1 2006-11-24 Brian Warner <warner@lothar.com>
3 * buildbot/clients/base.py (TextClient.not_connected): upon
4 UnauthorizedLogin failures, remind the user to connect to the
5 PBListener port instead of the slaveport.
6 (TextClient.disconnected): shut down more quietly
7 * docs/buildbot.texinfo (statuslog): add another reminder
9 * buildbot/scripts/runner.py (Options.subCommands): rename
10 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
12 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
13 reconfig command to follow twistd.log and print all of the lines
14 from the start of the config-file reload to its completion. This
15 should make it a lot easier to discover bugs in the config file.
16 Use --quiet to disable this behavior. This addresses half of
17 SF#1517975, the other half will be to add this same utility to
18 'buildbot start' and 'buildbot restart'.
19 * docs/buildbot.texinfo (Loading the Config File): same
22 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
23 method, it has been deprecated for a long time. Use
24 IBuilderControl.requestBuild instead.
25 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
26 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
27 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
28 * buildbot/test/test_control.py (Force.testForce): same
29 * buildbot/test/test_run.py: use requestBuild instead
31 * buildbot/clients/debug.py: replace 'Force Build' button with
32 'Request Build' (which just adds one to the queue), add Ping
33 Builder, add branch/revision fields to Request Build.
34 * buildbot/clients/debug.glade: same
35 * buildbot/master.py: update interface to match. This creates an
36 incompatibility between new debugclients and old buildmasters.
38 * buildbot/process/builder.py (Builder._attached): delay the call
39 to maybeStartBuild for a reactor turn, to avoid starting a build
40 in the middle of a reconfig (say, if the new Builder uses a new
41 slave which is already connected).
43 2006-11-23 Brian Warner <warner@lothar.com>
45 * buildbot/test/test_transfer.py: appease pyflakes
46 * buildbot/test/test_steps.py: same
48 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
49 keeps pyflakes from finding undefined names
51 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
52 Builder no longer induces a disconnect/reconnect cycle. This means
53 that any builds currently in progress will not be interrupted, and
54 any builds which are queued in the Builder will not be lost. This
55 is implemented by having the new Builder extract the state (i.e.
56 all pending Builds and any desired SlaveBuilders) from the old
58 (BotPerspective): refactor. The BotPerspective no longer keeps
59 track of all the Builders that want to use this slave; instead, it
60 asks the BotMaster each time it needs this list. This removes
61 addBuilder and removeBuilder. Clean up attached() to acquire all
62 the slave's information in a more atomic fashion. updateSlave() is
63 now the way to make sure the slave is using the right set of
64 Builders: just call it after everything else has been
66 (BotMaster): refactor, removing addBuilder/removeBuilder and
67 replacing them with an all-at-once setBuilders() call.
69 * buildbot/test/test_slaves.py (Reconfig): new test case to
70 exercise this functionality
71 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
72 * buildbot/slave/commands.py (WaitCommand): same
74 * docs/buildbot.texinfo (Loading the Config File): document the
77 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
78 SlaveBuilder to have its parent Builder changed.
79 (SlaveBuilder.isAvailable): new method to give access to state,
80 which is now a private attribute
81 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
82 the SlaveBuilder about how it is being used. These methods update
83 its internal state. buildFinished() is now the place that invokes
84 maybeStartBuild() on its parent Builder.
85 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
86 new Builder to take over for an old one, transferring state from
88 (Buider): refactor the way that SlaveBuilders are used to match,
89 giving them a bit more autonomy.
90 (Builder.buildFinished): this no longer calls maybeStartBuild():
91 instead the SlaveBuilder calls it on whoever its parent Builder is
92 at the time. This way, when an old Builder is replaced by a new
93 one, and there was a build in progress during the transition, when
94 that build finishes, it will be the new Builder that is told about
95 the newly available slave so it can start a new build.
97 * buildbot/process/base.py (Build.startBuild._release_slave): when
98 the Build finishes, tell the SlaveBuilder that they've been
101 * buildbot/status/builder.py (SlaveStatus): add some new setter
102 methods for use by BotPerspective, to keep some attributes more
105 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
106 called by the buildmaster.
107 (Bot.setBuilderList): instead, we locally announce any leftover
108 directories based upon which Builders we were told about. The
109 master doesn't really care; it's the local admin who may or may not
113 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
114 to allow use of python2.4 or whatever. This tool still requires
117 2006-11-19 Brian Warner <warner@lothar.com>
119 * NEWS (IStatusLog.readlines): more news items
121 2006-11-18 Brian Warner <warner@lothar.com>
123 * NEWS: start collecting items for the next release.
125 2006-11-04 Brian Warner <warner@lothar.com>
127 * buildbot/changes/bonsaipoller.py: apply updates from Ben
128 Hearsum. Closes SF#1590310.
129 * buildbot/test/test_bonsaipoller.py: and tests
131 * buildbot/status/tinderbox.py
132 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
133 status when the build results in WARNINGS. Patch from Dave
134 Liebreich. Closes SF#1587352.
136 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
137 linux-vs-osx behavior difference w.r.t. reading from files that
138 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
139 to Mark Rowe for the patch.
141 2006-10-15 Brian Warner <warner@lothar.com>
143 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
144 method name was misspelled in the interface definition. Thanks to
145 Roy Rapoport for the catch.
147 2006-10-13 Brian Warner <warner@lothar.com>
149 * docs/buildbot.texinfo (Adding LogObservers): update sample code
150 to match the great Steps renaming
152 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
153 Maybe I should run my own unit tests before recording a big
154 change. Good thing I've got a buildbot to remind me.
156 2006-10-12 Brian Warner <warner@lothar.com>
158 * buildbot/steps/transfer.py: rework __init__ and args setup
159 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
161 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
162 when opening the target file, only catch IOError (to report via
163 stderr/rc!=0), let the others be reported as normal exceptions
165 2006-10-08 Brian Warner <warner@lothar.com>
167 * contrib/svn_watcher.py: fix security holes by using proper argv
168 arrays and subprocess.Popen() rather than commands.getoutput().
169 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
170 is deprecated in favor of buildbot/changes/svnpoller.py, and will
171 probably be removed by the next release.
174 2006-10-04 Brian Warner <warner@lothar.com>
176 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
177 initial lines that weren't emitted by pyflakes. When the pyflakes
178 command is run under a Makefile, 'make' will echo the command it
179 runs to stdio, and that was getting logged as a "misc" warning.
180 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
181 * buildbot/test/test_steps.py (testPyFlakes3): another test
183 2006-10-01 Brian Warner <warner@lothar.com>
185 * buildbot/status/html.py (HtmlResource.render): if we get a
186 unicode object from our content() method, encode it into utf-8
187 like we've been claiming to all along. This allows the comments
188 and author names from svnpoller.py to be delivered properly.
190 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
191 de-unicodify filenames before creating the Change, because the
192 rest of buildbot is unlikely to handle them well. Leave the 'who'
193 field as a unicode object.. I don't think there's anything that
194 will break very soon, and it will probably nudge us towards
195 accepting unicode everywhere sooner or later. Stop using the
196 "date" field that comes out of SVN, since it is using the
197 repository's clock (and timezone) and what we care about is the
198 buildmaster's (otherwise Changes from the future show up later
199 than the builds they triggered).
200 * buildbot/test/test_svnpoller.py (Everything.test1): match the
203 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
204 Suvbersion repository polling ChangeSource. I've hacked it up
205 considerably: any bugs are entirely my own fault. Thank you
207 * buildbot/test/test_svnpoller.py: tests for it
208 * docs/buildbot.texinfo (SvnSource): document it
210 2006-09-30 Brian Warner <warner@lothar.com>
212 * buildbot/scheduler.py (Periodic): submit a reason= to the
213 BuildSet to indicate which Scheduler triggered the build. Thanks
214 to Mateusz Loskot for the suggestion.
216 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
218 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
219 changes: set self.loop in __init__, remove unused volatile=
221 * docs/buildbot.texinfo (.buildbot config directory): add more
222 docs on the .buildbot/options keys used by "buildbot try"
223 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
224 (Try.deliverJob): same
226 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
230 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
231 close the filehandle when we stop watching the file. Before, the
232 filehandle was only closed when the LogFileWatcher was
233 garbage-collected, which could be quite a while in the future. If
234 it was still open by the time the next build started, windows will
235 refuse to let the new build delete the old build/ directory. Fixes
236 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
237 #twisted for the catch.
239 2006-09-29 Brian Warner <warner@lothar.com>
241 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
244 2006-09-25 Brian Warner <warner@lothar.com>
246 * setup.py: the new buildbot.steps module wasn't being installed.
247 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
248 (testmsgs): add the extra stuff from buildbot/test/* so you can
249 run unit tests on an installed copy of buildbot, not just from
252 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
253 columns of 'svnlook changed' output contain status information, so
254 strip [:4] instead of [:6]. Depending upon what the status flags
255 were, this would sometimes lead to mangled filenames. Thanks to
256 Riccardo Magliocchetti for the patch. Closes SF#1545146.
258 * buildbot/steps/source.py (Monotone): initial Monotone support,
259 contributed by Nathaniel Smith. Still needs docs and tests, but
260 this code has been in use on the Monotone buildbot for a long
262 * buildbot/slave/commands.py (Monotone): slave-side support
263 * buildbot/changes/monotone.py (MonotoneSource): polling change
266 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
267 contributed a Change Source that polls a Bonsai server (a
268 kind of web-based viewcvs CGI script).
270 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
271 Hearsum contributed a status plugin which sends email in the same
272 format that Tinderbox does: this allows a number of tinderbox
273 tools to be driven by Buildbot instead. Thanks Ben!
275 2006-09-24 Brian Warner <warner@lothar.com>
277 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
278 Thanks to Robert Helmer for the patch.
280 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
281 BuildStatus about the buildslave name at the *beginning* of the
282 build, rather than at the end. Thanks to Alexander Lorenz for the
284 * buildbot/status/html.py (StatusResourceBuild.body): always
285 include the slavename in the build page, not just when the build
287 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
288 slavename in the email message
290 2006-09-21 Brian Warner <warner@lothar.com>
292 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
294 * docs/examples/glib_master.cfg: same
295 * docs/examples/hello.cfg: same
296 * docs/examples/twisted_master.cfg: same, update to current usage
298 2006-09-19 Brian Warner <warner@lothar.com>
300 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
301 (PyFlakes.createSummary): make it compatible with python-2.2
303 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
304 for at least the output-parsing parts of PyFlakes
306 2006-09-18 Brian Warner <warner@lothar.com>
308 * buildbot/steps/python.py: oops, fix import of StringIO
310 2006-09-17 Brian Warner <warner@lothar.com>
312 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
313 turns out that SVN-1.4.0 doesn't fail to update once you've
314 replaced a file with a directory, unlike older versions of SVN and
315 pretty much every other VC tool we support. Since what we really
316 care about is that the update succeeds anyway, stop checking that
317 the tree got clobbered and just assert that the build succeeded.
318 (VCBase.printLogs): add a utility function for debugging
320 * buildbot/process/step.py: oops, added extra imports by mistake
322 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
323 rstrip() on the first line coming out of the 'p4 describe'
324 process, to remove the stray ^M that Wade Brainerd reports seeing
325 in the 'when' field. Fixes SF#1555985.
327 * buildbot/master.py (BuildMaster.loadConfig): improve the error
328 message logged when c['schedulers'] is not right
329 * buildbot/scheduler.py (Scheduler.__init__): improve error
330 message when a Scheduler() is created with the wrong arguments
331 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
332 verify that these error messages are emitted
334 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
335 The idea is that all the base classes (like BuildStep and
336 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
337 will be a leftover backwards-compatibility file that only contains
338 aliases for the steps that were moved out to buildbot.steps.*
339 * lots: change imports to match
340 * buildbot/process/step.py: add a DeprecationWarning if it ever
343 2006-09-12 Brian Warner <warner@lothar.com>
345 * buildbot/scheduler.py (Scheduler.__init__): make sure that
346 builderNames= is actually a sequence, since if you happen to give
347 it a single builder-specification dictionary instead, it won't get
348 caught by the existing assert. Thanks to Brett Neely for the
351 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
353 * docs/buildbot.texinfo (Python BuildSteps): document them
354 (sendchange): include a link to PBChangeSource, since you need one
356 * buildbot/steps/shell.py: clean up test-case-name line, remove some
358 * buildbot/steps/dummy.py: same
360 2006-09-08 Brian Warner <warner@lothar.com>
362 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
363 BuildStep which lets you transfer files from the master to the
364 slave or vice versa. Thanks to Albert Hofkamp for the original
365 patch. Fixes SF#1504631.
366 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
368 (SlaveFileDownloadCommand): same
369 * docs/buildbot.texinfo (Transferring Files): document it
370 * buildbot/test/test_transfer.py: test it
371 * buildbot/test/runutils.py (StepTester): new utility class for
372 testing BuildSteps and RemoteCommands without Builds or Bots or PB
373 * buildbot/test/test_steps.py (CheckStepTester): validate that the
376 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
377 walk through StatusLogs one line at a time, mostly for the benefit
378 of ShellCommand.createSummary methods. You can either walk through
379 STDOUT or STDERR, but the default is STDOUT.
381 * buildbot/status/builder.py (LogFile.readlines): implement it.
382 Note that this is not yet memory-efficient, it just pulls the
383 whole file into RAM and then splits it up with a StringIO.
384 Eventually this should be a generator that only pulls chunks from
386 * buildbot/test/test_status.py (Log.testReadlines): test it
388 * docs/buildbot.texinfo: update to match changes
389 * buildbot/process/factory.py: stop using old definitions
390 * buildbot/process/process_twisted.py: same
391 * buildbot/test/test_*.py: same
393 * buildbot/process/step_twisted.py: move definition to..
394 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
395 relative-import mechanisms prevent this from being named 'twisted'
396 or 'python/twisted' as I would have preferred.
398 * buildbot/process/maxq.py: move definition to..
399 * buildbot/steps/maxq.py: .. here, leave a compatibility import
401 * buildbot/process/step.py: split the user-visible BuildSteps into
402 separate files, all under buildbot/steps/
403 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
404 * buildbot/steps/shell.py: this holds ShellCommand and friends
405 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
407 2006-09-05 Brian Warner <warner@lothar.com>
409 * lots: run pyflakes, removed a lot of unused imports, changed the
410 form of some conditional imports to remove false pyflakes
411 warnings. There are still a number of warnings left, mostly from
412 imports that are done for their side-effects.
413 * buildbot/test/test_vc.py: import twisted.python.failure, since it
416 2006-08-26 Brian Warner <warner@lothar.com>
418 * buildbot/test/test_locks.py (Unit.testLater): make the tests
419 compatible with twisted-1.3.0, for some reason I just can't seem
420 to let go of the past.
422 2006-08-25 Brian Warner <warner@lothar.com>
424 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
426 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
427 all logfiles= in startCommand(), rather than in start() . This
428 makes it easier to have the 'stdio' log come before any secondary
429 logfiles, which I feel makes the waterfall display more
431 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
432 from ShellCommand up into LoggingBuildStep
433 (LoggingBuildStep.__init__): move the handling of logfiles= from
434 ShellCommand up to LoggingBuildStep, because startCommand is
435 provided by LoggingBuildStep, whereas start() was specific to
436 subclasses like ShellCommand and Source. This removes code
437 duplication in those subclasses.
438 (ShellCommand.__init__): same
439 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
440 for a slave that's too old to understand logfiles= into a separate
441 method, so it can live in ShellCommand. The rest of
442 setupLogfiles() can live in LoggingBuildStep.
444 2006-08-24 Brian Warner <warner@lothar.com>
446 * buildbot/locks.py (BaseLock): you can now configure Locks to
447 allow multiple simultaneous owners. They still default to
448 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
450 * docs/buildbot.texinfo (Interlocks): document the new options
451 * buildbot/test/test_locks.py: add a bunch of new unit tests
452 * buildbot/process/base.py (Build.acquireLocks): locks now offer
453 waitUntilMaybeAvailable, not waitUntilAvailable
454 * buildbot/process/step.py (BuildStep.acquireLocks): same
455 * buildbot/master.py (BotMaster.getLockByID): real locks now use
456 the whole lockid in their constructor, not just the name. Also,
457 keep track of which real locks we've handed out by the full
458 lockid, not just class+name, otherwise changing just the maxCount=
459 in the master.cfg file would not actually cause a behavioral
462 2006-08-23 Brian Warner <warner@lothar.com>
464 * buildbot/__init__.py (version): bump to 0.7.4+ while between
466 * docs/buildbot.texinfo: same
468 2006-08-23 Brian Warner <warner@lothar.com>
470 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
471 * docs/buildbot.texinfo: set version to match
472 * NEWS: update for 0.7.4
473 * buildbot/slave/commands.py (command_version): mention that this
474 version (2.1) was released with buildbot-0.7.4
476 2006-08-22 Brian Warner <warner@lothar.com>
480 * CREDITS: new file, list of people who have helped. Thanks!
481 * MANIFEST.in: ship it
483 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
484 new diagrams, the user's manual is more informative than it was.
485 Start shipping the .html user's manual (and generated .png
487 * Makefile: update 'release' target to match
489 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
490 test.. I think the web-parts effort will render it pointless well
491 before it ever actually starts to work.
493 2006-08-20 Brian Warner <warner@lothar.com>
495 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
496 meaning of the prefix= argument. It is now just a string which is
497 stripped from the beginning of the filename. If prefix= is set but
498 not found on any given filename, that filename is ignored. If all
499 filenames in a Change are ignored, the Change is dropped. This is
500 much simpler than the previous sep= nonsense, and I should have
501 implemented it this way from the beginning. Effectively resolves
502 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
503 Gedminas for the catch and suggested fixes.
504 (ChangePerspective.perspective_addChange): implement the actual
506 * buildbot/test/test_changes.py (TestChangePerspective): test it
507 * docs/buildbot.texinfo (PBChangeSource): document it, explain
508 how to properly use prefix=
509 * docs/examples/twisted_master.cfg (source): update prefix= by
510 adding the trailing slash
513 * docs/examples/twisted_master.cfg: update to actual practice
515 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
516 update test case to match new link text.. the HREF has both a
517 class= setting and an enclosing [] pair that I didn't match in the
520 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
521 list of strings is preferred over a single string with embedded
523 (ShellCommand.description=): explain that either single strings or
524 a list of strings is acceptable, and why you might prefer one over
525 the other. Add an example. Fixes SF#1524659, thanks to Paul
526 Winkler for the catch.
527 (Build Steps): update to use f.addStep() rather than using s()
528 and the constructor list
530 * buildbot/process/step.py (ShellCommand): accept either a single
531 string or a list of strings in both description= and
533 * buildbot/test/test_steps.py (Steps.test_description): test it
534 * buildbot/test/runutils.py (makeBuildStep): support for that test
536 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
537 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
538 collecting the files and creating the patch.
540 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
541 per-step URLs that will be displayed on the waterfall display,
542 for things like the HTML output of code-coverage tools, when
543 the results are hosted elsewhere.
544 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
545 way to retrieve these URLs
546 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
547 the method to retrieve these URLs. Also provide backwards
548 compatibility for saved BuildStepStatus instances that didn't have
550 * buildbot/process/step.py (BuildStep.addURL): method to set these
551 URLs from within a BuildStep
552 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
553 (StepBox.getBox): give these external links a distinct CSS class
554 named "BuildStep external" so a .css file can display them
557 * buildbot/test/test_web.py (WaterfallSteps): test that we really
559 * buildbot/test/test_steps.py (Steps): test that we can all the
560 URLs. Also add a bunch of other tests on methods that can be
561 called from within BuildSteps
562 * buildbot/test/runutils.py (makeBuildStep): add utility function
564 2006-08-13 Brian Warner <warner@lothar.com>
566 * docs/buildbot.texinfo (BuildStep LogFiles): document them
568 2006-08-10 Brian Warner <warner@lothar.com>
570 * docs/buildbot.texinfo (Index of master.cfg keys): add another
571 index, this one of things like c['sources'] and c['schedulers']
572 (indices): it looks like my clever idea of putting the @fooindex
573 commands in between the @node and the @subsection (to make the
574 HREF anchor jump to slightly above the section title, which works
575 much better in html) confused texinfo horribly, so I'm moving the
576 index tags back to be just after the @subsection marker. I also
577 added extra lines between the @node/@section paragraph and the
578 index tags, since I think maybe texinfo wants to see these be
581 * docs/Makefile (images): make sure images get built when
583 * docs/images/Makefile: same
585 * buildbot/scripts/runner.py: rename 'buildbot master' to
586 'buildbot create-master', and 'buildbot slave' to 'buildbot
588 * docs/buildbot.texinfo: same
591 * docs/buildbot.texinfo: reimplement the "useful classes" index
592 with actual texinfo indices. The .info rendering is a bit
593 weird-looking but it works well, and the HTML rendering is quite
594 nice. This also puts the index targets in the regular flow of the
595 text, which is easier to maintain.
597 2006-08-06 Brian Warner <warner@lothar.com>
599 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
600 Kevin Turner to prefer the environ= argument be a list rather than
601 a string. If it is a list, it will be joined with a platform-local
602 os.pathsep delimiter, and then prepended to any existing
603 $PYTHONPATH value. This works better in cross-platform (i.e.
604 windows buildslaves) environments when you need to push multiple
605 directories onto the front of the path.
606 (SlaveShellCommand): documented the new magic
607 * docs/buildbot.texinfo (ShellCommand): documented the new magic
608 in a user-visible form
610 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
611 Turner to prefer lists over strings when creating/running VC
612 commands during unit tests. This is clearly necessary to survive
613 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
614 renamed the wq() function to qw() though, since that's how it's
615 spelled in perl. Eventually I'd prefer all commands to be
616 specified with lists.
618 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
619 which are deleted (or not yet created) correctly. Also add
620 failsafe code to not explode if the file-watching poller doesn't
621 get started. Thanks to JP Calderone for the catch and the poller
623 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
625 * buildbot/test/emitlogs.py: same
627 * NEWS: summarize recent changes
629 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
630 clause to avoid the "host key mismatch" warning
632 * buildbot/process/step_twisted.py (Trial.start): if the
633 buildslave is too old to understand logfiles=, fall back to
634 running 'cat _trial_temp/test.log' like before.
635 (Trial.commandComplete): same. this takes advantage of the
636 LoggingBuildStep refactoring to stall commandComplete long enough
637 to run a second RemoteShellCommand.
639 * buildbot/process/step.py (LoggingBuildStep.startCommand):
640 refactor command-completion handling, to allow methods like
641 commandComplete/createSummary/evaluateCommand to return Deferreds.
642 (LoggingBuildStep._commandComplete): delete the refactored method
643 (ShellCommand.setupLogfiles): if the buildslave is too old to
644 understand logfiles=, put a warning message both into twistd.log
645 and into the otherwise empty user-visible LogFiles.
647 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
648 callers to provide the slave-side logfile name, rather than
649 forcing it to come from the local name of the LogFile.
650 (BuildStep.getSlaveName): new method
652 * buildbot/process/base.py (Build.getSlaveName): new method, so
653 steps can find out which buildslave they're running on
655 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
656 to match the s/cvs_ver/command_version/ change
658 2006-08-05 Brian Warner <warner@lothar.com>
660 * buildbot/slave/commands.py (command_version): replace the CVS
661 auto-updated cvs_ver keyword with a manually-updated variable,
662 since CVS is no longer the master repository. Add a description of
663 the remote API change starting in this version (2.1), specifically
664 the fact that SlaveShellCommand now accepts 'initial_stdin',
665 'keep_stdin_open', and 'logfiles'.
667 2006-07-31 Brian Warner <warner@lothar.com>
669 * docs/buildbot.texinfo (System Architecture): Finally add lots of
670 diagrams to describe how the whole system fits together. The
671 images themselves are kept in SVG files, with ascii-art versions
672 in corresponding .txt files. Texinfo knows how to interpolate the
673 text version into .info files, reference the .png versions from
674 .html files, and include .eps versions in the .ps format.
675 * docs/images/Makefile: tools to create .png and .eps
676 * docs/images/*.svg: created pictures with Inkscape.
677 * .darcs-boring: ignore the generated .eps and .png files
679 2006-07-24 Brian Warner <warner@lothar.com>
681 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
682 Scheduler names, since they cause setServiceParent to explode
684 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
686 2006-07-20 Brian Warner <warner@lothar.com>
688 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
689 which runs the buildbot unit tests
691 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
692 classes that are useful in master.cfg
694 2006-07-15 Brian Warner <warner@lothar.com>
696 * Makefile (some-apidocs): new target to build only some epydocs
698 * setup.py: minor comment.. does the classifiers= argument prevent
699 the setup.py script from working on python2.2/2.3?
701 * buildbot/scripts/sample.cfg: update manhole example, arrange into
704 * buildbot/twcompat.py: fix minor typo in comments
706 * buildbot/manhole.py: move all Manhole-related code out to this
707 module. Implement SSH-based manholes (with TwistedConch), and move
708 to conch's nifty line-editing syntax-coloring REPL shell instead
709 of the boring non-editing monochromatic (and deprecated) old
711 * buildbot/master.py: remove all Manhole-related code
712 (BuildMaster.loadConfig._add): make sure the old manhole is
713 removed before we add the new one
714 * docs/buildbot.texinfo (Debug options): document new Manhole options
716 * buildbot/twcompat.py (_which): fix some epydoc issues
717 * buildbot/status/html.py (Waterfall.__init__): same
719 2006-06-29 Brian Warner <warner@lothar.com>
721 * buildbot/interfaces.py: get Interface from b.twcompat to hush
722 deprecation warnings under newer Twisteds (by using
723 zope.interface.Interface instead of old twisted.python.components
725 * buildbot/slave/interfaces.py: same
727 2006-06-28 Brian Warner <warner@lothar.com>
729 * buildbot/slave/commands.py (SVN): add --non-interactive to all
730 svn commands, so it will fail immediately instead of hanging while
731 it waits for a username/password to be typed in.
733 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
734 log message if the step was shut down
736 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
737 obsolete reference to mktap.
739 2006-06-20 Brian Warner <warner@lothar.com>
741 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
742 test to include new 'logfiles' argument sent from master to slave
744 2006-06-19 Brian Warner <warner@lothar.com>
746 * buildbot/process/step_twisted.py (Trial): track Progress from
747 _trial_temp/test.log too
749 * buildbot/process/step.py (OutputProgressObserver): generalize
750 the earlier StdioProgressObserver into an OutputProgressObserver
751 that can track LogFiles other than stdio.
752 (LoggingBuildStep.__init__): same
754 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
755 _trial_temp/test.log, not a separate 'cat' command. TODO: this
756 will fail under windows because of os.sep issues. It might have
757 worked before if 'cat' was doing cygwin path conversion.
759 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
760 creation of LogFileWatchers
761 (ShellCommand._startCommand): and record the files that were
762 watched in the 'headers' section of the ShellCommand output
764 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
765 need to actually pass it to the slave if you want it to work.
766 (ShellCommand): document it a bit
768 * buildbot/test/test_shell.py: new test to validate LogFiles
769 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
771 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
772 before printing the last batch of lines, to test that the polling
773 logic is working properly
775 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
776 handling, making it possible to track multiple logs for a single
777 RemoteCommand. The previous single logfile is now known as the
779 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
780 (RemoteShellCommand.__init__): accept logfiles=
781 (LoggingBuildStep.startCommand): stdio_log is now one of many
782 (ShellCommand): added logfiles= argument, as well as a class-level
783 .logfiles attribute, which will be merged together to figure out
784 which logfiles should be tracked. The latter maybe be useful for
785 subclasses of ShellCommand which know they will aways produce
786 secondary logfiles in the same location.
788 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
789 and closeStdin() methods, preparing to make it possible to write
790 to a ShellCommand's stdin at any time, not just at startup. These
791 writes are buffered if the child process hasn't started yet.
792 (LogFileWatcher): new helper class to watch arbitrary logfiles
793 while a ShellCommand runs. This class polls the file every two
794 seconds, and sends back 10k chunks to the buildmaster.
795 (ShellCommand): rename stdin= to initialStdin=, and add
796 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
798 (ShellCommand.addLogfile): LogFile text is sent in updates with a
799 key of "log" and a value of (logname, data).
800 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
801 'logfiles' to the master-visible args dictionary.
802 (SourceBase.doPatch): match s/stdin/initialStdin/ change
805 * buildbot/test/test_vc.py (Patch.testPatch): same
808 * buildbot/test/emit.py: write to a logfile in the current
809 directory. We use this to figure out what was used as a basedir
810 rather than looking to see which copy of emit.py gets run, so that
811 we can run the commands from inside _trial_temp rather than inside
813 * buildbot/test/subdir/emit.py: same
814 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
815 argument rather than running from buildbot/test/
816 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
817 rather than using an implicit setUp()
818 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
819 (ShellBase.testShell1, etc): use explicit path to emit.py instead
820 of assuming that we're running in buildbot/test/ (and that '.' is
823 * buildbot/slave/commands.py (Command.doStart): refactor Command
824 startup/completion a bit: now the SlaveBuilder calls doStart(),
825 which is not meant for overridding by subclasses, and doStart()
826 calls start(), which is. Likewise the SlaveBuilder calls
827 doInterrupt(), and subclasses override interrupt(). This also puts
828 responsibility for maintaining .running in Command rather than in
830 (Command.doInterrupt): same
831 (Command.commandComplete): same, this is called when the deferred
832 returned by start() completes.
833 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
834 (SlaveBuilder.remote_interruptCommand): same
835 (SlaveBuilder.stopCommand): same
837 2006-06-16 Brian Warner <warner@lothar.com>
839 * buildbot/test/test_shell.py: new test file to contain everything
840 relating to ShellCommand
841 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
842 multiple logfiles in realtime" feature, not yet implemented
843 * buildbot/test/emitlogs.py: support file for testLogFiles
844 * docs/buildbot.texinfo (ShellCommand): document the feature
846 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
848 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
849 for tests which exercise SlaveCommands in isolation.
851 * buildbot/test/test_slavecommand.py: Move some utilities like
852 SignalMixin and FakeSlaveBuilder from here ..
853 * buildbot/test/runutils.py: .. to here, so they can be used by
854 other test classes too
855 * buildbot/test/test_vc.py: more SignalMixin refactoring
856 * buildbot/test/test_control.py: same
857 * buildbot/test/test_run.py: and some rmtree refactoring
859 2006-06-15 Brian Warner <warner@lothar.com>
861 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
862 'testBranch' to match other VC tests and have the tests run in
863 roughly increasing order of dependency
865 * buildbot/test/test_steps.py (LogObserver): new test to verify
866 LogObservers can be created at various times and still get
867 connected up properly
869 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
870 to create BuildStepStatus instances that actually work.
872 * buildbot/process/step.py (LogObserver): add outReceived and
873 errReceived base methods, to be overridden
875 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
876 API to take a name instead of a step, reducing the coupling
877 somewhat. This returns the BuildStepStatus object so it can be
878 passed to the new Step, instead of jamming it directly into the
880 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
882 * buildbot/process/base.py (Build.setupBuild): use both methods
883 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
884 process a bit to match
886 2006-06-14 Brian Warner <warner@lothar.com>
888 * docs/buildbot.texinfo (Adding LogObservers): add some limited
889 docs on writing new LogObserver classes
890 (Writing New Status Plugins): brief docs on how Status Plugins fit
893 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
894 implement a LogObserver that counts how many unit tests have been
896 (Trial.__init__): wire it in
897 * buildbot/test/test_twisted.py (Counter): unit test for it
899 * buildbot/process/step_twisted.py (HLint.commandComplete): update
900 to new cmd.logs['stdio'] scheme
901 (Trial.commandComplete): same
902 (BuildDebs.commandComplete): same
904 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
905 LogFiles, instead of just a single one. The old single logfile is
906 now called "stdio". LoggedRemoteCommand no longer creates a
907 LogFile for you (the code to do that was broken anyway). If you
908 don't create a "stdio" LogFile, then stdout/stderr will be
910 (LogObserver): implement "LogObservers", which a BuildStep can add
911 to parse the output of a command in real-time. The primary use is
912 to provide more useful information to the Progress code, allowing
913 better ETA estimates.
914 (LogLineObserver): utility subclass which feeds complete lines to
915 the parser instead of bytes.
916 (BuildStep.progressMetrics): this is safer as a tuple
917 (BuildStep.setProgress): utility method, meant to be called by
919 (BuildStep.addLogObserver): new method, to be called at any time
920 during the BuildStep (even before any LogFiles have been created),
921 to attach (or schedule for eventual attachment) a LogObserver to a
923 (StdioProgressObserver): new LogObserver which replaces the old
924 "output" progress gatherer
925 (LoggingBuildStep.__init__): same
926 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
927 (LoggingBuildStep._commandComplete): must use logs['stdio']
928 instead of the old single ".log" attribute.
929 * buildbot/status/builder.py (LogFile): remove old logProgressTo
930 functionality, now subsumed into StdioProgressObserver
931 * buildbot/test/test_status.py (Subscription._testSlave_2): the
932 log name changed from "output" to "stdio".
935 * buildbot/interfaces.py (ILogFile): add the Interface used from
936 the BuildStep towards the LogFile
937 (ILogObserver): and the one provided by a LogObserver
938 * buildbot/status/builder.py (LogFile): implement it
940 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
941 HEADER constants here ..
942 * buildbot/status/builder.py (STDOUT): .. from here
944 2006-06-13 Brian Warner <warner@lothar.com>
946 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
947 compatibility with python2.2, which doesn't have the 'substr in
949 (TestP4Poller.makeTime): utility function to construct the
950 timestamp using the same strptime() approach as p4poller does. It
951 turns out that time.mktime() behaves slightly differently under
952 python2.2, probably something to do with the DST flag, and that
953 causes the test to fail under python2.2. (changing the mktime()
954 arguments to have dst=0 instead of -1 caused it to fail under
955 python2.3. Go figure.)
956 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
958 2006-06-12 Brian Warner <warner@lothar.com>
960 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
961 proper Perforce (P4) support. Many many thanks to Scott Lamb for
962 contributing such an excellent patch, including docs and unit
963 tests! This makes it *so* much easier to apply. I had to update
964 test_vc.py to handle some recent refactorings, but everything else
965 applied smoothly. The only remaining thing I'd like to fix would
966 be to remove the hard-wired port 1666 used by p4d, and allow it to
967 claim any unused port. This would allow two copies of the test
968 suite to run on the same host at the same time, as well as
969 allowing the test suite to run while a real (production) p4d was
970 running on the same host. Oh, and maybe we should add a warning to
971 step.P4 that gets emitted if the slave is too old to provide the
972 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
973 * buildbot/slave/commands.py (P4): same
974 (P4Sync): same, some minor updates
975 * buildbot/changes/p4poller.py: same
976 * docs/buildbot.texinfo: same
977 * buildbot/test/test_p4poller.py: same
978 * buildbot/test/test_vc.py (P4): same
980 * setup.py: add Trove classifiers for PyPI
982 2006-06-08 Brian Warner <warner@allmydata.com>
984 * buildbot/status/client.py
985 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
986 changing this from getCurrentBuild() to getCurrentBuilds(). Each
987 build needs to be IRemote'd separately, rather than IRemote'ing
988 the whole list at once. I can't wait until newpb's serialization
989 adapters make this unnecessary.
991 2006-06-06 Brian Warner <warner@lothar.com>
993 * buildbot/process/step.py (WithProperties): make this inherit
994 from ComparableMixin, so that reloading an unchanged config file
995 doesn't cause us to spuriously reload any Builders which use them.
996 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
999 2006-06-03 Brian Warner <warner@lothar.com>
1001 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1002 running py2exe on windows, contributed by Mark Hammond. Addresses
1003 SF#1401121, but I think we still need to include
1004 buildbot/scripts/sample.cfg
1005 * setup.py: include buildbot_service.py as a script under windows
1006 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1007 a py2exe application), get the icon/css datafiles from a different
1010 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1011 double-escape the build URL. Thanks to Olivier Bonnet for the
1012 patch. Fixes SF#1452801.
1014 2006-06-02 Brian Warner <warner@lothar.com>
1016 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1017 first six columns of 'svnlook' output, not just the first column,
1018 since property changes appear in the other five. Thanks to Olivier
1019 Bonnet for the patch. Fixes SF#1398174.
1021 2006-06-01 Brian Warner <warner@lothar.com>
1023 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1024 the fake build, so that title= has something to be set to
1026 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1027 attribute of the "Build #NN" link in the yellow start-the-build
1028 box to the build's reason. This means that you get a little
1029 tooltip explaining why the build was done when you hover over the
1030 yellow box. Thanks to Zandr Milewski for the suggestion.
1032 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1033 (Box.setETA): handle ETA=None (by stopping the timer)
1034 (Box.update): make the [soon] text less different than the usual
1035 text, so the rest of the text doesn't flop around so much. It
1036 would be awfully nice to figure out how to center this stuff.
1037 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1039 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1040 by default, so that any ShellCommand which fails marks the overall
1041 build as a failure. I should have done this from the beginning.
1042 Add flunkOnFailure=False to the arguments if you want to turn off
1045 2006-05-30 Brian Warner <warner@lothar.com>
1047 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1048 last-build/current-build/current-step. Show what step is currently
1049 running. Show ETA for both the overall build and the current step.
1050 Update GTK calls to modern non-deprecated forms. There's still a
1051 lot of dead code and debug noise to remove.
1053 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1054 shows up properly in status displays
1056 2006-05-28 Brian Warner <warner@lothar.com>
1058 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1059 build we use to verify that WithProperties works:
1061 ** set flunkOnFailure=True so that build failures get noticed
1062 ** set workdir='.' so that the build succeeds, otherwise it is trying
1063 to touch 'build/something', and 'build/' doesn't exist because
1064 usually that's created by a Source step
1065 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1066 this test somehow triggers, in which the 'touch' process becomes
1067 a zombie and we wait for th etimeout before giving up on it.
1069 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1070 to log the Build results and step logs to the twisted log.
1071 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1072 what went wrong if a build was expected to succeed but didn't.
1074 * buildbot/process/step_twisted.py (Trial): set the default
1075 trialMode to '--reporter=bwverbose', which specifies verbose
1076 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1077 '-to', but those are completely missing in modern Twisteds.
1079 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1080 a localhost-only port, to encourage better security
1082 * docs/buildbot.texinfo (Change Sources): mention
1085 * .darcs-boring: add a Darcs boringfile
1087 * README (REQUIREMENTS): stop claiming compatibility with
1090 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1093 2006-05-27 Brian Warner <warner@lothar.com>
1095 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1096 * docs/buildbot.texinfo: same
1098 2006-05-23 Brian Warner <warner@lothar.com>
1100 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1101 * docs/buildbot.texinfo: set version to match
1102 * NEWS: update for 0.7.3
1104 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1105 give a quick mapping from VC system to possible ChangeSources
1106 (Build Properties): add 'buildername'
1108 * buildbot/process/base.py (Build.setupStatus): oops, set
1109 'buildername' and 'buildnumber' properties
1110 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1113 2006-05-22 Brian Warner <warner@lothar.com>
1115 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1116 property interpolation better
1118 * README (INSTALLATION): remove old '-v' argument from recommended
1121 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1122 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1125 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1126 'svnversion' instead of grepping the output of 'svn info', much
1127 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1128 Bonnet for the suggestion.
1129 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1130 require the WC_PATH argument, so run 'svnversion .' instead.
1132 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1133 aren't supposed to have 'self' in their argument list
1135 2006-05-21 Brian Warner <warner@lothar.com>
1137 * buildbot/process/step.py (ShellCommand.start): make
1138 testInterpolate pass. I was passing the uninterpolated command to
1139 the RemoteShellCommand constructor
1140 (ShellCommand._interpolateProperties): oops, handle non-list
1141 commands (i.e. strings with multiple words separated by spaces in
1142 them) properly, instead of forgetting about them.
1144 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1145 to actually try to use build properties in a real build. This test
1147 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1148 to start and evaluate builds
1150 * buildbot/test/test__versions.py: add a pseudo-test to record
1151 what version of Twisted/Python/Buildbot are running. This should
1152 show up at the beginning of _trial_tmp/test.log, and exists to help
1153 debug other problems.
1155 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1156 a filename to be served as 'robots.txt' to discourage web spiders.
1157 Adapted from a patch by Tobi Vollebregt, thanks!
1158 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1159 (Waterfall.test_waterfall): tweak the way that filenames are put
1160 into the config file, to accomodate windows pathnames better.
1162 * docs/buildbot.texinfo (HTML Waterfall): document it
1164 * buildbot/process/process_twisted.py
1165 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1166 changed the build process. The new setup.py no longer takes the
1168 (FullTwistedBuildFactory.__init__): same
1169 (TwistedReactorsBuildFactory.__init__): same
1171 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1172 be placed in the [hooks] section of the central repository (the
1173 one that everybody pushes changes to).
1175 2006-05-20 Brian Warner <warner@lothar.com>
1177 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1178 .darcs-context file, use binary mode. I think this was causing a
1179 Darcs failure under windows.
1181 2006-05-19 Brian Warner <warner@lothar.com>
1183 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1184 use a timezone string of +0000 and gmtime, since this timestamp is
1185 sent to a buildmaster and %z is broken.
1187 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1188 string and localtime, since this timestamp will only be consumed
1189 locally, and %z is broken.
1191 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1192 gmtime, since this timestamp is returned to the buildmaster, and
1195 2006-05-18 Brian Warner <warner@lothar.com>
1197 * NEWS: update in preparation for next release
1199 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1200 setup-repository and do-we-have-the-vc-tools code into a separate
1201 "helper" class, which sticks around in a single module-level
1202 object. This seems more likely to continue to work in the future
1203 than having it hide in the TestCase and hope that TestCases stick
1204 around for a long time.
1206 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1207 addremove' has been deprecated in recent versions of mercurial, so
1208 use 'hg add' instead
1210 2006-05-07 Brian Warner <warner@lothar.com>
1212 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1213 operating under windows, move the file before opening it, since
1214 you can't rename a file that somebody has open.
1216 * buildbot/process/base.py (Build.setupBuild): if something goes
1217 wrong while creating a Step, log the name and arguments, since the
1218 error message when you get the number of arguments wrong is really
1221 2006-05-06 Brian Warner <warner@lothar.com>
1223 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1224 bugs in twisted-specific code not covered by my unit tests, this
1225 time use 'cmd' argument instead of self.cmd
1227 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1228 fix stupid braino: either use startwith or find()==0, not both.
1229 (TwistedReactorsBuildFactory.__init__): another dumb typo
1231 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1232 mark this test as TODO under windows, since process-killing seems
1233 dodgy there. We'll come back to this later and try to fix it
1236 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1237 and don't include a timezone
1238 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1239 This should avoid the windows-with-verbose-timezone-name problem
1241 (Patch.testPatch): add a test which runs 'patch' with less
1242 overhead than the full VCBase.do_patch sequence, to try to isolate
1243 a windows test failure. This one uses slave.commands.ShellCommand
1244 and 'patch', but none of the VC code.
1246 * buildbot/slave/commands.py (getCommand): use which() to find the
1247 executables for 'cvs', 'svn', etc. This ought to help under
1250 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1251 working directory before starting. If an earlier test failed, the
1252 leftover directory would mistakenly flunk a later test.
1253 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1254 Make sure that we use the right commandlines if which("tla") picks
1255 up "tla.exe" (as it does under windows).
1256 (TlaSupport.do_get): factor out this tla-vs-baz difference
1257 (TlaSupport.vc_create): more tla-vs-baz differences
1259 * buildbot/test/test_slavecommand.py
1260 (ShellBase.testShellMissingCommand): stop trying to assert
1261 anything about the error message: different shells on different
1262 OSes with different languages makes it hard, and it really isn't
1263 that interesting of a thing to test anyway.
1265 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1266 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1267 "Panther"), because it has a bug which flunks a couple tests in
1268 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1269 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1270 able to test that yet.
1272 2006-04-30 Brian Warner <warner@lothar.com>
1274 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1275 make sure child commands emit messages in english, so our regexps
1276 will match. Thanks to Nikaus Giger for identifying the problems.
1277 (VCBase._do_vctest_export_1): mode="export" is not responsible
1278 for setting the "got_revision" property, since in many cases it is
1279 not convenient to determine.
1280 (SVNSupport.capable): when running 'svn --version' to check for
1281 ra_local, we want error messages in english
1282 * buildbot/test/test_slavecommand.py
1283 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1284 to emit the error message in english
1286 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1287 the environment with $LC_ALL="C" so that Commands which need to
1288 parse the output of their child processes can obtain it in
1290 (SVN.parseGotRevision): call "svn info" afterwards instead of
1291 watching the output of the "svn update" or "svn checkout".
1292 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1293 (Arch.parseGotRevision): same
1294 (Bazaar.parseGotRevision): same
1295 (Mercurial.parseGotRevision): same
1297 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1298 $LC_ALL="C" when running commands under 'buildbot try', too
1300 * buildbot/test/__init__.py: remove the global os.environ()
1301 setting, instead we do it just for the tests that run commands and
1302 need to parse their output.
1304 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1305 remove the overly-short .timeout on this test, because non-DNotify
1306 platforms must fall back to polling which happens at 10 second
1307 intervals, so a 5 second timeout would never succeed.
1309 2006-04-24 Brian Warner <warner@lothar.com>
1311 * docs/buildbot.texinfo (Installing the code): update trial
1312 invocation, SF#1469116 by Niklaus Giger.
1313 (Attributes of Changes): updated branch-name examples to be
1314 a bit more realistic, SF#1475240 by Stephen Davis.
1316 * contrib/windows/buildbot2.bat: utility wrapper for windows
1317 developers, contributed by Nick Trout (after a year of neglect..
1318 sorry!). SF#1194231.
1320 * buildbot/test/test_vc.py (*.capable): store the actual VC
1321 binary's pathname in VCS[vcname], so it can be retrieved later
1322 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1323 strip out non-numeric timezone information, specifically the funky
1324 German string that his system produced that confuses CVS.
1325 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1326 allow Darcs tests to work on windows
1327 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1328 procutils.which() everywhere, to allow tryclient to work under
1329 windows. Also from Niklaus Giger, SF#1463394.
1331 * buildbot/twcompat.py (which): move the replacement for a missing
1332 twisted.python.procutils.which from test_vc.py to here, so it can
1333 be used in other places too (specifically tryclient.py)
1335 2006-04-23 Brian Warner <warner@lothar.com>
1337 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1338 bare buildbotURL/projectName line with a proper DIV, along with a
1339 CSS class of "title", from Stefan Seefeld (SF#1461675).
1340 (WaterfallStatusResource.body0): remove the redundant 'table'
1341 class from the table
1342 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1343 to the top-row TR, and class="Activity" to the second-row TR,
1344 rather than putting them in the individual TD nodes.
1346 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1347 'got_revision' build property for all VC systems that implement
1348 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1350 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1351 to determine which revision we actually obtained
1352 (CVS.parseGotRevision): implement this for CVS, which just means
1353 to grab a timestamp. Not ideal, and it depends upon the buildslave
1354 having a clock that is reasonably well syncronized with the server,
1355 but it's better than nothing.
1356 (SVN.parseGotRevision): implement it for SVN, which is accurate
1357 (Darcs.parseGotRevision): same
1358 (Arch.parseGotRevision): same
1359 (Bazaar.parseGotRevision): same
1360 (Mercurial.parseGotRevision): same
1362 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1363 keep a record of all non-stdout/stderr/header/rc status updates,
1364 for the benefit of RemoteCommands that send other useful things,
1366 (Source.commandComplete): put any 'got_revision' status values
1367 into a build property of the same name
1370 * buildbot/process/step_twisted.py (Trial): update to deal with
1371 new ShellCommand refactoring
1373 * docs/buildbot.texinfo (Build Properties): document new feature
1374 that allows BuildSteps to get/set Build-wide properties like which
1375 revision was requested and/or checked out.
1377 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1378 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1379 it. Note that this bumps the persistenceVersion of the saved Build
1380 object, so add the necessary upgrade-old-version logic to include
1381 an empty properties dict.
1383 * buildbot/process/base.py (Build.setProperty): implement it
1384 (Build.getProperty): same
1385 (Build.startBuild): change build startup to set 'branch',
1386 'revision', and 'slavename' properties at the right time
1388 * buildbot/process/step.py (BuildStep.__init__): change setup to
1389 require 'build' argument in a better way
1390 (LoggingBuildStep): split ShellCommand into two pieces, for better
1391 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1392 a single RemoteCommand that sends stdout/stderr status text. It
1393 also provides the usual commandComplete / createSummary /
1394 evaluateCommand / getText methods to be overridden...
1395 (ShellCommand): .. whereas ShellCommand is specifically for
1396 running RemoteShellCommands. Other shell-like BuildSteps (like
1397 Source) can inherit from LoggingBuildStep instead of ShellCommand
1398 (WithProperties): marker class to do build-property interpolation
1399 (Source): inherit from LoggingBuildStep instead of ShellCommand
1402 * buildbot/test/test_properties.py: test new functionality
1404 2006-04-21 Brian Warner <warner@lothar.com>
1406 * buildbot/test/test_vc.py: rename testBranch to
1407 testCheckoutBranch to keep the tests in about the right
1410 2006-04-18 Brian Warner <warner@lothar.com>
1412 * docs/buildbot.texinfo (PBListener): improve cross-references
1413 between PBListener and 'buildbot statusgui', thanks to John Pye
1416 2006-04-17 Brian Warner <warner@lothar.com>
1418 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1419 running under Twisted-1.3.0, otherwise skipped tests are reported
1422 * all: use isinstance() instead of 'type(x) is foo', suggested by
1425 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1426 oops, fix a brain-fade from the other week, when making the
1427 addStep changes. I changed all the __init__ upcalls to use the
1428 wrong superclass name.
1429 (FullTwistedBuildFactory.__init__): same
1430 (TwistedDebsBuildFactory.__init__): same
1431 (TwistedReactorsBuildFactory.__init__): same
1432 (TwistedBuild.isFileImportant): use .startswith for clarity,
1433 thanks to Neal Norwitz for the suggestions.
1435 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1436 changes, then deliver them over PB to a remote buildmaster.
1438 * contrib/svnpoller.py: added script by John Pye to poll a remote
1439 SVN repository (by running 'svn log') from a cronjob, and run
1440 'buildbot sendchange' to deliver the changes to a remote
1442 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1443 modification of svnpoller.py), same purpose, but this one loops
1444 internally (rather than expecting to run from a cronjob) and works
1446 * contrib/README.txt: same
1448 2006-04-11 Brian Warner <warner@lothar.com>
1450 * all: fix a number of incorrect names and missing imports, thanks
1451 to Anthony Baxter for the patch.
1452 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1453 remove unused buggy method.
1454 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1455 comes from shutil, not "shutils"
1456 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1457 (Arch.checkSlaveVersion): same
1458 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1460 * buildbot/process/step_twisted2.py: add some missing imports
1461 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1462 this code used to live in twisted.internet.defer
1464 2006-04-10 Brian Warner <warner@lothar.com>
1466 * buildbot/process/step.py (Mercurial): add Mercurial support
1467 * buildbot/slave/commands.py (Mercurial): same
1468 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1469 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1470 not yet tested, but 'try' support *is* covered
1471 * docs/buildbot.texinfo (Mercurial): document it
1473 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1474 some debugging messages (turned off)
1475 * buildbot/test/test_vc.py: improve debug messages
1477 2006-04-07 Brian Warner <warner@lothar.com>
1479 * buildbot/test/test_vc.py (which): define our own which() in case
1480 we can't import twisted.python.procutils, because procutils doesn't
1481 exist in Twisted-1.3
1483 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1484 of SlaveLocks for performance tests
1486 * docs/examples/twisted_master.cfg: update to match current usage
1488 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1489 password, p4 binary, pollinterval, maximum history to check.
1490 Patch from an anonymous sf.net contributor, SF#1219384.
1491 * buildbot/process/step.py (P4Sync.__init__): add username,
1492 password, and client arguments.
1493 * buildbot/slave/commands.py (P4Sync): same
1495 2006-04-05 Brian Warner <warner@lothar.com>
1497 * buildbot/process/factory.py (BuildFactory.addStep): new method
1498 to add steps to a BuildFactory. Use it instead of f.steps.append,
1499 and you can probably avoid using the s() convenience function.
1500 Patch from Neal Norwitz, sf.net #1412605.
1501 (other): update all factories to use addStep
1502 * buildbot/process/process_twisted.py: update all factories to use
1505 2006-04-03 Brian Warner <warner@lothar.com>
1507 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1508 work under windows too. Adapted from a patch by Niklaus Giger,
1509 addresses SF#1463399.
1511 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1512 spawned commands emit parseable results in english and not some
1513 other language. Patch from Niklaus Giger, SF#1463395.
1515 * README (INSTALLATION): discourage users from running unit tests on
1516 a "network drive", patch from Niklaus Giger, SF#1463394.
1518 2006-03-22 Brian Warner <warner@lothar.com>
1520 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1521 function to turn a repository-relative pathname into a (branch,
1522 branch-relative-filename) tuple. Change this function to handle
1523 the branch naming policy used by your Subversion repository.
1524 Thanks to AllMyData.com for sponsoring this work.
1526 2006-03-16 Brian Warner <warner@lothar.com>
1528 * buildbot/scripts/sample.cfg: add python-mode declaration for
1529 vim. Thanks to John Pye for the patch.
1531 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1532 command line, mention the importance of running 'crontab' as the
1533 buildmaster/buildslave user. Thanks to John Pye for the catch.
1535 2006-03-13 Brian Warner <warner@lothar.com>
1537 * buildbot/status/words.py (IRC): add an optional password=
1538 argument, which will be sent to Nickserv in an IDENTIFY message at
1539 login, to claim the nickname. freenode requires this before the
1540 bot can sent (or reply to) private messages. Thanks to Clement
1541 Stenac for the patch.
1542 * docs/buildbot.texinfo (IRC Bot): document it
1544 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1545 larger than chunkSize. Fixes SF#1349253.
1546 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1547 (Log.testConsumer): update to match new internal chunking behavior
1549 2006-03-12 Brian Warner <warner@lothar.com>
1551 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1553 * buildbot/test/test_maildir.py (MaildirTest): rename the
1554 'timeout' method, as it collides with trial's internals
1556 * buildbot/scripts/runner.py: add 'buildbot restart' command
1557 (stop): don't sys.exit() out of here, otherwise restart can't work
1558 * docs/buildbot.texinfo (Shutdown): document it
1560 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1561 * buildbot/status/html.py (Waterfall.__init__): same
1562 * buildbot/process/builder.py (Builder.startBuild): same
1563 * buildbot/process/base.py (BuildRequest): same
1564 * buildbot/sourcestamp.py (SourceStamp): same
1565 * buildbot/scheduler.py (Nightly): same
1567 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1569 * docs/buildbot.texinfo: same
1571 2006-02-17 Brian Warner <warner@lothar.com>
1573 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1574 * docs/buildbot.texinfo: set version number to match
1575 * NEWS: update for 0.7.2
1577 2006-02-16 Brian Warner <warner@lothar.com>
1579 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1581 2006-02-09 Brian Warner <warner@lothar.com>
1583 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1584 add text to explain per-build branch parameters
1585 * NEWS: mention --umask
1587 2006-02-08 Brian Warner <warner@lothar.com>
1589 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1591 (SlaveOptions.optParameters): add --umask, to make it possible to
1592 make buildslave-generated files (including build products) be
1595 * buildbot/slave/bot.py (BuildSlave.startService): same
1597 2006-01-23 Brian Warner <warner@lothar.com>
1599 * buildbot/status/builder.py: urllib.quote() all URLs that include
1600 Builder names, so that builders can include characters like '/'
1601 and ' ' without completely breaking the resulting HTML. Thanks to
1602 Kevin Turner for the patch.
1603 * buildbot/status/html.py: same
1604 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1606 * NEWS: update in preparation for upcoming release
1608 2006-01-18 Brian Warner <warner@lothar.com>
1610 * docs/examples/twisted_master.cfg: update to match the Twisted
1611 buildbot: remove python2.2, switch to exarkun's buildslaves,
1612 disable the .deb builder until we figure out how to build twisted
1613 .debs from SVN, add some ktrace debugging to the OS-X build
1614 process and remove the qt build, remove threadless builders,
1615 change freebsd builder to use landonf's buildslave.
1617 2006-01-12 Brian Warner <warner@lothar.com>
1619 * buildbot/master.py (Manhole.__init__): let port= be a strports
1620 specification string, but handle a regular int for backwards
1621 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1622 used in master.cfg to limit connections to just the local host.
1623 (BuildMaster.loadConfig): same for c['slavePortnum']
1624 * buildbot/scheduler.py (Try_Userpass.__init__): same
1625 * buildbot/status/client.py (PBListener.__init__): same
1626 * buildbot/status/html.py (Waterfall.__init__): same, for both
1627 http_port and distrib_port. Include backwards-compatibility checks
1628 so distrib_port can be a filename string and still mean unix:/foo
1629 * docs/buildbot.texinfo (Setting the slaveport): document it
1630 (Debug options): same
1631 (HTML Waterfall): same
1634 * buildbot/test/test_config.py (ConfigTest): test it
1636 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1637 slaveport's disownServiceParent deferred to fire before opening
1638 the new one. Fixes an annoying bug in the unit tests.
1640 2006-01-03 Brian Warner <warner@lothar.com>
1642 * buildbot/master.py (BuildMaster): remove the .schedulers
1643 attribute, replacing it with an allSchedulers() method that looks
1644 for all IService children that implement IScheduler. Having only
1645 one parent/child relationship means fewer opportunities for bugs.
1646 (BuildMaster.allSchedulers): new method
1647 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1648 also fix ugly bug that caused any config-file reload to
1649 half-forget about the earlier Schedulers, causing an exception
1650 when a Change arrived and was handed to a half-connected
1651 Scheduler. The exception was in scheduler.py line 54ish:
1652 self.parent.submitBuildSet(bs)
1653 exceptions.AttributeError: 'NoneType' object has no attribute
1655 (BuildMaster.addChange): update to use allSchedulers()
1657 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1658 to work properly with twisted-1.3.0, where you must explicitly
1659 include the __implements__ from parent classes
1660 (BaseScheduler.__repr__): make it easier to distinguish distinct
1662 (BaseUpstreamScheduler.__implements__): same
1664 * buildbot/status/builder.py (Status.getSchedulers): update to
1666 * buildbot/test/test_run.py (Run.testMaster): same
1667 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1668 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1669 make sure Scheduler instances are left alone when an identical
1670 config file is reloaded
1671 (ConfigElements.testSchedulers): make sure Schedulers are properly
1674 * Makefile (TRIALARGS): my local default Twisted version is now
1675 2.1.0, update the trial arguments accordingly
1677 2005-12-22 Brian Warner <warner@lothar.com>
1679 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1682 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1683 addChange in the parent class, although I suspect this should be
1684 fixed better in the future.
1686 2005-11-26 Brian Warner <warner@lothar.com>
1688 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1689 explode when branch==None, thanks to Kevin Turner for the catch
1690 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1693 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1695 * docs/buildbot.texinfo: same
1697 2005-11-26 Brian Warner <warner@lothar.com>
1699 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1700 * docs/buildbot.texinfo: set version number to match
1702 2005-11-26 Brian Warner <warner@lothar.com>
1704 * NEWS: update for 0.7.1
1706 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1707 sure that unsubscribe works even if we never sent an ETA update.
1708 Also, don't explode on duplicate unsubscribe.
1709 (BuildStepStatus.addLog): make the convenience "return self"-added
1710 watcher automatically unsubscribe when the Step finishes.
1711 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1712 (BuildStatus.stepStarted): same auto-unsubscribe
1713 (BuilderStatus.buildStarted): same auto-unsubscribe
1715 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1717 (IStatusReceiver.stepStarted): same
1718 (IStatusReceiver.logStarted): same
1720 * buildbot/test/test_run.py (Status): move the Status test..
1721 * buildbot/test/test_status.py (Subscription): .. to here
1723 2005-11-25 Brian Warner <warner@lothar.com>
1725 * NEWS: more updates
1727 * buildbot/locks.py: fix the problem in which loading a master.cfg
1728 file that changes some Builders (but not all of them) can result
1729 in having multiple copies of the same Lock. Now, the real Locks
1730 are kept in a table inside the BotMaster, and the Builders/Steps
1731 use "LockIDs", which are still instances of MasterLock and
1732 SlaveLock. The real Locks are instances of the new RealMasterLock
1733 and RealSlaveLock classes.
1734 * buildbot/master.py (BotMaster.getLockByID): new method to
1735 convert LockIDs into real Locks.
1736 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1737 into real Locks before building
1738 * buildbot/process/step.py (BuildStep.startStep): same
1739 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1740 exercises the problem
1743 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1744 what Schedulers are available
1746 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1747 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1748 'cron'-style build scheduling at certain times of day, week,
1750 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1752 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1753 handling: treat self.fileIsImportant more as an attribute that
1754 contains a callable than as a method. If the attribute is None,
1755 don't call it and assume all filenames are important. It is still
1756 possible to provide a fileIsImportant method in a subclass,
1758 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1760 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1761 test using AnyBranchScheduler with fileIsImportant=None
1763 2005-11-24 Brian Warner <warner@lothar.com>
1765 * buildbot/test/test_config.py (StartService): don't claim a fixed
1766 port number, instead set slavePort=0 on the first pass, figure out
1767 what port was allocated, then switch to a config file that uses
1770 * buildbot/master.py (BuildMaster.loadConfig): close the old
1771 slaveport before opening the new one, because unit tests might
1772 replace slavePort=0 with the same allocated portnumber, and if we
1773 don't wait for the old port to close first, we get a "port already
1774 in use" error. There is a tiny race condition here, but the only
1775 threat is from other programs that bind (statically) to the same
1776 port number we happened to be allocated, and only if those
1777 programs use SO_REUSEADDR, and only if they get control in between
1780 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1782 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1783 deleted ChangeSources before adding any new ones
1784 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1785 compare_attrs, to make sure that a config-file reload does not
1786 unnecessarily replace an unmodified ChangeSource instance
1787 * buildbot/test/test_config.py (ConfigTest.testSources): update
1789 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1790 mean "don't build anything", and add a warning if it gets used
1791 because it isn't actually useful.
1793 * contrib/svn_buildbot.py: update example usage to match the port
1794 number that gets used by the PBChangeSource
1795 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1797 2005-11-22 Brian Warner <warner@lothar.com>
1799 * NEWS: start collecting items for next release
1801 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1802 revisions are strings
1803 (P4Sync.computeSourceRevision): same
1805 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1806 to the Buildbot's overall status page
1807 (StatusResourceBuilder.body): same
1809 2005-11-15 Brian Warner <warner@lothar.com>
1811 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1812 config-file loading, specifically to make sure old StatusTargets
1813 are finished shutting down before new ones start up (thus
1814 resolving a bug in which changing the Waterfall object would fail
1815 because both new and old instances were claiming the same
1816 listening port). Also load new Schedulers after all the new
1817 Builders are set up, in case they fire off a new build right away.
1818 * buildbot/test/test_config.py (StartService): test it
1820 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1821 the branch name to the mail body
1823 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1824 Without it, a config-file reload fails to update an existing
1826 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1827 username/passwd to compare_attrs, for the same reason
1828 * buildbot/status/html.py (Waterfall): add favicon to
1829 compare_attrs, same reason
1831 2005-11-05 Brian Warner <warner@lothar.com>
1833 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1834 baserev before stuffing it in the jobfile. This resolves problems
1835 under SVN (and probably Arch) where revisions are expressed as
1836 numbers. I'm inclined to use string-based revisions everywhere in
1837 the future, but this fix should be safe for now. Thanks to Steven
1838 Walter for the patch.
1840 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1841 binary mode when opening pickle files, to make windows work
1842 better. Thanks to Dobes Vandermeer for the catch.
1843 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1844 (BuilderStatus.getBuildByNumber): same
1845 (Status.builderAdded): same
1846 * buildbot/master.py (BuildMaster.loadChanges): same
1848 * buildbot/util.py (Swappable): delete unused leftover code
1850 * buildbot/process/step.py (SVN): when building on a non-default
1851 branch, add the word "[branch]" to the VC step's description, so
1852 it is obvious that we're not building the usual stuff. Likewise,
1853 when we are building a specific revision, add the text "rNNN" to
1854 indicate what that revision number is. Thanks to Brad Hards and
1855 Nathaniel Smith for the suggestion.
1856 (Darcs.startVC): same
1857 (Arch.startVC): same
1858 (Bazaar.startVC): same
1860 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1861 typo, caught by Mark Dillavou, closes SF#1216636.
1863 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1864 about a test to add some day
1866 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1867 the 'full-2.3' build, and the 'reactors' build is now run under
1868 python-2.4 because the buildslave no longer has gtk/etc bindings
1869 for earlier versions.
1871 2005-11-03 Brian Warner <warner@lothar.com>
1873 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1874 method, takes an IBuildStatus and rebuilds it. It might make more
1875 sense to add this to IBuildControl instead, but that instance goes
1876 away completely once the build has finished, and resubmitting
1877 builds can take place weeks later.
1878 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1879 * buildbot/status/html.py (StatusResourceBuild): also stash an
1880 IBuilderControl so we can use resubmitBuild.
1881 (StatusResourceBuild.body): render "resubmit" button if we can.
1882 Also add hrefs for each BuildStep
1883 (StatusResourceBuild.rebuild): add action for "resubmit" button
1884 (StatusResourceBuilder.getChild): give it an IBuilderControl
1886 * buildbot/status/builder.py (Status.getURLForThing): change the
1887 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1888 that live as targets of buttons like "stop" and "rebuild" can't
1890 * buildbot/status/builder.py (Status.getURLForThing): same
1891 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1892 (StepBox.getBox): same
1893 * buildbot/test/test_web.py (GetURL): same
1896 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1897 exclusivity checks after Source.__init__ upcall, so misspelled
1898 arguments will be reported more usefully
1899 (Darcs.__init__): same
1901 2005-10-29 Brian Warner <warner@lothar.com>
1903 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1904 builder. Move the Try scheduler off to a separate port.
1906 2005-10-27 Brian Warner <warner@lothar.com>
1908 * buildbot/clients/gtkPanes.py
1909 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1910 to cause the app to crash, now they don't.
1912 * buildbot/clients/debug.py: display the buildmaster's location
1913 in the window's title bar
1915 2005-10-26 Brian Warner <warner@lothar.com>
1917 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
1918 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
1919 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
1921 * buildbot/status/html.py (td): put a single non-breaking space
1922 inside otherwise empty <td> elements, as a workaround for buggy
1923 browsers which would optimize them away (along with any associated
1924 styles, like the kind that create the waterfall grid borders).
1925 Patch from Frerich Raabe.
1927 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
1928 argv-list as an argument, defaulting to ["-to"], which is
1929 appropriate for the Trial that comes with Twisted-2.1.0 and
1930 earlier. The Trial in current Twisted SVN wants
1931 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
1932 defaults to an empty list.
1933 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
1934 match it, now that trialMode= is a list instead of a single string
1936 * buildbot/__init__.py (version): bump to 0.7.0+ while between
1938 * docs/buildbot.texinfo: same
1940 2005-10-24 Brian Warner <warner@lothar.com>
1942 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
1943 * docs/buildbot.texinfo: set version number to match
1945 2005-10-24 Brian Warner <warner@lothar.com>
1947 * README: update for 0.7.0
1949 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
1951 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
1952 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
1953 send the branch= argument unless the user really provided one, to
1954 retain compatibility with older buildmasters that don't accept
1956 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
1959 * docs/buildbot.texinfo: update lots of stuff
1961 * buildbot/scripts/runner.py (sendchange): add a --branch argument
1962 to the 'buildbot sendchange' command
1963 * buildbot/clients/sendchange.py (Sender.send): same
1964 * buildbot/changes/pb.py (ChangePerspective): same
1965 * buildbot/test/test_changes.py (Sender.testSender): test it
1967 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
1968 'default_branch' argument names to 'baseURL' and 'defaultBranch',
1969 for consistency with other BuildStep arguments that use camelCase.
1970 Well, at least more of them use camelCase (like flunkOnWarnings)
1971 than don't.. I wish I'd picked one style and stuck with it
1972 earlier. Annoying, but it's best done before the release, since
1973 these arguments didn't exist at all in 0.6.6 .
1975 * buildbot/test/test_vc.py (SVN.testCheckout): same
1976 (Darcs.testPatch): same
1977 * docs/buildbot.texinfo (SVN): document the change
1978 (Darcs): same, add some build-on-branch docs
1979 * docs/examples/twisted_master.cfg: match change
1981 * buildbot/process/step.py (BuildStep): rename
1982 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
1983 how it is normally used.
1984 * buildbot/test/test_steps.py (Version.checkCompare): same
1986 * buildbot/process/step.py (CVS.startVC): refuse to build
1987 update/copy -style builds on a non-default branch with an old
1988 buildslave (<=0.6.6) that doesn't know how to do it properly. The
1989 concern is that it will do a VC 'update' in an existing tree when
1990 it is supposed to be switching branches (and therefore clobbering
1991 the tree to do a full checkout), thus building the wrong source.
1992 This used to be a warning, but I think the confusion it is likely
1993 to cause warrants making it an error.
1994 (SVN.startVC): same, also make mode=export on old slaves an error
1995 (Darcs.startVC): same
1996 (Git.startVC): improve error message for non-Git-enabled slaves
1997 (Arch.checkSlaveVersion): same. continue to emit a warning when a
1998 specific revision is built on a slave that doesn't pay attention
1999 to args['revision'], because for slowly-changing trees it will
2000 probably do the right thing, and because we have no way to tell
2001 whether we're asking it to build the most recent version or not.
2002 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2004 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2005 that 'master' is in host:portnum format, to catch errors sooner
2007 2005-10-23 Brian Warner <warner@lothar.com>
2009 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2010 when creating the list of warning messages, include the line
2011 immediately after each WARNING: line, since that's usually where
2012 the file and line number wind up.
2014 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2019 2005-10-22 Brian Warner <warner@lothar.com>
2021 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2022 patch from Brad Hards
2023 * buildbot/status/classic.css: same
2024 * buildbot/test/test_web.py (Waterfall): match changes
2026 * buildbot/test/test_steps.py (BuildStep.setUp): set
2027 nextBuildNumber so the test passes
2028 * buildbot/test/test_status.py (MyBuilder): same
2030 * buildbot/status/html.py (StatusResourceBuild.body): revision
2031 might be numeric, so stringify it before html-escapifying it
2032 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2033 timer for the upcoming build
2034 * buildbot/status/classic.css: add background-color attributes for
2035 offline/waiting/building classes
2037 * buildbot/status/builder.py (BuildStatus): derive from
2038 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2039 the default (i.e. unknown) .slavename to "???" instead of None,
2040 since even unknown slavenames need to be printed eventually.
2041 (BuilderStatus): also derive from styles.Versioned . More
2042 importantly, determine .nextBuildNumber at creation/unpickling
2043 time by scanning the directory of saved BuildStatus instances and
2044 choosing one larger than the highest-numbered one found. This
2045 should fix the problem where random errors during upgrades cause
2046 the buildbot to forget about earlier builds. .nextBuildNumber is
2047 no longer stored in the pickle.
2048 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2049 at least log the error. Also call Builder.determineNextBuildNumber
2050 once the basedir is set.
2052 * buildbot/master.py (BuildMaster.loadChanges): do
2053 styles.doUpgrade afterwards, in case I decide to make Changes
2054 derived from styles.Versioned some day and forget to make this
2058 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2059 when running under older pythons (<2.3) in which the shlex module
2060 doesn't have a 'split' function.
2062 * buildbot/process/step.py (ShellCommand.start): make
2063 errorMessages= be a list of strings to stuff in the log before the
2064 command actually starts. This makes it easier to flag multiple
2065 warning messages, e.g. when the Source steps have to deal with an
2067 (CVS.startVC): handle slaves that don't handle multiple branches
2068 by switching into 'clobber' mode
2069 (SVN.startVC): same. Also reject branches without base_url
2070 (Darcs.startVC): same. Also reject revision= in older slaves
2071 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2072 (Bazaar.startVC): same, and test for baz separately than for arch
2074 * buildbot/slave/commands.py (cvs_ver): document new features
2076 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2077 (BuildStep.slaveVersionNewEnough): more useful utility method
2078 * buildbot/test/test_steps.py (Version): start testing it
2080 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2081 the 'force' command requires python2.3, for the shlex.split method
2083 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2084 since we don't use it anymore. The Twisted buildbot uses a
2087 2005-10-21 Brian Warner <warner@lothar.com>
2089 * buildbot/process/process_twisted.py: rework all BuildFactory
2090 classes to take a 'source' step as an argument, instead of
2091 building up the SVN instance in the factory.
2092 * docs/examples/twisted_master.cfg: enable build-on-branch by
2093 providing a base_url and default_branch
2095 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2096 control over --branch and --revision, not that they are always
2098 * buildbot/status/html.py (StatusResourceBuilder.force): same
2099 (StatusResourceBuild.body): display SourceStamp components
2101 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2102 IRC 'force' command, so it can be shared with an eventual
2103 command-line-tool 'buildbot force' mode.
2104 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2106 2005-10-20 Brian Warner <warner@lothar.com>
2108 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2110 * docs/examples/twisted_master.cfg: update to use Schedulers
2112 * buildbot/scripts/sample.cfg: update with Schedulers
2114 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2115 method specifically for use by HTML "force build" button and the
2116 IRC "force" command. Raises an immediate error if there are no
2118 (IBuilderControl.requestBuild): make this just submit a build, not
2119 try to check for existing slaves or set up any when-finished
2120 Deferreds or anything.
2121 * buildbot/process/builder.py (BuilderControl): same
2122 * buildbot/status/html.py (StatusResourceBuilder.force): same
2123 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2124 * buildbot/test/test_slaves.py: same
2125 * buildbot/test/test_web.py: same
2127 2005-10-19 Brian Warner <warner@lothar.com>
2129 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2130 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2132 2005-10-18 Brian Warner <warner@lothar.com>
2134 * buildbot/status/html.py: provide 'status' argument to most
2135 StatusResourceFOO objects
2136 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2137 and Logfiles" section to make the Build page into a more-or-less
2138 comprehensive source of status information about the build
2140 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2141 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2143 2005-10-17 Brian Warner <warner@lothar.com>
2145 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2146 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2147 out what to do about other projects: the correct options for
2148 recent Twisteds will not work for older ones.
2150 2005-10-15 Brian Warner <warner@lothar.com>
2152 * buildbot/status/builder.py (Status.getURLForThing): add method
2153 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2154 use this in email/IRC status clients to make them more useful, by
2155 providing the end user with hints on where to learn more about the
2156 object being reported on.
2157 * buildbot/test/test_web.py (GetURL): tests for it
2159 2005-10-14 Brian Warner <warner@lothar.com>
2161 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2162 fix bug resulting from deferredResult changes
2164 2005-10-13 Brian Warner <warner@lothar.com>
2166 * buildbot/test/test_changes.py: remove use of deferredResult
2167 * buildbot/test/test_config.py: same
2168 * buildbot/test/test_control.py: same
2169 * buildbot/test/test_status.py: same
2170 * buildbot/test/test_vc.py: this is the only remaining use, since
2171 it gets used at module level. This needs to be replaced by some
2172 sort of class-level run-once routine.
2174 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2176 * lots: implement multiple slaves per Builder, which means multiple
2177 current builds per Builder. Some highlights:
2178 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2179 of (state,currentBuilds) instead of (state,currentBuild)
2180 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2181 (IBuildStatus.getSlavename): new method, so you can tell which
2182 slave got used. This only gets set when the build completes.
2183 (IBuildRequestStatus.getBuilds): new method
2185 * buildbot/process/builder.py (SlaveBuilder): add a .state
2186 attribute to track things like ATTACHING and IDLE and BUILDING,
2188 (Builder): .. the .slaves attribute here, which has been turned
2189 into a simple list of available slaves. Added a separate
2190 attaching_slaves list to track ones that are not yet ready for
2192 (Builder.fireTestEvent): put off the test-event callback for a
2193 reactor turn, to make tests a bit more consistent.
2194 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2195 ping fails due to an exception. This needs work, I'm worried that
2196 a code error could lead to a constantly re-connecting slave.
2197 Especially since I'm trying to move to a distinct remote_ping
2198 method, separate from the remote_print that we currently use.
2199 (BuilderControl.requestBuild): return a convenience Deferred that
2200 provides an IBuildStatus when the build finishes.
2201 (BuilderControl.ping): ping all connected slaves, only return True
2202 if they all respond.
2204 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2205 reconnect when we shut down.
2207 * buildbot/status/builder.py: implement new methods, convert
2208 one-build-at-a-time methods to handle multiple builds
2209 * buildbot/status/*.py: do the same in all default status targets
2210 * buildbot/status/html.py: report the build's slavename in the
2211 per-Build page, report all buildslaves on the per-Builder page
2213 * buildbot/test/test_run.py: update/create tests
2214 * buildbot/test/test_slaves.py: same
2215 * buildbot/test/test_scheduler.py: remove stale test
2217 * docs/buildbot.texinfo: document the new builder-specification
2218 'slavenames' parameter
2220 2005-10-12 Brian Warner <warner@lothar.com>
2222 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2223 report failure correctly, causing Dependent builds to run when
2224 they shouldn't have.
2225 * buildbot/status/builder.py (BuildSetStatus): same
2226 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2227 (Set.testSuccess): test the both-pass case too
2228 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2229 fix this test: it was ending too early, masking the failure before
2230 (Logger): specialized StatusReceiver to make sure the dependent
2231 builds aren't even started, much less completed.
2233 2005-10-07 Brian Warner <warner@lothar.com>
2235 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2236 bot.SlaveBuilder being disowned in the middle of a build
2238 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2239 this inherit from StatusReceiver. Also upcall in __init__. This
2240 fixes the embarrasing crash when the new buildSetSubmitted method
2241 is invoked and Waterfall/etc don't implement their own.
2242 * buildbot/test/test_run.py: add a TODO note about a test to catch
2243 just this sort of thing.
2245 * buildbot/process/builder.py (Builder.attached): remove the
2246 already-attached warning, this situation is normal. Add some
2247 comments explaining it.
2249 2005-10-02 Brian Warner <warner@lothar.com>
2251 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2252 OverflowError when setting up dnotify, because some 64-bit systems
2253 have problems with signed-vs-unsigned constants and trip up on the
2254 DN_MULTISHOT flag. Patch from Brad Hards.
2256 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2258 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2259 progressMetrics, description, descriptionDone to the 'parms' list,
2260 and make use the 'parms' list from the implementation class
2261 instead of only BuildStep to initialize the parameters. This
2262 allows buildbot.process.factory.s() to initialize all the parms,
2263 not just those defined in directly by BuildStep.
2265 2005-09-03 Brian Warner <warner@lothar.com>
2267 * NEWS: start adding items for the next release
2269 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2270 python2.2 tests, change 'Quick' builder to only use python2.3
2272 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2274 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2275 the "Ping Builder" button if the build control is available; the
2276 user sees an exception otherwise
2278 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2280 2005-09-01 Brian Warner <warner@lothar.com>
2282 * buildbot/interfaces.py (IBuilderStatus.getState): update
2283 signature, point out that 'build' can be None
2284 (IBuildStatus.getETA): point out ETA can be none
2286 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2288 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2290 2005-08-31 Brian Warner <warner@lothar.com>
2292 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2293 update to match correct signature: removed 'eta' argument
2294 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2296 2005-08-30 Brian Warner <warner@lothar.com>
2298 * buildbot/status/builder.py (LogFile): remove the assertion that
2299 blows up when you try to overwrite an existing logfile, instead
2300 just emit a warning. This case gets hit when the buildmaster is
2301 killed and doesn't get a chance to write out the serialized
2302 BuilderStatus object, so the .nextBuildNumber attribute gets out
2305 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2306 the 'buildbot sendchange' arguments, for the Darcs context file
2307 * docs/buildbot.texinfo (sendchange): document it
2309 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2310 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2311 (IStatus.getSchedulers): new method
2312 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2313 (Status.getSchedulers): implement
2314 * buildbot/process/builder.py (Builder): maintain
2315 BuilderStatus.pendingBuilds
2316 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2317 (TryBase.addChange): Try schedulers should ignore Changes
2319 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2320 for 'try' on CVS/SVN
2321 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2323 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2324 report status properly.
2325 (Try.createJob): implement unique buildset IDs
2327 * buildbot/status/client.py (StatusClientPerspective): add a
2328 perspective_getBuildSets method for the benefit of jobdir-style
2330 * docs/buildbot.texinfo (try): more docs
2331 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2334 2005-08-18 Brian Warner <warner@lothar.com>
2336 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2337 actually work. It's functional but still kind of clunky. Also, it
2338 only works with the pb-style.. needs to be made to work with the
2341 * buildbot/status/client.py (RemoteBuildSet): new class
2342 (RemoteBuildRequest): same
2343 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2344 object, not the internal BuildStatus object.
2345 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2346 outside of the usual buildStarted() return value.
2347 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2349 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2350 (Try_Userpass_Perspective.perspective_try): return a remotely
2351 usable BuildSetStatus object
2353 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2354 isStarted()/waitUntilStarted()
2356 2005-08-16 Brian Warner <warner@lothar.com>
2358 * buildbot/status/builder.py: implement IBuildSetStatus and
2359 IBuildRequestStatus, wire them into place.
2360 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2361 methods into the BuildSetStatus object.
2362 * buildbot/interfaces.py: same
2363 (IStatus.getBuildSets): new method to get pending BuildSets
2364 (IStatusReceiver.buildsetSubmitted): new method which hears about
2366 * buildbot/master.py (BuildMaster.submitBuildSet): same
2367 * buildbot/process/base.py (BuildRequest): same, replace
2368 waitUntilStarted with subscribe/unsubscribe
2369 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2370 subscribe instead of waitUntilStarted
2371 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2373 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2375 * buildbot/test/test_buildreq.py: update for new code
2376 * buildbot/test/test_control.py (Force.testRequest): same
2379 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2380 for Darcs to not use the tempfile module, so it works under
2381 python-2.2 too. We really didn't need the full cleverness of that
2382 module, since the slave has exclusive control of its own builddir.
2384 2005-08-15 Brian Warner <warner@lothar.com>
2386 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2387 for CVS trees. It doesn't work for non-trunk branches,
2389 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2392 * Makefile: make it easier to test against python2.2
2394 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2395 tearDown2, so things like Arch can unregister archives as they're
2396 shutting down. The previous subclass-override-tearDown technique
2397 resulted in a nested maybeWait() and test failures under
2400 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2401 where we can (Arch), add a branch= argument to set the branch used
2403 (BazExtractor): extract the branch too
2404 (TlaExtractor): same
2405 * buildbot/scripts/runner.py (TryOptions): add --branch
2406 * docs/buildbot.texinfo (try): document --branch/try_branch
2408 * buildbot/slave/commands.py (Darcs): implement get-revision for
2409 Darcs, so that 'try' will work. This requires the tempfile module
2412 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2413 of revisions, branches, and 'try' in the process.
2415 2005-08-11 Brian Warner <warner@lothar.com>
2417 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2418 this, it got broken at some point in the last few releases
2419 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2420 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2421 specifically the removal of ETA information from the tuple
2423 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2426 * docs/buildbot.texinfo (try): document both --builder and
2427 'try_builders' in .buildbot/options
2428 * buildbot/scripts/runner.py (TryOptions): add --builder,
2429 accumulate the values into opts['builders']
2430 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2431 * buildbot/test/test_runner.py (Try): add some quick tests to make
2432 sure 'buildbot try --options' and .buildbot/options get parsed
2433 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2434 use --builder control
2436 * docs/buildbot.texinfo (try): add --port argument to PB style
2438 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2439 actual SourceStamp. Still need to extract a branch name, somehow.
2440 (Try): finish implementing the try client side, still need a UI
2441 for specifying which builders to use
2442 (Try.getopt): factor our options/config-file reading
2443 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2445 * buildbot/test/test_vc.py: match SourceStampExtractor change
2447 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2448 causes the twisted log to be sent to stderr
2450 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2452 2005-08-10 Brian Warner <warner@lothar.com>
2454 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2455 style is 90% done, still missing status reporting or waiting for
2456 the buildsets to finish, and it is completely untested.
2458 * buildbot/trybuild.py: delete file, move contents to ..
2459 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2460 * buildbot/test/test_vc.py: match the move
2462 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2463 of the TryScheduler, no buildsetID or status-tracking support yet
2464 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2466 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2467 possible to set the basedir after __init__ time, so it is easier
2468 to use as a Service-child of the BuildMaster instance
2470 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2471 that delivers messages to its Service parent instead of requiring
2472 a subclass to be useful. This turns out to be much easier to build
2475 * buildbot/scripts/tryclient.py (createJob): utility code to
2476 create jobfiles, will eventually be used by 'buildbot try'
2478 2005-08-08 Brian Warner <warner@lothar.com>
2480 * docs/buildbot.texinfo (try): add docs on the
2481 as-yet-unimplemented Try scheduler
2483 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2484 * buildbot/test/test_scheduler.py: .. here
2485 (Scheduling.testTryJobdir): add placeholder test for 'try'
2487 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2488 addEntry merging (>=chunkSize) behavior
2489 (Log.testConsumer): update to handle new callLater(0) behavior
2491 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2492 both the MAX_LENGTH bugfix and the resumeProducing hang.
2494 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2495 put off the actual resumeProducing for a moment with
2496 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2497 causes large logfiles to hang midway through.
2499 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2500 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2501 and to improve memory usage when streaming the file out to a web
2503 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2504 make this work cleanly
2506 2005-08-03 Brian Warner <warner@lothar.com>
2508 * buildbot/trybuild.py: new file for 'try' utilities
2509 (getSourceStamp): run in a tree, find out the baserev+patch
2510 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2511 implemented for SVN and Darcs, still working on Arch. I don't know
2512 how to make CVS work yet.
2514 * docs/buildbot.texinfo: document the 'buildbot' command-line
2515 tool, including the not-yet-implemented 'try' feature, and the
2516 in-flux .buildbot/ options directory.
2518 2005-07-20 Brian Warner <warner@lothar.com>
2520 * buildbot/locks.py: added temporary id() numbers to Lock
2521 descriptions, to track down a not-really-sharing-the-Lock bug
2523 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2525 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2526 needed for python2.2 compatibility
2527 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2528 are from the __future__
2530 2005-07-19 Brian Warner <warner@lothar.com>
2532 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2533 message when schedulers use unknown builders
2535 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2536 SlaveLock('name') and MasterLock('name') are distinct
2538 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2539 c['schedulers'] in such a way that we can actually accept
2541 * buildbot/test/test_config.py: check it
2543 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2544 utility method to *all* the Schedulers
2545 (Periodic.listBuilderNames): same
2547 * docs/buildbot.texinfo (Interlocks): update chapter to match
2550 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2551 to make sure that c['sources'], c['schedulers'], and c['status']
2552 are all lists of the appropriate objects, and that the Schedulers
2553 all point to real Builders
2554 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2555 'listBuilderNames' utility method to support this
2556 * buildbot/scheduler.py: implement the utility method
2557 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2559 * docs/buildbot.texinfo: add some @cindex entries
2561 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2562 if it wasn't already set: most tla commands will fail unless one
2564 (Arch.createRepository): and disable bazaar's revision cache, since
2565 they cause test failures (the multiple repositories we create all
2566 interfere with each other through the cache)
2568 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2569 bring it properly up to date with twisted-2.0 test guidelines
2571 * buildbot/master.py (BuildMaster): remove references to old
2572 'interlock' module, this caused a bunch of post-merge test
2574 * buildbot/test/test_config.py: same
2575 * buildbot/process/base.py (Build): same
2577 * buildbot/test/test_slaves.py: stubs for new test case
2579 * buildbot/scheduler.py: add test-case-name tag
2580 * buildbot/test/test_buildreq.py: same
2582 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2583 unnecessary init code
2584 (Bot.remote_setBuilderList): match it
2586 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2588 * buildbot/changes/mail.py (parseSyncmail): update comment
2590 * buildbot/test/test_slavecommand.py: disable Shell tests on
2591 platforms that don't suport IReactorProcess
2593 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2594 all places where we open logfiles. It causes OS-X to open the file
2595 in some weird mode that that prevents us from mixing reads and
2596 writes to the same filehandle, which we depend upon to implement
2597 _generateChunks properly. This change doesn't appear to break
2598 win32, on which "b" and "t" are treated differently but a missing
2599 flag seems to be interpreted as "t".
2601 2005-07-18 Brian Warner <warner@lothar.com>
2603 * buildbot/slave/commands.py (ShellCommand): overhaul
2604 error-handling code, to try and make timeout/interrupt work
2605 properly, and make win32 happier
2606 * buildbot/test/test_slavecommand.py: clean up, stop using
2607 reactor.iterate, add tests for timeout and interrupt
2608 * buildbot/test/sleep.py: utility for a new timeout test
2610 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2611 code from the local-usebranches branch
2613 2005-07-17 Brian Warner <warner@lothar.com>
2615 * buildbot/process/process_twisted.py
2616 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2617 minutes, to match the other twisted BuildFactories, and don't
2618 excuse failures in c/qt/win32 reactors any more.
2620 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2621 'freebsd' builders, since the buildslaves have been unavailable
2624 2005-07-13 Brian Warner <warner@lothar.com>
2626 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2627 build-on-branch feature
2629 * buildbot/process/step.py (Darcs.__init__): add base_url and
2630 default_branch arguments, just like SVN
2631 (Arch.__init__): note that the version= argument is really the
2634 * buildbot/slave/commands.py (SourceBase): keep track of the
2635 repository+branch that was used for the last checkout in
2636 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2637 match, we clobber the directory and perform a fresh checkout
2638 rather than trying to do an in-place update. This should protect
2639 us against trying to get to branch B by doing an update in a tree
2640 obtained from branch A.
2641 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2642 (SVN.setup): same, just the svnurl
2643 (Darcs.setup): same, just the repourl
2644 (Arch.setup): same, arch coordinates (url), version, and
2645 buildconfig. Also pull the buildconfig from the args dictionary,
2646 which we weren't doing before, so the build-config was effectively
2648 (Arch.sourcedirIsUpdateable): don't try to update when we're
2649 moving to a specific revision: arch can't go backwards, so it is
2650 safer to just clobber the tree and checkout a new one at the
2652 (Bazaar.setup): same sourcedata as Arch
2654 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2655 use maybeWait, to work with twisted-1.3.0 and twcompat
2656 (Dependencies.testRun_Pass): same
2658 * buildbot/test/test_vc.py: rearrange, cleanup
2660 * buildbot/twcompat.py: add defer.waitForDeferred and
2661 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2662 can work under twisted-1.3.0 .
2664 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2665 now created at setUp time. This increases the runtime of the test
2666 suite considerably (from 91 seconds to 151), but it removes the
2667 need for an offline tarball, which should solve a problem I've
2668 seen where the test host has a different version of svn than the
2669 tarball build host. The new code also validates that mode=update
2670 really picks up recent commits. This approach will also make it
2671 easier to test out branches, because the code which creates the VC
2672 branches is next to the code which uses them. It will also make it
2673 possible to test some change-notification hooks, by actually
2674 performing a VC commit and watching to see the ChangeSource get
2677 2005-07-12 Brian Warner <warner@lothar.com>
2679 * docs/buildbot.texinfo (SVN): add branches example
2680 * docs/Makefile (buildbot.ps): add target for postscript manual
2682 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2683 * buildbot/test/test_locks.py: same
2685 * buildbot/process/step.py (Darcs): comment about default branches
2687 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2688 c['interlocks'] in the config file, complain if it is present.
2689 Scan all locks in c['builders'] to make sure the Locks they use
2691 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2692 add some tests to check for non-uniquely-named Locks
2693 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2694 since the unique-Lock validation code requires it now
2696 * buildbot/locks.py: fix test-case-name
2698 * buildbot/interlock.py: remove old file
2700 2005-07-11 Brian Warner <warner@lothar.com>
2702 * buildbot/test/test_interlock.py: rename to..
2703 * buildbot/test/test_locks.py: .. something shorter
2705 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2706 versions (after 2.0.1) changed internet.TCPClient to shut down the
2707 connection in stopService. Change the code to handle this
2710 * buildbot/process/base.py (Build): handle whole-Build locks
2711 * buildbot/process/builder.py (Builder.compareToSetup): same
2712 * buildbot/test/test_interlock.py: make tests work
2714 * buildbot/process/step.py (BuildStep.startStep): complain if a
2715 Step tries to claim a lock that's owned by its own Build
2716 (BuildStep.releaseLocks): typo
2718 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2719 file reloads don't replace unchanged Builders
2721 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2722 rewrite to cover new Locks instead of old c['interlocks']
2723 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2727 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2728 start the master and connect the buildslave
2730 * buildbot/process/step.py (FailingDummy.done): finish with a
2731 FAILURE status rather than raising an exception
2733 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2734 stringify a BuildRequest.reason that is None
2736 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2738 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2739 allow scheduler.Dependent to work
2740 * buildbot/buildset.py (BuildSet): set .reason and .results
2742 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2743 slaves, to make the test stop hanging. It still fails, of course,
2744 because I haven't even started to implement Locks.
2746 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2748 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2749 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2750 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2751 (Dependent): new class for downstream build dependencies
2752 * buildbot/test/test_dependencies.py: tests (still failing)
2754 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2756 2005-07-07 Brian Warner <warner@lothar.com>
2758 * buildbot/test/runutils.py (RunMixin): factored this class out..
2759 * buildbot/test/test_run.py: .. from here
2760 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2761 added new buildbot.locks tests (which all hang right now)
2762 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2763 * buildbot/process/step.py: claim/release per-BuildStep locks
2765 * docs/Makefile: add 'buildbot.html' target
2767 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2768 interpreted as "HEAD", so that all VC steps can accept branch=None
2769 and have it mean the "default branch".
2771 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2773 2005-07-07 Brian Warner <warner@lothar.com>
2775 * docs/examples/twisted_master.cfg: update to match current usage
2777 * docs/buildbot.texinfo (System Architecture): comment out the
2778 image, it doesn't exist yet and just screws up the HTML manual.
2780 2005-07-05 Brian Warner <warner@lothar.com>
2782 * debian/.cvsignore: oops, missed one. Removing leftover file.
2784 2005-06-17 Brian Warner <warner@lothar.com>
2786 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2787 changed its output in 1.2.0, don't mistakenly think that the
2788 subversion we find isn't capable of supporting our tests.
2790 * debian/*: remove the debian/ directory and its contents, to make
2791 life easier for the proper Debian maintainer
2793 * Makefile (release): same
2795 2005-06-07 Brian Warner <warner@lothar.com>
2797 * everything: create a distinct SourceStamp class to replace the
2798 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2799 Changed the signature of Source.startVC to include the revision
2800 information (instead of passing it through self.args). Implement
2801 branches for SVN (now only Darcs/Git is missing support). Add more
2804 2005-06-06 Brian Warner <warner@lothar.com>
2806 * everything: rearrange build scheduling. Create a new Scheduler
2807 object (configured in c['schedulers'], which submit BuildSets to a
2808 set of Builders. Builders can now use multiple slaves. Builds can
2809 be run on alternate branches, either requested manually or driven
2810 by changes. This changed some of the Status classes. Interlocks
2811 are out of service until they've been properly split into Locks
2812 and Dependencies. treeStableTimer, isFileImportant, and
2813 periodicBuild have all been moved from the Builder to the
2815 (BuilderStatus.currentBigState): removed the 'waiting' and
2816 'interlocked' states, removed the 'ETA' argument.
2818 2005-05-24 Brian Warner <warner@lothar.com>
2820 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2821 erroneously abandons the connection (in clientConnectionFailed)
2822 for non-UserErrors, which means that if we lose the connection due
2823 to a network problem or a timeout, we'll never try to reconnect.
2824 Fix this by not upcalling to the buggy parent method. Note:
2825 twisted-2.0 fixes this, but the function only has 3 lines so it
2826 makes more sense to copy it than to try and detect the buggyness
2827 of the parent class. Fixes SF#1207588.
2829 * buildbot/changes/changes.py (Change.branch): doh! Add a
2830 class-level attribute to accomodate old Change instances that were
2831 pickled before 0.6.5 (where .branch was added for new Changes).
2832 This fixes the exception that occurs when you try to look at an
2833 old Change (through asHTML).
2835 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2838 2005-05-23 Brian Warner <warner@lothar.com>
2840 * buildbot/__init__.py (version): release 0.6.6
2842 2005-05-23 Brian Warner <warner@lothar.com>
2844 * NEWS: update for 0.6.6 release
2845 * debian/changelog: same
2847 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2848 before starting: this was done by twistd back when we spawned it,
2849 now that we're importing the pieces and running them in the
2850 current process, we have to do it ourselves. This allows
2851 master.cfg to import files from the same directory without
2852 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2853 Stichele for the catch.
2854 (Options.opt_version): Add a --version command (actually, just make
2855 the existing --version command emit Buildbot's version too)
2857 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2858 fix to make this behave like other LogFiles, this time to handle
2859 existing LogFiles on disk. (add the missing .upgrade method)
2860 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2862 2005-05-21 Brian Warner <warner@lothar.com>
2864 * buildbot/test/test_runner.py (Create.testMaster): match the
2865 rawstring change in runner.py:masterTAC
2867 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2868 TwistedWords is installed
2869 * buildbot/test/test_status.py: same, with TwistedMail
2871 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2872 some old, deprecated, and removed config keys). This should enable
2873 you to use the base buildbot functionality with Twisted-2.0.0 when
2874 you don't also have TwistedWeb and TwistedWords installed
2876 2005-05-20 Brian Warner <warner@lothar.com>
2878 * buildbot/scripts/runner.py (run): call sendchange(), not
2879 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2880 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2881 (stop): don't wait for process to die when sending SIGHUP
2882 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2883 directory name gets interpreted, which you don't want
2886 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2889 2005-05-18 Brian Warner <warner@lothar.com>
2891 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2893 2005-05-18 Brian Warner <warner@lothar.com>
2895 * README: update for 0.6.5
2896 * debian/changelog: same
2898 * buildbot/changes/changes.py: rename tag= to branch=, since
2899 that's how we're using it, and my design for the upcoming "build a
2900 specific branch" feature wants it. also, tag= was too CVS-centric
2901 * buildbot/changes/mail.py (parseSyncmail): same
2902 * buildbot/process/base.py (Build.isBranchImportant): same
2903 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2904 * docs/buildbot.texinfo (Attributes of Changes): same
2906 * NEWS: update tag=, update for upcoming release
2908 2005-05-17 Brian Warner <warner@lothar.com>
2910 * buildbot/scripts/runner.py (stop): actually poll once per
2911 second, instead of re-killing the poor daemon once per second.
2912 Sleep briefly (0.1s) before the first poll, since there's a good
2913 chance we can avoid waiting the full second if the daemon shuts
2914 down quickly. Also remove the sys.exit() at the end.
2915 (start): remove the unneighborly sys.exit()
2917 * Makefile: improve permission-setting to not kick Arch so badly
2919 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
2920 default --keepalive=600, since it doesn't hurt very much, and it's
2921 a hassle to discover that you need it.
2922 * buildbot/test/test_runner.py (Create.testSlave): test it
2924 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
2925 IRC bot about EXCEPTION
2927 * buildbot/status/client.py (PBListener): upcall more correctly
2929 * buildbot/process/base.py (Build.allStepsDone): if a step caused
2930 an exception mark the overall build with EXCEPTION, not SUCCESS
2932 * buildbot/scripts/runner.py (makefile_sample): remove the leading
2934 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
2935 * Makefile: update some release-related stuff
2937 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
2938 gets called when there isn't actually an active process, just end
2939 the Command instead of blowing up. I don't know how it gets into
2940 this state, but the twisted win32 buildslave will sometimes hang,
2941 and when it shakes its head and comes back, it thinks it's still
2942 running a Command. The next build causes this command to be
2943 interrupted, but the lack of self.process.pid breaks the interrupt
2946 * NEWS: document changes since the last release
2948 * buildbot/scripts/runner.py (start): change 'buildbot start' to
2949 look for Makefile.buildbot instead of a bare Makefile . The
2950 'buildbot start' does not install this file, so you have to
2951 manually copy it if you want to customize startup behavior.
2952 (createMaster): change 'buildbot master' command to create
2953 Makefile.sample instead of Makefile, to create master.cfg.sample
2954 instead of master.cfg (requiring you to copy it before the
2955 buildmaster can be started). Both sample files are kept up to
2956 date, i.e. they are overwritten if they have been changed. The
2957 'buildbot.tac' file is *not* overwritten, but if the new contents
2958 don't match the old, a 'buildbot.tac.new' file is created and the
2959 user is warned. This seems to be a much more sane way to handle
2960 startup files. Also, don't sys.exit(0) when done, so we can run
2961 unit tests against it.
2962 (createSlave): same. Don't overwrite the sample info/ files.
2963 * buildbot/scripts/sample.mk: remove. the contents were pulled
2964 into runner.py, since they need to match the behavior of start()
2968 * docs/buildbot.texinfo (Launching the daemons): document it
2969 * buildbot/test/test_runner.py (Create): test it
2971 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
2972 version that can handle string-in-string tests, because otherwise
2973 python-2.2 fails the tests. It'd be tremendous if Trial's test
2974 took two strings under 2.2 too.
2976 * everything: fixed all deprecation warnings when running against
2977 Twisted-2.0 . (at least all the ones in buildbot code, there are a
2978 few that come from Twisted itself). This involved putting most of
2979 the Twisted-version specific code in the new buildbot.twcompat
2980 module, and creating some abstract base classes in
2981 buildbot.changes.base and buildbot.status.base (which might be
2982 useful anyway). __implements__ is a nuisance and requires an ugly
2983 'if' clause everywhere.
2985 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
2986 delay before finishing the test: it seems that smtp.sendmail
2987 doesn't hang up on the server, so we must wait a moment so it can
2988 hang up on us. This removes the trial warning about an unclean
2991 2005-05-16 Brian Warner <warner@lothar.com>
2993 * buildbot/process/step.py (Source): add 'retry' argument. It is a
2994 tuple of (delay, repeats).
2995 * buildbot/test/test_vc.py (Retry): test it
2996 * docs/buildbot.texinfo (Source Checkout): document it
2997 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
2998 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
2999 doVCFull() are handled by re-trying the checkout (after a delay)
3000 some number of times.
3001 (ShellCommand._startCommand): make header lines easier to read
3003 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3005 (WebTest.test_logfile): make sure master gets shut down, silences
3006 some "unclean reactor" test errors
3008 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3009 reactor once after shutdown, something in certain versions of
3010 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3011 fails, svn-trunk is ok.
3013 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3014 second win32 error message
3016 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3017 validating the ETA, so the tests don't fail on slow systems
3019 2005-05-15 Brian Warner <warner@lothar.com>
3021 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3022 the new LogFile class, so upgrading works properly
3023 (LogFileProducer.resumeProducing): survive resumeProducing after
3024 we've exhausted the chunkGenerator
3026 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3028 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3029 (Log.testUpgrade): same
3031 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3032 Builds and logs with a cron job.
3034 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3035 of the old non-offline LogFile, added code to upgrade these to
3036 new-style contents-live-on-disk instances at load time (in a way
3037 that doesn't invalidate the old Build pickles, so upgrading to
3038 0.6.5 is not a one-way operation). Got rid of everything related
3040 (LogFile.__init__): create LogFiles with the parent step status,
3041 the log's name, and a builder-relative filename where it can keep
3042 the contents on disk.
3043 (LogFile.hasContents): new method, clients are advised to call it
3044 before getText or getChunks and friends. If it returns False, the
3045 log's contents have been deleted and getText() will raise an
3047 (LogFile.getChunks): made it a generator
3048 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3049 Consumer (except one that takes chunks instead of strings). This
3050 enables streaming of very large logfiles without storing the whole
3052 (BuildStatus.generateLogfileName): create names like
3053 12-log-compile-output, with a _0 suffix if required to be unique
3054 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3055 or earlier) logfiles into new-style ones
3056 (BuilderStatus): remove everything related to 'stub' builds. There
3057 is now only one build cache, and we don't strip logs from old
3059 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3060 since we no longer fight to keep it in the cache
3062 * buildbot/status/html.py (TextLog.render_GET): use a
3063 ChunkConsumer to stream the log entries efficiently.
3064 (ChunkConsumer): wrapper which consumes chunks and writes
3067 * buildbot/test/test_twisted.py (Parse.testParse): use a
3068 LogFile-like object instead of a real one
3070 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3071 (Log.testMerge3): validate more merge behavior
3072 (Log.testChunks): validate LogFile.getChunks
3073 (Log.testUpgrade): validate old-style LogFile upgrading
3074 (Log.testSubscribe): validate LogFile.subscribe
3075 (Log.testConsumer): validate LogFile.subscribeConsumer
3077 * buildbot/interfaces.py (IStatusLogStub): remove
3078 (IStatusLog.subscribeConsumer): new method
3079 (IStatusLog.hasContents): new method
3080 (IStatusLogConsumer): describes things passed to subscribeConsumer
3082 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3083 the log contents if it does not have any contents.
3084 (StatusResourceBuildStep.body): same
3085 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3087 2005-05-14 Brian Warner <warner@lothar.com>
3089 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3090 timeouts to try and make the windows metabuildslave not hang
3092 2005-05-13 Mike Taylor <bear@code-bear.com>
3094 * buildbot/slave/commands.py (rmdirRecursive): added a check
3095 to ensure the path passed into rmdirRecursive actually exists.
3096 On win32 a non-existant path would generate an exception.
3098 2005-05-13 Brian Warner <warner@lothar.com>
3100 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3101 shutil.rmtree which behaves correctly on windows in the face of
3102 files that you have to chmod before deleting. Thanks to Bear at
3103 the OSAF for the routine.
3104 (SourceBase.doClobber): use rmdirRecursive
3106 2005-05-12 Brian Warner <warner@lothar.com>
3108 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3109 method generate chunks instead of returning a big list. This
3110 allows the same method to be used for both old LogFile and new
3112 (OfflineLogFile.getText): use the generator
3113 (OfflineLogFile.subscribe): same
3114 * buildbot/status/html.py (TextLog.resumeProducing): same
3115 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3117 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3118 point out that OfflineLogFile does not currently work with
3119 html.Waterfall . Fixing this is high-priority.
3121 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3122 apparently windows defaults to using stdout
3124 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3125 better message on failure so I can figure out the win32 problem
3127 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3128 log messages to include more useful copies of the command being
3129 run, the argv array, and the child command's environment.
3130 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3132 2005-05-11 Brian Warner <warner@lothar.com>
3134 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3136 * Makefile: update the deb-snapshot version
3138 * docs/buildbot.texinfo: move all .xhtml docs into a new
3139 .texinfo-format document, adding a lot of material in the process.
3140 This is starting to look like a real user's manual. Removed all
3141 the Lore-related files: *.xhtml, *.css, template.tpl .
3142 * docs/Makefile: simple makefile to run 'makeinfo'
3143 * buildbot/scripts/sample.cfg: rearrange slightly
3144 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3146 2005-05-10 Brian Warner <warner@lothar.com>
3148 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3149 different name for the internal twistw module, handle it.
3151 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3152 * setup.py: .. and stop trying to install it
3154 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3155 'git'), the new linux kernel VC system (http://kernel.org/git/).
3156 Thanks to Brandon Philips for the patch.
3157 * buildbot/slave/commands.py (Git): same
3159 2005-05-06 Brian Warner <warner@lothar.com>
3161 * buildbot/status/builder.py (OfflineLogFile): replace the default
3162 LogFile with a form that appends its new contents to a disk file
3163 as they arrive. The complete log data is never kept in RAM. This
3164 is the first step towards handling very large (100MB+) logfiles
3165 without choking quite so badly. (The other half is
3166 producer/consumer on the HTML pages).
3167 (BuildStepStatus.addLog): use OfflineLogFile by default
3168 (BuildStatus.getLogfileName): helper code to give the
3169 OfflineLogFile a filename to work with
3171 * buildbot/test/test_status.py (Results.testAddResults): update
3172 tests to handle new asserts
3173 * buildbot/test/test_vc.py (Patch.doPatch): same
3174 * buildbot/test/test_steps.py (BuildStep.setUp): same
3176 2005-05-05 Brian Warner <warner@lothar.com>
3178 * buildbot/scripts/runner.py (start): if there is no Makefile,
3179 launch the app by importing twistd's internals and calling run(),
3180 rather than spawning a new twistd process. This stands a much
3181 better chance of working under windows.
3182 (stop): kill the process with os.kill instead of spawning
3183 /bin/kill, again to reduce the number of external programs which
3184 windows might not have in the PATH. Also wait up to 5 seconds for
3185 the process to go away, allowing things like 'buildbot stop;
3186 buildbot start' to be reliable in the face of slow shutdowns.
3188 * buildbot/master.py (Dispatcher.__getstate__): remove old
3189 .tap-related methods
3190 (BuildMaster.__getstate__): same
3192 * buildbot/slave/bot.py (makeService): same
3193 (Options.longdesc): same
3194 * buildbot/scripts/runner.py: copy over some old mktap option text
3196 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3197 'buildbot master' now creates a buildbot.tac file, so there is no
3198 longer a create-instance/save/reload sequence. mktap is dead, long
3200 * buildbot/scripts/sample.mk: use twistd -y, not -f
3201 * buildbot/test/test_config.py: remove mktap-based test
3202 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3203 * README: don't reference mktap
3205 * docs/source.xhtml: document some of the attributes that Changes
3208 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3210 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3211 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3212 * buildbot/changes/changes.py (Change)
3213 * buildbot/changes/mail.py (parseSyncmail)
3214 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3216 * buildbot/process/base.py (Build.isTagImportant)
3220 2005-05-04 Brian Warner <warner@lothar.com>
3222 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3223 connection after sending the change, so that unit tests don't
3224 complain about sockets being left around
3226 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3227 exception in phase=0 rendering
3228 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3230 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3232 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3233 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3234 and configuring builders with tuples.
3235 * buildbot/test/test_config.py: stop testing compatibility with
3236 deprecated config keys
3237 * buildbot/test/test_run.py: same
3239 2005-05-03 Brian Warner <warner@lothar.com>
3241 * contrib/arch_buildbot.py: survive if there are no logfiles
3242 (username): just use a string, os.getlogin isn't reliable
3244 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3245 so 'buildbot sendchange' actually works. The earlier test only
3246 covered the internal (non-reactor-running) form.
3248 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3249 script to notify the buildmaster about changes
3251 * buildbot/scripts/runner.py (sendchange): new command to send a
3252 change to a buildbot.changes.pb.PBChangeSource receiver.
3253 * buildbot/test/test_changes.py (Sender): test it
3255 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3256 after any reading of the config file, not just when we do it in
3257 startService. This makes some tests a bit cleaner.
3259 * buildbot/changes/pb.py: add some log messages
3261 * buildbot/process/base.py (Build.startBuild): fix a bug that
3262 caused an exception when the build terminated in the very first
3264 (Build.stepDone): let steps return a status of EXCEPTION. This
3265 terminates the build right away, and sets the build's overall
3266 status to EXCEPTION too.
3267 * buildbot/process/step.py (BuildStep.failed): return a status of
3268 EXCEPTION when that is what has happened.
3270 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3271 implement this, allowing Arch-based projects to get precise
3272 checkouts instead of always using the latest code
3273 (Bazaar): create variant of Arch to let folks use baz instead of
3274 tla. Requires a new buildslave too.
3275 * buildbot/slave/commands.py (Arch): add 'revision' argument
3276 (Bazaar): create variant of Arch that uses baz instead of tla.
3277 Remove the code that extracts the archive name from the
3278 register-archive output, since baz doesn't provide it, and require
3279 the user provide both the archive name and its location.
3280 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3282 2005-05-02 Brian Warner <warner@lothar.com>
3284 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3285 thanks to Nick Trout.
3287 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3288 deals better with source Makefile coming from a read-only CVS
3289 checkout. Thanks to Nick Trout for the catch.
3291 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3294 2005-04-28 Brian Warner <warner@lothar.com>
3296 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3298 * debian/changelog: update for 0.6.4
3300 2005-04-28 Brian Warner <warner@lothar.com>
3302 * README.w32: add a checklist of steps for getting buildbot
3304 * MANIFEST.in: include it in the tarball
3308 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3309 broken .tap files from 0.6.3 by getting rid of .services,
3310 .namedServices, and .change_svc at load time.
3312 2005-04-27 Brian Warner <warner@lothar.com>
3314 * NEWS: update in preparation for new release
3316 * buildbot/test/test_config.py (Save.testSave): don't pull in
3317 twisted.scripts.twistd, we don't need it and it isn't for windows
3320 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3321 accomodate win32 which can't do atomic-rename
3323 2005-04-27 Brian Warner <warner@lothar.com>
3325 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3326 timeouts to help the slow metabuildbot not flunk them so much
3327 (Disconnect.testBuild3): same
3328 (Disconnect.testBuild4): same
3329 (Disconnect.testInterrupt): same
3331 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3332 setup, it was completely broken for new buildmasters (those which
3333 did not have a 'change.pck' already saved. Thanks to Paul Warren
3334 for catching this (embarrassing!) bug.
3335 (Dispatcher.__getstate__): don't save our registered avatar
3336 factories, since they'll be re-populated when the config file is
3338 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3339 tests (since the real mktap-generated BuildMaster doesn't save
3341 (BuildMaster.__getstate__): don't save any service children,
3342 they'll all be re-populated when the config file is re-read.
3343 * buildbot/test/test_config.py (Save.testSave): test for this
3345 2005-04-26 Brian Warner <warner@lothar.com>
3347 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3348 rendered with Blender.. looks a bit nicer.
3349 * buildbot/docs/images/icon.blend: add the Blender file for it
3351 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3352 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3353 running under windows. This appears to be the best way to allow
3354 BuildSteps to do something normal like 'trial -v buildbot.test' or
3355 'make foo' and still expect it to work. The idea is to make the
3356 BuildSteps look as much like what a developer would type when
3357 compiling or testing the tree by hand. This approach probably has
3358 problems when there are spaces in the arguments, so if you've got
3359 windows buildslaves, you'll need to pay close attention to your
3362 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3363 timezone to the timestamp column.
3364 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3366 * buildbot/scripts/runner.py (loadOptions): do something sane for
3367 windows, I think. We use %APPDATA%/buildbot instead of
3368 ~/.buildbot, but we still search everywhere from the current
3369 directory up to the root for a .buildbot/ subdir. The "is it under
3370 $HOME" security test was replaced with "is it owned by the current
3371 user", which is only performed under posix.
3372 * buildbot/test/test_runner.py (Options.testFindOptions): update
3373 tests to match. The "is it owned by the current user" check is
3374 untested. The test has been re-enabled for windows.
3376 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3377 any "\n" in the expected output with the platform-specific line
3378 separator. Make this separator "\r\n" on PTYs under unix, they
3379 seem to do that and I don't know why
3381 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3382 windows for now, I don't know what ~/.buildbot/ should mean there.
3384 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3385 win32 compatibility, don't use "/tmp"
3386 (Basedir.testChangeBuilddir): remove more unixisms
3388 2005-04-26 Brian Warner <warner@lothar.com>
3390 * buildbot/test/test_control.py (Force.rmtree): python2.2
3391 compatibility, apparently its shutil.rmtree ignore_errors=
3392 argument is ignored.
3393 * buildbot/test/test_run.py (Run.rmtree): same
3394 (RunMixin.setUp): same
3396 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3399 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3400 'substring in string' operator, must use string.find(substr)!=-1
3401 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3402 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3404 * buildbot/scripts/runner.py (loadOptions): add code to search for
3405 ~/.buildbot/, a directory with things like 'options', containing
3406 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3407 the current directory, your $HOME directory, or anywhere
3408 inbetween, as long as you're somewhere inside your home directory.
3409 (debugclient): look in ~/.buildbot/options for master and passwd
3410 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3411 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3413 * buildbot/status/client.py (makeRemote): new approach to making
3414 IRemote(None) be None, which works under Twisted-2.0
3415 * buildbot/test/test_status.py (Client.testAdaptation): test it
3417 * buildbot/status/builder.py (Status.builderAdded): when loading a
3418 pickled BuilderStatus in from disk, set its name after loading.
3419 The config file might have changed its name (but not its
3420 directory) while it wasn't looking.
3422 * buildbot/process/builder.py (Builder.attached): always return a
3423 Deferred, even if the builder was already attached
3424 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3426 2005-04-25 Brian Warner <warner@lothar.com>
3428 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3429 category-related exception when announcing a build has finished
3431 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3432 reference no-longer-existent changemaster.sources
3433 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3435 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3438 2005-04-25 Brian Warner <warner@lothar.com>
3440 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3442 * debian/changelog: update for 0.6.3
3444 2005-04-25 Brian Warner <warner@lothar.com>
3446 * MANIFEST.in: make sure debug.glade is in the tarball
3448 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3450 * NEWS: update for the imminent 0.6.3 release
3452 * buildbot/status/html.py (HtmlResource.content): make the
3453 stylesheet <link> always point at "buildbot.css".
3454 (StatusResource.getChild): map "buildbot.css" to a static.File
3455 containing whatever css= argument was provided to Waterfall()
3456 (Waterfall): provide the "classic" css as the default.
3457 * docs/waterfall.classic.css: move default CSS from here ..
3458 * buildbot/status/classic.css: .. to here
3460 * MANIFEST.in: make sure classic.css is included in the tarball
3461 * setup.py: and that it is installed too, under buildbot/status/
3463 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3464 the module level, because buildbot.tap files from 0.6.2 don't have
3465 it in their attribute dictionary.
3467 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3468 really exists at startup, might save some confusion somewhere.
3470 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3472 * docs/waterfall.classic.css:
3473 add a stylesheet that's almost the same as the "classic"
3476 * buildbot/status/builder.py:
3477 add EXCEPTION as a result - this is a problem for the bot
3478 maintainer, not a build problem for the changers
3479 * buildbot/process/step.py:
3480 use EXCEPTION instead of FAILURE for exceptions
3481 * buildbot/status/html.py:
3482 add build_get_class to get a class out of a build/buildstep
3483 finish naming the classes
3484 split out sourceNames to changeNames and builderNames so we
3485 can style them separately
3486 * docs/config.xhtml:
3487 finish documenting classes as they are right now
3489 * buildbot/status/html.py:
3490 name the classes as we agreed on IRC
3491 * docs/config.xhtml:
3494 * buildbot/status/html.py:
3495 same for cssclass->class_
3497 * buildbot/status/html.py:
3498 as decided on IRC, use class_ for the "class" attribute to not
3499 conflict with the class keyword, and clean up the messy **{} stuff.
3501 * buildbot/status/mail.py:
3502 put back "builders" argument, and fix docstring, because the
3503 code *ignores* builders listed in this argument
3505 * buildbot/process/builder.py:
3506 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3508 * docs/config.xhtml:
3509 describe the category argument for builders
3511 * buildbot/status/builder.py:
3512 Fix a silly bug due to merging
3514 * buildbot/process/builder.py:
3515 remove category from the process Builder ...
3516 * buildbot/status/builder.py:
3517 ... and add it to BuilderStatus instead.
3518 Set category on unpickled builder statuses, they might not have it.
3519 * buildbot/master.py:
3520 include category when doing builderAdded
3521 * buildbot/status/mail.py:
3522 return None instead of self for builders we are not interested in.
3523 * buildbot/test/test_run.py:
3524 fix a bug due to only doing deferredResult on "dummy" waiting
3525 * buildbot/test/test_status.py:
3526 add checks for the Mail IStatusReceiver returning None or self
3528 * buildbot/status/html.py:
3529 fix testsuite by prefixing page title with BuildBot
3531 * buildbot/status/builder.py:
3532 have .category in builder status ...
3533 * buildbot/process/builder.py:
3534 ... and set it from Builder
3535 * buildbot/status/html.py:
3536 make .css a class variable
3537 * buildbot/test/test_status.py:
3538 write more tests to cover our categories stuff ...
3539 * buildbot/status/mail.py:
3540 ... and fix the bug that this uncovered
3542 * buildbot/changes/mail.py:
3543 * buildbot/changes/pb.py:
3544 * buildbot/master.py:
3545 * buildbot/process/base.py:
3546 * buildbot/process/factory.py:
3547 * buildbot/process/interlock.py:
3548 * buildbot/process/step.py:
3549 * buildbot/process/step_twisted.py:
3550 * buildbot/slave/commands.py:
3551 * buildbot/status/builder.py:
3552 * buildbot/status/client.py:
3553 * buildbot/status/html.py:
3554 * buildbot/status/mail.py:
3555 * buildbot/status/progress.py:
3556 * buildbot/test/test_changes.py:
3557 * buildbot/test/test_config.py:
3558 * buildbot/test/test_control.py:
3559 * buildbot/test/test_interlock.py:
3560 * buildbot/test/test_maildir.py:
3561 * buildbot/test/test_mailparse.py:
3562 * buildbot/test/test_run.py:
3563 * buildbot/test/test_slavecommand.py:
3564 * buildbot/test/test_status.py:
3565 * buildbot/test/test_steps.py:
3566 * buildbot/test/test_twisted.py:
3567 * buildbot/test/test_util.py:
3568 * buildbot/test/test_vc.py:
3569 * buildbot/test/test_web.py:
3571 add test-case-name at the top of a whole set of files
3573 * buildbot/status/builder.py:
3574 keep order of addition when getting builder names
3575 * buildbot/status/words.py:
3576 * buildbot/test/test_run.py:
3577 add test for getBuilderNames
3579 * buildbot/process/base.py:
3580 * buildbot/process/step.py:
3581 * buildbot/status/builder.py:
3582 * buildbot/status/html.py:
3583 make buildbot css-able
3584 replace the color code for purple with purple, don't understand
3585 why it wasn't purple to start with
3587 * buildbot/status/words.py:
3588 ok, so it doesn't look like BuilderStatus.remote is still valid.
3589 Use what waterfall uses instead.
3591 * buildbot/interfaces.py:
3592 * buildbot/status/builder.py:
3593 * buildbot/status/html.py:
3594 * buildbot/status/mail.py:
3595 * buildbot/status/words.py:
3596 * buildbot/test/test_run.py:
3597 use categories everywhere and make it be a list. More sensible
3598 for the future. Also make words actually respect this in
3601 * buildbot/interfaces.py:
3602 add category argument to getBuilderNames
3603 * buildbot/process/builder.py:
3604 * buildbot/status/builder.py:
3605 * buildbot/status/html.py:
3606 * buildbot/status/mail.py:
3607 * buildbot/status/words.py:
3608 * buildbot/test/test_run.py:
3609 move from specifying builders by name to specifying the category
3611 * buildbot/status/html.py:
3612 * buildbot/status/words.py:
3613 add "builders=" to __init__ of status clients so they can
3614 limit themselves to the given list of builders to report on
3616 * buildbot/status/html.py: set the title to the product name
3618 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3620 * buildbot/interfaces.py:
3621 * buildbot/status/builder.py:
3622 more documentation. Hm, not sure if ChangeLog entries make sense
3625 2005-04-23 Brian Warner <warner@lothar.com>
3627 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3629 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3631 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3632 the sub-commands that log buildmaster status to stdout and to a
3633 GUI window, respectively.
3635 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3636 functionality is working again, but all the step-status and ETA
3637 stuff is missing. Commented out a lot of code pending more
3640 * buildbot/status/client.py: make sure that IRemote(None) is None
3642 * buildbot/changes/changes.py: import defer, oops
3643 (ChangeMaster): remove the .sources list, rely upon the fact that
3644 MultiServices can be treated as sequences of their children. This
3645 cleans up the add/remove ChangeSource routines a lot, as we keep
3646 exactly one list of the current sources instead of three.
3648 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3649 up an empty ChangeMaster at init time.
3650 (BuildMaster.loadChanges): if there are changes to be had from
3651 disk, replace self.change_svc with the new ones. If not, keep
3652 using the empty ChangeMaster set up in __init__.
3653 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3654 instead of a separate list, makes the code a bit cleaner.
3655 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3656 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3657 Extend the test to make sure we can get rid of the sources when
3660 2005-04-22 Brian Warner <warner@lothar.com>
3662 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3663 and info/host files when making the slave directory
3665 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3666 whendone= argument, just return the Deferred and let the caller do
3667 what they want with it.
3668 (Disconnect.testBuild1): wait for shutdownSlave
3669 (Basedir.testChangeBuilddir): new test to make sure changes to the
3670 builddir actually get propagated to the slave
3672 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3673 explicit method, rather than passing the builddir in __init__ .
3674 Make sure to update self.basedir too, this was broken before.
3675 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3676 builders and for ones that have just had their builddir changed.
3677 (BotFactory): add a class-level .perspective attribute, so
3678 BuildSlave.waitUntilDisconnected won't get upset when the
3679 connection hasn't yet been established
3680 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3681 tests can reach through it to inspect the SlaveBuilders
3683 * buildbot/process/base.py (Build.buildException): explain the
3684 log.err with a log.msg
3685 * buildbot/process/builder.py (Builder.startBuild): same
3686 (Builder._startBuildFailed): improve error message
3688 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3689 occurred because we lost the brand-new connection, retry instead
3690 of giving up. If not, it's probably an authorization failure, and
3691 it makes sense to stop trying. Make sure we log.msg the reason
3692 that we're log.err'ing the failure, otherwise test failures are
3693 really hard to figure out.
3695 * buildbot/master.py: change loadConfig() to return a Deferred
3696 that doesn't fire until the change has been fully implemented.
3697 This means any connected slaves have been updated with the new
3698 builddir. This change makes it easier to test the code which
3699 actually implements this builddir-updating.
3700 (BotPerspective.addBuilder): return Deferred
3701 (BotPerspective.removeBuilder): same
3702 (BotPerspective.attached): same
3703 (BotPerspective._attached): same. finish with remote_print before
3704 starting the getSlaveInfo, instead of doing them in parallel
3705 (BotPerspective.list_done): same
3706 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3707 actually calling slave.disconnect()
3708 (BotMaster.addBuilder): same
3709 (BotMaster.removeBuilder): same
3710 (BuildMaster.loadConfig): same
3711 (BuildMaster.loadConfig_Slaves): same
3712 (BuildMaster.loadConfig_Sources): same
3713 (BuildMaster.loadConfig_Builders): same
3714 (BuildMaster.loadConfig_status): same
3716 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3717 a Deferred that fires when the source is finally removed
3719 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3720 the previous tree on win32, where we have to do it synchronously,
3721 make sure we return a Deferred anyway.
3722 (SourceBase.doCopy): same
3724 * buildbot/scripts/runner.py (statusgui): use the text client for
3725 now, while I rewrite the Gtk one
3726 * buildbot/clients/base.py: strip out old code, leaving just the
3727 basic print-message-on-event functionality. I also remove the
3728 ReconnectingPBClientFactory, but it does at least quit when it
3729 loses the connection instead of going silent
3731 2005-04-21 Brian Warner <warner@lothar.com>
3733 * Makefile: minor tweaks
3735 * NEWS: point out deprecation warnings, new features for
3738 * buildbot/master.py (BuildMaster.loadConfig): emit
3739 DeprecationWarnings for Builders defined with tuples. Rearrange
3740 code to facility removal of deprecated configuration keys in the
3743 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3744 'buildbot' command to put a little Makefile in the target that
3745 helps you re-create the buildbot.tap file, start or stop the
3746 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3747 all the files 0600, since they contain passwords.
3748 (start): if there is a Makefile, and /usr/bin/make exists, use
3749 'make start' in preference to a raw twistd command. This lets
3750 slave admins put things like PYTHONPATH variables in their
3751 Makefiles and have them still work when the slave is started with
3752 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3753 be nice to first try the 'make' command and only fall back to
3754 twistd if it fails. TODO: the Makefile's "start" command does not
3755 add the --reactor=win32 argument when running under windows.
3756 (Options.debugclient, Options.statusgui): add sub-commands to launch
3757 the debug client (formerly in contrib/debugclient.py) and the
3758 Gtk status application (currently broken)
3759 * buildbot/clients/debug.py: move from contrib/debugclient.py
3760 * buildbot/clients/debug.glade: same
3762 * buildbot/test/test_trial.py: remove it. This requires some
3763 functionality out of Twisted that isn't there yet, and until then
3764 having it around just confuses things.
3766 * buildbot/test/test_slavecommand.py (Shell): test both with and
3767 without PTYs, and make sure that command output is properly
3768 interleaved in the with-PTY case. I think the without-PTY test
3769 should pass on windows, where we never use PTYs anyway.
3771 2005-04-20 Brian Warner <warner@lothar.com>
3773 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3775 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3777 * NEWS: start creating entries for the next release
3779 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3781 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3782 (WebTest.test_webPathname): same
3783 (WebTest.test_webPathname_port): same
3784 (WebTest.test_waterfall): use the default favicon rather than
3785 rooting around the filesystem for it. Open the expected-icon file
3786 in binary mode, to make win32 tests happier (thanks to Nick Trout
3788 * buildbot/status/html.py (buildbot_icon): win32 portability
3790 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3791 win32-compatibility fixes from Nick Trout, the "file not found" message
3792 is different under windows
3793 (FakeSlaveBuilder.__init__): clean up setup a bit
3794 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3796 2005-04-19 Brian Warner <warner@lothar.com>
3798 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3799 skip-if-repositories-are-unavailable test to not kill the trial
3800 that comes with Twisted-1.3.0
3802 * setup.py: install buildbot.png icon file when installing code
3804 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3805 environment used by the command, at least on the child side.
3807 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3808 this method needs to be added and implemented because it gets
3809 called under heavy load. I don't quite understand the
3810 producer/consumer API enough to write it.
3811 (StatusResource.getChild): add a resource for /favicon.ico
3812 (Waterfall.__init__): add favicon= argument
3813 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3814 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3815 (WebTest.test_webPathname): same
3816 (WebTest.test_webPathname_port): same
3817 * docs/config.xhtml: mention favicon=
3818 * buildbot/buildbot.png: add a default icon, dorky as it is
3820 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3822 * buildbot/master.py:
3823 * buildbot/process/base.py:
3824 * buildbot/process/builder.py:
3825 * buildbot/process/interlock.py:
3826 * buildbot/status/builder.py:
3827 * buildbot/status/html.py:
3828 * buildbot/status/mail.py:
3829 * buildbot/status/words.py:
3830 new documentation while digging through the code
3832 2005-04-17 Brian Warner <warner@lothar.com>
3834 * general: try to fix file modes on all .py files: a+r, a-x,
3835 but let buildbot/clients/*.py be +x since they're tools
3837 * docs/epyrun (addMod): when an import fails, say why
3839 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3841 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3843 * buildbot/process/base.py:
3844 * buildbot/process/builder.py:
3845 * buildbot/status/builder.py:
3846 new documentation while digging through the code
3848 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3850 * buildbot/changes/changes.py:
3851 * buildbot/changes/p4poller.py:
3852 * buildbot/interfaces.py:
3853 * buildbot/process/base.py:
3854 * buildbot/process/builder.py:
3855 * buildbot/process/step.py:
3856 * buildbot/process/step_twisted.py:
3857 * buildbot/slave/bot.py:
3858 * buildbot/slave/commands.py:
3859 * buildbot/status/builder.py:
3860 fix all docstrings to make epydoc happy. In the process of fixing
3861 some, I also moved pieces of docs, and removed some deprecated
3864 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3866 * buildbot/process/builder.py:
3867 * buildbot/process/interlock.py:
3868 * buildbot/process/process_twisted.py:
3869 * buildbot/process/step.py:
3870 BuildProcess -> Build, as it looks like that's what happened
3871 * buildbot/process/base.py:
3872 * buildbot/process/factory.py:
3875 2005-04-17 Brian Warner <warner@lothar.com>
3877 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3878 update compile command to accomodate the Twisted split.. now
3879 instead of './setup.py build_ext -i', you do './setup.py all
3880 build_ext -i', to run build_ext over all sub-projects.
3881 (FullTwistedBuildFactory): same
3882 (TwistedReactorsBuildFactory): same
3884 * buildbot/status/html.py (TextLog.finished): null out self.req
3885 when we're done, otherwise the reference cycle of TextLog to .req
3886 to .notifications to a Deferred to TextLog.stop keeps them from
3887 being collected, and consumes a huge (610MB on pyramid at last
3888 check) amount of memory.
3890 2005-04-11 Brian Warner <warner@lothar.com>
3892 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3893 normalize the VC-repository location.. makes SVN happier with
3894 certain test environments.
3896 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3897 RemoteShellCommand gets its own .env dictionary, so that code in
3898 start() doesn't mutate the original. I think this should fix the
3899 step_twisted.Trial problem where multiple identical components
3900 kept getting added to PYTHONPATH= over and over again.
3902 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3903 adding epydoc-format docstrings to many classes. Thanks to Thomas
3904 Vander Stichele for the patches.
3905 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3906 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3907 * buildbot/slave/bot.py, commands.py, registry.py: same
3909 2005-04-05 Brian Warner <warner@lothar.com>
3911 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3912 preserve timestamps, helps incremental builds of large trees.
3913 Patch from Rene Rivera.
3915 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
3916 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
3919 2005-04-03 Brian Warner <warner@lothar.com>
3921 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
3922 with one dict, apparently exec has some scoping bugs when used
3923 with both global/local dicts. Thanks to Nathaniel Smith for the
3926 2005-04-02 Brian Warner <warner@lothar.com>
3928 * buildbot/process/step_twisted.py (countFailedTests): the new
3929 trial in Twisted-2.0 emits a slightly different status line than
3930 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
3931 mistakenly think the test count is unparseable.
3932 (Trial.start): note that for some reason each build causes another
3933 copy of self.testpath to be prepended to PYTHONPATH. This needs to
3934 be fixed but I'm not sure quite where the problem is.
3936 2005-04-01 Brian Warner <warner@lothar.com>
3938 * buildbot/test/test_run.py (Run.testMaster): change some uses of
3939 deferredResult to avoid hangs/warnings under twisted-2.0
3940 (RunMixin.tearDown): same
3941 (RunMixin.shutdownSlave): same
3942 (Disconnect.testIdle1): same
3943 (Disconnect.testBuild2): same: wait one second after the build
3944 finishes for test to really be done.. this should be cleaned up to
3945 avoid wasting that second. Builder.detach uses a callLater(0),
3946 either that should be done in-line (something else needed that
3947 behavior), or it should return a Deferred that fires when the
3948 builder is really offline.
3949 (Disconnect.testBuild3): same
3950 (Disconnect.testDisappear): same
3952 * buildbot/test/test_web.py: rearrange server-setup and teardown
3953 code to remove unclean-reactor warnings from twisted-2.0
3955 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
3956 so the tests don't hang under twisted-2.0
3958 2005-03-31 Brian Warner <warner@lothar.com>
3960 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
3961 caused a warning each time the master changed our set of builders
3963 * buildbot/status/builder.py (BuildStatus.saveYourself): under
3964 w32, don't unlink the file unless it already exists. Thanks to
3965 Baptiste Lepilleur for the catch.
3966 (BuilderStatus.saveYourself): same
3968 2005-02-01 Brian Warner <warner@lothar.com>
3970 * buildbot/status/html.py (TextLog.getChild): use a /text child
3971 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
3972 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
3973 logfile as text/plain (no markup, no headers). This replaces the
3974 previous scheme (which used an ?text=1 argument), and gets us back
3975 to a relative link (which works better when the buildbot lives
3976 behind another web server, such as Apache configured as a reverse
3977 proxy). Thanks to Gerald Combs for spotting the problem.
3979 * buildbot/__init__.py (version): bump to 0.6.2+ while between
3982 2004-12-13 Brian Warner <warner@lothar.com>
3984 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
3986 * debian/changelog: update for 0.6.2
3987 * NEWS: finalize for 0.6.2
3989 2004-12-11 Brian Warner <warner@lothar.com>
3991 * NEWS: bring it up to date
3993 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
3994 detection code. Require some sign of life from the buildmaster
3995 every BotFactory.keepaliveInterval seconds. Provoke this
3996 indication at BotFactory.keepaliveTimeout seconds before the
3997 deadline by sending a keepalive request. We don't actually care if
3998 that request is answered in a timely fashion, what we care about
3999 is that .activity() is called before the deadline. .activity() is
4000 triggered by any PB message from the master (including an ack to
4001 one of the slave's status-update messages). With this new scheme,
4002 large status messages over slow pipes are OK, as long as any given
4003 message can be sent (and thus acked) within .keepaliveTimeout
4004 seconds (which defaults to 30).
4005 (SlaveBuilder.remote_startCommand): record activity
4006 (SlaveBuilder.ackUpdate): same
4007 (SlaveBuilder.ackComplete): same
4008 (BotFactory.gotPerspective): same
4009 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4011 2004-12-09 Brian Warner <warner@lothar.com>
4013 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4016 * buildbot/process/step_twisted.py (Trial._commandComplete):
4017 update self.cmd when we start the 'cat test.log' transfer. Without
4018 this, we cannot interrupt the correct RemoteCommand when we lose
4021 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4022 trying to tell the slave to stop the command if we're already
4023 inactive, or if we no longer have a .remote
4025 * buildbot/process/builder.py (Builder._detached): don't let an
4026 exception in currentBuild.stopBuild() prevent the builder from
4027 being marked offline
4029 2004-12-07 Brian Warner <warner@lothar.com>
4031 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4032 KeyError that happens when you ask for a non-existent Builder, and
4033 translate it into a UsageError.
4035 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4036 losing the slave in the middle of a remote step is handled too
4038 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4039 be a Failure, so be sure to stringify it before using it as the
4040 contents of the 'interrupt' logfile
4041 (RemoteCommand.interrupt): use stringified 'why' in
4042 remote_interruptCommand too, just in case
4044 2004-12-06 Brian Warner <warner@lothar.com>
4046 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4047 instead of 'tla update', which is more efficient in case we've
4048 missed a couple of patches since the last update.
4050 * debian/changelog: update for previous (0.6.1) release. Obviously
4051 this needs to be handled better.
4053 2004-12-05 Brian Warner <warner@lothar.com>
4055 * NEWS: update for stuff since last release
4057 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4058 match the maybeDeferred change in Dispatcher.requestAvatar
4059 * buildbot/changes/pb.py (ChangePerspective.attached): same
4060 * buildbot/status/client.py (StatusClientPerspective.attached): same
4061 * buildbot/process/builder.py (Builder._attached3): same
4062 * buildbot/pbutil.py (NewCredPerspective.attached): same
4064 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4065 the date to the top-most box, if it is not the same as today's
4068 * docs/slave.xhtml: provide a buildslave setup checklist
4070 * docs/source.xhtml (Arch): correct terminology
4072 2004-12-04 Brian Warner <warner@lothar.com>
4074 * buildbot/test/test_slavecommand.py: use sys.executable instead
4075 of hard-coding 'python' for child commands, might help portability
4077 * docs/examples/twisted_master.cfg: update to current usage
4079 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4080 'stop build' command to the IRC bot
4082 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4083 message that broke PBChangeSource
4085 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4086 (SlaveBuilder): make some attributes class-level, remove the old
4087 "update queue" which existed to support resuming a build after the
4088 master connection was lost. Try to reimplement that feature later.
4089 (SlaveBuilder.stopCommand): clear self.command when the
4090 SlaveCommand finishes, so that we don't try to kill a leftover one
4092 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4095 * buildbot/slave/commands.py (SourceBase): set self.command for
4096 all VC commands, so they can be interrupted.
4098 2004-12-03 Brian Warner <warner@lothar.com>
4100 * buildbot/master.py: clean up slave-handling code, to handle
4101 slave-disconnect and multiple-connect better
4102 (BotPerspective): make these long-lasting, exactly one per bot
4103 listed in the config file.
4104 (BotPerspective.attached): if a slave connects while an existing
4105 one appears to still be connected, disconnect the old one first.
4106 (BotPerspective.disconnect): new method to forcibly disconnect a
4107 buildslave. Use some hacks to empty the transmit buffer quickly to
4108 avoid the long (20-min?) TCP timeout that could occur if the old
4109 slave has dropped off the net.
4110 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4111 own their own SlaveStatus objects. Remove .attached/.detached, add
4112 .addSlave/.removeSlave, treat slaves like Builders (config file
4113 parsing sends deltas to the BotMaster). Inform the slave
4114 instances, i.e. the BotPerspective, about addBuilder and
4116 (BotMaster.getPerspective): turns into a single dict lookup
4117 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4118 which gives BotPerspective.attached a chance to disconnect the old
4120 (BuildMaster.loadConfig): add code (disabled) to validate that all
4121 builders use known slaves (listed in c['bots']). The check won't
4122 work with tuple-specified builders, which are deprecated but not
4123 yet invalid, so the check is disabled for now.
4124 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4125 routine, do the add/changed/removed dance with them like we do
4127 (BuildMaster.loadConfig_Sources): move source-config into a
4128 separate routine too
4130 * buildbot/status/builder.py (Status.getSlave): get the
4131 SlaveStatus object from the BotPerspective, not the BotMaster.
4133 * buildbot/test/test_run.py: bunch of new tests for losing the
4134 buildslave at various points in the build, handling a slave that
4135 connects multiple times, and making sure we can interrupt a
4138 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4139 something other than 'Bot' for the Bot object, to make certain
4140 test cases easier to write.
4141 (BuildSlave.waitUntilDisconnected): utility method for testing
4143 2004-11-30 Brian Warner <warner@lothar.com>
4145 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4147 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4148 argument, return a Deferred that always fires with True or False.
4149 I don't use an errback to indicate 'ping failed' so that callers
4150 are free to ignore the deferred without causing spurious errors in
4152 * buildbot/process/builder.py (BuilderControl.ping): implement it
4154 * buildbot/test/test_run.py (Status.testDisappear): test ping
4155 (Status.disappearSlave): fix it
4157 2004-11-30 Brian Warner <warner@lothar.com>
4159 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4160 (IBuilderControl): add .getBuild(num), only works for the current
4161 build, of course, although it might be interesting to offer
4162 something for builds in the .waiting or .interlocked state.
4164 * buildbot/process/base.py (Build): have .stopBuild just do the
4165 interrupt, then let the build die by itself.
4166 (BuildControl): add .stopBuild, and add a point-event named
4167 'interrupt' just after the build so status viewers can tell that
4169 (BuilderControl): add .getBuild
4171 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4172 stops when you kill it, good for testing
4173 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4174 contains the 'reason' text.
4176 * buildbot/status/html.py: Add Stop Build button, if the build can
4177 still be stopped. Send a Redirect (to the top page) one second
4178 later, hopefully long enough for the interrupt to have an effect.
4179 Move make_row() up to top-level to share it between Stop Build and
4182 * buildbot/slave/commands.py: only kill the child process once
4184 * buildbot/test/test_run.py: add testInterrupt
4186 2004-11-29 Brian Warner <warner@lothar.com>
4188 * buildbot/process/base.py: Refactor command interruption. The
4189 Build is now responsible for noticing that the slave has gone
4190 away: Build.lostRemote() interrupts the current step and makes
4191 sure that no further ones will be started.
4193 * buildbot/process/builder.py: When the initial remote_startBuild
4194 message fails, log it: this usually indicates that the slave has
4195 gone away, but we don't really start paying attention until they
4196 fail to respond to the first step's command.
4198 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4199 slave disconnect. Now sports a new interrupt() method. Error
4200 handling was simplified a lot by chaining deferreds, so
4201 remoteFailed/remoteComplete were merged into a single
4202 remoteComplete method (which can now get a Failure object).
4203 Likewise failed/finished were merged into just _finished.
4204 (BuildStep): Add interrupt(why) method, and if why is a
4205 ConnectionLost Failure then the step is failed with some useful
4208 * buildbot/slave/bot.py: stop the current command when the remote
4209 Step reference is lost, and when the slave is shut down.
4210 (Bot): make it a MultiService, so it can have children. Use
4211 stopService to tell when the slave is shutting down.
4212 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4213 remote_interruptCommand (which asks the current SlaveCommand to
4214 stop but allows it to keep emitting status messages), and
4215 stopCommand (which tells it to shut up and die).
4217 * buildbot/slave/commands.py: make commands interruptible
4218 (ShellCommand.kill): factor out os.kill logic
4219 (Command): factor out setup()
4220 (Command.sendStatus): don't send status if .running is false, this
4221 happens when the command has been halted.
4222 (Command.interrupt): new method, used to tell the command to die
4223 (SlaveShellCommand): implement .interrupt
4224 (DummyCommand): implement .interrupt
4225 (SourceBase, etc): factor out setup(), don't continue substeps if
4228 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4229 so they can be called after finishing
4231 * buildbot/test/test_run.py: new tests for disconnect behavior,
4232 refactor slave-shutdown routines, add different kinds of
4235 2004-11-27 Brian Warner <warner@lothar.com>
4237 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4238 method to express ETA time like "2m45s" instead of "165 seconds"
4240 2004-11-24 Brian Warner <warner@lothar.com>
4242 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4243 archive after the test completes, to avoid cluttering the user's
4244 'tla archives' listing with a bogus entry. Arch doesn't happen to
4245 provide any way to override the use of ~/.arch-params/, so there
4246 isn't a convenient way to avoid touching the setup of the user who
4248 (VC_HTTP.testArchHTTP): same
4250 2004-11-23 Brian Warner <warner@lothar.com>
4252 * buildbot/status/html.py (TextLog): split render() up into
4253 render_HEAD and render_GET. Use a Producer when sending log
4254 chunks, to reduce memory requirements and avoid sending huge
4255 non-Banana-able strings over web.distrib connections. Requires
4256 peeking under the covers of IStatusLog.
4257 (TextLog.resumeProducing): fix the "as text" link, handle client
4258 disconnects that occur while we're still sending old chunks.
4260 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4261 use defer.succeed, not the non-existent defer.success
4262 (LogFile.waitUntilFinished): same
4263 (LogFile.subscribe): don't add watchers to a finished logfile
4265 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4268 2004-11-23 Brian Warner <warner@lothar.com>
4270 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4272 2004-11-23 Brian Warner <warner@lothar.com>
4274 * NEWS: update for the 0.6.1 release
4275 * MANIFEST.in: add new files
4277 * README (INSTALLATION): explain how to enable the extra VC tests
4279 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4280 level to, so old pickled builds can be displayed ok
4282 2004-11-22 Brian Warner <warner@lothar.com>
4284 * NEWS: summarize updates since last release
4286 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4287 Yoz Grahame. Closes SF#1050138.
4289 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4292 * buildbot/process/step_twisted.py (Trial): update docs a bit
4294 * docs/factories.xhtml: fix Trial factory docs to match reality.
4297 * buildbot/process/factory.py (Trial.__init__): add args for
4298 randomly= and recurse=, making them available to instantiators
4299 instead of only to subclassers. Closes: SF#1049759.
4301 2004-11-15 Brian Warner <warner@lothar.com>
4303 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4304 try to teach the Quick factory to use multiple versions of python
4306 2004-11-12 Brian Warner <warner@lothar.com>
4308 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4309 safer w32-compatible approach, and only use it on windows
4310 (BuildStatus.saveYourself): same
4312 2004-11-11 Brian Warner <warner@lothar.com>
4314 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4315 it: one string merge per chunk. There are now separate .entries
4316 and .runEntries lists: when enumerating over all chunks, make sure
4318 * buildbot/test/test_status.py (Log): more tests
4320 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4321 chunks together, up to 10kb per chunk. This ought to cut down on
4322 the CPU-burning overhead of large log files. Thanks to Alexander
4323 Staubo for spotting the problem.
4324 * buildbot/test/test_status.py (Log): tests for same
4326 2004-11-10 Brian Warner <warner@lothar.com>
4328 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4329 header to outbound mail
4330 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4332 2004-11-08 Brian Warner <warner@lothar.com>
4334 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4335 can't do os.rename() onto an existing file, so catch the exception
4336 and unlink the target file first. This introduces a slight window
4337 where the existing file could be lost, but the main failure case
4338 (disk full) should still be handled safely.
4339 (BuildStatus.saveYourself): same
4341 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4342 separator character instead of os.sep, because the filenames being
4343 split here are coming from the VC system, which can have a
4344 different pathname convention than the local host. This should
4345 help a buildmaster running on windows that uses a CVS repository
4346 which runs under unix.
4347 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4349 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4350 when there are no test failures to be parsed
4352 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4353 instead of the unix-specific os.system("cp"), thanks to Elliot
4354 Murphy for this and the other buildbot-vs-windows catches.
4355 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4357 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4358 echo the command as it is run
4360 * setup.py: install sample.mk too, not just sample.cfg
4361 (scripts): install contrib/windows/buildbot.bat on windows
4363 2004-11-07 Brian Warner <warner@lothar.com>
4365 * buildbot/process/builder.py (Builder._detached): clear the
4366 self.currentBuild reference, otherwise the next build will be
4367 skipped because we think the Builder is already in use.
4369 * docs/examples/twisted_master.cfg: update to match current usage
4370 on the Twisted buildbot
4372 2004-10-29 Brian Warner <warner@lothar.com>
4374 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4376 2004-10-28 Brian Warner <warner@lothar.com>
4378 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4379 have separate doVCUpdate/doVCFull methods. Catch an update failure
4380 and respond by clobbering the source directory and re-trying. This
4381 will handle local changes (like replacing a file with a directory)
4382 that will cause CVS and SVN updates to fail.
4383 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4385 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4388 2004-10-19 Brian Warner <warner@lothar.com>
4390 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4392 * buildbot/status/html.py (StatusResourceTestResults): display any
4393 TestResults that the Build might have
4394 (StatusResourceTestResult): and the logs for each TestResult
4395 (StatusResourceBuild): add link from the per-build page
4397 2004-10-15 Brian Warner <warner@lothar.com>
4399 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4400 the 'problems' portion of stdout, add TestResults to our build
4401 * buildbot/test/test_twisted.py (Parse.testParse): test it
4403 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4404 to retrieve a dict of accumulated test results
4405 (ITestResult): define what a single test result can do
4406 * buildbot/status/builder.py (TestResult): implement ITestResult
4407 (BuildStatus.getTestResults): retrieve dict of TestResults
4408 (BuildStatus.addTestResult): add TestResults
4409 * buildbot/test/test_status.py (Results.testAddResults): test it
4411 2004-10-14 Brian Warner <warner@lothar.com>
4413 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4414 instead of os.system("rm -rf") for win32 portability
4416 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4417 SignalMixin instead of starting/stopping the reactor, which is
4418 likely to cause problems with other tests
4420 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4421 self.copyComplete() call. Yoz Grahame makes the catch.
4423 * contrib/windows/buildbot.bat: helper script to deal with path
4424 issues. Thanks to Yoz Grahame.
4426 * buildbot/master.py (BuildMaster.startService): don't register a
4427 SIGHUP handler if the signal module has no SIGHUP attribute.
4428 Apparently win32 does this.
4430 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4432 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4433 test if the reactor can't offer UNIX sockets
4435 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4436 error introduced in the last commit. We really need that
4439 2004-10-12 Brian Warner <warner@lothar.com>
4441 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4442 when describing a maildir source. Thanks to Stephen Davis.
4444 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4447 * buildbot/scripts/runner.py (createMaster): install Makefile too
4448 (start): add --no_save to 'start' command
4449 * buildbot/scripts/sample.mk: simple convenience Makefile with
4450 start/stop/reload targets
4452 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4455 2004-09-30 Brian Warner <warner@lothar.com>
4457 * setup.py: Releasing buildbot-0.6.0
4459 2004-09-30 Brian Warner <warner@lothar.com>
4461 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4462 test_trial.py from the source tarball until support is complete.
4464 * NEWS: update for 0.6.0 release
4465 * buildbot/__init__.py (version): same
4468 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4469 'source' command to tell users where to get the Buildbot source
4471 * docs/examples/*.cfg: update to modern standards
4473 * NEWS: update for release
4475 * buildbot/scripts/runner.py (createMaster): remove the
4476 -shutdown.tap stuff now that it isn't necessary
4478 (start): launch buildbot.tap, not buildbot-shutdown.tap
4481 * buildbot/status/mail.py (Domain): shorten class name
4482 (MailNotifier): if lookup= is a string, pass it to Domain()
4483 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4484 (Mail.testBuild2): test the string-to-Domain shortcut
4485 (Mail.testMail): fix test
4488 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4491 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4492 more attributes on load
4493 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4494 to accomodate the whole waterfall page at once, and the thrashing
4495 results in a lot of unnecessary loads
4496 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4497 (BuilderStatus.saveYourself): same
4498 (BuilderStatus.eventGenerator): stop generating on the first missing
4499 build. We assume that saved builds are deleted oldest-first.
4500 (BuildStepStatus.__getstate__): .progress might not exist
4502 * buildbot/changes/changes.py (ChangeMaster): make it
4503 serializable, in $masterdir/changes.pck
4504 (ChangeMaster.stopService): save on shutdown
4505 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4506 * buildbot/test/test_config.py: load Changes before config file
4509 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4510 "Oh my god, you killed the command" header on a separate line
4512 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4513 skip over corrupted build pickles
4514 (BuilderStatus.getFullBuildByNumber): same
4515 (BuilderStatus.eventGenerator): skip over unavailable builds
4516 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4517 do an atomic rename. This prevents a corrupted pickle when some
4518 internal serialization error occurs.
4519 (BuilderStatus.saveYourself): same
4521 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4522 the timeout for shell commands, it got lost somehow
4524 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4525 run out of build steps, return the rest of the builder events
4527 * buildbot/interfaces.py (IBuilderControl.ping): add method
4529 * buildbot/process/builder.py (BuilderControl.ping): move
4530 slave-ping to BuilderControl, and fix the failure case in the
4531 process (Event.finish() is the verb, Event.finished is the noun).
4533 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4534 through the BuilderControl instead of the BuilderStatus
4535 (EventBox): add adapter for builder.Event, allowing builder events to
4536 be displayed in the waterfall display
4538 * buildbot/master.py (BotMaster.stopService): add a 'master
4539 shutdown' event to the builder's log
4540 (BuildMaster.startService): and a 'master started' on startup
4542 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4543 builder events into the BuildStep event stream
4544 (Status.builderAdded): add a 'builder created' event
4547 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4548 command to announce the completion of a running build
4549 (IrcStatusBot.command_FORCE): announce when the build finishes
4551 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4552 don't evict unfinished builds from the cache: they must stay in
4553 the full-cache until their logfiles have stopped changing. Make
4554 sure the eviction loop terminates if an unfinished build was hit.
4555 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4556 This lets exceptions be dumped in an email status message. Really
4557 we need LogFiles which contain both text and HTML, instead of two
4559 (BuildStatus.__getstate__): handle self.finished=False
4560 (Status.builderAdded): if the pickle is corrupted, abandon the
4561 history and create a new BuilderStatus object.
4563 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4564 self.progress attribute, helped one test which doesn't fully set
4565 up the Build object.
4567 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4568 IStatusLog methods into an Interface that is implemented by "stub"
4569 logs, for which all the actual text chunks are on disk (in the
4570 pickled Build instance). To show the log contents, you must first
4571 adapt the stub log to a full IStatusLog object.
4573 * buildbot/status/builder.py (LogFileStub): create separate stub
4574 log objects, which can be upgraded to a real one if necessary.
4575 (LogFile): make them persistable, and let them stubify themselves
4577 (BuildStepStatus): same
4579 (BuildStatus.saveYourself): save the whole build out to disk
4580 (BuilderStatus): make it persistable
4581 (BuilderStatus.saveYourself): save the builder to disk
4582 (BuilderStatus.addFullBuildToCache): implement two caches which
4583 hold Build objects: a small one which holds full Builds, and a
4584 larger one which holds "stubbed" Builds (ones with their LogFiles
4585 turned into LogFileStubs). This reduces memory usage by the
4586 buildmaster by not keeping more than a few (default is 2) whole
4587 build logs in RAM all the time.
4588 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4590 (BuilderStatus.eventGenerator): rewrite since .builds went away
4591 (BuilderStatus.buildStarted): remove the .builds array. Add the
4592 build to the "full" cache when it starts.
4593 (BuilderStatus._buildFinished): save the build to disk when it
4595 (Status): give it a basedir (same as the BuildMaster's basedir)
4596 where the builder pickles can be saved
4597 (Status.builderAdded): create the BuilderStatus ourselves, by
4598 loading a pickle from disk (or creating a new instance if there
4599 was none on disk). Return the BuilderStatus so the master can glue
4600 it into the new Builder object.
4602 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4603 all BuilderStatuses to save themselves out to disk. This is in
4604 lieu of saving anything important in the main Application pickle
4605 (the -shutdown.tap file).
4606 (BuildMaster.__init__): give Status() a basedir for its files
4607 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4608 to get the BuilderStatus, then give it to the Builder (instead of
4609 doing it the other way around). It's ok if the status announces
4610 the new Builder before it's really ready, as the outside world can
4611 only see the BuilderStatus object anyway (and it is ready before
4612 builderAdded returns). Use the builder's "builddir" (which
4613 normally specifies where the slave will run the builder) as the
4614 master's basedir (for saving serialized builds).
4616 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4617 coerce the logfile to IStatusLog before trying to get the text
4618 chunks out of it. This will pull the full (non-stubified) Build in
4619 from disk if necessary.
4620 (TextLog): fix the adapter registration
4622 * buildbot/test/test_control.py (Force.setUp): create the basedir
4623 * buildbot/test/test_web.py: same
4624 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4625 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4626 * buildbot/test/test_run.py (Run.testMaster): same
4627 (Status.setUp): same
4629 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4631 * buildbot/status/html.py (Waterfall.__init__): store actual
4632 allowForce flag passed in rather than using True for everyone;
4633 make sure setting it to False doesn't cause a NameError
4635 (StatusResourceBuilder.__init__) add the builder name to the page
4637 (StatusResourceBuilder.body) move HTML generation for a name/value
4638 row into a helper method (StatusResourceBuilder.make_row); only
4639 generate the "Force Build" form if allowForce was True and the
4640 slave is connected. Use class attributes in the generated HTML to
4641 spread a little CSS-joy.
4643 2004-09-28 Brian Warner <warner@lothar.com>
4645 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4646 warning-scanner to not ignore things like
4647 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4649 * buildbot/status/html.py (StatusResource.control): add some
4650 class-level values for .control in an attempt to make upgrading
4653 * buildbot/util.py (ComparableMixin): survive missing attributes,
4654 such as when a class is modified and we're comparing old instances
4657 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4658 failure handling, remove a redundant try/except block. Don't
4659 return the full traceback to the IRC channel.
4660 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4661 error messages. Get ETA properly.
4663 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4664 the reason, since (at least) IRC message will have <> in them.
4665 (StatusResourceBuilder.__init__): take an IBuilderControl
4666 (StatusResourceBuilder.force): use the IBuilderControl we get in
4667 the constructor instead of trying to make our own. Catch the
4668 new exceptions and ignore them for now (until we make an
4669 intermediate web page where we could show the error message)
4670 (StatusResource): create with an IControl, use it to give an
4671 IBuilderControl to all children
4672 (Waterfall): take an allowForce= option, pass an IControl object
4673 to StatusResource if it is True
4675 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4677 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4678 catch new exceptions and return string forms
4680 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4681 * buildbot/process/builder.py (Builder.forceBuild): raise them
4682 * buildbot/test/test_control.py (Force.testNoSlave): new test
4683 (Force.testBuilderInUse): same
4686 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4688 * buildbot/test/test_run.py: use IControl
4689 * buildbot/test/test_vc.py: same
4691 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4692 to use IControl. Still offline.
4693 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4695 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4696 who=None so periodic builds don't send out status mail
4697 (Builder.forceBuild): include reason in the log message
4698 (BuilderControl.forceBuild): rename 'name' to 'who'
4700 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4701 'who' parameter, but make it None by default so builds forced by
4702 slave admins don't cause status mail to be sent to anybody
4703 (BotMaster.forceBuild): same. this method is deprecated.
4704 (DebugPerspective.perspective_forceBuild): same, use IControl.
4705 (DebugPerspective.perspective_fakeChange): use IControl..
4706 (Dispatcher.requestAvatar): .. so don't set .changemaster
4708 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4709 parameter to avoid confusion with the name of the builder
4712 * buildbot/status/mail.py: refine comment about needing 2.3
4714 * buildbot/status/html.py: move all imports to the top
4716 * buildbot/test/test_control.py: test new interfaces
4717 * buildbot/test/test_run.py (Status): handle new interfaces
4718 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4720 * buildbot/process/base.py (BuildControl): implement IBuildControl
4721 and its lonely getStatus() method
4723 * buildbot/process/builder.py (BuilderControl): implement
4724 IBuilderControl, obtained by adapting the Builder instance
4725 (Builder.startBuild): return a BuilderControl instead of a
4726 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4727 accomplish the same thing.
4729 * buildbot/master.py: move all import statements to the top
4730 (Control): implement IControl, obtained by adapting the
4731 BuildMaster instance.
4733 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4734 IBuildControl. These are used to force builds. Eventually they
4735 will provide ways to reconfigure the Builders, pause or abandon a
4736 Build, and perhaps control the BuildMaster itself.
4738 2004-09-26 Brian Warner <warner@lothar.com>
4740 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4741 ends up comparing us against something without a .__class__
4743 2004-09-24 Brian Warner <warner@lothar.com>
4745 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4748 * Makefile: add 'deb-snapshot' target, to create a timestamped
4751 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4753 2004-09-23 Brian Warner <warner@lothar.com>
4755 * buildbot/__init__.py (version): move version string here
4756 * setup.py: get version string from buildbot.version
4757 * buildbot/status/html.py (WaterfallStatusResource.body): add
4758 buildbot version to the page footer
4759 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4762 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4763 slaves, let the second know where the first one is coming from
4764 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4765 see our exceptions. It would be nice if there were a way to just
4766 send them the exception type and value, not the full traceback.
4769 * buildbot/status/mail.py (MailNotifier): add a new argument
4770 sendToInterestedUsers=, which can be set to False to disable the
4771 usual send-to-blamelist behavior.
4772 (top): handle python-2.2 which has no email.MIMEMultipart
4773 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4774 (MailNotifier.disownServiceParent): unsubscribe on removal
4776 * buildbot/test/test_status.py (Mail.testBuild2): test it
4779 * buildbot/status/progress.py (Expectations.wavg): tolerate
4780 current=None, which happens when steps start failing badly
4781 * buildbot/test/test_status.py (Progress.testWavg): test for it
4783 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4784 doesn't understand args['revision'], emit a warning instead of
4785 bailing completely. Updating to -rHEAD is probably close enough.
4787 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4789 * buildbot/test/test_status.py: at least import bb.status.client
4790 even if we don't have any test coverage for it yet
4792 * contrib/svn_buildbot.py: don't require python2.3
4793 (main): wait, do require it (for sets.py), but explain how to
4794 make it work under python2.2
4796 2004-09-23 Brian Warner <warner@lothar.com>
4798 * contrib/svn_buildbot.py: include the revision number in the Change
4800 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4801 using util.now() because FreshCVS is a realtime service
4803 * buildbot/status/event.py: delete dead code
4804 * buildbot/process/step.py: don't import dead Event class
4805 * buildbot/process/step_twisted.py: same
4806 * buildbot/status/builder.py: same
4807 * buildbot/status/client.py: same
4809 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4811 * buildbot/changes/changes.py (Change): set .when from an __init__
4812 argument (which defaults to now()), rather than having
4813 ChangeMaster.addChange set it later.
4814 (ChangeMaster.addChange): same
4816 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4817 (parseSyncmail): same. Just use util.now() for now.
4818 (parseBonsaiMail): parse the timestamp field for when=
4820 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4821 instead of setting .when after the fact
4825 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4826 results when the target project uses retrial. Still under
4828 * buildbot/test/test_trial.py: same
4830 2004-09-21 Brian Warner <warner@lothar.com>
4832 * buildbot/status/mail.py (MailNotifier.__init__): include
4833 success/warnings/failure in the Subject line
4834 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4835 use step.logname for the addLogs=True attachment filenames
4836 * buildbot/test/test_status.py (Mail): test Subject lines
4837 (Mail.testLogs): test attachment filenames
4839 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4840 accept a 'who' argument from the debug tool
4841 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4842 * contrib/debug.glade: add text box to set 'who'
4844 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4845 .getBuilderName with .getBuilder().getName(), more flexible
4846 (IStatusLog.getName): logs have short names, but you can prefix
4847 them with log.getStep().getName() to make them more useful
4848 * buildbot/status/builder.py: same
4849 * buildbot/status/client.py: same
4850 * buildbot/status/html.py: same
4851 * buildbot/test/test_run.py (Status.testSlave): same
4852 * buildbot/process/step.py: tweak logfile names
4854 * buildbot/status/mail.py (MailNotifier): add lookup, change
4855 argument to extraRecipients. The notifier is now aimed at sending
4856 mail to the people involved in a particular build, with additional
4857 constant recipients as a secondary function.
4859 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4860 including slow-lookup and failing-lookup. Make sure the blamelist
4861 members are included.
4863 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4864 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4865 (IBuildStatus.getInterestedUsers): new method
4866 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4867 * buildbot/status/client.py (remote_getResponsibleUsers): same
4868 * buildbot/status/html.py (StatusResourceBuild.body): same
4869 * buildbot/test/test_run.py (Status.testSlave): same
4871 2004-09-20 Brian Warner <warner@lothar.com>
4873 * docs/users.xhtml: update concepts
4875 * Makefile: add a convenience makefile, for things like 'make
4876 test'. It is not included in the source tarball.
4878 2004-09-16 Brian Warner <warner@lothar.com>
4880 * NEWS: mention /usr/bin/buildbot, debian/*
4882 * debian/*: add preliminary debian packaging. Many thanks to
4883 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4884 it considerably since it left their hands, I am responsible for
4885 all breakage that's resulted.
4887 * bin/buildbot: create a top-level 'buildbot' command, to be
4888 installed in /usr/bin/buildbot . For now it's just a simple
4889 frontend to mktap/twistd/kill, but eventually it will be the entry
4890 point to the 'try' command and also a status client. It is also
4891 intended to support the upcoming debian-packaging init.d scripts.
4892 * buildbot/scripts/runner.py: the real work is done here
4893 * buildbot/scripts/__init__.py: need this too
4894 * buildbot/scripts/sample.cfg: this is installed in new
4895 buildmaster directories
4896 * setup.py: install new stuff
4898 2004-09-15 Brian Warner <warner@lothar.com>
4900 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4901 'file:' schema (the version shipped with OS-X was built without the
4903 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4904 updates the log-timestamp, to make sure it isn't still running after
4907 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4908 values to the config file.
4909 * docs/examples/hello.cfg: add examples
4910 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4911 * buildbot/status/builder.py (Status.getProjectURL): implement them
4912 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4913 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
4914 * buildbot/status/html.py (WaterfallStatusResource): display them
4917 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
4918 certain error cases don't suffer a secondary exception.
4919 (top): Skip tests if the corresponding VC tool is not installed.
4921 * buildbot/process/factory.py (Trial): introduce separate
4922 'buildpython' and 'trialpython' lists, since trialpython=[] is
4923 what you want to invoke /usr/bin/python, whereas ./setup.py is
4924 less likely to be executable. Add env= parameter to pass options
4925 to test cases (which is how I usually write tests, I don't know if
4926 anyone else does it this way).
4928 * buildbot/process/step_twisted.py (Trial): handle python=None.
4929 Require 'testpath' be a string, not a list. Fix tests= typo.
4930 (Trial.start): sanity-check any PYTHONPATH value for stringness.
4932 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
4933 way to deal with the possibility of removing the disconnect notify
4935 (CVS): add a 'login' parameter to give a password to 'cvs login',
4936 commonly used with pserver methods (where pw="" or pw="guest")
4938 * buildbot/slave/commands.py (SourceBase): move common args
4939 extraction and setup() to __init__, so everything is ready by the
4940 time setup() is called
4941 (CVS.start): call 'cvs login' if a password was supplied
4942 (ShellCommand): special-case PYTHONPATH: prepend the master's
4943 value to any existing slave-local value.
4945 * buildbot/process/builder.py (Builder.updateBigStatus): if we
4946 don't have a remote, mark the builder as Offline. This whole
4947 function should probably go away and be replaced by individual
4949 (Builder.buildFinished): return the results to the build-finished
4950 deferred callback, helps with testing
4952 2004-09-14 Brian Warner <warner@lothar.com>
4954 * buildbot/test/test_vc.py: put all the repositories needed to run
4955 the complete tests into a single small (1.3MB) tarball, so I can
4956 make that tarball available on the buildbot web site. Test HTTP
4957 access (for Arch and Darcs) by spawning a temporary web server
4958 while the test runs.
4960 * docs/users.xhtml: new document, describe Buildbot's limited
4961 understanding of different human users
4963 * buildbot/test/test_vc.py: rearrange test cases a bit
4965 * buildbot/process/step_twisted.py (Trial): handle testpath=
4966 * buildbot/process/factory.py (Trial): update to use step.Trial
4968 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
4970 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
4971 the overall build text (which gives you 'failed 2 tests' rather
4973 (BuildStepStatus.text2): default to [], not None
4975 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
4978 2004-09-12 Brian Warner <warner@lothar.com>
4980 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
4981 log the whole exception if it's just an AttributeError (old slave)
4983 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
4984 so (e.g.) sub-commands can be run in the right directory.
4985 (ShellCommand.start): accept an optional errorMessage= argument
4986 to make life easier for SVN.start
4987 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
4989 (ShellCommand.start): move ['dir'] compatibility hack..
4990 (RemoteShellCommand.start): .. to here so everyone can use it
4992 * buildbot/process/step_twisted.py (Trial): use .workdir
4994 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
4995 text displayed when debuild fails completely
4996 (Trial): snarf _trial_temp/test.log from the slave and display it
4998 2004-09-11 Brian Warner <warner@lothar.com>
5000 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5002 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5003 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5005 * buildbot/process/step.py (ShellCommand): call .createSummary
5006 before .evaluateCommand instead of the other way around. This
5007 makes it slightly easier to count warnings and then use that to
5008 set results=WARNINGS
5009 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5011 * buildbot/process/base.py (Build.buildFinished): update status
5012 before doing progress. It's embarrassing for the build to be stuck
5013 in the "building" state when an exceptions occurs elsewhere..
5015 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5016 python2.2 doesn't have 'sum'
5018 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5019 to prevent clients from accidentally sorting it
5021 * buildbot/master.py (Manhole): add username/password
5022 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5023 c['manholePort'], deprecate old usage
5024 * docs/config.xhtml: document c['manhole']
5025 * docs/examples/hello.cfg: show example of using a Manhole
5028 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5029 pretend the slave is up to date
5031 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5032 the module, overlaps with 'log', the local variable
5034 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5036 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5037 new method to let Steps find out the version of their
5038 corresponding SlaveCommand.
5039 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5040 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5041 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5043 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5044 (Arch.startVC): same
5045 (P4Sync.startVC): same
5047 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5048 Deferred so we can catch errors in remote_startCommand
5049 (RemoteShellCommand.start): same
5051 * docs/examples/twisted_master.cfg: update sample config file
5053 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5054 after connectionMade() is called, not before. Close stdin at that
5057 * buildbot/process/process_twisted.py: update to use Trial, clean
5058 up argument passing (move to argv arrays instead of string
5061 * buildbot/process/step_twisted.py (Trial): new step to replace
5062 RunUnitTests, usable by any trial-using project (not just
5063 Twisted). Arguments have changed, see the docstring for details.
5065 * buildbot/process/base.py (Build.startBuild): this now returns a
5066 Deferred. Exceptions that occur during setupBuild are now
5067 caught better and lead to fewer build_status weirdnesses, like
5068 finishing a build that was never started.
5069 (Build.buildFinished): fire the Deferred instead of calling
5070 builder.buildFinished directly. The callback argument is this
5071 Build, everything else can be extracted from it, including the
5072 new build.results attribute.
5073 * buildbot/process/builder.py (Builder.startBuild): same
5074 (Builder.buildFinished): same, extract results from build
5076 * buildbot/process/step.py (ShellCommands): remove dead code
5078 2004-09-08 Brian Warner <warner@lothar.com>
5080 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5081 doesn't try to use the leftover patched workdir
5082 (SourceStamp): test source-stamp computation for CVS and SVN
5084 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5085 patched workdir ('touch .buildbot-patched') so we don't try to
5087 (SourceBase.start): add ['revision'] for all Source steps
5088 (CVS): change args: use ['branch'] for -r, remove ['files']
5089 (CVS.buildVC): fix revision/branch stuff
5090 (SVN): add revision stuff
5092 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5093 kwargs (except 'workdir') to avoid silent spelling errors
5094 (ShellCommand.__init__): same
5095 (Source): new base class for CVS/SVN/etc. Factor out everything
5096 common, add revision computation (perform the checkout with a -D
5097 DATE or -r REVISION that gets exactly the sources described by the
5098 last Change), overridable with step.alwaysUseLatest. Add patch
5099 handling (build.getSourceStamp can trigger the use of a base
5100 revision and a patch).
5101 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5102 * docs/steps.xhtml: update docs
5103 * docs/source.xhtml: mention .checkoutDelay
5104 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5106 * buildbot/process/base.py (Build.setSourceStamp): add a
5107 .sourceStamp attribute to each Build. If set, this indicates that
5108 the build should be done with something other than the most
5109 recent source tree. This will be used to implement "try" builds.
5110 (Build.allChanges): new support method
5111 (Build.lastChangeTime): remove, functionality moved to Source steps
5112 (Build.setupBuild): copy the Step args before adding ['workdir'],
5113 to avoid modifying the BuildFactory (and thus triggering spurious
5117 * buildbot/status/html.py: rename s/commits/changes/
5118 (StatusResourceChanges): same
5119 (CommitBox.getBox): same, update URL
5120 (WaterfallStatusResource): same
5121 (StatusResource.getChild): same
5123 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5124 * contrib/debug.glade: add optional 'revision' to the fakeChange
5126 * buildbot/changes/changes.py (html_tmpl): display .revision
5127 (ChangeMaster.addChange): note .revision in log
5128 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5129 accept a ['revision'] attribute
5131 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5133 * buildbot/master.py (BotMaster.getPerspective): update the
5134 .connected flag in SlaveStatus when it connects
5135 (BotMaster.detach): and when it disconnects
5136 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5137 (BuildMaster.loadConfig_Builders): walk old list correctly
5139 * buildbot/test/test_config.py: fix prefix= usage
5141 2004-09-06 Brian Warner <warner@lothar.com>
5145 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5146 poll a P4 depot looking for recent changes. Thanks to Dave
5147 Peticolas for the contribution. Probably needs some testing after
5150 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5151 requires manual client setup for each buildslave. Rather
5152 experimental. Thanks again to Dave Peticolas.
5153 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5155 * buildbot/changes/changes.py (Change): add a .revision attribute,
5156 which will eventually be used to generate source-stamp values.
5158 * buildbot/process/step.py (RemoteCommand.start): use
5159 notifyOnDisconnect to notice when we lose the slave, then treat it
5160 like an exception. This allows LogFiles to be closed and the build
5161 to be wrapped up normally. Be sure to remove the disconnect
5162 notification when the step completes so we don't accumulate a
5163 bazillion such notifications which will fire weeks later (when the
5164 slave finally disconnects normally). Fixes SF#915807, thanks to
5165 spiv (Andrew Bennetts) for the report.
5166 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5167 really isn't Logged- specific
5168 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5169 header, since it's almost always going to be appended to an
5171 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5172 update test to handle use of notifyOnDisconnect
5174 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5175 don't clear .ETA and .currentBuild when going offline, let the
5176 current build clean up after itself
5178 * buildbot/process/builder.py (Builder.detached): wait a moment
5179 before doing things like stopping the current build, because the
5180 current step will probably notice the disconnect and cleanup the
5182 * buildbot/test/test_run.py (Status.tearDown): update test to
5183 handle asynchronous build-detachment
5185 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5187 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5188 hush a debug message
5190 2004-09-05 Brian Warner <warner@lothar.com>
5192 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5193 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5194 kernels do this: the fcntl module has the F_NOTIFY constant, but
5195 the kernel itself doesn't support the operation. Thanks to Olly
5196 Betts for spotting the problem.
5198 * buildbot/process/step.py (Darcs): new source-checkout command
5199 (Arch): new source-checkout command
5200 (todo_P4): fix constructor syntax, still just a placeholder
5201 * buildbot/test/test_vc.py (VC.testDarcs): test it
5202 (VC.testDarcsHTTP): same, via localhost HTTP
5204 (VC.testArchHTTP): same
5205 * NEWS: mention new features
5207 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5208 which tells the step to stash stdout text locally (in .stdout).
5209 Slave-side Commands can use this to make decisions based upon the
5210 output of the the ShellCommand (not just the exit code).
5211 (Darcs): New source-checkout command
5212 (Arch): New source-checkout command, uses .keepStdout in one place
5213 where it needs to discover the archive's default name.
5215 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5216 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5217 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5219 * buildbot/process/step.py (ShellCommand.describe): add an
5220 alternate .descriptionDone attribute which provides descriptive
5221 text when the step is complete. .description can be ["compiling"],
5222 for use while the step is running, then .descriptionDone can be
5223 ["compile"], used alone when the step succeeds or with "failed" when
5224 it does not. Updated other steps to use the new text.
5225 * buildbot/process/step_twisted.py: same
5226 * buildbot/test/test_run.py: update tests to match
5228 2004-08-30 Brian Warner <warner@lothar.com>
5230 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5231 (CVS.__init__): send 'patch' argument to slave
5232 (CVS.start): don't create the LoggedRemoteCommand until start(),
5233 so we can catch a .patch added after __init__
5234 (SVN.__init__): add 'patch' to SVN too
5237 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5238 argument, to let commands push data into the process' stdin pipe.
5239 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5240 is in use, since closing a PTY doesn't really affect the process
5241 in the right way (in particular, I couldn't run /usr/bin/patch
5243 (SourceBase.doPatch): handle 'patch' argument
5245 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5248 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5249 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5251 * buildbot/master.py (BotPerspective.got_commands): get command
5252 versions from slave, give to each builder
5253 * buildbot/process/builder.py (Builder.attached): stash slave
5254 command versions in .remoteCommands
5256 * docs/steps.xhtml: bring docs in-line with reality
5258 * buildbot/process/step.py (CVS.__init__): more brutal
5259 compatibility code removal
5260 (SVN.__init__): same
5262 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5263 (SlaveShellCommand.start): require ['workdir'] argument, remove
5264 the ['dir'] fallback (compatibility will come later)
5265 (SourceBase): update docs
5266 (SourceBase.start): remove ['directory'] fallback
5269 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5270 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5271 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5273 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5274 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5275 code.. I will figure out 0.5.0-compatibility hooks later)
5277 2004-08-30 Brian Warner <warner@lothar.com>
5279 * buildbot/process/process_twisted.py: rewrite in terms of new
5280 BuildFactory base class. It got significantly shorter. Yay
5283 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5284 work with the new "self.build isn't nailed down until we call
5285 step.start()" scheme: specifically, __init__ is called before the
5286 build has decided on which Changes are going in, so we don't scan
5287 build.allFiles() for .xhtml files until start()
5288 (HLint.commandComplete): use getText(), not getStdout()
5289 (RunUnitTests.start): same: don't use .build until start()
5290 (RunUnitTests.describe): oops, don't report (None) when using
5292 (RunUnitTests.commandComplete): use getText()
5293 (RunUnitTests.createSummary): same
5294 (BuildDebs.commandComplete): same
5296 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5297 set args['command'] until start(), since our BuildStep is allowed
5298 to change their mind up until that point
5299 (TreeSize.commandComplete): use getText(), not getStdout()
5301 * docs/examples/twisted_master.cfg: update to current standards
5303 * docs/factories.xhtml: update
5304 * buildbot/process/factory.py: implement all the common factories
5305 described in the docs. The Trial factory doesn't work yet, and
5306 I've probably broken all the process_twisted.py factories in the
5307 process. There are compatibility classes left in for things like
5308 the old BasicBuildFactory, but subclasses of them are unlikely to
5310 * docs/examples/glib_master.cfg: use new BuildFactories
5311 * docs/examples/hello.cfg: same
5313 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5314 explicit 'workdir' args
5316 * buildbot/process/base.py (BuildFactory): move factories to ..
5317 * buildbot/process/factory.py (BuildFactory): .. here
5318 * buildbot/process/process_twisted.py: handle move
5319 * buildbot/test/test_config.py: same
5320 * buildbot/test/test_run.py: same
5321 * buildbot/test/test_steps.py: same
5322 * buildbot/test/test_vc.py: same
5323 * docs/factories.xhtml: same
5325 * NEWS: mention config changes that require updating master.cfg
5327 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5328 argument to all steps that weren't given one already, pointing at
5329 the "build/" directory.
5331 * docs/examples/hello.cfg: remove explicit 'workdir' args
5333 * docs/factories.xhtml: document standard BuildFactory clases,
5334 including a bunch which are have not yet been written
5336 2004-08-29 Brian Warner <warner@lothar.com>
5338 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5339 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5340 buildbot.status.builder so they aren't quite so internal
5341 * buildbot/process/base.py, buildbot/process/builder.py: same
5342 * buildbot/process/maxq.py, buildbot/process/step.py: same
5343 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5344 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5345 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5347 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5348 to handle new getLogs()-returns-list behavior
5349 (StatusResourceBuildStep.getChild): same
5350 (StepBox.getBox): same
5351 (WaterfallStatusResource.phase0): same
5353 * docs/source.xhtml: document how Buildbot uses version-control
5354 systems (output side: how we get source trees)
5355 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5356 systems (input side: how we learn about Changes)
5358 * buildbot/master.py (Manhole): use ComparableMixin
5359 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5360 * buildbot/changes/mail.py (MaildirSource): same
5361 * buildbot/status/client.py (PBListener): same
5362 * buildbot/status/html.py (Waterfall): same
5363 * buildbot/status/words.py (IRC): same
5365 * NEWS: start describing new features
5367 * buildbot/status/mail.py (MailNotifier): finish implementation.
5368 The message body is still a bit sparse.
5369 * buildbot/test/test_status.py (Mail): test it
5371 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5372 and __hash__ methods I wind up adding everywhere. Specifically
5373 intended to support the buildbot config-file update scheme where
5374 we compare, say, the old list of IStatusTargets against the new
5375 one and don't touch something which shows up on both lists.
5376 * buildbot/test/test_util.py (Compare): test case for it
5378 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5379 return a list instead of a dict
5380 (IBuildStepStatus.getLogs): same. The idea is that steps create
5381 logs with vaguely unique names (although their uniqueness is not
5382 guaranteed). Thus a compilation step should create its sole
5383 logfile with the name 'compile', and contribute it to the
5384 BuildStatus. If a step has two logfiles, try to create them with
5385 different names (like 'test.log' and 'test.summary'), and only
5386 contribute the important ones to the overall BuildStatus.
5387 * buildbot/status/builder.py (Event.getLogs): same
5388 (BuildStepStatus): fix default .text and .results
5389 (BuildStepStatus.addLog): switch to list-like .getLogs()
5390 (BuildStepStatus.stepFinished): same
5391 (BuildStatus.text): fix default .text
5392 (BuildStatus.getLogs): temporary hack to return all logs (from all
5393 child BuildStepStatus objects). Needs to be fixed to only report
5394 the significant ones (as contributed by the steps themselves)
5395 * buildbot/test/test_run.py: handle list-like .getLogs()
5396 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5398 2004-08-28 Brian Warner <warner@lothar.com>
5400 * buildbot/process/builder.py (Builder.attached): serialize the
5401 attachment process, so the attach-watcher isn't called until the
5402 slave is really available. Add detached watchers too, which makes
5405 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5407 * buildbot/test/test_swap.py: remove dead code
5409 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5410 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5411 sort of as if the command being run exited with a -1. There may
5412 still be some holes in this scheme.
5413 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5414 -r option appears before the module list
5415 * buildbot/process/step.py (CVS): add 'revision' argument
5417 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5418 when sending updates or stepComplete messages to the master, since
5419 we don't currently care whether they arrive or not. When we revamp
5420 the master/slave protocol to really resume interrupted builds,
5421 this will need revisiting.
5422 (lostRemote): remove spurious print
5424 * buildbot/master.py (BotPerspective.attached): serialize the
5425 new-builder interrogation process, to make testing easier
5426 (BotMaster.waitUntilBuilderDetached): convenience function
5428 * buildbot/status/builder.py (BuilderStatus): prune old builds
5429 (BuildStatus.pruneSteps): .. and steps
5430 (BuildStepStatus.pruneLogs): .. and logs
5431 (BuilderStatus.getBuild): handle missing builds
5432 * buildbot/status/html.py (StatusResourceBuild.body): display build
5433 status in the per-build page
5434 (BuildBox.getBox): color finished builds in the per-build box
5436 2004-08-27 Brian Warner <warner@lothar.com>
5438 * buildbot/status/mail.py (MailNotifier): new notification class,
5441 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5442 variants of a common base class which handles all the mode= logic
5444 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5446 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5448 2004-08-26 Brian Warner <warner@lothar.com>
5450 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5453 * buildbot/test/test_run.py: update to new Logfile interface, new
5454 buildbot.slave modules
5455 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5457 * MANIFEST.in: new sample config file
5458 * docs/examples/hello.cfg: same
5460 * buildbot/process/step_twisted.py: remove dead import
5462 * buildbot/process/step.py (RemoteCommand.run): catch errors
5464 (RemoteCommand.remote_update): ignore updates that arrive after
5466 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5467 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5468 the responsibilities of the subclass's methods
5469 (BuildStep.failed): catch errors during failure processing
5470 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5471 (CVS): move to a mode= argument (described in docstring), rather
5472 than the ungainly clobber=/export=/copydir= combination.
5473 (SVN): add mode= functionality to SVN too
5474 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5476 * buildbot/process/base.py (Build.startNextStep): catch errors
5477 during s.startStep()
5479 * buildbot/clients/base.py: update to new PB client interface.
5480 gtkPanes is still broken
5482 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5483 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5484 * setup.py: add buildbot.slave module
5485 * buildbot/bb_tap.py: handle move
5486 * buildbot/slave/registry.py: place to register commands, w/versions
5487 * buildbot/slave/bot.py: major simplifications
5488 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5489 instead of a fixed table. Eventually this will make the slave more
5490 extensible. Use 'start' method on the command, not .startCommand.
5491 Fix unsafeTracebacks handling (I think).
5492 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5493 helper class with a .start method that returns a Deferred.
5494 SlaveShellCommand is the form reached by the buildmaster. Commands
5495 which use multiple ShellCommands can just chain them as Deferreds,
5496 with some helper methods in Command (_abandonOnFailure and
5497 _checkAbandoned) to bail on rc!=0.
5498 (CVSCommand): prefer new mode= argument
5499 (SVNFetch): add mode= argument
5501 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5502 put a useful reason string on the build
5504 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5505 core functionality into an IStatusLog object
5506 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5507 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5508 (StatusResourceBuild.body): use proper accessor methods
5509 * buildbot/status/client.py (RemoteLog): PB-access goes here
5510 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5511 which delivers log contents too
5512 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5513 * buildbot/status/event.py: remove old Logfile completely
5515 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5516 subscription interface for IStatusLog subscriptions just like all
5517 other the status subscriptions
5518 (IStatusReceiver.logChunk): method called on subscribers
5520 2004-08-24 Brian Warner <warner@lothar.com>
5522 * buildbot/process/builder.py (Builder._pong): oops, ping response
5523 includes a result (the implicit None returned by remote_print).
5524 Accept it so the _pong method handles the response correctly.
5526 2004-08-06 Brian Warner <warner@lothar.com>
5528 * buildbot/test/test_config.py: update IRC, PBListener tests
5530 * buildbot/status/client.py (StatusClientPerspective): total
5531 rewrite to match new IStatus interfaces. New subscription scheme.
5532 There are still a few optimizations to make (sending down extra
5533 information with event messages so the client doesn't have to do a
5534 round trip). The logfile-retrieval code is probably still broken.
5535 Moved the PB service into its own port, you can no longer share a
5536 TCP socket between a PBListener and, say, the slaveport (this
5537 should be fixed eventually).
5538 * buildbot/clients/base.py (Client): revamp to match. still needs
5539 a lot of work, but basic event reporting works fine. gtkPanes is
5542 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5543 instance talks to a single irc server. Threw out all the old
5544 multi-server handling code. Still need to add back in
5545 builder-control (i.e. "force build")
5547 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5548 more random text to the as-yet-unreachable per-step page
5550 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5551 rename to stepETAUpdate
5552 (BuildStatus.subscribe): add build-wide ETA updates
5553 (BuilderStatus.getState): remove more cruft
5554 (BuilderStatus.getCurrentBuild): remove more cruft
5555 (BuilderStatus.buildStarted): really handle tuple-subscription
5556 * buildbot/test/test_run.py (Status.testSlave): handle the
5557 stepETAUpdate rename
5559 * buildbot/master.py (BuildMaster): don't add a default
5560 StatusClientService. Don't add a default IrcStatusFactory. Both
5561 are now added through c['status'] in the config file. c['irc'] is
5562 accepted for backwards compatibility, the only quirk is you cannot
5563 use c['irc'] to specify IRC servers on ports other than 6667.
5565 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5566 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5567 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5568 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5571 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5572 the buildmaster to re-read its config file
5575 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5576 find out the port our server is running on
5577 (WebTest.test_webPathname_port): same
5579 * buildbot/test/test_config.py (testWebPortnum): test it
5580 (testWebPathname): ditto
5582 * docs/config.xhtml: document new c['status'] configuration option
5584 * buildbot/status/html.py (Waterfall): new top-level class which
5585 can be added to c['status']. This creates the Site as well as the
5586 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5587 reachable as .parent, for everything.
5589 * buildbot/master.py (Manhole): make it a normal service Child
5590 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5591 webPathname. It will eventually replace c['irc'] and the implicit
5592 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5593 in as (deprecated) backward compatibility hooks for now.
5596 * buildbot/process/builder.py (Builder.buildFinished): don't
5597 inform out builder_status about a finished build, as it finds out
5598 through its child BuildStatus object
5600 * buildbot/status/html.py: extensive revamp. Use adapters to make
5601 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5602 have both starting and finishing times and adjust the waterfall
5603 display accordingly, using spacers if necessary. Use SlaveStatus
5604 to get buildslave info.
5605 (StatusResourceBuildStep): new just-one-step resource, used to get
5606 logfiles. No actual href to it yet.
5608 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5609 the time being, until I get the file-naming scheme right
5611 * buildbot/status/builder.py (Event): clean started/finished names
5612 (BuildStatus.isFinished): .finished is not None is the right test
5613 (BuildStatus.buildStarted): track started/finished times ourselves
5614 (BuilderStatus.getSlave): provide access to SlaveStatus object
5615 (BuilderStatus.getLastFinishedBuild): all builds are now in
5616 .builds, even the currently-running one. Accomodate this change.
5617 (BuilderStatus.eventGenerator): new per-builder event generator.
5618 Returns BuildStepStatus and BuildStatus objects, since they can
5619 both be adapted as necessary.
5620 (BuilderStatus.addEvent): clean up started/finished attributes
5621 (BuilderStatus.startBuild,finishBuild): remove dead code
5622 (SlaveStatus): new object to provide ISlaveStatus
5624 * buildbot/process/step.py (ShellCommand.getColor): actually
5625 return the color instead of setting it ourselves
5626 (CVS.__init__): pull .timeout and .workdir options out of
5627 **kwargs, since BuildStep will ignore them. Without this neither
5628 will be sent to the slave correctly.
5629 (SVN.__init__): same
5631 * buildbot/process/builder.py (Builder): move flags to class-level
5633 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5634 SlaveStatus handle that
5636 * buildbot/process/base.py (Build.firstEvent): remove dead code
5637 (Build.stopBuild): bugfix
5639 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5641 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5642 (ChangeMaster.eventGenerator): yield Changes, since there are now
5643 Adapters to turn them into HTML boxes
5645 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5646 (BotPerspective.attached): feed a SlaveStatus object
5647 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5648 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5650 * buildbot/interfaces.py: API additions
5651 (ISlaveStatus): place to get slave status
5653 2004-08-04 Brian Warner <warner@lothar.com>
5655 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5656 the delay finishes, so the step is marked as SUCCESS
5658 * buildbot/test/test_run.py (Status.testSlave): cover more of
5659 IBuildStatus and IBuildStepStatus
5661 * buildbot/status/progress.py (StepProgress): move some flags to
5662 class-level attributes
5663 (StepProgress.remaining): if there are no other progress metrics
5664 to go by, fall back to elapsed time
5665 (StepProgress.setExpectations): take a dict of metrics instead of
5667 (BuildProgress.setExpectationsFrom): pull expectations from the
5668 Expectations, instead of having it push them to the BuildProgress
5669 (Expectations): move some flags to class-level attributes
5670 (Expectations.__init__): copy per-step times from the
5672 (Expectations.expectedBuildTime): new method for per-build ETA
5674 * buildbot/status/event.py (Logfile): move some flags to
5675 class-level attributes
5676 (Logfile.logProgressTo): better method name, let step set the
5677 progress axis name (instead of always being "output")
5679 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5680 times directly, rather than depending upon the (possibly missing)
5681 .progress object. Use 'None' to indicate "not started/finished
5683 (BuildStepStatus.getExpectations): oops, return the full list of
5685 (BuilderStatus._buildFinished): append finished builds to .builds
5687 * buildbot/process/step.py (BuildStep): add separate .useProgress
5688 flag, since empty .progressMetrics[] still implies that time is a
5690 (CVS): set up the cmd in __init__, instead of waiting for start()
5692 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5693 calculation, this will eventually turn into a proper sourceStamp
5694 (Build.setupBuild): tell the Progress to load from the Expectations,
5695 instead of having the Expectations stuff things into the Progress
5696 (Build.buildException): add a build-level errback to make sure the
5697 build's Deferred fires even in case of exceptions
5699 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5701 * buildbot/process/builder.py (Builder.forceBuild): convey the
5702 reason instead of creating a fake Change
5704 * docs/examples/twisted_master.cfg: update to match reality
5706 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5707 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5708 fix or remove broken/breaking tests
5710 * buildbot/status/event.py (Logfile.__len__): remove evil method
5712 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5713 missing .build, for test convenience
5715 * buildbot/process/step_twisted.py: import fixes
5717 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5719 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5720 .statusbag reference
5722 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5723 connection at shutdown, and stop it from reconnecting
5725 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5726 chase down remote-execution bugs
5728 * buildbot/process/step.py: more fixes, remove
5729 BuildStep.setStatus()
5730 * buildbot/status/builder.py: move setStatus() functionality into
5732 * buildbot/status/event.py: minor fixes
5734 2004-08-03 Brian Warner <warner@lothar.com>
5736 * buildbot/process/base.py, buildbot/process/builder.py
5737 * buildbot/process/step.py, buildbot/status/builder.py
5738 * buildbot/status/event.py, buildbot/test/test_run.py:
5739 fix status delivery, get a basic test case working
5740 * buildbot/master.py: finish implementing basic status delivery,
5741 temporarily disable HTML/IRC/PB status sources
5743 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5745 * buildbot/status/progress.py (BuildProgress): remove dead code
5747 * buildbot/interfaces.py
5748 * buildbot/process/base.py, buildbot/process/builder.py
5749 * buildbot/process/step.py, buildbot/process/step_twisted.py
5750 * buildbot/status/builder.py: Complete overhaul of the all
5751 status-delivery code, unifying all types of status clients (HTML,
5752 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5753 look like. This commit is a checkpointing of the work-in-progress:
5754 the input side is mostly done (Builders/Builds sending status
5755 to the BuilderStatus/BuildStatus objects), but the output side has
5756 not yet been started (HTML resources querying BuilderStatus
5757 objects). Things are probably very broken right now and may remain
5758 so for several weeks, I apologize for the disruption.
5760 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5761 HTML as the log's contents. Currently used for exception tracebacks.
5762 * buildbot/status/progress.py: minor spelling changes
5764 2004-08-02 Brian Warner <warner@lothar.com>
5766 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5767 in mozilla. Also added stylesheets copied from Twisted's docs.
5768 Remember that these files are meant to be run through Lore first.
5769 Thanks to Philipp Frauenfelder for the fixes.
5770 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5771 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5772 * docs/template.tpl: added a Lore template
5774 2004-07-29 Brian Warner <warner@lothar.com>
5776 * buildbot/interfaces.py: revamp status delivery. This is the
5777 preview: these are the Interfaces that will be provided by new
5778 Builder code, and to which the current HTML/IRC/PB status
5779 displayers will be adapted.
5781 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5782 on the SlaveBuilder, not the Bot.
5783 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5785 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5786 set .usePTY on the FakeSlaveBuilder
5788 2004-07-25 Brian Warner <warner@lothar.com>
5790 * buildbot/changes/freshcvs.py: add some debug log messages
5791 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5792 disabled 'setFilter' syntax
5793 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5794 don't end with a slash
5796 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5798 * setup.py: bump to 0.5.0+ while between releases
5800 2004-07-23 Brian Warner <warner@lothar.com>
5802 * setup.py (version): Releasing buildbot-0.5.0
5804 2004-07-23 Brian Warner <warner@lothar.com>
5806 * README: update for 0.5.0 release
5808 * NEWS: update for 0.5.0 release
5810 2004-07-22 Brian Warner <warner@lothar.com>
5812 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5813 mktap-time configuration flag (--usepty=1, --usepty=0)
5814 * buildbot/bot.py: same
5816 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5817 an 'info' directory being unwanted
5819 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5820 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5821 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5822 and earlier), use a FreshCVSSourceOldcred instead.
5823 (test): simple test routine: connect to server, print changes
5825 * buildbot/changes/changes.py (Change.getTime): make it possible
5826 to print un-timestamped changes
5828 * buildbot/master.py (makeApp): delete ancient dead code
5829 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5830 * buildbot/test/test_config.py (testFindConfigFile): test it
5832 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5833 instead of win32 one
5836 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5837 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5840 * buildbot/process/base.py (Builder.__init__): change constructor
5841 to accept a dictionary of config data, rather than discrete
5842 name/slave/builddir/factory arguments
5844 * docs/examples/twisted_master.cfg: update to new syntax
5845 * docs/examples/glib_master.cfg: same
5846 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5847 rough tests of the new syntax
5850 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5851 to be an int, which means "run a web.distrib sub-server on a TCP
5852 port". This lets you publish the buildbot status page to a remote
5853 twisted.web server (using distrib.ResourceSubscription). Also
5854 rename the local attributes used to hold these web things so
5855 they're more in touch with reality.
5856 * buildbot/test/test_web.py: test webPortnum and webPathname
5857 * docs/config.xhtml: document this new use of webPathname
5859 * docs/config.xhtml: new document, slightly ahead of reality
5861 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5862 'prefix' handling: treat it as a simple string to check with
5863 .startswith, instead of treating it as a directory. This allows
5864 sub-directories to be used. If you use prefix=, you should give it
5865 a string that starts just below the CVSROOT and ends with a slash.
5866 This prefix will be stripped from all filenames, and filenames
5867 which do not start with it will be ignored.
5869 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5871 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5872 and --exclude (inverse of --include). SVN post-commit hooks
5873 now have total control over which changes get sent to buildbot and which
5876 2004-07-10 Brian Warner <warner@lothar.com>
5878 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5879 test case to match new API
5881 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5882 which crashed HTML display when self.entries=[] (needed to
5883 distinguish between [], which means "no entries yet", and None,
5884 which means "the entries have been swapped out to disk, go fetch
5887 2004-07-04 Brian Warner <warner@lothar.com>
5889 * buildbot/process/step_twisted.py (countFailedTests): Count
5890 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5891 10kb from the end because any import errors are wedged there and
5892 they would make us think the test log was unparseable.
5893 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5895 2004-06-26 Brian Warner <warner@lothar.com>
5897 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5898 delete-*.pyc command into an actual BuildStep, so we can label it
5900 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5901 (FullTwistedBuildFactory): same
5903 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5905 * contrib/fakechange.py: Add an errback when sending the fake
5906 change, so we know it didn't work.
5908 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5910 * buildbot/process/step_twisted.py: Delete *.pyc files before
5911 calling trial, so it doesn't catch any old .pyc files whose .py
5912 files have been moved or deleted.
5914 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
5915 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
5916 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
5917 instead of ["twisted.test"], so that the end result is "trial -R
5920 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
5921 regular expression to match filenames that should be ignored when
5922 changed. Also add a --revision parameter that specifies the
5923 revision to examine, which is useful for debugging.
5925 2004-06-25 Brian Warner <warner@lothar.com>
5927 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
5928 summary of warnings (like DeprecationWarnings), next to the
5931 2004-05-13 Brian Warner <warner@lothar.com>
5933 * docs/examples/twisted_master.cfg: enable the win32 builder, as
5934 we now have a w32 build slave courtesy of Mike Taylor.
5936 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
5937 so broken. Fixed a race condition that tripped up interlocked
5938 builds and caused the status to be stuck at "Interlocked" forever.
5939 The twisted buildbot's one interlocked build just so happened to
5940 never hit this case until recently (the feeding builds both pass
5941 before the interlocked build is attempted.. usually it has to wait
5943 (Builder._pong_failed): fix method signature
5945 * setup.py: bump to 0.4.3+ while between releases
5947 2004-04-30 Brian Warner <warner@lothar.com>
5949 * setup.py (version): Releasing buildbot-0.4.3
5951 2004-04-30 Brian Warner <warner@lothar.com>
5953 * MANIFEST.in: add the doc fragments in docs/*.xhtml
5955 * README: update for 0.4.3 release
5957 * NEWS: update for 0.4.3 release
5959 * buildbot/master.py (BuildMaster.__getstate__): make sure
5960 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
5962 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
5963 .trial as a class attribute, for upgrade from 0.4.2
5965 * buildbot/changes/changes.py (Change.links): add .links for
5968 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
5969 .textWatchers and .htmlWatchers at save time, since they are both
5970 volatile, should allow smooth 0.4.2 upgrade
5972 * buildbot/process/step.py (CVS.finishStatus): catch failed
5973 CVS/SVN commands so we can make the status box red
5975 2004-04-29 Brian Warner <warner@lothar.com>
5977 * buildbot/changes/freshcvs.py
5978 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
5979 code to do setFilter(), which tells the freshcvs daemon to not
5980 send us stuff that we're not interested in. I will uncomment it
5981 when a new version of CVSToys is available in which setFilter()
5982 actually works, and I get a chance to test it better.
5984 * docs/examples/twisted_master.cfg: start using a PBChangeSource
5986 * buildbot/master.py (Dispatcher): use a registration scheme
5987 instead of hardwired service names
5988 (BuildMaster): keep track of the Dispatcher to support
5991 * buildbot/changes/changes.py (ChangeMaster): create a distinct
5992 PBChangeSource class instead of having it be an undocumented
5993 internal feature of the ChangeMaster. Split out the code into a
5995 * buildbot/changes/pb.py (PBChangeSource): same
5996 * buildbot/test/test_changes.py: a few tests for PBChangeSource
5998 * docs/{factories|sources|steps}.xhtml: document some pieces
6000 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6001 using FCMaildirSource
6002 (f23osx): update OS-X builder to use python2.3, since the slave
6003 was updated to Panther (10.3.3)
6005 2004-03-21 Brian Warner <warner@lothar.com>
6007 * buildbot/process/process_twisted.py: factor out doCheckout, change
6008 to use SVN instead of CVS
6010 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6011 an SVN subclass easier
6012 (BasicSVN): subclass which uses Subversion instead of CVS
6014 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6016 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6018 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6020 2004-02-25 Brian Warner <warner@lothar.com>
6022 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6023 is now either a list (which is passed to spawnProcess directly) or
6024 a string (which gets passed to /bin/sh -c). This removes the useSH
6025 flag and the ArgslistCommand class. Also send status header at the
6026 start and end of each command, instead of having the master-side
6028 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6029 -r'. Update to use list-based arguments.
6030 (SVNFetch): use list-based arguments, use ['dir'] argument to
6032 * buildbot/test/test_steps.py (Commands): match changes
6034 * buildbot/process/step.py (InternalShellCommand.words): handle
6036 (SVN): inherit from CVS, cleanup
6038 * buildbot/status/event.py (Logfile.content): render in HTML, with
6039 stderr in red and headers (like the name of the command we're
6040 about to run) in blue. Add link to a second URL (url + "?text=1")
6041 to get just stdout/stderr in text/plain without markup. There is
6042 still a problem with .entries=None causing a crash, it seems to occur
6043 when the logfile is read before it is finished.
6045 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6046 timeout to the keepalives, and use it to explicitly do a
6047 loseConnection instead of waiting for TCP to notice the loss. This
6048 ought to clear up the silent-lossage problem.
6049 (unsafeTracebacks): pass exception tracebacks back to the master,
6050 makes it much easier to debug problems
6052 2004-02-23 Brian Warner <warner@lothar.com>
6054 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6055 the whole command to /bin/sh instead of execve [Johan Dahlin]
6056 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6057 '-r HEAD' [Johan Dahlin]
6058 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6060 * buildbot/changes/changes.py (Change): add links= argument, add
6061 asHTML method [Johan Dahlin]. Modified to make a bit more
6062 XHTMLish. Still not sure how to best use links= .
6064 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6065 Change.asHTML to display the change, not asText
6067 * buildbot/status/html.py (StatusResourceBuilder): web button to
6070 * buildbot/test/test_run.py: test to actually start a buildmaster
6073 * MANIFEST.in: bring back accidentally-dropped test helper files
6075 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6076 that require cvstoys if it is not installed
6078 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6079 values of "bin/trial" [Dave Peticolas]
6080 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6081 tests passed" when we didn't happen to run any tests
6083 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6084 flunkOnFailure [Johan Dahlin]
6086 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6087 multiple instances of the same Step class by suffixing "_2", etc,
6088 to the name until it is unique. This name needs to be unique
6089 because it is used as a key in the dictionary that tracks build
6091 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6094 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6096 2004-01-14 Brian Warner <warner@lothar.com>
6098 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6099 kicked from a channel, log it
6101 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6102 something over whatever IRC channels the buildmaster is currently
6103 connected to. Added to try and track down a problem in which the
6104 master thinks it is still connected but the IRCd doesn't see it. I
6105 used a styles.Versioned this time, so hopefully users won't have
6106 to rebuild their .tap files this time.
6107 * contrib/debug.glade: add a "Poke IRC" button
6108 * contrib/debugclient.py: same
6110 * setup.py: bump to 0.4.2+ while between releases
6112 2004-01-08 Brian Warner <warner@lothar.com>
6114 * setup.py (version): Releasing buildbot-0.4.2
6116 2004-01-08 Brian Warner <warner@lothar.com>
6118 * NEWS: update for 0.4.2 release
6120 * README: document how to run the tests, now that they all pass
6122 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6124 * buildbot/process/step.py (CVS): add a global_options= argument,
6125 which lets you set CVS global options for the command like "-r"
6126 for read-only checkout, or "-R" to avoid writing in the
6128 * buildbot/slavecommand.py (CVSCommand): same
6130 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6131 testing easier (it is turned off when testing, to avoid the
6134 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6135 to make it easier to test: break generateStepID() out to a
6136 separate function, only update statusbag if it exists.
6137 (ShellCommands): create useful text for dict-based commands too.
6139 * test/*, buildbot/test/*: move unit tests under the buildbot/
6141 * setup.py (packages): install buildbot.test too
6143 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6144 * buildbot/test/test_steps.py: fix it, tests pass now
6146 2004-01-06 Brian Warner <warner@lothar.com>
6148 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6149 freshcvs mail uses a slightly different syntax for new
6150 directories. Update parser to handle either.
6151 * test/test_mailparse.py (Test1.testMsg9): test for same
6153 2003-12-21 Brian Warner <warner@lothar.com>
6155 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6156 'warnOnWarnings' so that lintian errors mark the build orange
6158 2003-12-17 Brian Warner <warner@lothar.com>
6160 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6161 messages emitted by Bonsai, contributed by Stephen Davis.
6163 * test/*: moved all tests to use trial instead of unittest. Some
6164 still fail (test_steps, test_slavecommand, and test_process).
6166 * setup.py (version): bump to 0.4.1+ while between releases
6168 2003-12-09 Brian Warner <warner@lothar.com>
6170 * setup.py (version): Releasing buildbot-0.4.1
6172 2003-12-09 Brian Warner <warner@lothar.com>
6174 * NEWS: update for 0.4.1 release
6176 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6177 freebsd builder code a little bit
6179 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6180 don't try to compare attributes of different classes
6181 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6182 (MaildirSource.messageReceived): fix Change delivery
6184 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6185 into the config file's namespace before loading it, like the
6186 documentation claims it does
6187 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6188 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6189 daemon comes back online
6191 2003-12-08 Brian Warner <warner@lothar.com>
6193 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6194 so the example will work with online=0 as well
6196 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6197 fix the __implements__ line
6199 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6200 class a twisted.application.service.Service, use startService to
6203 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6204 directory fd instead of simple open(). I'm sure this used to work,
6205 but the current version of python refuses to open directories with
6208 2003-12-05 Brian Warner <warner@lothar.com>
6210 * setup.py (version): bump to 0.4.0+ while between releases
6212 2003-12-05 Brian Warner <warner@lothar.com>
6214 * setup.py (version): Releasing buildbot-0.4.0
6216 2003-12-05 Brian Warner <warner@lothar.com>
6218 * docs/examples/glib_master.cfg: replace old sample scripts with
6219 new-style config files
6220 * MANIFEST.in: include .cfg files in distribution tarball
6222 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6223 implement a dummy method to avoid the exception that occurs when
6224 freshcvs sends this to us.
6226 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6227 removed the method, as it broke reconnection. Apparently
6228 stopFactory is called each time the connection attempt fails. Must
6230 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6231 attribute before serialization, since without stopFactory the
6232 reconnect timer may still be active and they aren't serializable.
6234 * test/test_mailparse.py (ParseTest): test with 'self' argument
6236 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6237 argument, as these "functions" are invoked like methods from class
6238 attributes and therefore always get an instance as the first
6241 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6242 message: thanks to Stephen Davis for the catch
6244 2003-12-04 Brian Warner <warner@lothar.com>
6246 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6247 twisted's standard ReconnectingClientFactory. Handles both oldcred
6248 and newcred connections. Also has a bug-workaround for
6249 ReconnectingClientFactory serializing its connector when it
6252 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6253 pbutil. Replace makeApp stuff with proper newcred/mktap
6254 makeService(). Don't serialize Ephemerals on shutdown.
6256 * buildbot/changes/changes.py (ChangeMaster): make it a
6257 MultiService and add the sources as children, to get startService
6258 and stopService for free. This also gets rid of the .running flag.
6260 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6261 new pbutil, turn into a TCPClient at the same time (to get
6262 startService for free). Two variants exist: FreshCVSSourceOldcred
6263 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6264 yet, but when it does, we'll be ready).
6265 (FreshCVSSource.notify): handle paths which are empty after the
6266 prefix is stripped. This only happens when the top-level (prefix)
6267 directory is added, at the very beginning of a Repository's life.
6269 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6270 Now the only reconnecting code is in the factory where it belongs.
6271 (Builder.unsubscribe): unregister the disconnect callback when we
6272 delete the builder on command from the master (i.e. when the
6273 buildmaster is reconfigured and that builder goes away). This
6274 fixes a multiple-delete exception when the status client is shut
6276 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6279 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6280 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6282 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6284 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6285 a list of globs (ugh). The testdir will be searched for files
6286 named *.tests and run the tests in the order specified in each of
6287 those files. This allows for "dependancies" between tests to be
6290 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6291 argument to pass to run_maxq.py, instead of a glob.
6293 2003-10-17 Brian Warner <warner@lothar.com>
6295 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6296 files that live in the sandbox
6298 2003-10-15 Brian Warner <warner@lothar.com>
6300 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6301 spelling error in "docs" count-warnings output
6302 (HLint.start): stupid thinko meant .xhtml files were ignored
6304 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6305 tests now that cReactor is banished to the sandbox
6307 2003-10-10 Brian Warner <warner@lothar.com>
6309 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6310 scheme: now .xhtml are sources and .html are generated
6312 2003-10-08 Brian Warner <warner@lothar.com>
6314 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6315 we were ignoring the 'randomly' parameter.
6317 2003-10-01 Brian Warner <warner@lothar.com>
6319 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6320 posix, to kill sub-children of aborted slavecommands.
6322 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6323 Clean up initialization: lastBuildStatus remains None until the
6324 first build has been completed.
6326 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6327 None as a lastBuildStatus
6328 * buildbot/clients/gtkPanes.py: same
6330 * buildbot/status/client.py (StatusClientService): keep
6331 BuilderStatus objects in self.statusbags . These objects now live
6332 here in the StatusClientService and are referenced by the Builder
6333 object, rather than the other way around.
6334 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6335 * buildbot/process/base.py (Builder): same
6336 * test/test_config.py (ConfigTest.testBuilders): same
6338 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6339 an existing builder, leave the statusbag alone. This will preserve the
6342 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6343 hook. This will probably go away in favor of a class in upcoming
6346 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6347 serviceName from newcred FreshCVSNotifiee setup
6349 2003-09-29 Brian Warner <warner@lothar.com>
6351 * buildbot/process/process_twisted.py: switch to new reactor
6353 * docs/examples/twisted_master.cfg: same
6355 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6357 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6358 botmaster reference instead of the oldapp service lookup
6360 * buildbot/master.py (BuildMaster.__init__): give the
6361 StatusClientService a reference to the botmaster to make it easier to
6364 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6366 * buildbot/status/html.py (Box.td): escape hreffy things so you
6367 can have spaces in things like builder names
6368 (StatusResourceBuilder.body)
6369 (WaterfallStatusResource.body)
6370 (WaterfallStatusResource.body0): same
6372 2003-09-25 Brian Warner <warner@lothar.com>
6374 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6375 rearrange the builder list when adding or removing builders: keep
6376 them in the order the user requested.
6377 * test/test_config.py (ConfigTest.testBuilders): verify it
6379 * contrib/debug.glade: give the debug window a name
6381 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6382 now wait on multiple interlocks. Fix code relating to that.
6383 (Builder.checkInterlocks): same
6384 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6386 * buildbot/master.py (BuildMaster.loadConfig): move from
6387 deprecated pb.BrokerFactory to new pb.PBServerFactory
6388 * test/test_config.py (ConfigTest.testWebPathname): same
6390 * docs/examples/twisted_master.cfg: fix interlock declaration
6392 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6393 Interlocks to their Builders into interlock.py .
6394 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6396 * test/test_config.py (ConfigTest.testInterlocks): validate
6399 * buildbot/process/base.py (Builder.__init__): better comments
6400 * buildbot/process/interlock.py (Interlock.__repr__): same
6401 (Interlock.deactivate): add .active flag, move the code that
6402 attaches/detaches builders into the Interlock
6404 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6406 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6407 tests using the new run_maxq.py script, and reporting failures by
6410 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6411 tests, reporting their success or failure in a buildbot-friendly
6414 2003-09-24 Brian Warner <warner@lothar.com>
6416 * docs/examples/twisted_master.cfg: example of a new-style config
6417 file. This lives in the buildmaster base directory as
6420 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6421 button to make the master re-read its config file
6423 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6424 buildmaster configuration from a file. This file can be re-read
6425 later, and the buildmaster will update itself to match the new
6426 desired configuration. Also use new Twisted Application class.
6427 * test/Makefile, test/test_config.py: unit tests for same
6429 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6430 FreshCVSSources comparable, to support reload.
6431 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6433 * buildbot/process/base.py (Builder): make them comparable, make
6434 Interlocks easier to attach, to support reload. Handle
6435 re-attachment of remote slaves.
6436 * buildbot/process/interlock.py (Interlock): same
6438 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6439 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6440 buildmaster taps are now constructed with mktap.
6441 * buildbot/status/client.py (StatusClientService): same
6443 * buildbot/status/words.py: move to new Services, add support to
6444 connect to multiple networks, add reload support, allow nickname
6445 to be configured on a per-network basis
6447 2003-09-20 Brian Warner <warner@lothar.com>
6449 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6450 the freebsd builder, now that the machine has been upgraded and no
6451 longer has python2.2
6453 * setup.py (version): bump to 0.3.5+ while between releases
6455 2003-09-19 Brian Warner <warner@lothar.com>
6457 * setup.py (version): Releasing buildbot-0.3.5
6459 2003-09-19 Brian Warner <warner@lothar.com>
6461 * NEWS: add post-0.3.4 notes
6463 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6465 * MANIFEST.in: add contrib/*
6467 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6468 use a remote root now: cvs.twistedmatrix.com
6470 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6472 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6473 compatibility with old servers
6474 (FreshCVSSource.start): and provide a way to use it
6475 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6477 * docs/examples/twisted_master.py (twisted_app): update to new
6479 (twisted_app): listen on new ~buildbot socket
6480 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6482 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6483 to reduce cvs bandwidth (update instead of full checkout)
6485 2003-09-11 Brian Warner <warner@lothar.com>
6487 * contrib/fakechange.py: demo how to connect to the changemaster
6488 port. You can use this technique to submit changes to the
6489 buildmaster from source control systems that offer a hook to run a
6490 script when changes are committed.
6492 * contrib/debugclient.py: tool to connect to the debug port. You
6493 can use it to force builds, submit fake changes, and wiggle the
6496 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6497 'Dispatcher' realm to handle all the different kinds of
6498 connections and Perspectives: buildslaves, the changemaster port,
6499 the debug port, and the status client port. NewCredPerspectives
6500 now have .attached/.detached methods called with the remote 'mind'
6501 reference, much like old perspectives did. All the pb.Services
6502 turned into ordinary app.ApplicationServices .
6503 (DebugService): went away, DebugPerspectives are now created
6504 directly by the Dispatcher.
6505 (makeApp): changed interface a little bit
6507 * buildbot/changes/changes.py: newcred
6508 * buildbot/status/client.py: newcred
6510 * buildbot/clients/base.py: newcred client side changes
6511 * buildbot/bot.py: ditto
6513 * docs/examples/glib_master.py: handle new makeApp() interface
6514 * docs/examples/twisted_master.py: ditto
6516 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6517 base newcred Perspectives on. This should go away once Twisted
6518 itself provides something sensible.
6521 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6523 * contrib/svn_buildbot.py: A program that you can call from your
6524 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6525 when a change in an SVN repository has happened. See the top of
6526 the file for some minimal usage info.
6528 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6530 * buildbot/slavecommand.py (ArglistCommand): Add new
6531 ArglistCommand that takes an argument list rather than a string as
6532 a parameter. Using a st.split() for argv is very bad.
6534 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6535 update to a particular revision rather than always checking out
6536 (still not very smart about it, there may be cases where the
6537 checkout becomes inconsistent).
6539 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6541 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6542 SVN fetch support. It can checkout (not update!) a specified
6543 revision from a specified repository to a specified directory.
6545 * buildbot/status/progress.py (Expectations.update): Fix an
6546 obvious bug (apparently created by the change described in the
6547 previous ChangeLog message) by moving a check to *after* the
6548 variable it checks is defined.
6551 2003-09-08 Brian Warner <warner@lothar.com>
6553 * buildbot/status/progress.py (Expectations.update): hack to catch
6554 an exception TTimo sees: sometimes the update() method seems to
6555 get called before the step has actually finished, so the .stopTime
6556 is not set, so no totalTime() is available and we average None
6557 with the previous value. Catch this and just don't update the
6558 metrics, and emit a log message.
6560 2003-08-24 Brian Warner <warner@lothar.com>
6562 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6563 parameter to set copydir='original' in CVS commands.
6565 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6567 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6568 which tells the command to maintain a separate original-source CVS
6569 workspace. For each build, this workspace will be updated, then
6570 the tree copied into a new workdir. This reduces CVS bandwidth
6571 (from a full checkout to a mere update) while doubling the local
6572 disk usage (to keep two copies of the tree).
6574 2003-08-21 Brian Warner <warner@lothar.com>
6576 * buildbot/status/event.py (Logfile.addEntry): if the master web
6577 server dies while we're serving a page, request.write raises
6578 pb.DeadReferenceError . Catch this and treat it like a
6579 notifyFinish event by dropping the request.
6581 2003-08-18 Brian Warner <warner@lothar.com>
6583 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6584 (instead of blowing up) if a force-build command is given without
6587 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6588 don't blow up if there aren't yet any Changes in the list
6590 2003-08-02 Brian Warner <warner@lothar.com>
6592 * buildbot/bot.py (updateApplication): don't set the .tap name,
6593 since we shouldn't assume we own the whole .tap file
6595 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6596 'mktap buildbot' (without a subcommand) better
6598 2003-07-29 Brian Warner <warner@lothar.com>
6600 * buildbot/status/words.py
6601 (IrcStatusFactory.clientConnectionLost): when we lose the
6602 connection to the IRC server, schedule a reconnection attempt.
6604 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6605 use shutil.rmtree instead of forking off an "rm -rf" command.
6606 rmtree may take a while and will block until it finishes, so we
6607 use "rm -rf" if available.
6609 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6610 freebsd buildslave badly
6612 * setup.py (version): bump to 0.3.4+ while between releases
6614 2003-07-28 Brian Warner <warner@lothar.com>
6616 * setup.py (version): Releasing buildbot-0.3.4
6618 2003-07-28 Brian Warner <warner@lothar.com>
6620 * NEWS: update in preparation for release
6622 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6623 process.signalProcess instead of os.kill, to improve w32
6626 * docs/examples/twisted_master.py (twisted_app): turn off
6627 win32eventreactor: the tests hang the buildslave badly
6629 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6630 failed builds, since usually the failures are consistent
6632 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6633 add compileOpts/compileOpts2 to reactors build
6635 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6636 (twisted_app): use both default and win32eventreactor on w32 build.
6637 Use both default and kqreactor on freebsd build.
6639 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6640 add compileOpts2, which is put after the build_ext argument. w32
6641 needs "-c mingw32" here.
6643 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6644 touch .acqpath, it goes away in recent Twisted releases
6646 * docs/examples/twisted_master.py (twisted_app): use "python" for
6647 the w32 buildslave, not "python2.2"
6649 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6650 the directory exists.. should hush an exception under w32
6652 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6653 ProcessTerminated -provided values for signal and exitCode rather
6654 than parsing the unix status code directly. This should remove one
6655 more roadblock for a w32-hosted buildslave.
6657 * test/test_mailparse.py: add test cases for Syncmail parser
6659 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6660 temporary compatibility import. Note! Start importing
6661 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6663 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6665 2003-07-27 Brian Warner <warner@lothar.com>
6667 * NEWS: started adding new features
6669 * buildbot/changes/mail.py: start work on Syncmail parser, move
6670 mail sources into their own file
6672 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6673 as implementing IChangeSource
6674 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6676 * buildbot/interfaces.py: define the IChangeSource interface
6678 2003-07-26 Brian Warner <warner@lothar.com>
6680 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6682 2003-06-25 Brian Warner <warner@lothar.com>
6684 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6687 2003-06-17 Brian Warner <warner@lothar.com>
6689 * buildbot/status/words.py: clean up method usage to avoid error
6690 in silly IRC command
6691 (IrcStatusBot.emit_status): round off seconds display
6693 * buildbot/process/base.py (Build): delete the timer when saving
6694 to the .tap file, and restore it (if it should still be running)
6695 upon restore. This should fix the "next build in -34 seconds"
6696 messages that result when the master is restarted while builds are
6697 sitting in the .waiting slot. If the time for the build has
6698 already passed, start it very soon (in 1 second).
6700 * buildbot/status/words.py: more silly commands
6702 * README (REQUIREMENTS): add URLs to all required software
6704 * buildbot/status/words.py ('last'): mention results of, and time
6707 2003-05-28 Brian Warner <warner@lothar.com>
6709 * buildbot/status/words.py: add 'last' command
6710 (IrcStatusBot.emit_status): add current-small text to 'status' output
6712 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6713 (twisted_app): remove spaces from OS-X builder name
6715 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6716 * buildbot/status/words.py: IRC bot should actually be useful now
6718 2003-05-23 Brian Warner <warner@lothar.com>
6720 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6721 "slave information" from $(slavedir)/info/* . These files are
6722 maintained by the slave administrator, and describe the
6723 machine/environment that is hosting the slave. Information from
6724 them is put into the "Builder" HTML page. Still need to establish
6725 a set of well-known filenames and meanings for this data: at the
6726 moment, *all* info/* files are sent to the master, but only
6727 'admin' and 'host' are used on that end.
6728 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6729 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6730 * buildbot/master.py (BotPerspective.got_info): ditto
6732 2003-05-22 Brian Warner <warner@lothar.com>
6734 * setup.py (version): bump version to 0.3.3+ while between releases
6736 2003-05-21 Brian Warner <warner@lothar.com>
6738 * setup.py: Releasing buildbot-0.3.3
6740 2003-05-21 Brian Warner <warner@lothar.com>
6742 * NEWS: 0.3.3 news items
6744 * README: describe --keepalive and life behind a NAT box
6746 * buildbot/bot.py (Bot.connected): implement application-level
6747 keepalives to deal with NAT timeouts, turn them on with
6748 --keepalive option or when SO_KEEPALIVE doesn't work.
6750 * buildbot/master.py (BotPerspective): accept keepalives silently
6752 * buildbot/process/base.py (Build.buildException): CopiedFailures
6753 don't carry as much information as local ones, so don't try to
6754 create a big HTMLized version of them.
6756 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6757 log file when step fails due to an exception, such as when the slave
6760 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6761 --testmodule argument instead of grepping for test-case-name tags
6762 ourselves. Remove FindUnitTests code.
6763 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6765 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6767 2003-05-16 Brian Warner <warner@lothar.com>
6769 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6770 argument to allow things like CFLAGS=-O0 to be passed without relying
6771 upon /bin/sh processing on the slave.
6773 * buildbot/process/step.py (InternalShellCommand.start): send
6775 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6776 'split' instead of letting /bin/sh do it. This should also remove
6777 the need for /bin/sh on the buildslave, making it more likely to
6780 * buildbot/status/html.py: html-escape text in blamelist.
6781 Add "force build" button to the Builder page.
6783 * buildbot/process/step_twisted.py (countFailedTests): look at
6784 last 1000 characters for status line, as import errors can put it
6785 before the -200 point.
6787 2003-05-15 Brian Warner <warner@lothar.com>
6789 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6791 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6792 make 'clobber' a parameter, so it is possible to have builds which
6793 do full tests but do a cvs update instead of hammering the CVS
6794 server with a full checkout each build
6796 * buildbot/process/step.py (InternalShellCommand): bump default
6797 timeout to 20 minutes
6799 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6800 the master to trigger a build. Run it via manhole.
6802 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6803 allow slaves to trigger any build that they host, to make life
6804 easier for slave admins who are testing out new build processes
6806 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6807 don't flunk cReactor or qtreactor on failure, since they fail alot
6808 these days. Do warnOnFailure instead.
6810 * buildbot/process/base.py: change Builder.buildable from a list
6811 into a single slot. When we don't have a slave, new builds (once
6812 they make it past the timeout) are now merged into an existing
6813 buildable one instead of being queued. With this change, a slave
6814 which has been away for a while doesn't get pounded with all the
6815 builds it missed, but instead just does a single build.
6817 2003-05-07 Brian Warner <warner@lothar.com>
6819 * setup.py (version): bump version to 0.3.2+ while between releases
6821 2003-05-07 Brian Warner <warner@lothar.com>
6823 * setup.py: Releasing buildbot-0.3.2
6825 2003-05-07 Brian Warner <warner@lothar.com>
6827 * setup.py: fix major packaging error: include subdirectories!
6829 * NEWS: add changes since last release
6831 * README (REQUIREMENTS): update twisted/python dependencies
6833 * buildbot/status/builder.py (Builder.startBuild): change
6834 BuildProcess API: now they should call startBuild/finishBuild
6835 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6836 keeping a list of builds in the statusbag, to support other kinds of
6838 (Builder.addClient): send current-activity-small to new clients
6839 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6842 * buildbot/status/client.py: drop RemoteReferences at shutdown
6844 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6846 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6847 more debug messages for remote status client
6849 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6850 (.stepFailed): only fire the Deferred once, even if both
6851 stepComplete and stepFailed are called. I think this can happen if
6852 an exception occurs at a weird time.
6854 * buildbot/status/words.py: work-in-progress: IRC status delivery
6856 2003-05-05 Brian Warner <warner@lothar.com>
6858 * docs/examples/twisted_master.py (twisted_app): hush internal
6859 python2.3 distutils deprecation warnings
6860 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6861 add compileOpts= argument which inserts extra args before the
6862 "setup.py build_ext" command. This can be used to give -Wignore
6863 warnings, to hush some internal python-2.3 deprecation messages.
6865 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6866 the ['twisted.test'] default test case to make it easier to change
6869 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6870 * buildbot/clients/gtkPanes.py: ditto
6872 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6873 arg to collapse RunUnitTestsRandomly into RunUnitTests
6874 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6875 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6877 * buildbot/status/html.py (StatusResource): shuffle Resources
6878 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6879 would serve the waterfall display, but the internal links were
6880 only valid on the trailing-slash version. The correct behavior is
6881 for the non-slashed one to serve a Redirect to the slashed one.
6882 This only shows up when the buildbot page is hanging off another
6883 server, like a Twisted-Web distributed server.
6885 * buildbot/status/event.py (Event, RemoteEvent): make Events
6886 pb.Cacheable, with RemoteEvent as the cached version. This removes
6887 a lot of explicit send-an-update code.
6888 * buildbot/status/builder.py (Builder): remove send-update code
6889 * buildbot/status/client.py (ClientBuilder): remove send-update
6890 code, and log errors that occur during callRemote (mostly to catch
6891 InsecureJelly exceptions)
6893 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6894 run Lore with the same python used in the rest of the build
6896 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6898 * buildbot/process/step_twisted.py (HLint): accept 'python'
6899 argument. Catch rc!=0 and mark the step as failed. This marks the
6900 build orange ("has warnings").
6901 (RunUnitTestsJelly): move out to step_twisted2.py
6903 * buildbot/util.py (ignoreStaleRefs): add utility function
6905 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6906 don't fake ETA object, it's too hard to get right
6908 2003-05-02 Brian Warner <warner@lothar.com>
6910 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6912 2003-05-01 Brian Warner <warner@lothar.com>
6914 * buildbot/status/html.py (StatusResource.body): oops, I was
6915 missing a <tr>, causing the waterfall page to be misrendered in
6916 everything except Galeon.
6918 2003-04-29 Brian Warner <warner@lothar.com>
6920 * docs/examples/twisted_master.py: make debuild use python-2.2
6921 explicitly, now that Twisted stopped supporting 2.1
6923 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
6924 handle tuple results too. I keep forgetting this, which suggests
6925 it needs to be rethought.
6927 * setup.py (setup): bump version to 0.3.1+ while between releases
6929 2003-04-29 Brian Warner <warner@lothar.com>
6931 * setup.py: Releasing buildbot-0.3.1
6933 2003-04-29 Brian Warner <warner@lothar.com>
6935 * README (SUPPORT): add plea to send questions to the mailing list
6937 * NEWS, MANIFEST.in: add description of recent changes
6939 * docs/examples/twisted_master.py: add the code used to create the
6940 Twisted buildmaster, with passwords and such removed out to a
6943 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
6944 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
6945 buildmasters to not require CVSToys be installed.
6946 * README, docs/examples/glib_master: update to match the change
6948 * buildbot/clients/base.py, buildbot/bot.py,
6949 buildbot/changes/changes.py, buildbot/pbutil.py: copy
6950 ReconnectingPB from CVSToys distribution to remove CVSToys
6951 dependency for build slaves and status clients. Buildmasters which
6952 use FreshCVSSources still require cvstoys be installed, of course.
6954 2003-04-25 Brian Warner <warner@lothar.com>
6956 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
6957 runTestsRandomly arg to turn on trial -z
6959 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
6960 experimental code to use trial's machine-parseable output to get
6961 more detailed test results. Still has some major issues.
6962 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
6965 * buildbot/status/builder.py (Builder.setCurrentBuild):
6966 anticipating moving build history into statusbag, not used yet
6968 * buildbot/status/tests.py: code to centralize test results,
6969 doesn't work quite yet
6971 * buildbot/status/event.py (Event): use hasattr("setName") instead
6972 of isinstance for now.. need better long-term solution
6974 * buildbot/status/html.py: Remove old imports
6976 2003-04-24 Brian Warner <warner@lothar.com>
6978 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
6979 ignore changes under doc/fun/ and sandbox/
6981 * buildbot/process/step_twisted.py: update pushEvent and friends.
6983 * buildbot/status/html.py (Box.td): replace event.buildername with
6984 event.parent.getSwappableName(). Needs more thought.
6986 * buildbot/status/builder.py (Builder): Replace pushEvent and
6987 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
6988 Tell events they are being pruned with event.delete().
6990 * buildbot/process/base.py (Build): Remove Builder status-handling
6991 methods. s/pushEvent/setCurrentActivity/.
6993 * buildbot/process/step.py (BuildStep): clean up status delivery.
6994 Gouse builder.statusbag methods instead of intermediate builder
6995 methods. s/updateLastEvent/updateCurrentActivity/.
6996 s/finalizeLastEvent/finishCurrentActivity/. Use
6997 addFileToCurrentActivity for summaryFunction.
6999 * buildbot/status/event.py (Logfile): put data in a Swappable when
7001 (Event): add more setter methods. Remove .buildername, use .parent
7002 and getSwappableName instead (needs more thought).
7004 * buildbot/util.py (Swappable):
7005 * test/test_swap.py: don't bother setting filename at __init__
7006 time, do it later. Change setFilename args to take parent first,
7007 since it provides the most significant part of the filename.
7009 2003-04-23 Brian Warner <warner@lothar.com>
7011 * buildbot/status/event.py (Logfile.addEntry): append to previous
7014 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7015 anticipating Swappable
7016 (InternalShellCommand.remoteUpdate): split out various log-adding
7017 methods so subclasses can snarf stdout separately
7019 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7020 in anticipation of Swappable build logs
7021 (Builder.testsFinished): anticipating TestResults, still disabled
7023 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7026 * buildbot/status/event.py (Logfile): add (disabled) support for
7027 Swappable, not ready for use yet
7029 * buildbot/util.py (Swappable): object which is swapped out to
7030 disk after some period of no use.
7031 * test/test_swap.py: test buildbot.utils.Swappable
7033 2003-04-14 Brian Warner <warner@lothar.com>
7035 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7036 periodic-build timer. Set the .periodicBuildTime on a builder
7037 instance to some number of seconds to activate it.
7039 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7041 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7042 a way that survives result tuples
7044 2003-04-12 Brian Warner <warner@lothar.com>
7046 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7047 return a dict instead of a tuple: allow summarizers to provide
7048 multiple summaries if they want
7049 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7050 (debuildSummarizer): summarize lintian warnings/errors
7052 2003-04-10 Brian Warner <warner@lothar.com>
7054 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7056 2003-04-09 Brian Warner <warner@lothar.com>
7058 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7059 empty summaries: happens when the tests fail so hard they don't emit
7060 a parseable summary line.
7062 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7063 Allow summaryFunction to return None to indicate no summary should
7066 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7067 writing to stale HTTP requests: notice when they disconnect and
7068 remove the request from the list. Also add CacheToFile from
7069 moshez, will be used later.
7071 2003-04-08 Brian Warner <warner@lothar.com>
7073 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7074 should be an int, not a list of strings
7076 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7077 if we weren't actually connected
7079 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7080 to show the tail end of the trial text output
7082 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7083 hook to summarize the results of a ShellCommand
7085 2003-04-07 Brian Warner <warner@lothar.com>
7087 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7088 twisted test suite code into a single class.
7089 * buildbot/process/process_twisted.py: same
7091 2003-04-04 Brian Warner <warner@lothar.com>
7093 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7095 * README (SLAVE): document use of mktap to create slave .tap file
7096 (REQUIREMENTS): describe dependencies
7098 * buildbot/bb_tap.py, buildbot/plugins.tml:
7099 * buildbot/bot.py (updateApplication): Add mktap support for creating
7100 buildslave .tap files
7102 2003-03-28 Brian Warner <warner@lothar.com>
7104 * buildbot/process/step.py (InternalShellCommand.finished): handle
7105 new tuple result values (fix embarrasing bug that appeared during
7108 2003-03-27 Brian Warner <warner@lothar.com>
7110 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7113 2003-03-25 Brian Warner <warner@lothar.com>
7115 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7116 to overall build status
7117 * buildbot/clients/base.py (Builder): improve event printing
7118 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7119 instead of generic ShellCommand
7120 (Build): Add .stopBuild, use it when slave is detached
7122 * buildbot/process/step.py (Configure,Test): give the steps their
7123 own names and status strings
7125 * buildbot/status/html.py (StatusResource): add "show" argument,
7126 lets you limit the set of Builders being displayed.
7128 2003-03-20 Brian Warner <warner@lothar.com>
7130 * buildbot/process/basic.py: removed
7132 2003-03-19 Brian Warner <warner@lothar.com>
7134 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7135 turn off process-docs by default
7137 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7138 when displaying build information without anything in allBuilds[]
7140 * buildbot/bot.py (makeApp): really take password from sys.argv
7142 2003-03-18 Brian Warner <warner@lothar.com>
7144 * buildbot/bot.py (buildApp): take password from sys.argv
7146 * README: replace with more useful text
7148 * setup.py: add a real one
7149 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7151 * docs/PyCon-2003/: added sources for PyCon paper.
7153 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7154 now Build objects control the process and Builder only handles
7155 slave stuff and distribution of changes/status. A new BuildFactory
7156 class creates Build objects on demand.
7158 Created ConfigurableBuild which takes a list of steps to run. This
7159 makes it a lot easier to set up a new kind of build and moves us
7160 closer to being able to configure a build from a web page.
7162 * buildbot/process/step_twisted.py, process_twisted.py: move to
7163 new model. A lot of code went away.
7165 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7166 send lots of empty progress messages to the client.
7168 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7170 2003-02-20 Brian Warner <warner@lothar.com>
7172 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7174 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7175 Twisted bug that prevented non-pty processes from working just got
7176 fixed, and the bug that leaks ptys is still being investigated.
7178 * buildbot/process/step.py (CVS): send timeout arg to slave
7180 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7181 builders coming and going
7182 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7183 from CVSToys, handle lost-buildmaster
7185 * buildbot/status/client.py (StatusClientService.removeBuilder):
7186 Clean up status client protocol: send builders (with references)
7187 as they are created, rather than sending a list and requiring the
7188 client to figure out which ones are new.
7189 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7190 attempts to force a build on an unknown builder
7192 2003-02-19 Brian Warner <warner@lothar.com>
7194 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7195 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7196 Twisted stops leaking them.
7197 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7198 builder goes to an idle state.
7200 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7201 I figure out why CVS commands hang without them, and/or I fix the
7202 hung-command timeout
7204 2003-02-16 Brian Warner <warner@lothar.com>
7206 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7207 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7208 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7209 GenerateDocs now that they are prefixed with WARNING:.
7211 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7212 use manual href target instead of request.childLink
7214 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7215 display every second, but update the ETA every 5 seconds (or
7216 whenever) as remote_progress messages arrive.
7219 2003-02-12 Brian Warner <warner@lothar.com>
7221 * *: import current sources from home CVS repository
7225 # add-log-time-format: add-log-iso8601-time-string