1 2007-03-01 Brian Warner <warner@lothar.com>
3 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
5 2007-02-28 Brian Warner <warner@lothar.com>
7 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
8 Lamb to use a more optimal form of 'p4 changes', to reduce server
9 load. He reports that this optimization was added to p4d release
10 2005.2, but it should work in all versions. Closes #27.
11 * buildbot/test/test_p4poller.py: match it
13 2007-02-27 Brian Warner <warner@lothar.com>
15 * buildbot/status/web/*.py: move all web status stuff into a
16 separate directory, in anticipation of splitting it into smaller
17 pieces and adding more files. html.py was getting way too big.
18 * buildbot/status/classic.css: move it too
19 * setup.py: add the new sub-package
20 * buildbot/test/test_web.py: match the changes
21 * MANIFEST.in: handle the move of classic.css
23 2007-02-07 Brian Warner <warner@lothar.com>
25 * contrib/OS-X/*: add some launchd .plist files for automatically
26 starting a buildmaster or buildslave under OS-X (10.4 or later).
27 Thanks to Mark Pauley for these.
29 2007-02-06 Brian Warner <warner@lothar.com>
31 * docs/buildbot.texinfo (Requirements): update requirements to
32 stop claiming compatibility with python-2.2 or twisted-1.3.x .
34 * README: mention python-2.5 and twisted-2.5 compatibility
36 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
38 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
40 * buildbot/status/builder.py: same, by requiring cStringIO
41 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
42 * buildbot/test/test_vc.py: same
43 * buildbot/test/test_web.py:
44 * buildbot/test/test_steps.py: same, remove unused import
46 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
49 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
50 see any Builders that don't have Schedulers to drive them
52 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
53 attributes this uses went away
55 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
56 dialog, to allow you to reset the buildmaster and force
57 connect/disconnect. Correctly handle losing the buildmaster
58 connection (by switching the display to the hexnut, at which point
59 you can use the 'Connect' menu item to reconnect).
61 * buildbot/steps/source.py (Source.start): if we're using a patch,
62 add it as a LogFile to the checkout/update step. This will turn
63 into a link on the waterfall page.
65 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
66 option, to take the patch from a pre-made file rather than
67 generating it from the local tree. Thanks to Robert Helmer for the
68 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
69 * buildbot/scripts/runner.py (TryOptions): add --diff,
70 --patchlevel, and --baserev options
71 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
72 as None, meaning HEAD.
73 * buildbot/sourcestamp.py (SourceStamp): update docstring to
74 indicate that baserev=None means HEAD
75 * docs/buildbot.texinfo (try --diff): document it
77 * buildbot/test/test_steps.py (BuildStep): remove use of
78 reactor.iterate(), although the technique I replaced it with is a
79 gross polling hack that must be cleaned up properly some day. This
80 was the last use of reactor.iterate in the entire tree, yay.
82 2007-02-05 Brian Warner <warner@lothar.com>
84 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
85 is one of the three known values, otherwise we emit some confusing
86 messages later on. Thanks to Grig Gheorghiu for the catch.
88 2007-01-30 Brian Warner <warner@lothar.com>
90 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
91 Hearsum contributed a patch to let BonsaiPoller work with results
92 that contain non-ascii characters. Closes SF#1632641.
94 2007-01-27 Brian Warner <warner@lothar.com>
96 * Makefile (release): produce both .tar.gz and .zip source bundles.
99 2007-01-23 Brian Warner <warner@lothar.com>
101 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
102 * buildbot/changes/monotone.py: same
104 * buildbot/changes/maildir.py: combine several files into one,
105 clean up maildir.py to use Services properly.
106 * buildbot/changes/maildirtwisted.py: remove
107 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
109 * buildbot/changes/mail.py: match the change
110 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
111 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
113 * buildbot/slave/commands.py (command_version): bump to "2.3" to
114 indicate that the buildslave knows about the 'bzr' command
116 2007-01-22 Brian Warner <warner@lothar.com>
118 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
119 'with', it will become a reserved work in python2.6 .
121 * contrib/bb_applet.py: add a simple gnome-panel applet, to
122 display a terse summary of buildbot status.
123 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
124 some icons, small versions of the Blender object that lives in
125 docs/images/icon.blend
127 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
128 * buildbot/slave/commands.py (Bzr): same
129 * buildbot/scripts/tryclient.py (BzrExtractor): same
130 (SourceStampExtractor.dovc): modify this to allow non-zero exit
131 status, since 'bzr diff' does that
132 * buildbot/test/test_vc.py (Bzr): same
133 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
137 2007-01-20 Brian Warner <warner@lothar.com>
139 * contrib/darcs_buildbot.py: tidy up the progress messages
141 2007-01-17 Brian Warner <warner@lothar.com>
143 * contrib/darcs_buildbot.py: enhance to handle multiple patches
144 being pushed at a time. This keeps state in the repository in a
145 small file named .darcs_buildbot-lastchange, but that shouldn't
146 interfere with normal repository operations. Fixes SF#1534049.
147 * buildbot/clients/sendchange.py (Sender): make a single Sender
148 capable of sending Changes with different usernames.
150 2006-12-11 Brian Warner <warner@lothar.com>
152 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
153 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
154 buildbot.changes.mail a long time ago, but I forgot to add the
155 DeprecationWarning until now.
157 * buildbot/process/maxq.py: remove this, the functionality now
158 lives in buildbot.steps.maxq
160 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
161 * buildbot/clients/gtkPanes.py: remove unused import
163 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
164 that was meant to provide a special Reporter to run inside trial
165 and give the buildslave lots of machine-readable status. We never
166 finished this project.
168 * buildbot/changes/bonsaipoller.py: remove unused imports
169 * buildbot/changes/svnpoller.py: same
170 * buildbot/process/builder.py: same
171 * buildbot/process/buildstep.py: same
172 * buildbot/slave/bot.py: hush pyflakes warning
173 * buildbot/status/tests.py: remove unused imports
174 * buildbot/status/tinderbox.py: same
175 * buildbot/steps/python_twisted.py: same
177 * buildbot/process/step.py: remove this file, these names were
178 deprecated in 0.7.5 and are now being removed.
179 * buildbot/process/step_twisted.py: same
180 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
182 * buildbot/twcompat.py: remove the empty file, yay it is gone
184 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
185 tw-2.0.0 and newer have the method we need.
186 (getProcessOutputAndValue): same
187 (which): remove this method, tw-2.0.0 t.p.procutils has it
189 * buildbot/twcompat.py (implements): remove this method
190 * buildbot/*: import implements() from zope.interface directly
192 * buildbot/status/mail.py: stop falling back to importing
193 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
196 * buildbot/twcompat.py (Interface): remove this import
197 * buildbot/*: import Interface from zope.interface directly
199 * buildbot/twcompat.py (providedBy): remove this method
200 * buildbot/*: turn all uses of providedBy(obj, iface) into
201 iface.providedBy(obj)
203 * buildbot/twcompat.py (maybeWait): remove this method, now that
204 we no longer maintain compatibility with Twisted<=1.3.0 .
205 Twisted-2.0.0 and later allow trial methods to return Deferreds
207 * buildbot/test/*: remove all uses of maybeWait
209 * buildbot/__init__.py (version): bump to 0.7.5+ while between
211 * docs/buildbot.texinfo: same
213 2006-12-10 Brian Warner <warner@lothar.com>
215 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
216 * docs/buildbot.texinfo: set version to match
218 2006-12-10 Brian Warner <warner@lothar.com>
220 * README (REQUIREMENTS): update for release
221 * NEWS: update for release
222 * buildbot/slave/commands.py (command_version): mention that this
223 version (2.2) was released with buildbot-0.7.5
225 * buildbot/test/test_config.py (StartService.testStartService):
226 inhibit the usual read-config-on-startup behavior, since otherwise
227 the log.err that gets recorded causes the test to fail
229 * buildbot/status/builder.py (LogFile.finish): forget about all
230 subscribers once the log has finished, since after that point
231 we're never going to use them again. This might help free up some
234 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
235 than the old/deprecated gtk.mainquit()
237 2006-12-09 Brian Warner <warner@lothar.com>
239 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
240 better when we can't open the masterdst file
242 * buildbot/scripts/startup.py (Follower._failure): add missing
243 import statement for BuildSlaveDetectedError
245 * buildbot/steps/transfer.py (FileUpload): cleanup
246 (FileDownload): same. Add tests for slave version, add mode=.
247 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
248 (SlaveFileDownloadCommand): same
249 * buildbot/test/test_transfer.py: enhance tests
250 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
253 2006-12-08 Brian Warner <warner@lothar.com>
255 * buildbot/scripts/runner.py (sendchange): halt the reactor on
256 both success *and* failure. Without this, the 'buildbot
257 sendchange' command would hang if it could not contact the
258 buildmaster or deliver the Change, which would generally cause the
259 user's commit/record/checkin command to hang too. Thanks to
260 Christian Unger for the catch.
262 2006-12-06 Brian Warner <warner@lothar.com>
264 * NEWS: update with items for the next release
266 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
267 whimsical example pulled from a punch-drunk email I sent out late
269 (Transferring Files): document some of the other parameters
270 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
271 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
272 * buildbot/test/test_svnpoller.py: same
273 * buildbot/changes/svnpoller.py (SVNPoller): same
275 2006-11-26 Brian Warner <warner@lothar.com>
277 * docs/buildbot.texinfo (Build Properties): remind users that
278 WithProperties must appear in a command= list, not as a top-level
280 * buildbot/steps/shell.py (ShellCommand.start): and assert that
281 we're sending a list or a single string to the RemoteShellCommand
283 * buildbot/scheduler.py (Nightly): Improve docs slightly.
285 * buildbot/scripts/startup.py (start): skip the whole
286 watch-the-logfile thing under windows, since it needs os.fork()
288 * buildbot/scripts/runner.py (restart): remove the old message
289 that got printed after the buildbot was restarted.. it most cases
290 it didn't get printed at the right time anyways
292 2006-11-25 Brian Warner <warner@lothar.com>
294 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
295 follow twistd.log and print lines until the process has started
296 started properly. For the buildmaster, this means until the config
297 file has been parsed and accepted. For the buildslave, this means
298 until we've connected to the master. We give up after 5 seconds in
299 any case. Helpful error messages and troubleshooting suggestions
300 are printed when we don't see a successful startup. This closes the
301 remainder of SF#1517975.
302 * buildbot/scripts/startup.py: moved app startup code to here
303 * buildbot/scripts/logwatcher.py: utility class to follow log
304 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
305 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
306 so the LogWatcher can tell the difference between a buildmaster
309 2006-11-24 Brian Warner <warner@lothar.com>
311 * docs/examples/twisted_master.cfg: update to match the version
312 in use on twistedmatrix.com
313 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
314 was using before stopped working, but 'irc.freenode.net' works
317 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
320 * buildbot/clients/base.py (TextClient.not_connected): upon
321 UnauthorizedLogin failures, remind the user to connect to the
322 PBListener port instead of the slaveport.
323 (TextClient.disconnected): shut down more quietly
324 * docs/buildbot.texinfo (statuslog): add another reminder
326 * buildbot/scripts/runner.py (Options.subCommands): rename
327 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
328 'sighup' as an alias.
329 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
330 reconfig command to follow twistd.log and print all of the lines
331 from the start of the config-file reload to its completion. This
332 should make it a lot easier to discover bugs in the config file.
333 Use --quiet to disable this behavior. This addresses half of
334 SF#1517975, the other half will be to add this same utility to
335 'buildbot start' and 'buildbot restart'.
336 * docs/buildbot.texinfo (Loading the Config File): same
339 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
340 method, it has been deprecated for a long time. Use
341 IBuilderControl.requestBuild instead.
342 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
343 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
344 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
345 * buildbot/test/test_control.py (Force.testForce): same
346 * buildbot/test/test_run.py: use requestBuild instead
348 * buildbot/clients/debug.py: replace 'Force Build' button with
349 'Request Build' (which just adds one to the queue), add Ping
350 Builder, add branch/revision fields to Request Build.
351 * buildbot/clients/debug.glade: same
352 * buildbot/master.py: update interface to match. This creates an
353 incompatibility between new debugclients and old buildmasters.
355 * buildbot/process/builder.py (Builder._attached): delay the call
356 to maybeStartBuild for a reactor turn, to avoid starting a build
357 in the middle of a reconfig (say, if the new Builder uses a new
358 slave which is already connected).
360 2006-11-23 Brian Warner <warner@lothar.com>
362 * buildbot/test/test_transfer.py: appease pyflakes
363 * buildbot/test/test_steps.py: same
365 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
366 keeps pyflakes from finding undefined names
368 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
369 Builder no longer induces a disconnect/reconnect cycle. This means
370 that any builds currently in progress will not be interrupted, and
371 any builds which are queued in the Builder will not be lost. This
372 is implemented by having the new Builder extract the state (i.e.
373 all pending Builds and any desired SlaveBuilders) from the old
375 (BotPerspective): refactor. The BotPerspective no longer keeps
376 track of all the Builders that want to use this slave; instead, it
377 asks the BotMaster each time it needs this list. This removes
378 addBuilder and removeBuilder. Clean up attached() to acquire all
379 the slave's information in a more atomic fashion. updateSlave() is
380 now the way to make sure the slave is using the right set of
381 Builders: just call it after everything else has been
383 (BotMaster): refactor, removing addBuilder/removeBuilder and
384 replacing them with an all-at-once setBuilders() call.
386 * buildbot/test/test_slaves.py (Reconfig): new test case to
387 exercise this functionality
388 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
389 * buildbot/slave/commands.py (WaitCommand): same
391 * docs/buildbot.texinfo (Loading the Config File): document the
394 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
395 SlaveBuilder to have its parent Builder changed.
396 (SlaveBuilder.isAvailable): new method to give access to state,
397 which is now a private attribute
398 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
399 the SlaveBuilder about how it is being used. These methods update
400 its internal state. buildFinished() is now the place that invokes
401 maybeStartBuild() on its parent Builder.
402 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
403 new Builder to take over for an old one, transferring state from
405 (Buider): refactor the way that SlaveBuilders are used to match,
406 giving them a bit more autonomy.
407 (Builder.buildFinished): this no longer calls maybeStartBuild():
408 instead the SlaveBuilder calls it on whoever its parent Builder is
409 at the time. This way, when an old Builder is replaced by a new
410 one, and there was a build in progress during the transition, when
411 that build finishes, it will be the new Builder that is told about
412 the newly available slave so it can start a new build.
414 * buildbot/process/base.py (Build.startBuild._release_slave): when
415 the Build finishes, tell the SlaveBuilder that they've been
418 * buildbot/status/builder.py (SlaveStatus): add some new setter
419 methods for use by BotPerspective, to keep some attributes more
422 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
423 called by the buildmaster.
424 (Bot.setBuilderList): instead, we locally announce any leftover
425 directories based upon which Builders we were told about. The
426 master doesn't really care; it's the local admin who may or may not
430 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
431 to allow use of python2.4 or whatever. This tool still requires
434 2006-11-19 Brian Warner <warner@lothar.com>
436 * NEWS (IStatusLog.readlines): more news items
438 2006-11-18 Brian Warner <warner@lothar.com>
440 * NEWS: start collecting items for the next release.
442 2006-11-04 Brian Warner <warner@lothar.com>
444 * buildbot/changes/bonsaipoller.py: apply updates from Ben
445 Hearsum. Closes SF#1590310.
446 * buildbot/test/test_bonsaipoller.py: and tests
448 * buildbot/status/tinderbox.py
449 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
450 status when the build results in WARNINGS. Patch from Dave
451 Liebreich. Closes SF#1587352.
453 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
454 linux-vs-osx behavior difference w.r.t. reading from files that
455 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
456 to Mark Rowe for the patch.
458 2006-10-15 Brian Warner <warner@lothar.com>
460 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
461 method name was misspelled in the interface definition. Thanks to
462 Roy Rapoport for the catch.
464 2006-10-13 Brian Warner <warner@lothar.com>
466 * docs/buildbot.texinfo (Adding LogObservers): update sample code
467 to match the great Steps renaming
469 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
470 Maybe I should run my own unit tests before recording a big
471 change. Good thing I've got a buildbot to remind me.
473 2006-10-12 Brian Warner <warner@lothar.com>
475 * buildbot/steps/transfer.py: rework __init__ and args setup
476 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
478 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
479 when opening the target file, only catch IOError (to report via
480 stderr/rc!=0), let the others be reported as normal exceptions
482 2006-10-08 Brian Warner <warner@lothar.com>
484 * contrib/svn_watcher.py: fix security holes by using proper argv
485 arrays and subprocess.Popen() rather than commands.getoutput().
486 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
487 is deprecated in favor of buildbot/changes/svnpoller.py, and will
488 probably be removed by the next release.
491 2006-10-04 Brian Warner <warner@lothar.com>
493 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
494 initial lines that weren't emitted by pyflakes. When the pyflakes
495 command is run under a Makefile, 'make' will echo the command it
496 runs to stdio, and that was getting logged as a "misc" warning.
497 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
498 * buildbot/test/test_steps.py (testPyFlakes3): another test
500 2006-10-01 Brian Warner <warner@lothar.com>
502 * buildbot/status/html.py (HtmlResource.render): if we get a
503 unicode object from our content() method, encode it into utf-8
504 like we've been claiming to all along. This allows the comments
505 and author names from svnpoller.py to be delivered properly.
507 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
508 de-unicodify filenames before creating the Change, because the
509 rest of buildbot is unlikely to handle them well. Leave the 'who'
510 field as a unicode object.. I don't think there's anything that
511 will break very soon, and it will probably nudge us towards
512 accepting unicode everywhere sooner or later. Stop using the
513 "date" field that comes out of SVN, since it is using the
514 repository's clock (and timezone) and what we care about is the
515 buildmaster's (otherwise Changes from the future show up later
516 than the builds they triggered).
517 * buildbot/test/test_svnpoller.py (Everything.test1): match the
520 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
521 Suvbersion repository polling ChangeSource. I've hacked it up
522 considerably: any bugs are entirely my own fault. Thank you
524 * buildbot/test/test_svnpoller.py: tests for it
525 * docs/buildbot.texinfo (SvnSource): document it
527 2006-09-30 Brian Warner <warner@lothar.com>
529 * buildbot/scheduler.py (Periodic): submit a reason= to the
530 BuildSet to indicate which Scheduler triggered the build. Thanks
531 to Mateusz Loskot for the suggestion.
533 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
535 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
536 changes: set self.loop in __init__, remove unused volatile=
538 * docs/buildbot.texinfo (.buildbot config directory): add more
539 docs on the .buildbot/options keys used by "buildbot try"
540 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
541 (Try.deliverJob): same
543 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
547 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
548 close the filehandle when we stop watching the file. Before, the
549 filehandle was only closed when the LogFileWatcher was
550 garbage-collected, which could be quite a while in the future. If
551 it was still open by the time the next build started, windows will
552 refuse to let the new build delete the old build/ directory. Fixes
553 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
554 #twisted for the catch.
556 2006-09-29 Brian Warner <warner@lothar.com>
558 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
561 2006-09-25 Brian Warner <warner@lothar.com>
563 * setup.py: the new buildbot.steps module wasn't being installed.
564 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
565 (testmsgs): add the extra stuff from buildbot/test/* so you can
566 run unit tests on an installed copy of buildbot, not just from
569 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
570 columns of 'svnlook changed' output contain status information, so
571 strip [:4] instead of [:6]. Depending upon what the status flags
572 were, this would sometimes lead to mangled filenames. Thanks to
573 Riccardo Magliocchetti for the patch. Closes SF#1545146.
575 * buildbot/steps/source.py (Monotone): initial Monotone support,
576 contributed by Nathaniel Smith. Still needs docs and tests, but
577 this code has been in use on the Monotone buildbot for a long
579 * buildbot/slave/commands.py (Monotone): slave-side support
580 * buildbot/changes/monotone.py (MonotoneSource): polling change
583 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
584 contributed a Change Source that polls a Bonsai server (a
585 kind of web-based viewcvs CGI script).
587 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
588 Hearsum contributed a status plugin which sends email in the same
589 format that Tinderbox does: this allows a number of tinderbox
590 tools to be driven by Buildbot instead. Thanks Ben!
592 2006-09-24 Brian Warner <warner@lothar.com>
594 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
595 Thanks to Robert Helmer for the patch.
597 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
598 BuildStatus about the buildslave name at the *beginning* of the
599 build, rather than at the end. Thanks to Alexander Lorenz for the
601 * buildbot/status/html.py (StatusResourceBuild.body): always
602 include the slavename in the build page, not just when the build
604 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
605 slavename in the email message
607 2006-09-21 Brian Warner <warner@lothar.com>
609 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
611 * docs/examples/glib_master.cfg: same
612 * docs/examples/hello.cfg: same
613 * docs/examples/twisted_master.cfg: same, update to current usage
615 2006-09-19 Brian Warner <warner@lothar.com>
617 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
618 (PyFlakes.createSummary): make it compatible with python-2.2
620 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
621 for at least the output-parsing parts of PyFlakes
623 2006-09-18 Brian Warner <warner@lothar.com>
625 * buildbot/steps/python.py: oops, fix import of StringIO
627 2006-09-17 Brian Warner <warner@lothar.com>
629 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
630 turns out that SVN-1.4.0 doesn't fail to update once you've
631 replaced a file with a directory, unlike older versions of SVN and
632 pretty much every other VC tool we support. Since what we really
633 care about is that the update succeeds anyway, stop checking that
634 the tree got clobbered and just assert that the build succeeded.
635 (VCBase.printLogs): add a utility function for debugging
637 * buildbot/process/step.py: oops, added extra imports by mistake
639 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
640 rstrip() on the first line coming out of the 'p4 describe'
641 process, to remove the stray ^M that Wade Brainerd reports seeing
642 in the 'when' field. Fixes SF#1555985.
644 * buildbot/master.py (BuildMaster.loadConfig): improve the error
645 message logged when c['schedulers'] is not right
646 * buildbot/scheduler.py (Scheduler.__init__): improve error
647 message when a Scheduler() is created with the wrong arguments
648 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
649 verify that these error messages are emitted
651 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
652 The idea is that all the base classes (like BuildStep and
653 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
654 will be a leftover backwards-compatibility file that only contains
655 aliases for the steps that were moved out to buildbot.steps.*
656 * lots: change imports to match
657 * buildbot/process/step.py: add a DeprecationWarning if it ever
660 2006-09-12 Brian Warner <warner@lothar.com>
662 * buildbot/scheduler.py (Scheduler.__init__): make sure that
663 builderNames= is actually a sequence, since if you happen to give
664 it a single builder-specification dictionary instead, it won't get
665 caught by the existing assert. Thanks to Brett Neely for the
668 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
670 * docs/buildbot.texinfo (Python BuildSteps): document them
671 (sendchange): include a link to PBChangeSource, since you need one
673 * buildbot/steps/shell.py: clean up test-case-name line, remove some
675 * buildbot/steps/dummy.py: same
677 2006-09-08 Brian Warner <warner@lothar.com>
679 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
680 BuildStep which lets you transfer files from the master to the
681 slave or vice versa. Thanks to Albert Hofkamp for the original
682 patch. Fixes SF#1504631.
683 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
685 (SlaveFileDownloadCommand): same
686 * docs/buildbot.texinfo (Transferring Files): document it
687 * buildbot/test/test_transfer.py: test it
688 * buildbot/test/runutils.py (StepTester): new utility class for
689 testing BuildSteps and RemoteCommands without Builds or Bots or PB
690 * buildbot/test/test_steps.py (CheckStepTester): validate that the
693 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
694 walk through StatusLogs one line at a time, mostly for the benefit
695 of ShellCommand.createSummary methods. You can either walk through
696 STDOUT or STDERR, but the default is STDOUT.
698 * buildbot/status/builder.py (LogFile.readlines): implement it.
699 Note that this is not yet memory-efficient, it just pulls the
700 whole file into RAM and then splits it up with a StringIO.
701 Eventually this should be a generator that only pulls chunks from
703 * buildbot/test/test_status.py (Log.testReadlines): test it
705 * docs/buildbot.texinfo: update to match changes
706 * buildbot/process/factory.py: stop using old definitions
707 * buildbot/process/process_twisted.py: same
708 * buildbot/test/test_*.py: same
710 * buildbot/process/step_twisted.py: move definition to..
711 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
712 relative-import mechanisms prevent this from being named 'twisted'
713 or 'python/twisted' as I would have preferred.
715 * buildbot/process/maxq.py: move definition to..
716 * buildbot/steps/maxq.py: .. here, leave a compatibility import
718 * buildbot/process/step.py: split the user-visible BuildSteps into
719 separate files, all under buildbot/steps/
720 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
721 * buildbot/steps/shell.py: this holds ShellCommand and friends
722 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
724 2006-09-05 Brian Warner <warner@lothar.com>
726 * lots: run pyflakes, removed a lot of unused imports, changed the
727 form of some conditional imports to remove false pyflakes
728 warnings. There are still a number of warnings left, mostly from
729 imports that are done for their side-effects.
730 * buildbot/test/test_vc.py: import twisted.python.failure, since it
733 2006-08-26 Brian Warner <warner@lothar.com>
735 * buildbot/test/test_locks.py (Unit.testLater): make the tests
736 compatible with twisted-1.3.0, for some reason I just can't seem
737 to let go of the past.
739 2006-08-25 Brian Warner <warner@lothar.com>
741 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
743 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
744 all logfiles= in startCommand(), rather than in start() . This
745 makes it easier to have the 'stdio' log come before any secondary
746 logfiles, which I feel makes the waterfall display more
748 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
749 from ShellCommand up into LoggingBuildStep
750 (LoggingBuildStep.__init__): move the handling of logfiles= from
751 ShellCommand up to LoggingBuildStep, because startCommand is
752 provided by LoggingBuildStep, whereas start() was specific to
753 subclasses like ShellCommand and Source. This removes code
754 duplication in those subclasses.
755 (ShellCommand.__init__): same
756 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
757 for a slave that's too old to understand logfiles= into a separate
758 method, so it can live in ShellCommand. The rest of
759 setupLogfiles() can live in LoggingBuildStep.
761 2006-08-24 Brian Warner <warner@lothar.com>
763 * buildbot/locks.py (BaseLock): you can now configure Locks to
764 allow multiple simultaneous owners. They still default to
765 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
767 * docs/buildbot.texinfo (Interlocks): document the new options
768 * buildbot/test/test_locks.py: add a bunch of new unit tests
769 * buildbot/process/base.py (Build.acquireLocks): locks now offer
770 waitUntilMaybeAvailable, not waitUntilAvailable
771 * buildbot/process/step.py (BuildStep.acquireLocks): same
772 * buildbot/master.py (BotMaster.getLockByID): real locks now use
773 the whole lockid in their constructor, not just the name. Also,
774 keep track of which real locks we've handed out by the full
775 lockid, not just class+name, otherwise changing just the maxCount=
776 in the master.cfg file would not actually cause a behavioral
779 2006-08-23 Brian Warner <warner@lothar.com>
781 * buildbot/__init__.py (version): bump to 0.7.4+ while between
783 * docs/buildbot.texinfo: same
785 2006-08-23 Brian Warner <warner@lothar.com>
787 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
788 * docs/buildbot.texinfo: set version to match
789 * NEWS: update for 0.7.4
790 * buildbot/slave/commands.py (command_version): mention that this
791 version (2.1) was released with buildbot-0.7.4
793 2006-08-22 Brian Warner <warner@lothar.com>
797 * CREDITS: new file, list of people who have helped. Thanks!
798 * MANIFEST.in: ship it
800 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
801 new diagrams, the user's manual is more informative than it was.
802 Start shipping the .html user's manual (and generated .png
804 * Makefile: update 'release' target to match
806 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
807 test.. I think the web-parts effort will render it pointless well
808 before it ever actually starts to work.
810 2006-08-20 Brian Warner <warner@lothar.com>
812 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
813 meaning of the prefix= argument. It is now just a string which is
814 stripped from the beginning of the filename. If prefix= is set but
815 not found on any given filename, that filename is ignored. If all
816 filenames in a Change are ignored, the Change is dropped. This is
817 much simpler than the previous sep= nonsense, and I should have
818 implemented it this way from the beginning. Effectively resolves
819 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
820 Gedminas for the catch and suggested fixes.
821 (ChangePerspective.perspective_addChange): implement the actual
823 * buildbot/test/test_changes.py (TestChangePerspective): test it
824 * docs/buildbot.texinfo (PBChangeSource): document it, explain
825 how to properly use prefix=
826 * docs/examples/twisted_master.cfg (source): update prefix= by
827 adding the trailing slash
830 * docs/examples/twisted_master.cfg: update to actual practice
832 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
833 update test case to match new link text.. the HREF has both a
834 class= setting and an enclosing [] pair that I didn't match in the
837 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
838 list of strings is preferred over a single string with embedded
840 (ShellCommand.description=): explain that either single strings or
841 a list of strings is acceptable, and why you might prefer one over
842 the other. Add an example. Fixes SF#1524659, thanks to Paul
843 Winkler for the catch.
844 (Build Steps): update to use f.addStep() rather than using s()
845 and the constructor list
847 * buildbot/process/step.py (ShellCommand): accept either a single
848 string or a list of strings in both description= and
850 * buildbot/test/test_steps.py (Steps.test_description): test it
851 * buildbot/test/runutils.py (makeBuildStep): support for that test
853 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
854 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
855 collecting the files and creating the patch.
857 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
858 per-step URLs that will be displayed on the waterfall display,
859 for things like the HTML output of code-coverage tools, when
860 the results are hosted elsewhere.
861 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
862 way to retrieve these URLs
863 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
864 the method to retrieve these URLs. Also provide backwards
865 compatibility for saved BuildStepStatus instances that didn't have
867 * buildbot/process/step.py (BuildStep.addURL): method to set these
868 URLs from within a BuildStep
869 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
870 (StepBox.getBox): give these external links a distinct CSS class
871 named "BuildStep external" so a .css file can display them
874 * buildbot/test/test_web.py (WaterfallSteps): test that we really
876 * buildbot/test/test_steps.py (Steps): test that we can all the
877 URLs. Also add a bunch of other tests on methods that can be
878 called from within BuildSteps
879 * buildbot/test/runutils.py (makeBuildStep): add utility function
881 2006-08-13 Brian Warner <warner@lothar.com>
883 * docs/buildbot.texinfo (BuildStep LogFiles): document them
885 2006-08-10 Brian Warner <warner@lothar.com>
887 * docs/buildbot.texinfo (Index of master.cfg keys): add another
888 index, this one of things like c['sources'] and c['schedulers']
889 (indices): it looks like my clever idea of putting the @fooindex
890 commands in between the @node and the @subsection (to make the
891 HREF anchor jump to slightly above the section title, which works
892 much better in html) confused texinfo horribly, so I'm moving the
893 index tags back to be just after the @subsection marker. I also
894 added extra lines between the @node/@section paragraph and the
895 index tags, since I think maybe texinfo wants to see these be
898 * docs/Makefile (images): make sure images get built when
900 * docs/images/Makefile: same
902 * buildbot/scripts/runner.py: rename 'buildbot master' to
903 'buildbot create-master', and 'buildbot slave' to 'buildbot
905 * docs/buildbot.texinfo: same
908 * docs/buildbot.texinfo: reimplement the "useful classes" index
909 with actual texinfo indices. The .info rendering is a bit
910 weird-looking but it works well, and the HTML rendering is quite
911 nice. This also puts the index targets in the regular flow of the
912 text, which is easier to maintain.
914 2006-08-06 Brian Warner <warner@lothar.com>
916 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
917 Kevin Turner to prefer the environ= argument be a list rather than
918 a string. If it is a list, it will be joined with a platform-local
919 os.pathsep delimiter, and then prepended to any existing
920 $PYTHONPATH value. This works better in cross-platform (i.e.
921 windows buildslaves) environments when you need to push multiple
922 directories onto the front of the path.
923 (SlaveShellCommand): documented the new magic
924 * docs/buildbot.texinfo (ShellCommand): documented the new magic
925 in a user-visible form
927 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
928 Turner to prefer lists over strings when creating/running VC
929 commands during unit tests. This is clearly necessary to survive
930 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
931 renamed the wq() function to qw() though, since that's how it's
932 spelled in perl. Eventually I'd prefer all commands to be
933 specified with lists.
935 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
936 which are deleted (or not yet created) correctly. Also add
937 failsafe code to not explode if the file-watching poller doesn't
938 get started. Thanks to JP Calderone for the catch and the poller
940 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
942 * buildbot/test/emitlogs.py: same
944 * NEWS: summarize recent changes
946 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
947 clause to avoid the "host key mismatch" warning
949 * buildbot/process/step_twisted.py (Trial.start): if the
950 buildslave is too old to understand logfiles=, fall back to
951 running 'cat _trial_temp/test.log' like before.
952 (Trial.commandComplete): same. this takes advantage of the
953 LoggingBuildStep refactoring to stall commandComplete long enough
954 to run a second RemoteShellCommand.
956 * buildbot/process/step.py (LoggingBuildStep.startCommand):
957 refactor command-completion handling, to allow methods like
958 commandComplete/createSummary/evaluateCommand to return Deferreds.
959 (LoggingBuildStep._commandComplete): delete the refactored method
960 (ShellCommand.setupLogfiles): if the buildslave is too old to
961 understand logfiles=, put a warning message both into twistd.log
962 and into the otherwise empty user-visible LogFiles.
964 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
965 callers to provide the slave-side logfile name, rather than
966 forcing it to come from the local name of the LogFile.
967 (BuildStep.getSlaveName): new method
969 * buildbot/process/base.py (Build.getSlaveName): new method, so
970 steps can find out which buildslave they're running on
972 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
973 to match the s/cvs_ver/command_version/ change
975 2006-08-05 Brian Warner <warner@lothar.com>
977 * buildbot/slave/commands.py (command_version): replace the CVS
978 auto-updated cvs_ver keyword with a manually-updated variable,
979 since CVS is no longer the master repository. Add a description of
980 the remote API change starting in this version (2.1), specifically
981 the fact that SlaveShellCommand now accepts 'initial_stdin',
982 'keep_stdin_open', and 'logfiles'.
984 2006-07-31 Brian Warner <warner@lothar.com>
986 * docs/buildbot.texinfo (System Architecture): Finally add lots of
987 diagrams to describe how the whole system fits together. The
988 images themselves are kept in SVG files, with ascii-art versions
989 in corresponding .txt files. Texinfo knows how to interpolate the
990 text version into .info files, reference the .png versions from
991 .html files, and include .eps versions in the .ps format.
992 * docs/images/Makefile: tools to create .png and .eps
993 * docs/images/*.svg: created pictures with Inkscape.
994 * .darcs-boring: ignore the generated .eps and .png files
996 2006-07-24 Brian Warner <warner@lothar.com>
998 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
999 Scheduler names, since they cause setServiceParent to explode
1001 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1003 2006-07-20 Brian Warner <warner@lothar.com>
1005 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1006 which runs the buildbot unit tests
1008 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1009 classes that are useful in master.cfg
1011 2006-07-15 Brian Warner <warner@lothar.com>
1013 * Makefile (some-apidocs): new target to build only some epydocs
1015 * setup.py: minor comment.. does the classifiers= argument prevent
1016 the setup.py script from working on python2.2/2.3?
1018 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1021 * buildbot/twcompat.py: fix minor typo in comments
1023 * buildbot/manhole.py: move all Manhole-related code out to this
1024 module. Implement SSH-based manholes (with TwistedConch), and move
1025 to conch's nifty line-editing syntax-coloring REPL shell instead
1026 of the boring non-editing monochromatic (and deprecated) old
1028 * buildbot/master.py: remove all Manhole-related code
1029 (BuildMaster.loadConfig._add): make sure the old manhole is
1030 removed before we add the new one
1031 * docs/buildbot.texinfo (Debug options): document new Manhole options
1033 * buildbot/twcompat.py (_which): fix some epydoc issues
1034 * buildbot/status/html.py (Waterfall.__init__): same
1036 2006-06-29 Brian Warner <warner@lothar.com>
1038 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1039 deprecation warnings under newer Twisteds (by using
1040 zope.interface.Interface instead of old twisted.python.components
1042 * buildbot/slave/interfaces.py: same
1044 2006-06-28 Brian Warner <warner@lothar.com>
1046 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1047 svn commands, so it will fail immediately instead of hanging while
1048 it waits for a username/password to be typed in.
1050 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1051 log message if the step was shut down
1053 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1054 obsolete reference to mktap.
1056 2006-06-20 Brian Warner <warner@lothar.com>
1058 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1059 test to include new 'logfiles' argument sent from master to slave
1061 2006-06-19 Brian Warner <warner@lothar.com>
1063 * buildbot/process/step_twisted.py (Trial): track Progress from
1064 _trial_temp/test.log too
1066 * buildbot/process/step.py (OutputProgressObserver): generalize
1067 the earlier StdioProgressObserver into an OutputProgressObserver
1068 that can track LogFiles other than stdio.
1069 (LoggingBuildStep.__init__): same
1071 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1072 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1073 will fail under windows because of os.sep issues. It might have
1074 worked before if 'cat' was doing cygwin path conversion.
1076 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1077 creation of LogFileWatchers
1078 (ShellCommand._startCommand): and record the files that were
1079 watched in the 'headers' section of the ShellCommand output
1081 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1082 need to actually pass it to the slave if you want it to work.
1083 (ShellCommand): document it a bit
1085 * buildbot/test/test_shell.py: new test to validate LogFiles
1086 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1088 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1089 before printing the last batch of lines, to test that the polling
1090 logic is working properly
1092 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1093 handling, making it possible to track multiple logs for a single
1094 RemoteCommand. The previous single logfile is now known as the
1096 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1097 (RemoteShellCommand.__init__): accept logfiles=
1098 (LoggingBuildStep.startCommand): stdio_log is now one of many
1099 (ShellCommand): added logfiles= argument, as well as a class-level
1100 .logfiles attribute, which will be merged together to figure out
1101 which logfiles should be tracked. The latter maybe be useful for
1102 subclasses of ShellCommand which know they will aways produce
1103 secondary logfiles in the same location.
1105 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1106 and closeStdin() methods, preparing to make it possible to write
1107 to a ShellCommand's stdin at any time, not just at startup. These
1108 writes are buffered if the child process hasn't started yet.
1109 (LogFileWatcher): new helper class to watch arbitrary logfiles
1110 while a ShellCommand runs. This class polls the file every two
1111 seconds, and sends back 10k chunks to the buildmaster.
1112 (ShellCommand): rename stdin= to initialStdin=, and add
1113 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1115 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1116 key of "log" and a value of (logname, data).
1117 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1118 'logfiles' to the master-visible args dictionary.
1119 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1122 * buildbot/test/test_vc.py (Patch.testPatch): same
1125 * buildbot/test/emit.py: write to a logfile in the current
1126 directory. We use this to figure out what was used as a basedir
1127 rather than looking to see which copy of emit.py gets run, so that
1128 we can run the commands from inside _trial_temp rather than inside
1130 * buildbot/test/subdir/emit.py: same
1131 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1132 argument rather than running from buildbot/test/
1133 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1134 rather than using an implicit setUp()
1135 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1136 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1137 of assuming that we're running in buildbot/test/ (and that '.' is
1140 * buildbot/slave/commands.py (Command.doStart): refactor Command
1141 startup/completion a bit: now the SlaveBuilder calls doStart(),
1142 which is not meant for overridding by subclasses, and doStart()
1143 calls start(), which is. Likewise the SlaveBuilder calls
1144 doInterrupt(), and subclasses override interrupt(). This also puts
1145 responsibility for maintaining .running in Command rather than in
1147 (Command.doInterrupt): same
1148 (Command.commandComplete): same, this is called when the deferred
1149 returned by start() completes.
1150 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1151 (SlaveBuilder.remote_interruptCommand): same
1152 (SlaveBuilder.stopCommand): same
1154 2006-06-16 Brian Warner <warner@lothar.com>
1156 * buildbot/test/test_shell.py: new test file to contain everything
1157 relating to ShellCommand
1158 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1159 multiple logfiles in realtime" feature, not yet implemented
1160 * buildbot/test/emitlogs.py: support file for testLogFiles
1161 * docs/buildbot.texinfo (ShellCommand): document the feature
1163 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1165 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1166 for tests which exercise SlaveCommands in isolation.
1168 * buildbot/test/test_slavecommand.py: Move some utilities like
1169 SignalMixin and FakeSlaveBuilder from here ..
1170 * buildbot/test/runutils.py: .. to here, so they can be used by
1171 other test classes too
1172 * buildbot/test/test_vc.py: more SignalMixin refactoring
1173 * buildbot/test/test_control.py: same
1174 * buildbot/test/test_run.py: and some rmtree refactoring
1176 2006-06-15 Brian Warner <warner@lothar.com>
1178 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1179 'testBranch' to match other VC tests and have the tests run in
1180 roughly increasing order of dependency
1182 * buildbot/test/test_steps.py (LogObserver): new test to verify
1183 LogObservers can be created at various times and still get
1184 connected up properly
1186 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1187 to create BuildStepStatus instances that actually work.
1189 * buildbot/process/step.py (LogObserver): add outReceived and
1190 errReceived base methods, to be overridden
1192 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1193 API to take a name instead of a step, reducing the coupling
1194 somewhat. This returns the BuildStepStatus object so it can be
1195 passed to the new Step, instead of jamming it directly into the
1197 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1199 * buildbot/process/base.py (Build.setupBuild): use both methods
1200 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1201 process a bit to match
1203 2006-06-14 Brian Warner <warner@lothar.com>
1205 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1206 docs on writing new LogObserver classes
1207 (Writing New Status Plugins): brief docs on how Status Plugins fit
1210 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1211 implement a LogObserver that counts how many unit tests have been
1213 (Trial.__init__): wire it in
1214 * buildbot/test/test_twisted.py (Counter): unit test for it
1216 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1217 to new cmd.logs['stdio'] scheme
1218 (Trial.commandComplete): same
1219 (BuildDebs.commandComplete): same
1221 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1222 LogFiles, instead of just a single one. The old single logfile is
1223 now called "stdio". LoggedRemoteCommand no longer creates a
1224 LogFile for you (the code to do that was broken anyway). If you
1225 don't create a "stdio" LogFile, then stdout/stderr will be
1227 (LogObserver): implement "LogObservers", which a BuildStep can add
1228 to parse the output of a command in real-time. The primary use is
1229 to provide more useful information to the Progress code, allowing
1230 better ETA estimates.
1231 (LogLineObserver): utility subclass which feeds complete lines to
1232 the parser instead of bytes.
1233 (BuildStep.progressMetrics): this is safer as a tuple
1234 (BuildStep.setProgress): utility method, meant to be called by
1236 (BuildStep.addLogObserver): new method, to be called at any time
1237 during the BuildStep (even before any LogFiles have been created),
1238 to attach (or schedule for eventual attachment) a LogObserver to a
1240 (StdioProgressObserver): new LogObserver which replaces the old
1241 "output" progress gatherer
1242 (LoggingBuildStep.__init__): same
1243 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1244 (LoggingBuildStep._commandComplete): must use logs['stdio']
1245 instead of the old single ".log" attribute.
1246 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1247 functionality, now subsumed into StdioProgressObserver
1248 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1249 log name changed from "output" to "stdio".
1252 * buildbot/interfaces.py (ILogFile): add the Interface used from
1253 the BuildStep towards the LogFile
1254 (ILogObserver): and the one provided by a LogObserver
1255 * buildbot/status/builder.py (LogFile): implement it
1257 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1258 HEADER constants here ..
1259 * buildbot/status/builder.py (STDOUT): .. from here
1261 2006-06-13 Brian Warner <warner@lothar.com>
1263 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1264 compatibility with python2.2, which doesn't have the 'substr in
1266 (TestP4Poller.makeTime): utility function to construct the
1267 timestamp using the same strptime() approach as p4poller does. It
1268 turns out that time.mktime() behaves slightly differently under
1269 python2.2, probably something to do with the DST flag, and that
1270 causes the test to fail under python2.2. (changing the mktime()
1271 arguments to have dst=0 instead of -1 caused it to fail under
1272 python2.3. Go figure.)
1273 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1275 2006-06-12 Brian Warner <warner@lothar.com>
1277 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1278 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1279 contributing such an excellent patch, including docs and unit
1280 tests! This makes it *so* much easier to apply. I had to update
1281 test_vc.py to handle some recent refactorings, but everything else
1282 applied smoothly. The only remaining thing I'd like to fix would
1283 be to remove the hard-wired port 1666 used by p4d, and allow it to
1284 claim any unused port. This would allow two copies of the test
1285 suite to run on the same host at the same time, as well as
1286 allowing the test suite to run while a real (production) p4d was
1287 running on the same host. Oh, and maybe we should add a warning to
1288 step.P4 that gets emitted if the slave is too old to provide the
1289 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1290 * buildbot/slave/commands.py (P4): same
1291 (P4Sync): same, some minor updates
1292 * buildbot/changes/p4poller.py: same
1293 * docs/buildbot.texinfo: same
1294 * buildbot/test/test_p4poller.py: same
1295 * buildbot/test/test_vc.py (P4): same
1297 * setup.py: add Trove classifiers for PyPI
1299 2006-06-08 Brian Warner <warner@allmydata.com>
1301 * buildbot/status/client.py
1302 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1303 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1304 build needs to be IRemote'd separately, rather than IRemote'ing
1305 the whole list at once. I can't wait until newpb's serialization
1306 adapters make this unnecessary.
1308 2006-06-06 Brian Warner <warner@lothar.com>
1310 * buildbot/process/step.py (WithProperties): make this inherit
1311 from ComparableMixin, so that reloading an unchanged config file
1312 doesn't cause us to spuriously reload any Builders which use them.
1313 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1316 2006-06-03 Brian Warner <warner@lothar.com>
1318 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1319 running py2exe on windows, contributed by Mark Hammond. Addresses
1320 SF#1401121, but I think we still need to include
1321 buildbot/scripts/sample.cfg
1322 * setup.py: include buildbot_service.py as a script under windows
1323 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1324 a py2exe application), get the icon/css datafiles from a different
1327 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1328 double-escape the build URL. Thanks to Olivier Bonnet for the
1329 patch. Fixes SF#1452801.
1331 2006-06-02 Brian Warner <warner@lothar.com>
1333 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1334 first six columns of 'svnlook' output, not just the first column,
1335 since property changes appear in the other five. Thanks to Olivier
1336 Bonnet for the patch. Fixes SF#1398174.
1338 2006-06-01 Brian Warner <warner@lothar.com>
1340 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1341 the fake build, so that title= has something to be set to
1343 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1344 attribute of the "Build #NN" link in the yellow start-the-build
1345 box to the build's reason. This means that you get a little
1346 tooltip explaining why the build was done when you hover over the
1347 yellow box. Thanks to Zandr Milewski for the suggestion.
1349 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1350 (Box.setETA): handle ETA=None (by stopping the timer)
1351 (Box.update): make the [soon] text less different than the usual
1352 text, so the rest of the text doesn't flop around so much. It
1353 would be awfully nice to figure out how to center this stuff.
1354 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1356 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1357 by default, so that any ShellCommand which fails marks the overall
1358 build as a failure. I should have done this from the beginning.
1359 Add flunkOnFailure=False to the arguments if you want to turn off
1362 2006-05-30 Brian Warner <warner@lothar.com>
1364 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1365 last-build/current-build/current-step. Show what step is currently
1366 running. Show ETA for both the overall build and the current step.
1367 Update GTK calls to modern non-deprecated forms. There's still a
1368 lot of dead code and debug noise to remove.
1370 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1371 shows up properly in status displays
1373 2006-05-28 Brian Warner <warner@lothar.com>
1375 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1376 build we use to verify that WithProperties works:
1378 ** set flunkOnFailure=True so that build failures get noticed
1379 ** set workdir='.' so that the build succeeds, otherwise it is trying
1380 to touch 'build/something', and 'build/' doesn't exist because
1381 usually that's created by a Source step
1382 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1383 this test somehow triggers, in which the 'touch' process becomes
1384 a zombie and we wait for th etimeout before giving up on it.
1386 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1387 to log the Build results and step logs to the twisted log.
1388 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1389 what went wrong if a build was expected to succeed but didn't.
1391 * buildbot/process/step_twisted.py (Trial): set the default
1392 trialMode to '--reporter=bwverbose', which specifies verbose
1393 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1394 '-to', but those are completely missing in modern Twisteds.
1396 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1397 a localhost-only port, to encourage better security
1399 * docs/buildbot.texinfo (Change Sources): mention
1402 * .darcs-boring: add a Darcs boringfile
1404 * README (REQUIREMENTS): stop claiming compatibility with
1407 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1410 2006-05-27 Brian Warner <warner@lothar.com>
1412 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1413 * docs/buildbot.texinfo: same
1415 2006-05-23 Brian Warner <warner@lothar.com>
1417 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1418 * docs/buildbot.texinfo: set version to match
1419 * NEWS: update for 0.7.3
1421 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1422 give a quick mapping from VC system to possible ChangeSources
1423 (Build Properties): add 'buildername'
1425 * buildbot/process/base.py (Build.setupStatus): oops, set
1426 'buildername' and 'buildnumber' properties
1427 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1430 2006-05-22 Brian Warner <warner@lothar.com>
1432 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1433 property interpolation better
1435 * README (INSTALLATION): remove old '-v' argument from recommended
1438 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1439 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1442 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1443 'svnversion' instead of grepping the output of 'svn info', much
1444 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1445 Bonnet for the suggestion.
1446 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1447 require the WC_PATH argument, so run 'svnversion .' instead.
1449 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1450 aren't supposed to have 'self' in their argument list
1452 2006-05-21 Brian Warner <warner@lothar.com>
1454 * buildbot/process/step.py (ShellCommand.start): make
1455 testInterpolate pass. I was passing the uninterpolated command to
1456 the RemoteShellCommand constructor
1457 (ShellCommand._interpolateProperties): oops, handle non-list
1458 commands (i.e. strings with multiple words separated by spaces in
1459 them) properly, instead of forgetting about them.
1461 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1462 to actually try to use build properties in a real build. This test
1464 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1465 to start and evaluate builds
1467 * buildbot/test/test__versions.py: add a pseudo-test to record
1468 what version of Twisted/Python/Buildbot are running. This should
1469 show up at the beginning of _trial_tmp/test.log, and exists to help
1470 debug other problems.
1472 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1473 a filename to be served as 'robots.txt' to discourage web spiders.
1474 Adapted from a patch by Tobi Vollebregt, thanks!
1475 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1476 (Waterfall.test_waterfall): tweak the way that filenames are put
1477 into the config file, to accomodate windows pathnames better.
1479 * docs/buildbot.texinfo (HTML Waterfall): document it
1481 * buildbot/process/process_twisted.py
1482 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1483 changed the build process. The new setup.py no longer takes the
1485 (FullTwistedBuildFactory.__init__): same
1486 (TwistedReactorsBuildFactory.__init__): same
1488 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1489 be placed in the [hooks] section of the central repository (the
1490 one that everybody pushes changes to).
1492 2006-05-20 Brian Warner <warner@lothar.com>
1494 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1495 .darcs-context file, use binary mode. I think this was causing a
1496 Darcs failure under windows.
1498 2006-05-19 Brian Warner <warner@lothar.com>
1500 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1501 use a timezone string of +0000 and gmtime, since this timestamp is
1502 sent to a buildmaster and %z is broken.
1504 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1505 string and localtime, since this timestamp will only be consumed
1506 locally, and %z is broken.
1508 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1509 gmtime, since this timestamp is returned to the buildmaster, and
1512 2006-05-18 Brian Warner <warner@lothar.com>
1514 * NEWS: update in preparation for next release
1516 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1517 setup-repository and do-we-have-the-vc-tools code into a separate
1518 "helper" class, which sticks around in a single module-level
1519 object. This seems more likely to continue to work in the future
1520 than having it hide in the TestCase and hope that TestCases stick
1521 around for a long time.
1523 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1524 addremove' has been deprecated in recent versions of mercurial, so
1525 use 'hg add' instead
1527 2006-05-07 Brian Warner <warner@lothar.com>
1529 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1530 operating under windows, move the file before opening it, since
1531 you can't rename a file that somebody has open.
1533 * buildbot/process/base.py (Build.setupBuild): if something goes
1534 wrong while creating a Step, log the name and arguments, since the
1535 error message when you get the number of arguments wrong is really
1538 2006-05-06 Brian Warner <warner@lothar.com>
1540 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1541 bugs in twisted-specific code not covered by my unit tests, this
1542 time use 'cmd' argument instead of self.cmd
1544 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1545 fix stupid braino: either use startwith or find()==0, not both.
1546 (TwistedReactorsBuildFactory.__init__): another dumb typo
1548 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1549 mark this test as TODO under windows, since process-killing seems
1550 dodgy there. We'll come back to this later and try to fix it
1553 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1554 and don't include a timezone
1555 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1556 This should avoid the windows-with-verbose-timezone-name problem
1558 (Patch.testPatch): add a test which runs 'patch' with less
1559 overhead than the full VCBase.do_patch sequence, to try to isolate
1560 a windows test failure. This one uses slave.commands.ShellCommand
1561 and 'patch', but none of the VC code.
1563 * buildbot/slave/commands.py (getCommand): use which() to find the
1564 executables for 'cvs', 'svn', etc. This ought to help under
1567 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1568 working directory before starting. If an earlier test failed, the
1569 leftover directory would mistakenly flunk a later test.
1570 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1571 Make sure that we use the right commandlines if which("tla") picks
1572 up "tla.exe" (as it does under windows).
1573 (TlaSupport.do_get): factor out this tla-vs-baz difference
1574 (TlaSupport.vc_create): more tla-vs-baz differences
1576 * buildbot/test/test_slavecommand.py
1577 (ShellBase.testShellMissingCommand): stop trying to assert
1578 anything about the error message: different shells on different
1579 OSes with different languages makes it hard, and it really isn't
1580 that interesting of a thing to test anyway.
1582 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1583 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1584 "Panther"), because it has a bug which flunks a couple tests in
1585 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1586 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1587 able to test that yet.
1589 2006-04-30 Brian Warner <warner@lothar.com>
1591 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1592 make sure child commands emit messages in english, so our regexps
1593 will match. Thanks to Nikaus Giger for identifying the problems.
1594 (VCBase._do_vctest_export_1): mode="export" is not responsible
1595 for setting the "got_revision" property, since in many cases it is
1596 not convenient to determine.
1597 (SVNSupport.capable): when running 'svn --version' to check for
1598 ra_local, we want error messages in english
1599 * buildbot/test/test_slavecommand.py
1600 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1601 to emit the error message in english
1603 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1604 the environment with $LC_ALL="C" so that Commands which need to
1605 parse the output of their child processes can obtain it in
1607 (SVN.parseGotRevision): call "svn info" afterwards instead of
1608 watching the output of the "svn update" or "svn checkout".
1609 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1610 (Arch.parseGotRevision): same
1611 (Bazaar.parseGotRevision): same
1612 (Mercurial.parseGotRevision): same
1614 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1615 $LC_ALL="C" when running commands under 'buildbot try', too
1617 * buildbot/test/__init__.py: remove the global os.environ()
1618 setting, instead we do it just for the tests that run commands and
1619 need to parse their output.
1621 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1622 remove the overly-short .timeout on this test, because non-DNotify
1623 platforms must fall back to polling which happens at 10 second
1624 intervals, so a 5 second timeout would never succeed.
1626 2006-04-24 Brian Warner <warner@lothar.com>
1628 * docs/buildbot.texinfo (Installing the code): update trial
1629 invocation, SF#1469116 by Niklaus Giger.
1630 (Attributes of Changes): updated branch-name examples to be
1631 a bit more realistic, SF#1475240 by Stephen Davis.
1633 * contrib/windows/buildbot2.bat: utility wrapper for windows
1634 developers, contributed by Nick Trout (after a year of neglect..
1635 sorry!). SF#1194231.
1637 * buildbot/test/test_vc.py (*.capable): store the actual VC
1638 binary's pathname in VCS[vcname], so it can be retrieved later
1639 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1640 strip out non-numeric timezone information, specifically the funky
1641 German string that his system produced that confuses CVS.
1642 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1643 allow Darcs tests to work on windows
1644 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1645 procutils.which() everywhere, to allow tryclient to work under
1646 windows. Also from Niklaus Giger, SF#1463394.
1648 * buildbot/twcompat.py (which): move the replacement for a missing
1649 twisted.python.procutils.which from test_vc.py to here, so it can
1650 be used in other places too (specifically tryclient.py)
1652 2006-04-23 Brian Warner <warner@lothar.com>
1654 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1655 bare buildbotURL/projectName line with a proper DIV, along with a
1656 CSS class of "title", from Stefan Seefeld (SF#1461675).
1657 (WaterfallStatusResource.body0): remove the redundant 'table'
1658 class from the table
1659 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1660 to the top-row TR, and class="Activity" to the second-row TR,
1661 rather than putting them in the individual TD nodes.
1663 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1664 'got_revision' build property for all VC systems that implement
1665 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1667 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1668 to determine which revision we actually obtained
1669 (CVS.parseGotRevision): implement this for CVS, which just means
1670 to grab a timestamp. Not ideal, and it depends upon the buildslave
1671 having a clock that is reasonably well syncronized with the server,
1672 but it's better than nothing.
1673 (SVN.parseGotRevision): implement it for SVN, which is accurate
1674 (Darcs.parseGotRevision): same
1675 (Arch.parseGotRevision): same
1676 (Bazaar.parseGotRevision): same
1677 (Mercurial.parseGotRevision): same
1679 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1680 keep a record of all non-stdout/stderr/header/rc status updates,
1681 for the benefit of RemoteCommands that send other useful things,
1683 (Source.commandComplete): put any 'got_revision' status values
1684 into a build property of the same name
1687 * buildbot/process/step_twisted.py (Trial): update to deal with
1688 new ShellCommand refactoring
1690 * docs/buildbot.texinfo (Build Properties): document new feature
1691 that allows BuildSteps to get/set Build-wide properties like which
1692 revision was requested and/or checked out.
1694 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1695 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1696 it. Note that this bumps the persistenceVersion of the saved Build
1697 object, so add the necessary upgrade-old-version logic to include
1698 an empty properties dict.
1700 * buildbot/process/base.py (Build.setProperty): implement it
1701 (Build.getProperty): same
1702 (Build.startBuild): change build startup to set 'branch',
1703 'revision', and 'slavename' properties at the right time
1705 * buildbot/process/step.py (BuildStep.__init__): change setup to
1706 require 'build' argument in a better way
1707 (LoggingBuildStep): split ShellCommand into two pieces, for better
1708 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1709 a single RemoteCommand that sends stdout/stderr status text. It
1710 also provides the usual commandComplete / createSummary /
1711 evaluateCommand / getText methods to be overridden...
1712 (ShellCommand): .. whereas ShellCommand is specifically for
1713 running RemoteShellCommands. Other shell-like BuildSteps (like
1714 Source) can inherit from LoggingBuildStep instead of ShellCommand
1715 (WithProperties): marker class to do build-property interpolation
1716 (Source): inherit from LoggingBuildStep instead of ShellCommand
1719 * buildbot/test/test_properties.py: test new functionality
1721 2006-04-21 Brian Warner <warner@lothar.com>
1723 * buildbot/test/test_vc.py: rename testBranch to
1724 testCheckoutBranch to keep the tests in about the right
1727 2006-04-18 Brian Warner <warner@lothar.com>
1729 * docs/buildbot.texinfo (PBListener): improve cross-references
1730 between PBListener and 'buildbot statusgui', thanks to John Pye
1733 2006-04-17 Brian Warner <warner@lothar.com>
1735 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1736 running under Twisted-1.3.0, otherwise skipped tests are reported
1739 * all: use isinstance() instead of 'type(x) is foo', suggested by
1742 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1743 oops, fix a brain-fade from the other week, when making the
1744 addStep changes. I changed all the __init__ upcalls to use the
1745 wrong superclass name.
1746 (FullTwistedBuildFactory.__init__): same
1747 (TwistedDebsBuildFactory.__init__): same
1748 (TwistedReactorsBuildFactory.__init__): same
1749 (TwistedBuild.isFileImportant): use .startswith for clarity,
1750 thanks to Neal Norwitz for the suggestions.
1752 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1753 changes, then deliver them over PB to a remote buildmaster.
1755 * contrib/svnpoller.py: added script by John Pye to poll a remote
1756 SVN repository (by running 'svn log') from a cronjob, and run
1757 'buildbot sendchange' to deliver the changes to a remote
1759 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1760 modification of svnpoller.py), same purpose, but this one loops
1761 internally (rather than expecting to run from a cronjob) and works
1763 * contrib/README.txt: same
1765 2006-04-11 Brian Warner <warner@lothar.com>
1767 * all: fix a number of incorrect names and missing imports, thanks
1768 to Anthony Baxter for the patch.
1769 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1770 remove unused buggy method.
1771 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1772 comes from shutil, not "shutils"
1773 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1774 (Arch.checkSlaveVersion): same
1775 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1777 * buildbot/process/step_twisted2.py: add some missing imports
1778 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1779 this code used to live in twisted.internet.defer
1781 2006-04-10 Brian Warner <warner@lothar.com>
1783 * buildbot/process/step.py (Mercurial): add Mercurial support
1784 * buildbot/slave/commands.py (Mercurial): same
1785 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1786 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1787 not yet tested, but 'try' support *is* covered
1788 * docs/buildbot.texinfo (Mercurial): document it
1790 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1791 some debugging messages (turned off)
1792 * buildbot/test/test_vc.py: improve debug messages
1794 2006-04-07 Brian Warner <warner@lothar.com>
1796 * buildbot/test/test_vc.py (which): define our own which() in case
1797 we can't import twisted.python.procutils, because procutils doesn't
1798 exist in Twisted-1.3
1800 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1801 of SlaveLocks for performance tests
1803 * docs/examples/twisted_master.cfg: update to match current usage
1805 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1806 password, p4 binary, pollinterval, maximum history to check.
1807 Patch from an anonymous sf.net contributor, SF#1219384.
1808 * buildbot/process/step.py (P4Sync.__init__): add username,
1809 password, and client arguments.
1810 * buildbot/slave/commands.py (P4Sync): same
1812 2006-04-05 Brian Warner <warner@lothar.com>
1814 * buildbot/process/factory.py (BuildFactory.addStep): new method
1815 to add steps to a BuildFactory. Use it instead of f.steps.append,
1816 and you can probably avoid using the s() convenience function.
1817 Patch from Neal Norwitz, sf.net #1412605.
1818 (other): update all factories to use addStep
1819 * buildbot/process/process_twisted.py: update all factories to use
1822 2006-04-03 Brian Warner <warner@lothar.com>
1824 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1825 work under windows too. Adapted from a patch by Niklaus Giger,
1826 addresses SF#1463399.
1828 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1829 spawned commands emit parseable results in english and not some
1830 other language. Patch from Niklaus Giger, SF#1463395.
1832 * README (INSTALLATION): discourage users from running unit tests on
1833 a "network drive", patch from Niklaus Giger, SF#1463394.
1835 2006-03-22 Brian Warner <warner@lothar.com>
1837 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1838 function to turn a repository-relative pathname into a (branch,
1839 branch-relative-filename) tuple. Change this function to handle
1840 the branch naming policy used by your Subversion repository.
1841 Thanks to AllMyData.com for sponsoring this work.
1843 2006-03-16 Brian Warner <warner@lothar.com>
1845 * buildbot/scripts/sample.cfg: add python-mode declaration for
1846 vim. Thanks to John Pye for the patch.
1848 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1849 command line, mention the importance of running 'crontab' as the
1850 buildmaster/buildslave user. Thanks to John Pye for the catch.
1852 2006-03-13 Brian Warner <warner@lothar.com>
1854 * buildbot/status/words.py (IRC): add an optional password=
1855 argument, which will be sent to Nickserv in an IDENTIFY message at
1856 login, to claim the nickname. freenode requires this before the
1857 bot can sent (or reply to) private messages. Thanks to Clement
1858 Stenac for the patch.
1859 * docs/buildbot.texinfo (IRC Bot): document it
1861 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1862 larger than chunkSize. Fixes SF#1349253.
1863 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1864 (Log.testConsumer): update to match new internal chunking behavior
1866 2006-03-12 Brian Warner <warner@lothar.com>
1868 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1870 * buildbot/test/test_maildir.py (MaildirTest): rename the
1871 'timeout' method, as it collides with trial's internals
1873 * buildbot/scripts/runner.py: add 'buildbot restart' command
1874 (stop): don't sys.exit() out of here, otherwise restart can't work
1875 * docs/buildbot.texinfo (Shutdown): document it
1877 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1878 * buildbot/status/html.py (Waterfall.__init__): same
1879 * buildbot/process/builder.py (Builder.startBuild): same
1880 * buildbot/process/base.py (BuildRequest): same
1881 * buildbot/sourcestamp.py (SourceStamp): same
1882 * buildbot/scheduler.py (Nightly): same
1884 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1886 * docs/buildbot.texinfo: same
1888 2006-02-17 Brian Warner <warner@lothar.com>
1890 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1891 * docs/buildbot.texinfo: set version number to match
1892 * NEWS: update for 0.7.2
1894 2006-02-16 Brian Warner <warner@lothar.com>
1896 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1898 2006-02-09 Brian Warner <warner@lothar.com>
1900 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1901 add text to explain per-build branch parameters
1902 * NEWS: mention --umask
1904 2006-02-08 Brian Warner <warner@lothar.com>
1906 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1908 (SlaveOptions.optParameters): add --umask, to make it possible to
1909 make buildslave-generated files (including build products) be
1912 * buildbot/slave/bot.py (BuildSlave.startService): same
1914 2006-01-23 Brian Warner <warner@lothar.com>
1916 * buildbot/status/builder.py: urllib.quote() all URLs that include
1917 Builder names, so that builders can include characters like '/'
1918 and ' ' without completely breaking the resulting HTML. Thanks to
1919 Kevin Turner for the patch.
1920 * buildbot/status/html.py: same
1921 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1923 * NEWS: update in preparation for upcoming release
1925 2006-01-18 Brian Warner <warner@lothar.com>
1927 * docs/examples/twisted_master.cfg: update to match the Twisted
1928 buildbot: remove python2.2, switch to exarkun's buildslaves,
1929 disable the .deb builder until we figure out how to build twisted
1930 .debs from SVN, add some ktrace debugging to the OS-X build
1931 process and remove the qt build, remove threadless builders,
1932 change freebsd builder to use landonf's buildslave.
1934 2006-01-12 Brian Warner <warner@lothar.com>
1936 * buildbot/master.py (Manhole.__init__): let port= be a strports
1937 specification string, but handle a regular int for backwards
1938 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1939 used in master.cfg to limit connections to just the local host.
1940 (BuildMaster.loadConfig): same for c['slavePortnum']
1941 * buildbot/scheduler.py (Try_Userpass.__init__): same
1942 * buildbot/status/client.py (PBListener.__init__): same
1943 * buildbot/status/html.py (Waterfall.__init__): same, for both
1944 http_port and distrib_port. Include backwards-compatibility checks
1945 so distrib_port can be a filename string and still mean unix:/foo
1946 * docs/buildbot.texinfo (Setting the slaveport): document it
1947 (Debug options): same
1948 (HTML Waterfall): same
1951 * buildbot/test/test_config.py (ConfigTest): test it
1953 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1954 slaveport's disownServiceParent deferred to fire before opening
1955 the new one. Fixes an annoying bug in the unit tests.
1957 2006-01-03 Brian Warner <warner@lothar.com>
1959 * buildbot/master.py (BuildMaster): remove the .schedulers
1960 attribute, replacing it with an allSchedulers() method that looks
1961 for all IService children that implement IScheduler. Having only
1962 one parent/child relationship means fewer opportunities for bugs.
1963 (BuildMaster.allSchedulers): new method
1964 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1965 also fix ugly bug that caused any config-file reload to
1966 half-forget about the earlier Schedulers, causing an exception
1967 when a Change arrived and was handed to a half-connected
1968 Scheduler. The exception was in scheduler.py line 54ish:
1969 self.parent.submitBuildSet(bs)
1970 exceptions.AttributeError: 'NoneType' object has no attribute
1972 (BuildMaster.addChange): update to use allSchedulers()
1974 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1975 to work properly with twisted-1.3.0, where you must explicitly
1976 include the __implements__ from parent classes
1977 (BaseScheduler.__repr__): make it easier to distinguish distinct
1979 (BaseUpstreamScheduler.__implements__): same
1981 * buildbot/status/builder.py (Status.getSchedulers): update to
1983 * buildbot/test/test_run.py (Run.testMaster): same
1984 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1985 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1986 make sure Scheduler instances are left alone when an identical
1987 config file is reloaded
1988 (ConfigElements.testSchedulers): make sure Schedulers are properly
1991 * Makefile (TRIALARGS): my local default Twisted version is now
1992 2.1.0, update the trial arguments accordingly
1994 2005-12-22 Brian Warner <warner@lothar.com>
1996 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1999 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2000 addChange in the parent class, although I suspect this should be
2001 fixed better in the future.
2003 2005-11-26 Brian Warner <warner@lothar.com>
2005 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2006 explode when branch==None, thanks to Kevin Turner for the catch
2007 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2010 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2012 * docs/buildbot.texinfo: same
2014 2005-11-26 Brian Warner <warner@lothar.com>
2016 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2017 * docs/buildbot.texinfo: set version number to match
2019 2005-11-26 Brian Warner <warner@lothar.com>
2021 * NEWS: update for 0.7.1
2023 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2024 sure that unsubscribe works even if we never sent an ETA update.
2025 Also, don't explode on duplicate unsubscribe.
2026 (BuildStepStatus.addLog): make the convenience "return self"-added
2027 watcher automatically unsubscribe when the Step finishes.
2028 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2029 (BuildStatus.stepStarted): same auto-unsubscribe
2030 (BuilderStatus.buildStarted): same auto-unsubscribe
2032 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2034 (IStatusReceiver.stepStarted): same
2035 (IStatusReceiver.logStarted): same
2037 * buildbot/test/test_run.py (Status): move the Status test..
2038 * buildbot/test/test_status.py (Subscription): .. to here
2040 2005-11-25 Brian Warner <warner@lothar.com>
2042 * NEWS: more updates
2044 * buildbot/locks.py: fix the problem in which loading a master.cfg
2045 file that changes some Builders (but not all of them) can result
2046 in having multiple copies of the same Lock. Now, the real Locks
2047 are kept in a table inside the BotMaster, and the Builders/Steps
2048 use "LockIDs", which are still instances of MasterLock and
2049 SlaveLock. The real Locks are instances of the new RealMasterLock
2050 and RealSlaveLock classes.
2051 * buildbot/master.py (BotMaster.getLockByID): new method to
2052 convert LockIDs into real Locks.
2053 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2054 into real Locks before building
2055 * buildbot/process/step.py (BuildStep.startStep): same
2056 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2057 exercises the problem
2060 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2061 what Schedulers are available
2063 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2064 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2065 'cron'-style build scheduling at certain times of day, week,
2067 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2069 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2070 handling: treat self.fileIsImportant more as an attribute that
2071 contains a callable than as a method. If the attribute is None,
2072 don't call it and assume all filenames are important. It is still
2073 possible to provide a fileIsImportant method in a subclass,
2075 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2077 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2078 test using AnyBranchScheduler with fileIsImportant=None
2080 2005-11-24 Brian Warner <warner@lothar.com>
2082 * buildbot/test/test_config.py (StartService): don't claim a fixed
2083 port number, instead set slavePort=0 on the first pass, figure out
2084 what port was allocated, then switch to a config file that uses
2087 * buildbot/master.py (BuildMaster.loadConfig): close the old
2088 slaveport before opening the new one, because unit tests might
2089 replace slavePort=0 with the same allocated portnumber, and if we
2090 don't wait for the old port to close first, we get a "port already
2091 in use" error. There is a tiny race condition here, but the only
2092 threat is from other programs that bind (statically) to the same
2093 port number we happened to be allocated, and only if those
2094 programs use SO_REUSEADDR, and only if they get control in between
2097 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2099 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2100 deleted ChangeSources before adding any new ones
2101 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2102 compare_attrs, to make sure that a config-file reload does not
2103 unnecessarily replace an unmodified ChangeSource instance
2104 * buildbot/test/test_config.py (ConfigTest.testSources): update
2106 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2107 mean "don't build anything", and add a warning if it gets used
2108 because it isn't actually useful.
2110 * contrib/svn_buildbot.py: update example usage to match the port
2111 number that gets used by the PBChangeSource
2112 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2114 2005-11-22 Brian Warner <warner@lothar.com>
2116 * NEWS: start collecting items for next release
2118 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2119 revisions are strings
2120 (P4Sync.computeSourceRevision): same
2122 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2123 to the Buildbot's overall status page
2124 (StatusResourceBuilder.body): same
2126 2005-11-15 Brian Warner <warner@lothar.com>
2128 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2129 config-file loading, specifically to make sure old StatusTargets
2130 are finished shutting down before new ones start up (thus
2131 resolving a bug in which changing the Waterfall object would fail
2132 because both new and old instances were claiming the same
2133 listening port). Also load new Schedulers after all the new
2134 Builders are set up, in case they fire off a new build right away.
2135 * buildbot/test/test_config.py (StartService): test it
2137 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2138 the branch name to the mail body
2140 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2141 Without it, a config-file reload fails to update an existing
2143 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2144 username/passwd to compare_attrs, for the same reason
2145 * buildbot/status/html.py (Waterfall): add favicon to
2146 compare_attrs, same reason
2148 2005-11-05 Brian Warner <warner@lothar.com>
2150 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2151 baserev before stuffing it in the jobfile. This resolves problems
2152 under SVN (and probably Arch) where revisions are expressed as
2153 numbers. I'm inclined to use string-based revisions everywhere in
2154 the future, but this fix should be safe for now. Thanks to Steven
2155 Walter for the patch.
2157 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2158 binary mode when opening pickle files, to make windows work
2159 better. Thanks to Dobes Vandermeer for the catch.
2160 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2161 (BuilderStatus.getBuildByNumber): same
2162 (Status.builderAdded): same
2163 * buildbot/master.py (BuildMaster.loadChanges): same
2165 * buildbot/util.py (Swappable): delete unused leftover code
2167 * buildbot/process/step.py (SVN): when building on a non-default
2168 branch, add the word "[branch]" to the VC step's description, so
2169 it is obvious that we're not building the usual stuff. Likewise,
2170 when we are building a specific revision, add the text "rNNN" to
2171 indicate what that revision number is. Thanks to Brad Hards and
2172 Nathaniel Smith for the suggestion.
2173 (Darcs.startVC): same
2174 (Arch.startVC): same
2175 (Bazaar.startVC): same
2177 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2178 typo, caught by Mark Dillavou, closes SF#1216636.
2180 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2181 about a test to add some day
2183 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2184 the 'full-2.3' build, and the 'reactors' build is now run under
2185 python-2.4 because the buildslave no longer has gtk/etc bindings
2186 for earlier versions.
2188 2005-11-03 Brian Warner <warner@lothar.com>
2190 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2191 method, takes an IBuildStatus and rebuilds it. It might make more
2192 sense to add this to IBuildControl instead, but that instance goes
2193 away completely once the build has finished, and resubmitting
2194 builds can take place weeks later.
2195 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2196 * buildbot/status/html.py (StatusResourceBuild): also stash an
2197 IBuilderControl so we can use resubmitBuild.
2198 (StatusResourceBuild.body): render "resubmit" button if we can.
2199 Also add hrefs for each BuildStep
2200 (StatusResourceBuild.rebuild): add action for "resubmit" button
2201 (StatusResourceBuilder.getChild): give it an IBuilderControl
2203 * buildbot/status/builder.py (Status.getURLForThing): change the
2204 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2205 that live as targets of buttons like "stop" and "rebuild" can't
2207 * buildbot/status/builder.py (Status.getURLForThing): same
2208 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2209 (StepBox.getBox): same
2210 * buildbot/test/test_web.py (GetURL): same
2213 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2214 exclusivity checks after Source.__init__ upcall, so misspelled
2215 arguments will be reported more usefully
2216 (Darcs.__init__): same
2218 2005-10-29 Brian Warner <warner@lothar.com>
2220 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2221 builder. Move the Try scheduler off to a separate port.
2223 2005-10-27 Brian Warner <warner@lothar.com>
2225 * buildbot/clients/gtkPanes.py
2226 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2227 to cause the app to crash, now they don't.
2229 * buildbot/clients/debug.py: display the buildmaster's location
2230 in the window's title bar
2232 2005-10-26 Brian Warner <warner@lothar.com>
2234 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2235 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2236 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2238 * buildbot/status/html.py (td): put a single non-breaking space
2239 inside otherwise empty <td> elements, as a workaround for buggy
2240 browsers which would optimize them away (along with any associated
2241 styles, like the kind that create the waterfall grid borders).
2242 Patch from Frerich Raabe.
2244 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2245 argv-list as an argument, defaulting to ["-to"], which is
2246 appropriate for the Trial that comes with Twisted-2.1.0 and
2247 earlier. The Trial in current Twisted SVN wants
2248 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2249 defaults to an empty list.
2250 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2251 match it, now that trialMode= is a list instead of a single string
2253 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2255 * docs/buildbot.texinfo: same
2257 2005-10-24 Brian Warner <warner@lothar.com>
2259 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2260 * docs/buildbot.texinfo: set version number to match
2262 2005-10-24 Brian Warner <warner@lothar.com>
2264 * README: update for 0.7.0
2266 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2268 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2269 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2270 send the branch= argument unless the user really provided one, to
2271 retain compatibility with older buildmasters that don't accept
2273 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2276 * docs/buildbot.texinfo: update lots of stuff
2278 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2279 to the 'buildbot sendchange' command
2280 * buildbot/clients/sendchange.py (Sender.send): same
2281 * buildbot/changes/pb.py (ChangePerspective): same
2282 * buildbot/test/test_changes.py (Sender.testSender): test it
2284 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2285 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2286 for consistency with other BuildStep arguments that use camelCase.
2287 Well, at least more of them use camelCase (like flunkOnWarnings)
2288 than don't.. I wish I'd picked one style and stuck with it
2289 earlier. Annoying, but it's best done before the release, since
2290 these arguments didn't exist at all in 0.6.6 .
2292 * buildbot/test/test_vc.py (SVN.testCheckout): same
2293 (Darcs.testPatch): same
2294 * docs/buildbot.texinfo (SVN): document the change
2295 (Darcs): same, add some build-on-branch docs
2296 * docs/examples/twisted_master.cfg: match change
2298 * buildbot/process/step.py (BuildStep): rename
2299 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2300 how it is normally used.
2301 * buildbot/test/test_steps.py (Version.checkCompare): same
2303 * buildbot/process/step.py (CVS.startVC): refuse to build
2304 update/copy -style builds on a non-default branch with an old
2305 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2306 concern is that it will do a VC 'update' in an existing tree when
2307 it is supposed to be switching branches (and therefore clobbering
2308 the tree to do a full checkout), thus building the wrong source.
2309 This used to be a warning, but I think the confusion it is likely
2310 to cause warrants making it an error.
2311 (SVN.startVC): same, also make mode=export on old slaves an error
2312 (Darcs.startVC): same
2313 (Git.startVC): improve error message for non-Git-enabled slaves
2314 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2315 specific revision is built on a slave that doesn't pay attention
2316 to args['revision'], because for slowly-changing trees it will
2317 probably do the right thing, and because we have no way to tell
2318 whether we're asking it to build the most recent version or not.
2319 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2321 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2322 that 'master' is in host:portnum format, to catch errors sooner
2324 2005-10-23 Brian Warner <warner@lothar.com>
2326 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2327 when creating the list of warning messages, include the line
2328 immediately after each WARNING: line, since that's usually where
2329 the file and line number wind up.
2331 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2336 2005-10-22 Brian Warner <warner@lothar.com>
2338 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2339 patch from Brad Hards
2340 * buildbot/status/classic.css: same
2341 * buildbot/test/test_web.py (Waterfall): match changes
2343 * buildbot/test/test_steps.py (BuildStep.setUp): set
2344 nextBuildNumber so the test passes
2345 * buildbot/test/test_status.py (MyBuilder): same
2347 * buildbot/status/html.py (StatusResourceBuild.body): revision
2348 might be numeric, so stringify it before html-escapifying it
2349 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2350 timer for the upcoming build
2351 * buildbot/status/classic.css: add background-color attributes for
2352 offline/waiting/building classes
2354 * buildbot/status/builder.py (BuildStatus): derive from
2355 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2356 the default (i.e. unknown) .slavename to "???" instead of None,
2357 since even unknown slavenames need to be printed eventually.
2358 (BuilderStatus): also derive from styles.Versioned . More
2359 importantly, determine .nextBuildNumber at creation/unpickling
2360 time by scanning the directory of saved BuildStatus instances and
2361 choosing one larger than the highest-numbered one found. This
2362 should fix the problem where random errors during upgrades cause
2363 the buildbot to forget about earlier builds. .nextBuildNumber is
2364 no longer stored in the pickle.
2365 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2366 at least log the error. Also call Builder.determineNextBuildNumber
2367 once the basedir is set.
2369 * buildbot/master.py (BuildMaster.loadChanges): do
2370 styles.doUpgrade afterwards, in case I decide to make Changes
2371 derived from styles.Versioned some day and forget to make this
2375 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2376 when running under older pythons (<2.3) in which the shlex module
2377 doesn't have a 'split' function.
2379 * buildbot/process/step.py (ShellCommand.start): make
2380 errorMessages= be a list of strings to stuff in the log before the
2381 command actually starts. This makes it easier to flag multiple
2382 warning messages, e.g. when the Source steps have to deal with an
2384 (CVS.startVC): handle slaves that don't handle multiple branches
2385 by switching into 'clobber' mode
2386 (SVN.startVC): same. Also reject branches without base_url
2387 (Darcs.startVC): same. Also reject revision= in older slaves
2388 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2389 (Bazaar.startVC): same, and test for baz separately than for arch
2391 * buildbot/slave/commands.py (cvs_ver): document new features
2393 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2394 (BuildStep.slaveVersionNewEnough): more useful utility method
2395 * buildbot/test/test_steps.py (Version): start testing it
2397 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2398 the 'force' command requires python2.3, for the shlex.split method
2400 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2401 since we don't use it anymore. The Twisted buildbot uses a
2404 2005-10-21 Brian Warner <warner@lothar.com>
2406 * buildbot/process/process_twisted.py: rework all BuildFactory
2407 classes to take a 'source' step as an argument, instead of
2408 building up the SVN instance in the factory.
2409 * docs/examples/twisted_master.cfg: enable build-on-branch by
2410 providing a base_url and default_branch
2412 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2413 control over --branch and --revision, not that they are always
2415 * buildbot/status/html.py (StatusResourceBuilder.force): same
2416 (StatusResourceBuild.body): display SourceStamp components
2418 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2419 IRC 'force' command, so it can be shared with an eventual
2420 command-line-tool 'buildbot force' mode.
2421 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2423 2005-10-20 Brian Warner <warner@lothar.com>
2425 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2427 * docs/examples/twisted_master.cfg: update to use Schedulers
2429 * buildbot/scripts/sample.cfg: update with Schedulers
2431 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2432 method specifically for use by HTML "force build" button and the
2433 IRC "force" command. Raises an immediate error if there are no
2435 (IBuilderControl.requestBuild): make this just submit a build, not
2436 try to check for existing slaves or set up any when-finished
2437 Deferreds or anything.
2438 * buildbot/process/builder.py (BuilderControl): same
2439 * buildbot/status/html.py (StatusResourceBuilder.force): same
2440 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2441 * buildbot/test/test_slaves.py: same
2442 * buildbot/test/test_web.py: same
2444 2005-10-19 Brian Warner <warner@lothar.com>
2446 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2447 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2449 2005-10-18 Brian Warner <warner@lothar.com>
2451 * buildbot/status/html.py: provide 'status' argument to most
2452 StatusResourceFOO objects
2453 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2454 and Logfiles" section to make the Build page into a more-or-less
2455 comprehensive source of status information about the build
2457 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2458 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2460 2005-10-17 Brian Warner <warner@lothar.com>
2462 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2463 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2464 out what to do about other projects: the correct options for
2465 recent Twisteds will not work for older ones.
2467 2005-10-15 Brian Warner <warner@lothar.com>
2469 * buildbot/status/builder.py (Status.getURLForThing): add method
2470 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2471 use this in email/IRC status clients to make them more useful, by
2472 providing the end user with hints on where to learn more about the
2473 object being reported on.
2474 * buildbot/test/test_web.py (GetURL): tests for it
2476 2005-10-14 Brian Warner <warner@lothar.com>
2478 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2479 fix bug resulting from deferredResult changes
2481 2005-10-13 Brian Warner <warner@lothar.com>
2483 * buildbot/test/test_changes.py: remove use of deferredResult
2484 * buildbot/test/test_config.py: same
2485 * buildbot/test/test_control.py: same
2486 * buildbot/test/test_status.py: same
2487 * buildbot/test/test_vc.py: this is the only remaining use, since
2488 it gets used at module level. This needs to be replaced by some
2489 sort of class-level run-once routine.
2491 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2493 * lots: implement multiple slaves per Builder, which means multiple
2494 current builds per Builder. Some highlights:
2495 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2496 of (state,currentBuilds) instead of (state,currentBuild)
2497 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2498 (IBuildStatus.getSlavename): new method, so you can tell which
2499 slave got used. This only gets set when the build completes.
2500 (IBuildRequestStatus.getBuilds): new method
2502 * buildbot/process/builder.py (SlaveBuilder): add a .state
2503 attribute to track things like ATTACHING and IDLE and BUILDING,
2505 (Builder): .. the .slaves attribute here, which has been turned
2506 into a simple list of available slaves. Added a separate
2507 attaching_slaves list to track ones that are not yet ready for
2509 (Builder.fireTestEvent): put off the test-event callback for a
2510 reactor turn, to make tests a bit more consistent.
2511 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2512 ping fails due to an exception. This needs work, I'm worried that
2513 a code error could lead to a constantly re-connecting slave.
2514 Especially since I'm trying to move to a distinct remote_ping
2515 method, separate from the remote_print that we currently use.
2516 (BuilderControl.requestBuild): return a convenience Deferred that
2517 provides an IBuildStatus when the build finishes.
2518 (BuilderControl.ping): ping all connected slaves, only return True
2519 if they all respond.
2521 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2522 reconnect when we shut down.
2524 * buildbot/status/builder.py: implement new methods, convert
2525 one-build-at-a-time methods to handle multiple builds
2526 * buildbot/status/*.py: do the same in all default status targets
2527 * buildbot/status/html.py: report the build's slavename in the
2528 per-Build page, report all buildslaves on the per-Builder page
2530 * buildbot/test/test_run.py: update/create tests
2531 * buildbot/test/test_slaves.py: same
2532 * buildbot/test/test_scheduler.py: remove stale test
2534 * docs/buildbot.texinfo: document the new builder-specification
2535 'slavenames' parameter
2537 2005-10-12 Brian Warner <warner@lothar.com>
2539 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2540 report failure correctly, causing Dependent builds to run when
2541 they shouldn't have.
2542 * buildbot/status/builder.py (BuildSetStatus): same
2543 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2544 (Set.testSuccess): test the both-pass case too
2545 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2546 fix this test: it was ending too early, masking the failure before
2547 (Logger): specialized StatusReceiver to make sure the dependent
2548 builds aren't even started, much less completed.
2550 2005-10-07 Brian Warner <warner@lothar.com>
2552 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2553 bot.SlaveBuilder being disowned in the middle of a build
2555 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2556 this inherit from StatusReceiver. Also upcall in __init__. This
2557 fixes the embarrasing crash when the new buildSetSubmitted method
2558 is invoked and Waterfall/etc don't implement their own.
2559 * buildbot/test/test_run.py: add a TODO note about a test to catch
2560 just this sort of thing.
2562 * buildbot/process/builder.py (Builder.attached): remove the
2563 already-attached warning, this situation is normal. Add some
2564 comments explaining it.
2566 2005-10-02 Brian Warner <warner@lothar.com>
2568 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2569 OverflowError when setting up dnotify, because some 64-bit systems
2570 have problems with signed-vs-unsigned constants and trip up on the
2571 DN_MULTISHOT flag. Patch from Brad Hards.
2573 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2575 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2576 progressMetrics, description, descriptionDone to the 'parms' list,
2577 and make use the 'parms' list from the implementation class
2578 instead of only BuildStep to initialize the parameters. This
2579 allows buildbot.process.factory.s() to initialize all the parms,
2580 not just those defined in directly by BuildStep.
2582 2005-09-03 Brian Warner <warner@lothar.com>
2584 * NEWS: start adding items for the next release
2586 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2587 python2.2 tests, change 'Quick' builder to only use python2.3
2589 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2591 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2592 the "Ping Builder" button if the build control is available; the
2593 user sees an exception otherwise
2595 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2597 2005-09-01 Brian Warner <warner@lothar.com>
2599 * buildbot/interfaces.py (IBuilderStatus.getState): update
2600 signature, point out that 'build' can be None
2601 (IBuildStatus.getETA): point out ETA can be none
2603 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2605 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2607 2005-08-31 Brian Warner <warner@lothar.com>
2609 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2610 update to match correct signature: removed 'eta' argument
2611 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2613 2005-08-30 Brian Warner <warner@lothar.com>
2615 * buildbot/status/builder.py (LogFile): remove the assertion that
2616 blows up when you try to overwrite an existing logfile, instead
2617 just emit a warning. This case gets hit when the buildmaster is
2618 killed and doesn't get a chance to write out the serialized
2619 BuilderStatus object, so the .nextBuildNumber attribute gets out
2622 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2623 the 'buildbot sendchange' arguments, for the Darcs context file
2624 * docs/buildbot.texinfo (sendchange): document it
2626 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2627 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2628 (IStatus.getSchedulers): new method
2629 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2630 (Status.getSchedulers): implement
2631 * buildbot/process/builder.py (Builder): maintain
2632 BuilderStatus.pendingBuilds
2633 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2634 (TryBase.addChange): Try schedulers should ignore Changes
2636 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2637 for 'try' on CVS/SVN
2638 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2640 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2641 report status properly.
2642 (Try.createJob): implement unique buildset IDs
2644 * buildbot/status/client.py (StatusClientPerspective): add a
2645 perspective_getBuildSets method for the benefit of jobdir-style
2647 * docs/buildbot.texinfo (try): more docs
2648 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2651 2005-08-18 Brian Warner <warner@lothar.com>
2653 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2654 actually work. It's functional but still kind of clunky. Also, it
2655 only works with the pb-style.. needs to be made to work with the
2658 * buildbot/status/client.py (RemoteBuildSet): new class
2659 (RemoteBuildRequest): same
2660 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2661 object, not the internal BuildStatus object.
2662 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2663 outside of the usual buildStarted() return value.
2664 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2666 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2667 (Try_Userpass_Perspective.perspective_try): return a remotely
2668 usable BuildSetStatus object
2670 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2671 isStarted()/waitUntilStarted()
2673 2005-08-16 Brian Warner <warner@lothar.com>
2675 * buildbot/status/builder.py: implement IBuildSetStatus and
2676 IBuildRequestStatus, wire them into place.
2677 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2678 methods into the BuildSetStatus object.
2679 * buildbot/interfaces.py: same
2680 (IStatus.getBuildSets): new method to get pending BuildSets
2681 (IStatusReceiver.buildsetSubmitted): new method which hears about
2683 * buildbot/master.py (BuildMaster.submitBuildSet): same
2684 * buildbot/process/base.py (BuildRequest): same, replace
2685 waitUntilStarted with subscribe/unsubscribe
2686 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2687 subscribe instead of waitUntilStarted
2688 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2690 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2692 * buildbot/test/test_buildreq.py: update for new code
2693 * buildbot/test/test_control.py (Force.testRequest): same
2696 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2697 for Darcs to not use the tempfile module, so it works under
2698 python-2.2 too. We really didn't need the full cleverness of that
2699 module, since the slave has exclusive control of its own builddir.
2701 2005-08-15 Brian Warner <warner@lothar.com>
2703 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2704 for CVS trees. It doesn't work for non-trunk branches,
2706 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2709 * Makefile: make it easier to test against python2.2
2711 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2712 tearDown2, so things like Arch can unregister archives as they're
2713 shutting down. The previous subclass-override-tearDown technique
2714 resulted in a nested maybeWait() and test failures under
2717 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2718 where we can (Arch), add a branch= argument to set the branch used
2720 (BazExtractor): extract the branch too
2721 (TlaExtractor): same
2722 * buildbot/scripts/runner.py (TryOptions): add --branch
2723 * docs/buildbot.texinfo (try): document --branch/try_branch
2725 * buildbot/slave/commands.py (Darcs): implement get-revision for
2726 Darcs, so that 'try' will work. This requires the tempfile module
2729 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2730 of revisions, branches, and 'try' in the process.
2732 2005-08-11 Brian Warner <warner@lothar.com>
2734 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2735 this, it got broken at some point in the last few releases
2736 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2737 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2738 specifically the removal of ETA information from the tuple
2740 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2743 * docs/buildbot.texinfo (try): document both --builder and
2744 'try_builders' in .buildbot/options
2745 * buildbot/scripts/runner.py (TryOptions): add --builder,
2746 accumulate the values into opts['builders']
2747 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2748 * buildbot/test/test_runner.py (Try): add some quick tests to make
2749 sure 'buildbot try --options' and .buildbot/options get parsed
2750 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2751 use --builder control
2753 * docs/buildbot.texinfo (try): add --port argument to PB style
2755 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2756 actual SourceStamp. Still need to extract a branch name, somehow.
2757 (Try): finish implementing the try client side, still need a UI
2758 for specifying which builders to use
2759 (Try.getopt): factor our options/config-file reading
2760 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2762 * buildbot/test/test_vc.py: match SourceStampExtractor change
2764 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2765 causes the twisted log to be sent to stderr
2767 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2769 2005-08-10 Brian Warner <warner@lothar.com>
2771 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2772 style is 90% done, still missing status reporting or waiting for
2773 the buildsets to finish, and it is completely untested.
2775 * buildbot/trybuild.py: delete file, move contents to ..
2776 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2777 * buildbot/test/test_vc.py: match the move
2779 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2780 of the TryScheduler, no buildsetID or status-tracking support yet
2781 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2783 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2784 possible to set the basedir after __init__ time, so it is easier
2785 to use as a Service-child of the BuildMaster instance
2787 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2788 that delivers messages to its Service parent instead of requiring
2789 a subclass to be useful. This turns out to be much easier to build
2792 * buildbot/scripts/tryclient.py (createJob): utility code to
2793 create jobfiles, will eventually be used by 'buildbot try'
2795 2005-08-08 Brian Warner <warner@lothar.com>
2797 * docs/buildbot.texinfo (try): add docs on the
2798 as-yet-unimplemented Try scheduler
2800 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2801 * buildbot/test/test_scheduler.py: .. here
2802 (Scheduling.testTryJobdir): add placeholder test for 'try'
2804 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2805 addEntry merging (>=chunkSize) behavior
2806 (Log.testConsumer): update to handle new callLater(0) behavior
2808 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2809 both the MAX_LENGTH bugfix and the resumeProducing hang.
2811 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2812 put off the actual resumeProducing for a moment with
2813 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2814 causes large logfiles to hang midway through.
2816 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2817 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2818 and to improve memory usage when streaming the file out to a web
2820 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2821 make this work cleanly
2823 2005-08-03 Brian Warner <warner@lothar.com>
2825 * buildbot/trybuild.py: new file for 'try' utilities
2826 (getSourceStamp): run in a tree, find out the baserev+patch
2827 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2828 implemented for SVN and Darcs, still working on Arch. I don't know
2829 how to make CVS work yet.
2831 * docs/buildbot.texinfo: document the 'buildbot' command-line
2832 tool, including the not-yet-implemented 'try' feature, and the
2833 in-flux .buildbot/ options directory.
2835 2005-07-20 Brian Warner <warner@lothar.com>
2837 * buildbot/locks.py: added temporary id() numbers to Lock
2838 descriptions, to track down a not-really-sharing-the-Lock bug
2840 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2842 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2843 needed for python2.2 compatibility
2844 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2845 are from the __future__
2847 2005-07-19 Brian Warner <warner@lothar.com>
2849 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2850 message when schedulers use unknown builders
2852 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2853 SlaveLock('name') and MasterLock('name') are distinct
2855 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2856 c['schedulers'] in such a way that we can actually accept
2858 * buildbot/test/test_config.py: check it
2860 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2861 utility method to *all* the Schedulers
2862 (Periodic.listBuilderNames): same
2864 * docs/buildbot.texinfo (Interlocks): update chapter to match
2867 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2868 to make sure that c['sources'], c['schedulers'], and c['status']
2869 are all lists of the appropriate objects, and that the Schedulers
2870 all point to real Builders
2871 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2872 'listBuilderNames' utility method to support this
2873 * buildbot/scheduler.py: implement the utility method
2874 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2876 * docs/buildbot.texinfo: add some @cindex entries
2878 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2879 if it wasn't already set: most tla commands will fail unless one
2881 (Arch.createRepository): and disable bazaar's revision cache, since
2882 they cause test failures (the multiple repositories we create all
2883 interfere with each other through the cache)
2885 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2886 bring it properly up to date with twisted-2.0 test guidelines
2888 * buildbot/master.py (BuildMaster): remove references to old
2889 'interlock' module, this caused a bunch of post-merge test
2891 * buildbot/test/test_config.py: same
2892 * buildbot/process/base.py (Build): same
2894 * buildbot/test/test_slaves.py: stubs for new test case
2896 * buildbot/scheduler.py: add test-case-name tag
2897 * buildbot/test/test_buildreq.py: same
2899 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2900 unnecessary init code
2901 (Bot.remote_setBuilderList): match it
2903 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2905 * buildbot/changes/mail.py (parseSyncmail): update comment
2907 * buildbot/test/test_slavecommand.py: disable Shell tests on
2908 platforms that don't suport IReactorProcess
2910 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2911 all places where we open logfiles. It causes OS-X to open the file
2912 in some weird mode that that prevents us from mixing reads and
2913 writes to the same filehandle, which we depend upon to implement
2914 _generateChunks properly. This change doesn't appear to break
2915 win32, on which "b" and "t" are treated differently but a missing
2916 flag seems to be interpreted as "t".
2918 2005-07-18 Brian Warner <warner@lothar.com>
2920 * buildbot/slave/commands.py (ShellCommand): overhaul
2921 error-handling code, to try and make timeout/interrupt work
2922 properly, and make win32 happier
2923 * buildbot/test/test_slavecommand.py: clean up, stop using
2924 reactor.iterate, add tests for timeout and interrupt
2925 * buildbot/test/sleep.py: utility for a new timeout test
2927 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2928 code from the local-usebranches branch
2930 2005-07-17 Brian Warner <warner@lothar.com>
2932 * buildbot/process/process_twisted.py
2933 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2934 minutes, to match the other twisted BuildFactories, and don't
2935 excuse failures in c/qt/win32 reactors any more.
2937 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2938 'freebsd' builders, since the buildslaves have been unavailable
2941 2005-07-13 Brian Warner <warner@lothar.com>
2943 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2944 build-on-branch feature
2946 * buildbot/process/step.py (Darcs.__init__): add base_url and
2947 default_branch arguments, just like SVN
2948 (Arch.__init__): note that the version= argument is really the
2951 * buildbot/slave/commands.py (SourceBase): keep track of the
2952 repository+branch that was used for the last checkout in
2953 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2954 match, we clobber the directory and perform a fresh checkout
2955 rather than trying to do an in-place update. This should protect
2956 us against trying to get to branch B by doing an update in a tree
2957 obtained from branch A.
2958 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2959 (SVN.setup): same, just the svnurl
2960 (Darcs.setup): same, just the repourl
2961 (Arch.setup): same, arch coordinates (url), version, and
2962 buildconfig. Also pull the buildconfig from the args dictionary,
2963 which we weren't doing before, so the build-config was effectively
2965 (Arch.sourcedirIsUpdateable): don't try to update when we're
2966 moving to a specific revision: arch can't go backwards, so it is
2967 safer to just clobber the tree and checkout a new one at the
2969 (Bazaar.setup): same sourcedata as Arch
2971 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2972 use maybeWait, to work with twisted-1.3.0 and twcompat
2973 (Dependencies.testRun_Pass): same
2975 * buildbot/test/test_vc.py: rearrange, cleanup
2977 * buildbot/twcompat.py: add defer.waitForDeferred and
2978 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2979 can work under twisted-1.3.0 .
2981 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2982 now created at setUp time. This increases the runtime of the test
2983 suite considerably (from 91 seconds to 151), but it removes the
2984 need for an offline tarball, which should solve a problem I've
2985 seen where the test host has a different version of svn than the
2986 tarball build host. The new code also validates that mode=update
2987 really picks up recent commits. This approach will also make it
2988 easier to test out branches, because the code which creates the VC
2989 branches is next to the code which uses them. It will also make it
2990 possible to test some change-notification hooks, by actually
2991 performing a VC commit and watching to see the ChangeSource get
2994 2005-07-12 Brian Warner <warner@lothar.com>
2996 * docs/buildbot.texinfo (SVN): add branches example
2997 * docs/Makefile (buildbot.ps): add target for postscript manual
2999 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3000 * buildbot/test/test_locks.py: same
3002 * buildbot/process/step.py (Darcs): comment about default branches
3004 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3005 c['interlocks'] in the config file, complain if it is present.
3006 Scan all locks in c['builders'] to make sure the Locks they use
3008 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3009 add some tests to check for non-uniquely-named Locks
3010 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3011 since the unique-Lock validation code requires it now
3013 * buildbot/locks.py: fix test-case-name
3015 * buildbot/interlock.py: remove old file
3017 2005-07-11 Brian Warner <warner@lothar.com>
3019 * buildbot/test/test_interlock.py: rename to..
3020 * buildbot/test/test_locks.py: .. something shorter
3022 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3023 versions (after 2.0.1) changed internet.TCPClient to shut down the
3024 connection in stopService. Change the code to handle this
3027 * buildbot/process/base.py (Build): handle whole-Build locks
3028 * buildbot/process/builder.py (Builder.compareToSetup): same
3029 * buildbot/test/test_interlock.py: make tests work
3031 * buildbot/process/step.py (BuildStep.startStep): complain if a
3032 Step tries to claim a lock that's owned by its own Build
3033 (BuildStep.releaseLocks): typo
3035 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3036 file reloads don't replace unchanged Builders
3038 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3039 rewrite to cover new Locks instead of old c['interlocks']
3040 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3044 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3045 start the master and connect the buildslave
3047 * buildbot/process/step.py (FailingDummy.done): finish with a
3048 FAILURE status rather than raising an exception
3050 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3051 stringify a BuildRequest.reason that is None
3053 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3055 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3056 allow scheduler.Dependent to work
3057 * buildbot/buildset.py (BuildSet): set .reason and .results
3059 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3060 slaves, to make the test stop hanging. It still fails, of course,
3061 because I haven't even started to implement Locks.
3063 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3065 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3066 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3067 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3068 (Dependent): new class for downstream build dependencies
3069 * buildbot/test/test_dependencies.py: tests (still failing)
3071 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3073 2005-07-07 Brian Warner <warner@lothar.com>
3075 * buildbot/test/runutils.py (RunMixin): factored this class out..
3076 * buildbot/test/test_run.py: .. from here
3077 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3078 added new buildbot.locks tests (which all hang right now)
3079 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3080 * buildbot/process/step.py: claim/release per-BuildStep locks
3082 * docs/Makefile: add 'buildbot.html' target
3084 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3085 interpreted as "HEAD", so that all VC steps can accept branch=None
3086 and have it mean the "default branch".
3088 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3090 2005-07-07 Brian Warner <warner@lothar.com>
3092 * docs/examples/twisted_master.cfg: update to match current usage
3094 * docs/buildbot.texinfo (System Architecture): comment out the
3095 image, it doesn't exist yet and just screws up the HTML manual.
3097 2005-07-05 Brian Warner <warner@lothar.com>
3099 * debian/.cvsignore: oops, missed one. Removing leftover file.
3101 2005-06-17 Brian Warner <warner@lothar.com>
3103 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3104 changed its output in 1.2.0, don't mistakenly think that the
3105 subversion we find isn't capable of supporting our tests.
3107 * debian/*: remove the debian/ directory and its contents, to make
3108 life easier for the proper Debian maintainer
3110 * Makefile (release): same
3112 2005-06-07 Brian Warner <warner@lothar.com>
3114 * everything: create a distinct SourceStamp class to replace the
3115 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3116 Changed the signature of Source.startVC to include the revision
3117 information (instead of passing it through self.args). Implement
3118 branches for SVN (now only Darcs/Git is missing support). Add more
3121 2005-06-06 Brian Warner <warner@lothar.com>
3123 * everything: rearrange build scheduling. Create a new Scheduler
3124 object (configured in c['schedulers'], which submit BuildSets to a
3125 set of Builders. Builders can now use multiple slaves. Builds can
3126 be run on alternate branches, either requested manually or driven
3127 by changes. This changed some of the Status classes. Interlocks
3128 are out of service until they've been properly split into Locks
3129 and Dependencies. treeStableTimer, isFileImportant, and
3130 periodicBuild have all been moved from the Builder to the
3132 (BuilderStatus.currentBigState): removed the 'waiting' and
3133 'interlocked' states, removed the 'ETA' argument.
3135 2005-05-24 Brian Warner <warner@lothar.com>
3137 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3138 erroneously abandons the connection (in clientConnectionFailed)
3139 for non-UserErrors, which means that if we lose the connection due
3140 to a network problem or a timeout, we'll never try to reconnect.
3141 Fix this by not upcalling to the buggy parent method. Note:
3142 twisted-2.0 fixes this, but the function only has 3 lines so it
3143 makes more sense to copy it than to try and detect the buggyness
3144 of the parent class. Fixes SF#1207588.
3146 * buildbot/changes/changes.py (Change.branch): doh! Add a
3147 class-level attribute to accomodate old Change instances that were
3148 pickled before 0.6.5 (where .branch was added for new Changes).
3149 This fixes the exception that occurs when you try to look at an
3150 old Change (through asHTML).
3152 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3155 2005-05-23 Brian Warner <warner@lothar.com>
3157 * buildbot/__init__.py (version): release 0.6.6
3159 2005-05-23 Brian Warner <warner@lothar.com>
3161 * NEWS: update for 0.6.6 release
3162 * debian/changelog: same
3164 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3165 before starting: this was done by twistd back when we spawned it,
3166 now that we're importing the pieces and running them in the
3167 current process, we have to do it ourselves. This allows
3168 master.cfg to import files from the same directory without
3169 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3170 Stichele for the catch.
3171 (Options.opt_version): Add a --version command (actually, just make
3172 the existing --version command emit Buildbot's version too)
3174 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3175 fix to make this behave like other LogFiles, this time to handle
3176 existing LogFiles on disk. (add the missing .upgrade method)
3177 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3179 2005-05-21 Brian Warner <warner@lothar.com>
3181 * buildbot/test/test_runner.py (Create.testMaster): match the
3182 rawstring change in runner.py:masterTAC
3184 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3185 TwistedWords is installed
3186 * buildbot/test/test_status.py: same, with TwistedMail
3188 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3189 some old, deprecated, and removed config keys). This should enable
3190 you to use the base buildbot functionality with Twisted-2.0.0 when
3191 you don't also have TwistedWeb and TwistedWords installed
3193 2005-05-20 Brian Warner <warner@lothar.com>
3195 * buildbot/scripts/runner.py (run): call sendchange(), not
3196 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3197 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3198 (stop): don't wait for process to die when sending SIGHUP
3199 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3200 directory name gets interpreted, which you don't want
3203 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3206 2005-05-18 Brian Warner <warner@lothar.com>
3208 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3210 2005-05-18 Brian Warner <warner@lothar.com>
3212 * README: update for 0.6.5
3213 * debian/changelog: same
3215 * buildbot/changes/changes.py: rename tag= to branch=, since
3216 that's how we're using it, and my design for the upcoming "build a
3217 specific branch" feature wants it. also, tag= was too CVS-centric
3218 * buildbot/changes/mail.py (parseSyncmail): same
3219 * buildbot/process/base.py (Build.isBranchImportant): same
3220 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3221 * docs/buildbot.texinfo (Attributes of Changes): same
3223 * NEWS: update tag=, update for upcoming release
3225 2005-05-17 Brian Warner <warner@lothar.com>
3227 * buildbot/scripts/runner.py (stop): actually poll once per
3228 second, instead of re-killing the poor daemon once per second.
3229 Sleep briefly (0.1s) before the first poll, since there's a good
3230 chance we can avoid waiting the full second if the daemon shuts
3231 down quickly. Also remove the sys.exit() at the end.
3232 (start): remove the unneighborly sys.exit()
3234 * Makefile: improve permission-setting to not kick Arch so badly
3236 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3237 default --keepalive=600, since it doesn't hurt very much, and it's
3238 a hassle to discover that you need it.
3239 * buildbot/test/test_runner.py (Create.testSlave): test it
3241 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3242 IRC bot about EXCEPTION
3244 * buildbot/status/client.py (PBListener): upcall more correctly
3246 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3247 an exception mark the overall build with EXCEPTION, not SUCCESS
3249 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3251 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3252 * Makefile: update some release-related stuff
3254 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3255 gets called when there isn't actually an active process, just end
3256 the Command instead of blowing up. I don't know how it gets into
3257 this state, but the twisted win32 buildslave will sometimes hang,
3258 and when it shakes its head and comes back, it thinks it's still
3259 running a Command. The next build causes this command to be
3260 interrupted, but the lack of self.process.pid breaks the interrupt
3263 * NEWS: document changes since the last release
3265 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3266 look for Makefile.buildbot instead of a bare Makefile . The
3267 'buildbot start' does not install this file, so you have to
3268 manually copy it if you want to customize startup behavior.
3269 (createMaster): change 'buildbot master' command to create
3270 Makefile.sample instead of Makefile, to create master.cfg.sample
3271 instead of master.cfg (requiring you to copy it before the
3272 buildmaster can be started). Both sample files are kept up to
3273 date, i.e. they are overwritten if they have been changed. The
3274 'buildbot.tac' file is *not* overwritten, but if the new contents
3275 don't match the old, a 'buildbot.tac.new' file is created and the
3276 user is warned. This seems to be a much more sane way to handle
3277 startup files. Also, don't sys.exit(0) when done, so we can run
3278 unit tests against it.
3279 (createSlave): same. Don't overwrite the sample info/ files.
3280 * buildbot/scripts/sample.mk: remove. the contents were pulled
3281 into runner.py, since they need to match the behavior of start()
3285 * docs/buildbot.texinfo (Launching the daemons): document it
3286 * buildbot/test/test_runner.py (Create): test it
3288 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3289 version that can handle string-in-string tests, because otherwise
3290 python-2.2 fails the tests. It'd be tremendous if Trial's test
3291 took two strings under 2.2 too.
3293 * everything: fixed all deprecation warnings when running against
3294 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3295 few that come from Twisted itself). This involved putting most of
3296 the Twisted-version specific code in the new buildbot.twcompat
3297 module, and creating some abstract base classes in
3298 buildbot.changes.base and buildbot.status.base (which might be
3299 useful anyway). __implements__ is a nuisance and requires an ugly
3300 'if' clause everywhere.
3302 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3303 delay before finishing the test: it seems that smtp.sendmail
3304 doesn't hang up on the server, so we must wait a moment so it can
3305 hang up on us. This removes the trial warning about an unclean
3308 2005-05-16 Brian Warner <warner@lothar.com>
3310 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3311 tuple of (delay, repeats).
3312 * buildbot/test/test_vc.py (Retry): test it
3313 * docs/buildbot.texinfo (Source Checkout): document it
3314 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3315 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3316 doVCFull() are handled by re-trying the checkout (after a delay)
3317 some number of times.
3318 (ShellCommand._startCommand): make header lines easier to read
3320 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3322 (WebTest.test_logfile): make sure master gets shut down, silences
3323 some "unclean reactor" test errors
3325 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3326 reactor once after shutdown, something in certain versions of
3327 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3328 fails, svn-trunk is ok.
3330 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3331 second win32 error message
3333 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3334 validating the ETA, so the tests don't fail on slow systems
3336 2005-05-15 Brian Warner <warner@lothar.com>
3338 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3339 the new LogFile class, so upgrading works properly
3340 (LogFileProducer.resumeProducing): survive resumeProducing after
3341 we've exhausted the chunkGenerator
3343 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3345 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3346 (Log.testUpgrade): same
3348 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3349 Builds and logs with a cron job.
3351 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3352 of the old non-offline LogFile, added code to upgrade these to
3353 new-style contents-live-on-disk instances at load time (in a way
3354 that doesn't invalidate the old Build pickles, so upgrading to
3355 0.6.5 is not a one-way operation). Got rid of everything related
3357 (LogFile.__init__): create LogFiles with the parent step status,
3358 the log's name, and a builder-relative filename where it can keep
3359 the contents on disk.
3360 (LogFile.hasContents): new method, clients are advised to call it
3361 before getText or getChunks and friends. If it returns False, the
3362 log's contents have been deleted and getText() will raise an
3364 (LogFile.getChunks): made it a generator
3365 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3366 Consumer (except one that takes chunks instead of strings). This
3367 enables streaming of very large logfiles without storing the whole
3369 (BuildStatus.generateLogfileName): create names like
3370 12-log-compile-output, with a _0 suffix if required to be unique
3371 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3372 or earlier) logfiles into new-style ones
3373 (BuilderStatus): remove everything related to 'stub' builds. There
3374 is now only one build cache, and we don't strip logs from old
3376 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3377 since we no longer fight to keep it in the cache
3379 * buildbot/status/html.py (TextLog.render_GET): use a
3380 ChunkConsumer to stream the log entries efficiently.
3381 (ChunkConsumer): wrapper which consumes chunks and writes
3384 * buildbot/test/test_twisted.py (Parse.testParse): use a
3385 LogFile-like object instead of a real one
3387 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3388 (Log.testMerge3): validate more merge behavior
3389 (Log.testChunks): validate LogFile.getChunks
3390 (Log.testUpgrade): validate old-style LogFile upgrading
3391 (Log.testSubscribe): validate LogFile.subscribe
3392 (Log.testConsumer): validate LogFile.subscribeConsumer
3394 * buildbot/interfaces.py (IStatusLogStub): remove
3395 (IStatusLog.subscribeConsumer): new method
3396 (IStatusLog.hasContents): new method
3397 (IStatusLogConsumer): describes things passed to subscribeConsumer
3399 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3400 the log contents if it does not have any contents.
3401 (StatusResourceBuildStep.body): same
3402 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3404 2005-05-14 Brian Warner <warner@lothar.com>
3406 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3407 timeouts to try and make the windows metabuildslave not hang
3409 2005-05-13 Mike Taylor <bear@code-bear.com>
3411 * buildbot/slave/commands.py (rmdirRecursive): added a check
3412 to ensure the path passed into rmdirRecursive actually exists.
3413 On win32 a non-existant path would generate an exception.
3415 2005-05-13 Brian Warner <warner@lothar.com>
3417 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3418 shutil.rmtree which behaves correctly on windows in the face of
3419 files that you have to chmod before deleting. Thanks to Bear at
3420 the OSAF for the routine.
3421 (SourceBase.doClobber): use rmdirRecursive
3423 2005-05-12 Brian Warner <warner@lothar.com>
3425 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3426 method generate chunks instead of returning a big list. This
3427 allows the same method to be used for both old LogFile and new
3429 (OfflineLogFile.getText): use the generator
3430 (OfflineLogFile.subscribe): same
3431 * buildbot/status/html.py (TextLog.resumeProducing): same
3432 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3434 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3435 point out that OfflineLogFile does not currently work with
3436 html.Waterfall . Fixing this is high-priority.
3438 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3439 apparently windows defaults to using stdout
3441 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3442 better message on failure so I can figure out the win32 problem
3444 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3445 log messages to include more useful copies of the command being
3446 run, the argv array, and the child command's environment.
3447 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3449 2005-05-11 Brian Warner <warner@lothar.com>
3451 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3453 * Makefile: update the deb-snapshot version
3455 * docs/buildbot.texinfo: move all .xhtml docs into a new
3456 .texinfo-format document, adding a lot of material in the process.
3457 This is starting to look like a real user's manual. Removed all
3458 the Lore-related files: *.xhtml, *.css, template.tpl .
3459 * docs/Makefile: simple makefile to run 'makeinfo'
3460 * buildbot/scripts/sample.cfg: rearrange slightly
3461 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3463 2005-05-10 Brian Warner <warner@lothar.com>
3465 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3466 different name for the internal twistw module, handle it.
3468 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3469 * setup.py: .. and stop trying to install it
3471 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3472 'git'), the new linux kernel VC system (http://kernel.org/git/).
3473 Thanks to Brandon Philips for the patch.
3474 * buildbot/slave/commands.py (Git): same
3476 2005-05-06 Brian Warner <warner@lothar.com>
3478 * buildbot/status/builder.py (OfflineLogFile): replace the default
3479 LogFile with a form that appends its new contents to a disk file
3480 as they arrive. The complete log data is never kept in RAM. This
3481 is the first step towards handling very large (100MB+) logfiles
3482 without choking quite so badly. (The other half is
3483 producer/consumer on the HTML pages).
3484 (BuildStepStatus.addLog): use OfflineLogFile by default
3485 (BuildStatus.getLogfileName): helper code to give the
3486 OfflineLogFile a filename to work with
3488 * buildbot/test/test_status.py (Results.testAddResults): update
3489 tests to handle new asserts
3490 * buildbot/test/test_vc.py (Patch.doPatch): same
3491 * buildbot/test/test_steps.py (BuildStep.setUp): same
3493 2005-05-05 Brian Warner <warner@lothar.com>
3495 * buildbot/scripts/runner.py (start): if there is no Makefile,
3496 launch the app by importing twistd's internals and calling run(),
3497 rather than spawning a new twistd process. This stands a much
3498 better chance of working under windows.
3499 (stop): kill the process with os.kill instead of spawning
3500 /bin/kill, again to reduce the number of external programs which
3501 windows might not have in the PATH. Also wait up to 5 seconds for
3502 the process to go away, allowing things like 'buildbot stop;
3503 buildbot start' to be reliable in the face of slow shutdowns.
3505 * buildbot/master.py (Dispatcher.__getstate__): remove old
3506 .tap-related methods
3507 (BuildMaster.__getstate__): same
3509 * buildbot/slave/bot.py (makeService): same
3510 (Options.longdesc): same
3511 * buildbot/scripts/runner.py: copy over some old mktap option text
3513 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3514 'buildbot master' now creates a buildbot.tac file, so there is no
3515 longer a create-instance/save/reload sequence. mktap is dead, long
3517 * buildbot/scripts/sample.mk: use twistd -y, not -f
3518 * buildbot/test/test_config.py: remove mktap-based test
3519 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3520 * README: don't reference mktap
3522 * docs/source.xhtml: document some of the attributes that Changes
3525 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3527 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3528 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3529 * buildbot/changes/changes.py (Change)
3530 * buildbot/changes/mail.py (parseSyncmail)
3531 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3533 * buildbot/process/base.py (Build.isTagImportant)
3537 2005-05-04 Brian Warner <warner@lothar.com>
3539 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3540 connection after sending the change, so that unit tests don't
3541 complain about sockets being left around
3543 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3544 exception in phase=0 rendering
3545 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3547 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3549 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3550 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3551 and configuring builders with tuples.
3552 * buildbot/test/test_config.py: stop testing compatibility with
3553 deprecated config keys
3554 * buildbot/test/test_run.py: same
3556 2005-05-03 Brian Warner <warner@lothar.com>
3558 * contrib/arch_buildbot.py: survive if there are no logfiles
3559 (username): just use a string, os.getlogin isn't reliable
3561 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3562 so 'buildbot sendchange' actually works. The earlier test only
3563 covered the internal (non-reactor-running) form.
3565 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3566 script to notify the buildmaster about changes
3568 * buildbot/scripts/runner.py (sendchange): new command to send a
3569 change to a buildbot.changes.pb.PBChangeSource receiver.
3570 * buildbot/test/test_changes.py (Sender): test it
3572 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3573 after any reading of the config file, not just when we do it in
3574 startService. This makes some tests a bit cleaner.
3576 * buildbot/changes/pb.py: add some log messages
3578 * buildbot/process/base.py (Build.startBuild): fix a bug that
3579 caused an exception when the build terminated in the very first
3581 (Build.stepDone): let steps return a status of EXCEPTION. This
3582 terminates the build right away, and sets the build's overall
3583 status to EXCEPTION too.
3584 * buildbot/process/step.py (BuildStep.failed): return a status of
3585 EXCEPTION when that is what has happened.
3587 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3588 implement this, allowing Arch-based projects to get precise
3589 checkouts instead of always using the latest code
3590 (Bazaar): create variant of Arch to let folks use baz instead of
3591 tla. Requires a new buildslave too.
3592 * buildbot/slave/commands.py (Arch): add 'revision' argument
3593 (Bazaar): create variant of Arch that uses baz instead of tla.
3594 Remove the code that extracts the archive name from the
3595 register-archive output, since baz doesn't provide it, and require
3596 the user provide both the archive name and its location.
3597 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3599 2005-05-02 Brian Warner <warner@lothar.com>
3601 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3602 thanks to Nick Trout.
3604 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3605 deals better with source Makefile coming from a read-only CVS
3606 checkout. Thanks to Nick Trout for the catch.
3608 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3611 2005-04-28 Brian Warner <warner@lothar.com>
3613 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3615 * debian/changelog: update for 0.6.4
3617 2005-04-28 Brian Warner <warner@lothar.com>
3619 * README.w32: add a checklist of steps for getting buildbot
3621 * MANIFEST.in: include it in the tarball
3625 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3626 broken .tap files from 0.6.3 by getting rid of .services,
3627 .namedServices, and .change_svc at load time.
3629 2005-04-27 Brian Warner <warner@lothar.com>
3631 * NEWS: update in preparation for new release
3633 * buildbot/test/test_config.py (Save.testSave): don't pull in
3634 twisted.scripts.twistd, we don't need it and it isn't for windows
3637 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3638 accomodate win32 which can't do atomic-rename
3640 2005-04-27 Brian Warner <warner@lothar.com>
3642 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3643 timeouts to help the slow metabuildbot not flunk them so much
3644 (Disconnect.testBuild3): same
3645 (Disconnect.testBuild4): same
3646 (Disconnect.testInterrupt): same
3648 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3649 setup, it was completely broken for new buildmasters (those which
3650 did not have a 'change.pck' already saved. Thanks to Paul Warren
3651 for catching this (embarrassing!) bug.
3652 (Dispatcher.__getstate__): don't save our registered avatar
3653 factories, since they'll be re-populated when the config file is
3655 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3656 tests (since the real mktap-generated BuildMaster doesn't save
3658 (BuildMaster.__getstate__): don't save any service children,
3659 they'll all be re-populated when the config file is re-read.
3660 * buildbot/test/test_config.py (Save.testSave): test for this
3662 2005-04-26 Brian Warner <warner@lothar.com>
3664 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3665 rendered with Blender.. looks a bit nicer.
3666 * buildbot/docs/images/icon.blend: add the Blender file for it
3668 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3669 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3670 running under windows. This appears to be the best way to allow
3671 BuildSteps to do something normal like 'trial -v buildbot.test' or
3672 'make foo' and still expect it to work. The idea is to make the
3673 BuildSteps look as much like what a developer would type when
3674 compiling or testing the tree by hand. This approach probably has
3675 problems when there are spaces in the arguments, so if you've got
3676 windows buildslaves, you'll need to pay close attention to your
3679 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3680 timezone to the timestamp column.
3681 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3683 * buildbot/scripts/runner.py (loadOptions): do something sane for
3684 windows, I think. We use %APPDATA%/buildbot instead of
3685 ~/.buildbot, but we still search everywhere from the current
3686 directory up to the root for a .buildbot/ subdir. The "is it under
3687 $HOME" security test was replaced with "is it owned by the current
3688 user", which is only performed under posix.
3689 * buildbot/test/test_runner.py (Options.testFindOptions): update
3690 tests to match. The "is it owned by the current user" check is
3691 untested. The test has been re-enabled for windows.
3693 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3694 any "\n" in the expected output with the platform-specific line
3695 separator. Make this separator "\r\n" on PTYs under unix, they
3696 seem to do that and I don't know why
3698 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3699 windows for now, I don't know what ~/.buildbot/ should mean there.
3701 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3702 win32 compatibility, don't use "/tmp"
3703 (Basedir.testChangeBuilddir): remove more unixisms
3705 2005-04-26 Brian Warner <warner@lothar.com>
3707 * buildbot/test/test_control.py (Force.rmtree): python2.2
3708 compatibility, apparently its shutil.rmtree ignore_errors=
3709 argument is ignored.
3710 * buildbot/test/test_run.py (Run.rmtree): same
3711 (RunMixin.setUp): same
3713 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3716 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3717 'substring in string' operator, must use string.find(substr)!=-1
3718 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3719 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3721 * buildbot/scripts/runner.py (loadOptions): add code to search for
3722 ~/.buildbot/, a directory with things like 'options', containing
3723 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3724 the current directory, your $HOME directory, or anywhere
3725 inbetween, as long as you're somewhere inside your home directory.
3726 (debugclient): look in ~/.buildbot/options for master and passwd
3727 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3728 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3730 * buildbot/status/client.py (makeRemote): new approach to making
3731 IRemote(None) be None, which works under Twisted-2.0
3732 * buildbot/test/test_status.py (Client.testAdaptation): test it
3734 * buildbot/status/builder.py (Status.builderAdded): when loading a
3735 pickled BuilderStatus in from disk, set its name after loading.
3736 The config file might have changed its name (but not its
3737 directory) while it wasn't looking.
3739 * buildbot/process/builder.py (Builder.attached): always return a
3740 Deferred, even if the builder was already attached
3741 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3743 2005-04-25 Brian Warner <warner@lothar.com>
3745 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3746 category-related exception when announcing a build has finished
3748 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3749 reference no-longer-existent changemaster.sources
3750 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3752 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3755 2005-04-25 Brian Warner <warner@lothar.com>
3757 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3759 * debian/changelog: update for 0.6.3
3761 2005-04-25 Brian Warner <warner@lothar.com>
3763 * MANIFEST.in: make sure debug.glade is in the tarball
3765 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3767 * NEWS: update for the imminent 0.6.3 release
3769 * buildbot/status/html.py (HtmlResource.content): make the
3770 stylesheet <link> always point at "buildbot.css".
3771 (StatusResource.getChild): map "buildbot.css" to a static.File
3772 containing whatever css= argument was provided to Waterfall()
3773 (Waterfall): provide the "classic" css as the default.
3774 * docs/waterfall.classic.css: move default CSS from here ..
3775 * buildbot/status/classic.css: .. to here
3777 * MANIFEST.in: make sure classic.css is included in the tarball
3778 * setup.py: and that it is installed too, under buildbot/status/
3780 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3781 the module level, because buildbot.tap files from 0.6.2 don't have
3782 it in their attribute dictionary.
3784 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3785 really exists at startup, might save some confusion somewhere.
3787 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3789 * docs/waterfall.classic.css:
3790 add a stylesheet that's almost the same as the "classic"
3793 * buildbot/status/builder.py:
3794 add EXCEPTION as a result - this is a problem for the bot
3795 maintainer, not a build problem for the changers
3796 * buildbot/process/step.py:
3797 use EXCEPTION instead of FAILURE for exceptions
3798 * buildbot/status/html.py:
3799 add build_get_class to get a class out of a build/buildstep
3800 finish naming the classes
3801 split out sourceNames to changeNames and builderNames so we
3802 can style them separately
3803 * docs/config.xhtml:
3804 finish documenting classes as they are right now
3806 * buildbot/status/html.py:
3807 name the classes as we agreed on IRC
3808 * docs/config.xhtml:
3811 * buildbot/status/html.py:
3812 same for cssclass->class_
3814 * buildbot/status/html.py:
3815 as decided on IRC, use class_ for the "class" attribute to not
3816 conflict with the class keyword, and clean up the messy **{} stuff.
3818 * buildbot/status/mail.py:
3819 put back "builders" argument, and fix docstring, because the
3820 code *ignores* builders listed in this argument
3822 * buildbot/process/builder.py:
3823 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3825 * docs/config.xhtml:
3826 describe the category argument for builders
3828 * buildbot/status/builder.py:
3829 Fix a silly bug due to merging
3831 * buildbot/process/builder.py:
3832 remove category from the process Builder ...
3833 * buildbot/status/builder.py:
3834 ... and add it to BuilderStatus instead.
3835 Set category on unpickled builder statuses, they might not have it.
3836 * buildbot/master.py:
3837 include category when doing builderAdded
3838 * buildbot/status/mail.py:
3839 return None instead of self for builders we are not interested in.
3840 * buildbot/test/test_run.py:
3841 fix a bug due to only doing deferredResult on "dummy" waiting
3842 * buildbot/test/test_status.py:
3843 add checks for the Mail IStatusReceiver returning None or self
3845 * buildbot/status/html.py:
3846 fix testsuite by prefixing page title with BuildBot
3848 * buildbot/status/builder.py:
3849 have .category in builder status ...
3850 * buildbot/process/builder.py:
3851 ... and set it from Builder
3852 * buildbot/status/html.py:
3853 make .css a class variable
3854 * buildbot/test/test_status.py:
3855 write more tests to cover our categories stuff ...
3856 * buildbot/status/mail.py:
3857 ... and fix the bug that this uncovered
3859 * buildbot/changes/mail.py:
3860 * buildbot/changes/pb.py:
3861 * buildbot/master.py:
3862 * buildbot/process/base.py:
3863 * buildbot/process/factory.py:
3864 * buildbot/process/interlock.py:
3865 * buildbot/process/step.py:
3866 * buildbot/process/step_twisted.py:
3867 * buildbot/slave/commands.py:
3868 * buildbot/status/builder.py:
3869 * buildbot/status/client.py:
3870 * buildbot/status/html.py:
3871 * buildbot/status/mail.py:
3872 * buildbot/status/progress.py:
3873 * buildbot/test/test_changes.py:
3874 * buildbot/test/test_config.py:
3875 * buildbot/test/test_control.py:
3876 * buildbot/test/test_interlock.py:
3877 * buildbot/test/test_maildir.py:
3878 * buildbot/test/test_mailparse.py:
3879 * buildbot/test/test_run.py:
3880 * buildbot/test/test_slavecommand.py:
3881 * buildbot/test/test_status.py:
3882 * buildbot/test/test_steps.py:
3883 * buildbot/test/test_twisted.py:
3884 * buildbot/test/test_util.py:
3885 * buildbot/test/test_vc.py:
3886 * buildbot/test/test_web.py:
3888 add test-case-name at the top of a whole set of files
3890 * buildbot/status/builder.py:
3891 keep order of addition when getting builder names
3892 * buildbot/status/words.py:
3893 * buildbot/test/test_run.py:
3894 add test for getBuilderNames
3896 * buildbot/process/base.py:
3897 * buildbot/process/step.py:
3898 * buildbot/status/builder.py:
3899 * buildbot/status/html.py:
3900 make buildbot css-able
3901 replace the color code for purple with purple, don't understand
3902 why it wasn't purple to start with
3904 * buildbot/status/words.py:
3905 ok, so it doesn't look like BuilderStatus.remote is still valid.
3906 Use what waterfall uses instead.
3908 * buildbot/interfaces.py:
3909 * buildbot/status/builder.py:
3910 * buildbot/status/html.py:
3911 * buildbot/status/mail.py:
3912 * buildbot/status/words.py:
3913 * buildbot/test/test_run.py:
3914 use categories everywhere and make it be a list. More sensible
3915 for the future. Also make words actually respect this in
3918 * buildbot/interfaces.py:
3919 add category argument to getBuilderNames
3920 * buildbot/process/builder.py:
3921 * buildbot/status/builder.py:
3922 * buildbot/status/html.py:
3923 * buildbot/status/mail.py:
3924 * buildbot/status/words.py:
3925 * buildbot/test/test_run.py:
3926 move from specifying builders by name to specifying the category
3928 * buildbot/status/html.py:
3929 * buildbot/status/words.py:
3930 add "builders=" to __init__ of status clients so they can
3931 limit themselves to the given list of builders to report on
3933 * buildbot/status/html.py: set the title to the product name
3935 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3937 * buildbot/interfaces.py:
3938 * buildbot/status/builder.py:
3939 more documentation. Hm, not sure if ChangeLog entries make sense
3942 2005-04-23 Brian Warner <warner@lothar.com>
3944 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3946 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3948 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3949 the sub-commands that log buildmaster status to stdout and to a
3950 GUI window, respectively.
3952 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3953 functionality is working again, but all the step-status and ETA
3954 stuff is missing. Commented out a lot of code pending more
3957 * buildbot/status/client.py: make sure that IRemote(None) is None
3959 * buildbot/changes/changes.py: import defer, oops
3960 (ChangeMaster): remove the .sources list, rely upon the fact that
3961 MultiServices can be treated as sequences of their children. This
3962 cleans up the add/remove ChangeSource routines a lot, as we keep
3963 exactly one list of the current sources instead of three.
3965 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3966 up an empty ChangeMaster at init time.
3967 (BuildMaster.loadChanges): if there are changes to be had from
3968 disk, replace self.change_svc with the new ones. If not, keep
3969 using the empty ChangeMaster set up in __init__.
3970 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3971 instead of a separate list, makes the code a bit cleaner.
3972 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3973 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3974 Extend the test to make sure we can get rid of the sources when
3977 2005-04-22 Brian Warner <warner@lothar.com>
3979 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3980 and info/host files when making the slave directory
3982 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3983 whendone= argument, just return the Deferred and let the caller do
3984 what they want with it.
3985 (Disconnect.testBuild1): wait for shutdownSlave
3986 (Basedir.testChangeBuilddir): new test to make sure changes to the
3987 builddir actually get propagated to the slave
3989 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3990 explicit method, rather than passing the builddir in __init__ .
3991 Make sure to update self.basedir too, this was broken before.
3992 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3993 builders and for ones that have just had their builddir changed.
3994 (BotFactory): add a class-level .perspective attribute, so
3995 BuildSlave.waitUntilDisconnected won't get upset when the
3996 connection hasn't yet been established
3997 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3998 tests can reach through it to inspect the SlaveBuilders
4000 * buildbot/process/base.py (Build.buildException): explain the
4001 log.err with a log.msg
4002 * buildbot/process/builder.py (Builder.startBuild): same
4003 (Builder._startBuildFailed): improve error message
4005 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4006 occurred because we lost the brand-new connection, retry instead
4007 of giving up. If not, it's probably an authorization failure, and
4008 it makes sense to stop trying. Make sure we log.msg the reason
4009 that we're log.err'ing the failure, otherwise test failures are
4010 really hard to figure out.
4012 * buildbot/master.py: change loadConfig() to return a Deferred
4013 that doesn't fire until the change has been fully implemented.
4014 This means any connected slaves have been updated with the new
4015 builddir. This change makes it easier to test the code which
4016 actually implements this builddir-updating.
4017 (BotPerspective.addBuilder): return Deferred
4018 (BotPerspective.removeBuilder): same
4019 (BotPerspective.attached): same
4020 (BotPerspective._attached): same. finish with remote_print before
4021 starting the getSlaveInfo, instead of doing them in parallel
4022 (BotPerspective.list_done): same
4023 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4024 actually calling slave.disconnect()
4025 (BotMaster.addBuilder): same
4026 (BotMaster.removeBuilder): same
4027 (BuildMaster.loadConfig): same
4028 (BuildMaster.loadConfig_Slaves): same
4029 (BuildMaster.loadConfig_Sources): same
4030 (BuildMaster.loadConfig_Builders): same
4031 (BuildMaster.loadConfig_status): same
4033 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4034 a Deferred that fires when the source is finally removed
4036 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4037 the previous tree on win32, where we have to do it synchronously,
4038 make sure we return a Deferred anyway.
4039 (SourceBase.doCopy): same
4041 * buildbot/scripts/runner.py (statusgui): use the text client for
4042 now, while I rewrite the Gtk one
4043 * buildbot/clients/base.py: strip out old code, leaving just the
4044 basic print-message-on-event functionality. I also remove the
4045 ReconnectingPBClientFactory, but it does at least quit when it
4046 loses the connection instead of going silent
4048 2005-04-21 Brian Warner <warner@lothar.com>
4050 * Makefile: minor tweaks
4052 * NEWS: point out deprecation warnings, new features for
4055 * buildbot/master.py (BuildMaster.loadConfig): emit
4056 DeprecationWarnings for Builders defined with tuples. Rearrange
4057 code to facility removal of deprecated configuration keys in the
4060 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4061 'buildbot' command to put a little Makefile in the target that
4062 helps you re-create the buildbot.tap file, start or stop the
4063 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4064 all the files 0600, since they contain passwords.
4065 (start): if there is a Makefile, and /usr/bin/make exists, use
4066 'make start' in preference to a raw twistd command. This lets
4067 slave admins put things like PYTHONPATH variables in their
4068 Makefiles and have them still work when the slave is started with
4069 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4070 be nice to first try the 'make' command and only fall back to
4071 twistd if it fails. TODO: the Makefile's "start" command does not
4072 add the --reactor=win32 argument when running under windows.
4073 (Options.debugclient, Options.statusgui): add sub-commands to launch
4074 the debug client (formerly in contrib/debugclient.py) and the
4075 Gtk status application (currently broken)
4076 * buildbot/clients/debug.py: move from contrib/debugclient.py
4077 * buildbot/clients/debug.glade: same
4079 * buildbot/test/test_trial.py: remove it. This requires some
4080 functionality out of Twisted that isn't there yet, and until then
4081 having it around just confuses things.
4083 * buildbot/test/test_slavecommand.py (Shell): test both with and
4084 without PTYs, and make sure that command output is properly
4085 interleaved in the with-PTY case. I think the without-PTY test
4086 should pass on windows, where we never use PTYs anyway.
4088 2005-04-20 Brian Warner <warner@lothar.com>
4090 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4092 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4094 * NEWS: start creating entries for the next release
4096 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4098 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4099 (WebTest.test_webPathname): same
4100 (WebTest.test_webPathname_port): same
4101 (WebTest.test_waterfall): use the default favicon rather than
4102 rooting around the filesystem for it. Open the expected-icon file
4103 in binary mode, to make win32 tests happier (thanks to Nick Trout
4105 * buildbot/status/html.py (buildbot_icon): win32 portability
4107 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4108 win32-compatibility fixes from Nick Trout, the "file not found" message
4109 is different under windows
4110 (FakeSlaveBuilder.__init__): clean up setup a bit
4111 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4113 2005-04-19 Brian Warner <warner@lothar.com>
4115 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4116 skip-if-repositories-are-unavailable test to not kill the trial
4117 that comes with Twisted-1.3.0
4119 * setup.py: install buildbot.png icon file when installing code
4121 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4122 environment used by the command, at least on the child side.
4124 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4125 this method needs to be added and implemented because it gets
4126 called under heavy load. I don't quite understand the
4127 producer/consumer API enough to write it.
4128 (StatusResource.getChild): add a resource for /favicon.ico
4129 (Waterfall.__init__): add favicon= argument
4130 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4131 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4132 (WebTest.test_webPathname): same
4133 (WebTest.test_webPathname_port): same
4134 * docs/config.xhtml: mention favicon=
4135 * buildbot/buildbot.png: add a default icon, dorky as it is
4137 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4139 * buildbot/master.py:
4140 * buildbot/process/base.py:
4141 * buildbot/process/builder.py:
4142 * buildbot/process/interlock.py:
4143 * buildbot/status/builder.py:
4144 * buildbot/status/html.py:
4145 * buildbot/status/mail.py:
4146 * buildbot/status/words.py:
4147 new documentation while digging through the code
4149 2005-04-17 Brian Warner <warner@lothar.com>
4151 * general: try to fix file modes on all .py files: a+r, a-x,
4152 but let buildbot/clients/*.py be +x since they're tools
4154 * docs/epyrun (addMod): when an import fails, say why
4156 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4158 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4160 * buildbot/process/base.py:
4161 * buildbot/process/builder.py:
4162 * buildbot/status/builder.py:
4163 new documentation while digging through the code
4165 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4167 * buildbot/changes/changes.py:
4168 * buildbot/changes/p4poller.py:
4169 * buildbot/interfaces.py:
4170 * buildbot/process/base.py:
4171 * buildbot/process/builder.py:
4172 * buildbot/process/step.py:
4173 * buildbot/process/step_twisted.py:
4174 * buildbot/slave/bot.py:
4175 * buildbot/slave/commands.py:
4176 * buildbot/status/builder.py:
4177 fix all docstrings to make epydoc happy. In the process of fixing
4178 some, I also moved pieces of docs, and removed some deprecated
4181 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4183 * buildbot/process/builder.py:
4184 * buildbot/process/interlock.py:
4185 * buildbot/process/process_twisted.py:
4186 * buildbot/process/step.py:
4187 BuildProcess -> Build, as it looks like that's what happened
4188 * buildbot/process/base.py:
4189 * buildbot/process/factory.py:
4192 2005-04-17 Brian Warner <warner@lothar.com>
4194 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4195 update compile command to accomodate the Twisted split.. now
4196 instead of './setup.py build_ext -i', you do './setup.py all
4197 build_ext -i', to run build_ext over all sub-projects.
4198 (FullTwistedBuildFactory): same
4199 (TwistedReactorsBuildFactory): same
4201 * buildbot/status/html.py (TextLog.finished): null out self.req
4202 when we're done, otherwise the reference cycle of TextLog to .req
4203 to .notifications to a Deferred to TextLog.stop keeps them from
4204 being collected, and consumes a huge (610MB on pyramid at last
4205 check) amount of memory.
4207 2005-04-11 Brian Warner <warner@lothar.com>
4209 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4210 normalize the VC-repository location.. makes SVN happier with
4211 certain test environments.
4213 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4214 RemoteShellCommand gets its own .env dictionary, so that code in
4215 start() doesn't mutate the original. I think this should fix the
4216 step_twisted.Trial problem where multiple identical components
4217 kept getting added to PYTHONPATH= over and over again.
4219 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4220 adding epydoc-format docstrings to many classes. Thanks to Thomas
4221 Vander Stichele for the patches.
4222 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4223 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4224 * buildbot/slave/bot.py, commands.py, registry.py: same
4226 2005-04-05 Brian Warner <warner@lothar.com>
4228 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4229 preserve timestamps, helps incremental builds of large trees.
4230 Patch from Rene Rivera.
4232 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4233 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4236 2005-04-03 Brian Warner <warner@lothar.com>
4238 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4239 with one dict, apparently exec has some scoping bugs when used
4240 with both global/local dicts. Thanks to Nathaniel Smith for the
4243 2005-04-02 Brian Warner <warner@lothar.com>
4245 * buildbot/process/step_twisted.py (countFailedTests): the new
4246 trial in Twisted-2.0 emits a slightly different status line than
4247 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4248 mistakenly think the test count is unparseable.
4249 (Trial.start): note that for some reason each build causes another
4250 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4251 be fixed but I'm not sure quite where the problem is.
4253 2005-04-01 Brian Warner <warner@lothar.com>
4255 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4256 deferredResult to avoid hangs/warnings under twisted-2.0
4257 (RunMixin.tearDown): same
4258 (RunMixin.shutdownSlave): same
4259 (Disconnect.testIdle1): same
4260 (Disconnect.testBuild2): same: wait one second after the build
4261 finishes for test to really be done.. this should be cleaned up to
4262 avoid wasting that second. Builder.detach uses a callLater(0),
4263 either that should be done in-line (something else needed that
4264 behavior), or it should return a Deferred that fires when the
4265 builder is really offline.
4266 (Disconnect.testBuild3): same
4267 (Disconnect.testDisappear): same
4269 * buildbot/test/test_web.py: rearrange server-setup and teardown
4270 code to remove unclean-reactor warnings from twisted-2.0
4272 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4273 so the tests don't hang under twisted-2.0
4275 2005-03-31 Brian Warner <warner@lothar.com>
4277 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4278 caused a warning each time the master changed our set of builders
4280 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4281 w32, don't unlink the file unless it already exists. Thanks to
4282 Baptiste Lepilleur for the catch.
4283 (BuilderStatus.saveYourself): same
4285 2005-02-01 Brian Warner <warner@lothar.com>
4287 * buildbot/status/html.py (TextLog.getChild): use a /text child
4288 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4289 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4290 logfile as text/plain (no markup, no headers). This replaces the
4291 previous scheme (which used an ?text=1 argument), and gets us back
4292 to a relative link (which works better when the buildbot lives
4293 behind another web server, such as Apache configured as a reverse
4294 proxy). Thanks to Gerald Combs for spotting the problem.
4296 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4299 2004-12-13 Brian Warner <warner@lothar.com>
4301 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4303 * debian/changelog: update for 0.6.2
4304 * NEWS: finalize for 0.6.2
4306 2004-12-11 Brian Warner <warner@lothar.com>
4308 * NEWS: bring it up to date
4310 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4311 detection code. Require some sign of life from the buildmaster
4312 every BotFactory.keepaliveInterval seconds. Provoke this
4313 indication at BotFactory.keepaliveTimeout seconds before the
4314 deadline by sending a keepalive request. We don't actually care if
4315 that request is answered in a timely fashion, what we care about
4316 is that .activity() is called before the deadline. .activity() is
4317 triggered by any PB message from the master (including an ack to
4318 one of the slave's status-update messages). With this new scheme,
4319 large status messages over slow pipes are OK, as long as any given
4320 message can be sent (and thus acked) within .keepaliveTimeout
4321 seconds (which defaults to 30).
4322 (SlaveBuilder.remote_startCommand): record activity
4323 (SlaveBuilder.ackUpdate): same
4324 (SlaveBuilder.ackComplete): same
4325 (BotFactory.gotPerspective): same
4326 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4328 2004-12-09 Brian Warner <warner@lothar.com>
4330 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4333 * buildbot/process/step_twisted.py (Trial._commandComplete):
4334 update self.cmd when we start the 'cat test.log' transfer. Without
4335 this, we cannot interrupt the correct RemoteCommand when we lose
4338 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4339 trying to tell the slave to stop the command if we're already
4340 inactive, or if we no longer have a .remote
4342 * buildbot/process/builder.py (Builder._detached): don't let an
4343 exception in currentBuild.stopBuild() prevent the builder from
4344 being marked offline
4346 2004-12-07 Brian Warner <warner@lothar.com>
4348 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4349 KeyError that happens when you ask for a non-existent Builder, and
4350 translate it into a UsageError.
4352 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4353 losing the slave in the middle of a remote step is handled too
4355 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4356 be a Failure, so be sure to stringify it before using it as the
4357 contents of the 'interrupt' logfile
4358 (RemoteCommand.interrupt): use stringified 'why' in
4359 remote_interruptCommand too, just in case
4361 2004-12-06 Brian Warner <warner@lothar.com>
4363 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4364 instead of 'tla update', which is more efficient in case we've
4365 missed a couple of patches since the last update.
4367 * debian/changelog: update for previous (0.6.1) release. Obviously
4368 this needs to be handled better.
4370 2004-12-05 Brian Warner <warner@lothar.com>
4372 * NEWS: update for stuff since last release
4374 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4375 match the maybeDeferred change in Dispatcher.requestAvatar
4376 * buildbot/changes/pb.py (ChangePerspective.attached): same
4377 * buildbot/status/client.py (StatusClientPerspective.attached): same
4378 * buildbot/process/builder.py (Builder._attached3): same
4379 * buildbot/pbutil.py (NewCredPerspective.attached): same
4381 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4382 the date to the top-most box, if it is not the same as today's
4385 * docs/slave.xhtml: provide a buildslave setup checklist
4387 * docs/source.xhtml (Arch): correct terminology
4389 2004-12-04 Brian Warner <warner@lothar.com>
4391 * buildbot/test/test_slavecommand.py: use sys.executable instead
4392 of hard-coding 'python' for child commands, might help portability
4394 * docs/examples/twisted_master.cfg: update to current usage
4396 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4397 'stop build' command to the IRC bot
4399 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4400 message that broke PBChangeSource
4402 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4403 (SlaveBuilder): make some attributes class-level, remove the old
4404 "update queue" which existed to support resuming a build after the
4405 master connection was lost. Try to reimplement that feature later.
4406 (SlaveBuilder.stopCommand): clear self.command when the
4407 SlaveCommand finishes, so that we don't try to kill a leftover one
4409 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4412 * buildbot/slave/commands.py (SourceBase): set self.command for
4413 all VC commands, so they can be interrupted.
4415 2004-12-03 Brian Warner <warner@lothar.com>
4417 * buildbot/master.py: clean up slave-handling code, to handle
4418 slave-disconnect and multiple-connect better
4419 (BotPerspective): make these long-lasting, exactly one per bot
4420 listed in the config file.
4421 (BotPerspective.attached): if a slave connects while an existing
4422 one appears to still be connected, disconnect the old one first.
4423 (BotPerspective.disconnect): new method to forcibly disconnect a
4424 buildslave. Use some hacks to empty the transmit buffer quickly to
4425 avoid the long (20-min?) TCP timeout that could occur if the old
4426 slave has dropped off the net.
4427 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4428 own their own SlaveStatus objects. Remove .attached/.detached, add
4429 .addSlave/.removeSlave, treat slaves like Builders (config file
4430 parsing sends deltas to the BotMaster). Inform the slave
4431 instances, i.e. the BotPerspective, about addBuilder and
4433 (BotMaster.getPerspective): turns into a single dict lookup
4434 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4435 which gives BotPerspective.attached a chance to disconnect the old
4437 (BuildMaster.loadConfig): add code (disabled) to validate that all
4438 builders use known slaves (listed in c['bots']). The check won't
4439 work with tuple-specified builders, which are deprecated but not
4440 yet invalid, so the check is disabled for now.
4441 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4442 routine, do the add/changed/removed dance with them like we do
4444 (BuildMaster.loadConfig_Sources): move source-config into a
4445 separate routine too
4447 * buildbot/status/builder.py (Status.getSlave): get the
4448 SlaveStatus object from the BotPerspective, not the BotMaster.
4450 * buildbot/test/test_run.py: bunch of new tests for losing the
4451 buildslave at various points in the build, handling a slave that
4452 connects multiple times, and making sure we can interrupt a
4455 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4456 something other than 'Bot' for the Bot object, to make certain
4457 test cases easier to write.
4458 (BuildSlave.waitUntilDisconnected): utility method for testing
4460 2004-11-30 Brian Warner <warner@lothar.com>
4462 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4464 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4465 argument, return a Deferred that always fires with True or False.
4466 I don't use an errback to indicate 'ping failed' so that callers
4467 are free to ignore the deferred without causing spurious errors in
4469 * buildbot/process/builder.py (BuilderControl.ping): implement it
4471 * buildbot/test/test_run.py (Status.testDisappear): test ping
4472 (Status.disappearSlave): fix it
4474 2004-11-30 Brian Warner <warner@lothar.com>
4476 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4477 (IBuilderControl): add .getBuild(num), only works for the current
4478 build, of course, although it might be interesting to offer
4479 something for builds in the .waiting or .interlocked state.
4481 * buildbot/process/base.py (Build): have .stopBuild just do the
4482 interrupt, then let the build die by itself.
4483 (BuildControl): add .stopBuild, and add a point-event named
4484 'interrupt' just after the build so status viewers can tell that
4486 (BuilderControl): add .getBuild
4488 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4489 stops when you kill it, good for testing
4490 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4491 contains the 'reason' text.
4493 * buildbot/status/html.py: Add Stop Build button, if the build can
4494 still be stopped. Send a Redirect (to the top page) one second
4495 later, hopefully long enough for the interrupt to have an effect.
4496 Move make_row() up to top-level to share it between Stop Build and
4499 * buildbot/slave/commands.py: only kill the child process once
4501 * buildbot/test/test_run.py: add testInterrupt
4503 2004-11-29 Brian Warner <warner@lothar.com>
4505 * buildbot/process/base.py: Refactor command interruption. The
4506 Build is now responsible for noticing that the slave has gone
4507 away: Build.lostRemote() interrupts the current step and makes
4508 sure that no further ones will be started.
4510 * buildbot/process/builder.py: When the initial remote_startBuild
4511 message fails, log it: this usually indicates that the slave has
4512 gone away, but we don't really start paying attention until they
4513 fail to respond to the first step's command.
4515 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4516 slave disconnect. Now sports a new interrupt() method. Error
4517 handling was simplified a lot by chaining deferreds, so
4518 remoteFailed/remoteComplete were merged into a single
4519 remoteComplete method (which can now get a Failure object).
4520 Likewise failed/finished were merged into just _finished.
4521 (BuildStep): Add interrupt(why) method, and if why is a
4522 ConnectionLost Failure then the step is failed with some useful
4525 * buildbot/slave/bot.py: stop the current command when the remote
4526 Step reference is lost, and when the slave is shut down.
4527 (Bot): make it a MultiService, so it can have children. Use
4528 stopService to tell when the slave is shutting down.
4529 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4530 remote_interruptCommand (which asks the current SlaveCommand to
4531 stop but allows it to keep emitting status messages), and
4532 stopCommand (which tells it to shut up and die).
4534 * buildbot/slave/commands.py: make commands interruptible
4535 (ShellCommand.kill): factor out os.kill logic
4536 (Command): factor out setup()
4537 (Command.sendStatus): don't send status if .running is false, this
4538 happens when the command has been halted.
4539 (Command.interrupt): new method, used to tell the command to die
4540 (SlaveShellCommand): implement .interrupt
4541 (DummyCommand): implement .interrupt
4542 (SourceBase, etc): factor out setup(), don't continue substeps if
4545 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4546 so they can be called after finishing
4548 * buildbot/test/test_run.py: new tests for disconnect behavior,
4549 refactor slave-shutdown routines, add different kinds of
4552 2004-11-27 Brian Warner <warner@lothar.com>
4554 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4555 method to express ETA time like "2m45s" instead of "165 seconds"
4557 2004-11-24 Brian Warner <warner@lothar.com>
4559 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4560 archive after the test completes, to avoid cluttering the user's
4561 'tla archives' listing with a bogus entry. Arch doesn't happen to
4562 provide any way to override the use of ~/.arch-params/, so there
4563 isn't a convenient way to avoid touching the setup of the user who
4565 (VC_HTTP.testArchHTTP): same
4567 2004-11-23 Brian Warner <warner@lothar.com>
4569 * buildbot/status/html.py (TextLog): split render() up into
4570 render_HEAD and render_GET. Use a Producer when sending log
4571 chunks, to reduce memory requirements and avoid sending huge
4572 non-Banana-able strings over web.distrib connections. Requires
4573 peeking under the covers of IStatusLog.
4574 (TextLog.resumeProducing): fix the "as text" link, handle client
4575 disconnects that occur while we're still sending old chunks.
4577 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4578 use defer.succeed, not the non-existent defer.success
4579 (LogFile.waitUntilFinished): same
4580 (LogFile.subscribe): don't add watchers to a finished logfile
4582 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4585 2004-11-23 Brian Warner <warner@lothar.com>
4587 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4589 2004-11-23 Brian Warner <warner@lothar.com>
4591 * NEWS: update for the 0.6.1 release
4592 * MANIFEST.in: add new files
4594 * README (INSTALLATION): explain how to enable the extra VC tests
4596 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4597 level to, so old pickled builds can be displayed ok
4599 2004-11-22 Brian Warner <warner@lothar.com>
4601 * NEWS: summarize updates since last release
4603 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4604 Yoz Grahame. Closes SF#1050138.
4606 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4609 * buildbot/process/step_twisted.py (Trial): update docs a bit
4611 * docs/factories.xhtml: fix Trial factory docs to match reality.
4614 * buildbot/process/factory.py (Trial.__init__): add args for
4615 randomly= and recurse=, making them available to instantiators
4616 instead of only to subclassers. Closes: SF#1049759.
4618 2004-11-15 Brian Warner <warner@lothar.com>
4620 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4621 try to teach the Quick factory to use multiple versions of python
4623 2004-11-12 Brian Warner <warner@lothar.com>
4625 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4626 safer w32-compatible approach, and only use it on windows
4627 (BuildStatus.saveYourself): same
4629 2004-11-11 Brian Warner <warner@lothar.com>
4631 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4632 it: one string merge per chunk. There are now separate .entries
4633 and .runEntries lists: when enumerating over all chunks, make sure
4635 * buildbot/test/test_status.py (Log): more tests
4637 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4638 chunks together, up to 10kb per chunk. This ought to cut down on
4639 the CPU-burning overhead of large log files. Thanks to Alexander
4640 Staubo for spotting the problem.
4641 * buildbot/test/test_status.py (Log): tests for same
4643 2004-11-10 Brian Warner <warner@lothar.com>
4645 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4646 header to outbound mail
4647 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4649 2004-11-08 Brian Warner <warner@lothar.com>
4651 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4652 can't do os.rename() onto an existing file, so catch the exception
4653 and unlink the target file first. This introduces a slight window
4654 where the existing file could be lost, but the main failure case
4655 (disk full) should still be handled safely.
4656 (BuildStatus.saveYourself): same
4658 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4659 separator character instead of os.sep, because the filenames being
4660 split here are coming from the VC system, which can have a
4661 different pathname convention than the local host. This should
4662 help a buildmaster running on windows that uses a CVS repository
4663 which runs under unix.
4664 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4666 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4667 when there are no test failures to be parsed
4669 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4670 instead of the unix-specific os.system("cp"), thanks to Elliot
4671 Murphy for this and the other buildbot-vs-windows catches.
4672 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4674 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4675 echo the command as it is run
4677 * setup.py: install sample.mk too, not just sample.cfg
4678 (scripts): install contrib/windows/buildbot.bat on windows
4680 2004-11-07 Brian Warner <warner@lothar.com>
4682 * buildbot/process/builder.py (Builder._detached): clear the
4683 self.currentBuild reference, otherwise the next build will be
4684 skipped because we think the Builder is already in use.
4686 * docs/examples/twisted_master.cfg: update to match current usage
4687 on the Twisted buildbot
4689 2004-10-29 Brian Warner <warner@lothar.com>
4691 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4693 2004-10-28 Brian Warner <warner@lothar.com>
4695 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4696 have separate doVCUpdate/doVCFull methods. Catch an update failure
4697 and respond by clobbering the source directory and re-trying. This
4698 will handle local changes (like replacing a file with a directory)
4699 that will cause CVS and SVN updates to fail.
4700 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4702 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4705 2004-10-19 Brian Warner <warner@lothar.com>
4707 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4709 * buildbot/status/html.py (StatusResourceTestResults): display any
4710 TestResults that the Build might have
4711 (StatusResourceTestResult): and the logs for each TestResult
4712 (StatusResourceBuild): add link from the per-build page
4714 2004-10-15 Brian Warner <warner@lothar.com>
4716 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4717 the 'problems' portion of stdout, add TestResults to our build
4718 * buildbot/test/test_twisted.py (Parse.testParse): test it
4720 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4721 to retrieve a dict of accumulated test results
4722 (ITestResult): define what a single test result can do
4723 * buildbot/status/builder.py (TestResult): implement ITestResult
4724 (BuildStatus.getTestResults): retrieve dict of TestResults
4725 (BuildStatus.addTestResult): add TestResults
4726 * buildbot/test/test_status.py (Results.testAddResults): test it
4728 2004-10-14 Brian Warner <warner@lothar.com>
4730 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4731 instead of os.system("rm -rf") for win32 portability
4733 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4734 SignalMixin instead of starting/stopping the reactor, which is
4735 likely to cause problems with other tests
4737 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4738 self.copyComplete() call. Yoz Grahame makes the catch.
4740 * contrib/windows/buildbot.bat: helper script to deal with path
4741 issues. Thanks to Yoz Grahame.
4743 * buildbot/master.py (BuildMaster.startService): don't register a
4744 SIGHUP handler if the signal module has no SIGHUP attribute.
4745 Apparently win32 does this.
4747 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4749 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4750 test if the reactor can't offer UNIX sockets
4752 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4753 error introduced in the last commit. We really need that
4756 2004-10-12 Brian Warner <warner@lothar.com>
4758 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4759 when describing a maildir source. Thanks to Stephen Davis.
4761 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4764 * buildbot/scripts/runner.py (createMaster): install Makefile too
4765 (start): add --no_save to 'start' command
4766 * buildbot/scripts/sample.mk: simple convenience Makefile with
4767 start/stop/reload targets
4769 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4772 2004-09-30 Brian Warner <warner@lothar.com>
4774 * setup.py: Releasing buildbot-0.6.0
4776 2004-09-30 Brian Warner <warner@lothar.com>
4778 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4779 test_trial.py from the source tarball until support is complete.
4781 * NEWS: update for 0.6.0 release
4782 * buildbot/__init__.py (version): same
4785 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4786 'source' command to tell users where to get the Buildbot source
4788 * docs/examples/*.cfg: update to modern standards
4790 * NEWS: update for release
4792 * buildbot/scripts/runner.py (createMaster): remove the
4793 -shutdown.tap stuff now that it isn't necessary
4795 (start): launch buildbot.tap, not buildbot-shutdown.tap
4798 * buildbot/status/mail.py (Domain): shorten class name
4799 (MailNotifier): if lookup= is a string, pass it to Domain()
4800 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4801 (Mail.testBuild2): test the string-to-Domain shortcut
4802 (Mail.testMail): fix test
4805 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4808 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4809 more attributes on load
4810 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4811 to accomodate the whole waterfall page at once, and the thrashing
4812 results in a lot of unnecessary loads
4813 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4814 (BuilderStatus.saveYourself): same
4815 (BuilderStatus.eventGenerator): stop generating on the first missing
4816 build. We assume that saved builds are deleted oldest-first.
4817 (BuildStepStatus.__getstate__): .progress might not exist
4819 * buildbot/changes/changes.py (ChangeMaster): make it
4820 serializable, in $masterdir/changes.pck
4821 (ChangeMaster.stopService): save on shutdown
4822 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4823 * buildbot/test/test_config.py: load Changes before config file
4826 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4827 "Oh my god, you killed the command" header on a separate line
4829 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4830 skip over corrupted build pickles
4831 (BuilderStatus.getFullBuildByNumber): same
4832 (BuilderStatus.eventGenerator): skip over unavailable builds
4833 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4834 do an atomic rename. This prevents a corrupted pickle when some
4835 internal serialization error occurs.
4836 (BuilderStatus.saveYourself): same
4838 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4839 the timeout for shell commands, it got lost somehow
4841 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4842 run out of build steps, return the rest of the builder events
4844 * buildbot/interfaces.py (IBuilderControl.ping): add method
4846 * buildbot/process/builder.py (BuilderControl.ping): move
4847 slave-ping to BuilderControl, and fix the failure case in the
4848 process (Event.finish() is the verb, Event.finished is the noun).
4850 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4851 through the BuilderControl instead of the BuilderStatus
4852 (EventBox): add adapter for builder.Event, allowing builder events to
4853 be displayed in the waterfall display
4855 * buildbot/master.py (BotMaster.stopService): add a 'master
4856 shutdown' event to the builder's log
4857 (BuildMaster.startService): and a 'master started' on startup
4859 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4860 builder events into the BuildStep event stream
4861 (Status.builderAdded): add a 'builder created' event
4864 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4865 command to announce the completion of a running build
4866 (IrcStatusBot.command_FORCE): announce when the build finishes
4868 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4869 don't evict unfinished builds from the cache: they must stay in
4870 the full-cache until their logfiles have stopped changing. Make
4871 sure the eviction loop terminates if an unfinished build was hit.
4872 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4873 This lets exceptions be dumped in an email status message. Really
4874 we need LogFiles which contain both text and HTML, instead of two
4876 (BuildStatus.__getstate__): handle self.finished=False
4877 (Status.builderAdded): if the pickle is corrupted, abandon the
4878 history and create a new BuilderStatus object.
4880 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4881 self.progress attribute, helped one test which doesn't fully set
4882 up the Build object.
4884 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4885 IStatusLog methods into an Interface that is implemented by "stub"
4886 logs, for which all the actual text chunks are on disk (in the
4887 pickled Build instance). To show the log contents, you must first
4888 adapt the stub log to a full IStatusLog object.
4890 * buildbot/status/builder.py (LogFileStub): create separate stub
4891 log objects, which can be upgraded to a real one if necessary.
4892 (LogFile): make them persistable, and let them stubify themselves
4894 (BuildStepStatus): same
4896 (BuildStatus.saveYourself): save the whole build out to disk
4897 (BuilderStatus): make it persistable
4898 (BuilderStatus.saveYourself): save the builder to disk
4899 (BuilderStatus.addFullBuildToCache): implement two caches which
4900 hold Build objects: a small one which holds full Builds, and a
4901 larger one which holds "stubbed" Builds (ones with their LogFiles
4902 turned into LogFileStubs). This reduces memory usage by the
4903 buildmaster by not keeping more than a few (default is 2) whole
4904 build logs in RAM all the time.
4905 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4907 (BuilderStatus.eventGenerator): rewrite since .builds went away
4908 (BuilderStatus.buildStarted): remove the .builds array. Add the
4909 build to the "full" cache when it starts.
4910 (BuilderStatus._buildFinished): save the build to disk when it
4912 (Status): give it a basedir (same as the BuildMaster's basedir)
4913 where the builder pickles can be saved
4914 (Status.builderAdded): create the BuilderStatus ourselves, by
4915 loading a pickle from disk (or creating a new instance if there
4916 was none on disk). Return the BuilderStatus so the master can glue
4917 it into the new Builder object.
4919 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4920 all BuilderStatuses to save themselves out to disk. This is in
4921 lieu of saving anything important in the main Application pickle
4922 (the -shutdown.tap file).
4923 (BuildMaster.__init__): give Status() a basedir for its files
4924 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4925 to get the BuilderStatus, then give it to the Builder (instead of
4926 doing it the other way around). It's ok if the status announces
4927 the new Builder before it's really ready, as the outside world can
4928 only see the BuilderStatus object anyway (and it is ready before
4929 builderAdded returns). Use the builder's "builddir" (which
4930 normally specifies where the slave will run the builder) as the
4931 master's basedir (for saving serialized builds).
4933 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4934 coerce the logfile to IStatusLog before trying to get the text
4935 chunks out of it. This will pull the full (non-stubified) Build in
4936 from disk if necessary.
4937 (TextLog): fix the adapter registration
4939 * buildbot/test/test_control.py (Force.setUp): create the basedir
4940 * buildbot/test/test_web.py: same
4941 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4942 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4943 * buildbot/test/test_run.py (Run.testMaster): same
4944 (Status.setUp): same
4946 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4948 * buildbot/status/html.py (Waterfall.__init__): store actual
4949 allowForce flag passed in rather than using True for everyone;
4950 make sure setting it to False doesn't cause a NameError
4952 (StatusResourceBuilder.__init__) add the builder name to the page
4954 (StatusResourceBuilder.body) move HTML generation for a name/value
4955 row into a helper method (StatusResourceBuilder.make_row); only
4956 generate the "Force Build" form if allowForce was True and the
4957 slave is connected. Use class attributes in the generated HTML to
4958 spread a little CSS-joy.
4960 2004-09-28 Brian Warner <warner@lothar.com>
4962 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4963 warning-scanner to not ignore things like
4964 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4966 * buildbot/status/html.py (StatusResource.control): add some
4967 class-level values for .control in an attempt to make upgrading
4970 * buildbot/util.py (ComparableMixin): survive missing attributes,
4971 such as when a class is modified and we're comparing old instances
4974 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4975 failure handling, remove a redundant try/except block. Don't
4976 return the full traceback to the IRC channel.
4977 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4978 error messages. Get ETA properly.
4980 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4981 the reason, since (at least) IRC message will have <> in them.
4982 (StatusResourceBuilder.__init__): take an IBuilderControl
4983 (StatusResourceBuilder.force): use the IBuilderControl we get in
4984 the constructor instead of trying to make our own. Catch the
4985 new exceptions and ignore them for now (until we make an
4986 intermediate web page where we could show the error message)
4987 (StatusResource): create with an IControl, use it to give an
4988 IBuilderControl to all children
4989 (Waterfall): take an allowForce= option, pass an IControl object
4990 to StatusResource if it is True
4992 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4994 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4995 catch new exceptions and return string forms
4997 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4998 * buildbot/process/builder.py (Builder.forceBuild): raise them
4999 * buildbot/test/test_control.py (Force.testNoSlave): new test
5000 (Force.testBuilderInUse): same
5003 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5005 * buildbot/test/test_run.py: use IControl
5006 * buildbot/test/test_vc.py: same
5008 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5009 to use IControl. Still offline.
5010 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5012 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5013 who=None so periodic builds don't send out status mail
5014 (Builder.forceBuild): include reason in the log message
5015 (BuilderControl.forceBuild): rename 'name' to 'who'
5017 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5018 'who' parameter, but make it None by default so builds forced by
5019 slave admins don't cause status mail to be sent to anybody
5020 (BotMaster.forceBuild): same. this method is deprecated.
5021 (DebugPerspective.perspective_forceBuild): same, use IControl.
5022 (DebugPerspective.perspective_fakeChange): use IControl..
5023 (Dispatcher.requestAvatar): .. so don't set .changemaster
5025 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5026 parameter to avoid confusion with the name of the builder
5029 * buildbot/status/mail.py: refine comment about needing 2.3
5031 * buildbot/status/html.py: move all imports to the top
5033 * buildbot/test/test_control.py: test new interfaces
5034 * buildbot/test/test_run.py (Status): handle new interfaces
5035 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5037 * buildbot/process/base.py (BuildControl): implement IBuildControl
5038 and its lonely getStatus() method
5040 * buildbot/process/builder.py (BuilderControl): implement
5041 IBuilderControl, obtained by adapting the Builder instance
5042 (Builder.startBuild): return a BuilderControl instead of a
5043 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5044 accomplish the same thing.
5046 * buildbot/master.py: move all import statements to the top
5047 (Control): implement IControl, obtained by adapting the
5048 BuildMaster instance.
5050 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5051 IBuildControl. These are used to force builds. Eventually they
5052 will provide ways to reconfigure the Builders, pause or abandon a
5053 Build, and perhaps control the BuildMaster itself.
5055 2004-09-26 Brian Warner <warner@lothar.com>
5057 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5058 ends up comparing us against something without a .__class__
5060 2004-09-24 Brian Warner <warner@lothar.com>
5062 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5065 * Makefile: add 'deb-snapshot' target, to create a timestamped
5068 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5070 2004-09-23 Brian Warner <warner@lothar.com>
5072 * buildbot/__init__.py (version): move version string here
5073 * setup.py: get version string from buildbot.version
5074 * buildbot/status/html.py (WaterfallStatusResource.body): add
5075 buildbot version to the page footer
5076 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5079 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5080 slaves, let the second know where the first one is coming from
5081 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5082 see our exceptions. It would be nice if there were a way to just
5083 send them the exception type and value, not the full traceback.
5086 * buildbot/status/mail.py (MailNotifier): add a new argument
5087 sendToInterestedUsers=, which can be set to False to disable the
5088 usual send-to-blamelist behavior.
5089 (top): handle python-2.2 which has no email.MIMEMultipart
5090 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5091 (MailNotifier.disownServiceParent): unsubscribe on removal
5093 * buildbot/test/test_status.py (Mail.testBuild2): test it
5096 * buildbot/status/progress.py (Expectations.wavg): tolerate
5097 current=None, which happens when steps start failing badly
5098 * buildbot/test/test_status.py (Progress.testWavg): test for it
5100 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5101 doesn't understand args['revision'], emit a warning instead of
5102 bailing completely. Updating to -rHEAD is probably close enough.
5104 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5106 * buildbot/test/test_status.py: at least import bb.status.client
5107 even if we don't have any test coverage for it yet
5109 * contrib/svn_buildbot.py: don't require python2.3
5110 (main): wait, do require it (for sets.py), but explain how to
5111 make it work under python2.2
5113 2004-09-23 Brian Warner <warner@lothar.com>
5115 * contrib/svn_buildbot.py: include the revision number in the Change
5117 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5118 using util.now() because FreshCVS is a realtime service
5120 * buildbot/status/event.py: delete dead code
5121 * buildbot/process/step.py: don't import dead Event class
5122 * buildbot/process/step_twisted.py: same
5123 * buildbot/status/builder.py: same
5124 * buildbot/status/client.py: same
5126 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5128 * buildbot/changes/changes.py (Change): set .when from an __init__
5129 argument (which defaults to now()), rather than having
5130 ChangeMaster.addChange set it later.
5131 (ChangeMaster.addChange): same
5133 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5134 (parseSyncmail): same. Just use util.now() for now.
5135 (parseBonsaiMail): parse the timestamp field for when=
5137 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5138 instead of setting .when after the fact
5142 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5143 results when the target project uses retrial. Still under
5145 * buildbot/test/test_trial.py: same
5147 2004-09-21 Brian Warner <warner@lothar.com>
5149 * buildbot/status/mail.py (MailNotifier.__init__): include
5150 success/warnings/failure in the Subject line
5151 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5152 use step.logname for the addLogs=True attachment filenames
5153 * buildbot/test/test_status.py (Mail): test Subject lines
5154 (Mail.testLogs): test attachment filenames
5156 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5157 accept a 'who' argument from the debug tool
5158 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5159 * contrib/debug.glade: add text box to set 'who'
5161 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5162 .getBuilderName with .getBuilder().getName(), more flexible
5163 (IStatusLog.getName): logs have short names, but you can prefix
5164 them with log.getStep().getName() to make them more useful
5165 * buildbot/status/builder.py: same
5166 * buildbot/status/client.py: same
5167 * buildbot/status/html.py: same
5168 * buildbot/test/test_run.py (Status.testSlave): same
5169 * buildbot/process/step.py: tweak logfile names
5171 * buildbot/status/mail.py (MailNotifier): add lookup, change
5172 argument to extraRecipients. The notifier is now aimed at sending
5173 mail to the people involved in a particular build, with additional
5174 constant recipients as a secondary function.
5176 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5177 including slow-lookup and failing-lookup. Make sure the blamelist
5178 members are included.
5180 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5181 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5182 (IBuildStatus.getInterestedUsers): new method
5183 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5184 * buildbot/status/client.py (remote_getResponsibleUsers): same
5185 * buildbot/status/html.py (StatusResourceBuild.body): same
5186 * buildbot/test/test_run.py (Status.testSlave): same
5188 2004-09-20 Brian Warner <warner@lothar.com>
5190 * docs/users.xhtml: update concepts
5192 * Makefile: add a convenience makefile, for things like 'make
5193 test'. It is not included in the source tarball.
5195 2004-09-16 Brian Warner <warner@lothar.com>
5197 * NEWS: mention /usr/bin/buildbot, debian/*
5199 * debian/*: add preliminary debian packaging. Many thanks to
5200 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5201 it considerably since it left their hands, I am responsible for
5202 all breakage that's resulted.
5204 * bin/buildbot: create a top-level 'buildbot' command, to be
5205 installed in /usr/bin/buildbot . For now it's just a simple
5206 frontend to mktap/twistd/kill, but eventually it will be the entry
5207 point to the 'try' command and also a status client. It is also
5208 intended to support the upcoming debian-packaging init.d scripts.
5209 * buildbot/scripts/runner.py: the real work is done here
5210 * buildbot/scripts/__init__.py: need this too
5211 * buildbot/scripts/sample.cfg: this is installed in new
5212 buildmaster directories
5213 * setup.py: install new stuff
5215 2004-09-15 Brian Warner <warner@lothar.com>
5217 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5218 'file:' schema (the version shipped with OS-X was built without the
5220 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5221 updates the log-timestamp, to make sure it isn't still running after
5224 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5225 values to the config file.
5226 * docs/examples/hello.cfg: add examples
5227 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5228 * buildbot/status/builder.py (Status.getProjectURL): implement them
5229 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5230 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5231 * buildbot/status/html.py (WaterfallStatusResource): display them
5234 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5235 certain error cases don't suffer a secondary exception.
5236 (top): Skip tests if the corresponding VC tool is not installed.
5238 * buildbot/process/factory.py (Trial): introduce separate
5239 'buildpython' and 'trialpython' lists, since trialpython=[] is
5240 what you want to invoke /usr/bin/python, whereas ./setup.py is
5241 less likely to be executable. Add env= parameter to pass options
5242 to test cases (which is how I usually write tests, I don't know if
5243 anyone else does it this way).
5245 * buildbot/process/step_twisted.py (Trial): handle python=None.
5246 Require 'testpath' be a string, not a list. Fix tests= typo.
5247 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5249 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5250 way to deal with the possibility of removing the disconnect notify
5252 (CVS): add a 'login' parameter to give a password to 'cvs login',
5253 commonly used with pserver methods (where pw="" or pw="guest")
5255 * buildbot/slave/commands.py (SourceBase): move common args
5256 extraction and setup() to __init__, so everything is ready by the
5257 time setup() is called
5258 (CVS.start): call 'cvs login' if a password was supplied
5259 (ShellCommand): special-case PYTHONPATH: prepend the master's
5260 value to any existing slave-local value.
5262 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5263 don't have a remote, mark the builder as Offline. This whole
5264 function should probably go away and be replaced by individual
5266 (Builder.buildFinished): return the results to the build-finished
5267 deferred callback, helps with testing
5269 2004-09-14 Brian Warner <warner@lothar.com>
5271 * buildbot/test/test_vc.py: put all the repositories needed to run
5272 the complete tests into a single small (1.3MB) tarball, so I can
5273 make that tarball available on the buildbot web site. Test HTTP
5274 access (for Arch and Darcs) by spawning a temporary web server
5275 while the test runs.
5277 * docs/users.xhtml: new document, describe Buildbot's limited
5278 understanding of different human users
5280 * buildbot/test/test_vc.py: rearrange test cases a bit
5282 * buildbot/process/step_twisted.py (Trial): handle testpath=
5283 * buildbot/process/factory.py (Trial): update to use step.Trial
5285 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5287 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5288 the overall build text (which gives you 'failed 2 tests' rather
5290 (BuildStepStatus.text2): default to [], not None
5292 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5295 2004-09-12 Brian Warner <warner@lothar.com>
5297 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5298 log the whole exception if it's just an AttributeError (old slave)
5300 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5301 so (e.g.) sub-commands can be run in the right directory.
5302 (ShellCommand.start): accept an optional errorMessage= argument
5303 to make life easier for SVN.start
5304 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5306 (ShellCommand.start): move ['dir'] compatibility hack..
5307 (RemoteShellCommand.start): .. to here so everyone can use it
5309 * buildbot/process/step_twisted.py (Trial): use .workdir
5311 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5312 text displayed when debuild fails completely
5313 (Trial): snarf _trial_temp/test.log from the slave and display it
5315 2004-09-11 Brian Warner <warner@lothar.com>
5317 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5319 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5320 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5322 * buildbot/process/step.py (ShellCommand): call .createSummary
5323 before .evaluateCommand instead of the other way around. This
5324 makes it slightly easier to count warnings and then use that to
5325 set results=WARNINGS
5326 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5328 * buildbot/process/base.py (Build.buildFinished): update status
5329 before doing progress. It's embarrassing for the build to be stuck
5330 in the "building" state when an exceptions occurs elsewhere..
5332 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5333 python2.2 doesn't have 'sum'
5335 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5336 to prevent clients from accidentally sorting it
5338 * buildbot/master.py (Manhole): add username/password
5339 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5340 c['manholePort'], deprecate old usage
5341 * docs/config.xhtml: document c['manhole']
5342 * docs/examples/hello.cfg: show example of using a Manhole
5345 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5346 pretend the slave is up to date
5348 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5349 the module, overlaps with 'log', the local variable
5351 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5353 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5354 new method to let Steps find out the version of their
5355 corresponding SlaveCommand.
5356 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5357 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5358 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5360 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5361 (Arch.startVC): same
5362 (P4Sync.startVC): same
5364 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5365 Deferred so we can catch errors in remote_startCommand
5366 (RemoteShellCommand.start): same
5368 * docs/examples/twisted_master.cfg: update sample config file
5370 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5371 after connectionMade() is called, not before. Close stdin at that
5374 * buildbot/process/process_twisted.py: update to use Trial, clean
5375 up argument passing (move to argv arrays instead of string
5378 * buildbot/process/step_twisted.py (Trial): new step to replace
5379 RunUnitTests, usable by any trial-using project (not just
5380 Twisted). Arguments have changed, see the docstring for details.
5382 * buildbot/process/base.py (Build.startBuild): this now returns a
5383 Deferred. Exceptions that occur during setupBuild are now
5384 caught better and lead to fewer build_status weirdnesses, like
5385 finishing a build that was never started.
5386 (Build.buildFinished): fire the Deferred instead of calling
5387 builder.buildFinished directly. The callback argument is this
5388 Build, everything else can be extracted from it, including the
5389 new build.results attribute.
5390 * buildbot/process/builder.py (Builder.startBuild): same
5391 (Builder.buildFinished): same, extract results from build
5393 * buildbot/process/step.py (ShellCommands): remove dead code
5395 2004-09-08 Brian Warner <warner@lothar.com>
5397 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5398 doesn't try to use the leftover patched workdir
5399 (SourceStamp): test source-stamp computation for CVS and SVN
5401 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5402 patched workdir ('touch .buildbot-patched') so we don't try to
5404 (SourceBase.start): add ['revision'] for all Source steps
5405 (CVS): change args: use ['branch'] for -r, remove ['files']
5406 (CVS.buildVC): fix revision/branch stuff
5407 (SVN): add revision stuff
5409 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5410 kwargs (except 'workdir') to avoid silent spelling errors
5411 (ShellCommand.__init__): same
5412 (Source): new base class for CVS/SVN/etc. Factor out everything
5413 common, add revision computation (perform the checkout with a -D
5414 DATE or -r REVISION that gets exactly the sources described by the
5415 last Change), overridable with step.alwaysUseLatest. Add patch
5416 handling (build.getSourceStamp can trigger the use of a base
5417 revision and a patch).
5418 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5419 * docs/steps.xhtml: update docs
5420 * docs/source.xhtml: mention .checkoutDelay
5421 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5423 * buildbot/process/base.py (Build.setSourceStamp): add a
5424 .sourceStamp attribute to each Build. If set, this indicates that
5425 the build should be done with something other than the most
5426 recent source tree. This will be used to implement "try" builds.
5427 (Build.allChanges): new support method
5428 (Build.lastChangeTime): remove, functionality moved to Source steps
5429 (Build.setupBuild): copy the Step args before adding ['workdir'],
5430 to avoid modifying the BuildFactory (and thus triggering spurious
5434 * buildbot/status/html.py: rename s/commits/changes/
5435 (StatusResourceChanges): same
5436 (CommitBox.getBox): same, update URL
5437 (WaterfallStatusResource): same
5438 (StatusResource.getChild): same
5440 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5441 * contrib/debug.glade: add optional 'revision' to the fakeChange
5443 * buildbot/changes/changes.py (html_tmpl): display .revision
5444 (ChangeMaster.addChange): note .revision in log
5445 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5446 accept a ['revision'] attribute
5448 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5450 * buildbot/master.py (BotMaster.getPerspective): update the
5451 .connected flag in SlaveStatus when it connects
5452 (BotMaster.detach): and when it disconnects
5453 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5454 (BuildMaster.loadConfig_Builders): walk old list correctly
5456 * buildbot/test/test_config.py: fix prefix= usage
5458 2004-09-06 Brian Warner <warner@lothar.com>
5462 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5463 poll a P4 depot looking for recent changes. Thanks to Dave
5464 Peticolas for the contribution. Probably needs some testing after
5467 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5468 requires manual client setup for each buildslave. Rather
5469 experimental. Thanks again to Dave Peticolas.
5470 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5472 * buildbot/changes/changes.py (Change): add a .revision attribute,
5473 which will eventually be used to generate source-stamp values.
5475 * buildbot/process/step.py (RemoteCommand.start): use
5476 notifyOnDisconnect to notice when we lose the slave, then treat it
5477 like an exception. This allows LogFiles to be closed and the build
5478 to be wrapped up normally. Be sure to remove the disconnect
5479 notification when the step completes so we don't accumulate a
5480 bazillion such notifications which will fire weeks later (when the
5481 slave finally disconnects normally). Fixes SF#915807, thanks to
5482 spiv (Andrew Bennetts) for the report.
5483 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5484 really isn't Logged- specific
5485 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5486 header, since it's almost always going to be appended to an
5488 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5489 update test to handle use of notifyOnDisconnect
5491 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5492 don't clear .ETA and .currentBuild when going offline, let the
5493 current build clean up after itself
5495 * buildbot/process/builder.py (Builder.detached): wait a moment
5496 before doing things like stopping the current build, because the
5497 current step will probably notice the disconnect and cleanup the
5499 * buildbot/test/test_run.py (Status.tearDown): update test to
5500 handle asynchronous build-detachment
5502 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5504 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5505 hush a debug message
5507 2004-09-05 Brian Warner <warner@lothar.com>
5509 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5510 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5511 kernels do this: the fcntl module has the F_NOTIFY constant, but
5512 the kernel itself doesn't support the operation. Thanks to Olly
5513 Betts for spotting the problem.
5515 * buildbot/process/step.py (Darcs): new source-checkout command
5516 (Arch): new source-checkout command
5517 (todo_P4): fix constructor syntax, still just a placeholder
5518 * buildbot/test/test_vc.py (VC.testDarcs): test it
5519 (VC.testDarcsHTTP): same, via localhost HTTP
5521 (VC.testArchHTTP): same
5522 * NEWS: mention new features
5524 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5525 which tells the step to stash stdout text locally (in .stdout).
5526 Slave-side Commands can use this to make decisions based upon the
5527 output of the the ShellCommand (not just the exit code).
5528 (Darcs): New source-checkout command
5529 (Arch): New source-checkout command, uses .keepStdout in one place
5530 where it needs to discover the archive's default name.
5532 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5533 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5534 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5536 * buildbot/process/step.py (ShellCommand.describe): add an
5537 alternate .descriptionDone attribute which provides descriptive
5538 text when the step is complete. .description can be ["compiling"],
5539 for use while the step is running, then .descriptionDone can be
5540 ["compile"], used alone when the step succeeds or with "failed" when
5541 it does not. Updated other steps to use the new text.
5542 * buildbot/process/step_twisted.py: same
5543 * buildbot/test/test_run.py: update tests to match
5545 2004-08-30 Brian Warner <warner@lothar.com>
5547 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5548 (CVS.__init__): send 'patch' argument to slave
5549 (CVS.start): don't create the LoggedRemoteCommand until start(),
5550 so we can catch a .patch added after __init__
5551 (SVN.__init__): add 'patch' to SVN too
5554 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5555 argument, to let commands push data into the process' stdin pipe.
5556 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5557 is in use, since closing a PTY doesn't really affect the process
5558 in the right way (in particular, I couldn't run /usr/bin/patch
5560 (SourceBase.doPatch): handle 'patch' argument
5562 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5565 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5566 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5568 * buildbot/master.py (BotPerspective.got_commands): get command
5569 versions from slave, give to each builder
5570 * buildbot/process/builder.py (Builder.attached): stash slave
5571 command versions in .remoteCommands
5573 * docs/steps.xhtml: bring docs in-line with reality
5575 * buildbot/process/step.py (CVS.__init__): more brutal
5576 compatibility code removal
5577 (SVN.__init__): same
5579 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5580 (SlaveShellCommand.start): require ['workdir'] argument, remove
5581 the ['dir'] fallback (compatibility will come later)
5582 (SourceBase): update docs
5583 (SourceBase.start): remove ['directory'] fallback
5586 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5587 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5588 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5590 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5591 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5592 code.. I will figure out 0.5.0-compatibility hooks later)
5594 2004-08-30 Brian Warner <warner@lothar.com>
5596 * buildbot/process/process_twisted.py: rewrite in terms of new
5597 BuildFactory base class. It got significantly shorter. Yay
5600 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5601 work with the new "self.build isn't nailed down until we call
5602 step.start()" scheme: specifically, __init__ is called before the
5603 build has decided on which Changes are going in, so we don't scan
5604 build.allFiles() for .xhtml files until start()
5605 (HLint.commandComplete): use getText(), not getStdout()
5606 (RunUnitTests.start): same: don't use .build until start()
5607 (RunUnitTests.describe): oops, don't report (None) when using
5609 (RunUnitTests.commandComplete): use getText()
5610 (RunUnitTests.createSummary): same
5611 (BuildDebs.commandComplete): same
5613 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5614 set args['command'] until start(), since our BuildStep is allowed
5615 to change their mind up until that point
5616 (TreeSize.commandComplete): use getText(), not getStdout()
5618 * docs/examples/twisted_master.cfg: update to current standards
5620 * docs/factories.xhtml: update
5621 * buildbot/process/factory.py: implement all the common factories
5622 described in the docs. The Trial factory doesn't work yet, and
5623 I've probably broken all the process_twisted.py factories in the
5624 process. There are compatibility classes left in for things like
5625 the old BasicBuildFactory, but subclasses of them are unlikely to
5627 * docs/examples/glib_master.cfg: use new BuildFactories
5628 * docs/examples/hello.cfg: same
5630 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5631 explicit 'workdir' args
5633 * buildbot/process/base.py (BuildFactory): move factories to ..
5634 * buildbot/process/factory.py (BuildFactory): .. here
5635 * buildbot/process/process_twisted.py: handle move
5636 * buildbot/test/test_config.py: same
5637 * buildbot/test/test_run.py: same
5638 * buildbot/test/test_steps.py: same
5639 * buildbot/test/test_vc.py: same
5640 * docs/factories.xhtml: same
5642 * NEWS: mention config changes that require updating master.cfg
5644 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5645 argument to all steps that weren't given one already, pointing at
5646 the "build/" directory.
5648 * docs/examples/hello.cfg: remove explicit 'workdir' args
5650 * docs/factories.xhtml: document standard BuildFactory clases,
5651 including a bunch which are have not yet been written
5653 2004-08-29 Brian Warner <warner@lothar.com>
5655 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5656 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5657 buildbot.status.builder so they aren't quite so internal
5658 * buildbot/process/base.py, buildbot/process/builder.py: same
5659 * buildbot/process/maxq.py, buildbot/process/step.py: same
5660 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5661 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5662 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5664 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5665 to handle new getLogs()-returns-list behavior
5666 (StatusResourceBuildStep.getChild): same
5667 (StepBox.getBox): same
5668 (WaterfallStatusResource.phase0): same
5670 * docs/source.xhtml: document how Buildbot uses version-control
5671 systems (output side: how we get source trees)
5672 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5673 systems (input side: how we learn about Changes)
5675 * buildbot/master.py (Manhole): use ComparableMixin
5676 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5677 * buildbot/changes/mail.py (MaildirSource): same
5678 * buildbot/status/client.py (PBListener): same
5679 * buildbot/status/html.py (Waterfall): same
5680 * buildbot/status/words.py (IRC): same
5682 * NEWS: start describing new features
5684 * buildbot/status/mail.py (MailNotifier): finish implementation.
5685 The message body is still a bit sparse.
5686 * buildbot/test/test_status.py (Mail): test it
5688 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5689 and __hash__ methods I wind up adding everywhere. Specifically
5690 intended to support the buildbot config-file update scheme where
5691 we compare, say, the old list of IStatusTargets against the new
5692 one and don't touch something which shows up on both lists.
5693 * buildbot/test/test_util.py (Compare): test case for it
5695 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5696 return a list instead of a dict
5697 (IBuildStepStatus.getLogs): same. The idea is that steps create
5698 logs with vaguely unique names (although their uniqueness is not
5699 guaranteed). Thus a compilation step should create its sole
5700 logfile with the name 'compile', and contribute it to the
5701 BuildStatus. If a step has two logfiles, try to create them with
5702 different names (like 'test.log' and 'test.summary'), and only
5703 contribute the important ones to the overall BuildStatus.
5704 * buildbot/status/builder.py (Event.getLogs): same
5705 (BuildStepStatus): fix default .text and .results
5706 (BuildStepStatus.addLog): switch to list-like .getLogs()
5707 (BuildStepStatus.stepFinished): same
5708 (BuildStatus.text): fix default .text
5709 (BuildStatus.getLogs): temporary hack to return all logs (from all
5710 child BuildStepStatus objects). Needs to be fixed to only report
5711 the significant ones (as contributed by the steps themselves)
5712 * buildbot/test/test_run.py: handle list-like .getLogs()
5713 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5715 2004-08-28 Brian Warner <warner@lothar.com>
5717 * buildbot/process/builder.py (Builder.attached): serialize the
5718 attachment process, so the attach-watcher isn't called until the
5719 slave is really available. Add detached watchers too, which makes
5722 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5724 * buildbot/test/test_swap.py: remove dead code
5726 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5727 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5728 sort of as if the command being run exited with a -1. There may
5729 still be some holes in this scheme.
5730 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5731 -r option appears before the module list
5732 * buildbot/process/step.py (CVS): add 'revision' argument
5734 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5735 when sending updates or stepComplete messages to the master, since
5736 we don't currently care whether they arrive or not. When we revamp
5737 the master/slave protocol to really resume interrupted builds,
5738 this will need revisiting.
5739 (lostRemote): remove spurious print
5741 * buildbot/master.py (BotPerspective.attached): serialize the
5742 new-builder interrogation process, to make testing easier
5743 (BotMaster.waitUntilBuilderDetached): convenience function
5745 * buildbot/status/builder.py (BuilderStatus): prune old builds
5746 (BuildStatus.pruneSteps): .. and steps
5747 (BuildStepStatus.pruneLogs): .. and logs
5748 (BuilderStatus.getBuild): handle missing builds
5749 * buildbot/status/html.py (StatusResourceBuild.body): display build
5750 status in the per-build page
5751 (BuildBox.getBox): color finished builds in the per-build box
5753 2004-08-27 Brian Warner <warner@lothar.com>
5755 * buildbot/status/mail.py (MailNotifier): new notification class,
5758 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5759 variants of a common base class which handles all the mode= logic
5761 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5763 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5765 2004-08-26 Brian Warner <warner@lothar.com>
5767 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5770 * buildbot/test/test_run.py: update to new Logfile interface, new
5771 buildbot.slave modules
5772 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5774 * MANIFEST.in: new sample config file
5775 * docs/examples/hello.cfg: same
5777 * buildbot/process/step_twisted.py: remove dead import
5779 * buildbot/process/step.py (RemoteCommand.run): catch errors
5781 (RemoteCommand.remote_update): ignore updates that arrive after
5783 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5784 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5785 the responsibilities of the subclass's methods
5786 (BuildStep.failed): catch errors during failure processing
5787 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5788 (CVS): move to a mode= argument (described in docstring), rather
5789 than the ungainly clobber=/export=/copydir= combination.
5790 (SVN): add mode= functionality to SVN too
5791 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5793 * buildbot/process/base.py (Build.startNextStep): catch errors
5794 during s.startStep()
5796 * buildbot/clients/base.py: update to new PB client interface.
5797 gtkPanes is still broken
5799 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5800 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5801 * setup.py: add buildbot.slave module
5802 * buildbot/bb_tap.py: handle move
5803 * buildbot/slave/registry.py: place to register commands, w/versions
5804 * buildbot/slave/bot.py: major simplifications
5805 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5806 instead of a fixed table. Eventually this will make the slave more
5807 extensible. Use 'start' method on the command, not .startCommand.
5808 Fix unsafeTracebacks handling (I think).
5809 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5810 helper class with a .start method that returns a Deferred.
5811 SlaveShellCommand is the form reached by the buildmaster. Commands
5812 which use multiple ShellCommands can just chain them as Deferreds,
5813 with some helper methods in Command (_abandonOnFailure and
5814 _checkAbandoned) to bail on rc!=0.
5815 (CVSCommand): prefer new mode= argument
5816 (SVNFetch): add mode= argument
5818 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5819 put a useful reason string on the build
5821 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5822 core functionality into an IStatusLog object
5823 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5824 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5825 (StatusResourceBuild.body): use proper accessor methods
5826 * buildbot/status/client.py (RemoteLog): PB-access goes here
5827 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5828 which delivers log contents too
5829 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5830 * buildbot/status/event.py: remove old Logfile completely
5832 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5833 subscription interface for IStatusLog subscriptions just like all
5834 other the status subscriptions
5835 (IStatusReceiver.logChunk): method called on subscribers
5837 2004-08-24 Brian Warner <warner@lothar.com>
5839 * buildbot/process/builder.py (Builder._pong): oops, ping response
5840 includes a result (the implicit None returned by remote_print).
5841 Accept it so the _pong method handles the response correctly.
5843 2004-08-06 Brian Warner <warner@lothar.com>
5845 * buildbot/test/test_config.py: update IRC, PBListener tests
5847 * buildbot/status/client.py (StatusClientPerspective): total
5848 rewrite to match new IStatus interfaces. New subscription scheme.
5849 There are still a few optimizations to make (sending down extra
5850 information with event messages so the client doesn't have to do a
5851 round trip). The logfile-retrieval code is probably still broken.
5852 Moved the PB service into its own port, you can no longer share a
5853 TCP socket between a PBListener and, say, the slaveport (this
5854 should be fixed eventually).
5855 * buildbot/clients/base.py (Client): revamp to match. still needs
5856 a lot of work, but basic event reporting works fine. gtkPanes is
5859 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5860 instance talks to a single irc server. Threw out all the old
5861 multi-server handling code. Still need to add back in
5862 builder-control (i.e. "force build")
5864 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5865 more random text to the as-yet-unreachable per-step page
5867 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5868 rename to stepETAUpdate
5869 (BuildStatus.subscribe): add build-wide ETA updates
5870 (BuilderStatus.getState): remove more cruft
5871 (BuilderStatus.getCurrentBuild): remove more cruft
5872 (BuilderStatus.buildStarted): really handle tuple-subscription
5873 * buildbot/test/test_run.py (Status.testSlave): handle the
5874 stepETAUpdate rename
5876 * buildbot/master.py (BuildMaster): don't add a default
5877 StatusClientService. Don't add a default IrcStatusFactory. Both
5878 are now added through c['status'] in the config file. c['irc'] is
5879 accepted for backwards compatibility, the only quirk is you cannot
5880 use c['irc'] to specify IRC servers on ports other than 6667.
5882 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5883 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5884 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5885 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5888 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5889 the buildmaster to re-read its config file
5892 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5893 find out the port our server is running on
5894 (WebTest.test_webPathname_port): same
5896 * buildbot/test/test_config.py (testWebPortnum): test it
5897 (testWebPathname): ditto
5899 * docs/config.xhtml: document new c['status'] configuration option
5901 * buildbot/status/html.py (Waterfall): new top-level class which
5902 can be added to c['status']. This creates the Site as well as the
5903 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5904 reachable as .parent, for everything.
5906 * buildbot/master.py (Manhole): make it a normal service Child
5907 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5908 webPathname. It will eventually replace c['irc'] and the implicit
5909 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5910 in as (deprecated) backward compatibility hooks for now.
5913 * buildbot/process/builder.py (Builder.buildFinished): don't
5914 inform out builder_status about a finished build, as it finds out
5915 through its child BuildStatus object
5917 * buildbot/status/html.py: extensive revamp. Use adapters to make
5918 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5919 have both starting and finishing times and adjust the waterfall
5920 display accordingly, using spacers if necessary. Use SlaveStatus
5921 to get buildslave info.
5922 (StatusResourceBuildStep): new just-one-step resource, used to get
5923 logfiles. No actual href to it yet.
5925 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5926 the time being, until I get the file-naming scheme right
5928 * buildbot/status/builder.py (Event): clean started/finished names
5929 (BuildStatus.isFinished): .finished is not None is the right test
5930 (BuildStatus.buildStarted): track started/finished times ourselves
5931 (BuilderStatus.getSlave): provide access to SlaveStatus object
5932 (BuilderStatus.getLastFinishedBuild): all builds are now in
5933 .builds, even the currently-running one. Accomodate this change.
5934 (BuilderStatus.eventGenerator): new per-builder event generator.
5935 Returns BuildStepStatus and BuildStatus objects, since they can
5936 both be adapted as necessary.
5937 (BuilderStatus.addEvent): clean up started/finished attributes
5938 (BuilderStatus.startBuild,finishBuild): remove dead code
5939 (SlaveStatus): new object to provide ISlaveStatus
5941 * buildbot/process/step.py (ShellCommand.getColor): actually
5942 return the color instead of setting it ourselves
5943 (CVS.__init__): pull .timeout and .workdir options out of
5944 **kwargs, since BuildStep will ignore them. Without this neither
5945 will be sent to the slave correctly.
5946 (SVN.__init__): same
5948 * buildbot/process/builder.py (Builder): move flags to class-level
5950 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5951 SlaveStatus handle that
5953 * buildbot/process/base.py (Build.firstEvent): remove dead code
5954 (Build.stopBuild): bugfix
5956 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5958 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5959 (ChangeMaster.eventGenerator): yield Changes, since there are now
5960 Adapters to turn them into HTML boxes
5962 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5963 (BotPerspective.attached): feed a SlaveStatus object
5964 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5965 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5967 * buildbot/interfaces.py: API additions
5968 (ISlaveStatus): place to get slave status
5970 2004-08-04 Brian Warner <warner@lothar.com>
5972 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5973 the delay finishes, so the step is marked as SUCCESS
5975 * buildbot/test/test_run.py (Status.testSlave): cover more of
5976 IBuildStatus and IBuildStepStatus
5978 * buildbot/status/progress.py (StepProgress): move some flags to
5979 class-level attributes
5980 (StepProgress.remaining): if there are no other progress metrics
5981 to go by, fall back to elapsed time
5982 (StepProgress.setExpectations): take a dict of metrics instead of
5984 (BuildProgress.setExpectationsFrom): pull expectations from the
5985 Expectations, instead of having it push them to the BuildProgress
5986 (Expectations): move some flags to class-level attributes
5987 (Expectations.__init__): copy per-step times from the
5989 (Expectations.expectedBuildTime): new method for per-build ETA
5991 * buildbot/status/event.py (Logfile): move some flags to
5992 class-level attributes
5993 (Logfile.logProgressTo): better method name, let step set the
5994 progress axis name (instead of always being "output")
5996 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5997 times directly, rather than depending upon the (possibly missing)
5998 .progress object. Use 'None' to indicate "not started/finished
6000 (BuildStepStatus.getExpectations): oops, return the full list of
6002 (BuilderStatus._buildFinished): append finished builds to .builds
6004 * buildbot/process/step.py (BuildStep): add separate .useProgress
6005 flag, since empty .progressMetrics[] still implies that time is a
6007 (CVS): set up the cmd in __init__, instead of waiting for start()
6009 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6010 calculation, this will eventually turn into a proper sourceStamp
6011 (Build.setupBuild): tell the Progress to load from the Expectations,
6012 instead of having the Expectations stuff things into the Progress
6013 (Build.buildException): add a build-level errback to make sure the
6014 build's Deferred fires even in case of exceptions
6016 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6018 * buildbot/process/builder.py (Builder.forceBuild): convey the
6019 reason instead of creating a fake Change
6021 * docs/examples/twisted_master.cfg: update to match reality
6023 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6024 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6025 fix or remove broken/breaking tests
6027 * buildbot/status/event.py (Logfile.__len__): remove evil method
6029 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6030 missing .build, for test convenience
6032 * buildbot/process/step_twisted.py: import fixes
6034 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6036 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6037 .statusbag reference
6039 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6040 connection at shutdown, and stop it from reconnecting
6042 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6043 chase down remote-execution bugs
6045 * buildbot/process/step.py: more fixes, remove
6046 BuildStep.setStatus()
6047 * buildbot/status/builder.py: move setStatus() functionality into
6049 * buildbot/status/event.py: minor fixes
6051 2004-08-03 Brian Warner <warner@lothar.com>
6053 * buildbot/process/base.py, buildbot/process/builder.py
6054 * buildbot/process/step.py, buildbot/status/builder.py
6055 * buildbot/status/event.py, buildbot/test/test_run.py:
6056 fix status delivery, get a basic test case working
6057 * buildbot/master.py: finish implementing basic status delivery,
6058 temporarily disable HTML/IRC/PB status sources
6060 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6062 * buildbot/status/progress.py (BuildProgress): remove dead code
6064 * buildbot/interfaces.py
6065 * buildbot/process/base.py, buildbot/process/builder.py
6066 * buildbot/process/step.py, buildbot/process/step_twisted.py
6067 * buildbot/status/builder.py: Complete overhaul of the all
6068 status-delivery code, unifying all types of status clients (HTML,
6069 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6070 look like. This commit is a checkpointing of the work-in-progress:
6071 the input side is mostly done (Builders/Builds sending status
6072 to the BuilderStatus/BuildStatus objects), but the output side has
6073 not yet been started (HTML resources querying BuilderStatus
6074 objects). Things are probably very broken right now and may remain
6075 so for several weeks, I apologize for the disruption.
6077 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6078 HTML as the log's contents. Currently used for exception tracebacks.
6079 * buildbot/status/progress.py: minor spelling changes
6081 2004-08-02 Brian Warner <warner@lothar.com>
6083 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6084 in mozilla. Also added stylesheets copied from Twisted's docs.
6085 Remember that these files are meant to be run through Lore first.
6086 Thanks to Philipp Frauenfelder for the fixes.
6087 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6088 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6089 * docs/template.tpl: added a Lore template
6091 2004-07-29 Brian Warner <warner@lothar.com>
6093 * buildbot/interfaces.py: revamp status delivery. This is the
6094 preview: these are the Interfaces that will be provided by new
6095 Builder code, and to which the current HTML/IRC/PB status
6096 displayers will be adapted.
6098 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6099 on the SlaveBuilder, not the Bot.
6100 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6102 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6103 set .usePTY on the FakeSlaveBuilder
6105 2004-07-25 Brian Warner <warner@lothar.com>
6107 * buildbot/changes/freshcvs.py: add some debug log messages
6108 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6109 disabled 'setFilter' syntax
6110 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6111 don't end with a slash
6113 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6115 * setup.py: bump to 0.5.0+ while between releases
6117 2004-07-23 Brian Warner <warner@lothar.com>
6119 * setup.py (version): Releasing buildbot-0.5.0
6121 2004-07-23 Brian Warner <warner@lothar.com>
6123 * README: update for 0.5.0 release
6125 * NEWS: update for 0.5.0 release
6127 2004-07-22 Brian Warner <warner@lothar.com>
6129 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6130 mktap-time configuration flag (--usepty=1, --usepty=0)
6131 * buildbot/bot.py: same
6133 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6134 an 'info' directory being unwanted
6136 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6137 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6138 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6139 and earlier), use a FreshCVSSourceOldcred instead.
6140 (test): simple test routine: connect to server, print changes
6142 * buildbot/changes/changes.py (Change.getTime): make it possible
6143 to print un-timestamped changes
6145 * buildbot/master.py (makeApp): delete ancient dead code
6146 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6147 * buildbot/test/test_config.py (testFindConfigFile): test it
6149 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6150 instead of win32 one
6153 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6154 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6157 * buildbot/process/base.py (Builder.__init__): change constructor
6158 to accept a dictionary of config data, rather than discrete
6159 name/slave/builddir/factory arguments
6161 * docs/examples/twisted_master.cfg: update to new syntax
6162 * docs/examples/glib_master.cfg: same
6163 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6164 rough tests of the new syntax
6167 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6168 to be an int, which means "run a web.distrib sub-server on a TCP
6169 port". This lets you publish the buildbot status page to a remote
6170 twisted.web server (using distrib.ResourceSubscription). Also
6171 rename the local attributes used to hold these web things so
6172 they're more in touch with reality.
6173 * buildbot/test/test_web.py: test webPortnum and webPathname
6174 * docs/config.xhtml: document this new use of webPathname
6176 * docs/config.xhtml: new document, slightly ahead of reality
6178 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6179 'prefix' handling: treat it as a simple string to check with
6180 .startswith, instead of treating it as a directory. This allows
6181 sub-directories to be used. If you use prefix=, you should give it
6182 a string that starts just below the CVSROOT and ends with a slash.
6183 This prefix will be stripped from all filenames, and filenames
6184 which do not start with it will be ignored.
6186 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6188 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6189 and --exclude (inverse of --include). SVN post-commit hooks
6190 now have total control over which changes get sent to buildbot and which
6193 2004-07-10 Brian Warner <warner@lothar.com>
6195 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6196 test case to match new API
6198 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6199 which crashed HTML display when self.entries=[] (needed to
6200 distinguish between [], which means "no entries yet", and None,
6201 which means "the entries have been swapped out to disk, go fetch
6204 2004-07-04 Brian Warner <warner@lothar.com>
6206 * buildbot/process/step_twisted.py (countFailedTests): Count
6207 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6208 10kb from the end because any import errors are wedged there and
6209 they would make us think the test log was unparseable.
6210 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6212 2004-06-26 Brian Warner <warner@lothar.com>
6214 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6215 delete-*.pyc command into an actual BuildStep, so we can label it
6217 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6218 (FullTwistedBuildFactory): same
6220 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6222 * contrib/fakechange.py: Add an errback when sending the fake
6223 change, so we know it didn't work.
6225 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6227 * buildbot/process/step_twisted.py: Delete *.pyc files before
6228 calling trial, so it doesn't catch any old .pyc files whose .py
6229 files have been moved or deleted.
6231 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6232 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6233 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6234 instead of ["twisted.test"], so that the end result is "trial -R
6237 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6238 regular expression to match filenames that should be ignored when
6239 changed. Also add a --revision parameter that specifies the
6240 revision to examine, which is useful for debugging.
6242 2004-06-25 Brian Warner <warner@lothar.com>
6244 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6245 summary of warnings (like DeprecationWarnings), next to the
6248 2004-05-13 Brian Warner <warner@lothar.com>
6250 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6251 we now have a w32 build slave courtesy of Mike Taylor.
6253 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6254 so broken. Fixed a race condition that tripped up interlocked
6255 builds and caused the status to be stuck at "Interlocked" forever.
6256 The twisted buildbot's one interlocked build just so happened to
6257 never hit this case until recently (the feeding builds both pass
6258 before the interlocked build is attempted.. usually it has to wait
6260 (Builder._pong_failed): fix method signature
6262 * setup.py: bump to 0.4.3+ while between releases
6264 2004-04-30 Brian Warner <warner@lothar.com>
6266 * setup.py (version): Releasing buildbot-0.4.3
6268 2004-04-30 Brian Warner <warner@lothar.com>
6270 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6272 * README: update for 0.4.3 release
6274 * NEWS: update for 0.4.3 release
6276 * buildbot/master.py (BuildMaster.__getstate__): make sure
6277 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6279 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6280 .trial as a class attribute, for upgrade from 0.4.2
6282 * buildbot/changes/changes.py (Change.links): add .links for
6285 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6286 .textWatchers and .htmlWatchers at save time, since they are both
6287 volatile, should allow smooth 0.4.2 upgrade
6289 * buildbot/process/step.py (CVS.finishStatus): catch failed
6290 CVS/SVN commands so we can make the status box red
6292 2004-04-29 Brian Warner <warner@lothar.com>
6294 * buildbot/changes/freshcvs.py
6295 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6296 code to do setFilter(), which tells the freshcvs daemon to not
6297 send us stuff that we're not interested in. I will uncomment it
6298 when a new version of CVSToys is available in which setFilter()
6299 actually works, and I get a chance to test it better.
6301 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6303 * buildbot/master.py (Dispatcher): use a registration scheme
6304 instead of hardwired service names
6305 (BuildMaster): keep track of the Dispatcher to support
6308 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6309 PBChangeSource class instead of having it be an undocumented
6310 internal feature of the ChangeMaster. Split out the code into a
6312 * buildbot/changes/pb.py (PBChangeSource): same
6313 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6315 * docs/{factories|sources|steps}.xhtml: document some pieces
6317 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6318 using FCMaildirSource
6319 (f23osx): update OS-X builder to use python2.3, since the slave
6320 was updated to Panther (10.3.3)
6322 2004-03-21 Brian Warner <warner@lothar.com>
6324 * buildbot/process/process_twisted.py: factor out doCheckout, change
6325 to use SVN instead of CVS
6327 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6328 an SVN subclass easier
6329 (BasicSVN): subclass which uses Subversion instead of CVS
6331 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6333 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6335 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6337 2004-02-25 Brian Warner <warner@lothar.com>
6339 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6340 is now either a list (which is passed to spawnProcess directly) or
6341 a string (which gets passed to /bin/sh -c). This removes the useSH
6342 flag and the ArgslistCommand class. Also send status header at the
6343 start and end of each command, instead of having the master-side
6345 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6346 -r'. Update to use list-based arguments.
6347 (SVNFetch): use list-based arguments, use ['dir'] argument to
6349 * buildbot/test/test_steps.py (Commands): match changes
6351 * buildbot/process/step.py (InternalShellCommand.words): handle
6353 (SVN): inherit from CVS, cleanup
6355 * buildbot/status/event.py (Logfile.content): render in HTML, with
6356 stderr in red and headers (like the name of the command we're
6357 about to run) in blue. Add link to a second URL (url + "?text=1")
6358 to get just stdout/stderr in text/plain without markup. There is
6359 still a problem with .entries=None causing a crash, it seems to occur
6360 when the logfile is read before it is finished.
6362 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6363 timeout to the keepalives, and use it to explicitly do a
6364 loseConnection instead of waiting for TCP to notice the loss. This
6365 ought to clear up the silent-lossage problem.
6366 (unsafeTracebacks): pass exception tracebacks back to the master,
6367 makes it much easier to debug problems
6369 2004-02-23 Brian Warner <warner@lothar.com>
6371 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6372 the whole command to /bin/sh instead of execve [Johan Dahlin]
6373 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6374 '-r HEAD' [Johan Dahlin]
6375 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6377 * buildbot/changes/changes.py (Change): add links= argument, add
6378 asHTML method [Johan Dahlin]. Modified to make a bit more
6379 XHTMLish. Still not sure how to best use links= .
6381 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6382 Change.asHTML to display the change, not asText
6384 * buildbot/status/html.py (StatusResourceBuilder): web button to
6387 * buildbot/test/test_run.py: test to actually start a buildmaster
6390 * MANIFEST.in: bring back accidentally-dropped test helper files
6392 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6393 that require cvstoys if it is not installed
6395 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6396 values of "bin/trial" [Dave Peticolas]
6397 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6398 tests passed" when we didn't happen to run any tests
6400 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6401 flunkOnFailure [Johan Dahlin]
6403 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6404 multiple instances of the same Step class by suffixing "_2", etc,
6405 to the name until it is unique. This name needs to be unique
6406 because it is used as a key in the dictionary that tracks build
6408 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6411 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6413 2004-01-14 Brian Warner <warner@lothar.com>
6415 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6416 kicked from a channel, log it
6418 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6419 something over whatever IRC channels the buildmaster is currently
6420 connected to. Added to try and track down a problem in which the
6421 master thinks it is still connected but the IRCd doesn't see it. I
6422 used a styles.Versioned this time, so hopefully users won't have
6423 to rebuild their .tap files this time.
6424 * contrib/debug.glade: add a "Poke IRC" button
6425 * contrib/debugclient.py: same
6427 * setup.py: bump to 0.4.2+ while between releases
6429 2004-01-08 Brian Warner <warner@lothar.com>
6431 * setup.py (version): Releasing buildbot-0.4.2
6433 2004-01-08 Brian Warner <warner@lothar.com>
6435 * NEWS: update for 0.4.2 release
6437 * README: document how to run the tests, now that they all pass
6439 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6441 * buildbot/process/step.py (CVS): add a global_options= argument,
6442 which lets you set CVS global options for the command like "-r"
6443 for read-only checkout, or "-R" to avoid writing in the
6445 * buildbot/slavecommand.py (CVSCommand): same
6447 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6448 testing easier (it is turned off when testing, to avoid the
6451 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6452 to make it easier to test: break generateStepID() out to a
6453 separate function, only update statusbag if it exists.
6454 (ShellCommands): create useful text for dict-based commands too.
6456 * test/*, buildbot/test/*: move unit tests under the buildbot/
6458 * setup.py (packages): install buildbot.test too
6460 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6461 * buildbot/test/test_steps.py: fix it, tests pass now
6463 2004-01-06 Brian Warner <warner@lothar.com>
6465 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6466 freshcvs mail uses a slightly different syntax for new
6467 directories. Update parser to handle either.
6468 * test/test_mailparse.py (Test1.testMsg9): test for same
6470 2003-12-21 Brian Warner <warner@lothar.com>
6472 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6473 'warnOnWarnings' so that lintian errors mark the build orange
6475 2003-12-17 Brian Warner <warner@lothar.com>
6477 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6478 messages emitted by Bonsai, contributed by Stephen Davis.
6480 * test/*: moved all tests to use trial instead of unittest. Some
6481 still fail (test_steps, test_slavecommand, and test_process).
6483 * setup.py (version): bump to 0.4.1+ while between releases
6485 2003-12-09 Brian Warner <warner@lothar.com>
6487 * setup.py (version): Releasing buildbot-0.4.1
6489 2003-12-09 Brian Warner <warner@lothar.com>
6491 * NEWS: update for 0.4.1 release
6493 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6494 freebsd builder code a little bit
6496 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6497 don't try to compare attributes of different classes
6498 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6499 (MaildirSource.messageReceived): fix Change delivery
6501 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6502 into the config file's namespace before loading it, like the
6503 documentation claims it does
6504 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6505 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6506 daemon comes back online
6508 2003-12-08 Brian Warner <warner@lothar.com>
6510 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6511 so the example will work with online=0 as well
6513 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6514 fix the __implements__ line
6516 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6517 class a twisted.application.service.Service, use startService to
6520 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6521 directory fd instead of simple open(). I'm sure this used to work,
6522 but the current version of python refuses to open directories with
6525 2003-12-05 Brian Warner <warner@lothar.com>
6527 * setup.py (version): bump to 0.4.0+ while between releases
6529 2003-12-05 Brian Warner <warner@lothar.com>
6531 * setup.py (version): Releasing buildbot-0.4.0
6533 2003-12-05 Brian Warner <warner@lothar.com>
6535 * docs/examples/glib_master.cfg: replace old sample scripts with
6536 new-style config files
6537 * MANIFEST.in: include .cfg files in distribution tarball
6539 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6540 implement a dummy method to avoid the exception that occurs when
6541 freshcvs sends this to us.
6543 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6544 removed the method, as it broke reconnection. Apparently
6545 stopFactory is called each time the connection attempt fails. Must
6547 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6548 attribute before serialization, since without stopFactory the
6549 reconnect timer may still be active and they aren't serializable.
6551 * test/test_mailparse.py (ParseTest): test with 'self' argument
6553 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6554 argument, as these "functions" are invoked like methods from class
6555 attributes and therefore always get an instance as the first
6558 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6559 message: thanks to Stephen Davis for the catch
6561 2003-12-04 Brian Warner <warner@lothar.com>
6563 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6564 twisted's standard ReconnectingClientFactory. Handles both oldcred
6565 and newcred connections. Also has a bug-workaround for
6566 ReconnectingClientFactory serializing its connector when it
6569 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6570 pbutil. Replace makeApp stuff with proper newcred/mktap
6571 makeService(). Don't serialize Ephemerals on shutdown.
6573 * buildbot/changes/changes.py (ChangeMaster): make it a
6574 MultiService and add the sources as children, to get startService
6575 and stopService for free. This also gets rid of the .running flag.
6577 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6578 new pbutil, turn into a TCPClient at the same time (to get
6579 startService for free). Two variants exist: FreshCVSSourceOldcred
6580 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6581 yet, but when it does, we'll be ready).
6582 (FreshCVSSource.notify): handle paths which are empty after the
6583 prefix is stripped. This only happens when the top-level (prefix)
6584 directory is added, at the very beginning of a Repository's life.
6586 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6587 Now the only reconnecting code is in the factory where it belongs.
6588 (Builder.unsubscribe): unregister the disconnect callback when we
6589 delete the builder on command from the master (i.e. when the
6590 buildmaster is reconfigured and that builder goes away). This
6591 fixes a multiple-delete exception when the status client is shut
6593 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6596 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6597 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6599 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6601 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6602 a list of globs (ugh). The testdir will be searched for files
6603 named *.tests and run the tests in the order specified in each of
6604 those files. This allows for "dependancies" between tests to be
6607 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6608 argument to pass to run_maxq.py, instead of a glob.
6610 2003-10-17 Brian Warner <warner@lothar.com>
6612 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6613 files that live in the sandbox
6615 2003-10-15 Brian Warner <warner@lothar.com>
6617 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6618 spelling error in "docs" count-warnings output
6619 (HLint.start): stupid thinko meant .xhtml files were ignored
6621 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6622 tests now that cReactor is banished to the sandbox
6624 2003-10-10 Brian Warner <warner@lothar.com>
6626 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6627 scheme: now .xhtml are sources and .html are generated
6629 2003-10-08 Brian Warner <warner@lothar.com>
6631 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6632 we were ignoring the 'randomly' parameter.
6634 2003-10-01 Brian Warner <warner@lothar.com>
6636 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6637 posix, to kill sub-children of aborted slavecommands.
6639 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6640 Clean up initialization: lastBuildStatus remains None until the
6641 first build has been completed.
6643 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6644 None as a lastBuildStatus
6645 * buildbot/clients/gtkPanes.py: same
6647 * buildbot/status/client.py (StatusClientService): keep
6648 BuilderStatus objects in self.statusbags . These objects now live
6649 here in the StatusClientService and are referenced by the Builder
6650 object, rather than the other way around.
6651 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6652 * buildbot/process/base.py (Builder): same
6653 * test/test_config.py (ConfigTest.testBuilders): same
6655 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6656 an existing builder, leave the statusbag alone. This will preserve the
6659 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6660 hook. This will probably go away in favor of a class in upcoming
6663 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6664 serviceName from newcred FreshCVSNotifiee setup
6666 2003-09-29 Brian Warner <warner@lothar.com>
6668 * buildbot/process/process_twisted.py: switch to new reactor
6670 * docs/examples/twisted_master.cfg: same
6672 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6674 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6675 botmaster reference instead of the oldapp service lookup
6677 * buildbot/master.py (BuildMaster.__init__): give the
6678 StatusClientService a reference to the botmaster to make it easier to
6681 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6683 * buildbot/status/html.py (Box.td): escape hreffy things so you
6684 can have spaces in things like builder names
6685 (StatusResourceBuilder.body)
6686 (WaterfallStatusResource.body)
6687 (WaterfallStatusResource.body0): same
6689 2003-09-25 Brian Warner <warner@lothar.com>
6691 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6692 rearrange the builder list when adding or removing builders: keep
6693 them in the order the user requested.
6694 * test/test_config.py (ConfigTest.testBuilders): verify it
6696 * contrib/debug.glade: give the debug window a name
6698 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6699 now wait on multiple interlocks. Fix code relating to that.
6700 (Builder.checkInterlocks): same
6701 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6703 * buildbot/master.py (BuildMaster.loadConfig): move from
6704 deprecated pb.BrokerFactory to new pb.PBServerFactory
6705 * test/test_config.py (ConfigTest.testWebPathname): same
6707 * docs/examples/twisted_master.cfg: fix interlock declaration
6709 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6710 Interlocks to their Builders into interlock.py .
6711 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6713 * test/test_config.py (ConfigTest.testInterlocks): validate
6716 * buildbot/process/base.py (Builder.__init__): better comments
6717 * buildbot/process/interlock.py (Interlock.__repr__): same
6718 (Interlock.deactivate): add .active flag, move the code that
6719 attaches/detaches builders into the Interlock
6721 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6723 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6724 tests using the new run_maxq.py script, and reporting failures by
6727 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6728 tests, reporting their success or failure in a buildbot-friendly
6731 2003-09-24 Brian Warner <warner@lothar.com>
6733 * docs/examples/twisted_master.cfg: example of a new-style config
6734 file. This lives in the buildmaster base directory as
6737 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6738 button to make the master re-read its config file
6740 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6741 buildmaster configuration from a file. This file can be re-read
6742 later, and the buildmaster will update itself to match the new
6743 desired configuration. Also use new Twisted Application class.
6744 * test/Makefile, test/test_config.py: unit tests for same
6746 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6747 FreshCVSSources comparable, to support reload.
6748 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6750 * buildbot/process/base.py (Builder): make them comparable, make
6751 Interlocks easier to attach, to support reload. Handle
6752 re-attachment of remote slaves.
6753 * buildbot/process/interlock.py (Interlock): same
6755 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6756 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6757 buildmaster taps are now constructed with mktap.
6758 * buildbot/status/client.py (StatusClientService): same
6760 * buildbot/status/words.py: move to new Services, add support to
6761 connect to multiple networks, add reload support, allow nickname
6762 to be configured on a per-network basis
6764 2003-09-20 Brian Warner <warner@lothar.com>
6766 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6767 the freebsd builder, now that the machine has been upgraded and no
6768 longer has python2.2
6770 * setup.py (version): bump to 0.3.5+ while between releases
6772 2003-09-19 Brian Warner <warner@lothar.com>
6774 * setup.py (version): Releasing buildbot-0.3.5
6776 2003-09-19 Brian Warner <warner@lothar.com>
6778 * NEWS: add post-0.3.4 notes
6780 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6782 * MANIFEST.in: add contrib/*
6784 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6785 use a remote root now: cvs.twistedmatrix.com
6787 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6789 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6790 compatibility with old servers
6791 (FreshCVSSource.start): and provide a way to use it
6792 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6794 * docs/examples/twisted_master.py (twisted_app): update to new
6796 (twisted_app): listen on new ~buildbot socket
6797 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6799 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6800 to reduce cvs bandwidth (update instead of full checkout)
6802 2003-09-11 Brian Warner <warner@lothar.com>
6804 * contrib/fakechange.py: demo how to connect to the changemaster
6805 port. You can use this technique to submit changes to the
6806 buildmaster from source control systems that offer a hook to run a
6807 script when changes are committed.
6809 * contrib/debugclient.py: tool to connect to the debug port. You
6810 can use it to force builds, submit fake changes, and wiggle the
6813 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6814 'Dispatcher' realm to handle all the different kinds of
6815 connections and Perspectives: buildslaves, the changemaster port,
6816 the debug port, and the status client port. NewCredPerspectives
6817 now have .attached/.detached methods called with the remote 'mind'
6818 reference, much like old perspectives did. All the pb.Services
6819 turned into ordinary app.ApplicationServices .
6820 (DebugService): went away, DebugPerspectives are now created
6821 directly by the Dispatcher.
6822 (makeApp): changed interface a little bit
6824 * buildbot/changes/changes.py: newcred
6825 * buildbot/status/client.py: newcred
6827 * buildbot/clients/base.py: newcred client side changes
6828 * buildbot/bot.py: ditto
6830 * docs/examples/glib_master.py: handle new makeApp() interface
6831 * docs/examples/twisted_master.py: ditto
6833 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6834 base newcred Perspectives on. This should go away once Twisted
6835 itself provides something sensible.
6838 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6840 * contrib/svn_buildbot.py: A program that you can call from your
6841 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6842 when a change in an SVN repository has happened. See the top of
6843 the file for some minimal usage info.
6845 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6847 * buildbot/slavecommand.py (ArglistCommand): Add new
6848 ArglistCommand that takes an argument list rather than a string as
6849 a parameter. Using a st.split() for argv is very bad.
6851 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6852 update to a particular revision rather than always checking out
6853 (still not very smart about it, there may be cases where the
6854 checkout becomes inconsistent).
6856 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6858 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6859 SVN fetch support. It can checkout (not update!) a specified
6860 revision from a specified repository to a specified directory.
6862 * buildbot/status/progress.py (Expectations.update): Fix an
6863 obvious bug (apparently created by the change described in the
6864 previous ChangeLog message) by moving a check to *after* the
6865 variable it checks is defined.
6868 2003-09-08 Brian Warner <warner@lothar.com>
6870 * buildbot/status/progress.py (Expectations.update): hack to catch
6871 an exception TTimo sees: sometimes the update() method seems to
6872 get called before the step has actually finished, so the .stopTime
6873 is not set, so no totalTime() is available and we average None
6874 with the previous value. Catch this and just don't update the
6875 metrics, and emit a log message.
6877 2003-08-24 Brian Warner <warner@lothar.com>
6879 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6880 parameter to set copydir='original' in CVS commands.
6882 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6884 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6885 which tells the command to maintain a separate original-source CVS
6886 workspace. For each build, this workspace will be updated, then
6887 the tree copied into a new workdir. This reduces CVS bandwidth
6888 (from a full checkout to a mere update) while doubling the local
6889 disk usage (to keep two copies of the tree).
6891 2003-08-21 Brian Warner <warner@lothar.com>
6893 * buildbot/status/event.py (Logfile.addEntry): if the master web
6894 server dies while we're serving a page, request.write raises
6895 pb.DeadReferenceError . Catch this and treat it like a
6896 notifyFinish event by dropping the request.
6898 2003-08-18 Brian Warner <warner@lothar.com>
6900 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6901 (instead of blowing up) if a force-build command is given without
6904 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6905 don't blow up if there aren't yet any Changes in the list
6907 2003-08-02 Brian Warner <warner@lothar.com>
6909 * buildbot/bot.py (updateApplication): don't set the .tap name,
6910 since we shouldn't assume we own the whole .tap file
6912 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6913 'mktap buildbot' (without a subcommand) better
6915 2003-07-29 Brian Warner <warner@lothar.com>
6917 * buildbot/status/words.py
6918 (IrcStatusFactory.clientConnectionLost): when we lose the
6919 connection to the IRC server, schedule a reconnection attempt.
6921 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6922 use shutil.rmtree instead of forking off an "rm -rf" command.
6923 rmtree may take a while and will block until it finishes, so we
6924 use "rm -rf" if available.
6926 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6927 freebsd buildslave badly
6929 * setup.py (version): bump to 0.3.4+ while between releases
6931 2003-07-28 Brian Warner <warner@lothar.com>
6933 * setup.py (version): Releasing buildbot-0.3.4
6935 2003-07-28 Brian Warner <warner@lothar.com>
6937 * NEWS: update in preparation for release
6939 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6940 process.signalProcess instead of os.kill, to improve w32
6943 * docs/examples/twisted_master.py (twisted_app): turn off
6944 win32eventreactor: the tests hang the buildslave badly
6946 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6947 failed builds, since usually the failures are consistent
6949 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6950 add compileOpts/compileOpts2 to reactors build
6952 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6953 (twisted_app): use both default and win32eventreactor on w32 build.
6954 Use both default and kqreactor on freebsd build.
6956 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6957 add compileOpts2, which is put after the build_ext argument. w32
6958 needs "-c mingw32" here.
6960 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6961 touch .acqpath, it goes away in recent Twisted releases
6963 * docs/examples/twisted_master.py (twisted_app): use "python" for
6964 the w32 buildslave, not "python2.2"
6966 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6967 the directory exists.. should hush an exception under w32
6969 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6970 ProcessTerminated -provided values for signal and exitCode rather
6971 than parsing the unix status code directly. This should remove one
6972 more roadblock for a w32-hosted buildslave.
6974 * test/test_mailparse.py: add test cases for Syncmail parser
6976 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6977 temporary compatibility import. Note! Start importing
6978 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6980 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6982 2003-07-27 Brian Warner <warner@lothar.com>
6984 * NEWS: started adding new features
6986 * buildbot/changes/mail.py: start work on Syncmail parser, move
6987 mail sources into their own file
6989 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6990 as implementing IChangeSource
6991 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6993 * buildbot/interfaces.py: define the IChangeSource interface
6995 2003-07-26 Brian Warner <warner@lothar.com>
6997 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6999 2003-06-25 Brian Warner <warner@lothar.com>
7001 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7004 2003-06-17 Brian Warner <warner@lothar.com>
7006 * buildbot/status/words.py: clean up method usage to avoid error
7007 in silly IRC command
7008 (IrcStatusBot.emit_status): round off seconds display
7010 * buildbot/process/base.py (Build): delete the timer when saving
7011 to the .tap file, and restore it (if it should still be running)
7012 upon restore. This should fix the "next build in -34 seconds"
7013 messages that result when the master is restarted while builds are
7014 sitting in the .waiting slot. If the time for the build has
7015 already passed, start it very soon (in 1 second).
7017 * buildbot/status/words.py: more silly commands
7019 * README (REQUIREMENTS): add URLs to all required software
7021 * buildbot/status/words.py ('last'): mention results of, and time
7024 2003-05-28 Brian Warner <warner@lothar.com>
7026 * buildbot/status/words.py: add 'last' command
7027 (IrcStatusBot.emit_status): add current-small text to 'status' output
7029 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7030 (twisted_app): remove spaces from OS-X builder name
7032 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7033 * buildbot/status/words.py: IRC bot should actually be useful now
7035 2003-05-23 Brian Warner <warner@lothar.com>
7037 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7038 "slave information" from $(slavedir)/info/* . These files are
7039 maintained by the slave administrator, and describe the
7040 machine/environment that is hosting the slave. Information from
7041 them is put into the "Builder" HTML page. Still need to establish
7042 a set of well-known filenames and meanings for this data: at the
7043 moment, *all* info/* files are sent to the master, but only
7044 'admin' and 'host' are used on that end.
7045 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7046 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7047 * buildbot/master.py (BotPerspective.got_info): ditto
7049 2003-05-22 Brian Warner <warner@lothar.com>
7051 * setup.py (version): bump version to 0.3.3+ while between releases
7053 2003-05-21 Brian Warner <warner@lothar.com>
7055 * setup.py: Releasing buildbot-0.3.3
7057 2003-05-21 Brian Warner <warner@lothar.com>
7059 * NEWS: 0.3.3 news items
7061 * README: describe --keepalive and life behind a NAT box
7063 * buildbot/bot.py (Bot.connected): implement application-level
7064 keepalives to deal with NAT timeouts, turn them on with
7065 --keepalive option or when SO_KEEPALIVE doesn't work.
7067 * buildbot/master.py (BotPerspective): accept keepalives silently
7069 * buildbot/process/base.py (Build.buildException): CopiedFailures
7070 don't carry as much information as local ones, so don't try to
7071 create a big HTMLized version of them.
7073 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7074 log file when step fails due to an exception, such as when the slave
7077 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7078 --testmodule argument instead of grepping for test-case-name tags
7079 ourselves. Remove FindUnitTests code.
7080 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7082 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7084 2003-05-16 Brian Warner <warner@lothar.com>
7086 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7087 argument to allow things like CFLAGS=-O0 to be passed without relying
7088 upon /bin/sh processing on the slave.
7090 * buildbot/process/step.py (InternalShellCommand.start): send
7092 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7093 'split' instead of letting /bin/sh do it. This should also remove
7094 the need for /bin/sh on the buildslave, making it more likely to
7097 * buildbot/status/html.py: html-escape text in blamelist.
7098 Add "force build" button to the Builder page.
7100 * buildbot/process/step_twisted.py (countFailedTests): look at
7101 last 1000 characters for status line, as import errors can put it
7102 before the -200 point.
7104 2003-05-15 Brian Warner <warner@lothar.com>
7106 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7108 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7109 make 'clobber' a parameter, so it is possible to have builds which
7110 do full tests but do a cvs update instead of hammering the CVS
7111 server with a full checkout each build
7113 * buildbot/process/step.py (InternalShellCommand): bump default
7114 timeout to 20 minutes
7116 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7117 the master to trigger a build. Run it via manhole.
7119 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7120 allow slaves to trigger any build that they host, to make life
7121 easier for slave admins who are testing out new build processes
7123 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7124 don't flunk cReactor or qtreactor on failure, since they fail alot
7125 these days. Do warnOnFailure instead.
7127 * buildbot/process/base.py: change Builder.buildable from a list
7128 into a single slot. When we don't have a slave, new builds (once
7129 they make it past the timeout) are now merged into an existing
7130 buildable one instead of being queued. With this change, a slave
7131 which has been away for a while doesn't get pounded with all the
7132 builds it missed, but instead just does a single build.
7134 2003-05-07 Brian Warner <warner@lothar.com>
7136 * setup.py (version): bump version to 0.3.2+ while between releases
7138 2003-05-07 Brian Warner <warner@lothar.com>
7140 * setup.py: Releasing buildbot-0.3.2
7142 2003-05-07 Brian Warner <warner@lothar.com>
7144 * setup.py: fix major packaging error: include subdirectories!
7146 * NEWS: add changes since last release
7148 * README (REQUIREMENTS): update twisted/python dependencies
7150 * buildbot/status/builder.py (Builder.startBuild): change
7151 BuildProcess API: now they should call startBuild/finishBuild
7152 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7153 keeping a list of builds in the statusbag, to support other kinds of
7155 (Builder.addClient): send current-activity-small to new clients
7156 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7159 * buildbot/status/client.py: drop RemoteReferences at shutdown
7161 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7163 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7164 more debug messages for remote status client
7166 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7167 (.stepFailed): only fire the Deferred once, even if both
7168 stepComplete and stepFailed are called. I think this can happen if
7169 an exception occurs at a weird time.
7171 * buildbot/status/words.py: work-in-progress: IRC status delivery
7173 2003-05-05 Brian Warner <warner@lothar.com>
7175 * docs/examples/twisted_master.py (twisted_app): hush internal
7176 python2.3 distutils deprecation warnings
7177 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7178 add compileOpts= argument which inserts extra args before the
7179 "setup.py build_ext" command. This can be used to give -Wignore
7180 warnings, to hush some internal python-2.3 deprecation messages.
7182 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7183 the ['twisted.test'] default test case to make it easier to change
7186 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7187 * buildbot/clients/gtkPanes.py: ditto
7189 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7190 arg to collapse RunUnitTestsRandomly into RunUnitTests
7191 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7192 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7194 * buildbot/status/html.py (StatusResource): shuffle Resources
7195 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7196 would serve the waterfall display, but the internal links were
7197 only valid on the trailing-slash version. The correct behavior is
7198 for the non-slashed one to serve a Redirect to the slashed one.
7199 This only shows up when the buildbot page is hanging off another
7200 server, like a Twisted-Web distributed server.
7202 * buildbot/status/event.py (Event, RemoteEvent): make Events
7203 pb.Cacheable, with RemoteEvent as the cached version. This removes
7204 a lot of explicit send-an-update code.
7205 * buildbot/status/builder.py (Builder): remove send-update code
7206 * buildbot/status/client.py (ClientBuilder): remove send-update
7207 code, and log errors that occur during callRemote (mostly to catch
7208 InsecureJelly exceptions)
7210 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7211 run Lore with the same python used in the rest of the build
7213 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7215 * buildbot/process/step_twisted.py (HLint): accept 'python'
7216 argument. Catch rc!=0 and mark the step as failed. This marks the
7217 build orange ("has warnings").
7218 (RunUnitTestsJelly): move out to step_twisted2.py
7220 * buildbot/util.py (ignoreStaleRefs): add utility function
7222 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7223 don't fake ETA object, it's too hard to get right
7225 2003-05-02 Brian Warner <warner@lothar.com>
7227 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7229 2003-05-01 Brian Warner <warner@lothar.com>
7231 * buildbot/status/html.py (StatusResource.body): oops, I was
7232 missing a <tr>, causing the waterfall page to be misrendered in
7233 everything except Galeon.
7235 2003-04-29 Brian Warner <warner@lothar.com>
7237 * docs/examples/twisted_master.py: make debuild use python-2.2
7238 explicitly, now that Twisted stopped supporting 2.1
7240 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7241 handle tuple results too. I keep forgetting this, which suggests
7242 it needs to be rethought.
7244 * setup.py (setup): bump version to 0.3.1+ while between releases
7246 2003-04-29 Brian Warner <warner@lothar.com>
7248 * setup.py: Releasing buildbot-0.3.1
7250 2003-04-29 Brian Warner <warner@lothar.com>
7252 * README (SUPPORT): add plea to send questions to the mailing list
7254 * NEWS, MANIFEST.in: add description of recent changes
7256 * docs/examples/twisted_master.py: add the code used to create the
7257 Twisted buildmaster, with passwords and such removed out to a
7260 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7261 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7262 buildmasters to not require CVSToys be installed.
7263 * README, docs/examples/glib_master: update to match the change
7265 * buildbot/clients/base.py, buildbot/bot.py,
7266 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7267 ReconnectingPB from CVSToys distribution to remove CVSToys
7268 dependency for build slaves and status clients. Buildmasters which
7269 use FreshCVSSources still require cvstoys be installed, of course.
7271 2003-04-25 Brian Warner <warner@lothar.com>
7273 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7274 runTestsRandomly arg to turn on trial -z
7276 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7277 experimental code to use trial's machine-parseable output to get
7278 more detailed test results. Still has some major issues.
7279 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7282 * buildbot/status/builder.py (Builder.setCurrentBuild):
7283 anticipating moving build history into statusbag, not used yet
7285 * buildbot/status/tests.py: code to centralize test results,
7286 doesn't work quite yet
7288 * buildbot/status/event.py (Event): use hasattr("setName") instead
7289 of isinstance for now.. need better long-term solution
7291 * buildbot/status/html.py: Remove old imports
7293 2003-04-24 Brian Warner <warner@lothar.com>
7295 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7296 ignore changes under doc/fun/ and sandbox/
7298 * buildbot/process/step_twisted.py: update pushEvent and friends.
7300 * buildbot/status/html.py (Box.td): replace event.buildername with
7301 event.parent.getSwappableName(). Needs more thought.
7303 * buildbot/status/builder.py (Builder): Replace pushEvent and
7304 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7305 Tell events they are being pruned with event.delete().
7307 * buildbot/process/base.py (Build): Remove Builder status-handling
7308 methods. s/pushEvent/setCurrentActivity/.
7310 * buildbot/process/step.py (BuildStep): clean up status delivery.
7311 Gouse builder.statusbag methods instead of intermediate builder
7312 methods. s/updateLastEvent/updateCurrentActivity/.
7313 s/finalizeLastEvent/finishCurrentActivity/. Use
7314 addFileToCurrentActivity for summaryFunction.
7316 * buildbot/status/event.py (Logfile): put data in a Swappable when
7318 (Event): add more setter methods. Remove .buildername, use .parent
7319 and getSwappableName instead (needs more thought).
7321 * buildbot/util.py (Swappable):
7322 * test/test_swap.py: don't bother setting filename at __init__
7323 time, do it later. Change setFilename args to take parent first,
7324 since it provides the most significant part of the filename.
7326 2003-04-23 Brian Warner <warner@lothar.com>
7328 * buildbot/status/event.py (Logfile.addEntry): append to previous
7331 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7332 anticipating Swappable
7333 (InternalShellCommand.remoteUpdate): split out various log-adding
7334 methods so subclasses can snarf stdout separately
7336 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7337 in anticipation of Swappable build logs
7338 (Builder.testsFinished): anticipating TestResults, still disabled
7340 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7343 * buildbot/status/event.py (Logfile): add (disabled) support for
7344 Swappable, not ready for use yet
7346 * buildbot/util.py (Swappable): object which is swapped out to
7347 disk after some period of no use.
7348 * test/test_swap.py: test buildbot.utils.Swappable
7350 2003-04-14 Brian Warner <warner@lothar.com>
7352 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7353 periodic-build timer. Set the .periodicBuildTime on a builder
7354 instance to some number of seconds to activate it.
7356 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7358 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7359 a way that survives result tuples
7361 2003-04-12 Brian Warner <warner@lothar.com>
7363 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7364 return a dict instead of a tuple: allow summarizers to provide
7365 multiple summaries if they want
7366 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7367 (debuildSummarizer): summarize lintian warnings/errors
7369 2003-04-10 Brian Warner <warner@lothar.com>
7371 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7373 2003-04-09 Brian Warner <warner@lothar.com>
7375 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7376 empty summaries: happens when the tests fail so hard they don't emit
7377 a parseable summary line.
7379 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7380 Allow summaryFunction to return None to indicate no summary should
7383 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7384 writing to stale HTTP requests: notice when they disconnect and
7385 remove the request from the list. Also add CacheToFile from
7386 moshez, will be used later.
7388 2003-04-08 Brian Warner <warner@lothar.com>
7390 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7391 should be an int, not a list of strings
7393 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7394 if we weren't actually connected
7396 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7397 to show the tail end of the trial text output
7399 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7400 hook to summarize the results of a ShellCommand
7402 2003-04-07 Brian Warner <warner@lothar.com>
7404 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7405 twisted test suite code into a single class.
7406 * buildbot/process/process_twisted.py: same
7408 2003-04-04 Brian Warner <warner@lothar.com>
7410 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7412 * README (SLAVE): document use of mktap to create slave .tap file
7413 (REQUIREMENTS): describe dependencies
7415 * buildbot/bb_tap.py, buildbot/plugins.tml:
7416 * buildbot/bot.py (updateApplication): Add mktap support for creating
7417 buildslave .tap files
7419 2003-03-28 Brian Warner <warner@lothar.com>
7421 * buildbot/process/step.py (InternalShellCommand.finished): handle
7422 new tuple result values (fix embarrasing bug that appeared during
7425 2003-03-27 Brian Warner <warner@lothar.com>
7427 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7430 2003-03-25 Brian Warner <warner@lothar.com>
7432 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7433 to overall build status
7434 * buildbot/clients/base.py (Builder): improve event printing
7435 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7436 instead of generic ShellCommand
7437 (Build): Add .stopBuild, use it when slave is detached
7439 * buildbot/process/step.py (Configure,Test): give the steps their
7440 own names and status strings
7442 * buildbot/status/html.py (StatusResource): add "show" argument,
7443 lets you limit the set of Builders being displayed.
7445 2003-03-20 Brian Warner <warner@lothar.com>
7447 * buildbot/process/basic.py: removed
7449 2003-03-19 Brian Warner <warner@lothar.com>
7451 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7452 turn off process-docs by default
7454 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7455 when displaying build information without anything in allBuilds[]
7457 * buildbot/bot.py (makeApp): really take password from sys.argv
7459 2003-03-18 Brian Warner <warner@lothar.com>
7461 * buildbot/bot.py (buildApp): take password from sys.argv
7463 * README: replace with more useful text
7465 * setup.py: add a real one
7466 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7468 * docs/PyCon-2003/: added sources for PyCon paper.
7470 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7471 now Build objects control the process and Builder only handles
7472 slave stuff and distribution of changes/status. A new BuildFactory
7473 class creates Build objects on demand.
7475 Created ConfigurableBuild which takes a list of steps to run. This
7476 makes it a lot easier to set up a new kind of build and moves us
7477 closer to being able to configure a build from a web page.
7479 * buildbot/process/step_twisted.py, process_twisted.py: move to
7480 new model. A lot of code went away.
7482 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7483 send lots of empty progress messages to the client.
7485 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7487 2003-02-20 Brian Warner <warner@lothar.com>
7489 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7491 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7492 Twisted bug that prevented non-pty processes from working just got
7493 fixed, and the bug that leaks ptys is still being investigated.
7495 * buildbot/process/step.py (CVS): send timeout arg to slave
7497 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7498 builders coming and going
7499 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7500 from CVSToys, handle lost-buildmaster
7502 * buildbot/status/client.py (StatusClientService.removeBuilder):
7503 Clean up status client protocol: send builders (with references)
7504 as they are created, rather than sending a list and requiring the
7505 client to figure out which ones are new.
7506 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7507 attempts to force a build on an unknown builder
7509 2003-02-19 Brian Warner <warner@lothar.com>
7511 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7512 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7513 Twisted stops leaking them.
7514 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7515 builder goes to an idle state.
7517 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7518 I figure out why CVS commands hang without them, and/or I fix the
7519 hung-command timeout
7521 2003-02-16 Brian Warner <warner@lothar.com>
7523 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7524 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7525 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7526 GenerateDocs now that they are prefixed with WARNING:.
7528 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7529 use manual href target instead of request.childLink
7531 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7532 display every second, but update the ETA every 5 seconds (or
7533 whenever) as remote_progress messages arrive.
7536 2003-02-12 Brian Warner <warner@lothar.com>
7538 * *: import current sources from home CVS repository
7542 # add-log-time-format: add-log-iso8601-time-string