1 2007-04-16 Brian Warner <warner@lothar.com>
3 * CREDITS: update list of contributors. Thank you all!
5 2007-04-13 Brian Warner <warner@lothar.com>
7 * buildbot/status/mail.py (MailNotifier): add the project name to
8 the subject line and message body, to make it easier to
9 distinguish email coming from different buildmasters. Thanks to
10 Benoit Sigoure for the patch.
11 * buildbot/test/test_status.py (Mail): update to match
13 2007-03-24 Brian Warner <warner@lothar.com>
15 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
16 avoid text-conversion problems between DOS/windows and unix.
17 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
19 2007-03-03 Brian Warner <warner@lothar.com>
21 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
22 warning about the use of Waterfall here
24 2007-03-01 Brian Warner <warner@lothar.com>
26 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
28 2007-02-28 Brian Warner <warner@lothar.com>
30 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
31 Lamb to use a more optimal form of 'p4 changes', to reduce server
32 load. He reports that this optimization was added to p4d release
33 2005.2, but it should work in all versions. Closes #27.
34 * buildbot/test/test_p4poller.py: match it
36 2007-02-27 Brian Warner <warner@lothar.com>
38 * buildbot/status/web/*.py: move all web status stuff into a
39 separate directory, in anticipation of splitting it into smaller
40 pieces and adding more files. html.py was getting way too big.
41 * buildbot/status/classic.css: move it too
42 * setup.py: add the new sub-package
43 * buildbot/test/test_web.py: match the changes
44 * MANIFEST.in: handle the move of classic.css
46 2007-02-07 Brian Warner <warner@lothar.com>
48 * contrib/OS-X/*: add some launchd .plist files for automatically
49 starting a buildmaster or buildslave under OS-X (10.4 or later).
50 Thanks to Mark Pauley for these.
52 2007-02-06 Brian Warner <warner@lothar.com>
54 * docs/buildbot.texinfo (Requirements): update requirements to
55 stop claiming compatibility with python-2.2 or twisted-1.3.x .
57 * README: mention python-2.5 and twisted-2.5 compatibility
59 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
61 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
63 * buildbot/status/builder.py: same, by requiring cStringIO
64 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
65 * buildbot/test/test_vc.py: same
66 * buildbot/test/test_web.py:
67 * buildbot/test/test_steps.py: same, remove unused import
69 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
72 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
73 see any Builders that don't have Schedulers to drive them
75 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
76 attributes this uses went away
78 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
79 dialog, to allow you to reset the buildmaster and force
80 connect/disconnect. Correctly handle losing the buildmaster
81 connection (by switching the display to the hexnut, at which point
82 you can use the 'Connect' menu item to reconnect).
84 * buildbot/steps/source.py (Source.start): if we're using a patch,
85 add it as a LogFile to the checkout/update step. This will turn
86 into a link on the waterfall page.
88 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
89 option, to take the patch from a pre-made file rather than
90 generating it from the local tree. Thanks to Robert Helmer for the
91 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
92 * buildbot/scripts/runner.py (TryOptions): add --diff,
93 --patchlevel, and --baserev options
94 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
95 as None, meaning HEAD.
96 * buildbot/sourcestamp.py (SourceStamp): update docstring to
97 indicate that baserev=None means HEAD
98 * docs/buildbot.texinfo (try --diff): document it
100 * buildbot/test/test_steps.py (BuildStep): remove use of
101 reactor.iterate(), although the technique I replaced it with is a
102 gross polling hack that must be cleaned up properly some day. This
103 was the last use of reactor.iterate in the entire tree, yay.
105 2007-02-05 Brian Warner <warner@lothar.com>
107 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
108 is one of the three known values, otherwise we emit some confusing
109 messages later on. Thanks to Grig Gheorghiu for the catch.
111 2007-01-30 Brian Warner <warner@lothar.com>
113 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
114 Hearsum contributed a patch to let BonsaiPoller work with results
115 that contain non-ascii characters. Closes SF#1632641.
117 2007-01-27 Brian Warner <warner@lothar.com>
119 * Makefile (release): produce both .tar.gz and .zip source bundles.
122 2007-01-23 Brian Warner <warner@lothar.com>
124 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
125 * buildbot/changes/monotone.py: same
127 * buildbot/changes/maildir.py: combine several files into one,
128 clean up maildir.py to use Services properly.
129 * buildbot/changes/maildirtwisted.py: remove
130 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
132 * buildbot/changes/mail.py: match the change
133 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
134 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
136 * buildbot/slave/commands.py (command_version): bump to "2.3" to
137 indicate that the buildslave knows about the 'bzr' command
139 2007-01-22 Brian Warner <warner@lothar.com>
141 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
142 'with', it will become a reserved work in python2.6 .
144 * contrib/bb_applet.py: add a simple gnome-panel applet, to
145 display a terse summary of buildbot status.
146 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
147 some icons, small versions of the Blender object that lives in
148 docs/images/icon.blend
150 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
151 * buildbot/slave/commands.py (Bzr): same
152 * buildbot/scripts/tryclient.py (BzrExtractor): same
153 (SourceStampExtractor.dovc): modify this to allow non-zero exit
154 status, since 'bzr diff' does that
155 * buildbot/test/test_vc.py (Bzr): same
156 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
160 2007-01-20 Brian Warner <warner@lothar.com>
162 * contrib/darcs_buildbot.py: tidy up the progress messages
164 2007-01-17 Brian Warner <warner@lothar.com>
166 * contrib/darcs_buildbot.py: enhance to handle multiple patches
167 being pushed at a time. This keeps state in the repository in a
168 small file named .darcs_buildbot-lastchange, but that shouldn't
169 interfere with normal repository operations. Fixes SF#1534049.
170 * buildbot/clients/sendchange.py (Sender): make a single Sender
171 capable of sending Changes with different usernames.
173 2006-12-11 Brian Warner <warner@lothar.com>
175 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
176 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
177 buildbot.changes.mail a long time ago, but I forgot to add the
178 DeprecationWarning until now.
180 * buildbot/process/maxq.py: remove this, the functionality now
181 lives in buildbot.steps.maxq
183 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
184 * buildbot/clients/gtkPanes.py: remove unused import
186 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
187 that was meant to provide a special Reporter to run inside trial
188 and give the buildslave lots of machine-readable status. We never
189 finished this project.
191 * buildbot/changes/bonsaipoller.py: remove unused imports
192 * buildbot/changes/svnpoller.py: same
193 * buildbot/process/builder.py: same
194 * buildbot/process/buildstep.py: same
195 * buildbot/slave/bot.py: hush pyflakes warning
196 * buildbot/status/tests.py: remove unused imports
197 * buildbot/status/tinderbox.py: same
198 * buildbot/steps/python_twisted.py: same
200 * buildbot/process/step.py: remove this file, these names were
201 deprecated in 0.7.5 and are now being removed.
202 * buildbot/process/step_twisted.py: same
203 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
205 * buildbot/twcompat.py: remove the empty file, yay it is gone
207 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
208 tw-2.0.0 and newer have the method we need.
209 (getProcessOutputAndValue): same
210 (which): remove this method, tw-2.0.0 t.p.procutils has it
212 * buildbot/twcompat.py (implements): remove this method
213 * buildbot/*: import implements() from zope.interface directly
215 * buildbot/status/mail.py: stop falling back to importing
216 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
219 * buildbot/twcompat.py (Interface): remove this import
220 * buildbot/*: import Interface from zope.interface directly
222 * buildbot/twcompat.py (providedBy): remove this method
223 * buildbot/*: turn all uses of providedBy(obj, iface) into
224 iface.providedBy(obj)
226 * buildbot/twcompat.py (maybeWait): remove this method, now that
227 we no longer maintain compatibility with Twisted<=1.3.0 .
228 Twisted-2.0.0 and later allow trial methods to return Deferreds
230 * buildbot/test/*: remove all uses of maybeWait
232 * buildbot/__init__.py (version): bump to 0.7.5+ while between
234 * docs/buildbot.texinfo: same
236 2006-12-10 Brian Warner <warner@lothar.com>
238 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
239 * docs/buildbot.texinfo: set version to match
241 2006-12-10 Brian Warner <warner@lothar.com>
243 * README (REQUIREMENTS): update for release
244 * NEWS: update for release
245 * buildbot/slave/commands.py (command_version): mention that this
246 version (2.2) was released with buildbot-0.7.5
248 * buildbot/test/test_config.py (StartService.testStartService):
249 inhibit the usual read-config-on-startup behavior, since otherwise
250 the log.err that gets recorded causes the test to fail
252 * buildbot/status/builder.py (LogFile.finish): forget about all
253 subscribers once the log has finished, since after that point
254 we're never going to use them again. This might help free up some
257 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
258 than the old/deprecated gtk.mainquit()
260 2006-12-09 Brian Warner <warner@lothar.com>
262 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
263 better when we can't open the masterdst file
265 * buildbot/scripts/startup.py (Follower._failure): add missing
266 import statement for BuildSlaveDetectedError
268 * buildbot/steps/transfer.py (FileUpload): cleanup
269 (FileDownload): same. Add tests for slave version, add mode=.
270 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
271 (SlaveFileDownloadCommand): same
272 * buildbot/test/test_transfer.py: enhance tests
273 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
276 2006-12-08 Brian Warner <warner@lothar.com>
278 * buildbot/scripts/runner.py (sendchange): halt the reactor on
279 both success *and* failure. Without this, the 'buildbot
280 sendchange' command would hang if it could not contact the
281 buildmaster or deliver the Change, which would generally cause the
282 user's commit/record/checkin command to hang too. Thanks to
283 Christian Unger for the catch.
285 2006-12-06 Brian Warner <warner@lothar.com>
287 * NEWS: update with items for the next release
289 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
290 whimsical example pulled from a punch-drunk email I sent out late
292 (Transferring Files): document some of the other parameters
293 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
294 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
295 * buildbot/test/test_svnpoller.py: same
296 * buildbot/changes/svnpoller.py (SVNPoller): same
298 2006-11-26 Brian Warner <warner@lothar.com>
300 * docs/buildbot.texinfo (Build Properties): remind users that
301 WithProperties must appear in a command= list, not as a top-level
303 * buildbot/steps/shell.py (ShellCommand.start): and assert that
304 we're sending a list or a single string to the RemoteShellCommand
306 * buildbot/scheduler.py (Nightly): Improve docs slightly.
308 * buildbot/scripts/startup.py (start): skip the whole
309 watch-the-logfile thing under windows, since it needs os.fork()
311 * buildbot/scripts/runner.py (restart): remove the old message
312 that got printed after the buildbot was restarted.. it most cases
313 it didn't get printed at the right time anyways
315 2006-11-25 Brian Warner <warner@lothar.com>
317 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
318 follow twistd.log and print lines until the process has started
319 started properly. For the buildmaster, this means until the config
320 file has been parsed and accepted. For the buildslave, this means
321 until we've connected to the master. We give up after 5 seconds in
322 any case. Helpful error messages and troubleshooting suggestions
323 are printed when we don't see a successful startup. This closes the
324 remainder of SF#1517975.
325 * buildbot/scripts/startup.py: moved app startup code to here
326 * buildbot/scripts/logwatcher.py: utility class to follow log
327 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
328 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
329 so the LogWatcher can tell the difference between a buildmaster
332 2006-11-24 Brian Warner <warner@lothar.com>
334 * docs/examples/twisted_master.cfg: update to match the version
335 in use on twistedmatrix.com
336 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
337 was using before stopped working, but 'irc.freenode.net' works
340 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
343 * buildbot/clients/base.py (TextClient.not_connected): upon
344 UnauthorizedLogin failures, remind the user to connect to the
345 PBListener port instead of the slaveport.
346 (TextClient.disconnected): shut down more quietly
347 * docs/buildbot.texinfo (statuslog): add another reminder
349 * buildbot/scripts/runner.py (Options.subCommands): rename
350 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
351 'sighup' as an alias.
352 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
353 reconfig command to follow twistd.log and print all of the lines
354 from the start of the config-file reload to its completion. This
355 should make it a lot easier to discover bugs in the config file.
356 Use --quiet to disable this behavior. This addresses half of
357 SF#1517975, the other half will be to add this same utility to
358 'buildbot start' and 'buildbot restart'.
359 * docs/buildbot.texinfo (Loading the Config File): same
362 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
363 method, it has been deprecated for a long time. Use
364 IBuilderControl.requestBuild instead.
365 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
366 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
367 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
368 * buildbot/test/test_control.py (Force.testForce): same
369 * buildbot/test/test_run.py: use requestBuild instead
371 * buildbot/clients/debug.py: replace 'Force Build' button with
372 'Request Build' (which just adds one to the queue), add Ping
373 Builder, add branch/revision fields to Request Build.
374 * buildbot/clients/debug.glade: same
375 * buildbot/master.py: update interface to match. This creates an
376 incompatibility between new debugclients and old buildmasters.
378 * buildbot/process/builder.py (Builder._attached): delay the call
379 to maybeStartBuild for a reactor turn, to avoid starting a build
380 in the middle of a reconfig (say, if the new Builder uses a new
381 slave which is already connected).
383 2006-11-23 Brian Warner <warner@lothar.com>
385 * buildbot/test/test_transfer.py: appease pyflakes
386 * buildbot/test/test_steps.py: same
388 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
389 keeps pyflakes from finding undefined names
391 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
392 Builder no longer induces a disconnect/reconnect cycle. This means
393 that any builds currently in progress will not be interrupted, and
394 any builds which are queued in the Builder will not be lost. This
395 is implemented by having the new Builder extract the state (i.e.
396 all pending Builds and any desired SlaveBuilders) from the old
398 (BotPerspective): refactor. The BotPerspective no longer keeps
399 track of all the Builders that want to use this slave; instead, it
400 asks the BotMaster each time it needs this list. This removes
401 addBuilder and removeBuilder. Clean up attached() to acquire all
402 the slave's information in a more atomic fashion. updateSlave() is
403 now the way to make sure the slave is using the right set of
404 Builders: just call it after everything else has been
406 (BotMaster): refactor, removing addBuilder/removeBuilder and
407 replacing them with an all-at-once setBuilders() call.
409 * buildbot/test/test_slaves.py (Reconfig): new test case to
410 exercise this functionality
411 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
412 * buildbot/slave/commands.py (WaitCommand): same
414 * docs/buildbot.texinfo (Loading the Config File): document the
417 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
418 SlaveBuilder to have its parent Builder changed.
419 (SlaveBuilder.isAvailable): new method to give access to state,
420 which is now a private attribute
421 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
422 the SlaveBuilder about how it is being used. These methods update
423 its internal state. buildFinished() is now the place that invokes
424 maybeStartBuild() on its parent Builder.
425 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
426 new Builder to take over for an old one, transferring state from
428 (Buider): refactor the way that SlaveBuilders are used to match,
429 giving them a bit more autonomy.
430 (Builder.buildFinished): this no longer calls maybeStartBuild():
431 instead the SlaveBuilder calls it on whoever its parent Builder is
432 at the time. This way, when an old Builder is replaced by a new
433 one, and there was a build in progress during the transition, when
434 that build finishes, it will be the new Builder that is told about
435 the newly available slave so it can start a new build.
437 * buildbot/process/base.py (Build.startBuild._release_slave): when
438 the Build finishes, tell the SlaveBuilder that they've been
441 * buildbot/status/builder.py (SlaveStatus): add some new setter
442 methods for use by BotPerspective, to keep some attributes more
445 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
446 called by the buildmaster.
447 (Bot.setBuilderList): instead, we locally announce any leftover
448 directories based upon which Builders we were told about. The
449 master doesn't really care; it's the local admin who may or may not
453 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
454 to allow use of python2.4 or whatever. This tool still requires
457 2006-11-19 Brian Warner <warner@lothar.com>
459 * NEWS (IStatusLog.readlines): more news items
461 2006-11-18 Brian Warner <warner@lothar.com>
463 * NEWS: start collecting items for the next release.
465 2006-11-04 Brian Warner <warner@lothar.com>
467 * buildbot/changes/bonsaipoller.py: apply updates from Ben
468 Hearsum. Closes SF#1590310.
469 * buildbot/test/test_bonsaipoller.py: and tests
471 * buildbot/status/tinderbox.py
472 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
473 status when the build results in WARNINGS. Patch from Dave
474 Liebreich. Closes SF#1587352.
476 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
477 linux-vs-osx behavior difference w.r.t. reading from files that
478 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
479 to Mark Rowe for the patch.
481 2006-10-15 Brian Warner <warner@lothar.com>
483 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
484 method name was misspelled in the interface definition. Thanks to
485 Roy Rapoport for the catch.
487 2006-10-13 Brian Warner <warner@lothar.com>
489 * docs/buildbot.texinfo (Adding LogObservers): update sample code
490 to match the great Steps renaming
492 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
493 Maybe I should run my own unit tests before recording a big
494 change. Good thing I've got a buildbot to remind me.
496 2006-10-12 Brian Warner <warner@lothar.com>
498 * buildbot/steps/transfer.py: rework __init__ and args setup
499 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
501 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
502 when opening the target file, only catch IOError (to report via
503 stderr/rc!=0), let the others be reported as normal exceptions
505 2006-10-08 Brian Warner <warner@lothar.com>
507 * contrib/svn_watcher.py: fix security holes by using proper argv
508 arrays and subprocess.Popen() rather than commands.getoutput().
509 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
510 is deprecated in favor of buildbot/changes/svnpoller.py, and will
511 probably be removed by the next release.
514 2006-10-04 Brian Warner <warner@lothar.com>
516 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
517 initial lines that weren't emitted by pyflakes. When the pyflakes
518 command is run under a Makefile, 'make' will echo the command it
519 runs to stdio, and that was getting logged as a "misc" warning.
520 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
521 * buildbot/test/test_steps.py (testPyFlakes3): another test
523 2006-10-01 Brian Warner <warner@lothar.com>
525 * buildbot/status/html.py (HtmlResource.render): if we get a
526 unicode object from our content() method, encode it into utf-8
527 like we've been claiming to all along. This allows the comments
528 and author names from svnpoller.py to be delivered properly.
530 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
531 de-unicodify filenames before creating the Change, because the
532 rest of buildbot is unlikely to handle them well. Leave the 'who'
533 field as a unicode object.. I don't think there's anything that
534 will break very soon, and it will probably nudge us towards
535 accepting unicode everywhere sooner or later. Stop using the
536 "date" field that comes out of SVN, since it is using the
537 repository's clock (and timezone) and what we care about is the
538 buildmaster's (otherwise Changes from the future show up later
539 than the builds they triggered).
540 * buildbot/test/test_svnpoller.py (Everything.test1): match the
543 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
544 Suvbersion repository polling ChangeSource. I've hacked it up
545 considerably: any bugs are entirely my own fault. Thank you
547 * buildbot/test/test_svnpoller.py: tests for it
548 * docs/buildbot.texinfo (SvnSource): document it
550 2006-09-30 Brian Warner <warner@lothar.com>
552 * buildbot/scheduler.py (Periodic): submit a reason= to the
553 BuildSet to indicate which Scheduler triggered the build. Thanks
554 to Mateusz Loskot for the suggestion.
556 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
558 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
559 changes: set self.loop in __init__, remove unused volatile=
561 * docs/buildbot.texinfo (.buildbot config directory): add more
562 docs on the .buildbot/options keys used by "buildbot try"
563 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
564 (Try.deliverJob): same
566 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
570 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
571 close the filehandle when we stop watching the file. Before, the
572 filehandle was only closed when the LogFileWatcher was
573 garbage-collected, which could be quite a while in the future. If
574 it was still open by the time the next build started, windows will
575 refuse to let the new build delete the old build/ directory. Fixes
576 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
577 #twisted for the catch.
579 2006-09-29 Brian Warner <warner@lothar.com>
581 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
584 2006-09-25 Brian Warner <warner@lothar.com>
586 * setup.py: the new buildbot.steps module wasn't being installed.
587 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
588 (testmsgs): add the extra stuff from buildbot/test/* so you can
589 run unit tests on an installed copy of buildbot, not just from
592 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
593 columns of 'svnlook changed' output contain status information, so
594 strip [:4] instead of [:6]. Depending upon what the status flags
595 were, this would sometimes lead to mangled filenames. Thanks to
596 Riccardo Magliocchetti for the patch. Closes SF#1545146.
598 * buildbot/steps/source.py (Monotone): initial Monotone support,
599 contributed by Nathaniel Smith. Still needs docs and tests, but
600 this code has been in use on the Monotone buildbot for a long
602 * buildbot/slave/commands.py (Monotone): slave-side support
603 * buildbot/changes/monotone.py (MonotoneSource): polling change
606 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
607 contributed a Change Source that polls a Bonsai server (a
608 kind of web-based viewcvs CGI script).
610 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
611 Hearsum contributed a status plugin which sends email in the same
612 format that Tinderbox does: this allows a number of tinderbox
613 tools to be driven by Buildbot instead. Thanks Ben!
615 2006-09-24 Brian Warner <warner@lothar.com>
617 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
618 Thanks to Robert Helmer for the patch.
620 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
621 BuildStatus about the buildslave name at the *beginning* of the
622 build, rather than at the end. Thanks to Alexander Lorenz for the
624 * buildbot/status/html.py (StatusResourceBuild.body): always
625 include the slavename in the build page, not just when the build
627 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
628 slavename in the email message
630 2006-09-21 Brian Warner <warner@lothar.com>
632 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
634 * docs/examples/glib_master.cfg: same
635 * docs/examples/hello.cfg: same
636 * docs/examples/twisted_master.cfg: same, update to current usage
638 2006-09-19 Brian Warner <warner@lothar.com>
640 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
641 (PyFlakes.createSummary): make it compatible with python-2.2
643 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
644 for at least the output-parsing parts of PyFlakes
646 2006-09-18 Brian Warner <warner@lothar.com>
648 * buildbot/steps/python.py: oops, fix import of StringIO
650 2006-09-17 Brian Warner <warner@lothar.com>
652 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
653 turns out that SVN-1.4.0 doesn't fail to update once you've
654 replaced a file with a directory, unlike older versions of SVN and
655 pretty much every other VC tool we support. Since what we really
656 care about is that the update succeeds anyway, stop checking that
657 the tree got clobbered and just assert that the build succeeded.
658 (VCBase.printLogs): add a utility function for debugging
660 * buildbot/process/step.py: oops, added extra imports by mistake
662 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
663 rstrip() on the first line coming out of the 'p4 describe'
664 process, to remove the stray ^M that Wade Brainerd reports seeing
665 in the 'when' field. Fixes SF#1555985.
667 * buildbot/master.py (BuildMaster.loadConfig): improve the error
668 message logged when c['schedulers'] is not right
669 * buildbot/scheduler.py (Scheduler.__init__): improve error
670 message when a Scheduler() is created with the wrong arguments
671 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
672 verify that these error messages are emitted
674 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
675 The idea is that all the base classes (like BuildStep and
676 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
677 will be a leftover backwards-compatibility file that only contains
678 aliases for the steps that were moved out to buildbot.steps.*
679 * lots: change imports to match
680 * buildbot/process/step.py: add a DeprecationWarning if it ever
683 2006-09-12 Brian Warner <warner@lothar.com>
685 * buildbot/scheduler.py (Scheduler.__init__): make sure that
686 builderNames= is actually a sequence, since if you happen to give
687 it a single builder-specification dictionary instead, it won't get
688 caught by the existing assert. Thanks to Brett Neely for the
691 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
693 * docs/buildbot.texinfo (Python BuildSteps): document them
694 (sendchange): include a link to PBChangeSource, since you need one
696 * buildbot/steps/shell.py: clean up test-case-name line, remove some
698 * buildbot/steps/dummy.py: same
700 2006-09-08 Brian Warner <warner@lothar.com>
702 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
703 BuildStep which lets you transfer files from the master to the
704 slave or vice versa. Thanks to Albert Hofkamp for the original
705 patch. Fixes SF#1504631.
706 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
708 (SlaveFileDownloadCommand): same
709 * docs/buildbot.texinfo (Transferring Files): document it
710 * buildbot/test/test_transfer.py: test it
711 * buildbot/test/runutils.py (StepTester): new utility class for
712 testing BuildSteps and RemoteCommands without Builds or Bots or PB
713 * buildbot/test/test_steps.py (CheckStepTester): validate that the
716 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
717 walk through StatusLogs one line at a time, mostly for the benefit
718 of ShellCommand.createSummary methods. You can either walk through
719 STDOUT or STDERR, but the default is STDOUT.
721 * buildbot/status/builder.py (LogFile.readlines): implement it.
722 Note that this is not yet memory-efficient, it just pulls the
723 whole file into RAM and then splits it up with a StringIO.
724 Eventually this should be a generator that only pulls chunks from
726 * buildbot/test/test_status.py (Log.testReadlines): test it
728 * docs/buildbot.texinfo: update to match changes
729 * buildbot/process/factory.py: stop using old definitions
730 * buildbot/process/process_twisted.py: same
731 * buildbot/test/test_*.py: same
733 * buildbot/process/step_twisted.py: move definition to..
734 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
735 relative-import mechanisms prevent this from being named 'twisted'
736 or 'python/twisted' as I would have preferred.
738 * buildbot/process/maxq.py: move definition to..
739 * buildbot/steps/maxq.py: .. here, leave a compatibility import
741 * buildbot/process/step.py: split the user-visible BuildSteps into
742 separate files, all under buildbot/steps/
743 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
744 * buildbot/steps/shell.py: this holds ShellCommand and friends
745 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
747 2006-09-05 Brian Warner <warner@lothar.com>
749 * lots: run pyflakes, removed a lot of unused imports, changed the
750 form of some conditional imports to remove false pyflakes
751 warnings. There are still a number of warnings left, mostly from
752 imports that are done for their side-effects.
753 * buildbot/test/test_vc.py: import twisted.python.failure, since it
756 2006-08-26 Brian Warner <warner@lothar.com>
758 * buildbot/test/test_locks.py (Unit.testLater): make the tests
759 compatible with twisted-1.3.0, for some reason I just can't seem
760 to let go of the past.
762 2006-08-25 Brian Warner <warner@lothar.com>
764 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
766 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
767 all logfiles= in startCommand(), rather than in start() . This
768 makes it easier to have the 'stdio' log come before any secondary
769 logfiles, which I feel makes the waterfall display more
771 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
772 from ShellCommand up into LoggingBuildStep
773 (LoggingBuildStep.__init__): move the handling of logfiles= from
774 ShellCommand up to LoggingBuildStep, because startCommand is
775 provided by LoggingBuildStep, whereas start() was specific to
776 subclasses like ShellCommand and Source. This removes code
777 duplication in those subclasses.
778 (ShellCommand.__init__): same
779 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
780 for a slave that's too old to understand logfiles= into a separate
781 method, so it can live in ShellCommand. The rest of
782 setupLogfiles() can live in LoggingBuildStep.
784 2006-08-24 Brian Warner <warner@lothar.com>
786 * buildbot/locks.py (BaseLock): you can now configure Locks to
787 allow multiple simultaneous owners. They still default to
788 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
790 * docs/buildbot.texinfo (Interlocks): document the new options
791 * buildbot/test/test_locks.py: add a bunch of new unit tests
792 * buildbot/process/base.py (Build.acquireLocks): locks now offer
793 waitUntilMaybeAvailable, not waitUntilAvailable
794 * buildbot/process/step.py (BuildStep.acquireLocks): same
795 * buildbot/master.py (BotMaster.getLockByID): real locks now use
796 the whole lockid in their constructor, not just the name. Also,
797 keep track of which real locks we've handed out by the full
798 lockid, not just class+name, otherwise changing just the maxCount=
799 in the master.cfg file would not actually cause a behavioral
802 2006-08-23 Brian Warner <warner@lothar.com>
804 * buildbot/__init__.py (version): bump to 0.7.4+ while between
806 * docs/buildbot.texinfo: same
808 2006-08-23 Brian Warner <warner@lothar.com>
810 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
811 * docs/buildbot.texinfo: set version to match
812 * NEWS: update for 0.7.4
813 * buildbot/slave/commands.py (command_version): mention that this
814 version (2.1) was released with buildbot-0.7.4
816 2006-08-22 Brian Warner <warner@lothar.com>
820 * CREDITS: new file, list of people who have helped. Thanks!
821 * MANIFEST.in: ship it
823 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
824 new diagrams, the user's manual is more informative than it was.
825 Start shipping the .html user's manual (and generated .png
827 * Makefile: update 'release' target to match
829 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
830 test.. I think the web-parts effort will render it pointless well
831 before it ever actually starts to work.
833 2006-08-20 Brian Warner <warner@lothar.com>
835 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
836 meaning of the prefix= argument. It is now just a string which is
837 stripped from the beginning of the filename. If prefix= is set but
838 not found on any given filename, that filename is ignored. If all
839 filenames in a Change are ignored, the Change is dropped. This is
840 much simpler than the previous sep= nonsense, and I should have
841 implemented it this way from the beginning. Effectively resolves
842 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
843 Gedminas for the catch and suggested fixes.
844 (ChangePerspective.perspective_addChange): implement the actual
846 * buildbot/test/test_changes.py (TestChangePerspective): test it
847 * docs/buildbot.texinfo (PBChangeSource): document it, explain
848 how to properly use prefix=
849 * docs/examples/twisted_master.cfg (source): update prefix= by
850 adding the trailing slash
853 * docs/examples/twisted_master.cfg: update to actual practice
855 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
856 update test case to match new link text.. the HREF has both a
857 class= setting and an enclosing [] pair that I didn't match in the
860 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
861 list of strings is preferred over a single string with embedded
863 (ShellCommand.description=): explain that either single strings or
864 a list of strings is acceptable, and why you might prefer one over
865 the other. Add an example. Fixes SF#1524659, thanks to Paul
866 Winkler for the catch.
867 (Build Steps): update to use f.addStep() rather than using s()
868 and the constructor list
870 * buildbot/process/step.py (ShellCommand): accept either a single
871 string or a list of strings in both description= and
873 * buildbot/test/test_steps.py (Steps.test_description): test it
874 * buildbot/test/runutils.py (makeBuildStep): support for that test
876 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
877 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
878 collecting the files and creating the patch.
880 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
881 per-step URLs that will be displayed on the waterfall display,
882 for things like the HTML output of code-coverage tools, when
883 the results are hosted elsewhere.
884 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
885 way to retrieve these URLs
886 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
887 the method to retrieve these URLs. Also provide backwards
888 compatibility for saved BuildStepStatus instances that didn't have
890 * buildbot/process/step.py (BuildStep.addURL): method to set these
891 URLs from within a BuildStep
892 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
893 (StepBox.getBox): give these external links a distinct CSS class
894 named "BuildStep external" so a .css file can display them
897 * buildbot/test/test_web.py (WaterfallSteps): test that we really
899 * buildbot/test/test_steps.py (Steps): test that we can all the
900 URLs. Also add a bunch of other tests on methods that can be
901 called from within BuildSteps
902 * buildbot/test/runutils.py (makeBuildStep): add utility function
904 2006-08-13 Brian Warner <warner@lothar.com>
906 * docs/buildbot.texinfo (BuildStep LogFiles): document them
908 2006-08-10 Brian Warner <warner@lothar.com>
910 * docs/buildbot.texinfo (Index of master.cfg keys): add another
911 index, this one of things like c['sources'] and c['schedulers']
912 (indices): it looks like my clever idea of putting the @fooindex
913 commands in between the @node and the @subsection (to make the
914 HREF anchor jump to slightly above the section title, which works
915 much better in html) confused texinfo horribly, so I'm moving the
916 index tags back to be just after the @subsection marker. I also
917 added extra lines between the @node/@section paragraph and the
918 index tags, since I think maybe texinfo wants to see these be
921 * docs/Makefile (images): make sure images get built when
923 * docs/images/Makefile: same
925 * buildbot/scripts/runner.py: rename 'buildbot master' to
926 'buildbot create-master', and 'buildbot slave' to 'buildbot
928 * docs/buildbot.texinfo: same
931 * docs/buildbot.texinfo: reimplement the "useful classes" index
932 with actual texinfo indices. The .info rendering is a bit
933 weird-looking but it works well, and the HTML rendering is quite
934 nice. This also puts the index targets in the regular flow of the
935 text, which is easier to maintain.
937 2006-08-06 Brian Warner <warner@lothar.com>
939 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
940 Kevin Turner to prefer the environ= argument be a list rather than
941 a string. If it is a list, it will be joined with a platform-local
942 os.pathsep delimiter, and then prepended to any existing
943 $PYTHONPATH value. This works better in cross-platform (i.e.
944 windows buildslaves) environments when you need to push multiple
945 directories onto the front of the path.
946 (SlaveShellCommand): documented the new magic
947 * docs/buildbot.texinfo (ShellCommand): documented the new magic
948 in a user-visible form
950 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
951 Turner to prefer lists over strings when creating/running VC
952 commands during unit tests. This is clearly necessary to survive
953 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
954 renamed the wq() function to qw() though, since that's how it's
955 spelled in perl. Eventually I'd prefer all commands to be
956 specified with lists.
958 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
959 which are deleted (or not yet created) correctly. Also add
960 failsafe code to not explode if the file-watching poller doesn't
961 get started. Thanks to JP Calderone for the catch and the poller
963 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
965 * buildbot/test/emitlogs.py: same
967 * NEWS: summarize recent changes
969 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
970 clause to avoid the "host key mismatch" warning
972 * buildbot/process/step_twisted.py (Trial.start): if the
973 buildslave is too old to understand logfiles=, fall back to
974 running 'cat _trial_temp/test.log' like before.
975 (Trial.commandComplete): same. this takes advantage of the
976 LoggingBuildStep refactoring to stall commandComplete long enough
977 to run a second RemoteShellCommand.
979 * buildbot/process/step.py (LoggingBuildStep.startCommand):
980 refactor command-completion handling, to allow methods like
981 commandComplete/createSummary/evaluateCommand to return Deferreds.
982 (LoggingBuildStep._commandComplete): delete the refactored method
983 (ShellCommand.setupLogfiles): if the buildslave is too old to
984 understand logfiles=, put a warning message both into twistd.log
985 and into the otherwise empty user-visible LogFiles.
987 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
988 callers to provide the slave-side logfile name, rather than
989 forcing it to come from the local name of the LogFile.
990 (BuildStep.getSlaveName): new method
992 * buildbot/process/base.py (Build.getSlaveName): new method, so
993 steps can find out which buildslave they're running on
995 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
996 to match the s/cvs_ver/command_version/ change
998 2006-08-05 Brian Warner <warner@lothar.com>
1000 * buildbot/slave/commands.py (command_version): replace the CVS
1001 auto-updated cvs_ver keyword with a manually-updated variable,
1002 since CVS is no longer the master repository. Add a description of
1003 the remote API change starting in this version (2.1), specifically
1004 the fact that SlaveShellCommand now accepts 'initial_stdin',
1005 'keep_stdin_open', and 'logfiles'.
1007 2006-07-31 Brian Warner <warner@lothar.com>
1009 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1010 diagrams to describe how the whole system fits together. The
1011 images themselves are kept in SVG files, with ascii-art versions
1012 in corresponding .txt files. Texinfo knows how to interpolate the
1013 text version into .info files, reference the .png versions from
1014 .html files, and include .eps versions in the .ps format.
1015 * docs/images/Makefile: tools to create .png and .eps
1016 * docs/images/*.svg: created pictures with Inkscape.
1017 * .darcs-boring: ignore the generated .eps and .png files
1019 2006-07-24 Brian Warner <warner@lothar.com>
1021 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1022 Scheduler names, since they cause setServiceParent to explode
1024 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1026 2006-07-20 Brian Warner <warner@lothar.com>
1028 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1029 which runs the buildbot unit tests
1031 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1032 classes that are useful in master.cfg
1034 2006-07-15 Brian Warner <warner@lothar.com>
1036 * Makefile (some-apidocs): new target to build only some epydocs
1038 * setup.py: minor comment.. does the classifiers= argument prevent
1039 the setup.py script from working on python2.2/2.3?
1041 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1044 * buildbot/twcompat.py: fix minor typo in comments
1046 * buildbot/manhole.py: move all Manhole-related code out to this
1047 module. Implement SSH-based manholes (with TwistedConch), and move
1048 to conch's nifty line-editing syntax-coloring REPL shell instead
1049 of the boring non-editing monochromatic (and deprecated) old
1051 * buildbot/master.py: remove all Manhole-related code
1052 (BuildMaster.loadConfig._add): make sure the old manhole is
1053 removed before we add the new one
1054 * docs/buildbot.texinfo (Debug options): document new Manhole options
1056 * buildbot/twcompat.py (_which): fix some epydoc issues
1057 * buildbot/status/html.py (Waterfall.__init__): same
1059 2006-06-29 Brian Warner <warner@lothar.com>
1061 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1062 deprecation warnings under newer Twisteds (by using
1063 zope.interface.Interface instead of old twisted.python.components
1065 * buildbot/slave/interfaces.py: same
1067 2006-06-28 Brian Warner <warner@lothar.com>
1069 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1070 svn commands, so it will fail immediately instead of hanging while
1071 it waits for a username/password to be typed in.
1073 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1074 log message if the step was shut down
1076 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1077 obsolete reference to mktap.
1079 2006-06-20 Brian Warner <warner@lothar.com>
1081 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1082 test to include new 'logfiles' argument sent from master to slave
1084 2006-06-19 Brian Warner <warner@lothar.com>
1086 * buildbot/process/step_twisted.py (Trial): track Progress from
1087 _trial_temp/test.log too
1089 * buildbot/process/step.py (OutputProgressObserver): generalize
1090 the earlier StdioProgressObserver into an OutputProgressObserver
1091 that can track LogFiles other than stdio.
1092 (LoggingBuildStep.__init__): same
1094 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1095 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1096 will fail under windows because of os.sep issues. It might have
1097 worked before if 'cat' was doing cygwin path conversion.
1099 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1100 creation of LogFileWatchers
1101 (ShellCommand._startCommand): and record the files that were
1102 watched in the 'headers' section of the ShellCommand output
1104 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1105 need to actually pass it to the slave if you want it to work.
1106 (ShellCommand): document it a bit
1108 * buildbot/test/test_shell.py: new test to validate LogFiles
1109 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1111 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1112 before printing the last batch of lines, to test that the polling
1113 logic is working properly
1115 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1116 handling, making it possible to track multiple logs for a single
1117 RemoteCommand. The previous single logfile is now known as the
1119 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1120 (RemoteShellCommand.__init__): accept logfiles=
1121 (LoggingBuildStep.startCommand): stdio_log is now one of many
1122 (ShellCommand): added logfiles= argument, as well as a class-level
1123 .logfiles attribute, which will be merged together to figure out
1124 which logfiles should be tracked. The latter maybe be useful for
1125 subclasses of ShellCommand which know they will aways produce
1126 secondary logfiles in the same location.
1128 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1129 and closeStdin() methods, preparing to make it possible to write
1130 to a ShellCommand's stdin at any time, not just at startup. These
1131 writes are buffered if the child process hasn't started yet.
1132 (LogFileWatcher): new helper class to watch arbitrary logfiles
1133 while a ShellCommand runs. This class polls the file every two
1134 seconds, and sends back 10k chunks to the buildmaster.
1135 (ShellCommand): rename stdin= to initialStdin=, and add
1136 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1138 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1139 key of "log" and a value of (logname, data).
1140 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1141 'logfiles' to the master-visible args dictionary.
1142 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1145 * buildbot/test/test_vc.py (Patch.testPatch): same
1148 * buildbot/test/emit.py: write to a logfile in the current
1149 directory. We use this to figure out what was used as a basedir
1150 rather than looking to see which copy of emit.py gets run, so that
1151 we can run the commands from inside _trial_temp rather than inside
1153 * buildbot/test/subdir/emit.py: same
1154 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1155 argument rather than running from buildbot/test/
1156 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1157 rather than using an implicit setUp()
1158 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1159 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1160 of assuming that we're running in buildbot/test/ (and that '.' is
1163 * buildbot/slave/commands.py (Command.doStart): refactor Command
1164 startup/completion a bit: now the SlaveBuilder calls doStart(),
1165 which is not meant for overridding by subclasses, and doStart()
1166 calls start(), which is. Likewise the SlaveBuilder calls
1167 doInterrupt(), and subclasses override interrupt(). This also puts
1168 responsibility for maintaining .running in Command rather than in
1170 (Command.doInterrupt): same
1171 (Command.commandComplete): same, this is called when the deferred
1172 returned by start() completes.
1173 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1174 (SlaveBuilder.remote_interruptCommand): same
1175 (SlaveBuilder.stopCommand): same
1177 2006-06-16 Brian Warner <warner@lothar.com>
1179 * buildbot/test/test_shell.py: new test file to contain everything
1180 relating to ShellCommand
1181 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1182 multiple logfiles in realtime" feature, not yet implemented
1183 * buildbot/test/emitlogs.py: support file for testLogFiles
1184 * docs/buildbot.texinfo (ShellCommand): document the feature
1186 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1188 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1189 for tests which exercise SlaveCommands in isolation.
1191 * buildbot/test/test_slavecommand.py: Move some utilities like
1192 SignalMixin and FakeSlaveBuilder from here ..
1193 * buildbot/test/runutils.py: .. to here, so they can be used by
1194 other test classes too
1195 * buildbot/test/test_vc.py: more SignalMixin refactoring
1196 * buildbot/test/test_control.py: same
1197 * buildbot/test/test_run.py: and some rmtree refactoring
1199 2006-06-15 Brian Warner <warner@lothar.com>
1201 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1202 'testBranch' to match other VC tests and have the tests run in
1203 roughly increasing order of dependency
1205 * buildbot/test/test_steps.py (LogObserver): new test to verify
1206 LogObservers can be created at various times and still get
1207 connected up properly
1209 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1210 to create BuildStepStatus instances that actually work.
1212 * buildbot/process/step.py (LogObserver): add outReceived and
1213 errReceived base methods, to be overridden
1215 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1216 API to take a name instead of a step, reducing the coupling
1217 somewhat. This returns the BuildStepStatus object so it can be
1218 passed to the new Step, instead of jamming it directly into the
1220 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1222 * buildbot/process/base.py (Build.setupBuild): use both methods
1223 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1224 process a bit to match
1226 2006-06-14 Brian Warner <warner@lothar.com>
1228 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1229 docs on writing new LogObserver classes
1230 (Writing New Status Plugins): brief docs on how Status Plugins fit
1233 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1234 implement a LogObserver that counts how many unit tests have been
1236 (Trial.__init__): wire it in
1237 * buildbot/test/test_twisted.py (Counter): unit test for it
1239 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1240 to new cmd.logs['stdio'] scheme
1241 (Trial.commandComplete): same
1242 (BuildDebs.commandComplete): same
1244 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1245 LogFiles, instead of just a single one. The old single logfile is
1246 now called "stdio". LoggedRemoteCommand no longer creates a
1247 LogFile for you (the code to do that was broken anyway). If you
1248 don't create a "stdio" LogFile, then stdout/stderr will be
1250 (LogObserver): implement "LogObservers", which a BuildStep can add
1251 to parse the output of a command in real-time. The primary use is
1252 to provide more useful information to the Progress code, allowing
1253 better ETA estimates.
1254 (LogLineObserver): utility subclass which feeds complete lines to
1255 the parser instead of bytes.
1256 (BuildStep.progressMetrics): this is safer as a tuple
1257 (BuildStep.setProgress): utility method, meant to be called by
1259 (BuildStep.addLogObserver): new method, to be called at any time
1260 during the BuildStep (even before any LogFiles have been created),
1261 to attach (or schedule for eventual attachment) a LogObserver to a
1263 (StdioProgressObserver): new LogObserver which replaces the old
1264 "output" progress gatherer
1265 (LoggingBuildStep.__init__): same
1266 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1267 (LoggingBuildStep._commandComplete): must use logs['stdio']
1268 instead of the old single ".log" attribute.
1269 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1270 functionality, now subsumed into StdioProgressObserver
1271 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1272 log name changed from "output" to "stdio".
1275 * buildbot/interfaces.py (ILogFile): add the Interface used from
1276 the BuildStep towards the LogFile
1277 (ILogObserver): and the one provided by a LogObserver
1278 * buildbot/status/builder.py (LogFile): implement it
1280 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1281 HEADER constants here ..
1282 * buildbot/status/builder.py (STDOUT): .. from here
1284 2006-06-13 Brian Warner <warner@lothar.com>
1286 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1287 compatibility with python2.2, which doesn't have the 'substr in
1289 (TestP4Poller.makeTime): utility function to construct the
1290 timestamp using the same strptime() approach as p4poller does. It
1291 turns out that time.mktime() behaves slightly differently under
1292 python2.2, probably something to do with the DST flag, and that
1293 causes the test to fail under python2.2. (changing the mktime()
1294 arguments to have dst=0 instead of -1 caused it to fail under
1295 python2.3. Go figure.)
1296 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1298 2006-06-12 Brian Warner <warner@lothar.com>
1300 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1301 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1302 contributing such an excellent patch, including docs and unit
1303 tests! This makes it *so* much easier to apply. I had to update
1304 test_vc.py to handle some recent refactorings, but everything else
1305 applied smoothly. The only remaining thing I'd like to fix would
1306 be to remove the hard-wired port 1666 used by p4d, and allow it to
1307 claim any unused port. This would allow two copies of the test
1308 suite to run on the same host at the same time, as well as
1309 allowing the test suite to run while a real (production) p4d was
1310 running on the same host. Oh, and maybe we should add a warning to
1311 step.P4 that gets emitted if the slave is too old to provide the
1312 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1313 * buildbot/slave/commands.py (P4): same
1314 (P4Sync): same, some minor updates
1315 * buildbot/changes/p4poller.py: same
1316 * docs/buildbot.texinfo: same
1317 * buildbot/test/test_p4poller.py: same
1318 * buildbot/test/test_vc.py (P4): same
1320 * setup.py: add Trove classifiers for PyPI
1322 2006-06-08 Brian Warner <warner@allmydata.com>
1324 * buildbot/status/client.py
1325 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1326 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1327 build needs to be IRemote'd separately, rather than IRemote'ing
1328 the whole list at once. I can't wait until newpb's serialization
1329 adapters make this unnecessary.
1331 2006-06-06 Brian Warner <warner@lothar.com>
1333 * buildbot/process/step.py (WithProperties): make this inherit
1334 from ComparableMixin, so that reloading an unchanged config file
1335 doesn't cause us to spuriously reload any Builders which use them.
1336 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1339 2006-06-03 Brian Warner <warner@lothar.com>
1341 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1342 running py2exe on windows, contributed by Mark Hammond. Addresses
1343 SF#1401121, but I think we still need to include
1344 buildbot/scripts/sample.cfg
1345 * setup.py: include buildbot_service.py as a script under windows
1346 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1347 a py2exe application), get the icon/css datafiles from a different
1350 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1351 double-escape the build URL. Thanks to Olivier Bonnet for the
1352 patch. Fixes SF#1452801.
1354 2006-06-02 Brian Warner <warner@lothar.com>
1356 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1357 first six columns of 'svnlook' output, not just the first column,
1358 since property changes appear in the other five. Thanks to Olivier
1359 Bonnet for the patch. Fixes SF#1398174.
1361 2006-06-01 Brian Warner <warner@lothar.com>
1363 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1364 the fake build, so that title= has something to be set to
1366 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1367 attribute of the "Build #NN" link in the yellow start-the-build
1368 box to the build's reason. This means that you get a little
1369 tooltip explaining why the build was done when you hover over the
1370 yellow box. Thanks to Zandr Milewski for the suggestion.
1372 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1373 (Box.setETA): handle ETA=None (by stopping the timer)
1374 (Box.update): make the [soon] text less different than the usual
1375 text, so the rest of the text doesn't flop around so much. It
1376 would be awfully nice to figure out how to center this stuff.
1377 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1379 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1380 by default, so that any ShellCommand which fails marks the overall
1381 build as a failure. I should have done this from the beginning.
1382 Add flunkOnFailure=False to the arguments if you want to turn off
1385 2006-05-30 Brian Warner <warner@lothar.com>
1387 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1388 last-build/current-build/current-step. Show what step is currently
1389 running. Show ETA for both the overall build and the current step.
1390 Update GTK calls to modern non-deprecated forms. There's still a
1391 lot of dead code and debug noise to remove.
1393 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1394 shows up properly in status displays
1396 2006-05-28 Brian Warner <warner@lothar.com>
1398 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1399 build we use to verify that WithProperties works:
1401 ** set flunkOnFailure=True so that build failures get noticed
1402 ** set workdir='.' so that the build succeeds, otherwise it is trying
1403 to touch 'build/something', and 'build/' doesn't exist because
1404 usually that's created by a Source step
1405 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1406 this test somehow triggers, in which the 'touch' process becomes
1407 a zombie and we wait for th etimeout before giving up on it.
1409 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1410 to log the Build results and step logs to the twisted log.
1411 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1412 what went wrong if a build was expected to succeed but didn't.
1414 * buildbot/process/step_twisted.py (Trial): set the default
1415 trialMode to '--reporter=bwverbose', which specifies verbose
1416 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1417 '-to', but those are completely missing in modern Twisteds.
1419 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1420 a localhost-only port, to encourage better security
1422 * docs/buildbot.texinfo (Change Sources): mention
1425 * .darcs-boring: add a Darcs boringfile
1427 * README (REQUIREMENTS): stop claiming compatibility with
1430 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1433 2006-05-27 Brian Warner <warner@lothar.com>
1435 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1436 * docs/buildbot.texinfo: same
1438 2006-05-23 Brian Warner <warner@lothar.com>
1440 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1441 * docs/buildbot.texinfo: set version to match
1442 * NEWS: update for 0.7.3
1444 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1445 give a quick mapping from VC system to possible ChangeSources
1446 (Build Properties): add 'buildername'
1448 * buildbot/process/base.py (Build.setupStatus): oops, set
1449 'buildername' and 'buildnumber' properties
1450 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1453 2006-05-22 Brian Warner <warner@lothar.com>
1455 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1456 property interpolation better
1458 * README (INSTALLATION): remove old '-v' argument from recommended
1461 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1462 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1465 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1466 'svnversion' instead of grepping the output of 'svn info', much
1467 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1468 Bonnet for the suggestion.
1469 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1470 require the WC_PATH argument, so run 'svnversion .' instead.
1472 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1473 aren't supposed to have 'self' in their argument list
1475 2006-05-21 Brian Warner <warner@lothar.com>
1477 * buildbot/process/step.py (ShellCommand.start): make
1478 testInterpolate pass. I was passing the uninterpolated command to
1479 the RemoteShellCommand constructor
1480 (ShellCommand._interpolateProperties): oops, handle non-list
1481 commands (i.e. strings with multiple words separated by spaces in
1482 them) properly, instead of forgetting about them.
1484 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1485 to actually try to use build properties in a real build. This test
1487 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1488 to start and evaluate builds
1490 * buildbot/test/test__versions.py: add a pseudo-test to record
1491 what version of Twisted/Python/Buildbot are running. This should
1492 show up at the beginning of _trial_tmp/test.log, and exists to help
1493 debug other problems.
1495 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1496 a filename to be served as 'robots.txt' to discourage web spiders.
1497 Adapted from a patch by Tobi Vollebregt, thanks!
1498 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1499 (Waterfall.test_waterfall): tweak the way that filenames are put
1500 into the config file, to accomodate windows pathnames better.
1502 * docs/buildbot.texinfo (HTML Waterfall): document it
1504 * buildbot/process/process_twisted.py
1505 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1506 changed the build process. The new setup.py no longer takes the
1508 (FullTwistedBuildFactory.__init__): same
1509 (TwistedReactorsBuildFactory.__init__): same
1511 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1512 be placed in the [hooks] section of the central repository (the
1513 one that everybody pushes changes to).
1515 2006-05-20 Brian Warner <warner@lothar.com>
1517 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1518 .darcs-context file, use binary mode. I think this was causing a
1519 Darcs failure under windows.
1521 2006-05-19 Brian Warner <warner@lothar.com>
1523 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1524 use a timezone string of +0000 and gmtime, since this timestamp is
1525 sent to a buildmaster and %z is broken.
1527 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1528 string and localtime, since this timestamp will only be consumed
1529 locally, and %z is broken.
1531 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1532 gmtime, since this timestamp is returned to the buildmaster, and
1535 2006-05-18 Brian Warner <warner@lothar.com>
1537 * NEWS: update in preparation for next release
1539 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1540 setup-repository and do-we-have-the-vc-tools code into a separate
1541 "helper" class, which sticks around in a single module-level
1542 object. This seems more likely to continue to work in the future
1543 than having it hide in the TestCase and hope that TestCases stick
1544 around for a long time.
1546 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1547 addremove' has been deprecated in recent versions of mercurial, so
1548 use 'hg add' instead
1550 2006-05-07 Brian Warner <warner@lothar.com>
1552 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1553 operating under windows, move the file before opening it, since
1554 you can't rename a file that somebody has open.
1556 * buildbot/process/base.py (Build.setupBuild): if something goes
1557 wrong while creating a Step, log the name and arguments, since the
1558 error message when you get the number of arguments wrong is really
1561 2006-05-06 Brian Warner <warner@lothar.com>
1563 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1564 bugs in twisted-specific code not covered by my unit tests, this
1565 time use 'cmd' argument instead of self.cmd
1567 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1568 fix stupid braino: either use startwith or find()==0, not both.
1569 (TwistedReactorsBuildFactory.__init__): another dumb typo
1571 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1572 mark this test as TODO under windows, since process-killing seems
1573 dodgy there. We'll come back to this later and try to fix it
1576 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1577 and don't include a timezone
1578 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1579 This should avoid the windows-with-verbose-timezone-name problem
1581 (Patch.testPatch): add a test which runs 'patch' with less
1582 overhead than the full VCBase.do_patch sequence, to try to isolate
1583 a windows test failure. This one uses slave.commands.ShellCommand
1584 and 'patch', but none of the VC code.
1586 * buildbot/slave/commands.py (getCommand): use which() to find the
1587 executables for 'cvs', 'svn', etc. This ought to help under
1590 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1591 working directory before starting. If an earlier test failed, the
1592 leftover directory would mistakenly flunk a later test.
1593 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1594 Make sure that we use the right commandlines if which("tla") picks
1595 up "tla.exe" (as it does under windows).
1596 (TlaSupport.do_get): factor out this tla-vs-baz difference
1597 (TlaSupport.vc_create): more tla-vs-baz differences
1599 * buildbot/test/test_slavecommand.py
1600 (ShellBase.testShellMissingCommand): stop trying to assert
1601 anything about the error message: different shells on different
1602 OSes with different languages makes it hard, and it really isn't
1603 that interesting of a thing to test anyway.
1605 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1606 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1607 "Panther"), because it has a bug which flunks a couple tests in
1608 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1609 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1610 able to test that yet.
1612 2006-04-30 Brian Warner <warner@lothar.com>
1614 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1615 make sure child commands emit messages in english, so our regexps
1616 will match. Thanks to Nikaus Giger for identifying the problems.
1617 (VCBase._do_vctest_export_1): mode="export" is not responsible
1618 for setting the "got_revision" property, since in many cases it is
1619 not convenient to determine.
1620 (SVNSupport.capable): when running 'svn --version' to check for
1621 ra_local, we want error messages in english
1622 * buildbot/test/test_slavecommand.py
1623 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1624 to emit the error message in english
1626 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1627 the environment with $LC_ALL="C" so that Commands which need to
1628 parse the output of their child processes can obtain it in
1630 (SVN.parseGotRevision): call "svn info" afterwards instead of
1631 watching the output of the "svn update" or "svn checkout".
1632 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1633 (Arch.parseGotRevision): same
1634 (Bazaar.parseGotRevision): same
1635 (Mercurial.parseGotRevision): same
1637 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1638 $LC_ALL="C" when running commands under 'buildbot try', too
1640 * buildbot/test/__init__.py: remove the global os.environ()
1641 setting, instead we do it just for the tests that run commands and
1642 need to parse their output.
1644 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1645 remove the overly-short .timeout on this test, because non-DNotify
1646 platforms must fall back to polling which happens at 10 second
1647 intervals, so a 5 second timeout would never succeed.
1649 2006-04-24 Brian Warner <warner@lothar.com>
1651 * docs/buildbot.texinfo (Installing the code): update trial
1652 invocation, SF#1469116 by Niklaus Giger.
1653 (Attributes of Changes): updated branch-name examples to be
1654 a bit more realistic, SF#1475240 by Stephen Davis.
1656 * contrib/windows/buildbot2.bat: utility wrapper for windows
1657 developers, contributed by Nick Trout (after a year of neglect..
1658 sorry!). SF#1194231.
1660 * buildbot/test/test_vc.py (*.capable): store the actual VC
1661 binary's pathname in VCS[vcname], so it can be retrieved later
1662 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1663 strip out non-numeric timezone information, specifically the funky
1664 German string that his system produced that confuses CVS.
1665 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1666 allow Darcs tests to work on windows
1667 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1668 procutils.which() everywhere, to allow tryclient to work under
1669 windows. Also from Niklaus Giger, SF#1463394.
1671 * buildbot/twcompat.py (which): move the replacement for a missing
1672 twisted.python.procutils.which from test_vc.py to here, so it can
1673 be used in other places too (specifically tryclient.py)
1675 2006-04-23 Brian Warner <warner@lothar.com>
1677 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1678 bare buildbotURL/projectName line with a proper DIV, along with a
1679 CSS class of "title", from Stefan Seefeld (SF#1461675).
1680 (WaterfallStatusResource.body0): remove the redundant 'table'
1681 class from the table
1682 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1683 to the top-row TR, and class="Activity" to the second-row TR,
1684 rather than putting them in the individual TD nodes.
1686 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1687 'got_revision' build property for all VC systems that implement
1688 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1690 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1691 to determine which revision we actually obtained
1692 (CVS.parseGotRevision): implement this for CVS, which just means
1693 to grab a timestamp. Not ideal, and it depends upon the buildslave
1694 having a clock that is reasonably well syncronized with the server,
1695 but it's better than nothing.
1696 (SVN.parseGotRevision): implement it for SVN, which is accurate
1697 (Darcs.parseGotRevision): same
1698 (Arch.parseGotRevision): same
1699 (Bazaar.parseGotRevision): same
1700 (Mercurial.parseGotRevision): same
1702 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1703 keep a record of all non-stdout/stderr/header/rc status updates,
1704 for the benefit of RemoteCommands that send other useful things,
1706 (Source.commandComplete): put any 'got_revision' status values
1707 into a build property of the same name
1710 * buildbot/process/step_twisted.py (Trial): update to deal with
1711 new ShellCommand refactoring
1713 * docs/buildbot.texinfo (Build Properties): document new feature
1714 that allows BuildSteps to get/set Build-wide properties like which
1715 revision was requested and/or checked out.
1717 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1718 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1719 it. Note that this bumps the persistenceVersion of the saved Build
1720 object, so add the necessary upgrade-old-version logic to include
1721 an empty properties dict.
1723 * buildbot/process/base.py (Build.setProperty): implement it
1724 (Build.getProperty): same
1725 (Build.startBuild): change build startup to set 'branch',
1726 'revision', and 'slavename' properties at the right time
1728 * buildbot/process/step.py (BuildStep.__init__): change setup to
1729 require 'build' argument in a better way
1730 (LoggingBuildStep): split ShellCommand into two pieces, for better
1731 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1732 a single RemoteCommand that sends stdout/stderr status text. It
1733 also provides the usual commandComplete / createSummary /
1734 evaluateCommand / getText methods to be overridden...
1735 (ShellCommand): .. whereas ShellCommand is specifically for
1736 running RemoteShellCommands. Other shell-like BuildSteps (like
1737 Source) can inherit from LoggingBuildStep instead of ShellCommand
1738 (WithProperties): marker class to do build-property interpolation
1739 (Source): inherit from LoggingBuildStep instead of ShellCommand
1742 * buildbot/test/test_properties.py: test new functionality
1744 2006-04-21 Brian Warner <warner@lothar.com>
1746 * buildbot/test/test_vc.py: rename testBranch to
1747 testCheckoutBranch to keep the tests in about the right
1750 2006-04-18 Brian Warner <warner@lothar.com>
1752 * docs/buildbot.texinfo (PBListener): improve cross-references
1753 between PBListener and 'buildbot statusgui', thanks to John Pye
1756 2006-04-17 Brian Warner <warner@lothar.com>
1758 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1759 running under Twisted-1.3.0, otherwise skipped tests are reported
1762 * all: use isinstance() instead of 'type(x) is foo', suggested by
1765 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1766 oops, fix a brain-fade from the other week, when making the
1767 addStep changes. I changed all the __init__ upcalls to use the
1768 wrong superclass name.
1769 (FullTwistedBuildFactory.__init__): same
1770 (TwistedDebsBuildFactory.__init__): same
1771 (TwistedReactorsBuildFactory.__init__): same
1772 (TwistedBuild.isFileImportant): use .startswith for clarity,
1773 thanks to Neal Norwitz for the suggestions.
1775 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1776 changes, then deliver them over PB to a remote buildmaster.
1778 * contrib/svnpoller.py: added script by John Pye to poll a remote
1779 SVN repository (by running 'svn log') from a cronjob, and run
1780 'buildbot sendchange' to deliver the changes to a remote
1782 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1783 modification of svnpoller.py), same purpose, but this one loops
1784 internally (rather than expecting to run from a cronjob) and works
1786 * contrib/README.txt: same
1788 2006-04-11 Brian Warner <warner@lothar.com>
1790 * all: fix a number of incorrect names and missing imports, thanks
1791 to Anthony Baxter for the patch.
1792 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1793 remove unused buggy method.
1794 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1795 comes from shutil, not "shutils"
1796 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1797 (Arch.checkSlaveVersion): same
1798 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1800 * buildbot/process/step_twisted2.py: add some missing imports
1801 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1802 this code used to live in twisted.internet.defer
1804 2006-04-10 Brian Warner <warner@lothar.com>
1806 * buildbot/process/step.py (Mercurial): add Mercurial support
1807 * buildbot/slave/commands.py (Mercurial): same
1808 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1809 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1810 not yet tested, but 'try' support *is* covered
1811 * docs/buildbot.texinfo (Mercurial): document it
1813 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1814 some debugging messages (turned off)
1815 * buildbot/test/test_vc.py: improve debug messages
1817 2006-04-07 Brian Warner <warner@lothar.com>
1819 * buildbot/test/test_vc.py (which): define our own which() in case
1820 we can't import twisted.python.procutils, because procutils doesn't
1821 exist in Twisted-1.3
1823 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1824 of SlaveLocks for performance tests
1826 * docs/examples/twisted_master.cfg: update to match current usage
1828 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1829 password, p4 binary, pollinterval, maximum history to check.
1830 Patch from an anonymous sf.net contributor, SF#1219384.
1831 * buildbot/process/step.py (P4Sync.__init__): add username,
1832 password, and client arguments.
1833 * buildbot/slave/commands.py (P4Sync): same
1835 2006-04-05 Brian Warner <warner@lothar.com>
1837 * buildbot/process/factory.py (BuildFactory.addStep): new method
1838 to add steps to a BuildFactory. Use it instead of f.steps.append,
1839 and you can probably avoid using the s() convenience function.
1840 Patch from Neal Norwitz, sf.net #1412605.
1841 (other): update all factories to use addStep
1842 * buildbot/process/process_twisted.py: update all factories to use
1845 2006-04-03 Brian Warner <warner@lothar.com>
1847 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1848 work under windows too. Adapted from a patch by Niklaus Giger,
1849 addresses SF#1463399.
1851 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1852 spawned commands emit parseable results in english and not some
1853 other language. Patch from Niklaus Giger, SF#1463395.
1855 * README (INSTALLATION): discourage users from running unit tests on
1856 a "network drive", patch from Niklaus Giger, SF#1463394.
1858 2006-03-22 Brian Warner <warner@lothar.com>
1860 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1861 function to turn a repository-relative pathname into a (branch,
1862 branch-relative-filename) tuple. Change this function to handle
1863 the branch naming policy used by your Subversion repository.
1864 Thanks to AllMyData.com for sponsoring this work.
1866 2006-03-16 Brian Warner <warner@lothar.com>
1868 * buildbot/scripts/sample.cfg: add python-mode declaration for
1869 vim. Thanks to John Pye for the patch.
1871 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1872 command line, mention the importance of running 'crontab' as the
1873 buildmaster/buildslave user. Thanks to John Pye for the catch.
1875 2006-03-13 Brian Warner <warner@lothar.com>
1877 * buildbot/status/words.py (IRC): add an optional password=
1878 argument, which will be sent to Nickserv in an IDENTIFY message at
1879 login, to claim the nickname. freenode requires this before the
1880 bot can sent (or reply to) private messages. Thanks to Clement
1881 Stenac for the patch.
1882 * docs/buildbot.texinfo (IRC Bot): document it
1884 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1885 larger than chunkSize. Fixes SF#1349253.
1886 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1887 (Log.testConsumer): update to match new internal chunking behavior
1889 2006-03-12 Brian Warner <warner@lothar.com>
1891 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1893 * buildbot/test/test_maildir.py (MaildirTest): rename the
1894 'timeout' method, as it collides with trial's internals
1896 * buildbot/scripts/runner.py: add 'buildbot restart' command
1897 (stop): don't sys.exit() out of here, otherwise restart can't work
1898 * docs/buildbot.texinfo (Shutdown): document it
1900 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1901 * buildbot/status/html.py (Waterfall.__init__): same
1902 * buildbot/process/builder.py (Builder.startBuild): same
1903 * buildbot/process/base.py (BuildRequest): same
1904 * buildbot/sourcestamp.py (SourceStamp): same
1905 * buildbot/scheduler.py (Nightly): same
1907 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1909 * docs/buildbot.texinfo: same
1911 2006-02-17 Brian Warner <warner@lothar.com>
1913 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1914 * docs/buildbot.texinfo: set version number to match
1915 * NEWS: update for 0.7.2
1917 2006-02-16 Brian Warner <warner@lothar.com>
1919 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1921 2006-02-09 Brian Warner <warner@lothar.com>
1923 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1924 add text to explain per-build branch parameters
1925 * NEWS: mention --umask
1927 2006-02-08 Brian Warner <warner@lothar.com>
1929 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1931 (SlaveOptions.optParameters): add --umask, to make it possible to
1932 make buildslave-generated files (including build products) be
1935 * buildbot/slave/bot.py (BuildSlave.startService): same
1937 2006-01-23 Brian Warner <warner@lothar.com>
1939 * buildbot/status/builder.py: urllib.quote() all URLs that include
1940 Builder names, so that builders can include characters like '/'
1941 and ' ' without completely breaking the resulting HTML. Thanks to
1942 Kevin Turner for the patch.
1943 * buildbot/status/html.py: same
1944 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1946 * NEWS: update in preparation for upcoming release
1948 2006-01-18 Brian Warner <warner@lothar.com>
1950 * docs/examples/twisted_master.cfg: update to match the Twisted
1951 buildbot: remove python2.2, switch to exarkun's buildslaves,
1952 disable the .deb builder until we figure out how to build twisted
1953 .debs from SVN, add some ktrace debugging to the OS-X build
1954 process and remove the qt build, remove threadless builders,
1955 change freebsd builder to use landonf's buildslave.
1957 2006-01-12 Brian Warner <warner@lothar.com>
1959 * buildbot/master.py (Manhole.__init__): let port= be a strports
1960 specification string, but handle a regular int for backwards
1961 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1962 used in master.cfg to limit connections to just the local host.
1963 (BuildMaster.loadConfig): same for c['slavePortnum']
1964 * buildbot/scheduler.py (Try_Userpass.__init__): same
1965 * buildbot/status/client.py (PBListener.__init__): same
1966 * buildbot/status/html.py (Waterfall.__init__): same, for both
1967 http_port and distrib_port. Include backwards-compatibility checks
1968 so distrib_port can be a filename string and still mean unix:/foo
1969 * docs/buildbot.texinfo (Setting the slaveport): document it
1970 (Debug options): same
1971 (HTML Waterfall): same
1974 * buildbot/test/test_config.py (ConfigTest): test it
1976 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1977 slaveport's disownServiceParent deferred to fire before opening
1978 the new one. Fixes an annoying bug in the unit tests.
1980 2006-01-03 Brian Warner <warner@lothar.com>
1982 * buildbot/master.py (BuildMaster): remove the .schedulers
1983 attribute, replacing it with an allSchedulers() method that looks
1984 for all IService children that implement IScheduler. Having only
1985 one parent/child relationship means fewer opportunities for bugs.
1986 (BuildMaster.allSchedulers): new method
1987 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1988 also fix ugly bug that caused any config-file reload to
1989 half-forget about the earlier Schedulers, causing an exception
1990 when a Change arrived and was handed to a half-connected
1991 Scheduler. The exception was in scheduler.py line 54ish:
1992 self.parent.submitBuildSet(bs)
1993 exceptions.AttributeError: 'NoneType' object has no attribute
1995 (BuildMaster.addChange): update to use allSchedulers()
1997 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1998 to work properly with twisted-1.3.0, where you must explicitly
1999 include the __implements__ from parent classes
2000 (BaseScheduler.__repr__): make it easier to distinguish distinct
2002 (BaseUpstreamScheduler.__implements__): same
2004 * buildbot/status/builder.py (Status.getSchedulers): update to
2006 * buildbot/test/test_run.py (Run.testMaster): same
2007 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2008 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2009 make sure Scheduler instances are left alone when an identical
2010 config file is reloaded
2011 (ConfigElements.testSchedulers): make sure Schedulers are properly
2014 * Makefile (TRIALARGS): my local default Twisted version is now
2015 2.1.0, update the trial arguments accordingly
2017 2005-12-22 Brian Warner <warner@lothar.com>
2019 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2022 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2023 addChange in the parent class, although I suspect this should be
2024 fixed better in the future.
2026 2005-11-26 Brian Warner <warner@lothar.com>
2028 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2029 explode when branch==None, thanks to Kevin Turner for the catch
2030 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2033 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2035 * docs/buildbot.texinfo: same
2037 2005-11-26 Brian Warner <warner@lothar.com>
2039 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2040 * docs/buildbot.texinfo: set version number to match
2042 2005-11-26 Brian Warner <warner@lothar.com>
2044 * NEWS: update for 0.7.1
2046 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2047 sure that unsubscribe works even if we never sent an ETA update.
2048 Also, don't explode on duplicate unsubscribe.
2049 (BuildStepStatus.addLog): make the convenience "return self"-added
2050 watcher automatically unsubscribe when the Step finishes.
2051 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2052 (BuildStatus.stepStarted): same auto-unsubscribe
2053 (BuilderStatus.buildStarted): same auto-unsubscribe
2055 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2057 (IStatusReceiver.stepStarted): same
2058 (IStatusReceiver.logStarted): same
2060 * buildbot/test/test_run.py (Status): move the Status test..
2061 * buildbot/test/test_status.py (Subscription): .. to here
2063 2005-11-25 Brian Warner <warner@lothar.com>
2065 * NEWS: more updates
2067 * buildbot/locks.py: fix the problem in which loading a master.cfg
2068 file that changes some Builders (but not all of them) can result
2069 in having multiple copies of the same Lock. Now, the real Locks
2070 are kept in a table inside the BotMaster, and the Builders/Steps
2071 use "LockIDs", which are still instances of MasterLock and
2072 SlaveLock. The real Locks are instances of the new RealMasterLock
2073 and RealSlaveLock classes.
2074 * buildbot/master.py (BotMaster.getLockByID): new method to
2075 convert LockIDs into real Locks.
2076 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2077 into real Locks before building
2078 * buildbot/process/step.py (BuildStep.startStep): same
2079 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2080 exercises the problem
2083 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2084 what Schedulers are available
2086 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2087 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2088 'cron'-style build scheduling at certain times of day, week,
2090 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2092 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2093 handling: treat self.fileIsImportant more as an attribute that
2094 contains a callable than as a method. If the attribute is None,
2095 don't call it and assume all filenames are important. It is still
2096 possible to provide a fileIsImportant method in a subclass,
2098 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2100 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2101 test using AnyBranchScheduler with fileIsImportant=None
2103 2005-11-24 Brian Warner <warner@lothar.com>
2105 * buildbot/test/test_config.py (StartService): don't claim a fixed
2106 port number, instead set slavePort=0 on the first pass, figure out
2107 what port was allocated, then switch to a config file that uses
2110 * buildbot/master.py (BuildMaster.loadConfig): close the old
2111 slaveport before opening the new one, because unit tests might
2112 replace slavePort=0 with the same allocated portnumber, and if we
2113 don't wait for the old port to close first, we get a "port already
2114 in use" error. There is a tiny race condition here, but the only
2115 threat is from other programs that bind (statically) to the same
2116 port number we happened to be allocated, and only if those
2117 programs use SO_REUSEADDR, and only if they get control in between
2120 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2122 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2123 deleted ChangeSources before adding any new ones
2124 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2125 compare_attrs, to make sure that a config-file reload does not
2126 unnecessarily replace an unmodified ChangeSource instance
2127 * buildbot/test/test_config.py (ConfigTest.testSources): update
2129 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2130 mean "don't build anything", and add a warning if it gets used
2131 because it isn't actually useful.
2133 * contrib/svn_buildbot.py: update example usage to match the port
2134 number that gets used by the PBChangeSource
2135 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2137 2005-11-22 Brian Warner <warner@lothar.com>
2139 * NEWS: start collecting items for next release
2141 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2142 revisions are strings
2143 (P4Sync.computeSourceRevision): same
2145 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2146 to the Buildbot's overall status page
2147 (StatusResourceBuilder.body): same
2149 2005-11-15 Brian Warner <warner@lothar.com>
2151 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2152 config-file loading, specifically to make sure old StatusTargets
2153 are finished shutting down before new ones start up (thus
2154 resolving a bug in which changing the Waterfall object would fail
2155 because both new and old instances were claiming the same
2156 listening port). Also load new Schedulers after all the new
2157 Builders are set up, in case they fire off a new build right away.
2158 * buildbot/test/test_config.py (StartService): test it
2160 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2161 the branch name to the mail body
2163 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2164 Without it, a config-file reload fails to update an existing
2166 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2167 username/passwd to compare_attrs, for the same reason
2168 * buildbot/status/html.py (Waterfall): add favicon to
2169 compare_attrs, same reason
2171 2005-11-05 Brian Warner <warner@lothar.com>
2173 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2174 baserev before stuffing it in the jobfile. This resolves problems
2175 under SVN (and probably Arch) where revisions are expressed as
2176 numbers. I'm inclined to use string-based revisions everywhere in
2177 the future, but this fix should be safe for now. Thanks to Steven
2178 Walter for the patch.
2180 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2181 binary mode when opening pickle files, to make windows work
2182 better. Thanks to Dobes Vandermeer for the catch.
2183 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2184 (BuilderStatus.getBuildByNumber): same
2185 (Status.builderAdded): same
2186 * buildbot/master.py (BuildMaster.loadChanges): same
2188 * buildbot/util.py (Swappable): delete unused leftover code
2190 * buildbot/process/step.py (SVN): when building on a non-default
2191 branch, add the word "[branch]" to the VC step's description, so
2192 it is obvious that we're not building the usual stuff. Likewise,
2193 when we are building a specific revision, add the text "rNNN" to
2194 indicate what that revision number is. Thanks to Brad Hards and
2195 Nathaniel Smith for the suggestion.
2196 (Darcs.startVC): same
2197 (Arch.startVC): same
2198 (Bazaar.startVC): same
2200 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2201 typo, caught by Mark Dillavou, closes SF#1216636.
2203 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2204 about a test to add some day
2206 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2207 the 'full-2.3' build, and the 'reactors' build is now run under
2208 python-2.4 because the buildslave no longer has gtk/etc bindings
2209 for earlier versions.
2211 2005-11-03 Brian Warner <warner@lothar.com>
2213 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2214 method, takes an IBuildStatus and rebuilds it. It might make more
2215 sense to add this to IBuildControl instead, but that instance goes
2216 away completely once the build has finished, and resubmitting
2217 builds can take place weeks later.
2218 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2219 * buildbot/status/html.py (StatusResourceBuild): also stash an
2220 IBuilderControl so we can use resubmitBuild.
2221 (StatusResourceBuild.body): render "resubmit" button if we can.
2222 Also add hrefs for each BuildStep
2223 (StatusResourceBuild.rebuild): add action for "resubmit" button
2224 (StatusResourceBuilder.getChild): give it an IBuilderControl
2226 * buildbot/status/builder.py (Status.getURLForThing): change the
2227 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2228 that live as targets of buttons like "stop" and "rebuild" can't
2230 * buildbot/status/builder.py (Status.getURLForThing): same
2231 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2232 (StepBox.getBox): same
2233 * buildbot/test/test_web.py (GetURL): same
2236 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2237 exclusivity checks after Source.__init__ upcall, so misspelled
2238 arguments will be reported more usefully
2239 (Darcs.__init__): same
2241 2005-10-29 Brian Warner <warner@lothar.com>
2243 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2244 builder. Move the Try scheduler off to a separate port.
2246 2005-10-27 Brian Warner <warner@lothar.com>
2248 * buildbot/clients/gtkPanes.py
2249 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2250 to cause the app to crash, now they don't.
2252 * buildbot/clients/debug.py: display the buildmaster's location
2253 in the window's title bar
2255 2005-10-26 Brian Warner <warner@lothar.com>
2257 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2258 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2259 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2261 * buildbot/status/html.py (td): put a single non-breaking space
2262 inside otherwise empty <td> elements, as a workaround for buggy
2263 browsers which would optimize them away (along with any associated
2264 styles, like the kind that create the waterfall grid borders).
2265 Patch from Frerich Raabe.
2267 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2268 argv-list as an argument, defaulting to ["-to"], which is
2269 appropriate for the Trial that comes with Twisted-2.1.0 and
2270 earlier. The Trial in current Twisted SVN wants
2271 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2272 defaults to an empty list.
2273 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2274 match it, now that trialMode= is a list instead of a single string
2276 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2278 * docs/buildbot.texinfo: same
2280 2005-10-24 Brian Warner <warner@lothar.com>
2282 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2283 * docs/buildbot.texinfo: set version number to match
2285 2005-10-24 Brian Warner <warner@lothar.com>
2287 * README: update for 0.7.0
2289 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2291 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2292 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2293 send the branch= argument unless the user really provided one, to
2294 retain compatibility with older buildmasters that don't accept
2296 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2299 * docs/buildbot.texinfo: update lots of stuff
2301 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2302 to the 'buildbot sendchange' command
2303 * buildbot/clients/sendchange.py (Sender.send): same
2304 * buildbot/changes/pb.py (ChangePerspective): same
2305 * buildbot/test/test_changes.py (Sender.testSender): test it
2307 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2308 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2309 for consistency with other BuildStep arguments that use camelCase.
2310 Well, at least more of them use camelCase (like flunkOnWarnings)
2311 than don't.. I wish I'd picked one style and stuck with it
2312 earlier. Annoying, but it's best done before the release, since
2313 these arguments didn't exist at all in 0.6.6 .
2315 * buildbot/test/test_vc.py (SVN.testCheckout): same
2316 (Darcs.testPatch): same
2317 * docs/buildbot.texinfo (SVN): document the change
2318 (Darcs): same, add some build-on-branch docs
2319 * docs/examples/twisted_master.cfg: match change
2321 * buildbot/process/step.py (BuildStep): rename
2322 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2323 how it is normally used.
2324 * buildbot/test/test_steps.py (Version.checkCompare): same
2326 * buildbot/process/step.py (CVS.startVC): refuse to build
2327 update/copy -style builds on a non-default branch with an old
2328 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2329 concern is that it will do a VC 'update' in an existing tree when
2330 it is supposed to be switching branches (and therefore clobbering
2331 the tree to do a full checkout), thus building the wrong source.
2332 This used to be a warning, but I think the confusion it is likely
2333 to cause warrants making it an error.
2334 (SVN.startVC): same, also make mode=export on old slaves an error
2335 (Darcs.startVC): same
2336 (Git.startVC): improve error message for non-Git-enabled slaves
2337 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2338 specific revision is built on a slave that doesn't pay attention
2339 to args['revision'], because for slowly-changing trees it will
2340 probably do the right thing, and because we have no way to tell
2341 whether we're asking it to build the most recent version or not.
2342 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2344 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2345 that 'master' is in host:portnum format, to catch errors sooner
2347 2005-10-23 Brian Warner <warner@lothar.com>
2349 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2350 when creating the list of warning messages, include the line
2351 immediately after each WARNING: line, since that's usually where
2352 the file and line number wind up.
2354 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2359 2005-10-22 Brian Warner <warner@lothar.com>
2361 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2362 patch from Brad Hards
2363 * buildbot/status/classic.css: same
2364 * buildbot/test/test_web.py (Waterfall): match changes
2366 * buildbot/test/test_steps.py (BuildStep.setUp): set
2367 nextBuildNumber so the test passes
2368 * buildbot/test/test_status.py (MyBuilder): same
2370 * buildbot/status/html.py (StatusResourceBuild.body): revision
2371 might be numeric, so stringify it before html-escapifying it
2372 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2373 timer for the upcoming build
2374 * buildbot/status/classic.css: add background-color attributes for
2375 offline/waiting/building classes
2377 * buildbot/status/builder.py (BuildStatus): derive from
2378 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2379 the default (i.e. unknown) .slavename to "???" instead of None,
2380 since even unknown slavenames need to be printed eventually.
2381 (BuilderStatus): also derive from styles.Versioned . More
2382 importantly, determine .nextBuildNumber at creation/unpickling
2383 time by scanning the directory of saved BuildStatus instances and
2384 choosing one larger than the highest-numbered one found. This
2385 should fix the problem where random errors during upgrades cause
2386 the buildbot to forget about earlier builds. .nextBuildNumber is
2387 no longer stored in the pickle.
2388 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2389 at least log the error. Also call Builder.determineNextBuildNumber
2390 once the basedir is set.
2392 * buildbot/master.py (BuildMaster.loadChanges): do
2393 styles.doUpgrade afterwards, in case I decide to make Changes
2394 derived from styles.Versioned some day and forget to make this
2398 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2399 when running under older pythons (<2.3) in which the shlex module
2400 doesn't have a 'split' function.
2402 * buildbot/process/step.py (ShellCommand.start): make
2403 errorMessages= be a list of strings to stuff in the log before the
2404 command actually starts. This makes it easier to flag multiple
2405 warning messages, e.g. when the Source steps have to deal with an
2407 (CVS.startVC): handle slaves that don't handle multiple branches
2408 by switching into 'clobber' mode
2409 (SVN.startVC): same. Also reject branches without base_url
2410 (Darcs.startVC): same. Also reject revision= in older slaves
2411 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2412 (Bazaar.startVC): same, and test for baz separately than for arch
2414 * buildbot/slave/commands.py (cvs_ver): document new features
2416 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2417 (BuildStep.slaveVersionNewEnough): more useful utility method
2418 * buildbot/test/test_steps.py (Version): start testing it
2420 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2421 the 'force' command requires python2.3, for the shlex.split method
2423 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2424 since we don't use it anymore. The Twisted buildbot uses a
2427 2005-10-21 Brian Warner <warner@lothar.com>
2429 * buildbot/process/process_twisted.py: rework all BuildFactory
2430 classes to take a 'source' step as an argument, instead of
2431 building up the SVN instance in the factory.
2432 * docs/examples/twisted_master.cfg: enable build-on-branch by
2433 providing a base_url and default_branch
2435 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2436 control over --branch and --revision, not that they are always
2438 * buildbot/status/html.py (StatusResourceBuilder.force): same
2439 (StatusResourceBuild.body): display SourceStamp components
2441 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2442 IRC 'force' command, so it can be shared with an eventual
2443 command-line-tool 'buildbot force' mode.
2444 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2446 2005-10-20 Brian Warner <warner@lothar.com>
2448 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2450 * docs/examples/twisted_master.cfg: update to use Schedulers
2452 * buildbot/scripts/sample.cfg: update with Schedulers
2454 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2455 method specifically for use by HTML "force build" button and the
2456 IRC "force" command. Raises an immediate error if there are no
2458 (IBuilderControl.requestBuild): make this just submit a build, not
2459 try to check for existing slaves or set up any when-finished
2460 Deferreds or anything.
2461 * buildbot/process/builder.py (BuilderControl): same
2462 * buildbot/status/html.py (StatusResourceBuilder.force): same
2463 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2464 * buildbot/test/test_slaves.py: same
2465 * buildbot/test/test_web.py: same
2467 2005-10-19 Brian Warner <warner@lothar.com>
2469 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2470 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2472 2005-10-18 Brian Warner <warner@lothar.com>
2474 * buildbot/status/html.py: provide 'status' argument to most
2475 StatusResourceFOO objects
2476 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2477 and Logfiles" section to make the Build page into a more-or-less
2478 comprehensive source of status information about the build
2480 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2481 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2483 2005-10-17 Brian Warner <warner@lothar.com>
2485 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2486 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2487 out what to do about other projects: the correct options for
2488 recent Twisteds will not work for older ones.
2490 2005-10-15 Brian Warner <warner@lothar.com>
2492 * buildbot/status/builder.py (Status.getURLForThing): add method
2493 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2494 use this in email/IRC status clients to make them more useful, by
2495 providing the end user with hints on where to learn more about the
2496 object being reported on.
2497 * buildbot/test/test_web.py (GetURL): tests for it
2499 2005-10-14 Brian Warner <warner@lothar.com>
2501 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2502 fix bug resulting from deferredResult changes
2504 2005-10-13 Brian Warner <warner@lothar.com>
2506 * buildbot/test/test_changes.py: remove use of deferredResult
2507 * buildbot/test/test_config.py: same
2508 * buildbot/test/test_control.py: same
2509 * buildbot/test/test_status.py: same
2510 * buildbot/test/test_vc.py: this is the only remaining use, since
2511 it gets used at module level. This needs to be replaced by some
2512 sort of class-level run-once routine.
2514 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2516 * lots: implement multiple slaves per Builder, which means multiple
2517 current builds per Builder. Some highlights:
2518 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2519 of (state,currentBuilds) instead of (state,currentBuild)
2520 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2521 (IBuildStatus.getSlavename): new method, so you can tell which
2522 slave got used. This only gets set when the build completes.
2523 (IBuildRequestStatus.getBuilds): new method
2525 * buildbot/process/builder.py (SlaveBuilder): add a .state
2526 attribute to track things like ATTACHING and IDLE and BUILDING,
2528 (Builder): .. the .slaves attribute here, which has been turned
2529 into a simple list of available slaves. Added a separate
2530 attaching_slaves list to track ones that are not yet ready for
2532 (Builder.fireTestEvent): put off the test-event callback for a
2533 reactor turn, to make tests a bit more consistent.
2534 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2535 ping fails due to an exception. This needs work, I'm worried that
2536 a code error could lead to a constantly re-connecting slave.
2537 Especially since I'm trying to move to a distinct remote_ping
2538 method, separate from the remote_print that we currently use.
2539 (BuilderControl.requestBuild): return a convenience Deferred that
2540 provides an IBuildStatus when the build finishes.
2541 (BuilderControl.ping): ping all connected slaves, only return True
2542 if they all respond.
2544 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2545 reconnect when we shut down.
2547 * buildbot/status/builder.py: implement new methods, convert
2548 one-build-at-a-time methods to handle multiple builds
2549 * buildbot/status/*.py: do the same in all default status targets
2550 * buildbot/status/html.py: report the build's slavename in the
2551 per-Build page, report all buildslaves on the per-Builder page
2553 * buildbot/test/test_run.py: update/create tests
2554 * buildbot/test/test_slaves.py: same
2555 * buildbot/test/test_scheduler.py: remove stale test
2557 * docs/buildbot.texinfo: document the new builder-specification
2558 'slavenames' parameter
2560 2005-10-12 Brian Warner <warner@lothar.com>
2562 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2563 report failure correctly, causing Dependent builds to run when
2564 they shouldn't have.
2565 * buildbot/status/builder.py (BuildSetStatus): same
2566 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2567 (Set.testSuccess): test the both-pass case too
2568 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2569 fix this test: it was ending too early, masking the failure before
2570 (Logger): specialized StatusReceiver to make sure the dependent
2571 builds aren't even started, much less completed.
2573 2005-10-07 Brian Warner <warner@lothar.com>
2575 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2576 bot.SlaveBuilder being disowned in the middle of a build
2578 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2579 this inherit from StatusReceiver. Also upcall in __init__. This
2580 fixes the embarrasing crash when the new buildSetSubmitted method
2581 is invoked and Waterfall/etc don't implement their own.
2582 * buildbot/test/test_run.py: add a TODO note about a test to catch
2583 just this sort of thing.
2585 * buildbot/process/builder.py (Builder.attached): remove the
2586 already-attached warning, this situation is normal. Add some
2587 comments explaining it.
2589 2005-10-02 Brian Warner <warner@lothar.com>
2591 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2592 OverflowError when setting up dnotify, because some 64-bit systems
2593 have problems with signed-vs-unsigned constants and trip up on the
2594 DN_MULTISHOT flag. Patch from Brad Hards.
2596 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2598 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2599 progressMetrics, description, descriptionDone to the 'parms' list,
2600 and make use the 'parms' list from the implementation class
2601 instead of only BuildStep to initialize the parameters. This
2602 allows buildbot.process.factory.s() to initialize all the parms,
2603 not just those defined in directly by BuildStep.
2605 2005-09-03 Brian Warner <warner@lothar.com>
2607 * NEWS: start adding items for the next release
2609 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2610 python2.2 tests, change 'Quick' builder to only use python2.3
2612 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2614 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2615 the "Ping Builder" button if the build control is available; the
2616 user sees an exception otherwise
2618 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2620 2005-09-01 Brian Warner <warner@lothar.com>
2622 * buildbot/interfaces.py (IBuilderStatus.getState): update
2623 signature, point out that 'build' can be None
2624 (IBuildStatus.getETA): point out ETA can be none
2626 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2628 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2630 2005-08-31 Brian Warner <warner@lothar.com>
2632 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2633 update to match correct signature: removed 'eta' argument
2634 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2636 2005-08-30 Brian Warner <warner@lothar.com>
2638 * buildbot/status/builder.py (LogFile): remove the assertion that
2639 blows up when you try to overwrite an existing logfile, instead
2640 just emit a warning. This case gets hit when the buildmaster is
2641 killed and doesn't get a chance to write out the serialized
2642 BuilderStatus object, so the .nextBuildNumber attribute gets out
2645 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2646 the 'buildbot sendchange' arguments, for the Darcs context file
2647 * docs/buildbot.texinfo (sendchange): document it
2649 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2650 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2651 (IStatus.getSchedulers): new method
2652 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2653 (Status.getSchedulers): implement
2654 * buildbot/process/builder.py (Builder): maintain
2655 BuilderStatus.pendingBuilds
2656 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2657 (TryBase.addChange): Try schedulers should ignore Changes
2659 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2660 for 'try' on CVS/SVN
2661 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2663 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2664 report status properly.
2665 (Try.createJob): implement unique buildset IDs
2667 * buildbot/status/client.py (StatusClientPerspective): add a
2668 perspective_getBuildSets method for the benefit of jobdir-style
2670 * docs/buildbot.texinfo (try): more docs
2671 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2674 2005-08-18 Brian Warner <warner@lothar.com>
2676 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2677 actually work. It's functional but still kind of clunky. Also, it
2678 only works with the pb-style.. needs to be made to work with the
2681 * buildbot/status/client.py (RemoteBuildSet): new class
2682 (RemoteBuildRequest): same
2683 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2684 object, not the internal BuildStatus object.
2685 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2686 outside of the usual buildStarted() return value.
2687 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2689 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2690 (Try_Userpass_Perspective.perspective_try): return a remotely
2691 usable BuildSetStatus object
2693 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2694 isStarted()/waitUntilStarted()
2696 2005-08-16 Brian Warner <warner@lothar.com>
2698 * buildbot/status/builder.py: implement IBuildSetStatus and
2699 IBuildRequestStatus, wire them into place.
2700 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2701 methods into the BuildSetStatus object.
2702 * buildbot/interfaces.py: same
2703 (IStatus.getBuildSets): new method to get pending BuildSets
2704 (IStatusReceiver.buildsetSubmitted): new method which hears about
2706 * buildbot/master.py (BuildMaster.submitBuildSet): same
2707 * buildbot/process/base.py (BuildRequest): same, replace
2708 waitUntilStarted with subscribe/unsubscribe
2709 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2710 subscribe instead of waitUntilStarted
2711 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2713 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2715 * buildbot/test/test_buildreq.py: update for new code
2716 * buildbot/test/test_control.py (Force.testRequest): same
2719 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2720 for Darcs to not use the tempfile module, so it works under
2721 python-2.2 too. We really didn't need the full cleverness of that
2722 module, since the slave has exclusive control of its own builddir.
2724 2005-08-15 Brian Warner <warner@lothar.com>
2726 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2727 for CVS trees. It doesn't work for non-trunk branches,
2729 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2732 * Makefile: make it easier to test against python2.2
2734 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2735 tearDown2, so things like Arch can unregister archives as they're
2736 shutting down. The previous subclass-override-tearDown technique
2737 resulted in a nested maybeWait() and test failures under
2740 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2741 where we can (Arch), add a branch= argument to set the branch used
2743 (BazExtractor): extract the branch too
2744 (TlaExtractor): same
2745 * buildbot/scripts/runner.py (TryOptions): add --branch
2746 * docs/buildbot.texinfo (try): document --branch/try_branch
2748 * buildbot/slave/commands.py (Darcs): implement get-revision for
2749 Darcs, so that 'try' will work. This requires the tempfile module
2752 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2753 of revisions, branches, and 'try' in the process.
2755 2005-08-11 Brian Warner <warner@lothar.com>
2757 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2758 this, it got broken at some point in the last few releases
2759 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2760 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2761 specifically the removal of ETA information from the tuple
2763 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2766 * docs/buildbot.texinfo (try): document both --builder and
2767 'try_builders' in .buildbot/options
2768 * buildbot/scripts/runner.py (TryOptions): add --builder,
2769 accumulate the values into opts['builders']
2770 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2771 * buildbot/test/test_runner.py (Try): add some quick tests to make
2772 sure 'buildbot try --options' and .buildbot/options get parsed
2773 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2774 use --builder control
2776 * docs/buildbot.texinfo (try): add --port argument to PB style
2778 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2779 actual SourceStamp. Still need to extract a branch name, somehow.
2780 (Try): finish implementing the try client side, still need a UI
2781 for specifying which builders to use
2782 (Try.getopt): factor our options/config-file reading
2783 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2785 * buildbot/test/test_vc.py: match SourceStampExtractor change
2787 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2788 causes the twisted log to be sent to stderr
2790 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2792 2005-08-10 Brian Warner <warner@lothar.com>
2794 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2795 style is 90% done, still missing status reporting or waiting for
2796 the buildsets to finish, and it is completely untested.
2798 * buildbot/trybuild.py: delete file, move contents to ..
2799 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2800 * buildbot/test/test_vc.py: match the move
2802 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2803 of the TryScheduler, no buildsetID or status-tracking support yet
2804 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2806 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2807 possible to set the basedir after __init__ time, so it is easier
2808 to use as a Service-child of the BuildMaster instance
2810 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2811 that delivers messages to its Service parent instead of requiring
2812 a subclass to be useful. This turns out to be much easier to build
2815 * buildbot/scripts/tryclient.py (createJob): utility code to
2816 create jobfiles, will eventually be used by 'buildbot try'
2818 2005-08-08 Brian Warner <warner@lothar.com>
2820 * docs/buildbot.texinfo (try): add docs on the
2821 as-yet-unimplemented Try scheduler
2823 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2824 * buildbot/test/test_scheduler.py: .. here
2825 (Scheduling.testTryJobdir): add placeholder test for 'try'
2827 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2828 addEntry merging (>=chunkSize) behavior
2829 (Log.testConsumer): update to handle new callLater(0) behavior
2831 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2832 both the MAX_LENGTH bugfix and the resumeProducing hang.
2834 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2835 put off the actual resumeProducing for a moment with
2836 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2837 causes large logfiles to hang midway through.
2839 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2840 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2841 and to improve memory usage when streaming the file out to a web
2843 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2844 make this work cleanly
2846 2005-08-03 Brian Warner <warner@lothar.com>
2848 * buildbot/trybuild.py: new file for 'try' utilities
2849 (getSourceStamp): run in a tree, find out the baserev+patch
2850 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2851 implemented for SVN and Darcs, still working on Arch. I don't know
2852 how to make CVS work yet.
2854 * docs/buildbot.texinfo: document the 'buildbot' command-line
2855 tool, including the not-yet-implemented 'try' feature, and the
2856 in-flux .buildbot/ options directory.
2858 2005-07-20 Brian Warner <warner@lothar.com>
2860 * buildbot/locks.py: added temporary id() numbers to Lock
2861 descriptions, to track down a not-really-sharing-the-Lock bug
2863 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2865 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2866 needed for python2.2 compatibility
2867 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2868 are from the __future__
2870 2005-07-19 Brian Warner <warner@lothar.com>
2872 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2873 message when schedulers use unknown builders
2875 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2876 SlaveLock('name') and MasterLock('name') are distinct
2878 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2879 c['schedulers'] in such a way that we can actually accept
2881 * buildbot/test/test_config.py: check it
2883 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2884 utility method to *all* the Schedulers
2885 (Periodic.listBuilderNames): same
2887 * docs/buildbot.texinfo (Interlocks): update chapter to match
2890 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2891 to make sure that c['sources'], c['schedulers'], and c['status']
2892 are all lists of the appropriate objects, and that the Schedulers
2893 all point to real Builders
2894 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2895 'listBuilderNames' utility method to support this
2896 * buildbot/scheduler.py: implement the utility method
2897 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2899 * docs/buildbot.texinfo: add some @cindex entries
2901 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2902 if it wasn't already set: most tla commands will fail unless one
2904 (Arch.createRepository): and disable bazaar's revision cache, since
2905 they cause test failures (the multiple repositories we create all
2906 interfere with each other through the cache)
2908 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2909 bring it properly up to date with twisted-2.0 test guidelines
2911 * buildbot/master.py (BuildMaster): remove references to old
2912 'interlock' module, this caused a bunch of post-merge test
2914 * buildbot/test/test_config.py: same
2915 * buildbot/process/base.py (Build): same
2917 * buildbot/test/test_slaves.py: stubs for new test case
2919 * buildbot/scheduler.py: add test-case-name tag
2920 * buildbot/test/test_buildreq.py: same
2922 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2923 unnecessary init code
2924 (Bot.remote_setBuilderList): match it
2926 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2928 * buildbot/changes/mail.py (parseSyncmail): update comment
2930 * buildbot/test/test_slavecommand.py: disable Shell tests on
2931 platforms that don't suport IReactorProcess
2933 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2934 all places where we open logfiles. It causes OS-X to open the file
2935 in some weird mode that that prevents us from mixing reads and
2936 writes to the same filehandle, which we depend upon to implement
2937 _generateChunks properly. This change doesn't appear to break
2938 win32, on which "b" and "t" are treated differently but a missing
2939 flag seems to be interpreted as "t".
2941 2005-07-18 Brian Warner <warner@lothar.com>
2943 * buildbot/slave/commands.py (ShellCommand): overhaul
2944 error-handling code, to try and make timeout/interrupt work
2945 properly, and make win32 happier
2946 * buildbot/test/test_slavecommand.py: clean up, stop using
2947 reactor.iterate, add tests for timeout and interrupt
2948 * buildbot/test/sleep.py: utility for a new timeout test
2950 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2951 code from the local-usebranches branch
2953 2005-07-17 Brian Warner <warner@lothar.com>
2955 * buildbot/process/process_twisted.py
2956 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2957 minutes, to match the other twisted BuildFactories, and don't
2958 excuse failures in c/qt/win32 reactors any more.
2960 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2961 'freebsd' builders, since the buildslaves have been unavailable
2964 2005-07-13 Brian Warner <warner@lothar.com>
2966 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2967 build-on-branch feature
2969 * buildbot/process/step.py (Darcs.__init__): add base_url and
2970 default_branch arguments, just like SVN
2971 (Arch.__init__): note that the version= argument is really the
2974 * buildbot/slave/commands.py (SourceBase): keep track of the
2975 repository+branch that was used for the last checkout in
2976 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2977 match, we clobber the directory and perform a fresh checkout
2978 rather than trying to do an in-place update. This should protect
2979 us against trying to get to branch B by doing an update in a tree
2980 obtained from branch A.
2981 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2982 (SVN.setup): same, just the svnurl
2983 (Darcs.setup): same, just the repourl
2984 (Arch.setup): same, arch coordinates (url), version, and
2985 buildconfig. Also pull the buildconfig from the args dictionary,
2986 which we weren't doing before, so the build-config was effectively
2988 (Arch.sourcedirIsUpdateable): don't try to update when we're
2989 moving to a specific revision: arch can't go backwards, so it is
2990 safer to just clobber the tree and checkout a new one at the
2992 (Bazaar.setup): same sourcedata as Arch
2994 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2995 use maybeWait, to work with twisted-1.3.0 and twcompat
2996 (Dependencies.testRun_Pass): same
2998 * buildbot/test/test_vc.py: rearrange, cleanup
3000 * buildbot/twcompat.py: add defer.waitForDeferred and
3001 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3002 can work under twisted-1.3.0 .
3004 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3005 now created at setUp time. This increases the runtime of the test
3006 suite considerably (from 91 seconds to 151), but it removes the
3007 need for an offline tarball, which should solve a problem I've
3008 seen where the test host has a different version of svn than the
3009 tarball build host. The new code also validates that mode=update
3010 really picks up recent commits. This approach will also make it
3011 easier to test out branches, because the code which creates the VC
3012 branches is next to the code which uses them. It will also make it
3013 possible to test some change-notification hooks, by actually
3014 performing a VC commit and watching to see the ChangeSource get
3017 2005-07-12 Brian Warner <warner@lothar.com>
3019 * docs/buildbot.texinfo (SVN): add branches example
3020 * docs/Makefile (buildbot.ps): add target for postscript manual
3022 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3023 * buildbot/test/test_locks.py: same
3025 * buildbot/process/step.py (Darcs): comment about default branches
3027 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3028 c['interlocks'] in the config file, complain if it is present.
3029 Scan all locks in c['builders'] to make sure the Locks they use
3031 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3032 add some tests to check for non-uniquely-named Locks
3033 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3034 since the unique-Lock validation code requires it now
3036 * buildbot/locks.py: fix test-case-name
3038 * buildbot/interlock.py: remove old file
3040 2005-07-11 Brian Warner <warner@lothar.com>
3042 * buildbot/test/test_interlock.py: rename to..
3043 * buildbot/test/test_locks.py: .. something shorter
3045 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3046 versions (after 2.0.1) changed internet.TCPClient to shut down the
3047 connection in stopService. Change the code to handle this
3050 * buildbot/process/base.py (Build): handle whole-Build locks
3051 * buildbot/process/builder.py (Builder.compareToSetup): same
3052 * buildbot/test/test_interlock.py: make tests work
3054 * buildbot/process/step.py (BuildStep.startStep): complain if a
3055 Step tries to claim a lock that's owned by its own Build
3056 (BuildStep.releaseLocks): typo
3058 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3059 file reloads don't replace unchanged Builders
3061 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3062 rewrite to cover new Locks instead of old c['interlocks']
3063 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3067 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3068 start the master and connect the buildslave
3070 * buildbot/process/step.py (FailingDummy.done): finish with a
3071 FAILURE status rather than raising an exception
3073 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3074 stringify a BuildRequest.reason that is None
3076 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3078 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3079 allow scheduler.Dependent to work
3080 * buildbot/buildset.py (BuildSet): set .reason and .results
3082 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3083 slaves, to make the test stop hanging. It still fails, of course,
3084 because I haven't even started to implement Locks.
3086 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3088 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3089 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3090 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3091 (Dependent): new class for downstream build dependencies
3092 * buildbot/test/test_dependencies.py: tests (still failing)
3094 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3096 2005-07-07 Brian Warner <warner@lothar.com>
3098 * buildbot/test/runutils.py (RunMixin): factored this class out..
3099 * buildbot/test/test_run.py: .. from here
3100 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3101 added new buildbot.locks tests (which all hang right now)
3102 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3103 * buildbot/process/step.py: claim/release per-BuildStep locks
3105 * docs/Makefile: add 'buildbot.html' target
3107 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3108 interpreted as "HEAD", so that all VC steps can accept branch=None
3109 and have it mean the "default branch".
3111 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3113 2005-07-07 Brian Warner <warner@lothar.com>
3115 * docs/examples/twisted_master.cfg: update to match current usage
3117 * docs/buildbot.texinfo (System Architecture): comment out the
3118 image, it doesn't exist yet and just screws up the HTML manual.
3120 2005-07-05 Brian Warner <warner@lothar.com>
3122 * debian/.cvsignore: oops, missed one. Removing leftover file.
3124 2005-06-17 Brian Warner <warner@lothar.com>
3126 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3127 changed its output in 1.2.0, don't mistakenly think that the
3128 subversion we find isn't capable of supporting our tests.
3130 * debian/*: remove the debian/ directory and its contents, to make
3131 life easier for the proper Debian maintainer
3133 * Makefile (release): same
3135 2005-06-07 Brian Warner <warner@lothar.com>
3137 * everything: create a distinct SourceStamp class to replace the
3138 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3139 Changed the signature of Source.startVC to include the revision
3140 information (instead of passing it through self.args). Implement
3141 branches for SVN (now only Darcs/Git is missing support). Add more
3144 2005-06-06 Brian Warner <warner@lothar.com>
3146 * everything: rearrange build scheduling. Create a new Scheduler
3147 object (configured in c['schedulers'], which submit BuildSets to a
3148 set of Builders. Builders can now use multiple slaves. Builds can
3149 be run on alternate branches, either requested manually or driven
3150 by changes. This changed some of the Status classes. Interlocks
3151 are out of service until they've been properly split into Locks
3152 and Dependencies. treeStableTimer, isFileImportant, and
3153 periodicBuild have all been moved from the Builder to the
3155 (BuilderStatus.currentBigState): removed the 'waiting' and
3156 'interlocked' states, removed the 'ETA' argument.
3158 2005-05-24 Brian Warner <warner@lothar.com>
3160 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3161 erroneously abandons the connection (in clientConnectionFailed)
3162 for non-UserErrors, which means that if we lose the connection due
3163 to a network problem or a timeout, we'll never try to reconnect.
3164 Fix this by not upcalling to the buggy parent method. Note:
3165 twisted-2.0 fixes this, but the function only has 3 lines so it
3166 makes more sense to copy it than to try and detect the buggyness
3167 of the parent class. Fixes SF#1207588.
3169 * buildbot/changes/changes.py (Change.branch): doh! Add a
3170 class-level attribute to accomodate old Change instances that were
3171 pickled before 0.6.5 (where .branch was added for new Changes).
3172 This fixes the exception that occurs when you try to look at an
3173 old Change (through asHTML).
3175 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3178 2005-05-23 Brian Warner <warner@lothar.com>
3180 * buildbot/__init__.py (version): release 0.6.6
3182 2005-05-23 Brian Warner <warner@lothar.com>
3184 * NEWS: update for 0.6.6 release
3185 * debian/changelog: same
3187 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3188 before starting: this was done by twistd back when we spawned it,
3189 now that we're importing the pieces and running them in the
3190 current process, we have to do it ourselves. This allows
3191 master.cfg to import files from the same directory without
3192 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3193 Stichele for the catch.
3194 (Options.opt_version): Add a --version command (actually, just make
3195 the existing --version command emit Buildbot's version too)
3197 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3198 fix to make this behave like other LogFiles, this time to handle
3199 existing LogFiles on disk. (add the missing .upgrade method)
3200 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3202 2005-05-21 Brian Warner <warner@lothar.com>
3204 * buildbot/test/test_runner.py (Create.testMaster): match the
3205 rawstring change in runner.py:masterTAC
3207 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3208 TwistedWords is installed
3209 * buildbot/test/test_status.py: same, with TwistedMail
3211 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3212 some old, deprecated, and removed config keys). This should enable
3213 you to use the base buildbot functionality with Twisted-2.0.0 when
3214 you don't also have TwistedWeb and TwistedWords installed
3216 2005-05-20 Brian Warner <warner@lothar.com>
3218 * buildbot/scripts/runner.py (run): call sendchange(), not
3219 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3220 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3221 (stop): don't wait for process to die when sending SIGHUP
3222 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3223 directory name gets interpreted, which you don't want
3226 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3229 2005-05-18 Brian Warner <warner@lothar.com>
3231 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3233 2005-05-18 Brian Warner <warner@lothar.com>
3235 * README: update for 0.6.5
3236 * debian/changelog: same
3238 * buildbot/changes/changes.py: rename tag= to branch=, since
3239 that's how we're using it, and my design for the upcoming "build a
3240 specific branch" feature wants it. also, tag= was too CVS-centric
3241 * buildbot/changes/mail.py (parseSyncmail): same
3242 * buildbot/process/base.py (Build.isBranchImportant): same
3243 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3244 * docs/buildbot.texinfo (Attributes of Changes): same
3246 * NEWS: update tag=, update for upcoming release
3248 2005-05-17 Brian Warner <warner@lothar.com>
3250 * buildbot/scripts/runner.py (stop): actually poll once per
3251 second, instead of re-killing the poor daemon once per second.
3252 Sleep briefly (0.1s) before the first poll, since there's a good
3253 chance we can avoid waiting the full second if the daemon shuts
3254 down quickly. Also remove the sys.exit() at the end.
3255 (start): remove the unneighborly sys.exit()
3257 * Makefile: improve permission-setting to not kick Arch so badly
3259 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3260 default --keepalive=600, since it doesn't hurt very much, and it's
3261 a hassle to discover that you need it.
3262 * buildbot/test/test_runner.py (Create.testSlave): test it
3264 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3265 IRC bot about EXCEPTION
3267 * buildbot/status/client.py (PBListener): upcall more correctly
3269 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3270 an exception mark the overall build with EXCEPTION, not SUCCESS
3272 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3274 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3275 * Makefile: update some release-related stuff
3277 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3278 gets called when there isn't actually an active process, just end
3279 the Command instead of blowing up. I don't know how it gets into
3280 this state, but the twisted win32 buildslave will sometimes hang,
3281 and when it shakes its head and comes back, it thinks it's still
3282 running a Command. The next build causes this command to be
3283 interrupted, but the lack of self.process.pid breaks the interrupt
3286 * NEWS: document changes since the last release
3288 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3289 look for Makefile.buildbot instead of a bare Makefile . The
3290 'buildbot start' does not install this file, so you have to
3291 manually copy it if you want to customize startup behavior.
3292 (createMaster): change 'buildbot master' command to create
3293 Makefile.sample instead of Makefile, to create master.cfg.sample
3294 instead of master.cfg (requiring you to copy it before the
3295 buildmaster can be started). Both sample files are kept up to
3296 date, i.e. they are overwritten if they have been changed. The
3297 'buildbot.tac' file is *not* overwritten, but if the new contents
3298 don't match the old, a 'buildbot.tac.new' file is created and the
3299 user is warned. This seems to be a much more sane way to handle
3300 startup files. Also, don't sys.exit(0) when done, so we can run
3301 unit tests against it.
3302 (createSlave): same. Don't overwrite the sample info/ files.
3303 * buildbot/scripts/sample.mk: remove. the contents were pulled
3304 into runner.py, since they need to match the behavior of start()
3308 * docs/buildbot.texinfo (Launching the daemons): document it
3309 * buildbot/test/test_runner.py (Create): test it
3311 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3312 version that can handle string-in-string tests, because otherwise
3313 python-2.2 fails the tests. It'd be tremendous if Trial's test
3314 took two strings under 2.2 too.
3316 * everything: fixed all deprecation warnings when running against
3317 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3318 few that come from Twisted itself). This involved putting most of
3319 the Twisted-version specific code in the new buildbot.twcompat
3320 module, and creating some abstract base classes in
3321 buildbot.changes.base and buildbot.status.base (which might be
3322 useful anyway). __implements__ is a nuisance and requires an ugly
3323 'if' clause everywhere.
3325 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3326 delay before finishing the test: it seems that smtp.sendmail
3327 doesn't hang up on the server, so we must wait a moment so it can
3328 hang up on us. This removes the trial warning about an unclean
3331 2005-05-16 Brian Warner <warner@lothar.com>
3333 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3334 tuple of (delay, repeats).
3335 * buildbot/test/test_vc.py (Retry): test it
3336 * docs/buildbot.texinfo (Source Checkout): document it
3337 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3338 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3339 doVCFull() are handled by re-trying the checkout (after a delay)
3340 some number of times.
3341 (ShellCommand._startCommand): make header lines easier to read
3343 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3345 (WebTest.test_logfile): make sure master gets shut down, silences
3346 some "unclean reactor" test errors
3348 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3349 reactor once after shutdown, something in certain versions of
3350 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3351 fails, svn-trunk is ok.
3353 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3354 second win32 error message
3356 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3357 validating the ETA, so the tests don't fail on slow systems
3359 2005-05-15 Brian Warner <warner@lothar.com>
3361 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3362 the new LogFile class, so upgrading works properly
3363 (LogFileProducer.resumeProducing): survive resumeProducing after
3364 we've exhausted the chunkGenerator
3366 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3368 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3369 (Log.testUpgrade): same
3371 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3372 Builds and logs with a cron job.
3374 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3375 of the old non-offline LogFile, added code to upgrade these to
3376 new-style contents-live-on-disk instances at load time (in a way
3377 that doesn't invalidate the old Build pickles, so upgrading to
3378 0.6.5 is not a one-way operation). Got rid of everything related
3380 (LogFile.__init__): create LogFiles with the parent step status,
3381 the log's name, and a builder-relative filename where it can keep
3382 the contents on disk.
3383 (LogFile.hasContents): new method, clients are advised to call it
3384 before getText or getChunks and friends. If it returns False, the
3385 log's contents have been deleted and getText() will raise an
3387 (LogFile.getChunks): made it a generator
3388 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3389 Consumer (except one that takes chunks instead of strings). This
3390 enables streaming of very large logfiles without storing the whole
3392 (BuildStatus.generateLogfileName): create names like
3393 12-log-compile-output, with a _0 suffix if required to be unique
3394 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3395 or earlier) logfiles into new-style ones
3396 (BuilderStatus): remove everything related to 'stub' builds. There
3397 is now only one build cache, and we don't strip logs from old
3399 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3400 since we no longer fight to keep it in the cache
3402 * buildbot/status/html.py (TextLog.render_GET): use a
3403 ChunkConsumer to stream the log entries efficiently.
3404 (ChunkConsumer): wrapper which consumes chunks and writes
3407 * buildbot/test/test_twisted.py (Parse.testParse): use a
3408 LogFile-like object instead of a real one
3410 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3411 (Log.testMerge3): validate more merge behavior
3412 (Log.testChunks): validate LogFile.getChunks
3413 (Log.testUpgrade): validate old-style LogFile upgrading
3414 (Log.testSubscribe): validate LogFile.subscribe
3415 (Log.testConsumer): validate LogFile.subscribeConsumer
3417 * buildbot/interfaces.py (IStatusLogStub): remove
3418 (IStatusLog.subscribeConsumer): new method
3419 (IStatusLog.hasContents): new method
3420 (IStatusLogConsumer): describes things passed to subscribeConsumer
3422 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3423 the log contents if it does not have any contents.
3424 (StatusResourceBuildStep.body): same
3425 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3427 2005-05-14 Brian Warner <warner@lothar.com>
3429 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3430 timeouts to try and make the windows metabuildslave not hang
3432 2005-05-13 Mike Taylor <bear@code-bear.com>
3434 * buildbot/slave/commands.py (rmdirRecursive): added a check
3435 to ensure the path passed into rmdirRecursive actually exists.
3436 On win32 a non-existant path would generate an exception.
3438 2005-05-13 Brian Warner <warner@lothar.com>
3440 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3441 shutil.rmtree which behaves correctly on windows in the face of
3442 files that you have to chmod before deleting. Thanks to Bear at
3443 the OSAF for the routine.
3444 (SourceBase.doClobber): use rmdirRecursive
3446 2005-05-12 Brian Warner <warner@lothar.com>
3448 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3449 method generate chunks instead of returning a big list. This
3450 allows the same method to be used for both old LogFile and new
3452 (OfflineLogFile.getText): use the generator
3453 (OfflineLogFile.subscribe): same
3454 * buildbot/status/html.py (TextLog.resumeProducing): same
3455 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3457 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3458 point out that OfflineLogFile does not currently work with
3459 html.Waterfall . Fixing this is high-priority.
3461 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3462 apparently windows defaults to using stdout
3464 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3465 better message on failure so I can figure out the win32 problem
3467 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3468 log messages to include more useful copies of the command being
3469 run, the argv array, and the child command's environment.
3470 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3472 2005-05-11 Brian Warner <warner@lothar.com>
3474 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3476 * Makefile: update the deb-snapshot version
3478 * docs/buildbot.texinfo: move all .xhtml docs into a new
3479 .texinfo-format document, adding a lot of material in the process.
3480 This is starting to look like a real user's manual. Removed all
3481 the Lore-related files: *.xhtml, *.css, template.tpl .
3482 * docs/Makefile: simple makefile to run 'makeinfo'
3483 * buildbot/scripts/sample.cfg: rearrange slightly
3484 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3486 2005-05-10 Brian Warner <warner@lothar.com>
3488 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3489 different name for the internal twistw module, handle it.
3491 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3492 * setup.py: .. and stop trying to install it
3494 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3495 'git'), the new linux kernel VC system (http://kernel.org/git/).
3496 Thanks to Brandon Philips for the patch.
3497 * buildbot/slave/commands.py (Git): same
3499 2005-05-06 Brian Warner <warner@lothar.com>
3501 * buildbot/status/builder.py (OfflineLogFile): replace the default
3502 LogFile with a form that appends its new contents to a disk file
3503 as they arrive. The complete log data is never kept in RAM. This
3504 is the first step towards handling very large (100MB+) logfiles
3505 without choking quite so badly. (The other half is
3506 producer/consumer on the HTML pages).
3507 (BuildStepStatus.addLog): use OfflineLogFile by default
3508 (BuildStatus.getLogfileName): helper code to give the
3509 OfflineLogFile a filename to work with
3511 * buildbot/test/test_status.py (Results.testAddResults): update
3512 tests to handle new asserts
3513 * buildbot/test/test_vc.py (Patch.doPatch): same
3514 * buildbot/test/test_steps.py (BuildStep.setUp): same
3516 2005-05-05 Brian Warner <warner@lothar.com>
3518 * buildbot/scripts/runner.py (start): if there is no Makefile,
3519 launch the app by importing twistd's internals and calling run(),
3520 rather than spawning a new twistd process. This stands a much
3521 better chance of working under windows.
3522 (stop): kill the process with os.kill instead of spawning
3523 /bin/kill, again to reduce the number of external programs which
3524 windows might not have in the PATH. Also wait up to 5 seconds for
3525 the process to go away, allowing things like 'buildbot stop;
3526 buildbot start' to be reliable in the face of slow shutdowns.
3528 * buildbot/master.py (Dispatcher.__getstate__): remove old
3529 .tap-related methods
3530 (BuildMaster.__getstate__): same
3532 * buildbot/slave/bot.py (makeService): same
3533 (Options.longdesc): same
3534 * buildbot/scripts/runner.py: copy over some old mktap option text
3536 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3537 'buildbot master' now creates a buildbot.tac file, so there is no
3538 longer a create-instance/save/reload sequence. mktap is dead, long
3540 * buildbot/scripts/sample.mk: use twistd -y, not -f
3541 * buildbot/test/test_config.py: remove mktap-based test
3542 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3543 * README: don't reference mktap
3545 * docs/source.xhtml: document some of the attributes that Changes
3548 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3550 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3551 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3552 * buildbot/changes/changes.py (Change)
3553 * buildbot/changes/mail.py (parseSyncmail)
3554 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3556 * buildbot/process/base.py (Build.isTagImportant)
3560 2005-05-04 Brian Warner <warner@lothar.com>
3562 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3563 connection after sending the change, so that unit tests don't
3564 complain about sockets being left around
3566 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3567 exception in phase=0 rendering
3568 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3570 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3572 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3573 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3574 and configuring builders with tuples.
3575 * buildbot/test/test_config.py: stop testing compatibility with
3576 deprecated config keys
3577 * buildbot/test/test_run.py: same
3579 2005-05-03 Brian Warner <warner@lothar.com>
3581 * contrib/arch_buildbot.py: survive if there are no logfiles
3582 (username): just use a string, os.getlogin isn't reliable
3584 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3585 so 'buildbot sendchange' actually works. The earlier test only
3586 covered the internal (non-reactor-running) form.
3588 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3589 script to notify the buildmaster about changes
3591 * buildbot/scripts/runner.py (sendchange): new command to send a
3592 change to a buildbot.changes.pb.PBChangeSource receiver.
3593 * buildbot/test/test_changes.py (Sender): test it
3595 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3596 after any reading of the config file, not just when we do it in
3597 startService. This makes some tests a bit cleaner.
3599 * buildbot/changes/pb.py: add some log messages
3601 * buildbot/process/base.py (Build.startBuild): fix a bug that
3602 caused an exception when the build terminated in the very first
3604 (Build.stepDone): let steps return a status of EXCEPTION. This
3605 terminates the build right away, and sets the build's overall
3606 status to EXCEPTION too.
3607 * buildbot/process/step.py (BuildStep.failed): return a status of
3608 EXCEPTION when that is what has happened.
3610 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3611 implement this, allowing Arch-based projects to get precise
3612 checkouts instead of always using the latest code
3613 (Bazaar): create variant of Arch to let folks use baz instead of
3614 tla. Requires a new buildslave too.
3615 * buildbot/slave/commands.py (Arch): add 'revision' argument
3616 (Bazaar): create variant of Arch that uses baz instead of tla.
3617 Remove the code that extracts the archive name from the
3618 register-archive output, since baz doesn't provide it, and require
3619 the user provide both the archive name and its location.
3620 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3622 2005-05-02 Brian Warner <warner@lothar.com>
3624 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3625 thanks to Nick Trout.
3627 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3628 deals better with source Makefile coming from a read-only CVS
3629 checkout. Thanks to Nick Trout for the catch.
3631 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3634 2005-04-28 Brian Warner <warner@lothar.com>
3636 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3638 * debian/changelog: update for 0.6.4
3640 2005-04-28 Brian Warner <warner@lothar.com>
3642 * README.w32: add a checklist of steps for getting buildbot
3644 * MANIFEST.in: include it in the tarball
3648 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3649 broken .tap files from 0.6.3 by getting rid of .services,
3650 .namedServices, and .change_svc at load time.
3652 2005-04-27 Brian Warner <warner@lothar.com>
3654 * NEWS: update in preparation for new release
3656 * buildbot/test/test_config.py (Save.testSave): don't pull in
3657 twisted.scripts.twistd, we don't need it and it isn't for windows
3660 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3661 accomodate win32 which can't do atomic-rename
3663 2005-04-27 Brian Warner <warner@lothar.com>
3665 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3666 timeouts to help the slow metabuildbot not flunk them so much
3667 (Disconnect.testBuild3): same
3668 (Disconnect.testBuild4): same
3669 (Disconnect.testInterrupt): same
3671 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3672 setup, it was completely broken for new buildmasters (those which
3673 did not have a 'change.pck' already saved. Thanks to Paul Warren
3674 for catching this (embarrassing!) bug.
3675 (Dispatcher.__getstate__): don't save our registered avatar
3676 factories, since they'll be re-populated when the config file is
3678 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3679 tests (since the real mktap-generated BuildMaster doesn't save
3681 (BuildMaster.__getstate__): don't save any service children,
3682 they'll all be re-populated when the config file is re-read.
3683 * buildbot/test/test_config.py (Save.testSave): test for this
3685 2005-04-26 Brian Warner <warner@lothar.com>
3687 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3688 rendered with Blender.. looks a bit nicer.
3689 * buildbot/docs/images/icon.blend: add the Blender file for it
3691 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3692 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3693 running under windows. This appears to be the best way to allow
3694 BuildSteps to do something normal like 'trial -v buildbot.test' or
3695 'make foo' and still expect it to work. The idea is to make the
3696 BuildSteps look as much like what a developer would type when
3697 compiling or testing the tree by hand. This approach probably has
3698 problems when there are spaces in the arguments, so if you've got
3699 windows buildslaves, you'll need to pay close attention to your
3702 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3703 timezone to the timestamp column.
3704 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3706 * buildbot/scripts/runner.py (loadOptions): do something sane for
3707 windows, I think. We use %APPDATA%/buildbot instead of
3708 ~/.buildbot, but we still search everywhere from the current
3709 directory up to the root for a .buildbot/ subdir. The "is it under
3710 $HOME" security test was replaced with "is it owned by the current
3711 user", which is only performed under posix.
3712 * buildbot/test/test_runner.py (Options.testFindOptions): update
3713 tests to match. The "is it owned by the current user" check is
3714 untested. The test has been re-enabled for windows.
3716 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3717 any "\n" in the expected output with the platform-specific line
3718 separator. Make this separator "\r\n" on PTYs under unix, they
3719 seem to do that and I don't know why
3721 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3722 windows for now, I don't know what ~/.buildbot/ should mean there.
3724 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3725 win32 compatibility, don't use "/tmp"
3726 (Basedir.testChangeBuilddir): remove more unixisms
3728 2005-04-26 Brian Warner <warner@lothar.com>
3730 * buildbot/test/test_control.py (Force.rmtree): python2.2
3731 compatibility, apparently its shutil.rmtree ignore_errors=
3732 argument is ignored.
3733 * buildbot/test/test_run.py (Run.rmtree): same
3734 (RunMixin.setUp): same
3736 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3739 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3740 'substring in string' operator, must use string.find(substr)!=-1
3741 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3742 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3744 * buildbot/scripts/runner.py (loadOptions): add code to search for
3745 ~/.buildbot/, a directory with things like 'options', containing
3746 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3747 the current directory, your $HOME directory, or anywhere
3748 inbetween, as long as you're somewhere inside your home directory.
3749 (debugclient): look in ~/.buildbot/options for master and passwd
3750 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3751 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3753 * buildbot/status/client.py (makeRemote): new approach to making
3754 IRemote(None) be None, which works under Twisted-2.0
3755 * buildbot/test/test_status.py (Client.testAdaptation): test it
3757 * buildbot/status/builder.py (Status.builderAdded): when loading a
3758 pickled BuilderStatus in from disk, set its name after loading.
3759 The config file might have changed its name (but not its
3760 directory) while it wasn't looking.
3762 * buildbot/process/builder.py (Builder.attached): always return a
3763 Deferred, even if the builder was already attached
3764 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3766 2005-04-25 Brian Warner <warner@lothar.com>
3768 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3769 category-related exception when announcing a build has finished
3771 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3772 reference no-longer-existent changemaster.sources
3773 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3775 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3778 2005-04-25 Brian Warner <warner@lothar.com>
3780 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3782 * debian/changelog: update for 0.6.3
3784 2005-04-25 Brian Warner <warner@lothar.com>
3786 * MANIFEST.in: make sure debug.glade is in the tarball
3788 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3790 * NEWS: update for the imminent 0.6.3 release
3792 * buildbot/status/html.py (HtmlResource.content): make the
3793 stylesheet <link> always point at "buildbot.css".
3794 (StatusResource.getChild): map "buildbot.css" to a static.File
3795 containing whatever css= argument was provided to Waterfall()
3796 (Waterfall): provide the "classic" css as the default.
3797 * docs/waterfall.classic.css: move default CSS from here ..
3798 * buildbot/status/classic.css: .. to here
3800 * MANIFEST.in: make sure classic.css is included in the tarball
3801 * setup.py: and that it is installed too, under buildbot/status/
3803 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3804 the module level, because buildbot.tap files from 0.6.2 don't have
3805 it in their attribute dictionary.
3807 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3808 really exists at startup, might save some confusion somewhere.
3810 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3812 * docs/waterfall.classic.css:
3813 add a stylesheet that's almost the same as the "classic"
3816 * buildbot/status/builder.py:
3817 add EXCEPTION as a result - this is a problem for the bot
3818 maintainer, not a build problem for the changers
3819 * buildbot/process/step.py:
3820 use EXCEPTION instead of FAILURE for exceptions
3821 * buildbot/status/html.py:
3822 add build_get_class to get a class out of a build/buildstep
3823 finish naming the classes
3824 split out sourceNames to changeNames and builderNames so we
3825 can style them separately
3826 * docs/config.xhtml:
3827 finish documenting classes as they are right now
3829 * buildbot/status/html.py:
3830 name the classes as we agreed on IRC
3831 * docs/config.xhtml:
3834 * buildbot/status/html.py:
3835 same for cssclass->class_
3837 * buildbot/status/html.py:
3838 as decided on IRC, use class_ for the "class" attribute to not
3839 conflict with the class keyword, and clean up the messy **{} stuff.
3841 * buildbot/status/mail.py:
3842 put back "builders" argument, and fix docstring, because the
3843 code *ignores* builders listed in this argument
3845 * buildbot/process/builder.py:
3846 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3848 * docs/config.xhtml:
3849 describe the category argument for builders
3851 * buildbot/status/builder.py:
3852 Fix a silly bug due to merging
3854 * buildbot/process/builder.py:
3855 remove category from the process Builder ...
3856 * buildbot/status/builder.py:
3857 ... and add it to BuilderStatus instead.
3858 Set category on unpickled builder statuses, they might not have it.
3859 * buildbot/master.py:
3860 include category when doing builderAdded
3861 * buildbot/status/mail.py:
3862 return None instead of self for builders we are not interested in.
3863 * buildbot/test/test_run.py:
3864 fix a bug due to only doing deferredResult on "dummy" waiting
3865 * buildbot/test/test_status.py:
3866 add checks for the Mail IStatusReceiver returning None or self
3868 * buildbot/status/html.py:
3869 fix testsuite by prefixing page title with BuildBot
3871 * buildbot/status/builder.py:
3872 have .category in builder status ...
3873 * buildbot/process/builder.py:
3874 ... and set it from Builder
3875 * buildbot/status/html.py:
3876 make .css a class variable
3877 * buildbot/test/test_status.py:
3878 write more tests to cover our categories stuff ...
3879 * buildbot/status/mail.py:
3880 ... and fix the bug that this uncovered
3882 * buildbot/changes/mail.py:
3883 * buildbot/changes/pb.py:
3884 * buildbot/master.py:
3885 * buildbot/process/base.py:
3886 * buildbot/process/factory.py:
3887 * buildbot/process/interlock.py:
3888 * buildbot/process/step.py:
3889 * buildbot/process/step_twisted.py:
3890 * buildbot/slave/commands.py:
3891 * buildbot/status/builder.py:
3892 * buildbot/status/client.py:
3893 * buildbot/status/html.py:
3894 * buildbot/status/mail.py:
3895 * buildbot/status/progress.py:
3896 * buildbot/test/test_changes.py:
3897 * buildbot/test/test_config.py:
3898 * buildbot/test/test_control.py:
3899 * buildbot/test/test_interlock.py:
3900 * buildbot/test/test_maildir.py:
3901 * buildbot/test/test_mailparse.py:
3902 * buildbot/test/test_run.py:
3903 * buildbot/test/test_slavecommand.py:
3904 * buildbot/test/test_status.py:
3905 * buildbot/test/test_steps.py:
3906 * buildbot/test/test_twisted.py:
3907 * buildbot/test/test_util.py:
3908 * buildbot/test/test_vc.py:
3909 * buildbot/test/test_web.py:
3911 add test-case-name at the top of a whole set of files
3913 * buildbot/status/builder.py:
3914 keep order of addition when getting builder names
3915 * buildbot/status/words.py:
3916 * buildbot/test/test_run.py:
3917 add test for getBuilderNames
3919 * buildbot/process/base.py:
3920 * buildbot/process/step.py:
3921 * buildbot/status/builder.py:
3922 * buildbot/status/html.py:
3923 make buildbot css-able
3924 replace the color code for purple with purple, don't understand
3925 why it wasn't purple to start with
3927 * buildbot/status/words.py:
3928 ok, so it doesn't look like BuilderStatus.remote is still valid.
3929 Use what waterfall uses instead.
3931 * buildbot/interfaces.py:
3932 * buildbot/status/builder.py:
3933 * buildbot/status/html.py:
3934 * buildbot/status/mail.py:
3935 * buildbot/status/words.py:
3936 * buildbot/test/test_run.py:
3937 use categories everywhere and make it be a list. More sensible
3938 for the future. Also make words actually respect this in
3941 * buildbot/interfaces.py:
3942 add category argument to getBuilderNames
3943 * buildbot/process/builder.py:
3944 * buildbot/status/builder.py:
3945 * buildbot/status/html.py:
3946 * buildbot/status/mail.py:
3947 * buildbot/status/words.py:
3948 * buildbot/test/test_run.py:
3949 move from specifying builders by name to specifying the category
3951 * buildbot/status/html.py:
3952 * buildbot/status/words.py:
3953 add "builders=" to __init__ of status clients so they can
3954 limit themselves to the given list of builders to report on
3956 * buildbot/status/html.py: set the title to the product name
3958 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3960 * buildbot/interfaces.py:
3961 * buildbot/status/builder.py:
3962 more documentation. Hm, not sure if ChangeLog entries make sense
3965 2005-04-23 Brian Warner <warner@lothar.com>
3967 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3969 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3971 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3972 the sub-commands that log buildmaster status to stdout and to a
3973 GUI window, respectively.
3975 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3976 functionality is working again, but all the step-status and ETA
3977 stuff is missing. Commented out a lot of code pending more
3980 * buildbot/status/client.py: make sure that IRemote(None) is None
3982 * buildbot/changes/changes.py: import defer, oops
3983 (ChangeMaster): remove the .sources list, rely upon the fact that
3984 MultiServices can be treated as sequences of their children. This
3985 cleans up the add/remove ChangeSource routines a lot, as we keep
3986 exactly one list of the current sources instead of three.
3988 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3989 up an empty ChangeMaster at init time.
3990 (BuildMaster.loadChanges): if there are changes to be had from
3991 disk, replace self.change_svc with the new ones. If not, keep
3992 using the empty ChangeMaster set up in __init__.
3993 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3994 instead of a separate list, makes the code a bit cleaner.
3995 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3996 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3997 Extend the test to make sure we can get rid of the sources when
4000 2005-04-22 Brian Warner <warner@lothar.com>
4002 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4003 and info/host files when making the slave directory
4005 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4006 whendone= argument, just return the Deferred and let the caller do
4007 what they want with it.
4008 (Disconnect.testBuild1): wait for shutdownSlave
4009 (Basedir.testChangeBuilddir): new test to make sure changes to the
4010 builddir actually get propagated to the slave
4012 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4013 explicit method, rather than passing the builddir in __init__ .
4014 Make sure to update self.basedir too, this was broken before.
4015 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4016 builders and for ones that have just had their builddir changed.
4017 (BotFactory): add a class-level .perspective attribute, so
4018 BuildSlave.waitUntilDisconnected won't get upset when the
4019 connection hasn't yet been established
4020 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4021 tests can reach through it to inspect the SlaveBuilders
4023 * buildbot/process/base.py (Build.buildException): explain the
4024 log.err with a log.msg
4025 * buildbot/process/builder.py (Builder.startBuild): same
4026 (Builder._startBuildFailed): improve error message
4028 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4029 occurred because we lost the brand-new connection, retry instead
4030 of giving up. If not, it's probably an authorization failure, and
4031 it makes sense to stop trying. Make sure we log.msg the reason
4032 that we're log.err'ing the failure, otherwise test failures are
4033 really hard to figure out.
4035 * buildbot/master.py: change loadConfig() to return a Deferred
4036 that doesn't fire until the change has been fully implemented.
4037 This means any connected slaves have been updated with the new
4038 builddir. This change makes it easier to test the code which
4039 actually implements this builddir-updating.
4040 (BotPerspective.addBuilder): return Deferred
4041 (BotPerspective.removeBuilder): same
4042 (BotPerspective.attached): same
4043 (BotPerspective._attached): same. finish with remote_print before
4044 starting the getSlaveInfo, instead of doing them in parallel
4045 (BotPerspective.list_done): same
4046 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4047 actually calling slave.disconnect()
4048 (BotMaster.addBuilder): same
4049 (BotMaster.removeBuilder): same
4050 (BuildMaster.loadConfig): same
4051 (BuildMaster.loadConfig_Slaves): same
4052 (BuildMaster.loadConfig_Sources): same
4053 (BuildMaster.loadConfig_Builders): same
4054 (BuildMaster.loadConfig_status): same
4056 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4057 a Deferred that fires when the source is finally removed
4059 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4060 the previous tree on win32, where we have to do it synchronously,
4061 make sure we return a Deferred anyway.
4062 (SourceBase.doCopy): same
4064 * buildbot/scripts/runner.py (statusgui): use the text client for
4065 now, while I rewrite the Gtk one
4066 * buildbot/clients/base.py: strip out old code, leaving just the
4067 basic print-message-on-event functionality. I also remove the
4068 ReconnectingPBClientFactory, but it does at least quit when it
4069 loses the connection instead of going silent
4071 2005-04-21 Brian Warner <warner@lothar.com>
4073 * Makefile: minor tweaks
4075 * NEWS: point out deprecation warnings, new features for
4078 * buildbot/master.py (BuildMaster.loadConfig): emit
4079 DeprecationWarnings for Builders defined with tuples. Rearrange
4080 code to facility removal of deprecated configuration keys in the
4083 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4084 'buildbot' command to put a little Makefile in the target that
4085 helps you re-create the buildbot.tap file, start or stop the
4086 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4087 all the files 0600, since they contain passwords.
4088 (start): if there is a Makefile, and /usr/bin/make exists, use
4089 'make start' in preference to a raw twistd command. This lets
4090 slave admins put things like PYTHONPATH variables in their
4091 Makefiles and have them still work when the slave is started with
4092 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4093 be nice to first try the 'make' command and only fall back to
4094 twistd if it fails. TODO: the Makefile's "start" command does not
4095 add the --reactor=win32 argument when running under windows.
4096 (Options.debugclient, Options.statusgui): add sub-commands to launch
4097 the debug client (formerly in contrib/debugclient.py) and the
4098 Gtk status application (currently broken)
4099 * buildbot/clients/debug.py: move from contrib/debugclient.py
4100 * buildbot/clients/debug.glade: same
4102 * buildbot/test/test_trial.py: remove it. This requires some
4103 functionality out of Twisted that isn't there yet, and until then
4104 having it around just confuses things.
4106 * buildbot/test/test_slavecommand.py (Shell): test both with and
4107 without PTYs, and make sure that command output is properly
4108 interleaved in the with-PTY case. I think the without-PTY test
4109 should pass on windows, where we never use PTYs anyway.
4111 2005-04-20 Brian Warner <warner@lothar.com>
4113 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4115 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4117 * NEWS: start creating entries for the next release
4119 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4121 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4122 (WebTest.test_webPathname): same
4123 (WebTest.test_webPathname_port): same
4124 (WebTest.test_waterfall): use the default favicon rather than
4125 rooting around the filesystem for it. Open the expected-icon file
4126 in binary mode, to make win32 tests happier (thanks to Nick Trout
4128 * buildbot/status/html.py (buildbot_icon): win32 portability
4130 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4131 win32-compatibility fixes from Nick Trout, the "file not found" message
4132 is different under windows
4133 (FakeSlaveBuilder.__init__): clean up setup a bit
4134 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4136 2005-04-19 Brian Warner <warner@lothar.com>
4138 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4139 skip-if-repositories-are-unavailable test to not kill the trial
4140 that comes with Twisted-1.3.0
4142 * setup.py: install buildbot.png icon file when installing code
4144 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4145 environment used by the command, at least on the child side.
4147 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4148 this method needs to be added and implemented because it gets
4149 called under heavy load. I don't quite understand the
4150 producer/consumer API enough to write it.
4151 (StatusResource.getChild): add a resource for /favicon.ico
4152 (Waterfall.__init__): add favicon= argument
4153 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4154 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4155 (WebTest.test_webPathname): same
4156 (WebTest.test_webPathname_port): same
4157 * docs/config.xhtml: mention favicon=
4158 * buildbot/buildbot.png: add a default icon, dorky as it is
4160 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4162 * buildbot/master.py:
4163 * buildbot/process/base.py:
4164 * buildbot/process/builder.py:
4165 * buildbot/process/interlock.py:
4166 * buildbot/status/builder.py:
4167 * buildbot/status/html.py:
4168 * buildbot/status/mail.py:
4169 * buildbot/status/words.py:
4170 new documentation while digging through the code
4172 2005-04-17 Brian Warner <warner@lothar.com>
4174 * general: try to fix file modes on all .py files: a+r, a-x,
4175 but let buildbot/clients/*.py be +x since they're tools
4177 * docs/epyrun (addMod): when an import fails, say why
4179 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4181 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4183 * buildbot/process/base.py:
4184 * buildbot/process/builder.py:
4185 * buildbot/status/builder.py:
4186 new documentation while digging through the code
4188 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4190 * buildbot/changes/changes.py:
4191 * buildbot/changes/p4poller.py:
4192 * buildbot/interfaces.py:
4193 * buildbot/process/base.py:
4194 * buildbot/process/builder.py:
4195 * buildbot/process/step.py:
4196 * buildbot/process/step_twisted.py:
4197 * buildbot/slave/bot.py:
4198 * buildbot/slave/commands.py:
4199 * buildbot/status/builder.py:
4200 fix all docstrings to make epydoc happy. In the process of fixing
4201 some, I also moved pieces of docs, and removed some deprecated
4204 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4206 * buildbot/process/builder.py:
4207 * buildbot/process/interlock.py:
4208 * buildbot/process/process_twisted.py:
4209 * buildbot/process/step.py:
4210 BuildProcess -> Build, as it looks like that's what happened
4211 * buildbot/process/base.py:
4212 * buildbot/process/factory.py:
4215 2005-04-17 Brian Warner <warner@lothar.com>
4217 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4218 update compile command to accomodate the Twisted split.. now
4219 instead of './setup.py build_ext -i', you do './setup.py all
4220 build_ext -i', to run build_ext over all sub-projects.
4221 (FullTwistedBuildFactory): same
4222 (TwistedReactorsBuildFactory): same
4224 * buildbot/status/html.py (TextLog.finished): null out self.req
4225 when we're done, otherwise the reference cycle of TextLog to .req
4226 to .notifications to a Deferred to TextLog.stop keeps them from
4227 being collected, and consumes a huge (610MB on pyramid at last
4228 check) amount of memory.
4230 2005-04-11 Brian Warner <warner@lothar.com>
4232 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4233 normalize the VC-repository location.. makes SVN happier with
4234 certain test environments.
4236 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4237 RemoteShellCommand gets its own .env dictionary, so that code in
4238 start() doesn't mutate the original. I think this should fix the
4239 step_twisted.Trial problem where multiple identical components
4240 kept getting added to PYTHONPATH= over and over again.
4242 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4243 adding epydoc-format docstrings to many classes. Thanks to Thomas
4244 Vander Stichele for the patches.
4245 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4246 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4247 * buildbot/slave/bot.py, commands.py, registry.py: same
4249 2005-04-05 Brian Warner <warner@lothar.com>
4251 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4252 preserve timestamps, helps incremental builds of large trees.
4253 Patch from Rene Rivera.
4255 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4256 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4259 2005-04-03 Brian Warner <warner@lothar.com>
4261 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4262 with one dict, apparently exec has some scoping bugs when used
4263 with both global/local dicts. Thanks to Nathaniel Smith for the
4266 2005-04-02 Brian Warner <warner@lothar.com>
4268 * buildbot/process/step_twisted.py (countFailedTests): the new
4269 trial in Twisted-2.0 emits a slightly different status line than
4270 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4271 mistakenly think the test count is unparseable.
4272 (Trial.start): note that for some reason each build causes another
4273 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4274 be fixed but I'm not sure quite where the problem is.
4276 2005-04-01 Brian Warner <warner@lothar.com>
4278 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4279 deferredResult to avoid hangs/warnings under twisted-2.0
4280 (RunMixin.tearDown): same
4281 (RunMixin.shutdownSlave): same
4282 (Disconnect.testIdle1): same
4283 (Disconnect.testBuild2): same: wait one second after the build
4284 finishes for test to really be done.. this should be cleaned up to
4285 avoid wasting that second. Builder.detach uses a callLater(0),
4286 either that should be done in-line (something else needed that
4287 behavior), or it should return a Deferred that fires when the
4288 builder is really offline.
4289 (Disconnect.testBuild3): same
4290 (Disconnect.testDisappear): same
4292 * buildbot/test/test_web.py: rearrange server-setup and teardown
4293 code to remove unclean-reactor warnings from twisted-2.0
4295 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4296 so the tests don't hang under twisted-2.0
4298 2005-03-31 Brian Warner <warner@lothar.com>
4300 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4301 caused a warning each time the master changed our set of builders
4303 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4304 w32, don't unlink the file unless it already exists. Thanks to
4305 Baptiste Lepilleur for the catch.
4306 (BuilderStatus.saveYourself): same
4308 2005-02-01 Brian Warner <warner@lothar.com>
4310 * buildbot/status/html.py (TextLog.getChild): use a /text child
4311 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4312 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4313 logfile as text/plain (no markup, no headers). This replaces the
4314 previous scheme (which used an ?text=1 argument), and gets us back
4315 to a relative link (which works better when the buildbot lives
4316 behind another web server, such as Apache configured as a reverse
4317 proxy). Thanks to Gerald Combs for spotting the problem.
4319 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4322 2004-12-13 Brian Warner <warner@lothar.com>
4324 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4326 * debian/changelog: update for 0.6.2
4327 * NEWS: finalize for 0.6.2
4329 2004-12-11 Brian Warner <warner@lothar.com>
4331 * NEWS: bring it up to date
4333 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4334 detection code. Require some sign of life from the buildmaster
4335 every BotFactory.keepaliveInterval seconds. Provoke this
4336 indication at BotFactory.keepaliveTimeout seconds before the
4337 deadline by sending a keepalive request. We don't actually care if
4338 that request is answered in a timely fashion, what we care about
4339 is that .activity() is called before the deadline. .activity() is
4340 triggered by any PB message from the master (including an ack to
4341 one of the slave's status-update messages). With this new scheme,
4342 large status messages over slow pipes are OK, as long as any given
4343 message can be sent (and thus acked) within .keepaliveTimeout
4344 seconds (which defaults to 30).
4345 (SlaveBuilder.remote_startCommand): record activity
4346 (SlaveBuilder.ackUpdate): same
4347 (SlaveBuilder.ackComplete): same
4348 (BotFactory.gotPerspective): same
4349 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4351 2004-12-09 Brian Warner <warner@lothar.com>
4353 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4356 * buildbot/process/step_twisted.py (Trial._commandComplete):
4357 update self.cmd when we start the 'cat test.log' transfer. Without
4358 this, we cannot interrupt the correct RemoteCommand when we lose
4361 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4362 trying to tell the slave to stop the command if we're already
4363 inactive, or if we no longer have a .remote
4365 * buildbot/process/builder.py (Builder._detached): don't let an
4366 exception in currentBuild.stopBuild() prevent the builder from
4367 being marked offline
4369 2004-12-07 Brian Warner <warner@lothar.com>
4371 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4372 KeyError that happens when you ask for a non-existent Builder, and
4373 translate it into a UsageError.
4375 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4376 losing the slave in the middle of a remote step is handled too
4378 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4379 be a Failure, so be sure to stringify it before using it as the
4380 contents of the 'interrupt' logfile
4381 (RemoteCommand.interrupt): use stringified 'why' in
4382 remote_interruptCommand too, just in case
4384 2004-12-06 Brian Warner <warner@lothar.com>
4386 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4387 instead of 'tla update', which is more efficient in case we've
4388 missed a couple of patches since the last update.
4390 * debian/changelog: update for previous (0.6.1) release. Obviously
4391 this needs to be handled better.
4393 2004-12-05 Brian Warner <warner@lothar.com>
4395 * NEWS: update for stuff since last release
4397 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4398 match the maybeDeferred change in Dispatcher.requestAvatar
4399 * buildbot/changes/pb.py (ChangePerspective.attached): same
4400 * buildbot/status/client.py (StatusClientPerspective.attached): same
4401 * buildbot/process/builder.py (Builder._attached3): same
4402 * buildbot/pbutil.py (NewCredPerspective.attached): same
4404 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4405 the date to the top-most box, if it is not the same as today's
4408 * docs/slave.xhtml: provide a buildslave setup checklist
4410 * docs/source.xhtml (Arch): correct terminology
4412 2004-12-04 Brian Warner <warner@lothar.com>
4414 * buildbot/test/test_slavecommand.py: use sys.executable instead
4415 of hard-coding 'python' for child commands, might help portability
4417 * docs/examples/twisted_master.cfg: update to current usage
4419 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4420 'stop build' command to the IRC bot
4422 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4423 message that broke PBChangeSource
4425 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4426 (SlaveBuilder): make some attributes class-level, remove the old
4427 "update queue" which existed to support resuming a build after the
4428 master connection was lost. Try to reimplement that feature later.
4429 (SlaveBuilder.stopCommand): clear self.command when the
4430 SlaveCommand finishes, so that we don't try to kill a leftover one
4432 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4435 * buildbot/slave/commands.py (SourceBase): set self.command for
4436 all VC commands, so they can be interrupted.
4438 2004-12-03 Brian Warner <warner@lothar.com>
4440 * buildbot/master.py: clean up slave-handling code, to handle
4441 slave-disconnect and multiple-connect better
4442 (BotPerspective): make these long-lasting, exactly one per bot
4443 listed in the config file.
4444 (BotPerspective.attached): if a slave connects while an existing
4445 one appears to still be connected, disconnect the old one first.
4446 (BotPerspective.disconnect): new method to forcibly disconnect a
4447 buildslave. Use some hacks to empty the transmit buffer quickly to
4448 avoid the long (20-min?) TCP timeout that could occur if the old
4449 slave has dropped off the net.
4450 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4451 own their own SlaveStatus objects. Remove .attached/.detached, add
4452 .addSlave/.removeSlave, treat slaves like Builders (config file
4453 parsing sends deltas to the BotMaster). Inform the slave
4454 instances, i.e. the BotPerspective, about addBuilder and
4456 (BotMaster.getPerspective): turns into a single dict lookup
4457 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4458 which gives BotPerspective.attached a chance to disconnect the old
4460 (BuildMaster.loadConfig): add code (disabled) to validate that all
4461 builders use known slaves (listed in c['bots']). The check won't
4462 work with tuple-specified builders, which are deprecated but not
4463 yet invalid, so the check is disabled for now.
4464 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4465 routine, do the add/changed/removed dance with them like we do
4467 (BuildMaster.loadConfig_Sources): move source-config into a
4468 separate routine too
4470 * buildbot/status/builder.py (Status.getSlave): get the
4471 SlaveStatus object from the BotPerspective, not the BotMaster.
4473 * buildbot/test/test_run.py: bunch of new tests for losing the
4474 buildslave at various points in the build, handling a slave that
4475 connects multiple times, and making sure we can interrupt a
4478 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4479 something other than 'Bot' for the Bot object, to make certain
4480 test cases easier to write.
4481 (BuildSlave.waitUntilDisconnected): utility method for testing
4483 2004-11-30 Brian Warner <warner@lothar.com>
4485 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4487 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4488 argument, return a Deferred that always fires with True or False.
4489 I don't use an errback to indicate 'ping failed' so that callers
4490 are free to ignore the deferred without causing spurious errors in
4492 * buildbot/process/builder.py (BuilderControl.ping): implement it
4494 * buildbot/test/test_run.py (Status.testDisappear): test ping
4495 (Status.disappearSlave): fix it
4497 2004-11-30 Brian Warner <warner@lothar.com>
4499 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4500 (IBuilderControl): add .getBuild(num), only works for the current
4501 build, of course, although it might be interesting to offer
4502 something for builds in the .waiting or .interlocked state.
4504 * buildbot/process/base.py (Build): have .stopBuild just do the
4505 interrupt, then let the build die by itself.
4506 (BuildControl): add .stopBuild, and add a point-event named
4507 'interrupt' just after the build so status viewers can tell that
4509 (BuilderControl): add .getBuild
4511 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4512 stops when you kill it, good for testing
4513 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4514 contains the 'reason' text.
4516 * buildbot/status/html.py: Add Stop Build button, if the build can
4517 still be stopped. Send a Redirect (to the top page) one second
4518 later, hopefully long enough for the interrupt to have an effect.
4519 Move make_row() up to top-level to share it between Stop Build and
4522 * buildbot/slave/commands.py: only kill the child process once
4524 * buildbot/test/test_run.py: add testInterrupt
4526 2004-11-29 Brian Warner <warner@lothar.com>
4528 * buildbot/process/base.py: Refactor command interruption. The
4529 Build is now responsible for noticing that the slave has gone
4530 away: Build.lostRemote() interrupts the current step and makes
4531 sure that no further ones will be started.
4533 * buildbot/process/builder.py: When the initial remote_startBuild
4534 message fails, log it: this usually indicates that the slave has
4535 gone away, but we don't really start paying attention until they
4536 fail to respond to the first step's command.
4538 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4539 slave disconnect. Now sports a new interrupt() method. Error
4540 handling was simplified a lot by chaining deferreds, so
4541 remoteFailed/remoteComplete were merged into a single
4542 remoteComplete method (which can now get a Failure object).
4543 Likewise failed/finished were merged into just _finished.
4544 (BuildStep): Add interrupt(why) method, and if why is a
4545 ConnectionLost Failure then the step is failed with some useful
4548 * buildbot/slave/bot.py: stop the current command when the remote
4549 Step reference is lost, and when the slave is shut down.
4550 (Bot): make it a MultiService, so it can have children. Use
4551 stopService to tell when the slave is shutting down.
4552 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4553 remote_interruptCommand (which asks the current SlaveCommand to
4554 stop but allows it to keep emitting status messages), and
4555 stopCommand (which tells it to shut up and die).
4557 * buildbot/slave/commands.py: make commands interruptible
4558 (ShellCommand.kill): factor out os.kill logic
4559 (Command): factor out setup()
4560 (Command.sendStatus): don't send status if .running is false, this
4561 happens when the command has been halted.
4562 (Command.interrupt): new method, used to tell the command to die
4563 (SlaveShellCommand): implement .interrupt
4564 (DummyCommand): implement .interrupt
4565 (SourceBase, etc): factor out setup(), don't continue substeps if
4568 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4569 so they can be called after finishing
4571 * buildbot/test/test_run.py: new tests for disconnect behavior,
4572 refactor slave-shutdown routines, add different kinds of
4575 2004-11-27 Brian Warner <warner@lothar.com>
4577 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4578 method to express ETA time like "2m45s" instead of "165 seconds"
4580 2004-11-24 Brian Warner <warner@lothar.com>
4582 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4583 archive after the test completes, to avoid cluttering the user's
4584 'tla archives' listing with a bogus entry. Arch doesn't happen to
4585 provide any way to override the use of ~/.arch-params/, so there
4586 isn't a convenient way to avoid touching the setup of the user who
4588 (VC_HTTP.testArchHTTP): same
4590 2004-11-23 Brian Warner <warner@lothar.com>
4592 * buildbot/status/html.py (TextLog): split render() up into
4593 render_HEAD and render_GET. Use a Producer when sending log
4594 chunks, to reduce memory requirements and avoid sending huge
4595 non-Banana-able strings over web.distrib connections. Requires
4596 peeking under the covers of IStatusLog.
4597 (TextLog.resumeProducing): fix the "as text" link, handle client
4598 disconnects that occur while we're still sending old chunks.
4600 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4601 use defer.succeed, not the non-existent defer.success
4602 (LogFile.waitUntilFinished): same
4603 (LogFile.subscribe): don't add watchers to a finished logfile
4605 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4608 2004-11-23 Brian Warner <warner@lothar.com>
4610 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4612 2004-11-23 Brian Warner <warner@lothar.com>
4614 * NEWS: update for the 0.6.1 release
4615 * MANIFEST.in: add new files
4617 * README (INSTALLATION): explain how to enable the extra VC tests
4619 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4620 level to, so old pickled builds can be displayed ok
4622 2004-11-22 Brian Warner <warner@lothar.com>
4624 * NEWS: summarize updates since last release
4626 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4627 Yoz Grahame. Closes SF#1050138.
4629 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4632 * buildbot/process/step_twisted.py (Trial): update docs a bit
4634 * docs/factories.xhtml: fix Trial factory docs to match reality.
4637 * buildbot/process/factory.py (Trial.__init__): add args for
4638 randomly= and recurse=, making them available to instantiators
4639 instead of only to subclassers. Closes: SF#1049759.
4641 2004-11-15 Brian Warner <warner@lothar.com>
4643 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4644 try to teach the Quick factory to use multiple versions of python
4646 2004-11-12 Brian Warner <warner@lothar.com>
4648 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4649 safer w32-compatible approach, and only use it on windows
4650 (BuildStatus.saveYourself): same
4652 2004-11-11 Brian Warner <warner@lothar.com>
4654 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4655 it: one string merge per chunk. There are now separate .entries
4656 and .runEntries lists: when enumerating over all chunks, make sure
4658 * buildbot/test/test_status.py (Log): more tests
4660 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4661 chunks together, up to 10kb per chunk. This ought to cut down on
4662 the CPU-burning overhead of large log files. Thanks to Alexander
4663 Staubo for spotting the problem.
4664 * buildbot/test/test_status.py (Log): tests for same
4666 2004-11-10 Brian Warner <warner@lothar.com>
4668 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4669 header to outbound mail
4670 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4672 2004-11-08 Brian Warner <warner@lothar.com>
4674 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4675 can't do os.rename() onto an existing file, so catch the exception
4676 and unlink the target file first. This introduces a slight window
4677 where the existing file could be lost, but the main failure case
4678 (disk full) should still be handled safely.
4679 (BuildStatus.saveYourself): same
4681 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4682 separator character instead of os.sep, because the filenames being
4683 split here are coming from the VC system, which can have a
4684 different pathname convention than the local host. This should
4685 help a buildmaster running on windows that uses a CVS repository
4686 which runs under unix.
4687 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4689 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4690 when there are no test failures to be parsed
4692 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4693 instead of the unix-specific os.system("cp"), thanks to Elliot
4694 Murphy for this and the other buildbot-vs-windows catches.
4695 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4697 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4698 echo the command as it is run
4700 * setup.py: install sample.mk too, not just sample.cfg
4701 (scripts): install contrib/windows/buildbot.bat on windows
4703 2004-11-07 Brian Warner <warner@lothar.com>
4705 * buildbot/process/builder.py (Builder._detached): clear the
4706 self.currentBuild reference, otherwise the next build will be
4707 skipped because we think the Builder is already in use.
4709 * docs/examples/twisted_master.cfg: update to match current usage
4710 on the Twisted buildbot
4712 2004-10-29 Brian Warner <warner@lothar.com>
4714 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4716 2004-10-28 Brian Warner <warner@lothar.com>
4718 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4719 have separate doVCUpdate/doVCFull methods. Catch an update failure
4720 and respond by clobbering the source directory and re-trying. This
4721 will handle local changes (like replacing a file with a directory)
4722 that will cause CVS and SVN updates to fail.
4723 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4725 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4728 2004-10-19 Brian Warner <warner@lothar.com>
4730 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4732 * buildbot/status/html.py (StatusResourceTestResults): display any
4733 TestResults that the Build might have
4734 (StatusResourceTestResult): and the logs for each TestResult
4735 (StatusResourceBuild): add link from the per-build page
4737 2004-10-15 Brian Warner <warner@lothar.com>
4739 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4740 the 'problems' portion of stdout, add TestResults to our build
4741 * buildbot/test/test_twisted.py (Parse.testParse): test it
4743 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4744 to retrieve a dict of accumulated test results
4745 (ITestResult): define what a single test result can do
4746 * buildbot/status/builder.py (TestResult): implement ITestResult
4747 (BuildStatus.getTestResults): retrieve dict of TestResults
4748 (BuildStatus.addTestResult): add TestResults
4749 * buildbot/test/test_status.py (Results.testAddResults): test it
4751 2004-10-14 Brian Warner <warner@lothar.com>
4753 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4754 instead of os.system("rm -rf") for win32 portability
4756 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4757 SignalMixin instead of starting/stopping the reactor, which is
4758 likely to cause problems with other tests
4760 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4761 self.copyComplete() call. Yoz Grahame makes the catch.
4763 * contrib/windows/buildbot.bat: helper script to deal with path
4764 issues. Thanks to Yoz Grahame.
4766 * buildbot/master.py (BuildMaster.startService): don't register a
4767 SIGHUP handler if the signal module has no SIGHUP attribute.
4768 Apparently win32 does this.
4770 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4772 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4773 test if the reactor can't offer UNIX sockets
4775 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4776 error introduced in the last commit. We really need that
4779 2004-10-12 Brian Warner <warner@lothar.com>
4781 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4782 when describing a maildir source. Thanks to Stephen Davis.
4784 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4787 * buildbot/scripts/runner.py (createMaster): install Makefile too
4788 (start): add --no_save to 'start' command
4789 * buildbot/scripts/sample.mk: simple convenience Makefile with
4790 start/stop/reload targets
4792 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4795 2004-09-30 Brian Warner <warner@lothar.com>
4797 * setup.py: Releasing buildbot-0.6.0
4799 2004-09-30 Brian Warner <warner@lothar.com>
4801 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4802 test_trial.py from the source tarball until support is complete.
4804 * NEWS: update for 0.6.0 release
4805 * buildbot/__init__.py (version): same
4808 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4809 'source' command to tell users where to get the Buildbot source
4811 * docs/examples/*.cfg: update to modern standards
4813 * NEWS: update for release
4815 * buildbot/scripts/runner.py (createMaster): remove the
4816 -shutdown.tap stuff now that it isn't necessary
4818 (start): launch buildbot.tap, not buildbot-shutdown.tap
4821 * buildbot/status/mail.py (Domain): shorten class name
4822 (MailNotifier): if lookup= is a string, pass it to Domain()
4823 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4824 (Mail.testBuild2): test the string-to-Domain shortcut
4825 (Mail.testMail): fix test
4828 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4831 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4832 more attributes on load
4833 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4834 to accomodate the whole waterfall page at once, and the thrashing
4835 results in a lot of unnecessary loads
4836 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4837 (BuilderStatus.saveYourself): same
4838 (BuilderStatus.eventGenerator): stop generating on the first missing
4839 build. We assume that saved builds are deleted oldest-first.
4840 (BuildStepStatus.__getstate__): .progress might not exist
4842 * buildbot/changes/changes.py (ChangeMaster): make it
4843 serializable, in $masterdir/changes.pck
4844 (ChangeMaster.stopService): save on shutdown
4845 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4846 * buildbot/test/test_config.py: load Changes before config file
4849 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4850 "Oh my god, you killed the command" header on a separate line
4852 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4853 skip over corrupted build pickles
4854 (BuilderStatus.getFullBuildByNumber): same
4855 (BuilderStatus.eventGenerator): skip over unavailable builds
4856 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4857 do an atomic rename. This prevents a corrupted pickle when some
4858 internal serialization error occurs.
4859 (BuilderStatus.saveYourself): same
4861 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4862 the timeout for shell commands, it got lost somehow
4864 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4865 run out of build steps, return the rest of the builder events
4867 * buildbot/interfaces.py (IBuilderControl.ping): add method
4869 * buildbot/process/builder.py (BuilderControl.ping): move
4870 slave-ping to BuilderControl, and fix the failure case in the
4871 process (Event.finish() is the verb, Event.finished is the noun).
4873 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4874 through the BuilderControl instead of the BuilderStatus
4875 (EventBox): add adapter for builder.Event, allowing builder events to
4876 be displayed in the waterfall display
4878 * buildbot/master.py (BotMaster.stopService): add a 'master
4879 shutdown' event to the builder's log
4880 (BuildMaster.startService): and a 'master started' on startup
4882 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4883 builder events into the BuildStep event stream
4884 (Status.builderAdded): add a 'builder created' event
4887 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4888 command to announce the completion of a running build
4889 (IrcStatusBot.command_FORCE): announce when the build finishes
4891 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4892 don't evict unfinished builds from the cache: they must stay in
4893 the full-cache until their logfiles have stopped changing. Make
4894 sure the eviction loop terminates if an unfinished build was hit.
4895 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4896 This lets exceptions be dumped in an email status message. Really
4897 we need LogFiles which contain both text and HTML, instead of two
4899 (BuildStatus.__getstate__): handle self.finished=False
4900 (Status.builderAdded): if the pickle is corrupted, abandon the
4901 history and create a new BuilderStatus object.
4903 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4904 self.progress attribute, helped one test which doesn't fully set
4905 up the Build object.
4907 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4908 IStatusLog methods into an Interface that is implemented by "stub"
4909 logs, for which all the actual text chunks are on disk (in the
4910 pickled Build instance). To show the log contents, you must first
4911 adapt the stub log to a full IStatusLog object.
4913 * buildbot/status/builder.py (LogFileStub): create separate stub
4914 log objects, which can be upgraded to a real one if necessary.
4915 (LogFile): make them persistable, and let them stubify themselves
4917 (BuildStepStatus): same
4919 (BuildStatus.saveYourself): save the whole build out to disk
4920 (BuilderStatus): make it persistable
4921 (BuilderStatus.saveYourself): save the builder to disk
4922 (BuilderStatus.addFullBuildToCache): implement two caches which
4923 hold Build objects: a small one which holds full Builds, and a
4924 larger one which holds "stubbed" Builds (ones with their LogFiles
4925 turned into LogFileStubs). This reduces memory usage by the
4926 buildmaster by not keeping more than a few (default is 2) whole
4927 build logs in RAM all the time.
4928 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4930 (BuilderStatus.eventGenerator): rewrite since .builds went away
4931 (BuilderStatus.buildStarted): remove the .builds array. Add the
4932 build to the "full" cache when it starts.
4933 (BuilderStatus._buildFinished): save the build to disk when it
4935 (Status): give it a basedir (same as the BuildMaster's basedir)
4936 where the builder pickles can be saved
4937 (Status.builderAdded): create the BuilderStatus ourselves, by
4938 loading a pickle from disk (or creating a new instance if there
4939 was none on disk). Return the BuilderStatus so the master can glue
4940 it into the new Builder object.
4942 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4943 all BuilderStatuses to save themselves out to disk. This is in
4944 lieu of saving anything important in the main Application pickle
4945 (the -shutdown.tap file).
4946 (BuildMaster.__init__): give Status() a basedir for its files
4947 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4948 to get the BuilderStatus, then give it to the Builder (instead of
4949 doing it the other way around). It's ok if the status announces
4950 the new Builder before it's really ready, as the outside world can
4951 only see the BuilderStatus object anyway (and it is ready before
4952 builderAdded returns). Use the builder's "builddir" (which
4953 normally specifies where the slave will run the builder) as the
4954 master's basedir (for saving serialized builds).
4956 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4957 coerce the logfile to IStatusLog before trying to get the text
4958 chunks out of it. This will pull the full (non-stubified) Build in
4959 from disk if necessary.
4960 (TextLog): fix the adapter registration
4962 * buildbot/test/test_control.py (Force.setUp): create the basedir
4963 * buildbot/test/test_web.py: same
4964 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4965 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4966 * buildbot/test/test_run.py (Run.testMaster): same
4967 (Status.setUp): same
4969 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4971 * buildbot/status/html.py (Waterfall.__init__): store actual
4972 allowForce flag passed in rather than using True for everyone;
4973 make sure setting it to False doesn't cause a NameError
4975 (StatusResourceBuilder.__init__) add the builder name to the page
4977 (StatusResourceBuilder.body) move HTML generation for a name/value
4978 row into a helper method (StatusResourceBuilder.make_row); only
4979 generate the "Force Build" form if allowForce was True and the
4980 slave is connected. Use class attributes in the generated HTML to
4981 spread a little CSS-joy.
4983 2004-09-28 Brian Warner <warner@lothar.com>
4985 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4986 warning-scanner to not ignore things like
4987 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4989 * buildbot/status/html.py (StatusResource.control): add some
4990 class-level values for .control in an attempt to make upgrading
4993 * buildbot/util.py (ComparableMixin): survive missing attributes,
4994 such as when a class is modified and we're comparing old instances
4997 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4998 failure handling, remove a redundant try/except block. Don't
4999 return the full traceback to the IRC channel.
5000 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5001 error messages. Get ETA properly.
5003 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5004 the reason, since (at least) IRC message will have <> in them.
5005 (StatusResourceBuilder.__init__): take an IBuilderControl
5006 (StatusResourceBuilder.force): use the IBuilderControl we get in
5007 the constructor instead of trying to make our own. Catch the
5008 new exceptions and ignore them for now (until we make an
5009 intermediate web page where we could show the error message)
5010 (StatusResource): create with an IControl, use it to give an
5011 IBuilderControl to all children
5012 (Waterfall): take an allowForce= option, pass an IControl object
5013 to StatusResource if it is True
5015 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5017 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5018 catch new exceptions and return string forms
5020 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5021 * buildbot/process/builder.py (Builder.forceBuild): raise them
5022 * buildbot/test/test_control.py (Force.testNoSlave): new test
5023 (Force.testBuilderInUse): same
5026 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5028 * buildbot/test/test_run.py: use IControl
5029 * buildbot/test/test_vc.py: same
5031 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5032 to use IControl. Still offline.
5033 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5035 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5036 who=None so periodic builds don't send out status mail
5037 (Builder.forceBuild): include reason in the log message
5038 (BuilderControl.forceBuild): rename 'name' to 'who'
5040 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5041 'who' parameter, but make it None by default so builds forced by
5042 slave admins don't cause status mail to be sent to anybody
5043 (BotMaster.forceBuild): same. this method is deprecated.
5044 (DebugPerspective.perspective_forceBuild): same, use IControl.
5045 (DebugPerspective.perspective_fakeChange): use IControl..
5046 (Dispatcher.requestAvatar): .. so don't set .changemaster
5048 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5049 parameter to avoid confusion with the name of the builder
5052 * buildbot/status/mail.py: refine comment about needing 2.3
5054 * buildbot/status/html.py: move all imports to the top
5056 * buildbot/test/test_control.py: test new interfaces
5057 * buildbot/test/test_run.py (Status): handle new interfaces
5058 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5060 * buildbot/process/base.py (BuildControl): implement IBuildControl
5061 and its lonely getStatus() method
5063 * buildbot/process/builder.py (BuilderControl): implement
5064 IBuilderControl, obtained by adapting the Builder instance
5065 (Builder.startBuild): return a BuilderControl instead of a
5066 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5067 accomplish the same thing.
5069 * buildbot/master.py: move all import statements to the top
5070 (Control): implement IControl, obtained by adapting the
5071 BuildMaster instance.
5073 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5074 IBuildControl. These are used to force builds. Eventually they
5075 will provide ways to reconfigure the Builders, pause or abandon a
5076 Build, and perhaps control the BuildMaster itself.
5078 2004-09-26 Brian Warner <warner@lothar.com>
5080 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5081 ends up comparing us against something without a .__class__
5083 2004-09-24 Brian Warner <warner@lothar.com>
5085 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5088 * Makefile: add 'deb-snapshot' target, to create a timestamped
5091 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5093 2004-09-23 Brian Warner <warner@lothar.com>
5095 * buildbot/__init__.py (version): move version string here
5096 * setup.py: get version string from buildbot.version
5097 * buildbot/status/html.py (WaterfallStatusResource.body): add
5098 buildbot version to the page footer
5099 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5102 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5103 slaves, let the second know where the first one is coming from
5104 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5105 see our exceptions. It would be nice if there were a way to just
5106 send them the exception type and value, not the full traceback.
5109 * buildbot/status/mail.py (MailNotifier): add a new argument
5110 sendToInterestedUsers=, which can be set to False to disable the
5111 usual send-to-blamelist behavior.
5112 (top): handle python-2.2 which has no email.MIMEMultipart
5113 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5114 (MailNotifier.disownServiceParent): unsubscribe on removal
5116 * buildbot/test/test_status.py (Mail.testBuild2): test it
5119 * buildbot/status/progress.py (Expectations.wavg): tolerate
5120 current=None, which happens when steps start failing badly
5121 * buildbot/test/test_status.py (Progress.testWavg): test for it
5123 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5124 doesn't understand args['revision'], emit a warning instead of
5125 bailing completely. Updating to -rHEAD is probably close enough.
5127 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5129 * buildbot/test/test_status.py: at least import bb.status.client
5130 even if we don't have any test coverage for it yet
5132 * contrib/svn_buildbot.py: don't require python2.3
5133 (main): wait, do require it (for sets.py), but explain how to
5134 make it work under python2.2
5136 2004-09-23 Brian Warner <warner@lothar.com>
5138 * contrib/svn_buildbot.py: include the revision number in the Change
5140 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5141 using util.now() because FreshCVS is a realtime service
5143 * buildbot/status/event.py: delete dead code
5144 * buildbot/process/step.py: don't import dead Event class
5145 * buildbot/process/step_twisted.py: same
5146 * buildbot/status/builder.py: same
5147 * buildbot/status/client.py: same
5149 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5151 * buildbot/changes/changes.py (Change): set .when from an __init__
5152 argument (which defaults to now()), rather than having
5153 ChangeMaster.addChange set it later.
5154 (ChangeMaster.addChange): same
5156 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5157 (parseSyncmail): same. Just use util.now() for now.
5158 (parseBonsaiMail): parse the timestamp field for when=
5160 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5161 instead of setting .when after the fact
5165 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5166 results when the target project uses retrial. Still under
5168 * buildbot/test/test_trial.py: same
5170 2004-09-21 Brian Warner <warner@lothar.com>
5172 * buildbot/status/mail.py (MailNotifier.__init__): include
5173 success/warnings/failure in the Subject line
5174 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5175 use step.logname for the addLogs=True attachment filenames
5176 * buildbot/test/test_status.py (Mail): test Subject lines
5177 (Mail.testLogs): test attachment filenames
5179 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5180 accept a 'who' argument from the debug tool
5181 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5182 * contrib/debug.glade: add text box to set 'who'
5184 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5185 .getBuilderName with .getBuilder().getName(), more flexible
5186 (IStatusLog.getName): logs have short names, but you can prefix
5187 them with log.getStep().getName() to make them more useful
5188 * buildbot/status/builder.py: same
5189 * buildbot/status/client.py: same
5190 * buildbot/status/html.py: same
5191 * buildbot/test/test_run.py (Status.testSlave): same
5192 * buildbot/process/step.py: tweak logfile names
5194 * buildbot/status/mail.py (MailNotifier): add lookup, change
5195 argument to extraRecipients. The notifier is now aimed at sending
5196 mail to the people involved in a particular build, with additional
5197 constant recipients as a secondary function.
5199 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5200 including slow-lookup and failing-lookup. Make sure the blamelist
5201 members are included.
5203 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5204 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5205 (IBuildStatus.getInterestedUsers): new method
5206 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5207 * buildbot/status/client.py (remote_getResponsibleUsers): same
5208 * buildbot/status/html.py (StatusResourceBuild.body): same
5209 * buildbot/test/test_run.py (Status.testSlave): same
5211 2004-09-20 Brian Warner <warner@lothar.com>
5213 * docs/users.xhtml: update concepts
5215 * Makefile: add a convenience makefile, for things like 'make
5216 test'. It is not included in the source tarball.
5218 2004-09-16 Brian Warner <warner@lothar.com>
5220 * NEWS: mention /usr/bin/buildbot, debian/*
5222 * debian/*: add preliminary debian packaging. Many thanks to
5223 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5224 it considerably since it left their hands, I am responsible for
5225 all breakage that's resulted.
5227 * bin/buildbot: create a top-level 'buildbot' command, to be
5228 installed in /usr/bin/buildbot . For now it's just a simple
5229 frontend to mktap/twistd/kill, but eventually it will be the entry
5230 point to the 'try' command and also a status client. It is also
5231 intended to support the upcoming debian-packaging init.d scripts.
5232 * buildbot/scripts/runner.py: the real work is done here
5233 * buildbot/scripts/__init__.py: need this too
5234 * buildbot/scripts/sample.cfg: this is installed in new
5235 buildmaster directories
5236 * setup.py: install new stuff
5238 2004-09-15 Brian Warner <warner@lothar.com>
5240 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5241 'file:' schema (the version shipped with OS-X was built without the
5243 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5244 updates the log-timestamp, to make sure it isn't still running after
5247 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5248 values to the config file.
5249 * docs/examples/hello.cfg: add examples
5250 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5251 * buildbot/status/builder.py (Status.getProjectURL): implement them
5252 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5253 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5254 * buildbot/status/html.py (WaterfallStatusResource): display them
5257 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5258 certain error cases don't suffer a secondary exception.
5259 (top): Skip tests if the corresponding VC tool is not installed.
5261 * buildbot/process/factory.py (Trial): introduce separate
5262 'buildpython' and 'trialpython' lists, since trialpython=[] is
5263 what you want to invoke /usr/bin/python, whereas ./setup.py is
5264 less likely to be executable. Add env= parameter to pass options
5265 to test cases (which is how I usually write tests, I don't know if
5266 anyone else does it this way).
5268 * buildbot/process/step_twisted.py (Trial): handle python=None.
5269 Require 'testpath' be a string, not a list. Fix tests= typo.
5270 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5272 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5273 way to deal with the possibility of removing the disconnect notify
5275 (CVS): add a 'login' parameter to give a password to 'cvs login',
5276 commonly used with pserver methods (where pw="" or pw="guest")
5278 * buildbot/slave/commands.py (SourceBase): move common args
5279 extraction and setup() to __init__, so everything is ready by the
5280 time setup() is called
5281 (CVS.start): call 'cvs login' if a password was supplied
5282 (ShellCommand): special-case PYTHONPATH: prepend the master's
5283 value to any existing slave-local value.
5285 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5286 don't have a remote, mark the builder as Offline. This whole
5287 function should probably go away and be replaced by individual
5289 (Builder.buildFinished): return the results to the build-finished
5290 deferred callback, helps with testing
5292 2004-09-14 Brian Warner <warner@lothar.com>
5294 * buildbot/test/test_vc.py: put all the repositories needed to run
5295 the complete tests into a single small (1.3MB) tarball, so I can
5296 make that tarball available on the buildbot web site. Test HTTP
5297 access (for Arch and Darcs) by spawning a temporary web server
5298 while the test runs.
5300 * docs/users.xhtml: new document, describe Buildbot's limited
5301 understanding of different human users
5303 * buildbot/test/test_vc.py: rearrange test cases a bit
5305 * buildbot/process/step_twisted.py (Trial): handle testpath=
5306 * buildbot/process/factory.py (Trial): update to use step.Trial
5308 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5310 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5311 the overall build text (which gives you 'failed 2 tests' rather
5313 (BuildStepStatus.text2): default to [], not None
5315 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5318 2004-09-12 Brian Warner <warner@lothar.com>
5320 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5321 log the whole exception if it's just an AttributeError (old slave)
5323 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5324 so (e.g.) sub-commands can be run in the right directory.
5325 (ShellCommand.start): accept an optional errorMessage= argument
5326 to make life easier for SVN.start
5327 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5329 (ShellCommand.start): move ['dir'] compatibility hack..
5330 (RemoteShellCommand.start): .. to here so everyone can use it
5332 * buildbot/process/step_twisted.py (Trial): use .workdir
5334 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5335 text displayed when debuild fails completely
5336 (Trial): snarf _trial_temp/test.log from the slave and display it
5338 2004-09-11 Brian Warner <warner@lothar.com>
5340 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5342 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5343 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5345 * buildbot/process/step.py (ShellCommand): call .createSummary
5346 before .evaluateCommand instead of the other way around. This
5347 makes it slightly easier to count warnings and then use that to
5348 set results=WARNINGS
5349 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5351 * buildbot/process/base.py (Build.buildFinished): update status
5352 before doing progress. It's embarrassing for the build to be stuck
5353 in the "building" state when an exceptions occurs elsewhere..
5355 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5356 python2.2 doesn't have 'sum'
5358 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5359 to prevent clients from accidentally sorting it
5361 * buildbot/master.py (Manhole): add username/password
5362 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5363 c['manholePort'], deprecate old usage
5364 * docs/config.xhtml: document c['manhole']
5365 * docs/examples/hello.cfg: show example of using a Manhole
5368 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5369 pretend the slave is up to date
5371 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5372 the module, overlaps with 'log', the local variable
5374 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5376 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5377 new method to let Steps find out the version of their
5378 corresponding SlaveCommand.
5379 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5380 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5381 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5383 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5384 (Arch.startVC): same
5385 (P4Sync.startVC): same
5387 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5388 Deferred so we can catch errors in remote_startCommand
5389 (RemoteShellCommand.start): same
5391 * docs/examples/twisted_master.cfg: update sample config file
5393 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5394 after connectionMade() is called, not before. Close stdin at that
5397 * buildbot/process/process_twisted.py: update to use Trial, clean
5398 up argument passing (move to argv arrays instead of string
5401 * buildbot/process/step_twisted.py (Trial): new step to replace
5402 RunUnitTests, usable by any trial-using project (not just
5403 Twisted). Arguments have changed, see the docstring for details.
5405 * buildbot/process/base.py (Build.startBuild): this now returns a
5406 Deferred. Exceptions that occur during setupBuild are now
5407 caught better and lead to fewer build_status weirdnesses, like
5408 finishing a build that was never started.
5409 (Build.buildFinished): fire the Deferred instead of calling
5410 builder.buildFinished directly. The callback argument is this
5411 Build, everything else can be extracted from it, including the
5412 new build.results attribute.
5413 * buildbot/process/builder.py (Builder.startBuild): same
5414 (Builder.buildFinished): same, extract results from build
5416 * buildbot/process/step.py (ShellCommands): remove dead code
5418 2004-09-08 Brian Warner <warner@lothar.com>
5420 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5421 doesn't try to use the leftover patched workdir
5422 (SourceStamp): test source-stamp computation for CVS and SVN
5424 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5425 patched workdir ('touch .buildbot-patched') so we don't try to
5427 (SourceBase.start): add ['revision'] for all Source steps
5428 (CVS): change args: use ['branch'] for -r, remove ['files']
5429 (CVS.buildVC): fix revision/branch stuff
5430 (SVN): add revision stuff
5432 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5433 kwargs (except 'workdir') to avoid silent spelling errors
5434 (ShellCommand.__init__): same
5435 (Source): new base class for CVS/SVN/etc. Factor out everything
5436 common, add revision computation (perform the checkout with a -D
5437 DATE or -r REVISION that gets exactly the sources described by the
5438 last Change), overridable with step.alwaysUseLatest. Add patch
5439 handling (build.getSourceStamp can trigger the use of a base
5440 revision and a patch).
5441 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5442 * docs/steps.xhtml: update docs
5443 * docs/source.xhtml: mention .checkoutDelay
5444 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5446 * buildbot/process/base.py (Build.setSourceStamp): add a
5447 .sourceStamp attribute to each Build. If set, this indicates that
5448 the build should be done with something other than the most
5449 recent source tree. This will be used to implement "try" builds.
5450 (Build.allChanges): new support method
5451 (Build.lastChangeTime): remove, functionality moved to Source steps
5452 (Build.setupBuild): copy the Step args before adding ['workdir'],
5453 to avoid modifying the BuildFactory (and thus triggering spurious
5457 * buildbot/status/html.py: rename s/commits/changes/
5458 (StatusResourceChanges): same
5459 (CommitBox.getBox): same, update URL
5460 (WaterfallStatusResource): same
5461 (StatusResource.getChild): same
5463 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5464 * contrib/debug.glade: add optional 'revision' to the fakeChange
5466 * buildbot/changes/changes.py (html_tmpl): display .revision
5467 (ChangeMaster.addChange): note .revision in log
5468 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5469 accept a ['revision'] attribute
5471 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5473 * buildbot/master.py (BotMaster.getPerspective): update the
5474 .connected flag in SlaveStatus when it connects
5475 (BotMaster.detach): and when it disconnects
5476 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5477 (BuildMaster.loadConfig_Builders): walk old list correctly
5479 * buildbot/test/test_config.py: fix prefix= usage
5481 2004-09-06 Brian Warner <warner@lothar.com>
5485 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5486 poll a P4 depot looking for recent changes. Thanks to Dave
5487 Peticolas for the contribution. Probably needs some testing after
5490 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5491 requires manual client setup for each buildslave. Rather
5492 experimental. Thanks again to Dave Peticolas.
5493 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5495 * buildbot/changes/changes.py (Change): add a .revision attribute,
5496 which will eventually be used to generate source-stamp values.
5498 * buildbot/process/step.py (RemoteCommand.start): use
5499 notifyOnDisconnect to notice when we lose the slave, then treat it
5500 like an exception. This allows LogFiles to be closed and the build
5501 to be wrapped up normally. Be sure to remove the disconnect
5502 notification when the step completes so we don't accumulate a
5503 bazillion such notifications which will fire weeks later (when the
5504 slave finally disconnects normally). Fixes SF#915807, thanks to
5505 spiv (Andrew Bennetts) for the report.
5506 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5507 really isn't Logged- specific
5508 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5509 header, since it's almost always going to be appended to an
5511 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5512 update test to handle use of notifyOnDisconnect
5514 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5515 don't clear .ETA and .currentBuild when going offline, let the
5516 current build clean up after itself
5518 * buildbot/process/builder.py (Builder.detached): wait a moment
5519 before doing things like stopping the current build, because the
5520 current step will probably notice the disconnect and cleanup the
5522 * buildbot/test/test_run.py (Status.tearDown): update test to
5523 handle asynchronous build-detachment
5525 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5527 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5528 hush a debug message
5530 2004-09-05 Brian Warner <warner@lothar.com>
5532 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5533 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5534 kernels do this: the fcntl module has the F_NOTIFY constant, but
5535 the kernel itself doesn't support the operation. Thanks to Olly
5536 Betts for spotting the problem.
5538 * buildbot/process/step.py (Darcs): new source-checkout command
5539 (Arch): new source-checkout command
5540 (todo_P4): fix constructor syntax, still just a placeholder
5541 * buildbot/test/test_vc.py (VC.testDarcs): test it
5542 (VC.testDarcsHTTP): same, via localhost HTTP
5544 (VC.testArchHTTP): same
5545 * NEWS: mention new features
5547 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5548 which tells the step to stash stdout text locally (in .stdout).
5549 Slave-side Commands can use this to make decisions based upon the
5550 output of the the ShellCommand (not just the exit code).
5551 (Darcs): New source-checkout command
5552 (Arch): New source-checkout command, uses .keepStdout in one place
5553 where it needs to discover the archive's default name.
5555 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5556 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5557 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5559 * buildbot/process/step.py (ShellCommand.describe): add an
5560 alternate .descriptionDone attribute which provides descriptive
5561 text when the step is complete. .description can be ["compiling"],
5562 for use while the step is running, then .descriptionDone can be
5563 ["compile"], used alone when the step succeeds or with "failed" when
5564 it does not. Updated other steps to use the new text.
5565 * buildbot/process/step_twisted.py: same
5566 * buildbot/test/test_run.py: update tests to match
5568 2004-08-30 Brian Warner <warner@lothar.com>
5570 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5571 (CVS.__init__): send 'patch' argument to slave
5572 (CVS.start): don't create the LoggedRemoteCommand until start(),
5573 so we can catch a .patch added after __init__
5574 (SVN.__init__): add 'patch' to SVN too
5577 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5578 argument, to let commands push data into the process' stdin pipe.
5579 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5580 is in use, since closing a PTY doesn't really affect the process
5581 in the right way (in particular, I couldn't run /usr/bin/patch
5583 (SourceBase.doPatch): handle 'patch' argument
5585 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5588 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5589 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5591 * buildbot/master.py (BotPerspective.got_commands): get command
5592 versions from slave, give to each builder
5593 * buildbot/process/builder.py (Builder.attached): stash slave
5594 command versions in .remoteCommands
5596 * docs/steps.xhtml: bring docs in-line with reality
5598 * buildbot/process/step.py (CVS.__init__): more brutal
5599 compatibility code removal
5600 (SVN.__init__): same
5602 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5603 (SlaveShellCommand.start): require ['workdir'] argument, remove
5604 the ['dir'] fallback (compatibility will come later)
5605 (SourceBase): update docs
5606 (SourceBase.start): remove ['directory'] fallback
5609 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5610 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5611 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5613 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5614 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5615 code.. I will figure out 0.5.0-compatibility hooks later)
5617 2004-08-30 Brian Warner <warner@lothar.com>
5619 * buildbot/process/process_twisted.py: rewrite in terms of new
5620 BuildFactory base class. It got significantly shorter. Yay
5623 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5624 work with the new "self.build isn't nailed down until we call
5625 step.start()" scheme: specifically, __init__ is called before the
5626 build has decided on which Changes are going in, so we don't scan
5627 build.allFiles() for .xhtml files until start()
5628 (HLint.commandComplete): use getText(), not getStdout()
5629 (RunUnitTests.start): same: don't use .build until start()
5630 (RunUnitTests.describe): oops, don't report (None) when using
5632 (RunUnitTests.commandComplete): use getText()
5633 (RunUnitTests.createSummary): same
5634 (BuildDebs.commandComplete): same
5636 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5637 set args['command'] until start(), since our BuildStep is allowed
5638 to change their mind up until that point
5639 (TreeSize.commandComplete): use getText(), not getStdout()
5641 * docs/examples/twisted_master.cfg: update to current standards
5643 * docs/factories.xhtml: update
5644 * buildbot/process/factory.py: implement all the common factories
5645 described in the docs. The Trial factory doesn't work yet, and
5646 I've probably broken all the process_twisted.py factories in the
5647 process. There are compatibility classes left in for things like
5648 the old BasicBuildFactory, but subclasses of them are unlikely to
5650 * docs/examples/glib_master.cfg: use new BuildFactories
5651 * docs/examples/hello.cfg: same
5653 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5654 explicit 'workdir' args
5656 * buildbot/process/base.py (BuildFactory): move factories to ..
5657 * buildbot/process/factory.py (BuildFactory): .. here
5658 * buildbot/process/process_twisted.py: handle move
5659 * buildbot/test/test_config.py: same
5660 * buildbot/test/test_run.py: same
5661 * buildbot/test/test_steps.py: same
5662 * buildbot/test/test_vc.py: same
5663 * docs/factories.xhtml: same
5665 * NEWS: mention config changes that require updating master.cfg
5667 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5668 argument to all steps that weren't given one already, pointing at
5669 the "build/" directory.
5671 * docs/examples/hello.cfg: remove explicit 'workdir' args
5673 * docs/factories.xhtml: document standard BuildFactory clases,
5674 including a bunch which are have not yet been written
5676 2004-08-29 Brian Warner <warner@lothar.com>
5678 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5679 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5680 buildbot.status.builder so they aren't quite so internal
5681 * buildbot/process/base.py, buildbot/process/builder.py: same
5682 * buildbot/process/maxq.py, buildbot/process/step.py: same
5683 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5684 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5685 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5687 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5688 to handle new getLogs()-returns-list behavior
5689 (StatusResourceBuildStep.getChild): same
5690 (StepBox.getBox): same
5691 (WaterfallStatusResource.phase0): same
5693 * docs/source.xhtml: document how Buildbot uses version-control
5694 systems (output side: how we get source trees)
5695 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5696 systems (input side: how we learn about Changes)
5698 * buildbot/master.py (Manhole): use ComparableMixin
5699 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5700 * buildbot/changes/mail.py (MaildirSource): same
5701 * buildbot/status/client.py (PBListener): same
5702 * buildbot/status/html.py (Waterfall): same
5703 * buildbot/status/words.py (IRC): same
5705 * NEWS: start describing new features
5707 * buildbot/status/mail.py (MailNotifier): finish implementation.
5708 The message body is still a bit sparse.
5709 * buildbot/test/test_status.py (Mail): test it
5711 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5712 and __hash__ methods I wind up adding everywhere. Specifically
5713 intended to support the buildbot config-file update scheme where
5714 we compare, say, the old list of IStatusTargets against the new
5715 one and don't touch something which shows up on both lists.
5716 * buildbot/test/test_util.py (Compare): test case for it
5718 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5719 return a list instead of a dict
5720 (IBuildStepStatus.getLogs): same. The idea is that steps create
5721 logs with vaguely unique names (although their uniqueness is not
5722 guaranteed). Thus a compilation step should create its sole
5723 logfile with the name 'compile', and contribute it to the
5724 BuildStatus. If a step has two logfiles, try to create them with
5725 different names (like 'test.log' and 'test.summary'), and only
5726 contribute the important ones to the overall BuildStatus.
5727 * buildbot/status/builder.py (Event.getLogs): same
5728 (BuildStepStatus): fix default .text and .results
5729 (BuildStepStatus.addLog): switch to list-like .getLogs()
5730 (BuildStepStatus.stepFinished): same
5731 (BuildStatus.text): fix default .text
5732 (BuildStatus.getLogs): temporary hack to return all logs (from all
5733 child BuildStepStatus objects). Needs to be fixed to only report
5734 the significant ones (as contributed by the steps themselves)
5735 * buildbot/test/test_run.py: handle list-like .getLogs()
5736 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5738 2004-08-28 Brian Warner <warner@lothar.com>
5740 * buildbot/process/builder.py (Builder.attached): serialize the
5741 attachment process, so the attach-watcher isn't called until the
5742 slave is really available. Add detached watchers too, which makes
5745 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5747 * buildbot/test/test_swap.py: remove dead code
5749 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5750 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5751 sort of as if the command being run exited with a -1. There may
5752 still be some holes in this scheme.
5753 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5754 -r option appears before the module list
5755 * buildbot/process/step.py (CVS): add 'revision' argument
5757 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5758 when sending updates or stepComplete messages to the master, since
5759 we don't currently care whether they arrive or not. When we revamp
5760 the master/slave protocol to really resume interrupted builds,
5761 this will need revisiting.
5762 (lostRemote): remove spurious print
5764 * buildbot/master.py (BotPerspective.attached): serialize the
5765 new-builder interrogation process, to make testing easier
5766 (BotMaster.waitUntilBuilderDetached): convenience function
5768 * buildbot/status/builder.py (BuilderStatus): prune old builds
5769 (BuildStatus.pruneSteps): .. and steps
5770 (BuildStepStatus.pruneLogs): .. and logs
5771 (BuilderStatus.getBuild): handle missing builds
5772 * buildbot/status/html.py (StatusResourceBuild.body): display build
5773 status in the per-build page
5774 (BuildBox.getBox): color finished builds in the per-build box
5776 2004-08-27 Brian Warner <warner@lothar.com>
5778 * buildbot/status/mail.py (MailNotifier): new notification class,
5781 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5782 variants of a common base class which handles all the mode= logic
5784 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5786 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5788 2004-08-26 Brian Warner <warner@lothar.com>
5790 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5793 * buildbot/test/test_run.py: update to new Logfile interface, new
5794 buildbot.slave modules
5795 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5797 * MANIFEST.in: new sample config file
5798 * docs/examples/hello.cfg: same
5800 * buildbot/process/step_twisted.py: remove dead import
5802 * buildbot/process/step.py (RemoteCommand.run): catch errors
5804 (RemoteCommand.remote_update): ignore updates that arrive after
5806 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5807 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5808 the responsibilities of the subclass's methods
5809 (BuildStep.failed): catch errors during failure processing
5810 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5811 (CVS): move to a mode= argument (described in docstring), rather
5812 than the ungainly clobber=/export=/copydir= combination.
5813 (SVN): add mode= functionality to SVN too
5814 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5816 * buildbot/process/base.py (Build.startNextStep): catch errors
5817 during s.startStep()
5819 * buildbot/clients/base.py: update to new PB client interface.
5820 gtkPanes is still broken
5822 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5823 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5824 * setup.py: add buildbot.slave module
5825 * buildbot/bb_tap.py: handle move
5826 * buildbot/slave/registry.py: place to register commands, w/versions
5827 * buildbot/slave/bot.py: major simplifications
5828 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5829 instead of a fixed table. Eventually this will make the slave more
5830 extensible. Use 'start' method on the command, not .startCommand.
5831 Fix unsafeTracebacks handling (I think).
5832 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5833 helper class with a .start method that returns a Deferred.
5834 SlaveShellCommand is the form reached by the buildmaster. Commands
5835 which use multiple ShellCommands can just chain them as Deferreds,
5836 with some helper methods in Command (_abandonOnFailure and
5837 _checkAbandoned) to bail on rc!=0.
5838 (CVSCommand): prefer new mode= argument
5839 (SVNFetch): add mode= argument
5841 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5842 put a useful reason string on the build
5844 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5845 core functionality into an IStatusLog object
5846 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5847 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5848 (StatusResourceBuild.body): use proper accessor methods
5849 * buildbot/status/client.py (RemoteLog): PB-access goes here
5850 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5851 which delivers log contents too
5852 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5853 * buildbot/status/event.py: remove old Logfile completely
5855 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5856 subscription interface for IStatusLog subscriptions just like all
5857 other the status subscriptions
5858 (IStatusReceiver.logChunk): method called on subscribers
5860 2004-08-24 Brian Warner <warner@lothar.com>
5862 * buildbot/process/builder.py (Builder._pong): oops, ping response
5863 includes a result (the implicit None returned by remote_print).
5864 Accept it so the _pong method handles the response correctly.
5866 2004-08-06 Brian Warner <warner@lothar.com>
5868 * buildbot/test/test_config.py: update IRC, PBListener tests
5870 * buildbot/status/client.py (StatusClientPerspective): total
5871 rewrite to match new IStatus interfaces. New subscription scheme.
5872 There are still a few optimizations to make (sending down extra
5873 information with event messages so the client doesn't have to do a
5874 round trip). The logfile-retrieval code is probably still broken.
5875 Moved the PB service into its own port, you can no longer share a
5876 TCP socket between a PBListener and, say, the slaveport (this
5877 should be fixed eventually).
5878 * buildbot/clients/base.py (Client): revamp to match. still needs
5879 a lot of work, but basic event reporting works fine. gtkPanes is
5882 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5883 instance talks to a single irc server. Threw out all the old
5884 multi-server handling code. Still need to add back in
5885 builder-control (i.e. "force build")
5887 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5888 more random text to the as-yet-unreachable per-step page
5890 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5891 rename to stepETAUpdate
5892 (BuildStatus.subscribe): add build-wide ETA updates
5893 (BuilderStatus.getState): remove more cruft
5894 (BuilderStatus.getCurrentBuild): remove more cruft
5895 (BuilderStatus.buildStarted): really handle tuple-subscription
5896 * buildbot/test/test_run.py (Status.testSlave): handle the
5897 stepETAUpdate rename
5899 * buildbot/master.py (BuildMaster): don't add a default
5900 StatusClientService. Don't add a default IrcStatusFactory. Both
5901 are now added through c['status'] in the config file. c['irc'] is
5902 accepted for backwards compatibility, the only quirk is you cannot
5903 use c['irc'] to specify IRC servers on ports other than 6667.
5905 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5906 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5907 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5908 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5911 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5912 the buildmaster to re-read its config file
5915 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5916 find out the port our server is running on
5917 (WebTest.test_webPathname_port): same
5919 * buildbot/test/test_config.py (testWebPortnum): test it
5920 (testWebPathname): ditto
5922 * docs/config.xhtml: document new c['status'] configuration option
5924 * buildbot/status/html.py (Waterfall): new top-level class which
5925 can be added to c['status']. This creates the Site as well as the
5926 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5927 reachable as .parent, for everything.
5929 * buildbot/master.py (Manhole): make it a normal service Child
5930 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5931 webPathname. It will eventually replace c['irc'] and the implicit
5932 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5933 in as (deprecated) backward compatibility hooks for now.
5936 * buildbot/process/builder.py (Builder.buildFinished): don't
5937 inform out builder_status about a finished build, as it finds out
5938 through its child BuildStatus object
5940 * buildbot/status/html.py: extensive revamp. Use adapters to make
5941 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5942 have both starting and finishing times and adjust the waterfall
5943 display accordingly, using spacers if necessary. Use SlaveStatus
5944 to get buildslave info.
5945 (StatusResourceBuildStep): new just-one-step resource, used to get
5946 logfiles. No actual href to it yet.
5948 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5949 the time being, until I get the file-naming scheme right
5951 * buildbot/status/builder.py (Event): clean started/finished names
5952 (BuildStatus.isFinished): .finished is not None is the right test
5953 (BuildStatus.buildStarted): track started/finished times ourselves
5954 (BuilderStatus.getSlave): provide access to SlaveStatus object
5955 (BuilderStatus.getLastFinishedBuild): all builds are now in
5956 .builds, even the currently-running one. Accomodate this change.
5957 (BuilderStatus.eventGenerator): new per-builder event generator.
5958 Returns BuildStepStatus and BuildStatus objects, since they can
5959 both be adapted as necessary.
5960 (BuilderStatus.addEvent): clean up started/finished attributes
5961 (BuilderStatus.startBuild,finishBuild): remove dead code
5962 (SlaveStatus): new object to provide ISlaveStatus
5964 * buildbot/process/step.py (ShellCommand.getColor): actually
5965 return the color instead of setting it ourselves
5966 (CVS.__init__): pull .timeout and .workdir options out of
5967 **kwargs, since BuildStep will ignore them. Without this neither
5968 will be sent to the slave correctly.
5969 (SVN.__init__): same
5971 * buildbot/process/builder.py (Builder): move flags to class-level
5973 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5974 SlaveStatus handle that
5976 * buildbot/process/base.py (Build.firstEvent): remove dead code
5977 (Build.stopBuild): bugfix
5979 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5981 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5982 (ChangeMaster.eventGenerator): yield Changes, since there are now
5983 Adapters to turn them into HTML boxes
5985 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5986 (BotPerspective.attached): feed a SlaveStatus object
5987 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5988 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5990 * buildbot/interfaces.py: API additions
5991 (ISlaveStatus): place to get slave status
5993 2004-08-04 Brian Warner <warner@lothar.com>
5995 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5996 the delay finishes, so the step is marked as SUCCESS
5998 * buildbot/test/test_run.py (Status.testSlave): cover more of
5999 IBuildStatus and IBuildStepStatus
6001 * buildbot/status/progress.py (StepProgress): move some flags to
6002 class-level attributes
6003 (StepProgress.remaining): if there are no other progress metrics
6004 to go by, fall back to elapsed time
6005 (StepProgress.setExpectations): take a dict of metrics instead of
6007 (BuildProgress.setExpectationsFrom): pull expectations from the
6008 Expectations, instead of having it push them to the BuildProgress
6009 (Expectations): move some flags to class-level attributes
6010 (Expectations.__init__): copy per-step times from the
6012 (Expectations.expectedBuildTime): new method for per-build ETA
6014 * buildbot/status/event.py (Logfile): move some flags to
6015 class-level attributes
6016 (Logfile.logProgressTo): better method name, let step set the
6017 progress axis name (instead of always being "output")
6019 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6020 times directly, rather than depending upon the (possibly missing)
6021 .progress object. Use 'None' to indicate "not started/finished
6023 (BuildStepStatus.getExpectations): oops, return the full list of
6025 (BuilderStatus._buildFinished): append finished builds to .builds
6027 * buildbot/process/step.py (BuildStep): add separate .useProgress
6028 flag, since empty .progressMetrics[] still implies that time is a
6030 (CVS): set up the cmd in __init__, instead of waiting for start()
6032 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6033 calculation, this will eventually turn into a proper sourceStamp
6034 (Build.setupBuild): tell the Progress to load from the Expectations,
6035 instead of having the Expectations stuff things into the Progress
6036 (Build.buildException): add a build-level errback to make sure the
6037 build's Deferred fires even in case of exceptions
6039 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6041 * buildbot/process/builder.py (Builder.forceBuild): convey the
6042 reason instead of creating a fake Change
6044 * docs/examples/twisted_master.cfg: update to match reality
6046 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6047 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6048 fix or remove broken/breaking tests
6050 * buildbot/status/event.py (Logfile.__len__): remove evil method
6052 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6053 missing .build, for test convenience
6055 * buildbot/process/step_twisted.py: import fixes
6057 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6059 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6060 .statusbag reference
6062 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6063 connection at shutdown, and stop it from reconnecting
6065 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6066 chase down remote-execution bugs
6068 * buildbot/process/step.py: more fixes, remove
6069 BuildStep.setStatus()
6070 * buildbot/status/builder.py: move setStatus() functionality into
6072 * buildbot/status/event.py: minor fixes
6074 2004-08-03 Brian Warner <warner@lothar.com>
6076 * buildbot/process/base.py, buildbot/process/builder.py
6077 * buildbot/process/step.py, buildbot/status/builder.py
6078 * buildbot/status/event.py, buildbot/test/test_run.py:
6079 fix status delivery, get a basic test case working
6080 * buildbot/master.py: finish implementing basic status delivery,
6081 temporarily disable HTML/IRC/PB status sources
6083 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6085 * buildbot/status/progress.py (BuildProgress): remove dead code
6087 * buildbot/interfaces.py
6088 * buildbot/process/base.py, buildbot/process/builder.py
6089 * buildbot/process/step.py, buildbot/process/step_twisted.py
6090 * buildbot/status/builder.py: Complete overhaul of the all
6091 status-delivery code, unifying all types of status clients (HTML,
6092 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6093 look like. This commit is a checkpointing of the work-in-progress:
6094 the input side is mostly done (Builders/Builds sending status
6095 to the BuilderStatus/BuildStatus objects), but the output side has
6096 not yet been started (HTML resources querying BuilderStatus
6097 objects). Things are probably very broken right now and may remain
6098 so for several weeks, I apologize for the disruption.
6100 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6101 HTML as the log's contents. Currently used for exception tracebacks.
6102 * buildbot/status/progress.py: minor spelling changes
6104 2004-08-02 Brian Warner <warner@lothar.com>
6106 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6107 in mozilla. Also added stylesheets copied from Twisted's docs.
6108 Remember that these files are meant to be run through Lore first.
6109 Thanks to Philipp Frauenfelder for the fixes.
6110 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6111 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6112 * docs/template.tpl: added a Lore template
6114 2004-07-29 Brian Warner <warner@lothar.com>
6116 * buildbot/interfaces.py: revamp status delivery. This is the
6117 preview: these are the Interfaces that will be provided by new
6118 Builder code, and to which the current HTML/IRC/PB status
6119 displayers will be adapted.
6121 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6122 on the SlaveBuilder, not the Bot.
6123 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6125 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6126 set .usePTY on the FakeSlaveBuilder
6128 2004-07-25 Brian Warner <warner@lothar.com>
6130 * buildbot/changes/freshcvs.py: add some debug log messages
6131 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6132 disabled 'setFilter' syntax
6133 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6134 don't end with a slash
6136 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6138 * setup.py: bump to 0.5.0+ while between releases
6140 2004-07-23 Brian Warner <warner@lothar.com>
6142 * setup.py (version): Releasing buildbot-0.5.0
6144 2004-07-23 Brian Warner <warner@lothar.com>
6146 * README: update for 0.5.0 release
6148 * NEWS: update for 0.5.0 release
6150 2004-07-22 Brian Warner <warner@lothar.com>
6152 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6153 mktap-time configuration flag (--usepty=1, --usepty=0)
6154 * buildbot/bot.py: same
6156 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6157 an 'info' directory being unwanted
6159 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6160 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6161 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6162 and earlier), use a FreshCVSSourceOldcred instead.
6163 (test): simple test routine: connect to server, print changes
6165 * buildbot/changes/changes.py (Change.getTime): make it possible
6166 to print un-timestamped changes
6168 * buildbot/master.py (makeApp): delete ancient dead code
6169 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6170 * buildbot/test/test_config.py (testFindConfigFile): test it
6172 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6173 instead of win32 one
6176 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6177 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6180 * buildbot/process/base.py (Builder.__init__): change constructor
6181 to accept a dictionary of config data, rather than discrete
6182 name/slave/builddir/factory arguments
6184 * docs/examples/twisted_master.cfg: update to new syntax
6185 * docs/examples/glib_master.cfg: same
6186 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6187 rough tests of the new syntax
6190 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6191 to be an int, which means "run a web.distrib sub-server on a TCP
6192 port". This lets you publish the buildbot status page to a remote
6193 twisted.web server (using distrib.ResourceSubscription). Also
6194 rename the local attributes used to hold these web things so
6195 they're more in touch with reality.
6196 * buildbot/test/test_web.py: test webPortnum and webPathname
6197 * docs/config.xhtml: document this new use of webPathname
6199 * docs/config.xhtml: new document, slightly ahead of reality
6201 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6202 'prefix' handling: treat it as a simple string to check with
6203 .startswith, instead of treating it as a directory. This allows
6204 sub-directories to be used. If you use prefix=, you should give it
6205 a string that starts just below the CVSROOT and ends with a slash.
6206 This prefix will be stripped from all filenames, and filenames
6207 which do not start with it will be ignored.
6209 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6211 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6212 and --exclude (inverse of --include). SVN post-commit hooks
6213 now have total control over which changes get sent to buildbot and which
6216 2004-07-10 Brian Warner <warner@lothar.com>
6218 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6219 test case to match new API
6221 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6222 which crashed HTML display when self.entries=[] (needed to
6223 distinguish between [], which means "no entries yet", and None,
6224 which means "the entries have been swapped out to disk, go fetch
6227 2004-07-04 Brian Warner <warner@lothar.com>
6229 * buildbot/process/step_twisted.py (countFailedTests): Count
6230 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6231 10kb from the end because any import errors are wedged there and
6232 they would make us think the test log was unparseable.
6233 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6235 2004-06-26 Brian Warner <warner@lothar.com>
6237 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6238 delete-*.pyc command into an actual BuildStep, so we can label it
6240 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6241 (FullTwistedBuildFactory): same
6243 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6245 * contrib/fakechange.py: Add an errback when sending the fake
6246 change, so we know it didn't work.
6248 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6250 * buildbot/process/step_twisted.py: Delete *.pyc files before
6251 calling trial, so it doesn't catch any old .pyc files whose .py
6252 files have been moved or deleted.
6254 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6255 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6256 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6257 instead of ["twisted.test"], so that the end result is "trial -R
6260 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6261 regular expression to match filenames that should be ignored when
6262 changed. Also add a --revision parameter that specifies the
6263 revision to examine, which is useful for debugging.
6265 2004-06-25 Brian Warner <warner@lothar.com>
6267 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6268 summary of warnings (like DeprecationWarnings), next to the
6271 2004-05-13 Brian Warner <warner@lothar.com>
6273 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6274 we now have a w32 build slave courtesy of Mike Taylor.
6276 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6277 so broken. Fixed a race condition that tripped up interlocked
6278 builds and caused the status to be stuck at "Interlocked" forever.
6279 The twisted buildbot's one interlocked build just so happened to
6280 never hit this case until recently (the feeding builds both pass
6281 before the interlocked build is attempted.. usually it has to wait
6283 (Builder._pong_failed): fix method signature
6285 * setup.py: bump to 0.4.3+ while between releases
6287 2004-04-30 Brian Warner <warner@lothar.com>
6289 * setup.py (version): Releasing buildbot-0.4.3
6291 2004-04-30 Brian Warner <warner@lothar.com>
6293 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6295 * README: update for 0.4.3 release
6297 * NEWS: update for 0.4.3 release
6299 * buildbot/master.py (BuildMaster.__getstate__): make sure
6300 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6302 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6303 .trial as a class attribute, for upgrade from 0.4.2
6305 * buildbot/changes/changes.py (Change.links): add .links for
6308 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6309 .textWatchers and .htmlWatchers at save time, since they are both
6310 volatile, should allow smooth 0.4.2 upgrade
6312 * buildbot/process/step.py (CVS.finishStatus): catch failed
6313 CVS/SVN commands so we can make the status box red
6315 2004-04-29 Brian Warner <warner@lothar.com>
6317 * buildbot/changes/freshcvs.py
6318 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6319 code to do setFilter(), which tells the freshcvs daemon to not
6320 send us stuff that we're not interested in. I will uncomment it
6321 when a new version of CVSToys is available in which setFilter()
6322 actually works, and I get a chance to test it better.
6324 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6326 * buildbot/master.py (Dispatcher): use a registration scheme
6327 instead of hardwired service names
6328 (BuildMaster): keep track of the Dispatcher to support
6331 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6332 PBChangeSource class instead of having it be an undocumented
6333 internal feature of the ChangeMaster. Split out the code into a
6335 * buildbot/changes/pb.py (PBChangeSource): same
6336 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6338 * docs/{factories|sources|steps}.xhtml: document some pieces
6340 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6341 using FCMaildirSource
6342 (f23osx): update OS-X builder to use python2.3, since the slave
6343 was updated to Panther (10.3.3)
6345 2004-03-21 Brian Warner <warner@lothar.com>
6347 * buildbot/process/process_twisted.py: factor out doCheckout, change
6348 to use SVN instead of CVS
6350 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6351 an SVN subclass easier
6352 (BasicSVN): subclass which uses Subversion instead of CVS
6354 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6356 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6358 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6360 2004-02-25 Brian Warner <warner@lothar.com>
6362 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6363 is now either a list (which is passed to spawnProcess directly) or
6364 a string (which gets passed to /bin/sh -c). This removes the useSH
6365 flag and the ArgslistCommand class. Also send status header at the
6366 start and end of each command, instead of having the master-side
6368 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6369 -r'. Update to use list-based arguments.
6370 (SVNFetch): use list-based arguments, use ['dir'] argument to
6372 * buildbot/test/test_steps.py (Commands): match changes
6374 * buildbot/process/step.py (InternalShellCommand.words): handle
6376 (SVN): inherit from CVS, cleanup
6378 * buildbot/status/event.py (Logfile.content): render in HTML, with
6379 stderr in red and headers (like the name of the command we're
6380 about to run) in blue. Add link to a second URL (url + "?text=1")
6381 to get just stdout/stderr in text/plain without markup. There is
6382 still a problem with .entries=None causing a crash, it seems to occur
6383 when the logfile is read before it is finished.
6385 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6386 timeout to the keepalives, and use it to explicitly do a
6387 loseConnection instead of waiting for TCP to notice the loss. This
6388 ought to clear up the silent-lossage problem.
6389 (unsafeTracebacks): pass exception tracebacks back to the master,
6390 makes it much easier to debug problems
6392 2004-02-23 Brian Warner <warner@lothar.com>
6394 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6395 the whole command to /bin/sh instead of execve [Johan Dahlin]
6396 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6397 '-r HEAD' [Johan Dahlin]
6398 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6400 * buildbot/changes/changes.py (Change): add links= argument, add
6401 asHTML method [Johan Dahlin]. Modified to make a bit more
6402 XHTMLish. Still not sure how to best use links= .
6404 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6405 Change.asHTML to display the change, not asText
6407 * buildbot/status/html.py (StatusResourceBuilder): web button to
6410 * buildbot/test/test_run.py: test to actually start a buildmaster
6413 * MANIFEST.in: bring back accidentally-dropped test helper files
6415 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6416 that require cvstoys if it is not installed
6418 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6419 values of "bin/trial" [Dave Peticolas]
6420 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6421 tests passed" when we didn't happen to run any tests
6423 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6424 flunkOnFailure [Johan Dahlin]
6426 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6427 multiple instances of the same Step class by suffixing "_2", etc,
6428 to the name until it is unique. This name needs to be unique
6429 because it is used as a key in the dictionary that tracks build
6431 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6434 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6436 2004-01-14 Brian Warner <warner@lothar.com>
6438 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6439 kicked from a channel, log it
6441 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6442 something over whatever IRC channels the buildmaster is currently
6443 connected to. Added to try and track down a problem in which the
6444 master thinks it is still connected but the IRCd doesn't see it. I
6445 used a styles.Versioned this time, so hopefully users won't have
6446 to rebuild their .tap files this time.
6447 * contrib/debug.glade: add a "Poke IRC" button
6448 * contrib/debugclient.py: same
6450 * setup.py: bump to 0.4.2+ while between releases
6452 2004-01-08 Brian Warner <warner@lothar.com>
6454 * setup.py (version): Releasing buildbot-0.4.2
6456 2004-01-08 Brian Warner <warner@lothar.com>
6458 * NEWS: update for 0.4.2 release
6460 * README: document how to run the tests, now that they all pass
6462 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6464 * buildbot/process/step.py (CVS): add a global_options= argument,
6465 which lets you set CVS global options for the command like "-r"
6466 for read-only checkout, or "-R" to avoid writing in the
6468 * buildbot/slavecommand.py (CVSCommand): same
6470 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6471 testing easier (it is turned off when testing, to avoid the
6474 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6475 to make it easier to test: break generateStepID() out to a
6476 separate function, only update statusbag if it exists.
6477 (ShellCommands): create useful text for dict-based commands too.
6479 * test/*, buildbot/test/*: move unit tests under the buildbot/
6481 * setup.py (packages): install buildbot.test too
6483 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6484 * buildbot/test/test_steps.py: fix it, tests pass now
6486 2004-01-06 Brian Warner <warner@lothar.com>
6488 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6489 freshcvs mail uses a slightly different syntax for new
6490 directories. Update parser to handle either.
6491 * test/test_mailparse.py (Test1.testMsg9): test for same
6493 2003-12-21 Brian Warner <warner@lothar.com>
6495 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6496 'warnOnWarnings' so that lintian errors mark the build orange
6498 2003-12-17 Brian Warner <warner@lothar.com>
6500 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6501 messages emitted by Bonsai, contributed by Stephen Davis.
6503 * test/*: moved all tests to use trial instead of unittest. Some
6504 still fail (test_steps, test_slavecommand, and test_process).
6506 * setup.py (version): bump to 0.4.1+ while between releases
6508 2003-12-09 Brian Warner <warner@lothar.com>
6510 * setup.py (version): Releasing buildbot-0.4.1
6512 2003-12-09 Brian Warner <warner@lothar.com>
6514 * NEWS: update for 0.4.1 release
6516 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6517 freebsd builder code a little bit
6519 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6520 don't try to compare attributes of different classes
6521 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6522 (MaildirSource.messageReceived): fix Change delivery
6524 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6525 into the config file's namespace before loading it, like the
6526 documentation claims it does
6527 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6528 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6529 daemon comes back online
6531 2003-12-08 Brian Warner <warner@lothar.com>
6533 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6534 so the example will work with online=0 as well
6536 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6537 fix the __implements__ line
6539 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6540 class a twisted.application.service.Service, use startService to
6543 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6544 directory fd instead of simple open(). I'm sure this used to work,
6545 but the current version of python refuses to open directories with
6548 2003-12-05 Brian Warner <warner@lothar.com>
6550 * setup.py (version): bump to 0.4.0+ while between releases
6552 2003-12-05 Brian Warner <warner@lothar.com>
6554 * setup.py (version): Releasing buildbot-0.4.0
6556 2003-12-05 Brian Warner <warner@lothar.com>
6558 * docs/examples/glib_master.cfg: replace old sample scripts with
6559 new-style config files
6560 * MANIFEST.in: include .cfg files in distribution tarball
6562 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6563 implement a dummy method to avoid the exception that occurs when
6564 freshcvs sends this to us.
6566 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6567 removed the method, as it broke reconnection. Apparently
6568 stopFactory is called each time the connection attempt fails. Must
6570 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6571 attribute before serialization, since without stopFactory the
6572 reconnect timer may still be active and they aren't serializable.
6574 * test/test_mailparse.py (ParseTest): test with 'self' argument
6576 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6577 argument, as these "functions" are invoked like methods from class
6578 attributes and therefore always get an instance as the first
6581 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6582 message: thanks to Stephen Davis for the catch
6584 2003-12-04 Brian Warner <warner@lothar.com>
6586 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6587 twisted's standard ReconnectingClientFactory. Handles both oldcred
6588 and newcred connections. Also has a bug-workaround for
6589 ReconnectingClientFactory serializing its connector when it
6592 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6593 pbutil. Replace makeApp stuff with proper newcred/mktap
6594 makeService(). Don't serialize Ephemerals on shutdown.
6596 * buildbot/changes/changes.py (ChangeMaster): make it a
6597 MultiService and add the sources as children, to get startService
6598 and stopService for free. This also gets rid of the .running flag.
6600 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6601 new pbutil, turn into a TCPClient at the same time (to get
6602 startService for free). Two variants exist: FreshCVSSourceOldcred
6603 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6604 yet, but when it does, we'll be ready).
6605 (FreshCVSSource.notify): handle paths which are empty after the
6606 prefix is stripped. This only happens when the top-level (prefix)
6607 directory is added, at the very beginning of a Repository's life.
6609 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6610 Now the only reconnecting code is in the factory where it belongs.
6611 (Builder.unsubscribe): unregister the disconnect callback when we
6612 delete the builder on command from the master (i.e. when the
6613 buildmaster is reconfigured and that builder goes away). This
6614 fixes a multiple-delete exception when the status client is shut
6616 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6619 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6620 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6622 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6624 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6625 a list of globs (ugh). The testdir will be searched for files
6626 named *.tests and run the tests in the order specified in each of
6627 those files. This allows for "dependancies" between tests to be
6630 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6631 argument to pass to run_maxq.py, instead of a glob.
6633 2003-10-17 Brian Warner <warner@lothar.com>
6635 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6636 files that live in the sandbox
6638 2003-10-15 Brian Warner <warner@lothar.com>
6640 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6641 spelling error in "docs" count-warnings output
6642 (HLint.start): stupid thinko meant .xhtml files were ignored
6644 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6645 tests now that cReactor is banished to the sandbox
6647 2003-10-10 Brian Warner <warner@lothar.com>
6649 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6650 scheme: now .xhtml are sources and .html are generated
6652 2003-10-08 Brian Warner <warner@lothar.com>
6654 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6655 we were ignoring the 'randomly' parameter.
6657 2003-10-01 Brian Warner <warner@lothar.com>
6659 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6660 posix, to kill sub-children of aborted slavecommands.
6662 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6663 Clean up initialization: lastBuildStatus remains None until the
6664 first build has been completed.
6666 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6667 None as a lastBuildStatus
6668 * buildbot/clients/gtkPanes.py: same
6670 * buildbot/status/client.py (StatusClientService): keep
6671 BuilderStatus objects in self.statusbags . These objects now live
6672 here in the StatusClientService and are referenced by the Builder
6673 object, rather than the other way around.
6674 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6675 * buildbot/process/base.py (Builder): same
6676 * test/test_config.py (ConfigTest.testBuilders): same
6678 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6679 an existing builder, leave the statusbag alone. This will preserve the
6682 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6683 hook. This will probably go away in favor of a class in upcoming
6686 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6687 serviceName from newcred FreshCVSNotifiee setup
6689 2003-09-29 Brian Warner <warner@lothar.com>
6691 * buildbot/process/process_twisted.py: switch to new reactor
6693 * docs/examples/twisted_master.cfg: same
6695 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6697 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6698 botmaster reference instead of the oldapp service lookup
6700 * buildbot/master.py (BuildMaster.__init__): give the
6701 StatusClientService a reference to the botmaster to make it easier to
6704 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6706 * buildbot/status/html.py (Box.td): escape hreffy things so you
6707 can have spaces in things like builder names
6708 (StatusResourceBuilder.body)
6709 (WaterfallStatusResource.body)
6710 (WaterfallStatusResource.body0): same
6712 2003-09-25 Brian Warner <warner@lothar.com>
6714 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6715 rearrange the builder list when adding or removing builders: keep
6716 them in the order the user requested.
6717 * test/test_config.py (ConfigTest.testBuilders): verify it
6719 * contrib/debug.glade: give the debug window a name
6721 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6722 now wait on multiple interlocks. Fix code relating to that.
6723 (Builder.checkInterlocks): same
6724 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6726 * buildbot/master.py (BuildMaster.loadConfig): move from
6727 deprecated pb.BrokerFactory to new pb.PBServerFactory
6728 * test/test_config.py (ConfigTest.testWebPathname): same
6730 * docs/examples/twisted_master.cfg: fix interlock declaration
6732 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6733 Interlocks to their Builders into interlock.py .
6734 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6736 * test/test_config.py (ConfigTest.testInterlocks): validate
6739 * buildbot/process/base.py (Builder.__init__): better comments
6740 * buildbot/process/interlock.py (Interlock.__repr__): same
6741 (Interlock.deactivate): add .active flag, move the code that
6742 attaches/detaches builders into the Interlock
6744 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6746 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6747 tests using the new run_maxq.py script, and reporting failures by
6750 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6751 tests, reporting their success or failure in a buildbot-friendly
6754 2003-09-24 Brian Warner <warner@lothar.com>
6756 * docs/examples/twisted_master.cfg: example of a new-style config
6757 file. This lives in the buildmaster base directory as
6760 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6761 button to make the master re-read its config file
6763 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6764 buildmaster configuration from a file. This file can be re-read
6765 later, and the buildmaster will update itself to match the new
6766 desired configuration. Also use new Twisted Application class.
6767 * test/Makefile, test/test_config.py: unit tests for same
6769 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6770 FreshCVSSources comparable, to support reload.
6771 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6773 * buildbot/process/base.py (Builder): make them comparable, make
6774 Interlocks easier to attach, to support reload. Handle
6775 re-attachment of remote slaves.
6776 * buildbot/process/interlock.py (Interlock): same
6778 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6779 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6780 buildmaster taps are now constructed with mktap.
6781 * buildbot/status/client.py (StatusClientService): same
6783 * buildbot/status/words.py: move to new Services, add support to
6784 connect to multiple networks, add reload support, allow nickname
6785 to be configured on a per-network basis
6787 2003-09-20 Brian Warner <warner@lothar.com>
6789 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6790 the freebsd builder, now that the machine has been upgraded and no
6791 longer has python2.2
6793 * setup.py (version): bump to 0.3.5+ while between releases
6795 2003-09-19 Brian Warner <warner@lothar.com>
6797 * setup.py (version): Releasing buildbot-0.3.5
6799 2003-09-19 Brian Warner <warner@lothar.com>
6801 * NEWS: add post-0.3.4 notes
6803 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6805 * MANIFEST.in: add contrib/*
6807 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6808 use a remote root now: cvs.twistedmatrix.com
6810 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6812 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6813 compatibility with old servers
6814 (FreshCVSSource.start): and provide a way to use it
6815 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6817 * docs/examples/twisted_master.py (twisted_app): update to new
6819 (twisted_app): listen on new ~buildbot socket
6820 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6822 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6823 to reduce cvs bandwidth (update instead of full checkout)
6825 2003-09-11 Brian Warner <warner@lothar.com>
6827 * contrib/fakechange.py: demo how to connect to the changemaster
6828 port. You can use this technique to submit changes to the
6829 buildmaster from source control systems that offer a hook to run a
6830 script when changes are committed.
6832 * contrib/debugclient.py: tool to connect to the debug port. You
6833 can use it to force builds, submit fake changes, and wiggle the
6836 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6837 'Dispatcher' realm to handle all the different kinds of
6838 connections and Perspectives: buildslaves, the changemaster port,
6839 the debug port, and the status client port. NewCredPerspectives
6840 now have .attached/.detached methods called with the remote 'mind'
6841 reference, much like old perspectives did. All the pb.Services
6842 turned into ordinary app.ApplicationServices .
6843 (DebugService): went away, DebugPerspectives are now created
6844 directly by the Dispatcher.
6845 (makeApp): changed interface a little bit
6847 * buildbot/changes/changes.py: newcred
6848 * buildbot/status/client.py: newcred
6850 * buildbot/clients/base.py: newcred client side changes
6851 * buildbot/bot.py: ditto
6853 * docs/examples/glib_master.py: handle new makeApp() interface
6854 * docs/examples/twisted_master.py: ditto
6856 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6857 base newcred Perspectives on. This should go away once Twisted
6858 itself provides something sensible.
6861 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6863 * contrib/svn_buildbot.py: A program that you can call from your
6864 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6865 when a change in an SVN repository has happened. See the top of
6866 the file for some minimal usage info.
6868 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6870 * buildbot/slavecommand.py (ArglistCommand): Add new
6871 ArglistCommand that takes an argument list rather than a string as
6872 a parameter. Using a st.split() for argv is very bad.
6874 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6875 update to a particular revision rather than always checking out
6876 (still not very smart about it, there may be cases where the
6877 checkout becomes inconsistent).
6879 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6881 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6882 SVN fetch support. It can checkout (not update!) a specified
6883 revision from a specified repository to a specified directory.
6885 * buildbot/status/progress.py (Expectations.update): Fix an
6886 obvious bug (apparently created by the change described in the
6887 previous ChangeLog message) by moving a check to *after* the
6888 variable it checks is defined.
6891 2003-09-08 Brian Warner <warner@lothar.com>
6893 * buildbot/status/progress.py (Expectations.update): hack to catch
6894 an exception TTimo sees: sometimes the update() method seems to
6895 get called before the step has actually finished, so the .stopTime
6896 is not set, so no totalTime() is available and we average None
6897 with the previous value. Catch this and just don't update the
6898 metrics, and emit a log message.
6900 2003-08-24 Brian Warner <warner@lothar.com>
6902 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6903 parameter to set copydir='original' in CVS commands.
6905 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6907 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6908 which tells the command to maintain a separate original-source CVS
6909 workspace. For each build, this workspace will be updated, then
6910 the tree copied into a new workdir. This reduces CVS bandwidth
6911 (from a full checkout to a mere update) while doubling the local
6912 disk usage (to keep two copies of the tree).
6914 2003-08-21 Brian Warner <warner@lothar.com>
6916 * buildbot/status/event.py (Logfile.addEntry): if the master web
6917 server dies while we're serving a page, request.write raises
6918 pb.DeadReferenceError . Catch this and treat it like a
6919 notifyFinish event by dropping the request.
6921 2003-08-18 Brian Warner <warner@lothar.com>
6923 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6924 (instead of blowing up) if a force-build command is given without
6927 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6928 don't blow up if there aren't yet any Changes in the list
6930 2003-08-02 Brian Warner <warner@lothar.com>
6932 * buildbot/bot.py (updateApplication): don't set the .tap name,
6933 since we shouldn't assume we own the whole .tap file
6935 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6936 'mktap buildbot' (without a subcommand) better
6938 2003-07-29 Brian Warner <warner@lothar.com>
6940 * buildbot/status/words.py
6941 (IrcStatusFactory.clientConnectionLost): when we lose the
6942 connection to the IRC server, schedule a reconnection attempt.
6944 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6945 use shutil.rmtree instead of forking off an "rm -rf" command.
6946 rmtree may take a while and will block until it finishes, so we
6947 use "rm -rf" if available.
6949 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6950 freebsd buildslave badly
6952 * setup.py (version): bump to 0.3.4+ while between releases
6954 2003-07-28 Brian Warner <warner@lothar.com>
6956 * setup.py (version): Releasing buildbot-0.3.4
6958 2003-07-28 Brian Warner <warner@lothar.com>
6960 * NEWS: update in preparation for release
6962 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6963 process.signalProcess instead of os.kill, to improve w32
6966 * docs/examples/twisted_master.py (twisted_app): turn off
6967 win32eventreactor: the tests hang the buildslave badly
6969 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6970 failed builds, since usually the failures are consistent
6972 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6973 add compileOpts/compileOpts2 to reactors build
6975 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6976 (twisted_app): use both default and win32eventreactor on w32 build.
6977 Use both default and kqreactor on freebsd build.
6979 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6980 add compileOpts2, which is put after the build_ext argument. w32
6981 needs "-c mingw32" here.
6983 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6984 touch .acqpath, it goes away in recent Twisted releases
6986 * docs/examples/twisted_master.py (twisted_app): use "python" for
6987 the w32 buildslave, not "python2.2"
6989 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6990 the directory exists.. should hush an exception under w32
6992 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6993 ProcessTerminated -provided values for signal and exitCode rather
6994 than parsing the unix status code directly. This should remove one
6995 more roadblock for a w32-hosted buildslave.
6997 * test/test_mailparse.py: add test cases for Syncmail parser
6999 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7000 temporary compatibility import. Note! Start importing
7001 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7003 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7005 2003-07-27 Brian Warner <warner@lothar.com>
7007 * NEWS: started adding new features
7009 * buildbot/changes/mail.py: start work on Syncmail parser, move
7010 mail sources into their own file
7012 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7013 as implementing IChangeSource
7014 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7016 * buildbot/interfaces.py: define the IChangeSource interface
7018 2003-07-26 Brian Warner <warner@lothar.com>
7020 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7022 2003-06-25 Brian Warner <warner@lothar.com>
7024 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7027 2003-06-17 Brian Warner <warner@lothar.com>
7029 * buildbot/status/words.py: clean up method usage to avoid error
7030 in silly IRC command
7031 (IrcStatusBot.emit_status): round off seconds display
7033 * buildbot/process/base.py (Build): delete the timer when saving
7034 to the .tap file, and restore it (if it should still be running)
7035 upon restore. This should fix the "next build in -34 seconds"
7036 messages that result when the master is restarted while builds are
7037 sitting in the .waiting slot. If the time for the build has
7038 already passed, start it very soon (in 1 second).
7040 * buildbot/status/words.py: more silly commands
7042 * README (REQUIREMENTS): add URLs to all required software
7044 * buildbot/status/words.py ('last'): mention results of, and time
7047 2003-05-28 Brian Warner <warner@lothar.com>
7049 * buildbot/status/words.py: add 'last' command
7050 (IrcStatusBot.emit_status): add current-small text to 'status' output
7052 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7053 (twisted_app): remove spaces from OS-X builder name
7055 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7056 * buildbot/status/words.py: IRC bot should actually be useful now
7058 2003-05-23 Brian Warner <warner@lothar.com>
7060 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7061 "slave information" from $(slavedir)/info/* . These files are
7062 maintained by the slave administrator, and describe the
7063 machine/environment that is hosting the slave. Information from
7064 them is put into the "Builder" HTML page. Still need to establish
7065 a set of well-known filenames and meanings for this data: at the
7066 moment, *all* info/* files are sent to the master, but only
7067 'admin' and 'host' are used on that end.
7068 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7069 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7070 * buildbot/master.py (BotPerspective.got_info): ditto
7072 2003-05-22 Brian Warner <warner@lothar.com>
7074 * setup.py (version): bump version to 0.3.3+ while between releases
7076 2003-05-21 Brian Warner <warner@lothar.com>
7078 * setup.py: Releasing buildbot-0.3.3
7080 2003-05-21 Brian Warner <warner@lothar.com>
7082 * NEWS: 0.3.3 news items
7084 * README: describe --keepalive and life behind a NAT box
7086 * buildbot/bot.py (Bot.connected): implement application-level
7087 keepalives to deal with NAT timeouts, turn them on with
7088 --keepalive option or when SO_KEEPALIVE doesn't work.
7090 * buildbot/master.py (BotPerspective): accept keepalives silently
7092 * buildbot/process/base.py (Build.buildException): CopiedFailures
7093 don't carry as much information as local ones, so don't try to
7094 create a big HTMLized version of them.
7096 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7097 log file when step fails due to an exception, such as when the slave
7100 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7101 --testmodule argument instead of grepping for test-case-name tags
7102 ourselves. Remove FindUnitTests code.
7103 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7105 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7107 2003-05-16 Brian Warner <warner@lothar.com>
7109 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7110 argument to allow things like CFLAGS=-O0 to be passed without relying
7111 upon /bin/sh processing on the slave.
7113 * buildbot/process/step.py (InternalShellCommand.start): send
7115 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7116 'split' instead of letting /bin/sh do it. This should also remove
7117 the need for /bin/sh on the buildslave, making it more likely to
7120 * buildbot/status/html.py: html-escape text in blamelist.
7121 Add "force build" button to the Builder page.
7123 * buildbot/process/step_twisted.py (countFailedTests): look at
7124 last 1000 characters for status line, as import errors can put it
7125 before the -200 point.
7127 2003-05-15 Brian Warner <warner@lothar.com>
7129 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7131 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7132 make 'clobber' a parameter, so it is possible to have builds which
7133 do full tests but do a cvs update instead of hammering the CVS
7134 server with a full checkout each build
7136 * buildbot/process/step.py (InternalShellCommand): bump default
7137 timeout to 20 minutes
7139 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7140 the master to trigger a build. Run it via manhole.
7142 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7143 allow slaves to trigger any build that they host, to make life
7144 easier for slave admins who are testing out new build processes
7146 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7147 don't flunk cReactor or qtreactor on failure, since they fail alot
7148 these days. Do warnOnFailure instead.
7150 * buildbot/process/base.py: change Builder.buildable from a list
7151 into a single slot. When we don't have a slave, new builds (once
7152 they make it past the timeout) are now merged into an existing
7153 buildable one instead of being queued. With this change, a slave
7154 which has been away for a while doesn't get pounded with all the
7155 builds it missed, but instead just does a single build.
7157 2003-05-07 Brian Warner <warner@lothar.com>
7159 * setup.py (version): bump version to 0.3.2+ while between releases
7161 2003-05-07 Brian Warner <warner@lothar.com>
7163 * setup.py: Releasing buildbot-0.3.2
7165 2003-05-07 Brian Warner <warner@lothar.com>
7167 * setup.py: fix major packaging error: include subdirectories!
7169 * NEWS: add changes since last release
7171 * README (REQUIREMENTS): update twisted/python dependencies
7173 * buildbot/status/builder.py (Builder.startBuild): change
7174 BuildProcess API: now they should call startBuild/finishBuild
7175 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7176 keeping a list of builds in the statusbag, to support other kinds of
7178 (Builder.addClient): send current-activity-small to new clients
7179 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7182 * buildbot/status/client.py: drop RemoteReferences at shutdown
7184 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7186 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7187 more debug messages for remote status client
7189 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7190 (.stepFailed): only fire the Deferred once, even if both
7191 stepComplete and stepFailed are called. I think this can happen if
7192 an exception occurs at a weird time.
7194 * buildbot/status/words.py: work-in-progress: IRC status delivery
7196 2003-05-05 Brian Warner <warner@lothar.com>
7198 * docs/examples/twisted_master.py (twisted_app): hush internal
7199 python2.3 distutils deprecation warnings
7200 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7201 add compileOpts= argument which inserts extra args before the
7202 "setup.py build_ext" command. This can be used to give -Wignore
7203 warnings, to hush some internal python-2.3 deprecation messages.
7205 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7206 the ['twisted.test'] default test case to make it easier to change
7209 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7210 * buildbot/clients/gtkPanes.py: ditto
7212 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7213 arg to collapse RunUnitTestsRandomly into RunUnitTests
7214 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7215 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7217 * buildbot/status/html.py (StatusResource): shuffle Resources
7218 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7219 would serve the waterfall display, but the internal links were
7220 only valid on the trailing-slash version. The correct behavior is
7221 for the non-slashed one to serve a Redirect to the slashed one.
7222 This only shows up when the buildbot page is hanging off another
7223 server, like a Twisted-Web distributed server.
7225 * buildbot/status/event.py (Event, RemoteEvent): make Events
7226 pb.Cacheable, with RemoteEvent as the cached version. This removes
7227 a lot of explicit send-an-update code.
7228 * buildbot/status/builder.py (Builder): remove send-update code
7229 * buildbot/status/client.py (ClientBuilder): remove send-update
7230 code, and log errors that occur during callRemote (mostly to catch
7231 InsecureJelly exceptions)
7233 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7234 run Lore with the same python used in the rest of the build
7236 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7238 * buildbot/process/step_twisted.py (HLint): accept 'python'
7239 argument. Catch rc!=0 and mark the step as failed. This marks the
7240 build orange ("has warnings").
7241 (RunUnitTestsJelly): move out to step_twisted2.py
7243 * buildbot/util.py (ignoreStaleRefs): add utility function
7245 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7246 don't fake ETA object, it's too hard to get right
7248 2003-05-02 Brian Warner <warner@lothar.com>
7250 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7252 2003-05-01 Brian Warner <warner@lothar.com>
7254 * buildbot/status/html.py (StatusResource.body): oops, I was
7255 missing a <tr>, causing the waterfall page to be misrendered in
7256 everything except Galeon.
7258 2003-04-29 Brian Warner <warner@lothar.com>
7260 * docs/examples/twisted_master.py: make debuild use python-2.2
7261 explicitly, now that Twisted stopped supporting 2.1
7263 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7264 handle tuple results too. I keep forgetting this, which suggests
7265 it needs to be rethought.
7267 * setup.py (setup): bump version to 0.3.1+ while between releases
7269 2003-04-29 Brian Warner <warner@lothar.com>
7271 * setup.py: Releasing buildbot-0.3.1
7273 2003-04-29 Brian Warner <warner@lothar.com>
7275 * README (SUPPORT): add plea to send questions to the mailing list
7277 * NEWS, MANIFEST.in: add description of recent changes
7279 * docs/examples/twisted_master.py: add the code used to create the
7280 Twisted buildmaster, with passwords and such removed out to a
7283 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7284 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7285 buildmasters to not require CVSToys be installed.
7286 * README, docs/examples/glib_master: update to match the change
7288 * buildbot/clients/base.py, buildbot/bot.py,
7289 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7290 ReconnectingPB from CVSToys distribution to remove CVSToys
7291 dependency for build slaves and status clients. Buildmasters which
7292 use FreshCVSSources still require cvstoys be installed, of course.
7294 2003-04-25 Brian Warner <warner@lothar.com>
7296 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7297 runTestsRandomly arg to turn on trial -z
7299 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7300 experimental code to use trial's machine-parseable output to get
7301 more detailed test results. Still has some major issues.
7302 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7305 * buildbot/status/builder.py (Builder.setCurrentBuild):
7306 anticipating moving build history into statusbag, not used yet
7308 * buildbot/status/tests.py: code to centralize test results,
7309 doesn't work quite yet
7311 * buildbot/status/event.py (Event): use hasattr("setName") instead
7312 of isinstance for now.. need better long-term solution
7314 * buildbot/status/html.py: Remove old imports
7316 2003-04-24 Brian Warner <warner@lothar.com>
7318 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7319 ignore changes under doc/fun/ and sandbox/
7321 * buildbot/process/step_twisted.py: update pushEvent and friends.
7323 * buildbot/status/html.py (Box.td): replace event.buildername with
7324 event.parent.getSwappableName(). Needs more thought.
7326 * buildbot/status/builder.py (Builder): Replace pushEvent and
7327 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7328 Tell events they are being pruned with event.delete().
7330 * buildbot/process/base.py (Build): Remove Builder status-handling
7331 methods. s/pushEvent/setCurrentActivity/.
7333 * buildbot/process/step.py (BuildStep): clean up status delivery.
7334 Gouse builder.statusbag methods instead of intermediate builder
7335 methods. s/updateLastEvent/updateCurrentActivity/.
7336 s/finalizeLastEvent/finishCurrentActivity/. Use
7337 addFileToCurrentActivity for summaryFunction.
7339 * buildbot/status/event.py (Logfile): put data in a Swappable when
7341 (Event): add more setter methods. Remove .buildername, use .parent
7342 and getSwappableName instead (needs more thought).
7344 * buildbot/util.py (Swappable):
7345 * test/test_swap.py: don't bother setting filename at __init__
7346 time, do it later. Change setFilename args to take parent first,
7347 since it provides the most significant part of the filename.
7349 2003-04-23 Brian Warner <warner@lothar.com>
7351 * buildbot/status/event.py (Logfile.addEntry): append to previous
7354 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7355 anticipating Swappable
7356 (InternalShellCommand.remoteUpdate): split out various log-adding
7357 methods so subclasses can snarf stdout separately
7359 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7360 in anticipation of Swappable build logs
7361 (Builder.testsFinished): anticipating TestResults, still disabled
7363 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7366 * buildbot/status/event.py (Logfile): add (disabled) support for
7367 Swappable, not ready for use yet
7369 * buildbot/util.py (Swappable): object which is swapped out to
7370 disk after some period of no use.
7371 * test/test_swap.py: test buildbot.utils.Swappable
7373 2003-04-14 Brian Warner <warner@lothar.com>
7375 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7376 periodic-build timer. Set the .periodicBuildTime on a builder
7377 instance to some number of seconds to activate it.
7379 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7381 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7382 a way that survives result tuples
7384 2003-04-12 Brian Warner <warner@lothar.com>
7386 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7387 return a dict instead of a tuple: allow summarizers to provide
7388 multiple summaries if they want
7389 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7390 (debuildSummarizer): summarize lintian warnings/errors
7392 2003-04-10 Brian Warner <warner@lothar.com>
7394 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7396 2003-04-09 Brian Warner <warner@lothar.com>
7398 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7399 empty summaries: happens when the tests fail so hard they don't emit
7400 a parseable summary line.
7402 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7403 Allow summaryFunction to return None to indicate no summary should
7406 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7407 writing to stale HTTP requests: notice when they disconnect and
7408 remove the request from the list. Also add CacheToFile from
7409 moshez, will be used later.
7411 2003-04-08 Brian Warner <warner@lothar.com>
7413 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7414 should be an int, not a list of strings
7416 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7417 if we weren't actually connected
7419 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7420 to show the tail end of the trial text output
7422 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7423 hook to summarize the results of a ShellCommand
7425 2003-04-07 Brian Warner <warner@lothar.com>
7427 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7428 twisted test suite code into a single class.
7429 * buildbot/process/process_twisted.py: same
7431 2003-04-04 Brian Warner <warner@lothar.com>
7433 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7435 * README (SLAVE): document use of mktap to create slave .tap file
7436 (REQUIREMENTS): describe dependencies
7438 * buildbot/bb_tap.py, buildbot/plugins.tml:
7439 * buildbot/bot.py (updateApplication): Add mktap support for creating
7440 buildslave .tap files
7442 2003-03-28 Brian Warner <warner@lothar.com>
7444 * buildbot/process/step.py (InternalShellCommand.finished): handle
7445 new tuple result values (fix embarrasing bug that appeared during
7448 2003-03-27 Brian Warner <warner@lothar.com>
7450 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7453 2003-03-25 Brian Warner <warner@lothar.com>
7455 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7456 to overall build status
7457 * buildbot/clients/base.py (Builder): improve event printing
7458 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7459 instead of generic ShellCommand
7460 (Build): Add .stopBuild, use it when slave is detached
7462 * buildbot/process/step.py (Configure,Test): give the steps their
7463 own names and status strings
7465 * buildbot/status/html.py (StatusResource): add "show" argument,
7466 lets you limit the set of Builders being displayed.
7468 2003-03-20 Brian Warner <warner@lothar.com>
7470 * buildbot/process/basic.py: removed
7472 2003-03-19 Brian Warner <warner@lothar.com>
7474 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7475 turn off process-docs by default
7477 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7478 when displaying build information without anything in allBuilds[]
7480 * buildbot/bot.py (makeApp): really take password from sys.argv
7482 2003-03-18 Brian Warner <warner@lothar.com>
7484 * buildbot/bot.py (buildApp): take password from sys.argv
7486 * README: replace with more useful text
7488 * setup.py: add a real one
7489 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7491 * docs/PyCon-2003/: added sources for PyCon paper.
7493 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7494 now Build objects control the process and Builder only handles
7495 slave stuff and distribution of changes/status. A new BuildFactory
7496 class creates Build objects on demand.
7498 Created ConfigurableBuild which takes a list of steps to run. This
7499 makes it a lot easier to set up a new kind of build and moves us
7500 closer to being able to configure a build from a web page.
7502 * buildbot/process/step_twisted.py, process_twisted.py: move to
7503 new model. A lot of code went away.
7505 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7506 send lots of empty progress messages to the client.
7508 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7510 2003-02-20 Brian Warner <warner@lothar.com>
7512 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7514 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7515 Twisted bug that prevented non-pty processes from working just got
7516 fixed, and the bug that leaks ptys is still being investigated.
7518 * buildbot/process/step.py (CVS): send timeout arg to slave
7520 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7521 builders coming and going
7522 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7523 from CVSToys, handle lost-buildmaster
7525 * buildbot/status/client.py (StatusClientService.removeBuilder):
7526 Clean up status client protocol: send builders (with references)
7527 as they are created, rather than sending a list and requiring the
7528 client to figure out which ones are new.
7529 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7530 attempts to force a build on an unknown builder
7532 2003-02-19 Brian Warner <warner@lothar.com>
7534 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7535 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7536 Twisted stops leaking them.
7537 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7538 builder goes to an idle state.
7540 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7541 I figure out why CVS commands hang without them, and/or I fix the
7542 hung-command timeout
7544 2003-02-16 Brian Warner <warner@lothar.com>
7546 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7547 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7548 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7549 GenerateDocs now that they are prefixed with WARNING:.
7551 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7552 use manual href target instead of request.childLink
7554 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7555 display every second, but update the ETA every 5 seconds (or
7556 whenever) as remote_progress messages arrive.
7559 2003-02-12 Brian Warner <warner@lothar.com>
7561 * *: import current sources from home CVS repository
7565 # add-log-time-format: add-log-iso8601-time-string