1 2007-07-27 Brian Warner <warner@lothar.com>
3 * docs/buildbot.texinfo (Getting Source Code Changes): move all
4 the changesource types up a level, removing the one-entry menu in
7 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
8 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
9 instances instead of tuples. Closes #63.
10 * buildbot/slave/__init__.py (BuildSlave): define marker class
11 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
12 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
13 * buildbot/test/test_*.py: update tests to match
14 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
15 the c['bots'] backwards-compatibility handler works
17 2007-07-26 Brian Warner <warner@lothar.com>
19 * buildbot/changes/hgbuildbot.py (hook): add an in-process
20 Mercurial change-sending hook, contributed by Frederic Leroy.
21 Thanks! Addresses #50.
22 * docs/buildbot.texinfo (MercurialHook): document it
24 * buildbot/changes/hgbuildbot.py: change the way imports are done,
25 to make it compatible with at least hg-0.9.1 and the current 0.9.4
27 2007-07-17 Brian Warner <warner@lothar.com>
29 * buildbot/process/buildstep.py (BuildStep.getLog): add a
30 convenience method to retrieve a log added with
31 addLog()/addCompleteLog()/etc or logfiles= . I should have added
34 2007-07-03 Brian Warner <warner@lothar.com>
36 * buildbot/slave/commands.py (ShellCommand._startCommand): when
37 logging the environment variables, put one variable on each line,
38 rather than having one really long line with all of them. This
39 should make them a bit more readable and not trigger the
40 horizontal scrollbar (when viewing it in a web browser) quite so
41 much. Thanks to Albert Hofkamp for the patch.
43 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
44 WithProperties instance. Thanks to Axel Hecht for the patch.
46 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
47 * docs/buildbot.texinfo (Build Properties): document it
48 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
49 workdir if it didn't already exist.
51 * docs/buildbot.texinfo (Scheduler Types): correct the description
52 of Dependent schedulers. Thanks to Greg Ward for the patch.
54 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
55 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
56 the patch. Closes #49.
58 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
59 0700 before removing it, to deal with situations where a build will
60 leave files around without write permissions and the 'copy' or
61 'clobber' VC checkout modes need to blow away the tree first.
62 Thanks to Steve Milner for the suggestion and the patch (which I
63 mangled horribly). Closes #29.
64 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
67 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
68 an allowReconnect= argument to let callers control whether they
69 want this don't-let-it-reconnect behavior, since some tests care.
70 Factor out the .continueTrying=False lines from those callers.
71 * buildbot/test/test_slaves.py: same
72 * buildbot/test/test_run.py: same
74 2007-07-02 Brian Warner <warner@lothar.com>
76 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
77 slave has been disappeared, don't let it reconnect. This was
78 causing an intermittent failure in test_slaves.py, when the slave
79 that was supposed to be gone managed to come back by the end of
80 the test and affect the count.
81 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
83 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
84 diagnostic messages to track down this problem
85 (Builder.startBuild): same
87 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
88 the slave randomly rather than always taking the first one. Thanks
89 to Pike for the patch. Closes #36.
90 * buildbot/test/test_slaves.py: match the change. to avoid huge
91 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
92 enables/disables the round-robin-ness (enabled by default), and
93 some unit tests disable it.
94 * docs/buildbot.texinfo (Buildmaster Architecture): document it
96 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
97 argument to 'buildmaster_host', to make it more obvious that this
98 points to the buildmaster. Thanks to Bob Proulx for the
100 * buildbot/scripts/runner.py (slaveTAC): same
101 * buildbot/test/test_runner.py (Create.testSlave): match the change
103 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
106 2007-06-17 Brian Warner <warner@lothar.com>
108 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
109 we can round-trip all of our current step classes by calling
110 getStepFactory() and using the results to make a clone of the
113 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
116 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
117 the config file, we're moving to using actual instances instead of
118 the (class, kwargs) 'step specification' tuples. BuildFactory
119 still keeps a list of tuples internally, but when real instances
120 are passed in to addStep(), they are asked for their class and
121 kwargs using the new BuildStep.getStepFactory method. BuildFactory
122 accepts both instances and the tuple form, and converts instances
123 to the tuple form, but the instance form is preferred because it
124 gives the Steps a chance to do argument validation. Closes: #11.
126 * buildbot/process/buildstep.py (BuildStep.__init__): record the
127 factory information necessary to implement getStepFactory. The
128 addFactoryArguments() method can be used to include arguments that
129 aren't passed to the BuildStep base class constructor.
130 (BuildStep.setBuild):
131 (BuildStep.setDefaultWorkdir): new methods to take parameters that
132 are needed for live BuildSteps but not to construct the specification
133 tuples that are stashed in the factory.
135 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
136 'workdir' into new BuildSteps by using methods instead of
137 arguments. This makes the constructor for BuildSteps a lot
140 * buildbot/steps/*.py: update to match this change. Basically this
141 means adding calls to addFactoryArguments() in the __init__
142 methods to capture the arguments that aren't passed through to the
144 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
145 the new workdir (if any) into the RemoteShellCommands arguments.
146 * buildbot/steps/source.py: allow workdir= to be optional,
147 implement setDefaultWorkdir() since we don't inherit from
148 (CVS): finally remove old clobber=/export=/copydir= arguments,
149 in favor of the mode= argument that's been around forever now.
150 * buildbot/steps/transfer.py: remove build= argument
152 * buildbot/test/*.py: update to match, generally by turning all
153 build= arguments into subsequent calls to s.setBuild()
154 * buildbot/test/test_config.py (Factories): verify that we can
155 use either BuildStep instances or class/kwarg tuples in both
156 BuildFactory.addStep and BuildFactory.__init__
158 * docs/buildbot.texinfo (Build Steps): document the new approach,
159 mention compatibility with the old approach, update all examples
160 to use the new style.
162 2007-06-16 Brian Warner <warner@lothar.com>
164 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
165 the LoopingCall, just eat the failure so that we'll poll again
166 next time. This should allow us to tolerate (e.g.) sf.net SVN
167 failures more gracefully. Many thanks to Dustin Mitchell for the
170 2007-05-17 Brian Warner <warner@lothar.com>
172 * buildbot/status/words.py: refactor the IRC status bot into
173 separate 'Contact' and 'Channel' classes. The base Contact class
174 contains the interaction code: commands and responses. The
175 IRCContact subclass (and IrcStatusBot 'Channel') handle the
176 IRC-specific aspects. The plan is to write other subclasses for
177 other IM protocols like AIM and Jabber.
179 2007-04-16 Brian Warner <warner@lothar.com>
181 * CREDITS: update list of contributors. Thank you all!
183 2007-04-13 Brian Warner <warner@lothar.com>
185 * buildbot/status/mail.py (MailNotifier): add the project name to
186 the subject line and message body, to make it easier to
187 distinguish email coming from different buildmasters. Thanks to
188 Benoit Sigoure for the patch.
189 * buildbot/test/test_status.py (Mail): update to match
191 2007-03-24 Brian Warner <warner@lothar.com>
193 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
194 avoid text-conversion problems between DOS/windows and unix.
195 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
197 2007-03-03 Brian Warner <warner@lothar.com>
199 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
200 warning about the use of Waterfall here
202 2007-03-01 Brian Warner <warner@lothar.com>
204 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
206 2007-02-28 Brian Warner <warner@lothar.com>
208 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
209 Lamb to use a more optimal form of 'p4 changes', to reduce server
210 load. He reports that this optimization was added to p4d release
211 2005.2, but it should work in all versions. Closes #27.
212 * buildbot/test/test_p4poller.py: match it
214 2007-02-27 Brian Warner <warner@lothar.com>
216 * buildbot/status/web/*.py: move all web status stuff into a
217 separate directory, in anticipation of splitting it into smaller
218 pieces and adding more files. html.py was getting way too big.
219 * buildbot/status/classic.css: move it too
220 * setup.py: add the new sub-package
221 * buildbot/test/test_web.py: match the changes
222 * MANIFEST.in: handle the move of classic.css
224 2007-02-07 Brian Warner <warner@lothar.com>
226 * contrib/OS-X/*: add some launchd .plist files for automatically
227 starting a buildmaster or buildslave under OS-X (10.4 or later).
228 Thanks to Mark Pauley for these.
230 2007-02-06 Brian Warner <warner@lothar.com>
232 * docs/buildbot.texinfo (Requirements): update requirements to
233 stop claiming compatibility with python-2.2 or twisted-1.3.x .
235 * README: mention python-2.5 and twisted-2.5 compatibility
237 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
239 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
241 * buildbot/status/builder.py: same, by requiring cStringIO
242 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
243 * buildbot/test/test_vc.py: same
244 * buildbot/test/test_web.py:
245 * buildbot/test/test_steps.py: same, remove unused import
247 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
250 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
251 see any Builders that don't have Schedulers to drive them
253 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
254 attributes this uses went away
256 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
257 dialog, to allow you to reset the buildmaster and force
258 connect/disconnect. Correctly handle losing the buildmaster
259 connection (by switching the display to the hexnut, at which point
260 you can use the 'Connect' menu item to reconnect).
262 * buildbot/steps/source.py (Source.start): if we're using a patch,
263 add it as a LogFile to the checkout/update step. This will turn
264 into a link on the waterfall page.
266 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
267 option, to take the patch from a pre-made file rather than
268 generating it from the local tree. Thanks to Robert Helmer for the
269 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
270 * buildbot/scripts/runner.py (TryOptions): add --diff,
271 --patchlevel, and --baserev options
272 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
273 as None, meaning HEAD.
274 * buildbot/sourcestamp.py (SourceStamp): update docstring to
275 indicate that baserev=None means HEAD
276 * docs/buildbot.texinfo (try --diff): document it
278 * buildbot/test/test_steps.py (BuildStep): remove use of
279 reactor.iterate(), although the technique I replaced it with is a
280 gross polling hack that must be cleaned up properly some day. This
281 was the last use of reactor.iterate in the entire tree, yay.
283 2007-02-05 Brian Warner <warner@lothar.com>
285 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
286 is one of the three known values, otherwise we emit some confusing
287 messages later on. Thanks to Grig Gheorghiu for the catch.
289 2007-01-30 Brian Warner <warner@lothar.com>
291 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
292 Hearsum contributed a patch to let BonsaiPoller work with results
293 that contain non-ascii characters. Closes SF#1632641.
295 2007-01-27 Brian Warner <warner@lothar.com>
297 * Makefile (release): produce both .tar.gz and .zip source bundles.
300 2007-01-23 Brian Warner <warner@lothar.com>
302 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
303 * buildbot/changes/monotone.py: same
305 * buildbot/changes/maildir.py: combine several files into one,
306 clean up maildir.py to use Services properly.
307 * buildbot/changes/maildirtwisted.py: remove
308 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
310 * buildbot/changes/mail.py: match the change
311 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
312 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
314 * buildbot/slave/commands.py (command_version): bump to "2.3" to
315 indicate that the buildslave knows about the 'bzr' command
317 2007-01-22 Brian Warner <warner@lothar.com>
319 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
320 'with', it will become a reserved work in python2.6 .
322 * contrib/bb_applet.py: add a simple gnome-panel applet, to
323 display a terse summary of buildbot status.
324 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
325 some icons, small versions of the Blender object that lives in
326 docs/images/icon.blend
328 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
329 * buildbot/slave/commands.py (Bzr): same
330 * buildbot/scripts/tryclient.py (BzrExtractor): same
331 (SourceStampExtractor.dovc): modify this to allow non-zero exit
332 status, since 'bzr diff' does that
333 * buildbot/test/test_vc.py (Bzr): same
334 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
338 2007-01-20 Brian Warner <warner@lothar.com>
340 * contrib/darcs_buildbot.py: tidy up the progress messages
342 2007-01-17 Brian Warner <warner@lothar.com>
344 * contrib/darcs_buildbot.py: enhance to handle multiple patches
345 being pushed at a time. This keeps state in the repository in a
346 small file named .darcs_buildbot-lastchange, but that shouldn't
347 interfere with normal repository operations. Fixes SF#1534049.
348 * buildbot/clients/sendchange.py (Sender): make a single Sender
349 capable of sending Changes with different usernames.
351 2006-12-11 Brian Warner <warner@lothar.com>
353 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
354 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
355 buildbot.changes.mail a long time ago, but I forgot to add the
356 DeprecationWarning until now.
358 * buildbot/process/maxq.py: remove this, the functionality now
359 lives in buildbot.steps.maxq
361 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
362 * buildbot/clients/gtkPanes.py: remove unused import
364 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
365 that was meant to provide a special Reporter to run inside trial
366 and give the buildslave lots of machine-readable status. We never
367 finished this project.
369 * buildbot/changes/bonsaipoller.py: remove unused imports
370 * buildbot/changes/svnpoller.py: same
371 * buildbot/process/builder.py: same
372 * buildbot/process/buildstep.py: same
373 * buildbot/slave/bot.py: hush pyflakes warning
374 * buildbot/status/tests.py: remove unused imports
375 * buildbot/status/tinderbox.py: same
376 * buildbot/steps/python_twisted.py: same
378 * buildbot/process/step.py: remove this file, these names were
379 deprecated in 0.7.5 and are now being removed.
380 * buildbot/process/step_twisted.py: same
381 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
383 * buildbot/twcompat.py: remove the empty file, yay it is gone
385 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
386 tw-2.0.0 and newer have the method we need.
387 (getProcessOutputAndValue): same
388 (which): remove this method, tw-2.0.0 t.p.procutils has it
390 * buildbot/twcompat.py (implements): remove this method
391 * buildbot/*: import implements() from zope.interface directly
393 * buildbot/status/mail.py: stop falling back to importing
394 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
397 * buildbot/twcompat.py (Interface): remove this import
398 * buildbot/*: import Interface from zope.interface directly
400 * buildbot/twcompat.py (providedBy): remove this method
401 * buildbot/*: turn all uses of providedBy(obj, iface) into
402 iface.providedBy(obj)
404 * buildbot/twcompat.py (maybeWait): remove this method, now that
405 we no longer maintain compatibility with Twisted<=1.3.0 .
406 Twisted-2.0.0 and later allow trial methods to return Deferreds
408 * buildbot/test/*: remove all uses of maybeWait
410 * buildbot/__init__.py (version): bump to 0.7.5+ while between
412 * docs/buildbot.texinfo: same
414 2006-12-10 Brian Warner <warner@lothar.com>
416 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
417 * docs/buildbot.texinfo: set version to match
419 2006-12-10 Brian Warner <warner@lothar.com>
421 * README (REQUIREMENTS): update for release
422 * NEWS: update for release
423 * buildbot/slave/commands.py (command_version): mention that this
424 version (2.2) was released with buildbot-0.7.5
426 * buildbot/test/test_config.py (StartService.testStartService):
427 inhibit the usual read-config-on-startup behavior, since otherwise
428 the log.err that gets recorded causes the test to fail
430 * buildbot/status/builder.py (LogFile.finish): forget about all
431 subscribers once the log has finished, since after that point
432 we're never going to use them again. This might help free up some
435 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
436 than the old/deprecated gtk.mainquit()
438 2006-12-09 Brian Warner <warner@lothar.com>
440 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
441 better when we can't open the masterdst file
443 * buildbot/scripts/startup.py (Follower._failure): add missing
444 import statement for BuildSlaveDetectedError
446 * buildbot/steps/transfer.py (FileUpload): cleanup
447 (FileDownload): same. Add tests for slave version, add mode=.
448 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
449 (SlaveFileDownloadCommand): same
450 * buildbot/test/test_transfer.py: enhance tests
451 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
454 2006-12-08 Brian Warner <warner@lothar.com>
456 * buildbot/scripts/runner.py (sendchange): halt the reactor on
457 both success *and* failure. Without this, the 'buildbot
458 sendchange' command would hang if it could not contact the
459 buildmaster or deliver the Change, which would generally cause the
460 user's commit/record/checkin command to hang too. Thanks to
461 Christian Unger for the catch.
463 2006-12-06 Brian Warner <warner@lothar.com>
465 * NEWS: update with items for the next release
467 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
468 whimsical example pulled from a punch-drunk email I sent out late
470 (Transferring Files): document some of the other parameters
471 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
472 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
473 * buildbot/test/test_svnpoller.py: same
474 * buildbot/changes/svnpoller.py (SVNPoller): same
476 2006-11-26 Brian Warner <warner@lothar.com>
478 * docs/buildbot.texinfo (Build Properties): remind users that
479 WithProperties must appear in a command= list, not as a top-level
481 * buildbot/steps/shell.py (ShellCommand.start): and assert that
482 we're sending a list or a single string to the RemoteShellCommand
484 * buildbot/scheduler.py (Nightly): Improve docs slightly.
486 * buildbot/scripts/startup.py (start): skip the whole
487 watch-the-logfile thing under windows, since it needs os.fork()
489 * buildbot/scripts/runner.py (restart): remove the old message
490 that got printed after the buildbot was restarted.. it most cases
491 it didn't get printed at the right time anyways
493 2006-11-25 Brian Warner <warner@lothar.com>
495 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
496 follow twistd.log and print lines until the process has started
497 started properly. For the buildmaster, this means until the config
498 file has been parsed and accepted. For the buildslave, this means
499 until we've connected to the master. We give up after 5 seconds in
500 any case. Helpful error messages and troubleshooting suggestions
501 are printed when we don't see a successful startup. This closes the
502 remainder of SF#1517975.
503 * buildbot/scripts/startup.py: moved app startup code to here
504 * buildbot/scripts/logwatcher.py: utility class to follow log
505 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
506 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
507 so the LogWatcher can tell the difference between a buildmaster
510 2006-11-24 Brian Warner <warner@lothar.com>
512 * docs/examples/twisted_master.cfg: update to match the version
513 in use on twistedmatrix.com
514 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
515 was using before stopped working, but 'irc.freenode.net' works
518 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
521 * buildbot/clients/base.py (TextClient.not_connected): upon
522 UnauthorizedLogin failures, remind the user to connect to the
523 PBListener port instead of the slaveport.
524 (TextClient.disconnected): shut down more quietly
525 * docs/buildbot.texinfo (statuslog): add another reminder
527 * buildbot/scripts/runner.py (Options.subCommands): rename
528 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
529 'sighup' as an alias.
530 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
531 reconfig command to follow twistd.log and print all of the lines
532 from the start of the config-file reload to its completion. This
533 should make it a lot easier to discover bugs in the config file.
534 Use --quiet to disable this behavior. This addresses half of
535 SF#1517975, the other half will be to add this same utility to
536 'buildbot start' and 'buildbot restart'.
537 * docs/buildbot.texinfo (Loading the Config File): same
540 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
541 method, it has been deprecated for a long time. Use
542 IBuilderControl.requestBuild instead.
543 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
544 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
545 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
546 * buildbot/test/test_control.py (Force.testForce): same
547 * buildbot/test/test_run.py: use requestBuild instead
549 * buildbot/clients/debug.py: replace 'Force Build' button with
550 'Request Build' (which just adds one to the queue), add Ping
551 Builder, add branch/revision fields to Request Build.
552 * buildbot/clients/debug.glade: same
553 * buildbot/master.py: update interface to match. This creates an
554 incompatibility between new debugclients and old buildmasters.
556 * buildbot/process/builder.py (Builder._attached): delay the call
557 to maybeStartBuild for a reactor turn, to avoid starting a build
558 in the middle of a reconfig (say, if the new Builder uses a new
559 slave which is already connected).
561 2006-11-23 Brian Warner <warner@lothar.com>
563 * buildbot/test/test_transfer.py: appease pyflakes
564 * buildbot/test/test_steps.py: same
566 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
567 keeps pyflakes from finding undefined names
569 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
570 Builder no longer induces a disconnect/reconnect cycle. This means
571 that any builds currently in progress will not be interrupted, and
572 any builds which are queued in the Builder will not be lost. This
573 is implemented by having the new Builder extract the state (i.e.
574 all pending Builds and any desired SlaveBuilders) from the old
576 (BotPerspective): refactor. The BotPerspective no longer keeps
577 track of all the Builders that want to use this slave; instead, it
578 asks the BotMaster each time it needs this list. This removes
579 addBuilder and removeBuilder. Clean up attached() to acquire all
580 the slave's information in a more atomic fashion. updateSlave() is
581 now the way to make sure the slave is using the right set of
582 Builders: just call it after everything else has been
584 (BotMaster): refactor, removing addBuilder/removeBuilder and
585 replacing them with an all-at-once setBuilders() call.
587 * buildbot/test/test_slaves.py (Reconfig): new test case to
588 exercise this functionality
589 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
590 * buildbot/slave/commands.py (WaitCommand): same
592 * docs/buildbot.texinfo (Loading the Config File): document the
595 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
596 SlaveBuilder to have its parent Builder changed.
597 (SlaveBuilder.isAvailable): new method to give access to state,
598 which is now a private attribute
599 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
600 the SlaveBuilder about how it is being used. These methods update
601 its internal state. buildFinished() is now the place that invokes
602 maybeStartBuild() on its parent Builder.
603 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
604 new Builder to take over for an old one, transferring state from
606 (Buider): refactor the way that SlaveBuilders are used to match,
607 giving them a bit more autonomy.
608 (Builder.buildFinished): this no longer calls maybeStartBuild():
609 instead the SlaveBuilder calls it on whoever its parent Builder is
610 at the time. This way, when an old Builder is replaced by a new
611 one, and there was a build in progress during the transition, when
612 that build finishes, it will be the new Builder that is told about
613 the newly available slave so it can start a new build.
615 * buildbot/process/base.py (Build.startBuild._release_slave): when
616 the Build finishes, tell the SlaveBuilder that they've been
619 * buildbot/status/builder.py (SlaveStatus): add some new setter
620 methods for use by BotPerspective, to keep some attributes more
623 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
624 called by the buildmaster.
625 (Bot.setBuilderList): instead, we locally announce any leftover
626 directories based upon which Builders we were told about. The
627 master doesn't really care; it's the local admin who may or may not
631 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
632 to allow use of python2.4 or whatever. This tool still requires
635 2006-11-19 Brian Warner <warner@lothar.com>
637 * NEWS (IStatusLog.readlines): more news items
639 2006-11-18 Brian Warner <warner@lothar.com>
641 * NEWS: start collecting items for the next release.
643 2006-11-04 Brian Warner <warner@lothar.com>
645 * buildbot/changes/bonsaipoller.py: apply updates from Ben
646 Hearsum. Closes SF#1590310.
647 * buildbot/test/test_bonsaipoller.py: and tests
649 * buildbot/status/tinderbox.py
650 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
651 status when the build results in WARNINGS. Patch from Dave
652 Liebreich. Closes SF#1587352.
654 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
655 linux-vs-osx behavior difference w.r.t. reading from files that
656 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
657 to Mark Rowe for the patch.
659 2006-10-15 Brian Warner <warner@lothar.com>
661 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
662 method name was misspelled in the interface definition. Thanks to
663 Roy Rapoport for the catch.
665 2006-10-13 Brian Warner <warner@lothar.com>
667 * docs/buildbot.texinfo (Adding LogObservers): update sample code
668 to match the great Steps renaming
670 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
671 Maybe I should run my own unit tests before recording a big
672 change. Good thing I've got a buildbot to remind me.
674 2006-10-12 Brian Warner <warner@lothar.com>
676 * buildbot/steps/transfer.py: rework __init__ and args setup
677 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
679 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
680 when opening the target file, only catch IOError (to report via
681 stderr/rc!=0), let the others be reported as normal exceptions
683 2006-10-08 Brian Warner <warner@lothar.com>
685 * contrib/svn_watcher.py: fix security holes by using proper argv
686 arrays and subprocess.Popen() rather than commands.getoutput().
687 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
688 is deprecated in favor of buildbot/changes/svnpoller.py, and will
689 probably be removed by the next release.
692 2006-10-04 Brian Warner <warner@lothar.com>
694 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
695 initial lines that weren't emitted by pyflakes. When the pyflakes
696 command is run under a Makefile, 'make' will echo the command it
697 runs to stdio, and that was getting logged as a "misc" warning.
698 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
699 * buildbot/test/test_steps.py (testPyFlakes3): another test
701 2006-10-01 Brian Warner <warner@lothar.com>
703 * buildbot/status/html.py (HtmlResource.render): if we get a
704 unicode object from our content() method, encode it into utf-8
705 like we've been claiming to all along. This allows the comments
706 and author names from svnpoller.py to be delivered properly.
708 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
709 de-unicodify filenames before creating the Change, because the
710 rest of buildbot is unlikely to handle them well. Leave the 'who'
711 field as a unicode object.. I don't think there's anything that
712 will break very soon, and it will probably nudge us towards
713 accepting unicode everywhere sooner or later. Stop using the
714 "date" field that comes out of SVN, since it is using the
715 repository's clock (and timezone) and what we care about is the
716 buildmaster's (otherwise Changes from the future show up later
717 than the builds they triggered).
718 * buildbot/test/test_svnpoller.py (Everything.test1): match the
721 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
722 Suvbersion repository polling ChangeSource. I've hacked it up
723 considerably: any bugs are entirely my own fault. Thank you
725 * buildbot/test/test_svnpoller.py: tests for it
726 * docs/buildbot.texinfo (SvnSource): document it
728 2006-09-30 Brian Warner <warner@lothar.com>
730 * buildbot/scheduler.py (Periodic): submit a reason= to the
731 BuildSet to indicate which Scheduler triggered the build. Thanks
732 to Mateusz Loskot for the suggestion.
734 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
736 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
737 changes: set self.loop in __init__, remove unused volatile=
739 * docs/buildbot.texinfo (.buildbot config directory): add more
740 docs on the .buildbot/options keys used by "buildbot try"
741 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
742 (Try.deliverJob): same
744 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
748 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
749 close the filehandle when we stop watching the file. Before, the
750 filehandle was only closed when the LogFileWatcher was
751 garbage-collected, which could be quite a while in the future. If
752 it was still open by the time the next build started, windows will
753 refuse to let the new build delete the old build/ directory. Fixes
754 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
755 #twisted for the catch.
757 2006-09-29 Brian Warner <warner@lothar.com>
759 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
762 2006-09-25 Brian Warner <warner@lothar.com>
764 * setup.py: the new buildbot.steps module wasn't being installed.
765 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
766 (testmsgs): add the extra stuff from buildbot/test/* so you can
767 run unit tests on an installed copy of buildbot, not just from
770 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
771 columns of 'svnlook changed' output contain status information, so
772 strip [:4] instead of [:6]. Depending upon what the status flags
773 were, this would sometimes lead to mangled filenames. Thanks to
774 Riccardo Magliocchetti for the patch. Closes SF#1545146.
776 * buildbot/steps/source.py (Monotone): initial Monotone support,
777 contributed by Nathaniel Smith. Still needs docs and tests, but
778 this code has been in use on the Monotone buildbot for a long
780 * buildbot/slave/commands.py (Monotone): slave-side support
781 * buildbot/changes/monotone.py (MonotoneSource): polling change
784 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
785 contributed a Change Source that polls a Bonsai server (a
786 kind of web-based viewcvs CGI script).
788 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
789 Hearsum contributed a status plugin which sends email in the same
790 format that Tinderbox does: this allows a number of tinderbox
791 tools to be driven by Buildbot instead. Thanks Ben!
793 2006-09-24 Brian Warner <warner@lothar.com>
795 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
796 Thanks to Robert Helmer for the patch.
798 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
799 BuildStatus about the buildslave name at the *beginning* of the
800 build, rather than at the end. Thanks to Alexander Lorenz for the
802 * buildbot/status/html.py (StatusResourceBuild.body): always
803 include the slavename in the build page, not just when the build
805 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
806 slavename in the email message
808 2006-09-21 Brian Warner <warner@lothar.com>
810 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
812 * docs/examples/glib_master.cfg: same
813 * docs/examples/hello.cfg: same
814 * docs/examples/twisted_master.cfg: same, update to current usage
816 2006-09-19 Brian Warner <warner@lothar.com>
818 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
819 (PyFlakes.createSummary): make it compatible with python-2.2
821 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
822 for at least the output-parsing parts of PyFlakes
824 2006-09-18 Brian Warner <warner@lothar.com>
826 * buildbot/steps/python.py: oops, fix import of StringIO
828 2006-09-17 Brian Warner <warner@lothar.com>
830 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
831 turns out that SVN-1.4.0 doesn't fail to update once you've
832 replaced a file with a directory, unlike older versions of SVN and
833 pretty much every other VC tool we support. Since what we really
834 care about is that the update succeeds anyway, stop checking that
835 the tree got clobbered and just assert that the build succeeded.
836 (VCBase.printLogs): add a utility function for debugging
838 * buildbot/process/step.py: oops, added extra imports by mistake
840 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
841 rstrip() on the first line coming out of the 'p4 describe'
842 process, to remove the stray ^M that Wade Brainerd reports seeing
843 in the 'when' field. Fixes SF#1555985.
845 * buildbot/master.py (BuildMaster.loadConfig): improve the error
846 message logged when c['schedulers'] is not right
847 * buildbot/scheduler.py (Scheduler.__init__): improve error
848 message when a Scheduler() is created with the wrong arguments
849 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
850 verify that these error messages are emitted
852 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
853 The idea is that all the base classes (like BuildStep and
854 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
855 will be a leftover backwards-compatibility file that only contains
856 aliases for the steps that were moved out to buildbot.steps.*
857 * lots: change imports to match
858 * buildbot/process/step.py: add a DeprecationWarning if it ever
861 2006-09-12 Brian Warner <warner@lothar.com>
863 * buildbot/scheduler.py (Scheduler.__init__): make sure that
864 builderNames= is actually a sequence, since if you happen to give
865 it a single builder-specification dictionary instead, it won't get
866 caught by the existing assert. Thanks to Brett Neely for the
869 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
871 * docs/buildbot.texinfo (Python BuildSteps): document them
872 (sendchange): include a link to PBChangeSource, since you need one
874 * buildbot/steps/shell.py: clean up test-case-name line, remove some
876 * buildbot/steps/dummy.py: same
878 2006-09-08 Brian Warner <warner@lothar.com>
880 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
881 BuildStep which lets you transfer files from the master to the
882 slave or vice versa. Thanks to Albert Hofkamp for the original
883 patch. Fixes SF#1504631.
884 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
886 (SlaveFileDownloadCommand): same
887 * docs/buildbot.texinfo (Transferring Files): document it
888 * buildbot/test/test_transfer.py: test it
889 * buildbot/test/runutils.py (StepTester): new utility class for
890 testing BuildSteps and RemoteCommands without Builds or Bots or PB
891 * buildbot/test/test_steps.py (CheckStepTester): validate that the
894 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
895 walk through StatusLogs one line at a time, mostly for the benefit
896 of ShellCommand.createSummary methods. You can either walk through
897 STDOUT or STDERR, but the default is STDOUT.
899 * buildbot/status/builder.py (LogFile.readlines): implement it.
900 Note that this is not yet memory-efficient, it just pulls the
901 whole file into RAM and then splits it up with a StringIO.
902 Eventually this should be a generator that only pulls chunks from
904 * buildbot/test/test_status.py (Log.testReadlines): test it
906 * docs/buildbot.texinfo: update to match changes
907 * buildbot/process/factory.py: stop using old definitions
908 * buildbot/process/process_twisted.py: same
909 * buildbot/test/test_*.py: same
911 * buildbot/process/step_twisted.py: move definition to..
912 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
913 relative-import mechanisms prevent this from being named 'twisted'
914 or 'python/twisted' as I would have preferred.
916 * buildbot/process/maxq.py: move definition to..
917 * buildbot/steps/maxq.py: .. here, leave a compatibility import
919 * buildbot/process/step.py: split the user-visible BuildSteps into
920 separate files, all under buildbot/steps/
921 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
922 * buildbot/steps/shell.py: this holds ShellCommand and friends
923 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
925 2006-09-05 Brian Warner <warner@lothar.com>
927 * lots: run pyflakes, removed a lot of unused imports, changed the
928 form of some conditional imports to remove false pyflakes
929 warnings. There are still a number of warnings left, mostly from
930 imports that are done for their side-effects.
931 * buildbot/test/test_vc.py: import twisted.python.failure, since it
934 2006-08-26 Brian Warner <warner@lothar.com>
936 * buildbot/test/test_locks.py (Unit.testLater): make the tests
937 compatible with twisted-1.3.0, for some reason I just can't seem
938 to let go of the past.
940 2006-08-25 Brian Warner <warner@lothar.com>
942 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
944 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
945 all logfiles= in startCommand(), rather than in start() . This
946 makes it easier to have the 'stdio' log come before any secondary
947 logfiles, which I feel makes the waterfall display more
949 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
950 from ShellCommand up into LoggingBuildStep
951 (LoggingBuildStep.__init__): move the handling of logfiles= from
952 ShellCommand up to LoggingBuildStep, because startCommand is
953 provided by LoggingBuildStep, whereas start() was specific to
954 subclasses like ShellCommand and Source. This removes code
955 duplication in those subclasses.
956 (ShellCommand.__init__): same
957 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
958 for a slave that's too old to understand logfiles= into a separate
959 method, so it can live in ShellCommand. The rest of
960 setupLogfiles() can live in LoggingBuildStep.
962 2006-08-24 Brian Warner <warner@lothar.com>
964 * buildbot/locks.py (BaseLock): you can now configure Locks to
965 allow multiple simultaneous owners. They still default to
966 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
968 * docs/buildbot.texinfo (Interlocks): document the new options
969 * buildbot/test/test_locks.py: add a bunch of new unit tests
970 * buildbot/process/base.py (Build.acquireLocks): locks now offer
971 waitUntilMaybeAvailable, not waitUntilAvailable
972 * buildbot/process/step.py (BuildStep.acquireLocks): same
973 * buildbot/master.py (BotMaster.getLockByID): real locks now use
974 the whole lockid in their constructor, not just the name. Also,
975 keep track of which real locks we've handed out by the full
976 lockid, not just class+name, otherwise changing just the maxCount=
977 in the master.cfg file would not actually cause a behavioral
980 2006-08-23 Brian Warner <warner@lothar.com>
982 * buildbot/__init__.py (version): bump to 0.7.4+ while between
984 * docs/buildbot.texinfo: same
986 2006-08-23 Brian Warner <warner@lothar.com>
988 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
989 * docs/buildbot.texinfo: set version to match
990 * NEWS: update for 0.7.4
991 * buildbot/slave/commands.py (command_version): mention that this
992 version (2.1) was released with buildbot-0.7.4
994 2006-08-22 Brian Warner <warner@lothar.com>
998 * CREDITS: new file, list of people who have helped. Thanks!
999 * MANIFEST.in: ship it
1001 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1002 new diagrams, the user's manual is more informative than it was.
1003 Start shipping the .html user's manual (and generated .png
1005 * Makefile: update 'release' target to match
1007 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1008 test.. I think the web-parts effort will render it pointless well
1009 before it ever actually starts to work.
1011 2006-08-20 Brian Warner <warner@lothar.com>
1013 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1014 meaning of the prefix= argument. It is now just a string which is
1015 stripped from the beginning of the filename. If prefix= is set but
1016 not found on any given filename, that filename is ignored. If all
1017 filenames in a Change are ignored, the Change is dropped. This is
1018 much simpler than the previous sep= nonsense, and I should have
1019 implemented it this way from the beginning. Effectively resolves
1020 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1021 Gedminas for the catch and suggested fixes.
1022 (ChangePerspective.perspective_addChange): implement the actual
1024 * buildbot/test/test_changes.py (TestChangePerspective): test it
1025 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1026 how to properly use prefix=
1027 * docs/examples/twisted_master.cfg (source): update prefix= by
1028 adding the trailing slash
1031 * docs/examples/twisted_master.cfg: update to actual practice
1033 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1034 update test case to match new link text.. the HREF has both a
1035 class= setting and an enclosing [] pair that I didn't match in the
1038 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1039 list of strings is preferred over a single string with embedded
1041 (ShellCommand.description=): explain that either single strings or
1042 a list of strings is acceptable, and why you might prefer one over
1043 the other. Add an example. Fixes SF#1524659, thanks to Paul
1044 Winkler for the catch.
1045 (Build Steps): update to use f.addStep() rather than using s()
1046 and the constructor list
1048 * buildbot/process/step.py (ShellCommand): accept either a single
1049 string or a list of strings in both description= and
1051 * buildbot/test/test_steps.py (Steps.test_description): test it
1052 * buildbot/test/runutils.py (makeBuildStep): support for that test
1054 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1055 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1056 collecting the files and creating the patch.
1058 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1059 per-step URLs that will be displayed on the waterfall display,
1060 for things like the HTML output of code-coverage tools, when
1061 the results are hosted elsewhere.
1062 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1063 way to retrieve these URLs
1064 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1065 the method to retrieve these URLs. Also provide backwards
1066 compatibility for saved BuildStepStatus instances that didn't have
1068 * buildbot/process/step.py (BuildStep.addURL): method to set these
1069 URLs from within a BuildStep
1070 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1071 (StepBox.getBox): give these external links a distinct CSS class
1072 named "BuildStep external" so a .css file can display them
1075 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1077 * buildbot/test/test_steps.py (Steps): test that we can all the
1078 URLs. Also add a bunch of other tests on methods that can be
1079 called from within BuildSteps
1080 * buildbot/test/runutils.py (makeBuildStep): add utility function
1082 2006-08-13 Brian Warner <warner@lothar.com>
1084 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1086 2006-08-10 Brian Warner <warner@lothar.com>
1088 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1089 index, this one of things like c['sources'] and c['schedulers']
1090 (indices): it looks like my clever idea of putting the @fooindex
1091 commands in between the @node and the @subsection (to make the
1092 HREF anchor jump to slightly above the section title, which works
1093 much better in html) confused texinfo horribly, so I'm moving the
1094 index tags back to be just after the @subsection marker. I also
1095 added extra lines between the @node/@section paragraph and the
1096 index tags, since I think maybe texinfo wants to see these be
1097 separate paragraphs.
1099 * docs/Makefile (images): make sure images get built when
1100 rendering the manual
1101 * docs/images/Makefile: same
1103 * buildbot/scripts/runner.py: rename 'buildbot master' to
1104 'buildbot create-master', and 'buildbot slave' to 'buildbot
1106 * docs/buildbot.texinfo: same
1109 * docs/buildbot.texinfo: reimplement the "useful classes" index
1110 with actual texinfo indices. The .info rendering is a bit
1111 weird-looking but it works well, and the HTML rendering is quite
1112 nice. This also puts the index targets in the regular flow of the
1113 text, which is easier to maintain.
1115 2006-08-06 Brian Warner <warner@lothar.com>
1117 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1118 Kevin Turner to prefer the environ= argument be a list rather than
1119 a string. If it is a list, it will be joined with a platform-local
1120 os.pathsep delimiter, and then prepended to any existing
1121 $PYTHONPATH value. This works better in cross-platform (i.e.
1122 windows buildslaves) environments when you need to push multiple
1123 directories onto the front of the path.
1124 (SlaveShellCommand): documented the new magic
1125 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1126 in a user-visible form
1128 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1129 Turner to prefer lists over strings when creating/running VC
1130 commands during unit tests. This is clearly necessary to survive
1131 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1132 renamed the wq() function to qw() though, since that's how it's
1133 spelled in perl. Eventually I'd prefer all commands to be
1134 specified with lists.
1136 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1137 which are deleted (or not yet created) correctly. Also add
1138 failsafe code to not explode if the file-watching poller doesn't
1139 get started. Thanks to JP Calderone for the catch and the poller
1141 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1143 * buildbot/test/emitlogs.py: same
1145 * NEWS: summarize recent changes
1147 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1148 clause to avoid the "host key mismatch" warning
1150 * buildbot/process/step_twisted.py (Trial.start): if the
1151 buildslave is too old to understand logfiles=, fall back to
1152 running 'cat _trial_temp/test.log' like before.
1153 (Trial.commandComplete): same. this takes advantage of the
1154 LoggingBuildStep refactoring to stall commandComplete long enough
1155 to run a second RemoteShellCommand.
1157 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1158 refactor command-completion handling, to allow methods like
1159 commandComplete/createSummary/evaluateCommand to return Deferreds.
1160 (LoggingBuildStep._commandComplete): delete the refactored method
1161 (ShellCommand.setupLogfiles): if the buildslave is too old to
1162 understand logfiles=, put a warning message both into twistd.log
1163 and into the otherwise empty user-visible LogFiles.
1165 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1166 callers to provide the slave-side logfile name, rather than
1167 forcing it to come from the local name of the LogFile.
1168 (BuildStep.getSlaveName): new method
1170 * buildbot/process/base.py (Build.getSlaveName): new method, so
1171 steps can find out which buildslave they're running on
1173 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1174 to match the s/cvs_ver/command_version/ change
1176 2006-08-05 Brian Warner <warner@lothar.com>
1178 * buildbot/slave/commands.py (command_version): replace the CVS
1179 auto-updated cvs_ver keyword with a manually-updated variable,
1180 since CVS is no longer the master repository. Add a description of
1181 the remote API change starting in this version (2.1), specifically
1182 the fact that SlaveShellCommand now accepts 'initial_stdin',
1183 'keep_stdin_open', and 'logfiles'.
1185 2006-07-31 Brian Warner <warner@lothar.com>
1187 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1188 diagrams to describe how the whole system fits together. The
1189 images themselves are kept in SVG files, with ascii-art versions
1190 in corresponding .txt files. Texinfo knows how to interpolate the
1191 text version into .info files, reference the .png versions from
1192 .html files, and include .eps versions in the .ps format.
1193 * docs/images/Makefile: tools to create .png and .eps
1194 * docs/images/*.svg: created pictures with Inkscape.
1195 * .darcs-boring: ignore the generated .eps and .png files
1197 2006-07-24 Brian Warner <warner@lothar.com>
1199 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1200 Scheduler names, since they cause setServiceParent to explode
1202 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1204 2006-07-20 Brian Warner <warner@lothar.com>
1206 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1207 which runs the buildbot unit tests
1209 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1210 classes that are useful in master.cfg
1212 2006-07-15 Brian Warner <warner@lothar.com>
1214 * Makefile (some-apidocs): new target to build only some epydocs
1216 * setup.py: minor comment.. does the classifiers= argument prevent
1217 the setup.py script from working on python2.2/2.3?
1219 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1222 * buildbot/twcompat.py: fix minor typo in comments
1224 * buildbot/manhole.py: move all Manhole-related code out to this
1225 module. Implement SSH-based manholes (with TwistedConch), and move
1226 to conch's nifty line-editing syntax-coloring REPL shell instead
1227 of the boring non-editing monochromatic (and deprecated) old
1229 * buildbot/master.py: remove all Manhole-related code
1230 (BuildMaster.loadConfig._add): make sure the old manhole is
1231 removed before we add the new one
1232 * docs/buildbot.texinfo (Debug options): document new Manhole options
1234 * buildbot/twcompat.py (_which): fix some epydoc issues
1235 * buildbot/status/html.py (Waterfall.__init__): same
1237 2006-06-29 Brian Warner <warner@lothar.com>
1239 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1240 deprecation warnings under newer Twisteds (by using
1241 zope.interface.Interface instead of old twisted.python.components
1243 * buildbot/slave/interfaces.py: same
1245 2006-06-28 Brian Warner <warner@lothar.com>
1247 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1248 svn commands, so it will fail immediately instead of hanging while
1249 it waits for a username/password to be typed in.
1251 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1252 log message if the step was shut down
1254 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1255 obsolete reference to mktap.
1257 2006-06-20 Brian Warner <warner@lothar.com>
1259 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1260 test to include new 'logfiles' argument sent from master to slave
1262 2006-06-19 Brian Warner <warner@lothar.com>
1264 * buildbot/process/step_twisted.py (Trial): track Progress from
1265 _trial_temp/test.log too
1267 * buildbot/process/step.py (OutputProgressObserver): generalize
1268 the earlier StdioProgressObserver into an OutputProgressObserver
1269 that can track LogFiles other than stdio.
1270 (LoggingBuildStep.__init__): same
1272 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1273 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1274 will fail under windows because of os.sep issues. It might have
1275 worked before if 'cat' was doing cygwin path conversion.
1277 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1278 creation of LogFileWatchers
1279 (ShellCommand._startCommand): and record the files that were
1280 watched in the 'headers' section of the ShellCommand output
1282 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1283 need to actually pass it to the slave if you want it to work.
1284 (ShellCommand): document it a bit
1286 * buildbot/test/test_shell.py: new test to validate LogFiles
1287 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1289 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1290 before printing the last batch of lines, to test that the polling
1291 logic is working properly
1293 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1294 handling, making it possible to track multiple logs for a single
1295 RemoteCommand. The previous single logfile is now known as the
1297 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1298 (RemoteShellCommand.__init__): accept logfiles=
1299 (LoggingBuildStep.startCommand): stdio_log is now one of many
1300 (ShellCommand): added logfiles= argument, as well as a class-level
1301 .logfiles attribute, which will be merged together to figure out
1302 which logfiles should be tracked. The latter maybe be useful for
1303 subclasses of ShellCommand which know they will aways produce
1304 secondary logfiles in the same location.
1306 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1307 and closeStdin() methods, preparing to make it possible to write
1308 to a ShellCommand's stdin at any time, not just at startup. These
1309 writes are buffered if the child process hasn't started yet.
1310 (LogFileWatcher): new helper class to watch arbitrary logfiles
1311 while a ShellCommand runs. This class polls the file every two
1312 seconds, and sends back 10k chunks to the buildmaster.
1313 (ShellCommand): rename stdin= to initialStdin=, and add
1314 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1316 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1317 key of "log" and a value of (logname, data).
1318 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1319 'logfiles' to the master-visible args dictionary.
1320 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1323 * buildbot/test/test_vc.py (Patch.testPatch): same
1326 * buildbot/test/emit.py: write to a logfile in the current
1327 directory. We use this to figure out what was used as a basedir
1328 rather than looking to see which copy of emit.py gets run, so that
1329 we can run the commands from inside _trial_temp rather than inside
1331 * buildbot/test/subdir/emit.py: same
1332 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1333 argument rather than running from buildbot/test/
1334 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1335 rather than using an implicit setUp()
1336 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1337 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1338 of assuming that we're running in buildbot/test/ (and that '.' is
1341 * buildbot/slave/commands.py (Command.doStart): refactor Command
1342 startup/completion a bit: now the SlaveBuilder calls doStart(),
1343 which is not meant for overridding by subclasses, and doStart()
1344 calls start(), which is. Likewise the SlaveBuilder calls
1345 doInterrupt(), and subclasses override interrupt(). This also puts
1346 responsibility for maintaining .running in Command rather than in
1348 (Command.doInterrupt): same
1349 (Command.commandComplete): same, this is called when the deferred
1350 returned by start() completes.
1351 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1352 (SlaveBuilder.remote_interruptCommand): same
1353 (SlaveBuilder.stopCommand): same
1355 2006-06-16 Brian Warner <warner@lothar.com>
1357 * buildbot/test/test_shell.py: new test file to contain everything
1358 relating to ShellCommand
1359 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1360 multiple logfiles in realtime" feature, not yet implemented
1361 * buildbot/test/emitlogs.py: support file for testLogFiles
1362 * docs/buildbot.texinfo (ShellCommand): document the feature
1364 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1366 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1367 for tests which exercise SlaveCommands in isolation.
1369 * buildbot/test/test_slavecommand.py: Move some utilities like
1370 SignalMixin and FakeSlaveBuilder from here ..
1371 * buildbot/test/runutils.py: .. to here, so they can be used by
1372 other test classes too
1373 * buildbot/test/test_vc.py: more SignalMixin refactoring
1374 * buildbot/test/test_control.py: same
1375 * buildbot/test/test_run.py: and some rmtree refactoring
1377 2006-06-15 Brian Warner <warner@lothar.com>
1379 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1380 'testBranch' to match other VC tests and have the tests run in
1381 roughly increasing order of dependency
1383 * buildbot/test/test_steps.py (LogObserver): new test to verify
1384 LogObservers can be created at various times and still get
1385 connected up properly
1387 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1388 to create BuildStepStatus instances that actually work.
1390 * buildbot/process/step.py (LogObserver): add outReceived and
1391 errReceived base methods, to be overridden
1393 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1394 API to take a name instead of a step, reducing the coupling
1395 somewhat. This returns the BuildStepStatus object so it can be
1396 passed to the new Step, instead of jamming it directly into the
1398 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1400 * buildbot/process/base.py (Build.setupBuild): use both methods
1401 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1402 process a bit to match
1404 2006-06-14 Brian Warner <warner@lothar.com>
1406 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1407 docs on writing new LogObserver classes
1408 (Writing New Status Plugins): brief docs on how Status Plugins fit
1411 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1412 implement a LogObserver that counts how many unit tests have been
1414 (Trial.__init__): wire it in
1415 * buildbot/test/test_twisted.py (Counter): unit test for it
1417 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1418 to new cmd.logs['stdio'] scheme
1419 (Trial.commandComplete): same
1420 (BuildDebs.commandComplete): same
1422 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1423 LogFiles, instead of just a single one. The old single logfile is
1424 now called "stdio". LoggedRemoteCommand no longer creates a
1425 LogFile for you (the code to do that was broken anyway). If you
1426 don't create a "stdio" LogFile, then stdout/stderr will be
1428 (LogObserver): implement "LogObservers", which a BuildStep can add
1429 to parse the output of a command in real-time. The primary use is
1430 to provide more useful information to the Progress code, allowing
1431 better ETA estimates.
1432 (LogLineObserver): utility subclass which feeds complete lines to
1433 the parser instead of bytes.
1434 (BuildStep.progressMetrics): this is safer as a tuple
1435 (BuildStep.setProgress): utility method, meant to be called by
1437 (BuildStep.addLogObserver): new method, to be called at any time
1438 during the BuildStep (even before any LogFiles have been created),
1439 to attach (or schedule for eventual attachment) a LogObserver to a
1441 (StdioProgressObserver): new LogObserver which replaces the old
1442 "output" progress gatherer
1443 (LoggingBuildStep.__init__): same
1444 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1445 (LoggingBuildStep._commandComplete): must use logs['stdio']
1446 instead of the old single ".log" attribute.
1447 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1448 functionality, now subsumed into StdioProgressObserver
1449 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1450 log name changed from "output" to "stdio".
1453 * buildbot/interfaces.py (ILogFile): add the Interface used from
1454 the BuildStep towards the LogFile
1455 (ILogObserver): and the one provided by a LogObserver
1456 * buildbot/status/builder.py (LogFile): implement it
1458 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1459 HEADER constants here ..
1460 * buildbot/status/builder.py (STDOUT): .. from here
1462 2006-06-13 Brian Warner <warner@lothar.com>
1464 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1465 compatibility with python2.2, which doesn't have the 'substr in
1467 (TestP4Poller.makeTime): utility function to construct the
1468 timestamp using the same strptime() approach as p4poller does. It
1469 turns out that time.mktime() behaves slightly differently under
1470 python2.2, probably something to do with the DST flag, and that
1471 causes the test to fail under python2.2. (changing the mktime()
1472 arguments to have dst=0 instead of -1 caused it to fail under
1473 python2.3. Go figure.)
1474 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1476 2006-06-12 Brian Warner <warner@lothar.com>
1478 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1479 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1480 contributing such an excellent patch, including docs and unit
1481 tests! This makes it *so* much easier to apply. I had to update
1482 test_vc.py to handle some recent refactorings, but everything else
1483 applied smoothly. The only remaining thing I'd like to fix would
1484 be to remove the hard-wired port 1666 used by p4d, and allow it to
1485 claim any unused port. This would allow two copies of the test
1486 suite to run on the same host at the same time, as well as
1487 allowing the test suite to run while a real (production) p4d was
1488 running on the same host. Oh, and maybe we should add a warning to
1489 step.P4 that gets emitted if the slave is too old to provide the
1490 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1491 * buildbot/slave/commands.py (P4): same
1492 (P4Sync): same, some minor updates
1493 * buildbot/changes/p4poller.py: same
1494 * docs/buildbot.texinfo: same
1495 * buildbot/test/test_p4poller.py: same
1496 * buildbot/test/test_vc.py (P4): same
1498 * setup.py: add Trove classifiers for PyPI
1500 2006-06-08 Brian Warner <warner@allmydata.com>
1502 * buildbot/status/client.py
1503 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1504 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1505 build needs to be IRemote'd separately, rather than IRemote'ing
1506 the whole list at once. I can't wait until newpb's serialization
1507 adapters make this unnecessary.
1509 2006-06-06 Brian Warner <warner@lothar.com>
1511 * buildbot/process/step.py (WithProperties): make this inherit
1512 from ComparableMixin, so that reloading an unchanged config file
1513 doesn't cause us to spuriously reload any Builders which use them.
1514 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1517 2006-06-03 Brian Warner <warner@lothar.com>
1519 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1520 running py2exe on windows, contributed by Mark Hammond. Addresses
1521 SF#1401121, but I think we still need to include
1522 buildbot/scripts/sample.cfg
1523 * setup.py: include buildbot_service.py as a script under windows
1524 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1525 a py2exe application), get the icon/css datafiles from a different
1528 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1529 double-escape the build URL. Thanks to Olivier Bonnet for the
1530 patch. Fixes SF#1452801.
1532 2006-06-02 Brian Warner <warner@lothar.com>
1534 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1535 first six columns of 'svnlook' output, not just the first column,
1536 since property changes appear in the other five. Thanks to Olivier
1537 Bonnet for the patch. Fixes SF#1398174.
1539 2006-06-01 Brian Warner <warner@lothar.com>
1541 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1542 the fake build, so that title= has something to be set to
1544 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1545 attribute of the "Build #NN" link in the yellow start-the-build
1546 box to the build's reason. This means that you get a little
1547 tooltip explaining why the build was done when you hover over the
1548 yellow box. Thanks to Zandr Milewski for the suggestion.
1550 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1551 (Box.setETA): handle ETA=None (by stopping the timer)
1552 (Box.update): make the [soon] text less different than the usual
1553 text, so the rest of the text doesn't flop around so much. It
1554 would be awfully nice to figure out how to center this stuff.
1555 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1557 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1558 by default, so that any ShellCommand which fails marks the overall
1559 build as a failure. I should have done this from the beginning.
1560 Add flunkOnFailure=False to the arguments if you want to turn off
1563 2006-05-30 Brian Warner <warner@lothar.com>
1565 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1566 last-build/current-build/current-step. Show what step is currently
1567 running. Show ETA for both the overall build and the current step.
1568 Update GTK calls to modern non-deprecated forms. There's still a
1569 lot of dead code and debug noise to remove.
1571 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1572 shows up properly in status displays
1574 2006-05-28 Brian Warner <warner@lothar.com>
1576 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1577 build we use to verify that WithProperties works:
1579 ** set flunkOnFailure=True so that build failures get noticed
1580 ** set workdir='.' so that the build succeeds, otherwise it is trying
1581 to touch 'build/something', and 'build/' doesn't exist because
1582 usually that's created by a Source step
1583 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1584 this test somehow triggers, in which the 'touch' process becomes
1585 a zombie and we wait for th etimeout before giving up on it.
1587 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1588 to log the Build results and step logs to the twisted log.
1589 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1590 what went wrong if a build was expected to succeed but didn't.
1592 * buildbot/process/step_twisted.py (Trial): set the default
1593 trialMode to '--reporter=bwverbose', which specifies verbose
1594 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1595 '-to', but those are completely missing in modern Twisteds.
1597 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1598 a localhost-only port, to encourage better security
1600 * docs/buildbot.texinfo (Change Sources): mention
1603 * .darcs-boring: add a Darcs boringfile
1605 * README (REQUIREMENTS): stop claiming compatibility with
1608 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1611 2006-05-27 Brian Warner <warner@lothar.com>
1613 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1614 * docs/buildbot.texinfo: same
1616 2006-05-23 Brian Warner <warner@lothar.com>
1618 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1619 * docs/buildbot.texinfo: set version to match
1620 * NEWS: update for 0.7.3
1622 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1623 give a quick mapping from VC system to possible ChangeSources
1624 (Build Properties): add 'buildername'
1626 * buildbot/process/base.py (Build.setupStatus): oops, set
1627 'buildername' and 'buildnumber' properties
1628 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1631 2006-05-22 Brian Warner <warner@lothar.com>
1633 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1634 property interpolation better
1636 * README (INSTALLATION): remove old '-v' argument from recommended
1639 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1640 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1643 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1644 'svnversion' instead of grepping the output of 'svn info', much
1645 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1646 Bonnet for the suggestion.
1647 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1648 require the WC_PATH argument, so run 'svnversion .' instead.
1650 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1651 aren't supposed to have 'self' in their argument list
1653 2006-05-21 Brian Warner <warner@lothar.com>
1655 * buildbot/process/step.py (ShellCommand.start): make
1656 testInterpolate pass. I was passing the uninterpolated command to
1657 the RemoteShellCommand constructor
1658 (ShellCommand._interpolateProperties): oops, handle non-list
1659 commands (i.e. strings with multiple words separated by spaces in
1660 them) properly, instead of forgetting about them.
1662 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1663 to actually try to use build properties in a real build. This test
1665 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1666 to start and evaluate builds
1668 * buildbot/test/test__versions.py: add a pseudo-test to record
1669 what version of Twisted/Python/Buildbot are running. This should
1670 show up at the beginning of _trial_tmp/test.log, and exists to help
1671 debug other problems.
1673 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1674 a filename to be served as 'robots.txt' to discourage web spiders.
1675 Adapted from a patch by Tobi Vollebregt, thanks!
1676 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1677 (Waterfall.test_waterfall): tweak the way that filenames are put
1678 into the config file, to accomodate windows pathnames better.
1680 * docs/buildbot.texinfo (HTML Waterfall): document it
1682 * buildbot/process/process_twisted.py
1683 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1684 changed the build process. The new setup.py no longer takes the
1686 (FullTwistedBuildFactory.__init__): same
1687 (TwistedReactorsBuildFactory.__init__): same
1689 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1690 be placed in the [hooks] section of the central repository (the
1691 one that everybody pushes changes to).
1693 2006-05-20 Brian Warner <warner@lothar.com>
1695 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1696 .darcs-context file, use binary mode. I think this was causing a
1697 Darcs failure under windows.
1699 2006-05-19 Brian Warner <warner@lothar.com>
1701 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1702 use a timezone string of +0000 and gmtime, since this timestamp is
1703 sent to a buildmaster and %z is broken.
1705 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1706 string and localtime, since this timestamp will only be consumed
1707 locally, and %z is broken.
1709 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1710 gmtime, since this timestamp is returned to the buildmaster, and
1713 2006-05-18 Brian Warner <warner@lothar.com>
1715 * NEWS: update in preparation for next release
1717 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1718 setup-repository and do-we-have-the-vc-tools code into a separate
1719 "helper" class, which sticks around in a single module-level
1720 object. This seems more likely to continue to work in the future
1721 than having it hide in the TestCase and hope that TestCases stick
1722 around for a long time.
1724 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1725 addremove' has been deprecated in recent versions of mercurial, so
1726 use 'hg add' instead
1728 2006-05-07 Brian Warner <warner@lothar.com>
1730 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1731 operating under windows, move the file before opening it, since
1732 you can't rename a file that somebody has open.
1734 * buildbot/process/base.py (Build.setupBuild): if something goes
1735 wrong while creating a Step, log the name and arguments, since the
1736 error message when you get the number of arguments wrong is really
1739 2006-05-06 Brian Warner <warner@lothar.com>
1741 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1742 bugs in twisted-specific code not covered by my unit tests, this
1743 time use 'cmd' argument instead of self.cmd
1745 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1746 fix stupid braino: either use startwith or find()==0, not both.
1747 (TwistedReactorsBuildFactory.__init__): another dumb typo
1749 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1750 mark this test as TODO under windows, since process-killing seems
1751 dodgy there. We'll come back to this later and try to fix it
1754 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1755 and don't include a timezone
1756 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1757 This should avoid the windows-with-verbose-timezone-name problem
1759 (Patch.testPatch): add a test which runs 'patch' with less
1760 overhead than the full VCBase.do_patch sequence, to try to isolate
1761 a windows test failure. This one uses slave.commands.ShellCommand
1762 and 'patch', but none of the VC code.
1764 * buildbot/slave/commands.py (getCommand): use which() to find the
1765 executables for 'cvs', 'svn', etc. This ought to help under
1768 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1769 working directory before starting. If an earlier test failed, the
1770 leftover directory would mistakenly flunk a later test.
1771 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1772 Make sure that we use the right commandlines if which("tla") picks
1773 up "tla.exe" (as it does under windows).
1774 (TlaSupport.do_get): factor out this tla-vs-baz difference
1775 (TlaSupport.vc_create): more tla-vs-baz differences
1777 * buildbot/test/test_slavecommand.py
1778 (ShellBase.testShellMissingCommand): stop trying to assert
1779 anything about the error message: different shells on different
1780 OSes with different languages makes it hard, and it really isn't
1781 that interesting of a thing to test anyway.
1783 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1784 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1785 "Panther"), because it has a bug which flunks a couple tests in
1786 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1787 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1788 able to test that yet.
1790 2006-04-30 Brian Warner <warner@lothar.com>
1792 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1793 make sure child commands emit messages in english, so our regexps
1794 will match. Thanks to Nikaus Giger for identifying the problems.
1795 (VCBase._do_vctest_export_1): mode="export" is not responsible
1796 for setting the "got_revision" property, since in many cases it is
1797 not convenient to determine.
1798 (SVNSupport.capable): when running 'svn --version' to check for
1799 ra_local, we want error messages in english
1800 * buildbot/test/test_slavecommand.py
1801 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1802 to emit the error message in english
1804 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1805 the environment with $LC_ALL="C" so that Commands which need to
1806 parse the output of their child processes can obtain it in
1808 (SVN.parseGotRevision): call "svn info" afterwards instead of
1809 watching the output of the "svn update" or "svn checkout".
1810 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1811 (Arch.parseGotRevision): same
1812 (Bazaar.parseGotRevision): same
1813 (Mercurial.parseGotRevision): same
1815 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1816 $LC_ALL="C" when running commands under 'buildbot try', too
1818 * buildbot/test/__init__.py: remove the global os.environ()
1819 setting, instead we do it just for the tests that run commands and
1820 need to parse their output.
1822 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1823 remove the overly-short .timeout on this test, because non-DNotify
1824 platforms must fall back to polling which happens at 10 second
1825 intervals, so a 5 second timeout would never succeed.
1827 2006-04-24 Brian Warner <warner@lothar.com>
1829 * docs/buildbot.texinfo (Installing the code): update trial
1830 invocation, SF#1469116 by Niklaus Giger.
1831 (Attributes of Changes): updated branch-name examples to be
1832 a bit more realistic, SF#1475240 by Stephen Davis.
1834 * contrib/windows/buildbot2.bat: utility wrapper for windows
1835 developers, contributed by Nick Trout (after a year of neglect..
1836 sorry!). SF#1194231.
1838 * buildbot/test/test_vc.py (*.capable): store the actual VC
1839 binary's pathname in VCS[vcname], so it can be retrieved later
1840 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1841 strip out non-numeric timezone information, specifically the funky
1842 German string that his system produced that confuses CVS.
1843 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1844 allow Darcs tests to work on windows
1845 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1846 procutils.which() everywhere, to allow tryclient to work under
1847 windows. Also from Niklaus Giger, SF#1463394.
1849 * buildbot/twcompat.py (which): move the replacement for a missing
1850 twisted.python.procutils.which from test_vc.py to here, so it can
1851 be used in other places too (specifically tryclient.py)
1853 2006-04-23 Brian Warner <warner@lothar.com>
1855 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1856 bare buildbotURL/projectName line with a proper DIV, along with a
1857 CSS class of "title", from Stefan Seefeld (SF#1461675).
1858 (WaterfallStatusResource.body0): remove the redundant 'table'
1859 class from the table
1860 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1861 to the top-row TR, and class="Activity" to the second-row TR,
1862 rather than putting them in the individual TD nodes.
1864 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1865 'got_revision' build property for all VC systems that implement
1866 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1868 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1869 to determine which revision we actually obtained
1870 (CVS.parseGotRevision): implement this for CVS, which just means
1871 to grab a timestamp. Not ideal, and it depends upon the buildslave
1872 having a clock that is reasonably well syncronized with the server,
1873 but it's better than nothing.
1874 (SVN.parseGotRevision): implement it for SVN, which is accurate
1875 (Darcs.parseGotRevision): same
1876 (Arch.parseGotRevision): same
1877 (Bazaar.parseGotRevision): same
1878 (Mercurial.parseGotRevision): same
1880 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1881 keep a record of all non-stdout/stderr/header/rc status updates,
1882 for the benefit of RemoteCommands that send other useful things,
1884 (Source.commandComplete): put any 'got_revision' status values
1885 into a build property of the same name
1888 * buildbot/process/step_twisted.py (Trial): update to deal with
1889 new ShellCommand refactoring
1891 * docs/buildbot.texinfo (Build Properties): document new feature
1892 that allows BuildSteps to get/set Build-wide properties like which
1893 revision was requested and/or checked out.
1895 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1896 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1897 it. Note that this bumps the persistenceVersion of the saved Build
1898 object, so add the necessary upgrade-old-version logic to include
1899 an empty properties dict.
1901 * buildbot/process/base.py (Build.setProperty): implement it
1902 (Build.getProperty): same
1903 (Build.startBuild): change build startup to set 'branch',
1904 'revision', and 'slavename' properties at the right time
1906 * buildbot/process/step.py (BuildStep.__init__): change setup to
1907 require 'build' argument in a better way
1908 (LoggingBuildStep): split ShellCommand into two pieces, for better
1909 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1910 a single RemoteCommand that sends stdout/stderr status text. It
1911 also provides the usual commandComplete / createSummary /
1912 evaluateCommand / getText methods to be overridden...
1913 (ShellCommand): .. whereas ShellCommand is specifically for
1914 running RemoteShellCommands. Other shell-like BuildSteps (like
1915 Source) can inherit from LoggingBuildStep instead of ShellCommand
1916 (WithProperties): marker class to do build-property interpolation
1917 (Source): inherit from LoggingBuildStep instead of ShellCommand
1920 * buildbot/test/test_properties.py: test new functionality
1922 2006-04-21 Brian Warner <warner@lothar.com>
1924 * buildbot/test/test_vc.py: rename testBranch to
1925 testCheckoutBranch to keep the tests in about the right
1928 2006-04-18 Brian Warner <warner@lothar.com>
1930 * docs/buildbot.texinfo (PBListener): improve cross-references
1931 between PBListener and 'buildbot statusgui', thanks to John Pye
1934 2006-04-17 Brian Warner <warner@lothar.com>
1936 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1937 running under Twisted-1.3.0, otherwise skipped tests are reported
1940 * all: use isinstance() instead of 'type(x) is foo', suggested by
1943 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1944 oops, fix a brain-fade from the other week, when making the
1945 addStep changes. I changed all the __init__ upcalls to use the
1946 wrong superclass name.
1947 (FullTwistedBuildFactory.__init__): same
1948 (TwistedDebsBuildFactory.__init__): same
1949 (TwistedReactorsBuildFactory.__init__): same
1950 (TwistedBuild.isFileImportant): use .startswith for clarity,
1951 thanks to Neal Norwitz for the suggestions.
1953 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1954 changes, then deliver them over PB to a remote buildmaster.
1956 * contrib/svnpoller.py: added script by John Pye to poll a remote
1957 SVN repository (by running 'svn log') from a cronjob, and run
1958 'buildbot sendchange' to deliver the changes to a remote
1960 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1961 modification of svnpoller.py), same purpose, but this one loops
1962 internally (rather than expecting to run from a cronjob) and works
1964 * contrib/README.txt: same
1966 2006-04-11 Brian Warner <warner@lothar.com>
1968 * all: fix a number of incorrect names and missing imports, thanks
1969 to Anthony Baxter for the patch.
1970 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1971 remove unused buggy method.
1972 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1973 comes from shutil, not "shutils"
1974 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1975 (Arch.checkSlaveVersion): same
1976 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1978 * buildbot/process/step_twisted2.py: add some missing imports
1979 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1980 this code used to live in twisted.internet.defer
1982 2006-04-10 Brian Warner <warner@lothar.com>
1984 * buildbot/process/step.py (Mercurial): add Mercurial support
1985 * buildbot/slave/commands.py (Mercurial): same
1986 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1987 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1988 not yet tested, but 'try' support *is* covered
1989 * docs/buildbot.texinfo (Mercurial): document it
1991 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1992 some debugging messages (turned off)
1993 * buildbot/test/test_vc.py: improve debug messages
1995 2006-04-07 Brian Warner <warner@lothar.com>
1997 * buildbot/test/test_vc.py (which): define our own which() in case
1998 we can't import twisted.python.procutils, because procutils doesn't
1999 exist in Twisted-1.3
2001 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2002 of SlaveLocks for performance tests
2004 * docs/examples/twisted_master.cfg: update to match current usage
2006 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2007 password, p4 binary, pollinterval, maximum history to check.
2008 Patch from an anonymous sf.net contributor, SF#1219384.
2009 * buildbot/process/step.py (P4Sync.__init__): add username,
2010 password, and client arguments.
2011 * buildbot/slave/commands.py (P4Sync): same
2013 2006-04-05 Brian Warner <warner@lothar.com>
2015 * buildbot/process/factory.py (BuildFactory.addStep): new method
2016 to add steps to a BuildFactory. Use it instead of f.steps.append,
2017 and you can probably avoid using the s() convenience function.
2018 Patch from Neal Norwitz, sf.net #1412605.
2019 (other): update all factories to use addStep
2020 * buildbot/process/process_twisted.py: update all factories to use
2023 2006-04-03 Brian Warner <warner@lothar.com>
2025 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2026 work under windows too. Adapted from a patch by Niklaus Giger,
2027 addresses SF#1463399.
2029 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2030 spawned commands emit parseable results in english and not some
2031 other language. Patch from Niklaus Giger, SF#1463395.
2033 * README (INSTALLATION): discourage users from running unit tests on
2034 a "network drive", patch from Niklaus Giger, SF#1463394.
2036 2006-03-22 Brian Warner <warner@lothar.com>
2038 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2039 function to turn a repository-relative pathname into a (branch,
2040 branch-relative-filename) tuple. Change this function to handle
2041 the branch naming policy used by your Subversion repository.
2042 Thanks to AllMyData.com for sponsoring this work.
2044 2006-03-16 Brian Warner <warner@lothar.com>
2046 * buildbot/scripts/sample.cfg: add python-mode declaration for
2047 vim. Thanks to John Pye for the patch.
2049 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2050 command line, mention the importance of running 'crontab' as the
2051 buildmaster/buildslave user. Thanks to John Pye for the catch.
2053 2006-03-13 Brian Warner <warner@lothar.com>
2055 * buildbot/status/words.py (IRC): add an optional password=
2056 argument, which will be sent to Nickserv in an IDENTIFY message at
2057 login, to claim the nickname. freenode requires this before the
2058 bot can sent (or reply to) private messages. Thanks to Clement
2059 Stenac for the patch.
2060 * docs/buildbot.texinfo (IRC Bot): document it
2062 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2063 larger than chunkSize. Fixes SF#1349253.
2064 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2065 (Log.testConsumer): update to match new internal chunking behavior
2067 2006-03-12 Brian Warner <warner@lothar.com>
2069 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2071 * buildbot/test/test_maildir.py (MaildirTest): rename the
2072 'timeout' method, as it collides with trial's internals
2074 * buildbot/scripts/runner.py: add 'buildbot restart' command
2075 (stop): don't sys.exit() out of here, otherwise restart can't work
2076 * docs/buildbot.texinfo (Shutdown): document it
2078 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2079 * buildbot/status/html.py (Waterfall.__init__): same
2080 * buildbot/process/builder.py (Builder.startBuild): same
2081 * buildbot/process/base.py (BuildRequest): same
2082 * buildbot/sourcestamp.py (SourceStamp): same
2083 * buildbot/scheduler.py (Nightly): same
2085 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2087 * docs/buildbot.texinfo: same
2089 2006-02-17 Brian Warner <warner@lothar.com>
2091 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2092 * docs/buildbot.texinfo: set version number to match
2093 * NEWS: update for 0.7.2
2095 2006-02-16 Brian Warner <warner@lothar.com>
2097 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2099 2006-02-09 Brian Warner <warner@lothar.com>
2101 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2102 add text to explain per-build branch parameters
2103 * NEWS: mention --umask
2105 2006-02-08 Brian Warner <warner@lothar.com>
2107 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2109 (SlaveOptions.optParameters): add --umask, to make it possible to
2110 make buildslave-generated files (including build products) be
2113 * buildbot/slave/bot.py (BuildSlave.startService): same
2115 2006-01-23 Brian Warner <warner@lothar.com>
2117 * buildbot/status/builder.py: urllib.quote() all URLs that include
2118 Builder names, so that builders can include characters like '/'
2119 and ' ' without completely breaking the resulting HTML. Thanks to
2120 Kevin Turner for the patch.
2121 * buildbot/status/html.py: same
2122 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2124 * NEWS: update in preparation for upcoming release
2126 2006-01-18 Brian Warner <warner@lothar.com>
2128 * docs/examples/twisted_master.cfg: update to match the Twisted
2129 buildbot: remove python2.2, switch to exarkun's buildslaves,
2130 disable the .deb builder until we figure out how to build twisted
2131 .debs from SVN, add some ktrace debugging to the OS-X build
2132 process and remove the qt build, remove threadless builders,
2133 change freebsd builder to use landonf's buildslave.
2135 2006-01-12 Brian Warner <warner@lothar.com>
2137 * buildbot/master.py (Manhole.__init__): let port= be a strports
2138 specification string, but handle a regular int for backwards
2139 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2140 used in master.cfg to limit connections to just the local host.
2141 (BuildMaster.loadConfig): same for c['slavePortnum']
2142 * buildbot/scheduler.py (Try_Userpass.__init__): same
2143 * buildbot/status/client.py (PBListener.__init__): same
2144 * buildbot/status/html.py (Waterfall.__init__): same, for both
2145 http_port and distrib_port. Include backwards-compatibility checks
2146 so distrib_port can be a filename string and still mean unix:/foo
2147 * docs/buildbot.texinfo (Setting the slaveport): document it
2148 (Debug options): same
2149 (HTML Waterfall): same
2152 * buildbot/test/test_config.py (ConfigTest): test it
2154 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2155 slaveport's disownServiceParent deferred to fire before opening
2156 the new one. Fixes an annoying bug in the unit tests.
2158 2006-01-03 Brian Warner <warner@lothar.com>
2160 * buildbot/master.py (BuildMaster): remove the .schedulers
2161 attribute, replacing it with an allSchedulers() method that looks
2162 for all IService children that implement IScheduler. Having only
2163 one parent/child relationship means fewer opportunities for bugs.
2164 (BuildMaster.allSchedulers): new method
2165 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2166 also fix ugly bug that caused any config-file reload to
2167 half-forget about the earlier Schedulers, causing an exception
2168 when a Change arrived and was handed to a half-connected
2169 Scheduler. The exception was in scheduler.py line 54ish:
2170 self.parent.submitBuildSet(bs)
2171 exceptions.AttributeError: 'NoneType' object has no attribute
2173 (BuildMaster.addChange): update to use allSchedulers()
2175 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2176 to work properly with twisted-1.3.0, where you must explicitly
2177 include the __implements__ from parent classes
2178 (BaseScheduler.__repr__): make it easier to distinguish distinct
2180 (BaseUpstreamScheduler.__implements__): same
2182 * buildbot/status/builder.py (Status.getSchedulers): update to
2184 * buildbot/test/test_run.py (Run.testMaster): same
2185 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2186 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2187 make sure Scheduler instances are left alone when an identical
2188 config file is reloaded
2189 (ConfigElements.testSchedulers): make sure Schedulers are properly
2192 * Makefile (TRIALARGS): my local default Twisted version is now
2193 2.1.0, update the trial arguments accordingly
2195 2005-12-22 Brian Warner <warner@lothar.com>
2197 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2200 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2201 addChange in the parent class, although I suspect this should be
2202 fixed better in the future.
2204 2005-11-26 Brian Warner <warner@lothar.com>
2206 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2207 explode when branch==None, thanks to Kevin Turner for the catch
2208 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2211 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2213 * docs/buildbot.texinfo: same
2215 2005-11-26 Brian Warner <warner@lothar.com>
2217 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2218 * docs/buildbot.texinfo: set version number to match
2220 2005-11-26 Brian Warner <warner@lothar.com>
2222 * NEWS: update for 0.7.1
2224 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2225 sure that unsubscribe works even if we never sent an ETA update.
2226 Also, don't explode on duplicate unsubscribe.
2227 (BuildStepStatus.addLog): make the convenience "return self"-added
2228 watcher automatically unsubscribe when the Step finishes.
2229 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2230 (BuildStatus.stepStarted): same auto-unsubscribe
2231 (BuilderStatus.buildStarted): same auto-unsubscribe
2233 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2235 (IStatusReceiver.stepStarted): same
2236 (IStatusReceiver.logStarted): same
2238 * buildbot/test/test_run.py (Status): move the Status test..
2239 * buildbot/test/test_status.py (Subscription): .. to here
2241 2005-11-25 Brian Warner <warner@lothar.com>
2243 * NEWS: more updates
2245 * buildbot/locks.py: fix the problem in which loading a master.cfg
2246 file that changes some Builders (but not all of them) can result
2247 in having multiple copies of the same Lock. Now, the real Locks
2248 are kept in a table inside the BotMaster, and the Builders/Steps
2249 use "LockIDs", which are still instances of MasterLock and
2250 SlaveLock. The real Locks are instances of the new RealMasterLock
2251 and RealSlaveLock classes.
2252 * buildbot/master.py (BotMaster.getLockByID): new method to
2253 convert LockIDs into real Locks.
2254 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2255 into real Locks before building
2256 * buildbot/process/step.py (BuildStep.startStep): same
2257 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2258 exercises the problem
2261 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2262 what Schedulers are available
2264 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2265 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2266 'cron'-style build scheduling at certain times of day, week,
2268 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2270 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2271 handling: treat self.fileIsImportant more as an attribute that
2272 contains a callable than as a method. If the attribute is None,
2273 don't call it and assume all filenames are important. It is still
2274 possible to provide a fileIsImportant method in a subclass,
2276 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2278 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2279 test using AnyBranchScheduler with fileIsImportant=None
2281 2005-11-24 Brian Warner <warner@lothar.com>
2283 * buildbot/test/test_config.py (StartService): don't claim a fixed
2284 port number, instead set slavePort=0 on the first pass, figure out
2285 what port was allocated, then switch to a config file that uses
2288 * buildbot/master.py (BuildMaster.loadConfig): close the old
2289 slaveport before opening the new one, because unit tests might
2290 replace slavePort=0 with the same allocated portnumber, and if we
2291 don't wait for the old port to close first, we get a "port already
2292 in use" error. There is a tiny race condition here, but the only
2293 threat is from other programs that bind (statically) to the same
2294 port number we happened to be allocated, and only if those
2295 programs use SO_REUSEADDR, and only if they get control in between
2298 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2300 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2301 deleted ChangeSources before adding any new ones
2302 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2303 compare_attrs, to make sure that a config-file reload does not
2304 unnecessarily replace an unmodified ChangeSource instance
2305 * buildbot/test/test_config.py (ConfigTest.testSources): update
2307 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2308 mean "don't build anything", and add a warning if it gets used
2309 because it isn't actually useful.
2311 * contrib/svn_buildbot.py: update example usage to match the port
2312 number that gets used by the PBChangeSource
2313 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2315 2005-11-22 Brian Warner <warner@lothar.com>
2317 * NEWS: start collecting items for next release
2319 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2320 revisions are strings
2321 (P4Sync.computeSourceRevision): same
2323 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2324 to the Buildbot's overall status page
2325 (StatusResourceBuilder.body): same
2327 2005-11-15 Brian Warner <warner@lothar.com>
2329 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2330 config-file loading, specifically to make sure old StatusTargets
2331 are finished shutting down before new ones start up (thus
2332 resolving a bug in which changing the Waterfall object would fail
2333 because both new and old instances were claiming the same
2334 listening port). Also load new Schedulers after all the new
2335 Builders are set up, in case they fire off a new build right away.
2336 * buildbot/test/test_config.py (StartService): test it
2338 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2339 the branch name to the mail body
2341 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2342 Without it, a config-file reload fails to update an existing
2344 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2345 username/passwd to compare_attrs, for the same reason
2346 * buildbot/status/html.py (Waterfall): add favicon to
2347 compare_attrs, same reason
2349 2005-11-05 Brian Warner <warner@lothar.com>
2351 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2352 baserev before stuffing it in the jobfile. This resolves problems
2353 under SVN (and probably Arch) where revisions are expressed as
2354 numbers. I'm inclined to use string-based revisions everywhere in
2355 the future, but this fix should be safe for now. Thanks to Steven
2356 Walter for the patch.
2358 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2359 binary mode when opening pickle files, to make windows work
2360 better. Thanks to Dobes Vandermeer for the catch.
2361 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2362 (BuilderStatus.getBuildByNumber): same
2363 (Status.builderAdded): same
2364 * buildbot/master.py (BuildMaster.loadChanges): same
2366 * buildbot/util.py (Swappable): delete unused leftover code
2368 * buildbot/process/step.py (SVN): when building on a non-default
2369 branch, add the word "[branch]" to the VC step's description, so
2370 it is obvious that we're not building the usual stuff. Likewise,
2371 when we are building a specific revision, add the text "rNNN" to
2372 indicate what that revision number is. Thanks to Brad Hards and
2373 Nathaniel Smith for the suggestion.
2374 (Darcs.startVC): same
2375 (Arch.startVC): same
2376 (Bazaar.startVC): same
2378 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2379 typo, caught by Mark Dillavou, closes SF#1216636.
2381 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2382 about a test to add some day
2384 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2385 the 'full-2.3' build, and the 'reactors' build is now run under
2386 python-2.4 because the buildslave no longer has gtk/etc bindings
2387 for earlier versions.
2389 2005-11-03 Brian Warner <warner@lothar.com>
2391 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2392 method, takes an IBuildStatus and rebuilds it. It might make more
2393 sense to add this to IBuildControl instead, but that instance goes
2394 away completely once the build has finished, and resubmitting
2395 builds can take place weeks later.
2396 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2397 * buildbot/status/html.py (StatusResourceBuild): also stash an
2398 IBuilderControl so we can use resubmitBuild.
2399 (StatusResourceBuild.body): render "resubmit" button if we can.
2400 Also add hrefs for each BuildStep
2401 (StatusResourceBuild.rebuild): add action for "resubmit" button
2402 (StatusResourceBuilder.getChild): give it an IBuilderControl
2404 * buildbot/status/builder.py (Status.getURLForThing): change the
2405 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2406 that live as targets of buttons like "stop" and "rebuild" can't
2408 * buildbot/status/builder.py (Status.getURLForThing): same
2409 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2410 (StepBox.getBox): same
2411 * buildbot/test/test_web.py (GetURL): same
2414 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2415 exclusivity checks after Source.__init__ upcall, so misspelled
2416 arguments will be reported more usefully
2417 (Darcs.__init__): same
2419 2005-10-29 Brian Warner <warner@lothar.com>
2421 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2422 builder. Move the Try scheduler off to a separate port.
2424 2005-10-27 Brian Warner <warner@lothar.com>
2426 * buildbot/clients/gtkPanes.py
2427 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2428 to cause the app to crash, now they don't.
2430 * buildbot/clients/debug.py: display the buildmaster's location
2431 in the window's title bar
2433 2005-10-26 Brian Warner <warner@lothar.com>
2435 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2436 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2437 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2439 * buildbot/status/html.py (td): put a single non-breaking space
2440 inside otherwise empty <td> elements, as a workaround for buggy
2441 browsers which would optimize them away (along with any associated
2442 styles, like the kind that create the waterfall grid borders).
2443 Patch from Frerich Raabe.
2445 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2446 argv-list as an argument, defaulting to ["-to"], which is
2447 appropriate for the Trial that comes with Twisted-2.1.0 and
2448 earlier. The Trial in current Twisted SVN wants
2449 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2450 defaults to an empty list.
2451 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2452 match it, now that trialMode= is a list instead of a single string
2454 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2456 * docs/buildbot.texinfo: same
2458 2005-10-24 Brian Warner <warner@lothar.com>
2460 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2461 * docs/buildbot.texinfo: set version number to match
2463 2005-10-24 Brian Warner <warner@lothar.com>
2465 * README: update for 0.7.0
2467 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2469 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2470 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2471 send the branch= argument unless the user really provided one, to
2472 retain compatibility with older buildmasters that don't accept
2474 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2477 * docs/buildbot.texinfo: update lots of stuff
2479 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2480 to the 'buildbot sendchange' command
2481 * buildbot/clients/sendchange.py (Sender.send): same
2482 * buildbot/changes/pb.py (ChangePerspective): same
2483 * buildbot/test/test_changes.py (Sender.testSender): test it
2485 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2486 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2487 for consistency with other BuildStep arguments that use camelCase.
2488 Well, at least more of them use camelCase (like flunkOnWarnings)
2489 than don't.. I wish I'd picked one style and stuck with it
2490 earlier. Annoying, but it's best done before the release, since
2491 these arguments didn't exist at all in 0.6.6 .
2493 * buildbot/test/test_vc.py (SVN.testCheckout): same
2494 (Darcs.testPatch): same
2495 * docs/buildbot.texinfo (SVN): document the change
2496 (Darcs): same, add some build-on-branch docs
2497 * docs/examples/twisted_master.cfg: match change
2499 * buildbot/process/step.py (BuildStep): rename
2500 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2501 how it is normally used.
2502 * buildbot/test/test_steps.py (Version.checkCompare): same
2504 * buildbot/process/step.py (CVS.startVC): refuse to build
2505 update/copy -style builds on a non-default branch with an old
2506 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2507 concern is that it will do a VC 'update' in an existing tree when
2508 it is supposed to be switching branches (and therefore clobbering
2509 the tree to do a full checkout), thus building the wrong source.
2510 This used to be a warning, but I think the confusion it is likely
2511 to cause warrants making it an error.
2512 (SVN.startVC): same, also make mode=export on old slaves an error
2513 (Darcs.startVC): same
2514 (Git.startVC): improve error message for non-Git-enabled slaves
2515 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2516 specific revision is built on a slave that doesn't pay attention
2517 to args['revision'], because for slowly-changing trees it will
2518 probably do the right thing, and because we have no way to tell
2519 whether we're asking it to build the most recent version or not.
2520 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2522 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2523 that 'master' is in host:portnum format, to catch errors sooner
2525 2005-10-23 Brian Warner <warner@lothar.com>
2527 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2528 when creating the list of warning messages, include the line
2529 immediately after each WARNING: line, since that's usually where
2530 the file and line number wind up.
2532 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2537 2005-10-22 Brian Warner <warner@lothar.com>
2539 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2540 patch from Brad Hards
2541 * buildbot/status/classic.css: same
2542 * buildbot/test/test_web.py (Waterfall): match changes
2544 * buildbot/test/test_steps.py (BuildStep.setUp): set
2545 nextBuildNumber so the test passes
2546 * buildbot/test/test_status.py (MyBuilder): same
2548 * buildbot/status/html.py (StatusResourceBuild.body): revision
2549 might be numeric, so stringify it before html-escapifying it
2550 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2551 timer for the upcoming build
2552 * buildbot/status/classic.css: add background-color attributes for
2553 offline/waiting/building classes
2555 * buildbot/status/builder.py (BuildStatus): derive from
2556 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2557 the default (i.e. unknown) .slavename to "???" instead of None,
2558 since even unknown slavenames need to be printed eventually.
2559 (BuilderStatus): also derive from styles.Versioned . More
2560 importantly, determine .nextBuildNumber at creation/unpickling
2561 time by scanning the directory of saved BuildStatus instances and
2562 choosing one larger than the highest-numbered one found. This
2563 should fix the problem where random errors during upgrades cause
2564 the buildbot to forget about earlier builds. .nextBuildNumber is
2565 no longer stored in the pickle.
2566 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2567 at least log the error. Also call Builder.determineNextBuildNumber
2568 once the basedir is set.
2570 * buildbot/master.py (BuildMaster.loadChanges): do
2571 styles.doUpgrade afterwards, in case I decide to make Changes
2572 derived from styles.Versioned some day and forget to make this
2576 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2577 when running under older pythons (<2.3) in which the shlex module
2578 doesn't have a 'split' function.
2580 * buildbot/process/step.py (ShellCommand.start): make
2581 errorMessages= be a list of strings to stuff in the log before the
2582 command actually starts. This makes it easier to flag multiple
2583 warning messages, e.g. when the Source steps have to deal with an
2585 (CVS.startVC): handle slaves that don't handle multiple branches
2586 by switching into 'clobber' mode
2587 (SVN.startVC): same. Also reject branches without base_url
2588 (Darcs.startVC): same. Also reject revision= in older slaves
2589 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2590 (Bazaar.startVC): same, and test for baz separately than for arch
2592 * buildbot/slave/commands.py (cvs_ver): document new features
2594 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2595 (BuildStep.slaveVersionNewEnough): more useful utility method
2596 * buildbot/test/test_steps.py (Version): start testing it
2598 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2599 the 'force' command requires python2.3, for the shlex.split method
2601 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2602 since we don't use it anymore. The Twisted buildbot uses a
2605 2005-10-21 Brian Warner <warner@lothar.com>
2607 * buildbot/process/process_twisted.py: rework all BuildFactory
2608 classes to take a 'source' step as an argument, instead of
2609 building up the SVN instance in the factory.
2610 * docs/examples/twisted_master.cfg: enable build-on-branch by
2611 providing a base_url and default_branch
2613 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2614 control over --branch and --revision, not that they are always
2616 * buildbot/status/html.py (StatusResourceBuilder.force): same
2617 (StatusResourceBuild.body): display SourceStamp components
2619 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2620 IRC 'force' command, so it can be shared with an eventual
2621 command-line-tool 'buildbot force' mode.
2622 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2624 2005-10-20 Brian Warner <warner@lothar.com>
2626 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2628 * docs/examples/twisted_master.cfg: update to use Schedulers
2630 * buildbot/scripts/sample.cfg: update with Schedulers
2632 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2633 method specifically for use by HTML "force build" button and the
2634 IRC "force" command. Raises an immediate error if there are no
2636 (IBuilderControl.requestBuild): make this just submit a build, not
2637 try to check for existing slaves or set up any when-finished
2638 Deferreds or anything.
2639 * buildbot/process/builder.py (BuilderControl): same
2640 * buildbot/status/html.py (StatusResourceBuilder.force): same
2641 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2642 * buildbot/test/test_slaves.py: same
2643 * buildbot/test/test_web.py: same
2645 2005-10-19 Brian Warner <warner@lothar.com>
2647 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2648 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2650 2005-10-18 Brian Warner <warner@lothar.com>
2652 * buildbot/status/html.py: provide 'status' argument to most
2653 StatusResourceFOO objects
2654 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2655 and Logfiles" section to make the Build page into a more-or-less
2656 comprehensive source of status information about the build
2658 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2659 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2661 2005-10-17 Brian Warner <warner@lothar.com>
2663 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2664 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2665 out what to do about other projects: the correct options for
2666 recent Twisteds will not work for older ones.
2668 2005-10-15 Brian Warner <warner@lothar.com>
2670 * buildbot/status/builder.py (Status.getURLForThing): add method
2671 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2672 use this in email/IRC status clients to make them more useful, by
2673 providing the end user with hints on where to learn more about the
2674 object being reported on.
2675 * buildbot/test/test_web.py (GetURL): tests for it
2677 2005-10-14 Brian Warner <warner@lothar.com>
2679 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2680 fix bug resulting from deferredResult changes
2682 2005-10-13 Brian Warner <warner@lothar.com>
2684 * buildbot/test/test_changes.py: remove use of deferredResult
2685 * buildbot/test/test_config.py: same
2686 * buildbot/test/test_control.py: same
2687 * buildbot/test/test_status.py: same
2688 * buildbot/test/test_vc.py: this is the only remaining use, since
2689 it gets used at module level. This needs to be replaced by some
2690 sort of class-level run-once routine.
2692 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2694 * lots: implement multiple slaves per Builder, which means multiple
2695 current builds per Builder. Some highlights:
2696 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2697 of (state,currentBuilds) instead of (state,currentBuild)
2698 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2699 (IBuildStatus.getSlavename): new method, so you can tell which
2700 slave got used. This only gets set when the build completes.
2701 (IBuildRequestStatus.getBuilds): new method
2703 * buildbot/process/builder.py (SlaveBuilder): add a .state
2704 attribute to track things like ATTACHING and IDLE and BUILDING,
2706 (Builder): .. the .slaves attribute here, which has been turned
2707 into a simple list of available slaves. Added a separate
2708 attaching_slaves list to track ones that are not yet ready for
2710 (Builder.fireTestEvent): put off the test-event callback for a
2711 reactor turn, to make tests a bit more consistent.
2712 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2713 ping fails due to an exception. This needs work, I'm worried that
2714 a code error could lead to a constantly re-connecting slave.
2715 Especially since I'm trying to move to a distinct remote_ping
2716 method, separate from the remote_print that we currently use.
2717 (BuilderControl.requestBuild): return a convenience Deferred that
2718 provides an IBuildStatus when the build finishes.
2719 (BuilderControl.ping): ping all connected slaves, only return True
2720 if they all respond.
2722 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2723 reconnect when we shut down.
2725 * buildbot/status/builder.py: implement new methods, convert
2726 one-build-at-a-time methods to handle multiple builds
2727 * buildbot/status/*.py: do the same in all default status targets
2728 * buildbot/status/html.py: report the build's slavename in the
2729 per-Build page, report all buildslaves on the per-Builder page
2731 * buildbot/test/test_run.py: update/create tests
2732 * buildbot/test/test_slaves.py: same
2733 * buildbot/test/test_scheduler.py: remove stale test
2735 * docs/buildbot.texinfo: document the new builder-specification
2736 'slavenames' parameter
2738 2005-10-12 Brian Warner <warner@lothar.com>
2740 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2741 report failure correctly, causing Dependent builds to run when
2742 they shouldn't have.
2743 * buildbot/status/builder.py (BuildSetStatus): same
2744 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2745 (Set.testSuccess): test the both-pass case too
2746 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2747 fix this test: it was ending too early, masking the failure before
2748 (Logger): specialized StatusReceiver to make sure the dependent
2749 builds aren't even started, much less completed.
2751 2005-10-07 Brian Warner <warner@lothar.com>
2753 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2754 bot.SlaveBuilder being disowned in the middle of a build
2756 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2757 this inherit from StatusReceiver. Also upcall in __init__. This
2758 fixes the embarrasing crash when the new buildSetSubmitted method
2759 is invoked and Waterfall/etc don't implement their own.
2760 * buildbot/test/test_run.py: add a TODO note about a test to catch
2761 just this sort of thing.
2763 * buildbot/process/builder.py (Builder.attached): remove the
2764 already-attached warning, this situation is normal. Add some
2765 comments explaining it.
2767 2005-10-02 Brian Warner <warner@lothar.com>
2769 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2770 OverflowError when setting up dnotify, because some 64-bit systems
2771 have problems with signed-vs-unsigned constants and trip up on the
2772 DN_MULTISHOT flag. Patch from Brad Hards.
2774 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2776 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2777 progressMetrics, description, descriptionDone to the 'parms' list,
2778 and make use the 'parms' list from the implementation class
2779 instead of only BuildStep to initialize the parameters. This
2780 allows buildbot.process.factory.s() to initialize all the parms,
2781 not just those defined in directly by BuildStep.
2783 2005-09-03 Brian Warner <warner@lothar.com>
2785 * NEWS: start adding items for the next release
2787 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2788 python2.2 tests, change 'Quick' builder to only use python2.3
2790 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2792 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2793 the "Ping Builder" button if the build control is available; the
2794 user sees an exception otherwise
2796 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2798 2005-09-01 Brian Warner <warner@lothar.com>
2800 * buildbot/interfaces.py (IBuilderStatus.getState): update
2801 signature, point out that 'build' can be None
2802 (IBuildStatus.getETA): point out ETA can be none
2804 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2806 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2808 2005-08-31 Brian Warner <warner@lothar.com>
2810 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2811 update to match correct signature: removed 'eta' argument
2812 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2814 2005-08-30 Brian Warner <warner@lothar.com>
2816 * buildbot/status/builder.py (LogFile): remove the assertion that
2817 blows up when you try to overwrite an existing logfile, instead
2818 just emit a warning. This case gets hit when the buildmaster is
2819 killed and doesn't get a chance to write out the serialized
2820 BuilderStatus object, so the .nextBuildNumber attribute gets out
2823 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2824 the 'buildbot sendchange' arguments, for the Darcs context file
2825 * docs/buildbot.texinfo (sendchange): document it
2827 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2828 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2829 (IStatus.getSchedulers): new method
2830 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2831 (Status.getSchedulers): implement
2832 * buildbot/process/builder.py (Builder): maintain
2833 BuilderStatus.pendingBuilds
2834 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2835 (TryBase.addChange): Try schedulers should ignore Changes
2837 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2838 for 'try' on CVS/SVN
2839 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2841 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2842 report status properly.
2843 (Try.createJob): implement unique buildset IDs
2845 * buildbot/status/client.py (StatusClientPerspective): add a
2846 perspective_getBuildSets method for the benefit of jobdir-style
2848 * docs/buildbot.texinfo (try): more docs
2849 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2852 2005-08-18 Brian Warner <warner@lothar.com>
2854 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2855 actually work. It's functional but still kind of clunky. Also, it
2856 only works with the pb-style.. needs to be made to work with the
2859 * buildbot/status/client.py (RemoteBuildSet): new class
2860 (RemoteBuildRequest): same
2861 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2862 object, not the internal BuildStatus object.
2863 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2864 outside of the usual buildStarted() return value.
2865 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2867 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2868 (Try_Userpass_Perspective.perspective_try): return a remotely
2869 usable BuildSetStatus object
2871 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2872 isStarted()/waitUntilStarted()
2874 2005-08-16 Brian Warner <warner@lothar.com>
2876 * buildbot/status/builder.py: implement IBuildSetStatus and
2877 IBuildRequestStatus, wire them into place.
2878 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2879 methods into the BuildSetStatus object.
2880 * buildbot/interfaces.py: same
2881 (IStatus.getBuildSets): new method to get pending BuildSets
2882 (IStatusReceiver.buildsetSubmitted): new method which hears about
2884 * buildbot/master.py (BuildMaster.submitBuildSet): same
2885 * buildbot/process/base.py (BuildRequest): same, replace
2886 waitUntilStarted with subscribe/unsubscribe
2887 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2888 subscribe instead of waitUntilStarted
2889 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2891 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2893 * buildbot/test/test_buildreq.py: update for new code
2894 * buildbot/test/test_control.py (Force.testRequest): same
2897 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2898 for Darcs to not use the tempfile module, so it works under
2899 python-2.2 too. We really didn't need the full cleverness of that
2900 module, since the slave has exclusive control of its own builddir.
2902 2005-08-15 Brian Warner <warner@lothar.com>
2904 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2905 for CVS trees. It doesn't work for non-trunk branches,
2907 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2910 * Makefile: make it easier to test against python2.2
2912 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2913 tearDown2, so things like Arch can unregister archives as they're
2914 shutting down. The previous subclass-override-tearDown technique
2915 resulted in a nested maybeWait() and test failures under
2918 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2919 where we can (Arch), add a branch= argument to set the branch used
2921 (BazExtractor): extract the branch too
2922 (TlaExtractor): same
2923 * buildbot/scripts/runner.py (TryOptions): add --branch
2924 * docs/buildbot.texinfo (try): document --branch/try_branch
2926 * buildbot/slave/commands.py (Darcs): implement get-revision for
2927 Darcs, so that 'try' will work. This requires the tempfile module
2930 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2931 of revisions, branches, and 'try' in the process.
2933 2005-08-11 Brian Warner <warner@lothar.com>
2935 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2936 this, it got broken at some point in the last few releases
2937 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2938 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2939 specifically the removal of ETA information from the tuple
2941 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2944 * docs/buildbot.texinfo (try): document both --builder and
2945 'try_builders' in .buildbot/options
2946 * buildbot/scripts/runner.py (TryOptions): add --builder,
2947 accumulate the values into opts['builders']
2948 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2949 * buildbot/test/test_runner.py (Try): add some quick tests to make
2950 sure 'buildbot try --options' and .buildbot/options get parsed
2951 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2952 use --builder control
2954 * docs/buildbot.texinfo (try): add --port argument to PB style
2956 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2957 actual SourceStamp. Still need to extract a branch name, somehow.
2958 (Try): finish implementing the try client side, still need a UI
2959 for specifying which builders to use
2960 (Try.getopt): factor our options/config-file reading
2961 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2963 * buildbot/test/test_vc.py: match SourceStampExtractor change
2965 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2966 causes the twisted log to be sent to stderr
2968 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2970 2005-08-10 Brian Warner <warner@lothar.com>
2972 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2973 style is 90% done, still missing status reporting or waiting for
2974 the buildsets to finish, and it is completely untested.
2976 * buildbot/trybuild.py: delete file, move contents to ..
2977 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2978 * buildbot/test/test_vc.py: match the move
2980 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2981 of the TryScheduler, no buildsetID or status-tracking support yet
2982 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2984 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2985 possible to set the basedir after __init__ time, so it is easier
2986 to use as a Service-child of the BuildMaster instance
2988 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2989 that delivers messages to its Service parent instead of requiring
2990 a subclass to be useful. This turns out to be much easier to build
2993 * buildbot/scripts/tryclient.py (createJob): utility code to
2994 create jobfiles, will eventually be used by 'buildbot try'
2996 2005-08-08 Brian Warner <warner@lothar.com>
2998 * docs/buildbot.texinfo (try): add docs on the
2999 as-yet-unimplemented Try scheduler
3001 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3002 * buildbot/test/test_scheduler.py: .. here
3003 (Scheduling.testTryJobdir): add placeholder test for 'try'
3005 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3006 addEntry merging (>=chunkSize) behavior
3007 (Log.testConsumer): update to handle new callLater(0) behavior
3009 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3010 both the MAX_LENGTH bugfix and the resumeProducing hang.
3012 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3013 put off the actual resumeProducing for a moment with
3014 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3015 causes large logfiles to hang midway through.
3017 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3018 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3019 and to improve memory usage when streaming the file out to a web
3021 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3022 make this work cleanly
3024 2005-08-03 Brian Warner <warner@lothar.com>
3026 * buildbot/trybuild.py: new file for 'try' utilities
3027 (getSourceStamp): run in a tree, find out the baserev+patch
3028 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3029 implemented for SVN and Darcs, still working on Arch. I don't know
3030 how to make CVS work yet.
3032 * docs/buildbot.texinfo: document the 'buildbot' command-line
3033 tool, including the not-yet-implemented 'try' feature, and the
3034 in-flux .buildbot/ options directory.
3036 2005-07-20 Brian Warner <warner@lothar.com>
3038 * buildbot/locks.py: added temporary id() numbers to Lock
3039 descriptions, to track down a not-really-sharing-the-Lock bug
3041 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3043 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3044 needed for python2.2 compatibility
3045 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3046 are from the __future__
3048 2005-07-19 Brian Warner <warner@lothar.com>
3050 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3051 message when schedulers use unknown builders
3053 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3054 SlaveLock('name') and MasterLock('name') are distinct
3056 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3057 c['schedulers'] in such a way that we can actually accept
3059 * buildbot/test/test_config.py: check it
3061 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3062 utility method to *all* the Schedulers
3063 (Periodic.listBuilderNames): same
3065 * docs/buildbot.texinfo (Interlocks): update chapter to match
3068 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3069 to make sure that c['sources'], c['schedulers'], and c['status']
3070 are all lists of the appropriate objects, and that the Schedulers
3071 all point to real Builders
3072 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3073 'listBuilderNames' utility method to support this
3074 * buildbot/scheduler.py: implement the utility method
3075 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3077 * docs/buildbot.texinfo: add some @cindex entries
3079 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3080 if it wasn't already set: most tla commands will fail unless one
3082 (Arch.createRepository): and disable bazaar's revision cache, since
3083 they cause test failures (the multiple repositories we create all
3084 interfere with each other through the cache)
3086 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3087 bring it properly up to date with twisted-2.0 test guidelines
3089 * buildbot/master.py (BuildMaster): remove references to old
3090 'interlock' module, this caused a bunch of post-merge test
3092 * buildbot/test/test_config.py: same
3093 * buildbot/process/base.py (Build): same
3095 * buildbot/test/test_slaves.py: stubs for new test case
3097 * buildbot/scheduler.py: add test-case-name tag
3098 * buildbot/test/test_buildreq.py: same
3100 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3101 unnecessary init code
3102 (Bot.remote_setBuilderList): match it
3104 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3106 * buildbot/changes/mail.py (parseSyncmail): update comment
3108 * buildbot/test/test_slavecommand.py: disable Shell tests on
3109 platforms that don't suport IReactorProcess
3111 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3112 all places where we open logfiles. It causes OS-X to open the file
3113 in some weird mode that that prevents us from mixing reads and
3114 writes to the same filehandle, which we depend upon to implement
3115 _generateChunks properly. This change doesn't appear to break
3116 win32, on which "b" and "t" are treated differently but a missing
3117 flag seems to be interpreted as "t".
3119 2005-07-18 Brian Warner <warner@lothar.com>
3121 * buildbot/slave/commands.py (ShellCommand): overhaul
3122 error-handling code, to try and make timeout/interrupt work
3123 properly, and make win32 happier
3124 * buildbot/test/test_slavecommand.py: clean up, stop using
3125 reactor.iterate, add tests for timeout and interrupt
3126 * buildbot/test/sleep.py: utility for a new timeout test
3128 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3129 code from the local-usebranches branch
3131 2005-07-17 Brian Warner <warner@lothar.com>
3133 * buildbot/process/process_twisted.py
3134 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3135 minutes, to match the other twisted BuildFactories, and don't
3136 excuse failures in c/qt/win32 reactors any more.
3138 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3139 'freebsd' builders, since the buildslaves have been unavailable
3142 2005-07-13 Brian Warner <warner@lothar.com>
3144 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3145 build-on-branch feature
3147 * buildbot/process/step.py (Darcs.__init__): add base_url and
3148 default_branch arguments, just like SVN
3149 (Arch.__init__): note that the version= argument is really the
3152 * buildbot/slave/commands.py (SourceBase): keep track of the
3153 repository+branch that was used for the last checkout in
3154 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3155 match, we clobber the directory and perform a fresh checkout
3156 rather than trying to do an in-place update. This should protect
3157 us against trying to get to branch B by doing an update in a tree
3158 obtained from branch A.
3159 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3160 (SVN.setup): same, just the svnurl
3161 (Darcs.setup): same, just the repourl
3162 (Arch.setup): same, arch coordinates (url), version, and
3163 buildconfig. Also pull the buildconfig from the args dictionary,
3164 which we weren't doing before, so the build-config was effectively
3166 (Arch.sourcedirIsUpdateable): don't try to update when we're
3167 moving to a specific revision: arch can't go backwards, so it is
3168 safer to just clobber the tree and checkout a new one at the
3170 (Bazaar.setup): same sourcedata as Arch
3172 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3173 use maybeWait, to work with twisted-1.3.0 and twcompat
3174 (Dependencies.testRun_Pass): same
3176 * buildbot/test/test_vc.py: rearrange, cleanup
3178 * buildbot/twcompat.py: add defer.waitForDeferred and
3179 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3180 can work under twisted-1.3.0 .
3182 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3183 now created at setUp time. This increases the runtime of the test
3184 suite considerably (from 91 seconds to 151), but it removes the
3185 need for an offline tarball, which should solve a problem I've
3186 seen where the test host has a different version of svn than the
3187 tarball build host. The new code also validates that mode=update
3188 really picks up recent commits. This approach will also make it
3189 easier to test out branches, because the code which creates the VC
3190 branches is next to the code which uses them. It will also make it
3191 possible to test some change-notification hooks, by actually
3192 performing a VC commit and watching to see the ChangeSource get
3195 2005-07-12 Brian Warner <warner@lothar.com>
3197 * docs/buildbot.texinfo (SVN): add branches example
3198 * docs/Makefile (buildbot.ps): add target for postscript manual
3200 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3201 * buildbot/test/test_locks.py: same
3203 * buildbot/process/step.py (Darcs): comment about default branches
3205 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3206 c['interlocks'] in the config file, complain if it is present.
3207 Scan all locks in c['builders'] to make sure the Locks they use
3209 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3210 add some tests to check for non-uniquely-named Locks
3211 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3212 since the unique-Lock validation code requires it now
3214 * buildbot/locks.py: fix test-case-name
3216 * buildbot/interlock.py: remove old file
3218 2005-07-11 Brian Warner <warner@lothar.com>
3220 * buildbot/test/test_interlock.py: rename to..
3221 * buildbot/test/test_locks.py: .. something shorter
3223 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3224 versions (after 2.0.1) changed internet.TCPClient to shut down the
3225 connection in stopService. Change the code to handle this
3228 * buildbot/process/base.py (Build): handle whole-Build locks
3229 * buildbot/process/builder.py (Builder.compareToSetup): same
3230 * buildbot/test/test_interlock.py: make tests work
3232 * buildbot/process/step.py (BuildStep.startStep): complain if a
3233 Step tries to claim a lock that's owned by its own Build
3234 (BuildStep.releaseLocks): typo
3236 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3237 file reloads don't replace unchanged Builders
3239 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3240 rewrite to cover new Locks instead of old c['interlocks']
3241 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3245 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3246 start the master and connect the buildslave
3248 * buildbot/process/step.py (FailingDummy.done): finish with a
3249 FAILURE status rather than raising an exception
3251 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3252 stringify a BuildRequest.reason that is None
3254 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3256 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3257 allow scheduler.Dependent to work
3258 * buildbot/buildset.py (BuildSet): set .reason and .results
3260 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3261 slaves, to make the test stop hanging. It still fails, of course,
3262 because I haven't even started to implement Locks.
3264 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3266 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3267 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3268 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3269 (Dependent): new class for downstream build dependencies
3270 * buildbot/test/test_dependencies.py: tests (still failing)
3272 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3274 2005-07-07 Brian Warner <warner@lothar.com>
3276 * buildbot/test/runutils.py (RunMixin): factored this class out..
3277 * buildbot/test/test_run.py: .. from here
3278 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3279 added new buildbot.locks tests (which all hang right now)
3280 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3281 * buildbot/process/step.py: claim/release per-BuildStep locks
3283 * docs/Makefile: add 'buildbot.html' target
3285 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3286 interpreted as "HEAD", so that all VC steps can accept branch=None
3287 and have it mean the "default branch".
3289 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3291 2005-07-07 Brian Warner <warner@lothar.com>
3293 * docs/examples/twisted_master.cfg: update to match current usage
3295 * docs/buildbot.texinfo (System Architecture): comment out the
3296 image, it doesn't exist yet and just screws up the HTML manual.
3298 2005-07-05 Brian Warner <warner@lothar.com>
3300 * debian/.cvsignore: oops, missed one. Removing leftover file.
3302 2005-06-17 Brian Warner <warner@lothar.com>
3304 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3305 changed its output in 1.2.0, don't mistakenly think that the
3306 subversion we find isn't capable of supporting our tests.
3308 * debian/*: remove the debian/ directory and its contents, to make
3309 life easier for the proper Debian maintainer
3311 * Makefile (release): same
3313 2005-06-07 Brian Warner <warner@lothar.com>
3315 * everything: create a distinct SourceStamp class to replace the
3316 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3317 Changed the signature of Source.startVC to include the revision
3318 information (instead of passing it through self.args). Implement
3319 branches for SVN (now only Darcs/Git is missing support). Add more
3322 2005-06-06 Brian Warner <warner@lothar.com>
3324 * everything: rearrange build scheduling. Create a new Scheduler
3325 object (configured in c['schedulers'], which submit BuildSets to a
3326 set of Builders. Builders can now use multiple slaves. Builds can
3327 be run on alternate branches, either requested manually or driven
3328 by changes. This changed some of the Status classes. Interlocks
3329 are out of service until they've been properly split into Locks
3330 and Dependencies. treeStableTimer, isFileImportant, and
3331 periodicBuild have all been moved from the Builder to the
3333 (BuilderStatus.currentBigState): removed the 'waiting' and
3334 'interlocked' states, removed the 'ETA' argument.
3336 2005-05-24 Brian Warner <warner@lothar.com>
3338 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3339 erroneously abandons the connection (in clientConnectionFailed)
3340 for non-UserErrors, which means that if we lose the connection due
3341 to a network problem or a timeout, we'll never try to reconnect.
3342 Fix this by not upcalling to the buggy parent method. Note:
3343 twisted-2.0 fixes this, but the function only has 3 lines so it
3344 makes more sense to copy it than to try and detect the buggyness
3345 of the parent class. Fixes SF#1207588.
3347 * buildbot/changes/changes.py (Change.branch): doh! Add a
3348 class-level attribute to accomodate old Change instances that were
3349 pickled before 0.6.5 (where .branch was added for new Changes).
3350 This fixes the exception that occurs when you try to look at an
3351 old Change (through asHTML).
3353 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3356 2005-05-23 Brian Warner <warner@lothar.com>
3358 * buildbot/__init__.py (version): release 0.6.6
3360 2005-05-23 Brian Warner <warner@lothar.com>
3362 * NEWS: update for 0.6.6 release
3363 * debian/changelog: same
3365 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3366 before starting: this was done by twistd back when we spawned it,
3367 now that we're importing the pieces and running them in the
3368 current process, we have to do it ourselves. This allows
3369 master.cfg to import files from the same directory without
3370 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3371 Stichele for the catch.
3372 (Options.opt_version): Add a --version command (actually, just make
3373 the existing --version command emit Buildbot's version too)
3375 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3376 fix to make this behave like other LogFiles, this time to handle
3377 existing LogFiles on disk. (add the missing .upgrade method)
3378 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3380 2005-05-21 Brian Warner <warner@lothar.com>
3382 * buildbot/test/test_runner.py (Create.testMaster): match the
3383 rawstring change in runner.py:masterTAC
3385 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3386 TwistedWords is installed
3387 * buildbot/test/test_status.py: same, with TwistedMail
3389 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3390 some old, deprecated, and removed config keys). This should enable
3391 you to use the base buildbot functionality with Twisted-2.0.0 when
3392 you don't also have TwistedWeb and TwistedWords installed
3394 2005-05-20 Brian Warner <warner@lothar.com>
3396 * buildbot/scripts/runner.py (run): call sendchange(), not
3397 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3398 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3399 (stop): don't wait for process to die when sending SIGHUP
3400 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3401 directory name gets interpreted, which you don't want
3404 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3407 2005-05-18 Brian Warner <warner@lothar.com>
3409 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3411 2005-05-18 Brian Warner <warner@lothar.com>
3413 * README: update for 0.6.5
3414 * debian/changelog: same
3416 * buildbot/changes/changes.py: rename tag= to branch=, since
3417 that's how we're using it, and my design for the upcoming "build a
3418 specific branch" feature wants it. also, tag= was too CVS-centric
3419 * buildbot/changes/mail.py (parseSyncmail): same
3420 * buildbot/process/base.py (Build.isBranchImportant): same
3421 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3422 * docs/buildbot.texinfo (Attributes of Changes): same
3424 * NEWS: update tag=, update for upcoming release
3426 2005-05-17 Brian Warner <warner@lothar.com>
3428 * buildbot/scripts/runner.py (stop): actually poll once per
3429 second, instead of re-killing the poor daemon once per second.
3430 Sleep briefly (0.1s) before the first poll, since there's a good
3431 chance we can avoid waiting the full second if the daemon shuts
3432 down quickly. Also remove the sys.exit() at the end.
3433 (start): remove the unneighborly sys.exit()
3435 * Makefile: improve permission-setting to not kick Arch so badly
3437 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3438 default --keepalive=600, since it doesn't hurt very much, and it's
3439 a hassle to discover that you need it.
3440 * buildbot/test/test_runner.py (Create.testSlave): test it
3442 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3443 IRC bot about EXCEPTION
3445 * buildbot/status/client.py (PBListener): upcall more correctly
3447 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3448 an exception mark the overall build with EXCEPTION, not SUCCESS
3450 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3452 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3453 * Makefile: update some release-related stuff
3455 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3456 gets called when there isn't actually an active process, just end
3457 the Command instead of blowing up. I don't know how it gets into
3458 this state, but the twisted win32 buildslave will sometimes hang,
3459 and when it shakes its head and comes back, it thinks it's still
3460 running a Command. The next build causes this command to be
3461 interrupted, but the lack of self.process.pid breaks the interrupt
3464 * NEWS: document changes since the last release
3466 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3467 look for Makefile.buildbot instead of a bare Makefile . The
3468 'buildbot start' does not install this file, so you have to
3469 manually copy it if you want to customize startup behavior.
3470 (createMaster): change 'buildbot master' command to create
3471 Makefile.sample instead of Makefile, to create master.cfg.sample
3472 instead of master.cfg (requiring you to copy it before the
3473 buildmaster can be started). Both sample files are kept up to
3474 date, i.e. they are overwritten if they have been changed. The
3475 'buildbot.tac' file is *not* overwritten, but if the new contents
3476 don't match the old, a 'buildbot.tac.new' file is created and the
3477 user is warned. This seems to be a much more sane way to handle
3478 startup files. Also, don't sys.exit(0) when done, so we can run
3479 unit tests against it.
3480 (createSlave): same. Don't overwrite the sample info/ files.
3481 * buildbot/scripts/sample.mk: remove. the contents were pulled
3482 into runner.py, since they need to match the behavior of start()
3486 * docs/buildbot.texinfo (Launching the daemons): document it
3487 * buildbot/test/test_runner.py (Create): test it
3489 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3490 version that can handle string-in-string tests, because otherwise
3491 python-2.2 fails the tests. It'd be tremendous if Trial's test
3492 took two strings under 2.2 too.
3494 * everything: fixed all deprecation warnings when running against
3495 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3496 few that come from Twisted itself). This involved putting most of
3497 the Twisted-version specific code in the new buildbot.twcompat
3498 module, and creating some abstract base classes in
3499 buildbot.changes.base and buildbot.status.base (which might be
3500 useful anyway). __implements__ is a nuisance and requires an ugly
3501 'if' clause everywhere.
3503 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3504 delay before finishing the test: it seems that smtp.sendmail
3505 doesn't hang up on the server, so we must wait a moment so it can
3506 hang up on us. This removes the trial warning about an unclean
3509 2005-05-16 Brian Warner <warner@lothar.com>
3511 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3512 tuple of (delay, repeats).
3513 * buildbot/test/test_vc.py (Retry): test it
3514 * docs/buildbot.texinfo (Source Checkout): document it
3515 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3516 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3517 doVCFull() are handled by re-trying the checkout (after a delay)
3518 some number of times.
3519 (ShellCommand._startCommand): make header lines easier to read
3521 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3523 (WebTest.test_logfile): make sure master gets shut down, silences
3524 some "unclean reactor" test errors
3526 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3527 reactor once after shutdown, something in certain versions of
3528 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3529 fails, svn-trunk is ok.
3531 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3532 second win32 error message
3534 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3535 validating the ETA, so the tests don't fail on slow systems
3537 2005-05-15 Brian Warner <warner@lothar.com>
3539 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3540 the new LogFile class, so upgrading works properly
3541 (LogFileProducer.resumeProducing): survive resumeProducing after
3542 we've exhausted the chunkGenerator
3544 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3546 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3547 (Log.testUpgrade): same
3549 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3550 Builds and logs with a cron job.
3552 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3553 of the old non-offline LogFile, added code to upgrade these to
3554 new-style contents-live-on-disk instances at load time (in a way
3555 that doesn't invalidate the old Build pickles, so upgrading to
3556 0.6.5 is not a one-way operation). Got rid of everything related
3558 (LogFile.__init__): create LogFiles with the parent step status,
3559 the log's name, and a builder-relative filename where it can keep
3560 the contents on disk.
3561 (LogFile.hasContents): new method, clients are advised to call it
3562 before getText or getChunks and friends. If it returns False, the
3563 log's contents have been deleted and getText() will raise an
3565 (LogFile.getChunks): made it a generator
3566 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3567 Consumer (except one that takes chunks instead of strings). This
3568 enables streaming of very large logfiles without storing the whole
3570 (BuildStatus.generateLogfileName): create names like
3571 12-log-compile-output, with a _0 suffix if required to be unique
3572 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3573 or earlier) logfiles into new-style ones
3574 (BuilderStatus): remove everything related to 'stub' builds. There
3575 is now only one build cache, and we don't strip logs from old
3577 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3578 since we no longer fight to keep it in the cache
3580 * buildbot/status/html.py (TextLog.render_GET): use a
3581 ChunkConsumer to stream the log entries efficiently.
3582 (ChunkConsumer): wrapper which consumes chunks and writes
3585 * buildbot/test/test_twisted.py (Parse.testParse): use a
3586 LogFile-like object instead of a real one
3588 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3589 (Log.testMerge3): validate more merge behavior
3590 (Log.testChunks): validate LogFile.getChunks
3591 (Log.testUpgrade): validate old-style LogFile upgrading
3592 (Log.testSubscribe): validate LogFile.subscribe
3593 (Log.testConsumer): validate LogFile.subscribeConsumer
3595 * buildbot/interfaces.py (IStatusLogStub): remove
3596 (IStatusLog.subscribeConsumer): new method
3597 (IStatusLog.hasContents): new method
3598 (IStatusLogConsumer): describes things passed to subscribeConsumer
3600 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3601 the log contents if it does not have any contents.
3602 (StatusResourceBuildStep.body): same
3603 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3605 2005-05-14 Brian Warner <warner@lothar.com>
3607 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3608 timeouts to try and make the windows metabuildslave not hang
3610 2005-05-13 Mike Taylor <bear@code-bear.com>
3612 * buildbot/slave/commands.py (rmdirRecursive): added a check
3613 to ensure the path passed into rmdirRecursive actually exists.
3614 On win32 a non-existant path would generate an exception.
3616 2005-05-13 Brian Warner <warner@lothar.com>
3618 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3619 shutil.rmtree which behaves correctly on windows in the face of
3620 files that you have to chmod before deleting. Thanks to Bear at
3621 the OSAF for the routine.
3622 (SourceBase.doClobber): use rmdirRecursive
3624 2005-05-12 Brian Warner <warner@lothar.com>
3626 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3627 method generate chunks instead of returning a big list. This
3628 allows the same method to be used for both old LogFile and new
3630 (OfflineLogFile.getText): use the generator
3631 (OfflineLogFile.subscribe): same
3632 * buildbot/status/html.py (TextLog.resumeProducing): same
3633 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3635 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3636 point out that OfflineLogFile does not currently work with
3637 html.Waterfall . Fixing this is high-priority.
3639 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3640 apparently windows defaults to using stdout
3642 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3643 better message on failure so I can figure out the win32 problem
3645 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3646 log messages to include more useful copies of the command being
3647 run, the argv array, and the child command's environment.
3648 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3650 2005-05-11 Brian Warner <warner@lothar.com>
3652 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3654 * Makefile: update the deb-snapshot version
3656 * docs/buildbot.texinfo: move all .xhtml docs into a new
3657 .texinfo-format document, adding a lot of material in the process.
3658 This is starting to look like a real user's manual. Removed all
3659 the Lore-related files: *.xhtml, *.css, template.tpl .
3660 * docs/Makefile: simple makefile to run 'makeinfo'
3661 * buildbot/scripts/sample.cfg: rearrange slightly
3662 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3664 2005-05-10 Brian Warner <warner@lothar.com>
3666 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3667 different name for the internal twistw module, handle it.
3669 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3670 * setup.py: .. and stop trying to install it
3672 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3673 'git'), the new linux kernel VC system (http://kernel.org/git/).
3674 Thanks to Brandon Philips for the patch.
3675 * buildbot/slave/commands.py (Git): same
3677 2005-05-06 Brian Warner <warner@lothar.com>
3679 * buildbot/status/builder.py (OfflineLogFile): replace the default
3680 LogFile with a form that appends its new contents to a disk file
3681 as they arrive. The complete log data is never kept in RAM. This
3682 is the first step towards handling very large (100MB+) logfiles
3683 without choking quite so badly. (The other half is
3684 producer/consumer on the HTML pages).
3685 (BuildStepStatus.addLog): use OfflineLogFile by default
3686 (BuildStatus.getLogfileName): helper code to give the
3687 OfflineLogFile a filename to work with
3689 * buildbot/test/test_status.py (Results.testAddResults): update
3690 tests to handle new asserts
3691 * buildbot/test/test_vc.py (Patch.doPatch): same
3692 * buildbot/test/test_steps.py (BuildStep.setUp): same
3694 2005-05-05 Brian Warner <warner@lothar.com>
3696 * buildbot/scripts/runner.py (start): if there is no Makefile,
3697 launch the app by importing twistd's internals and calling run(),
3698 rather than spawning a new twistd process. This stands a much
3699 better chance of working under windows.
3700 (stop): kill the process with os.kill instead of spawning
3701 /bin/kill, again to reduce the number of external programs which
3702 windows might not have in the PATH. Also wait up to 5 seconds for
3703 the process to go away, allowing things like 'buildbot stop;
3704 buildbot start' to be reliable in the face of slow shutdowns.
3706 * buildbot/master.py (Dispatcher.__getstate__): remove old
3707 .tap-related methods
3708 (BuildMaster.__getstate__): same
3710 * buildbot/slave/bot.py (makeService): same
3711 (Options.longdesc): same
3712 * buildbot/scripts/runner.py: copy over some old mktap option text
3714 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3715 'buildbot master' now creates a buildbot.tac file, so there is no
3716 longer a create-instance/save/reload sequence. mktap is dead, long
3718 * buildbot/scripts/sample.mk: use twistd -y, not -f
3719 * buildbot/test/test_config.py: remove mktap-based test
3720 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3721 * README: don't reference mktap
3723 * docs/source.xhtml: document some of the attributes that Changes
3726 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3728 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3729 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3730 * buildbot/changes/changes.py (Change)
3731 * buildbot/changes/mail.py (parseSyncmail)
3732 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3734 * buildbot/process/base.py (Build.isTagImportant)
3738 2005-05-04 Brian Warner <warner@lothar.com>
3740 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3741 connection after sending the change, so that unit tests don't
3742 complain about sockets being left around
3744 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3745 exception in phase=0 rendering
3746 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3748 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3750 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3751 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3752 and configuring builders with tuples.
3753 * buildbot/test/test_config.py: stop testing compatibility with
3754 deprecated config keys
3755 * buildbot/test/test_run.py: same
3757 2005-05-03 Brian Warner <warner@lothar.com>
3759 * contrib/arch_buildbot.py: survive if there are no logfiles
3760 (username): just use a string, os.getlogin isn't reliable
3762 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3763 so 'buildbot sendchange' actually works. The earlier test only
3764 covered the internal (non-reactor-running) form.
3766 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3767 script to notify the buildmaster about changes
3769 * buildbot/scripts/runner.py (sendchange): new command to send a
3770 change to a buildbot.changes.pb.PBChangeSource receiver.
3771 * buildbot/test/test_changes.py (Sender): test it
3773 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3774 after any reading of the config file, not just when we do it in
3775 startService. This makes some tests a bit cleaner.
3777 * buildbot/changes/pb.py: add some log messages
3779 * buildbot/process/base.py (Build.startBuild): fix a bug that
3780 caused an exception when the build terminated in the very first
3782 (Build.stepDone): let steps return a status of EXCEPTION. This
3783 terminates the build right away, and sets the build's overall
3784 status to EXCEPTION too.
3785 * buildbot/process/step.py (BuildStep.failed): return a status of
3786 EXCEPTION when that is what has happened.
3788 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3789 implement this, allowing Arch-based projects to get precise
3790 checkouts instead of always using the latest code
3791 (Bazaar): create variant of Arch to let folks use baz instead of
3792 tla. Requires a new buildslave too.
3793 * buildbot/slave/commands.py (Arch): add 'revision' argument
3794 (Bazaar): create variant of Arch that uses baz instead of tla.
3795 Remove the code that extracts the archive name from the
3796 register-archive output, since baz doesn't provide it, and require
3797 the user provide both the archive name and its location.
3798 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3800 2005-05-02 Brian Warner <warner@lothar.com>
3802 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3803 thanks to Nick Trout.
3805 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3806 deals better with source Makefile coming from a read-only CVS
3807 checkout. Thanks to Nick Trout for the catch.
3809 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3812 2005-04-28 Brian Warner <warner@lothar.com>
3814 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3816 * debian/changelog: update for 0.6.4
3818 2005-04-28 Brian Warner <warner@lothar.com>
3820 * README.w32: add a checklist of steps for getting buildbot
3822 * MANIFEST.in: include it in the tarball
3826 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3827 broken .tap files from 0.6.3 by getting rid of .services,
3828 .namedServices, and .change_svc at load time.
3830 2005-04-27 Brian Warner <warner@lothar.com>
3832 * NEWS: update in preparation for new release
3834 * buildbot/test/test_config.py (Save.testSave): don't pull in
3835 twisted.scripts.twistd, we don't need it and it isn't for windows
3838 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3839 accomodate win32 which can't do atomic-rename
3841 2005-04-27 Brian Warner <warner@lothar.com>
3843 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3844 timeouts to help the slow metabuildbot not flunk them so much
3845 (Disconnect.testBuild3): same
3846 (Disconnect.testBuild4): same
3847 (Disconnect.testInterrupt): same
3849 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3850 setup, it was completely broken for new buildmasters (those which
3851 did not have a 'change.pck' already saved. Thanks to Paul Warren
3852 for catching this (embarrassing!) bug.
3853 (Dispatcher.__getstate__): don't save our registered avatar
3854 factories, since they'll be re-populated when the config file is
3856 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3857 tests (since the real mktap-generated BuildMaster doesn't save
3859 (BuildMaster.__getstate__): don't save any service children,
3860 they'll all be re-populated when the config file is re-read.
3861 * buildbot/test/test_config.py (Save.testSave): test for this
3863 2005-04-26 Brian Warner <warner@lothar.com>
3865 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3866 rendered with Blender.. looks a bit nicer.
3867 * buildbot/docs/images/icon.blend: add the Blender file for it
3869 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3870 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3871 running under windows. This appears to be the best way to allow
3872 BuildSteps to do something normal like 'trial -v buildbot.test' or
3873 'make foo' and still expect it to work. The idea is to make the
3874 BuildSteps look as much like what a developer would type when
3875 compiling or testing the tree by hand. This approach probably has
3876 problems when there are spaces in the arguments, so if you've got
3877 windows buildslaves, you'll need to pay close attention to your
3880 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3881 timezone to the timestamp column.
3882 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3884 * buildbot/scripts/runner.py (loadOptions): do something sane for
3885 windows, I think. We use %APPDATA%/buildbot instead of
3886 ~/.buildbot, but we still search everywhere from the current
3887 directory up to the root for a .buildbot/ subdir. The "is it under
3888 $HOME" security test was replaced with "is it owned by the current
3889 user", which is only performed under posix.
3890 * buildbot/test/test_runner.py (Options.testFindOptions): update
3891 tests to match. The "is it owned by the current user" check is
3892 untested. The test has been re-enabled for windows.
3894 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3895 any "\n" in the expected output with the platform-specific line
3896 separator. Make this separator "\r\n" on PTYs under unix, they
3897 seem to do that and I don't know why
3899 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3900 windows for now, I don't know what ~/.buildbot/ should mean there.
3902 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3903 win32 compatibility, don't use "/tmp"
3904 (Basedir.testChangeBuilddir): remove more unixisms
3906 2005-04-26 Brian Warner <warner@lothar.com>
3908 * buildbot/test/test_control.py (Force.rmtree): python2.2
3909 compatibility, apparently its shutil.rmtree ignore_errors=
3910 argument is ignored.
3911 * buildbot/test/test_run.py (Run.rmtree): same
3912 (RunMixin.setUp): same
3914 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3917 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3918 'substring in string' operator, must use string.find(substr)!=-1
3919 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3920 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3922 * buildbot/scripts/runner.py (loadOptions): add code to search for
3923 ~/.buildbot/, a directory with things like 'options', containing
3924 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3925 the current directory, your $HOME directory, or anywhere
3926 inbetween, as long as you're somewhere inside your home directory.
3927 (debugclient): look in ~/.buildbot/options for master and passwd
3928 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3929 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3931 * buildbot/status/client.py (makeRemote): new approach to making
3932 IRemote(None) be None, which works under Twisted-2.0
3933 * buildbot/test/test_status.py (Client.testAdaptation): test it
3935 * buildbot/status/builder.py (Status.builderAdded): when loading a
3936 pickled BuilderStatus in from disk, set its name after loading.
3937 The config file might have changed its name (but not its
3938 directory) while it wasn't looking.
3940 * buildbot/process/builder.py (Builder.attached): always return a
3941 Deferred, even if the builder was already attached
3942 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3944 2005-04-25 Brian Warner <warner@lothar.com>
3946 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3947 category-related exception when announcing a build has finished
3949 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3950 reference no-longer-existent changemaster.sources
3951 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3953 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3956 2005-04-25 Brian Warner <warner@lothar.com>
3958 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3960 * debian/changelog: update for 0.6.3
3962 2005-04-25 Brian Warner <warner@lothar.com>
3964 * MANIFEST.in: make sure debug.glade is in the tarball
3966 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3968 * NEWS: update for the imminent 0.6.3 release
3970 * buildbot/status/html.py (HtmlResource.content): make the
3971 stylesheet <link> always point at "buildbot.css".
3972 (StatusResource.getChild): map "buildbot.css" to a static.File
3973 containing whatever css= argument was provided to Waterfall()
3974 (Waterfall): provide the "classic" css as the default.
3975 * docs/waterfall.classic.css: move default CSS from here ..
3976 * buildbot/status/classic.css: .. to here
3978 * MANIFEST.in: make sure classic.css is included in the tarball
3979 * setup.py: and that it is installed too, under buildbot/status/
3981 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3982 the module level, because buildbot.tap files from 0.6.2 don't have
3983 it in their attribute dictionary.
3985 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3986 really exists at startup, might save some confusion somewhere.
3988 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3990 * docs/waterfall.classic.css:
3991 add a stylesheet that's almost the same as the "classic"
3994 * buildbot/status/builder.py:
3995 add EXCEPTION as a result - this is a problem for the bot
3996 maintainer, not a build problem for the changers
3997 * buildbot/process/step.py:
3998 use EXCEPTION instead of FAILURE for exceptions
3999 * buildbot/status/html.py:
4000 add build_get_class to get a class out of a build/buildstep
4001 finish naming the classes
4002 split out sourceNames to changeNames and builderNames so we
4003 can style them separately
4004 * docs/config.xhtml:
4005 finish documenting classes as they are right now
4007 * buildbot/status/html.py:
4008 name the classes as we agreed on IRC
4009 * docs/config.xhtml:
4012 * buildbot/status/html.py:
4013 same for cssclass->class_
4015 * buildbot/status/html.py:
4016 as decided on IRC, use class_ for the "class" attribute to not
4017 conflict with the class keyword, and clean up the messy **{} stuff.
4019 * buildbot/status/mail.py:
4020 put back "builders" argument, and fix docstring, because the
4021 code *ignores* builders listed in this argument
4023 * buildbot/process/builder.py:
4024 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4026 * docs/config.xhtml:
4027 describe the category argument for builders
4029 * buildbot/status/builder.py:
4030 Fix a silly bug due to merging
4032 * buildbot/process/builder.py:
4033 remove category from the process Builder ...
4034 * buildbot/status/builder.py:
4035 ... and add it to BuilderStatus instead.
4036 Set category on unpickled builder statuses, they might not have it.
4037 * buildbot/master.py:
4038 include category when doing builderAdded
4039 * buildbot/status/mail.py:
4040 return None instead of self for builders we are not interested in.
4041 * buildbot/test/test_run.py:
4042 fix a bug due to only doing deferredResult on "dummy" waiting
4043 * buildbot/test/test_status.py:
4044 add checks for the Mail IStatusReceiver returning None or self
4046 * buildbot/status/html.py:
4047 fix testsuite by prefixing page title with BuildBot
4049 * buildbot/status/builder.py:
4050 have .category in builder status ...
4051 * buildbot/process/builder.py:
4052 ... and set it from Builder
4053 * buildbot/status/html.py:
4054 make .css a class variable
4055 * buildbot/test/test_status.py:
4056 write more tests to cover our categories stuff ...
4057 * buildbot/status/mail.py:
4058 ... and fix the bug that this uncovered
4060 * buildbot/changes/mail.py:
4061 * buildbot/changes/pb.py:
4062 * buildbot/master.py:
4063 * buildbot/process/base.py:
4064 * buildbot/process/factory.py:
4065 * buildbot/process/interlock.py:
4066 * buildbot/process/step.py:
4067 * buildbot/process/step_twisted.py:
4068 * buildbot/slave/commands.py:
4069 * buildbot/status/builder.py:
4070 * buildbot/status/client.py:
4071 * buildbot/status/html.py:
4072 * buildbot/status/mail.py:
4073 * buildbot/status/progress.py:
4074 * buildbot/test/test_changes.py:
4075 * buildbot/test/test_config.py:
4076 * buildbot/test/test_control.py:
4077 * buildbot/test/test_interlock.py:
4078 * buildbot/test/test_maildir.py:
4079 * buildbot/test/test_mailparse.py:
4080 * buildbot/test/test_run.py:
4081 * buildbot/test/test_slavecommand.py:
4082 * buildbot/test/test_status.py:
4083 * buildbot/test/test_steps.py:
4084 * buildbot/test/test_twisted.py:
4085 * buildbot/test/test_util.py:
4086 * buildbot/test/test_vc.py:
4087 * buildbot/test/test_web.py:
4089 add test-case-name at the top of a whole set of files
4091 * buildbot/status/builder.py:
4092 keep order of addition when getting builder names
4093 * buildbot/status/words.py:
4094 * buildbot/test/test_run.py:
4095 add test for getBuilderNames
4097 * buildbot/process/base.py:
4098 * buildbot/process/step.py:
4099 * buildbot/status/builder.py:
4100 * buildbot/status/html.py:
4101 make buildbot css-able
4102 replace the color code for purple with purple, don't understand
4103 why it wasn't purple to start with
4105 * buildbot/status/words.py:
4106 ok, so it doesn't look like BuilderStatus.remote is still valid.
4107 Use what waterfall uses instead.
4109 * buildbot/interfaces.py:
4110 * buildbot/status/builder.py:
4111 * buildbot/status/html.py:
4112 * buildbot/status/mail.py:
4113 * buildbot/status/words.py:
4114 * buildbot/test/test_run.py:
4115 use categories everywhere and make it be a list. More sensible
4116 for the future. Also make words actually respect this in
4119 * buildbot/interfaces.py:
4120 add category argument to getBuilderNames
4121 * buildbot/process/builder.py:
4122 * buildbot/status/builder.py:
4123 * buildbot/status/html.py:
4124 * buildbot/status/mail.py:
4125 * buildbot/status/words.py:
4126 * buildbot/test/test_run.py:
4127 move from specifying builders by name to specifying the category
4129 * buildbot/status/html.py:
4130 * buildbot/status/words.py:
4131 add "builders=" to __init__ of status clients so they can
4132 limit themselves to the given list of builders to report on
4134 * buildbot/status/html.py: set the title to the product name
4136 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4138 * buildbot/interfaces.py:
4139 * buildbot/status/builder.py:
4140 more documentation. Hm, not sure if ChangeLog entries make sense
4143 2005-04-23 Brian Warner <warner@lothar.com>
4145 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4147 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4149 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4150 the sub-commands that log buildmaster status to stdout and to a
4151 GUI window, respectively.
4153 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4154 functionality is working again, but all the step-status and ETA
4155 stuff is missing. Commented out a lot of code pending more
4158 * buildbot/status/client.py: make sure that IRemote(None) is None
4160 * buildbot/changes/changes.py: import defer, oops
4161 (ChangeMaster): remove the .sources list, rely upon the fact that
4162 MultiServices can be treated as sequences of their children. This
4163 cleans up the add/remove ChangeSource routines a lot, as we keep
4164 exactly one list of the current sources instead of three.
4166 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4167 up an empty ChangeMaster at init time.
4168 (BuildMaster.loadChanges): if there are changes to be had from
4169 disk, replace self.change_svc with the new ones. If not, keep
4170 using the empty ChangeMaster set up in __init__.
4171 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4172 instead of a separate list, makes the code a bit cleaner.
4173 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4174 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4175 Extend the test to make sure we can get rid of the sources when
4178 2005-04-22 Brian Warner <warner@lothar.com>
4180 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4181 and info/host files when making the slave directory
4183 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4184 whendone= argument, just return the Deferred and let the caller do
4185 what they want with it.
4186 (Disconnect.testBuild1): wait for shutdownSlave
4187 (Basedir.testChangeBuilddir): new test to make sure changes to the
4188 builddir actually get propagated to the slave
4190 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4191 explicit method, rather than passing the builddir in __init__ .
4192 Make sure to update self.basedir too, this was broken before.
4193 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4194 builders and for ones that have just had their builddir changed.
4195 (BotFactory): add a class-level .perspective attribute, so
4196 BuildSlave.waitUntilDisconnected won't get upset when the
4197 connection hasn't yet been established
4198 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4199 tests can reach through it to inspect the SlaveBuilders
4201 * buildbot/process/base.py (Build.buildException): explain the
4202 log.err with a log.msg
4203 * buildbot/process/builder.py (Builder.startBuild): same
4204 (Builder._startBuildFailed): improve error message
4206 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4207 occurred because we lost the brand-new connection, retry instead
4208 of giving up. If not, it's probably an authorization failure, and
4209 it makes sense to stop trying. Make sure we log.msg the reason
4210 that we're log.err'ing the failure, otherwise test failures are
4211 really hard to figure out.
4213 * buildbot/master.py: change loadConfig() to return a Deferred
4214 that doesn't fire until the change has been fully implemented.
4215 This means any connected slaves have been updated with the new
4216 builddir. This change makes it easier to test the code which
4217 actually implements this builddir-updating.
4218 (BotPerspective.addBuilder): return Deferred
4219 (BotPerspective.removeBuilder): same
4220 (BotPerspective.attached): same
4221 (BotPerspective._attached): same. finish with remote_print before
4222 starting the getSlaveInfo, instead of doing them in parallel
4223 (BotPerspective.list_done): same
4224 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4225 actually calling slave.disconnect()
4226 (BotMaster.addBuilder): same
4227 (BotMaster.removeBuilder): same
4228 (BuildMaster.loadConfig): same
4229 (BuildMaster.loadConfig_Slaves): same
4230 (BuildMaster.loadConfig_Sources): same
4231 (BuildMaster.loadConfig_Builders): same
4232 (BuildMaster.loadConfig_status): same
4234 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4235 a Deferred that fires when the source is finally removed
4237 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4238 the previous tree on win32, where we have to do it synchronously,
4239 make sure we return a Deferred anyway.
4240 (SourceBase.doCopy): same
4242 * buildbot/scripts/runner.py (statusgui): use the text client for
4243 now, while I rewrite the Gtk one
4244 * buildbot/clients/base.py: strip out old code, leaving just the
4245 basic print-message-on-event functionality. I also remove the
4246 ReconnectingPBClientFactory, but it does at least quit when it
4247 loses the connection instead of going silent
4249 2005-04-21 Brian Warner <warner@lothar.com>
4251 * Makefile: minor tweaks
4253 * NEWS: point out deprecation warnings, new features for
4256 * buildbot/master.py (BuildMaster.loadConfig): emit
4257 DeprecationWarnings for Builders defined with tuples. Rearrange
4258 code to facility removal of deprecated configuration keys in the
4261 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4262 'buildbot' command to put a little Makefile in the target that
4263 helps you re-create the buildbot.tap file, start or stop the
4264 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4265 all the files 0600, since they contain passwords.
4266 (start): if there is a Makefile, and /usr/bin/make exists, use
4267 'make start' in preference to a raw twistd command. This lets
4268 slave admins put things like PYTHONPATH variables in their
4269 Makefiles and have them still work when the slave is started with
4270 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4271 be nice to first try the 'make' command and only fall back to
4272 twistd if it fails. TODO: the Makefile's "start" command does not
4273 add the --reactor=win32 argument when running under windows.
4274 (Options.debugclient, Options.statusgui): add sub-commands to launch
4275 the debug client (formerly in contrib/debugclient.py) and the
4276 Gtk status application (currently broken)
4277 * buildbot/clients/debug.py: move from contrib/debugclient.py
4278 * buildbot/clients/debug.glade: same
4280 * buildbot/test/test_trial.py: remove it. This requires some
4281 functionality out of Twisted that isn't there yet, and until then
4282 having it around just confuses things.
4284 * buildbot/test/test_slavecommand.py (Shell): test both with and
4285 without PTYs, and make sure that command output is properly
4286 interleaved in the with-PTY case. I think the without-PTY test
4287 should pass on windows, where we never use PTYs anyway.
4289 2005-04-20 Brian Warner <warner@lothar.com>
4291 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4293 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4295 * NEWS: start creating entries for the next release
4297 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4299 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4300 (WebTest.test_webPathname): same
4301 (WebTest.test_webPathname_port): same
4302 (WebTest.test_waterfall): use the default favicon rather than
4303 rooting around the filesystem for it. Open the expected-icon file
4304 in binary mode, to make win32 tests happier (thanks to Nick Trout
4306 * buildbot/status/html.py (buildbot_icon): win32 portability
4308 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4309 win32-compatibility fixes from Nick Trout, the "file not found" message
4310 is different under windows
4311 (FakeSlaveBuilder.__init__): clean up setup a bit
4312 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4314 2005-04-19 Brian Warner <warner@lothar.com>
4316 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4317 skip-if-repositories-are-unavailable test to not kill the trial
4318 that comes with Twisted-1.3.0
4320 * setup.py: install buildbot.png icon file when installing code
4322 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4323 environment used by the command, at least on the child side.
4325 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4326 this method needs to be added and implemented because it gets
4327 called under heavy load. I don't quite understand the
4328 producer/consumer API enough to write it.
4329 (StatusResource.getChild): add a resource for /favicon.ico
4330 (Waterfall.__init__): add favicon= argument
4331 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4332 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4333 (WebTest.test_webPathname): same
4334 (WebTest.test_webPathname_port): same
4335 * docs/config.xhtml: mention favicon=
4336 * buildbot/buildbot.png: add a default icon, dorky as it is
4338 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4340 * buildbot/master.py:
4341 * buildbot/process/base.py:
4342 * buildbot/process/builder.py:
4343 * buildbot/process/interlock.py:
4344 * buildbot/status/builder.py:
4345 * buildbot/status/html.py:
4346 * buildbot/status/mail.py:
4347 * buildbot/status/words.py:
4348 new documentation while digging through the code
4350 2005-04-17 Brian Warner <warner@lothar.com>
4352 * general: try to fix file modes on all .py files: a+r, a-x,
4353 but let buildbot/clients/*.py be +x since they're tools
4355 * docs/epyrun (addMod): when an import fails, say why
4357 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4359 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4361 * buildbot/process/base.py:
4362 * buildbot/process/builder.py:
4363 * buildbot/status/builder.py:
4364 new documentation while digging through the code
4366 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4368 * buildbot/changes/changes.py:
4369 * buildbot/changes/p4poller.py:
4370 * buildbot/interfaces.py:
4371 * buildbot/process/base.py:
4372 * buildbot/process/builder.py:
4373 * buildbot/process/step.py:
4374 * buildbot/process/step_twisted.py:
4375 * buildbot/slave/bot.py:
4376 * buildbot/slave/commands.py:
4377 * buildbot/status/builder.py:
4378 fix all docstrings to make epydoc happy. In the process of fixing
4379 some, I also moved pieces of docs, and removed some deprecated
4382 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4384 * buildbot/process/builder.py:
4385 * buildbot/process/interlock.py:
4386 * buildbot/process/process_twisted.py:
4387 * buildbot/process/step.py:
4388 BuildProcess -> Build, as it looks like that's what happened
4389 * buildbot/process/base.py:
4390 * buildbot/process/factory.py:
4393 2005-04-17 Brian Warner <warner@lothar.com>
4395 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4396 update compile command to accomodate the Twisted split.. now
4397 instead of './setup.py build_ext -i', you do './setup.py all
4398 build_ext -i', to run build_ext over all sub-projects.
4399 (FullTwistedBuildFactory): same
4400 (TwistedReactorsBuildFactory): same
4402 * buildbot/status/html.py (TextLog.finished): null out self.req
4403 when we're done, otherwise the reference cycle of TextLog to .req
4404 to .notifications to a Deferred to TextLog.stop keeps them from
4405 being collected, and consumes a huge (610MB on pyramid at last
4406 check) amount of memory.
4408 2005-04-11 Brian Warner <warner@lothar.com>
4410 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4411 normalize the VC-repository location.. makes SVN happier with
4412 certain test environments.
4414 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4415 RemoteShellCommand gets its own .env dictionary, so that code in
4416 start() doesn't mutate the original. I think this should fix the
4417 step_twisted.Trial problem where multiple identical components
4418 kept getting added to PYTHONPATH= over and over again.
4420 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4421 adding epydoc-format docstrings to many classes. Thanks to Thomas
4422 Vander Stichele for the patches.
4423 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4424 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4425 * buildbot/slave/bot.py, commands.py, registry.py: same
4427 2005-04-05 Brian Warner <warner@lothar.com>
4429 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4430 preserve timestamps, helps incremental builds of large trees.
4431 Patch from Rene Rivera.
4433 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4434 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4437 2005-04-03 Brian Warner <warner@lothar.com>
4439 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4440 with one dict, apparently exec has some scoping bugs when used
4441 with both global/local dicts. Thanks to Nathaniel Smith for the
4444 2005-04-02 Brian Warner <warner@lothar.com>
4446 * buildbot/process/step_twisted.py (countFailedTests): the new
4447 trial in Twisted-2.0 emits a slightly different status line than
4448 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4449 mistakenly think the test count is unparseable.
4450 (Trial.start): note that for some reason each build causes another
4451 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4452 be fixed but I'm not sure quite where the problem is.
4454 2005-04-01 Brian Warner <warner@lothar.com>
4456 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4457 deferredResult to avoid hangs/warnings under twisted-2.0
4458 (RunMixin.tearDown): same
4459 (RunMixin.shutdownSlave): same
4460 (Disconnect.testIdle1): same
4461 (Disconnect.testBuild2): same: wait one second after the build
4462 finishes for test to really be done.. this should be cleaned up to
4463 avoid wasting that second. Builder.detach uses a callLater(0),
4464 either that should be done in-line (something else needed that
4465 behavior), or it should return a Deferred that fires when the
4466 builder is really offline.
4467 (Disconnect.testBuild3): same
4468 (Disconnect.testDisappear): same
4470 * buildbot/test/test_web.py: rearrange server-setup and teardown
4471 code to remove unclean-reactor warnings from twisted-2.0
4473 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4474 so the tests don't hang under twisted-2.0
4476 2005-03-31 Brian Warner <warner@lothar.com>
4478 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4479 caused a warning each time the master changed our set of builders
4481 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4482 w32, don't unlink the file unless it already exists. Thanks to
4483 Baptiste Lepilleur for the catch.
4484 (BuilderStatus.saveYourself): same
4486 2005-02-01 Brian Warner <warner@lothar.com>
4488 * buildbot/status/html.py (TextLog.getChild): use a /text child
4489 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4490 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4491 logfile as text/plain (no markup, no headers). This replaces the
4492 previous scheme (which used an ?text=1 argument), and gets us back
4493 to a relative link (which works better when the buildbot lives
4494 behind another web server, such as Apache configured as a reverse
4495 proxy). Thanks to Gerald Combs for spotting the problem.
4497 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4500 2004-12-13 Brian Warner <warner@lothar.com>
4502 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4504 * debian/changelog: update for 0.6.2
4505 * NEWS: finalize for 0.6.2
4507 2004-12-11 Brian Warner <warner@lothar.com>
4509 * NEWS: bring it up to date
4511 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4512 detection code. Require some sign of life from the buildmaster
4513 every BotFactory.keepaliveInterval seconds. Provoke this
4514 indication at BotFactory.keepaliveTimeout seconds before the
4515 deadline by sending a keepalive request. We don't actually care if
4516 that request is answered in a timely fashion, what we care about
4517 is that .activity() is called before the deadline. .activity() is
4518 triggered by any PB message from the master (including an ack to
4519 one of the slave's status-update messages). With this new scheme,
4520 large status messages over slow pipes are OK, as long as any given
4521 message can be sent (and thus acked) within .keepaliveTimeout
4522 seconds (which defaults to 30).
4523 (SlaveBuilder.remote_startCommand): record activity
4524 (SlaveBuilder.ackUpdate): same
4525 (SlaveBuilder.ackComplete): same
4526 (BotFactory.gotPerspective): same
4527 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4529 2004-12-09 Brian Warner <warner@lothar.com>
4531 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4534 * buildbot/process/step_twisted.py (Trial._commandComplete):
4535 update self.cmd when we start the 'cat test.log' transfer. Without
4536 this, we cannot interrupt the correct RemoteCommand when we lose
4539 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4540 trying to tell the slave to stop the command if we're already
4541 inactive, or if we no longer have a .remote
4543 * buildbot/process/builder.py (Builder._detached): don't let an
4544 exception in currentBuild.stopBuild() prevent the builder from
4545 being marked offline
4547 2004-12-07 Brian Warner <warner@lothar.com>
4549 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4550 KeyError that happens when you ask for a non-existent Builder, and
4551 translate it into a UsageError.
4553 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4554 losing the slave in the middle of a remote step is handled too
4556 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4557 be a Failure, so be sure to stringify it before using it as the
4558 contents of the 'interrupt' logfile
4559 (RemoteCommand.interrupt): use stringified 'why' in
4560 remote_interruptCommand too, just in case
4562 2004-12-06 Brian Warner <warner@lothar.com>
4564 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4565 instead of 'tla update', which is more efficient in case we've
4566 missed a couple of patches since the last update.
4568 * debian/changelog: update for previous (0.6.1) release. Obviously
4569 this needs to be handled better.
4571 2004-12-05 Brian Warner <warner@lothar.com>
4573 * NEWS: update for stuff since last release
4575 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4576 match the maybeDeferred change in Dispatcher.requestAvatar
4577 * buildbot/changes/pb.py (ChangePerspective.attached): same
4578 * buildbot/status/client.py (StatusClientPerspective.attached): same
4579 * buildbot/process/builder.py (Builder._attached3): same
4580 * buildbot/pbutil.py (NewCredPerspective.attached): same
4582 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4583 the date to the top-most box, if it is not the same as today's
4586 * docs/slave.xhtml: provide a buildslave setup checklist
4588 * docs/source.xhtml (Arch): correct terminology
4590 2004-12-04 Brian Warner <warner@lothar.com>
4592 * buildbot/test/test_slavecommand.py: use sys.executable instead
4593 of hard-coding 'python' for child commands, might help portability
4595 * docs/examples/twisted_master.cfg: update to current usage
4597 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4598 'stop build' command to the IRC bot
4600 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4601 message that broke PBChangeSource
4603 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4604 (SlaveBuilder): make some attributes class-level, remove the old
4605 "update queue" which existed to support resuming a build after the
4606 master connection was lost. Try to reimplement that feature later.
4607 (SlaveBuilder.stopCommand): clear self.command when the
4608 SlaveCommand finishes, so that we don't try to kill a leftover one
4610 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4613 * buildbot/slave/commands.py (SourceBase): set self.command for
4614 all VC commands, so they can be interrupted.
4616 2004-12-03 Brian Warner <warner@lothar.com>
4618 * buildbot/master.py: clean up slave-handling code, to handle
4619 slave-disconnect and multiple-connect better
4620 (BotPerspective): make these long-lasting, exactly one per bot
4621 listed in the config file.
4622 (BotPerspective.attached): if a slave connects while an existing
4623 one appears to still be connected, disconnect the old one first.
4624 (BotPerspective.disconnect): new method to forcibly disconnect a
4625 buildslave. Use some hacks to empty the transmit buffer quickly to
4626 avoid the long (20-min?) TCP timeout that could occur if the old
4627 slave has dropped off the net.
4628 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4629 own their own SlaveStatus objects. Remove .attached/.detached, add
4630 .addSlave/.removeSlave, treat slaves like Builders (config file
4631 parsing sends deltas to the BotMaster). Inform the slave
4632 instances, i.e. the BotPerspective, about addBuilder and
4634 (BotMaster.getPerspective): turns into a single dict lookup
4635 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4636 which gives BotPerspective.attached a chance to disconnect the old
4638 (BuildMaster.loadConfig): add code (disabled) to validate that all
4639 builders use known slaves (listed in c['bots']). The check won't
4640 work with tuple-specified builders, which are deprecated but not
4641 yet invalid, so the check is disabled for now.
4642 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4643 routine, do the add/changed/removed dance with them like we do
4645 (BuildMaster.loadConfig_Sources): move source-config into a
4646 separate routine too
4648 * buildbot/status/builder.py (Status.getSlave): get the
4649 SlaveStatus object from the BotPerspective, not the BotMaster.
4651 * buildbot/test/test_run.py: bunch of new tests for losing the
4652 buildslave at various points in the build, handling a slave that
4653 connects multiple times, and making sure we can interrupt a
4656 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4657 something other than 'Bot' for the Bot object, to make certain
4658 test cases easier to write.
4659 (BuildSlave.waitUntilDisconnected): utility method for testing
4661 2004-11-30 Brian Warner <warner@lothar.com>
4663 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4665 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4666 argument, return a Deferred that always fires with True or False.
4667 I don't use an errback to indicate 'ping failed' so that callers
4668 are free to ignore the deferred without causing spurious errors in
4670 * buildbot/process/builder.py (BuilderControl.ping): implement it
4672 * buildbot/test/test_run.py (Status.testDisappear): test ping
4673 (Status.disappearSlave): fix it
4675 2004-11-30 Brian Warner <warner@lothar.com>
4677 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4678 (IBuilderControl): add .getBuild(num), only works for the current
4679 build, of course, although it might be interesting to offer
4680 something for builds in the .waiting or .interlocked state.
4682 * buildbot/process/base.py (Build): have .stopBuild just do the
4683 interrupt, then let the build die by itself.
4684 (BuildControl): add .stopBuild, and add a point-event named
4685 'interrupt' just after the build so status viewers can tell that
4687 (BuilderControl): add .getBuild
4689 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4690 stops when you kill it, good for testing
4691 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4692 contains the 'reason' text.
4694 * buildbot/status/html.py: Add Stop Build button, if the build can
4695 still be stopped. Send a Redirect (to the top page) one second
4696 later, hopefully long enough for the interrupt to have an effect.
4697 Move make_row() up to top-level to share it between Stop Build and
4700 * buildbot/slave/commands.py: only kill the child process once
4702 * buildbot/test/test_run.py: add testInterrupt
4704 2004-11-29 Brian Warner <warner@lothar.com>
4706 * buildbot/process/base.py: Refactor command interruption. The
4707 Build is now responsible for noticing that the slave has gone
4708 away: Build.lostRemote() interrupts the current step and makes
4709 sure that no further ones will be started.
4711 * buildbot/process/builder.py: When the initial remote_startBuild
4712 message fails, log it: this usually indicates that the slave has
4713 gone away, but we don't really start paying attention until they
4714 fail to respond to the first step's command.
4716 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4717 slave disconnect. Now sports a new interrupt() method. Error
4718 handling was simplified a lot by chaining deferreds, so
4719 remoteFailed/remoteComplete were merged into a single
4720 remoteComplete method (which can now get a Failure object).
4721 Likewise failed/finished were merged into just _finished.
4722 (BuildStep): Add interrupt(why) method, and if why is a
4723 ConnectionLost Failure then the step is failed with some useful
4726 * buildbot/slave/bot.py: stop the current command when the remote
4727 Step reference is lost, and when the slave is shut down.
4728 (Bot): make it a MultiService, so it can have children. Use
4729 stopService to tell when the slave is shutting down.
4730 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4731 remote_interruptCommand (which asks the current SlaveCommand to
4732 stop but allows it to keep emitting status messages), and
4733 stopCommand (which tells it to shut up and die).
4735 * buildbot/slave/commands.py: make commands interruptible
4736 (ShellCommand.kill): factor out os.kill logic
4737 (Command): factor out setup()
4738 (Command.sendStatus): don't send status if .running is false, this
4739 happens when the command has been halted.
4740 (Command.interrupt): new method, used to tell the command to die
4741 (SlaveShellCommand): implement .interrupt
4742 (DummyCommand): implement .interrupt
4743 (SourceBase, etc): factor out setup(), don't continue substeps if
4746 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4747 so they can be called after finishing
4749 * buildbot/test/test_run.py: new tests for disconnect behavior,
4750 refactor slave-shutdown routines, add different kinds of
4753 2004-11-27 Brian Warner <warner@lothar.com>
4755 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4756 method to express ETA time like "2m45s" instead of "165 seconds"
4758 2004-11-24 Brian Warner <warner@lothar.com>
4760 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4761 archive after the test completes, to avoid cluttering the user's
4762 'tla archives' listing with a bogus entry. Arch doesn't happen to
4763 provide any way to override the use of ~/.arch-params/, so there
4764 isn't a convenient way to avoid touching the setup of the user who
4766 (VC_HTTP.testArchHTTP): same
4768 2004-11-23 Brian Warner <warner@lothar.com>
4770 * buildbot/status/html.py (TextLog): split render() up into
4771 render_HEAD and render_GET. Use a Producer when sending log
4772 chunks, to reduce memory requirements and avoid sending huge
4773 non-Banana-able strings over web.distrib connections. Requires
4774 peeking under the covers of IStatusLog.
4775 (TextLog.resumeProducing): fix the "as text" link, handle client
4776 disconnects that occur while we're still sending old chunks.
4778 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4779 use defer.succeed, not the non-existent defer.success
4780 (LogFile.waitUntilFinished): same
4781 (LogFile.subscribe): don't add watchers to a finished logfile
4783 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4786 2004-11-23 Brian Warner <warner@lothar.com>
4788 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4790 2004-11-23 Brian Warner <warner@lothar.com>
4792 * NEWS: update for the 0.6.1 release
4793 * MANIFEST.in: add new files
4795 * README (INSTALLATION): explain how to enable the extra VC tests
4797 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4798 level to, so old pickled builds can be displayed ok
4800 2004-11-22 Brian Warner <warner@lothar.com>
4802 * NEWS: summarize updates since last release
4804 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4805 Yoz Grahame. Closes SF#1050138.
4807 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4810 * buildbot/process/step_twisted.py (Trial): update docs a bit
4812 * docs/factories.xhtml: fix Trial factory docs to match reality.
4815 * buildbot/process/factory.py (Trial.__init__): add args for
4816 randomly= and recurse=, making them available to instantiators
4817 instead of only to subclassers. Closes: SF#1049759.
4819 2004-11-15 Brian Warner <warner@lothar.com>
4821 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4822 try to teach the Quick factory to use multiple versions of python
4824 2004-11-12 Brian Warner <warner@lothar.com>
4826 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4827 safer w32-compatible approach, and only use it on windows
4828 (BuildStatus.saveYourself): same
4830 2004-11-11 Brian Warner <warner@lothar.com>
4832 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4833 it: one string merge per chunk. There are now separate .entries
4834 and .runEntries lists: when enumerating over all chunks, make sure
4836 * buildbot/test/test_status.py (Log): more tests
4838 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4839 chunks together, up to 10kb per chunk. This ought to cut down on
4840 the CPU-burning overhead of large log files. Thanks to Alexander
4841 Staubo for spotting the problem.
4842 * buildbot/test/test_status.py (Log): tests for same
4844 2004-11-10 Brian Warner <warner@lothar.com>
4846 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4847 header to outbound mail
4848 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4850 2004-11-08 Brian Warner <warner@lothar.com>
4852 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4853 can't do os.rename() onto an existing file, so catch the exception
4854 and unlink the target file first. This introduces a slight window
4855 where the existing file could be lost, but the main failure case
4856 (disk full) should still be handled safely.
4857 (BuildStatus.saveYourself): same
4859 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4860 separator character instead of os.sep, because the filenames being
4861 split here are coming from the VC system, which can have a
4862 different pathname convention than the local host. This should
4863 help a buildmaster running on windows that uses a CVS repository
4864 which runs under unix.
4865 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4867 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4868 when there are no test failures to be parsed
4870 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4871 instead of the unix-specific os.system("cp"), thanks to Elliot
4872 Murphy for this and the other buildbot-vs-windows catches.
4873 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4875 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4876 echo the command as it is run
4878 * setup.py: install sample.mk too, not just sample.cfg
4879 (scripts): install contrib/windows/buildbot.bat on windows
4881 2004-11-07 Brian Warner <warner@lothar.com>
4883 * buildbot/process/builder.py (Builder._detached): clear the
4884 self.currentBuild reference, otherwise the next build will be
4885 skipped because we think the Builder is already in use.
4887 * docs/examples/twisted_master.cfg: update to match current usage
4888 on the Twisted buildbot
4890 2004-10-29 Brian Warner <warner@lothar.com>
4892 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4894 2004-10-28 Brian Warner <warner@lothar.com>
4896 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4897 have separate doVCUpdate/doVCFull methods. Catch an update failure
4898 and respond by clobbering the source directory and re-trying. This
4899 will handle local changes (like replacing a file with a directory)
4900 that will cause CVS and SVN updates to fail.
4901 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4903 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4906 2004-10-19 Brian Warner <warner@lothar.com>
4908 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4910 * buildbot/status/html.py (StatusResourceTestResults): display any
4911 TestResults that the Build might have
4912 (StatusResourceTestResult): and the logs for each TestResult
4913 (StatusResourceBuild): add link from the per-build page
4915 2004-10-15 Brian Warner <warner@lothar.com>
4917 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4918 the 'problems' portion of stdout, add TestResults to our build
4919 * buildbot/test/test_twisted.py (Parse.testParse): test it
4921 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4922 to retrieve a dict of accumulated test results
4923 (ITestResult): define what a single test result can do
4924 * buildbot/status/builder.py (TestResult): implement ITestResult
4925 (BuildStatus.getTestResults): retrieve dict of TestResults
4926 (BuildStatus.addTestResult): add TestResults
4927 * buildbot/test/test_status.py (Results.testAddResults): test it
4929 2004-10-14 Brian Warner <warner@lothar.com>
4931 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4932 instead of os.system("rm -rf") for win32 portability
4934 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4935 SignalMixin instead of starting/stopping the reactor, which is
4936 likely to cause problems with other tests
4938 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4939 self.copyComplete() call. Yoz Grahame makes the catch.
4941 * contrib/windows/buildbot.bat: helper script to deal with path
4942 issues. Thanks to Yoz Grahame.
4944 * buildbot/master.py (BuildMaster.startService): don't register a
4945 SIGHUP handler if the signal module has no SIGHUP attribute.
4946 Apparently win32 does this.
4948 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4950 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4951 test if the reactor can't offer UNIX sockets
4953 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4954 error introduced in the last commit. We really need that
4957 2004-10-12 Brian Warner <warner@lothar.com>
4959 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4960 when describing a maildir source. Thanks to Stephen Davis.
4962 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4965 * buildbot/scripts/runner.py (createMaster): install Makefile too
4966 (start): add --no_save to 'start' command
4967 * buildbot/scripts/sample.mk: simple convenience Makefile with
4968 start/stop/reload targets
4970 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4973 2004-09-30 Brian Warner <warner@lothar.com>
4975 * setup.py: Releasing buildbot-0.6.0
4977 2004-09-30 Brian Warner <warner@lothar.com>
4979 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4980 test_trial.py from the source tarball until support is complete.
4982 * NEWS: update for 0.6.0 release
4983 * buildbot/__init__.py (version): same
4986 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4987 'source' command to tell users where to get the Buildbot source
4989 * docs/examples/*.cfg: update to modern standards
4991 * NEWS: update for release
4993 * buildbot/scripts/runner.py (createMaster): remove the
4994 -shutdown.tap stuff now that it isn't necessary
4996 (start): launch buildbot.tap, not buildbot-shutdown.tap
4999 * buildbot/status/mail.py (Domain): shorten class name
5000 (MailNotifier): if lookup= is a string, pass it to Domain()
5001 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5002 (Mail.testBuild2): test the string-to-Domain shortcut
5003 (Mail.testMail): fix test
5006 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5009 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5010 more attributes on load
5011 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5012 to accomodate the whole waterfall page at once, and the thrashing
5013 results in a lot of unnecessary loads
5014 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5015 (BuilderStatus.saveYourself): same
5016 (BuilderStatus.eventGenerator): stop generating on the first missing
5017 build. We assume that saved builds are deleted oldest-first.
5018 (BuildStepStatus.__getstate__): .progress might not exist
5020 * buildbot/changes/changes.py (ChangeMaster): make it
5021 serializable, in $masterdir/changes.pck
5022 (ChangeMaster.stopService): save on shutdown
5023 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5024 * buildbot/test/test_config.py: load Changes before config file
5027 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5028 "Oh my god, you killed the command" header on a separate line
5030 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5031 skip over corrupted build pickles
5032 (BuilderStatus.getFullBuildByNumber): same
5033 (BuilderStatus.eventGenerator): skip over unavailable builds
5034 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5035 do an atomic rename. This prevents a corrupted pickle when some
5036 internal serialization error occurs.
5037 (BuilderStatus.saveYourself): same
5039 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5040 the timeout for shell commands, it got lost somehow
5042 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5043 run out of build steps, return the rest of the builder events
5045 * buildbot/interfaces.py (IBuilderControl.ping): add method
5047 * buildbot/process/builder.py (BuilderControl.ping): move
5048 slave-ping to BuilderControl, and fix the failure case in the
5049 process (Event.finish() is the verb, Event.finished is the noun).
5051 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5052 through the BuilderControl instead of the BuilderStatus
5053 (EventBox): add adapter for builder.Event, allowing builder events to
5054 be displayed in the waterfall display
5056 * buildbot/master.py (BotMaster.stopService): add a 'master
5057 shutdown' event to the builder's log
5058 (BuildMaster.startService): and a 'master started' on startup
5060 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5061 builder events into the BuildStep event stream
5062 (Status.builderAdded): add a 'builder created' event
5065 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5066 command to announce the completion of a running build
5067 (IrcStatusBot.command_FORCE): announce when the build finishes
5069 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5070 don't evict unfinished builds from the cache: they must stay in
5071 the full-cache until their logfiles have stopped changing. Make
5072 sure the eviction loop terminates if an unfinished build was hit.
5073 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5074 This lets exceptions be dumped in an email status message. Really
5075 we need LogFiles which contain both text and HTML, instead of two
5077 (BuildStatus.__getstate__): handle self.finished=False
5078 (Status.builderAdded): if the pickle is corrupted, abandon the
5079 history and create a new BuilderStatus object.
5081 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5082 self.progress attribute, helped one test which doesn't fully set
5083 up the Build object.
5085 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5086 IStatusLog methods into an Interface that is implemented by "stub"
5087 logs, for which all the actual text chunks are on disk (in the
5088 pickled Build instance). To show the log contents, you must first
5089 adapt the stub log to a full IStatusLog object.
5091 * buildbot/status/builder.py (LogFileStub): create separate stub
5092 log objects, which can be upgraded to a real one if necessary.
5093 (LogFile): make them persistable, and let them stubify themselves
5095 (BuildStepStatus): same
5097 (BuildStatus.saveYourself): save the whole build out to disk
5098 (BuilderStatus): make it persistable
5099 (BuilderStatus.saveYourself): save the builder to disk
5100 (BuilderStatus.addFullBuildToCache): implement two caches which
5101 hold Build objects: a small one which holds full Builds, and a
5102 larger one which holds "stubbed" Builds (ones with their LogFiles
5103 turned into LogFileStubs). This reduces memory usage by the
5104 buildmaster by not keeping more than a few (default is 2) whole
5105 build logs in RAM all the time.
5106 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5108 (BuilderStatus.eventGenerator): rewrite since .builds went away
5109 (BuilderStatus.buildStarted): remove the .builds array. Add the
5110 build to the "full" cache when it starts.
5111 (BuilderStatus._buildFinished): save the build to disk when it
5113 (Status): give it a basedir (same as the BuildMaster's basedir)
5114 where the builder pickles can be saved
5115 (Status.builderAdded): create the BuilderStatus ourselves, by
5116 loading a pickle from disk (or creating a new instance if there
5117 was none on disk). Return the BuilderStatus so the master can glue
5118 it into the new Builder object.
5120 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5121 all BuilderStatuses to save themselves out to disk. This is in
5122 lieu of saving anything important in the main Application pickle
5123 (the -shutdown.tap file).
5124 (BuildMaster.__init__): give Status() a basedir for its files
5125 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5126 to get the BuilderStatus, then give it to the Builder (instead of
5127 doing it the other way around). It's ok if the status announces
5128 the new Builder before it's really ready, as the outside world can
5129 only see the BuilderStatus object anyway (and it is ready before
5130 builderAdded returns). Use the builder's "builddir" (which
5131 normally specifies where the slave will run the builder) as the
5132 master's basedir (for saving serialized builds).
5134 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5135 coerce the logfile to IStatusLog before trying to get the text
5136 chunks out of it. This will pull the full (non-stubified) Build in
5137 from disk if necessary.
5138 (TextLog): fix the adapter registration
5140 * buildbot/test/test_control.py (Force.setUp): create the basedir
5141 * buildbot/test/test_web.py: same
5142 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5143 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5144 * buildbot/test/test_run.py (Run.testMaster): same
5145 (Status.setUp): same
5147 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5149 * buildbot/status/html.py (Waterfall.__init__): store actual
5150 allowForce flag passed in rather than using True for everyone;
5151 make sure setting it to False doesn't cause a NameError
5153 (StatusResourceBuilder.__init__) add the builder name to the page
5155 (StatusResourceBuilder.body) move HTML generation for a name/value
5156 row into a helper method (StatusResourceBuilder.make_row); only
5157 generate the "Force Build" form if allowForce was True and the
5158 slave is connected. Use class attributes in the generated HTML to
5159 spread a little CSS-joy.
5161 2004-09-28 Brian Warner <warner@lothar.com>
5163 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5164 warning-scanner to not ignore things like
5165 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5167 * buildbot/status/html.py (StatusResource.control): add some
5168 class-level values for .control in an attempt to make upgrading
5171 * buildbot/util.py (ComparableMixin): survive missing attributes,
5172 such as when a class is modified and we're comparing old instances
5175 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5176 failure handling, remove a redundant try/except block. Don't
5177 return the full traceback to the IRC channel.
5178 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5179 error messages. Get ETA properly.
5181 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5182 the reason, since (at least) IRC message will have <> in them.
5183 (StatusResourceBuilder.__init__): take an IBuilderControl
5184 (StatusResourceBuilder.force): use the IBuilderControl we get in
5185 the constructor instead of trying to make our own. Catch the
5186 new exceptions and ignore them for now (until we make an
5187 intermediate web page where we could show the error message)
5188 (StatusResource): create with an IControl, use it to give an
5189 IBuilderControl to all children
5190 (Waterfall): take an allowForce= option, pass an IControl object
5191 to StatusResource if it is True
5193 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5195 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5196 catch new exceptions and return string forms
5198 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5199 * buildbot/process/builder.py (Builder.forceBuild): raise them
5200 * buildbot/test/test_control.py (Force.testNoSlave): new test
5201 (Force.testBuilderInUse): same
5204 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5206 * buildbot/test/test_run.py: use IControl
5207 * buildbot/test/test_vc.py: same
5209 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5210 to use IControl. Still offline.
5211 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5213 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5214 who=None so periodic builds don't send out status mail
5215 (Builder.forceBuild): include reason in the log message
5216 (BuilderControl.forceBuild): rename 'name' to 'who'
5218 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5219 'who' parameter, but make it None by default so builds forced by
5220 slave admins don't cause status mail to be sent to anybody
5221 (BotMaster.forceBuild): same. this method is deprecated.
5222 (DebugPerspective.perspective_forceBuild): same, use IControl.
5223 (DebugPerspective.perspective_fakeChange): use IControl..
5224 (Dispatcher.requestAvatar): .. so don't set .changemaster
5226 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5227 parameter to avoid confusion with the name of the builder
5230 * buildbot/status/mail.py: refine comment about needing 2.3
5232 * buildbot/status/html.py: move all imports to the top
5234 * buildbot/test/test_control.py: test new interfaces
5235 * buildbot/test/test_run.py (Status): handle new interfaces
5236 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5238 * buildbot/process/base.py (BuildControl): implement IBuildControl
5239 and its lonely getStatus() method
5241 * buildbot/process/builder.py (BuilderControl): implement
5242 IBuilderControl, obtained by adapting the Builder instance
5243 (Builder.startBuild): return a BuilderControl instead of a
5244 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5245 accomplish the same thing.
5247 * buildbot/master.py: move all import statements to the top
5248 (Control): implement IControl, obtained by adapting the
5249 BuildMaster instance.
5251 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5252 IBuildControl. These are used to force builds. Eventually they
5253 will provide ways to reconfigure the Builders, pause or abandon a
5254 Build, and perhaps control the BuildMaster itself.
5256 2004-09-26 Brian Warner <warner@lothar.com>
5258 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5259 ends up comparing us against something without a .__class__
5261 2004-09-24 Brian Warner <warner@lothar.com>
5263 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5266 * Makefile: add 'deb-snapshot' target, to create a timestamped
5269 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5271 2004-09-23 Brian Warner <warner@lothar.com>
5273 * buildbot/__init__.py (version): move version string here
5274 * setup.py: get version string from buildbot.version
5275 * buildbot/status/html.py (WaterfallStatusResource.body): add
5276 buildbot version to the page footer
5277 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5280 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5281 slaves, let the second know where the first one is coming from
5282 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5283 see our exceptions. It would be nice if there were a way to just
5284 send them the exception type and value, not the full traceback.
5287 * buildbot/status/mail.py (MailNotifier): add a new argument
5288 sendToInterestedUsers=, which can be set to False to disable the
5289 usual send-to-blamelist behavior.
5290 (top): handle python-2.2 which has no email.MIMEMultipart
5291 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5292 (MailNotifier.disownServiceParent): unsubscribe on removal
5294 * buildbot/test/test_status.py (Mail.testBuild2): test it
5297 * buildbot/status/progress.py (Expectations.wavg): tolerate
5298 current=None, which happens when steps start failing badly
5299 * buildbot/test/test_status.py (Progress.testWavg): test for it
5301 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5302 doesn't understand args['revision'], emit a warning instead of
5303 bailing completely. Updating to -rHEAD is probably close enough.
5305 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5307 * buildbot/test/test_status.py: at least import bb.status.client
5308 even if we don't have any test coverage for it yet
5310 * contrib/svn_buildbot.py: don't require python2.3
5311 (main): wait, do require it (for sets.py), but explain how to
5312 make it work under python2.2
5314 2004-09-23 Brian Warner <warner@lothar.com>
5316 * contrib/svn_buildbot.py: include the revision number in the Change
5318 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5319 using util.now() because FreshCVS is a realtime service
5321 * buildbot/status/event.py: delete dead code
5322 * buildbot/process/step.py: don't import dead Event class
5323 * buildbot/process/step_twisted.py: same
5324 * buildbot/status/builder.py: same
5325 * buildbot/status/client.py: same
5327 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5329 * buildbot/changes/changes.py (Change): set .when from an __init__
5330 argument (which defaults to now()), rather than having
5331 ChangeMaster.addChange set it later.
5332 (ChangeMaster.addChange): same
5334 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5335 (parseSyncmail): same. Just use util.now() for now.
5336 (parseBonsaiMail): parse the timestamp field for when=
5338 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5339 instead of setting .when after the fact
5343 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5344 results when the target project uses retrial. Still under
5346 * buildbot/test/test_trial.py: same
5348 2004-09-21 Brian Warner <warner@lothar.com>
5350 * buildbot/status/mail.py (MailNotifier.__init__): include
5351 success/warnings/failure in the Subject line
5352 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5353 use step.logname for the addLogs=True attachment filenames
5354 * buildbot/test/test_status.py (Mail): test Subject lines
5355 (Mail.testLogs): test attachment filenames
5357 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5358 accept a 'who' argument from the debug tool
5359 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5360 * contrib/debug.glade: add text box to set 'who'
5362 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5363 .getBuilderName with .getBuilder().getName(), more flexible
5364 (IStatusLog.getName): logs have short names, but you can prefix
5365 them with log.getStep().getName() to make them more useful
5366 * buildbot/status/builder.py: same
5367 * buildbot/status/client.py: same
5368 * buildbot/status/html.py: same
5369 * buildbot/test/test_run.py (Status.testSlave): same
5370 * buildbot/process/step.py: tweak logfile names
5372 * buildbot/status/mail.py (MailNotifier): add lookup, change
5373 argument to extraRecipients. The notifier is now aimed at sending
5374 mail to the people involved in a particular build, with additional
5375 constant recipients as a secondary function.
5377 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5378 including slow-lookup and failing-lookup. Make sure the blamelist
5379 members are included.
5381 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5382 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5383 (IBuildStatus.getInterestedUsers): new method
5384 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5385 * buildbot/status/client.py (remote_getResponsibleUsers): same
5386 * buildbot/status/html.py (StatusResourceBuild.body): same
5387 * buildbot/test/test_run.py (Status.testSlave): same
5389 2004-09-20 Brian Warner <warner@lothar.com>
5391 * docs/users.xhtml: update concepts
5393 * Makefile: add a convenience makefile, for things like 'make
5394 test'. It is not included in the source tarball.
5396 2004-09-16 Brian Warner <warner@lothar.com>
5398 * NEWS: mention /usr/bin/buildbot, debian/*
5400 * debian/*: add preliminary debian packaging. Many thanks to
5401 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5402 it considerably since it left their hands, I am responsible for
5403 all breakage that's resulted.
5405 * bin/buildbot: create a top-level 'buildbot' command, to be
5406 installed in /usr/bin/buildbot . For now it's just a simple
5407 frontend to mktap/twistd/kill, but eventually it will be the entry
5408 point to the 'try' command and also a status client. It is also
5409 intended to support the upcoming debian-packaging init.d scripts.
5410 * buildbot/scripts/runner.py: the real work is done here
5411 * buildbot/scripts/__init__.py: need this too
5412 * buildbot/scripts/sample.cfg: this is installed in new
5413 buildmaster directories
5414 * setup.py: install new stuff
5416 2004-09-15 Brian Warner <warner@lothar.com>
5418 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5419 'file:' schema (the version shipped with OS-X was built without the
5421 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5422 updates the log-timestamp, to make sure it isn't still running after
5425 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5426 values to the config file.
5427 * docs/examples/hello.cfg: add examples
5428 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5429 * buildbot/status/builder.py (Status.getProjectURL): implement them
5430 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5431 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5432 * buildbot/status/html.py (WaterfallStatusResource): display them
5435 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5436 certain error cases don't suffer a secondary exception.
5437 (top): Skip tests if the corresponding VC tool is not installed.
5439 * buildbot/process/factory.py (Trial): introduce separate
5440 'buildpython' and 'trialpython' lists, since trialpython=[] is
5441 what you want to invoke /usr/bin/python, whereas ./setup.py is
5442 less likely to be executable. Add env= parameter to pass options
5443 to test cases (which is how I usually write tests, I don't know if
5444 anyone else does it this way).
5446 * buildbot/process/step_twisted.py (Trial): handle python=None.
5447 Require 'testpath' be a string, not a list. Fix tests= typo.
5448 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5450 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5451 way to deal with the possibility of removing the disconnect notify
5453 (CVS): add a 'login' parameter to give a password to 'cvs login',
5454 commonly used with pserver methods (where pw="" or pw="guest")
5456 * buildbot/slave/commands.py (SourceBase): move common args
5457 extraction and setup() to __init__, so everything is ready by the
5458 time setup() is called
5459 (CVS.start): call 'cvs login' if a password was supplied
5460 (ShellCommand): special-case PYTHONPATH: prepend the master's
5461 value to any existing slave-local value.
5463 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5464 don't have a remote, mark the builder as Offline. This whole
5465 function should probably go away and be replaced by individual
5467 (Builder.buildFinished): return the results to the build-finished
5468 deferred callback, helps with testing
5470 2004-09-14 Brian Warner <warner@lothar.com>
5472 * buildbot/test/test_vc.py: put all the repositories needed to run
5473 the complete tests into a single small (1.3MB) tarball, so I can
5474 make that tarball available on the buildbot web site. Test HTTP
5475 access (for Arch and Darcs) by spawning a temporary web server
5476 while the test runs.
5478 * docs/users.xhtml: new document, describe Buildbot's limited
5479 understanding of different human users
5481 * buildbot/test/test_vc.py: rearrange test cases a bit
5483 * buildbot/process/step_twisted.py (Trial): handle testpath=
5484 * buildbot/process/factory.py (Trial): update to use step.Trial
5486 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5488 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5489 the overall build text (which gives you 'failed 2 tests' rather
5491 (BuildStepStatus.text2): default to [], not None
5493 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5496 2004-09-12 Brian Warner <warner@lothar.com>
5498 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5499 log the whole exception if it's just an AttributeError (old slave)
5501 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5502 so (e.g.) sub-commands can be run in the right directory.
5503 (ShellCommand.start): accept an optional errorMessage= argument
5504 to make life easier for SVN.start
5505 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5507 (ShellCommand.start): move ['dir'] compatibility hack..
5508 (RemoteShellCommand.start): .. to here so everyone can use it
5510 * buildbot/process/step_twisted.py (Trial): use .workdir
5512 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5513 text displayed when debuild fails completely
5514 (Trial): snarf _trial_temp/test.log from the slave and display it
5516 2004-09-11 Brian Warner <warner@lothar.com>
5518 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5520 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5521 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5523 * buildbot/process/step.py (ShellCommand): call .createSummary
5524 before .evaluateCommand instead of the other way around. This
5525 makes it slightly easier to count warnings and then use that to
5526 set results=WARNINGS
5527 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5529 * buildbot/process/base.py (Build.buildFinished): update status
5530 before doing progress. It's embarrassing for the build to be stuck
5531 in the "building" state when an exceptions occurs elsewhere..
5533 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5534 python2.2 doesn't have 'sum'
5536 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5537 to prevent clients from accidentally sorting it
5539 * buildbot/master.py (Manhole): add username/password
5540 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5541 c['manholePort'], deprecate old usage
5542 * docs/config.xhtml: document c['manhole']
5543 * docs/examples/hello.cfg: show example of using a Manhole
5546 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5547 pretend the slave is up to date
5549 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5550 the module, overlaps with 'log', the local variable
5552 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5554 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5555 new method to let Steps find out the version of their
5556 corresponding SlaveCommand.
5557 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5558 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5559 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5561 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5562 (Arch.startVC): same
5563 (P4Sync.startVC): same
5565 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5566 Deferred so we can catch errors in remote_startCommand
5567 (RemoteShellCommand.start): same
5569 * docs/examples/twisted_master.cfg: update sample config file
5571 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5572 after connectionMade() is called, not before. Close stdin at that
5575 * buildbot/process/process_twisted.py: update to use Trial, clean
5576 up argument passing (move to argv arrays instead of string
5579 * buildbot/process/step_twisted.py (Trial): new step to replace
5580 RunUnitTests, usable by any trial-using project (not just
5581 Twisted). Arguments have changed, see the docstring for details.
5583 * buildbot/process/base.py (Build.startBuild): this now returns a
5584 Deferred. Exceptions that occur during setupBuild are now
5585 caught better and lead to fewer build_status weirdnesses, like
5586 finishing a build that was never started.
5587 (Build.buildFinished): fire the Deferred instead of calling
5588 builder.buildFinished directly. The callback argument is this
5589 Build, everything else can be extracted from it, including the
5590 new build.results attribute.
5591 * buildbot/process/builder.py (Builder.startBuild): same
5592 (Builder.buildFinished): same, extract results from build
5594 * buildbot/process/step.py (ShellCommands): remove dead code
5596 2004-09-08 Brian Warner <warner@lothar.com>
5598 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5599 doesn't try to use the leftover patched workdir
5600 (SourceStamp): test source-stamp computation for CVS and SVN
5602 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5603 patched workdir ('touch .buildbot-patched') so we don't try to
5605 (SourceBase.start): add ['revision'] for all Source steps
5606 (CVS): change args: use ['branch'] for -r, remove ['files']
5607 (CVS.buildVC): fix revision/branch stuff
5608 (SVN): add revision stuff
5610 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5611 kwargs (except 'workdir') to avoid silent spelling errors
5612 (ShellCommand.__init__): same
5613 (Source): new base class for CVS/SVN/etc. Factor out everything
5614 common, add revision computation (perform the checkout with a -D
5615 DATE or -r REVISION that gets exactly the sources described by the
5616 last Change), overridable with step.alwaysUseLatest. Add patch
5617 handling (build.getSourceStamp can trigger the use of a base
5618 revision and a patch).
5619 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5620 * docs/steps.xhtml: update docs
5621 * docs/source.xhtml: mention .checkoutDelay
5622 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5624 * buildbot/process/base.py (Build.setSourceStamp): add a
5625 .sourceStamp attribute to each Build. If set, this indicates that
5626 the build should be done with something other than the most
5627 recent source tree. This will be used to implement "try" builds.
5628 (Build.allChanges): new support method
5629 (Build.lastChangeTime): remove, functionality moved to Source steps
5630 (Build.setupBuild): copy the Step args before adding ['workdir'],
5631 to avoid modifying the BuildFactory (and thus triggering spurious
5635 * buildbot/status/html.py: rename s/commits/changes/
5636 (StatusResourceChanges): same
5637 (CommitBox.getBox): same, update URL
5638 (WaterfallStatusResource): same
5639 (StatusResource.getChild): same
5641 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5642 * contrib/debug.glade: add optional 'revision' to the fakeChange
5644 * buildbot/changes/changes.py (html_tmpl): display .revision
5645 (ChangeMaster.addChange): note .revision in log
5646 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5647 accept a ['revision'] attribute
5649 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5651 * buildbot/master.py (BotMaster.getPerspective): update the
5652 .connected flag in SlaveStatus when it connects
5653 (BotMaster.detach): and when it disconnects
5654 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5655 (BuildMaster.loadConfig_Builders): walk old list correctly
5657 * buildbot/test/test_config.py: fix prefix= usage
5659 2004-09-06 Brian Warner <warner@lothar.com>
5663 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5664 poll a P4 depot looking for recent changes. Thanks to Dave
5665 Peticolas for the contribution. Probably needs some testing after
5668 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5669 requires manual client setup for each buildslave. Rather
5670 experimental. Thanks again to Dave Peticolas.
5671 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5673 * buildbot/changes/changes.py (Change): add a .revision attribute,
5674 which will eventually be used to generate source-stamp values.
5676 * buildbot/process/step.py (RemoteCommand.start): use
5677 notifyOnDisconnect to notice when we lose the slave, then treat it
5678 like an exception. This allows LogFiles to be closed and the build
5679 to be wrapped up normally. Be sure to remove the disconnect
5680 notification when the step completes so we don't accumulate a
5681 bazillion such notifications which will fire weeks later (when the
5682 slave finally disconnects normally). Fixes SF#915807, thanks to
5683 spiv (Andrew Bennetts) for the report.
5684 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5685 really isn't Logged- specific
5686 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5687 header, since it's almost always going to be appended to an
5689 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5690 update test to handle use of notifyOnDisconnect
5692 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5693 don't clear .ETA and .currentBuild when going offline, let the
5694 current build clean up after itself
5696 * buildbot/process/builder.py (Builder.detached): wait a moment
5697 before doing things like stopping the current build, because the
5698 current step will probably notice the disconnect and cleanup the
5700 * buildbot/test/test_run.py (Status.tearDown): update test to
5701 handle asynchronous build-detachment
5703 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5705 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5706 hush a debug message
5708 2004-09-05 Brian Warner <warner@lothar.com>
5710 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5711 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5712 kernels do this: the fcntl module has the F_NOTIFY constant, but
5713 the kernel itself doesn't support the operation. Thanks to Olly
5714 Betts for spotting the problem.
5716 * buildbot/process/step.py (Darcs): new source-checkout command
5717 (Arch): new source-checkout command
5718 (todo_P4): fix constructor syntax, still just a placeholder
5719 * buildbot/test/test_vc.py (VC.testDarcs): test it
5720 (VC.testDarcsHTTP): same, via localhost HTTP
5722 (VC.testArchHTTP): same
5723 * NEWS: mention new features
5725 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5726 which tells the step to stash stdout text locally (in .stdout).
5727 Slave-side Commands can use this to make decisions based upon the
5728 output of the the ShellCommand (not just the exit code).
5729 (Darcs): New source-checkout command
5730 (Arch): New source-checkout command, uses .keepStdout in one place
5731 where it needs to discover the archive's default name.
5733 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5734 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5735 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5737 * buildbot/process/step.py (ShellCommand.describe): add an
5738 alternate .descriptionDone attribute which provides descriptive
5739 text when the step is complete. .description can be ["compiling"],
5740 for use while the step is running, then .descriptionDone can be
5741 ["compile"], used alone when the step succeeds or with "failed" when
5742 it does not. Updated other steps to use the new text.
5743 * buildbot/process/step_twisted.py: same
5744 * buildbot/test/test_run.py: update tests to match
5746 2004-08-30 Brian Warner <warner@lothar.com>
5748 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5749 (CVS.__init__): send 'patch' argument to slave
5750 (CVS.start): don't create the LoggedRemoteCommand until start(),
5751 so we can catch a .patch added after __init__
5752 (SVN.__init__): add 'patch' to SVN too
5755 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5756 argument, to let commands push data into the process' stdin pipe.
5757 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5758 is in use, since closing a PTY doesn't really affect the process
5759 in the right way (in particular, I couldn't run /usr/bin/patch
5761 (SourceBase.doPatch): handle 'patch' argument
5763 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5766 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5767 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5769 * buildbot/master.py (BotPerspective.got_commands): get command
5770 versions from slave, give to each builder
5771 * buildbot/process/builder.py (Builder.attached): stash slave
5772 command versions in .remoteCommands
5774 * docs/steps.xhtml: bring docs in-line with reality
5776 * buildbot/process/step.py (CVS.__init__): more brutal
5777 compatibility code removal
5778 (SVN.__init__): same
5780 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5781 (SlaveShellCommand.start): require ['workdir'] argument, remove
5782 the ['dir'] fallback (compatibility will come later)
5783 (SourceBase): update docs
5784 (SourceBase.start): remove ['directory'] fallback
5787 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5788 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5789 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5791 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5792 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5793 code.. I will figure out 0.5.0-compatibility hooks later)
5795 2004-08-30 Brian Warner <warner@lothar.com>
5797 * buildbot/process/process_twisted.py: rewrite in terms of new
5798 BuildFactory base class. It got significantly shorter. Yay
5801 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5802 work with the new "self.build isn't nailed down until we call
5803 step.start()" scheme: specifically, __init__ is called before the
5804 build has decided on which Changes are going in, so we don't scan
5805 build.allFiles() for .xhtml files until start()
5806 (HLint.commandComplete): use getText(), not getStdout()
5807 (RunUnitTests.start): same: don't use .build until start()
5808 (RunUnitTests.describe): oops, don't report (None) when using
5810 (RunUnitTests.commandComplete): use getText()
5811 (RunUnitTests.createSummary): same
5812 (BuildDebs.commandComplete): same
5814 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5815 set args['command'] until start(), since our BuildStep is allowed
5816 to change their mind up until that point
5817 (TreeSize.commandComplete): use getText(), not getStdout()
5819 * docs/examples/twisted_master.cfg: update to current standards
5821 * docs/factories.xhtml: update
5822 * buildbot/process/factory.py: implement all the common factories
5823 described in the docs. The Trial factory doesn't work yet, and
5824 I've probably broken all the process_twisted.py factories in the
5825 process. There are compatibility classes left in for things like
5826 the old BasicBuildFactory, but subclasses of them are unlikely to
5828 * docs/examples/glib_master.cfg: use new BuildFactories
5829 * docs/examples/hello.cfg: same
5831 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5832 explicit 'workdir' args
5834 * buildbot/process/base.py (BuildFactory): move factories to ..
5835 * buildbot/process/factory.py (BuildFactory): .. here
5836 * buildbot/process/process_twisted.py: handle move
5837 * buildbot/test/test_config.py: same
5838 * buildbot/test/test_run.py: same
5839 * buildbot/test/test_steps.py: same
5840 * buildbot/test/test_vc.py: same
5841 * docs/factories.xhtml: same
5843 * NEWS: mention config changes that require updating master.cfg
5845 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5846 argument to all steps that weren't given one already, pointing at
5847 the "build/" directory.
5849 * docs/examples/hello.cfg: remove explicit 'workdir' args
5851 * docs/factories.xhtml: document standard BuildFactory clases,
5852 including a bunch which are have not yet been written
5854 2004-08-29 Brian Warner <warner@lothar.com>
5856 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5857 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5858 buildbot.status.builder so they aren't quite so internal
5859 * buildbot/process/base.py, buildbot/process/builder.py: same
5860 * buildbot/process/maxq.py, buildbot/process/step.py: same
5861 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5862 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5863 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5865 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5866 to handle new getLogs()-returns-list behavior
5867 (StatusResourceBuildStep.getChild): same
5868 (StepBox.getBox): same
5869 (WaterfallStatusResource.phase0): same
5871 * docs/source.xhtml: document how Buildbot uses version-control
5872 systems (output side: how we get source trees)
5873 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5874 systems (input side: how we learn about Changes)
5876 * buildbot/master.py (Manhole): use ComparableMixin
5877 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5878 * buildbot/changes/mail.py (MaildirSource): same
5879 * buildbot/status/client.py (PBListener): same
5880 * buildbot/status/html.py (Waterfall): same
5881 * buildbot/status/words.py (IRC): same
5883 * NEWS: start describing new features
5885 * buildbot/status/mail.py (MailNotifier): finish implementation.
5886 The message body is still a bit sparse.
5887 * buildbot/test/test_status.py (Mail): test it
5889 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5890 and __hash__ methods I wind up adding everywhere. Specifically
5891 intended to support the buildbot config-file update scheme where
5892 we compare, say, the old list of IStatusTargets against the new
5893 one and don't touch something which shows up on both lists.
5894 * buildbot/test/test_util.py (Compare): test case for it
5896 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5897 return a list instead of a dict
5898 (IBuildStepStatus.getLogs): same. The idea is that steps create
5899 logs with vaguely unique names (although their uniqueness is not
5900 guaranteed). Thus a compilation step should create its sole
5901 logfile with the name 'compile', and contribute it to the
5902 BuildStatus. If a step has two logfiles, try to create them with
5903 different names (like 'test.log' and 'test.summary'), and only
5904 contribute the important ones to the overall BuildStatus.
5905 * buildbot/status/builder.py (Event.getLogs): same
5906 (BuildStepStatus): fix default .text and .results
5907 (BuildStepStatus.addLog): switch to list-like .getLogs()
5908 (BuildStepStatus.stepFinished): same
5909 (BuildStatus.text): fix default .text
5910 (BuildStatus.getLogs): temporary hack to return all logs (from all
5911 child BuildStepStatus objects). Needs to be fixed to only report
5912 the significant ones (as contributed by the steps themselves)
5913 * buildbot/test/test_run.py: handle list-like .getLogs()
5914 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5916 2004-08-28 Brian Warner <warner@lothar.com>
5918 * buildbot/process/builder.py (Builder.attached): serialize the
5919 attachment process, so the attach-watcher isn't called until the
5920 slave is really available. Add detached watchers too, which makes
5923 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5925 * buildbot/test/test_swap.py: remove dead code
5927 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5928 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5929 sort of as if the command being run exited with a -1. There may
5930 still be some holes in this scheme.
5931 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5932 -r option appears before the module list
5933 * buildbot/process/step.py (CVS): add 'revision' argument
5935 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5936 when sending updates or stepComplete messages to the master, since
5937 we don't currently care whether they arrive or not. When we revamp
5938 the master/slave protocol to really resume interrupted builds,
5939 this will need revisiting.
5940 (lostRemote): remove spurious print
5942 * buildbot/master.py (BotPerspective.attached): serialize the
5943 new-builder interrogation process, to make testing easier
5944 (BotMaster.waitUntilBuilderDetached): convenience function
5946 * buildbot/status/builder.py (BuilderStatus): prune old builds
5947 (BuildStatus.pruneSteps): .. and steps
5948 (BuildStepStatus.pruneLogs): .. and logs
5949 (BuilderStatus.getBuild): handle missing builds
5950 * buildbot/status/html.py (StatusResourceBuild.body): display build
5951 status in the per-build page
5952 (BuildBox.getBox): color finished builds in the per-build box
5954 2004-08-27 Brian Warner <warner@lothar.com>
5956 * buildbot/status/mail.py (MailNotifier): new notification class,
5959 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5960 variants of a common base class which handles all the mode= logic
5962 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5964 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5966 2004-08-26 Brian Warner <warner@lothar.com>
5968 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5971 * buildbot/test/test_run.py: update to new Logfile interface, new
5972 buildbot.slave modules
5973 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5975 * MANIFEST.in: new sample config file
5976 * docs/examples/hello.cfg: same
5978 * buildbot/process/step_twisted.py: remove dead import
5980 * buildbot/process/step.py (RemoteCommand.run): catch errors
5982 (RemoteCommand.remote_update): ignore updates that arrive after
5984 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5985 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5986 the responsibilities of the subclass's methods
5987 (BuildStep.failed): catch errors during failure processing
5988 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5989 (CVS): move to a mode= argument (described in docstring), rather
5990 than the ungainly clobber=/export=/copydir= combination.
5991 (SVN): add mode= functionality to SVN too
5992 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5994 * buildbot/process/base.py (Build.startNextStep): catch errors
5995 during s.startStep()
5997 * buildbot/clients/base.py: update to new PB client interface.
5998 gtkPanes is still broken
6000 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6001 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6002 * setup.py: add buildbot.slave module
6003 * buildbot/bb_tap.py: handle move
6004 * buildbot/slave/registry.py: place to register commands, w/versions
6005 * buildbot/slave/bot.py: major simplifications
6006 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6007 instead of a fixed table. Eventually this will make the slave more
6008 extensible. Use 'start' method on the command, not .startCommand.
6009 Fix unsafeTracebacks handling (I think).
6010 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6011 helper class with a .start method that returns a Deferred.
6012 SlaveShellCommand is the form reached by the buildmaster. Commands
6013 which use multiple ShellCommands can just chain them as Deferreds,
6014 with some helper methods in Command (_abandonOnFailure and
6015 _checkAbandoned) to bail on rc!=0.
6016 (CVSCommand): prefer new mode= argument
6017 (SVNFetch): add mode= argument
6019 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6020 put a useful reason string on the build
6022 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6023 core functionality into an IStatusLog object
6024 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6025 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6026 (StatusResourceBuild.body): use proper accessor methods
6027 * buildbot/status/client.py (RemoteLog): PB-access goes here
6028 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6029 which delivers log contents too
6030 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6031 * buildbot/status/event.py: remove old Logfile completely
6033 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6034 subscription interface for IStatusLog subscriptions just like all
6035 other the status subscriptions
6036 (IStatusReceiver.logChunk): method called on subscribers
6038 2004-08-24 Brian Warner <warner@lothar.com>
6040 * buildbot/process/builder.py (Builder._pong): oops, ping response
6041 includes a result (the implicit None returned by remote_print).
6042 Accept it so the _pong method handles the response correctly.
6044 2004-08-06 Brian Warner <warner@lothar.com>
6046 * buildbot/test/test_config.py: update IRC, PBListener tests
6048 * buildbot/status/client.py (StatusClientPerspective): total
6049 rewrite to match new IStatus interfaces. New subscription scheme.
6050 There are still a few optimizations to make (sending down extra
6051 information with event messages so the client doesn't have to do a
6052 round trip). The logfile-retrieval code is probably still broken.
6053 Moved the PB service into its own port, you can no longer share a
6054 TCP socket between a PBListener and, say, the slaveport (this
6055 should be fixed eventually).
6056 * buildbot/clients/base.py (Client): revamp to match. still needs
6057 a lot of work, but basic event reporting works fine. gtkPanes is
6060 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6061 instance talks to a single irc server. Threw out all the old
6062 multi-server handling code. Still need to add back in
6063 builder-control (i.e. "force build")
6065 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6066 more random text to the as-yet-unreachable per-step page
6068 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6069 rename to stepETAUpdate
6070 (BuildStatus.subscribe): add build-wide ETA updates
6071 (BuilderStatus.getState): remove more cruft
6072 (BuilderStatus.getCurrentBuild): remove more cruft
6073 (BuilderStatus.buildStarted): really handle tuple-subscription
6074 * buildbot/test/test_run.py (Status.testSlave): handle the
6075 stepETAUpdate rename
6077 * buildbot/master.py (BuildMaster): don't add a default
6078 StatusClientService. Don't add a default IrcStatusFactory. Both
6079 are now added through c['status'] in the config file. c['irc'] is
6080 accepted for backwards compatibility, the only quirk is you cannot
6081 use c['irc'] to specify IRC servers on ports other than 6667.
6083 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6084 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6085 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6086 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6089 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6090 the buildmaster to re-read its config file
6093 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6094 find out the port our server is running on
6095 (WebTest.test_webPathname_port): same
6097 * buildbot/test/test_config.py (testWebPortnum): test it
6098 (testWebPathname): ditto
6100 * docs/config.xhtml: document new c['status'] configuration option
6102 * buildbot/status/html.py (Waterfall): new top-level class which
6103 can be added to c['status']. This creates the Site as well as the
6104 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6105 reachable as .parent, for everything.
6107 * buildbot/master.py (Manhole): make it a normal service Child
6108 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6109 webPathname. It will eventually replace c['irc'] and the implicit
6110 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6111 in as (deprecated) backward compatibility hooks for now.
6114 * buildbot/process/builder.py (Builder.buildFinished): don't
6115 inform out builder_status about a finished build, as it finds out
6116 through its child BuildStatus object
6118 * buildbot/status/html.py: extensive revamp. Use adapters to make
6119 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6120 have both starting and finishing times and adjust the waterfall
6121 display accordingly, using spacers if necessary. Use SlaveStatus
6122 to get buildslave info.
6123 (StatusResourceBuildStep): new just-one-step resource, used to get
6124 logfiles. No actual href to it yet.
6126 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6127 the time being, until I get the file-naming scheme right
6129 * buildbot/status/builder.py (Event): clean started/finished names
6130 (BuildStatus.isFinished): .finished is not None is the right test
6131 (BuildStatus.buildStarted): track started/finished times ourselves
6132 (BuilderStatus.getSlave): provide access to SlaveStatus object
6133 (BuilderStatus.getLastFinishedBuild): all builds are now in
6134 .builds, even the currently-running one. Accomodate this change.
6135 (BuilderStatus.eventGenerator): new per-builder event generator.
6136 Returns BuildStepStatus and BuildStatus objects, since they can
6137 both be adapted as necessary.
6138 (BuilderStatus.addEvent): clean up started/finished attributes
6139 (BuilderStatus.startBuild,finishBuild): remove dead code
6140 (SlaveStatus): new object to provide ISlaveStatus
6142 * buildbot/process/step.py (ShellCommand.getColor): actually
6143 return the color instead of setting it ourselves
6144 (CVS.__init__): pull .timeout and .workdir options out of
6145 **kwargs, since BuildStep will ignore them. Without this neither
6146 will be sent to the slave correctly.
6147 (SVN.__init__): same
6149 * buildbot/process/builder.py (Builder): move flags to class-level
6151 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6152 SlaveStatus handle that
6154 * buildbot/process/base.py (Build.firstEvent): remove dead code
6155 (Build.stopBuild): bugfix
6157 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6159 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6160 (ChangeMaster.eventGenerator): yield Changes, since there are now
6161 Adapters to turn them into HTML boxes
6163 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6164 (BotPerspective.attached): feed a SlaveStatus object
6165 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6166 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6168 * buildbot/interfaces.py: API additions
6169 (ISlaveStatus): place to get slave status
6171 2004-08-04 Brian Warner <warner@lothar.com>
6173 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6174 the delay finishes, so the step is marked as SUCCESS
6176 * buildbot/test/test_run.py (Status.testSlave): cover more of
6177 IBuildStatus and IBuildStepStatus
6179 * buildbot/status/progress.py (StepProgress): move some flags to
6180 class-level attributes
6181 (StepProgress.remaining): if there are no other progress metrics
6182 to go by, fall back to elapsed time
6183 (StepProgress.setExpectations): take a dict of metrics instead of
6185 (BuildProgress.setExpectationsFrom): pull expectations from the
6186 Expectations, instead of having it push them to the BuildProgress
6187 (Expectations): move some flags to class-level attributes
6188 (Expectations.__init__): copy per-step times from the
6190 (Expectations.expectedBuildTime): new method for per-build ETA
6192 * buildbot/status/event.py (Logfile): move some flags to
6193 class-level attributes
6194 (Logfile.logProgressTo): better method name, let step set the
6195 progress axis name (instead of always being "output")
6197 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6198 times directly, rather than depending upon the (possibly missing)
6199 .progress object. Use 'None' to indicate "not started/finished
6201 (BuildStepStatus.getExpectations): oops, return the full list of
6203 (BuilderStatus._buildFinished): append finished builds to .builds
6205 * buildbot/process/step.py (BuildStep): add separate .useProgress
6206 flag, since empty .progressMetrics[] still implies that time is a
6208 (CVS): set up the cmd in __init__, instead of waiting for start()
6210 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6211 calculation, this will eventually turn into a proper sourceStamp
6212 (Build.setupBuild): tell the Progress to load from the Expectations,
6213 instead of having the Expectations stuff things into the Progress
6214 (Build.buildException): add a build-level errback to make sure the
6215 build's Deferred fires even in case of exceptions
6217 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6219 * buildbot/process/builder.py (Builder.forceBuild): convey the
6220 reason instead of creating a fake Change
6222 * docs/examples/twisted_master.cfg: update to match reality
6224 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6225 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6226 fix or remove broken/breaking tests
6228 * buildbot/status/event.py (Logfile.__len__): remove evil method
6230 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6231 missing .build, for test convenience
6233 * buildbot/process/step_twisted.py: import fixes
6235 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6237 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6238 .statusbag reference
6240 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6241 connection at shutdown, and stop it from reconnecting
6243 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6244 chase down remote-execution bugs
6246 * buildbot/process/step.py: more fixes, remove
6247 BuildStep.setStatus()
6248 * buildbot/status/builder.py: move setStatus() functionality into
6250 * buildbot/status/event.py: minor fixes
6252 2004-08-03 Brian Warner <warner@lothar.com>
6254 * buildbot/process/base.py, buildbot/process/builder.py
6255 * buildbot/process/step.py, buildbot/status/builder.py
6256 * buildbot/status/event.py, buildbot/test/test_run.py:
6257 fix status delivery, get a basic test case working
6258 * buildbot/master.py: finish implementing basic status delivery,
6259 temporarily disable HTML/IRC/PB status sources
6261 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6263 * buildbot/status/progress.py (BuildProgress): remove dead code
6265 * buildbot/interfaces.py
6266 * buildbot/process/base.py, buildbot/process/builder.py
6267 * buildbot/process/step.py, buildbot/process/step_twisted.py
6268 * buildbot/status/builder.py: Complete overhaul of the all
6269 status-delivery code, unifying all types of status clients (HTML,
6270 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6271 look like. This commit is a checkpointing of the work-in-progress:
6272 the input side is mostly done (Builders/Builds sending status
6273 to the BuilderStatus/BuildStatus objects), but the output side has
6274 not yet been started (HTML resources querying BuilderStatus
6275 objects). Things are probably very broken right now and may remain
6276 so for several weeks, I apologize for the disruption.
6278 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6279 HTML as the log's contents. Currently used for exception tracebacks.
6280 * buildbot/status/progress.py: minor spelling changes
6282 2004-08-02 Brian Warner <warner@lothar.com>
6284 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6285 in mozilla. Also added stylesheets copied from Twisted's docs.
6286 Remember that these files are meant to be run through Lore first.
6287 Thanks to Philipp Frauenfelder for the fixes.
6288 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6289 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6290 * docs/template.tpl: added a Lore template
6292 2004-07-29 Brian Warner <warner@lothar.com>
6294 * buildbot/interfaces.py: revamp status delivery. This is the
6295 preview: these are the Interfaces that will be provided by new
6296 Builder code, and to which the current HTML/IRC/PB status
6297 displayers will be adapted.
6299 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6300 on the SlaveBuilder, not the Bot.
6301 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6303 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6304 set .usePTY on the FakeSlaveBuilder
6306 2004-07-25 Brian Warner <warner@lothar.com>
6308 * buildbot/changes/freshcvs.py: add some debug log messages
6309 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6310 disabled 'setFilter' syntax
6311 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6312 don't end with a slash
6314 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6316 * setup.py: bump to 0.5.0+ while between releases
6318 2004-07-23 Brian Warner <warner@lothar.com>
6320 * setup.py (version): Releasing buildbot-0.5.0
6322 2004-07-23 Brian Warner <warner@lothar.com>
6324 * README: update for 0.5.0 release
6326 * NEWS: update for 0.5.0 release
6328 2004-07-22 Brian Warner <warner@lothar.com>
6330 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6331 mktap-time configuration flag (--usepty=1, --usepty=0)
6332 * buildbot/bot.py: same
6334 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6335 an 'info' directory being unwanted
6337 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6338 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6339 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6340 and earlier), use a FreshCVSSourceOldcred instead.
6341 (test): simple test routine: connect to server, print changes
6343 * buildbot/changes/changes.py (Change.getTime): make it possible
6344 to print un-timestamped changes
6346 * buildbot/master.py (makeApp): delete ancient dead code
6347 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6348 * buildbot/test/test_config.py (testFindConfigFile): test it
6350 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6351 instead of win32 one
6354 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6355 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6358 * buildbot/process/base.py (Builder.__init__): change constructor
6359 to accept a dictionary of config data, rather than discrete
6360 name/slave/builddir/factory arguments
6362 * docs/examples/twisted_master.cfg: update to new syntax
6363 * docs/examples/glib_master.cfg: same
6364 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6365 rough tests of the new syntax
6368 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6369 to be an int, which means "run a web.distrib sub-server on a TCP
6370 port". This lets you publish the buildbot status page to a remote
6371 twisted.web server (using distrib.ResourceSubscription). Also
6372 rename the local attributes used to hold these web things so
6373 they're more in touch with reality.
6374 * buildbot/test/test_web.py: test webPortnum and webPathname
6375 * docs/config.xhtml: document this new use of webPathname
6377 * docs/config.xhtml: new document, slightly ahead of reality
6379 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6380 'prefix' handling: treat it as a simple string to check with
6381 .startswith, instead of treating it as a directory. This allows
6382 sub-directories to be used. If you use prefix=, you should give it
6383 a string that starts just below the CVSROOT and ends with a slash.
6384 This prefix will be stripped from all filenames, and filenames
6385 which do not start with it will be ignored.
6387 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6389 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6390 and --exclude (inverse of --include). SVN post-commit hooks
6391 now have total control over which changes get sent to buildbot and which
6394 2004-07-10 Brian Warner <warner@lothar.com>
6396 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6397 test case to match new API
6399 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6400 which crashed HTML display when self.entries=[] (needed to
6401 distinguish between [], which means "no entries yet", and None,
6402 which means "the entries have been swapped out to disk, go fetch
6405 2004-07-04 Brian Warner <warner@lothar.com>
6407 * buildbot/process/step_twisted.py (countFailedTests): Count
6408 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6409 10kb from the end because any import errors are wedged there and
6410 they would make us think the test log was unparseable.
6411 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6413 2004-06-26 Brian Warner <warner@lothar.com>
6415 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6416 delete-*.pyc command into an actual BuildStep, so we can label it
6418 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6419 (FullTwistedBuildFactory): same
6421 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6423 * contrib/fakechange.py: Add an errback when sending the fake
6424 change, so we know it didn't work.
6426 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6428 * buildbot/process/step_twisted.py: Delete *.pyc files before
6429 calling trial, so it doesn't catch any old .pyc files whose .py
6430 files have been moved or deleted.
6432 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6433 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6434 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6435 instead of ["twisted.test"], so that the end result is "trial -R
6438 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6439 regular expression to match filenames that should be ignored when
6440 changed. Also add a --revision parameter that specifies the
6441 revision to examine, which is useful for debugging.
6443 2004-06-25 Brian Warner <warner@lothar.com>
6445 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6446 summary of warnings (like DeprecationWarnings), next to the
6449 2004-05-13 Brian Warner <warner@lothar.com>
6451 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6452 we now have a w32 build slave courtesy of Mike Taylor.
6454 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6455 so broken. Fixed a race condition that tripped up interlocked
6456 builds and caused the status to be stuck at "Interlocked" forever.
6457 The twisted buildbot's one interlocked build just so happened to
6458 never hit this case until recently (the feeding builds both pass
6459 before the interlocked build is attempted.. usually it has to wait
6461 (Builder._pong_failed): fix method signature
6463 * setup.py: bump to 0.4.3+ while between releases
6465 2004-04-30 Brian Warner <warner@lothar.com>
6467 * setup.py (version): Releasing buildbot-0.4.3
6469 2004-04-30 Brian Warner <warner@lothar.com>
6471 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6473 * README: update for 0.4.3 release
6475 * NEWS: update for 0.4.3 release
6477 * buildbot/master.py (BuildMaster.__getstate__): make sure
6478 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6480 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6481 .trial as a class attribute, for upgrade from 0.4.2
6483 * buildbot/changes/changes.py (Change.links): add .links for
6486 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6487 .textWatchers and .htmlWatchers at save time, since they are both
6488 volatile, should allow smooth 0.4.2 upgrade
6490 * buildbot/process/step.py (CVS.finishStatus): catch failed
6491 CVS/SVN commands so we can make the status box red
6493 2004-04-29 Brian Warner <warner@lothar.com>
6495 * buildbot/changes/freshcvs.py
6496 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6497 code to do setFilter(), which tells the freshcvs daemon to not
6498 send us stuff that we're not interested in. I will uncomment it
6499 when a new version of CVSToys is available in which setFilter()
6500 actually works, and I get a chance to test it better.
6502 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6504 * buildbot/master.py (Dispatcher): use a registration scheme
6505 instead of hardwired service names
6506 (BuildMaster): keep track of the Dispatcher to support
6509 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6510 PBChangeSource class instead of having it be an undocumented
6511 internal feature of the ChangeMaster. Split out the code into a
6513 * buildbot/changes/pb.py (PBChangeSource): same
6514 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6516 * docs/{factories|sources|steps}.xhtml: document some pieces
6518 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6519 using FCMaildirSource
6520 (f23osx): update OS-X builder to use python2.3, since the slave
6521 was updated to Panther (10.3.3)
6523 2004-03-21 Brian Warner <warner@lothar.com>
6525 * buildbot/process/process_twisted.py: factor out doCheckout, change
6526 to use SVN instead of CVS
6528 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6529 an SVN subclass easier
6530 (BasicSVN): subclass which uses Subversion instead of CVS
6532 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6534 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6536 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6538 2004-02-25 Brian Warner <warner@lothar.com>
6540 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6541 is now either a list (which is passed to spawnProcess directly) or
6542 a string (which gets passed to /bin/sh -c). This removes the useSH
6543 flag and the ArgslistCommand class. Also send status header at the
6544 start and end of each command, instead of having the master-side
6546 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6547 -r'. Update to use list-based arguments.
6548 (SVNFetch): use list-based arguments, use ['dir'] argument to
6550 * buildbot/test/test_steps.py (Commands): match changes
6552 * buildbot/process/step.py (InternalShellCommand.words): handle
6554 (SVN): inherit from CVS, cleanup
6556 * buildbot/status/event.py (Logfile.content): render in HTML, with
6557 stderr in red and headers (like the name of the command we're
6558 about to run) in blue. Add link to a second URL (url + "?text=1")
6559 to get just stdout/stderr in text/plain without markup. There is
6560 still a problem with .entries=None causing a crash, it seems to occur
6561 when the logfile is read before it is finished.
6563 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6564 timeout to the keepalives, and use it to explicitly do a
6565 loseConnection instead of waiting for TCP to notice the loss. This
6566 ought to clear up the silent-lossage problem.
6567 (unsafeTracebacks): pass exception tracebacks back to the master,
6568 makes it much easier to debug problems
6570 2004-02-23 Brian Warner <warner@lothar.com>
6572 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6573 the whole command to /bin/sh instead of execve [Johan Dahlin]
6574 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6575 '-r HEAD' [Johan Dahlin]
6576 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6578 * buildbot/changes/changes.py (Change): add links= argument, add
6579 asHTML method [Johan Dahlin]. Modified to make a bit more
6580 XHTMLish. Still not sure how to best use links= .
6582 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6583 Change.asHTML to display the change, not asText
6585 * buildbot/status/html.py (StatusResourceBuilder): web button to
6588 * buildbot/test/test_run.py: test to actually start a buildmaster
6591 * MANIFEST.in: bring back accidentally-dropped test helper files
6593 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6594 that require cvstoys if it is not installed
6596 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6597 values of "bin/trial" [Dave Peticolas]
6598 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6599 tests passed" when we didn't happen to run any tests
6601 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6602 flunkOnFailure [Johan Dahlin]
6604 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6605 multiple instances of the same Step class by suffixing "_2", etc,
6606 to the name until it is unique. This name needs to be unique
6607 because it is used as a key in the dictionary that tracks build
6609 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6612 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6614 2004-01-14 Brian Warner <warner@lothar.com>
6616 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6617 kicked from a channel, log it
6619 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6620 something over whatever IRC channels the buildmaster is currently
6621 connected to. Added to try and track down a problem in which the
6622 master thinks it is still connected but the IRCd doesn't see it. I
6623 used a styles.Versioned this time, so hopefully users won't have
6624 to rebuild their .tap files this time.
6625 * contrib/debug.glade: add a "Poke IRC" button
6626 * contrib/debugclient.py: same
6628 * setup.py: bump to 0.4.2+ while between releases
6630 2004-01-08 Brian Warner <warner@lothar.com>
6632 * setup.py (version): Releasing buildbot-0.4.2
6634 2004-01-08 Brian Warner <warner@lothar.com>
6636 * NEWS: update for 0.4.2 release
6638 * README: document how to run the tests, now that they all pass
6640 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6642 * buildbot/process/step.py (CVS): add a global_options= argument,
6643 which lets you set CVS global options for the command like "-r"
6644 for read-only checkout, or "-R" to avoid writing in the
6646 * buildbot/slavecommand.py (CVSCommand): same
6648 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6649 testing easier (it is turned off when testing, to avoid the
6652 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6653 to make it easier to test: break generateStepID() out to a
6654 separate function, only update statusbag if it exists.
6655 (ShellCommands): create useful text for dict-based commands too.
6657 * test/*, buildbot/test/*: move unit tests under the buildbot/
6659 * setup.py (packages): install buildbot.test too
6661 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6662 * buildbot/test/test_steps.py: fix it, tests pass now
6664 2004-01-06 Brian Warner <warner@lothar.com>
6666 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6667 freshcvs mail uses a slightly different syntax for new
6668 directories. Update parser to handle either.
6669 * test/test_mailparse.py (Test1.testMsg9): test for same
6671 2003-12-21 Brian Warner <warner@lothar.com>
6673 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6674 'warnOnWarnings' so that lintian errors mark the build orange
6676 2003-12-17 Brian Warner <warner@lothar.com>
6678 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6679 messages emitted by Bonsai, contributed by Stephen Davis.
6681 * test/*: moved all tests to use trial instead of unittest. Some
6682 still fail (test_steps, test_slavecommand, and test_process).
6684 * setup.py (version): bump to 0.4.1+ while between releases
6686 2003-12-09 Brian Warner <warner@lothar.com>
6688 * setup.py (version): Releasing buildbot-0.4.1
6690 2003-12-09 Brian Warner <warner@lothar.com>
6692 * NEWS: update for 0.4.1 release
6694 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6695 freebsd builder code a little bit
6697 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6698 don't try to compare attributes of different classes
6699 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6700 (MaildirSource.messageReceived): fix Change delivery
6702 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6703 into the config file's namespace before loading it, like the
6704 documentation claims it does
6705 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6706 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6707 daemon comes back online
6709 2003-12-08 Brian Warner <warner@lothar.com>
6711 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6712 so the example will work with online=0 as well
6714 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6715 fix the __implements__ line
6717 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6718 class a twisted.application.service.Service, use startService to
6721 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6722 directory fd instead of simple open(). I'm sure this used to work,
6723 but the current version of python refuses to open directories with
6726 2003-12-05 Brian Warner <warner@lothar.com>
6728 * setup.py (version): bump to 0.4.0+ while between releases
6730 2003-12-05 Brian Warner <warner@lothar.com>
6732 * setup.py (version): Releasing buildbot-0.4.0
6734 2003-12-05 Brian Warner <warner@lothar.com>
6736 * docs/examples/glib_master.cfg: replace old sample scripts with
6737 new-style config files
6738 * MANIFEST.in: include .cfg files in distribution tarball
6740 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6741 implement a dummy method to avoid the exception that occurs when
6742 freshcvs sends this to us.
6744 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6745 removed the method, as it broke reconnection. Apparently
6746 stopFactory is called each time the connection attempt fails. Must
6748 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6749 attribute before serialization, since without stopFactory the
6750 reconnect timer may still be active and they aren't serializable.
6752 * test/test_mailparse.py (ParseTest): test with 'self' argument
6754 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6755 argument, as these "functions" are invoked like methods from class
6756 attributes and therefore always get an instance as the first
6759 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6760 message: thanks to Stephen Davis for the catch
6762 2003-12-04 Brian Warner <warner@lothar.com>
6764 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6765 twisted's standard ReconnectingClientFactory. Handles both oldcred
6766 and newcred connections. Also has a bug-workaround for
6767 ReconnectingClientFactory serializing its connector when it
6770 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6771 pbutil. Replace makeApp stuff with proper newcred/mktap
6772 makeService(). Don't serialize Ephemerals on shutdown.
6774 * buildbot/changes/changes.py (ChangeMaster): make it a
6775 MultiService and add the sources as children, to get startService
6776 and stopService for free. This also gets rid of the .running flag.
6778 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6779 new pbutil, turn into a TCPClient at the same time (to get
6780 startService for free). Two variants exist: FreshCVSSourceOldcred
6781 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6782 yet, but when it does, we'll be ready).
6783 (FreshCVSSource.notify): handle paths which are empty after the
6784 prefix is stripped. This only happens when the top-level (prefix)
6785 directory is added, at the very beginning of a Repository's life.
6787 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6788 Now the only reconnecting code is in the factory where it belongs.
6789 (Builder.unsubscribe): unregister the disconnect callback when we
6790 delete the builder on command from the master (i.e. when the
6791 buildmaster is reconfigured and that builder goes away). This
6792 fixes a multiple-delete exception when the status client is shut
6794 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6797 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6798 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6800 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6802 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6803 a list of globs (ugh). The testdir will be searched for files
6804 named *.tests and run the tests in the order specified in each of
6805 those files. This allows for "dependancies" between tests to be
6808 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6809 argument to pass to run_maxq.py, instead of a glob.
6811 2003-10-17 Brian Warner <warner@lothar.com>
6813 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6814 files that live in the sandbox
6816 2003-10-15 Brian Warner <warner@lothar.com>
6818 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6819 spelling error in "docs" count-warnings output
6820 (HLint.start): stupid thinko meant .xhtml files were ignored
6822 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6823 tests now that cReactor is banished to the sandbox
6825 2003-10-10 Brian Warner <warner@lothar.com>
6827 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6828 scheme: now .xhtml are sources and .html are generated
6830 2003-10-08 Brian Warner <warner@lothar.com>
6832 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6833 we were ignoring the 'randomly' parameter.
6835 2003-10-01 Brian Warner <warner@lothar.com>
6837 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6838 posix, to kill sub-children of aborted slavecommands.
6840 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6841 Clean up initialization: lastBuildStatus remains None until the
6842 first build has been completed.
6844 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6845 None as a lastBuildStatus
6846 * buildbot/clients/gtkPanes.py: same
6848 * buildbot/status/client.py (StatusClientService): keep
6849 BuilderStatus objects in self.statusbags . These objects now live
6850 here in the StatusClientService and are referenced by the Builder
6851 object, rather than the other way around.
6852 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6853 * buildbot/process/base.py (Builder): same
6854 * test/test_config.py (ConfigTest.testBuilders): same
6856 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6857 an existing builder, leave the statusbag alone. This will preserve the
6860 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6861 hook. This will probably go away in favor of a class in upcoming
6864 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6865 serviceName from newcred FreshCVSNotifiee setup
6867 2003-09-29 Brian Warner <warner@lothar.com>
6869 * buildbot/process/process_twisted.py: switch to new reactor
6871 * docs/examples/twisted_master.cfg: same
6873 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6875 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6876 botmaster reference instead of the oldapp service lookup
6878 * buildbot/master.py (BuildMaster.__init__): give the
6879 StatusClientService a reference to the botmaster to make it easier to
6882 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6884 * buildbot/status/html.py (Box.td): escape hreffy things so you
6885 can have spaces in things like builder names
6886 (StatusResourceBuilder.body)
6887 (WaterfallStatusResource.body)
6888 (WaterfallStatusResource.body0): same
6890 2003-09-25 Brian Warner <warner@lothar.com>
6892 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6893 rearrange the builder list when adding or removing builders: keep
6894 them in the order the user requested.
6895 * test/test_config.py (ConfigTest.testBuilders): verify it
6897 * contrib/debug.glade: give the debug window a name
6899 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6900 now wait on multiple interlocks. Fix code relating to that.
6901 (Builder.checkInterlocks): same
6902 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6904 * buildbot/master.py (BuildMaster.loadConfig): move from
6905 deprecated pb.BrokerFactory to new pb.PBServerFactory
6906 * test/test_config.py (ConfigTest.testWebPathname): same
6908 * docs/examples/twisted_master.cfg: fix interlock declaration
6910 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6911 Interlocks to their Builders into interlock.py .
6912 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6914 * test/test_config.py (ConfigTest.testInterlocks): validate
6917 * buildbot/process/base.py (Builder.__init__): better comments
6918 * buildbot/process/interlock.py (Interlock.__repr__): same
6919 (Interlock.deactivate): add .active flag, move the code that
6920 attaches/detaches builders into the Interlock
6922 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6924 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6925 tests using the new run_maxq.py script, and reporting failures by
6928 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6929 tests, reporting their success or failure in a buildbot-friendly
6932 2003-09-24 Brian Warner <warner@lothar.com>
6934 * docs/examples/twisted_master.cfg: example of a new-style config
6935 file. This lives in the buildmaster base directory as
6938 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6939 button to make the master re-read its config file
6941 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6942 buildmaster configuration from a file. This file can be re-read
6943 later, and the buildmaster will update itself to match the new
6944 desired configuration. Also use new Twisted Application class.
6945 * test/Makefile, test/test_config.py: unit tests for same
6947 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6948 FreshCVSSources comparable, to support reload.
6949 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6951 * buildbot/process/base.py (Builder): make them comparable, make
6952 Interlocks easier to attach, to support reload. Handle
6953 re-attachment of remote slaves.
6954 * buildbot/process/interlock.py (Interlock): same
6956 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6957 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6958 buildmaster taps are now constructed with mktap.
6959 * buildbot/status/client.py (StatusClientService): same
6961 * buildbot/status/words.py: move to new Services, add support to
6962 connect to multiple networks, add reload support, allow nickname
6963 to be configured on a per-network basis
6965 2003-09-20 Brian Warner <warner@lothar.com>
6967 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6968 the freebsd builder, now that the machine has been upgraded and no
6969 longer has python2.2
6971 * setup.py (version): bump to 0.3.5+ while between releases
6973 2003-09-19 Brian Warner <warner@lothar.com>
6975 * setup.py (version): Releasing buildbot-0.3.5
6977 2003-09-19 Brian Warner <warner@lothar.com>
6979 * NEWS: add post-0.3.4 notes
6981 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6983 * MANIFEST.in: add contrib/*
6985 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6986 use a remote root now: cvs.twistedmatrix.com
6988 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6990 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6991 compatibility with old servers
6992 (FreshCVSSource.start): and provide a way to use it
6993 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6995 * docs/examples/twisted_master.py (twisted_app): update to new
6997 (twisted_app): listen on new ~buildbot socket
6998 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7000 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7001 to reduce cvs bandwidth (update instead of full checkout)
7003 2003-09-11 Brian Warner <warner@lothar.com>
7005 * contrib/fakechange.py: demo how to connect to the changemaster
7006 port. You can use this technique to submit changes to the
7007 buildmaster from source control systems that offer a hook to run a
7008 script when changes are committed.
7010 * contrib/debugclient.py: tool to connect to the debug port. You
7011 can use it to force builds, submit fake changes, and wiggle the
7014 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7015 'Dispatcher' realm to handle all the different kinds of
7016 connections and Perspectives: buildslaves, the changemaster port,
7017 the debug port, and the status client port. NewCredPerspectives
7018 now have .attached/.detached methods called with the remote 'mind'
7019 reference, much like old perspectives did. All the pb.Services
7020 turned into ordinary app.ApplicationServices .
7021 (DebugService): went away, DebugPerspectives are now created
7022 directly by the Dispatcher.
7023 (makeApp): changed interface a little bit
7025 * buildbot/changes/changes.py: newcred
7026 * buildbot/status/client.py: newcred
7028 * buildbot/clients/base.py: newcred client side changes
7029 * buildbot/bot.py: ditto
7031 * docs/examples/glib_master.py: handle new makeApp() interface
7032 * docs/examples/twisted_master.py: ditto
7034 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7035 base newcred Perspectives on. This should go away once Twisted
7036 itself provides something sensible.
7039 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7041 * contrib/svn_buildbot.py: A program that you can call from your
7042 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7043 when a change in an SVN repository has happened. See the top of
7044 the file for some minimal usage info.
7046 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7048 * buildbot/slavecommand.py (ArglistCommand): Add new
7049 ArglistCommand that takes an argument list rather than a string as
7050 a parameter. Using a st.split() for argv is very bad.
7052 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7053 update to a particular revision rather than always checking out
7054 (still not very smart about it, there may be cases where the
7055 checkout becomes inconsistent).
7057 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7059 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7060 SVN fetch support. It can checkout (not update!) a specified
7061 revision from a specified repository to a specified directory.
7063 * buildbot/status/progress.py (Expectations.update): Fix an
7064 obvious bug (apparently created by the change described in the
7065 previous ChangeLog message) by moving a check to *after* the
7066 variable it checks is defined.
7069 2003-09-08 Brian Warner <warner@lothar.com>
7071 * buildbot/status/progress.py (Expectations.update): hack to catch
7072 an exception TTimo sees: sometimes the update() method seems to
7073 get called before the step has actually finished, so the .stopTime
7074 is not set, so no totalTime() is available and we average None
7075 with the previous value. Catch this and just don't update the
7076 metrics, and emit a log message.
7078 2003-08-24 Brian Warner <warner@lothar.com>
7080 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7081 parameter to set copydir='original' in CVS commands.
7083 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7085 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7086 which tells the command to maintain a separate original-source CVS
7087 workspace. For each build, this workspace will be updated, then
7088 the tree copied into a new workdir. This reduces CVS bandwidth
7089 (from a full checkout to a mere update) while doubling the local
7090 disk usage (to keep two copies of the tree).
7092 2003-08-21 Brian Warner <warner@lothar.com>
7094 * buildbot/status/event.py (Logfile.addEntry): if the master web
7095 server dies while we're serving a page, request.write raises
7096 pb.DeadReferenceError . Catch this and treat it like a
7097 notifyFinish event by dropping the request.
7099 2003-08-18 Brian Warner <warner@lothar.com>
7101 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7102 (instead of blowing up) if a force-build command is given without
7105 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7106 don't blow up if there aren't yet any Changes in the list
7108 2003-08-02 Brian Warner <warner@lothar.com>
7110 * buildbot/bot.py (updateApplication): don't set the .tap name,
7111 since we shouldn't assume we own the whole .tap file
7113 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7114 'mktap buildbot' (without a subcommand) better
7116 2003-07-29 Brian Warner <warner@lothar.com>
7118 * buildbot/status/words.py
7119 (IrcStatusFactory.clientConnectionLost): when we lose the
7120 connection to the IRC server, schedule a reconnection attempt.
7122 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7123 use shutil.rmtree instead of forking off an "rm -rf" command.
7124 rmtree may take a while and will block until it finishes, so we
7125 use "rm -rf" if available.
7127 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7128 freebsd buildslave badly
7130 * setup.py (version): bump to 0.3.4+ while between releases
7132 2003-07-28 Brian Warner <warner@lothar.com>
7134 * setup.py (version): Releasing buildbot-0.3.4
7136 2003-07-28 Brian Warner <warner@lothar.com>
7138 * NEWS: update in preparation for release
7140 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7141 process.signalProcess instead of os.kill, to improve w32
7144 * docs/examples/twisted_master.py (twisted_app): turn off
7145 win32eventreactor: the tests hang the buildslave badly
7147 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7148 failed builds, since usually the failures are consistent
7150 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7151 add compileOpts/compileOpts2 to reactors build
7153 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7154 (twisted_app): use both default and win32eventreactor on w32 build.
7155 Use both default and kqreactor on freebsd build.
7157 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7158 add compileOpts2, which is put after the build_ext argument. w32
7159 needs "-c mingw32" here.
7161 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7162 touch .acqpath, it goes away in recent Twisted releases
7164 * docs/examples/twisted_master.py (twisted_app): use "python" for
7165 the w32 buildslave, not "python2.2"
7167 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7168 the directory exists.. should hush an exception under w32
7170 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7171 ProcessTerminated -provided values for signal and exitCode rather
7172 than parsing the unix status code directly. This should remove one
7173 more roadblock for a w32-hosted buildslave.
7175 * test/test_mailparse.py: add test cases for Syncmail parser
7177 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7178 temporary compatibility import. Note! Start importing
7179 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7181 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7183 2003-07-27 Brian Warner <warner@lothar.com>
7185 * NEWS: started adding new features
7187 * buildbot/changes/mail.py: start work on Syncmail parser, move
7188 mail sources into their own file
7190 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7191 as implementing IChangeSource
7192 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7194 * buildbot/interfaces.py: define the IChangeSource interface
7196 2003-07-26 Brian Warner <warner@lothar.com>
7198 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7200 2003-06-25 Brian Warner <warner@lothar.com>
7202 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7205 2003-06-17 Brian Warner <warner@lothar.com>
7207 * buildbot/status/words.py: clean up method usage to avoid error
7208 in silly IRC command
7209 (IrcStatusBot.emit_status): round off seconds display
7211 * buildbot/process/base.py (Build): delete the timer when saving
7212 to the .tap file, and restore it (if it should still be running)
7213 upon restore. This should fix the "next build in -34 seconds"
7214 messages that result when the master is restarted while builds are
7215 sitting in the .waiting slot. If the time for the build has
7216 already passed, start it very soon (in 1 second).
7218 * buildbot/status/words.py: more silly commands
7220 * README (REQUIREMENTS): add URLs to all required software
7222 * buildbot/status/words.py ('last'): mention results of, and time
7225 2003-05-28 Brian Warner <warner@lothar.com>
7227 * buildbot/status/words.py: add 'last' command
7228 (IrcStatusBot.emit_status): add current-small text to 'status' output
7230 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7231 (twisted_app): remove spaces from OS-X builder name
7233 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7234 * buildbot/status/words.py: IRC bot should actually be useful now
7236 2003-05-23 Brian Warner <warner@lothar.com>
7238 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7239 "slave information" from $(slavedir)/info/* . These files are
7240 maintained by the slave administrator, and describe the
7241 machine/environment that is hosting the slave. Information from
7242 them is put into the "Builder" HTML page. Still need to establish
7243 a set of well-known filenames and meanings for this data: at the
7244 moment, *all* info/* files are sent to the master, but only
7245 'admin' and 'host' are used on that end.
7246 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7247 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7248 * buildbot/master.py (BotPerspective.got_info): ditto
7250 2003-05-22 Brian Warner <warner@lothar.com>
7252 * setup.py (version): bump version to 0.3.3+ while between releases
7254 2003-05-21 Brian Warner <warner@lothar.com>
7256 * setup.py: Releasing buildbot-0.3.3
7258 2003-05-21 Brian Warner <warner@lothar.com>
7260 * NEWS: 0.3.3 news items
7262 * README: describe --keepalive and life behind a NAT box
7264 * buildbot/bot.py (Bot.connected): implement application-level
7265 keepalives to deal with NAT timeouts, turn them on with
7266 --keepalive option or when SO_KEEPALIVE doesn't work.
7268 * buildbot/master.py (BotPerspective): accept keepalives silently
7270 * buildbot/process/base.py (Build.buildException): CopiedFailures
7271 don't carry as much information as local ones, so don't try to
7272 create a big HTMLized version of them.
7274 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7275 log file when step fails due to an exception, such as when the slave
7278 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7279 --testmodule argument instead of grepping for test-case-name tags
7280 ourselves. Remove FindUnitTests code.
7281 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7283 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7285 2003-05-16 Brian Warner <warner@lothar.com>
7287 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7288 argument to allow things like CFLAGS=-O0 to be passed without relying
7289 upon /bin/sh processing on the slave.
7291 * buildbot/process/step.py (InternalShellCommand.start): send
7293 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7294 'split' instead of letting /bin/sh do it. This should also remove
7295 the need for /bin/sh on the buildslave, making it more likely to
7298 * buildbot/status/html.py: html-escape text in blamelist.
7299 Add "force build" button to the Builder page.
7301 * buildbot/process/step_twisted.py (countFailedTests): look at
7302 last 1000 characters for status line, as import errors can put it
7303 before the -200 point.
7305 2003-05-15 Brian Warner <warner@lothar.com>
7307 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7309 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7310 make 'clobber' a parameter, so it is possible to have builds which
7311 do full tests but do a cvs update instead of hammering the CVS
7312 server with a full checkout each build
7314 * buildbot/process/step.py (InternalShellCommand): bump default
7315 timeout to 20 minutes
7317 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7318 the master to trigger a build. Run it via manhole.
7320 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7321 allow slaves to trigger any build that they host, to make life
7322 easier for slave admins who are testing out new build processes
7324 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7325 don't flunk cReactor or qtreactor on failure, since they fail alot
7326 these days. Do warnOnFailure instead.
7328 * buildbot/process/base.py: change Builder.buildable from a list
7329 into a single slot. When we don't have a slave, new builds (once
7330 they make it past the timeout) are now merged into an existing
7331 buildable one instead of being queued. With this change, a slave
7332 which has been away for a while doesn't get pounded with all the
7333 builds it missed, but instead just does a single build.
7335 2003-05-07 Brian Warner <warner@lothar.com>
7337 * setup.py (version): bump version to 0.3.2+ while between releases
7339 2003-05-07 Brian Warner <warner@lothar.com>
7341 * setup.py: Releasing buildbot-0.3.2
7343 2003-05-07 Brian Warner <warner@lothar.com>
7345 * setup.py: fix major packaging error: include subdirectories!
7347 * NEWS: add changes since last release
7349 * README (REQUIREMENTS): update twisted/python dependencies
7351 * buildbot/status/builder.py (Builder.startBuild): change
7352 BuildProcess API: now they should call startBuild/finishBuild
7353 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7354 keeping a list of builds in the statusbag, to support other kinds of
7356 (Builder.addClient): send current-activity-small to new clients
7357 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7360 * buildbot/status/client.py: drop RemoteReferences at shutdown
7362 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7364 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7365 more debug messages for remote status client
7367 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7368 (.stepFailed): only fire the Deferred once, even if both
7369 stepComplete and stepFailed are called. I think this can happen if
7370 an exception occurs at a weird time.
7372 * buildbot/status/words.py: work-in-progress: IRC status delivery
7374 2003-05-05 Brian Warner <warner@lothar.com>
7376 * docs/examples/twisted_master.py (twisted_app): hush internal
7377 python2.3 distutils deprecation warnings
7378 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7379 add compileOpts= argument which inserts extra args before the
7380 "setup.py build_ext" command. This can be used to give -Wignore
7381 warnings, to hush some internal python-2.3 deprecation messages.
7383 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7384 the ['twisted.test'] default test case to make it easier to change
7387 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7388 * buildbot/clients/gtkPanes.py: ditto
7390 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7391 arg to collapse RunUnitTestsRandomly into RunUnitTests
7392 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7393 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7395 * buildbot/status/html.py (StatusResource): shuffle Resources
7396 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7397 would serve the waterfall display, but the internal links were
7398 only valid on the trailing-slash version. The correct behavior is
7399 for the non-slashed one to serve a Redirect to the slashed one.
7400 This only shows up when the buildbot page is hanging off another
7401 server, like a Twisted-Web distributed server.
7403 * buildbot/status/event.py (Event, RemoteEvent): make Events
7404 pb.Cacheable, with RemoteEvent as the cached version. This removes
7405 a lot of explicit send-an-update code.
7406 * buildbot/status/builder.py (Builder): remove send-update code
7407 * buildbot/status/client.py (ClientBuilder): remove send-update
7408 code, and log errors that occur during callRemote (mostly to catch
7409 InsecureJelly exceptions)
7411 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7412 run Lore with the same python used in the rest of the build
7414 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7416 * buildbot/process/step_twisted.py (HLint): accept 'python'
7417 argument. Catch rc!=0 and mark the step as failed. This marks the
7418 build orange ("has warnings").
7419 (RunUnitTestsJelly): move out to step_twisted2.py
7421 * buildbot/util.py (ignoreStaleRefs): add utility function
7423 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7424 don't fake ETA object, it's too hard to get right
7426 2003-05-02 Brian Warner <warner@lothar.com>
7428 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7430 2003-05-01 Brian Warner <warner@lothar.com>
7432 * buildbot/status/html.py (StatusResource.body): oops, I was
7433 missing a <tr>, causing the waterfall page to be misrendered in
7434 everything except Galeon.
7436 2003-04-29 Brian Warner <warner@lothar.com>
7438 * docs/examples/twisted_master.py: make debuild use python-2.2
7439 explicitly, now that Twisted stopped supporting 2.1
7441 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7442 handle tuple results too. I keep forgetting this, which suggests
7443 it needs to be rethought.
7445 * setup.py (setup): bump version to 0.3.1+ while between releases
7447 2003-04-29 Brian Warner <warner@lothar.com>
7449 * setup.py: Releasing buildbot-0.3.1
7451 2003-04-29 Brian Warner <warner@lothar.com>
7453 * README (SUPPORT): add plea to send questions to the mailing list
7455 * NEWS, MANIFEST.in: add description of recent changes
7457 * docs/examples/twisted_master.py: add the code used to create the
7458 Twisted buildmaster, with passwords and such removed out to a
7461 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7462 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7463 buildmasters to not require CVSToys be installed.
7464 * README, docs/examples/glib_master: update to match the change
7466 * buildbot/clients/base.py, buildbot/bot.py,
7467 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7468 ReconnectingPB from CVSToys distribution to remove CVSToys
7469 dependency for build slaves and status clients. Buildmasters which
7470 use FreshCVSSources still require cvstoys be installed, of course.
7472 2003-04-25 Brian Warner <warner@lothar.com>
7474 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7475 runTestsRandomly arg to turn on trial -z
7477 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7478 experimental code to use trial's machine-parseable output to get
7479 more detailed test results. Still has some major issues.
7480 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7483 * buildbot/status/builder.py (Builder.setCurrentBuild):
7484 anticipating moving build history into statusbag, not used yet
7486 * buildbot/status/tests.py: code to centralize test results,
7487 doesn't work quite yet
7489 * buildbot/status/event.py (Event): use hasattr("setName") instead
7490 of isinstance for now.. need better long-term solution
7492 * buildbot/status/html.py: Remove old imports
7494 2003-04-24 Brian Warner <warner@lothar.com>
7496 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7497 ignore changes under doc/fun/ and sandbox/
7499 * buildbot/process/step_twisted.py: update pushEvent and friends.
7501 * buildbot/status/html.py (Box.td): replace event.buildername with
7502 event.parent.getSwappableName(). Needs more thought.
7504 * buildbot/status/builder.py (Builder): Replace pushEvent and
7505 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7506 Tell events they are being pruned with event.delete().
7508 * buildbot/process/base.py (Build): Remove Builder status-handling
7509 methods. s/pushEvent/setCurrentActivity/.
7511 * buildbot/process/step.py (BuildStep): clean up status delivery.
7512 Gouse builder.statusbag methods instead of intermediate builder
7513 methods. s/updateLastEvent/updateCurrentActivity/.
7514 s/finalizeLastEvent/finishCurrentActivity/. Use
7515 addFileToCurrentActivity for summaryFunction.
7517 * buildbot/status/event.py (Logfile): put data in a Swappable when
7519 (Event): add more setter methods. Remove .buildername, use .parent
7520 and getSwappableName instead (needs more thought).
7522 * buildbot/util.py (Swappable):
7523 * test/test_swap.py: don't bother setting filename at __init__
7524 time, do it later. Change setFilename args to take parent first,
7525 since it provides the most significant part of the filename.
7527 2003-04-23 Brian Warner <warner@lothar.com>
7529 * buildbot/status/event.py (Logfile.addEntry): append to previous
7532 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7533 anticipating Swappable
7534 (InternalShellCommand.remoteUpdate): split out various log-adding
7535 methods so subclasses can snarf stdout separately
7537 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7538 in anticipation of Swappable build logs
7539 (Builder.testsFinished): anticipating TestResults, still disabled
7541 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7544 * buildbot/status/event.py (Logfile): add (disabled) support for
7545 Swappable, not ready for use yet
7547 * buildbot/util.py (Swappable): object which is swapped out to
7548 disk after some period of no use.
7549 * test/test_swap.py: test buildbot.utils.Swappable
7551 2003-04-14 Brian Warner <warner@lothar.com>
7553 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7554 periodic-build timer. Set the .periodicBuildTime on a builder
7555 instance to some number of seconds to activate it.
7557 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7559 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7560 a way that survives result tuples
7562 2003-04-12 Brian Warner <warner@lothar.com>
7564 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7565 return a dict instead of a tuple: allow summarizers to provide
7566 multiple summaries if they want
7567 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7568 (debuildSummarizer): summarize lintian warnings/errors
7570 2003-04-10 Brian Warner <warner@lothar.com>
7572 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7574 2003-04-09 Brian Warner <warner@lothar.com>
7576 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7577 empty summaries: happens when the tests fail so hard they don't emit
7578 a parseable summary line.
7580 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7581 Allow summaryFunction to return None to indicate no summary should
7584 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7585 writing to stale HTTP requests: notice when they disconnect and
7586 remove the request from the list. Also add CacheToFile from
7587 moshez, will be used later.
7589 2003-04-08 Brian Warner <warner@lothar.com>
7591 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7592 should be an int, not a list of strings
7594 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7595 if we weren't actually connected
7597 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7598 to show the tail end of the trial text output
7600 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7601 hook to summarize the results of a ShellCommand
7603 2003-04-07 Brian Warner <warner@lothar.com>
7605 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7606 twisted test suite code into a single class.
7607 * buildbot/process/process_twisted.py: same
7609 2003-04-04 Brian Warner <warner@lothar.com>
7611 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7613 * README (SLAVE): document use of mktap to create slave .tap file
7614 (REQUIREMENTS): describe dependencies
7616 * buildbot/bb_tap.py, buildbot/plugins.tml:
7617 * buildbot/bot.py (updateApplication): Add mktap support for creating
7618 buildslave .tap files
7620 2003-03-28 Brian Warner <warner@lothar.com>
7622 * buildbot/process/step.py (InternalShellCommand.finished): handle
7623 new tuple result values (fix embarrasing bug that appeared during
7626 2003-03-27 Brian Warner <warner@lothar.com>
7628 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7631 2003-03-25 Brian Warner <warner@lothar.com>
7633 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7634 to overall build status
7635 * buildbot/clients/base.py (Builder): improve event printing
7636 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7637 instead of generic ShellCommand
7638 (Build): Add .stopBuild, use it when slave is detached
7640 * buildbot/process/step.py (Configure,Test): give the steps their
7641 own names and status strings
7643 * buildbot/status/html.py (StatusResource): add "show" argument,
7644 lets you limit the set of Builders being displayed.
7646 2003-03-20 Brian Warner <warner@lothar.com>
7648 * buildbot/process/basic.py: removed
7650 2003-03-19 Brian Warner <warner@lothar.com>
7652 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7653 turn off process-docs by default
7655 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7656 when displaying build information without anything in allBuilds[]
7658 * buildbot/bot.py (makeApp): really take password from sys.argv
7660 2003-03-18 Brian Warner <warner@lothar.com>
7662 * buildbot/bot.py (buildApp): take password from sys.argv
7664 * README: replace with more useful text
7666 * setup.py: add a real one
7667 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7669 * docs/PyCon-2003/: added sources for PyCon paper.
7671 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7672 now Build objects control the process and Builder only handles
7673 slave stuff and distribution of changes/status. A new BuildFactory
7674 class creates Build objects on demand.
7676 Created ConfigurableBuild which takes a list of steps to run. This
7677 makes it a lot easier to set up a new kind of build and moves us
7678 closer to being able to configure a build from a web page.
7680 * buildbot/process/step_twisted.py, process_twisted.py: move to
7681 new model. A lot of code went away.
7683 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7684 send lots of empty progress messages to the client.
7686 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7688 2003-02-20 Brian Warner <warner@lothar.com>
7690 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7692 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7693 Twisted bug that prevented non-pty processes from working just got
7694 fixed, and the bug that leaks ptys is still being investigated.
7696 * buildbot/process/step.py (CVS): send timeout arg to slave
7698 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7699 builders coming and going
7700 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7701 from CVSToys, handle lost-buildmaster
7703 * buildbot/status/client.py (StatusClientService.removeBuilder):
7704 Clean up status client protocol: send builders (with references)
7705 as they are created, rather than sending a list and requiring the
7706 client to figure out which ones are new.
7707 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7708 attempts to force a build on an unknown builder
7710 2003-02-19 Brian Warner <warner@lothar.com>
7712 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7713 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7714 Twisted stops leaking them.
7715 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7716 builder goes to an idle state.
7718 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7719 I figure out why CVS commands hang without them, and/or I fix the
7720 hung-command timeout
7722 2003-02-16 Brian Warner <warner@lothar.com>
7724 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7725 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7726 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7727 GenerateDocs now that they are prefixed with WARNING:.
7729 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7730 use manual href target instead of request.childLink
7732 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7733 display every second, but update the ETA every 5 seconds (or
7734 whenever) as remote_progress messages arrive.
7737 2003-02-12 Brian Warner <warner@lothar.com>
7739 * *: import current sources from home CVS repository
7743 # add-log-time-format: add-log-iso8601-time-string