1 2007-12-14 Brian Warner <warner@lothar.com>
3 * buildbot/steps/shell.py (ShellCommand.__init__): stash the
4 RemoteShellCommands args too, so things like 'workdir' and 'env'
5 and 'timeout' are preserved. This ought to fix #150.
6 * buildbot/test/test_steps.py (Steps.testClone): test it
8 2007-12-11 Brian Warner <warner@lothar.com>
10 * buildbot/scripts/startup.py (launch): use twisted.__version__,
11 rather than twisted.version, since the latter didn't appear until
12 Twisted-2.4.0 . This unbreaks 'buildbot start' on older Twisteds.
14 2007-12-08 Brian Warner <warner@lothar.com>
16 * docs/buildbot.texinfo (Git): document the fact that we require
17 Git 1.2.0 or later, and that the one shipped in dapper is too old.
19 * buildbot/scripts/startup.py (launch): twisted-2.5.0 and later
20 doesn't need twisted.scripts._twistw.run; instead, it uses
21 twisted.scripts.twistd.run on all platforms. Closes #53.
23 2007-11-30 Brian Warner <warner@lothar.com>
25 * buildbot/status/builder.py (BuilderStatus): small docs patches
26 from Greg Ward.. thanks!
27 * buildbot/process/base.py (Build): same
29 2007-11-29 Brian Warner <warner@lothar.com>
31 * buildbot/slave/commands.py (Mercurial._maybeFallback): add an
32 _abandonOnFailure call to the fallback, to skip the 'update' step
33 if the checkout fails.
34 (Mercurial._maybeFallback): More fixes: look for error messages
35 generated by every version of hg from 0.7 to the current 0.9.5,
36 including development versions as of rev 92991422a847. Also make
37 sure to return the exit code of non-fallbackable errors so that
38 other steps can attempt a workaround.
40 2007-11-28 Brian Warner <warner@lothar.com>
42 * buildbot/slave/commands.py (Mercurial._maybeFallback): improve
43 hg fallback so that it works when the client hg is new and the
44 server hg is old (the error message is different in this case).
46 2007-11-27 Brian Warner <warner@lothar.com>
48 * buildbot/test/test_p4poller.py: hush pyflakes warning
50 * buildbot/slave/commands.py (Mercurial._maybeFallback): when hg
51 is doing a 'clone' operation, to a remote repository (e.g. over
52 HTTP), and either the server or the client is hg-0.9.1 or older,
53 'hg clone' cannot accept a --rev argument: instead, you have to
54 clone the tip and then update back to the desired revision. Added
55 code to detect this failure mode and fall back to the clone+update
56 scheme. Closes #122 and #103.
57 (ShellCommand.__init__): add a keepStderr= flag to support this
59 * buildbot/test/test_vc.py (VCBase._do_vctest_clobber_2): add a
60 test that does a checkout to a specific version, to exercise the
61 mercurial limitation workaround.
62 (Mercurial.serveHTTP): add code to test hg checkout over HTTP,
63 using mercurial's built-in 'hg serve' command. Because of
64 limitations in hg, this code uses a randomly-selected TCP
65 port (rather than claiming a free one), so every once in a while
66 this test is going to fail because of a port-number collision.
68 * buildbot/test/test_vc.py (GitHelper.capable): skip Git tests if
69 the version of Git installed is older than 1.2.x . Git 1.1.3
70 doesn't accept 'git init' (it wants 'git init-db' instead) and the
71 branch tests fail. I know that Git 1.5.3.6 works. I don't know
72 what the dividing line is.. if someone can figure it out, please
73 update this check. Also, if someone can make buildbot's git
74 support handle older versions, please do that too! Addresses #130.
76 2007-11-21 Brian Warner <warner@lothar.com>
78 * lots: improve Git support, AMAZING patch from Haavard
79 Skinnemoen, complete with unit tests and docs, thanks! Closes #130.
80 * buildbot/scripts/tryclient.py (GitExtractor): add 'try' support
81 * buildbot/slave/commands.py (Git): accept branch and revisions,
82 and use 'git' instead of the 'cogito' wrapper
83 * buildbot/steps/source.py (Git.__init__): same
84 * buildbot/test/test_vc.py (BaseHelper.runCommand): offer control
87 (BaseHelper.dovc): same
88 (Git): unit tests for Git support. Wow!
89 * docs/buildbot.texinfo (Git): docs for Git support. Double Wow!
90 * contrib/git_buildbot.py: commit-hook script for git
93 * buildbot/changes/p4poller.py (P4Source._finished): don't let a
94 failure cause us to stop polling. Thanks to John Backstrand for
95 the patch. Closes #135.
96 * buildbot/test/test_p4poller.py (TestP4Poller.testFailedChanges):
98 (TestP4Poller.testFailedDescribe): same
100 * buildbot/status/web/waterfall.py (WaterfallStatusResource.body):
101 fix timezone calculation, we were always emitting DST, even in
102 winter. Thanks to Charles Lepple and John Saxton for the patch.
104 * buildbot/test/test_web.py (Waterfall.test_waterfall._check1): same
107 * lots: a whole batch of patches from Benoit Sigoure, referenced
108 in ticket #138. Thanks!
110 * buildbot/master.py (BuildMaster.loadConfig): builder names that
111 begin with an underscore are now reserved, so prohibit them from
112 appearing in the config file.
113 * NEWS: announce this change.
115 * buildbot/status/web/base.py: add buttons (to one_line_per_build
116 and one_box_per_builder) to force/stop builds on all Builders at
118 * buildbot/status/web/baseweb.py: same
119 (OneBoxPerBuilder.body): add links to the per-Builder page
121 * buildbot/status/web/builder.py: same
123 * buildbot/status/web/builder.py (StatusResourceBuilder.body):
124 factor out force/stop form generation
125 * buildbot/status/web/base.py: same
126 * buildbot/status/web/build.py: same
128 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
129 simplify some 'if' statements
130 (StatusResourceBuilder.build_line): add a 'Stop Build' button next
131 to the 'Force Build' button, so you can start and stop a build
133 (StatusResourceBuilder.force): redirect back to the waterfall,
134 rather than the index page
135 (StatusResourceBuilder.ping): same
136 * buildbot/status/web/build.py (StatusResourceBuild.stop): same
138 * buildbot/slave/bot.py (Bot.remote_setBuilderList): don't
139 consider the 'info' directory as a leftover directory. Patch from
140 Benoit Sigoure, ticket #138.
141 (others): remove trailing whitespace
143 2007-11-01 Brian Warner <warner@lothar.com>
145 * buildbot/status/web/builder.py (StatusResourceBuilder.build_line):
146 if there's no current step, don't try to display its description.
147 Same crash as in #96, this time in the web page. Closes #111.
149 * buildbot/status/web/base.py (OneLineMixin.make_line): tolerate
150 results == None (i.e. when the build hasn't finished yet);
151 previously this code exploded when trying to find a CSS class for
152 that results value. Patch from Greg Ward. Closes #118.
154 * buildbot/status/client.py (RemoteBuildStep.remote_getLogs):
155 IBuildStepStatus.getLogs() returns a list, not a dict. Patch from
156 Fabrice Crestois. Closes #121.
158 2007-10-31 Brian Warner <warner@lothar.com>
160 * buildbot/status/words.py (Contact.emit_status): if there's no
161 current step, don't try to display its description. This should
162 fix the crash when asking the irc bot about builds which are
163 waiting for a build-wide Lock. Closes #96.
165 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
166 'columnName' argument, from a patch by Ben Hearsum. Closes #120.
168 2007-10-16 Brian Warner <warner@lothar.com>
170 * buildbot/status/web/slaves.py (BuildSlavesResource.body): fix
171 timestamp, I was using %M (minutes) where I meant to be using
172 %b (abbreviated month name). Closes #109.
174 2007-10-13 Brian Warner <warner@lothar.com>
176 * README (COPYING): make it clear that buildbot is distributed under
178 * COPYING: add a copy of the GPLv2 to the source tree
179 * MANIFEST.in: .. and to the source distribution too
181 2007-10-10 Brian Warner <warner@lothar.com>
183 * buildbot/status/builder.py (Status.getURLForThing): update this
184 to match new URL layout, I completely forgot about it. Closes #112.
185 * buildbot/test/test_web.py (GetURL): add unit tests
187 * buildbot/status/web/build.py (BuildsResource.getChild): fix
188 silly typo which prevented the Build page from ever offering
189 control options like 'Stop Build'. Thanks to Aaron Hsieh for the
191 * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd
194 * buildbot/__init__.py (version): bump to 0.7.6+ while between
196 * docs/buildbot.texinfo: same
198 2007-09-30 Brian Warner <warner@lothar.com>
200 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
201 * docs/buildbot.texinfo: same
203 2007-09-30 Brian Warner <warner@lothar.com>
205 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
206 * setup.py: install all test files from buildbot/test/mail/* . Also
207 update URL to point at buildbot.net
208 * MANIFEST.in: update with new files
210 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
211 auto-create an empty public_html directory, otherwise we get
212 internal server errors instead of 404s.
214 * README: reference buildbot.net, remove CVSToys section (does
215 anyone still use it?)
217 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
218 message when public_html/ is missing (indicating that you should
219 probably run 'upgrade-master'), and don't auto-create an empty
220 directory in that case.
222 * contrib/darcs_buildbot.py: refactor internals a bit, make it
223 possible to use as an importable module (to make it easier to
224 write some unit tests for it)
226 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
227 DeprecationWarning for Waterfall, advising users to switch over to
230 * NEWS: update with user-visible changes since the last release
232 * buildbot/status/web/waterfall.py
233 (WaterfallStatusResource.get_reload_time): if the suggest a
234 reload time of less than 15 seconds, give them 15 seconds instead
235 of ignoring their request entirely, because that'd be confusing.
237 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
238 warning if we must invoke the last-change-is-most-recent guess
240 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
241 Waterfall is running in an upgraded master (which is the usual
242 case for folks who have followed the instructions to run
243 'upgrade-master' but who have not yet resolved all the
244 DeprecationWarnings), prefer the buildbot.css from public_html/
245 rather than the one passed in on the buildbot= argument.
246 Otherwise, the resulting pages don't quite use CSS right..
247 sometimes it works, sometimes it doesn't, and I don't know why.
248 Sites that are using custom CSS will see the default CSS until
249 they modify public_html/buildbot.css to include their
252 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
253 * buildbot/status/web/robots.txt (Disallow): update to cover all
254 dynamically-generated pages
256 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
257 include both 'trunk' and None in the output list, since some VC
258 systems (SVN, frequently) refer to trunk as 'trunk'.
260 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
261 point the 'welcome' link explicitly at index.html, rather than
262 '.', so that old Waterfall users can reach it and discover all the
265 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
266 build's text to the end of the line, without a CSS class so it
269 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
270 'max_search=' argument, to limit the number of builds that are
271 examined while trying to find ones that match the other criteria.
272 This helps to limit the work we do, since otherwise we might have
273 to trawl through all history.
274 (IBuilderStatus.generateFinishedBuilds): same
275 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
276 (BuilderStatus.generateFinishedBuilds): same
278 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
279 our got_revision before checking its length: SVN (at least) still
280 reports numeric values for this.
281 * buildbot/status/web/build.py (StatusResourceBuild.body): same
282 * buildbot/status/web/xmlrpc.py
283 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
284 serving a completely fake revision
286 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
287 basedir to sys.path, to mimic what a real buildmaster would have
288 access to, since it is common for master.cfg to import helper
289 classes from .py files in the buildmaster directory, and we want
290 config-file checking to accomodate this.
292 * buildbot/status/web/base.py (map_branches): when referring to
293 branches through WebStatus (i.e. by appending ?branch=FOO query
294 arguments to the URL), make "trunk" mean trunk, by mapping it to
295 None before passing it to generateFinishedBuilds() and the like.
296 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
297 (OneBoxPerBuilder.body): same, also improve display of branches in
299 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
300 (WaterfallStatusResource.buildGrid): same. Note that this filters
301 Changes as well as Builds.
302 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
303 caveat about trunk branches, now that it's fixed
305 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
306 from builder.py, use it on the Builder page too
308 * buildbot/status/web/builder.py (StatusResourceBuilder): same
309 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
310 names, add some CSS classes
311 * buildbot/status/web/classic.css (td.box): new class, for
314 * docs/buildbot.texinfo (WebStatus): update docs
316 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
317 the trailing "M" indicator that tells us this is a modified file.
318 This should help with mode="update" builds that modify files
319 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
322 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
323 new copies of files (to .new) when those files already exist,
324 check the master.cfg file for errors (and give DeprecationWarnings
325 a chance to be displayed).
326 * buildbot/test/test_runner.py: add more tests
327 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
329 2007-09-29 Brian Warner <warner@lothar.com>
331 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
332 the revision id from the last change in our list, since that's the
333 best we can do without knowing the full ancestry graph. Closes #103.
335 * buildbot/scripts/sample.cfg: use buildstep instances in
336 f.addStep, to demonstrate the (correct) modern usage.
337 * docs/examples/hello.cfg: bring this up to date. Closes #79.
338 * docs/examples/twisted_master.cfg: add a big warning about how
340 * docs/examples/glib_master.cfg: delete this one entirely, it is
341 ancient and not a very useful example anyways
343 * buildbot/status/web/base.py (HtmlResource.render): keep track of
344 HTTPChannels, so we can shut them down at reconfig time (when the
345 WebStatus goes away). Closes #102.
346 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
347 (WebStatus.registerChannel): same
348 (WebStatus.stopService): do .loseConnection() here
350 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
351 WebStatus, make sure all pages are still retrievable. I thought
352 this would exercise a bug, but it turns out that it was firefox
353 caching connections (and continuing to talk to the old WebStatus
354 even though I'd loaded a new one).
355 * buildbot/status/web/baseweb.py (WebStatus): add some comments
356 (WebStatus.__repr__): include id() in the repr
358 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
359 this to specify an errorparser. From Ted Mielczarek and the
360 mozilla crew. Closes #94.
362 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
363 bonsaipoller ignore funkyness in xml output for empy log
364 messages", from Axel Hecht. Closes #90.
365 * buildbot/test/test_bonsaipoller.py
366 (TestBonsaiPoller.testMergeEmptyLogMsg): same
368 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
369 respect 'builders' arg, from Ben Hearsum. Closes #89.
371 * buildbot/scripts/runner.py (stop): increase the timeout from 5
372 seconds to 10, to give heavily loaded machines a better chance to
373 finish shutting down. Addresses (partially) #68.
374 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
376 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
377 * buildbot/scripts/startup.py (Follower._failure): update message
379 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
380 team, to fix some bugs and avoid the use of blocking urlopen().
382 * buildbot/test/test_bonsaipoller.py: same
384 2007-09-28 Brian Warner <warner@lothar.com>
386 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
387 argument, to send email about buildslaves which are disconnected
388 for more than an hour. Closes #64.
389 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
391 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
392 (MailNotifier): add docs for this too
395 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
396 respect branch= queryargs, by restricting the builds displayed to
397 those matching the given branch names
398 * buildbot/status/web/waterfall.py (BuildTopBox): same
400 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
401 fix a test failure by adding .prepath to this fake object
403 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
404 up generation of relative URLs. With luck, this should play with
405 reverse proxies much better now.
406 * buildbot/test/test_webparts.py: new test for most of the subpages
407 * buildbot/test/test_web.py (base_config): add enough of a config
408 to exercise more Waterfall code
410 2007-09-27 Brian Warner <warner@lothar.com>
412 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
413 relative URL to the buildbot welcome page, rather than
415 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
417 * buildbot/status/web/base.py (HtmlResource.title): change the
418 default title of all Buildbot-generated page to "Buildbot"
419 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
420 change the title to include the Builder name
421 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
422 same, and also show the build number
423 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
424 redirect the browser to the Builder page
426 2007-09-26 Brian Warner <warner@lothar.com>
428 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
429 problem with the build links
431 2007-09-25 Brian Warner <warner@lothar.com>
433 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
434 to emit relative URLs instead of using URLPath,
436 * docs/buildbot.texinfo (WebStatus): provide an example
438 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
439 page, shows a simple table with one row per Builder. Still pretty
440 ugly, but functional.
441 * buildbot/status/web/index.html: reference it
443 * buildbot/status/web/waterfall.py (Spacer): make this *not*
444 inherit from builder.Event, so that show_events=false doesn't hide
445 spacers, since that would make the waterfall weirdly compressed.
447 * buildbot/status/web/waterfall.py (HELP): put the View button in
448 its own section, so it doesn't get visually confused with the
450 (WaterfallStatusResource.body): make the '[help]' links more
451 visually distinct from each other, and add a link to the Welcome
453 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
454 unused buildslaves without exploding
456 * buildbot/status/web/waterfall.py
457 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
458 it gives us absolute paths that break proxies
459 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
460 this, it was giving bad results when the Waterfall is behind a
463 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
464 new 'upgrade-master' command, which will bring an old buildmaster
465 directory up-to-date. Right now the only thing it does is populate
466 public_html/ if it wasn't already there. Still to do: check the
467 other files, add documentation.
468 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
469 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
471 2007-08-13 Brian Warner <warner@lothar.com>
473 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
474 that contains the checkin comments when you hover over the entry
475 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
478 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
481 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
482 page with versions of python, buildbot, and twisted
483 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
484 * buildbot/status/web/index.html: add links to most pages
485 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
487 * buildbot/status/web/robots.txt: put a robots.txt in new installs
488 which discourages robot access to all large dynamically-generated
489 pages. The intention is that the index page and the 'about' page
490 are the only ones which should be crawlable.
491 * buildbot/scripts/runner.py (Maker.public_html): same
493 * setup.py: ship index.html and robots.txt in source distributions
495 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
496 activate automatic reloading of the page (using a meta Refresh:
498 (WaterfallHelp): new page to explain all the nifty query arguments
499 you can use on the Waterfall, along with forms to set them for
500 you. From this page, you can add filters for builder=, branch=,
501 show_events=, as well as turning on reload=.
502 (WaterfallStatusResource.buildGrid): new query args: last_time=,
503 first_time=, show_time=, num_events= . The old show= is still
504 accepted, but the new builder= is preferred. We ignore empty
505 branch= arguments, to make the WaterfallHelp form easier to
507 (WaterfallStatusResource.head): new method to add text to the
509 * buildbot/status/web/base.py (HtmlResource.content): use head()
510 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
511 empty branch= arguments
512 (OneLinePerBuildOneBuilder.body): same
514 2007-08-12 Brian Warner <warner@lothar.com>
516 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
517 new query args: 'last_time' is a timestamp of the top-most event
518 on the display, 'first_time' is a timestamp for the bottom-most
519 event. 'show_time' is the difference between them, and overrides
520 'first_time'. 'num_events' puts an upper limit on the number of
521 timestamps that will be displayed on the left hand edge.
522 (WaterfallStatusResource.body): add a 'next page' link to the
523 bottom, which shows the events that come just after those shown on
524 the current page. This is a first step towards #67, but we need
525 some more controls before we can close that one.
527 * buildbot/buildslave.py (BuildSlave): these are now MultiService
528 instances too, and live as children of the BotMaster. The main
529 advantage of this approach is that BuildSlaves can know when they
530 are being removed (so they can shut off the upcoming
531 when-do-we-email-an-admin-because-we-lost-our-slave timer).
532 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
533 identify which service children are BuildSlaves
534 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
535 Checker updates here, but delegate the rest to..
536 (BotMaster.loadConfig_Slaves): .. here, which looks at the
537 BotMaster's service children to identify the old slaves. I think
538 the previous approach of using master.slaves was broken in the
539 face of config updates that modified BuildSlave instances but did
540 not completely replace them.
541 * docs/buildbot.texinfo (Developer's Appendix): note the change to
542 the Service hierarchy
544 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
545 page (at URL /buildslaves/) to view status of all buildslaves at
546 once, including how long it's been since we last heard from them,
547 and which Builders use them.
549 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
552 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
555 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
556 use the BuildSlave to keep track of the last time we've heard from
557 the buildslave. This is updated upon receipt of any message from
558 any SlaveBuilder (which generally means when RemoteCommands are
559 giving us status updates, as BuildSteps run). In the future this
560 will include slave pings too.
561 * buildbot/process/base.py
562 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
563 * buildbot/process/buildstep.py:
564 (BuildStep.setBuildSlave): accept that reference
565 (BuildStep.runCommand): pass the reference on to the RemoteCommand
566 (RemoteCommand.remote_update): update the timestamp
567 (RemoteCommand.remote_complete): same
568 * buildbot/test/runutils.py (StepTester.makeStep): match the change
569 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
570 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
571 interface to retrieve this timestamp
572 * buildbot/status/builder.py (SlaveStatus): track a copy of the
576 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
578 (OneLinePerBuild.body): use a <ul> instead of <div>s
579 (OneLinePerBuildOneBuilder.body): same
581 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
582 by adding the file's new name to the list of changed files. This
583 ought to be sufficient for things like isFileImportant and trial
584 tests that only exercise tests for files that have been modified.
587 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
588 XMLRPC server to the WebStatus page. This only has two methods
589 right now (getAllBuildsInInterval and getBuild), but we'll be
590 adding more in the future. This server is extracted from the
593 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
594 generateFinishedBuilds, and improve the data displayed.
595 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
596 the per-Build page, add some information like ETA and got_revision
597 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
598 adding a list of recently completed builds
599 * buildbot/status/web/base.py (css_classes): factor this out
601 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
602 new method, to make status display classes easier to write,
603 especially the WebStatus 'one_line_per_build' page.
604 (IBuilderStatus.generateFinishedBuilds): same
605 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
606 (Status.generateFinishedBuilds): implement it
608 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
609 'source' to be a BuildStep instance, since BuildFactory accepts
611 (CPAN.__init__): same
612 (Distutils.__init__): same
613 (Trial.__init__): same
615 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
616 this might raise KeyError
618 2007-08-07 Brian Warner <warner@lothar.com>
620 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
621 'Owner:' field of the view, rather than 'p4logname', since
622 p4logname comes from the buildslave's environment and seems
623 unlikely to ever do the right thing. Thanks to Wade Brainerd for
624 the patch. Closes #40.
626 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
627 which imposes a per-slave limit on how many builds are allowed to
628 run simultaneously. This has a the same scope than the SlaveLock,
629 but is different because max_builds= gives the buildmaster the
630 freedom to assign the build to a different slave, whereas the
631 SlaveLock doesn't get tested until after the build is irrevocably
632 assigned to a slave. Therefore using max_builds= will improve
633 utilization in the presence of multiple buildslaves that are
634 attached to the same Builder. This completes the incorporation of
635 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
636 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
637 any Builder finishes, potentially trigger *all* Builders, since
638 max_builds= may have stalled someone else while waiting for the
640 * buildbot/scripts/sample.cfg: mention max_builds=
641 * buildbot/test/test_run.py (ConcurrencyLimit): test it
642 * docs/buildbot.texinfo (Buildslave Specifiers): document it
644 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
645 inherit from RunMixin do not need to call master.stopService()
646 themselves, since RunMixin.tearDown does that. The double call
647 fails on Twisted-2.0.x, which didn't happen to protect against it.
648 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
650 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
651 from #48, this one to have the BuildSlave objects track
652 SlaveBuilders, so they'll be able to use that knowledge to
653 influence their canStartBuild() response.
654 * buildbot/process/builder.py (SlaveBuilder.attached): call it
655 (SlaveBuilder.detached): same
656 * buildbot/test/test_slaves.py (BuildSlave): test it
658 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
659 the second of Dustin's #48 patches, this one adding a method to
660 the BuildSlave that allows it to decide whether it is willing to
661 participate in a build or not.
662 (SlaveBuilder.isAvailable): use canStartBuild() to decide
664 * buildbot/test/test_run.py (CanStartBuild): test for it
666 * all: incorporate the first of four patches by Dustin Mitchell
667 from ticket #48, working towards improving control over slave
668 concurrency. The first patch is to use a long-lived BuildSlave
669 object per slave, on which other behavior can be added later. I've
670 modified his patch considerably.
671 * buildbot/buildslave.py (BuildSlave): move class out of
672 slave/__init__.py (where it would get loaded by the slave as well
673 as the master, making dependencies trickier), and merge it with
674 BotPerspective. Now these BuildSlave instances are created once in
675 the master.cfg file, and not destroyed until they are either
676 removed from the config file or changed so
677 much (name/password/class changes) that we cannot continue to use
678 the old one. This affects config files: they must use
679 'from buildbot.buildslave import BuildSlave' instead of using
680 'from buildbot.slave import BuildSlave'.
681 * buildbot/master.py: move BotPerspective out
682 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
683 add or remove as necessary, update the rest using data from
685 * buildbot/slave/__init__.py: move BuildSlave out
686 * buildbot/test/test*.py: import BuildSlave from the new place
687 * buildbot/scripts/sample.cfg: update to match
688 * docs/buildbot.texinfo: update to match
689 * buildbot/process/builder.py: update comments to match
691 2007-08-02 Brian Warner <warner@lothar.com>
693 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
694 one-line-per-build pages a bit, add a header, refactor slightly
696 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
697 the TimeOutError timer, patch by Dustin Mitchell.
699 2007-08-01 Brian Warner <warner@lothar.com>
701 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
702 mostly work (branch= is still ignored, we need a useful header)
703 (OneLinePerBuildOneBuilder.body): this too
705 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
706 bring this up-to-date w.r.t. recent refactorings, and fix
707 redirections to bounce the browser to the top page after hitting
708 the 'force' button. This needs to be improved, but at least it now
709 redirects to a valid page.
710 (StatusResourceBuilder.ping): same
711 (StatusResourceBuilder.getChild): same, although I think this code
712 might be dead anyways
714 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
715 a branch= query argument, to filter the display down to builds and
716 changes that involve the given branch. You can add multiple
717 branch= arguments to see multiple branches (using a logical OR).
718 Note that there is no way to include the default branch (i.e.
719 None, i.e. trunk) yet, there is still work to be done to allow for
720 simple+uniform names of branches (i.e. removing the VC-specific
721 details of how branches are implemented, so calling the branch
722 'beta4' even though the SVN checkout step requires
724 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
725 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
726 * buildbot/interfaces.py (IEventSource.eventGenerator): same
727 * docs/buildbot.texinfo (Buildbot Web Resources): document it
729 * all: bring import statements up-to-date: don't import
730 __future__, assume cPickle and cStringIO are always available.
731 Also remove #!/usr/bin/python lines from non-scripts, my editor
732 has been a bit over-enthusiastic about stuffing them into new .py
735 * buildbot/status/web/index.html: put a link to the waterfall page
736 on the index, otherwise first-time users of WebStatus aren't going
737 to see anything very interesting.
739 * buildbot/interfaces.py (IEventSource): document this interface.
740 Thanks to Dustin Mitchell for the patch. Closes #60.
741 * buildbot/status/builder.py (BuilderStatus): same
742 * buildbot/changes/changes.py (ChangeMaster): same
744 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
745 add a query arg of 'show_events=true' to display non-build events,
746 like slaves attaching/detaching and reconfig events, or
747 'show_events=false' to hide them. The default is 'true'.
748 * docs/buildbot.texinfo (Buildbot Web Resources): document it
750 * web-parts: merge in web-parts branch. Lots of changes. The new
751 functionality is to add buildbot.status.html.WebStatus, which is a
752 superset of the Waterfall that adds new status pages and serves
753 regular files from BASEDIR/public_html/ , which is now the preferred
754 place to put robots.txt, buildbot.css, and index.html .
755 * buildbot/scripts/runner.py: the 'create-master' command now
756 creates public_html/ too, and populates it with a couple of
758 * buildbot/status/web: split waterfall code into smaller pieces
760 2007-07-31 Brian Warner <warner@lothar.com>
762 * buildbot/scripts/startup.py (launch): import twistd.run in a
763 different way to hush pyflakes
764 * buildbot/process/builder.py: remove unused import
766 2007-07-30 Brian Warner <warner@lothar.com>
768 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
769 Mitchell: pass SourceStamps around rather than branch/version/etc
770 tuples. Thanks Dustin! Closes #70.
771 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
772 tuple rather than a list, to avoid surprising mutations
773 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
774 * buildbot/status/mail.py (MailNotifier.buildMessage): same
775 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
776 * buildbot/test/test_status.py (Subscription): same
777 * buildbot/test/test_control.py (Force): same
778 * buildbot/test/test_buildreq.py (Request.testMerge): same
780 2007-07-29 Brian Warner <warner@lothar.com>
782 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
783 variable, since it wasn't used and is confusing in the presence of
784 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
787 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
788 the Buildbot home-page link to point at buildbot.net instead of
789 sourceforge, and add a current-version query parameter so we can
790 get some statistics on which versions are in use out there.
792 2007-07-28 Brian Warner <warner@lothar.com>
794 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
795 with c['change_source'], leaving c['sources'] for backwards
796 compatibility (but deprecated), scheduled for removal in 0.8.0
797 * docs/buildbot.texinfo: same
798 * buildbot/test/test_config.py: verify that c['sources'] still works
799 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
800 * buildbot/scripts/sample.cfg: update to match
802 * buildbot/changes/mail.py (MaildirSource): parse with python's
803 stdlib 'email' module, which has been available since python2.2,
804 and drop use of the 'rfc822' module, which has been depreceated
806 * buildbot/test/test_maildir.py: same: use parse_file() not parse
808 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
809 this needs to match the renaming in test/mail/msg*
811 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
814 * buildbot/test/test_mailparse.py: rename sample emails a bit
815 * buildbot/test/mail/msg*: same
817 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
818 parser for the "commit-email.pl" script that is shipped with SVN,
819 written by Justin Mason. Thanks! Closes SF#1072845.
820 * buildbot/test/mail/svn-commit.*: sample messages
821 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
822 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
824 2007-07-27 Brian Warner <warner@lothar.com>
826 * buildbot/changes/mail.py: refactor: move parsing into a method
827 named 'parse', each parser type gets a separate subclass. Remove
828 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
829 to be a simple leading-substring match. Add a warning to the logs
830 if prefix= does not end in a slash, since that's probably a
831 mistake. Fix both places where a prefix= mismatch would skip all
832 subsequent files in the same email, instead of just skipping the
833 one that didn't match.
834 * buildbot/test/test_mailparse.py: match changes
836 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
837 docs on email-based ChangeSources
839 * docs/buildbot.texinfo (Getting Source Code Changes): move all
840 the changesource types up a level, removing the one-entry menu in
843 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
844 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
845 instances instead of tuples. Closes #63.
846 * buildbot/slave/__init__.py (BuildSlave): define marker class
847 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
848 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
849 * buildbot/test/test_*.py: update tests to match
850 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
851 the c['bots'] backwards-compatibility handler works
853 2007-07-26 Brian Warner <warner@lothar.com>
855 * buildbot/changes/hgbuildbot.py (hook): add an in-process
856 Mercurial change-sending hook, contributed by Frederic Leroy.
857 Thanks! Addresses #50.
858 * docs/buildbot.texinfo (MercurialHook): document it
860 * buildbot/changes/hgbuildbot.py: change the way imports are done,
861 to make it compatible with at least hg-0.9.1 and the current 0.9.4
863 2007-07-17 Brian Warner <warner@lothar.com>
865 * buildbot/process/buildstep.py (BuildStep.getLog): add a
866 convenience method to retrieve a log added with
867 addLog()/addCompleteLog()/etc or logfiles= . I should have added
870 2007-07-03 Brian Warner <warner@lothar.com>
872 * buildbot/slave/commands.py (ShellCommand._startCommand): when
873 logging the environment variables, put one variable on each line,
874 rather than having one really long line with all of them. This
875 should make them a bit more readable and not trigger the
876 horizontal scrollbar (when viewing it in a web browser) quite so
877 much. Thanks to Albert Hofkamp for the patch.
879 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
880 WithProperties instance. Thanks to Axel Hecht for the patch.
882 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
883 * docs/buildbot.texinfo (Build Properties): document it
884 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
885 workdir if it didn't already exist.
887 * docs/buildbot.texinfo (Scheduler Types): correct the description
888 of Dependent schedulers. Thanks to Greg Ward for the patch.
890 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
891 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
892 the patch. Closes #49.
894 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
895 0700 before removing it, to deal with situations where a build will
896 leave files around without write permissions and the 'copy' or
897 'clobber' VC checkout modes need to blow away the tree first.
898 Thanks to Steve Milner for the suggestion and the patch (which I
899 mangled horribly). Closes #29.
900 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
903 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
904 an allowReconnect= argument to let callers control whether they
905 want this don't-let-it-reconnect behavior, since some tests care.
906 Factor out the .continueTrying=False lines from those callers.
907 * buildbot/test/test_slaves.py: same
908 * buildbot/test/test_run.py: same
910 2007-07-02 Brian Warner <warner@lothar.com>
912 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
913 slave has been disappeared, don't let it reconnect. This was
914 causing an intermittent failure in test_slaves.py, when the slave
915 that was supposed to be gone managed to come back by the end of
916 the test and affect the count.
917 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
919 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
920 diagnostic messages to track down this problem
921 (Builder.startBuild): same
923 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
924 the slave randomly rather than always taking the first one. Thanks
925 to Pike for the patch. Closes #36.
926 * buildbot/test/test_slaves.py: match the change. to avoid huge
927 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
928 enables/disables the round-robin-ness (enabled by default), and
929 some unit tests disable it.
930 * docs/buildbot.texinfo (Buildmaster Architecture): document it
932 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
933 argument to 'buildmaster_host', to make it more obvious that this
934 points to the buildmaster. Thanks to Bob Proulx for the
936 * buildbot/scripts/runner.py (slaveTAC): same
937 * buildbot/test/test_runner.py (Create.testSlave): match the change
939 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
942 2007-06-17 Brian Warner <warner@lothar.com>
944 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
945 we can round-trip all of our current step classes by calling
946 getStepFactory() and using the results to make a clone of the
949 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
952 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
953 the config file, we're moving to using actual instances instead of
954 the (class, kwargs) 'step specification' tuples. BuildFactory
955 still keeps a list of tuples internally, but when real instances
956 are passed in to addStep(), they are asked for their class and
957 kwargs using the new BuildStep.getStepFactory method. BuildFactory
958 accepts both instances and the tuple form, and converts instances
959 to the tuple form, but the instance form is preferred because it
960 gives the Steps a chance to do argument validation. Closes: #11.
962 * buildbot/process/buildstep.py (BuildStep.__init__): record the
963 factory information necessary to implement getStepFactory. The
964 addFactoryArguments() method can be used to include arguments that
965 aren't passed to the BuildStep base class constructor.
966 (BuildStep.setBuild):
967 (BuildStep.setDefaultWorkdir): new methods to take parameters that
968 are needed for live BuildSteps but not to construct the specification
969 tuples that are stashed in the factory.
971 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
972 'workdir' into new BuildSteps by using methods instead of
973 arguments. This makes the constructor for BuildSteps a lot
976 * buildbot/steps/*.py: update to match this change. Basically this
977 means adding calls to addFactoryArguments() in the __init__
978 methods to capture the arguments that aren't passed through to the
980 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
981 the new workdir (if any) into the RemoteShellCommands arguments.
982 * buildbot/steps/source.py: allow workdir= to be optional,
983 implement setDefaultWorkdir() since we don't inherit from
984 (CVS): finally remove old clobber=/export=/copydir= arguments,
985 in favor of the mode= argument that's been around forever now.
986 * buildbot/steps/transfer.py: remove build= argument
988 * buildbot/test/*.py: update to match, generally by turning all
989 build= arguments into subsequent calls to s.setBuild()
990 * buildbot/test/test_config.py (Factories): verify that we can
991 use either BuildStep instances or class/kwarg tuples in both
992 BuildFactory.addStep and BuildFactory.__init__
994 * docs/buildbot.texinfo (Build Steps): document the new approach,
995 mention compatibility with the old approach, update all examples
996 to use the new style.
998 2007-06-16 Brian Warner <warner@lothar.com>
1000 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
1001 the LoopingCall, just eat the failure so that we'll poll again
1002 next time. This should allow us to tolerate (e.g.) sf.net SVN
1003 failures more gracefully. Many thanks to Dustin Mitchell for the
1006 2007-05-17 Brian Warner <warner@lothar.com>
1008 * buildbot/status/words.py: refactor the IRC status bot into
1009 separate 'Contact' and 'Channel' classes. The base Contact class
1010 contains the interaction code: commands and responses. The
1011 IRCContact subclass (and IrcStatusBot 'Channel') handle the
1012 IRC-specific aspects. The plan is to write other subclasses for
1013 other IM protocols like AIM and Jabber.
1015 2007-04-16 Brian Warner <warner@lothar.com>
1017 * CREDITS: update list of contributors. Thank you all!
1019 2007-04-13 Brian Warner <warner@lothar.com>
1021 * buildbot/status/mail.py (MailNotifier): add the project name to
1022 the subject line and message body, to make it easier to
1023 distinguish email coming from different buildmasters. Thanks to
1024 Benoit Sigoure for the patch.
1025 * buildbot/test/test_status.py (Mail): update to match
1027 2007-03-24 Brian Warner <warner@lothar.com>
1029 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
1030 avoid text-conversion problems between DOS/windows and unix.
1031 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
1033 2007-03-03 Brian Warner <warner@lothar.com>
1035 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
1036 warning about the use of Waterfall here
1038 2007-03-01 Brian Warner <warner@lothar.com>
1040 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
1042 2007-02-28 Brian Warner <warner@lothar.com>
1044 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
1045 Lamb to use a more optimal form of 'p4 changes', to reduce server
1046 load. He reports that this optimization was added to p4d release
1047 2005.2, but it should work in all versions. Closes #27.
1048 * buildbot/test/test_p4poller.py: match it
1050 2007-02-27 Brian Warner <warner@lothar.com>
1052 * buildbot/status/web/*.py: move all web status stuff into a
1053 separate directory, in anticipation of splitting it into smaller
1054 pieces and adding more files. html.py was getting way too big.
1055 * buildbot/status/classic.css: move it too
1056 * setup.py: add the new sub-package
1057 * buildbot/test/test_web.py: match the changes
1058 * MANIFEST.in: handle the move of classic.css
1060 2007-02-07 Brian Warner <warner@lothar.com>
1062 * contrib/OS-X/*: add some launchd .plist files for automatically
1063 starting a buildmaster or buildslave under OS-X (10.4 or later).
1064 Thanks to Mark Pauley for these.
1066 2007-02-06 Brian Warner <warner@lothar.com>
1068 * docs/buildbot.texinfo (Requirements): update requirements to
1069 stop claiming compatibility with python-2.2 or twisted-1.3.x .
1071 * README: mention python-2.5 and twisted-2.5 compatibility
1073 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
1075 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
1077 * buildbot/status/builder.py: same, by requiring cStringIO
1078 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
1079 * buildbot/test/test_vc.py: same
1080 * buildbot/test/test_web.py:
1081 * buildbot/test/test_steps.py: same, remove unused import
1083 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
1086 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
1087 see any Builders that don't have Schedulers to drive them
1089 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
1090 attributes this uses went away
1092 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
1093 dialog, to allow you to reset the buildmaster and force
1094 connect/disconnect. Correctly handle losing the buildmaster
1095 connection (by switching the display to the hexnut, at which point
1096 you can use the 'Connect' menu item to reconnect).
1098 * buildbot/steps/source.py (Source.start): if we're using a patch,
1099 add it as a LogFile to the checkout/update step. This will turn
1100 into a link on the waterfall page.
1102 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
1103 option, to take the patch from a pre-made file rather than
1104 generating it from the local tree. Thanks to Robert Helmer for the
1105 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
1106 * buildbot/scripts/runner.py (TryOptions): add --diff,
1107 --patchlevel, and --baserev options
1108 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
1109 as None, meaning HEAD.
1110 * buildbot/sourcestamp.py (SourceStamp): update docstring to
1111 indicate that baserev=None means HEAD
1112 * docs/buildbot.texinfo (try --diff): document it
1114 * buildbot/test/test_steps.py (BuildStep): remove use of
1115 reactor.iterate(), although the technique I replaced it with is a
1116 gross polling hack that must be cleaned up properly some day. This
1117 was the last use of reactor.iterate in the entire tree, yay.
1119 2007-02-05 Brian Warner <warner@lothar.com>
1121 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
1122 is one of the three known values, otherwise we emit some confusing
1123 messages later on. Thanks to Grig Gheorghiu for the catch.
1125 2007-01-30 Brian Warner <warner@lothar.com>
1127 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
1128 Hearsum contributed a patch to let BonsaiPoller work with results
1129 that contain non-ascii characters. Closes SF#1632641.
1131 2007-01-27 Brian Warner <warner@lothar.com>
1133 * Makefile (release): produce both .tar.gz and .zip source bundles.
1136 2007-01-23 Brian Warner <warner@lothar.com>
1138 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
1139 * buildbot/changes/monotone.py: same
1141 * buildbot/changes/maildir.py: combine several files into one,
1142 clean up maildir.py to use Services properly.
1143 * buildbot/changes/maildirtwisted.py: remove
1144 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
1146 * buildbot/changes/mail.py: match the change
1147 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
1148 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
1150 * buildbot/slave/commands.py (command_version): bump to "2.3" to
1151 indicate that the buildslave knows about the 'bzr' command
1153 2007-01-22 Brian Warner <warner@lothar.com>
1155 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
1156 'with', it will become a reserved work in python2.6 .
1158 * contrib/bb_applet.py: add a simple gnome-panel applet, to
1159 display a terse summary of buildbot status.
1160 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
1161 some icons, small versions of the Blender object that lives in
1162 docs/images/icon.blend
1164 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
1165 * buildbot/slave/commands.py (Bzr): same
1166 * buildbot/scripts/tryclient.py (BzrExtractor): same
1167 (SourceStampExtractor.dovc): modify this to allow non-zero exit
1168 status, since 'bzr diff' does that
1169 * buildbot/test/test_vc.py (Bzr): same
1170 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1174 2007-01-20 Brian Warner <warner@lothar.com>
1176 * contrib/darcs_buildbot.py: tidy up the progress messages
1178 2007-01-17 Brian Warner <warner@lothar.com>
1180 * contrib/darcs_buildbot.py: enhance to handle multiple patches
1181 being pushed at a time. This keeps state in the repository in a
1182 small file named .darcs_buildbot-lastchange, but that shouldn't
1183 interfere with normal repository operations. Fixes SF#1534049.
1184 * buildbot/clients/sendchange.py (Sender): make a single Sender
1185 capable of sending Changes with different usernames.
1187 2006-12-11 Brian Warner <warner@lothar.com>
1189 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
1190 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
1191 buildbot.changes.mail a long time ago, but I forgot to add the
1192 DeprecationWarning until now.
1194 * buildbot/process/maxq.py: remove this, the functionality now
1195 lives in buildbot.steps.maxq
1197 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1198 * buildbot/clients/gtkPanes.py: remove unused import
1200 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1201 that was meant to provide a special Reporter to run inside trial
1202 and give the buildslave lots of machine-readable status. We never
1203 finished this project.
1205 * buildbot/changes/bonsaipoller.py: remove unused imports
1206 * buildbot/changes/svnpoller.py: same
1207 * buildbot/process/builder.py: same
1208 * buildbot/process/buildstep.py: same
1209 * buildbot/slave/bot.py: hush pyflakes warning
1210 * buildbot/status/tests.py: remove unused imports
1211 * buildbot/status/tinderbox.py: same
1212 * buildbot/steps/python_twisted.py: same
1214 * buildbot/process/step.py: remove this file, these names were
1215 deprecated in 0.7.5 and are now being removed.
1216 * buildbot/process/step_twisted.py: same
1217 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1219 * buildbot/twcompat.py: remove the empty file, yay it is gone
1221 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1222 tw-2.0.0 and newer have the method we need.
1223 (getProcessOutputAndValue): same
1224 (which): remove this method, tw-2.0.0 t.p.procutils has it
1226 * buildbot/twcompat.py (implements): remove this method
1227 * buildbot/*: import implements() from zope.interface directly
1229 * buildbot/status/mail.py: stop falling back to importing
1230 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1233 * buildbot/twcompat.py (Interface): remove this import
1234 * buildbot/*: import Interface from zope.interface directly
1236 * buildbot/twcompat.py (providedBy): remove this method
1237 * buildbot/*: turn all uses of providedBy(obj, iface) into
1238 iface.providedBy(obj)
1240 * buildbot/twcompat.py (maybeWait): remove this method, now that
1241 we no longer maintain compatibility with Twisted<=1.3.0 .
1242 Twisted-2.0.0 and later allow trial methods to return Deferreds
1244 * buildbot/test/*: remove all uses of maybeWait
1246 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1248 * docs/buildbot.texinfo: same
1250 2006-12-10 Brian Warner <warner@lothar.com>
1252 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1253 * docs/buildbot.texinfo: set version to match
1255 2006-12-10 Brian Warner <warner@lothar.com>
1257 * README (REQUIREMENTS): update for release
1258 * NEWS: update for release
1259 * buildbot/slave/commands.py (command_version): mention that this
1260 version (2.2) was released with buildbot-0.7.5
1262 * buildbot/test/test_config.py (StartService.testStartService):
1263 inhibit the usual read-config-on-startup behavior, since otherwise
1264 the log.err that gets recorded causes the test to fail
1266 * buildbot/status/builder.py (LogFile.finish): forget about all
1267 subscribers once the log has finished, since after that point
1268 we're never going to use them again. This might help free up some
1271 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1272 than the old/deprecated gtk.mainquit()
1274 2006-12-09 Brian Warner <warner@lothar.com>
1276 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1277 better when we can't open the masterdst file
1279 * buildbot/scripts/startup.py (Follower._failure): add missing
1280 import statement for BuildSlaveDetectedError
1282 * buildbot/steps/transfer.py (FileUpload): cleanup
1283 (FileDownload): same. Add tests for slave version, add mode=.
1284 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1285 (SlaveFileDownloadCommand): same
1286 * buildbot/test/test_transfer.py: enhance tests
1287 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1290 2006-12-08 Brian Warner <warner@lothar.com>
1292 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1293 both success *and* failure. Without this, the 'buildbot
1294 sendchange' command would hang if it could not contact the
1295 buildmaster or deliver the Change, which would generally cause the
1296 user's commit/record/checkin command to hang too. Thanks to
1297 Christian Unger for the catch.
1299 2006-12-06 Brian Warner <warner@lothar.com>
1301 * NEWS: update with items for the next release
1303 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1304 whimsical example pulled from a punch-drunk email I sent out late
1306 (Transferring Files): document some of the other parameters
1307 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1308 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1309 * buildbot/test/test_svnpoller.py: same
1310 * buildbot/changes/svnpoller.py (SVNPoller): same
1312 2006-11-26 Brian Warner <warner@lothar.com>
1314 * docs/buildbot.texinfo (Build Properties): remind users that
1315 WithProperties must appear in a command= list, not as a top-level
1317 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1318 we're sending a list or a single string to the RemoteShellCommand
1320 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1322 * buildbot/scripts/startup.py (start): skip the whole
1323 watch-the-logfile thing under windows, since it needs os.fork()
1325 * buildbot/scripts/runner.py (restart): remove the old message
1326 that got printed after the buildbot was restarted.. it most cases
1327 it didn't get printed at the right time anyways
1329 2006-11-25 Brian Warner <warner@lothar.com>
1331 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1332 follow twistd.log and print lines until the process has started
1333 started properly. For the buildmaster, this means until the config
1334 file has been parsed and accepted. For the buildslave, this means
1335 until we've connected to the master. We give up after 5 seconds in
1336 any case. Helpful error messages and troubleshooting suggestions
1337 are printed when we don't see a successful startup. This closes the
1338 remainder of SF#1517975.
1339 * buildbot/scripts/startup.py: moved app startup code to here
1340 * buildbot/scripts/logwatcher.py: utility class to follow log
1341 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1342 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1343 so the LogWatcher can tell the difference between a buildmaster
1346 2006-11-24 Brian Warner <warner@lothar.com>
1348 * docs/examples/twisted_master.cfg: update to match the version
1349 in use on twistedmatrix.com
1350 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1351 was using before stopped working, but 'irc.freenode.net' works
1354 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1357 * buildbot/clients/base.py (TextClient.not_connected): upon
1358 UnauthorizedLogin failures, remind the user to connect to the
1359 PBListener port instead of the slaveport.
1360 (TextClient.disconnected): shut down more quietly
1361 * docs/buildbot.texinfo (statuslog): add another reminder
1363 * buildbot/scripts/runner.py (Options.subCommands): rename
1364 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1365 'sighup' as an alias.
1366 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1367 reconfig command to follow twistd.log and print all of the lines
1368 from the start of the config-file reload to its completion. This
1369 should make it a lot easier to discover bugs in the config file.
1370 Use --quiet to disable this behavior. This addresses half of
1371 SF#1517975, the other half will be to add this same utility to
1372 'buildbot start' and 'buildbot restart'.
1373 * docs/buildbot.texinfo (Loading the Config File): same
1376 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1377 method, it has been deprecated for a long time. Use
1378 IBuilderControl.requestBuild instead.
1379 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1380 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1381 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1382 * buildbot/test/test_control.py (Force.testForce): same
1383 * buildbot/test/test_run.py: use requestBuild instead
1385 * buildbot/clients/debug.py: replace 'Force Build' button with
1386 'Request Build' (which just adds one to the queue), add Ping
1387 Builder, add branch/revision fields to Request Build.
1388 * buildbot/clients/debug.glade: same
1389 * buildbot/master.py: update interface to match. This creates an
1390 incompatibility between new debugclients and old buildmasters.
1392 * buildbot/process/builder.py (Builder._attached): delay the call
1393 to maybeStartBuild for a reactor turn, to avoid starting a build
1394 in the middle of a reconfig (say, if the new Builder uses a new
1395 slave which is already connected).
1397 2006-11-23 Brian Warner <warner@lothar.com>
1399 * buildbot/test/test_transfer.py: appease pyflakes
1400 * buildbot/test/test_steps.py: same
1402 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1403 keeps pyflakes from finding undefined names
1405 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1406 Builder no longer induces a disconnect/reconnect cycle. This means
1407 that any builds currently in progress will not be interrupted, and
1408 any builds which are queued in the Builder will not be lost. This
1409 is implemented by having the new Builder extract the state (i.e.
1410 all pending Builds and any desired SlaveBuilders) from the old
1412 (BotPerspective): refactor. The BotPerspective no longer keeps
1413 track of all the Builders that want to use this slave; instead, it
1414 asks the BotMaster each time it needs this list. This removes
1415 addBuilder and removeBuilder. Clean up attached() to acquire all
1416 the slave's information in a more atomic fashion. updateSlave() is
1417 now the way to make sure the slave is using the right set of
1418 Builders: just call it after everything else has been
1420 (BotMaster): refactor, removing addBuilder/removeBuilder and
1421 replacing them with an all-at-once setBuilders() call.
1423 * buildbot/test/test_slaves.py (Reconfig): new test case to
1424 exercise this functionality
1425 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1426 * buildbot/slave/commands.py (WaitCommand): same
1428 * docs/buildbot.texinfo (Loading the Config File): document the
1431 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1432 SlaveBuilder to have its parent Builder changed.
1433 (SlaveBuilder.isAvailable): new method to give access to state,
1434 which is now a private attribute
1435 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1436 the SlaveBuilder about how it is being used. These methods update
1437 its internal state. buildFinished() is now the place that invokes
1438 maybeStartBuild() on its parent Builder.
1439 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1440 new Builder to take over for an old one, transferring state from
1442 (Buider): refactor the way that SlaveBuilders are used to match,
1443 giving them a bit more autonomy.
1444 (Builder.buildFinished): this no longer calls maybeStartBuild():
1445 instead the SlaveBuilder calls it on whoever its parent Builder is
1446 at the time. This way, when an old Builder is replaced by a new
1447 one, and there was a build in progress during the transition, when
1448 that build finishes, it will be the new Builder that is told about
1449 the newly available slave so it can start a new build.
1451 * buildbot/process/base.py (Build.startBuild._release_slave): when
1452 the Build finishes, tell the SlaveBuilder that they've been
1455 * buildbot/status/builder.py (SlaveStatus): add some new setter
1456 methods for use by BotPerspective, to keep some attributes more
1459 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1460 called by the buildmaster.
1461 (Bot.setBuilderList): instead, we locally announce any leftover
1462 directories based upon which Builders we were told about. The
1463 master doesn't really care; it's the local admin who may or may not
1464 wish to delete them.
1467 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1468 to allow use of python2.4 or whatever. This tool still requires
1471 2006-11-19 Brian Warner <warner@lothar.com>
1473 * NEWS (IStatusLog.readlines): more news items
1475 2006-11-18 Brian Warner <warner@lothar.com>
1477 * NEWS: start collecting items for the next release.
1479 2006-11-04 Brian Warner <warner@lothar.com>
1481 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1482 Hearsum. Closes SF#1590310.
1483 * buildbot/test/test_bonsaipoller.py: and tests
1485 * buildbot/status/tinderbox.py
1486 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1487 status when the build results in WARNINGS. Patch from Dave
1488 Liebreich. Closes SF#1587352.
1490 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1491 linux-vs-osx behavior difference w.r.t. reading from files that
1492 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1493 to Mark Rowe for the patch.
1495 2006-10-15 Brian Warner <warner@lothar.com>
1497 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1498 method name was misspelled in the interface definition. Thanks to
1499 Roy Rapoport for the catch.
1501 2006-10-13 Brian Warner <warner@lothar.com>
1503 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1504 to match the great Steps renaming
1506 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1507 Maybe I should run my own unit tests before recording a big
1508 change. Good thing I've got a buildbot to remind me.
1510 2006-10-12 Brian Warner <warner@lothar.com>
1512 * buildbot/steps/transfer.py: rework __init__ and args setup
1513 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1515 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1516 when opening the target file, only catch IOError (to report via
1517 stderr/rc!=0), let the others be reported as normal exceptions
1519 2006-10-08 Brian Warner <warner@lothar.com>
1521 * contrib/svn_watcher.py: fix security holes by using proper argv
1522 arrays and subprocess.Popen() rather than commands.getoutput().
1523 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1524 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1525 probably be removed by the next release.
1528 2006-10-04 Brian Warner <warner@lothar.com>
1530 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1531 initial lines that weren't emitted by pyflakes. When the pyflakes
1532 command is run under a Makefile, 'make' will echo the command it
1533 runs to stdio, and that was getting logged as a "misc" warning.
1534 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1535 * buildbot/test/test_steps.py (testPyFlakes3): another test
1537 2006-10-01 Brian Warner <warner@lothar.com>
1539 * buildbot/status/html.py (HtmlResource.render): if we get a
1540 unicode object from our content() method, encode it into utf-8
1541 like we've been claiming to all along. This allows the comments
1542 and author names from svnpoller.py to be delivered properly.
1544 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1545 de-unicodify filenames before creating the Change, because the
1546 rest of buildbot is unlikely to handle them well. Leave the 'who'
1547 field as a unicode object.. I don't think there's anything that
1548 will break very soon, and it will probably nudge us towards
1549 accepting unicode everywhere sooner or later. Stop using the
1550 "date" field that comes out of SVN, since it is using the
1551 repository's clock (and timezone) and what we care about is the
1552 buildmaster's (otherwise Changes from the future show up later
1553 than the builds they triggered).
1554 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1557 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1558 Suvbersion repository polling ChangeSource. I've hacked it up
1559 considerably: any bugs are entirely my own fault. Thank you
1561 * buildbot/test/test_svnpoller.py: tests for it
1562 * docs/buildbot.texinfo (SvnSource): document it
1564 2006-09-30 Brian Warner <warner@lothar.com>
1566 * buildbot/scheduler.py (Periodic): submit a reason= to the
1567 BuildSet to indicate which Scheduler triggered the build. Thanks
1568 to Mateusz Loskot for the suggestion.
1570 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1572 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1573 changes: set self.loop in __init__, remove unused volatile=
1575 * docs/buildbot.texinfo (.buildbot config directory): add more
1576 docs on the .buildbot/options keys used by "buildbot try"
1577 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1578 (Try.deliverJob): same
1580 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1582 (BonsaiPoller): same
1584 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1585 close the filehandle when we stop watching the file. Before, the
1586 filehandle was only closed when the LogFileWatcher was
1587 garbage-collected, which could be quite a while in the future. If
1588 it was still open by the time the next build started, windows will
1589 refuse to let the new build delete the old build/ directory. Fixes
1590 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1591 #twisted for the catch.
1593 2006-09-29 Brian Warner <warner@lothar.com>
1595 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1598 2006-09-25 Brian Warner <warner@lothar.com>
1600 * setup.py: the new buildbot.steps module wasn't being installed.
1601 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1602 (testmsgs): add the extra stuff from buildbot/test/* so you can
1603 run unit tests on an installed copy of buildbot, not just from
1606 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1607 columns of 'svnlook changed' output contain status information, so
1608 strip [:4] instead of [:6]. Depending upon what the status flags
1609 were, this would sometimes lead to mangled filenames. Thanks to
1610 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1612 * buildbot/steps/source.py (Monotone): initial Monotone support,
1613 contributed by Nathaniel Smith. Still needs docs and tests, but
1614 this code has been in use on the Monotone buildbot for a long
1616 * buildbot/slave/commands.py (Monotone): slave-side support
1617 * buildbot/changes/monotone.py (MonotoneSource): polling change
1620 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1621 contributed a Change Source that polls a Bonsai server (a
1622 kind of web-based viewcvs CGI script).
1624 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1625 Hearsum contributed a status plugin which sends email in the same
1626 format that Tinderbox does: this allows a number of tinderbox
1627 tools to be driven by Buildbot instead. Thanks Ben!
1629 2006-09-24 Brian Warner <warner@lothar.com>
1631 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1632 Thanks to Robert Helmer for the patch.
1634 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1635 BuildStatus about the buildslave name at the *beginning* of the
1636 build, rather than at the end. Thanks to Alexander Lorenz for the
1638 * buildbot/status/html.py (StatusResourceBuild.body): always
1639 include the slavename in the build page, not just when the build
1641 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1642 slavename in the email message
1644 2006-09-21 Brian Warner <warner@lothar.com>
1646 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1648 * docs/examples/glib_master.cfg: same
1649 * docs/examples/hello.cfg: same
1650 * docs/examples/twisted_master.cfg: same, update to current usage
1652 2006-09-19 Brian Warner <warner@lothar.com>
1654 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1655 (PyFlakes.createSummary): make it compatible with python-2.2
1657 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1658 for at least the output-parsing parts of PyFlakes
1660 2006-09-18 Brian Warner <warner@lothar.com>
1662 * buildbot/steps/python.py: oops, fix import of StringIO
1664 2006-09-17 Brian Warner <warner@lothar.com>
1666 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1667 turns out that SVN-1.4.0 doesn't fail to update once you've
1668 replaced a file with a directory, unlike older versions of SVN and
1669 pretty much every other VC tool we support. Since what we really
1670 care about is that the update succeeds anyway, stop checking that
1671 the tree got clobbered and just assert that the build succeeded.
1672 (VCBase.printLogs): add a utility function for debugging
1674 * buildbot/process/step.py: oops, added extra imports by mistake
1676 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1677 rstrip() on the first line coming out of the 'p4 describe'
1678 process, to remove the stray ^M that Wade Brainerd reports seeing
1679 in the 'when' field. Fixes SF#1555985.
1681 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1682 message logged when c['schedulers'] is not right
1683 * buildbot/scheduler.py (Scheduler.__init__): improve error
1684 message when a Scheduler() is created with the wrong arguments
1685 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1686 verify that these error messages are emitted
1688 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1689 The idea is that all the base classes (like BuildStep and
1690 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1691 will be a leftover backwards-compatibility file that only contains
1692 aliases for the steps that were moved out to buildbot.steps.*
1693 * lots: change imports to match
1694 * buildbot/process/step.py: add a DeprecationWarning if it ever
1697 2006-09-12 Brian Warner <warner@lothar.com>
1699 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1700 builderNames= is actually a sequence, since if you happen to give
1701 it a single builder-specification dictionary instead, it won't get
1702 caught by the existing assert. Thanks to Brett Neely for the
1705 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1707 * docs/buildbot.texinfo (Python BuildSteps): document them
1708 (sendchange): include a link to PBChangeSource, since you need one
1710 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1712 * buildbot/steps/dummy.py: same
1714 2006-09-08 Brian Warner <warner@lothar.com>
1716 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1717 BuildStep which lets you transfer files from the master to the
1718 slave or vice versa. Thanks to Albert Hofkamp for the original
1719 patch. Fixes SF#1504631.
1720 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1722 (SlaveFileDownloadCommand): same
1723 * docs/buildbot.texinfo (Transferring Files): document it
1724 * buildbot/test/test_transfer.py: test it
1725 * buildbot/test/runutils.py (StepTester): new utility class for
1726 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1727 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1730 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1731 walk through StatusLogs one line at a time, mostly for the benefit
1732 of ShellCommand.createSummary methods. You can either walk through
1733 STDOUT or STDERR, but the default is STDOUT.
1735 * buildbot/status/builder.py (LogFile.readlines): implement it.
1736 Note that this is not yet memory-efficient, it just pulls the
1737 whole file into RAM and then splits it up with a StringIO.
1738 Eventually this should be a generator that only pulls chunks from
1740 * buildbot/test/test_status.py (Log.testReadlines): test it
1742 * docs/buildbot.texinfo: update to match changes
1743 * buildbot/process/factory.py: stop using old definitions
1744 * buildbot/process/process_twisted.py: same
1745 * buildbot/test/test_*.py: same
1747 * buildbot/process/step_twisted.py: move definition to..
1748 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1749 relative-import mechanisms prevent this from being named 'twisted'
1750 or 'python/twisted' as I would have preferred.
1752 * buildbot/process/maxq.py: move definition to..
1753 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1755 * buildbot/process/step.py: split the user-visible BuildSteps into
1756 separate files, all under buildbot/steps/
1757 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1758 * buildbot/steps/shell.py: this holds ShellCommand and friends
1759 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1761 2006-09-05 Brian Warner <warner@lothar.com>
1763 * lots: run pyflakes, removed a lot of unused imports, changed the
1764 form of some conditional imports to remove false pyflakes
1765 warnings. There are still a number of warnings left, mostly from
1766 imports that are done for their side-effects.
1767 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1770 2006-08-26 Brian Warner <warner@lothar.com>
1772 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1773 compatible with twisted-1.3.0, for some reason I just can't seem
1774 to let go of the past.
1776 2006-08-25 Brian Warner <warner@lothar.com>
1778 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1780 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1781 all logfiles= in startCommand(), rather than in start() . This
1782 makes it easier to have the 'stdio' log come before any secondary
1783 logfiles, which I feel makes the waterfall display more
1785 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1786 from ShellCommand up into LoggingBuildStep
1787 (LoggingBuildStep.__init__): move the handling of logfiles= from
1788 ShellCommand up to LoggingBuildStep, because startCommand is
1789 provided by LoggingBuildStep, whereas start() was specific to
1790 subclasses like ShellCommand and Source. This removes code
1791 duplication in those subclasses.
1792 (ShellCommand.__init__): same
1793 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1794 for a slave that's too old to understand logfiles= into a separate
1795 method, so it can live in ShellCommand. The rest of
1796 setupLogfiles() can live in LoggingBuildStep.
1798 2006-08-24 Brian Warner <warner@lothar.com>
1800 * buildbot/locks.py (BaseLock): you can now configure Locks to
1801 allow multiple simultaneous owners. They still default to
1802 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1804 * docs/buildbot.texinfo (Interlocks): document the new options
1805 * buildbot/test/test_locks.py: add a bunch of new unit tests
1806 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1807 waitUntilMaybeAvailable, not waitUntilAvailable
1808 * buildbot/process/step.py (BuildStep.acquireLocks): same
1809 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1810 the whole lockid in their constructor, not just the name. Also,
1811 keep track of which real locks we've handed out by the full
1812 lockid, not just class+name, otherwise changing just the maxCount=
1813 in the master.cfg file would not actually cause a behavioral
1816 2006-08-23 Brian Warner <warner@lothar.com>
1818 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1820 * docs/buildbot.texinfo: same
1822 2006-08-23 Brian Warner <warner@lothar.com>
1824 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1825 * docs/buildbot.texinfo: set version to match
1826 * NEWS: update for 0.7.4
1827 * buildbot/slave/commands.py (command_version): mention that this
1828 version (2.1) was released with buildbot-0.7.4
1830 2006-08-22 Brian Warner <warner@lothar.com>
1834 * CREDITS: new file, list of people who have helped. Thanks!
1835 * MANIFEST.in: ship it
1837 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1838 new diagrams, the user's manual is more informative than it was.
1839 Start shipping the .html user's manual (and generated .png
1841 * Makefile: update 'release' target to match
1843 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1844 test.. I think the web-parts effort will render it pointless well
1845 before it ever actually starts to work.
1847 2006-08-20 Brian Warner <warner@lothar.com>
1849 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1850 meaning of the prefix= argument. It is now just a string which is
1851 stripped from the beginning of the filename. If prefix= is set but
1852 not found on any given filename, that filename is ignored. If all
1853 filenames in a Change are ignored, the Change is dropped. This is
1854 much simpler than the previous sep= nonsense, and I should have
1855 implemented it this way from the beginning. Effectively resolves
1856 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1857 Gedminas for the catch and suggested fixes.
1858 (ChangePerspective.perspective_addChange): implement the actual
1860 * buildbot/test/test_changes.py (TestChangePerspective): test it
1861 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1862 how to properly use prefix=
1863 * docs/examples/twisted_master.cfg (source): update prefix= by
1864 adding the trailing slash
1867 * docs/examples/twisted_master.cfg: update to actual practice
1869 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1870 update test case to match new link text.. the HREF has both a
1871 class= setting and an enclosing [] pair that I didn't match in the
1874 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1875 list of strings is preferred over a single string with embedded
1877 (ShellCommand.description=): explain that either single strings or
1878 a list of strings is acceptable, and why you might prefer one over
1879 the other. Add an example. Fixes SF#1524659, thanks to Paul
1880 Winkler for the catch.
1881 (Build Steps): update to use f.addStep() rather than using s()
1882 and the constructor list
1884 * buildbot/process/step.py (ShellCommand): accept either a single
1885 string or a list of strings in both description= and
1887 * buildbot/test/test_steps.py (Steps.test_description): test it
1888 * buildbot/test/runutils.py (makeBuildStep): support for that test
1890 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1891 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1892 collecting the files and creating the patch.
1894 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1895 per-step URLs that will be displayed on the waterfall display,
1896 for things like the HTML output of code-coverage tools, when
1897 the results are hosted elsewhere.
1898 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1899 way to retrieve these URLs
1900 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1901 the method to retrieve these URLs. Also provide backwards
1902 compatibility for saved BuildStepStatus instances that didn't have
1904 * buildbot/process/step.py (BuildStep.addURL): method to set these
1905 URLs from within a BuildStep
1906 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1907 (StepBox.getBox): give these external links a distinct CSS class
1908 named "BuildStep external" so a .css file can display them
1911 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1913 * buildbot/test/test_steps.py (Steps): test that we can all the
1914 URLs. Also add a bunch of other tests on methods that can be
1915 called from within BuildSteps
1916 * buildbot/test/runutils.py (makeBuildStep): add utility function
1918 2006-08-13 Brian Warner <warner@lothar.com>
1920 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1922 2006-08-10 Brian Warner <warner@lothar.com>
1924 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1925 index, this one of things like c['sources'] and c['schedulers']
1926 (indices): it looks like my clever idea of putting the @fooindex
1927 commands in between the @node and the @subsection (to make the
1928 HREF anchor jump to slightly above the section title, which works
1929 much better in html) confused texinfo horribly, so I'm moving the
1930 index tags back to be just after the @subsection marker. I also
1931 added extra lines between the @node/@section paragraph and the
1932 index tags, since I think maybe texinfo wants to see these be
1933 separate paragraphs.
1935 * docs/Makefile (images): make sure images get built when
1936 rendering the manual
1937 * docs/images/Makefile: same
1939 * buildbot/scripts/runner.py: rename 'buildbot master' to
1940 'buildbot create-master', and 'buildbot slave' to 'buildbot
1942 * docs/buildbot.texinfo: same
1945 * docs/buildbot.texinfo: reimplement the "useful classes" index
1946 with actual texinfo indices. The .info rendering is a bit
1947 weird-looking but it works well, and the HTML rendering is quite
1948 nice. This also puts the index targets in the regular flow of the
1949 text, which is easier to maintain.
1951 2006-08-06 Brian Warner <warner@lothar.com>
1953 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1954 Kevin Turner to prefer the environ= argument be a list rather than
1955 a string. If it is a list, it will be joined with a platform-local
1956 os.pathsep delimiter, and then prepended to any existing
1957 $PYTHONPATH value. This works better in cross-platform (i.e.
1958 windows buildslaves) environments when you need to push multiple
1959 directories onto the front of the path.
1960 (SlaveShellCommand): documented the new magic
1961 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1962 in a user-visible form
1964 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1965 Turner to prefer lists over strings when creating/running VC
1966 commands during unit tests. This is clearly necessary to survive
1967 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1968 renamed the wq() function to qw() though, since that's how it's
1969 spelled in perl. Eventually I'd prefer all commands to be
1970 specified with lists.
1972 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1973 which are deleted (or not yet created) correctly. Also add
1974 failsafe code to not explode if the file-watching poller doesn't
1975 get started. Thanks to JP Calderone for the catch and the poller
1977 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1979 * buildbot/test/emitlogs.py: same
1981 * NEWS: summarize recent changes
1983 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1984 clause to avoid the "host key mismatch" warning
1986 * buildbot/process/step_twisted.py (Trial.start): if the
1987 buildslave is too old to understand logfiles=, fall back to
1988 running 'cat _trial_temp/test.log' like before.
1989 (Trial.commandComplete): same. this takes advantage of the
1990 LoggingBuildStep refactoring to stall commandComplete long enough
1991 to run a second RemoteShellCommand.
1993 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1994 refactor command-completion handling, to allow methods like
1995 commandComplete/createSummary/evaluateCommand to return Deferreds.
1996 (LoggingBuildStep._commandComplete): delete the refactored method
1997 (ShellCommand.setupLogfiles): if the buildslave is too old to
1998 understand logfiles=, put a warning message both into twistd.log
1999 and into the otherwise empty user-visible LogFiles.
2001 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
2002 callers to provide the slave-side logfile name, rather than
2003 forcing it to come from the local name of the LogFile.
2004 (BuildStep.getSlaveName): new method
2006 * buildbot/process/base.py (Build.getSlaveName): new method, so
2007 steps can find out which buildslave they're running on
2009 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
2010 to match the s/cvs_ver/command_version/ change
2012 2006-08-05 Brian Warner <warner@lothar.com>
2014 * buildbot/slave/commands.py (command_version): replace the CVS
2015 auto-updated cvs_ver keyword with a manually-updated variable,
2016 since CVS is no longer the master repository. Add a description of
2017 the remote API change starting in this version (2.1), specifically
2018 the fact that SlaveShellCommand now accepts 'initial_stdin',
2019 'keep_stdin_open', and 'logfiles'.
2021 2006-07-31 Brian Warner <warner@lothar.com>
2023 * docs/buildbot.texinfo (System Architecture): Finally add lots of
2024 diagrams to describe how the whole system fits together. The
2025 images themselves are kept in SVG files, with ascii-art versions
2026 in corresponding .txt files. Texinfo knows how to interpolate the
2027 text version into .info files, reference the .png versions from
2028 .html files, and include .eps versions in the .ps format.
2029 * docs/images/Makefile: tools to create .png and .eps
2030 * docs/images/*.svg: created pictures with Inkscape.
2031 * .darcs-boring: ignore the generated .eps and .png files
2033 2006-07-24 Brian Warner <warner@lothar.com>
2035 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
2036 Scheduler names, since they cause setServiceParent to explode
2038 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
2040 2006-07-20 Brian Warner <warner@lothar.com>
2042 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
2043 which runs the buildbot unit tests
2045 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
2046 classes that are useful in master.cfg
2048 2006-07-15 Brian Warner <warner@lothar.com>
2050 * Makefile (some-apidocs): new target to build only some epydocs
2052 * setup.py: minor comment.. does the classifiers= argument prevent
2053 the setup.py script from working on python2.2/2.3?
2055 * buildbot/scripts/sample.cfg: update manhole example, arrange into
2058 * buildbot/twcompat.py: fix minor typo in comments
2060 * buildbot/manhole.py: move all Manhole-related code out to this
2061 module. Implement SSH-based manholes (with TwistedConch), and move
2062 to conch's nifty line-editing syntax-coloring REPL shell instead
2063 of the boring non-editing monochromatic (and deprecated) old
2065 * buildbot/master.py: remove all Manhole-related code
2066 (BuildMaster.loadConfig._add): make sure the old manhole is
2067 removed before we add the new one
2068 * docs/buildbot.texinfo (Debug options): document new Manhole options
2070 * buildbot/twcompat.py (_which): fix some epydoc issues
2071 * buildbot/status/html.py (Waterfall.__init__): same
2073 2006-06-29 Brian Warner <warner@lothar.com>
2075 * buildbot/interfaces.py: get Interface from b.twcompat to hush
2076 deprecation warnings under newer Twisteds (by using
2077 zope.interface.Interface instead of old twisted.python.components
2079 * buildbot/slave/interfaces.py: same
2081 2006-06-28 Brian Warner <warner@lothar.com>
2083 * buildbot/slave/commands.py (SVN): add --non-interactive to all
2084 svn commands, so it will fail immediately instead of hanging while
2085 it waits for a username/password to be typed in.
2087 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
2088 log message if the step was shut down
2090 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
2091 obsolete reference to mktap.
2093 2006-06-20 Brian Warner <warner@lothar.com>
2095 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
2096 test to include new 'logfiles' argument sent from master to slave
2098 2006-06-19 Brian Warner <warner@lothar.com>
2100 * buildbot/process/step_twisted.py (Trial): track Progress from
2101 _trial_temp/test.log too
2103 * buildbot/process/step.py (OutputProgressObserver): generalize
2104 the earlier StdioProgressObserver into an OutputProgressObserver
2105 that can track LogFiles other than stdio.
2106 (LoggingBuildStep.__init__): same
2108 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
2109 _trial_temp/test.log, not a separate 'cat' command. TODO: this
2110 will fail under windows because of os.sep issues. It might have
2111 worked before if 'cat' was doing cygwin path conversion.
2113 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
2114 creation of LogFileWatchers
2115 (ShellCommand._startCommand): and record the files that were
2116 watched in the 'headers' section of the ShellCommand output
2118 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
2119 need to actually pass it to the slave if you want it to work.
2120 (ShellCommand): document it a bit
2122 * buildbot/test/test_shell.py: new test to validate LogFiles
2123 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
2125 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
2126 before printing the last batch of lines, to test that the polling
2127 logic is working properly
2129 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
2130 handling, making it possible to track multiple logs for a single
2131 RemoteCommand. The previous single logfile is now known as the
2133 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
2134 (RemoteShellCommand.__init__): accept logfiles=
2135 (LoggingBuildStep.startCommand): stdio_log is now one of many
2136 (ShellCommand): added logfiles= argument, as well as a class-level
2137 .logfiles attribute, which will be merged together to figure out
2138 which logfiles should be tracked. The latter maybe be useful for
2139 subclasses of ShellCommand which know they will aways produce
2140 secondary logfiles in the same location.
2142 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
2143 and closeStdin() methods, preparing to make it possible to write
2144 to a ShellCommand's stdin at any time, not just at startup. These
2145 writes are buffered if the child process hasn't started yet.
2146 (LogFileWatcher): new helper class to watch arbitrary logfiles
2147 while a ShellCommand runs. This class polls the file every two
2148 seconds, and sends back 10k chunks to the buildmaster.
2149 (ShellCommand): rename stdin= to initialStdin=, and add
2150 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
2152 (ShellCommand.addLogfile): LogFile text is sent in updates with a
2153 key of "log" and a value of (logname, data).
2154 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
2155 'logfiles' to the master-visible args dictionary.
2156 (SourceBase.doPatch): match s/stdin/initialStdin/ change
2159 * buildbot/test/test_vc.py (Patch.testPatch): same
2162 * buildbot/test/emit.py: write to a logfile in the current
2163 directory. We use this to figure out what was used as a basedir
2164 rather than looking to see which copy of emit.py gets run, so that
2165 we can run the commands from inside _trial_temp rather than inside
2167 * buildbot/test/subdir/emit.py: same
2168 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
2169 argument rather than running from buildbot/test/
2170 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
2171 rather than using an implicit setUp()
2172 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
2173 (ShellBase.testShell1, etc): use explicit path to emit.py instead
2174 of assuming that we're running in buildbot/test/ (and that '.' is
2177 * buildbot/slave/commands.py (Command.doStart): refactor Command
2178 startup/completion a bit: now the SlaveBuilder calls doStart(),
2179 which is not meant for overridding by subclasses, and doStart()
2180 calls start(), which is. Likewise the SlaveBuilder calls
2181 doInterrupt(), and subclasses override interrupt(). This also puts
2182 responsibility for maintaining .running in Command rather than in
2184 (Command.doInterrupt): same
2185 (Command.commandComplete): same, this is called when the deferred
2186 returned by start() completes.
2187 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
2188 (SlaveBuilder.remote_interruptCommand): same
2189 (SlaveBuilder.stopCommand): same
2191 2006-06-16 Brian Warner <warner@lothar.com>
2193 * buildbot/test/test_shell.py: new test file to contain everything
2194 relating to ShellCommand
2195 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
2196 multiple logfiles in realtime" feature, not yet implemented
2197 * buildbot/test/emitlogs.py: support file for testLogFiles
2198 * docs/buildbot.texinfo (ShellCommand): document the feature
2200 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2202 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2203 for tests which exercise SlaveCommands in isolation.
2205 * buildbot/test/test_slavecommand.py: Move some utilities like
2206 SignalMixin and FakeSlaveBuilder from here ..
2207 * buildbot/test/runutils.py: .. to here, so they can be used by
2208 other test classes too
2209 * buildbot/test/test_vc.py: more SignalMixin refactoring
2210 * buildbot/test/test_control.py: same
2211 * buildbot/test/test_run.py: and some rmtree refactoring
2213 2006-06-15 Brian Warner <warner@lothar.com>
2215 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2216 'testBranch' to match other VC tests and have the tests run in
2217 roughly increasing order of dependency
2219 * buildbot/test/test_steps.py (LogObserver): new test to verify
2220 LogObservers can be created at various times and still get
2221 connected up properly
2223 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2224 to create BuildStepStatus instances that actually work.
2226 * buildbot/process/step.py (LogObserver): add outReceived and
2227 errReceived base methods, to be overridden
2229 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2230 API to take a name instead of a step, reducing the coupling
2231 somewhat. This returns the BuildStepStatus object so it can be
2232 passed to the new Step, instead of jamming it directly into the
2234 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2236 * buildbot/process/base.py (Build.setupBuild): use both methods
2237 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2238 process a bit to match
2240 2006-06-14 Brian Warner <warner@lothar.com>
2242 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2243 docs on writing new LogObserver classes
2244 (Writing New Status Plugins): brief docs on how Status Plugins fit
2247 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2248 implement a LogObserver that counts how many unit tests have been
2250 (Trial.__init__): wire it in
2251 * buildbot/test/test_twisted.py (Counter): unit test for it
2253 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2254 to new cmd.logs['stdio'] scheme
2255 (Trial.commandComplete): same
2256 (BuildDebs.commandComplete): same
2258 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2259 LogFiles, instead of just a single one. The old single logfile is
2260 now called "stdio". LoggedRemoteCommand no longer creates a
2261 LogFile for you (the code to do that was broken anyway). If you
2262 don't create a "stdio" LogFile, then stdout/stderr will be
2264 (LogObserver): implement "LogObservers", which a BuildStep can add
2265 to parse the output of a command in real-time. The primary use is
2266 to provide more useful information to the Progress code, allowing
2267 better ETA estimates.
2268 (LogLineObserver): utility subclass which feeds complete lines to
2269 the parser instead of bytes.
2270 (BuildStep.progressMetrics): this is safer as a tuple
2271 (BuildStep.setProgress): utility method, meant to be called by
2273 (BuildStep.addLogObserver): new method, to be called at any time
2274 during the BuildStep (even before any LogFiles have been created),
2275 to attach (or schedule for eventual attachment) a LogObserver to a
2277 (StdioProgressObserver): new LogObserver which replaces the old
2278 "output" progress gatherer
2279 (LoggingBuildStep.__init__): same
2280 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2281 (LoggingBuildStep._commandComplete): must use logs['stdio']
2282 instead of the old single ".log" attribute.
2283 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2284 functionality, now subsumed into StdioProgressObserver
2285 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2286 log name changed from "output" to "stdio".
2289 * buildbot/interfaces.py (ILogFile): add the Interface used from
2290 the BuildStep towards the LogFile
2291 (ILogObserver): and the one provided by a LogObserver
2292 * buildbot/status/builder.py (LogFile): implement it
2294 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2295 HEADER constants here ..
2296 * buildbot/status/builder.py (STDOUT): .. from here
2298 2006-06-13 Brian Warner <warner@lothar.com>
2300 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2301 compatibility with python2.2, which doesn't have the 'substr in
2303 (TestP4Poller.makeTime): utility function to construct the
2304 timestamp using the same strptime() approach as p4poller does. It
2305 turns out that time.mktime() behaves slightly differently under
2306 python2.2, probably something to do with the DST flag, and that
2307 causes the test to fail under python2.2. (changing the mktime()
2308 arguments to have dst=0 instead of -1 caused it to fail under
2309 python2.3. Go figure.)
2310 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2312 2006-06-12 Brian Warner <warner@lothar.com>
2314 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2315 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2316 contributing such an excellent patch, including docs and unit
2317 tests! This makes it *so* much easier to apply. I had to update
2318 test_vc.py to handle some recent refactorings, but everything else
2319 applied smoothly. The only remaining thing I'd like to fix would
2320 be to remove the hard-wired port 1666 used by p4d, and allow it to
2321 claim any unused port. This would allow two copies of the test
2322 suite to run on the same host at the same time, as well as
2323 allowing the test suite to run while a real (production) p4d was
2324 running on the same host. Oh, and maybe we should add a warning to
2325 step.P4 that gets emitted if the slave is too old to provide the
2326 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2327 * buildbot/slave/commands.py (P4): same
2328 (P4Sync): same, some minor updates
2329 * buildbot/changes/p4poller.py: same
2330 * docs/buildbot.texinfo: same
2331 * buildbot/test/test_p4poller.py: same
2332 * buildbot/test/test_vc.py (P4): same
2334 * setup.py: add Trove classifiers for PyPI
2336 2006-06-08 Brian Warner <warner@allmydata.com>
2338 * buildbot/status/client.py
2339 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2340 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2341 build needs to be IRemote'd separately, rather than IRemote'ing
2342 the whole list at once. I can't wait until newpb's serialization
2343 adapters make this unnecessary.
2345 2006-06-06 Brian Warner <warner@lothar.com>
2347 * buildbot/process/step.py (WithProperties): make this inherit
2348 from ComparableMixin, so that reloading an unchanged config file
2349 doesn't cause us to spuriously reload any Builders which use them.
2350 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2353 2006-06-03 Brian Warner <warner@lothar.com>
2355 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2356 running py2exe on windows, contributed by Mark Hammond. Addresses
2357 SF#1401121, but I think we still need to include
2358 buildbot/scripts/sample.cfg
2359 * setup.py: include buildbot_service.py as a script under windows
2360 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2361 a py2exe application), get the icon/css datafiles from a different
2364 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2365 double-escape the build URL. Thanks to Olivier Bonnet for the
2366 patch. Fixes SF#1452801.
2368 2006-06-02 Brian Warner <warner@lothar.com>
2370 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2371 first six columns of 'svnlook' output, not just the first column,
2372 since property changes appear in the other five. Thanks to Olivier
2373 Bonnet for the patch. Fixes SF#1398174.
2375 2006-06-01 Brian Warner <warner@lothar.com>
2377 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2378 the fake build, so that title= has something to be set to
2380 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2381 attribute of the "Build #NN" link in the yellow start-the-build
2382 box to the build's reason. This means that you get a little
2383 tooltip explaining why the build was done when you hover over the
2384 yellow box. Thanks to Zandr Milewski for the suggestion.
2386 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2387 (Box.setETA): handle ETA=None (by stopping the timer)
2388 (Box.update): make the [soon] text less different than the usual
2389 text, so the rest of the text doesn't flop around so much. It
2390 would be awfully nice to figure out how to center this stuff.
2391 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2393 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2394 by default, so that any ShellCommand which fails marks the overall
2395 build as a failure. I should have done this from the beginning.
2396 Add flunkOnFailure=False to the arguments if you want to turn off
2399 2006-05-30 Brian Warner <warner@lothar.com>
2401 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2402 last-build/current-build/current-step. Show what step is currently
2403 running. Show ETA for both the overall build and the current step.
2404 Update GTK calls to modern non-deprecated forms. There's still a
2405 lot of dead code and debug noise to remove.
2407 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2408 shows up properly in status displays
2410 2006-05-28 Brian Warner <warner@lothar.com>
2412 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2413 build we use to verify that WithProperties works:
2415 ** set flunkOnFailure=True so that build failures get noticed
2416 ** set workdir='.' so that the build succeeds, otherwise it is trying
2417 to touch 'build/something', and 'build/' doesn't exist because
2418 usually that's created by a Source step
2419 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2420 this test somehow triggers, in which the 'touch' process becomes
2421 a zombie and we wait for th etimeout before giving up on it.
2423 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2424 to log the Build results and step logs to the twisted log.
2425 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2426 what went wrong if a build was expected to succeed but didn't.
2428 * buildbot/process/step_twisted.py (Trial): set the default
2429 trialMode to '--reporter=bwverbose', which specifies verbose
2430 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2431 '-to', but those are completely missing in modern Twisteds.
2433 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2434 a localhost-only port, to encourage better security
2436 * docs/buildbot.texinfo (Change Sources): mention
2439 * .darcs-boring: add a Darcs boringfile
2441 * README (REQUIREMENTS): stop claiming compatibility with
2444 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2447 2006-05-27 Brian Warner <warner@lothar.com>
2449 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2450 * docs/buildbot.texinfo: same
2452 2006-05-23 Brian Warner <warner@lothar.com>
2454 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2455 * docs/buildbot.texinfo: set version to match
2456 * NEWS: update for 0.7.3
2458 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2459 give a quick mapping from VC system to possible ChangeSources
2460 (Build Properties): add 'buildername'
2462 * buildbot/process/base.py (Build.setupStatus): oops, set
2463 'buildername' and 'buildnumber' properties
2464 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2467 2006-05-22 Brian Warner <warner@lothar.com>
2469 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2470 property interpolation better
2472 * README (INSTALLATION): remove old '-v' argument from recommended
2475 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2476 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2479 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2480 'svnversion' instead of grepping the output of 'svn info', much
2481 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2482 Bonnet for the suggestion.
2483 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2484 require the WC_PATH argument, so run 'svnversion .' instead.
2486 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2487 aren't supposed to have 'self' in their argument list
2489 2006-05-21 Brian Warner <warner@lothar.com>
2491 * buildbot/process/step.py (ShellCommand.start): make
2492 testInterpolate pass. I was passing the uninterpolated command to
2493 the RemoteShellCommand constructor
2494 (ShellCommand._interpolateProperties): oops, handle non-list
2495 commands (i.e. strings with multiple words separated by spaces in
2496 them) properly, instead of forgetting about them.
2498 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2499 to actually try to use build properties in a real build. This test
2501 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2502 to start and evaluate builds
2504 * buildbot/test/test__versions.py: add a pseudo-test to record
2505 what version of Twisted/Python/Buildbot are running. This should
2506 show up at the beginning of _trial_tmp/test.log, and exists to help
2507 debug other problems.
2509 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2510 a filename to be served as 'robots.txt' to discourage web spiders.
2511 Adapted from a patch by Tobi Vollebregt, thanks!
2512 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2513 (Waterfall.test_waterfall): tweak the way that filenames are put
2514 into the config file, to accomodate windows pathnames better.
2516 * docs/buildbot.texinfo (HTML Waterfall): document it
2518 * buildbot/process/process_twisted.py
2519 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2520 changed the build process. The new setup.py no longer takes the
2522 (FullTwistedBuildFactory.__init__): same
2523 (TwistedReactorsBuildFactory.__init__): same
2525 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2526 be placed in the [hooks] section of the central repository (the
2527 one that everybody pushes changes to).
2529 2006-05-20 Brian Warner <warner@lothar.com>
2531 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2532 .darcs-context file, use binary mode. I think this was causing a
2533 Darcs failure under windows.
2535 2006-05-19 Brian Warner <warner@lothar.com>
2537 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2538 use a timezone string of +0000 and gmtime, since this timestamp is
2539 sent to a buildmaster and %z is broken.
2541 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2542 string and localtime, since this timestamp will only be consumed
2543 locally, and %z is broken.
2545 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2546 gmtime, since this timestamp is returned to the buildmaster, and
2549 2006-05-18 Brian Warner <warner@lothar.com>
2551 * NEWS: update in preparation for next release
2553 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2554 setup-repository and do-we-have-the-vc-tools code into a separate
2555 "helper" class, which sticks around in a single module-level
2556 object. This seems more likely to continue to work in the future
2557 than having it hide in the TestCase and hope that TestCases stick
2558 around for a long time.
2560 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2561 addremove' has been deprecated in recent versions of mercurial, so
2562 use 'hg add' instead
2564 2006-05-07 Brian Warner <warner@lothar.com>
2566 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2567 operating under windows, move the file before opening it, since
2568 you can't rename a file that somebody has open.
2570 * buildbot/process/base.py (Build.setupBuild): if something goes
2571 wrong while creating a Step, log the name and arguments, since the
2572 error message when you get the number of arguments wrong is really
2575 2006-05-06 Brian Warner <warner@lothar.com>
2577 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2578 bugs in twisted-specific code not covered by my unit tests, this
2579 time use 'cmd' argument instead of self.cmd
2581 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2582 fix stupid braino: either use startwith or find()==0, not both.
2583 (TwistedReactorsBuildFactory.__init__): another dumb typo
2585 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2586 mark this test as TODO under windows, since process-killing seems
2587 dodgy there. We'll come back to this later and try to fix it
2590 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2591 and don't include a timezone
2592 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2593 This should avoid the windows-with-verbose-timezone-name problem
2595 (Patch.testPatch): add a test which runs 'patch' with less
2596 overhead than the full VCBase.do_patch sequence, to try to isolate
2597 a windows test failure. This one uses slave.commands.ShellCommand
2598 and 'patch', but none of the VC code.
2600 * buildbot/slave/commands.py (getCommand): use which() to find the
2601 executables for 'cvs', 'svn', etc. This ought to help under
2604 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2605 working directory before starting. If an earlier test failed, the
2606 leftover directory would mistakenly flunk a later test.
2607 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2608 Make sure that we use the right commandlines if which("tla") picks
2609 up "tla.exe" (as it does under windows).
2610 (TlaSupport.do_get): factor out this tla-vs-baz difference
2611 (TlaSupport.vc_create): more tla-vs-baz differences
2613 * buildbot/test/test_slavecommand.py
2614 (ShellBase.testShellMissingCommand): stop trying to assert
2615 anything about the error message: different shells on different
2616 OSes with different languages makes it hard, and it really isn't
2617 that interesting of a thing to test anyway.
2619 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2620 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2621 "Panther"), because it has a bug which flunks a couple tests in
2622 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2623 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2624 able to test that yet.
2626 2006-04-30 Brian Warner <warner@lothar.com>
2628 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2629 make sure child commands emit messages in english, so our regexps
2630 will match. Thanks to Nikaus Giger for identifying the problems.
2631 (VCBase._do_vctest_export_1): mode="export" is not responsible
2632 for setting the "got_revision" property, since in many cases it is
2633 not convenient to determine.
2634 (SVNSupport.capable): when running 'svn --version' to check for
2635 ra_local, we want error messages in english
2636 * buildbot/test/test_slavecommand.py
2637 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2638 to emit the error message in english
2640 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2641 the environment with $LC_ALL="C" so that Commands which need to
2642 parse the output of their child processes can obtain it in
2644 (SVN.parseGotRevision): call "svn info" afterwards instead of
2645 watching the output of the "svn update" or "svn checkout".
2646 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2647 (Arch.parseGotRevision): same
2648 (Bazaar.parseGotRevision): same
2649 (Mercurial.parseGotRevision): same
2651 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2652 $LC_ALL="C" when running commands under 'buildbot try', too
2654 * buildbot/test/__init__.py: remove the global os.environ()
2655 setting, instead we do it just for the tests that run commands and
2656 need to parse their output.
2658 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2659 remove the overly-short .timeout on this test, because non-DNotify
2660 platforms must fall back to polling which happens at 10 second
2661 intervals, so a 5 second timeout would never succeed.
2663 2006-04-24 Brian Warner <warner@lothar.com>
2665 * docs/buildbot.texinfo (Installing the code): update trial
2666 invocation, SF#1469116 by Niklaus Giger.
2667 (Attributes of Changes): updated branch-name examples to be
2668 a bit more realistic, SF#1475240 by Stephen Davis.
2670 * contrib/windows/buildbot2.bat: utility wrapper for windows
2671 developers, contributed by Nick Trout (after a year of neglect..
2672 sorry!). SF#1194231.
2674 * buildbot/test/test_vc.py (*.capable): store the actual VC
2675 binary's pathname in VCS[vcname], so it can be retrieved later
2676 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2677 strip out non-numeric timezone information, specifically the funky
2678 German string that his system produced that confuses CVS.
2679 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2680 allow Darcs tests to work on windows
2681 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2682 procutils.which() everywhere, to allow tryclient to work under
2683 windows. Also from Niklaus Giger, SF#1463394.
2685 * buildbot/twcompat.py (which): move the replacement for a missing
2686 twisted.python.procutils.which from test_vc.py to here, so it can
2687 be used in other places too (specifically tryclient.py)
2689 2006-04-23 Brian Warner <warner@lothar.com>
2691 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2692 bare buildbotURL/projectName line with a proper DIV, along with a
2693 CSS class of "title", from Stefan Seefeld (SF#1461675).
2694 (WaterfallStatusResource.body0): remove the redundant 'table'
2695 class from the table
2696 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2697 to the top-row TR, and class="Activity" to the second-row TR,
2698 rather than putting them in the individual TD nodes.
2700 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2701 'got_revision' build property for all VC systems that implement
2702 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2704 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2705 to determine which revision we actually obtained
2706 (CVS.parseGotRevision): implement this for CVS, which just means
2707 to grab a timestamp. Not ideal, and it depends upon the buildslave
2708 having a clock that is reasonably well syncronized with the server,
2709 but it's better than nothing.
2710 (SVN.parseGotRevision): implement it for SVN, which is accurate
2711 (Darcs.parseGotRevision): same
2712 (Arch.parseGotRevision): same
2713 (Bazaar.parseGotRevision): same
2714 (Mercurial.parseGotRevision): same
2716 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2717 keep a record of all non-stdout/stderr/header/rc status updates,
2718 for the benefit of RemoteCommands that send other useful things,
2720 (Source.commandComplete): put any 'got_revision' status values
2721 into a build property of the same name
2724 * buildbot/process/step_twisted.py (Trial): update to deal with
2725 new ShellCommand refactoring
2727 * docs/buildbot.texinfo (Build Properties): document new feature
2728 that allows BuildSteps to get/set Build-wide properties like which
2729 revision was requested and/or checked out.
2731 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2732 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2733 it. Note that this bumps the persistenceVersion of the saved Build
2734 object, so add the necessary upgrade-old-version logic to include
2735 an empty properties dict.
2737 * buildbot/process/base.py (Build.setProperty): implement it
2738 (Build.getProperty): same
2739 (Build.startBuild): change build startup to set 'branch',
2740 'revision', and 'slavename' properties at the right time
2742 * buildbot/process/step.py (BuildStep.__init__): change setup to
2743 require 'build' argument in a better way
2744 (LoggingBuildStep): split ShellCommand into two pieces, for better
2745 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2746 a single RemoteCommand that sends stdout/stderr status text. It
2747 also provides the usual commandComplete / createSummary /
2748 evaluateCommand / getText methods to be overridden...
2749 (ShellCommand): .. whereas ShellCommand is specifically for
2750 running RemoteShellCommands. Other shell-like BuildSteps (like
2751 Source) can inherit from LoggingBuildStep instead of ShellCommand
2752 (WithProperties): marker class to do build-property interpolation
2753 (Source): inherit from LoggingBuildStep instead of ShellCommand
2756 * buildbot/test/test_properties.py: test new functionality
2758 2006-04-21 Brian Warner <warner@lothar.com>
2760 * buildbot/test/test_vc.py: rename testBranch to
2761 testCheckoutBranch to keep the tests in about the right
2764 2006-04-18 Brian Warner <warner@lothar.com>
2766 * docs/buildbot.texinfo (PBListener): improve cross-references
2767 between PBListener and 'buildbot statusgui', thanks to John Pye
2770 2006-04-17 Brian Warner <warner@lothar.com>
2772 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2773 running under Twisted-1.3.0, otherwise skipped tests are reported
2776 * all: use isinstance() instead of 'type(x) is foo', suggested by
2779 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2780 oops, fix a brain-fade from the other week, when making the
2781 addStep changes. I changed all the __init__ upcalls to use the
2782 wrong superclass name.
2783 (FullTwistedBuildFactory.__init__): same
2784 (TwistedDebsBuildFactory.__init__): same
2785 (TwistedReactorsBuildFactory.__init__): same
2786 (TwistedBuild.isFileImportant): use .startswith for clarity,
2787 thanks to Neal Norwitz for the suggestions.
2789 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2790 changes, then deliver them over PB to a remote buildmaster.
2792 * contrib/svnpoller.py: added script by John Pye to poll a remote
2793 SVN repository (by running 'svn log') from a cronjob, and run
2794 'buildbot sendchange' to deliver the changes to a remote
2796 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2797 modification of svnpoller.py), same purpose, but this one loops
2798 internally (rather than expecting to run from a cronjob) and works
2800 * contrib/README.txt: same
2802 2006-04-11 Brian Warner <warner@lothar.com>
2804 * all: fix a number of incorrect names and missing imports, thanks
2805 to Anthony Baxter for the patch.
2806 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2807 remove unused buggy method.
2808 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2809 comes from shutil, not "shutils"
2810 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2811 (Arch.checkSlaveVersion): same
2812 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2814 * buildbot/process/step_twisted2.py: add some missing imports
2815 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2816 this code used to live in twisted.internet.defer
2818 2006-04-10 Brian Warner <warner@lothar.com>
2820 * buildbot/process/step.py (Mercurial): add Mercurial support
2821 * buildbot/slave/commands.py (Mercurial): same
2822 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2823 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2824 not yet tested, but 'try' support *is* covered
2825 * docs/buildbot.texinfo (Mercurial): document it
2827 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2828 some debugging messages (turned off)
2829 * buildbot/test/test_vc.py: improve debug messages
2831 2006-04-07 Brian Warner <warner@lothar.com>
2833 * buildbot/test/test_vc.py (which): define our own which() in case
2834 we can't import twisted.python.procutils, because procutils doesn't
2835 exist in Twisted-1.3
2837 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2838 of SlaveLocks for performance tests
2840 * docs/examples/twisted_master.cfg: update to match current usage
2842 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2843 password, p4 binary, pollinterval, maximum history to check.
2844 Patch from an anonymous sf.net contributor, SF#1219384.
2845 * buildbot/process/step.py (P4Sync.__init__): add username,
2846 password, and client arguments.
2847 * buildbot/slave/commands.py (P4Sync): same
2849 2006-04-05 Brian Warner <warner@lothar.com>
2851 * buildbot/process/factory.py (BuildFactory.addStep): new method
2852 to add steps to a BuildFactory. Use it instead of f.steps.append,
2853 and you can probably avoid using the s() convenience function.
2854 Patch from Neal Norwitz, sf.net #1412605.
2855 (other): update all factories to use addStep
2856 * buildbot/process/process_twisted.py: update all factories to use
2859 2006-04-03 Brian Warner <warner@lothar.com>
2861 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2862 work under windows too. Adapted from a patch by Niklaus Giger,
2863 addresses SF#1463399.
2865 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2866 spawned commands emit parseable results in english and not some
2867 other language. Patch from Niklaus Giger, SF#1463395.
2869 * README (INSTALLATION): discourage users from running unit tests on
2870 a "network drive", patch from Niklaus Giger, SF#1463394.
2872 2006-03-22 Brian Warner <warner@lothar.com>
2874 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2875 function to turn a repository-relative pathname into a (branch,
2876 branch-relative-filename) tuple. Change this function to handle
2877 the branch naming policy used by your Subversion repository.
2878 Thanks to AllMyData.com for sponsoring this work.
2880 2006-03-16 Brian Warner <warner@lothar.com>
2882 * buildbot/scripts/sample.cfg: add python-mode declaration for
2883 vim. Thanks to John Pye for the patch.
2885 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2886 command line, mention the importance of running 'crontab' as the
2887 buildmaster/buildslave user. Thanks to John Pye for the catch.
2889 2006-03-13 Brian Warner <warner@lothar.com>
2891 * buildbot/status/words.py (IRC): add an optional password=
2892 argument, which will be sent to Nickserv in an IDENTIFY message at
2893 login, to claim the nickname. freenode requires this before the
2894 bot can sent (or reply to) private messages. Thanks to Clement
2895 Stenac for the patch.
2896 * docs/buildbot.texinfo (IRC Bot): document it
2898 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2899 larger than chunkSize. Fixes SF#1349253.
2900 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2901 (Log.testConsumer): update to match new internal chunking behavior
2903 2006-03-12 Brian Warner <warner@lothar.com>
2905 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2907 * buildbot/test/test_maildir.py (MaildirTest): rename the
2908 'timeout' method, as it collides with trial's internals
2910 * buildbot/scripts/runner.py: add 'buildbot restart' command
2911 (stop): don't sys.exit() out of here, otherwise restart can't work
2912 * docs/buildbot.texinfo (Shutdown): document it
2914 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2915 * buildbot/status/html.py (Waterfall.__init__): same
2916 * buildbot/process/builder.py (Builder.startBuild): same
2917 * buildbot/process/base.py (BuildRequest): same
2918 * buildbot/sourcestamp.py (SourceStamp): same
2919 * buildbot/scheduler.py (Nightly): same
2921 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2923 * docs/buildbot.texinfo: same
2925 2006-02-17 Brian Warner <warner@lothar.com>
2927 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2928 * docs/buildbot.texinfo: set version number to match
2929 * NEWS: update for 0.7.2
2931 2006-02-16 Brian Warner <warner@lothar.com>
2933 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2935 2006-02-09 Brian Warner <warner@lothar.com>
2937 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2938 add text to explain per-build branch parameters
2939 * NEWS: mention --umask
2941 2006-02-08 Brian Warner <warner@lothar.com>
2943 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2945 (SlaveOptions.optParameters): add --umask, to make it possible to
2946 make buildslave-generated files (including build products) be
2949 * buildbot/slave/bot.py (BuildSlave.startService): same
2951 2006-01-23 Brian Warner <warner@lothar.com>
2953 * buildbot/status/builder.py: urllib.quote() all URLs that include
2954 Builder names, so that builders can include characters like '/'
2955 and ' ' without completely breaking the resulting HTML. Thanks to
2956 Kevin Turner for the patch.
2957 * buildbot/status/html.py: same
2958 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2960 * NEWS: update in preparation for upcoming release
2962 2006-01-18 Brian Warner <warner@lothar.com>
2964 * docs/examples/twisted_master.cfg: update to match the Twisted
2965 buildbot: remove python2.2, switch to exarkun's buildslaves,
2966 disable the .deb builder until we figure out how to build twisted
2967 .debs from SVN, add some ktrace debugging to the OS-X build
2968 process and remove the qt build, remove threadless builders,
2969 change freebsd builder to use landonf's buildslave.
2971 2006-01-12 Brian Warner <warner@lothar.com>
2973 * buildbot/master.py (Manhole.__init__): let port= be a strports
2974 specification string, but handle a regular int for backwards
2975 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2976 used in master.cfg to limit connections to just the local host.
2977 (BuildMaster.loadConfig): same for c['slavePortnum']
2978 * buildbot/scheduler.py (Try_Userpass.__init__): same
2979 * buildbot/status/client.py (PBListener.__init__): same
2980 * buildbot/status/html.py (Waterfall.__init__): same, for both
2981 http_port and distrib_port. Include backwards-compatibility checks
2982 so distrib_port can be a filename string and still mean unix:/foo
2983 * docs/buildbot.texinfo (Setting the slaveport): document it
2984 (Debug options): same
2985 (HTML Waterfall): same
2988 * buildbot/test/test_config.py (ConfigTest): test it
2990 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2991 slaveport's disownServiceParent deferred to fire before opening
2992 the new one. Fixes an annoying bug in the unit tests.
2994 2006-01-03 Brian Warner <warner@lothar.com>
2996 * buildbot/master.py (BuildMaster): remove the .schedulers
2997 attribute, replacing it with an allSchedulers() method that looks
2998 for all IService children that implement IScheduler. Having only
2999 one parent/child relationship means fewer opportunities for bugs.
3000 (BuildMaster.allSchedulers): new method
3001 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
3002 also fix ugly bug that caused any config-file reload to
3003 half-forget about the earlier Schedulers, causing an exception
3004 when a Change arrived and was handed to a half-connected
3005 Scheduler. The exception was in scheduler.py line 54ish:
3006 self.parent.submitBuildSet(bs)
3007 exceptions.AttributeError: 'NoneType' object has no attribute
3009 (BuildMaster.addChange): update to use allSchedulers()
3011 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
3012 to work properly with twisted-1.3.0, where you must explicitly
3013 include the __implements__ from parent classes
3014 (BaseScheduler.__repr__): make it easier to distinguish distinct
3016 (BaseUpstreamScheduler.__implements__): same
3018 * buildbot/status/builder.py (Status.getSchedulers): update to
3020 * buildbot/test/test_run.py (Run.testMaster): same
3021 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
3022 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
3023 make sure Scheduler instances are left alone when an identical
3024 config file is reloaded
3025 (ConfigElements.testSchedulers): make sure Schedulers are properly
3028 * Makefile (TRIALARGS): my local default Twisted version is now
3029 2.1.0, update the trial arguments accordingly
3031 2005-12-22 Brian Warner <warner@lothar.com>
3033 * docs/examples/twisted_master.cfg: merge changes from pyr: add
3036 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
3037 addChange in the parent class, although I suspect this should be
3038 fixed better in the future.
3040 2005-11-26 Brian Warner <warner@lothar.com>
3042 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
3043 explode when branch==None, thanks to Kevin Turner for the catch
3044 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
3047 * buildbot/__init__.py (version): bump to 0.7.1+ while between
3049 * docs/buildbot.texinfo: same
3051 2005-11-26 Brian Warner <warner@lothar.com>
3053 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
3054 * docs/buildbot.texinfo: set version number to match
3056 2005-11-26 Brian Warner <warner@lothar.com>
3058 * NEWS: update for 0.7.1
3060 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
3061 sure that unsubscribe works even if we never sent an ETA update.
3062 Also, don't explode on duplicate unsubscribe.
3063 (BuildStepStatus.addLog): make the convenience "return self"-added
3064 watcher automatically unsubscribe when the Step finishes.
3065 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
3066 (BuildStatus.stepStarted): same auto-unsubscribe
3067 (BuilderStatus.buildStarted): same auto-unsubscribe
3069 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
3071 (IStatusReceiver.stepStarted): same
3072 (IStatusReceiver.logStarted): same
3074 * buildbot/test/test_run.py (Status): move the Status test..
3075 * buildbot/test/test_status.py (Subscription): .. to here
3077 2005-11-25 Brian Warner <warner@lothar.com>
3079 * NEWS: more updates
3081 * buildbot/locks.py: fix the problem in which loading a master.cfg
3082 file that changes some Builders (but not all of them) can result
3083 in having multiple copies of the same Lock. Now, the real Locks
3084 are kept in a table inside the BotMaster, and the Builders/Steps
3085 use "LockIDs", which are still instances of MasterLock and
3086 SlaveLock. The real Locks are instances of the new RealMasterLock
3087 and RealSlaveLock classes.
3088 * buildbot/master.py (BotMaster.getLockByID): new method to
3089 convert LockIDs into real Locks.
3090 * buildbot/process/base.py (Build.startBuild): convert LockIDs
3091 into real Locks before building
3092 * buildbot/process/step.py (BuildStep.startStep): same
3093 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
3094 exercises the problem
3097 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
3098 what Schedulers are available
3100 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
3101 work by Dobes Vandermeer and hacked mercilessly by me. This offers
3102 'cron'-style build scheduling at certain times of day, week,
3104 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
3106 * buildbot/scheduler.py (Scheduler): change fileIsImportant
3107 handling: treat self.fileIsImportant more as an attribute that
3108 contains a callable than as a method. If the attribute is None,
3109 don't call it and assume all filenames are important. It is still
3110 possible to provide a fileIsImportant method in a subclass,
3112 (AnyBranchScheduler): handle fileIsImportant=None, previously it
3114 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
3115 test using AnyBranchScheduler with fileIsImportant=None
3117 2005-11-24 Brian Warner <warner@lothar.com>
3119 * buildbot/test/test_config.py (StartService): don't claim a fixed
3120 port number, instead set slavePort=0 on the first pass, figure out
3121 what port was allocated, then switch to a config file that uses
3124 * buildbot/master.py (BuildMaster.loadConfig): close the old
3125 slaveport before opening the new one, because unit tests might
3126 replace slavePort=0 with the same allocated portnumber, and if we
3127 don't wait for the old port to close first, we get a "port already
3128 in use" error. There is a tiny race condition here, but the only
3129 threat is from other programs that bind (statically) to the same
3130 port number we happened to be allocated, and only if those
3131 programs use SO_REUSEADDR, and only if they get control in between
3134 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
3136 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
3137 deleted ChangeSources before adding any new ones
3138 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
3139 compare_attrs, to make sure that a config-file reload does not
3140 unnecessarily replace an unmodified ChangeSource instance
3141 * buildbot/test/test_config.py (ConfigTest.testSources): update
3143 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
3144 mean "don't build anything", and add a warning if it gets used
3145 because it isn't actually useful.
3147 * contrib/svn_buildbot.py: update example usage to match the port
3148 number that gets used by the PBChangeSource
3149 * buildbot/scripts/sample.cfg: add example of PBChangeSource
3151 2005-11-22 Brian Warner <warner@lothar.com>
3153 * NEWS: start collecting items for next release
3155 * buildbot/process/step.py (SVN.computeSourceRevision): assume
3156 revisions are strings
3157 (P4Sync.computeSourceRevision): same
3159 * buildbot/status/html.py (StatusResourceBuild.body): add a link
3160 to the Buildbot's overall status page
3161 (StatusResourceBuilder.body): same
3163 2005-11-15 Brian Warner <warner@lothar.com>
3165 * buildbot/master.py (BuildMaster.loadConfig): serialize the
3166 config-file loading, specifically to make sure old StatusTargets
3167 are finished shutting down before new ones start up (thus
3168 resolving a bug in which changing the Waterfall object would fail
3169 because both new and old instances were claiming the same
3170 listening port). Also load new Schedulers after all the new
3171 Builders are set up, in case they fire off a new build right away.
3172 * buildbot/test/test_config.py (StartService): test it
3174 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
3175 the branch name to the mail body
3177 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
3178 Without it, a config-file reload fails to update an existing
3180 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
3181 username/passwd to compare_attrs, for the same reason
3182 * buildbot/status/html.py (Waterfall): add favicon to
3183 compare_attrs, same reason
3185 2005-11-05 Brian Warner <warner@lothar.com>
3187 * buildbot/scripts/tryclient.py (createJobfile): stringify the
3188 baserev before stuffing it in the jobfile. This resolves problems
3189 under SVN (and probably Arch) where revisions are expressed as
3190 numbers. I'm inclined to use string-based revisions everywhere in
3191 the future, but this fix should be safe for now. Thanks to Steven
3192 Walter for the patch.
3194 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
3195 binary mode when opening pickle files, to make windows work
3196 better. Thanks to Dobes Vandermeer for the catch.
3197 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3198 (BuilderStatus.getBuildByNumber): same
3199 (Status.builderAdded): same
3200 * buildbot/master.py (BuildMaster.loadChanges): same
3202 * buildbot/util.py (Swappable): delete unused leftover code
3204 * buildbot/process/step.py (SVN): when building on a non-default
3205 branch, add the word "[branch]" to the VC step's description, so
3206 it is obvious that we're not building the usual stuff. Likewise,
3207 when we are building a specific revision, add the text "rNNN" to
3208 indicate what that revision number is. Thanks to Brad Hards and
3209 Nathaniel Smith for the suggestion.
3210 (Darcs.startVC): same
3211 (Arch.startVC): same
3212 (Bazaar.startVC): same
3214 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3215 typo, caught by Mark Dillavou, closes SF#1216636.
3217 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3218 about a test to add some day
3220 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3221 the 'full-2.3' build, and the 'reactors' build is now run under
3222 python-2.4 because the buildslave no longer has gtk/etc bindings
3223 for earlier versions.
3225 2005-11-03 Brian Warner <warner@lothar.com>
3227 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3228 method, takes an IBuildStatus and rebuilds it. It might make more
3229 sense to add this to IBuildControl instead, but that instance goes
3230 away completely once the build has finished, and resubmitting
3231 builds can take place weeks later.
3232 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3233 * buildbot/status/html.py (StatusResourceBuild): also stash an
3234 IBuilderControl so we can use resubmitBuild.
3235 (StatusResourceBuild.body): render "resubmit" button if we can.
3236 Also add hrefs for each BuildStep
3237 (StatusResourceBuild.rebuild): add action for "resubmit" button
3238 (StatusResourceBuilder.getChild): give it an IBuilderControl
3240 * buildbot/status/builder.py (Status.getURLForThing): change the
3241 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3242 that live as targets of buttons like "stop" and "rebuild" can't
3244 * buildbot/status/builder.py (Status.getURLForThing): same
3245 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3246 (StepBox.getBox): same
3247 * buildbot/test/test_web.py (GetURL): same
3250 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3251 exclusivity checks after Source.__init__ upcall, so misspelled
3252 arguments will be reported more usefully
3253 (Darcs.__init__): same
3255 2005-10-29 Brian Warner <warner@lothar.com>
3257 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3258 builder. Move the Try scheduler off to a separate port.
3260 2005-10-27 Brian Warner <warner@lothar.com>
3262 * buildbot/clients/gtkPanes.py
3263 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3264 to cause the app to crash, now they don't.
3266 * buildbot/clients/debug.py: display the buildmaster's location
3267 in the window's title bar
3269 2005-10-26 Brian Warner <warner@lothar.com>
3271 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3272 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3273 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3275 * buildbot/status/html.py (td): put a single non-breaking space
3276 inside otherwise empty <td> elements, as a workaround for buggy
3277 browsers which would optimize them away (along with any associated
3278 styles, like the kind that create the waterfall grid borders).
3279 Patch from Frerich Raabe.
3281 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3282 argv-list as an argument, defaulting to ["-to"], which is
3283 appropriate for the Trial that comes with Twisted-2.1.0 and
3284 earlier. The Trial in current Twisted SVN wants
3285 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3286 defaults to an empty list.
3287 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3288 match it, now that trialMode= is a list instead of a single string
3290 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3292 * docs/buildbot.texinfo: same
3294 2005-10-24 Brian Warner <warner@lothar.com>
3296 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3297 * docs/buildbot.texinfo: set version number to match
3299 2005-10-24 Brian Warner <warner@lothar.com>
3301 * README: update for 0.7.0
3303 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3305 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3306 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3307 send the branch= argument unless the user really provided one, to
3308 retain compatibility with older buildmasters that don't accept
3310 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3313 * docs/buildbot.texinfo: update lots of stuff
3315 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3316 to the 'buildbot sendchange' command
3317 * buildbot/clients/sendchange.py (Sender.send): same
3318 * buildbot/changes/pb.py (ChangePerspective): same
3319 * buildbot/test/test_changes.py (Sender.testSender): test it
3321 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3322 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3323 for consistency with other BuildStep arguments that use camelCase.
3324 Well, at least more of them use camelCase (like flunkOnWarnings)
3325 than don't.. I wish I'd picked one style and stuck with it
3326 earlier. Annoying, but it's best done before the release, since
3327 these arguments didn't exist at all in 0.6.6 .
3329 * buildbot/test/test_vc.py (SVN.testCheckout): same
3330 (Darcs.testPatch): same
3331 * docs/buildbot.texinfo (SVN): document the change
3332 (Darcs): same, add some build-on-branch docs
3333 * docs/examples/twisted_master.cfg: match change
3335 * buildbot/process/step.py (BuildStep): rename
3336 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3337 how it is normally used.
3338 * buildbot/test/test_steps.py (Version.checkCompare): same
3340 * buildbot/process/step.py (CVS.startVC): refuse to build
3341 update/copy -style builds on a non-default branch with an old
3342 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3343 concern is that it will do a VC 'update' in an existing tree when
3344 it is supposed to be switching branches (and therefore clobbering
3345 the tree to do a full checkout), thus building the wrong source.
3346 This used to be a warning, but I think the confusion it is likely
3347 to cause warrants making it an error.
3348 (SVN.startVC): same, also make mode=export on old slaves an error
3349 (Darcs.startVC): same
3350 (Git.startVC): improve error message for non-Git-enabled slaves
3351 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3352 specific revision is built on a slave that doesn't pay attention
3353 to args['revision'], because for slowly-changing trees it will
3354 probably do the right thing, and because we have no way to tell
3355 whether we're asking it to build the most recent version or not.
3356 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3358 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3359 that 'master' is in host:portnum format, to catch errors sooner
3361 2005-10-23 Brian Warner <warner@lothar.com>
3363 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3364 when creating the list of warning messages, include the line
3365 immediately after each WARNING: line, since that's usually where
3366 the file and line number wind up.
3368 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3373 2005-10-22 Brian Warner <warner@lothar.com>
3375 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3376 patch from Brad Hards
3377 * buildbot/status/classic.css: same
3378 * buildbot/test/test_web.py (Waterfall): match changes
3380 * buildbot/test/test_steps.py (BuildStep.setUp): set
3381 nextBuildNumber so the test passes
3382 * buildbot/test/test_status.py (MyBuilder): same
3384 * buildbot/status/html.py (StatusResourceBuild.body): revision
3385 might be numeric, so stringify it before html-escapifying it
3386 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3387 timer for the upcoming build
3388 * buildbot/status/classic.css: add background-color attributes for
3389 offline/waiting/building classes
3391 * buildbot/status/builder.py (BuildStatus): derive from
3392 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3393 the default (i.e. unknown) .slavename to "???" instead of None,
3394 since even unknown slavenames need to be printed eventually.
3395 (BuilderStatus): also derive from styles.Versioned . More
3396 importantly, determine .nextBuildNumber at creation/unpickling
3397 time by scanning the directory of saved BuildStatus instances and
3398 choosing one larger than the highest-numbered one found. This
3399 should fix the problem where random errors during upgrades cause
3400 the buildbot to forget about earlier builds. .nextBuildNumber is
3401 no longer stored in the pickle.
3402 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3403 at least log the error. Also call Builder.determineNextBuildNumber
3404 once the basedir is set.
3406 * buildbot/master.py (BuildMaster.loadChanges): do
3407 styles.doUpgrade afterwards, in case I decide to make Changes
3408 derived from styles.Versioned some day and forget to make this
3412 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3413 when running under older pythons (<2.3) in which the shlex module
3414 doesn't have a 'split' function.
3416 * buildbot/process/step.py (ShellCommand.start): make
3417 errorMessages= be a list of strings to stuff in the log before the
3418 command actually starts. This makes it easier to flag multiple
3419 warning messages, e.g. when the Source steps have to deal with an
3421 (CVS.startVC): handle slaves that don't handle multiple branches
3422 by switching into 'clobber' mode
3423 (SVN.startVC): same. Also reject branches without base_url
3424 (Darcs.startVC): same. Also reject revision= in older slaves
3425 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3426 (Bazaar.startVC): same, and test for baz separately than for arch
3428 * buildbot/slave/commands.py (cvs_ver): document new features
3430 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3431 (BuildStep.slaveVersionNewEnough): more useful utility method
3432 * buildbot/test/test_steps.py (Version): start testing it
3434 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3435 the 'force' command requires python2.3, for the shlex.split method
3437 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3438 since we don't use it anymore. The Twisted buildbot uses a
3441 2005-10-21 Brian Warner <warner@lothar.com>
3443 * buildbot/process/process_twisted.py: rework all BuildFactory
3444 classes to take a 'source' step as an argument, instead of
3445 building up the SVN instance in the factory.
3446 * docs/examples/twisted_master.cfg: enable build-on-branch by
3447 providing a base_url and default_branch
3449 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3450 control over --branch and --revision, not that they are always
3452 * buildbot/status/html.py (StatusResourceBuilder.force): same
3453 (StatusResourceBuild.body): display SourceStamp components
3455 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3456 IRC 'force' command, so it can be shared with an eventual
3457 command-line-tool 'buildbot force' mode.
3458 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3460 2005-10-20 Brian Warner <warner@lothar.com>
3462 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3464 * docs/examples/twisted_master.cfg: update to use Schedulers
3466 * buildbot/scripts/sample.cfg: update with Schedulers
3468 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3469 method specifically for use by HTML "force build" button and the
3470 IRC "force" command. Raises an immediate error if there are no
3472 (IBuilderControl.requestBuild): make this just submit a build, not
3473 try to check for existing slaves or set up any when-finished
3474 Deferreds or anything.
3475 * buildbot/process/builder.py (BuilderControl): same
3476 * buildbot/status/html.py (StatusResourceBuilder.force): same
3477 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3478 * buildbot/test/test_slaves.py: same
3479 * buildbot/test/test_web.py: same
3481 2005-10-19 Brian Warner <warner@lothar.com>
3483 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3484 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3486 2005-10-18 Brian Warner <warner@lothar.com>
3488 * buildbot/status/html.py: provide 'status' argument to most
3489 StatusResourceFOO objects
3490 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3491 and Logfiles" section to make the Build page into a more-or-less
3492 comprehensive source of status information about the build
3494 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3495 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3497 2005-10-17 Brian Warner <warner@lothar.com>
3499 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3500 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3501 out what to do about other projects: the correct options for
3502 recent Twisteds will not work for older ones.
3504 2005-10-15 Brian Warner <warner@lothar.com>
3506 * buildbot/status/builder.py (Status.getURLForThing): add method
3507 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3508 use this in email/IRC status clients to make them more useful, by
3509 providing the end user with hints on where to learn more about the
3510 object being reported on.
3511 * buildbot/test/test_web.py (GetURL): tests for it
3513 2005-10-14 Brian Warner <warner@lothar.com>
3515 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3516 fix bug resulting from deferredResult changes
3518 2005-10-13 Brian Warner <warner@lothar.com>
3520 * buildbot/test/test_changes.py: remove use of deferredResult
3521 * buildbot/test/test_config.py: same
3522 * buildbot/test/test_control.py: same
3523 * buildbot/test/test_status.py: same
3524 * buildbot/test/test_vc.py: this is the only remaining use, since
3525 it gets used at module level. This needs to be replaced by some
3526 sort of class-level run-once routine.
3528 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3530 * lots: implement multiple slaves per Builder, which means multiple
3531 current builds per Builder. Some highlights:
3532 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3533 of (state,currentBuilds) instead of (state,currentBuild)
3534 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3535 (IBuildStatus.getSlavename): new method, so you can tell which
3536 slave got used. This only gets set when the build completes.
3537 (IBuildRequestStatus.getBuilds): new method
3539 * buildbot/process/builder.py (SlaveBuilder): add a .state
3540 attribute to track things like ATTACHING and IDLE and BUILDING,
3542 (Builder): .. the .slaves attribute here, which has been turned
3543 into a simple list of available slaves. Added a separate
3544 attaching_slaves list to track ones that are not yet ready for
3546 (Builder.fireTestEvent): put off the test-event callback for a
3547 reactor turn, to make tests a bit more consistent.
3548 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3549 ping fails due to an exception. This needs work, I'm worried that
3550 a code error could lead to a constantly re-connecting slave.
3551 Especially since I'm trying to move to a distinct remote_ping
3552 method, separate from the remote_print that we currently use.
3553 (BuilderControl.requestBuild): return a convenience Deferred that
3554 provides an IBuildStatus when the build finishes.
3555 (BuilderControl.ping): ping all connected slaves, only return True
3556 if they all respond.
3558 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3559 reconnect when we shut down.
3561 * buildbot/status/builder.py: implement new methods, convert
3562 one-build-at-a-time methods to handle multiple builds
3563 * buildbot/status/*.py: do the same in all default status targets
3564 * buildbot/status/html.py: report the build's slavename in the
3565 per-Build page, report all buildslaves on the per-Builder page
3567 * buildbot/test/test_run.py: update/create tests
3568 * buildbot/test/test_slaves.py: same
3569 * buildbot/test/test_scheduler.py: remove stale test
3571 * docs/buildbot.texinfo: document the new builder-specification
3572 'slavenames' parameter
3574 2005-10-12 Brian Warner <warner@lothar.com>
3576 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3577 report failure correctly, causing Dependent builds to run when
3578 they shouldn't have.
3579 * buildbot/status/builder.py (BuildSetStatus): same
3580 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3581 (Set.testSuccess): test the both-pass case too
3582 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3583 fix this test: it was ending too early, masking the failure before
3584 (Logger): specialized StatusReceiver to make sure the dependent
3585 builds aren't even started, much less completed.
3587 2005-10-07 Brian Warner <warner@lothar.com>
3589 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3590 bot.SlaveBuilder being disowned in the middle of a build
3592 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3593 this inherit from StatusReceiver. Also upcall in __init__. This
3594 fixes the embarrasing crash when the new buildSetSubmitted method
3595 is invoked and Waterfall/etc don't implement their own.
3596 * buildbot/test/test_run.py: add a TODO note about a test to catch
3597 just this sort of thing.
3599 * buildbot/process/builder.py (Builder.attached): remove the
3600 already-attached warning, this situation is normal. Add some
3601 comments explaining it.
3603 2005-10-02 Brian Warner <warner@lothar.com>
3605 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3606 OverflowError when setting up dnotify, because some 64-bit systems
3607 have problems with signed-vs-unsigned constants and trip up on the
3608 DN_MULTISHOT flag. Patch from Brad Hards.
3610 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3612 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3613 progressMetrics, description, descriptionDone to the 'parms' list,
3614 and make use the 'parms' list from the implementation class
3615 instead of only BuildStep to initialize the parameters. This
3616 allows buildbot.process.factory.s() to initialize all the parms,
3617 not just those defined in directly by BuildStep.
3619 2005-09-03 Brian Warner <warner@lothar.com>
3621 * NEWS: start adding items for the next release
3623 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3624 python2.2 tests, change 'Quick' builder to only use python2.3
3626 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3628 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3629 the "Ping Builder" button if the build control is available; the
3630 user sees an exception otherwise
3632 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3634 2005-09-01 Brian Warner <warner@lothar.com>
3636 * buildbot/interfaces.py (IBuilderStatus.getState): update
3637 signature, point out that 'build' can be None
3638 (IBuildStatus.getETA): point out ETA can be none
3640 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3642 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3644 2005-08-31 Brian Warner <warner@lothar.com>
3646 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3647 update to match correct signature: removed 'eta' argument
3648 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3650 2005-08-30 Brian Warner <warner@lothar.com>
3652 * buildbot/status/builder.py (LogFile): remove the assertion that
3653 blows up when you try to overwrite an existing logfile, instead
3654 just emit a warning. This case gets hit when the buildmaster is
3655 killed and doesn't get a chance to write out the serialized
3656 BuilderStatus object, so the .nextBuildNumber attribute gets out
3659 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3660 the 'buildbot sendchange' arguments, for the Darcs context file
3661 * docs/buildbot.texinfo (sendchange): document it
3663 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3664 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3665 (IStatus.getSchedulers): new method
3666 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3667 (Status.getSchedulers): implement
3668 * buildbot/process/builder.py (Builder): maintain
3669 BuilderStatus.pendingBuilds
3670 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3671 (TryBase.addChange): Try schedulers should ignore Changes
3673 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3674 for 'try' on CVS/SVN
3675 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3677 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3678 report status properly.
3679 (Try.createJob): implement unique buildset IDs
3681 * buildbot/status/client.py (StatusClientPerspective): add a
3682 perspective_getBuildSets method for the benefit of jobdir-style
3684 * docs/buildbot.texinfo (try): more docs
3685 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3688 2005-08-18 Brian Warner <warner@lothar.com>
3690 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3691 actually work. It's functional but still kind of clunky. Also, it
3692 only works with the pb-style.. needs to be made to work with the
3695 * buildbot/status/client.py (RemoteBuildSet): new class
3696 (RemoteBuildRequest): same
3697 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3698 object, not the internal BuildStatus object.
3699 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3700 outside of the usual buildStarted() return value.
3701 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3703 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3704 (Try_Userpass_Perspective.perspective_try): return a remotely
3705 usable BuildSetStatus object
3707 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3708 isStarted()/waitUntilStarted()
3710 2005-08-16 Brian Warner <warner@lothar.com>
3712 * buildbot/status/builder.py: implement IBuildSetStatus and
3713 IBuildRequestStatus, wire them into place.
3714 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3715 methods into the BuildSetStatus object.
3716 * buildbot/interfaces.py: same
3717 (IStatus.getBuildSets): new method to get pending BuildSets
3718 (IStatusReceiver.buildsetSubmitted): new method which hears about
3720 * buildbot/master.py (BuildMaster.submitBuildSet): same
3721 * buildbot/process/base.py (BuildRequest): same, replace
3722 waitUntilStarted with subscribe/unsubscribe
3723 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3724 subscribe instead of waitUntilStarted
3725 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3727 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3729 * buildbot/test/test_buildreq.py: update for new code
3730 * buildbot/test/test_control.py (Force.testRequest): same
3733 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3734 for Darcs to not use the tempfile module, so it works under
3735 python-2.2 too. We really didn't need the full cleverness of that
3736 module, since the slave has exclusive control of its own builddir.
3738 2005-08-15 Brian Warner <warner@lothar.com>
3740 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3741 for CVS trees. It doesn't work for non-trunk branches,
3743 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3746 * Makefile: make it easier to test against python2.2
3748 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3749 tearDown2, so things like Arch can unregister archives as they're
3750 shutting down. The previous subclass-override-tearDown technique
3751 resulted in a nested maybeWait() and test failures under
3754 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3755 where we can (Arch), add a branch= argument to set the branch used
3757 (BazExtractor): extract the branch too
3758 (TlaExtractor): same
3759 * buildbot/scripts/runner.py (TryOptions): add --branch
3760 * docs/buildbot.texinfo (try): document --branch/try_branch
3762 * buildbot/slave/commands.py (Darcs): implement get-revision for
3763 Darcs, so that 'try' will work. This requires the tempfile module
3766 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3767 of revisions, branches, and 'try' in the process.
3769 2005-08-11 Brian Warner <warner@lothar.com>
3771 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3772 this, it got broken at some point in the last few releases
3773 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3774 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3775 specifically the removal of ETA information from the tuple
3777 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3780 * docs/buildbot.texinfo (try): document both --builder and
3781 'try_builders' in .buildbot/options
3782 * buildbot/scripts/runner.py (TryOptions): add --builder,
3783 accumulate the values into opts['builders']
3784 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3785 * buildbot/test/test_runner.py (Try): add some quick tests to make
3786 sure 'buildbot try --options' and .buildbot/options get parsed
3787 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3788 use --builder control
3790 * docs/buildbot.texinfo (try): add --port argument to PB style
3792 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3793 actual SourceStamp. Still need to extract a branch name, somehow.
3794 (Try): finish implementing the try client side, still need a UI
3795 for specifying which builders to use
3796 (Try.getopt): factor our options/config-file reading
3797 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3799 * buildbot/test/test_vc.py: match SourceStampExtractor change
3801 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3802 causes the twisted log to be sent to stderr
3804 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3806 2005-08-10 Brian Warner <warner@lothar.com>
3808 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3809 style is 90% done, still missing status reporting or waiting for
3810 the buildsets to finish, and it is completely untested.
3812 * buildbot/trybuild.py: delete file, move contents to ..
3813 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3814 * buildbot/test/test_vc.py: match the move
3816 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3817 of the TryScheduler, no buildsetID or status-tracking support yet
3818 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3820 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3821 possible to set the basedir after __init__ time, so it is easier
3822 to use as a Service-child of the BuildMaster instance
3824 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3825 that delivers messages to its Service parent instead of requiring
3826 a subclass to be useful. This turns out to be much easier to build
3829 * buildbot/scripts/tryclient.py (createJob): utility code to
3830 create jobfiles, will eventually be used by 'buildbot try'
3832 2005-08-08 Brian Warner <warner@lothar.com>
3834 * docs/buildbot.texinfo (try): add docs on the
3835 as-yet-unimplemented Try scheduler
3837 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3838 * buildbot/test/test_scheduler.py: .. here
3839 (Scheduling.testTryJobdir): add placeholder test for 'try'
3841 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3842 addEntry merging (>=chunkSize) behavior
3843 (Log.testConsumer): update to handle new callLater(0) behavior
3845 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3846 both the MAX_LENGTH bugfix and the resumeProducing hang.
3848 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3849 put off the actual resumeProducing for a moment with
3850 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3851 causes large logfiles to hang midway through.
3853 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3854 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3855 and to improve memory usage when streaming the file out to a web
3857 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3858 make this work cleanly
3860 2005-08-03 Brian Warner <warner@lothar.com>
3862 * buildbot/trybuild.py: new file for 'try' utilities
3863 (getSourceStamp): run in a tree, find out the baserev+patch
3864 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3865 implemented for SVN and Darcs, still working on Arch. I don't know
3866 how to make CVS work yet.
3868 * docs/buildbot.texinfo: document the 'buildbot' command-line
3869 tool, including the not-yet-implemented 'try' feature, and the
3870 in-flux .buildbot/ options directory.
3872 2005-07-20 Brian Warner <warner@lothar.com>
3874 * buildbot/locks.py: added temporary id() numbers to Lock
3875 descriptions, to track down a not-really-sharing-the-Lock bug
3877 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3879 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3880 needed for python2.2 compatibility
3881 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3882 are from the __future__
3884 2005-07-19 Brian Warner <warner@lothar.com>
3886 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3887 message when schedulers use unknown builders
3889 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3890 SlaveLock('name') and MasterLock('name') are distinct
3892 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3893 c['schedulers'] in such a way that we can actually accept
3895 * buildbot/test/test_config.py: check it
3897 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3898 utility method to *all* the Schedulers
3899 (Periodic.listBuilderNames): same
3901 * docs/buildbot.texinfo (Interlocks): update chapter to match
3904 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3905 to make sure that c['sources'], c['schedulers'], and c['status']
3906 are all lists of the appropriate objects, and that the Schedulers
3907 all point to real Builders
3908 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3909 'listBuilderNames' utility method to support this
3910 * buildbot/scheduler.py: implement the utility method
3911 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3913 * docs/buildbot.texinfo: add some @cindex entries
3915 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3916 if it wasn't already set: most tla commands will fail unless one
3918 (Arch.createRepository): and disable bazaar's revision cache, since
3919 they cause test failures (the multiple repositories we create all
3920 interfere with each other through the cache)
3922 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3923 bring it properly up to date with twisted-2.0 test guidelines
3925 * buildbot/master.py (BuildMaster): remove references to old
3926 'interlock' module, this caused a bunch of post-merge test
3928 * buildbot/test/test_config.py: same
3929 * buildbot/process/base.py (Build): same
3931 * buildbot/test/test_slaves.py: stubs for new test case
3933 * buildbot/scheduler.py: add test-case-name tag
3934 * buildbot/test/test_buildreq.py: same
3936 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3937 unnecessary init code
3938 (Bot.remote_setBuilderList): match it
3940 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3942 * buildbot/changes/mail.py (parseSyncmail): update comment
3944 * buildbot/test/test_slavecommand.py: disable Shell tests on
3945 platforms that don't suport IReactorProcess
3947 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3948 all places where we open logfiles. It causes OS-X to open the file
3949 in some weird mode that that prevents us from mixing reads and
3950 writes to the same filehandle, which we depend upon to implement
3951 _generateChunks properly. This change doesn't appear to break
3952 win32, on which "b" and "t" are treated differently but a missing
3953 flag seems to be interpreted as "t".
3955 2005-07-18 Brian Warner <warner@lothar.com>
3957 * buildbot/slave/commands.py (ShellCommand): overhaul
3958 error-handling code, to try and make timeout/interrupt work
3959 properly, and make win32 happier
3960 * buildbot/test/test_slavecommand.py: clean up, stop using
3961 reactor.iterate, add tests for timeout and interrupt
3962 * buildbot/test/sleep.py: utility for a new timeout test
3964 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3965 code from the local-usebranches branch
3967 2005-07-17 Brian Warner <warner@lothar.com>
3969 * buildbot/process/process_twisted.py
3970 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3971 minutes, to match the other twisted BuildFactories, and don't
3972 excuse failures in c/qt/win32 reactors any more.
3974 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3975 'freebsd' builders, since the buildslaves have been unavailable
3978 2005-07-13 Brian Warner <warner@lothar.com>
3980 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3981 build-on-branch feature
3983 * buildbot/process/step.py (Darcs.__init__): add base_url and
3984 default_branch arguments, just like SVN
3985 (Arch.__init__): note that the version= argument is really the
3988 * buildbot/slave/commands.py (SourceBase): keep track of the
3989 repository+branch that was used for the last checkout in
3990 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3991 match, we clobber the directory and perform a fresh checkout
3992 rather than trying to do an in-place update. This should protect
3993 us against trying to get to branch B by doing an update in a tree
3994 obtained from branch A.
3995 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3996 (SVN.setup): same, just the svnurl
3997 (Darcs.setup): same, just the repourl
3998 (Arch.setup): same, arch coordinates (url), version, and
3999 buildconfig. Also pull the buildconfig from the args dictionary,
4000 which we weren't doing before, so the build-config was effectively
4002 (Arch.sourcedirIsUpdateable): don't try to update when we're
4003 moving to a specific revision: arch can't go backwards, so it is
4004 safer to just clobber the tree and checkout a new one at the
4006 (Bazaar.setup): same sourcedata as Arch
4008 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
4009 use maybeWait, to work with twisted-1.3.0 and twcompat
4010 (Dependencies.testRun_Pass): same
4012 * buildbot/test/test_vc.py: rearrange, cleanup
4014 * buildbot/twcompat.py: add defer.waitForDeferred and
4015 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
4016 can work under twisted-1.3.0 .
4018 * buildbot/test/test_vc.py: rewrite. The sample repositories are
4019 now created at setUp time. This increases the runtime of the test
4020 suite considerably (from 91 seconds to 151), but it removes the
4021 need for an offline tarball, which should solve a problem I've
4022 seen where the test host has a different version of svn than the
4023 tarball build host. The new code also validates that mode=update
4024 really picks up recent commits. This approach will also make it
4025 easier to test out branches, because the code which creates the VC
4026 branches is next to the code which uses them. It will also make it
4027 possible to test some change-notification hooks, by actually
4028 performing a VC commit and watching to see the ChangeSource get
4031 2005-07-12 Brian Warner <warner@lothar.com>
4033 * docs/buildbot.texinfo (SVN): add branches example
4034 * docs/Makefile (buildbot.ps): add target for postscript manual
4036 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
4037 * buildbot/test/test_locks.py: same
4039 * buildbot/process/step.py (Darcs): comment about default branches
4041 * buildbot/master.py (BuildMaster.loadConfig): don't look for
4042 c['interlocks'] in the config file, complain if it is present.
4043 Scan all locks in c['builders'] to make sure the Locks they use
4045 * buildbot/test/test_config.py: remove old c['interlocks'] test,
4046 add some tests to check for non-uniquely-named Locks
4047 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
4048 since the unique-Lock validation code requires it now
4050 * buildbot/locks.py: fix test-case-name
4052 * buildbot/interlock.py: remove old file
4054 2005-07-11 Brian Warner <warner@lothar.com>
4056 * buildbot/test/test_interlock.py: rename to..
4057 * buildbot/test/test_locks.py: .. something shorter
4059 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
4060 versions (after 2.0.1) changed internet.TCPClient to shut down the
4061 connection in stopService. Change the code to handle this
4064 * buildbot/process/base.py (Build): handle whole-Build locks
4065 * buildbot/process/builder.py (Builder.compareToSetup): same
4066 * buildbot/test/test_interlock.py: make tests work
4068 * buildbot/process/step.py (BuildStep.startStep): complain if a
4069 Step tries to claim a lock that's owned by its own Build
4070 (BuildStep.releaseLocks): typo
4072 * buildbot/locks.py (MasterLock): use ComparableMixin so config
4073 file reloads don't replace unchanged Builders
4075 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
4076 rewrite to cover new Locks instead of old c['interlocks']
4077 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
4081 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
4082 start the master and connect the buildslave
4084 * buildbot/process/step.py (FailingDummy.done): finish with a
4085 FAILURE status rather than raising an exception
4087 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
4088 stringify a BuildRequest.reason that is None
4090 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
4092 * buildbot/status/builder.py (BuildSetStatus): implement enough to
4093 allow scheduler.Dependent to work
4094 * buildbot/buildset.py (BuildSet): set .reason and .results
4096 * buildbot/test/test_interlock.py (Locks.setUp): connect both
4097 slaves, to make the test stop hanging. It still fails, of course,
4098 because I haven't even started to implement Locks.
4100 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
4102 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
4103 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
4104 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
4105 (Dependent): new class for downstream build dependencies
4106 * buildbot/test/test_dependencies.py: tests (still failing)
4108 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
4110 2005-07-07 Brian Warner <warner@lothar.com>
4112 * buildbot/test/runutils.py (RunMixin): factored this class out..
4113 * buildbot/test/test_run.py: .. from here
4114 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
4115 added new buildbot.locks tests (which all hang right now)
4116 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
4117 * buildbot/process/step.py: claim/release per-BuildStep locks
4119 * docs/Makefile: add 'buildbot.html' target
4121 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
4122 interpreted as "HEAD", so that all VC steps can accept branch=None
4123 and have it mean the "default branch".
4125 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
4127 2005-07-07 Brian Warner <warner@lothar.com>
4129 * docs/examples/twisted_master.cfg: update to match current usage
4131 * docs/buildbot.texinfo (System Architecture): comment out the
4132 image, it doesn't exist yet and just screws up the HTML manual.
4134 2005-07-05 Brian Warner <warner@lothar.com>
4136 * debian/.cvsignore: oops, missed one. Removing leftover file.
4138 2005-06-17 Brian Warner <warner@lothar.com>
4140 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
4141 changed its output in 1.2.0, don't mistakenly think that the
4142 subversion we find isn't capable of supporting our tests.
4144 * debian/*: remove the debian/ directory and its contents, to make
4145 life easier for the proper Debian maintainer
4147 * Makefile (release): same
4149 2005-06-07 Brian Warner <warner@lothar.com>
4151 * everything: create a distinct SourceStamp class to replace the
4152 ungainly 4-tuple, let it handle merging instead of BuildRequest.
4153 Changed the signature of Source.startVC to include the revision
4154 information (instead of passing it through self.args). Implement
4155 branches for SVN (now only Darcs/Git is missing support). Add more
4158 2005-06-06 Brian Warner <warner@lothar.com>
4160 * everything: rearrange build scheduling. Create a new Scheduler
4161 object (configured in c['schedulers'], which submit BuildSets to a
4162 set of Builders. Builders can now use multiple slaves. Builds can
4163 be run on alternate branches, either requested manually or driven
4164 by changes. This changed some of the Status classes. Interlocks
4165 are out of service until they've been properly split into Locks
4166 and Dependencies. treeStableTimer, isFileImportant, and
4167 periodicBuild have all been moved from the Builder to the
4169 (BuilderStatus.currentBigState): removed the 'waiting' and
4170 'interlocked' states, removed the 'ETA' argument.
4172 2005-05-24 Brian Warner <warner@lothar.com>
4174 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
4175 erroneously abandons the connection (in clientConnectionFailed)
4176 for non-UserErrors, which means that if we lose the connection due
4177 to a network problem or a timeout, we'll never try to reconnect.
4178 Fix this by not upcalling to the buggy parent method. Note:
4179 twisted-2.0 fixes this, but the function only has 3 lines so it
4180 makes more sense to copy it than to try and detect the buggyness
4181 of the parent class. Fixes SF#1207588.
4183 * buildbot/changes/changes.py (Change.branch): doh! Add a
4184 class-level attribute to accomodate old Change instances that were
4185 pickled before 0.6.5 (where .branch was added for new Changes).
4186 This fixes the exception that occurs when you try to look at an
4187 old Change (through asHTML).
4189 * buildbot/__init__.py (version): bump to 0.6.6+ while between
4192 2005-05-23 Brian Warner <warner@lothar.com>
4194 * buildbot/__init__.py (version): release 0.6.6
4196 2005-05-23 Brian Warner <warner@lothar.com>
4198 * NEWS: update for 0.6.6 release
4199 * debian/changelog: same
4201 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4202 before starting: this was done by twistd back when we spawned it,
4203 now that we're importing the pieces and running them in the
4204 current process, we have to do it ourselves. This allows
4205 master.cfg to import files from the same directory without
4206 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4207 Stichele for the catch.
4208 (Options.opt_version): Add a --version command (actually, just make
4209 the existing --version command emit Buildbot's version too)
4211 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4212 fix to make this behave like other LogFiles, this time to handle
4213 existing LogFiles on disk. (add the missing .upgrade method)
4214 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4216 2005-05-21 Brian Warner <warner@lothar.com>
4218 * buildbot/test/test_runner.py (Create.testMaster): match the
4219 rawstring change in runner.py:masterTAC
4221 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4222 TwistedWords is installed
4223 * buildbot/test/test_status.py: same, with TwistedMail
4225 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4226 some old, deprecated, and removed config keys). This should enable
4227 you to use the base buildbot functionality with Twisted-2.0.0 when
4228 you don't also have TwistedWeb and TwistedWords installed
4230 2005-05-20 Brian Warner <warner@lothar.com>
4232 * buildbot/scripts/runner.py (run): call sendchange(), not
4233 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4234 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4235 (stop): don't wait for process to die when sending SIGHUP
4236 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4237 directory name gets interpreted, which you don't want
4240 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4243 2005-05-18 Brian Warner <warner@lothar.com>
4245 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4247 2005-05-18 Brian Warner <warner@lothar.com>
4249 * README: update for 0.6.5
4250 * debian/changelog: same
4252 * buildbot/changes/changes.py: rename tag= to branch=, since
4253 that's how we're using it, and my design for the upcoming "build a
4254 specific branch" feature wants it. also, tag= was too CVS-centric
4255 * buildbot/changes/mail.py (parseSyncmail): same
4256 * buildbot/process/base.py (Build.isBranchImportant): same
4257 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4258 * docs/buildbot.texinfo (Attributes of Changes): same
4260 * NEWS: update tag=, update for upcoming release
4262 2005-05-17 Brian Warner <warner@lothar.com>
4264 * buildbot/scripts/runner.py (stop): actually poll once per
4265 second, instead of re-killing the poor daemon once per second.
4266 Sleep briefly (0.1s) before the first poll, since there's a good
4267 chance we can avoid waiting the full second if the daemon shuts
4268 down quickly. Also remove the sys.exit() at the end.
4269 (start): remove the unneighborly sys.exit()
4271 * Makefile: improve permission-setting to not kick Arch so badly
4273 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4274 default --keepalive=600, since it doesn't hurt very much, and it's
4275 a hassle to discover that you need it.
4276 * buildbot/test/test_runner.py (Create.testSlave): test it
4278 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4279 IRC bot about EXCEPTION
4281 * buildbot/status/client.py (PBListener): upcall more correctly
4283 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4284 an exception mark the overall build with EXCEPTION, not SUCCESS
4286 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4288 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4289 * Makefile: update some release-related stuff
4291 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4292 gets called when there isn't actually an active process, just end
4293 the Command instead of blowing up. I don't know how it gets into
4294 this state, but the twisted win32 buildslave will sometimes hang,
4295 and when it shakes its head and comes back, it thinks it's still
4296 running a Command. The next build causes this command to be
4297 interrupted, but the lack of self.process.pid breaks the interrupt
4300 * NEWS: document changes since the last release
4302 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4303 look for Makefile.buildbot instead of a bare Makefile . The
4304 'buildbot start' does not install this file, so you have to
4305 manually copy it if you want to customize startup behavior.
4306 (createMaster): change 'buildbot master' command to create
4307 Makefile.sample instead of Makefile, to create master.cfg.sample
4308 instead of master.cfg (requiring you to copy it before the
4309 buildmaster can be started). Both sample files are kept up to
4310 date, i.e. they are overwritten if they have been changed. The
4311 'buildbot.tac' file is *not* overwritten, but if the new contents
4312 don't match the old, a 'buildbot.tac.new' file is created and the
4313 user is warned. This seems to be a much more sane way to handle
4314 startup files. Also, don't sys.exit(0) when done, so we can run
4315 unit tests against it.
4316 (createSlave): same. Don't overwrite the sample info/ files.
4317 * buildbot/scripts/sample.mk: remove. the contents were pulled
4318 into runner.py, since they need to match the behavior of start()
4322 * docs/buildbot.texinfo (Launching the daemons): document it
4323 * buildbot/test/test_runner.py (Create): test it
4325 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4326 version that can handle string-in-string tests, because otherwise
4327 python-2.2 fails the tests. It'd be tremendous if Trial's test
4328 took two strings under 2.2 too.
4330 * everything: fixed all deprecation warnings when running against
4331 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4332 few that come from Twisted itself). This involved putting most of
4333 the Twisted-version specific code in the new buildbot.twcompat
4334 module, and creating some abstract base classes in
4335 buildbot.changes.base and buildbot.status.base (which might be
4336 useful anyway). __implements__ is a nuisance and requires an ugly
4337 'if' clause everywhere.
4339 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4340 delay before finishing the test: it seems that smtp.sendmail
4341 doesn't hang up on the server, so we must wait a moment so it can
4342 hang up on us. This removes the trial warning about an unclean
4345 2005-05-16 Brian Warner <warner@lothar.com>
4347 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4348 tuple of (delay, repeats).
4349 * buildbot/test/test_vc.py (Retry): test it
4350 * docs/buildbot.texinfo (Source Checkout): document it
4351 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4352 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4353 doVCFull() are handled by re-trying the checkout (after a delay)
4354 some number of times.
4355 (ShellCommand._startCommand): make header lines easier to read
4357 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4359 (WebTest.test_logfile): make sure master gets shut down, silences
4360 some "unclean reactor" test errors
4362 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4363 reactor once after shutdown, something in certain versions of
4364 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4365 fails, svn-trunk is ok.
4367 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4368 second win32 error message
4370 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4371 validating the ETA, so the tests don't fail on slow systems
4373 2005-05-15 Brian Warner <warner@lothar.com>
4375 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4376 the new LogFile class, so upgrading works properly
4377 (LogFileProducer.resumeProducing): survive resumeProducing after
4378 we've exhausted the chunkGenerator
4380 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4382 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4383 (Log.testUpgrade): same
4385 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4386 Builds and logs with a cron job.
4388 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4389 of the old non-offline LogFile, added code to upgrade these to
4390 new-style contents-live-on-disk instances at load time (in a way
4391 that doesn't invalidate the old Build pickles, so upgrading to
4392 0.6.5 is not a one-way operation). Got rid of everything related
4394 (LogFile.__init__): create LogFiles with the parent step status,
4395 the log's name, and a builder-relative filename where it can keep
4396 the contents on disk.
4397 (LogFile.hasContents): new method, clients are advised to call it
4398 before getText or getChunks and friends. If it returns False, the
4399 log's contents have been deleted and getText() will raise an
4401 (LogFile.getChunks): made it a generator
4402 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4403 Consumer (except one that takes chunks instead of strings). This
4404 enables streaming of very large logfiles without storing the whole
4406 (BuildStatus.generateLogfileName): create names like
4407 12-log-compile-output, with a _0 suffix if required to be unique
4408 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4409 or earlier) logfiles into new-style ones
4410 (BuilderStatus): remove everything related to 'stub' builds. There
4411 is now only one build cache, and we don't strip logs from old
4413 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4414 since we no longer fight to keep it in the cache
4416 * buildbot/status/html.py (TextLog.render_GET): use a
4417 ChunkConsumer to stream the log entries efficiently.
4418 (ChunkConsumer): wrapper which consumes chunks and writes
4421 * buildbot/test/test_twisted.py (Parse.testParse): use a
4422 LogFile-like object instead of a real one
4424 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4425 (Log.testMerge3): validate more merge behavior
4426 (Log.testChunks): validate LogFile.getChunks
4427 (Log.testUpgrade): validate old-style LogFile upgrading
4428 (Log.testSubscribe): validate LogFile.subscribe
4429 (Log.testConsumer): validate LogFile.subscribeConsumer
4431 * buildbot/interfaces.py (IStatusLogStub): remove
4432 (IStatusLog.subscribeConsumer): new method
4433 (IStatusLog.hasContents): new method
4434 (IStatusLogConsumer): describes things passed to subscribeConsumer
4436 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4437 the log contents if it does not have any contents.
4438 (StatusResourceBuildStep.body): same
4439 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4441 2005-05-14 Brian Warner <warner@lothar.com>
4443 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4444 timeouts to try and make the windows metabuildslave not hang
4446 2005-05-13 Mike Taylor <bear@code-bear.com>
4448 * buildbot/slave/commands.py (rmdirRecursive): added a check
4449 to ensure the path passed into rmdirRecursive actually exists.
4450 On win32 a non-existant path would generate an exception.
4452 2005-05-13 Brian Warner <warner@lothar.com>
4454 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4455 shutil.rmtree which behaves correctly on windows in the face of
4456 files that you have to chmod before deleting. Thanks to Bear at
4457 the OSAF for the routine.
4458 (SourceBase.doClobber): use rmdirRecursive
4460 2005-05-12 Brian Warner <warner@lothar.com>
4462 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4463 method generate chunks instead of returning a big list. This
4464 allows the same method to be used for both old LogFile and new
4466 (OfflineLogFile.getText): use the generator
4467 (OfflineLogFile.subscribe): same
4468 * buildbot/status/html.py (TextLog.resumeProducing): same
4469 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4471 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4472 point out that OfflineLogFile does not currently work with
4473 html.Waterfall . Fixing this is high-priority.
4475 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4476 apparently windows defaults to using stdout
4478 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4479 better message on failure so I can figure out the win32 problem
4481 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4482 log messages to include more useful copies of the command being
4483 run, the argv array, and the child command's environment.
4484 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4486 2005-05-11 Brian Warner <warner@lothar.com>
4488 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4490 * Makefile: update the deb-snapshot version
4492 * docs/buildbot.texinfo: move all .xhtml docs into a new
4493 .texinfo-format document, adding a lot of material in the process.
4494 This is starting to look like a real user's manual. Removed all
4495 the Lore-related files: *.xhtml, *.css, template.tpl .
4496 * docs/Makefile: simple makefile to run 'makeinfo'
4497 * buildbot/scripts/sample.cfg: rearrange slightly
4498 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4500 2005-05-10 Brian Warner <warner@lothar.com>
4502 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4503 different name for the internal twistw module, handle it.
4505 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4506 * setup.py: .. and stop trying to install it
4508 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4509 'git'), the new linux kernel VC system (http://kernel.org/git/).
4510 Thanks to Brandon Philips for the patch.
4511 * buildbot/slave/commands.py (Git): same
4513 2005-05-06 Brian Warner <warner@lothar.com>
4515 * buildbot/status/builder.py (OfflineLogFile): replace the default
4516 LogFile with a form that appends its new contents to a disk file
4517 as they arrive. The complete log data is never kept in RAM. This
4518 is the first step towards handling very large (100MB+) logfiles
4519 without choking quite so badly. (The other half is
4520 producer/consumer on the HTML pages).
4521 (BuildStepStatus.addLog): use OfflineLogFile by default
4522 (BuildStatus.getLogfileName): helper code to give the
4523 OfflineLogFile a filename to work with
4525 * buildbot/test/test_status.py (Results.testAddResults): update
4526 tests to handle new asserts
4527 * buildbot/test/test_vc.py (Patch.doPatch): same
4528 * buildbot/test/test_steps.py (BuildStep.setUp): same
4530 2005-05-05 Brian Warner <warner@lothar.com>
4532 * buildbot/scripts/runner.py (start): if there is no Makefile,
4533 launch the app by importing twistd's internals and calling run(),
4534 rather than spawning a new twistd process. This stands a much
4535 better chance of working under windows.
4536 (stop): kill the process with os.kill instead of spawning
4537 /bin/kill, again to reduce the number of external programs which
4538 windows might not have in the PATH. Also wait up to 5 seconds for
4539 the process to go away, allowing things like 'buildbot stop;
4540 buildbot start' to be reliable in the face of slow shutdowns.
4542 * buildbot/master.py (Dispatcher.__getstate__): remove old
4543 .tap-related methods
4544 (BuildMaster.__getstate__): same
4546 * buildbot/slave/bot.py (makeService): same
4547 (Options.longdesc): same
4548 * buildbot/scripts/runner.py: copy over some old mktap option text
4550 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4551 'buildbot master' now creates a buildbot.tac file, so there is no
4552 longer a create-instance/save/reload sequence. mktap is dead, long
4554 * buildbot/scripts/sample.mk: use twistd -y, not -f
4555 * buildbot/test/test_config.py: remove mktap-based test
4556 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4557 * README: don't reference mktap
4559 * docs/source.xhtml: document some of the attributes that Changes
4562 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4564 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4565 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4566 * buildbot/changes/changes.py (Change)
4567 * buildbot/changes/mail.py (parseSyncmail)
4568 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4570 * buildbot/process/base.py (Build.isTagImportant)
4574 2005-05-04 Brian Warner <warner@lothar.com>
4576 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4577 connection after sending the change, so that unit tests don't
4578 complain about sockets being left around
4580 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4581 exception in phase=0 rendering
4582 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4584 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4586 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4587 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4588 and configuring builders with tuples.
4589 * buildbot/test/test_config.py: stop testing compatibility with
4590 deprecated config keys
4591 * buildbot/test/test_run.py: same
4593 2005-05-03 Brian Warner <warner@lothar.com>
4595 * contrib/arch_buildbot.py: survive if there are no logfiles
4596 (username): just use a string, os.getlogin isn't reliable
4598 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4599 so 'buildbot sendchange' actually works. The earlier test only
4600 covered the internal (non-reactor-running) form.
4602 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4603 script to notify the buildmaster about changes
4605 * buildbot/scripts/runner.py (sendchange): new command to send a
4606 change to a buildbot.changes.pb.PBChangeSource receiver.
4607 * buildbot/test/test_changes.py (Sender): test it
4609 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4610 after any reading of the config file, not just when we do it in
4611 startService. This makes some tests a bit cleaner.
4613 * buildbot/changes/pb.py: add some log messages
4615 * buildbot/process/base.py (Build.startBuild): fix a bug that
4616 caused an exception when the build terminated in the very first
4618 (Build.stepDone): let steps return a status of EXCEPTION. This
4619 terminates the build right away, and sets the build's overall
4620 status to EXCEPTION too.
4621 * buildbot/process/step.py (BuildStep.failed): return a status of
4622 EXCEPTION when that is what has happened.
4624 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4625 implement this, allowing Arch-based projects to get precise
4626 checkouts instead of always using the latest code
4627 (Bazaar): create variant of Arch to let folks use baz instead of
4628 tla. Requires a new buildslave too.
4629 * buildbot/slave/commands.py (Arch): add 'revision' argument
4630 (Bazaar): create variant of Arch that uses baz instead of tla.
4631 Remove the code that extracts the archive name from the
4632 register-archive output, since baz doesn't provide it, and require
4633 the user provide both the archive name and its location.
4634 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4636 2005-05-02 Brian Warner <warner@lothar.com>
4638 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4639 thanks to Nick Trout.
4641 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4642 deals better with source Makefile coming from a read-only CVS
4643 checkout. Thanks to Nick Trout for the catch.
4645 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4648 2005-04-28 Brian Warner <warner@lothar.com>
4650 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4652 * debian/changelog: update for 0.6.4
4654 2005-04-28 Brian Warner <warner@lothar.com>
4656 * README.w32: add a checklist of steps for getting buildbot
4658 * MANIFEST.in: include it in the tarball
4662 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4663 broken .tap files from 0.6.3 by getting rid of .services,
4664 .namedServices, and .change_svc at load time.
4666 2005-04-27 Brian Warner <warner@lothar.com>
4668 * NEWS: update in preparation for new release
4670 * buildbot/test/test_config.py (Save.testSave): don't pull in
4671 twisted.scripts.twistd, we don't need it and it isn't for windows
4674 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4675 accomodate win32 which can't do atomic-rename
4677 2005-04-27 Brian Warner <warner@lothar.com>
4679 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4680 timeouts to help the slow metabuildbot not flunk them so much
4681 (Disconnect.testBuild3): same
4682 (Disconnect.testBuild4): same
4683 (Disconnect.testInterrupt): same
4685 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4686 setup, it was completely broken for new buildmasters (those which
4687 did not have a 'change.pck' already saved. Thanks to Paul Warren
4688 for catching this (embarrassing!) bug.
4689 (Dispatcher.__getstate__): don't save our registered avatar
4690 factories, since they'll be re-populated when the config file is
4692 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4693 tests (since the real mktap-generated BuildMaster doesn't save
4695 (BuildMaster.__getstate__): don't save any service children,
4696 they'll all be re-populated when the config file is re-read.
4697 * buildbot/test/test_config.py (Save.testSave): test for this
4699 2005-04-26 Brian Warner <warner@lothar.com>
4701 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4702 rendered with Blender.. looks a bit nicer.
4703 * buildbot/docs/images/icon.blend: add the Blender file for it
4705 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4706 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4707 running under windows. This appears to be the best way to allow
4708 BuildSteps to do something normal like 'trial -v buildbot.test' or
4709 'make foo' and still expect it to work. The idea is to make the
4710 BuildSteps look as much like what a developer would type when
4711 compiling or testing the tree by hand. This approach probably has
4712 problems when there are spaces in the arguments, so if you've got
4713 windows buildslaves, you'll need to pay close attention to your
4716 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4717 timezone to the timestamp column.
4718 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4720 * buildbot/scripts/runner.py (loadOptions): do something sane for
4721 windows, I think. We use %APPDATA%/buildbot instead of
4722 ~/.buildbot, but we still search everywhere from the current
4723 directory up to the root for a .buildbot/ subdir. The "is it under
4724 $HOME" security test was replaced with "is it owned by the current
4725 user", which is only performed under posix.
4726 * buildbot/test/test_runner.py (Options.testFindOptions): update
4727 tests to match. The "is it owned by the current user" check is
4728 untested. The test has been re-enabled for windows.
4730 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4731 any "\n" in the expected output with the platform-specific line
4732 separator. Make this separator "\r\n" on PTYs under unix, they
4733 seem to do that and I don't know why
4735 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4736 windows for now, I don't know what ~/.buildbot/ should mean there.
4738 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4739 win32 compatibility, don't use "/tmp"
4740 (Basedir.testChangeBuilddir): remove more unixisms
4742 2005-04-26 Brian Warner <warner@lothar.com>
4744 * buildbot/test/test_control.py (Force.rmtree): python2.2
4745 compatibility, apparently its shutil.rmtree ignore_errors=
4746 argument is ignored.
4747 * buildbot/test/test_run.py (Run.rmtree): same
4748 (RunMixin.setUp): same
4750 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4753 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4754 'substring in string' operator, must use string.find(substr)!=-1
4755 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4756 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4758 * buildbot/scripts/runner.py (loadOptions): add code to search for
4759 ~/.buildbot/, a directory with things like 'options', containing
4760 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4761 the current directory, your $HOME directory, or anywhere
4762 inbetween, as long as you're somewhere inside your home directory.
4763 (debugclient): look in ~/.buildbot/options for master and passwd
4764 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4765 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4767 * buildbot/status/client.py (makeRemote): new approach to making
4768 IRemote(None) be None, which works under Twisted-2.0
4769 * buildbot/test/test_status.py (Client.testAdaptation): test it
4771 * buildbot/status/builder.py (Status.builderAdded): when loading a
4772 pickled BuilderStatus in from disk, set its name after loading.
4773 The config file might have changed its name (but not its
4774 directory) while it wasn't looking.
4776 * buildbot/process/builder.py (Builder.attached): always return a
4777 Deferred, even if the builder was already attached
4778 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4780 2005-04-25 Brian Warner <warner@lothar.com>
4782 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4783 category-related exception when announcing a build has finished
4785 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4786 reference no-longer-existent changemaster.sources
4787 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4789 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4792 2005-04-25 Brian Warner <warner@lothar.com>
4794 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4796 * debian/changelog: update for 0.6.3
4798 2005-04-25 Brian Warner <warner@lothar.com>
4800 * MANIFEST.in: make sure debug.glade is in the tarball
4802 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4804 * NEWS: update for the imminent 0.6.3 release
4806 * buildbot/status/html.py (HtmlResource.content): make the
4807 stylesheet <link> always point at "buildbot.css".
4808 (StatusResource.getChild): map "buildbot.css" to a static.File
4809 containing whatever css= argument was provided to Waterfall()
4810 (Waterfall): provide the "classic" css as the default.
4811 * docs/waterfall.classic.css: move default CSS from here ..
4812 * buildbot/status/classic.css: .. to here
4814 * MANIFEST.in: make sure classic.css is included in the tarball
4815 * setup.py: and that it is installed too, under buildbot/status/
4817 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4818 the module level, because buildbot.tap files from 0.6.2 don't have
4819 it in their attribute dictionary.
4821 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4822 really exists at startup, might save some confusion somewhere.
4824 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4826 * docs/waterfall.classic.css:
4827 add a stylesheet that's almost the same as the "classic"
4830 * buildbot/status/builder.py:
4831 add EXCEPTION as a result - this is a problem for the bot
4832 maintainer, not a build problem for the changers
4833 * buildbot/process/step.py:
4834 use EXCEPTION instead of FAILURE for exceptions
4835 * buildbot/status/html.py:
4836 add build_get_class to get a class out of a build/buildstep
4837 finish naming the classes
4838 split out sourceNames to changeNames and builderNames so we
4839 can style them separately
4840 * docs/config.xhtml:
4841 finish documenting classes as they are right now
4843 * buildbot/status/html.py:
4844 name the classes as we agreed on IRC
4845 * docs/config.xhtml:
4848 * buildbot/status/html.py:
4849 same for cssclass->class_
4851 * buildbot/status/html.py:
4852 as decided on IRC, use class_ for the "class" attribute to not
4853 conflict with the class keyword, and clean up the messy **{} stuff.
4855 * buildbot/status/mail.py:
4856 put back "builders" argument, and fix docstring, because the
4857 code *ignores* builders listed in this argument
4859 * buildbot/process/builder.py:
4860 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4862 * docs/config.xhtml:
4863 describe the category argument for builders
4865 * buildbot/status/builder.py:
4866 Fix a silly bug due to merging
4868 * buildbot/process/builder.py:
4869 remove category from the process Builder ...
4870 * buildbot/status/builder.py:
4871 ... and add it to BuilderStatus instead.
4872 Set category on unpickled builder statuses, they might not have it.
4873 * buildbot/master.py:
4874 include category when doing builderAdded
4875 * buildbot/status/mail.py:
4876 return None instead of self for builders we are not interested in.
4877 * buildbot/test/test_run.py:
4878 fix a bug due to only doing deferredResult on "dummy" waiting
4879 * buildbot/test/test_status.py:
4880 add checks for the Mail IStatusReceiver returning None or self
4882 * buildbot/status/html.py:
4883 fix testsuite by prefixing page title with BuildBot
4885 * buildbot/status/builder.py:
4886 have .category in builder status ...
4887 * buildbot/process/builder.py:
4888 ... and set it from Builder
4889 * buildbot/status/html.py:
4890 make .css a class variable
4891 * buildbot/test/test_status.py:
4892 write more tests to cover our categories stuff ...
4893 * buildbot/status/mail.py:
4894 ... and fix the bug that this uncovered
4896 * buildbot/changes/mail.py:
4897 * buildbot/changes/pb.py:
4898 * buildbot/master.py:
4899 * buildbot/process/base.py:
4900 * buildbot/process/factory.py:
4901 * buildbot/process/interlock.py:
4902 * buildbot/process/step.py:
4903 * buildbot/process/step_twisted.py:
4904 * buildbot/slave/commands.py:
4905 * buildbot/status/builder.py:
4906 * buildbot/status/client.py:
4907 * buildbot/status/html.py:
4908 * buildbot/status/mail.py:
4909 * buildbot/status/progress.py:
4910 * buildbot/test/test_changes.py:
4911 * buildbot/test/test_config.py:
4912 * buildbot/test/test_control.py:
4913 * buildbot/test/test_interlock.py:
4914 * buildbot/test/test_maildir.py:
4915 * buildbot/test/test_mailparse.py:
4916 * buildbot/test/test_run.py:
4917 * buildbot/test/test_slavecommand.py:
4918 * buildbot/test/test_status.py:
4919 * buildbot/test/test_steps.py:
4920 * buildbot/test/test_twisted.py:
4921 * buildbot/test/test_util.py:
4922 * buildbot/test/test_vc.py:
4923 * buildbot/test/test_web.py:
4925 add test-case-name at the top of a whole set of files
4927 * buildbot/status/builder.py:
4928 keep order of addition when getting builder names
4929 * buildbot/status/words.py:
4930 * buildbot/test/test_run.py:
4931 add test for getBuilderNames
4933 * buildbot/process/base.py:
4934 * buildbot/process/step.py:
4935 * buildbot/status/builder.py:
4936 * buildbot/status/html.py:
4937 make buildbot css-able
4938 replace the color code for purple with purple, don't understand
4939 why it wasn't purple to start with
4941 * buildbot/status/words.py:
4942 ok, so it doesn't look like BuilderStatus.remote is still valid.
4943 Use what waterfall uses instead.
4945 * buildbot/interfaces.py:
4946 * buildbot/status/builder.py:
4947 * buildbot/status/html.py:
4948 * buildbot/status/mail.py:
4949 * buildbot/status/words.py:
4950 * buildbot/test/test_run.py:
4951 use categories everywhere and make it be a list. More sensible
4952 for the future. Also make words actually respect this in
4955 * buildbot/interfaces.py:
4956 add category argument to getBuilderNames
4957 * buildbot/process/builder.py:
4958 * buildbot/status/builder.py:
4959 * buildbot/status/html.py:
4960 * buildbot/status/mail.py:
4961 * buildbot/status/words.py:
4962 * buildbot/test/test_run.py:
4963 move from specifying builders by name to specifying the category
4965 * buildbot/status/html.py:
4966 * buildbot/status/words.py:
4967 add "builders=" to __init__ of status clients so they can
4968 limit themselves to the given list of builders to report on
4970 * buildbot/status/html.py: set the title to the product name
4972 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4974 * buildbot/interfaces.py:
4975 * buildbot/status/builder.py:
4976 more documentation. Hm, not sure if ChangeLog entries make sense
4979 2005-04-23 Brian Warner <warner@lothar.com>
4981 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4983 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4985 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4986 the sub-commands that log buildmaster status to stdout and to a
4987 GUI window, respectively.
4989 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4990 functionality is working again, but all the step-status and ETA
4991 stuff is missing. Commented out a lot of code pending more
4994 * buildbot/status/client.py: make sure that IRemote(None) is None
4996 * buildbot/changes/changes.py: import defer, oops
4997 (ChangeMaster): remove the .sources list, rely upon the fact that
4998 MultiServices can be treated as sequences of their children. This
4999 cleans up the add/remove ChangeSource routines a lot, as we keep
5000 exactly one list of the current sources instead of three.
5002 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
5003 up an empty ChangeMaster at init time.
5004 (BuildMaster.loadChanges): if there are changes to be had from
5005 disk, replace self.change_svc with the new ones. If not, keep
5006 using the empty ChangeMaster set up in __init__.
5007 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
5008 instead of a separate list, makes the code a bit cleaner.
5009 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
5010 (ConfigTest.testSources): same, also wait for loadConfig to finish.
5011 Extend the test to make sure we can get rid of the sources when
5014 2005-04-22 Brian Warner <warner@lothar.com>
5016 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
5017 and info/host files when making the slave directory
5019 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
5020 whendone= argument, just return the Deferred and let the caller do
5021 what they want with it.
5022 (Disconnect.testBuild1): wait for shutdownSlave
5023 (Basedir.testChangeBuilddir): new test to make sure changes to the
5024 builddir actually get propagated to the slave
5026 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
5027 explicit method, rather than passing the builddir in __init__ .
5028 Make sure to update self.basedir too, this was broken before.
5029 (Bot.remote_setBuilderList): use b.setBuilddir for both new
5030 builders and for ones that have just had their builddir changed.
5031 (BotFactory): add a class-level .perspective attribute, so
5032 BuildSlave.waitUntilDisconnected won't get upset when the
5033 connection hasn't yet been established
5034 (BuildSlave.__init__): keep track of the bot.Bot instance, so
5035 tests can reach through it to inspect the SlaveBuilders
5037 * buildbot/process/base.py (Build.buildException): explain the
5038 log.err with a log.msg
5039 * buildbot/process/builder.py (Builder.startBuild): same
5040 (Builder._startBuildFailed): improve error message
5042 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
5043 occurred because we lost the brand-new connection, retry instead
5044 of giving up. If not, it's probably an authorization failure, and
5045 it makes sense to stop trying. Make sure we log.msg the reason
5046 that we're log.err'ing the failure, otherwise test failures are
5047 really hard to figure out.
5049 * buildbot/master.py: change loadConfig() to return a Deferred
5050 that doesn't fire until the change has been fully implemented.
5051 This means any connected slaves have been updated with the new
5052 builddir. This change makes it easier to test the code which
5053 actually implements this builddir-updating.
5054 (BotPerspective.addBuilder): return Deferred
5055 (BotPerspective.removeBuilder): same
5056 (BotPerspective.attached): same
5057 (BotPerspective._attached): same. finish with remote_print before
5058 starting the getSlaveInfo, instead of doing them in parallel
5059 (BotPerspective.list_done): same
5060 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
5061 actually calling slave.disconnect()
5062 (BotMaster.addBuilder): same
5063 (BotMaster.removeBuilder): same
5064 (BuildMaster.loadConfig): same
5065 (BuildMaster.loadConfig_Slaves): same
5066 (BuildMaster.loadConfig_Sources): same
5067 (BuildMaster.loadConfig_Builders): same
5068 (BuildMaster.loadConfig_status): same
5070 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
5071 a Deferred that fires when the source is finally removed
5073 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
5074 the previous tree on win32, where we have to do it synchronously,
5075 make sure we return a Deferred anyway.
5076 (SourceBase.doCopy): same
5078 * buildbot/scripts/runner.py (statusgui): use the text client for
5079 now, while I rewrite the Gtk one
5080 * buildbot/clients/base.py: strip out old code, leaving just the
5081 basic print-message-on-event functionality. I also remove the
5082 ReconnectingPBClientFactory, but it does at least quit when it
5083 loses the connection instead of going silent
5085 2005-04-21 Brian Warner <warner@lothar.com>
5087 * Makefile: minor tweaks
5089 * NEWS: point out deprecation warnings, new features for
5092 * buildbot/master.py (BuildMaster.loadConfig): emit
5093 DeprecationWarnings for Builders defined with tuples. Rearrange
5094 code to facility removal of deprecated configuration keys in the
5097 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
5098 'buildbot' command to put a little Makefile in the target that
5099 helps you re-create the buildbot.tap file, start or stop the
5100 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
5101 all the files 0600, since they contain passwords.
5102 (start): if there is a Makefile, and /usr/bin/make exists, use
5103 'make start' in preference to a raw twistd command. This lets
5104 slave admins put things like PYTHONPATH variables in their
5105 Makefiles and have them still work when the slave is started with
5106 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
5107 be nice to first try the 'make' command and only fall back to
5108 twistd if it fails. TODO: the Makefile's "start" command does not
5109 add the --reactor=win32 argument when running under windows.
5110 (Options.debugclient, Options.statusgui): add sub-commands to launch
5111 the debug client (formerly in contrib/debugclient.py) and the
5112 Gtk status application (currently broken)
5113 * buildbot/clients/debug.py: move from contrib/debugclient.py
5114 * buildbot/clients/debug.glade: same
5116 * buildbot/test/test_trial.py: remove it. This requires some
5117 functionality out of Twisted that isn't there yet, and until then
5118 having it around just confuses things.
5120 * buildbot/test/test_slavecommand.py (Shell): test both with and
5121 without PTYs, and make sure that command output is properly
5122 interleaved in the with-PTY case. I think the without-PTY test
5123 should pass on windows, where we never use PTYs anyway.
5125 2005-04-20 Brian Warner <warner@lothar.com>
5127 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
5129 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
5131 * NEWS: start creating entries for the next release
5133 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
5135 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
5136 (WebTest.test_webPathname): same
5137 (WebTest.test_webPathname_port): same
5138 (WebTest.test_waterfall): use the default favicon rather than
5139 rooting around the filesystem for it. Open the expected-icon file
5140 in binary mode, to make win32 tests happier (thanks to Nick Trout
5142 * buildbot/status/html.py (buildbot_icon): win32 portability
5144 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
5145 win32-compatibility fixes from Nick Trout, the "file not found" message
5146 is different under windows
5147 (FakeSlaveBuilder.__init__): clean up setup a bit
5148 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
5150 2005-04-19 Brian Warner <warner@lothar.com>
5152 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
5153 skip-if-repositories-are-unavailable test to not kill the trial
5154 that comes with Twisted-1.3.0
5156 * setup.py: install buildbot.png icon file when installing code
5158 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
5159 environment used by the command, at least on the child side.
5161 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
5162 this method needs to be added and implemented because it gets
5163 called under heavy load. I don't quite understand the
5164 producer/consumer API enough to write it.
5165 (StatusResource.getChild): add a resource for /favicon.ico
5166 (Waterfall.__init__): add favicon= argument
5167 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5168 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
5169 (WebTest.test_webPathname): same
5170 (WebTest.test_webPathname_port): same
5171 * docs/config.xhtml: mention favicon=
5172 * buildbot/buildbot.png: add a default icon, dorky as it is
5174 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
5176 * buildbot/master.py:
5177 * buildbot/process/base.py:
5178 * buildbot/process/builder.py:
5179 * buildbot/process/interlock.py:
5180 * buildbot/status/builder.py:
5181 * buildbot/status/html.py:
5182 * buildbot/status/mail.py:
5183 * buildbot/status/words.py:
5184 new documentation while digging through the code
5186 2005-04-17 Brian Warner <warner@lothar.com>
5188 * general: try to fix file modes on all .py files: a+r, a-x,
5189 but let buildbot/clients/*.py be +x since they're tools
5191 * docs/epyrun (addMod): when an import fails, say why
5193 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
5195 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5197 * buildbot/process/base.py:
5198 * buildbot/process/builder.py:
5199 * buildbot/status/builder.py:
5200 new documentation while digging through the code
5202 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5204 * buildbot/changes/changes.py:
5205 * buildbot/changes/p4poller.py:
5206 * buildbot/interfaces.py:
5207 * buildbot/process/base.py:
5208 * buildbot/process/builder.py:
5209 * buildbot/process/step.py:
5210 * buildbot/process/step_twisted.py:
5211 * buildbot/slave/bot.py:
5212 * buildbot/slave/commands.py:
5213 * buildbot/status/builder.py:
5214 fix all docstrings to make epydoc happy. In the process of fixing
5215 some, I also moved pieces of docs, and removed some deprecated
5218 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5220 * buildbot/process/builder.py:
5221 * buildbot/process/interlock.py:
5222 * buildbot/process/process_twisted.py:
5223 * buildbot/process/step.py:
5224 BuildProcess -> Build, as it looks like that's what happened
5225 * buildbot/process/base.py:
5226 * buildbot/process/factory.py:
5229 2005-04-17 Brian Warner <warner@lothar.com>
5231 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5232 update compile command to accomodate the Twisted split.. now
5233 instead of './setup.py build_ext -i', you do './setup.py all
5234 build_ext -i', to run build_ext over all sub-projects.
5235 (FullTwistedBuildFactory): same
5236 (TwistedReactorsBuildFactory): same
5238 * buildbot/status/html.py (TextLog.finished): null out self.req
5239 when we're done, otherwise the reference cycle of TextLog to .req
5240 to .notifications to a Deferred to TextLog.stop keeps them from
5241 being collected, and consumes a huge (610MB on pyramid at last
5242 check) amount of memory.
5244 2005-04-11 Brian Warner <warner@lothar.com>
5246 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5247 normalize the VC-repository location.. makes SVN happier with
5248 certain test environments.
5250 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5251 RemoteShellCommand gets its own .env dictionary, so that code in
5252 start() doesn't mutate the original. I think this should fix the
5253 step_twisted.Trial problem where multiple identical components
5254 kept getting added to PYTHONPATH= over and over again.
5256 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5257 adding epydoc-format docstrings to many classes. Thanks to Thomas
5258 Vander Stichele for the patches.
5259 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5260 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5261 * buildbot/slave/bot.py, commands.py, registry.py: same
5263 2005-04-05 Brian Warner <warner@lothar.com>
5265 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5266 preserve timestamps, helps incremental builds of large trees.
5267 Patch from Rene Rivera.
5269 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5270 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5273 2005-04-03 Brian Warner <warner@lothar.com>
5275 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5276 with one dict, apparently exec has some scoping bugs when used
5277 with both global/local dicts. Thanks to Nathaniel Smith for the
5280 2005-04-02 Brian Warner <warner@lothar.com>
5282 * buildbot/process/step_twisted.py (countFailedTests): the new
5283 trial in Twisted-2.0 emits a slightly different status line than
5284 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5285 mistakenly think the test count is unparseable.
5286 (Trial.start): note that for some reason each build causes another
5287 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5288 be fixed but I'm not sure quite where the problem is.
5290 2005-04-01 Brian Warner <warner@lothar.com>
5292 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5293 deferredResult to avoid hangs/warnings under twisted-2.0
5294 (RunMixin.tearDown): same
5295 (RunMixin.shutdownSlave): same
5296 (Disconnect.testIdle1): same
5297 (Disconnect.testBuild2): same: wait one second after the build
5298 finishes for test to really be done.. this should be cleaned up to
5299 avoid wasting that second. Builder.detach uses a callLater(0),
5300 either that should be done in-line (something else needed that
5301 behavior), or it should return a Deferred that fires when the
5302 builder is really offline.
5303 (Disconnect.testBuild3): same
5304 (Disconnect.testDisappear): same
5306 * buildbot/test/test_web.py: rearrange server-setup and teardown
5307 code to remove unclean-reactor warnings from twisted-2.0
5309 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5310 so the tests don't hang under twisted-2.0
5312 2005-03-31 Brian Warner <warner@lothar.com>
5314 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5315 caused a warning each time the master changed our set of builders
5317 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5318 w32, don't unlink the file unless it already exists. Thanks to
5319 Baptiste Lepilleur for the catch.
5320 (BuilderStatus.saveYourself): same
5322 2005-02-01 Brian Warner <warner@lothar.com>
5324 * buildbot/status/html.py (TextLog.getChild): use a /text child
5325 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5326 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5327 logfile as text/plain (no markup, no headers). This replaces the
5328 previous scheme (which used an ?text=1 argument), and gets us back
5329 to a relative link (which works better when the buildbot lives
5330 behind another web server, such as Apache configured as a reverse
5331 proxy). Thanks to Gerald Combs for spotting the problem.
5333 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5336 2004-12-13 Brian Warner <warner@lothar.com>
5338 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5340 * debian/changelog: update for 0.6.2
5341 * NEWS: finalize for 0.6.2
5343 2004-12-11 Brian Warner <warner@lothar.com>
5345 * NEWS: bring it up to date
5347 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5348 detection code. Require some sign of life from the buildmaster
5349 every BotFactory.keepaliveInterval seconds. Provoke this
5350 indication at BotFactory.keepaliveTimeout seconds before the
5351 deadline by sending a keepalive request. We don't actually care if
5352 that request is answered in a timely fashion, what we care about
5353 is that .activity() is called before the deadline. .activity() is
5354 triggered by any PB message from the master (including an ack to
5355 one of the slave's status-update messages). With this new scheme,
5356 large status messages over slow pipes are OK, as long as any given
5357 message can be sent (and thus acked) within .keepaliveTimeout
5358 seconds (which defaults to 30).
5359 (SlaveBuilder.remote_startCommand): record activity
5360 (SlaveBuilder.ackUpdate): same
5361 (SlaveBuilder.ackComplete): same
5362 (BotFactory.gotPerspective): same
5363 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5365 2004-12-09 Brian Warner <warner@lothar.com>
5367 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5370 * buildbot/process/step_twisted.py (Trial._commandComplete):
5371 update self.cmd when we start the 'cat test.log' transfer. Without
5372 this, we cannot interrupt the correct RemoteCommand when we lose
5375 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5376 trying to tell the slave to stop the command if we're already
5377 inactive, or if we no longer have a .remote
5379 * buildbot/process/builder.py (Builder._detached): don't let an
5380 exception in currentBuild.stopBuild() prevent the builder from
5381 being marked offline
5383 2004-12-07 Brian Warner <warner@lothar.com>
5385 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5386 KeyError that happens when you ask for a non-existent Builder, and
5387 translate it into a UsageError.
5389 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5390 losing the slave in the middle of a remote step is handled too
5392 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5393 be a Failure, so be sure to stringify it before using it as the
5394 contents of the 'interrupt' logfile
5395 (RemoteCommand.interrupt): use stringified 'why' in
5396 remote_interruptCommand too, just in case
5398 2004-12-06 Brian Warner <warner@lothar.com>
5400 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5401 instead of 'tla update', which is more efficient in case we've
5402 missed a couple of patches since the last update.
5404 * debian/changelog: update for previous (0.6.1) release. Obviously
5405 this needs to be handled better.
5407 2004-12-05 Brian Warner <warner@lothar.com>
5409 * NEWS: update for stuff since last release
5411 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5412 match the maybeDeferred change in Dispatcher.requestAvatar
5413 * buildbot/changes/pb.py (ChangePerspective.attached): same
5414 * buildbot/status/client.py (StatusClientPerspective.attached): same
5415 * buildbot/process/builder.py (Builder._attached3): same
5416 * buildbot/pbutil.py (NewCredPerspective.attached): same
5418 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5419 the date to the top-most box, if it is not the same as today's
5422 * docs/slave.xhtml: provide a buildslave setup checklist
5424 * docs/source.xhtml (Arch): correct terminology
5426 2004-12-04 Brian Warner <warner@lothar.com>
5428 * buildbot/test/test_slavecommand.py: use sys.executable instead
5429 of hard-coding 'python' for child commands, might help portability
5431 * docs/examples/twisted_master.cfg: update to current usage
5433 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5434 'stop build' command to the IRC bot
5436 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5437 message that broke PBChangeSource
5439 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5440 (SlaveBuilder): make some attributes class-level, remove the old
5441 "update queue" which existed to support resuming a build after the
5442 master connection was lost. Try to reimplement that feature later.
5443 (SlaveBuilder.stopCommand): clear self.command when the
5444 SlaveCommand finishes, so that we don't try to kill a leftover one
5446 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5449 * buildbot/slave/commands.py (SourceBase): set self.command for
5450 all VC commands, so they can be interrupted.
5452 2004-12-03 Brian Warner <warner@lothar.com>
5454 * buildbot/master.py: clean up slave-handling code, to handle
5455 slave-disconnect and multiple-connect better
5456 (BotPerspective): make these long-lasting, exactly one per bot
5457 listed in the config file.
5458 (BotPerspective.attached): if a slave connects while an existing
5459 one appears to still be connected, disconnect the old one first.
5460 (BotPerspective.disconnect): new method to forcibly disconnect a
5461 buildslave. Use some hacks to empty the transmit buffer quickly to
5462 avoid the long (20-min?) TCP timeout that could occur if the old
5463 slave has dropped off the net.
5464 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5465 own their own SlaveStatus objects. Remove .attached/.detached, add
5466 .addSlave/.removeSlave, treat slaves like Builders (config file
5467 parsing sends deltas to the BotMaster). Inform the slave
5468 instances, i.e. the BotPerspective, about addBuilder and
5470 (BotMaster.getPerspective): turns into a single dict lookup
5471 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5472 which gives BotPerspective.attached a chance to disconnect the old
5474 (BuildMaster.loadConfig): add code (disabled) to validate that all
5475 builders use known slaves (listed in c['bots']). The check won't
5476 work with tuple-specified builders, which are deprecated but not
5477 yet invalid, so the check is disabled for now.
5478 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5479 routine, do the add/changed/removed dance with them like we do
5481 (BuildMaster.loadConfig_Sources): move source-config into a
5482 separate routine too
5484 * buildbot/status/builder.py (Status.getSlave): get the
5485 SlaveStatus object from the BotPerspective, not the BotMaster.
5487 * buildbot/test/test_run.py: bunch of new tests for losing the
5488 buildslave at various points in the build, handling a slave that
5489 connects multiple times, and making sure we can interrupt a
5492 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5493 something other than 'Bot' for the Bot object, to make certain
5494 test cases easier to write.
5495 (BuildSlave.waitUntilDisconnected): utility method for testing
5497 2004-11-30 Brian Warner <warner@lothar.com>
5499 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5501 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5502 argument, return a Deferred that always fires with True or False.
5503 I don't use an errback to indicate 'ping failed' so that callers
5504 are free to ignore the deferred without causing spurious errors in
5506 * buildbot/process/builder.py (BuilderControl.ping): implement it
5508 * buildbot/test/test_run.py (Status.testDisappear): test ping
5509 (Status.disappearSlave): fix it
5511 2004-11-30 Brian Warner <warner@lothar.com>
5513 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5514 (IBuilderControl): add .getBuild(num), only works for the current
5515 build, of course, although it might be interesting to offer
5516 something for builds in the .waiting or .interlocked state.
5518 * buildbot/process/base.py (Build): have .stopBuild just do the
5519 interrupt, then let the build die by itself.
5520 (BuildControl): add .stopBuild, and add a point-event named
5521 'interrupt' just after the build so status viewers can tell that
5523 (BuilderControl): add .getBuild
5525 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5526 stops when you kill it, good for testing
5527 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5528 contains the 'reason' text.
5530 * buildbot/status/html.py: Add Stop Build button, if the build can
5531 still be stopped. Send a Redirect (to the top page) one second
5532 later, hopefully long enough for the interrupt to have an effect.
5533 Move make_row() up to top-level to share it between Stop Build and
5536 * buildbot/slave/commands.py: only kill the child process once
5538 * buildbot/test/test_run.py: add testInterrupt
5540 2004-11-29 Brian Warner <warner@lothar.com>
5542 * buildbot/process/base.py: Refactor command interruption. The
5543 Build is now responsible for noticing that the slave has gone
5544 away: Build.lostRemote() interrupts the current step and makes
5545 sure that no further ones will be started.
5547 * buildbot/process/builder.py: When the initial remote_startBuild
5548 message fails, log it: this usually indicates that the slave has
5549 gone away, but we don't really start paying attention until they
5550 fail to respond to the first step's command.
5552 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5553 slave disconnect. Now sports a new interrupt() method. Error
5554 handling was simplified a lot by chaining deferreds, so
5555 remoteFailed/remoteComplete were merged into a single
5556 remoteComplete method (which can now get a Failure object).
5557 Likewise failed/finished were merged into just _finished.
5558 (BuildStep): Add interrupt(why) method, and if why is a
5559 ConnectionLost Failure then the step is failed with some useful
5562 * buildbot/slave/bot.py: stop the current command when the remote
5563 Step reference is lost, and when the slave is shut down.
5564 (Bot): make it a MultiService, so it can have children. Use
5565 stopService to tell when the slave is shutting down.
5566 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5567 remote_interruptCommand (which asks the current SlaveCommand to
5568 stop but allows it to keep emitting status messages), and
5569 stopCommand (which tells it to shut up and die).
5571 * buildbot/slave/commands.py: make commands interruptible
5572 (ShellCommand.kill): factor out os.kill logic
5573 (Command): factor out setup()
5574 (Command.sendStatus): don't send status if .running is false, this
5575 happens when the command has been halted.
5576 (Command.interrupt): new method, used to tell the command to die
5577 (SlaveShellCommand): implement .interrupt
5578 (DummyCommand): implement .interrupt
5579 (SourceBase, etc): factor out setup(), don't continue substeps if
5582 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5583 so they can be called after finishing
5585 * buildbot/test/test_run.py: new tests for disconnect behavior,
5586 refactor slave-shutdown routines, add different kinds of
5589 2004-11-27 Brian Warner <warner@lothar.com>
5591 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5592 method to express ETA time like "2m45s" instead of "165 seconds"
5594 2004-11-24 Brian Warner <warner@lothar.com>
5596 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5597 archive after the test completes, to avoid cluttering the user's
5598 'tla archives' listing with a bogus entry. Arch doesn't happen to
5599 provide any way to override the use of ~/.arch-params/, so there
5600 isn't a convenient way to avoid touching the setup of the user who
5602 (VC_HTTP.testArchHTTP): same
5604 2004-11-23 Brian Warner <warner@lothar.com>
5606 * buildbot/status/html.py (TextLog): split render() up into
5607 render_HEAD and render_GET. Use a Producer when sending log
5608 chunks, to reduce memory requirements and avoid sending huge
5609 non-Banana-able strings over web.distrib connections. Requires
5610 peeking under the covers of IStatusLog.
5611 (TextLog.resumeProducing): fix the "as text" link, handle client
5612 disconnects that occur while we're still sending old chunks.
5614 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5615 use defer.succeed, not the non-existent defer.success
5616 (LogFile.waitUntilFinished): same
5617 (LogFile.subscribe): don't add watchers to a finished logfile
5619 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5622 2004-11-23 Brian Warner <warner@lothar.com>
5624 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5626 2004-11-23 Brian Warner <warner@lothar.com>
5628 * NEWS: update for the 0.6.1 release
5629 * MANIFEST.in: add new files
5631 * README (INSTALLATION): explain how to enable the extra VC tests
5633 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5634 level to, so old pickled builds can be displayed ok
5636 2004-11-22 Brian Warner <warner@lothar.com>
5638 * NEWS: summarize updates since last release
5640 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5641 Yoz Grahame. Closes SF#1050138.
5643 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5646 * buildbot/process/step_twisted.py (Trial): update docs a bit
5648 * docs/factories.xhtml: fix Trial factory docs to match reality.
5651 * buildbot/process/factory.py (Trial.__init__): add args for
5652 randomly= and recurse=, making them available to instantiators
5653 instead of only to subclassers. Closes: SF#1049759.
5655 2004-11-15 Brian Warner <warner@lothar.com>
5657 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5658 try to teach the Quick factory to use multiple versions of python
5660 2004-11-12 Brian Warner <warner@lothar.com>
5662 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5663 safer w32-compatible approach, and only use it on windows
5664 (BuildStatus.saveYourself): same
5666 2004-11-11 Brian Warner <warner@lothar.com>
5668 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5669 it: one string merge per chunk. There are now separate .entries
5670 and .runEntries lists: when enumerating over all chunks, make sure
5672 * buildbot/test/test_status.py (Log): more tests
5674 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5675 chunks together, up to 10kb per chunk. This ought to cut down on
5676 the CPU-burning overhead of large log files. Thanks to Alexander
5677 Staubo for spotting the problem.
5678 * buildbot/test/test_status.py (Log): tests for same
5680 2004-11-10 Brian Warner <warner@lothar.com>
5682 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5683 header to outbound mail
5684 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5686 2004-11-08 Brian Warner <warner@lothar.com>
5688 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5689 can't do os.rename() onto an existing file, so catch the exception
5690 and unlink the target file first. This introduces a slight window
5691 where the existing file could be lost, but the main failure case
5692 (disk full) should still be handled safely.
5693 (BuildStatus.saveYourself): same
5695 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5696 separator character instead of os.sep, because the filenames being
5697 split here are coming from the VC system, which can have a
5698 different pathname convention than the local host. This should
5699 help a buildmaster running on windows that uses a CVS repository
5700 which runs under unix.
5701 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5703 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5704 when there are no test failures to be parsed
5706 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5707 instead of the unix-specific os.system("cp"), thanks to Elliot
5708 Murphy for this and the other buildbot-vs-windows catches.
5709 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5711 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5712 echo the command as it is run
5714 * setup.py: install sample.mk too, not just sample.cfg
5715 (scripts): install contrib/windows/buildbot.bat on windows
5717 2004-11-07 Brian Warner <warner@lothar.com>
5719 * buildbot/process/builder.py (Builder._detached): clear the
5720 self.currentBuild reference, otherwise the next build will be
5721 skipped because we think the Builder is already in use.
5723 * docs/examples/twisted_master.cfg: update to match current usage
5724 on the Twisted buildbot
5726 2004-10-29 Brian Warner <warner@lothar.com>
5728 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5730 2004-10-28 Brian Warner <warner@lothar.com>
5732 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5733 have separate doVCUpdate/doVCFull methods. Catch an update failure
5734 and respond by clobbering the source directory and re-trying. This
5735 will handle local changes (like replacing a file with a directory)
5736 that will cause CVS and SVN updates to fail.
5737 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5739 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5742 2004-10-19 Brian Warner <warner@lothar.com>
5744 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5746 * buildbot/status/html.py (StatusResourceTestResults): display any
5747 TestResults that the Build might have
5748 (StatusResourceTestResult): and the logs for each TestResult
5749 (StatusResourceBuild): add link from the per-build page
5751 2004-10-15 Brian Warner <warner@lothar.com>
5753 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5754 the 'problems' portion of stdout, add TestResults to our build
5755 * buildbot/test/test_twisted.py (Parse.testParse): test it
5757 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5758 to retrieve a dict of accumulated test results
5759 (ITestResult): define what a single test result can do
5760 * buildbot/status/builder.py (TestResult): implement ITestResult
5761 (BuildStatus.getTestResults): retrieve dict of TestResults
5762 (BuildStatus.addTestResult): add TestResults
5763 * buildbot/test/test_status.py (Results.testAddResults): test it
5765 2004-10-14 Brian Warner <warner@lothar.com>
5767 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5768 instead of os.system("rm -rf") for win32 portability
5770 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5771 SignalMixin instead of starting/stopping the reactor, which is
5772 likely to cause problems with other tests
5774 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5775 self.copyComplete() call. Yoz Grahame makes the catch.
5777 * contrib/windows/buildbot.bat: helper script to deal with path
5778 issues. Thanks to Yoz Grahame.
5780 * buildbot/master.py (BuildMaster.startService): don't register a
5781 SIGHUP handler if the signal module has no SIGHUP attribute.
5782 Apparently win32 does this.
5784 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5786 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5787 test if the reactor can't offer UNIX sockets
5789 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5790 error introduced in the last commit. We really need that
5793 2004-10-12 Brian Warner <warner@lothar.com>
5795 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5796 when describing a maildir source. Thanks to Stephen Davis.
5798 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5801 * buildbot/scripts/runner.py (createMaster): install Makefile too
5802 (start): add --no_save to 'start' command
5803 * buildbot/scripts/sample.mk: simple convenience Makefile with
5804 start/stop/reload targets
5806 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5809 2004-09-30 Brian Warner <warner@lothar.com>
5811 * setup.py: Releasing buildbot-0.6.0
5813 2004-09-30 Brian Warner <warner@lothar.com>
5815 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5816 test_trial.py from the source tarball until support is complete.
5818 * NEWS: update for 0.6.0 release
5819 * buildbot/__init__.py (version): same
5822 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5823 'source' command to tell users where to get the Buildbot source
5825 * docs/examples/*.cfg: update to modern standards
5827 * NEWS: update for release
5829 * buildbot/scripts/runner.py (createMaster): remove the
5830 -shutdown.tap stuff now that it isn't necessary
5832 (start): launch buildbot.tap, not buildbot-shutdown.tap
5835 * buildbot/status/mail.py (Domain): shorten class name
5836 (MailNotifier): if lookup= is a string, pass it to Domain()
5837 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5838 (Mail.testBuild2): test the string-to-Domain shortcut
5839 (Mail.testMail): fix test
5842 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5845 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5846 more attributes on load
5847 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5848 to accomodate the whole waterfall page at once, and the thrashing
5849 results in a lot of unnecessary loads
5850 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5851 (BuilderStatus.saveYourself): same
5852 (BuilderStatus.eventGenerator): stop generating on the first missing
5853 build. We assume that saved builds are deleted oldest-first.
5854 (BuildStepStatus.__getstate__): .progress might not exist
5856 * buildbot/changes/changes.py (ChangeMaster): make it
5857 serializable, in $masterdir/changes.pck
5858 (ChangeMaster.stopService): save on shutdown
5859 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5860 * buildbot/test/test_config.py: load Changes before config file
5863 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5864 "Oh my god, you killed the command" header on a separate line
5866 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5867 skip over corrupted build pickles
5868 (BuilderStatus.getFullBuildByNumber): same
5869 (BuilderStatus.eventGenerator): skip over unavailable builds
5870 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5871 do an atomic rename. This prevents a corrupted pickle when some
5872 internal serialization error occurs.
5873 (BuilderStatus.saveYourself): same
5875 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5876 the timeout for shell commands, it got lost somehow
5878 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5879 run out of build steps, return the rest of the builder events
5881 * buildbot/interfaces.py (IBuilderControl.ping): add method
5883 * buildbot/process/builder.py (BuilderControl.ping): move
5884 slave-ping to BuilderControl, and fix the failure case in the
5885 process (Event.finish() is the verb, Event.finished is the noun).
5887 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5888 through the BuilderControl instead of the BuilderStatus
5889 (EventBox): add adapter for builder.Event, allowing builder events to
5890 be displayed in the waterfall display
5892 * buildbot/master.py (BotMaster.stopService): add a 'master
5893 shutdown' event to the builder's log
5894 (BuildMaster.startService): and a 'master started' on startup
5896 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5897 builder events into the BuildStep event stream
5898 (Status.builderAdded): add a 'builder created' event
5901 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5902 command to announce the completion of a running build
5903 (IrcStatusBot.command_FORCE): announce when the build finishes
5905 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5906 don't evict unfinished builds from the cache: they must stay in
5907 the full-cache until their logfiles have stopped changing. Make
5908 sure the eviction loop terminates if an unfinished build was hit.
5909 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5910 This lets exceptions be dumped in an email status message. Really
5911 we need LogFiles which contain both text and HTML, instead of two
5913 (BuildStatus.__getstate__): handle self.finished=False
5914 (Status.builderAdded): if the pickle is corrupted, abandon the
5915 history and create a new BuilderStatus object.
5917 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5918 self.progress attribute, helped one test which doesn't fully set
5919 up the Build object.
5921 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5922 IStatusLog methods into an Interface that is implemented by "stub"
5923 logs, for which all the actual text chunks are on disk (in the
5924 pickled Build instance). To show the log contents, you must first
5925 adapt the stub log to a full IStatusLog object.
5927 * buildbot/status/builder.py (LogFileStub): create separate stub
5928 log objects, which can be upgraded to a real one if necessary.
5929 (LogFile): make them persistable, and let them stubify themselves
5931 (BuildStepStatus): same
5933 (BuildStatus.saveYourself): save the whole build out to disk
5934 (BuilderStatus): make it persistable
5935 (BuilderStatus.saveYourself): save the builder to disk
5936 (BuilderStatus.addFullBuildToCache): implement two caches which
5937 hold Build objects: a small one which holds full Builds, and a
5938 larger one which holds "stubbed" Builds (ones with their LogFiles
5939 turned into LogFileStubs). This reduces memory usage by the
5940 buildmaster by not keeping more than a few (default is 2) whole
5941 build logs in RAM all the time.
5942 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5944 (BuilderStatus.eventGenerator): rewrite since .builds went away
5945 (BuilderStatus.buildStarted): remove the .builds array. Add the
5946 build to the "full" cache when it starts.
5947 (BuilderStatus._buildFinished): save the build to disk when it
5949 (Status): give it a basedir (same as the BuildMaster's basedir)
5950 where the builder pickles can be saved
5951 (Status.builderAdded): create the BuilderStatus ourselves, by
5952 loading a pickle from disk (or creating a new instance if there
5953 was none on disk). Return the BuilderStatus so the master can glue
5954 it into the new Builder object.
5956 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5957 all BuilderStatuses to save themselves out to disk. This is in
5958 lieu of saving anything important in the main Application pickle
5959 (the -shutdown.tap file).
5960 (BuildMaster.__init__): give Status() a basedir for its files
5961 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5962 to get the BuilderStatus, then give it to the Builder (instead of
5963 doing it the other way around). It's ok if the status announces
5964 the new Builder before it's really ready, as the outside world can
5965 only see the BuilderStatus object anyway (and it is ready before
5966 builderAdded returns). Use the builder's "builddir" (which
5967 normally specifies where the slave will run the builder) as the
5968 master's basedir (for saving serialized builds).
5970 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5971 coerce the logfile to IStatusLog before trying to get the text
5972 chunks out of it. This will pull the full (non-stubified) Build in
5973 from disk if necessary.
5974 (TextLog): fix the adapter registration
5976 * buildbot/test/test_control.py (Force.setUp): create the basedir
5977 * buildbot/test/test_web.py: same
5978 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5979 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5980 * buildbot/test/test_run.py (Run.testMaster): same
5981 (Status.setUp): same
5983 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5985 * buildbot/status/html.py (Waterfall.__init__): store actual
5986 allowForce flag passed in rather than using True for everyone;
5987 make sure setting it to False doesn't cause a NameError
5989 (StatusResourceBuilder.__init__) add the builder name to the page
5991 (StatusResourceBuilder.body) move HTML generation for a name/value
5992 row into a helper method (StatusResourceBuilder.make_row); only
5993 generate the "Force Build" form if allowForce was True and the
5994 slave is connected. Use class attributes in the generated HTML to
5995 spread a little CSS-joy.
5997 2004-09-28 Brian Warner <warner@lothar.com>
5999 * buildbot/process/step_twisted.py (Trial.createSummary): fix
6000 warning-scanner to not ignore things like
6001 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
6003 * buildbot/status/html.py (StatusResource.control): add some
6004 class-level values for .control in an attempt to make upgrading
6007 * buildbot/util.py (ComparableMixin): survive missing attributes,
6008 such as when a class is modified and we're comparing old instances
6011 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
6012 failure handling, remove a redundant try/except block. Don't
6013 return the full traceback to the IRC channel.
6014 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
6015 error messages. Get ETA properly.
6017 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
6018 the reason, since (at least) IRC message will have <> in them.
6019 (StatusResourceBuilder.__init__): take an IBuilderControl
6020 (StatusResourceBuilder.force): use the IBuilderControl we get in
6021 the constructor instead of trying to make our own. Catch the
6022 new exceptions and ignore them for now (until we make an
6023 intermediate web page where we could show the error message)
6024 (StatusResource): create with an IControl, use it to give an
6025 IBuilderControl to all children
6026 (Waterfall): take an allowForce= option, pass an IControl object
6027 to StatusResource if it is True
6029 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
6031 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6032 catch new exceptions and return string forms
6034 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
6035 * buildbot/process/builder.py (Builder.forceBuild): raise them
6036 * buildbot/test/test_control.py (Force.testNoSlave): new test
6037 (Force.testBuilderInUse): same
6040 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
6042 * buildbot/test/test_run.py: use IControl
6043 * buildbot/test/test_vc.py: same
6045 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
6046 to use IControl. Still offline.
6047 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
6049 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
6050 who=None so periodic builds don't send out status mail
6051 (Builder.forceBuild): include reason in the log message
6052 (BuilderControl.forceBuild): rename 'name' to 'who'
6054 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
6055 'who' parameter, but make it None by default so builds forced by
6056 slave admins don't cause status mail to be sent to anybody
6057 (BotMaster.forceBuild): same. this method is deprecated.
6058 (DebugPerspective.perspective_forceBuild): same, use IControl.
6059 (DebugPerspective.perspective_fakeChange): use IControl..
6060 (Dispatcher.requestAvatar): .. so don't set .changemaster
6062 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
6063 parameter to avoid confusion with the name of the builder
6066 * buildbot/status/mail.py: refine comment about needing 2.3
6068 * buildbot/status/html.py: move all imports to the top
6070 * buildbot/test/test_control.py: test new interfaces
6071 * buildbot/test/test_run.py (Status): handle new interfaces
6072 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
6074 * buildbot/process/base.py (BuildControl): implement IBuildControl
6075 and its lonely getStatus() method
6077 * buildbot/process/builder.py (BuilderControl): implement
6078 IBuilderControl, obtained by adapting the Builder instance
6079 (Builder.startBuild): return a BuilderControl instead of a
6080 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
6081 accomplish the same thing.
6083 * buildbot/master.py: move all import statements to the top
6084 (Control): implement IControl, obtained by adapting the
6085 BuildMaster instance.
6087 * buildbot/interfaces.py: add IControl, IBuilderControl, and
6088 IBuildControl. These are used to force builds. Eventually they
6089 will provide ways to reconfigure the Builders, pause or abandon a
6090 Build, and perhaps control the BuildMaster itself.
6092 2004-09-26 Brian Warner <warner@lothar.com>
6094 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
6095 ends up comparing us against something without a .__class__
6097 2004-09-24 Brian Warner <warner@lothar.com>
6099 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
6102 * Makefile: add 'deb-snapshot' target, to create a timestamped
6105 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
6107 2004-09-23 Brian Warner <warner@lothar.com>
6109 * buildbot/__init__.py (version): move version string here
6110 * setup.py: get version string from buildbot.version
6111 * buildbot/status/html.py (WaterfallStatusResource.body): add
6112 buildbot version to the page footer
6113 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
6116 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
6117 slaves, let the second know where the first one is coming from
6118 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
6119 see our exceptions. It would be nice if there were a way to just
6120 send them the exception type and value, not the full traceback.
6123 * buildbot/status/mail.py (MailNotifier): add a new argument
6124 sendToInterestedUsers=, which can be set to False to disable the
6125 usual send-to-blamelist behavior.
6126 (top): handle python-2.2 which has no email.MIMEMultipart
6127 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
6128 (MailNotifier.disownServiceParent): unsubscribe on removal
6130 * buildbot/test/test_status.py (Mail.testBuild2): test it
6133 * buildbot/status/progress.py (Expectations.wavg): tolerate
6134 current=None, which happens when steps start failing badly
6135 * buildbot/test/test_status.py (Progress.testWavg): test for it
6137 * buildbot/process/step.py (SVN.startVC): when the (old) slave
6138 doesn't understand args['revision'], emit a warning instead of
6139 bailing completely. Updating to -rHEAD is probably close enough.
6141 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
6143 * buildbot/test/test_status.py: at least import bb.status.client
6144 even if we don't have any test coverage for it yet
6146 * contrib/svn_buildbot.py: don't require python2.3
6147 (main): wait, do require it (for sets.py), but explain how to
6148 make it work under python2.2
6150 2004-09-23 Brian Warner <warner@lothar.com>
6152 * contrib/svn_buildbot.py: include the revision number in the Change
6154 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
6155 using util.now() because FreshCVS is a realtime service
6157 * buildbot/status/event.py: delete dead code
6158 * buildbot/process/step.py: don't import dead Event class
6159 * buildbot/process/step_twisted.py: same
6160 * buildbot/status/builder.py: same
6161 * buildbot/status/client.py: same
6163 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
6165 * buildbot/changes/changes.py (Change): set .when from an __init__
6166 argument (which defaults to now()), rather than having
6167 ChangeMaster.addChange set it later.
6168 (ChangeMaster.addChange): same
6170 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
6171 (parseSyncmail): same. Just use util.now() for now.
6172 (parseBonsaiMail): parse the timestamp field for when=
6174 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
6175 instead of setting .when after the fact
6179 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
6180 results when the target project uses retrial. Still under
6182 * buildbot/test/test_trial.py: same
6184 2004-09-21 Brian Warner <warner@lothar.com>
6186 * buildbot/status/mail.py (MailNotifier.__init__): include
6187 success/warnings/failure in the Subject line
6188 (MailNotifier.buildMessage): add the buildbot's URL to the body,
6189 use step.logname for the addLogs=True attachment filenames
6190 * buildbot/test/test_status.py (Mail): test Subject lines
6191 (Mail.testLogs): test attachment filenames
6193 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
6194 accept a 'who' argument from the debug tool
6195 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
6196 * contrib/debug.glade: add text box to set 'who'
6198 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6199 .getBuilderName with .getBuilder().getName(), more flexible
6200 (IStatusLog.getName): logs have short names, but you can prefix
6201 them with log.getStep().getName() to make them more useful
6202 * buildbot/status/builder.py: same
6203 * buildbot/status/client.py: same
6204 * buildbot/status/html.py: same
6205 * buildbot/test/test_run.py (Status.testSlave): same
6206 * buildbot/process/step.py: tweak logfile names
6208 * buildbot/status/mail.py (MailNotifier): add lookup, change
6209 argument to extraRecipients. The notifier is now aimed at sending
6210 mail to the people involved in a particular build, with additional
6211 constant recipients as a secondary function.
6213 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6214 including slow-lookup and failing-lookup. Make sure the blamelist
6215 members are included.
6217 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6218 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6219 (IBuildStatus.getInterestedUsers): new method
6220 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6221 * buildbot/status/client.py (remote_getResponsibleUsers): same
6222 * buildbot/status/html.py (StatusResourceBuild.body): same
6223 * buildbot/test/test_run.py (Status.testSlave): same
6225 2004-09-20 Brian Warner <warner@lothar.com>
6227 * docs/users.xhtml: update concepts
6229 * Makefile: add a convenience makefile, for things like 'make
6230 test'. It is not included in the source tarball.
6232 2004-09-16 Brian Warner <warner@lothar.com>
6234 * NEWS: mention /usr/bin/buildbot, debian/*
6236 * debian/*: add preliminary debian packaging. Many thanks to
6237 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6238 it considerably since it left their hands, I am responsible for
6239 all breakage that's resulted.
6241 * bin/buildbot: create a top-level 'buildbot' command, to be
6242 installed in /usr/bin/buildbot . For now it's just a simple
6243 frontend to mktap/twistd/kill, but eventually it will be the entry
6244 point to the 'try' command and also a status client. It is also
6245 intended to support the upcoming debian-packaging init.d scripts.
6246 * buildbot/scripts/runner.py: the real work is done here
6247 * buildbot/scripts/__init__.py: need this too
6248 * buildbot/scripts/sample.cfg: this is installed in new
6249 buildmaster directories
6250 * setup.py: install new stuff
6252 2004-09-15 Brian Warner <warner@lothar.com>
6254 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6255 'file:' schema (the version shipped with OS-X was built without the
6257 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6258 updates the log-timestamp, to make sure it isn't still running after
6261 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6262 values to the config file.
6263 * docs/examples/hello.cfg: add examples
6264 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6265 * buildbot/status/builder.py (Status.getProjectURL): implement them
6266 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6267 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6268 * buildbot/status/html.py (WaterfallStatusResource): display them
6271 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6272 certain error cases don't suffer a secondary exception.
6273 (top): Skip tests if the corresponding VC tool is not installed.
6275 * buildbot/process/factory.py (Trial): introduce separate
6276 'buildpython' and 'trialpython' lists, since trialpython=[] is
6277 what you want to invoke /usr/bin/python, whereas ./setup.py is
6278 less likely to be executable. Add env= parameter to pass options
6279 to test cases (which is how I usually write tests, I don't know if
6280 anyone else does it this way).
6282 * buildbot/process/step_twisted.py (Trial): handle python=None.
6283 Require 'testpath' be a string, not a list. Fix tests= typo.
6284 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6286 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6287 way to deal with the possibility of removing the disconnect notify
6289 (CVS): add a 'login' parameter to give a password to 'cvs login',
6290 commonly used with pserver methods (where pw="" or pw="guest")
6292 * buildbot/slave/commands.py (SourceBase): move common args
6293 extraction and setup() to __init__, so everything is ready by the
6294 time setup() is called
6295 (CVS.start): call 'cvs login' if a password was supplied
6296 (ShellCommand): special-case PYTHONPATH: prepend the master's
6297 value to any existing slave-local value.
6299 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6300 don't have a remote, mark the builder as Offline. This whole
6301 function should probably go away and be replaced by individual
6303 (Builder.buildFinished): return the results to the build-finished
6304 deferred callback, helps with testing
6306 2004-09-14 Brian Warner <warner@lothar.com>
6308 * buildbot/test/test_vc.py: put all the repositories needed to run
6309 the complete tests into a single small (1.3MB) tarball, so I can
6310 make that tarball available on the buildbot web site. Test HTTP
6311 access (for Arch and Darcs) by spawning a temporary web server
6312 while the test runs.
6314 * docs/users.xhtml: new document, describe Buildbot's limited
6315 understanding of different human users
6317 * buildbot/test/test_vc.py: rearrange test cases a bit
6319 * buildbot/process/step_twisted.py (Trial): handle testpath=
6320 * buildbot/process/factory.py (Trial): update to use step.Trial
6322 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6324 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6325 the overall build text (which gives you 'failed 2 tests' rather
6327 (BuildStepStatus.text2): default to [], not None
6329 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6332 2004-09-12 Brian Warner <warner@lothar.com>
6334 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6335 log the whole exception if it's just an AttributeError (old slave)
6337 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6338 so (e.g.) sub-commands can be run in the right directory.
6339 (ShellCommand.start): accept an optional errorMessage= argument
6340 to make life easier for SVN.start
6341 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6343 (ShellCommand.start): move ['dir'] compatibility hack..
6344 (RemoteShellCommand.start): .. to here so everyone can use it
6346 * buildbot/process/step_twisted.py (Trial): use .workdir
6348 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6349 text displayed when debuild fails completely
6350 (Trial): snarf _trial_temp/test.log from the slave and display it
6352 2004-09-11 Brian Warner <warner@lothar.com>
6354 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6356 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6357 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6359 * buildbot/process/step.py (ShellCommand): call .createSummary
6360 before .evaluateCommand instead of the other way around. This
6361 makes it slightly easier to count warnings and then use that to
6362 set results=WARNINGS
6363 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6365 * buildbot/process/base.py (Build.buildFinished): update status
6366 before doing progress. It's embarrassing for the build to be stuck
6367 in the "building" state when an exceptions occurs elsewhere..
6369 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6370 python2.2 doesn't have 'sum'
6372 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6373 to prevent clients from accidentally sorting it
6375 * buildbot/master.py (Manhole): add username/password
6376 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6377 c['manholePort'], deprecate old usage
6378 * docs/config.xhtml: document c['manhole']
6379 * docs/examples/hello.cfg: show example of using a Manhole
6382 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6383 pretend the slave is up to date
6385 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6386 the module, overlaps with 'log', the local variable
6388 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6390 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6391 new method to let Steps find out the version of their
6392 corresponding SlaveCommand.
6393 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6394 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6395 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6397 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6398 (Arch.startVC): same
6399 (P4Sync.startVC): same
6401 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6402 Deferred so we can catch errors in remote_startCommand
6403 (RemoteShellCommand.start): same
6405 * docs/examples/twisted_master.cfg: update sample config file
6407 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6408 after connectionMade() is called, not before. Close stdin at that
6411 * buildbot/process/process_twisted.py: update to use Trial, clean
6412 up argument passing (move to argv arrays instead of string
6415 * buildbot/process/step_twisted.py (Trial): new step to replace
6416 RunUnitTests, usable by any trial-using project (not just
6417 Twisted). Arguments have changed, see the docstring for details.
6419 * buildbot/process/base.py (Build.startBuild): this now returns a
6420 Deferred. Exceptions that occur during setupBuild are now
6421 caught better and lead to fewer build_status weirdnesses, like
6422 finishing a build that was never started.
6423 (Build.buildFinished): fire the Deferred instead of calling
6424 builder.buildFinished directly. The callback argument is this
6425 Build, everything else can be extracted from it, including the
6426 new build.results attribute.
6427 * buildbot/process/builder.py (Builder.startBuild): same
6428 (Builder.buildFinished): same, extract results from build
6430 * buildbot/process/step.py (ShellCommands): remove dead code
6432 2004-09-08 Brian Warner <warner@lothar.com>
6434 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6435 doesn't try to use the leftover patched workdir
6436 (SourceStamp): test source-stamp computation for CVS and SVN
6438 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6439 patched workdir ('touch .buildbot-patched') so we don't try to
6441 (SourceBase.start): add ['revision'] for all Source steps
6442 (CVS): change args: use ['branch'] for -r, remove ['files']
6443 (CVS.buildVC): fix revision/branch stuff
6444 (SVN): add revision stuff
6446 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6447 kwargs (except 'workdir') to avoid silent spelling errors
6448 (ShellCommand.__init__): same
6449 (Source): new base class for CVS/SVN/etc. Factor out everything
6450 common, add revision computation (perform the checkout with a -D
6451 DATE or -r REVISION that gets exactly the sources described by the
6452 last Change), overridable with step.alwaysUseLatest. Add patch
6453 handling (build.getSourceStamp can trigger the use of a base
6454 revision and a patch).
6455 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6456 * docs/steps.xhtml: update docs
6457 * docs/source.xhtml: mention .checkoutDelay
6458 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6460 * buildbot/process/base.py (Build.setSourceStamp): add a
6461 .sourceStamp attribute to each Build. If set, this indicates that
6462 the build should be done with something other than the most
6463 recent source tree. This will be used to implement "try" builds.
6464 (Build.allChanges): new support method
6465 (Build.lastChangeTime): remove, functionality moved to Source steps
6466 (Build.setupBuild): copy the Step args before adding ['workdir'],
6467 to avoid modifying the BuildFactory (and thus triggering spurious
6471 * buildbot/status/html.py: rename s/commits/changes/
6472 (StatusResourceChanges): same
6473 (CommitBox.getBox): same, update URL
6474 (WaterfallStatusResource): same
6475 (StatusResource.getChild): same
6477 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6478 * contrib/debug.glade: add optional 'revision' to the fakeChange
6480 * buildbot/changes/changes.py (html_tmpl): display .revision
6481 (ChangeMaster.addChange): note .revision in log
6482 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6483 accept a ['revision'] attribute
6485 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6487 * buildbot/master.py (BotMaster.getPerspective): update the
6488 .connected flag in SlaveStatus when it connects
6489 (BotMaster.detach): and when it disconnects
6490 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6491 (BuildMaster.loadConfig_Builders): walk old list correctly
6493 * buildbot/test/test_config.py: fix prefix= usage
6495 2004-09-06 Brian Warner <warner@lothar.com>
6499 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6500 poll a P4 depot looking for recent changes. Thanks to Dave
6501 Peticolas for the contribution. Probably needs some testing after
6504 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6505 requires manual client setup for each buildslave. Rather
6506 experimental. Thanks again to Dave Peticolas.
6507 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6509 * buildbot/changes/changes.py (Change): add a .revision attribute,
6510 which will eventually be used to generate source-stamp values.
6512 * buildbot/process/step.py (RemoteCommand.start): use
6513 notifyOnDisconnect to notice when we lose the slave, then treat it
6514 like an exception. This allows LogFiles to be closed and the build
6515 to be wrapped up normally. Be sure to remove the disconnect
6516 notification when the step completes so we don't accumulate a
6517 bazillion such notifications which will fire weeks later (when the
6518 slave finally disconnects normally). Fixes SF#915807, thanks to
6519 spiv (Andrew Bennetts) for the report.
6520 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6521 really isn't Logged- specific
6522 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6523 header, since it's almost always going to be appended to an
6525 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6526 update test to handle use of notifyOnDisconnect
6528 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6529 don't clear .ETA and .currentBuild when going offline, let the
6530 current build clean up after itself
6532 * buildbot/process/builder.py (Builder.detached): wait a moment
6533 before doing things like stopping the current build, because the
6534 current step will probably notice the disconnect and cleanup the
6536 * buildbot/test/test_run.py (Status.tearDown): update test to
6537 handle asynchronous build-detachment
6539 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6541 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6542 hush a debug message
6544 2004-09-05 Brian Warner <warner@lothar.com>
6546 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6547 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6548 kernels do this: the fcntl module has the F_NOTIFY constant, but
6549 the kernel itself doesn't support the operation. Thanks to Olly
6550 Betts for spotting the problem.
6552 * buildbot/process/step.py (Darcs): new source-checkout command
6553 (Arch): new source-checkout command
6554 (todo_P4): fix constructor syntax, still just a placeholder
6555 * buildbot/test/test_vc.py (VC.testDarcs): test it
6556 (VC.testDarcsHTTP): same, via localhost HTTP
6558 (VC.testArchHTTP): same
6559 * NEWS: mention new features
6561 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6562 which tells the step to stash stdout text locally (in .stdout).
6563 Slave-side Commands can use this to make decisions based upon the
6564 output of the the ShellCommand (not just the exit code).
6565 (Darcs): New source-checkout command
6566 (Arch): New source-checkout command, uses .keepStdout in one place
6567 where it needs to discover the archive's default name.
6569 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6570 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6571 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6573 * buildbot/process/step.py (ShellCommand.describe): add an
6574 alternate .descriptionDone attribute which provides descriptive
6575 text when the step is complete. .description can be ["compiling"],
6576 for use while the step is running, then .descriptionDone can be
6577 ["compile"], used alone when the step succeeds or with "failed" when
6578 it does not. Updated other steps to use the new text.
6579 * buildbot/process/step_twisted.py: same
6580 * buildbot/test/test_run.py: update tests to match
6582 2004-08-30 Brian Warner <warner@lothar.com>
6584 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6585 (CVS.__init__): send 'patch' argument to slave
6586 (CVS.start): don't create the LoggedRemoteCommand until start(),
6587 so we can catch a .patch added after __init__
6588 (SVN.__init__): add 'patch' to SVN too
6591 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6592 argument, to let commands push data into the process' stdin pipe.
6593 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6594 is in use, since closing a PTY doesn't really affect the process
6595 in the right way (in particular, I couldn't run /usr/bin/patch
6597 (SourceBase.doPatch): handle 'patch' argument
6599 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6602 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6603 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6605 * buildbot/master.py (BotPerspective.got_commands): get command
6606 versions from slave, give to each builder
6607 * buildbot/process/builder.py (Builder.attached): stash slave
6608 command versions in .remoteCommands
6610 * docs/steps.xhtml: bring docs in-line with reality
6612 * buildbot/process/step.py (CVS.__init__): more brutal
6613 compatibility code removal
6614 (SVN.__init__): same
6616 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6617 (SlaveShellCommand.start): require ['workdir'] argument, remove
6618 the ['dir'] fallback (compatibility will come later)
6619 (SourceBase): update docs
6620 (SourceBase.start): remove ['directory'] fallback
6623 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6624 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6625 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6627 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6628 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6629 code.. I will figure out 0.5.0-compatibility hooks later)
6631 2004-08-30 Brian Warner <warner@lothar.com>
6633 * buildbot/process/process_twisted.py: rewrite in terms of new
6634 BuildFactory base class. It got significantly shorter. Yay
6637 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6638 work with the new "self.build isn't nailed down until we call
6639 step.start()" scheme: specifically, __init__ is called before the
6640 build has decided on which Changes are going in, so we don't scan
6641 build.allFiles() for .xhtml files until start()
6642 (HLint.commandComplete): use getText(), not getStdout()
6643 (RunUnitTests.start): same: don't use .build until start()
6644 (RunUnitTests.describe): oops, don't report (None) when using
6646 (RunUnitTests.commandComplete): use getText()
6647 (RunUnitTests.createSummary): same
6648 (BuildDebs.commandComplete): same
6650 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6651 set args['command'] until start(), since our BuildStep is allowed
6652 to change their mind up until that point
6653 (TreeSize.commandComplete): use getText(), not getStdout()
6655 * docs/examples/twisted_master.cfg: update to current standards
6657 * docs/factories.xhtml: update
6658 * buildbot/process/factory.py: implement all the common factories
6659 described in the docs. The Trial factory doesn't work yet, and
6660 I've probably broken all the process_twisted.py factories in the
6661 process. There are compatibility classes left in for things like
6662 the old BasicBuildFactory, but subclasses of them are unlikely to
6664 * docs/examples/glib_master.cfg: use new BuildFactories
6665 * docs/examples/hello.cfg: same
6667 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6668 explicit 'workdir' args
6670 * buildbot/process/base.py (BuildFactory): move factories to ..
6671 * buildbot/process/factory.py (BuildFactory): .. here
6672 * buildbot/process/process_twisted.py: handle move
6673 * buildbot/test/test_config.py: same
6674 * buildbot/test/test_run.py: same
6675 * buildbot/test/test_steps.py: same
6676 * buildbot/test/test_vc.py: same
6677 * docs/factories.xhtml: same
6679 * NEWS: mention config changes that require updating master.cfg
6681 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6682 argument to all steps that weren't given one already, pointing at
6683 the "build/" directory.
6685 * docs/examples/hello.cfg: remove explicit 'workdir' args
6687 * docs/factories.xhtml: document standard BuildFactory clases,
6688 including a bunch which are have not yet been written
6690 2004-08-29 Brian Warner <warner@lothar.com>
6692 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6693 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6694 buildbot.status.builder so they aren't quite so internal
6695 * buildbot/process/base.py, buildbot/process/builder.py: same
6696 * buildbot/process/maxq.py, buildbot/process/step.py: same
6697 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6698 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6699 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6701 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6702 to handle new getLogs()-returns-list behavior
6703 (StatusResourceBuildStep.getChild): same
6704 (StepBox.getBox): same
6705 (WaterfallStatusResource.phase0): same
6707 * docs/source.xhtml: document how Buildbot uses version-control
6708 systems (output side: how we get source trees)
6709 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6710 systems (input side: how we learn about Changes)
6712 * buildbot/master.py (Manhole): use ComparableMixin
6713 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6714 * buildbot/changes/mail.py (MaildirSource): same
6715 * buildbot/status/client.py (PBListener): same
6716 * buildbot/status/html.py (Waterfall): same
6717 * buildbot/status/words.py (IRC): same
6719 * NEWS: start describing new features
6721 * buildbot/status/mail.py (MailNotifier): finish implementation.
6722 The message body is still a bit sparse.
6723 * buildbot/test/test_status.py (Mail): test it
6725 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6726 and __hash__ methods I wind up adding everywhere. Specifically
6727 intended to support the buildbot config-file update scheme where
6728 we compare, say, the old list of IStatusTargets against the new
6729 one and don't touch something which shows up on both lists.
6730 * buildbot/test/test_util.py (Compare): test case for it
6732 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6733 return a list instead of a dict
6734 (IBuildStepStatus.getLogs): same. The idea is that steps create
6735 logs with vaguely unique names (although their uniqueness is not
6736 guaranteed). Thus a compilation step should create its sole
6737 logfile with the name 'compile', and contribute it to the
6738 BuildStatus. If a step has two logfiles, try to create them with
6739 different names (like 'test.log' and 'test.summary'), and only
6740 contribute the important ones to the overall BuildStatus.
6741 * buildbot/status/builder.py (Event.getLogs): same
6742 (BuildStepStatus): fix default .text and .results
6743 (BuildStepStatus.addLog): switch to list-like .getLogs()
6744 (BuildStepStatus.stepFinished): same
6745 (BuildStatus.text): fix default .text
6746 (BuildStatus.getLogs): temporary hack to return all logs (from all
6747 child BuildStepStatus objects). Needs to be fixed to only report
6748 the significant ones (as contributed by the steps themselves)
6749 * buildbot/test/test_run.py: handle list-like .getLogs()
6750 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6752 2004-08-28 Brian Warner <warner@lothar.com>
6754 * buildbot/process/builder.py (Builder.attached): serialize the
6755 attachment process, so the attach-watcher isn't called until the
6756 slave is really available. Add detached watchers too, which makes
6759 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6761 * buildbot/test/test_swap.py: remove dead code
6763 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6764 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6765 sort of as if the command being run exited with a -1. There may
6766 still be some holes in this scheme.
6767 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6768 -r option appears before the module list
6769 * buildbot/process/step.py (CVS): add 'revision' argument
6771 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6772 when sending updates or stepComplete messages to the master, since
6773 we don't currently care whether they arrive or not. When we revamp
6774 the master/slave protocol to really resume interrupted builds,
6775 this will need revisiting.
6776 (lostRemote): remove spurious print
6778 * buildbot/master.py (BotPerspective.attached): serialize the
6779 new-builder interrogation process, to make testing easier
6780 (BotMaster.waitUntilBuilderDetached): convenience function
6782 * buildbot/status/builder.py (BuilderStatus): prune old builds
6783 (BuildStatus.pruneSteps): .. and steps
6784 (BuildStepStatus.pruneLogs): .. and logs
6785 (BuilderStatus.getBuild): handle missing builds
6786 * buildbot/status/html.py (StatusResourceBuild.body): display build
6787 status in the per-build page
6788 (BuildBox.getBox): color finished builds in the per-build box
6790 2004-08-27 Brian Warner <warner@lothar.com>
6792 * buildbot/status/mail.py (MailNotifier): new notification class,
6795 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6796 variants of a common base class which handles all the mode= logic
6798 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6800 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6802 2004-08-26 Brian Warner <warner@lothar.com>
6804 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6807 * buildbot/test/test_run.py: update to new Logfile interface, new
6808 buildbot.slave modules
6809 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6811 * MANIFEST.in: new sample config file
6812 * docs/examples/hello.cfg: same
6814 * buildbot/process/step_twisted.py: remove dead import
6816 * buildbot/process/step.py (RemoteCommand.run): catch errors
6818 (RemoteCommand.remote_update): ignore updates that arrive after
6820 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6821 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6822 the responsibilities of the subclass's methods
6823 (BuildStep.failed): catch errors during failure processing
6824 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6825 (CVS): move to a mode= argument (described in docstring), rather
6826 than the ungainly clobber=/export=/copydir= combination.
6827 (SVN): add mode= functionality to SVN too
6828 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6830 * buildbot/process/base.py (Build.startNextStep): catch errors
6831 during s.startStep()
6833 * buildbot/clients/base.py: update to new PB client interface.
6834 gtkPanes is still broken
6836 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6837 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6838 * setup.py: add buildbot.slave module
6839 * buildbot/bb_tap.py: handle move
6840 * buildbot/slave/registry.py: place to register commands, w/versions
6841 * buildbot/slave/bot.py: major simplifications
6842 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6843 instead of a fixed table. Eventually this will make the slave more
6844 extensible. Use 'start' method on the command, not .startCommand.
6845 Fix unsafeTracebacks handling (I think).
6846 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6847 helper class with a .start method that returns a Deferred.
6848 SlaveShellCommand is the form reached by the buildmaster. Commands
6849 which use multiple ShellCommands can just chain them as Deferreds,
6850 with some helper methods in Command (_abandonOnFailure and
6851 _checkAbandoned) to bail on rc!=0.
6852 (CVSCommand): prefer new mode= argument
6853 (SVNFetch): add mode= argument
6855 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6856 put a useful reason string on the build
6858 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6859 core functionality into an IStatusLog object
6860 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6861 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6862 (StatusResourceBuild.body): use proper accessor methods
6863 * buildbot/status/client.py (RemoteLog): PB-access goes here
6864 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6865 which delivers log contents too
6866 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6867 * buildbot/status/event.py: remove old Logfile completely
6869 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6870 subscription interface for IStatusLog subscriptions just like all
6871 other the status subscriptions
6872 (IStatusReceiver.logChunk): method called on subscribers
6874 2004-08-24 Brian Warner <warner@lothar.com>
6876 * buildbot/process/builder.py (Builder._pong): oops, ping response
6877 includes a result (the implicit None returned by remote_print).
6878 Accept it so the _pong method handles the response correctly.
6880 2004-08-06 Brian Warner <warner@lothar.com>
6882 * buildbot/test/test_config.py: update IRC, PBListener tests
6884 * buildbot/status/client.py (StatusClientPerspective): total
6885 rewrite to match new IStatus interfaces. New subscription scheme.
6886 There are still a few optimizations to make (sending down extra
6887 information with event messages so the client doesn't have to do a
6888 round trip). The logfile-retrieval code is probably still broken.
6889 Moved the PB service into its own port, you can no longer share a
6890 TCP socket between a PBListener and, say, the slaveport (this
6891 should be fixed eventually).
6892 * buildbot/clients/base.py (Client): revamp to match. still needs
6893 a lot of work, but basic event reporting works fine. gtkPanes is
6896 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6897 instance talks to a single irc server. Threw out all the old
6898 multi-server handling code. Still need to add back in
6899 builder-control (i.e. "force build")
6901 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6902 more random text to the as-yet-unreachable per-step page
6904 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6905 rename to stepETAUpdate
6906 (BuildStatus.subscribe): add build-wide ETA updates
6907 (BuilderStatus.getState): remove more cruft
6908 (BuilderStatus.getCurrentBuild): remove more cruft
6909 (BuilderStatus.buildStarted): really handle tuple-subscription
6910 * buildbot/test/test_run.py (Status.testSlave): handle the
6911 stepETAUpdate rename
6913 * buildbot/master.py (BuildMaster): don't add a default
6914 StatusClientService. Don't add a default IrcStatusFactory. Both
6915 are now added through c['status'] in the config file. c['irc'] is
6916 accepted for backwards compatibility, the only quirk is you cannot
6917 use c['irc'] to specify IRC servers on ports other than 6667.
6919 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6920 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6921 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6922 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6925 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6926 the buildmaster to re-read its config file
6929 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6930 find out the port our server is running on
6931 (WebTest.test_webPathname_port): same
6933 * buildbot/test/test_config.py (testWebPortnum): test it
6934 (testWebPathname): ditto
6936 * docs/config.xhtml: document new c['status'] configuration option
6938 * buildbot/status/html.py (Waterfall): new top-level class which
6939 can be added to c['status']. This creates the Site as well as the
6940 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6941 reachable as .parent, for everything.
6943 * buildbot/master.py (Manhole): make it a normal service Child
6944 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6945 webPathname. It will eventually replace c['irc'] and the implicit
6946 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6947 in as (deprecated) backward compatibility hooks for now.
6950 * buildbot/process/builder.py (Builder.buildFinished): don't
6951 inform out builder_status about a finished build, as it finds out
6952 through its child BuildStatus object
6954 * buildbot/status/html.py: extensive revamp. Use adapters to make
6955 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6956 have both starting and finishing times and adjust the waterfall
6957 display accordingly, using spacers if necessary. Use SlaveStatus
6958 to get buildslave info.
6959 (StatusResourceBuildStep): new just-one-step resource, used to get
6960 logfiles. No actual href to it yet.
6962 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6963 the time being, until I get the file-naming scheme right
6965 * buildbot/status/builder.py (Event): clean started/finished names
6966 (BuildStatus.isFinished): .finished is not None is the right test
6967 (BuildStatus.buildStarted): track started/finished times ourselves
6968 (BuilderStatus.getSlave): provide access to SlaveStatus object
6969 (BuilderStatus.getLastFinishedBuild): all builds are now in
6970 .builds, even the currently-running one. Accomodate this change.
6971 (BuilderStatus.eventGenerator): new per-builder event generator.
6972 Returns BuildStepStatus and BuildStatus objects, since they can
6973 both be adapted as necessary.
6974 (BuilderStatus.addEvent): clean up started/finished attributes
6975 (BuilderStatus.startBuild,finishBuild): remove dead code
6976 (SlaveStatus): new object to provide ISlaveStatus
6978 * buildbot/process/step.py (ShellCommand.getColor): actually
6979 return the color instead of setting it ourselves
6980 (CVS.__init__): pull .timeout and .workdir options out of
6981 **kwargs, since BuildStep will ignore them. Without this neither
6982 will be sent to the slave correctly.
6983 (SVN.__init__): same
6985 * buildbot/process/builder.py (Builder): move flags to class-level
6987 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6988 SlaveStatus handle that
6990 * buildbot/process/base.py (Build.firstEvent): remove dead code
6991 (Build.stopBuild): bugfix
6993 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6995 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6996 (ChangeMaster.eventGenerator): yield Changes, since there are now
6997 Adapters to turn them into HTML boxes
6999 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
7000 (BotPerspective.attached): feed a SlaveStatus object
7001 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
7002 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
7004 * buildbot/interfaces.py: API additions
7005 (ISlaveStatus): place to get slave status
7007 2004-08-04 Brian Warner <warner@lothar.com>
7009 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
7010 the delay finishes, so the step is marked as SUCCESS
7012 * buildbot/test/test_run.py (Status.testSlave): cover more of
7013 IBuildStatus and IBuildStepStatus
7015 * buildbot/status/progress.py (StepProgress): move some flags to
7016 class-level attributes
7017 (StepProgress.remaining): if there are no other progress metrics
7018 to go by, fall back to elapsed time
7019 (StepProgress.setExpectations): take a dict of metrics instead of
7021 (BuildProgress.setExpectationsFrom): pull expectations from the
7022 Expectations, instead of having it push them to the BuildProgress
7023 (Expectations): move some flags to class-level attributes
7024 (Expectations.__init__): copy per-step times from the
7026 (Expectations.expectedBuildTime): new method for per-build ETA
7028 * buildbot/status/event.py (Logfile): move some flags to
7029 class-level attributes
7030 (Logfile.logProgressTo): better method name, let step set the
7031 progress axis name (instead of always being "output")
7033 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
7034 times directly, rather than depending upon the (possibly missing)
7035 .progress object. Use 'None' to indicate "not started/finished
7037 (BuildStepStatus.getExpectations): oops, return the full list of
7039 (BuilderStatus._buildFinished): append finished builds to .builds
7041 * buildbot/process/step.py (BuildStep): add separate .useProgress
7042 flag, since empty .progressMetrics[] still implies that time is a
7044 (CVS): set up the cmd in __init__, instead of waiting for start()
7046 * buildbot/process/base.py (Build.startBuild): disable the 'when'
7047 calculation, this will eventually turn into a proper sourceStamp
7048 (Build.setupBuild): tell the Progress to load from the Expectations,
7049 instead of having the Expectations stuff things into the Progress
7050 (Build.buildException): add a build-level errback to make sure the
7051 build's Deferred fires even in case of exceptions
7053 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
7055 * buildbot/process/builder.py (Builder.forceBuild): convey the
7056 reason instead of creating a fake Change
7058 * docs/examples/twisted_master.cfg: update to match reality
7060 * buildbot/test/test_config.py, buildbot/test/test_process.py:
7061 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
7062 fix or remove broken/breaking tests
7064 * buildbot/status/event.py (Logfile.__len__): remove evil method
7066 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
7067 missing .build, for test convenience
7069 * buildbot/process/step_twisted.py: import fixes
7071 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
7073 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
7074 .statusbag reference
7076 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
7077 connection at shutdown, and stop it from reconnecting
7079 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
7080 chase down remote-execution bugs
7082 * buildbot/process/step.py: more fixes, remove
7083 BuildStep.setStatus()
7084 * buildbot/status/builder.py: move setStatus() functionality into
7086 * buildbot/status/event.py: minor fixes
7088 2004-08-03 Brian Warner <warner@lothar.com>
7090 * buildbot/process/base.py, buildbot/process/builder.py
7091 * buildbot/process/step.py, buildbot/status/builder.py
7092 * buildbot/status/event.py, buildbot/test/test_run.py:
7093 fix status delivery, get a basic test case working
7094 * buildbot/master.py: finish implementing basic status delivery,
7095 temporarily disable HTML/IRC/PB status sources
7097 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
7099 * buildbot/status/progress.py (BuildProgress): remove dead code
7101 * buildbot/interfaces.py
7102 * buildbot/process/base.py, buildbot/process/builder.py
7103 * buildbot/process/step.py, buildbot/process/step_twisted.py
7104 * buildbot/status/builder.py: Complete overhaul of the all
7105 status-delivery code, unifying all types of status clients (HTML,
7106 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
7107 look like. This commit is a checkpointing of the work-in-progress:
7108 the input side is mostly done (Builders/Builds sending status
7109 to the BuilderStatus/BuildStatus objects), but the output side has
7110 not yet been started (HTML resources querying BuilderStatus
7111 objects). Things are probably very broken right now and may remain
7112 so for several weeks, I apologize for the disruption.
7114 * buildbot/status/event.py: add a setHTML method to use pre-rendered
7115 HTML as the log's contents. Currently used for exception tracebacks.
7116 * buildbot/status/progress.py: minor spelling changes
7118 2004-08-02 Brian Warner <warner@lothar.com>
7120 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
7121 in mozilla. Also added stylesheets copied from Twisted's docs.
7122 Remember that these files are meant to be run through Lore first.
7123 Thanks to Philipp Frauenfelder for the fixes.
7124 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
7125 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
7126 * docs/template.tpl: added a Lore template
7128 2004-07-29 Brian Warner <warner@lothar.com>
7130 * buildbot/interfaces.py: revamp status delivery. This is the
7131 preview: these are the Interfaces that will be provided by new
7132 Builder code, and to which the current HTML/IRC/PB status
7133 displayers will be adapted.
7135 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
7136 on the SlaveBuilder, not the Bot.
7137 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
7139 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
7140 set .usePTY on the FakeSlaveBuilder
7142 2004-07-25 Brian Warner <warner@lothar.com>
7144 * buildbot/changes/freshcvs.py: add some debug log messages
7145 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
7146 disabled 'setFilter' syntax
7147 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
7148 don't end with a slash
7150 * buildbot/process/base.py (Builder._pong_failed): add TODO note
7152 * setup.py: bump to 0.5.0+ while between releases
7154 2004-07-23 Brian Warner <warner@lothar.com>
7156 * setup.py (version): Releasing buildbot-0.5.0
7158 2004-07-23 Brian Warner <warner@lothar.com>
7160 * README: update for 0.5.0 release
7162 * NEWS: update for 0.5.0 release
7164 2004-07-22 Brian Warner <warner@lothar.com>
7166 * buildbot/slavecommand.py (ShellCommand): make usePTY a
7167 mktap-time configuration flag (--usepty=1, --usepty=0)
7168 * buildbot/bot.py: same
7170 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
7171 an 'info' directory being unwanted
7173 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
7174 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
7175 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
7176 and earlier), use a FreshCVSSourceOldcred instead.
7177 (test): simple test routine: connect to server, print changes
7179 * buildbot/changes/changes.py (Change.getTime): make it possible
7180 to print un-timestamped changes
7182 * buildbot/master.py (makeApp): delete ancient dead code
7183 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
7184 * buildbot/test/test_config.py (testFindConfigFile): test it
7186 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
7187 instead of win32 one
7190 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
7191 now takes a dictionary instead of a tuple. See docs/config.xhtml for
7194 * buildbot/process/base.py (Builder.__init__): change constructor
7195 to accept a dictionary of config data, rather than discrete
7196 name/slave/builddir/factory arguments
7198 * docs/examples/twisted_master.cfg: update to new syntax
7199 * docs/examples/glib_master.cfg: same
7200 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7201 rough tests of the new syntax
7204 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7205 to be an int, which means "run a web.distrib sub-server on a TCP
7206 port". This lets you publish the buildbot status page to a remote
7207 twisted.web server (using distrib.ResourceSubscription). Also
7208 rename the local attributes used to hold these web things so
7209 they're more in touch with reality.
7210 * buildbot/test/test_web.py: test webPortnum and webPathname
7211 * docs/config.xhtml: document this new use of webPathname
7213 * docs/config.xhtml: new document, slightly ahead of reality
7215 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7216 'prefix' handling: treat it as a simple string to check with
7217 .startswith, instead of treating it as a directory. This allows
7218 sub-directories to be used. If you use prefix=, you should give it
7219 a string that starts just below the CVSROOT and ends with a slash.
7220 This prefix will be stripped from all filenames, and filenames
7221 which do not start with it will be ignored.
7223 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7225 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7226 and --exclude (inverse of --include). SVN post-commit hooks
7227 now have total control over which changes get sent to buildbot and which
7230 2004-07-10 Brian Warner <warner@lothar.com>
7232 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7233 test case to match new API
7235 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7236 which crashed HTML display when self.entries=[] (needed to
7237 distinguish between [], which means "no entries yet", and None,
7238 which means "the entries have been swapped out to disk, go fetch
7241 2004-07-04 Brian Warner <warner@lothar.com>
7243 * buildbot/process/step_twisted.py (countFailedTests): Count
7244 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7245 10kb from the end because any import errors are wedged there and
7246 they would make us think the test log was unparseable.
7247 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7249 2004-06-26 Brian Warner <warner@lothar.com>
7251 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7252 delete-*.pyc command into an actual BuildStep, so we can label it
7254 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7255 (FullTwistedBuildFactory): same
7257 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7259 * contrib/fakechange.py: Add an errback when sending the fake
7260 change, so we know it didn't work.
7262 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7264 * buildbot/process/step_twisted.py: Delete *.pyc files before
7265 calling trial, so it doesn't catch any old .pyc files whose .py
7266 files have been moved or deleted.
7268 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7269 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7270 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7271 instead of ["twisted.test"], so that the end result is "trial -R
7274 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7275 regular expression to match filenames that should be ignored when
7276 changed. Also add a --revision parameter that specifies the
7277 revision to examine, which is useful for debugging.
7279 2004-06-25 Brian Warner <warner@lothar.com>
7281 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7282 summary of warnings (like DeprecationWarnings), next to the
7285 2004-05-13 Brian Warner <warner@lothar.com>
7287 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7288 we now have a w32 build slave courtesy of Mike Taylor.
7290 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7291 so broken. Fixed a race condition that tripped up interlocked
7292 builds and caused the status to be stuck at "Interlocked" forever.
7293 The twisted buildbot's one interlocked build just so happened to
7294 never hit this case until recently (the feeding builds both pass
7295 before the interlocked build is attempted.. usually it has to wait
7297 (Builder._pong_failed): fix method signature
7299 * setup.py: bump to 0.4.3+ while between releases
7301 2004-04-30 Brian Warner <warner@lothar.com>
7303 * setup.py (version): Releasing buildbot-0.4.3
7305 2004-04-30 Brian Warner <warner@lothar.com>
7307 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7309 * README: update for 0.4.3 release
7311 * NEWS: update for 0.4.3 release
7313 * buildbot/master.py (BuildMaster.__getstate__): make sure
7314 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7316 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7317 .trial as a class attribute, for upgrade from 0.4.2
7319 * buildbot/changes/changes.py (Change.links): add .links for
7322 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7323 .textWatchers and .htmlWatchers at save time, since they are both
7324 volatile, should allow smooth 0.4.2 upgrade
7326 * buildbot/process/step.py (CVS.finishStatus): catch failed
7327 CVS/SVN commands so we can make the status box red
7329 2004-04-29 Brian Warner <warner@lothar.com>
7331 * buildbot/changes/freshcvs.py
7332 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7333 code to do setFilter(), which tells the freshcvs daemon to not
7334 send us stuff that we're not interested in. I will uncomment it
7335 when a new version of CVSToys is available in which setFilter()
7336 actually works, and I get a chance to test it better.
7338 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7340 * buildbot/master.py (Dispatcher): use a registration scheme
7341 instead of hardwired service names
7342 (BuildMaster): keep track of the Dispatcher to support
7345 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7346 PBChangeSource class instead of having it be an undocumented
7347 internal feature of the ChangeMaster. Split out the code into a
7349 * buildbot/changes/pb.py (PBChangeSource): same
7350 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7352 * docs/{factories|sources|steps}.xhtml: document some pieces
7354 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7355 using FCMaildirSource
7356 (f23osx): update OS-X builder to use python2.3, since the slave
7357 was updated to Panther (10.3.3)
7359 2004-03-21 Brian Warner <warner@lothar.com>
7361 * buildbot/process/process_twisted.py: factor out doCheckout, change
7362 to use SVN instead of CVS
7364 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7365 an SVN subclass easier
7366 (BasicSVN): subclass which uses Subversion instead of CVS
7368 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7370 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7372 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7374 2004-02-25 Brian Warner <warner@lothar.com>
7376 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7377 is now either a list (which is passed to spawnProcess directly) or
7378 a string (which gets passed to /bin/sh -c). This removes the useSH
7379 flag and the ArgslistCommand class. Also send status header at the
7380 start and end of each command, instead of having the master-side
7382 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7383 -r'. Update to use list-based arguments.
7384 (SVNFetch): use list-based arguments, use ['dir'] argument to
7386 * buildbot/test/test_steps.py (Commands): match changes
7388 * buildbot/process/step.py (InternalShellCommand.words): handle
7390 (SVN): inherit from CVS, cleanup
7392 * buildbot/status/event.py (Logfile.content): render in HTML, with
7393 stderr in red and headers (like the name of the command we're
7394 about to run) in blue. Add link to a second URL (url + "?text=1")
7395 to get just stdout/stderr in text/plain without markup. There is
7396 still a problem with .entries=None causing a crash, it seems to occur
7397 when the logfile is read before it is finished.
7399 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7400 timeout to the keepalives, and use it to explicitly do a
7401 loseConnection instead of waiting for TCP to notice the loss. This
7402 ought to clear up the silent-lossage problem.
7403 (unsafeTracebacks): pass exception tracebacks back to the master,
7404 makes it much easier to debug problems
7406 2004-02-23 Brian Warner <warner@lothar.com>
7408 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7409 the whole command to /bin/sh instead of execve [Johan Dahlin]
7410 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7411 '-r HEAD' [Johan Dahlin]
7412 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7414 * buildbot/changes/changes.py (Change): add links= argument, add
7415 asHTML method [Johan Dahlin]. Modified to make a bit more
7416 XHTMLish. Still not sure how to best use links= .
7418 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7419 Change.asHTML to display the change, not asText
7421 * buildbot/status/html.py (StatusResourceBuilder): web button to
7424 * buildbot/test/test_run.py: test to actually start a buildmaster
7427 * MANIFEST.in: bring back accidentally-dropped test helper files
7429 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7430 that require cvstoys if it is not installed
7432 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7433 values of "bin/trial" [Dave Peticolas]
7434 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7435 tests passed" when we didn't happen to run any tests
7437 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7438 flunkOnFailure [Johan Dahlin]
7440 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7441 multiple instances of the same Step class by suffixing "_2", etc,
7442 to the name until it is unique. This name needs to be unique
7443 because it is used as a key in the dictionary that tracks build
7445 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7448 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7450 2004-01-14 Brian Warner <warner@lothar.com>
7452 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7453 kicked from a channel, log it
7455 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7456 something over whatever IRC channels the buildmaster is currently
7457 connected to. Added to try and track down a problem in which the
7458 master thinks it is still connected but the IRCd doesn't see it. I
7459 used a styles.Versioned this time, so hopefully users won't have
7460 to rebuild their .tap files this time.
7461 * contrib/debug.glade: add a "Poke IRC" button
7462 * contrib/debugclient.py: same
7464 * setup.py: bump to 0.4.2+ while between releases
7466 2004-01-08 Brian Warner <warner@lothar.com>
7468 * setup.py (version): Releasing buildbot-0.4.2
7470 2004-01-08 Brian Warner <warner@lothar.com>
7472 * NEWS: update for 0.4.2 release
7474 * README: document how to run the tests, now that they all pass
7476 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7478 * buildbot/process/step.py (CVS): add a global_options= argument,
7479 which lets you set CVS global options for the command like "-r"
7480 for read-only checkout, or "-R" to avoid writing in the
7482 * buildbot/slavecommand.py (CVSCommand): same
7484 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7485 testing easier (it is turned off when testing, to avoid the
7488 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7489 to make it easier to test: break generateStepID() out to a
7490 separate function, only update statusbag if it exists.
7491 (ShellCommands): create useful text for dict-based commands too.
7493 * test/*, buildbot/test/*: move unit tests under the buildbot/
7495 * setup.py (packages): install buildbot.test too
7497 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7498 * buildbot/test/test_steps.py: fix it, tests pass now
7500 2004-01-06 Brian Warner <warner@lothar.com>
7502 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7503 freshcvs mail uses a slightly different syntax for new
7504 directories. Update parser to handle either.
7505 * test/test_mailparse.py (Test1.testMsg9): test for same
7507 2003-12-21 Brian Warner <warner@lothar.com>
7509 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7510 'warnOnWarnings' so that lintian errors mark the build orange
7512 2003-12-17 Brian Warner <warner@lothar.com>
7514 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7515 messages emitted by Bonsai, contributed by Stephen Davis.
7517 * test/*: moved all tests to use trial instead of unittest. Some
7518 still fail (test_steps, test_slavecommand, and test_process).
7520 * setup.py (version): bump to 0.4.1+ while between releases
7522 2003-12-09 Brian Warner <warner@lothar.com>
7524 * setup.py (version): Releasing buildbot-0.4.1
7526 2003-12-09 Brian Warner <warner@lothar.com>
7528 * NEWS: update for 0.4.1 release
7530 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7531 freebsd builder code a little bit
7533 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7534 don't try to compare attributes of different classes
7535 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7536 (MaildirSource.messageReceived): fix Change delivery
7538 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7539 into the config file's namespace before loading it, like the
7540 documentation claims it does
7541 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7542 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7543 daemon comes back online
7545 2003-12-08 Brian Warner <warner@lothar.com>
7547 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7548 so the example will work with online=0 as well
7550 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7551 fix the __implements__ line
7553 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7554 class a twisted.application.service.Service, use startService to
7557 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7558 directory fd instead of simple open(). I'm sure this used to work,
7559 but the current version of python refuses to open directories with
7562 2003-12-05 Brian Warner <warner@lothar.com>
7564 * setup.py (version): bump to 0.4.0+ while between releases
7566 2003-12-05 Brian Warner <warner@lothar.com>
7568 * setup.py (version): Releasing buildbot-0.4.0
7570 2003-12-05 Brian Warner <warner@lothar.com>
7572 * docs/examples/glib_master.cfg: replace old sample scripts with
7573 new-style config files
7574 * MANIFEST.in: include .cfg files in distribution tarball
7576 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7577 implement a dummy method to avoid the exception that occurs when
7578 freshcvs sends this to us.
7580 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7581 removed the method, as it broke reconnection. Apparently
7582 stopFactory is called each time the connection attempt fails. Must
7584 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7585 attribute before serialization, since without stopFactory the
7586 reconnect timer may still be active and they aren't serializable.
7588 * test/test_mailparse.py (ParseTest): test with 'self' argument
7590 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7591 argument, as these "functions" are invoked like methods from class
7592 attributes and therefore always get an instance as the first
7595 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7596 message: thanks to Stephen Davis for the catch
7598 2003-12-04 Brian Warner <warner@lothar.com>
7600 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7601 twisted's standard ReconnectingClientFactory. Handles both oldcred
7602 and newcred connections. Also has a bug-workaround for
7603 ReconnectingClientFactory serializing its connector when it
7606 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7607 pbutil. Replace makeApp stuff with proper newcred/mktap
7608 makeService(). Don't serialize Ephemerals on shutdown.
7610 * buildbot/changes/changes.py (ChangeMaster): make it a
7611 MultiService and add the sources as children, to get startService
7612 and stopService for free. This also gets rid of the .running flag.
7614 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7615 new pbutil, turn into a TCPClient at the same time (to get
7616 startService for free). Two variants exist: FreshCVSSourceOldcred
7617 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7618 yet, but when it does, we'll be ready).
7619 (FreshCVSSource.notify): handle paths which are empty after the
7620 prefix is stripped. This only happens when the top-level (prefix)
7621 directory is added, at the very beginning of a Repository's life.
7623 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7624 Now the only reconnecting code is in the factory where it belongs.
7625 (Builder.unsubscribe): unregister the disconnect callback when we
7626 delete the builder on command from the master (i.e. when the
7627 buildmaster is reconfigured and that builder goes away). This
7628 fixes a multiple-delete exception when the status client is shut
7630 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7633 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7634 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7636 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7638 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7639 a list of globs (ugh). The testdir will be searched for files
7640 named *.tests and run the tests in the order specified in each of
7641 those files. This allows for "dependancies" between tests to be
7644 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7645 argument to pass to run_maxq.py, instead of a glob.
7647 2003-10-17 Brian Warner <warner@lothar.com>
7649 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7650 files that live in the sandbox
7652 2003-10-15 Brian Warner <warner@lothar.com>
7654 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7655 spelling error in "docs" count-warnings output
7656 (HLint.start): stupid thinko meant .xhtml files were ignored
7658 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7659 tests now that cReactor is banished to the sandbox
7661 2003-10-10 Brian Warner <warner@lothar.com>
7663 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7664 scheme: now .xhtml are sources and .html are generated
7666 2003-10-08 Brian Warner <warner@lothar.com>
7668 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7669 we were ignoring the 'randomly' parameter.
7671 2003-10-01 Brian Warner <warner@lothar.com>
7673 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7674 posix, to kill sub-children of aborted slavecommands.
7676 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7677 Clean up initialization: lastBuildStatus remains None until the
7678 first build has been completed.
7680 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7681 None as a lastBuildStatus
7682 * buildbot/clients/gtkPanes.py: same
7684 * buildbot/status/client.py (StatusClientService): keep
7685 BuilderStatus objects in self.statusbags . These objects now live
7686 here in the StatusClientService and are referenced by the Builder
7687 object, rather than the other way around.
7688 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7689 * buildbot/process/base.py (Builder): same
7690 * test/test_config.py (ConfigTest.testBuilders): same
7692 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7693 an existing builder, leave the statusbag alone. This will preserve the
7696 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7697 hook. This will probably go away in favor of a class in upcoming
7700 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7701 serviceName from newcred FreshCVSNotifiee setup
7703 2003-09-29 Brian Warner <warner@lothar.com>
7705 * buildbot/process/process_twisted.py: switch to new reactor
7707 * docs/examples/twisted_master.cfg: same
7709 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7711 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7712 botmaster reference instead of the oldapp service lookup
7714 * buildbot/master.py (BuildMaster.__init__): give the
7715 StatusClientService a reference to the botmaster to make it easier to
7718 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7720 * buildbot/status/html.py (Box.td): escape hreffy things so you
7721 can have spaces in things like builder names
7722 (StatusResourceBuilder.body)
7723 (WaterfallStatusResource.body)
7724 (WaterfallStatusResource.body0): same
7726 2003-09-25 Brian Warner <warner@lothar.com>
7728 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7729 rearrange the builder list when adding or removing builders: keep
7730 them in the order the user requested.
7731 * test/test_config.py (ConfigTest.testBuilders): verify it
7733 * contrib/debug.glade: give the debug window a name
7735 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7736 now wait on multiple interlocks. Fix code relating to that.
7737 (Builder.checkInterlocks): same
7738 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7740 * buildbot/master.py (BuildMaster.loadConfig): move from
7741 deprecated pb.BrokerFactory to new pb.PBServerFactory
7742 * test/test_config.py (ConfigTest.testWebPathname): same
7744 * docs/examples/twisted_master.cfg: fix interlock declaration
7746 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7747 Interlocks to their Builders into interlock.py .
7748 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7750 * test/test_config.py (ConfigTest.testInterlocks): validate
7753 * buildbot/process/base.py (Builder.__init__): better comments
7754 * buildbot/process/interlock.py (Interlock.__repr__): same
7755 (Interlock.deactivate): add .active flag, move the code that
7756 attaches/detaches builders into the Interlock
7758 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7760 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7761 tests using the new run_maxq.py script, and reporting failures by
7764 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7765 tests, reporting their success or failure in a buildbot-friendly
7768 2003-09-24 Brian Warner <warner@lothar.com>
7770 * docs/examples/twisted_master.cfg: example of a new-style config
7771 file. This lives in the buildmaster base directory as
7774 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7775 button to make the master re-read its config file
7777 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7778 buildmaster configuration from a file. This file can be re-read
7779 later, and the buildmaster will update itself to match the new
7780 desired configuration. Also use new Twisted Application class.
7781 * test/Makefile, test/test_config.py: unit tests for same
7783 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7784 FreshCVSSources comparable, to support reload.
7785 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7787 * buildbot/process/base.py (Builder): make them comparable, make
7788 Interlocks easier to attach, to support reload. Handle
7789 re-attachment of remote slaves.
7790 * buildbot/process/interlock.py (Interlock): same
7792 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7793 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7794 buildmaster taps are now constructed with mktap.
7795 * buildbot/status/client.py (StatusClientService): same
7797 * buildbot/status/words.py: move to new Services, add support to
7798 connect to multiple networks, add reload support, allow nickname
7799 to be configured on a per-network basis
7801 2003-09-20 Brian Warner <warner@lothar.com>
7803 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7804 the freebsd builder, now that the machine has been upgraded and no
7805 longer has python2.2
7807 * setup.py (version): bump to 0.3.5+ while between releases
7809 2003-09-19 Brian Warner <warner@lothar.com>
7811 * setup.py (version): Releasing buildbot-0.3.5
7813 2003-09-19 Brian Warner <warner@lothar.com>
7815 * NEWS: add post-0.3.4 notes
7817 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7819 * MANIFEST.in: add contrib/*
7821 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7822 use a remote root now: cvs.twistedmatrix.com
7824 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7826 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7827 compatibility with old servers
7828 (FreshCVSSource.start): and provide a way to use it
7829 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7831 * docs/examples/twisted_master.py (twisted_app): update to new
7833 (twisted_app): listen on new ~buildbot socket
7834 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7836 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7837 to reduce cvs bandwidth (update instead of full checkout)
7839 2003-09-11 Brian Warner <warner@lothar.com>
7841 * contrib/fakechange.py: demo how to connect to the changemaster
7842 port. You can use this technique to submit changes to the
7843 buildmaster from source control systems that offer a hook to run a
7844 script when changes are committed.
7846 * contrib/debugclient.py: tool to connect to the debug port. You
7847 can use it to force builds, submit fake changes, and wiggle the
7850 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7851 'Dispatcher' realm to handle all the different kinds of
7852 connections and Perspectives: buildslaves, the changemaster port,
7853 the debug port, and the status client port. NewCredPerspectives
7854 now have .attached/.detached methods called with the remote 'mind'
7855 reference, much like old perspectives did. All the pb.Services
7856 turned into ordinary app.ApplicationServices .
7857 (DebugService): went away, DebugPerspectives are now created
7858 directly by the Dispatcher.
7859 (makeApp): changed interface a little bit
7861 * buildbot/changes/changes.py: newcred
7862 * buildbot/status/client.py: newcred
7864 * buildbot/clients/base.py: newcred client side changes
7865 * buildbot/bot.py: ditto
7867 * docs/examples/glib_master.py: handle new makeApp() interface
7868 * docs/examples/twisted_master.py: ditto
7870 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7871 base newcred Perspectives on. This should go away once Twisted
7872 itself provides something sensible.
7875 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7877 * contrib/svn_buildbot.py: A program that you can call from your
7878 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7879 when a change in an SVN repository has happened. See the top of
7880 the file for some minimal usage info.
7882 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7884 * buildbot/slavecommand.py (ArglistCommand): Add new
7885 ArglistCommand that takes an argument list rather than a string as
7886 a parameter. Using a st.split() for argv is very bad.
7888 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7889 update to a particular revision rather than always checking out
7890 (still not very smart about it, there may be cases where the
7891 checkout becomes inconsistent).
7893 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7895 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7896 SVN fetch support. It can checkout (not update!) a specified
7897 revision from a specified repository to a specified directory.
7899 * buildbot/status/progress.py (Expectations.update): Fix an
7900 obvious bug (apparently created by the change described in the
7901 previous ChangeLog message) by moving a check to *after* the
7902 variable it checks is defined.
7905 2003-09-08 Brian Warner <warner@lothar.com>
7907 * buildbot/status/progress.py (Expectations.update): hack to catch
7908 an exception TTimo sees: sometimes the update() method seems to
7909 get called before the step has actually finished, so the .stopTime
7910 is not set, so no totalTime() is available and we average None
7911 with the previous value. Catch this and just don't update the
7912 metrics, and emit a log message.
7914 2003-08-24 Brian Warner <warner@lothar.com>
7916 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7917 parameter to set copydir='original' in CVS commands.
7919 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7921 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7922 which tells the command to maintain a separate original-source CVS
7923 workspace. For each build, this workspace will be updated, then
7924 the tree copied into a new workdir. This reduces CVS bandwidth
7925 (from a full checkout to a mere update) while doubling the local
7926 disk usage (to keep two copies of the tree).
7928 2003-08-21 Brian Warner <warner@lothar.com>
7930 * buildbot/status/event.py (Logfile.addEntry): if the master web
7931 server dies while we're serving a page, request.write raises
7932 pb.DeadReferenceError . Catch this and treat it like a
7933 notifyFinish event by dropping the request.
7935 2003-08-18 Brian Warner <warner@lothar.com>
7937 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7938 (instead of blowing up) if a force-build command is given without
7941 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7942 don't blow up if there aren't yet any Changes in the list
7944 2003-08-02 Brian Warner <warner@lothar.com>
7946 * buildbot/bot.py (updateApplication): don't set the .tap name,
7947 since we shouldn't assume we own the whole .tap file
7949 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7950 'mktap buildbot' (without a subcommand) better
7952 2003-07-29 Brian Warner <warner@lothar.com>
7954 * buildbot/status/words.py
7955 (IrcStatusFactory.clientConnectionLost): when we lose the
7956 connection to the IRC server, schedule a reconnection attempt.
7958 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7959 use shutil.rmtree instead of forking off an "rm -rf" command.
7960 rmtree may take a while and will block until it finishes, so we
7961 use "rm -rf" if available.
7963 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7964 freebsd buildslave badly
7966 * setup.py (version): bump to 0.3.4+ while between releases
7968 2003-07-28 Brian Warner <warner@lothar.com>
7970 * setup.py (version): Releasing buildbot-0.3.4
7972 2003-07-28 Brian Warner <warner@lothar.com>
7974 * NEWS: update in preparation for release
7976 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7977 process.signalProcess instead of os.kill, to improve w32
7980 * docs/examples/twisted_master.py (twisted_app): turn off
7981 win32eventreactor: the tests hang the buildslave badly
7983 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7984 failed builds, since usually the failures are consistent
7986 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7987 add compileOpts/compileOpts2 to reactors build
7989 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7990 (twisted_app): use both default and win32eventreactor on w32 build.
7991 Use both default and kqreactor on freebsd build.
7993 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7994 add compileOpts2, which is put after the build_ext argument. w32
7995 needs "-c mingw32" here.
7997 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7998 touch .acqpath, it goes away in recent Twisted releases
8000 * docs/examples/twisted_master.py (twisted_app): use "python" for
8001 the w32 buildslave, not "python2.2"
8003 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
8004 the directory exists.. should hush an exception under w32
8006 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
8007 ProcessTerminated -provided values for signal and exitCode rather
8008 than parsing the unix status code directly. This should remove one
8009 more roadblock for a w32-hosted buildslave.
8011 * test/test_mailparse.py: add test cases for Syncmail parser
8013 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
8014 temporary compatibility import. Note! Start importing
8015 FCMaildirSource from changes.mail instead of changes.freshcvsmail
8017 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
8019 2003-07-27 Brian Warner <warner@lothar.com>
8021 * NEWS: started adding new features
8023 * buildbot/changes/mail.py: start work on Syncmail parser, move
8024 mail sources into their own file
8026 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
8027 as implementing IChangeSource
8028 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
8030 * buildbot/interfaces.py: define the IChangeSource interface
8032 2003-07-26 Brian Warner <warner@lothar.com>
8034 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
8036 2003-06-25 Brian Warner <warner@lothar.com>
8038 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
8041 2003-06-17 Brian Warner <warner@lothar.com>
8043 * buildbot/status/words.py: clean up method usage to avoid error
8044 in silly IRC command
8045 (IrcStatusBot.emit_status): round off seconds display
8047 * buildbot/process/base.py (Build): delete the timer when saving
8048 to the .tap file, and restore it (if it should still be running)
8049 upon restore. This should fix the "next build in -34 seconds"
8050 messages that result when the master is restarted while builds are
8051 sitting in the .waiting slot. If the time for the build has
8052 already passed, start it very soon (in 1 second).
8054 * buildbot/status/words.py: more silly commands
8056 * README (REQUIREMENTS): add URLs to all required software
8058 * buildbot/status/words.py ('last'): mention results of, and time
8061 2003-05-28 Brian Warner <warner@lothar.com>
8063 * buildbot/status/words.py: add 'last' command
8064 (IrcStatusBot.emit_status): add current-small text to 'status' output
8066 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
8067 (twisted_app): remove spaces from OS-X builder name
8069 * buildbot/master.py (makeApp): add knob to turn on IRC bot
8070 * buildbot/status/words.py: IRC bot should actually be useful now
8072 2003-05-23 Brian Warner <warner@lothar.com>
8074 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
8075 "slave information" from $(slavedir)/info/* . These files are
8076 maintained by the slave administrator, and describe the
8077 machine/environment that is hosting the slave. Information from
8078 them is put into the "Builder" HTML page. Still need to establish
8079 a set of well-known filenames and meanings for this data: at the
8080 moment, *all* info/* files are sent to the master, but only
8081 'admin' and 'host' are used on that end.
8082 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
8083 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
8084 * buildbot/master.py (BotPerspective.got_info): ditto
8086 2003-05-22 Brian Warner <warner@lothar.com>
8088 * setup.py (version): bump version to 0.3.3+ while between releases
8090 2003-05-21 Brian Warner <warner@lothar.com>
8092 * setup.py: Releasing buildbot-0.3.3
8094 2003-05-21 Brian Warner <warner@lothar.com>
8096 * NEWS: 0.3.3 news items
8098 * README: describe --keepalive and life behind a NAT box
8100 * buildbot/bot.py (Bot.connected): implement application-level
8101 keepalives to deal with NAT timeouts, turn them on with
8102 --keepalive option or when SO_KEEPALIVE doesn't work.
8104 * buildbot/master.py (BotPerspective): accept keepalives silently
8106 * buildbot/process/base.py (Build.buildException): CopiedFailures
8107 don't carry as much information as local ones, so don't try to
8108 create a big HTMLized version of them.
8110 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
8111 log file when step fails due to an exception, such as when the slave
8114 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
8115 --testmodule argument instead of grepping for test-case-name tags
8116 ourselves. Remove FindUnitTests code.
8117 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
8119 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
8121 2003-05-16 Brian Warner <warner@lothar.com>
8123 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
8124 argument to allow things like CFLAGS=-O0 to be passed without relying
8125 upon /bin/sh processing on the slave.
8127 * buildbot/process/step.py (InternalShellCommand.start): send
8129 * buildbot/slavecommand.py (ShellCommand.start): create argv with
8130 'split' instead of letting /bin/sh do it. This should also remove
8131 the need for /bin/sh on the buildslave, making it more likely to
8134 * buildbot/status/html.py: html-escape text in blamelist.
8135 Add "force build" button to the Builder page.
8137 * buildbot/process/step_twisted.py (countFailedTests): look at
8138 last 1000 characters for status line, as import errors can put it
8139 before the -200 point.
8141 2003-05-15 Brian Warner <warner@lothar.com>
8143 * docs/examples/twisted_master.py: use clobber=0 for remote builds
8145 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8146 make 'clobber' a parameter, so it is possible to have builds which
8147 do full tests but do a cvs update instead of hammering the CVS
8148 server with a full checkout each build
8150 * buildbot/process/step.py (InternalShellCommand): bump default
8151 timeout to 20 minutes
8153 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
8154 the master to trigger a build. Run it via manhole.
8156 * buildbot/master.py (BotPerspective.perspective_forceBuild):
8157 allow slaves to trigger any build that they host, to make life
8158 easier for slave admins who are testing out new build processes
8160 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8161 don't flunk cReactor or qtreactor on failure, since they fail alot
8162 these days. Do warnOnFailure instead.
8164 * buildbot/process/base.py: change Builder.buildable from a list
8165 into a single slot. When we don't have a slave, new builds (once
8166 they make it past the timeout) are now merged into an existing
8167 buildable one instead of being queued. With this change, a slave
8168 which has been away for a while doesn't get pounded with all the
8169 builds it missed, but instead just does a single build.
8171 2003-05-07 Brian Warner <warner@lothar.com>
8173 * setup.py (version): bump version to 0.3.2+ while between releases
8175 2003-05-07 Brian Warner <warner@lothar.com>
8177 * setup.py: Releasing buildbot-0.3.2
8179 2003-05-07 Brian Warner <warner@lothar.com>
8181 * setup.py: fix major packaging error: include subdirectories!
8183 * NEWS: add changes since last release
8185 * README (REQUIREMENTS): update twisted/python dependencies
8187 * buildbot/status/builder.py (Builder.startBuild): change
8188 BuildProcess API: now they should call startBuild/finishBuild
8189 instead of pushing firstEvent / setLastBuildStatus. Moving towards
8190 keeping a list of builds in the statusbag, to support other kinds of
8192 (Builder.addClient): send current-activity-small to new clients
8193 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
8196 * buildbot/status/client.py: drop RemoteReferences at shutdown
8198 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8200 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8201 more debug messages for remote status client
8203 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8204 (.stepFailed): only fire the Deferred once, even if both
8205 stepComplete and stepFailed are called. I think this can happen if
8206 an exception occurs at a weird time.
8208 * buildbot/status/words.py: work-in-progress: IRC status delivery
8210 2003-05-05 Brian Warner <warner@lothar.com>
8212 * docs/examples/twisted_master.py (twisted_app): hush internal
8213 python2.3 distutils deprecation warnings
8214 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8215 add compileOpts= argument which inserts extra args before the
8216 "setup.py build_ext" command. This can be used to give -Wignore
8217 warnings, to hush some internal python-2.3 deprecation messages.
8219 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8220 the ['twisted.test'] default test case to make it easier to change
8223 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8224 * buildbot/clients/gtkPanes.py: ditto
8226 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8227 arg to collapse RunUnitTestsRandomly into RunUnitTests
8228 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8229 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8231 * buildbot/status/html.py (StatusResource): shuffle Resources
8232 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8233 would serve the waterfall display, but the internal links were
8234 only valid on the trailing-slash version. The correct behavior is
8235 for the non-slashed one to serve a Redirect to the slashed one.
8236 This only shows up when the buildbot page is hanging off another
8237 server, like a Twisted-Web distributed server.
8239 * buildbot/status/event.py (Event, RemoteEvent): make Events
8240 pb.Cacheable, with RemoteEvent as the cached version. This removes
8241 a lot of explicit send-an-update code.
8242 * buildbot/status/builder.py (Builder): remove send-update code
8243 * buildbot/status/client.py (ClientBuilder): remove send-update
8244 code, and log errors that occur during callRemote (mostly to catch
8245 InsecureJelly exceptions)
8247 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8248 run Lore with the same python used in the rest of the build
8250 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8252 * buildbot/process/step_twisted.py (HLint): accept 'python'
8253 argument. Catch rc!=0 and mark the step as failed. This marks the
8254 build orange ("has warnings").
8255 (RunUnitTestsJelly): move out to step_twisted2.py
8257 * buildbot/util.py (ignoreStaleRefs): add utility function
8259 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8260 don't fake ETA object, it's too hard to get right
8262 2003-05-02 Brian Warner <warner@lothar.com>
8264 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8266 2003-05-01 Brian Warner <warner@lothar.com>
8268 * buildbot/status/html.py (StatusResource.body): oops, I was
8269 missing a <tr>, causing the waterfall page to be misrendered in
8270 everything except Galeon.
8272 2003-04-29 Brian Warner <warner@lothar.com>
8274 * docs/examples/twisted_master.py: make debuild use python-2.2
8275 explicitly, now that Twisted stopped supporting 2.1
8277 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8278 handle tuple results too. I keep forgetting this, which suggests
8279 it needs to be rethought.
8281 * setup.py (setup): bump version to 0.3.1+ while between releases
8283 2003-04-29 Brian Warner <warner@lothar.com>
8285 * setup.py: Releasing buildbot-0.3.1
8287 2003-04-29 Brian Warner <warner@lothar.com>
8289 * README (SUPPORT): add plea to send questions to the mailing list
8291 * NEWS, MANIFEST.in: add description of recent changes
8293 * docs/examples/twisted_master.py: add the code used to create the
8294 Twisted buildmaster, with passwords and such removed out to a
8297 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8298 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8299 buildmasters to not require CVSToys be installed.
8300 * README, docs/examples/glib_master: update to match the change
8302 * buildbot/clients/base.py, buildbot/bot.py,
8303 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8304 ReconnectingPB from CVSToys distribution to remove CVSToys
8305 dependency for build slaves and status clients. Buildmasters which
8306 use FreshCVSSources still require cvstoys be installed, of course.
8308 2003-04-25 Brian Warner <warner@lothar.com>
8310 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8311 runTestsRandomly arg to turn on trial -z
8313 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8314 experimental code to use trial's machine-parseable output to get
8315 more detailed test results. Still has some major issues.
8316 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8319 * buildbot/status/builder.py (Builder.setCurrentBuild):
8320 anticipating moving build history into statusbag, not used yet
8322 * buildbot/status/tests.py: code to centralize test results,
8323 doesn't work quite yet
8325 * buildbot/status/event.py (Event): use hasattr("setName") instead
8326 of isinstance for now.. need better long-term solution
8328 * buildbot/status/html.py: Remove old imports
8330 2003-04-24 Brian Warner <warner@lothar.com>
8332 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8333 ignore changes under doc/fun/ and sandbox/
8335 * buildbot/process/step_twisted.py: update pushEvent and friends.
8337 * buildbot/status/html.py (Box.td): replace event.buildername with
8338 event.parent.getSwappableName(). Needs more thought.
8340 * buildbot/status/builder.py (Builder): Replace pushEvent and
8341 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8342 Tell events they are being pruned with event.delete().
8344 * buildbot/process/base.py (Build): Remove Builder status-handling
8345 methods. s/pushEvent/setCurrentActivity/.
8347 * buildbot/process/step.py (BuildStep): clean up status delivery.
8348 Gouse builder.statusbag methods instead of intermediate builder
8349 methods. s/updateLastEvent/updateCurrentActivity/.
8350 s/finalizeLastEvent/finishCurrentActivity/. Use
8351 addFileToCurrentActivity for summaryFunction.
8353 * buildbot/status/event.py (Logfile): put data in a Swappable when
8355 (Event): add more setter methods. Remove .buildername, use .parent
8356 and getSwappableName instead (needs more thought).
8358 * buildbot/util.py (Swappable):
8359 * test/test_swap.py: don't bother setting filename at __init__
8360 time, do it later. Change setFilename args to take parent first,
8361 since it provides the most significant part of the filename.
8363 2003-04-23 Brian Warner <warner@lothar.com>
8365 * buildbot/status/event.py (Logfile.addEntry): append to previous
8368 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8369 anticipating Swappable
8370 (InternalShellCommand.remoteUpdate): split out various log-adding
8371 methods so subclasses can snarf stdout separately
8373 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8374 in anticipation of Swappable build logs
8375 (Builder.testsFinished): anticipating TestResults, still disabled
8377 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8380 * buildbot/status/event.py (Logfile): add (disabled) support for
8381 Swappable, not ready for use yet
8383 * buildbot/util.py (Swappable): object which is swapped out to
8384 disk after some period of no use.
8385 * test/test_swap.py: test buildbot.utils.Swappable
8387 2003-04-14 Brian Warner <warner@lothar.com>
8389 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8390 periodic-build timer. Set the .periodicBuildTime on a builder
8391 instance to some number of seconds to activate it.
8393 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8395 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8396 a way that survives result tuples
8398 2003-04-12 Brian Warner <warner@lothar.com>
8400 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8401 return a dict instead of a tuple: allow summarizers to provide
8402 multiple summaries if they want
8403 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8404 (debuildSummarizer): summarize lintian warnings/errors
8406 2003-04-10 Brian Warner <warner@lothar.com>
8408 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8410 2003-04-09 Brian Warner <warner@lothar.com>
8412 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8413 empty summaries: happens when the tests fail so hard they don't emit
8414 a parseable summary line.
8416 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8417 Allow summaryFunction to return None to indicate no summary should
8420 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8421 writing to stale HTTP requests: notice when they disconnect and
8422 remove the request from the list. Also add CacheToFile from
8423 moshez, will be used later.
8425 2003-04-08 Brian Warner <warner@lothar.com>
8427 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8428 should be an int, not a list of strings
8430 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8431 if we weren't actually connected
8433 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8434 to show the tail end of the trial text output
8436 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8437 hook to summarize the results of a ShellCommand
8439 2003-04-07 Brian Warner <warner@lothar.com>
8441 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8442 twisted test suite code into a single class.
8443 * buildbot/process/process_twisted.py: same
8445 2003-04-04 Brian Warner <warner@lothar.com>
8447 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8449 * README (SLAVE): document use of mktap to create slave .tap file
8450 (REQUIREMENTS): describe dependencies
8452 * buildbot/bb_tap.py, buildbot/plugins.tml:
8453 * buildbot/bot.py (updateApplication): Add mktap support for creating
8454 buildslave .tap files
8456 2003-03-28 Brian Warner <warner@lothar.com>
8458 * buildbot/process/step.py (InternalShellCommand.finished): handle
8459 new tuple result values (fix embarrasing bug that appeared during
8462 2003-03-27 Brian Warner <warner@lothar.com>
8464 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8467 2003-03-25 Brian Warner <warner@lothar.com>
8469 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8470 to overall build status
8471 * buildbot/clients/base.py (Builder): improve event printing
8472 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8473 instead of generic ShellCommand
8474 (Build): Add .stopBuild, use it when slave is detached
8476 * buildbot/process/step.py (Configure,Test): give the steps their
8477 own names and status strings
8479 * buildbot/status/html.py (StatusResource): add "show" argument,
8480 lets you limit the set of Builders being displayed.
8482 2003-03-20 Brian Warner <warner@lothar.com>
8484 * buildbot/process/basic.py: removed
8486 2003-03-19 Brian Warner <warner@lothar.com>
8488 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8489 turn off process-docs by default
8491 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8492 when displaying build information without anything in allBuilds[]
8494 * buildbot/bot.py (makeApp): really take password from sys.argv
8496 2003-03-18 Brian Warner <warner@lothar.com>
8498 * buildbot/bot.py (buildApp): take password from sys.argv
8500 * README: replace with more useful text
8502 * setup.py: add a real one
8503 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8505 * docs/PyCon-2003/: added sources for PyCon paper.
8507 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8508 now Build objects control the process and Builder only handles
8509 slave stuff and distribution of changes/status. A new BuildFactory
8510 class creates Build objects on demand.
8512 Created ConfigurableBuild which takes a list of steps to run. This
8513 makes it a lot easier to set up a new kind of build and moves us
8514 closer to being able to configure a build from a web page.
8516 * buildbot/process/step_twisted.py, process_twisted.py: move to
8517 new model. A lot of code went away.
8519 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8520 send lots of empty progress messages to the client.
8522 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8524 2003-02-20 Brian Warner <warner@lothar.com>
8526 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8528 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8529 Twisted bug that prevented non-pty processes from working just got
8530 fixed, and the bug that leaks ptys is still being investigated.
8532 * buildbot/process/step.py (CVS): send timeout arg to slave
8534 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8535 builders coming and going
8536 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8537 from CVSToys, handle lost-buildmaster
8539 * buildbot/status/client.py (StatusClientService.removeBuilder):
8540 Clean up status client protocol: send builders (with references)
8541 as they are created, rather than sending a list and requiring the
8542 client to figure out which ones are new.
8543 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8544 attempts to force a build on an unknown builder
8546 2003-02-19 Brian Warner <warner@lothar.com>
8548 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8549 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8550 Twisted stops leaking them.
8551 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8552 builder goes to an idle state.
8554 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8555 I figure out why CVS commands hang without them, and/or I fix the
8556 hung-command timeout
8558 2003-02-16 Brian Warner <warner@lothar.com>
8560 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8561 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8562 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8563 GenerateDocs now that they are prefixed with WARNING:.
8565 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8566 use manual href target instead of request.childLink
8568 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8569 display every second, but update the ETA every 5 seconds (or
8570 whenever) as remote_progress messages arrive.
8573 2003-02-12 Brian Warner <warner@lothar.com>
8575 * *: import current sources from home CVS repository
8579 # add-log-time-format: add-log-iso8601-time-string