1 2007-08-01 Brian Warner <warner@lothar.com>
3 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
4 mostly work (branch= is still ignored, we need a useful header)
5 (OneLinePerBuildOneBuilder.body): this too
7 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
8 bring this up-to-date w.r.t. recent refactorings, and fix
9 redirections to bounce the browser to the top page after hitting
10 the 'force' button. This needs to be improved, but at least it now
11 redirects to a valid page.
12 (StatusResourceBuilder.ping): same
13 (StatusResourceBuilder.getChild): same, although I think this code
16 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
17 a branch= query argument, to filter the display down to builds and
18 changes that involve the given branch. You can add multiple
19 branch= arguments to see multiple branches (using a logical OR).
20 Note that there is no way to include the default branch (i.e.
21 None, i.e. trunk) yet, there is still work to be done to allow for
22 simple+uniform names of branches (i.e. removing the VC-specific
23 details of how branches are implemented, so calling the branch
24 'beta4' even though the SVN checkout step requires
26 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
27 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
28 * buildbot/interfaces.py (IEventSource.eventGenerator): same
29 * docs/buildbot.texinfo (Buildbot Web Resources): document it
31 * all: bring import statements up-to-date: don't import
32 __future__, assume cPickle and cStringIO are always available.
33 Also remove #!/usr/bin/python lines from non-scripts, my editor
34 has been a bit over-enthusiastic about stuffing them into new .py
37 * buildbot/status/web/index.html: put a link to the waterfall page
38 on the index, otherwise first-time users of WebStatus aren't going
39 to see anything very interesting.
41 * buildbot/interfaces.py (IEventSource): document this interface.
42 Thanks to Dustin Mitchell for the patch. Closes #60.
43 * buildbot/status/builder.py (BuilderStatus): same
44 * buildbot/changes/changes.py (ChangeMaster): same
46 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
47 add a query arg of 'show_events=true' to display non-build events,
48 like slaves attaching/detaching and reconfig events, or
49 'show_events=false' to hide them. The default is 'true'.
50 * docs/buildbot.texinfo (Buildbot Web Resources): document it
52 * web-parts: merge in web-parts branch. Lots of changes. The new
53 functionality is to add buildbot.status.html.WebStatus, which is a
54 superset of the Waterfall that adds new status pages and serves
55 regular files from BASEDIR/public_html/ , which is now the preferred
56 place to put robots.txt, buildbot.css, and index.html .
57 * buildbot/scripts/runner.py: the 'create-master' command now
58 creates public_html/ too, and populates it with a couple of
60 * buildbot/status/web: split waterfall code into smaller pieces
62 2007-07-31 Brian Warner <warner@lothar.com>
64 * buildbot/scripts/startup.py (launch): import twistd.run in a
65 different way to hush pyflakes
66 * buildbot/process/builder.py: remove unused import
68 2007-07-30 Brian Warner <warner@lothar.com>
70 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
71 Mitchell: pass SourceStamps around rather than branch/version/etc
72 tuples. Thanks Dustin! Closes #70.
73 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
74 tuple rather than a list, to avoid surprising mutations
75 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
76 * buildbot/status/mail.py (MailNotifier.buildMessage): same
77 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
78 * buildbot/test/test_status.py (Subscription): same
79 * buildbot/test/test_control.py (Force): same
80 * buildbot/test/test_buildreq.py (Request.testMerge): same
82 2007-07-29 Brian Warner <warner@lothar.com>
84 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
85 variable, since it wasn't used and is confusing in the presence of
86 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
89 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
90 the Buildbot home-page link to point at buildbot.net instead of
91 sourceforge, and add a current-version query parameter so we can
92 get some statistics on which versions are in use out there.
94 2007-07-28 Brian Warner <warner@lothar.com>
96 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
97 with c['change_source'], leaving c['sources'] for backwards
98 compatibility (but deprecated), scheduled for removal in 0.8.0
99 * docs/buildbot.texinfo: same
100 * buildbot/test/test_config.py: verify that c['sources'] still works
101 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
102 * buildbot/scripts/sample.cfg: update to match
104 * buildbot/changes/mail.py (MaildirSource): parse with python's
105 stdlib 'email' module, which has been available since python2.2,
106 and drop use of the 'rfc822' module, which has been depreceated
108 * buildbot/test/test_maildir.py: same: use parse_file() not parse
110 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
111 this needs to match the renaming in test/mail/msg*
113 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
116 * buildbot/test/test_mailparse.py: rename sample emails a bit
117 * buildbot/test/mail/msg*: same
119 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
120 parser for the "commit-email.pl" script that is shipped with SVN,
121 written by Justin Mason. Thanks! Closes SF#1072845.
122 * buildbot/test/mail/svn-commit.*: sample messages
123 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
124 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
126 2007-07-27 Brian Warner <warner@lothar.com>
128 * buildbot/changes/mail.py: refactor: move parsing into a method
129 named 'parse', each parser type gets a separate subclass. Remove
130 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
131 to be a simple leading-substring match. Add a warning to the logs
132 if prefix= does not end in a slash, since that's probably a
133 mistake. Fix both places where a prefix= mismatch would skip all
134 subsequent files in the same email, instead of just skipping the
135 one that didn't match.
136 * buildbot/test/test_mailparse.py: match changes
138 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
139 docs on email-based ChangeSources
141 * docs/buildbot.texinfo (Getting Source Code Changes): move all
142 the changesource types up a level, removing the one-entry menu in
145 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
146 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
147 instances instead of tuples. Closes #63.
148 * buildbot/slave/__init__.py (BuildSlave): define marker class
149 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
150 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
151 * buildbot/test/test_*.py: update tests to match
152 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
153 the c['bots'] backwards-compatibility handler works
155 2007-07-26 Brian Warner <warner@lothar.com>
157 * buildbot/changes/hgbuildbot.py (hook): add an in-process
158 Mercurial change-sending hook, contributed by Frederic Leroy.
159 Thanks! Addresses #50.
160 * docs/buildbot.texinfo (MercurialHook): document it
162 * buildbot/changes/hgbuildbot.py: change the way imports are done,
163 to make it compatible with at least hg-0.9.1 and the current 0.9.4
165 2007-07-17 Brian Warner <warner@lothar.com>
167 * buildbot/process/buildstep.py (BuildStep.getLog): add a
168 convenience method to retrieve a log added with
169 addLog()/addCompleteLog()/etc or logfiles= . I should have added
172 2007-07-03 Brian Warner <warner@lothar.com>
174 * buildbot/slave/commands.py (ShellCommand._startCommand): when
175 logging the environment variables, put one variable on each line,
176 rather than having one really long line with all of them. This
177 should make them a bit more readable and not trigger the
178 horizontal scrollbar (when viewing it in a web browser) quite so
179 much. Thanks to Albert Hofkamp for the patch.
181 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
182 WithProperties instance. Thanks to Axel Hecht for the patch.
184 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
185 * docs/buildbot.texinfo (Build Properties): document it
186 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
187 workdir if it didn't already exist.
189 * docs/buildbot.texinfo (Scheduler Types): correct the description
190 of Dependent schedulers. Thanks to Greg Ward for the patch.
192 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
193 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
194 the patch. Closes #49.
196 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
197 0700 before removing it, to deal with situations where a build will
198 leave files around without write permissions and the 'copy' or
199 'clobber' VC checkout modes need to blow away the tree first.
200 Thanks to Steve Milner for the suggestion and the patch (which I
201 mangled horribly). Closes #29.
202 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
205 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
206 an allowReconnect= argument to let callers control whether they
207 want this don't-let-it-reconnect behavior, since some tests care.
208 Factor out the .continueTrying=False lines from those callers.
209 * buildbot/test/test_slaves.py: same
210 * buildbot/test/test_run.py: same
212 2007-07-02 Brian Warner <warner@lothar.com>
214 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
215 slave has been disappeared, don't let it reconnect. This was
216 causing an intermittent failure in test_slaves.py, when the slave
217 that was supposed to be gone managed to come back by the end of
218 the test and affect the count.
219 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
221 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
222 diagnostic messages to track down this problem
223 (Builder.startBuild): same
225 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
226 the slave randomly rather than always taking the first one. Thanks
227 to Pike for the patch. Closes #36.
228 * buildbot/test/test_slaves.py: match the change. to avoid huge
229 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
230 enables/disables the round-robin-ness (enabled by default), and
231 some unit tests disable it.
232 * docs/buildbot.texinfo (Buildmaster Architecture): document it
234 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
235 argument to 'buildmaster_host', to make it more obvious that this
236 points to the buildmaster. Thanks to Bob Proulx for the
238 * buildbot/scripts/runner.py (slaveTAC): same
239 * buildbot/test/test_runner.py (Create.testSlave): match the change
241 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
244 2007-06-17 Brian Warner <warner@lothar.com>
246 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
247 we can round-trip all of our current step classes by calling
248 getStepFactory() and using the results to make a clone of the
251 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
254 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
255 the config file, we're moving to using actual instances instead of
256 the (class, kwargs) 'step specification' tuples. BuildFactory
257 still keeps a list of tuples internally, but when real instances
258 are passed in to addStep(), they are asked for their class and
259 kwargs using the new BuildStep.getStepFactory method. BuildFactory
260 accepts both instances and the tuple form, and converts instances
261 to the tuple form, but the instance form is preferred because it
262 gives the Steps a chance to do argument validation. Closes: #11.
264 * buildbot/process/buildstep.py (BuildStep.__init__): record the
265 factory information necessary to implement getStepFactory. The
266 addFactoryArguments() method can be used to include arguments that
267 aren't passed to the BuildStep base class constructor.
268 (BuildStep.setBuild):
269 (BuildStep.setDefaultWorkdir): new methods to take parameters that
270 are needed for live BuildSteps but not to construct the specification
271 tuples that are stashed in the factory.
273 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
274 'workdir' into new BuildSteps by using methods instead of
275 arguments. This makes the constructor for BuildSteps a lot
278 * buildbot/steps/*.py: update to match this change. Basically this
279 means adding calls to addFactoryArguments() in the __init__
280 methods to capture the arguments that aren't passed through to the
282 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
283 the new workdir (if any) into the RemoteShellCommands arguments.
284 * buildbot/steps/source.py: allow workdir= to be optional,
285 implement setDefaultWorkdir() since we don't inherit from
286 (CVS): finally remove old clobber=/export=/copydir= arguments,
287 in favor of the mode= argument that's been around forever now.
288 * buildbot/steps/transfer.py: remove build= argument
290 * buildbot/test/*.py: update to match, generally by turning all
291 build= arguments into subsequent calls to s.setBuild()
292 * buildbot/test/test_config.py (Factories): verify that we can
293 use either BuildStep instances or class/kwarg tuples in both
294 BuildFactory.addStep and BuildFactory.__init__
296 * docs/buildbot.texinfo (Build Steps): document the new approach,
297 mention compatibility with the old approach, update all examples
298 to use the new style.
300 2007-06-16 Brian Warner <warner@lothar.com>
302 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
303 the LoopingCall, just eat the failure so that we'll poll again
304 next time. This should allow us to tolerate (e.g.) sf.net SVN
305 failures more gracefully. Many thanks to Dustin Mitchell for the
308 2007-05-17 Brian Warner <warner@lothar.com>
310 * buildbot/status/words.py: refactor the IRC status bot into
311 separate 'Contact' and 'Channel' classes. The base Contact class
312 contains the interaction code: commands and responses. The
313 IRCContact subclass (and IrcStatusBot 'Channel') handle the
314 IRC-specific aspects. The plan is to write other subclasses for
315 other IM protocols like AIM and Jabber.
317 2007-04-16 Brian Warner <warner@lothar.com>
319 * CREDITS: update list of contributors. Thank you all!
321 2007-04-13 Brian Warner <warner@lothar.com>
323 * buildbot/status/mail.py (MailNotifier): add the project name to
324 the subject line and message body, to make it easier to
325 distinguish email coming from different buildmasters. Thanks to
326 Benoit Sigoure for the patch.
327 * buildbot/test/test_status.py (Mail): update to match
329 2007-03-24 Brian Warner <warner@lothar.com>
331 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
332 avoid text-conversion problems between DOS/windows and unix.
333 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
335 2007-03-03 Brian Warner <warner@lothar.com>
337 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
338 warning about the use of Waterfall here
340 2007-03-01 Brian Warner <warner@lothar.com>
342 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
344 2007-02-28 Brian Warner <warner@lothar.com>
346 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
347 Lamb to use a more optimal form of 'p4 changes', to reduce server
348 load. He reports that this optimization was added to p4d release
349 2005.2, but it should work in all versions. Closes #27.
350 * buildbot/test/test_p4poller.py: match it
352 2007-02-27 Brian Warner <warner@lothar.com>
354 * buildbot/status/web/*.py: move all web status stuff into a
355 separate directory, in anticipation of splitting it into smaller
356 pieces and adding more files. html.py was getting way too big.
357 * buildbot/status/classic.css: move it too
358 * setup.py: add the new sub-package
359 * buildbot/test/test_web.py: match the changes
360 * MANIFEST.in: handle the move of classic.css
362 2007-02-07 Brian Warner <warner@lothar.com>
364 * contrib/OS-X/*: add some launchd .plist files for automatically
365 starting a buildmaster or buildslave under OS-X (10.4 or later).
366 Thanks to Mark Pauley for these.
368 2007-02-06 Brian Warner <warner@lothar.com>
370 * docs/buildbot.texinfo (Requirements): update requirements to
371 stop claiming compatibility with python-2.2 or twisted-1.3.x .
373 * README: mention python-2.5 and twisted-2.5 compatibility
375 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
377 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
379 * buildbot/status/builder.py: same, by requiring cStringIO
380 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
381 * buildbot/test/test_vc.py: same
382 * buildbot/test/test_web.py:
383 * buildbot/test/test_steps.py: same, remove unused import
385 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
388 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
389 see any Builders that don't have Schedulers to drive them
391 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
392 attributes this uses went away
394 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
395 dialog, to allow you to reset the buildmaster and force
396 connect/disconnect. Correctly handle losing the buildmaster
397 connection (by switching the display to the hexnut, at which point
398 you can use the 'Connect' menu item to reconnect).
400 * buildbot/steps/source.py (Source.start): if we're using a patch,
401 add it as a LogFile to the checkout/update step. This will turn
402 into a link on the waterfall page.
404 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
405 option, to take the patch from a pre-made file rather than
406 generating it from the local tree. Thanks to Robert Helmer for the
407 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
408 * buildbot/scripts/runner.py (TryOptions): add --diff,
409 --patchlevel, and --baserev options
410 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
411 as None, meaning HEAD.
412 * buildbot/sourcestamp.py (SourceStamp): update docstring to
413 indicate that baserev=None means HEAD
414 * docs/buildbot.texinfo (try --diff): document it
416 * buildbot/test/test_steps.py (BuildStep): remove use of
417 reactor.iterate(), although the technique I replaced it with is a
418 gross polling hack that must be cleaned up properly some day. This
419 was the last use of reactor.iterate in the entire tree, yay.
421 2007-02-05 Brian Warner <warner@lothar.com>
423 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
424 is one of the three known values, otherwise we emit some confusing
425 messages later on. Thanks to Grig Gheorghiu for the catch.
427 2007-01-30 Brian Warner <warner@lothar.com>
429 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
430 Hearsum contributed a patch to let BonsaiPoller work with results
431 that contain non-ascii characters. Closes SF#1632641.
433 2007-01-27 Brian Warner <warner@lothar.com>
435 * Makefile (release): produce both .tar.gz and .zip source bundles.
438 2007-01-23 Brian Warner <warner@lothar.com>
440 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
441 * buildbot/changes/monotone.py: same
443 * buildbot/changes/maildir.py: combine several files into one,
444 clean up maildir.py to use Services properly.
445 * buildbot/changes/maildirtwisted.py: remove
446 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
448 * buildbot/changes/mail.py: match the change
449 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
450 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
452 * buildbot/slave/commands.py (command_version): bump to "2.3" to
453 indicate that the buildslave knows about the 'bzr' command
455 2007-01-22 Brian Warner <warner@lothar.com>
457 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
458 'with', it will become a reserved work in python2.6 .
460 * contrib/bb_applet.py: add a simple gnome-panel applet, to
461 display a terse summary of buildbot status.
462 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
463 some icons, small versions of the Blender object that lives in
464 docs/images/icon.blend
466 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
467 * buildbot/slave/commands.py (Bzr): same
468 * buildbot/scripts/tryclient.py (BzrExtractor): same
469 (SourceStampExtractor.dovc): modify this to allow non-zero exit
470 status, since 'bzr diff' does that
471 * buildbot/test/test_vc.py (Bzr): same
472 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
476 2007-01-20 Brian Warner <warner@lothar.com>
478 * contrib/darcs_buildbot.py: tidy up the progress messages
480 2007-01-17 Brian Warner <warner@lothar.com>
482 * contrib/darcs_buildbot.py: enhance to handle multiple patches
483 being pushed at a time. This keeps state in the repository in a
484 small file named .darcs_buildbot-lastchange, but that shouldn't
485 interfere with normal repository operations. Fixes SF#1534049.
486 * buildbot/clients/sendchange.py (Sender): make a single Sender
487 capable of sending Changes with different usernames.
489 2006-12-11 Brian Warner <warner@lothar.com>
491 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
492 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
493 buildbot.changes.mail a long time ago, but I forgot to add the
494 DeprecationWarning until now.
496 * buildbot/process/maxq.py: remove this, the functionality now
497 lives in buildbot.steps.maxq
499 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
500 * buildbot/clients/gtkPanes.py: remove unused import
502 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
503 that was meant to provide a special Reporter to run inside trial
504 and give the buildslave lots of machine-readable status. We never
505 finished this project.
507 * buildbot/changes/bonsaipoller.py: remove unused imports
508 * buildbot/changes/svnpoller.py: same
509 * buildbot/process/builder.py: same
510 * buildbot/process/buildstep.py: same
511 * buildbot/slave/bot.py: hush pyflakes warning
512 * buildbot/status/tests.py: remove unused imports
513 * buildbot/status/tinderbox.py: same
514 * buildbot/steps/python_twisted.py: same
516 * buildbot/process/step.py: remove this file, these names were
517 deprecated in 0.7.5 and are now being removed.
518 * buildbot/process/step_twisted.py: same
519 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
521 * buildbot/twcompat.py: remove the empty file, yay it is gone
523 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
524 tw-2.0.0 and newer have the method we need.
525 (getProcessOutputAndValue): same
526 (which): remove this method, tw-2.0.0 t.p.procutils has it
528 * buildbot/twcompat.py (implements): remove this method
529 * buildbot/*: import implements() from zope.interface directly
531 * buildbot/status/mail.py: stop falling back to importing
532 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
535 * buildbot/twcompat.py (Interface): remove this import
536 * buildbot/*: import Interface from zope.interface directly
538 * buildbot/twcompat.py (providedBy): remove this method
539 * buildbot/*: turn all uses of providedBy(obj, iface) into
540 iface.providedBy(obj)
542 * buildbot/twcompat.py (maybeWait): remove this method, now that
543 we no longer maintain compatibility with Twisted<=1.3.0 .
544 Twisted-2.0.0 and later allow trial methods to return Deferreds
546 * buildbot/test/*: remove all uses of maybeWait
548 * buildbot/__init__.py (version): bump to 0.7.5+ while between
550 * docs/buildbot.texinfo: same
552 2006-12-10 Brian Warner <warner@lothar.com>
554 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
555 * docs/buildbot.texinfo: set version to match
557 2006-12-10 Brian Warner <warner@lothar.com>
559 * README (REQUIREMENTS): update for release
560 * NEWS: update for release
561 * buildbot/slave/commands.py (command_version): mention that this
562 version (2.2) was released with buildbot-0.7.5
564 * buildbot/test/test_config.py (StartService.testStartService):
565 inhibit the usual read-config-on-startup behavior, since otherwise
566 the log.err that gets recorded causes the test to fail
568 * buildbot/status/builder.py (LogFile.finish): forget about all
569 subscribers once the log has finished, since after that point
570 we're never going to use them again. This might help free up some
573 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
574 than the old/deprecated gtk.mainquit()
576 2006-12-09 Brian Warner <warner@lothar.com>
578 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
579 better when we can't open the masterdst file
581 * buildbot/scripts/startup.py (Follower._failure): add missing
582 import statement for BuildSlaveDetectedError
584 * buildbot/steps/transfer.py (FileUpload): cleanup
585 (FileDownload): same. Add tests for slave version, add mode=.
586 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
587 (SlaveFileDownloadCommand): same
588 * buildbot/test/test_transfer.py: enhance tests
589 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
592 2006-12-08 Brian Warner <warner@lothar.com>
594 * buildbot/scripts/runner.py (sendchange): halt the reactor on
595 both success *and* failure. Without this, the 'buildbot
596 sendchange' command would hang if it could not contact the
597 buildmaster or deliver the Change, which would generally cause the
598 user's commit/record/checkin command to hang too. Thanks to
599 Christian Unger for the catch.
601 2006-12-06 Brian Warner <warner@lothar.com>
603 * NEWS: update with items for the next release
605 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
606 whimsical example pulled from a punch-drunk email I sent out late
608 (Transferring Files): document some of the other parameters
609 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
610 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
611 * buildbot/test/test_svnpoller.py: same
612 * buildbot/changes/svnpoller.py (SVNPoller): same
614 2006-11-26 Brian Warner <warner@lothar.com>
616 * docs/buildbot.texinfo (Build Properties): remind users that
617 WithProperties must appear in a command= list, not as a top-level
619 * buildbot/steps/shell.py (ShellCommand.start): and assert that
620 we're sending a list or a single string to the RemoteShellCommand
622 * buildbot/scheduler.py (Nightly): Improve docs slightly.
624 * buildbot/scripts/startup.py (start): skip the whole
625 watch-the-logfile thing under windows, since it needs os.fork()
627 * buildbot/scripts/runner.py (restart): remove the old message
628 that got printed after the buildbot was restarted.. it most cases
629 it didn't get printed at the right time anyways
631 2006-11-25 Brian Warner <warner@lothar.com>
633 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
634 follow twistd.log and print lines until the process has started
635 started properly. For the buildmaster, this means until the config
636 file has been parsed and accepted. For the buildslave, this means
637 until we've connected to the master. We give up after 5 seconds in
638 any case. Helpful error messages and troubleshooting suggestions
639 are printed when we don't see a successful startup. This closes the
640 remainder of SF#1517975.
641 * buildbot/scripts/startup.py: moved app startup code to here
642 * buildbot/scripts/logwatcher.py: utility class to follow log
643 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
644 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
645 so the LogWatcher can tell the difference between a buildmaster
648 2006-11-24 Brian Warner <warner@lothar.com>
650 * docs/examples/twisted_master.cfg: update to match the version
651 in use on twistedmatrix.com
652 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
653 was using before stopped working, but 'irc.freenode.net' works
656 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
659 * buildbot/clients/base.py (TextClient.not_connected): upon
660 UnauthorizedLogin failures, remind the user to connect to the
661 PBListener port instead of the slaveport.
662 (TextClient.disconnected): shut down more quietly
663 * docs/buildbot.texinfo (statuslog): add another reminder
665 * buildbot/scripts/runner.py (Options.subCommands): rename
666 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
667 'sighup' as an alias.
668 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
669 reconfig command to follow twistd.log and print all of the lines
670 from the start of the config-file reload to its completion. This
671 should make it a lot easier to discover bugs in the config file.
672 Use --quiet to disable this behavior. This addresses half of
673 SF#1517975, the other half will be to add this same utility to
674 'buildbot start' and 'buildbot restart'.
675 * docs/buildbot.texinfo (Loading the Config File): same
678 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
679 method, it has been deprecated for a long time. Use
680 IBuilderControl.requestBuild instead.
681 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
682 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
683 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
684 * buildbot/test/test_control.py (Force.testForce): same
685 * buildbot/test/test_run.py: use requestBuild instead
687 * buildbot/clients/debug.py: replace 'Force Build' button with
688 'Request Build' (which just adds one to the queue), add Ping
689 Builder, add branch/revision fields to Request Build.
690 * buildbot/clients/debug.glade: same
691 * buildbot/master.py: update interface to match. This creates an
692 incompatibility between new debugclients and old buildmasters.
694 * buildbot/process/builder.py (Builder._attached): delay the call
695 to maybeStartBuild for a reactor turn, to avoid starting a build
696 in the middle of a reconfig (say, if the new Builder uses a new
697 slave which is already connected).
699 2006-11-23 Brian Warner <warner@lothar.com>
701 * buildbot/test/test_transfer.py: appease pyflakes
702 * buildbot/test/test_steps.py: same
704 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
705 keeps pyflakes from finding undefined names
707 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
708 Builder no longer induces a disconnect/reconnect cycle. This means
709 that any builds currently in progress will not be interrupted, and
710 any builds which are queued in the Builder will not be lost. This
711 is implemented by having the new Builder extract the state (i.e.
712 all pending Builds and any desired SlaveBuilders) from the old
714 (BotPerspective): refactor. The BotPerspective no longer keeps
715 track of all the Builders that want to use this slave; instead, it
716 asks the BotMaster each time it needs this list. This removes
717 addBuilder and removeBuilder. Clean up attached() to acquire all
718 the slave's information in a more atomic fashion. updateSlave() is
719 now the way to make sure the slave is using the right set of
720 Builders: just call it after everything else has been
722 (BotMaster): refactor, removing addBuilder/removeBuilder and
723 replacing them with an all-at-once setBuilders() call.
725 * buildbot/test/test_slaves.py (Reconfig): new test case to
726 exercise this functionality
727 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
728 * buildbot/slave/commands.py (WaitCommand): same
730 * docs/buildbot.texinfo (Loading the Config File): document the
733 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
734 SlaveBuilder to have its parent Builder changed.
735 (SlaveBuilder.isAvailable): new method to give access to state,
736 which is now a private attribute
737 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
738 the SlaveBuilder about how it is being used. These methods update
739 its internal state. buildFinished() is now the place that invokes
740 maybeStartBuild() on its parent Builder.
741 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
742 new Builder to take over for an old one, transferring state from
744 (Buider): refactor the way that SlaveBuilders are used to match,
745 giving them a bit more autonomy.
746 (Builder.buildFinished): this no longer calls maybeStartBuild():
747 instead the SlaveBuilder calls it on whoever its parent Builder is
748 at the time. This way, when an old Builder is replaced by a new
749 one, and there was a build in progress during the transition, when
750 that build finishes, it will be the new Builder that is told about
751 the newly available slave so it can start a new build.
753 * buildbot/process/base.py (Build.startBuild._release_slave): when
754 the Build finishes, tell the SlaveBuilder that they've been
757 * buildbot/status/builder.py (SlaveStatus): add some new setter
758 methods for use by BotPerspective, to keep some attributes more
761 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
762 called by the buildmaster.
763 (Bot.setBuilderList): instead, we locally announce any leftover
764 directories based upon which Builders we were told about. The
765 master doesn't really care; it's the local admin who may or may not
769 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
770 to allow use of python2.4 or whatever. This tool still requires
773 2006-11-19 Brian Warner <warner@lothar.com>
775 * NEWS (IStatusLog.readlines): more news items
777 2006-11-18 Brian Warner <warner@lothar.com>
779 * NEWS: start collecting items for the next release.
781 2006-11-04 Brian Warner <warner@lothar.com>
783 * buildbot/changes/bonsaipoller.py: apply updates from Ben
784 Hearsum. Closes SF#1590310.
785 * buildbot/test/test_bonsaipoller.py: and tests
787 * buildbot/status/tinderbox.py
788 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
789 status when the build results in WARNINGS. Patch from Dave
790 Liebreich. Closes SF#1587352.
792 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
793 linux-vs-osx behavior difference w.r.t. reading from files that
794 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
795 to Mark Rowe for the patch.
797 2006-10-15 Brian Warner <warner@lothar.com>
799 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
800 method name was misspelled in the interface definition. Thanks to
801 Roy Rapoport for the catch.
803 2006-10-13 Brian Warner <warner@lothar.com>
805 * docs/buildbot.texinfo (Adding LogObservers): update sample code
806 to match the great Steps renaming
808 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
809 Maybe I should run my own unit tests before recording a big
810 change. Good thing I've got a buildbot to remind me.
812 2006-10-12 Brian Warner <warner@lothar.com>
814 * buildbot/steps/transfer.py: rework __init__ and args setup
815 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
817 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
818 when opening the target file, only catch IOError (to report via
819 stderr/rc!=0), let the others be reported as normal exceptions
821 2006-10-08 Brian Warner <warner@lothar.com>
823 * contrib/svn_watcher.py: fix security holes by using proper argv
824 arrays and subprocess.Popen() rather than commands.getoutput().
825 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
826 is deprecated in favor of buildbot/changes/svnpoller.py, and will
827 probably be removed by the next release.
830 2006-10-04 Brian Warner <warner@lothar.com>
832 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
833 initial lines that weren't emitted by pyflakes. When the pyflakes
834 command is run under a Makefile, 'make' will echo the command it
835 runs to stdio, and that was getting logged as a "misc" warning.
836 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
837 * buildbot/test/test_steps.py (testPyFlakes3): another test
839 2006-10-01 Brian Warner <warner@lothar.com>
841 * buildbot/status/html.py (HtmlResource.render): if we get a
842 unicode object from our content() method, encode it into utf-8
843 like we've been claiming to all along. This allows the comments
844 and author names from svnpoller.py to be delivered properly.
846 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
847 de-unicodify filenames before creating the Change, because the
848 rest of buildbot is unlikely to handle them well. Leave the 'who'
849 field as a unicode object.. I don't think there's anything that
850 will break very soon, and it will probably nudge us towards
851 accepting unicode everywhere sooner or later. Stop using the
852 "date" field that comes out of SVN, since it is using the
853 repository's clock (and timezone) and what we care about is the
854 buildmaster's (otherwise Changes from the future show up later
855 than the builds they triggered).
856 * buildbot/test/test_svnpoller.py (Everything.test1): match the
859 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
860 Suvbersion repository polling ChangeSource. I've hacked it up
861 considerably: any bugs are entirely my own fault. Thank you
863 * buildbot/test/test_svnpoller.py: tests for it
864 * docs/buildbot.texinfo (SvnSource): document it
866 2006-09-30 Brian Warner <warner@lothar.com>
868 * buildbot/scheduler.py (Periodic): submit a reason= to the
869 BuildSet to indicate which Scheduler triggered the build. Thanks
870 to Mateusz Loskot for the suggestion.
872 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
874 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
875 changes: set self.loop in __init__, remove unused volatile=
877 * docs/buildbot.texinfo (.buildbot config directory): add more
878 docs on the .buildbot/options keys used by "buildbot try"
879 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
880 (Try.deliverJob): same
882 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
886 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
887 close the filehandle when we stop watching the file. Before, the
888 filehandle was only closed when the LogFileWatcher was
889 garbage-collected, which could be quite a while in the future. If
890 it was still open by the time the next build started, windows will
891 refuse to let the new build delete the old build/ directory. Fixes
892 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
893 #twisted for the catch.
895 2006-09-29 Brian Warner <warner@lothar.com>
897 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
900 2006-09-25 Brian Warner <warner@lothar.com>
902 * setup.py: the new buildbot.steps module wasn't being installed.
903 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
904 (testmsgs): add the extra stuff from buildbot/test/* so you can
905 run unit tests on an installed copy of buildbot, not just from
908 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
909 columns of 'svnlook changed' output contain status information, so
910 strip [:4] instead of [:6]. Depending upon what the status flags
911 were, this would sometimes lead to mangled filenames. Thanks to
912 Riccardo Magliocchetti for the patch. Closes SF#1545146.
914 * buildbot/steps/source.py (Monotone): initial Monotone support,
915 contributed by Nathaniel Smith. Still needs docs and tests, but
916 this code has been in use on the Monotone buildbot for a long
918 * buildbot/slave/commands.py (Monotone): slave-side support
919 * buildbot/changes/monotone.py (MonotoneSource): polling change
922 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
923 contributed a Change Source that polls a Bonsai server (a
924 kind of web-based viewcvs CGI script).
926 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
927 Hearsum contributed a status plugin which sends email in the same
928 format that Tinderbox does: this allows a number of tinderbox
929 tools to be driven by Buildbot instead. Thanks Ben!
931 2006-09-24 Brian Warner <warner@lothar.com>
933 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
934 Thanks to Robert Helmer for the patch.
936 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
937 BuildStatus about the buildslave name at the *beginning* of the
938 build, rather than at the end. Thanks to Alexander Lorenz for the
940 * buildbot/status/html.py (StatusResourceBuild.body): always
941 include the slavename in the build page, not just when the build
943 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
944 slavename in the email message
946 2006-09-21 Brian Warner <warner@lothar.com>
948 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
950 * docs/examples/glib_master.cfg: same
951 * docs/examples/hello.cfg: same
952 * docs/examples/twisted_master.cfg: same, update to current usage
954 2006-09-19 Brian Warner <warner@lothar.com>
956 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
957 (PyFlakes.createSummary): make it compatible with python-2.2
959 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
960 for at least the output-parsing parts of PyFlakes
962 2006-09-18 Brian Warner <warner@lothar.com>
964 * buildbot/steps/python.py: oops, fix import of StringIO
966 2006-09-17 Brian Warner <warner@lothar.com>
968 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
969 turns out that SVN-1.4.0 doesn't fail to update once you've
970 replaced a file with a directory, unlike older versions of SVN and
971 pretty much every other VC tool we support. Since what we really
972 care about is that the update succeeds anyway, stop checking that
973 the tree got clobbered and just assert that the build succeeded.
974 (VCBase.printLogs): add a utility function for debugging
976 * buildbot/process/step.py: oops, added extra imports by mistake
978 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
979 rstrip() on the first line coming out of the 'p4 describe'
980 process, to remove the stray ^M that Wade Brainerd reports seeing
981 in the 'when' field. Fixes SF#1555985.
983 * buildbot/master.py (BuildMaster.loadConfig): improve the error
984 message logged when c['schedulers'] is not right
985 * buildbot/scheduler.py (Scheduler.__init__): improve error
986 message when a Scheduler() is created with the wrong arguments
987 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
988 verify that these error messages are emitted
990 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
991 The idea is that all the base classes (like BuildStep and
992 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
993 will be a leftover backwards-compatibility file that only contains
994 aliases for the steps that were moved out to buildbot.steps.*
995 * lots: change imports to match
996 * buildbot/process/step.py: add a DeprecationWarning if it ever
999 2006-09-12 Brian Warner <warner@lothar.com>
1001 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1002 builderNames= is actually a sequence, since if you happen to give
1003 it a single builder-specification dictionary instead, it won't get
1004 caught by the existing assert. Thanks to Brett Neely for the
1007 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1009 * docs/buildbot.texinfo (Python BuildSteps): document them
1010 (sendchange): include a link to PBChangeSource, since you need one
1012 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1014 * buildbot/steps/dummy.py: same
1016 2006-09-08 Brian Warner <warner@lothar.com>
1018 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1019 BuildStep which lets you transfer files from the master to the
1020 slave or vice versa. Thanks to Albert Hofkamp for the original
1021 patch. Fixes SF#1504631.
1022 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1024 (SlaveFileDownloadCommand): same
1025 * docs/buildbot.texinfo (Transferring Files): document it
1026 * buildbot/test/test_transfer.py: test it
1027 * buildbot/test/runutils.py (StepTester): new utility class for
1028 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1029 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1032 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1033 walk through StatusLogs one line at a time, mostly for the benefit
1034 of ShellCommand.createSummary methods. You can either walk through
1035 STDOUT or STDERR, but the default is STDOUT.
1037 * buildbot/status/builder.py (LogFile.readlines): implement it.
1038 Note that this is not yet memory-efficient, it just pulls the
1039 whole file into RAM and then splits it up with a StringIO.
1040 Eventually this should be a generator that only pulls chunks from
1042 * buildbot/test/test_status.py (Log.testReadlines): test it
1044 * docs/buildbot.texinfo: update to match changes
1045 * buildbot/process/factory.py: stop using old definitions
1046 * buildbot/process/process_twisted.py: same
1047 * buildbot/test/test_*.py: same
1049 * buildbot/process/step_twisted.py: move definition to..
1050 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1051 relative-import mechanisms prevent this from being named 'twisted'
1052 or 'python/twisted' as I would have preferred.
1054 * buildbot/process/maxq.py: move definition to..
1055 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1057 * buildbot/process/step.py: split the user-visible BuildSteps into
1058 separate files, all under buildbot/steps/
1059 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1060 * buildbot/steps/shell.py: this holds ShellCommand and friends
1061 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1063 2006-09-05 Brian Warner <warner@lothar.com>
1065 * lots: run pyflakes, removed a lot of unused imports, changed the
1066 form of some conditional imports to remove false pyflakes
1067 warnings. There are still a number of warnings left, mostly from
1068 imports that are done for their side-effects.
1069 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1072 2006-08-26 Brian Warner <warner@lothar.com>
1074 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1075 compatible with twisted-1.3.0, for some reason I just can't seem
1076 to let go of the past.
1078 2006-08-25 Brian Warner <warner@lothar.com>
1080 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1082 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1083 all logfiles= in startCommand(), rather than in start() . This
1084 makes it easier to have the 'stdio' log come before any secondary
1085 logfiles, which I feel makes the waterfall display more
1087 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1088 from ShellCommand up into LoggingBuildStep
1089 (LoggingBuildStep.__init__): move the handling of logfiles= from
1090 ShellCommand up to LoggingBuildStep, because startCommand is
1091 provided by LoggingBuildStep, whereas start() was specific to
1092 subclasses like ShellCommand and Source. This removes code
1093 duplication in those subclasses.
1094 (ShellCommand.__init__): same
1095 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1096 for a slave that's too old to understand logfiles= into a separate
1097 method, so it can live in ShellCommand. The rest of
1098 setupLogfiles() can live in LoggingBuildStep.
1100 2006-08-24 Brian Warner <warner@lothar.com>
1102 * buildbot/locks.py (BaseLock): you can now configure Locks to
1103 allow multiple simultaneous owners. They still default to
1104 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1106 * docs/buildbot.texinfo (Interlocks): document the new options
1107 * buildbot/test/test_locks.py: add a bunch of new unit tests
1108 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1109 waitUntilMaybeAvailable, not waitUntilAvailable
1110 * buildbot/process/step.py (BuildStep.acquireLocks): same
1111 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1112 the whole lockid in their constructor, not just the name. Also,
1113 keep track of which real locks we've handed out by the full
1114 lockid, not just class+name, otherwise changing just the maxCount=
1115 in the master.cfg file would not actually cause a behavioral
1118 2006-08-23 Brian Warner <warner@lothar.com>
1120 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1122 * docs/buildbot.texinfo: same
1124 2006-08-23 Brian Warner <warner@lothar.com>
1126 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1127 * docs/buildbot.texinfo: set version to match
1128 * NEWS: update for 0.7.4
1129 * buildbot/slave/commands.py (command_version): mention that this
1130 version (2.1) was released with buildbot-0.7.4
1132 2006-08-22 Brian Warner <warner@lothar.com>
1136 * CREDITS: new file, list of people who have helped. Thanks!
1137 * MANIFEST.in: ship it
1139 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1140 new diagrams, the user's manual is more informative than it was.
1141 Start shipping the .html user's manual (and generated .png
1143 * Makefile: update 'release' target to match
1145 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1146 test.. I think the web-parts effort will render it pointless well
1147 before it ever actually starts to work.
1149 2006-08-20 Brian Warner <warner@lothar.com>
1151 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1152 meaning of the prefix= argument. It is now just a string which is
1153 stripped from the beginning of the filename. If prefix= is set but
1154 not found on any given filename, that filename is ignored. If all
1155 filenames in a Change are ignored, the Change is dropped. This is
1156 much simpler than the previous sep= nonsense, and I should have
1157 implemented it this way from the beginning. Effectively resolves
1158 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1159 Gedminas for the catch and suggested fixes.
1160 (ChangePerspective.perspective_addChange): implement the actual
1162 * buildbot/test/test_changes.py (TestChangePerspective): test it
1163 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1164 how to properly use prefix=
1165 * docs/examples/twisted_master.cfg (source): update prefix= by
1166 adding the trailing slash
1169 * docs/examples/twisted_master.cfg: update to actual practice
1171 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1172 update test case to match new link text.. the HREF has both a
1173 class= setting and an enclosing [] pair that I didn't match in the
1176 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1177 list of strings is preferred over a single string with embedded
1179 (ShellCommand.description=): explain that either single strings or
1180 a list of strings is acceptable, and why you might prefer one over
1181 the other. Add an example. Fixes SF#1524659, thanks to Paul
1182 Winkler for the catch.
1183 (Build Steps): update to use f.addStep() rather than using s()
1184 and the constructor list
1186 * buildbot/process/step.py (ShellCommand): accept either a single
1187 string or a list of strings in both description= and
1189 * buildbot/test/test_steps.py (Steps.test_description): test it
1190 * buildbot/test/runutils.py (makeBuildStep): support for that test
1192 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1193 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1194 collecting the files and creating the patch.
1196 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1197 per-step URLs that will be displayed on the waterfall display,
1198 for things like the HTML output of code-coverage tools, when
1199 the results are hosted elsewhere.
1200 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1201 way to retrieve these URLs
1202 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1203 the method to retrieve these URLs. Also provide backwards
1204 compatibility for saved BuildStepStatus instances that didn't have
1206 * buildbot/process/step.py (BuildStep.addURL): method to set these
1207 URLs from within a BuildStep
1208 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1209 (StepBox.getBox): give these external links a distinct CSS class
1210 named "BuildStep external" so a .css file can display them
1213 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1215 * buildbot/test/test_steps.py (Steps): test that we can all the
1216 URLs. Also add a bunch of other tests on methods that can be
1217 called from within BuildSteps
1218 * buildbot/test/runutils.py (makeBuildStep): add utility function
1220 2006-08-13 Brian Warner <warner@lothar.com>
1222 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1224 2006-08-10 Brian Warner <warner@lothar.com>
1226 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1227 index, this one of things like c['sources'] and c['schedulers']
1228 (indices): it looks like my clever idea of putting the @fooindex
1229 commands in between the @node and the @subsection (to make the
1230 HREF anchor jump to slightly above the section title, which works
1231 much better in html) confused texinfo horribly, so I'm moving the
1232 index tags back to be just after the @subsection marker. I also
1233 added extra lines between the @node/@section paragraph and the
1234 index tags, since I think maybe texinfo wants to see these be
1235 separate paragraphs.
1237 * docs/Makefile (images): make sure images get built when
1238 rendering the manual
1239 * docs/images/Makefile: same
1241 * buildbot/scripts/runner.py: rename 'buildbot master' to
1242 'buildbot create-master', and 'buildbot slave' to 'buildbot
1244 * docs/buildbot.texinfo: same
1247 * docs/buildbot.texinfo: reimplement the "useful classes" index
1248 with actual texinfo indices. The .info rendering is a bit
1249 weird-looking but it works well, and the HTML rendering is quite
1250 nice. This also puts the index targets in the regular flow of the
1251 text, which is easier to maintain.
1253 2006-08-06 Brian Warner <warner@lothar.com>
1255 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1256 Kevin Turner to prefer the environ= argument be a list rather than
1257 a string. If it is a list, it will be joined with a platform-local
1258 os.pathsep delimiter, and then prepended to any existing
1259 $PYTHONPATH value. This works better in cross-platform (i.e.
1260 windows buildslaves) environments when you need to push multiple
1261 directories onto the front of the path.
1262 (SlaveShellCommand): documented the new magic
1263 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1264 in a user-visible form
1266 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1267 Turner to prefer lists over strings when creating/running VC
1268 commands during unit tests. This is clearly necessary to survive
1269 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1270 renamed the wq() function to qw() though, since that's how it's
1271 spelled in perl. Eventually I'd prefer all commands to be
1272 specified with lists.
1274 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1275 which are deleted (or not yet created) correctly. Also add
1276 failsafe code to not explode if the file-watching poller doesn't
1277 get started. Thanks to JP Calderone for the catch and the poller
1279 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1281 * buildbot/test/emitlogs.py: same
1283 * NEWS: summarize recent changes
1285 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1286 clause to avoid the "host key mismatch" warning
1288 * buildbot/process/step_twisted.py (Trial.start): if the
1289 buildslave is too old to understand logfiles=, fall back to
1290 running 'cat _trial_temp/test.log' like before.
1291 (Trial.commandComplete): same. this takes advantage of the
1292 LoggingBuildStep refactoring to stall commandComplete long enough
1293 to run a second RemoteShellCommand.
1295 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1296 refactor command-completion handling, to allow methods like
1297 commandComplete/createSummary/evaluateCommand to return Deferreds.
1298 (LoggingBuildStep._commandComplete): delete the refactored method
1299 (ShellCommand.setupLogfiles): if the buildslave is too old to
1300 understand logfiles=, put a warning message both into twistd.log
1301 and into the otherwise empty user-visible LogFiles.
1303 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1304 callers to provide the slave-side logfile name, rather than
1305 forcing it to come from the local name of the LogFile.
1306 (BuildStep.getSlaveName): new method
1308 * buildbot/process/base.py (Build.getSlaveName): new method, so
1309 steps can find out which buildslave they're running on
1311 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1312 to match the s/cvs_ver/command_version/ change
1314 2006-08-05 Brian Warner <warner@lothar.com>
1316 * buildbot/slave/commands.py (command_version): replace the CVS
1317 auto-updated cvs_ver keyword with a manually-updated variable,
1318 since CVS is no longer the master repository. Add a description of
1319 the remote API change starting in this version (2.1), specifically
1320 the fact that SlaveShellCommand now accepts 'initial_stdin',
1321 'keep_stdin_open', and 'logfiles'.
1323 2006-07-31 Brian Warner <warner@lothar.com>
1325 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1326 diagrams to describe how the whole system fits together. The
1327 images themselves are kept in SVG files, with ascii-art versions
1328 in corresponding .txt files. Texinfo knows how to interpolate the
1329 text version into .info files, reference the .png versions from
1330 .html files, and include .eps versions in the .ps format.
1331 * docs/images/Makefile: tools to create .png and .eps
1332 * docs/images/*.svg: created pictures with Inkscape.
1333 * .darcs-boring: ignore the generated .eps and .png files
1335 2006-07-24 Brian Warner <warner@lothar.com>
1337 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1338 Scheduler names, since they cause setServiceParent to explode
1340 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1342 2006-07-20 Brian Warner <warner@lothar.com>
1344 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1345 which runs the buildbot unit tests
1347 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1348 classes that are useful in master.cfg
1350 2006-07-15 Brian Warner <warner@lothar.com>
1352 * Makefile (some-apidocs): new target to build only some epydocs
1354 * setup.py: minor comment.. does the classifiers= argument prevent
1355 the setup.py script from working on python2.2/2.3?
1357 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1360 * buildbot/twcompat.py: fix minor typo in comments
1362 * buildbot/manhole.py: move all Manhole-related code out to this
1363 module. Implement SSH-based manholes (with TwistedConch), and move
1364 to conch's nifty line-editing syntax-coloring REPL shell instead
1365 of the boring non-editing monochromatic (and deprecated) old
1367 * buildbot/master.py: remove all Manhole-related code
1368 (BuildMaster.loadConfig._add): make sure the old manhole is
1369 removed before we add the new one
1370 * docs/buildbot.texinfo (Debug options): document new Manhole options
1372 * buildbot/twcompat.py (_which): fix some epydoc issues
1373 * buildbot/status/html.py (Waterfall.__init__): same
1375 2006-06-29 Brian Warner <warner@lothar.com>
1377 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1378 deprecation warnings under newer Twisteds (by using
1379 zope.interface.Interface instead of old twisted.python.components
1381 * buildbot/slave/interfaces.py: same
1383 2006-06-28 Brian Warner <warner@lothar.com>
1385 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1386 svn commands, so it will fail immediately instead of hanging while
1387 it waits for a username/password to be typed in.
1389 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1390 log message if the step was shut down
1392 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1393 obsolete reference to mktap.
1395 2006-06-20 Brian Warner <warner@lothar.com>
1397 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1398 test to include new 'logfiles' argument sent from master to slave
1400 2006-06-19 Brian Warner <warner@lothar.com>
1402 * buildbot/process/step_twisted.py (Trial): track Progress from
1403 _trial_temp/test.log too
1405 * buildbot/process/step.py (OutputProgressObserver): generalize
1406 the earlier StdioProgressObserver into an OutputProgressObserver
1407 that can track LogFiles other than stdio.
1408 (LoggingBuildStep.__init__): same
1410 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1411 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1412 will fail under windows because of os.sep issues. It might have
1413 worked before if 'cat' was doing cygwin path conversion.
1415 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1416 creation of LogFileWatchers
1417 (ShellCommand._startCommand): and record the files that were
1418 watched in the 'headers' section of the ShellCommand output
1420 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1421 need to actually pass it to the slave if you want it to work.
1422 (ShellCommand): document it a bit
1424 * buildbot/test/test_shell.py: new test to validate LogFiles
1425 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1427 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1428 before printing the last batch of lines, to test that the polling
1429 logic is working properly
1431 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1432 handling, making it possible to track multiple logs for a single
1433 RemoteCommand. The previous single logfile is now known as the
1435 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1436 (RemoteShellCommand.__init__): accept logfiles=
1437 (LoggingBuildStep.startCommand): stdio_log is now one of many
1438 (ShellCommand): added logfiles= argument, as well as a class-level
1439 .logfiles attribute, which will be merged together to figure out
1440 which logfiles should be tracked. The latter maybe be useful for
1441 subclasses of ShellCommand which know they will aways produce
1442 secondary logfiles in the same location.
1444 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1445 and closeStdin() methods, preparing to make it possible to write
1446 to a ShellCommand's stdin at any time, not just at startup. These
1447 writes are buffered if the child process hasn't started yet.
1448 (LogFileWatcher): new helper class to watch arbitrary logfiles
1449 while a ShellCommand runs. This class polls the file every two
1450 seconds, and sends back 10k chunks to the buildmaster.
1451 (ShellCommand): rename stdin= to initialStdin=, and add
1452 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1454 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1455 key of "log" and a value of (logname, data).
1456 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1457 'logfiles' to the master-visible args dictionary.
1458 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1461 * buildbot/test/test_vc.py (Patch.testPatch): same
1464 * buildbot/test/emit.py: write to a logfile in the current
1465 directory. We use this to figure out what was used as a basedir
1466 rather than looking to see which copy of emit.py gets run, so that
1467 we can run the commands from inside _trial_temp rather than inside
1469 * buildbot/test/subdir/emit.py: same
1470 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1471 argument rather than running from buildbot/test/
1472 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1473 rather than using an implicit setUp()
1474 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1475 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1476 of assuming that we're running in buildbot/test/ (and that '.' is
1479 * buildbot/slave/commands.py (Command.doStart): refactor Command
1480 startup/completion a bit: now the SlaveBuilder calls doStart(),
1481 which is not meant for overridding by subclasses, and doStart()
1482 calls start(), which is. Likewise the SlaveBuilder calls
1483 doInterrupt(), and subclasses override interrupt(). This also puts
1484 responsibility for maintaining .running in Command rather than in
1486 (Command.doInterrupt): same
1487 (Command.commandComplete): same, this is called when the deferred
1488 returned by start() completes.
1489 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1490 (SlaveBuilder.remote_interruptCommand): same
1491 (SlaveBuilder.stopCommand): same
1493 2006-06-16 Brian Warner <warner@lothar.com>
1495 * buildbot/test/test_shell.py: new test file to contain everything
1496 relating to ShellCommand
1497 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1498 multiple logfiles in realtime" feature, not yet implemented
1499 * buildbot/test/emitlogs.py: support file for testLogFiles
1500 * docs/buildbot.texinfo (ShellCommand): document the feature
1502 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1504 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1505 for tests which exercise SlaveCommands in isolation.
1507 * buildbot/test/test_slavecommand.py: Move some utilities like
1508 SignalMixin and FakeSlaveBuilder from here ..
1509 * buildbot/test/runutils.py: .. to here, so they can be used by
1510 other test classes too
1511 * buildbot/test/test_vc.py: more SignalMixin refactoring
1512 * buildbot/test/test_control.py: same
1513 * buildbot/test/test_run.py: and some rmtree refactoring
1515 2006-06-15 Brian Warner <warner@lothar.com>
1517 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1518 'testBranch' to match other VC tests and have the tests run in
1519 roughly increasing order of dependency
1521 * buildbot/test/test_steps.py (LogObserver): new test to verify
1522 LogObservers can be created at various times and still get
1523 connected up properly
1525 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1526 to create BuildStepStatus instances that actually work.
1528 * buildbot/process/step.py (LogObserver): add outReceived and
1529 errReceived base methods, to be overridden
1531 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1532 API to take a name instead of a step, reducing the coupling
1533 somewhat. This returns the BuildStepStatus object so it can be
1534 passed to the new Step, instead of jamming it directly into the
1536 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1538 * buildbot/process/base.py (Build.setupBuild): use both methods
1539 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1540 process a bit to match
1542 2006-06-14 Brian Warner <warner@lothar.com>
1544 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1545 docs on writing new LogObserver classes
1546 (Writing New Status Plugins): brief docs on how Status Plugins fit
1549 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1550 implement a LogObserver that counts how many unit tests have been
1552 (Trial.__init__): wire it in
1553 * buildbot/test/test_twisted.py (Counter): unit test for it
1555 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1556 to new cmd.logs['stdio'] scheme
1557 (Trial.commandComplete): same
1558 (BuildDebs.commandComplete): same
1560 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1561 LogFiles, instead of just a single one. The old single logfile is
1562 now called "stdio". LoggedRemoteCommand no longer creates a
1563 LogFile for you (the code to do that was broken anyway). If you
1564 don't create a "stdio" LogFile, then stdout/stderr will be
1566 (LogObserver): implement "LogObservers", which a BuildStep can add
1567 to parse the output of a command in real-time. The primary use is
1568 to provide more useful information to the Progress code, allowing
1569 better ETA estimates.
1570 (LogLineObserver): utility subclass which feeds complete lines to
1571 the parser instead of bytes.
1572 (BuildStep.progressMetrics): this is safer as a tuple
1573 (BuildStep.setProgress): utility method, meant to be called by
1575 (BuildStep.addLogObserver): new method, to be called at any time
1576 during the BuildStep (even before any LogFiles have been created),
1577 to attach (or schedule for eventual attachment) a LogObserver to a
1579 (StdioProgressObserver): new LogObserver which replaces the old
1580 "output" progress gatherer
1581 (LoggingBuildStep.__init__): same
1582 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1583 (LoggingBuildStep._commandComplete): must use logs['stdio']
1584 instead of the old single ".log" attribute.
1585 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1586 functionality, now subsumed into StdioProgressObserver
1587 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1588 log name changed from "output" to "stdio".
1591 * buildbot/interfaces.py (ILogFile): add the Interface used from
1592 the BuildStep towards the LogFile
1593 (ILogObserver): and the one provided by a LogObserver
1594 * buildbot/status/builder.py (LogFile): implement it
1596 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1597 HEADER constants here ..
1598 * buildbot/status/builder.py (STDOUT): .. from here
1600 2006-06-13 Brian Warner <warner@lothar.com>
1602 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1603 compatibility with python2.2, which doesn't have the 'substr in
1605 (TestP4Poller.makeTime): utility function to construct the
1606 timestamp using the same strptime() approach as p4poller does. It
1607 turns out that time.mktime() behaves slightly differently under
1608 python2.2, probably something to do with the DST flag, and that
1609 causes the test to fail under python2.2. (changing the mktime()
1610 arguments to have dst=0 instead of -1 caused it to fail under
1611 python2.3. Go figure.)
1612 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1614 2006-06-12 Brian Warner <warner@lothar.com>
1616 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1617 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1618 contributing such an excellent patch, including docs and unit
1619 tests! This makes it *so* much easier to apply. I had to update
1620 test_vc.py to handle some recent refactorings, but everything else
1621 applied smoothly. The only remaining thing I'd like to fix would
1622 be to remove the hard-wired port 1666 used by p4d, and allow it to
1623 claim any unused port. This would allow two copies of the test
1624 suite to run on the same host at the same time, as well as
1625 allowing the test suite to run while a real (production) p4d was
1626 running on the same host. Oh, and maybe we should add a warning to
1627 step.P4 that gets emitted if the slave is too old to provide the
1628 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1629 * buildbot/slave/commands.py (P4): same
1630 (P4Sync): same, some minor updates
1631 * buildbot/changes/p4poller.py: same
1632 * docs/buildbot.texinfo: same
1633 * buildbot/test/test_p4poller.py: same
1634 * buildbot/test/test_vc.py (P4): same
1636 * setup.py: add Trove classifiers for PyPI
1638 2006-06-08 Brian Warner <warner@allmydata.com>
1640 * buildbot/status/client.py
1641 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1642 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1643 build needs to be IRemote'd separately, rather than IRemote'ing
1644 the whole list at once. I can't wait until newpb's serialization
1645 adapters make this unnecessary.
1647 2006-06-06 Brian Warner <warner@lothar.com>
1649 * buildbot/process/step.py (WithProperties): make this inherit
1650 from ComparableMixin, so that reloading an unchanged config file
1651 doesn't cause us to spuriously reload any Builders which use them.
1652 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1655 2006-06-03 Brian Warner <warner@lothar.com>
1657 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1658 running py2exe on windows, contributed by Mark Hammond. Addresses
1659 SF#1401121, but I think we still need to include
1660 buildbot/scripts/sample.cfg
1661 * setup.py: include buildbot_service.py as a script under windows
1662 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1663 a py2exe application), get the icon/css datafiles from a different
1666 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1667 double-escape the build URL. Thanks to Olivier Bonnet for the
1668 patch. Fixes SF#1452801.
1670 2006-06-02 Brian Warner <warner@lothar.com>
1672 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1673 first six columns of 'svnlook' output, not just the first column,
1674 since property changes appear in the other five. Thanks to Olivier
1675 Bonnet for the patch. Fixes SF#1398174.
1677 2006-06-01 Brian Warner <warner@lothar.com>
1679 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1680 the fake build, so that title= has something to be set to
1682 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1683 attribute of the "Build #NN" link in the yellow start-the-build
1684 box to the build's reason. This means that you get a little
1685 tooltip explaining why the build was done when you hover over the
1686 yellow box. Thanks to Zandr Milewski for the suggestion.
1688 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1689 (Box.setETA): handle ETA=None (by stopping the timer)
1690 (Box.update): make the [soon] text less different than the usual
1691 text, so the rest of the text doesn't flop around so much. It
1692 would be awfully nice to figure out how to center this stuff.
1693 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1695 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1696 by default, so that any ShellCommand which fails marks the overall
1697 build as a failure. I should have done this from the beginning.
1698 Add flunkOnFailure=False to the arguments if you want to turn off
1701 2006-05-30 Brian Warner <warner@lothar.com>
1703 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1704 last-build/current-build/current-step. Show what step is currently
1705 running. Show ETA for both the overall build and the current step.
1706 Update GTK calls to modern non-deprecated forms. There's still a
1707 lot of dead code and debug noise to remove.
1709 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1710 shows up properly in status displays
1712 2006-05-28 Brian Warner <warner@lothar.com>
1714 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1715 build we use to verify that WithProperties works:
1717 ** set flunkOnFailure=True so that build failures get noticed
1718 ** set workdir='.' so that the build succeeds, otherwise it is trying
1719 to touch 'build/something', and 'build/' doesn't exist because
1720 usually that's created by a Source step
1721 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1722 this test somehow triggers, in which the 'touch' process becomes
1723 a zombie and we wait for th etimeout before giving up on it.
1725 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1726 to log the Build results and step logs to the twisted log.
1727 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1728 what went wrong if a build was expected to succeed but didn't.
1730 * buildbot/process/step_twisted.py (Trial): set the default
1731 trialMode to '--reporter=bwverbose', which specifies verbose
1732 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1733 '-to', but those are completely missing in modern Twisteds.
1735 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1736 a localhost-only port, to encourage better security
1738 * docs/buildbot.texinfo (Change Sources): mention
1741 * .darcs-boring: add a Darcs boringfile
1743 * README (REQUIREMENTS): stop claiming compatibility with
1746 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1749 2006-05-27 Brian Warner <warner@lothar.com>
1751 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1752 * docs/buildbot.texinfo: same
1754 2006-05-23 Brian Warner <warner@lothar.com>
1756 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1757 * docs/buildbot.texinfo: set version to match
1758 * NEWS: update for 0.7.3
1760 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1761 give a quick mapping from VC system to possible ChangeSources
1762 (Build Properties): add 'buildername'
1764 * buildbot/process/base.py (Build.setupStatus): oops, set
1765 'buildername' and 'buildnumber' properties
1766 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1769 2006-05-22 Brian Warner <warner@lothar.com>
1771 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1772 property interpolation better
1774 * README (INSTALLATION): remove old '-v' argument from recommended
1777 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1778 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1781 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1782 'svnversion' instead of grepping the output of 'svn info', much
1783 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1784 Bonnet for the suggestion.
1785 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1786 require the WC_PATH argument, so run 'svnversion .' instead.
1788 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1789 aren't supposed to have 'self' in their argument list
1791 2006-05-21 Brian Warner <warner@lothar.com>
1793 * buildbot/process/step.py (ShellCommand.start): make
1794 testInterpolate pass. I was passing the uninterpolated command to
1795 the RemoteShellCommand constructor
1796 (ShellCommand._interpolateProperties): oops, handle non-list
1797 commands (i.e. strings with multiple words separated by spaces in
1798 them) properly, instead of forgetting about them.
1800 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1801 to actually try to use build properties in a real build. This test
1803 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1804 to start and evaluate builds
1806 * buildbot/test/test__versions.py: add a pseudo-test to record
1807 what version of Twisted/Python/Buildbot are running. This should
1808 show up at the beginning of _trial_tmp/test.log, and exists to help
1809 debug other problems.
1811 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1812 a filename to be served as 'robots.txt' to discourage web spiders.
1813 Adapted from a patch by Tobi Vollebregt, thanks!
1814 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1815 (Waterfall.test_waterfall): tweak the way that filenames are put
1816 into the config file, to accomodate windows pathnames better.
1818 * docs/buildbot.texinfo (HTML Waterfall): document it
1820 * buildbot/process/process_twisted.py
1821 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1822 changed the build process. The new setup.py no longer takes the
1824 (FullTwistedBuildFactory.__init__): same
1825 (TwistedReactorsBuildFactory.__init__): same
1827 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1828 be placed in the [hooks] section of the central repository (the
1829 one that everybody pushes changes to).
1831 2006-05-20 Brian Warner <warner@lothar.com>
1833 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1834 .darcs-context file, use binary mode. I think this was causing a
1835 Darcs failure under windows.
1837 2006-05-19 Brian Warner <warner@lothar.com>
1839 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1840 use a timezone string of +0000 and gmtime, since this timestamp is
1841 sent to a buildmaster and %z is broken.
1843 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1844 string and localtime, since this timestamp will only be consumed
1845 locally, and %z is broken.
1847 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1848 gmtime, since this timestamp is returned to the buildmaster, and
1851 2006-05-18 Brian Warner <warner@lothar.com>
1853 * NEWS: update in preparation for next release
1855 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1856 setup-repository and do-we-have-the-vc-tools code into a separate
1857 "helper" class, which sticks around in a single module-level
1858 object. This seems more likely to continue to work in the future
1859 than having it hide in the TestCase and hope that TestCases stick
1860 around for a long time.
1862 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1863 addremove' has been deprecated in recent versions of mercurial, so
1864 use 'hg add' instead
1866 2006-05-07 Brian Warner <warner@lothar.com>
1868 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1869 operating under windows, move the file before opening it, since
1870 you can't rename a file that somebody has open.
1872 * buildbot/process/base.py (Build.setupBuild): if something goes
1873 wrong while creating a Step, log the name and arguments, since the
1874 error message when you get the number of arguments wrong is really
1877 2006-05-06 Brian Warner <warner@lothar.com>
1879 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1880 bugs in twisted-specific code not covered by my unit tests, this
1881 time use 'cmd' argument instead of self.cmd
1883 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1884 fix stupid braino: either use startwith or find()==0, not both.
1885 (TwistedReactorsBuildFactory.__init__): another dumb typo
1887 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1888 mark this test as TODO under windows, since process-killing seems
1889 dodgy there. We'll come back to this later and try to fix it
1892 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1893 and don't include a timezone
1894 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1895 This should avoid the windows-with-verbose-timezone-name problem
1897 (Patch.testPatch): add a test which runs 'patch' with less
1898 overhead than the full VCBase.do_patch sequence, to try to isolate
1899 a windows test failure. This one uses slave.commands.ShellCommand
1900 and 'patch', but none of the VC code.
1902 * buildbot/slave/commands.py (getCommand): use which() to find the
1903 executables for 'cvs', 'svn', etc. This ought to help under
1906 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1907 working directory before starting. If an earlier test failed, the
1908 leftover directory would mistakenly flunk a later test.
1909 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1910 Make sure that we use the right commandlines if which("tla") picks
1911 up "tla.exe" (as it does under windows).
1912 (TlaSupport.do_get): factor out this tla-vs-baz difference
1913 (TlaSupport.vc_create): more tla-vs-baz differences
1915 * buildbot/test/test_slavecommand.py
1916 (ShellBase.testShellMissingCommand): stop trying to assert
1917 anything about the error message: different shells on different
1918 OSes with different languages makes it hard, and it really isn't
1919 that interesting of a thing to test anyway.
1921 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1922 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1923 "Panther"), because it has a bug which flunks a couple tests in
1924 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1925 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1926 able to test that yet.
1928 2006-04-30 Brian Warner <warner@lothar.com>
1930 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1931 make sure child commands emit messages in english, so our regexps
1932 will match. Thanks to Nikaus Giger for identifying the problems.
1933 (VCBase._do_vctest_export_1): mode="export" is not responsible
1934 for setting the "got_revision" property, since in many cases it is
1935 not convenient to determine.
1936 (SVNSupport.capable): when running 'svn --version' to check for
1937 ra_local, we want error messages in english
1938 * buildbot/test/test_slavecommand.py
1939 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1940 to emit the error message in english
1942 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1943 the environment with $LC_ALL="C" so that Commands which need to
1944 parse the output of their child processes can obtain it in
1946 (SVN.parseGotRevision): call "svn info" afterwards instead of
1947 watching the output of the "svn update" or "svn checkout".
1948 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1949 (Arch.parseGotRevision): same
1950 (Bazaar.parseGotRevision): same
1951 (Mercurial.parseGotRevision): same
1953 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1954 $LC_ALL="C" when running commands under 'buildbot try', too
1956 * buildbot/test/__init__.py: remove the global os.environ()
1957 setting, instead we do it just for the tests that run commands and
1958 need to parse their output.
1960 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1961 remove the overly-short .timeout on this test, because non-DNotify
1962 platforms must fall back to polling which happens at 10 second
1963 intervals, so a 5 second timeout would never succeed.
1965 2006-04-24 Brian Warner <warner@lothar.com>
1967 * docs/buildbot.texinfo (Installing the code): update trial
1968 invocation, SF#1469116 by Niklaus Giger.
1969 (Attributes of Changes): updated branch-name examples to be
1970 a bit more realistic, SF#1475240 by Stephen Davis.
1972 * contrib/windows/buildbot2.bat: utility wrapper for windows
1973 developers, contributed by Nick Trout (after a year of neglect..
1974 sorry!). SF#1194231.
1976 * buildbot/test/test_vc.py (*.capable): store the actual VC
1977 binary's pathname in VCS[vcname], so it can be retrieved later
1978 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1979 strip out non-numeric timezone information, specifically the funky
1980 German string that his system produced that confuses CVS.
1981 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1982 allow Darcs tests to work on windows
1983 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1984 procutils.which() everywhere, to allow tryclient to work under
1985 windows. Also from Niklaus Giger, SF#1463394.
1987 * buildbot/twcompat.py (which): move the replacement for a missing
1988 twisted.python.procutils.which from test_vc.py to here, so it can
1989 be used in other places too (specifically tryclient.py)
1991 2006-04-23 Brian Warner <warner@lothar.com>
1993 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1994 bare buildbotURL/projectName line with a proper DIV, along with a
1995 CSS class of "title", from Stefan Seefeld (SF#1461675).
1996 (WaterfallStatusResource.body0): remove the redundant 'table'
1997 class from the table
1998 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1999 to the top-row TR, and class="Activity" to the second-row TR,
2000 rather than putting them in the individual TD nodes.
2002 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2003 'got_revision' build property for all VC systems that implement
2004 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2006 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2007 to determine which revision we actually obtained
2008 (CVS.parseGotRevision): implement this for CVS, which just means
2009 to grab a timestamp. Not ideal, and it depends upon the buildslave
2010 having a clock that is reasonably well syncronized with the server,
2011 but it's better than nothing.
2012 (SVN.parseGotRevision): implement it for SVN, which is accurate
2013 (Darcs.parseGotRevision): same
2014 (Arch.parseGotRevision): same
2015 (Bazaar.parseGotRevision): same
2016 (Mercurial.parseGotRevision): same
2018 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2019 keep a record of all non-stdout/stderr/header/rc status updates,
2020 for the benefit of RemoteCommands that send other useful things,
2022 (Source.commandComplete): put any 'got_revision' status values
2023 into a build property of the same name
2026 * buildbot/process/step_twisted.py (Trial): update to deal with
2027 new ShellCommand refactoring
2029 * docs/buildbot.texinfo (Build Properties): document new feature
2030 that allows BuildSteps to get/set Build-wide properties like which
2031 revision was requested and/or checked out.
2033 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2034 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2035 it. Note that this bumps the persistenceVersion of the saved Build
2036 object, so add the necessary upgrade-old-version logic to include
2037 an empty properties dict.
2039 * buildbot/process/base.py (Build.setProperty): implement it
2040 (Build.getProperty): same
2041 (Build.startBuild): change build startup to set 'branch',
2042 'revision', and 'slavename' properties at the right time
2044 * buildbot/process/step.py (BuildStep.__init__): change setup to
2045 require 'build' argument in a better way
2046 (LoggingBuildStep): split ShellCommand into two pieces, for better
2047 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2048 a single RemoteCommand that sends stdout/stderr status text. It
2049 also provides the usual commandComplete / createSummary /
2050 evaluateCommand / getText methods to be overridden...
2051 (ShellCommand): .. whereas ShellCommand is specifically for
2052 running RemoteShellCommands. Other shell-like BuildSteps (like
2053 Source) can inherit from LoggingBuildStep instead of ShellCommand
2054 (WithProperties): marker class to do build-property interpolation
2055 (Source): inherit from LoggingBuildStep instead of ShellCommand
2058 * buildbot/test/test_properties.py: test new functionality
2060 2006-04-21 Brian Warner <warner@lothar.com>
2062 * buildbot/test/test_vc.py: rename testBranch to
2063 testCheckoutBranch to keep the tests in about the right
2066 2006-04-18 Brian Warner <warner@lothar.com>
2068 * docs/buildbot.texinfo (PBListener): improve cross-references
2069 between PBListener and 'buildbot statusgui', thanks to John Pye
2072 2006-04-17 Brian Warner <warner@lothar.com>
2074 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2075 running under Twisted-1.3.0, otherwise skipped tests are reported
2078 * all: use isinstance() instead of 'type(x) is foo', suggested by
2081 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2082 oops, fix a brain-fade from the other week, when making the
2083 addStep changes. I changed all the __init__ upcalls to use the
2084 wrong superclass name.
2085 (FullTwistedBuildFactory.__init__): same
2086 (TwistedDebsBuildFactory.__init__): same
2087 (TwistedReactorsBuildFactory.__init__): same
2088 (TwistedBuild.isFileImportant): use .startswith for clarity,
2089 thanks to Neal Norwitz for the suggestions.
2091 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2092 changes, then deliver them over PB to a remote buildmaster.
2094 * contrib/svnpoller.py: added script by John Pye to poll a remote
2095 SVN repository (by running 'svn log') from a cronjob, and run
2096 'buildbot sendchange' to deliver the changes to a remote
2098 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2099 modification of svnpoller.py), same purpose, but this one loops
2100 internally (rather than expecting to run from a cronjob) and works
2102 * contrib/README.txt: same
2104 2006-04-11 Brian Warner <warner@lothar.com>
2106 * all: fix a number of incorrect names and missing imports, thanks
2107 to Anthony Baxter for the patch.
2108 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2109 remove unused buggy method.
2110 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2111 comes from shutil, not "shutils"
2112 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2113 (Arch.checkSlaveVersion): same
2114 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2116 * buildbot/process/step_twisted2.py: add some missing imports
2117 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2118 this code used to live in twisted.internet.defer
2120 2006-04-10 Brian Warner <warner@lothar.com>
2122 * buildbot/process/step.py (Mercurial): add Mercurial support
2123 * buildbot/slave/commands.py (Mercurial): same
2124 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2125 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2126 not yet tested, but 'try' support *is* covered
2127 * docs/buildbot.texinfo (Mercurial): document it
2129 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2130 some debugging messages (turned off)
2131 * buildbot/test/test_vc.py: improve debug messages
2133 2006-04-07 Brian Warner <warner@lothar.com>
2135 * buildbot/test/test_vc.py (which): define our own which() in case
2136 we can't import twisted.python.procutils, because procutils doesn't
2137 exist in Twisted-1.3
2139 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2140 of SlaveLocks for performance tests
2142 * docs/examples/twisted_master.cfg: update to match current usage
2144 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2145 password, p4 binary, pollinterval, maximum history to check.
2146 Patch from an anonymous sf.net contributor, SF#1219384.
2147 * buildbot/process/step.py (P4Sync.__init__): add username,
2148 password, and client arguments.
2149 * buildbot/slave/commands.py (P4Sync): same
2151 2006-04-05 Brian Warner <warner@lothar.com>
2153 * buildbot/process/factory.py (BuildFactory.addStep): new method
2154 to add steps to a BuildFactory. Use it instead of f.steps.append,
2155 and you can probably avoid using the s() convenience function.
2156 Patch from Neal Norwitz, sf.net #1412605.
2157 (other): update all factories to use addStep
2158 * buildbot/process/process_twisted.py: update all factories to use
2161 2006-04-03 Brian Warner <warner@lothar.com>
2163 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2164 work under windows too. Adapted from a patch by Niklaus Giger,
2165 addresses SF#1463399.
2167 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2168 spawned commands emit parseable results in english and not some
2169 other language. Patch from Niklaus Giger, SF#1463395.
2171 * README (INSTALLATION): discourage users from running unit tests on
2172 a "network drive", patch from Niklaus Giger, SF#1463394.
2174 2006-03-22 Brian Warner <warner@lothar.com>
2176 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2177 function to turn a repository-relative pathname into a (branch,
2178 branch-relative-filename) tuple. Change this function to handle
2179 the branch naming policy used by your Subversion repository.
2180 Thanks to AllMyData.com for sponsoring this work.
2182 2006-03-16 Brian Warner <warner@lothar.com>
2184 * buildbot/scripts/sample.cfg: add python-mode declaration for
2185 vim. Thanks to John Pye for the patch.
2187 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2188 command line, mention the importance of running 'crontab' as the
2189 buildmaster/buildslave user. Thanks to John Pye for the catch.
2191 2006-03-13 Brian Warner <warner@lothar.com>
2193 * buildbot/status/words.py (IRC): add an optional password=
2194 argument, which will be sent to Nickserv in an IDENTIFY message at
2195 login, to claim the nickname. freenode requires this before the
2196 bot can sent (or reply to) private messages. Thanks to Clement
2197 Stenac for the patch.
2198 * docs/buildbot.texinfo (IRC Bot): document it
2200 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2201 larger than chunkSize. Fixes SF#1349253.
2202 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2203 (Log.testConsumer): update to match new internal chunking behavior
2205 2006-03-12 Brian Warner <warner@lothar.com>
2207 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2209 * buildbot/test/test_maildir.py (MaildirTest): rename the
2210 'timeout' method, as it collides with trial's internals
2212 * buildbot/scripts/runner.py: add 'buildbot restart' command
2213 (stop): don't sys.exit() out of here, otherwise restart can't work
2214 * docs/buildbot.texinfo (Shutdown): document it
2216 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2217 * buildbot/status/html.py (Waterfall.__init__): same
2218 * buildbot/process/builder.py (Builder.startBuild): same
2219 * buildbot/process/base.py (BuildRequest): same
2220 * buildbot/sourcestamp.py (SourceStamp): same
2221 * buildbot/scheduler.py (Nightly): same
2223 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2225 * docs/buildbot.texinfo: same
2227 2006-02-17 Brian Warner <warner@lothar.com>
2229 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2230 * docs/buildbot.texinfo: set version number to match
2231 * NEWS: update for 0.7.2
2233 2006-02-16 Brian Warner <warner@lothar.com>
2235 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2237 2006-02-09 Brian Warner <warner@lothar.com>
2239 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2240 add text to explain per-build branch parameters
2241 * NEWS: mention --umask
2243 2006-02-08 Brian Warner <warner@lothar.com>
2245 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2247 (SlaveOptions.optParameters): add --umask, to make it possible to
2248 make buildslave-generated files (including build products) be
2251 * buildbot/slave/bot.py (BuildSlave.startService): same
2253 2006-01-23 Brian Warner <warner@lothar.com>
2255 * buildbot/status/builder.py: urllib.quote() all URLs that include
2256 Builder names, so that builders can include characters like '/'
2257 and ' ' without completely breaking the resulting HTML. Thanks to
2258 Kevin Turner for the patch.
2259 * buildbot/status/html.py: same
2260 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2262 * NEWS: update in preparation for upcoming release
2264 2006-01-18 Brian Warner <warner@lothar.com>
2266 * docs/examples/twisted_master.cfg: update to match the Twisted
2267 buildbot: remove python2.2, switch to exarkun's buildslaves,
2268 disable the .deb builder until we figure out how to build twisted
2269 .debs from SVN, add some ktrace debugging to the OS-X build
2270 process and remove the qt build, remove threadless builders,
2271 change freebsd builder to use landonf's buildslave.
2273 2006-01-12 Brian Warner <warner@lothar.com>
2275 * buildbot/master.py (Manhole.__init__): let port= be a strports
2276 specification string, but handle a regular int for backwards
2277 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2278 used in master.cfg to limit connections to just the local host.
2279 (BuildMaster.loadConfig): same for c['slavePortnum']
2280 * buildbot/scheduler.py (Try_Userpass.__init__): same
2281 * buildbot/status/client.py (PBListener.__init__): same
2282 * buildbot/status/html.py (Waterfall.__init__): same, for both
2283 http_port and distrib_port. Include backwards-compatibility checks
2284 so distrib_port can be a filename string and still mean unix:/foo
2285 * docs/buildbot.texinfo (Setting the slaveport): document it
2286 (Debug options): same
2287 (HTML Waterfall): same
2290 * buildbot/test/test_config.py (ConfigTest): test it
2292 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2293 slaveport's disownServiceParent deferred to fire before opening
2294 the new one. Fixes an annoying bug in the unit tests.
2296 2006-01-03 Brian Warner <warner@lothar.com>
2298 * buildbot/master.py (BuildMaster): remove the .schedulers
2299 attribute, replacing it with an allSchedulers() method that looks
2300 for all IService children that implement IScheduler. Having only
2301 one parent/child relationship means fewer opportunities for bugs.
2302 (BuildMaster.allSchedulers): new method
2303 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2304 also fix ugly bug that caused any config-file reload to
2305 half-forget about the earlier Schedulers, causing an exception
2306 when a Change arrived and was handed to a half-connected
2307 Scheduler. The exception was in scheduler.py line 54ish:
2308 self.parent.submitBuildSet(bs)
2309 exceptions.AttributeError: 'NoneType' object has no attribute
2311 (BuildMaster.addChange): update to use allSchedulers()
2313 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2314 to work properly with twisted-1.3.0, where you must explicitly
2315 include the __implements__ from parent classes
2316 (BaseScheduler.__repr__): make it easier to distinguish distinct
2318 (BaseUpstreamScheduler.__implements__): same
2320 * buildbot/status/builder.py (Status.getSchedulers): update to
2322 * buildbot/test/test_run.py (Run.testMaster): same
2323 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2324 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2325 make sure Scheduler instances are left alone when an identical
2326 config file is reloaded
2327 (ConfigElements.testSchedulers): make sure Schedulers are properly
2330 * Makefile (TRIALARGS): my local default Twisted version is now
2331 2.1.0, update the trial arguments accordingly
2333 2005-12-22 Brian Warner <warner@lothar.com>
2335 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2338 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2339 addChange in the parent class, although I suspect this should be
2340 fixed better in the future.
2342 2005-11-26 Brian Warner <warner@lothar.com>
2344 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2345 explode when branch==None, thanks to Kevin Turner for the catch
2346 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2349 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2351 * docs/buildbot.texinfo: same
2353 2005-11-26 Brian Warner <warner@lothar.com>
2355 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2356 * docs/buildbot.texinfo: set version number to match
2358 2005-11-26 Brian Warner <warner@lothar.com>
2360 * NEWS: update for 0.7.1
2362 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2363 sure that unsubscribe works even if we never sent an ETA update.
2364 Also, don't explode on duplicate unsubscribe.
2365 (BuildStepStatus.addLog): make the convenience "return self"-added
2366 watcher automatically unsubscribe when the Step finishes.
2367 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2368 (BuildStatus.stepStarted): same auto-unsubscribe
2369 (BuilderStatus.buildStarted): same auto-unsubscribe
2371 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2373 (IStatusReceiver.stepStarted): same
2374 (IStatusReceiver.logStarted): same
2376 * buildbot/test/test_run.py (Status): move the Status test..
2377 * buildbot/test/test_status.py (Subscription): .. to here
2379 2005-11-25 Brian Warner <warner@lothar.com>
2381 * NEWS: more updates
2383 * buildbot/locks.py: fix the problem in which loading a master.cfg
2384 file that changes some Builders (but not all of them) can result
2385 in having multiple copies of the same Lock. Now, the real Locks
2386 are kept in a table inside the BotMaster, and the Builders/Steps
2387 use "LockIDs", which are still instances of MasterLock and
2388 SlaveLock. The real Locks are instances of the new RealMasterLock
2389 and RealSlaveLock classes.
2390 * buildbot/master.py (BotMaster.getLockByID): new method to
2391 convert LockIDs into real Locks.
2392 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2393 into real Locks before building
2394 * buildbot/process/step.py (BuildStep.startStep): same
2395 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2396 exercises the problem
2399 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2400 what Schedulers are available
2402 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2403 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2404 'cron'-style build scheduling at certain times of day, week,
2406 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2408 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2409 handling: treat self.fileIsImportant more as an attribute that
2410 contains a callable than as a method. If the attribute is None,
2411 don't call it and assume all filenames are important. It is still
2412 possible to provide a fileIsImportant method in a subclass,
2414 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2416 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2417 test using AnyBranchScheduler with fileIsImportant=None
2419 2005-11-24 Brian Warner <warner@lothar.com>
2421 * buildbot/test/test_config.py (StartService): don't claim a fixed
2422 port number, instead set slavePort=0 on the first pass, figure out
2423 what port was allocated, then switch to a config file that uses
2426 * buildbot/master.py (BuildMaster.loadConfig): close the old
2427 slaveport before opening the new one, because unit tests might
2428 replace slavePort=0 with the same allocated portnumber, and if we
2429 don't wait for the old port to close first, we get a "port already
2430 in use" error. There is a tiny race condition here, but the only
2431 threat is from other programs that bind (statically) to the same
2432 port number we happened to be allocated, and only if those
2433 programs use SO_REUSEADDR, and only if they get control in between
2436 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2438 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2439 deleted ChangeSources before adding any new ones
2440 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2441 compare_attrs, to make sure that a config-file reload does not
2442 unnecessarily replace an unmodified ChangeSource instance
2443 * buildbot/test/test_config.py (ConfigTest.testSources): update
2445 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2446 mean "don't build anything", and add a warning if it gets used
2447 because it isn't actually useful.
2449 * contrib/svn_buildbot.py: update example usage to match the port
2450 number that gets used by the PBChangeSource
2451 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2453 2005-11-22 Brian Warner <warner@lothar.com>
2455 * NEWS: start collecting items for next release
2457 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2458 revisions are strings
2459 (P4Sync.computeSourceRevision): same
2461 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2462 to the Buildbot's overall status page
2463 (StatusResourceBuilder.body): same
2465 2005-11-15 Brian Warner <warner@lothar.com>
2467 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2468 config-file loading, specifically to make sure old StatusTargets
2469 are finished shutting down before new ones start up (thus
2470 resolving a bug in which changing the Waterfall object would fail
2471 because both new and old instances were claiming the same
2472 listening port). Also load new Schedulers after all the new
2473 Builders are set up, in case they fire off a new build right away.
2474 * buildbot/test/test_config.py (StartService): test it
2476 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2477 the branch name to the mail body
2479 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2480 Without it, a config-file reload fails to update an existing
2482 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2483 username/passwd to compare_attrs, for the same reason
2484 * buildbot/status/html.py (Waterfall): add favicon to
2485 compare_attrs, same reason
2487 2005-11-05 Brian Warner <warner@lothar.com>
2489 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2490 baserev before stuffing it in the jobfile. This resolves problems
2491 under SVN (and probably Arch) where revisions are expressed as
2492 numbers. I'm inclined to use string-based revisions everywhere in
2493 the future, but this fix should be safe for now. Thanks to Steven
2494 Walter for the patch.
2496 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2497 binary mode when opening pickle files, to make windows work
2498 better. Thanks to Dobes Vandermeer for the catch.
2499 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2500 (BuilderStatus.getBuildByNumber): same
2501 (Status.builderAdded): same
2502 * buildbot/master.py (BuildMaster.loadChanges): same
2504 * buildbot/util.py (Swappable): delete unused leftover code
2506 * buildbot/process/step.py (SVN): when building on a non-default
2507 branch, add the word "[branch]" to the VC step's description, so
2508 it is obvious that we're not building the usual stuff. Likewise,
2509 when we are building a specific revision, add the text "rNNN" to
2510 indicate what that revision number is. Thanks to Brad Hards and
2511 Nathaniel Smith for the suggestion.
2512 (Darcs.startVC): same
2513 (Arch.startVC): same
2514 (Bazaar.startVC): same
2516 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2517 typo, caught by Mark Dillavou, closes SF#1216636.
2519 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2520 about a test to add some day
2522 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2523 the 'full-2.3' build, and the 'reactors' build is now run under
2524 python-2.4 because the buildslave no longer has gtk/etc bindings
2525 for earlier versions.
2527 2005-11-03 Brian Warner <warner@lothar.com>
2529 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2530 method, takes an IBuildStatus and rebuilds it. It might make more
2531 sense to add this to IBuildControl instead, but that instance goes
2532 away completely once the build has finished, and resubmitting
2533 builds can take place weeks later.
2534 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2535 * buildbot/status/html.py (StatusResourceBuild): also stash an
2536 IBuilderControl so we can use resubmitBuild.
2537 (StatusResourceBuild.body): render "resubmit" button if we can.
2538 Also add hrefs for each BuildStep
2539 (StatusResourceBuild.rebuild): add action for "resubmit" button
2540 (StatusResourceBuilder.getChild): give it an IBuilderControl
2542 * buildbot/status/builder.py (Status.getURLForThing): change the
2543 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2544 that live as targets of buttons like "stop" and "rebuild" can't
2546 * buildbot/status/builder.py (Status.getURLForThing): same
2547 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2548 (StepBox.getBox): same
2549 * buildbot/test/test_web.py (GetURL): same
2552 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2553 exclusivity checks after Source.__init__ upcall, so misspelled
2554 arguments will be reported more usefully
2555 (Darcs.__init__): same
2557 2005-10-29 Brian Warner <warner@lothar.com>
2559 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2560 builder. Move the Try scheduler off to a separate port.
2562 2005-10-27 Brian Warner <warner@lothar.com>
2564 * buildbot/clients/gtkPanes.py
2565 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2566 to cause the app to crash, now they don't.
2568 * buildbot/clients/debug.py: display the buildmaster's location
2569 in the window's title bar
2571 2005-10-26 Brian Warner <warner@lothar.com>
2573 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2574 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2575 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2577 * buildbot/status/html.py (td): put a single non-breaking space
2578 inside otherwise empty <td> elements, as a workaround for buggy
2579 browsers which would optimize them away (along with any associated
2580 styles, like the kind that create the waterfall grid borders).
2581 Patch from Frerich Raabe.
2583 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2584 argv-list as an argument, defaulting to ["-to"], which is
2585 appropriate for the Trial that comes with Twisted-2.1.0 and
2586 earlier. The Trial in current Twisted SVN wants
2587 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2588 defaults to an empty list.
2589 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2590 match it, now that trialMode= is a list instead of a single string
2592 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2594 * docs/buildbot.texinfo: same
2596 2005-10-24 Brian Warner <warner@lothar.com>
2598 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2599 * docs/buildbot.texinfo: set version number to match
2601 2005-10-24 Brian Warner <warner@lothar.com>
2603 * README: update for 0.7.0
2605 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2607 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2608 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2609 send the branch= argument unless the user really provided one, to
2610 retain compatibility with older buildmasters that don't accept
2612 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2615 * docs/buildbot.texinfo: update lots of stuff
2617 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2618 to the 'buildbot sendchange' command
2619 * buildbot/clients/sendchange.py (Sender.send): same
2620 * buildbot/changes/pb.py (ChangePerspective): same
2621 * buildbot/test/test_changes.py (Sender.testSender): test it
2623 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2624 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2625 for consistency with other BuildStep arguments that use camelCase.
2626 Well, at least more of them use camelCase (like flunkOnWarnings)
2627 than don't.. I wish I'd picked one style and stuck with it
2628 earlier. Annoying, but it's best done before the release, since
2629 these arguments didn't exist at all in 0.6.6 .
2631 * buildbot/test/test_vc.py (SVN.testCheckout): same
2632 (Darcs.testPatch): same
2633 * docs/buildbot.texinfo (SVN): document the change
2634 (Darcs): same, add some build-on-branch docs
2635 * docs/examples/twisted_master.cfg: match change
2637 * buildbot/process/step.py (BuildStep): rename
2638 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2639 how it is normally used.
2640 * buildbot/test/test_steps.py (Version.checkCompare): same
2642 * buildbot/process/step.py (CVS.startVC): refuse to build
2643 update/copy -style builds on a non-default branch with an old
2644 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2645 concern is that it will do a VC 'update' in an existing tree when
2646 it is supposed to be switching branches (and therefore clobbering
2647 the tree to do a full checkout), thus building the wrong source.
2648 This used to be a warning, but I think the confusion it is likely
2649 to cause warrants making it an error.
2650 (SVN.startVC): same, also make mode=export on old slaves an error
2651 (Darcs.startVC): same
2652 (Git.startVC): improve error message for non-Git-enabled slaves
2653 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2654 specific revision is built on a slave that doesn't pay attention
2655 to args['revision'], because for slowly-changing trees it will
2656 probably do the right thing, and because we have no way to tell
2657 whether we're asking it to build the most recent version or not.
2658 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2660 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2661 that 'master' is in host:portnum format, to catch errors sooner
2663 2005-10-23 Brian Warner <warner@lothar.com>
2665 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2666 when creating the list of warning messages, include the line
2667 immediately after each WARNING: line, since that's usually where
2668 the file and line number wind up.
2670 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2675 2005-10-22 Brian Warner <warner@lothar.com>
2677 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2678 patch from Brad Hards
2679 * buildbot/status/classic.css: same
2680 * buildbot/test/test_web.py (Waterfall): match changes
2682 * buildbot/test/test_steps.py (BuildStep.setUp): set
2683 nextBuildNumber so the test passes
2684 * buildbot/test/test_status.py (MyBuilder): same
2686 * buildbot/status/html.py (StatusResourceBuild.body): revision
2687 might be numeric, so stringify it before html-escapifying it
2688 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2689 timer for the upcoming build
2690 * buildbot/status/classic.css: add background-color attributes for
2691 offline/waiting/building classes
2693 * buildbot/status/builder.py (BuildStatus): derive from
2694 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2695 the default (i.e. unknown) .slavename to "???" instead of None,
2696 since even unknown slavenames need to be printed eventually.
2697 (BuilderStatus): also derive from styles.Versioned . More
2698 importantly, determine .nextBuildNumber at creation/unpickling
2699 time by scanning the directory of saved BuildStatus instances and
2700 choosing one larger than the highest-numbered one found. This
2701 should fix the problem where random errors during upgrades cause
2702 the buildbot to forget about earlier builds. .nextBuildNumber is
2703 no longer stored in the pickle.
2704 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2705 at least log the error. Also call Builder.determineNextBuildNumber
2706 once the basedir is set.
2708 * buildbot/master.py (BuildMaster.loadChanges): do
2709 styles.doUpgrade afterwards, in case I decide to make Changes
2710 derived from styles.Versioned some day and forget to make this
2714 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2715 when running under older pythons (<2.3) in which the shlex module
2716 doesn't have a 'split' function.
2718 * buildbot/process/step.py (ShellCommand.start): make
2719 errorMessages= be a list of strings to stuff in the log before the
2720 command actually starts. This makes it easier to flag multiple
2721 warning messages, e.g. when the Source steps have to deal with an
2723 (CVS.startVC): handle slaves that don't handle multiple branches
2724 by switching into 'clobber' mode
2725 (SVN.startVC): same. Also reject branches without base_url
2726 (Darcs.startVC): same. Also reject revision= in older slaves
2727 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2728 (Bazaar.startVC): same, and test for baz separately than for arch
2730 * buildbot/slave/commands.py (cvs_ver): document new features
2732 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2733 (BuildStep.slaveVersionNewEnough): more useful utility method
2734 * buildbot/test/test_steps.py (Version): start testing it
2736 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2737 the 'force' command requires python2.3, for the shlex.split method
2739 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2740 since we don't use it anymore. The Twisted buildbot uses a
2743 2005-10-21 Brian Warner <warner@lothar.com>
2745 * buildbot/process/process_twisted.py: rework all BuildFactory
2746 classes to take a 'source' step as an argument, instead of
2747 building up the SVN instance in the factory.
2748 * docs/examples/twisted_master.cfg: enable build-on-branch by
2749 providing a base_url and default_branch
2751 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2752 control over --branch and --revision, not that they are always
2754 * buildbot/status/html.py (StatusResourceBuilder.force): same
2755 (StatusResourceBuild.body): display SourceStamp components
2757 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2758 IRC 'force' command, so it can be shared with an eventual
2759 command-line-tool 'buildbot force' mode.
2760 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2762 2005-10-20 Brian Warner <warner@lothar.com>
2764 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2766 * docs/examples/twisted_master.cfg: update to use Schedulers
2768 * buildbot/scripts/sample.cfg: update with Schedulers
2770 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2771 method specifically for use by HTML "force build" button and the
2772 IRC "force" command. Raises an immediate error if there are no
2774 (IBuilderControl.requestBuild): make this just submit a build, not
2775 try to check for existing slaves or set up any when-finished
2776 Deferreds or anything.
2777 * buildbot/process/builder.py (BuilderControl): same
2778 * buildbot/status/html.py (StatusResourceBuilder.force): same
2779 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2780 * buildbot/test/test_slaves.py: same
2781 * buildbot/test/test_web.py: same
2783 2005-10-19 Brian Warner <warner@lothar.com>
2785 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2786 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2788 2005-10-18 Brian Warner <warner@lothar.com>
2790 * buildbot/status/html.py: provide 'status' argument to most
2791 StatusResourceFOO objects
2792 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2793 and Logfiles" section to make the Build page into a more-or-less
2794 comprehensive source of status information about the build
2796 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2797 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2799 2005-10-17 Brian Warner <warner@lothar.com>
2801 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2802 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2803 out what to do about other projects: the correct options for
2804 recent Twisteds will not work for older ones.
2806 2005-10-15 Brian Warner <warner@lothar.com>
2808 * buildbot/status/builder.py (Status.getURLForThing): add method
2809 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2810 use this in email/IRC status clients to make them more useful, by
2811 providing the end user with hints on where to learn more about the
2812 object being reported on.
2813 * buildbot/test/test_web.py (GetURL): tests for it
2815 2005-10-14 Brian Warner <warner@lothar.com>
2817 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2818 fix bug resulting from deferredResult changes
2820 2005-10-13 Brian Warner <warner@lothar.com>
2822 * buildbot/test/test_changes.py: remove use of deferredResult
2823 * buildbot/test/test_config.py: same
2824 * buildbot/test/test_control.py: same
2825 * buildbot/test/test_status.py: same
2826 * buildbot/test/test_vc.py: this is the only remaining use, since
2827 it gets used at module level. This needs to be replaced by some
2828 sort of class-level run-once routine.
2830 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2832 * lots: implement multiple slaves per Builder, which means multiple
2833 current builds per Builder. Some highlights:
2834 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2835 of (state,currentBuilds) instead of (state,currentBuild)
2836 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2837 (IBuildStatus.getSlavename): new method, so you can tell which
2838 slave got used. This only gets set when the build completes.
2839 (IBuildRequestStatus.getBuilds): new method
2841 * buildbot/process/builder.py (SlaveBuilder): add a .state
2842 attribute to track things like ATTACHING and IDLE and BUILDING,
2844 (Builder): .. the .slaves attribute here, which has been turned
2845 into a simple list of available slaves. Added a separate
2846 attaching_slaves list to track ones that are not yet ready for
2848 (Builder.fireTestEvent): put off the test-event callback for a
2849 reactor turn, to make tests a bit more consistent.
2850 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2851 ping fails due to an exception. This needs work, I'm worried that
2852 a code error could lead to a constantly re-connecting slave.
2853 Especially since I'm trying to move to a distinct remote_ping
2854 method, separate from the remote_print that we currently use.
2855 (BuilderControl.requestBuild): return a convenience Deferred that
2856 provides an IBuildStatus when the build finishes.
2857 (BuilderControl.ping): ping all connected slaves, only return True
2858 if they all respond.
2860 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2861 reconnect when we shut down.
2863 * buildbot/status/builder.py: implement new methods, convert
2864 one-build-at-a-time methods to handle multiple builds
2865 * buildbot/status/*.py: do the same in all default status targets
2866 * buildbot/status/html.py: report the build's slavename in the
2867 per-Build page, report all buildslaves on the per-Builder page
2869 * buildbot/test/test_run.py: update/create tests
2870 * buildbot/test/test_slaves.py: same
2871 * buildbot/test/test_scheduler.py: remove stale test
2873 * docs/buildbot.texinfo: document the new builder-specification
2874 'slavenames' parameter
2876 2005-10-12 Brian Warner <warner@lothar.com>
2878 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2879 report failure correctly, causing Dependent builds to run when
2880 they shouldn't have.
2881 * buildbot/status/builder.py (BuildSetStatus): same
2882 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2883 (Set.testSuccess): test the both-pass case too
2884 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2885 fix this test: it was ending too early, masking the failure before
2886 (Logger): specialized StatusReceiver to make sure the dependent
2887 builds aren't even started, much less completed.
2889 2005-10-07 Brian Warner <warner@lothar.com>
2891 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2892 bot.SlaveBuilder being disowned in the middle of a build
2894 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2895 this inherit from StatusReceiver. Also upcall in __init__. This
2896 fixes the embarrasing crash when the new buildSetSubmitted method
2897 is invoked and Waterfall/etc don't implement their own.
2898 * buildbot/test/test_run.py: add a TODO note about a test to catch
2899 just this sort of thing.
2901 * buildbot/process/builder.py (Builder.attached): remove the
2902 already-attached warning, this situation is normal. Add some
2903 comments explaining it.
2905 2005-10-02 Brian Warner <warner@lothar.com>
2907 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2908 OverflowError when setting up dnotify, because some 64-bit systems
2909 have problems with signed-vs-unsigned constants and trip up on the
2910 DN_MULTISHOT flag. Patch from Brad Hards.
2912 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2914 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2915 progressMetrics, description, descriptionDone to the 'parms' list,
2916 and make use the 'parms' list from the implementation class
2917 instead of only BuildStep to initialize the parameters. This
2918 allows buildbot.process.factory.s() to initialize all the parms,
2919 not just those defined in directly by BuildStep.
2921 2005-09-03 Brian Warner <warner@lothar.com>
2923 * NEWS: start adding items for the next release
2925 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2926 python2.2 tests, change 'Quick' builder to only use python2.3
2928 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2930 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2931 the "Ping Builder" button if the build control is available; the
2932 user sees an exception otherwise
2934 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2936 2005-09-01 Brian Warner <warner@lothar.com>
2938 * buildbot/interfaces.py (IBuilderStatus.getState): update
2939 signature, point out that 'build' can be None
2940 (IBuildStatus.getETA): point out ETA can be none
2942 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2944 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2946 2005-08-31 Brian Warner <warner@lothar.com>
2948 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2949 update to match correct signature: removed 'eta' argument
2950 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2952 2005-08-30 Brian Warner <warner@lothar.com>
2954 * buildbot/status/builder.py (LogFile): remove the assertion that
2955 blows up when you try to overwrite an existing logfile, instead
2956 just emit a warning. This case gets hit when the buildmaster is
2957 killed and doesn't get a chance to write out the serialized
2958 BuilderStatus object, so the .nextBuildNumber attribute gets out
2961 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2962 the 'buildbot sendchange' arguments, for the Darcs context file
2963 * docs/buildbot.texinfo (sendchange): document it
2965 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2966 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2967 (IStatus.getSchedulers): new method
2968 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2969 (Status.getSchedulers): implement
2970 * buildbot/process/builder.py (Builder): maintain
2971 BuilderStatus.pendingBuilds
2972 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2973 (TryBase.addChange): Try schedulers should ignore Changes
2975 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2976 for 'try' on CVS/SVN
2977 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2979 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2980 report status properly.
2981 (Try.createJob): implement unique buildset IDs
2983 * buildbot/status/client.py (StatusClientPerspective): add a
2984 perspective_getBuildSets method for the benefit of jobdir-style
2986 * docs/buildbot.texinfo (try): more docs
2987 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2990 2005-08-18 Brian Warner <warner@lothar.com>
2992 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2993 actually work. It's functional but still kind of clunky. Also, it
2994 only works with the pb-style.. needs to be made to work with the
2997 * buildbot/status/client.py (RemoteBuildSet): new class
2998 (RemoteBuildRequest): same
2999 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3000 object, not the internal BuildStatus object.
3001 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3002 outside of the usual buildStarted() return value.
3003 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3005 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3006 (Try_Userpass_Perspective.perspective_try): return a remotely
3007 usable BuildSetStatus object
3009 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3010 isStarted()/waitUntilStarted()
3012 2005-08-16 Brian Warner <warner@lothar.com>
3014 * buildbot/status/builder.py: implement IBuildSetStatus and
3015 IBuildRequestStatus, wire them into place.
3016 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3017 methods into the BuildSetStatus object.
3018 * buildbot/interfaces.py: same
3019 (IStatus.getBuildSets): new method to get pending BuildSets
3020 (IStatusReceiver.buildsetSubmitted): new method which hears about
3022 * buildbot/master.py (BuildMaster.submitBuildSet): same
3023 * buildbot/process/base.py (BuildRequest): same, replace
3024 waitUntilStarted with subscribe/unsubscribe
3025 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3026 subscribe instead of waitUntilStarted
3027 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3029 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3031 * buildbot/test/test_buildreq.py: update for new code
3032 * buildbot/test/test_control.py (Force.testRequest): same
3035 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3036 for Darcs to not use the tempfile module, so it works under
3037 python-2.2 too. We really didn't need the full cleverness of that
3038 module, since the slave has exclusive control of its own builddir.
3040 2005-08-15 Brian Warner <warner@lothar.com>
3042 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3043 for CVS trees. It doesn't work for non-trunk branches,
3045 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3048 * Makefile: make it easier to test against python2.2
3050 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3051 tearDown2, so things like Arch can unregister archives as they're
3052 shutting down. The previous subclass-override-tearDown technique
3053 resulted in a nested maybeWait() and test failures under
3056 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3057 where we can (Arch), add a branch= argument to set the branch used
3059 (BazExtractor): extract the branch too
3060 (TlaExtractor): same
3061 * buildbot/scripts/runner.py (TryOptions): add --branch
3062 * docs/buildbot.texinfo (try): document --branch/try_branch
3064 * buildbot/slave/commands.py (Darcs): implement get-revision for
3065 Darcs, so that 'try' will work. This requires the tempfile module
3068 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3069 of revisions, branches, and 'try' in the process.
3071 2005-08-11 Brian Warner <warner@lothar.com>
3073 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3074 this, it got broken at some point in the last few releases
3075 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3076 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3077 specifically the removal of ETA information from the tuple
3079 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3082 * docs/buildbot.texinfo (try): document both --builder and
3083 'try_builders' in .buildbot/options
3084 * buildbot/scripts/runner.py (TryOptions): add --builder,
3085 accumulate the values into opts['builders']
3086 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3087 * buildbot/test/test_runner.py (Try): add some quick tests to make
3088 sure 'buildbot try --options' and .buildbot/options get parsed
3089 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3090 use --builder control
3092 * docs/buildbot.texinfo (try): add --port argument to PB style
3094 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3095 actual SourceStamp. Still need to extract a branch name, somehow.
3096 (Try): finish implementing the try client side, still need a UI
3097 for specifying which builders to use
3098 (Try.getopt): factor our options/config-file reading
3099 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3101 * buildbot/test/test_vc.py: match SourceStampExtractor change
3103 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3104 causes the twisted log to be sent to stderr
3106 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3108 2005-08-10 Brian Warner <warner@lothar.com>
3110 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3111 style is 90% done, still missing status reporting or waiting for
3112 the buildsets to finish, and it is completely untested.
3114 * buildbot/trybuild.py: delete file, move contents to ..
3115 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3116 * buildbot/test/test_vc.py: match the move
3118 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3119 of the TryScheduler, no buildsetID or status-tracking support yet
3120 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3122 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3123 possible to set the basedir after __init__ time, so it is easier
3124 to use as a Service-child of the BuildMaster instance
3126 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3127 that delivers messages to its Service parent instead of requiring
3128 a subclass to be useful. This turns out to be much easier to build
3131 * buildbot/scripts/tryclient.py (createJob): utility code to
3132 create jobfiles, will eventually be used by 'buildbot try'
3134 2005-08-08 Brian Warner <warner@lothar.com>
3136 * docs/buildbot.texinfo (try): add docs on the
3137 as-yet-unimplemented Try scheduler
3139 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3140 * buildbot/test/test_scheduler.py: .. here
3141 (Scheduling.testTryJobdir): add placeholder test for 'try'
3143 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3144 addEntry merging (>=chunkSize) behavior
3145 (Log.testConsumer): update to handle new callLater(0) behavior
3147 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3148 both the MAX_LENGTH bugfix and the resumeProducing hang.
3150 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3151 put off the actual resumeProducing for a moment with
3152 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3153 causes large logfiles to hang midway through.
3155 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3156 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3157 and to improve memory usage when streaming the file out to a web
3159 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3160 make this work cleanly
3162 2005-08-03 Brian Warner <warner@lothar.com>
3164 * buildbot/trybuild.py: new file for 'try' utilities
3165 (getSourceStamp): run in a tree, find out the baserev+patch
3166 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3167 implemented for SVN and Darcs, still working on Arch. I don't know
3168 how to make CVS work yet.
3170 * docs/buildbot.texinfo: document the 'buildbot' command-line
3171 tool, including the not-yet-implemented 'try' feature, and the
3172 in-flux .buildbot/ options directory.
3174 2005-07-20 Brian Warner <warner@lothar.com>
3176 * buildbot/locks.py: added temporary id() numbers to Lock
3177 descriptions, to track down a not-really-sharing-the-Lock bug
3179 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3181 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3182 needed for python2.2 compatibility
3183 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3184 are from the __future__
3186 2005-07-19 Brian Warner <warner@lothar.com>
3188 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3189 message when schedulers use unknown builders
3191 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3192 SlaveLock('name') and MasterLock('name') are distinct
3194 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3195 c['schedulers'] in such a way that we can actually accept
3197 * buildbot/test/test_config.py: check it
3199 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3200 utility method to *all* the Schedulers
3201 (Periodic.listBuilderNames): same
3203 * docs/buildbot.texinfo (Interlocks): update chapter to match
3206 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3207 to make sure that c['sources'], c['schedulers'], and c['status']
3208 are all lists of the appropriate objects, and that the Schedulers
3209 all point to real Builders
3210 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3211 'listBuilderNames' utility method to support this
3212 * buildbot/scheduler.py: implement the utility method
3213 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3215 * docs/buildbot.texinfo: add some @cindex entries
3217 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3218 if it wasn't already set: most tla commands will fail unless one
3220 (Arch.createRepository): and disable bazaar's revision cache, since
3221 they cause test failures (the multiple repositories we create all
3222 interfere with each other through the cache)
3224 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3225 bring it properly up to date with twisted-2.0 test guidelines
3227 * buildbot/master.py (BuildMaster): remove references to old
3228 'interlock' module, this caused a bunch of post-merge test
3230 * buildbot/test/test_config.py: same
3231 * buildbot/process/base.py (Build): same
3233 * buildbot/test/test_slaves.py: stubs for new test case
3235 * buildbot/scheduler.py: add test-case-name tag
3236 * buildbot/test/test_buildreq.py: same
3238 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3239 unnecessary init code
3240 (Bot.remote_setBuilderList): match it
3242 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3244 * buildbot/changes/mail.py (parseSyncmail): update comment
3246 * buildbot/test/test_slavecommand.py: disable Shell tests on
3247 platforms that don't suport IReactorProcess
3249 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3250 all places where we open logfiles. It causes OS-X to open the file
3251 in some weird mode that that prevents us from mixing reads and
3252 writes to the same filehandle, which we depend upon to implement
3253 _generateChunks properly. This change doesn't appear to break
3254 win32, on which "b" and "t" are treated differently but a missing
3255 flag seems to be interpreted as "t".
3257 2005-07-18 Brian Warner <warner@lothar.com>
3259 * buildbot/slave/commands.py (ShellCommand): overhaul
3260 error-handling code, to try and make timeout/interrupt work
3261 properly, and make win32 happier
3262 * buildbot/test/test_slavecommand.py: clean up, stop using
3263 reactor.iterate, add tests for timeout and interrupt
3264 * buildbot/test/sleep.py: utility for a new timeout test
3266 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3267 code from the local-usebranches branch
3269 2005-07-17 Brian Warner <warner@lothar.com>
3271 * buildbot/process/process_twisted.py
3272 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3273 minutes, to match the other twisted BuildFactories, and don't
3274 excuse failures in c/qt/win32 reactors any more.
3276 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3277 'freebsd' builders, since the buildslaves have been unavailable
3280 2005-07-13 Brian Warner <warner@lothar.com>
3282 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3283 build-on-branch feature
3285 * buildbot/process/step.py (Darcs.__init__): add base_url and
3286 default_branch arguments, just like SVN
3287 (Arch.__init__): note that the version= argument is really the
3290 * buildbot/slave/commands.py (SourceBase): keep track of the
3291 repository+branch that was used for the last checkout in
3292 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3293 match, we clobber the directory and perform a fresh checkout
3294 rather than trying to do an in-place update. This should protect
3295 us against trying to get to branch B by doing an update in a tree
3296 obtained from branch A.
3297 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3298 (SVN.setup): same, just the svnurl
3299 (Darcs.setup): same, just the repourl
3300 (Arch.setup): same, arch coordinates (url), version, and
3301 buildconfig. Also pull the buildconfig from the args dictionary,
3302 which we weren't doing before, so the build-config was effectively
3304 (Arch.sourcedirIsUpdateable): don't try to update when we're
3305 moving to a specific revision: arch can't go backwards, so it is
3306 safer to just clobber the tree and checkout a new one at the
3308 (Bazaar.setup): same sourcedata as Arch
3310 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3311 use maybeWait, to work with twisted-1.3.0 and twcompat
3312 (Dependencies.testRun_Pass): same
3314 * buildbot/test/test_vc.py: rearrange, cleanup
3316 * buildbot/twcompat.py: add defer.waitForDeferred and
3317 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3318 can work under twisted-1.3.0 .
3320 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3321 now created at setUp time. This increases the runtime of the test
3322 suite considerably (from 91 seconds to 151), but it removes the
3323 need for an offline tarball, which should solve a problem I've
3324 seen where the test host has a different version of svn than the
3325 tarball build host. The new code also validates that mode=update
3326 really picks up recent commits. This approach will also make it
3327 easier to test out branches, because the code which creates the VC
3328 branches is next to the code which uses them. It will also make it
3329 possible to test some change-notification hooks, by actually
3330 performing a VC commit and watching to see the ChangeSource get
3333 2005-07-12 Brian Warner <warner@lothar.com>
3335 * docs/buildbot.texinfo (SVN): add branches example
3336 * docs/Makefile (buildbot.ps): add target for postscript manual
3338 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3339 * buildbot/test/test_locks.py: same
3341 * buildbot/process/step.py (Darcs): comment about default branches
3343 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3344 c['interlocks'] in the config file, complain if it is present.
3345 Scan all locks in c['builders'] to make sure the Locks they use
3347 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3348 add some tests to check for non-uniquely-named Locks
3349 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3350 since the unique-Lock validation code requires it now
3352 * buildbot/locks.py: fix test-case-name
3354 * buildbot/interlock.py: remove old file
3356 2005-07-11 Brian Warner <warner@lothar.com>
3358 * buildbot/test/test_interlock.py: rename to..
3359 * buildbot/test/test_locks.py: .. something shorter
3361 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3362 versions (after 2.0.1) changed internet.TCPClient to shut down the
3363 connection in stopService. Change the code to handle this
3366 * buildbot/process/base.py (Build): handle whole-Build locks
3367 * buildbot/process/builder.py (Builder.compareToSetup): same
3368 * buildbot/test/test_interlock.py: make tests work
3370 * buildbot/process/step.py (BuildStep.startStep): complain if a
3371 Step tries to claim a lock that's owned by its own Build
3372 (BuildStep.releaseLocks): typo
3374 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3375 file reloads don't replace unchanged Builders
3377 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3378 rewrite to cover new Locks instead of old c['interlocks']
3379 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3383 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3384 start the master and connect the buildslave
3386 * buildbot/process/step.py (FailingDummy.done): finish with a
3387 FAILURE status rather than raising an exception
3389 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3390 stringify a BuildRequest.reason that is None
3392 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3394 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3395 allow scheduler.Dependent to work
3396 * buildbot/buildset.py (BuildSet): set .reason and .results
3398 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3399 slaves, to make the test stop hanging. It still fails, of course,
3400 because I haven't even started to implement Locks.
3402 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3404 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3405 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3406 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3407 (Dependent): new class for downstream build dependencies
3408 * buildbot/test/test_dependencies.py: tests (still failing)
3410 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3412 2005-07-07 Brian Warner <warner@lothar.com>
3414 * buildbot/test/runutils.py (RunMixin): factored this class out..
3415 * buildbot/test/test_run.py: .. from here
3416 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3417 added new buildbot.locks tests (which all hang right now)
3418 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3419 * buildbot/process/step.py: claim/release per-BuildStep locks
3421 * docs/Makefile: add 'buildbot.html' target
3423 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3424 interpreted as "HEAD", so that all VC steps can accept branch=None
3425 and have it mean the "default branch".
3427 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3429 2005-07-07 Brian Warner <warner@lothar.com>
3431 * docs/examples/twisted_master.cfg: update to match current usage
3433 * docs/buildbot.texinfo (System Architecture): comment out the
3434 image, it doesn't exist yet and just screws up the HTML manual.
3436 2005-07-05 Brian Warner <warner@lothar.com>
3438 * debian/.cvsignore: oops, missed one. Removing leftover file.
3440 2005-06-17 Brian Warner <warner@lothar.com>
3442 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3443 changed its output in 1.2.0, don't mistakenly think that the
3444 subversion we find isn't capable of supporting our tests.
3446 * debian/*: remove the debian/ directory and its contents, to make
3447 life easier for the proper Debian maintainer
3449 * Makefile (release): same
3451 2005-06-07 Brian Warner <warner@lothar.com>
3453 * everything: create a distinct SourceStamp class to replace the
3454 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3455 Changed the signature of Source.startVC to include the revision
3456 information (instead of passing it through self.args). Implement
3457 branches for SVN (now only Darcs/Git is missing support). Add more
3460 2005-06-06 Brian Warner <warner@lothar.com>
3462 * everything: rearrange build scheduling. Create a new Scheduler
3463 object (configured in c['schedulers'], which submit BuildSets to a
3464 set of Builders. Builders can now use multiple slaves. Builds can
3465 be run on alternate branches, either requested manually or driven
3466 by changes. This changed some of the Status classes. Interlocks
3467 are out of service until they've been properly split into Locks
3468 and Dependencies. treeStableTimer, isFileImportant, and
3469 periodicBuild have all been moved from the Builder to the
3471 (BuilderStatus.currentBigState): removed the 'waiting' and
3472 'interlocked' states, removed the 'ETA' argument.
3474 2005-05-24 Brian Warner <warner@lothar.com>
3476 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3477 erroneously abandons the connection (in clientConnectionFailed)
3478 for non-UserErrors, which means that if we lose the connection due
3479 to a network problem or a timeout, we'll never try to reconnect.
3480 Fix this by not upcalling to the buggy parent method. Note:
3481 twisted-2.0 fixes this, but the function only has 3 lines so it
3482 makes more sense to copy it than to try and detect the buggyness
3483 of the parent class. Fixes SF#1207588.
3485 * buildbot/changes/changes.py (Change.branch): doh! Add a
3486 class-level attribute to accomodate old Change instances that were
3487 pickled before 0.6.5 (where .branch was added for new Changes).
3488 This fixes the exception that occurs when you try to look at an
3489 old Change (through asHTML).
3491 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3494 2005-05-23 Brian Warner <warner@lothar.com>
3496 * buildbot/__init__.py (version): release 0.6.6
3498 2005-05-23 Brian Warner <warner@lothar.com>
3500 * NEWS: update for 0.6.6 release
3501 * debian/changelog: same
3503 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3504 before starting: this was done by twistd back when we spawned it,
3505 now that we're importing the pieces and running them in the
3506 current process, we have to do it ourselves. This allows
3507 master.cfg to import files from the same directory without
3508 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3509 Stichele for the catch.
3510 (Options.opt_version): Add a --version command (actually, just make
3511 the existing --version command emit Buildbot's version too)
3513 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3514 fix to make this behave like other LogFiles, this time to handle
3515 existing LogFiles on disk. (add the missing .upgrade method)
3516 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3518 2005-05-21 Brian Warner <warner@lothar.com>
3520 * buildbot/test/test_runner.py (Create.testMaster): match the
3521 rawstring change in runner.py:masterTAC
3523 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3524 TwistedWords is installed
3525 * buildbot/test/test_status.py: same, with TwistedMail
3527 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3528 some old, deprecated, and removed config keys). This should enable
3529 you to use the base buildbot functionality with Twisted-2.0.0 when
3530 you don't also have TwistedWeb and TwistedWords installed
3532 2005-05-20 Brian Warner <warner@lothar.com>
3534 * buildbot/scripts/runner.py (run): call sendchange(), not
3535 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3536 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3537 (stop): don't wait for process to die when sending SIGHUP
3538 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3539 directory name gets interpreted, which you don't want
3542 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3545 2005-05-18 Brian Warner <warner@lothar.com>
3547 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3549 2005-05-18 Brian Warner <warner@lothar.com>
3551 * README: update for 0.6.5
3552 * debian/changelog: same
3554 * buildbot/changes/changes.py: rename tag= to branch=, since
3555 that's how we're using it, and my design for the upcoming "build a
3556 specific branch" feature wants it. also, tag= was too CVS-centric
3557 * buildbot/changes/mail.py (parseSyncmail): same
3558 * buildbot/process/base.py (Build.isBranchImportant): same
3559 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3560 * docs/buildbot.texinfo (Attributes of Changes): same
3562 * NEWS: update tag=, update for upcoming release
3564 2005-05-17 Brian Warner <warner@lothar.com>
3566 * buildbot/scripts/runner.py (stop): actually poll once per
3567 second, instead of re-killing the poor daemon once per second.
3568 Sleep briefly (0.1s) before the first poll, since there's a good
3569 chance we can avoid waiting the full second if the daemon shuts
3570 down quickly. Also remove the sys.exit() at the end.
3571 (start): remove the unneighborly sys.exit()
3573 * Makefile: improve permission-setting to not kick Arch so badly
3575 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3576 default --keepalive=600, since it doesn't hurt very much, and it's
3577 a hassle to discover that you need it.
3578 * buildbot/test/test_runner.py (Create.testSlave): test it
3580 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3581 IRC bot about EXCEPTION
3583 * buildbot/status/client.py (PBListener): upcall more correctly
3585 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3586 an exception mark the overall build with EXCEPTION, not SUCCESS
3588 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3590 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3591 * Makefile: update some release-related stuff
3593 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3594 gets called when there isn't actually an active process, just end
3595 the Command instead of blowing up. I don't know how it gets into
3596 this state, but the twisted win32 buildslave will sometimes hang,
3597 and when it shakes its head and comes back, it thinks it's still
3598 running a Command. The next build causes this command to be
3599 interrupted, but the lack of self.process.pid breaks the interrupt
3602 * NEWS: document changes since the last release
3604 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3605 look for Makefile.buildbot instead of a bare Makefile . The
3606 'buildbot start' does not install this file, so you have to
3607 manually copy it if you want to customize startup behavior.
3608 (createMaster): change 'buildbot master' command to create
3609 Makefile.sample instead of Makefile, to create master.cfg.sample
3610 instead of master.cfg (requiring you to copy it before the
3611 buildmaster can be started). Both sample files are kept up to
3612 date, i.e. they are overwritten if they have been changed. The
3613 'buildbot.tac' file is *not* overwritten, but if the new contents
3614 don't match the old, a 'buildbot.tac.new' file is created and the
3615 user is warned. This seems to be a much more sane way to handle
3616 startup files. Also, don't sys.exit(0) when done, so we can run
3617 unit tests against it.
3618 (createSlave): same. Don't overwrite the sample info/ files.
3619 * buildbot/scripts/sample.mk: remove. the contents were pulled
3620 into runner.py, since they need to match the behavior of start()
3624 * docs/buildbot.texinfo (Launching the daemons): document it
3625 * buildbot/test/test_runner.py (Create): test it
3627 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3628 version that can handle string-in-string tests, because otherwise
3629 python-2.2 fails the tests. It'd be tremendous if Trial's test
3630 took two strings under 2.2 too.
3632 * everything: fixed all deprecation warnings when running against
3633 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3634 few that come from Twisted itself). This involved putting most of
3635 the Twisted-version specific code in the new buildbot.twcompat
3636 module, and creating some abstract base classes in
3637 buildbot.changes.base and buildbot.status.base (which might be
3638 useful anyway). __implements__ is a nuisance and requires an ugly
3639 'if' clause everywhere.
3641 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3642 delay before finishing the test: it seems that smtp.sendmail
3643 doesn't hang up on the server, so we must wait a moment so it can
3644 hang up on us. This removes the trial warning about an unclean
3647 2005-05-16 Brian Warner <warner@lothar.com>
3649 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3650 tuple of (delay, repeats).
3651 * buildbot/test/test_vc.py (Retry): test it
3652 * docs/buildbot.texinfo (Source Checkout): document it
3653 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3654 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3655 doVCFull() are handled by re-trying the checkout (after a delay)
3656 some number of times.
3657 (ShellCommand._startCommand): make header lines easier to read
3659 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3661 (WebTest.test_logfile): make sure master gets shut down, silences
3662 some "unclean reactor" test errors
3664 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3665 reactor once after shutdown, something in certain versions of
3666 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3667 fails, svn-trunk is ok.
3669 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3670 second win32 error message
3672 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3673 validating the ETA, so the tests don't fail on slow systems
3675 2005-05-15 Brian Warner <warner@lothar.com>
3677 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3678 the new LogFile class, so upgrading works properly
3679 (LogFileProducer.resumeProducing): survive resumeProducing after
3680 we've exhausted the chunkGenerator
3682 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3684 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3685 (Log.testUpgrade): same
3687 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3688 Builds and logs with a cron job.
3690 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3691 of the old non-offline LogFile, added code to upgrade these to
3692 new-style contents-live-on-disk instances at load time (in a way
3693 that doesn't invalidate the old Build pickles, so upgrading to
3694 0.6.5 is not a one-way operation). Got rid of everything related
3696 (LogFile.__init__): create LogFiles with the parent step status,
3697 the log's name, and a builder-relative filename where it can keep
3698 the contents on disk.
3699 (LogFile.hasContents): new method, clients are advised to call it
3700 before getText or getChunks and friends. If it returns False, the
3701 log's contents have been deleted and getText() will raise an
3703 (LogFile.getChunks): made it a generator
3704 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3705 Consumer (except one that takes chunks instead of strings). This
3706 enables streaming of very large logfiles without storing the whole
3708 (BuildStatus.generateLogfileName): create names like
3709 12-log-compile-output, with a _0 suffix if required to be unique
3710 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3711 or earlier) logfiles into new-style ones
3712 (BuilderStatus): remove everything related to 'stub' builds. There
3713 is now only one build cache, and we don't strip logs from old
3715 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3716 since we no longer fight to keep it in the cache
3718 * buildbot/status/html.py (TextLog.render_GET): use a
3719 ChunkConsumer to stream the log entries efficiently.
3720 (ChunkConsumer): wrapper which consumes chunks and writes
3723 * buildbot/test/test_twisted.py (Parse.testParse): use a
3724 LogFile-like object instead of a real one
3726 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3727 (Log.testMerge3): validate more merge behavior
3728 (Log.testChunks): validate LogFile.getChunks
3729 (Log.testUpgrade): validate old-style LogFile upgrading
3730 (Log.testSubscribe): validate LogFile.subscribe
3731 (Log.testConsumer): validate LogFile.subscribeConsumer
3733 * buildbot/interfaces.py (IStatusLogStub): remove
3734 (IStatusLog.subscribeConsumer): new method
3735 (IStatusLog.hasContents): new method
3736 (IStatusLogConsumer): describes things passed to subscribeConsumer
3738 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3739 the log contents if it does not have any contents.
3740 (StatusResourceBuildStep.body): same
3741 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3743 2005-05-14 Brian Warner <warner@lothar.com>
3745 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3746 timeouts to try and make the windows metabuildslave not hang
3748 2005-05-13 Mike Taylor <bear@code-bear.com>
3750 * buildbot/slave/commands.py (rmdirRecursive): added a check
3751 to ensure the path passed into rmdirRecursive actually exists.
3752 On win32 a non-existant path would generate an exception.
3754 2005-05-13 Brian Warner <warner@lothar.com>
3756 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3757 shutil.rmtree which behaves correctly on windows in the face of
3758 files that you have to chmod before deleting. Thanks to Bear at
3759 the OSAF for the routine.
3760 (SourceBase.doClobber): use rmdirRecursive
3762 2005-05-12 Brian Warner <warner@lothar.com>
3764 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3765 method generate chunks instead of returning a big list. This
3766 allows the same method to be used for both old LogFile and new
3768 (OfflineLogFile.getText): use the generator
3769 (OfflineLogFile.subscribe): same
3770 * buildbot/status/html.py (TextLog.resumeProducing): same
3771 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3773 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3774 point out that OfflineLogFile does not currently work with
3775 html.Waterfall . Fixing this is high-priority.
3777 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3778 apparently windows defaults to using stdout
3780 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3781 better message on failure so I can figure out the win32 problem
3783 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3784 log messages to include more useful copies of the command being
3785 run, the argv array, and the child command's environment.
3786 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3788 2005-05-11 Brian Warner <warner@lothar.com>
3790 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3792 * Makefile: update the deb-snapshot version
3794 * docs/buildbot.texinfo: move all .xhtml docs into a new
3795 .texinfo-format document, adding a lot of material in the process.
3796 This is starting to look like a real user's manual. Removed all
3797 the Lore-related files: *.xhtml, *.css, template.tpl .
3798 * docs/Makefile: simple makefile to run 'makeinfo'
3799 * buildbot/scripts/sample.cfg: rearrange slightly
3800 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3802 2005-05-10 Brian Warner <warner@lothar.com>
3804 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3805 different name for the internal twistw module, handle it.
3807 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3808 * setup.py: .. and stop trying to install it
3810 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3811 'git'), the new linux kernel VC system (http://kernel.org/git/).
3812 Thanks to Brandon Philips for the patch.
3813 * buildbot/slave/commands.py (Git): same
3815 2005-05-06 Brian Warner <warner@lothar.com>
3817 * buildbot/status/builder.py (OfflineLogFile): replace the default
3818 LogFile with a form that appends its new contents to a disk file
3819 as they arrive. The complete log data is never kept in RAM. This
3820 is the first step towards handling very large (100MB+) logfiles
3821 without choking quite so badly. (The other half is
3822 producer/consumer on the HTML pages).
3823 (BuildStepStatus.addLog): use OfflineLogFile by default
3824 (BuildStatus.getLogfileName): helper code to give the
3825 OfflineLogFile a filename to work with
3827 * buildbot/test/test_status.py (Results.testAddResults): update
3828 tests to handle new asserts
3829 * buildbot/test/test_vc.py (Patch.doPatch): same
3830 * buildbot/test/test_steps.py (BuildStep.setUp): same
3832 2005-05-05 Brian Warner <warner@lothar.com>
3834 * buildbot/scripts/runner.py (start): if there is no Makefile,
3835 launch the app by importing twistd's internals and calling run(),
3836 rather than spawning a new twistd process. This stands a much
3837 better chance of working under windows.
3838 (stop): kill the process with os.kill instead of spawning
3839 /bin/kill, again to reduce the number of external programs which
3840 windows might not have in the PATH. Also wait up to 5 seconds for
3841 the process to go away, allowing things like 'buildbot stop;
3842 buildbot start' to be reliable in the face of slow shutdowns.
3844 * buildbot/master.py (Dispatcher.__getstate__): remove old
3845 .tap-related methods
3846 (BuildMaster.__getstate__): same
3848 * buildbot/slave/bot.py (makeService): same
3849 (Options.longdesc): same
3850 * buildbot/scripts/runner.py: copy over some old mktap option text
3852 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3853 'buildbot master' now creates a buildbot.tac file, so there is no
3854 longer a create-instance/save/reload sequence. mktap is dead, long
3856 * buildbot/scripts/sample.mk: use twistd -y, not -f
3857 * buildbot/test/test_config.py: remove mktap-based test
3858 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3859 * README: don't reference mktap
3861 * docs/source.xhtml: document some of the attributes that Changes
3864 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3866 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3867 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3868 * buildbot/changes/changes.py (Change)
3869 * buildbot/changes/mail.py (parseSyncmail)
3870 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3872 * buildbot/process/base.py (Build.isTagImportant)
3876 2005-05-04 Brian Warner <warner@lothar.com>
3878 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3879 connection after sending the change, so that unit tests don't
3880 complain about sockets being left around
3882 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3883 exception in phase=0 rendering
3884 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3886 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3888 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3889 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3890 and configuring builders with tuples.
3891 * buildbot/test/test_config.py: stop testing compatibility with
3892 deprecated config keys
3893 * buildbot/test/test_run.py: same
3895 2005-05-03 Brian Warner <warner@lothar.com>
3897 * contrib/arch_buildbot.py: survive if there are no logfiles
3898 (username): just use a string, os.getlogin isn't reliable
3900 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3901 so 'buildbot sendchange' actually works. The earlier test only
3902 covered the internal (non-reactor-running) form.
3904 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3905 script to notify the buildmaster about changes
3907 * buildbot/scripts/runner.py (sendchange): new command to send a
3908 change to a buildbot.changes.pb.PBChangeSource receiver.
3909 * buildbot/test/test_changes.py (Sender): test it
3911 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3912 after any reading of the config file, not just when we do it in
3913 startService. This makes some tests a bit cleaner.
3915 * buildbot/changes/pb.py: add some log messages
3917 * buildbot/process/base.py (Build.startBuild): fix a bug that
3918 caused an exception when the build terminated in the very first
3920 (Build.stepDone): let steps return a status of EXCEPTION. This
3921 terminates the build right away, and sets the build's overall
3922 status to EXCEPTION too.
3923 * buildbot/process/step.py (BuildStep.failed): return a status of
3924 EXCEPTION when that is what has happened.
3926 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3927 implement this, allowing Arch-based projects to get precise
3928 checkouts instead of always using the latest code
3929 (Bazaar): create variant of Arch to let folks use baz instead of
3930 tla. Requires a new buildslave too.
3931 * buildbot/slave/commands.py (Arch): add 'revision' argument
3932 (Bazaar): create variant of Arch that uses baz instead of tla.
3933 Remove the code that extracts the archive name from the
3934 register-archive output, since baz doesn't provide it, and require
3935 the user provide both the archive name and its location.
3936 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3938 2005-05-02 Brian Warner <warner@lothar.com>
3940 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3941 thanks to Nick Trout.
3943 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3944 deals better with source Makefile coming from a read-only CVS
3945 checkout. Thanks to Nick Trout for the catch.
3947 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3950 2005-04-28 Brian Warner <warner@lothar.com>
3952 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3954 * debian/changelog: update for 0.6.4
3956 2005-04-28 Brian Warner <warner@lothar.com>
3958 * README.w32: add a checklist of steps for getting buildbot
3960 * MANIFEST.in: include it in the tarball
3964 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3965 broken .tap files from 0.6.3 by getting rid of .services,
3966 .namedServices, and .change_svc at load time.
3968 2005-04-27 Brian Warner <warner@lothar.com>
3970 * NEWS: update in preparation for new release
3972 * buildbot/test/test_config.py (Save.testSave): don't pull in
3973 twisted.scripts.twistd, we don't need it and it isn't for windows
3976 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3977 accomodate win32 which can't do atomic-rename
3979 2005-04-27 Brian Warner <warner@lothar.com>
3981 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3982 timeouts to help the slow metabuildbot not flunk them so much
3983 (Disconnect.testBuild3): same
3984 (Disconnect.testBuild4): same
3985 (Disconnect.testInterrupt): same
3987 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3988 setup, it was completely broken for new buildmasters (those which
3989 did not have a 'change.pck' already saved. Thanks to Paul Warren
3990 for catching this (embarrassing!) bug.
3991 (Dispatcher.__getstate__): don't save our registered avatar
3992 factories, since they'll be re-populated when the config file is
3994 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3995 tests (since the real mktap-generated BuildMaster doesn't save
3997 (BuildMaster.__getstate__): don't save any service children,
3998 they'll all be re-populated when the config file is re-read.
3999 * buildbot/test/test_config.py (Save.testSave): test for this
4001 2005-04-26 Brian Warner <warner@lothar.com>
4003 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4004 rendered with Blender.. looks a bit nicer.
4005 * buildbot/docs/images/icon.blend: add the Blender file for it
4007 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4008 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4009 running under windows. This appears to be the best way to allow
4010 BuildSteps to do something normal like 'trial -v buildbot.test' or
4011 'make foo' and still expect it to work. The idea is to make the
4012 BuildSteps look as much like what a developer would type when
4013 compiling or testing the tree by hand. This approach probably has
4014 problems when there are spaces in the arguments, so if you've got
4015 windows buildslaves, you'll need to pay close attention to your
4018 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4019 timezone to the timestamp column.
4020 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4022 * buildbot/scripts/runner.py (loadOptions): do something sane for
4023 windows, I think. We use %APPDATA%/buildbot instead of
4024 ~/.buildbot, but we still search everywhere from the current
4025 directory up to the root for a .buildbot/ subdir. The "is it under
4026 $HOME" security test was replaced with "is it owned by the current
4027 user", which is only performed under posix.
4028 * buildbot/test/test_runner.py (Options.testFindOptions): update
4029 tests to match. The "is it owned by the current user" check is
4030 untested. The test has been re-enabled for windows.
4032 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4033 any "\n" in the expected output with the platform-specific line
4034 separator. Make this separator "\r\n" on PTYs under unix, they
4035 seem to do that and I don't know why
4037 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4038 windows for now, I don't know what ~/.buildbot/ should mean there.
4040 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4041 win32 compatibility, don't use "/tmp"
4042 (Basedir.testChangeBuilddir): remove more unixisms
4044 2005-04-26 Brian Warner <warner@lothar.com>
4046 * buildbot/test/test_control.py (Force.rmtree): python2.2
4047 compatibility, apparently its shutil.rmtree ignore_errors=
4048 argument is ignored.
4049 * buildbot/test/test_run.py (Run.rmtree): same
4050 (RunMixin.setUp): same
4052 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4055 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4056 'substring in string' operator, must use string.find(substr)!=-1
4057 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4058 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4060 * buildbot/scripts/runner.py (loadOptions): add code to search for
4061 ~/.buildbot/, a directory with things like 'options', containing
4062 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4063 the current directory, your $HOME directory, or anywhere
4064 inbetween, as long as you're somewhere inside your home directory.
4065 (debugclient): look in ~/.buildbot/options for master and passwd
4066 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4067 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4069 * buildbot/status/client.py (makeRemote): new approach to making
4070 IRemote(None) be None, which works under Twisted-2.0
4071 * buildbot/test/test_status.py (Client.testAdaptation): test it
4073 * buildbot/status/builder.py (Status.builderAdded): when loading a
4074 pickled BuilderStatus in from disk, set its name after loading.
4075 The config file might have changed its name (but not its
4076 directory) while it wasn't looking.
4078 * buildbot/process/builder.py (Builder.attached): always return a
4079 Deferred, even if the builder was already attached
4080 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4082 2005-04-25 Brian Warner <warner@lothar.com>
4084 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4085 category-related exception when announcing a build has finished
4087 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4088 reference no-longer-existent changemaster.sources
4089 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4091 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4094 2005-04-25 Brian Warner <warner@lothar.com>
4096 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4098 * debian/changelog: update for 0.6.3
4100 2005-04-25 Brian Warner <warner@lothar.com>
4102 * MANIFEST.in: make sure debug.glade is in the tarball
4104 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4106 * NEWS: update for the imminent 0.6.3 release
4108 * buildbot/status/html.py (HtmlResource.content): make the
4109 stylesheet <link> always point at "buildbot.css".
4110 (StatusResource.getChild): map "buildbot.css" to a static.File
4111 containing whatever css= argument was provided to Waterfall()
4112 (Waterfall): provide the "classic" css as the default.
4113 * docs/waterfall.classic.css: move default CSS from here ..
4114 * buildbot/status/classic.css: .. to here
4116 * MANIFEST.in: make sure classic.css is included in the tarball
4117 * setup.py: and that it is installed too, under buildbot/status/
4119 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4120 the module level, because buildbot.tap files from 0.6.2 don't have
4121 it in their attribute dictionary.
4123 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4124 really exists at startup, might save some confusion somewhere.
4126 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4128 * docs/waterfall.classic.css:
4129 add a stylesheet that's almost the same as the "classic"
4132 * buildbot/status/builder.py:
4133 add EXCEPTION as a result - this is a problem for the bot
4134 maintainer, not a build problem for the changers
4135 * buildbot/process/step.py:
4136 use EXCEPTION instead of FAILURE for exceptions
4137 * buildbot/status/html.py:
4138 add build_get_class to get a class out of a build/buildstep
4139 finish naming the classes
4140 split out sourceNames to changeNames and builderNames so we
4141 can style them separately
4142 * docs/config.xhtml:
4143 finish documenting classes as they are right now
4145 * buildbot/status/html.py:
4146 name the classes as we agreed on IRC
4147 * docs/config.xhtml:
4150 * buildbot/status/html.py:
4151 same for cssclass->class_
4153 * buildbot/status/html.py:
4154 as decided on IRC, use class_ for the "class" attribute to not
4155 conflict with the class keyword, and clean up the messy **{} stuff.
4157 * buildbot/status/mail.py:
4158 put back "builders" argument, and fix docstring, because the
4159 code *ignores* builders listed in this argument
4161 * buildbot/process/builder.py:
4162 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4164 * docs/config.xhtml:
4165 describe the category argument for builders
4167 * buildbot/status/builder.py:
4168 Fix a silly bug due to merging
4170 * buildbot/process/builder.py:
4171 remove category from the process Builder ...
4172 * buildbot/status/builder.py:
4173 ... and add it to BuilderStatus instead.
4174 Set category on unpickled builder statuses, they might not have it.
4175 * buildbot/master.py:
4176 include category when doing builderAdded
4177 * buildbot/status/mail.py:
4178 return None instead of self for builders we are not interested in.
4179 * buildbot/test/test_run.py:
4180 fix a bug due to only doing deferredResult on "dummy" waiting
4181 * buildbot/test/test_status.py:
4182 add checks for the Mail IStatusReceiver returning None or self
4184 * buildbot/status/html.py:
4185 fix testsuite by prefixing page title with BuildBot
4187 * buildbot/status/builder.py:
4188 have .category in builder status ...
4189 * buildbot/process/builder.py:
4190 ... and set it from Builder
4191 * buildbot/status/html.py:
4192 make .css a class variable
4193 * buildbot/test/test_status.py:
4194 write more tests to cover our categories stuff ...
4195 * buildbot/status/mail.py:
4196 ... and fix the bug that this uncovered
4198 * buildbot/changes/mail.py:
4199 * buildbot/changes/pb.py:
4200 * buildbot/master.py:
4201 * buildbot/process/base.py:
4202 * buildbot/process/factory.py:
4203 * buildbot/process/interlock.py:
4204 * buildbot/process/step.py:
4205 * buildbot/process/step_twisted.py:
4206 * buildbot/slave/commands.py:
4207 * buildbot/status/builder.py:
4208 * buildbot/status/client.py:
4209 * buildbot/status/html.py:
4210 * buildbot/status/mail.py:
4211 * buildbot/status/progress.py:
4212 * buildbot/test/test_changes.py:
4213 * buildbot/test/test_config.py:
4214 * buildbot/test/test_control.py:
4215 * buildbot/test/test_interlock.py:
4216 * buildbot/test/test_maildir.py:
4217 * buildbot/test/test_mailparse.py:
4218 * buildbot/test/test_run.py:
4219 * buildbot/test/test_slavecommand.py:
4220 * buildbot/test/test_status.py:
4221 * buildbot/test/test_steps.py:
4222 * buildbot/test/test_twisted.py:
4223 * buildbot/test/test_util.py:
4224 * buildbot/test/test_vc.py:
4225 * buildbot/test/test_web.py:
4227 add test-case-name at the top of a whole set of files
4229 * buildbot/status/builder.py:
4230 keep order of addition when getting builder names
4231 * buildbot/status/words.py:
4232 * buildbot/test/test_run.py:
4233 add test for getBuilderNames
4235 * buildbot/process/base.py:
4236 * buildbot/process/step.py:
4237 * buildbot/status/builder.py:
4238 * buildbot/status/html.py:
4239 make buildbot css-able
4240 replace the color code for purple with purple, don't understand
4241 why it wasn't purple to start with
4243 * buildbot/status/words.py:
4244 ok, so it doesn't look like BuilderStatus.remote is still valid.
4245 Use what waterfall uses instead.
4247 * buildbot/interfaces.py:
4248 * buildbot/status/builder.py:
4249 * buildbot/status/html.py:
4250 * buildbot/status/mail.py:
4251 * buildbot/status/words.py:
4252 * buildbot/test/test_run.py:
4253 use categories everywhere and make it be a list. More sensible
4254 for the future. Also make words actually respect this in
4257 * buildbot/interfaces.py:
4258 add category argument to getBuilderNames
4259 * buildbot/process/builder.py:
4260 * buildbot/status/builder.py:
4261 * buildbot/status/html.py:
4262 * buildbot/status/mail.py:
4263 * buildbot/status/words.py:
4264 * buildbot/test/test_run.py:
4265 move from specifying builders by name to specifying the category
4267 * buildbot/status/html.py:
4268 * buildbot/status/words.py:
4269 add "builders=" to __init__ of status clients so they can
4270 limit themselves to the given list of builders to report on
4272 * buildbot/status/html.py: set the title to the product name
4274 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4276 * buildbot/interfaces.py:
4277 * buildbot/status/builder.py:
4278 more documentation. Hm, not sure if ChangeLog entries make sense
4281 2005-04-23 Brian Warner <warner@lothar.com>
4283 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4285 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4287 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4288 the sub-commands that log buildmaster status to stdout and to a
4289 GUI window, respectively.
4291 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4292 functionality is working again, but all the step-status and ETA
4293 stuff is missing. Commented out a lot of code pending more
4296 * buildbot/status/client.py: make sure that IRemote(None) is None
4298 * buildbot/changes/changes.py: import defer, oops
4299 (ChangeMaster): remove the .sources list, rely upon the fact that
4300 MultiServices can be treated as sequences of their children. This
4301 cleans up the add/remove ChangeSource routines a lot, as we keep
4302 exactly one list of the current sources instead of three.
4304 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4305 up an empty ChangeMaster at init time.
4306 (BuildMaster.loadChanges): if there are changes to be had from
4307 disk, replace self.change_svc with the new ones. If not, keep
4308 using the empty ChangeMaster set up in __init__.
4309 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4310 instead of a separate list, makes the code a bit cleaner.
4311 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4312 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4313 Extend the test to make sure we can get rid of the sources when
4316 2005-04-22 Brian Warner <warner@lothar.com>
4318 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4319 and info/host files when making the slave directory
4321 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4322 whendone= argument, just return the Deferred and let the caller do
4323 what they want with it.
4324 (Disconnect.testBuild1): wait for shutdownSlave
4325 (Basedir.testChangeBuilddir): new test to make sure changes to the
4326 builddir actually get propagated to the slave
4328 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4329 explicit method, rather than passing the builddir in __init__ .
4330 Make sure to update self.basedir too, this was broken before.
4331 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4332 builders and for ones that have just had their builddir changed.
4333 (BotFactory): add a class-level .perspective attribute, so
4334 BuildSlave.waitUntilDisconnected won't get upset when the
4335 connection hasn't yet been established
4336 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4337 tests can reach through it to inspect the SlaveBuilders
4339 * buildbot/process/base.py (Build.buildException): explain the
4340 log.err with a log.msg
4341 * buildbot/process/builder.py (Builder.startBuild): same
4342 (Builder._startBuildFailed): improve error message
4344 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4345 occurred because we lost the brand-new connection, retry instead
4346 of giving up. If not, it's probably an authorization failure, and
4347 it makes sense to stop trying. Make sure we log.msg the reason
4348 that we're log.err'ing the failure, otherwise test failures are
4349 really hard to figure out.
4351 * buildbot/master.py: change loadConfig() to return a Deferred
4352 that doesn't fire until the change has been fully implemented.
4353 This means any connected slaves have been updated with the new
4354 builddir. This change makes it easier to test the code which
4355 actually implements this builddir-updating.
4356 (BotPerspective.addBuilder): return Deferred
4357 (BotPerspective.removeBuilder): same
4358 (BotPerspective.attached): same
4359 (BotPerspective._attached): same. finish with remote_print before
4360 starting the getSlaveInfo, instead of doing them in parallel
4361 (BotPerspective.list_done): same
4362 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4363 actually calling slave.disconnect()
4364 (BotMaster.addBuilder): same
4365 (BotMaster.removeBuilder): same
4366 (BuildMaster.loadConfig): same
4367 (BuildMaster.loadConfig_Slaves): same
4368 (BuildMaster.loadConfig_Sources): same
4369 (BuildMaster.loadConfig_Builders): same
4370 (BuildMaster.loadConfig_status): same
4372 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4373 a Deferred that fires when the source is finally removed
4375 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4376 the previous tree on win32, where we have to do it synchronously,
4377 make sure we return a Deferred anyway.
4378 (SourceBase.doCopy): same
4380 * buildbot/scripts/runner.py (statusgui): use the text client for
4381 now, while I rewrite the Gtk one
4382 * buildbot/clients/base.py: strip out old code, leaving just the
4383 basic print-message-on-event functionality. I also remove the
4384 ReconnectingPBClientFactory, but it does at least quit when it
4385 loses the connection instead of going silent
4387 2005-04-21 Brian Warner <warner@lothar.com>
4389 * Makefile: minor tweaks
4391 * NEWS: point out deprecation warnings, new features for
4394 * buildbot/master.py (BuildMaster.loadConfig): emit
4395 DeprecationWarnings for Builders defined with tuples. Rearrange
4396 code to facility removal of deprecated configuration keys in the
4399 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4400 'buildbot' command to put a little Makefile in the target that
4401 helps you re-create the buildbot.tap file, start or stop the
4402 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4403 all the files 0600, since they contain passwords.
4404 (start): if there is a Makefile, and /usr/bin/make exists, use
4405 'make start' in preference to a raw twistd command. This lets
4406 slave admins put things like PYTHONPATH variables in their
4407 Makefiles and have them still work when the slave is started with
4408 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4409 be nice to first try the 'make' command and only fall back to
4410 twistd if it fails. TODO: the Makefile's "start" command does not
4411 add the --reactor=win32 argument when running under windows.
4412 (Options.debugclient, Options.statusgui): add sub-commands to launch
4413 the debug client (formerly in contrib/debugclient.py) and the
4414 Gtk status application (currently broken)
4415 * buildbot/clients/debug.py: move from contrib/debugclient.py
4416 * buildbot/clients/debug.glade: same
4418 * buildbot/test/test_trial.py: remove it. This requires some
4419 functionality out of Twisted that isn't there yet, and until then
4420 having it around just confuses things.
4422 * buildbot/test/test_slavecommand.py (Shell): test both with and
4423 without PTYs, and make sure that command output is properly
4424 interleaved in the with-PTY case. I think the without-PTY test
4425 should pass on windows, where we never use PTYs anyway.
4427 2005-04-20 Brian Warner <warner@lothar.com>
4429 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4431 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4433 * NEWS: start creating entries for the next release
4435 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4437 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4438 (WebTest.test_webPathname): same
4439 (WebTest.test_webPathname_port): same
4440 (WebTest.test_waterfall): use the default favicon rather than
4441 rooting around the filesystem for it. Open the expected-icon file
4442 in binary mode, to make win32 tests happier (thanks to Nick Trout
4444 * buildbot/status/html.py (buildbot_icon): win32 portability
4446 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4447 win32-compatibility fixes from Nick Trout, the "file not found" message
4448 is different under windows
4449 (FakeSlaveBuilder.__init__): clean up setup a bit
4450 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4452 2005-04-19 Brian Warner <warner@lothar.com>
4454 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4455 skip-if-repositories-are-unavailable test to not kill the trial
4456 that comes with Twisted-1.3.0
4458 * setup.py: install buildbot.png icon file when installing code
4460 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4461 environment used by the command, at least on the child side.
4463 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4464 this method needs to be added and implemented because it gets
4465 called under heavy load. I don't quite understand the
4466 producer/consumer API enough to write it.
4467 (StatusResource.getChild): add a resource for /favicon.ico
4468 (Waterfall.__init__): add favicon= argument
4469 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4470 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4471 (WebTest.test_webPathname): same
4472 (WebTest.test_webPathname_port): same
4473 * docs/config.xhtml: mention favicon=
4474 * buildbot/buildbot.png: add a default icon, dorky as it is
4476 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4478 * buildbot/master.py:
4479 * buildbot/process/base.py:
4480 * buildbot/process/builder.py:
4481 * buildbot/process/interlock.py:
4482 * buildbot/status/builder.py:
4483 * buildbot/status/html.py:
4484 * buildbot/status/mail.py:
4485 * buildbot/status/words.py:
4486 new documentation while digging through the code
4488 2005-04-17 Brian Warner <warner@lothar.com>
4490 * general: try to fix file modes on all .py files: a+r, a-x,
4491 but let buildbot/clients/*.py be +x since they're tools
4493 * docs/epyrun (addMod): when an import fails, say why
4495 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4497 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4499 * buildbot/process/base.py:
4500 * buildbot/process/builder.py:
4501 * buildbot/status/builder.py:
4502 new documentation while digging through the code
4504 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4506 * buildbot/changes/changes.py:
4507 * buildbot/changes/p4poller.py:
4508 * buildbot/interfaces.py:
4509 * buildbot/process/base.py:
4510 * buildbot/process/builder.py:
4511 * buildbot/process/step.py:
4512 * buildbot/process/step_twisted.py:
4513 * buildbot/slave/bot.py:
4514 * buildbot/slave/commands.py:
4515 * buildbot/status/builder.py:
4516 fix all docstrings to make epydoc happy. In the process of fixing
4517 some, I also moved pieces of docs, and removed some deprecated
4520 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4522 * buildbot/process/builder.py:
4523 * buildbot/process/interlock.py:
4524 * buildbot/process/process_twisted.py:
4525 * buildbot/process/step.py:
4526 BuildProcess -> Build, as it looks like that's what happened
4527 * buildbot/process/base.py:
4528 * buildbot/process/factory.py:
4531 2005-04-17 Brian Warner <warner@lothar.com>
4533 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4534 update compile command to accomodate the Twisted split.. now
4535 instead of './setup.py build_ext -i', you do './setup.py all
4536 build_ext -i', to run build_ext over all sub-projects.
4537 (FullTwistedBuildFactory): same
4538 (TwistedReactorsBuildFactory): same
4540 * buildbot/status/html.py (TextLog.finished): null out self.req
4541 when we're done, otherwise the reference cycle of TextLog to .req
4542 to .notifications to a Deferred to TextLog.stop keeps them from
4543 being collected, and consumes a huge (610MB on pyramid at last
4544 check) amount of memory.
4546 2005-04-11 Brian Warner <warner@lothar.com>
4548 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4549 normalize the VC-repository location.. makes SVN happier with
4550 certain test environments.
4552 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4553 RemoteShellCommand gets its own .env dictionary, so that code in
4554 start() doesn't mutate the original. I think this should fix the
4555 step_twisted.Trial problem where multiple identical components
4556 kept getting added to PYTHONPATH= over and over again.
4558 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4559 adding epydoc-format docstrings to many classes. Thanks to Thomas
4560 Vander Stichele for the patches.
4561 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4562 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4563 * buildbot/slave/bot.py, commands.py, registry.py: same
4565 2005-04-05 Brian Warner <warner@lothar.com>
4567 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4568 preserve timestamps, helps incremental builds of large trees.
4569 Patch from Rene Rivera.
4571 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4572 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4575 2005-04-03 Brian Warner <warner@lothar.com>
4577 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4578 with one dict, apparently exec has some scoping bugs when used
4579 with both global/local dicts. Thanks to Nathaniel Smith for the
4582 2005-04-02 Brian Warner <warner@lothar.com>
4584 * buildbot/process/step_twisted.py (countFailedTests): the new
4585 trial in Twisted-2.0 emits a slightly different status line than
4586 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4587 mistakenly think the test count is unparseable.
4588 (Trial.start): note that for some reason each build causes another
4589 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4590 be fixed but I'm not sure quite where the problem is.
4592 2005-04-01 Brian Warner <warner@lothar.com>
4594 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4595 deferredResult to avoid hangs/warnings under twisted-2.0
4596 (RunMixin.tearDown): same
4597 (RunMixin.shutdownSlave): same
4598 (Disconnect.testIdle1): same
4599 (Disconnect.testBuild2): same: wait one second after the build
4600 finishes for test to really be done.. this should be cleaned up to
4601 avoid wasting that second. Builder.detach uses a callLater(0),
4602 either that should be done in-line (something else needed that
4603 behavior), or it should return a Deferred that fires when the
4604 builder is really offline.
4605 (Disconnect.testBuild3): same
4606 (Disconnect.testDisappear): same
4608 * buildbot/test/test_web.py: rearrange server-setup and teardown
4609 code to remove unclean-reactor warnings from twisted-2.0
4611 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4612 so the tests don't hang under twisted-2.0
4614 2005-03-31 Brian Warner <warner@lothar.com>
4616 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4617 caused a warning each time the master changed our set of builders
4619 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4620 w32, don't unlink the file unless it already exists. Thanks to
4621 Baptiste Lepilleur for the catch.
4622 (BuilderStatus.saveYourself): same
4624 2005-02-01 Brian Warner <warner@lothar.com>
4626 * buildbot/status/html.py (TextLog.getChild): use a /text child
4627 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4628 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4629 logfile as text/plain (no markup, no headers). This replaces the
4630 previous scheme (which used an ?text=1 argument), and gets us back
4631 to a relative link (which works better when the buildbot lives
4632 behind another web server, such as Apache configured as a reverse
4633 proxy). Thanks to Gerald Combs for spotting the problem.
4635 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4638 2004-12-13 Brian Warner <warner@lothar.com>
4640 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4642 * debian/changelog: update for 0.6.2
4643 * NEWS: finalize for 0.6.2
4645 2004-12-11 Brian Warner <warner@lothar.com>
4647 * NEWS: bring it up to date
4649 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4650 detection code. Require some sign of life from the buildmaster
4651 every BotFactory.keepaliveInterval seconds. Provoke this
4652 indication at BotFactory.keepaliveTimeout seconds before the
4653 deadline by sending a keepalive request. We don't actually care if
4654 that request is answered in a timely fashion, what we care about
4655 is that .activity() is called before the deadline. .activity() is
4656 triggered by any PB message from the master (including an ack to
4657 one of the slave's status-update messages). With this new scheme,
4658 large status messages over slow pipes are OK, as long as any given
4659 message can be sent (and thus acked) within .keepaliveTimeout
4660 seconds (which defaults to 30).
4661 (SlaveBuilder.remote_startCommand): record activity
4662 (SlaveBuilder.ackUpdate): same
4663 (SlaveBuilder.ackComplete): same
4664 (BotFactory.gotPerspective): same
4665 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4667 2004-12-09 Brian Warner <warner@lothar.com>
4669 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4672 * buildbot/process/step_twisted.py (Trial._commandComplete):
4673 update self.cmd when we start the 'cat test.log' transfer. Without
4674 this, we cannot interrupt the correct RemoteCommand when we lose
4677 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4678 trying to tell the slave to stop the command if we're already
4679 inactive, or if we no longer have a .remote
4681 * buildbot/process/builder.py (Builder._detached): don't let an
4682 exception in currentBuild.stopBuild() prevent the builder from
4683 being marked offline
4685 2004-12-07 Brian Warner <warner@lothar.com>
4687 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4688 KeyError that happens when you ask for a non-existent Builder, and
4689 translate it into a UsageError.
4691 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4692 losing the slave in the middle of a remote step is handled too
4694 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4695 be a Failure, so be sure to stringify it before using it as the
4696 contents of the 'interrupt' logfile
4697 (RemoteCommand.interrupt): use stringified 'why' in
4698 remote_interruptCommand too, just in case
4700 2004-12-06 Brian Warner <warner@lothar.com>
4702 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4703 instead of 'tla update', which is more efficient in case we've
4704 missed a couple of patches since the last update.
4706 * debian/changelog: update for previous (0.6.1) release. Obviously
4707 this needs to be handled better.
4709 2004-12-05 Brian Warner <warner@lothar.com>
4711 * NEWS: update for stuff since last release
4713 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4714 match the maybeDeferred change in Dispatcher.requestAvatar
4715 * buildbot/changes/pb.py (ChangePerspective.attached): same
4716 * buildbot/status/client.py (StatusClientPerspective.attached): same
4717 * buildbot/process/builder.py (Builder._attached3): same
4718 * buildbot/pbutil.py (NewCredPerspective.attached): same
4720 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4721 the date to the top-most box, if it is not the same as today's
4724 * docs/slave.xhtml: provide a buildslave setup checklist
4726 * docs/source.xhtml (Arch): correct terminology
4728 2004-12-04 Brian Warner <warner@lothar.com>
4730 * buildbot/test/test_slavecommand.py: use sys.executable instead
4731 of hard-coding 'python' for child commands, might help portability
4733 * docs/examples/twisted_master.cfg: update to current usage
4735 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4736 'stop build' command to the IRC bot
4738 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4739 message that broke PBChangeSource
4741 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4742 (SlaveBuilder): make some attributes class-level, remove the old
4743 "update queue" which existed to support resuming a build after the
4744 master connection was lost. Try to reimplement that feature later.
4745 (SlaveBuilder.stopCommand): clear self.command when the
4746 SlaveCommand finishes, so that we don't try to kill a leftover one
4748 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4751 * buildbot/slave/commands.py (SourceBase): set self.command for
4752 all VC commands, so they can be interrupted.
4754 2004-12-03 Brian Warner <warner@lothar.com>
4756 * buildbot/master.py: clean up slave-handling code, to handle
4757 slave-disconnect and multiple-connect better
4758 (BotPerspective): make these long-lasting, exactly one per bot
4759 listed in the config file.
4760 (BotPerspective.attached): if a slave connects while an existing
4761 one appears to still be connected, disconnect the old one first.
4762 (BotPerspective.disconnect): new method to forcibly disconnect a
4763 buildslave. Use some hacks to empty the transmit buffer quickly to
4764 avoid the long (20-min?) TCP timeout that could occur if the old
4765 slave has dropped off the net.
4766 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4767 own their own SlaveStatus objects. Remove .attached/.detached, add
4768 .addSlave/.removeSlave, treat slaves like Builders (config file
4769 parsing sends deltas to the BotMaster). Inform the slave
4770 instances, i.e. the BotPerspective, about addBuilder and
4772 (BotMaster.getPerspective): turns into a single dict lookup
4773 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4774 which gives BotPerspective.attached a chance to disconnect the old
4776 (BuildMaster.loadConfig): add code (disabled) to validate that all
4777 builders use known slaves (listed in c['bots']). The check won't
4778 work with tuple-specified builders, which are deprecated but not
4779 yet invalid, so the check is disabled for now.
4780 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4781 routine, do the add/changed/removed dance with them like we do
4783 (BuildMaster.loadConfig_Sources): move source-config into a
4784 separate routine too
4786 * buildbot/status/builder.py (Status.getSlave): get the
4787 SlaveStatus object from the BotPerspective, not the BotMaster.
4789 * buildbot/test/test_run.py: bunch of new tests for losing the
4790 buildslave at various points in the build, handling a slave that
4791 connects multiple times, and making sure we can interrupt a
4794 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4795 something other than 'Bot' for the Bot object, to make certain
4796 test cases easier to write.
4797 (BuildSlave.waitUntilDisconnected): utility method for testing
4799 2004-11-30 Brian Warner <warner@lothar.com>
4801 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4803 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4804 argument, return a Deferred that always fires with True or False.
4805 I don't use an errback to indicate 'ping failed' so that callers
4806 are free to ignore the deferred without causing spurious errors in
4808 * buildbot/process/builder.py (BuilderControl.ping): implement it
4810 * buildbot/test/test_run.py (Status.testDisappear): test ping
4811 (Status.disappearSlave): fix it
4813 2004-11-30 Brian Warner <warner@lothar.com>
4815 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4816 (IBuilderControl): add .getBuild(num), only works for the current
4817 build, of course, although it might be interesting to offer
4818 something for builds in the .waiting or .interlocked state.
4820 * buildbot/process/base.py (Build): have .stopBuild just do the
4821 interrupt, then let the build die by itself.
4822 (BuildControl): add .stopBuild, and add a point-event named
4823 'interrupt' just after the build so status viewers can tell that
4825 (BuilderControl): add .getBuild
4827 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4828 stops when you kill it, good for testing
4829 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4830 contains the 'reason' text.
4832 * buildbot/status/html.py: Add Stop Build button, if the build can
4833 still be stopped. Send a Redirect (to the top page) one second
4834 later, hopefully long enough for the interrupt to have an effect.
4835 Move make_row() up to top-level to share it between Stop Build and
4838 * buildbot/slave/commands.py: only kill the child process once
4840 * buildbot/test/test_run.py: add testInterrupt
4842 2004-11-29 Brian Warner <warner@lothar.com>
4844 * buildbot/process/base.py: Refactor command interruption. The
4845 Build is now responsible for noticing that the slave has gone
4846 away: Build.lostRemote() interrupts the current step and makes
4847 sure that no further ones will be started.
4849 * buildbot/process/builder.py: When the initial remote_startBuild
4850 message fails, log it: this usually indicates that the slave has
4851 gone away, but we don't really start paying attention until they
4852 fail to respond to the first step's command.
4854 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4855 slave disconnect. Now sports a new interrupt() method. Error
4856 handling was simplified a lot by chaining deferreds, so
4857 remoteFailed/remoteComplete were merged into a single
4858 remoteComplete method (which can now get a Failure object).
4859 Likewise failed/finished were merged into just _finished.
4860 (BuildStep): Add interrupt(why) method, and if why is a
4861 ConnectionLost Failure then the step is failed with some useful
4864 * buildbot/slave/bot.py: stop the current command when the remote
4865 Step reference is lost, and when the slave is shut down.
4866 (Bot): make it a MultiService, so it can have children. Use
4867 stopService to tell when the slave is shutting down.
4868 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4869 remote_interruptCommand (which asks the current SlaveCommand to
4870 stop but allows it to keep emitting status messages), and
4871 stopCommand (which tells it to shut up and die).
4873 * buildbot/slave/commands.py: make commands interruptible
4874 (ShellCommand.kill): factor out os.kill logic
4875 (Command): factor out setup()
4876 (Command.sendStatus): don't send status if .running is false, this
4877 happens when the command has been halted.
4878 (Command.interrupt): new method, used to tell the command to die
4879 (SlaveShellCommand): implement .interrupt
4880 (DummyCommand): implement .interrupt
4881 (SourceBase, etc): factor out setup(), don't continue substeps if
4884 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4885 so they can be called after finishing
4887 * buildbot/test/test_run.py: new tests for disconnect behavior,
4888 refactor slave-shutdown routines, add different kinds of
4891 2004-11-27 Brian Warner <warner@lothar.com>
4893 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4894 method to express ETA time like "2m45s" instead of "165 seconds"
4896 2004-11-24 Brian Warner <warner@lothar.com>
4898 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4899 archive after the test completes, to avoid cluttering the user's
4900 'tla archives' listing with a bogus entry. Arch doesn't happen to
4901 provide any way to override the use of ~/.arch-params/, so there
4902 isn't a convenient way to avoid touching the setup of the user who
4904 (VC_HTTP.testArchHTTP): same
4906 2004-11-23 Brian Warner <warner@lothar.com>
4908 * buildbot/status/html.py (TextLog): split render() up into
4909 render_HEAD and render_GET. Use a Producer when sending log
4910 chunks, to reduce memory requirements and avoid sending huge
4911 non-Banana-able strings over web.distrib connections. Requires
4912 peeking under the covers of IStatusLog.
4913 (TextLog.resumeProducing): fix the "as text" link, handle client
4914 disconnects that occur while we're still sending old chunks.
4916 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4917 use defer.succeed, not the non-existent defer.success
4918 (LogFile.waitUntilFinished): same
4919 (LogFile.subscribe): don't add watchers to a finished logfile
4921 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4924 2004-11-23 Brian Warner <warner@lothar.com>
4926 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4928 2004-11-23 Brian Warner <warner@lothar.com>
4930 * NEWS: update for the 0.6.1 release
4931 * MANIFEST.in: add new files
4933 * README (INSTALLATION): explain how to enable the extra VC tests
4935 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4936 level to, so old pickled builds can be displayed ok
4938 2004-11-22 Brian Warner <warner@lothar.com>
4940 * NEWS: summarize updates since last release
4942 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4943 Yoz Grahame. Closes SF#1050138.
4945 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4948 * buildbot/process/step_twisted.py (Trial): update docs a bit
4950 * docs/factories.xhtml: fix Trial factory docs to match reality.
4953 * buildbot/process/factory.py (Trial.__init__): add args for
4954 randomly= and recurse=, making them available to instantiators
4955 instead of only to subclassers. Closes: SF#1049759.
4957 2004-11-15 Brian Warner <warner@lothar.com>
4959 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4960 try to teach the Quick factory to use multiple versions of python
4962 2004-11-12 Brian Warner <warner@lothar.com>
4964 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4965 safer w32-compatible approach, and only use it on windows
4966 (BuildStatus.saveYourself): same
4968 2004-11-11 Brian Warner <warner@lothar.com>
4970 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4971 it: one string merge per chunk. There are now separate .entries
4972 and .runEntries lists: when enumerating over all chunks, make sure
4974 * buildbot/test/test_status.py (Log): more tests
4976 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4977 chunks together, up to 10kb per chunk. This ought to cut down on
4978 the CPU-burning overhead of large log files. Thanks to Alexander
4979 Staubo for spotting the problem.
4980 * buildbot/test/test_status.py (Log): tests for same
4982 2004-11-10 Brian Warner <warner@lothar.com>
4984 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4985 header to outbound mail
4986 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4988 2004-11-08 Brian Warner <warner@lothar.com>
4990 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4991 can't do os.rename() onto an existing file, so catch the exception
4992 and unlink the target file first. This introduces a slight window
4993 where the existing file could be lost, but the main failure case
4994 (disk full) should still be handled safely.
4995 (BuildStatus.saveYourself): same
4997 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4998 separator character instead of os.sep, because the filenames being
4999 split here are coming from the VC system, which can have a
5000 different pathname convention than the local host. This should
5001 help a buildmaster running on windows that uses a CVS repository
5002 which runs under unix.
5003 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5005 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5006 when there are no test failures to be parsed
5008 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5009 instead of the unix-specific os.system("cp"), thanks to Elliot
5010 Murphy for this and the other buildbot-vs-windows catches.
5011 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5013 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5014 echo the command as it is run
5016 * setup.py: install sample.mk too, not just sample.cfg
5017 (scripts): install contrib/windows/buildbot.bat on windows
5019 2004-11-07 Brian Warner <warner@lothar.com>
5021 * buildbot/process/builder.py (Builder._detached): clear the
5022 self.currentBuild reference, otherwise the next build will be
5023 skipped because we think the Builder is already in use.
5025 * docs/examples/twisted_master.cfg: update to match current usage
5026 on the Twisted buildbot
5028 2004-10-29 Brian Warner <warner@lothar.com>
5030 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5032 2004-10-28 Brian Warner <warner@lothar.com>
5034 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5035 have separate doVCUpdate/doVCFull methods. Catch an update failure
5036 and respond by clobbering the source directory and re-trying. This
5037 will handle local changes (like replacing a file with a directory)
5038 that will cause CVS and SVN updates to fail.
5039 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5041 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5044 2004-10-19 Brian Warner <warner@lothar.com>
5046 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5048 * buildbot/status/html.py (StatusResourceTestResults): display any
5049 TestResults that the Build might have
5050 (StatusResourceTestResult): and the logs for each TestResult
5051 (StatusResourceBuild): add link from the per-build page
5053 2004-10-15 Brian Warner <warner@lothar.com>
5055 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5056 the 'problems' portion of stdout, add TestResults to our build
5057 * buildbot/test/test_twisted.py (Parse.testParse): test it
5059 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5060 to retrieve a dict of accumulated test results
5061 (ITestResult): define what a single test result can do
5062 * buildbot/status/builder.py (TestResult): implement ITestResult
5063 (BuildStatus.getTestResults): retrieve dict of TestResults
5064 (BuildStatus.addTestResult): add TestResults
5065 * buildbot/test/test_status.py (Results.testAddResults): test it
5067 2004-10-14 Brian Warner <warner@lothar.com>
5069 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5070 instead of os.system("rm -rf") for win32 portability
5072 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5073 SignalMixin instead of starting/stopping the reactor, which is
5074 likely to cause problems with other tests
5076 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5077 self.copyComplete() call. Yoz Grahame makes the catch.
5079 * contrib/windows/buildbot.bat: helper script to deal with path
5080 issues. Thanks to Yoz Grahame.
5082 * buildbot/master.py (BuildMaster.startService): don't register a
5083 SIGHUP handler if the signal module has no SIGHUP attribute.
5084 Apparently win32 does this.
5086 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5088 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5089 test if the reactor can't offer UNIX sockets
5091 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5092 error introduced in the last commit. We really need that
5095 2004-10-12 Brian Warner <warner@lothar.com>
5097 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5098 when describing a maildir source. Thanks to Stephen Davis.
5100 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5103 * buildbot/scripts/runner.py (createMaster): install Makefile too
5104 (start): add --no_save to 'start' command
5105 * buildbot/scripts/sample.mk: simple convenience Makefile with
5106 start/stop/reload targets
5108 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5111 2004-09-30 Brian Warner <warner@lothar.com>
5113 * setup.py: Releasing buildbot-0.6.0
5115 2004-09-30 Brian Warner <warner@lothar.com>
5117 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5118 test_trial.py from the source tarball until support is complete.
5120 * NEWS: update for 0.6.0 release
5121 * buildbot/__init__.py (version): same
5124 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5125 'source' command to tell users where to get the Buildbot source
5127 * docs/examples/*.cfg: update to modern standards
5129 * NEWS: update for release
5131 * buildbot/scripts/runner.py (createMaster): remove the
5132 -shutdown.tap stuff now that it isn't necessary
5134 (start): launch buildbot.tap, not buildbot-shutdown.tap
5137 * buildbot/status/mail.py (Domain): shorten class name
5138 (MailNotifier): if lookup= is a string, pass it to Domain()
5139 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5140 (Mail.testBuild2): test the string-to-Domain shortcut
5141 (Mail.testMail): fix test
5144 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5147 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5148 more attributes on load
5149 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5150 to accomodate the whole waterfall page at once, and the thrashing
5151 results in a lot of unnecessary loads
5152 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5153 (BuilderStatus.saveYourself): same
5154 (BuilderStatus.eventGenerator): stop generating on the first missing
5155 build. We assume that saved builds are deleted oldest-first.
5156 (BuildStepStatus.__getstate__): .progress might not exist
5158 * buildbot/changes/changes.py (ChangeMaster): make it
5159 serializable, in $masterdir/changes.pck
5160 (ChangeMaster.stopService): save on shutdown
5161 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5162 * buildbot/test/test_config.py: load Changes before config file
5165 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5166 "Oh my god, you killed the command" header on a separate line
5168 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5169 skip over corrupted build pickles
5170 (BuilderStatus.getFullBuildByNumber): same
5171 (BuilderStatus.eventGenerator): skip over unavailable builds
5172 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5173 do an atomic rename. This prevents a corrupted pickle when some
5174 internal serialization error occurs.
5175 (BuilderStatus.saveYourself): same
5177 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5178 the timeout for shell commands, it got lost somehow
5180 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5181 run out of build steps, return the rest of the builder events
5183 * buildbot/interfaces.py (IBuilderControl.ping): add method
5185 * buildbot/process/builder.py (BuilderControl.ping): move
5186 slave-ping to BuilderControl, and fix the failure case in the
5187 process (Event.finish() is the verb, Event.finished is the noun).
5189 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5190 through the BuilderControl instead of the BuilderStatus
5191 (EventBox): add adapter for builder.Event, allowing builder events to
5192 be displayed in the waterfall display
5194 * buildbot/master.py (BotMaster.stopService): add a 'master
5195 shutdown' event to the builder's log
5196 (BuildMaster.startService): and a 'master started' on startup
5198 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5199 builder events into the BuildStep event stream
5200 (Status.builderAdded): add a 'builder created' event
5203 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5204 command to announce the completion of a running build
5205 (IrcStatusBot.command_FORCE): announce when the build finishes
5207 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5208 don't evict unfinished builds from the cache: they must stay in
5209 the full-cache until their logfiles have stopped changing. Make
5210 sure the eviction loop terminates if an unfinished build was hit.
5211 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5212 This lets exceptions be dumped in an email status message. Really
5213 we need LogFiles which contain both text and HTML, instead of two
5215 (BuildStatus.__getstate__): handle self.finished=False
5216 (Status.builderAdded): if the pickle is corrupted, abandon the
5217 history and create a new BuilderStatus object.
5219 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5220 self.progress attribute, helped one test which doesn't fully set
5221 up the Build object.
5223 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5224 IStatusLog methods into an Interface that is implemented by "stub"
5225 logs, for which all the actual text chunks are on disk (in the
5226 pickled Build instance). To show the log contents, you must first
5227 adapt the stub log to a full IStatusLog object.
5229 * buildbot/status/builder.py (LogFileStub): create separate stub
5230 log objects, which can be upgraded to a real one if necessary.
5231 (LogFile): make them persistable, and let them stubify themselves
5233 (BuildStepStatus): same
5235 (BuildStatus.saveYourself): save the whole build out to disk
5236 (BuilderStatus): make it persistable
5237 (BuilderStatus.saveYourself): save the builder to disk
5238 (BuilderStatus.addFullBuildToCache): implement two caches which
5239 hold Build objects: a small one which holds full Builds, and a
5240 larger one which holds "stubbed" Builds (ones with their LogFiles
5241 turned into LogFileStubs). This reduces memory usage by the
5242 buildmaster by not keeping more than a few (default is 2) whole
5243 build logs in RAM all the time.
5244 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5246 (BuilderStatus.eventGenerator): rewrite since .builds went away
5247 (BuilderStatus.buildStarted): remove the .builds array. Add the
5248 build to the "full" cache when it starts.
5249 (BuilderStatus._buildFinished): save the build to disk when it
5251 (Status): give it a basedir (same as the BuildMaster's basedir)
5252 where the builder pickles can be saved
5253 (Status.builderAdded): create the BuilderStatus ourselves, by
5254 loading a pickle from disk (or creating a new instance if there
5255 was none on disk). Return the BuilderStatus so the master can glue
5256 it into the new Builder object.
5258 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5259 all BuilderStatuses to save themselves out to disk. This is in
5260 lieu of saving anything important in the main Application pickle
5261 (the -shutdown.tap file).
5262 (BuildMaster.__init__): give Status() a basedir for its files
5263 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5264 to get the BuilderStatus, then give it to the Builder (instead of
5265 doing it the other way around). It's ok if the status announces
5266 the new Builder before it's really ready, as the outside world can
5267 only see the BuilderStatus object anyway (and it is ready before
5268 builderAdded returns). Use the builder's "builddir" (which
5269 normally specifies where the slave will run the builder) as the
5270 master's basedir (for saving serialized builds).
5272 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5273 coerce the logfile to IStatusLog before trying to get the text
5274 chunks out of it. This will pull the full (non-stubified) Build in
5275 from disk if necessary.
5276 (TextLog): fix the adapter registration
5278 * buildbot/test/test_control.py (Force.setUp): create the basedir
5279 * buildbot/test/test_web.py: same
5280 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5281 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5282 * buildbot/test/test_run.py (Run.testMaster): same
5283 (Status.setUp): same
5285 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5287 * buildbot/status/html.py (Waterfall.__init__): store actual
5288 allowForce flag passed in rather than using True for everyone;
5289 make sure setting it to False doesn't cause a NameError
5291 (StatusResourceBuilder.__init__) add the builder name to the page
5293 (StatusResourceBuilder.body) move HTML generation for a name/value
5294 row into a helper method (StatusResourceBuilder.make_row); only
5295 generate the "Force Build" form if allowForce was True and the
5296 slave is connected. Use class attributes in the generated HTML to
5297 spread a little CSS-joy.
5299 2004-09-28 Brian Warner <warner@lothar.com>
5301 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5302 warning-scanner to not ignore things like
5303 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5305 * buildbot/status/html.py (StatusResource.control): add some
5306 class-level values for .control in an attempt to make upgrading
5309 * buildbot/util.py (ComparableMixin): survive missing attributes,
5310 such as when a class is modified and we're comparing old instances
5313 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5314 failure handling, remove a redundant try/except block. Don't
5315 return the full traceback to the IRC channel.
5316 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5317 error messages. Get ETA properly.
5319 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5320 the reason, since (at least) IRC message will have <> in them.
5321 (StatusResourceBuilder.__init__): take an IBuilderControl
5322 (StatusResourceBuilder.force): use the IBuilderControl we get in
5323 the constructor instead of trying to make our own. Catch the
5324 new exceptions and ignore them for now (until we make an
5325 intermediate web page where we could show the error message)
5326 (StatusResource): create with an IControl, use it to give an
5327 IBuilderControl to all children
5328 (Waterfall): take an allowForce= option, pass an IControl object
5329 to StatusResource if it is True
5331 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5333 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5334 catch new exceptions and return string forms
5336 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5337 * buildbot/process/builder.py (Builder.forceBuild): raise them
5338 * buildbot/test/test_control.py (Force.testNoSlave): new test
5339 (Force.testBuilderInUse): same
5342 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5344 * buildbot/test/test_run.py: use IControl
5345 * buildbot/test/test_vc.py: same
5347 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5348 to use IControl. Still offline.
5349 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5351 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5352 who=None so periodic builds don't send out status mail
5353 (Builder.forceBuild): include reason in the log message
5354 (BuilderControl.forceBuild): rename 'name' to 'who'
5356 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5357 'who' parameter, but make it None by default so builds forced by
5358 slave admins don't cause status mail to be sent to anybody
5359 (BotMaster.forceBuild): same. this method is deprecated.
5360 (DebugPerspective.perspective_forceBuild): same, use IControl.
5361 (DebugPerspective.perspective_fakeChange): use IControl..
5362 (Dispatcher.requestAvatar): .. so don't set .changemaster
5364 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5365 parameter to avoid confusion with the name of the builder
5368 * buildbot/status/mail.py: refine comment about needing 2.3
5370 * buildbot/status/html.py: move all imports to the top
5372 * buildbot/test/test_control.py: test new interfaces
5373 * buildbot/test/test_run.py (Status): handle new interfaces
5374 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5376 * buildbot/process/base.py (BuildControl): implement IBuildControl
5377 and its lonely getStatus() method
5379 * buildbot/process/builder.py (BuilderControl): implement
5380 IBuilderControl, obtained by adapting the Builder instance
5381 (Builder.startBuild): return a BuilderControl instead of a
5382 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5383 accomplish the same thing.
5385 * buildbot/master.py: move all import statements to the top
5386 (Control): implement IControl, obtained by adapting the
5387 BuildMaster instance.
5389 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5390 IBuildControl. These are used to force builds. Eventually they
5391 will provide ways to reconfigure the Builders, pause or abandon a
5392 Build, and perhaps control the BuildMaster itself.
5394 2004-09-26 Brian Warner <warner@lothar.com>
5396 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5397 ends up comparing us against something without a .__class__
5399 2004-09-24 Brian Warner <warner@lothar.com>
5401 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5404 * Makefile: add 'deb-snapshot' target, to create a timestamped
5407 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5409 2004-09-23 Brian Warner <warner@lothar.com>
5411 * buildbot/__init__.py (version): move version string here
5412 * setup.py: get version string from buildbot.version
5413 * buildbot/status/html.py (WaterfallStatusResource.body): add
5414 buildbot version to the page footer
5415 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5418 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5419 slaves, let the second know where the first one is coming from
5420 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5421 see our exceptions. It would be nice if there were a way to just
5422 send them the exception type and value, not the full traceback.
5425 * buildbot/status/mail.py (MailNotifier): add a new argument
5426 sendToInterestedUsers=, which can be set to False to disable the
5427 usual send-to-blamelist behavior.
5428 (top): handle python-2.2 which has no email.MIMEMultipart
5429 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5430 (MailNotifier.disownServiceParent): unsubscribe on removal
5432 * buildbot/test/test_status.py (Mail.testBuild2): test it
5435 * buildbot/status/progress.py (Expectations.wavg): tolerate
5436 current=None, which happens when steps start failing badly
5437 * buildbot/test/test_status.py (Progress.testWavg): test for it
5439 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5440 doesn't understand args['revision'], emit a warning instead of
5441 bailing completely. Updating to -rHEAD is probably close enough.
5443 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5445 * buildbot/test/test_status.py: at least import bb.status.client
5446 even if we don't have any test coverage for it yet
5448 * contrib/svn_buildbot.py: don't require python2.3
5449 (main): wait, do require it (for sets.py), but explain how to
5450 make it work under python2.2
5452 2004-09-23 Brian Warner <warner@lothar.com>
5454 * contrib/svn_buildbot.py: include the revision number in the Change
5456 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5457 using util.now() because FreshCVS is a realtime service
5459 * buildbot/status/event.py: delete dead code
5460 * buildbot/process/step.py: don't import dead Event class
5461 * buildbot/process/step_twisted.py: same
5462 * buildbot/status/builder.py: same
5463 * buildbot/status/client.py: same
5465 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5467 * buildbot/changes/changes.py (Change): set .when from an __init__
5468 argument (which defaults to now()), rather than having
5469 ChangeMaster.addChange set it later.
5470 (ChangeMaster.addChange): same
5472 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5473 (parseSyncmail): same. Just use util.now() for now.
5474 (parseBonsaiMail): parse the timestamp field for when=
5476 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5477 instead of setting .when after the fact
5481 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5482 results when the target project uses retrial. Still under
5484 * buildbot/test/test_trial.py: same
5486 2004-09-21 Brian Warner <warner@lothar.com>
5488 * buildbot/status/mail.py (MailNotifier.__init__): include
5489 success/warnings/failure in the Subject line
5490 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5491 use step.logname for the addLogs=True attachment filenames
5492 * buildbot/test/test_status.py (Mail): test Subject lines
5493 (Mail.testLogs): test attachment filenames
5495 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5496 accept a 'who' argument from the debug tool
5497 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5498 * contrib/debug.glade: add text box to set 'who'
5500 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5501 .getBuilderName with .getBuilder().getName(), more flexible
5502 (IStatusLog.getName): logs have short names, but you can prefix
5503 them with log.getStep().getName() to make them more useful
5504 * buildbot/status/builder.py: same
5505 * buildbot/status/client.py: same
5506 * buildbot/status/html.py: same
5507 * buildbot/test/test_run.py (Status.testSlave): same
5508 * buildbot/process/step.py: tweak logfile names
5510 * buildbot/status/mail.py (MailNotifier): add lookup, change
5511 argument to extraRecipients. The notifier is now aimed at sending
5512 mail to the people involved in a particular build, with additional
5513 constant recipients as a secondary function.
5515 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5516 including slow-lookup and failing-lookup. Make sure the blamelist
5517 members are included.
5519 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5520 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5521 (IBuildStatus.getInterestedUsers): new method
5522 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5523 * buildbot/status/client.py (remote_getResponsibleUsers): same
5524 * buildbot/status/html.py (StatusResourceBuild.body): same
5525 * buildbot/test/test_run.py (Status.testSlave): same
5527 2004-09-20 Brian Warner <warner@lothar.com>
5529 * docs/users.xhtml: update concepts
5531 * Makefile: add a convenience makefile, for things like 'make
5532 test'. It is not included in the source tarball.
5534 2004-09-16 Brian Warner <warner@lothar.com>
5536 * NEWS: mention /usr/bin/buildbot, debian/*
5538 * debian/*: add preliminary debian packaging. Many thanks to
5539 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5540 it considerably since it left their hands, I am responsible for
5541 all breakage that's resulted.
5543 * bin/buildbot: create a top-level 'buildbot' command, to be
5544 installed in /usr/bin/buildbot . For now it's just a simple
5545 frontend to mktap/twistd/kill, but eventually it will be the entry
5546 point to the 'try' command and also a status client. It is also
5547 intended to support the upcoming debian-packaging init.d scripts.
5548 * buildbot/scripts/runner.py: the real work is done here
5549 * buildbot/scripts/__init__.py: need this too
5550 * buildbot/scripts/sample.cfg: this is installed in new
5551 buildmaster directories
5552 * setup.py: install new stuff
5554 2004-09-15 Brian Warner <warner@lothar.com>
5556 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5557 'file:' schema (the version shipped with OS-X was built without the
5559 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5560 updates the log-timestamp, to make sure it isn't still running after
5563 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5564 values to the config file.
5565 * docs/examples/hello.cfg: add examples
5566 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5567 * buildbot/status/builder.py (Status.getProjectURL): implement them
5568 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5569 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5570 * buildbot/status/html.py (WaterfallStatusResource): display them
5573 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5574 certain error cases don't suffer a secondary exception.
5575 (top): Skip tests if the corresponding VC tool is not installed.
5577 * buildbot/process/factory.py (Trial): introduce separate
5578 'buildpython' and 'trialpython' lists, since trialpython=[] is
5579 what you want to invoke /usr/bin/python, whereas ./setup.py is
5580 less likely to be executable. Add env= parameter to pass options
5581 to test cases (which is how I usually write tests, I don't know if
5582 anyone else does it this way).
5584 * buildbot/process/step_twisted.py (Trial): handle python=None.
5585 Require 'testpath' be a string, not a list. Fix tests= typo.
5586 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5588 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5589 way to deal with the possibility of removing the disconnect notify
5591 (CVS): add a 'login' parameter to give a password to 'cvs login',
5592 commonly used with pserver methods (where pw="" or pw="guest")
5594 * buildbot/slave/commands.py (SourceBase): move common args
5595 extraction and setup() to __init__, so everything is ready by the
5596 time setup() is called
5597 (CVS.start): call 'cvs login' if a password was supplied
5598 (ShellCommand): special-case PYTHONPATH: prepend the master's
5599 value to any existing slave-local value.
5601 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5602 don't have a remote, mark the builder as Offline. This whole
5603 function should probably go away and be replaced by individual
5605 (Builder.buildFinished): return the results to the build-finished
5606 deferred callback, helps with testing
5608 2004-09-14 Brian Warner <warner@lothar.com>
5610 * buildbot/test/test_vc.py: put all the repositories needed to run
5611 the complete tests into a single small (1.3MB) tarball, so I can
5612 make that tarball available on the buildbot web site. Test HTTP
5613 access (for Arch and Darcs) by spawning a temporary web server
5614 while the test runs.
5616 * docs/users.xhtml: new document, describe Buildbot's limited
5617 understanding of different human users
5619 * buildbot/test/test_vc.py: rearrange test cases a bit
5621 * buildbot/process/step_twisted.py (Trial): handle testpath=
5622 * buildbot/process/factory.py (Trial): update to use step.Trial
5624 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5626 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5627 the overall build text (which gives you 'failed 2 tests' rather
5629 (BuildStepStatus.text2): default to [], not None
5631 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5634 2004-09-12 Brian Warner <warner@lothar.com>
5636 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5637 log the whole exception if it's just an AttributeError (old slave)
5639 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5640 so (e.g.) sub-commands can be run in the right directory.
5641 (ShellCommand.start): accept an optional errorMessage= argument
5642 to make life easier for SVN.start
5643 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5645 (ShellCommand.start): move ['dir'] compatibility hack..
5646 (RemoteShellCommand.start): .. to here so everyone can use it
5648 * buildbot/process/step_twisted.py (Trial): use .workdir
5650 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5651 text displayed when debuild fails completely
5652 (Trial): snarf _trial_temp/test.log from the slave and display it
5654 2004-09-11 Brian Warner <warner@lothar.com>
5656 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5658 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5659 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5661 * buildbot/process/step.py (ShellCommand): call .createSummary
5662 before .evaluateCommand instead of the other way around. This
5663 makes it slightly easier to count warnings and then use that to
5664 set results=WARNINGS
5665 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5667 * buildbot/process/base.py (Build.buildFinished): update status
5668 before doing progress. It's embarrassing for the build to be stuck
5669 in the "building" state when an exceptions occurs elsewhere..
5671 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5672 python2.2 doesn't have 'sum'
5674 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5675 to prevent clients from accidentally sorting it
5677 * buildbot/master.py (Manhole): add username/password
5678 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5679 c['manholePort'], deprecate old usage
5680 * docs/config.xhtml: document c['manhole']
5681 * docs/examples/hello.cfg: show example of using a Manhole
5684 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5685 pretend the slave is up to date
5687 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5688 the module, overlaps with 'log', the local variable
5690 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5692 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5693 new method to let Steps find out the version of their
5694 corresponding SlaveCommand.
5695 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5696 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5697 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5699 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5700 (Arch.startVC): same
5701 (P4Sync.startVC): same
5703 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5704 Deferred so we can catch errors in remote_startCommand
5705 (RemoteShellCommand.start): same
5707 * docs/examples/twisted_master.cfg: update sample config file
5709 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5710 after connectionMade() is called, not before. Close stdin at that
5713 * buildbot/process/process_twisted.py: update to use Trial, clean
5714 up argument passing (move to argv arrays instead of string
5717 * buildbot/process/step_twisted.py (Trial): new step to replace
5718 RunUnitTests, usable by any trial-using project (not just
5719 Twisted). Arguments have changed, see the docstring for details.
5721 * buildbot/process/base.py (Build.startBuild): this now returns a
5722 Deferred. Exceptions that occur during setupBuild are now
5723 caught better and lead to fewer build_status weirdnesses, like
5724 finishing a build that was never started.
5725 (Build.buildFinished): fire the Deferred instead of calling
5726 builder.buildFinished directly. The callback argument is this
5727 Build, everything else can be extracted from it, including the
5728 new build.results attribute.
5729 * buildbot/process/builder.py (Builder.startBuild): same
5730 (Builder.buildFinished): same, extract results from build
5732 * buildbot/process/step.py (ShellCommands): remove dead code
5734 2004-09-08 Brian Warner <warner@lothar.com>
5736 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5737 doesn't try to use the leftover patched workdir
5738 (SourceStamp): test source-stamp computation for CVS and SVN
5740 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5741 patched workdir ('touch .buildbot-patched') so we don't try to
5743 (SourceBase.start): add ['revision'] for all Source steps
5744 (CVS): change args: use ['branch'] for -r, remove ['files']
5745 (CVS.buildVC): fix revision/branch stuff
5746 (SVN): add revision stuff
5748 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5749 kwargs (except 'workdir') to avoid silent spelling errors
5750 (ShellCommand.__init__): same
5751 (Source): new base class for CVS/SVN/etc. Factor out everything
5752 common, add revision computation (perform the checkout with a -D
5753 DATE or -r REVISION that gets exactly the sources described by the
5754 last Change), overridable with step.alwaysUseLatest. Add patch
5755 handling (build.getSourceStamp can trigger the use of a base
5756 revision and a patch).
5757 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5758 * docs/steps.xhtml: update docs
5759 * docs/source.xhtml: mention .checkoutDelay
5760 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5762 * buildbot/process/base.py (Build.setSourceStamp): add a
5763 .sourceStamp attribute to each Build. If set, this indicates that
5764 the build should be done with something other than the most
5765 recent source tree. This will be used to implement "try" builds.
5766 (Build.allChanges): new support method
5767 (Build.lastChangeTime): remove, functionality moved to Source steps
5768 (Build.setupBuild): copy the Step args before adding ['workdir'],
5769 to avoid modifying the BuildFactory (and thus triggering spurious
5773 * buildbot/status/html.py: rename s/commits/changes/
5774 (StatusResourceChanges): same
5775 (CommitBox.getBox): same, update URL
5776 (WaterfallStatusResource): same
5777 (StatusResource.getChild): same
5779 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5780 * contrib/debug.glade: add optional 'revision' to the fakeChange
5782 * buildbot/changes/changes.py (html_tmpl): display .revision
5783 (ChangeMaster.addChange): note .revision in log
5784 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5785 accept a ['revision'] attribute
5787 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5789 * buildbot/master.py (BotMaster.getPerspective): update the
5790 .connected flag in SlaveStatus when it connects
5791 (BotMaster.detach): and when it disconnects
5792 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5793 (BuildMaster.loadConfig_Builders): walk old list correctly
5795 * buildbot/test/test_config.py: fix prefix= usage
5797 2004-09-06 Brian Warner <warner@lothar.com>
5801 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5802 poll a P4 depot looking for recent changes. Thanks to Dave
5803 Peticolas for the contribution. Probably needs some testing after
5806 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5807 requires manual client setup for each buildslave. Rather
5808 experimental. Thanks again to Dave Peticolas.
5809 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5811 * buildbot/changes/changes.py (Change): add a .revision attribute,
5812 which will eventually be used to generate source-stamp values.
5814 * buildbot/process/step.py (RemoteCommand.start): use
5815 notifyOnDisconnect to notice when we lose the slave, then treat it
5816 like an exception. This allows LogFiles to be closed and the build
5817 to be wrapped up normally. Be sure to remove the disconnect
5818 notification when the step completes so we don't accumulate a
5819 bazillion such notifications which will fire weeks later (when the
5820 slave finally disconnects normally). Fixes SF#915807, thanks to
5821 spiv (Andrew Bennetts) for the report.
5822 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5823 really isn't Logged- specific
5824 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5825 header, since it's almost always going to be appended to an
5827 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5828 update test to handle use of notifyOnDisconnect
5830 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5831 don't clear .ETA and .currentBuild when going offline, let the
5832 current build clean up after itself
5834 * buildbot/process/builder.py (Builder.detached): wait a moment
5835 before doing things like stopping the current build, because the
5836 current step will probably notice the disconnect and cleanup the
5838 * buildbot/test/test_run.py (Status.tearDown): update test to
5839 handle asynchronous build-detachment
5841 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5843 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5844 hush a debug message
5846 2004-09-05 Brian Warner <warner@lothar.com>
5848 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5849 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5850 kernels do this: the fcntl module has the F_NOTIFY constant, but
5851 the kernel itself doesn't support the operation. Thanks to Olly
5852 Betts for spotting the problem.
5854 * buildbot/process/step.py (Darcs): new source-checkout command
5855 (Arch): new source-checkout command
5856 (todo_P4): fix constructor syntax, still just a placeholder
5857 * buildbot/test/test_vc.py (VC.testDarcs): test it
5858 (VC.testDarcsHTTP): same, via localhost HTTP
5860 (VC.testArchHTTP): same
5861 * NEWS: mention new features
5863 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5864 which tells the step to stash stdout text locally (in .stdout).
5865 Slave-side Commands can use this to make decisions based upon the
5866 output of the the ShellCommand (not just the exit code).
5867 (Darcs): New source-checkout command
5868 (Arch): New source-checkout command, uses .keepStdout in one place
5869 where it needs to discover the archive's default name.
5871 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5872 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5873 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5875 * buildbot/process/step.py (ShellCommand.describe): add an
5876 alternate .descriptionDone attribute which provides descriptive
5877 text when the step is complete. .description can be ["compiling"],
5878 for use while the step is running, then .descriptionDone can be
5879 ["compile"], used alone when the step succeeds or with "failed" when
5880 it does not. Updated other steps to use the new text.
5881 * buildbot/process/step_twisted.py: same
5882 * buildbot/test/test_run.py: update tests to match
5884 2004-08-30 Brian Warner <warner@lothar.com>
5886 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5887 (CVS.__init__): send 'patch' argument to slave
5888 (CVS.start): don't create the LoggedRemoteCommand until start(),
5889 so we can catch a .patch added after __init__
5890 (SVN.__init__): add 'patch' to SVN too
5893 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5894 argument, to let commands push data into the process' stdin pipe.
5895 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5896 is in use, since closing a PTY doesn't really affect the process
5897 in the right way (in particular, I couldn't run /usr/bin/patch
5899 (SourceBase.doPatch): handle 'patch' argument
5901 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5904 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5905 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5907 * buildbot/master.py (BotPerspective.got_commands): get command
5908 versions from slave, give to each builder
5909 * buildbot/process/builder.py (Builder.attached): stash slave
5910 command versions in .remoteCommands
5912 * docs/steps.xhtml: bring docs in-line with reality
5914 * buildbot/process/step.py (CVS.__init__): more brutal
5915 compatibility code removal
5916 (SVN.__init__): same
5918 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5919 (SlaveShellCommand.start): require ['workdir'] argument, remove
5920 the ['dir'] fallback (compatibility will come later)
5921 (SourceBase): update docs
5922 (SourceBase.start): remove ['directory'] fallback
5925 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5926 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5927 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5929 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5930 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5931 code.. I will figure out 0.5.0-compatibility hooks later)
5933 2004-08-30 Brian Warner <warner@lothar.com>
5935 * buildbot/process/process_twisted.py: rewrite in terms of new
5936 BuildFactory base class. It got significantly shorter. Yay
5939 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5940 work with the new "self.build isn't nailed down until we call
5941 step.start()" scheme: specifically, __init__ is called before the
5942 build has decided on which Changes are going in, so we don't scan
5943 build.allFiles() for .xhtml files until start()
5944 (HLint.commandComplete): use getText(), not getStdout()
5945 (RunUnitTests.start): same: don't use .build until start()
5946 (RunUnitTests.describe): oops, don't report (None) when using
5948 (RunUnitTests.commandComplete): use getText()
5949 (RunUnitTests.createSummary): same
5950 (BuildDebs.commandComplete): same
5952 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5953 set args['command'] until start(), since our BuildStep is allowed
5954 to change their mind up until that point
5955 (TreeSize.commandComplete): use getText(), not getStdout()
5957 * docs/examples/twisted_master.cfg: update to current standards
5959 * docs/factories.xhtml: update
5960 * buildbot/process/factory.py: implement all the common factories
5961 described in the docs. The Trial factory doesn't work yet, and
5962 I've probably broken all the process_twisted.py factories in the
5963 process. There are compatibility classes left in for things like
5964 the old BasicBuildFactory, but subclasses of them are unlikely to
5966 * docs/examples/glib_master.cfg: use new BuildFactories
5967 * docs/examples/hello.cfg: same
5969 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5970 explicit 'workdir' args
5972 * buildbot/process/base.py (BuildFactory): move factories to ..
5973 * buildbot/process/factory.py (BuildFactory): .. here
5974 * buildbot/process/process_twisted.py: handle move
5975 * buildbot/test/test_config.py: same
5976 * buildbot/test/test_run.py: same
5977 * buildbot/test/test_steps.py: same
5978 * buildbot/test/test_vc.py: same
5979 * docs/factories.xhtml: same
5981 * NEWS: mention config changes that require updating master.cfg
5983 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5984 argument to all steps that weren't given one already, pointing at
5985 the "build/" directory.
5987 * docs/examples/hello.cfg: remove explicit 'workdir' args
5989 * docs/factories.xhtml: document standard BuildFactory clases,
5990 including a bunch which are have not yet been written
5992 2004-08-29 Brian Warner <warner@lothar.com>
5994 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5995 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5996 buildbot.status.builder so they aren't quite so internal
5997 * buildbot/process/base.py, buildbot/process/builder.py: same
5998 * buildbot/process/maxq.py, buildbot/process/step.py: same
5999 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6000 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6001 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6003 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6004 to handle new getLogs()-returns-list behavior
6005 (StatusResourceBuildStep.getChild): same
6006 (StepBox.getBox): same
6007 (WaterfallStatusResource.phase0): same
6009 * docs/source.xhtml: document how Buildbot uses version-control
6010 systems (output side: how we get source trees)
6011 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6012 systems (input side: how we learn about Changes)
6014 * buildbot/master.py (Manhole): use ComparableMixin
6015 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6016 * buildbot/changes/mail.py (MaildirSource): same
6017 * buildbot/status/client.py (PBListener): same
6018 * buildbot/status/html.py (Waterfall): same
6019 * buildbot/status/words.py (IRC): same
6021 * NEWS: start describing new features
6023 * buildbot/status/mail.py (MailNotifier): finish implementation.
6024 The message body is still a bit sparse.
6025 * buildbot/test/test_status.py (Mail): test it
6027 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6028 and __hash__ methods I wind up adding everywhere. Specifically
6029 intended to support the buildbot config-file update scheme where
6030 we compare, say, the old list of IStatusTargets against the new
6031 one and don't touch something which shows up on both lists.
6032 * buildbot/test/test_util.py (Compare): test case for it
6034 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6035 return a list instead of a dict
6036 (IBuildStepStatus.getLogs): same. The idea is that steps create
6037 logs with vaguely unique names (although their uniqueness is not
6038 guaranteed). Thus a compilation step should create its sole
6039 logfile with the name 'compile', and contribute it to the
6040 BuildStatus. If a step has two logfiles, try to create them with
6041 different names (like 'test.log' and 'test.summary'), and only
6042 contribute the important ones to the overall BuildStatus.
6043 * buildbot/status/builder.py (Event.getLogs): same
6044 (BuildStepStatus): fix default .text and .results
6045 (BuildStepStatus.addLog): switch to list-like .getLogs()
6046 (BuildStepStatus.stepFinished): same
6047 (BuildStatus.text): fix default .text
6048 (BuildStatus.getLogs): temporary hack to return all logs (from all
6049 child BuildStepStatus objects). Needs to be fixed to only report
6050 the significant ones (as contributed by the steps themselves)
6051 * buildbot/test/test_run.py: handle list-like .getLogs()
6052 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6054 2004-08-28 Brian Warner <warner@lothar.com>
6056 * buildbot/process/builder.py (Builder.attached): serialize the
6057 attachment process, so the attach-watcher isn't called until the
6058 slave is really available. Add detached watchers too, which makes
6061 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6063 * buildbot/test/test_swap.py: remove dead code
6065 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6066 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6067 sort of as if the command being run exited with a -1. There may
6068 still be some holes in this scheme.
6069 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6070 -r option appears before the module list
6071 * buildbot/process/step.py (CVS): add 'revision' argument
6073 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6074 when sending updates or stepComplete messages to the master, since
6075 we don't currently care whether they arrive or not. When we revamp
6076 the master/slave protocol to really resume interrupted builds,
6077 this will need revisiting.
6078 (lostRemote): remove spurious print
6080 * buildbot/master.py (BotPerspective.attached): serialize the
6081 new-builder interrogation process, to make testing easier
6082 (BotMaster.waitUntilBuilderDetached): convenience function
6084 * buildbot/status/builder.py (BuilderStatus): prune old builds
6085 (BuildStatus.pruneSteps): .. and steps
6086 (BuildStepStatus.pruneLogs): .. and logs
6087 (BuilderStatus.getBuild): handle missing builds
6088 * buildbot/status/html.py (StatusResourceBuild.body): display build
6089 status in the per-build page
6090 (BuildBox.getBox): color finished builds in the per-build box
6092 2004-08-27 Brian Warner <warner@lothar.com>
6094 * buildbot/status/mail.py (MailNotifier): new notification class,
6097 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6098 variants of a common base class which handles all the mode= logic
6100 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6102 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6104 2004-08-26 Brian Warner <warner@lothar.com>
6106 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6109 * buildbot/test/test_run.py: update to new Logfile interface, new
6110 buildbot.slave modules
6111 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6113 * MANIFEST.in: new sample config file
6114 * docs/examples/hello.cfg: same
6116 * buildbot/process/step_twisted.py: remove dead import
6118 * buildbot/process/step.py (RemoteCommand.run): catch errors
6120 (RemoteCommand.remote_update): ignore updates that arrive after
6122 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6123 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6124 the responsibilities of the subclass's methods
6125 (BuildStep.failed): catch errors during failure processing
6126 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6127 (CVS): move to a mode= argument (described in docstring), rather
6128 than the ungainly clobber=/export=/copydir= combination.
6129 (SVN): add mode= functionality to SVN too
6130 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6132 * buildbot/process/base.py (Build.startNextStep): catch errors
6133 during s.startStep()
6135 * buildbot/clients/base.py: update to new PB client interface.
6136 gtkPanes is still broken
6138 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6139 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6140 * setup.py: add buildbot.slave module
6141 * buildbot/bb_tap.py: handle move
6142 * buildbot/slave/registry.py: place to register commands, w/versions
6143 * buildbot/slave/bot.py: major simplifications
6144 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6145 instead of a fixed table. Eventually this will make the slave more
6146 extensible. Use 'start' method on the command, not .startCommand.
6147 Fix unsafeTracebacks handling (I think).
6148 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6149 helper class with a .start method that returns a Deferred.
6150 SlaveShellCommand is the form reached by the buildmaster. Commands
6151 which use multiple ShellCommands can just chain them as Deferreds,
6152 with some helper methods in Command (_abandonOnFailure and
6153 _checkAbandoned) to bail on rc!=0.
6154 (CVSCommand): prefer new mode= argument
6155 (SVNFetch): add mode= argument
6157 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6158 put a useful reason string on the build
6160 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6161 core functionality into an IStatusLog object
6162 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6163 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6164 (StatusResourceBuild.body): use proper accessor methods
6165 * buildbot/status/client.py (RemoteLog): PB-access goes here
6166 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6167 which delivers log contents too
6168 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6169 * buildbot/status/event.py: remove old Logfile completely
6171 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6172 subscription interface for IStatusLog subscriptions just like all
6173 other the status subscriptions
6174 (IStatusReceiver.logChunk): method called on subscribers
6176 2004-08-24 Brian Warner <warner@lothar.com>
6178 * buildbot/process/builder.py (Builder._pong): oops, ping response
6179 includes a result (the implicit None returned by remote_print).
6180 Accept it so the _pong method handles the response correctly.
6182 2004-08-06 Brian Warner <warner@lothar.com>
6184 * buildbot/test/test_config.py: update IRC, PBListener tests
6186 * buildbot/status/client.py (StatusClientPerspective): total
6187 rewrite to match new IStatus interfaces. New subscription scheme.
6188 There are still a few optimizations to make (sending down extra
6189 information with event messages so the client doesn't have to do a
6190 round trip). The logfile-retrieval code is probably still broken.
6191 Moved the PB service into its own port, you can no longer share a
6192 TCP socket between a PBListener and, say, the slaveport (this
6193 should be fixed eventually).
6194 * buildbot/clients/base.py (Client): revamp to match. still needs
6195 a lot of work, but basic event reporting works fine. gtkPanes is
6198 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6199 instance talks to a single irc server. Threw out all the old
6200 multi-server handling code. Still need to add back in
6201 builder-control (i.e. "force build")
6203 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6204 more random text to the as-yet-unreachable per-step page
6206 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6207 rename to stepETAUpdate
6208 (BuildStatus.subscribe): add build-wide ETA updates
6209 (BuilderStatus.getState): remove more cruft
6210 (BuilderStatus.getCurrentBuild): remove more cruft
6211 (BuilderStatus.buildStarted): really handle tuple-subscription
6212 * buildbot/test/test_run.py (Status.testSlave): handle the
6213 stepETAUpdate rename
6215 * buildbot/master.py (BuildMaster): don't add a default
6216 StatusClientService. Don't add a default IrcStatusFactory. Both
6217 are now added through c['status'] in the config file. c['irc'] is
6218 accepted for backwards compatibility, the only quirk is you cannot
6219 use c['irc'] to specify IRC servers on ports other than 6667.
6221 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6222 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6223 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6224 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6227 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6228 the buildmaster to re-read its config file
6231 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6232 find out the port our server is running on
6233 (WebTest.test_webPathname_port): same
6235 * buildbot/test/test_config.py (testWebPortnum): test it
6236 (testWebPathname): ditto
6238 * docs/config.xhtml: document new c['status'] configuration option
6240 * buildbot/status/html.py (Waterfall): new top-level class which
6241 can be added to c['status']. This creates the Site as well as the
6242 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6243 reachable as .parent, for everything.
6245 * buildbot/master.py (Manhole): make it a normal service Child
6246 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6247 webPathname. It will eventually replace c['irc'] and the implicit
6248 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6249 in as (deprecated) backward compatibility hooks for now.
6252 * buildbot/process/builder.py (Builder.buildFinished): don't
6253 inform out builder_status about a finished build, as it finds out
6254 through its child BuildStatus object
6256 * buildbot/status/html.py: extensive revamp. Use adapters to make
6257 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6258 have both starting and finishing times and adjust the waterfall
6259 display accordingly, using spacers if necessary. Use SlaveStatus
6260 to get buildslave info.
6261 (StatusResourceBuildStep): new just-one-step resource, used to get
6262 logfiles. No actual href to it yet.
6264 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6265 the time being, until I get the file-naming scheme right
6267 * buildbot/status/builder.py (Event): clean started/finished names
6268 (BuildStatus.isFinished): .finished is not None is the right test
6269 (BuildStatus.buildStarted): track started/finished times ourselves
6270 (BuilderStatus.getSlave): provide access to SlaveStatus object
6271 (BuilderStatus.getLastFinishedBuild): all builds are now in
6272 .builds, even the currently-running one. Accomodate this change.
6273 (BuilderStatus.eventGenerator): new per-builder event generator.
6274 Returns BuildStepStatus and BuildStatus objects, since they can
6275 both be adapted as necessary.
6276 (BuilderStatus.addEvent): clean up started/finished attributes
6277 (BuilderStatus.startBuild,finishBuild): remove dead code
6278 (SlaveStatus): new object to provide ISlaveStatus
6280 * buildbot/process/step.py (ShellCommand.getColor): actually
6281 return the color instead of setting it ourselves
6282 (CVS.__init__): pull .timeout and .workdir options out of
6283 **kwargs, since BuildStep will ignore them. Without this neither
6284 will be sent to the slave correctly.
6285 (SVN.__init__): same
6287 * buildbot/process/builder.py (Builder): move flags to class-level
6289 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6290 SlaveStatus handle that
6292 * buildbot/process/base.py (Build.firstEvent): remove dead code
6293 (Build.stopBuild): bugfix
6295 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6297 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6298 (ChangeMaster.eventGenerator): yield Changes, since there are now
6299 Adapters to turn them into HTML boxes
6301 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6302 (BotPerspective.attached): feed a SlaveStatus object
6303 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6304 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6306 * buildbot/interfaces.py: API additions
6307 (ISlaveStatus): place to get slave status
6309 2004-08-04 Brian Warner <warner@lothar.com>
6311 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6312 the delay finishes, so the step is marked as SUCCESS
6314 * buildbot/test/test_run.py (Status.testSlave): cover more of
6315 IBuildStatus and IBuildStepStatus
6317 * buildbot/status/progress.py (StepProgress): move some flags to
6318 class-level attributes
6319 (StepProgress.remaining): if there are no other progress metrics
6320 to go by, fall back to elapsed time
6321 (StepProgress.setExpectations): take a dict of metrics instead of
6323 (BuildProgress.setExpectationsFrom): pull expectations from the
6324 Expectations, instead of having it push them to the BuildProgress
6325 (Expectations): move some flags to class-level attributes
6326 (Expectations.__init__): copy per-step times from the
6328 (Expectations.expectedBuildTime): new method for per-build ETA
6330 * buildbot/status/event.py (Logfile): move some flags to
6331 class-level attributes
6332 (Logfile.logProgressTo): better method name, let step set the
6333 progress axis name (instead of always being "output")
6335 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6336 times directly, rather than depending upon the (possibly missing)
6337 .progress object. Use 'None' to indicate "not started/finished
6339 (BuildStepStatus.getExpectations): oops, return the full list of
6341 (BuilderStatus._buildFinished): append finished builds to .builds
6343 * buildbot/process/step.py (BuildStep): add separate .useProgress
6344 flag, since empty .progressMetrics[] still implies that time is a
6346 (CVS): set up the cmd in __init__, instead of waiting for start()
6348 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6349 calculation, this will eventually turn into a proper sourceStamp
6350 (Build.setupBuild): tell the Progress to load from the Expectations,
6351 instead of having the Expectations stuff things into the Progress
6352 (Build.buildException): add a build-level errback to make sure the
6353 build's Deferred fires even in case of exceptions
6355 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6357 * buildbot/process/builder.py (Builder.forceBuild): convey the
6358 reason instead of creating a fake Change
6360 * docs/examples/twisted_master.cfg: update to match reality
6362 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6363 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6364 fix or remove broken/breaking tests
6366 * buildbot/status/event.py (Logfile.__len__): remove evil method
6368 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6369 missing .build, for test convenience
6371 * buildbot/process/step_twisted.py: import fixes
6373 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6375 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6376 .statusbag reference
6378 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6379 connection at shutdown, and stop it from reconnecting
6381 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6382 chase down remote-execution bugs
6384 * buildbot/process/step.py: more fixes, remove
6385 BuildStep.setStatus()
6386 * buildbot/status/builder.py: move setStatus() functionality into
6388 * buildbot/status/event.py: minor fixes
6390 2004-08-03 Brian Warner <warner@lothar.com>
6392 * buildbot/process/base.py, buildbot/process/builder.py
6393 * buildbot/process/step.py, buildbot/status/builder.py
6394 * buildbot/status/event.py, buildbot/test/test_run.py:
6395 fix status delivery, get a basic test case working
6396 * buildbot/master.py: finish implementing basic status delivery,
6397 temporarily disable HTML/IRC/PB status sources
6399 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6401 * buildbot/status/progress.py (BuildProgress): remove dead code
6403 * buildbot/interfaces.py
6404 * buildbot/process/base.py, buildbot/process/builder.py
6405 * buildbot/process/step.py, buildbot/process/step_twisted.py
6406 * buildbot/status/builder.py: Complete overhaul of the all
6407 status-delivery code, unifying all types of status clients (HTML,
6408 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6409 look like. This commit is a checkpointing of the work-in-progress:
6410 the input side is mostly done (Builders/Builds sending status
6411 to the BuilderStatus/BuildStatus objects), but the output side has
6412 not yet been started (HTML resources querying BuilderStatus
6413 objects). Things are probably very broken right now and may remain
6414 so for several weeks, I apologize for the disruption.
6416 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6417 HTML as the log's contents. Currently used for exception tracebacks.
6418 * buildbot/status/progress.py: minor spelling changes
6420 2004-08-02 Brian Warner <warner@lothar.com>
6422 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6423 in mozilla. Also added stylesheets copied from Twisted's docs.
6424 Remember that these files are meant to be run through Lore first.
6425 Thanks to Philipp Frauenfelder for the fixes.
6426 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6427 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6428 * docs/template.tpl: added a Lore template
6430 2004-07-29 Brian Warner <warner@lothar.com>
6432 * buildbot/interfaces.py: revamp status delivery. This is the
6433 preview: these are the Interfaces that will be provided by new
6434 Builder code, and to which the current HTML/IRC/PB status
6435 displayers will be adapted.
6437 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6438 on the SlaveBuilder, not the Bot.
6439 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6441 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6442 set .usePTY on the FakeSlaveBuilder
6444 2004-07-25 Brian Warner <warner@lothar.com>
6446 * buildbot/changes/freshcvs.py: add some debug log messages
6447 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6448 disabled 'setFilter' syntax
6449 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6450 don't end with a slash
6452 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6454 * setup.py: bump to 0.5.0+ while between releases
6456 2004-07-23 Brian Warner <warner@lothar.com>
6458 * setup.py (version): Releasing buildbot-0.5.0
6460 2004-07-23 Brian Warner <warner@lothar.com>
6462 * README: update for 0.5.0 release
6464 * NEWS: update for 0.5.0 release
6466 2004-07-22 Brian Warner <warner@lothar.com>
6468 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6469 mktap-time configuration flag (--usepty=1, --usepty=0)
6470 * buildbot/bot.py: same
6472 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6473 an 'info' directory being unwanted
6475 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6476 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6477 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6478 and earlier), use a FreshCVSSourceOldcred instead.
6479 (test): simple test routine: connect to server, print changes
6481 * buildbot/changes/changes.py (Change.getTime): make it possible
6482 to print un-timestamped changes
6484 * buildbot/master.py (makeApp): delete ancient dead code
6485 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6486 * buildbot/test/test_config.py (testFindConfigFile): test it
6488 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6489 instead of win32 one
6492 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6493 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6496 * buildbot/process/base.py (Builder.__init__): change constructor
6497 to accept a dictionary of config data, rather than discrete
6498 name/slave/builddir/factory arguments
6500 * docs/examples/twisted_master.cfg: update to new syntax
6501 * docs/examples/glib_master.cfg: same
6502 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6503 rough tests of the new syntax
6506 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6507 to be an int, which means "run a web.distrib sub-server on a TCP
6508 port". This lets you publish the buildbot status page to a remote
6509 twisted.web server (using distrib.ResourceSubscription). Also
6510 rename the local attributes used to hold these web things so
6511 they're more in touch with reality.
6512 * buildbot/test/test_web.py: test webPortnum and webPathname
6513 * docs/config.xhtml: document this new use of webPathname
6515 * docs/config.xhtml: new document, slightly ahead of reality
6517 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6518 'prefix' handling: treat it as a simple string to check with
6519 .startswith, instead of treating it as a directory. This allows
6520 sub-directories to be used. If you use prefix=, you should give it
6521 a string that starts just below the CVSROOT and ends with a slash.
6522 This prefix will be stripped from all filenames, and filenames
6523 which do not start with it will be ignored.
6525 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6527 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6528 and --exclude (inverse of --include). SVN post-commit hooks
6529 now have total control over which changes get sent to buildbot and which
6532 2004-07-10 Brian Warner <warner@lothar.com>
6534 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6535 test case to match new API
6537 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6538 which crashed HTML display when self.entries=[] (needed to
6539 distinguish between [], which means "no entries yet", and None,
6540 which means "the entries have been swapped out to disk, go fetch
6543 2004-07-04 Brian Warner <warner@lothar.com>
6545 * buildbot/process/step_twisted.py (countFailedTests): Count
6546 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6547 10kb from the end because any import errors are wedged there and
6548 they would make us think the test log was unparseable.
6549 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6551 2004-06-26 Brian Warner <warner@lothar.com>
6553 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6554 delete-*.pyc command into an actual BuildStep, so we can label it
6556 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6557 (FullTwistedBuildFactory): same
6559 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6561 * contrib/fakechange.py: Add an errback when sending the fake
6562 change, so we know it didn't work.
6564 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6566 * buildbot/process/step_twisted.py: Delete *.pyc files before
6567 calling trial, so it doesn't catch any old .pyc files whose .py
6568 files have been moved or deleted.
6570 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6571 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6572 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6573 instead of ["twisted.test"], so that the end result is "trial -R
6576 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6577 regular expression to match filenames that should be ignored when
6578 changed. Also add a --revision parameter that specifies the
6579 revision to examine, which is useful for debugging.
6581 2004-06-25 Brian Warner <warner@lothar.com>
6583 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6584 summary of warnings (like DeprecationWarnings), next to the
6587 2004-05-13 Brian Warner <warner@lothar.com>
6589 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6590 we now have a w32 build slave courtesy of Mike Taylor.
6592 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6593 so broken. Fixed a race condition that tripped up interlocked
6594 builds and caused the status to be stuck at "Interlocked" forever.
6595 The twisted buildbot's one interlocked build just so happened to
6596 never hit this case until recently (the feeding builds both pass
6597 before the interlocked build is attempted.. usually it has to wait
6599 (Builder._pong_failed): fix method signature
6601 * setup.py: bump to 0.4.3+ while between releases
6603 2004-04-30 Brian Warner <warner@lothar.com>
6605 * setup.py (version): Releasing buildbot-0.4.3
6607 2004-04-30 Brian Warner <warner@lothar.com>
6609 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6611 * README: update for 0.4.3 release
6613 * NEWS: update for 0.4.3 release
6615 * buildbot/master.py (BuildMaster.__getstate__): make sure
6616 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6618 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6619 .trial as a class attribute, for upgrade from 0.4.2
6621 * buildbot/changes/changes.py (Change.links): add .links for
6624 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6625 .textWatchers and .htmlWatchers at save time, since they are both
6626 volatile, should allow smooth 0.4.2 upgrade
6628 * buildbot/process/step.py (CVS.finishStatus): catch failed
6629 CVS/SVN commands so we can make the status box red
6631 2004-04-29 Brian Warner <warner@lothar.com>
6633 * buildbot/changes/freshcvs.py
6634 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6635 code to do setFilter(), which tells the freshcvs daemon to not
6636 send us stuff that we're not interested in. I will uncomment it
6637 when a new version of CVSToys is available in which setFilter()
6638 actually works, and I get a chance to test it better.
6640 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6642 * buildbot/master.py (Dispatcher): use a registration scheme
6643 instead of hardwired service names
6644 (BuildMaster): keep track of the Dispatcher to support
6647 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6648 PBChangeSource class instead of having it be an undocumented
6649 internal feature of the ChangeMaster. Split out the code into a
6651 * buildbot/changes/pb.py (PBChangeSource): same
6652 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6654 * docs/{factories|sources|steps}.xhtml: document some pieces
6656 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6657 using FCMaildirSource
6658 (f23osx): update OS-X builder to use python2.3, since the slave
6659 was updated to Panther (10.3.3)
6661 2004-03-21 Brian Warner <warner@lothar.com>
6663 * buildbot/process/process_twisted.py: factor out doCheckout, change
6664 to use SVN instead of CVS
6666 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6667 an SVN subclass easier
6668 (BasicSVN): subclass which uses Subversion instead of CVS
6670 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6672 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6674 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6676 2004-02-25 Brian Warner <warner@lothar.com>
6678 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6679 is now either a list (which is passed to spawnProcess directly) or
6680 a string (which gets passed to /bin/sh -c). This removes the useSH
6681 flag and the ArgslistCommand class. Also send status header at the
6682 start and end of each command, instead of having the master-side
6684 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6685 -r'. Update to use list-based arguments.
6686 (SVNFetch): use list-based arguments, use ['dir'] argument to
6688 * buildbot/test/test_steps.py (Commands): match changes
6690 * buildbot/process/step.py (InternalShellCommand.words): handle
6692 (SVN): inherit from CVS, cleanup
6694 * buildbot/status/event.py (Logfile.content): render in HTML, with
6695 stderr in red and headers (like the name of the command we're
6696 about to run) in blue. Add link to a second URL (url + "?text=1")
6697 to get just stdout/stderr in text/plain without markup. There is
6698 still a problem with .entries=None causing a crash, it seems to occur
6699 when the logfile is read before it is finished.
6701 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6702 timeout to the keepalives, and use it to explicitly do a
6703 loseConnection instead of waiting for TCP to notice the loss. This
6704 ought to clear up the silent-lossage problem.
6705 (unsafeTracebacks): pass exception tracebacks back to the master,
6706 makes it much easier to debug problems
6708 2004-02-23 Brian Warner <warner@lothar.com>
6710 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6711 the whole command to /bin/sh instead of execve [Johan Dahlin]
6712 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6713 '-r HEAD' [Johan Dahlin]
6714 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6716 * buildbot/changes/changes.py (Change): add links= argument, add
6717 asHTML method [Johan Dahlin]. Modified to make a bit more
6718 XHTMLish. Still not sure how to best use links= .
6720 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6721 Change.asHTML to display the change, not asText
6723 * buildbot/status/html.py (StatusResourceBuilder): web button to
6726 * buildbot/test/test_run.py: test to actually start a buildmaster
6729 * MANIFEST.in: bring back accidentally-dropped test helper files
6731 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6732 that require cvstoys if it is not installed
6734 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6735 values of "bin/trial" [Dave Peticolas]
6736 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6737 tests passed" when we didn't happen to run any tests
6739 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6740 flunkOnFailure [Johan Dahlin]
6742 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6743 multiple instances of the same Step class by suffixing "_2", etc,
6744 to the name until it is unique. This name needs to be unique
6745 because it is used as a key in the dictionary that tracks build
6747 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6750 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6752 2004-01-14 Brian Warner <warner@lothar.com>
6754 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6755 kicked from a channel, log it
6757 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6758 something over whatever IRC channels the buildmaster is currently
6759 connected to. Added to try and track down a problem in which the
6760 master thinks it is still connected but the IRCd doesn't see it. I
6761 used a styles.Versioned this time, so hopefully users won't have
6762 to rebuild their .tap files this time.
6763 * contrib/debug.glade: add a "Poke IRC" button
6764 * contrib/debugclient.py: same
6766 * setup.py: bump to 0.4.2+ while between releases
6768 2004-01-08 Brian Warner <warner@lothar.com>
6770 * setup.py (version): Releasing buildbot-0.4.2
6772 2004-01-08 Brian Warner <warner@lothar.com>
6774 * NEWS: update for 0.4.2 release
6776 * README: document how to run the tests, now that they all pass
6778 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6780 * buildbot/process/step.py (CVS): add a global_options= argument,
6781 which lets you set CVS global options for the command like "-r"
6782 for read-only checkout, or "-R" to avoid writing in the
6784 * buildbot/slavecommand.py (CVSCommand): same
6786 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6787 testing easier (it is turned off when testing, to avoid the
6790 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6791 to make it easier to test: break generateStepID() out to a
6792 separate function, only update statusbag if it exists.
6793 (ShellCommands): create useful text for dict-based commands too.
6795 * test/*, buildbot/test/*: move unit tests under the buildbot/
6797 * setup.py (packages): install buildbot.test too
6799 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6800 * buildbot/test/test_steps.py: fix it, tests pass now
6802 2004-01-06 Brian Warner <warner@lothar.com>
6804 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6805 freshcvs mail uses a slightly different syntax for new
6806 directories. Update parser to handle either.
6807 * test/test_mailparse.py (Test1.testMsg9): test for same
6809 2003-12-21 Brian Warner <warner@lothar.com>
6811 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6812 'warnOnWarnings' so that lintian errors mark the build orange
6814 2003-12-17 Brian Warner <warner@lothar.com>
6816 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6817 messages emitted by Bonsai, contributed by Stephen Davis.
6819 * test/*: moved all tests to use trial instead of unittest. Some
6820 still fail (test_steps, test_slavecommand, and test_process).
6822 * setup.py (version): bump to 0.4.1+ while between releases
6824 2003-12-09 Brian Warner <warner@lothar.com>
6826 * setup.py (version): Releasing buildbot-0.4.1
6828 2003-12-09 Brian Warner <warner@lothar.com>
6830 * NEWS: update for 0.4.1 release
6832 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6833 freebsd builder code a little bit
6835 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6836 don't try to compare attributes of different classes
6837 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6838 (MaildirSource.messageReceived): fix Change delivery
6840 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6841 into the config file's namespace before loading it, like the
6842 documentation claims it does
6843 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6844 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6845 daemon comes back online
6847 2003-12-08 Brian Warner <warner@lothar.com>
6849 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6850 so the example will work with online=0 as well
6852 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6853 fix the __implements__ line
6855 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6856 class a twisted.application.service.Service, use startService to
6859 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6860 directory fd instead of simple open(). I'm sure this used to work,
6861 but the current version of python refuses to open directories with
6864 2003-12-05 Brian Warner <warner@lothar.com>
6866 * setup.py (version): bump to 0.4.0+ while between releases
6868 2003-12-05 Brian Warner <warner@lothar.com>
6870 * setup.py (version): Releasing buildbot-0.4.0
6872 2003-12-05 Brian Warner <warner@lothar.com>
6874 * docs/examples/glib_master.cfg: replace old sample scripts with
6875 new-style config files
6876 * MANIFEST.in: include .cfg files in distribution tarball
6878 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6879 implement a dummy method to avoid the exception that occurs when
6880 freshcvs sends this to us.
6882 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6883 removed the method, as it broke reconnection. Apparently
6884 stopFactory is called each time the connection attempt fails. Must
6886 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6887 attribute before serialization, since without stopFactory the
6888 reconnect timer may still be active and they aren't serializable.
6890 * test/test_mailparse.py (ParseTest): test with 'self' argument
6892 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6893 argument, as these "functions" are invoked like methods from class
6894 attributes and therefore always get an instance as the first
6897 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6898 message: thanks to Stephen Davis for the catch
6900 2003-12-04 Brian Warner <warner@lothar.com>
6902 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6903 twisted's standard ReconnectingClientFactory. Handles both oldcred
6904 and newcred connections. Also has a bug-workaround for
6905 ReconnectingClientFactory serializing its connector when it
6908 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6909 pbutil. Replace makeApp stuff with proper newcred/mktap
6910 makeService(). Don't serialize Ephemerals on shutdown.
6912 * buildbot/changes/changes.py (ChangeMaster): make it a
6913 MultiService and add the sources as children, to get startService
6914 and stopService for free. This also gets rid of the .running flag.
6916 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6917 new pbutil, turn into a TCPClient at the same time (to get
6918 startService for free). Two variants exist: FreshCVSSourceOldcred
6919 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6920 yet, but when it does, we'll be ready).
6921 (FreshCVSSource.notify): handle paths which are empty after the
6922 prefix is stripped. This only happens when the top-level (prefix)
6923 directory is added, at the very beginning of a Repository's life.
6925 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6926 Now the only reconnecting code is in the factory where it belongs.
6927 (Builder.unsubscribe): unregister the disconnect callback when we
6928 delete the builder on command from the master (i.e. when the
6929 buildmaster is reconfigured and that builder goes away). This
6930 fixes a multiple-delete exception when the status client is shut
6932 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6935 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6936 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6938 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6940 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6941 a list of globs (ugh). The testdir will be searched for files
6942 named *.tests and run the tests in the order specified in each of
6943 those files. This allows for "dependancies" between tests to be
6946 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6947 argument to pass to run_maxq.py, instead of a glob.
6949 2003-10-17 Brian Warner <warner@lothar.com>
6951 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6952 files that live in the sandbox
6954 2003-10-15 Brian Warner <warner@lothar.com>
6956 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6957 spelling error in "docs" count-warnings output
6958 (HLint.start): stupid thinko meant .xhtml files were ignored
6960 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6961 tests now that cReactor is banished to the sandbox
6963 2003-10-10 Brian Warner <warner@lothar.com>
6965 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6966 scheme: now .xhtml are sources and .html are generated
6968 2003-10-08 Brian Warner <warner@lothar.com>
6970 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6971 we were ignoring the 'randomly' parameter.
6973 2003-10-01 Brian Warner <warner@lothar.com>
6975 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6976 posix, to kill sub-children of aborted slavecommands.
6978 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6979 Clean up initialization: lastBuildStatus remains None until the
6980 first build has been completed.
6982 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6983 None as a lastBuildStatus
6984 * buildbot/clients/gtkPanes.py: same
6986 * buildbot/status/client.py (StatusClientService): keep
6987 BuilderStatus objects in self.statusbags . These objects now live
6988 here in the StatusClientService and are referenced by the Builder
6989 object, rather than the other way around.
6990 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6991 * buildbot/process/base.py (Builder): same
6992 * test/test_config.py (ConfigTest.testBuilders): same
6994 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6995 an existing builder, leave the statusbag alone. This will preserve the
6998 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6999 hook. This will probably go away in favor of a class in upcoming
7002 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7003 serviceName from newcred FreshCVSNotifiee setup
7005 2003-09-29 Brian Warner <warner@lothar.com>
7007 * buildbot/process/process_twisted.py: switch to new reactor
7009 * docs/examples/twisted_master.cfg: same
7011 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7013 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7014 botmaster reference instead of the oldapp service lookup
7016 * buildbot/master.py (BuildMaster.__init__): give the
7017 StatusClientService a reference to the botmaster to make it easier to
7020 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7022 * buildbot/status/html.py (Box.td): escape hreffy things so you
7023 can have spaces in things like builder names
7024 (StatusResourceBuilder.body)
7025 (WaterfallStatusResource.body)
7026 (WaterfallStatusResource.body0): same
7028 2003-09-25 Brian Warner <warner@lothar.com>
7030 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7031 rearrange the builder list when adding or removing builders: keep
7032 them in the order the user requested.
7033 * test/test_config.py (ConfigTest.testBuilders): verify it
7035 * contrib/debug.glade: give the debug window a name
7037 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7038 now wait on multiple interlocks. Fix code relating to that.
7039 (Builder.checkInterlocks): same
7040 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7042 * buildbot/master.py (BuildMaster.loadConfig): move from
7043 deprecated pb.BrokerFactory to new pb.PBServerFactory
7044 * test/test_config.py (ConfigTest.testWebPathname): same
7046 * docs/examples/twisted_master.cfg: fix interlock declaration
7048 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7049 Interlocks to their Builders into interlock.py .
7050 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7052 * test/test_config.py (ConfigTest.testInterlocks): validate
7055 * buildbot/process/base.py (Builder.__init__): better comments
7056 * buildbot/process/interlock.py (Interlock.__repr__): same
7057 (Interlock.deactivate): add .active flag, move the code that
7058 attaches/detaches builders into the Interlock
7060 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7062 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7063 tests using the new run_maxq.py script, and reporting failures by
7066 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7067 tests, reporting their success or failure in a buildbot-friendly
7070 2003-09-24 Brian Warner <warner@lothar.com>
7072 * docs/examples/twisted_master.cfg: example of a new-style config
7073 file. This lives in the buildmaster base directory as
7076 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7077 button to make the master re-read its config file
7079 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7080 buildmaster configuration from a file. This file can be re-read
7081 later, and the buildmaster will update itself to match the new
7082 desired configuration. Also use new Twisted Application class.
7083 * test/Makefile, test/test_config.py: unit tests for same
7085 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7086 FreshCVSSources comparable, to support reload.
7087 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7089 * buildbot/process/base.py (Builder): make them comparable, make
7090 Interlocks easier to attach, to support reload. Handle
7091 re-attachment of remote slaves.
7092 * buildbot/process/interlock.py (Interlock): same
7094 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7095 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7096 buildmaster taps are now constructed with mktap.
7097 * buildbot/status/client.py (StatusClientService): same
7099 * buildbot/status/words.py: move to new Services, add support to
7100 connect to multiple networks, add reload support, allow nickname
7101 to be configured on a per-network basis
7103 2003-09-20 Brian Warner <warner@lothar.com>
7105 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7106 the freebsd builder, now that the machine has been upgraded and no
7107 longer has python2.2
7109 * setup.py (version): bump to 0.3.5+ while between releases
7111 2003-09-19 Brian Warner <warner@lothar.com>
7113 * setup.py (version): Releasing buildbot-0.3.5
7115 2003-09-19 Brian Warner <warner@lothar.com>
7117 * NEWS: add post-0.3.4 notes
7119 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7121 * MANIFEST.in: add contrib/*
7123 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7124 use a remote root now: cvs.twistedmatrix.com
7126 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7128 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7129 compatibility with old servers
7130 (FreshCVSSource.start): and provide a way to use it
7131 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7133 * docs/examples/twisted_master.py (twisted_app): update to new
7135 (twisted_app): listen on new ~buildbot socket
7136 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7138 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7139 to reduce cvs bandwidth (update instead of full checkout)
7141 2003-09-11 Brian Warner <warner@lothar.com>
7143 * contrib/fakechange.py: demo how to connect to the changemaster
7144 port. You can use this technique to submit changes to the
7145 buildmaster from source control systems that offer a hook to run a
7146 script when changes are committed.
7148 * contrib/debugclient.py: tool to connect to the debug port. You
7149 can use it to force builds, submit fake changes, and wiggle the
7152 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7153 'Dispatcher' realm to handle all the different kinds of
7154 connections and Perspectives: buildslaves, the changemaster port,
7155 the debug port, and the status client port. NewCredPerspectives
7156 now have .attached/.detached methods called with the remote 'mind'
7157 reference, much like old perspectives did. All the pb.Services
7158 turned into ordinary app.ApplicationServices .
7159 (DebugService): went away, DebugPerspectives are now created
7160 directly by the Dispatcher.
7161 (makeApp): changed interface a little bit
7163 * buildbot/changes/changes.py: newcred
7164 * buildbot/status/client.py: newcred
7166 * buildbot/clients/base.py: newcred client side changes
7167 * buildbot/bot.py: ditto
7169 * docs/examples/glib_master.py: handle new makeApp() interface
7170 * docs/examples/twisted_master.py: ditto
7172 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7173 base newcred Perspectives on. This should go away once Twisted
7174 itself provides something sensible.
7177 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7179 * contrib/svn_buildbot.py: A program that you can call from your
7180 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7181 when a change in an SVN repository has happened. See the top of
7182 the file for some minimal usage info.
7184 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7186 * buildbot/slavecommand.py (ArglistCommand): Add new
7187 ArglistCommand that takes an argument list rather than a string as
7188 a parameter. Using a st.split() for argv is very bad.
7190 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7191 update to a particular revision rather than always checking out
7192 (still not very smart about it, there may be cases where the
7193 checkout becomes inconsistent).
7195 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7197 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7198 SVN fetch support. It can checkout (not update!) a specified
7199 revision from a specified repository to a specified directory.
7201 * buildbot/status/progress.py (Expectations.update): Fix an
7202 obvious bug (apparently created by the change described in the
7203 previous ChangeLog message) by moving a check to *after* the
7204 variable it checks is defined.
7207 2003-09-08 Brian Warner <warner@lothar.com>
7209 * buildbot/status/progress.py (Expectations.update): hack to catch
7210 an exception TTimo sees: sometimes the update() method seems to
7211 get called before the step has actually finished, so the .stopTime
7212 is not set, so no totalTime() is available and we average None
7213 with the previous value. Catch this and just don't update the
7214 metrics, and emit a log message.
7216 2003-08-24 Brian Warner <warner@lothar.com>
7218 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7219 parameter to set copydir='original' in CVS commands.
7221 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7223 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7224 which tells the command to maintain a separate original-source CVS
7225 workspace. For each build, this workspace will be updated, then
7226 the tree copied into a new workdir. This reduces CVS bandwidth
7227 (from a full checkout to a mere update) while doubling the local
7228 disk usage (to keep two copies of the tree).
7230 2003-08-21 Brian Warner <warner@lothar.com>
7232 * buildbot/status/event.py (Logfile.addEntry): if the master web
7233 server dies while we're serving a page, request.write raises
7234 pb.DeadReferenceError . Catch this and treat it like a
7235 notifyFinish event by dropping the request.
7237 2003-08-18 Brian Warner <warner@lothar.com>
7239 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7240 (instead of blowing up) if a force-build command is given without
7243 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7244 don't blow up if there aren't yet any Changes in the list
7246 2003-08-02 Brian Warner <warner@lothar.com>
7248 * buildbot/bot.py (updateApplication): don't set the .tap name,
7249 since we shouldn't assume we own the whole .tap file
7251 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7252 'mktap buildbot' (without a subcommand) better
7254 2003-07-29 Brian Warner <warner@lothar.com>
7256 * buildbot/status/words.py
7257 (IrcStatusFactory.clientConnectionLost): when we lose the
7258 connection to the IRC server, schedule a reconnection attempt.
7260 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7261 use shutil.rmtree instead of forking off an "rm -rf" command.
7262 rmtree may take a while and will block until it finishes, so we
7263 use "rm -rf" if available.
7265 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7266 freebsd buildslave badly
7268 * setup.py (version): bump to 0.3.4+ while between releases
7270 2003-07-28 Brian Warner <warner@lothar.com>
7272 * setup.py (version): Releasing buildbot-0.3.4
7274 2003-07-28 Brian Warner <warner@lothar.com>
7276 * NEWS: update in preparation for release
7278 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7279 process.signalProcess instead of os.kill, to improve w32
7282 * docs/examples/twisted_master.py (twisted_app): turn off
7283 win32eventreactor: the tests hang the buildslave badly
7285 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7286 failed builds, since usually the failures are consistent
7288 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7289 add compileOpts/compileOpts2 to reactors build
7291 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7292 (twisted_app): use both default and win32eventreactor on w32 build.
7293 Use both default and kqreactor on freebsd build.
7295 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7296 add compileOpts2, which is put after the build_ext argument. w32
7297 needs "-c mingw32" here.
7299 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7300 touch .acqpath, it goes away in recent Twisted releases
7302 * docs/examples/twisted_master.py (twisted_app): use "python" for
7303 the w32 buildslave, not "python2.2"
7305 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7306 the directory exists.. should hush an exception under w32
7308 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7309 ProcessTerminated -provided values for signal and exitCode rather
7310 than parsing the unix status code directly. This should remove one
7311 more roadblock for a w32-hosted buildslave.
7313 * test/test_mailparse.py: add test cases for Syncmail parser
7315 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7316 temporary compatibility import. Note! Start importing
7317 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7319 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7321 2003-07-27 Brian Warner <warner@lothar.com>
7323 * NEWS: started adding new features
7325 * buildbot/changes/mail.py: start work on Syncmail parser, move
7326 mail sources into their own file
7328 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7329 as implementing IChangeSource
7330 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7332 * buildbot/interfaces.py: define the IChangeSource interface
7334 2003-07-26 Brian Warner <warner@lothar.com>
7336 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7338 2003-06-25 Brian Warner <warner@lothar.com>
7340 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7343 2003-06-17 Brian Warner <warner@lothar.com>
7345 * buildbot/status/words.py: clean up method usage to avoid error
7346 in silly IRC command
7347 (IrcStatusBot.emit_status): round off seconds display
7349 * buildbot/process/base.py (Build): delete the timer when saving
7350 to the .tap file, and restore it (if it should still be running)
7351 upon restore. This should fix the "next build in -34 seconds"
7352 messages that result when the master is restarted while builds are
7353 sitting in the .waiting slot. If the time for the build has
7354 already passed, start it very soon (in 1 second).
7356 * buildbot/status/words.py: more silly commands
7358 * README (REQUIREMENTS): add URLs to all required software
7360 * buildbot/status/words.py ('last'): mention results of, and time
7363 2003-05-28 Brian Warner <warner@lothar.com>
7365 * buildbot/status/words.py: add 'last' command
7366 (IrcStatusBot.emit_status): add current-small text to 'status' output
7368 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7369 (twisted_app): remove spaces from OS-X builder name
7371 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7372 * buildbot/status/words.py: IRC bot should actually be useful now
7374 2003-05-23 Brian Warner <warner@lothar.com>
7376 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7377 "slave information" from $(slavedir)/info/* . These files are
7378 maintained by the slave administrator, and describe the
7379 machine/environment that is hosting the slave. Information from
7380 them is put into the "Builder" HTML page. Still need to establish
7381 a set of well-known filenames and meanings for this data: at the
7382 moment, *all* info/* files are sent to the master, but only
7383 'admin' and 'host' are used on that end.
7384 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7385 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7386 * buildbot/master.py (BotPerspective.got_info): ditto
7388 2003-05-22 Brian Warner <warner@lothar.com>
7390 * setup.py (version): bump version to 0.3.3+ while between releases
7392 2003-05-21 Brian Warner <warner@lothar.com>
7394 * setup.py: Releasing buildbot-0.3.3
7396 2003-05-21 Brian Warner <warner@lothar.com>
7398 * NEWS: 0.3.3 news items
7400 * README: describe --keepalive and life behind a NAT box
7402 * buildbot/bot.py (Bot.connected): implement application-level
7403 keepalives to deal with NAT timeouts, turn them on with
7404 --keepalive option or when SO_KEEPALIVE doesn't work.
7406 * buildbot/master.py (BotPerspective): accept keepalives silently
7408 * buildbot/process/base.py (Build.buildException): CopiedFailures
7409 don't carry as much information as local ones, so don't try to
7410 create a big HTMLized version of them.
7412 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7413 log file when step fails due to an exception, such as when the slave
7416 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7417 --testmodule argument instead of grepping for test-case-name tags
7418 ourselves. Remove FindUnitTests code.
7419 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7421 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7423 2003-05-16 Brian Warner <warner@lothar.com>
7425 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7426 argument to allow things like CFLAGS=-O0 to be passed without relying
7427 upon /bin/sh processing on the slave.
7429 * buildbot/process/step.py (InternalShellCommand.start): send
7431 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7432 'split' instead of letting /bin/sh do it. This should also remove
7433 the need for /bin/sh on the buildslave, making it more likely to
7436 * buildbot/status/html.py: html-escape text in blamelist.
7437 Add "force build" button to the Builder page.
7439 * buildbot/process/step_twisted.py (countFailedTests): look at
7440 last 1000 characters for status line, as import errors can put it
7441 before the -200 point.
7443 2003-05-15 Brian Warner <warner@lothar.com>
7445 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7447 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7448 make 'clobber' a parameter, so it is possible to have builds which
7449 do full tests but do a cvs update instead of hammering the CVS
7450 server with a full checkout each build
7452 * buildbot/process/step.py (InternalShellCommand): bump default
7453 timeout to 20 minutes
7455 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7456 the master to trigger a build. Run it via manhole.
7458 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7459 allow slaves to trigger any build that they host, to make life
7460 easier for slave admins who are testing out new build processes
7462 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7463 don't flunk cReactor or qtreactor on failure, since they fail alot
7464 these days. Do warnOnFailure instead.
7466 * buildbot/process/base.py: change Builder.buildable from a list
7467 into a single slot. When we don't have a slave, new builds (once
7468 they make it past the timeout) are now merged into an existing
7469 buildable one instead of being queued. With this change, a slave
7470 which has been away for a while doesn't get pounded with all the
7471 builds it missed, but instead just does a single build.
7473 2003-05-07 Brian Warner <warner@lothar.com>
7475 * setup.py (version): bump version to 0.3.2+ while between releases
7477 2003-05-07 Brian Warner <warner@lothar.com>
7479 * setup.py: Releasing buildbot-0.3.2
7481 2003-05-07 Brian Warner <warner@lothar.com>
7483 * setup.py: fix major packaging error: include subdirectories!
7485 * NEWS: add changes since last release
7487 * README (REQUIREMENTS): update twisted/python dependencies
7489 * buildbot/status/builder.py (Builder.startBuild): change
7490 BuildProcess API: now they should call startBuild/finishBuild
7491 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7492 keeping a list of builds in the statusbag, to support other kinds of
7494 (Builder.addClient): send current-activity-small to new clients
7495 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7498 * buildbot/status/client.py: drop RemoteReferences at shutdown
7500 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7502 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7503 more debug messages for remote status client
7505 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7506 (.stepFailed): only fire the Deferred once, even if both
7507 stepComplete and stepFailed are called. I think this can happen if
7508 an exception occurs at a weird time.
7510 * buildbot/status/words.py: work-in-progress: IRC status delivery
7512 2003-05-05 Brian Warner <warner@lothar.com>
7514 * docs/examples/twisted_master.py (twisted_app): hush internal
7515 python2.3 distutils deprecation warnings
7516 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7517 add compileOpts= argument which inserts extra args before the
7518 "setup.py build_ext" command. This can be used to give -Wignore
7519 warnings, to hush some internal python-2.3 deprecation messages.
7521 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7522 the ['twisted.test'] default test case to make it easier to change
7525 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7526 * buildbot/clients/gtkPanes.py: ditto
7528 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7529 arg to collapse RunUnitTestsRandomly into RunUnitTests
7530 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7531 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7533 * buildbot/status/html.py (StatusResource): shuffle Resources
7534 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7535 would serve the waterfall display, but the internal links were
7536 only valid on the trailing-slash version. The correct behavior is
7537 for the non-slashed one to serve a Redirect to the slashed one.
7538 This only shows up when the buildbot page is hanging off another
7539 server, like a Twisted-Web distributed server.
7541 * buildbot/status/event.py (Event, RemoteEvent): make Events
7542 pb.Cacheable, with RemoteEvent as the cached version. This removes
7543 a lot of explicit send-an-update code.
7544 * buildbot/status/builder.py (Builder): remove send-update code
7545 * buildbot/status/client.py (ClientBuilder): remove send-update
7546 code, and log errors that occur during callRemote (mostly to catch
7547 InsecureJelly exceptions)
7549 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7550 run Lore with the same python used in the rest of the build
7552 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7554 * buildbot/process/step_twisted.py (HLint): accept 'python'
7555 argument. Catch rc!=0 and mark the step as failed. This marks the
7556 build orange ("has warnings").
7557 (RunUnitTestsJelly): move out to step_twisted2.py
7559 * buildbot/util.py (ignoreStaleRefs): add utility function
7561 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7562 don't fake ETA object, it's too hard to get right
7564 2003-05-02 Brian Warner <warner@lothar.com>
7566 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7568 2003-05-01 Brian Warner <warner@lothar.com>
7570 * buildbot/status/html.py (StatusResource.body): oops, I was
7571 missing a <tr>, causing the waterfall page to be misrendered in
7572 everything except Galeon.
7574 2003-04-29 Brian Warner <warner@lothar.com>
7576 * docs/examples/twisted_master.py: make debuild use python-2.2
7577 explicitly, now that Twisted stopped supporting 2.1
7579 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7580 handle tuple results too. I keep forgetting this, which suggests
7581 it needs to be rethought.
7583 * setup.py (setup): bump version to 0.3.1+ while between releases
7585 2003-04-29 Brian Warner <warner@lothar.com>
7587 * setup.py: Releasing buildbot-0.3.1
7589 2003-04-29 Brian Warner <warner@lothar.com>
7591 * README (SUPPORT): add plea to send questions to the mailing list
7593 * NEWS, MANIFEST.in: add description of recent changes
7595 * docs/examples/twisted_master.py: add the code used to create the
7596 Twisted buildmaster, with passwords and such removed out to a
7599 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7600 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7601 buildmasters to not require CVSToys be installed.
7602 * README, docs/examples/glib_master: update to match the change
7604 * buildbot/clients/base.py, buildbot/bot.py,
7605 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7606 ReconnectingPB from CVSToys distribution to remove CVSToys
7607 dependency for build slaves and status clients. Buildmasters which
7608 use FreshCVSSources still require cvstoys be installed, of course.
7610 2003-04-25 Brian Warner <warner@lothar.com>
7612 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7613 runTestsRandomly arg to turn on trial -z
7615 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7616 experimental code to use trial's machine-parseable output to get
7617 more detailed test results. Still has some major issues.
7618 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7621 * buildbot/status/builder.py (Builder.setCurrentBuild):
7622 anticipating moving build history into statusbag, not used yet
7624 * buildbot/status/tests.py: code to centralize test results,
7625 doesn't work quite yet
7627 * buildbot/status/event.py (Event): use hasattr("setName") instead
7628 of isinstance for now.. need better long-term solution
7630 * buildbot/status/html.py: Remove old imports
7632 2003-04-24 Brian Warner <warner@lothar.com>
7634 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7635 ignore changes under doc/fun/ and sandbox/
7637 * buildbot/process/step_twisted.py: update pushEvent and friends.
7639 * buildbot/status/html.py (Box.td): replace event.buildername with
7640 event.parent.getSwappableName(). Needs more thought.
7642 * buildbot/status/builder.py (Builder): Replace pushEvent and
7643 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7644 Tell events they are being pruned with event.delete().
7646 * buildbot/process/base.py (Build): Remove Builder status-handling
7647 methods. s/pushEvent/setCurrentActivity/.
7649 * buildbot/process/step.py (BuildStep): clean up status delivery.
7650 Gouse builder.statusbag methods instead of intermediate builder
7651 methods. s/updateLastEvent/updateCurrentActivity/.
7652 s/finalizeLastEvent/finishCurrentActivity/. Use
7653 addFileToCurrentActivity for summaryFunction.
7655 * buildbot/status/event.py (Logfile): put data in a Swappable when
7657 (Event): add more setter methods. Remove .buildername, use .parent
7658 and getSwappableName instead (needs more thought).
7660 * buildbot/util.py (Swappable):
7661 * test/test_swap.py: don't bother setting filename at __init__
7662 time, do it later. Change setFilename args to take parent first,
7663 since it provides the most significant part of the filename.
7665 2003-04-23 Brian Warner <warner@lothar.com>
7667 * buildbot/status/event.py (Logfile.addEntry): append to previous
7670 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7671 anticipating Swappable
7672 (InternalShellCommand.remoteUpdate): split out various log-adding
7673 methods so subclasses can snarf stdout separately
7675 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7676 in anticipation of Swappable build logs
7677 (Builder.testsFinished): anticipating TestResults, still disabled
7679 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7682 * buildbot/status/event.py (Logfile): add (disabled) support for
7683 Swappable, not ready for use yet
7685 * buildbot/util.py (Swappable): object which is swapped out to
7686 disk after some period of no use.
7687 * test/test_swap.py: test buildbot.utils.Swappable
7689 2003-04-14 Brian Warner <warner@lothar.com>
7691 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7692 periodic-build timer. Set the .periodicBuildTime on a builder
7693 instance to some number of seconds to activate it.
7695 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7697 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7698 a way that survives result tuples
7700 2003-04-12 Brian Warner <warner@lothar.com>
7702 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7703 return a dict instead of a tuple: allow summarizers to provide
7704 multiple summaries if they want
7705 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7706 (debuildSummarizer): summarize lintian warnings/errors
7708 2003-04-10 Brian Warner <warner@lothar.com>
7710 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7712 2003-04-09 Brian Warner <warner@lothar.com>
7714 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7715 empty summaries: happens when the tests fail so hard they don't emit
7716 a parseable summary line.
7718 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7719 Allow summaryFunction to return None to indicate no summary should
7722 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7723 writing to stale HTTP requests: notice when they disconnect and
7724 remove the request from the list. Also add CacheToFile from
7725 moshez, will be used later.
7727 2003-04-08 Brian Warner <warner@lothar.com>
7729 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7730 should be an int, not a list of strings
7732 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7733 if we weren't actually connected
7735 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7736 to show the tail end of the trial text output
7738 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7739 hook to summarize the results of a ShellCommand
7741 2003-04-07 Brian Warner <warner@lothar.com>
7743 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7744 twisted test suite code into a single class.
7745 * buildbot/process/process_twisted.py: same
7747 2003-04-04 Brian Warner <warner@lothar.com>
7749 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7751 * README (SLAVE): document use of mktap to create slave .tap file
7752 (REQUIREMENTS): describe dependencies
7754 * buildbot/bb_tap.py, buildbot/plugins.tml:
7755 * buildbot/bot.py (updateApplication): Add mktap support for creating
7756 buildslave .tap files
7758 2003-03-28 Brian Warner <warner@lothar.com>
7760 * buildbot/process/step.py (InternalShellCommand.finished): handle
7761 new tuple result values (fix embarrasing bug that appeared during
7764 2003-03-27 Brian Warner <warner@lothar.com>
7766 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7769 2003-03-25 Brian Warner <warner@lothar.com>
7771 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7772 to overall build status
7773 * buildbot/clients/base.py (Builder): improve event printing
7774 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7775 instead of generic ShellCommand
7776 (Build): Add .stopBuild, use it when slave is detached
7778 * buildbot/process/step.py (Configure,Test): give the steps their
7779 own names and status strings
7781 * buildbot/status/html.py (StatusResource): add "show" argument,
7782 lets you limit the set of Builders being displayed.
7784 2003-03-20 Brian Warner <warner@lothar.com>
7786 * buildbot/process/basic.py: removed
7788 2003-03-19 Brian Warner <warner@lothar.com>
7790 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7791 turn off process-docs by default
7793 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7794 when displaying build information without anything in allBuilds[]
7796 * buildbot/bot.py (makeApp): really take password from sys.argv
7798 2003-03-18 Brian Warner <warner@lothar.com>
7800 * buildbot/bot.py (buildApp): take password from sys.argv
7802 * README: replace with more useful text
7804 * setup.py: add a real one
7805 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7807 * docs/PyCon-2003/: added sources for PyCon paper.
7809 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7810 now Build objects control the process and Builder only handles
7811 slave stuff and distribution of changes/status. A new BuildFactory
7812 class creates Build objects on demand.
7814 Created ConfigurableBuild which takes a list of steps to run. This
7815 makes it a lot easier to set up a new kind of build and moves us
7816 closer to being able to configure a build from a web page.
7818 * buildbot/process/step_twisted.py, process_twisted.py: move to
7819 new model. A lot of code went away.
7821 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7822 send lots of empty progress messages to the client.
7824 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7826 2003-02-20 Brian Warner <warner@lothar.com>
7828 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7830 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7831 Twisted bug that prevented non-pty processes from working just got
7832 fixed, and the bug that leaks ptys is still being investigated.
7834 * buildbot/process/step.py (CVS): send timeout arg to slave
7836 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7837 builders coming and going
7838 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7839 from CVSToys, handle lost-buildmaster
7841 * buildbot/status/client.py (StatusClientService.removeBuilder):
7842 Clean up status client protocol: send builders (with references)
7843 as they are created, rather than sending a list and requiring the
7844 client to figure out which ones are new.
7845 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7846 attempts to force a build on an unknown builder
7848 2003-02-19 Brian Warner <warner@lothar.com>
7850 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7851 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7852 Twisted stops leaking them.
7853 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7854 builder goes to an idle state.
7856 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7857 I figure out why CVS commands hang without them, and/or I fix the
7858 hung-command timeout
7860 2003-02-16 Brian Warner <warner@lothar.com>
7862 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7863 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7864 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7865 GenerateDocs now that they are prefixed with WARNING:.
7867 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7868 use manual href target instead of request.childLink
7870 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7871 display every second, but update the ETA every 5 seconds (or
7872 whenever) as remote_progress messages arrive.
7875 2003-02-12 Brian Warner <warner@lothar.com>
7877 * *: import current sources from home CVS repository
7881 # add-log-time-format: add-log-iso8601-time-string