1 2007-08-01 Brian Warner <warner@lothar.com>
3 * buildbot/status/web/index.html: put a link to the waterfall page
4 on the index, otherwise first-time users of WebStatus aren't going
5 to see anything very interesting.
7 * buildbot/interfaces.py (IEventSource): document this interface.
8 Thanks to Dustin Mitchell for the patch. Closes #60.
9 * buildbot/status/builder.py (BuilderStatus): same
10 * buildbot/changes/changes.py (ChangeMaster): same
12 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
13 add a query arg of 'show_events=true' to display non-build events,
14 like slaves attaching/detaching and reconfig events, or
15 'show_events=false' to hide them. The default is 'true'.
16 * docs/buildbot.texinfo (Buildbot Web Resources): document it
18 * web-parts: merge in web-parts branch. Lots of changes. The new
19 functionality is to add buildbot.status.html.WebStatus, which is a
20 superset of the Waterfall that adds new status pages and serves
21 regular files from BASEDIR/public_html/ , which is now the preferred
22 place to put robots.txt, buildbot.css, and index.html .
23 * buildbot/scripts/runner.py: the 'create-master' command now
24 creates public_html/ too, and populates it with a couple of
26 * buildbot/status/web: split waterfall code into smaller pieces
28 2007-07-31 Brian Warner <warner@lothar.com>
30 * buildbot/scripts/startup.py (launch): import twistd.run in a
31 different way to hush pyflakes
32 * buildbot/process/builder.py: remove unused import
34 2007-07-30 Brian Warner <warner@lothar.com>
36 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
37 Mitchell: pass SourceStamps around rather than branch/version/etc
38 tuples. Thanks Dustin! Closes #70.
39 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
40 tuple rather than a list, to avoid surprising mutations
41 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
42 * buildbot/status/mail.py (MailNotifier.buildMessage): same
43 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
44 * buildbot/test/test_status.py (Subscription): same
45 * buildbot/test/test_control.py (Force): same
46 * buildbot/test/test_buildreq.py (Request.testMerge): same
48 2007-07-29 Brian Warner <warner@lothar.com>
50 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
51 variable, since it wasn't used and is confusing in the presence of
52 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
55 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
56 the Buildbot home-page link to point at buildbot.net instead of
57 sourceforge, and add a current-version query parameter so we can
58 get some statistics on which versions are in use out there.
60 2007-07-28 Brian Warner <warner@lothar.com>
62 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
63 with c['change_source'], leaving c['sources'] for backwards
64 compatibility (but deprecated), scheduled for removal in 0.8.0
65 * docs/buildbot.texinfo: same
66 * buildbot/test/test_config.py: verify that c['sources'] still works
67 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
68 * buildbot/scripts/sample.cfg: update to match
70 * buildbot/changes/mail.py (MaildirSource): parse with python's
71 stdlib 'email' module, which has been available since python2.2,
72 and drop use of the 'rfc822' module, which has been depreceated
74 * buildbot/test/test_maildir.py: same: use parse_file() not parse
76 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
77 this needs to match the renaming in test/mail/msg*
79 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
82 * buildbot/test/test_mailparse.py: rename sample emails a bit
83 * buildbot/test/mail/msg*: same
85 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
86 parser for the "commit-email.pl" script that is shipped with SVN,
87 written by Justin Mason. Thanks! Closes SF#1072845.
88 * buildbot/test/mail/svn-commit.*: sample messages
89 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
90 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
92 2007-07-27 Brian Warner <warner@lothar.com>
94 * buildbot/changes/mail.py: refactor: move parsing into a method
95 named 'parse', each parser type gets a separate subclass. Remove
96 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
97 to be a simple leading-substring match. Add a warning to the logs
98 if prefix= does not end in a slash, since that's probably a
99 mistake. Fix both places where a prefix= mismatch would skip all
100 subsequent files in the same email, instead of just skipping the
101 one that didn't match.
102 * buildbot/test/test_mailparse.py: match changes
104 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
105 docs on email-based ChangeSources
107 * docs/buildbot.texinfo (Getting Source Code Changes): move all
108 the changesource types up a level, removing the one-entry menu in
111 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
112 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
113 instances instead of tuples. Closes #63.
114 * buildbot/slave/__init__.py (BuildSlave): define marker class
115 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
116 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
117 * buildbot/test/test_*.py: update tests to match
118 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
119 the c['bots'] backwards-compatibility handler works
121 2007-07-26 Brian Warner <warner@lothar.com>
123 * buildbot/changes/hgbuildbot.py (hook): add an in-process
124 Mercurial change-sending hook, contributed by Frederic Leroy.
125 Thanks! Addresses #50.
126 * docs/buildbot.texinfo (MercurialHook): document it
128 * buildbot/changes/hgbuildbot.py: change the way imports are done,
129 to make it compatible with at least hg-0.9.1 and the current 0.9.4
131 2007-07-17 Brian Warner <warner@lothar.com>
133 * buildbot/process/buildstep.py (BuildStep.getLog): add a
134 convenience method to retrieve a log added with
135 addLog()/addCompleteLog()/etc or logfiles= . I should have added
138 2007-07-03 Brian Warner <warner@lothar.com>
140 * buildbot/slave/commands.py (ShellCommand._startCommand): when
141 logging the environment variables, put one variable on each line,
142 rather than having one really long line with all of them. This
143 should make them a bit more readable and not trigger the
144 horizontal scrollbar (when viewing it in a web browser) quite so
145 much. Thanks to Albert Hofkamp for the patch.
147 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
148 WithProperties instance. Thanks to Axel Hecht for the patch.
150 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
151 * docs/buildbot.texinfo (Build Properties): document it
152 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
153 workdir if it didn't already exist.
155 * docs/buildbot.texinfo (Scheduler Types): correct the description
156 of Dependent schedulers. Thanks to Greg Ward for the patch.
158 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
159 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
160 the patch. Closes #49.
162 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
163 0700 before removing it, to deal with situations where a build will
164 leave files around without write permissions and the 'copy' or
165 'clobber' VC checkout modes need to blow away the tree first.
166 Thanks to Steve Milner for the suggestion and the patch (which I
167 mangled horribly). Closes #29.
168 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
171 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
172 an allowReconnect= argument to let callers control whether they
173 want this don't-let-it-reconnect behavior, since some tests care.
174 Factor out the .continueTrying=False lines from those callers.
175 * buildbot/test/test_slaves.py: same
176 * buildbot/test/test_run.py: same
178 2007-07-02 Brian Warner <warner@lothar.com>
180 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
181 slave has been disappeared, don't let it reconnect. This was
182 causing an intermittent failure in test_slaves.py, when the slave
183 that was supposed to be gone managed to come back by the end of
184 the test and affect the count.
185 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
187 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
188 diagnostic messages to track down this problem
189 (Builder.startBuild): same
191 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
192 the slave randomly rather than always taking the first one. Thanks
193 to Pike for the patch. Closes #36.
194 * buildbot/test/test_slaves.py: match the change. to avoid huge
195 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
196 enables/disables the round-robin-ness (enabled by default), and
197 some unit tests disable it.
198 * docs/buildbot.texinfo (Buildmaster Architecture): document it
200 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
201 argument to 'buildmaster_host', to make it more obvious that this
202 points to the buildmaster. Thanks to Bob Proulx for the
204 * buildbot/scripts/runner.py (slaveTAC): same
205 * buildbot/test/test_runner.py (Create.testSlave): match the change
207 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
210 2007-06-17 Brian Warner <warner@lothar.com>
212 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
213 we can round-trip all of our current step classes by calling
214 getStepFactory() and using the results to make a clone of the
217 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
220 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
221 the config file, we're moving to using actual instances instead of
222 the (class, kwargs) 'step specification' tuples. BuildFactory
223 still keeps a list of tuples internally, but when real instances
224 are passed in to addStep(), they are asked for their class and
225 kwargs using the new BuildStep.getStepFactory method. BuildFactory
226 accepts both instances and the tuple form, and converts instances
227 to the tuple form, but the instance form is preferred because it
228 gives the Steps a chance to do argument validation. Closes: #11.
230 * buildbot/process/buildstep.py (BuildStep.__init__): record the
231 factory information necessary to implement getStepFactory. The
232 addFactoryArguments() method can be used to include arguments that
233 aren't passed to the BuildStep base class constructor.
234 (BuildStep.setBuild):
235 (BuildStep.setDefaultWorkdir): new methods to take parameters that
236 are needed for live BuildSteps but not to construct the specification
237 tuples that are stashed in the factory.
239 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
240 'workdir' into new BuildSteps by using methods instead of
241 arguments. This makes the constructor for BuildSteps a lot
244 * buildbot/steps/*.py: update to match this change. Basically this
245 means adding calls to addFactoryArguments() in the __init__
246 methods to capture the arguments that aren't passed through to the
248 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
249 the new workdir (if any) into the RemoteShellCommands arguments.
250 * buildbot/steps/source.py: allow workdir= to be optional,
251 implement setDefaultWorkdir() since we don't inherit from
252 (CVS): finally remove old clobber=/export=/copydir= arguments,
253 in favor of the mode= argument that's been around forever now.
254 * buildbot/steps/transfer.py: remove build= argument
256 * buildbot/test/*.py: update to match, generally by turning all
257 build= arguments into subsequent calls to s.setBuild()
258 * buildbot/test/test_config.py (Factories): verify that we can
259 use either BuildStep instances or class/kwarg tuples in both
260 BuildFactory.addStep and BuildFactory.__init__
262 * docs/buildbot.texinfo (Build Steps): document the new approach,
263 mention compatibility with the old approach, update all examples
264 to use the new style.
266 2007-06-16 Brian Warner <warner@lothar.com>
268 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
269 the LoopingCall, just eat the failure so that we'll poll again
270 next time. This should allow us to tolerate (e.g.) sf.net SVN
271 failures more gracefully. Many thanks to Dustin Mitchell for the
274 2007-05-17 Brian Warner <warner@lothar.com>
276 * buildbot/status/words.py: refactor the IRC status bot into
277 separate 'Contact' and 'Channel' classes. The base Contact class
278 contains the interaction code: commands and responses. The
279 IRCContact subclass (and IrcStatusBot 'Channel') handle the
280 IRC-specific aspects. The plan is to write other subclasses for
281 other IM protocols like AIM and Jabber.
283 2007-04-16 Brian Warner <warner@lothar.com>
285 * CREDITS: update list of contributors. Thank you all!
287 2007-04-13 Brian Warner <warner@lothar.com>
289 * buildbot/status/mail.py (MailNotifier): add the project name to
290 the subject line and message body, to make it easier to
291 distinguish email coming from different buildmasters. Thanks to
292 Benoit Sigoure for the patch.
293 * buildbot/test/test_status.py (Mail): update to match
295 2007-03-24 Brian Warner <warner@lothar.com>
297 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
298 avoid text-conversion problems between DOS/windows and unix.
299 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
301 2007-03-03 Brian Warner <warner@lothar.com>
303 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
304 warning about the use of Waterfall here
306 2007-03-01 Brian Warner <warner@lothar.com>
308 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
310 2007-02-28 Brian Warner <warner@lothar.com>
312 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
313 Lamb to use a more optimal form of 'p4 changes', to reduce server
314 load. He reports that this optimization was added to p4d release
315 2005.2, but it should work in all versions. Closes #27.
316 * buildbot/test/test_p4poller.py: match it
318 2007-02-27 Brian Warner <warner@lothar.com>
320 * buildbot/status/web/*.py: move all web status stuff into a
321 separate directory, in anticipation of splitting it into smaller
322 pieces and adding more files. html.py was getting way too big.
323 * buildbot/status/classic.css: move it too
324 * setup.py: add the new sub-package
325 * buildbot/test/test_web.py: match the changes
326 * MANIFEST.in: handle the move of classic.css
328 2007-02-07 Brian Warner <warner@lothar.com>
330 * contrib/OS-X/*: add some launchd .plist files for automatically
331 starting a buildmaster or buildslave under OS-X (10.4 or later).
332 Thanks to Mark Pauley for these.
334 2007-02-06 Brian Warner <warner@lothar.com>
336 * docs/buildbot.texinfo (Requirements): update requirements to
337 stop claiming compatibility with python-2.2 or twisted-1.3.x .
339 * README: mention python-2.5 and twisted-2.5 compatibility
341 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
343 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
345 * buildbot/status/builder.py: same, by requiring cStringIO
346 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
347 * buildbot/test/test_vc.py: same
348 * buildbot/test/test_web.py:
349 * buildbot/test/test_steps.py: same, remove unused import
351 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
354 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
355 see any Builders that don't have Schedulers to drive them
357 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
358 attributes this uses went away
360 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
361 dialog, to allow you to reset the buildmaster and force
362 connect/disconnect. Correctly handle losing the buildmaster
363 connection (by switching the display to the hexnut, at which point
364 you can use the 'Connect' menu item to reconnect).
366 * buildbot/steps/source.py (Source.start): if we're using a patch,
367 add it as a LogFile to the checkout/update step. This will turn
368 into a link on the waterfall page.
370 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
371 option, to take the patch from a pre-made file rather than
372 generating it from the local tree. Thanks to Robert Helmer for the
373 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
374 * buildbot/scripts/runner.py (TryOptions): add --diff,
375 --patchlevel, and --baserev options
376 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
377 as None, meaning HEAD.
378 * buildbot/sourcestamp.py (SourceStamp): update docstring to
379 indicate that baserev=None means HEAD
380 * docs/buildbot.texinfo (try --diff): document it
382 * buildbot/test/test_steps.py (BuildStep): remove use of
383 reactor.iterate(), although the technique I replaced it with is a
384 gross polling hack that must be cleaned up properly some day. This
385 was the last use of reactor.iterate in the entire tree, yay.
387 2007-02-05 Brian Warner <warner@lothar.com>
389 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
390 is one of the three known values, otherwise we emit some confusing
391 messages later on. Thanks to Grig Gheorghiu for the catch.
393 2007-01-30 Brian Warner <warner@lothar.com>
395 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
396 Hearsum contributed a patch to let BonsaiPoller work with results
397 that contain non-ascii characters. Closes SF#1632641.
399 2007-01-27 Brian Warner <warner@lothar.com>
401 * Makefile (release): produce both .tar.gz and .zip source bundles.
404 2007-01-23 Brian Warner <warner@lothar.com>
406 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
407 * buildbot/changes/monotone.py: same
409 * buildbot/changes/maildir.py: combine several files into one,
410 clean up maildir.py to use Services properly.
411 * buildbot/changes/maildirtwisted.py: remove
412 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
414 * buildbot/changes/mail.py: match the change
415 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
416 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
418 * buildbot/slave/commands.py (command_version): bump to "2.3" to
419 indicate that the buildslave knows about the 'bzr' command
421 2007-01-22 Brian Warner <warner@lothar.com>
423 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
424 'with', it will become a reserved work in python2.6 .
426 * contrib/bb_applet.py: add a simple gnome-panel applet, to
427 display a terse summary of buildbot status.
428 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
429 some icons, small versions of the Blender object that lives in
430 docs/images/icon.blend
432 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
433 * buildbot/slave/commands.py (Bzr): same
434 * buildbot/scripts/tryclient.py (BzrExtractor): same
435 (SourceStampExtractor.dovc): modify this to allow non-zero exit
436 status, since 'bzr diff' does that
437 * buildbot/test/test_vc.py (Bzr): same
438 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
442 2007-01-20 Brian Warner <warner@lothar.com>
444 * contrib/darcs_buildbot.py: tidy up the progress messages
446 2007-01-17 Brian Warner <warner@lothar.com>
448 * contrib/darcs_buildbot.py: enhance to handle multiple patches
449 being pushed at a time. This keeps state in the repository in a
450 small file named .darcs_buildbot-lastchange, but that shouldn't
451 interfere with normal repository operations. Fixes SF#1534049.
452 * buildbot/clients/sendchange.py (Sender): make a single Sender
453 capable of sending Changes with different usernames.
455 2006-12-11 Brian Warner <warner@lothar.com>
457 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
458 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
459 buildbot.changes.mail a long time ago, but I forgot to add the
460 DeprecationWarning until now.
462 * buildbot/process/maxq.py: remove this, the functionality now
463 lives in buildbot.steps.maxq
465 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
466 * buildbot/clients/gtkPanes.py: remove unused import
468 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
469 that was meant to provide a special Reporter to run inside trial
470 and give the buildslave lots of machine-readable status. We never
471 finished this project.
473 * buildbot/changes/bonsaipoller.py: remove unused imports
474 * buildbot/changes/svnpoller.py: same
475 * buildbot/process/builder.py: same
476 * buildbot/process/buildstep.py: same
477 * buildbot/slave/bot.py: hush pyflakes warning
478 * buildbot/status/tests.py: remove unused imports
479 * buildbot/status/tinderbox.py: same
480 * buildbot/steps/python_twisted.py: same
482 * buildbot/process/step.py: remove this file, these names were
483 deprecated in 0.7.5 and are now being removed.
484 * buildbot/process/step_twisted.py: same
485 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
487 * buildbot/twcompat.py: remove the empty file, yay it is gone
489 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
490 tw-2.0.0 and newer have the method we need.
491 (getProcessOutputAndValue): same
492 (which): remove this method, tw-2.0.0 t.p.procutils has it
494 * buildbot/twcompat.py (implements): remove this method
495 * buildbot/*: import implements() from zope.interface directly
497 * buildbot/status/mail.py: stop falling back to importing
498 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
501 * buildbot/twcompat.py (Interface): remove this import
502 * buildbot/*: import Interface from zope.interface directly
504 * buildbot/twcompat.py (providedBy): remove this method
505 * buildbot/*: turn all uses of providedBy(obj, iface) into
506 iface.providedBy(obj)
508 * buildbot/twcompat.py (maybeWait): remove this method, now that
509 we no longer maintain compatibility with Twisted<=1.3.0 .
510 Twisted-2.0.0 and later allow trial methods to return Deferreds
512 * buildbot/test/*: remove all uses of maybeWait
514 * buildbot/__init__.py (version): bump to 0.7.5+ while between
516 * docs/buildbot.texinfo: same
518 2006-12-10 Brian Warner <warner@lothar.com>
520 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
521 * docs/buildbot.texinfo: set version to match
523 2006-12-10 Brian Warner <warner@lothar.com>
525 * README (REQUIREMENTS): update for release
526 * NEWS: update for release
527 * buildbot/slave/commands.py (command_version): mention that this
528 version (2.2) was released with buildbot-0.7.5
530 * buildbot/test/test_config.py (StartService.testStartService):
531 inhibit the usual read-config-on-startup behavior, since otherwise
532 the log.err that gets recorded causes the test to fail
534 * buildbot/status/builder.py (LogFile.finish): forget about all
535 subscribers once the log has finished, since after that point
536 we're never going to use them again. This might help free up some
539 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
540 than the old/deprecated gtk.mainquit()
542 2006-12-09 Brian Warner <warner@lothar.com>
544 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
545 better when we can't open the masterdst file
547 * buildbot/scripts/startup.py (Follower._failure): add missing
548 import statement for BuildSlaveDetectedError
550 * buildbot/steps/transfer.py (FileUpload): cleanup
551 (FileDownload): same. Add tests for slave version, add mode=.
552 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
553 (SlaveFileDownloadCommand): same
554 * buildbot/test/test_transfer.py: enhance tests
555 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
558 2006-12-08 Brian Warner <warner@lothar.com>
560 * buildbot/scripts/runner.py (sendchange): halt the reactor on
561 both success *and* failure. Without this, the 'buildbot
562 sendchange' command would hang if it could not contact the
563 buildmaster or deliver the Change, which would generally cause the
564 user's commit/record/checkin command to hang too. Thanks to
565 Christian Unger for the catch.
567 2006-12-06 Brian Warner <warner@lothar.com>
569 * NEWS: update with items for the next release
571 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
572 whimsical example pulled from a punch-drunk email I sent out late
574 (Transferring Files): document some of the other parameters
575 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
576 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
577 * buildbot/test/test_svnpoller.py: same
578 * buildbot/changes/svnpoller.py (SVNPoller): same
580 2006-11-26 Brian Warner <warner@lothar.com>
582 * docs/buildbot.texinfo (Build Properties): remind users that
583 WithProperties must appear in a command= list, not as a top-level
585 * buildbot/steps/shell.py (ShellCommand.start): and assert that
586 we're sending a list or a single string to the RemoteShellCommand
588 * buildbot/scheduler.py (Nightly): Improve docs slightly.
590 * buildbot/scripts/startup.py (start): skip the whole
591 watch-the-logfile thing under windows, since it needs os.fork()
593 * buildbot/scripts/runner.py (restart): remove the old message
594 that got printed after the buildbot was restarted.. it most cases
595 it didn't get printed at the right time anyways
597 2006-11-25 Brian Warner <warner@lothar.com>
599 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
600 follow twistd.log and print lines until the process has started
601 started properly. For the buildmaster, this means until the config
602 file has been parsed and accepted. For the buildslave, this means
603 until we've connected to the master. We give up after 5 seconds in
604 any case. Helpful error messages and troubleshooting suggestions
605 are printed when we don't see a successful startup. This closes the
606 remainder of SF#1517975.
607 * buildbot/scripts/startup.py: moved app startup code to here
608 * buildbot/scripts/logwatcher.py: utility class to follow log
609 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
610 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
611 so the LogWatcher can tell the difference between a buildmaster
614 2006-11-24 Brian Warner <warner@lothar.com>
616 * docs/examples/twisted_master.cfg: update to match the version
617 in use on twistedmatrix.com
618 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
619 was using before stopped working, but 'irc.freenode.net' works
622 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
625 * buildbot/clients/base.py (TextClient.not_connected): upon
626 UnauthorizedLogin failures, remind the user to connect to the
627 PBListener port instead of the slaveport.
628 (TextClient.disconnected): shut down more quietly
629 * docs/buildbot.texinfo (statuslog): add another reminder
631 * buildbot/scripts/runner.py (Options.subCommands): rename
632 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
633 'sighup' as an alias.
634 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
635 reconfig command to follow twistd.log and print all of the lines
636 from the start of the config-file reload to its completion. This
637 should make it a lot easier to discover bugs in the config file.
638 Use --quiet to disable this behavior. This addresses half of
639 SF#1517975, the other half will be to add this same utility to
640 'buildbot start' and 'buildbot restart'.
641 * docs/buildbot.texinfo (Loading the Config File): same
644 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
645 method, it has been deprecated for a long time. Use
646 IBuilderControl.requestBuild instead.
647 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
648 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
649 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
650 * buildbot/test/test_control.py (Force.testForce): same
651 * buildbot/test/test_run.py: use requestBuild instead
653 * buildbot/clients/debug.py: replace 'Force Build' button with
654 'Request Build' (which just adds one to the queue), add Ping
655 Builder, add branch/revision fields to Request Build.
656 * buildbot/clients/debug.glade: same
657 * buildbot/master.py: update interface to match. This creates an
658 incompatibility between new debugclients and old buildmasters.
660 * buildbot/process/builder.py (Builder._attached): delay the call
661 to maybeStartBuild for a reactor turn, to avoid starting a build
662 in the middle of a reconfig (say, if the new Builder uses a new
663 slave which is already connected).
665 2006-11-23 Brian Warner <warner@lothar.com>
667 * buildbot/test/test_transfer.py: appease pyflakes
668 * buildbot/test/test_steps.py: same
670 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
671 keeps pyflakes from finding undefined names
673 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
674 Builder no longer induces a disconnect/reconnect cycle. This means
675 that any builds currently in progress will not be interrupted, and
676 any builds which are queued in the Builder will not be lost. This
677 is implemented by having the new Builder extract the state (i.e.
678 all pending Builds and any desired SlaveBuilders) from the old
680 (BotPerspective): refactor. The BotPerspective no longer keeps
681 track of all the Builders that want to use this slave; instead, it
682 asks the BotMaster each time it needs this list. This removes
683 addBuilder and removeBuilder. Clean up attached() to acquire all
684 the slave's information in a more atomic fashion. updateSlave() is
685 now the way to make sure the slave is using the right set of
686 Builders: just call it after everything else has been
688 (BotMaster): refactor, removing addBuilder/removeBuilder and
689 replacing them with an all-at-once setBuilders() call.
691 * buildbot/test/test_slaves.py (Reconfig): new test case to
692 exercise this functionality
693 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
694 * buildbot/slave/commands.py (WaitCommand): same
696 * docs/buildbot.texinfo (Loading the Config File): document the
699 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
700 SlaveBuilder to have its parent Builder changed.
701 (SlaveBuilder.isAvailable): new method to give access to state,
702 which is now a private attribute
703 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
704 the SlaveBuilder about how it is being used. These methods update
705 its internal state. buildFinished() is now the place that invokes
706 maybeStartBuild() on its parent Builder.
707 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
708 new Builder to take over for an old one, transferring state from
710 (Buider): refactor the way that SlaveBuilders are used to match,
711 giving them a bit more autonomy.
712 (Builder.buildFinished): this no longer calls maybeStartBuild():
713 instead the SlaveBuilder calls it on whoever its parent Builder is
714 at the time. This way, when an old Builder is replaced by a new
715 one, and there was a build in progress during the transition, when
716 that build finishes, it will be the new Builder that is told about
717 the newly available slave so it can start a new build.
719 * buildbot/process/base.py (Build.startBuild._release_slave): when
720 the Build finishes, tell the SlaveBuilder that they've been
723 * buildbot/status/builder.py (SlaveStatus): add some new setter
724 methods for use by BotPerspective, to keep some attributes more
727 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
728 called by the buildmaster.
729 (Bot.setBuilderList): instead, we locally announce any leftover
730 directories based upon which Builders we were told about. The
731 master doesn't really care; it's the local admin who may or may not
735 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
736 to allow use of python2.4 or whatever. This tool still requires
739 2006-11-19 Brian Warner <warner@lothar.com>
741 * NEWS (IStatusLog.readlines): more news items
743 2006-11-18 Brian Warner <warner@lothar.com>
745 * NEWS: start collecting items for the next release.
747 2006-11-04 Brian Warner <warner@lothar.com>
749 * buildbot/changes/bonsaipoller.py: apply updates from Ben
750 Hearsum. Closes SF#1590310.
751 * buildbot/test/test_bonsaipoller.py: and tests
753 * buildbot/status/tinderbox.py
754 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
755 status when the build results in WARNINGS. Patch from Dave
756 Liebreich. Closes SF#1587352.
758 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
759 linux-vs-osx behavior difference w.r.t. reading from files that
760 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
761 to Mark Rowe for the patch.
763 2006-10-15 Brian Warner <warner@lothar.com>
765 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
766 method name was misspelled in the interface definition. Thanks to
767 Roy Rapoport for the catch.
769 2006-10-13 Brian Warner <warner@lothar.com>
771 * docs/buildbot.texinfo (Adding LogObservers): update sample code
772 to match the great Steps renaming
774 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
775 Maybe I should run my own unit tests before recording a big
776 change. Good thing I've got a buildbot to remind me.
778 2006-10-12 Brian Warner <warner@lothar.com>
780 * buildbot/steps/transfer.py: rework __init__ and args setup
781 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
783 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
784 when opening the target file, only catch IOError (to report via
785 stderr/rc!=0), let the others be reported as normal exceptions
787 2006-10-08 Brian Warner <warner@lothar.com>
789 * contrib/svn_watcher.py: fix security holes by using proper argv
790 arrays and subprocess.Popen() rather than commands.getoutput().
791 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
792 is deprecated in favor of buildbot/changes/svnpoller.py, and will
793 probably be removed by the next release.
796 2006-10-04 Brian Warner <warner@lothar.com>
798 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
799 initial lines that weren't emitted by pyflakes. When the pyflakes
800 command is run under a Makefile, 'make' will echo the command it
801 runs to stdio, and that was getting logged as a "misc" warning.
802 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
803 * buildbot/test/test_steps.py (testPyFlakes3): another test
805 2006-10-01 Brian Warner <warner@lothar.com>
807 * buildbot/status/html.py (HtmlResource.render): if we get a
808 unicode object from our content() method, encode it into utf-8
809 like we've been claiming to all along. This allows the comments
810 and author names from svnpoller.py to be delivered properly.
812 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
813 de-unicodify filenames before creating the Change, because the
814 rest of buildbot is unlikely to handle them well. Leave the 'who'
815 field as a unicode object.. I don't think there's anything that
816 will break very soon, and it will probably nudge us towards
817 accepting unicode everywhere sooner or later. Stop using the
818 "date" field that comes out of SVN, since it is using the
819 repository's clock (and timezone) and what we care about is the
820 buildmaster's (otherwise Changes from the future show up later
821 than the builds they triggered).
822 * buildbot/test/test_svnpoller.py (Everything.test1): match the
825 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
826 Suvbersion repository polling ChangeSource. I've hacked it up
827 considerably: any bugs are entirely my own fault. Thank you
829 * buildbot/test/test_svnpoller.py: tests for it
830 * docs/buildbot.texinfo (SvnSource): document it
832 2006-09-30 Brian Warner <warner@lothar.com>
834 * buildbot/scheduler.py (Periodic): submit a reason= to the
835 BuildSet to indicate which Scheduler triggered the build. Thanks
836 to Mateusz Loskot for the suggestion.
838 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
840 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
841 changes: set self.loop in __init__, remove unused volatile=
843 * docs/buildbot.texinfo (.buildbot config directory): add more
844 docs on the .buildbot/options keys used by "buildbot try"
845 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
846 (Try.deliverJob): same
848 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
852 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
853 close the filehandle when we stop watching the file. Before, the
854 filehandle was only closed when the LogFileWatcher was
855 garbage-collected, which could be quite a while in the future. If
856 it was still open by the time the next build started, windows will
857 refuse to let the new build delete the old build/ directory. Fixes
858 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
859 #twisted for the catch.
861 2006-09-29 Brian Warner <warner@lothar.com>
863 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
866 2006-09-25 Brian Warner <warner@lothar.com>
868 * setup.py: the new buildbot.steps module wasn't being installed.
869 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
870 (testmsgs): add the extra stuff from buildbot/test/* so you can
871 run unit tests on an installed copy of buildbot, not just from
874 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
875 columns of 'svnlook changed' output contain status information, so
876 strip [:4] instead of [:6]. Depending upon what the status flags
877 were, this would sometimes lead to mangled filenames. Thanks to
878 Riccardo Magliocchetti for the patch. Closes SF#1545146.
880 * buildbot/steps/source.py (Monotone): initial Monotone support,
881 contributed by Nathaniel Smith. Still needs docs and tests, but
882 this code has been in use on the Monotone buildbot for a long
884 * buildbot/slave/commands.py (Monotone): slave-side support
885 * buildbot/changes/monotone.py (MonotoneSource): polling change
888 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
889 contributed a Change Source that polls a Bonsai server (a
890 kind of web-based viewcvs CGI script).
892 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
893 Hearsum contributed a status plugin which sends email in the same
894 format that Tinderbox does: this allows a number of tinderbox
895 tools to be driven by Buildbot instead. Thanks Ben!
897 2006-09-24 Brian Warner <warner@lothar.com>
899 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
900 Thanks to Robert Helmer for the patch.
902 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
903 BuildStatus about the buildslave name at the *beginning* of the
904 build, rather than at the end. Thanks to Alexander Lorenz for the
906 * buildbot/status/html.py (StatusResourceBuild.body): always
907 include the slavename in the build page, not just when the build
909 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
910 slavename in the email message
912 2006-09-21 Brian Warner <warner@lothar.com>
914 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
916 * docs/examples/glib_master.cfg: same
917 * docs/examples/hello.cfg: same
918 * docs/examples/twisted_master.cfg: same, update to current usage
920 2006-09-19 Brian Warner <warner@lothar.com>
922 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
923 (PyFlakes.createSummary): make it compatible with python-2.2
925 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
926 for at least the output-parsing parts of PyFlakes
928 2006-09-18 Brian Warner <warner@lothar.com>
930 * buildbot/steps/python.py: oops, fix import of StringIO
932 2006-09-17 Brian Warner <warner@lothar.com>
934 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
935 turns out that SVN-1.4.0 doesn't fail to update once you've
936 replaced a file with a directory, unlike older versions of SVN and
937 pretty much every other VC tool we support. Since what we really
938 care about is that the update succeeds anyway, stop checking that
939 the tree got clobbered and just assert that the build succeeded.
940 (VCBase.printLogs): add a utility function for debugging
942 * buildbot/process/step.py: oops, added extra imports by mistake
944 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
945 rstrip() on the first line coming out of the 'p4 describe'
946 process, to remove the stray ^M that Wade Brainerd reports seeing
947 in the 'when' field. Fixes SF#1555985.
949 * buildbot/master.py (BuildMaster.loadConfig): improve the error
950 message logged when c['schedulers'] is not right
951 * buildbot/scheduler.py (Scheduler.__init__): improve error
952 message when a Scheduler() is created with the wrong arguments
953 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
954 verify that these error messages are emitted
956 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
957 The idea is that all the base classes (like BuildStep and
958 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
959 will be a leftover backwards-compatibility file that only contains
960 aliases for the steps that were moved out to buildbot.steps.*
961 * lots: change imports to match
962 * buildbot/process/step.py: add a DeprecationWarning if it ever
965 2006-09-12 Brian Warner <warner@lothar.com>
967 * buildbot/scheduler.py (Scheduler.__init__): make sure that
968 builderNames= is actually a sequence, since if you happen to give
969 it a single builder-specification dictionary instead, it won't get
970 caught by the existing assert. Thanks to Brett Neely for the
973 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
975 * docs/buildbot.texinfo (Python BuildSteps): document them
976 (sendchange): include a link to PBChangeSource, since you need one
978 * buildbot/steps/shell.py: clean up test-case-name line, remove some
980 * buildbot/steps/dummy.py: same
982 2006-09-08 Brian Warner <warner@lothar.com>
984 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
985 BuildStep which lets you transfer files from the master to the
986 slave or vice versa. Thanks to Albert Hofkamp for the original
987 patch. Fixes SF#1504631.
988 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
990 (SlaveFileDownloadCommand): same
991 * docs/buildbot.texinfo (Transferring Files): document it
992 * buildbot/test/test_transfer.py: test it
993 * buildbot/test/runutils.py (StepTester): new utility class for
994 testing BuildSteps and RemoteCommands without Builds or Bots or PB
995 * buildbot/test/test_steps.py (CheckStepTester): validate that the
998 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
999 walk through StatusLogs one line at a time, mostly for the benefit
1000 of ShellCommand.createSummary methods. You can either walk through
1001 STDOUT or STDERR, but the default is STDOUT.
1003 * buildbot/status/builder.py (LogFile.readlines): implement it.
1004 Note that this is not yet memory-efficient, it just pulls the
1005 whole file into RAM and then splits it up with a StringIO.
1006 Eventually this should be a generator that only pulls chunks from
1008 * buildbot/test/test_status.py (Log.testReadlines): test it
1010 * docs/buildbot.texinfo: update to match changes
1011 * buildbot/process/factory.py: stop using old definitions
1012 * buildbot/process/process_twisted.py: same
1013 * buildbot/test/test_*.py: same
1015 * buildbot/process/step_twisted.py: move definition to..
1016 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1017 relative-import mechanisms prevent this from being named 'twisted'
1018 or 'python/twisted' as I would have preferred.
1020 * buildbot/process/maxq.py: move definition to..
1021 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1023 * buildbot/process/step.py: split the user-visible BuildSteps into
1024 separate files, all under buildbot/steps/
1025 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1026 * buildbot/steps/shell.py: this holds ShellCommand and friends
1027 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1029 2006-09-05 Brian Warner <warner@lothar.com>
1031 * lots: run pyflakes, removed a lot of unused imports, changed the
1032 form of some conditional imports to remove false pyflakes
1033 warnings. There are still a number of warnings left, mostly from
1034 imports that are done for their side-effects.
1035 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1038 2006-08-26 Brian Warner <warner@lothar.com>
1040 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1041 compatible with twisted-1.3.0, for some reason I just can't seem
1042 to let go of the past.
1044 2006-08-25 Brian Warner <warner@lothar.com>
1046 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1048 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1049 all logfiles= in startCommand(), rather than in start() . This
1050 makes it easier to have the 'stdio' log come before any secondary
1051 logfiles, which I feel makes the waterfall display more
1053 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1054 from ShellCommand up into LoggingBuildStep
1055 (LoggingBuildStep.__init__): move the handling of logfiles= from
1056 ShellCommand up to LoggingBuildStep, because startCommand is
1057 provided by LoggingBuildStep, whereas start() was specific to
1058 subclasses like ShellCommand and Source. This removes code
1059 duplication in those subclasses.
1060 (ShellCommand.__init__): same
1061 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1062 for a slave that's too old to understand logfiles= into a separate
1063 method, so it can live in ShellCommand. The rest of
1064 setupLogfiles() can live in LoggingBuildStep.
1066 2006-08-24 Brian Warner <warner@lothar.com>
1068 * buildbot/locks.py (BaseLock): you can now configure Locks to
1069 allow multiple simultaneous owners. They still default to
1070 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1072 * docs/buildbot.texinfo (Interlocks): document the new options
1073 * buildbot/test/test_locks.py: add a bunch of new unit tests
1074 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1075 waitUntilMaybeAvailable, not waitUntilAvailable
1076 * buildbot/process/step.py (BuildStep.acquireLocks): same
1077 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1078 the whole lockid in their constructor, not just the name. Also,
1079 keep track of which real locks we've handed out by the full
1080 lockid, not just class+name, otherwise changing just the maxCount=
1081 in the master.cfg file would not actually cause a behavioral
1084 2006-08-23 Brian Warner <warner@lothar.com>
1086 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1088 * docs/buildbot.texinfo: same
1090 2006-08-23 Brian Warner <warner@lothar.com>
1092 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1093 * docs/buildbot.texinfo: set version to match
1094 * NEWS: update for 0.7.4
1095 * buildbot/slave/commands.py (command_version): mention that this
1096 version (2.1) was released with buildbot-0.7.4
1098 2006-08-22 Brian Warner <warner@lothar.com>
1102 * CREDITS: new file, list of people who have helped. Thanks!
1103 * MANIFEST.in: ship it
1105 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1106 new diagrams, the user's manual is more informative than it was.
1107 Start shipping the .html user's manual (and generated .png
1109 * Makefile: update 'release' target to match
1111 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1112 test.. I think the web-parts effort will render it pointless well
1113 before it ever actually starts to work.
1115 2006-08-20 Brian Warner <warner@lothar.com>
1117 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1118 meaning of the prefix= argument. It is now just a string which is
1119 stripped from the beginning of the filename. If prefix= is set but
1120 not found on any given filename, that filename is ignored. If all
1121 filenames in a Change are ignored, the Change is dropped. This is
1122 much simpler than the previous sep= nonsense, and I should have
1123 implemented it this way from the beginning. Effectively resolves
1124 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1125 Gedminas for the catch and suggested fixes.
1126 (ChangePerspective.perspective_addChange): implement the actual
1128 * buildbot/test/test_changes.py (TestChangePerspective): test it
1129 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1130 how to properly use prefix=
1131 * docs/examples/twisted_master.cfg (source): update prefix= by
1132 adding the trailing slash
1135 * docs/examples/twisted_master.cfg: update to actual practice
1137 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1138 update test case to match new link text.. the HREF has both a
1139 class= setting and an enclosing [] pair that I didn't match in the
1142 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1143 list of strings is preferred over a single string with embedded
1145 (ShellCommand.description=): explain that either single strings or
1146 a list of strings is acceptable, and why you might prefer one over
1147 the other. Add an example. Fixes SF#1524659, thanks to Paul
1148 Winkler for the catch.
1149 (Build Steps): update to use f.addStep() rather than using s()
1150 and the constructor list
1152 * buildbot/process/step.py (ShellCommand): accept either a single
1153 string or a list of strings in both description= and
1155 * buildbot/test/test_steps.py (Steps.test_description): test it
1156 * buildbot/test/runutils.py (makeBuildStep): support for that test
1158 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1159 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1160 collecting the files and creating the patch.
1162 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1163 per-step URLs that will be displayed on the waterfall display,
1164 for things like the HTML output of code-coverage tools, when
1165 the results are hosted elsewhere.
1166 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1167 way to retrieve these URLs
1168 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1169 the method to retrieve these URLs. Also provide backwards
1170 compatibility for saved BuildStepStatus instances that didn't have
1172 * buildbot/process/step.py (BuildStep.addURL): method to set these
1173 URLs from within a BuildStep
1174 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1175 (StepBox.getBox): give these external links a distinct CSS class
1176 named "BuildStep external" so a .css file can display them
1179 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1181 * buildbot/test/test_steps.py (Steps): test that we can all the
1182 URLs. Also add a bunch of other tests on methods that can be
1183 called from within BuildSteps
1184 * buildbot/test/runutils.py (makeBuildStep): add utility function
1186 2006-08-13 Brian Warner <warner@lothar.com>
1188 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1190 2006-08-10 Brian Warner <warner@lothar.com>
1192 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1193 index, this one of things like c['sources'] and c['schedulers']
1194 (indices): it looks like my clever idea of putting the @fooindex
1195 commands in between the @node and the @subsection (to make the
1196 HREF anchor jump to slightly above the section title, which works
1197 much better in html) confused texinfo horribly, so I'm moving the
1198 index tags back to be just after the @subsection marker. I also
1199 added extra lines between the @node/@section paragraph and the
1200 index tags, since I think maybe texinfo wants to see these be
1201 separate paragraphs.
1203 * docs/Makefile (images): make sure images get built when
1204 rendering the manual
1205 * docs/images/Makefile: same
1207 * buildbot/scripts/runner.py: rename 'buildbot master' to
1208 'buildbot create-master', and 'buildbot slave' to 'buildbot
1210 * docs/buildbot.texinfo: same
1213 * docs/buildbot.texinfo: reimplement the "useful classes" index
1214 with actual texinfo indices. The .info rendering is a bit
1215 weird-looking but it works well, and the HTML rendering is quite
1216 nice. This also puts the index targets in the regular flow of the
1217 text, which is easier to maintain.
1219 2006-08-06 Brian Warner <warner@lothar.com>
1221 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1222 Kevin Turner to prefer the environ= argument be a list rather than
1223 a string. If it is a list, it will be joined with a platform-local
1224 os.pathsep delimiter, and then prepended to any existing
1225 $PYTHONPATH value. This works better in cross-platform (i.e.
1226 windows buildslaves) environments when you need to push multiple
1227 directories onto the front of the path.
1228 (SlaveShellCommand): documented the new magic
1229 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1230 in a user-visible form
1232 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1233 Turner to prefer lists over strings when creating/running VC
1234 commands during unit tests. This is clearly necessary to survive
1235 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1236 renamed the wq() function to qw() though, since that's how it's
1237 spelled in perl. Eventually I'd prefer all commands to be
1238 specified with lists.
1240 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1241 which are deleted (or not yet created) correctly. Also add
1242 failsafe code to not explode if the file-watching poller doesn't
1243 get started. Thanks to JP Calderone for the catch and the poller
1245 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1247 * buildbot/test/emitlogs.py: same
1249 * NEWS: summarize recent changes
1251 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1252 clause to avoid the "host key mismatch" warning
1254 * buildbot/process/step_twisted.py (Trial.start): if the
1255 buildslave is too old to understand logfiles=, fall back to
1256 running 'cat _trial_temp/test.log' like before.
1257 (Trial.commandComplete): same. this takes advantage of the
1258 LoggingBuildStep refactoring to stall commandComplete long enough
1259 to run a second RemoteShellCommand.
1261 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1262 refactor command-completion handling, to allow methods like
1263 commandComplete/createSummary/evaluateCommand to return Deferreds.
1264 (LoggingBuildStep._commandComplete): delete the refactored method
1265 (ShellCommand.setupLogfiles): if the buildslave is too old to
1266 understand logfiles=, put a warning message both into twistd.log
1267 and into the otherwise empty user-visible LogFiles.
1269 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1270 callers to provide the slave-side logfile name, rather than
1271 forcing it to come from the local name of the LogFile.
1272 (BuildStep.getSlaveName): new method
1274 * buildbot/process/base.py (Build.getSlaveName): new method, so
1275 steps can find out which buildslave they're running on
1277 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1278 to match the s/cvs_ver/command_version/ change
1280 2006-08-05 Brian Warner <warner@lothar.com>
1282 * buildbot/slave/commands.py (command_version): replace the CVS
1283 auto-updated cvs_ver keyword with a manually-updated variable,
1284 since CVS is no longer the master repository. Add a description of
1285 the remote API change starting in this version (2.1), specifically
1286 the fact that SlaveShellCommand now accepts 'initial_stdin',
1287 'keep_stdin_open', and 'logfiles'.
1289 2006-07-31 Brian Warner <warner@lothar.com>
1291 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1292 diagrams to describe how the whole system fits together. The
1293 images themselves are kept in SVG files, with ascii-art versions
1294 in corresponding .txt files. Texinfo knows how to interpolate the
1295 text version into .info files, reference the .png versions from
1296 .html files, and include .eps versions in the .ps format.
1297 * docs/images/Makefile: tools to create .png and .eps
1298 * docs/images/*.svg: created pictures with Inkscape.
1299 * .darcs-boring: ignore the generated .eps and .png files
1301 2006-07-24 Brian Warner <warner@lothar.com>
1303 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1304 Scheduler names, since they cause setServiceParent to explode
1306 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1308 2006-07-20 Brian Warner <warner@lothar.com>
1310 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1311 which runs the buildbot unit tests
1313 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1314 classes that are useful in master.cfg
1316 2006-07-15 Brian Warner <warner@lothar.com>
1318 * Makefile (some-apidocs): new target to build only some epydocs
1320 * setup.py: minor comment.. does the classifiers= argument prevent
1321 the setup.py script from working on python2.2/2.3?
1323 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1326 * buildbot/twcompat.py: fix minor typo in comments
1328 * buildbot/manhole.py: move all Manhole-related code out to this
1329 module. Implement SSH-based manholes (with TwistedConch), and move
1330 to conch's nifty line-editing syntax-coloring REPL shell instead
1331 of the boring non-editing monochromatic (and deprecated) old
1333 * buildbot/master.py: remove all Manhole-related code
1334 (BuildMaster.loadConfig._add): make sure the old manhole is
1335 removed before we add the new one
1336 * docs/buildbot.texinfo (Debug options): document new Manhole options
1338 * buildbot/twcompat.py (_which): fix some epydoc issues
1339 * buildbot/status/html.py (Waterfall.__init__): same
1341 2006-06-29 Brian Warner <warner@lothar.com>
1343 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1344 deprecation warnings under newer Twisteds (by using
1345 zope.interface.Interface instead of old twisted.python.components
1347 * buildbot/slave/interfaces.py: same
1349 2006-06-28 Brian Warner <warner@lothar.com>
1351 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1352 svn commands, so it will fail immediately instead of hanging while
1353 it waits for a username/password to be typed in.
1355 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1356 log message if the step was shut down
1358 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1359 obsolete reference to mktap.
1361 2006-06-20 Brian Warner <warner@lothar.com>
1363 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1364 test to include new 'logfiles' argument sent from master to slave
1366 2006-06-19 Brian Warner <warner@lothar.com>
1368 * buildbot/process/step_twisted.py (Trial): track Progress from
1369 _trial_temp/test.log too
1371 * buildbot/process/step.py (OutputProgressObserver): generalize
1372 the earlier StdioProgressObserver into an OutputProgressObserver
1373 that can track LogFiles other than stdio.
1374 (LoggingBuildStep.__init__): same
1376 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1377 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1378 will fail under windows because of os.sep issues. It might have
1379 worked before if 'cat' was doing cygwin path conversion.
1381 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1382 creation of LogFileWatchers
1383 (ShellCommand._startCommand): and record the files that were
1384 watched in the 'headers' section of the ShellCommand output
1386 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1387 need to actually pass it to the slave if you want it to work.
1388 (ShellCommand): document it a bit
1390 * buildbot/test/test_shell.py: new test to validate LogFiles
1391 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1393 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1394 before printing the last batch of lines, to test that the polling
1395 logic is working properly
1397 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1398 handling, making it possible to track multiple logs for a single
1399 RemoteCommand. The previous single logfile is now known as the
1401 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1402 (RemoteShellCommand.__init__): accept logfiles=
1403 (LoggingBuildStep.startCommand): stdio_log is now one of many
1404 (ShellCommand): added logfiles= argument, as well as a class-level
1405 .logfiles attribute, which will be merged together to figure out
1406 which logfiles should be tracked. The latter maybe be useful for
1407 subclasses of ShellCommand which know they will aways produce
1408 secondary logfiles in the same location.
1410 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1411 and closeStdin() methods, preparing to make it possible to write
1412 to a ShellCommand's stdin at any time, not just at startup. These
1413 writes are buffered if the child process hasn't started yet.
1414 (LogFileWatcher): new helper class to watch arbitrary logfiles
1415 while a ShellCommand runs. This class polls the file every two
1416 seconds, and sends back 10k chunks to the buildmaster.
1417 (ShellCommand): rename stdin= to initialStdin=, and add
1418 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1420 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1421 key of "log" and a value of (logname, data).
1422 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1423 'logfiles' to the master-visible args dictionary.
1424 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1427 * buildbot/test/test_vc.py (Patch.testPatch): same
1430 * buildbot/test/emit.py: write to a logfile in the current
1431 directory. We use this to figure out what was used as a basedir
1432 rather than looking to see which copy of emit.py gets run, so that
1433 we can run the commands from inside _trial_temp rather than inside
1435 * buildbot/test/subdir/emit.py: same
1436 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1437 argument rather than running from buildbot/test/
1438 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1439 rather than using an implicit setUp()
1440 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1441 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1442 of assuming that we're running in buildbot/test/ (and that '.' is
1445 * buildbot/slave/commands.py (Command.doStart): refactor Command
1446 startup/completion a bit: now the SlaveBuilder calls doStart(),
1447 which is not meant for overridding by subclasses, and doStart()
1448 calls start(), which is. Likewise the SlaveBuilder calls
1449 doInterrupt(), and subclasses override interrupt(). This also puts
1450 responsibility for maintaining .running in Command rather than in
1452 (Command.doInterrupt): same
1453 (Command.commandComplete): same, this is called when the deferred
1454 returned by start() completes.
1455 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1456 (SlaveBuilder.remote_interruptCommand): same
1457 (SlaveBuilder.stopCommand): same
1459 2006-06-16 Brian Warner <warner@lothar.com>
1461 * buildbot/test/test_shell.py: new test file to contain everything
1462 relating to ShellCommand
1463 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1464 multiple logfiles in realtime" feature, not yet implemented
1465 * buildbot/test/emitlogs.py: support file for testLogFiles
1466 * docs/buildbot.texinfo (ShellCommand): document the feature
1468 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1470 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1471 for tests which exercise SlaveCommands in isolation.
1473 * buildbot/test/test_slavecommand.py: Move some utilities like
1474 SignalMixin and FakeSlaveBuilder from here ..
1475 * buildbot/test/runutils.py: .. to here, so they can be used by
1476 other test classes too
1477 * buildbot/test/test_vc.py: more SignalMixin refactoring
1478 * buildbot/test/test_control.py: same
1479 * buildbot/test/test_run.py: and some rmtree refactoring
1481 2006-06-15 Brian Warner <warner@lothar.com>
1483 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1484 'testBranch' to match other VC tests and have the tests run in
1485 roughly increasing order of dependency
1487 * buildbot/test/test_steps.py (LogObserver): new test to verify
1488 LogObservers can be created at various times and still get
1489 connected up properly
1491 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1492 to create BuildStepStatus instances that actually work.
1494 * buildbot/process/step.py (LogObserver): add outReceived and
1495 errReceived base methods, to be overridden
1497 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1498 API to take a name instead of a step, reducing the coupling
1499 somewhat. This returns the BuildStepStatus object so it can be
1500 passed to the new Step, instead of jamming it directly into the
1502 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1504 * buildbot/process/base.py (Build.setupBuild): use both methods
1505 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1506 process a bit to match
1508 2006-06-14 Brian Warner <warner@lothar.com>
1510 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1511 docs on writing new LogObserver classes
1512 (Writing New Status Plugins): brief docs on how Status Plugins fit
1515 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1516 implement a LogObserver that counts how many unit tests have been
1518 (Trial.__init__): wire it in
1519 * buildbot/test/test_twisted.py (Counter): unit test for it
1521 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1522 to new cmd.logs['stdio'] scheme
1523 (Trial.commandComplete): same
1524 (BuildDebs.commandComplete): same
1526 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1527 LogFiles, instead of just a single one. The old single logfile is
1528 now called "stdio". LoggedRemoteCommand no longer creates a
1529 LogFile for you (the code to do that was broken anyway). If you
1530 don't create a "stdio" LogFile, then stdout/stderr will be
1532 (LogObserver): implement "LogObservers", which a BuildStep can add
1533 to parse the output of a command in real-time. The primary use is
1534 to provide more useful information to the Progress code, allowing
1535 better ETA estimates.
1536 (LogLineObserver): utility subclass which feeds complete lines to
1537 the parser instead of bytes.
1538 (BuildStep.progressMetrics): this is safer as a tuple
1539 (BuildStep.setProgress): utility method, meant to be called by
1541 (BuildStep.addLogObserver): new method, to be called at any time
1542 during the BuildStep (even before any LogFiles have been created),
1543 to attach (or schedule for eventual attachment) a LogObserver to a
1545 (StdioProgressObserver): new LogObserver which replaces the old
1546 "output" progress gatherer
1547 (LoggingBuildStep.__init__): same
1548 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1549 (LoggingBuildStep._commandComplete): must use logs['stdio']
1550 instead of the old single ".log" attribute.
1551 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1552 functionality, now subsumed into StdioProgressObserver
1553 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1554 log name changed from "output" to "stdio".
1557 * buildbot/interfaces.py (ILogFile): add the Interface used from
1558 the BuildStep towards the LogFile
1559 (ILogObserver): and the one provided by a LogObserver
1560 * buildbot/status/builder.py (LogFile): implement it
1562 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1563 HEADER constants here ..
1564 * buildbot/status/builder.py (STDOUT): .. from here
1566 2006-06-13 Brian Warner <warner@lothar.com>
1568 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1569 compatibility with python2.2, which doesn't have the 'substr in
1571 (TestP4Poller.makeTime): utility function to construct the
1572 timestamp using the same strptime() approach as p4poller does. It
1573 turns out that time.mktime() behaves slightly differently under
1574 python2.2, probably something to do with the DST flag, and that
1575 causes the test to fail under python2.2. (changing the mktime()
1576 arguments to have dst=0 instead of -1 caused it to fail under
1577 python2.3. Go figure.)
1578 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1580 2006-06-12 Brian Warner <warner@lothar.com>
1582 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1583 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1584 contributing such an excellent patch, including docs and unit
1585 tests! This makes it *so* much easier to apply. I had to update
1586 test_vc.py to handle some recent refactorings, but everything else
1587 applied smoothly. The only remaining thing I'd like to fix would
1588 be to remove the hard-wired port 1666 used by p4d, and allow it to
1589 claim any unused port. This would allow two copies of the test
1590 suite to run on the same host at the same time, as well as
1591 allowing the test suite to run while a real (production) p4d was
1592 running on the same host. Oh, and maybe we should add a warning to
1593 step.P4 that gets emitted if the slave is too old to provide the
1594 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1595 * buildbot/slave/commands.py (P4): same
1596 (P4Sync): same, some minor updates
1597 * buildbot/changes/p4poller.py: same
1598 * docs/buildbot.texinfo: same
1599 * buildbot/test/test_p4poller.py: same
1600 * buildbot/test/test_vc.py (P4): same
1602 * setup.py: add Trove classifiers for PyPI
1604 2006-06-08 Brian Warner <warner@allmydata.com>
1606 * buildbot/status/client.py
1607 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1608 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1609 build needs to be IRemote'd separately, rather than IRemote'ing
1610 the whole list at once. I can't wait until newpb's serialization
1611 adapters make this unnecessary.
1613 2006-06-06 Brian Warner <warner@lothar.com>
1615 * buildbot/process/step.py (WithProperties): make this inherit
1616 from ComparableMixin, so that reloading an unchanged config file
1617 doesn't cause us to spuriously reload any Builders which use them.
1618 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1621 2006-06-03 Brian Warner <warner@lothar.com>
1623 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1624 running py2exe on windows, contributed by Mark Hammond. Addresses
1625 SF#1401121, but I think we still need to include
1626 buildbot/scripts/sample.cfg
1627 * setup.py: include buildbot_service.py as a script under windows
1628 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1629 a py2exe application), get the icon/css datafiles from a different
1632 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1633 double-escape the build URL. Thanks to Olivier Bonnet for the
1634 patch. Fixes SF#1452801.
1636 2006-06-02 Brian Warner <warner@lothar.com>
1638 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1639 first six columns of 'svnlook' output, not just the first column,
1640 since property changes appear in the other five. Thanks to Olivier
1641 Bonnet for the patch. Fixes SF#1398174.
1643 2006-06-01 Brian Warner <warner@lothar.com>
1645 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1646 the fake build, so that title= has something to be set to
1648 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1649 attribute of the "Build #NN" link in the yellow start-the-build
1650 box to the build's reason. This means that you get a little
1651 tooltip explaining why the build was done when you hover over the
1652 yellow box. Thanks to Zandr Milewski for the suggestion.
1654 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1655 (Box.setETA): handle ETA=None (by stopping the timer)
1656 (Box.update): make the [soon] text less different than the usual
1657 text, so the rest of the text doesn't flop around so much. It
1658 would be awfully nice to figure out how to center this stuff.
1659 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1661 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1662 by default, so that any ShellCommand which fails marks the overall
1663 build as a failure. I should have done this from the beginning.
1664 Add flunkOnFailure=False to the arguments if you want to turn off
1667 2006-05-30 Brian Warner <warner@lothar.com>
1669 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1670 last-build/current-build/current-step. Show what step is currently
1671 running. Show ETA for both the overall build and the current step.
1672 Update GTK calls to modern non-deprecated forms. There's still a
1673 lot of dead code and debug noise to remove.
1675 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1676 shows up properly in status displays
1678 2006-05-28 Brian Warner <warner@lothar.com>
1680 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1681 build we use to verify that WithProperties works:
1683 ** set flunkOnFailure=True so that build failures get noticed
1684 ** set workdir='.' so that the build succeeds, otherwise it is trying
1685 to touch 'build/something', and 'build/' doesn't exist because
1686 usually that's created by a Source step
1687 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1688 this test somehow triggers, in which the 'touch' process becomes
1689 a zombie and we wait for th etimeout before giving up on it.
1691 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1692 to log the Build results and step logs to the twisted log.
1693 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1694 what went wrong if a build was expected to succeed but didn't.
1696 * buildbot/process/step_twisted.py (Trial): set the default
1697 trialMode to '--reporter=bwverbose', which specifies verbose
1698 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1699 '-to', but those are completely missing in modern Twisteds.
1701 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1702 a localhost-only port, to encourage better security
1704 * docs/buildbot.texinfo (Change Sources): mention
1707 * .darcs-boring: add a Darcs boringfile
1709 * README (REQUIREMENTS): stop claiming compatibility with
1712 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1715 2006-05-27 Brian Warner <warner@lothar.com>
1717 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1718 * docs/buildbot.texinfo: same
1720 2006-05-23 Brian Warner <warner@lothar.com>
1722 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1723 * docs/buildbot.texinfo: set version to match
1724 * NEWS: update for 0.7.3
1726 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1727 give a quick mapping from VC system to possible ChangeSources
1728 (Build Properties): add 'buildername'
1730 * buildbot/process/base.py (Build.setupStatus): oops, set
1731 'buildername' and 'buildnumber' properties
1732 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1735 2006-05-22 Brian Warner <warner@lothar.com>
1737 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1738 property interpolation better
1740 * README (INSTALLATION): remove old '-v' argument from recommended
1743 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1744 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1747 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1748 'svnversion' instead of grepping the output of 'svn info', much
1749 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1750 Bonnet for the suggestion.
1751 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1752 require the WC_PATH argument, so run 'svnversion .' instead.
1754 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1755 aren't supposed to have 'self' in their argument list
1757 2006-05-21 Brian Warner <warner@lothar.com>
1759 * buildbot/process/step.py (ShellCommand.start): make
1760 testInterpolate pass. I was passing the uninterpolated command to
1761 the RemoteShellCommand constructor
1762 (ShellCommand._interpolateProperties): oops, handle non-list
1763 commands (i.e. strings with multiple words separated by spaces in
1764 them) properly, instead of forgetting about them.
1766 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1767 to actually try to use build properties in a real build. This test
1769 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1770 to start and evaluate builds
1772 * buildbot/test/test__versions.py: add a pseudo-test to record
1773 what version of Twisted/Python/Buildbot are running. This should
1774 show up at the beginning of _trial_tmp/test.log, and exists to help
1775 debug other problems.
1777 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1778 a filename to be served as 'robots.txt' to discourage web spiders.
1779 Adapted from a patch by Tobi Vollebregt, thanks!
1780 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1781 (Waterfall.test_waterfall): tweak the way that filenames are put
1782 into the config file, to accomodate windows pathnames better.
1784 * docs/buildbot.texinfo (HTML Waterfall): document it
1786 * buildbot/process/process_twisted.py
1787 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1788 changed the build process. The new setup.py no longer takes the
1790 (FullTwistedBuildFactory.__init__): same
1791 (TwistedReactorsBuildFactory.__init__): same
1793 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1794 be placed in the [hooks] section of the central repository (the
1795 one that everybody pushes changes to).
1797 2006-05-20 Brian Warner <warner@lothar.com>
1799 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1800 .darcs-context file, use binary mode. I think this was causing a
1801 Darcs failure under windows.
1803 2006-05-19 Brian Warner <warner@lothar.com>
1805 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1806 use a timezone string of +0000 and gmtime, since this timestamp is
1807 sent to a buildmaster and %z is broken.
1809 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1810 string and localtime, since this timestamp will only be consumed
1811 locally, and %z is broken.
1813 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1814 gmtime, since this timestamp is returned to the buildmaster, and
1817 2006-05-18 Brian Warner <warner@lothar.com>
1819 * NEWS: update in preparation for next release
1821 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1822 setup-repository and do-we-have-the-vc-tools code into a separate
1823 "helper" class, which sticks around in a single module-level
1824 object. This seems more likely to continue to work in the future
1825 than having it hide in the TestCase and hope that TestCases stick
1826 around for a long time.
1828 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1829 addremove' has been deprecated in recent versions of mercurial, so
1830 use 'hg add' instead
1832 2006-05-07 Brian Warner <warner@lothar.com>
1834 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1835 operating under windows, move the file before opening it, since
1836 you can't rename a file that somebody has open.
1838 * buildbot/process/base.py (Build.setupBuild): if something goes
1839 wrong while creating a Step, log the name and arguments, since the
1840 error message when you get the number of arguments wrong is really
1843 2006-05-06 Brian Warner <warner@lothar.com>
1845 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1846 bugs in twisted-specific code not covered by my unit tests, this
1847 time use 'cmd' argument instead of self.cmd
1849 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1850 fix stupid braino: either use startwith or find()==0, not both.
1851 (TwistedReactorsBuildFactory.__init__): another dumb typo
1853 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1854 mark this test as TODO under windows, since process-killing seems
1855 dodgy there. We'll come back to this later and try to fix it
1858 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1859 and don't include a timezone
1860 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1861 This should avoid the windows-with-verbose-timezone-name problem
1863 (Patch.testPatch): add a test which runs 'patch' with less
1864 overhead than the full VCBase.do_patch sequence, to try to isolate
1865 a windows test failure. This one uses slave.commands.ShellCommand
1866 and 'patch', but none of the VC code.
1868 * buildbot/slave/commands.py (getCommand): use which() to find the
1869 executables for 'cvs', 'svn', etc. This ought to help under
1872 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1873 working directory before starting. If an earlier test failed, the
1874 leftover directory would mistakenly flunk a later test.
1875 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1876 Make sure that we use the right commandlines if which("tla") picks
1877 up "tla.exe" (as it does under windows).
1878 (TlaSupport.do_get): factor out this tla-vs-baz difference
1879 (TlaSupport.vc_create): more tla-vs-baz differences
1881 * buildbot/test/test_slavecommand.py
1882 (ShellBase.testShellMissingCommand): stop trying to assert
1883 anything about the error message: different shells on different
1884 OSes with different languages makes it hard, and it really isn't
1885 that interesting of a thing to test anyway.
1887 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1888 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1889 "Panther"), because it has a bug which flunks a couple tests in
1890 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1891 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1892 able to test that yet.
1894 2006-04-30 Brian Warner <warner@lothar.com>
1896 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1897 make sure child commands emit messages in english, so our regexps
1898 will match. Thanks to Nikaus Giger for identifying the problems.
1899 (VCBase._do_vctest_export_1): mode="export" is not responsible
1900 for setting the "got_revision" property, since in many cases it is
1901 not convenient to determine.
1902 (SVNSupport.capable): when running 'svn --version' to check for
1903 ra_local, we want error messages in english
1904 * buildbot/test/test_slavecommand.py
1905 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1906 to emit the error message in english
1908 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1909 the environment with $LC_ALL="C" so that Commands which need to
1910 parse the output of their child processes can obtain it in
1912 (SVN.parseGotRevision): call "svn info" afterwards instead of
1913 watching the output of the "svn update" or "svn checkout".
1914 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1915 (Arch.parseGotRevision): same
1916 (Bazaar.parseGotRevision): same
1917 (Mercurial.parseGotRevision): same
1919 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1920 $LC_ALL="C" when running commands under 'buildbot try', too
1922 * buildbot/test/__init__.py: remove the global os.environ()
1923 setting, instead we do it just for the tests that run commands and
1924 need to parse their output.
1926 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1927 remove the overly-short .timeout on this test, because non-DNotify
1928 platforms must fall back to polling which happens at 10 second
1929 intervals, so a 5 second timeout would never succeed.
1931 2006-04-24 Brian Warner <warner@lothar.com>
1933 * docs/buildbot.texinfo (Installing the code): update trial
1934 invocation, SF#1469116 by Niklaus Giger.
1935 (Attributes of Changes): updated branch-name examples to be
1936 a bit more realistic, SF#1475240 by Stephen Davis.
1938 * contrib/windows/buildbot2.bat: utility wrapper for windows
1939 developers, contributed by Nick Trout (after a year of neglect..
1940 sorry!). SF#1194231.
1942 * buildbot/test/test_vc.py (*.capable): store the actual VC
1943 binary's pathname in VCS[vcname], so it can be retrieved later
1944 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1945 strip out non-numeric timezone information, specifically the funky
1946 German string that his system produced that confuses CVS.
1947 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1948 allow Darcs tests to work on windows
1949 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1950 procutils.which() everywhere, to allow tryclient to work under
1951 windows. Also from Niklaus Giger, SF#1463394.
1953 * buildbot/twcompat.py (which): move the replacement for a missing
1954 twisted.python.procutils.which from test_vc.py to here, so it can
1955 be used in other places too (specifically tryclient.py)
1957 2006-04-23 Brian Warner <warner@lothar.com>
1959 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1960 bare buildbotURL/projectName line with a proper DIV, along with a
1961 CSS class of "title", from Stefan Seefeld (SF#1461675).
1962 (WaterfallStatusResource.body0): remove the redundant 'table'
1963 class from the table
1964 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1965 to the top-row TR, and class="Activity" to the second-row TR,
1966 rather than putting them in the individual TD nodes.
1968 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1969 'got_revision' build property for all VC systems that implement
1970 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1972 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1973 to determine which revision we actually obtained
1974 (CVS.parseGotRevision): implement this for CVS, which just means
1975 to grab a timestamp. Not ideal, and it depends upon the buildslave
1976 having a clock that is reasonably well syncronized with the server,
1977 but it's better than nothing.
1978 (SVN.parseGotRevision): implement it for SVN, which is accurate
1979 (Darcs.parseGotRevision): same
1980 (Arch.parseGotRevision): same
1981 (Bazaar.parseGotRevision): same
1982 (Mercurial.parseGotRevision): same
1984 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1985 keep a record of all non-stdout/stderr/header/rc status updates,
1986 for the benefit of RemoteCommands that send other useful things,
1988 (Source.commandComplete): put any 'got_revision' status values
1989 into a build property of the same name
1992 * buildbot/process/step_twisted.py (Trial): update to deal with
1993 new ShellCommand refactoring
1995 * docs/buildbot.texinfo (Build Properties): document new feature
1996 that allows BuildSteps to get/set Build-wide properties like which
1997 revision was requested and/or checked out.
1999 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2000 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2001 it. Note that this bumps the persistenceVersion of the saved Build
2002 object, so add the necessary upgrade-old-version logic to include
2003 an empty properties dict.
2005 * buildbot/process/base.py (Build.setProperty): implement it
2006 (Build.getProperty): same
2007 (Build.startBuild): change build startup to set 'branch',
2008 'revision', and 'slavename' properties at the right time
2010 * buildbot/process/step.py (BuildStep.__init__): change setup to
2011 require 'build' argument in a better way
2012 (LoggingBuildStep): split ShellCommand into two pieces, for better
2013 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2014 a single RemoteCommand that sends stdout/stderr status text. It
2015 also provides the usual commandComplete / createSummary /
2016 evaluateCommand / getText methods to be overridden...
2017 (ShellCommand): .. whereas ShellCommand is specifically for
2018 running RemoteShellCommands. Other shell-like BuildSteps (like
2019 Source) can inherit from LoggingBuildStep instead of ShellCommand
2020 (WithProperties): marker class to do build-property interpolation
2021 (Source): inherit from LoggingBuildStep instead of ShellCommand
2024 * buildbot/test/test_properties.py: test new functionality
2026 2006-04-21 Brian Warner <warner@lothar.com>
2028 * buildbot/test/test_vc.py: rename testBranch to
2029 testCheckoutBranch to keep the tests in about the right
2032 2006-04-18 Brian Warner <warner@lothar.com>
2034 * docs/buildbot.texinfo (PBListener): improve cross-references
2035 between PBListener and 'buildbot statusgui', thanks to John Pye
2038 2006-04-17 Brian Warner <warner@lothar.com>
2040 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2041 running under Twisted-1.3.0, otherwise skipped tests are reported
2044 * all: use isinstance() instead of 'type(x) is foo', suggested by
2047 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2048 oops, fix a brain-fade from the other week, when making the
2049 addStep changes. I changed all the __init__ upcalls to use the
2050 wrong superclass name.
2051 (FullTwistedBuildFactory.__init__): same
2052 (TwistedDebsBuildFactory.__init__): same
2053 (TwistedReactorsBuildFactory.__init__): same
2054 (TwistedBuild.isFileImportant): use .startswith for clarity,
2055 thanks to Neal Norwitz for the suggestions.
2057 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2058 changes, then deliver them over PB to a remote buildmaster.
2060 * contrib/svnpoller.py: added script by John Pye to poll a remote
2061 SVN repository (by running 'svn log') from a cronjob, and run
2062 'buildbot sendchange' to deliver the changes to a remote
2064 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2065 modification of svnpoller.py), same purpose, but this one loops
2066 internally (rather than expecting to run from a cronjob) and works
2068 * contrib/README.txt: same
2070 2006-04-11 Brian Warner <warner@lothar.com>
2072 * all: fix a number of incorrect names and missing imports, thanks
2073 to Anthony Baxter for the patch.
2074 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2075 remove unused buggy method.
2076 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2077 comes from shutil, not "shutils"
2078 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2079 (Arch.checkSlaveVersion): same
2080 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2082 * buildbot/process/step_twisted2.py: add some missing imports
2083 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2084 this code used to live in twisted.internet.defer
2086 2006-04-10 Brian Warner <warner@lothar.com>
2088 * buildbot/process/step.py (Mercurial): add Mercurial support
2089 * buildbot/slave/commands.py (Mercurial): same
2090 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2091 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2092 not yet tested, but 'try' support *is* covered
2093 * docs/buildbot.texinfo (Mercurial): document it
2095 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2096 some debugging messages (turned off)
2097 * buildbot/test/test_vc.py: improve debug messages
2099 2006-04-07 Brian Warner <warner@lothar.com>
2101 * buildbot/test/test_vc.py (which): define our own which() in case
2102 we can't import twisted.python.procutils, because procutils doesn't
2103 exist in Twisted-1.3
2105 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2106 of SlaveLocks for performance tests
2108 * docs/examples/twisted_master.cfg: update to match current usage
2110 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2111 password, p4 binary, pollinterval, maximum history to check.
2112 Patch from an anonymous sf.net contributor, SF#1219384.
2113 * buildbot/process/step.py (P4Sync.__init__): add username,
2114 password, and client arguments.
2115 * buildbot/slave/commands.py (P4Sync): same
2117 2006-04-05 Brian Warner <warner@lothar.com>
2119 * buildbot/process/factory.py (BuildFactory.addStep): new method
2120 to add steps to a BuildFactory. Use it instead of f.steps.append,
2121 and you can probably avoid using the s() convenience function.
2122 Patch from Neal Norwitz, sf.net #1412605.
2123 (other): update all factories to use addStep
2124 * buildbot/process/process_twisted.py: update all factories to use
2127 2006-04-03 Brian Warner <warner@lothar.com>
2129 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2130 work under windows too. Adapted from a patch by Niklaus Giger,
2131 addresses SF#1463399.
2133 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2134 spawned commands emit parseable results in english and not some
2135 other language. Patch from Niklaus Giger, SF#1463395.
2137 * README (INSTALLATION): discourage users from running unit tests on
2138 a "network drive", patch from Niklaus Giger, SF#1463394.
2140 2006-03-22 Brian Warner <warner@lothar.com>
2142 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2143 function to turn a repository-relative pathname into a (branch,
2144 branch-relative-filename) tuple. Change this function to handle
2145 the branch naming policy used by your Subversion repository.
2146 Thanks to AllMyData.com for sponsoring this work.
2148 2006-03-16 Brian Warner <warner@lothar.com>
2150 * buildbot/scripts/sample.cfg: add python-mode declaration for
2151 vim. Thanks to John Pye for the patch.
2153 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2154 command line, mention the importance of running 'crontab' as the
2155 buildmaster/buildslave user. Thanks to John Pye for the catch.
2157 2006-03-13 Brian Warner <warner@lothar.com>
2159 * buildbot/status/words.py (IRC): add an optional password=
2160 argument, which will be sent to Nickserv in an IDENTIFY message at
2161 login, to claim the nickname. freenode requires this before the
2162 bot can sent (or reply to) private messages. Thanks to Clement
2163 Stenac for the patch.
2164 * docs/buildbot.texinfo (IRC Bot): document it
2166 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2167 larger than chunkSize. Fixes SF#1349253.
2168 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2169 (Log.testConsumer): update to match new internal chunking behavior
2171 2006-03-12 Brian Warner <warner@lothar.com>
2173 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2175 * buildbot/test/test_maildir.py (MaildirTest): rename the
2176 'timeout' method, as it collides with trial's internals
2178 * buildbot/scripts/runner.py: add 'buildbot restart' command
2179 (stop): don't sys.exit() out of here, otherwise restart can't work
2180 * docs/buildbot.texinfo (Shutdown): document it
2182 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2183 * buildbot/status/html.py (Waterfall.__init__): same
2184 * buildbot/process/builder.py (Builder.startBuild): same
2185 * buildbot/process/base.py (BuildRequest): same
2186 * buildbot/sourcestamp.py (SourceStamp): same
2187 * buildbot/scheduler.py (Nightly): same
2189 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2191 * docs/buildbot.texinfo: same
2193 2006-02-17 Brian Warner <warner@lothar.com>
2195 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2196 * docs/buildbot.texinfo: set version number to match
2197 * NEWS: update for 0.7.2
2199 2006-02-16 Brian Warner <warner@lothar.com>
2201 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2203 2006-02-09 Brian Warner <warner@lothar.com>
2205 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2206 add text to explain per-build branch parameters
2207 * NEWS: mention --umask
2209 2006-02-08 Brian Warner <warner@lothar.com>
2211 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2213 (SlaveOptions.optParameters): add --umask, to make it possible to
2214 make buildslave-generated files (including build products) be
2217 * buildbot/slave/bot.py (BuildSlave.startService): same
2219 2006-01-23 Brian Warner <warner@lothar.com>
2221 * buildbot/status/builder.py: urllib.quote() all URLs that include
2222 Builder names, so that builders can include characters like '/'
2223 and ' ' without completely breaking the resulting HTML. Thanks to
2224 Kevin Turner for the patch.
2225 * buildbot/status/html.py: same
2226 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2228 * NEWS: update in preparation for upcoming release
2230 2006-01-18 Brian Warner <warner@lothar.com>
2232 * docs/examples/twisted_master.cfg: update to match the Twisted
2233 buildbot: remove python2.2, switch to exarkun's buildslaves,
2234 disable the .deb builder until we figure out how to build twisted
2235 .debs from SVN, add some ktrace debugging to the OS-X build
2236 process and remove the qt build, remove threadless builders,
2237 change freebsd builder to use landonf's buildslave.
2239 2006-01-12 Brian Warner <warner@lothar.com>
2241 * buildbot/master.py (Manhole.__init__): let port= be a strports
2242 specification string, but handle a regular int for backwards
2243 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2244 used in master.cfg to limit connections to just the local host.
2245 (BuildMaster.loadConfig): same for c['slavePortnum']
2246 * buildbot/scheduler.py (Try_Userpass.__init__): same
2247 * buildbot/status/client.py (PBListener.__init__): same
2248 * buildbot/status/html.py (Waterfall.__init__): same, for both
2249 http_port and distrib_port. Include backwards-compatibility checks
2250 so distrib_port can be a filename string and still mean unix:/foo
2251 * docs/buildbot.texinfo (Setting the slaveport): document it
2252 (Debug options): same
2253 (HTML Waterfall): same
2256 * buildbot/test/test_config.py (ConfigTest): test it
2258 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2259 slaveport's disownServiceParent deferred to fire before opening
2260 the new one. Fixes an annoying bug in the unit tests.
2262 2006-01-03 Brian Warner <warner@lothar.com>
2264 * buildbot/master.py (BuildMaster): remove the .schedulers
2265 attribute, replacing it with an allSchedulers() method that looks
2266 for all IService children that implement IScheduler. Having only
2267 one parent/child relationship means fewer opportunities for bugs.
2268 (BuildMaster.allSchedulers): new method
2269 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2270 also fix ugly bug that caused any config-file reload to
2271 half-forget about the earlier Schedulers, causing an exception
2272 when a Change arrived and was handed to a half-connected
2273 Scheduler. The exception was in scheduler.py line 54ish:
2274 self.parent.submitBuildSet(bs)
2275 exceptions.AttributeError: 'NoneType' object has no attribute
2277 (BuildMaster.addChange): update to use allSchedulers()
2279 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2280 to work properly with twisted-1.3.0, where you must explicitly
2281 include the __implements__ from parent classes
2282 (BaseScheduler.__repr__): make it easier to distinguish distinct
2284 (BaseUpstreamScheduler.__implements__): same
2286 * buildbot/status/builder.py (Status.getSchedulers): update to
2288 * buildbot/test/test_run.py (Run.testMaster): same
2289 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2290 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2291 make sure Scheduler instances are left alone when an identical
2292 config file is reloaded
2293 (ConfigElements.testSchedulers): make sure Schedulers are properly
2296 * Makefile (TRIALARGS): my local default Twisted version is now
2297 2.1.0, update the trial arguments accordingly
2299 2005-12-22 Brian Warner <warner@lothar.com>
2301 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2304 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2305 addChange in the parent class, although I suspect this should be
2306 fixed better in the future.
2308 2005-11-26 Brian Warner <warner@lothar.com>
2310 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2311 explode when branch==None, thanks to Kevin Turner for the catch
2312 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2315 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2317 * docs/buildbot.texinfo: same
2319 2005-11-26 Brian Warner <warner@lothar.com>
2321 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2322 * docs/buildbot.texinfo: set version number to match
2324 2005-11-26 Brian Warner <warner@lothar.com>
2326 * NEWS: update for 0.7.1
2328 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2329 sure that unsubscribe works even if we never sent an ETA update.
2330 Also, don't explode on duplicate unsubscribe.
2331 (BuildStepStatus.addLog): make the convenience "return self"-added
2332 watcher automatically unsubscribe when the Step finishes.
2333 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2334 (BuildStatus.stepStarted): same auto-unsubscribe
2335 (BuilderStatus.buildStarted): same auto-unsubscribe
2337 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2339 (IStatusReceiver.stepStarted): same
2340 (IStatusReceiver.logStarted): same
2342 * buildbot/test/test_run.py (Status): move the Status test..
2343 * buildbot/test/test_status.py (Subscription): .. to here
2345 2005-11-25 Brian Warner <warner@lothar.com>
2347 * NEWS: more updates
2349 * buildbot/locks.py: fix the problem in which loading a master.cfg
2350 file that changes some Builders (but not all of them) can result
2351 in having multiple copies of the same Lock. Now, the real Locks
2352 are kept in a table inside the BotMaster, and the Builders/Steps
2353 use "LockIDs", which are still instances of MasterLock and
2354 SlaveLock. The real Locks are instances of the new RealMasterLock
2355 and RealSlaveLock classes.
2356 * buildbot/master.py (BotMaster.getLockByID): new method to
2357 convert LockIDs into real Locks.
2358 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2359 into real Locks before building
2360 * buildbot/process/step.py (BuildStep.startStep): same
2361 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2362 exercises the problem
2365 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2366 what Schedulers are available
2368 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2369 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2370 'cron'-style build scheduling at certain times of day, week,
2372 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2374 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2375 handling: treat self.fileIsImportant more as an attribute that
2376 contains a callable than as a method. If the attribute is None,
2377 don't call it and assume all filenames are important. It is still
2378 possible to provide a fileIsImportant method in a subclass,
2380 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2382 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2383 test using AnyBranchScheduler with fileIsImportant=None
2385 2005-11-24 Brian Warner <warner@lothar.com>
2387 * buildbot/test/test_config.py (StartService): don't claim a fixed
2388 port number, instead set slavePort=0 on the first pass, figure out
2389 what port was allocated, then switch to a config file that uses
2392 * buildbot/master.py (BuildMaster.loadConfig): close the old
2393 slaveport before opening the new one, because unit tests might
2394 replace slavePort=0 with the same allocated portnumber, and if we
2395 don't wait for the old port to close first, we get a "port already
2396 in use" error. There is a tiny race condition here, but the only
2397 threat is from other programs that bind (statically) to the same
2398 port number we happened to be allocated, and only if those
2399 programs use SO_REUSEADDR, and only if they get control in between
2402 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2404 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2405 deleted ChangeSources before adding any new ones
2406 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2407 compare_attrs, to make sure that a config-file reload does not
2408 unnecessarily replace an unmodified ChangeSource instance
2409 * buildbot/test/test_config.py (ConfigTest.testSources): update
2411 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2412 mean "don't build anything", and add a warning if it gets used
2413 because it isn't actually useful.
2415 * contrib/svn_buildbot.py: update example usage to match the port
2416 number that gets used by the PBChangeSource
2417 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2419 2005-11-22 Brian Warner <warner@lothar.com>
2421 * NEWS: start collecting items for next release
2423 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2424 revisions are strings
2425 (P4Sync.computeSourceRevision): same
2427 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2428 to the Buildbot's overall status page
2429 (StatusResourceBuilder.body): same
2431 2005-11-15 Brian Warner <warner@lothar.com>
2433 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2434 config-file loading, specifically to make sure old StatusTargets
2435 are finished shutting down before new ones start up (thus
2436 resolving a bug in which changing the Waterfall object would fail
2437 because both new and old instances were claiming the same
2438 listening port). Also load new Schedulers after all the new
2439 Builders are set up, in case they fire off a new build right away.
2440 * buildbot/test/test_config.py (StartService): test it
2442 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2443 the branch name to the mail body
2445 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2446 Without it, a config-file reload fails to update an existing
2448 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2449 username/passwd to compare_attrs, for the same reason
2450 * buildbot/status/html.py (Waterfall): add favicon to
2451 compare_attrs, same reason
2453 2005-11-05 Brian Warner <warner@lothar.com>
2455 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2456 baserev before stuffing it in the jobfile. This resolves problems
2457 under SVN (and probably Arch) where revisions are expressed as
2458 numbers. I'm inclined to use string-based revisions everywhere in
2459 the future, but this fix should be safe for now. Thanks to Steven
2460 Walter for the patch.
2462 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2463 binary mode when opening pickle files, to make windows work
2464 better. Thanks to Dobes Vandermeer for the catch.
2465 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2466 (BuilderStatus.getBuildByNumber): same
2467 (Status.builderAdded): same
2468 * buildbot/master.py (BuildMaster.loadChanges): same
2470 * buildbot/util.py (Swappable): delete unused leftover code
2472 * buildbot/process/step.py (SVN): when building on a non-default
2473 branch, add the word "[branch]" to the VC step's description, so
2474 it is obvious that we're not building the usual stuff. Likewise,
2475 when we are building a specific revision, add the text "rNNN" to
2476 indicate what that revision number is. Thanks to Brad Hards and
2477 Nathaniel Smith for the suggestion.
2478 (Darcs.startVC): same
2479 (Arch.startVC): same
2480 (Bazaar.startVC): same
2482 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2483 typo, caught by Mark Dillavou, closes SF#1216636.
2485 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2486 about a test to add some day
2488 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2489 the 'full-2.3' build, and the 'reactors' build is now run under
2490 python-2.4 because the buildslave no longer has gtk/etc bindings
2491 for earlier versions.
2493 2005-11-03 Brian Warner <warner@lothar.com>
2495 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2496 method, takes an IBuildStatus and rebuilds it. It might make more
2497 sense to add this to IBuildControl instead, but that instance goes
2498 away completely once the build has finished, and resubmitting
2499 builds can take place weeks later.
2500 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2501 * buildbot/status/html.py (StatusResourceBuild): also stash an
2502 IBuilderControl so we can use resubmitBuild.
2503 (StatusResourceBuild.body): render "resubmit" button if we can.
2504 Also add hrefs for each BuildStep
2505 (StatusResourceBuild.rebuild): add action for "resubmit" button
2506 (StatusResourceBuilder.getChild): give it an IBuilderControl
2508 * buildbot/status/builder.py (Status.getURLForThing): change the
2509 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2510 that live as targets of buttons like "stop" and "rebuild" can't
2512 * buildbot/status/builder.py (Status.getURLForThing): same
2513 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2514 (StepBox.getBox): same
2515 * buildbot/test/test_web.py (GetURL): same
2518 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2519 exclusivity checks after Source.__init__ upcall, so misspelled
2520 arguments will be reported more usefully
2521 (Darcs.__init__): same
2523 2005-10-29 Brian Warner <warner@lothar.com>
2525 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2526 builder. Move the Try scheduler off to a separate port.
2528 2005-10-27 Brian Warner <warner@lothar.com>
2530 * buildbot/clients/gtkPanes.py
2531 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2532 to cause the app to crash, now they don't.
2534 * buildbot/clients/debug.py: display the buildmaster's location
2535 in the window's title bar
2537 2005-10-26 Brian Warner <warner@lothar.com>
2539 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2540 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2541 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2543 * buildbot/status/html.py (td): put a single non-breaking space
2544 inside otherwise empty <td> elements, as a workaround for buggy
2545 browsers which would optimize them away (along with any associated
2546 styles, like the kind that create the waterfall grid borders).
2547 Patch from Frerich Raabe.
2549 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2550 argv-list as an argument, defaulting to ["-to"], which is
2551 appropriate for the Trial that comes with Twisted-2.1.0 and
2552 earlier. The Trial in current Twisted SVN wants
2553 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2554 defaults to an empty list.
2555 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2556 match it, now that trialMode= is a list instead of a single string
2558 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2560 * docs/buildbot.texinfo: same
2562 2005-10-24 Brian Warner <warner@lothar.com>
2564 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2565 * docs/buildbot.texinfo: set version number to match
2567 2005-10-24 Brian Warner <warner@lothar.com>
2569 * README: update for 0.7.0
2571 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2573 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2574 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2575 send the branch= argument unless the user really provided one, to
2576 retain compatibility with older buildmasters that don't accept
2578 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2581 * docs/buildbot.texinfo: update lots of stuff
2583 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2584 to the 'buildbot sendchange' command
2585 * buildbot/clients/sendchange.py (Sender.send): same
2586 * buildbot/changes/pb.py (ChangePerspective): same
2587 * buildbot/test/test_changes.py (Sender.testSender): test it
2589 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2590 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2591 for consistency with other BuildStep arguments that use camelCase.
2592 Well, at least more of them use camelCase (like flunkOnWarnings)
2593 than don't.. I wish I'd picked one style and stuck with it
2594 earlier. Annoying, but it's best done before the release, since
2595 these arguments didn't exist at all in 0.6.6 .
2597 * buildbot/test/test_vc.py (SVN.testCheckout): same
2598 (Darcs.testPatch): same
2599 * docs/buildbot.texinfo (SVN): document the change
2600 (Darcs): same, add some build-on-branch docs
2601 * docs/examples/twisted_master.cfg: match change
2603 * buildbot/process/step.py (BuildStep): rename
2604 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2605 how it is normally used.
2606 * buildbot/test/test_steps.py (Version.checkCompare): same
2608 * buildbot/process/step.py (CVS.startVC): refuse to build
2609 update/copy -style builds on a non-default branch with an old
2610 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2611 concern is that it will do a VC 'update' in an existing tree when
2612 it is supposed to be switching branches (and therefore clobbering
2613 the tree to do a full checkout), thus building the wrong source.
2614 This used to be a warning, but I think the confusion it is likely
2615 to cause warrants making it an error.
2616 (SVN.startVC): same, also make mode=export on old slaves an error
2617 (Darcs.startVC): same
2618 (Git.startVC): improve error message for non-Git-enabled slaves
2619 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2620 specific revision is built on a slave that doesn't pay attention
2621 to args['revision'], because for slowly-changing trees it will
2622 probably do the right thing, and because we have no way to tell
2623 whether we're asking it to build the most recent version or not.
2624 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2626 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2627 that 'master' is in host:portnum format, to catch errors sooner
2629 2005-10-23 Brian Warner <warner@lothar.com>
2631 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2632 when creating the list of warning messages, include the line
2633 immediately after each WARNING: line, since that's usually where
2634 the file and line number wind up.
2636 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2641 2005-10-22 Brian Warner <warner@lothar.com>
2643 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2644 patch from Brad Hards
2645 * buildbot/status/classic.css: same
2646 * buildbot/test/test_web.py (Waterfall): match changes
2648 * buildbot/test/test_steps.py (BuildStep.setUp): set
2649 nextBuildNumber so the test passes
2650 * buildbot/test/test_status.py (MyBuilder): same
2652 * buildbot/status/html.py (StatusResourceBuild.body): revision
2653 might be numeric, so stringify it before html-escapifying it
2654 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2655 timer for the upcoming build
2656 * buildbot/status/classic.css: add background-color attributes for
2657 offline/waiting/building classes
2659 * buildbot/status/builder.py (BuildStatus): derive from
2660 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2661 the default (i.e. unknown) .slavename to "???" instead of None,
2662 since even unknown slavenames need to be printed eventually.
2663 (BuilderStatus): also derive from styles.Versioned . More
2664 importantly, determine .nextBuildNumber at creation/unpickling
2665 time by scanning the directory of saved BuildStatus instances and
2666 choosing one larger than the highest-numbered one found. This
2667 should fix the problem where random errors during upgrades cause
2668 the buildbot to forget about earlier builds. .nextBuildNumber is
2669 no longer stored in the pickle.
2670 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2671 at least log the error. Also call Builder.determineNextBuildNumber
2672 once the basedir is set.
2674 * buildbot/master.py (BuildMaster.loadChanges): do
2675 styles.doUpgrade afterwards, in case I decide to make Changes
2676 derived from styles.Versioned some day and forget to make this
2680 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2681 when running under older pythons (<2.3) in which the shlex module
2682 doesn't have a 'split' function.
2684 * buildbot/process/step.py (ShellCommand.start): make
2685 errorMessages= be a list of strings to stuff in the log before the
2686 command actually starts. This makes it easier to flag multiple
2687 warning messages, e.g. when the Source steps have to deal with an
2689 (CVS.startVC): handle slaves that don't handle multiple branches
2690 by switching into 'clobber' mode
2691 (SVN.startVC): same. Also reject branches without base_url
2692 (Darcs.startVC): same. Also reject revision= in older slaves
2693 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2694 (Bazaar.startVC): same, and test for baz separately than for arch
2696 * buildbot/slave/commands.py (cvs_ver): document new features
2698 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2699 (BuildStep.slaveVersionNewEnough): more useful utility method
2700 * buildbot/test/test_steps.py (Version): start testing it
2702 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2703 the 'force' command requires python2.3, for the shlex.split method
2705 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2706 since we don't use it anymore. The Twisted buildbot uses a
2709 2005-10-21 Brian Warner <warner@lothar.com>
2711 * buildbot/process/process_twisted.py: rework all BuildFactory
2712 classes to take a 'source' step as an argument, instead of
2713 building up the SVN instance in the factory.
2714 * docs/examples/twisted_master.cfg: enable build-on-branch by
2715 providing a base_url and default_branch
2717 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2718 control over --branch and --revision, not that they are always
2720 * buildbot/status/html.py (StatusResourceBuilder.force): same
2721 (StatusResourceBuild.body): display SourceStamp components
2723 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2724 IRC 'force' command, so it can be shared with an eventual
2725 command-line-tool 'buildbot force' mode.
2726 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2728 2005-10-20 Brian Warner <warner@lothar.com>
2730 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2732 * docs/examples/twisted_master.cfg: update to use Schedulers
2734 * buildbot/scripts/sample.cfg: update with Schedulers
2736 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2737 method specifically for use by HTML "force build" button and the
2738 IRC "force" command. Raises an immediate error if there are no
2740 (IBuilderControl.requestBuild): make this just submit a build, not
2741 try to check for existing slaves or set up any when-finished
2742 Deferreds or anything.
2743 * buildbot/process/builder.py (BuilderControl): same
2744 * buildbot/status/html.py (StatusResourceBuilder.force): same
2745 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2746 * buildbot/test/test_slaves.py: same
2747 * buildbot/test/test_web.py: same
2749 2005-10-19 Brian Warner <warner@lothar.com>
2751 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2752 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2754 2005-10-18 Brian Warner <warner@lothar.com>
2756 * buildbot/status/html.py: provide 'status' argument to most
2757 StatusResourceFOO objects
2758 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2759 and Logfiles" section to make the Build page into a more-or-less
2760 comprehensive source of status information about the build
2762 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2763 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2765 2005-10-17 Brian Warner <warner@lothar.com>
2767 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2768 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2769 out what to do about other projects: the correct options for
2770 recent Twisteds will not work for older ones.
2772 2005-10-15 Brian Warner <warner@lothar.com>
2774 * buildbot/status/builder.py (Status.getURLForThing): add method
2775 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2776 use this in email/IRC status clients to make them more useful, by
2777 providing the end user with hints on where to learn more about the
2778 object being reported on.
2779 * buildbot/test/test_web.py (GetURL): tests for it
2781 2005-10-14 Brian Warner <warner@lothar.com>
2783 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2784 fix bug resulting from deferredResult changes
2786 2005-10-13 Brian Warner <warner@lothar.com>
2788 * buildbot/test/test_changes.py: remove use of deferredResult
2789 * buildbot/test/test_config.py: same
2790 * buildbot/test/test_control.py: same
2791 * buildbot/test/test_status.py: same
2792 * buildbot/test/test_vc.py: this is the only remaining use, since
2793 it gets used at module level. This needs to be replaced by some
2794 sort of class-level run-once routine.
2796 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2798 * lots: implement multiple slaves per Builder, which means multiple
2799 current builds per Builder. Some highlights:
2800 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2801 of (state,currentBuilds) instead of (state,currentBuild)
2802 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2803 (IBuildStatus.getSlavename): new method, so you can tell which
2804 slave got used. This only gets set when the build completes.
2805 (IBuildRequestStatus.getBuilds): new method
2807 * buildbot/process/builder.py (SlaveBuilder): add a .state
2808 attribute to track things like ATTACHING and IDLE and BUILDING,
2810 (Builder): .. the .slaves attribute here, which has been turned
2811 into a simple list of available slaves. Added a separate
2812 attaching_slaves list to track ones that are not yet ready for
2814 (Builder.fireTestEvent): put off the test-event callback for a
2815 reactor turn, to make tests a bit more consistent.
2816 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2817 ping fails due to an exception. This needs work, I'm worried that
2818 a code error could lead to a constantly re-connecting slave.
2819 Especially since I'm trying to move to a distinct remote_ping
2820 method, separate from the remote_print that we currently use.
2821 (BuilderControl.requestBuild): return a convenience Deferred that
2822 provides an IBuildStatus when the build finishes.
2823 (BuilderControl.ping): ping all connected slaves, only return True
2824 if they all respond.
2826 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2827 reconnect when we shut down.
2829 * buildbot/status/builder.py: implement new methods, convert
2830 one-build-at-a-time methods to handle multiple builds
2831 * buildbot/status/*.py: do the same in all default status targets
2832 * buildbot/status/html.py: report the build's slavename in the
2833 per-Build page, report all buildslaves on the per-Builder page
2835 * buildbot/test/test_run.py: update/create tests
2836 * buildbot/test/test_slaves.py: same
2837 * buildbot/test/test_scheduler.py: remove stale test
2839 * docs/buildbot.texinfo: document the new builder-specification
2840 'slavenames' parameter
2842 2005-10-12 Brian Warner <warner@lothar.com>
2844 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2845 report failure correctly, causing Dependent builds to run when
2846 they shouldn't have.
2847 * buildbot/status/builder.py (BuildSetStatus): same
2848 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2849 (Set.testSuccess): test the both-pass case too
2850 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2851 fix this test: it was ending too early, masking the failure before
2852 (Logger): specialized StatusReceiver to make sure the dependent
2853 builds aren't even started, much less completed.
2855 2005-10-07 Brian Warner <warner@lothar.com>
2857 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2858 bot.SlaveBuilder being disowned in the middle of a build
2860 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2861 this inherit from StatusReceiver. Also upcall in __init__. This
2862 fixes the embarrasing crash when the new buildSetSubmitted method
2863 is invoked and Waterfall/etc don't implement their own.
2864 * buildbot/test/test_run.py: add a TODO note about a test to catch
2865 just this sort of thing.
2867 * buildbot/process/builder.py (Builder.attached): remove the
2868 already-attached warning, this situation is normal. Add some
2869 comments explaining it.
2871 2005-10-02 Brian Warner <warner@lothar.com>
2873 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2874 OverflowError when setting up dnotify, because some 64-bit systems
2875 have problems with signed-vs-unsigned constants and trip up on the
2876 DN_MULTISHOT flag. Patch from Brad Hards.
2878 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2880 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2881 progressMetrics, description, descriptionDone to the 'parms' list,
2882 and make use the 'parms' list from the implementation class
2883 instead of only BuildStep to initialize the parameters. This
2884 allows buildbot.process.factory.s() to initialize all the parms,
2885 not just those defined in directly by BuildStep.
2887 2005-09-03 Brian Warner <warner@lothar.com>
2889 * NEWS: start adding items for the next release
2891 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2892 python2.2 tests, change 'Quick' builder to only use python2.3
2894 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2896 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2897 the "Ping Builder" button if the build control is available; the
2898 user sees an exception otherwise
2900 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2902 2005-09-01 Brian Warner <warner@lothar.com>
2904 * buildbot/interfaces.py (IBuilderStatus.getState): update
2905 signature, point out that 'build' can be None
2906 (IBuildStatus.getETA): point out ETA can be none
2908 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2910 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2912 2005-08-31 Brian Warner <warner@lothar.com>
2914 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2915 update to match correct signature: removed 'eta' argument
2916 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2918 2005-08-30 Brian Warner <warner@lothar.com>
2920 * buildbot/status/builder.py (LogFile): remove the assertion that
2921 blows up when you try to overwrite an existing logfile, instead
2922 just emit a warning. This case gets hit when the buildmaster is
2923 killed and doesn't get a chance to write out the serialized
2924 BuilderStatus object, so the .nextBuildNumber attribute gets out
2927 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2928 the 'buildbot sendchange' arguments, for the Darcs context file
2929 * docs/buildbot.texinfo (sendchange): document it
2931 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2932 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2933 (IStatus.getSchedulers): new method
2934 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2935 (Status.getSchedulers): implement
2936 * buildbot/process/builder.py (Builder): maintain
2937 BuilderStatus.pendingBuilds
2938 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2939 (TryBase.addChange): Try schedulers should ignore Changes
2941 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2942 for 'try' on CVS/SVN
2943 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2945 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2946 report status properly.
2947 (Try.createJob): implement unique buildset IDs
2949 * buildbot/status/client.py (StatusClientPerspective): add a
2950 perspective_getBuildSets method for the benefit of jobdir-style
2952 * docs/buildbot.texinfo (try): more docs
2953 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2956 2005-08-18 Brian Warner <warner@lothar.com>
2958 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2959 actually work. It's functional but still kind of clunky. Also, it
2960 only works with the pb-style.. needs to be made to work with the
2963 * buildbot/status/client.py (RemoteBuildSet): new class
2964 (RemoteBuildRequest): same
2965 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2966 object, not the internal BuildStatus object.
2967 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2968 outside of the usual buildStarted() return value.
2969 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2971 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2972 (Try_Userpass_Perspective.perspective_try): return a remotely
2973 usable BuildSetStatus object
2975 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2976 isStarted()/waitUntilStarted()
2978 2005-08-16 Brian Warner <warner@lothar.com>
2980 * buildbot/status/builder.py: implement IBuildSetStatus and
2981 IBuildRequestStatus, wire them into place.
2982 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2983 methods into the BuildSetStatus object.
2984 * buildbot/interfaces.py: same
2985 (IStatus.getBuildSets): new method to get pending BuildSets
2986 (IStatusReceiver.buildsetSubmitted): new method which hears about
2988 * buildbot/master.py (BuildMaster.submitBuildSet): same
2989 * buildbot/process/base.py (BuildRequest): same, replace
2990 waitUntilStarted with subscribe/unsubscribe
2991 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2992 subscribe instead of waitUntilStarted
2993 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2995 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2997 * buildbot/test/test_buildreq.py: update for new code
2998 * buildbot/test/test_control.py (Force.testRequest): same
3001 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3002 for Darcs to not use the tempfile module, so it works under
3003 python-2.2 too. We really didn't need the full cleverness of that
3004 module, since the slave has exclusive control of its own builddir.
3006 2005-08-15 Brian Warner <warner@lothar.com>
3008 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3009 for CVS trees. It doesn't work for non-trunk branches,
3011 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3014 * Makefile: make it easier to test against python2.2
3016 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3017 tearDown2, so things like Arch can unregister archives as they're
3018 shutting down. The previous subclass-override-tearDown technique
3019 resulted in a nested maybeWait() and test failures under
3022 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3023 where we can (Arch), add a branch= argument to set the branch used
3025 (BazExtractor): extract the branch too
3026 (TlaExtractor): same
3027 * buildbot/scripts/runner.py (TryOptions): add --branch
3028 * docs/buildbot.texinfo (try): document --branch/try_branch
3030 * buildbot/slave/commands.py (Darcs): implement get-revision for
3031 Darcs, so that 'try' will work. This requires the tempfile module
3034 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3035 of revisions, branches, and 'try' in the process.
3037 2005-08-11 Brian Warner <warner@lothar.com>
3039 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3040 this, it got broken at some point in the last few releases
3041 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3042 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3043 specifically the removal of ETA information from the tuple
3045 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3048 * docs/buildbot.texinfo (try): document both --builder and
3049 'try_builders' in .buildbot/options
3050 * buildbot/scripts/runner.py (TryOptions): add --builder,
3051 accumulate the values into opts['builders']
3052 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3053 * buildbot/test/test_runner.py (Try): add some quick tests to make
3054 sure 'buildbot try --options' and .buildbot/options get parsed
3055 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3056 use --builder control
3058 * docs/buildbot.texinfo (try): add --port argument to PB style
3060 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3061 actual SourceStamp. Still need to extract a branch name, somehow.
3062 (Try): finish implementing the try client side, still need a UI
3063 for specifying which builders to use
3064 (Try.getopt): factor our options/config-file reading
3065 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3067 * buildbot/test/test_vc.py: match SourceStampExtractor change
3069 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3070 causes the twisted log to be sent to stderr
3072 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3074 2005-08-10 Brian Warner <warner@lothar.com>
3076 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3077 style is 90% done, still missing status reporting or waiting for
3078 the buildsets to finish, and it is completely untested.
3080 * buildbot/trybuild.py: delete file, move contents to ..
3081 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3082 * buildbot/test/test_vc.py: match the move
3084 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3085 of the TryScheduler, no buildsetID or status-tracking support yet
3086 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3088 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3089 possible to set the basedir after __init__ time, so it is easier
3090 to use as a Service-child of the BuildMaster instance
3092 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3093 that delivers messages to its Service parent instead of requiring
3094 a subclass to be useful. This turns out to be much easier to build
3097 * buildbot/scripts/tryclient.py (createJob): utility code to
3098 create jobfiles, will eventually be used by 'buildbot try'
3100 2005-08-08 Brian Warner <warner@lothar.com>
3102 * docs/buildbot.texinfo (try): add docs on the
3103 as-yet-unimplemented Try scheduler
3105 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3106 * buildbot/test/test_scheduler.py: .. here
3107 (Scheduling.testTryJobdir): add placeholder test for 'try'
3109 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3110 addEntry merging (>=chunkSize) behavior
3111 (Log.testConsumer): update to handle new callLater(0) behavior
3113 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3114 both the MAX_LENGTH bugfix and the resumeProducing hang.
3116 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3117 put off the actual resumeProducing for a moment with
3118 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3119 causes large logfiles to hang midway through.
3121 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3122 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3123 and to improve memory usage when streaming the file out to a web
3125 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3126 make this work cleanly
3128 2005-08-03 Brian Warner <warner@lothar.com>
3130 * buildbot/trybuild.py: new file for 'try' utilities
3131 (getSourceStamp): run in a tree, find out the baserev+patch
3132 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3133 implemented for SVN and Darcs, still working on Arch. I don't know
3134 how to make CVS work yet.
3136 * docs/buildbot.texinfo: document the 'buildbot' command-line
3137 tool, including the not-yet-implemented 'try' feature, and the
3138 in-flux .buildbot/ options directory.
3140 2005-07-20 Brian Warner <warner@lothar.com>
3142 * buildbot/locks.py: added temporary id() numbers to Lock
3143 descriptions, to track down a not-really-sharing-the-Lock bug
3145 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3147 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3148 needed for python2.2 compatibility
3149 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3150 are from the __future__
3152 2005-07-19 Brian Warner <warner@lothar.com>
3154 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3155 message when schedulers use unknown builders
3157 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3158 SlaveLock('name') and MasterLock('name') are distinct
3160 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3161 c['schedulers'] in such a way that we can actually accept
3163 * buildbot/test/test_config.py: check it
3165 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3166 utility method to *all* the Schedulers
3167 (Periodic.listBuilderNames): same
3169 * docs/buildbot.texinfo (Interlocks): update chapter to match
3172 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3173 to make sure that c['sources'], c['schedulers'], and c['status']
3174 are all lists of the appropriate objects, and that the Schedulers
3175 all point to real Builders
3176 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3177 'listBuilderNames' utility method to support this
3178 * buildbot/scheduler.py: implement the utility method
3179 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3181 * docs/buildbot.texinfo: add some @cindex entries
3183 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3184 if it wasn't already set: most tla commands will fail unless one
3186 (Arch.createRepository): and disable bazaar's revision cache, since
3187 they cause test failures (the multiple repositories we create all
3188 interfere with each other through the cache)
3190 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3191 bring it properly up to date with twisted-2.0 test guidelines
3193 * buildbot/master.py (BuildMaster): remove references to old
3194 'interlock' module, this caused a bunch of post-merge test
3196 * buildbot/test/test_config.py: same
3197 * buildbot/process/base.py (Build): same
3199 * buildbot/test/test_slaves.py: stubs for new test case
3201 * buildbot/scheduler.py: add test-case-name tag
3202 * buildbot/test/test_buildreq.py: same
3204 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3205 unnecessary init code
3206 (Bot.remote_setBuilderList): match it
3208 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3210 * buildbot/changes/mail.py (parseSyncmail): update comment
3212 * buildbot/test/test_slavecommand.py: disable Shell tests on
3213 platforms that don't suport IReactorProcess
3215 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3216 all places where we open logfiles. It causes OS-X to open the file
3217 in some weird mode that that prevents us from mixing reads and
3218 writes to the same filehandle, which we depend upon to implement
3219 _generateChunks properly. This change doesn't appear to break
3220 win32, on which "b" and "t" are treated differently but a missing
3221 flag seems to be interpreted as "t".
3223 2005-07-18 Brian Warner <warner@lothar.com>
3225 * buildbot/slave/commands.py (ShellCommand): overhaul
3226 error-handling code, to try and make timeout/interrupt work
3227 properly, and make win32 happier
3228 * buildbot/test/test_slavecommand.py: clean up, stop using
3229 reactor.iterate, add tests for timeout and interrupt
3230 * buildbot/test/sleep.py: utility for a new timeout test
3232 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3233 code from the local-usebranches branch
3235 2005-07-17 Brian Warner <warner@lothar.com>
3237 * buildbot/process/process_twisted.py
3238 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3239 minutes, to match the other twisted BuildFactories, and don't
3240 excuse failures in c/qt/win32 reactors any more.
3242 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3243 'freebsd' builders, since the buildslaves have been unavailable
3246 2005-07-13 Brian Warner <warner@lothar.com>
3248 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3249 build-on-branch feature
3251 * buildbot/process/step.py (Darcs.__init__): add base_url and
3252 default_branch arguments, just like SVN
3253 (Arch.__init__): note that the version= argument is really the
3256 * buildbot/slave/commands.py (SourceBase): keep track of the
3257 repository+branch that was used for the last checkout in
3258 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3259 match, we clobber the directory and perform a fresh checkout
3260 rather than trying to do an in-place update. This should protect
3261 us against trying to get to branch B by doing an update in a tree
3262 obtained from branch A.
3263 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3264 (SVN.setup): same, just the svnurl
3265 (Darcs.setup): same, just the repourl
3266 (Arch.setup): same, arch coordinates (url), version, and
3267 buildconfig. Also pull the buildconfig from the args dictionary,
3268 which we weren't doing before, so the build-config was effectively
3270 (Arch.sourcedirIsUpdateable): don't try to update when we're
3271 moving to a specific revision: arch can't go backwards, so it is
3272 safer to just clobber the tree and checkout a new one at the
3274 (Bazaar.setup): same sourcedata as Arch
3276 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3277 use maybeWait, to work with twisted-1.3.0 and twcompat
3278 (Dependencies.testRun_Pass): same
3280 * buildbot/test/test_vc.py: rearrange, cleanup
3282 * buildbot/twcompat.py: add defer.waitForDeferred and
3283 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3284 can work under twisted-1.3.0 .
3286 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3287 now created at setUp time. This increases the runtime of the test
3288 suite considerably (from 91 seconds to 151), but it removes the
3289 need for an offline tarball, which should solve a problem I've
3290 seen where the test host has a different version of svn than the
3291 tarball build host. The new code also validates that mode=update
3292 really picks up recent commits. This approach will also make it
3293 easier to test out branches, because the code which creates the VC
3294 branches is next to the code which uses them. It will also make it
3295 possible to test some change-notification hooks, by actually
3296 performing a VC commit and watching to see the ChangeSource get
3299 2005-07-12 Brian Warner <warner@lothar.com>
3301 * docs/buildbot.texinfo (SVN): add branches example
3302 * docs/Makefile (buildbot.ps): add target for postscript manual
3304 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3305 * buildbot/test/test_locks.py: same
3307 * buildbot/process/step.py (Darcs): comment about default branches
3309 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3310 c['interlocks'] in the config file, complain if it is present.
3311 Scan all locks in c['builders'] to make sure the Locks they use
3313 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3314 add some tests to check for non-uniquely-named Locks
3315 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3316 since the unique-Lock validation code requires it now
3318 * buildbot/locks.py: fix test-case-name
3320 * buildbot/interlock.py: remove old file
3322 2005-07-11 Brian Warner <warner@lothar.com>
3324 * buildbot/test/test_interlock.py: rename to..
3325 * buildbot/test/test_locks.py: .. something shorter
3327 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3328 versions (after 2.0.1) changed internet.TCPClient to shut down the
3329 connection in stopService. Change the code to handle this
3332 * buildbot/process/base.py (Build): handle whole-Build locks
3333 * buildbot/process/builder.py (Builder.compareToSetup): same
3334 * buildbot/test/test_interlock.py: make tests work
3336 * buildbot/process/step.py (BuildStep.startStep): complain if a
3337 Step tries to claim a lock that's owned by its own Build
3338 (BuildStep.releaseLocks): typo
3340 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3341 file reloads don't replace unchanged Builders
3343 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3344 rewrite to cover new Locks instead of old c['interlocks']
3345 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3349 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3350 start the master and connect the buildslave
3352 * buildbot/process/step.py (FailingDummy.done): finish with a
3353 FAILURE status rather than raising an exception
3355 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3356 stringify a BuildRequest.reason that is None
3358 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3360 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3361 allow scheduler.Dependent to work
3362 * buildbot/buildset.py (BuildSet): set .reason and .results
3364 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3365 slaves, to make the test stop hanging. It still fails, of course,
3366 because I haven't even started to implement Locks.
3368 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3370 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3371 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3372 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3373 (Dependent): new class for downstream build dependencies
3374 * buildbot/test/test_dependencies.py: tests (still failing)
3376 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3378 2005-07-07 Brian Warner <warner@lothar.com>
3380 * buildbot/test/runutils.py (RunMixin): factored this class out..
3381 * buildbot/test/test_run.py: .. from here
3382 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3383 added new buildbot.locks tests (which all hang right now)
3384 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3385 * buildbot/process/step.py: claim/release per-BuildStep locks
3387 * docs/Makefile: add 'buildbot.html' target
3389 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3390 interpreted as "HEAD", so that all VC steps can accept branch=None
3391 and have it mean the "default branch".
3393 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3395 2005-07-07 Brian Warner <warner@lothar.com>
3397 * docs/examples/twisted_master.cfg: update to match current usage
3399 * docs/buildbot.texinfo (System Architecture): comment out the
3400 image, it doesn't exist yet and just screws up the HTML manual.
3402 2005-07-05 Brian Warner <warner@lothar.com>
3404 * debian/.cvsignore: oops, missed one. Removing leftover file.
3406 2005-06-17 Brian Warner <warner@lothar.com>
3408 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3409 changed its output in 1.2.0, don't mistakenly think that the
3410 subversion we find isn't capable of supporting our tests.
3412 * debian/*: remove the debian/ directory and its contents, to make
3413 life easier for the proper Debian maintainer
3415 * Makefile (release): same
3417 2005-06-07 Brian Warner <warner@lothar.com>
3419 * everything: create a distinct SourceStamp class to replace the
3420 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3421 Changed the signature of Source.startVC to include the revision
3422 information (instead of passing it through self.args). Implement
3423 branches for SVN (now only Darcs/Git is missing support). Add more
3426 2005-06-06 Brian Warner <warner@lothar.com>
3428 * everything: rearrange build scheduling. Create a new Scheduler
3429 object (configured in c['schedulers'], which submit BuildSets to a
3430 set of Builders. Builders can now use multiple slaves. Builds can
3431 be run on alternate branches, either requested manually or driven
3432 by changes. This changed some of the Status classes. Interlocks
3433 are out of service until they've been properly split into Locks
3434 and Dependencies. treeStableTimer, isFileImportant, and
3435 periodicBuild have all been moved from the Builder to the
3437 (BuilderStatus.currentBigState): removed the 'waiting' and
3438 'interlocked' states, removed the 'ETA' argument.
3440 2005-05-24 Brian Warner <warner@lothar.com>
3442 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3443 erroneously abandons the connection (in clientConnectionFailed)
3444 for non-UserErrors, which means that if we lose the connection due
3445 to a network problem or a timeout, we'll never try to reconnect.
3446 Fix this by not upcalling to the buggy parent method. Note:
3447 twisted-2.0 fixes this, but the function only has 3 lines so it
3448 makes more sense to copy it than to try and detect the buggyness
3449 of the parent class. Fixes SF#1207588.
3451 * buildbot/changes/changes.py (Change.branch): doh! Add a
3452 class-level attribute to accomodate old Change instances that were
3453 pickled before 0.6.5 (where .branch was added for new Changes).
3454 This fixes the exception that occurs when you try to look at an
3455 old Change (through asHTML).
3457 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3460 2005-05-23 Brian Warner <warner@lothar.com>
3462 * buildbot/__init__.py (version): release 0.6.6
3464 2005-05-23 Brian Warner <warner@lothar.com>
3466 * NEWS: update for 0.6.6 release
3467 * debian/changelog: same
3469 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3470 before starting: this was done by twistd back when we spawned it,
3471 now that we're importing the pieces and running them in the
3472 current process, we have to do it ourselves. This allows
3473 master.cfg to import files from the same directory without
3474 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3475 Stichele for the catch.
3476 (Options.opt_version): Add a --version command (actually, just make
3477 the existing --version command emit Buildbot's version too)
3479 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3480 fix to make this behave like other LogFiles, this time to handle
3481 existing LogFiles on disk. (add the missing .upgrade method)
3482 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3484 2005-05-21 Brian Warner <warner@lothar.com>
3486 * buildbot/test/test_runner.py (Create.testMaster): match the
3487 rawstring change in runner.py:masterTAC
3489 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3490 TwistedWords is installed
3491 * buildbot/test/test_status.py: same, with TwistedMail
3493 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3494 some old, deprecated, and removed config keys). This should enable
3495 you to use the base buildbot functionality with Twisted-2.0.0 when
3496 you don't also have TwistedWeb and TwistedWords installed
3498 2005-05-20 Brian Warner <warner@lothar.com>
3500 * buildbot/scripts/runner.py (run): call sendchange(), not
3501 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3502 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3503 (stop): don't wait for process to die when sending SIGHUP
3504 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3505 directory name gets interpreted, which you don't want
3508 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3511 2005-05-18 Brian Warner <warner@lothar.com>
3513 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3515 2005-05-18 Brian Warner <warner@lothar.com>
3517 * README: update for 0.6.5
3518 * debian/changelog: same
3520 * buildbot/changes/changes.py: rename tag= to branch=, since
3521 that's how we're using it, and my design for the upcoming "build a
3522 specific branch" feature wants it. also, tag= was too CVS-centric
3523 * buildbot/changes/mail.py (parseSyncmail): same
3524 * buildbot/process/base.py (Build.isBranchImportant): same
3525 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3526 * docs/buildbot.texinfo (Attributes of Changes): same
3528 * NEWS: update tag=, update for upcoming release
3530 2005-05-17 Brian Warner <warner@lothar.com>
3532 * buildbot/scripts/runner.py (stop): actually poll once per
3533 second, instead of re-killing the poor daemon once per second.
3534 Sleep briefly (0.1s) before the first poll, since there's a good
3535 chance we can avoid waiting the full second if the daemon shuts
3536 down quickly. Also remove the sys.exit() at the end.
3537 (start): remove the unneighborly sys.exit()
3539 * Makefile: improve permission-setting to not kick Arch so badly
3541 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3542 default --keepalive=600, since it doesn't hurt very much, and it's
3543 a hassle to discover that you need it.
3544 * buildbot/test/test_runner.py (Create.testSlave): test it
3546 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3547 IRC bot about EXCEPTION
3549 * buildbot/status/client.py (PBListener): upcall more correctly
3551 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3552 an exception mark the overall build with EXCEPTION, not SUCCESS
3554 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3556 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3557 * Makefile: update some release-related stuff
3559 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3560 gets called when there isn't actually an active process, just end
3561 the Command instead of blowing up. I don't know how it gets into
3562 this state, but the twisted win32 buildslave will sometimes hang,
3563 and when it shakes its head and comes back, it thinks it's still
3564 running a Command. The next build causes this command to be
3565 interrupted, but the lack of self.process.pid breaks the interrupt
3568 * NEWS: document changes since the last release
3570 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3571 look for Makefile.buildbot instead of a bare Makefile . The
3572 'buildbot start' does not install this file, so you have to
3573 manually copy it if you want to customize startup behavior.
3574 (createMaster): change 'buildbot master' command to create
3575 Makefile.sample instead of Makefile, to create master.cfg.sample
3576 instead of master.cfg (requiring you to copy it before the
3577 buildmaster can be started). Both sample files are kept up to
3578 date, i.e. they are overwritten if they have been changed. The
3579 'buildbot.tac' file is *not* overwritten, but if the new contents
3580 don't match the old, a 'buildbot.tac.new' file is created and the
3581 user is warned. This seems to be a much more sane way to handle
3582 startup files. Also, don't sys.exit(0) when done, so we can run
3583 unit tests against it.
3584 (createSlave): same. Don't overwrite the sample info/ files.
3585 * buildbot/scripts/sample.mk: remove. the contents were pulled
3586 into runner.py, since they need to match the behavior of start()
3590 * docs/buildbot.texinfo (Launching the daemons): document it
3591 * buildbot/test/test_runner.py (Create): test it
3593 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3594 version that can handle string-in-string tests, because otherwise
3595 python-2.2 fails the tests. It'd be tremendous if Trial's test
3596 took two strings under 2.2 too.
3598 * everything: fixed all deprecation warnings when running against
3599 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3600 few that come from Twisted itself). This involved putting most of
3601 the Twisted-version specific code in the new buildbot.twcompat
3602 module, and creating some abstract base classes in
3603 buildbot.changes.base and buildbot.status.base (which might be
3604 useful anyway). __implements__ is a nuisance and requires an ugly
3605 'if' clause everywhere.
3607 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3608 delay before finishing the test: it seems that smtp.sendmail
3609 doesn't hang up on the server, so we must wait a moment so it can
3610 hang up on us. This removes the trial warning about an unclean
3613 2005-05-16 Brian Warner <warner@lothar.com>
3615 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3616 tuple of (delay, repeats).
3617 * buildbot/test/test_vc.py (Retry): test it
3618 * docs/buildbot.texinfo (Source Checkout): document it
3619 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3620 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3621 doVCFull() are handled by re-trying the checkout (after a delay)
3622 some number of times.
3623 (ShellCommand._startCommand): make header lines easier to read
3625 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3627 (WebTest.test_logfile): make sure master gets shut down, silences
3628 some "unclean reactor" test errors
3630 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3631 reactor once after shutdown, something in certain versions of
3632 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3633 fails, svn-trunk is ok.
3635 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3636 second win32 error message
3638 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3639 validating the ETA, so the tests don't fail on slow systems
3641 2005-05-15 Brian Warner <warner@lothar.com>
3643 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3644 the new LogFile class, so upgrading works properly
3645 (LogFileProducer.resumeProducing): survive resumeProducing after
3646 we've exhausted the chunkGenerator
3648 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3650 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3651 (Log.testUpgrade): same
3653 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3654 Builds and logs with a cron job.
3656 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3657 of the old non-offline LogFile, added code to upgrade these to
3658 new-style contents-live-on-disk instances at load time (in a way
3659 that doesn't invalidate the old Build pickles, so upgrading to
3660 0.6.5 is not a one-way operation). Got rid of everything related
3662 (LogFile.__init__): create LogFiles with the parent step status,
3663 the log's name, and a builder-relative filename where it can keep
3664 the contents on disk.
3665 (LogFile.hasContents): new method, clients are advised to call it
3666 before getText or getChunks and friends. If it returns False, the
3667 log's contents have been deleted and getText() will raise an
3669 (LogFile.getChunks): made it a generator
3670 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3671 Consumer (except one that takes chunks instead of strings). This
3672 enables streaming of very large logfiles without storing the whole
3674 (BuildStatus.generateLogfileName): create names like
3675 12-log-compile-output, with a _0 suffix if required to be unique
3676 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3677 or earlier) logfiles into new-style ones
3678 (BuilderStatus): remove everything related to 'stub' builds. There
3679 is now only one build cache, and we don't strip logs from old
3681 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3682 since we no longer fight to keep it in the cache
3684 * buildbot/status/html.py (TextLog.render_GET): use a
3685 ChunkConsumer to stream the log entries efficiently.
3686 (ChunkConsumer): wrapper which consumes chunks and writes
3689 * buildbot/test/test_twisted.py (Parse.testParse): use a
3690 LogFile-like object instead of a real one
3692 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3693 (Log.testMerge3): validate more merge behavior
3694 (Log.testChunks): validate LogFile.getChunks
3695 (Log.testUpgrade): validate old-style LogFile upgrading
3696 (Log.testSubscribe): validate LogFile.subscribe
3697 (Log.testConsumer): validate LogFile.subscribeConsumer
3699 * buildbot/interfaces.py (IStatusLogStub): remove
3700 (IStatusLog.subscribeConsumer): new method
3701 (IStatusLog.hasContents): new method
3702 (IStatusLogConsumer): describes things passed to subscribeConsumer
3704 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3705 the log contents if it does not have any contents.
3706 (StatusResourceBuildStep.body): same
3707 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3709 2005-05-14 Brian Warner <warner@lothar.com>
3711 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3712 timeouts to try and make the windows metabuildslave not hang
3714 2005-05-13 Mike Taylor <bear@code-bear.com>
3716 * buildbot/slave/commands.py (rmdirRecursive): added a check
3717 to ensure the path passed into rmdirRecursive actually exists.
3718 On win32 a non-existant path would generate an exception.
3720 2005-05-13 Brian Warner <warner@lothar.com>
3722 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3723 shutil.rmtree which behaves correctly on windows in the face of
3724 files that you have to chmod before deleting. Thanks to Bear at
3725 the OSAF for the routine.
3726 (SourceBase.doClobber): use rmdirRecursive
3728 2005-05-12 Brian Warner <warner@lothar.com>
3730 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3731 method generate chunks instead of returning a big list. This
3732 allows the same method to be used for both old LogFile and new
3734 (OfflineLogFile.getText): use the generator
3735 (OfflineLogFile.subscribe): same
3736 * buildbot/status/html.py (TextLog.resumeProducing): same
3737 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3739 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3740 point out that OfflineLogFile does not currently work with
3741 html.Waterfall . Fixing this is high-priority.
3743 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3744 apparently windows defaults to using stdout
3746 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3747 better message on failure so I can figure out the win32 problem
3749 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3750 log messages to include more useful copies of the command being
3751 run, the argv array, and the child command's environment.
3752 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3754 2005-05-11 Brian Warner <warner@lothar.com>
3756 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3758 * Makefile: update the deb-snapshot version
3760 * docs/buildbot.texinfo: move all .xhtml docs into a new
3761 .texinfo-format document, adding a lot of material in the process.
3762 This is starting to look like a real user's manual. Removed all
3763 the Lore-related files: *.xhtml, *.css, template.tpl .
3764 * docs/Makefile: simple makefile to run 'makeinfo'
3765 * buildbot/scripts/sample.cfg: rearrange slightly
3766 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3768 2005-05-10 Brian Warner <warner@lothar.com>
3770 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3771 different name for the internal twistw module, handle it.
3773 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3774 * setup.py: .. and stop trying to install it
3776 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3777 'git'), the new linux kernel VC system (http://kernel.org/git/).
3778 Thanks to Brandon Philips for the patch.
3779 * buildbot/slave/commands.py (Git): same
3781 2005-05-06 Brian Warner <warner@lothar.com>
3783 * buildbot/status/builder.py (OfflineLogFile): replace the default
3784 LogFile with a form that appends its new contents to a disk file
3785 as they arrive. The complete log data is never kept in RAM. This
3786 is the first step towards handling very large (100MB+) logfiles
3787 without choking quite so badly. (The other half is
3788 producer/consumer on the HTML pages).
3789 (BuildStepStatus.addLog): use OfflineLogFile by default
3790 (BuildStatus.getLogfileName): helper code to give the
3791 OfflineLogFile a filename to work with
3793 * buildbot/test/test_status.py (Results.testAddResults): update
3794 tests to handle new asserts
3795 * buildbot/test/test_vc.py (Patch.doPatch): same
3796 * buildbot/test/test_steps.py (BuildStep.setUp): same
3798 2005-05-05 Brian Warner <warner@lothar.com>
3800 * buildbot/scripts/runner.py (start): if there is no Makefile,
3801 launch the app by importing twistd's internals and calling run(),
3802 rather than spawning a new twistd process. This stands a much
3803 better chance of working under windows.
3804 (stop): kill the process with os.kill instead of spawning
3805 /bin/kill, again to reduce the number of external programs which
3806 windows might not have in the PATH. Also wait up to 5 seconds for
3807 the process to go away, allowing things like 'buildbot stop;
3808 buildbot start' to be reliable in the face of slow shutdowns.
3810 * buildbot/master.py (Dispatcher.__getstate__): remove old
3811 .tap-related methods
3812 (BuildMaster.__getstate__): same
3814 * buildbot/slave/bot.py (makeService): same
3815 (Options.longdesc): same
3816 * buildbot/scripts/runner.py: copy over some old mktap option text
3818 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3819 'buildbot master' now creates a buildbot.tac file, so there is no
3820 longer a create-instance/save/reload sequence. mktap is dead, long
3822 * buildbot/scripts/sample.mk: use twistd -y, not -f
3823 * buildbot/test/test_config.py: remove mktap-based test
3824 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3825 * README: don't reference mktap
3827 * docs/source.xhtml: document some of the attributes that Changes
3830 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3832 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3833 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3834 * buildbot/changes/changes.py (Change)
3835 * buildbot/changes/mail.py (parseSyncmail)
3836 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3838 * buildbot/process/base.py (Build.isTagImportant)
3842 2005-05-04 Brian Warner <warner@lothar.com>
3844 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3845 connection after sending the change, so that unit tests don't
3846 complain about sockets being left around
3848 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3849 exception in phase=0 rendering
3850 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3852 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3854 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3855 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3856 and configuring builders with tuples.
3857 * buildbot/test/test_config.py: stop testing compatibility with
3858 deprecated config keys
3859 * buildbot/test/test_run.py: same
3861 2005-05-03 Brian Warner <warner@lothar.com>
3863 * contrib/arch_buildbot.py: survive if there are no logfiles
3864 (username): just use a string, os.getlogin isn't reliable
3866 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3867 so 'buildbot sendchange' actually works. The earlier test only
3868 covered the internal (non-reactor-running) form.
3870 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3871 script to notify the buildmaster about changes
3873 * buildbot/scripts/runner.py (sendchange): new command to send a
3874 change to a buildbot.changes.pb.PBChangeSource receiver.
3875 * buildbot/test/test_changes.py (Sender): test it
3877 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3878 after any reading of the config file, not just when we do it in
3879 startService. This makes some tests a bit cleaner.
3881 * buildbot/changes/pb.py: add some log messages
3883 * buildbot/process/base.py (Build.startBuild): fix a bug that
3884 caused an exception when the build terminated in the very first
3886 (Build.stepDone): let steps return a status of EXCEPTION. This
3887 terminates the build right away, and sets the build's overall
3888 status to EXCEPTION too.
3889 * buildbot/process/step.py (BuildStep.failed): return a status of
3890 EXCEPTION when that is what has happened.
3892 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3893 implement this, allowing Arch-based projects to get precise
3894 checkouts instead of always using the latest code
3895 (Bazaar): create variant of Arch to let folks use baz instead of
3896 tla. Requires a new buildslave too.
3897 * buildbot/slave/commands.py (Arch): add 'revision' argument
3898 (Bazaar): create variant of Arch that uses baz instead of tla.
3899 Remove the code that extracts the archive name from the
3900 register-archive output, since baz doesn't provide it, and require
3901 the user provide both the archive name and its location.
3902 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3904 2005-05-02 Brian Warner <warner@lothar.com>
3906 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3907 thanks to Nick Trout.
3909 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3910 deals better with source Makefile coming from a read-only CVS
3911 checkout. Thanks to Nick Trout for the catch.
3913 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3916 2005-04-28 Brian Warner <warner@lothar.com>
3918 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3920 * debian/changelog: update for 0.6.4
3922 2005-04-28 Brian Warner <warner@lothar.com>
3924 * README.w32: add a checklist of steps for getting buildbot
3926 * MANIFEST.in: include it in the tarball
3930 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3931 broken .tap files from 0.6.3 by getting rid of .services,
3932 .namedServices, and .change_svc at load time.
3934 2005-04-27 Brian Warner <warner@lothar.com>
3936 * NEWS: update in preparation for new release
3938 * buildbot/test/test_config.py (Save.testSave): don't pull in
3939 twisted.scripts.twistd, we don't need it and it isn't for windows
3942 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3943 accomodate win32 which can't do atomic-rename
3945 2005-04-27 Brian Warner <warner@lothar.com>
3947 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3948 timeouts to help the slow metabuildbot not flunk them so much
3949 (Disconnect.testBuild3): same
3950 (Disconnect.testBuild4): same
3951 (Disconnect.testInterrupt): same
3953 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3954 setup, it was completely broken for new buildmasters (those which
3955 did not have a 'change.pck' already saved. Thanks to Paul Warren
3956 for catching this (embarrassing!) bug.
3957 (Dispatcher.__getstate__): don't save our registered avatar
3958 factories, since they'll be re-populated when the config file is
3960 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3961 tests (since the real mktap-generated BuildMaster doesn't save
3963 (BuildMaster.__getstate__): don't save any service children,
3964 they'll all be re-populated when the config file is re-read.
3965 * buildbot/test/test_config.py (Save.testSave): test for this
3967 2005-04-26 Brian Warner <warner@lothar.com>
3969 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3970 rendered with Blender.. looks a bit nicer.
3971 * buildbot/docs/images/icon.blend: add the Blender file for it
3973 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3974 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3975 running under windows. This appears to be the best way to allow
3976 BuildSteps to do something normal like 'trial -v buildbot.test' or
3977 'make foo' and still expect it to work. The idea is to make the
3978 BuildSteps look as much like what a developer would type when
3979 compiling or testing the tree by hand. This approach probably has
3980 problems when there are spaces in the arguments, so if you've got
3981 windows buildslaves, you'll need to pay close attention to your
3984 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3985 timezone to the timestamp column.
3986 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3988 * buildbot/scripts/runner.py (loadOptions): do something sane for
3989 windows, I think. We use %APPDATA%/buildbot instead of
3990 ~/.buildbot, but we still search everywhere from the current
3991 directory up to the root for a .buildbot/ subdir. The "is it under
3992 $HOME" security test was replaced with "is it owned by the current
3993 user", which is only performed under posix.
3994 * buildbot/test/test_runner.py (Options.testFindOptions): update
3995 tests to match. The "is it owned by the current user" check is
3996 untested. The test has been re-enabled for windows.
3998 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3999 any "\n" in the expected output with the platform-specific line
4000 separator. Make this separator "\r\n" on PTYs under unix, they
4001 seem to do that and I don't know why
4003 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4004 windows for now, I don't know what ~/.buildbot/ should mean there.
4006 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4007 win32 compatibility, don't use "/tmp"
4008 (Basedir.testChangeBuilddir): remove more unixisms
4010 2005-04-26 Brian Warner <warner@lothar.com>
4012 * buildbot/test/test_control.py (Force.rmtree): python2.2
4013 compatibility, apparently its shutil.rmtree ignore_errors=
4014 argument is ignored.
4015 * buildbot/test/test_run.py (Run.rmtree): same
4016 (RunMixin.setUp): same
4018 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4021 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4022 'substring in string' operator, must use string.find(substr)!=-1
4023 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4024 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4026 * buildbot/scripts/runner.py (loadOptions): add code to search for
4027 ~/.buildbot/, a directory with things like 'options', containing
4028 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4029 the current directory, your $HOME directory, or anywhere
4030 inbetween, as long as you're somewhere inside your home directory.
4031 (debugclient): look in ~/.buildbot/options for master and passwd
4032 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4033 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4035 * buildbot/status/client.py (makeRemote): new approach to making
4036 IRemote(None) be None, which works under Twisted-2.0
4037 * buildbot/test/test_status.py (Client.testAdaptation): test it
4039 * buildbot/status/builder.py (Status.builderAdded): when loading a
4040 pickled BuilderStatus in from disk, set its name after loading.
4041 The config file might have changed its name (but not its
4042 directory) while it wasn't looking.
4044 * buildbot/process/builder.py (Builder.attached): always return a
4045 Deferred, even if the builder was already attached
4046 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4048 2005-04-25 Brian Warner <warner@lothar.com>
4050 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4051 category-related exception when announcing a build has finished
4053 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4054 reference no-longer-existent changemaster.sources
4055 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4057 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4060 2005-04-25 Brian Warner <warner@lothar.com>
4062 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4064 * debian/changelog: update for 0.6.3
4066 2005-04-25 Brian Warner <warner@lothar.com>
4068 * MANIFEST.in: make sure debug.glade is in the tarball
4070 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4072 * NEWS: update for the imminent 0.6.3 release
4074 * buildbot/status/html.py (HtmlResource.content): make the
4075 stylesheet <link> always point at "buildbot.css".
4076 (StatusResource.getChild): map "buildbot.css" to a static.File
4077 containing whatever css= argument was provided to Waterfall()
4078 (Waterfall): provide the "classic" css as the default.
4079 * docs/waterfall.classic.css: move default CSS from here ..
4080 * buildbot/status/classic.css: .. to here
4082 * MANIFEST.in: make sure classic.css is included in the tarball
4083 * setup.py: and that it is installed too, under buildbot/status/
4085 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4086 the module level, because buildbot.tap files from 0.6.2 don't have
4087 it in their attribute dictionary.
4089 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4090 really exists at startup, might save some confusion somewhere.
4092 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4094 * docs/waterfall.classic.css:
4095 add a stylesheet that's almost the same as the "classic"
4098 * buildbot/status/builder.py:
4099 add EXCEPTION as a result - this is a problem for the bot
4100 maintainer, not a build problem for the changers
4101 * buildbot/process/step.py:
4102 use EXCEPTION instead of FAILURE for exceptions
4103 * buildbot/status/html.py:
4104 add build_get_class to get a class out of a build/buildstep
4105 finish naming the classes
4106 split out sourceNames to changeNames and builderNames so we
4107 can style them separately
4108 * docs/config.xhtml:
4109 finish documenting classes as they are right now
4111 * buildbot/status/html.py:
4112 name the classes as we agreed on IRC
4113 * docs/config.xhtml:
4116 * buildbot/status/html.py:
4117 same for cssclass->class_
4119 * buildbot/status/html.py:
4120 as decided on IRC, use class_ for the "class" attribute to not
4121 conflict with the class keyword, and clean up the messy **{} stuff.
4123 * buildbot/status/mail.py:
4124 put back "builders" argument, and fix docstring, because the
4125 code *ignores* builders listed in this argument
4127 * buildbot/process/builder.py:
4128 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4130 * docs/config.xhtml:
4131 describe the category argument for builders
4133 * buildbot/status/builder.py:
4134 Fix a silly bug due to merging
4136 * buildbot/process/builder.py:
4137 remove category from the process Builder ...
4138 * buildbot/status/builder.py:
4139 ... and add it to BuilderStatus instead.
4140 Set category on unpickled builder statuses, they might not have it.
4141 * buildbot/master.py:
4142 include category when doing builderAdded
4143 * buildbot/status/mail.py:
4144 return None instead of self for builders we are not interested in.
4145 * buildbot/test/test_run.py:
4146 fix a bug due to only doing deferredResult on "dummy" waiting
4147 * buildbot/test/test_status.py:
4148 add checks for the Mail IStatusReceiver returning None or self
4150 * buildbot/status/html.py:
4151 fix testsuite by prefixing page title with BuildBot
4153 * buildbot/status/builder.py:
4154 have .category in builder status ...
4155 * buildbot/process/builder.py:
4156 ... and set it from Builder
4157 * buildbot/status/html.py:
4158 make .css a class variable
4159 * buildbot/test/test_status.py:
4160 write more tests to cover our categories stuff ...
4161 * buildbot/status/mail.py:
4162 ... and fix the bug that this uncovered
4164 * buildbot/changes/mail.py:
4165 * buildbot/changes/pb.py:
4166 * buildbot/master.py:
4167 * buildbot/process/base.py:
4168 * buildbot/process/factory.py:
4169 * buildbot/process/interlock.py:
4170 * buildbot/process/step.py:
4171 * buildbot/process/step_twisted.py:
4172 * buildbot/slave/commands.py:
4173 * buildbot/status/builder.py:
4174 * buildbot/status/client.py:
4175 * buildbot/status/html.py:
4176 * buildbot/status/mail.py:
4177 * buildbot/status/progress.py:
4178 * buildbot/test/test_changes.py:
4179 * buildbot/test/test_config.py:
4180 * buildbot/test/test_control.py:
4181 * buildbot/test/test_interlock.py:
4182 * buildbot/test/test_maildir.py:
4183 * buildbot/test/test_mailparse.py:
4184 * buildbot/test/test_run.py:
4185 * buildbot/test/test_slavecommand.py:
4186 * buildbot/test/test_status.py:
4187 * buildbot/test/test_steps.py:
4188 * buildbot/test/test_twisted.py:
4189 * buildbot/test/test_util.py:
4190 * buildbot/test/test_vc.py:
4191 * buildbot/test/test_web.py:
4193 add test-case-name at the top of a whole set of files
4195 * buildbot/status/builder.py:
4196 keep order of addition when getting builder names
4197 * buildbot/status/words.py:
4198 * buildbot/test/test_run.py:
4199 add test for getBuilderNames
4201 * buildbot/process/base.py:
4202 * buildbot/process/step.py:
4203 * buildbot/status/builder.py:
4204 * buildbot/status/html.py:
4205 make buildbot css-able
4206 replace the color code for purple with purple, don't understand
4207 why it wasn't purple to start with
4209 * buildbot/status/words.py:
4210 ok, so it doesn't look like BuilderStatus.remote is still valid.
4211 Use what waterfall uses instead.
4213 * buildbot/interfaces.py:
4214 * buildbot/status/builder.py:
4215 * buildbot/status/html.py:
4216 * buildbot/status/mail.py:
4217 * buildbot/status/words.py:
4218 * buildbot/test/test_run.py:
4219 use categories everywhere and make it be a list. More sensible
4220 for the future. Also make words actually respect this in
4223 * buildbot/interfaces.py:
4224 add category argument to getBuilderNames
4225 * buildbot/process/builder.py:
4226 * buildbot/status/builder.py:
4227 * buildbot/status/html.py:
4228 * buildbot/status/mail.py:
4229 * buildbot/status/words.py:
4230 * buildbot/test/test_run.py:
4231 move from specifying builders by name to specifying the category
4233 * buildbot/status/html.py:
4234 * buildbot/status/words.py:
4235 add "builders=" to __init__ of status clients so they can
4236 limit themselves to the given list of builders to report on
4238 * buildbot/status/html.py: set the title to the product name
4240 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4242 * buildbot/interfaces.py:
4243 * buildbot/status/builder.py:
4244 more documentation. Hm, not sure if ChangeLog entries make sense
4247 2005-04-23 Brian Warner <warner@lothar.com>
4249 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4251 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4253 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4254 the sub-commands that log buildmaster status to stdout and to a
4255 GUI window, respectively.
4257 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4258 functionality is working again, but all the step-status and ETA
4259 stuff is missing. Commented out a lot of code pending more
4262 * buildbot/status/client.py: make sure that IRemote(None) is None
4264 * buildbot/changes/changes.py: import defer, oops
4265 (ChangeMaster): remove the .sources list, rely upon the fact that
4266 MultiServices can be treated as sequences of their children. This
4267 cleans up the add/remove ChangeSource routines a lot, as we keep
4268 exactly one list of the current sources instead of three.
4270 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4271 up an empty ChangeMaster at init time.
4272 (BuildMaster.loadChanges): if there are changes to be had from
4273 disk, replace self.change_svc with the new ones. If not, keep
4274 using the empty ChangeMaster set up in __init__.
4275 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4276 instead of a separate list, makes the code a bit cleaner.
4277 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4278 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4279 Extend the test to make sure we can get rid of the sources when
4282 2005-04-22 Brian Warner <warner@lothar.com>
4284 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4285 and info/host files when making the slave directory
4287 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4288 whendone= argument, just return the Deferred and let the caller do
4289 what they want with it.
4290 (Disconnect.testBuild1): wait for shutdownSlave
4291 (Basedir.testChangeBuilddir): new test to make sure changes to the
4292 builddir actually get propagated to the slave
4294 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4295 explicit method, rather than passing the builddir in __init__ .
4296 Make sure to update self.basedir too, this was broken before.
4297 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4298 builders and for ones that have just had their builddir changed.
4299 (BotFactory): add a class-level .perspective attribute, so
4300 BuildSlave.waitUntilDisconnected won't get upset when the
4301 connection hasn't yet been established
4302 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4303 tests can reach through it to inspect the SlaveBuilders
4305 * buildbot/process/base.py (Build.buildException): explain the
4306 log.err with a log.msg
4307 * buildbot/process/builder.py (Builder.startBuild): same
4308 (Builder._startBuildFailed): improve error message
4310 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4311 occurred because we lost the brand-new connection, retry instead
4312 of giving up. If not, it's probably an authorization failure, and
4313 it makes sense to stop trying. Make sure we log.msg the reason
4314 that we're log.err'ing the failure, otherwise test failures are
4315 really hard to figure out.
4317 * buildbot/master.py: change loadConfig() to return a Deferred
4318 that doesn't fire until the change has been fully implemented.
4319 This means any connected slaves have been updated with the new
4320 builddir. This change makes it easier to test the code which
4321 actually implements this builddir-updating.
4322 (BotPerspective.addBuilder): return Deferred
4323 (BotPerspective.removeBuilder): same
4324 (BotPerspective.attached): same
4325 (BotPerspective._attached): same. finish with remote_print before
4326 starting the getSlaveInfo, instead of doing them in parallel
4327 (BotPerspective.list_done): same
4328 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4329 actually calling slave.disconnect()
4330 (BotMaster.addBuilder): same
4331 (BotMaster.removeBuilder): same
4332 (BuildMaster.loadConfig): same
4333 (BuildMaster.loadConfig_Slaves): same
4334 (BuildMaster.loadConfig_Sources): same
4335 (BuildMaster.loadConfig_Builders): same
4336 (BuildMaster.loadConfig_status): same
4338 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4339 a Deferred that fires when the source is finally removed
4341 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4342 the previous tree on win32, where we have to do it synchronously,
4343 make sure we return a Deferred anyway.
4344 (SourceBase.doCopy): same
4346 * buildbot/scripts/runner.py (statusgui): use the text client for
4347 now, while I rewrite the Gtk one
4348 * buildbot/clients/base.py: strip out old code, leaving just the
4349 basic print-message-on-event functionality. I also remove the
4350 ReconnectingPBClientFactory, but it does at least quit when it
4351 loses the connection instead of going silent
4353 2005-04-21 Brian Warner <warner@lothar.com>
4355 * Makefile: minor tweaks
4357 * NEWS: point out deprecation warnings, new features for
4360 * buildbot/master.py (BuildMaster.loadConfig): emit
4361 DeprecationWarnings for Builders defined with tuples. Rearrange
4362 code to facility removal of deprecated configuration keys in the
4365 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4366 'buildbot' command to put a little Makefile in the target that
4367 helps you re-create the buildbot.tap file, start or stop the
4368 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4369 all the files 0600, since they contain passwords.
4370 (start): if there is a Makefile, and /usr/bin/make exists, use
4371 'make start' in preference to a raw twistd command. This lets
4372 slave admins put things like PYTHONPATH variables in their
4373 Makefiles and have them still work when the slave is started with
4374 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4375 be nice to first try the 'make' command and only fall back to
4376 twistd if it fails. TODO: the Makefile's "start" command does not
4377 add the --reactor=win32 argument when running under windows.
4378 (Options.debugclient, Options.statusgui): add sub-commands to launch
4379 the debug client (formerly in contrib/debugclient.py) and the
4380 Gtk status application (currently broken)
4381 * buildbot/clients/debug.py: move from contrib/debugclient.py
4382 * buildbot/clients/debug.glade: same
4384 * buildbot/test/test_trial.py: remove it. This requires some
4385 functionality out of Twisted that isn't there yet, and until then
4386 having it around just confuses things.
4388 * buildbot/test/test_slavecommand.py (Shell): test both with and
4389 without PTYs, and make sure that command output is properly
4390 interleaved in the with-PTY case. I think the without-PTY test
4391 should pass on windows, where we never use PTYs anyway.
4393 2005-04-20 Brian Warner <warner@lothar.com>
4395 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4397 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4399 * NEWS: start creating entries for the next release
4401 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4403 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4404 (WebTest.test_webPathname): same
4405 (WebTest.test_webPathname_port): same
4406 (WebTest.test_waterfall): use the default favicon rather than
4407 rooting around the filesystem for it. Open the expected-icon file
4408 in binary mode, to make win32 tests happier (thanks to Nick Trout
4410 * buildbot/status/html.py (buildbot_icon): win32 portability
4412 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4413 win32-compatibility fixes from Nick Trout, the "file not found" message
4414 is different under windows
4415 (FakeSlaveBuilder.__init__): clean up setup a bit
4416 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4418 2005-04-19 Brian Warner <warner@lothar.com>
4420 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4421 skip-if-repositories-are-unavailable test to not kill the trial
4422 that comes with Twisted-1.3.0
4424 * setup.py: install buildbot.png icon file when installing code
4426 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4427 environment used by the command, at least on the child side.
4429 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4430 this method needs to be added and implemented because it gets
4431 called under heavy load. I don't quite understand the
4432 producer/consumer API enough to write it.
4433 (StatusResource.getChild): add a resource for /favicon.ico
4434 (Waterfall.__init__): add favicon= argument
4435 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4436 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4437 (WebTest.test_webPathname): same
4438 (WebTest.test_webPathname_port): same
4439 * docs/config.xhtml: mention favicon=
4440 * buildbot/buildbot.png: add a default icon, dorky as it is
4442 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4444 * buildbot/master.py:
4445 * buildbot/process/base.py:
4446 * buildbot/process/builder.py:
4447 * buildbot/process/interlock.py:
4448 * buildbot/status/builder.py:
4449 * buildbot/status/html.py:
4450 * buildbot/status/mail.py:
4451 * buildbot/status/words.py:
4452 new documentation while digging through the code
4454 2005-04-17 Brian Warner <warner@lothar.com>
4456 * general: try to fix file modes on all .py files: a+r, a-x,
4457 but let buildbot/clients/*.py be +x since they're tools
4459 * docs/epyrun (addMod): when an import fails, say why
4461 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4463 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4465 * buildbot/process/base.py:
4466 * buildbot/process/builder.py:
4467 * buildbot/status/builder.py:
4468 new documentation while digging through the code
4470 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4472 * buildbot/changes/changes.py:
4473 * buildbot/changes/p4poller.py:
4474 * buildbot/interfaces.py:
4475 * buildbot/process/base.py:
4476 * buildbot/process/builder.py:
4477 * buildbot/process/step.py:
4478 * buildbot/process/step_twisted.py:
4479 * buildbot/slave/bot.py:
4480 * buildbot/slave/commands.py:
4481 * buildbot/status/builder.py:
4482 fix all docstrings to make epydoc happy. In the process of fixing
4483 some, I also moved pieces of docs, and removed some deprecated
4486 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4488 * buildbot/process/builder.py:
4489 * buildbot/process/interlock.py:
4490 * buildbot/process/process_twisted.py:
4491 * buildbot/process/step.py:
4492 BuildProcess -> Build, as it looks like that's what happened
4493 * buildbot/process/base.py:
4494 * buildbot/process/factory.py:
4497 2005-04-17 Brian Warner <warner@lothar.com>
4499 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4500 update compile command to accomodate the Twisted split.. now
4501 instead of './setup.py build_ext -i', you do './setup.py all
4502 build_ext -i', to run build_ext over all sub-projects.
4503 (FullTwistedBuildFactory): same
4504 (TwistedReactorsBuildFactory): same
4506 * buildbot/status/html.py (TextLog.finished): null out self.req
4507 when we're done, otherwise the reference cycle of TextLog to .req
4508 to .notifications to a Deferred to TextLog.stop keeps them from
4509 being collected, and consumes a huge (610MB on pyramid at last
4510 check) amount of memory.
4512 2005-04-11 Brian Warner <warner@lothar.com>
4514 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4515 normalize the VC-repository location.. makes SVN happier with
4516 certain test environments.
4518 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4519 RemoteShellCommand gets its own .env dictionary, so that code in
4520 start() doesn't mutate the original. I think this should fix the
4521 step_twisted.Trial problem where multiple identical components
4522 kept getting added to PYTHONPATH= over and over again.
4524 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4525 adding epydoc-format docstrings to many classes. Thanks to Thomas
4526 Vander Stichele for the patches.
4527 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4528 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4529 * buildbot/slave/bot.py, commands.py, registry.py: same
4531 2005-04-05 Brian Warner <warner@lothar.com>
4533 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4534 preserve timestamps, helps incremental builds of large trees.
4535 Patch from Rene Rivera.
4537 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4538 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4541 2005-04-03 Brian Warner <warner@lothar.com>
4543 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4544 with one dict, apparently exec has some scoping bugs when used
4545 with both global/local dicts. Thanks to Nathaniel Smith for the
4548 2005-04-02 Brian Warner <warner@lothar.com>
4550 * buildbot/process/step_twisted.py (countFailedTests): the new
4551 trial in Twisted-2.0 emits a slightly different status line than
4552 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4553 mistakenly think the test count is unparseable.
4554 (Trial.start): note that for some reason each build causes another
4555 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4556 be fixed but I'm not sure quite where the problem is.
4558 2005-04-01 Brian Warner <warner@lothar.com>
4560 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4561 deferredResult to avoid hangs/warnings under twisted-2.0
4562 (RunMixin.tearDown): same
4563 (RunMixin.shutdownSlave): same
4564 (Disconnect.testIdle1): same
4565 (Disconnect.testBuild2): same: wait one second after the build
4566 finishes for test to really be done.. this should be cleaned up to
4567 avoid wasting that second. Builder.detach uses a callLater(0),
4568 either that should be done in-line (something else needed that
4569 behavior), or it should return a Deferred that fires when the
4570 builder is really offline.
4571 (Disconnect.testBuild3): same
4572 (Disconnect.testDisappear): same
4574 * buildbot/test/test_web.py: rearrange server-setup and teardown
4575 code to remove unclean-reactor warnings from twisted-2.0
4577 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4578 so the tests don't hang under twisted-2.0
4580 2005-03-31 Brian Warner <warner@lothar.com>
4582 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4583 caused a warning each time the master changed our set of builders
4585 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4586 w32, don't unlink the file unless it already exists. Thanks to
4587 Baptiste Lepilleur for the catch.
4588 (BuilderStatus.saveYourself): same
4590 2005-02-01 Brian Warner <warner@lothar.com>
4592 * buildbot/status/html.py (TextLog.getChild): use a /text child
4593 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4594 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4595 logfile as text/plain (no markup, no headers). This replaces the
4596 previous scheme (which used an ?text=1 argument), and gets us back
4597 to a relative link (which works better when the buildbot lives
4598 behind another web server, such as Apache configured as a reverse
4599 proxy). Thanks to Gerald Combs for spotting the problem.
4601 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4604 2004-12-13 Brian Warner <warner@lothar.com>
4606 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4608 * debian/changelog: update for 0.6.2
4609 * NEWS: finalize for 0.6.2
4611 2004-12-11 Brian Warner <warner@lothar.com>
4613 * NEWS: bring it up to date
4615 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4616 detection code. Require some sign of life from the buildmaster
4617 every BotFactory.keepaliveInterval seconds. Provoke this
4618 indication at BotFactory.keepaliveTimeout seconds before the
4619 deadline by sending a keepalive request. We don't actually care if
4620 that request is answered in a timely fashion, what we care about
4621 is that .activity() is called before the deadline. .activity() is
4622 triggered by any PB message from the master (including an ack to
4623 one of the slave's status-update messages). With this new scheme,
4624 large status messages over slow pipes are OK, as long as any given
4625 message can be sent (and thus acked) within .keepaliveTimeout
4626 seconds (which defaults to 30).
4627 (SlaveBuilder.remote_startCommand): record activity
4628 (SlaveBuilder.ackUpdate): same
4629 (SlaveBuilder.ackComplete): same
4630 (BotFactory.gotPerspective): same
4631 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4633 2004-12-09 Brian Warner <warner@lothar.com>
4635 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4638 * buildbot/process/step_twisted.py (Trial._commandComplete):
4639 update self.cmd when we start the 'cat test.log' transfer. Without
4640 this, we cannot interrupt the correct RemoteCommand when we lose
4643 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4644 trying to tell the slave to stop the command if we're already
4645 inactive, or if we no longer have a .remote
4647 * buildbot/process/builder.py (Builder._detached): don't let an
4648 exception in currentBuild.stopBuild() prevent the builder from
4649 being marked offline
4651 2004-12-07 Brian Warner <warner@lothar.com>
4653 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4654 KeyError that happens when you ask for a non-existent Builder, and
4655 translate it into a UsageError.
4657 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4658 losing the slave in the middle of a remote step is handled too
4660 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4661 be a Failure, so be sure to stringify it before using it as the
4662 contents of the 'interrupt' logfile
4663 (RemoteCommand.interrupt): use stringified 'why' in
4664 remote_interruptCommand too, just in case
4666 2004-12-06 Brian Warner <warner@lothar.com>
4668 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4669 instead of 'tla update', which is more efficient in case we've
4670 missed a couple of patches since the last update.
4672 * debian/changelog: update for previous (0.6.1) release. Obviously
4673 this needs to be handled better.
4675 2004-12-05 Brian Warner <warner@lothar.com>
4677 * NEWS: update for stuff since last release
4679 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4680 match the maybeDeferred change in Dispatcher.requestAvatar
4681 * buildbot/changes/pb.py (ChangePerspective.attached): same
4682 * buildbot/status/client.py (StatusClientPerspective.attached): same
4683 * buildbot/process/builder.py (Builder._attached3): same
4684 * buildbot/pbutil.py (NewCredPerspective.attached): same
4686 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4687 the date to the top-most box, if it is not the same as today's
4690 * docs/slave.xhtml: provide a buildslave setup checklist
4692 * docs/source.xhtml (Arch): correct terminology
4694 2004-12-04 Brian Warner <warner@lothar.com>
4696 * buildbot/test/test_slavecommand.py: use sys.executable instead
4697 of hard-coding 'python' for child commands, might help portability
4699 * docs/examples/twisted_master.cfg: update to current usage
4701 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4702 'stop build' command to the IRC bot
4704 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4705 message that broke PBChangeSource
4707 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4708 (SlaveBuilder): make some attributes class-level, remove the old
4709 "update queue" which existed to support resuming a build after the
4710 master connection was lost. Try to reimplement that feature later.
4711 (SlaveBuilder.stopCommand): clear self.command when the
4712 SlaveCommand finishes, so that we don't try to kill a leftover one
4714 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4717 * buildbot/slave/commands.py (SourceBase): set self.command for
4718 all VC commands, so they can be interrupted.
4720 2004-12-03 Brian Warner <warner@lothar.com>
4722 * buildbot/master.py: clean up slave-handling code, to handle
4723 slave-disconnect and multiple-connect better
4724 (BotPerspective): make these long-lasting, exactly one per bot
4725 listed in the config file.
4726 (BotPerspective.attached): if a slave connects while an existing
4727 one appears to still be connected, disconnect the old one first.
4728 (BotPerspective.disconnect): new method to forcibly disconnect a
4729 buildslave. Use some hacks to empty the transmit buffer quickly to
4730 avoid the long (20-min?) TCP timeout that could occur if the old
4731 slave has dropped off the net.
4732 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4733 own their own SlaveStatus objects. Remove .attached/.detached, add
4734 .addSlave/.removeSlave, treat slaves like Builders (config file
4735 parsing sends deltas to the BotMaster). Inform the slave
4736 instances, i.e. the BotPerspective, about addBuilder and
4738 (BotMaster.getPerspective): turns into a single dict lookup
4739 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4740 which gives BotPerspective.attached a chance to disconnect the old
4742 (BuildMaster.loadConfig): add code (disabled) to validate that all
4743 builders use known slaves (listed in c['bots']). The check won't
4744 work with tuple-specified builders, which are deprecated but not
4745 yet invalid, so the check is disabled for now.
4746 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4747 routine, do the add/changed/removed dance with them like we do
4749 (BuildMaster.loadConfig_Sources): move source-config into a
4750 separate routine too
4752 * buildbot/status/builder.py (Status.getSlave): get the
4753 SlaveStatus object from the BotPerspective, not the BotMaster.
4755 * buildbot/test/test_run.py: bunch of new tests for losing the
4756 buildslave at various points in the build, handling a slave that
4757 connects multiple times, and making sure we can interrupt a
4760 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4761 something other than 'Bot' for the Bot object, to make certain
4762 test cases easier to write.
4763 (BuildSlave.waitUntilDisconnected): utility method for testing
4765 2004-11-30 Brian Warner <warner@lothar.com>
4767 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4769 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4770 argument, return a Deferred that always fires with True or False.
4771 I don't use an errback to indicate 'ping failed' so that callers
4772 are free to ignore the deferred without causing spurious errors in
4774 * buildbot/process/builder.py (BuilderControl.ping): implement it
4776 * buildbot/test/test_run.py (Status.testDisappear): test ping
4777 (Status.disappearSlave): fix it
4779 2004-11-30 Brian Warner <warner@lothar.com>
4781 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4782 (IBuilderControl): add .getBuild(num), only works for the current
4783 build, of course, although it might be interesting to offer
4784 something for builds in the .waiting or .interlocked state.
4786 * buildbot/process/base.py (Build): have .stopBuild just do the
4787 interrupt, then let the build die by itself.
4788 (BuildControl): add .stopBuild, and add a point-event named
4789 'interrupt' just after the build so status viewers can tell that
4791 (BuilderControl): add .getBuild
4793 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4794 stops when you kill it, good for testing
4795 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4796 contains the 'reason' text.
4798 * buildbot/status/html.py: Add Stop Build button, if the build can
4799 still be stopped. Send a Redirect (to the top page) one second
4800 later, hopefully long enough for the interrupt to have an effect.
4801 Move make_row() up to top-level to share it between Stop Build and
4804 * buildbot/slave/commands.py: only kill the child process once
4806 * buildbot/test/test_run.py: add testInterrupt
4808 2004-11-29 Brian Warner <warner@lothar.com>
4810 * buildbot/process/base.py: Refactor command interruption. The
4811 Build is now responsible for noticing that the slave has gone
4812 away: Build.lostRemote() interrupts the current step and makes
4813 sure that no further ones will be started.
4815 * buildbot/process/builder.py: When the initial remote_startBuild
4816 message fails, log it: this usually indicates that the slave has
4817 gone away, but we don't really start paying attention until they
4818 fail to respond to the first step's command.
4820 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4821 slave disconnect. Now sports a new interrupt() method. Error
4822 handling was simplified a lot by chaining deferreds, so
4823 remoteFailed/remoteComplete were merged into a single
4824 remoteComplete method (which can now get a Failure object).
4825 Likewise failed/finished were merged into just _finished.
4826 (BuildStep): Add interrupt(why) method, and if why is a
4827 ConnectionLost Failure then the step is failed with some useful
4830 * buildbot/slave/bot.py: stop the current command when the remote
4831 Step reference is lost, and when the slave is shut down.
4832 (Bot): make it a MultiService, so it can have children. Use
4833 stopService to tell when the slave is shutting down.
4834 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4835 remote_interruptCommand (which asks the current SlaveCommand to
4836 stop but allows it to keep emitting status messages), and
4837 stopCommand (which tells it to shut up and die).
4839 * buildbot/slave/commands.py: make commands interruptible
4840 (ShellCommand.kill): factor out os.kill logic
4841 (Command): factor out setup()
4842 (Command.sendStatus): don't send status if .running is false, this
4843 happens when the command has been halted.
4844 (Command.interrupt): new method, used to tell the command to die
4845 (SlaveShellCommand): implement .interrupt
4846 (DummyCommand): implement .interrupt
4847 (SourceBase, etc): factor out setup(), don't continue substeps if
4850 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4851 so they can be called after finishing
4853 * buildbot/test/test_run.py: new tests for disconnect behavior,
4854 refactor slave-shutdown routines, add different kinds of
4857 2004-11-27 Brian Warner <warner@lothar.com>
4859 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4860 method to express ETA time like "2m45s" instead of "165 seconds"
4862 2004-11-24 Brian Warner <warner@lothar.com>
4864 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4865 archive after the test completes, to avoid cluttering the user's
4866 'tla archives' listing with a bogus entry. Arch doesn't happen to
4867 provide any way to override the use of ~/.arch-params/, so there
4868 isn't a convenient way to avoid touching the setup of the user who
4870 (VC_HTTP.testArchHTTP): same
4872 2004-11-23 Brian Warner <warner@lothar.com>
4874 * buildbot/status/html.py (TextLog): split render() up into
4875 render_HEAD and render_GET. Use a Producer when sending log
4876 chunks, to reduce memory requirements and avoid sending huge
4877 non-Banana-able strings over web.distrib connections. Requires
4878 peeking under the covers of IStatusLog.
4879 (TextLog.resumeProducing): fix the "as text" link, handle client
4880 disconnects that occur while we're still sending old chunks.
4882 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4883 use defer.succeed, not the non-existent defer.success
4884 (LogFile.waitUntilFinished): same
4885 (LogFile.subscribe): don't add watchers to a finished logfile
4887 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4890 2004-11-23 Brian Warner <warner@lothar.com>
4892 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4894 2004-11-23 Brian Warner <warner@lothar.com>
4896 * NEWS: update for the 0.6.1 release
4897 * MANIFEST.in: add new files
4899 * README (INSTALLATION): explain how to enable the extra VC tests
4901 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4902 level to, so old pickled builds can be displayed ok
4904 2004-11-22 Brian Warner <warner@lothar.com>
4906 * NEWS: summarize updates since last release
4908 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4909 Yoz Grahame. Closes SF#1050138.
4911 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4914 * buildbot/process/step_twisted.py (Trial): update docs a bit
4916 * docs/factories.xhtml: fix Trial factory docs to match reality.
4919 * buildbot/process/factory.py (Trial.__init__): add args for
4920 randomly= and recurse=, making them available to instantiators
4921 instead of only to subclassers. Closes: SF#1049759.
4923 2004-11-15 Brian Warner <warner@lothar.com>
4925 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4926 try to teach the Quick factory to use multiple versions of python
4928 2004-11-12 Brian Warner <warner@lothar.com>
4930 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4931 safer w32-compatible approach, and only use it on windows
4932 (BuildStatus.saveYourself): same
4934 2004-11-11 Brian Warner <warner@lothar.com>
4936 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4937 it: one string merge per chunk. There are now separate .entries
4938 and .runEntries lists: when enumerating over all chunks, make sure
4940 * buildbot/test/test_status.py (Log): more tests
4942 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4943 chunks together, up to 10kb per chunk. This ought to cut down on
4944 the CPU-burning overhead of large log files. Thanks to Alexander
4945 Staubo for spotting the problem.
4946 * buildbot/test/test_status.py (Log): tests for same
4948 2004-11-10 Brian Warner <warner@lothar.com>
4950 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4951 header to outbound mail
4952 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4954 2004-11-08 Brian Warner <warner@lothar.com>
4956 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4957 can't do os.rename() onto an existing file, so catch the exception
4958 and unlink the target file first. This introduces a slight window
4959 where the existing file could be lost, but the main failure case
4960 (disk full) should still be handled safely.
4961 (BuildStatus.saveYourself): same
4963 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4964 separator character instead of os.sep, because the filenames being
4965 split here are coming from the VC system, which can have a
4966 different pathname convention than the local host. This should
4967 help a buildmaster running on windows that uses a CVS repository
4968 which runs under unix.
4969 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4971 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4972 when there are no test failures to be parsed
4974 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4975 instead of the unix-specific os.system("cp"), thanks to Elliot
4976 Murphy for this and the other buildbot-vs-windows catches.
4977 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4979 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4980 echo the command as it is run
4982 * setup.py: install sample.mk too, not just sample.cfg
4983 (scripts): install contrib/windows/buildbot.bat on windows
4985 2004-11-07 Brian Warner <warner@lothar.com>
4987 * buildbot/process/builder.py (Builder._detached): clear the
4988 self.currentBuild reference, otherwise the next build will be
4989 skipped because we think the Builder is already in use.
4991 * docs/examples/twisted_master.cfg: update to match current usage
4992 on the Twisted buildbot
4994 2004-10-29 Brian Warner <warner@lothar.com>
4996 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4998 2004-10-28 Brian Warner <warner@lothar.com>
5000 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5001 have separate doVCUpdate/doVCFull methods. Catch an update failure
5002 and respond by clobbering the source directory and re-trying. This
5003 will handle local changes (like replacing a file with a directory)
5004 that will cause CVS and SVN updates to fail.
5005 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5007 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5010 2004-10-19 Brian Warner <warner@lothar.com>
5012 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5014 * buildbot/status/html.py (StatusResourceTestResults): display any
5015 TestResults that the Build might have
5016 (StatusResourceTestResult): and the logs for each TestResult
5017 (StatusResourceBuild): add link from the per-build page
5019 2004-10-15 Brian Warner <warner@lothar.com>
5021 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5022 the 'problems' portion of stdout, add TestResults to our build
5023 * buildbot/test/test_twisted.py (Parse.testParse): test it
5025 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5026 to retrieve a dict of accumulated test results
5027 (ITestResult): define what a single test result can do
5028 * buildbot/status/builder.py (TestResult): implement ITestResult
5029 (BuildStatus.getTestResults): retrieve dict of TestResults
5030 (BuildStatus.addTestResult): add TestResults
5031 * buildbot/test/test_status.py (Results.testAddResults): test it
5033 2004-10-14 Brian Warner <warner@lothar.com>
5035 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5036 instead of os.system("rm -rf") for win32 portability
5038 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5039 SignalMixin instead of starting/stopping the reactor, which is
5040 likely to cause problems with other tests
5042 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5043 self.copyComplete() call. Yoz Grahame makes the catch.
5045 * contrib/windows/buildbot.bat: helper script to deal with path
5046 issues. Thanks to Yoz Grahame.
5048 * buildbot/master.py (BuildMaster.startService): don't register a
5049 SIGHUP handler if the signal module has no SIGHUP attribute.
5050 Apparently win32 does this.
5052 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5054 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5055 test if the reactor can't offer UNIX sockets
5057 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5058 error introduced in the last commit. We really need that
5061 2004-10-12 Brian Warner <warner@lothar.com>
5063 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5064 when describing a maildir source. Thanks to Stephen Davis.
5066 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5069 * buildbot/scripts/runner.py (createMaster): install Makefile too
5070 (start): add --no_save to 'start' command
5071 * buildbot/scripts/sample.mk: simple convenience Makefile with
5072 start/stop/reload targets
5074 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5077 2004-09-30 Brian Warner <warner@lothar.com>
5079 * setup.py: Releasing buildbot-0.6.0
5081 2004-09-30 Brian Warner <warner@lothar.com>
5083 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5084 test_trial.py from the source tarball until support is complete.
5086 * NEWS: update for 0.6.0 release
5087 * buildbot/__init__.py (version): same
5090 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5091 'source' command to tell users where to get the Buildbot source
5093 * docs/examples/*.cfg: update to modern standards
5095 * NEWS: update for release
5097 * buildbot/scripts/runner.py (createMaster): remove the
5098 -shutdown.tap stuff now that it isn't necessary
5100 (start): launch buildbot.tap, not buildbot-shutdown.tap
5103 * buildbot/status/mail.py (Domain): shorten class name
5104 (MailNotifier): if lookup= is a string, pass it to Domain()
5105 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5106 (Mail.testBuild2): test the string-to-Domain shortcut
5107 (Mail.testMail): fix test
5110 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5113 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5114 more attributes on load
5115 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5116 to accomodate the whole waterfall page at once, and the thrashing
5117 results in a lot of unnecessary loads
5118 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5119 (BuilderStatus.saveYourself): same
5120 (BuilderStatus.eventGenerator): stop generating on the first missing
5121 build. We assume that saved builds are deleted oldest-first.
5122 (BuildStepStatus.__getstate__): .progress might not exist
5124 * buildbot/changes/changes.py (ChangeMaster): make it
5125 serializable, in $masterdir/changes.pck
5126 (ChangeMaster.stopService): save on shutdown
5127 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5128 * buildbot/test/test_config.py: load Changes before config file
5131 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5132 "Oh my god, you killed the command" header on a separate line
5134 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5135 skip over corrupted build pickles
5136 (BuilderStatus.getFullBuildByNumber): same
5137 (BuilderStatus.eventGenerator): skip over unavailable builds
5138 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5139 do an atomic rename. This prevents a corrupted pickle when some
5140 internal serialization error occurs.
5141 (BuilderStatus.saveYourself): same
5143 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5144 the timeout for shell commands, it got lost somehow
5146 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5147 run out of build steps, return the rest of the builder events
5149 * buildbot/interfaces.py (IBuilderControl.ping): add method
5151 * buildbot/process/builder.py (BuilderControl.ping): move
5152 slave-ping to BuilderControl, and fix the failure case in the
5153 process (Event.finish() is the verb, Event.finished is the noun).
5155 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5156 through the BuilderControl instead of the BuilderStatus
5157 (EventBox): add adapter for builder.Event, allowing builder events to
5158 be displayed in the waterfall display
5160 * buildbot/master.py (BotMaster.stopService): add a 'master
5161 shutdown' event to the builder's log
5162 (BuildMaster.startService): and a 'master started' on startup
5164 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5165 builder events into the BuildStep event stream
5166 (Status.builderAdded): add a 'builder created' event
5169 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5170 command to announce the completion of a running build
5171 (IrcStatusBot.command_FORCE): announce when the build finishes
5173 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5174 don't evict unfinished builds from the cache: they must stay in
5175 the full-cache until their logfiles have stopped changing. Make
5176 sure the eviction loop terminates if an unfinished build was hit.
5177 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5178 This lets exceptions be dumped in an email status message. Really
5179 we need LogFiles which contain both text and HTML, instead of two
5181 (BuildStatus.__getstate__): handle self.finished=False
5182 (Status.builderAdded): if the pickle is corrupted, abandon the
5183 history and create a new BuilderStatus object.
5185 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5186 self.progress attribute, helped one test which doesn't fully set
5187 up the Build object.
5189 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5190 IStatusLog methods into an Interface that is implemented by "stub"
5191 logs, for which all the actual text chunks are on disk (in the
5192 pickled Build instance). To show the log contents, you must first
5193 adapt the stub log to a full IStatusLog object.
5195 * buildbot/status/builder.py (LogFileStub): create separate stub
5196 log objects, which can be upgraded to a real one if necessary.
5197 (LogFile): make them persistable, and let them stubify themselves
5199 (BuildStepStatus): same
5201 (BuildStatus.saveYourself): save the whole build out to disk
5202 (BuilderStatus): make it persistable
5203 (BuilderStatus.saveYourself): save the builder to disk
5204 (BuilderStatus.addFullBuildToCache): implement two caches which
5205 hold Build objects: a small one which holds full Builds, and a
5206 larger one which holds "stubbed" Builds (ones with their LogFiles
5207 turned into LogFileStubs). This reduces memory usage by the
5208 buildmaster by not keeping more than a few (default is 2) whole
5209 build logs in RAM all the time.
5210 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5212 (BuilderStatus.eventGenerator): rewrite since .builds went away
5213 (BuilderStatus.buildStarted): remove the .builds array. Add the
5214 build to the "full" cache when it starts.
5215 (BuilderStatus._buildFinished): save the build to disk when it
5217 (Status): give it a basedir (same as the BuildMaster's basedir)
5218 where the builder pickles can be saved
5219 (Status.builderAdded): create the BuilderStatus ourselves, by
5220 loading a pickle from disk (or creating a new instance if there
5221 was none on disk). Return the BuilderStatus so the master can glue
5222 it into the new Builder object.
5224 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5225 all BuilderStatuses to save themselves out to disk. This is in
5226 lieu of saving anything important in the main Application pickle
5227 (the -shutdown.tap file).
5228 (BuildMaster.__init__): give Status() a basedir for its files
5229 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5230 to get the BuilderStatus, then give it to the Builder (instead of
5231 doing it the other way around). It's ok if the status announces
5232 the new Builder before it's really ready, as the outside world can
5233 only see the BuilderStatus object anyway (and it is ready before
5234 builderAdded returns). Use the builder's "builddir" (which
5235 normally specifies where the slave will run the builder) as the
5236 master's basedir (for saving serialized builds).
5238 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5239 coerce the logfile to IStatusLog before trying to get the text
5240 chunks out of it. This will pull the full (non-stubified) Build in
5241 from disk if necessary.
5242 (TextLog): fix the adapter registration
5244 * buildbot/test/test_control.py (Force.setUp): create the basedir
5245 * buildbot/test/test_web.py: same
5246 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5247 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5248 * buildbot/test/test_run.py (Run.testMaster): same
5249 (Status.setUp): same
5251 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5253 * buildbot/status/html.py (Waterfall.__init__): store actual
5254 allowForce flag passed in rather than using True for everyone;
5255 make sure setting it to False doesn't cause a NameError
5257 (StatusResourceBuilder.__init__) add the builder name to the page
5259 (StatusResourceBuilder.body) move HTML generation for a name/value
5260 row into a helper method (StatusResourceBuilder.make_row); only
5261 generate the "Force Build" form if allowForce was True and the
5262 slave is connected. Use class attributes in the generated HTML to
5263 spread a little CSS-joy.
5265 2004-09-28 Brian Warner <warner@lothar.com>
5267 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5268 warning-scanner to not ignore things like
5269 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5271 * buildbot/status/html.py (StatusResource.control): add some
5272 class-level values for .control in an attempt to make upgrading
5275 * buildbot/util.py (ComparableMixin): survive missing attributes,
5276 such as when a class is modified and we're comparing old instances
5279 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5280 failure handling, remove a redundant try/except block. Don't
5281 return the full traceback to the IRC channel.
5282 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5283 error messages. Get ETA properly.
5285 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5286 the reason, since (at least) IRC message will have <> in them.
5287 (StatusResourceBuilder.__init__): take an IBuilderControl
5288 (StatusResourceBuilder.force): use the IBuilderControl we get in
5289 the constructor instead of trying to make our own. Catch the
5290 new exceptions and ignore them for now (until we make an
5291 intermediate web page where we could show the error message)
5292 (StatusResource): create with an IControl, use it to give an
5293 IBuilderControl to all children
5294 (Waterfall): take an allowForce= option, pass an IControl object
5295 to StatusResource if it is True
5297 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5299 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5300 catch new exceptions and return string forms
5302 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5303 * buildbot/process/builder.py (Builder.forceBuild): raise them
5304 * buildbot/test/test_control.py (Force.testNoSlave): new test
5305 (Force.testBuilderInUse): same
5308 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5310 * buildbot/test/test_run.py: use IControl
5311 * buildbot/test/test_vc.py: same
5313 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5314 to use IControl. Still offline.
5315 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5317 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5318 who=None so periodic builds don't send out status mail
5319 (Builder.forceBuild): include reason in the log message
5320 (BuilderControl.forceBuild): rename 'name' to 'who'
5322 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5323 'who' parameter, but make it None by default so builds forced by
5324 slave admins don't cause status mail to be sent to anybody
5325 (BotMaster.forceBuild): same. this method is deprecated.
5326 (DebugPerspective.perspective_forceBuild): same, use IControl.
5327 (DebugPerspective.perspective_fakeChange): use IControl..
5328 (Dispatcher.requestAvatar): .. so don't set .changemaster
5330 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5331 parameter to avoid confusion with the name of the builder
5334 * buildbot/status/mail.py: refine comment about needing 2.3
5336 * buildbot/status/html.py: move all imports to the top
5338 * buildbot/test/test_control.py: test new interfaces
5339 * buildbot/test/test_run.py (Status): handle new interfaces
5340 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5342 * buildbot/process/base.py (BuildControl): implement IBuildControl
5343 and its lonely getStatus() method
5345 * buildbot/process/builder.py (BuilderControl): implement
5346 IBuilderControl, obtained by adapting the Builder instance
5347 (Builder.startBuild): return a BuilderControl instead of a
5348 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5349 accomplish the same thing.
5351 * buildbot/master.py: move all import statements to the top
5352 (Control): implement IControl, obtained by adapting the
5353 BuildMaster instance.
5355 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5356 IBuildControl. These are used to force builds. Eventually they
5357 will provide ways to reconfigure the Builders, pause or abandon a
5358 Build, and perhaps control the BuildMaster itself.
5360 2004-09-26 Brian Warner <warner@lothar.com>
5362 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5363 ends up comparing us against something without a .__class__
5365 2004-09-24 Brian Warner <warner@lothar.com>
5367 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5370 * Makefile: add 'deb-snapshot' target, to create a timestamped
5373 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5375 2004-09-23 Brian Warner <warner@lothar.com>
5377 * buildbot/__init__.py (version): move version string here
5378 * setup.py: get version string from buildbot.version
5379 * buildbot/status/html.py (WaterfallStatusResource.body): add
5380 buildbot version to the page footer
5381 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5384 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5385 slaves, let the second know where the first one is coming from
5386 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5387 see our exceptions. It would be nice if there were a way to just
5388 send them the exception type and value, not the full traceback.
5391 * buildbot/status/mail.py (MailNotifier): add a new argument
5392 sendToInterestedUsers=, which can be set to False to disable the
5393 usual send-to-blamelist behavior.
5394 (top): handle python-2.2 which has no email.MIMEMultipart
5395 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5396 (MailNotifier.disownServiceParent): unsubscribe on removal
5398 * buildbot/test/test_status.py (Mail.testBuild2): test it
5401 * buildbot/status/progress.py (Expectations.wavg): tolerate
5402 current=None, which happens when steps start failing badly
5403 * buildbot/test/test_status.py (Progress.testWavg): test for it
5405 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5406 doesn't understand args['revision'], emit a warning instead of
5407 bailing completely. Updating to -rHEAD is probably close enough.
5409 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5411 * buildbot/test/test_status.py: at least import bb.status.client
5412 even if we don't have any test coverage for it yet
5414 * contrib/svn_buildbot.py: don't require python2.3
5415 (main): wait, do require it (for sets.py), but explain how to
5416 make it work under python2.2
5418 2004-09-23 Brian Warner <warner@lothar.com>
5420 * contrib/svn_buildbot.py: include the revision number in the Change
5422 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5423 using util.now() because FreshCVS is a realtime service
5425 * buildbot/status/event.py: delete dead code
5426 * buildbot/process/step.py: don't import dead Event class
5427 * buildbot/process/step_twisted.py: same
5428 * buildbot/status/builder.py: same
5429 * buildbot/status/client.py: same
5431 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5433 * buildbot/changes/changes.py (Change): set .when from an __init__
5434 argument (which defaults to now()), rather than having
5435 ChangeMaster.addChange set it later.
5436 (ChangeMaster.addChange): same
5438 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5439 (parseSyncmail): same. Just use util.now() for now.
5440 (parseBonsaiMail): parse the timestamp field for when=
5442 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5443 instead of setting .when after the fact
5447 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5448 results when the target project uses retrial. Still under
5450 * buildbot/test/test_trial.py: same
5452 2004-09-21 Brian Warner <warner@lothar.com>
5454 * buildbot/status/mail.py (MailNotifier.__init__): include
5455 success/warnings/failure in the Subject line
5456 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5457 use step.logname for the addLogs=True attachment filenames
5458 * buildbot/test/test_status.py (Mail): test Subject lines
5459 (Mail.testLogs): test attachment filenames
5461 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5462 accept a 'who' argument from the debug tool
5463 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5464 * contrib/debug.glade: add text box to set 'who'
5466 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5467 .getBuilderName with .getBuilder().getName(), more flexible
5468 (IStatusLog.getName): logs have short names, but you can prefix
5469 them with log.getStep().getName() to make them more useful
5470 * buildbot/status/builder.py: same
5471 * buildbot/status/client.py: same
5472 * buildbot/status/html.py: same
5473 * buildbot/test/test_run.py (Status.testSlave): same
5474 * buildbot/process/step.py: tweak logfile names
5476 * buildbot/status/mail.py (MailNotifier): add lookup, change
5477 argument to extraRecipients. The notifier is now aimed at sending
5478 mail to the people involved in a particular build, with additional
5479 constant recipients as a secondary function.
5481 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5482 including slow-lookup and failing-lookup. Make sure the blamelist
5483 members are included.
5485 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5486 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5487 (IBuildStatus.getInterestedUsers): new method
5488 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5489 * buildbot/status/client.py (remote_getResponsibleUsers): same
5490 * buildbot/status/html.py (StatusResourceBuild.body): same
5491 * buildbot/test/test_run.py (Status.testSlave): same
5493 2004-09-20 Brian Warner <warner@lothar.com>
5495 * docs/users.xhtml: update concepts
5497 * Makefile: add a convenience makefile, for things like 'make
5498 test'. It is not included in the source tarball.
5500 2004-09-16 Brian Warner <warner@lothar.com>
5502 * NEWS: mention /usr/bin/buildbot, debian/*
5504 * debian/*: add preliminary debian packaging. Many thanks to
5505 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5506 it considerably since it left their hands, I am responsible for
5507 all breakage that's resulted.
5509 * bin/buildbot: create a top-level 'buildbot' command, to be
5510 installed in /usr/bin/buildbot . For now it's just a simple
5511 frontend to mktap/twistd/kill, but eventually it will be the entry
5512 point to the 'try' command and also a status client. It is also
5513 intended to support the upcoming debian-packaging init.d scripts.
5514 * buildbot/scripts/runner.py: the real work is done here
5515 * buildbot/scripts/__init__.py: need this too
5516 * buildbot/scripts/sample.cfg: this is installed in new
5517 buildmaster directories
5518 * setup.py: install new stuff
5520 2004-09-15 Brian Warner <warner@lothar.com>
5522 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5523 'file:' schema (the version shipped with OS-X was built without the
5525 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5526 updates the log-timestamp, to make sure it isn't still running after
5529 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5530 values to the config file.
5531 * docs/examples/hello.cfg: add examples
5532 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5533 * buildbot/status/builder.py (Status.getProjectURL): implement them
5534 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5535 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5536 * buildbot/status/html.py (WaterfallStatusResource): display them
5539 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5540 certain error cases don't suffer a secondary exception.
5541 (top): Skip tests if the corresponding VC tool is not installed.
5543 * buildbot/process/factory.py (Trial): introduce separate
5544 'buildpython' and 'trialpython' lists, since trialpython=[] is
5545 what you want to invoke /usr/bin/python, whereas ./setup.py is
5546 less likely to be executable. Add env= parameter to pass options
5547 to test cases (which is how I usually write tests, I don't know if
5548 anyone else does it this way).
5550 * buildbot/process/step_twisted.py (Trial): handle python=None.
5551 Require 'testpath' be a string, not a list. Fix tests= typo.
5552 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5554 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5555 way to deal with the possibility of removing the disconnect notify
5557 (CVS): add a 'login' parameter to give a password to 'cvs login',
5558 commonly used with pserver methods (where pw="" or pw="guest")
5560 * buildbot/slave/commands.py (SourceBase): move common args
5561 extraction and setup() to __init__, so everything is ready by the
5562 time setup() is called
5563 (CVS.start): call 'cvs login' if a password was supplied
5564 (ShellCommand): special-case PYTHONPATH: prepend the master's
5565 value to any existing slave-local value.
5567 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5568 don't have a remote, mark the builder as Offline. This whole
5569 function should probably go away and be replaced by individual
5571 (Builder.buildFinished): return the results to the build-finished
5572 deferred callback, helps with testing
5574 2004-09-14 Brian Warner <warner@lothar.com>
5576 * buildbot/test/test_vc.py: put all the repositories needed to run
5577 the complete tests into a single small (1.3MB) tarball, so I can
5578 make that tarball available on the buildbot web site. Test HTTP
5579 access (for Arch and Darcs) by spawning a temporary web server
5580 while the test runs.
5582 * docs/users.xhtml: new document, describe Buildbot's limited
5583 understanding of different human users
5585 * buildbot/test/test_vc.py: rearrange test cases a bit
5587 * buildbot/process/step_twisted.py (Trial): handle testpath=
5588 * buildbot/process/factory.py (Trial): update to use step.Trial
5590 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5592 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5593 the overall build text (which gives you 'failed 2 tests' rather
5595 (BuildStepStatus.text2): default to [], not None
5597 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5600 2004-09-12 Brian Warner <warner@lothar.com>
5602 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5603 log the whole exception if it's just an AttributeError (old slave)
5605 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5606 so (e.g.) sub-commands can be run in the right directory.
5607 (ShellCommand.start): accept an optional errorMessage= argument
5608 to make life easier for SVN.start
5609 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5611 (ShellCommand.start): move ['dir'] compatibility hack..
5612 (RemoteShellCommand.start): .. to here so everyone can use it
5614 * buildbot/process/step_twisted.py (Trial): use .workdir
5616 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5617 text displayed when debuild fails completely
5618 (Trial): snarf _trial_temp/test.log from the slave and display it
5620 2004-09-11 Brian Warner <warner@lothar.com>
5622 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5624 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5625 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5627 * buildbot/process/step.py (ShellCommand): call .createSummary
5628 before .evaluateCommand instead of the other way around. This
5629 makes it slightly easier to count warnings and then use that to
5630 set results=WARNINGS
5631 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5633 * buildbot/process/base.py (Build.buildFinished): update status
5634 before doing progress. It's embarrassing for the build to be stuck
5635 in the "building" state when an exceptions occurs elsewhere..
5637 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5638 python2.2 doesn't have 'sum'
5640 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5641 to prevent clients from accidentally sorting it
5643 * buildbot/master.py (Manhole): add username/password
5644 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5645 c['manholePort'], deprecate old usage
5646 * docs/config.xhtml: document c['manhole']
5647 * docs/examples/hello.cfg: show example of using a Manhole
5650 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5651 pretend the slave is up to date
5653 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5654 the module, overlaps with 'log', the local variable
5656 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5658 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5659 new method to let Steps find out the version of their
5660 corresponding SlaveCommand.
5661 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5662 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5663 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5665 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5666 (Arch.startVC): same
5667 (P4Sync.startVC): same
5669 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5670 Deferred so we can catch errors in remote_startCommand
5671 (RemoteShellCommand.start): same
5673 * docs/examples/twisted_master.cfg: update sample config file
5675 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5676 after connectionMade() is called, not before. Close stdin at that
5679 * buildbot/process/process_twisted.py: update to use Trial, clean
5680 up argument passing (move to argv arrays instead of string
5683 * buildbot/process/step_twisted.py (Trial): new step to replace
5684 RunUnitTests, usable by any trial-using project (not just
5685 Twisted). Arguments have changed, see the docstring for details.
5687 * buildbot/process/base.py (Build.startBuild): this now returns a
5688 Deferred. Exceptions that occur during setupBuild are now
5689 caught better and lead to fewer build_status weirdnesses, like
5690 finishing a build that was never started.
5691 (Build.buildFinished): fire the Deferred instead of calling
5692 builder.buildFinished directly. The callback argument is this
5693 Build, everything else can be extracted from it, including the
5694 new build.results attribute.
5695 * buildbot/process/builder.py (Builder.startBuild): same
5696 (Builder.buildFinished): same, extract results from build
5698 * buildbot/process/step.py (ShellCommands): remove dead code
5700 2004-09-08 Brian Warner <warner@lothar.com>
5702 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5703 doesn't try to use the leftover patched workdir
5704 (SourceStamp): test source-stamp computation for CVS and SVN
5706 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5707 patched workdir ('touch .buildbot-patched') so we don't try to
5709 (SourceBase.start): add ['revision'] for all Source steps
5710 (CVS): change args: use ['branch'] for -r, remove ['files']
5711 (CVS.buildVC): fix revision/branch stuff
5712 (SVN): add revision stuff
5714 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5715 kwargs (except 'workdir') to avoid silent spelling errors
5716 (ShellCommand.__init__): same
5717 (Source): new base class for CVS/SVN/etc. Factor out everything
5718 common, add revision computation (perform the checkout with a -D
5719 DATE or -r REVISION that gets exactly the sources described by the
5720 last Change), overridable with step.alwaysUseLatest. Add patch
5721 handling (build.getSourceStamp can trigger the use of a base
5722 revision and a patch).
5723 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5724 * docs/steps.xhtml: update docs
5725 * docs/source.xhtml: mention .checkoutDelay
5726 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5728 * buildbot/process/base.py (Build.setSourceStamp): add a
5729 .sourceStamp attribute to each Build. If set, this indicates that
5730 the build should be done with something other than the most
5731 recent source tree. This will be used to implement "try" builds.
5732 (Build.allChanges): new support method
5733 (Build.lastChangeTime): remove, functionality moved to Source steps
5734 (Build.setupBuild): copy the Step args before adding ['workdir'],
5735 to avoid modifying the BuildFactory (and thus triggering spurious
5739 * buildbot/status/html.py: rename s/commits/changes/
5740 (StatusResourceChanges): same
5741 (CommitBox.getBox): same, update URL
5742 (WaterfallStatusResource): same
5743 (StatusResource.getChild): same
5745 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5746 * contrib/debug.glade: add optional 'revision' to the fakeChange
5748 * buildbot/changes/changes.py (html_tmpl): display .revision
5749 (ChangeMaster.addChange): note .revision in log
5750 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5751 accept a ['revision'] attribute
5753 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5755 * buildbot/master.py (BotMaster.getPerspective): update the
5756 .connected flag in SlaveStatus when it connects
5757 (BotMaster.detach): and when it disconnects
5758 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5759 (BuildMaster.loadConfig_Builders): walk old list correctly
5761 * buildbot/test/test_config.py: fix prefix= usage
5763 2004-09-06 Brian Warner <warner@lothar.com>
5767 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5768 poll a P4 depot looking for recent changes. Thanks to Dave
5769 Peticolas for the contribution. Probably needs some testing after
5772 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5773 requires manual client setup for each buildslave. Rather
5774 experimental. Thanks again to Dave Peticolas.
5775 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5777 * buildbot/changes/changes.py (Change): add a .revision attribute,
5778 which will eventually be used to generate source-stamp values.
5780 * buildbot/process/step.py (RemoteCommand.start): use
5781 notifyOnDisconnect to notice when we lose the slave, then treat it
5782 like an exception. This allows LogFiles to be closed and the build
5783 to be wrapped up normally. Be sure to remove the disconnect
5784 notification when the step completes so we don't accumulate a
5785 bazillion such notifications which will fire weeks later (when the
5786 slave finally disconnects normally). Fixes SF#915807, thanks to
5787 spiv (Andrew Bennetts) for the report.
5788 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5789 really isn't Logged- specific
5790 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5791 header, since it's almost always going to be appended to an
5793 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5794 update test to handle use of notifyOnDisconnect
5796 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5797 don't clear .ETA and .currentBuild when going offline, let the
5798 current build clean up after itself
5800 * buildbot/process/builder.py (Builder.detached): wait a moment
5801 before doing things like stopping the current build, because the
5802 current step will probably notice the disconnect and cleanup the
5804 * buildbot/test/test_run.py (Status.tearDown): update test to
5805 handle asynchronous build-detachment
5807 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5809 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5810 hush a debug message
5812 2004-09-05 Brian Warner <warner@lothar.com>
5814 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5815 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5816 kernels do this: the fcntl module has the F_NOTIFY constant, but
5817 the kernel itself doesn't support the operation. Thanks to Olly
5818 Betts for spotting the problem.
5820 * buildbot/process/step.py (Darcs): new source-checkout command
5821 (Arch): new source-checkout command
5822 (todo_P4): fix constructor syntax, still just a placeholder
5823 * buildbot/test/test_vc.py (VC.testDarcs): test it
5824 (VC.testDarcsHTTP): same, via localhost HTTP
5826 (VC.testArchHTTP): same
5827 * NEWS: mention new features
5829 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5830 which tells the step to stash stdout text locally (in .stdout).
5831 Slave-side Commands can use this to make decisions based upon the
5832 output of the the ShellCommand (not just the exit code).
5833 (Darcs): New source-checkout command
5834 (Arch): New source-checkout command, uses .keepStdout in one place
5835 where it needs to discover the archive's default name.
5837 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5838 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5839 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5841 * buildbot/process/step.py (ShellCommand.describe): add an
5842 alternate .descriptionDone attribute which provides descriptive
5843 text when the step is complete. .description can be ["compiling"],
5844 for use while the step is running, then .descriptionDone can be
5845 ["compile"], used alone when the step succeeds or with "failed" when
5846 it does not. Updated other steps to use the new text.
5847 * buildbot/process/step_twisted.py: same
5848 * buildbot/test/test_run.py: update tests to match
5850 2004-08-30 Brian Warner <warner@lothar.com>
5852 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5853 (CVS.__init__): send 'patch' argument to slave
5854 (CVS.start): don't create the LoggedRemoteCommand until start(),
5855 so we can catch a .patch added after __init__
5856 (SVN.__init__): add 'patch' to SVN too
5859 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5860 argument, to let commands push data into the process' stdin pipe.
5861 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5862 is in use, since closing a PTY doesn't really affect the process
5863 in the right way (in particular, I couldn't run /usr/bin/patch
5865 (SourceBase.doPatch): handle 'patch' argument
5867 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5870 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5871 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5873 * buildbot/master.py (BotPerspective.got_commands): get command
5874 versions from slave, give to each builder
5875 * buildbot/process/builder.py (Builder.attached): stash slave
5876 command versions in .remoteCommands
5878 * docs/steps.xhtml: bring docs in-line with reality
5880 * buildbot/process/step.py (CVS.__init__): more brutal
5881 compatibility code removal
5882 (SVN.__init__): same
5884 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5885 (SlaveShellCommand.start): require ['workdir'] argument, remove
5886 the ['dir'] fallback (compatibility will come later)
5887 (SourceBase): update docs
5888 (SourceBase.start): remove ['directory'] fallback
5891 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5892 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5893 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5895 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5896 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5897 code.. I will figure out 0.5.0-compatibility hooks later)
5899 2004-08-30 Brian Warner <warner@lothar.com>
5901 * buildbot/process/process_twisted.py: rewrite in terms of new
5902 BuildFactory base class. It got significantly shorter. Yay
5905 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5906 work with the new "self.build isn't nailed down until we call
5907 step.start()" scheme: specifically, __init__ is called before the
5908 build has decided on which Changes are going in, so we don't scan
5909 build.allFiles() for .xhtml files until start()
5910 (HLint.commandComplete): use getText(), not getStdout()
5911 (RunUnitTests.start): same: don't use .build until start()
5912 (RunUnitTests.describe): oops, don't report (None) when using
5914 (RunUnitTests.commandComplete): use getText()
5915 (RunUnitTests.createSummary): same
5916 (BuildDebs.commandComplete): same
5918 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5919 set args['command'] until start(), since our BuildStep is allowed
5920 to change their mind up until that point
5921 (TreeSize.commandComplete): use getText(), not getStdout()
5923 * docs/examples/twisted_master.cfg: update to current standards
5925 * docs/factories.xhtml: update
5926 * buildbot/process/factory.py: implement all the common factories
5927 described in the docs. The Trial factory doesn't work yet, and
5928 I've probably broken all the process_twisted.py factories in the
5929 process. There are compatibility classes left in for things like
5930 the old BasicBuildFactory, but subclasses of them are unlikely to
5932 * docs/examples/glib_master.cfg: use new BuildFactories
5933 * docs/examples/hello.cfg: same
5935 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5936 explicit 'workdir' args
5938 * buildbot/process/base.py (BuildFactory): move factories to ..
5939 * buildbot/process/factory.py (BuildFactory): .. here
5940 * buildbot/process/process_twisted.py: handle move
5941 * buildbot/test/test_config.py: same
5942 * buildbot/test/test_run.py: same
5943 * buildbot/test/test_steps.py: same
5944 * buildbot/test/test_vc.py: same
5945 * docs/factories.xhtml: same
5947 * NEWS: mention config changes that require updating master.cfg
5949 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5950 argument to all steps that weren't given one already, pointing at
5951 the "build/" directory.
5953 * docs/examples/hello.cfg: remove explicit 'workdir' args
5955 * docs/factories.xhtml: document standard BuildFactory clases,
5956 including a bunch which are have not yet been written
5958 2004-08-29 Brian Warner <warner@lothar.com>
5960 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5961 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5962 buildbot.status.builder so they aren't quite so internal
5963 * buildbot/process/base.py, buildbot/process/builder.py: same
5964 * buildbot/process/maxq.py, buildbot/process/step.py: same
5965 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5966 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5967 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5969 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5970 to handle new getLogs()-returns-list behavior
5971 (StatusResourceBuildStep.getChild): same
5972 (StepBox.getBox): same
5973 (WaterfallStatusResource.phase0): same
5975 * docs/source.xhtml: document how Buildbot uses version-control
5976 systems (output side: how we get source trees)
5977 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5978 systems (input side: how we learn about Changes)
5980 * buildbot/master.py (Manhole): use ComparableMixin
5981 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5982 * buildbot/changes/mail.py (MaildirSource): same
5983 * buildbot/status/client.py (PBListener): same
5984 * buildbot/status/html.py (Waterfall): same
5985 * buildbot/status/words.py (IRC): same
5987 * NEWS: start describing new features
5989 * buildbot/status/mail.py (MailNotifier): finish implementation.
5990 The message body is still a bit sparse.
5991 * buildbot/test/test_status.py (Mail): test it
5993 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5994 and __hash__ methods I wind up adding everywhere. Specifically
5995 intended to support the buildbot config-file update scheme where
5996 we compare, say, the old list of IStatusTargets against the new
5997 one and don't touch something which shows up on both lists.
5998 * buildbot/test/test_util.py (Compare): test case for it
6000 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6001 return a list instead of a dict
6002 (IBuildStepStatus.getLogs): same. The idea is that steps create
6003 logs with vaguely unique names (although their uniqueness is not
6004 guaranteed). Thus a compilation step should create its sole
6005 logfile with the name 'compile', and contribute it to the
6006 BuildStatus. If a step has two logfiles, try to create them with
6007 different names (like 'test.log' and 'test.summary'), and only
6008 contribute the important ones to the overall BuildStatus.
6009 * buildbot/status/builder.py (Event.getLogs): same
6010 (BuildStepStatus): fix default .text and .results
6011 (BuildStepStatus.addLog): switch to list-like .getLogs()
6012 (BuildStepStatus.stepFinished): same
6013 (BuildStatus.text): fix default .text
6014 (BuildStatus.getLogs): temporary hack to return all logs (from all
6015 child BuildStepStatus objects). Needs to be fixed to only report
6016 the significant ones (as contributed by the steps themselves)
6017 * buildbot/test/test_run.py: handle list-like .getLogs()
6018 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6020 2004-08-28 Brian Warner <warner@lothar.com>
6022 * buildbot/process/builder.py (Builder.attached): serialize the
6023 attachment process, so the attach-watcher isn't called until the
6024 slave is really available. Add detached watchers too, which makes
6027 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6029 * buildbot/test/test_swap.py: remove dead code
6031 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6032 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6033 sort of as if the command being run exited with a -1. There may
6034 still be some holes in this scheme.
6035 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6036 -r option appears before the module list
6037 * buildbot/process/step.py (CVS): add 'revision' argument
6039 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6040 when sending updates or stepComplete messages to the master, since
6041 we don't currently care whether they arrive or not. When we revamp
6042 the master/slave protocol to really resume interrupted builds,
6043 this will need revisiting.
6044 (lostRemote): remove spurious print
6046 * buildbot/master.py (BotPerspective.attached): serialize the
6047 new-builder interrogation process, to make testing easier
6048 (BotMaster.waitUntilBuilderDetached): convenience function
6050 * buildbot/status/builder.py (BuilderStatus): prune old builds
6051 (BuildStatus.pruneSteps): .. and steps
6052 (BuildStepStatus.pruneLogs): .. and logs
6053 (BuilderStatus.getBuild): handle missing builds
6054 * buildbot/status/html.py (StatusResourceBuild.body): display build
6055 status in the per-build page
6056 (BuildBox.getBox): color finished builds in the per-build box
6058 2004-08-27 Brian Warner <warner@lothar.com>
6060 * buildbot/status/mail.py (MailNotifier): new notification class,
6063 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6064 variants of a common base class which handles all the mode= logic
6066 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6068 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6070 2004-08-26 Brian Warner <warner@lothar.com>
6072 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6075 * buildbot/test/test_run.py: update to new Logfile interface, new
6076 buildbot.slave modules
6077 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6079 * MANIFEST.in: new sample config file
6080 * docs/examples/hello.cfg: same
6082 * buildbot/process/step_twisted.py: remove dead import
6084 * buildbot/process/step.py (RemoteCommand.run): catch errors
6086 (RemoteCommand.remote_update): ignore updates that arrive after
6088 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6089 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6090 the responsibilities of the subclass's methods
6091 (BuildStep.failed): catch errors during failure processing
6092 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6093 (CVS): move to a mode= argument (described in docstring), rather
6094 than the ungainly clobber=/export=/copydir= combination.
6095 (SVN): add mode= functionality to SVN too
6096 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6098 * buildbot/process/base.py (Build.startNextStep): catch errors
6099 during s.startStep()
6101 * buildbot/clients/base.py: update to new PB client interface.
6102 gtkPanes is still broken
6104 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6105 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6106 * setup.py: add buildbot.slave module
6107 * buildbot/bb_tap.py: handle move
6108 * buildbot/slave/registry.py: place to register commands, w/versions
6109 * buildbot/slave/bot.py: major simplifications
6110 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6111 instead of a fixed table. Eventually this will make the slave more
6112 extensible. Use 'start' method on the command, not .startCommand.
6113 Fix unsafeTracebacks handling (I think).
6114 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6115 helper class with a .start method that returns a Deferred.
6116 SlaveShellCommand is the form reached by the buildmaster. Commands
6117 which use multiple ShellCommands can just chain them as Deferreds,
6118 with some helper methods in Command (_abandonOnFailure and
6119 _checkAbandoned) to bail on rc!=0.
6120 (CVSCommand): prefer new mode= argument
6121 (SVNFetch): add mode= argument
6123 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6124 put a useful reason string on the build
6126 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6127 core functionality into an IStatusLog object
6128 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6129 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6130 (StatusResourceBuild.body): use proper accessor methods
6131 * buildbot/status/client.py (RemoteLog): PB-access goes here
6132 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6133 which delivers log contents too
6134 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6135 * buildbot/status/event.py: remove old Logfile completely
6137 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6138 subscription interface for IStatusLog subscriptions just like all
6139 other the status subscriptions
6140 (IStatusReceiver.logChunk): method called on subscribers
6142 2004-08-24 Brian Warner <warner@lothar.com>
6144 * buildbot/process/builder.py (Builder._pong): oops, ping response
6145 includes a result (the implicit None returned by remote_print).
6146 Accept it so the _pong method handles the response correctly.
6148 2004-08-06 Brian Warner <warner@lothar.com>
6150 * buildbot/test/test_config.py: update IRC, PBListener tests
6152 * buildbot/status/client.py (StatusClientPerspective): total
6153 rewrite to match new IStatus interfaces. New subscription scheme.
6154 There are still a few optimizations to make (sending down extra
6155 information with event messages so the client doesn't have to do a
6156 round trip). The logfile-retrieval code is probably still broken.
6157 Moved the PB service into its own port, you can no longer share a
6158 TCP socket between a PBListener and, say, the slaveport (this
6159 should be fixed eventually).
6160 * buildbot/clients/base.py (Client): revamp to match. still needs
6161 a lot of work, but basic event reporting works fine. gtkPanes is
6164 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6165 instance talks to a single irc server. Threw out all the old
6166 multi-server handling code. Still need to add back in
6167 builder-control (i.e. "force build")
6169 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6170 more random text to the as-yet-unreachable per-step page
6172 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6173 rename to stepETAUpdate
6174 (BuildStatus.subscribe): add build-wide ETA updates
6175 (BuilderStatus.getState): remove more cruft
6176 (BuilderStatus.getCurrentBuild): remove more cruft
6177 (BuilderStatus.buildStarted): really handle tuple-subscription
6178 * buildbot/test/test_run.py (Status.testSlave): handle the
6179 stepETAUpdate rename
6181 * buildbot/master.py (BuildMaster): don't add a default
6182 StatusClientService. Don't add a default IrcStatusFactory. Both
6183 are now added through c['status'] in the config file. c['irc'] is
6184 accepted for backwards compatibility, the only quirk is you cannot
6185 use c['irc'] to specify IRC servers on ports other than 6667.
6187 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6188 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6189 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6190 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6193 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6194 the buildmaster to re-read its config file
6197 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6198 find out the port our server is running on
6199 (WebTest.test_webPathname_port): same
6201 * buildbot/test/test_config.py (testWebPortnum): test it
6202 (testWebPathname): ditto
6204 * docs/config.xhtml: document new c['status'] configuration option
6206 * buildbot/status/html.py (Waterfall): new top-level class which
6207 can be added to c['status']. This creates the Site as well as the
6208 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6209 reachable as .parent, for everything.
6211 * buildbot/master.py (Manhole): make it a normal service Child
6212 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6213 webPathname. It will eventually replace c['irc'] and the implicit
6214 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6215 in as (deprecated) backward compatibility hooks for now.
6218 * buildbot/process/builder.py (Builder.buildFinished): don't
6219 inform out builder_status about a finished build, as it finds out
6220 through its child BuildStatus object
6222 * buildbot/status/html.py: extensive revamp. Use adapters to make
6223 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6224 have both starting and finishing times and adjust the waterfall
6225 display accordingly, using spacers if necessary. Use SlaveStatus
6226 to get buildslave info.
6227 (StatusResourceBuildStep): new just-one-step resource, used to get
6228 logfiles. No actual href to it yet.
6230 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6231 the time being, until I get the file-naming scheme right
6233 * buildbot/status/builder.py (Event): clean started/finished names
6234 (BuildStatus.isFinished): .finished is not None is the right test
6235 (BuildStatus.buildStarted): track started/finished times ourselves
6236 (BuilderStatus.getSlave): provide access to SlaveStatus object
6237 (BuilderStatus.getLastFinishedBuild): all builds are now in
6238 .builds, even the currently-running one. Accomodate this change.
6239 (BuilderStatus.eventGenerator): new per-builder event generator.
6240 Returns BuildStepStatus and BuildStatus objects, since they can
6241 both be adapted as necessary.
6242 (BuilderStatus.addEvent): clean up started/finished attributes
6243 (BuilderStatus.startBuild,finishBuild): remove dead code
6244 (SlaveStatus): new object to provide ISlaveStatus
6246 * buildbot/process/step.py (ShellCommand.getColor): actually
6247 return the color instead of setting it ourselves
6248 (CVS.__init__): pull .timeout and .workdir options out of
6249 **kwargs, since BuildStep will ignore them. Without this neither
6250 will be sent to the slave correctly.
6251 (SVN.__init__): same
6253 * buildbot/process/builder.py (Builder): move flags to class-level
6255 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6256 SlaveStatus handle that
6258 * buildbot/process/base.py (Build.firstEvent): remove dead code
6259 (Build.stopBuild): bugfix
6261 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6263 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6264 (ChangeMaster.eventGenerator): yield Changes, since there are now
6265 Adapters to turn them into HTML boxes
6267 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6268 (BotPerspective.attached): feed a SlaveStatus object
6269 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6270 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6272 * buildbot/interfaces.py: API additions
6273 (ISlaveStatus): place to get slave status
6275 2004-08-04 Brian Warner <warner@lothar.com>
6277 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6278 the delay finishes, so the step is marked as SUCCESS
6280 * buildbot/test/test_run.py (Status.testSlave): cover more of
6281 IBuildStatus and IBuildStepStatus
6283 * buildbot/status/progress.py (StepProgress): move some flags to
6284 class-level attributes
6285 (StepProgress.remaining): if there are no other progress metrics
6286 to go by, fall back to elapsed time
6287 (StepProgress.setExpectations): take a dict of metrics instead of
6289 (BuildProgress.setExpectationsFrom): pull expectations from the
6290 Expectations, instead of having it push them to the BuildProgress
6291 (Expectations): move some flags to class-level attributes
6292 (Expectations.__init__): copy per-step times from the
6294 (Expectations.expectedBuildTime): new method for per-build ETA
6296 * buildbot/status/event.py (Logfile): move some flags to
6297 class-level attributes
6298 (Logfile.logProgressTo): better method name, let step set the
6299 progress axis name (instead of always being "output")
6301 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6302 times directly, rather than depending upon the (possibly missing)
6303 .progress object. Use 'None' to indicate "not started/finished
6305 (BuildStepStatus.getExpectations): oops, return the full list of
6307 (BuilderStatus._buildFinished): append finished builds to .builds
6309 * buildbot/process/step.py (BuildStep): add separate .useProgress
6310 flag, since empty .progressMetrics[] still implies that time is a
6312 (CVS): set up the cmd in __init__, instead of waiting for start()
6314 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6315 calculation, this will eventually turn into a proper sourceStamp
6316 (Build.setupBuild): tell the Progress to load from the Expectations,
6317 instead of having the Expectations stuff things into the Progress
6318 (Build.buildException): add a build-level errback to make sure the
6319 build's Deferred fires even in case of exceptions
6321 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6323 * buildbot/process/builder.py (Builder.forceBuild): convey the
6324 reason instead of creating a fake Change
6326 * docs/examples/twisted_master.cfg: update to match reality
6328 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6329 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6330 fix or remove broken/breaking tests
6332 * buildbot/status/event.py (Logfile.__len__): remove evil method
6334 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6335 missing .build, for test convenience
6337 * buildbot/process/step_twisted.py: import fixes
6339 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6341 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6342 .statusbag reference
6344 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6345 connection at shutdown, and stop it from reconnecting
6347 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6348 chase down remote-execution bugs
6350 * buildbot/process/step.py: more fixes, remove
6351 BuildStep.setStatus()
6352 * buildbot/status/builder.py: move setStatus() functionality into
6354 * buildbot/status/event.py: minor fixes
6356 2004-08-03 Brian Warner <warner@lothar.com>
6358 * buildbot/process/base.py, buildbot/process/builder.py
6359 * buildbot/process/step.py, buildbot/status/builder.py
6360 * buildbot/status/event.py, buildbot/test/test_run.py:
6361 fix status delivery, get a basic test case working
6362 * buildbot/master.py: finish implementing basic status delivery,
6363 temporarily disable HTML/IRC/PB status sources
6365 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6367 * buildbot/status/progress.py (BuildProgress): remove dead code
6369 * buildbot/interfaces.py
6370 * buildbot/process/base.py, buildbot/process/builder.py
6371 * buildbot/process/step.py, buildbot/process/step_twisted.py
6372 * buildbot/status/builder.py: Complete overhaul of the all
6373 status-delivery code, unifying all types of status clients (HTML,
6374 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6375 look like. This commit is a checkpointing of the work-in-progress:
6376 the input side is mostly done (Builders/Builds sending status
6377 to the BuilderStatus/BuildStatus objects), but the output side has
6378 not yet been started (HTML resources querying BuilderStatus
6379 objects). Things are probably very broken right now and may remain
6380 so for several weeks, I apologize for the disruption.
6382 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6383 HTML as the log's contents. Currently used for exception tracebacks.
6384 * buildbot/status/progress.py: minor spelling changes
6386 2004-08-02 Brian Warner <warner@lothar.com>
6388 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6389 in mozilla. Also added stylesheets copied from Twisted's docs.
6390 Remember that these files are meant to be run through Lore first.
6391 Thanks to Philipp Frauenfelder for the fixes.
6392 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6393 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6394 * docs/template.tpl: added a Lore template
6396 2004-07-29 Brian Warner <warner@lothar.com>
6398 * buildbot/interfaces.py: revamp status delivery. This is the
6399 preview: these are the Interfaces that will be provided by new
6400 Builder code, and to which the current HTML/IRC/PB status
6401 displayers will be adapted.
6403 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6404 on the SlaveBuilder, not the Bot.
6405 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6407 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6408 set .usePTY on the FakeSlaveBuilder
6410 2004-07-25 Brian Warner <warner@lothar.com>
6412 * buildbot/changes/freshcvs.py: add some debug log messages
6413 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6414 disabled 'setFilter' syntax
6415 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6416 don't end with a slash
6418 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6420 * setup.py: bump to 0.5.0+ while between releases
6422 2004-07-23 Brian Warner <warner@lothar.com>
6424 * setup.py (version): Releasing buildbot-0.5.0
6426 2004-07-23 Brian Warner <warner@lothar.com>
6428 * README: update for 0.5.0 release
6430 * NEWS: update for 0.5.0 release
6432 2004-07-22 Brian Warner <warner@lothar.com>
6434 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6435 mktap-time configuration flag (--usepty=1, --usepty=0)
6436 * buildbot/bot.py: same
6438 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6439 an 'info' directory being unwanted
6441 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6442 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6443 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6444 and earlier), use a FreshCVSSourceOldcred instead.
6445 (test): simple test routine: connect to server, print changes
6447 * buildbot/changes/changes.py (Change.getTime): make it possible
6448 to print un-timestamped changes
6450 * buildbot/master.py (makeApp): delete ancient dead code
6451 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6452 * buildbot/test/test_config.py (testFindConfigFile): test it
6454 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6455 instead of win32 one
6458 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6459 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6462 * buildbot/process/base.py (Builder.__init__): change constructor
6463 to accept a dictionary of config data, rather than discrete
6464 name/slave/builddir/factory arguments
6466 * docs/examples/twisted_master.cfg: update to new syntax
6467 * docs/examples/glib_master.cfg: same
6468 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6469 rough tests of the new syntax
6472 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6473 to be an int, which means "run a web.distrib sub-server on a TCP
6474 port". This lets you publish the buildbot status page to a remote
6475 twisted.web server (using distrib.ResourceSubscription). Also
6476 rename the local attributes used to hold these web things so
6477 they're more in touch with reality.
6478 * buildbot/test/test_web.py: test webPortnum and webPathname
6479 * docs/config.xhtml: document this new use of webPathname
6481 * docs/config.xhtml: new document, slightly ahead of reality
6483 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6484 'prefix' handling: treat it as a simple string to check with
6485 .startswith, instead of treating it as a directory. This allows
6486 sub-directories to be used. If you use prefix=, you should give it
6487 a string that starts just below the CVSROOT and ends with a slash.
6488 This prefix will be stripped from all filenames, and filenames
6489 which do not start with it will be ignored.
6491 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6493 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6494 and --exclude (inverse of --include). SVN post-commit hooks
6495 now have total control over which changes get sent to buildbot and which
6498 2004-07-10 Brian Warner <warner@lothar.com>
6500 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6501 test case to match new API
6503 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6504 which crashed HTML display when self.entries=[] (needed to
6505 distinguish between [], which means "no entries yet", and None,
6506 which means "the entries have been swapped out to disk, go fetch
6509 2004-07-04 Brian Warner <warner@lothar.com>
6511 * buildbot/process/step_twisted.py (countFailedTests): Count
6512 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6513 10kb from the end because any import errors are wedged there and
6514 they would make us think the test log was unparseable.
6515 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6517 2004-06-26 Brian Warner <warner@lothar.com>
6519 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6520 delete-*.pyc command into an actual BuildStep, so we can label it
6522 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6523 (FullTwistedBuildFactory): same
6525 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6527 * contrib/fakechange.py: Add an errback when sending the fake
6528 change, so we know it didn't work.
6530 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6532 * buildbot/process/step_twisted.py: Delete *.pyc files before
6533 calling trial, so it doesn't catch any old .pyc files whose .py
6534 files have been moved or deleted.
6536 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6537 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6538 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6539 instead of ["twisted.test"], so that the end result is "trial -R
6542 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6543 regular expression to match filenames that should be ignored when
6544 changed. Also add a --revision parameter that specifies the
6545 revision to examine, which is useful for debugging.
6547 2004-06-25 Brian Warner <warner@lothar.com>
6549 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6550 summary of warnings (like DeprecationWarnings), next to the
6553 2004-05-13 Brian Warner <warner@lothar.com>
6555 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6556 we now have a w32 build slave courtesy of Mike Taylor.
6558 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6559 so broken. Fixed a race condition that tripped up interlocked
6560 builds and caused the status to be stuck at "Interlocked" forever.
6561 The twisted buildbot's one interlocked build just so happened to
6562 never hit this case until recently (the feeding builds both pass
6563 before the interlocked build is attempted.. usually it has to wait
6565 (Builder._pong_failed): fix method signature
6567 * setup.py: bump to 0.4.3+ while between releases
6569 2004-04-30 Brian Warner <warner@lothar.com>
6571 * setup.py (version): Releasing buildbot-0.4.3
6573 2004-04-30 Brian Warner <warner@lothar.com>
6575 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6577 * README: update for 0.4.3 release
6579 * NEWS: update for 0.4.3 release
6581 * buildbot/master.py (BuildMaster.__getstate__): make sure
6582 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6584 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6585 .trial as a class attribute, for upgrade from 0.4.2
6587 * buildbot/changes/changes.py (Change.links): add .links for
6590 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6591 .textWatchers and .htmlWatchers at save time, since they are both
6592 volatile, should allow smooth 0.4.2 upgrade
6594 * buildbot/process/step.py (CVS.finishStatus): catch failed
6595 CVS/SVN commands so we can make the status box red
6597 2004-04-29 Brian Warner <warner@lothar.com>
6599 * buildbot/changes/freshcvs.py
6600 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6601 code to do setFilter(), which tells the freshcvs daemon to not
6602 send us stuff that we're not interested in. I will uncomment it
6603 when a new version of CVSToys is available in which setFilter()
6604 actually works, and I get a chance to test it better.
6606 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6608 * buildbot/master.py (Dispatcher): use a registration scheme
6609 instead of hardwired service names
6610 (BuildMaster): keep track of the Dispatcher to support
6613 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6614 PBChangeSource class instead of having it be an undocumented
6615 internal feature of the ChangeMaster. Split out the code into a
6617 * buildbot/changes/pb.py (PBChangeSource): same
6618 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6620 * docs/{factories|sources|steps}.xhtml: document some pieces
6622 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6623 using FCMaildirSource
6624 (f23osx): update OS-X builder to use python2.3, since the slave
6625 was updated to Panther (10.3.3)
6627 2004-03-21 Brian Warner <warner@lothar.com>
6629 * buildbot/process/process_twisted.py: factor out doCheckout, change
6630 to use SVN instead of CVS
6632 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6633 an SVN subclass easier
6634 (BasicSVN): subclass which uses Subversion instead of CVS
6636 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6638 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6640 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6642 2004-02-25 Brian Warner <warner@lothar.com>
6644 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6645 is now either a list (which is passed to spawnProcess directly) or
6646 a string (which gets passed to /bin/sh -c). This removes the useSH
6647 flag and the ArgslistCommand class. Also send status header at the
6648 start and end of each command, instead of having the master-side
6650 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6651 -r'. Update to use list-based arguments.
6652 (SVNFetch): use list-based arguments, use ['dir'] argument to
6654 * buildbot/test/test_steps.py (Commands): match changes
6656 * buildbot/process/step.py (InternalShellCommand.words): handle
6658 (SVN): inherit from CVS, cleanup
6660 * buildbot/status/event.py (Logfile.content): render in HTML, with
6661 stderr in red and headers (like the name of the command we're
6662 about to run) in blue. Add link to a second URL (url + "?text=1")
6663 to get just stdout/stderr in text/plain without markup. There is
6664 still a problem with .entries=None causing a crash, it seems to occur
6665 when the logfile is read before it is finished.
6667 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6668 timeout to the keepalives, and use it to explicitly do a
6669 loseConnection instead of waiting for TCP to notice the loss. This
6670 ought to clear up the silent-lossage problem.
6671 (unsafeTracebacks): pass exception tracebacks back to the master,
6672 makes it much easier to debug problems
6674 2004-02-23 Brian Warner <warner@lothar.com>
6676 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6677 the whole command to /bin/sh instead of execve [Johan Dahlin]
6678 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6679 '-r HEAD' [Johan Dahlin]
6680 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6682 * buildbot/changes/changes.py (Change): add links= argument, add
6683 asHTML method [Johan Dahlin]. Modified to make a bit more
6684 XHTMLish. Still not sure how to best use links= .
6686 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6687 Change.asHTML to display the change, not asText
6689 * buildbot/status/html.py (StatusResourceBuilder): web button to
6692 * buildbot/test/test_run.py: test to actually start a buildmaster
6695 * MANIFEST.in: bring back accidentally-dropped test helper files
6697 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6698 that require cvstoys if it is not installed
6700 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6701 values of "bin/trial" [Dave Peticolas]
6702 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6703 tests passed" when we didn't happen to run any tests
6705 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6706 flunkOnFailure [Johan Dahlin]
6708 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6709 multiple instances of the same Step class by suffixing "_2", etc,
6710 to the name until it is unique. This name needs to be unique
6711 because it is used as a key in the dictionary that tracks build
6713 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6716 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6718 2004-01-14 Brian Warner <warner@lothar.com>
6720 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6721 kicked from a channel, log it
6723 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6724 something over whatever IRC channels the buildmaster is currently
6725 connected to. Added to try and track down a problem in which the
6726 master thinks it is still connected but the IRCd doesn't see it. I
6727 used a styles.Versioned this time, so hopefully users won't have
6728 to rebuild their .tap files this time.
6729 * contrib/debug.glade: add a "Poke IRC" button
6730 * contrib/debugclient.py: same
6732 * setup.py: bump to 0.4.2+ while between releases
6734 2004-01-08 Brian Warner <warner@lothar.com>
6736 * setup.py (version): Releasing buildbot-0.4.2
6738 2004-01-08 Brian Warner <warner@lothar.com>
6740 * NEWS: update for 0.4.2 release
6742 * README: document how to run the tests, now that they all pass
6744 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6746 * buildbot/process/step.py (CVS): add a global_options= argument,
6747 which lets you set CVS global options for the command like "-r"
6748 for read-only checkout, or "-R" to avoid writing in the
6750 * buildbot/slavecommand.py (CVSCommand): same
6752 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6753 testing easier (it is turned off when testing, to avoid the
6756 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6757 to make it easier to test: break generateStepID() out to a
6758 separate function, only update statusbag if it exists.
6759 (ShellCommands): create useful text for dict-based commands too.
6761 * test/*, buildbot/test/*: move unit tests under the buildbot/
6763 * setup.py (packages): install buildbot.test too
6765 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6766 * buildbot/test/test_steps.py: fix it, tests pass now
6768 2004-01-06 Brian Warner <warner@lothar.com>
6770 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6771 freshcvs mail uses a slightly different syntax for new
6772 directories. Update parser to handle either.
6773 * test/test_mailparse.py (Test1.testMsg9): test for same
6775 2003-12-21 Brian Warner <warner@lothar.com>
6777 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6778 'warnOnWarnings' so that lintian errors mark the build orange
6780 2003-12-17 Brian Warner <warner@lothar.com>
6782 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6783 messages emitted by Bonsai, contributed by Stephen Davis.
6785 * test/*: moved all tests to use trial instead of unittest. Some
6786 still fail (test_steps, test_slavecommand, and test_process).
6788 * setup.py (version): bump to 0.4.1+ while between releases
6790 2003-12-09 Brian Warner <warner@lothar.com>
6792 * setup.py (version): Releasing buildbot-0.4.1
6794 2003-12-09 Brian Warner <warner@lothar.com>
6796 * NEWS: update for 0.4.1 release
6798 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6799 freebsd builder code a little bit
6801 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6802 don't try to compare attributes of different classes
6803 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6804 (MaildirSource.messageReceived): fix Change delivery
6806 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6807 into the config file's namespace before loading it, like the
6808 documentation claims it does
6809 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6810 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6811 daemon comes back online
6813 2003-12-08 Brian Warner <warner@lothar.com>
6815 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6816 so the example will work with online=0 as well
6818 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6819 fix the __implements__ line
6821 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6822 class a twisted.application.service.Service, use startService to
6825 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6826 directory fd instead of simple open(). I'm sure this used to work,
6827 but the current version of python refuses to open directories with
6830 2003-12-05 Brian Warner <warner@lothar.com>
6832 * setup.py (version): bump to 0.4.0+ while between releases
6834 2003-12-05 Brian Warner <warner@lothar.com>
6836 * setup.py (version): Releasing buildbot-0.4.0
6838 2003-12-05 Brian Warner <warner@lothar.com>
6840 * docs/examples/glib_master.cfg: replace old sample scripts with
6841 new-style config files
6842 * MANIFEST.in: include .cfg files in distribution tarball
6844 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6845 implement a dummy method to avoid the exception that occurs when
6846 freshcvs sends this to us.
6848 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6849 removed the method, as it broke reconnection. Apparently
6850 stopFactory is called each time the connection attempt fails. Must
6852 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6853 attribute before serialization, since without stopFactory the
6854 reconnect timer may still be active and they aren't serializable.
6856 * test/test_mailparse.py (ParseTest): test with 'self' argument
6858 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6859 argument, as these "functions" are invoked like methods from class
6860 attributes and therefore always get an instance as the first
6863 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6864 message: thanks to Stephen Davis for the catch
6866 2003-12-04 Brian Warner <warner@lothar.com>
6868 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6869 twisted's standard ReconnectingClientFactory. Handles both oldcred
6870 and newcred connections. Also has a bug-workaround for
6871 ReconnectingClientFactory serializing its connector when it
6874 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6875 pbutil. Replace makeApp stuff with proper newcred/mktap
6876 makeService(). Don't serialize Ephemerals on shutdown.
6878 * buildbot/changes/changes.py (ChangeMaster): make it a
6879 MultiService and add the sources as children, to get startService
6880 and stopService for free. This also gets rid of the .running flag.
6882 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6883 new pbutil, turn into a TCPClient at the same time (to get
6884 startService for free). Two variants exist: FreshCVSSourceOldcred
6885 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6886 yet, but when it does, we'll be ready).
6887 (FreshCVSSource.notify): handle paths which are empty after the
6888 prefix is stripped. This only happens when the top-level (prefix)
6889 directory is added, at the very beginning of a Repository's life.
6891 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6892 Now the only reconnecting code is in the factory where it belongs.
6893 (Builder.unsubscribe): unregister the disconnect callback when we
6894 delete the builder on command from the master (i.e. when the
6895 buildmaster is reconfigured and that builder goes away). This
6896 fixes a multiple-delete exception when the status client is shut
6898 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6901 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6902 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6904 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6906 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6907 a list of globs (ugh). The testdir will be searched for files
6908 named *.tests and run the tests in the order specified in each of
6909 those files. This allows for "dependancies" between tests to be
6912 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6913 argument to pass to run_maxq.py, instead of a glob.
6915 2003-10-17 Brian Warner <warner@lothar.com>
6917 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6918 files that live in the sandbox
6920 2003-10-15 Brian Warner <warner@lothar.com>
6922 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6923 spelling error in "docs" count-warnings output
6924 (HLint.start): stupid thinko meant .xhtml files were ignored
6926 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6927 tests now that cReactor is banished to the sandbox
6929 2003-10-10 Brian Warner <warner@lothar.com>
6931 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6932 scheme: now .xhtml are sources and .html are generated
6934 2003-10-08 Brian Warner <warner@lothar.com>
6936 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6937 we were ignoring the 'randomly' parameter.
6939 2003-10-01 Brian Warner <warner@lothar.com>
6941 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6942 posix, to kill sub-children of aborted slavecommands.
6944 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6945 Clean up initialization: lastBuildStatus remains None until the
6946 first build has been completed.
6948 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6949 None as a lastBuildStatus
6950 * buildbot/clients/gtkPanes.py: same
6952 * buildbot/status/client.py (StatusClientService): keep
6953 BuilderStatus objects in self.statusbags . These objects now live
6954 here in the StatusClientService and are referenced by the Builder
6955 object, rather than the other way around.
6956 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6957 * buildbot/process/base.py (Builder): same
6958 * test/test_config.py (ConfigTest.testBuilders): same
6960 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6961 an existing builder, leave the statusbag alone. This will preserve the
6964 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6965 hook. This will probably go away in favor of a class in upcoming
6968 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6969 serviceName from newcred FreshCVSNotifiee setup
6971 2003-09-29 Brian Warner <warner@lothar.com>
6973 * buildbot/process/process_twisted.py: switch to new reactor
6975 * docs/examples/twisted_master.cfg: same
6977 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6979 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6980 botmaster reference instead of the oldapp service lookup
6982 * buildbot/master.py (BuildMaster.__init__): give the
6983 StatusClientService a reference to the botmaster to make it easier to
6986 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6988 * buildbot/status/html.py (Box.td): escape hreffy things so you
6989 can have spaces in things like builder names
6990 (StatusResourceBuilder.body)
6991 (WaterfallStatusResource.body)
6992 (WaterfallStatusResource.body0): same
6994 2003-09-25 Brian Warner <warner@lothar.com>
6996 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6997 rearrange the builder list when adding or removing builders: keep
6998 them in the order the user requested.
6999 * test/test_config.py (ConfigTest.testBuilders): verify it
7001 * contrib/debug.glade: give the debug window a name
7003 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7004 now wait on multiple interlocks. Fix code relating to that.
7005 (Builder.checkInterlocks): same
7006 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7008 * buildbot/master.py (BuildMaster.loadConfig): move from
7009 deprecated pb.BrokerFactory to new pb.PBServerFactory
7010 * test/test_config.py (ConfigTest.testWebPathname): same
7012 * docs/examples/twisted_master.cfg: fix interlock declaration
7014 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7015 Interlocks to their Builders into interlock.py .
7016 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7018 * test/test_config.py (ConfigTest.testInterlocks): validate
7021 * buildbot/process/base.py (Builder.__init__): better comments
7022 * buildbot/process/interlock.py (Interlock.__repr__): same
7023 (Interlock.deactivate): add .active flag, move the code that
7024 attaches/detaches builders into the Interlock
7026 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7028 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7029 tests using the new run_maxq.py script, and reporting failures by
7032 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7033 tests, reporting their success or failure in a buildbot-friendly
7036 2003-09-24 Brian Warner <warner@lothar.com>
7038 * docs/examples/twisted_master.cfg: example of a new-style config
7039 file. This lives in the buildmaster base directory as
7042 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7043 button to make the master re-read its config file
7045 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7046 buildmaster configuration from a file. This file can be re-read
7047 later, and the buildmaster will update itself to match the new
7048 desired configuration. Also use new Twisted Application class.
7049 * test/Makefile, test/test_config.py: unit tests for same
7051 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7052 FreshCVSSources comparable, to support reload.
7053 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7055 * buildbot/process/base.py (Builder): make them comparable, make
7056 Interlocks easier to attach, to support reload. Handle
7057 re-attachment of remote slaves.
7058 * buildbot/process/interlock.py (Interlock): same
7060 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7061 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7062 buildmaster taps are now constructed with mktap.
7063 * buildbot/status/client.py (StatusClientService): same
7065 * buildbot/status/words.py: move to new Services, add support to
7066 connect to multiple networks, add reload support, allow nickname
7067 to be configured on a per-network basis
7069 2003-09-20 Brian Warner <warner@lothar.com>
7071 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7072 the freebsd builder, now that the machine has been upgraded and no
7073 longer has python2.2
7075 * setup.py (version): bump to 0.3.5+ while between releases
7077 2003-09-19 Brian Warner <warner@lothar.com>
7079 * setup.py (version): Releasing buildbot-0.3.5
7081 2003-09-19 Brian Warner <warner@lothar.com>
7083 * NEWS: add post-0.3.4 notes
7085 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7087 * MANIFEST.in: add contrib/*
7089 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7090 use a remote root now: cvs.twistedmatrix.com
7092 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7094 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7095 compatibility with old servers
7096 (FreshCVSSource.start): and provide a way to use it
7097 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7099 * docs/examples/twisted_master.py (twisted_app): update to new
7101 (twisted_app): listen on new ~buildbot socket
7102 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7104 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7105 to reduce cvs bandwidth (update instead of full checkout)
7107 2003-09-11 Brian Warner <warner@lothar.com>
7109 * contrib/fakechange.py: demo how to connect to the changemaster
7110 port. You can use this technique to submit changes to the
7111 buildmaster from source control systems that offer a hook to run a
7112 script when changes are committed.
7114 * contrib/debugclient.py: tool to connect to the debug port. You
7115 can use it to force builds, submit fake changes, and wiggle the
7118 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7119 'Dispatcher' realm to handle all the different kinds of
7120 connections and Perspectives: buildslaves, the changemaster port,
7121 the debug port, and the status client port. NewCredPerspectives
7122 now have .attached/.detached methods called with the remote 'mind'
7123 reference, much like old perspectives did. All the pb.Services
7124 turned into ordinary app.ApplicationServices .
7125 (DebugService): went away, DebugPerspectives are now created
7126 directly by the Dispatcher.
7127 (makeApp): changed interface a little bit
7129 * buildbot/changes/changes.py: newcred
7130 * buildbot/status/client.py: newcred
7132 * buildbot/clients/base.py: newcred client side changes
7133 * buildbot/bot.py: ditto
7135 * docs/examples/glib_master.py: handle new makeApp() interface
7136 * docs/examples/twisted_master.py: ditto
7138 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7139 base newcred Perspectives on. This should go away once Twisted
7140 itself provides something sensible.
7143 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7145 * contrib/svn_buildbot.py: A program that you can call from your
7146 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7147 when a change in an SVN repository has happened. See the top of
7148 the file for some minimal usage info.
7150 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7152 * buildbot/slavecommand.py (ArglistCommand): Add new
7153 ArglistCommand that takes an argument list rather than a string as
7154 a parameter. Using a st.split() for argv is very bad.
7156 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7157 update to a particular revision rather than always checking out
7158 (still not very smart about it, there may be cases where the
7159 checkout becomes inconsistent).
7161 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7163 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7164 SVN fetch support. It can checkout (not update!) a specified
7165 revision from a specified repository to a specified directory.
7167 * buildbot/status/progress.py (Expectations.update): Fix an
7168 obvious bug (apparently created by the change described in the
7169 previous ChangeLog message) by moving a check to *after* the
7170 variable it checks is defined.
7173 2003-09-08 Brian Warner <warner@lothar.com>
7175 * buildbot/status/progress.py (Expectations.update): hack to catch
7176 an exception TTimo sees: sometimes the update() method seems to
7177 get called before the step has actually finished, so the .stopTime
7178 is not set, so no totalTime() is available and we average None
7179 with the previous value. Catch this and just don't update the
7180 metrics, and emit a log message.
7182 2003-08-24 Brian Warner <warner@lothar.com>
7184 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7185 parameter to set copydir='original' in CVS commands.
7187 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7189 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7190 which tells the command to maintain a separate original-source CVS
7191 workspace. For each build, this workspace will be updated, then
7192 the tree copied into a new workdir. This reduces CVS bandwidth
7193 (from a full checkout to a mere update) while doubling the local
7194 disk usage (to keep two copies of the tree).
7196 2003-08-21 Brian Warner <warner@lothar.com>
7198 * buildbot/status/event.py (Logfile.addEntry): if the master web
7199 server dies while we're serving a page, request.write raises
7200 pb.DeadReferenceError . Catch this and treat it like a
7201 notifyFinish event by dropping the request.
7203 2003-08-18 Brian Warner <warner@lothar.com>
7205 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7206 (instead of blowing up) if a force-build command is given without
7209 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7210 don't blow up if there aren't yet any Changes in the list
7212 2003-08-02 Brian Warner <warner@lothar.com>
7214 * buildbot/bot.py (updateApplication): don't set the .tap name,
7215 since we shouldn't assume we own the whole .tap file
7217 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7218 'mktap buildbot' (without a subcommand) better
7220 2003-07-29 Brian Warner <warner@lothar.com>
7222 * buildbot/status/words.py
7223 (IrcStatusFactory.clientConnectionLost): when we lose the
7224 connection to the IRC server, schedule a reconnection attempt.
7226 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7227 use shutil.rmtree instead of forking off an "rm -rf" command.
7228 rmtree may take a while and will block until it finishes, so we
7229 use "rm -rf" if available.
7231 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7232 freebsd buildslave badly
7234 * setup.py (version): bump to 0.3.4+ while between releases
7236 2003-07-28 Brian Warner <warner@lothar.com>
7238 * setup.py (version): Releasing buildbot-0.3.4
7240 2003-07-28 Brian Warner <warner@lothar.com>
7242 * NEWS: update in preparation for release
7244 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7245 process.signalProcess instead of os.kill, to improve w32
7248 * docs/examples/twisted_master.py (twisted_app): turn off
7249 win32eventreactor: the tests hang the buildslave badly
7251 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7252 failed builds, since usually the failures are consistent
7254 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7255 add compileOpts/compileOpts2 to reactors build
7257 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7258 (twisted_app): use both default and win32eventreactor on w32 build.
7259 Use both default and kqreactor on freebsd build.
7261 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7262 add compileOpts2, which is put after the build_ext argument. w32
7263 needs "-c mingw32" here.
7265 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7266 touch .acqpath, it goes away in recent Twisted releases
7268 * docs/examples/twisted_master.py (twisted_app): use "python" for
7269 the w32 buildslave, not "python2.2"
7271 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7272 the directory exists.. should hush an exception under w32
7274 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7275 ProcessTerminated -provided values for signal and exitCode rather
7276 than parsing the unix status code directly. This should remove one
7277 more roadblock for a w32-hosted buildslave.
7279 * test/test_mailparse.py: add test cases for Syncmail parser
7281 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7282 temporary compatibility import. Note! Start importing
7283 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7285 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7287 2003-07-27 Brian Warner <warner@lothar.com>
7289 * NEWS: started adding new features
7291 * buildbot/changes/mail.py: start work on Syncmail parser, move
7292 mail sources into their own file
7294 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7295 as implementing IChangeSource
7296 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7298 * buildbot/interfaces.py: define the IChangeSource interface
7300 2003-07-26 Brian Warner <warner@lothar.com>
7302 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7304 2003-06-25 Brian Warner <warner@lothar.com>
7306 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7309 2003-06-17 Brian Warner <warner@lothar.com>
7311 * buildbot/status/words.py: clean up method usage to avoid error
7312 in silly IRC command
7313 (IrcStatusBot.emit_status): round off seconds display
7315 * buildbot/process/base.py (Build): delete the timer when saving
7316 to the .tap file, and restore it (if it should still be running)
7317 upon restore. This should fix the "next build in -34 seconds"
7318 messages that result when the master is restarted while builds are
7319 sitting in the .waiting slot. If the time for the build has
7320 already passed, start it very soon (in 1 second).
7322 * buildbot/status/words.py: more silly commands
7324 * README (REQUIREMENTS): add URLs to all required software
7326 * buildbot/status/words.py ('last'): mention results of, and time
7329 2003-05-28 Brian Warner <warner@lothar.com>
7331 * buildbot/status/words.py: add 'last' command
7332 (IrcStatusBot.emit_status): add current-small text to 'status' output
7334 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7335 (twisted_app): remove spaces from OS-X builder name
7337 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7338 * buildbot/status/words.py: IRC bot should actually be useful now
7340 2003-05-23 Brian Warner <warner@lothar.com>
7342 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7343 "slave information" from $(slavedir)/info/* . These files are
7344 maintained by the slave administrator, and describe the
7345 machine/environment that is hosting the slave. Information from
7346 them is put into the "Builder" HTML page. Still need to establish
7347 a set of well-known filenames and meanings for this data: at the
7348 moment, *all* info/* files are sent to the master, but only
7349 'admin' and 'host' are used on that end.
7350 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7351 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7352 * buildbot/master.py (BotPerspective.got_info): ditto
7354 2003-05-22 Brian Warner <warner@lothar.com>
7356 * setup.py (version): bump version to 0.3.3+ while between releases
7358 2003-05-21 Brian Warner <warner@lothar.com>
7360 * setup.py: Releasing buildbot-0.3.3
7362 2003-05-21 Brian Warner <warner@lothar.com>
7364 * NEWS: 0.3.3 news items
7366 * README: describe --keepalive and life behind a NAT box
7368 * buildbot/bot.py (Bot.connected): implement application-level
7369 keepalives to deal with NAT timeouts, turn them on with
7370 --keepalive option or when SO_KEEPALIVE doesn't work.
7372 * buildbot/master.py (BotPerspective): accept keepalives silently
7374 * buildbot/process/base.py (Build.buildException): CopiedFailures
7375 don't carry as much information as local ones, so don't try to
7376 create a big HTMLized version of them.
7378 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7379 log file when step fails due to an exception, such as when the slave
7382 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7383 --testmodule argument instead of grepping for test-case-name tags
7384 ourselves. Remove FindUnitTests code.
7385 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7387 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7389 2003-05-16 Brian Warner <warner@lothar.com>
7391 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7392 argument to allow things like CFLAGS=-O0 to be passed without relying
7393 upon /bin/sh processing on the slave.
7395 * buildbot/process/step.py (InternalShellCommand.start): send
7397 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7398 'split' instead of letting /bin/sh do it. This should also remove
7399 the need for /bin/sh on the buildslave, making it more likely to
7402 * buildbot/status/html.py: html-escape text in blamelist.
7403 Add "force build" button to the Builder page.
7405 * buildbot/process/step_twisted.py (countFailedTests): look at
7406 last 1000 characters for status line, as import errors can put it
7407 before the -200 point.
7409 2003-05-15 Brian Warner <warner@lothar.com>
7411 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7413 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7414 make 'clobber' a parameter, so it is possible to have builds which
7415 do full tests but do a cvs update instead of hammering the CVS
7416 server with a full checkout each build
7418 * buildbot/process/step.py (InternalShellCommand): bump default
7419 timeout to 20 minutes
7421 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7422 the master to trigger a build. Run it via manhole.
7424 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7425 allow slaves to trigger any build that they host, to make life
7426 easier for slave admins who are testing out new build processes
7428 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7429 don't flunk cReactor or qtreactor on failure, since they fail alot
7430 these days. Do warnOnFailure instead.
7432 * buildbot/process/base.py: change Builder.buildable from a list
7433 into a single slot. When we don't have a slave, new builds (once
7434 they make it past the timeout) are now merged into an existing
7435 buildable one instead of being queued. With this change, a slave
7436 which has been away for a while doesn't get pounded with all the
7437 builds it missed, but instead just does a single build.
7439 2003-05-07 Brian Warner <warner@lothar.com>
7441 * setup.py (version): bump version to 0.3.2+ while between releases
7443 2003-05-07 Brian Warner <warner@lothar.com>
7445 * setup.py: Releasing buildbot-0.3.2
7447 2003-05-07 Brian Warner <warner@lothar.com>
7449 * setup.py: fix major packaging error: include subdirectories!
7451 * NEWS: add changes since last release
7453 * README (REQUIREMENTS): update twisted/python dependencies
7455 * buildbot/status/builder.py (Builder.startBuild): change
7456 BuildProcess API: now they should call startBuild/finishBuild
7457 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7458 keeping a list of builds in the statusbag, to support other kinds of
7460 (Builder.addClient): send current-activity-small to new clients
7461 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7464 * buildbot/status/client.py: drop RemoteReferences at shutdown
7466 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7468 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7469 more debug messages for remote status client
7471 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7472 (.stepFailed): only fire the Deferred once, even if both
7473 stepComplete and stepFailed are called. I think this can happen if
7474 an exception occurs at a weird time.
7476 * buildbot/status/words.py: work-in-progress: IRC status delivery
7478 2003-05-05 Brian Warner <warner@lothar.com>
7480 * docs/examples/twisted_master.py (twisted_app): hush internal
7481 python2.3 distutils deprecation warnings
7482 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7483 add compileOpts= argument which inserts extra args before the
7484 "setup.py build_ext" command. This can be used to give -Wignore
7485 warnings, to hush some internal python-2.3 deprecation messages.
7487 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7488 the ['twisted.test'] default test case to make it easier to change
7491 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7492 * buildbot/clients/gtkPanes.py: ditto
7494 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7495 arg to collapse RunUnitTestsRandomly into RunUnitTests
7496 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7497 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7499 * buildbot/status/html.py (StatusResource): shuffle Resources
7500 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7501 would serve the waterfall display, but the internal links were
7502 only valid on the trailing-slash version. The correct behavior is
7503 for the non-slashed one to serve a Redirect to the slashed one.
7504 This only shows up when the buildbot page is hanging off another
7505 server, like a Twisted-Web distributed server.
7507 * buildbot/status/event.py (Event, RemoteEvent): make Events
7508 pb.Cacheable, with RemoteEvent as the cached version. This removes
7509 a lot of explicit send-an-update code.
7510 * buildbot/status/builder.py (Builder): remove send-update code
7511 * buildbot/status/client.py (ClientBuilder): remove send-update
7512 code, and log errors that occur during callRemote (mostly to catch
7513 InsecureJelly exceptions)
7515 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7516 run Lore with the same python used in the rest of the build
7518 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7520 * buildbot/process/step_twisted.py (HLint): accept 'python'
7521 argument. Catch rc!=0 and mark the step as failed. This marks the
7522 build orange ("has warnings").
7523 (RunUnitTestsJelly): move out to step_twisted2.py
7525 * buildbot/util.py (ignoreStaleRefs): add utility function
7527 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7528 don't fake ETA object, it's too hard to get right
7530 2003-05-02 Brian Warner <warner@lothar.com>
7532 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7534 2003-05-01 Brian Warner <warner@lothar.com>
7536 * buildbot/status/html.py (StatusResource.body): oops, I was
7537 missing a <tr>, causing the waterfall page to be misrendered in
7538 everything except Galeon.
7540 2003-04-29 Brian Warner <warner@lothar.com>
7542 * docs/examples/twisted_master.py: make debuild use python-2.2
7543 explicitly, now that Twisted stopped supporting 2.1
7545 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7546 handle tuple results too. I keep forgetting this, which suggests
7547 it needs to be rethought.
7549 * setup.py (setup): bump version to 0.3.1+ while between releases
7551 2003-04-29 Brian Warner <warner@lothar.com>
7553 * setup.py: Releasing buildbot-0.3.1
7555 2003-04-29 Brian Warner <warner@lothar.com>
7557 * README (SUPPORT): add plea to send questions to the mailing list
7559 * NEWS, MANIFEST.in: add description of recent changes
7561 * docs/examples/twisted_master.py: add the code used to create the
7562 Twisted buildmaster, with passwords and such removed out to a
7565 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7566 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7567 buildmasters to not require CVSToys be installed.
7568 * README, docs/examples/glib_master: update to match the change
7570 * buildbot/clients/base.py, buildbot/bot.py,
7571 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7572 ReconnectingPB from CVSToys distribution to remove CVSToys
7573 dependency for build slaves and status clients. Buildmasters which
7574 use FreshCVSSources still require cvstoys be installed, of course.
7576 2003-04-25 Brian Warner <warner@lothar.com>
7578 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7579 runTestsRandomly arg to turn on trial -z
7581 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7582 experimental code to use trial's machine-parseable output to get
7583 more detailed test results. Still has some major issues.
7584 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7587 * buildbot/status/builder.py (Builder.setCurrentBuild):
7588 anticipating moving build history into statusbag, not used yet
7590 * buildbot/status/tests.py: code to centralize test results,
7591 doesn't work quite yet
7593 * buildbot/status/event.py (Event): use hasattr("setName") instead
7594 of isinstance for now.. need better long-term solution
7596 * buildbot/status/html.py: Remove old imports
7598 2003-04-24 Brian Warner <warner@lothar.com>
7600 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7601 ignore changes under doc/fun/ and sandbox/
7603 * buildbot/process/step_twisted.py: update pushEvent and friends.
7605 * buildbot/status/html.py (Box.td): replace event.buildername with
7606 event.parent.getSwappableName(). Needs more thought.
7608 * buildbot/status/builder.py (Builder): Replace pushEvent and
7609 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7610 Tell events they are being pruned with event.delete().
7612 * buildbot/process/base.py (Build): Remove Builder status-handling
7613 methods. s/pushEvent/setCurrentActivity/.
7615 * buildbot/process/step.py (BuildStep): clean up status delivery.
7616 Gouse builder.statusbag methods instead of intermediate builder
7617 methods. s/updateLastEvent/updateCurrentActivity/.
7618 s/finalizeLastEvent/finishCurrentActivity/. Use
7619 addFileToCurrentActivity for summaryFunction.
7621 * buildbot/status/event.py (Logfile): put data in a Swappable when
7623 (Event): add more setter methods. Remove .buildername, use .parent
7624 and getSwappableName instead (needs more thought).
7626 * buildbot/util.py (Swappable):
7627 * test/test_swap.py: don't bother setting filename at __init__
7628 time, do it later. Change setFilename args to take parent first,
7629 since it provides the most significant part of the filename.
7631 2003-04-23 Brian Warner <warner@lothar.com>
7633 * buildbot/status/event.py (Logfile.addEntry): append to previous
7636 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7637 anticipating Swappable
7638 (InternalShellCommand.remoteUpdate): split out various log-adding
7639 methods so subclasses can snarf stdout separately
7641 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7642 in anticipation of Swappable build logs
7643 (Builder.testsFinished): anticipating TestResults, still disabled
7645 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7648 * buildbot/status/event.py (Logfile): add (disabled) support for
7649 Swappable, not ready for use yet
7651 * buildbot/util.py (Swappable): object which is swapped out to
7652 disk after some period of no use.
7653 * test/test_swap.py: test buildbot.utils.Swappable
7655 2003-04-14 Brian Warner <warner@lothar.com>
7657 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7658 periodic-build timer. Set the .periodicBuildTime on a builder
7659 instance to some number of seconds to activate it.
7661 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7663 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7664 a way that survives result tuples
7666 2003-04-12 Brian Warner <warner@lothar.com>
7668 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7669 return a dict instead of a tuple: allow summarizers to provide
7670 multiple summaries if they want
7671 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7672 (debuildSummarizer): summarize lintian warnings/errors
7674 2003-04-10 Brian Warner <warner@lothar.com>
7676 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7678 2003-04-09 Brian Warner <warner@lothar.com>
7680 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7681 empty summaries: happens when the tests fail so hard they don't emit
7682 a parseable summary line.
7684 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7685 Allow summaryFunction to return None to indicate no summary should
7688 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7689 writing to stale HTTP requests: notice when they disconnect and
7690 remove the request from the list. Also add CacheToFile from
7691 moshez, will be used later.
7693 2003-04-08 Brian Warner <warner@lothar.com>
7695 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7696 should be an int, not a list of strings
7698 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7699 if we weren't actually connected
7701 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7702 to show the tail end of the trial text output
7704 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7705 hook to summarize the results of a ShellCommand
7707 2003-04-07 Brian Warner <warner@lothar.com>
7709 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7710 twisted test suite code into a single class.
7711 * buildbot/process/process_twisted.py: same
7713 2003-04-04 Brian Warner <warner@lothar.com>
7715 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7717 * README (SLAVE): document use of mktap to create slave .tap file
7718 (REQUIREMENTS): describe dependencies
7720 * buildbot/bb_tap.py, buildbot/plugins.tml:
7721 * buildbot/bot.py (updateApplication): Add mktap support for creating
7722 buildslave .tap files
7724 2003-03-28 Brian Warner <warner@lothar.com>
7726 * buildbot/process/step.py (InternalShellCommand.finished): handle
7727 new tuple result values (fix embarrasing bug that appeared during
7730 2003-03-27 Brian Warner <warner@lothar.com>
7732 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7735 2003-03-25 Brian Warner <warner@lothar.com>
7737 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7738 to overall build status
7739 * buildbot/clients/base.py (Builder): improve event printing
7740 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7741 instead of generic ShellCommand
7742 (Build): Add .stopBuild, use it when slave is detached
7744 * buildbot/process/step.py (Configure,Test): give the steps their
7745 own names and status strings
7747 * buildbot/status/html.py (StatusResource): add "show" argument,
7748 lets you limit the set of Builders being displayed.
7750 2003-03-20 Brian Warner <warner@lothar.com>
7752 * buildbot/process/basic.py: removed
7754 2003-03-19 Brian Warner <warner@lothar.com>
7756 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7757 turn off process-docs by default
7759 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7760 when displaying build information without anything in allBuilds[]
7762 * buildbot/bot.py (makeApp): really take password from sys.argv
7764 2003-03-18 Brian Warner <warner@lothar.com>
7766 * buildbot/bot.py (buildApp): take password from sys.argv
7768 * README: replace with more useful text
7770 * setup.py: add a real one
7771 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7773 * docs/PyCon-2003/: added sources for PyCon paper.
7775 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7776 now Build objects control the process and Builder only handles
7777 slave stuff and distribution of changes/status. A new BuildFactory
7778 class creates Build objects on demand.
7780 Created ConfigurableBuild which takes a list of steps to run. This
7781 makes it a lot easier to set up a new kind of build and moves us
7782 closer to being able to configure a build from a web page.
7784 * buildbot/process/step_twisted.py, process_twisted.py: move to
7785 new model. A lot of code went away.
7787 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7788 send lots of empty progress messages to the client.
7790 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7792 2003-02-20 Brian Warner <warner@lothar.com>
7794 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7796 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7797 Twisted bug that prevented non-pty processes from working just got
7798 fixed, and the bug that leaks ptys is still being investigated.
7800 * buildbot/process/step.py (CVS): send timeout arg to slave
7802 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7803 builders coming and going
7804 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7805 from CVSToys, handle lost-buildmaster
7807 * buildbot/status/client.py (StatusClientService.removeBuilder):
7808 Clean up status client protocol: send builders (with references)
7809 as they are created, rather than sending a list and requiring the
7810 client to figure out which ones are new.
7811 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7812 attempts to force a build on an unknown builder
7814 2003-02-19 Brian Warner <warner@lothar.com>
7816 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7817 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7818 Twisted stops leaking them.
7819 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7820 builder goes to an idle state.
7822 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7823 I figure out why CVS commands hang without them, and/or I fix the
7824 hung-command timeout
7826 2003-02-16 Brian Warner <warner@lothar.com>
7828 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7829 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7830 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7831 GenerateDocs now that they are prefixed with WARNING:.
7833 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7834 use manual href target instead of request.childLink
7836 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7837 display every second, but update the ETA every 5 seconds (or
7838 whenever) as remote_progress messages arrive.
7841 2003-02-12 Brian Warner <warner@lothar.com>
7843 * *: import current sources from home CVS repository
7847 # add-log-time-format: add-log-iso8601-time-string