1 2007-08-01 Brian Warner <warner@lothar.com>
3 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
4 add a query arg of 'show_events=true' to display non-build events,
5 like slaves attaching/detaching and reconfig events, or
6 'show_events=false' to hide them. The default is 'true'.
7 * docs/buildbot.texinfo (Buildbot Web Resources): document it
9 * web-parts: merge in web-parts branch. Lots of changes. The new
10 functionality is to add buildbot.status.html.WebStatus, which is a
11 superset of the Waterfall that adds new status pages and serves
12 regular files from BASEDIR/public_html/ , which is now the preferred
13 place to put robots.txt, buildbot.css, and index.html .
14 * buildbot/scripts/runner.py: the 'create-master' command now
15 creates public_html/ too, and populates it with a couple of
17 * buildbot/status/web: split waterfall code into smaller pieces
19 2007-07-31 Brian Warner <warner@lothar.com>
21 * buildbot/scripts/startup.py (launch): import twistd.run in a
22 different way to hush pyflakes
23 * buildbot/process/builder.py: remove unused import
25 2007-07-30 Brian Warner <warner@lothar.com>
27 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
28 Mitchell: pass SourceStamps around rather than branch/version/etc
29 tuples. Thanks Dustin! Closes #70.
30 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
31 tuple rather than a list, to avoid surprising mutations
32 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
33 * buildbot/status/mail.py (MailNotifier.buildMessage): same
34 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
35 * buildbot/test/test_status.py (Subscription): same
36 * buildbot/test/test_control.py (Force): same
37 * buildbot/test/test_buildreq.py (Request.testMerge): same
39 2007-07-29 Brian Warner <warner@lothar.com>
41 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
42 variable, since it wasn't used and is confusing in the presence of
43 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
46 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
47 the Buildbot home-page link to point at buildbot.net instead of
48 sourceforge, and add a current-version query parameter so we can
49 get some statistics on which versions are in use out there.
51 2007-07-28 Brian Warner <warner@lothar.com>
53 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
54 with c['change_source'], leaving c['sources'] for backwards
55 compatibility (but deprecated), scheduled for removal in 0.8.0
56 * docs/buildbot.texinfo: same
57 * buildbot/test/test_config.py: verify that c['sources'] still works
58 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
59 * buildbot/scripts/sample.cfg: update to match
61 * buildbot/changes/mail.py (MaildirSource): parse with python's
62 stdlib 'email' module, which has been available since python2.2,
63 and drop use of the 'rfc822' module, which has been depreceated
65 * buildbot/test/test_maildir.py: same: use parse_file() not parse
67 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
68 this needs to match the renaming in test/mail/msg*
70 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
73 * buildbot/test/test_mailparse.py: rename sample emails a bit
74 * buildbot/test/mail/msg*: same
76 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
77 parser for the "commit-email.pl" script that is shipped with SVN,
78 written by Justin Mason. Thanks! Closes SF#1072845.
79 * buildbot/test/mail/svn-commit.*: sample messages
80 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
81 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
83 2007-07-27 Brian Warner <warner@lothar.com>
85 * buildbot/changes/mail.py: refactor: move parsing into a method
86 named 'parse', each parser type gets a separate subclass. Remove
87 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
88 to be a simple leading-substring match. Add a warning to the logs
89 if prefix= does not end in a slash, since that's probably a
90 mistake. Fix both places where a prefix= mismatch would skip all
91 subsequent files in the same email, instead of just skipping the
92 one that didn't match.
93 * buildbot/test/test_mailparse.py: match changes
95 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
96 docs on email-based ChangeSources
98 * docs/buildbot.texinfo (Getting Source Code Changes): move all
99 the changesource types up a level, removing the one-entry menu in
102 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
103 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
104 instances instead of tuples. Closes #63.
105 * buildbot/slave/__init__.py (BuildSlave): define marker class
106 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
107 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
108 * buildbot/test/test_*.py: update tests to match
109 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
110 the c['bots'] backwards-compatibility handler works
112 2007-07-26 Brian Warner <warner@lothar.com>
114 * buildbot/changes/hgbuildbot.py (hook): add an in-process
115 Mercurial change-sending hook, contributed by Frederic Leroy.
116 Thanks! Addresses #50.
117 * docs/buildbot.texinfo (MercurialHook): document it
119 * buildbot/changes/hgbuildbot.py: change the way imports are done,
120 to make it compatible with at least hg-0.9.1 and the current 0.9.4
122 2007-07-17 Brian Warner <warner@lothar.com>
124 * buildbot/process/buildstep.py (BuildStep.getLog): add a
125 convenience method to retrieve a log added with
126 addLog()/addCompleteLog()/etc or logfiles= . I should have added
129 2007-07-03 Brian Warner <warner@lothar.com>
131 * buildbot/slave/commands.py (ShellCommand._startCommand): when
132 logging the environment variables, put one variable on each line,
133 rather than having one really long line with all of them. This
134 should make them a bit more readable and not trigger the
135 horizontal scrollbar (when viewing it in a web browser) quite so
136 much. Thanks to Albert Hofkamp for the patch.
138 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
139 WithProperties instance. Thanks to Axel Hecht for the patch.
141 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
142 * docs/buildbot.texinfo (Build Properties): document it
143 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
144 workdir if it didn't already exist.
146 * docs/buildbot.texinfo (Scheduler Types): correct the description
147 of Dependent schedulers. Thanks to Greg Ward for the patch.
149 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
150 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
151 the patch. Closes #49.
153 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
154 0700 before removing it, to deal with situations where a build will
155 leave files around without write permissions and the 'copy' or
156 'clobber' VC checkout modes need to blow away the tree first.
157 Thanks to Steve Milner for the suggestion and the patch (which I
158 mangled horribly). Closes #29.
159 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
162 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
163 an allowReconnect= argument to let callers control whether they
164 want this don't-let-it-reconnect behavior, since some tests care.
165 Factor out the .continueTrying=False lines from those callers.
166 * buildbot/test/test_slaves.py: same
167 * buildbot/test/test_run.py: same
169 2007-07-02 Brian Warner <warner@lothar.com>
171 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
172 slave has been disappeared, don't let it reconnect. This was
173 causing an intermittent failure in test_slaves.py, when the slave
174 that was supposed to be gone managed to come back by the end of
175 the test and affect the count.
176 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
178 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
179 diagnostic messages to track down this problem
180 (Builder.startBuild): same
182 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
183 the slave randomly rather than always taking the first one. Thanks
184 to Pike for the patch. Closes #36.
185 * buildbot/test/test_slaves.py: match the change. to avoid huge
186 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
187 enables/disables the round-robin-ness (enabled by default), and
188 some unit tests disable it.
189 * docs/buildbot.texinfo (Buildmaster Architecture): document it
191 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
192 argument to 'buildmaster_host', to make it more obvious that this
193 points to the buildmaster. Thanks to Bob Proulx for the
195 * buildbot/scripts/runner.py (slaveTAC): same
196 * buildbot/test/test_runner.py (Create.testSlave): match the change
198 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
201 2007-06-17 Brian Warner <warner@lothar.com>
203 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
204 we can round-trip all of our current step classes by calling
205 getStepFactory() and using the results to make a clone of the
208 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
211 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
212 the config file, we're moving to using actual instances instead of
213 the (class, kwargs) 'step specification' tuples. BuildFactory
214 still keeps a list of tuples internally, but when real instances
215 are passed in to addStep(), they are asked for their class and
216 kwargs using the new BuildStep.getStepFactory method. BuildFactory
217 accepts both instances and the tuple form, and converts instances
218 to the tuple form, but the instance form is preferred because it
219 gives the Steps a chance to do argument validation. Closes: #11.
221 * buildbot/process/buildstep.py (BuildStep.__init__): record the
222 factory information necessary to implement getStepFactory. The
223 addFactoryArguments() method can be used to include arguments that
224 aren't passed to the BuildStep base class constructor.
225 (BuildStep.setBuild):
226 (BuildStep.setDefaultWorkdir): new methods to take parameters that
227 are needed for live BuildSteps but not to construct the specification
228 tuples that are stashed in the factory.
230 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
231 'workdir' into new BuildSteps by using methods instead of
232 arguments. This makes the constructor for BuildSteps a lot
235 * buildbot/steps/*.py: update to match this change. Basically this
236 means adding calls to addFactoryArguments() in the __init__
237 methods to capture the arguments that aren't passed through to the
239 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
240 the new workdir (if any) into the RemoteShellCommands arguments.
241 * buildbot/steps/source.py: allow workdir= to be optional,
242 implement setDefaultWorkdir() since we don't inherit from
243 (CVS): finally remove old clobber=/export=/copydir= arguments,
244 in favor of the mode= argument that's been around forever now.
245 * buildbot/steps/transfer.py: remove build= argument
247 * buildbot/test/*.py: update to match, generally by turning all
248 build= arguments into subsequent calls to s.setBuild()
249 * buildbot/test/test_config.py (Factories): verify that we can
250 use either BuildStep instances or class/kwarg tuples in both
251 BuildFactory.addStep and BuildFactory.__init__
253 * docs/buildbot.texinfo (Build Steps): document the new approach,
254 mention compatibility with the old approach, update all examples
255 to use the new style.
257 2007-06-16 Brian Warner <warner@lothar.com>
259 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
260 the LoopingCall, just eat the failure so that we'll poll again
261 next time. This should allow us to tolerate (e.g.) sf.net SVN
262 failures more gracefully. Many thanks to Dustin Mitchell for the
265 2007-05-17 Brian Warner <warner@lothar.com>
267 * buildbot/status/words.py: refactor the IRC status bot into
268 separate 'Contact' and 'Channel' classes. The base Contact class
269 contains the interaction code: commands and responses. The
270 IRCContact subclass (and IrcStatusBot 'Channel') handle the
271 IRC-specific aspects. The plan is to write other subclasses for
272 other IM protocols like AIM and Jabber.
274 2007-04-16 Brian Warner <warner@lothar.com>
276 * CREDITS: update list of contributors. Thank you all!
278 2007-04-13 Brian Warner <warner@lothar.com>
280 * buildbot/status/mail.py (MailNotifier): add the project name to
281 the subject line and message body, to make it easier to
282 distinguish email coming from different buildmasters. Thanks to
283 Benoit Sigoure for the patch.
284 * buildbot/test/test_status.py (Mail): update to match
286 2007-03-24 Brian Warner <warner@lothar.com>
288 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
289 avoid text-conversion problems between DOS/windows and unix.
290 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
292 2007-03-03 Brian Warner <warner@lothar.com>
294 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
295 warning about the use of Waterfall here
297 2007-03-01 Brian Warner <warner@lothar.com>
299 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
301 2007-02-28 Brian Warner <warner@lothar.com>
303 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
304 Lamb to use a more optimal form of 'p4 changes', to reduce server
305 load. He reports that this optimization was added to p4d release
306 2005.2, but it should work in all versions. Closes #27.
307 * buildbot/test/test_p4poller.py: match it
309 2007-02-27 Brian Warner <warner@lothar.com>
311 * buildbot/status/web/*.py: move all web status stuff into a
312 separate directory, in anticipation of splitting it into smaller
313 pieces and adding more files. html.py was getting way too big.
314 * buildbot/status/classic.css: move it too
315 * setup.py: add the new sub-package
316 * buildbot/test/test_web.py: match the changes
317 * MANIFEST.in: handle the move of classic.css
319 2007-02-07 Brian Warner <warner@lothar.com>
321 * contrib/OS-X/*: add some launchd .plist files for automatically
322 starting a buildmaster or buildslave under OS-X (10.4 or later).
323 Thanks to Mark Pauley for these.
325 2007-02-06 Brian Warner <warner@lothar.com>
327 * docs/buildbot.texinfo (Requirements): update requirements to
328 stop claiming compatibility with python-2.2 or twisted-1.3.x .
330 * README: mention python-2.5 and twisted-2.5 compatibility
332 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
334 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
336 * buildbot/status/builder.py: same, by requiring cStringIO
337 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
338 * buildbot/test/test_vc.py: same
339 * buildbot/test/test_web.py:
340 * buildbot/test/test_steps.py: same, remove unused import
342 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
345 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
346 see any Builders that don't have Schedulers to drive them
348 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
349 attributes this uses went away
351 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
352 dialog, to allow you to reset the buildmaster and force
353 connect/disconnect. Correctly handle losing the buildmaster
354 connection (by switching the display to the hexnut, at which point
355 you can use the 'Connect' menu item to reconnect).
357 * buildbot/steps/source.py (Source.start): if we're using a patch,
358 add it as a LogFile to the checkout/update step. This will turn
359 into a link on the waterfall page.
361 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
362 option, to take the patch from a pre-made file rather than
363 generating it from the local tree. Thanks to Robert Helmer for the
364 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
365 * buildbot/scripts/runner.py (TryOptions): add --diff,
366 --patchlevel, and --baserev options
367 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
368 as None, meaning HEAD.
369 * buildbot/sourcestamp.py (SourceStamp): update docstring to
370 indicate that baserev=None means HEAD
371 * docs/buildbot.texinfo (try --diff): document it
373 * buildbot/test/test_steps.py (BuildStep): remove use of
374 reactor.iterate(), although the technique I replaced it with is a
375 gross polling hack that must be cleaned up properly some day. This
376 was the last use of reactor.iterate in the entire tree, yay.
378 2007-02-05 Brian Warner <warner@lothar.com>
380 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
381 is one of the three known values, otherwise we emit some confusing
382 messages later on. Thanks to Grig Gheorghiu for the catch.
384 2007-01-30 Brian Warner <warner@lothar.com>
386 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
387 Hearsum contributed a patch to let BonsaiPoller work with results
388 that contain non-ascii characters. Closes SF#1632641.
390 2007-01-27 Brian Warner <warner@lothar.com>
392 * Makefile (release): produce both .tar.gz and .zip source bundles.
395 2007-01-23 Brian Warner <warner@lothar.com>
397 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
398 * buildbot/changes/monotone.py: same
400 * buildbot/changes/maildir.py: combine several files into one,
401 clean up maildir.py to use Services properly.
402 * buildbot/changes/maildirtwisted.py: remove
403 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
405 * buildbot/changes/mail.py: match the change
406 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
407 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
409 * buildbot/slave/commands.py (command_version): bump to "2.3" to
410 indicate that the buildslave knows about the 'bzr' command
412 2007-01-22 Brian Warner <warner@lothar.com>
414 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
415 'with', it will become a reserved work in python2.6 .
417 * contrib/bb_applet.py: add a simple gnome-panel applet, to
418 display a terse summary of buildbot status.
419 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
420 some icons, small versions of the Blender object that lives in
421 docs/images/icon.blend
423 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
424 * buildbot/slave/commands.py (Bzr): same
425 * buildbot/scripts/tryclient.py (BzrExtractor): same
426 (SourceStampExtractor.dovc): modify this to allow non-zero exit
427 status, since 'bzr diff' does that
428 * buildbot/test/test_vc.py (Bzr): same
429 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
433 2007-01-20 Brian Warner <warner@lothar.com>
435 * contrib/darcs_buildbot.py: tidy up the progress messages
437 2007-01-17 Brian Warner <warner@lothar.com>
439 * contrib/darcs_buildbot.py: enhance to handle multiple patches
440 being pushed at a time. This keeps state in the repository in a
441 small file named .darcs_buildbot-lastchange, but that shouldn't
442 interfere with normal repository operations. Fixes SF#1534049.
443 * buildbot/clients/sendchange.py (Sender): make a single Sender
444 capable of sending Changes with different usernames.
446 2006-12-11 Brian Warner <warner@lothar.com>
448 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
449 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
450 buildbot.changes.mail a long time ago, but I forgot to add the
451 DeprecationWarning until now.
453 * buildbot/process/maxq.py: remove this, the functionality now
454 lives in buildbot.steps.maxq
456 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
457 * buildbot/clients/gtkPanes.py: remove unused import
459 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
460 that was meant to provide a special Reporter to run inside trial
461 and give the buildslave lots of machine-readable status. We never
462 finished this project.
464 * buildbot/changes/bonsaipoller.py: remove unused imports
465 * buildbot/changes/svnpoller.py: same
466 * buildbot/process/builder.py: same
467 * buildbot/process/buildstep.py: same
468 * buildbot/slave/bot.py: hush pyflakes warning
469 * buildbot/status/tests.py: remove unused imports
470 * buildbot/status/tinderbox.py: same
471 * buildbot/steps/python_twisted.py: same
473 * buildbot/process/step.py: remove this file, these names were
474 deprecated in 0.7.5 and are now being removed.
475 * buildbot/process/step_twisted.py: same
476 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
478 * buildbot/twcompat.py: remove the empty file, yay it is gone
480 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
481 tw-2.0.0 and newer have the method we need.
482 (getProcessOutputAndValue): same
483 (which): remove this method, tw-2.0.0 t.p.procutils has it
485 * buildbot/twcompat.py (implements): remove this method
486 * buildbot/*: import implements() from zope.interface directly
488 * buildbot/status/mail.py: stop falling back to importing
489 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
492 * buildbot/twcompat.py (Interface): remove this import
493 * buildbot/*: import Interface from zope.interface directly
495 * buildbot/twcompat.py (providedBy): remove this method
496 * buildbot/*: turn all uses of providedBy(obj, iface) into
497 iface.providedBy(obj)
499 * buildbot/twcompat.py (maybeWait): remove this method, now that
500 we no longer maintain compatibility with Twisted<=1.3.0 .
501 Twisted-2.0.0 and later allow trial methods to return Deferreds
503 * buildbot/test/*: remove all uses of maybeWait
505 * buildbot/__init__.py (version): bump to 0.7.5+ while between
507 * docs/buildbot.texinfo: same
509 2006-12-10 Brian Warner <warner@lothar.com>
511 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
512 * docs/buildbot.texinfo: set version to match
514 2006-12-10 Brian Warner <warner@lothar.com>
516 * README (REQUIREMENTS): update for release
517 * NEWS: update for release
518 * buildbot/slave/commands.py (command_version): mention that this
519 version (2.2) was released with buildbot-0.7.5
521 * buildbot/test/test_config.py (StartService.testStartService):
522 inhibit the usual read-config-on-startup behavior, since otherwise
523 the log.err that gets recorded causes the test to fail
525 * buildbot/status/builder.py (LogFile.finish): forget about all
526 subscribers once the log has finished, since after that point
527 we're never going to use them again. This might help free up some
530 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
531 than the old/deprecated gtk.mainquit()
533 2006-12-09 Brian Warner <warner@lothar.com>
535 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
536 better when we can't open the masterdst file
538 * buildbot/scripts/startup.py (Follower._failure): add missing
539 import statement for BuildSlaveDetectedError
541 * buildbot/steps/transfer.py (FileUpload): cleanup
542 (FileDownload): same. Add tests for slave version, add mode=.
543 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
544 (SlaveFileDownloadCommand): same
545 * buildbot/test/test_transfer.py: enhance tests
546 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
549 2006-12-08 Brian Warner <warner@lothar.com>
551 * buildbot/scripts/runner.py (sendchange): halt the reactor on
552 both success *and* failure. Without this, the 'buildbot
553 sendchange' command would hang if it could not contact the
554 buildmaster or deliver the Change, which would generally cause the
555 user's commit/record/checkin command to hang too. Thanks to
556 Christian Unger for the catch.
558 2006-12-06 Brian Warner <warner@lothar.com>
560 * NEWS: update with items for the next release
562 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
563 whimsical example pulled from a punch-drunk email I sent out late
565 (Transferring Files): document some of the other parameters
566 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
567 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
568 * buildbot/test/test_svnpoller.py: same
569 * buildbot/changes/svnpoller.py (SVNPoller): same
571 2006-11-26 Brian Warner <warner@lothar.com>
573 * docs/buildbot.texinfo (Build Properties): remind users that
574 WithProperties must appear in a command= list, not as a top-level
576 * buildbot/steps/shell.py (ShellCommand.start): and assert that
577 we're sending a list or a single string to the RemoteShellCommand
579 * buildbot/scheduler.py (Nightly): Improve docs slightly.
581 * buildbot/scripts/startup.py (start): skip the whole
582 watch-the-logfile thing under windows, since it needs os.fork()
584 * buildbot/scripts/runner.py (restart): remove the old message
585 that got printed after the buildbot was restarted.. it most cases
586 it didn't get printed at the right time anyways
588 2006-11-25 Brian Warner <warner@lothar.com>
590 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
591 follow twistd.log and print lines until the process has started
592 started properly. For the buildmaster, this means until the config
593 file has been parsed and accepted. For the buildslave, this means
594 until we've connected to the master. We give up after 5 seconds in
595 any case. Helpful error messages and troubleshooting suggestions
596 are printed when we don't see a successful startup. This closes the
597 remainder of SF#1517975.
598 * buildbot/scripts/startup.py: moved app startup code to here
599 * buildbot/scripts/logwatcher.py: utility class to follow log
600 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
601 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
602 so the LogWatcher can tell the difference between a buildmaster
605 2006-11-24 Brian Warner <warner@lothar.com>
607 * docs/examples/twisted_master.cfg: update to match the version
608 in use on twistedmatrix.com
609 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
610 was using before stopped working, but 'irc.freenode.net' works
613 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
616 * buildbot/clients/base.py (TextClient.not_connected): upon
617 UnauthorizedLogin failures, remind the user to connect to the
618 PBListener port instead of the slaveport.
619 (TextClient.disconnected): shut down more quietly
620 * docs/buildbot.texinfo (statuslog): add another reminder
622 * buildbot/scripts/runner.py (Options.subCommands): rename
623 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
624 'sighup' as an alias.
625 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
626 reconfig command to follow twistd.log and print all of the lines
627 from the start of the config-file reload to its completion. This
628 should make it a lot easier to discover bugs in the config file.
629 Use --quiet to disable this behavior. This addresses half of
630 SF#1517975, the other half will be to add this same utility to
631 'buildbot start' and 'buildbot restart'.
632 * docs/buildbot.texinfo (Loading the Config File): same
635 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
636 method, it has been deprecated for a long time. Use
637 IBuilderControl.requestBuild instead.
638 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
639 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
640 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
641 * buildbot/test/test_control.py (Force.testForce): same
642 * buildbot/test/test_run.py: use requestBuild instead
644 * buildbot/clients/debug.py: replace 'Force Build' button with
645 'Request Build' (which just adds one to the queue), add Ping
646 Builder, add branch/revision fields to Request Build.
647 * buildbot/clients/debug.glade: same
648 * buildbot/master.py: update interface to match. This creates an
649 incompatibility between new debugclients and old buildmasters.
651 * buildbot/process/builder.py (Builder._attached): delay the call
652 to maybeStartBuild for a reactor turn, to avoid starting a build
653 in the middle of a reconfig (say, if the new Builder uses a new
654 slave which is already connected).
656 2006-11-23 Brian Warner <warner@lothar.com>
658 * buildbot/test/test_transfer.py: appease pyflakes
659 * buildbot/test/test_steps.py: same
661 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
662 keeps pyflakes from finding undefined names
664 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
665 Builder no longer induces a disconnect/reconnect cycle. This means
666 that any builds currently in progress will not be interrupted, and
667 any builds which are queued in the Builder will not be lost. This
668 is implemented by having the new Builder extract the state (i.e.
669 all pending Builds and any desired SlaveBuilders) from the old
671 (BotPerspective): refactor. The BotPerspective no longer keeps
672 track of all the Builders that want to use this slave; instead, it
673 asks the BotMaster each time it needs this list. This removes
674 addBuilder and removeBuilder. Clean up attached() to acquire all
675 the slave's information in a more atomic fashion. updateSlave() is
676 now the way to make sure the slave is using the right set of
677 Builders: just call it after everything else has been
679 (BotMaster): refactor, removing addBuilder/removeBuilder and
680 replacing them with an all-at-once setBuilders() call.
682 * buildbot/test/test_slaves.py (Reconfig): new test case to
683 exercise this functionality
684 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
685 * buildbot/slave/commands.py (WaitCommand): same
687 * docs/buildbot.texinfo (Loading the Config File): document the
690 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
691 SlaveBuilder to have its parent Builder changed.
692 (SlaveBuilder.isAvailable): new method to give access to state,
693 which is now a private attribute
694 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
695 the SlaveBuilder about how it is being used. These methods update
696 its internal state. buildFinished() is now the place that invokes
697 maybeStartBuild() on its parent Builder.
698 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
699 new Builder to take over for an old one, transferring state from
701 (Buider): refactor the way that SlaveBuilders are used to match,
702 giving them a bit more autonomy.
703 (Builder.buildFinished): this no longer calls maybeStartBuild():
704 instead the SlaveBuilder calls it on whoever its parent Builder is
705 at the time. This way, when an old Builder is replaced by a new
706 one, and there was a build in progress during the transition, when
707 that build finishes, it will be the new Builder that is told about
708 the newly available slave so it can start a new build.
710 * buildbot/process/base.py (Build.startBuild._release_slave): when
711 the Build finishes, tell the SlaveBuilder that they've been
714 * buildbot/status/builder.py (SlaveStatus): add some new setter
715 methods for use by BotPerspective, to keep some attributes more
718 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
719 called by the buildmaster.
720 (Bot.setBuilderList): instead, we locally announce any leftover
721 directories based upon which Builders we were told about. The
722 master doesn't really care; it's the local admin who may or may not
726 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
727 to allow use of python2.4 or whatever. This tool still requires
730 2006-11-19 Brian Warner <warner@lothar.com>
732 * NEWS (IStatusLog.readlines): more news items
734 2006-11-18 Brian Warner <warner@lothar.com>
736 * NEWS: start collecting items for the next release.
738 2006-11-04 Brian Warner <warner@lothar.com>
740 * buildbot/changes/bonsaipoller.py: apply updates from Ben
741 Hearsum. Closes SF#1590310.
742 * buildbot/test/test_bonsaipoller.py: and tests
744 * buildbot/status/tinderbox.py
745 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
746 status when the build results in WARNINGS. Patch from Dave
747 Liebreich. Closes SF#1587352.
749 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
750 linux-vs-osx behavior difference w.r.t. reading from files that
751 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
752 to Mark Rowe for the patch.
754 2006-10-15 Brian Warner <warner@lothar.com>
756 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
757 method name was misspelled in the interface definition. Thanks to
758 Roy Rapoport for the catch.
760 2006-10-13 Brian Warner <warner@lothar.com>
762 * docs/buildbot.texinfo (Adding LogObservers): update sample code
763 to match the great Steps renaming
765 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
766 Maybe I should run my own unit tests before recording a big
767 change. Good thing I've got a buildbot to remind me.
769 2006-10-12 Brian Warner <warner@lothar.com>
771 * buildbot/steps/transfer.py: rework __init__ and args setup
772 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
774 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
775 when opening the target file, only catch IOError (to report via
776 stderr/rc!=0), let the others be reported as normal exceptions
778 2006-10-08 Brian Warner <warner@lothar.com>
780 * contrib/svn_watcher.py: fix security holes by using proper argv
781 arrays and subprocess.Popen() rather than commands.getoutput().
782 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
783 is deprecated in favor of buildbot/changes/svnpoller.py, and will
784 probably be removed by the next release.
787 2006-10-04 Brian Warner <warner@lothar.com>
789 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
790 initial lines that weren't emitted by pyflakes. When the pyflakes
791 command is run under a Makefile, 'make' will echo the command it
792 runs to stdio, and that was getting logged as a "misc" warning.
793 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
794 * buildbot/test/test_steps.py (testPyFlakes3): another test
796 2006-10-01 Brian Warner <warner@lothar.com>
798 * buildbot/status/html.py (HtmlResource.render): if we get a
799 unicode object from our content() method, encode it into utf-8
800 like we've been claiming to all along. This allows the comments
801 and author names from svnpoller.py to be delivered properly.
803 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
804 de-unicodify filenames before creating the Change, because the
805 rest of buildbot is unlikely to handle them well. Leave the 'who'
806 field as a unicode object.. I don't think there's anything that
807 will break very soon, and it will probably nudge us towards
808 accepting unicode everywhere sooner or later. Stop using the
809 "date" field that comes out of SVN, since it is using the
810 repository's clock (and timezone) and what we care about is the
811 buildmaster's (otherwise Changes from the future show up later
812 than the builds they triggered).
813 * buildbot/test/test_svnpoller.py (Everything.test1): match the
816 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
817 Suvbersion repository polling ChangeSource. I've hacked it up
818 considerably: any bugs are entirely my own fault. Thank you
820 * buildbot/test/test_svnpoller.py: tests for it
821 * docs/buildbot.texinfo (SvnSource): document it
823 2006-09-30 Brian Warner <warner@lothar.com>
825 * buildbot/scheduler.py (Periodic): submit a reason= to the
826 BuildSet to indicate which Scheduler triggered the build. Thanks
827 to Mateusz Loskot for the suggestion.
829 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
831 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
832 changes: set self.loop in __init__, remove unused volatile=
834 * docs/buildbot.texinfo (.buildbot config directory): add more
835 docs on the .buildbot/options keys used by "buildbot try"
836 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
837 (Try.deliverJob): same
839 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
843 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
844 close the filehandle when we stop watching the file. Before, the
845 filehandle was only closed when the LogFileWatcher was
846 garbage-collected, which could be quite a while in the future. If
847 it was still open by the time the next build started, windows will
848 refuse to let the new build delete the old build/ directory. Fixes
849 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
850 #twisted for the catch.
852 2006-09-29 Brian Warner <warner@lothar.com>
854 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
857 2006-09-25 Brian Warner <warner@lothar.com>
859 * setup.py: the new buildbot.steps module wasn't being installed.
860 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
861 (testmsgs): add the extra stuff from buildbot/test/* so you can
862 run unit tests on an installed copy of buildbot, not just from
865 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
866 columns of 'svnlook changed' output contain status information, so
867 strip [:4] instead of [:6]. Depending upon what the status flags
868 were, this would sometimes lead to mangled filenames. Thanks to
869 Riccardo Magliocchetti for the patch. Closes SF#1545146.
871 * buildbot/steps/source.py (Monotone): initial Monotone support,
872 contributed by Nathaniel Smith. Still needs docs and tests, but
873 this code has been in use on the Monotone buildbot for a long
875 * buildbot/slave/commands.py (Monotone): slave-side support
876 * buildbot/changes/monotone.py (MonotoneSource): polling change
879 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
880 contributed a Change Source that polls a Bonsai server (a
881 kind of web-based viewcvs CGI script).
883 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
884 Hearsum contributed a status plugin which sends email in the same
885 format that Tinderbox does: this allows a number of tinderbox
886 tools to be driven by Buildbot instead. Thanks Ben!
888 2006-09-24 Brian Warner <warner@lothar.com>
890 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
891 Thanks to Robert Helmer for the patch.
893 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
894 BuildStatus about the buildslave name at the *beginning* of the
895 build, rather than at the end. Thanks to Alexander Lorenz for the
897 * buildbot/status/html.py (StatusResourceBuild.body): always
898 include the slavename in the build page, not just when the build
900 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
901 slavename in the email message
903 2006-09-21 Brian Warner <warner@lothar.com>
905 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
907 * docs/examples/glib_master.cfg: same
908 * docs/examples/hello.cfg: same
909 * docs/examples/twisted_master.cfg: same, update to current usage
911 2006-09-19 Brian Warner <warner@lothar.com>
913 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
914 (PyFlakes.createSummary): make it compatible with python-2.2
916 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
917 for at least the output-parsing parts of PyFlakes
919 2006-09-18 Brian Warner <warner@lothar.com>
921 * buildbot/steps/python.py: oops, fix import of StringIO
923 2006-09-17 Brian Warner <warner@lothar.com>
925 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
926 turns out that SVN-1.4.0 doesn't fail to update once you've
927 replaced a file with a directory, unlike older versions of SVN and
928 pretty much every other VC tool we support. Since what we really
929 care about is that the update succeeds anyway, stop checking that
930 the tree got clobbered and just assert that the build succeeded.
931 (VCBase.printLogs): add a utility function for debugging
933 * buildbot/process/step.py: oops, added extra imports by mistake
935 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
936 rstrip() on the first line coming out of the 'p4 describe'
937 process, to remove the stray ^M that Wade Brainerd reports seeing
938 in the 'when' field. Fixes SF#1555985.
940 * buildbot/master.py (BuildMaster.loadConfig): improve the error
941 message logged when c['schedulers'] is not right
942 * buildbot/scheduler.py (Scheduler.__init__): improve error
943 message when a Scheduler() is created with the wrong arguments
944 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
945 verify that these error messages are emitted
947 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
948 The idea is that all the base classes (like BuildStep and
949 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
950 will be a leftover backwards-compatibility file that only contains
951 aliases for the steps that were moved out to buildbot.steps.*
952 * lots: change imports to match
953 * buildbot/process/step.py: add a DeprecationWarning if it ever
956 2006-09-12 Brian Warner <warner@lothar.com>
958 * buildbot/scheduler.py (Scheduler.__init__): make sure that
959 builderNames= is actually a sequence, since if you happen to give
960 it a single builder-specification dictionary instead, it won't get
961 caught by the existing assert. Thanks to Brett Neely for the
964 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
966 * docs/buildbot.texinfo (Python BuildSteps): document them
967 (sendchange): include a link to PBChangeSource, since you need one
969 * buildbot/steps/shell.py: clean up test-case-name line, remove some
971 * buildbot/steps/dummy.py: same
973 2006-09-08 Brian Warner <warner@lothar.com>
975 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
976 BuildStep which lets you transfer files from the master to the
977 slave or vice versa. Thanks to Albert Hofkamp for the original
978 patch. Fixes SF#1504631.
979 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
981 (SlaveFileDownloadCommand): same
982 * docs/buildbot.texinfo (Transferring Files): document it
983 * buildbot/test/test_transfer.py: test it
984 * buildbot/test/runutils.py (StepTester): new utility class for
985 testing BuildSteps and RemoteCommands without Builds or Bots or PB
986 * buildbot/test/test_steps.py (CheckStepTester): validate that the
989 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
990 walk through StatusLogs one line at a time, mostly for the benefit
991 of ShellCommand.createSummary methods. You can either walk through
992 STDOUT or STDERR, but the default is STDOUT.
994 * buildbot/status/builder.py (LogFile.readlines): implement it.
995 Note that this is not yet memory-efficient, it just pulls the
996 whole file into RAM and then splits it up with a StringIO.
997 Eventually this should be a generator that only pulls chunks from
999 * buildbot/test/test_status.py (Log.testReadlines): test it
1001 * docs/buildbot.texinfo: update to match changes
1002 * buildbot/process/factory.py: stop using old definitions
1003 * buildbot/process/process_twisted.py: same
1004 * buildbot/test/test_*.py: same
1006 * buildbot/process/step_twisted.py: move definition to..
1007 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1008 relative-import mechanisms prevent this from being named 'twisted'
1009 or 'python/twisted' as I would have preferred.
1011 * buildbot/process/maxq.py: move definition to..
1012 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1014 * buildbot/process/step.py: split the user-visible BuildSteps into
1015 separate files, all under buildbot/steps/
1016 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1017 * buildbot/steps/shell.py: this holds ShellCommand and friends
1018 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1020 2006-09-05 Brian Warner <warner@lothar.com>
1022 * lots: run pyflakes, removed a lot of unused imports, changed the
1023 form of some conditional imports to remove false pyflakes
1024 warnings. There are still a number of warnings left, mostly from
1025 imports that are done for their side-effects.
1026 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1029 2006-08-26 Brian Warner <warner@lothar.com>
1031 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1032 compatible with twisted-1.3.0, for some reason I just can't seem
1033 to let go of the past.
1035 2006-08-25 Brian Warner <warner@lothar.com>
1037 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1039 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1040 all logfiles= in startCommand(), rather than in start() . This
1041 makes it easier to have the 'stdio' log come before any secondary
1042 logfiles, which I feel makes the waterfall display more
1044 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1045 from ShellCommand up into LoggingBuildStep
1046 (LoggingBuildStep.__init__): move the handling of logfiles= from
1047 ShellCommand up to LoggingBuildStep, because startCommand is
1048 provided by LoggingBuildStep, whereas start() was specific to
1049 subclasses like ShellCommand and Source. This removes code
1050 duplication in those subclasses.
1051 (ShellCommand.__init__): same
1052 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1053 for a slave that's too old to understand logfiles= into a separate
1054 method, so it can live in ShellCommand. The rest of
1055 setupLogfiles() can live in LoggingBuildStep.
1057 2006-08-24 Brian Warner <warner@lothar.com>
1059 * buildbot/locks.py (BaseLock): you can now configure Locks to
1060 allow multiple simultaneous owners. They still default to
1061 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1063 * docs/buildbot.texinfo (Interlocks): document the new options
1064 * buildbot/test/test_locks.py: add a bunch of new unit tests
1065 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1066 waitUntilMaybeAvailable, not waitUntilAvailable
1067 * buildbot/process/step.py (BuildStep.acquireLocks): same
1068 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1069 the whole lockid in their constructor, not just the name. Also,
1070 keep track of which real locks we've handed out by the full
1071 lockid, not just class+name, otherwise changing just the maxCount=
1072 in the master.cfg file would not actually cause a behavioral
1075 2006-08-23 Brian Warner <warner@lothar.com>
1077 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1079 * docs/buildbot.texinfo: same
1081 2006-08-23 Brian Warner <warner@lothar.com>
1083 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1084 * docs/buildbot.texinfo: set version to match
1085 * NEWS: update for 0.7.4
1086 * buildbot/slave/commands.py (command_version): mention that this
1087 version (2.1) was released with buildbot-0.7.4
1089 2006-08-22 Brian Warner <warner@lothar.com>
1093 * CREDITS: new file, list of people who have helped. Thanks!
1094 * MANIFEST.in: ship it
1096 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1097 new diagrams, the user's manual is more informative than it was.
1098 Start shipping the .html user's manual (and generated .png
1100 * Makefile: update 'release' target to match
1102 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1103 test.. I think the web-parts effort will render it pointless well
1104 before it ever actually starts to work.
1106 2006-08-20 Brian Warner <warner@lothar.com>
1108 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1109 meaning of the prefix= argument. It is now just a string which is
1110 stripped from the beginning of the filename. If prefix= is set but
1111 not found on any given filename, that filename is ignored. If all
1112 filenames in a Change are ignored, the Change is dropped. This is
1113 much simpler than the previous sep= nonsense, and I should have
1114 implemented it this way from the beginning. Effectively resolves
1115 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1116 Gedminas for the catch and suggested fixes.
1117 (ChangePerspective.perspective_addChange): implement the actual
1119 * buildbot/test/test_changes.py (TestChangePerspective): test it
1120 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1121 how to properly use prefix=
1122 * docs/examples/twisted_master.cfg (source): update prefix= by
1123 adding the trailing slash
1126 * docs/examples/twisted_master.cfg: update to actual practice
1128 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1129 update test case to match new link text.. the HREF has both a
1130 class= setting and an enclosing [] pair that I didn't match in the
1133 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1134 list of strings is preferred over a single string with embedded
1136 (ShellCommand.description=): explain that either single strings or
1137 a list of strings is acceptable, and why you might prefer one over
1138 the other. Add an example. Fixes SF#1524659, thanks to Paul
1139 Winkler for the catch.
1140 (Build Steps): update to use f.addStep() rather than using s()
1141 and the constructor list
1143 * buildbot/process/step.py (ShellCommand): accept either a single
1144 string or a list of strings in both description= and
1146 * buildbot/test/test_steps.py (Steps.test_description): test it
1147 * buildbot/test/runutils.py (makeBuildStep): support for that test
1149 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1150 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1151 collecting the files and creating the patch.
1153 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1154 per-step URLs that will be displayed on the waterfall display,
1155 for things like the HTML output of code-coverage tools, when
1156 the results are hosted elsewhere.
1157 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1158 way to retrieve these URLs
1159 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1160 the method to retrieve these URLs. Also provide backwards
1161 compatibility for saved BuildStepStatus instances that didn't have
1163 * buildbot/process/step.py (BuildStep.addURL): method to set these
1164 URLs from within a BuildStep
1165 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1166 (StepBox.getBox): give these external links a distinct CSS class
1167 named "BuildStep external" so a .css file can display them
1170 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1172 * buildbot/test/test_steps.py (Steps): test that we can all the
1173 URLs. Also add a bunch of other tests on methods that can be
1174 called from within BuildSteps
1175 * buildbot/test/runutils.py (makeBuildStep): add utility function
1177 2006-08-13 Brian Warner <warner@lothar.com>
1179 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1181 2006-08-10 Brian Warner <warner@lothar.com>
1183 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1184 index, this one of things like c['sources'] and c['schedulers']
1185 (indices): it looks like my clever idea of putting the @fooindex
1186 commands in between the @node and the @subsection (to make the
1187 HREF anchor jump to slightly above the section title, which works
1188 much better in html) confused texinfo horribly, so I'm moving the
1189 index tags back to be just after the @subsection marker. I also
1190 added extra lines between the @node/@section paragraph and the
1191 index tags, since I think maybe texinfo wants to see these be
1192 separate paragraphs.
1194 * docs/Makefile (images): make sure images get built when
1195 rendering the manual
1196 * docs/images/Makefile: same
1198 * buildbot/scripts/runner.py: rename 'buildbot master' to
1199 'buildbot create-master', and 'buildbot slave' to 'buildbot
1201 * docs/buildbot.texinfo: same
1204 * docs/buildbot.texinfo: reimplement the "useful classes" index
1205 with actual texinfo indices. The .info rendering is a bit
1206 weird-looking but it works well, and the HTML rendering is quite
1207 nice. This also puts the index targets in the regular flow of the
1208 text, which is easier to maintain.
1210 2006-08-06 Brian Warner <warner@lothar.com>
1212 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1213 Kevin Turner to prefer the environ= argument be a list rather than
1214 a string. If it is a list, it will be joined with a platform-local
1215 os.pathsep delimiter, and then prepended to any existing
1216 $PYTHONPATH value. This works better in cross-platform (i.e.
1217 windows buildslaves) environments when you need to push multiple
1218 directories onto the front of the path.
1219 (SlaveShellCommand): documented the new magic
1220 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1221 in a user-visible form
1223 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1224 Turner to prefer lists over strings when creating/running VC
1225 commands during unit tests. This is clearly necessary to survive
1226 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1227 renamed the wq() function to qw() though, since that's how it's
1228 spelled in perl. Eventually I'd prefer all commands to be
1229 specified with lists.
1231 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1232 which are deleted (or not yet created) correctly. Also add
1233 failsafe code to not explode if the file-watching poller doesn't
1234 get started. Thanks to JP Calderone for the catch and the poller
1236 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1238 * buildbot/test/emitlogs.py: same
1240 * NEWS: summarize recent changes
1242 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1243 clause to avoid the "host key mismatch" warning
1245 * buildbot/process/step_twisted.py (Trial.start): if the
1246 buildslave is too old to understand logfiles=, fall back to
1247 running 'cat _trial_temp/test.log' like before.
1248 (Trial.commandComplete): same. this takes advantage of the
1249 LoggingBuildStep refactoring to stall commandComplete long enough
1250 to run a second RemoteShellCommand.
1252 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1253 refactor command-completion handling, to allow methods like
1254 commandComplete/createSummary/evaluateCommand to return Deferreds.
1255 (LoggingBuildStep._commandComplete): delete the refactored method
1256 (ShellCommand.setupLogfiles): if the buildslave is too old to
1257 understand logfiles=, put a warning message both into twistd.log
1258 and into the otherwise empty user-visible LogFiles.
1260 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1261 callers to provide the slave-side logfile name, rather than
1262 forcing it to come from the local name of the LogFile.
1263 (BuildStep.getSlaveName): new method
1265 * buildbot/process/base.py (Build.getSlaveName): new method, so
1266 steps can find out which buildslave they're running on
1268 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1269 to match the s/cvs_ver/command_version/ change
1271 2006-08-05 Brian Warner <warner@lothar.com>
1273 * buildbot/slave/commands.py (command_version): replace the CVS
1274 auto-updated cvs_ver keyword with a manually-updated variable,
1275 since CVS is no longer the master repository. Add a description of
1276 the remote API change starting in this version (2.1), specifically
1277 the fact that SlaveShellCommand now accepts 'initial_stdin',
1278 'keep_stdin_open', and 'logfiles'.
1280 2006-07-31 Brian Warner <warner@lothar.com>
1282 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1283 diagrams to describe how the whole system fits together. The
1284 images themselves are kept in SVG files, with ascii-art versions
1285 in corresponding .txt files. Texinfo knows how to interpolate the
1286 text version into .info files, reference the .png versions from
1287 .html files, and include .eps versions in the .ps format.
1288 * docs/images/Makefile: tools to create .png and .eps
1289 * docs/images/*.svg: created pictures with Inkscape.
1290 * .darcs-boring: ignore the generated .eps and .png files
1292 2006-07-24 Brian Warner <warner@lothar.com>
1294 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1295 Scheduler names, since they cause setServiceParent to explode
1297 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1299 2006-07-20 Brian Warner <warner@lothar.com>
1301 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1302 which runs the buildbot unit tests
1304 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1305 classes that are useful in master.cfg
1307 2006-07-15 Brian Warner <warner@lothar.com>
1309 * Makefile (some-apidocs): new target to build only some epydocs
1311 * setup.py: minor comment.. does the classifiers= argument prevent
1312 the setup.py script from working on python2.2/2.3?
1314 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1317 * buildbot/twcompat.py: fix minor typo in comments
1319 * buildbot/manhole.py: move all Manhole-related code out to this
1320 module. Implement SSH-based manholes (with TwistedConch), and move
1321 to conch's nifty line-editing syntax-coloring REPL shell instead
1322 of the boring non-editing monochromatic (and deprecated) old
1324 * buildbot/master.py: remove all Manhole-related code
1325 (BuildMaster.loadConfig._add): make sure the old manhole is
1326 removed before we add the new one
1327 * docs/buildbot.texinfo (Debug options): document new Manhole options
1329 * buildbot/twcompat.py (_which): fix some epydoc issues
1330 * buildbot/status/html.py (Waterfall.__init__): same
1332 2006-06-29 Brian Warner <warner@lothar.com>
1334 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1335 deprecation warnings under newer Twisteds (by using
1336 zope.interface.Interface instead of old twisted.python.components
1338 * buildbot/slave/interfaces.py: same
1340 2006-06-28 Brian Warner <warner@lothar.com>
1342 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1343 svn commands, so it will fail immediately instead of hanging while
1344 it waits for a username/password to be typed in.
1346 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1347 log message if the step was shut down
1349 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1350 obsolete reference to mktap.
1352 2006-06-20 Brian Warner <warner@lothar.com>
1354 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1355 test to include new 'logfiles' argument sent from master to slave
1357 2006-06-19 Brian Warner <warner@lothar.com>
1359 * buildbot/process/step_twisted.py (Trial): track Progress from
1360 _trial_temp/test.log too
1362 * buildbot/process/step.py (OutputProgressObserver): generalize
1363 the earlier StdioProgressObserver into an OutputProgressObserver
1364 that can track LogFiles other than stdio.
1365 (LoggingBuildStep.__init__): same
1367 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1368 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1369 will fail under windows because of os.sep issues. It might have
1370 worked before if 'cat' was doing cygwin path conversion.
1372 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1373 creation of LogFileWatchers
1374 (ShellCommand._startCommand): and record the files that were
1375 watched in the 'headers' section of the ShellCommand output
1377 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1378 need to actually pass it to the slave if you want it to work.
1379 (ShellCommand): document it a bit
1381 * buildbot/test/test_shell.py: new test to validate LogFiles
1382 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1384 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1385 before printing the last batch of lines, to test that the polling
1386 logic is working properly
1388 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1389 handling, making it possible to track multiple logs for a single
1390 RemoteCommand. The previous single logfile is now known as the
1392 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1393 (RemoteShellCommand.__init__): accept logfiles=
1394 (LoggingBuildStep.startCommand): stdio_log is now one of many
1395 (ShellCommand): added logfiles= argument, as well as a class-level
1396 .logfiles attribute, which will be merged together to figure out
1397 which logfiles should be tracked. The latter maybe be useful for
1398 subclasses of ShellCommand which know they will aways produce
1399 secondary logfiles in the same location.
1401 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1402 and closeStdin() methods, preparing to make it possible to write
1403 to a ShellCommand's stdin at any time, not just at startup. These
1404 writes are buffered if the child process hasn't started yet.
1405 (LogFileWatcher): new helper class to watch arbitrary logfiles
1406 while a ShellCommand runs. This class polls the file every two
1407 seconds, and sends back 10k chunks to the buildmaster.
1408 (ShellCommand): rename stdin= to initialStdin=, and add
1409 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1411 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1412 key of "log" and a value of (logname, data).
1413 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1414 'logfiles' to the master-visible args dictionary.
1415 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1418 * buildbot/test/test_vc.py (Patch.testPatch): same
1421 * buildbot/test/emit.py: write to a logfile in the current
1422 directory. We use this to figure out what was used as a basedir
1423 rather than looking to see which copy of emit.py gets run, so that
1424 we can run the commands from inside _trial_temp rather than inside
1426 * buildbot/test/subdir/emit.py: same
1427 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1428 argument rather than running from buildbot/test/
1429 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1430 rather than using an implicit setUp()
1431 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1432 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1433 of assuming that we're running in buildbot/test/ (and that '.' is
1436 * buildbot/slave/commands.py (Command.doStart): refactor Command
1437 startup/completion a bit: now the SlaveBuilder calls doStart(),
1438 which is not meant for overridding by subclasses, and doStart()
1439 calls start(), which is. Likewise the SlaveBuilder calls
1440 doInterrupt(), and subclasses override interrupt(). This also puts
1441 responsibility for maintaining .running in Command rather than in
1443 (Command.doInterrupt): same
1444 (Command.commandComplete): same, this is called when the deferred
1445 returned by start() completes.
1446 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1447 (SlaveBuilder.remote_interruptCommand): same
1448 (SlaveBuilder.stopCommand): same
1450 2006-06-16 Brian Warner <warner@lothar.com>
1452 * buildbot/test/test_shell.py: new test file to contain everything
1453 relating to ShellCommand
1454 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1455 multiple logfiles in realtime" feature, not yet implemented
1456 * buildbot/test/emitlogs.py: support file for testLogFiles
1457 * docs/buildbot.texinfo (ShellCommand): document the feature
1459 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1461 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1462 for tests which exercise SlaveCommands in isolation.
1464 * buildbot/test/test_slavecommand.py: Move some utilities like
1465 SignalMixin and FakeSlaveBuilder from here ..
1466 * buildbot/test/runutils.py: .. to here, so they can be used by
1467 other test classes too
1468 * buildbot/test/test_vc.py: more SignalMixin refactoring
1469 * buildbot/test/test_control.py: same
1470 * buildbot/test/test_run.py: and some rmtree refactoring
1472 2006-06-15 Brian Warner <warner@lothar.com>
1474 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1475 'testBranch' to match other VC tests and have the tests run in
1476 roughly increasing order of dependency
1478 * buildbot/test/test_steps.py (LogObserver): new test to verify
1479 LogObservers can be created at various times and still get
1480 connected up properly
1482 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1483 to create BuildStepStatus instances that actually work.
1485 * buildbot/process/step.py (LogObserver): add outReceived and
1486 errReceived base methods, to be overridden
1488 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1489 API to take a name instead of a step, reducing the coupling
1490 somewhat. This returns the BuildStepStatus object so it can be
1491 passed to the new Step, instead of jamming it directly into the
1493 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1495 * buildbot/process/base.py (Build.setupBuild): use both methods
1496 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1497 process a bit to match
1499 2006-06-14 Brian Warner <warner@lothar.com>
1501 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1502 docs on writing new LogObserver classes
1503 (Writing New Status Plugins): brief docs on how Status Plugins fit
1506 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1507 implement a LogObserver that counts how many unit tests have been
1509 (Trial.__init__): wire it in
1510 * buildbot/test/test_twisted.py (Counter): unit test for it
1512 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1513 to new cmd.logs['stdio'] scheme
1514 (Trial.commandComplete): same
1515 (BuildDebs.commandComplete): same
1517 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1518 LogFiles, instead of just a single one. The old single logfile is
1519 now called "stdio". LoggedRemoteCommand no longer creates a
1520 LogFile for you (the code to do that was broken anyway). If you
1521 don't create a "stdio" LogFile, then stdout/stderr will be
1523 (LogObserver): implement "LogObservers", which a BuildStep can add
1524 to parse the output of a command in real-time. The primary use is
1525 to provide more useful information to the Progress code, allowing
1526 better ETA estimates.
1527 (LogLineObserver): utility subclass which feeds complete lines to
1528 the parser instead of bytes.
1529 (BuildStep.progressMetrics): this is safer as a tuple
1530 (BuildStep.setProgress): utility method, meant to be called by
1532 (BuildStep.addLogObserver): new method, to be called at any time
1533 during the BuildStep (even before any LogFiles have been created),
1534 to attach (or schedule for eventual attachment) a LogObserver to a
1536 (StdioProgressObserver): new LogObserver which replaces the old
1537 "output" progress gatherer
1538 (LoggingBuildStep.__init__): same
1539 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1540 (LoggingBuildStep._commandComplete): must use logs['stdio']
1541 instead of the old single ".log" attribute.
1542 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1543 functionality, now subsumed into StdioProgressObserver
1544 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1545 log name changed from "output" to "stdio".
1548 * buildbot/interfaces.py (ILogFile): add the Interface used from
1549 the BuildStep towards the LogFile
1550 (ILogObserver): and the one provided by a LogObserver
1551 * buildbot/status/builder.py (LogFile): implement it
1553 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1554 HEADER constants here ..
1555 * buildbot/status/builder.py (STDOUT): .. from here
1557 2006-06-13 Brian Warner <warner@lothar.com>
1559 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1560 compatibility with python2.2, which doesn't have the 'substr in
1562 (TestP4Poller.makeTime): utility function to construct the
1563 timestamp using the same strptime() approach as p4poller does. It
1564 turns out that time.mktime() behaves slightly differently under
1565 python2.2, probably something to do with the DST flag, and that
1566 causes the test to fail under python2.2. (changing the mktime()
1567 arguments to have dst=0 instead of -1 caused it to fail under
1568 python2.3. Go figure.)
1569 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1571 2006-06-12 Brian Warner <warner@lothar.com>
1573 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1574 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1575 contributing such an excellent patch, including docs and unit
1576 tests! This makes it *so* much easier to apply. I had to update
1577 test_vc.py to handle some recent refactorings, but everything else
1578 applied smoothly. The only remaining thing I'd like to fix would
1579 be to remove the hard-wired port 1666 used by p4d, and allow it to
1580 claim any unused port. This would allow two copies of the test
1581 suite to run on the same host at the same time, as well as
1582 allowing the test suite to run while a real (production) p4d was
1583 running on the same host. Oh, and maybe we should add a warning to
1584 step.P4 that gets emitted if the slave is too old to provide the
1585 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1586 * buildbot/slave/commands.py (P4): same
1587 (P4Sync): same, some minor updates
1588 * buildbot/changes/p4poller.py: same
1589 * docs/buildbot.texinfo: same
1590 * buildbot/test/test_p4poller.py: same
1591 * buildbot/test/test_vc.py (P4): same
1593 * setup.py: add Trove classifiers for PyPI
1595 2006-06-08 Brian Warner <warner@allmydata.com>
1597 * buildbot/status/client.py
1598 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1599 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1600 build needs to be IRemote'd separately, rather than IRemote'ing
1601 the whole list at once. I can't wait until newpb's serialization
1602 adapters make this unnecessary.
1604 2006-06-06 Brian Warner <warner@lothar.com>
1606 * buildbot/process/step.py (WithProperties): make this inherit
1607 from ComparableMixin, so that reloading an unchanged config file
1608 doesn't cause us to spuriously reload any Builders which use them.
1609 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1612 2006-06-03 Brian Warner <warner@lothar.com>
1614 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1615 running py2exe on windows, contributed by Mark Hammond. Addresses
1616 SF#1401121, but I think we still need to include
1617 buildbot/scripts/sample.cfg
1618 * setup.py: include buildbot_service.py as a script under windows
1619 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1620 a py2exe application), get the icon/css datafiles from a different
1623 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1624 double-escape the build URL. Thanks to Olivier Bonnet for the
1625 patch. Fixes SF#1452801.
1627 2006-06-02 Brian Warner <warner@lothar.com>
1629 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1630 first six columns of 'svnlook' output, not just the first column,
1631 since property changes appear in the other five. Thanks to Olivier
1632 Bonnet for the patch. Fixes SF#1398174.
1634 2006-06-01 Brian Warner <warner@lothar.com>
1636 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1637 the fake build, so that title= has something to be set to
1639 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1640 attribute of the "Build #NN" link in the yellow start-the-build
1641 box to the build's reason. This means that you get a little
1642 tooltip explaining why the build was done when you hover over the
1643 yellow box. Thanks to Zandr Milewski for the suggestion.
1645 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1646 (Box.setETA): handle ETA=None (by stopping the timer)
1647 (Box.update): make the [soon] text less different than the usual
1648 text, so the rest of the text doesn't flop around so much. It
1649 would be awfully nice to figure out how to center this stuff.
1650 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1652 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1653 by default, so that any ShellCommand which fails marks the overall
1654 build as a failure. I should have done this from the beginning.
1655 Add flunkOnFailure=False to the arguments if you want to turn off
1658 2006-05-30 Brian Warner <warner@lothar.com>
1660 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1661 last-build/current-build/current-step. Show what step is currently
1662 running. Show ETA for both the overall build and the current step.
1663 Update GTK calls to modern non-deprecated forms. There's still a
1664 lot of dead code and debug noise to remove.
1666 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1667 shows up properly in status displays
1669 2006-05-28 Brian Warner <warner@lothar.com>
1671 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1672 build we use to verify that WithProperties works:
1674 ** set flunkOnFailure=True so that build failures get noticed
1675 ** set workdir='.' so that the build succeeds, otherwise it is trying
1676 to touch 'build/something', and 'build/' doesn't exist because
1677 usually that's created by a Source step
1678 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1679 this test somehow triggers, in which the 'touch' process becomes
1680 a zombie and we wait for th etimeout before giving up on it.
1682 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1683 to log the Build results and step logs to the twisted log.
1684 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1685 what went wrong if a build was expected to succeed but didn't.
1687 * buildbot/process/step_twisted.py (Trial): set the default
1688 trialMode to '--reporter=bwverbose', which specifies verbose
1689 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1690 '-to', but those are completely missing in modern Twisteds.
1692 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1693 a localhost-only port, to encourage better security
1695 * docs/buildbot.texinfo (Change Sources): mention
1698 * .darcs-boring: add a Darcs boringfile
1700 * README (REQUIREMENTS): stop claiming compatibility with
1703 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1706 2006-05-27 Brian Warner <warner@lothar.com>
1708 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1709 * docs/buildbot.texinfo: same
1711 2006-05-23 Brian Warner <warner@lothar.com>
1713 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1714 * docs/buildbot.texinfo: set version to match
1715 * NEWS: update for 0.7.3
1717 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1718 give a quick mapping from VC system to possible ChangeSources
1719 (Build Properties): add 'buildername'
1721 * buildbot/process/base.py (Build.setupStatus): oops, set
1722 'buildername' and 'buildnumber' properties
1723 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1726 2006-05-22 Brian Warner <warner@lothar.com>
1728 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1729 property interpolation better
1731 * README (INSTALLATION): remove old '-v' argument from recommended
1734 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1735 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1738 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1739 'svnversion' instead of grepping the output of 'svn info', much
1740 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1741 Bonnet for the suggestion.
1742 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1743 require the WC_PATH argument, so run 'svnversion .' instead.
1745 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1746 aren't supposed to have 'self' in their argument list
1748 2006-05-21 Brian Warner <warner@lothar.com>
1750 * buildbot/process/step.py (ShellCommand.start): make
1751 testInterpolate pass. I was passing the uninterpolated command to
1752 the RemoteShellCommand constructor
1753 (ShellCommand._interpolateProperties): oops, handle non-list
1754 commands (i.e. strings with multiple words separated by spaces in
1755 them) properly, instead of forgetting about them.
1757 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1758 to actually try to use build properties in a real build. This test
1760 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1761 to start and evaluate builds
1763 * buildbot/test/test__versions.py: add a pseudo-test to record
1764 what version of Twisted/Python/Buildbot are running. This should
1765 show up at the beginning of _trial_tmp/test.log, and exists to help
1766 debug other problems.
1768 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1769 a filename to be served as 'robots.txt' to discourage web spiders.
1770 Adapted from a patch by Tobi Vollebregt, thanks!
1771 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1772 (Waterfall.test_waterfall): tweak the way that filenames are put
1773 into the config file, to accomodate windows pathnames better.
1775 * docs/buildbot.texinfo (HTML Waterfall): document it
1777 * buildbot/process/process_twisted.py
1778 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1779 changed the build process. The new setup.py no longer takes the
1781 (FullTwistedBuildFactory.__init__): same
1782 (TwistedReactorsBuildFactory.__init__): same
1784 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1785 be placed in the [hooks] section of the central repository (the
1786 one that everybody pushes changes to).
1788 2006-05-20 Brian Warner <warner@lothar.com>
1790 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1791 .darcs-context file, use binary mode. I think this was causing a
1792 Darcs failure under windows.
1794 2006-05-19 Brian Warner <warner@lothar.com>
1796 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1797 use a timezone string of +0000 and gmtime, since this timestamp is
1798 sent to a buildmaster and %z is broken.
1800 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1801 string and localtime, since this timestamp will only be consumed
1802 locally, and %z is broken.
1804 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1805 gmtime, since this timestamp is returned to the buildmaster, and
1808 2006-05-18 Brian Warner <warner@lothar.com>
1810 * NEWS: update in preparation for next release
1812 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1813 setup-repository and do-we-have-the-vc-tools code into a separate
1814 "helper" class, which sticks around in a single module-level
1815 object. This seems more likely to continue to work in the future
1816 than having it hide in the TestCase and hope that TestCases stick
1817 around for a long time.
1819 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1820 addremove' has been deprecated in recent versions of mercurial, so
1821 use 'hg add' instead
1823 2006-05-07 Brian Warner <warner@lothar.com>
1825 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1826 operating under windows, move the file before opening it, since
1827 you can't rename a file that somebody has open.
1829 * buildbot/process/base.py (Build.setupBuild): if something goes
1830 wrong while creating a Step, log the name and arguments, since the
1831 error message when you get the number of arguments wrong is really
1834 2006-05-06 Brian Warner <warner@lothar.com>
1836 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1837 bugs in twisted-specific code not covered by my unit tests, this
1838 time use 'cmd' argument instead of self.cmd
1840 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1841 fix stupid braino: either use startwith or find()==0, not both.
1842 (TwistedReactorsBuildFactory.__init__): another dumb typo
1844 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1845 mark this test as TODO under windows, since process-killing seems
1846 dodgy there. We'll come back to this later and try to fix it
1849 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1850 and don't include a timezone
1851 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1852 This should avoid the windows-with-verbose-timezone-name problem
1854 (Patch.testPatch): add a test which runs 'patch' with less
1855 overhead than the full VCBase.do_patch sequence, to try to isolate
1856 a windows test failure. This one uses slave.commands.ShellCommand
1857 and 'patch', but none of the VC code.
1859 * buildbot/slave/commands.py (getCommand): use which() to find the
1860 executables for 'cvs', 'svn', etc. This ought to help under
1863 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1864 working directory before starting. If an earlier test failed, the
1865 leftover directory would mistakenly flunk a later test.
1866 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1867 Make sure that we use the right commandlines if which("tla") picks
1868 up "tla.exe" (as it does under windows).
1869 (TlaSupport.do_get): factor out this tla-vs-baz difference
1870 (TlaSupport.vc_create): more tla-vs-baz differences
1872 * buildbot/test/test_slavecommand.py
1873 (ShellBase.testShellMissingCommand): stop trying to assert
1874 anything about the error message: different shells on different
1875 OSes with different languages makes it hard, and it really isn't
1876 that interesting of a thing to test anyway.
1878 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1879 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1880 "Panther"), because it has a bug which flunks a couple tests in
1881 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1882 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1883 able to test that yet.
1885 2006-04-30 Brian Warner <warner@lothar.com>
1887 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1888 make sure child commands emit messages in english, so our regexps
1889 will match. Thanks to Nikaus Giger for identifying the problems.
1890 (VCBase._do_vctest_export_1): mode="export" is not responsible
1891 for setting the "got_revision" property, since in many cases it is
1892 not convenient to determine.
1893 (SVNSupport.capable): when running 'svn --version' to check for
1894 ra_local, we want error messages in english
1895 * buildbot/test/test_slavecommand.py
1896 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1897 to emit the error message in english
1899 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1900 the environment with $LC_ALL="C" so that Commands which need to
1901 parse the output of their child processes can obtain it in
1903 (SVN.parseGotRevision): call "svn info" afterwards instead of
1904 watching the output of the "svn update" or "svn checkout".
1905 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1906 (Arch.parseGotRevision): same
1907 (Bazaar.parseGotRevision): same
1908 (Mercurial.parseGotRevision): same
1910 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1911 $LC_ALL="C" when running commands under 'buildbot try', too
1913 * buildbot/test/__init__.py: remove the global os.environ()
1914 setting, instead we do it just for the tests that run commands and
1915 need to parse their output.
1917 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1918 remove the overly-short .timeout on this test, because non-DNotify
1919 platforms must fall back to polling which happens at 10 second
1920 intervals, so a 5 second timeout would never succeed.
1922 2006-04-24 Brian Warner <warner@lothar.com>
1924 * docs/buildbot.texinfo (Installing the code): update trial
1925 invocation, SF#1469116 by Niklaus Giger.
1926 (Attributes of Changes): updated branch-name examples to be
1927 a bit more realistic, SF#1475240 by Stephen Davis.
1929 * contrib/windows/buildbot2.bat: utility wrapper for windows
1930 developers, contributed by Nick Trout (after a year of neglect..
1931 sorry!). SF#1194231.
1933 * buildbot/test/test_vc.py (*.capable): store the actual VC
1934 binary's pathname in VCS[vcname], so it can be retrieved later
1935 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1936 strip out non-numeric timezone information, specifically the funky
1937 German string that his system produced that confuses CVS.
1938 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1939 allow Darcs tests to work on windows
1940 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1941 procutils.which() everywhere, to allow tryclient to work under
1942 windows. Also from Niklaus Giger, SF#1463394.
1944 * buildbot/twcompat.py (which): move the replacement for a missing
1945 twisted.python.procutils.which from test_vc.py to here, so it can
1946 be used in other places too (specifically tryclient.py)
1948 2006-04-23 Brian Warner <warner@lothar.com>
1950 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1951 bare buildbotURL/projectName line with a proper DIV, along with a
1952 CSS class of "title", from Stefan Seefeld (SF#1461675).
1953 (WaterfallStatusResource.body0): remove the redundant 'table'
1954 class from the table
1955 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1956 to the top-row TR, and class="Activity" to the second-row TR,
1957 rather than putting them in the individual TD nodes.
1959 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1960 'got_revision' build property for all VC systems that implement
1961 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1963 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1964 to determine which revision we actually obtained
1965 (CVS.parseGotRevision): implement this for CVS, which just means
1966 to grab a timestamp. Not ideal, and it depends upon the buildslave
1967 having a clock that is reasonably well syncronized with the server,
1968 but it's better than nothing.
1969 (SVN.parseGotRevision): implement it for SVN, which is accurate
1970 (Darcs.parseGotRevision): same
1971 (Arch.parseGotRevision): same
1972 (Bazaar.parseGotRevision): same
1973 (Mercurial.parseGotRevision): same
1975 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1976 keep a record of all non-stdout/stderr/header/rc status updates,
1977 for the benefit of RemoteCommands that send other useful things,
1979 (Source.commandComplete): put any 'got_revision' status values
1980 into a build property of the same name
1983 * buildbot/process/step_twisted.py (Trial): update to deal with
1984 new ShellCommand refactoring
1986 * docs/buildbot.texinfo (Build Properties): document new feature
1987 that allows BuildSteps to get/set Build-wide properties like which
1988 revision was requested and/or checked out.
1990 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1991 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1992 it. Note that this bumps the persistenceVersion of the saved Build
1993 object, so add the necessary upgrade-old-version logic to include
1994 an empty properties dict.
1996 * buildbot/process/base.py (Build.setProperty): implement it
1997 (Build.getProperty): same
1998 (Build.startBuild): change build startup to set 'branch',
1999 'revision', and 'slavename' properties at the right time
2001 * buildbot/process/step.py (BuildStep.__init__): change setup to
2002 require 'build' argument in a better way
2003 (LoggingBuildStep): split ShellCommand into two pieces, for better
2004 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2005 a single RemoteCommand that sends stdout/stderr status text. It
2006 also provides the usual commandComplete / createSummary /
2007 evaluateCommand / getText methods to be overridden...
2008 (ShellCommand): .. whereas ShellCommand is specifically for
2009 running RemoteShellCommands. Other shell-like BuildSteps (like
2010 Source) can inherit from LoggingBuildStep instead of ShellCommand
2011 (WithProperties): marker class to do build-property interpolation
2012 (Source): inherit from LoggingBuildStep instead of ShellCommand
2015 * buildbot/test/test_properties.py: test new functionality
2017 2006-04-21 Brian Warner <warner@lothar.com>
2019 * buildbot/test/test_vc.py: rename testBranch to
2020 testCheckoutBranch to keep the tests in about the right
2023 2006-04-18 Brian Warner <warner@lothar.com>
2025 * docs/buildbot.texinfo (PBListener): improve cross-references
2026 between PBListener and 'buildbot statusgui', thanks to John Pye
2029 2006-04-17 Brian Warner <warner@lothar.com>
2031 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2032 running under Twisted-1.3.0, otherwise skipped tests are reported
2035 * all: use isinstance() instead of 'type(x) is foo', suggested by
2038 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2039 oops, fix a brain-fade from the other week, when making the
2040 addStep changes. I changed all the __init__ upcalls to use the
2041 wrong superclass name.
2042 (FullTwistedBuildFactory.__init__): same
2043 (TwistedDebsBuildFactory.__init__): same
2044 (TwistedReactorsBuildFactory.__init__): same
2045 (TwistedBuild.isFileImportant): use .startswith for clarity,
2046 thanks to Neal Norwitz for the suggestions.
2048 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2049 changes, then deliver them over PB to a remote buildmaster.
2051 * contrib/svnpoller.py: added script by John Pye to poll a remote
2052 SVN repository (by running 'svn log') from a cronjob, and run
2053 'buildbot sendchange' to deliver the changes to a remote
2055 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2056 modification of svnpoller.py), same purpose, but this one loops
2057 internally (rather than expecting to run from a cronjob) and works
2059 * contrib/README.txt: same
2061 2006-04-11 Brian Warner <warner@lothar.com>
2063 * all: fix a number of incorrect names and missing imports, thanks
2064 to Anthony Baxter for the patch.
2065 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2066 remove unused buggy method.
2067 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2068 comes from shutil, not "shutils"
2069 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2070 (Arch.checkSlaveVersion): same
2071 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2073 * buildbot/process/step_twisted2.py: add some missing imports
2074 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2075 this code used to live in twisted.internet.defer
2077 2006-04-10 Brian Warner <warner@lothar.com>
2079 * buildbot/process/step.py (Mercurial): add Mercurial support
2080 * buildbot/slave/commands.py (Mercurial): same
2081 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2082 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2083 not yet tested, but 'try' support *is* covered
2084 * docs/buildbot.texinfo (Mercurial): document it
2086 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2087 some debugging messages (turned off)
2088 * buildbot/test/test_vc.py: improve debug messages
2090 2006-04-07 Brian Warner <warner@lothar.com>
2092 * buildbot/test/test_vc.py (which): define our own which() in case
2093 we can't import twisted.python.procutils, because procutils doesn't
2094 exist in Twisted-1.3
2096 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2097 of SlaveLocks for performance tests
2099 * docs/examples/twisted_master.cfg: update to match current usage
2101 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2102 password, p4 binary, pollinterval, maximum history to check.
2103 Patch from an anonymous sf.net contributor, SF#1219384.
2104 * buildbot/process/step.py (P4Sync.__init__): add username,
2105 password, and client arguments.
2106 * buildbot/slave/commands.py (P4Sync): same
2108 2006-04-05 Brian Warner <warner@lothar.com>
2110 * buildbot/process/factory.py (BuildFactory.addStep): new method
2111 to add steps to a BuildFactory. Use it instead of f.steps.append,
2112 and you can probably avoid using the s() convenience function.
2113 Patch from Neal Norwitz, sf.net #1412605.
2114 (other): update all factories to use addStep
2115 * buildbot/process/process_twisted.py: update all factories to use
2118 2006-04-03 Brian Warner <warner@lothar.com>
2120 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2121 work under windows too. Adapted from a patch by Niklaus Giger,
2122 addresses SF#1463399.
2124 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2125 spawned commands emit parseable results in english and not some
2126 other language. Patch from Niklaus Giger, SF#1463395.
2128 * README (INSTALLATION): discourage users from running unit tests on
2129 a "network drive", patch from Niklaus Giger, SF#1463394.
2131 2006-03-22 Brian Warner <warner@lothar.com>
2133 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2134 function to turn a repository-relative pathname into a (branch,
2135 branch-relative-filename) tuple. Change this function to handle
2136 the branch naming policy used by your Subversion repository.
2137 Thanks to AllMyData.com for sponsoring this work.
2139 2006-03-16 Brian Warner <warner@lothar.com>
2141 * buildbot/scripts/sample.cfg: add python-mode declaration for
2142 vim. Thanks to John Pye for the patch.
2144 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2145 command line, mention the importance of running 'crontab' as the
2146 buildmaster/buildslave user. Thanks to John Pye for the catch.
2148 2006-03-13 Brian Warner <warner@lothar.com>
2150 * buildbot/status/words.py (IRC): add an optional password=
2151 argument, which will be sent to Nickserv in an IDENTIFY message at
2152 login, to claim the nickname. freenode requires this before the
2153 bot can sent (or reply to) private messages. Thanks to Clement
2154 Stenac for the patch.
2155 * docs/buildbot.texinfo (IRC Bot): document it
2157 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2158 larger than chunkSize. Fixes SF#1349253.
2159 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2160 (Log.testConsumer): update to match new internal chunking behavior
2162 2006-03-12 Brian Warner <warner@lothar.com>
2164 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2166 * buildbot/test/test_maildir.py (MaildirTest): rename the
2167 'timeout' method, as it collides with trial's internals
2169 * buildbot/scripts/runner.py: add 'buildbot restart' command
2170 (stop): don't sys.exit() out of here, otherwise restart can't work
2171 * docs/buildbot.texinfo (Shutdown): document it
2173 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2174 * buildbot/status/html.py (Waterfall.__init__): same
2175 * buildbot/process/builder.py (Builder.startBuild): same
2176 * buildbot/process/base.py (BuildRequest): same
2177 * buildbot/sourcestamp.py (SourceStamp): same
2178 * buildbot/scheduler.py (Nightly): same
2180 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2182 * docs/buildbot.texinfo: same
2184 2006-02-17 Brian Warner <warner@lothar.com>
2186 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2187 * docs/buildbot.texinfo: set version number to match
2188 * NEWS: update for 0.7.2
2190 2006-02-16 Brian Warner <warner@lothar.com>
2192 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2194 2006-02-09 Brian Warner <warner@lothar.com>
2196 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2197 add text to explain per-build branch parameters
2198 * NEWS: mention --umask
2200 2006-02-08 Brian Warner <warner@lothar.com>
2202 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2204 (SlaveOptions.optParameters): add --umask, to make it possible to
2205 make buildslave-generated files (including build products) be
2208 * buildbot/slave/bot.py (BuildSlave.startService): same
2210 2006-01-23 Brian Warner <warner@lothar.com>
2212 * buildbot/status/builder.py: urllib.quote() all URLs that include
2213 Builder names, so that builders can include characters like '/'
2214 and ' ' without completely breaking the resulting HTML. Thanks to
2215 Kevin Turner for the patch.
2216 * buildbot/status/html.py: same
2217 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2219 * NEWS: update in preparation for upcoming release
2221 2006-01-18 Brian Warner <warner@lothar.com>
2223 * docs/examples/twisted_master.cfg: update to match the Twisted
2224 buildbot: remove python2.2, switch to exarkun's buildslaves,
2225 disable the .deb builder until we figure out how to build twisted
2226 .debs from SVN, add some ktrace debugging to the OS-X build
2227 process and remove the qt build, remove threadless builders,
2228 change freebsd builder to use landonf's buildslave.
2230 2006-01-12 Brian Warner <warner@lothar.com>
2232 * buildbot/master.py (Manhole.__init__): let port= be a strports
2233 specification string, but handle a regular int for backwards
2234 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2235 used in master.cfg to limit connections to just the local host.
2236 (BuildMaster.loadConfig): same for c['slavePortnum']
2237 * buildbot/scheduler.py (Try_Userpass.__init__): same
2238 * buildbot/status/client.py (PBListener.__init__): same
2239 * buildbot/status/html.py (Waterfall.__init__): same, for both
2240 http_port and distrib_port. Include backwards-compatibility checks
2241 so distrib_port can be a filename string and still mean unix:/foo
2242 * docs/buildbot.texinfo (Setting the slaveport): document it
2243 (Debug options): same
2244 (HTML Waterfall): same
2247 * buildbot/test/test_config.py (ConfigTest): test it
2249 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2250 slaveport's disownServiceParent deferred to fire before opening
2251 the new one. Fixes an annoying bug in the unit tests.
2253 2006-01-03 Brian Warner <warner@lothar.com>
2255 * buildbot/master.py (BuildMaster): remove the .schedulers
2256 attribute, replacing it with an allSchedulers() method that looks
2257 for all IService children that implement IScheduler. Having only
2258 one parent/child relationship means fewer opportunities for bugs.
2259 (BuildMaster.allSchedulers): new method
2260 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2261 also fix ugly bug that caused any config-file reload to
2262 half-forget about the earlier Schedulers, causing an exception
2263 when a Change arrived and was handed to a half-connected
2264 Scheduler. The exception was in scheduler.py line 54ish:
2265 self.parent.submitBuildSet(bs)
2266 exceptions.AttributeError: 'NoneType' object has no attribute
2268 (BuildMaster.addChange): update to use allSchedulers()
2270 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2271 to work properly with twisted-1.3.0, where you must explicitly
2272 include the __implements__ from parent classes
2273 (BaseScheduler.__repr__): make it easier to distinguish distinct
2275 (BaseUpstreamScheduler.__implements__): same
2277 * buildbot/status/builder.py (Status.getSchedulers): update to
2279 * buildbot/test/test_run.py (Run.testMaster): same
2280 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2281 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2282 make sure Scheduler instances are left alone when an identical
2283 config file is reloaded
2284 (ConfigElements.testSchedulers): make sure Schedulers are properly
2287 * Makefile (TRIALARGS): my local default Twisted version is now
2288 2.1.0, update the trial arguments accordingly
2290 2005-12-22 Brian Warner <warner@lothar.com>
2292 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2295 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2296 addChange in the parent class, although I suspect this should be
2297 fixed better in the future.
2299 2005-11-26 Brian Warner <warner@lothar.com>
2301 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2302 explode when branch==None, thanks to Kevin Turner for the catch
2303 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2306 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2308 * docs/buildbot.texinfo: same
2310 2005-11-26 Brian Warner <warner@lothar.com>
2312 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2313 * docs/buildbot.texinfo: set version number to match
2315 2005-11-26 Brian Warner <warner@lothar.com>
2317 * NEWS: update for 0.7.1
2319 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2320 sure that unsubscribe works even if we never sent an ETA update.
2321 Also, don't explode on duplicate unsubscribe.
2322 (BuildStepStatus.addLog): make the convenience "return self"-added
2323 watcher automatically unsubscribe when the Step finishes.
2324 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2325 (BuildStatus.stepStarted): same auto-unsubscribe
2326 (BuilderStatus.buildStarted): same auto-unsubscribe
2328 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2330 (IStatusReceiver.stepStarted): same
2331 (IStatusReceiver.logStarted): same
2333 * buildbot/test/test_run.py (Status): move the Status test..
2334 * buildbot/test/test_status.py (Subscription): .. to here
2336 2005-11-25 Brian Warner <warner@lothar.com>
2338 * NEWS: more updates
2340 * buildbot/locks.py: fix the problem in which loading a master.cfg
2341 file that changes some Builders (but not all of them) can result
2342 in having multiple copies of the same Lock. Now, the real Locks
2343 are kept in a table inside the BotMaster, and the Builders/Steps
2344 use "LockIDs", which are still instances of MasterLock and
2345 SlaveLock. The real Locks are instances of the new RealMasterLock
2346 and RealSlaveLock classes.
2347 * buildbot/master.py (BotMaster.getLockByID): new method to
2348 convert LockIDs into real Locks.
2349 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2350 into real Locks before building
2351 * buildbot/process/step.py (BuildStep.startStep): same
2352 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2353 exercises the problem
2356 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2357 what Schedulers are available
2359 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2360 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2361 'cron'-style build scheduling at certain times of day, week,
2363 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2365 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2366 handling: treat self.fileIsImportant more as an attribute that
2367 contains a callable than as a method. If the attribute is None,
2368 don't call it and assume all filenames are important. It is still
2369 possible to provide a fileIsImportant method in a subclass,
2371 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2373 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2374 test using AnyBranchScheduler with fileIsImportant=None
2376 2005-11-24 Brian Warner <warner@lothar.com>
2378 * buildbot/test/test_config.py (StartService): don't claim a fixed
2379 port number, instead set slavePort=0 on the first pass, figure out
2380 what port was allocated, then switch to a config file that uses
2383 * buildbot/master.py (BuildMaster.loadConfig): close the old
2384 slaveport before opening the new one, because unit tests might
2385 replace slavePort=0 with the same allocated portnumber, and if we
2386 don't wait for the old port to close first, we get a "port already
2387 in use" error. There is a tiny race condition here, but the only
2388 threat is from other programs that bind (statically) to the same
2389 port number we happened to be allocated, and only if those
2390 programs use SO_REUSEADDR, and only if they get control in between
2393 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2395 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2396 deleted ChangeSources before adding any new ones
2397 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2398 compare_attrs, to make sure that a config-file reload does not
2399 unnecessarily replace an unmodified ChangeSource instance
2400 * buildbot/test/test_config.py (ConfigTest.testSources): update
2402 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2403 mean "don't build anything", and add a warning if it gets used
2404 because it isn't actually useful.
2406 * contrib/svn_buildbot.py: update example usage to match the port
2407 number that gets used by the PBChangeSource
2408 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2410 2005-11-22 Brian Warner <warner@lothar.com>
2412 * NEWS: start collecting items for next release
2414 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2415 revisions are strings
2416 (P4Sync.computeSourceRevision): same
2418 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2419 to the Buildbot's overall status page
2420 (StatusResourceBuilder.body): same
2422 2005-11-15 Brian Warner <warner@lothar.com>
2424 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2425 config-file loading, specifically to make sure old StatusTargets
2426 are finished shutting down before new ones start up (thus
2427 resolving a bug in which changing the Waterfall object would fail
2428 because both new and old instances were claiming the same
2429 listening port). Also load new Schedulers after all the new
2430 Builders are set up, in case they fire off a new build right away.
2431 * buildbot/test/test_config.py (StartService): test it
2433 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2434 the branch name to the mail body
2436 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2437 Without it, a config-file reload fails to update an existing
2439 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2440 username/passwd to compare_attrs, for the same reason
2441 * buildbot/status/html.py (Waterfall): add favicon to
2442 compare_attrs, same reason
2444 2005-11-05 Brian Warner <warner@lothar.com>
2446 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2447 baserev before stuffing it in the jobfile. This resolves problems
2448 under SVN (and probably Arch) where revisions are expressed as
2449 numbers. I'm inclined to use string-based revisions everywhere in
2450 the future, but this fix should be safe for now. Thanks to Steven
2451 Walter for the patch.
2453 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2454 binary mode when opening pickle files, to make windows work
2455 better. Thanks to Dobes Vandermeer for the catch.
2456 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2457 (BuilderStatus.getBuildByNumber): same
2458 (Status.builderAdded): same
2459 * buildbot/master.py (BuildMaster.loadChanges): same
2461 * buildbot/util.py (Swappable): delete unused leftover code
2463 * buildbot/process/step.py (SVN): when building on a non-default
2464 branch, add the word "[branch]" to the VC step's description, so
2465 it is obvious that we're not building the usual stuff. Likewise,
2466 when we are building a specific revision, add the text "rNNN" to
2467 indicate what that revision number is. Thanks to Brad Hards and
2468 Nathaniel Smith for the suggestion.
2469 (Darcs.startVC): same
2470 (Arch.startVC): same
2471 (Bazaar.startVC): same
2473 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2474 typo, caught by Mark Dillavou, closes SF#1216636.
2476 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2477 about a test to add some day
2479 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2480 the 'full-2.3' build, and the 'reactors' build is now run under
2481 python-2.4 because the buildslave no longer has gtk/etc bindings
2482 for earlier versions.
2484 2005-11-03 Brian Warner <warner@lothar.com>
2486 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2487 method, takes an IBuildStatus and rebuilds it. It might make more
2488 sense to add this to IBuildControl instead, but that instance goes
2489 away completely once the build has finished, and resubmitting
2490 builds can take place weeks later.
2491 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2492 * buildbot/status/html.py (StatusResourceBuild): also stash an
2493 IBuilderControl so we can use resubmitBuild.
2494 (StatusResourceBuild.body): render "resubmit" button if we can.
2495 Also add hrefs for each BuildStep
2496 (StatusResourceBuild.rebuild): add action for "resubmit" button
2497 (StatusResourceBuilder.getChild): give it an IBuilderControl
2499 * buildbot/status/builder.py (Status.getURLForThing): change the
2500 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2501 that live as targets of buttons like "stop" and "rebuild" can't
2503 * buildbot/status/builder.py (Status.getURLForThing): same
2504 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2505 (StepBox.getBox): same
2506 * buildbot/test/test_web.py (GetURL): same
2509 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2510 exclusivity checks after Source.__init__ upcall, so misspelled
2511 arguments will be reported more usefully
2512 (Darcs.__init__): same
2514 2005-10-29 Brian Warner <warner@lothar.com>
2516 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2517 builder. Move the Try scheduler off to a separate port.
2519 2005-10-27 Brian Warner <warner@lothar.com>
2521 * buildbot/clients/gtkPanes.py
2522 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2523 to cause the app to crash, now they don't.
2525 * buildbot/clients/debug.py: display the buildmaster's location
2526 in the window's title bar
2528 2005-10-26 Brian Warner <warner@lothar.com>
2530 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2531 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2532 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2534 * buildbot/status/html.py (td): put a single non-breaking space
2535 inside otherwise empty <td> elements, as a workaround for buggy
2536 browsers which would optimize them away (along with any associated
2537 styles, like the kind that create the waterfall grid borders).
2538 Patch from Frerich Raabe.
2540 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2541 argv-list as an argument, defaulting to ["-to"], which is
2542 appropriate for the Trial that comes with Twisted-2.1.0 and
2543 earlier. The Trial in current Twisted SVN wants
2544 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2545 defaults to an empty list.
2546 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2547 match it, now that trialMode= is a list instead of a single string
2549 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2551 * docs/buildbot.texinfo: same
2553 2005-10-24 Brian Warner <warner@lothar.com>
2555 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2556 * docs/buildbot.texinfo: set version number to match
2558 2005-10-24 Brian Warner <warner@lothar.com>
2560 * README: update for 0.7.0
2562 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2564 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2565 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2566 send the branch= argument unless the user really provided one, to
2567 retain compatibility with older buildmasters that don't accept
2569 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2572 * docs/buildbot.texinfo: update lots of stuff
2574 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2575 to the 'buildbot sendchange' command
2576 * buildbot/clients/sendchange.py (Sender.send): same
2577 * buildbot/changes/pb.py (ChangePerspective): same
2578 * buildbot/test/test_changes.py (Sender.testSender): test it
2580 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2581 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2582 for consistency with other BuildStep arguments that use camelCase.
2583 Well, at least more of them use camelCase (like flunkOnWarnings)
2584 than don't.. I wish I'd picked one style and stuck with it
2585 earlier. Annoying, but it's best done before the release, since
2586 these arguments didn't exist at all in 0.6.6 .
2588 * buildbot/test/test_vc.py (SVN.testCheckout): same
2589 (Darcs.testPatch): same
2590 * docs/buildbot.texinfo (SVN): document the change
2591 (Darcs): same, add some build-on-branch docs
2592 * docs/examples/twisted_master.cfg: match change
2594 * buildbot/process/step.py (BuildStep): rename
2595 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2596 how it is normally used.
2597 * buildbot/test/test_steps.py (Version.checkCompare): same
2599 * buildbot/process/step.py (CVS.startVC): refuse to build
2600 update/copy -style builds on a non-default branch with an old
2601 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2602 concern is that it will do a VC 'update' in an existing tree when
2603 it is supposed to be switching branches (and therefore clobbering
2604 the tree to do a full checkout), thus building the wrong source.
2605 This used to be a warning, but I think the confusion it is likely
2606 to cause warrants making it an error.
2607 (SVN.startVC): same, also make mode=export on old slaves an error
2608 (Darcs.startVC): same
2609 (Git.startVC): improve error message for non-Git-enabled slaves
2610 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2611 specific revision is built on a slave that doesn't pay attention
2612 to args['revision'], because for slowly-changing trees it will
2613 probably do the right thing, and because we have no way to tell
2614 whether we're asking it to build the most recent version or not.
2615 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2617 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2618 that 'master' is in host:portnum format, to catch errors sooner
2620 2005-10-23 Brian Warner <warner@lothar.com>
2622 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2623 when creating the list of warning messages, include the line
2624 immediately after each WARNING: line, since that's usually where
2625 the file and line number wind up.
2627 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2632 2005-10-22 Brian Warner <warner@lothar.com>
2634 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2635 patch from Brad Hards
2636 * buildbot/status/classic.css: same
2637 * buildbot/test/test_web.py (Waterfall): match changes
2639 * buildbot/test/test_steps.py (BuildStep.setUp): set
2640 nextBuildNumber so the test passes
2641 * buildbot/test/test_status.py (MyBuilder): same
2643 * buildbot/status/html.py (StatusResourceBuild.body): revision
2644 might be numeric, so stringify it before html-escapifying it
2645 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2646 timer for the upcoming build
2647 * buildbot/status/classic.css: add background-color attributes for
2648 offline/waiting/building classes
2650 * buildbot/status/builder.py (BuildStatus): derive from
2651 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2652 the default (i.e. unknown) .slavename to "???" instead of None,
2653 since even unknown slavenames need to be printed eventually.
2654 (BuilderStatus): also derive from styles.Versioned . More
2655 importantly, determine .nextBuildNumber at creation/unpickling
2656 time by scanning the directory of saved BuildStatus instances and
2657 choosing one larger than the highest-numbered one found. This
2658 should fix the problem where random errors during upgrades cause
2659 the buildbot to forget about earlier builds. .nextBuildNumber is
2660 no longer stored in the pickle.
2661 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2662 at least log the error. Also call Builder.determineNextBuildNumber
2663 once the basedir is set.
2665 * buildbot/master.py (BuildMaster.loadChanges): do
2666 styles.doUpgrade afterwards, in case I decide to make Changes
2667 derived from styles.Versioned some day and forget to make this
2671 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2672 when running under older pythons (<2.3) in which the shlex module
2673 doesn't have a 'split' function.
2675 * buildbot/process/step.py (ShellCommand.start): make
2676 errorMessages= be a list of strings to stuff in the log before the
2677 command actually starts. This makes it easier to flag multiple
2678 warning messages, e.g. when the Source steps have to deal with an
2680 (CVS.startVC): handle slaves that don't handle multiple branches
2681 by switching into 'clobber' mode
2682 (SVN.startVC): same. Also reject branches without base_url
2683 (Darcs.startVC): same. Also reject revision= in older slaves
2684 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2685 (Bazaar.startVC): same, and test for baz separately than for arch
2687 * buildbot/slave/commands.py (cvs_ver): document new features
2689 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2690 (BuildStep.slaveVersionNewEnough): more useful utility method
2691 * buildbot/test/test_steps.py (Version): start testing it
2693 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2694 the 'force' command requires python2.3, for the shlex.split method
2696 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2697 since we don't use it anymore. The Twisted buildbot uses a
2700 2005-10-21 Brian Warner <warner@lothar.com>
2702 * buildbot/process/process_twisted.py: rework all BuildFactory
2703 classes to take a 'source' step as an argument, instead of
2704 building up the SVN instance in the factory.
2705 * docs/examples/twisted_master.cfg: enable build-on-branch by
2706 providing a base_url and default_branch
2708 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2709 control over --branch and --revision, not that they are always
2711 * buildbot/status/html.py (StatusResourceBuilder.force): same
2712 (StatusResourceBuild.body): display SourceStamp components
2714 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2715 IRC 'force' command, so it can be shared with an eventual
2716 command-line-tool 'buildbot force' mode.
2717 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2719 2005-10-20 Brian Warner <warner@lothar.com>
2721 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2723 * docs/examples/twisted_master.cfg: update to use Schedulers
2725 * buildbot/scripts/sample.cfg: update with Schedulers
2727 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2728 method specifically for use by HTML "force build" button and the
2729 IRC "force" command. Raises an immediate error if there are no
2731 (IBuilderControl.requestBuild): make this just submit a build, not
2732 try to check for existing slaves or set up any when-finished
2733 Deferreds or anything.
2734 * buildbot/process/builder.py (BuilderControl): same
2735 * buildbot/status/html.py (StatusResourceBuilder.force): same
2736 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2737 * buildbot/test/test_slaves.py: same
2738 * buildbot/test/test_web.py: same
2740 2005-10-19 Brian Warner <warner@lothar.com>
2742 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2743 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2745 2005-10-18 Brian Warner <warner@lothar.com>
2747 * buildbot/status/html.py: provide 'status' argument to most
2748 StatusResourceFOO objects
2749 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2750 and Logfiles" section to make the Build page into a more-or-less
2751 comprehensive source of status information about the build
2753 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2754 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2756 2005-10-17 Brian Warner <warner@lothar.com>
2758 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2759 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2760 out what to do about other projects: the correct options for
2761 recent Twisteds will not work for older ones.
2763 2005-10-15 Brian Warner <warner@lothar.com>
2765 * buildbot/status/builder.py (Status.getURLForThing): add method
2766 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2767 use this in email/IRC status clients to make them more useful, by
2768 providing the end user with hints on where to learn more about the
2769 object being reported on.
2770 * buildbot/test/test_web.py (GetURL): tests for it
2772 2005-10-14 Brian Warner <warner@lothar.com>
2774 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2775 fix bug resulting from deferredResult changes
2777 2005-10-13 Brian Warner <warner@lothar.com>
2779 * buildbot/test/test_changes.py: remove use of deferredResult
2780 * buildbot/test/test_config.py: same
2781 * buildbot/test/test_control.py: same
2782 * buildbot/test/test_status.py: same
2783 * buildbot/test/test_vc.py: this is the only remaining use, since
2784 it gets used at module level. This needs to be replaced by some
2785 sort of class-level run-once routine.
2787 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2789 * lots: implement multiple slaves per Builder, which means multiple
2790 current builds per Builder. Some highlights:
2791 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2792 of (state,currentBuilds) instead of (state,currentBuild)
2793 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2794 (IBuildStatus.getSlavename): new method, so you can tell which
2795 slave got used. This only gets set when the build completes.
2796 (IBuildRequestStatus.getBuilds): new method
2798 * buildbot/process/builder.py (SlaveBuilder): add a .state
2799 attribute to track things like ATTACHING and IDLE and BUILDING,
2801 (Builder): .. the .slaves attribute here, which has been turned
2802 into a simple list of available slaves. Added a separate
2803 attaching_slaves list to track ones that are not yet ready for
2805 (Builder.fireTestEvent): put off the test-event callback for a
2806 reactor turn, to make tests a bit more consistent.
2807 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2808 ping fails due to an exception. This needs work, I'm worried that
2809 a code error could lead to a constantly re-connecting slave.
2810 Especially since I'm trying to move to a distinct remote_ping
2811 method, separate from the remote_print that we currently use.
2812 (BuilderControl.requestBuild): return a convenience Deferred that
2813 provides an IBuildStatus when the build finishes.
2814 (BuilderControl.ping): ping all connected slaves, only return True
2815 if they all respond.
2817 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2818 reconnect when we shut down.
2820 * buildbot/status/builder.py: implement new methods, convert
2821 one-build-at-a-time methods to handle multiple builds
2822 * buildbot/status/*.py: do the same in all default status targets
2823 * buildbot/status/html.py: report the build's slavename in the
2824 per-Build page, report all buildslaves on the per-Builder page
2826 * buildbot/test/test_run.py: update/create tests
2827 * buildbot/test/test_slaves.py: same
2828 * buildbot/test/test_scheduler.py: remove stale test
2830 * docs/buildbot.texinfo: document the new builder-specification
2831 'slavenames' parameter
2833 2005-10-12 Brian Warner <warner@lothar.com>
2835 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2836 report failure correctly, causing Dependent builds to run when
2837 they shouldn't have.
2838 * buildbot/status/builder.py (BuildSetStatus): same
2839 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2840 (Set.testSuccess): test the both-pass case too
2841 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2842 fix this test: it was ending too early, masking the failure before
2843 (Logger): specialized StatusReceiver to make sure the dependent
2844 builds aren't even started, much less completed.
2846 2005-10-07 Brian Warner <warner@lothar.com>
2848 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2849 bot.SlaveBuilder being disowned in the middle of a build
2851 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2852 this inherit from StatusReceiver. Also upcall in __init__. This
2853 fixes the embarrasing crash when the new buildSetSubmitted method
2854 is invoked and Waterfall/etc don't implement their own.
2855 * buildbot/test/test_run.py: add a TODO note about a test to catch
2856 just this sort of thing.
2858 * buildbot/process/builder.py (Builder.attached): remove the
2859 already-attached warning, this situation is normal. Add some
2860 comments explaining it.
2862 2005-10-02 Brian Warner <warner@lothar.com>
2864 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2865 OverflowError when setting up dnotify, because some 64-bit systems
2866 have problems with signed-vs-unsigned constants and trip up on the
2867 DN_MULTISHOT flag. Patch from Brad Hards.
2869 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2871 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2872 progressMetrics, description, descriptionDone to the 'parms' list,
2873 and make use the 'parms' list from the implementation class
2874 instead of only BuildStep to initialize the parameters. This
2875 allows buildbot.process.factory.s() to initialize all the parms,
2876 not just those defined in directly by BuildStep.
2878 2005-09-03 Brian Warner <warner@lothar.com>
2880 * NEWS: start adding items for the next release
2882 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2883 python2.2 tests, change 'Quick' builder to only use python2.3
2885 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2887 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2888 the "Ping Builder" button if the build control is available; the
2889 user sees an exception otherwise
2891 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2893 2005-09-01 Brian Warner <warner@lothar.com>
2895 * buildbot/interfaces.py (IBuilderStatus.getState): update
2896 signature, point out that 'build' can be None
2897 (IBuildStatus.getETA): point out ETA can be none
2899 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2901 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2903 2005-08-31 Brian Warner <warner@lothar.com>
2905 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2906 update to match correct signature: removed 'eta' argument
2907 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2909 2005-08-30 Brian Warner <warner@lothar.com>
2911 * buildbot/status/builder.py (LogFile): remove the assertion that
2912 blows up when you try to overwrite an existing logfile, instead
2913 just emit a warning. This case gets hit when the buildmaster is
2914 killed and doesn't get a chance to write out the serialized
2915 BuilderStatus object, so the .nextBuildNumber attribute gets out
2918 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2919 the 'buildbot sendchange' arguments, for the Darcs context file
2920 * docs/buildbot.texinfo (sendchange): document it
2922 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2923 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2924 (IStatus.getSchedulers): new method
2925 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2926 (Status.getSchedulers): implement
2927 * buildbot/process/builder.py (Builder): maintain
2928 BuilderStatus.pendingBuilds
2929 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2930 (TryBase.addChange): Try schedulers should ignore Changes
2932 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2933 for 'try' on CVS/SVN
2934 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2936 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2937 report status properly.
2938 (Try.createJob): implement unique buildset IDs
2940 * buildbot/status/client.py (StatusClientPerspective): add a
2941 perspective_getBuildSets method for the benefit of jobdir-style
2943 * docs/buildbot.texinfo (try): more docs
2944 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2947 2005-08-18 Brian Warner <warner@lothar.com>
2949 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2950 actually work. It's functional but still kind of clunky. Also, it
2951 only works with the pb-style.. needs to be made to work with the
2954 * buildbot/status/client.py (RemoteBuildSet): new class
2955 (RemoteBuildRequest): same
2956 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2957 object, not the internal BuildStatus object.
2958 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2959 outside of the usual buildStarted() return value.
2960 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2962 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2963 (Try_Userpass_Perspective.perspective_try): return a remotely
2964 usable BuildSetStatus object
2966 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2967 isStarted()/waitUntilStarted()
2969 2005-08-16 Brian Warner <warner@lothar.com>
2971 * buildbot/status/builder.py: implement IBuildSetStatus and
2972 IBuildRequestStatus, wire them into place.
2973 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2974 methods into the BuildSetStatus object.
2975 * buildbot/interfaces.py: same
2976 (IStatus.getBuildSets): new method to get pending BuildSets
2977 (IStatusReceiver.buildsetSubmitted): new method which hears about
2979 * buildbot/master.py (BuildMaster.submitBuildSet): same
2980 * buildbot/process/base.py (BuildRequest): same, replace
2981 waitUntilStarted with subscribe/unsubscribe
2982 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2983 subscribe instead of waitUntilStarted
2984 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2986 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2988 * buildbot/test/test_buildreq.py: update for new code
2989 * buildbot/test/test_control.py (Force.testRequest): same
2992 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2993 for Darcs to not use the tempfile module, so it works under
2994 python-2.2 too. We really didn't need the full cleverness of that
2995 module, since the slave has exclusive control of its own builddir.
2997 2005-08-15 Brian Warner <warner@lothar.com>
2999 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3000 for CVS trees. It doesn't work for non-trunk branches,
3002 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3005 * Makefile: make it easier to test against python2.2
3007 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3008 tearDown2, so things like Arch can unregister archives as they're
3009 shutting down. The previous subclass-override-tearDown technique
3010 resulted in a nested maybeWait() and test failures under
3013 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3014 where we can (Arch), add a branch= argument to set the branch used
3016 (BazExtractor): extract the branch too
3017 (TlaExtractor): same
3018 * buildbot/scripts/runner.py (TryOptions): add --branch
3019 * docs/buildbot.texinfo (try): document --branch/try_branch
3021 * buildbot/slave/commands.py (Darcs): implement get-revision for
3022 Darcs, so that 'try' will work. This requires the tempfile module
3025 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3026 of revisions, branches, and 'try' in the process.
3028 2005-08-11 Brian Warner <warner@lothar.com>
3030 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3031 this, it got broken at some point in the last few releases
3032 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3033 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3034 specifically the removal of ETA information from the tuple
3036 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3039 * docs/buildbot.texinfo (try): document both --builder and
3040 'try_builders' in .buildbot/options
3041 * buildbot/scripts/runner.py (TryOptions): add --builder,
3042 accumulate the values into opts['builders']
3043 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3044 * buildbot/test/test_runner.py (Try): add some quick tests to make
3045 sure 'buildbot try --options' and .buildbot/options get parsed
3046 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3047 use --builder control
3049 * docs/buildbot.texinfo (try): add --port argument to PB style
3051 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3052 actual SourceStamp. Still need to extract a branch name, somehow.
3053 (Try): finish implementing the try client side, still need a UI
3054 for specifying which builders to use
3055 (Try.getopt): factor our options/config-file reading
3056 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3058 * buildbot/test/test_vc.py: match SourceStampExtractor change
3060 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3061 causes the twisted log to be sent to stderr
3063 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3065 2005-08-10 Brian Warner <warner@lothar.com>
3067 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3068 style is 90% done, still missing status reporting or waiting for
3069 the buildsets to finish, and it is completely untested.
3071 * buildbot/trybuild.py: delete file, move contents to ..
3072 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3073 * buildbot/test/test_vc.py: match the move
3075 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3076 of the TryScheduler, no buildsetID or status-tracking support yet
3077 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3079 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3080 possible to set the basedir after __init__ time, so it is easier
3081 to use as a Service-child of the BuildMaster instance
3083 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3084 that delivers messages to its Service parent instead of requiring
3085 a subclass to be useful. This turns out to be much easier to build
3088 * buildbot/scripts/tryclient.py (createJob): utility code to
3089 create jobfiles, will eventually be used by 'buildbot try'
3091 2005-08-08 Brian Warner <warner@lothar.com>
3093 * docs/buildbot.texinfo (try): add docs on the
3094 as-yet-unimplemented Try scheduler
3096 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3097 * buildbot/test/test_scheduler.py: .. here
3098 (Scheduling.testTryJobdir): add placeholder test for 'try'
3100 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3101 addEntry merging (>=chunkSize) behavior
3102 (Log.testConsumer): update to handle new callLater(0) behavior
3104 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3105 both the MAX_LENGTH bugfix and the resumeProducing hang.
3107 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3108 put off the actual resumeProducing for a moment with
3109 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3110 causes large logfiles to hang midway through.
3112 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3113 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3114 and to improve memory usage when streaming the file out to a web
3116 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3117 make this work cleanly
3119 2005-08-03 Brian Warner <warner@lothar.com>
3121 * buildbot/trybuild.py: new file for 'try' utilities
3122 (getSourceStamp): run in a tree, find out the baserev+patch
3123 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3124 implemented for SVN and Darcs, still working on Arch. I don't know
3125 how to make CVS work yet.
3127 * docs/buildbot.texinfo: document the 'buildbot' command-line
3128 tool, including the not-yet-implemented 'try' feature, and the
3129 in-flux .buildbot/ options directory.
3131 2005-07-20 Brian Warner <warner@lothar.com>
3133 * buildbot/locks.py: added temporary id() numbers to Lock
3134 descriptions, to track down a not-really-sharing-the-Lock bug
3136 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3138 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3139 needed for python2.2 compatibility
3140 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3141 are from the __future__
3143 2005-07-19 Brian Warner <warner@lothar.com>
3145 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3146 message when schedulers use unknown builders
3148 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3149 SlaveLock('name') and MasterLock('name') are distinct
3151 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3152 c['schedulers'] in such a way that we can actually accept
3154 * buildbot/test/test_config.py: check it
3156 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3157 utility method to *all* the Schedulers
3158 (Periodic.listBuilderNames): same
3160 * docs/buildbot.texinfo (Interlocks): update chapter to match
3163 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3164 to make sure that c['sources'], c['schedulers'], and c['status']
3165 are all lists of the appropriate objects, and that the Schedulers
3166 all point to real Builders
3167 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3168 'listBuilderNames' utility method to support this
3169 * buildbot/scheduler.py: implement the utility method
3170 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3172 * docs/buildbot.texinfo: add some @cindex entries
3174 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3175 if it wasn't already set: most tla commands will fail unless one
3177 (Arch.createRepository): and disable bazaar's revision cache, since
3178 they cause test failures (the multiple repositories we create all
3179 interfere with each other through the cache)
3181 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3182 bring it properly up to date with twisted-2.0 test guidelines
3184 * buildbot/master.py (BuildMaster): remove references to old
3185 'interlock' module, this caused a bunch of post-merge test
3187 * buildbot/test/test_config.py: same
3188 * buildbot/process/base.py (Build): same
3190 * buildbot/test/test_slaves.py: stubs for new test case
3192 * buildbot/scheduler.py: add test-case-name tag
3193 * buildbot/test/test_buildreq.py: same
3195 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3196 unnecessary init code
3197 (Bot.remote_setBuilderList): match it
3199 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3201 * buildbot/changes/mail.py (parseSyncmail): update comment
3203 * buildbot/test/test_slavecommand.py: disable Shell tests on
3204 platforms that don't suport IReactorProcess
3206 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3207 all places where we open logfiles. It causes OS-X to open the file
3208 in some weird mode that that prevents us from mixing reads and
3209 writes to the same filehandle, which we depend upon to implement
3210 _generateChunks properly. This change doesn't appear to break
3211 win32, on which "b" and "t" are treated differently but a missing
3212 flag seems to be interpreted as "t".
3214 2005-07-18 Brian Warner <warner@lothar.com>
3216 * buildbot/slave/commands.py (ShellCommand): overhaul
3217 error-handling code, to try and make timeout/interrupt work
3218 properly, and make win32 happier
3219 * buildbot/test/test_slavecommand.py: clean up, stop using
3220 reactor.iterate, add tests for timeout and interrupt
3221 * buildbot/test/sleep.py: utility for a new timeout test
3223 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3224 code from the local-usebranches branch
3226 2005-07-17 Brian Warner <warner@lothar.com>
3228 * buildbot/process/process_twisted.py
3229 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3230 minutes, to match the other twisted BuildFactories, and don't
3231 excuse failures in c/qt/win32 reactors any more.
3233 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3234 'freebsd' builders, since the buildslaves have been unavailable
3237 2005-07-13 Brian Warner <warner@lothar.com>
3239 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3240 build-on-branch feature
3242 * buildbot/process/step.py (Darcs.__init__): add base_url and
3243 default_branch arguments, just like SVN
3244 (Arch.__init__): note that the version= argument is really the
3247 * buildbot/slave/commands.py (SourceBase): keep track of the
3248 repository+branch that was used for the last checkout in
3249 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3250 match, we clobber the directory and perform a fresh checkout
3251 rather than trying to do an in-place update. This should protect
3252 us against trying to get to branch B by doing an update in a tree
3253 obtained from branch A.
3254 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3255 (SVN.setup): same, just the svnurl
3256 (Darcs.setup): same, just the repourl
3257 (Arch.setup): same, arch coordinates (url), version, and
3258 buildconfig. Also pull the buildconfig from the args dictionary,
3259 which we weren't doing before, so the build-config was effectively
3261 (Arch.sourcedirIsUpdateable): don't try to update when we're
3262 moving to a specific revision: arch can't go backwards, so it is
3263 safer to just clobber the tree and checkout a new one at the
3265 (Bazaar.setup): same sourcedata as Arch
3267 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3268 use maybeWait, to work with twisted-1.3.0 and twcompat
3269 (Dependencies.testRun_Pass): same
3271 * buildbot/test/test_vc.py: rearrange, cleanup
3273 * buildbot/twcompat.py: add defer.waitForDeferred and
3274 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3275 can work under twisted-1.3.0 .
3277 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3278 now created at setUp time. This increases the runtime of the test
3279 suite considerably (from 91 seconds to 151), but it removes the
3280 need for an offline tarball, which should solve a problem I've
3281 seen where the test host has a different version of svn than the
3282 tarball build host. The new code also validates that mode=update
3283 really picks up recent commits. This approach will also make it
3284 easier to test out branches, because the code which creates the VC
3285 branches is next to the code which uses them. It will also make it
3286 possible to test some change-notification hooks, by actually
3287 performing a VC commit and watching to see the ChangeSource get
3290 2005-07-12 Brian Warner <warner@lothar.com>
3292 * docs/buildbot.texinfo (SVN): add branches example
3293 * docs/Makefile (buildbot.ps): add target for postscript manual
3295 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3296 * buildbot/test/test_locks.py: same
3298 * buildbot/process/step.py (Darcs): comment about default branches
3300 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3301 c['interlocks'] in the config file, complain if it is present.
3302 Scan all locks in c['builders'] to make sure the Locks they use
3304 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3305 add some tests to check for non-uniquely-named Locks
3306 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3307 since the unique-Lock validation code requires it now
3309 * buildbot/locks.py: fix test-case-name
3311 * buildbot/interlock.py: remove old file
3313 2005-07-11 Brian Warner <warner@lothar.com>
3315 * buildbot/test/test_interlock.py: rename to..
3316 * buildbot/test/test_locks.py: .. something shorter
3318 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3319 versions (after 2.0.1) changed internet.TCPClient to shut down the
3320 connection in stopService. Change the code to handle this
3323 * buildbot/process/base.py (Build): handle whole-Build locks
3324 * buildbot/process/builder.py (Builder.compareToSetup): same
3325 * buildbot/test/test_interlock.py: make tests work
3327 * buildbot/process/step.py (BuildStep.startStep): complain if a
3328 Step tries to claim a lock that's owned by its own Build
3329 (BuildStep.releaseLocks): typo
3331 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3332 file reloads don't replace unchanged Builders
3334 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3335 rewrite to cover new Locks instead of old c['interlocks']
3336 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3340 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3341 start the master and connect the buildslave
3343 * buildbot/process/step.py (FailingDummy.done): finish with a
3344 FAILURE status rather than raising an exception
3346 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3347 stringify a BuildRequest.reason that is None
3349 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3351 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3352 allow scheduler.Dependent to work
3353 * buildbot/buildset.py (BuildSet): set .reason and .results
3355 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3356 slaves, to make the test stop hanging. It still fails, of course,
3357 because I haven't even started to implement Locks.
3359 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3361 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3362 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3363 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3364 (Dependent): new class for downstream build dependencies
3365 * buildbot/test/test_dependencies.py: tests (still failing)
3367 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3369 2005-07-07 Brian Warner <warner@lothar.com>
3371 * buildbot/test/runutils.py (RunMixin): factored this class out..
3372 * buildbot/test/test_run.py: .. from here
3373 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3374 added new buildbot.locks tests (which all hang right now)
3375 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3376 * buildbot/process/step.py: claim/release per-BuildStep locks
3378 * docs/Makefile: add 'buildbot.html' target
3380 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3381 interpreted as "HEAD", so that all VC steps can accept branch=None
3382 and have it mean the "default branch".
3384 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3386 2005-07-07 Brian Warner <warner@lothar.com>
3388 * docs/examples/twisted_master.cfg: update to match current usage
3390 * docs/buildbot.texinfo (System Architecture): comment out the
3391 image, it doesn't exist yet and just screws up the HTML manual.
3393 2005-07-05 Brian Warner <warner@lothar.com>
3395 * debian/.cvsignore: oops, missed one. Removing leftover file.
3397 2005-06-17 Brian Warner <warner@lothar.com>
3399 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3400 changed its output in 1.2.0, don't mistakenly think that the
3401 subversion we find isn't capable of supporting our tests.
3403 * debian/*: remove the debian/ directory and its contents, to make
3404 life easier for the proper Debian maintainer
3406 * Makefile (release): same
3408 2005-06-07 Brian Warner <warner@lothar.com>
3410 * everything: create a distinct SourceStamp class to replace the
3411 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3412 Changed the signature of Source.startVC to include the revision
3413 information (instead of passing it through self.args). Implement
3414 branches for SVN (now only Darcs/Git is missing support). Add more
3417 2005-06-06 Brian Warner <warner@lothar.com>
3419 * everything: rearrange build scheduling. Create a new Scheduler
3420 object (configured in c['schedulers'], which submit BuildSets to a
3421 set of Builders. Builders can now use multiple slaves. Builds can
3422 be run on alternate branches, either requested manually or driven
3423 by changes. This changed some of the Status classes. Interlocks
3424 are out of service until they've been properly split into Locks
3425 and Dependencies. treeStableTimer, isFileImportant, and
3426 periodicBuild have all been moved from the Builder to the
3428 (BuilderStatus.currentBigState): removed the 'waiting' and
3429 'interlocked' states, removed the 'ETA' argument.
3431 2005-05-24 Brian Warner <warner@lothar.com>
3433 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3434 erroneously abandons the connection (in clientConnectionFailed)
3435 for non-UserErrors, which means that if we lose the connection due
3436 to a network problem or a timeout, we'll never try to reconnect.
3437 Fix this by not upcalling to the buggy parent method. Note:
3438 twisted-2.0 fixes this, but the function only has 3 lines so it
3439 makes more sense to copy it than to try and detect the buggyness
3440 of the parent class. Fixes SF#1207588.
3442 * buildbot/changes/changes.py (Change.branch): doh! Add a
3443 class-level attribute to accomodate old Change instances that were
3444 pickled before 0.6.5 (where .branch was added for new Changes).
3445 This fixes the exception that occurs when you try to look at an
3446 old Change (through asHTML).
3448 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3451 2005-05-23 Brian Warner <warner@lothar.com>
3453 * buildbot/__init__.py (version): release 0.6.6
3455 2005-05-23 Brian Warner <warner@lothar.com>
3457 * NEWS: update for 0.6.6 release
3458 * debian/changelog: same
3460 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3461 before starting: this was done by twistd back when we spawned it,
3462 now that we're importing the pieces and running them in the
3463 current process, we have to do it ourselves. This allows
3464 master.cfg to import files from the same directory without
3465 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3466 Stichele for the catch.
3467 (Options.opt_version): Add a --version command (actually, just make
3468 the existing --version command emit Buildbot's version too)
3470 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3471 fix to make this behave like other LogFiles, this time to handle
3472 existing LogFiles on disk. (add the missing .upgrade method)
3473 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3475 2005-05-21 Brian Warner <warner@lothar.com>
3477 * buildbot/test/test_runner.py (Create.testMaster): match the
3478 rawstring change in runner.py:masterTAC
3480 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3481 TwistedWords is installed
3482 * buildbot/test/test_status.py: same, with TwistedMail
3484 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3485 some old, deprecated, and removed config keys). This should enable
3486 you to use the base buildbot functionality with Twisted-2.0.0 when
3487 you don't also have TwistedWeb and TwistedWords installed
3489 2005-05-20 Brian Warner <warner@lothar.com>
3491 * buildbot/scripts/runner.py (run): call sendchange(), not
3492 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3493 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3494 (stop): don't wait for process to die when sending SIGHUP
3495 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3496 directory name gets interpreted, which you don't want
3499 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3502 2005-05-18 Brian Warner <warner@lothar.com>
3504 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3506 2005-05-18 Brian Warner <warner@lothar.com>
3508 * README: update for 0.6.5
3509 * debian/changelog: same
3511 * buildbot/changes/changes.py: rename tag= to branch=, since
3512 that's how we're using it, and my design for the upcoming "build a
3513 specific branch" feature wants it. also, tag= was too CVS-centric
3514 * buildbot/changes/mail.py (parseSyncmail): same
3515 * buildbot/process/base.py (Build.isBranchImportant): same
3516 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3517 * docs/buildbot.texinfo (Attributes of Changes): same
3519 * NEWS: update tag=, update for upcoming release
3521 2005-05-17 Brian Warner <warner@lothar.com>
3523 * buildbot/scripts/runner.py (stop): actually poll once per
3524 second, instead of re-killing the poor daemon once per second.
3525 Sleep briefly (0.1s) before the first poll, since there's a good
3526 chance we can avoid waiting the full second if the daemon shuts
3527 down quickly. Also remove the sys.exit() at the end.
3528 (start): remove the unneighborly sys.exit()
3530 * Makefile: improve permission-setting to not kick Arch so badly
3532 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3533 default --keepalive=600, since it doesn't hurt very much, and it's
3534 a hassle to discover that you need it.
3535 * buildbot/test/test_runner.py (Create.testSlave): test it
3537 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3538 IRC bot about EXCEPTION
3540 * buildbot/status/client.py (PBListener): upcall more correctly
3542 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3543 an exception mark the overall build with EXCEPTION, not SUCCESS
3545 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3547 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3548 * Makefile: update some release-related stuff
3550 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3551 gets called when there isn't actually an active process, just end
3552 the Command instead of blowing up. I don't know how it gets into
3553 this state, but the twisted win32 buildslave will sometimes hang,
3554 and when it shakes its head and comes back, it thinks it's still
3555 running a Command. The next build causes this command to be
3556 interrupted, but the lack of self.process.pid breaks the interrupt
3559 * NEWS: document changes since the last release
3561 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3562 look for Makefile.buildbot instead of a bare Makefile . The
3563 'buildbot start' does not install this file, so you have to
3564 manually copy it if you want to customize startup behavior.
3565 (createMaster): change 'buildbot master' command to create
3566 Makefile.sample instead of Makefile, to create master.cfg.sample
3567 instead of master.cfg (requiring you to copy it before the
3568 buildmaster can be started). Both sample files are kept up to
3569 date, i.e. they are overwritten if they have been changed. The
3570 'buildbot.tac' file is *not* overwritten, but if the new contents
3571 don't match the old, a 'buildbot.tac.new' file is created and the
3572 user is warned. This seems to be a much more sane way to handle
3573 startup files. Also, don't sys.exit(0) when done, so we can run
3574 unit tests against it.
3575 (createSlave): same. Don't overwrite the sample info/ files.
3576 * buildbot/scripts/sample.mk: remove. the contents were pulled
3577 into runner.py, since they need to match the behavior of start()
3581 * docs/buildbot.texinfo (Launching the daemons): document it
3582 * buildbot/test/test_runner.py (Create): test it
3584 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3585 version that can handle string-in-string tests, because otherwise
3586 python-2.2 fails the tests. It'd be tremendous if Trial's test
3587 took two strings under 2.2 too.
3589 * everything: fixed all deprecation warnings when running against
3590 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3591 few that come from Twisted itself). This involved putting most of
3592 the Twisted-version specific code in the new buildbot.twcompat
3593 module, and creating some abstract base classes in
3594 buildbot.changes.base and buildbot.status.base (which might be
3595 useful anyway). __implements__ is a nuisance and requires an ugly
3596 'if' clause everywhere.
3598 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3599 delay before finishing the test: it seems that smtp.sendmail
3600 doesn't hang up on the server, so we must wait a moment so it can
3601 hang up on us. This removes the trial warning about an unclean
3604 2005-05-16 Brian Warner <warner@lothar.com>
3606 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3607 tuple of (delay, repeats).
3608 * buildbot/test/test_vc.py (Retry): test it
3609 * docs/buildbot.texinfo (Source Checkout): document it
3610 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3611 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3612 doVCFull() are handled by re-trying the checkout (after a delay)
3613 some number of times.
3614 (ShellCommand._startCommand): make header lines easier to read
3616 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3618 (WebTest.test_logfile): make sure master gets shut down, silences
3619 some "unclean reactor" test errors
3621 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3622 reactor once after shutdown, something in certain versions of
3623 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3624 fails, svn-trunk is ok.
3626 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3627 second win32 error message
3629 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3630 validating the ETA, so the tests don't fail on slow systems
3632 2005-05-15 Brian Warner <warner@lothar.com>
3634 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3635 the new LogFile class, so upgrading works properly
3636 (LogFileProducer.resumeProducing): survive resumeProducing after
3637 we've exhausted the chunkGenerator
3639 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3641 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3642 (Log.testUpgrade): same
3644 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3645 Builds and logs with a cron job.
3647 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3648 of the old non-offline LogFile, added code to upgrade these to
3649 new-style contents-live-on-disk instances at load time (in a way
3650 that doesn't invalidate the old Build pickles, so upgrading to
3651 0.6.5 is not a one-way operation). Got rid of everything related
3653 (LogFile.__init__): create LogFiles with the parent step status,
3654 the log's name, and a builder-relative filename where it can keep
3655 the contents on disk.
3656 (LogFile.hasContents): new method, clients are advised to call it
3657 before getText or getChunks and friends. If it returns False, the
3658 log's contents have been deleted and getText() will raise an
3660 (LogFile.getChunks): made it a generator
3661 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3662 Consumer (except one that takes chunks instead of strings). This
3663 enables streaming of very large logfiles without storing the whole
3665 (BuildStatus.generateLogfileName): create names like
3666 12-log-compile-output, with a _0 suffix if required to be unique
3667 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3668 or earlier) logfiles into new-style ones
3669 (BuilderStatus): remove everything related to 'stub' builds. There
3670 is now only one build cache, and we don't strip logs from old
3672 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3673 since we no longer fight to keep it in the cache
3675 * buildbot/status/html.py (TextLog.render_GET): use a
3676 ChunkConsumer to stream the log entries efficiently.
3677 (ChunkConsumer): wrapper which consumes chunks and writes
3680 * buildbot/test/test_twisted.py (Parse.testParse): use a
3681 LogFile-like object instead of a real one
3683 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3684 (Log.testMerge3): validate more merge behavior
3685 (Log.testChunks): validate LogFile.getChunks
3686 (Log.testUpgrade): validate old-style LogFile upgrading
3687 (Log.testSubscribe): validate LogFile.subscribe
3688 (Log.testConsumer): validate LogFile.subscribeConsumer
3690 * buildbot/interfaces.py (IStatusLogStub): remove
3691 (IStatusLog.subscribeConsumer): new method
3692 (IStatusLog.hasContents): new method
3693 (IStatusLogConsumer): describes things passed to subscribeConsumer
3695 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3696 the log contents if it does not have any contents.
3697 (StatusResourceBuildStep.body): same
3698 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3700 2005-05-14 Brian Warner <warner@lothar.com>
3702 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3703 timeouts to try and make the windows metabuildslave not hang
3705 2005-05-13 Mike Taylor <bear@code-bear.com>
3707 * buildbot/slave/commands.py (rmdirRecursive): added a check
3708 to ensure the path passed into rmdirRecursive actually exists.
3709 On win32 a non-existant path would generate an exception.
3711 2005-05-13 Brian Warner <warner@lothar.com>
3713 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3714 shutil.rmtree which behaves correctly on windows in the face of
3715 files that you have to chmod before deleting. Thanks to Bear at
3716 the OSAF for the routine.
3717 (SourceBase.doClobber): use rmdirRecursive
3719 2005-05-12 Brian Warner <warner@lothar.com>
3721 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3722 method generate chunks instead of returning a big list. This
3723 allows the same method to be used for both old LogFile and new
3725 (OfflineLogFile.getText): use the generator
3726 (OfflineLogFile.subscribe): same
3727 * buildbot/status/html.py (TextLog.resumeProducing): same
3728 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3730 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3731 point out that OfflineLogFile does not currently work with
3732 html.Waterfall . Fixing this is high-priority.
3734 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3735 apparently windows defaults to using stdout
3737 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3738 better message on failure so I can figure out the win32 problem
3740 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3741 log messages to include more useful copies of the command being
3742 run, the argv array, and the child command's environment.
3743 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3745 2005-05-11 Brian Warner <warner@lothar.com>
3747 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3749 * Makefile: update the deb-snapshot version
3751 * docs/buildbot.texinfo: move all .xhtml docs into a new
3752 .texinfo-format document, adding a lot of material in the process.
3753 This is starting to look like a real user's manual. Removed all
3754 the Lore-related files: *.xhtml, *.css, template.tpl .
3755 * docs/Makefile: simple makefile to run 'makeinfo'
3756 * buildbot/scripts/sample.cfg: rearrange slightly
3757 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3759 2005-05-10 Brian Warner <warner@lothar.com>
3761 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3762 different name for the internal twistw module, handle it.
3764 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3765 * setup.py: .. and stop trying to install it
3767 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3768 'git'), the new linux kernel VC system (http://kernel.org/git/).
3769 Thanks to Brandon Philips for the patch.
3770 * buildbot/slave/commands.py (Git): same
3772 2005-05-06 Brian Warner <warner@lothar.com>
3774 * buildbot/status/builder.py (OfflineLogFile): replace the default
3775 LogFile with a form that appends its new contents to a disk file
3776 as they arrive. The complete log data is never kept in RAM. This
3777 is the first step towards handling very large (100MB+) logfiles
3778 without choking quite so badly. (The other half is
3779 producer/consumer on the HTML pages).
3780 (BuildStepStatus.addLog): use OfflineLogFile by default
3781 (BuildStatus.getLogfileName): helper code to give the
3782 OfflineLogFile a filename to work with
3784 * buildbot/test/test_status.py (Results.testAddResults): update
3785 tests to handle new asserts
3786 * buildbot/test/test_vc.py (Patch.doPatch): same
3787 * buildbot/test/test_steps.py (BuildStep.setUp): same
3789 2005-05-05 Brian Warner <warner@lothar.com>
3791 * buildbot/scripts/runner.py (start): if there is no Makefile,
3792 launch the app by importing twistd's internals and calling run(),
3793 rather than spawning a new twistd process. This stands a much
3794 better chance of working under windows.
3795 (stop): kill the process with os.kill instead of spawning
3796 /bin/kill, again to reduce the number of external programs which
3797 windows might not have in the PATH. Also wait up to 5 seconds for
3798 the process to go away, allowing things like 'buildbot stop;
3799 buildbot start' to be reliable in the face of slow shutdowns.
3801 * buildbot/master.py (Dispatcher.__getstate__): remove old
3802 .tap-related methods
3803 (BuildMaster.__getstate__): same
3805 * buildbot/slave/bot.py (makeService): same
3806 (Options.longdesc): same
3807 * buildbot/scripts/runner.py: copy over some old mktap option text
3809 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3810 'buildbot master' now creates a buildbot.tac file, so there is no
3811 longer a create-instance/save/reload sequence. mktap is dead, long
3813 * buildbot/scripts/sample.mk: use twistd -y, not -f
3814 * buildbot/test/test_config.py: remove mktap-based test
3815 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3816 * README: don't reference mktap
3818 * docs/source.xhtml: document some of the attributes that Changes
3821 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3823 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3824 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3825 * buildbot/changes/changes.py (Change)
3826 * buildbot/changes/mail.py (parseSyncmail)
3827 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3829 * buildbot/process/base.py (Build.isTagImportant)
3833 2005-05-04 Brian Warner <warner@lothar.com>
3835 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3836 connection after sending the change, so that unit tests don't
3837 complain about sockets being left around
3839 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3840 exception in phase=0 rendering
3841 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3843 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3845 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3846 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3847 and configuring builders with tuples.
3848 * buildbot/test/test_config.py: stop testing compatibility with
3849 deprecated config keys
3850 * buildbot/test/test_run.py: same
3852 2005-05-03 Brian Warner <warner@lothar.com>
3854 * contrib/arch_buildbot.py: survive if there are no logfiles
3855 (username): just use a string, os.getlogin isn't reliable
3857 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3858 so 'buildbot sendchange' actually works. The earlier test only
3859 covered the internal (non-reactor-running) form.
3861 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3862 script to notify the buildmaster about changes
3864 * buildbot/scripts/runner.py (sendchange): new command to send a
3865 change to a buildbot.changes.pb.PBChangeSource receiver.
3866 * buildbot/test/test_changes.py (Sender): test it
3868 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3869 after any reading of the config file, not just when we do it in
3870 startService. This makes some tests a bit cleaner.
3872 * buildbot/changes/pb.py: add some log messages
3874 * buildbot/process/base.py (Build.startBuild): fix a bug that
3875 caused an exception when the build terminated in the very first
3877 (Build.stepDone): let steps return a status of EXCEPTION. This
3878 terminates the build right away, and sets the build's overall
3879 status to EXCEPTION too.
3880 * buildbot/process/step.py (BuildStep.failed): return a status of
3881 EXCEPTION when that is what has happened.
3883 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3884 implement this, allowing Arch-based projects to get precise
3885 checkouts instead of always using the latest code
3886 (Bazaar): create variant of Arch to let folks use baz instead of
3887 tla. Requires a new buildslave too.
3888 * buildbot/slave/commands.py (Arch): add 'revision' argument
3889 (Bazaar): create variant of Arch that uses baz instead of tla.
3890 Remove the code that extracts the archive name from the
3891 register-archive output, since baz doesn't provide it, and require
3892 the user provide both the archive name and its location.
3893 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3895 2005-05-02 Brian Warner <warner@lothar.com>
3897 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3898 thanks to Nick Trout.
3900 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3901 deals better with source Makefile coming from a read-only CVS
3902 checkout. Thanks to Nick Trout for the catch.
3904 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3907 2005-04-28 Brian Warner <warner@lothar.com>
3909 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3911 * debian/changelog: update for 0.6.4
3913 2005-04-28 Brian Warner <warner@lothar.com>
3915 * README.w32: add a checklist of steps for getting buildbot
3917 * MANIFEST.in: include it in the tarball
3921 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3922 broken .tap files from 0.6.3 by getting rid of .services,
3923 .namedServices, and .change_svc at load time.
3925 2005-04-27 Brian Warner <warner@lothar.com>
3927 * NEWS: update in preparation for new release
3929 * buildbot/test/test_config.py (Save.testSave): don't pull in
3930 twisted.scripts.twistd, we don't need it and it isn't for windows
3933 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3934 accomodate win32 which can't do atomic-rename
3936 2005-04-27 Brian Warner <warner@lothar.com>
3938 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3939 timeouts to help the slow metabuildbot not flunk them so much
3940 (Disconnect.testBuild3): same
3941 (Disconnect.testBuild4): same
3942 (Disconnect.testInterrupt): same
3944 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3945 setup, it was completely broken for new buildmasters (those which
3946 did not have a 'change.pck' already saved. Thanks to Paul Warren
3947 for catching this (embarrassing!) bug.
3948 (Dispatcher.__getstate__): don't save our registered avatar
3949 factories, since they'll be re-populated when the config file is
3951 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3952 tests (since the real mktap-generated BuildMaster doesn't save
3954 (BuildMaster.__getstate__): don't save any service children,
3955 they'll all be re-populated when the config file is re-read.
3956 * buildbot/test/test_config.py (Save.testSave): test for this
3958 2005-04-26 Brian Warner <warner@lothar.com>
3960 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3961 rendered with Blender.. looks a bit nicer.
3962 * buildbot/docs/images/icon.blend: add the Blender file for it
3964 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3965 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3966 running under windows. This appears to be the best way to allow
3967 BuildSteps to do something normal like 'trial -v buildbot.test' or
3968 'make foo' and still expect it to work. The idea is to make the
3969 BuildSteps look as much like what a developer would type when
3970 compiling or testing the tree by hand. This approach probably has
3971 problems when there are spaces in the arguments, so if you've got
3972 windows buildslaves, you'll need to pay close attention to your
3975 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3976 timezone to the timestamp column.
3977 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3979 * buildbot/scripts/runner.py (loadOptions): do something sane for
3980 windows, I think. We use %APPDATA%/buildbot instead of
3981 ~/.buildbot, but we still search everywhere from the current
3982 directory up to the root for a .buildbot/ subdir. The "is it under
3983 $HOME" security test was replaced with "is it owned by the current
3984 user", which is only performed under posix.
3985 * buildbot/test/test_runner.py (Options.testFindOptions): update
3986 tests to match. The "is it owned by the current user" check is
3987 untested. The test has been re-enabled for windows.
3989 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3990 any "\n" in the expected output with the platform-specific line
3991 separator. Make this separator "\r\n" on PTYs under unix, they
3992 seem to do that and I don't know why
3994 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3995 windows for now, I don't know what ~/.buildbot/ should mean there.
3997 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3998 win32 compatibility, don't use "/tmp"
3999 (Basedir.testChangeBuilddir): remove more unixisms
4001 2005-04-26 Brian Warner <warner@lothar.com>
4003 * buildbot/test/test_control.py (Force.rmtree): python2.2
4004 compatibility, apparently its shutil.rmtree ignore_errors=
4005 argument is ignored.
4006 * buildbot/test/test_run.py (Run.rmtree): same
4007 (RunMixin.setUp): same
4009 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4012 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4013 'substring in string' operator, must use string.find(substr)!=-1
4014 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4015 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4017 * buildbot/scripts/runner.py (loadOptions): add code to search for
4018 ~/.buildbot/, a directory with things like 'options', containing
4019 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4020 the current directory, your $HOME directory, or anywhere
4021 inbetween, as long as you're somewhere inside your home directory.
4022 (debugclient): look in ~/.buildbot/options for master and passwd
4023 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4024 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4026 * buildbot/status/client.py (makeRemote): new approach to making
4027 IRemote(None) be None, which works under Twisted-2.0
4028 * buildbot/test/test_status.py (Client.testAdaptation): test it
4030 * buildbot/status/builder.py (Status.builderAdded): when loading a
4031 pickled BuilderStatus in from disk, set its name after loading.
4032 The config file might have changed its name (but not its
4033 directory) while it wasn't looking.
4035 * buildbot/process/builder.py (Builder.attached): always return a
4036 Deferred, even if the builder was already attached
4037 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4039 2005-04-25 Brian Warner <warner@lothar.com>
4041 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4042 category-related exception when announcing a build has finished
4044 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4045 reference no-longer-existent changemaster.sources
4046 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4048 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4051 2005-04-25 Brian Warner <warner@lothar.com>
4053 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4055 * debian/changelog: update for 0.6.3
4057 2005-04-25 Brian Warner <warner@lothar.com>
4059 * MANIFEST.in: make sure debug.glade is in the tarball
4061 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4063 * NEWS: update for the imminent 0.6.3 release
4065 * buildbot/status/html.py (HtmlResource.content): make the
4066 stylesheet <link> always point at "buildbot.css".
4067 (StatusResource.getChild): map "buildbot.css" to a static.File
4068 containing whatever css= argument was provided to Waterfall()
4069 (Waterfall): provide the "classic" css as the default.
4070 * docs/waterfall.classic.css: move default CSS from here ..
4071 * buildbot/status/classic.css: .. to here
4073 * MANIFEST.in: make sure classic.css is included in the tarball
4074 * setup.py: and that it is installed too, under buildbot/status/
4076 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4077 the module level, because buildbot.tap files from 0.6.2 don't have
4078 it in their attribute dictionary.
4080 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4081 really exists at startup, might save some confusion somewhere.
4083 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4085 * docs/waterfall.classic.css:
4086 add a stylesheet that's almost the same as the "classic"
4089 * buildbot/status/builder.py:
4090 add EXCEPTION as a result - this is a problem for the bot
4091 maintainer, not a build problem for the changers
4092 * buildbot/process/step.py:
4093 use EXCEPTION instead of FAILURE for exceptions
4094 * buildbot/status/html.py:
4095 add build_get_class to get a class out of a build/buildstep
4096 finish naming the classes
4097 split out sourceNames to changeNames and builderNames so we
4098 can style them separately
4099 * docs/config.xhtml:
4100 finish documenting classes as they are right now
4102 * buildbot/status/html.py:
4103 name the classes as we agreed on IRC
4104 * docs/config.xhtml:
4107 * buildbot/status/html.py:
4108 same for cssclass->class_
4110 * buildbot/status/html.py:
4111 as decided on IRC, use class_ for the "class" attribute to not
4112 conflict with the class keyword, and clean up the messy **{} stuff.
4114 * buildbot/status/mail.py:
4115 put back "builders" argument, and fix docstring, because the
4116 code *ignores* builders listed in this argument
4118 * buildbot/process/builder.py:
4119 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4121 * docs/config.xhtml:
4122 describe the category argument for builders
4124 * buildbot/status/builder.py:
4125 Fix a silly bug due to merging
4127 * buildbot/process/builder.py:
4128 remove category from the process Builder ...
4129 * buildbot/status/builder.py:
4130 ... and add it to BuilderStatus instead.
4131 Set category on unpickled builder statuses, they might not have it.
4132 * buildbot/master.py:
4133 include category when doing builderAdded
4134 * buildbot/status/mail.py:
4135 return None instead of self for builders we are not interested in.
4136 * buildbot/test/test_run.py:
4137 fix a bug due to only doing deferredResult on "dummy" waiting
4138 * buildbot/test/test_status.py:
4139 add checks for the Mail IStatusReceiver returning None or self
4141 * buildbot/status/html.py:
4142 fix testsuite by prefixing page title with BuildBot
4144 * buildbot/status/builder.py:
4145 have .category in builder status ...
4146 * buildbot/process/builder.py:
4147 ... and set it from Builder
4148 * buildbot/status/html.py:
4149 make .css a class variable
4150 * buildbot/test/test_status.py:
4151 write more tests to cover our categories stuff ...
4152 * buildbot/status/mail.py:
4153 ... and fix the bug that this uncovered
4155 * buildbot/changes/mail.py:
4156 * buildbot/changes/pb.py:
4157 * buildbot/master.py:
4158 * buildbot/process/base.py:
4159 * buildbot/process/factory.py:
4160 * buildbot/process/interlock.py:
4161 * buildbot/process/step.py:
4162 * buildbot/process/step_twisted.py:
4163 * buildbot/slave/commands.py:
4164 * buildbot/status/builder.py:
4165 * buildbot/status/client.py:
4166 * buildbot/status/html.py:
4167 * buildbot/status/mail.py:
4168 * buildbot/status/progress.py:
4169 * buildbot/test/test_changes.py:
4170 * buildbot/test/test_config.py:
4171 * buildbot/test/test_control.py:
4172 * buildbot/test/test_interlock.py:
4173 * buildbot/test/test_maildir.py:
4174 * buildbot/test/test_mailparse.py:
4175 * buildbot/test/test_run.py:
4176 * buildbot/test/test_slavecommand.py:
4177 * buildbot/test/test_status.py:
4178 * buildbot/test/test_steps.py:
4179 * buildbot/test/test_twisted.py:
4180 * buildbot/test/test_util.py:
4181 * buildbot/test/test_vc.py:
4182 * buildbot/test/test_web.py:
4184 add test-case-name at the top of a whole set of files
4186 * buildbot/status/builder.py:
4187 keep order of addition when getting builder names
4188 * buildbot/status/words.py:
4189 * buildbot/test/test_run.py:
4190 add test for getBuilderNames
4192 * buildbot/process/base.py:
4193 * buildbot/process/step.py:
4194 * buildbot/status/builder.py:
4195 * buildbot/status/html.py:
4196 make buildbot css-able
4197 replace the color code for purple with purple, don't understand
4198 why it wasn't purple to start with
4200 * buildbot/status/words.py:
4201 ok, so it doesn't look like BuilderStatus.remote is still valid.
4202 Use what waterfall uses instead.
4204 * buildbot/interfaces.py:
4205 * buildbot/status/builder.py:
4206 * buildbot/status/html.py:
4207 * buildbot/status/mail.py:
4208 * buildbot/status/words.py:
4209 * buildbot/test/test_run.py:
4210 use categories everywhere and make it be a list. More sensible
4211 for the future. Also make words actually respect this in
4214 * buildbot/interfaces.py:
4215 add category argument to getBuilderNames
4216 * buildbot/process/builder.py:
4217 * buildbot/status/builder.py:
4218 * buildbot/status/html.py:
4219 * buildbot/status/mail.py:
4220 * buildbot/status/words.py:
4221 * buildbot/test/test_run.py:
4222 move from specifying builders by name to specifying the category
4224 * buildbot/status/html.py:
4225 * buildbot/status/words.py:
4226 add "builders=" to __init__ of status clients so they can
4227 limit themselves to the given list of builders to report on
4229 * buildbot/status/html.py: set the title to the product name
4231 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4233 * buildbot/interfaces.py:
4234 * buildbot/status/builder.py:
4235 more documentation. Hm, not sure if ChangeLog entries make sense
4238 2005-04-23 Brian Warner <warner@lothar.com>
4240 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4242 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4244 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4245 the sub-commands that log buildmaster status to stdout and to a
4246 GUI window, respectively.
4248 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4249 functionality is working again, but all the step-status and ETA
4250 stuff is missing. Commented out a lot of code pending more
4253 * buildbot/status/client.py: make sure that IRemote(None) is None
4255 * buildbot/changes/changes.py: import defer, oops
4256 (ChangeMaster): remove the .sources list, rely upon the fact that
4257 MultiServices can be treated as sequences of their children. This
4258 cleans up the add/remove ChangeSource routines a lot, as we keep
4259 exactly one list of the current sources instead of three.
4261 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4262 up an empty ChangeMaster at init time.
4263 (BuildMaster.loadChanges): if there are changes to be had from
4264 disk, replace self.change_svc with the new ones. If not, keep
4265 using the empty ChangeMaster set up in __init__.
4266 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4267 instead of a separate list, makes the code a bit cleaner.
4268 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4269 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4270 Extend the test to make sure we can get rid of the sources when
4273 2005-04-22 Brian Warner <warner@lothar.com>
4275 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4276 and info/host files when making the slave directory
4278 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4279 whendone= argument, just return the Deferred and let the caller do
4280 what they want with it.
4281 (Disconnect.testBuild1): wait for shutdownSlave
4282 (Basedir.testChangeBuilddir): new test to make sure changes to the
4283 builddir actually get propagated to the slave
4285 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4286 explicit method, rather than passing the builddir in __init__ .
4287 Make sure to update self.basedir too, this was broken before.
4288 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4289 builders and for ones that have just had their builddir changed.
4290 (BotFactory): add a class-level .perspective attribute, so
4291 BuildSlave.waitUntilDisconnected won't get upset when the
4292 connection hasn't yet been established
4293 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4294 tests can reach through it to inspect the SlaveBuilders
4296 * buildbot/process/base.py (Build.buildException): explain the
4297 log.err with a log.msg
4298 * buildbot/process/builder.py (Builder.startBuild): same
4299 (Builder._startBuildFailed): improve error message
4301 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4302 occurred because we lost the brand-new connection, retry instead
4303 of giving up. If not, it's probably an authorization failure, and
4304 it makes sense to stop trying. Make sure we log.msg the reason
4305 that we're log.err'ing the failure, otherwise test failures are
4306 really hard to figure out.
4308 * buildbot/master.py: change loadConfig() to return a Deferred
4309 that doesn't fire until the change has been fully implemented.
4310 This means any connected slaves have been updated with the new
4311 builddir. This change makes it easier to test the code which
4312 actually implements this builddir-updating.
4313 (BotPerspective.addBuilder): return Deferred
4314 (BotPerspective.removeBuilder): same
4315 (BotPerspective.attached): same
4316 (BotPerspective._attached): same. finish with remote_print before
4317 starting the getSlaveInfo, instead of doing them in parallel
4318 (BotPerspective.list_done): same
4319 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4320 actually calling slave.disconnect()
4321 (BotMaster.addBuilder): same
4322 (BotMaster.removeBuilder): same
4323 (BuildMaster.loadConfig): same
4324 (BuildMaster.loadConfig_Slaves): same
4325 (BuildMaster.loadConfig_Sources): same
4326 (BuildMaster.loadConfig_Builders): same
4327 (BuildMaster.loadConfig_status): same
4329 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4330 a Deferred that fires when the source is finally removed
4332 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4333 the previous tree on win32, where we have to do it synchronously,
4334 make sure we return a Deferred anyway.
4335 (SourceBase.doCopy): same
4337 * buildbot/scripts/runner.py (statusgui): use the text client for
4338 now, while I rewrite the Gtk one
4339 * buildbot/clients/base.py: strip out old code, leaving just the
4340 basic print-message-on-event functionality. I also remove the
4341 ReconnectingPBClientFactory, but it does at least quit when it
4342 loses the connection instead of going silent
4344 2005-04-21 Brian Warner <warner@lothar.com>
4346 * Makefile: minor tweaks
4348 * NEWS: point out deprecation warnings, new features for
4351 * buildbot/master.py (BuildMaster.loadConfig): emit
4352 DeprecationWarnings for Builders defined with tuples. Rearrange
4353 code to facility removal of deprecated configuration keys in the
4356 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4357 'buildbot' command to put a little Makefile in the target that
4358 helps you re-create the buildbot.tap file, start or stop the
4359 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4360 all the files 0600, since they contain passwords.
4361 (start): if there is a Makefile, and /usr/bin/make exists, use
4362 'make start' in preference to a raw twistd command. This lets
4363 slave admins put things like PYTHONPATH variables in their
4364 Makefiles and have them still work when the slave is started with
4365 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4366 be nice to first try the 'make' command and only fall back to
4367 twistd if it fails. TODO: the Makefile's "start" command does not
4368 add the --reactor=win32 argument when running under windows.
4369 (Options.debugclient, Options.statusgui): add sub-commands to launch
4370 the debug client (formerly in contrib/debugclient.py) and the
4371 Gtk status application (currently broken)
4372 * buildbot/clients/debug.py: move from contrib/debugclient.py
4373 * buildbot/clients/debug.glade: same
4375 * buildbot/test/test_trial.py: remove it. This requires some
4376 functionality out of Twisted that isn't there yet, and until then
4377 having it around just confuses things.
4379 * buildbot/test/test_slavecommand.py (Shell): test both with and
4380 without PTYs, and make sure that command output is properly
4381 interleaved in the with-PTY case. I think the without-PTY test
4382 should pass on windows, where we never use PTYs anyway.
4384 2005-04-20 Brian Warner <warner@lothar.com>
4386 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4388 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4390 * NEWS: start creating entries for the next release
4392 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4394 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4395 (WebTest.test_webPathname): same
4396 (WebTest.test_webPathname_port): same
4397 (WebTest.test_waterfall): use the default favicon rather than
4398 rooting around the filesystem for it. Open the expected-icon file
4399 in binary mode, to make win32 tests happier (thanks to Nick Trout
4401 * buildbot/status/html.py (buildbot_icon): win32 portability
4403 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4404 win32-compatibility fixes from Nick Trout, the "file not found" message
4405 is different under windows
4406 (FakeSlaveBuilder.__init__): clean up setup a bit
4407 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4409 2005-04-19 Brian Warner <warner@lothar.com>
4411 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4412 skip-if-repositories-are-unavailable test to not kill the trial
4413 that comes with Twisted-1.3.0
4415 * setup.py: install buildbot.png icon file when installing code
4417 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4418 environment used by the command, at least on the child side.
4420 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4421 this method needs to be added and implemented because it gets
4422 called under heavy load. I don't quite understand the
4423 producer/consumer API enough to write it.
4424 (StatusResource.getChild): add a resource for /favicon.ico
4425 (Waterfall.__init__): add favicon= argument
4426 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4427 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4428 (WebTest.test_webPathname): same
4429 (WebTest.test_webPathname_port): same
4430 * docs/config.xhtml: mention favicon=
4431 * buildbot/buildbot.png: add a default icon, dorky as it is
4433 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4435 * buildbot/master.py:
4436 * buildbot/process/base.py:
4437 * buildbot/process/builder.py:
4438 * buildbot/process/interlock.py:
4439 * buildbot/status/builder.py:
4440 * buildbot/status/html.py:
4441 * buildbot/status/mail.py:
4442 * buildbot/status/words.py:
4443 new documentation while digging through the code
4445 2005-04-17 Brian Warner <warner@lothar.com>
4447 * general: try to fix file modes on all .py files: a+r, a-x,
4448 but let buildbot/clients/*.py be +x since they're tools
4450 * docs/epyrun (addMod): when an import fails, say why
4452 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4454 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4456 * buildbot/process/base.py:
4457 * buildbot/process/builder.py:
4458 * buildbot/status/builder.py:
4459 new documentation while digging through the code
4461 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4463 * buildbot/changes/changes.py:
4464 * buildbot/changes/p4poller.py:
4465 * buildbot/interfaces.py:
4466 * buildbot/process/base.py:
4467 * buildbot/process/builder.py:
4468 * buildbot/process/step.py:
4469 * buildbot/process/step_twisted.py:
4470 * buildbot/slave/bot.py:
4471 * buildbot/slave/commands.py:
4472 * buildbot/status/builder.py:
4473 fix all docstrings to make epydoc happy. In the process of fixing
4474 some, I also moved pieces of docs, and removed some deprecated
4477 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4479 * buildbot/process/builder.py:
4480 * buildbot/process/interlock.py:
4481 * buildbot/process/process_twisted.py:
4482 * buildbot/process/step.py:
4483 BuildProcess -> Build, as it looks like that's what happened
4484 * buildbot/process/base.py:
4485 * buildbot/process/factory.py:
4488 2005-04-17 Brian Warner <warner@lothar.com>
4490 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4491 update compile command to accomodate the Twisted split.. now
4492 instead of './setup.py build_ext -i', you do './setup.py all
4493 build_ext -i', to run build_ext over all sub-projects.
4494 (FullTwistedBuildFactory): same
4495 (TwistedReactorsBuildFactory): same
4497 * buildbot/status/html.py (TextLog.finished): null out self.req
4498 when we're done, otherwise the reference cycle of TextLog to .req
4499 to .notifications to a Deferred to TextLog.stop keeps them from
4500 being collected, and consumes a huge (610MB on pyramid at last
4501 check) amount of memory.
4503 2005-04-11 Brian Warner <warner@lothar.com>
4505 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4506 normalize the VC-repository location.. makes SVN happier with
4507 certain test environments.
4509 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4510 RemoteShellCommand gets its own .env dictionary, so that code in
4511 start() doesn't mutate the original. I think this should fix the
4512 step_twisted.Trial problem where multiple identical components
4513 kept getting added to PYTHONPATH= over and over again.
4515 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4516 adding epydoc-format docstrings to many classes. Thanks to Thomas
4517 Vander Stichele for the patches.
4518 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4519 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4520 * buildbot/slave/bot.py, commands.py, registry.py: same
4522 2005-04-05 Brian Warner <warner@lothar.com>
4524 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4525 preserve timestamps, helps incremental builds of large trees.
4526 Patch from Rene Rivera.
4528 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4529 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4532 2005-04-03 Brian Warner <warner@lothar.com>
4534 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4535 with one dict, apparently exec has some scoping bugs when used
4536 with both global/local dicts. Thanks to Nathaniel Smith for the
4539 2005-04-02 Brian Warner <warner@lothar.com>
4541 * buildbot/process/step_twisted.py (countFailedTests): the new
4542 trial in Twisted-2.0 emits a slightly different status line than
4543 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4544 mistakenly think the test count is unparseable.
4545 (Trial.start): note that for some reason each build causes another
4546 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4547 be fixed but I'm not sure quite where the problem is.
4549 2005-04-01 Brian Warner <warner@lothar.com>
4551 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4552 deferredResult to avoid hangs/warnings under twisted-2.0
4553 (RunMixin.tearDown): same
4554 (RunMixin.shutdownSlave): same
4555 (Disconnect.testIdle1): same
4556 (Disconnect.testBuild2): same: wait one second after the build
4557 finishes for test to really be done.. this should be cleaned up to
4558 avoid wasting that second. Builder.detach uses a callLater(0),
4559 either that should be done in-line (something else needed that
4560 behavior), or it should return a Deferred that fires when the
4561 builder is really offline.
4562 (Disconnect.testBuild3): same
4563 (Disconnect.testDisappear): same
4565 * buildbot/test/test_web.py: rearrange server-setup and teardown
4566 code to remove unclean-reactor warnings from twisted-2.0
4568 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4569 so the tests don't hang under twisted-2.0
4571 2005-03-31 Brian Warner <warner@lothar.com>
4573 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4574 caused a warning each time the master changed our set of builders
4576 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4577 w32, don't unlink the file unless it already exists. Thanks to
4578 Baptiste Lepilleur for the catch.
4579 (BuilderStatus.saveYourself): same
4581 2005-02-01 Brian Warner <warner@lothar.com>
4583 * buildbot/status/html.py (TextLog.getChild): use a /text child
4584 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4585 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4586 logfile as text/plain (no markup, no headers). This replaces the
4587 previous scheme (which used an ?text=1 argument), and gets us back
4588 to a relative link (which works better when the buildbot lives
4589 behind another web server, such as Apache configured as a reverse
4590 proxy). Thanks to Gerald Combs for spotting the problem.
4592 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4595 2004-12-13 Brian Warner <warner@lothar.com>
4597 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4599 * debian/changelog: update for 0.6.2
4600 * NEWS: finalize for 0.6.2
4602 2004-12-11 Brian Warner <warner@lothar.com>
4604 * NEWS: bring it up to date
4606 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4607 detection code. Require some sign of life from the buildmaster
4608 every BotFactory.keepaliveInterval seconds. Provoke this
4609 indication at BotFactory.keepaliveTimeout seconds before the
4610 deadline by sending a keepalive request. We don't actually care if
4611 that request is answered in a timely fashion, what we care about
4612 is that .activity() is called before the deadline. .activity() is
4613 triggered by any PB message from the master (including an ack to
4614 one of the slave's status-update messages). With this new scheme,
4615 large status messages over slow pipes are OK, as long as any given
4616 message can be sent (and thus acked) within .keepaliveTimeout
4617 seconds (which defaults to 30).
4618 (SlaveBuilder.remote_startCommand): record activity
4619 (SlaveBuilder.ackUpdate): same
4620 (SlaveBuilder.ackComplete): same
4621 (BotFactory.gotPerspective): same
4622 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4624 2004-12-09 Brian Warner <warner@lothar.com>
4626 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4629 * buildbot/process/step_twisted.py (Trial._commandComplete):
4630 update self.cmd when we start the 'cat test.log' transfer. Without
4631 this, we cannot interrupt the correct RemoteCommand when we lose
4634 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4635 trying to tell the slave to stop the command if we're already
4636 inactive, or if we no longer have a .remote
4638 * buildbot/process/builder.py (Builder._detached): don't let an
4639 exception in currentBuild.stopBuild() prevent the builder from
4640 being marked offline
4642 2004-12-07 Brian Warner <warner@lothar.com>
4644 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4645 KeyError that happens when you ask for a non-existent Builder, and
4646 translate it into a UsageError.
4648 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4649 losing the slave in the middle of a remote step is handled too
4651 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4652 be a Failure, so be sure to stringify it before using it as the
4653 contents of the 'interrupt' logfile
4654 (RemoteCommand.interrupt): use stringified 'why' in
4655 remote_interruptCommand too, just in case
4657 2004-12-06 Brian Warner <warner@lothar.com>
4659 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4660 instead of 'tla update', which is more efficient in case we've
4661 missed a couple of patches since the last update.
4663 * debian/changelog: update for previous (0.6.1) release. Obviously
4664 this needs to be handled better.
4666 2004-12-05 Brian Warner <warner@lothar.com>
4668 * NEWS: update for stuff since last release
4670 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4671 match the maybeDeferred change in Dispatcher.requestAvatar
4672 * buildbot/changes/pb.py (ChangePerspective.attached): same
4673 * buildbot/status/client.py (StatusClientPerspective.attached): same
4674 * buildbot/process/builder.py (Builder._attached3): same
4675 * buildbot/pbutil.py (NewCredPerspective.attached): same
4677 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4678 the date to the top-most box, if it is not the same as today's
4681 * docs/slave.xhtml: provide a buildslave setup checklist
4683 * docs/source.xhtml (Arch): correct terminology
4685 2004-12-04 Brian Warner <warner@lothar.com>
4687 * buildbot/test/test_slavecommand.py: use sys.executable instead
4688 of hard-coding 'python' for child commands, might help portability
4690 * docs/examples/twisted_master.cfg: update to current usage
4692 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4693 'stop build' command to the IRC bot
4695 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4696 message that broke PBChangeSource
4698 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4699 (SlaveBuilder): make some attributes class-level, remove the old
4700 "update queue" which existed to support resuming a build after the
4701 master connection was lost. Try to reimplement that feature later.
4702 (SlaveBuilder.stopCommand): clear self.command when the
4703 SlaveCommand finishes, so that we don't try to kill a leftover one
4705 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4708 * buildbot/slave/commands.py (SourceBase): set self.command for
4709 all VC commands, so they can be interrupted.
4711 2004-12-03 Brian Warner <warner@lothar.com>
4713 * buildbot/master.py: clean up slave-handling code, to handle
4714 slave-disconnect and multiple-connect better
4715 (BotPerspective): make these long-lasting, exactly one per bot
4716 listed in the config file.
4717 (BotPerspective.attached): if a slave connects while an existing
4718 one appears to still be connected, disconnect the old one first.
4719 (BotPerspective.disconnect): new method to forcibly disconnect a
4720 buildslave. Use some hacks to empty the transmit buffer quickly to
4721 avoid the long (20-min?) TCP timeout that could occur if the old
4722 slave has dropped off the net.
4723 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4724 own their own SlaveStatus objects. Remove .attached/.detached, add
4725 .addSlave/.removeSlave, treat slaves like Builders (config file
4726 parsing sends deltas to the BotMaster). Inform the slave
4727 instances, i.e. the BotPerspective, about addBuilder and
4729 (BotMaster.getPerspective): turns into a single dict lookup
4730 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4731 which gives BotPerspective.attached a chance to disconnect the old
4733 (BuildMaster.loadConfig): add code (disabled) to validate that all
4734 builders use known slaves (listed in c['bots']). The check won't
4735 work with tuple-specified builders, which are deprecated but not
4736 yet invalid, so the check is disabled for now.
4737 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4738 routine, do the add/changed/removed dance with them like we do
4740 (BuildMaster.loadConfig_Sources): move source-config into a
4741 separate routine too
4743 * buildbot/status/builder.py (Status.getSlave): get the
4744 SlaveStatus object from the BotPerspective, not the BotMaster.
4746 * buildbot/test/test_run.py: bunch of new tests for losing the
4747 buildslave at various points in the build, handling a slave that
4748 connects multiple times, and making sure we can interrupt a
4751 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4752 something other than 'Bot' for the Bot object, to make certain
4753 test cases easier to write.
4754 (BuildSlave.waitUntilDisconnected): utility method for testing
4756 2004-11-30 Brian Warner <warner@lothar.com>
4758 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4760 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4761 argument, return a Deferred that always fires with True or False.
4762 I don't use an errback to indicate 'ping failed' so that callers
4763 are free to ignore the deferred without causing spurious errors in
4765 * buildbot/process/builder.py (BuilderControl.ping): implement it
4767 * buildbot/test/test_run.py (Status.testDisappear): test ping
4768 (Status.disappearSlave): fix it
4770 2004-11-30 Brian Warner <warner@lothar.com>
4772 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4773 (IBuilderControl): add .getBuild(num), only works for the current
4774 build, of course, although it might be interesting to offer
4775 something for builds in the .waiting or .interlocked state.
4777 * buildbot/process/base.py (Build): have .stopBuild just do the
4778 interrupt, then let the build die by itself.
4779 (BuildControl): add .stopBuild, and add a point-event named
4780 'interrupt' just after the build so status viewers can tell that
4782 (BuilderControl): add .getBuild
4784 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4785 stops when you kill it, good for testing
4786 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4787 contains the 'reason' text.
4789 * buildbot/status/html.py: Add Stop Build button, if the build can
4790 still be stopped. Send a Redirect (to the top page) one second
4791 later, hopefully long enough for the interrupt to have an effect.
4792 Move make_row() up to top-level to share it between Stop Build and
4795 * buildbot/slave/commands.py: only kill the child process once
4797 * buildbot/test/test_run.py: add testInterrupt
4799 2004-11-29 Brian Warner <warner@lothar.com>
4801 * buildbot/process/base.py: Refactor command interruption. The
4802 Build is now responsible for noticing that the slave has gone
4803 away: Build.lostRemote() interrupts the current step and makes
4804 sure that no further ones will be started.
4806 * buildbot/process/builder.py: When the initial remote_startBuild
4807 message fails, log it: this usually indicates that the slave has
4808 gone away, but we don't really start paying attention until they
4809 fail to respond to the first step's command.
4811 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4812 slave disconnect. Now sports a new interrupt() method. Error
4813 handling was simplified a lot by chaining deferreds, so
4814 remoteFailed/remoteComplete were merged into a single
4815 remoteComplete method (which can now get a Failure object).
4816 Likewise failed/finished were merged into just _finished.
4817 (BuildStep): Add interrupt(why) method, and if why is a
4818 ConnectionLost Failure then the step is failed with some useful
4821 * buildbot/slave/bot.py: stop the current command when the remote
4822 Step reference is lost, and when the slave is shut down.
4823 (Bot): make it a MultiService, so it can have children. Use
4824 stopService to tell when the slave is shutting down.
4825 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4826 remote_interruptCommand (which asks the current SlaveCommand to
4827 stop but allows it to keep emitting status messages), and
4828 stopCommand (which tells it to shut up and die).
4830 * buildbot/slave/commands.py: make commands interruptible
4831 (ShellCommand.kill): factor out os.kill logic
4832 (Command): factor out setup()
4833 (Command.sendStatus): don't send status if .running is false, this
4834 happens when the command has been halted.
4835 (Command.interrupt): new method, used to tell the command to die
4836 (SlaveShellCommand): implement .interrupt
4837 (DummyCommand): implement .interrupt
4838 (SourceBase, etc): factor out setup(), don't continue substeps if
4841 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4842 so they can be called after finishing
4844 * buildbot/test/test_run.py: new tests for disconnect behavior,
4845 refactor slave-shutdown routines, add different kinds of
4848 2004-11-27 Brian Warner <warner@lothar.com>
4850 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4851 method to express ETA time like "2m45s" instead of "165 seconds"
4853 2004-11-24 Brian Warner <warner@lothar.com>
4855 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4856 archive after the test completes, to avoid cluttering the user's
4857 'tla archives' listing with a bogus entry. Arch doesn't happen to
4858 provide any way to override the use of ~/.arch-params/, so there
4859 isn't a convenient way to avoid touching the setup of the user who
4861 (VC_HTTP.testArchHTTP): same
4863 2004-11-23 Brian Warner <warner@lothar.com>
4865 * buildbot/status/html.py (TextLog): split render() up into
4866 render_HEAD and render_GET. Use a Producer when sending log
4867 chunks, to reduce memory requirements and avoid sending huge
4868 non-Banana-able strings over web.distrib connections. Requires
4869 peeking under the covers of IStatusLog.
4870 (TextLog.resumeProducing): fix the "as text" link, handle client
4871 disconnects that occur while we're still sending old chunks.
4873 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4874 use defer.succeed, not the non-existent defer.success
4875 (LogFile.waitUntilFinished): same
4876 (LogFile.subscribe): don't add watchers to a finished logfile
4878 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4881 2004-11-23 Brian Warner <warner@lothar.com>
4883 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4885 2004-11-23 Brian Warner <warner@lothar.com>
4887 * NEWS: update for the 0.6.1 release
4888 * MANIFEST.in: add new files
4890 * README (INSTALLATION): explain how to enable the extra VC tests
4892 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4893 level to, so old pickled builds can be displayed ok
4895 2004-11-22 Brian Warner <warner@lothar.com>
4897 * NEWS: summarize updates since last release
4899 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4900 Yoz Grahame. Closes SF#1050138.
4902 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4905 * buildbot/process/step_twisted.py (Trial): update docs a bit
4907 * docs/factories.xhtml: fix Trial factory docs to match reality.
4910 * buildbot/process/factory.py (Trial.__init__): add args for
4911 randomly= and recurse=, making them available to instantiators
4912 instead of only to subclassers. Closes: SF#1049759.
4914 2004-11-15 Brian Warner <warner@lothar.com>
4916 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4917 try to teach the Quick factory to use multiple versions of python
4919 2004-11-12 Brian Warner <warner@lothar.com>
4921 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4922 safer w32-compatible approach, and only use it on windows
4923 (BuildStatus.saveYourself): same
4925 2004-11-11 Brian Warner <warner@lothar.com>
4927 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4928 it: one string merge per chunk. There are now separate .entries
4929 and .runEntries lists: when enumerating over all chunks, make sure
4931 * buildbot/test/test_status.py (Log): more tests
4933 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4934 chunks together, up to 10kb per chunk. This ought to cut down on
4935 the CPU-burning overhead of large log files. Thanks to Alexander
4936 Staubo for spotting the problem.
4937 * buildbot/test/test_status.py (Log): tests for same
4939 2004-11-10 Brian Warner <warner@lothar.com>
4941 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4942 header to outbound mail
4943 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4945 2004-11-08 Brian Warner <warner@lothar.com>
4947 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4948 can't do os.rename() onto an existing file, so catch the exception
4949 and unlink the target file first. This introduces a slight window
4950 where the existing file could be lost, but the main failure case
4951 (disk full) should still be handled safely.
4952 (BuildStatus.saveYourself): same
4954 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4955 separator character instead of os.sep, because the filenames being
4956 split here are coming from the VC system, which can have a
4957 different pathname convention than the local host. This should
4958 help a buildmaster running on windows that uses a CVS repository
4959 which runs under unix.
4960 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4962 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4963 when there are no test failures to be parsed
4965 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4966 instead of the unix-specific os.system("cp"), thanks to Elliot
4967 Murphy for this and the other buildbot-vs-windows catches.
4968 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4970 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4971 echo the command as it is run
4973 * setup.py: install sample.mk too, not just sample.cfg
4974 (scripts): install contrib/windows/buildbot.bat on windows
4976 2004-11-07 Brian Warner <warner@lothar.com>
4978 * buildbot/process/builder.py (Builder._detached): clear the
4979 self.currentBuild reference, otherwise the next build will be
4980 skipped because we think the Builder is already in use.
4982 * docs/examples/twisted_master.cfg: update to match current usage
4983 on the Twisted buildbot
4985 2004-10-29 Brian Warner <warner@lothar.com>
4987 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4989 2004-10-28 Brian Warner <warner@lothar.com>
4991 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4992 have separate doVCUpdate/doVCFull methods. Catch an update failure
4993 and respond by clobbering the source directory and re-trying. This
4994 will handle local changes (like replacing a file with a directory)
4995 that will cause CVS and SVN updates to fail.
4996 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4998 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5001 2004-10-19 Brian Warner <warner@lothar.com>
5003 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5005 * buildbot/status/html.py (StatusResourceTestResults): display any
5006 TestResults that the Build might have
5007 (StatusResourceTestResult): and the logs for each TestResult
5008 (StatusResourceBuild): add link from the per-build page
5010 2004-10-15 Brian Warner <warner@lothar.com>
5012 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5013 the 'problems' portion of stdout, add TestResults to our build
5014 * buildbot/test/test_twisted.py (Parse.testParse): test it
5016 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5017 to retrieve a dict of accumulated test results
5018 (ITestResult): define what a single test result can do
5019 * buildbot/status/builder.py (TestResult): implement ITestResult
5020 (BuildStatus.getTestResults): retrieve dict of TestResults
5021 (BuildStatus.addTestResult): add TestResults
5022 * buildbot/test/test_status.py (Results.testAddResults): test it
5024 2004-10-14 Brian Warner <warner@lothar.com>
5026 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5027 instead of os.system("rm -rf") for win32 portability
5029 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5030 SignalMixin instead of starting/stopping the reactor, which is
5031 likely to cause problems with other tests
5033 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5034 self.copyComplete() call. Yoz Grahame makes the catch.
5036 * contrib/windows/buildbot.bat: helper script to deal with path
5037 issues. Thanks to Yoz Grahame.
5039 * buildbot/master.py (BuildMaster.startService): don't register a
5040 SIGHUP handler if the signal module has no SIGHUP attribute.
5041 Apparently win32 does this.
5043 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5045 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5046 test if the reactor can't offer UNIX sockets
5048 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5049 error introduced in the last commit. We really need that
5052 2004-10-12 Brian Warner <warner@lothar.com>
5054 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5055 when describing a maildir source. Thanks to Stephen Davis.
5057 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5060 * buildbot/scripts/runner.py (createMaster): install Makefile too
5061 (start): add --no_save to 'start' command
5062 * buildbot/scripts/sample.mk: simple convenience Makefile with
5063 start/stop/reload targets
5065 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5068 2004-09-30 Brian Warner <warner@lothar.com>
5070 * setup.py: Releasing buildbot-0.6.0
5072 2004-09-30 Brian Warner <warner@lothar.com>
5074 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5075 test_trial.py from the source tarball until support is complete.
5077 * NEWS: update for 0.6.0 release
5078 * buildbot/__init__.py (version): same
5081 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5082 'source' command to tell users where to get the Buildbot source
5084 * docs/examples/*.cfg: update to modern standards
5086 * NEWS: update for release
5088 * buildbot/scripts/runner.py (createMaster): remove the
5089 -shutdown.tap stuff now that it isn't necessary
5091 (start): launch buildbot.tap, not buildbot-shutdown.tap
5094 * buildbot/status/mail.py (Domain): shorten class name
5095 (MailNotifier): if lookup= is a string, pass it to Domain()
5096 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5097 (Mail.testBuild2): test the string-to-Domain shortcut
5098 (Mail.testMail): fix test
5101 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5104 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5105 more attributes on load
5106 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5107 to accomodate the whole waterfall page at once, and the thrashing
5108 results in a lot of unnecessary loads
5109 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5110 (BuilderStatus.saveYourself): same
5111 (BuilderStatus.eventGenerator): stop generating on the first missing
5112 build. We assume that saved builds are deleted oldest-first.
5113 (BuildStepStatus.__getstate__): .progress might not exist
5115 * buildbot/changes/changes.py (ChangeMaster): make it
5116 serializable, in $masterdir/changes.pck
5117 (ChangeMaster.stopService): save on shutdown
5118 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5119 * buildbot/test/test_config.py: load Changes before config file
5122 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5123 "Oh my god, you killed the command" header on a separate line
5125 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5126 skip over corrupted build pickles
5127 (BuilderStatus.getFullBuildByNumber): same
5128 (BuilderStatus.eventGenerator): skip over unavailable builds
5129 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5130 do an atomic rename. This prevents a corrupted pickle when some
5131 internal serialization error occurs.
5132 (BuilderStatus.saveYourself): same
5134 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5135 the timeout for shell commands, it got lost somehow
5137 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5138 run out of build steps, return the rest of the builder events
5140 * buildbot/interfaces.py (IBuilderControl.ping): add method
5142 * buildbot/process/builder.py (BuilderControl.ping): move
5143 slave-ping to BuilderControl, and fix the failure case in the
5144 process (Event.finish() is the verb, Event.finished is the noun).
5146 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5147 through the BuilderControl instead of the BuilderStatus
5148 (EventBox): add adapter for builder.Event, allowing builder events to
5149 be displayed in the waterfall display
5151 * buildbot/master.py (BotMaster.stopService): add a 'master
5152 shutdown' event to the builder's log
5153 (BuildMaster.startService): and a 'master started' on startup
5155 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5156 builder events into the BuildStep event stream
5157 (Status.builderAdded): add a 'builder created' event
5160 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5161 command to announce the completion of a running build
5162 (IrcStatusBot.command_FORCE): announce when the build finishes
5164 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5165 don't evict unfinished builds from the cache: they must stay in
5166 the full-cache until their logfiles have stopped changing. Make
5167 sure the eviction loop terminates if an unfinished build was hit.
5168 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5169 This lets exceptions be dumped in an email status message. Really
5170 we need LogFiles which contain both text and HTML, instead of two
5172 (BuildStatus.__getstate__): handle self.finished=False
5173 (Status.builderAdded): if the pickle is corrupted, abandon the
5174 history and create a new BuilderStatus object.
5176 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5177 self.progress attribute, helped one test which doesn't fully set
5178 up the Build object.
5180 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5181 IStatusLog methods into an Interface that is implemented by "stub"
5182 logs, for which all the actual text chunks are on disk (in the
5183 pickled Build instance). To show the log contents, you must first
5184 adapt the stub log to a full IStatusLog object.
5186 * buildbot/status/builder.py (LogFileStub): create separate stub
5187 log objects, which can be upgraded to a real one if necessary.
5188 (LogFile): make them persistable, and let them stubify themselves
5190 (BuildStepStatus): same
5192 (BuildStatus.saveYourself): save the whole build out to disk
5193 (BuilderStatus): make it persistable
5194 (BuilderStatus.saveYourself): save the builder to disk
5195 (BuilderStatus.addFullBuildToCache): implement two caches which
5196 hold Build objects: a small one which holds full Builds, and a
5197 larger one which holds "stubbed" Builds (ones with their LogFiles
5198 turned into LogFileStubs). This reduces memory usage by the
5199 buildmaster by not keeping more than a few (default is 2) whole
5200 build logs in RAM all the time.
5201 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5203 (BuilderStatus.eventGenerator): rewrite since .builds went away
5204 (BuilderStatus.buildStarted): remove the .builds array. Add the
5205 build to the "full" cache when it starts.
5206 (BuilderStatus._buildFinished): save the build to disk when it
5208 (Status): give it a basedir (same as the BuildMaster's basedir)
5209 where the builder pickles can be saved
5210 (Status.builderAdded): create the BuilderStatus ourselves, by
5211 loading a pickle from disk (or creating a new instance if there
5212 was none on disk). Return the BuilderStatus so the master can glue
5213 it into the new Builder object.
5215 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5216 all BuilderStatuses to save themselves out to disk. This is in
5217 lieu of saving anything important in the main Application pickle
5218 (the -shutdown.tap file).
5219 (BuildMaster.__init__): give Status() a basedir for its files
5220 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5221 to get the BuilderStatus, then give it to the Builder (instead of
5222 doing it the other way around). It's ok if the status announces
5223 the new Builder before it's really ready, as the outside world can
5224 only see the BuilderStatus object anyway (and it is ready before
5225 builderAdded returns). Use the builder's "builddir" (which
5226 normally specifies where the slave will run the builder) as the
5227 master's basedir (for saving serialized builds).
5229 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5230 coerce the logfile to IStatusLog before trying to get the text
5231 chunks out of it. This will pull the full (non-stubified) Build in
5232 from disk if necessary.
5233 (TextLog): fix the adapter registration
5235 * buildbot/test/test_control.py (Force.setUp): create the basedir
5236 * buildbot/test/test_web.py: same
5237 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5238 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5239 * buildbot/test/test_run.py (Run.testMaster): same
5240 (Status.setUp): same
5242 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5244 * buildbot/status/html.py (Waterfall.__init__): store actual
5245 allowForce flag passed in rather than using True for everyone;
5246 make sure setting it to False doesn't cause a NameError
5248 (StatusResourceBuilder.__init__) add the builder name to the page
5250 (StatusResourceBuilder.body) move HTML generation for a name/value
5251 row into a helper method (StatusResourceBuilder.make_row); only
5252 generate the "Force Build" form if allowForce was True and the
5253 slave is connected. Use class attributes in the generated HTML to
5254 spread a little CSS-joy.
5256 2004-09-28 Brian Warner <warner@lothar.com>
5258 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5259 warning-scanner to not ignore things like
5260 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5262 * buildbot/status/html.py (StatusResource.control): add some
5263 class-level values for .control in an attempt to make upgrading
5266 * buildbot/util.py (ComparableMixin): survive missing attributes,
5267 such as when a class is modified and we're comparing old instances
5270 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5271 failure handling, remove a redundant try/except block. Don't
5272 return the full traceback to the IRC channel.
5273 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5274 error messages. Get ETA properly.
5276 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5277 the reason, since (at least) IRC message will have <> in them.
5278 (StatusResourceBuilder.__init__): take an IBuilderControl
5279 (StatusResourceBuilder.force): use the IBuilderControl we get in
5280 the constructor instead of trying to make our own. Catch the
5281 new exceptions and ignore them for now (until we make an
5282 intermediate web page where we could show the error message)
5283 (StatusResource): create with an IControl, use it to give an
5284 IBuilderControl to all children
5285 (Waterfall): take an allowForce= option, pass an IControl object
5286 to StatusResource if it is True
5288 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5290 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5291 catch new exceptions and return string forms
5293 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5294 * buildbot/process/builder.py (Builder.forceBuild): raise them
5295 * buildbot/test/test_control.py (Force.testNoSlave): new test
5296 (Force.testBuilderInUse): same
5299 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5301 * buildbot/test/test_run.py: use IControl
5302 * buildbot/test/test_vc.py: same
5304 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5305 to use IControl. Still offline.
5306 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5308 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5309 who=None so periodic builds don't send out status mail
5310 (Builder.forceBuild): include reason in the log message
5311 (BuilderControl.forceBuild): rename 'name' to 'who'
5313 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5314 'who' parameter, but make it None by default so builds forced by
5315 slave admins don't cause status mail to be sent to anybody
5316 (BotMaster.forceBuild): same. this method is deprecated.
5317 (DebugPerspective.perspective_forceBuild): same, use IControl.
5318 (DebugPerspective.perspective_fakeChange): use IControl..
5319 (Dispatcher.requestAvatar): .. so don't set .changemaster
5321 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5322 parameter to avoid confusion with the name of the builder
5325 * buildbot/status/mail.py: refine comment about needing 2.3
5327 * buildbot/status/html.py: move all imports to the top
5329 * buildbot/test/test_control.py: test new interfaces
5330 * buildbot/test/test_run.py (Status): handle new interfaces
5331 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5333 * buildbot/process/base.py (BuildControl): implement IBuildControl
5334 and its lonely getStatus() method
5336 * buildbot/process/builder.py (BuilderControl): implement
5337 IBuilderControl, obtained by adapting the Builder instance
5338 (Builder.startBuild): return a BuilderControl instead of a
5339 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5340 accomplish the same thing.
5342 * buildbot/master.py: move all import statements to the top
5343 (Control): implement IControl, obtained by adapting the
5344 BuildMaster instance.
5346 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5347 IBuildControl. These are used to force builds. Eventually they
5348 will provide ways to reconfigure the Builders, pause or abandon a
5349 Build, and perhaps control the BuildMaster itself.
5351 2004-09-26 Brian Warner <warner@lothar.com>
5353 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5354 ends up comparing us against something without a .__class__
5356 2004-09-24 Brian Warner <warner@lothar.com>
5358 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5361 * Makefile: add 'deb-snapshot' target, to create a timestamped
5364 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5366 2004-09-23 Brian Warner <warner@lothar.com>
5368 * buildbot/__init__.py (version): move version string here
5369 * setup.py: get version string from buildbot.version
5370 * buildbot/status/html.py (WaterfallStatusResource.body): add
5371 buildbot version to the page footer
5372 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5375 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5376 slaves, let the second know where the first one is coming from
5377 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5378 see our exceptions. It would be nice if there were a way to just
5379 send them the exception type and value, not the full traceback.
5382 * buildbot/status/mail.py (MailNotifier): add a new argument
5383 sendToInterestedUsers=, which can be set to False to disable the
5384 usual send-to-blamelist behavior.
5385 (top): handle python-2.2 which has no email.MIMEMultipart
5386 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5387 (MailNotifier.disownServiceParent): unsubscribe on removal
5389 * buildbot/test/test_status.py (Mail.testBuild2): test it
5392 * buildbot/status/progress.py (Expectations.wavg): tolerate
5393 current=None, which happens when steps start failing badly
5394 * buildbot/test/test_status.py (Progress.testWavg): test for it
5396 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5397 doesn't understand args['revision'], emit a warning instead of
5398 bailing completely. Updating to -rHEAD is probably close enough.
5400 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5402 * buildbot/test/test_status.py: at least import bb.status.client
5403 even if we don't have any test coverage for it yet
5405 * contrib/svn_buildbot.py: don't require python2.3
5406 (main): wait, do require it (for sets.py), but explain how to
5407 make it work under python2.2
5409 2004-09-23 Brian Warner <warner@lothar.com>
5411 * contrib/svn_buildbot.py: include the revision number in the Change
5413 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5414 using util.now() because FreshCVS is a realtime service
5416 * buildbot/status/event.py: delete dead code
5417 * buildbot/process/step.py: don't import dead Event class
5418 * buildbot/process/step_twisted.py: same
5419 * buildbot/status/builder.py: same
5420 * buildbot/status/client.py: same
5422 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5424 * buildbot/changes/changes.py (Change): set .when from an __init__
5425 argument (which defaults to now()), rather than having
5426 ChangeMaster.addChange set it later.
5427 (ChangeMaster.addChange): same
5429 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5430 (parseSyncmail): same. Just use util.now() for now.
5431 (parseBonsaiMail): parse the timestamp field for when=
5433 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5434 instead of setting .when after the fact
5438 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5439 results when the target project uses retrial. Still under
5441 * buildbot/test/test_trial.py: same
5443 2004-09-21 Brian Warner <warner@lothar.com>
5445 * buildbot/status/mail.py (MailNotifier.__init__): include
5446 success/warnings/failure in the Subject line
5447 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5448 use step.logname for the addLogs=True attachment filenames
5449 * buildbot/test/test_status.py (Mail): test Subject lines
5450 (Mail.testLogs): test attachment filenames
5452 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5453 accept a 'who' argument from the debug tool
5454 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5455 * contrib/debug.glade: add text box to set 'who'
5457 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5458 .getBuilderName with .getBuilder().getName(), more flexible
5459 (IStatusLog.getName): logs have short names, but you can prefix
5460 them with log.getStep().getName() to make them more useful
5461 * buildbot/status/builder.py: same
5462 * buildbot/status/client.py: same
5463 * buildbot/status/html.py: same
5464 * buildbot/test/test_run.py (Status.testSlave): same
5465 * buildbot/process/step.py: tweak logfile names
5467 * buildbot/status/mail.py (MailNotifier): add lookup, change
5468 argument to extraRecipients. The notifier is now aimed at sending
5469 mail to the people involved in a particular build, with additional
5470 constant recipients as a secondary function.
5472 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5473 including slow-lookup and failing-lookup. Make sure the blamelist
5474 members are included.
5476 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5477 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5478 (IBuildStatus.getInterestedUsers): new method
5479 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5480 * buildbot/status/client.py (remote_getResponsibleUsers): same
5481 * buildbot/status/html.py (StatusResourceBuild.body): same
5482 * buildbot/test/test_run.py (Status.testSlave): same
5484 2004-09-20 Brian Warner <warner@lothar.com>
5486 * docs/users.xhtml: update concepts
5488 * Makefile: add a convenience makefile, for things like 'make
5489 test'. It is not included in the source tarball.
5491 2004-09-16 Brian Warner <warner@lothar.com>
5493 * NEWS: mention /usr/bin/buildbot, debian/*
5495 * debian/*: add preliminary debian packaging. Many thanks to
5496 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5497 it considerably since it left their hands, I am responsible for
5498 all breakage that's resulted.
5500 * bin/buildbot: create a top-level 'buildbot' command, to be
5501 installed in /usr/bin/buildbot . For now it's just a simple
5502 frontend to mktap/twistd/kill, but eventually it will be the entry
5503 point to the 'try' command and also a status client. It is also
5504 intended to support the upcoming debian-packaging init.d scripts.
5505 * buildbot/scripts/runner.py: the real work is done here
5506 * buildbot/scripts/__init__.py: need this too
5507 * buildbot/scripts/sample.cfg: this is installed in new
5508 buildmaster directories
5509 * setup.py: install new stuff
5511 2004-09-15 Brian Warner <warner@lothar.com>
5513 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5514 'file:' schema (the version shipped with OS-X was built without the
5516 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5517 updates the log-timestamp, to make sure it isn't still running after
5520 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5521 values to the config file.
5522 * docs/examples/hello.cfg: add examples
5523 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5524 * buildbot/status/builder.py (Status.getProjectURL): implement them
5525 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5526 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5527 * buildbot/status/html.py (WaterfallStatusResource): display them
5530 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5531 certain error cases don't suffer a secondary exception.
5532 (top): Skip tests if the corresponding VC tool is not installed.
5534 * buildbot/process/factory.py (Trial): introduce separate
5535 'buildpython' and 'trialpython' lists, since trialpython=[] is
5536 what you want to invoke /usr/bin/python, whereas ./setup.py is
5537 less likely to be executable. Add env= parameter to pass options
5538 to test cases (which is how I usually write tests, I don't know if
5539 anyone else does it this way).
5541 * buildbot/process/step_twisted.py (Trial): handle python=None.
5542 Require 'testpath' be a string, not a list. Fix tests= typo.
5543 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5545 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5546 way to deal with the possibility of removing the disconnect notify
5548 (CVS): add a 'login' parameter to give a password to 'cvs login',
5549 commonly used with pserver methods (where pw="" or pw="guest")
5551 * buildbot/slave/commands.py (SourceBase): move common args
5552 extraction and setup() to __init__, so everything is ready by the
5553 time setup() is called
5554 (CVS.start): call 'cvs login' if a password was supplied
5555 (ShellCommand): special-case PYTHONPATH: prepend the master's
5556 value to any existing slave-local value.
5558 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5559 don't have a remote, mark the builder as Offline. This whole
5560 function should probably go away and be replaced by individual
5562 (Builder.buildFinished): return the results to the build-finished
5563 deferred callback, helps with testing
5565 2004-09-14 Brian Warner <warner@lothar.com>
5567 * buildbot/test/test_vc.py: put all the repositories needed to run
5568 the complete tests into a single small (1.3MB) tarball, so I can
5569 make that tarball available on the buildbot web site. Test HTTP
5570 access (for Arch and Darcs) by spawning a temporary web server
5571 while the test runs.
5573 * docs/users.xhtml: new document, describe Buildbot's limited
5574 understanding of different human users
5576 * buildbot/test/test_vc.py: rearrange test cases a bit
5578 * buildbot/process/step_twisted.py (Trial): handle testpath=
5579 * buildbot/process/factory.py (Trial): update to use step.Trial
5581 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5583 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5584 the overall build text (which gives you 'failed 2 tests' rather
5586 (BuildStepStatus.text2): default to [], not None
5588 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5591 2004-09-12 Brian Warner <warner@lothar.com>
5593 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5594 log the whole exception if it's just an AttributeError (old slave)
5596 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5597 so (e.g.) sub-commands can be run in the right directory.
5598 (ShellCommand.start): accept an optional errorMessage= argument
5599 to make life easier for SVN.start
5600 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5602 (ShellCommand.start): move ['dir'] compatibility hack..
5603 (RemoteShellCommand.start): .. to here so everyone can use it
5605 * buildbot/process/step_twisted.py (Trial): use .workdir
5607 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5608 text displayed when debuild fails completely
5609 (Trial): snarf _trial_temp/test.log from the slave and display it
5611 2004-09-11 Brian Warner <warner@lothar.com>
5613 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5615 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5616 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5618 * buildbot/process/step.py (ShellCommand): call .createSummary
5619 before .evaluateCommand instead of the other way around. This
5620 makes it slightly easier to count warnings and then use that to
5621 set results=WARNINGS
5622 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5624 * buildbot/process/base.py (Build.buildFinished): update status
5625 before doing progress. It's embarrassing for the build to be stuck
5626 in the "building" state when an exceptions occurs elsewhere..
5628 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5629 python2.2 doesn't have 'sum'
5631 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5632 to prevent clients from accidentally sorting it
5634 * buildbot/master.py (Manhole): add username/password
5635 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5636 c['manholePort'], deprecate old usage
5637 * docs/config.xhtml: document c['manhole']
5638 * docs/examples/hello.cfg: show example of using a Manhole
5641 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5642 pretend the slave is up to date
5644 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5645 the module, overlaps with 'log', the local variable
5647 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5649 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5650 new method to let Steps find out the version of their
5651 corresponding SlaveCommand.
5652 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5653 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5654 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5656 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5657 (Arch.startVC): same
5658 (P4Sync.startVC): same
5660 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5661 Deferred so we can catch errors in remote_startCommand
5662 (RemoteShellCommand.start): same
5664 * docs/examples/twisted_master.cfg: update sample config file
5666 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5667 after connectionMade() is called, not before. Close stdin at that
5670 * buildbot/process/process_twisted.py: update to use Trial, clean
5671 up argument passing (move to argv arrays instead of string
5674 * buildbot/process/step_twisted.py (Trial): new step to replace
5675 RunUnitTests, usable by any trial-using project (not just
5676 Twisted). Arguments have changed, see the docstring for details.
5678 * buildbot/process/base.py (Build.startBuild): this now returns a
5679 Deferred. Exceptions that occur during setupBuild are now
5680 caught better and lead to fewer build_status weirdnesses, like
5681 finishing a build that was never started.
5682 (Build.buildFinished): fire the Deferred instead of calling
5683 builder.buildFinished directly. The callback argument is this
5684 Build, everything else can be extracted from it, including the
5685 new build.results attribute.
5686 * buildbot/process/builder.py (Builder.startBuild): same
5687 (Builder.buildFinished): same, extract results from build
5689 * buildbot/process/step.py (ShellCommands): remove dead code
5691 2004-09-08 Brian Warner <warner@lothar.com>
5693 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5694 doesn't try to use the leftover patched workdir
5695 (SourceStamp): test source-stamp computation for CVS and SVN
5697 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5698 patched workdir ('touch .buildbot-patched') so we don't try to
5700 (SourceBase.start): add ['revision'] for all Source steps
5701 (CVS): change args: use ['branch'] for -r, remove ['files']
5702 (CVS.buildVC): fix revision/branch stuff
5703 (SVN): add revision stuff
5705 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5706 kwargs (except 'workdir') to avoid silent spelling errors
5707 (ShellCommand.__init__): same
5708 (Source): new base class for CVS/SVN/etc. Factor out everything
5709 common, add revision computation (perform the checkout with a -D
5710 DATE or -r REVISION that gets exactly the sources described by the
5711 last Change), overridable with step.alwaysUseLatest. Add patch
5712 handling (build.getSourceStamp can trigger the use of a base
5713 revision and a patch).
5714 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5715 * docs/steps.xhtml: update docs
5716 * docs/source.xhtml: mention .checkoutDelay
5717 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5719 * buildbot/process/base.py (Build.setSourceStamp): add a
5720 .sourceStamp attribute to each Build. If set, this indicates that
5721 the build should be done with something other than the most
5722 recent source tree. This will be used to implement "try" builds.
5723 (Build.allChanges): new support method
5724 (Build.lastChangeTime): remove, functionality moved to Source steps
5725 (Build.setupBuild): copy the Step args before adding ['workdir'],
5726 to avoid modifying the BuildFactory (and thus triggering spurious
5730 * buildbot/status/html.py: rename s/commits/changes/
5731 (StatusResourceChanges): same
5732 (CommitBox.getBox): same, update URL
5733 (WaterfallStatusResource): same
5734 (StatusResource.getChild): same
5736 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5737 * contrib/debug.glade: add optional 'revision' to the fakeChange
5739 * buildbot/changes/changes.py (html_tmpl): display .revision
5740 (ChangeMaster.addChange): note .revision in log
5741 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5742 accept a ['revision'] attribute
5744 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5746 * buildbot/master.py (BotMaster.getPerspective): update the
5747 .connected flag in SlaveStatus when it connects
5748 (BotMaster.detach): and when it disconnects
5749 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5750 (BuildMaster.loadConfig_Builders): walk old list correctly
5752 * buildbot/test/test_config.py: fix prefix= usage
5754 2004-09-06 Brian Warner <warner@lothar.com>
5758 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5759 poll a P4 depot looking for recent changes. Thanks to Dave
5760 Peticolas for the contribution. Probably needs some testing after
5763 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5764 requires manual client setup for each buildslave. Rather
5765 experimental. Thanks again to Dave Peticolas.
5766 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5768 * buildbot/changes/changes.py (Change): add a .revision attribute,
5769 which will eventually be used to generate source-stamp values.
5771 * buildbot/process/step.py (RemoteCommand.start): use
5772 notifyOnDisconnect to notice when we lose the slave, then treat it
5773 like an exception. This allows LogFiles to be closed and the build
5774 to be wrapped up normally. Be sure to remove the disconnect
5775 notification when the step completes so we don't accumulate a
5776 bazillion such notifications which will fire weeks later (when the
5777 slave finally disconnects normally). Fixes SF#915807, thanks to
5778 spiv (Andrew Bennetts) for the report.
5779 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5780 really isn't Logged- specific
5781 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5782 header, since it's almost always going to be appended to an
5784 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5785 update test to handle use of notifyOnDisconnect
5787 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5788 don't clear .ETA and .currentBuild when going offline, let the
5789 current build clean up after itself
5791 * buildbot/process/builder.py (Builder.detached): wait a moment
5792 before doing things like stopping the current build, because the
5793 current step will probably notice the disconnect and cleanup the
5795 * buildbot/test/test_run.py (Status.tearDown): update test to
5796 handle asynchronous build-detachment
5798 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5800 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5801 hush a debug message
5803 2004-09-05 Brian Warner <warner@lothar.com>
5805 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5806 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5807 kernels do this: the fcntl module has the F_NOTIFY constant, but
5808 the kernel itself doesn't support the operation. Thanks to Olly
5809 Betts for spotting the problem.
5811 * buildbot/process/step.py (Darcs): new source-checkout command
5812 (Arch): new source-checkout command
5813 (todo_P4): fix constructor syntax, still just a placeholder
5814 * buildbot/test/test_vc.py (VC.testDarcs): test it
5815 (VC.testDarcsHTTP): same, via localhost HTTP
5817 (VC.testArchHTTP): same
5818 * NEWS: mention new features
5820 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5821 which tells the step to stash stdout text locally (in .stdout).
5822 Slave-side Commands can use this to make decisions based upon the
5823 output of the the ShellCommand (not just the exit code).
5824 (Darcs): New source-checkout command
5825 (Arch): New source-checkout command, uses .keepStdout in one place
5826 where it needs to discover the archive's default name.
5828 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5829 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5830 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5832 * buildbot/process/step.py (ShellCommand.describe): add an
5833 alternate .descriptionDone attribute which provides descriptive
5834 text when the step is complete. .description can be ["compiling"],
5835 for use while the step is running, then .descriptionDone can be
5836 ["compile"], used alone when the step succeeds or with "failed" when
5837 it does not. Updated other steps to use the new text.
5838 * buildbot/process/step_twisted.py: same
5839 * buildbot/test/test_run.py: update tests to match
5841 2004-08-30 Brian Warner <warner@lothar.com>
5843 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5844 (CVS.__init__): send 'patch' argument to slave
5845 (CVS.start): don't create the LoggedRemoteCommand until start(),
5846 so we can catch a .patch added after __init__
5847 (SVN.__init__): add 'patch' to SVN too
5850 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5851 argument, to let commands push data into the process' stdin pipe.
5852 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5853 is in use, since closing a PTY doesn't really affect the process
5854 in the right way (in particular, I couldn't run /usr/bin/patch
5856 (SourceBase.doPatch): handle 'patch' argument
5858 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5861 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5862 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5864 * buildbot/master.py (BotPerspective.got_commands): get command
5865 versions from slave, give to each builder
5866 * buildbot/process/builder.py (Builder.attached): stash slave
5867 command versions in .remoteCommands
5869 * docs/steps.xhtml: bring docs in-line with reality
5871 * buildbot/process/step.py (CVS.__init__): more brutal
5872 compatibility code removal
5873 (SVN.__init__): same
5875 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5876 (SlaveShellCommand.start): require ['workdir'] argument, remove
5877 the ['dir'] fallback (compatibility will come later)
5878 (SourceBase): update docs
5879 (SourceBase.start): remove ['directory'] fallback
5882 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5883 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5884 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5886 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5887 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5888 code.. I will figure out 0.5.0-compatibility hooks later)
5890 2004-08-30 Brian Warner <warner@lothar.com>
5892 * buildbot/process/process_twisted.py: rewrite in terms of new
5893 BuildFactory base class. It got significantly shorter. Yay
5896 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5897 work with the new "self.build isn't nailed down until we call
5898 step.start()" scheme: specifically, __init__ is called before the
5899 build has decided on which Changes are going in, so we don't scan
5900 build.allFiles() for .xhtml files until start()
5901 (HLint.commandComplete): use getText(), not getStdout()
5902 (RunUnitTests.start): same: don't use .build until start()
5903 (RunUnitTests.describe): oops, don't report (None) when using
5905 (RunUnitTests.commandComplete): use getText()
5906 (RunUnitTests.createSummary): same
5907 (BuildDebs.commandComplete): same
5909 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5910 set args['command'] until start(), since our BuildStep is allowed
5911 to change their mind up until that point
5912 (TreeSize.commandComplete): use getText(), not getStdout()
5914 * docs/examples/twisted_master.cfg: update to current standards
5916 * docs/factories.xhtml: update
5917 * buildbot/process/factory.py: implement all the common factories
5918 described in the docs. The Trial factory doesn't work yet, and
5919 I've probably broken all the process_twisted.py factories in the
5920 process. There are compatibility classes left in for things like
5921 the old BasicBuildFactory, but subclasses of them are unlikely to
5923 * docs/examples/glib_master.cfg: use new BuildFactories
5924 * docs/examples/hello.cfg: same
5926 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5927 explicit 'workdir' args
5929 * buildbot/process/base.py (BuildFactory): move factories to ..
5930 * buildbot/process/factory.py (BuildFactory): .. here
5931 * buildbot/process/process_twisted.py: handle move
5932 * buildbot/test/test_config.py: same
5933 * buildbot/test/test_run.py: same
5934 * buildbot/test/test_steps.py: same
5935 * buildbot/test/test_vc.py: same
5936 * docs/factories.xhtml: same
5938 * NEWS: mention config changes that require updating master.cfg
5940 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5941 argument to all steps that weren't given one already, pointing at
5942 the "build/" directory.
5944 * docs/examples/hello.cfg: remove explicit 'workdir' args
5946 * docs/factories.xhtml: document standard BuildFactory clases,
5947 including a bunch which are have not yet been written
5949 2004-08-29 Brian Warner <warner@lothar.com>
5951 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5952 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5953 buildbot.status.builder so they aren't quite so internal
5954 * buildbot/process/base.py, buildbot/process/builder.py: same
5955 * buildbot/process/maxq.py, buildbot/process/step.py: same
5956 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5957 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5958 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5960 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5961 to handle new getLogs()-returns-list behavior
5962 (StatusResourceBuildStep.getChild): same
5963 (StepBox.getBox): same
5964 (WaterfallStatusResource.phase0): same
5966 * docs/source.xhtml: document how Buildbot uses version-control
5967 systems (output side: how we get source trees)
5968 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5969 systems (input side: how we learn about Changes)
5971 * buildbot/master.py (Manhole): use ComparableMixin
5972 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5973 * buildbot/changes/mail.py (MaildirSource): same
5974 * buildbot/status/client.py (PBListener): same
5975 * buildbot/status/html.py (Waterfall): same
5976 * buildbot/status/words.py (IRC): same
5978 * NEWS: start describing new features
5980 * buildbot/status/mail.py (MailNotifier): finish implementation.
5981 The message body is still a bit sparse.
5982 * buildbot/test/test_status.py (Mail): test it
5984 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5985 and __hash__ methods I wind up adding everywhere. Specifically
5986 intended to support the buildbot config-file update scheme where
5987 we compare, say, the old list of IStatusTargets against the new
5988 one and don't touch something which shows up on both lists.
5989 * buildbot/test/test_util.py (Compare): test case for it
5991 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5992 return a list instead of a dict
5993 (IBuildStepStatus.getLogs): same. The idea is that steps create
5994 logs with vaguely unique names (although their uniqueness is not
5995 guaranteed). Thus a compilation step should create its sole
5996 logfile with the name 'compile', and contribute it to the
5997 BuildStatus. If a step has two logfiles, try to create them with
5998 different names (like 'test.log' and 'test.summary'), and only
5999 contribute the important ones to the overall BuildStatus.
6000 * buildbot/status/builder.py (Event.getLogs): same
6001 (BuildStepStatus): fix default .text and .results
6002 (BuildStepStatus.addLog): switch to list-like .getLogs()
6003 (BuildStepStatus.stepFinished): same
6004 (BuildStatus.text): fix default .text
6005 (BuildStatus.getLogs): temporary hack to return all logs (from all
6006 child BuildStepStatus objects). Needs to be fixed to only report
6007 the significant ones (as contributed by the steps themselves)
6008 * buildbot/test/test_run.py: handle list-like .getLogs()
6009 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6011 2004-08-28 Brian Warner <warner@lothar.com>
6013 * buildbot/process/builder.py (Builder.attached): serialize the
6014 attachment process, so the attach-watcher isn't called until the
6015 slave is really available. Add detached watchers too, which makes
6018 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6020 * buildbot/test/test_swap.py: remove dead code
6022 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6023 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6024 sort of as if the command being run exited with a -1. There may
6025 still be some holes in this scheme.
6026 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6027 -r option appears before the module list
6028 * buildbot/process/step.py (CVS): add 'revision' argument
6030 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6031 when sending updates or stepComplete messages to the master, since
6032 we don't currently care whether they arrive or not. When we revamp
6033 the master/slave protocol to really resume interrupted builds,
6034 this will need revisiting.
6035 (lostRemote): remove spurious print
6037 * buildbot/master.py (BotPerspective.attached): serialize the
6038 new-builder interrogation process, to make testing easier
6039 (BotMaster.waitUntilBuilderDetached): convenience function
6041 * buildbot/status/builder.py (BuilderStatus): prune old builds
6042 (BuildStatus.pruneSteps): .. and steps
6043 (BuildStepStatus.pruneLogs): .. and logs
6044 (BuilderStatus.getBuild): handle missing builds
6045 * buildbot/status/html.py (StatusResourceBuild.body): display build
6046 status in the per-build page
6047 (BuildBox.getBox): color finished builds in the per-build box
6049 2004-08-27 Brian Warner <warner@lothar.com>
6051 * buildbot/status/mail.py (MailNotifier): new notification class,
6054 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6055 variants of a common base class which handles all the mode= logic
6057 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6059 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6061 2004-08-26 Brian Warner <warner@lothar.com>
6063 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6066 * buildbot/test/test_run.py: update to new Logfile interface, new
6067 buildbot.slave modules
6068 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6070 * MANIFEST.in: new sample config file
6071 * docs/examples/hello.cfg: same
6073 * buildbot/process/step_twisted.py: remove dead import
6075 * buildbot/process/step.py (RemoteCommand.run): catch errors
6077 (RemoteCommand.remote_update): ignore updates that arrive after
6079 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6080 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6081 the responsibilities of the subclass's methods
6082 (BuildStep.failed): catch errors during failure processing
6083 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6084 (CVS): move to a mode= argument (described in docstring), rather
6085 than the ungainly clobber=/export=/copydir= combination.
6086 (SVN): add mode= functionality to SVN too
6087 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6089 * buildbot/process/base.py (Build.startNextStep): catch errors
6090 during s.startStep()
6092 * buildbot/clients/base.py: update to new PB client interface.
6093 gtkPanes is still broken
6095 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6096 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6097 * setup.py: add buildbot.slave module
6098 * buildbot/bb_tap.py: handle move
6099 * buildbot/slave/registry.py: place to register commands, w/versions
6100 * buildbot/slave/bot.py: major simplifications
6101 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6102 instead of a fixed table. Eventually this will make the slave more
6103 extensible. Use 'start' method on the command, not .startCommand.
6104 Fix unsafeTracebacks handling (I think).
6105 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6106 helper class with a .start method that returns a Deferred.
6107 SlaveShellCommand is the form reached by the buildmaster. Commands
6108 which use multiple ShellCommands can just chain them as Deferreds,
6109 with some helper methods in Command (_abandonOnFailure and
6110 _checkAbandoned) to bail on rc!=0.
6111 (CVSCommand): prefer new mode= argument
6112 (SVNFetch): add mode= argument
6114 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6115 put a useful reason string on the build
6117 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6118 core functionality into an IStatusLog object
6119 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6120 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6121 (StatusResourceBuild.body): use proper accessor methods
6122 * buildbot/status/client.py (RemoteLog): PB-access goes here
6123 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6124 which delivers log contents too
6125 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6126 * buildbot/status/event.py: remove old Logfile completely
6128 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6129 subscription interface for IStatusLog subscriptions just like all
6130 other the status subscriptions
6131 (IStatusReceiver.logChunk): method called on subscribers
6133 2004-08-24 Brian Warner <warner@lothar.com>
6135 * buildbot/process/builder.py (Builder._pong): oops, ping response
6136 includes a result (the implicit None returned by remote_print).
6137 Accept it so the _pong method handles the response correctly.
6139 2004-08-06 Brian Warner <warner@lothar.com>
6141 * buildbot/test/test_config.py: update IRC, PBListener tests
6143 * buildbot/status/client.py (StatusClientPerspective): total
6144 rewrite to match new IStatus interfaces. New subscription scheme.
6145 There are still a few optimizations to make (sending down extra
6146 information with event messages so the client doesn't have to do a
6147 round trip). The logfile-retrieval code is probably still broken.
6148 Moved the PB service into its own port, you can no longer share a
6149 TCP socket between a PBListener and, say, the slaveport (this
6150 should be fixed eventually).
6151 * buildbot/clients/base.py (Client): revamp to match. still needs
6152 a lot of work, but basic event reporting works fine. gtkPanes is
6155 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6156 instance talks to a single irc server. Threw out all the old
6157 multi-server handling code. Still need to add back in
6158 builder-control (i.e. "force build")
6160 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6161 more random text to the as-yet-unreachable per-step page
6163 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6164 rename to stepETAUpdate
6165 (BuildStatus.subscribe): add build-wide ETA updates
6166 (BuilderStatus.getState): remove more cruft
6167 (BuilderStatus.getCurrentBuild): remove more cruft
6168 (BuilderStatus.buildStarted): really handle tuple-subscription
6169 * buildbot/test/test_run.py (Status.testSlave): handle the
6170 stepETAUpdate rename
6172 * buildbot/master.py (BuildMaster): don't add a default
6173 StatusClientService. Don't add a default IrcStatusFactory. Both
6174 are now added through c['status'] in the config file. c['irc'] is
6175 accepted for backwards compatibility, the only quirk is you cannot
6176 use c['irc'] to specify IRC servers on ports other than 6667.
6178 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6179 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6180 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6181 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6184 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6185 the buildmaster to re-read its config file
6188 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6189 find out the port our server is running on
6190 (WebTest.test_webPathname_port): same
6192 * buildbot/test/test_config.py (testWebPortnum): test it
6193 (testWebPathname): ditto
6195 * docs/config.xhtml: document new c['status'] configuration option
6197 * buildbot/status/html.py (Waterfall): new top-level class which
6198 can be added to c['status']. This creates the Site as well as the
6199 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6200 reachable as .parent, for everything.
6202 * buildbot/master.py (Manhole): make it a normal service Child
6203 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6204 webPathname. It will eventually replace c['irc'] and the implicit
6205 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6206 in as (deprecated) backward compatibility hooks for now.
6209 * buildbot/process/builder.py (Builder.buildFinished): don't
6210 inform out builder_status about a finished build, as it finds out
6211 through its child BuildStatus object
6213 * buildbot/status/html.py: extensive revamp. Use adapters to make
6214 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6215 have both starting and finishing times and adjust the waterfall
6216 display accordingly, using spacers if necessary. Use SlaveStatus
6217 to get buildslave info.
6218 (StatusResourceBuildStep): new just-one-step resource, used to get
6219 logfiles. No actual href to it yet.
6221 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6222 the time being, until I get the file-naming scheme right
6224 * buildbot/status/builder.py (Event): clean started/finished names
6225 (BuildStatus.isFinished): .finished is not None is the right test
6226 (BuildStatus.buildStarted): track started/finished times ourselves
6227 (BuilderStatus.getSlave): provide access to SlaveStatus object
6228 (BuilderStatus.getLastFinishedBuild): all builds are now in
6229 .builds, even the currently-running one. Accomodate this change.
6230 (BuilderStatus.eventGenerator): new per-builder event generator.
6231 Returns BuildStepStatus and BuildStatus objects, since they can
6232 both be adapted as necessary.
6233 (BuilderStatus.addEvent): clean up started/finished attributes
6234 (BuilderStatus.startBuild,finishBuild): remove dead code
6235 (SlaveStatus): new object to provide ISlaveStatus
6237 * buildbot/process/step.py (ShellCommand.getColor): actually
6238 return the color instead of setting it ourselves
6239 (CVS.__init__): pull .timeout and .workdir options out of
6240 **kwargs, since BuildStep will ignore them. Without this neither
6241 will be sent to the slave correctly.
6242 (SVN.__init__): same
6244 * buildbot/process/builder.py (Builder): move flags to class-level
6246 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6247 SlaveStatus handle that
6249 * buildbot/process/base.py (Build.firstEvent): remove dead code
6250 (Build.stopBuild): bugfix
6252 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6254 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6255 (ChangeMaster.eventGenerator): yield Changes, since there are now
6256 Adapters to turn them into HTML boxes
6258 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6259 (BotPerspective.attached): feed a SlaveStatus object
6260 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6261 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6263 * buildbot/interfaces.py: API additions
6264 (ISlaveStatus): place to get slave status
6266 2004-08-04 Brian Warner <warner@lothar.com>
6268 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6269 the delay finishes, so the step is marked as SUCCESS
6271 * buildbot/test/test_run.py (Status.testSlave): cover more of
6272 IBuildStatus and IBuildStepStatus
6274 * buildbot/status/progress.py (StepProgress): move some flags to
6275 class-level attributes
6276 (StepProgress.remaining): if there are no other progress metrics
6277 to go by, fall back to elapsed time
6278 (StepProgress.setExpectations): take a dict of metrics instead of
6280 (BuildProgress.setExpectationsFrom): pull expectations from the
6281 Expectations, instead of having it push them to the BuildProgress
6282 (Expectations): move some flags to class-level attributes
6283 (Expectations.__init__): copy per-step times from the
6285 (Expectations.expectedBuildTime): new method for per-build ETA
6287 * buildbot/status/event.py (Logfile): move some flags to
6288 class-level attributes
6289 (Logfile.logProgressTo): better method name, let step set the
6290 progress axis name (instead of always being "output")
6292 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6293 times directly, rather than depending upon the (possibly missing)
6294 .progress object. Use 'None' to indicate "not started/finished
6296 (BuildStepStatus.getExpectations): oops, return the full list of
6298 (BuilderStatus._buildFinished): append finished builds to .builds
6300 * buildbot/process/step.py (BuildStep): add separate .useProgress
6301 flag, since empty .progressMetrics[] still implies that time is a
6303 (CVS): set up the cmd in __init__, instead of waiting for start()
6305 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6306 calculation, this will eventually turn into a proper sourceStamp
6307 (Build.setupBuild): tell the Progress to load from the Expectations,
6308 instead of having the Expectations stuff things into the Progress
6309 (Build.buildException): add a build-level errback to make sure the
6310 build's Deferred fires even in case of exceptions
6312 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6314 * buildbot/process/builder.py (Builder.forceBuild): convey the
6315 reason instead of creating a fake Change
6317 * docs/examples/twisted_master.cfg: update to match reality
6319 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6320 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6321 fix or remove broken/breaking tests
6323 * buildbot/status/event.py (Logfile.__len__): remove evil method
6325 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6326 missing .build, for test convenience
6328 * buildbot/process/step_twisted.py: import fixes
6330 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6332 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6333 .statusbag reference
6335 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6336 connection at shutdown, and stop it from reconnecting
6338 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6339 chase down remote-execution bugs
6341 * buildbot/process/step.py: more fixes, remove
6342 BuildStep.setStatus()
6343 * buildbot/status/builder.py: move setStatus() functionality into
6345 * buildbot/status/event.py: minor fixes
6347 2004-08-03 Brian Warner <warner@lothar.com>
6349 * buildbot/process/base.py, buildbot/process/builder.py
6350 * buildbot/process/step.py, buildbot/status/builder.py
6351 * buildbot/status/event.py, buildbot/test/test_run.py:
6352 fix status delivery, get a basic test case working
6353 * buildbot/master.py: finish implementing basic status delivery,
6354 temporarily disable HTML/IRC/PB status sources
6356 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6358 * buildbot/status/progress.py (BuildProgress): remove dead code
6360 * buildbot/interfaces.py
6361 * buildbot/process/base.py, buildbot/process/builder.py
6362 * buildbot/process/step.py, buildbot/process/step_twisted.py
6363 * buildbot/status/builder.py: Complete overhaul of the all
6364 status-delivery code, unifying all types of status clients (HTML,
6365 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6366 look like. This commit is a checkpointing of the work-in-progress:
6367 the input side is mostly done (Builders/Builds sending status
6368 to the BuilderStatus/BuildStatus objects), but the output side has
6369 not yet been started (HTML resources querying BuilderStatus
6370 objects). Things are probably very broken right now and may remain
6371 so for several weeks, I apologize for the disruption.
6373 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6374 HTML as the log's contents. Currently used for exception tracebacks.
6375 * buildbot/status/progress.py: minor spelling changes
6377 2004-08-02 Brian Warner <warner@lothar.com>
6379 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6380 in mozilla. Also added stylesheets copied from Twisted's docs.
6381 Remember that these files are meant to be run through Lore first.
6382 Thanks to Philipp Frauenfelder for the fixes.
6383 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6384 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6385 * docs/template.tpl: added a Lore template
6387 2004-07-29 Brian Warner <warner@lothar.com>
6389 * buildbot/interfaces.py: revamp status delivery. This is the
6390 preview: these are the Interfaces that will be provided by new
6391 Builder code, and to which the current HTML/IRC/PB status
6392 displayers will be adapted.
6394 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6395 on the SlaveBuilder, not the Bot.
6396 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6398 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6399 set .usePTY on the FakeSlaveBuilder
6401 2004-07-25 Brian Warner <warner@lothar.com>
6403 * buildbot/changes/freshcvs.py: add some debug log messages
6404 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6405 disabled 'setFilter' syntax
6406 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6407 don't end with a slash
6409 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6411 * setup.py: bump to 0.5.0+ while between releases
6413 2004-07-23 Brian Warner <warner@lothar.com>
6415 * setup.py (version): Releasing buildbot-0.5.0
6417 2004-07-23 Brian Warner <warner@lothar.com>
6419 * README: update for 0.5.0 release
6421 * NEWS: update for 0.5.0 release
6423 2004-07-22 Brian Warner <warner@lothar.com>
6425 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6426 mktap-time configuration flag (--usepty=1, --usepty=0)
6427 * buildbot/bot.py: same
6429 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6430 an 'info' directory being unwanted
6432 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6433 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6434 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6435 and earlier), use a FreshCVSSourceOldcred instead.
6436 (test): simple test routine: connect to server, print changes
6438 * buildbot/changes/changes.py (Change.getTime): make it possible
6439 to print un-timestamped changes
6441 * buildbot/master.py (makeApp): delete ancient dead code
6442 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6443 * buildbot/test/test_config.py (testFindConfigFile): test it
6445 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6446 instead of win32 one
6449 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6450 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6453 * buildbot/process/base.py (Builder.__init__): change constructor
6454 to accept a dictionary of config data, rather than discrete
6455 name/slave/builddir/factory arguments
6457 * docs/examples/twisted_master.cfg: update to new syntax
6458 * docs/examples/glib_master.cfg: same
6459 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6460 rough tests of the new syntax
6463 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6464 to be an int, which means "run a web.distrib sub-server on a TCP
6465 port". This lets you publish the buildbot status page to a remote
6466 twisted.web server (using distrib.ResourceSubscription). Also
6467 rename the local attributes used to hold these web things so
6468 they're more in touch with reality.
6469 * buildbot/test/test_web.py: test webPortnum and webPathname
6470 * docs/config.xhtml: document this new use of webPathname
6472 * docs/config.xhtml: new document, slightly ahead of reality
6474 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6475 'prefix' handling: treat it as a simple string to check with
6476 .startswith, instead of treating it as a directory. This allows
6477 sub-directories to be used. If you use prefix=, you should give it
6478 a string that starts just below the CVSROOT and ends with a slash.
6479 This prefix will be stripped from all filenames, and filenames
6480 which do not start with it will be ignored.
6482 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6484 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6485 and --exclude (inverse of --include). SVN post-commit hooks
6486 now have total control over which changes get sent to buildbot and which
6489 2004-07-10 Brian Warner <warner@lothar.com>
6491 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6492 test case to match new API
6494 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6495 which crashed HTML display when self.entries=[] (needed to
6496 distinguish between [], which means "no entries yet", and None,
6497 which means "the entries have been swapped out to disk, go fetch
6500 2004-07-04 Brian Warner <warner@lothar.com>
6502 * buildbot/process/step_twisted.py (countFailedTests): Count
6503 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6504 10kb from the end because any import errors are wedged there and
6505 they would make us think the test log was unparseable.
6506 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6508 2004-06-26 Brian Warner <warner@lothar.com>
6510 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6511 delete-*.pyc command into an actual BuildStep, so we can label it
6513 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6514 (FullTwistedBuildFactory): same
6516 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6518 * contrib/fakechange.py: Add an errback when sending the fake
6519 change, so we know it didn't work.
6521 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6523 * buildbot/process/step_twisted.py: Delete *.pyc files before
6524 calling trial, so it doesn't catch any old .pyc files whose .py
6525 files have been moved or deleted.
6527 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6528 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6529 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6530 instead of ["twisted.test"], so that the end result is "trial -R
6533 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6534 regular expression to match filenames that should be ignored when
6535 changed. Also add a --revision parameter that specifies the
6536 revision to examine, which is useful for debugging.
6538 2004-06-25 Brian Warner <warner@lothar.com>
6540 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6541 summary of warnings (like DeprecationWarnings), next to the
6544 2004-05-13 Brian Warner <warner@lothar.com>
6546 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6547 we now have a w32 build slave courtesy of Mike Taylor.
6549 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6550 so broken. Fixed a race condition that tripped up interlocked
6551 builds and caused the status to be stuck at "Interlocked" forever.
6552 The twisted buildbot's one interlocked build just so happened to
6553 never hit this case until recently (the feeding builds both pass
6554 before the interlocked build is attempted.. usually it has to wait
6556 (Builder._pong_failed): fix method signature
6558 * setup.py: bump to 0.4.3+ while between releases
6560 2004-04-30 Brian Warner <warner@lothar.com>
6562 * setup.py (version): Releasing buildbot-0.4.3
6564 2004-04-30 Brian Warner <warner@lothar.com>
6566 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6568 * README: update for 0.4.3 release
6570 * NEWS: update for 0.4.3 release
6572 * buildbot/master.py (BuildMaster.__getstate__): make sure
6573 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6575 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6576 .trial as a class attribute, for upgrade from 0.4.2
6578 * buildbot/changes/changes.py (Change.links): add .links for
6581 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6582 .textWatchers and .htmlWatchers at save time, since they are both
6583 volatile, should allow smooth 0.4.2 upgrade
6585 * buildbot/process/step.py (CVS.finishStatus): catch failed
6586 CVS/SVN commands so we can make the status box red
6588 2004-04-29 Brian Warner <warner@lothar.com>
6590 * buildbot/changes/freshcvs.py
6591 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6592 code to do setFilter(), which tells the freshcvs daemon to not
6593 send us stuff that we're not interested in. I will uncomment it
6594 when a new version of CVSToys is available in which setFilter()
6595 actually works, and I get a chance to test it better.
6597 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6599 * buildbot/master.py (Dispatcher): use a registration scheme
6600 instead of hardwired service names
6601 (BuildMaster): keep track of the Dispatcher to support
6604 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6605 PBChangeSource class instead of having it be an undocumented
6606 internal feature of the ChangeMaster. Split out the code into a
6608 * buildbot/changes/pb.py (PBChangeSource): same
6609 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6611 * docs/{factories|sources|steps}.xhtml: document some pieces
6613 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6614 using FCMaildirSource
6615 (f23osx): update OS-X builder to use python2.3, since the slave
6616 was updated to Panther (10.3.3)
6618 2004-03-21 Brian Warner <warner@lothar.com>
6620 * buildbot/process/process_twisted.py: factor out doCheckout, change
6621 to use SVN instead of CVS
6623 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6624 an SVN subclass easier
6625 (BasicSVN): subclass which uses Subversion instead of CVS
6627 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6629 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6631 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6633 2004-02-25 Brian Warner <warner@lothar.com>
6635 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6636 is now either a list (which is passed to spawnProcess directly) or
6637 a string (which gets passed to /bin/sh -c). This removes the useSH
6638 flag and the ArgslistCommand class. Also send status header at the
6639 start and end of each command, instead of having the master-side
6641 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6642 -r'. Update to use list-based arguments.
6643 (SVNFetch): use list-based arguments, use ['dir'] argument to
6645 * buildbot/test/test_steps.py (Commands): match changes
6647 * buildbot/process/step.py (InternalShellCommand.words): handle
6649 (SVN): inherit from CVS, cleanup
6651 * buildbot/status/event.py (Logfile.content): render in HTML, with
6652 stderr in red and headers (like the name of the command we're
6653 about to run) in blue. Add link to a second URL (url + "?text=1")
6654 to get just stdout/stderr in text/plain without markup. There is
6655 still a problem with .entries=None causing a crash, it seems to occur
6656 when the logfile is read before it is finished.
6658 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6659 timeout to the keepalives, and use it to explicitly do a
6660 loseConnection instead of waiting for TCP to notice the loss. This
6661 ought to clear up the silent-lossage problem.
6662 (unsafeTracebacks): pass exception tracebacks back to the master,
6663 makes it much easier to debug problems
6665 2004-02-23 Brian Warner <warner@lothar.com>
6667 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6668 the whole command to /bin/sh instead of execve [Johan Dahlin]
6669 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6670 '-r HEAD' [Johan Dahlin]
6671 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6673 * buildbot/changes/changes.py (Change): add links= argument, add
6674 asHTML method [Johan Dahlin]. Modified to make a bit more
6675 XHTMLish. Still not sure how to best use links= .
6677 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6678 Change.asHTML to display the change, not asText
6680 * buildbot/status/html.py (StatusResourceBuilder): web button to
6683 * buildbot/test/test_run.py: test to actually start a buildmaster
6686 * MANIFEST.in: bring back accidentally-dropped test helper files
6688 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6689 that require cvstoys if it is not installed
6691 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6692 values of "bin/trial" [Dave Peticolas]
6693 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6694 tests passed" when we didn't happen to run any tests
6696 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6697 flunkOnFailure [Johan Dahlin]
6699 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6700 multiple instances of the same Step class by suffixing "_2", etc,
6701 to the name until it is unique. This name needs to be unique
6702 because it is used as a key in the dictionary that tracks build
6704 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6707 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6709 2004-01-14 Brian Warner <warner@lothar.com>
6711 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6712 kicked from a channel, log it
6714 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6715 something over whatever IRC channels the buildmaster is currently
6716 connected to. Added to try and track down a problem in which the
6717 master thinks it is still connected but the IRCd doesn't see it. I
6718 used a styles.Versioned this time, so hopefully users won't have
6719 to rebuild their .tap files this time.
6720 * contrib/debug.glade: add a "Poke IRC" button
6721 * contrib/debugclient.py: same
6723 * setup.py: bump to 0.4.2+ while between releases
6725 2004-01-08 Brian Warner <warner@lothar.com>
6727 * setup.py (version): Releasing buildbot-0.4.2
6729 2004-01-08 Brian Warner <warner@lothar.com>
6731 * NEWS: update for 0.4.2 release
6733 * README: document how to run the tests, now that they all pass
6735 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6737 * buildbot/process/step.py (CVS): add a global_options= argument,
6738 which lets you set CVS global options for the command like "-r"
6739 for read-only checkout, or "-R" to avoid writing in the
6741 * buildbot/slavecommand.py (CVSCommand): same
6743 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6744 testing easier (it is turned off when testing, to avoid the
6747 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6748 to make it easier to test: break generateStepID() out to a
6749 separate function, only update statusbag if it exists.
6750 (ShellCommands): create useful text for dict-based commands too.
6752 * test/*, buildbot/test/*: move unit tests under the buildbot/
6754 * setup.py (packages): install buildbot.test too
6756 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6757 * buildbot/test/test_steps.py: fix it, tests pass now
6759 2004-01-06 Brian Warner <warner@lothar.com>
6761 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6762 freshcvs mail uses a slightly different syntax for new
6763 directories. Update parser to handle either.
6764 * test/test_mailparse.py (Test1.testMsg9): test for same
6766 2003-12-21 Brian Warner <warner@lothar.com>
6768 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6769 'warnOnWarnings' so that lintian errors mark the build orange
6771 2003-12-17 Brian Warner <warner@lothar.com>
6773 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6774 messages emitted by Bonsai, contributed by Stephen Davis.
6776 * test/*: moved all tests to use trial instead of unittest. Some
6777 still fail (test_steps, test_slavecommand, and test_process).
6779 * setup.py (version): bump to 0.4.1+ while between releases
6781 2003-12-09 Brian Warner <warner@lothar.com>
6783 * setup.py (version): Releasing buildbot-0.4.1
6785 2003-12-09 Brian Warner <warner@lothar.com>
6787 * NEWS: update for 0.4.1 release
6789 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6790 freebsd builder code a little bit
6792 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6793 don't try to compare attributes of different classes
6794 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6795 (MaildirSource.messageReceived): fix Change delivery
6797 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6798 into the config file's namespace before loading it, like the
6799 documentation claims it does
6800 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6801 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6802 daemon comes back online
6804 2003-12-08 Brian Warner <warner@lothar.com>
6806 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6807 so the example will work with online=0 as well
6809 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6810 fix the __implements__ line
6812 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6813 class a twisted.application.service.Service, use startService to
6816 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6817 directory fd instead of simple open(). I'm sure this used to work,
6818 but the current version of python refuses to open directories with
6821 2003-12-05 Brian Warner <warner@lothar.com>
6823 * setup.py (version): bump to 0.4.0+ while between releases
6825 2003-12-05 Brian Warner <warner@lothar.com>
6827 * setup.py (version): Releasing buildbot-0.4.0
6829 2003-12-05 Brian Warner <warner@lothar.com>
6831 * docs/examples/glib_master.cfg: replace old sample scripts with
6832 new-style config files
6833 * MANIFEST.in: include .cfg files in distribution tarball
6835 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6836 implement a dummy method to avoid the exception that occurs when
6837 freshcvs sends this to us.
6839 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6840 removed the method, as it broke reconnection. Apparently
6841 stopFactory is called each time the connection attempt fails. Must
6843 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6844 attribute before serialization, since without stopFactory the
6845 reconnect timer may still be active and they aren't serializable.
6847 * test/test_mailparse.py (ParseTest): test with 'self' argument
6849 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6850 argument, as these "functions" are invoked like methods from class
6851 attributes and therefore always get an instance as the first
6854 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6855 message: thanks to Stephen Davis for the catch
6857 2003-12-04 Brian Warner <warner@lothar.com>
6859 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6860 twisted's standard ReconnectingClientFactory. Handles both oldcred
6861 and newcred connections. Also has a bug-workaround for
6862 ReconnectingClientFactory serializing its connector when it
6865 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6866 pbutil. Replace makeApp stuff with proper newcred/mktap
6867 makeService(). Don't serialize Ephemerals on shutdown.
6869 * buildbot/changes/changes.py (ChangeMaster): make it a
6870 MultiService and add the sources as children, to get startService
6871 and stopService for free. This also gets rid of the .running flag.
6873 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6874 new pbutil, turn into a TCPClient at the same time (to get
6875 startService for free). Two variants exist: FreshCVSSourceOldcred
6876 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6877 yet, but when it does, we'll be ready).
6878 (FreshCVSSource.notify): handle paths which are empty after the
6879 prefix is stripped. This only happens when the top-level (prefix)
6880 directory is added, at the very beginning of a Repository's life.
6882 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6883 Now the only reconnecting code is in the factory where it belongs.
6884 (Builder.unsubscribe): unregister the disconnect callback when we
6885 delete the builder on command from the master (i.e. when the
6886 buildmaster is reconfigured and that builder goes away). This
6887 fixes a multiple-delete exception when the status client is shut
6889 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6892 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6893 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6895 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6897 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6898 a list of globs (ugh). The testdir will be searched for files
6899 named *.tests and run the tests in the order specified in each of
6900 those files. This allows for "dependancies" between tests to be
6903 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6904 argument to pass to run_maxq.py, instead of a glob.
6906 2003-10-17 Brian Warner <warner@lothar.com>
6908 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6909 files that live in the sandbox
6911 2003-10-15 Brian Warner <warner@lothar.com>
6913 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6914 spelling error in "docs" count-warnings output
6915 (HLint.start): stupid thinko meant .xhtml files were ignored
6917 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6918 tests now that cReactor is banished to the sandbox
6920 2003-10-10 Brian Warner <warner@lothar.com>
6922 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6923 scheme: now .xhtml are sources and .html are generated
6925 2003-10-08 Brian Warner <warner@lothar.com>
6927 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6928 we were ignoring the 'randomly' parameter.
6930 2003-10-01 Brian Warner <warner@lothar.com>
6932 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6933 posix, to kill sub-children of aborted slavecommands.
6935 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6936 Clean up initialization: lastBuildStatus remains None until the
6937 first build has been completed.
6939 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6940 None as a lastBuildStatus
6941 * buildbot/clients/gtkPanes.py: same
6943 * buildbot/status/client.py (StatusClientService): keep
6944 BuilderStatus objects in self.statusbags . These objects now live
6945 here in the StatusClientService and are referenced by the Builder
6946 object, rather than the other way around.
6947 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6948 * buildbot/process/base.py (Builder): same
6949 * test/test_config.py (ConfigTest.testBuilders): same
6951 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6952 an existing builder, leave the statusbag alone. This will preserve the
6955 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6956 hook. This will probably go away in favor of a class in upcoming
6959 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6960 serviceName from newcred FreshCVSNotifiee setup
6962 2003-09-29 Brian Warner <warner@lothar.com>
6964 * buildbot/process/process_twisted.py: switch to new reactor
6966 * docs/examples/twisted_master.cfg: same
6968 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6970 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6971 botmaster reference instead of the oldapp service lookup
6973 * buildbot/master.py (BuildMaster.__init__): give the
6974 StatusClientService a reference to the botmaster to make it easier to
6977 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6979 * buildbot/status/html.py (Box.td): escape hreffy things so you
6980 can have spaces in things like builder names
6981 (StatusResourceBuilder.body)
6982 (WaterfallStatusResource.body)
6983 (WaterfallStatusResource.body0): same
6985 2003-09-25 Brian Warner <warner@lothar.com>
6987 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6988 rearrange the builder list when adding or removing builders: keep
6989 them in the order the user requested.
6990 * test/test_config.py (ConfigTest.testBuilders): verify it
6992 * contrib/debug.glade: give the debug window a name
6994 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6995 now wait on multiple interlocks. Fix code relating to that.
6996 (Builder.checkInterlocks): same
6997 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6999 * buildbot/master.py (BuildMaster.loadConfig): move from
7000 deprecated pb.BrokerFactory to new pb.PBServerFactory
7001 * test/test_config.py (ConfigTest.testWebPathname): same
7003 * docs/examples/twisted_master.cfg: fix interlock declaration
7005 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7006 Interlocks to their Builders into interlock.py .
7007 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7009 * test/test_config.py (ConfigTest.testInterlocks): validate
7012 * buildbot/process/base.py (Builder.__init__): better comments
7013 * buildbot/process/interlock.py (Interlock.__repr__): same
7014 (Interlock.deactivate): add .active flag, move the code that
7015 attaches/detaches builders into the Interlock
7017 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7019 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7020 tests using the new run_maxq.py script, and reporting failures by
7023 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7024 tests, reporting their success or failure in a buildbot-friendly
7027 2003-09-24 Brian Warner <warner@lothar.com>
7029 * docs/examples/twisted_master.cfg: example of a new-style config
7030 file. This lives in the buildmaster base directory as
7033 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7034 button to make the master re-read its config file
7036 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7037 buildmaster configuration from a file. This file can be re-read
7038 later, and the buildmaster will update itself to match the new
7039 desired configuration. Also use new Twisted Application class.
7040 * test/Makefile, test/test_config.py: unit tests for same
7042 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7043 FreshCVSSources comparable, to support reload.
7044 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7046 * buildbot/process/base.py (Builder): make them comparable, make
7047 Interlocks easier to attach, to support reload. Handle
7048 re-attachment of remote slaves.
7049 * buildbot/process/interlock.py (Interlock): same
7051 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7052 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7053 buildmaster taps are now constructed with mktap.
7054 * buildbot/status/client.py (StatusClientService): same
7056 * buildbot/status/words.py: move to new Services, add support to
7057 connect to multiple networks, add reload support, allow nickname
7058 to be configured on a per-network basis
7060 2003-09-20 Brian Warner <warner@lothar.com>
7062 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7063 the freebsd builder, now that the machine has been upgraded and no
7064 longer has python2.2
7066 * setup.py (version): bump to 0.3.5+ while between releases
7068 2003-09-19 Brian Warner <warner@lothar.com>
7070 * setup.py (version): Releasing buildbot-0.3.5
7072 2003-09-19 Brian Warner <warner@lothar.com>
7074 * NEWS: add post-0.3.4 notes
7076 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7078 * MANIFEST.in: add contrib/*
7080 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7081 use a remote root now: cvs.twistedmatrix.com
7083 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7085 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7086 compatibility with old servers
7087 (FreshCVSSource.start): and provide a way to use it
7088 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7090 * docs/examples/twisted_master.py (twisted_app): update to new
7092 (twisted_app): listen on new ~buildbot socket
7093 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7095 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7096 to reduce cvs bandwidth (update instead of full checkout)
7098 2003-09-11 Brian Warner <warner@lothar.com>
7100 * contrib/fakechange.py: demo how to connect to the changemaster
7101 port. You can use this technique to submit changes to the
7102 buildmaster from source control systems that offer a hook to run a
7103 script when changes are committed.
7105 * contrib/debugclient.py: tool to connect to the debug port. You
7106 can use it to force builds, submit fake changes, and wiggle the
7109 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7110 'Dispatcher' realm to handle all the different kinds of
7111 connections and Perspectives: buildslaves, the changemaster port,
7112 the debug port, and the status client port. NewCredPerspectives
7113 now have .attached/.detached methods called with the remote 'mind'
7114 reference, much like old perspectives did. All the pb.Services
7115 turned into ordinary app.ApplicationServices .
7116 (DebugService): went away, DebugPerspectives are now created
7117 directly by the Dispatcher.
7118 (makeApp): changed interface a little bit
7120 * buildbot/changes/changes.py: newcred
7121 * buildbot/status/client.py: newcred
7123 * buildbot/clients/base.py: newcred client side changes
7124 * buildbot/bot.py: ditto
7126 * docs/examples/glib_master.py: handle new makeApp() interface
7127 * docs/examples/twisted_master.py: ditto
7129 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7130 base newcred Perspectives on. This should go away once Twisted
7131 itself provides something sensible.
7134 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7136 * contrib/svn_buildbot.py: A program that you can call from your
7137 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7138 when a change in an SVN repository has happened. See the top of
7139 the file for some minimal usage info.
7141 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7143 * buildbot/slavecommand.py (ArglistCommand): Add new
7144 ArglistCommand that takes an argument list rather than a string as
7145 a parameter. Using a st.split() for argv is very bad.
7147 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7148 update to a particular revision rather than always checking out
7149 (still not very smart about it, there may be cases where the
7150 checkout becomes inconsistent).
7152 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7154 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7155 SVN fetch support. It can checkout (not update!) a specified
7156 revision from a specified repository to a specified directory.
7158 * buildbot/status/progress.py (Expectations.update): Fix an
7159 obvious bug (apparently created by the change described in the
7160 previous ChangeLog message) by moving a check to *after* the
7161 variable it checks is defined.
7164 2003-09-08 Brian Warner <warner@lothar.com>
7166 * buildbot/status/progress.py (Expectations.update): hack to catch
7167 an exception TTimo sees: sometimes the update() method seems to
7168 get called before the step has actually finished, so the .stopTime
7169 is not set, so no totalTime() is available and we average None
7170 with the previous value. Catch this and just don't update the
7171 metrics, and emit a log message.
7173 2003-08-24 Brian Warner <warner@lothar.com>
7175 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7176 parameter to set copydir='original' in CVS commands.
7178 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7180 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7181 which tells the command to maintain a separate original-source CVS
7182 workspace. For each build, this workspace will be updated, then
7183 the tree copied into a new workdir. This reduces CVS bandwidth
7184 (from a full checkout to a mere update) while doubling the local
7185 disk usage (to keep two copies of the tree).
7187 2003-08-21 Brian Warner <warner@lothar.com>
7189 * buildbot/status/event.py (Logfile.addEntry): if the master web
7190 server dies while we're serving a page, request.write raises
7191 pb.DeadReferenceError . Catch this and treat it like a
7192 notifyFinish event by dropping the request.
7194 2003-08-18 Brian Warner <warner@lothar.com>
7196 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7197 (instead of blowing up) if a force-build command is given without
7200 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7201 don't blow up if there aren't yet any Changes in the list
7203 2003-08-02 Brian Warner <warner@lothar.com>
7205 * buildbot/bot.py (updateApplication): don't set the .tap name,
7206 since we shouldn't assume we own the whole .tap file
7208 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7209 'mktap buildbot' (without a subcommand) better
7211 2003-07-29 Brian Warner <warner@lothar.com>
7213 * buildbot/status/words.py
7214 (IrcStatusFactory.clientConnectionLost): when we lose the
7215 connection to the IRC server, schedule a reconnection attempt.
7217 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7218 use shutil.rmtree instead of forking off an "rm -rf" command.
7219 rmtree may take a while and will block until it finishes, so we
7220 use "rm -rf" if available.
7222 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7223 freebsd buildslave badly
7225 * setup.py (version): bump to 0.3.4+ while between releases
7227 2003-07-28 Brian Warner <warner@lothar.com>
7229 * setup.py (version): Releasing buildbot-0.3.4
7231 2003-07-28 Brian Warner <warner@lothar.com>
7233 * NEWS: update in preparation for release
7235 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7236 process.signalProcess instead of os.kill, to improve w32
7239 * docs/examples/twisted_master.py (twisted_app): turn off
7240 win32eventreactor: the tests hang the buildslave badly
7242 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7243 failed builds, since usually the failures are consistent
7245 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7246 add compileOpts/compileOpts2 to reactors build
7248 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7249 (twisted_app): use both default and win32eventreactor on w32 build.
7250 Use both default and kqreactor on freebsd build.
7252 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7253 add compileOpts2, which is put after the build_ext argument. w32
7254 needs "-c mingw32" here.
7256 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7257 touch .acqpath, it goes away in recent Twisted releases
7259 * docs/examples/twisted_master.py (twisted_app): use "python" for
7260 the w32 buildslave, not "python2.2"
7262 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7263 the directory exists.. should hush an exception under w32
7265 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7266 ProcessTerminated -provided values for signal and exitCode rather
7267 than parsing the unix status code directly. This should remove one
7268 more roadblock for a w32-hosted buildslave.
7270 * test/test_mailparse.py: add test cases for Syncmail parser
7272 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7273 temporary compatibility import. Note! Start importing
7274 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7276 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7278 2003-07-27 Brian Warner <warner@lothar.com>
7280 * NEWS: started adding new features
7282 * buildbot/changes/mail.py: start work on Syncmail parser, move
7283 mail sources into their own file
7285 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7286 as implementing IChangeSource
7287 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7289 * buildbot/interfaces.py: define the IChangeSource interface
7291 2003-07-26 Brian Warner <warner@lothar.com>
7293 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7295 2003-06-25 Brian Warner <warner@lothar.com>
7297 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7300 2003-06-17 Brian Warner <warner@lothar.com>
7302 * buildbot/status/words.py: clean up method usage to avoid error
7303 in silly IRC command
7304 (IrcStatusBot.emit_status): round off seconds display
7306 * buildbot/process/base.py (Build): delete the timer when saving
7307 to the .tap file, and restore it (if it should still be running)
7308 upon restore. This should fix the "next build in -34 seconds"
7309 messages that result when the master is restarted while builds are
7310 sitting in the .waiting slot. If the time for the build has
7311 already passed, start it very soon (in 1 second).
7313 * buildbot/status/words.py: more silly commands
7315 * README (REQUIREMENTS): add URLs to all required software
7317 * buildbot/status/words.py ('last'): mention results of, and time
7320 2003-05-28 Brian Warner <warner@lothar.com>
7322 * buildbot/status/words.py: add 'last' command
7323 (IrcStatusBot.emit_status): add current-small text to 'status' output
7325 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7326 (twisted_app): remove spaces from OS-X builder name
7328 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7329 * buildbot/status/words.py: IRC bot should actually be useful now
7331 2003-05-23 Brian Warner <warner@lothar.com>
7333 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7334 "slave information" from $(slavedir)/info/* . These files are
7335 maintained by the slave administrator, and describe the
7336 machine/environment that is hosting the slave. Information from
7337 them is put into the "Builder" HTML page. Still need to establish
7338 a set of well-known filenames and meanings for this data: at the
7339 moment, *all* info/* files are sent to the master, but only
7340 'admin' and 'host' are used on that end.
7341 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7342 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7343 * buildbot/master.py (BotPerspective.got_info): ditto
7345 2003-05-22 Brian Warner <warner@lothar.com>
7347 * setup.py (version): bump version to 0.3.3+ while between releases
7349 2003-05-21 Brian Warner <warner@lothar.com>
7351 * setup.py: Releasing buildbot-0.3.3
7353 2003-05-21 Brian Warner <warner@lothar.com>
7355 * NEWS: 0.3.3 news items
7357 * README: describe --keepalive and life behind a NAT box
7359 * buildbot/bot.py (Bot.connected): implement application-level
7360 keepalives to deal with NAT timeouts, turn them on with
7361 --keepalive option or when SO_KEEPALIVE doesn't work.
7363 * buildbot/master.py (BotPerspective): accept keepalives silently
7365 * buildbot/process/base.py (Build.buildException): CopiedFailures
7366 don't carry as much information as local ones, so don't try to
7367 create a big HTMLized version of them.
7369 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7370 log file when step fails due to an exception, such as when the slave
7373 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7374 --testmodule argument instead of grepping for test-case-name tags
7375 ourselves. Remove FindUnitTests code.
7376 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7378 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7380 2003-05-16 Brian Warner <warner@lothar.com>
7382 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7383 argument to allow things like CFLAGS=-O0 to be passed without relying
7384 upon /bin/sh processing on the slave.
7386 * buildbot/process/step.py (InternalShellCommand.start): send
7388 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7389 'split' instead of letting /bin/sh do it. This should also remove
7390 the need for /bin/sh on the buildslave, making it more likely to
7393 * buildbot/status/html.py: html-escape text in blamelist.
7394 Add "force build" button to the Builder page.
7396 * buildbot/process/step_twisted.py (countFailedTests): look at
7397 last 1000 characters for status line, as import errors can put it
7398 before the -200 point.
7400 2003-05-15 Brian Warner <warner@lothar.com>
7402 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7404 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7405 make 'clobber' a parameter, so it is possible to have builds which
7406 do full tests but do a cvs update instead of hammering the CVS
7407 server with a full checkout each build
7409 * buildbot/process/step.py (InternalShellCommand): bump default
7410 timeout to 20 minutes
7412 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7413 the master to trigger a build. Run it via manhole.
7415 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7416 allow slaves to trigger any build that they host, to make life
7417 easier for slave admins who are testing out new build processes
7419 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7420 don't flunk cReactor or qtreactor on failure, since they fail alot
7421 these days. Do warnOnFailure instead.
7423 * buildbot/process/base.py: change Builder.buildable from a list
7424 into a single slot. When we don't have a slave, new builds (once
7425 they make it past the timeout) are now merged into an existing
7426 buildable one instead of being queued. With this change, a slave
7427 which has been away for a while doesn't get pounded with all the
7428 builds it missed, but instead just does a single build.
7430 2003-05-07 Brian Warner <warner@lothar.com>
7432 * setup.py (version): bump version to 0.3.2+ while between releases
7434 2003-05-07 Brian Warner <warner@lothar.com>
7436 * setup.py: Releasing buildbot-0.3.2
7438 2003-05-07 Brian Warner <warner@lothar.com>
7440 * setup.py: fix major packaging error: include subdirectories!
7442 * NEWS: add changes since last release
7444 * README (REQUIREMENTS): update twisted/python dependencies
7446 * buildbot/status/builder.py (Builder.startBuild): change
7447 BuildProcess API: now they should call startBuild/finishBuild
7448 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7449 keeping a list of builds in the statusbag, to support other kinds of
7451 (Builder.addClient): send current-activity-small to new clients
7452 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7455 * buildbot/status/client.py: drop RemoteReferences at shutdown
7457 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7459 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7460 more debug messages for remote status client
7462 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7463 (.stepFailed): only fire the Deferred once, even if both
7464 stepComplete and stepFailed are called. I think this can happen if
7465 an exception occurs at a weird time.
7467 * buildbot/status/words.py: work-in-progress: IRC status delivery
7469 2003-05-05 Brian Warner <warner@lothar.com>
7471 * docs/examples/twisted_master.py (twisted_app): hush internal
7472 python2.3 distutils deprecation warnings
7473 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7474 add compileOpts= argument which inserts extra args before the
7475 "setup.py build_ext" command. This can be used to give -Wignore
7476 warnings, to hush some internal python-2.3 deprecation messages.
7478 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7479 the ['twisted.test'] default test case to make it easier to change
7482 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7483 * buildbot/clients/gtkPanes.py: ditto
7485 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7486 arg to collapse RunUnitTestsRandomly into RunUnitTests
7487 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7488 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7490 * buildbot/status/html.py (StatusResource): shuffle Resources
7491 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7492 would serve the waterfall display, but the internal links were
7493 only valid on the trailing-slash version. The correct behavior is
7494 for the non-slashed one to serve a Redirect to the slashed one.
7495 This only shows up when the buildbot page is hanging off another
7496 server, like a Twisted-Web distributed server.
7498 * buildbot/status/event.py (Event, RemoteEvent): make Events
7499 pb.Cacheable, with RemoteEvent as the cached version. This removes
7500 a lot of explicit send-an-update code.
7501 * buildbot/status/builder.py (Builder): remove send-update code
7502 * buildbot/status/client.py (ClientBuilder): remove send-update
7503 code, and log errors that occur during callRemote (mostly to catch
7504 InsecureJelly exceptions)
7506 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7507 run Lore with the same python used in the rest of the build
7509 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7511 * buildbot/process/step_twisted.py (HLint): accept 'python'
7512 argument. Catch rc!=0 and mark the step as failed. This marks the
7513 build orange ("has warnings").
7514 (RunUnitTestsJelly): move out to step_twisted2.py
7516 * buildbot/util.py (ignoreStaleRefs): add utility function
7518 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7519 don't fake ETA object, it's too hard to get right
7521 2003-05-02 Brian Warner <warner@lothar.com>
7523 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7525 2003-05-01 Brian Warner <warner@lothar.com>
7527 * buildbot/status/html.py (StatusResource.body): oops, I was
7528 missing a <tr>, causing the waterfall page to be misrendered in
7529 everything except Galeon.
7531 2003-04-29 Brian Warner <warner@lothar.com>
7533 * docs/examples/twisted_master.py: make debuild use python-2.2
7534 explicitly, now that Twisted stopped supporting 2.1
7536 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7537 handle tuple results too. I keep forgetting this, which suggests
7538 it needs to be rethought.
7540 * setup.py (setup): bump version to 0.3.1+ while between releases
7542 2003-04-29 Brian Warner <warner@lothar.com>
7544 * setup.py: Releasing buildbot-0.3.1
7546 2003-04-29 Brian Warner <warner@lothar.com>
7548 * README (SUPPORT): add plea to send questions to the mailing list
7550 * NEWS, MANIFEST.in: add description of recent changes
7552 * docs/examples/twisted_master.py: add the code used to create the
7553 Twisted buildmaster, with passwords and such removed out to a
7556 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7557 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7558 buildmasters to not require CVSToys be installed.
7559 * README, docs/examples/glib_master: update to match the change
7561 * buildbot/clients/base.py, buildbot/bot.py,
7562 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7563 ReconnectingPB from CVSToys distribution to remove CVSToys
7564 dependency for build slaves and status clients. Buildmasters which
7565 use FreshCVSSources still require cvstoys be installed, of course.
7567 2003-04-25 Brian Warner <warner@lothar.com>
7569 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7570 runTestsRandomly arg to turn on trial -z
7572 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7573 experimental code to use trial's machine-parseable output to get
7574 more detailed test results. Still has some major issues.
7575 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7578 * buildbot/status/builder.py (Builder.setCurrentBuild):
7579 anticipating moving build history into statusbag, not used yet
7581 * buildbot/status/tests.py: code to centralize test results,
7582 doesn't work quite yet
7584 * buildbot/status/event.py (Event): use hasattr("setName") instead
7585 of isinstance for now.. need better long-term solution
7587 * buildbot/status/html.py: Remove old imports
7589 2003-04-24 Brian Warner <warner@lothar.com>
7591 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7592 ignore changes under doc/fun/ and sandbox/
7594 * buildbot/process/step_twisted.py: update pushEvent and friends.
7596 * buildbot/status/html.py (Box.td): replace event.buildername with
7597 event.parent.getSwappableName(). Needs more thought.
7599 * buildbot/status/builder.py (Builder): Replace pushEvent and
7600 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7601 Tell events they are being pruned with event.delete().
7603 * buildbot/process/base.py (Build): Remove Builder status-handling
7604 methods. s/pushEvent/setCurrentActivity/.
7606 * buildbot/process/step.py (BuildStep): clean up status delivery.
7607 Gouse builder.statusbag methods instead of intermediate builder
7608 methods. s/updateLastEvent/updateCurrentActivity/.
7609 s/finalizeLastEvent/finishCurrentActivity/. Use
7610 addFileToCurrentActivity for summaryFunction.
7612 * buildbot/status/event.py (Logfile): put data in a Swappable when
7614 (Event): add more setter methods. Remove .buildername, use .parent
7615 and getSwappableName instead (needs more thought).
7617 * buildbot/util.py (Swappable):
7618 * test/test_swap.py: don't bother setting filename at __init__
7619 time, do it later. Change setFilename args to take parent first,
7620 since it provides the most significant part of the filename.
7622 2003-04-23 Brian Warner <warner@lothar.com>
7624 * buildbot/status/event.py (Logfile.addEntry): append to previous
7627 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7628 anticipating Swappable
7629 (InternalShellCommand.remoteUpdate): split out various log-adding
7630 methods so subclasses can snarf stdout separately
7632 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7633 in anticipation of Swappable build logs
7634 (Builder.testsFinished): anticipating TestResults, still disabled
7636 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7639 * buildbot/status/event.py (Logfile): add (disabled) support for
7640 Swappable, not ready for use yet
7642 * buildbot/util.py (Swappable): object which is swapped out to
7643 disk after some period of no use.
7644 * test/test_swap.py: test buildbot.utils.Swappable
7646 2003-04-14 Brian Warner <warner@lothar.com>
7648 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7649 periodic-build timer. Set the .periodicBuildTime on a builder
7650 instance to some number of seconds to activate it.
7652 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7654 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7655 a way that survives result tuples
7657 2003-04-12 Brian Warner <warner@lothar.com>
7659 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7660 return a dict instead of a tuple: allow summarizers to provide
7661 multiple summaries if they want
7662 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7663 (debuildSummarizer): summarize lintian warnings/errors
7665 2003-04-10 Brian Warner <warner@lothar.com>
7667 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7669 2003-04-09 Brian Warner <warner@lothar.com>
7671 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7672 empty summaries: happens when the tests fail so hard they don't emit
7673 a parseable summary line.
7675 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7676 Allow summaryFunction to return None to indicate no summary should
7679 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7680 writing to stale HTTP requests: notice when they disconnect and
7681 remove the request from the list. Also add CacheToFile from
7682 moshez, will be used later.
7684 2003-04-08 Brian Warner <warner@lothar.com>
7686 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7687 should be an int, not a list of strings
7689 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7690 if we weren't actually connected
7692 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7693 to show the tail end of the trial text output
7695 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7696 hook to summarize the results of a ShellCommand
7698 2003-04-07 Brian Warner <warner@lothar.com>
7700 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7701 twisted test suite code into a single class.
7702 * buildbot/process/process_twisted.py: same
7704 2003-04-04 Brian Warner <warner@lothar.com>
7706 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7708 * README (SLAVE): document use of mktap to create slave .tap file
7709 (REQUIREMENTS): describe dependencies
7711 * buildbot/bb_tap.py, buildbot/plugins.tml:
7712 * buildbot/bot.py (updateApplication): Add mktap support for creating
7713 buildslave .tap files
7715 2003-03-28 Brian Warner <warner@lothar.com>
7717 * buildbot/process/step.py (InternalShellCommand.finished): handle
7718 new tuple result values (fix embarrasing bug that appeared during
7721 2003-03-27 Brian Warner <warner@lothar.com>
7723 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7726 2003-03-25 Brian Warner <warner@lothar.com>
7728 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7729 to overall build status
7730 * buildbot/clients/base.py (Builder): improve event printing
7731 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7732 instead of generic ShellCommand
7733 (Build): Add .stopBuild, use it when slave is detached
7735 * buildbot/process/step.py (Configure,Test): give the steps their
7736 own names and status strings
7738 * buildbot/status/html.py (StatusResource): add "show" argument,
7739 lets you limit the set of Builders being displayed.
7741 2003-03-20 Brian Warner <warner@lothar.com>
7743 * buildbot/process/basic.py: removed
7745 2003-03-19 Brian Warner <warner@lothar.com>
7747 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7748 turn off process-docs by default
7750 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7751 when displaying build information without anything in allBuilds[]
7753 * buildbot/bot.py (makeApp): really take password from sys.argv
7755 2003-03-18 Brian Warner <warner@lothar.com>
7757 * buildbot/bot.py (buildApp): take password from sys.argv
7759 * README: replace with more useful text
7761 * setup.py: add a real one
7762 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7764 * docs/PyCon-2003/: added sources for PyCon paper.
7766 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7767 now Build objects control the process and Builder only handles
7768 slave stuff and distribution of changes/status. A new BuildFactory
7769 class creates Build objects on demand.
7771 Created ConfigurableBuild which takes a list of steps to run. This
7772 makes it a lot easier to set up a new kind of build and moves us
7773 closer to being able to configure a build from a web page.
7775 * buildbot/process/step_twisted.py, process_twisted.py: move to
7776 new model. A lot of code went away.
7778 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7779 send lots of empty progress messages to the client.
7781 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7783 2003-02-20 Brian Warner <warner@lothar.com>
7785 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7787 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7788 Twisted bug that prevented non-pty processes from working just got
7789 fixed, and the bug that leaks ptys is still being investigated.
7791 * buildbot/process/step.py (CVS): send timeout arg to slave
7793 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7794 builders coming and going
7795 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7796 from CVSToys, handle lost-buildmaster
7798 * buildbot/status/client.py (StatusClientService.removeBuilder):
7799 Clean up status client protocol: send builders (with references)
7800 as they are created, rather than sending a list and requiring the
7801 client to figure out which ones are new.
7802 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7803 attempts to force a build on an unknown builder
7805 2003-02-19 Brian Warner <warner@lothar.com>
7807 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7808 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7809 Twisted stops leaking them.
7810 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7811 builder goes to an idle state.
7813 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7814 I figure out why CVS commands hang without them, and/or I fix the
7815 hung-command timeout
7817 2003-02-16 Brian Warner <warner@lothar.com>
7819 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7820 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7821 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7822 GenerateDocs now that they are prefixed with WARNING:.
7824 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7825 use manual href target instead of request.childLink
7827 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7828 display every second, but update the ETA every 5 seconds (or
7829 whenever) as remote_progress messages arrive.
7832 2003-02-12 Brian Warner <warner@lothar.com>
7834 * *: import current sources from home CVS repository
7838 # add-log-time-format: add-log-iso8601-time-string