1 2007-02-06 Brian Warner <warner@lothar.com>
3 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
4 attributes this uses went away
6 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
7 dialog, to allow you to reset the buildmaster and force
8 connect/disconnect. Correctly handle losing the buildmaster
9 connection (by switching the display to the hexnut, at which point
10 you can use the 'Connect' menu item to reconnect).
12 * buildbot/steps/source.py (Source.start): if we're using a patch,
13 add it as a LogFile to the checkout/update step. This will turn
14 into a link on the waterfall page.
16 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
17 option, to take the patch from a pre-made file rather than
18 generating it from the local tree. Thanks to Robert Helmer for the
19 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
20 * buildbot/scripts/runner.py (TryOptions): add --diff,
21 --patchlevel, and --baserev options
22 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
23 as None, meaning HEAD.
24 * buildbot/sourcestamp.py (SourceStamp): update docstring to
25 indicate that baserev=None means HEAD
26 * docs/buildbot.texinfo (try --diff): document it
28 * buildbot/test/test_steps.py (BuildStep): remove use of
29 reactor.iterate(), although the technique I replaced it with is a
30 gross polling hack that must be cleaned up properly some day. This
31 was the last use of reactor.iterate in the entire tree, yay.
33 2007-02-05 Brian Warner <warner@lothar.com>
35 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
36 is one of the three known values, otherwise we emit some confusing
37 messages later on. Thanks to Grig Gheorghiu for the catch.
39 2007-01-30 Brian Warner <warner@lothar.com>
41 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
42 Hearsum contributed a patch to let BonsaiPoller work with results
43 that contain non-ascii characters. Closes SF#1632641.
45 2007-01-27 Brian Warner <warner@lothar.com>
47 * Makefile (release): produce both .tar.gz and .zip source bundles.
50 2007-01-23 Brian Warner <warner@lothar.com>
52 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
53 * buildbot/changes/monotone.py: same
55 * buildbot/changes/maildir.py: combine several files into one,
56 clean up maildir.py to use Services properly.
57 * buildbot/changes/maildirtwisted.py: remove
58 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
60 * buildbot/changes/mail.py: match the change
61 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
62 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
64 * buildbot/slave/commands.py (command_version): bump to "2.3" to
65 indicate that the buildslave knows about the 'bzr' command
67 2007-01-22 Brian Warner <warner@lothar.com>
69 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
70 'with', it will become a reserved work in python2.6 .
72 * contrib/bb_applet.py: add a simple gnome-panel applet, to
73 display a terse summary of buildbot status.
74 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
75 some icons, small versions of the Blender object that lives in
76 docs/images/icon.blend
78 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
79 * buildbot/slave/commands.py (Bzr): same
80 * buildbot/scripts/tryclient.py (BzrExtractor): same
81 (SourceStampExtractor.dovc): modify this to allow non-zero exit
82 status, since 'bzr diff' does that
83 * buildbot/test/test_vc.py (Bzr): same
84 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
88 2007-01-20 Brian Warner <warner@lothar.com>
90 * contrib/darcs_buildbot.py: tidy up the progress messages
92 2007-01-17 Brian Warner <warner@lothar.com>
94 * contrib/darcs_buildbot.py: enhance to handle multiple patches
95 being pushed at a time. This keeps state in the repository in a
96 small file named .darcs_buildbot-lastchange, but that shouldn't
97 interfere with normal repository operations. Fixes SF#1534049.
98 * buildbot/clients/sendchange.py (Sender): make a single Sender
99 capable of sending Changes with different usernames.
101 2006-12-11 Brian Warner <warner@lothar.com>
103 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
104 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
105 buildbot.changes.mail a long time ago, but I forgot to add the
106 DeprecationWarning until now.
108 * buildbot/process/maxq.py: remove this, the functionality now
109 lives in buildbot.steps.maxq
111 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
112 * buildbot/clients/gtkPanes.py: remove unused import
114 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
115 that was meant to provide a special Reporter to run inside trial
116 and give the buildslave lots of machine-readable status. We never
117 finished this project.
119 * buildbot/changes/bonsaipoller.py: remove unused imports
120 * buildbot/changes/svnpoller.py: same
121 * buildbot/process/builder.py: same
122 * buildbot/process/buildstep.py: same
123 * buildbot/slave/bot.py: hush pyflakes warning
124 * buildbot/status/tests.py: remove unused imports
125 * buildbot/status/tinderbox.py: same
126 * buildbot/steps/python_twisted.py: same
128 * buildbot/process/step.py: remove this file, these names were
129 deprecated in 0.7.5 and are now being removed.
130 * buildbot/process/step_twisted.py: same
131 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
133 * buildbot/twcompat.py: remove the empty file, yay it is gone
135 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
136 tw-2.0.0 and newer have the method we need.
137 (getProcessOutputAndValue): same
138 (which): remove this method, tw-2.0.0 t.p.procutils has it
140 * buildbot/twcompat.py (implements): remove this method
141 * buildbot/*: import implements() from zope.interface directly
143 * buildbot/status/mail.py: stop falling back to importing
144 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
147 * buildbot/twcompat.py (Interface): remove this import
148 * buildbot/*: import Interface from zope.interface directly
150 * buildbot/twcompat.py (providedBy): remove this method
151 * buildbot/*: turn all uses of providedBy(obj, iface) into
152 iface.providedBy(obj)
154 * buildbot/twcompat.py (maybeWait): remove this method, now that
155 we no longer maintain compatibility with Twisted<=1.3.0 .
156 Twisted-2.0.0 and later allow trial methods to return Deferreds
158 * buildbot/test/*: remove all uses of maybeWait
160 * buildbot/__init__.py (version): bump to 0.7.5+ while between
162 * docs/buildbot.texinfo: same
164 2006-12-10 Brian Warner <warner@lothar.com>
166 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
167 * docs/buildbot.texinfo: set version to match
169 2006-12-10 Brian Warner <warner@lothar.com>
171 * README (REQUIREMENTS): update for release
172 * NEWS: update for release
173 * buildbot/slave/commands.py (command_version): mention that this
174 version (2.2) was released with buildbot-0.7.5
176 * buildbot/test/test_config.py (StartService.testStartService):
177 inhibit the usual read-config-on-startup behavior, since otherwise
178 the log.err that gets recorded causes the test to fail
180 * buildbot/status/builder.py (LogFile.finish): forget about all
181 subscribers once the log has finished, since after that point
182 we're never going to use them again. This might help free up some
185 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
186 than the old/deprecated gtk.mainquit()
188 2006-12-09 Brian Warner <warner@lothar.com>
190 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
191 better when we can't open the masterdst file
193 * buildbot/scripts/startup.py (Follower._failure): add missing
194 import statement for BuildSlaveDetectedError
196 * buildbot/steps/transfer.py (FileUpload): cleanup
197 (FileDownload): same. Add tests for slave version, add mode=.
198 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
199 (SlaveFileDownloadCommand): same
200 * buildbot/test/test_transfer.py: enhance tests
201 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
204 2006-12-08 Brian Warner <warner@lothar.com>
206 * buildbot/scripts/runner.py (sendchange): halt the reactor on
207 both success *and* failure. Without this, the 'buildbot
208 sendchange' command would hang if it could not contact the
209 buildmaster or deliver the Change, which would generally cause the
210 user's commit/record/checkin command to hang too. Thanks to
211 Christian Unger for the catch.
213 2006-12-06 Brian Warner <warner@lothar.com>
215 * NEWS: update with items for the next release
217 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
218 whimsical example pulled from a punch-drunk email I sent out late
220 (Transferring Files): document some of the other parameters
221 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
222 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
223 * buildbot/test/test_svnpoller.py: same
224 * buildbot/changes/svnpoller.py (SVNPoller): same
226 2006-11-26 Brian Warner <warner@lothar.com>
228 * docs/buildbot.texinfo (Build Properties): remind users that
229 WithProperties must appear in a command= list, not as a top-level
231 * buildbot/steps/shell.py (ShellCommand.start): and assert that
232 we're sending a list or a single string to the RemoteShellCommand
234 * buildbot/scheduler.py (Nightly): Improve docs slightly.
236 * buildbot/scripts/startup.py (start): skip the whole
237 watch-the-logfile thing under windows, since it needs os.fork()
239 * buildbot/scripts/runner.py (restart): remove the old message
240 that got printed after the buildbot was restarted.. it most cases
241 it didn't get printed at the right time anyways
243 2006-11-25 Brian Warner <warner@lothar.com>
245 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
246 follow twistd.log and print lines until the process has started
247 started properly. For the buildmaster, this means until the config
248 file has been parsed and accepted. For the buildslave, this means
249 until we've connected to the master. We give up after 5 seconds in
250 any case. Helpful error messages and troubleshooting suggestions
251 are printed when we don't see a successful startup. This closes the
252 remainder of SF#1517975.
253 * buildbot/scripts/startup.py: moved app startup code to here
254 * buildbot/scripts/logwatcher.py: utility class to follow log
255 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
256 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
257 so the LogWatcher can tell the difference between a buildmaster
260 2006-11-24 Brian Warner <warner@lothar.com>
262 * docs/examples/twisted_master.cfg: update to match the version
263 in use on twistedmatrix.com
264 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
265 was using before stopped working, but 'irc.freenode.net' works
268 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
271 * buildbot/clients/base.py (TextClient.not_connected): upon
272 UnauthorizedLogin failures, remind the user to connect to the
273 PBListener port instead of the slaveport.
274 (TextClient.disconnected): shut down more quietly
275 * docs/buildbot.texinfo (statuslog): add another reminder
277 * buildbot/scripts/runner.py (Options.subCommands): rename
278 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
279 'sighup' as an alias.
280 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
281 reconfig command to follow twistd.log and print all of the lines
282 from the start of the config-file reload to its completion. This
283 should make it a lot easier to discover bugs in the config file.
284 Use --quiet to disable this behavior. This addresses half of
285 SF#1517975, the other half will be to add this same utility to
286 'buildbot start' and 'buildbot restart'.
287 * docs/buildbot.texinfo (Loading the Config File): same
290 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
291 method, it has been deprecated for a long time. Use
292 IBuilderControl.requestBuild instead.
293 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
294 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
295 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
296 * buildbot/test/test_control.py (Force.testForce): same
297 * buildbot/test/test_run.py: use requestBuild instead
299 * buildbot/clients/debug.py: replace 'Force Build' button with
300 'Request Build' (which just adds one to the queue), add Ping
301 Builder, add branch/revision fields to Request Build.
302 * buildbot/clients/debug.glade: same
303 * buildbot/master.py: update interface to match. This creates an
304 incompatibility between new debugclients and old buildmasters.
306 * buildbot/process/builder.py (Builder._attached): delay the call
307 to maybeStartBuild for a reactor turn, to avoid starting a build
308 in the middle of a reconfig (say, if the new Builder uses a new
309 slave which is already connected).
311 2006-11-23 Brian Warner <warner@lothar.com>
313 * buildbot/test/test_transfer.py: appease pyflakes
314 * buildbot/test/test_steps.py: same
316 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
317 keeps pyflakes from finding undefined names
319 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
320 Builder no longer induces a disconnect/reconnect cycle. This means
321 that any builds currently in progress will not be interrupted, and
322 any builds which are queued in the Builder will not be lost. This
323 is implemented by having the new Builder extract the state (i.e.
324 all pending Builds and any desired SlaveBuilders) from the old
326 (BotPerspective): refactor. The BotPerspective no longer keeps
327 track of all the Builders that want to use this slave; instead, it
328 asks the BotMaster each time it needs this list. This removes
329 addBuilder and removeBuilder. Clean up attached() to acquire all
330 the slave's information in a more atomic fashion. updateSlave() is
331 now the way to make sure the slave is using the right set of
332 Builders: just call it after everything else has been
334 (BotMaster): refactor, removing addBuilder/removeBuilder and
335 replacing them with an all-at-once setBuilders() call.
337 * buildbot/test/test_slaves.py (Reconfig): new test case to
338 exercise this functionality
339 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
340 * buildbot/slave/commands.py (WaitCommand): same
342 * docs/buildbot.texinfo (Loading the Config File): document the
345 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
346 SlaveBuilder to have its parent Builder changed.
347 (SlaveBuilder.isAvailable): new method to give access to state,
348 which is now a private attribute
349 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
350 the SlaveBuilder about how it is being used. These methods update
351 its internal state. buildFinished() is now the place that invokes
352 maybeStartBuild() on its parent Builder.
353 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
354 new Builder to take over for an old one, transferring state from
356 (Buider): refactor the way that SlaveBuilders are used to match,
357 giving them a bit more autonomy.
358 (Builder.buildFinished): this no longer calls maybeStartBuild():
359 instead the SlaveBuilder calls it on whoever its parent Builder is
360 at the time. This way, when an old Builder is replaced by a new
361 one, and there was a build in progress during the transition, when
362 that build finishes, it will be the new Builder that is told about
363 the newly available slave so it can start a new build.
365 * buildbot/process/base.py (Build.startBuild._release_slave): when
366 the Build finishes, tell the SlaveBuilder that they've been
369 * buildbot/status/builder.py (SlaveStatus): add some new setter
370 methods for use by BotPerspective, to keep some attributes more
373 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
374 called by the buildmaster.
375 (Bot.setBuilderList): instead, we locally announce any leftover
376 directories based upon which Builders we were told about. The
377 master doesn't really care; it's the local admin who may or may not
381 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
382 to allow use of python2.4 or whatever. This tool still requires
385 2006-11-19 Brian Warner <warner@lothar.com>
387 * NEWS (IStatusLog.readlines): more news items
389 2006-11-18 Brian Warner <warner@lothar.com>
391 * NEWS: start collecting items for the next release.
393 2006-11-04 Brian Warner <warner@lothar.com>
395 * buildbot/changes/bonsaipoller.py: apply updates from Ben
396 Hearsum. Closes SF#1590310.
397 * buildbot/test/test_bonsaipoller.py: and tests
399 * buildbot/status/tinderbox.py
400 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
401 status when the build results in WARNINGS. Patch from Dave
402 Liebreich. Closes SF#1587352.
404 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
405 linux-vs-osx behavior difference w.r.t. reading from files that
406 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
407 to Mark Rowe for the patch.
409 2006-10-15 Brian Warner <warner@lothar.com>
411 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
412 method name was misspelled in the interface definition. Thanks to
413 Roy Rapoport for the catch.
415 2006-10-13 Brian Warner <warner@lothar.com>
417 * docs/buildbot.texinfo (Adding LogObservers): update sample code
418 to match the great Steps renaming
420 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
421 Maybe I should run my own unit tests before recording a big
422 change. Good thing I've got a buildbot to remind me.
424 2006-10-12 Brian Warner <warner@lothar.com>
426 * buildbot/steps/transfer.py: rework __init__ and args setup
427 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
429 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
430 when opening the target file, only catch IOError (to report via
431 stderr/rc!=0), let the others be reported as normal exceptions
433 2006-10-08 Brian Warner <warner@lothar.com>
435 * contrib/svn_watcher.py: fix security holes by using proper argv
436 arrays and subprocess.Popen() rather than commands.getoutput().
437 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
438 is deprecated in favor of buildbot/changes/svnpoller.py, and will
439 probably be removed by the next release.
442 2006-10-04 Brian Warner <warner@lothar.com>
444 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
445 initial lines that weren't emitted by pyflakes. When the pyflakes
446 command is run under a Makefile, 'make' will echo the command it
447 runs to stdio, and that was getting logged as a "misc" warning.
448 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
449 * buildbot/test/test_steps.py (testPyFlakes3): another test
451 2006-10-01 Brian Warner <warner@lothar.com>
453 * buildbot/status/html.py (HtmlResource.render): if we get a
454 unicode object from our content() method, encode it into utf-8
455 like we've been claiming to all along. This allows the comments
456 and author names from svnpoller.py to be delivered properly.
458 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
459 de-unicodify filenames before creating the Change, because the
460 rest of buildbot is unlikely to handle them well. Leave the 'who'
461 field as a unicode object.. I don't think there's anything that
462 will break very soon, and it will probably nudge us towards
463 accepting unicode everywhere sooner or later. Stop using the
464 "date" field that comes out of SVN, since it is using the
465 repository's clock (and timezone) and what we care about is the
466 buildmaster's (otherwise Changes from the future show up later
467 than the builds they triggered).
468 * buildbot/test/test_svnpoller.py (Everything.test1): match the
471 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
472 Suvbersion repository polling ChangeSource. I've hacked it up
473 considerably: any bugs are entirely my own fault. Thank you
475 * buildbot/test/test_svnpoller.py: tests for it
476 * docs/buildbot.texinfo (SvnSource): document it
478 2006-09-30 Brian Warner <warner@lothar.com>
480 * buildbot/scheduler.py (Periodic): submit a reason= to the
481 BuildSet to indicate which Scheduler triggered the build. Thanks
482 to Mateusz Loskot for the suggestion.
484 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
486 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
487 changes: set self.loop in __init__, remove unused volatile=
489 * docs/buildbot.texinfo (.buildbot config directory): add more
490 docs on the .buildbot/options keys used by "buildbot try"
491 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
492 (Try.deliverJob): same
494 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
498 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
499 close the filehandle when we stop watching the file. Before, the
500 filehandle was only closed when the LogFileWatcher was
501 garbage-collected, which could be quite a while in the future. If
502 it was still open by the time the next build started, windows will
503 refuse to let the new build delete the old build/ directory. Fixes
504 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
505 #twisted for the catch.
507 2006-09-29 Brian Warner <warner@lothar.com>
509 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
512 2006-09-25 Brian Warner <warner@lothar.com>
514 * setup.py: the new buildbot.steps module wasn't being installed.
515 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
516 (testmsgs): add the extra stuff from buildbot/test/* so you can
517 run unit tests on an installed copy of buildbot, not just from
520 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
521 columns of 'svnlook changed' output contain status information, so
522 strip [:4] instead of [:6]. Depending upon what the status flags
523 were, this would sometimes lead to mangled filenames. Thanks to
524 Riccardo Magliocchetti for the patch. Closes SF#1545146.
526 * buildbot/steps/source.py (Monotone): initial Monotone support,
527 contributed by Nathaniel Smith. Still needs docs and tests, but
528 this code has been in use on the Monotone buildbot for a long
530 * buildbot/slave/commands.py (Monotone): slave-side support
531 * buildbot/changes/monotone.py (MonotoneSource): polling change
534 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
535 contributed a Change Source that polls a Bonsai server (a
536 kind of web-based viewcvs CGI script).
538 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
539 Hearsum contributed a status plugin which sends email in the same
540 format that Tinderbox does: this allows a number of tinderbox
541 tools to be driven by Buildbot instead. Thanks Ben!
543 2006-09-24 Brian Warner <warner@lothar.com>
545 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
546 Thanks to Robert Helmer for the patch.
548 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
549 BuildStatus about the buildslave name at the *beginning* of the
550 build, rather than at the end. Thanks to Alexander Lorenz for the
552 * buildbot/status/html.py (StatusResourceBuild.body): always
553 include the slavename in the build page, not just when the build
555 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
556 slavename in the email message
558 2006-09-21 Brian Warner <warner@lothar.com>
560 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
562 * docs/examples/glib_master.cfg: same
563 * docs/examples/hello.cfg: same
564 * docs/examples/twisted_master.cfg: same, update to current usage
566 2006-09-19 Brian Warner <warner@lothar.com>
568 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
569 (PyFlakes.createSummary): make it compatible with python-2.2
571 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
572 for at least the output-parsing parts of PyFlakes
574 2006-09-18 Brian Warner <warner@lothar.com>
576 * buildbot/steps/python.py: oops, fix import of StringIO
578 2006-09-17 Brian Warner <warner@lothar.com>
580 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
581 turns out that SVN-1.4.0 doesn't fail to update once you've
582 replaced a file with a directory, unlike older versions of SVN and
583 pretty much every other VC tool we support. Since what we really
584 care about is that the update succeeds anyway, stop checking that
585 the tree got clobbered and just assert that the build succeeded.
586 (VCBase.printLogs): add a utility function for debugging
588 * buildbot/process/step.py: oops, added extra imports by mistake
590 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
591 rstrip() on the first line coming out of the 'p4 describe'
592 process, to remove the stray ^M that Wade Brainerd reports seeing
593 in the 'when' field. Fixes SF#1555985.
595 * buildbot/master.py (BuildMaster.loadConfig): improve the error
596 message logged when c['schedulers'] is not right
597 * buildbot/scheduler.py (Scheduler.__init__): improve error
598 message when a Scheduler() is created with the wrong arguments
599 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
600 verify that these error messages are emitted
602 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
603 The idea is that all the base classes (like BuildStep and
604 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
605 will be a leftover backwards-compatibility file that only contains
606 aliases for the steps that were moved out to buildbot.steps.*
607 * lots: change imports to match
608 * buildbot/process/step.py: add a DeprecationWarning if it ever
611 2006-09-12 Brian Warner <warner@lothar.com>
613 * buildbot/scheduler.py (Scheduler.__init__): make sure that
614 builderNames= is actually a sequence, since if you happen to give
615 it a single builder-specification dictionary instead, it won't get
616 caught by the existing assert. Thanks to Brett Neely for the
619 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
621 * docs/buildbot.texinfo (Python BuildSteps): document them
622 (sendchange): include a link to PBChangeSource, since you need one
624 * buildbot/steps/shell.py: clean up test-case-name line, remove some
626 * buildbot/steps/dummy.py: same
628 2006-09-08 Brian Warner <warner@lothar.com>
630 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
631 BuildStep which lets you transfer files from the master to the
632 slave or vice versa. Thanks to Albert Hofkamp for the original
633 patch. Fixes SF#1504631.
634 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
636 (SlaveFileDownloadCommand): same
637 * docs/buildbot.texinfo (Transferring Files): document it
638 * buildbot/test/test_transfer.py: test it
639 * buildbot/test/runutils.py (StepTester): new utility class for
640 testing BuildSteps and RemoteCommands without Builds or Bots or PB
641 * buildbot/test/test_steps.py (CheckStepTester): validate that the
644 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
645 walk through StatusLogs one line at a time, mostly for the benefit
646 of ShellCommand.createSummary methods. You can either walk through
647 STDOUT or STDERR, but the default is STDOUT.
649 * buildbot/status/builder.py (LogFile.readlines): implement it.
650 Note that this is not yet memory-efficient, it just pulls the
651 whole file into RAM and then splits it up with a StringIO.
652 Eventually this should be a generator that only pulls chunks from
654 * buildbot/test/test_status.py (Log.testReadlines): test it
656 * docs/buildbot.texinfo: update to match changes
657 * buildbot/process/factory.py: stop using old definitions
658 * buildbot/process/process_twisted.py: same
659 * buildbot/test/test_*.py: same
661 * buildbot/process/step_twisted.py: move definition to..
662 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
663 relative-import mechanisms prevent this from being named 'twisted'
664 or 'python/twisted' as I would have preferred.
666 * buildbot/process/maxq.py: move definition to..
667 * buildbot/steps/maxq.py: .. here, leave a compatibility import
669 * buildbot/process/step.py: split the user-visible BuildSteps into
670 separate files, all under buildbot/steps/
671 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
672 * buildbot/steps/shell.py: this holds ShellCommand and friends
673 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
675 2006-09-05 Brian Warner <warner@lothar.com>
677 * lots: run pyflakes, removed a lot of unused imports, changed the
678 form of some conditional imports to remove false pyflakes
679 warnings. There are still a number of warnings left, mostly from
680 imports that are done for their side-effects.
681 * buildbot/test/test_vc.py: import twisted.python.failure, since it
684 2006-08-26 Brian Warner <warner@lothar.com>
686 * buildbot/test/test_locks.py (Unit.testLater): make the tests
687 compatible with twisted-1.3.0, for some reason I just can't seem
688 to let go of the past.
690 2006-08-25 Brian Warner <warner@lothar.com>
692 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
694 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
695 all logfiles= in startCommand(), rather than in start() . This
696 makes it easier to have the 'stdio' log come before any secondary
697 logfiles, which I feel makes the waterfall display more
699 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
700 from ShellCommand up into LoggingBuildStep
701 (LoggingBuildStep.__init__): move the handling of logfiles= from
702 ShellCommand up to LoggingBuildStep, because startCommand is
703 provided by LoggingBuildStep, whereas start() was specific to
704 subclasses like ShellCommand and Source. This removes code
705 duplication in those subclasses.
706 (ShellCommand.__init__): same
707 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
708 for a slave that's too old to understand logfiles= into a separate
709 method, so it can live in ShellCommand. The rest of
710 setupLogfiles() can live in LoggingBuildStep.
712 2006-08-24 Brian Warner <warner@lothar.com>
714 * buildbot/locks.py (BaseLock): you can now configure Locks to
715 allow multiple simultaneous owners. They still default to
716 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
718 * docs/buildbot.texinfo (Interlocks): document the new options
719 * buildbot/test/test_locks.py: add a bunch of new unit tests
720 * buildbot/process/base.py (Build.acquireLocks): locks now offer
721 waitUntilMaybeAvailable, not waitUntilAvailable
722 * buildbot/process/step.py (BuildStep.acquireLocks): same
723 * buildbot/master.py (BotMaster.getLockByID): real locks now use
724 the whole lockid in their constructor, not just the name. Also,
725 keep track of which real locks we've handed out by the full
726 lockid, not just class+name, otherwise changing just the maxCount=
727 in the master.cfg file would not actually cause a behavioral
730 2006-08-23 Brian Warner <warner@lothar.com>
732 * buildbot/__init__.py (version): bump to 0.7.4+ while between
734 * docs/buildbot.texinfo: same
736 2006-08-23 Brian Warner <warner@lothar.com>
738 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
739 * docs/buildbot.texinfo: set version to match
740 * NEWS: update for 0.7.4
741 * buildbot/slave/commands.py (command_version): mention that this
742 version (2.1) was released with buildbot-0.7.4
744 2006-08-22 Brian Warner <warner@lothar.com>
748 * CREDITS: new file, list of people who have helped. Thanks!
749 * MANIFEST.in: ship it
751 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
752 new diagrams, the user's manual is more informative than it was.
753 Start shipping the .html user's manual (and generated .png
755 * Makefile: update 'release' target to match
757 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
758 test.. I think the web-parts effort will render it pointless well
759 before it ever actually starts to work.
761 2006-08-20 Brian Warner <warner@lothar.com>
763 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
764 meaning of the prefix= argument. It is now just a string which is
765 stripped from the beginning of the filename. If prefix= is set but
766 not found on any given filename, that filename is ignored. If all
767 filenames in a Change are ignored, the Change is dropped. This is
768 much simpler than the previous sep= nonsense, and I should have
769 implemented it this way from the beginning. Effectively resolves
770 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
771 Gedminas for the catch and suggested fixes.
772 (ChangePerspective.perspective_addChange): implement the actual
774 * buildbot/test/test_changes.py (TestChangePerspective): test it
775 * docs/buildbot.texinfo (PBChangeSource): document it, explain
776 how to properly use prefix=
777 * docs/examples/twisted_master.cfg (source): update prefix= by
778 adding the trailing slash
781 * docs/examples/twisted_master.cfg: update to actual practice
783 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
784 update test case to match new link text.. the HREF has both a
785 class= setting and an enclosing [] pair that I didn't match in the
788 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
789 list of strings is preferred over a single string with embedded
791 (ShellCommand.description=): explain that either single strings or
792 a list of strings is acceptable, and why you might prefer one over
793 the other. Add an example. Fixes SF#1524659, thanks to Paul
794 Winkler for the catch.
795 (Build Steps): update to use f.addStep() rather than using s()
796 and the constructor list
798 * buildbot/process/step.py (ShellCommand): accept either a single
799 string or a list of strings in both description= and
801 * buildbot/test/test_steps.py (Steps.test_description): test it
802 * buildbot/test/runutils.py (makeBuildStep): support for that test
804 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
805 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
806 collecting the files and creating the patch.
808 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
809 per-step URLs that will be displayed on the waterfall display,
810 for things like the HTML output of code-coverage tools, when
811 the results are hosted elsewhere.
812 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
813 way to retrieve these URLs
814 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
815 the method to retrieve these URLs. Also provide backwards
816 compatibility for saved BuildStepStatus instances that didn't have
818 * buildbot/process/step.py (BuildStep.addURL): method to set these
819 URLs from within a BuildStep
820 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
821 (StepBox.getBox): give these external links a distinct CSS class
822 named "BuildStep external" so a .css file can display them
825 * buildbot/test/test_web.py (WaterfallSteps): test that we really
827 * buildbot/test/test_steps.py (Steps): test that we can all the
828 URLs. Also add a bunch of other tests on methods that can be
829 called from within BuildSteps
830 * buildbot/test/runutils.py (makeBuildStep): add utility function
832 2006-08-13 Brian Warner <warner@lothar.com>
834 * docs/buildbot.texinfo (BuildStep LogFiles): document them
836 2006-08-10 Brian Warner <warner@lothar.com>
838 * docs/buildbot.texinfo (Index of master.cfg keys): add another
839 index, this one of things like c['sources'] and c['schedulers']
840 (indices): it looks like my clever idea of putting the @fooindex
841 commands in between the @node and the @subsection (to make the
842 HREF anchor jump to slightly above the section title, which works
843 much better in html) confused texinfo horribly, so I'm moving the
844 index tags back to be just after the @subsection marker. I also
845 added extra lines between the @node/@section paragraph and the
846 index tags, since I think maybe texinfo wants to see these be
849 * docs/Makefile (images): make sure images get built when
851 * docs/images/Makefile: same
853 * buildbot/scripts/runner.py: rename 'buildbot master' to
854 'buildbot create-master', and 'buildbot slave' to 'buildbot
856 * docs/buildbot.texinfo: same
859 * docs/buildbot.texinfo: reimplement the "useful classes" index
860 with actual texinfo indices. The .info rendering is a bit
861 weird-looking but it works well, and the HTML rendering is quite
862 nice. This also puts the index targets in the regular flow of the
863 text, which is easier to maintain.
865 2006-08-06 Brian Warner <warner@lothar.com>
867 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
868 Kevin Turner to prefer the environ= argument be a list rather than
869 a string. If it is a list, it will be joined with a platform-local
870 os.pathsep delimiter, and then prepended to any existing
871 $PYTHONPATH value. This works better in cross-platform (i.e.
872 windows buildslaves) environments when you need to push multiple
873 directories onto the front of the path.
874 (SlaveShellCommand): documented the new magic
875 * docs/buildbot.texinfo (ShellCommand): documented the new magic
876 in a user-visible form
878 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
879 Turner to prefer lists over strings when creating/running VC
880 commands during unit tests. This is clearly necessary to survive
881 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
882 renamed the wq() function to qw() though, since that's how it's
883 spelled in perl. Eventually I'd prefer all commands to be
884 specified with lists.
886 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
887 which are deleted (or not yet created) correctly. Also add
888 failsafe code to not explode if the file-watching poller doesn't
889 get started. Thanks to JP Calderone for the catch and the poller
891 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
893 * buildbot/test/emitlogs.py: same
895 * NEWS: summarize recent changes
897 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
898 clause to avoid the "host key mismatch" warning
900 * buildbot/process/step_twisted.py (Trial.start): if the
901 buildslave is too old to understand logfiles=, fall back to
902 running 'cat _trial_temp/test.log' like before.
903 (Trial.commandComplete): same. this takes advantage of the
904 LoggingBuildStep refactoring to stall commandComplete long enough
905 to run a second RemoteShellCommand.
907 * buildbot/process/step.py (LoggingBuildStep.startCommand):
908 refactor command-completion handling, to allow methods like
909 commandComplete/createSummary/evaluateCommand to return Deferreds.
910 (LoggingBuildStep._commandComplete): delete the refactored method
911 (ShellCommand.setupLogfiles): if the buildslave is too old to
912 understand logfiles=, put a warning message both into twistd.log
913 and into the otherwise empty user-visible LogFiles.
915 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
916 callers to provide the slave-side logfile name, rather than
917 forcing it to come from the local name of the LogFile.
918 (BuildStep.getSlaveName): new method
920 * buildbot/process/base.py (Build.getSlaveName): new method, so
921 steps can find out which buildslave they're running on
923 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
924 to match the s/cvs_ver/command_version/ change
926 2006-08-05 Brian Warner <warner@lothar.com>
928 * buildbot/slave/commands.py (command_version): replace the CVS
929 auto-updated cvs_ver keyword with a manually-updated variable,
930 since CVS is no longer the master repository. Add a description of
931 the remote API change starting in this version (2.1), specifically
932 the fact that SlaveShellCommand now accepts 'initial_stdin',
933 'keep_stdin_open', and 'logfiles'.
935 2006-07-31 Brian Warner <warner@lothar.com>
937 * docs/buildbot.texinfo (System Architecture): Finally add lots of
938 diagrams to describe how the whole system fits together. The
939 images themselves are kept in SVG files, with ascii-art versions
940 in corresponding .txt files. Texinfo knows how to interpolate the
941 text version into .info files, reference the .png versions from
942 .html files, and include .eps versions in the .ps format.
943 * docs/images/Makefile: tools to create .png and .eps
944 * docs/images/*.svg: created pictures with Inkscape.
945 * .darcs-boring: ignore the generated .eps and .png files
947 2006-07-24 Brian Warner <warner@lothar.com>
949 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
950 Scheduler names, since they cause setServiceParent to explode
952 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
954 2006-07-20 Brian Warner <warner@lothar.com>
956 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
957 which runs the buildbot unit tests
959 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
960 classes that are useful in master.cfg
962 2006-07-15 Brian Warner <warner@lothar.com>
964 * Makefile (some-apidocs): new target to build only some epydocs
966 * setup.py: minor comment.. does the classifiers= argument prevent
967 the setup.py script from working on python2.2/2.3?
969 * buildbot/scripts/sample.cfg: update manhole example, arrange into
972 * buildbot/twcompat.py: fix minor typo in comments
974 * buildbot/manhole.py: move all Manhole-related code out to this
975 module. Implement SSH-based manholes (with TwistedConch), and move
976 to conch's nifty line-editing syntax-coloring REPL shell instead
977 of the boring non-editing monochromatic (and deprecated) old
979 * buildbot/master.py: remove all Manhole-related code
980 (BuildMaster.loadConfig._add): make sure the old manhole is
981 removed before we add the new one
982 * docs/buildbot.texinfo (Debug options): document new Manhole options
984 * buildbot/twcompat.py (_which): fix some epydoc issues
985 * buildbot/status/html.py (Waterfall.__init__): same
987 2006-06-29 Brian Warner <warner@lothar.com>
989 * buildbot/interfaces.py: get Interface from b.twcompat to hush
990 deprecation warnings under newer Twisteds (by using
991 zope.interface.Interface instead of old twisted.python.components
993 * buildbot/slave/interfaces.py: same
995 2006-06-28 Brian Warner <warner@lothar.com>
997 * buildbot/slave/commands.py (SVN): add --non-interactive to all
998 svn commands, so it will fail immediately instead of hanging while
999 it waits for a username/password to be typed in.
1001 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1002 log message if the step was shut down
1004 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1005 obsolete reference to mktap.
1007 2006-06-20 Brian Warner <warner@lothar.com>
1009 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1010 test to include new 'logfiles' argument sent from master to slave
1012 2006-06-19 Brian Warner <warner@lothar.com>
1014 * buildbot/process/step_twisted.py (Trial): track Progress from
1015 _trial_temp/test.log too
1017 * buildbot/process/step.py (OutputProgressObserver): generalize
1018 the earlier StdioProgressObserver into an OutputProgressObserver
1019 that can track LogFiles other than stdio.
1020 (LoggingBuildStep.__init__): same
1022 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1023 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1024 will fail under windows because of os.sep issues. It might have
1025 worked before if 'cat' was doing cygwin path conversion.
1027 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1028 creation of LogFileWatchers
1029 (ShellCommand._startCommand): and record the files that were
1030 watched in the 'headers' section of the ShellCommand output
1032 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1033 need to actually pass it to the slave if you want it to work.
1034 (ShellCommand): document it a bit
1036 * buildbot/test/test_shell.py: new test to validate LogFiles
1037 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1039 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1040 before printing the last batch of lines, to test that the polling
1041 logic is working properly
1043 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1044 handling, making it possible to track multiple logs for a single
1045 RemoteCommand. The previous single logfile is now known as the
1047 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1048 (RemoteShellCommand.__init__): accept logfiles=
1049 (LoggingBuildStep.startCommand): stdio_log is now one of many
1050 (ShellCommand): added logfiles= argument, as well as a class-level
1051 .logfiles attribute, which will be merged together to figure out
1052 which logfiles should be tracked. The latter maybe be useful for
1053 subclasses of ShellCommand which know they will aways produce
1054 secondary logfiles in the same location.
1056 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1057 and closeStdin() methods, preparing to make it possible to write
1058 to a ShellCommand's stdin at any time, not just at startup. These
1059 writes are buffered if the child process hasn't started yet.
1060 (LogFileWatcher): new helper class to watch arbitrary logfiles
1061 while a ShellCommand runs. This class polls the file every two
1062 seconds, and sends back 10k chunks to the buildmaster.
1063 (ShellCommand): rename stdin= to initialStdin=, and add
1064 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1066 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1067 key of "log" and a value of (logname, data).
1068 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1069 'logfiles' to the master-visible args dictionary.
1070 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1073 * buildbot/test/test_vc.py (Patch.testPatch): same
1076 * buildbot/test/emit.py: write to a logfile in the current
1077 directory. We use this to figure out what was used as a basedir
1078 rather than looking to see which copy of emit.py gets run, so that
1079 we can run the commands from inside _trial_temp rather than inside
1081 * buildbot/test/subdir/emit.py: same
1082 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1083 argument rather than running from buildbot/test/
1084 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1085 rather than using an implicit setUp()
1086 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1087 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1088 of assuming that we're running in buildbot/test/ (and that '.' is
1091 * buildbot/slave/commands.py (Command.doStart): refactor Command
1092 startup/completion a bit: now the SlaveBuilder calls doStart(),
1093 which is not meant for overridding by subclasses, and doStart()
1094 calls start(), which is. Likewise the SlaveBuilder calls
1095 doInterrupt(), and subclasses override interrupt(). This also puts
1096 responsibility for maintaining .running in Command rather than in
1098 (Command.doInterrupt): same
1099 (Command.commandComplete): same, this is called when the deferred
1100 returned by start() completes.
1101 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1102 (SlaveBuilder.remote_interruptCommand): same
1103 (SlaveBuilder.stopCommand): same
1105 2006-06-16 Brian Warner <warner@lothar.com>
1107 * buildbot/test/test_shell.py: new test file to contain everything
1108 relating to ShellCommand
1109 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1110 multiple logfiles in realtime" feature, not yet implemented
1111 * buildbot/test/emitlogs.py: support file for testLogFiles
1112 * docs/buildbot.texinfo (ShellCommand): document the feature
1114 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1116 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1117 for tests which exercise SlaveCommands in isolation.
1119 * buildbot/test/test_slavecommand.py: Move some utilities like
1120 SignalMixin and FakeSlaveBuilder from here ..
1121 * buildbot/test/runutils.py: .. to here, so they can be used by
1122 other test classes too
1123 * buildbot/test/test_vc.py: more SignalMixin refactoring
1124 * buildbot/test/test_control.py: same
1125 * buildbot/test/test_run.py: and some rmtree refactoring
1127 2006-06-15 Brian Warner <warner@lothar.com>
1129 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1130 'testBranch' to match other VC tests and have the tests run in
1131 roughly increasing order of dependency
1133 * buildbot/test/test_steps.py (LogObserver): new test to verify
1134 LogObservers can be created at various times and still get
1135 connected up properly
1137 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1138 to create BuildStepStatus instances that actually work.
1140 * buildbot/process/step.py (LogObserver): add outReceived and
1141 errReceived base methods, to be overridden
1143 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1144 API to take a name instead of a step, reducing the coupling
1145 somewhat. This returns the BuildStepStatus object so it can be
1146 passed to the new Step, instead of jamming it directly into the
1148 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1150 * buildbot/process/base.py (Build.setupBuild): use both methods
1151 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1152 process a bit to match
1154 2006-06-14 Brian Warner <warner@lothar.com>
1156 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1157 docs on writing new LogObserver classes
1158 (Writing New Status Plugins): brief docs on how Status Plugins fit
1161 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1162 implement a LogObserver that counts how many unit tests have been
1164 (Trial.__init__): wire it in
1165 * buildbot/test/test_twisted.py (Counter): unit test for it
1167 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1168 to new cmd.logs['stdio'] scheme
1169 (Trial.commandComplete): same
1170 (BuildDebs.commandComplete): same
1172 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1173 LogFiles, instead of just a single one. The old single logfile is
1174 now called "stdio". LoggedRemoteCommand no longer creates a
1175 LogFile for you (the code to do that was broken anyway). If you
1176 don't create a "stdio" LogFile, then stdout/stderr will be
1178 (LogObserver): implement "LogObservers", which a BuildStep can add
1179 to parse the output of a command in real-time. The primary use is
1180 to provide more useful information to the Progress code, allowing
1181 better ETA estimates.
1182 (LogLineObserver): utility subclass which feeds complete lines to
1183 the parser instead of bytes.
1184 (BuildStep.progressMetrics): this is safer as a tuple
1185 (BuildStep.setProgress): utility method, meant to be called by
1187 (BuildStep.addLogObserver): new method, to be called at any time
1188 during the BuildStep (even before any LogFiles have been created),
1189 to attach (or schedule for eventual attachment) a LogObserver to a
1191 (StdioProgressObserver): new LogObserver which replaces the old
1192 "output" progress gatherer
1193 (LoggingBuildStep.__init__): same
1194 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1195 (LoggingBuildStep._commandComplete): must use logs['stdio']
1196 instead of the old single ".log" attribute.
1197 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1198 functionality, now subsumed into StdioProgressObserver
1199 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1200 log name changed from "output" to "stdio".
1203 * buildbot/interfaces.py (ILogFile): add the Interface used from
1204 the BuildStep towards the LogFile
1205 (ILogObserver): and the one provided by a LogObserver
1206 * buildbot/status/builder.py (LogFile): implement it
1208 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1209 HEADER constants here ..
1210 * buildbot/status/builder.py (STDOUT): .. from here
1212 2006-06-13 Brian Warner <warner@lothar.com>
1214 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1215 compatibility with python2.2, which doesn't have the 'substr in
1217 (TestP4Poller.makeTime): utility function to construct the
1218 timestamp using the same strptime() approach as p4poller does. It
1219 turns out that time.mktime() behaves slightly differently under
1220 python2.2, probably something to do with the DST flag, and that
1221 causes the test to fail under python2.2. (changing the mktime()
1222 arguments to have dst=0 instead of -1 caused it to fail under
1223 python2.3. Go figure.)
1224 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1226 2006-06-12 Brian Warner <warner@lothar.com>
1228 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1229 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1230 contributing such an excellent patch, including docs and unit
1231 tests! This makes it *so* much easier to apply. I had to update
1232 test_vc.py to handle some recent refactorings, but everything else
1233 applied smoothly. The only remaining thing I'd like to fix would
1234 be to remove the hard-wired port 1666 used by p4d, and allow it to
1235 claim any unused port. This would allow two copies of the test
1236 suite to run on the same host at the same time, as well as
1237 allowing the test suite to run while a real (production) p4d was
1238 running on the same host. Oh, and maybe we should add a warning to
1239 step.P4 that gets emitted if the slave is too old to provide the
1240 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1241 * buildbot/slave/commands.py (P4): same
1242 (P4Sync): same, some minor updates
1243 * buildbot/changes/p4poller.py: same
1244 * docs/buildbot.texinfo: same
1245 * buildbot/test/test_p4poller.py: same
1246 * buildbot/test/test_vc.py (P4): same
1248 * setup.py: add Trove classifiers for PyPI
1250 2006-06-08 Brian Warner <warner@allmydata.com>
1252 * buildbot/status/client.py
1253 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1254 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1255 build needs to be IRemote'd separately, rather than IRemote'ing
1256 the whole list at once. I can't wait until newpb's serialization
1257 adapters make this unnecessary.
1259 2006-06-06 Brian Warner <warner@lothar.com>
1261 * buildbot/process/step.py (WithProperties): make this inherit
1262 from ComparableMixin, so that reloading an unchanged config file
1263 doesn't cause us to spuriously reload any Builders which use them.
1264 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1267 2006-06-03 Brian Warner <warner@lothar.com>
1269 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1270 running py2exe on windows, contributed by Mark Hammond. Addresses
1271 SF#1401121, but I think we still need to include
1272 buildbot/scripts/sample.cfg
1273 * setup.py: include buildbot_service.py as a script under windows
1274 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1275 a py2exe application), get the icon/css datafiles from a different
1278 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1279 double-escape the build URL. Thanks to Olivier Bonnet for the
1280 patch. Fixes SF#1452801.
1282 2006-06-02 Brian Warner <warner@lothar.com>
1284 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1285 first six columns of 'svnlook' output, not just the first column,
1286 since property changes appear in the other five. Thanks to Olivier
1287 Bonnet for the patch. Fixes SF#1398174.
1289 2006-06-01 Brian Warner <warner@lothar.com>
1291 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1292 the fake build, so that title= has something to be set to
1294 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1295 attribute of the "Build #NN" link in the yellow start-the-build
1296 box to the build's reason. This means that you get a little
1297 tooltip explaining why the build was done when you hover over the
1298 yellow box. Thanks to Zandr Milewski for the suggestion.
1300 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1301 (Box.setETA): handle ETA=None (by stopping the timer)
1302 (Box.update): make the [soon] text less different than the usual
1303 text, so the rest of the text doesn't flop around so much. It
1304 would be awfully nice to figure out how to center this stuff.
1305 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1307 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1308 by default, so that any ShellCommand which fails marks the overall
1309 build as a failure. I should have done this from the beginning.
1310 Add flunkOnFailure=False to the arguments if you want to turn off
1313 2006-05-30 Brian Warner <warner@lothar.com>
1315 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1316 last-build/current-build/current-step. Show what step is currently
1317 running. Show ETA for both the overall build and the current step.
1318 Update GTK calls to modern non-deprecated forms. There's still a
1319 lot of dead code and debug noise to remove.
1321 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1322 shows up properly in status displays
1324 2006-05-28 Brian Warner <warner@lothar.com>
1326 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1327 build we use to verify that WithProperties works:
1329 ** set flunkOnFailure=True so that build failures get noticed
1330 ** set workdir='.' so that the build succeeds, otherwise it is trying
1331 to touch 'build/something', and 'build/' doesn't exist because
1332 usually that's created by a Source step
1333 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1334 this test somehow triggers, in which the 'touch' process becomes
1335 a zombie and we wait for th etimeout before giving up on it.
1337 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1338 to log the Build results and step logs to the twisted log.
1339 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1340 what went wrong if a build was expected to succeed but didn't.
1342 * buildbot/process/step_twisted.py (Trial): set the default
1343 trialMode to '--reporter=bwverbose', which specifies verbose
1344 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1345 '-to', but those are completely missing in modern Twisteds.
1347 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1348 a localhost-only port, to encourage better security
1350 * docs/buildbot.texinfo (Change Sources): mention
1353 * .darcs-boring: add a Darcs boringfile
1355 * README (REQUIREMENTS): stop claiming compatibility with
1358 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1361 2006-05-27 Brian Warner <warner@lothar.com>
1363 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1364 * docs/buildbot.texinfo: same
1366 2006-05-23 Brian Warner <warner@lothar.com>
1368 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1369 * docs/buildbot.texinfo: set version to match
1370 * NEWS: update for 0.7.3
1372 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1373 give a quick mapping from VC system to possible ChangeSources
1374 (Build Properties): add 'buildername'
1376 * buildbot/process/base.py (Build.setupStatus): oops, set
1377 'buildername' and 'buildnumber' properties
1378 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1381 2006-05-22 Brian Warner <warner@lothar.com>
1383 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1384 property interpolation better
1386 * README (INSTALLATION): remove old '-v' argument from recommended
1389 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1390 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1393 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1394 'svnversion' instead of grepping the output of 'svn info', much
1395 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1396 Bonnet for the suggestion.
1397 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1398 require the WC_PATH argument, so run 'svnversion .' instead.
1400 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1401 aren't supposed to have 'self' in their argument list
1403 2006-05-21 Brian Warner <warner@lothar.com>
1405 * buildbot/process/step.py (ShellCommand.start): make
1406 testInterpolate pass. I was passing the uninterpolated command to
1407 the RemoteShellCommand constructor
1408 (ShellCommand._interpolateProperties): oops, handle non-list
1409 commands (i.e. strings with multiple words separated by spaces in
1410 them) properly, instead of forgetting about them.
1412 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1413 to actually try to use build properties in a real build. This test
1415 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1416 to start and evaluate builds
1418 * buildbot/test/test__versions.py: add a pseudo-test to record
1419 what version of Twisted/Python/Buildbot are running. This should
1420 show up at the beginning of _trial_tmp/test.log, and exists to help
1421 debug other problems.
1423 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1424 a filename to be served as 'robots.txt' to discourage web spiders.
1425 Adapted from a patch by Tobi Vollebregt, thanks!
1426 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1427 (Waterfall.test_waterfall): tweak the way that filenames are put
1428 into the config file, to accomodate windows pathnames better.
1430 * docs/buildbot.texinfo (HTML Waterfall): document it
1432 * buildbot/process/process_twisted.py
1433 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1434 changed the build process. The new setup.py no longer takes the
1436 (FullTwistedBuildFactory.__init__): same
1437 (TwistedReactorsBuildFactory.__init__): same
1439 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1440 be placed in the [hooks] section of the central repository (the
1441 one that everybody pushes changes to).
1443 2006-05-20 Brian Warner <warner@lothar.com>
1445 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1446 .darcs-context file, use binary mode. I think this was causing a
1447 Darcs failure under windows.
1449 2006-05-19 Brian Warner <warner@lothar.com>
1451 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1452 use a timezone string of +0000 and gmtime, since this timestamp is
1453 sent to a buildmaster and %z is broken.
1455 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1456 string and localtime, since this timestamp will only be consumed
1457 locally, and %z is broken.
1459 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1460 gmtime, since this timestamp is returned to the buildmaster, and
1463 2006-05-18 Brian Warner <warner@lothar.com>
1465 * NEWS: update in preparation for next release
1467 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1468 setup-repository and do-we-have-the-vc-tools code into a separate
1469 "helper" class, which sticks around in a single module-level
1470 object. This seems more likely to continue to work in the future
1471 than having it hide in the TestCase and hope that TestCases stick
1472 around for a long time.
1474 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1475 addremove' has been deprecated in recent versions of mercurial, so
1476 use 'hg add' instead
1478 2006-05-07 Brian Warner <warner@lothar.com>
1480 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1481 operating under windows, move the file before opening it, since
1482 you can't rename a file that somebody has open.
1484 * buildbot/process/base.py (Build.setupBuild): if something goes
1485 wrong while creating a Step, log the name and arguments, since the
1486 error message when you get the number of arguments wrong is really
1489 2006-05-06 Brian Warner <warner@lothar.com>
1491 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1492 bugs in twisted-specific code not covered by my unit tests, this
1493 time use 'cmd' argument instead of self.cmd
1495 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1496 fix stupid braino: either use startwith or find()==0, not both.
1497 (TwistedReactorsBuildFactory.__init__): another dumb typo
1499 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1500 mark this test as TODO under windows, since process-killing seems
1501 dodgy there. We'll come back to this later and try to fix it
1504 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1505 and don't include a timezone
1506 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1507 This should avoid the windows-with-verbose-timezone-name problem
1509 (Patch.testPatch): add a test which runs 'patch' with less
1510 overhead than the full VCBase.do_patch sequence, to try to isolate
1511 a windows test failure. This one uses slave.commands.ShellCommand
1512 and 'patch', but none of the VC code.
1514 * buildbot/slave/commands.py (getCommand): use which() to find the
1515 executables for 'cvs', 'svn', etc. This ought to help under
1518 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1519 working directory before starting. If an earlier test failed, the
1520 leftover directory would mistakenly flunk a later test.
1521 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1522 Make sure that we use the right commandlines if which("tla") picks
1523 up "tla.exe" (as it does under windows).
1524 (TlaSupport.do_get): factor out this tla-vs-baz difference
1525 (TlaSupport.vc_create): more tla-vs-baz differences
1527 * buildbot/test/test_slavecommand.py
1528 (ShellBase.testShellMissingCommand): stop trying to assert
1529 anything about the error message: different shells on different
1530 OSes with different languages makes it hard, and it really isn't
1531 that interesting of a thing to test anyway.
1533 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1534 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1535 "Panther"), because it has a bug which flunks a couple tests in
1536 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1537 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1538 able to test that yet.
1540 2006-04-30 Brian Warner <warner@lothar.com>
1542 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1543 make sure child commands emit messages in english, so our regexps
1544 will match. Thanks to Nikaus Giger for identifying the problems.
1545 (VCBase._do_vctest_export_1): mode="export" is not responsible
1546 for setting the "got_revision" property, since in many cases it is
1547 not convenient to determine.
1548 (SVNSupport.capable): when running 'svn --version' to check for
1549 ra_local, we want error messages in english
1550 * buildbot/test/test_slavecommand.py
1551 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1552 to emit the error message in english
1554 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1555 the environment with $LC_ALL="C" so that Commands which need to
1556 parse the output of their child processes can obtain it in
1558 (SVN.parseGotRevision): call "svn info" afterwards instead of
1559 watching the output of the "svn update" or "svn checkout".
1560 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1561 (Arch.parseGotRevision): same
1562 (Bazaar.parseGotRevision): same
1563 (Mercurial.parseGotRevision): same
1565 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1566 $LC_ALL="C" when running commands under 'buildbot try', too
1568 * buildbot/test/__init__.py: remove the global os.environ()
1569 setting, instead we do it just for the tests that run commands and
1570 need to parse their output.
1572 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1573 remove the overly-short .timeout on this test, because non-DNotify
1574 platforms must fall back to polling which happens at 10 second
1575 intervals, so a 5 second timeout would never succeed.
1577 2006-04-24 Brian Warner <warner@lothar.com>
1579 * docs/buildbot.texinfo (Installing the code): update trial
1580 invocation, SF#1469116 by Niklaus Giger.
1581 (Attributes of Changes): updated branch-name examples to be
1582 a bit more realistic, SF#1475240 by Stephen Davis.
1584 * contrib/windows/buildbot2.bat: utility wrapper for windows
1585 developers, contributed by Nick Trout (after a year of neglect..
1586 sorry!). SF#1194231.
1588 * buildbot/test/test_vc.py (*.capable): store the actual VC
1589 binary's pathname in VCS[vcname], so it can be retrieved later
1590 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1591 strip out non-numeric timezone information, specifically the funky
1592 German string that his system produced that confuses CVS.
1593 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1594 allow Darcs tests to work on windows
1595 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1596 procutils.which() everywhere, to allow tryclient to work under
1597 windows. Also from Niklaus Giger, SF#1463394.
1599 * buildbot/twcompat.py (which): move the replacement for a missing
1600 twisted.python.procutils.which from test_vc.py to here, so it can
1601 be used in other places too (specifically tryclient.py)
1603 2006-04-23 Brian Warner <warner@lothar.com>
1605 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1606 bare buildbotURL/projectName line with a proper DIV, along with a
1607 CSS class of "title", from Stefan Seefeld (SF#1461675).
1608 (WaterfallStatusResource.body0): remove the redundant 'table'
1609 class from the table
1610 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1611 to the top-row TR, and class="Activity" to the second-row TR,
1612 rather than putting them in the individual TD nodes.
1614 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1615 'got_revision' build property for all VC systems that implement
1616 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1618 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1619 to determine which revision we actually obtained
1620 (CVS.parseGotRevision): implement this for CVS, which just means
1621 to grab a timestamp. Not ideal, and it depends upon the buildslave
1622 having a clock that is reasonably well syncronized with the server,
1623 but it's better than nothing.
1624 (SVN.parseGotRevision): implement it for SVN, which is accurate
1625 (Darcs.parseGotRevision): same
1626 (Arch.parseGotRevision): same
1627 (Bazaar.parseGotRevision): same
1628 (Mercurial.parseGotRevision): same
1630 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1631 keep a record of all non-stdout/stderr/header/rc status updates,
1632 for the benefit of RemoteCommands that send other useful things,
1634 (Source.commandComplete): put any 'got_revision' status values
1635 into a build property of the same name
1638 * buildbot/process/step_twisted.py (Trial): update to deal with
1639 new ShellCommand refactoring
1641 * docs/buildbot.texinfo (Build Properties): document new feature
1642 that allows BuildSteps to get/set Build-wide properties like which
1643 revision was requested and/or checked out.
1645 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1646 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1647 it. Note that this bumps the persistenceVersion of the saved Build
1648 object, so add the necessary upgrade-old-version logic to include
1649 an empty properties dict.
1651 * buildbot/process/base.py (Build.setProperty): implement it
1652 (Build.getProperty): same
1653 (Build.startBuild): change build startup to set 'branch',
1654 'revision', and 'slavename' properties at the right time
1656 * buildbot/process/step.py (BuildStep.__init__): change setup to
1657 require 'build' argument in a better way
1658 (LoggingBuildStep): split ShellCommand into two pieces, for better
1659 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1660 a single RemoteCommand that sends stdout/stderr status text. It
1661 also provides the usual commandComplete / createSummary /
1662 evaluateCommand / getText methods to be overridden...
1663 (ShellCommand): .. whereas ShellCommand is specifically for
1664 running RemoteShellCommands. Other shell-like BuildSteps (like
1665 Source) can inherit from LoggingBuildStep instead of ShellCommand
1666 (WithProperties): marker class to do build-property interpolation
1667 (Source): inherit from LoggingBuildStep instead of ShellCommand
1670 * buildbot/test/test_properties.py: test new functionality
1672 2006-04-21 Brian Warner <warner@lothar.com>
1674 * buildbot/test/test_vc.py: rename testBranch to
1675 testCheckoutBranch to keep the tests in about the right
1678 2006-04-18 Brian Warner <warner@lothar.com>
1680 * docs/buildbot.texinfo (PBListener): improve cross-references
1681 between PBListener and 'buildbot statusgui', thanks to John Pye
1684 2006-04-17 Brian Warner <warner@lothar.com>
1686 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1687 running under Twisted-1.3.0, otherwise skipped tests are reported
1690 * all: use isinstance() instead of 'type(x) is foo', suggested by
1693 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1694 oops, fix a brain-fade from the other week, when making the
1695 addStep changes. I changed all the __init__ upcalls to use the
1696 wrong superclass name.
1697 (FullTwistedBuildFactory.__init__): same
1698 (TwistedDebsBuildFactory.__init__): same
1699 (TwistedReactorsBuildFactory.__init__): same
1700 (TwistedBuild.isFileImportant): use .startswith for clarity,
1701 thanks to Neal Norwitz for the suggestions.
1703 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1704 changes, then deliver them over PB to a remote buildmaster.
1706 * contrib/svnpoller.py: added script by John Pye to poll a remote
1707 SVN repository (by running 'svn log') from a cronjob, and run
1708 'buildbot sendchange' to deliver the changes to a remote
1710 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1711 modification of svnpoller.py), same purpose, but this one loops
1712 internally (rather than expecting to run from a cronjob) and works
1714 * contrib/README.txt: same
1716 2006-04-11 Brian Warner <warner@lothar.com>
1718 * all: fix a number of incorrect names and missing imports, thanks
1719 to Anthony Baxter for the patch.
1720 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1721 remove unused buggy method.
1722 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1723 comes from shutil, not "shutils"
1724 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1725 (Arch.checkSlaveVersion): same
1726 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1728 * buildbot/process/step_twisted2.py: add some missing imports
1729 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1730 this code used to live in twisted.internet.defer
1732 2006-04-10 Brian Warner <warner@lothar.com>
1734 * buildbot/process/step.py (Mercurial): add Mercurial support
1735 * buildbot/slave/commands.py (Mercurial): same
1736 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1737 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1738 not yet tested, but 'try' support *is* covered
1739 * docs/buildbot.texinfo (Mercurial): document it
1741 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1742 some debugging messages (turned off)
1743 * buildbot/test/test_vc.py: improve debug messages
1745 2006-04-07 Brian Warner <warner@lothar.com>
1747 * buildbot/test/test_vc.py (which): define our own which() in case
1748 we can't import twisted.python.procutils, because procutils doesn't
1749 exist in Twisted-1.3
1751 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1752 of SlaveLocks for performance tests
1754 * docs/examples/twisted_master.cfg: update to match current usage
1756 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1757 password, p4 binary, pollinterval, maximum history to check.
1758 Patch from an anonymous sf.net contributor, SF#1219384.
1759 * buildbot/process/step.py (P4Sync.__init__): add username,
1760 password, and client arguments.
1761 * buildbot/slave/commands.py (P4Sync): same
1763 2006-04-05 Brian Warner <warner@lothar.com>
1765 * buildbot/process/factory.py (BuildFactory.addStep): new method
1766 to add steps to a BuildFactory. Use it instead of f.steps.append,
1767 and you can probably avoid using the s() convenience function.
1768 Patch from Neal Norwitz, sf.net #1412605.
1769 (other): update all factories to use addStep
1770 * buildbot/process/process_twisted.py: update all factories to use
1773 2006-04-03 Brian Warner <warner@lothar.com>
1775 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1776 work under windows too. Adapted from a patch by Niklaus Giger,
1777 addresses SF#1463399.
1779 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1780 spawned commands emit parseable results in english and not some
1781 other language. Patch from Niklaus Giger, SF#1463395.
1783 * README (INSTALLATION): discourage users from running unit tests on
1784 a "network drive", patch from Niklaus Giger, SF#1463394.
1786 2006-03-22 Brian Warner <warner@lothar.com>
1788 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1789 function to turn a repository-relative pathname into a (branch,
1790 branch-relative-filename) tuple. Change this function to handle
1791 the branch naming policy used by your Subversion repository.
1792 Thanks to AllMyData.com for sponsoring this work.
1794 2006-03-16 Brian Warner <warner@lothar.com>
1796 * buildbot/scripts/sample.cfg: add python-mode declaration for
1797 vim. Thanks to John Pye for the patch.
1799 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1800 command line, mention the importance of running 'crontab' as the
1801 buildmaster/buildslave user. Thanks to John Pye for the catch.
1803 2006-03-13 Brian Warner <warner@lothar.com>
1805 * buildbot/status/words.py (IRC): add an optional password=
1806 argument, which will be sent to Nickserv in an IDENTIFY message at
1807 login, to claim the nickname. freenode requires this before the
1808 bot can sent (or reply to) private messages. Thanks to Clement
1809 Stenac for the patch.
1810 * docs/buildbot.texinfo (IRC Bot): document it
1812 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1813 larger than chunkSize. Fixes SF#1349253.
1814 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1815 (Log.testConsumer): update to match new internal chunking behavior
1817 2006-03-12 Brian Warner <warner@lothar.com>
1819 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1821 * buildbot/test/test_maildir.py (MaildirTest): rename the
1822 'timeout' method, as it collides with trial's internals
1824 * buildbot/scripts/runner.py: add 'buildbot restart' command
1825 (stop): don't sys.exit() out of here, otherwise restart can't work
1826 * docs/buildbot.texinfo (Shutdown): document it
1828 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1829 * buildbot/status/html.py (Waterfall.__init__): same
1830 * buildbot/process/builder.py (Builder.startBuild): same
1831 * buildbot/process/base.py (BuildRequest): same
1832 * buildbot/sourcestamp.py (SourceStamp): same
1833 * buildbot/scheduler.py (Nightly): same
1835 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1837 * docs/buildbot.texinfo: same
1839 2006-02-17 Brian Warner <warner@lothar.com>
1841 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1842 * docs/buildbot.texinfo: set version number to match
1843 * NEWS: update for 0.7.2
1845 2006-02-16 Brian Warner <warner@lothar.com>
1847 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1849 2006-02-09 Brian Warner <warner@lothar.com>
1851 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1852 add text to explain per-build branch parameters
1853 * NEWS: mention --umask
1855 2006-02-08 Brian Warner <warner@lothar.com>
1857 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1859 (SlaveOptions.optParameters): add --umask, to make it possible to
1860 make buildslave-generated files (including build products) be
1863 * buildbot/slave/bot.py (BuildSlave.startService): same
1865 2006-01-23 Brian Warner <warner@lothar.com>
1867 * buildbot/status/builder.py: urllib.quote() all URLs that include
1868 Builder names, so that builders can include characters like '/'
1869 and ' ' without completely breaking the resulting HTML. Thanks to
1870 Kevin Turner for the patch.
1871 * buildbot/status/html.py: same
1872 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1874 * NEWS: update in preparation for upcoming release
1876 2006-01-18 Brian Warner <warner@lothar.com>
1878 * docs/examples/twisted_master.cfg: update to match the Twisted
1879 buildbot: remove python2.2, switch to exarkun's buildslaves,
1880 disable the .deb builder until we figure out how to build twisted
1881 .debs from SVN, add some ktrace debugging to the OS-X build
1882 process and remove the qt build, remove threadless builders,
1883 change freebsd builder to use landonf's buildslave.
1885 2006-01-12 Brian Warner <warner@lothar.com>
1887 * buildbot/master.py (Manhole.__init__): let port= be a strports
1888 specification string, but handle a regular int for backwards
1889 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1890 used in master.cfg to limit connections to just the local host.
1891 (BuildMaster.loadConfig): same for c['slavePortnum']
1892 * buildbot/scheduler.py (Try_Userpass.__init__): same
1893 * buildbot/status/client.py (PBListener.__init__): same
1894 * buildbot/status/html.py (Waterfall.__init__): same, for both
1895 http_port and distrib_port. Include backwards-compatibility checks
1896 so distrib_port can be a filename string and still mean unix:/foo
1897 * docs/buildbot.texinfo (Setting the slaveport): document it
1898 (Debug options): same
1899 (HTML Waterfall): same
1902 * buildbot/test/test_config.py (ConfigTest): test it
1904 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1905 slaveport's disownServiceParent deferred to fire before opening
1906 the new one. Fixes an annoying bug in the unit tests.
1908 2006-01-03 Brian Warner <warner@lothar.com>
1910 * buildbot/master.py (BuildMaster): remove the .schedulers
1911 attribute, replacing it with an allSchedulers() method that looks
1912 for all IService children that implement IScheduler. Having only
1913 one parent/child relationship means fewer opportunities for bugs.
1914 (BuildMaster.allSchedulers): new method
1915 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1916 also fix ugly bug that caused any config-file reload to
1917 half-forget about the earlier Schedulers, causing an exception
1918 when a Change arrived and was handed to a half-connected
1919 Scheduler. The exception was in scheduler.py line 54ish:
1920 self.parent.submitBuildSet(bs)
1921 exceptions.AttributeError: 'NoneType' object has no attribute
1923 (BuildMaster.addChange): update to use allSchedulers()
1925 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1926 to work properly with twisted-1.3.0, where you must explicitly
1927 include the __implements__ from parent classes
1928 (BaseScheduler.__repr__): make it easier to distinguish distinct
1930 (BaseUpstreamScheduler.__implements__): same
1932 * buildbot/status/builder.py (Status.getSchedulers): update to
1934 * buildbot/test/test_run.py (Run.testMaster): same
1935 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1936 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1937 make sure Scheduler instances are left alone when an identical
1938 config file is reloaded
1939 (ConfigElements.testSchedulers): make sure Schedulers are properly
1942 * Makefile (TRIALARGS): my local default Twisted version is now
1943 2.1.0, update the trial arguments accordingly
1945 2005-12-22 Brian Warner <warner@lothar.com>
1947 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1950 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1951 addChange in the parent class, although I suspect this should be
1952 fixed better in the future.
1954 2005-11-26 Brian Warner <warner@lothar.com>
1956 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1957 explode when branch==None, thanks to Kevin Turner for the catch
1958 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1961 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1963 * docs/buildbot.texinfo: same
1965 2005-11-26 Brian Warner <warner@lothar.com>
1967 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1968 * docs/buildbot.texinfo: set version number to match
1970 2005-11-26 Brian Warner <warner@lothar.com>
1972 * NEWS: update for 0.7.1
1974 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1975 sure that unsubscribe works even if we never sent an ETA update.
1976 Also, don't explode on duplicate unsubscribe.
1977 (BuildStepStatus.addLog): make the convenience "return self"-added
1978 watcher automatically unsubscribe when the Step finishes.
1979 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1980 (BuildStatus.stepStarted): same auto-unsubscribe
1981 (BuilderStatus.buildStarted): same auto-unsubscribe
1983 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1985 (IStatusReceiver.stepStarted): same
1986 (IStatusReceiver.logStarted): same
1988 * buildbot/test/test_run.py (Status): move the Status test..
1989 * buildbot/test/test_status.py (Subscription): .. to here
1991 2005-11-25 Brian Warner <warner@lothar.com>
1993 * NEWS: more updates
1995 * buildbot/locks.py: fix the problem in which loading a master.cfg
1996 file that changes some Builders (but not all of them) can result
1997 in having multiple copies of the same Lock. Now, the real Locks
1998 are kept in a table inside the BotMaster, and the Builders/Steps
1999 use "LockIDs", which are still instances of MasterLock and
2000 SlaveLock. The real Locks are instances of the new RealMasterLock
2001 and RealSlaveLock classes.
2002 * buildbot/master.py (BotMaster.getLockByID): new method to
2003 convert LockIDs into real Locks.
2004 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2005 into real Locks before building
2006 * buildbot/process/step.py (BuildStep.startStep): same
2007 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2008 exercises the problem
2011 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2012 what Schedulers are available
2014 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2015 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2016 'cron'-style build scheduling at certain times of day, week,
2018 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2020 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2021 handling: treat self.fileIsImportant more as an attribute that
2022 contains a callable than as a method. If the attribute is None,
2023 don't call it and assume all filenames are important. It is still
2024 possible to provide a fileIsImportant method in a subclass,
2026 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2028 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2029 test using AnyBranchScheduler with fileIsImportant=None
2031 2005-11-24 Brian Warner <warner@lothar.com>
2033 * buildbot/test/test_config.py (StartService): don't claim a fixed
2034 port number, instead set slavePort=0 on the first pass, figure out
2035 what port was allocated, then switch to a config file that uses
2038 * buildbot/master.py (BuildMaster.loadConfig): close the old
2039 slaveport before opening the new one, because unit tests might
2040 replace slavePort=0 with the same allocated portnumber, and if we
2041 don't wait for the old port to close first, we get a "port already
2042 in use" error. There is a tiny race condition here, but the only
2043 threat is from other programs that bind (statically) to the same
2044 port number we happened to be allocated, and only if those
2045 programs use SO_REUSEADDR, and only if they get control in between
2048 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2050 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2051 deleted ChangeSources before adding any new ones
2052 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2053 compare_attrs, to make sure that a config-file reload does not
2054 unnecessarily replace an unmodified ChangeSource instance
2055 * buildbot/test/test_config.py (ConfigTest.testSources): update
2057 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2058 mean "don't build anything", and add a warning if it gets used
2059 because it isn't actually useful.
2061 * contrib/svn_buildbot.py: update example usage to match the port
2062 number that gets used by the PBChangeSource
2063 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2065 2005-11-22 Brian Warner <warner@lothar.com>
2067 * NEWS: start collecting items for next release
2069 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2070 revisions are strings
2071 (P4Sync.computeSourceRevision): same
2073 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2074 to the Buildbot's overall status page
2075 (StatusResourceBuilder.body): same
2077 2005-11-15 Brian Warner <warner@lothar.com>
2079 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2080 config-file loading, specifically to make sure old StatusTargets
2081 are finished shutting down before new ones start up (thus
2082 resolving a bug in which changing the Waterfall object would fail
2083 because both new and old instances were claiming the same
2084 listening port). Also load new Schedulers after all the new
2085 Builders are set up, in case they fire off a new build right away.
2086 * buildbot/test/test_config.py (StartService): test it
2088 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2089 the branch name to the mail body
2091 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2092 Without it, a config-file reload fails to update an existing
2094 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2095 username/passwd to compare_attrs, for the same reason
2096 * buildbot/status/html.py (Waterfall): add favicon to
2097 compare_attrs, same reason
2099 2005-11-05 Brian Warner <warner@lothar.com>
2101 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2102 baserev before stuffing it in the jobfile. This resolves problems
2103 under SVN (and probably Arch) where revisions are expressed as
2104 numbers. I'm inclined to use string-based revisions everywhere in
2105 the future, but this fix should be safe for now. Thanks to Steven
2106 Walter for the patch.
2108 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2109 binary mode when opening pickle files, to make windows work
2110 better. Thanks to Dobes Vandermeer for the catch.
2111 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2112 (BuilderStatus.getBuildByNumber): same
2113 (Status.builderAdded): same
2114 * buildbot/master.py (BuildMaster.loadChanges): same
2116 * buildbot/util.py (Swappable): delete unused leftover code
2118 * buildbot/process/step.py (SVN): when building on a non-default
2119 branch, add the word "[branch]" to the VC step's description, so
2120 it is obvious that we're not building the usual stuff. Likewise,
2121 when we are building a specific revision, add the text "rNNN" to
2122 indicate what that revision number is. Thanks to Brad Hards and
2123 Nathaniel Smith for the suggestion.
2124 (Darcs.startVC): same
2125 (Arch.startVC): same
2126 (Bazaar.startVC): same
2128 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2129 typo, caught by Mark Dillavou, closes SF#1216636.
2131 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2132 about a test to add some day
2134 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2135 the 'full-2.3' build, and the 'reactors' build is now run under
2136 python-2.4 because the buildslave no longer has gtk/etc bindings
2137 for earlier versions.
2139 2005-11-03 Brian Warner <warner@lothar.com>
2141 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2142 method, takes an IBuildStatus and rebuilds it. It might make more
2143 sense to add this to IBuildControl instead, but that instance goes
2144 away completely once the build has finished, and resubmitting
2145 builds can take place weeks later.
2146 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2147 * buildbot/status/html.py (StatusResourceBuild): also stash an
2148 IBuilderControl so we can use resubmitBuild.
2149 (StatusResourceBuild.body): render "resubmit" button if we can.
2150 Also add hrefs for each BuildStep
2151 (StatusResourceBuild.rebuild): add action for "resubmit" button
2152 (StatusResourceBuilder.getChild): give it an IBuilderControl
2154 * buildbot/status/builder.py (Status.getURLForThing): change the
2155 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2156 that live as targets of buttons like "stop" and "rebuild" can't
2158 * buildbot/status/builder.py (Status.getURLForThing): same
2159 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2160 (StepBox.getBox): same
2161 * buildbot/test/test_web.py (GetURL): same
2164 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2165 exclusivity checks after Source.__init__ upcall, so misspelled
2166 arguments will be reported more usefully
2167 (Darcs.__init__): same
2169 2005-10-29 Brian Warner <warner@lothar.com>
2171 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2172 builder. Move the Try scheduler off to a separate port.
2174 2005-10-27 Brian Warner <warner@lothar.com>
2176 * buildbot/clients/gtkPanes.py
2177 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2178 to cause the app to crash, now they don't.
2180 * buildbot/clients/debug.py: display the buildmaster's location
2181 in the window's title bar
2183 2005-10-26 Brian Warner <warner@lothar.com>
2185 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2186 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2187 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2189 * buildbot/status/html.py (td): put a single non-breaking space
2190 inside otherwise empty <td> elements, as a workaround for buggy
2191 browsers which would optimize them away (along with any associated
2192 styles, like the kind that create the waterfall grid borders).
2193 Patch from Frerich Raabe.
2195 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2196 argv-list as an argument, defaulting to ["-to"], which is
2197 appropriate for the Trial that comes with Twisted-2.1.0 and
2198 earlier. The Trial in current Twisted SVN wants
2199 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2200 defaults to an empty list.
2201 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2202 match it, now that trialMode= is a list instead of a single string
2204 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2206 * docs/buildbot.texinfo: same
2208 2005-10-24 Brian Warner <warner@lothar.com>
2210 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2211 * docs/buildbot.texinfo: set version number to match
2213 2005-10-24 Brian Warner <warner@lothar.com>
2215 * README: update for 0.7.0
2217 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2219 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2220 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2221 send the branch= argument unless the user really provided one, to
2222 retain compatibility with older buildmasters that don't accept
2224 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2227 * docs/buildbot.texinfo: update lots of stuff
2229 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2230 to the 'buildbot sendchange' command
2231 * buildbot/clients/sendchange.py (Sender.send): same
2232 * buildbot/changes/pb.py (ChangePerspective): same
2233 * buildbot/test/test_changes.py (Sender.testSender): test it
2235 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2236 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2237 for consistency with other BuildStep arguments that use camelCase.
2238 Well, at least more of them use camelCase (like flunkOnWarnings)
2239 than don't.. I wish I'd picked one style and stuck with it
2240 earlier. Annoying, but it's best done before the release, since
2241 these arguments didn't exist at all in 0.6.6 .
2243 * buildbot/test/test_vc.py (SVN.testCheckout): same
2244 (Darcs.testPatch): same
2245 * docs/buildbot.texinfo (SVN): document the change
2246 (Darcs): same, add some build-on-branch docs
2247 * docs/examples/twisted_master.cfg: match change
2249 * buildbot/process/step.py (BuildStep): rename
2250 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2251 how it is normally used.
2252 * buildbot/test/test_steps.py (Version.checkCompare): same
2254 * buildbot/process/step.py (CVS.startVC): refuse to build
2255 update/copy -style builds on a non-default branch with an old
2256 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2257 concern is that it will do a VC 'update' in an existing tree when
2258 it is supposed to be switching branches (and therefore clobbering
2259 the tree to do a full checkout), thus building the wrong source.
2260 This used to be a warning, but I think the confusion it is likely
2261 to cause warrants making it an error.
2262 (SVN.startVC): same, also make mode=export on old slaves an error
2263 (Darcs.startVC): same
2264 (Git.startVC): improve error message for non-Git-enabled slaves
2265 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2266 specific revision is built on a slave that doesn't pay attention
2267 to args['revision'], because for slowly-changing trees it will
2268 probably do the right thing, and because we have no way to tell
2269 whether we're asking it to build the most recent version or not.
2270 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2272 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2273 that 'master' is in host:portnum format, to catch errors sooner
2275 2005-10-23 Brian Warner <warner@lothar.com>
2277 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2278 when creating the list of warning messages, include the line
2279 immediately after each WARNING: line, since that's usually where
2280 the file and line number wind up.
2282 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2287 2005-10-22 Brian Warner <warner@lothar.com>
2289 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2290 patch from Brad Hards
2291 * buildbot/status/classic.css: same
2292 * buildbot/test/test_web.py (Waterfall): match changes
2294 * buildbot/test/test_steps.py (BuildStep.setUp): set
2295 nextBuildNumber so the test passes
2296 * buildbot/test/test_status.py (MyBuilder): same
2298 * buildbot/status/html.py (StatusResourceBuild.body): revision
2299 might be numeric, so stringify it before html-escapifying it
2300 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2301 timer for the upcoming build
2302 * buildbot/status/classic.css: add background-color attributes for
2303 offline/waiting/building classes
2305 * buildbot/status/builder.py (BuildStatus): derive from
2306 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2307 the default (i.e. unknown) .slavename to "???" instead of None,
2308 since even unknown slavenames need to be printed eventually.
2309 (BuilderStatus): also derive from styles.Versioned . More
2310 importantly, determine .nextBuildNumber at creation/unpickling
2311 time by scanning the directory of saved BuildStatus instances and
2312 choosing one larger than the highest-numbered one found. This
2313 should fix the problem where random errors during upgrades cause
2314 the buildbot to forget about earlier builds. .nextBuildNumber is
2315 no longer stored in the pickle.
2316 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2317 at least log the error. Also call Builder.determineNextBuildNumber
2318 once the basedir is set.
2320 * buildbot/master.py (BuildMaster.loadChanges): do
2321 styles.doUpgrade afterwards, in case I decide to make Changes
2322 derived from styles.Versioned some day and forget to make this
2326 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2327 when running under older pythons (<2.3) in which the shlex module
2328 doesn't have a 'split' function.
2330 * buildbot/process/step.py (ShellCommand.start): make
2331 errorMessages= be a list of strings to stuff in the log before the
2332 command actually starts. This makes it easier to flag multiple
2333 warning messages, e.g. when the Source steps have to deal with an
2335 (CVS.startVC): handle slaves that don't handle multiple branches
2336 by switching into 'clobber' mode
2337 (SVN.startVC): same. Also reject branches without base_url
2338 (Darcs.startVC): same. Also reject revision= in older slaves
2339 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2340 (Bazaar.startVC): same, and test for baz separately than for arch
2342 * buildbot/slave/commands.py (cvs_ver): document new features
2344 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2345 (BuildStep.slaveVersionNewEnough): more useful utility method
2346 * buildbot/test/test_steps.py (Version): start testing it
2348 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2349 the 'force' command requires python2.3, for the shlex.split method
2351 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2352 since we don't use it anymore. The Twisted buildbot uses a
2355 2005-10-21 Brian Warner <warner@lothar.com>
2357 * buildbot/process/process_twisted.py: rework all BuildFactory
2358 classes to take a 'source' step as an argument, instead of
2359 building up the SVN instance in the factory.
2360 * docs/examples/twisted_master.cfg: enable build-on-branch by
2361 providing a base_url and default_branch
2363 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2364 control over --branch and --revision, not that they are always
2366 * buildbot/status/html.py (StatusResourceBuilder.force): same
2367 (StatusResourceBuild.body): display SourceStamp components
2369 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2370 IRC 'force' command, so it can be shared with an eventual
2371 command-line-tool 'buildbot force' mode.
2372 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2374 2005-10-20 Brian Warner <warner@lothar.com>
2376 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2378 * docs/examples/twisted_master.cfg: update to use Schedulers
2380 * buildbot/scripts/sample.cfg: update with Schedulers
2382 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2383 method specifically for use by HTML "force build" button and the
2384 IRC "force" command. Raises an immediate error if there are no
2386 (IBuilderControl.requestBuild): make this just submit a build, not
2387 try to check for existing slaves or set up any when-finished
2388 Deferreds or anything.
2389 * buildbot/process/builder.py (BuilderControl): same
2390 * buildbot/status/html.py (StatusResourceBuilder.force): same
2391 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2392 * buildbot/test/test_slaves.py: same
2393 * buildbot/test/test_web.py: same
2395 2005-10-19 Brian Warner <warner@lothar.com>
2397 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2398 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2400 2005-10-18 Brian Warner <warner@lothar.com>
2402 * buildbot/status/html.py: provide 'status' argument to most
2403 StatusResourceFOO objects
2404 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2405 and Logfiles" section to make the Build page into a more-or-less
2406 comprehensive source of status information about the build
2408 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2409 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2411 2005-10-17 Brian Warner <warner@lothar.com>
2413 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2414 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2415 out what to do about other projects: the correct options for
2416 recent Twisteds will not work for older ones.
2418 2005-10-15 Brian Warner <warner@lothar.com>
2420 * buildbot/status/builder.py (Status.getURLForThing): add method
2421 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2422 use this in email/IRC status clients to make them more useful, by
2423 providing the end user with hints on where to learn more about the
2424 object being reported on.
2425 * buildbot/test/test_web.py (GetURL): tests for it
2427 2005-10-14 Brian Warner <warner@lothar.com>
2429 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2430 fix bug resulting from deferredResult changes
2432 2005-10-13 Brian Warner <warner@lothar.com>
2434 * buildbot/test/test_changes.py: remove use of deferredResult
2435 * buildbot/test/test_config.py: same
2436 * buildbot/test/test_control.py: same
2437 * buildbot/test/test_status.py: same
2438 * buildbot/test/test_vc.py: this is the only remaining use, since
2439 it gets used at module level. This needs to be replaced by some
2440 sort of class-level run-once routine.
2442 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2444 * lots: implement multiple slaves per Builder, which means multiple
2445 current builds per Builder. Some highlights:
2446 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2447 of (state,currentBuilds) instead of (state,currentBuild)
2448 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2449 (IBuildStatus.getSlavename): new method, so you can tell which
2450 slave got used. This only gets set when the build completes.
2451 (IBuildRequestStatus.getBuilds): new method
2453 * buildbot/process/builder.py (SlaveBuilder): add a .state
2454 attribute to track things like ATTACHING and IDLE and BUILDING,
2456 (Builder): .. the .slaves attribute here, which has been turned
2457 into a simple list of available slaves. Added a separate
2458 attaching_slaves list to track ones that are not yet ready for
2460 (Builder.fireTestEvent): put off the test-event callback for a
2461 reactor turn, to make tests a bit more consistent.
2462 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2463 ping fails due to an exception. This needs work, I'm worried that
2464 a code error could lead to a constantly re-connecting slave.
2465 Especially since I'm trying to move to a distinct remote_ping
2466 method, separate from the remote_print that we currently use.
2467 (BuilderControl.requestBuild): return a convenience Deferred that
2468 provides an IBuildStatus when the build finishes.
2469 (BuilderControl.ping): ping all connected slaves, only return True
2470 if they all respond.
2472 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2473 reconnect when we shut down.
2475 * buildbot/status/builder.py: implement new methods, convert
2476 one-build-at-a-time methods to handle multiple builds
2477 * buildbot/status/*.py: do the same in all default status targets
2478 * buildbot/status/html.py: report the build's slavename in the
2479 per-Build page, report all buildslaves on the per-Builder page
2481 * buildbot/test/test_run.py: update/create tests
2482 * buildbot/test/test_slaves.py: same
2483 * buildbot/test/test_scheduler.py: remove stale test
2485 * docs/buildbot.texinfo: document the new builder-specification
2486 'slavenames' parameter
2488 2005-10-12 Brian Warner <warner@lothar.com>
2490 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2491 report failure correctly, causing Dependent builds to run when
2492 they shouldn't have.
2493 * buildbot/status/builder.py (BuildSetStatus): same
2494 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2495 (Set.testSuccess): test the both-pass case too
2496 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2497 fix this test: it was ending too early, masking the failure before
2498 (Logger): specialized StatusReceiver to make sure the dependent
2499 builds aren't even started, much less completed.
2501 2005-10-07 Brian Warner <warner@lothar.com>
2503 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2504 bot.SlaveBuilder being disowned in the middle of a build
2506 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2507 this inherit from StatusReceiver. Also upcall in __init__. This
2508 fixes the embarrasing crash when the new buildSetSubmitted method
2509 is invoked and Waterfall/etc don't implement their own.
2510 * buildbot/test/test_run.py: add a TODO note about a test to catch
2511 just this sort of thing.
2513 * buildbot/process/builder.py (Builder.attached): remove the
2514 already-attached warning, this situation is normal. Add some
2515 comments explaining it.
2517 2005-10-02 Brian Warner <warner@lothar.com>
2519 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2520 OverflowError when setting up dnotify, because some 64-bit systems
2521 have problems with signed-vs-unsigned constants and trip up on the
2522 DN_MULTISHOT flag. Patch from Brad Hards.
2524 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2526 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2527 progressMetrics, description, descriptionDone to the 'parms' list,
2528 and make use the 'parms' list from the implementation class
2529 instead of only BuildStep to initialize the parameters. This
2530 allows buildbot.process.factory.s() to initialize all the parms,
2531 not just those defined in directly by BuildStep.
2533 2005-09-03 Brian Warner <warner@lothar.com>
2535 * NEWS: start adding items for the next release
2537 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2538 python2.2 tests, change 'Quick' builder to only use python2.3
2540 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2542 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2543 the "Ping Builder" button if the build control is available; the
2544 user sees an exception otherwise
2546 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2548 2005-09-01 Brian Warner <warner@lothar.com>
2550 * buildbot/interfaces.py (IBuilderStatus.getState): update
2551 signature, point out that 'build' can be None
2552 (IBuildStatus.getETA): point out ETA can be none
2554 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2556 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2558 2005-08-31 Brian Warner <warner@lothar.com>
2560 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2561 update to match correct signature: removed 'eta' argument
2562 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2564 2005-08-30 Brian Warner <warner@lothar.com>
2566 * buildbot/status/builder.py (LogFile): remove the assertion that
2567 blows up when you try to overwrite an existing logfile, instead
2568 just emit a warning. This case gets hit when the buildmaster is
2569 killed and doesn't get a chance to write out the serialized
2570 BuilderStatus object, so the .nextBuildNumber attribute gets out
2573 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2574 the 'buildbot sendchange' arguments, for the Darcs context file
2575 * docs/buildbot.texinfo (sendchange): document it
2577 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2578 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2579 (IStatus.getSchedulers): new method
2580 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2581 (Status.getSchedulers): implement
2582 * buildbot/process/builder.py (Builder): maintain
2583 BuilderStatus.pendingBuilds
2584 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2585 (TryBase.addChange): Try schedulers should ignore Changes
2587 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2588 for 'try' on CVS/SVN
2589 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2591 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2592 report status properly.
2593 (Try.createJob): implement unique buildset IDs
2595 * buildbot/status/client.py (StatusClientPerspective): add a
2596 perspective_getBuildSets method for the benefit of jobdir-style
2598 * docs/buildbot.texinfo (try): more docs
2599 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2602 2005-08-18 Brian Warner <warner@lothar.com>
2604 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2605 actually work. It's functional but still kind of clunky. Also, it
2606 only works with the pb-style.. needs to be made to work with the
2609 * buildbot/status/client.py (RemoteBuildSet): new class
2610 (RemoteBuildRequest): same
2611 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2612 object, not the internal BuildStatus object.
2613 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2614 outside of the usual buildStarted() return value.
2615 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2617 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2618 (Try_Userpass_Perspective.perspective_try): return a remotely
2619 usable BuildSetStatus object
2621 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2622 isStarted()/waitUntilStarted()
2624 2005-08-16 Brian Warner <warner@lothar.com>
2626 * buildbot/status/builder.py: implement IBuildSetStatus and
2627 IBuildRequestStatus, wire them into place.
2628 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2629 methods into the BuildSetStatus object.
2630 * buildbot/interfaces.py: same
2631 (IStatus.getBuildSets): new method to get pending BuildSets
2632 (IStatusReceiver.buildsetSubmitted): new method which hears about
2634 * buildbot/master.py (BuildMaster.submitBuildSet): same
2635 * buildbot/process/base.py (BuildRequest): same, replace
2636 waitUntilStarted with subscribe/unsubscribe
2637 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2638 subscribe instead of waitUntilStarted
2639 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2641 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2643 * buildbot/test/test_buildreq.py: update for new code
2644 * buildbot/test/test_control.py (Force.testRequest): same
2647 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2648 for Darcs to not use the tempfile module, so it works under
2649 python-2.2 too. We really didn't need the full cleverness of that
2650 module, since the slave has exclusive control of its own builddir.
2652 2005-08-15 Brian Warner <warner@lothar.com>
2654 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2655 for CVS trees. It doesn't work for non-trunk branches,
2657 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2660 * Makefile: make it easier to test against python2.2
2662 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2663 tearDown2, so things like Arch can unregister archives as they're
2664 shutting down. The previous subclass-override-tearDown technique
2665 resulted in a nested maybeWait() and test failures under
2668 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2669 where we can (Arch), add a branch= argument to set the branch used
2671 (BazExtractor): extract the branch too
2672 (TlaExtractor): same
2673 * buildbot/scripts/runner.py (TryOptions): add --branch
2674 * docs/buildbot.texinfo (try): document --branch/try_branch
2676 * buildbot/slave/commands.py (Darcs): implement get-revision for
2677 Darcs, so that 'try' will work. This requires the tempfile module
2680 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2681 of revisions, branches, and 'try' in the process.
2683 2005-08-11 Brian Warner <warner@lothar.com>
2685 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2686 this, it got broken at some point in the last few releases
2687 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2688 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2689 specifically the removal of ETA information from the tuple
2691 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2694 * docs/buildbot.texinfo (try): document both --builder and
2695 'try_builders' in .buildbot/options
2696 * buildbot/scripts/runner.py (TryOptions): add --builder,
2697 accumulate the values into opts['builders']
2698 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2699 * buildbot/test/test_runner.py (Try): add some quick tests to make
2700 sure 'buildbot try --options' and .buildbot/options get parsed
2701 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2702 use --builder control
2704 * docs/buildbot.texinfo (try): add --port argument to PB style
2706 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2707 actual SourceStamp. Still need to extract a branch name, somehow.
2708 (Try): finish implementing the try client side, still need a UI
2709 for specifying which builders to use
2710 (Try.getopt): factor our options/config-file reading
2711 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2713 * buildbot/test/test_vc.py: match SourceStampExtractor change
2715 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2716 causes the twisted log to be sent to stderr
2718 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2720 2005-08-10 Brian Warner <warner@lothar.com>
2722 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2723 style is 90% done, still missing status reporting or waiting for
2724 the buildsets to finish, and it is completely untested.
2726 * buildbot/trybuild.py: delete file, move contents to ..
2727 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2728 * buildbot/test/test_vc.py: match the move
2730 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2731 of the TryScheduler, no buildsetID or status-tracking support yet
2732 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2734 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2735 possible to set the basedir after __init__ time, so it is easier
2736 to use as a Service-child of the BuildMaster instance
2738 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2739 that delivers messages to its Service parent instead of requiring
2740 a subclass to be useful. This turns out to be much easier to build
2743 * buildbot/scripts/tryclient.py (createJob): utility code to
2744 create jobfiles, will eventually be used by 'buildbot try'
2746 2005-08-08 Brian Warner <warner@lothar.com>
2748 * docs/buildbot.texinfo (try): add docs on the
2749 as-yet-unimplemented Try scheduler
2751 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2752 * buildbot/test/test_scheduler.py: .. here
2753 (Scheduling.testTryJobdir): add placeholder test for 'try'
2755 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2756 addEntry merging (>=chunkSize) behavior
2757 (Log.testConsumer): update to handle new callLater(0) behavior
2759 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2760 both the MAX_LENGTH bugfix and the resumeProducing hang.
2762 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2763 put off the actual resumeProducing for a moment with
2764 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2765 causes large logfiles to hang midway through.
2767 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2768 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2769 and to improve memory usage when streaming the file out to a web
2771 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2772 make this work cleanly
2774 2005-08-03 Brian Warner <warner@lothar.com>
2776 * buildbot/trybuild.py: new file for 'try' utilities
2777 (getSourceStamp): run in a tree, find out the baserev+patch
2778 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2779 implemented for SVN and Darcs, still working on Arch. I don't know
2780 how to make CVS work yet.
2782 * docs/buildbot.texinfo: document the 'buildbot' command-line
2783 tool, including the not-yet-implemented 'try' feature, and the
2784 in-flux .buildbot/ options directory.
2786 2005-07-20 Brian Warner <warner@lothar.com>
2788 * buildbot/locks.py: added temporary id() numbers to Lock
2789 descriptions, to track down a not-really-sharing-the-Lock bug
2791 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2793 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2794 needed for python2.2 compatibility
2795 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2796 are from the __future__
2798 2005-07-19 Brian Warner <warner@lothar.com>
2800 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2801 message when schedulers use unknown builders
2803 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2804 SlaveLock('name') and MasterLock('name') are distinct
2806 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2807 c['schedulers'] in such a way that we can actually accept
2809 * buildbot/test/test_config.py: check it
2811 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2812 utility method to *all* the Schedulers
2813 (Periodic.listBuilderNames): same
2815 * docs/buildbot.texinfo (Interlocks): update chapter to match
2818 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2819 to make sure that c['sources'], c['schedulers'], and c['status']
2820 are all lists of the appropriate objects, and that the Schedulers
2821 all point to real Builders
2822 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2823 'listBuilderNames' utility method to support this
2824 * buildbot/scheduler.py: implement the utility method
2825 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2827 * docs/buildbot.texinfo: add some @cindex entries
2829 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2830 if it wasn't already set: most tla commands will fail unless one
2832 (Arch.createRepository): and disable bazaar's revision cache, since
2833 they cause test failures (the multiple repositories we create all
2834 interfere with each other through the cache)
2836 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2837 bring it properly up to date with twisted-2.0 test guidelines
2839 * buildbot/master.py (BuildMaster): remove references to old
2840 'interlock' module, this caused a bunch of post-merge test
2842 * buildbot/test/test_config.py: same
2843 * buildbot/process/base.py (Build): same
2845 * buildbot/test/test_slaves.py: stubs for new test case
2847 * buildbot/scheduler.py: add test-case-name tag
2848 * buildbot/test/test_buildreq.py: same
2850 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2851 unnecessary init code
2852 (Bot.remote_setBuilderList): match it
2854 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2856 * buildbot/changes/mail.py (parseSyncmail): update comment
2858 * buildbot/test/test_slavecommand.py: disable Shell tests on
2859 platforms that don't suport IReactorProcess
2861 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2862 all places where we open logfiles. It causes OS-X to open the file
2863 in some weird mode that that prevents us from mixing reads and
2864 writes to the same filehandle, which we depend upon to implement
2865 _generateChunks properly. This change doesn't appear to break
2866 win32, on which "b" and "t" are treated differently but a missing
2867 flag seems to be interpreted as "t".
2869 2005-07-18 Brian Warner <warner@lothar.com>
2871 * buildbot/slave/commands.py (ShellCommand): overhaul
2872 error-handling code, to try and make timeout/interrupt work
2873 properly, and make win32 happier
2874 * buildbot/test/test_slavecommand.py: clean up, stop using
2875 reactor.iterate, add tests for timeout and interrupt
2876 * buildbot/test/sleep.py: utility for a new timeout test
2878 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2879 code from the local-usebranches branch
2881 2005-07-17 Brian Warner <warner@lothar.com>
2883 * buildbot/process/process_twisted.py
2884 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2885 minutes, to match the other twisted BuildFactories, and don't
2886 excuse failures in c/qt/win32 reactors any more.
2888 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2889 'freebsd' builders, since the buildslaves have been unavailable
2892 2005-07-13 Brian Warner <warner@lothar.com>
2894 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2895 build-on-branch feature
2897 * buildbot/process/step.py (Darcs.__init__): add base_url and
2898 default_branch arguments, just like SVN
2899 (Arch.__init__): note that the version= argument is really the
2902 * buildbot/slave/commands.py (SourceBase): keep track of the
2903 repository+branch that was used for the last checkout in
2904 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2905 match, we clobber the directory and perform a fresh checkout
2906 rather than trying to do an in-place update. This should protect
2907 us against trying to get to branch B by doing an update in a tree
2908 obtained from branch A.
2909 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2910 (SVN.setup): same, just the svnurl
2911 (Darcs.setup): same, just the repourl
2912 (Arch.setup): same, arch coordinates (url), version, and
2913 buildconfig. Also pull the buildconfig from the args dictionary,
2914 which we weren't doing before, so the build-config was effectively
2916 (Arch.sourcedirIsUpdateable): don't try to update when we're
2917 moving to a specific revision: arch can't go backwards, so it is
2918 safer to just clobber the tree and checkout a new one at the
2920 (Bazaar.setup): same sourcedata as Arch
2922 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2923 use maybeWait, to work with twisted-1.3.0 and twcompat
2924 (Dependencies.testRun_Pass): same
2926 * buildbot/test/test_vc.py: rearrange, cleanup
2928 * buildbot/twcompat.py: add defer.waitForDeferred and
2929 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2930 can work under twisted-1.3.0 .
2932 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2933 now created at setUp time. This increases the runtime of the test
2934 suite considerably (from 91 seconds to 151), but it removes the
2935 need for an offline tarball, which should solve a problem I've
2936 seen where the test host has a different version of svn than the
2937 tarball build host. The new code also validates that mode=update
2938 really picks up recent commits. This approach will also make it
2939 easier to test out branches, because the code which creates the VC
2940 branches is next to the code which uses them. It will also make it
2941 possible to test some change-notification hooks, by actually
2942 performing a VC commit and watching to see the ChangeSource get
2945 2005-07-12 Brian Warner <warner@lothar.com>
2947 * docs/buildbot.texinfo (SVN): add branches example
2948 * docs/Makefile (buildbot.ps): add target for postscript manual
2950 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2951 * buildbot/test/test_locks.py: same
2953 * buildbot/process/step.py (Darcs): comment about default branches
2955 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2956 c['interlocks'] in the config file, complain if it is present.
2957 Scan all locks in c['builders'] to make sure the Locks they use
2959 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2960 add some tests to check for non-uniquely-named Locks
2961 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2962 since the unique-Lock validation code requires it now
2964 * buildbot/locks.py: fix test-case-name
2966 * buildbot/interlock.py: remove old file
2968 2005-07-11 Brian Warner <warner@lothar.com>
2970 * buildbot/test/test_interlock.py: rename to..
2971 * buildbot/test/test_locks.py: .. something shorter
2973 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2974 versions (after 2.0.1) changed internet.TCPClient to shut down the
2975 connection in stopService. Change the code to handle this
2978 * buildbot/process/base.py (Build): handle whole-Build locks
2979 * buildbot/process/builder.py (Builder.compareToSetup): same
2980 * buildbot/test/test_interlock.py: make tests work
2982 * buildbot/process/step.py (BuildStep.startStep): complain if a
2983 Step tries to claim a lock that's owned by its own Build
2984 (BuildStep.releaseLocks): typo
2986 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2987 file reloads don't replace unchanged Builders
2989 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2990 rewrite to cover new Locks instead of old c['interlocks']
2991 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2995 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2996 start the master and connect the buildslave
2998 * buildbot/process/step.py (FailingDummy.done): finish with a
2999 FAILURE status rather than raising an exception
3001 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3002 stringify a BuildRequest.reason that is None
3004 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3006 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3007 allow scheduler.Dependent to work
3008 * buildbot/buildset.py (BuildSet): set .reason and .results
3010 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3011 slaves, to make the test stop hanging. It still fails, of course,
3012 because I haven't even started to implement Locks.
3014 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3016 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3017 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3018 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3019 (Dependent): new class for downstream build dependencies
3020 * buildbot/test/test_dependencies.py: tests (still failing)
3022 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3024 2005-07-07 Brian Warner <warner@lothar.com>
3026 * buildbot/test/runutils.py (RunMixin): factored this class out..
3027 * buildbot/test/test_run.py: .. from here
3028 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3029 added new buildbot.locks tests (which all hang right now)
3030 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3031 * buildbot/process/step.py: claim/release per-BuildStep locks
3033 * docs/Makefile: add 'buildbot.html' target
3035 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3036 interpreted as "HEAD", so that all VC steps can accept branch=None
3037 and have it mean the "default branch".
3039 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3041 2005-07-07 Brian Warner <warner@lothar.com>
3043 * docs/examples/twisted_master.cfg: update to match current usage
3045 * docs/buildbot.texinfo (System Architecture): comment out the
3046 image, it doesn't exist yet and just screws up the HTML manual.
3048 2005-07-05 Brian Warner <warner@lothar.com>
3050 * debian/.cvsignore: oops, missed one. Removing leftover file.
3052 2005-06-17 Brian Warner <warner@lothar.com>
3054 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3055 changed its output in 1.2.0, don't mistakenly think that the
3056 subversion we find isn't capable of supporting our tests.
3058 * debian/*: remove the debian/ directory and its contents, to make
3059 life easier for the proper Debian maintainer
3061 * Makefile (release): same
3063 2005-06-07 Brian Warner <warner@lothar.com>
3065 * everything: create a distinct SourceStamp class to replace the
3066 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3067 Changed the signature of Source.startVC to include the revision
3068 information (instead of passing it through self.args). Implement
3069 branches for SVN (now only Darcs/Git is missing support). Add more
3072 2005-06-06 Brian Warner <warner@lothar.com>
3074 * everything: rearrange build scheduling. Create a new Scheduler
3075 object (configured in c['schedulers'], which submit BuildSets to a
3076 set of Builders. Builders can now use multiple slaves. Builds can
3077 be run on alternate branches, either requested manually or driven
3078 by changes. This changed some of the Status classes. Interlocks
3079 are out of service until they've been properly split into Locks
3080 and Dependencies. treeStableTimer, isFileImportant, and
3081 periodicBuild have all been moved from the Builder to the
3083 (BuilderStatus.currentBigState): removed the 'waiting' and
3084 'interlocked' states, removed the 'ETA' argument.
3086 2005-05-24 Brian Warner <warner@lothar.com>
3088 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3089 erroneously abandons the connection (in clientConnectionFailed)
3090 for non-UserErrors, which means that if we lose the connection due
3091 to a network problem or a timeout, we'll never try to reconnect.
3092 Fix this by not upcalling to the buggy parent method. Note:
3093 twisted-2.0 fixes this, but the function only has 3 lines so it
3094 makes more sense to copy it than to try and detect the buggyness
3095 of the parent class. Fixes SF#1207588.
3097 * buildbot/changes/changes.py (Change.branch): doh! Add a
3098 class-level attribute to accomodate old Change instances that were
3099 pickled before 0.6.5 (where .branch was added for new Changes).
3100 This fixes the exception that occurs when you try to look at an
3101 old Change (through asHTML).
3103 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3106 2005-05-23 Brian Warner <warner@lothar.com>
3108 * buildbot/__init__.py (version): release 0.6.6
3110 2005-05-23 Brian Warner <warner@lothar.com>
3112 * NEWS: update for 0.6.6 release
3113 * debian/changelog: same
3115 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3116 before starting: this was done by twistd back when we spawned it,
3117 now that we're importing the pieces and running them in the
3118 current process, we have to do it ourselves. This allows
3119 master.cfg to import files from the same directory without
3120 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3121 Stichele for the catch.
3122 (Options.opt_version): Add a --version command (actually, just make
3123 the existing --version command emit Buildbot's version too)
3125 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3126 fix to make this behave like other LogFiles, this time to handle
3127 existing LogFiles on disk. (add the missing .upgrade method)
3128 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3130 2005-05-21 Brian Warner <warner@lothar.com>
3132 * buildbot/test/test_runner.py (Create.testMaster): match the
3133 rawstring change in runner.py:masterTAC
3135 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3136 TwistedWords is installed
3137 * buildbot/test/test_status.py: same, with TwistedMail
3139 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3140 some old, deprecated, and removed config keys). This should enable
3141 you to use the base buildbot functionality with Twisted-2.0.0 when
3142 you don't also have TwistedWeb and TwistedWords installed
3144 2005-05-20 Brian Warner <warner@lothar.com>
3146 * buildbot/scripts/runner.py (run): call sendchange(), not
3147 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3148 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3149 (stop): don't wait for process to die when sending SIGHUP
3150 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3151 directory name gets interpreted, which you don't want
3154 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3157 2005-05-18 Brian Warner <warner@lothar.com>
3159 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3161 2005-05-18 Brian Warner <warner@lothar.com>
3163 * README: update for 0.6.5
3164 * debian/changelog: same
3166 * buildbot/changes/changes.py: rename tag= to branch=, since
3167 that's how we're using it, and my design for the upcoming "build a
3168 specific branch" feature wants it. also, tag= was too CVS-centric
3169 * buildbot/changes/mail.py (parseSyncmail): same
3170 * buildbot/process/base.py (Build.isBranchImportant): same
3171 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3172 * docs/buildbot.texinfo (Attributes of Changes): same
3174 * NEWS: update tag=, update for upcoming release
3176 2005-05-17 Brian Warner <warner@lothar.com>
3178 * buildbot/scripts/runner.py (stop): actually poll once per
3179 second, instead of re-killing the poor daemon once per second.
3180 Sleep briefly (0.1s) before the first poll, since there's a good
3181 chance we can avoid waiting the full second if the daemon shuts
3182 down quickly. Also remove the sys.exit() at the end.
3183 (start): remove the unneighborly sys.exit()
3185 * Makefile: improve permission-setting to not kick Arch so badly
3187 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3188 default --keepalive=600, since it doesn't hurt very much, and it's
3189 a hassle to discover that you need it.
3190 * buildbot/test/test_runner.py (Create.testSlave): test it
3192 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3193 IRC bot about EXCEPTION
3195 * buildbot/status/client.py (PBListener): upcall more correctly
3197 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3198 an exception mark the overall build with EXCEPTION, not SUCCESS
3200 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3202 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3203 * Makefile: update some release-related stuff
3205 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3206 gets called when there isn't actually an active process, just end
3207 the Command instead of blowing up. I don't know how it gets into
3208 this state, but the twisted win32 buildslave will sometimes hang,
3209 and when it shakes its head and comes back, it thinks it's still
3210 running a Command. The next build causes this command to be
3211 interrupted, but the lack of self.process.pid breaks the interrupt
3214 * NEWS: document changes since the last release
3216 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3217 look for Makefile.buildbot instead of a bare Makefile . The
3218 'buildbot start' does not install this file, so you have to
3219 manually copy it if you want to customize startup behavior.
3220 (createMaster): change 'buildbot master' command to create
3221 Makefile.sample instead of Makefile, to create master.cfg.sample
3222 instead of master.cfg (requiring you to copy it before the
3223 buildmaster can be started). Both sample files are kept up to
3224 date, i.e. they are overwritten if they have been changed. The
3225 'buildbot.tac' file is *not* overwritten, but if the new contents
3226 don't match the old, a 'buildbot.tac.new' file is created and the
3227 user is warned. This seems to be a much more sane way to handle
3228 startup files. Also, don't sys.exit(0) when done, so we can run
3229 unit tests against it.
3230 (createSlave): same. Don't overwrite the sample info/ files.
3231 * buildbot/scripts/sample.mk: remove. the contents were pulled
3232 into runner.py, since they need to match the behavior of start()
3236 * docs/buildbot.texinfo (Launching the daemons): document it
3237 * buildbot/test/test_runner.py (Create): test it
3239 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3240 version that can handle string-in-string tests, because otherwise
3241 python-2.2 fails the tests. It'd be tremendous if Trial's test
3242 took two strings under 2.2 too.
3244 * everything: fixed all deprecation warnings when running against
3245 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3246 few that come from Twisted itself). This involved putting most of
3247 the Twisted-version specific code in the new buildbot.twcompat
3248 module, and creating some abstract base classes in
3249 buildbot.changes.base and buildbot.status.base (which might be
3250 useful anyway). __implements__ is a nuisance and requires an ugly
3251 'if' clause everywhere.
3253 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3254 delay before finishing the test: it seems that smtp.sendmail
3255 doesn't hang up on the server, so we must wait a moment so it can
3256 hang up on us. This removes the trial warning about an unclean
3259 2005-05-16 Brian Warner <warner@lothar.com>
3261 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3262 tuple of (delay, repeats).
3263 * buildbot/test/test_vc.py (Retry): test it
3264 * docs/buildbot.texinfo (Source Checkout): document it
3265 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3266 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3267 doVCFull() are handled by re-trying the checkout (after a delay)
3268 some number of times.
3269 (ShellCommand._startCommand): make header lines easier to read
3271 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3273 (WebTest.test_logfile): make sure master gets shut down, silences
3274 some "unclean reactor" test errors
3276 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3277 reactor once after shutdown, something in certain versions of
3278 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3279 fails, svn-trunk is ok.
3281 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3282 second win32 error message
3284 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3285 validating the ETA, so the tests don't fail on slow systems
3287 2005-05-15 Brian Warner <warner@lothar.com>
3289 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3290 the new LogFile class, so upgrading works properly
3291 (LogFileProducer.resumeProducing): survive resumeProducing after
3292 we've exhausted the chunkGenerator
3294 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3296 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3297 (Log.testUpgrade): same
3299 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3300 Builds and logs with a cron job.
3302 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3303 of the old non-offline LogFile, added code to upgrade these to
3304 new-style contents-live-on-disk instances at load time (in a way
3305 that doesn't invalidate the old Build pickles, so upgrading to
3306 0.6.5 is not a one-way operation). Got rid of everything related
3308 (LogFile.__init__): create LogFiles with the parent step status,
3309 the log's name, and a builder-relative filename where it can keep
3310 the contents on disk.
3311 (LogFile.hasContents): new method, clients are advised to call it
3312 before getText or getChunks and friends. If it returns False, the
3313 log's contents have been deleted and getText() will raise an
3315 (LogFile.getChunks): made it a generator
3316 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3317 Consumer (except one that takes chunks instead of strings). This
3318 enables streaming of very large logfiles without storing the whole
3320 (BuildStatus.generateLogfileName): create names like
3321 12-log-compile-output, with a _0 suffix if required to be unique
3322 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3323 or earlier) logfiles into new-style ones
3324 (BuilderStatus): remove everything related to 'stub' builds. There
3325 is now only one build cache, and we don't strip logs from old
3327 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3328 since we no longer fight to keep it in the cache
3330 * buildbot/status/html.py (TextLog.render_GET): use a
3331 ChunkConsumer to stream the log entries efficiently.
3332 (ChunkConsumer): wrapper which consumes chunks and writes
3335 * buildbot/test/test_twisted.py (Parse.testParse): use a
3336 LogFile-like object instead of a real one
3338 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3339 (Log.testMerge3): validate more merge behavior
3340 (Log.testChunks): validate LogFile.getChunks
3341 (Log.testUpgrade): validate old-style LogFile upgrading
3342 (Log.testSubscribe): validate LogFile.subscribe
3343 (Log.testConsumer): validate LogFile.subscribeConsumer
3345 * buildbot/interfaces.py (IStatusLogStub): remove
3346 (IStatusLog.subscribeConsumer): new method
3347 (IStatusLog.hasContents): new method
3348 (IStatusLogConsumer): describes things passed to subscribeConsumer
3350 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3351 the log contents if it does not have any contents.
3352 (StatusResourceBuildStep.body): same
3353 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3355 2005-05-14 Brian Warner <warner@lothar.com>
3357 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3358 timeouts to try and make the windows metabuildslave not hang
3360 2005-05-13 Mike Taylor <bear@code-bear.com>
3362 * buildbot/slave/commands.py (rmdirRecursive): added a check
3363 to ensure the path passed into rmdirRecursive actually exists.
3364 On win32 a non-existant path would generate an exception.
3366 2005-05-13 Brian Warner <warner@lothar.com>
3368 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3369 shutil.rmtree which behaves correctly on windows in the face of
3370 files that you have to chmod before deleting. Thanks to Bear at
3371 the OSAF for the routine.
3372 (SourceBase.doClobber): use rmdirRecursive
3374 2005-05-12 Brian Warner <warner@lothar.com>
3376 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3377 method generate chunks instead of returning a big list. This
3378 allows the same method to be used for both old LogFile and new
3380 (OfflineLogFile.getText): use the generator
3381 (OfflineLogFile.subscribe): same
3382 * buildbot/status/html.py (TextLog.resumeProducing): same
3383 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3385 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3386 point out that OfflineLogFile does not currently work with
3387 html.Waterfall . Fixing this is high-priority.
3389 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3390 apparently windows defaults to using stdout
3392 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3393 better message on failure so I can figure out the win32 problem
3395 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3396 log messages to include more useful copies of the command being
3397 run, the argv array, and the child command's environment.
3398 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3400 2005-05-11 Brian Warner <warner@lothar.com>
3402 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3404 * Makefile: update the deb-snapshot version
3406 * docs/buildbot.texinfo: move all .xhtml docs into a new
3407 .texinfo-format document, adding a lot of material in the process.
3408 This is starting to look like a real user's manual. Removed all
3409 the Lore-related files: *.xhtml, *.css, template.tpl .
3410 * docs/Makefile: simple makefile to run 'makeinfo'
3411 * buildbot/scripts/sample.cfg: rearrange slightly
3412 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3414 2005-05-10 Brian Warner <warner@lothar.com>
3416 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3417 different name for the internal twistw module, handle it.
3419 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3420 * setup.py: .. and stop trying to install it
3422 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3423 'git'), the new linux kernel VC system (http://kernel.org/git/).
3424 Thanks to Brandon Philips for the patch.
3425 * buildbot/slave/commands.py (Git): same
3427 2005-05-06 Brian Warner <warner@lothar.com>
3429 * buildbot/status/builder.py (OfflineLogFile): replace the default
3430 LogFile with a form that appends its new contents to a disk file
3431 as they arrive. The complete log data is never kept in RAM. This
3432 is the first step towards handling very large (100MB+) logfiles
3433 without choking quite so badly. (The other half is
3434 producer/consumer on the HTML pages).
3435 (BuildStepStatus.addLog): use OfflineLogFile by default
3436 (BuildStatus.getLogfileName): helper code to give the
3437 OfflineLogFile a filename to work with
3439 * buildbot/test/test_status.py (Results.testAddResults): update
3440 tests to handle new asserts
3441 * buildbot/test/test_vc.py (Patch.doPatch): same
3442 * buildbot/test/test_steps.py (BuildStep.setUp): same
3444 2005-05-05 Brian Warner <warner@lothar.com>
3446 * buildbot/scripts/runner.py (start): if there is no Makefile,
3447 launch the app by importing twistd's internals and calling run(),
3448 rather than spawning a new twistd process. This stands a much
3449 better chance of working under windows.
3450 (stop): kill the process with os.kill instead of spawning
3451 /bin/kill, again to reduce the number of external programs which
3452 windows might not have in the PATH. Also wait up to 5 seconds for
3453 the process to go away, allowing things like 'buildbot stop;
3454 buildbot start' to be reliable in the face of slow shutdowns.
3456 * buildbot/master.py (Dispatcher.__getstate__): remove old
3457 .tap-related methods
3458 (BuildMaster.__getstate__): same
3460 * buildbot/slave/bot.py (makeService): same
3461 (Options.longdesc): same
3462 * buildbot/scripts/runner.py: copy over some old mktap option text
3464 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3465 'buildbot master' now creates a buildbot.tac file, so there is no
3466 longer a create-instance/save/reload sequence. mktap is dead, long
3468 * buildbot/scripts/sample.mk: use twistd -y, not -f
3469 * buildbot/test/test_config.py: remove mktap-based test
3470 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3471 * README: don't reference mktap
3473 * docs/source.xhtml: document some of the attributes that Changes
3476 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3478 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3479 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3480 * buildbot/changes/changes.py (Change)
3481 * buildbot/changes/mail.py (parseSyncmail)
3482 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3484 * buildbot/process/base.py (Build.isTagImportant)
3488 2005-05-04 Brian Warner <warner@lothar.com>
3490 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3491 connection after sending the change, so that unit tests don't
3492 complain about sockets being left around
3494 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3495 exception in phase=0 rendering
3496 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3498 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3500 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3501 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3502 and configuring builders with tuples.
3503 * buildbot/test/test_config.py: stop testing compatibility with
3504 deprecated config keys
3505 * buildbot/test/test_run.py: same
3507 2005-05-03 Brian Warner <warner@lothar.com>
3509 * contrib/arch_buildbot.py: survive if there are no logfiles
3510 (username): just use a string, os.getlogin isn't reliable
3512 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3513 so 'buildbot sendchange' actually works. The earlier test only
3514 covered the internal (non-reactor-running) form.
3516 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3517 script to notify the buildmaster about changes
3519 * buildbot/scripts/runner.py (sendchange): new command to send a
3520 change to a buildbot.changes.pb.PBChangeSource receiver.
3521 * buildbot/test/test_changes.py (Sender): test it
3523 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3524 after any reading of the config file, not just when we do it in
3525 startService. This makes some tests a bit cleaner.
3527 * buildbot/changes/pb.py: add some log messages
3529 * buildbot/process/base.py (Build.startBuild): fix a bug that
3530 caused an exception when the build terminated in the very first
3532 (Build.stepDone): let steps return a status of EXCEPTION. This
3533 terminates the build right away, and sets the build's overall
3534 status to EXCEPTION too.
3535 * buildbot/process/step.py (BuildStep.failed): return a status of
3536 EXCEPTION when that is what has happened.
3538 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3539 implement this, allowing Arch-based projects to get precise
3540 checkouts instead of always using the latest code
3541 (Bazaar): create variant of Arch to let folks use baz instead of
3542 tla. Requires a new buildslave too.
3543 * buildbot/slave/commands.py (Arch): add 'revision' argument
3544 (Bazaar): create variant of Arch that uses baz instead of tla.
3545 Remove the code that extracts the archive name from the
3546 register-archive output, since baz doesn't provide it, and require
3547 the user provide both the archive name and its location.
3548 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3550 2005-05-02 Brian Warner <warner@lothar.com>
3552 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3553 thanks to Nick Trout.
3555 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3556 deals better with source Makefile coming from a read-only CVS
3557 checkout. Thanks to Nick Trout for the catch.
3559 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3562 2005-04-28 Brian Warner <warner@lothar.com>
3564 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3566 * debian/changelog: update for 0.6.4
3568 2005-04-28 Brian Warner <warner@lothar.com>
3570 * README.w32: add a checklist of steps for getting buildbot
3572 * MANIFEST.in: include it in the tarball
3576 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3577 broken .tap files from 0.6.3 by getting rid of .services,
3578 .namedServices, and .change_svc at load time.
3580 2005-04-27 Brian Warner <warner@lothar.com>
3582 * NEWS: update in preparation for new release
3584 * buildbot/test/test_config.py (Save.testSave): don't pull in
3585 twisted.scripts.twistd, we don't need it and it isn't for windows
3588 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3589 accomodate win32 which can't do atomic-rename
3591 2005-04-27 Brian Warner <warner@lothar.com>
3593 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3594 timeouts to help the slow metabuildbot not flunk them so much
3595 (Disconnect.testBuild3): same
3596 (Disconnect.testBuild4): same
3597 (Disconnect.testInterrupt): same
3599 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3600 setup, it was completely broken for new buildmasters (those which
3601 did not have a 'change.pck' already saved. Thanks to Paul Warren
3602 for catching this (embarrassing!) bug.
3603 (Dispatcher.__getstate__): don't save our registered avatar
3604 factories, since they'll be re-populated when the config file is
3606 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3607 tests (since the real mktap-generated BuildMaster doesn't save
3609 (BuildMaster.__getstate__): don't save any service children,
3610 they'll all be re-populated when the config file is re-read.
3611 * buildbot/test/test_config.py (Save.testSave): test for this
3613 2005-04-26 Brian Warner <warner@lothar.com>
3615 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3616 rendered with Blender.. looks a bit nicer.
3617 * buildbot/docs/images/icon.blend: add the Blender file for it
3619 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3620 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3621 running under windows. This appears to be the best way to allow
3622 BuildSteps to do something normal like 'trial -v buildbot.test' or
3623 'make foo' and still expect it to work. The idea is to make the
3624 BuildSteps look as much like what a developer would type when
3625 compiling or testing the tree by hand. This approach probably has
3626 problems when there are spaces in the arguments, so if you've got
3627 windows buildslaves, you'll need to pay close attention to your
3630 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3631 timezone to the timestamp column.
3632 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3634 * buildbot/scripts/runner.py (loadOptions): do something sane for
3635 windows, I think. We use %APPDATA%/buildbot instead of
3636 ~/.buildbot, but we still search everywhere from the current
3637 directory up to the root for a .buildbot/ subdir. The "is it under
3638 $HOME" security test was replaced with "is it owned by the current
3639 user", which is only performed under posix.
3640 * buildbot/test/test_runner.py (Options.testFindOptions): update
3641 tests to match. The "is it owned by the current user" check is
3642 untested. The test has been re-enabled for windows.
3644 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3645 any "\n" in the expected output with the platform-specific line
3646 separator. Make this separator "\r\n" on PTYs under unix, they
3647 seem to do that and I don't know why
3649 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3650 windows for now, I don't know what ~/.buildbot/ should mean there.
3652 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3653 win32 compatibility, don't use "/tmp"
3654 (Basedir.testChangeBuilddir): remove more unixisms
3656 2005-04-26 Brian Warner <warner@lothar.com>
3658 * buildbot/test/test_control.py (Force.rmtree): python2.2
3659 compatibility, apparently its shutil.rmtree ignore_errors=
3660 argument is ignored.
3661 * buildbot/test/test_run.py (Run.rmtree): same
3662 (RunMixin.setUp): same
3664 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3667 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3668 'substring in string' operator, must use string.find(substr)!=-1
3669 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3670 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3672 * buildbot/scripts/runner.py (loadOptions): add code to search for
3673 ~/.buildbot/, a directory with things like 'options', containing
3674 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3675 the current directory, your $HOME directory, or anywhere
3676 inbetween, as long as you're somewhere inside your home directory.
3677 (debugclient): look in ~/.buildbot/options for master and passwd
3678 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3679 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3681 * buildbot/status/client.py (makeRemote): new approach to making
3682 IRemote(None) be None, which works under Twisted-2.0
3683 * buildbot/test/test_status.py (Client.testAdaptation): test it
3685 * buildbot/status/builder.py (Status.builderAdded): when loading a
3686 pickled BuilderStatus in from disk, set its name after loading.
3687 The config file might have changed its name (but not its
3688 directory) while it wasn't looking.
3690 * buildbot/process/builder.py (Builder.attached): always return a
3691 Deferred, even if the builder was already attached
3692 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3694 2005-04-25 Brian Warner <warner@lothar.com>
3696 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3697 category-related exception when announcing a build has finished
3699 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3700 reference no-longer-existent changemaster.sources
3701 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3703 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3706 2005-04-25 Brian Warner <warner@lothar.com>
3708 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3710 * debian/changelog: update for 0.6.3
3712 2005-04-25 Brian Warner <warner@lothar.com>
3714 * MANIFEST.in: make sure debug.glade is in the tarball
3716 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3718 * NEWS: update for the imminent 0.6.3 release
3720 * buildbot/status/html.py (HtmlResource.content): make the
3721 stylesheet <link> always point at "buildbot.css".
3722 (StatusResource.getChild): map "buildbot.css" to a static.File
3723 containing whatever css= argument was provided to Waterfall()
3724 (Waterfall): provide the "classic" css as the default.
3725 * docs/waterfall.classic.css: move default CSS from here ..
3726 * buildbot/status/classic.css: .. to here
3728 * MANIFEST.in: make sure classic.css is included in the tarball
3729 * setup.py: and that it is installed too, under buildbot/status/
3731 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3732 the module level, because buildbot.tap files from 0.6.2 don't have
3733 it in their attribute dictionary.
3735 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3736 really exists at startup, might save some confusion somewhere.
3738 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3740 * docs/waterfall.classic.css:
3741 add a stylesheet that's almost the same as the "classic"
3744 * buildbot/status/builder.py:
3745 add EXCEPTION as a result - this is a problem for the bot
3746 maintainer, not a build problem for the changers
3747 * buildbot/process/step.py:
3748 use EXCEPTION instead of FAILURE for exceptions
3749 * buildbot/status/html.py:
3750 add build_get_class to get a class out of a build/buildstep
3751 finish naming the classes
3752 split out sourceNames to changeNames and builderNames so we
3753 can style them separately
3754 * docs/config.xhtml:
3755 finish documenting classes as they are right now
3757 * buildbot/status/html.py:
3758 name the classes as we agreed on IRC
3759 * docs/config.xhtml:
3762 * buildbot/status/html.py:
3763 same for cssclass->class_
3765 * buildbot/status/html.py:
3766 as decided on IRC, use class_ for the "class" attribute to not
3767 conflict with the class keyword, and clean up the messy **{} stuff.
3769 * buildbot/status/mail.py:
3770 put back "builders" argument, and fix docstring, because the
3771 code *ignores* builders listed in this argument
3773 * buildbot/process/builder.py:
3774 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3776 * docs/config.xhtml:
3777 describe the category argument for builders
3779 * buildbot/status/builder.py:
3780 Fix a silly bug due to merging
3782 * buildbot/process/builder.py:
3783 remove category from the process Builder ...
3784 * buildbot/status/builder.py:
3785 ... and add it to BuilderStatus instead.
3786 Set category on unpickled builder statuses, they might not have it.
3787 * buildbot/master.py:
3788 include category when doing builderAdded
3789 * buildbot/status/mail.py:
3790 return None instead of self for builders we are not interested in.
3791 * buildbot/test/test_run.py:
3792 fix a bug due to only doing deferredResult on "dummy" waiting
3793 * buildbot/test/test_status.py:
3794 add checks for the Mail IStatusReceiver returning None or self
3796 * buildbot/status/html.py:
3797 fix testsuite by prefixing page title with BuildBot
3799 * buildbot/status/builder.py:
3800 have .category in builder status ...
3801 * buildbot/process/builder.py:
3802 ... and set it from Builder
3803 * buildbot/status/html.py:
3804 make .css a class variable
3805 * buildbot/test/test_status.py:
3806 write more tests to cover our categories stuff ...
3807 * buildbot/status/mail.py:
3808 ... and fix the bug that this uncovered
3810 * buildbot/changes/mail.py:
3811 * buildbot/changes/pb.py:
3812 * buildbot/master.py:
3813 * buildbot/process/base.py:
3814 * buildbot/process/factory.py:
3815 * buildbot/process/interlock.py:
3816 * buildbot/process/step.py:
3817 * buildbot/process/step_twisted.py:
3818 * buildbot/slave/commands.py:
3819 * buildbot/status/builder.py:
3820 * buildbot/status/client.py:
3821 * buildbot/status/html.py:
3822 * buildbot/status/mail.py:
3823 * buildbot/status/progress.py:
3824 * buildbot/test/test_changes.py:
3825 * buildbot/test/test_config.py:
3826 * buildbot/test/test_control.py:
3827 * buildbot/test/test_interlock.py:
3828 * buildbot/test/test_maildir.py:
3829 * buildbot/test/test_mailparse.py:
3830 * buildbot/test/test_run.py:
3831 * buildbot/test/test_slavecommand.py:
3832 * buildbot/test/test_status.py:
3833 * buildbot/test/test_steps.py:
3834 * buildbot/test/test_twisted.py:
3835 * buildbot/test/test_util.py:
3836 * buildbot/test/test_vc.py:
3837 * buildbot/test/test_web.py:
3839 add test-case-name at the top of a whole set of files
3841 * buildbot/status/builder.py:
3842 keep order of addition when getting builder names
3843 * buildbot/status/words.py:
3844 * buildbot/test/test_run.py:
3845 add test for getBuilderNames
3847 * buildbot/process/base.py:
3848 * buildbot/process/step.py:
3849 * buildbot/status/builder.py:
3850 * buildbot/status/html.py:
3851 make buildbot css-able
3852 replace the color code for purple with purple, don't understand
3853 why it wasn't purple to start with
3855 * buildbot/status/words.py:
3856 ok, so it doesn't look like BuilderStatus.remote is still valid.
3857 Use what waterfall uses instead.
3859 * buildbot/interfaces.py:
3860 * buildbot/status/builder.py:
3861 * buildbot/status/html.py:
3862 * buildbot/status/mail.py:
3863 * buildbot/status/words.py:
3864 * buildbot/test/test_run.py:
3865 use categories everywhere and make it be a list. More sensible
3866 for the future. Also make words actually respect this in
3869 * buildbot/interfaces.py:
3870 add category argument to getBuilderNames
3871 * buildbot/process/builder.py:
3872 * buildbot/status/builder.py:
3873 * buildbot/status/html.py:
3874 * buildbot/status/mail.py:
3875 * buildbot/status/words.py:
3876 * buildbot/test/test_run.py:
3877 move from specifying builders by name to specifying the category
3879 * buildbot/status/html.py:
3880 * buildbot/status/words.py:
3881 add "builders=" to __init__ of status clients so they can
3882 limit themselves to the given list of builders to report on
3884 * buildbot/status/html.py: set the title to the product name
3886 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3888 * buildbot/interfaces.py:
3889 * buildbot/status/builder.py:
3890 more documentation. Hm, not sure if ChangeLog entries make sense
3893 2005-04-23 Brian Warner <warner@lothar.com>
3895 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3897 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3899 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3900 the sub-commands that log buildmaster status to stdout and to a
3901 GUI window, respectively.
3903 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3904 functionality is working again, but all the step-status and ETA
3905 stuff is missing. Commented out a lot of code pending more
3908 * buildbot/status/client.py: make sure that IRemote(None) is None
3910 * buildbot/changes/changes.py: import defer, oops
3911 (ChangeMaster): remove the .sources list, rely upon the fact that
3912 MultiServices can be treated as sequences of their children. This
3913 cleans up the add/remove ChangeSource routines a lot, as we keep
3914 exactly one list of the current sources instead of three.
3916 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3917 up an empty ChangeMaster at init time.
3918 (BuildMaster.loadChanges): if there are changes to be had from
3919 disk, replace self.change_svc with the new ones. If not, keep
3920 using the empty ChangeMaster set up in __init__.
3921 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3922 instead of a separate list, makes the code a bit cleaner.
3923 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3924 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3925 Extend the test to make sure we can get rid of the sources when
3928 2005-04-22 Brian Warner <warner@lothar.com>
3930 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3931 and info/host files when making the slave directory
3933 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3934 whendone= argument, just return the Deferred and let the caller do
3935 what they want with it.
3936 (Disconnect.testBuild1): wait for shutdownSlave
3937 (Basedir.testChangeBuilddir): new test to make sure changes to the
3938 builddir actually get propagated to the slave
3940 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3941 explicit method, rather than passing the builddir in __init__ .
3942 Make sure to update self.basedir too, this was broken before.
3943 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3944 builders and for ones that have just had their builddir changed.
3945 (BotFactory): add a class-level .perspective attribute, so
3946 BuildSlave.waitUntilDisconnected won't get upset when the
3947 connection hasn't yet been established
3948 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3949 tests can reach through it to inspect the SlaveBuilders
3951 * buildbot/process/base.py (Build.buildException): explain the
3952 log.err with a log.msg
3953 * buildbot/process/builder.py (Builder.startBuild): same
3954 (Builder._startBuildFailed): improve error message
3956 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3957 occurred because we lost the brand-new connection, retry instead
3958 of giving up. If not, it's probably an authorization failure, and
3959 it makes sense to stop trying. Make sure we log.msg the reason
3960 that we're log.err'ing the failure, otherwise test failures are
3961 really hard to figure out.
3963 * buildbot/master.py: change loadConfig() to return a Deferred
3964 that doesn't fire until the change has been fully implemented.
3965 This means any connected slaves have been updated with the new
3966 builddir. This change makes it easier to test the code which
3967 actually implements this builddir-updating.
3968 (BotPerspective.addBuilder): return Deferred
3969 (BotPerspective.removeBuilder): same
3970 (BotPerspective.attached): same
3971 (BotPerspective._attached): same. finish with remote_print before
3972 starting the getSlaveInfo, instead of doing them in parallel
3973 (BotPerspective.list_done): same
3974 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3975 actually calling slave.disconnect()
3976 (BotMaster.addBuilder): same
3977 (BotMaster.removeBuilder): same
3978 (BuildMaster.loadConfig): same
3979 (BuildMaster.loadConfig_Slaves): same
3980 (BuildMaster.loadConfig_Sources): same
3981 (BuildMaster.loadConfig_Builders): same
3982 (BuildMaster.loadConfig_status): same
3984 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3985 a Deferred that fires when the source is finally removed
3987 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3988 the previous tree on win32, where we have to do it synchronously,
3989 make sure we return a Deferred anyway.
3990 (SourceBase.doCopy): same
3992 * buildbot/scripts/runner.py (statusgui): use the text client for
3993 now, while I rewrite the Gtk one
3994 * buildbot/clients/base.py: strip out old code, leaving just the
3995 basic print-message-on-event functionality. I also remove the
3996 ReconnectingPBClientFactory, but it does at least quit when it
3997 loses the connection instead of going silent
3999 2005-04-21 Brian Warner <warner@lothar.com>
4001 * Makefile: minor tweaks
4003 * NEWS: point out deprecation warnings, new features for
4006 * buildbot/master.py (BuildMaster.loadConfig): emit
4007 DeprecationWarnings for Builders defined with tuples. Rearrange
4008 code to facility removal of deprecated configuration keys in the
4011 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4012 'buildbot' command to put a little Makefile in the target that
4013 helps you re-create the buildbot.tap file, start or stop the
4014 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4015 all the files 0600, since they contain passwords.
4016 (start): if there is a Makefile, and /usr/bin/make exists, use
4017 'make start' in preference to a raw twistd command. This lets
4018 slave admins put things like PYTHONPATH variables in their
4019 Makefiles and have them still work when the slave is started with
4020 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4021 be nice to first try the 'make' command and only fall back to
4022 twistd if it fails. TODO: the Makefile's "start" command does not
4023 add the --reactor=win32 argument when running under windows.
4024 (Options.debugclient, Options.statusgui): add sub-commands to launch
4025 the debug client (formerly in contrib/debugclient.py) and the
4026 Gtk status application (currently broken)
4027 * buildbot/clients/debug.py: move from contrib/debugclient.py
4028 * buildbot/clients/debug.glade: same
4030 * buildbot/test/test_trial.py: remove it. This requires some
4031 functionality out of Twisted that isn't there yet, and until then
4032 having it around just confuses things.
4034 * buildbot/test/test_slavecommand.py (Shell): test both with and
4035 without PTYs, and make sure that command output is properly
4036 interleaved in the with-PTY case. I think the without-PTY test
4037 should pass on windows, where we never use PTYs anyway.
4039 2005-04-20 Brian Warner <warner@lothar.com>
4041 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4043 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4045 * NEWS: start creating entries for the next release
4047 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4049 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4050 (WebTest.test_webPathname): same
4051 (WebTest.test_webPathname_port): same
4052 (WebTest.test_waterfall): use the default favicon rather than
4053 rooting around the filesystem for it. Open the expected-icon file
4054 in binary mode, to make win32 tests happier (thanks to Nick Trout
4056 * buildbot/status/html.py (buildbot_icon): win32 portability
4058 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4059 win32-compatibility fixes from Nick Trout, the "file not found" message
4060 is different under windows
4061 (FakeSlaveBuilder.__init__): clean up setup a bit
4062 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4064 2005-04-19 Brian Warner <warner@lothar.com>
4066 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4067 skip-if-repositories-are-unavailable test to not kill the trial
4068 that comes with Twisted-1.3.0
4070 * setup.py: install buildbot.png icon file when installing code
4072 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4073 environment used by the command, at least on the child side.
4075 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4076 this method needs to be added and implemented because it gets
4077 called under heavy load. I don't quite understand the
4078 producer/consumer API enough to write it.
4079 (StatusResource.getChild): add a resource for /favicon.ico
4080 (Waterfall.__init__): add favicon= argument
4081 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4082 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4083 (WebTest.test_webPathname): same
4084 (WebTest.test_webPathname_port): same
4085 * docs/config.xhtml: mention favicon=
4086 * buildbot/buildbot.png: add a default icon, dorky as it is
4088 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4090 * buildbot/master.py:
4091 * buildbot/process/base.py:
4092 * buildbot/process/builder.py:
4093 * buildbot/process/interlock.py:
4094 * buildbot/status/builder.py:
4095 * buildbot/status/html.py:
4096 * buildbot/status/mail.py:
4097 * buildbot/status/words.py:
4098 new documentation while digging through the code
4100 2005-04-17 Brian Warner <warner@lothar.com>
4102 * general: try to fix file modes on all .py files: a+r, a-x,
4103 but let buildbot/clients/*.py be +x since they're tools
4105 * docs/epyrun (addMod): when an import fails, say why
4107 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4109 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4111 * buildbot/process/base.py:
4112 * buildbot/process/builder.py:
4113 * buildbot/status/builder.py:
4114 new documentation while digging through the code
4116 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4118 * buildbot/changes/changes.py:
4119 * buildbot/changes/p4poller.py:
4120 * buildbot/interfaces.py:
4121 * buildbot/process/base.py:
4122 * buildbot/process/builder.py:
4123 * buildbot/process/step.py:
4124 * buildbot/process/step_twisted.py:
4125 * buildbot/slave/bot.py:
4126 * buildbot/slave/commands.py:
4127 * buildbot/status/builder.py:
4128 fix all docstrings to make epydoc happy. In the process of fixing
4129 some, I also moved pieces of docs, and removed some deprecated
4132 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4134 * buildbot/process/builder.py:
4135 * buildbot/process/interlock.py:
4136 * buildbot/process/process_twisted.py:
4137 * buildbot/process/step.py:
4138 BuildProcess -> Build, as it looks like that's what happened
4139 * buildbot/process/base.py:
4140 * buildbot/process/factory.py:
4143 2005-04-17 Brian Warner <warner@lothar.com>
4145 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4146 update compile command to accomodate the Twisted split.. now
4147 instead of './setup.py build_ext -i', you do './setup.py all
4148 build_ext -i', to run build_ext over all sub-projects.
4149 (FullTwistedBuildFactory): same
4150 (TwistedReactorsBuildFactory): same
4152 * buildbot/status/html.py (TextLog.finished): null out self.req
4153 when we're done, otherwise the reference cycle of TextLog to .req
4154 to .notifications to a Deferred to TextLog.stop keeps them from
4155 being collected, and consumes a huge (610MB on pyramid at last
4156 check) amount of memory.
4158 2005-04-11 Brian Warner <warner@lothar.com>
4160 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4161 normalize the VC-repository location.. makes SVN happier with
4162 certain test environments.
4164 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4165 RemoteShellCommand gets its own .env dictionary, so that code in
4166 start() doesn't mutate the original. I think this should fix the
4167 step_twisted.Trial problem where multiple identical components
4168 kept getting added to PYTHONPATH= over and over again.
4170 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4171 adding epydoc-format docstrings to many classes. Thanks to Thomas
4172 Vander Stichele for the patches.
4173 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4174 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4175 * buildbot/slave/bot.py, commands.py, registry.py: same
4177 2005-04-05 Brian Warner <warner@lothar.com>
4179 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4180 preserve timestamps, helps incremental builds of large trees.
4181 Patch from Rene Rivera.
4183 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4184 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4187 2005-04-03 Brian Warner <warner@lothar.com>
4189 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4190 with one dict, apparently exec has some scoping bugs when used
4191 with both global/local dicts. Thanks to Nathaniel Smith for the
4194 2005-04-02 Brian Warner <warner@lothar.com>
4196 * buildbot/process/step_twisted.py (countFailedTests): the new
4197 trial in Twisted-2.0 emits a slightly different status line than
4198 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4199 mistakenly think the test count is unparseable.
4200 (Trial.start): note that for some reason each build causes another
4201 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4202 be fixed but I'm not sure quite where the problem is.
4204 2005-04-01 Brian Warner <warner@lothar.com>
4206 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4207 deferredResult to avoid hangs/warnings under twisted-2.0
4208 (RunMixin.tearDown): same
4209 (RunMixin.shutdownSlave): same
4210 (Disconnect.testIdle1): same
4211 (Disconnect.testBuild2): same: wait one second after the build
4212 finishes for test to really be done.. this should be cleaned up to
4213 avoid wasting that second. Builder.detach uses a callLater(0),
4214 either that should be done in-line (something else needed that
4215 behavior), or it should return a Deferred that fires when the
4216 builder is really offline.
4217 (Disconnect.testBuild3): same
4218 (Disconnect.testDisappear): same
4220 * buildbot/test/test_web.py: rearrange server-setup and teardown
4221 code to remove unclean-reactor warnings from twisted-2.0
4223 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4224 so the tests don't hang under twisted-2.0
4226 2005-03-31 Brian Warner <warner@lothar.com>
4228 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4229 caused a warning each time the master changed our set of builders
4231 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4232 w32, don't unlink the file unless it already exists. Thanks to
4233 Baptiste Lepilleur for the catch.
4234 (BuilderStatus.saveYourself): same
4236 2005-02-01 Brian Warner <warner@lothar.com>
4238 * buildbot/status/html.py (TextLog.getChild): use a /text child
4239 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4240 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4241 logfile as text/plain (no markup, no headers). This replaces the
4242 previous scheme (which used an ?text=1 argument), and gets us back
4243 to a relative link (which works better when the buildbot lives
4244 behind another web server, such as Apache configured as a reverse
4245 proxy). Thanks to Gerald Combs for spotting the problem.
4247 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4250 2004-12-13 Brian Warner <warner@lothar.com>
4252 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4254 * debian/changelog: update for 0.6.2
4255 * NEWS: finalize for 0.6.2
4257 2004-12-11 Brian Warner <warner@lothar.com>
4259 * NEWS: bring it up to date
4261 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4262 detection code. Require some sign of life from the buildmaster
4263 every BotFactory.keepaliveInterval seconds. Provoke this
4264 indication at BotFactory.keepaliveTimeout seconds before the
4265 deadline by sending a keepalive request. We don't actually care if
4266 that request is answered in a timely fashion, what we care about
4267 is that .activity() is called before the deadline. .activity() is
4268 triggered by any PB message from the master (including an ack to
4269 one of the slave's status-update messages). With this new scheme,
4270 large status messages over slow pipes are OK, as long as any given
4271 message can be sent (and thus acked) within .keepaliveTimeout
4272 seconds (which defaults to 30).
4273 (SlaveBuilder.remote_startCommand): record activity
4274 (SlaveBuilder.ackUpdate): same
4275 (SlaveBuilder.ackComplete): same
4276 (BotFactory.gotPerspective): same
4277 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4279 2004-12-09 Brian Warner <warner@lothar.com>
4281 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4284 * buildbot/process/step_twisted.py (Trial._commandComplete):
4285 update self.cmd when we start the 'cat test.log' transfer. Without
4286 this, we cannot interrupt the correct RemoteCommand when we lose
4289 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4290 trying to tell the slave to stop the command if we're already
4291 inactive, or if we no longer have a .remote
4293 * buildbot/process/builder.py (Builder._detached): don't let an
4294 exception in currentBuild.stopBuild() prevent the builder from
4295 being marked offline
4297 2004-12-07 Brian Warner <warner@lothar.com>
4299 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4300 KeyError that happens when you ask for a non-existent Builder, and
4301 translate it into a UsageError.
4303 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4304 losing the slave in the middle of a remote step is handled too
4306 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4307 be a Failure, so be sure to stringify it before using it as the
4308 contents of the 'interrupt' logfile
4309 (RemoteCommand.interrupt): use stringified 'why' in
4310 remote_interruptCommand too, just in case
4312 2004-12-06 Brian Warner <warner@lothar.com>
4314 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4315 instead of 'tla update', which is more efficient in case we've
4316 missed a couple of patches since the last update.
4318 * debian/changelog: update for previous (0.6.1) release. Obviously
4319 this needs to be handled better.
4321 2004-12-05 Brian Warner <warner@lothar.com>
4323 * NEWS: update for stuff since last release
4325 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4326 match the maybeDeferred change in Dispatcher.requestAvatar
4327 * buildbot/changes/pb.py (ChangePerspective.attached): same
4328 * buildbot/status/client.py (StatusClientPerspective.attached): same
4329 * buildbot/process/builder.py (Builder._attached3): same
4330 * buildbot/pbutil.py (NewCredPerspective.attached): same
4332 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4333 the date to the top-most box, if it is not the same as today's
4336 * docs/slave.xhtml: provide a buildslave setup checklist
4338 * docs/source.xhtml (Arch): correct terminology
4340 2004-12-04 Brian Warner <warner@lothar.com>
4342 * buildbot/test/test_slavecommand.py: use sys.executable instead
4343 of hard-coding 'python' for child commands, might help portability
4345 * docs/examples/twisted_master.cfg: update to current usage
4347 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4348 'stop build' command to the IRC bot
4350 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4351 message that broke PBChangeSource
4353 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4354 (SlaveBuilder): make some attributes class-level, remove the old
4355 "update queue" which existed to support resuming a build after the
4356 master connection was lost. Try to reimplement that feature later.
4357 (SlaveBuilder.stopCommand): clear self.command when the
4358 SlaveCommand finishes, so that we don't try to kill a leftover one
4360 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4363 * buildbot/slave/commands.py (SourceBase): set self.command for
4364 all VC commands, so they can be interrupted.
4366 2004-12-03 Brian Warner <warner@lothar.com>
4368 * buildbot/master.py: clean up slave-handling code, to handle
4369 slave-disconnect and multiple-connect better
4370 (BotPerspective): make these long-lasting, exactly one per bot
4371 listed in the config file.
4372 (BotPerspective.attached): if a slave connects while an existing
4373 one appears to still be connected, disconnect the old one first.
4374 (BotPerspective.disconnect): new method to forcibly disconnect a
4375 buildslave. Use some hacks to empty the transmit buffer quickly to
4376 avoid the long (20-min?) TCP timeout that could occur if the old
4377 slave has dropped off the net.
4378 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4379 own their own SlaveStatus objects. Remove .attached/.detached, add
4380 .addSlave/.removeSlave, treat slaves like Builders (config file
4381 parsing sends deltas to the BotMaster). Inform the slave
4382 instances, i.e. the BotPerspective, about addBuilder and
4384 (BotMaster.getPerspective): turns into a single dict lookup
4385 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4386 which gives BotPerspective.attached a chance to disconnect the old
4388 (BuildMaster.loadConfig): add code (disabled) to validate that all
4389 builders use known slaves (listed in c['bots']). The check won't
4390 work with tuple-specified builders, which are deprecated but not
4391 yet invalid, so the check is disabled for now.
4392 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4393 routine, do the add/changed/removed dance with them like we do
4395 (BuildMaster.loadConfig_Sources): move source-config into a
4396 separate routine too
4398 * buildbot/status/builder.py (Status.getSlave): get the
4399 SlaveStatus object from the BotPerspective, not the BotMaster.
4401 * buildbot/test/test_run.py: bunch of new tests for losing the
4402 buildslave at various points in the build, handling a slave that
4403 connects multiple times, and making sure we can interrupt a
4406 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4407 something other than 'Bot' for the Bot object, to make certain
4408 test cases easier to write.
4409 (BuildSlave.waitUntilDisconnected): utility method for testing
4411 2004-11-30 Brian Warner <warner@lothar.com>
4413 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4415 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4416 argument, return a Deferred that always fires with True or False.
4417 I don't use an errback to indicate 'ping failed' so that callers
4418 are free to ignore the deferred without causing spurious errors in
4420 * buildbot/process/builder.py (BuilderControl.ping): implement it
4422 * buildbot/test/test_run.py (Status.testDisappear): test ping
4423 (Status.disappearSlave): fix it
4425 2004-11-30 Brian Warner <warner@lothar.com>
4427 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4428 (IBuilderControl): add .getBuild(num), only works for the current
4429 build, of course, although it might be interesting to offer
4430 something for builds in the .waiting or .interlocked state.
4432 * buildbot/process/base.py (Build): have .stopBuild just do the
4433 interrupt, then let the build die by itself.
4434 (BuildControl): add .stopBuild, and add a point-event named
4435 'interrupt' just after the build so status viewers can tell that
4437 (BuilderControl): add .getBuild
4439 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4440 stops when you kill it, good for testing
4441 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4442 contains the 'reason' text.
4444 * buildbot/status/html.py: Add Stop Build button, if the build can
4445 still be stopped. Send a Redirect (to the top page) one second
4446 later, hopefully long enough for the interrupt to have an effect.
4447 Move make_row() up to top-level to share it between Stop Build and
4450 * buildbot/slave/commands.py: only kill the child process once
4452 * buildbot/test/test_run.py: add testInterrupt
4454 2004-11-29 Brian Warner <warner@lothar.com>
4456 * buildbot/process/base.py: Refactor command interruption. The
4457 Build is now responsible for noticing that the slave has gone
4458 away: Build.lostRemote() interrupts the current step and makes
4459 sure that no further ones will be started.
4461 * buildbot/process/builder.py: When the initial remote_startBuild
4462 message fails, log it: this usually indicates that the slave has
4463 gone away, but we don't really start paying attention until they
4464 fail to respond to the first step's command.
4466 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4467 slave disconnect. Now sports a new interrupt() method. Error
4468 handling was simplified a lot by chaining deferreds, so
4469 remoteFailed/remoteComplete were merged into a single
4470 remoteComplete method (which can now get a Failure object).
4471 Likewise failed/finished were merged into just _finished.
4472 (BuildStep): Add interrupt(why) method, and if why is a
4473 ConnectionLost Failure then the step is failed with some useful
4476 * buildbot/slave/bot.py: stop the current command when the remote
4477 Step reference is lost, and when the slave is shut down.
4478 (Bot): make it a MultiService, so it can have children. Use
4479 stopService to tell when the slave is shutting down.
4480 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4481 remote_interruptCommand (which asks the current SlaveCommand to
4482 stop but allows it to keep emitting status messages), and
4483 stopCommand (which tells it to shut up and die).
4485 * buildbot/slave/commands.py: make commands interruptible
4486 (ShellCommand.kill): factor out os.kill logic
4487 (Command): factor out setup()
4488 (Command.sendStatus): don't send status if .running is false, this
4489 happens when the command has been halted.
4490 (Command.interrupt): new method, used to tell the command to die
4491 (SlaveShellCommand): implement .interrupt
4492 (DummyCommand): implement .interrupt
4493 (SourceBase, etc): factor out setup(), don't continue substeps if
4496 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4497 so they can be called after finishing
4499 * buildbot/test/test_run.py: new tests for disconnect behavior,
4500 refactor slave-shutdown routines, add different kinds of
4503 2004-11-27 Brian Warner <warner@lothar.com>
4505 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4506 method to express ETA time like "2m45s" instead of "165 seconds"
4508 2004-11-24 Brian Warner <warner@lothar.com>
4510 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4511 archive after the test completes, to avoid cluttering the user's
4512 'tla archives' listing with a bogus entry. Arch doesn't happen to
4513 provide any way to override the use of ~/.arch-params/, so there
4514 isn't a convenient way to avoid touching the setup of the user who
4516 (VC_HTTP.testArchHTTP): same
4518 2004-11-23 Brian Warner <warner@lothar.com>
4520 * buildbot/status/html.py (TextLog): split render() up into
4521 render_HEAD and render_GET. Use a Producer when sending log
4522 chunks, to reduce memory requirements and avoid sending huge
4523 non-Banana-able strings over web.distrib connections. Requires
4524 peeking under the covers of IStatusLog.
4525 (TextLog.resumeProducing): fix the "as text" link, handle client
4526 disconnects that occur while we're still sending old chunks.
4528 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4529 use defer.succeed, not the non-existent defer.success
4530 (LogFile.waitUntilFinished): same
4531 (LogFile.subscribe): don't add watchers to a finished logfile
4533 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4536 2004-11-23 Brian Warner <warner@lothar.com>
4538 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4540 2004-11-23 Brian Warner <warner@lothar.com>
4542 * NEWS: update for the 0.6.1 release
4543 * MANIFEST.in: add new files
4545 * README (INSTALLATION): explain how to enable the extra VC tests
4547 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4548 level to, so old pickled builds can be displayed ok
4550 2004-11-22 Brian Warner <warner@lothar.com>
4552 * NEWS: summarize updates since last release
4554 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4555 Yoz Grahame. Closes SF#1050138.
4557 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4560 * buildbot/process/step_twisted.py (Trial): update docs a bit
4562 * docs/factories.xhtml: fix Trial factory docs to match reality.
4565 * buildbot/process/factory.py (Trial.__init__): add args for
4566 randomly= and recurse=, making them available to instantiators
4567 instead of only to subclassers. Closes: SF#1049759.
4569 2004-11-15 Brian Warner <warner@lothar.com>
4571 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4572 try to teach the Quick factory to use multiple versions of python
4574 2004-11-12 Brian Warner <warner@lothar.com>
4576 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4577 safer w32-compatible approach, and only use it on windows
4578 (BuildStatus.saveYourself): same
4580 2004-11-11 Brian Warner <warner@lothar.com>
4582 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4583 it: one string merge per chunk. There are now separate .entries
4584 and .runEntries lists: when enumerating over all chunks, make sure
4586 * buildbot/test/test_status.py (Log): more tests
4588 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4589 chunks together, up to 10kb per chunk. This ought to cut down on
4590 the CPU-burning overhead of large log files. Thanks to Alexander
4591 Staubo for spotting the problem.
4592 * buildbot/test/test_status.py (Log): tests for same
4594 2004-11-10 Brian Warner <warner@lothar.com>
4596 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4597 header to outbound mail
4598 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4600 2004-11-08 Brian Warner <warner@lothar.com>
4602 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4603 can't do os.rename() onto an existing file, so catch the exception
4604 and unlink the target file first. This introduces a slight window
4605 where the existing file could be lost, but the main failure case
4606 (disk full) should still be handled safely.
4607 (BuildStatus.saveYourself): same
4609 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4610 separator character instead of os.sep, because the filenames being
4611 split here are coming from the VC system, which can have a
4612 different pathname convention than the local host. This should
4613 help a buildmaster running on windows that uses a CVS repository
4614 which runs under unix.
4615 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4617 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4618 when there are no test failures to be parsed
4620 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4621 instead of the unix-specific os.system("cp"), thanks to Elliot
4622 Murphy for this and the other buildbot-vs-windows catches.
4623 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4625 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4626 echo the command as it is run
4628 * setup.py: install sample.mk too, not just sample.cfg
4629 (scripts): install contrib/windows/buildbot.bat on windows
4631 2004-11-07 Brian Warner <warner@lothar.com>
4633 * buildbot/process/builder.py (Builder._detached): clear the
4634 self.currentBuild reference, otherwise the next build will be
4635 skipped because we think the Builder is already in use.
4637 * docs/examples/twisted_master.cfg: update to match current usage
4638 on the Twisted buildbot
4640 2004-10-29 Brian Warner <warner@lothar.com>
4642 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4644 2004-10-28 Brian Warner <warner@lothar.com>
4646 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4647 have separate doVCUpdate/doVCFull methods. Catch an update failure
4648 and respond by clobbering the source directory and re-trying. This
4649 will handle local changes (like replacing a file with a directory)
4650 that will cause CVS and SVN updates to fail.
4651 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4653 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4656 2004-10-19 Brian Warner <warner@lothar.com>
4658 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4660 * buildbot/status/html.py (StatusResourceTestResults): display any
4661 TestResults that the Build might have
4662 (StatusResourceTestResult): and the logs for each TestResult
4663 (StatusResourceBuild): add link from the per-build page
4665 2004-10-15 Brian Warner <warner@lothar.com>
4667 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4668 the 'problems' portion of stdout, add TestResults to our build
4669 * buildbot/test/test_twisted.py (Parse.testParse): test it
4671 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4672 to retrieve a dict of accumulated test results
4673 (ITestResult): define what a single test result can do
4674 * buildbot/status/builder.py (TestResult): implement ITestResult
4675 (BuildStatus.getTestResults): retrieve dict of TestResults
4676 (BuildStatus.addTestResult): add TestResults
4677 * buildbot/test/test_status.py (Results.testAddResults): test it
4679 2004-10-14 Brian Warner <warner@lothar.com>
4681 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4682 instead of os.system("rm -rf") for win32 portability
4684 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4685 SignalMixin instead of starting/stopping the reactor, which is
4686 likely to cause problems with other tests
4688 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4689 self.copyComplete() call. Yoz Grahame makes the catch.
4691 * contrib/windows/buildbot.bat: helper script to deal with path
4692 issues. Thanks to Yoz Grahame.
4694 * buildbot/master.py (BuildMaster.startService): don't register a
4695 SIGHUP handler if the signal module has no SIGHUP attribute.
4696 Apparently win32 does this.
4698 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4700 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4701 test if the reactor can't offer UNIX sockets
4703 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4704 error introduced in the last commit. We really need that
4707 2004-10-12 Brian Warner <warner@lothar.com>
4709 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4710 when describing a maildir source. Thanks to Stephen Davis.
4712 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4715 * buildbot/scripts/runner.py (createMaster): install Makefile too
4716 (start): add --no_save to 'start' command
4717 * buildbot/scripts/sample.mk: simple convenience Makefile with
4718 start/stop/reload targets
4720 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4723 2004-09-30 Brian Warner <warner@lothar.com>
4725 * setup.py: Releasing buildbot-0.6.0
4727 2004-09-30 Brian Warner <warner@lothar.com>
4729 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4730 test_trial.py from the source tarball until support is complete.
4732 * NEWS: update for 0.6.0 release
4733 * buildbot/__init__.py (version): same
4736 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4737 'source' command to tell users where to get the Buildbot source
4739 * docs/examples/*.cfg: update to modern standards
4741 * NEWS: update for release
4743 * buildbot/scripts/runner.py (createMaster): remove the
4744 -shutdown.tap stuff now that it isn't necessary
4746 (start): launch buildbot.tap, not buildbot-shutdown.tap
4749 * buildbot/status/mail.py (Domain): shorten class name
4750 (MailNotifier): if lookup= is a string, pass it to Domain()
4751 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4752 (Mail.testBuild2): test the string-to-Domain shortcut
4753 (Mail.testMail): fix test
4756 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4759 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4760 more attributes on load
4761 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4762 to accomodate the whole waterfall page at once, and the thrashing
4763 results in a lot of unnecessary loads
4764 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4765 (BuilderStatus.saveYourself): same
4766 (BuilderStatus.eventGenerator): stop generating on the first missing
4767 build. We assume that saved builds are deleted oldest-first.
4768 (BuildStepStatus.__getstate__): .progress might not exist
4770 * buildbot/changes/changes.py (ChangeMaster): make it
4771 serializable, in $masterdir/changes.pck
4772 (ChangeMaster.stopService): save on shutdown
4773 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4774 * buildbot/test/test_config.py: load Changes before config file
4777 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4778 "Oh my god, you killed the command" header on a separate line
4780 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4781 skip over corrupted build pickles
4782 (BuilderStatus.getFullBuildByNumber): same
4783 (BuilderStatus.eventGenerator): skip over unavailable builds
4784 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4785 do an atomic rename. This prevents a corrupted pickle when some
4786 internal serialization error occurs.
4787 (BuilderStatus.saveYourself): same
4789 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4790 the timeout for shell commands, it got lost somehow
4792 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4793 run out of build steps, return the rest of the builder events
4795 * buildbot/interfaces.py (IBuilderControl.ping): add method
4797 * buildbot/process/builder.py (BuilderControl.ping): move
4798 slave-ping to BuilderControl, and fix the failure case in the
4799 process (Event.finish() is the verb, Event.finished is the noun).
4801 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4802 through the BuilderControl instead of the BuilderStatus
4803 (EventBox): add adapter for builder.Event, allowing builder events to
4804 be displayed in the waterfall display
4806 * buildbot/master.py (BotMaster.stopService): add a 'master
4807 shutdown' event to the builder's log
4808 (BuildMaster.startService): and a 'master started' on startup
4810 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4811 builder events into the BuildStep event stream
4812 (Status.builderAdded): add a 'builder created' event
4815 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4816 command to announce the completion of a running build
4817 (IrcStatusBot.command_FORCE): announce when the build finishes
4819 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4820 don't evict unfinished builds from the cache: they must stay in
4821 the full-cache until their logfiles have stopped changing. Make
4822 sure the eviction loop terminates if an unfinished build was hit.
4823 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4824 This lets exceptions be dumped in an email status message. Really
4825 we need LogFiles which contain both text and HTML, instead of two
4827 (BuildStatus.__getstate__): handle self.finished=False
4828 (Status.builderAdded): if the pickle is corrupted, abandon the
4829 history and create a new BuilderStatus object.
4831 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4832 self.progress attribute, helped one test which doesn't fully set
4833 up the Build object.
4835 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4836 IStatusLog methods into an Interface that is implemented by "stub"
4837 logs, for which all the actual text chunks are on disk (in the
4838 pickled Build instance). To show the log contents, you must first
4839 adapt the stub log to a full IStatusLog object.
4841 * buildbot/status/builder.py (LogFileStub): create separate stub
4842 log objects, which can be upgraded to a real one if necessary.
4843 (LogFile): make them persistable, and let them stubify themselves
4845 (BuildStepStatus): same
4847 (BuildStatus.saveYourself): save the whole build out to disk
4848 (BuilderStatus): make it persistable
4849 (BuilderStatus.saveYourself): save the builder to disk
4850 (BuilderStatus.addFullBuildToCache): implement two caches which
4851 hold Build objects: a small one which holds full Builds, and a
4852 larger one which holds "stubbed" Builds (ones with their LogFiles
4853 turned into LogFileStubs). This reduces memory usage by the
4854 buildmaster by not keeping more than a few (default is 2) whole
4855 build logs in RAM all the time.
4856 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4858 (BuilderStatus.eventGenerator): rewrite since .builds went away
4859 (BuilderStatus.buildStarted): remove the .builds array. Add the
4860 build to the "full" cache when it starts.
4861 (BuilderStatus._buildFinished): save the build to disk when it
4863 (Status): give it a basedir (same as the BuildMaster's basedir)
4864 where the builder pickles can be saved
4865 (Status.builderAdded): create the BuilderStatus ourselves, by
4866 loading a pickle from disk (or creating a new instance if there
4867 was none on disk). Return the BuilderStatus so the master can glue
4868 it into the new Builder object.
4870 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4871 all BuilderStatuses to save themselves out to disk. This is in
4872 lieu of saving anything important in the main Application pickle
4873 (the -shutdown.tap file).
4874 (BuildMaster.__init__): give Status() a basedir for its files
4875 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4876 to get the BuilderStatus, then give it to the Builder (instead of
4877 doing it the other way around). It's ok if the status announces
4878 the new Builder before it's really ready, as the outside world can
4879 only see the BuilderStatus object anyway (and it is ready before
4880 builderAdded returns). Use the builder's "builddir" (which
4881 normally specifies where the slave will run the builder) as the
4882 master's basedir (for saving serialized builds).
4884 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4885 coerce the logfile to IStatusLog before trying to get the text
4886 chunks out of it. This will pull the full (non-stubified) Build in
4887 from disk if necessary.
4888 (TextLog): fix the adapter registration
4890 * buildbot/test/test_control.py (Force.setUp): create the basedir
4891 * buildbot/test/test_web.py: same
4892 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4893 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4894 * buildbot/test/test_run.py (Run.testMaster): same
4895 (Status.setUp): same
4897 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4899 * buildbot/status/html.py (Waterfall.__init__): store actual
4900 allowForce flag passed in rather than using True for everyone;
4901 make sure setting it to False doesn't cause a NameError
4903 (StatusResourceBuilder.__init__) add the builder name to the page
4905 (StatusResourceBuilder.body) move HTML generation for a name/value
4906 row into a helper method (StatusResourceBuilder.make_row); only
4907 generate the "Force Build" form if allowForce was True and the
4908 slave is connected. Use class attributes in the generated HTML to
4909 spread a little CSS-joy.
4911 2004-09-28 Brian Warner <warner@lothar.com>
4913 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4914 warning-scanner to not ignore things like
4915 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4917 * buildbot/status/html.py (StatusResource.control): add some
4918 class-level values for .control in an attempt to make upgrading
4921 * buildbot/util.py (ComparableMixin): survive missing attributes,
4922 such as when a class is modified and we're comparing old instances
4925 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4926 failure handling, remove a redundant try/except block. Don't
4927 return the full traceback to the IRC channel.
4928 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4929 error messages. Get ETA properly.
4931 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4932 the reason, since (at least) IRC message will have <> in them.
4933 (StatusResourceBuilder.__init__): take an IBuilderControl
4934 (StatusResourceBuilder.force): use the IBuilderControl we get in
4935 the constructor instead of trying to make our own. Catch the
4936 new exceptions and ignore them for now (until we make an
4937 intermediate web page where we could show the error message)
4938 (StatusResource): create with an IControl, use it to give an
4939 IBuilderControl to all children
4940 (Waterfall): take an allowForce= option, pass an IControl object
4941 to StatusResource if it is True
4943 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4945 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4946 catch new exceptions and return string forms
4948 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4949 * buildbot/process/builder.py (Builder.forceBuild): raise them
4950 * buildbot/test/test_control.py (Force.testNoSlave): new test
4951 (Force.testBuilderInUse): same
4954 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4956 * buildbot/test/test_run.py: use IControl
4957 * buildbot/test/test_vc.py: same
4959 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4960 to use IControl. Still offline.
4961 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4963 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4964 who=None so periodic builds don't send out status mail
4965 (Builder.forceBuild): include reason in the log message
4966 (BuilderControl.forceBuild): rename 'name' to 'who'
4968 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4969 'who' parameter, but make it None by default so builds forced by
4970 slave admins don't cause status mail to be sent to anybody
4971 (BotMaster.forceBuild): same. this method is deprecated.
4972 (DebugPerspective.perspective_forceBuild): same, use IControl.
4973 (DebugPerspective.perspective_fakeChange): use IControl..
4974 (Dispatcher.requestAvatar): .. so don't set .changemaster
4976 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4977 parameter to avoid confusion with the name of the builder
4980 * buildbot/status/mail.py: refine comment about needing 2.3
4982 * buildbot/status/html.py: move all imports to the top
4984 * buildbot/test/test_control.py: test new interfaces
4985 * buildbot/test/test_run.py (Status): handle new interfaces
4986 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4988 * buildbot/process/base.py (BuildControl): implement IBuildControl
4989 and its lonely getStatus() method
4991 * buildbot/process/builder.py (BuilderControl): implement
4992 IBuilderControl, obtained by adapting the Builder instance
4993 (Builder.startBuild): return a BuilderControl instead of a
4994 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4995 accomplish the same thing.
4997 * buildbot/master.py: move all import statements to the top
4998 (Control): implement IControl, obtained by adapting the
4999 BuildMaster instance.
5001 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5002 IBuildControl. These are used to force builds. Eventually they
5003 will provide ways to reconfigure the Builders, pause or abandon a
5004 Build, and perhaps control the BuildMaster itself.
5006 2004-09-26 Brian Warner <warner@lothar.com>
5008 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5009 ends up comparing us against something without a .__class__
5011 2004-09-24 Brian Warner <warner@lothar.com>
5013 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5016 * Makefile: add 'deb-snapshot' target, to create a timestamped
5019 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5021 2004-09-23 Brian Warner <warner@lothar.com>
5023 * buildbot/__init__.py (version): move version string here
5024 * setup.py: get version string from buildbot.version
5025 * buildbot/status/html.py (WaterfallStatusResource.body): add
5026 buildbot version to the page footer
5027 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5030 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5031 slaves, let the second know where the first one is coming from
5032 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5033 see our exceptions. It would be nice if there were a way to just
5034 send them the exception type and value, not the full traceback.
5037 * buildbot/status/mail.py (MailNotifier): add a new argument
5038 sendToInterestedUsers=, which can be set to False to disable the
5039 usual send-to-blamelist behavior.
5040 (top): handle python-2.2 which has no email.MIMEMultipart
5041 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5042 (MailNotifier.disownServiceParent): unsubscribe on removal
5044 * buildbot/test/test_status.py (Mail.testBuild2): test it
5047 * buildbot/status/progress.py (Expectations.wavg): tolerate
5048 current=None, which happens when steps start failing badly
5049 * buildbot/test/test_status.py (Progress.testWavg): test for it
5051 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5052 doesn't understand args['revision'], emit a warning instead of
5053 bailing completely. Updating to -rHEAD is probably close enough.
5055 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5057 * buildbot/test/test_status.py: at least import bb.status.client
5058 even if we don't have any test coverage for it yet
5060 * contrib/svn_buildbot.py: don't require python2.3
5061 (main): wait, do require it (for sets.py), but explain how to
5062 make it work under python2.2
5064 2004-09-23 Brian Warner <warner@lothar.com>
5066 * contrib/svn_buildbot.py: include the revision number in the Change
5068 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5069 using util.now() because FreshCVS is a realtime service
5071 * buildbot/status/event.py: delete dead code
5072 * buildbot/process/step.py: don't import dead Event class
5073 * buildbot/process/step_twisted.py: same
5074 * buildbot/status/builder.py: same
5075 * buildbot/status/client.py: same
5077 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5079 * buildbot/changes/changes.py (Change): set .when from an __init__
5080 argument (which defaults to now()), rather than having
5081 ChangeMaster.addChange set it later.
5082 (ChangeMaster.addChange): same
5084 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5085 (parseSyncmail): same. Just use util.now() for now.
5086 (parseBonsaiMail): parse the timestamp field for when=
5088 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5089 instead of setting .when after the fact
5093 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5094 results when the target project uses retrial. Still under
5096 * buildbot/test/test_trial.py: same
5098 2004-09-21 Brian Warner <warner@lothar.com>
5100 * buildbot/status/mail.py (MailNotifier.__init__): include
5101 success/warnings/failure in the Subject line
5102 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5103 use step.logname for the addLogs=True attachment filenames
5104 * buildbot/test/test_status.py (Mail): test Subject lines
5105 (Mail.testLogs): test attachment filenames
5107 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5108 accept a 'who' argument from the debug tool
5109 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5110 * contrib/debug.glade: add text box to set 'who'
5112 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5113 .getBuilderName with .getBuilder().getName(), more flexible
5114 (IStatusLog.getName): logs have short names, but you can prefix
5115 them with log.getStep().getName() to make them more useful
5116 * buildbot/status/builder.py: same
5117 * buildbot/status/client.py: same
5118 * buildbot/status/html.py: same
5119 * buildbot/test/test_run.py (Status.testSlave): same
5120 * buildbot/process/step.py: tweak logfile names
5122 * buildbot/status/mail.py (MailNotifier): add lookup, change
5123 argument to extraRecipients. The notifier is now aimed at sending
5124 mail to the people involved in a particular build, with additional
5125 constant recipients as a secondary function.
5127 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5128 including slow-lookup and failing-lookup. Make sure the blamelist
5129 members are included.
5131 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5132 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5133 (IBuildStatus.getInterestedUsers): new method
5134 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5135 * buildbot/status/client.py (remote_getResponsibleUsers): same
5136 * buildbot/status/html.py (StatusResourceBuild.body): same
5137 * buildbot/test/test_run.py (Status.testSlave): same
5139 2004-09-20 Brian Warner <warner@lothar.com>
5141 * docs/users.xhtml: update concepts
5143 * Makefile: add a convenience makefile, for things like 'make
5144 test'. It is not included in the source tarball.
5146 2004-09-16 Brian Warner <warner@lothar.com>
5148 * NEWS: mention /usr/bin/buildbot, debian/*
5150 * debian/*: add preliminary debian packaging. Many thanks to
5151 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5152 it considerably since it left their hands, I am responsible for
5153 all breakage that's resulted.
5155 * bin/buildbot: create a top-level 'buildbot' command, to be
5156 installed in /usr/bin/buildbot . For now it's just a simple
5157 frontend to mktap/twistd/kill, but eventually it will be the entry
5158 point to the 'try' command and also a status client. It is also
5159 intended to support the upcoming debian-packaging init.d scripts.
5160 * buildbot/scripts/runner.py: the real work is done here
5161 * buildbot/scripts/__init__.py: need this too
5162 * buildbot/scripts/sample.cfg: this is installed in new
5163 buildmaster directories
5164 * setup.py: install new stuff
5166 2004-09-15 Brian Warner <warner@lothar.com>
5168 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5169 'file:' schema (the version shipped with OS-X was built without the
5171 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5172 updates the log-timestamp, to make sure it isn't still running after
5175 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5176 values to the config file.
5177 * docs/examples/hello.cfg: add examples
5178 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5179 * buildbot/status/builder.py (Status.getProjectURL): implement them
5180 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5181 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5182 * buildbot/status/html.py (WaterfallStatusResource): display them
5185 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5186 certain error cases don't suffer a secondary exception.
5187 (top): Skip tests if the corresponding VC tool is not installed.
5189 * buildbot/process/factory.py (Trial): introduce separate
5190 'buildpython' and 'trialpython' lists, since trialpython=[] is
5191 what you want to invoke /usr/bin/python, whereas ./setup.py is
5192 less likely to be executable. Add env= parameter to pass options
5193 to test cases (which is how I usually write tests, I don't know if
5194 anyone else does it this way).
5196 * buildbot/process/step_twisted.py (Trial): handle python=None.
5197 Require 'testpath' be a string, not a list. Fix tests= typo.
5198 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5200 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5201 way to deal with the possibility of removing the disconnect notify
5203 (CVS): add a 'login' parameter to give a password to 'cvs login',
5204 commonly used with pserver methods (where pw="" or pw="guest")
5206 * buildbot/slave/commands.py (SourceBase): move common args
5207 extraction and setup() to __init__, so everything is ready by the
5208 time setup() is called
5209 (CVS.start): call 'cvs login' if a password was supplied
5210 (ShellCommand): special-case PYTHONPATH: prepend the master's
5211 value to any existing slave-local value.
5213 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5214 don't have a remote, mark the builder as Offline. This whole
5215 function should probably go away and be replaced by individual
5217 (Builder.buildFinished): return the results to the build-finished
5218 deferred callback, helps with testing
5220 2004-09-14 Brian Warner <warner@lothar.com>
5222 * buildbot/test/test_vc.py: put all the repositories needed to run
5223 the complete tests into a single small (1.3MB) tarball, so I can
5224 make that tarball available on the buildbot web site. Test HTTP
5225 access (for Arch and Darcs) by spawning a temporary web server
5226 while the test runs.
5228 * docs/users.xhtml: new document, describe Buildbot's limited
5229 understanding of different human users
5231 * buildbot/test/test_vc.py: rearrange test cases a bit
5233 * buildbot/process/step_twisted.py (Trial): handle testpath=
5234 * buildbot/process/factory.py (Trial): update to use step.Trial
5236 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5238 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5239 the overall build text (which gives you 'failed 2 tests' rather
5241 (BuildStepStatus.text2): default to [], not None
5243 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5246 2004-09-12 Brian Warner <warner@lothar.com>
5248 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5249 log the whole exception if it's just an AttributeError (old slave)
5251 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5252 so (e.g.) sub-commands can be run in the right directory.
5253 (ShellCommand.start): accept an optional errorMessage= argument
5254 to make life easier for SVN.start
5255 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5257 (ShellCommand.start): move ['dir'] compatibility hack..
5258 (RemoteShellCommand.start): .. to here so everyone can use it
5260 * buildbot/process/step_twisted.py (Trial): use .workdir
5262 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5263 text displayed when debuild fails completely
5264 (Trial): snarf _trial_temp/test.log from the slave and display it
5266 2004-09-11 Brian Warner <warner@lothar.com>
5268 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5270 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5271 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5273 * buildbot/process/step.py (ShellCommand): call .createSummary
5274 before .evaluateCommand instead of the other way around. This
5275 makes it slightly easier to count warnings and then use that to
5276 set results=WARNINGS
5277 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5279 * buildbot/process/base.py (Build.buildFinished): update status
5280 before doing progress. It's embarrassing for the build to be stuck
5281 in the "building" state when an exceptions occurs elsewhere..
5283 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5284 python2.2 doesn't have 'sum'
5286 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5287 to prevent clients from accidentally sorting it
5289 * buildbot/master.py (Manhole): add username/password
5290 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5291 c['manholePort'], deprecate old usage
5292 * docs/config.xhtml: document c['manhole']
5293 * docs/examples/hello.cfg: show example of using a Manhole
5296 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5297 pretend the slave is up to date
5299 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5300 the module, overlaps with 'log', the local variable
5302 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5304 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5305 new method to let Steps find out the version of their
5306 corresponding SlaveCommand.
5307 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5308 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5309 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5311 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5312 (Arch.startVC): same
5313 (P4Sync.startVC): same
5315 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5316 Deferred so we can catch errors in remote_startCommand
5317 (RemoteShellCommand.start): same
5319 * docs/examples/twisted_master.cfg: update sample config file
5321 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5322 after connectionMade() is called, not before. Close stdin at that
5325 * buildbot/process/process_twisted.py: update to use Trial, clean
5326 up argument passing (move to argv arrays instead of string
5329 * buildbot/process/step_twisted.py (Trial): new step to replace
5330 RunUnitTests, usable by any trial-using project (not just
5331 Twisted). Arguments have changed, see the docstring for details.
5333 * buildbot/process/base.py (Build.startBuild): this now returns a
5334 Deferred. Exceptions that occur during setupBuild are now
5335 caught better and lead to fewer build_status weirdnesses, like
5336 finishing a build that was never started.
5337 (Build.buildFinished): fire the Deferred instead of calling
5338 builder.buildFinished directly. The callback argument is this
5339 Build, everything else can be extracted from it, including the
5340 new build.results attribute.
5341 * buildbot/process/builder.py (Builder.startBuild): same
5342 (Builder.buildFinished): same, extract results from build
5344 * buildbot/process/step.py (ShellCommands): remove dead code
5346 2004-09-08 Brian Warner <warner@lothar.com>
5348 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5349 doesn't try to use the leftover patched workdir
5350 (SourceStamp): test source-stamp computation for CVS and SVN
5352 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5353 patched workdir ('touch .buildbot-patched') so we don't try to
5355 (SourceBase.start): add ['revision'] for all Source steps
5356 (CVS): change args: use ['branch'] for -r, remove ['files']
5357 (CVS.buildVC): fix revision/branch stuff
5358 (SVN): add revision stuff
5360 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5361 kwargs (except 'workdir') to avoid silent spelling errors
5362 (ShellCommand.__init__): same
5363 (Source): new base class for CVS/SVN/etc. Factor out everything
5364 common, add revision computation (perform the checkout with a -D
5365 DATE or -r REVISION that gets exactly the sources described by the
5366 last Change), overridable with step.alwaysUseLatest. Add patch
5367 handling (build.getSourceStamp can trigger the use of a base
5368 revision and a patch).
5369 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5370 * docs/steps.xhtml: update docs
5371 * docs/source.xhtml: mention .checkoutDelay
5372 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5374 * buildbot/process/base.py (Build.setSourceStamp): add a
5375 .sourceStamp attribute to each Build. If set, this indicates that
5376 the build should be done with something other than the most
5377 recent source tree. This will be used to implement "try" builds.
5378 (Build.allChanges): new support method
5379 (Build.lastChangeTime): remove, functionality moved to Source steps
5380 (Build.setupBuild): copy the Step args before adding ['workdir'],
5381 to avoid modifying the BuildFactory (and thus triggering spurious
5385 * buildbot/status/html.py: rename s/commits/changes/
5386 (StatusResourceChanges): same
5387 (CommitBox.getBox): same, update URL
5388 (WaterfallStatusResource): same
5389 (StatusResource.getChild): same
5391 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5392 * contrib/debug.glade: add optional 'revision' to the fakeChange
5394 * buildbot/changes/changes.py (html_tmpl): display .revision
5395 (ChangeMaster.addChange): note .revision in log
5396 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5397 accept a ['revision'] attribute
5399 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5401 * buildbot/master.py (BotMaster.getPerspective): update the
5402 .connected flag in SlaveStatus when it connects
5403 (BotMaster.detach): and when it disconnects
5404 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5405 (BuildMaster.loadConfig_Builders): walk old list correctly
5407 * buildbot/test/test_config.py: fix prefix= usage
5409 2004-09-06 Brian Warner <warner@lothar.com>
5413 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5414 poll a P4 depot looking for recent changes. Thanks to Dave
5415 Peticolas for the contribution. Probably needs some testing after
5418 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5419 requires manual client setup for each buildslave. Rather
5420 experimental. Thanks again to Dave Peticolas.
5421 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5423 * buildbot/changes/changes.py (Change): add a .revision attribute,
5424 which will eventually be used to generate source-stamp values.
5426 * buildbot/process/step.py (RemoteCommand.start): use
5427 notifyOnDisconnect to notice when we lose the slave, then treat it
5428 like an exception. This allows LogFiles to be closed and the build
5429 to be wrapped up normally. Be sure to remove the disconnect
5430 notification when the step completes so we don't accumulate a
5431 bazillion such notifications which will fire weeks later (when the
5432 slave finally disconnects normally). Fixes SF#915807, thanks to
5433 spiv (Andrew Bennetts) for the report.
5434 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5435 really isn't Logged- specific
5436 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5437 header, since it's almost always going to be appended to an
5439 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5440 update test to handle use of notifyOnDisconnect
5442 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5443 don't clear .ETA and .currentBuild when going offline, let the
5444 current build clean up after itself
5446 * buildbot/process/builder.py (Builder.detached): wait a moment
5447 before doing things like stopping the current build, because the
5448 current step will probably notice the disconnect and cleanup the
5450 * buildbot/test/test_run.py (Status.tearDown): update test to
5451 handle asynchronous build-detachment
5453 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5455 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5456 hush a debug message
5458 2004-09-05 Brian Warner <warner@lothar.com>
5460 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5461 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5462 kernels do this: the fcntl module has the F_NOTIFY constant, but
5463 the kernel itself doesn't support the operation. Thanks to Olly
5464 Betts for spotting the problem.
5466 * buildbot/process/step.py (Darcs): new source-checkout command
5467 (Arch): new source-checkout command
5468 (todo_P4): fix constructor syntax, still just a placeholder
5469 * buildbot/test/test_vc.py (VC.testDarcs): test it
5470 (VC.testDarcsHTTP): same, via localhost HTTP
5472 (VC.testArchHTTP): same
5473 * NEWS: mention new features
5475 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5476 which tells the step to stash stdout text locally (in .stdout).
5477 Slave-side Commands can use this to make decisions based upon the
5478 output of the the ShellCommand (not just the exit code).
5479 (Darcs): New source-checkout command
5480 (Arch): New source-checkout command, uses .keepStdout in one place
5481 where it needs to discover the archive's default name.
5483 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5484 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5485 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5487 * buildbot/process/step.py (ShellCommand.describe): add an
5488 alternate .descriptionDone attribute which provides descriptive
5489 text when the step is complete. .description can be ["compiling"],
5490 for use while the step is running, then .descriptionDone can be
5491 ["compile"], used alone when the step succeeds or with "failed" when
5492 it does not. Updated other steps to use the new text.
5493 * buildbot/process/step_twisted.py: same
5494 * buildbot/test/test_run.py: update tests to match
5496 2004-08-30 Brian Warner <warner@lothar.com>
5498 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5499 (CVS.__init__): send 'patch' argument to slave
5500 (CVS.start): don't create the LoggedRemoteCommand until start(),
5501 so we can catch a .patch added after __init__
5502 (SVN.__init__): add 'patch' to SVN too
5505 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5506 argument, to let commands push data into the process' stdin pipe.
5507 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5508 is in use, since closing a PTY doesn't really affect the process
5509 in the right way (in particular, I couldn't run /usr/bin/patch
5511 (SourceBase.doPatch): handle 'patch' argument
5513 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5516 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5517 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5519 * buildbot/master.py (BotPerspective.got_commands): get command
5520 versions from slave, give to each builder
5521 * buildbot/process/builder.py (Builder.attached): stash slave
5522 command versions in .remoteCommands
5524 * docs/steps.xhtml: bring docs in-line with reality
5526 * buildbot/process/step.py (CVS.__init__): more brutal
5527 compatibility code removal
5528 (SVN.__init__): same
5530 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5531 (SlaveShellCommand.start): require ['workdir'] argument, remove
5532 the ['dir'] fallback (compatibility will come later)
5533 (SourceBase): update docs
5534 (SourceBase.start): remove ['directory'] fallback
5537 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5538 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5539 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5541 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5542 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5543 code.. I will figure out 0.5.0-compatibility hooks later)
5545 2004-08-30 Brian Warner <warner@lothar.com>
5547 * buildbot/process/process_twisted.py: rewrite in terms of new
5548 BuildFactory base class. It got significantly shorter. Yay
5551 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5552 work with the new "self.build isn't nailed down until we call
5553 step.start()" scheme: specifically, __init__ is called before the
5554 build has decided on which Changes are going in, so we don't scan
5555 build.allFiles() for .xhtml files until start()
5556 (HLint.commandComplete): use getText(), not getStdout()
5557 (RunUnitTests.start): same: don't use .build until start()
5558 (RunUnitTests.describe): oops, don't report (None) when using
5560 (RunUnitTests.commandComplete): use getText()
5561 (RunUnitTests.createSummary): same
5562 (BuildDebs.commandComplete): same
5564 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5565 set args['command'] until start(), since our BuildStep is allowed
5566 to change their mind up until that point
5567 (TreeSize.commandComplete): use getText(), not getStdout()
5569 * docs/examples/twisted_master.cfg: update to current standards
5571 * docs/factories.xhtml: update
5572 * buildbot/process/factory.py: implement all the common factories
5573 described in the docs. The Trial factory doesn't work yet, and
5574 I've probably broken all the process_twisted.py factories in the
5575 process. There are compatibility classes left in for things like
5576 the old BasicBuildFactory, but subclasses of them are unlikely to
5578 * docs/examples/glib_master.cfg: use new BuildFactories
5579 * docs/examples/hello.cfg: same
5581 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5582 explicit 'workdir' args
5584 * buildbot/process/base.py (BuildFactory): move factories to ..
5585 * buildbot/process/factory.py (BuildFactory): .. here
5586 * buildbot/process/process_twisted.py: handle move
5587 * buildbot/test/test_config.py: same
5588 * buildbot/test/test_run.py: same
5589 * buildbot/test/test_steps.py: same
5590 * buildbot/test/test_vc.py: same
5591 * docs/factories.xhtml: same
5593 * NEWS: mention config changes that require updating master.cfg
5595 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5596 argument to all steps that weren't given one already, pointing at
5597 the "build/" directory.
5599 * docs/examples/hello.cfg: remove explicit 'workdir' args
5601 * docs/factories.xhtml: document standard BuildFactory clases,
5602 including a bunch which are have not yet been written
5604 2004-08-29 Brian Warner <warner@lothar.com>
5606 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5607 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5608 buildbot.status.builder so they aren't quite so internal
5609 * buildbot/process/base.py, buildbot/process/builder.py: same
5610 * buildbot/process/maxq.py, buildbot/process/step.py: same
5611 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5612 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5613 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5615 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5616 to handle new getLogs()-returns-list behavior
5617 (StatusResourceBuildStep.getChild): same
5618 (StepBox.getBox): same
5619 (WaterfallStatusResource.phase0): same
5621 * docs/source.xhtml: document how Buildbot uses version-control
5622 systems (output side: how we get source trees)
5623 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5624 systems (input side: how we learn about Changes)
5626 * buildbot/master.py (Manhole): use ComparableMixin
5627 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5628 * buildbot/changes/mail.py (MaildirSource): same
5629 * buildbot/status/client.py (PBListener): same
5630 * buildbot/status/html.py (Waterfall): same
5631 * buildbot/status/words.py (IRC): same
5633 * NEWS: start describing new features
5635 * buildbot/status/mail.py (MailNotifier): finish implementation.
5636 The message body is still a bit sparse.
5637 * buildbot/test/test_status.py (Mail): test it
5639 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5640 and __hash__ methods I wind up adding everywhere. Specifically
5641 intended to support the buildbot config-file update scheme where
5642 we compare, say, the old list of IStatusTargets against the new
5643 one and don't touch something which shows up on both lists.
5644 * buildbot/test/test_util.py (Compare): test case for it
5646 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5647 return a list instead of a dict
5648 (IBuildStepStatus.getLogs): same. The idea is that steps create
5649 logs with vaguely unique names (although their uniqueness is not
5650 guaranteed). Thus a compilation step should create its sole
5651 logfile with the name 'compile', and contribute it to the
5652 BuildStatus. If a step has two logfiles, try to create them with
5653 different names (like 'test.log' and 'test.summary'), and only
5654 contribute the important ones to the overall BuildStatus.
5655 * buildbot/status/builder.py (Event.getLogs): same
5656 (BuildStepStatus): fix default .text and .results
5657 (BuildStepStatus.addLog): switch to list-like .getLogs()
5658 (BuildStepStatus.stepFinished): same
5659 (BuildStatus.text): fix default .text
5660 (BuildStatus.getLogs): temporary hack to return all logs (from all
5661 child BuildStepStatus objects). Needs to be fixed to only report
5662 the significant ones (as contributed by the steps themselves)
5663 * buildbot/test/test_run.py: handle list-like .getLogs()
5664 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5666 2004-08-28 Brian Warner <warner@lothar.com>
5668 * buildbot/process/builder.py (Builder.attached): serialize the
5669 attachment process, so the attach-watcher isn't called until the
5670 slave is really available. Add detached watchers too, which makes
5673 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5675 * buildbot/test/test_swap.py: remove dead code
5677 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5678 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5679 sort of as if the command being run exited with a -1. There may
5680 still be some holes in this scheme.
5681 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5682 -r option appears before the module list
5683 * buildbot/process/step.py (CVS): add 'revision' argument
5685 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5686 when sending updates or stepComplete messages to the master, since
5687 we don't currently care whether they arrive or not. When we revamp
5688 the master/slave protocol to really resume interrupted builds,
5689 this will need revisiting.
5690 (lostRemote): remove spurious print
5692 * buildbot/master.py (BotPerspective.attached): serialize the
5693 new-builder interrogation process, to make testing easier
5694 (BotMaster.waitUntilBuilderDetached): convenience function
5696 * buildbot/status/builder.py (BuilderStatus): prune old builds
5697 (BuildStatus.pruneSteps): .. and steps
5698 (BuildStepStatus.pruneLogs): .. and logs
5699 (BuilderStatus.getBuild): handle missing builds
5700 * buildbot/status/html.py (StatusResourceBuild.body): display build
5701 status in the per-build page
5702 (BuildBox.getBox): color finished builds in the per-build box
5704 2004-08-27 Brian Warner <warner@lothar.com>
5706 * buildbot/status/mail.py (MailNotifier): new notification class,
5709 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5710 variants of a common base class which handles all the mode= logic
5712 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5714 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5716 2004-08-26 Brian Warner <warner@lothar.com>
5718 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5721 * buildbot/test/test_run.py: update to new Logfile interface, new
5722 buildbot.slave modules
5723 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5725 * MANIFEST.in: new sample config file
5726 * docs/examples/hello.cfg: same
5728 * buildbot/process/step_twisted.py: remove dead import
5730 * buildbot/process/step.py (RemoteCommand.run): catch errors
5732 (RemoteCommand.remote_update): ignore updates that arrive after
5734 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5735 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5736 the responsibilities of the subclass's methods
5737 (BuildStep.failed): catch errors during failure processing
5738 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5739 (CVS): move to a mode= argument (described in docstring), rather
5740 than the ungainly clobber=/export=/copydir= combination.
5741 (SVN): add mode= functionality to SVN too
5742 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5744 * buildbot/process/base.py (Build.startNextStep): catch errors
5745 during s.startStep()
5747 * buildbot/clients/base.py: update to new PB client interface.
5748 gtkPanes is still broken
5750 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5751 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5752 * setup.py: add buildbot.slave module
5753 * buildbot/bb_tap.py: handle move
5754 * buildbot/slave/registry.py: place to register commands, w/versions
5755 * buildbot/slave/bot.py: major simplifications
5756 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5757 instead of a fixed table. Eventually this will make the slave more
5758 extensible. Use 'start' method on the command, not .startCommand.
5759 Fix unsafeTracebacks handling (I think).
5760 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5761 helper class with a .start method that returns a Deferred.
5762 SlaveShellCommand is the form reached by the buildmaster. Commands
5763 which use multiple ShellCommands can just chain them as Deferreds,
5764 with some helper methods in Command (_abandonOnFailure and
5765 _checkAbandoned) to bail on rc!=0.
5766 (CVSCommand): prefer new mode= argument
5767 (SVNFetch): add mode= argument
5769 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5770 put a useful reason string on the build
5772 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5773 core functionality into an IStatusLog object
5774 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5775 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5776 (StatusResourceBuild.body): use proper accessor methods
5777 * buildbot/status/client.py (RemoteLog): PB-access goes here
5778 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5779 which delivers log contents too
5780 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5781 * buildbot/status/event.py: remove old Logfile completely
5783 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5784 subscription interface for IStatusLog subscriptions just like all
5785 other the status subscriptions
5786 (IStatusReceiver.logChunk): method called on subscribers
5788 2004-08-24 Brian Warner <warner@lothar.com>
5790 * buildbot/process/builder.py (Builder._pong): oops, ping response
5791 includes a result (the implicit None returned by remote_print).
5792 Accept it so the _pong method handles the response correctly.
5794 2004-08-06 Brian Warner <warner@lothar.com>
5796 * buildbot/test/test_config.py: update IRC, PBListener tests
5798 * buildbot/status/client.py (StatusClientPerspective): total
5799 rewrite to match new IStatus interfaces. New subscription scheme.
5800 There are still a few optimizations to make (sending down extra
5801 information with event messages so the client doesn't have to do a
5802 round trip). The logfile-retrieval code is probably still broken.
5803 Moved the PB service into its own port, you can no longer share a
5804 TCP socket between a PBListener and, say, the slaveport (this
5805 should be fixed eventually).
5806 * buildbot/clients/base.py (Client): revamp to match. still needs
5807 a lot of work, but basic event reporting works fine. gtkPanes is
5810 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5811 instance talks to a single irc server. Threw out all the old
5812 multi-server handling code. Still need to add back in
5813 builder-control (i.e. "force build")
5815 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5816 more random text to the as-yet-unreachable per-step page
5818 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5819 rename to stepETAUpdate
5820 (BuildStatus.subscribe): add build-wide ETA updates
5821 (BuilderStatus.getState): remove more cruft
5822 (BuilderStatus.getCurrentBuild): remove more cruft
5823 (BuilderStatus.buildStarted): really handle tuple-subscription
5824 * buildbot/test/test_run.py (Status.testSlave): handle the
5825 stepETAUpdate rename
5827 * buildbot/master.py (BuildMaster): don't add a default
5828 StatusClientService. Don't add a default IrcStatusFactory. Both
5829 are now added through c['status'] in the config file. c['irc'] is
5830 accepted for backwards compatibility, the only quirk is you cannot
5831 use c['irc'] to specify IRC servers on ports other than 6667.
5833 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5834 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5835 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5836 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5839 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5840 the buildmaster to re-read its config file
5843 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5844 find out the port our server is running on
5845 (WebTest.test_webPathname_port): same
5847 * buildbot/test/test_config.py (testWebPortnum): test it
5848 (testWebPathname): ditto
5850 * docs/config.xhtml: document new c['status'] configuration option
5852 * buildbot/status/html.py (Waterfall): new top-level class which
5853 can be added to c['status']. This creates the Site as well as the
5854 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5855 reachable as .parent, for everything.
5857 * buildbot/master.py (Manhole): make it a normal service Child
5858 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5859 webPathname. It will eventually replace c['irc'] and the implicit
5860 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5861 in as (deprecated) backward compatibility hooks for now.
5864 * buildbot/process/builder.py (Builder.buildFinished): don't
5865 inform out builder_status about a finished build, as it finds out
5866 through its child BuildStatus object
5868 * buildbot/status/html.py: extensive revamp. Use adapters to make
5869 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5870 have both starting and finishing times and adjust the waterfall
5871 display accordingly, using spacers if necessary. Use SlaveStatus
5872 to get buildslave info.
5873 (StatusResourceBuildStep): new just-one-step resource, used to get
5874 logfiles. No actual href to it yet.
5876 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5877 the time being, until I get the file-naming scheme right
5879 * buildbot/status/builder.py (Event): clean started/finished names
5880 (BuildStatus.isFinished): .finished is not None is the right test
5881 (BuildStatus.buildStarted): track started/finished times ourselves
5882 (BuilderStatus.getSlave): provide access to SlaveStatus object
5883 (BuilderStatus.getLastFinishedBuild): all builds are now in
5884 .builds, even the currently-running one. Accomodate this change.
5885 (BuilderStatus.eventGenerator): new per-builder event generator.
5886 Returns BuildStepStatus and BuildStatus objects, since they can
5887 both be adapted as necessary.
5888 (BuilderStatus.addEvent): clean up started/finished attributes
5889 (BuilderStatus.startBuild,finishBuild): remove dead code
5890 (SlaveStatus): new object to provide ISlaveStatus
5892 * buildbot/process/step.py (ShellCommand.getColor): actually
5893 return the color instead of setting it ourselves
5894 (CVS.__init__): pull .timeout and .workdir options out of
5895 **kwargs, since BuildStep will ignore them. Without this neither
5896 will be sent to the slave correctly.
5897 (SVN.__init__): same
5899 * buildbot/process/builder.py (Builder): move flags to class-level
5901 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5902 SlaveStatus handle that
5904 * buildbot/process/base.py (Build.firstEvent): remove dead code
5905 (Build.stopBuild): bugfix
5907 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5909 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5910 (ChangeMaster.eventGenerator): yield Changes, since there are now
5911 Adapters to turn them into HTML boxes
5913 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5914 (BotPerspective.attached): feed a SlaveStatus object
5915 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5916 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5918 * buildbot/interfaces.py: API additions
5919 (ISlaveStatus): place to get slave status
5921 2004-08-04 Brian Warner <warner@lothar.com>
5923 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5924 the delay finishes, so the step is marked as SUCCESS
5926 * buildbot/test/test_run.py (Status.testSlave): cover more of
5927 IBuildStatus and IBuildStepStatus
5929 * buildbot/status/progress.py (StepProgress): move some flags to
5930 class-level attributes
5931 (StepProgress.remaining): if there are no other progress metrics
5932 to go by, fall back to elapsed time
5933 (StepProgress.setExpectations): take a dict of metrics instead of
5935 (BuildProgress.setExpectationsFrom): pull expectations from the
5936 Expectations, instead of having it push them to the BuildProgress
5937 (Expectations): move some flags to class-level attributes
5938 (Expectations.__init__): copy per-step times from the
5940 (Expectations.expectedBuildTime): new method for per-build ETA
5942 * buildbot/status/event.py (Logfile): move some flags to
5943 class-level attributes
5944 (Logfile.logProgressTo): better method name, let step set the
5945 progress axis name (instead of always being "output")
5947 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5948 times directly, rather than depending upon the (possibly missing)
5949 .progress object. Use 'None' to indicate "not started/finished
5951 (BuildStepStatus.getExpectations): oops, return the full list of
5953 (BuilderStatus._buildFinished): append finished builds to .builds
5955 * buildbot/process/step.py (BuildStep): add separate .useProgress
5956 flag, since empty .progressMetrics[] still implies that time is a
5958 (CVS): set up the cmd in __init__, instead of waiting for start()
5960 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5961 calculation, this will eventually turn into a proper sourceStamp
5962 (Build.setupBuild): tell the Progress to load from the Expectations,
5963 instead of having the Expectations stuff things into the Progress
5964 (Build.buildException): add a build-level errback to make sure the
5965 build's Deferred fires even in case of exceptions
5967 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5969 * buildbot/process/builder.py (Builder.forceBuild): convey the
5970 reason instead of creating a fake Change
5972 * docs/examples/twisted_master.cfg: update to match reality
5974 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5975 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5976 fix or remove broken/breaking tests
5978 * buildbot/status/event.py (Logfile.__len__): remove evil method
5980 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5981 missing .build, for test convenience
5983 * buildbot/process/step_twisted.py: import fixes
5985 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5987 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5988 .statusbag reference
5990 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5991 connection at shutdown, and stop it from reconnecting
5993 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5994 chase down remote-execution bugs
5996 * buildbot/process/step.py: more fixes, remove
5997 BuildStep.setStatus()
5998 * buildbot/status/builder.py: move setStatus() functionality into
6000 * buildbot/status/event.py: minor fixes
6002 2004-08-03 Brian Warner <warner@lothar.com>
6004 * buildbot/process/base.py, buildbot/process/builder.py
6005 * buildbot/process/step.py, buildbot/status/builder.py
6006 * buildbot/status/event.py, buildbot/test/test_run.py:
6007 fix status delivery, get a basic test case working
6008 * buildbot/master.py: finish implementing basic status delivery,
6009 temporarily disable HTML/IRC/PB status sources
6011 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6013 * buildbot/status/progress.py (BuildProgress): remove dead code
6015 * buildbot/interfaces.py
6016 * buildbot/process/base.py, buildbot/process/builder.py
6017 * buildbot/process/step.py, buildbot/process/step_twisted.py
6018 * buildbot/status/builder.py: Complete overhaul of the all
6019 status-delivery code, unifying all types of status clients (HTML,
6020 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6021 look like. This commit is a checkpointing of the work-in-progress:
6022 the input side is mostly done (Builders/Builds sending status
6023 to the BuilderStatus/BuildStatus objects), but the output side has
6024 not yet been started (HTML resources querying BuilderStatus
6025 objects). Things are probably very broken right now and may remain
6026 so for several weeks, I apologize for the disruption.
6028 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6029 HTML as the log's contents. Currently used for exception tracebacks.
6030 * buildbot/status/progress.py: minor spelling changes
6032 2004-08-02 Brian Warner <warner@lothar.com>
6034 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6035 in mozilla. Also added stylesheets copied from Twisted's docs.
6036 Remember that these files are meant to be run through Lore first.
6037 Thanks to Philipp Frauenfelder for the fixes.
6038 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6039 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6040 * docs/template.tpl: added a Lore template
6042 2004-07-29 Brian Warner <warner@lothar.com>
6044 * buildbot/interfaces.py: revamp status delivery. This is the
6045 preview: these are the Interfaces that will be provided by new
6046 Builder code, and to which the current HTML/IRC/PB status
6047 displayers will be adapted.
6049 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6050 on the SlaveBuilder, not the Bot.
6051 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6053 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6054 set .usePTY on the FakeSlaveBuilder
6056 2004-07-25 Brian Warner <warner@lothar.com>
6058 * buildbot/changes/freshcvs.py: add some debug log messages
6059 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6060 disabled 'setFilter' syntax
6061 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6062 don't end with a slash
6064 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6066 * setup.py: bump to 0.5.0+ while between releases
6068 2004-07-23 Brian Warner <warner@lothar.com>
6070 * setup.py (version): Releasing buildbot-0.5.0
6072 2004-07-23 Brian Warner <warner@lothar.com>
6074 * README: update for 0.5.0 release
6076 * NEWS: update for 0.5.0 release
6078 2004-07-22 Brian Warner <warner@lothar.com>
6080 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6081 mktap-time configuration flag (--usepty=1, --usepty=0)
6082 * buildbot/bot.py: same
6084 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6085 an 'info' directory being unwanted
6087 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6088 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6089 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6090 and earlier), use a FreshCVSSourceOldcred instead.
6091 (test): simple test routine: connect to server, print changes
6093 * buildbot/changes/changes.py (Change.getTime): make it possible
6094 to print un-timestamped changes
6096 * buildbot/master.py (makeApp): delete ancient dead code
6097 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6098 * buildbot/test/test_config.py (testFindConfigFile): test it
6100 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6101 instead of win32 one
6104 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6105 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6108 * buildbot/process/base.py (Builder.__init__): change constructor
6109 to accept a dictionary of config data, rather than discrete
6110 name/slave/builddir/factory arguments
6112 * docs/examples/twisted_master.cfg: update to new syntax
6113 * docs/examples/glib_master.cfg: same
6114 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6115 rough tests of the new syntax
6118 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6119 to be an int, which means "run a web.distrib sub-server on a TCP
6120 port". This lets you publish the buildbot status page to a remote
6121 twisted.web server (using distrib.ResourceSubscription). Also
6122 rename the local attributes used to hold these web things so
6123 they're more in touch with reality.
6124 * buildbot/test/test_web.py: test webPortnum and webPathname
6125 * docs/config.xhtml: document this new use of webPathname
6127 * docs/config.xhtml: new document, slightly ahead of reality
6129 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6130 'prefix' handling: treat it as a simple string to check with
6131 .startswith, instead of treating it as a directory. This allows
6132 sub-directories to be used. If you use prefix=, you should give it
6133 a string that starts just below the CVSROOT and ends with a slash.
6134 This prefix will be stripped from all filenames, and filenames
6135 which do not start with it will be ignored.
6137 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6139 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6140 and --exclude (inverse of --include). SVN post-commit hooks
6141 now have total control over which changes get sent to buildbot and which
6144 2004-07-10 Brian Warner <warner@lothar.com>
6146 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6147 test case to match new API
6149 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6150 which crashed HTML display when self.entries=[] (needed to
6151 distinguish between [], which means "no entries yet", and None,
6152 which means "the entries have been swapped out to disk, go fetch
6155 2004-07-04 Brian Warner <warner@lothar.com>
6157 * buildbot/process/step_twisted.py (countFailedTests): Count
6158 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6159 10kb from the end because any import errors are wedged there and
6160 they would make us think the test log was unparseable.
6161 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6163 2004-06-26 Brian Warner <warner@lothar.com>
6165 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6166 delete-*.pyc command into an actual BuildStep, so we can label it
6168 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6169 (FullTwistedBuildFactory): same
6171 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6173 * contrib/fakechange.py: Add an errback when sending the fake
6174 change, so we know it didn't work.
6176 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6178 * buildbot/process/step_twisted.py: Delete *.pyc files before
6179 calling trial, so it doesn't catch any old .pyc files whose .py
6180 files have been moved or deleted.
6182 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6183 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6184 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6185 instead of ["twisted.test"], so that the end result is "trial -R
6188 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6189 regular expression to match filenames that should be ignored when
6190 changed. Also add a --revision parameter that specifies the
6191 revision to examine, which is useful for debugging.
6193 2004-06-25 Brian Warner <warner@lothar.com>
6195 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6196 summary of warnings (like DeprecationWarnings), next to the
6199 2004-05-13 Brian Warner <warner@lothar.com>
6201 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6202 we now have a w32 build slave courtesy of Mike Taylor.
6204 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6205 so broken. Fixed a race condition that tripped up interlocked
6206 builds and caused the status to be stuck at "Interlocked" forever.
6207 The twisted buildbot's one interlocked build just so happened to
6208 never hit this case until recently (the feeding builds both pass
6209 before the interlocked build is attempted.. usually it has to wait
6211 (Builder._pong_failed): fix method signature
6213 * setup.py: bump to 0.4.3+ while between releases
6215 2004-04-30 Brian Warner <warner@lothar.com>
6217 * setup.py (version): Releasing buildbot-0.4.3
6219 2004-04-30 Brian Warner <warner@lothar.com>
6221 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6223 * README: update for 0.4.3 release
6225 * NEWS: update for 0.4.3 release
6227 * buildbot/master.py (BuildMaster.__getstate__): make sure
6228 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6230 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6231 .trial as a class attribute, for upgrade from 0.4.2
6233 * buildbot/changes/changes.py (Change.links): add .links for
6236 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6237 .textWatchers and .htmlWatchers at save time, since they are both
6238 volatile, should allow smooth 0.4.2 upgrade
6240 * buildbot/process/step.py (CVS.finishStatus): catch failed
6241 CVS/SVN commands so we can make the status box red
6243 2004-04-29 Brian Warner <warner@lothar.com>
6245 * buildbot/changes/freshcvs.py
6246 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6247 code to do setFilter(), which tells the freshcvs daemon to not
6248 send us stuff that we're not interested in. I will uncomment it
6249 when a new version of CVSToys is available in which setFilter()
6250 actually works, and I get a chance to test it better.
6252 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6254 * buildbot/master.py (Dispatcher): use a registration scheme
6255 instead of hardwired service names
6256 (BuildMaster): keep track of the Dispatcher to support
6259 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6260 PBChangeSource class instead of having it be an undocumented
6261 internal feature of the ChangeMaster. Split out the code into a
6263 * buildbot/changes/pb.py (PBChangeSource): same
6264 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6266 * docs/{factories|sources|steps}.xhtml: document some pieces
6268 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6269 using FCMaildirSource
6270 (f23osx): update OS-X builder to use python2.3, since the slave
6271 was updated to Panther (10.3.3)
6273 2004-03-21 Brian Warner <warner@lothar.com>
6275 * buildbot/process/process_twisted.py: factor out doCheckout, change
6276 to use SVN instead of CVS
6278 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6279 an SVN subclass easier
6280 (BasicSVN): subclass which uses Subversion instead of CVS
6282 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6284 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6286 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6288 2004-02-25 Brian Warner <warner@lothar.com>
6290 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6291 is now either a list (which is passed to spawnProcess directly) or
6292 a string (which gets passed to /bin/sh -c). This removes the useSH
6293 flag and the ArgslistCommand class. Also send status header at the
6294 start and end of each command, instead of having the master-side
6296 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6297 -r'. Update to use list-based arguments.
6298 (SVNFetch): use list-based arguments, use ['dir'] argument to
6300 * buildbot/test/test_steps.py (Commands): match changes
6302 * buildbot/process/step.py (InternalShellCommand.words): handle
6304 (SVN): inherit from CVS, cleanup
6306 * buildbot/status/event.py (Logfile.content): render in HTML, with
6307 stderr in red and headers (like the name of the command we're
6308 about to run) in blue. Add link to a second URL (url + "?text=1")
6309 to get just stdout/stderr in text/plain without markup. There is
6310 still a problem with .entries=None causing a crash, it seems to occur
6311 when the logfile is read before it is finished.
6313 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6314 timeout to the keepalives, and use it to explicitly do a
6315 loseConnection instead of waiting for TCP to notice the loss. This
6316 ought to clear up the silent-lossage problem.
6317 (unsafeTracebacks): pass exception tracebacks back to the master,
6318 makes it much easier to debug problems
6320 2004-02-23 Brian Warner <warner@lothar.com>
6322 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6323 the whole command to /bin/sh instead of execve [Johan Dahlin]
6324 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6325 '-r HEAD' [Johan Dahlin]
6326 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6328 * buildbot/changes/changes.py (Change): add links= argument, add
6329 asHTML method [Johan Dahlin]. Modified to make a bit more
6330 XHTMLish. Still not sure how to best use links= .
6332 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6333 Change.asHTML to display the change, not asText
6335 * buildbot/status/html.py (StatusResourceBuilder): web button to
6338 * buildbot/test/test_run.py: test to actually start a buildmaster
6341 * MANIFEST.in: bring back accidentally-dropped test helper files
6343 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6344 that require cvstoys if it is not installed
6346 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6347 values of "bin/trial" [Dave Peticolas]
6348 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6349 tests passed" when we didn't happen to run any tests
6351 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6352 flunkOnFailure [Johan Dahlin]
6354 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6355 multiple instances of the same Step class by suffixing "_2", etc,
6356 to the name until it is unique. This name needs to be unique
6357 because it is used as a key in the dictionary that tracks build
6359 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6362 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6364 2004-01-14 Brian Warner <warner@lothar.com>
6366 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6367 kicked from a channel, log it
6369 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6370 something over whatever IRC channels the buildmaster is currently
6371 connected to. Added to try and track down a problem in which the
6372 master thinks it is still connected but the IRCd doesn't see it. I
6373 used a styles.Versioned this time, so hopefully users won't have
6374 to rebuild their .tap files this time.
6375 * contrib/debug.glade: add a "Poke IRC" button
6376 * contrib/debugclient.py: same
6378 * setup.py: bump to 0.4.2+ while between releases
6380 2004-01-08 Brian Warner <warner@lothar.com>
6382 * setup.py (version): Releasing buildbot-0.4.2
6384 2004-01-08 Brian Warner <warner@lothar.com>
6386 * NEWS: update for 0.4.2 release
6388 * README: document how to run the tests, now that they all pass
6390 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6392 * buildbot/process/step.py (CVS): add a global_options= argument,
6393 which lets you set CVS global options for the command like "-r"
6394 for read-only checkout, or "-R" to avoid writing in the
6396 * buildbot/slavecommand.py (CVSCommand): same
6398 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6399 testing easier (it is turned off when testing, to avoid the
6402 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6403 to make it easier to test: break generateStepID() out to a
6404 separate function, only update statusbag if it exists.
6405 (ShellCommands): create useful text for dict-based commands too.
6407 * test/*, buildbot/test/*: move unit tests under the buildbot/
6409 * setup.py (packages): install buildbot.test too
6411 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6412 * buildbot/test/test_steps.py: fix it, tests pass now
6414 2004-01-06 Brian Warner <warner@lothar.com>
6416 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6417 freshcvs mail uses a slightly different syntax for new
6418 directories. Update parser to handle either.
6419 * test/test_mailparse.py (Test1.testMsg9): test for same
6421 2003-12-21 Brian Warner <warner@lothar.com>
6423 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6424 'warnOnWarnings' so that lintian errors mark the build orange
6426 2003-12-17 Brian Warner <warner@lothar.com>
6428 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6429 messages emitted by Bonsai, contributed by Stephen Davis.
6431 * test/*: moved all tests to use trial instead of unittest. Some
6432 still fail (test_steps, test_slavecommand, and test_process).
6434 * setup.py (version): bump to 0.4.1+ while between releases
6436 2003-12-09 Brian Warner <warner@lothar.com>
6438 * setup.py (version): Releasing buildbot-0.4.1
6440 2003-12-09 Brian Warner <warner@lothar.com>
6442 * NEWS: update for 0.4.1 release
6444 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6445 freebsd builder code a little bit
6447 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6448 don't try to compare attributes of different classes
6449 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6450 (MaildirSource.messageReceived): fix Change delivery
6452 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6453 into the config file's namespace before loading it, like the
6454 documentation claims it does
6455 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6456 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6457 daemon comes back online
6459 2003-12-08 Brian Warner <warner@lothar.com>
6461 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6462 so the example will work with online=0 as well
6464 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6465 fix the __implements__ line
6467 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6468 class a twisted.application.service.Service, use startService to
6471 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6472 directory fd instead of simple open(). I'm sure this used to work,
6473 but the current version of python refuses to open directories with
6476 2003-12-05 Brian Warner <warner@lothar.com>
6478 * setup.py (version): bump to 0.4.0+ while between releases
6480 2003-12-05 Brian Warner <warner@lothar.com>
6482 * setup.py (version): Releasing buildbot-0.4.0
6484 2003-12-05 Brian Warner <warner@lothar.com>
6486 * docs/examples/glib_master.cfg: replace old sample scripts with
6487 new-style config files
6488 * MANIFEST.in: include .cfg files in distribution tarball
6490 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6491 implement a dummy method to avoid the exception that occurs when
6492 freshcvs sends this to us.
6494 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6495 removed the method, as it broke reconnection. Apparently
6496 stopFactory is called each time the connection attempt fails. Must
6498 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6499 attribute before serialization, since without stopFactory the
6500 reconnect timer may still be active and they aren't serializable.
6502 * test/test_mailparse.py (ParseTest): test with 'self' argument
6504 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6505 argument, as these "functions" are invoked like methods from class
6506 attributes and therefore always get an instance as the first
6509 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6510 message: thanks to Stephen Davis for the catch
6512 2003-12-04 Brian Warner <warner@lothar.com>
6514 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6515 twisted's standard ReconnectingClientFactory. Handles both oldcred
6516 and newcred connections. Also has a bug-workaround for
6517 ReconnectingClientFactory serializing its connector when it
6520 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6521 pbutil. Replace makeApp stuff with proper newcred/mktap
6522 makeService(). Don't serialize Ephemerals on shutdown.
6524 * buildbot/changes/changes.py (ChangeMaster): make it a
6525 MultiService and add the sources as children, to get startService
6526 and stopService for free. This also gets rid of the .running flag.
6528 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6529 new pbutil, turn into a TCPClient at the same time (to get
6530 startService for free). Two variants exist: FreshCVSSourceOldcred
6531 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6532 yet, but when it does, we'll be ready).
6533 (FreshCVSSource.notify): handle paths which are empty after the
6534 prefix is stripped. This only happens when the top-level (prefix)
6535 directory is added, at the very beginning of a Repository's life.
6537 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6538 Now the only reconnecting code is in the factory where it belongs.
6539 (Builder.unsubscribe): unregister the disconnect callback when we
6540 delete the builder on command from the master (i.e. when the
6541 buildmaster is reconfigured and that builder goes away). This
6542 fixes a multiple-delete exception when the status client is shut
6544 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6547 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6548 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6550 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6552 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6553 a list of globs (ugh). The testdir will be searched for files
6554 named *.tests and run the tests in the order specified in each of
6555 those files. This allows for "dependancies" between tests to be
6558 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6559 argument to pass to run_maxq.py, instead of a glob.
6561 2003-10-17 Brian Warner <warner@lothar.com>
6563 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6564 files that live in the sandbox
6566 2003-10-15 Brian Warner <warner@lothar.com>
6568 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6569 spelling error in "docs" count-warnings output
6570 (HLint.start): stupid thinko meant .xhtml files were ignored
6572 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6573 tests now that cReactor is banished to the sandbox
6575 2003-10-10 Brian Warner <warner@lothar.com>
6577 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6578 scheme: now .xhtml are sources and .html are generated
6580 2003-10-08 Brian Warner <warner@lothar.com>
6582 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6583 we were ignoring the 'randomly' parameter.
6585 2003-10-01 Brian Warner <warner@lothar.com>
6587 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6588 posix, to kill sub-children of aborted slavecommands.
6590 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6591 Clean up initialization: lastBuildStatus remains None until the
6592 first build has been completed.
6594 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6595 None as a lastBuildStatus
6596 * buildbot/clients/gtkPanes.py: same
6598 * buildbot/status/client.py (StatusClientService): keep
6599 BuilderStatus objects in self.statusbags . These objects now live
6600 here in the StatusClientService and are referenced by the Builder
6601 object, rather than the other way around.
6602 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6603 * buildbot/process/base.py (Builder): same
6604 * test/test_config.py (ConfigTest.testBuilders): same
6606 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6607 an existing builder, leave the statusbag alone. This will preserve the
6610 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6611 hook. This will probably go away in favor of a class in upcoming
6614 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6615 serviceName from newcred FreshCVSNotifiee setup
6617 2003-09-29 Brian Warner <warner@lothar.com>
6619 * buildbot/process/process_twisted.py: switch to new reactor
6621 * docs/examples/twisted_master.cfg: same
6623 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6625 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6626 botmaster reference instead of the oldapp service lookup
6628 * buildbot/master.py (BuildMaster.__init__): give the
6629 StatusClientService a reference to the botmaster to make it easier to
6632 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6634 * buildbot/status/html.py (Box.td): escape hreffy things so you
6635 can have spaces in things like builder names
6636 (StatusResourceBuilder.body)
6637 (WaterfallStatusResource.body)
6638 (WaterfallStatusResource.body0): same
6640 2003-09-25 Brian Warner <warner@lothar.com>
6642 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6643 rearrange the builder list when adding or removing builders: keep
6644 them in the order the user requested.
6645 * test/test_config.py (ConfigTest.testBuilders): verify it
6647 * contrib/debug.glade: give the debug window a name
6649 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6650 now wait on multiple interlocks. Fix code relating to that.
6651 (Builder.checkInterlocks): same
6652 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6654 * buildbot/master.py (BuildMaster.loadConfig): move from
6655 deprecated pb.BrokerFactory to new pb.PBServerFactory
6656 * test/test_config.py (ConfigTest.testWebPathname): same
6658 * docs/examples/twisted_master.cfg: fix interlock declaration
6660 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6661 Interlocks to their Builders into interlock.py .
6662 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6664 * test/test_config.py (ConfigTest.testInterlocks): validate
6667 * buildbot/process/base.py (Builder.__init__): better comments
6668 * buildbot/process/interlock.py (Interlock.__repr__): same
6669 (Interlock.deactivate): add .active flag, move the code that
6670 attaches/detaches builders into the Interlock
6672 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6674 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6675 tests using the new run_maxq.py script, and reporting failures by
6678 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6679 tests, reporting their success or failure in a buildbot-friendly
6682 2003-09-24 Brian Warner <warner@lothar.com>
6684 * docs/examples/twisted_master.cfg: example of a new-style config
6685 file. This lives in the buildmaster base directory as
6688 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6689 button to make the master re-read its config file
6691 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6692 buildmaster configuration from a file. This file can be re-read
6693 later, and the buildmaster will update itself to match the new
6694 desired configuration. Also use new Twisted Application class.
6695 * test/Makefile, test/test_config.py: unit tests for same
6697 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6698 FreshCVSSources comparable, to support reload.
6699 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6701 * buildbot/process/base.py (Builder): make them comparable, make
6702 Interlocks easier to attach, to support reload. Handle
6703 re-attachment of remote slaves.
6704 * buildbot/process/interlock.py (Interlock): same
6706 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6707 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6708 buildmaster taps are now constructed with mktap.
6709 * buildbot/status/client.py (StatusClientService): same
6711 * buildbot/status/words.py: move to new Services, add support to
6712 connect to multiple networks, add reload support, allow nickname
6713 to be configured on a per-network basis
6715 2003-09-20 Brian Warner <warner@lothar.com>
6717 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6718 the freebsd builder, now that the machine has been upgraded and no
6719 longer has python2.2
6721 * setup.py (version): bump to 0.3.5+ while between releases
6723 2003-09-19 Brian Warner <warner@lothar.com>
6725 * setup.py (version): Releasing buildbot-0.3.5
6727 2003-09-19 Brian Warner <warner@lothar.com>
6729 * NEWS: add post-0.3.4 notes
6731 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6733 * MANIFEST.in: add contrib/*
6735 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6736 use a remote root now: cvs.twistedmatrix.com
6738 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6740 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6741 compatibility with old servers
6742 (FreshCVSSource.start): and provide a way to use it
6743 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6745 * docs/examples/twisted_master.py (twisted_app): update to new
6747 (twisted_app): listen on new ~buildbot socket
6748 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6750 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6751 to reduce cvs bandwidth (update instead of full checkout)
6753 2003-09-11 Brian Warner <warner@lothar.com>
6755 * contrib/fakechange.py: demo how to connect to the changemaster
6756 port. You can use this technique to submit changes to the
6757 buildmaster from source control systems that offer a hook to run a
6758 script when changes are committed.
6760 * contrib/debugclient.py: tool to connect to the debug port. You
6761 can use it to force builds, submit fake changes, and wiggle the
6764 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6765 'Dispatcher' realm to handle all the different kinds of
6766 connections and Perspectives: buildslaves, the changemaster port,
6767 the debug port, and the status client port. NewCredPerspectives
6768 now have .attached/.detached methods called with the remote 'mind'
6769 reference, much like old perspectives did. All the pb.Services
6770 turned into ordinary app.ApplicationServices .
6771 (DebugService): went away, DebugPerspectives are now created
6772 directly by the Dispatcher.
6773 (makeApp): changed interface a little bit
6775 * buildbot/changes/changes.py: newcred
6776 * buildbot/status/client.py: newcred
6778 * buildbot/clients/base.py: newcred client side changes
6779 * buildbot/bot.py: ditto
6781 * docs/examples/glib_master.py: handle new makeApp() interface
6782 * docs/examples/twisted_master.py: ditto
6784 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6785 base newcred Perspectives on. This should go away once Twisted
6786 itself provides something sensible.
6789 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6791 * contrib/svn_buildbot.py: A program that you can call from your
6792 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6793 when a change in an SVN repository has happened. See the top of
6794 the file for some minimal usage info.
6796 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6798 * buildbot/slavecommand.py (ArglistCommand): Add new
6799 ArglistCommand that takes an argument list rather than a string as
6800 a parameter. Using a st.split() for argv is very bad.
6802 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6803 update to a particular revision rather than always checking out
6804 (still not very smart about it, there may be cases where the
6805 checkout becomes inconsistent).
6807 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6809 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6810 SVN fetch support. It can checkout (not update!) a specified
6811 revision from a specified repository to a specified directory.
6813 * buildbot/status/progress.py (Expectations.update): Fix an
6814 obvious bug (apparently created by the change described in the
6815 previous ChangeLog message) by moving a check to *after* the
6816 variable it checks is defined.
6819 2003-09-08 Brian Warner <warner@lothar.com>
6821 * buildbot/status/progress.py (Expectations.update): hack to catch
6822 an exception TTimo sees: sometimes the update() method seems to
6823 get called before the step has actually finished, so the .stopTime
6824 is not set, so no totalTime() is available and we average None
6825 with the previous value. Catch this and just don't update the
6826 metrics, and emit a log message.
6828 2003-08-24 Brian Warner <warner@lothar.com>
6830 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6831 parameter to set copydir='original' in CVS commands.
6833 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6835 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6836 which tells the command to maintain a separate original-source CVS
6837 workspace. For each build, this workspace will be updated, then
6838 the tree copied into a new workdir. This reduces CVS bandwidth
6839 (from a full checkout to a mere update) while doubling the local
6840 disk usage (to keep two copies of the tree).
6842 2003-08-21 Brian Warner <warner@lothar.com>
6844 * buildbot/status/event.py (Logfile.addEntry): if the master web
6845 server dies while we're serving a page, request.write raises
6846 pb.DeadReferenceError . Catch this and treat it like a
6847 notifyFinish event by dropping the request.
6849 2003-08-18 Brian Warner <warner@lothar.com>
6851 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6852 (instead of blowing up) if a force-build command is given without
6855 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6856 don't blow up if there aren't yet any Changes in the list
6858 2003-08-02 Brian Warner <warner@lothar.com>
6860 * buildbot/bot.py (updateApplication): don't set the .tap name,
6861 since we shouldn't assume we own the whole .tap file
6863 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6864 'mktap buildbot' (without a subcommand) better
6866 2003-07-29 Brian Warner <warner@lothar.com>
6868 * buildbot/status/words.py
6869 (IrcStatusFactory.clientConnectionLost): when we lose the
6870 connection to the IRC server, schedule a reconnection attempt.
6872 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6873 use shutil.rmtree instead of forking off an "rm -rf" command.
6874 rmtree may take a while and will block until it finishes, so we
6875 use "rm -rf" if available.
6877 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6878 freebsd buildslave badly
6880 * setup.py (version): bump to 0.3.4+ while between releases
6882 2003-07-28 Brian Warner <warner@lothar.com>
6884 * setup.py (version): Releasing buildbot-0.3.4
6886 2003-07-28 Brian Warner <warner@lothar.com>
6888 * NEWS: update in preparation for release
6890 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6891 process.signalProcess instead of os.kill, to improve w32
6894 * docs/examples/twisted_master.py (twisted_app): turn off
6895 win32eventreactor: the tests hang the buildslave badly
6897 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6898 failed builds, since usually the failures are consistent
6900 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6901 add compileOpts/compileOpts2 to reactors build
6903 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6904 (twisted_app): use both default and win32eventreactor on w32 build.
6905 Use both default and kqreactor on freebsd build.
6907 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6908 add compileOpts2, which is put after the build_ext argument. w32
6909 needs "-c mingw32" here.
6911 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6912 touch .acqpath, it goes away in recent Twisted releases
6914 * docs/examples/twisted_master.py (twisted_app): use "python" for
6915 the w32 buildslave, not "python2.2"
6917 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6918 the directory exists.. should hush an exception under w32
6920 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6921 ProcessTerminated -provided values for signal and exitCode rather
6922 than parsing the unix status code directly. This should remove one
6923 more roadblock for a w32-hosted buildslave.
6925 * test/test_mailparse.py: add test cases for Syncmail parser
6927 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6928 temporary compatibility import. Note! Start importing
6929 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6931 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6933 2003-07-27 Brian Warner <warner@lothar.com>
6935 * NEWS: started adding new features
6937 * buildbot/changes/mail.py: start work on Syncmail parser, move
6938 mail sources into their own file
6940 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6941 as implementing IChangeSource
6942 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6944 * buildbot/interfaces.py: define the IChangeSource interface
6946 2003-07-26 Brian Warner <warner@lothar.com>
6948 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6950 2003-06-25 Brian Warner <warner@lothar.com>
6952 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6955 2003-06-17 Brian Warner <warner@lothar.com>
6957 * buildbot/status/words.py: clean up method usage to avoid error
6958 in silly IRC command
6959 (IrcStatusBot.emit_status): round off seconds display
6961 * buildbot/process/base.py (Build): delete the timer when saving
6962 to the .tap file, and restore it (if it should still be running)
6963 upon restore. This should fix the "next build in -34 seconds"
6964 messages that result when the master is restarted while builds are
6965 sitting in the .waiting slot. If the time for the build has
6966 already passed, start it very soon (in 1 second).
6968 * buildbot/status/words.py: more silly commands
6970 * README (REQUIREMENTS): add URLs to all required software
6972 * buildbot/status/words.py ('last'): mention results of, and time
6975 2003-05-28 Brian Warner <warner@lothar.com>
6977 * buildbot/status/words.py: add 'last' command
6978 (IrcStatusBot.emit_status): add current-small text to 'status' output
6980 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6981 (twisted_app): remove spaces from OS-X builder name
6983 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6984 * buildbot/status/words.py: IRC bot should actually be useful now
6986 2003-05-23 Brian Warner <warner@lothar.com>
6988 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6989 "slave information" from $(slavedir)/info/* . These files are
6990 maintained by the slave administrator, and describe the
6991 machine/environment that is hosting the slave. Information from
6992 them is put into the "Builder" HTML page. Still need to establish
6993 a set of well-known filenames and meanings for this data: at the
6994 moment, *all* info/* files are sent to the master, but only
6995 'admin' and 'host' are used on that end.
6996 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6997 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6998 * buildbot/master.py (BotPerspective.got_info): ditto
7000 2003-05-22 Brian Warner <warner@lothar.com>
7002 * setup.py (version): bump version to 0.3.3+ while between releases
7004 2003-05-21 Brian Warner <warner@lothar.com>
7006 * setup.py: Releasing buildbot-0.3.3
7008 2003-05-21 Brian Warner <warner@lothar.com>
7010 * NEWS: 0.3.3 news items
7012 * README: describe --keepalive and life behind a NAT box
7014 * buildbot/bot.py (Bot.connected): implement application-level
7015 keepalives to deal with NAT timeouts, turn them on with
7016 --keepalive option or when SO_KEEPALIVE doesn't work.
7018 * buildbot/master.py (BotPerspective): accept keepalives silently
7020 * buildbot/process/base.py (Build.buildException): CopiedFailures
7021 don't carry as much information as local ones, so don't try to
7022 create a big HTMLized version of them.
7024 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7025 log file when step fails due to an exception, such as when the slave
7028 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7029 --testmodule argument instead of grepping for test-case-name tags
7030 ourselves. Remove FindUnitTests code.
7031 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7033 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7035 2003-05-16 Brian Warner <warner@lothar.com>
7037 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7038 argument to allow things like CFLAGS=-O0 to be passed without relying
7039 upon /bin/sh processing on the slave.
7041 * buildbot/process/step.py (InternalShellCommand.start): send
7043 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7044 'split' instead of letting /bin/sh do it. This should also remove
7045 the need for /bin/sh on the buildslave, making it more likely to
7048 * buildbot/status/html.py: html-escape text in blamelist.
7049 Add "force build" button to the Builder page.
7051 * buildbot/process/step_twisted.py (countFailedTests): look at
7052 last 1000 characters for status line, as import errors can put it
7053 before the -200 point.
7055 2003-05-15 Brian Warner <warner@lothar.com>
7057 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7059 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7060 make 'clobber' a parameter, so it is possible to have builds which
7061 do full tests but do a cvs update instead of hammering the CVS
7062 server with a full checkout each build
7064 * buildbot/process/step.py (InternalShellCommand): bump default
7065 timeout to 20 minutes
7067 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7068 the master to trigger a build. Run it via manhole.
7070 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7071 allow slaves to trigger any build that they host, to make life
7072 easier for slave admins who are testing out new build processes
7074 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7075 don't flunk cReactor or qtreactor on failure, since they fail alot
7076 these days. Do warnOnFailure instead.
7078 * buildbot/process/base.py: change Builder.buildable from a list
7079 into a single slot. When we don't have a slave, new builds (once
7080 they make it past the timeout) are now merged into an existing
7081 buildable one instead of being queued. With this change, a slave
7082 which has been away for a while doesn't get pounded with all the
7083 builds it missed, but instead just does a single build.
7085 2003-05-07 Brian Warner <warner@lothar.com>
7087 * setup.py (version): bump version to 0.3.2+ while between releases
7089 2003-05-07 Brian Warner <warner@lothar.com>
7091 * setup.py: Releasing buildbot-0.3.2
7093 2003-05-07 Brian Warner <warner@lothar.com>
7095 * setup.py: fix major packaging error: include subdirectories!
7097 * NEWS: add changes since last release
7099 * README (REQUIREMENTS): update twisted/python dependencies
7101 * buildbot/status/builder.py (Builder.startBuild): change
7102 BuildProcess API: now they should call startBuild/finishBuild
7103 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7104 keeping a list of builds in the statusbag, to support other kinds of
7106 (Builder.addClient): send current-activity-small to new clients
7107 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7110 * buildbot/status/client.py: drop RemoteReferences at shutdown
7112 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7114 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7115 more debug messages for remote status client
7117 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7118 (.stepFailed): only fire the Deferred once, even if both
7119 stepComplete and stepFailed are called. I think this can happen if
7120 an exception occurs at a weird time.
7122 * buildbot/status/words.py: work-in-progress: IRC status delivery
7124 2003-05-05 Brian Warner <warner@lothar.com>
7126 * docs/examples/twisted_master.py (twisted_app): hush internal
7127 python2.3 distutils deprecation warnings
7128 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7129 add compileOpts= argument which inserts extra args before the
7130 "setup.py build_ext" command. This can be used to give -Wignore
7131 warnings, to hush some internal python-2.3 deprecation messages.
7133 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7134 the ['twisted.test'] default test case to make it easier to change
7137 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7138 * buildbot/clients/gtkPanes.py: ditto
7140 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7141 arg to collapse RunUnitTestsRandomly into RunUnitTests
7142 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7143 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7145 * buildbot/status/html.py (StatusResource): shuffle Resources
7146 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7147 would serve the waterfall display, but the internal links were
7148 only valid on the trailing-slash version. The correct behavior is
7149 for the non-slashed one to serve a Redirect to the slashed one.
7150 This only shows up when the buildbot page is hanging off another
7151 server, like a Twisted-Web distributed server.
7153 * buildbot/status/event.py (Event, RemoteEvent): make Events
7154 pb.Cacheable, with RemoteEvent as the cached version. This removes
7155 a lot of explicit send-an-update code.
7156 * buildbot/status/builder.py (Builder): remove send-update code
7157 * buildbot/status/client.py (ClientBuilder): remove send-update
7158 code, and log errors that occur during callRemote (mostly to catch
7159 InsecureJelly exceptions)
7161 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7162 run Lore with the same python used in the rest of the build
7164 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7166 * buildbot/process/step_twisted.py (HLint): accept 'python'
7167 argument. Catch rc!=0 and mark the step as failed. This marks the
7168 build orange ("has warnings").
7169 (RunUnitTestsJelly): move out to step_twisted2.py
7171 * buildbot/util.py (ignoreStaleRefs): add utility function
7173 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7174 don't fake ETA object, it's too hard to get right
7176 2003-05-02 Brian Warner <warner@lothar.com>
7178 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7180 2003-05-01 Brian Warner <warner@lothar.com>
7182 * buildbot/status/html.py (StatusResource.body): oops, I was
7183 missing a <tr>, causing the waterfall page to be misrendered in
7184 everything except Galeon.
7186 2003-04-29 Brian Warner <warner@lothar.com>
7188 * docs/examples/twisted_master.py: make debuild use python-2.2
7189 explicitly, now that Twisted stopped supporting 2.1
7191 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7192 handle tuple results too. I keep forgetting this, which suggests
7193 it needs to be rethought.
7195 * setup.py (setup): bump version to 0.3.1+ while between releases
7197 2003-04-29 Brian Warner <warner@lothar.com>
7199 * setup.py: Releasing buildbot-0.3.1
7201 2003-04-29 Brian Warner <warner@lothar.com>
7203 * README (SUPPORT): add plea to send questions to the mailing list
7205 * NEWS, MANIFEST.in: add description of recent changes
7207 * docs/examples/twisted_master.py: add the code used to create the
7208 Twisted buildmaster, with passwords and such removed out to a
7211 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7212 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7213 buildmasters to not require CVSToys be installed.
7214 * README, docs/examples/glib_master: update to match the change
7216 * buildbot/clients/base.py, buildbot/bot.py,
7217 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7218 ReconnectingPB from CVSToys distribution to remove CVSToys
7219 dependency for build slaves and status clients. Buildmasters which
7220 use FreshCVSSources still require cvstoys be installed, of course.
7222 2003-04-25 Brian Warner <warner@lothar.com>
7224 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7225 runTestsRandomly arg to turn on trial -z
7227 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7228 experimental code to use trial's machine-parseable output to get
7229 more detailed test results. Still has some major issues.
7230 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7233 * buildbot/status/builder.py (Builder.setCurrentBuild):
7234 anticipating moving build history into statusbag, not used yet
7236 * buildbot/status/tests.py: code to centralize test results,
7237 doesn't work quite yet
7239 * buildbot/status/event.py (Event): use hasattr("setName") instead
7240 of isinstance for now.. need better long-term solution
7242 * buildbot/status/html.py: Remove old imports
7244 2003-04-24 Brian Warner <warner@lothar.com>
7246 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7247 ignore changes under doc/fun/ and sandbox/
7249 * buildbot/process/step_twisted.py: update pushEvent and friends.
7251 * buildbot/status/html.py (Box.td): replace event.buildername with
7252 event.parent.getSwappableName(). Needs more thought.
7254 * buildbot/status/builder.py (Builder): Replace pushEvent and
7255 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7256 Tell events they are being pruned with event.delete().
7258 * buildbot/process/base.py (Build): Remove Builder status-handling
7259 methods. s/pushEvent/setCurrentActivity/.
7261 * buildbot/process/step.py (BuildStep): clean up status delivery.
7262 Gouse builder.statusbag methods instead of intermediate builder
7263 methods. s/updateLastEvent/updateCurrentActivity/.
7264 s/finalizeLastEvent/finishCurrentActivity/. Use
7265 addFileToCurrentActivity for summaryFunction.
7267 * buildbot/status/event.py (Logfile): put data in a Swappable when
7269 (Event): add more setter methods. Remove .buildername, use .parent
7270 and getSwappableName instead (needs more thought).
7272 * buildbot/util.py (Swappable):
7273 * test/test_swap.py: don't bother setting filename at __init__
7274 time, do it later. Change setFilename args to take parent first,
7275 since it provides the most significant part of the filename.
7277 2003-04-23 Brian Warner <warner@lothar.com>
7279 * buildbot/status/event.py (Logfile.addEntry): append to previous
7282 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7283 anticipating Swappable
7284 (InternalShellCommand.remoteUpdate): split out various log-adding
7285 methods so subclasses can snarf stdout separately
7287 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7288 in anticipation of Swappable build logs
7289 (Builder.testsFinished): anticipating TestResults, still disabled
7291 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7294 * buildbot/status/event.py (Logfile): add (disabled) support for
7295 Swappable, not ready for use yet
7297 * buildbot/util.py (Swappable): object which is swapped out to
7298 disk after some period of no use.
7299 * test/test_swap.py: test buildbot.utils.Swappable
7301 2003-04-14 Brian Warner <warner@lothar.com>
7303 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7304 periodic-build timer. Set the .periodicBuildTime on a builder
7305 instance to some number of seconds to activate it.
7307 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7309 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7310 a way that survives result tuples
7312 2003-04-12 Brian Warner <warner@lothar.com>
7314 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7315 return a dict instead of a tuple: allow summarizers to provide
7316 multiple summaries if they want
7317 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7318 (debuildSummarizer): summarize lintian warnings/errors
7320 2003-04-10 Brian Warner <warner@lothar.com>
7322 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7324 2003-04-09 Brian Warner <warner@lothar.com>
7326 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7327 empty summaries: happens when the tests fail so hard they don't emit
7328 a parseable summary line.
7330 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7331 Allow summaryFunction to return None to indicate no summary should
7334 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7335 writing to stale HTTP requests: notice when they disconnect and
7336 remove the request from the list. Also add CacheToFile from
7337 moshez, will be used later.
7339 2003-04-08 Brian Warner <warner@lothar.com>
7341 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7342 should be an int, not a list of strings
7344 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7345 if we weren't actually connected
7347 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7348 to show the tail end of the trial text output
7350 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7351 hook to summarize the results of a ShellCommand
7353 2003-04-07 Brian Warner <warner@lothar.com>
7355 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7356 twisted test suite code into a single class.
7357 * buildbot/process/process_twisted.py: same
7359 2003-04-04 Brian Warner <warner@lothar.com>
7361 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7363 * README (SLAVE): document use of mktap to create slave .tap file
7364 (REQUIREMENTS): describe dependencies
7366 * buildbot/bb_tap.py, buildbot/plugins.tml:
7367 * buildbot/bot.py (updateApplication): Add mktap support for creating
7368 buildslave .tap files
7370 2003-03-28 Brian Warner <warner@lothar.com>
7372 * buildbot/process/step.py (InternalShellCommand.finished): handle
7373 new tuple result values (fix embarrasing bug that appeared during
7376 2003-03-27 Brian Warner <warner@lothar.com>
7378 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7381 2003-03-25 Brian Warner <warner@lothar.com>
7383 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7384 to overall build status
7385 * buildbot/clients/base.py (Builder): improve event printing
7386 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7387 instead of generic ShellCommand
7388 (Build): Add .stopBuild, use it when slave is detached
7390 * buildbot/process/step.py (Configure,Test): give the steps their
7391 own names and status strings
7393 * buildbot/status/html.py (StatusResource): add "show" argument,
7394 lets you limit the set of Builders being displayed.
7396 2003-03-20 Brian Warner <warner@lothar.com>
7398 * buildbot/process/basic.py: removed
7400 2003-03-19 Brian Warner <warner@lothar.com>
7402 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7403 turn off process-docs by default
7405 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7406 when displaying build information without anything in allBuilds[]
7408 * buildbot/bot.py (makeApp): really take password from sys.argv
7410 2003-03-18 Brian Warner <warner@lothar.com>
7412 * buildbot/bot.py (buildApp): take password from sys.argv
7414 * README: replace with more useful text
7416 * setup.py: add a real one
7417 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7419 * docs/PyCon-2003/: added sources for PyCon paper.
7421 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7422 now Build objects control the process and Builder only handles
7423 slave stuff and distribution of changes/status. A new BuildFactory
7424 class creates Build objects on demand.
7426 Created ConfigurableBuild which takes a list of steps to run. This
7427 makes it a lot easier to set up a new kind of build and moves us
7428 closer to being able to configure a build from a web page.
7430 * buildbot/process/step_twisted.py, process_twisted.py: move to
7431 new model. A lot of code went away.
7433 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7434 send lots of empty progress messages to the client.
7436 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7438 2003-02-20 Brian Warner <warner@lothar.com>
7440 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7442 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7443 Twisted bug that prevented non-pty processes from working just got
7444 fixed, and the bug that leaks ptys is still being investigated.
7446 * buildbot/process/step.py (CVS): send timeout arg to slave
7448 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7449 builders coming and going
7450 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7451 from CVSToys, handle lost-buildmaster
7453 * buildbot/status/client.py (StatusClientService.removeBuilder):
7454 Clean up status client protocol: send builders (with references)
7455 as they are created, rather than sending a list and requiring the
7456 client to figure out which ones are new.
7457 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7458 attempts to force a build on an unknown builder
7460 2003-02-19 Brian Warner <warner@lothar.com>
7462 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7463 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7464 Twisted stops leaking them.
7465 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7466 builder goes to an idle state.
7468 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7469 I figure out why CVS commands hang without them, and/or I fix the
7470 hung-command timeout
7472 2003-02-16 Brian Warner <warner@lothar.com>
7474 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7475 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7476 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7477 GenerateDocs now that they are prefixed with WARNING:.
7479 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7480 use manual href target instead of request.childLink
7482 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7483 display every second, but update the ETA every 5 seconds (or
7484 whenever) as remote_progress messages arrive.
7487 2003-02-12 Brian Warner <warner@lothar.com>
7489 * *: import current sources from home CVS repository
7493 # add-log-time-format: add-log-iso8601-time-string