1 2006-12-10 Brian Warner <warner@lothar.com>
3 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
4 than the old/deprecated gtk.mainquit()
6 2006-12-09 Brian Warner <warner@lothar.com>
8 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
9 better when we can't open the masterdst file
11 * buildbot/scripts/startup.py (Follower._failure): add missing
12 import statement for BuildSlaveDetectedError
14 * buildbot/steps/transfer.py (FileUpload): cleanup
15 (FileDownload): same. Add tests for slave version, add mode=.
16 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
17 (SlaveFileDownloadCommand): same
18 * buildbot/test/test_transfer.py: enhance tests
19 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
22 2006-12-08 Brian Warner <warner@lothar.com>
24 * buildbot/scripts/runner.py (sendchange): halt the reactor on
25 both success *and* failure. Without this, the 'buildbot
26 sendchange' command would hang if it could not contact the
27 buildmaster or deliver the Change, which would generally cause the
28 user's commit/record/checkin command to hang too. Thanks to
29 Christian Unger for the catch.
31 2006-12-06 Brian Warner <warner@lothar.com>
33 * NEWS: update with items for the next release
35 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
36 whimsical example pulled from a punch-drunk email I sent out late
38 (Transferring Files): document some of the other parameters
39 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
40 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
41 * buildbot/test/test_svnpoller.py: same
42 * buildbot/changes/svnpoller.py (SVNPoller): same
44 2006-11-26 Brian Warner <warner@lothar.com>
46 * docs/buildbot.texinfo (Build Properties): remind users that
47 WithProperties must appear in a command= list, not as a top-level
49 * buildbot/steps/shell.py (ShellCommand.start): and assert that
50 we're sending a list or a single string to the RemoteShellCommand
52 * buildbot/scheduler.py (Nightly): Improve docs slightly.
54 * buildbot/scripts/startup.py (start): skip the whole
55 watch-the-logfile thing under windows, since it needs os.fork()
57 * buildbot/scripts/runner.py (restart): remove the old message
58 that got printed after the buildbot was restarted.. it most cases
59 it didn't get printed at the right time anyways
61 2006-11-25 Brian Warner <warner@lothar.com>
63 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
64 follow twistd.log and print lines until the process has started
65 started properly. For the buildmaster, this means until the config
66 file has been parsed and accepted. For the buildslave, this means
67 until we've connected to the master. We give up after 5 seconds in
68 any case. Helpful error messages and troubleshooting suggestions
69 are printed when we don't see a successful startup. This closes the
70 remainder of SF#1517975.
71 * buildbot/scripts/startup.py: moved app startup code to here
72 * buildbot/scripts/logwatcher.py: utility class to follow log
73 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
74 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
75 so the LogWatcher can tell the difference between a buildmaster
78 2006-11-24 Brian Warner <warner@lothar.com>
80 * docs/examples/twisted_master.cfg: update to match the version
81 in use on twistedmatrix.com
82 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
83 was using before stopped working, but 'irc.freenode.net' works
86 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
89 * buildbot/clients/base.py (TextClient.not_connected): upon
90 UnauthorizedLogin failures, remind the user to connect to the
91 PBListener port instead of the slaveport.
92 (TextClient.disconnected): shut down more quietly
93 * docs/buildbot.texinfo (statuslog): add another reminder
95 * buildbot/scripts/runner.py (Options.subCommands): rename
96 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
98 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
99 reconfig command to follow twistd.log and print all of the lines
100 from the start of the config-file reload to its completion. This
101 should make it a lot easier to discover bugs in the config file.
102 Use --quiet to disable this behavior. This addresses half of
103 SF#1517975, the other half will be to add this same utility to
104 'buildbot start' and 'buildbot restart'.
105 * docs/buildbot.texinfo (Loading the Config File): same
108 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
109 method, it has been deprecated for a long time. Use
110 IBuilderControl.requestBuild instead.
111 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
112 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
113 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
114 * buildbot/test/test_control.py (Force.testForce): same
115 * buildbot/test/test_run.py: use requestBuild instead
117 * buildbot/clients/debug.py: replace 'Force Build' button with
118 'Request Build' (which just adds one to the queue), add Ping
119 Builder, add branch/revision fields to Request Build.
120 * buildbot/clients/debug.glade: same
121 * buildbot/master.py: update interface to match. This creates an
122 incompatibility between new debugclients and old buildmasters.
124 * buildbot/process/builder.py (Builder._attached): delay the call
125 to maybeStartBuild for a reactor turn, to avoid starting a build
126 in the middle of a reconfig (say, if the new Builder uses a new
127 slave which is already connected).
129 2006-11-23 Brian Warner <warner@lothar.com>
131 * buildbot/test/test_transfer.py: appease pyflakes
132 * buildbot/test/test_steps.py: same
134 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
135 keeps pyflakes from finding undefined names
137 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
138 Builder no longer induces a disconnect/reconnect cycle. This means
139 that any builds currently in progress will not be interrupted, and
140 any builds which are queued in the Builder will not be lost. This
141 is implemented by having the new Builder extract the state (i.e.
142 all pending Builds and any desired SlaveBuilders) from the old
144 (BotPerspective): refactor. The BotPerspective no longer keeps
145 track of all the Builders that want to use this slave; instead, it
146 asks the BotMaster each time it needs this list. This removes
147 addBuilder and removeBuilder. Clean up attached() to acquire all
148 the slave's information in a more atomic fashion. updateSlave() is
149 now the way to make sure the slave is using the right set of
150 Builders: just call it after everything else has been
152 (BotMaster): refactor, removing addBuilder/removeBuilder and
153 replacing them with an all-at-once setBuilders() call.
155 * buildbot/test/test_slaves.py (Reconfig): new test case to
156 exercise this functionality
157 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
158 * buildbot/slave/commands.py (WaitCommand): same
160 * docs/buildbot.texinfo (Loading the Config File): document the
163 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
164 SlaveBuilder to have its parent Builder changed.
165 (SlaveBuilder.isAvailable): new method to give access to state,
166 which is now a private attribute
167 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
168 the SlaveBuilder about how it is being used. These methods update
169 its internal state. buildFinished() is now the place that invokes
170 maybeStartBuild() on its parent Builder.
171 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
172 new Builder to take over for an old one, transferring state from
174 (Buider): refactor the way that SlaveBuilders are used to match,
175 giving them a bit more autonomy.
176 (Builder.buildFinished): this no longer calls maybeStartBuild():
177 instead the SlaveBuilder calls it on whoever its parent Builder is
178 at the time. This way, when an old Builder is replaced by a new
179 one, and there was a build in progress during the transition, when
180 that build finishes, it will be the new Builder that is told about
181 the newly available slave so it can start a new build.
183 * buildbot/process/base.py (Build.startBuild._release_slave): when
184 the Build finishes, tell the SlaveBuilder that they've been
187 * buildbot/status/builder.py (SlaveStatus): add some new setter
188 methods for use by BotPerspective, to keep some attributes more
191 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
192 called by the buildmaster.
193 (Bot.setBuilderList): instead, we locally announce any leftover
194 directories based upon which Builders we were told about. The
195 master doesn't really care; it's the local admin who may or may not
199 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
200 to allow use of python2.4 or whatever. This tool still requires
203 2006-11-19 Brian Warner <warner@lothar.com>
205 * NEWS (IStatusLog.readlines): more news items
207 2006-11-18 Brian Warner <warner@lothar.com>
209 * NEWS: start collecting items for the next release.
211 2006-11-04 Brian Warner <warner@lothar.com>
213 * buildbot/changes/bonsaipoller.py: apply updates from Ben
214 Hearsum. Closes SF#1590310.
215 * buildbot/test/test_bonsaipoller.py: and tests
217 * buildbot/status/tinderbox.py
218 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
219 status when the build results in WARNINGS. Patch from Dave
220 Liebreich. Closes SF#1587352.
222 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
223 linux-vs-osx behavior difference w.r.t. reading from files that
224 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
225 to Mark Rowe for the patch.
227 2006-10-15 Brian Warner <warner@lothar.com>
229 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
230 method name was misspelled in the interface definition. Thanks to
231 Roy Rapoport for the catch.
233 2006-10-13 Brian Warner <warner@lothar.com>
235 * docs/buildbot.texinfo (Adding LogObservers): update sample code
236 to match the great Steps renaming
238 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
239 Maybe I should run my own unit tests before recording a big
240 change. Good thing I've got a buildbot to remind me.
242 2006-10-12 Brian Warner <warner@lothar.com>
244 * buildbot/steps/transfer.py: rework __init__ and args setup
245 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
247 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
248 when opening the target file, only catch IOError (to report via
249 stderr/rc!=0), let the others be reported as normal exceptions
251 2006-10-08 Brian Warner <warner@lothar.com>
253 * contrib/svn_watcher.py: fix security holes by using proper argv
254 arrays and subprocess.Popen() rather than commands.getoutput().
255 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
256 is deprecated in favor of buildbot/changes/svnpoller.py, and will
257 probably be removed by the next release.
260 2006-10-04 Brian Warner <warner@lothar.com>
262 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
263 initial lines that weren't emitted by pyflakes. When the pyflakes
264 command is run under a Makefile, 'make' will echo the command it
265 runs to stdio, and that was getting logged as a "misc" warning.
266 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
267 * buildbot/test/test_steps.py (testPyFlakes3): another test
269 2006-10-01 Brian Warner <warner@lothar.com>
271 * buildbot/status/html.py (HtmlResource.render): if we get a
272 unicode object from our content() method, encode it into utf-8
273 like we've been claiming to all along. This allows the comments
274 and author names from svnpoller.py to be delivered properly.
276 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
277 de-unicodify filenames before creating the Change, because the
278 rest of buildbot is unlikely to handle them well. Leave the 'who'
279 field as a unicode object.. I don't think there's anything that
280 will break very soon, and it will probably nudge us towards
281 accepting unicode everywhere sooner or later. Stop using the
282 "date" field that comes out of SVN, since it is using the
283 repository's clock (and timezone) and what we care about is the
284 buildmaster's (otherwise Changes from the future show up later
285 than the builds they triggered).
286 * buildbot/test/test_svnpoller.py (Everything.test1): match the
289 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
290 Suvbersion repository polling ChangeSource. I've hacked it up
291 considerably: any bugs are entirely my own fault. Thank you
293 * buildbot/test/test_svnpoller.py: tests for it
294 * docs/buildbot.texinfo (SvnSource): document it
296 2006-09-30 Brian Warner <warner@lothar.com>
298 * buildbot/scheduler.py (Periodic): submit a reason= to the
299 BuildSet to indicate which Scheduler triggered the build. Thanks
300 to Mateusz Loskot for the suggestion.
302 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
304 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
305 changes: set self.loop in __init__, remove unused volatile=
307 * docs/buildbot.texinfo (.buildbot config directory): add more
308 docs on the .buildbot/options keys used by "buildbot try"
309 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
310 (Try.deliverJob): same
312 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
316 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
317 close the filehandle when we stop watching the file. Before, the
318 filehandle was only closed when the LogFileWatcher was
319 garbage-collected, which could be quite a while in the future. If
320 it was still open by the time the next build started, windows will
321 refuse to let the new build delete the old build/ directory. Fixes
322 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
323 #twisted for the catch.
325 2006-09-29 Brian Warner <warner@lothar.com>
327 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
330 2006-09-25 Brian Warner <warner@lothar.com>
332 * setup.py: the new buildbot.steps module wasn't being installed.
333 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
334 (testmsgs): add the extra stuff from buildbot/test/* so you can
335 run unit tests on an installed copy of buildbot, not just from
338 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
339 columns of 'svnlook changed' output contain status information, so
340 strip [:4] instead of [:6]. Depending upon what the status flags
341 were, this would sometimes lead to mangled filenames. Thanks to
342 Riccardo Magliocchetti for the patch. Closes SF#1545146.
344 * buildbot/steps/source.py (Monotone): initial Monotone support,
345 contributed by Nathaniel Smith. Still needs docs and tests, but
346 this code has been in use on the Monotone buildbot for a long
348 * buildbot/slave/commands.py (Monotone): slave-side support
349 * buildbot/changes/monotone.py (MonotoneSource): polling change
352 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
353 contributed a Change Source that polls a Bonsai server (a
354 kind of web-based viewcvs CGI script).
356 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
357 Hearsum contributed a status plugin which sends email in the same
358 format that Tinderbox does: this allows a number of tinderbox
359 tools to be driven by Buildbot instead. Thanks Ben!
361 2006-09-24 Brian Warner <warner@lothar.com>
363 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
364 Thanks to Robert Helmer for the patch.
366 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
367 BuildStatus about the buildslave name at the *beginning* of the
368 build, rather than at the end. Thanks to Alexander Lorenz for the
370 * buildbot/status/html.py (StatusResourceBuild.body): always
371 include the slavename in the build page, not just when the build
373 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
374 slavename in the email message
376 2006-09-21 Brian Warner <warner@lothar.com>
378 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
380 * docs/examples/glib_master.cfg: same
381 * docs/examples/hello.cfg: same
382 * docs/examples/twisted_master.cfg: same, update to current usage
384 2006-09-19 Brian Warner <warner@lothar.com>
386 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
387 (PyFlakes.createSummary): make it compatible with python-2.2
389 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
390 for at least the output-parsing parts of PyFlakes
392 2006-09-18 Brian Warner <warner@lothar.com>
394 * buildbot/steps/python.py: oops, fix import of StringIO
396 2006-09-17 Brian Warner <warner@lothar.com>
398 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
399 turns out that SVN-1.4.0 doesn't fail to update once you've
400 replaced a file with a directory, unlike older versions of SVN and
401 pretty much every other VC tool we support. Since what we really
402 care about is that the update succeeds anyway, stop checking that
403 the tree got clobbered and just assert that the build succeeded.
404 (VCBase.printLogs): add a utility function for debugging
406 * buildbot/process/step.py: oops, added extra imports by mistake
408 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
409 rstrip() on the first line coming out of the 'p4 describe'
410 process, to remove the stray ^M that Wade Brainerd reports seeing
411 in the 'when' field. Fixes SF#1555985.
413 * buildbot/master.py (BuildMaster.loadConfig): improve the error
414 message logged when c['schedulers'] is not right
415 * buildbot/scheduler.py (Scheduler.__init__): improve error
416 message when a Scheduler() is created with the wrong arguments
417 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
418 verify that these error messages are emitted
420 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
421 The idea is that all the base classes (like BuildStep and
422 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
423 will be a leftover backwards-compatibility file that only contains
424 aliases for the steps that were moved out to buildbot.steps.*
425 * lots: change imports to match
426 * buildbot/process/step.py: add a DeprecationWarning if it ever
429 2006-09-12 Brian Warner <warner@lothar.com>
431 * buildbot/scheduler.py (Scheduler.__init__): make sure that
432 builderNames= is actually a sequence, since if you happen to give
433 it a single builder-specification dictionary instead, it won't get
434 caught by the existing assert. Thanks to Brett Neely for the
437 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
439 * docs/buildbot.texinfo (Python BuildSteps): document them
440 (sendchange): include a link to PBChangeSource, since you need one
442 * buildbot/steps/shell.py: clean up test-case-name line, remove some
444 * buildbot/steps/dummy.py: same
446 2006-09-08 Brian Warner <warner@lothar.com>
448 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
449 BuildStep which lets you transfer files from the master to the
450 slave or vice versa. Thanks to Albert Hofkamp for the original
451 patch. Fixes SF#1504631.
452 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
454 (SlaveFileDownloadCommand): same
455 * docs/buildbot.texinfo (Transferring Files): document it
456 * buildbot/test/test_transfer.py: test it
457 * buildbot/test/runutils.py (StepTester): new utility class for
458 testing BuildSteps and RemoteCommands without Builds or Bots or PB
459 * buildbot/test/test_steps.py (CheckStepTester): validate that the
462 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
463 walk through StatusLogs one line at a time, mostly for the benefit
464 of ShellCommand.createSummary methods. You can either walk through
465 STDOUT or STDERR, but the default is STDOUT.
467 * buildbot/status/builder.py (LogFile.readlines): implement it.
468 Note that this is not yet memory-efficient, it just pulls the
469 whole file into RAM and then splits it up with a StringIO.
470 Eventually this should be a generator that only pulls chunks from
472 * buildbot/test/test_status.py (Log.testReadlines): test it
474 * docs/buildbot.texinfo: update to match changes
475 * buildbot/process/factory.py: stop using old definitions
476 * buildbot/process/process_twisted.py: same
477 * buildbot/test/test_*.py: same
479 * buildbot/process/step_twisted.py: move definition to..
480 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
481 relative-import mechanisms prevent this from being named 'twisted'
482 or 'python/twisted' as I would have preferred.
484 * buildbot/process/maxq.py: move definition to..
485 * buildbot/steps/maxq.py: .. here, leave a compatibility import
487 * buildbot/process/step.py: split the user-visible BuildSteps into
488 separate files, all under buildbot/steps/
489 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
490 * buildbot/steps/shell.py: this holds ShellCommand and friends
491 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
493 2006-09-05 Brian Warner <warner@lothar.com>
495 * lots: run pyflakes, removed a lot of unused imports, changed the
496 form of some conditional imports to remove false pyflakes
497 warnings. There are still a number of warnings left, mostly from
498 imports that are done for their side-effects.
499 * buildbot/test/test_vc.py: import twisted.python.failure, since it
502 2006-08-26 Brian Warner <warner@lothar.com>
504 * buildbot/test/test_locks.py (Unit.testLater): make the tests
505 compatible with twisted-1.3.0, for some reason I just can't seem
506 to let go of the past.
508 2006-08-25 Brian Warner <warner@lothar.com>
510 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
512 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
513 all logfiles= in startCommand(), rather than in start() . This
514 makes it easier to have the 'stdio' log come before any secondary
515 logfiles, which I feel makes the waterfall display more
517 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
518 from ShellCommand up into LoggingBuildStep
519 (LoggingBuildStep.__init__): move the handling of logfiles= from
520 ShellCommand up to LoggingBuildStep, because startCommand is
521 provided by LoggingBuildStep, whereas start() was specific to
522 subclasses like ShellCommand and Source. This removes code
523 duplication in those subclasses.
524 (ShellCommand.__init__): same
525 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
526 for a slave that's too old to understand logfiles= into a separate
527 method, so it can live in ShellCommand. The rest of
528 setupLogfiles() can live in LoggingBuildStep.
530 2006-08-24 Brian Warner <warner@lothar.com>
532 * buildbot/locks.py (BaseLock): you can now configure Locks to
533 allow multiple simultaneous owners. They still default to
534 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
536 * docs/buildbot.texinfo (Interlocks): document the new options
537 * buildbot/test/test_locks.py: add a bunch of new unit tests
538 * buildbot/process/base.py (Build.acquireLocks): locks now offer
539 waitUntilMaybeAvailable, not waitUntilAvailable
540 * buildbot/process/step.py (BuildStep.acquireLocks): same
541 * buildbot/master.py (BotMaster.getLockByID): real locks now use
542 the whole lockid in their constructor, not just the name. Also,
543 keep track of which real locks we've handed out by the full
544 lockid, not just class+name, otherwise changing just the maxCount=
545 in the master.cfg file would not actually cause a behavioral
548 2006-08-23 Brian Warner <warner@lothar.com>
550 * buildbot/__init__.py (version): bump to 0.7.4+ while between
552 * docs/buildbot.texinfo: same
554 2006-08-23 Brian Warner <warner@lothar.com>
556 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
557 * docs/buildbot.texinfo: set version to match
558 * NEWS: update for 0.7.4
559 * buildbot/slave/commands.py (command_version): mention that this
560 version (2.1) was released with buildbot-0.7.4
562 2006-08-22 Brian Warner <warner@lothar.com>
566 * CREDITS: new file, list of people who have helped. Thanks!
567 * MANIFEST.in: ship it
569 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
570 new diagrams, the user's manual is more informative than it was.
571 Start shipping the .html user's manual (and generated .png
573 * Makefile: update 'release' target to match
575 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
576 test.. I think the web-parts effort will render it pointless well
577 before it ever actually starts to work.
579 2006-08-20 Brian Warner <warner@lothar.com>
581 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
582 meaning of the prefix= argument. It is now just a string which is
583 stripped from the beginning of the filename. If prefix= is set but
584 not found on any given filename, that filename is ignored. If all
585 filenames in a Change are ignored, the Change is dropped. This is
586 much simpler than the previous sep= nonsense, and I should have
587 implemented it this way from the beginning. Effectively resolves
588 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
589 Gedminas for the catch and suggested fixes.
590 (ChangePerspective.perspective_addChange): implement the actual
592 * buildbot/test/test_changes.py (TestChangePerspective): test it
593 * docs/buildbot.texinfo (PBChangeSource): document it, explain
594 how to properly use prefix=
595 * docs/examples/twisted_master.cfg (source): update prefix= by
596 adding the trailing slash
599 * docs/examples/twisted_master.cfg: update to actual practice
601 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
602 update test case to match new link text.. the HREF has both a
603 class= setting and an enclosing [] pair that I didn't match in the
606 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
607 list of strings is preferred over a single string with embedded
609 (ShellCommand.description=): explain that either single strings or
610 a list of strings is acceptable, and why you might prefer one over
611 the other. Add an example. Fixes SF#1524659, thanks to Paul
612 Winkler for the catch.
613 (Build Steps): update to use f.addStep() rather than using s()
614 and the constructor list
616 * buildbot/process/step.py (ShellCommand): accept either a single
617 string or a list of strings in both description= and
619 * buildbot/test/test_steps.py (Steps.test_description): test it
620 * buildbot/test/runutils.py (makeBuildStep): support for that test
622 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
623 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
624 collecting the files and creating the patch.
626 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
627 per-step URLs that will be displayed on the waterfall display,
628 for things like the HTML output of code-coverage tools, when
629 the results are hosted elsewhere.
630 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
631 way to retrieve these URLs
632 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
633 the method to retrieve these URLs. Also provide backwards
634 compatibility for saved BuildStepStatus instances that didn't have
636 * buildbot/process/step.py (BuildStep.addURL): method to set these
637 URLs from within a BuildStep
638 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
639 (StepBox.getBox): give these external links a distinct CSS class
640 named "BuildStep external" so a .css file can display them
643 * buildbot/test/test_web.py (WaterfallSteps): test that we really
645 * buildbot/test/test_steps.py (Steps): test that we can all the
646 URLs. Also add a bunch of other tests on methods that can be
647 called from within BuildSteps
648 * buildbot/test/runutils.py (makeBuildStep): add utility function
650 2006-08-13 Brian Warner <warner@lothar.com>
652 * docs/buildbot.texinfo (BuildStep LogFiles): document them
654 2006-08-10 Brian Warner <warner@lothar.com>
656 * docs/buildbot.texinfo (Index of master.cfg keys): add another
657 index, this one of things like c['sources'] and c['schedulers']
658 (indices): it looks like my clever idea of putting the @fooindex
659 commands in between the @node and the @subsection (to make the
660 HREF anchor jump to slightly above the section title, which works
661 much better in html) confused texinfo horribly, so I'm moving the
662 index tags back to be just after the @subsection marker. I also
663 added extra lines between the @node/@section paragraph and the
664 index tags, since I think maybe texinfo wants to see these be
667 * docs/Makefile (images): make sure images get built when
669 * docs/images/Makefile: same
671 * buildbot/scripts/runner.py: rename 'buildbot master' to
672 'buildbot create-master', and 'buildbot slave' to 'buildbot
674 * docs/buildbot.texinfo: same
677 * docs/buildbot.texinfo: reimplement the "useful classes" index
678 with actual texinfo indices. The .info rendering is a bit
679 weird-looking but it works well, and the HTML rendering is quite
680 nice. This also puts the index targets in the regular flow of the
681 text, which is easier to maintain.
683 2006-08-06 Brian Warner <warner@lothar.com>
685 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
686 Kevin Turner to prefer the environ= argument be a list rather than
687 a string. If it is a list, it will be joined with a platform-local
688 os.pathsep delimiter, and then prepended to any existing
689 $PYTHONPATH value. This works better in cross-platform (i.e.
690 windows buildslaves) environments when you need to push multiple
691 directories onto the front of the path.
692 (SlaveShellCommand): documented the new magic
693 * docs/buildbot.texinfo (ShellCommand): documented the new magic
694 in a user-visible form
696 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
697 Turner to prefer lists over strings when creating/running VC
698 commands during unit tests. This is clearly necessary to survive
699 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
700 renamed the wq() function to qw() though, since that's how it's
701 spelled in perl. Eventually I'd prefer all commands to be
702 specified with lists.
704 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
705 which are deleted (or not yet created) correctly. Also add
706 failsafe code to not explode if the file-watching poller doesn't
707 get started. Thanks to JP Calderone for the catch and the poller
709 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
711 * buildbot/test/emitlogs.py: same
713 * NEWS: summarize recent changes
715 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
716 clause to avoid the "host key mismatch" warning
718 * buildbot/process/step_twisted.py (Trial.start): if the
719 buildslave is too old to understand logfiles=, fall back to
720 running 'cat _trial_temp/test.log' like before.
721 (Trial.commandComplete): same. this takes advantage of the
722 LoggingBuildStep refactoring to stall commandComplete long enough
723 to run a second RemoteShellCommand.
725 * buildbot/process/step.py (LoggingBuildStep.startCommand):
726 refactor command-completion handling, to allow methods like
727 commandComplete/createSummary/evaluateCommand to return Deferreds.
728 (LoggingBuildStep._commandComplete): delete the refactored method
729 (ShellCommand.setupLogfiles): if the buildslave is too old to
730 understand logfiles=, put a warning message both into twistd.log
731 and into the otherwise empty user-visible LogFiles.
733 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
734 callers to provide the slave-side logfile name, rather than
735 forcing it to come from the local name of the LogFile.
736 (BuildStep.getSlaveName): new method
738 * buildbot/process/base.py (Build.getSlaveName): new method, so
739 steps can find out which buildslave they're running on
741 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
742 to match the s/cvs_ver/command_version/ change
744 2006-08-05 Brian Warner <warner@lothar.com>
746 * buildbot/slave/commands.py (command_version): replace the CVS
747 auto-updated cvs_ver keyword with a manually-updated variable,
748 since CVS is no longer the master repository. Add a description of
749 the remote API change starting in this version (2.1), specifically
750 the fact that SlaveShellCommand now accepts 'initial_stdin',
751 'keep_stdin_open', and 'logfiles'.
753 2006-07-31 Brian Warner <warner@lothar.com>
755 * docs/buildbot.texinfo (System Architecture): Finally add lots of
756 diagrams to describe how the whole system fits together. The
757 images themselves are kept in SVG files, with ascii-art versions
758 in corresponding .txt files. Texinfo knows how to interpolate the
759 text version into .info files, reference the .png versions from
760 .html files, and include .eps versions in the .ps format.
761 * docs/images/Makefile: tools to create .png and .eps
762 * docs/images/*.svg: created pictures with Inkscape.
763 * .darcs-boring: ignore the generated .eps and .png files
765 2006-07-24 Brian Warner <warner@lothar.com>
767 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
768 Scheduler names, since they cause setServiceParent to explode
770 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
772 2006-07-20 Brian Warner <warner@lothar.com>
774 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
775 which runs the buildbot unit tests
777 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
778 classes that are useful in master.cfg
780 2006-07-15 Brian Warner <warner@lothar.com>
782 * Makefile (some-apidocs): new target to build only some epydocs
784 * setup.py: minor comment.. does the classifiers= argument prevent
785 the setup.py script from working on python2.2/2.3?
787 * buildbot/scripts/sample.cfg: update manhole example, arrange into
790 * buildbot/twcompat.py: fix minor typo in comments
792 * buildbot/manhole.py: move all Manhole-related code out to this
793 module. Implement SSH-based manholes (with TwistedConch), and move
794 to conch's nifty line-editing syntax-coloring REPL shell instead
795 of the boring non-editing monochromatic (and deprecated) old
797 * buildbot/master.py: remove all Manhole-related code
798 (BuildMaster.loadConfig._add): make sure the old manhole is
799 removed before we add the new one
800 * docs/buildbot.texinfo (Debug options): document new Manhole options
802 * buildbot/twcompat.py (_which): fix some epydoc issues
803 * buildbot/status/html.py (Waterfall.__init__): same
805 2006-06-29 Brian Warner <warner@lothar.com>
807 * buildbot/interfaces.py: get Interface from b.twcompat to hush
808 deprecation warnings under newer Twisteds (by using
809 zope.interface.Interface instead of old twisted.python.components
811 * buildbot/slave/interfaces.py: same
813 2006-06-28 Brian Warner <warner@lothar.com>
815 * buildbot/slave/commands.py (SVN): add --non-interactive to all
816 svn commands, so it will fail immediately instead of hanging while
817 it waits for a username/password to be typed in.
819 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
820 log message if the step was shut down
822 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
823 obsolete reference to mktap.
825 2006-06-20 Brian Warner <warner@lothar.com>
827 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
828 test to include new 'logfiles' argument sent from master to slave
830 2006-06-19 Brian Warner <warner@lothar.com>
832 * buildbot/process/step_twisted.py (Trial): track Progress from
833 _trial_temp/test.log too
835 * buildbot/process/step.py (OutputProgressObserver): generalize
836 the earlier StdioProgressObserver into an OutputProgressObserver
837 that can track LogFiles other than stdio.
838 (LoggingBuildStep.__init__): same
840 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
841 _trial_temp/test.log, not a separate 'cat' command. TODO: this
842 will fail under windows because of os.sep issues. It might have
843 worked before if 'cat' was doing cygwin path conversion.
845 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
846 creation of LogFileWatchers
847 (ShellCommand._startCommand): and record the files that were
848 watched in the 'headers' section of the ShellCommand output
850 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
851 need to actually pass it to the slave if you want it to work.
852 (ShellCommand): document it a bit
854 * buildbot/test/test_shell.py: new test to validate LogFiles
855 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
857 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
858 before printing the last batch of lines, to test that the polling
859 logic is working properly
861 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
862 handling, making it possible to track multiple logs for a single
863 RemoteCommand. The previous single logfile is now known as the
865 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
866 (RemoteShellCommand.__init__): accept logfiles=
867 (LoggingBuildStep.startCommand): stdio_log is now one of many
868 (ShellCommand): added logfiles= argument, as well as a class-level
869 .logfiles attribute, which will be merged together to figure out
870 which logfiles should be tracked. The latter maybe be useful for
871 subclasses of ShellCommand which know they will aways produce
872 secondary logfiles in the same location.
874 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
875 and closeStdin() methods, preparing to make it possible to write
876 to a ShellCommand's stdin at any time, not just at startup. These
877 writes are buffered if the child process hasn't started yet.
878 (LogFileWatcher): new helper class to watch arbitrary logfiles
879 while a ShellCommand runs. This class polls the file every two
880 seconds, and sends back 10k chunks to the buildmaster.
881 (ShellCommand): rename stdin= to initialStdin=, and add
882 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
884 (ShellCommand.addLogfile): LogFile text is sent in updates with a
885 key of "log" and a value of (logname, data).
886 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
887 'logfiles' to the master-visible args dictionary.
888 (SourceBase.doPatch): match s/stdin/initialStdin/ change
891 * buildbot/test/test_vc.py (Patch.testPatch): same
894 * buildbot/test/emit.py: write to a logfile in the current
895 directory. We use this to figure out what was used as a basedir
896 rather than looking to see which copy of emit.py gets run, so that
897 we can run the commands from inside _trial_temp rather than inside
899 * buildbot/test/subdir/emit.py: same
900 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
901 argument rather than running from buildbot/test/
902 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
903 rather than using an implicit setUp()
904 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
905 (ShellBase.testShell1, etc): use explicit path to emit.py instead
906 of assuming that we're running in buildbot/test/ (and that '.' is
909 * buildbot/slave/commands.py (Command.doStart): refactor Command
910 startup/completion a bit: now the SlaveBuilder calls doStart(),
911 which is not meant for overridding by subclasses, and doStart()
912 calls start(), which is. Likewise the SlaveBuilder calls
913 doInterrupt(), and subclasses override interrupt(). This also puts
914 responsibility for maintaining .running in Command rather than in
916 (Command.doInterrupt): same
917 (Command.commandComplete): same, this is called when the deferred
918 returned by start() completes.
919 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
920 (SlaveBuilder.remote_interruptCommand): same
921 (SlaveBuilder.stopCommand): same
923 2006-06-16 Brian Warner <warner@lothar.com>
925 * buildbot/test/test_shell.py: new test file to contain everything
926 relating to ShellCommand
927 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
928 multiple logfiles in realtime" feature, not yet implemented
929 * buildbot/test/emitlogs.py: support file for testLogFiles
930 * docs/buildbot.texinfo (ShellCommand): document the feature
932 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
934 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
935 for tests which exercise SlaveCommands in isolation.
937 * buildbot/test/test_slavecommand.py: Move some utilities like
938 SignalMixin and FakeSlaveBuilder from here ..
939 * buildbot/test/runutils.py: .. to here, so they can be used by
940 other test classes too
941 * buildbot/test/test_vc.py: more SignalMixin refactoring
942 * buildbot/test/test_control.py: same
943 * buildbot/test/test_run.py: and some rmtree refactoring
945 2006-06-15 Brian Warner <warner@lothar.com>
947 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
948 'testBranch' to match other VC tests and have the tests run in
949 roughly increasing order of dependency
951 * buildbot/test/test_steps.py (LogObserver): new test to verify
952 LogObservers can be created at various times and still get
953 connected up properly
955 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
956 to create BuildStepStatus instances that actually work.
958 * buildbot/process/step.py (LogObserver): add outReceived and
959 errReceived base methods, to be overridden
961 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
962 API to take a name instead of a step, reducing the coupling
963 somewhat. This returns the BuildStepStatus object so it can be
964 passed to the new Step, instead of jamming it directly into the
966 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
968 * buildbot/process/base.py (Build.setupBuild): use both methods
969 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
970 process a bit to match
972 2006-06-14 Brian Warner <warner@lothar.com>
974 * docs/buildbot.texinfo (Adding LogObservers): add some limited
975 docs on writing new LogObserver classes
976 (Writing New Status Plugins): brief docs on how Status Plugins fit
979 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
980 implement a LogObserver that counts how many unit tests have been
982 (Trial.__init__): wire it in
983 * buildbot/test/test_twisted.py (Counter): unit test for it
985 * buildbot/process/step_twisted.py (HLint.commandComplete): update
986 to new cmd.logs['stdio'] scheme
987 (Trial.commandComplete): same
988 (BuildDebs.commandComplete): same
990 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
991 LogFiles, instead of just a single one. The old single logfile is
992 now called "stdio". LoggedRemoteCommand no longer creates a
993 LogFile for you (the code to do that was broken anyway). If you
994 don't create a "stdio" LogFile, then stdout/stderr will be
996 (LogObserver): implement "LogObservers", which a BuildStep can add
997 to parse the output of a command in real-time. The primary use is
998 to provide more useful information to the Progress code, allowing
999 better ETA estimates.
1000 (LogLineObserver): utility subclass which feeds complete lines to
1001 the parser instead of bytes.
1002 (BuildStep.progressMetrics): this is safer as a tuple
1003 (BuildStep.setProgress): utility method, meant to be called by
1005 (BuildStep.addLogObserver): new method, to be called at any time
1006 during the BuildStep (even before any LogFiles have been created),
1007 to attach (or schedule for eventual attachment) a LogObserver to a
1009 (StdioProgressObserver): new LogObserver which replaces the old
1010 "output" progress gatherer
1011 (LoggingBuildStep.__init__): same
1012 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1013 (LoggingBuildStep._commandComplete): must use logs['stdio']
1014 instead of the old single ".log" attribute.
1015 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1016 functionality, now subsumed into StdioProgressObserver
1017 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1018 log name changed from "output" to "stdio".
1021 * buildbot/interfaces.py (ILogFile): add the Interface used from
1022 the BuildStep towards the LogFile
1023 (ILogObserver): and the one provided by a LogObserver
1024 * buildbot/status/builder.py (LogFile): implement it
1026 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1027 HEADER constants here ..
1028 * buildbot/status/builder.py (STDOUT): .. from here
1030 2006-06-13 Brian Warner <warner@lothar.com>
1032 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1033 compatibility with python2.2, which doesn't have the 'substr in
1035 (TestP4Poller.makeTime): utility function to construct the
1036 timestamp using the same strptime() approach as p4poller does. It
1037 turns out that time.mktime() behaves slightly differently under
1038 python2.2, probably something to do with the DST flag, and that
1039 causes the test to fail under python2.2. (changing the mktime()
1040 arguments to have dst=0 instead of -1 caused it to fail under
1041 python2.3. Go figure.)
1042 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1044 2006-06-12 Brian Warner <warner@lothar.com>
1046 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1047 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1048 contributing such an excellent patch, including docs and unit
1049 tests! This makes it *so* much easier to apply. I had to update
1050 test_vc.py to handle some recent refactorings, but everything else
1051 applied smoothly. The only remaining thing I'd like to fix would
1052 be to remove the hard-wired port 1666 used by p4d, and allow it to
1053 claim any unused port. This would allow two copies of the test
1054 suite to run on the same host at the same time, as well as
1055 allowing the test suite to run while a real (production) p4d was
1056 running on the same host. Oh, and maybe we should add a warning to
1057 step.P4 that gets emitted if the slave is too old to provide the
1058 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1059 * buildbot/slave/commands.py (P4): same
1060 (P4Sync): same, some minor updates
1061 * buildbot/changes/p4poller.py: same
1062 * docs/buildbot.texinfo: same
1063 * buildbot/test/test_p4poller.py: same
1064 * buildbot/test/test_vc.py (P4): same
1066 * setup.py: add Trove classifiers for PyPI
1068 2006-06-08 Brian Warner <warner@allmydata.com>
1070 * buildbot/status/client.py
1071 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1072 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1073 build needs to be IRemote'd separately, rather than IRemote'ing
1074 the whole list at once. I can't wait until newpb's serialization
1075 adapters make this unnecessary.
1077 2006-06-06 Brian Warner <warner@lothar.com>
1079 * buildbot/process/step.py (WithProperties): make this inherit
1080 from ComparableMixin, so that reloading an unchanged config file
1081 doesn't cause us to spuriously reload any Builders which use them.
1082 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1085 2006-06-03 Brian Warner <warner@lothar.com>
1087 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1088 running py2exe on windows, contributed by Mark Hammond. Addresses
1089 SF#1401121, but I think we still need to include
1090 buildbot/scripts/sample.cfg
1091 * setup.py: include buildbot_service.py as a script under windows
1092 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1093 a py2exe application), get the icon/css datafiles from a different
1096 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1097 double-escape the build URL. Thanks to Olivier Bonnet for the
1098 patch. Fixes SF#1452801.
1100 2006-06-02 Brian Warner <warner@lothar.com>
1102 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1103 first six columns of 'svnlook' output, not just the first column,
1104 since property changes appear in the other five. Thanks to Olivier
1105 Bonnet for the patch. Fixes SF#1398174.
1107 2006-06-01 Brian Warner <warner@lothar.com>
1109 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1110 the fake build, so that title= has something to be set to
1112 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1113 attribute of the "Build #NN" link in the yellow start-the-build
1114 box to the build's reason. This means that you get a little
1115 tooltip explaining why the build was done when you hover over the
1116 yellow box. Thanks to Zandr Milewski for the suggestion.
1118 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1119 (Box.setETA): handle ETA=None (by stopping the timer)
1120 (Box.update): make the [soon] text less different than the usual
1121 text, so the rest of the text doesn't flop around so much. It
1122 would be awfully nice to figure out how to center this stuff.
1123 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1125 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1126 by default, so that any ShellCommand which fails marks the overall
1127 build as a failure. I should have done this from the beginning.
1128 Add flunkOnFailure=False to the arguments if you want to turn off
1131 2006-05-30 Brian Warner <warner@lothar.com>
1133 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1134 last-build/current-build/current-step. Show what step is currently
1135 running. Show ETA for both the overall build and the current step.
1136 Update GTK calls to modern non-deprecated forms. There's still a
1137 lot of dead code and debug noise to remove.
1139 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1140 shows up properly in status displays
1142 2006-05-28 Brian Warner <warner@lothar.com>
1144 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1145 build we use to verify that WithProperties works:
1147 ** set flunkOnFailure=True so that build failures get noticed
1148 ** set workdir='.' so that the build succeeds, otherwise it is trying
1149 to touch 'build/something', and 'build/' doesn't exist because
1150 usually that's created by a Source step
1151 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1152 this test somehow triggers, in which the 'touch' process becomes
1153 a zombie and we wait for th etimeout before giving up on it.
1155 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1156 to log the Build results and step logs to the twisted log.
1157 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1158 what went wrong if a build was expected to succeed but didn't.
1160 * buildbot/process/step_twisted.py (Trial): set the default
1161 trialMode to '--reporter=bwverbose', which specifies verbose
1162 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1163 '-to', but those are completely missing in modern Twisteds.
1165 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1166 a localhost-only port, to encourage better security
1168 * docs/buildbot.texinfo (Change Sources): mention
1171 * .darcs-boring: add a Darcs boringfile
1173 * README (REQUIREMENTS): stop claiming compatibility with
1176 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1179 2006-05-27 Brian Warner <warner@lothar.com>
1181 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1182 * docs/buildbot.texinfo: same
1184 2006-05-23 Brian Warner <warner@lothar.com>
1186 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1187 * docs/buildbot.texinfo: set version to match
1188 * NEWS: update for 0.7.3
1190 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1191 give a quick mapping from VC system to possible ChangeSources
1192 (Build Properties): add 'buildername'
1194 * buildbot/process/base.py (Build.setupStatus): oops, set
1195 'buildername' and 'buildnumber' properties
1196 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1199 2006-05-22 Brian Warner <warner@lothar.com>
1201 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1202 property interpolation better
1204 * README (INSTALLATION): remove old '-v' argument from recommended
1207 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1208 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1211 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1212 'svnversion' instead of grepping the output of 'svn info', much
1213 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1214 Bonnet for the suggestion.
1215 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1216 require the WC_PATH argument, so run 'svnversion .' instead.
1218 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1219 aren't supposed to have 'self' in their argument list
1221 2006-05-21 Brian Warner <warner@lothar.com>
1223 * buildbot/process/step.py (ShellCommand.start): make
1224 testInterpolate pass. I was passing the uninterpolated command to
1225 the RemoteShellCommand constructor
1226 (ShellCommand._interpolateProperties): oops, handle non-list
1227 commands (i.e. strings with multiple words separated by spaces in
1228 them) properly, instead of forgetting about them.
1230 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1231 to actually try to use build properties in a real build. This test
1233 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1234 to start and evaluate builds
1236 * buildbot/test/test__versions.py: add a pseudo-test to record
1237 what version of Twisted/Python/Buildbot are running. This should
1238 show up at the beginning of _trial_tmp/test.log, and exists to help
1239 debug other problems.
1241 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1242 a filename to be served as 'robots.txt' to discourage web spiders.
1243 Adapted from a patch by Tobi Vollebregt, thanks!
1244 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1245 (Waterfall.test_waterfall): tweak the way that filenames are put
1246 into the config file, to accomodate windows pathnames better.
1248 * docs/buildbot.texinfo (HTML Waterfall): document it
1250 * buildbot/process/process_twisted.py
1251 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1252 changed the build process. The new setup.py no longer takes the
1254 (FullTwistedBuildFactory.__init__): same
1255 (TwistedReactorsBuildFactory.__init__): same
1257 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1258 be placed in the [hooks] section of the central repository (the
1259 one that everybody pushes changes to).
1261 2006-05-20 Brian Warner <warner@lothar.com>
1263 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1264 .darcs-context file, use binary mode. I think this was causing a
1265 Darcs failure under windows.
1267 2006-05-19 Brian Warner <warner@lothar.com>
1269 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1270 use a timezone string of +0000 and gmtime, since this timestamp is
1271 sent to a buildmaster and %z is broken.
1273 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1274 string and localtime, since this timestamp will only be consumed
1275 locally, and %z is broken.
1277 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1278 gmtime, since this timestamp is returned to the buildmaster, and
1281 2006-05-18 Brian Warner <warner@lothar.com>
1283 * NEWS: update in preparation for next release
1285 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1286 setup-repository and do-we-have-the-vc-tools code into a separate
1287 "helper" class, which sticks around in a single module-level
1288 object. This seems more likely to continue to work in the future
1289 than having it hide in the TestCase and hope that TestCases stick
1290 around for a long time.
1292 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1293 addremove' has been deprecated in recent versions of mercurial, so
1294 use 'hg add' instead
1296 2006-05-07 Brian Warner <warner@lothar.com>
1298 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1299 operating under windows, move the file before opening it, since
1300 you can't rename a file that somebody has open.
1302 * buildbot/process/base.py (Build.setupBuild): if something goes
1303 wrong while creating a Step, log the name and arguments, since the
1304 error message when you get the number of arguments wrong is really
1307 2006-05-06 Brian Warner <warner@lothar.com>
1309 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1310 bugs in twisted-specific code not covered by my unit tests, this
1311 time use 'cmd' argument instead of self.cmd
1313 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1314 fix stupid braino: either use startwith or find()==0, not both.
1315 (TwistedReactorsBuildFactory.__init__): another dumb typo
1317 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1318 mark this test as TODO under windows, since process-killing seems
1319 dodgy there. We'll come back to this later and try to fix it
1322 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1323 and don't include a timezone
1324 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1325 This should avoid the windows-with-verbose-timezone-name problem
1327 (Patch.testPatch): add a test which runs 'patch' with less
1328 overhead than the full VCBase.do_patch sequence, to try to isolate
1329 a windows test failure. This one uses slave.commands.ShellCommand
1330 and 'patch', but none of the VC code.
1332 * buildbot/slave/commands.py (getCommand): use which() to find the
1333 executables for 'cvs', 'svn', etc. This ought to help under
1336 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1337 working directory before starting. If an earlier test failed, the
1338 leftover directory would mistakenly flunk a later test.
1339 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1340 Make sure that we use the right commandlines if which("tla") picks
1341 up "tla.exe" (as it does under windows).
1342 (TlaSupport.do_get): factor out this tla-vs-baz difference
1343 (TlaSupport.vc_create): more tla-vs-baz differences
1345 * buildbot/test/test_slavecommand.py
1346 (ShellBase.testShellMissingCommand): stop trying to assert
1347 anything about the error message: different shells on different
1348 OSes with different languages makes it hard, and it really isn't
1349 that interesting of a thing to test anyway.
1351 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1352 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1353 "Panther"), because it has a bug which flunks a couple tests in
1354 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1355 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1356 able to test that yet.
1358 2006-04-30 Brian Warner <warner@lothar.com>
1360 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1361 make sure child commands emit messages in english, so our regexps
1362 will match. Thanks to Nikaus Giger for identifying the problems.
1363 (VCBase._do_vctest_export_1): mode="export" is not responsible
1364 for setting the "got_revision" property, since in many cases it is
1365 not convenient to determine.
1366 (SVNSupport.capable): when running 'svn --version' to check for
1367 ra_local, we want error messages in english
1368 * buildbot/test/test_slavecommand.py
1369 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1370 to emit the error message in english
1372 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1373 the environment with $LC_ALL="C" so that Commands which need to
1374 parse the output of their child processes can obtain it in
1376 (SVN.parseGotRevision): call "svn info" afterwards instead of
1377 watching the output of the "svn update" or "svn checkout".
1378 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1379 (Arch.parseGotRevision): same
1380 (Bazaar.parseGotRevision): same
1381 (Mercurial.parseGotRevision): same
1383 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1384 $LC_ALL="C" when running commands under 'buildbot try', too
1386 * buildbot/test/__init__.py: remove the global os.environ()
1387 setting, instead we do it just for the tests that run commands and
1388 need to parse their output.
1390 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1391 remove the overly-short .timeout on this test, because non-DNotify
1392 platforms must fall back to polling which happens at 10 second
1393 intervals, so a 5 second timeout would never succeed.
1395 2006-04-24 Brian Warner <warner@lothar.com>
1397 * docs/buildbot.texinfo (Installing the code): update trial
1398 invocation, SF#1469116 by Niklaus Giger.
1399 (Attributes of Changes): updated branch-name examples to be
1400 a bit more realistic, SF#1475240 by Stephen Davis.
1402 * contrib/windows/buildbot2.bat: utility wrapper for windows
1403 developers, contributed by Nick Trout (after a year of neglect..
1404 sorry!). SF#1194231.
1406 * buildbot/test/test_vc.py (*.capable): store the actual VC
1407 binary's pathname in VCS[vcname], so it can be retrieved later
1408 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1409 strip out non-numeric timezone information, specifically the funky
1410 German string that his system produced that confuses CVS.
1411 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1412 allow Darcs tests to work on windows
1413 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1414 procutils.which() everywhere, to allow tryclient to work under
1415 windows. Also from Niklaus Giger, SF#1463394.
1417 * buildbot/twcompat.py (which): move the replacement for a missing
1418 twisted.python.procutils.which from test_vc.py to here, so it can
1419 be used in other places too (specifically tryclient.py)
1421 2006-04-23 Brian Warner <warner@lothar.com>
1423 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1424 bare buildbotURL/projectName line with a proper DIV, along with a
1425 CSS class of "title", from Stefan Seefeld (SF#1461675).
1426 (WaterfallStatusResource.body0): remove the redundant 'table'
1427 class from the table
1428 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1429 to the top-row TR, and class="Activity" to the second-row TR,
1430 rather than putting them in the individual TD nodes.
1432 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1433 'got_revision' build property for all VC systems that implement
1434 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1436 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1437 to determine which revision we actually obtained
1438 (CVS.parseGotRevision): implement this for CVS, which just means
1439 to grab a timestamp. Not ideal, and it depends upon the buildslave
1440 having a clock that is reasonably well syncronized with the server,
1441 but it's better than nothing.
1442 (SVN.parseGotRevision): implement it for SVN, which is accurate
1443 (Darcs.parseGotRevision): same
1444 (Arch.parseGotRevision): same
1445 (Bazaar.parseGotRevision): same
1446 (Mercurial.parseGotRevision): same
1448 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1449 keep a record of all non-stdout/stderr/header/rc status updates,
1450 for the benefit of RemoteCommands that send other useful things,
1452 (Source.commandComplete): put any 'got_revision' status values
1453 into a build property of the same name
1456 * buildbot/process/step_twisted.py (Trial): update to deal with
1457 new ShellCommand refactoring
1459 * docs/buildbot.texinfo (Build Properties): document new feature
1460 that allows BuildSteps to get/set Build-wide properties like which
1461 revision was requested and/or checked out.
1463 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1464 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1465 it. Note that this bumps the persistenceVersion of the saved Build
1466 object, so add the necessary upgrade-old-version logic to include
1467 an empty properties dict.
1469 * buildbot/process/base.py (Build.setProperty): implement it
1470 (Build.getProperty): same
1471 (Build.startBuild): change build startup to set 'branch',
1472 'revision', and 'slavename' properties at the right time
1474 * buildbot/process/step.py (BuildStep.__init__): change setup to
1475 require 'build' argument in a better way
1476 (LoggingBuildStep): split ShellCommand into two pieces, for better
1477 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1478 a single RemoteCommand that sends stdout/stderr status text. It
1479 also provides the usual commandComplete / createSummary /
1480 evaluateCommand / getText methods to be overridden...
1481 (ShellCommand): .. whereas ShellCommand is specifically for
1482 running RemoteShellCommands. Other shell-like BuildSteps (like
1483 Source) can inherit from LoggingBuildStep instead of ShellCommand
1484 (WithProperties): marker class to do build-property interpolation
1485 (Source): inherit from LoggingBuildStep instead of ShellCommand
1488 * buildbot/test/test_properties.py: test new functionality
1490 2006-04-21 Brian Warner <warner@lothar.com>
1492 * buildbot/test/test_vc.py: rename testBranch to
1493 testCheckoutBranch to keep the tests in about the right
1496 2006-04-18 Brian Warner <warner@lothar.com>
1498 * docs/buildbot.texinfo (PBListener): improve cross-references
1499 between PBListener and 'buildbot statusgui', thanks to John Pye
1502 2006-04-17 Brian Warner <warner@lothar.com>
1504 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1505 running under Twisted-1.3.0, otherwise skipped tests are reported
1508 * all: use isinstance() instead of 'type(x) is foo', suggested by
1511 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1512 oops, fix a brain-fade from the other week, when making the
1513 addStep changes. I changed all the __init__ upcalls to use the
1514 wrong superclass name.
1515 (FullTwistedBuildFactory.__init__): same
1516 (TwistedDebsBuildFactory.__init__): same
1517 (TwistedReactorsBuildFactory.__init__): same
1518 (TwistedBuild.isFileImportant): use .startswith for clarity,
1519 thanks to Neal Norwitz for the suggestions.
1521 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1522 changes, then deliver them over PB to a remote buildmaster.
1524 * contrib/svnpoller.py: added script by John Pye to poll a remote
1525 SVN repository (by running 'svn log') from a cronjob, and run
1526 'buildbot sendchange' to deliver the changes to a remote
1528 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1529 modification of svnpoller.py), same purpose, but this one loops
1530 internally (rather than expecting to run from a cronjob) and works
1532 * contrib/README.txt: same
1534 2006-04-11 Brian Warner <warner@lothar.com>
1536 * all: fix a number of incorrect names and missing imports, thanks
1537 to Anthony Baxter for the patch.
1538 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1539 remove unused buggy method.
1540 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1541 comes from shutil, not "shutils"
1542 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1543 (Arch.checkSlaveVersion): same
1544 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1546 * buildbot/process/step_twisted2.py: add some missing imports
1547 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1548 this code used to live in twisted.internet.defer
1550 2006-04-10 Brian Warner <warner@lothar.com>
1552 * buildbot/process/step.py (Mercurial): add Mercurial support
1553 * buildbot/slave/commands.py (Mercurial): same
1554 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1555 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1556 not yet tested, but 'try' support *is* covered
1557 * docs/buildbot.texinfo (Mercurial): document it
1559 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1560 some debugging messages (turned off)
1561 * buildbot/test/test_vc.py: improve debug messages
1563 2006-04-07 Brian Warner <warner@lothar.com>
1565 * buildbot/test/test_vc.py (which): define our own which() in case
1566 we can't import twisted.python.procutils, because procutils doesn't
1567 exist in Twisted-1.3
1569 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1570 of SlaveLocks for performance tests
1572 * docs/examples/twisted_master.cfg: update to match current usage
1574 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1575 password, p4 binary, pollinterval, maximum history to check.
1576 Patch from an anonymous sf.net contributor, SF#1219384.
1577 * buildbot/process/step.py (P4Sync.__init__): add username,
1578 password, and client arguments.
1579 * buildbot/slave/commands.py (P4Sync): same
1581 2006-04-05 Brian Warner <warner@lothar.com>
1583 * buildbot/process/factory.py (BuildFactory.addStep): new method
1584 to add steps to a BuildFactory. Use it instead of f.steps.append,
1585 and you can probably avoid using the s() convenience function.
1586 Patch from Neal Norwitz, sf.net #1412605.
1587 (other): update all factories to use addStep
1588 * buildbot/process/process_twisted.py: update all factories to use
1591 2006-04-03 Brian Warner <warner@lothar.com>
1593 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1594 work under windows too. Adapted from a patch by Niklaus Giger,
1595 addresses SF#1463399.
1597 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1598 spawned commands emit parseable results in english and not some
1599 other language. Patch from Niklaus Giger, SF#1463395.
1601 * README (INSTALLATION): discourage users from running unit tests on
1602 a "network drive", patch from Niklaus Giger, SF#1463394.
1604 2006-03-22 Brian Warner <warner@lothar.com>
1606 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1607 function to turn a repository-relative pathname into a (branch,
1608 branch-relative-filename) tuple. Change this function to handle
1609 the branch naming policy used by your Subversion repository.
1610 Thanks to AllMyData.com for sponsoring this work.
1612 2006-03-16 Brian Warner <warner@lothar.com>
1614 * buildbot/scripts/sample.cfg: add python-mode declaration for
1615 vim. Thanks to John Pye for the patch.
1617 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1618 command line, mention the importance of running 'crontab' as the
1619 buildmaster/buildslave user. Thanks to John Pye for the catch.
1621 2006-03-13 Brian Warner <warner@lothar.com>
1623 * buildbot/status/words.py (IRC): add an optional password=
1624 argument, which will be sent to Nickserv in an IDENTIFY message at
1625 login, to claim the nickname. freenode requires this before the
1626 bot can sent (or reply to) private messages. Thanks to Clement
1627 Stenac for the patch.
1628 * docs/buildbot.texinfo (IRC Bot): document it
1630 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1631 larger than chunkSize. Fixes SF#1349253.
1632 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1633 (Log.testConsumer): update to match new internal chunking behavior
1635 2006-03-12 Brian Warner <warner@lothar.com>
1637 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1639 * buildbot/test/test_maildir.py (MaildirTest): rename the
1640 'timeout' method, as it collides with trial's internals
1642 * buildbot/scripts/runner.py: add 'buildbot restart' command
1643 (stop): don't sys.exit() out of here, otherwise restart can't work
1644 * docs/buildbot.texinfo (Shutdown): document it
1646 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1647 * buildbot/status/html.py (Waterfall.__init__): same
1648 * buildbot/process/builder.py (Builder.startBuild): same
1649 * buildbot/process/base.py (BuildRequest): same
1650 * buildbot/sourcestamp.py (SourceStamp): same
1651 * buildbot/scheduler.py (Nightly): same
1653 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1655 * docs/buildbot.texinfo: same
1657 2006-02-17 Brian Warner <warner@lothar.com>
1659 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1660 * docs/buildbot.texinfo: set version number to match
1661 * NEWS: update for 0.7.2
1663 2006-02-16 Brian Warner <warner@lothar.com>
1665 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1667 2006-02-09 Brian Warner <warner@lothar.com>
1669 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1670 add text to explain per-build branch parameters
1671 * NEWS: mention --umask
1673 2006-02-08 Brian Warner <warner@lothar.com>
1675 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1677 (SlaveOptions.optParameters): add --umask, to make it possible to
1678 make buildslave-generated files (including build products) be
1681 * buildbot/slave/bot.py (BuildSlave.startService): same
1683 2006-01-23 Brian Warner <warner@lothar.com>
1685 * buildbot/status/builder.py: urllib.quote() all URLs that include
1686 Builder names, so that builders can include characters like '/'
1687 and ' ' without completely breaking the resulting HTML. Thanks to
1688 Kevin Turner for the patch.
1689 * buildbot/status/html.py: same
1690 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1692 * NEWS: update in preparation for upcoming release
1694 2006-01-18 Brian Warner <warner@lothar.com>
1696 * docs/examples/twisted_master.cfg: update to match the Twisted
1697 buildbot: remove python2.2, switch to exarkun's buildslaves,
1698 disable the .deb builder until we figure out how to build twisted
1699 .debs from SVN, add some ktrace debugging to the OS-X build
1700 process and remove the qt build, remove threadless builders,
1701 change freebsd builder to use landonf's buildslave.
1703 2006-01-12 Brian Warner <warner@lothar.com>
1705 * buildbot/master.py (Manhole.__init__): let port= be a strports
1706 specification string, but handle a regular int for backwards
1707 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1708 used in master.cfg to limit connections to just the local host.
1709 (BuildMaster.loadConfig): same for c['slavePortnum']
1710 * buildbot/scheduler.py (Try_Userpass.__init__): same
1711 * buildbot/status/client.py (PBListener.__init__): same
1712 * buildbot/status/html.py (Waterfall.__init__): same, for both
1713 http_port and distrib_port. Include backwards-compatibility checks
1714 so distrib_port can be a filename string and still mean unix:/foo
1715 * docs/buildbot.texinfo (Setting the slaveport): document it
1716 (Debug options): same
1717 (HTML Waterfall): same
1720 * buildbot/test/test_config.py (ConfigTest): test it
1722 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1723 slaveport's disownServiceParent deferred to fire before opening
1724 the new one. Fixes an annoying bug in the unit tests.
1726 2006-01-03 Brian Warner <warner@lothar.com>
1728 * buildbot/master.py (BuildMaster): remove the .schedulers
1729 attribute, replacing it with an allSchedulers() method that looks
1730 for all IService children that implement IScheduler. Having only
1731 one parent/child relationship means fewer opportunities for bugs.
1732 (BuildMaster.allSchedulers): new method
1733 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1734 also fix ugly bug that caused any config-file reload to
1735 half-forget about the earlier Schedulers, causing an exception
1736 when a Change arrived and was handed to a half-connected
1737 Scheduler. The exception was in scheduler.py line 54ish:
1738 self.parent.submitBuildSet(bs)
1739 exceptions.AttributeError: 'NoneType' object has no attribute
1741 (BuildMaster.addChange): update to use allSchedulers()
1743 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1744 to work properly with twisted-1.3.0, where you must explicitly
1745 include the __implements__ from parent classes
1746 (BaseScheduler.__repr__): make it easier to distinguish distinct
1748 (BaseUpstreamScheduler.__implements__): same
1750 * buildbot/status/builder.py (Status.getSchedulers): update to
1752 * buildbot/test/test_run.py (Run.testMaster): same
1753 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1754 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1755 make sure Scheduler instances are left alone when an identical
1756 config file is reloaded
1757 (ConfigElements.testSchedulers): make sure Schedulers are properly
1760 * Makefile (TRIALARGS): my local default Twisted version is now
1761 2.1.0, update the trial arguments accordingly
1763 2005-12-22 Brian Warner <warner@lothar.com>
1765 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1768 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1769 addChange in the parent class, although I suspect this should be
1770 fixed better in the future.
1772 2005-11-26 Brian Warner <warner@lothar.com>
1774 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1775 explode when branch==None, thanks to Kevin Turner for the catch
1776 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1779 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1781 * docs/buildbot.texinfo: same
1783 2005-11-26 Brian Warner <warner@lothar.com>
1785 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1786 * docs/buildbot.texinfo: set version number to match
1788 2005-11-26 Brian Warner <warner@lothar.com>
1790 * NEWS: update for 0.7.1
1792 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1793 sure that unsubscribe works even if we never sent an ETA update.
1794 Also, don't explode on duplicate unsubscribe.
1795 (BuildStepStatus.addLog): make the convenience "return self"-added
1796 watcher automatically unsubscribe when the Step finishes.
1797 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1798 (BuildStatus.stepStarted): same auto-unsubscribe
1799 (BuilderStatus.buildStarted): same auto-unsubscribe
1801 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1803 (IStatusReceiver.stepStarted): same
1804 (IStatusReceiver.logStarted): same
1806 * buildbot/test/test_run.py (Status): move the Status test..
1807 * buildbot/test/test_status.py (Subscription): .. to here
1809 2005-11-25 Brian Warner <warner@lothar.com>
1811 * NEWS: more updates
1813 * buildbot/locks.py: fix the problem in which loading a master.cfg
1814 file that changes some Builders (but not all of them) can result
1815 in having multiple copies of the same Lock. Now, the real Locks
1816 are kept in a table inside the BotMaster, and the Builders/Steps
1817 use "LockIDs", which are still instances of MasterLock and
1818 SlaveLock. The real Locks are instances of the new RealMasterLock
1819 and RealSlaveLock classes.
1820 * buildbot/master.py (BotMaster.getLockByID): new method to
1821 convert LockIDs into real Locks.
1822 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1823 into real Locks before building
1824 * buildbot/process/step.py (BuildStep.startStep): same
1825 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1826 exercises the problem
1829 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1830 what Schedulers are available
1832 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1833 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1834 'cron'-style build scheduling at certain times of day, week,
1836 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1838 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1839 handling: treat self.fileIsImportant more as an attribute that
1840 contains a callable than as a method. If the attribute is None,
1841 don't call it and assume all filenames are important. It is still
1842 possible to provide a fileIsImportant method in a subclass,
1844 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1846 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1847 test using AnyBranchScheduler with fileIsImportant=None
1849 2005-11-24 Brian Warner <warner@lothar.com>
1851 * buildbot/test/test_config.py (StartService): don't claim a fixed
1852 port number, instead set slavePort=0 on the first pass, figure out
1853 what port was allocated, then switch to a config file that uses
1856 * buildbot/master.py (BuildMaster.loadConfig): close the old
1857 slaveport before opening the new one, because unit tests might
1858 replace slavePort=0 with the same allocated portnumber, and if we
1859 don't wait for the old port to close first, we get a "port already
1860 in use" error. There is a tiny race condition here, but the only
1861 threat is from other programs that bind (statically) to the same
1862 port number we happened to be allocated, and only if those
1863 programs use SO_REUSEADDR, and only if they get control in between
1866 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1868 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1869 deleted ChangeSources before adding any new ones
1870 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1871 compare_attrs, to make sure that a config-file reload does not
1872 unnecessarily replace an unmodified ChangeSource instance
1873 * buildbot/test/test_config.py (ConfigTest.testSources): update
1875 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1876 mean "don't build anything", and add a warning if it gets used
1877 because it isn't actually useful.
1879 * contrib/svn_buildbot.py: update example usage to match the port
1880 number that gets used by the PBChangeSource
1881 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1883 2005-11-22 Brian Warner <warner@lothar.com>
1885 * NEWS: start collecting items for next release
1887 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1888 revisions are strings
1889 (P4Sync.computeSourceRevision): same
1891 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1892 to the Buildbot's overall status page
1893 (StatusResourceBuilder.body): same
1895 2005-11-15 Brian Warner <warner@lothar.com>
1897 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1898 config-file loading, specifically to make sure old StatusTargets
1899 are finished shutting down before new ones start up (thus
1900 resolving a bug in which changing the Waterfall object would fail
1901 because both new and old instances were claiming the same
1902 listening port). Also load new Schedulers after all the new
1903 Builders are set up, in case they fire off a new build right away.
1904 * buildbot/test/test_config.py (StartService): test it
1906 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1907 the branch name to the mail body
1909 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1910 Without it, a config-file reload fails to update an existing
1912 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1913 username/passwd to compare_attrs, for the same reason
1914 * buildbot/status/html.py (Waterfall): add favicon to
1915 compare_attrs, same reason
1917 2005-11-05 Brian Warner <warner@lothar.com>
1919 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1920 baserev before stuffing it in the jobfile. This resolves problems
1921 under SVN (and probably Arch) where revisions are expressed as
1922 numbers. I'm inclined to use string-based revisions everywhere in
1923 the future, but this fix should be safe for now. Thanks to Steven
1924 Walter for the patch.
1926 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1927 binary mode when opening pickle files, to make windows work
1928 better. Thanks to Dobes Vandermeer for the catch.
1929 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1930 (BuilderStatus.getBuildByNumber): same
1931 (Status.builderAdded): same
1932 * buildbot/master.py (BuildMaster.loadChanges): same
1934 * buildbot/util.py (Swappable): delete unused leftover code
1936 * buildbot/process/step.py (SVN): when building on a non-default
1937 branch, add the word "[branch]" to the VC step's description, so
1938 it is obvious that we're not building the usual stuff. Likewise,
1939 when we are building a specific revision, add the text "rNNN" to
1940 indicate what that revision number is. Thanks to Brad Hards and
1941 Nathaniel Smith for the suggestion.
1942 (Darcs.startVC): same
1943 (Arch.startVC): same
1944 (Bazaar.startVC): same
1946 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1947 typo, caught by Mark Dillavou, closes SF#1216636.
1949 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1950 about a test to add some day
1952 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1953 the 'full-2.3' build, and the 'reactors' build is now run under
1954 python-2.4 because the buildslave no longer has gtk/etc bindings
1955 for earlier versions.
1957 2005-11-03 Brian Warner <warner@lothar.com>
1959 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1960 method, takes an IBuildStatus and rebuilds it. It might make more
1961 sense to add this to IBuildControl instead, but that instance goes
1962 away completely once the build has finished, and resubmitting
1963 builds can take place weeks later.
1964 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1965 * buildbot/status/html.py (StatusResourceBuild): also stash an
1966 IBuilderControl so we can use resubmitBuild.
1967 (StatusResourceBuild.body): render "resubmit" button if we can.
1968 Also add hrefs for each BuildStep
1969 (StatusResourceBuild.rebuild): add action for "resubmit" button
1970 (StatusResourceBuilder.getChild): give it an IBuilderControl
1972 * buildbot/status/builder.py (Status.getURLForThing): change the
1973 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1974 that live as targets of buttons like "stop" and "rebuild" can't
1976 * buildbot/status/builder.py (Status.getURLForThing): same
1977 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1978 (StepBox.getBox): same
1979 * buildbot/test/test_web.py (GetURL): same
1982 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1983 exclusivity checks after Source.__init__ upcall, so misspelled
1984 arguments will be reported more usefully
1985 (Darcs.__init__): same
1987 2005-10-29 Brian Warner <warner@lothar.com>
1989 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1990 builder. Move the Try scheduler off to a separate port.
1992 2005-10-27 Brian Warner <warner@lothar.com>
1994 * buildbot/clients/gtkPanes.py
1995 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1996 to cause the app to crash, now they don't.
1998 * buildbot/clients/debug.py: display the buildmaster's location
1999 in the window's title bar
2001 2005-10-26 Brian Warner <warner@lothar.com>
2003 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2004 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2005 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2007 * buildbot/status/html.py (td): put a single non-breaking space
2008 inside otherwise empty <td> elements, as a workaround for buggy
2009 browsers which would optimize them away (along with any associated
2010 styles, like the kind that create the waterfall grid borders).
2011 Patch from Frerich Raabe.
2013 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2014 argv-list as an argument, defaulting to ["-to"], which is
2015 appropriate for the Trial that comes with Twisted-2.1.0 and
2016 earlier. The Trial in current Twisted SVN wants
2017 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2018 defaults to an empty list.
2019 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2020 match it, now that trialMode= is a list instead of a single string
2022 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2024 * docs/buildbot.texinfo: same
2026 2005-10-24 Brian Warner <warner@lothar.com>
2028 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2029 * docs/buildbot.texinfo: set version number to match
2031 2005-10-24 Brian Warner <warner@lothar.com>
2033 * README: update for 0.7.0
2035 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2037 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2038 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2039 send the branch= argument unless the user really provided one, to
2040 retain compatibility with older buildmasters that don't accept
2042 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2045 * docs/buildbot.texinfo: update lots of stuff
2047 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2048 to the 'buildbot sendchange' command
2049 * buildbot/clients/sendchange.py (Sender.send): same
2050 * buildbot/changes/pb.py (ChangePerspective): same
2051 * buildbot/test/test_changes.py (Sender.testSender): test it
2053 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2054 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2055 for consistency with other BuildStep arguments that use camelCase.
2056 Well, at least more of them use camelCase (like flunkOnWarnings)
2057 than don't.. I wish I'd picked one style and stuck with it
2058 earlier. Annoying, but it's best done before the release, since
2059 these arguments didn't exist at all in 0.6.6 .
2061 * buildbot/test/test_vc.py (SVN.testCheckout): same
2062 (Darcs.testPatch): same
2063 * docs/buildbot.texinfo (SVN): document the change
2064 (Darcs): same, add some build-on-branch docs
2065 * docs/examples/twisted_master.cfg: match change
2067 * buildbot/process/step.py (BuildStep): rename
2068 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2069 how it is normally used.
2070 * buildbot/test/test_steps.py (Version.checkCompare): same
2072 * buildbot/process/step.py (CVS.startVC): refuse to build
2073 update/copy -style builds on a non-default branch with an old
2074 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2075 concern is that it will do a VC 'update' in an existing tree when
2076 it is supposed to be switching branches (and therefore clobbering
2077 the tree to do a full checkout), thus building the wrong source.
2078 This used to be a warning, but I think the confusion it is likely
2079 to cause warrants making it an error.
2080 (SVN.startVC): same, also make mode=export on old slaves an error
2081 (Darcs.startVC): same
2082 (Git.startVC): improve error message for non-Git-enabled slaves
2083 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2084 specific revision is built on a slave that doesn't pay attention
2085 to args['revision'], because for slowly-changing trees it will
2086 probably do the right thing, and because we have no way to tell
2087 whether we're asking it to build the most recent version or not.
2088 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2090 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2091 that 'master' is in host:portnum format, to catch errors sooner
2093 2005-10-23 Brian Warner <warner@lothar.com>
2095 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2096 when creating the list of warning messages, include the line
2097 immediately after each WARNING: line, since that's usually where
2098 the file and line number wind up.
2100 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2105 2005-10-22 Brian Warner <warner@lothar.com>
2107 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2108 patch from Brad Hards
2109 * buildbot/status/classic.css: same
2110 * buildbot/test/test_web.py (Waterfall): match changes
2112 * buildbot/test/test_steps.py (BuildStep.setUp): set
2113 nextBuildNumber so the test passes
2114 * buildbot/test/test_status.py (MyBuilder): same
2116 * buildbot/status/html.py (StatusResourceBuild.body): revision
2117 might be numeric, so stringify it before html-escapifying it
2118 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2119 timer for the upcoming build
2120 * buildbot/status/classic.css: add background-color attributes for
2121 offline/waiting/building classes
2123 * buildbot/status/builder.py (BuildStatus): derive from
2124 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2125 the default (i.e. unknown) .slavename to "???" instead of None,
2126 since even unknown slavenames need to be printed eventually.
2127 (BuilderStatus): also derive from styles.Versioned . More
2128 importantly, determine .nextBuildNumber at creation/unpickling
2129 time by scanning the directory of saved BuildStatus instances and
2130 choosing one larger than the highest-numbered one found. This
2131 should fix the problem where random errors during upgrades cause
2132 the buildbot to forget about earlier builds. .nextBuildNumber is
2133 no longer stored in the pickle.
2134 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2135 at least log the error. Also call Builder.determineNextBuildNumber
2136 once the basedir is set.
2138 * buildbot/master.py (BuildMaster.loadChanges): do
2139 styles.doUpgrade afterwards, in case I decide to make Changes
2140 derived from styles.Versioned some day and forget to make this
2144 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2145 when running under older pythons (<2.3) in which the shlex module
2146 doesn't have a 'split' function.
2148 * buildbot/process/step.py (ShellCommand.start): make
2149 errorMessages= be a list of strings to stuff in the log before the
2150 command actually starts. This makes it easier to flag multiple
2151 warning messages, e.g. when the Source steps have to deal with an
2153 (CVS.startVC): handle slaves that don't handle multiple branches
2154 by switching into 'clobber' mode
2155 (SVN.startVC): same. Also reject branches without base_url
2156 (Darcs.startVC): same. Also reject revision= in older slaves
2157 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2158 (Bazaar.startVC): same, and test for baz separately than for arch
2160 * buildbot/slave/commands.py (cvs_ver): document new features
2162 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2163 (BuildStep.slaveVersionNewEnough): more useful utility method
2164 * buildbot/test/test_steps.py (Version): start testing it
2166 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2167 the 'force' command requires python2.3, for the shlex.split method
2169 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2170 since we don't use it anymore. The Twisted buildbot uses a
2173 2005-10-21 Brian Warner <warner@lothar.com>
2175 * buildbot/process/process_twisted.py: rework all BuildFactory
2176 classes to take a 'source' step as an argument, instead of
2177 building up the SVN instance in the factory.
2178 * docs/examples/twisted_master.cfg: enable build-on-branch by
2179 providing a base_url and default_branch
2181 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2182 control over --branch and --revision, not that they are always
2184 * buildbot/status/html.py (StatusResourceBuilder.force): same
2185 (StatusResourceBuild.body): display SourceStamp components
2187 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2188 IRC 'force' command, so it can be shared with an eventual
2189 command-line-tool 'buildbot force' mode.
2190 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2192 2005-10-20 Brian Warner <warner@lothar.com>
2194 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2196 * docs/examples/twisted_master.cfg: update to use Schedulers
2198 * buildbot/scripts/sample.cfg: update with Schedulers
2200 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2201 method specifically for use by HTML "force build" button and the
2202 IRC "force" command. Raises an immediate error if there are no
2204 (IBuilderControl.requestBuild): make this just submit a build, not
2205 try to check for existing slaves or set up any when-finished
2206 Deferreds or anything.
2207 * buildbot/process/builder.py (BuilderControl): same
2208 * buildbot/status/html.py (StatusResourceBuilder.force): same
2209 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2210 * buildbot/test/test_slaves.py: same
2211 * buildbot/test/test_web.py: same
2213 2005-10-19 Brian Warner <warner@lothar.com>
2215 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2216 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2218 2005-10-18 Brian Warner <warner@lothar.com>
2220 * buildbot/status/html.py: provide 'status' argument to most
2221 StatusResourceFOO objects
2222 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2223 and Logfiles" section to make the Build page into a more-or-less
2224 comprehensive source of status information about the build
2226 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2227 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2229 2005-10-17 Brian Warner <warner@lothar.com>
2231 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2232 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2233 out what to do about other projects: the correct options for
2234 recent Twisteds will not work for older ones.
2236 2005-10-15 Brian Warner <warner@lothar.com>
2238 * buildbot/status/builder.py (Status.getURLForThing): add method
2239 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2240 use this in email/IRC status clients to make them more useful, by
2241 providing the end user with hints on where to learn more about the
2242 object being reported on.
2243 * buildbot/test/test_web.py (GetURL): tests for it
2245 2005-10-14 Brian Warner <warner@lothar.com>
2247 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2248 fix bug resulting from deferredResult changes
2250 2005-10-13 Brian Warner <warner@lothar.com>
2252 * buildbot/test/test_changes.py: remove use of deferredResult
2253 * buildbot/test/test_config.py: same
2254 * buildbot/test/test_control.py: same
2255 * buildbot/test/test_status.py: same
2256 * buildbot/test/test_vc.py: this is the only remaining use, since
2257 it gets used at module level. This needs to be replaced by some
2258 sort of class-level run-once routine.
2260 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2262 * lots: implement multiple slaves per Builder, which means multiple
2263 current builds per Builder. Some highlights:
2264 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2265 of (state,currentBuilds) instead of (state,currentBuild)
2266 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2267 (IBuildStatus.getSlavename): new method, so you can tell which
2268 slave got used. This only gets set when the build completes.
2269 (IBuildRequestStatus.getBuilds): new method
2271 * buildbot/process/builder.py (SlaveBuilder): add a .state
2272 attribute to track things like ATTACHING and IDLE and BUILDING,
2274 (Builder): .. the .slaves attribute here, which has been turned
2275 into a simple list of available slaves. Added a separate
2276 attaching_slaves list to track ones that are not yet ready for
2278 (Builder.fireTestEvent): put off the test-event callback for a
2279 reactor turn, to make tests a bit more consistent.
2280 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2281 ping fails due to an exception. This needs work, I'm worried that
2282 a code error could lead to a constantly re-connecting slave.
2283 Especially since I'm trying to move to a distinct remote_ping
2284 method, separate from the remote_print that we currently use.
2285 (BuilderControl.requestBuild): return a convenience Deferred that
2286 provides an IBuildStatus when the build finishes.
2287 (BuilderControl.ping): ping all connected slaves, only return True
2288 if they all respond.
2290 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2291 reconnect when we shut down.
2293 * buildbot/status/builder.py: implement new methods, convert
2294 one-build-at-a-time methods to handle multiple builds
2295 * buildbot/status/*.py: do the same in all default status targets
2296 * buildbot/status/html.py: report the build's slavename in the
2297 per-Build page, report all buildslaves on the per-Builder page
2299 * buildbot/test/test_run.py: update/create tests
2300 * buildbot/test/test_slaves.py: same
2301 * buildbot/test/test_scheduler.py: remove stale test
2303 * docs/buildbot.texinfo: document the new builder-specification
2304 'slavenames' parameter
2306 2005-10-12 Brian Warner <warner@lothar.com>
2308 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2309 report failure correctly, causing Dependent builds to run when
2310 they shouldn't have.
2311 * buildbot/status/builder.py (BuildSetStatus): same
2312 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2313 (Set.testSuccess): test the both-pass case too
2314 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2315 fix this test: it was ending too early, masking the failure before
2316 (Logger): specialized StatusReceiver to make sure the dependent
2317 builds aren't even started, much less completed.
2319 2005-10-07 Brian Warner <warner@lothar.com>
2321 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2322 bot.SlaveBuilder being disowned in the middle of a build
2324 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2325 this inherit from StatusReceiver. Also upcall in __init__. This
2326 fixes the embarrasing crash when the new buildSetSubmitted method
2327 is invoked and Waterfall/etc don't implement their own.
2328 * buildbot/test/test_run.py: add a TODO note about a test to catch
2329 just this sort of thing.
2331 * buildbot/process/builder.py (Builder.attached): remove the
2332 already-attached warning, this situation is normal. Add some
2333 comments explaining it.
2335 2005-10-02 Brian Warner <warner@lothar.com>
2337 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2338 OverflowError when setting up dnotify, because some 64-bit systems
2339 have problems with signed-vs-unsigned constants and trip up on the
2340 DN_MULTISHOT flag. Patch from Brad Hards.
2342 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2344 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2345 progressMetrics, description, descriptionDone to the 'parms' list,
2346 and make use the 'parms' list from the implementation class
2347 instead of only BuildStep to initialize the parameters. This
2348 allows buildbot.process.factory.s() to initialize all the parms,
2349 not just those defined in directly by BuildStep.
2351 2005-09-03 Brian Warner <warner@lothar.com>
2353 * NEWS: start adding items for the next release
2355 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2356 python2.2 tests, change 'Quick' builder to only use python2.3
2358 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2360 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2361 the "Ping Builder" button if the build control is available; the
2362 user sees an exception otherwise
2364 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2366 2005-09-01 Brian Warner <warner@lothar.com>
2368 * buildbot/interfaces.py (IBuilderStatus.getState): update
2369 signature, point out that 'build' can be None
2370 (IBuildStatus.getETA): point out ETA can be none
2372 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2374 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2376 2005-08-31 Brian Warner <warner@lothar.com>
2378 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2379 update to match correct signature: removed 'eta' argument
2380 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2382 2005-08-30 Brian Warner <warner@lothar.com>
2384 * buildbot/status/builder.py (LogFile): remove the assertion that
2385 blows up when you try to overwrite an existing logfile, instead
2386 just emit a warning. This case gets hit when the buildmaster is
2387 killed and doesn't get a chance to write out the serialized
2388 BuilderStatus object, so the .nextBuildNumber attribute gets out
2391 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2392 the 'buildbot sendchange' arguments, for the Darcs context file
2393 * docs/buildbot.texinfo (sendchange): document it
2395 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2396 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2397 (IStatus.getSchedulers): new method
2398 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2399 (Status.getSchedulers): implement
2400 * buildbot/process/builder.py (Builder): maintain
2401 BuilderStatus.pendingBuilds
2402 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2403 (TryBase.addChange): Try schedulers should ignore Changes
2405 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2406 for 'try' on CVS/SVN
2407 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2409 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2410 report status properly.
2411 (Try.createJob): implement unique buildset IDs
2413 * buildbot/status/client.py (StatusClientPerspective): add a
2414 perspective_getBuildSets method for the benefit of jobdir-style
2416 * docs/buildbot.texinfo (try): more docs
2417 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2420 2005-08-18 Brian Warner <warner@lothar.com>
2422 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2423 actually work. It's functional but still kind of clunky. Also, it
2424 only works with the pb-style.. needs to be made to work with the
2427 * buildbot/status/client.py (RemoteBuildSet): new class
2428 (RemoteBuildRequest): same
2429 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2430 object, not the internal BuildStatus object.
2431 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2432 outside of the usual buildStarted() return value.
2433 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2435 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2436 (Try_Userpass_Perspective.perspective_try): return a remotely
2437 usable BuildSetStatus object
2439 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2440 isStarted()/waitUntilStarted()
2442 2005-08-16 Brian Warner <warner@lothar.com>
2444 * buildbot/status/builder.py: implement IBuildSetStatus and
2445 IBuildRequestStatus, wire them into place.
2446 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2447 methods into the BuildSetStatus object.
2448 * buildbot/interfaces.py: same
2449 (IStatus.getBuildSets): new method to get pending BuildSets
2450 (IStatusReceiver.buildsetSubmitted): new method which hears about
2452 * buildbot/master.py (BuildMaster.submitBuildSet): same
2453 * buildbot/process/base.py (BuildRequest): same, replace
2454 waitUntilStarted with subscribe/unsubscribe
2455 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2456 subscribe instead of waitUntilStarted
2457 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2459 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2461 * buildbot/test/test_buildreq.py: update for new code
2462 * buildbot/test/test_control.py (Force.testRequest): same
2465 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2466 for Darcs to not use the tempfile module, so it works under
2467 python-2.2 too. We really didn't need the full cleverness of that
2468 module, since the slave has exclusive control of its own builddir.
2470 2005-08-15 Brian Warner <warner@lothar.com>
2472 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2473 for CVS trees. It doesn't work for non-trunk branches,
2475 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2478 * Makefile: make it easier to test against python2.2
2480 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2481 tearDown2, so things like Arch can unregister archives as they're
2482 shutting down. The previous subclass-override-tearDown technique
2483 resulted in a nested maybeWait() and test failures under
2486 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2487 where we can (Arch), add a branch= argument to set the branch used
2489 (BazExtractor): extract the branch too
2490 (TlaExtractor): same
2491 * buildbot/scripts/runner.py (TryOptions): add --branch
2492 * docs/buildbot.texinfo (try): document --branch/try_branch
2494 * buildbot/slave/commands.py (Darcs): implement get-revision for
2495 Darcs, so that 'try' will work. This requires the tempfile module
2498 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2499 of revisions, branches, and 'try' in the process.
2501 2005-08-11 Brian Warner <warner@lothar.com>
2503 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2504 this, it got broken at some point in the last few releases
2505 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2506 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2507 specifically the removal of ETA information from the tuple
2509 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2512 * docs/buildbot.texinfo (try): document both --builder and
2513 'try_builders' in .buildbot/options
2514 * buildbot/scripts/runner.py (TryOptions): add --builder,
2515 accumulate the values into opts['builders']
2516 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2517 * buildbot/test/test_runner.py (Try): add some quick tests to make
2518 sure 'buildbot try --options' and .buildbot/options get parsed
2519 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2520 use --builder control
2522 * docs/buildbot.texinfo (try): add --port argument to PB style
2524 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2525 actual SourceStamp. Still need to extract a branch name, somehow.
2526 (Try): finish implementing the try client side, still need a UI
2527 for specifying which builders to use
2528 (Try.getopt): factor our options/config-file reading
2529 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2531 * buildbot/test/test_vc.py: match SourceStampExtractor change
2533 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2534 causes the twisted log to be sent to stderr
2536 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2538 2005-08-10 Brian Warner <warner@lothar.com>
2540 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2541 style is 90% done, still missing status reporting or waiting for
2542 the buildsets to finish, and it is completely untested.
2544 * buildbot/trybuild.py: delete file, move contents to ..
2545 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2546 * buildbot/test/test_vc.py: match the move
2548 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2549 of the TryScheduler, no buildsetID or status-tracking support yet
2550 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2552 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2553 possible to set the basedir after __init__ time, so it is easier
2554 to use as a Service-child of the BuildMaster instance
2556 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2557 that delivers messages to its Service parent instead of requiring
2558 a subclass to be useful. This turns out to be much easier to build
2561 * buildbot/scripts/tryclient.py (createJob): utility code to
2562 create jobfiles, will eventually be used by 'buildbot try'
2564 2005-08-08 Brian Warner <warner@lothar.com>
2566 * docs/buildbot.texinfo (try): add docs on the
2567 as-yet-unimplemented Try scheduler
2569 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2570 * buildbot/test/test_scheduler.py: .. here
2571 (Scheduling.testTryJobdir): add placeholder test for 'try'
2573 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2574 addEntry merging (>=chunkSize) behavior
2575 (Log.testConsumer): update to handle new callLater(0) behavior
2577 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2578 both the MAX_LENGTH bugfix and the resumeProducing hang.
2580 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2581 put off the actual resumeProducing for a moment with
2582 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2583 causes large logfiles to hang midway through.
2585 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2586 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2587 and to improve memory usage when streaming the file out to a web
2589 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2590 make this work cleanly
2592 2005-08-03 Brian Warner <warner@lothar.com>
2594 * buildbot/trybuild.py: new file for 'try' utilities
2595 (getSourceStamp): run in a tree, find out the baserev+patch
2596 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2597 implemented for SVN and Darcs, still working on Arch. I don't know
2598 how to make CVS work yet.
2600 * docs/buildbot.texinfo: document the 'buildbot' command-line
2601 tool, including the not-yet-implemented 'try' feature, and the
2602 in-flux .buildbot/ options directory.
2604 2005-07-20 Brian Warner <warner@lothar.com>
2606 * buildbot/locks.py: added temporary id() numbers to Lock
2607 descriptions, to track down a not-really-sharing-the-Lock bug
2609 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2611 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2612 needed for python2.2 compatibility
2613 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2614 are from the __future__
2616 2005-07-19 Brian Warner <warner@lothar.com>
2618 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2619 message when schedulers use unknown builders
2621 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2622 SlaveLock('name') and MasterLock('name') are distinct
2624 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2625 c['schedulers'] in such a way that we can actually accept
2627 * buildbot/test/test_config.py: check it
2629 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2630 utility method to *all* the Schedulers
2631 (Periodic.listBuilderNames): same
2633 * docs/buildbot.texinfo (Interlocks): update chapter to match
2636 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2637 to make sure that c['sources'], c['schedulers'], and c['status']
2638 are all lists of the appropriate objects, and that the Schedulers
2639 all point to real Builders
2640 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2641 'listBuilderNames' utility method to support this
2642 * buildbot/scheduler.py: implement the utility method
2643 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2645 * docs/buildbot.texinfo: add some @cindex entries
2647 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2648 if it wasn't already set: most tla commands will fail unless one
2650 (Arch.createRepository): and disable bazaar's revision cache, since
2651 they cause test failures (the multiple repositories we create all
2652 interfere with each other through the cache)
2654 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2655 bring it properly up to date with twisted-2.0 test guidelines
2657 * buildbot/master.py (BuildMaster): remove references to old
2658 'interlock' module, this caused a bunch of post-merge test
2660 * buildbot/test/test_config.py: same
2661 * buildbot/process/base.py (Build): same
2663 * buildbot/test/test_slaves.py: stubs for new test case
2665 * buildbot/scheduler.py: add test-case-name tag
2666 * buildbot/test/test_buildreq.py: same
2668 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2669 unnecessary init code
2670 (Bot.remote_setBuilderList): match it
2672 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2674 * buildbot/changes/mail.py (parseSyncmail): update comment
2676 * buildbot/test/test_slavecommand.py: disable Shell tests on
2677 platforms that don't suport IReactorProcess
2679 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2680 all places where we open logfiles. It causes OS-X to open the file
2681 in some weird mode that that prevents us from mixing reads and
2682 writes to the same filehandle, which we depend upon to implement
2683 _generateChunks properly. This change doesn't appear to break
2684 win32, on which "b" and "t" are treated differently but a missing
2685 flag seems to be interpreted as "t".
2687 2005-07-18 Brian Warner <warner@lothar.com>
2689 * buildbot/slave/commands.py (ShellCommand): overhaul
2690 error-handling code, to try and make timeout/interrupt work
2691 properly, and make win32 happier
2692 * buildbot/test/test_slavecommand.py: clean up, stop using
2693 reactor.iterate, add tests for timeout and interrupt
2694 * buildbot/test/sleep.py: utility for a new timeout test
2696 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2697 code from the local-usebranches branch
2699 2005-07-17 Brian Warner <warner@lothar.com>
2701 * buildbot/process/process_twisted.py
2702 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2703 minutes, to match the other twisted BuildFactories, and don't
2704 excuse failures in c/qt/win32 reactors any more.
2706 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2707 'freebsd' builders, since the buildslaves have been unavailable
2710 2005-07-13 Brian Warner <warner@lothar.com>
2712 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2713 build-on-branch feature
2715 * buildbot/process/step.py (Darcs.__init__): add base_url and
2716 default_branch arguments, just like SVN
2717 (Arch.__init__): note that the version= argument is really the
2720 * buildbot/slave/commands.py (SourceBase): keep track of the
2721 repository+branch that was used for the last checkout in
2722 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2723 match, we clobber the directory and perform a fresh checkout
2724 rather than trying to do an in-place update. This should protect
2725 us against trying to get to branch B by doing an update in a tree
2726 obtained from branch A.
2727 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2728 (SVN.setup): same, just the svnurl
2729 (Darcs.setup): same, just the repourl
2730 (Arch.setup): same, arch coordinates (url), version, and
2731 buildconfig. Also pull the buildconfig from the args dictionary,
2732 which we weren't doing before, so the build-config was effectively
2734 (Arch.sourcedirIsUpdateable): don't try to update when we're
2735 moving to a specific revision: arch can't go backwards, so it is
2736 safer to just clobber the tree and checkout a new one at the
2738 (Bazaar.setup): same sourcedata as Arch
2740 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2741 use maybeWait, to work with twisted-1.3.0 and twcompat
2742 (Dependencies.testRun_Pass): same
2744 * buildbot/test/test_vc.py: rearrange, cleanup
2746 * buildbot/twcompat.py: add defer.waitForDeferred and
2747 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2748 can work under twisted-1.3.0 .
2750 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2751 now created at setUp time. This increases the runtime of the test
2752 suite considerably (from 91 seconds to 151), but it removes the
2753 need for an offline tarball, which should solve a problem I've
2754 seen where the test host has a different version of svn than the
2755 tarball build host. The new code also validates that mode=update
2756 really picks up recent commits. This approach will also make it
2757 easier to test out branches, because the code which creates the VC
2758 branches is next to the code which uses them. It will also make it
2759 possible to test some change-notification hooks, by actually
2760 performing a VC commit and watching to see the ChangeSource get
2763 2005-07-12 Brian Warner <warner@lothar.com>
2765 * docs/buildbot.texinfo (SVN): add branches example
2766 * docs/Makefile (buildbot.ps): add target for postscript manual
2768 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2769 * buildbot/test/test_locks.py: same
2771 * buildbot/process/step.py (Darcs): comment about default branches
2773 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2774 c['interlocks'] in the config file, complain if it is present.
2775 Scan all locks in c['builders'] to make sure the Locks they use
2777 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2778 add some tests to check for non-uniquely-named Locks
2779 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2780 since the unique-Lock validation code requires it now
2782 * buildbot/locks.py: fix test-case-name
2784 * buildbot/interlock.py: remove old file
2786 2005-07-11 Brian Warner <warner@lothar.com>
2788 * buildbot/test/test_interlock.py: rename to..
2789 * buildbot/test/test_locks.py: .. something shorter
2791 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2792 versions (after 2.0.1) changed internet.TCPClient to shut down the
2793 connection in stopService. Change the code to handle this
2796 * buildbot/process/base.py (Build): handle whole-Build locks
2797 * buildbot/process/builder.py (Builder.compareToSetup): same
2798 * buildbot/test/test_interlock.py: make tests work
2800 * buildbot/process/step.py (BuildStep.startStep): complain if a
2801 Step tries to claim a lock that's owned by its own Build
2802 (BuildStep.releaseLocks): typo
2804 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2805 file reloads don't replace unchanged Builders
2807 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2808 rewrite to cover new Locks instead of old c['interlocks']
2809 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2813 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2814 start the master and connect the buildslave
2816 * buildbot/process/step.py (FailingDummy.done): finish with a
2817 FAILURE status rather than raising an exception
2819 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2820 stringify a BuildRequest.reason that is None
2822 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2824 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2825 allow scheduler.Dependent to work
2826 * buildbot/buildset.py (BuildSet): set .reason and .results
2828 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2829 slaves, to make the test stop hanging. It still fails, of course,
2830 because I haven't even started to implement Locks.
2832 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2834 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2835 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2836 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2837 (Dependent): new class for downstream build dependencies
2838 * buildbot/test/test_dependencies.py: tests (still failing)
2840 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2842 2005-07-07 Brian Warner <warner@lothar.com>
2844 * buildbot/test/runutils.py (RunMixin): factored this class out..
2845 * buildbot/test/test_run.py: .. from here
2846 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2847 added new buildbot.locks tests (which all hang right now)
2848 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2849 * buildbot/process/step.py: claim/release per-BuildStep locks
2851 * docs/Makefile: add 'buildbot.html' target
2853 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2854 interpreted as "HEAD", so that all VC steps can accept branch=None
2855 and have it mean the "default branch".
2857 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2859 2005-07-07 Brian Warner <warner@lothar.com>
2861 * docs/examples/twisted_master.cfg: update to match current usage
2863 * docs/buildbot.texinfo (System Architecture): comment out the
2864 image, it doesn't exist yet and just screws up the HTML manual.
2866 2005-07-05 Brian Warner <warner@lothar.com>
2868 * debian/.cvsignore: oops, missed one. Removing leftover file.
2870 2005-06-17 Brian Warner <warner@lothar.com>
2872 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2873 changed its output in 1.2.0, don't mistakenly think that the
2874 subversion we find isn't capable of supporting our tests.
2876 * debian/*: remove the debian/ directory and its contents, to make
2877 life easier for the proper Debian maintainer
2879 * Makefile (release): same
2881 2005-06-07 Brian Warner <warner@lothar.com>
2883 * everything: create a distinct SourceStamp class to replace the
2884 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2885 Changed the signature of Source.startVC to include the revision
2886 information (instead of passing it through self.args). Implement
2887 branches for SVN (now only Darcs/Git is missing support). Add more
2890 2005-06-06 Brian Warner <warner@lothar.com>
2892 * everything: rearrange build scheduling. Create a new Scheduler
2893 object (configured in c['schedulers'], which submit BuildSets to a
2894 set of Builders. Builders can now use multiple slaves. Builds can
2895 be run on alternate branches, either requested manually or driven
2896 by changes. This changed some of the Status classes. Interlocks
2897 are out of service until they've been properly split into Locks
2898 and Dependencies. treeStableTimer, isFileImportant, and
2899 periodicBuild have all been moved from the Builder to the
2901 (BuilderStatus.currentBigState): removed the 'waiting' and
2902 'interlocked' states, removed the 'ETA' argument.
2904 2005-05-24 Brian Warner <warner@lothar.com>
2906 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2907 erroneously abandons the connection (in clientConnectionFailed)
2908 for non-UserErrors, which means that if we lose the connection due
2909 to a network problem or a timeout, we'll never try to reconnect.
2910 Fix this by not upcalling to the buggy parent method. Note:
2911 twisted-2.0 fixes this, but the function only has 3 lines so it
2912 makes more sense to copy it than to try and detect the buggyness
2913 of the parent class. Fixes SF#1207588.
2915 * buildbot/changes/changes.py (Change.branch): doh! Add a
2916 class-level attribute to accomodate old Change instances that were
2917 pickled before 0.6.5 (where .branch was added for new Changes).
2918 This fixes the exception that occurs when you try to look at an
2919 old Change (through asHTML).
2921 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2924 2005-05-23 Brian Warner <warner@lothar.com>
2926 * buildbot/__init__.py (version): release 0.6.6
2928 2005-05-23 Brian Warner <warner@lothar.com>
2930 * NEWS: update for 0.6.6 release
2931 * debian/changelog: same
2933 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2934 before starting: this was done by twistd back when we spawned it,
2935 now that we're importing the pieces and running them in the
2936 current process, we have to do it ourselves. This allows
2937 master.cfg to import files from the same directory without
2938 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2939 Stichele for the catch.
2940 (Options.opt_version): Add a --version command (actually, just make
2941 the existing --version command emit Buildbot's version too)
2943 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2944 fix to make this behave like other LogFiles, this time to handle
2945 existing LogFiles on disk. (add the missing .upgrade method)
2946 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2948 2005-05-21 Brian Warner <warner@lothar.com>
2950 * buildbot/test/test_runner.py (Create.testMaster): match the
2951 rawstring change in runner.py:masterTAC
2953 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2954 TwistedWords is installed
2955 * buildbot/test/test_status.py: same, with TwistedMail
2957 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2958 some old, deprecated, and removed config keys). This should enable
2959 you to use the base buildbot functionality with Twisted-2.0.0 when
2960 you don't also have TwistedWeb and TwistedWords installed
2962 2005-05-20 Brian Warner <warner@lothar.com>
2964 * buildbot/scripts/runner.py (run): call sendchange(), not
2965 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2966 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2967 (stop): don't wait for process to die when sending SIGHUP
2968 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2969 directory name gets interpreted, which you don't want
2972 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2975 2005-05-18 Brian Warner <warner@lothar.com>
2977 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2979 2005-05-18 Brian Warner <warner@lothar.com>
2981 * README: update for 0.6.5
2982 * debian/changelog: same
2984 * buildbot/changes/changes.py: rename tag= to branch=, since
2985 that's how we're using it, and my design for the upcoming "build a
2986 specific branch" feature wants it. also, tag= was too CVS-centric
2987 * buildbot/changes/mail.py (parseSyncmail): same
2988 * buildbot/process/base.py (Build.isBranchImportant): same
2989 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2990 * docs/buildbot.texinfo (Attributes of Changes): same
2992 * NEWS: update tag=, update for upcoming release
2994 2005-05-17 Brian Warner <warner@lothar.com>
2996 * buildbot/scripts/runner.py (stop): actually poll once per
2997 second, instead of re-killing the poor daemon once per second.
2998 Sleep briefly (0.1s) before the first poll, since there's a good
2999 chance we can avoid waiting the full second if the daemon shuts
3000 down quickly. Also remove the sys.exit() at the end.
3001 (start): remove the unneighborly sys.exit()
3003 * Makefile: improve permission-setting to not kick Arch so badly
3005 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3006 default --keepalive=600, since it doesn't hurt very much, and it's
3007 a hassle to discover that you need it.
3008 * buildbot/test/test_runner.py (Create.testSlave): test it
3010 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3011 IRC bot about EXCEPTION
3013 * buildbot/status/client.py (PBListener): upcall more correctly
3015 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3016 an exception mark the overall build with EXCEPTION, not SUCCESS
3018 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3020 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3021 * Makefile: update some release-related stuff
3023 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3024 gets called when there isn't actually an active process, just end
3025 the Command instead of blowing up. I don't know how it gets into
3026 this state, but the twisted win32 buildslave will sometimes hang,
3027 and when it shakes its head and comes back, it thinks it's still
3028 running a Command. The next build causes this command to be
3029 interrupted, but the lack of self.process.pid breaks the interrupt
3032 * NEWS: document changes since the last release
3034 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3035 look for Makefile.buildbot instead of a bare Makefile . The
3036 'buildbot start' does not install this file, so you have to
3037 manually copy it if you want to customize startup behavior.
3038 (createMaster): change 'buildbot master' command to create
3039 Makefile.sample instead of Makefile, to create master.cfg.sample
3040 instead of master.cfg (requiring you to copy it before the
3041 buildmaster can be started). Both sample files are kept up to
3042 date, i.e. they are overwritten if they have been changed. The
3043 'buildbot.tac' file is *not* overwritten, but if the new contents
3044 don't match the old, a 'buildbot.tac.new' file is created and the
3045 user is warned. This seems to be a much more sane way to handle
3046 startup files. Also, don't sys.exit(0) when done, so we can run
3047 unit tests against it.
3048 (createSlave): same. Don't overwrite the sample info/ files.
3049 * buildbot/scripts/sample.mk: remove. the contents were pulled
3050 into runner.py, since they need to match the behavior of start()
3054 * docs/buildbot.texinfo (Launching the daemons): document it
3055 * buildbot/test/test_runner.py (Create): test it
3057 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3058 version that can handle string-in-string tests, because otherwise
3059 python-2.2 fails the tests. It'd be tremendous if Trial's test
3060 took two strings under 2.2 too.
3062 * everything: fixed all deprecation warnings when running against
3063 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3064 few that come from Twisted itself). This involved putting most of
3065 the Twisted-version specific code in the new buildbot.twcompat
3066 module, and creating some abstract base classes in
3067 buildbot.changes.base and buildbot.status.base (which might be
3068 useful anyway). __implements__ is a nuisance and requires an ugly
3069 'if' clause everywhere.
3071 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3072 delay before finishing the test: it seems that smtp.sendmail
3073 doesn't hang up on the server, so we must wait a moment so it can
3074 hang up on us. This removes the trial warning about an unclean
3077 2005-05-16 Brian Warner <warner@lothar.com>
3079 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3080 tuple of (delay, repeats).
3081 * buildbot/test/test_vc.py (Retry): test it
3082 * docs/buildbot.texinfo (Source Checkout): document it
3083 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3084 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3085 doVCFull() are handled by re-trying the checkout (after a delay)
3086 some number of times.
3087 (ShellCommand._startCommand): make header lines easier to read
3089 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3091 (WebTest.test_logfile): make sure master gets shut down, silences
3092 some "unclean reactor" test errors
3094 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3095 reactor once after shutdown, something in certain versions of
3096 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3097 fails, svn-trunk is ok.
3099 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3100 second win32 error message
3102 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3103 validating the ETA, so the tests don't fail on slow systems
3105 2005-05-15 Brian Warner <warner@lothar.com>
3107 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3108 the new LogFile class, so upgrading works properly
3109 (LogFileProducer.resumeProducing): survive resumeProducing after
3110 we've exhausted the chunkGenerator
3112 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3114 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3115 (Log.testUpgrade): same
3117 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3118 Builds and logs with a cron job.
3120 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3121 of the old non-offline LogFile, added code to upgrade these to
3122 new-style contents-live-on-disk instances at load time (in a way
3123 that doesn't invalidate the old Build pickles, so upgrading to
3124 0.6.5 is not a one-way operation). Got rid of everything related
3126 (LogFile.__init__): create LogFiles with the parent step status,
3127 the log's name, and a builder-relative filename where it can keep
3128 the contents on disk.
3129 (LogFile.hasContents): new method, clients are advised to call it
3130 before getText or getChunks and friends. If it returns False, the
3131 log's contents have been deleted and getText() will raise an
3133 (LogFile.getChunks): made it a generator
3134 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3135 Consumer (except one that takes chunks instead of strings). This
3136 enables streaming of very large logfiles without storing the whole
3138 (BuildStatus.generateLogfileName): create names like
3139 12-log-compile-output, with a _0 suffix if required to be unique
3140 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3141 or earlier) logfiles into new-style ones
3142 (BuilderStatus): remove everything related to 'stub' builds. There
3143 is now only one build cache, and we don't strip logs from old
3145 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3146 since we no longer fight to keep it in the cache
3148 * buildbot/status/html.py (TextLog.render_GET): use a
3149 ChunkConsumer to stream the log entries efficiently.
3150 (ChunkConsumer): wrapper which consumes chunks and writes
3153 * buildbot/test/test_twisted.py (Parse.testParse): use a
3154 LogFile-like object instead of a real one
3156 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3157 (Log.testMerge3): validate more merge behavior
3158 (Log.testChunks): validate LogFile.getChunks
3159 (Log.testUpgrade): validate old-style LogFile upgrading
3160 (Log.testSubscribe): validate LogFile.subscribe
3161 (Log.testConsumer): validate LogFile.subscribeConsumer
3163 * buildbot/interfaces.py (IStatusLogStub): remove
3164 (IStatusLog.subscribeConsumer): new method
3165 (IStatusLog.hasContents): new method
3166 (IStatusLogConsumer): describes things passed to subscribeConsumer
3168 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3169 the log contents if it does not have any contents.
3170 (StatusResourceBuildStep.body): same
3171 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3173 2005-05-14 Brian Warner <warner@lothar.com>
3175 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3176 timeouts to try and make the windows metabuildslave not hang
3178 2005-05-13 Mike Taylor <bear@code-bear.com>
3180 * buildbot/slave/commands.py (rmdirRecursive): added a check
3181 to ensure the path passed into rmdirRecursive actually exists.
3182 On win32 a non-existant path would generate an exception.
3184 2005-05-13 Brian Warner <warner@lothar.com>
3186 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3187 shutil.rmtree which behaves correctly on windows in the face of
3188 files that you have to chmod before deleting. Thanks to Bear at
3189 the OSAF for the routine.
3190 (SourceBase.doClobber): use rmdirRecursive
3192 2005-05-12 Brian Warner <warner@lothar.com>
3194 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3195 method generate chunks instead of returning a big list. This
3196 allows the same method to be used for both old LogFile and new
3198 (OfflineLogFile.getText): use the generator
3199 (OfflineLogFile.subscribe): same
3200 * buildbot/status/html.py (TextLog.resumeProducing): same
3201 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3203 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3204 point out that OfflineLogFile does not currently work with
3205 html.Waterfall . Fixing this is high-priority.
3207 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3208 apparently windows defaults to using stdout
3210 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3211 better message on failure so I can figure out the win32 problem
3213 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3214 log messages to include more useful copies of the command being
3215 run, the argv array, and the child command's environment.
3216 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3218 2005-05-11 Brian Warner <warner@lothar.com>
3220 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3222 * Makefile: update the deb-snapshot version
3224 * docs/buildbot.texinfo: move all .xhtml docs into a new
3225 .texinfo-format document, adding a lot of material in the process.
3226 This is starting to look like a real user's manual. Removed all
3227 the Lore-related files: *.xhtml, *.css, template.tpl .
3228 * docs/Makefile: simple makefile to run 'makeinfo'
3229 * buildbot/scripts/sample.cfg: rearrange slightly
3230 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3232 2005-05-10 Brian Warner <warner@lothar.com>
3234 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3235 different name for the internal twistw module, handle it.
3237 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3238 * setup.py: .. and stop trying to install it
3240 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3241 'git'), the new linux kernel VC system (http://kernel.org/git/).
3242 Thanks to Brandon Philips for the patch.
3243 * buildbot/slave/commands.py (Git): same
3245 2005-05-06 Brian Warner <warner@lothar.com>
3247 * buildbot/status/builder.py (OfflineLogFile): replace the default
3248 LogFile with a form that appends its new contents to a disk file
3249 as they arrive. The complete log data is never kept in RAM. This
3250 is the first step towards handling very large (100MB+) logfiles
3251 without choking quite so badly. (The other half is
3252 producer/consumer on the HTML pages).
3253 (BuildStepStatus.addLog): use OfflineLogFile by default
3254 (BuildStatus.getLogfileName): helper code to give the
3255 OfflineLogFile a filename to work with
3257 * buildbot/test/test_status.py (Results.testAddResults): update
3258 tests to handle new asserts
3259 * buildbot/test/test_vc.py (Patch.doPatch): same
3260 * buildbot/test/test_steps.py (BuildStep.setUp): same
3262 2005-05-05 Brian Warner <warner@lothar.com>
3264 * buildbot/scripts/runner.py (start): if there is no Makefile,
3265 launch the app by importing twistd's internals and calling run(),
3266 rather than spawning a new twistd process. This stands a much
3267 better chance of working under windows.
3268 (stop): kill the process with os.kill instead of spawning
3269 /bin/kill, again to reduce the number of external programs which
3270 windows might not have in the PATH. Also wait up to 5 seconds for
3271 the process to go away, allowing things like 'buildbot stop;
3272 buildbot start' to be reliable in the face of slow shutdowns.
3274 * buildbot/master.py (Dispatcher.__getstate__): remove old
3275 .tap-related methods
3276 (BuildMaster.__getstate__): same
3278 * buildbot/slave/bot.py (makeService): same
3279 (Options.longdesc): same
3280 * buildbot/scripts/runner.py: copy over some old mktap option text
3282 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3283 'buildbot master' now creates a buildbot.tac file, so there is no
3284 longer a create-instance/save/reload sequence. mktap is dead, long
3286 * buildbot/scripts/sample.mk: use twistd -y, not -f
3287 * buildbot/test/test_config.py: remove mktap-based test
3288 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3289 * README: don't reference mktap
3291 * docs/source.xhtml: document some of the attributes that Changes
3294 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3296 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3297 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3298 * buildbot/changes/changes.py (Change)
3299 * buildbot/changes/mail.py (parseSyncmail)
3300 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3302 * buildbot/process/base.py (Build.isTagImportant)
3306 2005-05-04 Brian Warner <warner@lothar.com>
3308 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3309 connection after sending the change, so that unit tests don't
3310 complain about sockets being left around
3312 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3313 exception in phase=0 rendering
3314 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3316 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3318 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3319 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3320 and configuring builders with tuples.
3321 * buildbot/test/test_config.py: stop testing compatibility with
3322 deprecated config keys
3323 * buildbot/test/test_run.py: same
3325 2005-05-03 Brian Warner <warner@lothar.com>
3327 * contrib/arch_buildbot.py: survive if there are no logfiles
3328 (username): just use a string, os.getlogin isn't reliable
3330 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3331 so 'buildbot sendchange' actually works. The earlier test only
3332 covered the internal (non-reactor-running) form.
3334 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3335 script to notify the buildmaster about changes
3337 * buildbot/scripts/runner.py (sendchange): new command to send a
3338 change to a buildbot.changes.pb.PBChangeSource receiver.
3339 * buildbot/test/test_changes.py (Sender): test it
3341 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3342 after any reading of the config file, not just when we do it in
3343 startService. This makes some tests a bit cleaner.
3345 * buildbot/changes/pb.py: add some log messages
3347 * buildbot/process/base.py (Build.startBuild): fix a bug that
3348 caused an exception when the build terminated in the very first
3350 (Build.stepDone): let steps return a status of EXCEPTION. This
3351 terminates the build right away, and sets the build's overall
3352 status to EXCEPTION too.
3353 * buildbot/process/step.py (BuildStep.failed): return a status of
3354 EXCEPTION when that is what has happened.
3356 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3357 implement this, allowing Arch-based projects to get precise
3358 checkouts instead of always using the latest code
3359 (Bazaar): create variant of Arch to let folks use baz instead of
3360 tla. Requires a new buildslave too.
3361 * buildbot/slave/commands.py (Arch): add 'revision' argument
3362 (Bazaar): create variant of Arch that uses baz instead of tla.
3363 Remove the code that extracts the archive name from the
3364 register-archive output, since baz doesn't provide it, and require
3365 the user provide both the archive name and its location.
3366 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3368 2005-05-02 Brian Warner <warner@lothar.com>
3370 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3371 thanks to Nick Trout.
3373 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3374 deals better with source Makefile coming from a read-only CVS
3375 checkout. Thanks to Nick Trout for the catch.
3377 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3380 2005-04-28 Brian Warner <warner@lothar.com>
3382 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3384 * debian/changelog: update for 0.6.4
3386 2005-04-28 Brian Warner <warner@lothar.com>
3388 * README.w32: add a checklist of steps for getting buildbot
3390 * MANIFEST.in: include it in the tarball
3394 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3395 broken .tap files from 0.6.3 by getting rid of .services,
3396 .namedServices, and .change_svc at load time.
3398 2005-04-27 Brian Warner <warner@lothar.com>
3400 * NEWS: update in preparation for new release
3402 * buildbot/test/test_config.py (Save.testSave): don't pull in
3403 twisted.scripts.twistd, we don't need it and it isn't for windows
3406 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3407 accomodate win32 which can't do atomic-rename
3409 2005-04-27 Brian Warner <warner@lothar.com>
3411 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3412 timeouts to help the slow metabuildbot not flunk them so much
3413 (Disconnect.testBuild3): same
3414 (Disconnect.testBuild4): same
3415 (Disconnect.testInterrupt): same
3417 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3418 setup, it was completely broken for new buildmasters (those which
3419 did not have a 'change.pck' already saved. Thanks to Paul Warren
3420 for catching this (embarrassing!) bug.
3421 (Dispatcher.__getstate__): don't save our registered avatar
3422 factories, since they'll be re-populated when the config file is
3424 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3425 tests (since the real mktap-generated BuildMaster doesn't save
3427 (BuildMaster.__getstate__): don't save any service children,
3428 they'll all be re-populated when the config file is re-read.
3429 * buildbot/test/test_config.py (Save.testSave): test for this
3431 2005-04-26 Brian Warner <warner@lothar.com>
3433 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3434 rendered with Blender.. looks a bit nicer.
3435 * buildbot/docs/images/icon.blend: add the Blender file for it
3437 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3438 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3439 running under windows. This appears to be the best way to allow
3440 BuildSteps to do something normal like 'trial -v buildbot.test' or
3441 'make foo' and still expect it to work. The idea is to make the
3442 BuildSteps look as much like what a developer would type when
3443 compiling or testing the tree by hand. This approach probably has
3444 problems when there are spaces in the arguments, so if you've got
3445 windows buildslaves, you'll need to pay close attention to your
3448 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3449 timezone to the timestamp column.
3450 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3452 * buildbot/scripts/runner.py (loadOptions): do something sane for
3453 windows, I think. We use %APPDATA%/buildbot instead of
3454 ~/.buildbot, but we still search everywhere from the current
3455 directory up to the root for a .buildbot/ subdir. The "is it under
3456 $HOME" security test was replaced with "is it owned by the current
3457 user", which is only performed under posix.
3458 * buildbot/test/test_runner.py (Options.testFindOptions): update
3459 tests to match. The "is it owned by the current user" check is
3460 untested. The test has been re-enabled for windows.
3462 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3463 any "\n" in the expected output with the platform-specific line
3464 separator. Make this separator "\r\n" on PTYs under unix, they
3465 seem to do that and I don't know why
3467 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3468 windows for now, I don't know what ~/.buildbot/ should mean there.
3470 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3471 win32 compatibility, don't use "/tmp"
3472 (Basedir.testChangeBuilddir): remove more unixisms
3474 2005-04-26 Brian Warner <warner@lothar.com>
3476 * buildbot/test/test_control.py (Force.rmtree): python2.2
3477 compatibility, apparently its shutil.rmtree ignore_errors=
3478 argument is ignored.
3479 * buildbot/test/test_run.py (Run.rmtree): same
3480 (RunMixin.setUp): same
3482 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3485 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3486 'substring in string' operator, must use string.find(substr)!=-1
3487 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3488 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3490 * buildbot/scripts/runner.py (loadOptions): add code to search for
3491 ~/.buildbot/, a directory with things like 'options', containing
3492 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3493 the current directory, your $HOME directory, or anywhere
3494 inbetween, as long as you're somewhere inside your home directory.
3495 (debugclient): look in ~/.buildbot/options for master and passwd
3496 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3497 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3499 * buildbot/status/client.py (makeRemote): new approach to making
3500 IRemote(None) be None, which works under Twisted-2.0
3501 * buildbot/test/test_status.py (Client.testAdaptation): test it
3503 * buildbot/status/builder.py (Status.builderAdded): when loading a
3504 pickled BuilderStatus in from disk, set its name after loading.
3505 The config file might have changed its name (but not its
3506 directory) while it wasn't looking.
3508 * buildbot/process/builder.py (Builder.attached): always return a
3509 Deferred, even if the builder was already attached
3510 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3512 2005-04-25 Brian Warner <warner@lothar.com>
3514 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3515 category-related exception when announcing a build has finished
3517 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3518 reference no-longer-existent changemaster.sources
3519 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3521 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3524 2005-04-25 Brian Warner <warner@lothar.com>
3526 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3528 * debian/changelog: update for 0.6.3
3530 2005-04-25 Brian Warner <warner@lothar.com>
3532 * MANIFEST.in: make sure debug.glade is in the tarball
3534 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3536 * NEWS: update for the imminent 0.6.3 release
3538 * buildbot/status/html.py (HtmlResource.content): make the
3539 stylesheet <link> always point at "buildbot.css".
3540 (StatusResource.getChild): map "buildbot.css" to a static.File
3541 containing whatever css= argument was provided to Waterfall()
3542 (Waterfall): provide the "classic" css as the default.
3543 * docs/waterfall.classic.css: move default CSS from here ..
3544 * buildbot/status/classic.css: .. to here
3546 * MANIFEST.in: make sure classic.css is included in the tarball
3547 * setup.py: and that it is installed too, under buildbot/status/
3549 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3550 the module level, because buildbot.tap files from 0.6.2 don't have
3551 it in their attribute dictionary.
3553 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3554 really exists at startup, might save some confusion somewhere.
3556 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3558 * docs/waterfall.classic.css:
3559 add a stylesheet that's almost the same as the "classic"
3562 * buildbot/status/builder.py:
3563 add EXCEPTION as a result - this is a problem for the bot
3564 maintainer, not a build problem for the changers
3565 * buildbot/process/step.py:
3566 use EXCEPTION instead of FAILURE for exceptions
3567 * buildbot/status/html.py:
3568 add build_get_class to get a class out of a build/buildstep
3569 finish naming the classes
3570 split out sourceNames to changeNames and builderNames so we
3571 can style them separately
3572 * docs/config.xhtml:
3573 finish documenting classes as they are right now
3575 * buildbot/status/html.py:
3576 name the classes as we agreed on IRC
3577 * docs/config.xhtml:
3580 * buildbot/status/html.py:
3581 same for cssclass->class_
3583 * buildbot/status/html.py:
3584 as decided on IRC, use class_ for the "class" attribute to not
3585 conflict with the class keyword, and clean up the messy **{} stuff.
3587 * buildbot/status/mail.py:
3588 put back "builders" argument, and fix docstring, because the
3589 code *ignores* builders listed in this argument
3591 * buildbot/process/builder.py:
3592 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3594 * docs/config.xhtml:
3595 describe the category argument for builders
3597 * buildbot/status/builder.py:
3598 Fix a silly bug due to merging
3600 * buildbot/process/builder.py:
3601 remove category from the process Builder ...
3602 * buildbot/status/builder.py:
3603 ... and add it to BuilderStatus instead.
3604 Set category on unpickled builder statuses, they might not have it.
3605 * buildbot/master.py:
3606 include category when doing builderAdded
3607 * buildbot/status/mail.py:
3608 return None instead of self for builders we are not interested in.
3609 * buildbot/test/test_run.py:
3610 fix a bug due to only doing deferredResult on "dummy" waiting
3611 * buildbot/test/test_status.py:
3612 add checks for the Mail IStatusReceiver returning None or self
3614 * buildbot/status/html.py:
3615 fix testsuite by prefixing page title with BuildBot
3617 * buildbot/status/builder.py:
3618 have .category in builder status ...
3619 * buildbot/process/builder.py:
3620 ... and set it from Builder
3621 * buildbot/status/html.py:
3622 make .css a class variable
3623 * buildbot/test/test_status.py:
3624 write more tests to cover our categories stuff ...
3625 * buildbot/status/mail.py:
3626 ... and fix the bug that this uncovered
3628 * buildbot/changes/mail.py:
3629 * buildbot/changes/pb.py:
3630 * buildbot/master.py:
3631 * buildbot/process/base.py:
3632 * buildbot/process/factory.py:
3633 * buildbot/process/interlock.py:
3634 * buildbot/process/step.py:
3635 * buildbot/process/step_twisted.py:
3636 * buildbot/slave/commands.py:
3637 * buildbot/status/builder.py:
3638 * buildbot/status/client.py:
3639 * buildbot/status/html.py:
3640 * buildbot/status/mail.py:
3641 * buildbot/status/progress.py:
3642 * buildbot/test/test_changes.py:
3643 * buildbot/test/test_config.py:
3644 * buildbot/test/test_control.py:
3645 * buildbot/test/test_interlock.py:
3646 * buildbot/test/test_maildir.py:
3647 * buildbot/test/test_mailparse.py:
3648 * buildbot/test/test_run.py:
3649 * buildbot/test/test_slavecommand.py:
3650 * buildbot/test/test_status.py:
3651 * buildbot/test/test_steps.py:
3652 * buildbot/test/test_twisted.py:
3653 * buildbot/test/test_util.py:
3654 * buildbot/test/test_vc.py:
3655 * buildbot/test/test_web.py:
3657 add test-case-name at the top of a whole set of files
3659 * buildbot/status/builder.py:
3660 keep order of addition when getting builder names
3661 * buildbot/status/words.py:
3662 * buildbot/test/test_run.py:
3663 add test for getBuilderNames
3665 * buildbot/process/base.py:
3666 * buildbot/process/step.py:
3667 * buildbot/status/builder.py:
3668 * buildbot/status/html.py:
3669 make buildbot css-able
3670 replace the color code for purple with purple, don't understand
3671 why it wasn't purple to start with
3673 * buildbot/status/words.py:
3674 ok, so it doesn't look like BuilderStatus.remote is still valid.
3675 Use what waterfall uses instead.
3677 * buildbot/interfaces.py:
3678 * buildbot/status/builder.py:
3679 * buildbot/status/html.py:
3680 * buildbot/status/mail.py:
3681 * buildbot/status/words.py:
3682 * buildbot/test/test_run.py:
3683 use categories everywhere and make it be a list. More sensible
3684 for the future. Also make words actually respect this in
3687 * buildbot/interfaces.py:
3688 add category argument to getBuilderNames
3689 * buildbot/process/builder.py:
3690 * buildbot/status/builder.py:
3691 * buildbot/status/html.py:
3692 * buildbot/status/mail.py:
3693 * buildbot/status/words.py:
3694 * buildbot/test/test_run.py:
3695 move from specifying builders by name to specifying the category
3697 * buildbot/status/html.py:
3698 * buildbot/status/words.py:
3699 add "builders=" to __init__ of status clients so they can
3700 limit themselves to the given list of builders to report on
3702 * buildbot/status/html.py: set the title to the product name
3704 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3706 * buildbot/interfaces.py:
3707 * buildbot/status/builder.py:
3708 more documentation. Hm, not sure if ChangeLog entries make sense
3711 2005-04-23 Brian Warner <warner@lothar.com>
3713 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3715 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3717 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3718 the sub-commands that log buildmaster status to stdout and to a
3719 GUI window, respectively.
3721 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3722 functionality is working again, but all the step-status and ETA
3723 stuff is missing. Commented out a lot of code pending more
3726 * buildbot/status/client.py: make sure that IRemote(None) is None
3728 * buildbot/changes/changes.py: import defer, oops
3729 (ChangeMaster): remove the .sources list, rely upon the fact that
3730 MultiServices can be treated as sequences of their children. This
3731 cleans up the add/remove ChangeSource routines a lot, as we keep
3732 exactly one list of the current sources instead of three.
3734 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3735 up an empty ChangeMaster at init time.
3736 (BuildMaster.loadChanges): if there are changes to be had from
3737 disk, replace self.change_svc with the new ones. If not, keep
3738 using the empty ChangeMaster set up in __init__.
3739 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3740 instead of a separate list, makes the code a bit cleaner.
3741 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3742 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3743 Extend the test to make sure we can get rid of the sources when
3746 2005-04-22 Brian Warner <warner@lothar.com>
3748 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3749 and info/host files when making the slave directory
3751 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3752 whendone= argument, just return the Deferred and let the caller do
3753 what they want with it.
3754 (Disconnect.testBuild1): wait for shutdownSlave
3755 (Basedir.testChangeBuilddir): new test to make sure changes to the
3756 builddir actually get propagated to the slave
3758 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3759 explicit method, rather than passing the builddir in __init__ .
3760 Make sure to update self.basedir too, this was broken before.
3761 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3762 builders and for ones that have just had their builddir changed.
3763 (BotFactory): add a class-level .perspective attribute, so
3764 BuildSlave.waitUntilDisconnected won't get upset when the
3765 connection hasn't yet been established
3766 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3767 tests can reach through it to inspect the SlaveBuilders
3769 * buildbot/process/base.py (Build.buildException): explain the
3770 log.err with a log.msg
3771 * buildbot/process/builder.py (Builder.startBuild): same
3772 (Builder._startBuildFailed): improve error message
3774 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3775 occurred because we lost the brand-new connection, retry instead
3776 of giving up. If not, it's probably an authorization failure, and
3777 it makes sense to stop trying. Make sure we log.msg the reason
3778 that we're log.err'ing the failure, otherwise test failures are
3779 really hard to figure out.
3781 * buildbot/master.py: change loadConfig() to return a Deferred
3782 that doesn't fire until the change has been fully implemented.
3783 This means any connected slaves have been updated with the new
3784 builddir. This change makes it easier to test the code which
3785 actually implements this builddir-updating.
3786 (BotPerspective.addBuilder): return Deferred
3787 (BotPerspective.removeBuilder): same
3788 (BotPerspective.attached): same
3789 (BotPerspective._attached): same. finish with remote_print before
3790 starting the getSlaveInfo, instead of doing them in parallel
3791 (BotPerspective.list_done): same
3792 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3793 actually calling slave.disconnect()
3794 (BotMaster.addBuilder): same
3795 (BotMaster.removeBuilder): same
3796 (BuildMaster.loadConfig): same
3797 (BuildMaster.loadConfig_Slaves): same
3798 (BuildMaster.loadConfig_Sources): same
3799 (BuildMaster.loadConfig_Builders): same
3800 (BuildMaster.loadConfig_status): same
3802 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3803 a Deferred that fires when the source is finally removed
3805 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3806 the previous tree on win32, where we have to do it synchronously,
3807 make sure we return a Deferred anyway.
3808 (SourceBase.doCopy): same
3810 * buildbot/scripts/runner.py (statusgui): use the text client for
3811 now, while I rewrite the Gtk one
3812 * buildbot/clients/base.py: strip out old code, leaving just the
3813 basic print-message-on-event functionality. I also remove the
3814 ReconnectingPBClientFactory, but it does at least quit when it
3815 loses the connection instead of going silent
3817 2005-04-21 Brian Warner <warner@lothar.com>
3819 * Makefile: minor tweaks
3821 * NEWS: point out deprecation warnings, new features for
3824 * buildbot/master.py (BuildMaster.loadConfig): emit
3825 DeprecationWarnings for Builders defined with tuples. Rearrange
3826 code to facility removal of deprecated configuration keys in the
3829 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3830 'buildbot' command to put a little Makefile in the target that
3831 helps you re-create the buildbot.tap file, start or stop the
3832 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3833 all the files 0600, since they contain passwords.
3834 (start): if there is a Makefile, and /usr/bin/make exists, use
3835 'make start' in preference to a raw twistd command. This lets
3836 slave admins put things like PYTHONPATH variables in their
3837 Makefiles and have them still work when the slave is started with
3838 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3839 be nice to first try the 'make' command and only fall back to
3840 twistd if it fails. TODO: the Makefile's "start" command does not
3841 add the --reactor=win32 argument when running under windows.
3842 (Options.debugclient, Options.statusgui): add sub-commands to launch
3843 the debug client (formerly in contrib/debugclient.py) and the
3844 Gtk status application (currently broken)
3845 * buildbot/clients/debug.py: move from contrib/debugclient.py
3846 * buildbot/clients/debug.glade: same
3848 * buildbot/test/test_trial.py: remove it. This requires some
3849 functionality out of Twisted that isn't there yet, and until then
3850 having it around just confuses things.
3852 * buildbot/test/test_slavecommand.py (Shell): test both with and
3853 without PTYs, and make sure that command output is properly
3854 interleaved in the with-PTY case. I think the without-PTY test
3855 should pass on windows, where we never use PTYs anyway.
3857 2005-04-20 Brian Warner <warner@lothar.com>
3859 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3861 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3863 * NEWS: start creating entries for the next release
3865 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3867 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3868 (WebTest.test_webPathname): same
3869 (WebTest.test_webPathname_port): same
3870 (WebTest.test_waterfall): use the default favicon rather than
3871 rooting around the filesystem for it. Open the expected-icon file
3872 in binary mode, to make win32 tests happier (thanks to Nick Trout
3874 * buildbot/status/html.py (buildbot_icon): win32 portability
3876 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3877 win32-compatibility fixes from Nick Trout, the "file not found" message
3878 is different under windows
3879 (FakeSlaveBuilder.__init__): clean up setup a bit
3880 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3882 2005-04-19 Brian Warner <warner@lothar.com>
3884 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3885 skip-if-repositories-are-unavailable test to not kill the trial
3886 that comes with Twisted-1.3.0
3888 * setup.py: install buildbot.png icon file when installing code
3890 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3891 environment used by the command, at least on the child side.
3893 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3894 this method needs to be added and implemented because it gets
3895 called under heavy load. I don't quite understand the
3896 producer/consumer API enough to write it.
3897 (StatusResource.getChild): add a resource for /favicon.ico
3898 (Waterfall.__init__): add favicon= argument
3899 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3900 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3901 (WebTest.test_webPathname): same
3902 (WebTest.test_webPathname_port): same
3903 * docs/config.xhtml: mention favicon=
3904 * buildbot/buildbot.png: add a default icon, dorky as it is
3906 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3908 * buildbot/master.py:
3909 * buildbot/process/base.py:
3910 * buildbot/process/builder.py:
3911 * buildbot/process/interlock.py:
3912 * buildbot/status/builder.py:
3913 * buildbot/status/html.py:
3914 * buildbot/status/mail.py:
3915 * buildbot/status/words.py:
3916 new documentation while digging through the code
3918 2005-04-17 Brian Warner <warner@lothar.com>
3920 * general: try to fix file modes on all .py files: a+r, a-x,
3921 but let buildbot/clients/*.py be +x since they're tools
3923 * docs/epyrun (addMod): when an import fails, say why
3925 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3927 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3929 * buildbot/process/base.py:
3930 * buildbot/process/builder.py:
3931 * buildbot/status/builder.py:
3932 new documentation while digging through the code
3934 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3936 * buildbot/changes/changes.py:
3937 * buildbot/changes/p4poller.py:
3938 * buildbot/interfaces.py:
3939 * buildbot/process/base.py:
3940 * buildbot/process/builder.py:
3941 * buildbot/process/step.py:
3942 * buildbot/process/step_twisted.py:
3943 * buildbot/slave/bot.py:
3944 * buildbot/slave/commands.py:
3945 * buildbot/status/builder.py:
3946 fix all docstrings to make epydoc happy. In the process of fixing
3947 some, I also moved pieces of docs, and removed some deprecated
3950 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3952 * buildbot/process/builder.py:
3953 * buildbot/process/interlock.py:
3954 * buildbot/process/process_twisted.py:
3955 * buildbot/process/step.py:
3956 BuildProcess -> Build, as it looks like that's what happened
3957 * buildbot/process/base.py:
3958 * buildbot/process/factory.py:
3961 2005-04-17 Brian Warner <warner@lothar.com>
3963 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3964 update compile command to accomodate the Twisted split.. now
3965 instead of './setup.py build_ext -i', you do './setup.py all
3966 build_ext -i', to run build_ext over all sub-projects.
3967 (FullTwistedBuildFactory): same
3968 (TwistedReactorsBuildFactory): same
3970 * buildbot/status/html.py (TextLog.finished): null out self.req
3971 when we're done, otherwise the reference cycle of TextLog to .req
3972 to .notifications to a Deferred to TextLog.stop keeps them from
3973 being collected, and consumes a huge (610MB on pyramid at last
3974 check) amount of memory.
3976 2005-04-11 Brian Warner <warner@lothar.com>
3978 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3979 normalize the VC-repository location.. makes SVN happier with
3980 certain test environments.
3982 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3983 RemoteShellCommand gets its own .env dictionary, so that code in
3984 start() doesn't mutate the original. I think this should fix the
3985 step_twisted.Trial problem where multiple identical components
3986 kept getting added to PYTHONPATH= over and over again.
3988 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3989 adding epydoc-format docstrings to many classes. Thanks to Thomas
3990 Vander Stichele for the patches.
3991 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3992 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3993 * buildbot/slave/bot.py, commands.py, registry.py: same
3995 2005-04-05 Brian Warner <warner@lothar.com>
3997 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3998 preserve timestamps, helps incremental builds of large trees.
3999 Patch from Rene Rivera.
4001 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4002 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4005 2005-04-03 Brian Warner <warner@lothar.com>
4007 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4008 with one dict, apparently exec has some scoping bugs when used
4009 with both global/local dicts. Thanks to Nathaniel Smith for the
4012 2005-04-02 Brian Warner <warner@lothar.com>
4014 * buildbot/process/step_twisted.py (countFailedTests): the new
4015 trial in Twisted-2.0 emits a slightly different status line than
4016 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4017 mistakenly think the test count is unparseable.
4018 (Trial.start): note that for some reason each build causes another
4019 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4020 be fixed but I'm not sure quite where the problem is.
4022 2005-04-01 Brian Warner <warner@lothar.com>
4024 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4025 deferredResult to avoid hangs/warnings under twisted-2.0
4026 (RunMixin.tearDown): same
4027 (RunMixin.shutdownSlave): same
4028 (Disconnect.testIdle1): same
4029 (Disconnect.testBuild2): same: wait one second after the build
4030 finishes for test to really be done.. this should be cleaned up to
4031 avoid wasting that second. Builder.detach uses a callLater(0),
4032 either that should be done in-line (something else needed that
4033 behavior), or it should return a Deferred that fires when the
4034 builder is really offline.
4035 (Disconnect.testBuild3): same
4036 (Disconnect.testDisappear): same
4038 * buildbot/test/test_web.py: rearrange server-setup and teardown
4039 code to remove unclean-reactor warnings from twisted-2.0
4041 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4042 so the tests don't hang under twisted-2.0
4044 2005-03-31 Brian Warner <warner@lothar.com>
4046 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4047 caused a warning each time the master changed our set of builders
4049 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4050 w32, don't unlink the file unless it already exists. Thanks to
4051 Baptiste Lepilleur for the catch.
4052 (BuilderStatus.saveYourself): same
4054 2005-02-01 Brian Warner <warner@lothar.com>
4056 * buildbot/status/html.py (TextLog.getChild): use a /text child
4057 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4058 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4059 logfile as text/plain (no markup, no headers). This replaces the
4060 previous scheme (which used an ?text=1 argument), and gets us back
4061 to a relative link (which works better when the buildbot lives
4062 behind another web server, such as Apache configured as a reverse
4063 proxy). Thanks to Gerald Combs for spotting the problem.
4065 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4068 2004-12-13 Brian Warner <warner@lothar.com>
4070 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4072 * debian/changelog: update for 0.6.2
4073 * NEWS: finalize for 0.6.2
4075 2004-12-11 Brian Warner <warner@lothar.com>
4077 * NEWS: bring it up to date
4079 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4080 detection code. Require some sign of life from the buildmaster
4081 every BotFactory.keepaliveInterval seconds. Provoke this
4082 indication at BotFactory.keepaliveTimeout seconds before the
4083 deadline by sending a keepalive request. We don't actually care if
4084 that request is answered in a timely fashion, what we care about
4085 is that .activity() is called before the deadline. .activity() is
4086 triggered by any PB message from the master (including an ack to
4087 one of the slave's status-update messages). With this new scheme,
4088 large status messages over slow pipes are OK, as long as any given
4089 message can be sent (and thus acked) within .keepaliveTimeout
4090 seconds (which defaults to 30).
4091 (SlaveBuilder.remote_startCommand): record activity
4092 (SlaveBuilder.ackUpdate): same
4093 (SlaveBuilder.ackComplete): same
4094 (BotFactory.gotPerspective): same
4095 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4097 2004-12-09 Brian Warner <warner@lothar.com>
4099 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4102 * buildbot/process/step_twisted.py (Trial._commandComplete):
4103 update self.cmd when we start the 'cat test.log' transfer. Without
4104 this, we cannot interrupt the correct RemoteCommand when we lose
4107 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4108 trying to tell the slave to stop the command if we're already
4109 inactive, or if we no longer have a .remote
4111 * buildbot/process/builder.py (Builder._detached): don't let an
4112 exception in currentBuild.stopBuild() prevent the builder from
4113 being marked offline
4115 2004-12-07 Brian Warner <warner@lothar.com>
4117 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4118 KeyError that happens when you ask for a non-existent Builder, and
4119 translate it into a UsageError.
4121 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4122 losing the slave in the middle of a remote step is handled too
4124 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4125 be a Failure, so be sure to stringify it before using it as the
4126 contents of the 'interrupt' logfile
4127 (RemoteCommand.interrupt): use stringified 'why' in
4128 remote_interruptCommand too, just in case
4130 2004-12-06 Brian Warner <warner@lothar.com>
4132 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4133 instead of 'tla update', which is more efficient in case we've
4134 missed a couple of patches since the last update.
4136 * debian/changelog: update for previous (0.6.1) release. Obviously
4137 this needs to be handled better.
4139 2004-12-05 Brian Warner <warner@lothar.com>
4141 * NEWS: update for stuff since last release
4143 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4144 match the maybeDeferred change in Dispatcher.requestAvatar
4145 * buildbot/changes/pb.py (ChangePerspective.attached): same
4146 * buildbot/status/client.py (StatusClientPerspective.attached): same
4147 * buildbot/process/builder.py (Builder._attached3): same
4148 * buildbot/pbutil.py (NewCredPerspective.attached): same
4150 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4151 the date to the top-most box, if it is not the same as today's
4154 * docs/slave.xhtml: provide a buildslave setup checklist
4156 * docs/source.xhtml (Arch): correct terminology
4158 2004-12-04 Brian Warner <warner@lothar.com>
4160 * buildbot/test/test_slavecommand.py: use sys.executable instead
4161 of hard-coding 'python' for child commands, might help portability
4163 * docs/examples/twisted_master.cfg: update to current usage
4165 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4166 'stop build' command to the IRC bot
4168 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4169 message that broke PBChangeSource
4171 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4172 (SlaveBuilder): make some attributes class-level, remove the old
4173 "update queue" which existed to support resuming a build after the
4174 master connection was lost. Try to reimplement that feature later.
4175 (SlaveBuilder.stopCommand): clear self.command when the
4176 SlaveCommand finishes, so that we don't try to kill a leftover one
4178 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4181 * buildbot/slave/commands.py (SourceBase): set self.command for
4182 all VC commands, so they can be interrupted.
4184 2004-12-03 Brian Warner <warner@lothar.com>
4186 * buildbot/master.py: clean up slave-handling code, to handle
4187 slave-disconnect and multiple-connect better
4188 (BotPerspective): make these long-lasting, exactly one per bot
4189 listed in the config file.
4190 (BotPerspective.attached): if a slave connects while an existing
4191 one appears to still be connected, disconnect the old one first.
4192 (BotPerspective.disconnect): new method to forcibly disconnect a
4193 buildslave. Use some hacks to empty the transmit buffer quickly to
4194 avoid the long (20-min?) TCP timeout that could occur if the old
4195 slave has dropped off the net.
4196 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4197 own their own SlaveStatus objects. Remove .attached/.detached, add
4198 .addSlave/.removeSlave, treat slaves like Builders (config file
4199 parsing sends deltas to the BotMaster). Inform the slave
4200 instances, i.e. the BotPerspective, about addBuilder and
4202 (BotMaster.getPerspective): turns into a single dict lookup
4203 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4204 which gives BotPerspective.attached a chance to disconnect the old
4206 (BuildMaster.loadConfig): add code (disabled) to validate that all
4207 builders use known slaves (listed in c['bots']). The check won't
4208 work with tuple-specified builders, which are deprecated but not
4209 yet invalid, so the check is disabled for now.
4210 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4211 routine, do the add/changed/removed dance with them like we do
4213 (BuildMaster.loadConfig_Sources): move source-config into a
4214 separate routine too
4216 * buildbot/status/builder.py (Status.getSlave): get the
4217 SlaveStatus object from the BotPerspective, not the BotMaster.
4219 * buildbot/test/test_run.py: bunch of new tests for losing the
4220 buildslave at various points in the build, handling a slave that
4221 connects multiple times, and making sure we can interrupt a
4224 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4225 something other than 'Bot' for the Bot object, to make certain
4226 test cases easier to write.
4227 (BuildSlave.waitUntilDisconnected): utility method for testing
4229 2004-11-30 Brian Warner <warner@lothar.com>
4231 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4233 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4234 argument, return a Deferred that always fires with True or False.
4235 I don't use an errback to indicate 'ping failed' so that callers
4236 are free to ignore the deferred without causing spurious errors in
4238 * buildbot/process/builder.py (BuilderControl.ping): implement it
4240 * buildbot/test/test_run.py (Status.testDisappear): test ping
4241 (Status.disappearSlave): fix it
4243 2004-11-30 Brian Warner <warner@lothar.com>
4245 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4246 (IBuilderControl): add .getBuild(num), only works for the current
4247 build, of course, although it might be interesting to offer
4248 something for builds in the .waiting or .interlocked state.
4250 * buildbot/process/base.py (Build): have .stopBuild just do the
4251 interrupt, then let the build die by itself.
4252 (BuildControl): add .stopBuild, and add a point-event named
4253 'interrupt' just after the build so status viewers can tell that
4255 (BuilderControl): add .getBuild
4257 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4258 stops when you kill it, good for testing
4259 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4260 contains the 'reason' text.
4262 * buildbot/status/html.py: Add Stop Build button, if the build can
4263 still be stopped. Send a Redirect (to the top page) one second
4264 later, hopefully long enough for the interrupt to have an effect.
4265 Move make_row() up to top-level to share it between Stop Build and
4268 * buildbot/slave/commands.py: only kill the child process once
4270 * buildbot/test/test_run.py: add testInterrupt
4272 2004-11-29 Brian Warner <warner@lothar.com>
4274 * buildbot/process/base.py: Refactor command interruption. The
4275 Build is now responsible for noticing that the slave has gone
4276 away: Build.lostRemote() interrupts the current step and makes
4277 sure that no further ones will be started.
4279 * buildbot/process/builder.py: When the initial remote_startBuild
4280 message fails, log it: this usually indicates that the slave has
4281 gone away, but we don't really start paying attention until they
4282 fail to respond to the first step's command.
4284 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4285 slave disconnect. Now sports a new interrupt() method. Error
4286 handling was simplified a lot by chaining deferreds, so
4287 remoteFailed/remoteComplete were merged into a single
4288 remoteComplete method (which can now get a Failure object).
4289 Likewise failed/finished were merged into just _finished.
4290 (BuildStep): Add interrupt(why) method, and if why is a
4291 ConnectionLost Failure then the step is failed with some useful
4294 * buildbot/slave/bot.py: stop the current command when the remote
4295 Step reference is lost, and when the slave is shut down.
4296 (Bot): make it a MultiService, so it can have children. Use
4297 stopService to tell when the slave is shutting down.
4298 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4299 remote_interruptCommand (which asks the current SlaveCommand to
4300 stop but allows it to keep emitting status messages), and
4301 stopCommand (which tells it to shut up and die).
4303 * buildbot/slave/commands.py: make commands interruptible
4304 (ShellCommand.kill): factor out os.kill logic
4305 (Command): factor out setup()
4306 (Command.sendStatus): don't send status if .running is false, this
4307 happens when the command has been halted.
4308 (Command.interrupt): new method, used to tell the command to die
4309 (SlaveShellCommand): implement .interrupt
4310 (DummyCommand): implement .interrupt
4311 (SourceBase, etc): factor out setup(), don't continue substeps if
4314 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4315 so they can be called after finishing
4317 * buildbot/test/test_run.py: new tests for disconnect behavior,
4318 refactor slave-shutdown routines, add different kinds of
4321 2004-11-27 Brian Warner <warner@lothar.com>
4323 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4324 method to express ETA time like "2m45s" instead of "165 seconds"
4326 2004-11-24 Brian Warner <warner@lothar.com>
4328 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4329 archive after the test completes, to avoid cluttering the user's
4330 'tla archives' listing with a bogus entry. Arch doesn't happen to
4331 provide any way to override the use of ~/.arch-params/, so there
4332 isn't a convenient way to avoid touching the setup of the user who
4334 (VC_HTTP.testArchHTTP): same
4336 2004-11-23 Brian Warner <warner@lothar.com>
4338 * buildbot/status/html.py (TextLog): split render() up into
4339 render_HEAD and render_GET. Use a Producer when sending log
4340 chunks, to reduce memory requirements and avoid sending huge
4341 non-Banana-able strings over web.distrib connections. Requires
4342 peeking under the covers of IStatusLog.
4343 (TextLog.resumeProducing): fix the "as text" link, handle client
4344 disconnects that occur while we're still sending old chunks.
4346 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4347 use defer.succeed, not the non-existent defer.success
4348 (LogFile.waitUntilFinished): same
4349 (LogFile.subscribe): don't add watchers to a finished logfile
4351 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4354 2004-11-23 Brian Warner <warner@lothar.com>
4356 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4358 2004-11-23 Brian Warner <warner@lothar.com>
4360 * NEWS: update for the 0.6.1 release
4361 * MANIFEST.in: add new files
4363 * README (INSTALLATION): explain how to enable the extra VC tests
4365 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4366 level to, so old pickled builds can be displayed ok
4368 2004-11-22 Brian Warner <warner@lothar.com>
4370 * NEWS: summarize updates since last release
4372 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4373 Yoz Grahame. Closes SF#1050138.
4375 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4378 * buildbot/process/step_twisted.py (Trial): update docs a bit
4380 * docs/factories.xhtml: fix Trial factory docs to match reality.
4383 * buildbot/process/factory.py (Trial.__init__): add args for
4384 randomly= and recurse=, making them available to instantiators
4385 instead of only to subclassers. Closes: SF#1049759.
4387 2004-11-15 Brian Warner <warner@lothar.com>
4389 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4390 try to teach the Quick factory to use multiple versions of python
4392 2004-11-12 Brian Warner <warner@lothar.com>
4394 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4395 safer w32-compatible approach, and only use it on windows
4396 (BuildStatus.saveYourself): same
4398 2004-11-11 Brian Warner <warner@lothar.com>
4400 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4401 it: one string merge per chunk. There are now separate .entries
4402 and .runEntries lists: when enumerating over all chunks, make sure
4404 * buildbot/test/test_status.py (Log): more tests
4406 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4407 chunks together, up to 10kb per chunk. This ought to cut down on
4408 the CPU-burning overhead of large log files. Thanks to Alexander
4409 Staubo for spotting the problem.
4410 * buildbot/test/test_status.py (Log): tests for same
4412 2004-11-10 Brian Warner <warner@lothar.com>
4414 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4415 header to outbound mail
4416 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4418 2004-11-08 Brian Warner <warner@lothar.com>
4420 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4421 can't do os.rename() onto an existing file, so catch the exception
4422 and unlink the target file first. This introduces a slight window
4423 where the existing file could be lost, but the main failure case
4424 (disk full) should still be handled safely.
4425 (BuildStatus.saveYourself): same
4427 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4428 separator character instead of os.sep, because the filenames being
4429 split here are coming from the VC system, which can have a
4430 different pathname convention than the local host. This should
4431 help a buildmaster running on windows that uses a CVS repository
4432 which runs under unix.
4433 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4435 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4436 when there are no test failures to be parsed
4438 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4439 instead of the unix-specific os.system("cp"), thanks to Elliot
4440 Murphy for this and the other buildbot-vs-windows catches.
4441 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4443 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4444 echo the command as it is run
4446 * setup.py: install sample.mk too, not just sample.cfg
4447 (scripts): install contrib/windows/buildbot.bat on windows
4449 2004-11-07 Brian Warner <warner@lothar.com>
4451 * buildbot/process/builder.py (Builder._detached): clear the
4452 self.currentBuild reference, otherwise the next build will be
4453 skipped because we think the Builder is already in use.
4455 * docs/examples/twisted_master.cfg: update to match current usage
4456 on the Twisted buildbot
4458 2004-10-29 Brian Warner <warner@lothar.com>
4460 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4462 2004-10-28 Brian Warner <warner@lothar.com>
4464 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4465 have separate doVCUpdate/doVCFull methods. Catch an update failure
4466 and respond by clobbering the source directory and re-trying. This
4467 will handle local changes (like replacing a file with a directory)
4468 that will cause CVS and SVN updates to fail.
4469 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4471 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4474 2004-10-19 Brian Warner <warner@lothar.com>
4476 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4478 * buildbot/status/html.py (StatusResourceTestResults): display any
4479 TestResults that the Build might have
4480 (StatusResourceTestResult): and the logs for each TestResult
4481 (StatusResourceBuild): add link from the per-build page
4483 2004-10-15 Brian Warner <warner@lothar.com>
4485 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4486 the 'problems' portion of stdout, add TestResults to our build
4487 * buildbot/test/test_twisted.py (Parse.testParse): test it
4489 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4490 to retrieve a dict of accumulated test results
4491 (ITestResult): define what a single test result can do
4492 * buildbot/status/builder.py (TestResult): implement ITestResult
4493 (BuildStatus.getTestResults): retrieve dict of TestResults
4494 (BuildStatus.addTestResult): add TestResults
4495 * buildbot/test/test_status.py (Results.testAddResults): test it
4497 2004-10-14 Brian Warner <warner@lothar.com>
4499 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4500 instead of os.system("rm -rf") for win32 portability
4502 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4503 SignalMixin instead of starting/stopping the reactor, which is
4504 likely to cause problems with other tests
4506 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4507 self.copyComplete() call. Yoz Grahame makes the catch.
4509 * contrib/windows/buildbot.bat: helper script to deal with path
4510 issues. Thanks to Yoz Grahame.
4512 * buildbot/master.py (BuildMaster.startService): don't register a
4513 SIGHUP handler if the signal module has no SIGHUP attribute.
4514 Apparently win32 does this.
4516 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4518 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4519 test if the reactor can't offer UNIX sockets
4521 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4522 error introduced in the last commit. We really need that
4525 2004-10-12 Brian Warner <warner@lothar.com>
4527 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4528 when describing a maildir source. Thanks to Stephen Davis.
4530 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4533 * buildbot/scripts/runner.py (createMaster): install Makefile too
4534 (start): add --no_save to 'start' command
4535 * buildbot/scripts/sample.mk: simple convenience Makefile with
4536 start/stop/reload targets
4538 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4541 2004-09-30 Brian Warner <warner@lothar.com>
4543 * setup.py: Releasing buildbot-0.6.0
4545 2004-09-30 Brian Warner <warner@lothar.com>
4547 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4548 test_trial.py from the source tarball until support is complete.
4550 * NEWS: update for 0.6.0 release
4551 * buildbot/__init__.py (version): same
4554 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4555 'source' command to tell users where to get the Buildbot source
4557 * docs/examples/*.cfg: update to modern standards
4559 * NEWS: update for release
4561 * buildbot/scripts/runner.py (createMaster): remove the
4562 -shutdown.tap stuff now that it isn't necessary
4564 (start): launch buildbot.tap, not buildbot-shutdown.tap
4567 * buildbot/status/mail.py (Domain): shorten class name
4568 (MailNotifier): if lookup= is a string, pass it to Domain()
4569 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4570 (Mail.testBuild2): test the string-to-Domain shortcut
4571 (Mail.testMail): fix test
4574 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4577 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4578 more attributes on load
4579 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4580 to accomodate the whole waterfall page at once, and the thrashing
4581 results in a lot of unnecessary loads
4582 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4583 (BuilderStatus.saveYourself): same
4584 (BuilderStatus.eventGenerator): stop generating on the first missing
4585 build. We assume that saved builds are deleted oldest-first.
4586 (BuildStepStatus.__getstate__): .progress might not exist
4588 * buildbot/changes/changes.py (ChangeMaster): make it
4589 serializable, in $masterdir/changes.pck
4590 (ChangeMaster.stopService): save on shutdown
4591 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4592 * buildbot/test/test_config.py: load Changes before config file
4595 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4596 "Oh my god, you killed the command" header on a separate line
4598 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4599 skip over corrupted build pickles
4600 (BuilderStatus.getFullBuildByNumber): same
4601 (BuilderStatus.eventGenerator): skip over unavailable builds
4602 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4603 do an atomic rename. This prevents a corrupted pickle when some
4604 internal serialization error occurs.
4605 (BuilderStatus.saveYourself): same
4607 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4608 the timeout for shell commands, it got lost somehow
4610 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4611 run out of build steps, return the rest of the builder events
4613 * buildbot/interfaces.py (IBuilderControl.ping): add method
4615 * buildbot/process/builder.py (BuilderControl.ping): move
4616 slave-ping to BuilderControl, and fix the failure case in the
4617 process (Event.finish() is the verb, Event.finished is the noun).
4619 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4620 through the BuilderControl instead of the BuilderStatus
4621 (EventBox): add adapter for builder.Event, allowing builder events to
4622 be displayed in the waterfall display
4624 * buildbot/master.py (BotMaster.stopService): add a 'master
4625 shutdown' event to the builder's log
4626 (BuildMaster.startService): and a 'master started' on startup
4628 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4629 builder events into the BuildStep event stream
4630 (Status.builderAdded): add a 'builder created' event
4633 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4634 command to announce the completion of a running build
4635 (IrcStatusBot.command_FORCE): announce when the build finishes
4637 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4638 don't evict unfinished builds from the cache: they must stay in
4639 the full-cache until their logfiles have stopped changing. Make
4640 sure the eviction loop terminates if an unfinished build was hit.
4641 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4642 This lets exceptions be dumped in an email status message. Really
4643 we need LogFiles which contain both text and HTML, instead of two
4645 (BuildStatus.__getstate__): handle self.finished=False
4646 (Status.builderAdded): if the pickle is corrupted, abandon the
4647 history and create a new BuilderStatus object.
4649 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4650 self.progress attribute, helped one test which doesn't fully set
4651 up the Build object.
4653 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4654 IStatusLog methods into an Interface that is implemented by "stub"
4655 logs, for which all the actual text chunks are on disk (in the
4656 pickled Build instance). To show the log contents, you must first
4657 adapt the stub log to a full IStatusLog object.
4659 * buildbot/status/builder.py (LogFileStub): create separate stub
4660 log objects, which can be upgraded to a real one if necessary.
4661 (LogFile): make them persistable, and let them stubify themselves
4663 (BuildStepStatus): same
4665 (BuildStatus.saveYourself): save the whole build out to disk
4666 (BuilderStatus): make it persistable
4667 (BuilderStatus.saveYourself): save the builder to disk
4668 (BuilderStatus.addFullBuildToCache): implement two caches which
4669 hold Build objects: a small one which holds full Builds, and a
4670 larger one which holds "stubbed" Builds (ones with their LogFiles
4671 turned into LogFileStubs). This reduces memory usage by the
4672 buildmaster by not keeping more than a few (default is 2) whole
4673 build logs in RAM all the time.
4674 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4676 (BuilderStatus.eventGenerator): rewrite since .builds went away
4677 (BuilderStatus.buildStarted): remove the .builds array. Add the
4678 build to the "full" cache when it starts.
4679 (BuilderStatus._buildFinished): save the build to disk when it
4681 (Status): give it a basedir (same as the BuildMaster's basedir)
4682 where the builder pickles can be saved
4683 (Status.builderAdded): create the BuilderStatus ourselves, by
4684 loading a pickle from disk (or creating a new instance if there
4685 was none on disk). Return the BuilderStatus so the master can glue
4686 it into the new Builder object.
4688 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4689 all BuilderStatuses to save themselves out to disk. This is in
4690 lieu of saving anything important in the main Application pickle
4691 (the -shutdown.tap file).
4692 (BuildMaster.__init__): give Status() a basedir for its files
4693 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4694 to get the BuilderStatus, then give it to the Builder (instead of
4695 doing it the other way around). It's ok if the status announces
4696 the new Builder before it's really ready, as the outside world can
4697 only see the BuilderStatus object anyway (and it is ready before
4698 builderAdded returns). Use the builder's "builddir" (which
4699 normally specifies where the slave will run the builder) as the
4700 master's basedir (for saving serialized builds).
4702 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4703 coerce the logfile to IStatusLog before trying to get the text
4704 chunks out of it. This will pull the full (non-stubified) Build in
4705 from disk if necessary.
4706 (TextLog): fix the adapter registration
4708 * buildbot/test/test_control.py (Force.setUp): create the basedir
4709 * buildbot/test/test_web.py: same
4710 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4711 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4712 * buildbot/test/test_run.py (Run.testMaster): same
4713 (Status.setUp): same
4715 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4717 * buildbot/status/html.py (Waterfall.__init__): store actual
4718 allowForce flag passed in rather than using True for everyone;
4719 make sure setting it to False doesn't cause a NameError
4721 (StatusResourceBuilder.__init__) add the builder name to the page
4723 (StatusResourceBuilder.body) move HTML generation for a name/value
4724 row into a helper method (StatusResourceBuilder.make_row); only
4725 generate the "Force Build" form if allowForce was True and the
4726 slave is connected. Use class attributes in the generated HTML to
4727 spread a little CSS-joy.
4729 2004-09-28 Brian Warner <warner@lothar.com>
4731 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4732 warning-scanner to not ignore things like
4733 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4735 * buildbot/status/html.py (StatusResource.control): add some
4736 class-level values for .control in an attempt to make upgrading
4739 * buildbot/util.py (ComparableMixin): survive missing attributes,
4740 such as when a class is modified and we're comparing old instances
4743 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4744 failure handling, remove a redundant try/except block. Don't
4745 return the full traceback to the IRC channel.
4746 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4747 error messages. Get ETA properly.
4749 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4750 the reason, since (at least) IRC message will have <> in them.
4751 (StatusResourceBuilder.__init__): take an IBuilderControl
4752 (StatusResourceBuilder.force): use the IBuilderControl we get in
4753 the constructor instead of trying to make our own. Catch the
4754 new exceptions and ignore them for now (until we make an
4755 intermediate web page where we could show the error message)
4756 (StatusResource): create with an IControl, use it to give an
4757 IBuilderControl to all children
4758 (Waterfall): take an allowForce= option, pass an IControl object
4759 to StatusResource if it is True
4761 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4763 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4764 catch new exceptions and return string forms
4766 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4767 * buildbot/process/builder.py (Builder.forceBuild): raise them
4768 * buildbot/test/test_control.py (Force.testNoSlave): new test
4769 (Force.testBuilderInUse): same
4772 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4774 * buildbot/test/test_run.py: use IControl
4775 * buildbot/test/test_vc.py: same
4777 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4778 to use IControl. Still offline.
4779 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4781 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4782 who=None so periodic builds don't send out status mail
4783 (Builder.forceBuild): include reason in the log message
4784 (BuilderControl.forceBuild): rename 'name' to 'who'
4786 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4787 'who' parameter, but make it None by default so builds forced by
4788 slave admins don't cause status mail to be sent to anybody
4789 (BotMaster.forceBuild): same. this method is deprecated.
4790 (DebugPerspective.perspective_forceBuild): same, use IControl.
4791 (DebugPerspective.perspective_fakeChange): use IControl..
4792 (Dispatcher.requestAvatar): .. so don't set .changemaster
4794 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4795 parameter to avoid confusion with the name of the builder
4798 * buildbot/status/mail.py: refine comment about needing 2.3
4800 * buildbot/status/html.py: move all imports to the top
4802 * buildbot/test/test_control.py: test new interfaces
4803 * buildbot/test/test_run.py (Status): handle new interfaces
4804 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4806 * buildbot/process/base.py (BuildControl): implement IBuildControl
4807 and its lonely getStatus() method
4809 * buildbot/process/builder.py (BuilderControl): implement
4810 IBuilderControl, obtained by adapting the Builder instance
4811 (Builder.startBuild): return a BuilderControl instead of a
4812 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4813 accomplish the same thing.
4815 * buildbot/master.py: move all import statements to the top
4816 (Control): implement IControl, obtained by adapting the
4817 BuildMaster instance.
4819 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4820 IBuildControl. These are used to force builds. Eventually they
4821 will provide ways to reconfigure the Builders, pause or abandon a
4822 Build, and perhaps control the BuildMaster itself.
4824 2004-09-26 Brian Warner <warner@lothar.com>
4826 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4827 ends up comparing us against something without a .__class__
4829 2004-09-24 Brian Warner <warner@lothar.com>
4831 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4834 * Makefile: add 'deb-snapshot' target, to create a timestamped
4837 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4839 2004-09-23 Brian Warner <warner@lothar.com>
4841 * buildbot/__init__.py (version): move version string here
4842 * setup.py: get version string from buildbot.version
4843 * buildbot/status/html.py (WaterfallStatusResource.body): add
4844 buildbot version to the page footer
4845 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4848 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4849 slaves, let the second know where the first one is coming from
4850 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4851 see our exceptions. It would be nice if there were a way to just
4852 send them the exception type and value, not the full traceback.
4855 * buildbot/status/mail.py (MailNotifier): add a new argument
4856 sendToInterestedUsers=, which can be set to False to disable the
4857 usual send-to-blamelist behavior.
4858 (top): handle python-2.2 which has no email.MIMEMultipart
4859 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4860 (MailNotifier.disownServiceParent): unsubscribe on removal
4862 * buildbot/test/test_status.py (Mail.testBuild2): test it
4865 * buildbot/status/progress.py (Expectations.wavg): tolerate
4866 current=None, which happens when steps start failing badly
4867 * buildbot/test/test_status.py (Progress.testWavg): test for it
4869 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4870 doesn't understand args['revision'], emit a warning instead of
4871 bailing completely. Updating to -rHEAD is probably close enough.
4873 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4875 * buildbot/test/test_status.py: at least import bb.status.client
4876 even if we don't have any test coverage for it yet
4878 * contrib/svn_buildbot.py: don't require python2.3
4879 (main): wait, do require it (for sets.py), but explain how to
4880 make it work under python2.2
4882 2004-09-23 Brian Warner <warner@lothar.com>
4884 * contrib/svn_buildbot.py: include the revision number in the Change
4886 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4887 using util.now() because FreshCVS is a realtime service
4889 * buildbot/status/event.py: delete dead code
4890 * buildbot/process/step.py: don't import dead Event class
4891 * buildbot/process/step_twisted.py: same
4892 * buildbot/status/builder.py: same
4893 * buildbot/status/client.py: same
4895 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4897 * buildbot/changes/changes.py (Change): set .when from an __init__
4898 argument (which defaults to now()), rather than having
4899 ChangeMaster.addChange set it later.
4900 (ChangeMaster.addChange): same
4902 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4903 (parseSyncmail): same. Just use util.now() for now.
4904 (parseBonsaiMail): parse the timestamp field for when=
4906 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4907 instead of setting .when after the fact
4911 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4912 results when the target project uses retrial. Still under
4914 * buildbot/test/test_trial.py: same
4916 2004-09-21 Brian Warner <warner@lothar.com>
4918 * buildbot/status/mail.py (MailNotifier.__init__): include
4919 success/warnings/failure in the Subject line
4920 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4921 use step.logname for the addLogs=True attachment filenames
4922 * buildbot/test/test_status.py (Mail): test Subject lines
4923 (Mail.testLogs): test attachment filenames
4925 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4926 accept a 'who' argument from the debug tool
4927 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4928 * contrib/debug.glade: add text box to set 'who'
4930 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4931 .getBuilderName with .getBuilder().getName(), more flexible
4932 (IStatusLog.getName): logs have short names, but you can prefix
4933 them with log.getStep().getName() to make them more useful
4934 * buildbot/status/builder.py: same
4935 * buildbot/status/client.py: same
4936 * buildbot/status/html.py: same
4937 * buildbot/test/test_run.py (Status.testSlave): same
4938 * buildbot/process/step.py: tweak logfile names
4940 * buildbot/status/mail.py (MailNotifier): add lookup, change
4941 argument to extraRecipients. The notifier is now aimed at sending
4942 mail to the people involved in a particular build, with additional
4943 constant recipients as a secondary function.
4945 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4946 including slow-lookup and failing-lookup. Make sure the blamelist
4947 members are included.
4949 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4950 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4951 (IBuildStatus.getInterestedUsers): new method
4952 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4953 * buildbot/status/client.py (remote_getResponsibleUsers): same
4954 * buildbot/status/html.py (StatusResourceBuild.body): same
4955 * buildbot/test/test_run.py (Status.testSlave): same
4957 2004-09-20 Brian Warner <warner@lothar.com>
4959 * docs/users.xhtml: update concepts
4961 * Makefile: add a convenience makefile, for things like 'make
4962 test'. It is not included in the source tarball.
4964 2004-09-16 Brian Warner <warner@lothar.com>
4966 * NEWS: mention /usr/bin/buildbot, debian/*
4968 * debian/*: add preliminary debian packaging. Many thanks to
4969 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4970 it considerably since it left their hands, I am responsible for
4971 all breakage that's resulted.
4973 * bin/buildbot: create a top-level 'buildbot' command, to be
4974 installed in /usr/bin/buildbot . For now it's just a simple
4975 frontend to mktap/twistd/kill, but eventually it will be the entry
4976 point to the 'try' command and also a status client. It is also
4977 intended to support the upcoming debian-packaging init.d scripts.
4978 * buildbot/scripts/runner.py: the real work is done here
4979 * buildbot/scripts/__init__.py: need this too
4980 * buildbot/scripts/sample.cfg: this is installed in new
4981 buildmaster directories
4982 * setup.py: install new stuff
4984 2004-09-15 Brian Warner <warner@lothar.com>
4986 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4987 'file:' schema (the version shipped with OS-X was built without the
4989 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4990 updates the log-timestamp, to make sure it isn't still running after
4993 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4994 values to the config file.
4995 * docs/examples/hello.cfg: add examples
4996 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4997 * buildbot/status/builder.py (Status.getProjectURL): implement them
4998 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4999 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5000 * buildbot/status/html.py (WaterfallStatusResource): display them
5003 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5004 certain error cases don't suffer a secondary exception.
5005 (top): Skip tests if the corresponding VC tool is not installed.
5007 * buildbot/process/factory.py (Trial): introduce separate
5008 'buildpython' and 'trialpython' lists, since trialpython=[] is
5009 what you want to invoke /usr/bin/python, whereas ./setup.py is
5010 less likely to be executable. Add env= parameter to pass options
5011 to test cases (which is how I usually write tests, I don't know if
5012 anyone else does it this way).
5014 * buildbot/process/step_twisted.py (Trial): handle python=None.
5015 Require 'testpath' be a string, not a list. Fix tests= typo.
5016 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5018 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5019 way to deal with the possibility of removing the disconnect notify
5021 (CVS): add a 'login' parameter to give a password to 'cvs login',
5022 commonly used with pserver methods (where pw="" or pw="guest")
5024 * buildbot/slave/commands.py (SourceBase): move common args
5025 extraction and setup() to __init__, so everything is ready by the
5026 time setup() is called
5027 (CVS.start): call 'cvs login' if a password was supplied
5028 (ShellCommand): special-case PYTHONPATH: prepend the master's
5029 value to any existing slave-local value.
5031 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5032 don't have a remote, mark the builder as Offline. This whole
5033 function should probably go away and be replaced by individual
5035 (Builder.buildFinished): return the results to the build-finished
5036 deferred callback, helps with testing
5038 2004-09-14 Brian Warner <warner@lothar.com>
5040 * buildbot/test/test_vc.py: put all the repositories needed to run
5041 the complete tests into a single small (1.3MB) tarball, so I can
5042 make that tarball available on the buildbot web site. Test HTTP
5043 access (for Arch and Darcs) by spawning a temporary web server
5044 while the test runs.
5046 * docs/users.xhtml: new document, describe Buildbot's limited
5047 understanding of different human users
5049 * buildbot/test/test_vc.py: rearrange test cases a bit
5051 * buildbot/process/step_twisted.py (Trial): handle testpath=
5052 * buildbot/process/factory.py (Trial): update to use step.Trial
5054 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5056 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5057 the overall build text (which gives you 'failed 2 tests' rather
5059 (BuildStepStatus.text2): default to [], not None
5061 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5064 2004-09-12 Brian Warner <warner@lothar.com>
5066 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5067 log the whole exception if it's just an AttributeError (old slave)
5069 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5070 so (e.g.) sub-commands can be run in the right directory.
5071 (ShellCommand.start): accept an optional errorMessage= argument
5072 to make life easier for SVN.start
5073 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5075 (ShellCommand.start): move ['dir'] compatibility hack..
5076 (RemoteShellCommand.start): .. to here so everyone can use it
5078 * buildbot/process/step_twisted.py (Trial): use .workdir
5080 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5081 text displayed when debuild fails completely
5082 (Trial): snarf _trial_temp/test.log from the slave and display it
5084 2004-09-11 Brian Warner <warner@lothar.com>
5086 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5088 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5089 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5091 * buildbot/process/step.py (ShellCommand): call .createSummary
5092 before .evaluateCommand instead of the other way around. This
5093 makes it slightly easier to count warnings and then use that to
5094 set results=WARNINGS
5095 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5097 * buildbot/process/base.py (Build.buildFinished): update status
5098 before doing progress. It's embarrassing for the build to be stuck
5099 in the "building" state when an exceptions occurs elsewhere..
5101 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5102 python2.2 doesn't have 'sum'
5104 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5105 to prevent clients from accidentally sorting it
5107 * buildbot/master.py (Manhole): add username/password
5108 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5109 c['manholePort'], deprecate old usage
5110 * docs/config.xhtml: document c['manhole']
5111 * docs/examples/hello.cfg: show example of using a Manhole
5114 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5115 pretend the slave is up to date
5117 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5118 the module, overlaps with 'log', the local variable
5120 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5122 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5123 new method to let Steps find out the version of their
5124 corresponding SlaveCommand.
5125 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5126 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5127 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5129 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5130 (Arch.startVC): same
5131 (P4Sync.startVC): same
5133 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5134 Deferred so we can catch errors in remote_startCommand
5135 (RemoteShellCommand.start): same
5137 * docs/examples/twisted_master.cfg: update sample config file
5139 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5140 after connectionMade() is called, not before. Close stdin at that
5143 * buildbot/process/process_twisted.py: update to use Trial, clean
5144 up argument passing (move to argv arrays instead of string
5147 * buildbot/process/step_twisted.py (Trial): new step to replace
5148 RunUnitTests, usable by any trial-using project (not just
5149 Twisted). Arguments have changed, see the docstring for details.
5151 * buildbot/process/base.py (Build.startBuild): this now returns a
5152 Deferred. Exceptions that occur during setupBuild are now
5153 caught better and lead to fewer build_status weirdnesses, like
5154 finishing a build that was never started.
5155 (Build.buildFinished): fire the Deferred instead of calling
5156 builder.buildFinished directly. The callback argument is this
5157 Build, everything else can be extracted from it, including the
5158 new build.results attribute.
5159 * buildbot/process/builder.py (Builder.startBuild): same
5160 (Builder.buildFinished): same, extract results from build
5162 * buildbot/process/step.py (ShellCommands): remove dead code
5164 2004-09-08 Brian Warner <warner@lothar.com>
5166 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5167 doesn't try to use the leftover patched workdir
5168 (SourceStamp): test source-stamp computation for CVS and SVN
5170 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5171 patched workdir ('touch .buildbot-patched') so we don't try to
5173 (SourceBase.start): add ['revision'] for all Source steps
5174 (CVS): change args: use ['branch'] for -r, remove ['files']
5175 (CVS.buildVC): fix revision/branch stuff
5176 (SVN): add revision stuff
5178 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5179 kwargs (except 'workdir') to avoid silent spelling errors
5180 (ShellCommand.__init__): same
5181 (Source): new base class for CVS/SVN/etc. Factor out everything
5182 common, add revision computation (perform the checkout with a -D
5183 DATE or -r REVISION that gets exactly the sources described by the
5184 last Change), overridable with step.alwaysUseLatest. Add patch
5185 handling (build.getSourceStamp can trigger the use of a base
5186 revision and a patch).
5187 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5188 * docs/steps.xhtml: update docs
5189 * docs/source.xhtml: mention .checkoutDelay
5190 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5192 * buildbot/process/base.py (Build.setSourceStamp): add a
5193 .sourceStamp attribute to each Build. If set, this indicates that
5194 the build should be done with something other than the most
5195 recent source tree. This will be used to implement "try" builds.
5196 (Build.allChanges): new support method
5197 (Build.lastChangeTime): remove, functionality moved to Source steps
5198 (Build.setupBuild): copy the Step args before adding ['workdir'],
5199 to avoid modifying the BuildFactory (and thus triggering spurious
5203 * buildbot/status/html.py: rename s/commits/changes/
5204 (StatusResourceChanges): same
5205 (CommitBox.getBox): same, update URL
5206 (WaterfallStatusResource): same
5207 (StatusResource.getChild): same
5209 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5210 * contrib/debug.glade: add optional 'revision' to the fakeChange
5212 * buildbot/changes/changes.py (html_tmpl): display .revision
5213 (ChangeMaster.addChange): note .revision in log
5214 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5215 accept a ['revision'] attribute
5217 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5219 * buildbot/master.py (BotMaster.getPerspective): update the
5220 .connected flag in SlaveStatus when it connects
5221 (BotMaster.detach): and when it disconnects
5222 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5223 (BuildMaster.loadConfig_Builders): walk old list correctly
5225 * buildbot/test/test_config.py: fix prefix= usage
5227 2004-09-06 Brian Warner <warner@lothar.com>
5231 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5232 poll a P4 depot looking for recent changes. Thanks to Dave
5233 Peticolas for the contribution. Probably needs some testing after
5236 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5237 requires manual client setup for each buildslave. Rather
5238 experimental. Thanks again to Dave Peticolas.
5239 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5241 * buildbot/changes/changes.py (Change): add a .revision attribute,
5242 which will eventually be used to generate source-stamp values.
5244 * buildbot/process/step.py (RemoteCommand.start): use
5245 notifyOnDisconnect to notice when we lose the slave, then treat it
5246 like an exception. This allows LogFiles to be closed and the build
5247 to be wrapped up normally. Be sure to remove the disconnect
5248 notification when the step completes so we don't accumulate a
5249 bazillion such notifications which will fire weeks later (when the
5250 slave finally disconnects normally). Fixes SF#915807, thanks to
5251 spiv (Andrew Bennetts) for the report.
5252 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5253 really isn't Logged- specific
5254 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5255 header, since it's almost always going to be appended to an
5257 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5258 update test to handle use of notifyOnDisconnect
5260 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5261 don't clear .ETA and .currentBuild when going offline, let the
5262 current build clean up after itself
5264 * buildbot/process/builder.py (Builder.detached): wait a moment
5265 before doing things like stopping the current build, because the
5266 current step will probably notice the disconnect and cleanup the
5268 * buildbot/test/test_run.py (Status.tearDown): update test to
5269 handle asynchronous build-detachment
5271 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5273 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5274 hush a debug message
5276 2004-09-05 Brian Warner <warner@lothar.com>
5278 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5279 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5280 kernels do this: the fcntl module has the F_NOTIFY constant, but
5281 the kernel itself doesn't support the operation. Thanks to Olly
5282 Betts for spotting the problem.
5284 * buildbot/process/step.py (Darcs): new source-checkout command
5285 (Arch): new source-checkout command
5286 (todo_P4): fix constructor syntax, still just a placeholder
5287 * buildbot/test/test_vc.py (VC.testDarcs): test it
5288 (VC.testDarcsHTTP): same, via localhost HTTP
5290 (VC.testArchHTTP): same
5291 * NEWS: mention new features
5293 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5294 which tells the step to stash stdout text locally (in .stdout).
5295 Slave-side Commands can use this to make decisions based upon the
5296 output of the the ShellCommand (not just the exit code).
5297 (Darcs): New source-checkout command
5298 (Arch): New source-checkout command, uses .keepStdout in one place
5299 where it needs to discover the archive's default name.
5301 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5302 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5303 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5305 * buildbot/process/step.py (ShellCommand.describe): add an
5306 alternate .descriptionDone attribute which provides descriptive
5307 text when the step is complete. .description can be ["compiling"],
5308 for use while the step is running, then .descriptionDone can be
5309 ["compile"], used alone when the step succeeds or with "failed" when
5310 it does not. Updated other steps to use the new text.
5311 * buildbot/process/step_twisted.py: same
5312 * buildbot/test/test_run.py: update tests to match
5314 2004-08-30 Brian Warner <warner@lothar.com>
5316 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5317 (CVS.__init__): send 'patch' argument to slave
5318 (CVS.start): don't create the LoggedRemoteCommand until start(),
5319 so we can catch a .patch added after __init__
5320 (SVN.__init__): add 'patch' to SVN too
5323 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5324 argument, to let commands push data into the process' stdin pipe.
5325 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5326 is in use, since closing a PTY doesn't really affect the process
5327 in the right way (in particular, I couldn't run /usr/bin/patch
5329 (SourceBase.doPatch): handle 'patch' argument
5331 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5334 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5335 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5337 * buildbot/master.py (BotPerspective.got_commands): get command
5338 versions from slave, give to each builder
5339 * buildbot/process/builder.py (Builder.attached): stash slave
5340 command versions in .remoteCommands
5342 * docs/steps.xhtml: bring docs in-line with reality
5344 * buildbot/process/step.py (CVS.__init__): more brutal
5345 compatibility code removal
5346 (SVN.__init__): same
5348 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5349 (SlaveShellCommand.start): require ['workdir'] argument, remove
5350 the ['dir'] fallback (compatibility will come later)
5351 (SourceBase): update docs
5352 (SourceBase.start): remove ['directory'] fallback
5355 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5356 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5357 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5359 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5360 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5361 code.. I will figure out 0.5.0-compatibility hooks later)
5363 2004-08-30 Brian Warner <warner@lothar.com>
5365 * buildbot/process/process_twisted.py: rewrite in terms of new
5366 BuildFactory base class. It got significantly shorter. Yay
5369 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5370 work with the new "self.build isn't nailed down until we call
5371 step.start()" scheme: specifically, __init__ is called before the
5372 build has decided on which Changes are going in, so we don't scan
5373 build.allFiles() for .xhtml files until start()
5374 (HLint.commandComplete): use getText(), not getStdout()
5375 (RunUnitTests.start): same: don't use .build until start()
5376 (RunUnitTests.describe): oops, don't report (None) when using
5378 (RunUnitTests.commandComplete): use getText()
5379 (RunUnitTests.createSummary): same
5380 (BuildDebs.commandComplete): same
5382 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5383 set args['command'] until start(), since our BuildStep is allowed
5384 to change their mind up until that point
5385 (TreeSize.commandComplete): use getText(), not getStdout()
5387 * docs/examples/twisted_master.cfg: update to current standards
5389 * docs/factories.xhtml: update
5390 * buildbot/process/factory.py: implement all the common factories
5391 described in the docs. The Trial factory doesn't work yet, and
5392 I've probably broken all the process_twisted.py factories in the
5393 process. There are compatibility classes left in for things like
5394 the old BasicBuildFactory, but subclasses of them are unlikely to
5396 * docs/examples/glib_master.cfg: use new BuildFactories
5397 * docs/examples/hello.cfg: same
5399 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5400 explicit 'workdir' args
5402 * buildbot/process/base.py (BuildFactory): move factories to ..
5403 * buildbot/process/factory.py (BuildFactory): .. here
5404 * buildbot/process/process_twisted.py: handle move
5405 * buildbot/test/test_config.py: same
5406 * buildbot/test/test_run.py: same
5407 * buildbot/test/test_steps.py: same
5408 * buildbot/test/test_vc.py: same
5409 * docs/factories.xhtml: same
5411 * NEWS: mention config changes that require updating master.cfg
5413 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5414 argument to all steps that weren't given one already, pointing at
5415 the "build/" directory.
5417 * docs/examples/hello.cfg: remove explicit 'workdir' args
5419 * docs/factories.xhtml: document standard BuildFactory clases,
5420 including a bunch which are have not yet been written
5422 2004-08-29 Brian Warner <warner@lothar.com>
5424 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5425 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5426 buildbot.status.builder so they aren't quite so internal
5427 * buildbot/process/base.py, buildbot/process/builder.py: same
5428 * buildbot/process/maxq.py, buildbot/process/step.py: same
5429 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5430 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5431 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5433 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5434 to handle new getLogs()-returns-list behavior
5435 (StatusResourceBuildStep.getChild): same
5436 (StepBox.getBox): same
5437 (WaterfallStatusResource.phase0): same
5439 * docs/source.xhtml: document how Buildbot uses version-control
5440 systems (output side: how we get source trees)
5441 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5442 systems (input side: how we learn about Changes)
5444 * buildbot/master.py (Manhole): use ComparableMixin
5445 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5446 * buildbot/changes/mail.py (MaildirSource): same
5447 * buildbot/status/client.py (PBListener): same
5448 * buildbot/status/html.py (Waterfall): same
5449 * buildbot/status/words.py (IRC): same
5451 * NEWS: start describing new features
5453 * buildbot/status/mail.py (MailNotifier): finish implementation.
5454 The message body is still a bit sparse.
5455 * buildbot/test/test_status.py (Mail): test it
5457 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5458 and __hash__ methods I wind up adding everywhere. Specifically
5459 intended to support the buildbot config-file update scheme where
5460 we compare, say, the old list of IStatusTargets against the new
5461 one and don't touch something which shows up on both lists.
5462 * buildbot/test/test_util.py (Compare): test case for it
5464 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5465 return a list instead of a dict
5466 (IBuildStepStatus.getLogs): same. The idea is that steps create
5467 logs with vaguely unique names (although their uniqueness is not
5468 guaranteed). Thus a compilation step should create its sole
5469 logfile with the name 'compile', and contribute it to the
5470 BuildStatus. If a step has two logfiles, try to create them with
5471 different names (like 'test.log' and 'test.summary'), and only
5472 contribute the important ones to the overall BuildStatus.
5473 * buildbot/status/builder.py (Event.getLogs): same
5474 (BuildStepStatus): fix default .text and .results
5475 (BuildStepStatus.addLog): switch to list-like .getLogs()
5476 (BuildStepStatus.stepFinished): same
5477 (BuildStatus.text): fix default .text
5478 (BuildStatus.getLogs): temporary hack to return all logs (from all
5479 child BuildStepStatus objects). Needs to be fixed to only report
5480 the significant ones (as contributed by the steps themselves)
5481 * buildbot/test/test_run.py: handle list-like .getLogs()
5482 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5484 2004-08-28 Brian Warner <warner@lothar.com>
5486 * buildbot/process/builder.py (Builder.attached): serialize the
5487 attachment process, so the attach-watcher isn't called until the
5488 slave is really available. Add detached watchers too, which makes
5491 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5493 * buildbot/test/test_swap.py: remove dead code
5495 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5496 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5497 sort of as if the command being run exited with a -1. There may
5498 still be some holes in this scheme.
5499 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5500 -r option appears before the module list
5501 * buildbot/process/step.py (CVS): add 'revision' argument
5503 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5504 when sending updates or stepComplete messages to the master, since
5505 we don't currently care whether they arrive or not. When we revamp
5506 the master/slave protocol to really resume interrupted builds,
5507 this will need revisiting.
5508 (lostRemote): remove spurious print
5510 * buildbot/master.py (BotPerspective.attached): serialize the
5511 new-builder interrogation process, to make testing easier
5512 (BotMaster.waitUntilBuilderDetached): convenience function
5514 * buildbot/status/builder.py (BuilderStatus): prune old builds
5515 (BuildStatus.pruneSteps): .. and steps
5516 (BuildStepStatus.pruneLogs): .. and logs
5517 (BuilderStatus.getBuild): handle missing builds
5518 * buildbot/status/html.py (StatusResourceBuild.body): display build
5519 status in the per-build page
5520 (BuildBox.getBox): color finished builds in the per-build box
5522 2004-08-27 Brian Warner <warner@lothar.com>
5524 * buildbot/status/mail.py (MailNotifier): new notification class,
5527 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5528 variants of a common base class which handles all the mode= logic
5530 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5532 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5534 2004-08-26 Brian Warner <warner@lothar.com>
5536 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5539 * buildbot/test/test_run.py: update to new Logfile interface, new
5540 buildbot.slave modules
5541 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5543 * MANIFEST.in: new sample config file
5544 * docs/examples/hello.cfg: same
5546 * buildbot/process/step_twisted.py: remove dead import
5548 * buildbot/process/step.py (RemoteCommand.run): catch errors
5550 (RemoteCommand.remote_update): ignore updates that arrive after
5552 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5553 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5554 the responsibilities of the subclass's methods
5555 (BuildStep.failed): catch errors during failure processing
5556 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5557 (CVS): move to a mode= argument (described in docstring), rather
5558 than the ungainly clobber=/export=/copydir= combination.
5559 (SVN): add mode= functionality to SVN too
5560 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5562 * buildbot/process/base.py (Build.startNextStep): catch errors
5563 during s.startStep()
5565 * buildbot/clients/base.py: update to new PB client interface.
5566 gtkPanes is still broken
5568 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5569 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5570 * setup.py: add buildbot.slave module
5571 * buildbot/bb_tap.py: handle move
5572 * buildbot/slave/registry.py: place to register commands, w/versions
5573 * buildbot/slave/bot.py: major simplifications
5574 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5575 instead of a fixed table. Eventually this will make the slave more
5576 extensible. Use 'start' method on the command, not .startCommand.
5577 Fix unsafeTracebacks handling (I think).
5578 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5579 helper class with a .start method that returns a Deferred.
5580 SlaveShellCommand is the form reached by the buildmaster. Commands
5581 which use multiple ShellCommands can just chain them as Deferreds,
5582 with some helper methods in Command (_abandonOnFailure and
5583 _checkAbandoned) to bail on rc!=0.
5584 (CVSCommand): prefer new mode= argument
5585 (SVNFetch): add mode= argument
5587 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5588 put a useful reason string on the build
5590 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5591 core functionality into an IStatusLog object
5592 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5593 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5594 (StatusResourceBuild.body): use proper accessor methods
5595 * buildbot/status/client.py (RemoteLog): PB-access goes here
5596 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5597 which delivers log contents too
5598 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5599 * buildbot/status/event.py: remove old Logfile completely
5601 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5602 subscription interface for IStatusLog subscriptions just like all
5603 other the status subscriptions
5604 (IStatusReceiver.logChunk): method called on subscribers
5606 2004-08-24 Brian Warner <warner@lothar.com>
5608 * buildbot/process/builder.py (Builder._pong): oops, ping response
5609 includes a result (the implicit None returned by remote_print).
5610 Accept it so the _pong method handles the response correctly.
5612 2004-08-06 Brian Warner <warner@lothar.com>
5614 * buildbot/test/test_config.py: update IRC, PBListener tests
5616 * buildbot/status/client.py (StatusClientPerspective): total
5617 rewrite to match new IStatus interfaces. New subscription scheme.
5618 There are still a few optimizations to make (sending down extra
5619 information with event messages so the client doesn't have to do a
5620 round trip). The logfile-retrieval code is probably still broken.
5621 Moved the PB service into its own port, you can no longer share a
5622 TCP socket between a PBListener and, say, the slaveport (this
5623 should be fixed eventually).
5624 * buildbot/clients/base.py (Client): revamp to match. still needs
5625 a lot of work, but basic event reporting works fine. gtkPanes is
5628 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5629 instance talks to a single irc server. Threw out all the old
5630 multi-server handling code. Still need to add back in
5631 builder-control (i.e. "force build")
5633 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5634 more random text to the as-yet-unreachable per-step page
5636 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5637 rename to stepETAUpdate
5638 (BuildStatus.subscribe): add build-wide ETA updates
5639 (BuilderStatus.getState): remove more cruft
5640 (BuilderStatus.getCurrentBuild): remove more cruft
5641 (BuilderStatus.buildStarted): really handle tuple-subscription
5642 * buildbot/test/test_run.py (Status.testSlave): handle the
5643 stepETAUpdate rename
5645 * buildbot/master.py (BuildMaster): don't add a default
5646 StatusClientService. Don't add a default IrcStatusFactory. Both
5647 are now added through c['status'] in the config file. c['irc'] is
5648 accepted for backwards compatibility, the only quirk is you cannot
5649 use c['irc'] to specify IRC servers on ports other than 6667.
5651 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5652 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5653 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5654 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5657 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5658 the buildmaster to re-read its config file
5661 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5662 find out the port our server is running on
5663 (WebTest.test_webPathname_port): same
5665 * buildbot/test/test_config.py (testWebPortnum): test it
5666 (testWebPathname): ditto
5668 * docs/config.xhtml: document new c['status'] configuration option
5670 * buildbot/status/html.py (Waterfall): new top-level class which
5671 can be added to c['status']. This creates the Site as well as the
5672 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5673 reachable as .parent, for everything.
5675 * buildbot/master.py (Manhole): make it a normal service Child
5676 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5677 webPathname. It will eventually replace c['irc'] and the implicit
5678 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5679 in as (deprecated) backward compatibility hooks for now.
5682 * buildbot/process/builder.py (Builder.buildFinished): don't
5683 inform out builder_status about a finished build, as it finds out
5684 through its child BuildStatus object
5686 * buildbot/status/html.py: extensive revamp. Use adapters to make
5687 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5688 have both starting and finishing times and adjust the waterfall
5689 display accordingly, using spacers if necessary. Use SlaveStatus
5690 to get buildslave info.
5691 (StatusResourceBuildStep): new just-one-step resource, used to get
5692 logfiles. No actual href to it yet.
5694 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5695 the time being, until I get the file-naming scheme right
5697 * buildbot/status/builder.py (Event): clean started/finished names
5698 (BuildStatus.isFinished): .finished is not None is the right test
5699 (BuildStatus.buildStarted): track started/finished times ourselves
5700 (BuilderStatus.getSlave): provide access to SlaveStatus object
5701 (BuilderStatus.getLastFinishedBuild): all builds are now in
5702 .builds, even the currently-running one. Accomodate this change.
5703 (BuilderStatus.eventGenerator): new per-builder event generator.
5704 Returns BuildStepStatus and BuildStatus objects, since they can
5705 both be adapted as necessary.
5706 (BuilderStatus.addEvent): clean up started/finished attributes
5707 (BuilderStatus.startBuild,finishBuild): remove dead code
5708 (SlaveStatus): new object to provide ISlaveStatus
5710 * buildbot/process/step.py (ShellCommand.getColor): actually
5711 return the color instead of setting it ourselves
5712 (CVS.__init__): pull .timeout and .workdir options out of
5713 **kwargs, since BuildStep will ignore them. Without this neither
5714 will be sent to the slave correctly.
5715 (SVN.__init__): same
5717 * buildbot/process/builder.py (Builder): move flags to class-level
5719 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5720 SlaveStatus handle that
5722 * buildbot/process/base.py (Build.firstEvent): remove dead code
5723 (Build.stopBuild): bugfix
5725 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5727 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5728 (ChangeMaster.eventGenerator): yield Changes, since there are now
5729 Adapters to turn them into HTML boxes
5731 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5732 (BotPerspective.attached): feed a SlaveStatus object
5733 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5734 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5736 * buildbot/interfaces.py: API additions
5737 (ISlaveStatus): place to get slave status
5739 2004-08-04 Brian Warner <warner@lothar.com>
5741 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5742 the delay finishes, so the step is marked as SUCCESS
5744 * buildbot/test/test_run.py (Status.testSlave): cover more of
5745 IBuildStatus and IBuildStepStatus
5747 * buildbot/status/progress.py (StepProgress): move some flags to
5748 class-level attributes
5749 (StepProgress.remaining): if there are no other progress metrics
5750 to go by, fall back to elapsed time
5751 (StepProgress.setExpectations): take a dict of metrics instead of
5753 (BuildProgress.setExpectationsFrom): pull expectations from the
5754 Expectations, instead of having it push them to the BuildProgress
5755 (Expectations): move some flags to class-level attributes
5756 (Expectations.__init__): copy per-step times from the
5758 (Expectations.expectedBuildTime): new method for per-build ETA
5760 * buildbot/status/event.py (Logfile): move some flags to
5761 class-level attributes
5762 (Logfile.logProgressTo): better method name, let step set the
5763 progress axis name (instead of always being "output")
5765 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5766 times directly, rather than depending upon the (possibly missing)
5767 .progress object. Use 'None' to indicate "not started/finished
5769 (BuildStepStatus.getExpectations): oops, return the full list of
5771 (BuilderStatus._buildFinished): append finished builds to .builds
5773 * buildbot/process/step.py (BuildStep): add separate .useProgress
5774 flag, since empty .progressMetrics[] still implies that time is a
5776 (CVS): set up the cmd in __init__, instead of waiting for start()
5778 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5779 calculation, this will eventually turn into a proper sourceStamp
5780 (Build.setupBuild): tell the Progress to load from the Expectations,
5781 instead of having the Expectations stuff things into the Progress
5782 (Build.buildException): add a build-level errback to make sure the
5783 build's Deferred fires even in case of exceptions
5785 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5787 * buildbot/process/builder.py (Builder.forceBuild): convey the
5788 reason instead of creating a fake Change
5790 * docs/examples/twisted_master.cfg: update to match reality
5792 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5793 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5794 fix or remove broken/breaking tests
5796 * buildbot/status/event.py (Logfile.__len__): remove evil method
5798 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5799 missing .build, for test convenience
5801 * buildbot/process/step_twisted.py: import fixes
5803 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5805 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5806 .statusbag reference
5808 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5809 connection at shutdown, and stop it from reconnecting
5811 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5812 chase down remote-execution bugs
5814 * buildbot/process/step.py: more fixes, remove
5815 BuildStep.setStatus()
5816 * buildbot/status/builder.py: move setStatus() functionality into
5818 * buildbot/status/event.py: minor fixes
5820 2004-08-03 Brian Warner <warner@lothar.com>
5822 * buildbot/process/base.py, buildbot/process/builder.py
5823 * buildbot/process/step.py, buildbot/status/builder.py
5824 * buildbot/status/event.py, buildbot/test/test_run.py:
5825 fix status delivery, get a basic test case working
5826 * buildbot/master.py: finish implementing basic status delivery,
5827 temporarily disable HTML/IRC/PB status sources
5829 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5831 * buildbot/status/progress.py (BuildProgress): remove dead code
5833 * buildbot/interfaces.py
5834 * buildbot/process/base.py, buildbot/process/builder.py
5835 * buildbot/process/step.py, buildbot/process/step_twisted.py
5836 * buildbot/status/builder.py: Complete overhaul of the all
5837 status-delivery code, unifying all types of status clients (HTML,
5838 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5839 look like. This commit is a checkpointing of the work-in-progress:
5840 the input side is mostly done (Builders/Builds sending status
5841 to the BuilderStatus/BuildStatus objects), but the output side has
5842 not yet been started (HTML resources querying BuilderStatus
5843 objects). Things are probably very broken right now and may remain
5844 so for several weeks, I apologize for the disruption.
5846 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5847 HTML as the log's contents. Currently used for exception tracebacks.
5848 * buildbot/status/progress.py: minor spelling changes
5850 2004-08-02 Brian Warner <warner@lothar.com>
5852 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5853 in mozilla. Also added stylesheets copied from Twisted's docs.
5854 Remember that these files are meant to be run through Lore first.
5855 Thanks to Philipp Frauenfelder for the fixes.
5856 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5857 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5858 * docs/template.tpl: added a Lore template
5860 2004-07-29 Brian Warner <warner@lothar.com>
5862 * buildbot/interfaces.py: revamp status delivery. This is the
5863 preview: these are the Interfaces that will be provided by new
5864 Builder code, and to which the current HTML/IRC/PB status
5865 displayers will be adapted.
5867 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5868 on the SlaveBuilder, not the Bot.
5869 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5871 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5872 set .usePTY on the FakeSlaveBuilder
5874 2004-07-25 Brian Warner <warner@lothar.com>
5876 * buildbot/changes/freshcvs.py: add some debug log messages
5877 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5878 disabled 'setFilter' syntax
5879 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5880 don't end with a slash
5882 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5884 * setup.py: bump to 0.5.0+ while between releases
5886 2004-07-23 Brian Warner <warner@lothar.com>
5888 * setup.py (version): Releasing buildbot-0.5.0
5890 2004-07-23 Brian Warner <warner@lothar.com>
5892 * README: update for 0.5.0 release
5894 * NEWS: update for 0.5.0 release
5896 2004-07-22 Brian Warner <warner@lothar.com>
5898 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5899 mktap-time configuration flag (--usepty=1, --usepty=0)
5900 * buildbot/bot.py: same
5902 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5903 an 'info' directory being unwanted
5905 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5906 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5907 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5908 and earlier), use a FreshCVSSourceOldcred instead.
5909 (test): simple test routine: connect to server, print changes
5911 * buildbot/changes/changes.py (Change.getTime): make it possible
5912 to print un-timestamped changes
5914 * buildbot/master.py (makeApp): delete ancient dead code
5915 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5916 * buildbot/test/test_config.py (testFindConfigFile): test it
5918 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5919 instead of win32 one
5922 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5923 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5926 * buildbot/process/base.py (Builder.__init__): change constructor
5927 to accept a dictionary of config data, rather than discrete
5928 name/slave/builddir/factory arguments
5930 * docs/examples/twisted_master.cfg: update to new syntax
5931 * docs/examples/glib_master.cfg: same
5932 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5933 rough tests of the new syntax
5936 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5937 to be an int, which means "run a web.distrib sub-server on a TCP
5938 port". This lets you publish the buildbot status page to a remote
5939 twisted.web server (using distrib.ResourceSubscription). Also
5940 rename the local attributes used to hold these web things so
5941 they're more in touch with reality.
5942 * buildbot/test/test_web.py: test webPortnum and webPathname
5943 * docs/config.xhtml: document this new use of webPathname
5945 * docs/config.xhtml: new document, slightly ahead of reality
5947 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5948 'prefix' handling: treat it as a simple string to check with
5949 .startswith, instead of treating it as a directory. This allows
5950 sub-directories to be used. If you use prefix=, you should give it
5951 a string that starts just below the CVSROOT and ends with a slash.
5952 This prefix will be stripped from all filenames, and filenames
5953 which do not start with it will be ignored.
5955 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5957 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5958 and --exclude (inverse of --include). SVN post-commit hooks
5959 now have total control over which changes get sent to buildbot and which
5962 2004-07-10 Brian Warner <warner@lothar.com>
5964 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5965 test case to match new API
5967 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5968 which crashed HTML display when self.entries=[] (needed to
5969 distinguish between [], which means "no entries yet", and None,
5970 which means "the entries have been swapped out to disk, go fetch
5973 2004-07-04 Brian Warner <warner@lothar.com>
5975 * buildbot/process/step_twisted.py (countFailedTests): Count
5976 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5977 10kb from the end because any import errors are wedged there and
5978 they would make us think the test log was unparseable.
5979 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5981 2004-06-26 Brian Warner <warner@lothar.com>
5983 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5984 delete-*.pyc command into an actual BuildStep, so we can label it
5986 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5987 (FullTwistedBuildFactory): same
5989 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5991 * contrib/fakechange.py: Add an errback when sending the fake
5992 change, so we know it didn't work.
5994 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5996 * buildbot/process/step_twisted.py: Delete *.pyc files before
5997 calling trial, so it doesn't catch any old .pyc files whose .py
5998 files have been moved or deleted.
6000 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6001 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6002 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6003 instead of ["twisted.test"], so that the end result is "trial -R
6006 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6007 regular expression to match filenames that should be ignored when
6008 changed. Also add a --revision parameter that specifies the
6009 revision to examine, which is useful for debugging.
6011 2004-06-25 Brian Warner <warner@lothar.com>
6013 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6014 summary of warnings (like DeprecationWarnings), next to the
6017 2004-05-13 Brian Warner <warner@lothar.com>
6019 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6020 we now have a w32 build slave courtesy of Mike Taylor.
6022 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6023 so broken. Fixed a race condition that tripped up interlocked
6024 builds and caused the status to be stuck at "Interlocked" forever.
6025 The twisted buildbot's one interlocked build just so happened to
6026 never hit this case until recently (the feeding builds both pass
6027 before the interlocked build is attempted.. usually it has to wait
6029 (Builder._pong_failed): fix method signature
6031 * setup.py: bump to 0.4.3+ while between releases
6033 2004-04-30 Brian Warner <warner@lothar.com>
6035 * setup.py (version): Releasing buildbot-0.4.3
6037 2004-04-30 Brian Warner <warner@lothar.com>
6039 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6041 * README: update for 0.4.3 release
6043 * NEWS: update for 0.4.3 release
6045 * buildbot/master.py (BuildMaster.__getstate__): make sure
6046 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6048 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6049 .trial as a class attribute, for upgrade from 0.4.2
6051 * buildbot/changes/changes.py (Change.links): add .links for
6054 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6055 .textWatchers and .htmlWatchers at save time, since they are both
6056 volatile, should allow smooth 0.4.2 upgrade
6058 * buildbot/process/step.py (CVS.finishStatus): catch failed
6059 CVS/SVN commands so we can make the status box red
6061 2004-04-29 Brian Warner <warner@lothar.com>
6063 * buildbot/changes/freshcvs.py
6064 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6065 code to do setFilter(), which tells the freshcvs daemon to not
6066 send us stuff that we're not interested in. I will uncomment it
6067 when a new version of CVSToys is available in which setFilter()
6068 actually works, and I get a chance to test it better.
6070 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6072 * buildbot/master.py (Dispatcher): use a registration scheme
6073 instead of hardwired service names
6074 (BuildMaster): keep track of the Dispatcher to support
6077 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6078 PBChangeSource class instead of having it be an undocumented
6079 internal feature of the ChangeMaster. Split out the code into a
6081 * buildbot/changes/pb.py (PBChangeSource): same
6082 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6084 * docs/{factories|sources|steps}.xhtml: document some pieces
6086 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6087 using FCMaildirSource
6088 (f23osx): update OS-X builder to use python2.3, since the slave
6089 was updated to Panther (10.3.3)
6091 2004-03-21 Brian Warner <warner@lothar.com>
6093 * buildbot/process/process_twisted.py: factor out doCheckout, change
6094 to use SVN instead of CVS
6096 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6097 an SVN subclass easier
6098 (BasicSVN): subclass which uses Subversion instead of CVS
6100 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6102 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6104 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6106 2004-02-25 Brian Warner <warner@lothar.com>
6108 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6109 is now either a list (which is passed to spawnProcess directly) or
6110 a string (which gets passed to /bin/sh -c). This removes the useSH
6111 flag and the ArgslistCommand class. Also send status header at the
6112 start and end of each command, instead of having the master-side
6114 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6115 -r'. Update to use list-based arguments.
6116 (SVNFetch): use list-based arguments, use ['dir'] argument to
6118 * buildbot/test/test_steps.py (Commands): match changes
6120 * buildbot/process/step.py (InternalShellCommand.words): handle
6122 (SVN): inherit from CVS, cleanup
6124 * buildbot/status/event.py (Logfile.content): render in HTML, with
6125 stderr in red and headers (like the name of the command we're
6126 about to run) in blue. Add link to a second URL (url + "?text=1")
6127 to get just stdout/stderr in text/plain without markup. There is
6128 still a problem with .entries=None causing a crash, it seems to occur
6129 when the logfile is read before it is finished.
6131 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6132 timeout to the keepalives, and use it to explicitly do a
6133 loseConnection instead of waiting for TCP to notice the loss. This
6134 ought to clear up the silent-lossage problem.
6135 (unsafeTracebacks): pass exception tracebacks back to the master,
6136 makes it much easier to debug problems
6138 2004-02-23 Brian Warner <warner@lothar.com>
6140 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6141 the whole command to /bin/sh instead of execve [Johan Dahlin]
6142 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6143 '-r HEAD' [Johan Dahlin]
6144 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6146 * buildbot/changes/changes.py (Change): add links= argument, add
6147 asHTML method [Johan Dahlin]. Modified to make a bit more
6148 XHTMLish. Still not sure how to best use links= .
6150 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6151 Change.asHTML to display the change, not asText
6153 * buildbot/status/html.py (StatusResourceBuilder): web button to
6156 * buildbot/test/test_run.py: test to actually start a buildmaster
6159 * MANIFEST.in: bring back accidentally-dropped test helper files
6161 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6162 that require cvstoys if it is not installed
6164 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6165 values of "bin/trial" [Dave Peticolas]
6166 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6167 tests passed" when we didn't happen to run any tests
6169 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6170 flunkOnFailure [Johan Dahlin]
6172 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6173 multiple instances of the same Step class by suffixing "_2", etc,
6174 to the name until it is unique. This name needs to be unique
6175 because it is used as a key in the dictionary that tracks build
6177 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6180 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6182 2004-01-14 Brian Warner <warner@lothar.com>
6184 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6185 kicked from a channel, log it
6187 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6188 something over whatever IRC channels the buildmaster is currently
6189 connected to. Added to try and track down a problem in which the
6190 master thinks it is still connected but the IRCd doesn't see it. I
6191 used a styles.Versioned this time, so hopefully users won't have
6192 to rebuild their .tap files this time.
6193 * contrib/debug.glade: add a "Poke IRC" button
6194 * contrib/debugclient.py: same
6196 * setup.py: bump to 0.4.2+ while between releases
6198 2004-01-08 Brian Warner <warner@lothar.com>
6200 * setup.py (version): Releasing buildbot-0.4.2
6202 2004-01-08 Brian Warner <warner@lothar.com>
6204 * NEWS: update for 0.4.2 release
6206 * README: document how to run the tests, now that they all pass
6208 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6210 * buildbot/process/step.py (CVS): add a global_options= argument,
6211 which lets you set CVS global options for the command like "-r"
6212 for read-only checkout, or "-R" to avoid writing in the
6214 * buildbot/slavecommand.py (CVSCommand): same
6216 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6217 testing easier (it is turned off when testing, to avoid the
6220 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6221 to make it easier to test: break generateStepID() out to a
6222 separate function, only update statusbag if it exists.
6223 (ShellCommands): create useful text for dict-based commands too.
6225 * test/*, buildbot/test/*: move unit tests under the buildbot/
6227 * setup.py (packages): install buildbot.test too
6229 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6230 * buildbot/test/test_steps.py: fix it, tests pass now
6232 2004-01-06 Brian Warner <warner@lothar.com>
6234 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6235 freshcvs mail uses a slightly different syntax for new
6236 directories. Update parser to handle either.
6237 * test/test_mailparse.py (Test1.testMsg9): test for same
6239 2003-12-21 Brian Warner <warner@lothar.com>
6241 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6242 'warnOnWarnings' so that lintian errors mark the build orange
6244 2003-12-17 Brian Warner <warner@lothar.com>
6246 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6247 messages emitted by Bonsai, contributed by Stephen Davis.
6249 * test/*: moved all tests to use trial instead of unittest. Some
6250 still fail (test_steps, test_slavecommand, and test_process).
6252 * setup.py (version): bump to 0.4.1+ while between releases
6254 2003-12-09 Brian Warner <warner@lothar.com>
6256 * setup.py (version): Releasing buildbot-0.4.1
6258 2003-12-09 Brian Warner <warner@lothar.com>
6260 * NEWS: update for 0.4.1 release
6262 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6263 freebsd builder code a little bit
6265 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6266 don't try to compare attributes of different classes
6267 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6268 (MaildirSource.messageReceived): fix Change delivery
6270 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6271 into the config file's namespace before loading it, like the
6272 documentation claims it does
6273 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6274 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6275 daemon comes back online
6277 2003-12-08 Brian Warner <warner@lothar.com>
6279 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6280 so the example will work with online=0 as well
6282 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6283 fix the __implements__ line
6285 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6286 class a twisted.application.service.Service, use startService to
6289 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6290 directory fd instead of simple open(). I'm sure this used to work,
6291 but the current version of python refuses to open directories with
6294 2003-12-05 Brian Warner <warner@lothar.com>
6296 * setup.py (version): bump to 0.4.0+ while between releases
6298 2003-12-05 Brian Warner <warner@lothar.com>
6300 * setup.py (version): Releasing buildbot-0.4.0
6302 2003-12-05 Brian Warner <warner@lothar.com>
6304 * docs/examples/glib_master.cfg: replace old sample scripts with
6305 new-style config files
6306 * MANIFEST.in: include .cfg files in distribution tarball
6308 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6309 implement a dummy method to avoid the exception that occurs when
6310 freshcvs sends this to us.
6312 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6313 removed the method, as it broke reconnection. Apparently
6314 stopFactory is called each time the connection attempt fails. Must
6316 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6317 attribute before serialization, since without stopFactory the
6318 reconnect timer may still be active and they aren't serializable.
6320 * test/test_mailparse.py (ParseTest): test with 'self' argument
6322 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6323 argument, as these "functions" are invoked like methods from class
6324 attributes and therefore always get an instance as the first
6327 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6328 message: thanks to Stephen Davis for the catch
6330 2003-12-04 Brian Warner <warner@lothar.com>
6332 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6333 twisted's standard ReconnectingClientFactory. Handles both oldcred
6334 and newcred connections. Also has a bug-workaround for
6335 ReconnectingClientFactory serializing its connector when it
6338 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6339 pbutil. Replace makeApp stuff with proper newcred/mktap
6340 makeService(). Don't serialize Ephemerals on shutdown.
6342 * buildbot/changes/changes.py (ChangeMaster): make it a
6343 MultiService and add the sources as children, to get startService
6344 and stopService for free. This also gets rid of the .running flag.
6346 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6347 new pbutil, turn into a TCPClient at the same time (to get
6348 startService for free). Two variants exist: FreshCVSSourceOldcred
6349 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6350 yet, but when it does, we'll be ready).
6351 (FreshCVSSource.notify): handle paths which are empty after the
6352 prefix is stripped. This only happens when the top-level (prefix)
6353 directory is added, at the very beginning of a Repository's life.
6355 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6356 Now the only reconnecting code is in the factory where it belongs.
6357 (Builder.unsubscribe): unregister the disconnect callback when we
6358 delete the builder on command from the master (i.e. when the
6359 buildmaster is reconfigured and that builder goes away). This
6360 fixes a multiple-delete exception when the status client is shut
6362 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6365 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6366 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6368 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6370 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6371 a list of globs (ugh). The testdir will be searched for files
6372 named *.tests and run the tests in the order specified in each of
6373 those files. This allows for "dependancies" between tests to be
6376 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6377 argument to pass to run_maxq.py, instead of a glob.
6379 2003-10-17 Brian Warner <warner@lothar.com>
6381 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6382 files that live in the sandbox
6384 2003-10-15 Brian Warner <warner@lothar.com>
6386 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6387 spelling error in "docs" count-warnings output
6388 (HLint.start): stupid thinko meant .xhtml files were ignored
6390 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6391 tests now that cReactor is banished to the sandbox
6393 2003-10-10 Brian Warner <warner@lothar.com>
6395 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6396 scheme: now .xhtml are sources and .html are generated
6398 2003-10-08 Brian Warner <warner@lothar.com>
6400 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6401 we were ignoring the 'randomly' parameter.
6403 2003-10-01 Brian Warner <warner@lothar.com>
6405 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6406 posix, to kill sub-children of aborted slavecommands.
6408 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6409 Clean up initialization: lastBuildStatus remains None until the
6410 first build has been completed.
6412 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6413 None as a lastBuildStatus
6414 * buildbot/clients/gtkPanes.py: same
6416 * buildbot/status/client.py (StatusClientService): keep
6417 BuilderStatus objects in self.statusbags . These objects now live
6418 here in the StatusClientService and are referenced by the Builder
6419 object, rather than the other way around.
6420 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6421 * buildbot/process/base.py (Builder): same
6422 * test/test_config.py (ConfigTest.testBuilders): same
6424 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6425 an existing builder, leave the statusbag alone. This will preserve the
6428 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6429 hook. This will probably go away in favor of a class in upcoming
6432 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6433 serviceName from newcred FreshCVSNotifiee setup
6435 2003-09-29 Brian Warner <warner@lothar.com>
6437 * buildbot/process/process_twisted.py: switch to new reactor
6439 * docs/examples/twisted_master.cfg: same
6441 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6443 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6444 botmaster reference instead of the oldapp service lookup
6446 * buildbot/master.py (BuildMaster.__init__): give the
6447 StatusClientService a reference to the botmaster to make it easier to
6450 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6452 * buildbot/status/html.py (Box.td): escape hreffy things so you
6453 can have spaces in things like builder names
6454 (StatusResourceBuilder.body)
6455 (WaterfallStatusResource.body)
6456 (WaterfallStatusResource.body0): same
6458 2003-09-25 Brian Warner <warner@lothar.com>
6460 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6461 rearrange the builder list when adding or removing builders: keep
6462 them in the order the user requested.
6463 * test/test_config.py (ConfigTest.testBuilders): verify it
6465 * contrib/debug.glade: give the debug window a name
6467 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6468 now wait on multiple interlocks. Fix code relating to that.
6469 (Builder.checkInterlocks): same
6470 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6472 * buildbot/master.py (BuildMaster.loadConfig): move from
6473 deprecated pb.BrokerFactory to new pb.PBServerFactory
6474 * test/test_config.py (ConfigTest.testWebPathname): same
6476 * docs/examples/twisted_master.cfg: fix interlock declaration
6478 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6479 Interlocks to their Builders into interlock.py .
6480 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6482 * test/test_config.py (ConfigTest.testInterlocks): validate
6485 * buildbot/process/base.py (Builder.__init__): better comments
6486 * buildbot/process/interlock.py (Interlock.__repr__): same
6487 (Interlock.deactivate): add .active flag, move the code that
6488 attaches/detaches builders into the Interlock
6490 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6492 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6493 tests using the new run_maxq.py script, and reporting failures by
6496 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6497 tests, reporting their success or failure in a buildbot-friendly
6500 2003-09-24 Brian Warner <warner@lothar.com>
6502 * docs/examples/twisted_master.cfg: example of a new-style config
6503 file. This lives in the buildmaster base directory as
6506 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6507 button to make the master re-read its config file
6509 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6510 buildmaster configuration from a file. This file can be re-read
6511 later, and the buildmaster will update itself to match the new
6512 desired configuration. Also use new Twisted Application class.
6513 * test/Makefile, test/test_config.py: unit tests for same
6515 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6516 FreshCVSSources comparable, to support reload.
6517 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6519 * buildbot/process/base.py (Builder): make them comparable, make
6520 Interlocks easier to attach, to support reload. Handle
6521 re-attachment of remote slaves.
6522 * buildbot/process/interlock.py (Interlock): same
6524 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6525 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6526 buildmaster taps are now constructed with mktap.
6527 * buildbot/status/client.py (StatusClientService): same
6529 * buildbot/status/words.py: move to new Services, add support to
6530 connect to multiple networks, add reload support, allow nickname
6531 to be configured on a per-network basis
6533 2003-09-20 Brian Warner <warner@lothar.com>
6535 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6536 the freebsd builder, now that the machine has been upgraded and no
6537 longer has python2.2
6539 * setup.py (version): bump to 0.3.5+ while between releases
6541 2003-09-19 Brian Warner <warner@lothar.com>
6543 * setup.py (version): Releasing buildbot-0.3.5
6545 2003-09-19 Brian Warner <warner@lothar.com>
6547 * NEWS: add post-0.3.4 notes
6549 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6551 * MANIFEST.in: add contrib/*
6553 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6554 use a remote root now: cvs.twistedmatrix.com
6556 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6558 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6559 compatibility with old servers
6560 (FreshCVSSource.start): and provide a way to use it
6561 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6563 * docs/examples/twisted_master.py (twisted_app): update to new
6565 (twisted_app): listen on new ~buildbot socket
6566 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6568 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6569 to reduce cvs bandwidth (update instead of full checkout)
6571 2003-09-11 Brian Warner <warner@lothar.com>
6573 * contrib/fakechange.py: demo how to connect to the changemaster
6574 port. You can use this technique to submit changes to the
6575 buildmaster from source control systems that offer a hook to run a
6576 script when changes are committed.
6578 * contrib/debugclient.py: tool to connect to the debug port. You
6579 can use it to force builds, submit fake changes, and wiggle the
6582 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6583 'Dispatcher' realm to handle all the different kinds of
6584 connections and Perspectives: buildslaves, the changemaster port,
6585 the debug port, and the status client port. NewCredPerspectives
6586 now have .attached/.detached methods called with the remote 'mind'
6587 reference, much like old perspectives did. All the pb.Services
6588 turned into ordinary app.ApplicationServices .
6589 (DebugService): went away, DebugPerspectives are now created
6590 directly by the Dispatcher.
6591 (makeApp): changed interface a little bit
6593 * buildbot/changes/changes.py: newcred
6594 * buildbot/status/client.py: newcred
6596 * buildbot/clients/base.py: newcred client side changes
6597 * buildbot/bot.py: ditto
6599 * docs/examples/glib_master.py: handle new makeApp() interface
6600 * docs/examples/twisted_master.py: ditto
6602 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6603 base newcred Perspectives on. This should go away once Twisted
6604 itself provides something sensible.
6607 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6609 * contrib/svn_buildbot.py: A program that you can call from your
6610 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6611 when a change in an SVN repository has happened. See the top of
6612 the file for some minimal usage info.
6614 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6616 * buildbot/slavecommand.py (ArglistCommand): Add new
6617 ArglistCommand that takes an argument list rather than a string as
6618 a parameter. Using a st.split() for argv is very bad.
6620 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6621 update to a particular revision rather than always checking out
6622 (still not very smart about it, there may be cases where the
6623 checkout becomes inconsistent).
6625 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6627 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6628 SVN fetch support. It can checkout (not update!) a specified
6629 revision from a specified repository to a specified directory.
6631 * buildbot/status/progress.py (Expectations.update): Fix an
6632 obvious bug (apparently created by the change described in the
6633 previous ChangeLog message) by moving a check to *after* the
6634 variable it checks is defined.
6637 2003-09-08 Brian Warner <warner@lothar.com>
6639 * buildbot/status/progress.py (Expectations.update): hack to catch
6640 an exception TTimo sees: sometimes the update() method seems to
6641 get called before the step has actually finished, so the .stopTime
6642 is not set, so no totalTime() is available and we average None
6643 with the previous value. Catch this and just don't update the
6644 metrics, and emit a log message.
6646 2003-08-24 Brian Warner <warner@lothar.com>
6648 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6649 parameter to set copydir='original' in CVS commands.
6651 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6653 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6654 which tells the command to maintain a separate original-source CVS
6655 workspace. For each build, this workspace will be updated, then
6656 the tree copied into a new workdir. This reduces CVS bandwidth
6657 (from a full checkout to a mere update) while doubling the local
6658 disk usage (to keep two copies of the tree).
6660 2003-08-21 Brian Warner <warner@lothar.com>
6662 * buildbot/status/event.py (Logfile.addEntry): if the master web
6663 server dies while we're serving a page, request.write raises
6664 pb.DeadReferenceError . Catch this and treat it like a
6665 notifyFinish event by dropping the request.
6667 2003-08-18 Brian Warner <warner@lothar.com>
6669 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6670 (instead of blowing up) if a force-build command is given without
6673 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6674 don't blow up if there aren't yet any Changes in the list
6676 2003-08-02 Brian Warner <warner@lothar.com>
6678 * buildbot/bot.py (updateApplication): don't set the .tap name,
6679 since we shouldn't assume we own the whole .tap file
6681 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6682 'mktap buildbot' (without a subcommand) better
6684 2003-07-29 Brian Warner <warner@lothar.com>
6686 * buildbot/status/words.py
6687 (IrcStatusFactory.clientConnectionLost): when we lose the
6688 connection to the IRC server, schedule a reconnection attempt.
6690 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6691 use shutil.rmtree instead of forking off an "rm -rf" command.
6692 rmtree may take a while and will block until it finishes, so we
6693 use "rm -rf" if available.
6695 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6696 freebsd buildslave badly
6698 * setup.py (version): bump to 0.3.4+ while between releases
6700 2003-07-28 Brian Warner <warner@lothar.com>
6702 * setup.py (version): Releasing buildbot-0.3.4
6704 2003-07-28 Brian Warner <warner@lothar.com>
6706 * NEWS: update in preparation for release
6708 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6709 process.signalProcess instead of os.kill, to improve w32
6712 * docs/examples/twisted_master.py (twisted_app): turn off
6713 win32eventreactor: the tests hang the buildslave badly
6715 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6716 failed builds, since usually the failures are consistent
6718 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6719 add compileOpts/compileOpts2 to reactors build
6721 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6722 (twisted_app): use both default and win32eventreactor on w32 build.
6723 Use both default and kqreactor on freebsd build.
6725 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6726 add compileOpts2, which is put after the build_ext argument. w32
6727 needs "-c mingw32" here.
6729 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6730 touch .acqpath, it goes away in recent Twisted releases
6732 * docs/examples/twisted_master.py (twisted_app): use "python" for
6733 the w32 buildslave, not "python2.2"
6735 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6736 the directory exists.. should hush an exception under w32
6738 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6739 ProcessTerminated -provided values for signal and exitCode rather
6740 than parsing the unix status code directly. This should remove one
6741 more roadblock for a w32-hosted buildslave.
6743 * test/test_mailparse.py: add test cases for Syncmail parser
6745 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6746 temporary compatibility import. Note! Start importing
6747 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6749 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6751 2003-07-27 Brian Warner <warner@lothar.com>
6753 * NEWS: started adding new features
6755 * buildbot/changes/mail.py: start work on Syncmail parser, move
6756 mail sources into their own file
6758 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6759 as implementing IChangeSource
6760 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6762 * buildbot/interfaces.py: define the IChangeSource interface
6764 2003-07-26 Brian Warner <warner@lothar.com>
6766 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6768 2003-06-25 Brian Warner <warner@lothar.com>
6770 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6773 2003-06-17 Brian Warner <warner@lothar.com>
6775 * buildbot/status/words.py: clean up method usage to avoid error
6776 in silly IRC command
6777 (IrcStatusBot.emit_status): round off seconds display
6779 * buildbot/process/base.py (Build): delete the timer when saving
6780 to the .tap file, and restore it (if it should still be running)
6781 upon restore. This should fix the "next build in -34 seconds"
6782 messages that result when the master is restarted while builds are
6783 sitting in the .waiting slot. If the time for the build has
6784 already passed, start it very soon (in 1 second).
6786 * buildbot/status/words.py: more silly commands
6788 * README (REQUIREMENTS): add URLs to all required software
6790 * buildbot/status/words.py ('last'): mention results of, and time
6793 2003-05-28 Brian Warner <warner@lothar.com>
6795 * buildbot/status/words.py: add 'last' command
6796 (IrcStatusBot.emit_status): add current-small text to 'status' output
6798 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6799 (twisted_app): remove spaces from OS-X builder name
6801 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6802 * buildbot/status/words.py: IRC bot should actually be useful now
6804 2003-05-23 Brian Warner <warner@lothar.com>
6806 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6807 "slave information" from $(slavedir)/info/* . These files are
6808 maintained by the slave administrator, and describe the
6809 machine/environment that is hosting the slave. Information from
6810 them is put into the "Builder" HTML page. Still need to establish
6811 a set of well-known filenames and meanings for this data: at the
6812 moment, *all* info/* files are sent to the master, but only
6813 'admin' and 'host' are used on that end.
6814 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6815 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6816 * buildbot/master.py (BotPerspective.got_info): ditto
6818 2003-05-22 Brian Warner <warner@lothar.com>
6820 * setup.py (version): bump version to 0.3.3+ while between releases
6822 2003-05-21 Brian Warner <warner@lothar.com>
6824 * setup.py: Releasing buildbot-0.3.3
6826 2003-05-21 Brian Warner <warner@lothar.com>
6828 * NEWS: 0.3.3 news items
6830 * README: describe --keepalive and life behind a NAT box
6832 * buildbot/bot.py (Bot.connected): implement application-level
6833 keepalives to deal with NAT timeouts, turn them on with
6834 --keepalive option or when SO_KEEPALIVE doesn't work.
6836 * buildbot/master.py (BotPerspective): accept keepalives silently
6838 * buildbot/process/base.py (Build.buildException): CopiedFailures
6839 don't carry as much information as local ones, so don't try to
6840 create a big HTMLized version of them.
6842 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6843 log file when step fails due to an exception, such as when the slave
6846 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6847 --testmodule argument instead of grepping for test-case-name tags
6848 ourselves. Remove FindUnitTests code.
6849 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6851 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6853 2003-05-16 Brian Warner <warner@lothar.com>
6855 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6856 argument to allow things like CFLAGS=-O0 to be passed without relying
6857 upon /bin/sh processing on the slave.
6859 * buildbot/process/step.py (InternalShellCommand.start): send
6861 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6862 'split' instead of letting /bin/sh do it. This should also remove
6863 the need for /bin/sh on the buildslave, making it more likely to
6866 * buildbot/status/html.py: html-escape text in blamelist.
6867 Add "force build" button to the Builder page.
6869 * buildbot/process/step_twisted.py (countFailedTests): look at
6870 last 1000 characters for status line, as import errors can put it
6871 before the -200 point.
6873 2003-05-15 Brian Warner <warner@lothar.com>
6875 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6877 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6878 make 'clobber' a parameter, so it is possible to have builds which
6879 do full tests but do a cvs update instead of hammering the CVS
6880 server with a full checkout each build
6882 * buildbot/process/step.py (InternalShellCommand): bump default
6883 timeout to 20 minutes
6885 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6886 the master to trigger a build. Run it via manhole.
6888 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6889 allow slaves to trigger any build that they host, to make life
6890 easier for slave admins who are testing out new build processes
6892 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6893 don't flunk cReactor or qtreactor on failure, since they fail alot
6894 these days. Do warnOnFailure instead.
6896 * buildbot/process/base.py: change Builder.buildable from a list
6897 into a single slot. When we don't have a slave, new builds (once
6898 they make it past the timeout) are now merged into an existing
6899 buildable one instead of being queued. With this change, a slave
6900 which has been away for a while doesn't get pounded with all the
6901 builds it missed, but instead just does a single build.
6903 2003-05-07 Brian Warner <warner@lothar.com>
6905 * setup.py (version): bump version to 0.3.2+ while between releases
6907 2003-05-07 Brian Warner <warner@lothar.com>
6909 * setup.py: Releasing buildbot-0.3.2
6911 2003-05-07 Brian Warner <warner@lothar.com>
6913 * setup.py: fix major packaging error: include subdirectories!
6915 * NEWS: add changes since last release
6917 * README (REQUIREMENTS): update twisted/python dependencies
6919 * buildbot/status/builder.py (Builder.startBuild): change
6920 BuildProcess API: now they should call startBuild/finishBuild
6921 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6922 keeping a list of builds in the statusbag, to support other kinds of
6924 (Builder.addClient): send current-activity-small to new clients
6925 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6928 * buildbot/status/client.py: drop RemoteReferences at shutdown
6930 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6932 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6933 more debug messages for remote status client
6935 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6936 (.stepFailed): only fire the Deferred once, even if both
6937 stepComplete and stepFailed are called. I think this can happen if
6938 an exception occurs at a weird time.
6940 * buildbot/status/words.py: work-in-progress: IRC status delivery
6942 2003-05-05 Brian Warner <warner@lothar.com>
6944 * docs/examples/twisted_master.py (twisted_app): hush internal
6945 python2.3 distutils deprecation warnings
6946 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6947 add compileOpts= argument which inserts extra args before the
6948 "setup.py build_ext" command. This can be used to give -Wignore
6949 warnings, to hush some internal python-2.3 deprecation messages.
6951 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6952 the ['twisted.test'] default test case to make it easier to change
6955 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6956 * buildbot/clients/gtkPanes.py: ditto
6958 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6959 arg to collapse RunUnitTestsRandomly into RunUnitTests
6960 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6961 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6963 * buildbot/status/html.py (StatusResource): shuffle Resources
6964 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6965 would serve the waterfall display, but the internal links were
6966 only valid on the trailing-slash version. The correct behavior is
6967 for the non-slashed one to serve a Redirect to the slashed one.
6968 This only shows up when the buildbot page is hanging off another
6969 server, like a Twisted-Web distributed server.
6971 * buildbot/status/event.py (Event, RemoteEvent): make Events
6972 pb.Cacheable, with RemoteEvent as the cached version. This removes
6973 a lot of explicit send-an-update code.
6974 * buildbot/status/builder.py (Builder): remove send-update code
6975 * buildbot/status/client.py (ClientBuilder): remove send-update
6976 code, and log errors that occur during callRemote (mostly to catch
6977 InsecureJelly exceptions)
6979 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6980 run Lore with the same python used in the rest of the build
6982 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6984 * buildbot/process/step_twisted.py (HLint): accept 'python'
6985 argument. Catch rc!=0 and mark the step as failed. This marks the
6986 build orange ("has warnings").
6987 (RunUnitTestsJelly): move out to step_twisted2.py
6989 * buildbot/util.py (ignoreStaleRefs): add utility function
6991 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6992 don't fake ETA object, it's too hard to get right
6994 2003-05-02 Brian Warner <warner@lothar.com>
6996 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6998 2003-05-01 Brian Warner <warner@lothar.com>
7000 * buildbot/status/html.py (StatusResource.body): oops, I was
7001 missing a <tr>, causing the waterfall page to be misrendered in
7002 everything except Galeon.
7004 2003-04-29 Brian Warner <warner@lothar.com>
7006 * docs/examples/twisted_master.py: make debuild use python-2.2
7007 explicitly, now that Twisted stopped supporting 2.1
7009 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7010 handle tuple results too. I keep forgetting this, which suggests
7011 it needs to be rethought.
7013 * setup.py (setup): bump version to 0.3.1+ while between releases
7015 2003-04-29 Brian Warner <warner@lothar.com>
7017 * setup.py: Releasing buildbot-0.3.1
7019 2003-04-29 Brian Warner <warner@lothar.com>
7021 * README (SUPPORT): add plea to send questions to the mailing list
7023 * NEWS, MANIFEST.in: add description of recent changes
7025 * docs/examples/twisted_master.py: add the code used to create the
7026 Twisted buildmaster, with passwords and such removed out to a
7029 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7030 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7031 buildmasters to not require CVSToys be installed.
7032 * README, docs/examples/glib_master: update to match the change
7034 * buildbot/clients/base.py, buildbot/bot.py,
7035 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7036 ReconnectingPB from CVSToys distribution to remove CVSToys
7037 dependency for build slaves and status clients. Buildmasters which
7038 use FreshCVSSources still require cvstoys be installed, of course.
7040 2003-04-25 Brian Warner <warner@lothar.com>
7042 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7043 runTestsRandomly arg to turn on trial -z
7045 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7046 experimental code to use trial's machine-parseable output to get
7047 more detailed test results. Still has some major issues.
7048 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7051 * buildbot/status/builder.py (Builder.setCurrentBuild):
7052 anticipating moving build history into statusbag, not used yet
7054 * buildbot/status/tests.py: code to centralize test results,
7055 doesn't work quite yet
7057 * buildbot/status/event.py (Event): use hasattr("setName") instead
7058 of isinstance for now.. need better long-term solution
7060 * buildbot/status/html.py: Remove old imports
7062 2003-04-24 Brian Warner <warner@lothar.com>
7064 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7065 ignore changes under doc/fun/ and sandbox/
7067 * buildbot/process/step_twisted.py: update pushEvent and friends.
7069 * buildbot/status/html.py (Box.td): replace event.buildername with
7070 event.parent.getSwappableName(). Needs more thought.
7072 * buildbot/status/builder.py (Builder): Replace pushEvent and
7073 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7074 Tell events they are being pruned with event.delete().
7076 * buildbot/process/base.py (Build): Remove Builder status-handling
7077 methods. s/pushEvent/setCurrentActivity/.
7079 * buildbot/process/step.py (BuildStep): clean up status delivery.
7080 Gouse builder.statusbag methods instead of intermediate builder
7081 methods. s/updateLastEvent/updateCurrentActivity/.
7082 s/finalizeLastEvent/finishCurrentActivity/. Use
7083 addFileToCurrentActivity for summaryFunction.
7085 * buildbot/status/event.py (Logfile): put data in a Swappable when
7087 (Event): add more setter methods. Remove .buildername, use .parent
7088 and getSwappableName instead (needs more thought).
7090 * buildbot/util.py (Swappable):
7091 * test/test_swap.py: don't bother setting filename at __init__
7092 time, do it later. Change setFilename args to take parent first,
7093 since it provides the most significant part of the filename.
7095 2003-04-23 Brian Warner <warner@lothar.com>
7097 * buildbot/status/event.py (Logfile.addEntry): append to previous
7100 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7101 anticipating Swappable
7102 (InternalShellCommand.remoteUpdate): split out various log-adding
7103 methods so subclasses can snarf stdout separately
7105 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7106 in anticipation of Swappable build logs
7107 (Builder.testsFinished): anticipating TestResults, still disabled
7109 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7112 * buildbot/status/event.py (Logfile): add (disabled) support for
7113 Swappable, not ready for use yet
7115 * buildbot/util.py (Swappable): object which is swapped out to
7116 disk after some period of no use.
7117 * test/test_swap.py: test buildbot.utils.Swappable
7119 2003-04-14 Brian Warner <warner@lothar.com>
7121 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7122 periodic-build timer. Set the .periodicBuildTime on a builder
7123 instance to some number of seconds to activate it.
7125 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7127 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7128 a way that survives result tuples
7130 2003-04-12 Brian Warner <warner@lothar.com>
7132 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7133 return a dict instead of a tuple: allow summarizers to provide
7134 multiple summaries if they want
7135 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7136 (debuildSummarizer): summarize lintian warnings/errors
7138 2003-04-10 Brian Warner <warner@lothar.com>
7140 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7142 2003-04-09 Brian Warner <warner@lothar.com>
7144 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7145 empty summaries: happens when the tests fail so hard they don't emit
7146 a parseable summary line.
7148 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7149 Allow summaryFunction to return None to indicate no summary should
7152 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7153 writing to stale HTTP requests: notice when they disconnect and
7154 remove the request from the list. Also add CacheToFile from
7155 moshez, will be used later.
7157 2003-04-08 Brian Warner <warner@lothar.com>
7159 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7160 should be an int, not a list of strings
7162 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7163 if we weren't actually connected
7165 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7166 to show the tail end of the trial text output
7168 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7169 hook to summarize the results of a ShellCommand
7171 2003-04-07 Brian Warner <warner@lothar.com>
7173 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7174 twisted test suite code into a single class.
7175 * buildbot/process/process_twisted.py: same
7177 2003-04-04 Brian Warner <warner@lothar.com>
7179 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7181 * README (SLAVE): document use of mktap to create slave .tap file
7182 (REQUIREMENTS): describe dependencies
7184 * buildbot/bb_tap.py, buildbot/plugins.tml:
7185 * buildbot/bot.py (updateApplication): Add mktap support for creating
7186 buildslave .tap files
7188 2003-03-28 Brian Warner <warner@lothar.com>
7190 * buildbot/process/step.py (InternalShellCommand.finished): handle
7191 new tuple result values (fix embarrasing bug that appeared during
7194 2003-03-27 Brian Warner <warner@lothar.com>
7196 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7199 2003-03-25 Brian Warner <warner@lothar.com>
7201 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7202 to overall build status
7203 * buildbot/clients/base.py (Builder): improve event printing
7204 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7205 instead of generic ShellCommand
7206 (Build): Add .stopBuild, use it when slave is detached
7208 * buildbot/process/step.py (Configure,Test): give the steps their
7209 own names and status strings
7211 * buildbot/status/html.py (StatusResource): add "show" argument,
7212 lets you limit the set of Builders being displayed.
7214 2003-03-20 Brian Warner <warner@lothar.com>
7216 * buildbot/process/basic.py: removed
7218 2003-03-19 Brian Warner <warner@lothar.com>
7220 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7221 turn off process-docs by default
7223 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7224 when displaying build information without anything in allBuilds[]
7226 * buildbot/bot.py (makeApp): really take password from sys.argv
7228 2003-03-18 Brian Warner <warner@lothar.com>
7230 * buildbot/bot.py (buildApp): take password from sys.argv
7232 * README: replace with more useful text
7234 * setup.py: add a real one
7235 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7237 * docs/PyCon-2003/: added sources for PyCon paper.
7239 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7240 now Build objects control the process and Builder only handles
7241 slave stuff and distribution of changes/status. A new BuildFactory
7242 class creates Build objects on demand.
7244 Created ConfigurableBuild which takes a list of steps to run. This
7245 makes it a lot easier to set up a new kind of build and moves us
7246 closer to being able to configure a build from a web page.
7248 * buildbot/process/step_twisted.py, process_twisted.py: move to
7249 new model. A lot of code went away.
7251 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7252 send lots of empty progress messages to the client.
7254 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7256 2003-02-20 Brian Warner <warner@lothar.com>
7258 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7260 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7261 Twisted bug that prevented non-pty processes from working just got
7262 fixed, and the bug that leaks ptys is still being investigated.
7264 * buildbot/process/step.py (CVS): send timeout arg to slave
7266 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7267 builders coming and going
7268 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7269 from CVSToys, handle lost-buildmaster
7271 * buildbot/status/client.py (StatusClientService.removeBuilder):
7272 Clean up status client protocol: send builders (with references)
7273 as they are created, rather than sending a list and requiring the
7274 client to figure out which ones are new.
7275 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7276 attempts to force a build on an unknown builder
7278 2003-02-19 Brian Warner <warner@lothar.com>
7280 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7281 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7282 Twisted stops leaking them.
7283 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7284 builder goes to an idle state.
7286 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7287 I figure out why CVS commands hang without them, and/or I fix the
7288 hung-command timeout
7290 2003-02-16 Brian Warner <warner@lothar.com>
7292 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7293 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7294 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7295 GenerateDocs now that they are prefixed with WARNING:.
7297 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7298 use manual href target instead of request.childLink
7300 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7301 display every second, but update the ETA every 5 seconds (or
7302 whenever) as remote_progress messages arrive.
7305 2003-02-12 Brian Warner <warner@lothar.com>
7307 * *: import current sources from home CVS repository
7311 # add-log-time-format: add-log-iso8601-time-string