| blob | 2081b50f70d6f249ad298548f79bcc553ec56231 |
1 2007-08-13 Brian Warner <warner@lothar.com>
3 * buildbot/status/web/robots.txt: put a robots.txt in new installs
4 which discourages robot access to all large dynamically-generated
5 pages. The intention is that the index page and the 'about' page
6 are the only ones which should be crawlable.
7 * buildbot/scripts/runner.py (Maker.public_html): same
8 (createMaster): same
9 * setup.py: ship index.html and robots.txt in source distributions
11 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
12 activate automatic reloading of the page (using a meta Refresh:
13 tag). Closes #69.
14 (WaterfallHelp): new page to explain all the nifty query arguments
15 you can use on the Waterfall, along with forms to set them for
16 you. From this page, you can add filters for builder=, branch=,
17 show_events=, as well as turning on reload=.
18 (WaterfallStatusResource.buildGrid): new query args: last_time=,
19 first_time=, show_time=, num_events= . The old show= is still
20 accepted, but the new builder= is preferred. We ignore empty
21 branch= arguments, to make the WaterfallHelp form easier to
22 implement.
23 (WaterfallStatusResource.head): new method to add text to the
24 <head> of the page.
25 * buildbot/status/web/base.py (HtmlResource.content): use head()
26 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
27 empty branch= arguments
28 (OneLinePerBuildOneBuilder.body): same
30 2007-08-12 Brian Warner <warner@lothar.com>
32 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
33 new query args: 'last_time' is a timestamp of the top-most event
34 on the display, 'first_time' is a timestamp for the bottom-most
35 event. 'show_time' is the difference between them, and overrides
36 'first_time'. 'num_events' puts an upper limit on the number of
37 timestamps that will be displayed on the left hand edge.
38 (WaterfallStatusResource.body): add a 'next page' link to the
39 bottom, which shows the events that come just after those shown on
40 the current page. This is a first step towards #67, but we need
41 some more controls before we can close that one.
43 * buildbot/buildslave.py (BuildSlave): these are now MultiService
44 instances too, and live as children of the BotMaster. The main
45 advantage of this approach is that BuildSlaves can know when they
46 are being removed (so they can shut off the upcoming
47 when-do-we-email-an-admin-because-we-lost-our-slave timer).
48 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
49 identify which service children are BuildSlaves
50 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
51 Checker updates here, but delegate the rest to..
52 (BotMaster.loadConfig_Slaves): .. here, which looks at the
53 BotMaster's service children to identify the old slaves. I think
54 the previous approach of using master.slaves was broken in the
55 face of config updates that modified BuildSlave instances but did
56 not completely replace them.
57 * docs/buildbot.texinfo (Developer's Appendix): note the change to
58 the Service hierarchy
60 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
61 page (at URL /buildslaves/) to view status of all buildslaves at
62 once, including how long it's been since we last heard from them,
63 and which Builders use them.
65 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
66 pages
68 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
69 list all buildslaves
71 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
72 use the BuildSlave to keep track of the last time we've heard from
73 the buildslave. This is updated upon receipt of any message from
74 any SlaveBuilder (which generally means when RemoteCommands are
75 giving us status updates, as BuildSteps run). In the future this
76 will include slave pings too.
77 * buildbot/process/base.py
78 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
79 * buildbot/process/buildstep.py:
80 (BuildStep.setBuildSlave): accept that reference
81 (BuildStep.runCommand): pass the reference on to the RemoteCommand
82 (RemoteCommand.remote_update): update the timestamp
83 (RemoteCommand.remote_complete): same
84 * buildbot/test/runutils.py (StepTester.makeStep): match the change
85 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
86 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
87 interface to retrieve this timestamp
88 * buildbot/status/builder.py (SlaveStatus): track a copy of the
89 timestamp
92 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
93 up the format a bit
94 (OneLinePerBuild.body): use a <ul> instead of <div>s
95 (OneLinePerBuildOneBuilder.body): same
97 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
98 by adding the file's new name to the list of changed files. This
99 ought to be sufficient for things like isFileImportant and trial
100 tests that only exercise tests for files that have been modified.
101 Closes #31.
103 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
104 XMLRPC server to the WebStatus page. This only has two methods
105 right now (getAllBuildsInInterval and getBuild), but we'll be
106 adding more in the future. This server is extracted from the
107 trac-plugin branch.
109 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
110 generateFinishedBuilds, and improve the data displayed.
111 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
112 the per-Build page, add some information like ETA and got_revision
113 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
114 adding a list of recently completed builds
115 * buildbot/status/web/base.py (css_classes): factor this out
117 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
118 new method, to make status display classes easier to write,
119 especially the WebStatus 'one_line_per_build' page.
120 (IBuilderStatus.generateFinishedBuilds): same
121 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
122 (Status.generateFinishedBuilds): implement it
124 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
125 'source' to be a BuildStep instance, since BuildFactory accepts
126 them now.
127 (CPAN.__init__): same
128 (Distutils.__init__): same
129 (Trial.__init__): same
131 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
132 this might raise KeyError
134 2007-08-07 Brian Warner <warner@lothar.com>
136 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
137 'Owner:' field of the view, rather than 'p4logname', since
138 p4logname comes from the buildslave's environment and seems
139 unlikely to ever do the right thing. Thanks to Wade Brainerd for
140 the patch. Closes #40.
142 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
143 which imposes a per-slave limit on how many builds are allowed to
144 run simultaneously. This has a the same scope than the SlaveLock,
145 but is different because max_builds= gives the buildmaster the
146 freedom to assign the build to a different slave, whereas the
147 SlaveLock doesn't get tested until after the build is irrevocably
148 assigned to a slave. Therefore using max_builds= will improve
149 utilization in the presence of multiple buildslaves that are
150 attached to the same Builder. This completes the incorporation of
151 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
152 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
153 any Builder finishes, potentially trigger *all* Builders, since
154 max_builds= may have stalled someone else while waiting for the
155 slave.
156 * buildbot/scripts/sample.cfg: mention max_builds=
157 * buildbot/test/test_run.py (ConcurrencyLimit): test it
158 * docs/buildbot.texinfo (Buildslave Specifiers): document it
160 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
161 inherit from RunMixin do not need to call master.stopService()
162 themselves, since RunMixin.tearDown does that. The double call
163 fails on Twisted-2.0.x, which didn't happen to protect against it.
164 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
166 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
167 from #48, this one to have the BuildSlave objects track
168 SlaveBuilders, so they'll be able to use that knowledge to
169 influence their canStartBuild() response.
170 * buildbot/process/builder.py (SlaveBuilder.attached): call it
171 (SlaveBuilder.detached): same
172 * buildbot/test/test_slaves.py (BuildSlave): test it
174 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
175 the second of Dustin's #48 patches, this one adding a method to
176 the BuildSlave that allows it to decide whether it is willing to
177 participate in a build or not.
178 (SlaveBuilder.isAvailable): use canStartBuild() to decide
180 * buildbot/test/test_run.py (CanStartBuild): test for it
182 * all: incorporate the first of four patches by Dustin Mitchell
183 from ticket #48, working towards improving control over slave
184 concurrency. The first patch is to use a long-lived BuildSlave
185 object per slave, on which other behavior can be added later. I've
186 modified his patch considerably.
187 * buildbot/buildslave.py (BuildSlave): move class out of
188 slave/__init__.py (where it would get loaded by the slave as well
189 as the master, making dependencies trickier), and merge it with
190 BotPerspective. Now these BuildSlave instances are created once in
191 the master.cfg file, and not destroyed until they are either
192 removed from the config file or changed so
193 much (name/password/class changes) that we cannot continue to use
194 the old one. This affects config files: they must use
195 'from buildbot.buildslave import BuildSlave' instead of using
196 'from buildbot.slave import BuildSlave'.
197 * buildbot/master.py: move BotPerspective out
198 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
199 add or remove as necessary, update the rest using data from
200 the new config file.
201 * buildbot/slave/__init__.py: move BuildSlave out
202 * buildbot/test/test*.py: import BuildSlave from the new place
203 * buildbot/scripts/sample.cfg: update to match
204 * docs/buildbot.texinfo: update to match
205 * buildbot/process/builder.py: update comments to match
207 2007-08-02 Brian Warner <warner@lothar.com>
209 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
210 one-line-per-build pages a bit, add a header, refactor slightly
212 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
213 the TimeOutError timer, patch by Dustin Mitchell.
215 2007-08-01 Brian Warner <warner@lothar.com>
217 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
218 mostly work (branch= is still ignored, we need a useful header)
219 (OneLinePerBuildOneBuilder.body): this too
221 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
222 bring this up-to-date w.r.t. recent refactorings, and fix
223 redirections to bounce the browser to the top page after hitting
224 the 'force' button. This needs to be improved, but at least it now
225 redirects to a valid page.
226 (StatusResourceBuilder.ping): same
227 (StatusResourceBuilder.getChild): same, although I think this code
228 might be dead anyways
230 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
231 a branch= query argument, to filter the display down to builds and
232 changes that involve the given branch. You can add multiple
233 branch= arguments to see multiple branches (using a logical OR).
234 Note that there is no way to include the default branch (i.e.
235 None, i.e. trunk) yet, there is still work to be done to allow for
236 simple+uniform names of branches (i.e. removing the VC-specific
237 details of how branches are implemented, so calling the branch
238 'beta4' even though the SVN checkout step requires
239 'branches/beta4').
240 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
241 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
242 * buildbot/interfaces.py (IEventSource.eventGenerator): same
243 * docs/buildbot.texinfo (Buildbot Web Resources): document it
245 * all: bring import statements up-to-date: don't import
246 __future__, assume cPickle and cStringIO are always available.
247 Also remove #!/usr/bin/python lines from non-scripts, my editor
248 has been a bit over-enthusiastic about stuffing them into new .py
249 files.
251 * buildbot/status/web/index.html: put a link to the waterfall page
252 on the index, otherwise first-time users of WebStatus aren't going
253 to see anything very interesting.
255 * buildbot/interfaces.py (IEventSource): document this interface.
256 Thanks to Dustin Mitchell for the patch. Closes #60.
257 * buildbot/status/builder.py (BuilderStatus): same
258 * buildbot/changes/changes.py (ChangeMaster): same
260 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
261 add a query arg of 'show_events=true' to display non-build events,
262 like slaves attaching/detaching and reconfig events, or
263 'show_events=false' to hide them. The default is 'true'.
264 * docs/buildbot.texinfo (Buildbot Web Resources): document it
266 * web-parts: merge in web-parts branch. Lots of changes. The new
267 functionality is to add buildbot.status.html.WebStatus, which is a
268 superset of the Waterfall that adds new status pages and serves
269 regular files from BASEDIR/public_html/ , which is now the preferred
270 place to put robots.txt, buildbot.css, and index.html .
271 * buildbot/scripts/runner.py: the 'create-master' command now
272 creates public_html/ too, and populates it with a couple of
273 static files.
274 * buildbot/status/web: split waterfall code into smaller pieces
276 2007-07-31 Brian Warner <warner@lothar.com>
278 * buildbot/scripts/startup.py (launch): import twistd.run in a
279 different way to hush pyflakes
280 * buildbot/process/builder.py: remove unused import
282 2007-07-30 Brian Warner <warner@lothar.com>
284 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
285 Mitchell: pass SourceStamps around rather than branch/version/etc
286 tuples. Thanks Dustin! Closes #70.
287 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
288 tuple rather than a list, to avoid surprising mutations
289 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
290 * buildbot/status/mail.py (MailNotifier.buildMessage): same
291 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
292 * buildbot/test/test_status.py (Subscription): same
293 * buildbot/test/test_control.py (Force): same
294 * buildbot/test/test_buildreq.py (Request.testMerge): same
296 2007-07-29 Brian Warner <warner@lothar.com>
298 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
299 variable, since it wasn't used and is confusing in the presence of
300 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
301 for the suggestion.
303 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
304 the Buildbot home-page link to point at buildbot.net instead of
305 sourceforge, and add a current-version query parameter so we can
306 get some statistics on which versions are in use out there.
308 2007-07-28 Brian Warner <warner@lothar.com>
310 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
311 with c['change_source'], leaving c['sources'] for backwards
312 compatibility (but deprecated), scheduled for removal in 0.8.0
313 * docs/buildbot.texinfo: same
314 * buildbot/test/test_config.py: verify that c['sources'] still works
315 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
316 * buildbot/scripts/sample.cfg: update to match
318 * buildbot/changes/mail.py (MaildirSource): parse with python's
319 stdlib 'email' module, which has been available since python2.2,
320 and drop use of the 'rfc822' module, which has been depreceated
321 since python2.3 .
322 * buildbot/test/test_maildir.py: same: use parse_file() not parse
324 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
325 this needs to match the renaming in test/mail/msg*
327 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
328 Closes SF#1752648.
330 * buildbot/test/test_mailparse.py: rename sample emails a bit
331 * buildbot/test/mail/msg*: same
333 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
334 parser for the "commit-email.pl" script that is shipped with SVN,
335 written by Justin Mason. Thanks! Closes SF#1072845.
336 * buildbot/test/mail/svn-commit.*: sample messages
337 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
338 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
340 2007-07-27 Brian Warner <warner@lothar.com>
342 * buildbot/changes/mail.py: refactor: move parsing into a method
343 named 'parse', each parser type gets a separate subclass. Remove
344 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
345 to be a simple leading-substring match. Add a warning to the logs
346 if prefix= does not end in a slash, since that's probably a
347 mistake. Fix both places where a prefix= mismatch would skip all
348 subsequent files in the same email, instead of just skipping the
349 one that didn't match.
350 * buildbot/test/test_mailparse.py: match changes
352 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
353 docs on email-based ChangeSources
355 * docs/buildbot.texinfo (Getting Source Code Changes): move all
356 the changesource types up a level, removing the one-entry menu in
357 the process
359 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
360 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
361 instances instead of tuples. Closes #63.
362 * buildbot/slave/__init__.py (BuildSlave): define marker class
363 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
364 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
365 * buildbot/test/test_*.py: update tests to match
366 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
367 the c['bots'] backwards-compatibility handler works
369 2007-07-26 Brian Warner <warner@lothar.com>
371 * buildbot/changes/hgbuildbot.py (hook): add an in-process
372 Mercurial change-sending hook, contributed by Frederic Leroy.
373 Thanks! Addresses #50.
374 * docs/buildbot.texinfo (MercurialHook): document it
376 * buildbot/changes/hgbuildbot.py: change the way imports are done,
377 to make it compatible with at least hg-0.9.1 and the current 0.9.4
379 2007-07-17 Brian Warner <warner@lothar.com>
381 * buildbot/process/buildstep.py (BuildStep.getLog): add a
382 convenience method to retrieve a log added with
383 addLog()/addCompleteLog()/etc or logfiles= . I should have added
384 this two years ago..
386 2007-07-03 Brian Warner <warner@lothar.com>
388 * buildbot/slave/commands.py (ShellCommand._startCommand): when
389 logging the environment variables, put one variable on each line,
390 rather than having one really long line with all of them. This
391 should make them a bit more readable and not trigger the
392 horizontal scrollbar (when viewing it in a web browser) quite so
393 much. Thanks to Albert Hofkamp for the patch.
395 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
396 WithProperties instance. Thanks to Axel Hecht for the patch.
397 Closes #43.
398 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
399 * docs/buildbot.texinfo (Build Properties): document it
400 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
401 workdir if it didn't already exist.
403 * docs/buildbot.texinfo (Scheduler Types): correct the description
404 of Dependent schedulers. Thanks to Greg Ward for the patch.
406 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
407 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
408 the patch. Closes #49.
410 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
411 0700 before removing it, to deal with situations where a build will
412 leave files around without write permissions and the 'copy' or
413 'clobber' VC checkout modes need to blow away the tree first.
414 Thanks to Steve Milner for the suggestion and the patch (which I
415 mangled horribly). Closes #29.
416 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
417 test for it
419 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
420 an allowReconnect= argument to let callers control whether they
421 want this don't-let-it-reconnect behavior, since some tests care.
422 Factor out the .continueTrying=False lines from those callers.
423 * buildbot/test/test_slaves.py: same
424 * buildbot/test/test_run.py: same
426 2007-07-02 Brian Warner <warner@lothar.com>
428 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
429 slave has been disappeared, don't let it reconnect. This was
430 causing an intermittent failure in test_slaves.py, when the slave
431 that was supposed to be gone managed to come back by the end of
432 the test and affect the count.
433 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
434 refactorings
435 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
436 diagnostic messages to track down this problem
437 (Builder.startBuild): same
439 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
440 the slave randomly rather than always taking the first one. Thanks
441 to Pike for the patch. Closes #36.
442 * buildbot/test/test_slaves.py: match the change. to avoid huge
443 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
444 enables/disables the round-robin-ness (enabled by default), and
445 some unit tests disable it.
446 * docs/buildbot.texinfo (Buildmaster Architecture): document it
448 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
449 argument to 'buildmaster_host', to make it more obvious that this
450 points to the buildmaster. Thanks to Bob Proulx for the
451 suggestion.
452 * buildbot/scripts/runner.py (slaveTAC): same
453 * buildbot/test/test_runner.py (Create.testSlave): match the change
455 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
456 work better.
458 2007-06-17 Brian Warner <warner@lothar.com>
460 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
461 we can round-trip all of our current step classes by calling
462 getStepFactory() and using the results to make a clone of the
463 original step.
465 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
466 used in a while..
468 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
469 the config file, we're moving to using actual instances instead of
470 the (class, kwargs) 'step specification' tuples. BuildFactory
471 still keeps a list of tuples internally, but when real instances
472 are passed in to addStep(), they are asked for their class and
473 kwargs using the new BuildStep.getStepFactory method. BuildFactory
474 accepts both instances and the tuple form, and converts instances
475 to the tuple form, but the instance form is preferred because it
476 gives the Steps a chance to do argument validation. Closes: #11.
478 * buildbot/process/buildstep.py (BuildStep.__init__): record the
479 factory information necessary to implement getStepFactory. The
480 addFactoryArguments() method can be used to include arguments that
481 aren't passed to the BuildStep base class constructor.
482 (BuildStep.setBuild):
483 (BuildStep.setDefaultWorkdir): new methods to take parameters that
484 are needed for live BuildSteps but not to construct the specification
485 tuples that are stashed in the factory.
487 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
488 'workdir' into new BuildSteps by using methods instead of
489 arguments. This makes the constructor for BuildSteps a lot
490 simpler.
492 * buildbot/steps/*.py: update to match this change. Basically this
493 means adding calls to addFactoryArguments() in the __init__
494 methods to capture the arguments that aren't passed through to the
495 base class.
496 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
497 the new workdir (if any) into the RemoteShellCommands arguments.
498 * buildbot/steps/source.py: allow workdir= to be optional,
499 implement setDefaultWorkdir() since we don't inherit from
500 (CVS): finally remove old clobber=/export=/copydir= arguments,
501 in favor of the mode= argument that's been around forever now.
502 * buildbot/steps/transfer.py: remove build= argument
504 * buildbot/test/*.py: update to match, generally by turning all
505 build= arguments into subsequent calls to s.setBuild()
506 * buildbot/test/test_config.py (Factories): verify that we can
507 use either BuildStep instances or class/kwarg tuples in both
508 BuildFactory.addStep and BuildFactory.__init__
510 * docs/buildbot.texinfo (Build Steps): document the new approach,
511 mention compatibility with the old approach, update all examples
512 to use the new style.
514 2007-06-16 Brian Warner <warner@lothar.com>
516 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
517 the LoopingCall, just eat the failure so that we'll poll again
518 next time. This should allow us to tolerate (e.g.) sf.net SVN
519 failures more gracefully. Many thanks to Dustin Mitchell for the
520 patch. Closes #34.
522 2007-05-17 Brian Warner <warner@lothar.com>
524 * buildbot/status/words.py: refactor the IRC status bot into
525 separate 'Contact' and 'Channel' classes. The base Contact class
526 contains the interaction code: commands and responses. The
527 IRCContact subclass (and IrcStatusBot 'Channel') handle the
528 IRC-specific aspects. The plan is to write other subclasses for
529 other IM protocols like AIM and Jabber.
531 2007-04-16 Brian Warner <warner@lothar.com>
533 * CREDITS: update list of contributors. Thank you all!
535 2007-04-13 Brian Warner <warner@lothar.com>
537 * buildbot/status/mail.py (MailNotifier): add the project name to
538 the subject line and message body, to make it easier to
539 distinguish email coming from different buildmasters. Thanks to
540 Benoit Sigoure for the patch.
541 * buildbot/test/test_status.py (Mail): update to match
543 2007-03-24 Brian Warner <warner@lothar.com>
545 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
546 avoid text-conversion problems between DOS/windows and unix.
547 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
549 2007-03-03 Brian Warner <warner@lothar.com>
551 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
552 warning about the use of Waterfall here
554 2007-03-01 Brian Warner <warner@lothar.com>
556 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
558 2007-02-28 Brian Warner <warner@lothar.com>
560 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
561 Lamb to use a more optimal form of 'p4 changes', to reduce server
562 load. He reports that this optimization was added to p4d release
563 2005.2, but it should work in all versions. Closes #27.
564 * buildbot/test/test_p4poller.py: match it
566 2007-02-27 Brian Warner <warner@lothar.com>
568 * buildbot/status/web/*.py: move all web status stuff into a
569 separate directory, in anticipation of splitting it into smaller
570 pieces and adding more files. html.py was getting way too big.
571 * buildbot/status/classic.css: move it too
572 * setup.py: add the new sub-package
573 * buildbot/test/test_web.py: match the changes
574 * MANIFEST.in: handle the move of classic.css
576 2007-02-07 Brian Warner <warner@lothar.com>
578 * contrib/OS-X/*: add some launchd .plist files for automatically
579 starting a buildmaster or buildslave under OS-X (10.4 or later).
580 Thanks to Mark Pauley for these.
582 2007-02-06 Brian Warner <warner@lothar.com>
584 * docs/buildbot.texinfo (Requirements): update requirements to
585 stop claiming compatibility with python-2.2 or twisted-1.3.x .
586 Closes #13.
587 * README: mention python-2.5 and twisted-2.5 compatibility
589 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
590 redundant import
591 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
592 compatibility
593 * buildbot/status/builder.py: same, by requiring cStringIO
594 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
595 * buildbot/test/test_vc.py: same
596 * buildbot/test/test_web.py:
597 * buildbot/test/test_steps.py: same, remove unused import
599 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
600 the FORM tag
602 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
603 see any Builders that don't have Schedulers to drive them
605 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
606 attributes this uses went away
608 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
609 dialog, to allow you to reset the buildmaster and force
610 connect/disconnect. Correctly handle losing the buildmaster
611 connection (by switching the display to the hexnut, at which point
612 you can use the 'Connect' menu item to reconnect).
614 * buildbot/steps/source.py (Source.start): if we're using a patch,
615 add it as a LogFile to the checkout/update step. This will turn
616 into a link on the waterfall page.
618 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
619 option, to take the patch from a pre-made file rather than
620 generating it from the local tree. Thanks to Robert Helmer for the
621 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
622 * buildbot/scripts/runner.py (TryOptions): add --diff,
623 --patchlevel, and --baserev options
624 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
625 as None, meaning HEAD.
626 * buildbot/sourcestamp.py (SourceStamp): update docstring to
627 indicate that baserev=None means HEAD
628 * docs/buildbot.texinfo (try --diff): document it
630 * buildbot/test/test_steps.py (BuildStep): remove use of
631 reactor.iterate(), although the technique I replaced it with is a
632 gross polling hack that must be cleaned up properly some day. This
633 was the last use of reactor.iterate in the entire tree, yay.
635 2007-02-05 Brian Warner <warner@lothar.com>
637 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
638 is one of the three known values, otherwise we emit some confusing
639 messages later on. Thanks to Grig Gheorghiu for the catch.
641 2007-01-30 Brian Warner <warner@lothar.com>
643 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
644 Hearsum contributed a patch to let BonsaiPoller work with results
645 that contain non-ascii characters. Closes SF#1632641.
647 2007-01-27 Brian Warner <warner@lothar.com>
649 * Makefile (release): produce both .tar.gz and .zip source bundles.
650 Closes SF#1222216.
652 2007-01-23 Brian Warner <warner@lothar.com>
654 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
655 * buildbot/changes/monotone.py: same
657 * buildbot/changes/maildir.py: combine several files into one,
658 clean up maildir.py to use Services properly.
659 * buildbot/changes/maildirtwisted.py: remove
660 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
661 buildbot anyways.
662 * buildbot/changes/mail.py: match the change
663 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
664 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
666 * buildbot/slave/commands.py (command_version): bump to "2.3" to
667 indicate that the buildslave knows about the 'bzr' command
669 2007-01-22 Brian Warner <warner@lothar.com>
671 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
672 'with', it will become a reserved work in python2.6 .
674 * contrib/bb_applet.py: add a simple gnome-panel applet, to
675 display a terse summary of buildbot status.
676 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
677 some icons, small versions of the Blender object that lives in
678 docs/images/icon.blend
680 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
681 * buildbot/slave/commands.py (Bzr): same
682 * buildbot/scripts/tryclient.py (BzrExtractor): same
683 (SourceStampExtractor.dovc): modify this to allow non-zero exit
684 status, since 'bzr diff' does that
685 * buildbot/test/test_vc.py (Bzr): same
686 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
687 add notes on bzr
688 (Bzr): document it
690 2007-01-20 Brian Warner <warner@lothar.com>
692 * contrib/darcs_buildbot.py: tidy up the progress messages
694 2007-01-17 Brian Warner <warner@lothar.com>
696 * contrib/darcs_buildbot.py: enhance to handle multiple patches
697 being pushed at a time. This keeps state in the repository in a
698 small file named .darcs_buildbot-lastchange, but that shouldn't
699 interfere with normal repository operations. Fixes SF#1534049.
700 * buildbot/clients/sendchange.py (Sender): make a single Sender
701 capable of sending Changes with different usernames.
703 2006-12-11 Brian Warner <warner@lothar.com>
705 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
706 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
707 buildbot.changes.mail a long time ago, but I forgot to add the
708 DeprecationWarning until now.
710 * buildbot/process/maxq.py: remove this, the functionality now
711 lives in buildbot.steps.maxq
713 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
714 * buildbot/clients/gtkPanes.py: remove unused import
716 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
717 that was meant to provide a special Reporter to run inside trial
718 and give the buildslave lots of machine-readable status. We never
719 finished this project.
721 * buildbot/changes/bonsaipoller.py: remove unused imports
722 * buildbot/changes/svnpoller.py: same
723 * buildbot/process/builder.py: same
724 * buildbot/process/buildstep.py: same
725 * buildbot/slave/bot.py: hush pyflakes warning
726 * buildbot/status/tests.py: remove unused imports
727 * buildbot/status/tinderbox.py: same
728 * buildbot/steps/python_twisted.py: same
730 * buildbot/process/step.py: remove this file, these names were
731 deprecated in 0.7.5 and are now being removed.
732 * buildbot/process/step_twisted.py: same
733 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
735 * buildbot/twcompat.py: remove the empty file, yay it is gone
737 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
738 tw-2.0.0 and newer have the method we need.
739 (getProcessOutputAndValue): same
740 (which): remove this method, tw-2.0.0 t.p.procutils has it
742 * buildbot/twcompat.py (implements): remove this method
743 * buildbot/*: import implements() from zope.interface directly
745 * buildbot/status/mail.py: stop falling back to importing
746 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
747 support
749 * buildbot/twcompat.py (Interface): remove this import
750 * buildbot/*: import Interface from zope.interface directly
752 * buildbot/twcompat.py (providedBy): remove this method
753 * buildbot/*: turn all uses of providedBy(obj, iface) into
754 iface.providedBy(obj)
756 * buildbot/twcompat.py (maybeWait): remove this method, now that
757 we no longer maintain compatibility with Twisted<=1.3.0 .
758 Twisted-2.0.0 and later allow trial methods to return Deferreds
759 directly.
760 * buildbot/test/*: remove all uses of maybeWait
762 * buildbot/__init__.py (version): bump to 0.7.5+ while between
763 releases
764 * docs/buildbot.texinfo: same
766 2006-12-10 Brian Warner <warner@lothar.com>
768 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
769 * docs/buildbot.texinfo: set version to match
771 2006-12-10 Brian Warner <warner@lothar.com>
773 * README (REQUIREMENTS): update for release
774 * NEWS: update for release
775 * buildbot/slave/commands.py (command_version): mention that this
776 version (2.2) was released with buildbot-0.7.5
778 * buildbot/test/test_config.py (StartService.testStartService):
779 inhibit the usual read-config-on-startup behavior, since otherwise
780 the log.err that gets recorded causes the test to fail
782 * buildbot/status/builder.py (LogFile.finish): forget about all
783 subscribers once the log has finished, since after that point
784 we're never going to use them again. This might help free up some
785 memory somewhere.
787 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
788 than the old/deprecated gtk.mainquit()
790 2006-12-09 Brian Warner <warner@lothar.com>
792 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
793 better when we can't open the masterdst file
795 * buildbot/scripts/startup.py (Follower._failure): add missing
796 import statement for BuildSlaveDetectedError
798 * buildbot/steps/transfer.py (FileUpload): cleanup
799 (FileDownload): same. Add tests for slave version, add mode=.
800 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
801 (SlaveFileDownloadCommand): same
802 * buildbot/test/test_transfer.py: enhance tests
803 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
804 step.slaveVersion
806 2006-12-08 Brian Warner <warner@lothar.com>
808 * buildbot/scripts/runner.py (sendchange): halt the reactor on
809 both success *and* failure. Without this, the 'buildbot
810 sendchange' command would hang if it could not contact the
811 buildmaster or deliver the Change, which would generally cause the
812 user's commit/record/checkin command to hang too. Thanks to
813 Christian Unger for the catch.
815 2006-12-06 Brian Warner <warner@lothar.com>
817 * NEWS: update with items for the next release
819 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
820 whimsical example pulled from a punch-drunk email I sent out late
821 one night.
822 (Transferring Files): document some of the other parameters
823 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
824 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
825 * buildbot/test/test_svnpoller.py: same
826 * buildbot/changes/svnpoller.py (SVNPoller): same
828 2006-11-26 Brian Warner <warner@lothar.com>
830 * docs/buildbot.texinfo (Build Properties): remind users that
831 WithProperties must appear in a command= list, not as a top-level
832 instance.
833 * buildbot/steps/shell.py (ShellCommand.start): and assert that
834 we're sending a list or a single string to the RemoteShellCommand
836 * buildbot/scheduler.py (Nightly): Improve docs slightly.
838 * buildbot/scripts/startup.py (start): skip the whole
839 watch-the-logfile thing under windows, since it needs os.fork()
841 * buildbot/scripts/runner.py (restart): remove the old message
842 that got printed after the buildbot was restarted.. it most cases
843 it didn't get printed at the right time anyways
845 2006-11-25 Brian Warner <warner@lothar.com>
847 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
848 follow twistd.log and print lines until the process has started
849 started properly. For the buildmaster, this means until the config
850 file has been parsed and accepted. For the buildslave, this means
851 until we've connected to the master. We give up after 5 seconds in
852 any case. Helpful error messages and troubleshooting suggestions
853 are printed when we don't see a successful startup. This closes the
854 remainder of SF#1517975.
855 * buildbot/scripts/startup.py: moved app startup code to here
856 * buildbot/scripts/logwatcher.py: utility class to follow log
857 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
858 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
859 so the LogWatcher can tell the difference between a buildmaster
860 and a buildslave
862 2006-11-24 Brian Warner <warner@lothar.com>
864 * docs/examples/twisted_master.cfg: update to match the version
865 in use on twistedmatrix.com
866 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
867 was using before stopped working, but 'irc.freenode.net' works
868 just fine.
870 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
871 'reconfig' command
873 * buildbot/clients/base.py (TextClient.not_connected): upon
874 UnauthorizedLogin failures, remind the user to connect to the
875 PBListener port instead of the slaveport.
876 (TextClient.disconnected): shut down more quietly
877 * docs/buildbot.texinfo (statuslog): add another reminder
879 * buildbot/scripts/runner.py (Options.subCommands): rename
880 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
881 'sighup' as an alias.
882 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
883 reconfig command to follow twistd.log and print all of the lines
884 from the start of the config-file reload to its completion. This
885 should make it a lot easier to discover bugs in the config file.
886 Use --quiet to disable this behavior. This addresses half of
887 SF#1517975, the other half will be to add this same utility to
888 'buildbot start' and 'buildbot restart'.
889 * docs/buildbot.texinfo (Loading the Config File): same
890 (Shutdown): same
892 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
893 method, it has been deprecated for a long time. Use
894 IBuilderControl.requestBuild instead.
895 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
896 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
897 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
898 * buildbot/test/test_control.py (Force.testForce): same
899 * buildbot/test/test_run.py: use requestBuild instead
901 * buildbot/clients/debug.py: replace 'Force Build' button with
902 'Request Build' (which just adds one to the queue), add Ping
903 Builder, add branch/revision fields to Request Build.
904 * buildbot/clients/debug.glade: same
905 * buildbot/master.py: update interface to match. This creates an
906 incompatibility between new debugclients and old buildmasters.
908 * buildbot/process/builder.py (Builder._attached): delay the call
909 to maybeStartBuild for a reactor turn, to avoid starting a build
910 in the middle of a reconfig (say, if the new Builder uses a new
911 slave which is already connected).
913 2006-11-23 Brian Warner <warner@lothar.com>
915 * buildbot/test/test_transfer.py: appease pyflakes
916 * buildbot/test/test_steps.py: same
918 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
919 keeps pyflakes from finding undefined names
921 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
922 Builder no longer induces a disconnect/reconnect cycle. This means
923 that any builds currently in progress will not be interrupted, and
924 any builds which are queued in the Builder will not be lost. This
925 is implemented by having the new Builder extract the state (i.e.
926 all pending Builds and any desired SlaveBuilders) from the old
927 Builder.
928 (BotPerspective): refactor. The BotPerspective no longer keeps
929 track of all the Builders that want to use this slave; instead, it
930 asks the BotMaster each time it needs this list. This removes
931 addBuilder and removeBuilder. Clean up attached() to acquire all
932 the slave's information in a more atomic fashion. updateSlave() is
933 now the way to make sure the slave is using the right set of
934 Builders: just call it after everything else has been
935 reconfigured.
936 (BotMaster): refactor, removing addBuilder/removeBuilder and
937 replacing them with an all-at-once setBuilders() call.
939 * buildbot/test/test_slaves.py (Reconfig): new test case to
940 exercise this functionality
941 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
942 * buildbot/slave/commands.py (WaitCommand): same
944 * docs/buildbot.texinfo (Loading the Config File): document the
945 changes
947 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
948 SlaveBuilder to have its parent Builder changed.
949 (SlaveBuilder.isAvailable): new method to give access to state,
950 which is now a private attribute
951 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
952 the SlaveBuilder about how it is being used. These methods update
953 its internal state. buildFinished() is now the place that invokes
954 maybeStartBuild() on its parent Builder.
955 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
956 new Builder to take over for an old one, transferring state from
957 the old one.
958 (Buider): refactor the way that SlaveBuilders are used to match,
959 giving them a bit more autonomy.
960 (Builder.buildFinished): this no longer calls maybeStartBuild():
961 instead the SlaveBuilder calls it on whoever its parent Builder is
962 at the time. This way, when an old Builder is replaced by a new
963 one, and there was a build in progress during the transition, when
964 that build finishes, it will be the new Builder that is told about
965 the newly available slave so it can start a new build.
967 * buildbot/process/base.py (Build.startBuild._release_slave): when
968 the Build finishes, tell the SlaveBuilder that they've been
969 released.
971 * buildbot/status/builder.py (SlaveStatus): add some new setter
972 methods for use by BotPerspective, to keep some attributes more
973 private
975 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
976 called by the buildmaster.
977 (Bot.setBuilderList): instead, we locally announce any leftover
978 directories based upon which Builders we were told about. The
979 master doesn't really care; it's the local admin who may or may not
980 wish to delete them.
983 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
984 to allow use of python2.4 or whatever. This tool still requires
985 python2.3 or newer.
987 2006-11-19 Brian Warner <warner@lothar.com>
989 * NEWS (IStatusLog.readlines): more news items
991 2006-11-18 Brian Warner <warner@lothar.com>
993 * NEWS: start collecting items for the next release.
995 2006-11-04 Brian Warner <warner@lothar.com>
997 * buildbot/changes/bonsaipoller.py: apply updates from Ben
998 Hearsum. Closes SF#1590310.
999 * buildbot/test/test_bonsaipoller.py: and tests
1001 * buildbot/status/tinderbox.py
1002 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1003 status when the build results in WARNINGS. Patch from Dave
1004 Liebreich. Closes SF#1587352.
1006 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1007 linux-vs-osx behavior difference w.r.t. reading from files that
1008 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1009 to Mark Rowe for the patch.
1011 2006-10-15 Brian Warner <warner@lothar.com>
1013 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1014 method name was misspelled in the interface definition. Thanks to
1015 Roy Rapoport for the catch.
1017 2006-10-13 Brian Warner <warner@lothar.com>
1019 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1020 to match the great Steps renaming
1022 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1023 Maybe I should run my own unit tests before recording a big
1024 change. Good thing I've got a buildbot to remind me.
1026 2006-10-12 Brian Warner <warner@lothar.com>
1028 * buildbot/steps/transfer.py: rework __init__ and args setup
1029 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1030 docs improvements
1031 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1032 when opening the target file, only catch IOError (to report via
1033 stderr/rc!=0), let the others be reported as normal exceptions
1035 2006-10-08 Brian Warner <warner@lothar.com>
1037 * contrib/svn_watcher.py: fix security holes by using proper argv
1038 arrays and subprocess.Popen() rather than commands.getoutput().
1039 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1040 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1041 probably be removed by the next release.
1042 * CREDITS: add Nick
1044 2006-10-04 Brian Warner <warner@lothar.com>
1046 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1047 initial lines that weren't emitted by pyflakes. When the pyflakes
1048 command is run under a Makefile, 'make' will echo the command it
1049 runs to stdio, and that was getting logged as a "misc" warning.
1050 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1051 * buildbot/test/test_steps.py (testPyFlakes3): another test
1053 2006-10-01 Brian Warner <warner@lothar.com>
1055 * buildbot/status/html.py (HtmlResource.render): if we get a
1056 unicode object from our content() method, encode it into utf-8
1057 like we've been claiming to all along. This allows the comments
1058 and author names from svnpoller.py to be delivered properly.
1060 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1061 de-unicodify filenames before creating the Change, because the
1062 rest of buildbot is unlikely to handle them well. Leave the 'who'
1063 field as a unicode object.. I don't think there's anything that
1064 will break very soon, and it will probably nudge us towards
1065 accepting unicode everywhere sooner or later. Stop using the
1066 "date" field that comes out of SVN, since it is using the
1067 repository's clock (and timezone) and what we care about is the
1068 buildmaster's (otherwise Changes from the future show up later
1069 than the builds they triggered).
1070 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1071 change to .when
1073 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1074 Suvbersion repository polling ChangeSource. I've hacked it up
1075 considerably: any bugs are entirely my own fault. Thank you
1076 Niklaus!
1077 * buildbot/test/test_svnpoller.py: tests for it
1078 * docs/buildbot.texinfo (SvnSource): document it
1080 2006-09-30 Brian Warner <warner@lothar.com>
1082 * buildbot/scheduler.py (Periodic): submit a reason= to the
1083 BuildSet to indicate which Scheduler triggered the build. Thanks
1084 to Mateusz Loskot for the suggestion.
1085 (Nightly): same
1086 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1088 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1089 changes: set self.loop in __init__, remove unused volatile=
1091 * docs/buildbot.texinfo (.buildbot config directory): add more
1092 docs on the .buildbot/options keys used by "buildbot try"
1093 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1094 (Try.deliverJob): same
1096 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1097 from Robert Helmer
1098 (BonsaiPoller): same
1100 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1101 close the filehandle when we stop watching the file. Before, the
1102 filehandle was only closed when the LogFileWatcher was
1103 garbage-collected, which could be quite a while in the future. If
1104 it was still open by the time the next build started, windows will
1105 refuse to let the new build delete the old build/ directory. Fixes
1106 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1107 #twisted for the catch.
1109 2006-09-29 Brian Warner <warner@lothar.com>
1111 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1112 from Robert Helmer
1114 2006-09-25 Brian Warner <warner@lothar.com>
1116 * setup.py: the new buildbot.steps module wasn't being installed.
1117 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1118 (testmsgs): add the extra stuff from buildbot/test/* so you can
1119 run unit tests on an installed copy of buildbot, not just from
1120 the source tree.
1122 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1123 columns of 'svnlook changed' output contain status information, so
1124 strip [:4] instead of [:6]. Depending upon what the status flags
1125 were, this would sometimes lead to mangled filenames. Thanks to
1126 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1128 * buildbot/steps/source.py (Monotone): initial Monotone support,
1129 contributed by Nathaniel Smith. Still needs docs and tests, but
1130 this code has been in use on the Monotone buildbot for a long
1131 time now.
1132 * buildbot/slave/commands.py (Monotone): slave-side support
1133 * buildbot/changes/monotone.py (MonotoneSource): polling change
1134 source
1136 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1137 contributed a Change Source that polls a Bonsai server (a
1138 kind of web-based viewcvs CGI script).
1140 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1141 Hearsum contributed a status plugin which sends email in the same
1142 format that Tinderbox does: this allows a number of tinderbox
1143 tools to be driven by Buildbot instead. Thanks Ben!
1145 2006-09-24 Brian Warner <warner@lothar.com>
1147 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1148 Thanks to Robert Helmer for the patch.
1150 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1151 BuildStatus about the buildslave name at the *beginning* of the
1152 build, rather than at the end. Thanks to Alexander Lorenz for the
1153 patch.
1154 * buildbot/status/html.py (StatusResourceBuild.body): always
1155 include the slavename in the build page, not just when the build
1156 has finished.
1157 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1158 slavename in the email message
1160 2006-09-21 Brian Warner <warner@lothar.com>
1162 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1163 from buildbot.steps
1164 * docs/examples/glib_master.cfg: same
1165 * docs/examples/hello.cfg: same
1166 * docs/examples/twisted_master.cfg: same, update to current usage
1168 2006-09-19 Brian Warner <warner@lothar.com>
1170 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1171 (PyFlakes.createSummary): make it compatible with python-2.2
1173 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1174 for at least the output-parsing parts of PyFlakes
1176 2006-09-18 Brian Warner <warner@lothar.com>
1178 * buildbot/steps/python.py: oops, fix import of StringIO
1180 2006-09-17 Brian Warner <warner@lothar.com>
1182 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1183 turns out that SVN-1.4.0 doesn't fail to update once you've
1184 replaced a file with a directory, unlike older versions of SVN and
1185 pretty much every other VC tool we support. Since what we really
1186 care about is that the update succeeds anyway, stop checking that
1187 the tree got clobbered and just assert that the build succeeded.
1188 (VCBase.printLogs): add a utility function for debugging
1190 * buildbot/process/step.py: oops, added extra imports by mistake
1192 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1193 rstrip() on the first line coming out of the 'p4 describe'
1194 process, to remove the stray ^M that Wade Brainerd reports seeing
1195 in the 'when' field. Fixes SF#1555985.
1197 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1198 message logged when c['schedulers'] is not right
1199 * buildbot/scheduler.py (Scheduler.__init__): improve error
1200 message when a Scheduler() is created with the wrong arguments
1201 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1202 verify that these error messages are emitted
1204 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1205 The idea is that all the base classes (like BuildStep and
1206 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1207 will be a leftover backwards-compatibility file that only contains
1208 aliases for the steps that were moved out to buildbot.steps.*
1209 * lots: change imports to match
1210 * buildbot/process/step.py: add a DeprecationWarning if it ever
1211 gets imported
1213 2006-09-12 Brian Warner <warner@lothar.com>
1215 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1216 builderNames= is actually a sequence, since if you happen to give
1217 it a single builder-specification dictionary instead, it won't get
1218 caught by the existing assert. Thanks to Brett Neely for the
1219 catch.
1221 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1222 tests yet, alas.
1223 * docs/buildbot.texinfo (Python BuildSteps): document them
1224 (sendchange): include a link to PBChangeSource, since you need one
1226 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1227 unnecessary imports
1228 * buildbot/steps/dummy.py: same
1230 2006-09-08 Brian Warner <warner@lothar.com>
1232 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1233 BuildStep which lets you transfer files from the master to the
1234 slave or vice versa. Thanks to Albert Hofkamp for the original
1235 patch. Fixes SF#1504631.
1236 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1237 support for it
1238 (SlaveFileDownloadCommand): same
1239 * docs/buildbot.texinfo (Transferring Files): document it
1240 * buildbot/test/test_transfer.py: test it
1241 * buildbot/test/runutils.py (StepTester): new utility class for
1242 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1243 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1244 utility class works
1246 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1247 walk through StatusLogs one line at a time, mostly for the benefit
1248 of ShellCommand.createSummary methods. You can either walk through
1249 STDOUT or STDERR, but the default is STDOUT.
1251 * buildbot/status/builder.py (LogFile.readlines): implement it.
1252 Note that this is not yet memory-efficient, it just pulls the
1253 whole file into RAM and then splits it up with a StringIO.
1254 Eventually this should be a generator that only pulls chunks from
1255 disk as necessary.
1256 * buildbot/test/test_status.py (Log.testReadlines): test it
1258 * docs/buildbot.texinfo: update to match changes
1259 * buildbot/process/factory.py: stop using old definitions
1260 * buildbot/process/process_twisted.py: same
1261 * buildbot/test/test_*.py: same
1263 * buildbot/process/step_twisted.py: move definition to..
1264 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1265 relative-import mechanisms prevent this from being named 'twisted'
1266 or 'python/twisted' as I would have preferred.
1268 * buildbot/process/maxq.py: move definition to..
1269 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1271 * buildbot/process/step.py: split the user-visible BuildSteps into
1272 separate files, all under buildbot/steps/
1273 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1274 * buildbot/steps/shell.py: this holds ShellCommand and friends
1275 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1277 2006-09-05 Brian Warner <warner@lothar.com>
1279 * lots: run pyflakes, removed a lot of unused imports, changed the
1280 form of some conditional imports to remove false pyflakes
1281 warnings. There are still a number of warnings left, mostly from
1282 imports that are done for their side-effects.
1283 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1284 was missing
1286 2006-08-26 Brian Warner <warner@lothar.com>
1288 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1289 compatible with twisted-1.3.0, for some reason I just can't seem
1290 to let go of the past.
1292 2006-08-25 Brian Warner <warner@lothar.com>
1294 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1296 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1297 all logfiles= in startCommand(), rather than in start() . This
1298 makes it easier to have the 'stdio' log come before any secondary
1299 logfiles, which I feel makes the waterfall display more
1300 understandable.
1301 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1302 from ShellCommand up into LoggingBuildStep
1303 (LoggingBuildStep.__init__): move the handling of logfiles= from
1304 ShellCommand up to LoggingBuildStep, because startCommand is
1305 provided by LoggingBuildStep, whereas start() was specific to
1306 subclasses like ShellCommand and Source. This removes code
1307 duplication in those subclasses.
1308 (ShellCommand.__init__): same
1309 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1310 for a slave that's too old to understand logfiles= into a separate
1311 method, so it can live in ShellCommand. The rest of
1312 setupLogfiles() can live in LoggingBuildStep.
1314 2006-08-24 Brian Warner <warner@lothar.com>
1316 * buildbot/locks.py (BaseLock): you can now configure Locks to
1317 allow multiple simultaneous owners. They still default to
1318 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1319 the patch.
1320 * docs/buildbot.texinfo (Interlocks): document the new options
1321 * buildbot/test/test_locks.py: add a bunch of new unit tests
1322 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1323 waitUntilMaybeAvailable, not waitUntilAvailable
1324 * buildbot/process/step.py (BuildStep.acquireLocks): same
1325 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1326 the whole lockid in their constructor, not just the name. Also,
1327 keep track of which real locks we've handed out by the full
1328 lockid, not just class+name, otherwise changing just the maxCount=
1329 in the master.cfg file would not actually cause a behavioral
1330 change
1332 2006-08-23 Brian Warner <warner@lothar.com>
1334 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1335 releases
1336 * docs/buildbot.texinfo: same
1338 2006-08-23 Brian Warner <warner@lothar.com>
1340 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1341 * docs/buildbot.texinfo: set version to match
1342 * NEWS: update for 0.7.4
1343 * buildbot/slave/commands.py (command_version): mention that this
1344 version (2.1) was released with buildbot-0.7.4
1346 2006-08-22 Brian Warner <warner@lothar.com>
1348 * README: update
1350 * CREDITS: new file, list of people who have helped. Thanks!
1351 * MANIFEST.in: ship it
1353 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1354 new diagrams, the user's manual is more informative than it was.
1355 Start shipping the .html user's manual (and generated .png
1356 images).
1357 * Makefile: update 'release' target to match
1359 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1360 test.. I think the web-parts effort will render it pointless well
1361 before it ever actually starts to work.
1363 2006-08-20 Brian Warner <warner@lothar.com>
1365 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1366 meaning of the prefix= argument. It is now just a string which is
1367 stripped from the beginning of the filename. If prefix= is set but
1368 not found on any given filename, that filename is ignored. If all
1369 filenames in a Change are ignored, the Change is dropped. This is
1370 much simpler than the previous sep= nonsense, and I should have
1371 implemented it this way from the beginning. Effectively resolves
1372 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1373 Gedminas for the catch and suggested fixes.
1374 (ChangePerspective.perspective_addChange): implement the actual
1375 prefix comparison
1376 * buildbot/test/test_changes.py (TestChangePerspective): test it
1377 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1378 how to properly use prefix=
1379 * docs/examples/twisted_master.cfg (source): update prefix= by
1380 adding the trailing slash
1383 * docs/examples/twisted_master.cfg: update to actual practice
1385 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1386 update test case to match new link text.. the HREF has both a
1387 class= setting and an enclosing [] pair that I didn't match in the
1388 test.
1390 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1391 list of strings is preferred over a single string with embedded
1392 spaces
1393 (ShellCommand.description=): explain that either single strings or
1394 a list of strings is acceptable, and why you might prefer one over
1395 the other. Add an example. Fixes SF#1524659, thanks to Paul
1396 Winkler for the catch.
1397 (Build Steps): update to use f.addStep() rather than using s()
1398 and the constructor list
1400 * buildbot/process/step.py (ShellCommand): accept either a single
1401 string or a list of strings in both description= and
1402 descriptionDone=
1403 * buildbot/test/test_steps.py (Steps.test_description): test it
1404 * buildbot/test/runutils.py (makeBuildStep): support for that test
1406 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1407 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1408 collecting the files and creating the patch.
1410 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1411 per-step URLs that will be displayed on the waterfall display,
1412 for things like the HTML output of code-coverage tools, when
1413 the results are hosted elsewhere.
1414 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1415 way to retrieve these URLs
1416 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1417 the method to retrieve these URLs. Also provide backwards
1418 compatibility for saved BuildStepStatus instances that didn't have
1419 the .urls attribute
1420 * buildbot/process/step.py (BuildStep.addURL): method to set these
1421 URLs from within a BuildStep
1422 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1423 (StepBox.getBox): give these external links a distinct CSS class
1424 named "BuildStep external" so a .css file can display them
1425 differently
1427 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1428 do emit those links
1429 * buildbot/test/test_steps.py (Steps): test that we can all the
1430 URLs. Also add a bunch of other tests on methods that can be
1431 called from within BuildSteps
1432 * buildbot/test/runutils.py (makeBuildStep): add utility function
1434 2006-08-13 Brian Warner <warner@lothar.com>
1436 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1438 2006-08-10 Brian Warner <warner@lothar.com>
1440 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1441 index, this one of things like c['sources'] and c['schedulers']
1442 (indices): it looks like my clever idea of putting the @fooindex
1443 commands in between the @node and the @subsection (to make the
1444 HREF anchor jump to slightly above the section title, which works
1445 much better in html) confused texinfo horribly, so I'm moving the
1446 index tags back to be just after the @subsection marker. I also
1447 added extra lines between the @node/@section paragraph and the
1448 index tags, since I think maybe texinfo wants to see these be
1449 separate paragraphs.
1451 * docs/Makefile (images): make sure images get built when
1452 rendering the manual
1453 * docs/images/Makefile: same
1455 * buildbot/scripts/runner.py: rename 'buildbot master' to
1456 'buildbot create-master', and 'buildbot slave' to 'buildbot
1457 create-slave'
1458 * docs/buildbot.texinfo: same
1459 * README: same
1461 * docs/buildbot.texinfo: reimplement the "useful classes" index
1462 with actual texinfo indices. The .info rendering is a bit
1463 weird-looking but it works well, and the HTML rendering is quite
1464 nice. This also puts the index targets in the regular flow of the
1465 text, which is easier to maintain.
1467 2006-08-06 Brian Warner <warner@lothar.com>
1469 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1470 Kevin Turner to prefer the environ= argument be a list rather than
1471 a string. If it is a list, it will be joined with a platform-local
1472 os.pathsep delimiter, and then prepended to any existing
1473 $PYTHONPATH value. This works better in cross-platform (i.e.
1474 windows buildslaves) environments when you need to push multiple
1475 directories onto the front of the path.
1476 (SlaveShellCommand): documented the new magic
1477 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1478 in a user-visible form
1480 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1481 Turner to prefer lists over strings when creating/running VC
1482 commands during unit tests. This is clearly necessary to survive
1483 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1484 renamed the wq() function to qw() though, since that's how it's
1485 spelled in perl. Eventually I'd prefer all commands to be
1486 specified with lists.
1488 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1489 which are deleted (or not yet created) correctly. Also add
1490 failsafe code to not explode if the file-watching poller doesn't
1491 get started. Thanks to JP Calderone for the catch and the poller
1492 patch.
1493 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1494 for that case
1495 * buildbot/test/emitlogs.py: same
1497 * NEWS: summarize recent changes
1499 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1500 clause to avoid the "host key mismatch" warning
1502 * buildbot/process/step_twisted.py (Trial.start): if the
1503 buildslave is too old to understand logfiles=, fall back to
1504 running 'cat _trial_temp/test.log' like before.
1505 (Trial.commandComplete): same. this takes advantage of the
1506 LoggingBuildStep refactoring to stall commandComplete long enough
1507 to run a second RemoteShellCommand.
1509 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1510 refactor command-completion handling, to allow methods like
1511 commandComplete/createSummary/evaluateCommand to return Deferreds.
1512 (LoggingBuildStep._commandComplete): delete the refactored method
1513 (ShellCommand.setupLogfiles): if the buildslave is too old to
1514 understand logfiles=, put a warning message both into twistd.log
1515 and into the otherwise empty user-visible LogFiles.
1517 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1518 callers to provide the slave-side logfile name, rather than
1519 forcing it to come from the local name of the LogFile.
1520 (BuildStep.getSlaveName): new method
1522 * buildbot/process/base.py (Build.getSlaveName): new method, so
1523 steps can find out which buildslave they're running on
1525 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1526 to match the s/cvs_ver/command_version/ change
1528 2006-08-05 Brian Warner <warner@lothar.com>
1530 * buildbot/slave/commands.py (command_version): replace the CVS
1531 auto-updated cvs_ver keyword with a manually-updated variable,
1532 since CVS is no longer the master repository. Add a description of
1533 the remote API change starting in this version (2.1), specifically
1534 the fact that SlaveShellCommand now accepts 'initial_stdin',
1535 'keep_stdin_open', and 'logfiles'.
1537 2006-07-31 Brian Warner <warner@lothar.com>
1539 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1540 diagrams to describe how the whole system fits together. The
1541 images themselves are kept in SVG files, with ascii-art versions
1542 in corresponding .txt files. Texinfo knows how to interpolate the
1543 text version into .info files, reference the .png versions from
1544 .html files, and include .eps versions in the .ps format.
1545 * docs/images/Makefile: tools to create .png and .eps
1546 * docs/images/*.svg: created pictures with Inkscape.
1547 * .darcs-boring: ignore the generated .eps and .png files
1549 2006-07-24 Brian Warner <warner@lothar.com>
1551 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1552 Scheduler names, since they cause setServiceParent to explode
1553 later.
1554 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1556 2006-07-20 Brian Warner <warner@lothar.com>
1558 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1559 which runs the buildbot unit tests
1561 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1562 classes that are useful in master.cfg
1564 2006-07-15 Brian Warner <warner@lothar.com>
1566 * Makefile (some-apidocs): new target to build only some epydocs
1568 * setup.py: minor comment.. does the classifiers= argument prevent
1569 the setup.py script from working on python2.2/2.3?
1571 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1572 major sections
1574 * buildbot/twcompat.py: fix minor typo in comments
1576 * buildbot/manhole.py: move all Manhole-related code out to this
1577 module. Implement SSH-based manholes (with TwistedConch), and move
1578 to conch's nifty line-editing syntax-coloring REPL shell instead
1579 of the boring non-editing monochromatic (and deprecated) old
1580 'telnet' protocol.
1581 * buildbot/master.py: remove all Manhole-related code
1582 (BuildMaster.loadConfig._add): make sure the old manhole is
1583 removed before we add the new one
1584 * docs/buildbot.texinfo (Debug options): document new Manhole options
1586 * buildbot/twcompat.py (_which): fix some epydoc issues
1587 * buildbot/status/html.py (Waterfall.__init__): same
1589 2006-06-29 Brian Warner <warner@lothar.com>
1591 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1592 deprecation warnings under newer Twisteds (by using
1593 zope.interface.Interface instead of old twisted.python.components
1594 stuff)
1595 * buildbot/slave/interfaces.py: same
1597 2006-06-28 Brian Warner <warner@lothar.com>
1599 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1600 svn commands, so it will fail immediately instead of hanging while
1601 it waits for a username/password to be typed in.
1603 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1604 log message if the step was shut down
1606 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1607 obsolete reference to mktap.
1609 2006-06-20 Brian Warner <warner@lothar.com>
1611 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1612 test to include new 'logfiles' argument sent from master to slave
1614 2006-06-19 Brian Warner <warner@lothar.com>
1616 * buildbot/process/step_twisted.py (Trial): track Progress from
1617 _trial_temp/test.log too
1619 * buildbot/process/step.py (OutputProgressObserver): generalize
1620 the earlier StdioProgressObserver into an OutputProgressObserver
1621 that can track LogFiles other than stdio.
1622 (LoggingBuildStep.__init__): same
1624 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1625 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1626 will fail under windows because of os.sep issues. It might have
1627 worked before if 'cat' was doing cygwin path conversion.
1629 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1630 creation of LogFileWatchers
1631 (ShellCommand._startCommand): and record the files that were
1632 watched in the 'headers' section of the ShellCommand output
1634 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1635 need to actually pass it to the slave if you want it to work.
1636 (ShellCommand): document it a bit
1638 * buildbot/test/test_shell.py: new test to validate LogFiles
1639 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1640 test LogFiles
1641 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1642 before printing the last batch of lines, to test that the polling
1643 logic is working properly
1645 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1646 handling, making it possible to track multiple logs for a single
1647 RemoteCommand. The previous single logfile is now known as the
1648 'stdio' log.
1649 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1650 (RemoteShellCommand.__init__): accept logfiles=
1651 (LoggingBuildStep.startCommand): stdio_log is now one of many
1652 (ShellCommand): added logfiles= argument, as well as a class-level
1653 .logfiles attribute, which will be merged together to figure out
1654 which logfiles should be tracked. The latter maybe be useful for
1655 subclasses of ShellCommand which know they will aways produce
1656 secondary logfiles in the same location.
1658 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1659 and closeStdin() methods, preparing to make it possible to write
1660 to a ShellCommand's stdin at any time, not just at startup. These
1661 writes are buffered if the child process hasn't started yet.
1662 (LogFileWatcher): new helper class to watch arbitrary logfiles
1663 while a ShellCommand runs. This class polls the file every two
1664 seconds, and sends back 10k chunks to the buildmaster.
1665 (ShellCommand): rename stdin= to initialStdin=, and add
1666 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1667 at startup.
1668 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1669 key of "log" and a value of (logname, data).
1670 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1671 'logfiles' to the master-visible args dictionary.
1672 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1673 (CVS.start): same
1674 (P4.doVCFull): same
1675 * buildbot/test/test_vc.py (Patch.testPatch): same
1678 * buildbot/test/emit.py: write to a logfile in the current
1679 directory. We use this to figure out what was used as a basedir
1680 rather than looking to see which copy of emit.py gets run, so that
1681 we can run the commands from inside _trial_temp rather than inside
1682 buildbot/test
1683 * buildbot/test/subdir/emit.py: same
1684 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1685 argument rather than running from buildbot/test/
1686 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1687 rather than using an implicit setUp()
1688 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1689 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1690 of assuming that we're running in buildbot/test/ (and that '.' is
1691 on our $PATH)
1693 * buildbot/slave/commands.py (Command.doStart): refactor Command
1694 startup/completion a bit: now the SlaveBuilder calls doStart(),
1695 which is not meant for overridding by subclasses, and doStart()
1696 calls start(), which is. Likewise the SlaveBuilder calls
1697 doInterrupt(), and subclasses override interrupt(). This also puts
1698 responsibility for maintaining .running in Command rather than in
1699 SlaveBuilder.
1700 (Command.doInterrupt): same
1701 (Command.commandComplete): same, this is called when the deferred
1702 returned by start() completes.
1703 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1704 (SlaveBuilder.remote_interruptCommand): same
1705 (SlaveBuilder.stopCommand): same
1707 2006-06-16 Brian Warner <warner@lothar.com>
1709 * buildbot/test/test_shell.py: new test file to contain everything
1710 relating to ShellCommand
1711 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1712 multiple logfiles in realtime" feature, not yet implemented
1713 * buildbot/test/emitlogs.py: support file for testLogFiles
1714 * docs/buildbot.texinfo (ShellCommand): document the feature
1716 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1718 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1719 for tests which exercise SlaveCommands in isolation.
1721 * buildbot/test/test_slavecommand.py: Move some utilities like
1722 SignalMixin and FakeSlaveBuilder from here ..
1723 * buildbot/test/runutils.py: .. to here, so they can be used by
1724 other test classes too
1725 * buildbot/test/test_vc.py: more SignalMixin refactoring
1726 * buildbot/test/test_control.py: same
1727 * buildbot/test/test_run.py: and some rmtree refactoring
1729 2006-06-15 Brian Warner <warner@lothar.com>
1731 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1732 'testBranch' to match other VC tests and have the tests run in
1733 roughly increasing order of dependency
1735 * buildbot/test/test_steps.py (LogObserver): new test to verify
1736 LogObservers can be created at various times and still get
1737 connected up properly
1739 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1740 to create BuildStepStatus instances that actually work.
1742 * buildbot/process/step.py (LogObserver): add outReceived and
1743 errReceived base methods, to be overridden
1745 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1746 API to take a name instead of a step, reducing the coupling
1747 somewhat. This returns the BuildStepStatus object so it can be
1748 passed to the new Step, instead of jamming it directly into the
1749 Step.
1750 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1751 method
1752 * buildbot/process/base.py (Build.setupBuild): use both methods
1753 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1754 process a bit to match
1756 2006-06-14 Brian Warner <warner@lothar.com>
1758 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1759 docs on writing new LogObserver classes
1760 (Writing New Status Plugins): brief docs on how Status Plugins fit
1761 together
1763 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1764 implement a LogObserver that counts how many unit tests have been
1765 run so far
1766 (Trial.__init__): wire it in
1767 * buildbot/test/test_twisted.py (Counter): unit test for it
1769 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1770 to new cmd.logs['stdio'] scheme
1771 (Trial.commandComplete): same
1772 (BuildDebs.commandComplete): same
1774 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1775 LogFiles, instead of just a single one. The old single logfile is
1776 now called "stdio". LoggedRemoteCommand no longer creates a
1777 LogFile for you (the code to do that was broken anyway). If you
1778 don't create a "stdio" LogFile, then stdout/stderr will be
1779 discarded.
1780 (LogObserver): implement "LogObservers", which a BuildStep can add
1781 to parse the output of a command in real-time. The primary use is
1782 to provide more useful information to the Progress code, allowing
1783 better ETA estimates.
1784 (LogLineObserver): utility subclass which feeds complete lines to
1785 the parser instead of bytes.
1786 (BuildStep.progressMetrics): this is safer as a tuple
1787 (BuildStep.setProgress): utility method, meant to be called by
1788 LogObservers
1789 (BuildStep.addLogObserver): new method, to be called at any time
1790 during the BuildStep (even before any LogFiles have been created),
1791 to attach (or schedule for eventual attachment) a LogObserver to a
1792 LogFile.
1793 (StdioProgressObserver): new LogObserver which replaces the old
1794 "output" progress gatherer
1795 (LoggingBuildStep.__init__): same
1796 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1797 (LoggingBuildStep._commandComplete): must use logs['stdio']
1798 instead of the old single ".log" attribute.
1799 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1800 functionality, now subsumed into StdioProgressObserver
1801 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1802 log name changed from "output" to "stdio".
1805 * buildbot/interfaces.py (ILogFile): add the Interface used from
1806 the BuildStep towards the LogFile
1807 (ILogObserver): and the one provided by a LogObserver
1808 * buildbot/status/builder.py (LogFile): implement it
1810 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1811 HEADER constants here ..
1812 * buildbot/status/builder.py (STDOUT): .. from here
1814 2006-06-13 Brian Warner <warner@lothar.com>
1816 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1817 compatibility with python2.2, which doesn't have the 'substr in
1818 str' feature.
1819 (TestP4Poller.makeTime): utility function to construct the
1820 timestamp using the same strptime() approach as p4poller does. It
1821 turns out that time.mktime() behaves slightly differently under
1822 python2.2, probably something to do with the DST flag, and that
1823 causes the test to fail under python2.2. (changing the mktime()
1824 arguments to have dst=0 instead of -1 caused it to fail under
1825 python2.3. Go figure.)
1826 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1828 2006-06-12 Brian Warner <warner@lothar.com>
1830 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1831 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1832 contributing such an excellent patch, including docs and unit
1833 tests! This makes it *so* much easier to apply. I had to update
1834 test_vc.py to handle some recent refactorings, but everything else
1835 applied smoothly. The only remaining thing I'd like to fix would
1836 be to remove the hard-wired port 1666 used by p4d, and allow it to
1837 claim any unused port. This would allow two copies of the test
1838 suite to run on the same host at the same time, as well as
1839 allowing the test suite to run while a real (production) p4d was
1840 running on the same host. Oh, and maybe we should add a warning to
1841 step.P4 that gets emitted if the slave is too old to provide the
1842 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1843 * buildbot/slave/commands.py (P4): same
1844 (P4Sync): same, some minor updates
1845 * buildbot/changes/p4poller.py: same
1846 * docs/buildbot.texinfo: same
1847 * buildbot/test/test_p4poller.py: same
1848 * buildbot/test/test_vc.py (P4): same
1850 * setup.py: add Trove classifiers for PyPI
1852 2006-06-08 Brian Warner <warner@allmydata.com>
1854 * buildbot/status/client.py
1855 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1856 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1857 build needs to be IRemote'd separately, rather than IRemote'ing
1858 the whole list at once. I can't wait until newpb's serialization
1859 adapters make this unnecessary.
1861 2006-06-06 Brian Warner <warner@lothar.com>
1863 * buildbot/process/step.py (WithProperties): make this inherit
1864 from ComparableMixin, so that reloading an unchanged config file
1865 doesn't cause us to spuriously reload any Builders which use them.
1866 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1867 add a test for it
1869 2006-06-03 Brian Warner <warner@lothar.com>
1871 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1872 running py2exe on windows, contributed by Mark Hammond. Addresses
1873 SF#1401121, but I think we still need to include
1874 buildbot/scripts/sample.cfg
1875 * setup.py: include buildbot_service.py as a script under windows
1876 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1877 a py2exe application), get the icon/css datafiles from a different
1878 place than usual.
1880 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1881 double-escape the build URL. Thanks to Olivier Bonnet for the
1882 patch. Fixes SF#1452801.
1884 2006-06-02 Brian Warner <warner@lothar.com>
1886 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1887 first six columns of 'svnlook' output, not just the first column,
1888 since property changes appear in the other five. Thanks to Olivier
1889 Bonnet for the patch. Fixes SF#1398174.
1891 2006-06-01 Brian Warner <warner@lothar.com>
1893 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1894 the fake build, so that title= has something to be set to
1896 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1897 attribute of the "Build #NN" link in the yellow start-the-build
1898 box to the build's reason. This means that you get a little
1899 tooltip explaining why the build was done when you hover over the
1900 yellow box. Thanks to Zandr Milewski for the suggestion.
1902 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1903 (Box.setETA): handle ETA=None (by stopping the timer)
1904 (Box.update): make the [soon] text less different than the usual
1905 text, so the rest of the text doesn't flop around so much. It
1906 would be awfully nice to figure out how to center this stuff.
1907 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1909 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1910 by default, so that any ShellCommand which fails marks the overall
1911 build as a failure. I should have done this from the beginning.
1912 Add flunkOnFailure=False to the arguments if you want to turn off
1913 this behavior.
1915 2006-05-30 Brian Warner <warner@lothar.com>
1917 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1918 last-build/current-build/current-step. Show what step is currently
1919 running. Show ETA for both the overall build and the current step.
1920 Update GTK calls to modern non-deprecated forms. There's still a
1921 lot of dead code and debug noise to remove.
1923 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1924 shows up properly in status displays
1926 2006-05-28 Brian Warner <warner@lothar.com>
1928 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1929 build we use to verify that WithProperties works:
1931 ** set flunkOnFailure=True so that build failures get noticed
1932 ** set workdir='.' so that the build succeeds, otherwise it is trying
1933 to touch 'build/something', and 'build/' doesn't exist because
1934 usually that's created by a Source step
1935 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1936 this test somehow triggers, in which the 'touch' process becomes
1937 a zombie and we wait for th etimeout before giving up on it.
1939 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1940 to log the Build results and step logs to the twisted log.
1941 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1942 what went wrong if a build was expected to succeed but didn't.
1944 * buildbot/process/step_twisted.py (Trial): set the default
1945 trialMode to '--reporter=bwverbose', which specifies verbose
1946 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1947 '-to', but those are completely missing in modern Twisteds.
1949 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1950 a localhost-only port, to encourage better security
1952 * docs/buildbot.texinfo (Change Sources): mention
1953 darcs_buildbot.py
1955 * .darcs-boring: add a Darcs boringfile
1957 * README (REQUIREMENTS): stop claiming compatibility with
1958 Twisted-1.3.0
1960 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1961 sender
1963 2006-05-27 Brian Warner <warner@lothar.com>
1965 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1966 * docs/buildbot.texinfo: same
1968 2006-05-23 Brian Warner <warner@lothar.com>
1970 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1971 * docs/buildbot.texinfo: set version to match
1972 * NEWS: update for 0.7.3
1974 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1975 give a quick mapping from VC system to possible ChangeSources
1976 (Build Properties): add 'buildername'
1978 * buildbot/process/base.py (Build.setupStatus): oops, set
1979 'buildername' and 'buildnumber' properties
1980 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1981 test them
1983 2006-05-22 Brian Warner <warner@lothar.com>
1985 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1986 property interpolation better
1988 * README (INSTALLATION): remove old '-v' argument from recommended
1989 trial command line
1991 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1992 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1993 patch. SF#1475494.
1995 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1996 'svnversion' instead of grepping the output of 'svn info', much
1997 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1998 Bonnet for the suggestion.
1999 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2000 require the WC_PATH argument, so run 'svnversion .' instead.
2002 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2003 aren't supposed to have 'self' in their argument list
2005 2006-05-21 Brian Warner <warner@lothar.com>
2007 * buildbot/process/step.py (ShellCommand.start): make
2008 testInterpolate pass. I was passing the uninterpolated command to
2009 the RemoteShellCommand constructor
2010 (ShellCommand._interpolateProperties): oops, handle non-list
2011 commands (i.e. strings with multiple words separated by spaces in
2012 them) properly, instead of forgetting about them.
2014 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2015 to actually try to use build properties in a real build. This test
2016 fails.
2017 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2018 to start and evaluate builds
2020 * buildbot/test/test__versions.py: add a pseudo-test to record
2021 what version of Twisted/Python/Buildbot are running. This should
2022 show up at the beginning of _trial_tmp/test.log, and exists to help
2023 debug other problems.
2025 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2026 a filename to be served as 'robots.txt' to discourage web spiders.
2027 Adapted from a patch by Tobi Vollebregt, thanks!
2028 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2029 (Waterfall.test_waterfall): tweak the way that filenames are put
2030 into the config file, to accomodate windows pathnames better.
2032 * docs/buildbot.texinfo (HTML Waterfall): document it
2034 * buildbot/process/process_twisted.py
2035 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2036 changed the build process. The new setup.py no longer takes the
2037 'all' argument.
2038 (FullTwistedBuildFactory.__init__): same
2039 (TwistedReactorsBuildFactory.__init__): same
2041 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2042 be placed in the [hooks] section of the central repository (the
2043 one that everybody pushes changes to).
2045 2006-05-20 Brian Warner <warner@lothar.com>
2047 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2048 .darcs-context file, use binary mode. I think this was causing a
2049 Darcs failure under windows.
2051 2006-05-19 Brian Warner <warner@lothar.com>
2053 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2054 use a timezone string of +0000 and gmtime, since this timestamp is
2055 sent to a buildmaster and %z is broken.
2057 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2058 string and localtime, since this timestamp will only be consumed
2059 locally, and %z is broken.
2061 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2062 gmtime, since this timestamp is returned to the buildmaster, and
2063 %z is broken.
2065 2006-05-18 Brian Warner <warner@lothar.com>
2067 * NEWS: update in preparation for next release
2069 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2070 setup-repository and do-we-have-the-vc-tools code into a separate
2071 "helper" class, which sticks around in a single module-level
2072 object. This seems more likely to continue to work in the future
2073 than having it hide in the TestCase and hope that TestCases stick
2074 around for a long time.
2076 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2077 addremove' has been deprecated in recent versions of mercurial, so
2078 use 'hg add' instead
2080 2006-05-07 Brian Warner <warner@lothar.com>
2082 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2083 operating under windows, move the file before opening it, since
2084 you can't rename a file that somebody has open.
2086 * buildbot/process/base.py (Build.setupBuild): if something goes
2087 wrong while creating a Step, log the name and arguments, since the
2088 error message when you get the number of arguments wrong is really
2089 opaque.
2091 2006-05-06 Brian Warner <warner@lothar.com>
2093 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2094 bugs in twisted-specific code not covered by my unit tests, this
2095 time use 'cmd' argument instead of self.cmd
2097 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2098 fix stupid braino: either use startwith or find()==0, not both.
2099 (TwistedReactorsBuildFactory.__init__): another dumb typo
2101 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2102 mark this test as TODO under windows, since process-killing seems
2103 dodgy there. We'll come back to this later and try to fix it
2104 properly.
2106 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2107 and don't include a timezone
2108 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2109 This should avoid the windows-with-verbose-timezone-name problem
2110 altogether.
2111 (Patch.testPatch): add a test which runs 'patch' with less
2112 overhead than the full VCBase.do_patch sequence, to try to isolate
2113 a windows test failure. This one uses slave.commands.ShellCommand
2114 and 'patch', but none of the VC code.
2116 * buildbot/slave/commands.py (getCommand): use which() to find the
2117 executables for 'cvs', 'svn', etc. This ought to help under
2118 windows.
2120 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2121 working directory before starting. If an earlier test failed, the
2122 leftover directory would mistakenly flunk a later test.
2123 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2124 Make sure that we use the right commandlines if which("tla") picks
2125 up "tla.exe" (as it does under windows).
2126 (TlaSupport.do_get): factor out this tla-vs-baz difference
2127 (TlaSupport.vc_create): more tla-vs-baz differences
2129 * buildbot/test/test_slavecommand.py
2130 (ShellBase.testShellMissingCommand): stop trying to assert
2131 anything about the error message: different shells on different
2132 OSes with different languages makes it hard, and it really isn't
2133 that interesting of a thing to test anyway.
2135 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2136 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2137 "Panther"), because it has a bug which flunks a couple tests in
2138 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2139 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2140 able to test that yet.
2142 2006-04-30 Brian Warner <warner@lothar.com>
2144 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2145 make sure child commands emit messages in english, so our regexps
2146 will match. Thanks to Nikaus Giger for identifying the problems.
2147 (VCBase._do_vctest_export_1): mode="export" is not responsible
2148 for setting the "got_revision" property, since in many cases it is
2149 not convenient to determine.
2150 (SVNSupport.capable): when running 'svn --version' to check for
2151 ra_local, we want error messages in english
2152 * buildbot/test/test_slavecommand.py
2153 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2154 to emit the error message in english
2156 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2157 the environment with $LC_ALL="C" so that Commands which need to
2158 parse the output of their child processes can obtain it in
2159 english.
2160 (SVN.parseGotRevision): call "svn info" afterwards instead of
2161 watching the output of the "svn update" or "svn checkout".
2162 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2163 (Arch.parseGotRevision): same
2164 (Bazaar.parseGotRevision): same
2165 (Mercurial.parseGotRevision): same
2167 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2168 $LC_ALL="C" when running commands under 'buildbot try', too
2170 * buildbot/test/__init__.py: remove the global os.environ()
2171 setting, instead we do it just for the tests that run commands and
2172 need to parse their output.
2174 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2175 remove the overly-short .timeout on this test, because non-DNotify
2176 platforms must fall back to polling which happens at 10 second
2177 intervals, so a 5 second timeout would never succeed.
2179 2006-04-24 Brian Warner <warner@lothar.com>
2181 * docs/buildbot.texinfo (Installing the code): update trial
2182 invocation, SF#1469116 by Niklaus Giger.
2183 (Attributes of Changes): updated branch-name examples to be
2184 a bit more realistic, SF#1475240 by Stephen Davis.
2186 * contrib/windows/buildbot2.bat: utility wrapper for windows
2187 developers, contributed by Nick Trout (after a year of neglect..
2188 sorry!). SF#1194231.
2190 * buildbot/test/test_vc.py (*.capable): store the actual VC
2191 binary's pathname in VCS[vcname], so it can be retrieved later
2192 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2193 strip out non-numeric timezone information, specifically the funky
2194 German string that his system produced that confuses CVS.
2195 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2196 allow Darcs tests to work on windows
2197 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2198 procutils.which() everywhere, to allow tryclient to work under
2199 windows. Also from Niklaus Giger, SF#1463394.
2201 * buildbot/twcompat.py (which): move the replacement for a missing
2202 twisted.python.procutils.which from test_vc.py to here, so it can
2203 be used in other places too (specifically tryclient.py)
2205 2006-04-23 Brian Warner <warner@lothar.com>
2207 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2208 bare buildbotURL/projectName line with a proper DIV, along with a
2209 CSS class of "title", from Stefan Seefeld (SF#1461675).
2210 (WaterfallStatusResource.body0): remove the redundant 'table'
2211 class from the table
2212 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2213 to the top-row TR, and class="Activity" to the second-row TR,
2214 rather than putting them in the individual TD nodes.
2216 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2217 'got_revision' build property for all VC systems that implement
2218 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2220 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2221 to determine which revision we actually obtained
2222 (CVS.parseGotRevision): implement this for CVS, which just means
2223 to grab a timestamp. Not ideal, and it depends upon the buildslave
2224 having a clock that is reasonably well syncronized with the server,
2225 but it's better than nothing.
2226 (SVN.parseGotRevision): implement it for SVN, which is accurate
2227 (Darcs.parseGotRevision): same
2228 (Arch.parseGotRevision): same
2229 (Bazaar.parseGotRevision): same
2230 (Mercurial.parseGotRevision): same
2232 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2233 keep a record of all non-stdout/stderr/header/rc status updates,
2234 for the benefit of RemoteCommands that send other useful things,
2235 like got_revision
2236 (Source.commandComplete): put any 'got_revision' status values
2237 into a build property of the same name
2240 * buildbot/process/step_twisted.py (Trial): update to deal with
2241 new ShellCommand refactoring
2243 * docs/buildbot.texinfo (Build Properties): document new feature
2244 that allows BuildSteps to get/set Build-wide properties like which
2245 revision was requested and/or checked out.
2247 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2248 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2249 it. Note that this bumps the persistenceVersion of the saved Build
2250 object, so add the necessary upgrade-old-version logic to include
2251 an empty properties dict.
2253 * buildbot/process/base.py (Build.setProperty): implement it
2254 (Build.getProperty): same
2255 (Build.startBuild): change build startup to set 'branch',
2256 'revision', and 'slavename' properties at the right time
2258 * buildbot/process/step.py (BuildStep.__init__): change setup to
2259 require 'build' argument in a better way
2260 (LoggingBuildStep): split ShellCommand into two pieces, for better
2261 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2262 a single RemoteCommand that sends stdout/stderr status text. It
2263 also provides the usual commandComplete / createSummary /
2264 evaluateCommand / getText methods to be overridden...
2265 (ShellCommand): .. whereas ShellCommand is specifically for
2266 running RemoteShellCommands. Other shell-like BuildSteps (like
2267 Source) can inherit from LoggingBuildStep instead of ShellCommand
2268 (WithProperties): marker class to do build-property interpolation
2269 (Source): inherit from LoggingBuildStep instead of ShellCommand
2270 (RemoteDummy): same
2272 * buildbot/test/test_properties.py: test new functionality
2274 2006-04-21 Brian Warner <warner@lothar.com>
2276 * buildbot/test/test_vc.py: rename testBranch to
2277 testCheckoutBranch to keep the tests in about the right
2278 alphabetical order
2280 2006-04-18 Brian Warner <warner@lothar.com>
2282 * docs/buildbot.texinfo (PBListener): improve cross-references
2283 between PBListener and 'buildbot statusgui', thanks to John Pye
2284 for the suggestion.
2286 2006-04-17 Brian Warner <warner@lothar.com>
2288 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2289 running under Twisted-1.3.0, otherwise skipped tests are reported
2290 as errors.
2292 * all: use isinstance() instead of 'type(x) is foo', suggested by
2293 Neal Norwitz
2295 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2296 oops, fix a brain-fade from the other week, when making the
2297 addStep changes. I changed all the __init__ upcalls to use the
2298 wrong superclass name.
2299 (FullTwistedBuildFactory.__init__): same
2300 (TwistedDebsBuildFactory.__init__): same
2301 (TwistedReactorsBuildFactory.__init__): same
2302 (TwistedBuild.isFileImportant): use .startswith for clarity,
2303 thanks to Neal Norwitz for the suggestions.
2305 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2306 changes, then deliver them over PB to a remote buildmaster.
2308 * contrib/svnpoller.py: added script by John Pye to poll a remote
2309 SVN repository (by running 'svn log') from a cronjob, and run
2310 'buildbot sendchange' to deliver the changes to a remote
2311 buildmaster.
2312 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2313 modification of svnpoller.py), same purpose, but this one loops
2314 internally (rather than expecting to run from a cronjob) and works
2315 under windows.
2316 * contrib/README.txt: same
2318 2006-04-11 Brian Warner <warner@lothar.com>
2320 * all: fix a number of incorrect names and missing imports, thanks
2321 to Anthony Baxter for the patch.
2322 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2323 remove unused buggy method.
2324 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2325 comes from shutil, not "shutils"
2326 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2327 (Arch.checkSlaveVersion): same
2328 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2329 some disabled code
2330 * buildbot/process/step_twisted2.py: add some missing imports
2331 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2332 this code used to live in twisted.internet.defer
2334 2006-04-10 Brian Warner <warner@lothar.com>
2336 * buildbot/process/step.py (Mercurial): add Mercurial support
2337 * buildbot/slave/commands.py (Mercurial): same
2338 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2339 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2340 not yet tested, but 'try' support *is* covered
2341 * docs/buildbot.texinfo (Mercurial): document it
2343 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2344 some debugging messages (turned off)
2345 * buildbot/test/test_vc.py: improve debug messages
2347 2006-04-07 Brian Warner <warner@lothar.com>
2349 * buildbot/test/test_vc.py (which): define our own which() in case
2350 we can't import twisted.python.procutils, because procutils doesn't
2351 exist in Twisted-1.3
2353 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2354 of SlaveLocks for performance tests
2356 * docs/examples/twisted_master.cfg: update to match current usage
2358 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2359 password, p4 binary, pollinterval, maximum history to check.
2360 Patch from an anonymous sf.net contributor, SF#1219384.
2361 * buildbot/process/step.py (P4Sync.__init__): add username,
2362 password, and client arguments.
2363 * buildbot/slave/commands.py (P4Sync): same
2365 2006-04-05 Brian Warner <warner@lothar.com>
2367 * buildbot/process/factory.py (BuildFactory.addStep): new method
2368 to add steps to a BuildFactory. Use it instead of f.steps.append,
2369 and you can probably avoid using the s() convenience function.
2370 Patch from Neal Norwitz, sf.net #1412605.
2371 (other): update all factories to use addStep
2372 * buildbot/process/process_twisted.py: update all factories to use
2373 addStep.
2375 2006-04-03 Brian Warner <warner@lothar.com>
2377 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2378 work under windows too. Adapted from a patch by Niklaus Giger,
2379 addresses SF#1463399.
2381 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2382 spawned commands emit parseable results in english and not some
2383 other language. Patch from Niklaus Giger, SF#1463395.
2385 * README (INSTALLATION): discourage users from running unit tests on
2386 a "network drive", patch from Niklaus Giger, SF#1463394.
2388 2006-03-22 Brian Warner <warner@lothar.com>
2390 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2391 function to turn a repository-relative pathname into a (branch,
2392 branch-relative-filename) tuple. Change this function to handle
2393 the branch naming policy used by your Subversion repository.
2394 Thanks to AllMyData.com for sponsoring this work.
2396 2006-03-16 Brian Warner <warner@lothar.com>
2398 * buildbot/scripts/sample.cfg: add python-mode declaration for
2399 vim. Thanks to John Pye for the patch.
2401 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2402 command line, mention the importance of running 'crontab' as the
2403 buildmaster/buildslave user. Thanks to John Pye for the catch.
2405 2006-03-13 Brian Warner <warner@lothar.com>
2407 * buildbot/status/words.py (IRC): add an optional password=
2408 argument, which will be sent to Nickserv in an IDENTIFY message at
2409 login, to claim the nickname. freenode requires this before the
2410 bot can sent (or reply to) private messages. Thanks to Clement
2411 Stenac for the patch.
2412 * docs/buildbot.texinfo (IRC Bot): document it
2414 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2415 larger than chunkSize. Fixes SF#1349253.
2416 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2417 (Log.testConsumer): update to match new internal chunking behavior
2419 2006-03-12 Brian Warner <warner@lothar.com>
2421 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2423 * buildbot/test/test_maildir.py (MaildirTest): rename the
2424 'timeout' method, as it collides with trial's internals
2426 * buildbot/scripts/runner.py: add 'buildbot restart' command
2427 (stop): don't sys.exit() out of here, otherwise restart can't work
2428 * docs/buildbot.texinfo (Shutdown): document it
2430 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2431 * buildbot/status/html.py (Waterfall.__init__): same
2432 * buildbot/process/builder.py (Builder.startBuild): same
2433 * buildbot/process/base.py (BuildRequest): same
2434 * buildbot/sourcestamp.py (SourceStamp): same
2435 * buildbot/scheduler.py (Nightly): same
2437 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2438 releases
2439 * docs/buildbot.texinfo: same
2441 2006-02-17 Brian Warner <warner@lothar.com>
2443 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2444 * docs/buildbot.texinfo: set version number to match
2445 * NEWS: update for 0.7.2
2447 2006-02-16 Brian Warner <warner@lothar.com>
2449 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2451 2006-02-09 Brian Warner <warner@lothar.com>
2453 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2454 add text to explain per-build branch parameters
2455 * NEWS: mention --umask
2457 2006-02-08 Brian Warner <warner@lothar.com>
2459 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2460 method
2461 (SlaveOptions.optParameters): add --umask, to make it possible to
2462 make buildslave-generated files (including build products) be
2463 world-readable
2464 (slaveTAC): same
2465 * buildbot/slave/bot.py (BuildSlave.startService): same
2467 2006-01-23 Brian Warner <warner@lothar.com>
2469 * buildbot/status/builder.py: urllib.quote() all URLs that include
2470 Builder names, so that builders can include characters like '/'
2471 and ' ' without completely breaking the resulting HTML. Thanks to
2472 Kevin Turner for the patch.
2473 * buildbot/status/html.py: same
2474 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2476 * NEWS: update in preparation for upcoming release
2478 2006-01-18 Brian Warner <warner@lothar.com>
2480 * docs/examples/twisted_master.cfg: update to match the Twisted
2481 buildbot: remove python2.2, switch to exarkun's buildslaves,
2482 disable the .deb builder until we figure out how to build twisted
2483 .debs from SVN, add some ktrace debugging to the OS-X build
2484 process and remove the qt build, remove threadless builders,
2485 change freebsd builder to use landonf's buildslave.
2487 2006-01-12 Brian Warner <warner@lothar.com>
2489 * buildbot/master.py (Manhole.__init__): let port= be a strports
2490 specification string, but handle a regular int for backwards
2491 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2492 used in master.cfg to limit connections to just the local host.
2493 (BuildMaster.loadConfig): same for c['slavePortnum']
2494 * buildbot/scheduler.py (Try_Userpass.__init__): same
2495 * buildbot/status/client.py (PBListener.__init__): same
2496 * buildbot/status/html.py (Waterfall.__init__): same, for both
2497 http_port and distrib_port. Include backwards-compatibility checks
2498 so distrib_port can be a filename string and still mean unix:/foo
2499 * docs/buildbot.texinfo (Setting the slaveport): document it
2500 (Debug options): same
2501 (HTML Waterfall): same
2502 (PBListener): same
2503 (try): same
2504 * buildbot/test/test_config.py (ConfigTest): test it
2506 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2507 slaveport's disownServiceParent deferred to fire before opening
2508 the new one. Fixes an annoying bug in the unit tests.
2510 2006-01-03 Brian Warner <warner@lothar.com>
2512 * buildbot/master.py (BuildMaster): remove the .schedulers
2513 attribute, replacing it with an allSchedulers() method that looks
2514 for all IService children that implement IScheduler. Having only
2515 one parent/child relationship means fewer opportunities for bugs.
2516 (BuildMaster.allSchedulers): new method
2517 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2518 also fix ugly bug that caused any config-file reload to
2519 half-forget about the earlier Schedulers, causing an exception
2520 when a Change arrived and was handed to a half-connected
2521 Scheduler. The exception was in scheduler.py line 54ish:
2522 self.parent.submitBuildSet(bs)
2523 exceptions.AttributeError: 'NoneType' object has no attribute
2524 'submitBuildSet'
2525 (BuildMaster.addChange): update to use allSchedulers()
2527 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2528 to work properly with twisted-1.3.0, where you must explicitly
2529 include the __implements__ from parent classes
2530 (BaseScheduler.__repr__): make it easier to distinguish distinct
2531 instances
2532 (BaseUpstreamScheduler.__implements__): same
2534 * buildbot/status/builder.py (Status.getSchedulers): update to
2535 use allSchedulers()
2536 * buildbot/test/test_run.py (Run.testMaster): same
2537 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2538 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2539 make sure Scheduler instances are left alone when an identical
2540 config file is reloaded
2541 (ConfigElements.testSchedulers): make sure Schedulers are properly
2542 comparable
2544 * Makefile (TRIALARGS): my local default Twisted version is now
2545 2.1.0, update the trial arguments accordingly
2547 2005-12-22 Brian Warner <warner@lothar.com>
2549 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2550 new win32 builders
2552 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2553 addChange in the parent class, although I suspect this should be
2554 fixed better in the future.
2556 2005-11-26 Brian Warner <warner@lothar.com>
2558 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2559 explode when branch==None, thanks to Kevin Turner for the catch
2560 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2561 it
2563 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2564 releases
2565 * docs/buildbot.texinfo: same
2567 2005-11-26 Brian Warner <warner@lothar.com>
2569 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2570 * docs/buildbot.texinfo: set version number to match
2572 2005-11-26 Brian Warner <warner@lothar.com>
2574 * NEWS: update for 0.7.1
2576 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2577 sure that unsubscribe works even if we never sent an ETA update.
2578 Also, don't explode on duplicate unsubscribe.
2579 (BuildStepStatus.addLog): make the convenience "return self"-added
2580 watcher automatically unsubscribe when the Step finishes.
2581 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2582 (BuildStatus.stepStarted): same auto-unsubscribe
2583 (BuilderStatus.buildStarted): same auto-unsubscribe
2585 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2586 auto-unsubscribe
2587 (IStatusReceiver.stepStarted): same
2588 (IStatusReceiver.logStarted): same
2590 * buildbot/test/test_run.py (Status): move the Status test..
2591 * buildbot/test/test_status.py (Subscription): .. to here
2593 2005-11-25 Brian Warner <warner@lothar.com>
2595 * NEWS: more updates
2597 * buildbot/locks.py: fix the problem in which loading a master.cfg
2598 file that changes some Builders (but not all of them) can result
2599 in having multiple copies of the same Lock. Now, the real Locks
2600 are kept in a table inside the BotMaster, and the Builders/Steps
2601 use "LockIDs", which are still instances of MasterLock and
2602 SlaveLock. The real Locks are instances of the new RealMasterLock
2603 and RealSlaveLock classes.
2604 * buildbot/master.py (BotMaster.getLockByID): new method to
2605 convert LockIDs into real Locks.
2606 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2607 into real Locks before building
2608 * buildbot/process/step.py (BuildStep.startStep): same
2609 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2610 exercises the problem
2613 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2614 what Schedulers are available
2616 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2617 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2618 'cron'-style build scheduling at certain times of day, week,
2619 month, or year.
2620 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2622 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2623 handling: treat self.fileIsImportant more as an attribute that
2624 contains a callable than as a method. If the attribute is None,
2625 don't call it and assume all filenames are important. It is still
2626 possible to provide a fileIsImportant method in a subclass,
2627 however.
2628 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2629 was broken
2630 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2631 test using AnyBranchScheduler with fileIsImportant=None
2633 2005-11-24 Brian Warner <warner@lothar.com>
2635 * buildbot/test/test_config.py (StartService): don't claim a fixed
2636 port number, instead set slavePort=0 on the first pass, figure out
2637 what port was allocated, then switch to a config file that uses
2638 the allocated port.
2640 * buildbot/master.py (BuildMaster.loadConfig): close the old
2641 slaveport before opening the new one, because unit tests might
2642 replace slavePort=0 with the same allocated portnumber, and if we
2643 don't wait for the old port to close first, we get a "port already
2644 in use" error. There is a tiny race condition here, but the only
2645 threat is from other programs that bind (statically) to the same
2646 port number we happened to be allocated, and only if those
2647 programs use SO_REUSEADDR, and only if they get control in between
2648 reactor turns.
2650 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2652 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2653 deleted ChangeSources before adding any new ones
2654 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2655 compare_attrs, to make sure that a config-file reload does not
2656 unnecessarily replace an unmodified ChangeSource instance
2657 * buildbot/test/test_config.py (ConfigTest.testSources): update
2659 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2660 mean "don't build anything", and add a warning if it gets used
2661 because it isn't actually useful.
2663 * contrib/svn_buildbot.py: update example usage to match the port
2664 number that gets used by the PBChangeSource
2665 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2667 2005-11-22 Brian Warner <warner@lothar.com>
2669 * NEWS: start collecting items for next release
2671 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2672 revisions are strings
2673 (P4Sync.computeSourceRevision): same
2675 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2676 to the Buildbot's overall status page
2677 (StatusResourceBuilder.body): same
2679 2005-11-15 Brian Warner <warner@lothar.com>
2681 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2682 config-file loading, specifically to make sure old StatusTargets
2683 are finished shutting down before new ones start up (thus
2684 resolving a bug in which changing the Waterfall object would fail
2685 because both new and old instances were claiming the same
2686 listening port). Also load new Schedulers after all the new
2687 Builders are set up, in case they fire off a new build right away.
2688 * buildbot/test/test_config.py (StartService): test it
2690 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2691 the branch name to the mail body
2693 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2694 Without it, a config-file reload fails to update an existing
2695 PBChangeSource.
2696 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2697 username/passwd to compare_attrs, for the same reason
2698 * buildbot/status/html.py (Waterfall): add favicon to
2699 compare_attrs, same reason
2701 2005-11-05 Brian Warner <warner@lothar.com>
2703 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2704 baserev before stuffing it in the jobfile. This resolves problems
2705 under SVN (and probably Arch) where revisions are expressed as
2706 numbers. I'm inclined to use string-based revisions everywhere in
2707 the future, but this fix should be safe for now. Thanks to Steven
2708 Walter for the patch.
2710 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2711 binary mode when opening pickle files, to make windows work
2712 better. Thanks to Dobes Vandermeer for the catch.
2713 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2714 (BuilderStatus.getBuildByNumber): same
2715 (Status.builderAdded): same
2716 * buildbot/master.py (BuildMaster.loadChanges): same
2718 * buildbot/util.py (Swappable): delete unused leftover code
2720 * buildbot/process/step.py (SVN): when building on a non-default
2721 branch, add the word "[branch]" to the VC step's description, so
2722 it is obvious that we're not building the usual stuff. Likewise,
2723 when we are building a specific revision, add the text "rNNN" to
2724 indicate what that revision number is. Thanks to Brad Hards and
2725 Nathaniel Smith for the suggestion.
2726 (Darcs.startVC): same
2727 (Arch.startVC): same
2728 (Bazaar.startVC): same
2730 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2731 typo, caught by Mark Dillavou, closes SF#1216636.
2733 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2734 about a test to add some day
2736 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2737 the 'full-2.3' build, and the 'reactors' build is now run under
2738 python-2.4 because the buildslave no longer has gtk/etc bindings
2739 for earlier versions.
2741 2005-11-03 Brian Warner <warner@lothar.com>
2743 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2744 method, takes an IBuildStatus and rebuilds it. It might make more
2745 sense to add this to IBuildControl instead, but that instance goes
2746 away completely once the build has finished, and resubmitting
2747 builds can take place weeks later.
2748 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2749 * buildbot/status/html.py (StatusResourceBuild): also stash an
2750 IBuilderControl so we can use resubmitBuild.
2751 (StatusResourceBuild.body): render "resubmit" button if we can.
2752 Also add hrefs for each BuildStep
2753 (StatusResourceBuild.rebuild): add action for "resubmit" button
2754 (StatusResourceBuilder.getChild): give it an IBuilderControl
2756 * buildbot/status/builder.py (Status.getURLForThing): change the
2757 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2758 that live as targets of buttons like "stop" and "rebuild" can't
2759 collide with them.
2760 * buildbot/status/builder.py (Status.getURLForThing): same
2761 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2762 (StepBox.getBox): same
2763 * buildbot/test/test_web.py (GetURL): same
2764 (Logfile): same
2766 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2767 exclusivity checks after Source.__init__ upcall, so misspelled
2768 arguments will be reported more usefully
2769 (Darcs.__init__): same
2771 2005-10-29 Brian Warner <warner@lothar.com>
2773 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2774 builder. Move the Try scheduler off to a separate port.
2776 2005-10-27 Brian Warner <warner@lothar.com>
2778 * buildbot/clients/gtkPanes.py
2779 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2780 to cause the app to crash, now they don't.
2782 * buildbot/clients/debug.py: display the buildmaster's location
2783 in the window's title bar
2785 2005-10-26 Brian Warner <warner@lothar.com>
2787 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2788 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2789 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2791 * buildbot/status/html.py (td): put a single non-breaking space
2792 inside otherwise empty <td> elements, as a workaround for buggy
2793 browsers which would optimize them away (along with any associated
2794 styles, like the kind that create the waterfall grid borders).
2795 Patch from Frerich Raabe.
2797 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2798 argv-list as an argument, defaulting to ["-to"], which is
2799 appropriate for the Trial that comes with Twisted-2.1.0 and
2800 earlier. The Trial in current Twisted SVN wants
2801 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2802 defaults to an empty list.
2803 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2804 match it, now that trialMode= is a list instead of a single string
2806 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2807 releases
2808 * docs/buildbot.texinfo: same
2810 2005-10-24 Brian Warner <warner@lothar.com>
2812 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2813 * docs/buildbot.texinfo: set version number to match
2815 2005-10-24 Brian Warner <warner@lothar.com>
2817 * README: update for 0.7.0
2818 * NEWS: same
2819 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2821 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2822 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2823 send the branch= argument unless the user really provided one, to
2824 retain compatibility with older buildmasters that don't accept
2825 that argument.
2826 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2827 same
2829 * docs/buildbot.texinfo: update lots of stuff
2831 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2832 to the 'buildbot sendchange' command
2833 * buildbot/clients/sendchange.py (Sender.send): same
2834 * buildbot/changes/pb.py (ChangePerspective): same
2835 * buildbot/test/test_changes.py (Sender.testSender): test it
2837 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2838 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2839 for consistency with other BuildStep arguments that use camelCase.
2840 Well, at least more of them use camelCase (like flunkOnWarnings)
2841 than don't.. I wish I'd picked one style and stuck with it
2842 earlier. Annoying, but it's best done before the release, since
2843 these arguments didn't exist at all in 0.6.6 .
2844 (Darcs): same
2845 * buildbot/test/test_vc.py (SVN.testCheckout): same
2846 (Darcs.testPatch): same
2847 * docs/buildbot.texinfo (SVN): document the change
2848 (Darcs): same, add some build-on-branch docs
2849 * docs/examples/twisted_master.cfg: match change
2851 * buildbot/process/step.py (BuildStep): rename
2852 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2853 how it is normally used.
2854 * buildbot/test/test_steps.py (Version.checkCompare): same
2856 * buildbot/process/step.py (CVS.startVC): refuse to build
2857 update/copy -style builds on a non-default branch with an old
2858 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2859 concern is that it will do a VC 'update' in an existing tree when
2860 it is supposed to be switching branches (and therefore clobbering
2861 the tree to do a full checkout), thus building the wrong source.
2862 This used to be a warning, but I think the confusion it is likely
2863 to cause warrants making it an error.
2864 (SVN.startVC): same, also make mode=export on old slaves an error
2865 (Darcs.startVC): same
2866 (Git.startVC): improve error message for non-Git-enabled slaves
2867 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2868 specific revision is built on a slave that doesn't pay attention
2869 to args['revision'], because for slowly-changing trees it will
2870 probably do the right thing, and because we have no way to tell
2871 whether we're asking it to build the most recent version or not.
2872 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2874 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2875 that 'master' is in host:portnum format, to catch errors sooner
2877 2005-10-23 Brian Warner <warner@lothar.com>
2879 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2880 when creating the list of warning messages, include the line
2881 immediately after each WARNING: line, since that's usually where
2882 the file and line number wind up.
2884 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2885 TryScheduler
2887 * NEWS: update
2889 2005-10-22 Brian Warner <warner@lothar.com>
2891 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2892 patch from Brad Hards
2893 * buildbot/status/classic.css: same
2894 * buildbot/test/test_web.py (Waterfall): match changes
2896 * buildbot/test/test_steps.py (BuildStep.setUp): set
2897 nextBuildNumber so the test passes
2898 * buildbot/test/test_status.py (MyBuilder): same
2900 * buildbot/status/html.py (StatusResourceBuild.body): revision
2901 might be numeric, so stringify it before html-escapifying it
2902 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2903 timer for the upcoming build
2904 * buildbot/status/classic.css: add background-color attributes for
2905 offline/waiting/building classes
2907 * buildbot/status/builder.py (BuildStatus): derive from
2908 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2909 the default (i.e. unknown) .slavename to "???" instead of None,
2910 since even unknown slavenames need to be printed eventually.
2911 (BuilderStatus): also derive from styles.Versioned . More
2912 importantly, determine .nextBuildNumber at creation/unpickling
2913 time by scanning the directory of saved BuildStatus instances and
2914 choosing one larger than the highest-numbered one found. This
2915 should fix the problem where random errors during upgrades cause
2916 the buildbot to forget about earlier builds. .nextBuildNumber is
2917 no longer stored in the pickle.
2918 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2919 at least log the error. Also call Builder.determineNextBuildNumber
2920 once the basedir is set.
2922 * buildbot/master.py (BuildMaster.loadChanges): do
2923 styles.doUpgrade afterwards, in case I decide to make Changes
2924 derived from styles.Versioned some day and forget to make this
2925 change later.
2928 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2929 when running under older pythons (<2.3) in which the shlex module
2930 doesn't have a 'split' function.
2932 * buildbot/process/step.py (ShellCommand.start): make
2933 errorMessages= be a list of strings to stuff in the log before the
2934 command actually starts. This makes it easier to flag multiple
2935 warning messages, e.g. when the Source steps have to deal with an
2936 old buildslave.
2937 (CVS.startVC): handle slaves that don't handle multiple branches
2938 by switching into 'clobber' mode
2939 (SVN.startVC): same. Also reject branches without base_url
2940 (Darcs.startVC): same. Also reject revision= in older slaves
2941 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2942 (Bazaar.startVC): same, and test for baz separately than for arch
2944 * buildbot/slave/commands.py (cvs_ver): document new features
2946 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2947 (BuildStep.slaveVersionNewEnough): more useful utility method
2948 * buildbot/test/test_steps.py (Version): start testing it
2950 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2951 the 'force' command requires python2.3, for the shlex.split method
2953 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2954 since we don't use it anymore. The Twisted buildbot uses a
2955 PBChangeSource now.
2957 2005-10-21 Brian Warner <warner@lothar.com>
2959 * buildbot/process/process_twisted.py: rework all BuildFactory
2960 classes to take a 'source' step as an argument, instead of
2961 building up the SVN instance in the factory.
2962 * docs/examples/twisted_master.cfg: enable build-on-branch by
2963 providing a base_url and default_branch
2965 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2966 control over --branch and --revision, not that they are always
2967 legal to provide
2968 * buildbot/status/html.py (StatusResourceBuilder.force): same
2969 (StatusResourceBuild.body): display SourceStamp components
2971 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2972 IRC 'force' command, so it can be shared with an eventual
2973 command-line-tool 'buildbot force' mode.
2974 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2976 2005-10-20 Brian Warner <warner@lothar.com>
2978 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2980 * docs/examples/twisted_master.cfg: update to use Schedulers
2982 * buildbot/scripts/sample.cfg: update with Schedulers
2984 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2985 method specifically for use by HTML "force build" button and the
2986 IRC "force" command. Raises an immediate error if there are no
2987 slaves available.
2988 (IBuilderControl.requestBuild): make this just submit a build, not
2989 try to check for existing slaves or set up any when-finished
2990 Deferreds or anything.
2991 * buildbot/process/builder.py (BuilderControl): same
2992 * buildbot/status/html.py (StatusResourceBuilder.force): same
2993 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2994 * buildbot/test/test_slaves.py: same
2995 * buildbot/test/test_web.py: same
2997 2005-10-19 Brian Warner <warner@lothar.com>
2999 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3000 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3002 2005-10-18 Brian Warner <warner@lothar.com>
3004 * buildbot/status/html.py: provide 'status' argument to most
3005 StatusResourceFOO objects
3006 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3007 and Logfiles" section to make the Build page into a more-or-less
3008 comprehensive source of status information about the build
3010 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3011 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3013 2005-10-17 Brian Warner <warner@lothar.com>
3015 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3016 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3017 out what to do about other projects: the correct options for
3018 recent Twisteds will not work for older ones.
3020 2005-10-15 Brian Warner <warner@lothar.com>
3022 * buildbot/status/builder.py (Status.getURLForThing): add method
3023 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3024 use this in email/IRC status clients to make them more useful, by
3025 providing the end user with hints on where to learn more about the
3026 object being reported on.
3027 * buildbot/test/test_web.py (GetURL): tests for it
3029 2005-10-14 Brian Warner <warner@lothar.com>
3031 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3032 fix bug resulting from deferredResult changes
3034 2005-10-13 Brian Warner <warner@lothar.com>
3036 * buildbot/test/test_changes.py: remove use of deferredResult
3037 * buildbot/test/test_config.py: same
3038 * buildbot/test/test_control.py: same
3039 * buildbot/test/test_status.py: same
3040 * buildbot/test/test_vc.py: this is the only remaining use, since
3041 it gets used at module level. This needs to be replaced by some
3042 sort of class-level run-once routine.
3044 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3046 * lots: implement multiple slaves per Builder, which means multiple
3047 current builds per Builder. Some highlights:
3048 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3049 of (state,currentBuilds) instead of (state,currentBuild)
3050 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3051 (IBuildStatus.getSlavename): new method, so you can tell which
3052 slave got used. This only gets set when the build completes.
3053 (IBuildRequestStatus.getBuilds): new method
3055 * buildbot/process/builder.py (SlaveBuilder): add a .state
3056 attribute to track things like ATTACHING and IDLE and BUILDING,
3057 instead of..
3058 (Builder): .. the .slaves attribute here, which has been turned
3059 into a simple list of available slaves. Added a separate
3060 attaching_slaves list to track ones that are not yet ready for
3061 builds.
3062 (Builder.fireTestEvent): put off the test-event callback for a
3063 reactor turn, to make tests a bit more consistent.
3064 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3065 ping fails due to an exception. This needs work, I'm worried that
3066 a code error could lead to a constantly re-connecting slave.
3067 Especially since I'm trying to move to a distinct remote_ping
3068 method, separate from the remote_print that we currently use.
3069 (BuilderControl.requestBuild): return a convenience Deferred that
3070 provides an IBuildStatus when the build finishes.
3071 (BuilderControl.ping): ping all connected slaves, only return True
3072 if they all respond.
3074 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3075 reconnect when we shut down.
3077 * buildbot/status/builder.py: implement new methods, convert
3078 one-build-at-a-time methods to handle multiple builds
3079 * buildbot/status/*.py: do the same in all default status targets
3080 * buildbot/status/html.py: report the build's slavename in the
3081 per-Build page, report all buildslaves on the per-Builder page
3083 * buildbot/test/test_run.py: update/create tests
3084 * buildbot/test/test_slaves.py: same
3085 * buildbot/test/test_scheduler.py: remove stale test
3087 * docs/buildbot.texinfo: document the new builder-specification
3088 'slavenames' parameter
3090 2005-10-12 Brian Warner <warner@lothar.com>
3092 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3093 report failure correctly, causing Dependent builds to run when
3094 they shouldn't have.
3095 * buildbot/status/builder.py (BuildSetStatus): same
3096 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3097 (Set.testSuccess): test the both-pass case too
3098 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3099 fix this test: it was ending too early, masking the failure before
3100 (Logger): specialized StatusReceiver to make sure the dependent
3101 builds aren't even started, much less completed.
3103 2005-10-07 Brian Warner <warner@lothar.com>
3105 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3106 bot.SlaveBuilder being disowned in the middle of a build
3108 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3109 this inherit from StatusReceiver. Also upcall in __init__. This
3110 fixes the embarrasing crash when the new buildSetSubmitted method
3111 is invoked and Waterfall/etc don't implement their own.
3112 * buildbot/test/test_run.py: add a TODO note about a test to catch
3113 just this sort of thing.
3115 * buildbot/process/builder.py (Builder.attached): remove the
3116 already-attached warning, this situation is normal. Add some
3117 comments explaining it.
3119 2005-10-02 Brian Warner <warner@lothar.com>
3121 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3122 OverflowError when setting up dnotify, because some 64-bit systems
3123 have problems with signed-vs-unsigned constants and trip up on the
3124 DN_MULTISHOT flag. Patch from Brad Hards.
3126 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3128 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3129 progressMetrics, description, descriptionDone to the 'parms' list,
3130 and make use the 'parms' list from the implementation class
3131 instead of only BuildStep to initialize the parameters. This
3132 allows buildbot.process.factory.s() to initialize all the parms,
3133 not just those defined in directly by BuildStep.
3135 2005-09-03 Brian Warner <warner@lothar.com>
3137 * NEWS: start adding items for the next release
3139 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3140 python2.2 tests, change 'Quick' builder to only use python2.3
3142 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3144 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3145 the "Ping Builder" button if the build control is available; the
3146 user sees an exception otherwise
3148 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3150 2005-09-01 Brian Warner <warner@lothar.com>
3152 * buildbot/interfaces.py (IBuilderStatus.getState): update
3153 signature, point out that 'build' can be None
3154 (IBuildStatus.getETA): point out ETA can be none
3156 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3157 being None
3158 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3160 2005-08-31 Brian Warner <warner@lothar.com>
3162 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3163 update to match correct signature: removed 'eta' argument
3164 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3166 2005-08-30 Brian Warner <warner@lothar.com>
3168 * buildbot/status/builder.py (LogFile): remove the assertion that
3169 blows up when you try to overwrite an existing logfile, instead
3170 just emit a warning. This case gets hit when the buildmaster is
3171 killed and doesn't get a chance to write out the serialized
3172 BuilderStatus object, so the .nextBuildNumber attribute gets out
3173 of date.
3175 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3176 the 'buildbot sendchange' arguments, for the Darcs context file
3177 * docs/buildbot.texinfo (sendchange): document it
3179 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3180 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3181 (IStatus.getSchedulers): new method
3182 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3183 (Status.getSchedulers): implement
3184 * buildbot/process/builder.py (Builder): maintain
3185 BuilderStatus.pendingBuilds
3186 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3187 (TryBase.addChange): Try schedulers should ignore Changes
3189 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3190 for 'try' on CVS/SVN
3191 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3193 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3194 report status properly.
3195 (Try.createJob): implement unique buildset IDs
3197 * buildbot/status/client.py (StatusClientPerspective): add a
3198 perspective_getBuildSets method for the benefit of jobdir-style
3199 'try'.
3200 * docs/buildbot.texinfo (try): more docs
3201 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3202 new test case
3204 2005-08-18 Brian Warner <warner@lothar.com>
3206 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3207 actually work. It's functional but still kind of clunky. Also, it
3208 only works with the pb-style.. needs to be made to work with the
3209 jobdir-style too.
3211 * buildbot/status/client.py (RemoteBuildSet): new class
3212 (RemoteBuildRequest): same
3213 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3214 object, not the internal BuildStatus object.
3215 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3216 outside of the usual buildStarted() return value.
3217 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3219 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3220 (Try_Userpass_Perspective.perspective_try): return a remotely
3221 usable BuildSetStatus object
3223 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3224 isStarted()/waitUntilStarted()
3226 2005-08-16 Brian Warner <warner@lothar.com>
3228 * buildbot/status/builder.py: implement IBuildSetStatus and
3229 IBuildRequestStatus, wire them into place.
3230 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3231 methods into the BuildSetStatus object.
3232 * buildbot/interfaces.py: same
3233 (IStatus.getBuildSets): new method to get pending BuildSets
3234 (IStatusReceiver.buildsetSubmitted): new method which hears about
3235 new BuildSets
3236 * buildbot/master.py (BuildMaster.submitBuildSet): same
3237 * buildbot/process/base.py (BuildRequest): same, replace
3238 waitUntilStarted with subscribe/unsubscribe
3239 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3240 subscribe instead of waitUntilStarted
3241 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3242 for new method
3243 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3244 same
3245 * buildbot/test/test_buildreq.py: update for new code
3246 * buildbot/test/test_control.py (Force.testRequest): same
3249 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3250 for Darcs to not use the tempfile module, so it works under
3251 python-2.2 too. We really didn't need the full cleverness of that
3252 module, since the slave has exclusive control of its own builddir.
3254 2005-08-15 Brian Warner <warner@lothar.com>
3256 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3257 for CVS trees. It doesn't work for non-trunk branches,
3258 unfortunately.
3259 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3260 branch test
3262 * Makefile: make it easier to test against python2.2
3264 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3265 tearDown2, so things like Arch can unregister archives as they're
3266 shutting down. The previous subclass-override-tearDown technique
3267 resulted in a nested maybeWait() and test failures under
3268 Twisted-1.3.0
3270 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3271 where we can (Arch), add a branch= argument to set the branch used
3272 when we can't
3273 (BazExtractor): extract the branch too
3274 (TlaExtractor): same
3275 * buildbot/scripts/runner.py (TryOptions): add --branch
3276 * docs/buildbot.texinfo (try): document --branch/try_branch
3278 * buildbot/slave/commands.py (Darcs): implement get-revision for
3279 Darcs, so that 'try' will work. This requires the tempfile module
3280 from python-2.3 .
3282 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3283 of revisions, branches, and 'try' in the process.
3285 2005-08-11 Brian Warner <warner@lothar.com>
3287 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3288 this, it got broken at some point in the last few releases
3289 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3290 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3291 specifically the removal of ETA information from the tuple
3293 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3294 warning message
3296 * docs/buildbot.texinfo (try): document both --builder and
3297 'try_builders' in .buildbot/options
3298 * buildbot/scripts/runner.py (TryOptions): add --builder,
3299 accumulate the values into opts['builders']
3300 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3301 * buildbot/test/test_runner.py (Try): add some quick tests to make
3302 sure 'buildbot try --options' and .buildbot/options get parsed
3303 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3304 use --builder control
3306 * docs/buildbot.texinfo (try): add --port argument to PB style
3308 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3309 actual SourceStamp. Still need to extract a branch name, somehow.
3310 (Try): finish implementing the try client side, still need a UI
3311 for specifying which builders to use
3312 (Try.getopt): factor our options/config-file reading
3313 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3314 test it
3315 * buildbot/test/test_vc.py: match SourceStampExtractor change
3317 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3318 causes the twisted log to be sent to stderr
3320 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3322 2005-08-10 Brian Warner <warner@lothar.com>
3324 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3325 style is 90% done, still missing status reporting or waiting for
3326 the buildsets to finish, and it is completely untested.
3328 * buildbot/trybuild.py: delete file, move contents to ..
3329 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3330 * buildbot/test/test_vc.py: match the move
3332 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3333 of the TryScheduler, no buildsetID or status-tracking support yet
3334 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3336 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3337 possible to set the basedir after __init__ time, so it is easier
3338 to use as a Service-child of the BuildMaster instance
3340 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3341 that delivers messages to its Service parent instead of requiring
3342 a subclass to be useful. This turns out to be much easier to build
3343 unit tests around.
3345 * buildbot/scripts/tryclient.py (createJob): utility code to
3346 create jobfiles, will eventually be used by 'buildbot try'
3348 2005-08-08 Brian Warner <warner@lothar.com>
3350 * docs/buildbot.texinfo (try): add docs on the
3351 as-yet-unimplemented Try scheduler
3353 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3354 * buildbot/test/test_scheduler.py: .. here
3355 (Scheduling.testTryJobdir): add placeholder test for 'try'
3357 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3358 addEntry merging (>=chunkSize) behavior
3359 (Log.testConsumer): update to handle new callLater(0) behavior
3361 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3362 both the MAX_LENGTH bugfix and the resumeProducing hang.
3364 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3365 put off the actual resumeProducing for a moment with
3366 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3367 causes large logfiles to hang midway through.
3369 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3370 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3371 and to improve memory usage when streaming the file out to a web
3372 browser.
3373 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3374 make this work cleanly
3376 2005-08-03 Brian Warner <warner@lothar.com>
3378 * buildbot/trybuild.py: new file for 'try' utilities
3379 (getSourceStamp): run in a tree, find out the baserev+patch
3380 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3381 implemented for SVN and Darcs, still working on Arch. I don't know
3382 how to make CVS work yet.
3384 * docs/buildbot.texinfo: document the 'buildbot' command-line
3385 tool, including the not-yet-implemented 'try' feature, and the
3386 in-flux .buildbot/ options directory.
3388 2005-07-20 Brian Warner <warner@lothar.com>
3390 * buildbot/locks.py: added temporary id() numbers to Lock
3391 descriptions, to track down a not-really-sharing-the-Lock bug
3393 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3395 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3396 needed for python2.2 compatibility
3397 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3398 are from the __future__
3400 2005-07-19 Brian Warner <warner@lothar.com>
3402 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3403 message when schedulers use unknown builders
3405 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3406 SlaveLock('name') and MasterLock('name') are distinct
3408 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3409 c['schedulers'] in such a way that we can actually accept
3410 Dependent instances
3411 * buildbot/test/test_config.py: check it
3413 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3414 utility method to *all* the Schedulers
3415 (Periodic.listBuilderNames): same
3417 * docs/buildbot.texinfo (Interlocks): update chapter to match
3418 reality
3420 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3421 to make sure that c['sources'], c['schedulers'], and c['status']
3422 are all lists of the appropriate objects, and that the Schedulers
3423 all point to real Builders
3424 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3425 'listBuilderNames' utility method to support this
3426 * buildbot/scheduler.py: implement the utility method
3427 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3429 * docs/buildbot.texinfo: add some @cindex entries
3431 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3432 if it wasn't already set: most tla commands will fail unless one
3433 has been set.
3434 (Arch.createRepository): and disable bazaar's revision cache, since
3435 they cause test failures (the multiple repositories we create all
3436 interfere with each other through the cache)
3438 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3439 bring it properly up to date with twisted-2.0 test guidelines
3441 * buildbot/master.py (BuildMaster): remove references to old
3442 'interlock' module, this caused a bunch of post-merge test
3443 failures
3444 * buildbot/test/test_config.py: same
3445 * buildbot/process/base.py (Build): same
3447 * buildbot/test/test_slaves.py: stubs for new test case
3449 * buildbot/scheduler.py: add test-case-name tag
3450 * buildbot/test/test_buildreq.py: same
3452 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3453 unnecessary init code
3454 (Bot.remote_setBuilderList): match it
3456 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3458 * buildbot/changes/mail.py (parseSyncmail): update comment
3460 * buildbot/test/test_slavecommand.py: disable Shell tests on
3461 platforms that don't suport IReactorProcess
3463 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3464 all places where we open logfiles. It causes OS-X to open the file
3465 in some weird mode that that prevents us from mixing reads and
3466 writes to the same filehandle, which we depend upon to implement
3467 _generateChunks properly. This change doesn't appear to break
3468 win32, on which "b" and "t" are treated differently but a missing
3469 flag seems to be interpreted as "t".
3471 2005-07-18 Brian Warner <warner@lothar.com>
3473 * buildbot/slave/commands.py (ShellCommand): overhaul
3474 error-handling code, to try and make timeout/interrupt work
3475 properly, and make win32 happier
3476 * buildbot/test/test_slavecommand.py: clean up, stop using
3477 reactor.iterate, add tests for timeout and interrupt
3478 * buildbot/test/sleep.py: utility for a new timeout test
3480 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3481 code from the local-usebranches branch
3483 2005-07-17 Brian Warner <warner@lothar.com>
3485 * buildbot/process/process_twisted.py
3486 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3487 minutes, to match the other twisted BuildFactories, and don't
3488 excuse failures in c/qt/win32 reactors any more.
3490 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3491 'freebsd' builders, since the buildslaves have been unavailable
3492 for quite a while
3494 2005-07-13 Brian Warner <warner@lothar.com>
3496 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3497 build-on-branch feature
3499 * buildbot/process/step.py (Darcs.__init__): add base_url and
3500 default_branch arguments, just like SVN
3501 (Arch.__init__): note that the version= argument is really the
3502 default branch name
3504 * buildbot/slave/commands.py (SourceBase): keep track of the
3505 repository+branch that was used for the last checkout in
3506 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3507 match, we clobber the directory and perform a fresh checkout
3508 rather than trying to do an in-place update. This should protect
3509 us against trying to get to branch B by doing an update in a tree
3510 obtained from branch A.
3511 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3512 (SVN.setup): same, just the svnurl
3513 (Darcs.setup): same, just the repourl
3514 (Arch.setup): same, arch coordinates (url), version, and
3515 buildconfig. Also pull the buildconfig from the args dictionary,
3516 which we weren't doing before, so the build-config was effectively
3517 disabled.
3518 (Arch.sourcedirIsUpdateable): don't try to update when we're
3519 moving to a specific revision: arch can't go backwards, so it is
3520 safer to just clobber the tree and checkout a new one at the
3521 desired revision.
3522 (Bazaar.setup): same sourcedata as Arch
3524 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3525 use maybeWait, to work with twisted-1.3.0 and twcompat
3526 (Dependencies.testRun_Pass): same
3528 * buildbot/test/test_vc.py: rearrange, cleanup
3530 * buildbot/twcompat.py: add defer.waitForDeferred and
3531 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3532 can work under twisted-1.3.0 .
3534 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3535 now created at setUp time. This increases the runtime of the test
3536 suite considerably (from 91 seconds to 151), but it removes the
3537 need for an offline tarball, which should solve a problem I've
3538 seen where the test host has a different version of svn than the
3539 tarball build host. The new code also validates that mode=update
3540 really picks up recent commits. This approach will also make it
3541 easier to test out branches, because the code which creates the VC
3542 branches is next to the code which uses them. It will also make it
3543 possible to test some change-notification hooks, by actually
3544 performing a VC commit and watching to see the ChangeSource get
3545 notified.
3547 2005-07-12 Brian Warner <warner@lothar.com>
3549 * docs/buildbot.texinfo (SVN): add branches example
3550 * docs/Makefile (buildbot.ps): add target for postscript manual
3552 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3553 * buildbot/test/test_locks.py: same
3555 * buildbot/process/step.py (Darcs): comment about default branches
3557 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3558 c['interlocks'] in the config file, complain if it is present.
3559 Scan all locks in c['builders'] to make sure the Locks they use
3560 are uniquely named.
3561 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3562 add some tests to check for non-uniquely-named Locks
3563 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3564 since the unique-Lock validation code requires it now
3566 * buildbot/locks.py: fix test-case-name
3568 * buildbot/interlock.py: remove old file
3570 2005-07-11 Brian Warner <warner@lothar.com>
3572 * buildbot/test/test_interlock.py: rename to..
3573 * buildbot/test/test_locks.py: .. something shorter
3575 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3576 versions (after 2.0.1) changed internet.TCPClient to shut down the
3577 connection in stopService. Change the code to handle this
3578 gracefully.
3580 * buildbot/process/base.py (Build): handle whole-Build locks
3581 * buildbot/process/builder.py (Builder.compareToSetup): same
3582 * buildbot/test/test_interlock.py: make tests work
3584 * buildbot/process/step.py (BuildStep.startStep): complain if a
3585 Step tries to claim a lock that's owned by its own Build
3586 (BuildStep.releaseLocks): typo
3588 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3589 file reloads don't replace unchanged Builders
3590 (SlaveLock): same
3591 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3592 rewrite to cover new Locks instead of old c['interlocks']
3593 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3594 slave2 too
3597 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3598 start the master and connect the buildslave
3600 * buildbot/process/step.py (FailingDummy.done): finish with a
3601 FAILURE status rather than raising an exception
3603 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3604 stringify a BuildRequest.reason that is None
3606 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3607 minor fix
3608 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3609 allow scheduler.Dependent to work
3610 * buildbot/buildset.py (BuildSet): set .reason and .results
3612 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3613 slaves, to make the test stop hanging. It still fails, of course,
3614 because I haven't even started to implement Locks.
3616 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3618 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3619 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3620 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3621 (Dependent): new class for downstream build dependencies
3622 * buildbot/test/test_dependencies.py: tests (still failing)
3624 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3626 2005-07-07 Brian Warner <warner@lothar.com>
3628 * buildbot/test/runutils.py (RunMixin): factored this class out..
3629 * buildbot/test/test_run.py: .. from here
3630 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3631 added new buildbot.locks tests (which all hang right now)
3632 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3633 * buildbot/process/step.py: claim/release per-BuildStep locks
3635 * docs/Makefile: add 'buildbot.html' target
3637 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3638 interpreted as "HEAD", so that all VC steps can accept branch=None
3639 and have it mean the "default branch".
3641 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3643 2005-07-07 Brian Warner <warner@lothar.com>
3645 * docs/examples/twisted_master.cfg: update to match current usage
3647 * docs/buildbot.texinfo (System Architecture): comment out the
3648 image, it doesn't exist yet and just screws up the HTML manual.
3650 2005-07-05 Brian Warner <warner@lothar.com>
3652 * debian/.cvsignore: oops, missed one. Removing leftover file.
3654 2005-06-17 Brian Warner <warner@lothar.com>
3656 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3657 changed its output in 1.2.0, don't mistakenly think that the
3658 subversion we find isn't capable of supporting our tests.
3660 * debian/*: remove the debian/ directory and its contents, to make
3661 life easier for the proper Debian maintainer
3662 * MANIFEST.in: same
3663 * Makefile (release): same
3665 2005-06-07 Brian Warner <warner@lothar.com>
3667 * everything: create a distinct SourceStamp class to replace the
3668 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3669 Changed the signature of Source.startVC to include the revision
3670 information (instead of passing it through self.args). Implement
3671 branches for SVN (now only Darcs/Git is missing support). Add more
3672 Scheduler tests.
3674 2005-06-06 Brian Warner <warner@lothar.com>
3676 * everything: rearrange build scheduling. Create a new Scheduler
3677 object (configured in c['schedulers'], which submit BuildSets to a
3678 set of Builders. Builders can now use multiple slaves. Builds can
3679 be run on alternate branches, either requested manually or driven
3680 by changes. This changed some of the Status classes. Interlocks
3681 are out of service until they've been properly split into Locks
3682 and Dependencies. treeStableTimer, isFileImportant, and
3683 periodicBuild have all been moved from the Builder to the
3684 Scheduler.
3685 (BuilderStatus.currentBigState): removed the 'waiting' and
3686 'interlocked' states, removed the 'ETA' argument.
3688 2005-05-24 Brian Warner <warner@lothar.com>
3690 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3691 erroneously abandons the connection (in clientConnectionFailed)
3692 for non-UserErrors, which means that if we lose the connection due
3693 to a network problem or a timeout, we'll never try to reconnect.
3694 Fix this by not upcalling to the buggy parent method. Note:
3695 twisted-2.0 fixes this, but the function only has 3 lines so it
3696 makes more sense to copy it than to try and detect the buggyness
3697 of the parent class. Fixes SF#1207588.
3699 * buildbot/changes/changes.py (Change.branch): doh! Add a
3700 class-level attribute to accomodate old Change instances that were
3701 pickled before 0.6.5 (where .branch was added for new Changes).
3702 This fixes the exception that occurs when you try to look at an
3703 old Change (through asHTML).
3705 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3706 releases
3708 2005-05-23 Brian Warner <warner@lothar.com>
3710 * buildbot/__init__.py (version): release 0.6.6
3712 2005-05-23 Brian Warner <warner@lothar.com>
3714 * NEWS: update for 0.6.6 release
3715 * debian/changelog: same
3717 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3718 before starting: this was done by twistd back when we spawned it,
3719 now that we're importing the pieces and running them in the
3720 current process, we have to do it ourselves. This allows
3721 master.cfg to import files from the same directory without
3722 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3723 Stichele for the catch.
3724 (Options.opt_version): Add a --version command (actually, just make
3725 the existing --version command emit Buildbot's version too)
3727 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3728 fix to make this behave like other LogFiles, this time to handle
3729 existing LogFiles on disk. (add the missing .upgrade method)
3730 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3732 2005-05-21 Brian Warner <warner@lothar.com>
3734 * buildbot/test/test_runner.py (Create.testMaster): match the
3735 rawstring change in runner.py:masterTAC
3737 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3738 TwistedWords is installed
3739 * buildbot/test/test_status.py: same, with TwistedMail
3741 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3742 some old, deprecated, and removed config keys). This should enable
3743 you to use the base buildbot functionality with Twisted-2.0.0 when
3744 you don't also have TwistedWeb and TwistedWords installed
3746 2005-05-20 Brian Warner <warner@lothar.com>
3748 * buildbot/scripts/runner.py (run): call sendchange(), not
3749 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3750 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3751 (stop): don't wait for process to die when sending SIGHUP
3752 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3753 directory name gets interpreted, which you don't want
3754 (slaveTAC): same
3756 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3757 releases
3759 2005-05-18 Brian Warner <warner@lothar.com>
3761 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3763 2005-05-18 Brian Warner <warner@lothar.com>
3765 * README: update for 0.6.5
3766 * debian/changelog: same
3768 * buildbot/changes/changes.py: rename tag= to branch=, since
3769 that's how we're using it, and my design for the upcoming "build a
3770 specific branch" feature wants it. also, tag= was too CVS-centric
3771 * buildbot/changes/mail.py (parseSyncmail): same
3772 * buildbot/process/base.py (Build.isBranchImportant): same
3773 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3774 * docs/buildbot.texinfo (Attributes of Changes): same
3776 * NEWS: update tag=, update for upcoming release
3778 2005-05-17 Brian Warner <warner@lothar.com>
3780 * buildbot/scripts/runner.py (stop): actually poll once per
3781 second, instead of re-killing the poor daemon once per second.
3782 Sleep briefly (0.1s) before the first poll, since there's a good
3783 chance we can avoid waiting the full second if the daemon shuts
3784 down quickly. Also remove the sys.exit() at the end.
3785 (start): remove the unneighborly sys.exit()
3787 * Makefile: improve permission-setting to not kick Arch so badly
3789 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3790 default --keepalive=600, since it doesn't hurt very much, and it's
3791 a hassle to discover that you need it.
3792 * buildbot/test/test_runner.py (Create.testSlave): test it
3794 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3795 IRC bot about EXCEPTION
3797 * buildbot/status/client.py (PBListener): upcall more correctly
3799 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3800 an exception mark the overall build with EXCEPTION, not SUCCESS
3802 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3803 newline
3804 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3805 * Makefile: update some release-related stuff
3807 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3808 gets called when there isn't actually an active process, just end
3809 the Command instead of blowing up. I don't know how it gets into
3810 this state, but the twisted win32 buildslave will sometimes hang,
3811 and when it shakes its head and comes back, it thinks it's still
3812 running a Command. The next build causes this command to be
3813 interrupted, but the lack of self.process.pid breaks the interrupt
3814 attempt.
3816 * NEWS: document changes since the last release
3818 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3819 look for Makefile.buildbot instead of a bare Makefile . The
3820 'buildbot start' does not install this file, so you have to
3821 manually copy it if you want to customize startup behavior.
3822 (createMaster): change 'buildbot master' command to create
3823 Makefile.sample instead of Makefile, to create master.cfg.sample
3824 instead of master.cfg (requiring you to copy it before the
3825 buildmaster can be started). Both sample files are kept up to
3826 date, i.e. they are overwritten if they have been changed. The
3827 'buildbot.tac' file is *not* overwritten, but if the new contents
3828 don't match the old, a 'buildbot.tac.new' file is created and the
3829 user is warned. This seems to be a much more sane way to handle
3830 startup files. Also, don't sys.exit(0) when done, so we can run
3831 unit tests against it.
3832 (createSlave): same. Don't overwrite the sample info/ files.
3833 * buildbot/scripts/sample.mk: remove. the contents were pulled
3834 into runner.py, since they need to match the behavior of start()
3835 * setup.py: same
3836 * MANIFEST.in: same
3838 * docs/buildbot.texinfo (Launching the daemons): document it
3839 * buildbot/test/test_runner.py (Create): test it
3841 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3842 version that can handle string-in-string tests, because otherwise
3843 python-2.2 fails the tests. It'd be tremendous if Trial's test
3844 took two strings under 2.2 too.
3846 * everything: fixed all deprecation warnings when running against
3847 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3848 few that come from Twisted itself). This involved putting most of
3849 the Twisted-version specific code in the new buildbot.twcompat
3850 module, and creating some abstract base classes in
3851 buildbot.changes.base and buildbot.status.base (which might be
3852 useful anyway). __implements__ is a nuisance and requires an ugly
3853 'if' clause everywhere.
3855 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3856 delay before finishing the test: it seems that smtp.sendmail
3857 doesn't hang up on the server, so we must wait a moment so it can
3858 hang up on us. This removes the trial warning about an unclean
3859 reactor.
3861 2005-05-16 Brian Warner <warner@lothar.com>
3863 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3864 tuple of (delay, repeats).
3865 * buildbot/test/test_vc.py (Retry): test it
3866 * docs/buildbot.texinfo (Source Checkout): document it
3867 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3868 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3869 doVCFull() are handled by re-trying the checkout (after a delay)
3870 some number of times.
3871 (ShellCommand._startCommand): make header lines easier to read
3873 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3874 shutdown
3875 (WebTest.test_logfile): make sure master gets shut down, silences
3876 some "unclean reactor" test errors
3878 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3879 reactor once after shutdown, something in certain versions of
3880 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3881 fails, svn-trunk is ok.
3883 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3884 second win32 error message
3886 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3887 validating the ETA, so the tests don't fail on slow systems
3889 2005-05-15 Brian Warner <warner@lothar.com>
3891 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3892 the new LogFile class, so upgrading works properly
3893 (LogFileProducer.resumeProducing): survive resumeProducing after
3894 we've exhausted the chunkGenerator
3896 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3897 logs too
3898 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3899 (Log.testUpgrade): same
3901 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3902 Builds and logs with a cron job.
3904 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3905 of the old non-offline LogFile, added code to upgrade these to
3906 new-style contents-live-on-disk instances at load time (in a way
3907 that doesn't invalidate the old Build pickles, so upgrading to
3908 0.6.5 is not a one-way operation). Got rid of everything related
3909 to 'stub' builds.
3910 (LogFile.__init__): create LogFiles with the parent step status,
3911 the log's name, and a builder-relative filename where it can keep
3912 the contents on disk.
3913 (LogFile.hasContents): new method, clients are advised to call it
3914 before getText or getChunks and friends. If it returns False, the
3915 log's contents have been deleted and getText() will raise an
3916 error.
3917 (LogFile.getChunks): made it a generator
3918 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3919 Consumer (except one that takes chunks instead of strings). This
3920 enables streaming of very large logfiles without storing the whole
3921 thing in memory.
3922 (BuildStatus.generateLogfileName): create names like
3923 12-log-compile-output, with a _0 suffix if required to be unique
3924 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3925 or earlier) logfiles into new-style ones
3926 (BuilderStatus): remove everything related to 'stub' builds. There
3927 is now only one build cache, and we don't strip logs from old
3928 builds anymore.
3929 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3930 since we no longer fight to keep it in the cache
3932 * buildbot/status/html.py (TextLog.render_GET): use a
3933 ChunkConsumer to stream the log entries efficiently.
3934 (ChunkConsumer): wrapper which consumes chunks and writes
3935 formatted HTML.
3937 * buildbot/test/test_twisted.py (Parse.testParse): use a
3938 LogFile-like object instead of a real one
3940 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3941 (Log.testMerge3): validate more merge behavior
3942 (Log.testChunks): validate LogFile.getChunks
3943 (Log.testUpgrade): validate old-style LogFile upgrading
3944 (Log.testSubscribe): validate LogFile.subscribe
3945 (Log.testConsumer): validate LogFile.subscribeConsumer
3947 * buildbot/interfaces.py (IStatusLogStub): remove
3948 (IStatusLog.subscribeConsumer): new method
3949 (IStatusLog.hasContents): new method
3950 (IStatusLogConsumer): describes things passed to subscribeConsumer
3952 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3953 the log contents if it does not have any contents.
3954 (StatusResourceBuildStep.body): same
3955 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3957 2005-05-14 Brian Warner <warner@lothar.com>
3959 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3960 timeouts to try and make the windows metabuildslave not hang
3962 2005-05-13 Mike Taylor <bear@code-bear.com>
3964 * buildbot/slave/commands.py (rmdirRecursive): added a check
3965 to ensure the path passed into rmdirRecursive actually exists.
3966 On win32 a non-existant path would generate an exception.
3968 2005-05-13 Brian Warner <warner@lothar.com>
3970 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3971 shutil.rmtree which behaves correctly on windows in the face of
3972 files that you have to chmod before deleting. Thanks to Bear at
3973 the OSAF for the routine.
3974 (SourceBase.doClobber): use rmdirRecursive
3976 2005-05-12 Brian Warner <warner@lothar.com>
3978 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3979 method generate chunks instead of returning a big list. This
3980 allows the same method to be used for both old LogFile and new
3981 OfflineLogFile.
3982 (OfflineLogFile.getText): use the generator
3983 (OfflineLogFile.subscribe): same
3984 * buildbot/status/html.py (TextLog.resumeProducing): same
3985 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3987 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3988 point out that OfflineLogFile does not currently work with
3989 html.Waterfall . Fixing this is high-priority.
3991 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3992 apparently windows defaults to using stdout
3994 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3995 better message on failure so I can figure out the win32 problem
3997 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3998 log messages to include more useful copies of the command being
3999 run, the argv array, and the child command's environment.
4000 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4002 2005-05-11 Brian Warner <warner@lothar.com>
4004 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4005 will actually work
4006 * Makefile: update the deb-snapshot version
4008 * docs/buildbot.texinfo: move all .xhtml docs into a new
4009 .texinfo-format document, adding a lot of material in the process.
4010 This is starting to look like a real user's manual. Removed all
4011 the Lore-related files: *.xhtml, *.css, template.tpl .
4012 * docs/Makefile: simple makefile to run 'makeinfo'
4013 * buildbot/scripts/sample.cfg: rearrange slightly
4014 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4016 2005-05-10 Brian Warner <warner@lothar.com>
4018 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4019 different name for the internal twistw module, handle it.
4021 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4022 * setup.py: .. and stop trying to install it
4024 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4025 'git'), the new linux kernel VC system (http://kernel.org/git/).
4026 Thanks to Brandon Philips for the patch.
4027 * buildbot/slave/commands.py (Git): same
4029 2005-05-06 Brian Warner <warner@lothar.com>
4031 * buildbot/status/builder.py (OfflineLogFile): replace the default
4032 LogFile with a form that appends its new contents to a disk file
4033 as they arrive. The complete log data is never kept in RAM. This
4034 is the first step towards handling very large (100MB+) logfiles
4035 without choking quite so badly. (The other half is
4036 producer/consumer on the HTML pages).
4037 (BuildStepStatus.addLog): use OfflineLogFile by default
4038 (BuildStatus.getLogfileName): helper code to give the
4039 OfflineLogFile a filename to work with
4041 * buildbot/test/test_status.py (Results.testAddResults): update
4042 tests to handle new asserts
4043 * buildbot/test/test_vc.py (Patch.doPatch): same
4044 * buildbot/test/test_steps.py (BuildStep.setUp): same
4046 2005-05-05 Brian Warner <warner@lothar.com>
4048 * buildbot/scripts/runner.py (start): if there is no Makefile,
4049 launch the app by importing twistd's internals and calling run(),
4050 rather than spawning a new twistd process. This stands a much
4051 better chance of working under windows.
4052 (stop): kill the process with os.kill instead of spawning
4053 /bin/kill, again to reduce the number of external programs which
4054 windows might not have in the PATH. Also wait up to 5 seconds for
4055 the process to go away, allowing things like 'buildbot stop;
4056 buildbot start' to be reliable in the face of slow shutdowns.
4058 * buildbot/master.py (Dispatcher.__getstate__): remove old
4059 .tap-related methods
4060 (BuildMaster.__getstate__): same
4061 (makeService): same
4062 * buildbot/slave/bot.py (makeService): same
4063 (Options.longdesc): same
4064 * buildbot/scripts/runner.py: copy over some old mktap option text
4066 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4067 'buildbot master' now creates a buildbot.tac file, so there is no
4068 longer a create-instance/save/reload sequence. mktap is dead, long
4069 live twistd -y.
4070 * buildbot/scripts/sample.mk: use twistd -y, not -f
4071 * buildbot/test/test_config.py: remove mktap-based test
4072 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4073 * README: don't reference mktap
4075 * docs/source.xhtml: document some of the attributes that Changes
4076 might have
4078 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4080 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4081 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4082 * buildbot/changes/changes.py (Change)
4083 * buildbot/changes/mail.py (parseSyncmail)
4084 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4085 (Test3.testMsgS5)
4086 * buildbot/process/base.py (Build.isTagImportant)
4087 (Build.addChange)
4090 2005-05-04 Brian Warner <warner@lothar.com>
4092 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4093 connection after sending the change, so that unit tests don't
4094 complain about sockets being left around
4096 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4097 exception in phase=0 rendering
4098 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4100 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4102 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4103 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4104 and configuring builders with tuples.
4105 * buildbot/test/test_config.py: stop testing compatibility with
4106 deprecated config keys
4107 * buildbot/test/test_run.py: same
4109 2005-05-03 Brian Warner <warner@lothar.com>
4111 * contrib/arch_buildbot.py: survive if there are no logfiles
4112 (username): just use a string, os.getlogin isn't reliable
4114 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4115 so 'buildbot sendchange' actually works. The earlier test only
4116 covered the internal (non-reactor-running) form.
4118 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4119 script to notify the buildmaster about changes
4121 * buildbot/scripts/runner.py (sendchange): new command to send a
4122 change to a buildbot.changes.pb.PBChangeSource receiver.
4123 * buildbot/test/test_changes.py (Sender): test it
4125 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4126 after any reading of the config file, not just when we do it in
4127 startService. This makes some tests a bit cleaner.
4129 * buildbot/changes/pb.py: add some log messages
4131 * buildbot/process/base.py (Build.startBuild): fix a bug that
4132 caused an exception when the build terminated in the very first
4133 step.
4134 (Build.stepDone): let steps return a status of EXCEPTION. This
4135 terminates the build right away, and sets the build's overall
4136 status to EXCEPTION too.
4137 * buildbot/process/step.py (BuildStep.failed): return a status of
4138 EXCEPTION when that is what has happened.
4140 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4141 implement this, allowing Arch-based projects to get precise
4142 checkouts instead of always using the latest code
4143 (Bazaar): create variant of Arch to let folks use baz instead of
4144 tla. Requires a new buildslave too.
4145 * buildbot/slave/commands.py (Arch): add 'revision' argument
4146 (Bazaar): create variant of Arch that uses baz instead of tla.
4147 Remove the code that extracts the archive name from the
4148 register-archive output, since baz doesn't provide it, and require
4149 the user provide both the archive name and its location.
4150 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4152 2005-05-02 Brian Warner <warner@lothar.com>
4154 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4155 thanks to Nick Trout.
4157 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4158 deals better with source Makefile coming from a read-only CVS
4159 checkout. Thanks to Nick Trout for the catch.
4161 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4162 releases
4164 2005-04-28 Brian Warner <warner@lothar.com>
4166 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4168 * debian/changelog: update for 0.6.4
4170 2005-04-28 Brian Warner <warner@lothar.com>
4172 * README.w32: add a checklist of steps for getting buildbot
4173 running on windows.
4174 * MANIFEST.in: include it in the tarball
4176 * NEWS: update
4178 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4179 broken .tap files from 0.6.3 by getting rid of .services,
4180 .namedServices, and .change_svc at load time.
4182 2005-04-27 Brian Warner <warner@lothar.com>
4184 * NEWS: update in preparation for new release
4186 * buildbot/test/test_config.py (Save.testSave): don't pull in
4187 twisted.scripts.twistd, we don't need it and it isn't for windows
4188 anyway.
4190 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4191 accomodate win32 which can't do atomic-rename
4193 2005-04-27 Brian Warner <warner@lothar.com>
4195 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4196 timeouts to help the slow metabuildbot not flunk them so much
4197 (Disconnect.testBuild3): same
4198 (Disconnect.testBuild4): same
4199 (Disconnect.testInterrupt): same
4201 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4202 setup, it was completely broken for new buildmasters (those which
4203 did not have a 'change.pck' already saved. Thanks to Paul Warren
4204 for catching this (embarrassing!) bug.
4205 (Dispatcher.__getstate__): don't save our registered avatar
4206 factories, since they'll be re-populated when the config file is
4207 re-read.
4208 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4209 tests (since the real mktap-generated BuildMaster doesn't save
4210 this attribute).
4211 (BuildMaster.__getstate__): don't save any service children,
4212 they'll all be re-populated when the config file is re-read.
4213 * buildbot/test/test_config.py (Save.testSave): test for this
4215 2005-04-26 Brian Warner <warner@lothar.com>
4217 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4218 rendered with Blender.. looks a bit nicer.
4219 * buildbot/docs/images/icon.blend: add the Blender file for it
4221 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4222 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4223 running under windows. This appears to be the best way to allow
4224 BuildSteps to do something normal like 'trial -v buildbot.test' or
4225 'make foo' and still expect it to work. The idea is to make the
4226 BuildSteps look as much like what a developer would type when
4227 compiling or testing the tree by hand. This approach probably has
4228 problems when there are spaces in the arguments, so if you've got
4229 windows buildslaves, you'll need to pay close attention to your
4230 commands.
4232 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4233 timezone to the timestamp column.
4234 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4236 * buildbot/scripts/runner.py (loadOptions): do something sane for
4237 windows, I think. We use %APPDATA%/buildbot instead of
4238 ~/.buildbot, but we still search everywhere from the current
4239 directory up to the root for a .buildbot/ subdir. The "is it under
4240 $HOME" security test was replaced with "is it owned by the current
4241 user", which is only performed under posix.
4242 * buildbot/test/test_runner.py (Options.testFindOptions): update
4243 tests to match. The "is it owned by the current user" check is
4244 untested. The test has been re-enabled for windows.
4246 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4247 any "\n" in the expected output with the platform-specific line
4248 separator. Make this separator "\r\n" on PTYs under unix, they
4249 seem to do that and I don't know why
4251 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4252 windows for now, I don't know what ~/.buildbot/ should mean there.
4254 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4255 win32 compatibility, don't use "/tmp"
4256 (Basedir.testChangeBuilddir): remove more unixisms
4258 2005-04-26 Brian Warner <warner@lothar.com>
4260 * buildbot/test/test_control.py (Force.rmtree): python2.2
4261 compatibility, apparently its shutil.rmtree ignore_errors=
4262 argument is ignored.
4263 * buildbot/test/test_run.py (Run.rmtree): same
4264 (RunMixin.setUp): same
4266 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4267 not os.path.sep
4269 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4270 'substring in string' operator, must use string.find(substr)!=-1
4271 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4272 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4274 * buildbot/scripts/runner.py (loadOptions): add code to search for
4275 ~/.buildbot/, a directory with things like 'options', containing
4276 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4277 the current directory, your $HOME directory, or anywhere
4278 inbetween, as long as you're somewhere inside your home directory.
4279 (debugclient): look in ~/.buildbot/options for master and passwd
4280 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4281 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4283 * buildbot/status/client.py (makeRemote): new approach to making
4284 IRemote(None) be None, which works under Twisted-2.0
4285 * buildbot/test/test_status.py (Client.testAdaptation): test it
4287 * buildbot/status/builder.py (Status.builderAdded): when loading a
4288 pickled BuilderStatus in from disk, set its name after loading.
4289 The config file might have changed its name (but not its
4290 directory) while it wasn't looking.
4292 * buildbot/process/builder.py (Builder.attached): always return a
4293 Deferred, even if the builder was already attached
4294 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4296 2005-04-25 Brian Warner <warner@lothar.com>
4298 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4299 category-related exception when announcing a build has finished
4301 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4302 reference no-longer-existent changemaster.sources
4303 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4305 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4306 releases
4308 2005-04-25 Brian Warner <warner@lothar.com>
4310 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4312 * debian/changelog: update for 0.6.3
4314 2005-04-25 Brian Warner <warner@lothar.com>
4316 * MANIFEST.in: make sure debug.glade is in the tarball
4318 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4320 * NEWS: update for the imminent 0.6.3 release
4322 * buildbot/status/html.py (HtmlResource.content): make the
4323 stylesheet <link> always point at "buildbot.css".
4324 (StatusResource.getChild): map "buildbot.css" to a static.File
4325 containing whatever css= argument was provided to Waterfall()
4326 (Waterfall): provide the "classic" css as the default.
4327 * docs/waterfall.classic.css: move default CSS from here ..
4328 * buildbot/status/classic.css: .. to here
4330 * MANIFEST.in: make sure classic.css is included in the tarball
4331 * setup.py: and that it is installed too, under buildbot/status/
4333 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4334 the module level, because buildbot.tap files from 0.6.2 don't have
4335 it in their attribute dictionary.
4337 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4338 really exists at startup, might save some confusion somewhere.
4340 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4342 * docs/waterfall.classic.css:
4343 add a stylesheet that's almost the same as the "classic"
4344 buildbot style
4346 * buildbot/status/builder.py:
4347 add EXCEPTION as a result - this is a problem for the bot
4348 maintainer, not a build problem for the changers
4349 * buildbot/process/step.py:
4350 use EXCEPTION instead of FAILURE for exceptions
4351 * buildbot/status/html.py:
4352 add build_get_class to get a class out of a build/buildstep
4353 finish naming the classes
4354 split out sourceNames to changeNames and builderNames so we
4355 can style them separately
4356 * docs/config.xhtml:
4357 finish documenting classes as they are right now
4359 * buildbot/status/html.py:
4360 name the classes as we agreed on IRC
4361 * docs/config.xhtml:
4362 and document them
4364 * buildbot/status/html.py:
4365 same for cssclass->class_
4367 * buildbot/status/html.py:
4368 as decided on IRC, use class_ for the "class" attribute to not
4369 conflict with the class keyword, and clean up the messy **{} stuff.
4371 * buildbot/status/mail.py:
4372 put back "builders" argument, and fix docstring, because the
4373 code *ignores* builders listed in this argument
4375 * buildbot/process/builder.py:
4376 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4378 * docs/config.xhtml:
4379 describe the category argument for builders
4381 * buildbot/status/builder.py:
4382 Fix a silly bug due to merging
4384 * buildbot/process/builder.py:
4385 remove category from the process Builder ...
4386 * buildbot/status/builder.py:
4387 ... and add it to BuilderStatus instead.
4388 Set category on unpickled builder statuses, they might not have it.
4389 * buildbot/master.py:
4390 include category when doing builderAdded
4391 * buildbot/status/mail.py:
4392 return None instead of self for builders we are not interested in.
4393 * buildbot/test/test_run.py:
4394 fix a bug due to only doing deferredResult on "dummy" waiting
4395 * buildbot/test/test_status.py:
4396 add checks for the Mail IStatusReceiver returning None or self
4398 * buildbot/status/html.py:
4399 fix testsuite by prefixing page title with BuildBot
4401 * buildbot/status/builder.py:
4402 have .category in builder status ...
4403 * buildbot/process/builder.py:
4404 ... and set it from Builder
4405 * buildbot/status/html.py:
4406 make .css a class variable
4407 * buildbot/test/test_status.py:
4408 write more tests to cover our categories stuff ...
4409 * buildbot/status/mail.py:
4410 ... and fix the bug that this uncovered
4412 * buildbot/changes/mail.py:
4413 * buildbot/changes/pb.py:
4414 * buildbot/master.py:
4415 * buildbot/process/base.py:
4416 * buildbot/process/factory.py:
4417 * buildbot/process/interlock.py:
4418 * buildbot/process/step.py:
4419 * buildbot/process/step_twisted.py:
4420 * buildbot/slave/commands.py:
4421 * buildbot/status/builder.py:
4422 * buildbot/status/client.py:
4423 * buildbot/status/html.py:
4424 * buildbot/status/mail.py:
4425 * buildbot/status/progress.py:
4426 * buildbot/test/test_changes.py:
4427 * buildbot/test/test_config.py:
4428 * buildbot/test/test_control.py:
4429 * buildbot/test/test_interlock.py:
4430 * buildbot/test/test_maildir.py:
4431 * buildbot/test/test_mailparse.py:
4432 * buildbot/test/test_run.py:
4433 * buildbot/test/test_slavecommand.py:
4434 * buildbot/test/test_status.py:
4435 * buildbot/test/test_steps.py:
4436 * buildbot/test/test_twisted.py:
4437 * buildbot/test/test_util.py:
4438 * buildbot/test/test_vc.py:
4439 * buildbot/test/test_web.py:
4440 * buildbot/util.py:
4441 add test-case-name at the top of a whole set of files
4443 * buildbot/status/builder.py:
4444 keep order of addition when getting builder names
4445 * buildbot/status/words.py:
4446 * buildbot/test/test_run.py:
4447 add test for getBuilderNames
4449 * buildbot/process/base.py:
4450 * buildbot/process/step.py:
4451 * buildbot/status/builder.py:
4452 * buildbot/status/html.py:
4453 make buildbot css-able
4454 replace the color code for purple with purple, don't understand
4455 why it wasn't purple to start with
4457 * buildbot/status/words.py:
4458 ok, so it doesn't look like BuilderStatus.remote is still valid.
4459 Use what waterfall uses instead.
4461 * buildbot/interfaces.py:
4462 * buildbot/status/builder.py:
4463 * buildbot/status/html.py:
4464 * buildbot/status/mail.py:
4465 * buildbot/status/words.py:
4466 * buildbot/test/test_run.py:
4467 use categories everywhere and make it be a list. More sensible
4468 for the future. Also make words actually respect this in
4469 buildFinished.
4471 * buildbot/interfaces.py:
4472 add category argument to getBuilderNames
4473 * buildbot/process/builder.py:
4474 * buildbot/status/builder.py:
4475 * buildbot/status/html.py:
4476 * buildbot/status/mail.py:
4477 * buildbot/status/words.py:
4478 * buildbot/test/test_run.py:
4479 move from specifying builders by name to specifying the category
4481 * buildbot/status/html.py:
4482 * buildbot/status/words.py:
4483 add "builders=" to __init__ of status clients so they can
4484 limit themselves to the given list of builders to report on
4486 * buildbot/status/html.py: set the title to the product name
4488 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4490 * buildbot/interfaces.py:
4491 * buildbot/status/builder.py:
4492 more documentation. Hm, not sure if ChangeLog entries make sense
4493 here...
4495 2005-04-23 Brian Warner <warner@lothar.com>
4497 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4499 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4501 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4502 the sub-commands that log buildmaster status to stdout and to a
4503 GUI window, respectively.
4505 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4506 functionality is working again, but all the step-status and ETA
4507 stuff is missing. Commented out a lot of code pending more
4508 overhaul work.
4510 * buildbot/status/client.py: make sure that IRemote(None) is None
4512 * buildbot/changes/changes.py: import defer, oops
4513 (ChangeMaster): remove the .sources list, rely upon the fact that
4514 MultiServices can be treated as sequences of their children. This
4515 cleans up the add/remove ChangeSource routines a lot, as we keep
4516 exactly one list of the current sources instead of three.
4518 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4519 up an empty ChangeMaster at init time.
4520 (BuildMaster.loadChanges): if there are changes to be had from
4521 disk, replace self.change_svc with the new ones. If not, keep
4522 using the empty ChangeMaster set up in __init__.
4523 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4524 instead of a separate list, makes the code a bit cleaner.
4525 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4526 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4527 Extend the test to make sure we can get rid of the sources when
4528 we're done.
4530 2005-04-22 Brian Warner <warner@lothar.com>
4532 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4533 and info/host files when making the slave directory
4535 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4536 whendone= argument, just return the Deferred and let the caller do
4537 what they want with it.
4538 (Disconnect.testBuild1): wait for shutdownSlave
4539 (Basedir.testChangeBuilddir): new test to make sure changes to the
4540 builddir actually get propagated to the slave
4542 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4543 explicit method, rather than passing the builddir in __init__ .
4544 Make sure to update self.basedir too, this was broken before.
4545 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4546 builders and for ones that have just had their builddir changed.
4547 (BotFactory): add a class-level .perspective attribute, so
4548 BuildSlave.waitUntilDisconnected won't get upset when the
4549 connection hasn't yet been established
4550 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4551 tests can reach through it to inspect the SlaveBuilders
4553 * buildbot/process/base.py (Build.buildException): explain the
4554 log.err with a log.msg
4555 * buildbot/process/builder.py (Builder.startBuild): same
4556 (Builder._startBuildFailed): improve error message
4558 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4559 occurred because we lost the brand-new connection, retry instead
4560 of giving up. If not, it's probably an authorization failure, and
4561 it makes sense to stop trying. Make sure we log.msg the reason
4562 that we're log.err'ing the failure, otherwise test failures are
4563 really hard to figure out.
4565 * buildbot/master.py: change loadConfig() to return a Deferred
4566 that doesn't fire until the change has been fully implemented.
4567 This means any connected slaves have been updated with the new
4568 builddir. This change makes it easier to test the code which
4569 actually implements this builddir-updating.
4570 (BotPerspective.addBuilder): return Deferred
4571 (BotPerspective.removeBuilder): same
4572 (BotPerspective.attached): same
4573 (BotPerspective._attached): same. finish with remote_print before
4574 starting the getSlaveInfo, instead of doing them in parallel
4575 (BotPerspective.list_done): same
4576 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4577 actually calling slave.disconnect()
4578 (BotMaster.addBuilder): same
4579 (BotMaster.removeBuilder): same
4580 (BuildMaster.loadConfig): same
4581 (BuildMaster.loadConfig_Slaves): same
4582 (BuildMaster.loadConfig_Sources): same
4583 (BuildMaster.loadConfig_Builders): same
4584 (BuildMaster.loadConfig_status): same
4586 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4587 a Deferred that fires when the source is finally removed
4589 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4590 the previous tree on win32, where we have to do it synchronously,
4591 make sure we return a Deferred anyway.
4592 (SourceBase.doCopy): same
4594 * buildbot/scripts/runner.py (statusgui): use the text client for
4595 now, while I rewrite the Gtk one
4596 * buildbot/clients/base.py: strip out old code, leaving just the
4597 basic print-message-on-event functionality. I also remove the
4598 ReconnectingPBClientFactory, but it does at least quit when it
4599 loses the connection instead of going silent
4601 2005-04-21 Brian Warner <warner@lothar.com>
4603 * Makefile: minor tweaks
4605 * NEWS: point out deprecation warnings, new features for
4606 /usr/bin/buildbot
4608 * buildbot/master.py (BuildMaster.loadConfig): emit
4609 DeprecationWarnings for Builders defined with tuples. Rearrange
4610 code to facility removal of deprecated configuration keys in the
4611 next release.
4613 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4614 'buildbot' command to put a little Makefile in the target that
4615 helps you re-create the buildbot.tap file, start or stop the
4616 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4617 all the files 0600, since they contain passwords.
4618 (start): if there is a Makefile, and /usr/bin/make exists, use
4619 'make start' in preference to a raw twistd command. This lets
4620 slave admins put things like PYTHONPATH variables in their
4621 Makefiles and have them still work when the slave is started with
4622 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4623 be nice to first try the 'make' command and only fall back to
4624 twistd if it fails. TODO: the Makefile's "start" command does not
4625 add the --reactor=win32 argument when running under windows.
4626 (Options.debugclient, Options.statusgui): add sub-commands to launch
4627 the debug client (formerly in contrib/debugclient.py) and the
4628 Gtk status application (currently broken)
4629 * buildbot/clients/debug.py: move from contrib/debugclient.py
4630 * buildbot/clients/debug.glade: same
4632 * buildbot/test/test_trial.py: remove it. This requires some
4633 functionality out of Twisted that isn't there yet, and until then
4634 having it around just confuses things.
4636 * buildbot/test/test_slavecommand.py (Shell): test both with and
4637 without PTYs, and make sure that command output is properly
4638 interleaved in the with-PTY case. I think the without-PTY test
4639 should pass on windows, where we never use PTYs anyway.
4641 2005-04-20 Brian Warner <warner@lothar.com>
4643 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4645 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4647 * NEWS: start creating entries for the next release
4649 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4651 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4652 (WebTest.test_webPathname): same
4653 (WebTest.test_webPathname_port): same
4654 (WebTest.test_waterfall): use the default favicon rather than
4655 rooting around the filesystem for it. Open the expected-icon file
4656 in binary mode, to make win32 tests happier (thanks to Nick Trout
4657 for the catch)
4658 * buildbot/status/html.py (buildbot_icon): win32 portability
4660 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4661 win32-compatibility fixes from Nick Trout, the "file not found" message
4662 is different under windows
4663 (FakeSlaveBuilder.__init__): clean up setup a bit
4664 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4666 2005-04-19 Brian Warner <warner@lothar.com>
4668 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4669 skip-if-repositories-are-unavailable test to not kill the trial
4670 that comes with Twisted-1.3.0
4672 * setup.py: install buildbot.png icon file when installing code
4674 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4675 environment used by the command, at least on the child side.
4677 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4678 this method needs to be added and implemented because it gets
4679 called under heavy load. I don't quite understand the
4680 producer/consumer API enough to write it.
4681 (StatusResource.getChild): add a resource for /favicon.ico
4682 (Waterfall.__init__): add favicon= argument
4683 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4684 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4685 (WebTest.test_webPathname): same
4686 (WebTest.test_webPathname_port): same
4687 * docs/config.xhtml: mention favicon=
4688 * buildbot/buildbot.png: add a default icon, dorky as it is
4690 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4692 * buildbot/master.py:
4693 * buildbot/process/base.py:
4694 * buildbot/process/builder.py:
4695 * buildbot/process/interlock.py:
4696 * buildbot/status/builder.py:
4697 * buildbot/status/html.py:
4698 * buildbot/status/mail.py:
4699 * buildbot/status/words.py:
4700 new documentation while digging through the code
4702 2005-04-17 Brian Warner <warner@lothar.com>
4704 * general: try to fix file modes on all .py files: a+r, a-x,
4705 but let buildbot/clients/*.py be +x since they're tools
4707 * docs/epyrun (addMod): when an import fails, say why
4709 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4711 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4713 * buildbot/process/base.py:
4714 * buildbot/process/builder.py:
4715 * buildbot/status/builder.py:
4716 new documentation while digging through the code
4718 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4720 * buildbot/changes/changes.py:
4721 * buildbot/changes/p4poller.py:
4722 * buildbot/interfaces.py:
4723 * buildbot/process/base.py:
4724 * buildbot/process/builder.py:
4725 * buildbot/process/step.py:
4726 * buildbot/process/step_twisted.py:
4727 * buildbot/slave/bot.py:
4728 * buildbot/slave/commands.py:
4729 * buildbot/status/builder.py:
4730 fix all docstrings to make epydoc happy. In the process of fixing
4731 some, I also moved pieces of docs, and removed some deprecated
4732 documentation
4734 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4736 * buildbot/process/builder.py:
4737 * buildbot/process/interlock.py:
4738 * buildbot/process/process_twisted.py:
4739 * buildbot/process/step.py:
4740 BuildProcess -> Build, as it looks like that's what happened
4741 * buildbot/process/base.py:
4742 * buildbot/process/factory.py:
4743 update epydoc stuff
4745 2005-04-17 Brian Warner <warner@lothar.com>
4747 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4748 update compile command to accomodate the Twisted split.. now
4749 instead of './setup.py build_ext -i', you do './setup.py all
4750 build_ext -i', to run build_ext over all sub-projects.
4751 (FullTwistedBuildFactory): same
4752 (TwistedReactorsBuildFactory): same
4754 * buildbot/status/html.py (TextLog.finished): null out self.req
4755 when we're done, otherwise the reference cycle of TextLog to .req
4756 to .notifications to a Deferred to TextLog.stop keeps them from
4757 being collected, and consumes a huge (610MB on pyramid at last
4758 check) amount of memory.
4760 2005-04-11 Brian Warner <warner@lothar.com>
4762 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4763 normalize the VC-repository location.. makes SVN happier with
4764 certain test environments.
4766 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4767 RemoteShellCommand gets its own .env dictionary, so that code in
4768 start() doesn't mutate the original. I think this should fix the
4769 step_twisted.Trial problem where multiple identical components
4770 kept getting added to PYTHONPATH= over and over again.
4772 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4773 adding epydoc-format docstrings to many classes. Thanks to Thomas
4774 Vander Stichele for the patches.
4775 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4776 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4777 * buildbot/slave/bot.py, commands.py, registry.py: same
4779 2005-04-05 Brian Warner <warner@lothar.com>
4781 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4782 preserve timestamps, helps incremental builds of large trees.
4783 Patch from Rene Rivera.
4785 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4786 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4787 for the catch.
4789 2005-04-03 Brian Warner <warner@lothar.com>
4791 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4792 with one dict, apparently exec has some scoping bugs when used
4793 with both global/local dicts. Thanks to Nathaniel Smith for the
4794 catch.
4796 2005-04-02 Brian Warner <warner@lothar.com>
4798 * buildbot/process/step_twisted.py (countFailedTests): the new
4799 trial in Twisted-2.0 emits a slightly different status line than
4800 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4801 mistakenly think the test count is unparseable.
4802 (Trial.start): note that for some reason each build causes another
4803 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4804 be fixed but I'm not sure quite where the problem is.
4806 2005-04-01 Brian Warner <warner@lothar.com>
4808 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4809 deferredResult to avoid hangs/warnings under twisted-2.0
4810 (RunMixin.tearDown): same
4811 (RunMixin.shutdownSlave): same
4812 (Disconnect.testIdle1): same
4813 (Disconnect.testBuild2): same: wait one second after the build
4814 finishes for test to really be done.. this should be cleaned up to
4815 avoid wasting that second. Builder.detach uses a callLater(0),
4816 either that should be done in-line (something else needed that
4817 behavior), or it should return a Deferred that fires when the
4818 builder is really offline.
4819 (Disconnect.testBuild3): same
4820 (Disconnect.testDisappear): same
4822 * buildbot/test/test_web.py: rearrange server-setup and teardown
4823 code to remove unclean-reactor warnings from twisted-2.0
4825 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4826 so the tests don't hang under twisted-2.0
4828 2005-03-31 Brian Warner <warner@lothar.com>
4830 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4831 caused a warning each time the master changed our set of builders
4833 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4834 w32, don't unlink the file unless it already exists. Thanks to
4835 Baptiste Lepilleur for the catch.
4836 (BuilderStatus.saveYourself): same
4838 2005-02-01 Brian Warner <warner@lothar.com>
4840 * buildbot/status/html.py (TextLog.getChild): use a /text child
4841 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4842 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4843 logfile as text/plain (no markup, no headers). This replaces the
4844 previous scheme (which used an ?text=1 argument), and gets us back
4845 to a relative link (which works better when the buildbot lives
4846 behind another web server, such as Apache configured as a reverse
4847 proxy). Thanks to Gerald Combs for spotting the problem.
4849 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4850 releases
4852 2004-12-13 Brian Warner <warner@lothar.com>
4854 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4856 * debian/changelog: update for 0.6.2
4857 * NEWS: finalize for 0.6.2
4859 2004-12-11 Brian Warner <warner@lothar.com>
4861 * NEWS: bring it up to date
4863 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4864 detection code. Require some sign of life from the buildmaster
4865 every BotFactory.keepaliveInterval seconds. Provoke this
4866 indication at BotFactory.keepaliveTimeout seconds before the
4867 deadline by sending a keepalive request. We don't actually care if
4868 that request is answered in a timely fashion, what we care about
4869 is that .activity() is called before the deadline. .activity() is
4870 triggered by any PB message from the master (including an ack to
4871 one of the slave's status-update messages). With this new scheme,
4872 large status messages over slow pipes are OK, as long as any given
4873 message can be sent (and thus acked) within .keepaliveTimeout
4874 seconds (which defaults to 30).
4875 (SlaveBuilder.remote_startCommand): record activity
4876 (SlaveBuilder.ackUpdate): same
4877 (SlaveBuilder.ackComplete): same
4878 (BotFactory.gotPerspective): same
4879 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4881 2004-12-09 Brian Warner <warner@lothar.com>
4883 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4884 debug message
4886 * buildbot/process/step_twisted.py (Trial._commandComplete):
4887 update self.cmd when we start the 'cat test.log' transfer. Without
4888 this, we cannot interrupt the correct RemoteCommand when we lose
4889 the connection.
4891 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4892 trying to tell the slave to stop the command if we're already
4893 inactive, or if we no longer have a .remote
4895 * buildbot/process/builder.py (Builder._detached): don't let an
4896 exception in currentBuild.stopBuild() prevent the builder from
4897 being marked offline
4899 2004-12-07 Brian Warner <warner@lothar.com>
4901 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4902 KeyError that happens when you ask for a non-existent Builder, and
4903 translate it into a UsageError.
4905 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4906 losing the slave in the middle of a remote step is handled too
4908 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4909 be a Failure, so be sure to stringify it before using it as the
4910 contents of the 'interrupt' logfile
4911 (RemoteCommand.interrupt): use stringified 'why' in
4912 remote_interruptCommand too, just in case
4914 2004-12-06 Brian Warner <warner@lothar.com>
4916 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4917 instead of 'tla update', which is more efficient in case we've
4918 missed a couple of patches since the last update.
4920 * debian/changelog: update for previous (0.6.1) release. Obviously
4921 this needs to be handled better.
4923 2004-12-05 Brian Warner <warner@lothar.com>
4925 * NEWS: update for stuff since last release
4927 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4928 match the maybeDeferred change in Dispatcher.requestAvatar
4929 * buildbot/changes/pb.py (ChangePerspective.attached): same
4930 * buildbot/status/client.py (StatusClientPerspective.attached): same
4931 * buildbot/process/builder.py (Builder._attached3): same
4932 * buildbot/pbutil.py (NewCredPerspective.attached): same
4934 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4935 the date to the top-most box, if it is not the same as today's
4936 date.
4938 * docs/slave.xhtml: provide a buildslave setup checklist
4940 * docs/source.xhtml (Arch): correct terminology
4942 2004-12-04 Brian Warner <warner@lothar.com>
4944 * buildbot/test/test_slavecommand.py: use sys.executable instead
4945 of hard-coding 'python' for child commands, might help portability
4947 * docs/examples/twisted_master.cfg: update to current usage
4949 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4950 'stop build' command to the IRC bot
4952 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4953 message that broke PBChangeSource
4955 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4956 (SlaveBuilder): make some attributes class-level, remove the old
4957 "update queue" which existed to support resuming a build after the
4958 master connection was lost. Try to reimplement that feature later.
4959 (SlaveBuilder.stopCommand): clear self.command when the
4960 SlaveCommand finishes, so that we don't try to kill a leftover one
4961 at shutdown time.
4962 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4963 .finishCommand
4965 * buildbot/slave/commands.py (SourceBase): set self.command for
4966 all VC commands, so they can be interrupted.
4968 2004-12-03 Brian Warner <warner@lothar.com>
4970 * buildbot/master.py: clean up slave-handling code, to handle
4971 slave-disconnect and multiple-connect better
4972 (BotPerspective): make these long-lasting, exactly one per bot
4973 listed in the config file.
4974 (BotPerspective.attached): if a slave connects while an existing
4975 one appears to still be connected, disconnect the old one first.
4976 (BotPerspective.disconnect): new method to forcibly disconnect a
4977 buildslave. Use some hacks to empty the transmit buffer quickly to
4978 avoid the long (20-min?) TCP timeout that could occur if the old
4979 slave has dropped off the net.
4980 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4981 own their own SlaveStatus objects. Remove .attached/.detached, add
4982 .addSlave/.removeSlave, treat slaves like Builders (config file
4983 parsing sends deltas to the BotMaster). Inform the slave
4984 instances, i.e. the BotPerspective, about addBuilder and
4985 removeBuilder.
4986 (BotMaster.getPerspective): turns into a single dict lookup
4987 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4988 which gives BotPerspective.attached a chance to disconnect the old
4989 slave first.
4990 (BuildMaster.loadConfig): add code (disabled) to validate that all
4991 builders use known slaves (listed in c['bots']). The check won't
4992 work with tuple-specified builders, which are deprecated but not
4993 yet invalid, so the check is disabled for now.
4994 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4995 routine, do the add/changed/removed dance with them like we do
4996 with builders.
4997 (BuildMaster.loadConfig_Sources): move source-config into a
4998 separate routine too
5000 * buildbot/status/builder.py (Status.getSlave): get the
5001 SlaveStatus object from the BotPerspective, not the BotMaster.
5003 * buildbot/test/test_run.py: bunch of new tests for losing the
5004 buildslave at various points in the build, handling a slave that
5005 connects multiple times, and making sure we can interrupt a
5006 running build
5008 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5009 something other than 'Bot' for the Bot object, to make certain
5010 test cases easier to write.
5011 (BuildSlave.waitUntilDisconnected): utility method for testing
5013 2004-11-30 Brian Warner <warner@lothar.com>
5015 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5017 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5018 argument, return a Deferred that always fires with True or False.
5019 I don't use an errback to indicate 'ping failed' so that callers
5020 are free to ignore the deferred without causing spurious errors in
5021 the logs.
5022 * buildbot/process/builder.py (BuilderControl.ping): implement it
5024 * buildbot/test/test_run.py (Status.testDisappear): test ping
5025 (Status.disappearSlave): fix it
5027 2004-11-30 Brian Warner <warner@lothar.com>
5029 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5030 (IBuilderControl): add .getBuild(num), only works for the current
5031 build, of course, although it might be interesting to offer
5032 something for builds in the .waiting or .interlocked state.
5034 * buildbot/process/base.py (Build): have .stopBuild just do the
5035 interrupt, then let the build die by itself.
5036 (BuildControl): add .stopBuild, and add a point-event named
5037 'interrupt' just after the build so status viewers can tell that
5038 someone killed it.
5039 (BuilderControl): add .getBuild
5041 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5042 stops when you kill it, good for testing
5043 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5044 contains the 'reason' text.
5046 * buildbot/status/html.py: Add Stop Build button, if the build can
5047 still be stopped. Send a Redirect (to the top page) one second
5048 later, hopefully long enough for the interrupt to have an effect.
5049 Move make_row() up to top-level to share it between Stop Build and
5050 Force Build.
5052 * buildbot/slave/commands.py: only kill the child process once
5054 * buildbot/test/test_run.py: add testInterrupt
5056 2004-11-29 Brian Warner <warner@lothar.com>
5058 * buildbot/process/base.py: Refactor command interruption. The
5059 Build is now responsible for noticing that the slave has gone
5060 away: Build.lostRemote() interrupts the current step and makes
5061 sure that no further ones will be started.
5063 * buildbot/process/builder.py: When the initial remote_startBuild
5064 message fails, log it: this usually indicates that the slave has
5065 gone away, but we don't really start paying attention until they
5066 fail to respond to the first step's command.
5068 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5069 slave disconnect. Now sports a new interrupt() method. Error
5070 handling was simplified a lot by chaining deferreds, so
5071 remoteFailed/remoteComplete were merged into a single
5072 remoteComplete method (which can now get a Failure object).
5073 Likewise failed/finished were merged into just _finished.
5074 (BuildStep): Add interrupt(why) method, and if why is a
5075 ConnectionLost Failure then the step is failed with some useful
5076 error text.
5078 * buildbot/slave/bot.py: stop the current command when the remote
5079 Step reference is lost, and when the slave is shut down.
5080 (Bot): make it a MultiService, so it can have children. Use
5081 stopService to tell when the slave is shutting down.
5082 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5083 remote_interruptCommand (which asks the current SlaveCommand to
5084 stop but allows it to keep emitting status messages), and
5085 stopCommand (which tells it to shut up and die).
5087 * buildbot/slave/commands.py: make commands interruptible
5088 (ShellCommand.kill): factor out os.kill logic
5089 (Command): factor out setup()
5090 (Command.sendStatus): don't send status if .running is false, this
5091 happens when the command has been halted.
5092 (Command.interrupt): new method, used to tell the command to die
5093 (SlaveShellCommand): implement .interrupt
5094 (DummyCommand): implement .interrupt
5095 (SourceBase, etc): factor out setup(), don't continue substeps if
5096 .interrupted is set
5098 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5099 so they can be called after finishing
5101 * buildbot/test/test_run.py: new tests for disconnect behavior,
5102 refactor slave-shutdown routines, add different kinds of
5103 slave-shutdown
5105 2004-11-27 Brian Warner <warner@lothar.com>
5107 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5108 method to express ETA time like "2m45s" instead of "165 seconds"
5110 2004-11-24 Brian Warner <warner@lothar.com>
5112 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5113 archive after the test completes, to avoid cluttering the user's
5114 'tla archives' listing with a bogus entry. Arch doesn't happen to
5115 provide any way to override the use of ~/.arch-params/, so there
5116 isn't a convenient way to avoid touching the setup of the user who
5117 runs the test.
5118 (VC_HTTP.testArchHTTP): same
5120 2004-11-23 Brian Warner <warner@lothar.com>
5122 * buildbot/status/html.py (TextLog): split render() up into
5123 render_HEAD and render_GET. Use a Producer when sending log
5124 chunks, to reduce memory requirements and avoid sending huge
5125 non-Banana-able strings over web.distrib connections. Requires
5126 peeking under the covers of IStatusLog.
5127 (TextLog.resumeProducing): fix the "as text" link, handle client
5128 disconnects that occur while we're still sending old chunks.
5130 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5131 use defer.succeed, not the non-existent defer.success
5132 (LogFile.waitUntilFinished): same
5133 (LogFile.subscribe): don't add watchers to a finished logfile
5135 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5136 releases
5138 2004-11-23 Brian Warner <warner@lothar.com>
5140 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5142 2004-11-23 Brian Warner <warner@lothar.com>
5144 * NEWS: update for the 0.6.1 release
5145 * MANIFEST.in: add new files
5147 * README (INSTALLATION): explain how to enable the extra VC tests
5149 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5150 level to, so old pickled builds can be displayed ok
5152 2004-11-22 Brian Warner <warner@lothar.com>
5154 * NEWS: summarize updates since last release
5156 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5157 Yoz Grahame. Closes SF#1050138.
5159 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5160 SF#1042563.
5162 * buildbot/process/step_twisted.py (Trial): update docs a bit
5164 * docs/factories.xhtml: fix Trial factory docs to match reality.
5165 Closes: SF#1049758.
5167 * buildbot/process/factory.py (Trial.__init__): add args for
5168 randomly= and recurse=, making them available to instantiators
5169 instead of only to subclassers. Closes: SF#1049759.
5171 2004-11-15 Brian Warner <warner@lothar.com>
5173 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5174 try to teach the Quick factory to use multiple versions of python
5176 2004-11-12 Brian Warner <warner@lothar.com>
5178 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5179 safer w32-compatible approach, and only use it on windows
5180 (BuildStatus.saveYourself): same
5182 2004-11-11 Brian Warner <warner@lothar.com>
5184 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5185 it: one string merge per chunk. There are now separate .entries
5186 and .runEntries lists: when enumerating over all chunks, make sure
5187 to look at both.
5188 * buildbot/test/test_status.py (Log): more tests
5190 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5191 chunks together, up to 10kb per chunk. This ought to cut down on
5192 the CPU-burning overhead of large log files. Thanks to Alexander
5193 Staubo for spotting the problem.
5194 * buildbot/test/test_status.py (Log): tests for same
5196 2004-11-10 Brian Warner <warner@lothar.com>
5198 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5199 header to outbound mail
5200 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5202 2004-11-08 Brian Warner <warner@lothar.com>
5204 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5205 can't do os.rename() onto an existing file, so catch the exception
5206 and unlink the target file first. This introduces a slight window
5207 where the existing file could be lost, but the main failure case
5208 (disk full) should still be handled safely.
5209 (BuildStatus.saveYourself): same
5211 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5212 separator character instead of os.sep, because the filenames being
5213 split here are coming from the VC system, which can have a
5214 different pathname convention than the local host. This should
5215 help a buildmaster running on windows that uses a CVS repository
5216 which runs under unix.
5217 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5219 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5220 when there are no test failures to be parsed
5222 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5223 instead of the unix-specific os.system("cp"), thanks to Elliot
5224 Murphy for this and the other buildbot-vs-windows catches.
5225 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5227 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5228 echo the command as it is run
5230 * setup.py: install sample.mk too, not just sample.cfg
5231 (scripts): install contrib/windows/buildbot.bat on windows
5233 2004-11-07 Brian Warner <warner@lothar.com>
5235 * buildbot/process/builder.py (Builder._detached): clear the
5236 self.currentBuild reference, otherwise the next build will be
5237 skipped because we think the Builder is already in use.
5239 * docs/examples/twisted_master.cfg: update to match current usage
5240 on the Twisted buildbot
5242 2004-10-29 Brian Warner <warner@lothar.com>
5244 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5246 2004-10-28 Brian Warner <warner@lothar.com>
5248 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5249 have separate doVCUpdate/doVCFull methods. Catch an update failure
5250 and respond by clobbering the source directory and re-trying. This
5251 will handle local changes (like replacing a file with a directory)
5252 that will cause CVS and SVN updates to fail.
5253 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5255 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5256 python-2.4 warning
5258 2004-10-19 Brian Warner <warner@lothar.com>
5260 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5262 * buildbot/status/html.py (StatusResourceTestResults): display any
5263 TestResults that the Build might have
5264 (StatusResourceTestResult): and the logs for each TestResult
5265 (StatusResourceBuild): add link from the per-build page
5267 2004-10-15 Brian Warner <warner@lothar.com>
5269 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5270 the 'problems' portion of stdout, add TestResults to our build
5271 * buildbot/test/test_twisted.py (Parse.testParse): test it
5273 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5274 to retrieve a dict of accumulated test results
5275 (ITestResult): define what a single test result can do
5276 * buildbot/status/builder.py (TestResult): implement ITestResult
5277 (BuildStatus.getTestResults): retrieve dict of TestResults
5278 (BuildStatus.addTestResult): add TestResults
5279 * buildbot/test/test_status.py (Results.testAddResults): test it
5281 2004-10-14 Brian Warner <warner@lothar.com>
5283 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5284 instead of os.system("rm -rf") for win32 portability
5286 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5287 SignalMixin instead of starting/stopping the reactor, which is
5288 likely to cause problems with other tests
5290 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5291 self.copyComplete() call. Yoz Grahame makes the catch.
5293 * contrib/windows/buildbot.bat: helper script to deal with path
5294 issues. Thanks to Yoz Grahame.
5296 * buildbot/master.py (BuildMaster.startService): don't register a
5297 SIGHUP handler if the signal module has no SIGHUP attribute.
5298 Apparently win32 does this.
5300 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5302 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5303 test if the reactor can't offer UNIX sockets
5305 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5306 error introduced in the last commit. We really need that
5307 metabuildbot :).
5309 2004-10-12 Brian Warner <warner@lothar.com>
5311 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5312 when describing a maildir source. Thanks to Stephen Davis.
5314 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5315 ETA seconds
5317 * buildbot/scripts/runner.py (createMaster): install Makefile too
5318 (start): add --no_save to 'start' command
5319 * buildbot/scripts/sample.mk: simple convenience Makefile with
5320 start/stop/reload targets
5322 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5323 releases
5325 2004-09-30 Brian Warner <warner@lothar.com>
5327 * setup.py: Releasing buildbot-0.6.0
5329 2004-09-30 Brian Warner <warner@lothar.com>
5331 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5332 test_trial.py from the source tarball until support is complete.
5334 * NEWS: update for 0.6.0 release
5335 * buildbot/__init__.py (version): same
5336 * README: same
5338 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5339 'source' command to tell users where to get the Buildbot source
5341 * docs/examples/*.cfg: update to modern standards
5343 * NEWS: update for release
5345 * buildbot/scripts/runner.py (createMaster): remove the
5346 -shutdown.tap stuff now that it isn't necessary
5347 (createSlave): same
5348 (start): launch buildbot.tap, not buildbot-shutdown.tap
5351 * buildbot/status/mail.py (Domain): shorten class name
5352 (MailNotifier): if lookup= is a string, pass it to Domain()
5353 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5354 (Mail.testBuild2): test the string-to-Domain shortcut
5355 (Mail.testMail): fix test
5358 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5359 example config file
5361 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5362 more attributes on load
5363 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5364 to accomodate the whole waterfall page at once, and the thrashing
5365 results in a lot of unnecessary loads
5366 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5367 (BuilderStatus.saveYourself): same
5368 (BuilderStatus.eventGenerator): stop generating on the first missing
5369 build. We assume that saved builds are deleted oldest-first.
5370 (BuildStepStatus.__getstate__): .progress might not exist
5372 * buildbot/changes/changes.py (ChangeMaster): make it
5373 serializable, in $masterdir/changes.pck
5374 (ChangeMaster.stopService): save on shutdown
5375 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5376 * buildbot/test/test_config.py: load Changes before config file
5379 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5380 "Oh my god, you killed the command" header on a separate line
5382 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5383 skip over corrupted build pickles
5384 (BuilderStatus.getFullBuildByNumber): same
5385 (BuilderStatus.eventGenerator): skip over unavailable builds
5386 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5387 do an atomic rename. This prevents a corrupted pickle when some
5388 internal serialization error occurs.
5389 (BuilderStatus.saveYourself): same
5391 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5392 the timeout for shell commands, it got lost somehow
5394 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5395 run out of build steps, return the rest of the builder events
5397 * buildbot/interfaces.py (IBuilderControl.ping): add method
5399 * buildbot/process/builder.py (BuilderControl.ping): move
5400 slave-ping to BuilderControl, and fix the failure case in the
5401 process (Event.finish() is the verb, Event.finished is the noun).
5403 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5404 through the BuilderControl instead of the BuilderStatus
5405 (EventBox): add adapter for builder.Event, allowing builder events to
5406 be displayed in the waterfall display
5408 * buildbot/master.py (BotMaster.stopService): add a 'master
5409 shutdown' event to the builder's log
5410 (BuildMaster.startService): and a 'master started' on startup
5412 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5413 builder events into the BuildStep event stream
5414 (Status.builderAdded): add a 'builder created' event
5417 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5418 command to announce the completion of a running build
5419 (IrcStatusBot.command_FORCE): announce when the build finishes
5421 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5422 don't evict unfinished builds from the cache: they must stay in
5423 the full-cache until their logfiles have stopped changing. Make
5424 sure the eviction loop terminates if an unfinished build was hit.
5425 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5426 This lets exceptions be dumped in an email status message. Really
5427 we need LogFiles which contain both text and HTML, instead of two
5428 separate classes.
5429 (BuildStatus.__getstate__): handle self.finished=False
5430 (Status.builderAdded): if the pickle is corrupted, abandon the
5431 history and create a new BuilderStatus object.
5433 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5434 self.progress attribute, helped one test which doesn't fully set
5435 up the Build object.
5437 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5438 IStatusLog methods into an Interface that is implemented by "stub"
5439 logs, for which all the actual text chunks are on disk (in the
5440 pickled Build instance). To show the log contents, you must first
5441 adapt the stub log to a full IStatusLog object.
5443 * buildbot/status/builder.py (LogFileStub): create separate stub
5444 log objects, which can be upgraded to a real one if necessary.
5445 (LogFile): make them persistable, and let them stubify themselves
5446 (HTMLLogFile): same
5447 (BuildStepStatus): same
5448 (BuildStatus): same
5449 (BuildStatus.saveYourself): save the whole build out to disk
5450 (BuilderStatus): make it persistable
5451 (BuilderStatus.saveYourself): save the builder to disk
5452 (BuilderStatus.addFullBuildToCache): implement two caches which
5453 hold Build objects: a small one which holds full Builds, and a
5454 larger one which holds "stubbed" Builds (ones with their LogFiles
5455 turned into LogFileStubs). This reduces memory usage by the
5456 buildmaster by not keeping more than a few (default is 2) whole
5457 build logs in RAM all the time.
5458 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5459 cache)
5460 (BuilderStatus.eventGenerator): rewrite since .builds went away
5461 (BuilderStatus.buildStarted): remove the .builds array. Add the
5462 build to the "full" cache when it starts.
5463 (BuilderStatus._buildFinished): save the build to disk when it
5464 finishes
5465 (Status): give it a basedir (same as the BuildMaster's basedir)
5466 where the builder pickles can be saved
5467 (Status.builderAdded): create the BuilderStatus ourselves, by
5468 loading a pickle from disk (or creating a new instance if there
5469 was none on disk). Return the BuilderStatus so the master can glue
5470 it into the new Builder object.
5472 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5473 all BuilderStatuses to save themselves out to disk. This is in
5474 lieu of saving anything important in the main Application pickle
5475 (the -shutdown.tap file).
5476 (BuildMaster.__init__): give Status() a basedir for its files
5477 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5478 to get the BuilderStatus, then give it to the Builder (instead of
5479 doing it the other way around). It's ok if the status announces
5480 the new Builder before it's really ready, as the outside world can
5481 only see the BuilderStatus object anyway (and it is ready before
5482 builderAdded returns). Use the builder's "builddir" (which
5483 normally specifies where the slave will run the builder) as the
5484 master's basedir (for saving serialized builds).
5486 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5487 coerce the logfile to IStatusLog before trying to get the text
5488 chunks out of it. This will pull the full (non-stubified) Build in
5489 from disk if necessary.
5490 (TextLog): fix the adapter registration
5492 * buildbot/test/test_control.py (Force.setUp): create the basedir
5493 * buildbot/test/test_web.py: same
5494 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5495 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5496 * buildbot/test/test_run.py (Run.testMaster): same
5497 (Status.setUp): same
5499 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5501 * buildbot/status/html.py (Waterfall.__init__): store actual
5502 allowForce flag passed in rather than using True for everyone;
5503 make sure setting it to False doesn't cause a NameError
5504 (Waterfall.setup).
5505 (StatusResourceBuilder.__init__) add the builder name to the page
5506 title.
5507 (StatusResourceBuilder.body) move HTML generation for a name/value
5508 row into a helper method (StatusResourceBuilder.make_row); only
5509 generate the "Force Build" form if allowForce was True and the
5510 slave is connected. Use class attributes in the generated HTML to
5511 spread a little CSS-joy.
5513 2004-09-28 Brian Warner <warner@lothar.com>
5515 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5516 warning-scanner to not ignore things like
5517 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5519 * buildbot/status/html.py (StatusResource.control): add some
5520 class-level values for .control in an attempt to make upgrading
5521 smoother
5523 * buildbot/util.py (ComparableMixin): survive missing attributes,
5524 such as when a class is modified and we're comparing old instances
5525 against new ones
5527 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5528 failure handling, remove a redundant try/except block. Don't
5529 return the full traceback to the IRC channel.
5530 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5531 error messages. Get ETA properly.
5533 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5534 the reason, since (at least) IRC message will have <> in them.
5535 (StatusResourceBuilder.__init__): take an IBuilderControl
5536 (StatusResourceBuilder.force): use the IBuilderControl we get in
5537 the constructor instead of trying to make our own. Catch the
5538 new exceptions and ignore them for now (until we make an
5539 intermediate web page where we could show the error message)
5540 (StatusResource): create with an IControl, use it to give an
5541 IBuilderControl to all children
5542 (Waterfall): take an allowForce= option, pass an IControl object
5543 to StatusResource if it is True
5545 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5547 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5548 catch new exceptions and return string forms
5550 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5551 * buildbot/process/builder.py (Builder.forceBuild): raise them
5552 * buildbot/test/test_control.py (Force.testNoSlave): new test
5553 (Force.testBuilderInUse): same
5556 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5558 * buildbot/test/test_run.py: use IControl
5559 * buildbot/test/test_vc.py: same
5561 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5562 to use IControl. Still offline.
5563 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5565 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5566 who=None so periodic builds don't send out status mail
5567 (Builder.forceBuild): include reason in the log message
5568 (BuilderControl.forceBuild): rename 'name' to 'who'
5570 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5571 'who' parameter, but make it None by default so builds forced by
5572 slave admins don't cause status mail to be sent to anybody
5573 (BotMaster.forceBuild): same. this method is deprecated.
5574 (DebugPerspective.perspective_forceBuild): same, use IControl.
5575 (DebugPerspective.perspective_fakeChange): use IControl..
5576 (Dispatcher.requestAvatar): .. so don't set .changemaster
5578 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5579 parameter to avoid confusion with the name of the builder
5582 * buildbot/status/mail.py: refine comment about needing 2.3
5584 * buildbot/status/html.py: move all imports to the top
5586 * buildbot/test/test_control.py: test new interfaces
5587 * buildbot/test/test_run.py (Status): handle new interfaces
5588 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5590 * buildbot/process/base.py (BuildControl): implement IBuildControl
5591 and its lonely getStatus() method
5593 * buildbot/process/builder.py (BuilderControl): implement
5594 IBuilderControl, obtained by adapting the Builder instance
5595 (Builder.startBuild): return a BuilderControl instead of a
5596 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5597 accomplish the same thing.
5599 * buildbot/master.py: move all import statements to the top
5600 (Control): implement IControl, obtained by adapting the
5601 BuildMaster instance.
5603 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5604 IBuildControl. These are used to force builds. Eventually they
5605 will provide ways to reconfigure the Builders, pause or abandon a
5606 Build, and perhaps control the BuildMaster itself.
5608 2004-09-26 Brian Warner <warner@lothar.com>
5610 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5611 ends up comparing us against something without a .__class__
5613 2004-09-24 Brian Warner <warner@lothar.com>
5615 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5616 usage text right.
5618 * Makefile: add 'deb-snapshot' target, to create a timestamped
5619 .deb package
5621 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5623 2004-09-23 Brian Warner <warner@lothar.com>
5625 * buildbot/__init__.py (version): move version string here
5626 * setup.py: get version string from buildbot.version
5627 * buildbot/status/html.py (WaterfallStatusResource.body): add
5628 buildbot version to the page footer
5629 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5630 version when asked
5632 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5633 slaves, let the second know where the first one is coming from
5634 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5635 see our exceptions. It would be nice if there were a way to just
5636 send them the exception type and value, not the full traceback.
5639 * buildbot/status/mail.py (MailNotifier): add a new argument
5640 sendToInterestedUsers=, which can be set to False to disable the
5641 usual send-to-blamelist behavior.
5642 (top): handle python-2.2 which has no email.MIMEMultipart
5643 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5644 (MailNotifier.disownServiceParent): unsubscribe on removal
5646 * buildbot/test/test_status.py (Mail.testBuild2): test it
5649 * buildbot/status/progress.py (Expectations.wavg): tolerate
5650 current=None, which happens when steps start failing badly
5651 * buildbot/test/test_status.py (Progress.testWavg): test for it
5653 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5654 doesn't understand args['revision'], emit a warning instead of
5655 bailing completely. Updating to -rHEAD is probably close enough.
5657 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5659 * buildbot/test/test_status.py: at least import bb.status.client
5660 even if we don't have any test coverage for it yet
5662 * contrib/svn_buildbot.py: don't require python2.3
5663 (main): wait, do require it (for sets.py), but explain how to
5664 make it work under python2.2
5666 2004-09-23 Brian Warner <warner@lothar.com>
5668 * contrib/svn_buildbot.py: include the revision number in the Change
5670 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5671 using util.now() because FreshCVS is a realtime service
5673 * buildbot/status/event.py: delete dead code
5674 * buildbot/process/step.py: don't import dead Event class
5675 * buildbot/process/step_twisted.py: same
5676 * buildbot/status/builder.py: same
5677 * buildbot/status/client.py: same
5679 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5681 * buildbot/changes/changes.py (Change): set .when from an __init__
5682 argument (which defaults to now()), rather than having
5683 ChangeMaster.addChange set it later.
5684 (ChangeMaster.addChange): same
5686 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5687 (parseSyncmail): same. Just use util.now() for now.
5688 (parseBonsaiMail): parse the timestamp field for when=
5690 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5691 instead of setting .when after the fact
5693 2004-09-22 slyphon
5695 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5696 results when the target project uses retrial. Still under
5697 development.
5698 * buildbot/test/test_trial.py: same
5700 2004-09-21 Brian Warner <warner@lothar.com>
5702 * buildbot/status/mail.py (MailNotifier.__init__): include
5703 success/warnings/failure in the Subject line
5704 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5705 use step.logname for the addLogs=True attachment filenames
5706 * buildbot/test/test_status.py (Mail): test Subject lines
5707 (Mail.testLogs): test attachment filenames
5709 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5710 accept a 'who' argument from the debug tool
5711 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5712 * contrib/debug.glade: add text box to set 'who'
5714 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5715 .getBuilderName with .getBuilder().getName(), more flexible
5716 (IStatusLog.getName): logs have short names, but you can prefix
5717 them with log.getStep().getName() to make them more useful
5718 * buildbot/status/builder.py: same
5719 * buildbot/status/client.py: same
5720 * buildbot/status/html.py: same
5721 * buildbot/test/test_run.py (Status.testSlave): same
5722 * buildbot/process/step.py: tweak logfile names
5724 * buildbot/status/mail.py (MailNotifier): add lookup, change
5725 argument to extraRecipients. The notifier is now aimed at sending
5726 mail to the people involved in a particular build, with additional
5727 constant recipients as a secondary function.
5729 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5730 including slow-lookup and failing-lookup. Make sure the blamelist
5731 members are included.
5733 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5734 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5735 (IBuildStatus.getInterestedUsers): new method
5736 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5737 * buildbot/status/client.py (remote_getResponsibleUsers): same
5738 * buildbot/status/html.py (StatusResourceBuild.body): same
5739 * buildbot/test/test_run.py (Status.testSlave): same
5741 2004-09-20 Brian Warner <warner@lothar.com>
5743 * docs/users.xhtml: update concepts
5745 * Makefile: add a convenience makefile, for things like 'make
5746 test'. It is not included in the source tarball.
5748 2004-09-16 Brian Warner <warner@lothar.com>
5750 * NEWS: mention /usr/bin/buildbot, debian/*
5752 * debian/*: add preliminary debian packaging. Many thanks to
5753 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5754 it considerably since it left their hands, I am responsible for
5755 all breakage that's resulted.
5757 * bin/buildbot: create a top-level 'buildbot' command, to be
5758 installed in /usr/bin/buildbot . For now it's just a simple
5759 frontend to mktap/twistd/kill, but eventually it will be the entry
5760 point to the 'try' command and also a status client. It is also
5761 intended to support the upcoming debian-packaging init.d scripts.
5762 * buildbot/scripts/runner.py: the real work is done here
5763 * buildbot/scripts/__init__.py: need this too
5764 * buildbot/scripts/sample.cfg: this is installed in new
5765 buildmaster directories
5766 * setup.py: install new stuff
5768 2004-09-15 Brian Warner <warner@lothar.com>
5770 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5771 'file:' schema (the version shipped with OS-X was built without the
5772 ra_local plugin).
5773 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5774 updates the log-timestamp, to make sure it isn't still running after
5775 the test finishes
5777 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5778 values to the config file.
5779 * docs/examples/hello.cfg: add examples
5780 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5781 * buildbot/status/builder.py (Status.getProjectURL): implement them
5782 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5783 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5784 * buildbot/status/html.py (WaterfallStatusResource): display them
5787 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5788 certain error cases don't suffer a secondary exception.
5789 (top): Skip tests if the corresponding VC tool is not installed.
5791 * buildbot/process/factory.py (Trial): introduce separate
5792 'buildpython' and 'trialpython' lists, since trialpython=[] is
5793 what you want to invoke /usr/bin/python, whereas ./setup.py is
5794 less likely to be executable. Add env= parameter to pass options
5795 to test cases (which is how I usually write tests, I don't know if
5796 anyone else does it this way).
5798 * buildbot/process/step_twisted.py (Trial): handle python=None.
5799 Require 'testpath' be a string, not a list. Fix tests= typo.
5800 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5802 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5803 way to deal with the possibility of removing the disconnect notify
5804 twice.
5805 (CVS): add a 'login' parameter to give a password to 'cvs login',
5806 commonly used with pserver methods (where pw="" or pw="guest")
5808 * buildbot/slave/commands.py (SourceBase): move common args
5809 extraction and setup() to __init__, so everything is ready by the
5810 time setup() is called
5811 (CVS.start): call 'cvs login' if a password was supplied
5812 (ShellCommand): special-case PYTHONPATH: prepend the master's
5813 value to any existing slave-local value.
5815 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5816 don't have a remote, mark the builder as Offline. This whole
5817 function should probably go away and be replaced by individual
5818 deltas.
5819 (Builder.buildFinished): return the results to the build-finished
5820 deferred callback, helps with testing
5822 2004-09-14 Brian Warner <warner@lothar.com>
5824 * buildbot/test/test_vc.py: put all the repositories needed to run
5825 the complete tests into a single small (1.3MB) tarball, so I can
5826 make that tarball available on the buildbot web site. Test HTTP
5827 access (for Arch and Darcs) by spawning a temporary web server
5828 while the test runs.
5830 * docs/users.xhtml: new document, describe Buildbot's limited
5831 understanding of different human users
5833 * buildbot/test/test_vc.py: rearrange test cases a bit
5835 * buildbot/process/step_twisted.py (Trial): handle testpath=
5836 * buildbot/process/factory.py (Trial): update to use step.Trial
5838 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5840 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5841 the overall build text (which gives you 'failed 2 tests' rather
5842 than just 'failed')
5843 (BuildStepStatus.text2): default to [], not None
5845 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5846 must be a list
5848 2004-09-12 Brian Warner <warner@lothar.com>
5850 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5851 log the whole exception if it's just an AttributeError (old slave)
5853 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5854 so (e.g.) sub-commands can be run in the right directory.
5855 (ShellCommand.start): accept an optional errorMessage= argument
5856 to make life easier for SVN.start
5857 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5858 headers
5859 (ShellCommand.start): move ['dir'] compatibility hack..
5860 (RemoteShellCommand.start): .. to here so everyone can use it
5862 * buildbot/process/step_twisted.py (Trial): use .workdir
5864 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5865 text displayed when debuild fails completely
5866 (Trial): snarf _trial_temp/test.log from the slave and display it
5868 2004-09-11 Brian Warner <warner@lothar.com>
5870 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5872 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5873 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5875 * buildbot/process/step.py (ShellCommand): call .createSummary
5876 before .evaluateCommand instead of the other way around. This
5877 makes it slightly easier to count warnings and then use that to
5878 set results=WARNINGS
5879 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5881 * buildbot/process/base.py (Build.buildFinished): update status
5882 before doing progress. It's embarrassing for the build to be stuck
5883 in the "building" state when an exceptions occurs elsewhere..
5885 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5886 python2.2 doesn't have 'sum'
5888 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5889 to prevent clients from accidentally sorting it
5891 * buildbot/master.py (Manhole): add username/password
5892 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5893 c['manholePort'], deprecate old usage
5894 * docs/config.xhtml: document c['manhole']
5895 * docs/examples/hello.cfg: show example of using a Manhole
5898 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5899 pretend the slave is up to date
5901 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5902 the module, overlaps with 'log', the local variable
5904 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5906 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5907 new method to let Steps find out the version of their
5908 corresponding SlaveCommand.
5909 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5910 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5911 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5912 (SVN.startVC): same
5913 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5914 (Arch.startVC): same
5915 (P4Sync.startVC): same
5917 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5918 Deferred so we can catch errors in remote_startCommand
5919 (RemoteShellCommand.start): same
5921 * docs/examples/twisted_master.cfg: update sample config file
5923 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5924 after connectionMade() is called, not before. Close stdin at that
5925 point too.
5927 * buildbot/process/process_twisted.py: update to use Trial, clean
5928 up argument passing (move to argv arrays instead of string
5929 commands)
5931 * buildbot/process/step_twisted.py (Trial): new step to replace
5932 RunUnitTests, usable by any trial-using project (not just
5933 Twisted). Arguments have changed, see the docstring for details.
5935 * buildbot/process/base.py (Build.startBuild): this now returns a
5936 Deferred. Exceptions that occur during setupBuild are now
5937 caught better and lead to fewer build_status weirdnesses, like
5938 finishing a build that was never started.
5939 (Build.buildFinished): fire the Deferred instead of calling
5940 builder.buildFinished directly. The callback argument is this
5941 Build, everything else can be extracted from it, including the
5942 new build.results attribute.
5943 * buildbot/process/builder.py (Builder.startBuild): same
5944 (Builder.buildFinished): same, extract results from build
5946 * buildbot/process/step.py (ShellCommands): remove dead code
5948 2004-09-08 Brian Warner <warner@lothar.com>
5950 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5951 doesn't try to use the leftover patched workdir
5952 (SourceStamp): test source-stamp computation for CVS and SVN
5954 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5955 patched workdir ('touch .buildbot-patched') so we don't try to
5956 update it later
5957 (SourceBase.start): add ['revision'] for all Source steps
5958 (CVS): change args: use ['branch'] for -r, remove ['files']
5959 (CVS.buildVC): fix revision/branch stuff
5960 (SVN): add revision stuff
5962 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5963 kwargs (except 'workdir') to avoid silent spelling errors
5964 (ShellCommand.__init__): same
5965 (Source): new base class for CVS/SVN/etc. Factor out everything
5966 common, add revision computation (perform the checkout with a -D
5967 DATE or -r REVISION that gets exactly the sources described by the
5968 last Change), overridable with step.alwaysUseLatest. Add patch
5969 handling (build.getSourceStamp can trigger the use of a base
5970 revision and a patch).
5971 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5972 * docs/steps.xhtml: update docs
5973 * docs/source.xhtml: mention .checkoutDelay
5974 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5976 * buildbot/process/base.py (Build.setSourceStamp): add a
5977 .sourceStamp attribute to each Build. If set, this indicates that
5978 the build should be done with something other than the most
5979 recent source tree. This will be used to implement "try" builds.
5980 (Build.allChanges): new support method
5981 (Build.lastChangeTime): remove, functionality moved to Source steps
5982 (Build.setupBuild): copy the Step args before adding ['workdir'],
5983 to avoid modifying the BuildFactory (and thus triggering spurious
5984 config changes)
5987 * buildbot/status/html.py: rename s/commits/changes/
5988 (StatusResourceChanges): same
5989 (CommitBox.getBox): same, update URL
5990 (WaterfallStatusResource): same
5991 (StatusResource.getChild): same
5993 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5994 * contrib/debug.glade: add optional 'revision' to the fakeChange
5996 * buildbot/changes/changes.py (html_tmpl): display .revision
5997 (ChangeMaster.addChange): note .revision in log
5998 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5999 accept a ['revision'] attribute
6001 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6003 * buildbot/master.py (BotMaster.getPerspective): update the
6004 .connected flag in SlaveStatus when it connects
6005 (BotMaster.detach): and when it disconnects
6006 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6007 (BuildMaster.loadConfig_Builders): walk old list correctly
6009 * buildbot/test/test_config.py: fix prefix= usage
6011 2004-09-06 Brian Warner <warner@lothar.com>
6013 * NEWS: mention P4
6015 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6016 poll a P4 depot looking for recent changes. Thanks to Dave
6017 Peticolas for the contribution. Probably needs some testing after
6018 I mangled it.
6020 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6021 requires manual client setup for each buildslave. Rather
6022 experimental. Thanks again to Dave Peticolas.
6023 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6025 * buildbot/changes/changes.py (Change): add a .revision attribute,
6026 which will eventually be used to generate source-stamp values.
6028 * buildbot/process/step.py (RemoteCommand.start): use
6029 notifyOnDisconnect to notice when we lose the slave, then treat it
6030 like an exception. This allows LogFiles to be closed and the build
6031 to be wrapped up normally. Be sure to remove the disconnect
6032 notification when the step completes so we don't accumulate a
6033 bazillion such notifications which will fire weeks later (when the
6034 slave finally disconnects normally). Fixes SF#915807, thanks to
6035 spiv (Andrew Bennetts) for the report.
6036 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6037 really isn't Logged- specific
6038 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6039 header, since it's almost always going to be appended to an
6040 incomplete line
6041 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6042 update test to handle use of notifyOnDisconnect
6044 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6045 don't clear .ETA and .currentBuild when going offline, let the
6046 current build clean up after itself
6048 * buildbot/process/builder.py (Builder.detached): wait a moment
6049 before doing things like stopping the current build, because the
6050 current step will probably notice the disconnect and cleanup the
6051 build by itself
6052 * buildbot/test/test_run.py (Status.tearDown): update test to
6053 handle asynchronous build-detachment
6055 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6057 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6058 hush a debug message
6060 2004-09-05 Brian Warner <warner@lothar.com>
6062 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6063 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6064 kernels do this: the fcntl module has the F_NOTIFY constant, but
6065 the kernel itself doesn't support the operation. Thanks to Olly
6066 Betts for spotting the problem.
6068 * buildbot/process/step.py (Darcs): new source-checkout command
6069 (Arch): new source-checkout command
6070 (todo_P4): fix constructor syntax, still just a placeholder
6071 * buildbot/test/test_vc.py (VC.testDarcs): test it
6072 (VC.testDarcsHTTP): same, via localhost HTTP
6073 (VC.testArch): same
6074 (VC.testArchHTTP): same
6075 * NEWS: mention new features
6077 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6078 which tells the step to stash stdout text locally (in .stdout).
6079 Slave-side Commands can use this to make decisions based upon the
6080 output of the the ShellCommand (not just the exit code).
6081 (Darcs): New source-checkout command
6082 (Arch): New source-checkout command, uses .keepStdout in one place
6083 where it needs to discover the archive's default name.
6085 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6086 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6087 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6089 * buildbot/process/step.py (ShellCommand.describe): add an
6090 alternate .descriptionDone attribute which provides descriptive
6091 text when the step is complete. .description can be ["compiling"],
6092 for use while the step is running, then .descriptionDone can be
6093 ["compile"], used alone when the step succeeds or with "failed" when
6094 it does not. Updated other steps to use the new text.
6095 * buildbot/process/step_twisted.py: same
6096 * buildbot/test/test_run.py: update tests to match
6098 2004-08-30 Brian Warner <warner@lothar.com>
6100 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6101 (CVS.__init__): send 'patch' argument to slave
6102 (CVS.start): don't create the LoggedRemoteCommand until start(),
6103 so we can catch a .patch added after __init__
6104 (SVN.__init__): add 'patch' to SVN too
6105 (SVN.start): same
6107 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6108 argument, to let commands push data into the process' stdin pipe.
6109 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6110 is in use, since closing a PTY doesn't really affect the process
6111 in the right way (in particular, I couldn't run /usr/bin/patch
6112 under a pty).
6113 (SourceBase.doPatch): handle 'patch' argument
6115 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6116 both CVS and SVN
6118 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6119 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6120 versions to master
6121 * buildbot/master.py (BotPerspective.got_commands): get command
6122 versions from slave, give to each builder
6123 * buildbot/process/builder.py (Builder.attached): stash slave
6124 command versions in .remoteCommands
6126 * docs/steps.xhtml: bring docs in-line with reality
6128 * buildbot/process/step.py (CVS.__init__): more brutal
6129 compatibility code removal
6130 (SVN.__init__): same
6132 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6133 (SlaveShellCommand.start): require ['workdir'] argument, remove
6134 the ['dir'] fallback (compatibility will come later)
6135 (SourceBase): update docs
6136 (SourceBase.start): remove ['directory'] fallback
6137 (CVS): update docs
6138 (SVN): update docs
6139 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6140 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6141 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6143 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6144 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6145 code.. I will figure out 0.5.0-compatibility hooks later)
6147 2004-08-30 Brian Warner <warner@lothar.com>
6149 * buildbot/process/process_twisted.py: rewrite in terms of new
6150 BuildFactory base class. It got significantly shorter. Yay
6151 negative code days.
6153 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6154 work with the new "self.build isn't nailed down until we call
6155 step.start()" scheme: specifically, __init__ is called before the
6156 build has decided on which Changes are going in, so we don't scan
6157 build.allFiles() for .xhtml files until start()
6158 (HLint.commandComplete): use getText(), not getStdout()
6159 (RunUnitTests.start): same: don't use .build until start()
6160 (RunUnitTests.describe): oops, don't report (None) when using
6161 the default reactor
6162 (RunUnitTests.commandComplete): use getText()
6163 (RunUnitTests.createSummary): same
6164 (BuildDebs.commandComplete): same
6166 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6167 set args['command'] until start(), since our BuildStep is allowed
6168 to change their mind up until that point
6169 (TreeSize.commandComplete): use getText(), not getStdout()
6171 * docs/examples/twisted_master.cfg: update to current standards
6173 * docs/factories.xhtml: update
6174 * buildbot/process/factory.py: implement all the common factories
6175 described in the docs. The Trial factory doesn't work yet, and
6176 I've probably broken all the process_twisted.py factories in the
6177 process. There are compatibility classes left in for things like
6178 the old BasicBuildFactory, but subclasses of them are unlikely to
6179 work.
6180 * docs/examples/glib_master.cfg: use new BuildFactories
6181 * docs/examples/hello.cfg: same
6183 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6184 explicit 'workdir' args
6186 * buildbot/process/base.py (BuildFactory): move factories to ..
6187 * buildbot/process/factory.py (BuildFactory): .. here
6188 * buildbot/process/process_twisted.py: handle move
6189 * buildbot/test/test_config.py: same
6190 * buildbot/test/test_run.py: same
6191 * buildbot/test/test_steps.py: same
6192 * buildbot/test/test_vc.py: same
6193 * docs/factories.xhtml: same
6195 * NEWS: mention config changes that require updating master.cfg
6197 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6198 argument to all steps that weren't given one already, pointing at
6199 the "build/" directory.
6201 * docs/examples/hello.cfg: remove explicit 'workdir' args
6203 * docs/factories.xhtml: document standard BuildFactory clases,
6204 including a bunch which are have not yet been written
6206 2004-08-29 Brian Warner <warner@lothar.com>
6208 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6209 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6210 buildbot.status.builder so they aren't quite so internal
6211 * buildbot/process/base.py, buildbot/process/builder.py: same
6212 * buildbot/process/maxq.py, buildbot/process/step.py: same
6213 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6214 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6215 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6217 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6218 to handle new getLogs()-returns-list behavior
6219 (StatusResourceBuildStep.getChild): same
6220 (StepBox.getBox): same
6221 (WaterfallStatusResource.phase0): same
6223 * docs/source.xhtml: document how Buildbot uses version-control
6224 systems (output side: how we get source trees)
6225 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6226 systems (input side: how we learn about Changes)
6228 * buildbot/master.py (Manhole): use ComparableMixin
6229 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6230 * buildbot/changes/mail.py (MaildirSource): same
6231 * buildbot/status/client.py (PBListener): same
6232 * buildbot/status/html.py (Waterfall): same
6233 * buildbot/status/words.py (IRC): same
6235 * NEWS: start describing new features
6237 * buildbot/status/mail.py (MailNotifier): finish implementation.
6238 The message body is still a bit sparse.
6239 * buildbot/test/test_status.py (Mail): test it
6241 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6242 and __hash__ methods I wind up adding everywhere. Specifically
6243 intended to support the buildbot config-file update scheme where
6244 we compare, say, the old list of IStatusTargets against the new
6245 one and don't touch something which shows up on both lists.
6246 * buildbot/test/test_util.py (Compare): test case for it
6248 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6249 return a list instead of a dict
6250 (IBuildStepStatus.getLogs): same. The idea is that steps create
6251 logs with vaguely unique names (although their uniqueness is not
6252 guaranteed). Thus a compilation step should create its sole
6253 logfile with the name 'compile', and contribute it to the
6254 BuildStatus. If a step has two logfiles, try to create them with
6255 different names (like 'test.log' and 'test.summary'), and only
6256 contribute the important ones to the overall BuildStatus.
6257 * buildbot/status/builder.py (Event.getLogs): same
6258 (BuildStepStatus): fix default .text and .results
6259 (BuildStepStatus.addLog): switch to list-like .getLogs()
6260 (BuildStepStatus.stepFinished): same
6261 (BuildStatus.text): fix default .text
6262 (BuildStatus.getLogs): temporary hack to return all logs (from all
6263 child BuildStepStatus objects). Needs to be fixed to only report
6264 the significant ones (as contributed by the steps themselves)
6265 * buildbot/test/test_run.py: handle list-like .getLogs()
6266 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6268 2004-08-28 Brian Warner <warner@lothar.com>
6270 * buildbot/process/builder.py (Builder.attached): serialize the
6271 attachment process, so the attach-watcher isn't called until the
6272 slave is really available. Add detached watchers too, which makes
6273 testing easier.
6275 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6277 * buildbot/test/test_swap.py: remove dead code
6279 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6280 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6281 sort of as if the command being run exited with a -1. There may
6282 still be some holes in this scheme.
6283 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6284 -r option appears before the module list
6285 * buildbot/process/step.py (CVS): add 'revision' argument
6287 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6288 when sending updates or stepComplete messages to the master, since
6289 we don't currently care whether they arrive or not. When we revamp
6290 the master/slave protocol to really resume interrupted builds,
6291 this will need revisiting.
6292 (lostRemote): remove spurious print
6294 * buildbot/master.py (BotPerspective.attached): serialize the
6295 new-builder interrogation process, to make testing easier
6296 (BotMaster.waitUntilBuilderDetached): convenience function
6298 * buildbot/status/builder.py (BuilderStatus): prune old builds
6299 (BuildStatus.pruneSteps): .. and steps
6300 (BuildStepStatus.pruneLogs): .. and logs
6301 (BuilderStatus.getBuild): handle missing builds
6302 * buildbot/status/html.py (StatusResourceBuild.body): display build
6303 status in the per-build page
6304 (BuildBox.getBox): color finished builds in the per-build box
6306 2004-08-27 Brian Warner <warner@lothar.com>
6308 * buildbot/status/mail.py (MailNotifier): new notification class,
6309 not yet finished
6311 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6312 variants of a common base class which handles all the mode= logic
6314 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6315 convenience method
6316 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6318 2004-08-26 Brian Warner <warner@lothar.com>
6320 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6321 interfaces
6323 * buildbot/test/test_run.py: update to new Logfile interface, new
6324 buildbot.slave modules
6325 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6327 * MANIFEST.in: new sample config file
6328 * docs/examples/hello.cfg: same
6330 * buildbot/process/step_twisted.py: remove dead import
6332 * buildbot/process/step.py (RemoteCommand.run): catch errors
6333 during .start
6334 (RemoteCommand.remote_update): ignore updates that arrive after
6335 we've shut down
6336 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6337 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6338 the responsibilities of the subclass's methods
6339 (BuildStep.failed): catch errors during failure processing
6340 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6341 (CVS): move to a mode= argument (described in docstring), rather
6342 than the ungainly clobber=/export=/copydir= combination.
6343 (SVN): add mode= functionality to SVN too
6344 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6346 * buildbot/process/base.py (Build.startNextStep): catch errors
6347 during s.startStep()
6349 * buildbot/clients/base.py: update to new PB client interface.
6350 gtkPanes is still broken
6352 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6353 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6354 * setup.py: add buildbot.slave module
6355 * buildbot/bb_tap.py: handle move
6356 * buildbot/slave/registry.py: place to register commands, w/versions
6357 * buildbot/slave/bot.py: major simplifications
6358 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6359 instead of a fixed table. Eventually this will make the slave more
6360 extensible. Use 'start' method on the command, not .startCommand.
6361 Fix unsafeTracebacks handling (I think).
6362 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6363 helper class with a .start method that returns a Deferred.
6364 SlaveShellCommand is the form reached by the buildmaster. Commands
6365 which use multiple ShellCommands can just chain them as Deferreds,
6366 with some helper methods in Command (_abandonOnFailure and
6367 _checkAbandoned) to bail on rc!=0.
6368 (CVSCommand): prefer new mode= argument
6369 (SVNFetch): add mode= argument
6371 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6372 put a useful reason string on the build
6374 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6375 core functionality into an IStatusLog object
6376 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6377 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6378 (StatusResourceBuild.body): use proper accessor methods
6379 * buildbot/status/client.py (RemoteLog): PB-access goes here
6380 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6381 which delivers log contents too
6382 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6383 * buildbot/status/event.py: remove old Logfile completely
6385 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6386 subscription interface for IStatusLog subscriptions just like all
6387 other the status subscriptions
6388 (IStatusReceiver.logChunk): method called on subscribers
6390 2004-08-24 Brian Warner <warner@lothar.com>
6392 * buildbot/process/builder.py (Builder._pong): oops, ping response
6393 includes a result (the implicit None returned by remote_print).
6394 Accept it so the _pong method handles the response correctly.
6396 2004-08-06 Brian Warner <warner@lothar.com>
6398 * buildbot/test/test_config.py: update IRC, PBListener tests
6400 * buildbot/status/client.py (StatusClientPerspective): total
6401 rewrite to match new IStatus interfaces. New subscription scheme.
6402 There are still a few optimizations to make (sending down extra
6403 information with event messages so the client doesn't have to do a
6404 round trip). The logfile-retrieval code is probably still broken.
6405 Moved the PB service into its own port, you can no longer share a
6406 TCP socket between a PBListener and, say, the slaveport (this
6407 should be fixed eventually).
6408 * buildbot/clients/base.py (Client): revamp to match. still needs
6409 a lot of work, but basic event reporting works fine. gtkPanes is
6410 completely broken.
6412 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6413 instance talks to a single irc server. Threw out all the old
6414 multi-server handling code. Still need to add back in
6415 builder-control (i.e. "force build")
6417 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6418 more random text to the as-yet-unreachable per-step page
6420 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6421 rename to stepETAUpdate
6422 (BuildStatus.subscribe): add build-wide ETA updates
6423 (BuilderStatus.getState): remove more cruft
6424 (BuilderStatus.getCurrentBuild): remove more cruft
6425 (BuilderStatus.buildStarted): really handle tuple-subscription
6426 * buildbot/test/test_run.py (Status.testSlave): handle the
6427 stepETAUpdate rename
6429 * buildbot/master.py (BuildMaster): don't add a default
6430 StatusClientService. Don't add a default IrcStatusFactory. Both
6431 are now added through c['status'] in the config file. c['irc'] is
6432 accepted for backwards compatibility, the only quirk is you cannot
6433 use c['irc'] to specify IRC servers on ports other than 6667.
6435 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6436 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6437 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6438 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6441 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6442 the buildmaster to re-read its config file
6445 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6446 find out the port our server is running on
6447 (WebTest.test_webPathname_port): same
6449 * buildbot/test/test_config.py (testWebPortnum): test it
6450 (testWebPathname): ditto
6452 * docs/config.xhtml: document new c['status'] configuration option
6454 * buildbot/status/html.py (Waterfall): new top-level class which
6455 can be added to c['status']. This creates the Site as well as the
6456 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6457 reachable as .parent, for everything.
6459 * buildbot/master.py (Manhole): make it a normal service Child
6460 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6461 webPathname. It will eventually replace c['irc'] and the implicit
6462 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6463 in as (deprecated) backward compatibility hooks for now.
6466 * buildbot/process/builder.py (Builder.buildFinished): don't
6467 inform out builder_status about a finished build, as it finds out
6468 through its child BuildStatus object
6470 * buildbot/status/html.py: extensive revamp. Use adapters to make
6471 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6472 have both starting and finishing times and adjust the waterfall
6473 display accordingly, using spacers if necessary. Use SlaveStatus
6474 to get buildslave info.
6475 (StatusResourceBuildStep): new just-one-step resource, used to get
6476 logfiles. No actual href to it yet.
6478 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6479 the time being, until I get the file-naming scheme right
6481 * buildbot/status/builder.py (Event): clean started/finished names
6482 (BuildStatus.isFinished): .finished is not None is the right test
6483 (BuildStatus.buildStarted): track started/finished times ourselves
6484 (BuilderStatus.getSlave): provide access to SlaveStatus object
6485 (BuilderStatus.getLastFinishedBuild): all builds are now in
6486 .builds, even the currently-running one. Accomodate this change.
6487 (BuilderStatus.eventGenerator): new per-builder event generator.
6488 Returns BuildStepStatus and BuildStatus objects, since they can
6489 both be adapted as necessary.
6490 (BuilderStatus.addEvent): clean up started/finished attributes
6491 (BuilderStatus.startBuild,finishBuild): remove dead code
6492 (SlaveStatus): new object to provide ISlaveStatus
6494 * buildbot/process/step.py (ShellCommand.getColor): actually
6495 return the color instead of setting it ourselves
6496 (CVS.__init__): pull .timeout and .workdir options out of
6497 **kwargs, since BuildStep will ignore them. Without this neither
6498 will be sent to the slave correctly.
6499 (SVN.__init__): same
6501 * buildbot/process/builder.py (Builder): move flags to class-level
6502 attributes
6503 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6504 SlaveStatus handle that
6506 * buildbot/process/base.py (Build.firstEvent): remove dead code
6507 (Build.stopBuild): bugfix
6509 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6511 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6512 (ChangeMaster.eventGenerator): yield Changes, since there are now
6513 Adapters to turn them into HTML boxes
6515 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6516 (BotPerspective.attached): feed a SlaveStatus object
6517 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6518 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6520 * buildbot/interfaces.py: API additions
6521 (ISlaveStatus): place to get slave status
6523 2004-08-04 Brian Warner <warner@lothar.com>
6525 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6526 the delay finishes, so the step is marked as SUCCESS
6528 * buildbot/test/test_run.py (Status.testSlave): cover more of
6529 IBuildStatus and IBuildStepStatus
6531 * buildbot/status/progress.py (StepProgress): move some flags to
6532 class-level attributes
6533 (StepProgress.remaining): if there are no other progress metrics
6534 to go by, fall back to elapsed time
6535 (StepProgress.setExpectations): take a dict of metrics instead of
6536 a list
6537 (BuildProgress.setExpectationsFrom): pull expectations from the
6538 Expectations, instead of having it push them to the BuildProgress
6539 (Expectations): move some flags to class-level attributes
6540 (Expectations.__init__): copy per-step times from the
6541 BuildProgress too
6542 (Expectations.expectedBuildTime): new method for per-build ETA
6544 * buildbot/status/event.py (Logfile): move some flags to
6545 class-level attributes
6546 (Logfile.logProgressTo): better method name, let step set the
6547 progress axis name (instead of always being "output")
6549 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6550 times directly, rather than depending upon the (possibly missing)
6551 .progress object. Use 'None' to indicate "not started/finished
6552 yet"
6553 (BuildStepStatus.getExpectations): oops, return the full list of
6554 expectations
6555 (BuilderStatus._buildFinished): append finished builds to .builds
6557 * buildbot/process/step.py (BuildStep): add separate .useProgress
6558 flag, since empty .progressMetrics[] still implies that time is a
6559 useful predictor
6560 (CVS): set up the cmd in __init__, instead of waiting for start()
6562 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6563 calculation, this will eventually turn into a proper sourceStamp
6564 (Build.setupBuild): tell the Progress to load from the Expectations,
6565 instead of having the Expectations stuff things into the Progress
6566 (Build.buildException): add a build-level errback to make sure the
6567 build's Deferred fires even in case of exceptions
6569 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6570 the forced build
6571 * buildbot/process/builder.py (Builder.forceBuild): convey the
6572 reason instead of creating a fake Change
6574 * docs/examples/twisted_master.cfg: update to match reality
6576 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6577 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6578 fix or remove broken/breaking tests
6580 * buildbot/status/event.py (Logfile.__len__): remove evil method
6582 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6583 missing .build, for test convenience
6585 * buildbot/process/step_twisted.py: import fixes
6587 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6589 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6590 .statusbag reference
6592 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6593 connection at shutdown, and stop it from reconnecting
6595 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6596 chase down remote-execution bugs
6598 * buildbot/process/step.py: more fixes, remove
6599 BuildStep.setStatus()
6600 * buildbot/status/builder.py: move setStatus() functionality into
6601 BuildStatus.addStep
6602 * buildbot/status/event.py: minor fixes
6604 2004-08-03 Brian Warner <warner@lothar.com>
6606 * buildbot/process/base.py, buildbot/process/builder.py
6607 * buildbot/process/step.py, buildbot/status/builder.py
6608 * buildbot/status/event.py, buildbot/test/test_run.py:
6609 fix status delivery, get a basic test case working
6610 * buildbot/master.py: finish implementing basic status delivery,
6611 temporarily disable HTML/IRC/PB status sources
6613 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6615 * buildbot/status/progress.py (BuildProgress): remove dead code
6617 * buildbot/interfaces.py
6618 * buildbot/process/base.py, buildbot/process/builder.py
6619 * buildbot/process/step.py, buildbot/process/step_twisted.py
6620 * buildbot/status/builder.py: Complete overhaul of the all
6621 status-delivery code, unifying all types of status clients (HTML,
6622 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6623 look like. This commit is a checkpointing of the work-in-progress:
6624 the input side is mostly done (Builders/Builds sending status
6625 to the BuilderStatus/BuildStatus objects), but the output side has
6626 not yet been started (HTML resources querying BuilderStatus
6627 objects). Things are probably very broken right now and may remain
6628 so for several weeks, I apologize for the disruption.
6630 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6631 HTML as the log's contents. Currently used for exception tracebacks.
6632 * buildbot/status/progress.py: minor spelling changes
6634 2004-08-02 Brian Warner <warner@lothar.com>
6636 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6637 in mozilla. Also added stylesheets copied from Twisted's docs.
6638 Remember that these files are meant to be run through Lore first.
6639 Thanks to Philipp Frauenfelder for the fixes.
6640 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6641 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6642 * docs/template.tpl: added a Lore template
6644 2004-07-29 Brian Warner <warner@lothar.com>
6646 * buildbot/interfaces.py: revamp status delivery. This is the
6647 preview: these are the Interfaces that will be provided by new
6648 Builder code, and to which the current HTML/IRC/PB status
6649 displayers will be adapted.
6651 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6652 on the SlaveBuilder, not the Bot.
6653 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6654 SlaveBuilder.usePTY
6655 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6656 set .usePTY on the FakeSlaveBuilder
6658 2004-07-25 Brian Warner <warner@lothar.com>
6660 * buildbot/changes/freshcvs.py: add some debug log messages
6661 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6662 disabled 'setFilter' syntax
6663 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6664 don't end with a slash
6666 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6668 * setup.py: bump to 0.5.0+ while between releases
6670 2004-07-23 Brian Warner <warner@lothar.com>
6672 * setup.py (version): Releasing buildbot-0.5.0
6674 2004-07-23 Brian Warner <warner@lothar.com>
6676 * README: update for 0.5.0 release
6678 * NEWS: update for 0.5.0 release
6680 2004-07-22 Brian Warner <warner@lothar.com>
6682 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6683 mktap-time configuration flag (--usepty=1, --usepty=0)
6684 * buildbot/bot.py: same
6686 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6687 an 'info' directory being unwanted
6689 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6690 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6691 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6692 and earlier), use a FreshCVSSourceOldcred instead.
6693 (test): simple test routine: connect to server, print changes
6695 * buildbot/changes/changes.py (Change.getTime): make it possible
6696 to print un-timestamped changes
6698 * buildbot/master.py (makeApp): delete ancient dead code
6699 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6700 * buildbot/test/test_config.py (testFindConfigFile): test it
6702 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6703 instead of win32 one
6706 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6707 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6708 details.
6710 * buildbot/process/base.py (Builder.__init__): change constructor
6711 to accept a dictionary of config data, rather than discrete
6712 name/slave/builddir/factory arguments
6714 * docs/examples/twisted_master.cfg: update to new syntax
6715 * docs/examples/glib_master.cfg: same
6716 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6717 rough tests of the new syntax
6720 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6721 to be an int, which means "run a web.distrib sub-server on a TCP
6722 port". This lets you publish the buildbot status page to a remote
6723 twisted.web server (using distrib.ResourceSubscription). Also
6724 rename the local attributes used to hold these web things so
6725 they're more in touch with reality.
6726 * buildbot/test/test_web.py: test webPortnum and webPathname
6727 * docs/config.xhtml: document this new use of webPathname
6729 * docs/config.xhtml: new document, slightly ahead of reality
6731 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6732 'prefix' handling: treat it as a simple string to check with
6733 .startswith, instead of treating it as a directory. This allows
6734 sub-directories to be used. If you use prefix=, you should give it
6735 a string that starts just below the CVSROOT and ends with a slash.
6736 This prefix will be stripped from all filenames, and filenames
6737 which do not start with it will be ignored.
6739 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6741 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6742 and --exclude (inverse of --include). SVN post-commit hooks
6743 now have total control over which changes get sent to buildbot and which
6744 do not.
6746 2004-07-10 Brian Warner <warner@lothar.com>
6748 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6749 test case to match new API
6751 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6752 which crashed HTML display when self.entries=[] (needed to
6753 distinguish between [], which means "no entries yet", and None,
6754 which means "the entries have been swapped out to disk, go fetch
6755 them").
6757 2004-07-04 Brian Warner <warner@lothar.com>
6759 * buildbot/process/step_twisted.py (countFailedTests): Count
6760 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6761 10kb from the end because any import errors are wedged there and
6762 they would make us think the test log was unparseable.
6763 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6765 2004-06-26 Brian Warner <warner@lothar.com>
6767 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6768 delete-*.pyc command into an actual BuildStep, so we can label it
6769 nicely
6770 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6771 (FullTwistedBuildFactory): same
6773 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6775 * contrib/fakechange.py: Add an errback when sending the fake
6776 change, so we know it didn't work.
6778 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6780 * buildbot/process/step_twisted.py: Delete *.pyc files before
6781 calling trial, so it doesn't catch any old .pyc files whose .py
6782 files have been moved or deleted.
6784 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6785 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6786 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6787 instead of ["twisted.test"], so that the end result is "trial -R
6788 twisted".
6790 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6791 regular expression to match filenames that should be ignored when
6792 changed. Also add a --revision parameter that specifies the
6793 revision to examine, which is useful for debugging.
6795 2004-06-25 Brian Warner <warner@lothar.com>
6797 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6798 summary of warnings (like DeprecationWarnings), next to the
6799 "summary" file
6801 2004-05-13 Brian Warner <warner@lothar.com>
6803 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6804 we now have a w32 build slave courtesy of Mike Taylor.
6806 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6807 so broken. Fixed a race condition that tripped up interlocked
6808 builds and caused the status to be stuck at "Interlocked" forever.
6809 The twisted buildbot's one interlocked build just so happened to
6810 never hit this case until recently (the feeding builds both pass
6811 before the interlocked build is attempted.. usually it has to wait
6812 a while).
6813 (Builder._pong_failed): fix method signature
6815 * setup.py: bump to 0.4.3+ while between releases
6817 2004-04-30 Brian Warner <warner@lothar.com>
6819 * setup.py (version): Releasing buildbot-0.4.3
6821 2004-04-30 Brian Warner <warner@lothar.com>
6823 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6825 * README: update for 0.4.3 release
6827 * NEWS: update for 0.4.3 release
6829 * buildbot/master.py (BuildMaster.__getstate__): make sure
6830 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6832 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6833 .trial as a class attribute, for upgrade from 0.4.2
6835 * buildbot/changes/changes.py (Change.links): add .links for
6836 upgrade from 0.4.2
6838 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6839 .textWatchers and .htmlWatchers at save time, since they are both
6840 volatile, should allow smooth 0.4.2 upgrade
6842 * buildbot/process/step.py (CVS.finishStatus): catch failed
6843 CVS/SVN commands so we can make the status box red
6845 2004-04-29 Brian Warner <warner@lothar.com>
6847 * buildbot/changes/freshcvs.py
6848 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6849 code to do setFilter(), which tells the freshcvs daemon to not
6850 send us stuff that we're not interested in. I will uncomment it
6851 when a new version of CVSToys is available in which setFilter()
6852 actually works, and I get a chance to test it better.
6854 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6856 * buildbot/master.py (Dispatcher): use a registration scheme
6857 instead of hardwired service names
6858 (BuildMaster): keep track of the Dispatcher to support
6859 registration
6861 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6862 PBChangeSource class instead of having it be an undocumented
6863 internal feature of the ChangeMaster. Split out the code into a
6864 new file.
6865 * buildbot/changes/pb.py (PBChangeSource): same
6866 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6868 * docs/{factories|sources|steps}.xhtml: document some pieces
6870 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6871 using FCMaildirSource
6872 (f23osx): update OS-X builder to use python2.3, since the slave
6873 was updated to Panther (10.3.3)
6875 2004-03-21 Brian Warner <warner@lothar.com>
6877 * buildbot/process/process_twisted.py: factor out doCheckout, change
6878 to use SVN instead of CVS
6880 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6881 an SVN subclass easier
6882 (BasicSVN): subclass which uses Subversion instead of CVS
6884 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6886 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6887 of /bin/sh on win32
6888 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6890 2004-02-25 Brian Warner <warner@lothar.com>
6892 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6893 is now either a list (which is passed to spawnProcess directly) or
6894 a string (which gets passed to /bin/sh -c). This removes the useSH
6895 flag and the ArgslistCommand class. Also send status header at the
6896 start and end of each command, instead of having the master-side
6897 code do that.
6898 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6899 -r'. Update to use list-based arguments.
6900 (SVNFetch): use list-based arguments, use ['dir'] argument to
6901 simplify code.
6902 * buildbot/test/test_steps.py (Commands): match changes
6904 * buildbot/process/step.py (InternalShellCommand.words): handle
6905 command lists
6906 (SVN): inherit from CVS, cleanup
6908 * buildbot/status/event.py (Logfile.content): render in HTML, with
6909 stderr in red and headers (like the name of the command we're
6910 about to run) in blue. Add link to a second URL (url + "?text=1")
6911 to get just stdout/stderr in text/plain without markup. There is
6912 still a problem with .entries=None causing a crash, it seems to occur
6913 when the logfile is read before it is finished.
6915 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6916 timeout to the keepalives, and use it to explicitly do a
6917 loseConnection instead of waiting for TCP to notice the loss. This
6918 ought to clear up the silent-lossage problem.
6919 (unsafeTracebacks): pass exception tracebacks back to the master,
6920 makes it much easier to debug problems
6922 2004-02-23 Brian Warner <warner@lothar.com>
6924 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6925 the whole command to /bin/sh instead of execve [Johan Dahlin]
6926 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6927 '-r HEAD' [Johan Dahlin]
6928 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6930 * buildbot/changes/changes.py (Change): add links= argument, add
6931 asHTML method [Johan Dahlin]. Modified to make a bit more
6932 XHTMLish. Still not sure how to best use links= .
6934 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6935 Change.asHTML to display the change, not asText
6937 * buildbot/status/html.py (StatusResourceBuilder): web button to
6938 ping slave
6940 * buildbot/test/test_run.py: test to actually start a buildmaster
6941 and poke at it
6943 * MANIFEST.in: bring back accidentally-dropped test helper files
6945 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6946 that require cvstoys if it is not installed
6948 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6949 values of "bin/trial" [Dave Peticolas]
6950 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6951 tests passed" when we didn't happen to run any tests
6953 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6954 flunkOnFailure [Johan Dahlin]
6956 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6957 multiple instances of the same Step class by suffixing "_2", etc,
6958 to the name until it is unique. This name needs to be unique
6959 because it is used as a key in the dictionary that tracks build
6960 progress.
6961 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6962 add test for it
6964 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6966 2004-01-14 Brian Warner <warner@lothar.com>
6968 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6969 kicked from a channel, log it
6971 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6972 something over whatever IRC channels the buildmaster is currently
6973 connected to. Added to try and track down a problem in which the
6974 master thinks it is still connected but the IRCd doesn't see it. I
6975 used a styles.Versioned this time, so hopefully users won't have
6976 to rebuild their .tap files this time.
6977 * contrib/debug.glade: add a "Poke IRC" button
6978 * contrib/debugclient.py: same
6980 * setup.py: bump to 0.4.2+ while between releases
6982 2004-01-08 Brian Warner <warner@lothar.com>
6984 * setup.py (version): Releasing buildbot-0.4.2
6986 2004-01-08 Brian Warner <warner@lothar.com>
6988 * NEWS: update for 0.4.2 release
6990 * README: document how to run the tests, now that they all pass
6992 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6994 * buildbot/process/step.py (CVS): add a global_options= argument,
6995 which lets you set CVS global options for the command like "-r"
6996 for read-only checkout, or "-R" to avoid writing in the
6997 repository.
6998 * buildbot/slavecommand.py (CVSCommand): same
7000 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7001 testing easier (it is turned off when testing, to avoid the
7002 leftover timer)
7004 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7005 to make it easier to test: break generateStepID() out to a
7006 separate function, only update statusbag if it exists.
7007 (ShellCommands): create useful text for dict-based commands too.
7009 * test/*, buildbot/test/*: move unit tests under the buildbot/
7010 directory
7011 * setup.py (packages): install buildbot.test too
7013 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7014 * buildbot/test/test_steps.py: fix it, tests pass now
7016 2004-01-06 Brian Warner <warner@lothar.com>
7018 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7019 freshcvs mail uses a slightly different syntax for new
7020 directories. Update parser to handle either.
7021 * test/test_mailparse.py (Test1.testMsg9): test for same
7023 2003-12-21 Brian Warner <warner@lothar.com>
7025 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7026 'warnOnWarnings' so that lintian errors mark the build orange
7028 2003-12-17 Brian Warner <warner@lothar.com>
7030 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7031 messages emitted by Bonsai, contributed by Stephen Davis.
7033 * test/*: moved all tests to use trial instead of unittest. Some
7034 still fail (test_steps, test_slavecommand, and test_process).
7036 * setup.py (version): bump to 0.4.1+ while between releases
7038 2003-12-09 Brian Warner <warner@lothar.com>
7040 * setup.py (version): Releasing buildbot-0.4.1
7042 2003-12-09 Brian Warner <warner@lothar.com>
7044 * NEWS: update for 0.4.1 release
7046 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7047 freebsd builder code a little bit
7049 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7050 don't try to compare attributes of different classes
7051 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7052 (MaildirSource.messageReceived): fix Change delivery
7054 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7055 into the config file's namespace before loading it, like the
7056 documentation claims it does
7057 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7058 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7059 daemon comes back online
7061 2003-12-08 Brian Warner <warner@lothar.com>
7063 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7064 so the example will work with online=0 as well
7066 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7067 fix the __implements__ line
7069 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7070 class a twisted.application.service.Service, use startService to
7071 get it moving.
7073 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7074 directory fd instead of simple open(). I'm sure this used to work,
7075 but the current version of python refuses to open directories with
7076 open().
7078 2003-12-05 Brian Warner <warner@lothar.com>
7080 * setup.py (version): bump to 0.4.0+ while between releases
7082 2003-12-05 Brian Warner <warner@lothar.com>
7084 * setup.py (version): Releasing buildbot-0.4.0
7086 2003-12-05 Brian Warner <warner@lothar.com>
7088 * docs/examples/glib_master.cfg: replace old sample scripts with
7089 new-style config files
7090 * MANIFEST.in: include .cfg files in distribution tarball
7092 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7093 implement a dummy method to avoid the exception that occurs when
7094 freshcvs sends this to us.
7096 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7097 removed the method, as it broke reconnection. Apparently
7098 stopFactory is called each time the connection attempt fails. Must
7099 rethink this.
7100 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7101 attribute before serialization, since without stopFactory the
7102 reconnect timer may still be active and they aren't serializable.
7104 * test/test_mailparse.py (ParseTest): test with 'self' argument
7106 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7107 argument, as these "functions" are invoked like methods from class
7108 attributes and therefore always get an instance as the first
7109 argument.
7111 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7112 message: thanks to Stephen Davis for the catch
7114 2003-12-04 Brian Warner <warner@lothar.com>
7116 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7117 twisted's standard ReconnectingClientFactory. Handles both oldcred
7118 and newcred connections. Also has a bug-workaround for
7119 ReconnectingClientFactory serializing its connector when it
7120 shouldn't.
7122 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7123 pbutil. Replace makeApp stuff with proper newcred/mktap
7124 makeService(). Don't serialize Ephemerals on shutdown.
7126 * buildbot/changes/changes.py (ChangeMaster): make it a
7127 MultiService and add the sources as children, to get startService
7128 and stopService for free. This also gets rid of the .running flag.
7130 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7131 new pbutil, turn into a TCPClient at the same time (to get
7132 startService for free). Two variants exist: FreshCVSSourceOldcred
7133 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7134 yet, but when it does, we'll be ready).
7135 (FreshCVSSource.notify): handle paths which are empty after the
7136 prefix is stripped. This only happens when the top-level (prefix)
7137 directory is added, at the very beginning of a Repository's life.
7139 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7140 Now the only reconnecting code is in the factory where it belongs.
7141 (Builder.unsubscribe): unregister the disconnect callback when we
7142 delete the builder on command from the master (i.e. when the
7143 buildmaster is reconfigured and that builder goes away). This
7144 fixes a multiple-delete exception when the status client is shut
7145 down afterwards.
7146 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7147 base Client.
7149 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7150 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7152 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7154 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7155 a list of globs (ugh). The testdir will be searched for files
7156 named *.tests and run the tests in the order specified in each of
7157 those files. This allows for "dependancies" between tests to be
7158 codified.
7160 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7161 argument to pass to run_maxq.py, instead of a glob.
7163 2003-10-17 Brian Warner <warner@lothar.com>
7165 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7166 files that live in the sandbox
7168 2003-10-15 Brian Warner <warner@lothar.com>
7170 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7171 spelling error in "docs" count-warnings output
7172 (HLint.start): stupid thinko meant .xhtml files were ignored
7174 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7175 tests now that cReactor is banished to the sandbox
7177 2003-10-10 Brian Warner <warner@lothar.com>
7179 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7180 scheme: now .xhtml are sources and .html are generated
7182 2003-10-08 Brian Warner <warner@lothar.com>
7184 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7185 we were ignoring the 'randomly' parameter.
7187 2003-10-01 Brian Warner <warner@lothar.com>
7189 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7190 posix, to kill sub-children of aborted slavecommands.
7192 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7193 Clean up initialization: lastBuildStatus remains None until the
7194 first build has been completed.
7196 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7197 None as a lastBuildStatus
7198 * buildbot/clients/gtkPanes.py: same
7200 * buildbot/status/client.py (StatusClientService): keep
7201 BuilderStatus objects in self.statusbags . These objects now live
7202 here in the StatusClientService and are referenced by the Builder
7203 object, rather than the other way around.
7204 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7205 * buildbot/process/base.py (Builder): same
7206 * test/test_config.py (ConfigTest.testBuilders): same
7208 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7209 an existing builder, leave the statusbag alone. This will preserve the
7210 event history.
7212 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7213 hook. This will probably go away in favor of a class in upcoming
7214 Twisted versions.
7216 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7217 serviceName from newcred FreshCVSNotifiee setup
7219 2003-09-29 Brian Warner <warner@lothar.com>
7221 * buildbot/process/process_twisted.py: switch to new reactor
7222 abbreviations
7223 * docs/examples/twisted_master.cfg: same
7225 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7227 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7228 botmaster reference instead of the oldapp service lookup
7230 * buildbot/master.py (BuildMaster.__init__): give the
7231 StatusClientService a reference to the botmaster to make it easier to
7232 force builds
7234 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7236 * buildbot/status/html.py (Box.td): escape hreffy things so you
7237 can have spaces in things like builder names
7238 (StatusResourceBuilder.body)
7239 (WaterfallStatusResource.body)
7240 (WaterfallStatusResource.body0): same
7242 2003-09-25 Brian Warner <warner@lothar.com>
7244 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7245 rearrange the builder list when adding or removing builders: keep
7246 them in the order the user requested.
7247 * test/test_config.py (ConfigTest.testBuilders): verify it
7249 * contrib/debug.glade: give the debug window a name
7251 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7252 now wait on multiple interlocks. Fix code relating to that.
7253 (Builder.checkInterlocks): same
7254 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7256 * buildbot/master.py (BuildMaster.loadConfig): move from
7257 deprecated pb.BrokerFactory to new pb.PBServerFactory
7258 * test/test_config.py (ConfigTest.testWebPathname): same
7260 * docs/examples/twisted_master.cfg: fix interlock declaration
7262 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7263 Interlocks to their Builders into interlock.py .
7264 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7266 * test/test_config.py (ConfigTest.testInterlocks): validate
7267 interlock handling
7269 * buildbot/process/base.py (Builder.__init__): better comments
7270 * buildbot/process/interlock.py (Interlock.__repr__): same
7271 (Interlock.deactivate): add .active flag, move the code that
7272 attaches/detaches builders into the Interlock
7274 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7276 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7277 tests using the new run_maxq.py script, and reporting failures by
7278 parsing its output.
7280 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7281 tests, reporting their success or failure in a buildbot-friendly
7282 manner.
7284 2003-09-24 Brian Warner <warner@lothar.com>
7286 * docs/examples/twisted_master.cfg: example of a new-style config
7287 file. This lives in the buildmaster base directory as
7288 "master.cfg".
7290 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7291 button to make the master re-read its config file
7293 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7294 buildmaster configuration from a file. This file can be re-read
7295 later, and the buildmaster will update itself to match the new
7296 desired configuration. Also use new Twisted Application class.
7297 * test/Makefile, test/test_config.py: unit tests for same
7299 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7300 FreshCVSSources comparable, to support reload.
7301 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7303 * buildbot/process/base.py (Builder): make them comparable, make
7304 Interlocks easier to attach, to support reload. Handle
7305 re-attachment of remote slaves.
7306 * buildbot/process/interlock.py (Interlock): same
7308 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7309 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7310 buildmaster taps are now constructed with mktap.
7311 * buildbot/status/client.py (StatusClientService): same
7313 * buildbot/status/words.py: move to new Services, add support to
7314 connect to multiple networks, add reload support, allow nickname
7315 to be configured on a per-network basis
7317 2003-09-20 Brian Warner <warner@lothar.com>
7319 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7320 the freebsd builder, now that the machine has been upgraded and no
7321 longer has python2.2
7323 * setup.py (version): bump to 0.3.5+ while between releases
7325 2003-09-19 Brian Warner <warner@lothar.com>
7327 * setup.py (version): Releasing buildbot-0.3.5
7329 2003-09-19 Brian Warner <warner@lothar.com>
7331 * NEWS: add post-0.3.4 notes
7333 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7335 * MANIFEST.in: add contrib/*
7337 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7338 use a remote root now: cvs.twistedmatrix.com
7340 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7341 to newcred
7342 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7343 compatibility with old servers
7344 (FreshCVSSource.start): and provide a way to use it
7345 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7347 * docs/examples/twisted_master.py (twisted_app): update to new
7348 makeApp interface.
7349 (twisted_app): listen on new ~buildbot socket
7350 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7352 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7353 to reduce cvs bandwidth (update instead of full checkout)
7355 2003-09-11 Brian Warner <warner@lothar.com>
7357 * contrib/fakechange.py: demo how to connect to the changemaster
7358 port. You can use this technique to submit changes to the
7359 buildmaster from source control systems that offer a hook to run a
7360 script when changes are committed.
7362 * contrib/debugclient.py: tool to connect to the debug port. You
7363 can use it to force builds, submit fake changes, and wiggle the
7364 builder state
7366 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7367 'Dispatcher' realm to handle all the different kinds of
7368 connections and Perspectives: buildslaves, the changemaster port,
7369 the debug port, and the status client port. NewCredPerspectives
7370 now have .attached/.detached methods called with the remote 'mind'
7371 reference, much like old perspectives did. All the pb.Services
7372 turned into ordinary app.ApplicationServices .
7373 (DebugService): went away, DebugPerspectives are now created
7374 directly by the Dispatcher.
7375 (makeApp): changed interface a little bit
7377 * buildbot/changes/changes.py: newcred
7378 * buildbot/status/client.py: newcred
7380 * buildbot/clients/base.py: newcred client side changes
7381 * buildbot/bot.py: ditto
7383 * docs/examples/glib_master.py: handle new makeApp() interface
7384 * docs/examples/twisted_master.py: ditto
7386 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7387 base newcred Perspectives on. This should go away once Twisted
7388 itself provides something sensible.
7391 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7393 * contrib/svn_buildbot.py: A program that you can call from your
7394 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7395 when a change in an SVN repository has happened. See the top of
7396 the file for some minimal usage info.
7398 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7400 * buildbot/slavecommand.py (ArglistCommand): Add new
7401 ArglistCommand that takes an argument list rather than a string as
7402 a parameter. Using a st.split() for argv is very bad.
7404 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7405 update to a particular revision rather than always checking out
7406 (still not very smart about it, there may be cases where the
7407 checkout becomes inconsistent).
7409 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7411 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7412 SVN fetch support. It can checkout (not update!) a specified
7413 revision from a specified repository to a specified directory.
7415 * buildbot/status/progress.py (Expectations.update): Fix an
7416 obvious bug (apparently created by the change described in the
7417 previous ChangeLog message) by moving a check to *after* the
7418 variable it checks is defined.
7421 2003-09-08 Brian Warner <warner@lothar.com>
7423 * buildbot/status/progress.py (Expectations.update): hack to catch
7424 an exception TTimo sees: sometimes the update() method seems to
7425 get called before the step has actually finished, so the .stopTime
7426 is not set, so no totalTime() is available and we average None
7427 with the previous value. Catch this and just don't update the
7428 metrics, and emit a log message.
7430 2003-08-24 Brian Warner <warner@lothar.com>
7432 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7433 parameter to set copydir='original' in CVS commands.
7435 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7437 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7438 which tells the command to maintain a separate original-source CVS
7439 workspace. For each build, this workspace will be updated, then
7440 the tree copied into a new workdir. This reduces CVS bandwidth
7441 (from a full checkout to a mere update) while doubling the local
7442 disk usage (to keep two copies of the tree).
7444 2003-08-21 Brian Warner <warner@lothar.com>
7446 * buildbot/status/event.py (Logfile.addEntry): if the master web
7447 server dies while we're serving a page, request.write raises
7448 pb.DeadReferenceError . Catch this and treat it like a
7449 notifyFinish event by dropping the request.
7451 2003-08-18 Brian Warner <warner@lothar.com>
7453 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7454 (instead of blowing up) if a force-build command is given without
7455 a reason field
7457 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7458 don't blow up if there aren't yet any Changes in the list
7460 2003-08-02 Brian Warner <warner@lothar.com>
7462 * buildbot/bot.py (updateApplication): don't set the .tap name,
7463 since we shouldn't assume we own the whole .tap file
7465 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7466 'mktap buildbot' (without a subcommand) better
7468 2003-07-29 Brian Warner <warner@lothar.com>
7470 * buildbot/status/words.py
7471 (IrcStatusFactory.clientConnectionLost): when we lose the
7472 connection to the IRC server, schedule a reconnection attempt.
7474 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7475 use shutil.rmtree instead of forking off an "rm -rf" command.
7476 rmtree may take a while and will block until it finishes, so we
7477 use "rm -rf" if available.
7479 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7480 freebsd buildslave badly
7482 * setup.py (version): bump to 0.3.4+ while between releases
7484 2003-07-28 Brian Warner <warner@lothar.com>
7486 * setup.py (version): Releasing buildbot-0.3.4
7488 2003-07-28 Brian Warner <warner@lothar.com>
7490 * NEWS: update in preparation for release
7492 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7493 process.signalProcess instead of os.kill, to improve w32
7494 portability
7496 * docs/examples/twisted_master.py (twisted_app): turn off
7497 win32eventreactor: the tests hang the buildslave badly
7499 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7500 failed builds, since usually the failures are consistent
7502 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7503 add compileOpts/compileOpts2 to reactors build
7505 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7506 (twisted_app): use both default and win32eventreactor on w32 build.
7507 Use both default and kqreactor on freebsd build.
7509 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7510 add compileOpts2, which is put after the build_ext argument. w32
7511 needs "-c mingw32" here.
7513 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7514 touch .acqpath, it goes away in recent Twisted releases
7516 * docs/examples/twisted_master.py (twisted_app): use "python" for
7517 the w32 buildslave, not "python2.2"
7519 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7520 the directory exists.. should hush an exception under w32
7522 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7523 ProcessTerminated -provided values for signal and exitCode rather
7524 than parsing the unix status code directly. This should remove one
7525 more roadblock for a w32-hosted buildslave.
7527 * test/test_mailparse.py: add test cases for Syncmail parser
7529 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7530 temporary compatibility import. Note! Start importing
7531 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7533 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7535 2003-07-27 Brian Warner <warner@lothar.com>
7537 * NEWS: started adding new features
7539 * buildbot/changes/mail.py: start work on Syncmail parser, move
7540 mail sources into their own file
7542 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7543 as implementing IChangeSource
7544 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7546 * buildbot/interfaces.py: define the IChangeSource interface
7548 2003-07-26 Brian Warner <warner@lothar.com>
7550 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7552 2003-06-25 Brian Warner <warner@lothar.com>
7554 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7555 seconds display
7557 2003-06-17 Brian Warner <warner@lothar.com>
7559 * buildbot/status/words.py: clean up method usage to avoid error
7560 in silly IRC command
7561 (IrcStatusBot.emit_status): round off seconds display
7563 * buildbot/process/base.py (Build): delete the timer when saving
7564 to the .tap file, and restore it (if it should still be running)
7565 upon restore. This should fix the "next build in -34 seconds"
7566 messages that result when the master is restarted while builds are
7567 sitting in the .waiting slot. If the time for the build has
7568 already passed, start it very soon (in 1 second).
7570 * buildbot/status/words.py: more silly commands
7572 * README (REQUIREMENTS): add URLs to all required software
7574 * buildbot/status/words.py ('last'): mention results of, and time
7575 since last build
7577 2003-05-28 Brian Warner <warner@lothar.com>
7579 * buildbot/status/words.py: add 'last' command
7580 (IrcStatusBot.emit_status): add current-small text to 'status' output
7582 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7583 (twisted_app): remove spaces from OS-X builder name
7585 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7586 * buildbot/status/words.py: IRC bot should actually be useful now
7588 2003-05-23 Brian Warner <warner@lothar.com>
7590 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7591 "slave information" from $(slavedir)/info/* . These files are
7592 maintained by the slave administrator, and describe the
7593 machine/environment that is hosting the slave. Information from
7594 them is put into the "Builder" HTML page. Still need to establish
7595 a set of well-known filenames and meanings for this data: at the
7596 moment, *all* info/* files are sent to the master, but only
7597 'admin' and 'host' are used on that end.
7598 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7599 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7600 * buildbot/master.py (BotPerspective.got_info): ditto
7602 2003-05-22 Brian Warner <warner@lothar.com>
7604 * setup.py (version): bump version to 0.3.3+ while between releases
7606 2003-05-21 Brian Warner <warner@lothar.com>
7608 * setup.py: Releasing buildbot-0.3.3
7610 2003-05-21 Brian Warner <warner@lothar.com>
7612 * NEWS: 0.3.3 news items
7614 * README: describe --keepalive and life behind a NAT box
7616 * buildbot/bot.py (Bot.connected): implement application-level
7617 keepalives to deal with NAT timeouts, turn them on with
7618 --keepalive option or when SO_KEEPALIVE doesn't work.
7620 * buildbot/master.py (BotPerspective): accept keepalives silently
7622 * buildbot/process/base.py (Build.buildException): CopiedFailures
7623 don't carry as much information as local ones, so don't try to
7624 create a big HTMLized version of them.
7626 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7627 log file when step fails due to an exception, such as when the slave
7628 becomes unreachable
7630 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7631 --testmodule argument instead of grepping for test-case-name tags
7632 ourselves. Remove FindUnitTests code.
7633 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7635 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7637 2003-05-16 Brian Warner <warner@lothar.com>
7639 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7640 argument to allow things like CFLAGS=-O0 to be passed without relying
7641 upon /bin/sh processing on the slave.
7643 * buildbot/process/step.py (InternalShellCommand.start): send
7644 'env' dict to slave
7645 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7646 'split' instead of letting /bin/sh do it. This should also remove
7647 the need for /bin/sh on the buildslave, making it more likely to
7648 work with win32.
7650 * buildbot/status/html.py: html-escape text in blamelist.
7651 Add "force build" button to the Builder page.
7653 * buildbot/process/step_twisted.py (countFailedTests): look at
7654 last 1000 characters for status line, as import errors can put it
7655 before the -200 point.
7657 2003-05-15 Brian Warner <warner@lothar.com>
7659 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7661 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7662 make 'clobber' a parameter, so it is possible to have builds which
7663 do full tests but do a cvs update instead of hammering the CVS
7664 server with a full checkout each build
7666 * buildbot/process/step.py (InternalShellCommand): bump default
7667 timeout to 20 minutes
7669 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7670 the master to trigger a build. Run it via manhole.
7672 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7673 allow slaves to trigger any build that they host, to make life
7674 easier for slave admins who are testing out new build processes
7676 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7677 don't flunk cReactor or qtreactor on failure, since they fail alot
7678 these days. Do warnOnFailure instead.
7680 * buildbot/process/base.py: change Builder.buildable from a list
7681 into a single slot. When we don't have a slave, new builds (once
7682 they make it past the timeout) are now merged into an existing
7683 buildable one instead of being queued. With this change, a slave
7684 which has been away for a while doesn't get pounded with all the
7685 builds it missed, but instead just does a single build.
7687 2003-05-07 Brian Warner <warner@lothar.com>
7689 * setup.py (version): bump version to 0.3.2+ while between releases
7691 2003-05-07 Brian Warner <warner@lothar.com>
7693 * setup.py: Releasing buildbot-0.3.2
7695 2003-05-07 Brian Warner <warner@lothar.com>
7697 * setup.py: fix major packaging error: include subdirectories!
7699 * NEWS: add changes since last release
7701 * README (REQUIREMENTS): update twisted/python dependencies
7703 * buildbot/status/builder.py (Builder.startBuild): change
7704 BuildProcess API: now they should call startBuild/finishBuild
7705 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7706 keeping a list of builds in the statusbag, to support other kinds of
7707 status delivery.
7708 (Builder.addClient): send current-activity-small to new clients
7709 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7710 new API
7712 * buildbot/status/client.py: drop RemoteReferences at shutdown
7714 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7716 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7717 more debug messages for remote status client
7719 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7720 (.stepFailed): only fire the Deferred once, even if both
7721 stepComplete and stepFailed are called. I think this can happen if
7722 an exception occurs at a weird time.
7724 * buildbot/status/words.py: work-in-progress: IRC status delivery
7726 2003-05-05 Brian Warner <warner@lothar.com>
7728 * docs/examples/twisted_master.py (twisted_app): hush internal
7729 python2.3 distutils deprecation warnings
7730 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7731 add compileOpts= argument which inserts extra args before the
7732 "setup.py build_ext" command. This can be used to give -Wignore
7733 warnings, to hush some internal python-2.3 deprecation messages.
7735 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7736 the ['twisted.test'] default test case to make it easier to change
7737 in subclasses
7739 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7740 * buildbot/clients/gtkPanes.py: ditto
7742 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7743 arg to collapse RunUnitTestsRandomly into RunUnitTests
7744 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7745 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7747 * buildbot/status/html.py (StatusResource): shuffle Resources
7748 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7749 would serve the waterfall display, but the internal links were
7750 only valid on the trailing-slash version. The correct behavior is
7751 for the non-slashed one to serve a Redirect to the slashed one.
7752 This only shows up when the buildbot page is hanging off another
7753 server, like a Twisted-Web distributed server.
7755 * buildbot/status/event.py (Event, RemoteEvent): make Events
7756 pb.Cacheable, with RemoteEvent as the cached version. This removes
7757 a lot of explicit send-an-update code.
7758 * buildbot/status/builder.py (Builder): remove send-update code
7759 * buildbot/status/client.py (ClientBuilder): remove send-update
7760 code, and log errors that occur during callRemote (mostly to catch
7761 InsecureJelly exceptions)
7763 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7764 run Lore with the same python used in the rest of the build
7766 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7768 * buildbot/process/step_twisted.py (HLint): accept 'python'
7769 argument. Catch rc!=0 and mark the step as failed. This marks the
7770 build orange ("has warnings").
7771 (RunUnitTestsJelly): move out to step_twisted2.py
7773 * buildbot/util.py (ignoreStaleRefs): add utility function
7775 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7776 don't fake ETA object, it's too hard to get right
7778 2003-05-02 Brian Warner <warner@lothar.com>
7780 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7782 2003-05-01 Brian Warner <warner@lothar.com>
7784 * buildbot/status/html.py (StatusResource.body): oops, I was
7785 missing a <tr>, causing the waterfall page to be misrendered in
7786 everything except Galeon.
7788 2003-04-29 Brian Warner <warner@lothar.com>
7790 * docs/examples/twisted_master.py: make debuild use python-2.2
7791 explicitly, now that Twisted stopped supporting 2.1
7793 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7794 handle tuple results too. I keep forgetting this, which suggests
7795 it needs to be rethought.
7797 * setup.py (setup): bump version to 0.3.1+ while between releases
7799 2003-04-29 Brian Warner <warner@lothar.com>
7801 * setup.py: Releasing buildbot-0.3.1
7803 2003-04-29 Brian Warner <warner@lothar.com>
7805 * README (SUPPORT): add plea to send questions to the mailing list
7807 * NEWS, MANIFEST.in: add description of recent changes
7809 * docs/examples/twisted_master.py: add the code used to create the
7810 Twisted buildmaster, with passwords and such removed out to a
7811 separate file.
7813 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7814 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7815 buildmasters to not require CVSToys be installed.
7816 * README, docs/examples/glib_master: update to match the change
7818 * buildbot/clients/base.py, buildbot/bot.py,
7819 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7820 ReconnectingPB from CVSToys distribution to remove CVSToys
7821 dependency for build slaves and status clients. Buildmasters which
7822 use FreshCVSSources still require cvstoys be installed, of course.
7824 2003-04-25 Brian Warner <warner@lothar.com>
7826 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7827 runTestsRandomly arg to turn on trial -z
7829 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7830 experimental code to use trial's machine-parseable output to get
7831 more detailed test results. Still has some major issues.
7832 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7833 in random sequence
7835 * buildbot/status/builder.py (Builder.setCurrentBuild):
7836 anticipating moving build history into statusbag, not used yet
7838 * buildbot/status/tests.py: code to centralize test results,
7839 doesn't work quite yet
7841 * buildbot/status/event.py (Event): use hasattr("setName") instead
7842 of isinstance for now.. need better long-term solution
7844 * buildbot/status/html.py: Remove old imports
7846 2003-04-24 Brian Warner <warner@lothar.com>
7848 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7849 ignore changes under doc/fun/ and sandbox/
7851 * buildbot/process/step_twisted.py: update pushEvent and friends.
7853 * buildbot/status/html.py (Box.td): replace event.buildername with
7854 event.parent.getSwappableName(). Needs more thought.
7856 * buildbot/status/builder.py (Builder): Replace pushEvent and
7857 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7858 Tell events they are being pruned with event.delete().
7860 * buildbot/process/base.py (Build): Remove Builder status-handling
7861 methods. s/pushEvent/setCurrentActivity/.
7863 * buildbot/process/step.py (BuildStep): clean up status delivery.
7864 Gouse builder.statusbag methods instead of intermediate builder
7865 methods. s/updateLastEvent/updateCurrentActivity/.
7866 s/finalizeLastEvent/finishCurrentActivity/. Use
7867 addFileToCurrentActivity for summaryFunction.
7869 * buildbot/status/event.py (Logfile): put data in a Swappable when
7870 .finish is called.
7871 (Event): add more setter methods. Remove .buildername, use .parent
7872 and getSwappableName instead (needs more thought).
7874 * buildbot/util.py (Swappable):
7875 * test/test_swap.py: don't bother setting filename at __init__
7876 time, do it later. Change setFilename args to take parent first,
7877 since it provides the most significant part of the filename.
7879 2003-04-23 Brian Warner <warner@lothar.com>
7881 * buildbot/status/event.py (Logfile.addEntry): append to previous
7882 entry, if possible
7884 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7885 anticipating Swappable
7886 (InternalShellCommand.remoteUpdate): split out various log-adding
7887 methods so subclasses can snarf stdout separately
7889 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7890 in anticipation of Swappable build logs
7891 (Builder.testsFinished): anticipating TestResults, still disabled
7893 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7894 last 100 events
7896 * buildbot/status/event.py (Logfile): add (disabled) support for
7897 Swappable, not ready for use yet
7899 * buildbot/util.py (Swappable): object which is swapped out to
7900 disk after some period of no use.
7901 * test/test_swap.py: test buildbot.utils.Swappable
7903 2003-04-14 Brian Warner <warner@lothar.com>
7905 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7906 periodic-build timer. Set the .periodicBuildTime on a builder
7907 instance to some number of seconds to activate it.
7909 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7911 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7912 a way that survives result tuples
7914 2003-04-12 Brian Warner <warner@lothar.com>
7916 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7917 return a dict instead of a tuple: allow summarizers to provide
7918 multiple summaries if they want
7919 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7920 (debuildSummarizer): summarize lintian warnings/errors
7922 2003-04-10 Brian Warner <warner@lothar.com>
7924 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7926 2003-04-09 Brian Warner <warner@lothar.com>
7928 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7929 empty summaries: happens when the tests fail so hard they don't emit
7930 a parseable summary line.
7932 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7933 Allow summaryFunction to return None to indicate no summary should
7934 be added.
7936 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7937 writing to stale HTTP requests: notice when they disconnect and
7938 remove the request from the list. Also add CacheToFile from
7939 moshez, will be used later.
7941 2003-04-08 Brian Warner <warner@lothar.com>
7943 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7944 should be an int, not a list of strings
7946 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7947 if we weren't actually connected
7949 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7950 to show the tail end of the trial text output
7952 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7953 hook to summarize the results of a ShellCommand
7955 2003-04-07 Brian Warner <warner@lothar.com>
7957 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7958 twisted test suite code into a single class.
7959 * buildbot/process/process_twisted.py: same
7961 2003-04-04 Brian Warner <warner@lothar.com>
7963 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7965 * README (SLAVE): document use of mktap to create slave .tap file
7966 (REQUIREMENTS): describe dependencies
7968 * buildbot/bb_tap.py, buildbot/plugins.tml:
7969 * buildbot/bot.py (updateApplication): Add mktap support for creating
7970 buildslave .tap files
7972 2003-03-28 Brian Warner <warner@lothar.com>
7974 * buildbot/process/step.py (InternalShellCommand.finished): handle
7975 new tuple result values (fix embarrasing bug that appeared during
7976 PyCon demo)
7978 2003-03-27 Brian Warner <warner@lothar.com>
7980 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7981 -making program
7983 2003-03-25 Brian Warner <warner@lothar.com>
7985 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7986 to overall build status
7987 * buildbot/clients/base.py (Builder): improve event printing
7988 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7989 instead of generic ShellCommand
7990 (Build): Add .stopBuild, use it when slave is detached
7992 * buildbot/process/step.py (Configure,Test): give the steps their
7993 own names and status strings
7995 * buildbot/status/html.py (StatusResource): add "show" argument,
7996 lets you limit the set of Builders being displayed.
7998 2003-03-20 Brian Warner <warner@lothar.com>
8000 * buildbot/process/basic.py: removed
8002 2003-03-19 Brian Warner <warner@lothar.com>
8004 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8005 turn off process-docs by default
8007 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8008 when displaying build information without anything in allBuilds[]
8010 * buildbot/bot.py (makeApp): really take password from sys.argv
8012 2003-03-18 Brian Warner <warner@lothar.com>
8014 * buildbot/bot.py (buildApp): take password from sys.argv
8016 * README: replace with more useful text
8018 * setup.py: add a real one
8019 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8021 * docs/PyCon-2003/: added sources for PyCon paper.
8023 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8024 now Build objects control the process and Builder only handles
8025 slave stuff and distribution of changes/status. A new BuildFactory
8026 class creates Build objects on demand.
8028 Created ConfigurableBuild which takes a list of steps to run. This
8029 makes it a lot easier to set up a new kind of build and moves us
8030 closer to being able to configure a build from a web page.
8032 * buildbot/process/step_twisted.py, process_twisted.py: move to
8033 new model. A lot of code went away.
8035 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8036 send lots of empty progress messages to the client.
8038 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8040 2003-02-20 Brian Warner <warner@lothar.com>
8042 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8044 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8045 Twisted bug that prevented non-pty processes from working just got
8046 fixed, and the bug that leaks ptys is still being investigated.
8048 * buildbot/process/step.py (CVS): send timeout arg to slave
8050 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8051 builders coming and going
8052 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8053 from CVSToys, handle lost-buildmaster
8055 * buildbot/status/client.py (StatusClientService.removeBuilder):
8056 Clean up status client protocol: send builders (with references)
8057 as they are created, rather than sending a list and requiring the
8058 client to figure out which ones are new.
8059 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8060 attempts to force a build on an unknown builder
8062 2003-02-19 Brian Warner <warner@lothar.com>
8064 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8065 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8066 Twisted stops leaking them.
8067 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8068 builder goes to an idle state.
8070 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8071 I figure out why CVS commands hang without them, and/or I fix the
8072 hung-command timeout
8074 2003-02-16 Brian Warner <warner@lothar.com>
8076 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8077 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8078 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8079 GenerateDocs now that they are prefixed with WARNING:.
8081 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8082 use manual href target instead of request.childLink
8084 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8085 display every second, but update the ETA every 5 seconds (or
8086 whenever) as remote_progress messages arrive.
8089 2003-02-12 Brian Warner <warner@lothar.com>
8091 * *: import current sources from home CVS repository
8094 # Local Variables:
8095 # add-log-time-format: add-log-iso8601-time-string
8096 # End: