1 2008-03-29 Brian Warner <warner@lothar.com>
3 * buildbot/__init__.py (version): Releasing buildbot-0.7.7
4 * docs/buildbot.texinfo: same
6 2008-03-29 Brian Warner <warner@lothar.com>
8 * NEWS: update with all changes since the last release. I left the
9 bugs-fixed section somewhat terse, but there's a link to the Trac
10 page with more details.
13 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
14 accept category= arguments in the query-arg portion of the URL.
15 These behave like the builder= queryargs: if any category=
16 queryargs are present, we'll only show Builders that fit into one
17 of the specified categories. Using multiple category= arguments
18 will show more Builders. Thanks to Jerome Davann (hollowman) for
19 the idea and the patch. Closes #117.
20 * docs/buildbot.texinfo (Buildbot Web Resources): document it
22 * buildbot/changes/svnpoller.py (SVNPoller.create_changes): pass
23 revision as a string, not an int. This fixes a problem in
24 MailNotifier, which expects a string. Thanks to Dan Locks for the
25 patch, and Dustin Mitchell for the test fixups. Closes #208.
26 * buildbot/steps/source.py (Source.commandComplete): treat
27 got_revision as a string too.
28 * buildbot/test/test_svnpoller.py: update test to match
29 * buildbot/test/test_vc.py: same
31 2008-03-27 Brian Warner <warner@lothar.com>
33 * buildbot/scripts/runner.py (doCheckConfig): patch from Ben
34 Hearsum to implement 'buildbot checkconfig': validate that your
35 master.cfg is good without actually touching the buildmaster.
37 * buildbot/scripts/checkconfig.py: same
38 * docs/buildbot.texinfo (Testing the Config File): document it
40 2008-03-22 Brian Warner <warner@lothar.com>
42 * buildbot/test/test_vc.py (Mercurial.serveHTTP): another attempt
43 to make Mercurial.testCheckoutHTTP not fail on heavily loaded
44 machines: avoid overlapping poll() calls.
46 * NEWS: preliminary list of changes for the upcoming release.
47 Needs editing and explanations.
49 * buildbot/status/web/base.py (make_stop_form): add a label=
50 argument so that the button says "Stop Builds" or "Stop Build" as
51 appropriate. It used to say "Stop Builder", which was wrong.
52 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
53 (OneBoxPerBuilder.body): same
55 * buildbot/process/builder.py (Builder): use self.old_building to
56 track Builds from a previous version of this Builder and are still
57 running. This makes it possible for IBuilderControl to get at
58 them, allowing the "Stop Build" button to work after a
59 Builder-replacing reconfig. Closes #22.
60 (Builder.consumeTheSoulOfYourPredecessor): grab weakrefs from the
61 old Builder's self.building attribute, instead of strongrefs,
62 since there's no good place to explicitly forget about them.
63 (Builder.getBuild): factor this out of BuilderControl
65 * buildbot/process/buildstep.py (LogLineObserver.setMaxLineLength):
66 new method to override the default 16KiB line length. Lines that
67 are longer than this will cause the rest of the log file to be
68 ignored. Thanks to Greg Ward for the patch. Closes #201.
69 * buildbot/test/test_buildstep.py: new tests for log observers
70 * docs/buildbot.texinfo (Adding LogObservers): document it
72 * buildbot/slave/commands.py (ShellCommand): record more
73 information in the 'header' section: how much we write into stdin,
74 do we close stdin, are we using a PTY. There are lingering
75 problems with PTYs and with closing stdin (see #198 and #158).
76 This doesn't fix those problems, but it should provide more
77 information to developers.
79 * buildbot/status/client.py: hush pyflakes, log.msg vs log
80 * buildbot/status/mail.py: same
82 * buildbot/locks.py (debuglog): hush pyflakes
84 * buildbot/steps/source.py (SVN.__init__): fix pyflakes: it
85 doesn't like a variable named 'warnings' that shadows the import
87 * buildbot/test/test_web.py: fix some pyflakes warnings, caused by
88 having a variable name shadow a top-level import
90 * buildbot/test/test_run.py (Disconnect.testBuild2): fix old
91 cut-and-paste typo that was causing us to run the wrong callback
93 * Makefile (pyflakes): sort+uniqify, since newer pyflakes isn't
94 smart enough to do this on its own
95 * buildbot/test/runutils.py (myGetProcessOutputAndValue): move this
96 method out from test_vc.py, hush pyflakes complaints
98 * buildbot/test/test_vc.py (Mercurial.serveHTTP): wait for the 'hg
99 serve' command to be ready, by polling with twisted.web's
100 client.getPage . Unfortunately mercurial doesn't flush its stdout
101 at startup, so we can't just wait for the 'listening at..' line to
102 be printed. This should fix the sporadic "connection refused" test
103 failures I've seen on the metabuildbot when the buildslave is
104 overloaded and 'hg serve' takes a while to start up.
106 * buildbot/steps/python_twisted.py (TrialTestCaseCounter): modify
107 regexp to count "Doctest:" lines as well as normal tests. Thanks to
108 Martin Geisler for the patch. Closes #196.
110 2008-03-20 Brian Warner <warner@lothar.com>
112 * buildbot/status/web/waterfall.py (CurrentBox.formatETA): apply
113 patch from TedMielczarek to display hours/minutes/seconds in the
114 ETA display. Thanks Ted! Also make 'next build starts in' box use
115 the same format. Closes #95.
117 * buildbot/process/buildstep.py (render_properties): more cleanup:
118 rename 'render' to 'render_properties'.
119 * buildbot/steps/shell.py: same
120 (ShellCommand._interpolateProperties): tolerate None in the value,
121 clean up the isinstance checks, stop using the 'types' module
123 * buildbot/steps/transfer.py (FileUpload.start): same, other cleanups
125 * buildbot/steps/shell.py (render): oops, remove redundant
126 definition that probably crept in during a merge conflict
128 * buildbot/scheduler.py (Triggerable): cleanup: wrap docstring
129 * buildbot/steps/trigger.py (Trigger): cleanup: rename schedulers=
130 to schedulerNames=, make updateSourceStamp=True by default, tolerate
131 missing got_revision property (i.e. if updateSourceStamp=True but
132 there was no checkout/update step run), add TODO notes for further
134 * buildbot/test/test_run.py (Triggers): update to match
135 * docs/buildbot.texinfo (Build Dependencies): same
137 * buildbot/slave/commands.py (SVN.doVCFull): merge Dustin's patch:
138 add --no-auth-cache option to svn invocations to avoid caching
139 buildbot's credentials. This also helps when users run a
140 buildslave from their personal account, to keep the buildslave
141 from clobbering their manually-provided svn password. Closes #188.
142 (SVN.doVCUpdate): do it for 'svn update' too.
144 * buildbot/steps/shell.py: merge Greg Ward's patch (via Dustin):
145 refactor WithProperties handling, allow WithProperties in more
147 * buildbot/process/buildstep.py: same
148 * buildbot/steps/transfer.py: same, allow WithProperties in filenames
150 * buildbot/steps/trigger.py: remove unused imports to hush pyflakes
152 * docs/buildbot.texinfo (Build Properties): fix up nodes+menus
154 2008-03-19 Brian Warner <warner@lothar.com>
156 * buildbot/status/web/xmlrpc.py (XMLRPCServer.xmlrpc_getAllBuilders):
157 merge Etienne Pierre's patch (via Dustin): add new XMLRPC methods.
158 (XMLRPCServer.xmlrpc_getStatus): same
159 (XMLRPCServer.xmlrpc_getLastBuilds): same, returns the last N
160 completed builds for a given Builder
162 * buildbot/test/test_config.py (ConfigTest.setUp): merge Dustin's
163 patch: suppress DeprecationWarnings in our tests of deprecated
164 features that aren't scheduled for removal quite yet. In the long
165 run, we'll remove the old features and the tests.
167 * NEWS: add a deprecation schedule
168 * buildbot/changes/freshcvsmail.py: remove this file, it was
169 replaced by mail.FCMaildirSource in the previous release.
171 * buildbot/test/runutils.py: set usePTY=False everywhere we aren't
172 explicitly testing =True, to avoid SIGHUP-based failures that I
173 now see about 10% of the time.
175 * buildbot/scheduler.py (Triggerable): merge Dustin's patch: add
176 "Triggerable" Schedulers, to start builds at specific phases of
177 other builds rather than in response to source code changes or
178 periodic timers. These phases are marked by "Trigger" steps, which
179 are configured with a list of Triggerable schedulers that they
180 should fire. Closes #56.
181 * buildbot/steps/trigger.py (Trigger): buildstep to match
182 * buildbot/test/test_run.py (Triggers): test for it
183 * docs/buildbot.texinfo (Build Dependencies): document it
184 (Triggering Schedulers): same
186 2008-03-18 Brian Warner <warner@lothar.com>
188 * buildbot/interfaces.py (ISourceStamp.getAbsoluteSourceStamp):
189 merge patch from Dustin to add "absolute source stamps": just like
190 normal SourceStamp instances except that they have a .revision
191 attribute copied out of the got_revision property of a build. If
192 the input SourceStamp says .revision=None (i.e. HEAD), and the
193 build is done when the tree is at r1234, then the "absolute"
194 SourceStamp should have .revision=1234 .
195 * buildbot/sourcestamp.py (SourceStamp.getAbsoluteSourceStamp): same
196 * buildbot/status/builder.py (BuildStatus.getSourceStamp): add
199 * buildbot/test/runutils.py (SetTestFlagStep): test utility class,
200 adding 'flags' that can be set by specific buildsteps. This makes
201 it easier to write tests that detect whether certain buildsteps
202 have been reached or not. Patch by Dustin Mitchell.
203 * buildbot/test/test_run.py (TestFlag.testTestFlag): test for it.
205 * buildbot/buildslave.py (BuildSlave.__repr__): protect against
206 .botmaster being empty, to allow pretty-printing of configuration
207 files before the twisted reactor starts. Patch from Dustin
210 * docs/buildbot.texinfo (Shutdown): make it clear that 'buildbot
211 reconfig' (which uses SIGHUP) doesn't work on windows. Acknowledge
212 the occasional failures in reconfig (and suggest 'buildbot
213 restart' as a fallback). Closes #105.
215 * buildbot/steps/shell.py (ShellCommand._interpolateProperties):
216 apply patch from Albert Hofkamp to allow WithProperties in
217 environment variables and the workdir= argument. Closes #52.
218 * buildbot/test/test_properties.py (Interpolate.testCustomBuildStep):
219 remove this test, it was pretty weird and didn't work with the
220 new _interpolateProperties approach.
222 * buildbot/test/test_vc.py (VCBase.connectSlave): turn off usePTY
223 for all slave commands: I'm seeing 'cp' and 'rm' fail with SIGHUP,
224 probably when we close stdin. This happens on my debian/sid
225 system, but not on older unixes, so I suspect some change in
226 behavior in the kernel or glibc or something similar.
228 2008-02-05 Brian Warner <warner@lothar.com>
230 * buildbot/buildslave.py (BuildSlave._missing_timer_fired): add a
231 To: header to the email message we're composing. Oops. Thanks
232 to Zandr Milewski for the catch.
233 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
236 2007-12-31 Brian Warner <warner@lothar.com>
238 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): remove
239 the short timeouts, these can cause false test failures on slow
240 systems, and were only needed while developing the recent patch
241 (Download.testLotsOfBlocks): same
243 * buildbot/scripts/reconfig.py (Reconfigurator.run): if we're on
244 windows, make 'buildbot reconfig' emit a warning message (since
245 there's no SIGHUP to be had) rather than just hanging. Addresses
246 #105, but we still need to document this somewhere. Thanks to
247 Ben Hearsum for the patch.
249 * buildbot/slave/commands.py (SlaveFileUploadCommand.start):
250 rewrite the main loop to avoid tail recursion, since Deferreds
251 don't optimize those out. Without this, at the end of the transfer
252 we'd hit a stack depth of about two or three frames per block
253 transferred, and for large transfers this would run into a "stack
254 depth exceeded" error. Closes #106.
255 (SlaveFileDownloadCommand.start): same, for downloads.
256 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): test it
257 (Download.testLotsOfBlocks): same
259 2007-12-22 Brian Warner <warner@lothar.com>
261 * buildbot/steps/shell.py (TreeSize): This never worked properly.
262 Fix it. Also, stash the tree size in a build property named
263 'tree-size-kb'. Note that this records size in KiB (1024 bytes),
264 not KB (1000 bytes), because that's what du will give us. This
266 * docs/buildbot.texinfo (TreeSize): document it
267 * buildbot/test/test_steps.py (TreeSize.testTreeSize): test it
269 * buildbot/steps/shell.py (WarningCountingShellCommand): utility
270 subclass which uses a regular expression to count warning messages
271 in the output. This also puts warning messages in a new 'warnings'
272 logfile, sets the 'warnings-count' build property with the total
273 count, and marks the step results as WARNINGS if there are any
274 warnings. Thanks to Roch Gadsdon (rochg) for the patch. Closes
276 (Compile): derive from WarningCountingShellCommand
278 * docs/buildbot.texinfo (Compile): document it
279 * buildbot/test/test_steps.py (Warnings): test it
281 * buildbot/slave/commands.py (ShellCommand._chunkForSend): don't
282 send more than 128kB of stdout/stderr/logfile text in a single PB
283 string, since PB has a hardwired limit of 640kB. This should fix
284 crashes that occur when the test process generates output very
285 very quickly. Patch by chops@demiurgestudios.com, thanks! I
286 haven't been able to reproduce this locally, but the potential bug
287 is clear. This should close #129.
289 2007-12-21 Brian Warner <warner@lothar.com>
291 * buildbot/scripts/startup.py (start): check to see if there's a
292 buildbot.tac before doing anything else. This improves the error
293 message when you do 'buildbot start' in the wrong directory.
295 * buildbot/scripts/logwatcher.py (LogWatcher.start): rewrite to
296 spawn /usr/bin/tail to follow the target's twistd.log . It turns
297 out that OS-X file EOF semantics are different, and the naive
298 read-then-read-again approach I was using doesn't work (the first
299 EOF we hit is sticky). tail gets it right, so rely upon it instead
300 of reimplementing the wheel. This should make 'buildbot start'
301 correctly follow the logfile on OS-X, thus closing #141.
303 2007-12-14 Brian Warner <warner@lothar.com>
305 * buildbot/steps/shell.py (ShellCommand.__init__): stash the
306 RemoteShellCommands args too, so things like 'workdir' and 'env'
307 and 'timeout' are preserved. This ought to fix #150.
308 * buildbot/test/test_steps.py (Steps.testClone): test it
310 2007-12-11 Brian Warner <warner@lothar.com>
312 * buildbot/scripts/startup.py (launch): use twisted.__version__,
313 rather than twisted.version, since the latter didn't appear until
314 Twisted-2.4.0 . This unbreaks 'buildbot start' on older Twisteds.
316 2007-12-08 Brian Warner <warner@lothar.com>
318 * docs/buildbot.texinfo (Git): document the fact that we require
319 Git 1.2.0 or later, and that the one shipped in dapper is too old.
321 * buildbot/scripts/startup.py (launch): twisted-2.5.0 and later
322 doesn't need twisted.scripts._twistw.run; instead, it uses
323 twisted.scripts.twistd.run on all platforms. Closes #53.
325 2007-11-30 Brian Warner <warner@lothar.com>
327 * buildbot/status/builder.py (BuilderStatus): small docs patches
328 from Greg Ward.. thanks!
329 * buildbot/process/base.py (Build): same
331 2007-11-29 Brian Warner <warner@lothar.com>
333 * buildbot/slave/commands.py (Mercurial._maybeFallback): add an
334 _abandonOnFailure call to the fallback, to skip the 'update' step
335 if the checkout fails.
336 (Mercurial._maybeFallback): More fixes: look for error messages
337 generated by every version of hg from 0.7 to the current 0.9.5,
338 including development versions as of rev 92991422a847. Also make
339 sure to return the exit code of non-fallbackable errors so that
340 other steps can attempt a workaround.
342 2007-11-28 Brian Warner <warner@lothar.com>
344 * buildbot/slave/commands.py (Mercurial._maybeFallback): improve
345 hg fallback so that it works when the client hg is new and the
346 server hg is old (the error message is different in this case).
348 2007-11-27 Brian Warner <warner@lothar.com>
350 * buildbot/test/test_p4poller.py: hush pyflakes warning
352 * buildbot/slave/commands.py (Mercurial._maybeFallback): when hg
353 is doing a 'clone' operation, to a remote repository (e.g. over
354 HTTP), and either the server or the client is hg-0.9.1 or older,
355 'hg clone' cannot accept a --rev argument: instead, you have to
356 clone the tip and then update back to the desired revision. Added
357 code to detect this failure mode and fall back to the clone+update
358 scheme. Closes #122 and #103.
359 (ShellCommand.__init__): add a keepStderr= flag to support this
361 * buildbot/test/test_vc.py (VCBase._do_vctest_clobber_2): add a
362 test that does a checkout to a specific version, to exercise the
363 mercurial limitation workaround.
364 (Mercurial.serveHTTP): add code to test hg checkout over HTTP,
365 using mercurial's built-in 'hg serve' command. Because of
366 limitations in hg, this code uses a randomly-selected TCP
367 port (rather than claiming a free one), so every once in a while
368 this test is going to fail because of a port-number collision.
370 * buildbot/test/test_vc.py (GitHelper.capable): skip Git tests if
371 the version of Git installed is older than 1.2.x . Git 1.1.3
372 doesn't accept 'git init' (it wants 'git init-db' instead) and the
373 branch tests fail. I know that Git 1.5.3.6 works. I don't know
374 what the dividing line is.. if someone can figure it out, please
375 update this check. Also, if someone can make buildbot's git
376 support handle older versions, please do that too! Addresses #130.
378 2007-11-21 Brian Warner <warner@lothar.com>
380 * lots: improve Git support, AMAZING patch from Haavard
381 Skinnemoen, complete with unit tests and docs, thanks! Closes #130.
382 * buildbot/scripts/tryclient.py (GitExtractor): add 'try' support
383 * buildbot/slave/commands.py (Git): accept branch and revisions,
384 and use 'git' instead of the 'cogito' wrapper
385 * buildbot/steps/source.py (Git.__init__): same
386 * buildbot/test/test_vc.py (BaseHelper.runCommand): offer control
388 (BaseHelper.do): same
389 (BaseHelper.dovc): same
390 (Git): unit tests for Git support. Wow!
391 * docs/buildbot.texinfo (Git): docs for Git support. Double Wow!
392 * contrib/git_buildbot.py: commit-hook script for git
395 * buildbot/changes/p4poller.py (P4Source._finished): don't let a
396 failure cause us to stop polling. Thanks to John Backstrand for
397 the patch. Closes #135.
398 * buildbot/test/test_p4poller.py (TestP4Poller.testFailedChanges):
400 (TestP4Poller.testFailedDescribe): same
402 * buildbot/status/web/waterfall.py (WaterfallStatusResource.body):
403 fix timezone calculation, we were always emitting DST, even in
404 winter. Thanks to Charles Lepple and John Saxton for the patch.
406 * buildbot/test/test_web.py (Waterfall.test_waterfall._check1): same
409 * lots: a whole batch of patches from Benoit Sigoure, referenced
410 in ticket #138. Thanks!
412 * buildbot/master.py (BuildMaster.loadConfig): builder names that
413 begin with an underscore are now reserved, so prohibit them from
414 appearing in the config file.
415 * NEWS: announce this change.
417 * buildbot/status/web/base.py: add buttons (to one_line_per_build
418 and one_box_per_builder) to force/stop builds on all Builders at
420 * buildbot/status/web/baseweb.py: same
421 (OneBoxPerBuilder.body): add links to the per-Builder page
423 * buildbot/status/web/builder.py: same
425 * buildbot/status/web/builder.py (StatusResourceBuilder.body):
426 factor out force/stop form generation
427 * buildbot/status/web/base.py: same
428 * buildbot/status/web/build.py: same
430 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
431 simplify some 'if' statements
432 (StatusResourceBuilder.build_line): add a 'Stop Build' button next
433 to the 'Force Build' button, so you can start and stop a build
435 (StatusResourceBuilder.force): redirect back to the waterfall,
436 rather than the index page
437 (StatusResourceBuilder.ping): same
438 * buildbot/status/web/build.py (StatusResourceBuild.stop): same
440 * buildbot/slave/bot.py (Bot.remote_setBuilderList): don't
441 consider the 'info' directory as a leftover directory. Patch from
442 Benoit Sigoure, ticket #138.
443 (others): remove trailing whitespace
445 2007-11-01 Brian Warner <warner@lothar.com>
447 * buildbot/status/web/builder.py (StatusResourceBuilder.build_line):
448 if there's no current step, don't try to display its description.
449 Same crash as in #96, this time in the web page. Closes #111.
451 * buildbot/status/web/base.py (OneLineMixin.make_line): tolerate
452 results == None (i.e. when the build hasn't finished yet);
453 previously this code exploded when trying to find a CSS class for
454 that results value. Patch from Greg Ward. Closes #118.
456 * buildbot/status/client.py (RemoteBuildStep.remote_getLogs):
457 IBuildStepStatus.getLogs() returns a list, not a dict. Patch from
458 Fabrice Crestois. Closes #121.
460 2007-10-31 Brian Warner <warner@lothar.com>
462 * buildbot/status/words.py (Contact.emit_status): if there's no
463 current step, don't try to display its description. This should
464 fix the crash when asking the irc bot about builds which are
465 waiting for a build-wide Lock. Closes #96.
467 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
468 'columnName' argument, from a patch by Ben Hearsum. Closes #120.
470 2007-10-16 Brian Warner <warner@lothar.com>
472 * buildbot/status/web/slaves.py (BuildSlavesResource.body): fix
473 timestamp, I was using %M (minutes) where I meant to be using
474 %b (abbreviated month name). Closes #109.
476 2007-10-13 Brian Warner <warner@lothar.com>
478 * README (COPYING): make it clear that buildbot is distributed under
480 * COPYING: add a copy of the GPLv2 to the source tree
481 * MANIFEST.in: .. and to the source distribution too
483 2007-10-10 Brian Warner <warner@lothar.com>
485 * buildbot/status/builder.py (Status.getURLForThing): update this
486 to match new URL layout, I completely forgot about it. Closes #112.
487 * buildbot/test/test_web.py (GetURL): add unit tests
489 * buildbot/status/web/build.py (BuildsResource.getChild): fix
490 silly typo which prevented the Build page from ever offering
491 control options like 'Stop Build'. Thanks to Aaron Hsieh for the
493 * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd
496 * buildbot/__init__.py (version): bump to 0.7.6+ while between
498 * docs/buildbot.texinfo: same
500 2007-09-30 Brian Warner <warner@lothar.com>
502 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
503 * docs/buildbot.texinfo: same
505 2007-09-30 Brian Warner <warner@lothar.com>
507 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
508 * setup.py: install all test files from buildbot/test/mail/* . Also
509 update URL to point at buildbot.net
510 * MANIFEST.in: update with new files
512 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
513 auto-create an empty public_html directory, otherwise we get
514 internal server errors instead of 404s.
516 * README: reference buildbot.net, remove CVSToys section (does
517 anyone still use it?)
519 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
520 message when public_html/ is missing (indicating that you should
521 probably run 'upgrade-master'), and don't auto-create an empty
522 directory in that case.
524 * contrib/darcs_buildbot.py: refactor internals a bit, make it
525 possible to use as an importable module (to make it easier to
526 write some unit tests for it)
528 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
529 DeprecationWarning for Waterfall, advising users to switch over to
532 * NEWS: update with user-visible changes since the last release
534 * buildbot/status/web/waterfall.py
535 (WaterfallStatusResource.get_reload_time): if the suggest a
536 reload time of less than 15 seconds, give them 15 seconds instead
537 of ignoring their request entirely, because that'd be confusing.
539 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
540 warning if we must invoke the last-change-is-most-recent guess
542 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
543 Waterfall is running in an upgraded master (which is the usual
544 case for folks who have followed the instructions to run
545 'upgrade-master' but who have not yet resolved all the
546 DeprecationWarnings), prefer the buildbot.css from public_html/
547 rather than the one passed in on the buildbot= argument.
548 Otherwise, the resulting pages don't quite use CSS right..
549 sometimes it works, sometimes it doesn't, and I don't know why.
550 Sites that are using custom CSS will see the default CSS until
551 they modify public_html/buildbot.css to include their
554 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
555 * buildbot/status/web/robots.txt (Disallow): update to cover all
556 dynamically-generated pages
558 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
559 include both 'trunk' and None in the output list, since some VC
560 systems (SVN, frequently) refer to trunk as 'trunk'.
562 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
563 point the 'welcome' link explicitly at index.html, rather than
564 '.', so that old Waterfall users can reach it and discover all the
567 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
568 build's text to the end of the line, without a CSS class so it
571 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
572 'max_search=' argument, to limit the number of builds that are
573 examined while trying to find ones that match the other criteria.
574 This helps to limit the work we do, since otherwise we might have
575 to trawl through all history.
576 (IBuilderStatus.generateFinishedBuilds): same
577 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
578 (BuilderStatus.generateFinishedBuilds): same
580 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
581 our got_revision before checking its length: SVN (at least) still
582 reports numeric values for this.
583 * buildbot/status/web/build.py (StatusResourceBuild.body): same
584 * buildbot/status/web/xmlrpc.py
585 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
586 serving a completely fake revision
588 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
589 basedir to sys.path, to mimic what a real buildmaster would have
590 access to, since it is common for master.cfg to import helper
591 classes from .py files in the buildmaster directory, and we want
592 config-file checking to accomodate this.
594 * buildbot/status/web/base.py (map_branches): when referring to
595 branches through WebStatus (i.e. by appending ?branch=FOO query
596 arguments to the URL), make "trunk" mean trunk, by mapping it to
597 None before passing it to generateFinishedBuilds() and the like.
598 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
599 (OneBoxPerBuilder.body): same, also improve display of branches in
601 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
602 (WaterfallStatusResource.buildGrid): same. Note that this filters
603 Changes as well as Builds.
604 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
605 caveat about trunk branches, now that it's fixed
607 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
608 from builder.py, use it on the Builder page too
610 * buildbot/status/web/builder.py (StatusResourceBuilder): same
611 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
612 names, add some CSS classes
613 * buildbot/status/web/classic.css (td.box): new class, for
616 * docs/buildbot.texinfo (WebStatus): update docs
618 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
619 the trailing "M" indicator that tells us this is a modified file.
620 This should help with mode="update" builds that modify files
621 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
624 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
625 new copies of files (to .new) when those files already exist,
626 check the master.cfg file for errors (and give DeprecationWarnings
627 a chance to be displayed).
628 * buildbot/test/test_runner.py: add more tests
629 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
631 2007-09-29 Brian Warner <warner@lothar.com>
633 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
634 the revision id from the last change in our list, since that's the
635 best we can do without knowing the full ancestry graph. Closes #103.
637 * buildbot/scripts/sample.cfg: use buildstep instances in
638 f.addStep, to demonstrate the (correct) modern usage.
639 * docs/examples/hello.cfg: bring this up to date. Closes #79.
640 * docs/examples/twisted_master.cfg: add a big warning about how
642 * docs/examples/glib_master.cfg: delete this one entirely, it is
643 ancient and not a very useful example anyways
645 * buildbot/status/web/base.py (HtmlResource.render): keep track of
646 HTTPChannels, so we can shut them down at reconfig time (when the
647 WebStatus goes away). Closes #102.
648 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
649 (WebStatus.registerChannel): same
650 (WebStatus.stopService): do .loseConnection() here
652 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
653 WebStatus, make sure all pages are still retrievable. I thought
654 this would exercise a bug, but it turns out that it was firefox
655 caching connections (and continuing to talk to the old WebStatus
656 even though I'd loaded a new one).
657 * buildbot/status/web/baseweb.py (WebStatus): add some comments
658 (WebStatus.__repr__): include id() in the repr
660 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
661 this to specify an errorparser. From Ted Mielczarek and the
662 mozilla crew. Closes #94.
664 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
665 bonsaipoller ignore funkyness in xml output for empy log
666 messages", from Axel Hecht. Closes #90.
667 * buildbot/test/test_bonsaipoller.py
668 (TestBonsaiPoller.testMergeEmptyLogMsg): same
670 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
671 respect 'builders' arg, from Ben Hearsum. Closes #89.
673 * buildbot/scripts/runner.py (stop): increase the timeout from 5
674 seconds to 10, to give heavily loaded machines a better chance to
675 finish shutting down. Addresses (partially) #68.
676 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
678 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
679 * buildbot/scripts/startup.py (Follower._failure): update message
681 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
682 team, to fix some bugs and avoid the use of blocking urlopen().
684 * buildbot/test/test_bonsaipoller.py: same
686 2007-09-28 Brian Warner <warner@lothar.com>
688 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
689 argument, to send email about buildslaves which are disconnected
690 for more than an hour. Closes #64.
691 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
693 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
694 (MailNotifier): add docs for this too
697 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
698 respect branch= queryargs, by restricting the builds displayed to
699 those matching the given branch names
700 * buildbot/status/web/waterfall.py (BuildTopBox): same
702 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
703 fix a test failure by adding .prepath to this fake object
705 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
706 up generation of relative URLs. With luck, this should play with
707 reverse proxies much better now.
708 * buildbot/test/test_webparts.py: new test for most of the subpages
709 * buildbot/test/test_web.py (base_config): add enough of a config
710 to exercise more Waterfall code
712 2007-09-27 Brian Warner <warner@lothar.com>
714 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
715 relative URL to the buildbot welcome page, rather than
717 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
719 * buildbot/status/web/base.py (HtmlResource.title): change the
720 default title of all Buildbot-generated page to "Buildbot"
721 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
722 change the title to include the Builder name
723 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
724 same, and also show the build number
725 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
726 redirect the browser to the Builder page
728 2007-09-26 Brian Warner <warner@lothar.com>
730 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
731 problem with the build links
733 2007-09-25 Brian Warner <warner@lothar.com>
735 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
736 to emit relative URLs instead of using URLPath,
738 * docs/buildbot.texinfo (WebStatus): provide an example
740 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
741 page, shows a simple table with one row per Builder. Still pretty
742 ugly, but functional.
743 * buildbot/status/web/index.html: reference it
745 * buildbot/status/web/waterfall.py (Spacer): make this *not*
746 inherit from builder.Event, so that show_events=false doesn't hide
747 spacers, since that would make the waterfall weirdly compressed.
749 * buildbot/status/web/waterfall.py (HELP): put the View button in
750 its own section, so it doesn't get visually confused with the
752 (WaterfallStatusResource.body): make the '[help]' links more
753 visually distinct from each other, and add a link to the Welcome
755 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
756 unused buildslaves without exploding
758 * buildbot/status/web/waterfall.py
759 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
760 it gives us absolute paths that break proxies
761 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
762 this, it was giving bad results when the Waterfall is behind a
765 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
766 new 'upgrade-master' command, which will bring an old buildmaster
767 directory up-to-date. Right now the only thing it does is populate
768 public_html/ if it wasn't already there. Still to do: check the
769 other files, add documentation.
770 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
771 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
773 2007-08-13 Brian Warner <warner@lothar.com>
775 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
776 that contains the checkin comments when you hover over the entry
777 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
780 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
783 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
784 page with versions of python, buildbot, and twisted
785 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
786 * buildbot/status/web/index.html: add links to most pages
787 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
789 * buildbot/status/web/robots.txt: put a robots.txt in new installs
790 which discourages robot access to all large dynamically-generated
791 pages. The intention is that the index page and the 'about' page
792 are the only ones which should be crawlable.
793 * buildbot/scripts/runner.py (Maker.public_html): same
795 * setup.py: ship index.html and robots.txt in source distributions
797 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
798 activate automatic reloading of the page (using a meta Refresh:
800 (WaterfallHelp): new page to explain all the nifty query arguments
801 you can use on the Waterfall, along with forms to set them for
802 you. From this page, you can add filters for builder=, branch=,
803 show_events=, as well as turning on reload=.
804 (WaterfallStatusResource.buildGrid): new query args: last_time=,
805 first_time=, show_time=, num_events= . The old show= is still
806 accepted, but the new builder= is preferred. We ignore empty
807 branch= arguments, to make the WaterfallHelp form easier to
809 (WaterfallStatusResource.head): new method to add text to the
811 * buildbot/status/web/base.py (HtmlResource.content): use head()
812 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
813 empty branch= arguments
814 (OneLinePerBuildOneBuilder.body): same
816 2007-08-12 Brian Warner <warner@lothar.com>
818 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
819 new query args: 'last_time' is a timestamp of the top-most event
820 on the display, 'first_time' is a timestamp for the bottom-most
821 event. 'show_time' is the difference between them, and overrides
822 'first_time'. 'num_events' puts an upper limit on the number of
823 timestamps that will be displayed on the left hand edge.
824 (WaterfallStatusResource.body): add a 'next page' link to the
825 bottom, which shows the events that come just after those shown on
826 the current page. This is a first step towards #67, but we need
827 some more controls before we can close that one.
829 * buildbot/buildslave.py (BuildSlave): these are now MultiService
830 instances too, and live as children of the BotMaster. The main
831 advantage of this approach is that BuildSlaves can know when they
832 are being removed (so they can shut off the upcoming
833 when-do-we-email-an-admin-because-we-lost-our-slave timer).
834 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
835 identify which service children are BuildSlaves
836 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
837 Checker updates here, but delegate the rest to..
838 (BotMaster.loadConfig_Slaves): .. here, which looks at the
839 BotMaster's service children to identify the old slaves. I think
840 the previous approach of using master.slaves was broken in the
841 face of config updates that modified BuildSlave instances but did
842 not completely replace them.
843 * docs/buildbot.texinfo (Developer's Appendix): note the change to
844 the Service hierarchy
846 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
847 page (at URL /buildslaves/) to view status of all buildslaves at
848 once, including how long it's been since we last heard from them,
849 and which Builders use them.
851 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
854 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
857 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
858 use the BuildSlave to keep track of the last time we've heard from
859 the buildslave. This is updated upon receipt of any message from
860 any SlaveBuilder (which generally means when RemoteCommands are
861 giving us status updates, as BuildSteps run). In the future this
862 will include slave pings too.
863 * buildbot/process/base.py
864 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
865 * buildbot/process/buildstep.py:
866 (BuildStep.setBuildSlave): accept that reference
867 (BuildStep.runCommand): pass the reference on to the RemoteCommand
868 (RemoteCommand.remote_update): update the timestamp
869 (RemoteCommand.remote_complete): same
870 * buildbot/test/runutils.py (StepTester.makeStep): match the change
871 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
872 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
873 interface to retrieve this timestamp
874 * buildbot/status/builder.py (SlaveStatus): track a copy of the
878 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
880 (OneLinePerBuild.body): use a <ul> instead of <div>s
881 (OneLinePerBuildOneBuilder.body): same
883 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
884 by adding the file's new name to the list of changed files. This
885 ought to be sufficient for things like isFileImportant and trial
886 tests that only exercise tests for files that have been modified.
889 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
890 XMLRPC server to the WebStatus page. This only has two methods
891 right now (getAllBuildsInInterval and getBuild), but we'll be
892 adding more in the future. This server is extracted from the
895 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
896 generateFinishedBuilds, and improve the data displayed.
897 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
898 the per-Build page, add some information like ETA and got_revision
899 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
900 adding a list of recently completed builds
901 * buildbot/status/web/base.py (css_classes): factor this out
903 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
904 new method, to make status display classes easier to write,
905 especially the WebStatus 'one_line_per_build' page.
906 (IBuilderStatus.generateFinishedBuilds): same
907 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
908 (Status.generateFinishedBuilds): implement it
910 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
911 'source' to be a BuildStep instance, since BuildFactory accepts
913 (CPAN.__init__): same
914 (Distutils.__init__): same
915 (Trial.__init__): same
917 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
918 this might raise KeyError
920 2007-08-07 Brian Warner <warner@lothar.com>
922 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
923 'Owner:' field of the view, rather than 'p4logname', since
924 p4logname comes from the buildslave's environment and seems
925 unlikely to ever do the right thing. Thanks to Wade Brainerd for
926 the patch. Closes #40.
928 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
929 which imposes a per-slave limit on how many builds are allowed to
930 run simultaneously. This has a the same scope than the SlaveLock,
931 but is different because max_builds= gives the buildmaster the
932 freedom to assign the build to a different slave, whereas the
933 SlaveLock doesn't get tested until after the build is irrevocably
934 assigned to a slave. Therefore using max_builds= will improve
935 utilization in the presence of multiple buildslaves that are
936 attached to the same Builder. This completes the incorporation of
937 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
938 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
939 any Builder finishes, potentially trigger *all* Builders, since
940 max_builds= may have stalled someone else while waiting for the
942 * buildbot/scripts/sample.cfg: mention max_builds=
943 * buildbot/test/test_run.py (ConcurrencyLimit): test it
944 * docs/buildbot.texinfo (Buildslave Specifiers): document it
946 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
947 inherit from RunMixin do not need to call master.stopService()
948 themselves, since RunMixin.tearDown does that. The double call
949 fails on Twisted-2.0.x, which didn't happen to protect against it.
950 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
952 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
953 from #48, this one to have the BuildSlave objects track
954 SlaveBuilders, so they'll be able to use that knowledge to
955 influence their canStartBuild() response.
956 * buildbot/process/builder.py (SlaveBuilder.attached): call it
957 (SlaveBuilder.detached): same
958 * buildbot/test/test_slaves.py (BuildSlave): test it
960 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
961 the second of Dustin's #48 patches, this one adding a method to
962 the BuildSlave that allows it to decide whether it is willing to
963 participate in a build or not.
964 (SlaveBuilder.isAvailable): use canStartBuild() to decide
966 * buildbot/test/test_run.py (CanStartBuild): test for it
968 * all: incorporate the first of four patches by Dustin Mitchell
969 from ticket #48, working towards improving control over slave
970 concurrency. The first patch is to use a long-lived BuildSlave
971 object per slave, on which other behavior can be added later. I've
972 modified his patch considerably.
973 * buildbot/buildslave.py (BuildSlave): move class out of
974 slave/__init__.py (where it would get loaded by the slave as well
975 as the master, making dependencies trickier), and merge it with
976 BotPerspective. Now these BuildSlave instances are created once in
977 the master.cfg file, and not destroyed until they are either
978 removed from the config file or changed so
979 much (name/password/class changes) that we cannot continue to use
980 the old one. This affects config files: they must use
981 'from buildbot.buildslave import BuildSlave' instead of using
982 'from buildbot.slave import BuildSlave'.
983 * buildbot/master.py: move BotPerspective out
984 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
985 add or remove as necessary, update the rest using data from
987 * buildbot/slave/__init__.py: move BuildSlave out
988 * buildbot/test/test*.py: import BuildSlave from the new place
989 * buildbot/scripts/sample.cfg: update to match
990 * docs/buildbot.texinfo: update to match
991 * buildbot/process/builder.py: update comments to match
993 2007-08-02 Brian Warner <warner@lothar.com>
995 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
996 one-line-per-build pages a bit, add a header, refactor slightly
998 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
999 the TimeOutError timer, patch by Dustin Mitchell.
1001 2007-08-01 Brian Warner <warner@lothar.com>
1003 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
1004 mostly work (branch= is still ignored, we need a useful header)
1005 (OneLinePerBuildOneBuilder.body): this too
1007 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
1008 bring this up-to-date w.r.t. recent refactorings, and fix
1009 redirections to bounce the browser to the top page after hitting
1010 the 'force' button. This needs to be improved, but at least it now
1011 redirects to a valid page.
1012 (StatusResourceBuilder.ping): same
1013 (StatusResourceBuilder.getChild): same, although I think this code
1014 might be dead anyways
1016 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
1017 a branch= query argument, to filter the display down to builds and
1018 changes that involve the given branch. You can add multiple
1019 branch= arguments to see multiple branches (using a logical OR).
1020 Note that there is no way to include the default branch (i.e.
1021 None, i.e. trunk) yet, there is still work to be done to allow for
1022 simple+uniform names of branches (i.e. removing the VC-specific
1023 details of how branches are implemented, so calling the branch
1024 'beta4' even though the SVN checkout step requires
1026 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
1027 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
1028 * buildbot/interfaces.py (IEventSource.eventGenerator): same
1029 * docs/buildbot.texinfo (Buildbot Web Resources): document it
1031 * all: bring import statements up-to-date: don't import
1032 __future__, assume cPickle and cStringIO are always available.
1033 Also remove #!/usr/bin/python lines from non-scripts, my editor
1034 has been a bit over-enthusiastic about stuffing them into new .py
1037 * buildbot/status/web/index.html: put a link to the waterfall page
1038 on the index, otherwise first-time users of WebStatus aren't going
1039 to see anything very interesting.
1041 * buildbot/interfaces.py (IEventSource): document this interface.
1042 Thanks to Dustin Mitchell for the patch. Closes #60.
1043 * buildbot/status/builder.py (BuilderStatus): same
1044 * buildbot/changes/changes.py (ChangeMaster): same
1046 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
1047 add a query arg of 'show_events=true' to display non-build events,
1048 like slaves attaching/detaching and reconfig events, or
1049 'show_events=false' to hide them. The default is 'true'.
1050 * docs/buildbot.texinfo (Buildbot Web Resources): document it
1052 * web-parts: merge in web-parts branch. Lots of changes. The new
1053 functionality is to add buildbot.status.html.WebStatus, which is a
1054 superset of the Waterfall that adds new status pages and serves
1055 regular files from BASEDIR/public_html/ , which is now the preferred
1056 place to put robots.txt, buildbot.css, and index.html .
1057 * buildbot/scripts/runner.py: the 'create-master' command now
1058 creates public_html/ too, and populates it with a couple of
1060 * buildbot/status/web: split waterfall code into smaller pieces
1062 2007-07-31 Brian Warner <warner@lothar.com>
1064 * buildbot/scripts/startup.py (launch): import twistd.run in a
1065 different way to hush pyflakes
1066 * buildbot/process/builder.py: remove unused import
1068 2007-07-30 Brian Warner <warner@lothar.com>
1070 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
1071 Mitchell: pass SourceStamps around rather than branch/version/etc
1072 tuples. Thanks Dustin! Closes #70.
1073 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
1074 tuple rather than a list, to avoid surprising mutations
1075 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1076 * buildbot/status/mail.py (MailNotifier.buildMessage): same
1077 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
1078 * buildbot/test/test_status.py (Subscription): same
1079 * buildbot/test/test_control.py (Force): same
1080 * buildbot/test/test_buildreq.py (Request.testMerge): same
1082 2007-07-29 Brian Warner <warner@lothar.com>
1084 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
1085 variable, since it wasn't used and is confusing in the presence of
1086 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
1089 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
1090 the Buildbot home-page link to point at buildbot.net instead of
1091 sourceforge, and add a current-version query parameter so we can
1092 get some statistics on which versions are in use out there.
1094 2007-07-28 Brian Warner <warner@lothar.com>
1096 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
1097 with c['change_source'], leaving c['sources'] for backwards
1098 compatibility (but deprecated), scheduled for removal in 0.8.0
1099 * docs/buildbot.texinfo: same
1100 * buildbot/test/test_config.py: verify that c['sources'] still works
1101 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
1102 * buildbot/scripts/sample.cfg: update to match
1104 * buildbot/changes/mail.py (MaildirSource): parse with python's
1105 stdlib 'email' module, which has been available since python2.2,
1106 and drop use of the 'rfc822' module, which has been depreceated
1108 * buildbot/test/test_maildir.py: same: use parse_file() not parse
1110 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
1111 this needs to match the renaming in test/mail/msg*
1113 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
1116 * buildbot/test/test_mailparse.py: rename sample emails a bit
1117 * buildbot/test/mail/msg*: same
1119 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
1120 parser for the "commit-email.pl" script that is shipped with SVN,
1121 written by Justin Mason. Thanks! Closes SF#1072845.
1122 * buildbot/test/mail/svn-commit.*: sample messages
1123 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
1124 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
1126 2007-07-27 Brian Warner <warner@lothar.com>
1128 * buildbot/changes/mail.py: refactor: move parsing into a method
1129 named 'parse', each parser type gets a separate subclass. Remove
1130 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
1131 to be a simple leading-substring match. Add a warning to the logs
1132 if prefix= does not end in a slash, since that's probably a
1133 mistake. Fix both places where a prefix= mismatch would skip all
1134 subsequent files in the same email, instead of just skipping the
1135 one that didn't match.
1136 * buildbot/test/test_mailparse.py: match changes
1138 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
1139 docs on email-based ChangeSources
1141 * docs/buildbot.texinfo (Getting Source Code Changes): move all
1142 the changesource types up a level, removing the one-entry menu in
1145 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
1146 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
1147 instances instead of tuples. Closes #63.
1148 * buildbot/slave/__init__.py (BuildSlave): define marker class
1149 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
1150 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
1151 * buildbot/test/test_*.py: update tests to match
1152 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
1153 the c['bots'] backwards-compatibility handler works
1155 2007-07-26 Brian Warner <warner@lothar.com>
1157 * buildbot/changes/hgbuildbot.py (hook): add an in-process
1158 Mercurial change-sending hook, contributed by Frederic Leroy.
1159 Thanks! Addresses #50.
1160 * docs/buildbot.texinfo (MercurialHook): document it
1162 * buildbot/changes/hgbuildbot.py: change the way imports are done,
1163 to make it compatible with at least hg-0.9.1 and the current 0.9.4
1165 2007-07-17 Brian Warner <warner@lothar.com>
1167 * buildbot/process/buildstep.py (BuildStep.getLog): add a
1168 convenience method to retrieve a log added with
1169 addLog()/addCompleteLog()/etc or logfiles= . I should have added
1170 this two years ago..
1172 2007-07-03 Brian Warner <warner@lothar.com>
1174 * buildbot/slave/commands.py (ShellCommand._startCommand): when
1175 logging the environment variables, put one variable on each line,
1176 rather than having one really long line with all of them. This
1177 should make them a bit more readable and not trigger the
1178 horizontal scrollbar (when viewing it in a web browser) quite so
1179 much. Thanks to Albert Hofkamp for the patch.
1181 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
1182 WithProperties instance. Thanks to Axel Hecht for the patch.
1184 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
1185 * docs/buildbot.texinfo (Build Properties): document it
1186 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
1187 workdir if it didn't already exist.
1189 * docs/buildbot.texinfo (Scheduler Types): correct the description
1190 of Dependent schedulers. Thanks to Greg Ward for the patch.
1192 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
1193 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
1194 the patch. Closes #49.
1196 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
1197 0700 before removing it, to deal with situations where a build will
1198 leave files around without write permissions and the 'copy' or
1199 'clobber' VC checkout modes need to blow away the tree first.
1200 Thanks to Steve Milner for the suggestion and the patch (which I
1201 mangled horribly). Closes #29.
1202 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
1205 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
1206 an allowReconnect= argument to let callers control whether they
1207 want this don't-let-it-reconnect behavior, since some tests care.
1208 Factor out the .continueTrying=False lines from those callers.
1209 * buildbot/test/test_slaves.py: same
1210 * buildbot/test/test_run.py: same
1212 2007-07-02 Brian Warner <warner@lothar.com>
1214 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
1215 slave has been disappeared, don't let it reconnect. This was
1216 causing an intermittent failure in test_slaves.py, when the slave
1217 that was supposed to be gone managed to come back by the end of
1218 the test and affect the count.
1219 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
1221 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
1222 diagnostic messages to track down this problem
1223 (Builder.startBuild): same
1225 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
1226 the slave randomly rather than always taking the first one. Thanks
1227 to Pike for the patch. Closes #36.
1228 * buildbot/test/test_slaves.py: match the change. to avoid huge
1229 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
1230 enables/disables the round-robin-ness (enabled by default), and
1231 some unit tests disable it.
1232 * docs/buildbot.texinfo (Buildmaster Architecture): document it
1234 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
1235 argument to 'buildmaster_host', to make it more obvious that this
1236 points to the buildmaster. Thanks to Bob Proulx for the
1238 * buildbot/scripts/runner.py (slaveTAC): same
1239 * buildbot/test/test_runner.py (Create.testSlave): match the change
1241 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
1244 2007-06-17 Brian Warner <warner@lothar.com>
1246 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
1247 we can round-trip all of our current step classes by calling
1248 getStepFactory() and using the results to make a clone of the
1251 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
1254 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
1255 the config file, we're moving to using actual instances instead of
1256 the (class, kwargs) 'step specification' tuples. BuildFactory
1257 still keeps a list of tuples internally, but when real instances
1258 are passed in to addStep(), they are asked for their class and
1259 kwargs using the new BuildStep.getStepFactory method. BuildFactory
1260 accepts both instances and the tuple form, and converts instances
1261 to the tuple form, but the instance form is preferred because it
1262 gives the Steps a chance to do argument validation. Closes: #11.
1264 * buildbot/process/buildstep.py (BuildStep.__init__): record the
1265 factory information necessary to implement getStepFactory. The
1266 addFactoryArguments() method can be used to include arguments that
1267 aren't passed to the BuildStep base class constructor.
1268 (BuildStep.setBuild):
1269 (BuildStep.setDefaultWorkdir): new methods to take parameters that
1270 are needed for live BuildSteps but not to construct the specification
1271 tuples that are stashed in the factory.
1273 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
1274 'workdir' into new BuildSteps by using methods instead of
1275 arguments. This makes the constructor for BuildSteps a lot
1278 * buildbot/steps/*.py: update to match this change. Basically this
1279 means adding calls to addFactoryArguments() in the __init__
1280 methods to capture the arguments that aren't passed through to the
1282 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
1283 the new workdir (if any) into the RemoteShellCommands arguments.
1284 * buildbot/steps/source.py: allow workdir= to be optional,
1285 implement setDefaultWorkdir() since we don't inherit from
1286 (CVS): finally remove old clobber=/export=/copydir= arguments,
1287 in favor of the mode= argument that's been around forever now.
1288 * buildbot/steps/transfer.py: remove build= argument
1290 * buildbot/test/*.py: update to match, generally by turning all
1291 build= arguments into subsequent calls to s.setBuild()
1292 * buildbot/test/test_config.py (Factories): verify that we can
1293 use either BuildStep instances or class/kwarg tuples in both
1294 BuildFactory.addStep and BuildFactory.__init__
1296 * docs/buildbot.texinfo (Build Steps): document the new approach,
1297 mention compatibility with the old approach, update all examples
1298 to use the new style.
1300 2007-06-16 Brian Warner <warner@lothar.com>
1302 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
1303 the LoopingCall, just eat the failure so that we'll poll again
1304 next time. This should allow us to tolerate (e.g.) sf.net SVN
1305 failures more gracefully. Many thanks to Dustin Mitchell for the
1308 2007-05-17 Brian Warner <warner@lothar.com>
1310 * buildbot/status/words.py: refactor the IRC status bot into
1311 separate 'Contact' and 'Channel' classes. The base Contact class
1312 contains the interaction code: commands and responses. The
1313 IRCContact subclass (and IrcStatusBot 'Channel') handle the
1314 IRC-specific aspects. The plan is to write other subclasses for
1315 other IM protocols like AIM and Jabber.
1317 2007-04-16 Brian Warner <warner@lothar.com>
1319 * CREDITS: update list of contributors. Thank you all!
1321 2007-04-13 Brian Warner <warner@lothar.com>
1323 * buildbot/status/mail.py (MailNotifier): add the project name to
1324 the subject line and message body, to make it easier to
1325 distinguish email coming from different buildmasters. Thanks to
1326 Benoit Sigoure for the patch.
1327 * buildbot/test/test_status.py (Mail): update to match
1329 2007-03-24 Brian Warner <warner@lothar.com>
1331 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
1332 avoid text-conversion problems between DOS/windows and unix.
1333 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
1335 2007-03-03 Brian Warner <warner@lothar.com>
1337 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
1338 warning about the use of Waterfall here
1340 2007-03-01 Brian Warner <warner@lothar.com>
1342 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
1344 2007-02-28 Brian Warner <warner@lothar.com>
1346 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
1347 Lamb to use a more optimal form of 'p4 changes', to reduce server
1348 load. He reports that this optimization was added to p4d release
1349 2005.2, but it should work in all versions. Closes #27.
1350 * buildbot/test/test_p4poller.py: match it
1352 2007-02-27 Brian Warner <warner@lothar.com>
1354 * buildbot/status/web/*.py: move all web status stuff into a
1355 separate directory, in anticipation of splitting it into smaller
1356 pieces and adding more files. html.py was getting way too big.
1357 * buildbot/status/classic.css: move it too
1358 * setup.py: add the new sub-package
1359 * buildbot/test/test_web.py: match the changes
1360 * MANIFEST.in: handle the move of classic.css
1362 2007-02-07 Brian Warner <warner@lothar.com>
1364 * contrib/OS-X/*: add some launchd .plist files for automatically
1365 starting a buildmaster or buildslave under OS-X (10.4 or later).
1366 Thanks to Mark Pauley for these.
1368 2007-02-06 Brian Warner <warner@lothar.com>
1370 * docs/buildbot.texinfo (Requirements): update requirements to
1371 stop claiming compatibility with python-2.2 or twisted-1.3.x .
1373 * README: mention python-2.5 and twisted-2.5 compatibility
1375 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
1377 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
1379 * buildbot/status/builder.py: same, by requiring cStringIO
1380 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
1381 * buildbot/test/test_vc.py: same
1382 * buildbot/test/test_web.py:
1383 * buildbot/test/test_steps.py: same, remove unused import
1385 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
1388 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
1389 see any Builders that don't have Schedulers to drive them
1391 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
1392 attributes this uses went away
1394 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
1395 dialog, to allow you to reset the buildmaster and force
1396 connect/disconnect. Correctly handle losing the buildmaster
1397 connection (by switching the display to the hexnut, at which point
1398 you can use the 'Connect' menu item to reconnect).
1400 * buildbot/steps/source.py (Source.start): if we're using a patch,
1401 add it as a LogFile to the checkout/update step. This will turn
1402 into a link on the waterfall page.
1404 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
1405 option, to take the patch from a pre-made file rather than
1406 generating it from the local tree. Thanks to Robert Helmer for the
1407 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
1408 * buildbot/scripts/runner.py (TryOptions): add --diff,
1409 --patchlevel, and --baserev options
1410 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
1411 as None, meaning HEAD.
1412 * buildbot/sourcestamp.py (SourceStamp): update docstring to
1413 indicate that baserev=None means HEAD
1414 * docs/buildbot.texinfo (try --diff): document it
1416 * buildbot/test/test_steps.py (BuildStep): remove use of
1417 reactor.iterate(), although the technique I replaced it with is a
1418 gross polling hack that must be cleaned up properly some day. This
1419 was the last use of reactor.iterate in the entire tree, yay.
1421 2007-02-05 Brian Warner <warner@lothar.com>
1423 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
1424 is one of the three known values, otherwise we emit some confusing
1425 messages later on. Thanks to Grig Gheorghiu for the catch.
1427 2007-01-30 Brian Warner <warner@lothar.com>
1429 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
1430 Hearsum contributed a patch to let BonsaiPoller work with results
1431 that contain non-ascii characters. Closes SF#1632641.
1433 2007-01-27 Brian Warner <warner@lothar.com>
1435 * Makefile (release): produce both .tar.gz and .zip source bundles.
1438 2007-01-23 Brian Warner <warner@lothar.com>
1440 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
1441 * buildbot/changes/monotone.py: same
1443 * buildbot/changes/maildir.py: combine several files into one,
1444 clean up maildir.py to use Services properly.
1445 * buildbot/changes/maildirtwisted.py: remove
1446 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
1448 * buildbot/changes/mail.py: match the change
1449 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
1450 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
1452 * buildbot/slave/commands.py (command_version): bump to "2.3" to
1453 indicate that the buildslave knows about the 'bzr' command
1455 2007-01-22 Brian Warner <warner@lothar.com>
1457 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
1458 'with', it will become a reserved work in python2.6 .
1460 * contrib/bb_applet.py: add a simple gnome-panel applet, to
1461 display a terse summary of buildbot status.
1462 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
1463 some icons, small versions of the Blender object that lives in
1464 docs/images/icon.blend
1466 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
1467 * buildbot/slave/commands.py (Bzr): same
1468 * buildbot/scripts/tryclient.py (BzrExtractor): same
1469 (SourceStampExtractor.dovc): modify this to allow non-zero exit
1470 status, since 'bzr diff' does that
1471 * buildbot/test/test_vc.py (Bzr): same
1472 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1476 2007-01-20 Brian Warner <warner@lothar.com>
1478 * contrib/darcs_buildbot.py: tidy up the progress messages
1480 2007-01-17 Brian Warner <warner@lothar.com>
1482 * contrib/darcs_buildbot.py: enhance to handle multiple patches
1483 being pushed at a time. This keeps state in the repository in a
1484 small file named .darcs_buildbot-lastchange, but that shouldn't
1485 interfere with normal repository operations. Fixes SF#1534049.
1486 * buildbot/clients/sendchange.py (Sender): make a single Sender
1487 capable of sending Changes with different usernames.
1489 2006-12-11 Brian Warner <warner@lothar.com>
1491 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
1492 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
1493 buildbot.changes.mail a long time ago, but I forgot to add the
1494 DeprecationWarning until now.
1496 * buildbot/process/maxq.py: remove this, the functionality now
1497 lives in buildbot.steps.maxq
1499 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1500 * buildbot/clients/gtkPanes.py: remove unused import
1502 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1503 that was meant to provide a special Reporter to run inside trial
1504 and give the buildslave lots of machine-readable status. We never
1505 finished this project.
1507 * buildbot/changes/bonsaipoller.py: remove unused imports
1508 * buildbot/changes/svnpoller.py: same
1509 * buildbot/process/builder.py: same
1510 * buildbot/process/buildstep.py: same
1511 * buildbot/slave/bot.py: hush pyflakes warning
1512 * buildbot/status/tests.py: remove unused imports
1513 * buildbot/status/tinderbox.py: same
1514 * buildbot/steps/python_twisted.py: same
1516 * buildbot/process/step.py: remove this file, these names were
1517 deprecated in 0.7.5 and are now being removed.
1518 * buildbot/process/step_twisted.py: same
1519 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1521 * buildbot/twcompat.py: remove the empty file, yay it is gone
1523 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1524 tw-2.0.0 and newer have the method we need.
1525 (getProcessOutputAndValue): same
1526 (which): remove this method, tw-2.0.0 t.p.procutils has it
1528 * buildbot/twcompat.py (implements): remove this method
1529 * buildbot/*: import implements() from zope.interface directly
1531 * buildbot/status/mail.py: stop falling back to importing
1532 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1535 * buildbot/twcompat.py (Interface): remove this import
1536 * buildbot/*: import Interface from zope.interface directly
1538 * buildbot/twcompat.py (providedBy): remove this method
1539 * buildbot/*: turn all uses of providedBy(obj, iface) into
1540 iface.providedBy(obj)
1542 * buildbot/twcompat.py (maybeWait): remove this method, now that
1543 we no longer maintain compatibility with Twisted<=1.3.0 .
1544 Twisted-2.0.0 and later allow trial methods to return Deferreds
1546 * buildbot/test/*: remove all uses of maybeWait
1548 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1550 * docs/buildbot.texinfo: same
1552 2006-12-10 Brian Warner <warner@lothar.com>
1554 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1555 * docs/buildbot.texinfo: set version to match
1557 2006-12-10 Brian Warner <warner@lothar.com>
1559 * README (REQUIREMENTS): update for release
1560 * NEWS: update for release
1561 * buildbot/slave/commands.py (command_version): mention that this
1562 version (2.2) was released with buildbot-0.7.5
1564 * buildbot/test/test_config.py (StartService.testStartService):
1565 inhibit the usual read-config-on-startup behavior, since otherwise
1566 the log.err that gets recorded causes the test to fail
1568 * buildbot/status/builder.py (LogFile.finish): forget about all
1569 subscribers once the log has finished, since after that point
1570 we're never going to use them again. This might help free up some
1573 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1574 than the old/deprecated gtk.mainquit()
1576 2006-12-09 Brian Warner <warner@lothar.com>
1578 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1579 better when we can't open the masterdst file
1581 * buildbot/scripts/startup.py (Follower._failure): add missing
1582 import statement for BuildSlaveDetectedError
1584 * buildbot/steps/transfer.py (FileUpload): cleanup
1585 (FileDownload): same. Add tests for slave version, add mode=.
1586 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1587 (SlaveFileDownloadCommand): same
1588 * buildbot/test/test_transfer.py: enhance tests
1589 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1592 2006-12-08 Brian Warner <warner@lothar.com>
1594 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1595 both success *and* failure. Without this, the 'buildbot
1596 sendchange' command would hang if it could not contact the
1597 buildmaster or deliver the Change, which would generally cause the
1598 user's commit/record/checkin command to hang too. Thanks to
1599 Christian Unger for the catch.
1601 2006-12-06 Brian Warner <warner@lothar.com>
1603 * NEWS: update with items for the next release
1605 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1606 whimsical example pulled from a punch-drunk email I sent out late
1608 (Transferring Files): document some of the other parameters
1609 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1610 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1611 * buildbot/test/test_svnpoller.py: same
1612 * buildbot/changes/svnpoller.py (SVNPoller): same
1614 2006-11-26 Brian Warner <warner@lothar.com>
1616 * docs/buildbot.texinfo (Build Properties): remind users that
1617 WithProperties must appear in a command= list, not as a top-level
1619 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1620 we're sending a list or a single string to the RemoteShellCommand
1622 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1624 * buildbot/scripts/startup.py (start): skip the whole
1625 watch-the-logfile thing under windows, since it needs os.fork()
1627 * buildbot/scripts/runner.py (restart): remove the old message
1628 that got printed after the buildbot was restarted.. it most cases
1629 it didn't get printed at the right time anyways
1631 2006-11-25 Brian Warner <warner@lothar.com>
1633 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1634 follow twistd.log and print lines until the process has started
1635 started properly. For the buildmaster, this means until the config
1636 file has been parsed and accepted. For the buildslave, this means
1637 until we've connected to the master. We give up after 5 seconds in
1638 any case. Helpful error messages and troubleshooting suggestions
1639 are printed when we don't see a successful startup. This closes the
1640 remainder of SF#1517975.
1641 * buildbot/scripts/startup.py: moved app startup code to here
1642 * buildbot/scripts/logwatcher.py: utility class to follow log
1643 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1644 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1645 so the LogWatcher can tell the difference between a buildmaster
1648 2006-11-24 Brian Warner <warner@lothar.com>
1650 * docs/examples/twisted_master.cfg: update to match the version
1651 in use on twistedmatrix.com
1652 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1653 was using before stopped working, but 'irc.freenode.net' works
1656 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1659 * buildbot/clients/base.py (TextClient.not_connected): upon
1660 UnauthorizedLogin failures, remind the user to connect to the
1661 PBListener port instead of the slaveport.
1662 (TextClient.disconnected): shut down more quietly
1663 * docs/buildbot.texinfo (statuslog): add another reminder
1665 * buildbot/scripts/runner.py (Options.subCommands): rename
1666 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1667 'sighup' as an alias.
1668 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1669 reconfig command to follow twistd.log and print all of the lines
1670 from the start of the config-file reload to its completion. This
1671 should make it a lot easier to discover bugs in the config file.
1672 Use --quiet to disable this behavior. This addresses half of
1673 SF#1517975, the other half will be to add this same utility to
1674 'buildbot start' and 'buildbot restart'.
1675 * docs/buildbot.texinfo (Loading the Config File): same
1678 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1679 method, it has been deprecated for a long time. Use
1680 IBuilderControl.requestBuild instead.
1681 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1682 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1683 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1684 * buildbot/test/test_control.py (Force.testForce): same
1685 * buildbot/test/test_run.py: use requestBuild instead
1687 * buildbot/clients/debug.py: replace 'Force Build' button with
1688 'Request Build' (which just adds one to the queue), add Ping
1689 Builder, add branch/revision fields to Request Build.
1690 * buildbot/clients/debug.glade: same
1691 * buildbot/master.py: update interface to match. This creates an
1692 incompatibility between new debugclients and old buildmasters.
1694 * buildbot/process/builder.py (Builder._attached): delay the call
1695 to maybeStartBuild for a reactor turn, to avoid starting a build
1696 in the middle of a reconfig (say, if the new Builder uses a new
1697 slave which is already connected).
1699 2006-11-23 Brian Warner <warner@lothar.com>
1701 * buildbot/test/test_transfer.py: appease pyflakes
1702 * buildbot/test/test_steps.py: same
1704 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1705 keeps pyflakes from finding undefined names
1707 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1708 Builder no longer induces a disconnect/reconnect cycle. This means
1709 that any builds currently in progress will not be interrupted, and
1710 any builds which are queued in the Builder will not be lost. This
1711 is implemented by having the new Builder extract the state (i.e.
1712 all pending Builds and any desired SlaveBuilders) from the old
1714 (BotPerspective): refactor. The BotPerspective no longer keeps
1715 track of all the Builders that want to use this slave; instead, it
1716 asks the BotMaster each time it needs this list. This removes
1717 addBuilder and removeBuilder. Clean up attached() to acquire all
1718 the slave's information in a more atomic fashion. updateSlave() is
1719 now the way to make sure the slave is using the right set of
1720 Builders: just call it after everything else has been
1722 (BotMaster): refactor, removing addBuilder/removeBuilder and
1723 replacing them with an all-at-once setBuilders() call.
1725 * buildbot/test/test_slaves.py (Reconfig): new test case to
1726 exercise this functionality
1727 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1728 * buildbot/slave/commands.py (WaitCommand): same
1730 * docs/buildbot.texinfo (Loading the Config File): document the
1733 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1734 SlaveBuilder to have its parent Builder changed.
1735 (SlaveBuilder.isAvailable): new method to give access to state,
1736 which is now a private attribute
1737 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1738 the SlaveBuilder about how it is being used. These methods update
1739 its internal state. buildFinished() is now the place that invokes
1740 maybeStartBuild() on its parent Builder.
1741 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1742 new Builder to take over for an old one, transferring state from
1744 (Buider): refactor the way that SlaveBuilders are used to match,
1745 giving them a bit more autonomy.
1746 (Builder.buildFinished): this no longer calls maybeStartBuild():
1747 instead the SlaveBuilder calls it on whoever its parent Builder is
1748 at the time. This way, when an old Builder is replaced by a new
1749 one, and there was a build in progress during the transition, when
1750 that build finishes, it will be the new Builder that is told about
1751 the newly available slave so it can start a new build.
1753 * buildbot/process/base.py (Build.startBuild._release_slave): when
1754 the Build finishes, tell the SlaveBuilder that they've been
1757 * buildbot/status/builder.py (SlaveStatus): add some new setter
1758 methods for use by BotPerspective, to keep some attributes more
1761 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1762 called by the buildmaster.
1763 (Bot.setBuilderList): instead, we locally announce any leftover
1764 directories based upon which Builders we were told about. The
1765 master doesn't really care; it's the local admin who may or may not
1766 wish to delete them.
1769 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1770 to allow use of python2.4 or whatever. This tool still requires
1773 2006-11-19 Brian Warner <warner@lothar.com>
1775 * NEWS (IStatusLog.readlines): more news items
1777 2006-11-18 Brian Warner <warner@lothar.com>
1779 * NEWS: start collecting items for the next release.
1781 2006-11-04 Brian Warner <warner@lothar.com>
1783 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1784 Hearsum. Closes SF#1590310.
1785 * buildbot/test/test_bonsaipoller.py: and tests
1787 * buildbot/status/tinderbox.py
1788 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1789 status when the build results in WARNINGS. Patch from Dave
1790 Liebreich. Closes SF#1587352.
1792 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1793 linux-vs-osx behavior difference w.r.t. reading from files that
1794 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1795 to Mark Rowe for the patch.
1797 2006-10-15 Brian Warner <warner@lothar.com>
1799 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1800 method name was misspelled in the interface definition. Thanks to
1801 Roy Rapoport for the catch.
1803 2006-10-13 Brian Warner <warner@lothar.com>
1805 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1806 to match the great Steps renaming
1808 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1809 Maybe I should run my own unit tests before recording a big
1810 change. Good thing I've got a buildbot to remind me.
1812 2006-10-12 Brian Warner <warner@lothar.com>
1814 * buildbot/steps/transfer.py: rework __init__ and args setup
1815 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1817 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1818 when opening the target file, only catch IOError (to report via
1819 stderr/rc!=0), let the others be reported as normal exceptions
1821 2006-10-08 Brian Warner <warner@lothar.com>
1823 * contrib/svn_watcher.py: fix security holes by using proper argv
1824 arrays and subprocess.Popen() rather than commands.getoutput().
1825 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1826 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1827 probably be removed by the next release.
1830 2006-10-04 Brian Warner <warner@lothar.com>
1832 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1833 initial lines that weren't emitted by pyflakes. When the pyflakes
1834 command is run under a Makefile, 'make' will echo the command it
1835 runs to stdio, and that was getting logged as a "misc" warning.
1836 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1837 * buildbot/test/test_steps.py (testPyFlakes3): another test
1839 2006-10-01 Brian Warner <warner@lothar.com>
1841 * buildbot/status/html.py (HtmlResource.render): if we get a
1842 unicode object from our content() method, encode it into utf-8
1843 like we've been claiming to all along. This allows the comments
1844 and author names from svnpoller.py to be delivered properly.
1846 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1847 de-unicodify filenames before creating the Change, because the
1848 rest of buildbot is unlikely to handle them well. Leave the 'who'
1849 field as a unicode object.. I don't think there's anything that
1850 will break very soon, and it will probably nudge us towards
1851 accepting unicode everywhere sooner or later. Stop using the
1852 "date" field that comes out of SVN, since it is using the
1853 repository's clock (and timezone) and what we care about is the
1854 buildmaster's (otherwise Changes from the future show up later
1855 than the builds they triggered).
1856 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1859 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1860 Suvbersion repository polling ChangeSource. I've hacked it up
1861 considerably: any bugs are entirely my own fault. Thank you
1863 * buildbot/test/test_svnpoller.py: tests for it
1864 * docs/buildbot.texinfo (SvnSource): document it
1866 2006-09-30 Brian Warner <warner@lothar.com>
1868 * buildbot/scheduler.py (Periodic): submit a reason= to the
1869 BuildSet to indicate which Scheduler triggered the build. Thanks
1870 to Mateusz Loskot for the suggestion.
1872 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1874 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1875 changes: set self.loop in __init__, remove unused volatile=
1877 * docs/buildbot.texinfo (.buildbot config directory): add more
1878 docs on the .buildbot/options keys used by "buildbot try"
1879 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1880 (Try.deliverJob): same
1882 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1884 (BonsaiPoller): same
1886 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1887 close the filehandle when we stop watching the file. Before, the
1888 filehandle was only closed when the LogFileWatcher was
1889 garbage-collected, which could be quite a while in the future. If
1890 it was still open by the time the next build started, windows will
1891 refuse to let the new build delete the old build/ directory. Fixes
1892 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1893 #twisted for the catch.
1895 2006-09-29 Brian Warner <warner@lothar.com>
1897 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1900 2006-09-25 Brian Warner <warner@lothar.com>
1902 * setup.py: the new buildbot.steps module wasn't being installed.
1903 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1904 (testmsgs): add the extra stuff from buildbot/test/* so you can
1905 run unit tests on an installed copy of buildbot, not just from
1908 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1909 columns of 'svnlook changed' output contain status information, so
1910 strip [:4] instead of [:6]. Depending upon what the status flags
1911 were, this would sometimes lead to mangled filenames. Thanks to
1912 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1914 * buildbot/steps/source.py (Monotone): initial Monotone support,
1915 contributed by Nathaniel Smith. Still needs docs and tests, but
1916 this code has been in use on the Monotone buildbot for a long
1918 * buildbot/slave/commands.py (Monotone): slave-side support
1919 * buildbot/changes/monotone.py (MonotoneSource): polling change
1922 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1923 contributed a Change Source that polls a Bonsai server (a
1924 kind of web-based viewcvs CGI script).
1926 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1927 Hearsum contributed a status plugin which sends email in the same
1928 format that Tinderbox does: this allows a number of tinderbox
1929 tools to be driven by Buildbot instead. Thanks Ben!
1931 2006-09-24 Brian Warner <warner@lothar.com>
1933 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1934 Thanks to Robert Helmer for the patch.
1936 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1937 BuildStatus about the buildslave name at the *beginning* of the
1938 build, rather than at the end. Thanks to Alexander Lorenz for the
1940 * buildbot/status/html.py (StatusResourceBuild.body): always
1941 include the slavename in the build page, not just when the build
1943 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1944 slavename in the email message
1946 2006-09-21 Brian Warner <warner@lothar.com>
1948 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1950 * docs/examples/glib_master.cfg: same
1951 * docs/examples/hello.cfg: same
1952 * docs/examples/twisted_master.cfg: same, update to current usage
1954 2006-09-19 Brian Warner <warner@lothar.com>
1956 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1957 (PyFlakes.createSummary): make it compatible with python-2.2
1959 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1960 for at least the output-parsing parts of PyFlakes
1962 2006-09-18 Brian Warner <warner@lothar.com>
1964 * buildbot/steps/python.py: oops, fix import of StringIO
1966 2006-09-17 Brian Warner <warner@lothar.com>
1968 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1969 turns out that SVN-1.4.0 doesn't fail to update once you've
1970 replaced a file with a directory, unlike older versions of SVN and
1971 pretty much every other VC tool we support. Since what we really
1972 care about is that the update succeeds anyway, stop checking that
1973 the tree got clobbered and just assert that the build succeeded.
1974 (VCBase.printLogs): add a utility function for debugging
1976 * buildbot/process/step.py: oops, added extra imports by mistake
1978 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1979 rstrip() on the first line coming out of the 'p4 describe'
1980 process, to remove the stray ^M that Wade Brainerd reports seeing
1981 in the 'when' field. Fixes SF#1555985.
1983 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1984 message logged when c['schedulers'] is not right
1985 * buildbot/scheduler.py (Scheduler.__init__): improve error
1986 message when a Scheduler() is created with the wrong arguments
1987 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1988 verify that these error messages are emitted
1990 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1991 The idea is that all the base classes (like BuildStep and
1992 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1993 will be a leftover backwards-compatibility file that only contains
1994 aliases for the steps that were moved out to buildbot.steps.*
1995 * lots: change imports to match
1996 * buildbot/process/step.py: add a DeprecationWarning if it ever
1999 2006-09-12 Brian Warner <warner@lothar.com>
2001 * buildbot/scheduler.py (Scheduler.__init__): make sure that
2002 builderNames= is actually a sequence, since if you happen to give
2003 it a single builder-specification dictionary instead, it won't get
2004 caught by the existing assert. Thanks to Brett Neely for the
2007 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
2009 * docs/buildbot.texinfo (Python BuildSteps): document them
2010 (sendchange): include a link to PBChangeSource, since you need one
2012 * buildbot/steps/shell.py: clean up test-case-name line, remove some
2014 * buildbot/steps/dummy.py: same
2016 2006-09-08 Brian Warner <warner@lothar.com>
2018 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
2019 BuildStep which lets you transfer files from the master to the
2020 slave or vice versa. Thanks to Albert Hofkamp for the original
2021 patch. Fixes SF#1504631.
2022 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
2024 (SlaveFileDownloadCommand): same
2025 * docs/buildbot.texinfo (Transferring Files): document it
2026 * buildbot/test/test_transfer.py: test it
2027 * buildbot/test/runutils.py (StepTester): new utility class for
2028 testing BuildSteps and RemoteCommands without Builds or Bots or PB
2029 * buildbot/test/test_steps.py (CheckStepTester): validate that the
2032 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
2033 walk through StatusLogs one line at a time, mostly for the benefit
2034 of ShellCommand.createSummary methods. You can either walk through
2035 STDOUT or STDERR, but the default is STDOUT.
2037 * buildbot/status/builder.py (LogFile.readlines): implement it.
2038 Note that this is not yet memory-efficient, it just pulls the
2039 whole file into RAM and then splits it up with a StringIO.
2040 Eventually this should be a generator that only pulls chunks from
2042 * buildbot/test/test_status.py (Log.testReadlines): test it
2044 * docs/buildbot.texinfo: update to match changes
2045 * buildbot/process/factory.py: stop using old definitions
2046 * buildbot/process/process_twisted.py: same
2047 * buildbot/test/test_*.py: same
2049 * buildbot/process/step_twisted.py: move definition to..
2050 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
2051 relative-import mechanisms prevent this from being named 'twisted'
2052 or 'python/twisted' as I would have preferred.
2054 * buildbot/process/maxq.py: move definition to..
2055 * buildbot/steps/maxq.py: .. here, leave a compatibility import
2057 * buildbot/process/step.py: split the user-visible BuildSteps into
2058 separate files, all under buildbot/steps/
2059 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
2060 * buildbot/steps/shell.py: this holds ShellCommand and friends
2061 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
2063 2006-09-05 Brian Warner <warner@lothar.com>
2065 * lots: run pyflakes, removed a lot of unused imports, changed the
2066 form of some conditional imports to remove false pyflakes
2067 warnings. There are still a number of warnings left, mostly from
2068 imports that are done for their side-effects.
2069 * buildbot/test/test_vc.py: import twisted.python.failure, since it
2072 2006-08-26 Brian Warner <warner@lothar.com>
2074 * buildbot/test/test_locks.py (Unit.testLater): make the tests
2075 compatible with twisted-1.3.0, for some reason I just can't seem
2076 to let go of the past.
2078 2006-08-25 Brian Warner <warner@lothar.com>
2080 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
2082 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
2083 all logfiles= in startCommand(), rather than in start() . This
2084 makes it easier to have the 'stdio' log come before any secondary
2085 logfiles, which I feel makes the waterfall display more
2087 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
2088 from ShellCommand up into LoggingBuildStep
2089 (LoggingBuildStep.__init__): move the handling of logfiles= from
2090 ShellCommand up to LoggingBuildStep, because startCommand is
2091 provided by LoggingBuildStep, whereas start() was specific to
2092 subclasses like ShellCommand and Source. This removes code
2093 duplication in those subclasses.
2094 (ShellCommand.__init__): same
2095 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
2096 for a slave that's too old to understand logfiles= into a separate
2097 method, so it can live in ShellCommand. The rest of
2098 setupLogfiles() can live in LoggingBuildStep.
2100 2006-08-24 Brian Warner <warner@lothar.com>
2102 * buildbot/locks.py (BaseLock): you can now configure Locks to
2103 allow multiple simultaneous owners. They still default to
2104 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
2106 * docs/buildbot.texinfo (Interlocks): document the new options
2107 * buildbot/test/test_locks.py: add a bunch of new unit tests
2108 * buildbot/process/base.py (Build.acquireLocks): locks now offer
2109 waitUntilMaybeAvailable, not waitUntilAvailable
2110 * buildbot/process/step.py (BuildStep.acquireLocks): same
2111 * buildbot/master.py (BotMaster.getLockByID): real locks now use
2112 the whole lockid in their constructor, not just the name. Also,
2113 keep track of which real locks we've handed out by the full
2114 lockid, not just class+name, otherwise changing just the maxCount=
2115 in the master.cfg file would not actually cause a behavioral
2118 2006-08-23 Brian Warner <warner@lothar.com>
2120 * buildbot/__init__.py (version): bump to 0.7.4+ while between
2122 * docs/buildbot.texinfo: same
2124 2006-08-23 Brian Warner <warner@lothar.com>
2126 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
2127 * docs/buildbot.texinfo: set version to match
2128 * NEWS: update for 0.7.4
2129 * buildbot/slave/commands.py (command_version): mention that this
2130 version (2.1) was released with buildbot-0.7.4
2132 2006-08-22 Brian Warner <warner@lothar.com>
2136 * CREDITS: new file, list of people who have helped. Thanks!
2137 * MANIFEST.in: ship it
2139 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
2140 new diagrams, the user's manual is more informative than it was.
2141 Start shipping the .html user's manual (and generated .png
2143 * Makefile: update 'release' target to match
2145 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
2146 test.. I think the web-parts effort will render it pointless well
2147 before it ever actually starts to work.
2149 2006-08-20 Brian Warner <warner@lothar.com>
2151 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
2152 meaning of the prefix= argument. It is now just a string which is
2153 stripped from the beginning of the filename. If prefix= is set but
2154 not found on any given filename, that filename is ignored. If all
2155 filenames in a Change are ignored, the Change is dropped. This is
2156 much simpler than the previous sep= nonsense, and I should have
2157 implemented it this way from the beginning. Effectively resolves
2158 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
2159 Gedminas for the catch and suggested fixes.
2160 (ChangePerspective.perspective_addChange): implement the actual
2162 * buildbot/test/test_changes.py (TestChangePerspective): test it
2163 * docs/buildbot.texinfo (PBChangeSource): document it, explain
2164 how to properly use prefix=
2165 * docs/examples/twisted_master.cfg (source): update prefix= by
2166 adding the trailing slash
2169 * docs/examples/twisted_master.cfg: update to actual practice
2171 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
2172 update test case to match new link text.. the HREF has both a
2173 class= setting and an enclosing [] pair that I didn't match in the
2176 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
2177 list of strings is preferred over a single string with embedded
2179 (ShellCommand.description=): explain that either single strings or
2180 a list of strings is acceptable, and why you might prefer one over
2181 the other. Add an example. Fixes SF#1524659, thanks to Paul
2182 Winkler for the catch.
2183 (Build Steps): update to use f.addStep() rather than using s()
2184 and the constructor list
2186 * buildbot/process/step.py (ShellCommand): accept either a single
2187 string or a list of strings in both description= and
2189 * buildbot/test/test_steps.py (Steps.test_description): test it
2190 * buildbot/test/runutils.py (makeBuildStep): support for that test
2192 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
2193 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
2194 collecting the files and creating the patch.
2196 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
2197 per-step URLs that will be displayed on the waterfall display,
2198 for things like the HTML output of code-coverage tools, when
2199 the results are hosted elsewhere.
2200 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
2201 way to retrieve these URLs
2202 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
2203 the method to retrieve these URLs. Also provide backwards
2204 compatibility for saved BuildStepStatus instances that didn't have
2206 * buildbot/process/step.py (BuildStep.addURL): method to set these
2207 URLs from within a BuildStep
2208 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
2209 (StepBox.getBox): give these external links a distinct CSS class
2210 named "BuildStep external" so a .css file can display them
2213 * buildbot/test/test_web.py (WaterfallSteps): test that we really
2215 * buildbot/test/test_steps.py (Steps): test that we can all the
2216 URLs. Also add a bunch of other tests on methods that can be
2217 called from within BuildSteps
2218 * buildbot/test/runutils.py (makeBuildStep): add utility function
2220 2006-08-13 Brian Warner <warner@lothar.com>
2222 * docs/buildbot.texinfo (BuildStep LogFiles): document them
2224 2006-08-10 Brian Warner <warner@lothar.com>
2226 * docs/buildbot.texinfo (Index of master.cfg keys): add another
2227 index, this one of things like c['sources'] and c['schedulers']
2228 (indices): it looks like my clever idea of putting the @fooindex
2229 commands in between the @node and the @subsection (to make the
2230 HREF anchor jump to slightly above the section title, which works
2231 much better in html) confused texinfo horribly, so I'm moving the
2232 index tags back to be just after the @subsection marker. I also
2233 added extra lines between the @node/@section paragraph and the
2234 index tags, since I think maybe texinfo wants to see these be
2235 separate paragraphs.
2237 * docs/Makefile (images): make sure images get built when
2238 rendering the manual
2239 * docs/images/Makefile: same
2241 * buildbot/scripts/runner.py: rename 'buildbot master' to
2242 'buildbot create-master', and 'buildbot slave' to 'buildbot
2244 * docs/buildbot.texinfo: same
2247 * docs/buildbot.texinfo: reimplement the "useful classes" index
2248 with actual texinfo indices. The .info rendering is a bit
2249 weird-looking but it works well, and the HTML rendering is quite
2250 nice. This also puts the index targets in the regular flow of the
2251 text, which is easier to maintain.
2253 2006-08-06 Brian Warner <warner@lothar.com>
2255 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
2256 Kevin Turner to prefer the environ= argument be a list rather than
2257 a string. If it is a list, it will be joined with a platform-local
2258 os.pathsep delimiter, and then prepended to any existing
2259 $PYTHONPATH value. This works better in cross-platform (i.e.
2260 windows buildslaves) environments when you need to push multiple
2261 directories onto the front of the path.
2262 (SlaveShellCommand): documented the new magic
2263 * docs/buildbot.texinfo (ShellCommand): documented the new magic
2264 in a user-visible form
2266 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
2267 Turner to prefer lists over strings when creating/running VC
2268 commands during unit tests. This is clearly necessary to survive
2269 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
2270 renamed the wq() function to qw() though, since that's how it's
2271 spelled in perl. Eventually I'd prefer all commands to be
2272 specified with lists.
2274 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
2275 which are deleted (or not yet created) correctly. Also add
2276 failsafe code to not explode if the file-watching poller doesn't
2277 get started. Thanks to JP Calderone for the catch and the poller
2279 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
2281 * buildbot/test/emitlogs.py: same
2283 * NEWS: summarize recent changes
2285 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
2286 clause to avoid the "host key mismatch" warning
2288 * buildbot/process/step_twisted.py (Trial.start): if the
2289 buildslave is too old to understand logfiles=, fall back to
2290 running 'cat _trial_temp/test.log' like before.
2291 (Trial.commandComplete): same. this takes advantage of the
2292 LoggingBuildStep refactoring to stall commandComplete long enough
2293 to run a second RemoteShellCommand.
2295 * buildbot/process/step.py (LoggingBuildStep.startCommand):
2296 refactor command-completion handling, to allow methods like
2297 commandComplete/createSummary/evaluateCommand to return Deferreds.
2298 (LoggingBuildStep._commandComplete): delete the refactored method
2299 (ShellCommand.setupLogfiles): if the buildslave is too old to
2300 understand logfiles=, put a warning message both into twistd.log
2301 and into the otherwise empty user-visible LogFiles.
2303 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
2304 callers to provide the slave-side logfile name, rather than
2305 forcing it to come from the local name of the LogFile.
2306 (BuildStep.getSlaveName): new method
2308 * buildbot/process/base.py (Build.getSlaveName): new method, so
2309 steps can find out which buildslave they're running on
2311 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
2312 to match the s/cvs_ver/command_version/ change
2314 2006-08-05 Brian Warner <warner@lothar.com>
2316 * buildbot/slave/commands.py (command_version): replace the CVS
2317 auto-updated cvs_ver keyword with a manually-updated variable,
2318 since CVS is no longer the master repository. Add a description of
2319 the remote API change starting in this version (2.1), specifically
2320 the fact that SlaveShellCommand now accepts 'initial_stdin',
2321 'keep_stdin_open', and 'logfiles'.
2323 2006-07-31 Brian Warner <warner@lothar.com>
2325 * docs/buildbot.texinfo (System Architecture): Finally add lots of
2326 diagrams to describe how the whole system fits together. The
2327 images themselves are kept in SVG files, with ascii-art versions
2328 in corresponding .txt files. Texinfo knows how to interpolate the
2329 text version into .info files, reference the .png versions from
2330 .html files, and include .eps versions in the .ps format.
2331 * docs/images/Makefile: tools to create .png and .eps
2332 * docs/images/*.svg: created pictures with Inkscape.
2333 * .darcs-boring: ignore the generated .eps and .png files
2335 2006-07-24 Brian Warner <warner@lothar.com>
2337 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
2338 Scheduler names, since they cause setServiceParent to explode
2340 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
2342 2006-07-20 Brian Warner <warner@lothar.com>
2344 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
2345 which runs the buildbot unit tests
2347 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
2348 classes that are useful in master.cfg
2350 2006-07-15 Brian Warner <warner@lothar.com>
2352 * Makefile (some-apidocs): new target to build only some epydocs
2354 * setup.py: minor comment.. does the classifiers= argument prevent
2355 the setup.py script from working on python2.2/2.3?
2357 * buildbot/scripts/sample.cfg: update manhole example, arrange into
2360 * buildbot/twcompat.py: fix minor typo in comments
2362 * buildbot/manhole.py: move all Manhole-related code out to this
2363 module. Implement SSH-based manholes (with TwistedConch), and move
2364 to conch's nifty line-editing syntax-coloring REPL shell instead
2365 of the boring non-editing monochromatic (and deprecated) old
2367 * buildbot/master.py: remove all Manhole-related code
2368 (BuildMaster.loadConfig._add): make sure the old manhole is
2369 removed before we add the new one
2370 * docs/buildbot.texinfo (Debug options): document new Manhole options
2372 * buildbot/twcompat.py (_which): fix some epydoc issues
2373 * buildbot/status/html.py (Waterfall.__init__): same
2375 2006-06-29 Brian Warner <warner@lothar.com>
2377 * buildbot/interfaces.py: get Interface from b.twcompat to hush
2378 deprecation warnings under newer Twisteds (by using
2379 zope.interface.Interface instead of old twisted.python.components
2381 * buildbot/slave/interfaces.py: same
2383 2006-06-28 Brian Warner <warner@lothar.com>
2385 * buildbot/slave/commands.py (SVN): add --non-interactive to all
2386 svn commands, so it will fail immediately instead of hanging while
2387 it waits for a username/password to be typed in.
2389 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
2390 log message if the step was shut down
2392 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
2393 obsolete reference to mktap.
2395 2006-06-20 Brian Warner <warner@lothar.com>
2397 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
2398 test to include new 'logfiles' argument sent from master to slave
2400 2006-06-19 Brian Warner <warner@lothar.com>
2402 * buildbot/process/step_twisted.py (Trial): track Progress from
2403 _trial_temp/test.log too
2405 * buildbot/process/step.py (OutputProgressObserver): generalize
2406 the earlier StdioProgressObserver into an OutputProgressObserver
2407 that can track LogFiles other than stdio.
2408 (LoggingBuildStep.__init__): same
2410 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
2411 _trial_temp/test.log, not a separate 'cat' command. TODO: this
2412 will fail under windows because of os.sep issues. It might have
2413 worked before if 'cat' was doing cygwin path conversion.
2415 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
2416 creation of LogFileWatchers
2417 (ShellCommand._startCommand): and record the files that were
2418 watched in the 'headers' section of the ShellCommand output
2420 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
2421 need to actually pass it to the slave if you want it to work.
2422 (ShellCommand): document it a bit
2424 * buildbot/test/test_shell.py: new test to validate LogFiles
2425 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
2427 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
2428 before printing the last batch of lines, to test that the polling
2429 logic is working properly
2431 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
2432 handling, making it possible to track multiple logs for a single
2433 RemoteCommand. The previous single logfile is now known as the
2435 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
2436 (RemoteShellCommand.__init__): accept logfiles=
2437 (LoggingBuildStep.startCommand): stdio_log is now one of many
2438 (ShellCommand): added logfiles= argument, as well as a class-level
2439 .logfiles attribute, which will be merged together to figure out
2440 which logfiles should be tracked. The latter maybe be useful for
2441 subclasses of ShellCommand which know they will aways produce
2442 secondary logfiles in the same location.
2444 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
2445 and closeStdin() methods, preparing to make it possible to write
2446 to a ShellCommand's stdin at any time, not just at startup. These
2447 writes are buffered if the child process hasn't started yet.
2448 (LogFileWatcher): new helper class to watch arbitrary logfiles
2449 while a ShellCommand runs. This class polls the file every two
2450 seconds, and sends back 10k chunks to the buildmaster.
2451 (ShellCommand): rename stdin= to initialStdin=, and add
2452 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
2454 (ShellCommand.addLogfile): LogFile text is sent in updates with a
2455 key of "log" and a value of (logname, data).
2456 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
2457 'logfiles' to the master-visible args dictionary.
2458 (SourceBase.doPatch): match s/stdin/initialStdin/ change
2461 * buildbot/test/test_vc.py (Patch.testPatch): same
2464 * buildbot/test/emit.py: write to a logfile in the current
2465 directory. We use this to figure out what was used as a basedir
2466 rather than looking to see which copy of emit.py gets run, so that
2467 we can run the commands from inside _trial_temp rather than inside
2469 * buildbot/test/subdir/emit.py: same
2470 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
2471 argument rather than running from buildbot/test/
2472 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
2473 rather than using an implicit setUp()
2474 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
2475 (ShellBase.testShell1, etc): use explicit path to emit.py instead
2476 of assuming that we're running in buildbot/test/ (and that '.' is
2479 * buildbot/slave/commands.py (Command.doStart): refactor Command
2480 startup/completion a bit: now the SlaveBuilder calls doStart(),
2481 which is not meant for overridding by subclasses, and doStart()
2482 calls start(), which is. Likewise the SlaveBuilder calls
2483 doInterrupt(), and subclasses override interrupt(). This also puts
2484 responsibility for maintaining .running in Command rather than in
2486 (Command.doInterrupt): same
2487 (Command.commandComplete): same, this is called when the deferred
2488 returned by start() completes.
2489 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
2490 (SlaveBuilder.remote_interruptCommand): same
2491 (SlaveBuilder.stopCommand): same
2493 2006-06-16 Brian Warner <warner@lothar.com>
2495 * buildbot/test/test_shell.py: new test file to contain everything
2496 relating to ShellCommand
2497 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
2498 multiple logfiles in realtime" feature, not yet implemented
2499 * buildbot/test/emitlogs.py: support file for testLogFiles
2500 * docs/buildbot.texinfo (ShellCommand): document the feature
2502 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2504 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2505 for tests which exercise SlaveCommands in isolation.
2507 * buildbot/test/test_slavecommand.py: Move some utilities like
2508 SignalMixin and FakeSlaveBuilder from here ..
2509 * buildbot/test/runutils.py: .. to here, so they can be used by
2510 other test classes too
2511 * buildbot/test/test_vc.py: more SignalMixin refactoring
2512 * buildbot/test/test_control.py: same
2513 * buildbot/test/test_run.py: and some rmtree refactoring
2515 2006-06-15 Brian Warner <warner@lothar.com>
2517 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2518 'testBranch' to match other VC tests and have the tests run in
2519 roughly increasing order of dependency
2521 * buildbot/test/test_steps.py (LogObserver): new test to verify
2522 LogObservers can be created at various times and still get
2523 connected up properly
2525 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2526 to create BuildStepStatus instances that actually work.
2528 * buildbot/process/step.py (LogObserver): add outReceived and
2529 errReceived base methods, to be overridden
2531 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2532 API to take a name instead of a step, reducing the coupling
2533 somewhat. This returns the BuildStepStatus object so it can be
2534 passed to the new Step, instead of jamming it directly into the
2536 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2538 * buildbot/process/base.py (Build.setupBuild): use both methods
2539 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2540 process a bit to match
2542 2006-06-14 Brian Warner <warner@lothar.com>
2544 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2545 docs on writing new LogObserver classes
2546 (Writing New Status Plugins): brief docs on how Status Plugins fit
2549 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2550 implement a LogObserver that counts how many unit tests have been
2552 (Trial.__init__): wire it in
2553 * buildbot/test/test_twisted.py (Counter): unit test for it
2555 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2556 to new cmd.logs['stdio'] scheme
2557 (Trial.commandComplete): same
2558 (BuildDebs.commandComplete): same
2560 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2561 LogFiles, instead of just a single one. The old single logfile is
2562 now called "stdio". LoggedRemoteCommand no longer creates a
2563 LogFile for you (the code to do that was broken anyway). If you
2564 don't create a "stdio" LogFile, then stdout/stderr will be
2566 (LogObserver): implement "LogObservers", which a BuildStep can add
2567 to parse the output of a command in real-time. The primary use is
2568 to provide more useful information to the Progress code, allowing
2569 better ETA estimates.
2570 (LogLineObserver): utility subclass which feeds complete lines to
2571 the parser instead of bytes.
2572 (BuildStep.progressMetrics): this is safer as a tuple
2573 (BuildStep.setProgress): utility method, meant to be called by
2575 (BuildStep.addLogObserver): new method, to be called at any time
2576 during the BuildStep (even before any LogFiles have been created),
2577 to attach (or schedule for eventual attachment) a LogObserver to a
2579 (StdioProgressObserver): new LogObserver which replaces the old
2580 "output" progress gatherer
2581 (LoggingBuildStep.__init__): same
2582 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2583 (LoggingBuildStep._commandComplete): must use logs['stdio']
2584 instead of the old single ".log" attribute.
2585 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2586 functionality, now subsumed into StdioProgressObserver
2587 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2588 log name changed from "output" to "stdio".
2591 * buildbot/interfaces.py (ILogFile): add the Interface used from
2592 the BuildStep towards the LogFile
2593 (ILogObserver): and the one provided by a LogObserver
2594 * buildbot/status/builder.py (LogFile): implement it
2596 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2597 HEADER constants here ..
2598 * buildbot/status/builder.py (STDOUT): .. from here
2600 2006-06-13 Brian Warner <warner@lothar.com>
2602 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2603 compatibility with python2.2, which doesn't have the 'substr in
2605 (TestP4Poller.makeTime): utility function to construct the
2606 timestamp using the same strptime() approach as p4poller does. It
2607 turns out that time.mktime() behaves slightly differently under
2608 python2.2, probably something to do with the DST flag, and that
2609 causes the test to fail under python2.2. (changing the mktime()
2610 arguments to have dst=0 instead of -1 caused it to fail under
2611 python2.3. Go figure.)
2612 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2614 2006-06-12 Brian Warner <warner@lothar.com>
2616 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2617 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2618 contributing such an excellent patch, including docs and unit
2619 tests! This makes it *so* much easier to apply. I had to update
2620 test_vc.py to handle some recent refactorings, but everything else
2621 applied smoothly. The only remaining thing I'd like to fix would
2622 be to remove the hard-wired port 1666 used by p4d, and allow it to
2623 claim any unused port. This would allow two copies of the test
2624 suite to run on the same host at the same time, as well as
2625 allowing the test suite to run while a real (production) p4d was
2626 running on the same host. Oh, and maybe we should add a warning to
2627 step.P4 that gets emitted if the slave is too old to provide the
2628 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2629 * buildbot/slave/commands.py (P4): same
2630 (P4Sync): same, some minor updates
2631 * buildbot/changes/p4poller.py: same
2632 * docs/buildbot.texinfo: same
2633 * buildbot/test/test_p4poller.py: same
2634 * buildbot/test/test_vc.py (P4): same
2636 * setup.py: add Trove classifiers for PyPI
2638 2006-06-08 Brian Warner <warner@allmydata.com>
2640 * buildbot/status/client.py
2641 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2642 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2643 build needs to be IRemote'd separately, rather than IRemote'ing
2644 the whole list at once. I can't wait until newpb's serialization
2645 adapters make this unnecessary.
2647 2006-06-06 Brian Warner <warner@lothar.com>
2649 * buildbot/process/step.py (WithProperties): make this inherit
2650 from ComparableMixin, so that reloading an unchanged config file
2651 doesn't cause us to spuriously reload any Builders which use them.
2652 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2655 2006-06-03 Brian Warner <warner@lothar.com>
2657 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2658 running py2exe on windows, contributed by Mark Hammond. Addresses
2659 SF#1401121, but I think we still need to include
2660 buildbot/scripts/sample.cfg
2661 * setup.py: include buildbot_service.py as a script under windows
2662 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2663 a py2exe application), get the icon/css datafiles from a different
2666 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2667 double-escape the build URL. Thanks to Olivier Bonnet for the
2668 patch. Fixes SF#1452801.
2670 2006-06-02 Brian Warner <warner@lothar.com>
2672 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2673 first six columns of 'svnlook' output, not just the first column,
2674 since property changes appear in the other five. Thanks to Olivier
2675 Bonnet for the patch. Fixes SF#1398174.
2677 2006-06-01 Brian Warner <warner@lothar.com>
2679 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2680 the fake build, so that title= has something to be set to
2682 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2683 attribute of the "Build #NN" link in the yellow start-the-build
2684 box to the build's reason. This means that you get a little
2685 tooltip explaining why the build was done when you hover over the
2686 yellow box. Thanks to Zandr Milewski for the suggestion.
2688 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2689 (Box.setETA): handle ETA=None (by stopping the timer)
2690 (Box.update): make the [soon] text less different than the usual
2691 text, so the rest of the text doesn't flop around so much. It
2692 would be awfully nice to figure out how to center this stuff.
2693 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2695 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2696 by default, so that any ShellCommand which fails marks the overall
2697 build as a failure. I should have done this from the beginning.
2698 Add flunkOnFailure=False to the arguments if you want to turn off
2701 2006-05-30 Brian Warner <warner@lothar.com>
2703 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2704 last-build/current-build/current-step. Show what step is currently
2705 running. Show ETA for both the overall build and the current step.
2706 Update GTK calls to modern non-deprecated forms. There's still a
2707 lot of dead code and debug noise to remove.
2709 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2710 shows up properly in status displays
2712 2006-05-28 Brian Warner <warner@lothar.com>
2714 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2715 build we use to verify that WithProperties works:
2717 ** set flunkOnFailure=True so that build failures get noticed
2718 ** set workdir='.' so that the build succeeds, otherwise it is trying
2719 to touch 'build/something', and 'build/' doesn't exist because
2720 usually that's created by a Source step
2721 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2722 this test somehow triggers, in which the 'touch' process becomes
2723 a zombie and we wait for th etimeout before giving up on it.
2725 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2726 to log the Build results and step logs to the twisted log.
2727 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2728 what went wrong if a build was expected to succeed but didn't.
2730 * buildbot/process/step_twisted.py (Trial): set the default
2731 trialMode to '--reporter=bwverbose', which specifies verbose
2732 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2733 '-to', but those are completely missing in modern Twisteds.
2735 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2736 a localhost-only port, to encourage better security
2738 * docs/buildbot.texinfo (Change Sources): mention
2741 * .darcs-boring: add a Darcs boringfile
2743 * README (REQUIREMENTS): stop claiming compatibility with
2746 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2749 2006-05-27 Brian Warner <warner@lothar.com>
2751 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2752 * docs/buildbot.texinfo: same
2754 2006-05-23 Brian Warner <warner@lothar.com>
2756 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2757 * docs/buildbot.texinfo: set version to match
2758 * NEWS: update for 0.7.3
2760 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2761 give a quick mapping from VC system to possible ChangeSources
2762 (Build Properties): add 'buildername'
2764 * buildbot/process/base.py (Build.setupStatus): oops, set
2765 'buildername' and 'buildnumber' properties
2766 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2769 2006-05-22 Brian Warner <warner@lothar.com>
2771 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2772 property interpolation better
2774 * README (INSTALLATION): remove old '-v' argument from recommended
2777 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2778 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2781 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2782 'svnversion' instead of grepping the output of 'svn info', much
2783 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2784 Bonnet for the suggestion.
2785 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2786 require the WC_PATH argument, so run 'svnversion .' instead.
2788 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2789 aren't supposed to have 'self' in their argument list
2791 2006-05-21 Brian Warner <warner@lothar.com>
2793 * buildbot/process/step.py (ShellCommand.start): make
2794 testInterpolate pass. I was passing the uninterpolated command to
2795 the RemoteShellCommand constructor
2796 (ShellCommand._interpolateProperties): oops, handle non-list
2797 commands (i.e. strings with multiple words separated by spaces in
2798 them) properly, instead of forgetting about them.
2800 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2801 to actually try to use build properties in a real build. This test
2803 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2804 to start and evaluate builds
2806 * buildbot/test/test__versions.py: add a pseudo-test to record
2807 what version of Twisted/Python/Buildbot are running. This should
2808 show up at the beginning of _trial_tmp/test.log, and exists to help
2809 debug other problems.
2811 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2812 a filename to be served as 'robots.txt' to discourage web spiders.
2813 Adapted from a patch by Tobi Vollebregt, thanks!
2814 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2815 (Waterfall.test_waterfall): tweak the way that filenames are put
2816 into the config file, to accomodate windows pathnames better.
2818 * docs/buildbot.texinfo (HTML Waterfall): document it
2820 * buildbot/process/process_twisted.py
2821 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2822 changed the build process. The new setup.py no longer takes the
2824 (FullTwistedBuildFactory.__init__): same
2825 (TwistedReactorsBuildFactory.__init__): same
2827 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2828 be placed in the [hooks] section of the central repository (the
2829 one that everybody pushes changes to).
2831 2006-05-20 Brian Warner <warner@lothar.com>
2833 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2834 .darcs-context file, use binary mode. I think this was causing a
2835 Darcs failure under windows.
2837 2006-05-19 Brian Warner <warner@lothar.com>
2839 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2840 use a timezone string of +0000 and gmtime, since this timestamp is
2841 sent to a buildmaster and %z is broken.
2843 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2844 string and localtime, since this timestamp will only be consumed
2845 locally, and %z is broken.
2847 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2848 gmtime, since this timestamp is returned to the buildmaster, and
2851 2006-05-18 Brian Warner <warner@lothar.com>
2853 * NEWS: update in preparation for next release
2855 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2856 setup-repository and do-we-have-the-vc-tools code into a separate
2857 "helper" class, which sticks around in a single module-level
2858 object. This seems more likely to continue to work in the future
2859 than having it hide in the TestCase and hope that TestCases stick
2860 around for a long time.
2862 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2863 addremove' has been deprecated in recent versions of mercurial, so
2864 use 'hg add' instead
2866 2006-05-07 Brian Warner <warner@lothar.com>
2868 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2869 operating under windows, move the file before opening it, since
2870 you can't rename a file that somebody has open.
2872 * buildbot/process/base.py (Build.setupBuild): if something goes
2873 wrong while creating a Step, log the name and arguments, since the
2874 error message when you get the number of arguments wrong is really
2877 2006-05-06 Brian Warner <warner@lothar.com>
2879 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2880 bugs in twisted-specific code not covered by my unit tests, this
2881 time use 'cmd' argument instead of self.cmd
2883 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2884 fix stupid braino: either use startwith or find()==0, not both.
2885 (TwistedReactorsBuildFactory.__init__): another dumb typo
2887 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2888 mark this test as TODO under windows, since process-killing seems
2889 dodgy there. We'll come back to this later and try to fix it
2892 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2893 and don't include a timezone
2894 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2895 This should avoid the windows-with-verbose-timezone-name problem
2897 (Patch.testPatch): add a test which runs 'patch' with less
2898 overhead than the full VCBase.do_patch sequence, to try to isolate
2899 a windows test failure. This one uses slave.commands.ShellCommand
2900 and 'patch', but none of the VC code.
2902 * buildbot/slave/commands.py (getCommand): use which() to find the
2903 executables for 'cvs', 'svn', etc. This ought to help under
2906 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2907 working directory before starting. If an earlier test failed, the
2908 leftover directory would mistakenly flunk a later test.
2909 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2910 Make sure that we use the right commandlines if which("tla") picks
2911 up "tla.exe" (as it does under windows).
2912 (TlaSupport.do_get): factor out this tla-vs-baz difference
2913 (TlaSupport.vc_create): more tla-vs-baz differences
2915 * buildbot/test/test_slavecommand.py
2916 (ShellBase.testShellMissingCommand): stop trying to assert
2917 anything about the error message: different shells on different
2918 OSes with different languages makes it hard, and it really isn't
2919 that interesting of a thing to test anyway.
2921 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2922 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2923 "Panther"), because it has a bug which flunks a couple tests in
2924 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2925 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2926 able to test that yet.
2928 2006-04-30 Brian Warner <warner@lothar.com>
2930 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2931 make sure child commands emit messages in english, so our regexps
2932 will match. Thanks to Nikaus Giger for identifying the problems.
2933 (VCBase._do_vctest_export_1): mode="export" is not responsible
2934 for setting the "got_revision" property, since in many cases it is
2935 not convenient to determine.
2936 (SVNSupport.capable): when running 'svn --version' to check for
2937 ra_local, we want error messages in english
2938 * buildbot/test/test_slavecommand.py
2939 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2940 to emit the error message in english
2942 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2943 the environment with $LC_ALL="C" so that Commands which need to
2944 parse the output of their child processes can obtain it in
2946 (SVN.parseGotRevision): call "svn info" afterwards instead of
2947 watching the output of the "svn update" or "svn checkout".
2948 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2949 (Arch.parseGotRevision): same
2950 (Bazaar.parseGotRevision): same
2951 (Mercurial.parseGotRevision): same
2953 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2954 $LC_ALL="C" when running commands under 'buildbot try', too
2956 * buildbot/test/__init__.py: remove the global os.environ()
2957 setting, instead we do it just for the tests that run commands and
2958 need to parse their output.
2960 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2961 remove the overly-short .timeout on this test, because non-DNotify
2962 platforms must fall back to polling which happens at 10 second
2963 intervals, so a 5 second timeout would never succeed.
2965 2006-04-24 Brian Warner <warner@lothar.com>
2967 * docs/buildbot.texinfo (Installing the code): update trial
2968 invocation, SF#1469116 by Niklaus Giger.
2969 (Attributes of Changes): updated branch-name examples to be
2970 a bit more realistic, SF#1475240 by Stephen Davis.
2972 * contrib/windows/buildbot2.bat: utility wrapper for windows
2973 developers, contributed by Nick Trout (after a year of neglect..
2974 sorry!). SF#1194231.
2976 * buildbot/test/test_vc.py (*.capable): store the actual VC
2977 binary's pathname in VCS[vcname], so it can be retrieved later
2978 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2979 strip out non-numeric timezone information, specifically the funky
2980 German string that his system produced that confuses CVS.
2981 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2982 allow Darcs tests to work on windows
2983 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2984 procutils.which() everywhere, to allow tryclient to work under
2985 windows. Also from Niklaus Giger, SF#1463394.
2987 * buildbot/twcompat.py (which): move the replacement for a missing
2988 twisted.python.procutils.which from test_vc.py to here, so it can
2989 be used in other places too (specifically tryclient.py)
2991 2006-04-23 Brian Warner <warner@lothar.com>
2993 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2994 bare buildbotURL/projectName line with a proper DIV, along with a
2995 CSS class of "title", from Stefan Seefeld (SF#1461675).
2996 (WaterfallStatusResource.body0): remove the redundant 'table'
2997 class from the table
2998 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2999 to the top-row TR, and class="Activity" to the second-row TR,
3000 rather than putting them in the individual TD nodes.
3002 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
3003 'got_revision' build property for all VC systems that implement
3004 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
3006 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
3007 to determine which revision we actually obtained
3008 (CVS.parseGotRevision): implement this for CVS, which just means
3009 to grab a timestamp. Not ideal, and it depends upon the buildslave
3010 having a clock that is reasonably well syncronized with the server,
3011 but it's better than nothing.
3012 (SVN.parseGotRevision): implement it for SVN, which is accurate
3013 (Darcs.parseGotRevision): same
3014 (Arch.parseGotRevision): same
3015 (Bazaar.parseGotRevision): same
3016 (Mercurial.parseGotRevision): same
3018 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
3019 keep a record of all non-stdout/stderr/header/rc status updates,
3020 for the benefit of RemoteCommands that send other useful things,
3022 (Source.commandComplete): put any 'got_revision' status values
3023 into a build property of the same name
3026 * buildbot/process/step_twisted.py (Trial): update to deal with
3027 new ShellCommand refactoring
3029 * docs/buildbot.texinfo (Build Properties): document new feature
3030 that allows BuildSteps to get/set Build-wide properties like which
3031 revision was requested and/or checked out.
3033 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
3034 * buildbot/status/builder.py (BuildStatus.getProperty): implement
3035 it. Note that this bumps the persistenceVersion of the saved Build
3036 object, so add the necessary upgrade-old-version logic to include
3037 an empty properties dict.
3039 * buildbot/process/base.py (Build.setProperty): implement it
3040 (Build.getProperty): same
3041 (Build.startBuild): change build startup to set 'branch',
3042 'revision', and 'slavename' properties at the right time
3044 * buildbot/process/step.py (BuildStep.__init__): change setup to
3045 require 'build' argument in a better way
3046 (LoggingBuildStep): split ShellCommand into two pieces, for better
3047 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
3048 a single RemoteCommand that sends stdout/stderr status text. It
3049 also provides the usual commandComplete / createSummary /
3050 evaluateCommand / getText methods to be overridden...
3051 (ShellCommand): .. whereas ShellCommand is specifically for
3052 running RemoteShellCommands. Other shell-like BuildSteps (like
3053 Source) can inherit from LoggingBuildStep instead of ShellCommand
3054 (WithProperties): marker class to do build-property interpolation
3055 (Source): inherit from LoggingBuildStep instead of ShellCommand
3058 * buildbot/test/test_properties.py: test new functionality
3060 2006-04-21 Brian Warner <warner@lothar.com>
3062 * buildbot/test/test_vc.py: rename testBranch to
3063 testCheckoutBranch to keep the tests in about the right
3066 2006-04-18 Brian Warner <warner@lothar.com>
3068 * docs/buildbot.texinfo (PBListener): improve cross-references
3069 between PBListener and 'buildbot statusgui', thanks to John Pye
3072 2006-04-17 Brian Warner <warner@lothar.com>
3074 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
3075 running under Twisted-1.3.0, otherwise skipped tests are reported
3078 * all: use isinstance() instead of 'type(x) is foo', suggested by
3081 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3082 oops, fix a brain-fade from the other week, when making the
3083 addStep changes. I changed all the __init__ upcalls to use the
3084 wrong superclass name.
3085 (FullTwistedBuildFactory.__init__): same
3086 (TwistedDebsBuildFactory.__init__): same
3087 (TwistedReactorsBuildFactory.__init__): same
3088 (TwistedBuild.isFileImportant): use .startswith for clarity,
3089 thanks to Neal Norwitz for the suggestions.
3091 * contrib/viewcvspoll.py: script to poll a viewcvs database for
3092 changes, then deliver them over PB to a remote buildmaster.
3094 * contrib/svnpoller.py: added script by John Pye to poll a remote
3095 SVN repository (by running 'svn log') from a cronjob, and run
3096 'buildbot sendchange' to deliver the changes to a remote
3098 * contrib/svn_watcher.py: added script by Niklaus Giger (a
3099 modification of svnpoller.py), same purpose, but this one loops
3100 internally (rather than expecting to run from a cronjob) and works
3102 * contrib/README.txt: same
3104 2006-04-11 Brian Warner <warner@lothar.com>
3106 * all: fix a number of incorrect names and missing imports, thanks
3107 to Anthony Baxter for the patch.
3108 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
3109 remove unused buggy method.
3110 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
3111 comes from shutil, not "shutils"
3112 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
3113 (Arch.checkSlaveVersion): same
3114 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
3116 * buildbot/process/step_twisted2.py: add some missing imports
3117 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
3118 this code used to live in twisted.internet.defer
3120 2006-04-10 Brian Warner <warner@lothar.com>
3122 * buildbot/process/step.py (Mercurial): add Mercurial support
3123 * buildbot/slave/commands.py (Mercurial): same
3124 * buildbot/scripts/tryclient.py (MercurialExtractor): same
3125 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
3126 not yet tested, but 'try' support *is* covered
3127 * docs/buildbot.texinfo (Mercurial): document it
3129 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
3130 some debugging messages (turned off)
3131 * buildbot/test/test_vc.py: improve debug messages
3133 2006-04-07 Brian Warner <warner@lothar.com>
3135 * buildbot/test/test_vc.py (which): define our own which() in case
3136 we can't import twisted.python.procutils, because procutils doesn't
3137 exist in Twisted-1.3
3139 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
3140 of SlaveLocks for performance tests
3142 * docs/examples/twisted_master.cfg: update to match current usage
3144 * buildbot/changes/p4poller.py (P4Source): add new arguments:
3145 password, p4 binary, pollinterval, maximum history to check.
3146 Patch from an anonymous sf.net contributor, SF#1219384.
3147 * buildbot/process/step.py (P4Sync.__init__): add username,
3148 password, and client arguments.
3149 * buildbot/slave/commands.py (P4Sync): same
3151 2006-04-05 Brian Warner <warner@lothar.com>
3153 * buildbot/process/factory.py (BuildFactory.addStep): new method
3154 to add steps to a BuildFactory. Use it instead of f.steps.append,
3155 and you can probably avoid using the s() convenience function.
3156 Patch from Neal Norwitz, sf.net #1412605.
3157 (other): update all factories to use addStep
3158 * buildbot/process/process_twisted.py: update all factories to use
3161 2006-04-03 Brian Warner <warner@lothar.com>
3163 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
3164 work under windows too. Adapted from a patch by Niklaus Giger,
3165 addresses SF#1463399.
3167 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
3168 spawned commands emit parseable results in english and not some
3169 other language. Patch from Niklaus Giger, SF#1463395.
3171 * README (INSTALLATION): discourage users from running unit tests on
3172 a "network drive", patch from Niklaus Giger, SF#1463394.
3174 2006-03-22 Brian Warner <warner@lothar.com>
3176 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
3177 function to turn a repository-relative pathname into a (branch,
3178 branch-relative-filename) tuple. Change this function to handle
3179 the branch naming policy used by your Subversion repository.
3180 Thanks to AllMyData.com for sponsoring this work.
3182 2006-03-16 Brian Warner <warner@lothar.com>
3184 * buildbot/scripts/sample.cfg: add python-mode declaration for
3185 vim. Thanks to John Pye for the patch.
3187 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
3188 command line, mention the importance of running 'crontab' as the
3189 buildmaster/buildslave user. Thanks to John Pye for the catch.
3191 2006-03-13 Brian Warner <warner@lothar.com>
3193 * buildbot/status/words.py (IRC): add an optional password=
3194 argument, which will be sent to Nickserv in an IDENTIFY message at
3195 login, to claim the nickname. freenode requires this before the
3196 bot can sent (or reply to) private messages. Thanks to Clement
3197 Stenac for the patch.
3198 * docs/buildbot.texinfo (IRC Bot): document it
3200 * buildbot/status/builder.py (LogFile.merge): don't write chunks
3201 larger than chunkSize. Fixes SF#1349253.
3202 * buildbot/test/test_status.py (Log.testLargeSummary): test it
3203 (Log.testConsumer): update to match new internal chunking behavior
3205 2006-03-12 Brian Warner <warner@lothar.com>
3207 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
3209 * buildbot/test/test_maildir.py (MaildirTest): rename the
3210 'timeout' method, as it collides with trial's internals
3212 * buildbot/scripts/runner.py: add 'buildbot restart' command
3213 (stop): don't sys.exit() out of here, otherwise restart can't work
3214 * docs/buildbot.texinfo (Shutdown): document it
3216 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
3217 * buildbot/status/html.py (Waterfall.__init__): same
3218 * buildbot/process/builder.py (Builder.startBuild): same
3219 * buildbot/process/base.py (BuildRequest): same
3220 * buildbot/sourcestamp.py (SourceStamp): same
3221 * buildbot/scheduler.py (Nightly): same
3223 * buildbot/__init__.py (version): bump to 0.7.2+ while between
3225 * docs/buildbot.texinfo: same
3227 2006-02-17 Brian Warner <warner@lothar.com>
3229 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
3230 * docs/buildbot.texinfo: set version number to match
3231 * NEWS: update for 0.7.2
3233 2006-02-16 Brian Warner <warner@lothar.com>
3235 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
3237 2006-02-09 Brian Warner <warner@lothar.com>
3239 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
3240 add text to explain per-build branch parameters
3241 * NEWS: mention --umask
3243 2006-02-08 Brian Warner <warner@lothar.com>
3245 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
3247 (SlaveOptions.optParameters): add --umask, to make it possible to
3248 make buildslave-generated files (including build products) be
3251 * buildbot/slave/bot.py (BuildSlave.startService): same
3253 2006-01-23 Brian Warner <warner@lothar.com>
3255 * buildbot/status/builder.py: urllib.quote() all URLs that include
3256 Builder names, so that builders can include characters like '/'
3257 and ' ' without completely breaking the resulting HTML. Thanks to
3258 Kevin Turner for the patch.
3259 * buildbot/status/html.py: same
3260 * buildbot/test/test_web.py (GetURL.testBuild): match changes
3262 * NEWS: update in preparation for upcoming release
3264 2006-01-18 Brian Warner <warner@lothar.com>
3266 * docs/examples/twisted_master.cfg: update to match the Twisted
3267 buildbot: remove python2.2, switch to exarkun's buildslaves,
3268 disable the .deb builder until we figure out how to build twisted
3269 .debs from SVN, add some ktrace debugging to the OS-X build
3270 process and remove the qt build, remove threadless builders,
3271 change freebsd builder to use landonf's buildslave.
3273 2006-01-12 Brian Warner <warner@lothar.com>
3275 * buildbot/master.py (Manhole.__init__): let port= be a strports
3276 specification string, but handle a regular int for backwards
3277 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
3278 used in master.cfg to limit connections to just the local host.
3279 (BuildMaster.loadConfig): same for c['slavePortnum']
3280 * buildbot/scheduler.py (Try_Userpass.__init__): same
3281 * buildbot/status/client.py (PBListener.__init__): same
3282 * buildbot/status/html.py (Waterfall.__init__): same, for both
3283 http_port and distrib_port. Include backwards-compatibility checks
3284 so distrib_port can be a filename string and still mean unix:/foo
3285 * docs/buildbot.texinfo (Setting the slaveport): document it
3286 (Debug options): same
3287 (HTML Waterfall): same
3290 * buildbot/test/test_config.py (ConfigTest): test it
3292 * buildbot/master.py (BuildMaster.loadConfig): wait for the
3293 slaveport's disownServiceParent deferred to fire before opening
3294 the new one. Fixes an annoying bug in the unit tests.
3296 2006-01-03 Brian Warner <warner@lothar.com>
3298 * buildbot/master.py (BuildMaster): remove the .schedulers
3299 attribute, replacing it with an allSchedulers() method that looks
3300 for all IService children that implement IScheduler. Having only
3301 one parent/child relationship means fewer opportunities for bugs.
3302 (BuildMaster.allSchedulers): new method
3303 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
3304 also fix ugly bug that caused any config-file reload to
3305 half-forget about the earlier Schedulers, causing an exception
3306 when a Change arrived and was handed to a half-connected
3307 Scheduler. The exception was in scheduler.py line 54ish:
3308 self.parent.submitBuildSet(bs)
3309 exceptions.AttributeError: 'NoneType' object has no attribute
3311 (BuildMaster.addChange): update to use allSchedulers()
3313 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
3314 to work properly with twisted-1.3.0, where you must explicitly
3315 include the __implements__ from parent classes
3316 (BaseScheduler.__repr__): make it easier to distinguish distinct
3318 (BaseUpstreamScheduler.__implements__): same
3320 * buildbot/status/builder.py (Status.getSchedulers): update to
3322 * buildbot/test/test_run.py (Run.testMaster): same
3323 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
3324 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
3325 make sure Scheduler instances are left alone when an identical
3326 config file is reloaded
3327 (ConfigElements.testSchedulers): make sure Schedulers are properly
3330 * Makefile (TRIALARGS): my local default Twisted version is now
3331 2.1.0, update the trial arguments accordingly
3333 2005-12-22 Brian Warner <warner@lothar.com>
3335 * docs/examples/twisted_master.cfg: merge changes from pyr: add
3338 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
3339 addChange in the parent class, although I suspect this should be
3340 fixed better in the future.
3342 2005-11-26 Brian Warner <warner@lothar.com>
3344 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
3345 explode when branch==None, thanks to Kevin Turner for the catch
3346 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
3349 * buildbot/__init__.py (version): bump to 0.7.1+ while between
3351 * docs/buildbot.texinfo: same
3353 2005-11-26 Brian Warner <warner@lothar.com>
3355 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
3356 * docs/buildbot.texinfo: set version number to match
3358 2005-11-26 Brian Warner <warner@lothar.com>
3360 * NEWS: update for 0.7.1
3362 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
3363 sure that unsubscribe works even if we never sent an ETA update.
3364 Also, don't explode on duplicate unsubscribe.
3365 (BuildStepStatus.addLog): make the convenience "return self"-added
3366 watcher automatically unsubscribe when the Step finishes.
3367 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
3368 (BuildStatus.stepStarted): same auto-unsubscribe
3369 (BuilderStatus.buildStarted): same auto-unsubscribe
3371 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
3373 (IStatusReceiver.stepStarted): same
3374 (IStatusReceiver.logStarted): same
3376 * buildbot/test/test_run.py (Status): move the Status test..
3377 * buildbot/test/test_status.py (Subscription): .. to here
3379 2005-11-25 Brian Warner <warner@lothar.com>
3381 * NEWS: more updates
3383 * buildbot/locks.py: fix the problem in which loading a master.cfg
3384 file that changes some Builders (but not all of them) can result
3385 in having multiple copies of the same Lock. Now, the real Locks
3386 are kept in a table inside the BotMaster, and the Builders/Steps
3387 use "LockIDs", which are still instances of MasterLock and
3388 SlaveLock. The real Locks are instances of the new RealMasterLock
3389 and RealSlaveLock classes.
3390 * buildbot/master.py (BotMaster.getLockByID): new method to
3391 convert LockIDs into real Locks.
3392 * buildbot/process/base.py (Build.startBuild): convert LockIDs
3393 into real Locks before building
3394 * buildbot/process/step.py (BuildStep.startStep): same
3395 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
3396 exercises the problem
3399 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
3400 what Schedulers are available
3402 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
3403 work by Dobes Vandermeer and hacked mercilessly by me. This offers
3404 'cron'-style build scheduling at certain times of day, week,
3406 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
3408 * buildbot/scheduler.py (Scheduler): change fileIsImportant
3409 handling: treat self.fileIsImportant more as an attribute that
3410 contains a callable than as a method. If the attribute is None,
3411 don't call it and assume all filenames are important. It is still
3412 possible to provide a fileIsImportant method in a subclass,
3414 (AnyBranchScheduler): handle fileIsImportant=None, previously it
3416 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
3417 test using AnyBranchScheduler with fileIsImportant=None
3419 2005-11-24 Brian Warner <warner@lothar.com>
3421 * buildbot/test/test_config.py (StartService): don't claim a fixed
3422 port number, instead set slavePort=0 on the first pass, figure out
3423 what port was allocated, then switch to a config file that uses
3426 * buildbot/master.py (BuildMaster.loadConfig): close the old
3427 slaveport before opening the new one, because unit tests might
3428 replace slavePort=0 with the same allocated portnumber, and if we
3429 don't wait for the old port to close first, we get a "port already
3430 in use" error. There is a tiny race condition here, but the only
3431 threat is from other programs that bind (statically) to the same
3432 port number we happened to be allocated, and only if those
3433 programs use SO_REUSEADDR, and only if they get control in between
3436 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
3438 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
3439 deleted ChangeSources before adding any new ones
3440 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
3441 compare_attrs, to make sure that a config-file reload does not
3442 unnecessarily replace an unmodified ChangeSource instance
3443 * buildbot/test/test_config.py (ConfigTest.testSources): update
3445 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
3446 mean "don't build anything", and add a warning if it gets used
3447 because it isn't actually useful.
3449 * contrib/svn_buildbot.py: update example usage to match the port
3450 number that gets used by the PBChangeSource
3451 * buildbot/scripts/sample.cfg: add example of PBChangeSource
3453 2005-11-22 Brian Warner <warner@lothar.com>
3455 * NEWS: start collecting items for next release
3457 * buildbot/process/step.py (SVN.computeSourceRevision): assume
3458 revisions are strings
3459 (P4Sync.computeSourceRevision): same
3461 * buildbot/status/html.py (StatusResourceBuild.body): add a link
3462 to the Buildbot's overall status page
3463 (StatusResourceBuilder.body): same
3465 2005-11-15 Brian Warner <warner@lothar.com>
3467 * buildbot/master.py (BuildMaster.loadConfig): serialize the
3468 config-file loading, specifically to make sure old StatusTargets
3469 are finished shutting down before new ones start up (thus
3470 resolving a bug in which changing the Waterfall object would fail
3471 because both new and old instances were claiming the same
3472 listening port). Also load new Schedulers after all the new
3473 Builders are set up, in case they fire off a new build right away.
3474 * buildbot/test/test_config.py (StartService): test it
3476 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
3477 the branch name to the mail body
3479 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
3480 Without it, a config-file reload fails to update an existing
3482 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
3483 username/passwd to compare_attrs, for the same reason
3484 * buildbot/status/html.py (Waterfall): add favicon to
3485 compare_attrs, same reason
3487 2005-11-05 Brian Warner <warner@lothar.com>
3489 * buildbot/scripts/tryclient.py (createJobfile): stringify the
3490 baserev before stuffing it in the jobfile. This resolves problems
3491 under SVN (and probably Arch) where revisions are expressed as
3492 numbers. I'm inclined to use string-based revisions everywhere in
3493 the future, but this fix should be safe for now. Thanks to Steven
3494 Walter for the patch.
3496 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
3497 binary mode when opening pickle files, to make windows work
3498 better. Thanks to Dobes Vandermeer for the catch.
3499 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3500 (BuilderStatus.getBuildByNumber): same
3501 (Status.builderAdded): same
3502 * buildbot/master.py (BuildMaster.loadChanges): same
3504 * buildbot/util.py (Swappable): delete unused leftover code
3506 * buildbot/process/step.py (SVN): when building on a non-default
3507 branch, add the word "[branch]" to the VC step's description, so
3508 it is obvious that we're not building the usual stuff. Likewise,
3509 when we are building a specific revision, add the text "rNNN" to
3510 indicate what that revision number is. Thanks to Brad Hards and
3511 Nathaniel Smith for the suggestion.
3512 (Darcs.startVC): same
3513 (Arch.startVC): same
3514 (Bazaar.startVC): same
3516 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3517 typo, caught by Mark Dillavou, closes SF#1216636.
3519 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3520 about a test to add some day
3522 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3523 the 'full-2.3' build, and the 'reactors' build is now run under
3524 python-2.4 because the buildslave no longer has gtk/etc bindings
3525 for earlier versions.
3527 2005-11-03 Brian Warner <warner@lothar.com>
3529 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3530 method, takes an IBuildStatus and rebuilds it. It might make more
3531 sense to add this to IBuildControl instead, but that instance goes
3532 away completely once the build has finished, and resubmitting
3533 builds can take place weeks later.
3534 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3535 * buildbot/status/html.py (StatusResourceBuild): also stash an
3536 IBuilderControl so we can use resubmitBuild.
3537 (StatusResourceBuild.body): render "resubmit" button if we can.
3538 Also add hrefs for each BuildStep
3539 (StatusResourceBuild.rebuild): add action for "resubmit" button
3540 (StatusResourceBuilder.getChild): give it an IBuilderControl
3542 * buildbot/status/builder.py (Status.getURLForThing): change the
3543 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3544 that live as targets of buttons like "stop" and "rebuild" can't
3546 * buildbot/status/builder.py (Status.getURLForThing): same
3547 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3548 (StepBox.getBox): same
3549 * buildbot/test/test_web.py (GetURL): same
3552 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3553 exclusivity checks after Source.__init__ upcall, so misspelled
3554 arguments will be reported more usefully
3555 (Darcs.__init__): same
3557 2005-10-29 Brian Warner <warner@lothar.com>
3559 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3560 builder. Move the Try scheduler off to a separate port.
3562 2005-10-27 Brian Warner <warner@lothar.com>
3564 * buildbot/clients/gtkPanes.py
3565 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3566 to cause the app to crash, now they don't.
3568 * buildbot/clients/debug.py: display the buildmaster's location
3569 in the window's title bar
3571 2005-10-26 Brian Warner <warner@lothar.com>
3573 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3574 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3575 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3577 * buildbot/status/html.py (td): put a single non-breaking space
3578 inside otherwise empty <td> elements, as a workaround for buggy
3579 browsers which would optimize them away (along with any associated
3580 styles, like the kind that create the waterfall grid borders).
3581 Patch from Frerich Raabe.
3583 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3584 argv-list as an argument, defaulting to ["-to"], which is
3585 appropriate for the Trial that comes with Twisted-2.1.0 and
3586 earlier. The Trial in current Twisted SVN wants
3587 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3588 defaults to an empty list.
3589 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3590 match it, now that trialMode= is a list instead of a single string
3592 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3594 * docs/buildbot.texinfo: same
3596 2005-10-24 Brian Warner <warner@lothar.com>
3598 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3599 * docs/buildbot.texinfo: set version number to match
3601 2005-10-24 Brian Warner <warner@lothar.com>
3603 * README: update for 0.7.0
3605 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3607 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3608 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3609 send the branch= argument unless the user really provided one, to
3610 retain compatibility with older buildmasters that don't accept
3612 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3615 * docs/buildbot.texinfo: update lots of stuff
3617 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3618 to the 'buildbot sendchange' command
3619 * buildbot/clients/sendchange.py (Sender.send): same
3620 * buildbot/changes/pb.py (ChangePerspective): same
3621 * buildbot/test/test_changes.py (Sender.testSender): test it
3623 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3624 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3625 for consistency with other BuildStep arguments that use camelCase.
3626 Well, at least more of them use camelCase (like flunkOnWarnings)
3627 than don't.. I wish I'd picked one style and stuck with it
3628 earlier. Annoying, but it's best done before the release, since
3629 these arguments didn't exist at all in 0.6.6 .
3631 * buildbot/test/test_vc.py (SVN.testCheckout): same
3632 (Darcs.testPatch): same
3633 * docs/buildbot.texinfo (SVN): document the change
3634 (Darcs): same, add some build-on-branch docs
3635 * docs/examples/twisted_master.cfg: match change
3637 * buildbot/process/step.py (BuildStep): rename
3638 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3639 how it is normally used.
3640 * buildbot/test/test_steps.py (Version.checkCompare): same
3642 * buildbot/process/step.py (CVS.startVC): refuse to build
3643 update/copy -style builds on a non-default branch with an old
3644 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3645 concern is that it will do a VC 'update' in an existing tree when
3646 it is supposed to be switching branches (and therefore clobbering
3647 the tree to do a full checkout), thus building the wrong source.
3648 This used to be a warning, but I think the confusion it is likely
3649 to cause warrants making it an error.
3650 (SVN.startVC): same, also make mode=export on old slaves an error
3651 (Darcs.startVC): same
3652 (Git.startVC): improve error message for non-Git-enabled slaves
3653 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3654 specific revision is built on a slave that doesn't pay attention
3655 to args['revision'], because for slowly-changing trees it will
3656 probably do the right thing, and because we have no way to tell
3657 whether we're asking it to build the most recent version or not.
3658 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3660 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3661 that 'master' is in host:portnum format, to catch errors sooner
3663 2005-10-23 Brian Warner <warner@lothar.com>
3665 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3666 when creating the list of warning messages, include the line
3667 immediately after each WARNING: line, since that's usually where
3668 the file and line number wind up.
3670 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3675 2005-10-22 Brian Warner <warner@lothar.com>
3677 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3678 patch from Brad Hards
3679 * buildbot/status/classic.css: same
3680 * buildbot/test/test_web.py (Waterfall): match changes
3682 * buildbot/test/test_steps.py (BuildStep.setUp): set
3683 nextBuildNumber so the test passes
3684 * buildbot/test/test_status.py (MyBuilder): same
3686 * buildbot/status/html.py (StatusResourceBuild.body): revision
3687 might be numeric, so stringify it before html-escapifying it
3688 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3689 timer for the upcoming build
3690 * buildbot/status/classic.css: add background-color attributes for
3691 offline/waiting/building classes
3693 * buildbot/status/builder.py (BuildStatus): derive from
3694 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3695 the default (i.e. unknown) .slavename to "???" instead of None,
3696 since even unknown slavenames need to be printed eventually.
3697 (BuilderStatus): also derive from styles.Versioned . More
3698 importantly, determine .nextBuildNumber at creation/unpickling
3699 time by scanning the directory of saved BuildStatus instances and
3700 choosing one larger than the highest-numbered one found. This
3701 should fix the problem where random errors during upgrades cause
3702 the buildbot to forget about earlier builds. .nextBuildNumber is
3703 no longer stored in the pickle.
3704 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3705 at least log the error. Also call Builder.determineNextBuildNumber
3706 once the basedir is set.
3708 * buildbot/master.py (BuildMaster.loadChanges): do
3709 styles.doUpgrade afterwards, in case I decide to make Changes
3710 derived from styles.Versioned some day and forget to make this
3714 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3715 when running under older pythons (<2.3) in which the shlex module
3716 doesn't have a 'split' function.
3718 * buildbot/process/step.py (ShellCommand.start): make
3719 errorMessages= be a list of strings to stuff in the log before the
3720 command actually starts. This makes it easier to flag multiple
3721 warning messages, e.g. when the Source steps have to deal with an
3723 (CVS.startVC): handle slaves that don't handle multiple branches
3724 by switching into 'clobber' mode
3725 (SVN.startVC): same. Also reject branches without base_url
3726 (Darcs.startVC): same. Also reject revision= in older slaves
3727 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3728 (Bazaar.startVC): same, and test for baz separately than for arch
3730 * buildbot/slave/commands.py (cvs_ver): document new features
3732 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3733 (BuildStep.slaveVersionNewEnough): more useful utility method
3734 * buildbot/test/test_steps.py (Version): start testing it
3736 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3737 the 'force' command requires python2.3, for the shlex.split method
3739 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3740 since we don't use it anymore. The Twisted buildbot uses a
3743 2005-10-21 Brian Warner <warner@lothar.com>
3745 * buildbot/process/process_twisted.py: rework all BuildFactory
3746 classes to take a 'source' step as an argument, instead of
3747 building up the SVN instance in the factory.
3748 * docs/examples/twisted_master.cfg: enable build-on-branch by
3749 providing a base_url and default_branch
3751 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3752 control over --branch and --revision, not that they are always
3754 * buildbot/status/html.py (StatusResourceBuilder.force): same
3755 (StatusResourceBuild.body): display SourceStamp components
3757 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3758 IRC 'force' command, so it can be shared with an eventual
3759 command-line-tool 'buildbot force' mode.
3760 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3762 2005-10-20 Brian Warner <warner@lothar.com>
3764 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3766 * docs/examples/twisted_master.cfg: update to use Schedulers
3768 * buildbot/scripts/sample.cfg: update with Schedulers
3770 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3771 method specifically for use by HTML "force build" button and the
3772 IRC "force" command. Raises an immediate error if there are no
3774 (IBuilderControl.requestBuild): make this just submit a build, not
3775 try to check for existing slaves or set up any when-finished
3776 Deferreds or anything.
3777 * buildbot/process/builder.py (BuilderControl): same
3778 * buildbot/status/html.py (StatusResourceBuilder.force): same
3779 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3780 * buildbot/test/test_slaves.py: same
3781 * buildbot/test/test_web.py: same
3783 2005-10-19 Brian Warner <warner@lothar.com>
3785 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3786 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3788 2005-10-18 Brian Warner <warner@lothar.com>
3790 * buildbot/status/html.py: provide 'status' argument to most
3791 StatusResourceFOO objects
3792 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3793 and Logfiles" section to make the Build page into a more-or-less
3794 comprehensive source of status information about the build
3796 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3797 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3799 2005-10-17 Brian Warner <warner@lothar.com>
3801 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3802 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3803 out what to do about other projects: the correct options for
3804 recent Twisteds will not work for older ones.
3806 2005-10-15 Brian Warner <warner@lothar.com>
3808 * buildbot/status/builder.py (Status.getURLForThing): add method
3809 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3810 use this in email/IRC status clients to make them more useful, by
3811 providing the end user with hints on where to learn more about the
3812 object being reported on.
3813 * buildbot/test/test_web.py (GetURL): tests for it
3815 2005-10-14 Brian Warner <warner@lothar.com>
3817 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3818 fix bug resulting from deferredResult changes
3820 2005-10-13 Brian Warner <warner@lothar.com>
3822 * buildbot/test/test_changes.py: remove use of deferredResult
3823 * buildbot/test/test_config.py: same
3824 * buildbot/test/test_control.py: same
3825 * buildbot/test/test_status.py: same
3826 * buildbot/test/test_vc.py: this is the only remaining use, since
3827 it gets used at module level. This needs to be replaced by some
3828 sort of class-level run-once routine.
3830 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3832 * lots: implement multiple slaves per Builder, which means multiple
3833 current builds per Builder. Some highlights:
3834 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3835 of (state,currentBuilds) instead of (state,currentBuild)
3836 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3837 (IBuildStatus.getSlavename): new method, so you can tell which
3838 slave got used. This only gets set when the build completes.
3839 (IBuildRequestStatus.getBuilds): new method
3841 * buildbot/process/builder.py (SlaveBuilder): add a .state
3842 attribute to track things like ATTACHING and IDLE and BUILDING,
3844 (Builder): .. the .slaves attribute here, which has been turned
3845 into a simple list of available slaves. Added a separate
3846 attaching_slaves list to track ones that are not yet ready for
3848 (Builder.fireTestEvent): put off the test-event callback for a
3849 reactor turn, to make tests a bit more consistent.
3850 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3851 ping fails due to an exception. This needs work, I'm worried that
3852 a code error could lead to a constantly re-connecting slave.
3853 Especially since I'm trying to move to a distinct remote_ping
3854 method, separate from the remote_print that we currently use.
3855 (BuilderControl.requestBuild): return a convenience Deferred that
3856 provides an IBuildStatus when the build finishes.
3857 (BuilderControl.ping): ping all connected slaves, only return True
3858 if they all respond.
3860 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3861 reconnect when we shut down.
3863 * buildbot/status/builder.py: implement new methods, convert
3864 one-build-at-a-time methods to handle multiple builds
3865 * buildbot/status/*.py: do the same in all default status targets
3866 * buildbot/status/html.py: report the build's slavename in the
3867 per-Build page, report all buildslaves on the per-Builder page
3869 * buildbot/test/test_run.py: update/create tests
3870 * buildbot/test/test_slaves.py: same
3871 * buildbot/test/test_scheduler.py: remove stale test
3873 * docs/buildbot.texinfo: document the new builder-specification
3874 'slavenames' parameter
3876 2005-10-12 Brian Warner <warner@lothar.com>
3878 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3879 report failure correctly, causing Dependent builds to run when
3880 they shouldn't have.
3881 * buildbot/status/builder.py (BuildSetStatus): same
3882 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3883 (Set.testSuccess): test the both-pass case too
3884 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3885 fix this test: it was ending too early, masking the failure before
3886 (Logger): specialized StatusReceiver to make sure the dependent
3887 builds aren't even started, much less completed.
3889 2005-10-07 Brian Warner <warner@lothar.com>
3891 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3892 bot.SlaveBuilder being disowned in the middle of a build
3894 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3895 this inherit from StatusReceiver. Also upcall in __init__. This
3896 fixes the embarrasing crash when the new buildSetSubmitted method
3897 is invoked and Waterfall/etc don't implement their own.
3898 * buildbot/test/test_run.py: add a TODO note about a test to catch
3899 just this sort of thing.
3901 * buildbot/process/builder.py (Builder.attached): remove the
3902 already-attached warning, this situation is normal. Add some
3903 comments explaining it.
3905 2005-10-02 Brian Warner <warner@lothar.com>
3907 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3908 OverflowError when setting up dnotify, because some 64-bit systems
3909 have problems with signed-vs-unsigned constants and trip up on the
3910 DN_MULTISHOT flag. Patch from Brad Hards.
3912 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3914 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3915 progressMetrics, description, descriptionDone to the 'parms' list,
3916 and make use the 'parms' list from the implementation class
3917 instead of only BuildStep to initialize the parameters. This
3918 allows buildbot.process.factory.s() to initialize all the parms,
3919 not just those defined in directly by BuildStep.
3921 2005-09-03 Brian Warner <warner@lothar.com>
3923 * NEWS: start adding items for the next release
3925 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3926 python2.2 tests, change 'Quick' builder to only use python2.3
3928 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3930 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3931 the "Ping Builder" button if the build control is available; the
3932 user sees an exception otherwise
3934 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3936 2005-09-01 Brian Warner <warner@lothar.com>
3938 * buildbot/interfaces.py (IBuilderStatus.getState): update
3939 signature, point out that 'build' can be None
3940 (IBuildStatus.getETA): point out ETA can be none
3942 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3944 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3946 2005-08-31 Brian Warner <warner@lothar.com>
3948 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3949 update to match correct signature: removed 'eta' argument
3950 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3952 2005-08-30 Brian Warner <warner@lothar.com>
3954 * buildbot/status/builder.py (LogFile): remove the assertion that
3955 blows up when you try to overwrite an existing logfile, instead
3956 just emit a warning. This case gets hit when the buildmaster is
3957 killed and doesn't get a chance to write out the serialized
3958 BuilderStatus object, so the .nextBuildNumber attribute gets out
3961 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3962 the 'buildbot sendchange' arguments, for the Darcs context file
3963 * docs/buildbot.texinfo (sendchange): document it
3965 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3966 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3967 (IStatus.getSchedulers): new method
3968 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3969 (Status.getSchedulers): implement
3970 * buildbot/process/builder.py (Builder): maintain
3971 BuilderStatus.pendingBuilds
3972 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3973 (TryBase.addChange): Try schedulers should ignore Changes
3975 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3976 for 'try' on CVS/SVN
3977 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3979 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3980 report status properly.
3981 (Try.createJob): implement unique buildset IDs
3983 * buildbot/status/client.py (StatusClientPerspective): add a
3984 perspective_getBuildSets method for the benefit of jobdir-style
3986 * docs/buildbot.texinfo (try): more docs
3987 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3990 2005-08-18 Brian Warner <warner@lothar.com>
3992 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3993 actually work. It's functional but still kind of clunky. Also, it
3994 only works with the pb-style.. needs to be made to work with the
3997 * buildbot/status/client.py (RemoteBuildSet): new class
3998 (RemoteBuildRequest): same
3999 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
4000 object, not the internal BuildStatus object.
4001 (RemoteBuild.remote_subscribe): new method to subscribe to builds
4002 outside of the usual buildStarted() return value.
4003 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
4005 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
4006 (Try_Userpass_Perspective.perspective_try): return a remotely
4007 usable BuildSetStatus object
4009 * buildbot/interfaces.py (IBuildStatus): remove obsolete
4010 isStarted()/waitUntilStarted()
4012 2005-08-16 Brian Warner <warner@lothar.com>
4014 * buildbot/status/builder.py: implement IBuildSetStatus and
4015 IBuildRequestStatus, wire them into place.
4016 * buildbot/buildset.py: same. Add ID, move wait-until-finished
4017 methods into the BuildSetStatus object.
4018 * buildbot/interfaces.py: same
4019 (IStatus.getBuildSets): new method to get pending BuildSets
4020 (IStatusReceiver.buildsetSubmitted): new method which hears about
4022 * buildbot/master.py (BuildMaster.submitBuildSet): same
4023 * buildbot/process/base.py (BuildRequest): same, replace
4024 waitUntilStarted with subscribe/unsubscribe
4025 * buildbot/process/builder.py (BuilderControl.forceBuild): use
4026 subscribe instead of waitUntilStarted
4027 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
4029 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
4031 * buildbot/test/test_buildreq.py: update for new code
4032 * buildbot/test/test_control.py (Force.testRequest): same
4035 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
4036 for Darcs to not use the tempfile module, so it works under
4037 python-2.2 too. We really didn't need the full cleverness of that
4038 module, since the slave has exclusive control of its own builddir.
4040 2005-08-15 Brian Warner <warner@lothar.com>
4042 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
4043 for CVS trees. It doesn't work for non-trunk branches,
4045 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
4048 * Makefile: make it easier to test against python2.2
4050 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
4051 tearDown2, so things like Arch can unregister archives as they're
4052 shutting down. The previous subclass-override-tearDown technique
4053 resulted in a nested maybeWait() and test failures under
4056 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
4057 where we can (Arch), add a branch= argument to set the branch used
4059 (BazExtractor): extract the branch too
4060 (TlaExtractor): same
4061 * buildbot/scripts/runner.py (TryOptions): add --branch
4062 * docs/buildbot.texinfo (try): document --branch/try_branch
4064 * buildbot/slave/commands.py (Darcs): implement get-revision for
4065 Darcs, so that 'try' will work. This requires the tempfile module
4068 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
4069 of revisions, branches, and 'try' in the process.
4071 2005-08-11 Brian Warner <warner@lothar.com>
4073 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
4074 this, it got broken at some point in the last few releases
4075 * buildbot/status/words.py (IrcBuildRequest): reply was broken
4076 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
4077 specifically the removal of ETA information from the tuple
4079 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
4082 * docs/buildbot.texinfo (try): document both --builder and
4083 'try_builders' in .buildbot/options
4084 * buildbot/scripts/runner.py (TryOptions): add --builder,
4085 accumulate the values into opts['builders']
4086 * buildbot/scripts/tryclient.py (Try.__init__): set builders
4087 * buildbot/test/test_runner.py (Try): add some quick tests to make
4088 sure 'buildbot try --options' and .buildbot/options get parsed
4089 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
4090 use --builder control
4092 * docs/buildbot.texinfo (try): add --port argument to PB style
4094 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
4095 actual SourceStamp. Still need to extract a branch name, somehow.
4096 (Try): finish implementing the try client side, still need a UI
4097 for specifying which builders to use
4098 (Try.getopt): factor our options/config-file reading
4099 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
4101 * buildbot/test/test_vc.py: match SourceStampExtractor change
4103 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
4104 causes the twisted log to be sent to stderr
4106 * buildbot/scheduler.py (Try_Userpass): implement the PB style
4108 2005-08-10 Brian Warner <warner@lothar.com>
4110 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
4111 style is 90% done, still missing status reporting or waiting for
4112 the buildsets to finish, and it is completely untested.
4114 * buildbot/trybuild.py: delete file, move contents to ..
4115 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
4116 * buildbot/test/test_vc.py: match the move
4118 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
4119 of the TryScheduler, no buildsetID or status-tracking support yet
4120 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
4122 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
4123 possible to set the basedir after __init__ time, so it is easier
4124 to use as a Service-child of the BuildMaster instance
4126 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
4127 that delivers messages to its Service parent instead of requiring
4128 a subclass to be useful. This turns out to be much easier to build
4131 * buildbot/scripts/tryclient.py (createJob): utility code to
4132 create jobfiles, will eventually be used by 'buildbot try'
4134 2005-08-08 Brian Warner <warner@lothar.com>
4136 * docs/buildbot.texinfo (try): add docs on the
4137 as-yet-unimplemented Try scheduler
4139 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
4140 * buildbot/test/test_scheduler.py: .. here
4141 (Scheduling.testTryJobdir): add placeholder test for 'try'
4143 * buildbot/test/test_status.py (Log.testMerge3): update to match new
4144 addEntry merging (>=chunkSize) behavior
4145 (Log.testConsumer): update to handle new callLater(0) behavior
4147 * buildbot/test/test_web.py: rearrange tests a bit, add test for
4148 both the MAX_LENGTH bugfix and the resumeProducing hang.
4150 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
4151 put off the actual resumeProducing for a moment with
4152 reactor.callLater(0). This works around a twisted-1.3.0 bug which
4153 causes large logfiles to hang midway through.
4155 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
4156 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
4157 and to improve memory usage when streaming the file out to a web
4159 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
4160 make this work cleanly
4162 2005-08-03 Brian Warner <warner@lothar.com>
4164 * buildbot/trybuild.py: new file for 'try' utilities
4165 (getSourceStamp): run in a tree, find out the baserev+patch
4166 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
4167 implemented for SVN and Darcs, still working on Arch. I don't know
4168 how to make CVS work yet.
4170 * docs/buildbot.texinfo: document the 'buildbot' command-line
4171 tool, including the not-yet-implemented 'try' feature, and the
4172 in-flux .buildbot/ options directory.
4174 2005-07-20 Brian Warner <warner@lothar.com>
4176 * buildbot/locks.py: added temporary id() numbers to Lock
4177 descriptions, to track down a not-really-sharing-the-Lock bug
4179 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
4181 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
4182 needed for python2.2 compatibility
4183 * buildbot/test/test_vc.py: python2.2 compatibility: generators
4184 are from the __future__
4186 2005-07-19 Brian Warner <warner@lothar.com>
4188 * buildbot/master.py (BuildMaster.loadConfig): give a better error
4189 message when schedulers use unknown builders
4191 * buildbot/process/builder.py (Builder.compareToSetup): make sure
4192 SlaveLock('name') and MasterLock('name') are distinct
4194 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
4195 c['schedulers'] in such a way that we can actually accept
4197 * buildbot/test/test_config.py: check it
4199 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
4200 utility method to *all* the Schedulers
4201 (Periodic.listBuilderNames): same
4203 * docs/buildbot.texinfo (Interlocks): update chapter to match
4206 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
4207 to make sure that c['sources'], c['schedulers'], and c['status']
4208 are all lists of the appropriate objects, and that the Schedulers
4209 all point to real Builders
4210 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
4211 'listBuilderNames' utility method to support this
4212 * buildbot/scheduler.py: implement the utility method
4213 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
4215 * docs/buildbot.texinfo: add some @cindex entries
4217 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
4218 if it wasn't already set: most tla commands will fail unless one
4220 (Arch.createRepository): and disable bazaar's revision cache, since
4221 they cause test failures (the multiple repositories we create all
4222 interfere with each other through the cache)
4224 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
4225 bring it properly up to date with twisted-2.0 test guidelines
4227 * buildbot/master.py (BuildMaster): remove references to old
4228 'interlock' module, this caused a bunch of post-merge test
4230 * buildbot/test/test_config.py: same
4231 * buildbot/process/base.py (Build): same
4233 * buildbot/test/test_slaves.py: stubs for new test case
4235 * buildbot/scheduler.py: add test-case-name tag
4236 * buildbot/test/test_buildreq.py: same
4238 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
4239 unnecessary init code
4240 (Bot.remote_setBuilderList): match it
4242 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
4244 * buildbot/changes/mail.py (parseSyncmail): update comment
4246 * buildbot/test/test_slavecommand.py: disable Shell tests on
4247 platforms that don't suport IReactorProcess
4249 * buildbot/status/builder.py (LogFile): remove the 't' mode from
4250 all places where we open logfiles. It causes OS-X to open the file
4251 in some weird mode that that prevents us from mixing reads and
4252 writes to the same filehandle, which we depend upon to implement
4253 _generateChunks properly. This change doesn't appear to break
4254 win32, on which "b" and "t" are treated differently but a missing
4255 flag seems to be interpreted as "t".
4257 2005-07-18 Brian Warner <warner@lothar.com>
4259 * buildbot/slave/commands.py (ShellCommand): overhaul
4260 error-handling code, to try and make timeout/interrupt work
4261 properly, and make win32 happier
4262 * buildbot/test/test_slavecommand.py: clean up, stop using
4263 reactor.iterate, add tests for timeout and interrupt
4264 * buildbot/test/sleep.py: utility for a new timeout test
4266 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
4267 code from the local-usebranches branch
4269 2005-07-17 Brian Warner <warner@lothar.com>
4271 * buildbot/process/process_twisted.py
4272 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
4273 minutes, to match the other twisted BuildFactories, and don't
4274 excuse failures in c/qt/win32 reactors any more.
4276 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
4277 'freebsd' builders, since the buildslaves have been unavailable
4280 2005-07-13 Brian Warner <warner@lothar.com>
4282 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
4283 build-on-branch feature
4285 * buildbot/process/step.py (Darcs.__init__): add base_url and
4286 default_branch arguments, just like SVN
4287 (Arch.__init__): note that the version= argument is really the
4290 * buildbot/slave/commands.py (SourceBase): keep track of the
4291 repository+branch that was used for the last checkout in
4292 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
4293 match, we clobber the directory and perform a fresh checkout
4294 rather than trying to do an in-place update. This should protect
4295 us against trying to get to branch B by doing an update in a tree
4296 obtained from branch A.
4297 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
4298 (SVN.setup): same, just the svnurl
4299 (Darcs.setup): same, just the repourl
4300 (Arch.setup): same, arch coordinates (url), version, and
4301 buildconfig. Also pull the buildconfig from the args dictionary,
4302 which we weren't doing before, so the build-config was effectively
4304 (Arch.sourcedirIsUpdateable): don't try to update when we're
4305 moving to a specific revision: arch can't go backwards, so it is
4306 safer to just clobber the tree and checkout a new one at the
4308 (Bazaar.setup): same sourcedata as Arch
4310 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
4311 use maybeWait, to work with twisted-1.3.0 and twcompat
4312 (Dependencies.testRun_Pass): same
4314 * buildbot/test/test_vc.py: rearrange, cleanup
4316 * buildbot/twcompat.py: add defer.waitForDeferred and
4317 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
4318 can work under twisted-1.3.0 .
4320 * buildbot/test/test_vc.py: rewrite. The sample repositories are
4321 now created at setUp time. This increases the runtime of the test
4322 suite considerably (from 91 seconds to 151), but it removes the
4323 need for an offline tarball, which should solve a problem I've
4324 seen where the test host has a different version of svn than the
4325 tarball build host. The new code also validates that mode=update
4326 really picks up recent commits. This approach will also make it
4327 easier to test out branches, because the code which creates the VC
4328 branches is next to the code which uses them. It will also make it
4329 possible to test some change-notification hooks, by actually
4330 performing a VC commit and watching to see the ChangeSource get
4333 2005-07-12 Brian Warner <warner@lothar.com>
4335 * docs/buildbot.texinfo (SVN): add branches example
4336 * docs/Makefile (buildbot.ps): add target for postscript manual
4338 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
4339 * buildbot/test/test_locks.py: same
4341 * buildbot/process/step.py (Darcs): comment about default branches
4343 * buildbot/master.py (BuildMaster.loadConfig): don't look for
4344 c['interlocks'] in the config file, complain if it is present.
4345 Scan all locks in c['builders'] to make sure the Locks they use
4347 * buildbot/test/test_config.py: remove old c['interlocks'] test,
4348 add some tests to check for non-uniquely-named Locks
4349 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
4350 since the unique-Lock validation code requires it now
4352 * buildbot/locks.py: fix test-case-name
4354 * buildbot/interlock.py: remove old file
4356 2005-07-11 Brian Warner <warner@lothar.com>
4358 * buildbot/test/test_interlock.py: rename to..
4359 * buildbot/test/test_locks.py: .. something shorter
4361 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
4362 versions (after 2.0.1) changed internet.TCPClient to shut down the
4363 connection in stopService. Change the code to handle this
4366 * buildbot/process/base.py (Build): handle whole-Build locks
4367 * buildbot/process/builder.py (Builder.compareToSetup): same
4368 * buildbot/test/test_interlock.py: make tests work
4370 * buildbot/process/step.py (BuildStep.startStep): complain if a
4371 Step tries to claim a lock that's owned by its own Build
4372 (BuildStep.releaseLocks): typo
4374 * buildbot/locks.py (MasterLock): use ComparableMixin so config
4375 file reloads don't replace unchanged Builders
4377 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
4378 rewrite to cover new Locks instead of old c['interlocks']
4379 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
4383 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
4384 start the master and connect the buildslave
4386 * buildbot/process/step.py (FailingDummy.done): finish with a
4387 FAILURE status rather than raising an exception
4389 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
4390 stringify a BuildRequest.reason that is None
4392 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
4394 * buildbot/status/builder.py (BuildSetStatus): implement enough to
4395 allow scheduler.Dependent to work
4396 * buildbot/buildset.py (BuildSet): set .reason and .results
4398 * buildbot/test/test_interlock.py (Locks.setUp): connect both
4399 slaves, to make the test stop hanging. It still fails, of course,
4400 because I haven't even started to implement Locks.
4402 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
4404 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
4405 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
4406 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
4407 (Dependent): new class for downstream build dependencies
4408 * buildbot/test/test_dependencies.py: tests (still failing)
4410 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
4412 2005-07-07 Brian Warner <warner@lothar.com>
4414 * buildbot/test/runutils.py (RunMixin): factored this class out..
4415 * buildbot/test/test_run.py: .. from here
4416 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
4417 added new buildbot.locks tests (which all hang right now)
4418 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
4419 * buildbot/process/step.py: claim/release per-BuildStep locks
4421 * docs/Makefile: add 'buildbot.html' target
4423 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
4424 interpreted as "HEAD", so that all VC steps can accept branch=None
4425 and have it mean the "default branch".
4427 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
4429 2005-07-07 Brian Warner <warner@lothar.com>
4431 * docs/examples/twisted_master.cfg: update to match current usage
4433 * docs/buildbot.texinfo (System Architecture): comment out the
4434 image, it doesn't exist yet and just screws up the HTML manual.
4436 2005-07-05 Brian Warner <warner@lothar.com>
4438 * debian/.cvsignore: oops, missed one. Removing leftover file.
4440 2005-06-17 Brian Warner <warner@lothar.com>
4442 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
4443 changed its output in 1.2.0, don't mistakenly think that the
4444 subversion we find isn't capable of supporting our tests.
4446 * debian/*: remove the debian/ directory and its contents, to make
4447 life easier for the proper Debian maintainer
4449 * Makefile (release): same
4451 2005-06-07 Brian Warner <warner@lothar.com>
4453 * everything: create a distinct SourceStamp class to replace the
4454 ungainly 4-tuple, let it handle merging instead of BuildRequest.
4455 Changed the signature of Source.startVC to include the revision
4456 information (instead of passing it through self.args). Implement
4457 branches for SVN (now only Darcs/Git is missing support). Add more
4460 2005-06-06 Brian Warner <warner@lothar.com>
4462 * everything: rearrange build scheduling. Create a new Scheduler
4463 object (configured in c['schedulers'], which submit BuildSets to a
4464 set of Builders. Builders can now use multiple slaves. Builds can
4465 be run on alternate branches, either requested manually or driven
4466 by changes. This changed some of the Status classes. Interlocks
4467 are out of service until they've been properly split into Locks
4468 and Dependencies. treeStableTimer, isFileImportant, and
4469 periodicBuild have all been moved from the Builder to the
4471 (BuilderStatus.currentBigState): removed the 'waiting' and
4472 'interlocked' states, removed the 'ETA' argument.
4474 2005-05-24 Brian Warner <warner@lothar.com>
4476 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
4477 erroneously abandons the connection (in clientConnectionFailed)
4478 for non-UserErrors, which means that if we lose the connection due
4479 to a network problem or a timeout, we'll never try to reconnect.
4480 Fix this by not upcalling to the buggy parent method. Note:
4481 twisted-2.0 fixes this, but the function only has 3 lines so it
4482 makes more sense to copy it than to try and detect the buggyness
4483 of the parent class. Fixes SF#1207588.
4485 * buildbot/changes/changes.py (Change.branch): doh! Add a
4486 class-level attribute to accomodate old Change instances that were
4487 pickled before 0.6.5 (where .branch was added for new Changes).
4488 This fixes the exception that occurs when you try to look at an
4489 old Change (through asHTML).
4491 * buildbot/__init__.py (version): bump to 0.6.6+ while between
4494 2005-05-23 Brian Warner <warner@lothar.com>
4496 * buildbot/__init__.py (version): release 0.6.6
4498 2005-05-23 Brian Warner <warner@lothar.com>
4500 * NEWS: update for 0.6.6 release
4501 * debian/changelog: same
4503 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4504 before starting: this was done by twistd back when we spawned it,
4505 now that we're importing the pieces and running them in the
4506 current process, we have to do it ourselves. This allows
4507 master.cfg to import files from the same directory without
4508 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4509 Stichele for the catch.
4510 (Options.opt_version): Add a --version command (actually, just make
4511 the existing --version command emit Buildbot's version too)
4513 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4514 fix to make this behave like other LogFiles, this time to handle
4515 existing LogFiles on disk. (add the missing .upgrade method)
4516 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4518 2005-05-21 Brian Warner <warner@lothar.com>
4520 * buildbot/test/test_runner.py (Create.testMaster): match the
4521 rawstring change in runner.py:masterTAC
4523 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4524 TwistedWords is installed
4525 * buildbot/test/test_status.py: same, with TwistedMail
4527 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4528 some old, deprecated, and removed config keys). This should enable
4529 you to use the base buildbot functionality with Twisted-2.0.0 when
4530 you don't also have TwistedWeb and TwistedWords installed
4532 2005-05-20 Brian Warner <warner@lothar.com>
4534 * buildbot/scripts/runner.py (run): call sendchange(), not
4535 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4536 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4537 (stop): don't wait for process to die when sending SIGHUP
4538 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4539 directory name gets interpreted, which you don't want
4542 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4545 2005-05-18 Brian Warner <warner@lothar.com>
4547 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4549 2005-05-18 Brian Warner <warner@lothar.com>
4551 * README: update for 0.6.5
4552 * debian/changelog: same
4554 * buildbot/changes/changes.py: rename tag= to branch=, since
4555 that's how we're using it, and my design for the upcoming "build a
4556 specific branch" feature wants it. also, tag= was too CVS-centric
4557 * buildbot/changes/mail.py (parseSyncmail): same
4558 * buildbot/process/base.py (Build.isBranchImportant): same
4559 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4560 * docs/buildbot.texinfo (Attributes of Changes): same
4562 * NEWS: update tag=, update for upcoming release
4564 2005-05-17 Brian Warner <warner@lothar.com>
4566 * buildbot/scripts/runner.py (stop): actually poll once per
4567 second, instead of re-killing the poor daemon once per second.
4568 Sleep briefly (0.1s) before the first poll, since there's a good
4569 chance we can avoid waiting the full second if the daemon shuts
4570 down quickly. Also remove the sys.exit() at the end.
4571 (start): remove the unneighborly sys.exit()
4573 * Makefile: improve permission-setting to not kick Arch so badly
4575 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4576 default --keepalive=600, since it doesn't hurt very much, and it's
4577 a hassle to discover that you need it.
4578 * buildbot/test/test_runner.py (Create.testSlave): test it
4580 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4581 IRC bot about EXCEPTION
4583 * buildbot/status/client.py (PBListener): upcall more correctly
4585 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4586 an exception mark the overall build with EXCEPTION, not SUCCESS
4588 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4590 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4591 * Makefile: update some release-related stuff
4593 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4594 gets called when there isn't actually an active process, just end
4595 the Command instead of blowing up. I don't know how it gets into
4596 this state, but the twisted win32 buildslave will sometimes hang,
4597 and when it shakes its head and comes back, it thinks it's still
4598 running a Command. The next build causes this command to be
4599 interrupted, but the lack of self.process.pid breaks the interrupt
4602 * NEWS: document changes since the last release
4604 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4605 look for Makefile.buildbot instead of a bare Makefile . The
4606 'buildbot start' does not install this file, so you have to
4607 manually copy it if you want to customize startup behavior.
4608 (createMaster): change 'buildbot master' command to create
4609 Makefile.sample instead of Makefile, to create master.cfg.sample
4610 instead of master.cfg (requiring you to copy it before the
4611 buildmaster can be started). Both sample files are kept up to
4612 date, i.e. they are overwritten if they have been changed. The
4613 'buildbot.tac' file is *not* overwritten, but if the new contents
4614 don't match the old, a 'buildbot.tac.new' file is created and the
4615 user is warned. This seems to be a much more sane way to handle
4616 startup files. Also, don't sys.exit(0) when done, so we can run
4617 unit tests against it.
4618 (createSlave): same. Don't overwrite the sample info/ files.
4619 * buildbot/scripts/sample.mk: remove. the contents were pulled
4620 into runner.py, since they need to match the behavior of start()
4624 * docs/buildbot.texinfo (Launching the daemons): document it
4625 * buildbot/test/test_runner.py (Create): test it
4627 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4628 version that can handle string-in-string tests, because otherwise
4629 python-2.2 fails the tests. It'd be tremendous if Trial's test
4630 took two strings under 2.2 too.
4632 * everything: fixed all deprecation warnings when running against
4633 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4634 few that come from Twisted itself). This involved putting most of
4635 the Twisted-version specific code in the new buildbot.twcompat
4636 module, and creating some abstract base classes in
4637 buildbot.changes.base and buildbot.status.base (which might be
4638 useful anyway). __implements__ is a nuisance and requires an ugly
4639 'if' clause everywhere.
4641 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4642 delay before finishing the test: it seems that smtp.sendmail
4643 doesn't hang up on the server, so we must wait a moment so it can
4644 hang up on us. This removes the trial warning about an unclean
4647 2005-05-16 Brian Warner <warner@lothar.com>
4649 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4650 tuple of (delay, repeats).
4651 * buildbot/test/test_vc.py (Retry): test it
4652 * docs/buildbot.texinfo (Source Checkout): document it
4653 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4654 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4655 doVCFull() are handled by re-trying the checkout (after a delay)
4656 some number of times.
4657 (ShellCommand._startCommand): make header lines easier to read
4659 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4661 (WebTest.test_logfile): make sure master gets shut down, silences
4662 some "unclean reactor" test errors
4664 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4665 reactor once after shutdown, something in certain versions of
4666 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4667 fails, svn-trunk is ok.
4669 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4670 second win32 error message
4672 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4673 validating the ETA, so the tests don't fail on slow systems
4675 2005-05-15 Brian Warner <warner@lothar.com>
4677 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4678 the new LogFile class, so upgrading works properly
4679 (LogFileProducer.resumeProducing): survive resumeProducing after
4680 we've exhausted the chunkGenerator
4682 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4684 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4685 (Log.testUpgrade): same
4687 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4688 Builds and logs with a cron job.
4690 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4691 of the old non-offline LogFile, added code to upgrade these to
4692 new-style contents-live-on-disk instances at load time (in a way
4693 that doesn't invalidate the old Build pickles, so upgrading to
4694 0.6.5 is not a one-way operation). Got rid of everything related
4696 (LogFile.__init__): create LogFiles with the parent step status,
4697 the log's name, and a builder-relative filename where it can keep
4698 the contents on disk.
4699 (LogFile.hasContents): new method, clients are advised to call it
4700 before getText or getChunks and friends. If it returns False, the
4701 log's contents have been deleted and getText() will raise an
4703 (LogFile.getChunks): made it a generator
4704 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4705 Consumer (except one that takes chunks instead of strings). This
4706 enables streaming of very large logfiles without storing the whole
4708 (BuildStatus.generateLogfileName): create names like
4709 12-log-compile-output, with a _0 suffix if required to be unique
4710 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4711 or earlier) logfiles into new-style ones
4712 (BuilderStatus): remove everything related to 'stub' builds. There
4713 is now only one build cache, and we don't strip logs from old
4715 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4716 since we no longer fight to keep it in the cache
4718 * buildbot/status/html.py (TextLog.render_GET): use a
4719 ChunkConsumer to stream the log entries efficiently.
4720 (ChunkConsumer): wrapper which consumes chunks and writes
4723 * buildbot/test/test_twisted.py (Parse.testParse): use a
4724 LogFile-like object instead of a real one
4726 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4727 (Log.testMerge3): validate more merge behavior
4728 (Log.testChunks): validate LogFile.getChunks
4729 (Log.testUpgrade): validate old-style LogFile upgrading
4730 (Log.testSubscribe): validate LogFile.subscribe
4731 (Log.testConsumer): validate LogFile.subscribeConsumer
4733 * buildbot/interfaces.py (IStatusLogStub): remove
4734 (IStatusLog.subscribeConsumer): new method
4735 (IStatusLog.hasContents): new method
4736 (IStatusLogConsumer): describes things passed to subscribeConsumer
4738 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4739 the log contents if it does not have any contents.
4740 (StatusResourceBuildStep.body): same
4741 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4743 2005-05-14 Brian Warner <warner@lothar.com>
4745 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4746 timeouts to try and make the windows metabuildslave not hang
4748 2005-05-13 Mike Taylor <bear@code-bear.com>
4750 * buildbot/slave/commands.py (rmdirRecursive): added a check
4751 to ensure the path passed into rmdirRecursive actually exists.
4752 On win32 a non-existant path would generate an exception.
4754 2005-05-13 Brian Warner <warner@lothar.com>
4756 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4757 shutil.rmtree which behaves correctly on windows in the face of
4758 files that you have to chmod before deleting. Thanks to Bear at
4759 the OSAF for the routine.
4760 (SourceBase.doClobber): use rmdirRecursive
4762 2005-05-12 Brian Warner <warner@lothar.com>
4764 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4765 method generate chunks instead of returning a big list. This
4766 allows the same method to be used for both old LogFile and new
4768 (OfflineLogFile.getText): use the generator
4769 (OfflineLogFile.subscribe): same
4770 * buildbot/status/html.py (TextLog.resumeProducing): same
4771 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4773 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4774 point out that OfflineLogFile does not currently work with
4775 html.Waterfall . Fixing this is high-priority.
4777 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4778 apparently windows defaults to using stdout
4780 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4781 better message on failure so I can figure out the win32 problem
4783 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4784 log messages to include more useful copies of the command being
4785 run, the argv array, and the child command's environment.
4786 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4788 2005-05-11 Brian Warner <warner@lothar.com>
4790 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4792 * Makefile: update the deb-snapshot version
4794 * docs/buildbot.texinfo: move all .xhtml docs into a new
4795 .texinfo-format document, adding a lot of material in the process.
4796 This is starting to look like a real user's manual. Removed all
4797 the Lore-related files: *.xhtml, *.css, template.tpl .
4798 * docs/Makefile: simple makefile to run 'makeinfo'
4799 * buildbot/scripts/sample.cfg: rearrange slightly
4800 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4802 2005-05-10 Brian Warner <warner@lothar.com>
4804 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4805 different name for the internal twistw module, handle it.
4807 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4808 * setup.py: .. and stop trying to install it
4810 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4811 'git'), the new linux kernel VC system (http://kernel.org/git/).
4812 Thanks to Brandon Philips for the patch.
4813 * buildbot/slave/commands.py (Git): same
4815 2005-05-06 Brian Warner <warner@lothar.com>
4817 * buildbot/status/builder.py (OfflineLogFile): replace the default
4818 LogFile with a form that appends its new contents to a disk file
4819 as they arrive. The complete log data is never kept in RAM. This
4820 is the first step towards handling very large (100MB+) logfiles
4821 without choking quite so badly. (The other half is
4822 producer/consumer on the HTML pages).
4823 (BuildStepStatus.addLog): use OfflineLogFile by default
4824 (BuildStatus.getLogfileName): helper code to give the
4825 OfflineLogFile a filename to work with
4827 * buildbot/test/test_status.py (Results.testAddResults): update
4828 tests to handle new asserts
4829 * buildbot/test/test_vc.py (Patch.doPatch): same
4830 * buildbot/test/test_steps.py (BuildStep.setUp): same
4832 2005-05-05 Brian Warner <warner@lothar.com>
4834 * buildbot/scripts/runner.py (start): if there is no Makefile,
4835 launch the app by importing twistd's internals and calling run(),
4836 rather than spawning a new twistd process. This stands a much
4837 better chance of working under windows.
4838 (stop): kill the process with os.kill instead of spawning
4839 /bin/kill, again to reduce the number of external programs which
4840 windows might not have in the PATH. Also wait up to 5 seconds for
4841 the process to go away, allowing things like 'buildbot stop;
4842 buildbot start' to be reliable in the face of slow shutdowns.
4844 * buildbot/master.py (Dispatcher.__getstate__): remove old
4845 .tap-related methods
4846 (BuildMaster.__getstate__): same
4848 * buildbot/slave/bot.py (makeService): same
4849 (Options.longdesc): same
4850 * buildbot/scripts/runner.py: copy over some old mktap option text
4852 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4853 'buildbot master' now creates a buildbot.tac file, so there is no
4854 longer a create-instance/save/reload sequence. mktap is dead, long
4856 * buildbot/scripts/sample.mk: use twistd -y, not -f
4857 * buildbot/test/test_config.py: remove mktap-based test
4858 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4859 * README: don't reference mktap
4861 * docs/source.xhtml: document some of the attributes that Changes
4864 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4866 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4867 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4868 * buildbot/changes/changes.py (Change)
4869 * buildbot/changes/mail.py (parseSyncmail)
4870 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4872 * buildbot/process/base.py (Build.isTagImportant)
4876 2005-05-04 Brian Warner <warner@lothar.com>
4878 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4879 connection after sending the change, so that unit tests don't
4880 complain about sockets being left around
4882 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4883 exception in phase=0 rendering
4884 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4886 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4888 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4889 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4890 and configuring builders with tuples.
4891 * buildbot/test/test_config.py: stop testing compatibility with
4892 deprecated config keys
4893 * buildbot/test/test_run.py: same
4895 2005-05-03 Brian Warner <warner@lothar.com>
4897 * contrib/arch_buildbot.py: survive if there are no logfiles
4898 (username): just use a string, os.getlogin isn't reliable
4900 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4901 so 'buildbot sendchange' actually works. The earlier test only
4902 covered the internal (non-reactor-running) form.
4904 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4905 script to notify the buildmaster about changes
4907 * buildbot/scripts/runner.py (sendchange): new command to send a
4908 change to a buildbot.changes.pb.PBChangeSource receiver.
4909 * buildbot/test/test_changes.py (Sender): test it
4911 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4912 after any reading of the config file, not just when we do it in
4913 startService. This makes some tests a bit cleaner.
4915 * buildbot/changes/pb.py: add some log messages
4917 * buildbot/process/base.py (Build.startBuild): fix a bug that
4918 caused an exception when the build terminated in the very first
4920 (Build.stepDone): let steps return a status of EXCEPTION. This
4921 terminates the build right away, and sets the build's overall
4922 status to EXCEPTION too.
4923 * buildbot/process/step.py (BuildStep.failed): return a status of
4924 EXCEPTION when that is what has happened.
4926 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4927 implement this, allowing Arch-based projects to get precise
4928 checkouts instead of always using the latest code
4929 (Bazaar): create variant of Arch to let folks use baz instead of
4930 tla. Requires a new buildslave too.
4931 * buildbot/slave/commands.py (Arch): add 'revision' argument
4932 (Bazaar): create variant of Arch that uses baz instead of tla.
4933 Remove the code that extracts the archive name from the
4934 register-archive output, since baz doesn't provide it, and require
4935 the user provide both the archive name and its location.
4936 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4938 2005-05-02 Brian Warner <warner@lothar.com>
4940 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4941 thanks to Nick Trout.
4943 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4944 deals better with source Makefile coming from a read-only CVS
4945 checkout. Thanks to Nick Trout for the catch.
4947 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4950 2005-04-28 Brian Warner <warner@lothar.com>
4952 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4954 * debian/changelog: update for 0.6.4
4956 2005-04-28 Brian Warner <warner@lothar.com>
4958 * README.w32: add a checklist of steps for getting buildbot
4960 * MANIFEST.in: include it in the tarball
4964 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4965 broken .tap files from 0.6.3 by getting rid of .services,
4966 .namedServices, and .change_svc at load time.
4968 2005-04-27 Brian Warner <warner@lothar.com>
4970 * NEWS: update in preparation for new release
4972 * buildbot/test/test_config.py (Save.testSave): don't pull in
4973 twisted.scripts.twistd, we don't need it and it isn't for windows
4976 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4977 accomodate win32 which can't do atomic-rename
4979 2005-04-27 Brian Warner <warner@lothar.com>
4981 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4982 timeouts to help the slow metabuildbot not flunk them so much
4983 (Disconnect.testBuild3): same
4984 (Disconnect.testBuild4): same
4985 (Disconnect.testInterrupt): same
4987 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4988 setup, it was completely broken for new buildmasters (those which
4989 did not have a 'change.pck' already saved. Thanks to Paul Warren
4990 for catching this (embarrassing!) bug.
4991 (Dispatcher.__getstate__): don't save our registered avatar
4992 factories, since they'll be re-populated when the config file is
4994 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4995 tests (since the real mktap-generated BuildMaster doesn't save
4997 (BuildMaster.__getstate__): don't save any service children,
4998 they'll all be re-populated when the config file is re-read.
4999 * buildbot/test/test_config.py (Save.testSave): test for this
5001 2005-04-26 Brian Warner <warner@lothar.com>
5003 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
5004 rendered with Blender.. looks a bit nicer.
5005 * buildbot/docs/images/icon.blend: add the Blender file for it
5007 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
5008 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
5009 running under windows. This appears to be the best way to allow
5010 BuildSteps to do something normal like 'trial -v buildbot.test' or
5011 'make foo' and still expect it to work. The idea is to make the
5012 BuildSteps look as much like what a developer would type when
5013 compiling or testing the tree by hand. This approach probably has
5014 problems when there are spaces in the arguments, so if you've got
5015 windows buildslaves, you'll need to pay close attention to your
5018 * buildbot/status/html.py (WaterfallStatusResource.body): add the
5019 timezone to the timestamp column.
5020 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5022 * buildbot/scripts/runner.py (loadOptions): do something sane for
5023 windows, I think. We use %APPDATA%/buildbot instead of
5024 ~/.buildbot, but we still search everywhere from the current
5025 directory up to the root for a .buildbot/ subdir. The "is it under
5026 $HOME" security test was replaced with "is it owned by the current
5027 user", which is only performed under posix.
5028 * buildbot/test/test_runner.py (Options.testFindOptions): update
5029 tests to match. The "is it owned by the current user" check is
5030 untested. The test has been re-enabled for windows.
5032 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
5033 any "\n" in the expected output with the platform-specific line
5034 separator. Make this separator "\r\n" on PTYs under unix, they
5035 seem to do that and I don't know why
5037 * buildbot/test/test_runner.py (Options.optionsFile): disable on
5038 windows for now, I don't know what ~/.buildbot/ should mean there.
5040 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
5041 win32 compatibility, don't use "/tmp"
5042 (Basedir.testChangeBuilddir): remove more unixisms
5044 2005-04-26 Brian Warner <warner@lothar.com>
5046 * buildbot/test/test_control.py (Force.rmtree): python2.2
5047 compatibility, apparently its shutil.rmtree ignore_errors=
5048 argument is ignored.
5049 * buildbot/test/test_run.py (Run.rmtree): same
5050 (RunMixin.setUp): same
5052 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
5055 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
5056 'substring in string' operator, must use string.find(substr)!=-1
5057 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
5058 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
5060 * buildbot/scripts/runner.py (loadOptions): add code to search for
5061 ~/.buildbot/, a directory with things like 'options', containing
5062 defaults for various 'buildbot' subcommands. .buildbot/ can be in
5063 the current directory, your $HOME directory, or anywhere
5064 inbetween, as long as you're somewhere inside your home directory.
5065 (debugclient): look in ~/.buildbot/options for master and passwd
5066 (statuslog): look in ~/.buildbot/options for 'masterstatus'
5067 * buildbot/test/test_runner.py (Options.testFindOptions): test it
5069 * buildbot/status/client.py (makeRemote): new approach to making
5070 IRemote(None) be None, which works under Twisted-2.0
5071 * buildbot/test/test_status.py (Client.testAdaptation): test it
5073 * buildbot/status/builder.py (Status.builderAdded): when loading a
5074 pickled BuilderStatus in from disk, set its name after loading.
5075 The config file might have changed its name (but not its
5076 directory) while it wasn't looking.
5078 * buildbot/process/builder.py (Builder.attached): always return a
5079 Deferred, even if the builder was already attached
5080 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
5082 2005-04-25 Brian Warner <warner@lothar.com>
5084 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
5085 category-related exception when announcing a build has finished
5087 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
5088 reference no-longer-existent changemaster.sources
5089 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
5091 * buildbot/__init__.py (version): bump to 0.6.3+ while between
5094 2005-04-25 Brian Warner <warner@lothar.com>
5096 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
5098 * debian/changelog: update for 0.6.3
5100 2005-04-25 Brian Warner <warner@lothar.com>
5102 * MANIFEST.in: make sure debug.glade is in the tarball
5104 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
5106 * NEWS: update for the imminent 0.6.3 release
5108 * buildbot/status/html.py (HtmlResource.content): make the
5109 stylesheet <link> always point at "buildbot.css".
5110 (StatusResource.getChild): map "buildbot.css" to a static.File
5111 containing whatever css= argument was provided to Waterfall()
5112 (Waterfall): provide the "classic" css as the default.
5113 * docs/waterfall.classic.css: move default CSS from here ..
5114 * buildbot/status/classic.css: .. to here
5116 * MANIFEST.in: make sure classic.css is included in the tarball
5117 * setup.py: and that it is installed too, under buildbot/status/
5119 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
5120 the module level, because buildbot.tap files from 0.6.2 don't have
5121 it in their attribute dictionary.
5123 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
5124 really exists at startup, might save some confusion somewhere.
5126 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
5128 * docs/waterfall.classic.css:
5129 add a stylesheet that's almost the same as the "classic"
5132 * buildbot/status/builder.py:
5133 add EXCEPTION as a result - this is a problem for the bot
5134 maintainer, not a build problem for the changers
5135 * buildbot/process/step.py:
5136 use EXCEPTION instead of FAILURE for exceptions
5137 * buildbot/status/html.py:
5138 add build_get_class to get a class out of a build/buildstep
5139 finish naming the classes
5140 split out sourceNames to changeNames and builderNames so we
5141 can style them separately
5142 * docs/config.xhtml:
5143 finish documenting classes as they are right now
5145 * buildbot/status/html.py:
5146 name the classes as we agreed on IRC
5147 * docs/config.xhtml:
5150 * buildbot/status/html.py:
5151 same for cssclass->class_
5153 * buildbot/status/html.py:
5154 as decided on IRC, use class_ for the "class" attribute to not
5155 conflict with the class keyword, and clean up the messy **{} stuff.
5157 * buildbot/status/mail.py:
5158 put back "builders" argument, and fix docstring, because the
5159 code *ignores* builders listed in this argument
5161 * buildbot/process/builder.py:
5162 remove FIXME notes - category is now indeed a cvar of BuilderStatus
5164 * docs/config.xhtml:
5165 describe the category argument for builders
5167 * buildbot/status/builder.py:
5168 Fix a silly bug due to merging
5170 * buildbot/process/builder.py:
5171 remove category from the process Builder ...
5172 * buildbot/status/builder.py:
5173 ... and add it to BuilderStatus instead.
5174 Set category on unpickled builder statuses, they might not have it.
5175 * buildbot/master.py:
5176 include category when doing builderAdded
5177 * buildbot/status/mail.py:
5178 return None instead of self for builders we are not interested in.
5179 * buildbot/test/test_run.py:
5180 fix a bug due to only doing deferredResult on "dummy" waiting
5181 * buildbot/test/test_status.py:
5182 add checks for the Mail IStatusReceiver returning None or self
5184 * buildbot/status/html.py:
5185 fix testsuite by prefixing page title with BuildBot
5187 * buildbot/status/builder.py:
5188 have .category in builder status ...
5189 * buildbot/process/builder.py:
5190 ... and set it from Builder
5191 * buildbot/status/html.py:
5192 make .css a class variable
5193 * buildbot/test/test_status.py:
5194 write more tests to cover our categories stuff ...
5195 * buildbot/status/mail.py:
5196 ... and fix the bug that this uncovered
5198 * buildbot/changes/mail.py:
5199 * buildbot/changes/pb.py:
5200 * buildbot/master.py:
5201 * buildbot/process/base.py:
5202 * buildbot/process/factory.py:
5203 * buildbot/process/interlock.py:
5204 * buildbot/process/step.py:
5205 * buildbot/process/step_twisted.py:
5206 * buildbot/slave/commands.py:
5207 * buildbot/status/builder.py:
5208 * buildbot/status/client.py:
5209 * buildbot/status/html.py:
5210 * buildbot/status/mail.py:
5211 * buildbot/status/progress.py:
5212 * buildbot/test/test_changes.py:
5213 * buildbot/test/test_config.py:
5214 * buildbot/test/test_control.py:
5215 * buildbot/test/test_interlock.py:
5216 * buildbot/test/test_maildir.py:
5217 * buildbot/test/test_mailparse.py:
5218 * buildbot/test/test_run.py:
5219 * buildbot/test/test_slavecommand.py:
5220 * buildbot/test/test_status.py:
5221 * buildbot/test/test_steps.py:
5222 * buildbot/test/test_twisted.py:
5223 * buildbot/test/test_util.py:
5224 * buildbot/test/test_vc.py:
5225 * buildbot/test/test_web.py:
5227 add test-case-name at the top of a whole set of files
5229 * buildbot/status/builder.py:
5230 keep order of addition when getting builder names
5231 * buildbot/status/words.py:
5232 * buildbot/test/test_run.py:
5233 add test for getBuilderNames
5235 * buildbot/process/base.py:
5236 * buildbot/process/step.py:
5237 * buildbot/status/builder.py:
5238 * buildbot/status/html.py:
5239 make buildbot css-able
5240 replace the color code for purple with purple, don't understand
5241 why it wasn't purple to start with
5243 * buildbot/status/words.py:
5244 ok, so it doesn't look like BuilderStatus.remote is still valid.
5245 Use what waterfall uses instead.
5247 * buildbot/interfaces.py:
5248 * buildbot/status/builder.py:
5249 * buildbot/status/html.py:
5250 * buildbot/status/mail.py:
5251 * buildbot/status/words.py:
5252 * buildbot/test/test_run.py:
5253 use categories everywhere and make it be a list. More sensible
5254 for the future. Also make words actually respect this in
5257 * buildbot/interfaces.py:
5258 add category argument to getBuilderNames
5259 * buildbot/process/builder.py:
5260 * buildbot/status/builder.py:
5261 * buildbot/status/html.py:
5262 * buildbot/status/mail.py:
5263 * buildbot/status/words.py:
5264 * buildbot/test/test_run.py:
5265 move from specifying builders by name to specifying the category
5267 * buildbot/status/html.py:
5268 * buildbot/status/words.py:
5269 add "builders=" to __init__ of status clients so they can
5270 limit themselves to the given list of builders to report on
5272 * buildbot/status/html.py: set the title to the product name
5274 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
5276 * buildbot/interfaces.py:
5277 * buildbot/status/builder.py:
5278 more documentation. Hm, not sure if ChangeLog entries make sense
5281 2005-04-23 Brian Warner <warner@lothar.com>
5283 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
5285 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
5287 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
5288 the sub-commands that log buildmaster status to stdout and to a
5289 GUI window, respectively.
5291 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
5292 functionality is working again, but all the step-status and ETA
5293 stuff is missing. Commented out a lot of code pending more
5296 * buildbot/status/client.py: make sure that IRemote(None) is None
5298 * buildbot/changes/changes.py: import defer, oops
5299 (ChangeMaster): remove the .sources list, rely upon the fact that
5300 MultiServices can be treated as sequences of their children. This
5301 cleans up the add/remove ChangeSource routines a lot, as we keep
5302 exactly one list of the current sources instead of three.
5304 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
5305 up an empty ChangeMaster at init time.
5306 (BuildMaster.loadChanges): if there are changes to be had from
5307 disk, replace self.change_svc with the new ones. If not, keep
5308 using the empty ChangeMaster set up in __init__.
5309 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
5310 instead of a separate list, makes the code a bit cleaner.
5311 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
5312 (ConfigTest.testSources): same, also wait for loadConfig to finish.
5313 Extend the test to make sure we can get rid of the sources when
5316 2005-04-22 Brian Warner <warner@lothar.com>
5318 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
5319 and info/host files when making the slave directory
5321 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
5322 whendone= argument, just return the Deferred and let the caller do
5323 what they want with it.
5324 (Disconnect.testBuild1): wait for shutdownSlave
5325 (Basedir.testChangeBuilddir): new test to make sure changes to the
5326 builddir actually get propagated to the slave
5328 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
5329 explicit method, rather than passing the builddir in __init__ .
5330 Make sure to update self.basedir too, this was broken before.
5331 (Bot.remote_setBuilderList): use b.setBuilddir for both new
5332 builders and for ones that have just had their builddir changed.
5333 (BotFactory): add a class-level .perspective attribute, so
5334 BuildSlave.waitUntilDisconnected won't get upset when the
5335 connection hasn't yet been established
5336 (BuildSlave.__init__): keep track of the bot.Bot instance, so
5337 tests can reach through it to inspect the SlaveBuilders
5339 * buildbot/process/base.py (Build.buildException): explain the
5340 log.err with a log.msg
5341 * buildbot/process/builder.py (Builder.startBuild): same
5342 (Builder._startBuildFailed): improve error message
5344 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
5345 occurred because we lost the brand-new connection, retry instead
5346 of giving up. If not, it's probably an authorization failure, and
5347 it makes sense to stop trying. Make sure we log.msg the reason
5348 that we're log.err'ing the failure, otherwise test failures are
5349 really hard to figure out.
5351 * buildbot/master.py: change loadConfig() to return a Deferred
5352 that doesn't fire until the change has been fully implemented.
5353 This means any connected slaves have been updated with the new
5354 builddir. This change makes it easier to test the code which
5355 actually implements this builddir-updating.
5356 (BotPerspective.addBuilder): return Deferred
5357 (BotPerspective.removeBuilder): same
5358 (BotPerspective.attached): same
5359 (BotPerspective._attached): same. finish with remote_print before
5360 starting the getSlaveInfo, instead of doing them in parallel
5361 (BotPerspective.list_done): same
5362 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
5363 actually calling slave.disconnect()
5364 (BotMaster.addBuilder): same
5365 (BotMaster.removeBuilder): same
5366 (BuildMaster.loadConfig): same
5367 (BuildMaster.loadConfig_Slaves): same
5368 (BuildMaster.loadConfig_Sources): same
5369 (BuildMaster.loadConfig_Builders): same
5370 (BuildMaster.loadConfig_status): same
5372 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
5373 a Deferred that fires when the source is finally removed
5375 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
5376 the previous tree on win32, where we have to do it synchronously,
5377 make sure we return a Deferred anyway.
5378 (SourceBase.doCopy): same
5380 * buildbot/scripts/runner.py (statusgui): use the text client for
5381 now, while I rewrite the Gtk one
5382 * buildbot/clients/base.py: strip out old code, leaving just the
5383 basic print-message-on-event functionality. I also remove the
5384 ReconnectingPBClientFactory, but it does at least quit when it
5385 loses the connection instead of going silent
5387 2005-04-21 Brian Warner <warner@lothar.com>
5389 * Makefile: minor tweaks
5391 * NEWS: point out deprecation warnings, new features for
5394 * buildbot/master.py (BuildMaster.loadConfig): emit
5395 DeprecationWarnings for Builders defined with tuples. Rearrange
5396 code to facility removal of deprecated configuration keys in the
5399 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
5400 'buildbot' command to put a little Makefile in the target that
5401 helps you re-create the buildbot.tap file, start or stop the
5402 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
5403 all the files 0600, since they contain passwords.
5404 (start): if there is a Makefile, and /usr/bin/make exists, use
5405 'make start' in preference to a raw twistd command. This lets
5406 slave admins put things like PYTHONPATH variables in their
5407 Makefiles and have them still work when the slave is started with
5408 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
5409 be nice to first try the 'make' command and only fall back to
5410 twistd if it fails. TODO: the Makefile's "start" command does not
5411 add the --reactor=win32 argument when running under windows.
5412 (Options.debugclient, Options.statusgui): add sub-commands to launch
5413 the debug client (formerly in contrib/debugclient.py) and the
5414 Gtk status application (currently broken)
5415 * buildbot/clients/debug.py: move from contrib/debugclient.py
5416 * buildbot/clients/debug.glade: same
5418 * buildbot/test/test_trial.py: remove it. This requires some
5419 functionality out of Twisted that isn't there yet, and until then
5420 having it around just confuses things.
5422 * buildbot/test/test_slavecommand.py (Shell): test both with and
5423 without PTYs, and make sure that command output is properly
5424 interleaved in the with-PTY case. I think the without-PTY test
5425 should pass on windows, where we never use PTYs anyway.
5427 2005-04-20 Brian Warner <warner@lothar.com>
5429 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
5431 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
5433 * NEWS: start creating entries for the next release
5435 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
5437 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
5438 (WebTest.test_webPathname): same
5439 (WebTest.test_webPathname_port): same
5440 (WebTest.test_waterfall): use the default favicon rather than
5441 rooting around the filesystem for it. Open the expected-icon file
5442 in binary mode, to make win32 tests happier (thanks to Nick Trout
5444 * buildbot/status/html.py (buildbot_icon): win32 portability
5446 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
5447 win32-compatibility fixes from Nick Trout, the "file not found" message
5448 is different under windows
5449 (FakeSlaveBuilder.__init__): clean up setup a bit
5450 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
5452 2005-04-19 Brian Warner <warner@lothar.com>
5454 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
5455 skip-if-repositories-are-unavailable test to not kill the trial
5456 that comes with Twisted-1.3.0
5458 * setup.py: install buildbot.png icon file when installing code
5460 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
5461 environment used by the command, at least on the child side.
5463 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
5464 this method needs to be added and implemented because it gets
5465 called under heavy load. I don't quite understand the
5466 producer/consumer API enough to write it.
5467 (StatusResource.getChild): add a resource for /favicon.ico
5468 (Waterfall.__init__): add favicon= argument
5469 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5470 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
5471 (WebTest.test_webPathname): same
5472 (WebTest.test_webPathname_port): same
5473 * docs/config.xhtml: mention favicon=
5474 * buildbot/buildbot.png: add a default icon, dorky as it is
5476 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
5478 * buildbot/master.py:
5479 * buildbot/process/base.py:
5480 * buildbot/process/builder.py:
5481 * buildbot/process/interlock.py:
5482 * buildbot/status/builder.py:
5483 * buildbot/status/html.py:
5484 * buildbot/status/mail.py:
5485 * buildbot/status/words.py:
5486 new documentation while digging through the code
5488 2005-04-17 Brian Warner <warner@lothar.com>
5490 * general: try to fix file modes on all .py files: a+r, a-x,
5491 but let buildbot/clients/*.py be +x since they're tools
5493 * docs/epyrun (addMod): when an import fails, say why
5495 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
5497 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5499 * buildbot/process/base.py:
5500 * buildbot/process/builder.py:
5501 * buildbot/status/builder.py:
5502 new documentation while digging through the code
5504 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5506 * buildbot/changes/changes.py:
5507 * buildbot/changes/p4poller.py:
5508 * buildbot/interfaces.py:
5509 * buildbot/process/base.py:
5510 * buildbot/process/builder.py:
5511 * buildbot/process/step.py:
5512 * buildbot/process/step_twisted.py:
5513 * buildbot/slave/bot.py:
5514 * buildbot/slave/commands.py:
5515 * buildbot/status/builder.py:
5516 fix all docstrings to make epydoc happy. In the process of fixing
5517 some, I also moved pieces of docs, and removed some deprecated
5520 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5522 * buildbot/process/builder.py:
5523 * buildbot/process/interlock.py:
5524 * buildbot/process/process_twisted.py:
5525 * buildbot/process/step.py:
5526 BuildProcess -> Build, as it looks like that's what happened
5527 * buildbot/process/base.py:
5528 * buildbot/process/factory.py:
5531 2005-04-17 Brian Warner <warner@lothar.com>
5533 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5534 update compile command to accomodate the Twisted split.. now
5535 instead of './setup.py build_ext -i', you do './setup.py all
5536 build_ext -i', to run build_ext over all sub-projects.
5537 (FullTwistedBuildFactory): same
5538 (TwistedReactorsBuildFactory): same
5540 * buildbot/status/html.py (TextLog.finished): null out self.req
5541 when we're done, otherwise the reference cycle of TextLog to .req
5542 to .notifications to a Deferred to TextLog.stop keeps them from
5543 being collected, and consumes a huge (610MB on pyramid at last
5544 check) amount of memory.
5546 2005-04-11 Brian Warner <warner@lothar.com>
5548 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5549 normalize the VC-repository location.. makes SVN happier with
5550 certain test environments.
5552 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5553 RemoteShellCommand gets its own .env dictionary, so that code in
5554 start() doesn't mutate the original. I think this should fix the
5555 step_twisted.Trial problem where multiple identical components
5556 kept getting added to PYTHONPATH= over and over again.
5558 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5559 adding epydoc-format docstrings to many classes. Thanks to Thomas
5560 Vander Stichele for the patches.
5561 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5562 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5563 * buildbot/slave/bot.py, commands.py, registry.py: same
5565 2005-04-05 Brian Warner <warner@lothar.com>
5567 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5568 preserve timestamps, helps incremental builds of large trees.
5569 Patch from Rene Rivera.
5571 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5572 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5575 2005-04-03 Brian Warner <warner@lothar.com>
5577 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5578 with one dict, apparently exec has some scoping bugs when used
5579 with both global/local dicts. Thanks to Nathaniel Smith for the
5582 2005-04-02 Brian Warner <warner@lothar.com>
5584 * buildbot/process/step_twisted.py (countFailedTests): the new
5585 trial in Twisted-2.0 emits a slightly different status line than
5586 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5587 mistakenly think the test count is unparseable.
5588 (Trial.start): note that for some reason each build causes another
5589 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5590 be fixed but I'm not sure quite where the problem is.
5592 2005-04-01 Brian Warner <warner@lothar.com>
5594 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5595 deferredResult to avoid hangs/warnings under twisted-2.0
5596 (RunMixin.tearDown): same
5597 (RunMixin.shutdownSlave): same
5598 (Disconnect.testIdle1): same
5599 (Disconnect.testBuild2): same: wait one second after the build
5600 finishes for test to really be done.. this should be cleaned up to
5601 avoid wasting that second. Builder.detach uses a callLater(0),
5602 either that should be done in-line (something else needed that
5603 behavior), or it should return a Deferred that fires when the
5604 builder is really offline.
5605 (Disconnect.testBuild3): same
5606 (Disconnect.testDisappear): same
5608 * buildbot/test/test_web.py: rearrange server-setup and teardown
5609 code to remove unclean-reactor warnings from twisted-2.0
5611 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5612 so the tests don't hang under twisted-2.0
5614 2005-03-31 Brian Warner <warner@lothar.com>
5616 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5617 caused a warning each time the master changed our set of builders
5619 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5620 w32, don't unlink the file unless it already exists. Thanks to
5621 Baptiste Lepilleur for the catch.
5622 (BuilderStatus.saveYourself): same
5624 2005-02-01 Brian Warner <warner@lothar.com>
5626 * buildbot/status/html.py (TextLog.getChild): use a /text child
5627 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5628 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5629 logfile as text/plain (no markup, no headers). This replaces the
5630 previous scheme (which used an ?text=1 argument), and gets us back
5631 to a relative link (which works better when the buildbot lives
5632 behind another web server, such as Apache configured as a reverse
5633 proxy). Thanks to Gerald Combs for spotting the problem.
5635 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5638 2004-12-13 Brian Warner <warner@lothar.com>
5640 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5642 * debian/changelog: update for 0.6.2
5643 * NEWS: finalize for 0.6.2
5645 2004-12-11 Brian Warner <warner@lothar.com>
5647 * NEWS: bring it up to date
5649 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5650 detection code. Require some sign of life from the buildmaster
5651 every BotFactory.keepaliveInterval seconds. Provoke this
5652 indication at BotFactory.keepaliveTimeout seconds before the
5653 deadline by sending a keepalive request. We don't actually care if
5654 that request is answered in a timely fashion, what we care about
5655 is that .activity() is called before the deadline. .activity() is
5656 triggered by any PB message from the master (including an ack to
5657 one of the slave's status-update messages). With this new scheme,
5658 large status messages over slow pipes are OK, as long as any given
5659 message can be sent (and thus acked) within .keepaliveTimeout
5660 seconds (which defaults to 30).
5661 (SlaveBuilder.remote_startCommand): record activity
5662 (SlaveBuilder.ackUpdate): same
5663 (SlaveBuilder.ackComplete): same
5664 (BotFactory.gotPerspective): same
5665 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5667 2004-12-09 Brian Warner <warner@lothar.com>
5669 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5672 * buildbot/process/step_twisted.py (Trial._commandComplete):
5673 update self.cmd when we start the 'cat test.log' transfer. Without
5674 this, we cannot interrupt the correct RemoteCommand when we lose
5677 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5678 trying to tell the slave to stop the command if we're already
5679 inactive, or if we no longer have a .remote
5681 * buildbot/process/builder.py (Builder._detached): don't let an
5682 exception in currentBuild.stopBuild() prevent the builder from
5683 being marked offline
5685 2004-12-07 Brian Warner <warner@lothar.com>
5687 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5688 KeyError that happens when you ask for a non-existent Builder, and
5689 translate it into a UsageError.
5691 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5692 losing the slave in the middle of a remote step is handled too
5694 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5695 be a Failure, so be sure to stringify it before using it as the
5696 contents of the 'interrupt' logfile
5697 (RemoteCommand.interrupt): use stringified 'why' in
5698 remote_interruptCommand too, just in case
5700 2004-12-06 Brian Warner <warner@lothar.com>
5702 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5703 instead of 'tla update', which is more efficient in case we've
5704 missed a couple of patches since the last update.
5706 * debian/changelog: update for previous (0.6.1) release. Obviously
5707 this needs to be handled better.
5709 2004-12-05 Brian Warner <warner@lothar.com>
5711 * NEWS: update for stuff since last release
5713 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5714 match the maybeDeferred change in Dispatcher.requestAvatar
5715 * buildbot/changes/pb.py (ChangePerspective.attached): same
5716 * buildbot/status/client.py (StatusClientPerspective.attached): same
5717 * buildbot/process/builder.py (Builder._attached3): same
5718 * buildbot/pbutil.py (NewCredPerspective.attached): same
5720 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5721 the date to the top-most box, if it is not the same as today's
5724 * docs/slave.xhtml: provide a buildslave setup checklist
5726 * docs/source.xhtml (Arch): correct terminology
5728 2004-12-04 Brian Warner <warner@lothar.com>
5730 * buildbot/test/test_slavecommand.py: use sys.executable instead
5731 of hard-coding 'python' for child commands, might help portability
5733 * docs/examples/twisted_master.cfg: update to current usage
5735 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5736 'stop build' command to the IRC bot
5738 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5739 message that broke PBChangeSource
5741 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5742 (SlaveBuilder): make some attributes class-level, remove the old
5743 "update queue" which existed to support resuming a build after the
5744 master connection was lost. Try to reimplement that feature later.
5745 (SlaveBuilder.stopCommand): clear self.command when the
5746 SlaveCommand finishes, so that we don't try to kill a leftover one
5748 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5751 * buildbot/slave/commands.py (SourceBase): set self.command for
5752 all VC commands, so they can be interrupted.
5754 2004-12-03 Brian Warner <warner@lothar.com>
5756 * buildbot/master.py: clean up slave-handling code, to handle
5757 slave-disconnect and multiple-connect better
5758 (BotPerspective): make these long-lasting, exactly one per bot
5759 listed in the config file.
5760 (BotPerspective.attached): if a slave connects while an existing
5761 one appears to still be connected, disconnect the old one first.
5762 (BotPerspective.disconnect): new method to forcibly disconnect a
5763 buildslave. Use some hacks to empty the transmit buffer quickly to
5764 avoid the long (20-min?) TCP timeout that could occur if the old
5765 slave has dropped off the net.
5766 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5767 own their own SlaveStatus objects. Remove .attached/.detached, add
5768 .addSlave/.removeSlave, treat slaves like Builders (config file
5769 parsing sends deltas to the BotMaster). Inform the slave
5770 instances, i.e. the BotPerspective, about addBuilder and
5772 (BotMaster.getPerspective): turns into a single dict lookup
5773 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5774 which gives BotPerspective.attached a chance to disconnect the old
5776 (BuildMaster.loadConfig): add code (disabled) to validate that all
5777 builders use known slaves (listed in c['bots']). The check won't
5778 work with tuple-specified builders, which are deprecated but not
5779 yet invalid, so the check is disabled for now.
5780 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5781 routine, do the add/changed/removed dance with them like we do
5783 (BuildMaster.loadConfig_Sources): move source-config into a
5784 separate routine too
5786 * buildbot/status/builder.py (Status.getSlave): get the
5787 SlaveStatus object from the BotPerspective, not the BotMaster.
5789 * buildbot/test/test_run.py: bunch of new tests for losing the
5790 buildslave at various points in the build, handling a slave that
5791 connects multiple times, and making sure we can interrupt a
5794 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5795 something other than 'Bot' for the Bot object, to make certain
5796 test cases easier to write.
5797 (BuildSlave.waitUntilDisconnected): utility method for testing
5799 2004-11-30 Brian Warner <warner@lothar.com>
5801 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5803 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5804 argument, return a Deferred that always fires with True or False.
5805 I don't use an errback to indicate 'ping failed' so that callers
5806 are free to ignore the deferred without causing spurious errors in
5808 * buildbot/process/builder.py (BuilderControl.ping): implement it
5810 * buildbot/test/test_run.py (Status.testDisappear): test ping
5811 (Status.disappearSlave): fix it
5813 2004-11-30 Brian Warner <warner@lothar.com>
5815 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5816 (IBuilderControl): add .getBuild(num), only works for the current
5817 build, of course, although it might be interesting to offer
5818 something for builds in the .waiting or .interlocked state.
5820 * buildbot/process/base.py (Build): have .stopBuild just do the
5821 interrupt, then let the build die by itself.
5822 (BuildControl): add .stopBuild, and add a point-event named
5823 'interrupt' just after the build so status viewers can tell that
5825 (BuilderControl): add .getBuild
5827 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5828 stops when you kill it, good for testing
5829 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5830 contains the 'reason' text.
5832 * buildbot/status/html.py: Add Stop Build button, if the build can
5833 still be stopped. Send a Redirect (to the top page) one second
5834 later, hopefully long enough for the interrupt to have an effect.
5835 Move make_row() up to top-level to share it between Stop Build and
5838 * buildbot/slave/commands.py: only kill the child process once
5840 * buildbot/test/test_run.py: add testInterrupt
5842 2004-11-29 Brian Warner <warner@lothar.com>
5844 * buildbot/process/base.py: Refactor command interruption. The
5845 Build is now responsible for noticing that the slave has gone
5846 away: Build.lostRemote() interrupts the current step and makes
5847 sure that no further ones will be started.
5849 * buildbot/process/builder.py: When the initial remote_startBuild
5850 message fails, log it: this usually indicates that the slave has
5851 gone away, but we don't really start paying attention until they
5852 fail to respond to the first step's command.
5854 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5855 slave disconnect. Now sports a new interrupt() method. Error
5856 handling was simplified a lot by chaining deferreds, so
5857 remoteFailed/remoteComplete were merged into a single
5858 remoteComplete method (which can now get a Failure object).
5859 Likewise failed/finished were merged into just _finished.
5860 (BuildStep): Add interrupt(why) method, and if why is a
5861 ConnectionLost Failure then the step is failed with some useful
5864 * buildbot/slave/bot.py: stop the current command when the remote
5865 Step reference is lost, and when the slave is shut down.
5866 (Bot): make it a MultiService, so it can have children. Use
5867 stopService to tell when the slave is shutting down.
5868 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5869 remote_interruptCommand (which asks the current SlaveCommand to
5870 stop but allows it to keep emitting status messages), and
5871 stopCommand (which tells it to shut up and die).
5873 * buildbot/slave/commands.py: make commands interruptible
5874 (ShellCommand.kill): factor out os.kill logic
5875 (Command): factor out setup()
5876 (Command.sendStatus): don't send status if .running is false, this
5877 happens when the command has been halted.
5878 (Command.interrupt): new method, used to tell the command to die
5879 (SlaveShellCommand): implement .interrupt
5880 (DummyCommand): implement .interrupt
5881 (SourceBase, etc): factor out setup(), don't continue substeps if
5884 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5885 so they can be called after finishing
5887 * buildbot/test/test_run.py: new tests for disconnect behavior,
5888 refactor slave-shutdown routines, add different kinds of
5891 2004-11-27 Brian Warner <warner@lothar.com>
5893 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5894 method to express ETA time like "2m45s" instead of "165 seconds"
5896 2004-11-24 Brian Warner <warner@lothar.com>
5898 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5899 archive after the test completes, to avoid cluttering the user's
5900 'tla archives' listing with a bogus entry. Arch doesn't happen to
5901 provide any way to override the use of ~/.arch-params/, so there
5902 isn't a convenient way to avoid touching the setup of the user who
5904 (VC_HTTP.testArchHTTP): same
5906 2004-11-23 Brian Warner <warner@lothar.com>
5908 * buildbot/status/html.py (TextLog): split render() up into
5909 render_HEAD and render_GET. Use a Producer when sending log
5910 chunks, to reduce memory requirements and avoid sending huge
5911 non-Banana-able strings over web.distrib connections. Requires
5912 peeking under the covers of IStatusLog.
5913 (TextLog.resumeProducing): fix the "as text" link, handle client
5914 disconnects that occur while we're still sending old chunks.
5916 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5917 use defer.succeed, not the non-existent defer.success
5918 (LogFile.waitUntilFinished): same
5919 (LogFile.subscribe): don't add watchers to a finished logfile
5921 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5924 2004-11-23 Brian Warner <warner@lothar.com>
5926 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5928 2004-11-23 Brian Warner <warner@lothar.com>
5930 * NEWS: update for the 0.6.1 release
5931 * MANIFEST.in: add new files
5933 * README (INSTALLATION): explain how to enable the extra VC tests
5935 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5936 level to, so old pickled builds can be displayed ok
5938 2004-11-22 Brian Warner <warner@lothar.com>
5940 * NEWS: summarize updates since last release
5942 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5943 Yoz Grahame. Closes SF#1050138.
5945 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5948 * buildbot/process/step_twisted.py (Trial): update docs a bit
5950 * docs/factories.xhtml: fix Trial factory docs to match reality.
5953 * buildbot/process/factory.py (Trial.__init__): add args for
5954 randomly= and recurse=, making them available to instantiators
5955 instead of only to subclassers. Closes: SF#1049759.
5957 2004-11-15 Brian Warner <warner@lothar.com>
5959 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5960 try to teach the Quick factory to use multiple versions of python
5962 2004-11-12 Brian Warner <warner@lothar.com>
5964 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5965 safer w32-compatible approach, and only use it on windows
5966 (BuildStatus.saveYourself): same
5968 2004-11-11 Brian Warner <warner@lothar.com>
5970 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5971 it: one string merge per chunk. There are now separate .entries
5972 and .runEntries lists: when enumerating over all chunks, make sure
5974 * buildbot/test/test_status.py (Log): more tests
5976 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5977 chunks together, up to 10kb per chunk. This ought to cut down on
5978 the CPU-burning overhead of large log files. Thanks to Alexander
5979 Staubo for spotting the problem.
5980 * buildbot/test/test_status.py (Log): tests for same
5982 2004-11-10 Brian Warner <warner@lothar.com>
5984 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5985 header to outbound mail
5986 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5988 2004-11-08 Brian Warner <warner@lothar.com>
5990 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5991 can't do os.rename() onto an existing file, so catch the exception
5992 and unlink the target file first. This introduces a slight window
5993 where the existing file could be lost, but the main failure case
5994 (disk full) should still be handled safely.
5995 (BuildStatus.saveYourself): same
5997 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5998 separator character instead of os.sep, because the filenames being
5999 split here are coming from the VC system, which can have a
6000 different pathname convention than the local host. This should
6001 help a buildmaster running on windows that uses a CVS repository
6002 which runs under unix.
6003 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
6005 * buildbot/process/step_twisted.py (Trial.createSummary): survive
6006 when there are no test failures to be parsed
6008 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
6009 instead of the unix-specific os.system("cp"), thanks to Elliot
6010 Murphy for this and the other buildbot-vs-windows catches.
6011 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
6013 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
6014 echo the command as it is run
6016 * setup.py: install sample.mk too, not just sample.cfg
6017 (scripts): install contrib/windows/buildbot.bat on windows
6019 2004-11-07 Brian Warner <warner@lothar.com>
6021 * buildbot/process/builder.py (Builder._detached): clear the
6022 self.currentBuild reference, otherwise the next build will be
6023 skipped because we think the Builder is already in use.
6025 * docs/examples/twisted_master.cfg: update to match current usage
6026 on the Twisted buildbot
6028 2004-10-29 Brian Warner <warner@lothar.com>
6030 * buildbot/status/mail.py (MailNotifier): fix typo in docs
6032 2004-10-28 Brian Warner <warner@lothar.com>
6034 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
6035 have separate doVCUpdate/doVCFull methods. Catch an update failure
6036 and respond by clobbering the source directory and re-trying. This
6037 will handle local changes (like replacing a file with a directory)
6038 that will cause CVS and SVN updates to fail.
6039 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
6041 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
6044 2004-10-19 Brian Warner <warner@lothar.com>
6046 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
6048 * buildbot/status/html.py (StatusResourceTestResults): display any
6049 TestResults that the Build might have
6050 (StatusResourceTestResult): and the logs for each TestResult
6051 (StatusResourceBuild): add link from the per-build page
6053 2004-10-15 Brian Warner <warner@lothar.com>
6055 * buildbot/process/step_twisted.py (Trial.createSummary): parse
6056 the 'problems' portion of stdout, add TestResults to our build
6057 * buildbot/test/test_twisted.py (Parse.testParse): test it
6059 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
6060 to retrieve a dict of accumulated test results
6061 (ITestResult): define what a single test result can do
6062 * buildbot/status/builder.py (TestResult): implement ITestResult
6063 (BuildStatus.getTestResults): retrieve dict of TestResults
6064 (BuildStatus.addTestResult): add TestResults
6065 * buildbot/test/test_status.py (Results.testAddResults): test it
6067 2004-10-14 Brian Warner <warner@lothar.com>
6069 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
6070 instead of os.system("rm -rf") for win32 portability
6072 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
6073 SignalMixin instead of starting/stopping the reactor, which is
6074 likely to cause problems with other tests
6076 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
6077 self.copyComplete() call. Yoz Grahame makes the catch.
6079 * contrib/windows/buildbot.bat: helper script to deal with path
6080 issues. Thanks to Yoz Grahame.
6082 * buildbot/master.py (BuildMaster.startService): don't register a
6083 SIGHUP handler if the signal module has no SIGHUP attribute.
6084 Apparently win32 does this.
6086 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
6088 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
6089 test if the reactor can't offer UNIX sockets
6091 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
6092 error introduced in the last commit. We really need that
6095 2004-10-12 Brian Warner <warner@lothar.com>
6097 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
6098 when describing a maildir source. Thanks to Stephen Davis.
6100 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
6103 * buildbot/scripts/runner.py (createMaster): install Makefile too
6104 (start): add --no_save to 'start' command
6105 * buildbot/scripts/sample.mk: simple convenience Makefile with
6106 start/stop/reload targets
6108 * buildbot/__init__.py (version): bump to 0.6.0+ while between
6111 2004-09-30 Brian Warner <warner@lothar.com>
6113 * setup.py: Releasing buildbot-0.6.0
6115 2004-09-30 Brian Warner <warner@lothar.com>
6117 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
6118 test_trial.py from the source tarball until support is complete.
6120 * NEWS: update for 0.6.0 release
6121 * buildbot/__init__.py (version): same
6124 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
6125 'source' command to tell users where to get the Buildbot source
6127 * docs/examples/*.cfg: update to modern standards
6129 * NEWS: update for release
6131 * buildbot/scripts/runner.py (createMaster): remove the
6132 -shutdown.tap stuff now that it isn't necessary
6134 (start): launch buildbot.tap, not buildbot-shutdown.tap
6137 * buildbot/status/mail.py (Domain): shorten class name
6138 (MailNotifier): if lookup= is a string, pass it to Domain()
6139 * buildbot/test/test_status.py (Mail.testBuild1): new class name
6140 (Mail.testBuild2): test the string-to-Domain shortcut
6141 (Mail.testMail): fix test
6144 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
6147 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
6148 more attributes on load
6149 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
6150 to accomodate the whole waterfall page at once, and the thrashing
6151 results in a lot of unnecessary loads
6152 (BuildStatus.saveYourself): use binary pickles, not fluffy text
6153 (BuilderStatus.saveYourself): same
6154 (BuilderStatus.eventGenerator): stop generating on the first missing
6155 build. We assume that saved builds are deleted oldest-first.
6156 (BuildStepStatus.__getstate__): .progress might not exist
6158 * buildbot/changes/changes.py (ChangeMaster): make it
6159 serializable, in $masterdir/changes.pck
6160 (ChangeMaster.stopService): save on shutdown
6161 * buildbot/master.py (BuildMaster.loadChanges): load at startup
6162 * buildbot/test/test_config.py: load Changes before config file
6165 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
6166 "Oh my god, you killed the command" header on a separate line
6168 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
6169 skip over corrupted build pickles
6170 (BuilderStatus.getFullBuildByNumber): same
6171 (BuilderStatus.eventGenerator): skip over unavailable builds
6172 (BuildStatus.saveYourself): save builds to a .tmp file first, then
6173 do an atomic rename. This prevents a corrupted pickle when some
6174 internal serialization error occurs.
6175 (BuilderStatus.saveYourself): same
6177 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
6178 the timeout for shell commands, it got lost somehow
6180 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
6181 run out of build steps, return the rest of the builder events
6183 * buildbot/interfaces.py (IBuilderControl.ping): add method
6185 * buildbot/process/builder.py (BuilderControl.ping): move
6186 slave-ping to BuilderControl, and fix the failure case in the
6187 process (Event.finish() is the verb, Event.finished is the noun).
6189 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
6190 through the BuilderControl instead of the BuilderStatus
6191 (EventBox): add adapter for builder.Event, allowing builder events to
6192 be displayed in the waterfall display
6194 * buildbot/master.py (BotMaster.stopService): add a 'master
6195 shutdown' event to the builder's log
6196 (BuildMaster.startService): and a 'master started' on startup
6198 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
6199 builder events into the BuildStep event stream
6200 (Status.builderAdded): add a 'builder created' event
6203 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
6204 command to announce the completion of a running build
6205 (IrcStatusBot.command_FORCE): announce when the build finishes
6207 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
6208 don't evict unfinished builds from the cache: they must stay in
6209 the full-cache until their logfiles have stopped changing. Make
6210 sure the eviction loop terminates if an unfinished build was hit.
6211 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
6212 This lets exceptions be dumped in an email status message. Really
6213 we need LogFiles which contain both text and HTML, instead of two
6215 (BuildStatus.__getstate__): handle self.finished=False
6216 (Status.builderAdded): if the pickle is corrupted, abandon the
6217 history and create a new BuilderStatus object.
6219 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
6220 self.progress attribute, helped one test which doesn't fully set
6221 up the Build object.
6223 * buildbot/interfaces.py (IStatusLogStub): split out some of the
6224 IStatusLog methods into an Interface that is implemented by "stub"
6225 logs, for which all the actual text chunks are on disk (in the
6226 pickled Build instance). To show the log contents, you must first
6227 adapt the stub log to a full IStatusLog object.
6229 * buildbot/status/builder.py (LogFileStub): create separate stub
6230 log objects, which can be upgraded to a real one if necessary.
6231 (LogFile): make them persistable, and let them stubify themselves
6233 (BuildStepStatus): same
6235 (BuildStatus.saveYourself): save the whole build out to disk
6236 (BuilderStatus): make it persistable
6237 (BuilderStatus.saveYourself): save the builder to disk
6238 (BuilderStatus.addFullBuildToCache): implement two caches which
6239 hold Build objects: a small one which holds full Builds, and a
6240 larger one which holds "stubbed" Builds (ones with their LogFiles
6241 turned into LogFileStubs). This reduces memory usage by the
6242 buildmaster by not keeping more than a few (default is 2) whole
6243 build logs in RAM all the time.
6244 (BuilderStatus.getBuild): rewrite to pull from disk (through the
6246 (BuilderStatus.eventGenerator): rewrite since .builds went away
6247 (BuilderStatus.buildStarted): remove the .builds array. Add the
6248 build to the "full" cache when it starts.
6249 (BuilderStatus._buildFinished): save the build to disk when it
6251 (Status): give it a basedir (same as the BuildMaster's basedir)
6252 where the builder pickles can be saved
6253 (Status.builderAdded): create the BuilderStatus ourselves, by
6254 loading a pickle from disk (or creating a new instance if there
6255 was none on disk). Return the BuilderStatus so the master can glue
6256 it into the new Builder object.
6258 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
6259 all BuilderStatuses to save themselves out to disk. This is in
6260 lieu of saving anything important in the main Application pickle
6261 (the -shutdown.tap file).
6262 (BuildMaster.__init__): give Status() a basedir for its files
6263 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
6264 to get the BuilderStatus, then give it to the Builder (instead of
6265 doing it the other way around). It's ok if the status announces
6266 the new Builder before it's really ready, as the outside world can
6267 only see the BuilderStatus object anyway (and it is ready before
6268 builderAdded returns). Use the builder's "builddir" (which
6269 normally specifies where the slave will run the builder) as the
6270 master's basedir (for saving serialized builds).
6272 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
6273 coerce the logfile to IStatusLog before trying to get the text
6274 chunks out of it. This will pull the full (non-stubified) Build in
6275 from disk if necessary.
6276 (TextLog): fix the adapter registration
6278 * buildbot/test/test_control.py (Force.setUp): create the basedir
6279 * buildbot/test/test_web.py: same
6280 * buildbot/test/test_vc.py (SetupMixin.setUp): same
6281 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
6282 * buildbot/test/test_run.py (Run.testMaster): same
6283 (Status.setUp): same
6285 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
6287 * buildbot/status/html.py (Waterfall.__init__): store actual
6288 allowForce flag passed in rather than using True for everyone;
6289 make sure setting it to False doesn't cause a NameError
6291 (StatusResourceBuilder.__init__) add the builder name to the page
6293 (StatusResourceBuilder.body) move HTML generation for a name/value
6294 row into a helper method (StatusResourceBuilder.make_row); only
6295 generate the "Force Build" form if allowForce was True and the
6296 slave is connected. Use class attributes in the generated HTML to
6297 spread a little CSS-joy.
6299 2004-09-28 Brian Warner <warner@lothar.com>
6301 * buildbot/process/step_twisted.py (Trial.createSummary): fix
6302 warning-scanner to not ignore things like
6303 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
6305 * buildbot/status/html.py (StatusResource.control): add some
6306 class-level values for .control in an attempt to make upgrading
6309 * buildbot/util.py (ComparableMixin): survive missing attributes,
6310 such as when a class is modified and we're comparing old instances
6313 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
6314 failure handling, remove a redundant try/except block. Don't
6315 return the full traceback to the IRC channel.
6316 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
6317 error messages. Get ETA properly.
6319 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
6320 the reason, since (at least) IRC message will have <> in them.
6321 (StatusResourceBuilder.__init__): take an IBuilderControl
6322 (StatusResourceBuilder.force): use the IBuilderControl we get in
6323 the constructor instead of trying to make our own. Catch the
6324 new exceptions and ignore them for now (until we make an
6325 intermediate web page where we could show the error message)
6326 (StatusResource): create with an IControl, use it to give an
6327 IBuilderControl to all children
6328 (Waterfall): take an allowForce= option, pass an IControl object
6329 to StatusResource if it is True
6331 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
6333 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6334 catch new exceptions and return string forms
6336 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
6337 * buildbot/process/builder.py (Builder.forceBuild): raise them
6338 * buildbot/test/test_control.py (Force.testNoSlave): new test
6339 (Force.testBuilderInUse): same
6342 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
6344 * buildbot/test/test_run.py: use IControl
6345 * buildbot/test/test_vc.py: same
6347 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
6348 to use IControl. Still offline.
6349 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
6351 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
6352 who=None so periodic builds don't send out status mail
6353 (Builder.forceBuild): include reason in the log message
6354 (BuilderControl.forceBuild): rename 'name' to 'who'
6356 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
6357 'who' parameter, but make it None by default so builds forced by
6358 slave admins don't cause status mail to be sent to anybody
6359 (BotMaster.forceBuild): same. this method is deprecated.
6360 (DebugPerspective.perspective_forceBuild): same, use IControl.
6361 (DebugPerspective.perspective_fakeChange): use IControl..
6362 (Dispatcher.requestAvatar): .. so don't set .changemaster
6364 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
6365 parameter to avoid confusion with the name of the builder
6368 * buildbot/status/mail.py: refine comment about needing 2.3
6370 * buildbot/status/html.py: move all imports to the top
6372 * buildbot/test/test_control.py: test new interfaces
6373 * buildbot/test/test_run.py (Status): handle new interfaces
6374 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
6376 * buildbot/process/base.py (BuildControl): implement IBuildControl
6377 and its lonely getStatus() method
6379 * buildbot/process/builder.py (BuilderControl): implement
6380 IBuilderControl, obtained by adapting the Builder instance
6381 (Builder.startBuild): return a BuilderControl instead of a
6382 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
6383 accomplish the same thing.
6385 * buildbot/master.py: move all import statements to the top
6386 (Control): implement IControl, obtained by adapting the
6387 BuildMaster instance.
6389 * buildbot/interfaces.py: add IControl, IBuilderControl, and
6390 IBuildControl. These are used to force builds. Eventually they
6391 will provide ways to reconfigure the Builders, pause or abandon a
6392 Build, and perhaps control the BuildMaster itself.
6394 2004-09-26 Brian Warner <warner@lothar.com>
6396 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
6397 ends up comparing us against something without a .__class__
6399 2004-09-24 Brian Warner <warner@lothar.com>
6401 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
6404 * Makefile: add 'deb-snapshot' target, to create a timestamped
6407 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
6409 2004-09-23 Brian Warner <warner@lothar.com>
6411 * buildbot/__init__.py (version): move version string here
6412 * setup.py: get version string from buildbot.version
6413 * buildbot/status/html.py (WaterfallStatusResource.body): add
6414 buildbot version to the page footer
6415 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
6418 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
6419 slaves, let the second know where the first one is coming from
6420 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
6421 see our exceptions. It would be nice if there were a way to just
6422 send them the exception type and value, not the full traceback.
6425 * buildbot/status/mail.py (MailNotifier): add a new argument
6426 sendToInterestedUsers=, which can be set to False to disable the
6427 usual send-to-blamelist behavior.
6428 (top): handle python-2.2 which has no email.MIMEMultipart
6429 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
6430 (MailNotifier.disownServiceParent): unsubscribe on removal
6432 * buildbot/test/test_status.py (Mail.testBuild2): test it
6435 * buildbot/status/progress.py (Expectations.wavg): tolerate
6436 current=None, which happens when steps start failing badly
6437 * buildbot/test/test_status.py (Progress.testWavg): test for it
6439 * buildbot/process/step.py (SVN.startVC): when the (old) slave
6440 doesn't understand args['revision'], emit a warning instead of
6441 bailing completely. Updating to -rHEAD is probably close enough.
6443 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
6445 * buildbot/test/test_status.py: at least import bb.status.client
6446 even if we don't have any test coverage for it yet
6448 * contrib/svn_buildbot.py: don't require python2.3
6449 (main): wait, do require it (for sets.py), but explain how to
6450 make it work under python2.2
6452 2004-09-23 Brian Warner <warner@lothar.com>
6454 * contrib/svn_buildbot.py: include the revision number in the Change
6456 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
6457 using util.now() because FreshCVS is a realtime service
6459 * buildbot/status/event.py: delete dead code
6460 * buildbot/process/step.py: don't import dead Event class
6461 * buildbot/process/step_twisted.py: same
6462 * buildbot/status/builder.py: same
6463 * buildbot/status/client.py: same
6465 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
6467 * buildbot/changes/changes.py (Change): set .when from an __init__
6468 argument (which defaults to now()), rather than having
6469 ChangeMaster.addChange set it later.
6470 (ChangeMaster.addChange): same
6472 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
6473 (parseSyncmail): same. Just use util.now() for now.
6474 (parseBonsaiMail): parse the timestamp field for when=
6476 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
6477 instead of setting .when after the fact
6481 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
6482 results when the target project uses retrial. Still under
6484 * buildbot/test/test_trial.py: same
6486 2004-09-21 Brian Warner <warner@lothar.com>
6488 * buildbot/status/mail.py (MailNotifier.__init__): include
6489 success/warnings/failure in the Subject line
6490 (MailNotifier.buildMessage): add the buildbot's URL to the body,
6491 use step.logname for the addLogs=True attachment filenames
6492 * buildbot/test/test_status.py (Mail): test Subject lines
6493 (Mail.testLogs): test attachment filenames
6495 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
6496 accept a 'who' argument from the debug tool
6497 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
6498 * contrib/debug.glade: add text box to set 'who'
6500 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6501 .getBuilderName with .getBuilder().getName(), more flexible
6502 (IStatusLog.getName): logs have short names, but you can prefix
6503 them with log.getStep().getName() to make them more useful
6504 * buildbot/status/builder.py: same
6505 * buildbot/status/client.py: same
6506 * buildbot/status/html.py: same
6507 * buildbot/test/test_run.py (Status.testSlave): same
6508 * buildbot/process/step.py: tweak logfile names
6510 * buildbot/status/mail.py (MailNotifier): add lookup, change
6511 argument to extraRecipients. The notifier is now aimed at sending
6512 mail to the people involved in a particular build, with additional
6513 constant recipients as a secondary function.
6515 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6516 including slow-lookup and failing-lookup. Make sure the blamelist
6517 members are included.
6519 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6520 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6521 (IBuildStatus.getInterestedUsers): new method
6522 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6523 * buildbot/status/client.py (remote_getResponsibleUsers): same
6524 * buildbot/status/html.py (StatusResourceBuild.body): same
6525 * buildbot/test/test_run.py (Status.testSlave): same
6527 2004-09-20 Brian Warner <warner@lothar.com>
6529 * docs/users.xhtml: update concepts
6531 * Makefile: add a convenience makefile, for things like 'make
6532 test'. It is not included in the source tarball.
6534 2004-09-16 Brian Warner <warner@lothar.com>
6536 * NEWS: mention /usr/bin/buildbot, debian/*
6538 * debian/*: add preliminary debian packaging. Many thanks to
6539 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6540 it considerably since it left their hands, I am responsible for
6541 all breakage that's resulted.
6543 * bin/buildbot: create a top-level 'buildbot' command, to be
6544 installed in /usr/bin/buildbot . For now it's just a simple
6545 frontend to mktap/twistd/kill, but eventually it will be the entry
6546 point to the 'try' command and also a status client. It is also
6547 intended to support the upcoming debian-packaging init.d scripts.
6548 * buildbot/scripts/runner.py: the real work is done here
6549 * buildbot/scripts/__init__.py: need this too
6550 * buildbot/scripts/sample.cfg: this is installed in new
6551 buildmaster directories
6552 * setup.py: install new stuff
6554 2004-09-15 Brian Warner <warner@lothar.com>
6556 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6557 'file:' schema (the version shipped with OS-X was built without the
6559 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6560 updates the log-timestamp, to make sure it isn't still running after
6563 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6564 values to the config file.
6565 * docs/examples/hello.cfg: add examples
6566 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6567 * buildbot/status/builder.py (Status.getProjectURL): implement them
6568 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6569 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6570 * buildbot/status/html.py (WaterfallStatusResource): display them
6573 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6574 certain error cases don't suffer a secondary exception.
6575 (top): Skip tests if the corresponding VC tool is not installed.
6577 * buildbot/process/factory.py (Trial): introduce separate
6578 'buildpython' and 'trialpython' lists, since trialpython=[] is
6579 what you want to invoke /usr/bin/python, whereas ./setup.py is
6580 less likely to be executable. Add env= parameter to pass options
6581 to test cases (which is how I usually write tests, I don't know if
6582 anyone else does it this way).
6584 * buildbot/process/step_twisted.py (Trial): handle python=None.
6585 Require 'testpath' be a string, not a list. Fix tests= typo.
6586 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6588 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6589 way to deal with the possibility of removing the disconnect notify
6591 (CVS): add a 'login' parameter to give a password to 'cvs login',
6592 commonly used with pserver methods (where pw="" or pw="guest")
6594 * buildbot/slave/commands.py (SourceBase): move common args
6595 extraction and setup() to __init__, so everything is ready by the
6596 time setup() is called
6597 (CVS.start): call 'cvs login' if a password was supplied
6598 (ShellCommand): special-case PYTHONPATH: prepend the master's
6599 value to any existing slave-local value.
6601 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6602 don't have a remote, mark the builder as Offline. This whole
6603 function should probably go away and be replaced by individual
6605 (Builder.buildFinished): return the results to the build-finished
6606 deferred callback, helps with testing
6608 2004-09-14 Brian Warner <warner@lothar.com>
6610 * buildbot/test/test_vc.py: put all the repositories needed to run
6611 the complete tests into a single small (1.3MB) tarball, so I can
6612 make that tarball available on the buildbot web site. Test HTTP
6613 access (for Arch and Darcs) by spawning a temporary web server
6614 while the test runs.
6616 * docs/users.xhtml: new document, describe Buildbot's limited
6617 understanding of different human users
6619 * buildbot/test/test_vc.py: rearrange test cases a bit
6621 * buildbot/process/step_twisted.py (Trial): handle testpath=
6622 * buildbot/process/factory.py (Trial): update to use step.Trial
6624 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6626 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6627 the overall build text (which gives you 'failed 2 tests' rather
6629 (BuildStepStatus.text2): default to [], not None
6631 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6634 2004-09-12 Brian Warner <warner@lothar.com>
6636 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6637 log the whole exception if it's just an AttributeError (old slave)
6639 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6640 so (e.g.) sub-commands can be run in the right directory.
6641 (ShellCommand.start): accept an optional errorMessage= argument
6642 to make life easier for SVN.start
6643 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6645 (ShellCommand.start): move ['dir'] compatibility hack..
6646 (RemoteShellCommand.start): .. to here so everyone can use it
6648 * buildbot/process/step_twisted.py (Trial): use .workdir
6650 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6651 text displayed when debuild fails completely
6652 (Trial): snarf _trial_temp/test.log from the slave and display it
6654 2004-09-11 Brian Warner <warner@lothar.com>
6656 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6658 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6659 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6661 * buildbot/process/step.py (ShellCommand): call .createSummary
6662 before .evaluateCommand instead of the other way around. This
6663 makes it slightly easier to count warnings and then use that to
6664 set results=WARNINGS
6665 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6667 * buildbot/process/base.py (Build.buildFinished): update status
6668 before doing progress. It's embarrassing for the build to be stuck
6669 in the "building" state when an exceptions occurs elsewhere..
6671 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6672 python2.2 doesn't have 'sum'
6674 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6675 to prevent clients from accidentally sorting it
6677 * buildbot/master.py (Manhole): add username/password
6678 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6679 c['manholePort'], deprecate old usage
6680 * docs/config.xhtml: document c['manhole']
6681 * docs/examples/hello.cfg: show example of using a Manhole
6684 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6685 pretend the slave is up to date
6687 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6688 the module, overlaps with 'log', the local variable
6690 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6692 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6693 new method to let Steps find out the version of their
6694 corresponding SlaveCommand.
6695 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6696 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6697 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6699 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6700 (Arch.startVC): same
6701 (P4Sync.startVC): same
6703 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6704 Deferred so we can catch errors in remote_startCommand
6705 (RemoteShellCommand.start): same
6707 * docs/examples/twisted_master.cfg: update sample config file
6709 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6710 after connectionMade() is called, not before. Close stdin at that
6713 * buildbot/process/process_twisted.py: update to use Trial, clean
6714 up argument passing (move to argv arrays instead of string
6717 * buildbot/process/step_twisted.py (Trial): new step to replace
6718 RunUnitTests, usable by any trial-using project (not just
6719 Twisted). Arguments have changed, see the docstring for details.
6721 * buildbot/process/base.py (Build.startBuild): this now returns a
6722 Deferred. Exceptions that occur during setupBuild are now
6723 caught better and lead to fewer build_status weirdnesses, like
6724 finishing a build that was never started.
6725 (Build.buildFinished): fire the Deferred instead of calling
6726 builder.buildFinished directly. The callback argument is this
6727 Build, everything else can be extracted from it, including the
6728 new build.results attribute.
6729 * buildbot/process/builder.py (Builder.startBuild): same
6730 (Builder.buildFinished): same, extract results from build
6732 * buildbot/process/step.py (ShellCommands): remove dead code
6734 2004-09-08 Brian Warner <warner@lothar.com>
6736 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6737 doesn't try to use the leftover patched workdir
6738 (SourceStamp): test source-stamp computation for CVS and SVN
6740 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6741 patched workdir ('touch .buildbot-patched') so we don't try to
6743 (SourceBase.start): add ['revision'] for all Source steps
6744 (CVS): change args: use ['branch'] for -r, remove ['files']
6745 (CVS.buildVC): fix revision/branch stuff
6746 (SVN): add revision stuff
6748 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6749 kwargs (except 'workdir') to avoid silent spelling errors
6750 (ShellCommand.__init__): same
6751 (Source): new base class for CVS/SVN/etc. Factor out everything
6752 common, add revision computation (perform the checkout with a -D
6753 DATE or -r REVISION that gets exactly the sources described by the
6754 last Change), overridable with step.alwaysUseLatest. Add patch
6755 handling (build.getSourceStamp can trigger the use of a base
6756 revision and a patch).
6757 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6758 * docs/steps.xhtml: update docs
6759 * docs/source.xhtml: mention .checkoutDelay
6760 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6762 * buildbot/process/base.py (Build.setSourceStamp): add a
6763 .sourceStamp attribute to each Build. If set, this indicates that
6764 the build should be done with something other than the most
6765 recent source tree. This will be used to implement "try" builds.
6766 (Build.allChanges): new support method
6767 (Build.lastChangeTime): remove, functionality moved to Source steps
6768 (Build.setupBuild): copy the Step args before adding ['workdir'],
6769 to avoid modifying the BuildFactory (and thus triggering spurious
6773 * buildbot/status/html.py: rename s/commits/changes/
6774 (StatusResourceChanges): same
6775 (CommitBox.getBox): same, update URL
6776 (WaterfallStatusResource): same
6777 (StatusResource.getChild): same
6779 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6780 * contrib/debug.glade: add optional 'revision' to the fakeChange
6782 * buildbot/changes/changes.py (html_tmpl): display .revision
6783 (ChangeMaster.addChange): note .revision in log
6784 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6785 accept a ['revision'] attribute
6787 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6789 * buildbot/master.py (BotMaster.getPerspective): update the
6790 .connected flag in SlaveStatus when it connects
6791 (BotMaster.detach): and when it disconnects
6792 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6793 (BuildMaster.loadConfig_Builders): walk old list correctly
6795 * buildbot/test/test_config.py: fix prefix= usage
6797 2004-09-06 Brian Warner <warner@lothar.com>
6801 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6802 poll a P4 depot looking for recent changes. Thanks to Dave
6803 Peticolas for the contribution. Probably needs some testing after
6806 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6807 requires manual client setup for each buildslave. Rather
6808 experimental. Thanks again to Dave Peticolas.
6809 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6811 * buildbot/changes/changes.py (Change): add a .revision attribute,
6812 which will eventually be used to generate source-stamp values.
6814 * buildbot/process/step.py (RemoteCommand.start): use
6815 notifyOnDisconnect to notice when we lose the slave, then treat it
6816 like an exception. This allows LogFiles to be closed and the build
6817 to be wrapped up normally. Be sure to remove the disconnect
6818 notification when the step completes so we don't accumulate a
6819 bazillion such notifications which will fire weeks later (when the
6820 slave finally disconnects normally). Fixes SF#915807, thanks to
6821 spiv (Andrew Bennetts) for the report.
6822 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6823 really isn't Logged- specific
6824 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6825 header, since it's almost always going to be appended to an
6827 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6828 update test to handle use of notifyOnDisconnect
6830 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6831 don't clear .ETA and .currentBuild when going offline, let the
6832 current build clean up after itself
6834 * buildbot/process/builder.py (Builder.detached): wait a moment
6835 before doing things like stopping the current build, because the
6836 current step will probably notice the disconnect and cleanup the
6838 * buildbot/test/test_run.py (Status.tearDown): update test to
6839 handle asynchronous build-detachment
6841 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6843 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6844 hush a debug message
6846 2004-09-05 Brian Warner <warner@lothar.com>
6848 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6849 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6850 kernels do this: the fcntl module has the F_NOTIFY constant, but
6851 the kernel itself doesn't support the operation. Thanks to Olly
6852 Betts for spotting the problem.
6854 * buildbot/process/step.py (Darcs): new source-checkout command
6855 (Arch): new source-checkout command
6856 (todo_P4): fix constructor syntax, still just a placeholder
6857 * buildbot/test/test_vc.py (VC.testDarcs): test it
6858 (VC.testDarcsHTTP): same, via localhost HTTP
6860 (VC.testArchHTTP): same
6861 * NEWS: mention new features
6863 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6864 which tells the step to stash stdout text locally (in .stdout).
6865 Slave-side Commands can use this to make decisions based upon the
6866 output of the the ShellCommand (not just the exit code).
6867 (Darcs): New source-checkout command
6868 (Arch): New source-checkout command, uses .keepStdout in one place
6869 where it needs to discover the archive's default name.
6871 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6872 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6873 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6875 * buildbot/process/step.py (ShellCommand.describe): add an
6876 alternate .descriptionDone attribute which provides descriptive
6877 text when the step is complete. .description can be ["compiling"],
6878 for use while the step is running, then .descriptionDone can be
6879 ["compile"], used alone when the step succeeds or with "failed" when
6880 it does not. Updated other steps to use the new text.
6881 * buildbot/process/step_twisted.py: same
6882 * buildbot/test/test_run.py: update tests to match
6884 2004-08-30 Brian Warner <warner@lothar.com>
6886 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6887 (CVS.__init__): send 'patch' argument to slave
6888 (CVS.start): don't create the LoggedRemoteCommand until start(),
6889 so we can catch a .patch added after __init__
6890 (SVN.__init__): add 'patch' to SVN too
6893 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6894 argument, to let commands push data into the process' stdin pipe.
6895 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6896 is in use, since closing a PTY doesn't really affect the process
6897 in the right way (in particular, I couldn't run /usr/bin/patch
6899 (SourceBase.doPatch): handle 'patch' argument
6901 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6904 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6905 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6907 * buildbot/master.py (BotPerspective.got_commands): get command
6908 versions from slave, give to each builder
6909 * buildbot/process/builder.py (Builder.attached): stash slave
6910 command versions in .remoteCommands
6912 * docs/steps.xhtml: bring docs in-line with reality
6914 * buildbot/process/step.py (CVS.__init__): more brutal
6915 compatibility code removal
6916 (SVN.__init__): same
6918 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6919 (SlaveShellCommand.start): require ['workdir'] argument, remove
6920 the ['dir'] fallback (compatibility will come later)
6921 (SourceBase): update docs
6922 (SourceBase.start): remove ['directory'] fallback
6925 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6926 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6927 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6929 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6930 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6931 code.. I will figure out 0.5.0-compatibility hooks later)
6933 2004-08-30 Brian Warner <warner@lothar.com>
6935 * buildbot/process/process_twisted.py: rewrite in terms of new
6936 BuildFactory base class. It got significantly shorter. Yay
6939 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6940 work with the new "self.build isn't nailed down until we call
6941 step.start()" scheme: specifically, __init__ is called before the
6942 build has decided on which Changes are going in, so we don't scan
6943 build.allFiles() for .xhtml files until start()
6944 (HLint.commandComplete): use getText(), not getStdout()
6945 (RunUnitTests.start): same: don't use .build until start()
6946 (RunUnitTests.describe): oops, don't report (None) when using
6948 (RunUnitTests.commandComplete): use getText()
6949 (RunUnitTests.createSummary): same
6950 (BuildDebs.commandComplete): same
6952 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6953 set args['command'] until start(), since our BuildStep is allowed
6954 to change their mind up until that point
6955 (TreeSize.commandComplete): use getText(), not getStdout()
6957 * docs/examples/twisted_master.cfg: update to current standards
6959 * docs/factories.xhtml: update
6960 * buildbot/process/factory.py: implement all the common factories
6961 described in the docs. The Trial factory doesn't work yet, and
6962 I've probably broken all the process_twisted.py factories in the
6963 process. There are compatibility classes left in for things like
6964 the old BasicBuildFactory, but subclasses of them are unlikely to
6966 * docs/examples/glib_master.cfg: use new BuildFactories
6967 * docs/examples/hello.cfg: same
6969 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6970 explicit 'workdir' args
6972 * buildbot/process/base.py (BuildFactory): move factories to ..
6973 * buildbot/process/factory.py (BuildFactory): .. here
6974 * buildbot/process/process_twisted.py: handle move
6975 * buildbot/test/test_config.py: same
6976 * buildbot/test/test_run.py: same
6977 * buildbot/test/test_steps.py: same
6978 * buildbot/test/test_vc.py: same
6979 * docs/factories.xhtml: same
6981 * NEWS: mention config changes that require updating master.cfg
6983 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6984 argument to all steps that weren't given one already, pointing at
6985 the "build/" directory.
6987 * docs/examples/hello.cfg: remove explicit 'workdir' args
6989 * docs/factories.xhtml: document standard BuildFactory clases,
6990 including a bunch which are have not yet been written
6992 2004-08-29 Brian Warner <warner@lothar.com>
6994 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6995 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6996 buildbot.status.builder so they aren't quite so internal
6997 * buildbot/process/base.py, buildbot/process/builder.py: same
6998 * buildbot/process/maxq.py, buildbot/process/step.py: same
6999 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
7000 * buildbot/status/mail.py, buildbot/test/test_run.py: same
7001 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
7003 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
7004 to handle new getLogs()-returns-list behavior
7005 (StatusResourceBuildStep.getChild): same
7006 (StepBox.getBox): same
7007 (WaterfallStatusResource.phase0): same
7009 * docs/source.xhtml: document how Buildbot uses version-control
7010 systems (output side: how we get source trees)
7011 * docs/changes.xhtml: rename from sources.xhtml, documents VC
7012 systems (input side: how we learn about Changes)
7014 * buildbot/master.py (Manhole): use ComparableMixin
7015 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
7016 * buildbot/changes/mail.py (MaildirSource): same
7017 * buildbot/status/client.py (PBListener): same
7018 * buildbot/status/html.py (Waterfall): same
7019 * buildbot/status/words.py (IRC): same
7021 * NEWS: start describing new features
7023 * buildbot/status/mail.py (MailNotifier): finish implementation.
7024 The message body is still a bit sparse.
7025 * buildbot/test/test_status.py (Mail): test it
7027 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
7028 and __hash__ methods I wind up adding everywhere. Specifically
7029 intended to support the buildbot config-file update scheme where
7030 we compare, say, the old list of IStatusTargets against the new
7031 one and don't touch something which shows up on both lists.
7032 * buildbot/test/test_util.py (Compare): test case for it
7034 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
7035 return a list instead of a dict
7036 (IBuildStepStatus.getLogs): same. The idea is that steps create
7037 logs with vaguely unique names (although their uniqueness is not
7038 guaranteed). Thus a compilation step should create its sole
7039 logfile with the name 'compile', and contribute it to the
7040 BuildStatus. If a step has two logfiles, try to create them with
7041 different names (like 'test.log' and 'test.summary'), and only
7042 contribute the important ones to the overall BuildStatus.
7043 * buildbot/status/builder.py (Event.getLogs): same
7044 (BuildStepStatus): fix default .text and .results
7045 (BuildStepStatus.addLog): switch to list-like .getLogs()
7046 (BuildStepStatus.stepFinished): same
7047 (BuildStatus.text): fix default .text
7048 (BuildStatus.getLogs): temporary hack to return all logs (from all
7049 child BuildStepStatus objects). Needs to be fixed to only report
7050 the significant ones (as contributed by the steps themselves)
7051 * buildbot/test/test_run.py: handle list-like .getLogs()
7052 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
7054 2004-08-28 Brian Warner <warner@lothar.com>
7056 * buildbot/process/builder.py (Builder.attached): serialize the
7057 attachment process, so the attach-watcher isn't called until the
7058 slave is really available. Add detached watchers too, which makes
7061 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
7063 * buildbot/test/test_swap.py: remove dead code
7065 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
7066 (ShellCommand.start): treat errors in _startCommand/spawnProcess
7067 sort of as if the command being run exited with a -1. There may
7068 still be some holes in this scheme.
7069 (CVSCommand): add 'revision' tag to the VC commands, make sure the
7070 -r option appears before the module list
7071 * buildbot/process/step.py (CVS): add 'revision' argument
7073 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
7074 when sending updates or stepComplete messages to the master, since
7075 we don't currently care whether they arrive or not. When we revamp
7076 the master/slave protocol to really resume interrupted builds,
7077 this will need revisiting.
7078 (lostRemote): remove spurious print
7080 * buildbot/master.py (BotPerspective.attached): serialize the
7081 new-builder interrogation process, to make testing easier
7082 (BotMaster.waitUntilBuilderDetached): convenience function
7084 * buildbot/status/builder.py (BuilderStatus): prune old builds
7085 (BuildStatus.pruneSteps): .. and steps
7086 (BuildStepStatus.pruneLogs): .. and logs
7087 (BuilderStatus.getBuild): handle missing builds
7088 * buildbot/status/html.py (StatusResourceBuild.body): display build
7089 status in the per-build page
7090 (BuildBox.getBox): color finished builds in the per-build box
7092 2004-08-27 Brian Warner <warner@lothar.com>
7094 * buildbot/status/mail.py (MailNotifier): new notification class,
7097 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
7098 variants of a common base class which handles all the mode= logic
7100 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
7102 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
7104 2004-08-26 Brian Warner <warner@lothar.com>
7106 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
7109 * buildbot/test/test_run.py: update to new Logfile interface, new
7110 buildbot.slave modules
7111 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
7113 * MANIFEST.in: new sample config file
7114 * docs/examples/hello.cfg: same
7116 * buildbot/process/step_twisted.py: remove dead import
7118 * buildbot/process/step.py (RemoteCommand.run): catch errors
7120 (RemoteCommand.remote_update): ignore updates that arrive after
7122 (RemoteCommand.remote_complete): ignore duplicate complete msgs
7123 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
7124 the responsibilities of the subclass's methods
7125 (BuildStep.failed): catch errors during failure processing
7126 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
7127 (CVS): move to a mode= argument (described in docstring), rather
7128 than the ungainly clobber=/export=/copydir= combination.
7129 (SVN): add mode= functionality to SVN too
7130 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
7132 * buildbot/process/base.py (Build.startNextStep): catch errors
7133 during s.startStep()
7135 * buildbot/clients/base.py: update to new PB client interface.
7136 gtkPanes is still broken
7138 * buildbot/bot.py, buildbot/slavecommand.py: move to..
7139 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
7140 * setup.py: add buildbot.slave module
7141 * buildbot/bb_tap.py: handle move
7142 * buildbot/slave/registry.py: place to register commands, w/versions
7143 * buildbot/slave/bot.py: major simplifications
7144 (SlaveBuilder.remote_startCommand): use registry for slave commands,
7145 instead of a fixed table. Eventually this will make the slave more
7146 extensible. Use 'start' method on the command, not .startCommand.
7147 Fix unsafeTracebacks handling (I think).
7148 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
7149 helper class with a .start method that returns a Deferred.
7150 SlaveShellCommand is the form reached by the buildmaster. Commands
7151 which use multiple ShellCommands can just chain them as Deferreds,
7152 with some helper methods in Command (_abandonOnFailure and
7153 _checkAbandoned) to bail on rc!=0.
7154 (CVSCommand): prefer new mode= argument
7155 (SVNFetch): add mode= argument
7157 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
7158 put a useful reason string on the build
7160 * buildbot/status/builder.py (LogFile): do LogFile right: move the
7161 core functionality into an IStatusLog object
7162 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
7163 * buildbot/status/html.py (TextLog): HTML-rendering goes here
7164 (StatusResourceBuild.body): use proper accessor methods
7165 * buildbot/status/client.py (RemoteLog): PB-access goes here
7166 (StatusClientPerspective.perspective_subscribe): add "full" mode,
7167 which delivers log contents too
7168 (PBListener.__cmp__): make PBListeners comparable, thus removeable
7169 * buildbot/status/event.py: remove old Logfile completely
7171 * buildbot/interfaces.py (IStatusLog.subscribe): make the
7172 subscription interface for IStatusLog subscriptions just like all
7173 other the status subscriptions
7174 (IStatusReceiver.logChunk): method called on subscribers
7176 2004-08-24 Brian Warner <warner@lothar.com>
7178 * buildbot/process/builder.py (Builder._pong): oops, ping response
7179 includes a result (the implicit None returned by remote_print).
7180 Accept it so the _pong method handles the response correctly.
7182 2004-08-06 Brian Warner <warner@lothar.com>
7184 * buildbot/test/test_config.py: update IRC, PBListener tests
7186 * buildbot/status/client.py (StatusClientPerspective): total
7187 rewrite to match new IStatus interfaces. New subscription scheme.
7188 There are still a few optimizations to make (sending down extra
7189 information with event messages so the client doesn't have to do a
7190 round trip). The logfile-retrieval code is probably still broken.
7191 Moved the PB service into its own port, you can no longer share a
7192 TCP socket between a PBListener and, say, the slaveport (this
7193 should be fixed eventually).
7194 * buildbot/clients/base.py (Client): revamp to match. still needs
7195 a lot of work, but basic event reporting works fine. gtkPanes is
7198 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
7199 instance talks to a single irc server. Threw out all the old
7200 multi-server handling code. Still need to add back in
7201 builder-control (i.e. "force build")
7203 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
7204 more random text to the as-yet-unreachable per-step page
7206 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
7207 rename to stepETAUpdate
7208 (BuildStatus.subscribe): add build-wide ETA updates
7209 (BuilderStatus.getState): remove more cruft
7210 (BuilderStatus.getCurrentBuild): remove more cruft
7211 (BuilderStatus.buildStarted): really handle tuple-subscription
7212 * buildbot/test/test_run.py (Status.testSlave): handle the
7213 stepETAUpdate rename
7215 * buildbot/master.py (BuildMaster): don't add a default
7216 StatusClientService. Don't add a default IrcStatusFactory. Both
7217 are now added through c['status'] in the config file. c['irc'] is
7218 accepted for backwards compatibility, the only quirk is you cannot
7219 use c['irc'] to specify IRC servers on ports other than 6667.
7221 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
7222 (IStatusReceiver.buildStarted): allow update-interval on subscribe
7223 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
7224 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
7227 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
7228 the buildmaster to re-read its config file
7231 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
7232 find out the port our server is running on
7233 (WebTest.test_webPathname_port): same
7235 * buildbot/test/test_config.py (testWebPortnum): test it
7236 (testWebPathname): ditto
7238 * docs/config.xhtml: document new c['status'] configuration option
7240 * buildbot/status/html.py (Waterfall): new top-level class which
7241 can be added to c['status']. This creates the Site as well as the
7242 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
7243 reachable as .parent, for everything.
7245 * buildbot/master.py (Manhole): make it a normal service Child
7246 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
7247 webPathname. It will eventually replace c['irc'] and the implicit
7248 PB listener as well. c['webPortnum'] and c['webPathname'] are left
7249 in as (deprecated) backward compatibility hooks for now.
7252 * buildbot/process/builder.py (Builder.buildFinished): don't
7253 inform out builder_status about a finished build, as it finds out
7254 through its child BuildStatus object
7256 * buildbot/status/html.py: extensive revamp. Use adapters to make
7257 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
7258 have both starting and finishing times and adjust the waterfall
7259 display accordingly, using spacers if necessary. Use SlaveStatus
7260 to get buildslave info.
7261 (StatusResourceBuildStep): new just-one-step resource, used to get
7262 logfiles. No actual href to it yet.
7264 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
7265 the time being, until I get the file-naming scheme right
7267 * buildbot/status/builder.py (Event): clean started/finished names
7268 (BuildStatus.isFinished): .finished is not None is the right test
7269 (BuildStatus.buildStarted): track started/finished times ourselves
7270 (BuilderStatus.getSlave): provide access to SlaveStatus object
7271 (BuilderStatus.getLastFinishedBuild): all builds are now in
7272 .builds, even the currently-running one. Accomodate this change.
7273 (BuilderStatus.eventGenerator): new per-builder event generator.
7274 Returns BuildStepStatus and BuildStatus objects, since they can
7275 both be adapted as necessary.
7276 (BuilderStatus.addEvent): clean up started/finished attributes
7277 (BuilderStatus.startBuild,finishBuild): remove dead code
7278 (SlaveStatus): new object to provide ISlaveStatus
7280 * buildbot/process/step.py (ShellCommand.getColor): actually
7281 return the color instead of setting it ourselves
7282 (CVS.__init__): pull .timeout and .workdir options out of
7283 **kwargs, since BuildStep will ignore them. Without this neither
7284 will be sent to the slave correctly.
7285 (SVN.__init__): same
7287 * buildbot/process/builder.py (Builder): move flags to class-level
7289 (Builder.attached): remove .remoteInfo, let the BotPerspective and
7290 SlaveStatus handle that
7292 * buildbot/process/base.py (Build.firstEvent): remove dead code
7293 (Build.stopBuild): bugfix
7295 * buildbot/changes/pb.py (PBChangeSource.describe): add method
7297 * buildbot/changes/changes.py (Change): add IStatusEvent methods
7298 (ChangeMaster.eventGenerator): yield Changes, since there are now
7299 Adapters to turn them into HTML boxes
7301 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
7302 (BotPerspective.attached): feed a SlaveStatus object
7303 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
7304 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
7306 * buildbot/interfaces.py: API additions
7307 (ISlaveStatus): place to get slave status
7309 2004-08-04 Brian Warner <warner@lothar.com>
7311 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
7312 the delay finishes, so the step is marked as SUCCESS
7314 * buildbot/test/test_run.py (Status.testSlave): cover more of
7315 IBuildStatus and IBuildStepStatus
7317 * buildbot/status/progress.py (StepProgress): move some flags to
7318 class-level attributes
7319 (StepProgress.remaining): if there are no other progress metrics
7320 to go by, fall back to elapsed time
7321 (StepProgress.setExpectations): take a dict of metrics instead of
7323 (BuildProgress.setExpectationsFrom): pull expectations from the
7324 Expectations, instead of having it push them to the BuildProgress
7325 (Expectations): move some flags to class-level attributes
7326 (Expectations.__init__): copy per-step times from the
7328 (Expectations.expectedBuildTime): new method for per-build ETA
7330 * buildbot/status/event.py (Logfile): move some flags to
7331 class-level attributes
7332 (Logfile.logProgressTo): better method name, let step set the
7333 progress axis name (instead of always being "output")
7335 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
7336 times directly, rather than depending upon the (possibly missing)
7337 .progress object. Use 'None' to indicate "not started/finished
7339 (BuildStepStatus.getExpectations): oops, return the full list of
7341 (BuilderStatus._buildFinished): append finished builds to .builds
7343 * buildbot/process/step.py (BuildStep): add separate .useProgress
7344 flag, since empty .progressMetrics[] still implies that time is a
7346 (CVS): set up the cmd in __init__, instead of waiting for start()
7348 * buildbot/process/base.py (Build.startBuild): disable the 'when'
7349 calculation, this will eventually turn into a proper sourceStamp
7350 (Build.setupBuild): tell the Progress to load from the Expectations,
7351 instead of having the Expectations stuff things into the Progress
7352 (Build.buildException): add a build-level errback to make sure the
7353 build's Deferred fires even in case of exceptions
7355 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
7357 * buildbot/process/builder.py (Builder.forceBuild): convey the
7358 reason instead of creating a fake Change
7360 * docs/examples/twisted_master.cfg: update to match reality
7362 * buildbot/test/test_config.py, buildbot/test/test_process.py:
7363 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
7364 fix or remove broken/breaking tests
7366 * buildbot/status/event.py (Logfile.__len__): remove evil method
7368 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
7369 missing .build, for test convenience
7371 * buildbot/process/step_twisted.py: import fixes
7373 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
7375 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
7376 .statusbag reference
7378 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
7379 connection at shutdown, and stop it from reconnecting
7381 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
7382 chase down remote-execution bugs
7384 * buildbot/process/step.py: more fixes, remove
7385 BuildStep.setStatus()
7386 * buildbot/status/builder.py: move setStatus() functionality into
7388 * buildbot/status/event.py: minor fixes
7390 2004-08-03 Brian Warner <warner@lothar.com>
7392 * buildbot/process/base.py, buildbot/process/builder.py
7393 * buildbot/process/step.py, buildbot/status/builder.py
7394 * buildbot/status/event.py, buildbot/test/test_run.py:
7395 fix status delivery, get a basic test case working
7396 * buildbot/master.py: finish implementing basic status delivery,
7397 temporarily disable HTML/IRC/PB status sources
7399 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
7401 * buildbot/status/progress.py (BuildProgress): remove dead code
7403 * buildbot/interfaces.py
7404 * buildbot/process/base.py, buildbot/process/builder.py
7405 * buildbot/process/step.py, buildbot/process/step_twisted.py
7406 * buildbot/status/builder.py: Complete overhaul of the all
7407 status-delivery code, unifying all types of status clients (HTML,
7408 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
7409 look like. This commit is a checkpointing of the work-in-progress:
7410 the input side is mostly done (Builders/Builds sending status
7411 to the BuilderStatus/BuildStatus objects), but the output side has
7412 not yet been started (HTML resources querying BuilderStatus
7413 objects). Things are probably very broken right now and may remain
7414 so for several weeks, I apologize for the disruption.
7416 * buildbot/status/event.py: add a setHTML method to use pre-rendered
7417 HTML as the log's contents. Currently used for exception tracebacks.
7418 * buildbot/status/progress.py: minor spelling changes
7420 2004-08-02 Brian Warner <warner@lothar.com>
7422 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
7423 in mozilla. Also added stylesheets copied from Twisted's docs.
7424 Remember that these files are meant to be run through Lore first.
7425 Thanks to Philipp Frauenfelder for the fixes.
7426 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
7427 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
7428 * docs/template.tpl: added a Lore template
7430 2004-07-29 Brian Warner <warner@lothar.com>
7432 * buildbot/interfaces.py: revamp status delivery. This is the
7433 preview: these are the Interfaces that will be provided by new
7434 Builder code, and to which the current HTML/IRC/PB status
7435 displayers will be adapted.
7437 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
7438 on the SlaveBuilder, not the Bot.
7439 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
7441 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
7442 set .usePTY on the FakeSlaveBuilder
7444 2004-07-25 Brian Warner <warner@lothar.com>
7446 * buildbot/changes/freshcvs.py: add some debug log messages
7447 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
7448 disabled 'setFilter' syntax
7449 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
7450 don't end with a slash
7452 * buildbot/process/base.py (Builder._pong_failed): add TODO note
7454 * setup.py: bump to 0.5.0+ while between releases
7456 2004-07-23 Brian Warner <warner@lothar.com>
7458 * setup.py (version): Releasing buildbot-0.5.0
7460 2004-07-23 Brian Warner <warner@lothar.com>
7462 * README: update for 0.5.0 release
7464 * NEWS: update for 0.5.0 release
7466 2004-07-22 Brian Warner <warner@lothar.com>
7468 * buildbot/slavecommand.py (ShellCommand): make usePTY a
7469 mktap-time configuration flag (--usepty=1, --usepty=0)
7470 * buildbot/bot.py: same
7472 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
7473 an 'info' directory being unwanted
7475 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
7476 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
7477 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
7478 and earlier), use a FreshCVSSourceOldcred instead.
7479 (test): simple test routine: connect to server, print changes
7481 * buildbot/changes/changes.py (Change.getTime): make it possible
7482 to print un-timestamped changes
7484 * buildbot/master.py (makeApp): delete ancient dead code
7485 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
7486 * buildbot/test/test_config.py (testFindConfigFile): test it
7488 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
7489 instead of win32 one
7492 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
7493 now takes a dictionary instead of a tuple. See docs/config.xhtml for
7496 * buildbot/process/base.py (Builder.__init__): change constructor
7497 to accept a dictionary of config data, rather than discrete
7498 name/slave/builddir/factory arguments
7500 * docs/examples/twisted_master.cfg: update to new syntax
7501 * docs/examples/glib_master.cfg: same
7502 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7503 rough tests of the new syntax
7506 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7507 to be an int, which means "run a web.distrib sub-server on a TCP
7508 port". This lets you publish the buildbot status page to a remote
7509 twisted.web server (using distrib.ResourceSubscription). Also
7510 rename the local attributes used to hold these web things so
7511 they're more in touch with reality.
7512 * buildbot/test/test_web.py: test webPortnum and webPathname
7513 * docs/config.xhtml: document this new use of webPathname
7515 * docs/config.xhtml: new document, slightly ahead of reality
7517 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7518 'prefix' handling: treat it as a simple string to check with
7519 .startswith, instead of treating it as a directory. This allows
7520 sub-directories to be used. If you use prefix=, you should give it
7521 a string that starts just below the CVSROOT and ends with a slash.
7522 This prefix will be stripped from all filenames, and filenames
7523 which do not start with it will be ignored.
7525 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7527 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7528 and --exclude (inverse of --include). SVN post-commit hooks
7529 now have total control over which changes get sent to buildbot and which
7532 2004-07-10 Brian Warner <warner@lothar.com>
7534 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7535 test case to match new API
7537 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7538 which crashed HTML display when self.entries=[] (needed to
7539 distinguish between [], which means "no entries yet", and None,
7540 which means "the entries have been swapped out to disk, go fetch
7543 2004-07-04 Brian Warner <warner@lothar.com>
7545 * buildbot/process/step_twisted.py (countFailedTests): Count
7546 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7547 10kb from the end because any import errors are wedged there and
7548 they would make us think the test log was unparseable.
7549 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7551 2004-06-26 Brian Warner <warner@lothar.com>
7553 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7554 delete-*.pyc command into an actual BuildStep, so we can label it
7556 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7557 (FullTwistedBuildFactory): same
7559 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7561 * contrib/fakechange.py: Add an errback when sending the fake
7562 change, so we know it didn't work.
7564 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7566 * buildbot/process/step_twisted.py: Delete *.pyc files before
7567 calling trial, so it doesn't catch any old .pyc files whose .py
7568 files have been moved or deleted.
7570 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7571 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7572 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7573 instead of ["twisted.test"], so that the end result is "trial -R
7576 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7577 regular expression to match filenames that should be ignored when
7578 changed. Also add a --revision parameter that specifies the
7579 revision to examine, which is useful for debugging.
7581 2004-06-25 Brian Warner <warner@lothar.com>
7583 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7584 summary of warnings (like DeprecationWarnings), next to the
7587 2004-05-13 Brian Warner <warner@lothar.com>
7589 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7590 we now have a w32 build slave courtesy of Mike Taylor.
7592 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7593 so broken. Fixed a race condition that tripped up interlocked
7594 builds and caused the status to be stuck at "Interlocked" forever.
7595 The twisted buildbot's one interlocked build just so happened to
7596 never hit this case until recently (the feeding builds both pass
7597 before the interlocked build is attempted.. usually it has to wait
7599 (Builder._pong_failed): fix method signature
7601 * setup.py: bump to 0.4.3+ while between releases
7603 2004-04-30 Brian Warner <warner@lothar.com>
7605 * setup.py (version): Releasing buildbot-0.4.3
7607 2004-04-30 Brian Warner <warner@lothar.com>
7609 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7611 * README: update for 0.4.3 release
7613 * NEWS: update for 0.4.3 release
7615 * buildbot/master.py (BuildMaster.__getstate__): make sure
7616 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7618 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7619 .trial as a class attribute, for upgrade from 0.4.2
7621 * buildbot/changes/changes.py (Change.links): add .links for
7624 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7625 .textWatchers and .htmlWatchers at save time, since they are both
7626 volatile, should allow smooth 0.4.2 upgrade
7628 * buildbot/process/step.py (CVS.finishStatus): catch failed
7629 CVS/SVN commands so we can make the status box red
7631 2004-04-29 Brian Warner <warner@lothar.com>
7633 * buildbot/changes/freshcvs.py
7634 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7635 code to do setFilter(), which tells the freshcvs daemon to not
7636 send us stuff that we're not interested in. I will uncomment it
7637 when a new version of CVSToys is available in which setFilter()
7638 actually works, and I get a chance to test it better.
7640 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7642 * buildbot/master.py (Dispatcher): use a registration scheme
7643 instead of hardwired service names
7644 (BuildMaster): keep track of the Dispatcher to support
7647 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7648 PBChangeSource class instead of having it be an undocumented
7649 internal feature of the ChangeMaster. Split out the code into a
7651 * buildbot/changes/pb.py (PBChangeSource): same
7652 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7654 * docs/{factories|sources|steps}.xhtml: document some pieces
7656 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7657 using FCMaildirSource
7658 (f23osx): update OS-X builder to use python2.3, since the slave
7659 was updated to Panther (10.3.3)
7661 2004-03-21 Brian Warner <warner@lothar.com>
7663 * buildbot/process/process_twisted.py: factor out doCheckout, change
7664 to use SVN instead of CVS
7666 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7667 an SVN subclass easier
7668 (BasicSVN): subclass which uses Subversion instead of CVS
7670 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7672 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7674 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7676 2004-02-25 Brian Warner <warner@lothar.com>
7678 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7679 is now either a list (which is passed to spawnProcess directly) or
7680 a string (which gets passed to /bin/sh -c). This removes the useSH
7681 flag and the ArgslistCommand class. Also send status header at the
7682 start and end of each command, instead of having the master-side
7684 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7685 -r'. Update to use list-based arguments.
7686 (SVNFetch): use list-based arguments, use ['dir'] argument to
7688 * buildbot/test/test_steps.py (Commands): match changes
7690 * buildbot/process/step.py (InternalShellCommand.words): handle
7692 (SVN): inherit from CVS, cleanup
7694 * buildbot/status/event.py (Logfile.content): render in HTML, with
7695 stderr in red and headers (like the name of the command we're
7696 about to run) in blue. Add link to a second URL (url + "?text=1")
7697 to get just stdout/stderr in text/plain without markup. There is
7698 still a problem with .entries=None causing a crash, it seems to occur
7699 when the logfile is read before it is finished.
7701 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7702 timeout to the keepalives, and use it to explicitly do a
7703 loseConnection instead of waiting for TCP to notice the loss. This
7704 ought to clear up the silent-lossage problem.
7705 (unsafeTracebacks): pass exception tracebacks back to the master,
7706 makes it much easier to debug problems
7708 2004-02-23 Brian Warner <warner@lothar.com>
7710 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7711 the whole command to /bin/sh instead of execve [Johan Dahlin]
7712 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7713 '-r HEAD' [Johan Dahlin]
7714 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7716 * buildbot/changes/changes.py (Change): add links= argument, add
7717 asHTML method [Johan Dahlin]. Modified to make a bit more
7718 XHTMLish. Still not sure how to best use links= .
7720 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7721 Change.asHTML to display the change, not asText
7723 * buildbot/status/html.py (StatusResourceBuilder): web button to
7726 * buildbot/test/test_run.py: test to actually start a buildmaster
7729 * MANIFEST.in: bring back accidentally-dropped test helper files
7731 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7732 that require cvstoys if it is not installed
7734 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7735 values of "bin/trial" [Dave Peticolas]
7736 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7737 tests passed" when we didn't happen to run any tests
7739 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7740 flunkOnFailure [Johan Dahlin]
7742 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7743 multiple instances of the same Step class by suffixing "_2", etc,
7744 to the name until it is unique. This name needs to be unique
7745 because it is used as a key in the dictionary that tracks build
7747 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7750 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7752 2004-01-14 Brian Warner <warner@lothar.com>
7754 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7755 kicked from a channel, log it
7757 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7758 something over whatever IRC channels the buildmaster is currently
7759 connected to. Added to try and track down a problem in which the
7760 master thinks it is still connected but the IRCd doesn't see it. I
7761 used a styles.Versioned this time, so hopefully users won't have
7762 to rebuild their .tap files this time.
7763 * contrib/debug.glade: add a "Poke IRC" button
7764 * contrib/debugclient.py: same
7766 * setup.py: bump to 0.4.2+ while between releases
7768 2004-01-08 Brian Warner <warner@lothar.com>
7770 * setup.py (version): Releasing buildbot-0.4.2
7772 2004-01-08 Brian Warner <warner@lothar.com>
7774 * NEWS: update for 0.4.2 release
7776 * README: document how to run the tests, now that they all pass
7778 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7780 * buildbot/process/step.py (CVS): add a global_options= argument,
7781 which lets you set CVS global options for the command like "-r"
7782 for read-only checkout, or "-R" to avoid writing in the
7784 * buildbot/slavecommand.py (CVSCommand): same
7786 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7787 testing easier (it is turned off when testing, to avoid the
7790 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7791 to make it easier to test: break generateStepID() out to a
7792 separate function, only update statusbag if it exists.
7793 (ShellCommands): create useful text for dict-based commands too.
7795 * test/*, buildbot/test/*: move unit tests under the buildbot/
7797 * setup.py (packages): install buildbot.test too
7799 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7800 * buildbot/test/test_steps.py: fix it, tests pass now
7802 2004-01-06 Brian Warner <warner@lothar.com>
7804 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7805 freshcvs mail uses a slightly different syntax for new
7806 directories. Update parser to handle either.
7807 * test/test_mailparse.py (Test1.testMsg9): test for same
7809 2003-12-21 Brian Warner <warner@lothar.com>
7811 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7812 'warnOnWarnings' so that lintian errors mark the build orange
7814 2003-12-17 Brian Warner <warner@lothar.com>
7816 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7817 messages emitted by Bonsai, contributed by Stephen Davis.
7819 * test/*: moved all tests to use trial instead of unittest. Some
7820 still fail (test_steps, test_slavecommand, and test_process).
7822 * setup.py (version): bump to 0.4.1+ while between releases
7824 2003-12-09 Brian Warner <warner@lothar.com>
7826 * setup.py (version): Releasing buildbot-0.4.1
7828 2003-12-09 Brian Warner <warner@lothar.com>
7830 * NEWS: update for 0.4.1 release
7832 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7833 freebsd builder code a little bit
7835 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7836 don't try to compare attributes of different classes
7837 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7838 (MaildirSource.messageReceived): fix Change delivery
7840 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7841 into the config file's namespace before loading it, like the
7842 documentation claims it does
7843 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7844 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7845 daemon comes back online
7847 2003-12-08 Brian Warner <warner@lothar.com>
7849 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7850 so the example will work with online=0 as well
7852 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7853 fix the __implements__ line
7855 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7856 class a twisted.application.service.Service, use startService to
7859 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7860 directory fd instead of simple open(). I'm sure this used to work,
7861 but the current version of python refuses to open directories with
7864 2003-12-05 Brian Warner <warner@lothar.com>
7866 * setup.py (version): bump to 0.4.0+ while between releases
7868 2003-12-05 Brian Warner <warner@lothar.com>
7870 * setup.py (version): Releasing buildbot-0.4.0
7872 2003-12-05 Brian Warner <warner@lothar.com>
7874 * docs/examples/glib_master.cfg: replace old sample scripts with
7875 new-style config files
7876 * MANIFEST.in: include .cfg files in distribution tarball
7878 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7879 implement a dummy method to avoid the exception that occurs when
7880 freshcvs sends this to us.
7882 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7883 removed the method, as it broke reconnection. Apparently
7884 stopFactory is called each time the connection attempt fails. Must
7886 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7887 attribute before serialization, since without stopFactory the
7888 reconnect timer may still be active and they aren't serializable.
7890 * test/test_mailparse.py (ParseTest): test with 'self' argument
7892 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7893 argument, as these "functions" are invoked like methods from class
7894 attributes and therefore always get an instance as the first
7897 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7898 message: thanks to Stephen Davis for the catch
7900 2003-12-04 Brian Warner <warner@lothar.com>
7902 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7903 twisted's standard ReconnectingClientFactory. Handles both oldcred
7904 and newcred connections. Also has a bug-workaround for
7905 ReconnectingClientFactory serializing its connector when it
7908 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7909 pbutil. Replace makeApp stuff with proper newcred/mktap
7910 makeService(). Don't serialize Ephemerals on shutdown.
7912 * buildbot/changes/changes.py (ChangeMaster): make it a
7913 MultiService and add the sources as children, to get startService
7914 and stopService for free. This also gets rid of the .running flag.
7916 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7917 new pbutil, turn into a TCPClient at the same time (to get
7918 startService for free). Two variants exist: FreshCVSSourceOldcred
7919 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7920 yet, but when it does, we'll be ready).
7921 (FreshCVSSource.notify): handle paths which are empty after the
7922 prefix is stripped. This only happens when the top-level (prefix)
7923 directory is added, at the very beginning of a Repository's life.
7925 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7926 Now the only reconnecting code is in the factory where it belongs.
7927 (Builder.unsubscribe): unregister the disconnect callback when we
7928 delete the builder on command from the master (i.e. when the
7929 buildmaster is reconfigured and that builder goes away). This
7930 fixes a multiple-delete exception when the status client is shut
7932 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7935 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7936 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7938 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7940 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7941 a list of globs (ugh). The testdir will be searched for files
7942 named *.tests and run the tests in the order specified in each of
7943 those files. This allows for "dependancies" between tests to be
7946 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7947 argument to pass to run_maxq.py, instead of a glob.
7949 2003-10-17 Brian Warner <warner@lothar.com>
7951 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7952 files that live in the sandbox
7954 2003-10-15 Brian Warner <warner@lothar.com>
7956 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7957 spelling error in "docs" count-warnings output
7958 (HLint.start): stupid thinko meant .xhtml files were ignored
7960 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7961 tests now that cReactor is banished to the sandbox
7963 2003-10-10 Brian Warner <warner@lothar.com>
7965 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7966 scheme: now .xhtml are sources and .html are generated
7968 2003-10-08 Brian Warner <warner@lothar.com>
7970 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7971 we were ignoring the 'randomly' parameter.
7973 2003-10-01 Brian Warner <warner@lothar.com>
7975 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7976 posix, to kill sub-children of aborted slavecommands.
7978 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7979 Clean up initialization: lastBuildStatus remains None until the
7980 first build has been completed.
7982 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7983 None as a lastBuildStatus
7984 * buildbot/clients/gtkPanes.py: same
7986 * buildbot/status/client.py (StatusClientService): keep
7987 BuilderStatus objects in self.statusbags . These objects now live
7988 here in the StatusClientService and are referenced by the Builder
7989 object, rather than the other way around.
7990 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7991 * buildbot/process/base.py (Builder): same
7992 * test/test_config.py (ConfigTest.testBuilders): same
7994 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7995 an existing builder, leave the statusbag alone. This will preserve the
7998 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7999 hook. This will probably go away in favor of a class in upcoming
8002 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
8003 serviceName from newcred FreshCVSNotifiee setup
8005 2003-09-29 Brian Warner <warner@lothar.com>
8007 * buildbot/process/process_twisted.py: switch to new reactor
8009 * docs/examples/twisted_master.cfg: same
8011 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
8013 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
8014 botmaster reference instead of the oldapp service lookup
8016 * buildbot/master.py (BuildMaster.__init__): give the
8017 StatusClientService a reference to the botmaster to make it easier to
8020 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
8022 * buildbot/status/html.py (Box.td): escape hreffy things so you
8023 can have spaces in things like builder names
8024 (StatusResourceBuilder.body)
8025 (WaterfallStatusResource.body)
8026 (WaterfallStatusResource.body0): same
8028 2003-09-25 Brian Warner <warner@lothar.com>
8030 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
8031 rearrange the builder list when adding or removing builders: keep
8032 them in the order the user requested.
8033 * test/test_config.py (ConfigTest.testBuilders): verify it
8035 * contrib/debug.glade: give the debug window a name
8037 * buildbot/process/base.py (Builder.buildTimerFired): builders can
8038 now wait on multiple interlocks. Fix code relating to that.
8039 (Builder.checkInterlocks): same
8040 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
8042 * buildbot/master.py (BuildMaster.loadConfig): move from
8043 deprecated pb.BrokerFactory to new pb.PBServerFactory
8044 * test/test_config.py (ConfigTest.testWebPathname): same
8046 * docs/examples/twisted_master.cfg: fix interlock declaration
8048 * buildbot/master.py (BotMaster.addInterlock): move code to attach
8049 Interlocks to their Builders into interlock.py .
8050 (BuildMaster.loadConfig_Interlocks): fix interlock handling
8052 * test/test_config.py (ConfigTest.testInterlocks): validate
8055 * buildbot/process/base.py (Builder.__init__): better comments
8056 * buildbot/process/interlock.py (Interlock.__repr__): same
8057 (Interlock.deactivate): add .active flag, move the code that
8058 attaches/detaches builders into the Interlock
8060 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
8062 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
8063 tests using the new run_maxq.py script, and reporting failures by
8066 * contrib/run_maxq.py: Hacky little script for running a set of maxq
8067 tests, reporting their success or failure in a buildbot-friendly
8070 2003-09-24 Brian Warner <warner@lothar.com>
8072 * docs/examples/twisted_master.cfg: example of a new-style config
8073 file. This lives in the buildmaster base directory as
8076 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
8077 button to make the master re-read its config file
8079 * buildbot/master.py (BuildMaster.loadConfig): new code to load
8080 buildmaster configuration from a file. This file can be re-read
8081 later, and the buildmaster will update itself to match the new
8082 desired configuration. Also use new Twisted Application class.
8083 * test/Makefile, test/test_config.py: unit tests for same
8085 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
8086 FreshCVSSources comparable, to support reload.
8087 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
8089 * buildbot/process/base.py (Builder): make them comparable, make
8090 Interlocks easier to attach, to support reload. Handle
8091 re-attachment of remote slaves.
8092 * buildbot/process/interlock.py (Interlock): same
8094 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
8095 Twisted's new Application class. Requires Twisted >= 1.0.8 .
8096 buildmaster taps are now constructed with mktap.
8097 * buildbot/status/client.py (StatusClientService): same
8099 * buildbot/status/words.py: move to new Services, add support to
8100 connect to multiple networks, add reload support, allow nickname
8101 to be configured on a per-network basis
8103 2003-09-20 Brian Warner <warner@lothar.com>
8105 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
8106 the freebsd builder, now that the machine has been upgraded and no
8107 longer has python2.2
8109 * setup.py (version): bump to 0.3.5+ while between releases
8111 2003-09-19 Brian Warner <warner@lothar.com>
8113 * setup.py (version): Releasing buildbot-0.3.5
8115 2003-09-19 Brian Warner <warner@lothar.com>
8117 * NEWS: add post-0.3.4 notes
8119 * README (REQUIREMENTS): note twisted-1.0.7 requirement
8121 * MANIFEST.in: add contrib/*
8123 * docs/examples/twisted_master.py (twisted_app): all build slaves must
8124 use a remote root now: cvs.twistedmatrix.com
8126 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
8128 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
8129 compatibility with old servers
8130 (FreshCVSSource.start): and provide a way to use it
8131 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
8133 * docs/examples/twisted_master.py (twisted_app): update to new
8135 (twisted_app): listen on new ~buildbot socket
8136 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
8138 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
8139 to reduce cvs bandwidth (update instead of full checkout)
8141 2003-09-11 Brian Warner <warner@lothar.com>
8143 * contrib/fakechange.py: demo how to connect to the changemaster
8144 port. You can use this technique to submit changes to the
8145 buildmaster from source control systems that offer a hook to run a
8146 script when changes are committed.
8148 * contrib/debugclient.py: tool to connect to the debug port. You
8149 can use it to force builds, submit fake changes, and wiggle the
8152 * buildbot/master.py: the Big NewCred Reorganization. Use a single
8153 'Dispatcher' realm to handle all the different kinds of
8154 connections and Perspectives: buildslaves, the changemaster port,
8155 the debug port, and the status client port. NewCredPerspectives
8156 now have .attached/.detached methods called with the remote 'mind'
8157 reference, much like old perspectives did. All the pb.Services
8158 turned into ordinary app.ApplicationServices .
8159 (DebugService): went away, DebugPerspectives are now created
8160 directly by the Dispatcher.
8161 (makeApp): changed interface a little bit
8163 * buildbot/changes/changes.py: newcred
8164 * buildbot/status/client.py: newcred
8166 * buildbot/clients/base.py: newcred client side changes
8167 * buildbot/bot.py: ditto
8169 * docs/examples/glib_master.py: handle new makeApp() interface
8170 * docs/examples/twisted_master.py: ditto
8172 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
8173 base newcred Perspectives on. This should go away once Twisted
8174 itself provides something sensible.
8177 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
8179 * contrib/svn_buildbot.py: A program that you can call from your
8180 SVNREPO/hooks/post-commit file that will notify a BuildBot master
8181 when a change in an SVN repository has happened. See the top of
8182 the file for some minimal usage info.
8184 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8186 * buildbot/slavecommand.py (ArglistCommand): Add new
8187 ArglistCommand that takes an argument list rather than a string as
8188 a parameter. Using a st.split() for argv is very bad.
8190 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
8191 update to a particular revision rather than always checking out
8192 (still not very smart about it, there may be cases where the
8193 checkout becomes inconsistent).
8195 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8197 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
8198 SVN fetch support. It can checkout (not update!) a specified
8199 revision from a specified repository to a specified directory.
8201 * buildbot/status/progress.py (Expectations.update): Fix an
8202 obvious bug (apparently created by the change described in the
8203 previous ChangeLog message) by moving a check to *after* the
8204 variable it checks is defined.
8207 2003-09-08 Brian Warner <warner@lothar.com>
8209 * buildbot/status/progress.py (Expectations.update): hack to catch
8210 an exception TTimo sees: sometimes the update() method seems to
8211 get called before the step has actually finished, so the .stopTime
8212 is not set, so no totalTime() is available and we average None
8213 with the previous value. Catch this and just don't update the
8214 metrics, and emit a log message.
8216 2003-08-24 Brian Warner <warner@lothar.com>
8218 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
8219 parameter to set copydir='original' in CVS commands.
8221 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
8223 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
8224 which tells the command to maintain a separate original-source CVS
8225 workspace. For each build, this workspace will be updated, then
8226 the tree copied into a new workdir. This reduces CVS bandwidth
8227 (from a full checkout to a mere update) while doubling the local
8228 disk usage (to keep two copies of the tree).
8230 2003-08-21 Brian Warner <warner@lothar.com>
8232 * buildbot/status/event.py (Logfile.addEntry): if the master web
8233 server dies while we're serving a page, request.write raises
8234 pb.DeadReferenceError . Catch this and treat it like a
8235 notifyFinish event by dropping the request.
8237 2003-08-18 Brian Warner <warner@lothar.com>
8239 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
8240 (instead of blowing up) if a force-build command is given without
8243 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
8244 don't blow up if there aren't yet any Changes in the list
8246 2003-08-02 Brian Warner <warner@lothar.com>
8248 * buildbot/bot.py (updateApplication): don't set the .tap name,
8249 since we shouldn't assume we own the whole .tap file
8251 * buildbot/bb_tap.py (updateApplication): clean up code, detect
8252 'mktap buildbot' (without a subcommand) better
8254 2003-07-29 Brian Warner <warner@lothar.com>
8256 * buildbot/status/words.py
8257 (IrcStatusFactory.clientConnectionLost): when we lose the
8258 connection to the IRC server, schedule a reconnection attempt.
8260 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
8261 use shutil.rmtree instead of forking off an "rm -rf" command.
8262 rmtree may take a while and will block until it finishes, so we
8263 use "rm -rf" if available.
8265 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
8266 freebsd buildslave badly
8268 * setup.py (version): bump to 0.3.4+ while between releases
8270 2003-07-28 Brian Warner <warner@lothar.com>
8272 * setup.py (version): Releasing buildbot-0.3.4
8274 2003-07-28 Brian Warner <warner@lothar.com>
8276 * NEWS: update in preparation for release
8278 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
8279 process.signalProcess instead of os.kill, to improve w32
8282 * docs/examples/twisted_master.py (twisted_app): turn off
8283 win32eventreactor: the tests hang the buildslave badly
8285 * buildbot/process/base.py (Build.buildFinished): update ETA even on
8286 failed builds, since usually the failures are consistent
8288 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8289 add compileOpts/compileOpts2 to reactors build
8291 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
8292 (twisted_app): use both default and win32eventreactor on w32 build.
8293 Use both default and kqreactor on freebsd build.
8295 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8296 add compileOpts2, which is put after the build_ext argument. w32
8297 needs "-c mingw32" here.
8299 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
8300 touch .acqpath, it goes away in recent Twisted releases
8302 * docs/examples/twisted_master.py (twisted_app): use "python" for
8303 the w32 buildslave, not "python2.2"
8305 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
8306 the directory exists.. should hush an exception under w32
8308 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
8309 ProcessTerminated -provided values for signal and exitCode rather
8310 than parsing the unix status code directly. This should remove one
8311 more roadblock for a w32-hosted buildslave.
8313 * test/test_mailparse.py: add test cases for Syncmail parser
8315 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
8316 temporary compatibility import. Note! Start importing
8317 FCMaildirSource from changes.mail instead of changes.freshcvsmail
8319 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
8321 2003-07-27 Brian Warner <warner@lothar.com>
8323 * NEWS: started adding new features
8325 * buildbot/changes/mail.py: start work on Syncmail parser, move
8326 mail sources into their own file
8328 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
8329 as implementing IChangeSource
8330 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
8332 * buildbot/interfaces.py: define the IChangeSource interface
8334 2003-07-26 Brian Warner <warner@lothar.com>
8336 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
8338 2003-06-25 Brian Warner <warner@lothar.com>
8340 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
8343 2003-06-17 Brian Warner <warner@lothar.com>
8345 * buildbot/status/words.py: clean up method usage to avoid error
8346 in silly IRC command
8347 (IrcStatusBot.emit_status): round off seconds display
8349 * buildbot/process/base.py (Build): delete the timer when saving
8350 to the .tap file, and restore it (if it should still be running)
8351 upon restore. This should fix the "next build in -34 seconds"
8352 messages that result when the master is restarted while builds are
8353 sitting in the .waiting slot. If the time for the build has
8354 already passed, start it very soon (in 1 second).
8356 * buildbot/status/words.py: more silly commands
8358 * README (REQUIREMENTS): add URLs to all required software
8360 * buildbot/status/words.py ('last'): mention results of, and time
8363 2003-05-28 Brian Warner <warner@lothar.com>
8365 * buildbot/status/words.py: add 'last' command
8366 (IrcStatusBot.emit_status): add current-small text to 'status' output
8368 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
8369 (twisted_app): remove spaces from OS-X builder name
8371 * buildbot/master.py (makeApp): add knob to turn on IRC bot
8372 * buildbot/status/words.py: IRC bot should actually be useful now
8374 2003-05-23 Brian Warner <warner@lothar.com>
8376 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
8377 "slave information" from $(slavedir)/info/* . These files are
8378 maintained by the slave administrator, and describe the
8379 machine/environment that is hosting the slave. Information from
8380 them is put into the "Builder" HTML page. Still need to establish
8381 a set of well-known filenames and meanings for this data: at the
8382 moment, *all* info/* files are sent to the master, but only
8383 'admin' and 'host' are used on that end.
8384 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
8385 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
8386 * buildbot/master.py (BotPerspective.got_info): ditto
8388 2003-05-22 Brian Warner <warner@lothar.com>
8390 * setup.py (version): bump version to 0.3.3+ while between releases
8392 2003-05-21 Brian Warner <warner@lothar.com>
8394 * setup.py: Releasing buildbot-0.3.3
8396 2003-05-21 Brian Warner <warner@lothar.com>
8398 * NEWS: 0.3.3 news items
8400 * README: describe --keepalive and life behind a NAT box
8402 * buildbot/bot.py (Bot.connected): implement application-level
8403 keepalives to deal with NAT timeouts, turn them on with
8404 --keepalive option or when SO_KEEPALIVE doesn't work.
8406 * buildbot/master.py (BotPerspective): accept keepalives silently
8408 * buildbot/process/base.py (Build.buildException): CopiedFailures
8409 don't carry as much information as local ones, so don't try to
8410 create a big HTMLized version of them.
8412 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
8413 log file when step fails due to an exception, such as when the slave
8416 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
8417 --testmodule argument instead of grepping for test-case-name tags
8418 ourselves. Remove FindUnitTests code.
8419 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
8421 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
8423 2003-05-16 Brian Warner <warner@lothar.com>
8425 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
8426 argument to allow things like CFLAGS=-O0 to be passed without relying
8427 upon /bin/sh processing on the slave.
8429 * buildbot/process/step.py (InternalShellCommand.start): send
8431 * buildbot/slavecommand.py (ShellCommand.start): create argv with
8432 'split' instead of letting /bin/sh do it. This should also remove
8433 the need for /bin/sh on the buildslave, making it more likely to
8436 * buildbot/status/html.py: html-escape text in blamelist.
8437 Add "force build" button to the Builder page.
8439 * buildbot/process/step_twisted.py (countFailedTests): look at
8440 last 1000 characters for status line, as import errors can put it
8441 before the -200 point.
8443 2003-05-15 Brian Warner <warner@lothar.com>
8445 * docs/examples/twisted_master.py: use clobber=0 for remote builds
8447 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8448 make 'clobber' a parameter, so it is possible to have builds which
8449 do full tests but do a cvs update instead of hammering the CVS
8450 server with a full checkout each build
8452 * buildbot/process/step.py (InternalShellCommand): bump default
8453 timeout to 20 minutes
8455 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
8456 the master to trigger a build. Run it via manhole.
8458 * buildbot/master.py (BotPerspective.perspective_forceBuild):
8459 allow slaves to trigger any build that they host, to make life
8460 easier for slave admins who are testing out new build processes
8462 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8463 don't flunk cReactor or qtreactor on failure, since they fail alot
8464 these days. Do warnOnFailure instead.
8466 * buildbot/process/base.py: change Builder.buildable from a list
8467 into a single slot. When we don't have a slave, new builds (once
8468 they make it past the timeout) are now merged into an existing
8469 buildable one instead of being queued. With this change, a slave
8470 which has been away for a while doesn't get pounded with all the
8471 builds it missed, but instead just does a single build.
8473 2003-05-07 Brian Warner <warner@lothar.com>
8475 * setup.py (version): bump version to 0.3.2+ while between releases
8477 2003-05-07 Brian Warner <warner@lothar.com>
8479 * setup.py: Releasing buildbot-0.3.2
8481 2003-05-07 Brian Warner <warner@lothar.com>
8483 * setup.py: fix major packaging error: include subdirectories!
8485 * NEWS: add changes since last release
8487 * README (REQUIREMENTS): update twisted/python dependencies
8489 * buildbot/status/builder.py (Builder.startBuild): change
8490 BuildProcess API: now they should call startBuild/finishBuild
8491 instead of pushing firstEvent / setLastBuildStatus. Moving towards
8492 keeping a list of builds in the statusbag, to support other kinds of
8494 (Builder.addClient): send current-activity-small to new clients
8495 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
8498 * buildbot/status/client.py: drop RemoteReferences at shutdown
8500 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8502 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8503 more debug messages for remote status client
8505 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8506 (.stepFailed): only fire the Deferred once, even if both
8507 stepComplete and stepFailed are called. I think this can happen if
8508 an exception occurs at a weird time.
8510 * buildbot/status/words.py: work-in-progress: IRC status delivery
8512 2003-05-05 Brian Warner <warner@lothar.com>
8514 * docs/examples/twisted_master.py (twisted_app): hush internal
8515 python2.3 distutils deprecation warnings
8516 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8517 add compileOpts= argument which inserts extra args before the
8518 "setup.py build_ext" command. This can be used to give -Wignore
8519 warnings, to hush some internal python-2.3 deprecation messages.
8521 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8522 the ['twisted.test'] default test case to make it easier to change
8525 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8526 * buildbot/clients/gtkPanes.py: ditto
8528 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8529 arg to collapse RunUnitTestsRandomly into RunUnitTests
8530 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8531 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8533 * buildbot/status/html.py (StatusResource): shuffle Resources
8534 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8535 would serve the waterfall display, but the internal links were
8536 only valid on the trailing-slash version. The correct behavior is
8537 for the non-slashed one to serve a Redirect to the slashed one.
8538 This only shows up when the buildbot page is hanging off another
8539 server, like a Twisted-Web distributed server.
8541 * buildbot/status/event.py (Event, RemoteEvent): make Events
8542 pb.Cacheable, with RemoteEvent as the cached version. This removes
8543 a lot of explicit send-an-update code.
8544 * buildbot/status/builder.py (Builder): remove send-update code
8545 * buildbot/status/client.py (ClientBuilder): remove send-update
8546 code, and log errors that occur during callRemote (mostly to catch
8547 InsecureJelly exceptions)
8549 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8550 run Lore with the same python used in the rest of the build
8552 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8554 * buildbot/process/step_twisted.py (HLint): accept 'python'
8555 argument. Catch rc!=0 and mark the step as failed. This marks the
8556 build orange ("has warnings").
8557 (RunUnitTestsJelly): move out to step_twisted2.py
8559 * buildbot/util.py (ignoreStaleRefs): add utility function
8561 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8562 don't fake ETA object, it's too hard to get right
8564 2003-05-02 Brian Warner <warner@lothar.com>
8566 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8568 2003-05-01 Brian Warner <warner@lothar.com>
8570 * buildbot/status/html.py (StatusResource.body): oops, I was
8571 missing a <tr>, causing the waterfall page to be misrendered in
8572 everything except Galeon.
8574 2003-04-29 Brian Warner <warner@lothar.com>
8576 * docs/examples/twisted_master.py: make debuild use python-2.2
8577 explicitly, now that Twisted stopped supporting 2.1
8579 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8580 handle tuple results too. I keep forgetting this, which suggests
8581 it needs to be rethought.
8583 * setup.py (setup): bump version to 0.3.1+ while between releases
8585 2003-04-29 Brian Warner <warner@lothar.com>
8587 * setup.py: Releasing buildbot-0.3.1
8589 2003-04-29 Brian Warner <warner@lothar.com>
8591 * README (SUPPORT): add plea to send questions to the mailing list
8593 * NEWS, MANIFEST.in: add description of recent changes
8595 * docs/examples/twisted_master.py: add the code used to create the
8596 Twisted buildmaster, with passwords and such removed out to a
8599 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8600 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8601 buildmasters to not require CVSToys be installed.
8602 * README, docs/examples/glib_master: update to match the change
8604 * buildbot/clients/base.py, buildbot/bot.py,
8605 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8606 ReconnectingPB from CVSToys distribution to remove CVSToys
8607 dependency for build slaves and status clients. Buildmasters which
8608 use FreshCVSSources still require cvstoys be installed, of course.
8610 2003-04-25 Brian Warner <warner@lothar.com>
8612 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8613 runTestsRandomly arg to turn on trial -z
8615 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8616 experimental code to use trial's machine-parseable output to get
8617 more detailed test results. Still has some major issues.
8618 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8621 * buildbot/status/builder.py (Builder.setCurrentBuild):
8622 anticipating moving build history into statusbag, not used yet
8624 * buildbot/status/tests.py: code to centralize test results,
8625 doesn't work quite yet
8627 * buildbot/status/event.py (Event): use hasattr("setName") instead
8628 of isinstance for now.. need better long-term solution
8630 * buildbot/status/html.py: Remove old imports
8632 2003-04-24 Brian Warner <warner@lothar.com>
8634 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8635 ignore changes under doc/fun/ and sandbox/
8637 * buildbot/process/step_twisted.py: update pushEvent and friends.
8639 * buildbot/status/html.py (Box.td): replace event.buildername with
8640 event.parent.getSwappableName(). Needs more thought.
8642 * buildbot/status/builder.py (Builder): Replace pushEvent and
8643 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8644 Tell events they are being pruned with event.delete().
8646 * buildbot/process/base.py (Build): Remove Builder status-handling
8647 methods. s/pushEvent/setCurrentActivity/.
8649 * buildbot/process/step.py (BuildStep): clean up status delivery.
8650 Gouse builder.statusbag methods instead of intermediate builder
8651 methods. s/updateLastEvent/updateCurrentActivity/.
8652 s/finalizeLastEvent/finishCurrentActivity/. Use
8653 addFileToCurrentActivity for summaryFunction.
8655 * buildbot/status/event.py (Logfile): put data in a Swappable when
8657 (Event): add more setter methods. Remove .buildername, use .parent
8658 and getSwappableName instead (needs more thought).
8660 * buildbot/util.py (Swappable):
8661 * test/test_swap.py: don't bother setting filename at __init__
8662 time, do it later. Change setFilename args to take parent first,
8663 since it provides the most significant part of the filename.
8665 2003-04-23 Brian Warner <warner@lothar.com>
8667 * buildbot/status/event.py (Logfile.addEntry): append to previous
8670 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8671 anticipating Swappable
8672 (InternalShellCommand.remoteUpdate): split out various log-adding
8673 methods so subclasses can snarf stdout separately
8675 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8676 in anticipation of Swappable build logs
8677 (Builder.testsFinished): anticipating TestResults, still disabled
8679 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8682 * buildbot/status/event.py (Logfile): add (disabled) support for
8683 Swappable, not ready for use yet
8685 * buildbot/util.py (Swappable): object which is swapped out to
8686 disk after some period of no use.
8687 * test/test_swap.py: test buildbot.utils.Swappable
8689 2003-04-14 Brian Warner <warner@lothar.com>
8691 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8692 periodic-build timer. Set the .periodicBuildTime on a builder
8693 instance to some number of seconds to activate it.
8695 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8697 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8698 a way that survives result tuples
8700 2003-04-12 Brian Warner <warner@lothar.com>
8702 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8703 return a dict instead of a tuple: allow summarizers to provide
8704 multiple summaries if they want
8705 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8706 (debuildSummarizer): summarize lintian warnings/errors
8708 2003-04-10 Brian Warner <warner@lothar.com>
8710 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8712 2003-04-09 Brian Warner <warner@lothar.com>
8714 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8715 empty summaries: happens when the tests fail so hard they don't emit
8716 a parseable summary line.
8718 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8719 Allow summaryFunction to return None to indicate no summary should
8722 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8723 writing to stale HTTP requests: notice when they disconnect and
8724 remove the request from the list. Also add CacheToFile from
8725 moshez, will be used later.
8727 2003-04-08 Brian Warner <warner@lothar.com>
8729 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8730 should be an int, not a list of strings
8732 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8733 if we weren't actually connected
8735 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8736 to show the tail end of the trial text output
8738 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8739 hook to summarize the results of a ShellCommand
8741 2003-04-07 Brian Warner <warner@lothar.com>
8743 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8744 twisted test suite code into a single class.
8745 * buildbot/process/process_twisted.py: same
8747 2003-04-04 Brian Warner <warner@lothar.com>
8749 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8751 * README (SLAVE): document use of mktap to create slave .tap file
8752 (REQUIREMENTS): describe dependencies
8754 * buildbot/bb_tap.py, buildbot/plugins.tml:
8755 * buildbot/bot.py (updateApplication): Add mktap support for creating
8756 buildslave .tap files
8758 2003-03-28 Brian Warner <warner@lothar.com>
8760 * buildbot/process/step.py (InternalShellCommand.finished): handle
8761 new tuple result values (fix embarrasing bug that appeared during
8764 2003-03-27 Brian Warner <warner@lothar.com>
8766 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8769 2003-03-25 Brian Warner <warner@lothar.com>
8771 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8772 to overall build status
8773 * buildbot/clients/base.py (Builder): improve event printing
8774 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8775 instead of generic ShellCommand
8776 (Build): Add .stopBuild, use it when slave is detached
8778 * buildbot/process/step.py (Configure,Test): give the steps their
8779 own names and status strings
8781 * buildbot/status/html.py (StatusResource): add "show" argument,
8782 lets you limit the set of Builders being displayed.
8784 2003-03-20 Brian Warner <warner@lothar.com>
8786 * buildbot/process/basic.py: removed
8788 2003-03-19 Brian Warner <warner@lothar.com>
8790 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8791 turn off process-docs by default
8793 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8794 when displaying build information without anything in allBuilds[]
8796 * buildbot/bot.py (makeApp): really take password from sys.argv
8798 2003-03-18 Brian Warner <warner@lothar.com>
8800 * buildbot/bot.py (buildApp): take password from sys.argv
8802 * README: replace with more useful text
8804 * setup.py: add a real one
8805 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8807 * docs/PyCon-2003/: added sources for PyCon paper.
8809 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8810 now Build objects control the process and Builder only handles
8811 slave stuff and distribution of changes/status. A new BuildFactory
8812 class creates Build objects on demand.
8814 Created ConfigurableBuild which takes a list of steps to run. This
8815 makes it a lot easier to set up a new kind of build and moves us
8816 closer to being able to configure a build from a web page.
8818 * buildbot/process/step_twisted.py, process_twisted.py: move to
8819 new model. A lot of code went away.
8821 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8822 send lots of empty progress messages to the client.
8824 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8826 2003-02-20 Brian Warner <warner@lothar.com>
8828 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8830 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8831 Twisted bug that prevented non-pty processes from working just got
8832 fixed, and the bug that leaks ptys is still being investigated.
8834 * buildbot/process/step.py (CVS): send timeout arg to slave
8836 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8837 builders coming and going
8838 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8839 from CVSToys, handle lost-buildmaster
8841 * buildbot/status/client.py (StatusClientService.removeBuilder):
8842 Clean up status client protocol: send builders (with references)
8843 as they are created, rather than sending a list and requiring the
8844 client to figure out which ones are new.
8845 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8846 attempts to force a build on an unknown builder
8848 2003-02-19 Brian Warner <warner@lothar.com>
8850 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8851 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8852 Twisted stops leaking them.
8853 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8854 builder goes to an idle state.
8856 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8857 I figure out why CVS commands hang without them, and/or I fix the
8858 hung-command timeout
8860 2003-02-16 Brian Warner <warner@lothar.com>
8862 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8863 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8864 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8865 GenerateDocs now that they are prefixed with WARNING:.
8867 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8868 use manual href target instead of request.childLink
8870 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8871 display every second, but update the ETA every 5 seconds (or
8872 whenever) as remote_progress messages arrive.
8875 2003-02-12 Brian Warner <warner@lothar.com>
8877 * *: import current sources from home CVS repository
8881 # add-log-time-format: add-log-iso8601-time-string