1 2007-08-12 Brian Warner <warner@lothar.com>
3 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
4 by adding the file's new name to the list of changed files. This
5 ought to be sufficient for things like isFileImportant and trial
6 tests that only exercise tests for files that have been modified.
9 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
10 XMLRPC server to the WebStatus page. This only has two methods
11 right now (getAllBuildsInInterval and getBuild), but we'll be
12 adding more in the future. This server is extracted from the
15 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
16 generateFinishedBuilds, and improve the data displayed.
17 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
18 the per-Build page, add some information like ETA and got_revision
19 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
20 adding a list of recently completed builds
21 * buildbot/status/web/base.py (css_classes): factor this out
23 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
24 new method, to make status display classes easier to write,
25 especially the WebStatus 'one_line_per_build' page.
26 (IBuilderStatus.generateFinishedBuilds): same
27 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
28 (Status.generateFinishedBuilds): implement it
30 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
31 'source' to be a BuildStep instance, since BuildFactory accepts
34 (Distutils.__init__): same
35 (Trial.__init__): same
37 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
38 this might raise KeyError
40 2007-08-07 Brian Warner <warner@lothar.com>
42 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
43 'Owner:' field of the view, rather than 'p4logname', since
44 p4logname comes from the buildslave's environment and seems
45 unlikely to ever do the right thing. Thanks to Wade Brainerd for
46 the patch. Closes #40.
48 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
49 which imposes a per-slave limit on how many builds are allowed to
50 run simultaneously. This has a the same scope than the SlaveLock,
51 but is different because max_builds= gives the buildmaster the
52 freedom to assign the build to a different slave, whereas the
53 SlaveLock doesn't get tested until after the build is irrevocably
54 assigned to a slave. Therefore using max_builds= will improve
55 utilization in the presence of multiple buildslaves that are
56 attached to the same Builder. This completes the incorporation of
57 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
58 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
59 any Builder finishes, potentially trigger *all* Builders, since
60 max_builds= may have stalled someone else while waiting for the
62 * buildbot/scripts/sample.cfg: mention max_builds=
63 * buildbot/test/test_run.py (ConcurrencyLimit): test it
64 * docs/buildbot.texinfo (Buildslave Specifiers): document it
66 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
67 inherit from RunMixin do not need to call master.stopService()
68 themselves, since RunMixin.tearDown does that. The double call
69 fails on Twisted-2.0.x, which didn't happen to protect against it.
70 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
72 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
73 from #48, this one to have the BuildSlave objects track
74 SlaveBuilders, so they'll be able to use that knowledge to
75 influence their canStartBuild() response.
76 * buildbot/process/builder.py (SlaveBuilder.attached): call it
77 (SlaveBuilder.detached): same
78 * buildbot/test/test_slaves.py (BuildSlave): test it
80 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
81 the second of Dustin's #48 patches, this one adding a method to
82 the BuildSlave that allows it to decide whether it is willing to
83 participate in a build or not.
84 (SlaveBuilder.isAvailable): use canStartBuild() to decide
86 * buildbot/test/test_run.py (CanStartBuild): test for it
88 * all: incorporate the first of four patches by Dustin Mitchell
89 from ticket #48, working towards improving control over slave
90 concurrency. The first patch is to use a long-lived BuildSlave
91 object per slave, on which other behavior can be added later. I've
92 modified his patch considerably.
93 * buildbot/buildslave.py (BuildSlave): move class out of
94 slave/__init__.py (where it would get loaded by the slave as well
95 as the master, making dependencies trickier), and merge it with
96 BotPerspective. Now these BuildSlave instances are created once in
97 the master.cfg file, and not destroyed until they are either
98 removed from the config file or changed so
99 much (name/password/class changes) that we cannot continue to use
100 the old one. This affects config files: they must use
101 'from buildbot.buildslave import BuildSlave' instead of using
102 'from buildbot.slave import BuildSlave'.
103 * buildbot/master.py: move BotPerspective out
104 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
105 add or remove as necessary, update the rest using data from
107 * buildbot/slave/__init__.py: move BuildSlave out
108 * buildbot/test/test*.py: import BuildSlave from the new place
109 * buildbot/scripts/sample.cfg: update to match
110 * docs/buildbot.texinfo: update to match
111 * buildbot/process/builder.py: update comments to match
113 2007-08-02 Brian Warner <warner@lothar.com>
115 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
116 one-line-per-build pages a bit, add a header, refactor slightly
118 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
119 the TimeOutError timer, patch by Dustin Mitchell.
121 2007-08-01 Brian Warner <warner@lothar.com>
123 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
124 mostly work (branch= is still ignored, we need a useful header)
125 (OneLinePerBuildOneBuilder.body): this too
127 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
128 bring this up-to-date w.r.t. recent refactorings, and fix
129 redirections to bounce the browser to the top page after hitting
130 the 'force' button. This needs to be improved, but at least it now
131 redirects to a valid page.
132 (StatusResourceBuilder.ping): same
133 (StatusResourceBuilder.getChild): same, although I think this code
134 might be dead anyways
136 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
137 a branch= query argument, to filter the display down to builds and
138 changes that involve the given branch. You can add multiple
139 branch= arguments to see multiple branches (using a logical OR).
140 Note that there is no way to include the default branch (i.e.
141 None, i.e. trunk) yet, there is still work to be done to allow for
142 simple+uniform names of branches (i.e. removing the VC-specific
143 details of how branches are implemented, so calling the branch
144 'beta4' even though the SVN checkout step requires
146 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
147 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
148 * buildbot/interfaces.py (IEventSource.eventGenerator): same
149 * docs/buildbot.texinfo (Buildbot Web Resources): document it
151 * all: bring import statements up-to-date: don't import
152 __future__, assume cPickle and cStringIO are always available.
153 Also remove #!/usr/bin/python lines from non-scripts, my editor
154 has been a bit over-enthusiastic about stuffing them into new .py
157 * buildbot/status/web/index.html: put a link to the waterfall page
158 on the index, otherwise first-time users of WebStatus aren't going
159 to see anything very interesting.
161 * buildbot/interfaces.py (IEventSource): document this interface.
162 Thanks to Dustin Mitchell for the patch. Closes #60.
163 * buildbot/status/builder.py (BuilderStatus): same
164 * buildbot/changes/changes.py (ChangeMaster): same
166 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
167 add a query arg of 'show_events=true' to display non-build events,
168 like slaves attaching/detaching and reconfig events, or
169 'show_events=false' to hide them. The default is 'true'.
170 * docs/buildbot.texinfo (Buildbot Web Resources): document it
172 * web-parts: merge in web-parts branch. Lots of changes. The new
173 functionality is to add buildbot.status.html.WebStatus, which is a
174 superset of the Waterfall that adds new status pages and serves
175 regular files from BASEDIR/public_html/ , which is now the preferred
176 place to put robots.txt, buildbot.css, and index.html .
177 * buildbot/scripts/runner.py: the 'create-master' command now
178 creates public_html/ too, and populates it with a couple of
180 * buildbot/status/web: split waterfall code into smaller pieces
182 2007-07-31 Brian Warner <warner@lothar.com>
184 * buildbot/scripts/startup.py (launch): import twistd.run in a
185 different way to hush pyflakes
186 * buildbot/process/builder.py: remove unused import
188 2007-07-30 Brian Warner <warner@lothar.com>
190 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
191 Mitchell: pass SourceStamps around rather than branch/version/etc
192 tuples. Thanks Dustin! Closes #70.
193 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
194 tuple rather than a list, to avoid surprising mutations
195 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
196 * buildbot/status/mail.py (MailNotifier.buildMessage): same
197 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
198 * buildbot/test/test_status.py (Subscription): same
199 * buildbot/test/test_control.py (Force): same
200 * buildbot/test/test_buildreq.py (Request.testMerge): same
202 2007-07-29 Brian Warner <warner@lothar.com>
204 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
205 variable, since it wasn't used and is confusing in the presence of
206 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
209 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
210 the Buildbot home-page link to point at buildbot.net instead of
211 sourceforge, and add a current-version query parameter so we can
212 get some statistics on which versions are in use out there.
214 2007-07-28 Brian Warner <warner@lothar.com>
216 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
217 with c['change_source'], leaving c['sources'] for backwards
218 compatibility (but deprecated), scheduled for removal in 0.8.0
219 * docs/buildbot.texinfo: same
220 * buildbot/test/test_config.py: verify that c['sources'] still works
221 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
222 * buildbot/scripts/sample.cfg: update to match
224 * buildbot/changes/mail.py (MaildirSource): parse with python's
225 stdlib 'email' module, which has been available since python2.2,
226 and drop use of the 'rfc822' module, which has been depreceated
228 * buildbot/test/test_maildir.py: same: use parse_file() not parse
230 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
231 this needs to match the renaming in test/mail/msg*
233 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
236 * buildbot/test/test_mailparse.py: rename sample emails a bit
237 * buildbot/test/mail/msg*: same
239 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
240 parser for the "commit-email.pl" script that is shipped with SVN,
241 written by Justin Mason. Thanks! Closes SF#1072845.
242 * buildbot/test/mail/svn-commit.*: sample messages
243 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
244 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
246 2007-07-27 Brian Warner <warner@lothar.com>
248 * buildbot/changes/mail.py: refactor: move parsing into a method
249 named 'parse', each parser type gets a separate subclass. Remove
250 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
251 to be a simple leading-substring match. Add a warning to the logs
252 if prefix= does not end in a slash, since that's probably a
253 mistake. Fix both places where a prefix= mismatch would skip all
254 subsequent files in the same email, instead of just skipping the
255 one that didn't match.
256 * buildbot/test/test_mailparse.py: match changes
258 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
259 docs on email-based ChangeSources
261 * docs/buildbot.texinfo (Getting Source Code Changes): move all
262 the changesource types up a level, removing the one-entry menu in
265 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
266 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
267 instances instead of tuples. Closes #63.
268 * buildbot/slave/__init__.py (BuildSlave): define marker class
269 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
270 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
271 * buildbot/test/test_*.py: update tests to match
272 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
273 the c['bots'] backwards-compatibility handler works
275 2007-07-26 Brian Warner <warner@lothar.com>
277 * buildbot/changes/hgbuildbot.py (hook): add an in-process
278 Mercurial change-sending hook, contributed by Frederic Leroy.
279 Thanks! Addresses #50.
280 * docs/buildbot.texinfo (MercurialHook): document it
282 * buildbot/changes/hgbuildbot.py: change the way imports are done,
283 to make it compatible with at least hg-0.9.1 and the current 0.9.4
285 2007-07-17 Brian Warner <warner@lothar.com>
287 * buildbot/process/buildstep.py (BuildStep.getLog): add a
288 convenience method to retrieve a log added with
289 addLog()/addCompleteLog()/etc or logfiles= . I should have added
292 2007-07-03 Brian Warner <warner@lothar.com>
294 * buildbot/slave/commands.py (ShellCommand._startCommand): when
295 logging the environment variables, put one variable on each line,
296 rather than having one really long line with all of them. This
297 should make them a bit more readable and not trigger the
298 horizontal scrollbar (when viewing it in a web browser) quite so
299 much. Thanks to Albert Hofkamp for the patch.
301 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
302 WithProperties instance. Thanks to Axel Hecht for the patch.
304 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
305 * docs/buildbot.texinfo (Build Properties): document it
306 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
307 workdir if it didn't already exist.
309 * docs/buildbot.texinfo (Scheduler Types): correct the description
310 of Dependent schedulers. Thanks to Greg Ward for the patch.
312 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
313 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
314 the patch. Closes #49.
316 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
317 0700 before removing it, to deal with situations where a build will
318 leave files around without write permissions and the 'copy' or
319 'clobber' VC checkout modes need to blow away the tree first.
320 Thanks to Steve Milner for the suggestion and the patch (which I
321 mangled horribly). Closes #29.
322 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
325 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
326 an allowReconnect= argument to let callers control whether they
327 want this don't-let-it-reconnect behavior, since some tests care.
328 Factor out the .continueTrying=False lines from those callers.
329 * buildbot/test/test_slaves.py: same
330 * buildbot/test/test_run.py: same
332 2007-07-02 Brian Warner <warner@lothar.com>
334 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
335 slave has been disappeared, don't let it reconnect. This was
336 causing an intermittent failure in test_slaves.py, when the slave
337 that was supposed to be gone managed to come back by the end of
338 the test and affect the count.
339 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
341 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
342 diagnostic messages to track down this problem
343 (Builder.startBuild): same
345 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
346 the slave randomly rather than always taking the first one. Thanks
347 to Pike for the patch. Closes #36.
348 * buildbot/test/test_slaves.py: match the change. to avoid huge
349 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
350 enables/disables the round-robin-ness (enabled by default), and
351 some unit tests disable it.
352 * docs/buildbot.texinfo (Buildmaster Architecture): document it
354 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
355 argument to 'buildmaster_host', to make it more obvious that this
356 points to the buildmaster. Thanks to Bob Proulx for the
358 * buildbot/scripts/runner.py (slaveTAC): same
359 * buildbot/test/test_runner.py (Create.testSlave): match the change
361 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
364 2007-06-17 Brian Warner <warner@lothar.com>
366 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
367 we can round-trip all of our current step classes by calling
368 getStepFactory() and using the results to make a clone of the
371 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
374 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
375 the config file, we're moving to using actual instances instead of
376 the (class, kwargs) 'step specification' tuples. BuildFactory
377 still keeps a list of tuples internally, but when real instances
378 are passed in to addStep(), they are asked for their class and
379 kwargs using the new BuildStep.getStepFactory method. BuildFactory
380 accepts both instances and the tuple form, and converts instances
381 to the tuple form, but the instance form is preferred because it
382 gives the Steps a chance to do argument validation. Closes: #11.
384 * buildbot/process/buildstep.py (BuildStep.__init__): record the
385 factory information necessary to implement getStepFactory. The
386 addFactoryArguments() method can be used to include arguments that
387 aren't passed to the BuildStep base class constructor.
388 (BuildStep.setBuild):
389 (BuildStep.setDefaultWorkdir): new methods to take parameters that
390 are needed for live BuildSteps but not to construct the specification
391 tuples that are stashed in the factory.
393 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
394 'workdir' into new BuildSteps by using methods instead of
395 arguments. This makes the constructor for BuildSteps a lot
398 * buildbot/steps/*.py: update to match this change. Basically this
399 means adding calls to addFactoryArguments() in the __init__
400 methods to capture the arguments that aren't passed through to the
402 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
403 the new workdir (if any) into the RemoteShellCommands arguments.
404 * buildbot/steps/source.py: allow workdir= to be optional,
405 implement setDefaultWorkdir() since we don't inherit from
406 (CVS): finally remove old clobber=/export=/copydir= arguments,
407 in favor of the mode= argument that's been around forever now.
408 * buildbot/steps/transfer.py: remove build= argument
410 * buildbot/test/*.py: update to match, generally by turning all
411 build= arguments into subsequent calls to s.setBuild()
412 * buildbot/test/test_config.py (Factories): verify that we can
413 use either BuildStep instances or class/kwarg tuples in both
414 BuildFactory.addStep and BuildFactory.__init__
416 * docs/buildbot.texinfo (Build Steps): document the new approach,
417 mention compatibility with the old approach, update all examples
418 to use the new style.
420 2007-06-16 Brian Warner <warner@lothar.com>
422 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
423 the LoopingCall, just eat the failure so that we'll poll again
424 next time. This should allow us to tolerate (e.g.) sf.net SVN
425 failures more gracefully. Many thanks to Dustin Mitchell for the
428 2007-05-17 Brian Warner <warner@lothar.com>
430 * buildbot/status/words.py: refactor the IRC status bot into
431 separate 'Contact' and 'Channel' classes. The base Contact class
432 contains the interaction code: commands and responses. The
433 IRCContact subclass (and IrcStatusBot 'Channel') handle the
434 IRC-specific aspects. The plan is to write other subclasses for
435 other IM protocols like AIM and Jabber.
437 2007-04-16 Brian Warner <warner@lothar.com>
439 * CREDITS: update list of contributors. Thank you all!
441 2007-04-13 Brian Warner <warner@lothar.com>
443 * buildbot/status/mail.py (MailNotifier): add the project name to
444 the subject line and message body, to make it easier to
445 distinguish email coming from different buildmasters. Thanks to
446 Benoit Sigoure for the patch.
447 * buildbot/test/test_status.py (Mail): update to match
449 2007-03-24 Brian Warner <warner@lothar.com>
451 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
452 avoid text-conversion problems between DOS/windows and unix.
453 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
455 2007-03-03 Brian Warner <warner@lothar.com>
457 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
458 warning about the use of Waterfall here
460 2007-03-01 Brian Warner <warner@lothar.com>
462 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
464 2007-02-28 Brian Warner <warner@lothar.com>
466 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
467 Lamb to use a more optimal form of 'p4 changes', to reduce server
468 load. He reports that this optimization was added to p4d release
469 2005.2, but it should work in all versions. Closes #27.
470 * buildbot/test/test_p4poller.py: match it
472 2007-02-27 Brian Warner <warner@lothar.com>
474 * buildbot/status/web/*.py: move all web status stuff into a
475 separate directory, in anticipation of splitting it into smaller
476 pieces and adding more files. html.py was getting way too big.
477 * buildbot/status/classic.css: move it too
478 * setup.py: add the new sub-package
479 * buildbot/test/test_web.py: match the changes
480 * MANIFEST.in: handle the move of classic.css
482 2007-02-07 Brian Warner <warner@lothar.com>
484 * contrib/OS-X/*: add some launchd .plist files for automatically
485 starting a buildmaster or buildslave under OS-X (10.4 or later).
486 Thanks to Mark Pauley for these.
488 2007-02-06 Brian Warner <warner@lothar.com>
490 * docs/buildbot.texinfo (Requirements): update requirements to
491 stop claiming compatibility with python-2.2 or twisted-1.3.x .
493 * README: mention python-2.5 and twisted-2.5 compatibility
495 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
497 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
499 * buildbot/status/builder.py: same, by requiring cStringIO
500 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
501 * buildbot/test/test_vc.py: same
502 * buildbot/test/test_web.py:
503 * buildbot/test/test_steps.py: same, remove unused import
505 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
508 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
509 see any Builders that don't have Schedulers to drive them
511 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
512 attributes this uses went away
514 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
515 dialog, to allow you to reset the buildmaster and force
516 connect/disconnect. Correctly handle losing the buildmaster
517 connection (by switching the display to the hexnut, at which point
518 you can use the 'Connect' menu item to reconnect).
520 * buildbot/steps/source.py (Source.start): if we're using a patch,
521 add it as a LogFile to the checkout/update step. This will turn
522 into a link on the waterfall page.
524 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
525 option, to take the patch from a pre-made file rather than
526 generating it from the local tree. Thanks to Robert Helmer for the
527 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
528 * buildbot/scripts/runner.py (TryOptions): add --diff,
529 --patchlevel, and --baserev options
530 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
531 as None, meaning HEAD.
532 * buildbot/sourcestamp.py (SourceStamp): update docstring to
533 indicate that baserev=None means HEAD
534 * docs/buildbot.texinfo (try --diff): document it
536 * buildbot/test/test_steps.py (BuildStep): remove use of
537 reactor.iterate(), although the technique I replaced it with is a
538 gross polling hack that must be cleaned up properly some day. This
539 was the last use of reactor.iterate in the entire tree, yay.
541 2007-02-05 Brian Warner <warner@lothar.com>
543 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
544 is one of the three known values, otherwise we emit some confusing
545 messages later on. Thanks to Grig Gheorghiu for the catch.
547 2007-01-30 Brian Warner <warner@lothar.com>
549 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
550 Hearsum contributed a patch to let BonsaiPoller work with results
551 that contain non-ascii characters. Closes SF#1632641.
553 2007-01-27 Brian Warner <warner@lothar.com>
555 * Makefile (release): produce both .tar.gz and .zip source bundles.
558 2007-01-23 Brian Warner <warner@lothar.com>
560 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
561 * buildbot/changes/monotone.py: same
563 * buildbot/changes/maildir.py: combine several files into one,
564 clean up maildir.py to use Services properly.
565 * buildbot/changes/maildirtwisted.py: remove
566 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
568 * buildbot/changes/mail.py: match the change
569 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
570 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
572 * buildbot/slave/commands.py (command_version): bump to "2.3" to
573 indicate that the buildslave knows about the 'bzr' command
575 2007-01-22 Brian Warner <warner@lothar.com>
577 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
578 'with', it will become a reserved work in python2.6 .
580 * contrib/bb_applet.py: add a simple gnome-panel applet, to
581 display a terse summary of buildbot status.
582 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
583 some icons, small versions of the Blender object that lives in
584 docs/images/icon.blend
586 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
587 * buildbot/slave/commands.py (Bzr): same
588 * buildbot/scripts/tryclient.py (BzrExtractor): same
589 (SourceStampExtractor.dovc): modify this to allow non-zero exit
590 status, since 'bzr diff' does that
591 * buildbot/test/test_vc.py (Bzr): same
592 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
596 2007-01-20 Brian Warner <warner@lothar.com>
598 * contrib/darcs_buildbot.py: tidy up the progress messages
600 2007-01-17 Brian Warner <warner@lothar.com>
602 * contrib/darcs_buildbot.py: enhance to handle multiple patches
603 being pushed at a time. This keeps state in the repository in a
604 small file named .darcs_buildbot-lastchange, but that shouldn't
605 interfere with normal repository operations. Fixes SF#1534049.
606 * buildbot/clients/sendchange.py (Sender): make a single Sender
607 capable of sending Changes with different usernames.
609 2006-12-11 Brian Warner <warner@lothar.com>
611 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
612 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
613 buildbot.changes.mail a long time ago, but I forgot to add the
614 DeprecationWarning until now.
616 * buildbot/process/maxq.py: remove this, the functionality now
617 lives in buildbot.steps.maxq
619 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
620 * buildbot/clients/gtkPanes.py: remove unused import
622 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
623 that was meant to provide a special Reporter to run inside trial
624 and give the buildslave lots of machine-readable status. We never
625 finished this project.
627 * buildbot/changes/bonsaipoller.py: remove unused imports
628 * buildbot/changes/svnpoller.py: same
629 * buildbot/process/builder.py: same
630 * buildbot/process/buildstep.py: same
631 * buildbot/slave/bot.py: hush pyflakes warning
632 * buildbot/status/tests.py: remove unused imports
633 * buildbot/status/tinderbox.py: same
634 * buildbot/steps/python_twisted.py: same
636 * buildbot/process/step.py: remove this file, these names were
637 deprecated in 0.7.5 and are now being removed.
638 * buildbot/process/step_twisted.py: same
639 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
641 * buildbot/twcompat.py: remove the empty file, yay it is gone
643 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
644 tw-2.0.0 and newer have the method we need.
645 (getProcessOutputAndValue): same
646 (which): remove this method, tw-2.0.0 t.p.procutils has it
648 * buildbot/twcompat.py (implements): remove this method
649 * buildbot/*: import implements() from zope.interface directly
651 * buildbot/status/mail.py: stop falling back to importing
652 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
655 * buildbot/twcompat.py (Interface): remove this import
656 * buildbot/*: import Interface from zope.interface directly
658 * buildbot/twcompat.py (providedBy): remove this method
659 * buildbot/*: turn all uses of providedBy(obj, iface) into
660 iface.providedBy(obj)
662 * buildbot/twcompat.py (maybeWait): remove this method, now that
663 we no longer maintain compatibility with Twisted<=1.3.0 .
664 Twisted-2.0.0 and later allow trial methods to return Deferreds
666 * buildbot/test/*: remove all uses of maybeWait
668 * buildbot/__init__.py (version): bump to 0.7.5+ while between
670 * docs/buildbot.texinfo: same
672 2006-12-10 Brian Warner <warner@lothar.com>
674 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
675 * docs/buildbot.texinfo: set version to match
677 2006-12-10 Brian Warner <warner@lothar.com>
679 * README (REQUIREMENTS): update for release
680 * NEWS: update for release
681 * buildbot/slave/commands.py (command_version): mention that this
682 version (2.2) was released with buildbot-0.7.5
684 * buildbot/test/test_config.py (StartService.testStartService):
685 inhibit the usual read-config-on-startup behavior, since otherwise
686 the log.err that gets recorded causes the test to fail
688 * buildbot/status/builder.py (LogFile.finish): forget about all
689 subscribers once the log has finished, since after that point
690 we're never going to use them again. This might help free up some
693 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
694 than the old/deprecated gtk.mainquit()
696 2006-12-09 Brian Warner <warner@lothar.com>
698 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
699 better when we can't open the masterdst file
701 * buildbot/scripts/startup.py (Follower._failure): add missing
702 import statement for BuildSlaveDetectedError
704 * buildbot/steps/transfer.py (FileUpload): cleanup
705 (FileDownload): same. Add tests for slave version, add mode=.
706 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
707 (SlaveFileDownloadCommand): same
708 * buildbot/test/test_transfer.py: enhance tests
709 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
712 2006-12-08 Brian Warner <warner@lothar.com>
714 * buildbot/scripts/runner.py (sendchange): halt the reactor on
715 both success *and* failure. Without this, the 'buildbot
716 sendchange' command would hang if it could not contact the
717 buildmaster or deliver the Change, which would generally cause the
718 user's commit/record/checkin command to hang too. Thanks to
719 Christian Unger for the catch.
721 2006-12-06 Brian Warner <warner@lothar.com>
723 * NEWS: update with items for the next release
725 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
726 whimsical example pulled from a punch-drunk email I sent out late
728 (Transferring Files): document some of the other parameters
729 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
730 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
731 * buildbot/test/test_svnpoller.py: same
732 * buildbot/changes/svnpoller.py (SVNPoller): same
734 2006-11-26 Brian Warner <warner@lothar.com>
736 * docs/buildbot.texinfo (Build Properties): remind users that
737 WithProperties must appear in a command= list, not as a top-level
739 * buildbot/steps/shell.py (ShellCommand.start): and assert that
740 we're sending a list or a single string to the RemoteShellCommand
742 * buildbot/scheduler.py (Nightly): Improve docs slightly.
744 * buildbot/scripts/startup.py (start): skip the whole
745 watch-the-logfile thing under windows, since it needs os.fork()
747 * buildbot/scripts/runner.py (restart): remove the old message
748 that got printed after the buildbot was restarted.. it most cases
749 it didn't get printed at the right time anyways
751 2006-11-25 Brian Warner <warner@lothar.com>
753 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
754 follow twistd.log and print lines until the process has started
755 started properly. For the buildmaster, this means until the config
756 file has been parsed and accepted. For the buildslave, this means
757 until we've connected to the master. We give up after 5 seconds in
758 any case. Helpful error messages and troubleshooting suggestions
759 are printed when we don't see a successful startup. This closes the
760 remainder of SF#1517975.
761 * buildbot/scripts/startup.py: moved app startup code to here
762 * buildbot/scripts/logwatcher.py: utility class to follow log
763 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
764 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
765 so the LogWatcher can tell the difference between a buildmaster
768 2006-11-24 Brian Warner <warner@lothar.com>
770 * docs/examples/twisted_master.cfg: update to match the version
771 in use on twistedmatrix.com
772 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
773 was using before stopped working, but 'irc.freenode.net' works
776 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
779 * buildbot/clients/base.py (TextClient.not_connected): upon
780 UnauthorizedLogin failures, remind the user to connect to the
781 PBListener port instead of the slaveport.
782 (TextClient.disconnected): shut down more quietly
783 * docs/buildbot.texinfo (statuslog): add another reminder
785 * buildbot/scripts/runner.py (Options.subCommands): rename
786 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
787 'sighup' as an alias.
788 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
789 reconfig command to follow twistd.log and print all of the lines
790 from the start of the config-file reload to its completion. This
791 should make it a lot easier to discover bugs in the config file.
792 Use --quiet to disable this behavior. This addresses half of
793 SF#1517975, the other half will be to add this same utility to
794 'buildbot start' and 'buildbot restart'.
795 * docs/buildbot.texinfo (Loading the Config File): same
798 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
799 method, it has been deprecated for a long time. Use
800 IBuilderControl.requestBuild instead.
801 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
802 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
803 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
804 * buildbot/test/test_control.py (Force.testForce): same
805 * buildbot/test/test_run.py: use requestBuild instead
807 * buildbot/clients/debug.py: replace 'Force Build' button with
808 'Request Build' (which just adds one to the queue), add Ping
809 Builder, add branch/revision fields to Request Build.
810 * buildbot/clients/debug.glade: same
811 * buildbot/master.py: update interface to match. This creates an
812 incompatibility between new debugclients and old buildmasters.
814 * buildbot/process/builder.py (Builder._attached): delay the call
815 to maybeStartBuild for a reactor turn, to avoid starting a build
816 in the middle of a reconfig (say, if the new Builder uses a new
817 slave which is already connected).
819 2006-11-23 Brian Warner <warner@lothar.com>
821 * buildbot/test/test_transfer.py: appease pyflakes
822 * buildbot/test/test_steps.py: same
824 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
825 keeps pyflakes from finding undefined names
827 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
828 Builder no longer induces a disconnect/reconnect cycle. This means
829 that any builds currently in progress will not be interrupted, and
830 any builds which are queued in the Builder will not be lost. This
831 is implemented by having the new Builder extract the state (i.e.
832 all pending Builds and any desired SlaveBuilders) from the old
834 (BotPerspective): refactor. The BotPerspective no longer keeps
835 track of all the Builders that want to use this slave; instead, it
836 asks the BotMaster each time it needs this list. This removes
837 addBuilder and removeBuilder. Clean up attached() to acquire all
838 the slave's information in a more atomic fashion. updateSlave() is
839 now the way to make sure the slave is using the right set of
840 Builders: just call it after everything else has been
842 (BotMaster): refactor, removing addBuilder/removeBuilder and
843 replacing them with an all-at-once setBuilders() call.
845 * buildbot/test/test_slaves.py (Reconfig): new test case to
846 exercise this functionality
847 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
848 * buildbot/slave/commands.py (WaitCommand): same
850 * docs/buildbot.texinfo (Loading the Config File): document the
853 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
854 SlaveBuilder to have its parent Builder changed.
855 (SlaveBuilder.isAvailable): new method to give access to state,
856 which is now a private attribute
857 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
858 the SlaveBuilder about how it is being used. These methods update
859 its internal state. buildFinished() is now the place that invokes
860 maybeStartBuild() on its parent Builder.
861 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
862 new Builder to take over for an old one, transferring state from
864 (Buider): refactor the way that SlaveBuilders are used to match,
865 giving them a bit more autonomy.
866 (Builder.buildFinished): this no longer calls maybeStartBuild():
867 instead the SlaveBuilder calls it on whoever its parent Builder is
868 at the time. This way, when an old Builder is replaced by a new
869 one, and there was a build in progress during the transition, when
870 that build finishes, it will be the new Builder that is told about
871 the newly available slave so it can start a new build.
873 * buildbot/process/base.py (Build.startBuild._release_slave): when
874 the Build finishes, tell the SlaveBuilder that they've been
877 * buildbot/status/builder.py (SlaveStatus): add some new setter
878 methods for use by BotPerspective, to keep some attributes more
881 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
882 called by the buildmaster.
883 (Bot.setBuilderList): instead, we locally announce any leftover
884 directories based upon which Builders we were told about. The
885 master doesn't really care; it's the local admin who may or may not
889 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
890 to allow use of python2.4 or whatever. This tool still requires
893 2006-11-19 Brian Warner <warner@lothar.com>
895 * NEWS (IStatusLog.readlines): more news items
897 2006-11-18 Brian Warner <warner@lothar.com>
899 * NEWS: start collecting items for the next release.
901 2006-11-04 Brian Warner <warner@lothar.com>
903 * buildbot/changes/bonsaipoller.py: apply updates from Ben
904 Hearsum. Closes SF#1590310.
905 * buildbot/test/test_bonsaipoller.py: and tests
907 * buildbot/status/tinderbox.py
908 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
909 status when the build results in WARNINGS. Patch from Dave
910 Liebreich. Closes SF#1587352.
912 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
913 linux-vs-osx behavior difference w.r.t. reading from files that
914 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
915 to Mark Rowe for the patch.
917 2006-10-15 Brian Warner <warner@lothar.com>
919 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
920 method name was misspelled in the interface definition. Thanks to
921 Roy Rapoport for the catch.
923 2006-10-13 Brian Warner <warner@lothar.com>
925 * docs/buildbot.texinfo (Adding LogObservers): update sample code
926 to match the great Steps renaming
928 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
929 Maybe I should run my own unit tests before recording a big
930 change. Good thing I've got a buildbot to remind me.
932 2006-10-12 Brian Warner <warner@lothar.com>
934 * buildbot/steps/transfer.py: rework __init__ and args setup
935 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
937 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
938 when opening the target file, only catch IOError (to report via
939 stderr/rc!=0), let the others be reported as normal exceptions
941 2006-10-08 Brian Warner <warner@lothar.com>
943 * contrib/svn_watcher.py: fix security holes by using proper argv
944 arrays and subprocess.Popen() rather than commands.getoutput().
945 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
946 is deprecated in favor of buildbot/changes/svnpoller.py, and will
947 probably be removed by the next release.
950 2006-10-04 Brian Warner <warner@lothar.com>
952 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
953 initial lines that weren't emitted by pyflakes. When the pyflakes
954 command is run under a Makefile, 'make' will echo the command it
955 runs to stdio, and that was getting logged as a "misc" warning.
956 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
957 * buildbot/test/test_steps.py (testPyFlakes3): another test
959 2006-10-01 Brian Warner <warner@lothar.com>
961 * buildbot/status/html.py (HtmlResource.render): if we get a
962 unicode object from our content() method, encode it into utf-8
963 like we've been claiming to all along. This allows the comments
964 and author names from svnpoller.py to be delivered properly.
966 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
967 de-unicodify filenames before creating the Change, because the
968 rest of buildbot is unlikely to handle them well. Leave the 'who'
969 field as a unicode object.. I don't think there's anything that
970 will break very soon, and it will probably nudge us towards
971 accepting unicode everywhere sooner or later. Stop using the
972 "date" field that comes out of SVN, since it is using the
973 repository's clock (and timezone) and what we care about is the
974 buildmaster's (otherwise Changes from the future show up later
975 than the builds they triggered).
976 * buildbot/test/test_svnpoller.py (Everything.test1): match the
979 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
980 Suvbersion repository polling ChangeSource. I've hacked it up
981 considerably: any bugs are entirely my own fault. Thank you
983 * buildbot/test/test_svnpoller.py: tests for it
984 * docs/buildbot.texinfo (SvnSource): document it
986 2006-09-30 Brian Warner <warner@lothar.com>
988 * buildbot/scheduler.py (Periodic): submit a reason= to the
989 BuildSet to indicate which Scheduler triggered the build. Thanks
990 to Mateusz Loskot for the suggestion.
992 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
994 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
995 changes: set self.loop in __init__, remove unused volatile=
997 * docs/buildbot.texinfo (.buildbot config directory): add more
998 docs on the .buildbot/options keys used by "buildbot try"
999 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1000 (Try.deliverJob): same
1002 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1004 (BonsaiPoller): same
1006 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1007 close the filehandle when we stop watching the file. Before, the
1008 filehandle was only closed when the LogFileWatcher was
1009 garbage-collected, which could be quite a while in the future. If
1010 it was still open by the time the next build started, windows will
1011 refuse to let the new build delete the old build/ directory. Fixes
1012 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1013 #twisted for the catch.
1015 2006-09-29 Brian Warner <warner@lothar.com>
1017 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1020 2006-09-25 Brian Warner <warner@lothar.com>
1022 * setup.py: the new buildbot.steps module wasn't being installed.
1023 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1024 (testmsgs): add the extra stuff from buildbot/test/* so you can
1025 run unit tests on an installed copy of buildbot, not just from
1028 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1029 columns of 'svnlook changed' output contain status information, so
1030 strip [:4] instead of [:6]. Depending upon what the status flags
1031 were, this would sometimes lead to mangled filenames. Thanks to
1032 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1034 * buildbot/steps/source.py (Monotone): initial Monotone support,
1035 contributed by Nathaniel Smith. Still needs docs and tests, but
1036 this code has been in use on the Monotone buildbot for a long
1038 * buildbot/slave/commands.py (Monotone): slave-side support
1039 * buildbot/changes/monotone.py (MonotoneSource): polling change
1042 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1043 contributed a Change Source that polls a Bonsai server (a
1044 kind of web-based viewcvs CGI script).
1046 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1047 Hearsum contributed a status plugin which sends email in the same
1048 format that Tinderbox does: this allows a number of tinderbox
1049 tools to be driven by Buildbot instead. Thanks Ben!
1051 2006-09-24 Brian Warner <warner@lothar.com>
1053 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1054 Thanks to Robert Helmer for the patch.
1056 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1057 BuildStatus about the buildslave name at the *beginning* of the
1058 build, rather than at the end. Thanks to Alexander Lorenz for the
1060 * buildbot/status/html.py (StatusResourceBuild.body): always
1061 include the slavename in the build page, not just when the build
1063 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1064 slavename in the email message
1066 2006-09-21 Brian Warner <warner@lothar.com>
1068 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1070 * docs/examples/glib_master.cfg: same
1071 * docs/examples/hello.cfg: same
1072 * docs/examples/twisted_master.cfg: same, update to current usage
1074 2006-09-19 Brian Warner <warner@lothar.com>
1076 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1077 (PyFlakes.createSummary): make it compatible with python-2.2
1079 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1080 for at least the output-parsing parts of PyFlakes
1082 2006-09-18 Brian Warner <warner@lothar.com>
1084 * buildbot/steps/python.py: oops, fix import of StringIO
1086 2006-09-17 Brian Warner <warner@lothar.com>
1088 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1089 turns out that SVN-1.4.0 doesn't fail to update once you've
1090 replaced a file with a directory, unlike older versions of SVN and
1091 pretty much every other VC tool we support. Since what we really
1092 care about is that the update succeeds anyway, stop checking that
1093 the tree got clobbered and just assert that the build succeeded.
1094 (VCBase.printLogs): add a utility function for debugging
1096 * buildbot/process/step.py: oops, added extra imports by mistake
1098 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1099 rstrip() on the first line coming out of the 'p4 describe'
1100 process, to remove the stray ^M that Wade Brainerd reports seeing
1101 in the 'when' field. Fixes SF#1555985.
1103 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1104 message logged when c['schedulers'] is not right
1105 * buildbot/scheduler.py (Scheduler.__init__): improve error
1106 message when a Scheduler() is created with the wrong arguments
1107 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1108 verify that these error messages are emitted
1110 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1111 The idea is that all the base classes (like BuildStep and
1112 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1113 will be a leftover backwards-compatibility file that only contains
1114 aliases for the steps that were moved out to buildbot.steps.*
1115 * lots: change imports to match
1116 * buildbot/process/step.py: add a DeprecationWarning if it ever
1119 2006-09-12 Brian Warner <warner@lothar.com>
1121 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1122 builderNames= is actually a sequence, since if you happen to give
1123 it a single builder-specification dictionary instead, it won't get
1124 caught by the existing assert. Thanks to Brett Neely for the
1127 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1129 * docs/buildbot.texinfo (Python BuildSteps): document them
1130 (sendchange): include a link to PBChangeSource, since you need one
1132 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1134 * buildbot/steps/dummy.py: same
1136 2006-09-08 Brian Warner <warner@lothar.com>
1138 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1139 BuildStep which lets you transfer files from the master to the
1140 slave or vice versa. Thanks to Albert Hofkamp for the original
1141 patch. Fixes SF#1504631.
1142 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1144 (SlaveFileDownloadCommand): same
1145 * docs/buildbot.texinfo (Transferring Files): document it
1146 * buildbot/test/test_transfer.py: test it
1147 * buildbot/test/runutils.py (StepTester): new utility class for
1148 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1149 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1152 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1153 walk through StatusLogs one line at a time, mostly for the benefit
1154 of ShellCommand.createSummary methods. You can either walk through
1155 STDOUT or STDERR, but the default is STDOUT.
1157 * buildbot/status/builder.py (LogFile.readlines): implement it.
1158 Note that this is not yet memory-efficient, it just pulls the
1159 whole file into RAM and then splits it up with a StringIO.
1160 Eventually this should be a generator that only pulls chunks from
1162 * buildbot/test/test_status.py (Log.testReadlines): test it
1164 * docs/buildbot.texinfo: update to match changes
1165 * buildbot/process/factory.py: stop using old definitions
1166 * buildbot/process/process_twisted.py: same
1167 * buildbot/test/test_*.py: same
1169 * buildbot/process/step_twisted.py: move definition to..
1170 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1171 relative-import mechanisms prevent this from being named 'twisted'
1172 or 'python/twisted' as I would have preferred.
1174 * buildbot/process/maxq.py: move definition to..
1175 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1177 * buildbot/process/step.py: split the user-visible BuildSteps into
1178 separate files, all under buildbot/steps/
1179 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1180 * buildbot/steps/shell.py: this holds ShellCommand and friends
1181 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1183 2006-09-05 Brian Warner <warner@lothar.com>
1185 * lots: run pyflakes, removed a lot of unused imports, changed the
1186 form of some conditional imports to remove false pyflakes
1187 warnings. There are still a number of warnings left, mostly from
1188 imports that are done for their side-effects.
1189 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1192 2006-08-26 Brian Warner <warner@lothar.com>
1194 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1195 compatible with twisted-1.3.0, for some reason I just can't seem
1196 to let go of the past.
1198 2006-08-25 Brian Warner <warner@lothar.com>
1200 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1202 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1203 all logfiles= in startCommand(), rather than in start() . This
1204 makes it easier to have the 'stdio' log come before any secondary
1205 logfiles, which I feel makes the waterfall display more
1207 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1208 from ShellCommand up into LoggingBuildStep
1209 (LoggingBuildStep.__init__): move the handling of logfiles= from
1210 ShellCommand up to LoggingBuildStep, because startCommand is
1211 provided by LoggingBuildStep, whereas start() was specific to
1212 subclasses like ShellCommand and Source. This removes code
1213 duplication in those subclasses.
1214 (ShellCommand.__init__): same
1215 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1216 for a slave that's too old to understand logfiles= into a separate
1217 method, so it can live in ShellCommand. The rest of
1218 setupLogfiles() can live in LoggingBuildStep.
1220 2006-08-24 Brian Warner <warner@lothar.com>
1222 * buildbot/locks.py (BaseLock): you can now configure Locks to
1223 allow multiple simultaneous owners. They still default to
1224 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1226 * docs/buildbot.texinfo (Interlocks): document the new options
1227 * buildbot/test/test_locks.py: add a bunch of new unit tests
1228 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1229 waitUntilMaybeAvailable, not waitUntilAvailable
1230 * buildbot/process/step.py (BuildStep.acquireLocks): same
1231 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1232 the whole lockid in their constructor, not just the name. Also,
1233 keep track of which real locks we've handed out by the full
1234 lockid, not just class+name, otherwise changing just the maxCount=
1235 in the master.cfg file would not actually cause a behavioral
1238 2006-08-23 Brian Warner <warner@lothar.com>
1240 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1242 * docs/buildbot.texinfo: same
1244 2006-08-23 Brian Warner <warner@lothar.com>
1246 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1247 * docs/buildbot.texinfo: set version to match
1248 * NEWS: update for 0.7.4
1249 * buildbot/slave/commands.py (command_version): mention that this
1250 version (2.1) was released with buildbot-0.7.4
1252 2006-08-22 Brian Warner <warner@lothar.com>
1256 * CREDITS: new file, list of people who have helped. Thanks!
1257 * MANIFEST.in: ship it
1259 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1260 new diagrams, the user's manual is more informative than it was.
1261 Start shipping the .html user's manual (and generated .png
1263 * Makefile: update 'release' target to match
1265 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1266 test.. I think the web-parts effort will render it pointless well
1267 before it ever actually starts to work.
1269 2006-08-20 Brian Warner <warner@lothar.com>
1271 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1272 meaning of the prefix= argument. It is now just a string which is
1273 stripped from the beginning of the filename. If prefix= is set but
1274 not found on any given filename, that filename is ignored. If all
1275 filenames in a Change are ignored, the Change is dropped. This is
1276 much simpler than the previous sep= nonsense, and I should have
1277 implemented it this way from the beginning. Effectively resolves
1278 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1279 Gedminas for the catch and suggested fixes.
1280 (ChangePerspective.perspective_addChange): implement the actual
1282 * buildbot/test/test_changes.py (TestChangePerspective): test it
1283 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1284 how to properly use prefix=
1285 * docs/examples/twisted_master.cfg (source): update prefix= by
1286 adding the trailing slash
1289 * docs/examples/twisted_master.cfg: update to actual practice
1291 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1292 update test case to match new link text.. the HREF has both a
1293 class= setting and an enclosing [] pair that I didn't match in the
1296 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1297 list of strings is preferred over a single string with embedded
1299 (ShellCommand.description=): explain that either single strings or
1300 a list of strings is acceptable, and why you might prefer one over
1301 the other. Add an example. Fixes SF#1524659, thanks to Paul
1302 Winkler for the catch.
1303 (Build Steps): update to use f.addStep() rather than using s()
1304 and the constructor list
1306 * buildbot/process/step.py (ShellCommand): accept either a single
1307 string or a list of strings in both description= and
1309 * buildbot/test/test_steps.py (Steps.test_description): test it
1310 * buildbot/test/runutils.py (makeBuildStep): support for that test
1312 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1313 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1314 collecting the files and creating the patch.
1316 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1317 per-step URLs that will be displayed on the waterfall display,
1318 for things like the HTML output of code-coverage tools, when
1319 the results are hosted elsewhere.
1320 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1321 way to retrieve these URLs
1322 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1323 the method to retrieve these URLs. Also provide backwards
1324 compatibility for saved BuildStepStatus instances that didn't have
1326 * buildbot/process/step.py (BuildStep.addURL): method to set these
1327 URLs from within a BuildStep
1328 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1329 (StepBox.getBox): give these external links a distinct CSS class
1330 named "BuildStep external" so a .css file can display them
1333 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1335 * buildbot/test/test_steps.py (Steps): test that we can all the
1336 URLs. Also add a bunch of other tests on methods that can be
1337 called from within BuildSteps
1338 * buildbot/test/runutils.py (makeBuildStep): add utility function
1340 2006-08-13 Brian Warner <warner@lothar.com>
1342 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1344 2006-08-10 Brian Warner <warner@lothar.com>
1346 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1347 index, this one of things like c['sources'] and c['schedulers']
1348 (indices): it looks like my clever idea of putting the @fooindex
1349 commands in between the @node and the @subsection (to make the
1350 HREF anchor jump to slightly above the section title, which works
1351 much better in html) confused texinfo horribly, so I'm moving the
1352 index tags back to be just after the @subsection marker. I also
1353 added extra lines between the @node/@section paragraph and the
1354 index tags, since I think maybe texinfo wants to see these be
1355 separate paragraphs.
1357 * docs/Makefile (images): make sure images get built when
1358 rendering the manual
1359 * docs/images/Makefile: same
1361 * buildbot/scripts/runner.py: rename 'buildbot master' to
1362 'buildbot create-master', and 'buildbot slave' to 'buildbot
1364 * docs/buildbot.texinfo: same
1367 * docs/buildbot.texinfo: reimplement the "useful classes" index
1368 with actual texinfo indices. The .info rendering is a bit
1369 weird-looking but it works well, and the HTML rendering is quite
1370 nice. This also puts the index targets in the regular flow of the
1371 text, which is easier to maintain.
1373 2006-08-06 Brian Warner <warner@lothar.com>
1375 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1376 Kevin Turner to prefer the environ= argument be a list rather than
1377 a string. If it is a list, it will be joined with a platform-local
1378 os.pathsep delimiter, and then prepended to any existing
1379 $PYTHONPATH value. This works better in cross-platform (i.e.
1380 windows buildslaves) environments when you need to push multiple
1381 directories onto the front of the path.
1382 (SlaveShellCommand): documented the new magic
1383 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1384 in a user-visible form
1386 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1387 Turner to prefer lists over strings when creating/running VC
1388 commands during unit tests. This is clearly necessary to survive
1389 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1390 renamed the wq() function to qw() though, since that's how it's
1391 spelled in perl. Eventually I'd prefer all commands to be
1392 specified with lists.
1394 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1395 which are deleted (or not yet created) correctly. Also add
1396 failsafe code to not explode if the file-watching poller doesn't
1397 get started. Thanks to JP Calderone for the catch and the poller
1399 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1401 * buildbot/test/emitlogs.py: same
1403 * NEWS: summarize recent changes
1405 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1406 clause to avoid the "host key mismatch" warning
1408 * buildbot/process/step_twisted.py (Trial.start): if the
1409 buildslave is too old to understand logfiles=, fall back to
1410 running 'cat _trial_temp/test.log' like before.
1411 (Trial.commandComplete): same. this takes advantage of the
1412 LoggingBuildStep refactoring to stall commandComplete long enough
1413 to run a second RemoteShellCommand.
1415 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1416 refactor command-completion handling, to allow methods like
1417 commandComplete/createSummary/evaluateCommand to return Deferreds.
1418 (LoggingBuildStep._commandComplete): delete the refactored method
1419 (ShellCommand.setupLogfiles): if the buildslave is too old to
1420 understand logfiles=, put a warning message both into twistd.log
1421 and into the otherwise empty user-visible LogFiles.
1423 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1424 callers to provide the slave-side logfile name, rather than
1425 forcing it to come from the local name of the LogFile.
1426 (BuildStep.getSlaveName): new method
1428 * buildbot/process/base.py (Build.getSlaveName): new method, so
1429 steps can find out which buildslave they're running on
1431 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1432 to match the s/cvs_ver/command_version/ change
1434 2006-08-05 Brian Warner <warner@lothar.com>
1436 * buildbot/slave/commands.py (command_version): replace the CVS
1437 auto-updated cvs_ver keyword with a manually-updated variable,
1438 since CVS is no longer the master repository. Add a description of
1439 the remote API change starting in this version (2.1), specifically
1440 the fact that SlaveShellCommand now accepts 'initial_stdin',
1441 'keep_stdin_open', and 'logfiles'.
1443 2006-07-31 Brian Warner <warner@lothar.com>
1445 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1446 diagrams to describe how the whole system fits together. The
1447 images themselves are kept in SVG files, with ascii-art versions
1448 in corresponding .txt files. Texinfo knows how to interpolate the
1449 text version into .info files, reference the .png versions from
1450 .html files, and include .eps versions in the .ps format.
1451 * docs/images/Makefile: tools to create .png and .eps
1452 * docs/images/*.svg: created pictures with Inkscape.
1453 * .darcs-boring: ignore the generated .eps and .png files
1455 2006-07-24 Brian Warner <warner@lothar.com>
1457 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1458 Scheduler names, since they cause setServiceParent to explode
1460 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1462 2006-07-20 Brian Warner <warner@lothar.com>
1464 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1465 which runs the buildbot unit tests
1467 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1468 classes that are useful in master.cfg
1470 2006-07-15 Brian Warner <warner@lothar.com>
1472 * Makefile (some-apidocs): new target to build only some epydocs
1474 * setup.py: minor comment.. does the classifiers= argument prevent
1475 the setup.py script from working on python2.2/2.3?
1477 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1480 * buildbot/twcompat.py: fix minor typo in comments
1482 * buildbot/manhole.py: move all Manhole-related code out to this
1483 module. Implement SSH-based manholes (with TwistedConch), and move
1484 to conch's nifty line-editing syntax-coloring REPL shell instead
1485 of the boring non-editing monochromatic (and deprecated) old
1487 * buildbot/master.py: remove all Manhole-related code
1488 (BuildMaster.loadConfig._add): make sure the old manhole is
1489 removed before we add the new one
1490 * docs/buildbot.texinfo (Debug options): document new Manhole options
1492 * buildbot/twcompat.py (_which): fix some epydoc issues
1493 * buildbot/status/html.py (Waterfall.__init__): same
1495 2006-06-29 Brian Warner <warner@lothar.com>
1497 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1498 deprecation warnings under newer Twisteds (by using
1499 zope.interface.Interface instead of old twisted.python.components
1501 * buildbot/slave/interfaces.py: same
1503 2006-06-28 Brian Warner <warner@lothar.com>
1505 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1506 svn commands, so it will fail immediately instead of hanging while
1507 it waits for a username/password to be typed in.
1509 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1510 log message if the step was shut down
1512 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1513 obsolete reference to mktap.
1515 2006-06-20 Brian Warner <warner@lothar.com>
1517 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1518 test to include new 'logfiles' argument sent from master to slave
1520 2006-06-19 Brian Warner <warner@lothar.com>
1522 * buildbot/process/step_twisted.py (Trial): track Progress from
1523 _trial_temp/test.log too
1525 * buildbot/process/step.py (OutputProgressObserver): generalize
1526 the earlier StdioProgressObserver into an OutputProgressObserver
1527 that can track LogFiles other than stdio.
1528 (LoggingBuildStep.__init__): same
1530 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1531 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1532 will fail under windows because of os.sep issues. It might have
1533 worked before if 'cat' was doing cygwin path conversion.
1535 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1536 creation of LogFileWatchers
1537 (ShellCommand._startCommand): and record the files that were
1538 watched in the 'headers' section of the ShellCommand output
1540 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1541 need to actually pass it to the slave if you want it to work.
1542 (ShellCommand): document it a bit
1544 * buildbot/test/test_shell.py: new test to validate LogFiles
1545 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1547 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1548 before printing the last batch of lines, to test that the polling
1549 logic is working properly
1551 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1552 handling, making it possible to track multiple logs for a single
1553 RemoteCommand. The previous single logfile is now known as the
1555 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1556 (RemoteShellCommand.__init__): accept logfiles=
1557 (LoggingBuildStep.startCommand): stdio_log is now one of many
1558 (ShellCommand): added logfiles= argument, as well as a class-level
1559 .logfiles attribute, which will be merged together to figure out
1560 which logfiles should be tracked. The latter maybe be useful for
1561 subclasses of ShellCommand which know they will aways produce
1562 secondary logfiles in the same location.
1564 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1565 and closeStdin() methods, preparing to make it possible to write
1566 to a ShellCommand's stdin at any time, not just at startup. These
1567 writes are buffered if the child process hasn't started yet.
1568 (LogFileWatcher): new helper class to watch arbitrary logfiles
1569 while a ShellCommand runs. This class polls the file every two
1570 seconds, and sends back 10k chunks to the buildmaster.
1571 (ShellCommand): rename stdin= to initialStdin=, and add
1572 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1574 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1575 key of "log" and a value of (logname, data).
1576 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1577 'logfiles' to the master-visible args dictionary.
1578 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1581 * buildbot/test/test_vc.py (Patch.testPatch): same
1584 * buildbot/test/emit.py: write to a logfile in the current
1585 directory. We use this to figure out what was used as a basedir
1586 rather than looking to see which copy of emit.py gets run, so that
1587 we can run the commands from inside _trial_temp rather than inside
1589 * buildbot/test/subdir/emit.py: same
1590 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1591 argument rather than running from buildbot/test/
1592 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1593 rather than using an implicit setUp()
1594 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1595 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1596 of assuming that we're running in buildbot/test/ (and that '.' is
1599 * buildbot/slave/commands.py (Command.doStart): refactor Command
1600 startup/completion a bit: now the SlaveBuilder calls doStart(),
1601 which is not meant for overridding by subclasses, and doStart()
1602 calls start(), which is. Likewise the SlaveBuilder calls
1603 doInterrupt(), and subclasses override interrupt(). This also puts
1604 responsibility for maintaining .running in Command rather than in
1606 (Command.doInterrupt): same
1607 (Command.commandComplete): same, this is called when the deferred
1608 returned by start() completes.
1609 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1610 (SlaveBuilder.remote_interruptCommand): same
1611 (SlaveBuilder.stopCommand): same
1613 2006-06-16 Brian Warner <warner@lothar.com>
1615 * buildbot/test/test_shell.py: new test file to contain everything
1616 relating to ShellCommand
1617 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1618 multiple logfiles in realtime" feature, not yet implemented
1619 * buildbot/test/emitlogs.py: support file for testLogFiles
1620 * docs/buildbot.texinfo (ShellCommand): document the feature
1622 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1624 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1625 for tests which exercise SlaveCommands in isolation.
1627 * buildbot/test/test_slavecommand.py: Move some utilities like
1628 SignalMixin and FakeSlaveBuilder from here ..
1629 * buildbot/test/runutils.py: .. to here, so they can be used by
1630 other test classes too
1631 * buildbot/test/test_vc.py: more SignalMixin refactoring
1632 * buildbot/test/test_control.py: same
1633 * buildbot/test/test_run.py: and some rmtree refactoring
1635 2006-06-15 Brian Warner <warner@lothar.com>
1637 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1638 'testBranch' to match other VC tests and have the tests run in
1639 roughly increasing order of dependency
1641 * buildbot/test/test_steps.py (LogObserver): new test to verify
1642 LogObservers can be created at various times and still get
1643 connected up properly
1645 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1646 to create BuildStepStatus instances that actually work.
1648 * buildbot/process/step.py (LogObserver): add outReceived and
1649 errReceived base methods, to be overridden
1651 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1652 API to take a name instead of a step, reducing the coupling
1653 somewhat. This returns the BuildStepStatus object so it can be
1654 passed to the new Step, instead of jamming it directly into the
1656 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1658 * buildbot/process/base.py (Build.setupBuild): use both methods
1659 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1660 process a bit to match
1662 2006-06-14 Brian Warner <warner@lothar.com>
1664 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1665 docs on writing new LogObserver classes
1666 (Writing New Status Plugins): brief docs on how Status Plugins fit
1669 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1670 implement a LogObserver that counts how many unit tests have been
1672 (Trial.__init__): wire it in
1673 * buildbot/test/test_twisted.py (Counter): unit test for it
1675 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1676 to new cmd.logs['stdio'] scheme
1677 (Trial.commandComplete): same
1678 (BuildDebs.commandComplete): same
1680 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1681 LogFiles, instead of just a single one. The old single logfile is
1682 now called "stdio". LoggedRemoteCommand no longer creates a
1683 LogFile for you (the code to do that was broken anyway). If you
1684 don't create a "stdio" LogFile, then stdout/stderr will be
1686 (LogObserver): implement "LogObservers", which a BuildStep can add
1687 to parse the output of a command in real-time. The primary use is
1688 to provide more useful information to the Progress code, allowing
1689 better ETA estimates.
1690 (LogLineObserver): utility subclass which feeds complete lines to
1691 the parser instead of bytes.
1692 (BuildStep.progressMetrics): this is safer as a tuple
1693 (BuildStep.setProgress): utility method, meant to be called by
1695 (BuildStep.addLogObserver): new method, to be called at any time
1696 during the BuildStep (even before any LogFiles have been created),
1697 to attach (or schedule for eventual attachment) a LogObserver to a
1699 (StdioProgressObserver): new LogObserver which replaces the old
1700 "output" progress gatherer
1701 (LoggingBuildStep.__init__): same
1702 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1703 (LoggingBuildStep._commandComplete): must use logs['stdio']
1704 instead of the old single ".log" attribute.
1705 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1706 functionality, now subsumed into StdioProgressObserver
1707 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1708 log name changed from "output" to "stdio".
1711 * buildbot/interfaces.py (ILogFile): add the Interface used from
1712 the BuildStep towards the LogFile
1713 (ILogObserver): and the one provided by a LogObserver
1714 * buildbot/status/builder.py (LogFile): implement it
1716 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1717 HEADER constants here ..
1718 * buildbot/status/builder.py (STDOUT): .. from here
1720 2006-06-13 Brian Warner <warner@lothar.com>
1722 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1723 compatibility with python2.2, which doesn't have the 'substr in
1725 (TestP4Poller.makeTime): utility function to construct the
1726 timestamp using the same strptime() approach as p4poller does. It
1727 turns out that time.mktime() behaves slightly differently under
1728 python2.2, probably something to do with the DST flag, and that
1729 causes the test to fail under python2.2. (changing the mktime()
1730 arguments to have dst=0 instead of -1 caused it to fail under
1731 python2.3. Go figure.)
1732 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1734 2006-06-12 Brian Warner <warner@lothar.com>
1736 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1737 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1738 contributing such an excellent patch, including docs and unit
1739 tests! This makes it *so* much easier to apply. I had to update
1740 test_vc.py to handle some recent refactorings, but everything else
1741 applied smoothly. The only remaining thing I'd like to fix would
1742 be to remove the hard-wired port 1666 used by p4d, and allow it to
1743 claim any unused port. This would allow two copies of the test
1744 suite to run on the same host at the same time, as well as
1745 allowing the test suite to run while a real (production) p4d was
1746 running on the same host. Oh, and maybe we should add a warning to
1747 step.P4 that gets emitted if the slave is too old to provide the
1748 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1749 * buildbot/slave/commands.py (P4): same
1750 (P4Sync): same, some minor updates
1751 * buildbot/changes/p4poller.py: same
1752 * docs/buildbot.texinfo: same
1753 * buildbot/test/test_p4poller.py: same
1754 * buildbot/test/test_vc.py (P4): same
1756 * setup.py: add Trove classifiers for PyPI
1758 2006-06-08 Brian Warner <warner@allmydata.com>
1760 * buildbot/status/client.py
1761 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1762 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1763 build needs to be IRemote'd separately, rather than IRemote'ing
1764 the whole list at once. I can't wait until newpb's serialization
1765 adapters make this unnecessary.
1767 2006-06-06 Brian Warner <warner@lothar.com>
1769 * buildbot/process/step.py (WithProperties): make this inherit
1770 from ComparableMixin, so that reloading an unchanged config file
1771 doesn't cause us to spuriously reload any Builders which use them.
1772 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1775 2006-06-03 Brian Warner <warner@lothar.com>
1777 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1778 running py2exe on windows, contributed by Mark Hammond. Addresses
1779 SF#1401121, but I think we still need to include
1780 buildbot/scripts/sample.cfg
1781 * setup.py: include buildbot_service.py as a script under windows
1782 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1783 a py2exe application), get the icon/css datafiles from a different
1786 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1787 double-escape the build URL. Thanks to Olivier Bonnet for the
1788 patch. Fixes SF#1452801.
1790 2006-06-02 Brian Warner <warner@lothar.com>
1792 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1793 first six columns of 'svnlook' output, not just the first column,
1794 since property changes appear in the other five. Thanks to Olivier
1795 Bonnet for the patch. Fixes SF#1398174.
1797 2006-06-01 Brian Warner <warner@lothar.com>
1799 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1800 the fake build, so that title= has something to be set to
1802 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1803 attribute of the "Build #NN" link in the yellow start-the-build
1804 box to the build's reason. This means that you get a little
1805 tooltip explaining why the build was done when you hover over the
1806 yellow box. Thanks to Zandr Milewski for the suggestion.
1808 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1809 (Box.setETA): handle ETA=None (by stopping the timer)
1810 (Box.update): make the [soon] text less different than the usual
1811 text, so the rest of the text doesn't flop around so much. It
1812 would be awfully nice to figure out how to center this stuff.
1813 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1815 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1816 by default, so that any ShellCommand which fails marks the overall
1817 build as a failure. I should have done this from the beginning.
1818 Add flunkOnFailure=False to the arguments if you want to turn off
1821 2006-05-30 Brian Warner <warner@lothar.com>
1823 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1824 last-build/current-build/current-step. Show what step is currently
1825 running. Show ETA for both the overall build and the current step.
1826 Update GTK calls to modern non-deprecated forms. There's still a
1827 lot of dead code and debug noise to remove.
1829 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1830 shows up properly in status displays
1832 2006-05-28 Brian Warner <warner@lothar.com>
1834 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1835 build we use to verify that WithProperties works:
1837 ** set flunkOnFailure=True so that build failures get noticed
1838 ** set workdir='.' so that the build succeeds, otherwise it is trying
1839 to touch 'build/something', and 'build/' doesn't exist because
1840 usually that's created by a Source step
1841 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1842 this test somehow triggers, in which the 'touch' process becomes
1843 a zombie and we wait for th etimeout before giving up on it.
1845 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1846 to log the Build results and step logs to the twisted log.
1847 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1848 what went wrong if a build was expected to succeed but didn't.
1850 * buildbot/process/step_twisted.py (Trial): set the default
1851 trialMode to '--reporter=bwverbose', which specifies verbose
1852 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1853 '-to', but those are completely missing in modern Twisteds.
1855 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1856 a localhost-only port, to encourage better security
1858 * docs/buildbot.texinfo (Change Sources): mention
1861 * .darcs-boring: add a Darcs boringfile
1863 * README (REQUIREMENTS): stop claiming compatibility with
1866 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1869 2006-05-27 Brian Warner <warner@lothar.com>
1871 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1872 * docs/buildbot.texinfo: same
1874 2006-05-23 Brian Warner <warner@lothar.com>
1876 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1877 * docs/buildbot.texinfo: set version to match
1878 * NEWS: update for 0.7.3
1880 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1881 give a quick mapping from VC system to possible ChangeSources
1882 (Build Properties): add 'buildername'
1884 * buildbot/process/base.py (Build.setupStatus): oops, set
1885 'buildername' and 'buildnumber' properties
1886 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1889 2006-05-22 Brian Warner <warner@lothar.com>
1891 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1892 property interpolation better
1894 * README (INSTALLATION): remove old '-v' argument from recommended
1897 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1898 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1901 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1902 'svnversion' instead of grepping the output of 'svn info', much
1903 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1904 Bonnet for the suggestion.
1905 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1906 require the WC_PATH argument, so run 'svnversion .' instead.
1908 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1909 aren't supposed to have 'self' in their argument list
1911 2006-05-21 Brian Warner <warner@lothar.com>
1913 * buildbot/process/step.py (ShellCommand.start): make
1914 testInterpolate pass. I was passing the uninterpolated command to
1915 the RemoteShellCommand constructor
1916 (ShellCommand._interpolateProperties): oops, handle non-list
1917 commands (i.e. strings with multiple words separated by spaces in
1918 them) properly, instead of forgetting about them.
1920 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1921 to actually try to use build properties in a real build. This test
1923 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1924 to start and evaluate builds
1926 * buildbot/test/test__versions.py: add a pseudo-test to record
1927 what version of Twisted/Python/Buildbot are running. This should
1928 show up at the beginning of _trial_tmp/test.log, and exists to help
1929 debug other problems.
1931 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1932 a filename to be served as 'robots.txt' to discourage web spiders.
1933 Adapted from a patch by Tobi Vollebregt, thanks!
1934 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1935 (Waterfall.test_waterfall): tweak the way that filenames are put
1936 into the config file, to accomodate windows pathnames better.
1938 * docs/buildbot.texinfo (HTML Waterfall): document it
1940 * buildbot/process/process_twisted.py
1941 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1942 changed the build process. The new setup.py no longer takes the
1944 (FullTwistedBuildFactory.__init__): same
1945 (TwistedReactorsBuildFactory.__init__): same
1947 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1948 be placed in the [hooks] section of the central repository (the
1949 one that everybody pushes changes to).
1951 2006-05-20 Brian Warner <warner@lothar.com>
1953 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1954 .darcs-context file, use binary mode. I think this was causing a
1955 Darcs failure under windows.
1957 2006-05-19 Brian Warner <warner@lothar.com>
1959 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1960 use a timezone string of +0000 and gmtime, since this timestamp is
1961 sent to a buildmaster and %z is broken.
1963 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1964 string and localtime, since this timestamp will only be consumed
1965 locally, and %z is broken.
1967 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1968 gmtime, since this timestamp is returned to the buildmaster, and
1971 2006-05-18 Brian Warner <warner@lothar.com>
1973 * NEWS: update in preparation for next release
1975 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1976 setup-repository and do-we-have-the-vc-tools code into a separate
1977 "helper" class, which sticks around in a single module-level
1978 object. This seems more likely to continue to work in the future
1979 than having it hide in the TestCase and hope that TestCases stick
1980 around for a long time.
1982 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1983 addremove' has been deprecated in recent versions of mercurial, so
1984 use 'hg add' instead
1986 2006-05-07 Brian Warner <warner@lothar.com>
1988 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1989 operating under windows, move the file before opening it, since
1990 you can't rename a file that somebody has open.
1992 * buildbot/process/base.py (Build.setupBuild): if something goes
1993 wrong while creating a Step, log the name and arguments, since the
1994 error message when you get the number of arguments wrong is really
1997 2006-05-06 Brian Warner <warner@lothar.com>
1999 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2000 bugs in twisted-specific code not covered by my unit tests, this
2001 time use 'cmd' argument instead of self.cmd
2003 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2004 fix stupid braino: either use startwith or find()==0, not both.
2005 (TwistedReactorsBuildFactory.__init__): another dumb typo
2007 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2008 mark this test as TODO under windows, since process-killing seems
2009 dodgy there. We'll come back to this later and try to fix it
2012 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2013 and don't include a timezone
2014 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2015 This should avoid the windows-with-verbose-timezone-name problem
2017 (Patch.testPatch): add a test which runs 'patch' with less
2018 overhead than the full VCBase.do_patch sequence, to try to isolate
2019 a windows test failure. This one uses slave.commands.ShellCommand
2020 and 'patch', but none of the VC code.
2022 * buildbot/slave/commands.py (getCommand): use which() to find the
2023 executables for 'cvs', 'svn', etc. This ought to help under
2026 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2027 working directory before starting. If an earlier test failed, the
2028 leftover directory would mistakenly flunk a later test.
2029 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2030 Make sure that we use the right commandlines if which("tla") picks
2031 up "tla.exe" (as it does under windows).
2032 (TlaSupport.do_get): factor out this tla-vs-baz difference
2033 (TlaSupport.vc_create): more tla-vs-baz differences
2035 * buildbot/test/test_slavecommand.py
2036 (ShellBase.testShellMissingCommand): stop trying to assert
2037 anything about the error message: different shells on different
2038 OSes with different languages makes it hard, and it really isn't
2039 that interesting of a thing to test anyway.
2041 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2042 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2043 "Panther"), because it has a bug which flunks a couple tests in
2044 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2045 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2046 able to test that yet.
2048 2006-04-30 Brian Warner <warner@lothar.com>
2050 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2051 make sure child commands emit messages in english, so our regexps
2052 will match. Thanks to Nikaus Giger for identifying the problems.
2053 (VCBase._do_vctest_export_1): mode="export" is not responsible
2054 for setting the "got_revision" property, since in many cases it is
2055 not convenient to determine.
2056 (SVNSupport.capable): when running 'svn --version' to check for
2057 ra_local, we want error messages in english
2058 * buildbot/test/test_slavecommand.py
2059 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2060 to emit the error message in english
2062 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2063 the environment with $LC_ALL="C" so that Commands which need to
2064 parse the output of their child processes can obtain it in
2066 (SVN.parseGotRevision): call "svn info" afterwards instead of
2067 watching the output of the "svn update" or "svn checkout".
2068 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2069 (Arch.parseGotRevision): same
2070 (Bazaar.parseGotRevision): same
2071 (Mercurial.parseGotRevision): same
2073 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2074 $LC_ALL="C" when running commands under 'buildbot try', too
2076 * buildbot/test/__init__.py: remove the global os.environ()
2077 setting, instead we do it just for the tests that run commands and
2078 need to parse their output.
2080 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2081 remove the overly-short .timeout on this test, because non-DNotify
2082 platforms must fall back to polling which happens at 10 second
2083 intervals, so a 5 second timeout would never succeed.
2085 2006-04-24 Brian Warner <warner@lothar.com>
2087 * docs/buildbot.texinfo (Installing the code): update trial
2088 invocation, SF#1469116 by Niklaus Giger.
2089 (Attributes of Changes): updated branch-name examples to be
2090 a bit more realistic, SF#1475240 by Stephen Davis.
2092 * contrib/windows/buildbot2.bat: utility wrapper for windows
2093 developers, contributed by Nick Trout (after a year of neglect..
2094 sorry!). SF#1194231.
2096 * buildbot/test/test_vc.py (*.capable): store the actual VC
2097 binary's pathname in VCS[vcname], so it can be retrieved later
2098 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2099 strip out non-numeric timezone information, specifically the funky
2100 German string that his system produced that confuses CVS.
2101 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2102 allow Darcs tests to work on windows
2103 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2104 procutils.which() everywhere, to allow tryclient to work under
2105 windows. Also from Niklaus Giger, SF#1463394.
2107 * buildbot/twcompat.py (which): move the replacement for a missing
2108 twisted.python.procutils.which from test_vc.py to here, so it can
2109 be used in other places too (specifically tryclient.py)
2111 2006-04-23 Brian Warner <warner@lothar.com>
2113 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2114 bare buildbotURL/projectName line with a proper DIV, along with a
2115 CSS class of "title", from Stefan Seefeld (SF#1461675).
2116 (WaterfallStatusResource.body0): remove the redundant 'table'
2117 class from the table
2118 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2119 to the top-row TR, and class="Activity" to the second-row TR,
2120 rather than putting them in the individual TD nodes.
2122 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2123 'got_revision' build property for all VC systems that implement
2124 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2126 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2127 to determine which revision we actually obtained
2128 (CVS.parseGotRevision): implement this for CVS, which just means
2129 to grab a timestamp. Not ideal, and it depends upon the buildslave
2130 having a clock that is reasonably well syncronized with the server,
2131 but it's better than nothing.
2132 (SVN.parseGotRevision): implement it for SVN, which is accurate
2133 (Darcs.parseGotRevision): same
2134 (Arch.parseGotRevision): same
2135 (Bazaar.parseGotRevision): same
2136 (Mercurial.parseGotRevision): same
2138 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2139 keep a record of all non-stdout/stderr/header/rc status updates,
2140 for the benefit of RemoteCommands that send other useful things,
2142 (Source.commandComplete): put any 'got_revision' status values
2143 into a build property of the same name
2146 * buildbot/process/step_twisted.py (Trial): update to deal with
2147 new ShellCommand refactoring
2149 * docs/buildbot.texinfo (Build Properties): document new feature
2150 that allows BuildSteps to get/set Build-wide properties like which
2151 revision was requested and/or checked out.
2153 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2154 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2155 it. Note that this bumps the persistenceVersion of the saved Build
2156 object, so add the necessary upgrade-old-version logic to include
2157 an empty properties dict.
2159 * buildbot/process/base.py (Build.setProperty): implement it
2160 (Build.getProperty): same
2161 (Build.startBuild): change build startup to set 'branch',
2162 'revision', and 'slavename' properties at the right time
2164 * buildbot/process/step.py (BuildStep.__init__): change setup to
2165 require 'build' argument in a better way
2166 (LoggingBuildStep): split ShellCommand into two pieces, for better
2167 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2168 a single RemoteCommand that sends stdout/stderr status text. It
2169 also provides the usual commandComplete / createSummary /
2170 evaluateCommand / getText methods to be overridden...
2171 (ShellCommand): .. whereas ShellCommand is specifically for
2172 running RemoteShellCommands. Other shell-like BuildSteps (like
2173 Source) can inherit from LoggingBuildStep instead of ShellCommand
2174 (WithProperties): marker class to do build-property interpolation
2175 (Source): inherit from LoggingBuildStep instead of ShellCommand
2178 * buildbot/test/test_properties.py: test new functionality
2180 2006-04-21 Brian Warner <warner@lothar.com>
2182 * buildbot/test/test_vc.py: rename testBranch to
2183 testCheckoutBranch to keep the tests in about the right
2186 2006-04-18 Brian Warner <warner@lothar.com>
2188 * docs/buildbot.texinfo (PBListener): improve cross-references
2189 between PBListener and 'buildbot statusgui', thanks to John Pye
2192 2006-04-17 Brian Warner <warner@lothar.com>
2194 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2195 running under Twisted-1.3.0, otherwise skipped tests are reported
2198 * all: use isinstance() instead of 'type(x) is foo', suggested by
2201 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2202 oops, fix a brain-fade from the other week, when making the
2203 addStep changes. I changed all the __init__ upcalls to use the
2204 wrong superclass name.
2205 (FullTwistedBuildFactory.__init__): same
2206 (TwistedDebsBuildFactory.__init__): same
2207 (TwistedReactorsBuildFactory.__init__): same
2208 (TwistedBuild.isFileImportant): use .startswith for clarity,
2209 thanks to Neal Norwitz for the suggestions.
2211 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2212 changes, then deliver them over PB to a remote buildmaster.
2214 * contrib/svnpoller.py: added script by John Pye to poll a remote
2215 SVN repository (by running 'svn log') from a cronjob, and run
2216 'buildbot sendchange' to deliver the changes to a remote
2218 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2219 modification of svnpoller.py), same purpose, but this one loops
2220 internally (rather than expecting to run from a cronjob) and works
2222 * contrib/README.txt: same
2224 2006-04-11 Brian Warner <warner@lothar.com>
2226 * all: fix a number of incorrect names and missing imports, thanks
2227 to Anthony Baxter for the patch.
2228 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2229 remove unused buggy method.
2230 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2231 comes from shutil, not "shutils"
2232 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2233 (Arch.checkSlaveVersion): same
2234 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2236 * buildbot/process/step_twisted2.py: add some missing imports
2237 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2238 this code used to live in twisted.internet.defer
2240 2006-04-10 Brian Warner <warner@lothar.com>
2242 * buildbot/process/step.py (Mercurial): add Mercurial support
2243 * buildbot/slave/commands.py (Mercurial): same
2244 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2245 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2246 not yet tested, but 'try' support *is* covered
2247 * docs/buildbot.texinfo (Mercurial): document it
2249 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2250 some debugging messages (turned off)
2251 * buildbot/test/test_vc.py: improve debug messages
2253 2006-04-07 Brian Warner <warner@lothar.com>
2255 * buildbot/test/test_vc.py (which): define our own which() in case
2256 we can't import twisted.python.procutils, because procutils doesn't
2257 exist in Twisted-1.3
2259 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2260 of SlaveLocks for performance tests
2262 * docs/examples/twisted_master.cfg: update to match current usage
2264 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2265 password, p4 binary, pollinterval, maximum history to check.
2266 Patch from an anonymous sf.net contributor, SF#1219384.
2267 * buildbot/process/step.py (P4Sync.__init__): add username,
2268 password, and client arguments.
2269 * buildbot/slave/commands.py (P4Sync): same
2271 2006-04-05 Brian Warner <warner@lothar.com>
2273 * buildbot/process/factory.py (BuildFactory.addStep): new method
2274 to add steps to a BuildFactory. Use it instead of f.steps.append,
2275 and you can probably avoid using the s() convenience function.
2276 Patch from Neal Norwitz, sf.net #1412605.
2277 (other): update all factories to use addStep
2278 * buildbot/process/process_twisted.py: update all factories to use
2281 2006-04-03 Brian Warner <warner@lothar.com>
2283 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2284 work under windows too. Adapted from a patch by Niklaus Giger,
2285 addresses SF#1463399.
2287 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2288 spawned commands emit parseable results in english and not some
2289 other language. Patch from Niklaus Giger, SF#1463395.
2291 * README (INSTALLATION): discourage users from running unit tests on
2292 a "network drive", patch from Niklaus Giger, SF#1463394.
2294 2006-03-22 Brian Warner <warner@lothar.com>
2296 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2297 function to turn a repository-relative pathname into a (branch,
2298 branch-relative-filename) tuple. Change this function to handle
2299 the branch naming policy used by your Subversion repository.
2300 Thanks to AllMyData.com for sponsoring this work.
2302 2006-03-16 Brian Warner <warner@lothar.com>
2304 * buildbot/scripts/sample.cfg: add python-mode declaration for
2305 vim. Thanks to John Pye for the patch.
2307 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2308 command line, mention the importance of running 'crontab' as the
2309 buildmaster/buildslave user. Thanks to John Pye for the catch.
2311 2006-03-13 Brian Warner <warner@lothar.com>
2313 * buildbot/status/words.py (IRC): add an optional password=
2314 argument, which will be sent to Nickserv in an IDENTIFY message at
2315 login, to claim the nickname. freenode requires this before the
2316 bot can sent (or reply to) private messages. Thanks to Clement
2317 Stenac for the patch.
2318 * docs/buildbot.texinfo (IRC Bot): document it
2320 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2321 larger than chunkSize. Fixes SF#1349253.
2322 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2323 (Log.testConsumer): update to match new internal chunking behavior
2325 2006-03-12 Brian Warner <warner@lothar.com>
2327 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2329 * buildbot/test/test_maildir.py (MaildirTest): rename the
2330 'timeout' method, as it collides with trial's internals
2332 * buildbot/scripts/runner.py: add 'buildbot restart' command
2333 (stop): don't sys.exit() out of here, otherwise restart can't work
2334 * docs/buildbot.texinfo (Shutdown): document it
2336 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2337 * buildbot/status/html.py (Waterfall.__init__): same
2338 * buildbot/process/builder.py (Builder.startBuild): same
2339 * buildbot/process/base.py (BuildRequest): same
2340 * buildbot/sourcestamp.py (SourceStamp): same
2341 * buildbot/scheduler.py (Nightly): same
2343 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2345 * docs/buildbot.texinfo: same
2347 2006-02-17 Brian Warner <warner@lothar.com>
2349 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2350 * docs/buildbot.texinfo: set version number to match
2351 * NEWS: update for 0.7.2
2353 2006-02-16 Brian Warner <warner@lothar.com>
2355 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2357 2006-02-09 Brian Warner <warner@lothar.com>
2359 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2360 add text to explain per-build branch parameters
2361 * NEWS: mention --umask
2363 2006-02-08 Brian Warner <warner@lothar.com>
2365 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2367 (SlaveOptions.optParameters): add --umask, to make it possible to
2368 make buildslave-generated files (including build products) be
2371 * buildbot/slave/bot.py (BuildSlave.startService): same
2373 2006-01-23 Brian Warner <warner@lothar.com>
2375 * buildbot/status/builder.py: urllib.quote() all URLs that include
2376 Builder names, so that builders can include characters like '/'
2377 and ' ' without completely breaking the resulting HTML. Thanks to
2378 Kevin Turner for the patch.
2379 * buildbot/status/html.py: same
2380 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2382 * NEWS: update in preparation for upcoming release
2384 2006-01-18 Brian Warner <warner@lothar.com>
2386 * docs/examples/twisted_master.cfg: update to match the Twisted
2387 buildbot: remove python2.2, switch to exarkun's buildslaves,
2388 disable the .deb builder until we figure out how to build twisted
2389 .debs from SVN, add some ktrace debugging to the OS-X build
2390 process and remove the qt build, remove threadless builders,
2391 change freebsd builder to use landonf's buildslave.
2393 2006-01-12 Brian Warner <warner@lothar.com>
2395 * buildbot/master.py (Manhole.__init__): let port= be a strports
2396 specification string, but handle a regular int for backwards
2397 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2398 used in master.cfg to limit connections to just the local host.
2399 (BuildMaster.loadConfig): same for c['slavePortnum']
2400 * buildbot/scheduler.py (Try_Userpass.__init__): same
2401 * buildbot/status/client.py (PBListener.__init__): same
2402 * buildbot/status/html.py (Waterfall.__init__): same, for both
2403 http_port and distrib_port. Include backwards-compatibility checks
2404 so distrib_port can be a filename string and still mean unix:/foo
2405 * docs/buildbot.texinfo (Setting the slaveport): document it
2406 (Debug options): same
2407 (HTML Waterfall): same
2410 * buildbot/test/test_config.py (ConfigTest): test it
2412 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2413 slaveport's disownServiceParent deferred to fire before opening
2414 the new one. Fixes an annoying bug in the unit tests.
2416 2006-01-03 Brian Warner <warner@lothar.com>
2418 * buildbot/master.py (BuildMaster): remove the .schedulers
2419 attribute, replacing it with an allSchedulers() method that looks
2420 for all IService children that implement IScheduler. Having only
2421 one parent/child relationship means fewer opportunities for bugs.
2422 (BuildMaster.allSchedulers): new method
2423 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2424 also fix ugly bug that caused any config-file reload to
2425 half-forget about the earlier Schedulers, causing an exception
2426 when a Change arrived and was handed to a half-connected
2427 Scheduler. The exception was in scheduler.py line 54ish:
2428 self.parent.submitBuildSet(bs)
2429 exceptions.AttributeError: 'NoneType' object has no attribute
2431 (BuildMaster.addChange): update to use allSchedulers()
2433 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2434 to work properly with twisted-1.3.0, where you must explicitly
2435 include the __implements__ from parent classes
2436 (BaseScheduler.__repr__): make it easier to distinguish distinct
2438 (BaseUpstreamScheduler.__implements__): same
2440 * buildbot/status/builder.py (Status.getSchedulers): update to
2442 * buildbot/test/test_run.py (Run.testMaster): same
2443 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2444 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2445 make sure Scheduler instances are left alone when an identical
2446 config file is reloaded
2447 (ConfigElements.testSchedulers): make sure Schedulers are properly
2450 * Makefile (TRIALARGS): my local default Twisted version is now
2451 2.1.0, update the trial arguments accordingly
2453 2005-12-22 Brian Warner <warner@lothar.com>
2455 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2458 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2459 addChange in the parent class, although I suspect this should be
2460 fixed better in the future.
2462 2005-11-26 Brian Warner <warner@lothar.com>
2464 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2465 explode when branch==None, thanks to Kevin Turner for the catch
2466 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2469 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2471 * docs/buildbot.texinfo: same
2473 2005-11-26 Brian Warner <warner@lothar.com>
2475 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2476 * docs/buildbot.texinfo: set version number to match
2478 2005-11-26 Brian Warner <warner@lothar.com>
2480 * NEWS: update for 0.7.1
2482 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2483 sure that unsubscribe works even if we never sent an ETA update.
2484 Also, don't explode on duplicate unsubscribe.
2485 (BuildStepStatus.addLog): make the convenience "return self"-added
2486 watcher automatically unsubscribe when the Step finishes.
2487 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2488 (BuildStatus.stepStarted): same auto-unsubscribe
2489 (BuilderStatus.buildStarted): same auto-unsubscribe
2491 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2493 (IStatusReceiver.stepStarted): same
2494 (IStatusReceiver.logStarted): same
2496 * buildbot/test/test_run.py (Status): move the Status test..
2497 * buildbot/test/test_status.py (Subscription): .. to here
2499 2005-11-25 Brian Warner <warner@lothar.com>
2501 * NEWS: more updates
2503 * buildbot/locks.py: fix the problem in which loading a master.cfg
2504 file that changes some Builders (but not all of them) can result
2505 in having multiple copies of the same Lock. Now, the real Locks
2506 are kept in a table inside the BotMaster, and the Builders/Steps
2507 use "LockIDs", which are still instances of MasterLock and
2508 SlaveLock. The real Locks are instances of the new RealMasterLock
2509 and RealSlaveLock classes.
2510 * buildbot/master.py (BotMaster.getLockByID): new method to
2511 convert LockIDs into real Locks.
2512 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2513 into real Locks before building
2514 * buildbot/process/step.py (BuildStep.startStep): same
2515 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2516 exercises the problem
2519 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2520 what Schedulers are available
2522 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2523 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2524 'cron'-style build scheduling at certain times of day, week,
2526 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2528 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2529 handling: treat self.fileIsImportant more as an attribute that
2530 contains a callable than as a method. If the attribute is None,
2531 don't call it and assume all filenames are important. It is still
2532 possible to provide a fileIsImportant method in a subclass,
2534 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2536 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2537 test using AnyBranchScheduler with fileIsImportant=None
2539 2005-11-24 Brian Warner <warner@lothar.com>
2541 * buildbot/test/test_config.py (StartService): don't claim a fixed
2542 port number, instead set slavePort=0 on the first pass, figure out
2543 what port was allocated, then switch to a config file that uses
2546 * buildbot/master.py (BuildMaster.loadConfig): close the old
2547 slaveport before opening the new one, because unit tests might
2548 replace slavePort=0 with the same allocated portnumber, and if we
2549 don't wait for the old port to close first, we get a "port already
2550 in use" error. There is a tiny race condition here, but the only
2551 threat is from other programs that bind (statically) to the same
2552 port number we happened to be allocated, and only if those
2553 programs use SO_REUSEADDR, and only if they get control in between
2556 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2558 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2559 deleted ChangeSources before adding any new ones
2560 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2561 compare_attrs, to make sure that a config-file reload does not
2562 unnecessarily replace an unmodified ChangeSource instance
2563 * buildbot/test/test_config.py (ConfigTest.testSources): update
2565 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2566 mean "don't build anything", and add a warning if it gets used
2567 because it isn't actually useful.
2569 * contrib/svn_buildbot.py: update example usage to match the port
2570 number that gets used by the PBChangeSource
2571 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2573 2005-11-22 Brian Warner <warner@lothar.com>
2575 * NEWS: start collecting items for next release
2577 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2578 revisions are strings
2579 (P4Sync.computeSourceRevision): same
2581 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2582 to the Buildbot's overall status page
2583 (StatusResourceBuilder.body): same
2585 2005-11-15 Brian Warner <warner@lothar.com>
2587 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2588 config-file loading, specifically to make sure old StatusTargets
2589 are finished shutting down before new ones start up (thus
2590 resolving a bug in which changing the Waterfall object would fail
2591 because both new and old instances were claiming the same
2592 listening port). Also load new Schedulers after all the new
2593 Builders are set up, in case they fire off a new build right away.
2594 * buildbot/test/test_config.py (StartService): test it
2596 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2597 the branch name to the mail body
2599 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2600 Without it, a config-file reload fails to update an existing
2602 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2603 username/passwd to compare_attrs, for the same reason
2604 * buildbot/status/html.py (Waterfall): add favicon to
2605 compare_attrs, same reason
2607 2005-11-05 Brian Warner <warner@lothar.com>
2609 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2610 baserev before stuffing it in the jobfile. This resolves problems
2611 under SVN (and probably Arch) where revisions are expressed as
2612 numbers. I'm inclined to use string-based revisions everywhere in
2613 the future, but this fix should be safe for now. Thanks to Steven
2614 Walter for the patch.
2616 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2617 binary mode when opening pickle files, to make windows work
2618 better. Thanks to Dobes Vandermeer for the catch.
2619 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2620 (BuilderStatus.getBuildByNumber): same
2621 (Status.builderAdded): same
2622 * buildbot/master.py (BuildMaster.loadChanges): same
2624 * buildbot/util.py (Swappable): delete unused leftover code
2626 * buildbot/process/step.py (SVN): when building on a non-default
2627 branch, add the word "[branch]" to the VC step's description, so
2628 it is obvious that we're not building the usual stuff. Likewise,
2629 when we are building a specific revision, add the text "rNNN" to
2630 indicate what that revision number is. Thanks to Brad Hards and
2631 Nathaniel Smith for the suggestion.
2632 (Darcs.startVC): same
2633 (Arch.startVC): same
2634 (Bazaar.startVC): same
2636 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2637 typo, caught by Mark Dillavou, closes SF#1216636.
2639 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2640 about a test to add some day
2642 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2643 the 'full-2.3' build, and the 'reactors' build is now run under
2644 python-2.4 because the buildslave no longer has gtk/etc bindings
2645 for earlier versions.
2647 2005-11-03 Brian Warner <warner@lothar.com>
2649 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2650 method, takes an IBuildStatus and rebuilds it. It might make more
2651 sense to add this to IBuildControl instead, but that instance goes
2652 away completely once the build has finished, and resubmitting
2653 builds can take place weeks later.
2654 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2655 * buildbot/status/html.py (StatusResourceBuild): also stash an
2656 IBuilderControl so we can use resubmitBuild.
2657 (StatusResourceBuild.body): render "resubmit" button if we can.
2658 Also add hrefs for each BuildStep
2659 (StatusResourceBuild.rebuild): add action for "resubmit" button
2660 (StatusResourceBuilder.getChild): give it an IBuilderControl
2662 * buildbot/status/builder.py (Status.getURLForThing): change the
2663 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2664 that live as targets of buttons like "stop" and "rebuild" can't
2666 * buildbot/status/builder.py (Status.getURLForThing): same
2667 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2668 (StepBox.getBox): same
2669 * buildbot/test/test_web.py (GetURL): same
2672 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2673 exclusivity checks after Source.__init__ upcall, so misspelled
2674 arguments will be reported more usefully
2675 (Darcs.__init__): same
2677 2005-10-29 Brian Warner <warner@lothar.com>
2679 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2680 builder. Move the Try scheduler off to a separate port.
2682 2005-10-27 Brian Warner <warner@lothar.com>
2684 * buildbot/clients/gtkPanes.py
2685 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2686 to cause the app to crash, now they don't.
2688 * buildbot/clients/debug.py: display the buildmaster's location
2689 in the window's title bar
2691 2005-10-26 Brian Warner <warner@lothar.com>
2693 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2694 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2695 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2697 * buildbot/status/html.py (td): put a single non-breaking space
2698 inside otherwise empty <td> elements, as a workaround for buggy
2699 browsers which would optimize them away (along with any associated
2700 styles, like the kind that create the waterfall grid borders).
2701 Patch from Frerich Raabe.
2703 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2704 argv-list as an argument, defaulting to ["-to"], which is
2705 appropriate for the Trial that comes with Twisted-2.1.0 and
2706 earlier. The Trial in current Twisted SVN wants
2707 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2708 defaults to an empty list.
2709 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2710 match it, now that trialMode= is a list instead of a single string
2712 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2714 * docs/buildbot.texinfo: same
2716 2005-10-24 Brian Warner <warner@lothar.com>
2718 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2719 * docs/buildbot.texinfo: set version number to match
2721 2005-10-24 Brian Warner <warner@lothar.com>
2723 * README: update for 0.7.0
2725 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2727 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2728 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2729 send the branch= argument unless the user really provided one, to
2730 retain compatibility with older buildmasters that don't accept
2732 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2735 * docs/buildbot.texinfo: update lots of stuff
2737 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2738 to the 'buildbot sendchange' command
2739 * buildbot/clients/sendchange.py (Sender.send): same
2740 * buildbot/changes/pb.py (ChangePerspective): same
2741 * buildbot/test/test_changes.py (Sender.testSender): test it
2743 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2744 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2745 for consistency with other BuildStep arguments that use camelCase.
2746 Well, at least more of them use camelCase (like flunkOnWarnings)
2747 than don't.. I wish I'd picked one style and stuck with it
2748 earlier. Annoying, but it's best done before the release, since
2749 these arguments didn't exist at all in 0.6.6 .
2751 * buildbot/test/test_vc.py (SVN.testCheckout): same
2752 (Darcs.testPatch): same
2753 * docs/buildbot.texinfo (SVN): document the change
2754 (Darcs): same, add some build-on-branch docs
2755 * docs/examples/twisted_master.cfg: match change
2757 * buildbot/process/step.py (BuildStep): rename
2758 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2759 how it is normally used.
2760 * buildbot/test/test_steps.py (Version.checkCompare): same
2762 * buildbot/process/step.py (CVS.startVC): refuse to build
2763 update/copy -style builds on a non-default branch with an old
2764 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2765 concern is that it will do a VC 'update' in an existing tree when
2766 it is supposed to be switching branches (and therefore clobbering
2767 the tree to do a full checkout), thus building the wrong source.
2768 This used to be a warning, but I think the confusion it is likely
2769 to cause warrants making it an error.
2770 (SVN.startVC): same, also make mode=export on old slaves an error
2771 (Darcs.startVC): same
2772 (Git.startVC): improve error message for non-Git-enabled slaves
2773 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2774 specific revision is built on a slave that doesn't pay attention
2775 to args['revision'], because for slowly-changing trees it will
2776 probably do the right thing, and because we have no way to tell
2777 whether we're asking it to build the most recent version or not.
2778 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2780 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2781 that 'master' is in host:portnum format, to catch errors sooner
2783 2005-10-23 Brian Warner <warner@lothar.com>
2785 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2786 when creating the list of warning messages, include the line
2787 immediately after each WARNING: line, since that's usually where
2788 the file and line number wind up.
2790 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2795 2005-10-22 Brian Warner <warner@lothar.com>
2797 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2798 patch from Brad Hards
2799 * buildbot/status/classic.css: same
2800 * buildbot/test/test_web.py (Waterfall): match changes
2802 * buildbot/test/test_steps.py (BuildStep.setUp): set
2803 nextBuildNumber so the test passes
2804 * buildbot/test/test_status.py (MyBuilder): same
2806 * buildbot/status/html.py (StatusResourceBuild.body): revision
2807 might be numeric, so stringify it before html-escapifying it
2808 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2809 timer for the upcoming build
2810 * buildbot/status/classic.css: add background-color attributes for
2811 offline/waiting/building classes
2813 * buildbot/status/builder.py (BuildStatus): derive from
2814 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2815 the default (i.e. unknown) .slavename to "???" instead of None,
2816 since even unknown slavenames need to be printed eventually.
2817 (BuilderStatus): also derive from styles.Versioned . More
2818 importantly, determine .nextBuildNumber at creation/unpickling
2819 time by scanning the directory of saved BuildStatus instances and
2820 choosing one larger than the highest-numbered one found. This
2821 should fix the problem where random errors during upgrades cause
2822 the buildbot to forget about earlier builds. .nextBuildNumber is
2823 no longer stored in the pickle.
2824 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2825 at least log the error. Also call Builder.determineNextBuildNumber
2826 once the basedir is set.
2828 * buildbot/master.py (BuildMaster.loadChanges): do
2829 styles.doUpgrade afterwards, in case I decide to make Changes
2830 derived from styles.Versioned some day and forget to make this
2834 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2835 when running under older pythons (<2.3) in which the shlex module
2836 doesn't have a 'split' function.
2838 * buildbot/process/step.py (ShellCommand.start): make
2839 errorMessages= be a list of strings to stuff in the log before the
2840 command actually starts. This makes it easier to flag multiple
2841 warning messages, e.g. when the Source steps have to deal with an
2843 (CVS.startVC): handle slaves that don't handle multiple branches
2844 by switching into 'clobber' mode
2845 (SVN.startVC): same. Also reject branches without base_url
2846 (Darcs.startVC): same. Also reject revision= in older slaves
2847 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2848 (Bazaar.startVC): same, and test for baz separately than for arch
2850 * buildbot/slave/commands.py (cvs_ver): document new features
2852 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2853 (BuildStep.slaveVersionNewEnough): more useful utility method
2854 * buildbot/test/test_steps.py (Version): start testing it
2856 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2857 the 'force' command requires python2.3, for the shlex.split method
2859 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2860 since we don't use it anymore. The Twisted buildbot uses a
2863 2005-10-21 Brian Warner <warner@lothar.com>
2865 * buildbot/process/process_twisted.py: rework all BuildFactory
2866 classes to take a 'source' step as an argument, instead of
2867 building up the SVN instance in the factory.
2868 * docs/examples/twisted_master.cfg: enable build-on-branch by
2869 providing a base_url and default_branch
2871 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2872 control over --branch and --revision, not that they are always
2874 * buildbot/status/html.py (StatusResourceBuilder.force): same
2875 (StatusResourceBuild.body): display SourceStamp components
2877 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2878 IRC 'force' command, so it can be shared with an eventual
2879 command-line-tool 'buildbot force' mode.
2880 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2882 2005-10-20 Brian Warner <warner@lothar.com>
2884 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2886 * docs/examples/twisted_master.cfg: update to use Schedulers
2888 * buildbot/scripts/sample.cfg: update with Schedulers
2890 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2891 method specifically for use by HTML "force build" button and the
2892 IRC "force" command. Raises an immediate error if there are no
2894 (IBuilderControl.requestBuild): make this just submit a build, not
2895 try to check for existing slaves or set up any when-finished
2896 Deferreds or anything.
2897 * buildbot/process/builder.py (BuilderControl): same
2898 * buildbot/status/html.py (StatusResourceBuilder.force): same
2899 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2900 * buildbot/test/test_slaves.py: same
2901 * buildbot/test/test_web.py: same
2903 2005-10-19 Brian Warner <warner@lothar.com>
2905 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2906 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2908 2005-10-18 Brian Warner <warner@lothar.com>
2910 * buildbot/status/html.py: provide 'status' argument to most
2911 StatusResourceFOO objects
2912 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2913 and Logfiles" section to make the Build page into a more-or-less
2914 comprehensive source of status information about the build
2916 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2917 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2919 2005-10-17 Brian Warner <warner@lothar.com>
2921 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2922 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2923 out what to do about other projects: the correct options for
2924 recent Twisteds will not work for older ones.
2926 2005-10-15 Brian Warner <warner@lothar.com>
2928 * buildbot/status/builder.py (Status.getURLForThing): add method
2929 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2930 use this in email/IRC status clients to make them more useful, by
2931 providing the end user with hints on where to learn more about the
2932 object being reported on.
2933 * buildbot/test/test_web.py (GetURL): tests for it
2935 2005-10-14 Brian Warner <warner@lothar.com>
2937 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2938 fix bug resulting from deferredResult changes
2940 2005-10-13 Brian Warner <warner@lothar.com>
2942 * buildbot/test/test_changes.py: remove use of deferredResult
2943 * buildbot/test/test_config.py: same
2944 * buildbot/test/test_control.py: same
2945 * buildbot/test/test_status.py: same
2946 * buildbot/test/test_vc.py: this is the only remaining use, since
2947 it gets used at module level. This needs to be replaced by some
2948 sort of class-level run-once routine.
2950 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2952 * lots: implement multiple slaves per Builder, which means multiple
2953 current builds per Builder. Some highlights:
2954 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2955 of (state,currentBuilds) instead of (state,currentBuild)
2956 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2957 (IBuildStatus.getSlavename): new method, so you can tell which
2958 slave got used. This only gets set when the build completes.
2959 (IBuildRequestStatus.getBuilds): new method
2961 * buildbot/process/builder.py (SlaveBuilder): add a .state
2962 attribute to track things like ATTACHING and IDLE and BUILDING,
2964 (Builder): .. the .slaves attribute here, which has been turned
2965 into a simple list of available slaves. Added a separate
2966 attaching_slaves list to track ones that are not yet ready for
2968 (Builder.fireTestEvent): put off the test-event callback for a
2969 reactor turn, to make tests a bit more consistent.
2970 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2971 ping fails due to an exception. This needs work, I'm worried that
2972 a code error could lead to a constantly re-connecting slave.
2973 Especially since I'm trying to move to a distinct remote_ping
2974 method, separate from the remote_print that we currently use.
2975 (BuilderControl.requestBuild): return a convenience Deferred that
2976 provides an IBuildStatus when the build finishes.
2977 (BuilderControl.ping): ping all connected slaves, only return True
2978 if they all respond.
2980 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2981 reconnect when we shut down.
2983 * buildbot/status/builder.py: implement new methods, convert
2984 one-build-at-a-time methods to handle multiple builds
2985 * buildbot/status/*.py: do the same in all default status targets
2986 * buildbot/status/html.py: report the build's slavename in the
2987 per-Build page, report all buildslaves on the per-Builder page
2989 * buildbot/test/test_run.py: update/create tests
2990 * buildbot/test/test_slaves.py: same
2991 * buildbot/test/test_scheduler.py: remove stale test
2993 * docs/buildbot.texinfo: document the new builder-specification
2994 'slavenames' parameter
2996 2005-10-12 Brian Warner <warner@lothar.com>
2998 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2999 report failure correctly, causing Dependent builds to run when
3000 they shouldn't have.
3001 * buildbot/status/builder.py (BuildSetStatus): same
3002 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3003 (Set.testSuccess): test the both-pass case too
3004 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3005 fix this test: it was ending too early, masking the failure before
3006 (Logger): specialized StatusReceiver to make sure the dependent
3007 builds aren't even started, much less completed.
3009 2005-10-07 Brian Warner <warner@lothar.com>
3011 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3012 bot.SlaveBuilder being disowned in the middle of a build
3014 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3015 this inherit from StatusReceiver. Also upcall in __init__. This
3016 fixes the embarrasing crash when the new buildSetSubmitted method
3017 is invoked and Waterfall/etc don't implement their own.
3018 * buildbot/test/test_run.py: add a TODO note about a test to catch
3019 just this sort of thing.
3021 * buildbot/process/builder.py (Builder.attached): remove the
3022 already-attached warning, this situation is normal. Add some
3023 comments explaining it.
3025 2005-10-02 Brian Warner <warner@lothar.com>
3027 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3028 OverflowError when setting up dnotify, because some 64-bit systems
3029 have problems with signed-vs-unsigned constants and trip up on the
3030 DN_MULTISHOT flag. Patch from Brad Hards.
3032 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3034 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3035 progressMetrics, description, descriptionDone to the 'parms' list,
3036 and make use the 'parms' list from the implementation class
3037 instead of only BuildStep to initialize the parameters. This
3038 allows buildbot.process.factory.s() to initialize all the parms,
3039 not just those defined in directly by BuildStep.
3041 2005-09-03 Brian Warner <warner@lothar.com>
3043 * NEWS: start adding items for the next release
3045 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3046 python2.2 tests, change 'Quick' builder to only use python2.3
3048 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3050 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3051 the "Ping Builder" button if the build control is available; the
3052 user sees an exception otherwise
3054 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3056 2005-09-01 Brian Warner <warner@lothar.com>
3058 * buildbot/interfaces.py (IBuilderStatus.getState): update
3059 signature, point out that 'build' can be None
3060 (IBuildStatus.getETA): point out ETA can be none
3062 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3064 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3066 2005-08-31 Brian Warner <warner@lothar.com>
3068 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3069 update to match correct signature: removed 'eta' argument
3070 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3072 2005-08-30 Brian Warner <warner@lothar.com>
3074 * buildbot/status/builder.py (LogFile): remove the assertion that
3075 blows up when you try to overwrite an existing logfile, instead
3076 just emit a warning. This case gets hit when the buildmaster is
3077 killed and doesn't get a chance to write out the serialized
3078 BuilderStatus object, so the .nextBuildNumber attribute gets out
3081 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3082 the 'buildbot sendchange' arguments, for the Darcs context file
3083 * docs/buildbot.texinfo (sendchange): document it
3085 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3086 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3087 (IStatus.getSchedulers): new method
3088 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3089 (Status.getSchedulers): implement
3090 * buildbot/process/builder.py (Builder): maintain
3091 BuilderStatus.pendingBuilds
3092 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3093 (TryBase.addChange): Try schedulers should ignore Changes
3095 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3096 for 'try' on CVS/SVN
3097 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3099 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3100 report status properly.
3101 (Try.createJob): implement unique buildset IDs
3103 * buildbot/status/client.py (StatusClientPerspective): add a
3104 perspective_getBuildSets method for the benefit of jobdir-style
3106 * docs/buildbot.texinfo (try): more docs
3107 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3110 2005-08-18 Brian Warner <warner@lothar.com>
3112 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3113 actually work. It's functional but still kind of clunky. Also, it
3114 only works with the pb-style.. needs to be made to work with the
3117 * buildbot/status/client.py (RemoteBuildSet): new class
3118 (RemoteBuildRequest): same
3119 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3120 object, not the internal BuildStatus object.
3121 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3122 outside of the usual buildStarted() return value.
3123 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3125 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3126 (Try_Userpass_Perspective.perspective_try): return a remotely
3127 usable BuildSetStatus object
3129 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3130 isStarted()/waitUntilStarted()
3132 2005-08-16 Brian Warner <warner@lothar.com>
3134 * buildbot/status/builder.py: implement IBuildSetStatus and
3135 IBuildRequestStatus, wire them into place.
3136 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3137 methods into the BuildSetStatus object.
3138 * buildbot/interfaces.py: same
3139 (IStatus.getBuildSets): new method to get pending BuildSets
3140 (IStatusReceiver.buildsetSubmitted): new method which hears about
3142 * buildbot/master.py (BuildMaster.submitBuildSet): same
3143 * buildbot/process/base.py (BuildRequest): same, replace
3144 waitUntilStarted with subscribe/unsubscribe
3145 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3146 subscribe instead of waitUntilStarted
3147 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3149 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3151 * buildbot/test/test_buildreq.py: update for new code
3152 * buildbot/test/test_control.py (Force.testRequest): same
3155 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3156 for Darcs to not use the tempfile module, so it works under
3157 python-2.2 too. We really didn't need the full cleverness of that
3158 module, since the slave has exclusive control of its own builddir.
3160 2005-08-15 Brian Warner <warner@lothar.com>
3162 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3163 for CVS trees. It doesn't work for non-trunk branches,
3165 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3168 * Makefile: make it easier to test against python2.2
3170 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3171 tearDown2, so things like Arch can unregister archives as they're
3172 shutting down. The previous subclass-override-tearDown technique
3173 resulted in a nested maybeWait() and test failures under
3176 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3177 where we can (Arch), add a branch= argument to set the branch used
3179 (BazExtractor): extract the branch too
3180 (TlaExtractor): same
3181 * buildbot/scripts/runner.py (TryOptions): add --branch
3182 * docs/buildbot.texinfo (try): document --branch/try_branch
3184 * buildbot/slave/commands.py (Darcs): implement get-revision for
3185 Darcs, so that 'try' will work. This requires the tempfile module
3188 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3189 of revisions, branches, and 'try' in the process.
3191 2005-08-11 Brian Warner <warner@lothar.com>
3193 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3194 this, it got broken at some point in the last few releases
3195 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3196 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3197 specifically the removal of ETA information from the tuple
3199 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3202 * docs/buildbot.texinfo (try): document both --builder and
3203 'try_builders' in .buildbot/options
3204 * buildbot/scripts/runner.py (TryOptions): add --builder,
3205 accumulate the values into opts['builders']
3206 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3207 * buildbot/test/test_runner.py (Try): add some quick tests to make
3208 sure 'buildbot try --options' and .buildbot/options get parsed
3209 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3210 use --builder control
3212 * docs/buildbot.texinfo (try): add --port argument to PB style
3214 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3215 actual SourceStamp. Still need to extract a branch name, somehow.
3216 (Try): finish implementing the try client side, still need a UI
3217 for specifying which builders to use
3218 (Try.getopt): factor our options/config-file reading
3219 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3221 * buildbot/test/test_vc.py: match SourceStampExtractor change
3223 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3224 causes the twisted log to be sent to stderr
3226 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3228 2005-08-10 Brian Warner <warner@lothar.com>
3230 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3231 style is 90% done, still missing status reporting or waiting for
3232 the buildsets to finish, and it is completely untested.
3234 * buildbot/trybuild.py: delete file, move contents to ..
3235 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3236 * buildbot/test/test_vc.py: match the move
3238 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3239 of the TryScheduler, no buildsetID or status-tracking support yet
3240 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3242 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3243 possible to set the basedir after __init__ time, so it is easier
3244 to use as a Service-child of the BuildMaster instance
3246 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3247 that delivers messages to its Service parent instead of requiring
3248 a subclass to be useful. This turns out to be much easier to build
3251 * buildbot/scripts/tryclient.py (createJob): utility code to
3252 create jobfiles, will eventually be used by 'buildbot try'
3254 2005-08-08 Brian Warner <warner@lothar.com>
3256 * docs/buildbot.texinfo (try): add docs on the
3257 as-yet-unimplemented Try scheduler
3259 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3260 * buildbot/test/test_scheduler.py: .. here
3261 (Scheduling.testTryJobdir): add placeholder test for 'try'
3263 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3264 addEntry merging (>=chunkSize) behavior
3265 (Log.testConsumer): update to handle new callLater(0) behavior
3267 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3268 both the MAX_LENGTH bugfix and the resumeProducing hang.
3270 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3271 put off the actual resumeProducing for a moment with
3272 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3273 causes large logfiles to hang midway through.
3275 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3276 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3277 and to improve memory usage when streaming the file out to a web
3279 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3280 make this work cleanly
3282 2005-08-03 Brian Warner <warner@lothar.com>
3284 * buildbot/trybuild.py: new file for 'try' utilities
3285 (getSourceStamp): run in a tree, find out the baserev+patch
3286 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3287 implemented for SVN and Darcs, still working on Arch. I don't know
3288 how to make CVS work yet.
3290 * docs/buildbot.texinfo: document the 'buildbot' command-line
3291 tool, including the not-yet-implemented 'try' feature, and the
3292 in-flux .buildbot/ options directory.
3294 2005-07-20 Brian Warner <warner@lothar.com>
3296 * buildbot/locks.py: added temporary id() numbers to Lock
3297 descriptions, to track down a not-really-sharing-the-Lock bug
3299 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3301 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3302 needed for python2.2 compatibility
3303 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3304 are from the __future__
3306 2005-07-19 Brian Warner <warner@lothar.com>
3308 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3309 message when schedulers use unknown builders
3311 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3312 SlaveLock('name') and MasterLock('name') are distinct
3314 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3315 c['schedulers'] in such a way that we can actually accept
3317 * buildbot/test/test_config.py: check it
3319 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3320 utility method to *all* the Schedulers
3321 (Periodic.listBuilderNames): same
3323 * docs/buildbot.texinfo (Interlocks): update chapter to match
3326 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3327 to make sure that c['sources'], c['schedulers'], and c['status']
3328 are all lists of the appropriate objects, and that the Schedulers
3329 all point to real Builders
3330 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3331 'listBuilderNames' utility method to support this
3332 * buildbot/scheduler.py: implement the utility method
3333 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3335 * docs/buildbot.texinfo: add some @cindex entries
3337 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3338 if it wasn't already set: most tla commands will fail unless one
3340 (Arch.createRepository): and disable bazaar's revision cache, since
3341 they cause test failures (the multiple repositories we create all
3342 interfere with each other through the cache)
3344 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3345 bring it properly up to date with twisted-2.0 test guidelines
3347 * buildbot/master.py (BuildMaster): remove references to old
3348 'interlock' module, this caused a bunch of post-merge test
3350 * buildbot/test/test_config.py: same
3351 * buildbot/process/base.py (Build): same
3353 * buildbot/test/test_slaves.py: stubs for new test case
3355 * buildbot/scheduler.py: add test-case-name tag
3356 * buildbot/test/test_buildreq.py: same
3358 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3359 unnecessary init code
3360 (Bot.remote_setBuilderList): match it
3362 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3364 * buildbot/changes/mail.py (parseSyncmail): update comment
3366 * buildbot/test/test_slavecommand.py: disable Shell tests on
3367 platforms that don't suport IReactorProcess
3369 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3370 all places where we open logfiles. It causes OS-X to open the file
3371 in some weird mode that that prevents us from mixing reads and
3372 writes to the same filehandle, which we depend upon to implement
3373 _generateChunks properly. This change doesn't appear to break
3374 win32, on which "b" and "t" are treated differently but a missing
3375 flag seems to be interpreted as "t".
3377 2005-07-18 Brian Warner <warner@lothar.com>
3379 * buildbot/slave/commands.py (ShellCommand): overhaul
3380 error-handling code, to try and make timeout/interrupt work
3381 properly, and make win32 happier
3382 * buildbot/test/test_slavecommand.py: clean up, stop using
3383 reactor.iterate, add tests for timeout and interrupt
3384 * buildbot/test/sleep.py: utility for a new timeout test
3386 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3387 code from the local-usebranches branch
3389 2005-07-17 Brian Warner <warner@lothar.com>
3391 * buildbot/process/process_twisted.py
3392 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3393 minutes, to match the other twisted BuildFactories, and don't
3394 excuse failures in c/qt/win32 reactors any more.
3396 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3397 'freebsd' builders, since the buildslaves have been unavailable
3400 2005-07-13 Brian Warner <warner@lothar.com>
3402 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3403 build-on-branch feature
3405 * buildbot/process/step.py (Darcs.__init__): add base_url and
3406 default_branch arguments, just like SVN
3407 (Arch.__init__): note that the version= argument is really the
3410 * buildbot/slave/commands.py (SourceBase): keep track of the
3411 repository+branch that was used for the last checkout in
3412 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3413 match, we clobber the directory and perform a fresh checkout
3414 rather than trying to do an in-place update. This should protect
3415 us against trying to get to branch B by doing an update in a tree
3416 obtained from branch A.
3417 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3418 (SVN.setup): same, just the svnurl
3419 (Darcs.setup): same, just the repourl
3420 (Arch.setup): same, arch coordinates (url), version, and
3421 buildconfig. Also pull the buildconfig from the args dictionary,
3422 which we weren't doing before, so the build-config was effectively
3424 (Arch.sourcedirIsUpdateable): don't try to update when we're
3425 moving to a specific revision: arch can't go backwards, so it is
3426 safer to just clobber the tree and checkout a new one at the
3428 (Bazaar.setup): same sourcedata as Arch
3430 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3431 use maybeWait, to work with twisted-1.3.0 and twcompat
3432 (Dependencies.testRun_Pass): same
3434 * buildbot/test/test_vc.py: rearrange, cleanup
3436 * buildbot/twcompat.py: add defer.waitForDeferred and
3437 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3438 can work under twisted-1.3.0 .
3440 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3441 now created at setUp time. This increases the runtime of the test
3442 suite considerably (from 91 seconds to 151), but it removes the
3443 need for an offline tarball, which should solve a problem I've
3444 seen where the test host has a different version of svn than the
3445 tarball build host. The new code also validates that mode=update
3446 really picks up recent commits. This approach will also make it
3447 easier to test out branches, because the code which creates the VC
3448 branches is next to the code which uses them. It will also make it
3449 possible to test some change-notification hooks, by actually
3450 performing a VC commit and watching to see the ChangeSource get
3453 2005-07-12 Brian Warner <warner@lothar.com>
3455 * docs/buildbot.texinfo (SVN): add branches example
3456 * docs/Makefile (buildbot.ps): add target for postscript manual
3458 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3459 * buildbot/test/test_locks.py: same
3461 * buildbot/process/step.py (Darcs): comment about default branches
3463 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3464 c['interlocks'] in the config file, complain if it is present.
3465 Scan all locks in c['builders'] to make sure the Locks they use
3467 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3468 add some tests to check for non-uniquely-named Locks
3469 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3470 since the unique-Lock validation code requires it now
3472 * buildbot/locks.py: fix test-case-name
3474 * buildbot/interlock.py: remove old file
3476 2005-07-11 Brian Warner <warner@lothar.com>
3478 * buildbot/test/test_interlock.py: rename to..
3479 * buildbot/test/test_locks.py: .. something shorter
3481 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3482 versions (after 2.0.1) changed internet.TCPClient to shut down the
3483 connection in stopService. Change the code to handle this
3486 * buildbot/process/base.py (Build): handle whole-Build locks
3487 * buildbot/process/builder.py (Builder.compareToSetup): same
3488 * buildbot/test/test_interlock.py: make tests work
3490 * buildbot/process/step.py (BuildStep.startStep): complain if a
3491 Step tries to claim a lock that's owned by its own Build
3492 (BuildStep.releaseLocks): typo
3494 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3495 file reloads don't replace unchanged Builders
3497 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3498 rewrite to cover new Locks instead of old c['interlocks']
3499 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3503 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3504 start the master and connect the buildslave
3506 * buildbot/process/step.py (FailingDummy.done): finish with a
3507 FAILURE status rather than raising an exception
3509 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3510 stringify a BuildRequest.reason that is None
3512 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3514 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3515 allow scheduler.Dependent to work
3516 * buildbot/buildset.py (BuildSet): set .reason and .results
3518 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3519 slaves, to make the test stop hanging. It still fails, of course,
3520 because I haven't even started to implement Locks.
3522 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3524 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3525 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3526 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3527 (Dependent): new class for downstream build dependencies
3528 * buildbot/test/test_dependencies.py: tests (still failing)
3530 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3532 2005-07-07 Brian Warner <warner@lothar.com>
3534 * buildbot/test/runutils.py (RunMixin): factored this class out..
3535 * buildbot/test/test_run.py: .. from here
3536 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3537 added new buildbot.locks tests (which all hang right now)
3538 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3539 * buildbot/process/step.py: claim/release per-BuildStep locks
3541 * docs/Makefile: add 'buildbot.html' target
3543 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3544 interpreted as "HEAD", so that all VC steps can accept branch=None
3545 and have it mean the "default branch".
3547 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3549 2005-07-07 Brian Warner <warner@lothar.com>
3551 * docs/examples/twisted_master.cfg: update to match current usage
3553 * docs/buildbot.texinfo (System Architecture): comment out the
3554 image, it doesn't exist yet and just screws up the HTML manual.
3556 2005-07-05 Brian Warner <warner@lothar.com>
3558 * debian/.cvsignore: oops, missed one. Removing leftover file.
3560 2005-06-17 Brian Warner <warner@lothar.com>
3562 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3563 changed its output in 1.2.0, don't mistakenly think that the
3564 subversion we find isn't capable of supporting our tests.
3566 * debian/*: remove the debian/ directory and its contents, to make
3567 life easier for the proper Debian maintainer
3569 * Makefile (release): same
3571 2005-06-07 Brian Warner <warner@lothar.com>
3573 * everything: create a distinct SourceStamp class to replace the
3574 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3575 Changed the signature of Source.startVC to include the revision
3576 information (instead of passing it through self.args). Implement
3577 branches for SVN (now only Darcs/Git is missing support). Add more
3580 2005-06-06 Brian Warner <warner@lothar.com>
3582 * everything: rearrange build scheduling. Create a new Scheduler
3583 object (configured in c['schedulers'], which submit BuildSets to a
3584 set of Builders. Builders can now use multiple slaves. Builds can
3585 be run on alternate branches, either requested manually or driven
3586 by changes. This changed some of the Status classes. Interlocks
3587 are out of service until they've been properly split into Locks
3588 and Dependencies. treeStableTimer, isFileImportant, and
3589 periodicBuild have all been moved from the Builder to the
3591 (BuilderStatus.currentBigState): removed the 'waiting' and
3592 'interlocked' states, removed the 'ETA' argument.
3594 2005-05-24 Brian Warner <warner@lothar.com>
3596 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3597 erroneously abandons the connection (in clientConnectionFailed)
3598 for non-UserErrors, which means that if we lose the connection due
3599 to a network problem or a timeout, we'll never try to reconnect.
3600 Fix this by not upcalling to the buggy parent method. Note:
3601 twisted-2.0 fixes this, but the function only has 3 lines so it
3602 makes more sense to copy it than to try and detect the buggyness
3603 of the parent class. Fixes SF#1207588.
3605 * buildbot/changes/changes.py (Change.branch): doh! Add a
3606 class-level attribute to accomodate old Change instances that were
3607 pickled before 0.6.5 (where .branch was added for new Changes).
3608 This fixes the exception that occurs when you try to look at an
3609 old Change (through asHTML).
3611 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3614 2005-05-23 Brian Warner <warner@lothar.com>
3616 * buildbot/__init__.py (version): release 0.6.6
3618 2005-05-23 Brian Warner <warner@lothar.com>
3620 * NEWS: update for 0.6.6 release
3621 * debian/changelog: same
3623 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3624 before starting: this was done by twistd back when we spawned it,
3625 now that we're importing the pieces and running them in the
3626 current process, we have to do it ourselves. This allows
3627 master.cfg to import files from the same directory without
3628 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3629 Stichele for the catch.
3630 (Options.opt_version): Add a --version command (actually, just make
3631 the existing --version command emit Buildbot's version too)
3633 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3634 fix to make this behave like other LogFiles, this time to handle
3635 existing LogFiles on disk. (add the missing .upgrade method)
3636 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3638 2005-05-21 Brian Warner <warner@lothar.com>
3640 * buildbot/test/test_runner.py (Create.testMaster): match the
3641 rawstring change in runner.py:masterTAC
3643 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3644 TwistedWords is installed
3645 * buildbot/test/test_status.py: same, with TwistedMail
3647 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3648 some old, deprecated, and removed config keys). This should enable
3649 you to use the base buildbot functionality with Twisted-2.0.0 when
3650 you don't also have TwistedWeb and TwistedWords installed
3652 2005-05-20 Brian Warner <warner@lothar.com>
3654 * buildbot/scripts/runner.py (run): call sendchange(), not
3655 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3656 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3657 (stop): don't wait for process to die when sending SIGHUP
3658 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3659 directory name gets interpreted, which you don't want
3662 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3665 2005-05-18 Brian Warner <warner@lothar.com>
3667 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3669 2005-05-18 Brian Warner <warner@lothar.com>
3671 * README: update for 0.6.5
3672 * debian/changelog: same
3674 * buildbot/changes/changes.py: rename tag= to branch=, since
3675 that's how we're using it, and my design for the upcoming "build a
3676 specific branch" feature wants it. also, tag= was too CVS-centric
3677 * buildbot/changes/mail.py (parseSyncmail): same
3678 * buildbot/process/base.py (Build.isBranchImportant): same
3679 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3680 * docs/buildbot.texinfo (Attributes of Changes): same
3682 * NEWS: update tag=, update for upcoming release
3684 2005-05-17 Brian Warner <warner@lothar.com>
3686 * buildbot/scripts/runner.py (stop): actually poll once per
3687 second, instead of re-killing the poor daemon once per second.
3688 Sleep briefly (0.1s) before the first poll, since there's a good
3689 chance we can avoid waiting the full second if the daemon shuts
3690 down quickly. Also remove the sys.exit() at the end.
3691 (start): remove the unneighborly sys.exit()
3693 * Makefile: improve permission-setting to not kick Arch so badly
3695 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3696 default --keepalive=600, since it doesn't hurt very much, and it's
3697 a hassle to discover that you need it.
3698 * buildbot/test/test_runner.py (Create.testSlave): test it
3700 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3701 IRC bot about EXCEPTION
3703 * buildbot/status/client.py (PBListener): upcall more correctly
3705 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3706 an exception mark the overall build with EXCEPTION, not SUCCESS
3708 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3710 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3711 * Makefile: update some release-related stuff
3713 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3714 gets called when there isn't actually an active process, just end
3715 the Command instead of blowing up. I don't know how it gets into
3716 this state, but the twisted win32 buildslave will sometimes hang,
3717 and when it shakes its head and comes back, it thinks it's still
3718 running a Command. The next build causes this command to be
3719 interrupted, but the lack of self.process.pid breaks the interrupt
3722 * NEWS: document changes since the last release
3724 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3725 look for Makefile.buildbot instead of a bare Makefile . The
3726 'buildbot start' does not install this file, so you have to
3727 manually copy it if you want to customize startup behavior.
3728 (createMaster): change 'buildbot master' command to create
3729 Makefile.sample instead of Makefile, to create master.cfg.sample
3730 instead of master.cfg (requiring you to copy it before the
3731 buildmaster can be started). Both sample files are kept up to
3732 date, i.e. they are overwritten if they have been changed. The
3733 'buildbot.tac' file is *not* overwritten, but if the new contents
3734 don't match the old, a 'buildbot.tac.new' file is created and the
3735 user is warned. This seems to be a much more sane way to handle
3736 startup files. Also, don't sys.exit(0) when done, so we can run
3737 unit tests against it.
3738 (createSlave): same. Don't overwrite the sample info/ files.
3739 * buildbot/scripts/sample.mk: remove. the contents were pulled
3740 into runner.py, since they need to match the behavior of start()
3744 * docs/buildbot.texinfo (Launching the daemons): document it
3745 * buildbot/test/test_runner.py (Create): test it
3747 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3748 version that can handle string-in-string tests, because otherwise
3749 python-2.2 fails the tests. It'd be tremendous if Trial's test
3750 took two strings under 2.2 too.
3752 * everything: fixed all deprecation warnings when running against
3753 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3754 few that come from Twisted itself). This involved putting most of
3755 the Twisted-version specific code in the new buildbot.twcompat
3756 module, and creating some abstract base classes in
3757 buildbot.changes.base and buildbot.status.base (which might be
3758 useful anyway). __implements__ is a nuisance and requires an ugly
3759 'if' clause everywhere.
3761 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3762 delay before finishing the test: it seems that smtp.sendmail
3763 doesn't hang up on the server, so we must wait a moment so it can
3764 hang up on us. This removes the trial warning about an unclean
3767 2005-05-16 Brian Warner <warner@lothar.com>
3769 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3770 tuple of (delay, repeats).
3771 * buildbot/test/test_vc.py (Retry): test it
3772 * docs/buildbot.texinfo (Source Checkout): document it
3773 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3774 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3775 doVCFull() are handled by re-trying the checkout (after a delay)
3776 some number of times.
3777 (ShellCommand._startCommand): make header lines easier to read
3779 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3781 (WebTest.test_logfile): make sure master gets shut down, silences
3782 some "unclean reactor" test errors
3784 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3785 reactor once after shutdown, something in certain versions of
3786 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3787 fails, svn-trunk is ok.
3789 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3790 second win32 error message
3792 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3793 validating the ETA, so the tests don't fail on slow systems
3795 2005-05-15 Brian Warner <warner@lothar.com>
3797 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3798 the new LogFile class, so upgrading works properly
3799 (LogFileProducer.resumeProducing): survive resumeProducing after
3800 we've exhausted the chunkGenerator
3802 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3804 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3805 (Log.testUpgrade): same
3807 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3808 Builds and logs with a cron job.
3810 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3811 of the old non-offline LogFile, added code to upgrade these to
3812 new-style contents-live-on-disk instances at load time (in a way
3813 that doesn't invalidate the old Build pickles, so upgrading to
3814 0.6.5 is not a one-way operation). Got rid of everything related
3816 (LogFile.__init__): create LogFiles with the parent step status,
3817 the log's name, and a builder-relative filename where it can keep
3818 the contents on disk.
3819 (LogFile.hasContents): new method, clients are advised to call it
3820 before getText or getChunks and friends. If it returns False, the
3821 log's contents have been deleted and getText() will raise an
3823 (LogFile.getChunks): made it a generator
3824 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3825 Consumer (except one that takes chunks instead of strings). This
3826 enables streaming of very large logfiles without storing the whole
3828 (BuildStatus.generateLogfileName): create names like
3829 12-log-compile-output, with a _0 suffix if required to be unique
3830 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3831 or earlier) logfiles into new-style ones
3832 (BuilderStatus): remove everything related to 'stub' builds. There
3833 is now only one build cache, and we don't strip logs from old
3835 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3836 since we no longer fight to keep it in the cache
3838 * buildbot/status/html.py (TextLog.render_GET): use a
3839 ChunkConsumer to stream the log entries efficiently.
3840 (ChunkConsumer): wrapper which consumes chunks and writes
3843 * buildbot/test/test_twisted.py (Parse.testParse): use a
3844 LogFile-like object instead of a real one
3846 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3847 (Log.testMerge3): validate more merge behavior
3848 (Log.testChunks): validate LogFile.getChunks
3849 (Log.testUpgrade): validate old-style LogFile upgrading
3850 (Log.testSubscribe): validate LogFile.subscribe
3851 (Log.testConsumer): validate LogFile.subscribeConsumer
3853 * buildbot/interfaces.py (IStatusLogStub): remove
3854 (IStatusLog.subscribeConsumer): new method
3855 (IStatusLog.hasContents): new method
3856 (IStatusLogConsumer): describes things passed to subscribeConsumer
3858 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3859 the log contents if it does not have any contents.
3860 (StatusResourceBuildStep.body): same
3861 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3863 2005-05-14 Brian Warner <warner@lothar.com>
3865 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3866 timeouts to try and make the windows metabuildslave not hang
3868 2005-05-13 Mike Taylor <bear@code-bear.com>
3870 * buildbot/slave/commands.py (rmdirRecursive): added a check
3871 to ensure the path passed into rmdirRecursive actually exists.
3872 On win32 a non-existant path would generate an exception.
3874 2005-05-13 Brian Warner <warner@lothar.com>
3876 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3877 shutil.rmtree which behaves correctly on windows in the face of
3878 files that you have to chmod before deleting. Thanks to Bear at
3879 the OSAF for the routine.
3880 (SourceBase.doClobber): use rmdirRecursive
3882 2005-05-12 Brian Warner <warner@lothar.com>
3884 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3885 method generate chunks instead of returning a big list. This
3886 allows the same method to be used for both old LogFile and new
3888 (OfflineLogFile.getText): use the generator
3889 (OfflineLogFile.subscribe): same
3890 * buildbot/status/html.py (TextLog.resumeProducing): same
3891 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3893 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3894 point out that OfflineLogFile does not currently work with
3895 html.Waterfall . Fixing this is high-priority.
3897 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3898 apparently windows defaults to using stdout
3900 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3901 better message on failure so I can figure out the win32 problem
3903 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3904 log messages to include more useful copies of the command being
3905 run, the argv array, and the child command's environment.
3906 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3908 2005-05-11 Brian Warner <warner@lothar.com>
3910 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3912 * Makefile: update the deb-snapshot version
3914 * docs/buildbot.texinfo: move all .xhtml docs into a new
3915 .texinfo-format document, adding a lot of material in the process.
3916 This is starting to look like a real user's manual. Removed all
3917 the Lore-related files: *.xhtml, *.css, template.tpl .
3918 * docs/Makefile: simple makefile to run 'makeinfo'
3919 * buildbot/scripts/sample.cfg: rearrange slightly
3920 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3922 2005-05-10 Brian Warner <warner@lothar.com>
3924 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3925 different name for the internal twistw module, handle it.
3927 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3928 * setup.py: .. and stop trying to install it
3930 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3931 'git'), the new linux kernel VC system (http://kernel.org/git/).
3932 Thanks to Brandon Philips for the patch.
3933 * buildbot/slave/commands.py (Git): same
3935 2005-05-06 Brian Warner <warner@lothar.com>
3937 * buildbot/status/builder.py (OfflineLogFile): replace the default
3938 LogFile with a form that appends its new contents to a disk file
3939 as they arrive. The complete log data is never kept in RAM. This
3940 is the first step towards handling very large (100MB+) logfiles
3941 without choking quite so badly. (The other half is
3942 producer/consumer on the HTML pages).
3943 (BuildStepStatus.addLog): use OfflineLogFile by default
3944 (BuildStatus.getLogfileName): helper code to give the
3945 OfflineLogFile a filename to work with
3947 * buildbot/test/test_status.py (Results.testAddResults): update
3948 tests to handle new asserts
3949 * buildbot/test/test_vc.py (Patch.doPatch): same
3950 * buildbot/test/test_steps.py (BuildStep.setUp): same
3952 2005-05-05 Brian Warner <warner@lothar.com>
3954 * buildbot/scripts/runner.py (start): if there is no Makefile,
3955 launch the app by importing twistd's internals and calling run(),
3956 rather than spawning a new twistd process. This stands a much
3957 better chance of working under windows.
3958 (stop): kill the process with os.kill instead of spawning
3959 /bin/kill, again to reduce the number of external programs which
3960 windows might not have in the PATH. Also wait up to 5 seconds for
3961 the process to go away, allowing things like 'buildbot stop;
3962 buildbot start' to be reliable in the face of slow shutdowns.
3964 * buildbot/master.py (Dispatcher.__getstate__): remove old
3965 .tap-related methods
3966 (BuildMaster.__getstate__): same
3968 * buildbot/slave/bot.py (makeService): same
3969 (Options.longdesc): same
3970 * buildbot/scripts/runner.py: copy over some old mktap option text
3972 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3973 'buildbot master' now creates a buildbot.tac file, so there is no
3974 longer a create-instance/save/reload sequence. mktap is dead, long
3976 * buildbot/scripts/sample.mk: use twistd -y, not -f
3977 * buildbot/test/test_config.py: remove mktap-based test
3978 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3979 * README: don't reference mktap
3981 * docs/source.xhtml: document some of the attributes that Changes
3984 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3986 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3987 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3988 * buildbot/changes/changes.py (Change)
3989 * buildbot/changes/mail.py (parseSyncmail)
3990 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3992 * buildbot/process/base.py (Build.isTagImportant)
3996 2005-05-04 Brian Warner <warner@lothar.com>
3998 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3999 connection after sending the change, so that unit tests don't
4000 complain about sockets being left around
4002 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4003 exception in phase=0 rendering
4004 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4006 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4008 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4009 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4010 and configuring builders with tuples.
4011 * buildbot/test/test_config.py: stop testing compatibility with
4012 deprecated config keys
4013 * buildbot/test/test_run.py: same
4015 2005-05-03 Brian Warner <warner@lothar.com>
4017 * contrib/arch_buildbot.py: survive if there are no logfiles
4018 (username): just use a string, os.getlogin isn't reliable
4020 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4021 so 'buildbot sendchange' actually works. The earlier test only
4022 covered the internal (non-reactor-running) form.
4024 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4025 script to notify the buildmaster about changes
4027 * buildbot/scripts/runner.py (sendchange): new command to send a
4028 change to a buildbot.changes.pb.PBChangeSource receiver.
4029 * buildbot/test/test_changes.py (Sender): test it
4031 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4032 after any reading of the config file, not just when we do it in
4033 startService. This makes some tests a bit cleaner.
4035 * buildbot/changes/pb.py: add some log messages
4037 * buildbot/process/base.py (Build.startBuild): fix a bug that
4038 caused an exception when the build terminated in the very first
4040 (Build.stepDone): let steps return a status of EXCEPTION. This
4041 terminates the build right away, and sets the build's overall
4042 status to EXCEPTION too.
4043 * buildbot/process/step.py (BuildStep.failed): return a status of
4044 EXCEPTION when that is what has happened.
4046 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4047 implement this, allowing Arch-based projects to get precise
4048 checkouts instead of always using the latest code
4049 (Bazaar): create variant of Arch to let folks use baz instead of
4050 tla. Requires a new buildslave too.
4051 * buildbot/slave/commands.py (Arch): add 'revision' argument
4052 (Bazaar): create variant of Arch that uses baz instead of tla.
4053 Remove the code that extracts the archive name from the
4054 register-archive output, since baz doesn't provide it, and require
4055 the user provide both the archive name and its location.
4056 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4058 2005-05-02 Brian Warner <warner@lothar.com>
4060 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4061 thanks to Nick Trout.
4063 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4064 deals better with source Makefile coming from a read-only CVS
4065 checkout. Thanks to Nick Trout for the catch.
4067 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4070 2005-04-28 Brian Warner <warner@lothar.com>
4072 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4074 * debian/changelog: update for 0.6.4
4076 2005-04-28 Brian Warner <warner@lothar.com>
4078 * README.w32: add a checklist of steps for getting buildbot
4080 * MANIFEST.in: include it in the tarball
4084 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4085 broken .tap files from 0.6.3 by getting rid of .services,
4086 .namedServices, and .change_svc at load time.
4088 2005-04-27 Brian Warner <warner@lothar.com>
4090 * NEWS: update in preparation for new release
4092 * buildbot/test/test_config.py (Save.testSave): don't pull in
4093 twisted.scripts.twistd, we don't need it and it isn't for windows
4096 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4097 accomodate win32 which can't do atomic-rename
4099 2005-04-27 Brian Warner <warner@lothar.com>
4101 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4102 timeouts to help the slow metabuildbot not flunk them so much
4103 (Disconnect.testBuild3): same
4104 (Disconnect.testBuild4): same
4105 (Disconnect.testInterrupt): same
4107 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4108 setup, it was completely broken for new buildmasters (those which
4109 did not have a 'change.pck' already saved. Thanks to Paul Warren
4110 for catching this (embarrassing!) bug.
4111 (Dispatcher.__getstate__): don't save our registered avatar
4112 factories, since they'll be re-populated when the config file is
4114 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4115 tests (since the real mktap-generated BuildMaster doesn't save
4117 (BuildMaster.__getstate__): don't save any service children,
4118 they'll all be re-populated when the config file is re-read.
4119 * buildbot/test/test_config.py (Save.testSave): test for this
4121 2005-04-26 Brian Warner <warner@lothar.com>
4123 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4124 rendered with Blender.. looks a bit nicer.
4125 * buildbot/docs/images/icon.blend: add the Blender file for it
4127 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4128 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4129 running under windows. This appears to be the best way to allow
4130 BuildSteps to do something normal like 'trial -v buildbot.test' or
4131 'make foo' and still expect it to work. The idea is to make the
4132 BuildSteps look as much like what a developer would type when
4133 compiling or testing the tree by hand. This approach probably has
4134 problems when there are spaces in the arguments, so if you've got
4135 windows buildslaves, you'll need to pay close attention to your
4138 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4139 timezone to the timestamp column.
4140 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4142 * buildbot/scripts/runner.py (loadOptions): do something sane for
4143 windows, I think. We use %APPDATA%/buildbot instead of
4144 ~/.buildbot, but we still search everywhere from the current
4145 directory up to the root for a .buildbot/ subdir. The "is it under
4146 $HOME" security test was replaced with "is it owned by the current
4147 user", which is only performed under posix.
4148 * buildbot/test/test_runner.py (Options.testFindOptions): update
4149 tests to match. The "is it owned by the current user" check is
4150 untested. The test has been re-enabled for windows.
4152 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4153 any "\n" in the expected output with the platform-specific line
4154 separator. Make this separator "\r\n" on PTYs under unix, they
4155 seem to do that and I don't know why
4157 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4158 windows for now, I don't know what ~/.buildbot/ should mean there.
4160 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4161 win32 compatibility, don't use "/tmp"
4162 (Basedir.testChangeBuilddir): remove more unixisms
4164 2005-04-26 Brian Warner <warner@lothar.com>
4166 * buildbot/test/test_control.py (Force.rmtree): python2.2
4167 compatibility, apparently its shutil.rmtree ignore_errors=
4168 argument is ignored.
4169 * buildbot/test/test_run.py (Run.rmtree): same
4170 (RunMixin.setUp): same
4172 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4175 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4176 'substring in string' operator, must use string.find(substr)!=-1
4177 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4178 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4180 * buildbot/scripts/runner.py (loadOptions): add code to search for
4181 ~/.buildbot/, a directory with things like 'options', containing
4182 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4183 the current directory, your $HOME directory, or anywhere
4184 inbetween, as long as you're somewhere inside your home directory.
4185 (debugclient): look in ~/.buildbot/options for master and passwd
4186 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4187 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4189 * buildbot/status/client.py (makeRemote): new approach to making
4190 IRemote(None) be None, which works under Twisted-2.0
4191 * buildbot/test/test_status.py (Client.testAdaptation): test it
4193 * buildbot/status/builder.py (Status.builderAdded): when loading a
4194 pickled BuilderStatus in from disk, set its name after loading.
4195 The config file might have changed its name (but not its
4196 directory) while it wasn't looking.
4198 * buildbot/process/builder.py (Builder.attached): always return a
4199 Deferred, even if the builder was already attached
4200 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4202 2005-04-25 Brian Warner <warner@lothar.com>
4204 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4205 category-related exception when announcing a build has finished
4207 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4208 reference no-longer-existent changemaster.sources
4209 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4211 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4214 2005-04-25 Brian Warner <warner@lothar.com>
4216 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4218 * debian/changelog: update for 0.6.3
4220 2005-04-25 Brian Warner <warner@lothar.com>
4222 * MANIFEST.in: make sure debug.glade is in the tarball
4224 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4226 * NEWS: update for the imminent 0.6.3 release
4228 * buildbot/status/html.py (HtmlResource.content): make the
4229 stylesheet <link> always point at "buildbot.css".
4230 (StatusResource.getChild): map "buildbot.css" to a static.File
4231 containing whatever css= argument was provided to Waterfall()
4232 (Waterfall): provide the "classic" css as the default.
4233 * docs/waterfall.classic.css: move default CSS from here ..
4234 * buildbot/status/classic.css: .. to here
4236 * MANIFEST.in: make sure classic.css is included in the tarball
4237 * setup.py: and that it is installed too, under buildbot/status/
4239 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4240 the module level, because buildbot.tap files from 0.6.2 don't have
4241 it in their attribute dictionary.
4243 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4244 really exists at startup, might save some confusion somewhere.
4246 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4248 * docs/waterfall.classic.css:
4249 add a stylesheet that's almost the same as the "classic"
4252 * buildbot/status/builder.py:
4253 add EXCEPTION as a result - this is a problem for the bot
4254 maintainer, not a build problem for the changers
4255 * buildbot/process/step.py:
4256 use EXCEPTION instead of FAILURE for exceptions
4257 * buildbot/status/html.py:
4258 add build_get_class to get a class out of a build/buildstep
4259 finish naming the classes
4260 split out sourceNames to changeNames and builderNames so we
4261 can style them separately
4262 * docs/config.xhtml:
4263 finish documenting classes as they are right now
4265 * buildbot/status/html.py:
4266 name the classes as we agreed on IRC
4267 * docs/config.xhtml:
4270 * buildbot/status/html.py:
4271 same for cssclass->class_
4273 * buildbot/status/html.py:
4274 as decided on IRC, use class_ for the "class" attribute to not
4275 conflict with the class keyword, and clean up the messy **{} stuff.
4277 * buildbot/status/mail.py:
4278 put back "builders" argument, and fix docstring, because the
4279 code *ignores* builders listed in this argument
4281 * buildbot/process/builder.py:
4282 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4284 * docs/config.xhtml:
4285 describe the category argument for builders
4287 * buildbot/status/builder.py:
4288 Fix a silly bug due to merging
4290 * buildbot/process/builder.py:
4291 remove category from the process Builder ...
4292 * buildbot/status/builder.py:
4293 ... and add it to BuilderStatus instead.
4294 Set category on unpickled builder statuses, they might not have it.
4295 * buildbot/master.py:
4296 include category when doing builderAdded
4297 * buildbot/status/mail.py:
4298 return None instead of self for builders we are not interested in.
4299 * buildbot/test/test_run.py:
4300 fix a bug due to only doing deferredResult on "dummy" waiting
4301 * buildbot/test/test_status.py:
4302 add checks for the Mail IStatusReceiver returning None or self
4304 * buildbot/status/html.py:
4305 fix testsuite by prefixing page title with BuildBot
4307 * buildbot/status/builder.py:
4308 have .category in builder status ...
4309 * buildbot/process/builder.py:
4310 ... and set it from Builder
4311 * buildbot/status/html.py:
4312 make .css a class variable
4313 * buildbot/test/test_status.py:
4314 write more tests to cover our categories stuff ...
4315 * buildbot/status/mail.py:
4316 ... and fix the bug that this uncovered
4318 * buildbot/changes/mail.py:
4319 * buildbot/changes/pb.py:
4320 * buildbot/master.py:
4321 * buildbot/process/base.py:
4322 * buildbot/process/factory.py:
4323 * buildbot/process/interlock.py:
4324 * buildbot/process/step.py:
4325 * buildbot/process/step_twisted.py:
4326 * buildbot/slave/commands.py:
4327 * buildbot/status/builder.py:
4328 * buildbot/status/client.py:
4329 * buildbot/status/html.py:
4330 * buildbot/status/mail.py:
4331 * buildbot/status/progress.py:
4332 * buildbot/test/test_changes.py:
4333 * buildbot/test/test_config.py:
4334 * buildbot/test/test_control.py:
4335 * buildbot/test/test_interlock.py:
4336 * buildbot/test/test_maildir.py:
4337 * buildbot/test/test_mailparse.py:
4338 * buildbot/test/test_run.py:
4339 * buildbot/test/test_slavecommand.py:
4340 * buildbot/test/test_status.py:
4341 * buildbot/test/test_steps.py:
4342 * buildbot/test/test_twisted.py:
4343 * buildbot/test/test_util.py:
4344 * buildbot/test/test_vc.py:
4345 * buildbot/test/test_web.py:
4347 add test-case-name at the top of a whole set of files
4349 * buildbot/status/builder.py:
4350 keep order of addition when getting builder names
4351 * buildbot/status/words.py:
4352 * buildbot/test/test_run.py:
4353 add test for getBuilderNames
4355 * buildbot/process/base.py:
4356 * buildbot/process/step.py:
4357 * buildbot/status/builder.py:
4358 * buildbot/status/html.py:
4359 make buildbot css-able
4360 replace the color code for purple with purple, don't understand
4361 why it wasn't purple to start with
4363 * buildbot/status/words.py:
4364 ok, so it doesn't look like BuilderStatus.remote is still valid.
4365 Use what waterfall uses instead.
4367 * buildbot/interfaces.py:
4368 * buildbot/status/builder.py:
4369 * buildbot/status/html.py:
4370 * buildbot/status/mail.py:
4371 * buildbot/status/words.py:
4372 * buildbot/test/test_run.py:
4373 use categories everywhere and make it be a list. More sensible
4374 for the future. Also make words actually respect this in
4377 * buildbot/interfaces.py:
4378 add category argument to getBuilderNames
4379 * buildbot/process/builder.py:
4380 * buildbot/status/builder.py:
4381 * buildbot/status/html.py:
4382 * buildbot/status/mail.py:
4383 * buildbot/status/words.py:
4384 * buildbot/test/test_run.py:
4385 move from specifying builders by name to specifying the category
4387 * buildbot/status/html.py:
4388 * buildbot/status/words.py:
4389 add "builders=" to __init__ of status clients so they can
4390 limit themselves to the given list of builders to report on
4392 * buildbot/status/html.py: set the title to the product name
4394 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4396 * buildbot/interfaces.py:
4397 * buildbot/status/builder.py:
4398 more documentation. Hm, not sure if ChangeLog entries make sense
4401 2005-04-23 Brian Warner <warner@lothar.com>
4403 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4405 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4407 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4408 the sub-commands that log buildmaster status to stdout and to a
4409 GUI window, respectively.
4411 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4412 functionality is working again, but all the step-status and ETA
4413 stuff is missing. Commented out a lot of code pending more
4416 * buildbot/status/client.py: make sure that IRemote(None) is None
4418 * buildbot/changes/changes.py: import defer, oops
4419 (ChangeMaster): remove the .sources list, rely upon the fact that
4420 MultiServices can be treated as sequences of their children. This
4421 cleans up the add/remove ChangeSource routines a lot, as we keep
4422 exactly one list of the current sources instead of three.
4424 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4425 up an empty ChangeMaster at init time.
4426 (BuildMaster.loadChanges): if there are changes to be had from
4427 disk, replace self.change_svc with the new ones. If not, keep
4428 using the empty ChangeMaster set up in __init__.
4429 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4430 instead of a separate list, makes the code a bit cleaner.
4431 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4432 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4433 Extend the test to make sure we can get rid of the sources when
4436 2005-04-22 Brian Warner <warner@lothar.com>
4438 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4439 and info/host files when making the slave directory
4441 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4442 whendone= argument, just return the Deferred and let the caller do
4443 what they want with it.
4444 (Disconnect.testBuild1): wait for shutdownSlave
4445 (Basedir.testChangeBuilddir): new test to make sure changes to the
4446 builddir actually get propagated to the slave
4448 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4449 explicit method, rather than passing the builddir in __init__ .
4450 Make sure to update self.basedir too, this was broken before.
4451 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4452 builders and for ones that have just had their builddir changed.
4453 (BotFactory): add a class-level .perspective attribute, so
4454 BuildSlave.waitUntilDisconnected won't get upset when the
4455 connection hasn't yet been established
4456 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4457 tests can reach through it to inspect the SlaveBuilders
4459 * buildbot/process/base.py (Build.buildException): explain the
4460 log.err with a log.msg
4461 * buildbot/process/builder.py (Builder.startBuild): same
4462 (Builder._startBuildFailed): improve error message
4464 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4465 occurred because we lost the brand-new connection, retry instead
4466 of giving up. If not, it's probably an authorization failure, and
4467 it makes sense to stop trying. Make sure we log.msg the reason
4468 that we're log.err'ing the failure, otherwise test failures are
4469 really hard to figure out.
4471 * buildbot/master.py: change loadConfig() to return a Deferred
4472 that doesn't fire until the change has been fully implemented.
4473 This means any connected slaves have been updated with the new
4474 builddir. This change makes it easier to test the code which
4475 actually implements this builddir-updating.
4476 (BotPerspective.addBuilder): return Deferred
4477 (BotPerspective.removeBuilder): same
4478 (BotPerspective.attached): same
4479 (BotPerspective._attached): same. finish with remote_print before
4480 starting the getSlaveInfo, instead of doing them in parallel
4481 (BotPerspective.list_done): same
4482 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4483 actually calling slave.disconnect()
4484 (BotMaster.addBuilder): same
4485 (BotMaster.removeBuilder): same
4486 (BuildMaster.loadConfig): same
4487 (BuildMaster.loadConfig_Slaves): same
4488 (BuildMaster.loadConfig_Sources): same
4489 (BuildMaster.loadConfig_Builders): same
4490 (BuildMaster.loadConfig_status): same
4492 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4493 a Deferred that fires when the source is finally removed
4495 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4496 the previous tree on win32, where we have to do it synchronously,
4497 make sure we return a Deferred anyway.
4498 (SourceBase.doCopy): same
4500 * buildbot/scripts/runner.py (statusgui): use the text client for
4501 now, while I rewrite the Gtk one
4502 * buildbot/clients/base.py: strip out old code, leaving just the
4503 basic print-message-on-event functionality. I also remove the
4504 ReconnectingPBClientFactory, but it does at least quit when it
4505 loses the connection instead of going silent
4507 2005-04-21 Brian Warner <warner@lothar.com>
4509 * Makefile: minor tweaks
4511 * NEWS: point out deprecation warnings, new features for
4514 * buildbot/master.py (BuildMaster.loadConfig): emit
4515 DeprecationWarnings for Builders defined with tuples. Rearrange
4516 code to facility removal of deprecated configuration keys in the
4519 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4520 'buildbot' command to put a little Makefile in the target that
4521 helps you re-create the buildbot.tap file, start or stop the
4522 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4523 all the files 0600, since they contain passwords.
4524 (start): if there is a Makefile, and /usr/bin/make exists, use
4525 'make start' in preference to a raw twistd command. This lets
4526 slave admins put things like PYTHONPATH variables in their
4527 Makefiles and have them still work when the slave is started with
4528 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4529 be nice to first try the 'make' command and only fall back to
4530 twistd if it fails. TODO: the Makefile's "start" command does not
4531 add the --reactor=win32 argument when running under windows.
4532 (Options.debugclient, Options.statusgui): add sub-commands to launch
4533 the debug client (formerly in contrib/debugclient.py) and the
4534 Gtk status application (currently broken)
4535 * buildbot/clients/debug.py: move from contrib/debugclient.py
4536 * buildbot/clients/debug.glade: same
4538 * buildbot/test/test_trial.py: remove it. This requires some
4539 functionality out of Twisted that isn't there yet, and until then
4540 having it around just confuses things.
4542 * buildbot/test/test_slavecommand.py (Shell): test both with and
4543 without PTYs, and make sure that command output is properly
4544 interleaved in the with-PTY case. I think the without-PTY test
4545 should pass on windows, where we never use PTYs anyway.
4547 2005-04-20 Brian Warner <warner@lothar.com>
4549 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4551 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4553 * NEWS: start creating entries for the next release
4555 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4557 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4558 (WebTest.test_webPathname): same
4559 (WebTest.test_webPathname_port): same
4560 (WebTest.test_waterfall): use the default favicon rather than
4561 rooting around the filesystem for it. Open the expected-icon file
4562 in binary mode, to make win32 tests happier (thanks to Nick Trout
4564 * buildbot/status/html.py (buildbot_icon): win32 portability
4566 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4567 win32-compatibility fixes from Nick Trout, the "file not found" message
4568 is different under windows
4569 (FakeSlaveBuilder.__init__): clean up setup a bit
4570 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4572 2005-04-19 Brian Warner <warner@lothar.com>
4574 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4575 skip-if-repositories-are-unavailable test to not kill the trial
4576 that comes with Twisted-1.3.0
4578 * setup.py: install buildbot.png icon file when installing code
4580 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4581 environment used by the command, at least on the child side.
4583 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4584 this method needs to be added and implemented because it gets
4585 called under heavy load. I don't quite understand the
4586 producer/consumer API enough to write it.
4587 (StatusResource.getChild): add a resource for /favicon.ico
4588 (Waterfall.__init__): add favicon= argument
4589 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4590 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4591 (WebTest.test_webPathname): same
4592 (WebTest.test_webPathname_port): same
4593 * docs/config.xhtml: mention favicon=
4594 * buildbot/buildbot.png: add a default icon, dorky as it is
4596 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4598 * buildbot/master.py:
4599 * buildbot/process/base.py:
4600 * buildbot/process/builder.py:
4601 * buildbot/process/interlock.py:
4602 * buildbot/status/builder.py:
4603 * buildbot/status/html.py:
4604 * buildbot/status/mail.py:
4605 * buildbot/status/words.py:
4606 new documentation while digging through the code
4608 2005-04-17 Brian Warner <warner@lothar.com>
4610 * general: try to fix file modes on all .py files: a+r, a-x,
4611 but let buildbot/clients/*.py be +x since they're tools
4613 * docs/epyrun (addMod): when an import fails, say why
4615 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4617 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4619 * buildbot/process/base.py:
4620 * buildbot/process/builder.py:
4621 * buildbot/status/builder.py:
4622 new documentation while digging through the code
4624 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4626 * buildbot/changes/changes.py:
4627 * buildbot/changes/p4poller.py:
4628 * buildbot/interfaces.py:
4629 * buildbot/process/base.py:
4630 * buildbot/process/builder.py:
4631 * buildbot/process/step.py:
4632 * buildbot/process/step_twisted.py:
4633 * buildbot/slave/bot.py:
4634 * buildbot/slave/commands.py:
4635 * buildbot/status/builder.py:
4636 fix all docstrings to make epydoc happy. In the process of fixing
4637 some, I also moved pieces of docs, and removed some deprecated
4640 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4642 * buildbot/process/builder.py:
4643 * buildbot/process/interlock.py:
4644 * buildbot/process/process_twisted.py:
4645 * buildbot/process/step.py:
4646 BuildProcess -> Build, as it looks like that's what happened
4647 * buildbot/process/base.py:
4648 * buildbot/process/factory.py:
4651 2005-04-17 Brian Warner <warner@lothar.com>
4653 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4654 update compile command to accomodate the Twisted split.. now
4655 instead of './setup.py build_ext -i', you do './setup.py all
4656 build_ext -i', to run build_ext over all sub-projects.
4657 (FullTwistedBuildFactory): same
4658 (TwistedReactorsBuildFactory): same
4660 * buildbot/status/html.py (TextLog.finished): null out self.req
4661 when we're done, otherwise the reference cycle of TextLog to .req
4662 to .notifications to a Deferred to TextLog.stop keeps them from
4663 being collected, and consumes a huge (610MB on pyramid at last
4664 check) amount of memory.
4666 2005-04-11 Brian Warner <warner@lothar.com>
4668 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4669 normalize the VC-repository location.. makes SVN happier with
4670 certain test environments.
4672 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4673 RemoteShellCommand gets its own .env dictionary, so that code in
4674 start() doesn't mutate the original. I think this should fix the
4675 step_twisted.Trial problem where multiple identical components
4676 kept getting added to PYTHONPATH= over and over again.
4678 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4679 adding epydoc-format docstrings to many classes. Thanks to Thomas
4680 Vander Stichele for the patches.
4681 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4682 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4683 * buildbot/slave/bot.py, commands.py, registry.py: same
4685 2005-04-05 Brian Warner <warner@lothar.com>
4687 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4688 preserve timestamps, helps incremental builds of large trees.
4689 Patch from Rene Rivera.
4691 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4692 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4695 2005-04-03 Brian Warner <warner@lothar.com>
4697 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4698 with one dict, apparently exec has some scoping bugs when used
4699 with both global/local dicts. Thanks to Nathaniel Smith for the
4702 2005-04-02 Brian Warner <warner@lothar.com>
4704 * buildbot/process/step_twisted.py (countFailedTests): the new
4705 trial in Twisted-2.0 emits a slightly different status line than
4706 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4707 mistakenly think the test count is unparseable.
4708 (Trial.start): note that for some reason each build causes another
4709 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4710 be fixed but I'm not sure quite where the problem is.
4712 2005-04-01 Brian Warner <warner@lothar.com>
4714 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4715 deferredResult to avoid hangs/warnings under twisted-2.0
4716 (RunMixin.tearDown): same
4717 (RunMixin.shutdownSlave): same
4718 (Disconnect.testIdle1): same
4719 (Disconnect.testBuild2): same: wait one second after the build
4720 finishes for test to really be done.. this should be cleaned up to
4721 avoid wasting that second. Builder.detach uses a callLater(0),
4722 either that should be done in-line (something else needed that
4723 behavior), or it should return a Deferred that fires when the
4724 builder is really offline.
4725 (Disconnect.testBuild3): same
4726 (Disconnect.testDisappear): same
4728 * buildbot/test/test_web.py: rearrange server-setup and teardown
4729 code to remove unclean-reactor warnings from twisted-2.0
4731 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4732 so the tests don't hang under twisted-2.0
4734 2005-03-31 Brian Warner <warner@lothar.com>
4736 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4737 caused a warning each time the master changed our set of builders
4739 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4740 w32, don't unlink the file unless it already exists. Thanks to
4741 Baptiste Lepilleur for the catch.
4742 (BuilderStatus.saveYourself): same
4744 2005-02-01 Brian Warner <warner@lothar.com>
4746 * buildbot/status/html.py (TextLog.getChild): use a /text child
4747 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4748 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4749 logfile as text/plain (no markup, no headers). This replaces the
4750 previous scheme (which used an ?text=1 argument), and gets us back
4751 to a relative link (which works better when the buildbot lives
4752 behind another web server, such as Apache configured as a reverse
4753 proxy). Thanks to Gerald Combs for spotting the problem.
4755 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4758 2004-12-13 Brian Warner <warner@lothar.com>
4760 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4762 * debian/changelog: update for 0.6.2
4763 * NEWS: finalize for 0.6.2
4765 2004-12-11 Brian Warner <warner@lothar.com>
4767 * NEWS: bring it up to date
4769 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4770 detection code. Require some sign of life from the buildmaster
4771 every BotFactory.keepaliveInterval seconds. Provoke this
4772 indication at BotFactory.keepaliveTimeout seconds before the
4773 deadline by sending a keepalive request. We don't actually care if
4774 that request is answered in a timely fashion, what we care about
4775 is that .activity() is called before the deadline. .activity() is
4776 triggered by any PB message from the master (including an ack to
4777 one of the slave's status-update messages). With this new scheme,
4778 large status messages over slow pipes are OK, as long as any given
4779 message can be sent (and thus acked) within .keepaliveTimeout
4780 seconds (which defaults to 30).
4781 (SlaveBuilder.remote_startCommand): record activity
4782 (SlaveBuilder.ackUpdate): same
4783 (SlaveBuilder.ackComplete): same
4784 (BotFactory.gotPerspective): same
4785 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4787 2004-12-09 Brian Warner <warner@lothar.com>
4789 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4792 * buildbot/process/step_twisted.py (Trial._commandComplete):
4793 update self.cmd when we start the 'cat test.log' transfer. Without
4794 this, we cannot interrupt the correct RemoteCommand when we lose
4797 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4798 trying to tell the slave to stop the command if we're already
4799 inactive, or if we no longer have a .remote
4801 * buildbot/process/builder.py (Builder._detached): don't let an
4802 exception in currentBuild.stopBuild() prevent the builder from
4803 being marked offline
4805 2004-12-07 Brian Warner <warner@lothar.com>
4807 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4808 KeyError that happens when you ask for a non-existent Builder, and
4809 translate it into a UsageError.
4811 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4812 losing the slave in the middle of a remote step is handled too
4814 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4815 be a Failure, so be sure to stringify it before using it as the
4816 contents of the 'interrupt' logfile
4817 (RemoteCommand.interrupt): use stringified 'why' in
4818 remote_interruptCommand too, just in case
4820 2004-12-06 Brian Warner <warner@lothar.com>
4822 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4823 instead of 'tla update', which is more efficient in case we've
4824 missed a couple of patches since the last update.
4826 * debian/changelog: update for previous (0.6.1) release. Obviously
4827 this needs to be handled better.
4829 2004-12-05 Brian Warner <warner@lothar.com>
4831 * NEWS: update for stuff since last release
4833 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4834 match the maybeDeferred change in Dispatcher.requestAvatar
4835 * buildbot/changes/pb.py (ChangePerspective.attached): same
4836 * buildbot/status/client.py (StatusClientPerspective.attached): same
4837 * buildbot/process/builder.py (Builder._attached3): same
4838 * buildbot/pbutil.py (NewCredPerspective.attached): same
4840 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4841 the date to the top-most box, if it is not the same as today's
4844 * docs/slave.xhtml: provide a buildslave setup checklist
4846 * docs/source.xhtml (Arch): correct terminology
4848 2004-12-04 Brian Warner <warner@lothar.com>
4850 * buildbot/test/test_slavecommand.py: use sys.executable instead
4851 of hard-coding 'python' for child commands, might help portability
4853 * docs/examples/twisted_master.cfg: update to current usage
4855 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4856 'stop build' command to the IRC bot
4858 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4859 message that broke PBChangeSource
4861 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4862 (SlaveBuilder): make some attributes class-level, remove the old
4863 "update queue" which existed to support resuming a build after the
4864 master connection was lost. Try to reimplement that feature later.
4865 (SlaveBuilder.stopCommand): clear self.command when the
4866 SlaveCommand finishes, so that we don't try to kill a leftover one
4868 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4871 * buildbot/slave/commands.py (SourceBase): set self.command for
4872 all VC commands, so they can be interrupted.
4874 2004-12-03 Brian Warner <warner@lothar.com>
4876 * buildbot/master.py: clean up slave-handling code, to handle
4877 slave-disconnect and multiple-connect better
4878 (BotPerspective): make these long-lasting, exactly one per bot
4879 listed in the config file.
4880 (BotPerspective.attached): if a slave connects while an existing
4881 one appears to still be connected, disconnect the old one first.
4882 (BotPerspective.disconnect): new method to forcibly disconnect a
4883 buildslave. Use some hacks to empty the transmit buffer quickly to
4884 avoid the long (20-min?) TCP timeout that could occur if the old
4885 slave has dropped off the net.
4886 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4887 own their own SlaveStatus objects. Remove .attached/.detached, add
4888 .addSlave/.removeSlave, treat slaves like Builders (config file
4889 parsing sends deltas to the BotMaster). Inform the slave
4890 instances, i.e. the BotPerspective, about addBuilder and
4892 (BotMaster.getPerspective): turns into a single dict lookup
4893 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4894 which gives BotPerspective.attached a chance to disconnect the old
4896 (BuildMaster.loadConfig): add code (disabled) to validate that all
4897 builders use known slaves (listed in c['bots']). The check won't
4898 work with tuple-specified builders, which are deprecated but not
4899 yet invalid, so the check is disabled for now.
4900 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4901 routine, do the add/changed/removed dance with them like we do
4903 (BuildMaster.loadConfig_Sources): move source-config into a
4904 separate routine too
4906 * buildbot/status/builder.py (Status.getSlave): get the
4907 SlaveStatus object from the BotPerspective, not the BotMaster.
4909 * buildbot/test/test_run.py: bunch of new tests for losing the
4910 buildslave at various points in the build, handling a slave that
4911 connects multiple times, and making sure we can interrupt a
4914 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4915 something other than 'Bot' for the Bot object, to make certain
4916 test cases easier to write.
4917 (BuildSlave.waitUntilDisconnected): utility method for testing
4919 2004-11-30 Brian Warner <warner@lothar.com>
4921 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4923 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4924 argument, return a Deferred that always fires with True or False.
4925 I don't use an errback to indicate 'ping failed' so that callers
4926 are free to ignore the deferred without causing spurious errors in
4928 * buildbot/process/builder.py (BuilderControl.ping): implement it
4930 * buildbot/test/test_run.py (Status.testDisappear): test ping
4931 (Status.disappearSlave): fix it
4933 2004-11-30 Brian Warner <warner@lothar.com>
4935 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4936 (IBuilderControl): add .getBuild(num), only works for the current
4937 build, of course, although it might be interesting to offer
4938 something for builds in the .waiting or .interlocked state.
4940 * buildbot/process/base.py (Build): have .stopBuild just do the
4941 interrupt, then let the build die by itself.
4942 (BuildControl): add .stopBuild, and add a point-event named
4943 'interrupt' just after the build so status viewers can tell that
4945 (BuilderControl): add .getBuild
4947 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4948 stops when you kill it, good for testing
4949 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4950 contains the 'reason' text.
4952 * buildbot/status/html.py: Add Stop Build button, if the build can
4953 still be stopped. Send a Redirect (to the top page) one second
4954 later, hopefully long enough for the interrupt to have an effect.
4955 Move make_row() up to top-level to share it between Stop Build and
4958 * buildbot/slave/commands.py: only kill the child process once
4960 * buildbot/test/test_run.py: add testInterrupt
4962 2004-11-29 Brian Warner <warner@lothar.com>
4964 * buildbot/process/base.py: Refactor command interruption. The
4965 Build is now responsible for noticing that the slave has gone
4966 away: Build.lostRemote() interrupts the current step and makes
4967 sure that no further ones will be started.
4969 * buildbot/process/builder.py: When the initial remote_startBuild
4970 message fails, log it: this usually indicates that the slave has
4971 gone away, but we don't really start paying attention until they
4972 fail to respond to the first step's command.
4974 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4975 slave disconnect. Now sports a new interrupt() method. Error
4976 handling was simplified a lot by chaining deferreds, so
4977 remoteFailed/remoteComplete were merged into a single
4978 remoteComplete method (which can now get a Failure object).
4979 Likewise failed/finished were merged into just _finished.
4980 (BuildStep): Add interrupt(why) method, and if why is a
4981 ConnectionLost Failure then the step is failed with some useful
4984 * buildbot/slave/bot.py: stop the current command when the remote
4985 Step reference is lost, and when the slave is shut down.
4986 (Bot): make it a MultiService, so it can have children. Use
4987 stopService to tell when the slave is shutting down.
4988 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4989 remote_interruptCommand (which asks the current SlaveCommand to
4990 stop but allows it to keep emitting status messages), and
4991 stopCommand (which tells it to shut up and die).
4993 * buildbot/slave/commands.py: make commands interruptible
4994 (ShellCommand.kill): factor out os.kill logic
4995 (Command): factor out setup()
4996 (Command.sendStatus): don't send status if .running is false, this
4997 happens when the command has been halted.
4998 (Command.interrupt): new method, used to tell the command to die
4999 (SlaveShellCommand): implement .interrupt
5000 (DummyCommand): implement .interrupt
5001 (SourceBase, etc): factor out setup(), don't continue substeps if
5004 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5005 so they can be called after finishing
5007 * buildbot/test/test_run.py: new tests for disconnect behavior,
5008 refactor slave-shutdown routines, add different kinds of
5011 2004-11-27 Brian Warner <warner@lothar.com>
5013 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5014 method to express ETA time like "2m45s" instead of "165 seconds"
5016 2004-11-24 Brian Warner <warner@lothar.com>
5018 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5019 archive after the test completes, to avoid cluttering the user's
5020 'tla archives' listing with a bogus entry. Arch doesn't happen to
5021 provide any way to override the use of ~/.arch-params/, so there
5022 isn't a convenient way to avoid touching the setup of the user who
5024 (VC_HTTP.testArchHTTP): same
5026 2004-11-23 Brian Warner <warner@lothar.com>
5028 * buildbot/status/html.py (TextLog): split render() up into
5029 render_HEAD and render_GET. Use a Producer when sending log
5030 chunks, to reduce memory requirements and avoid sending huge
5031 non-Banana-able strings over web.distrib connections. Requires
5032 peeking under the covers of IStatusLog.
5033 (TextLog.resumeProducing): fix the "as text" link, handle client
5034 disconnects that occur while we're still sending old chunks.
5036 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5037 use defer.succeed, not the non-existent defer.success
5038 (LogFile.waitUntilFinished): same
5039 (LogFile.subscribe): don't add watchers to a finished logfile
5041 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5044 2004-11-23 Brian Warner <warner@lothar.com>
5046 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5048 2004-11-23 Brian Warner <warner@lothar.com>
5050 * NEWS: update for the 0.6.1 release
5051 * MANIFEST.in: add new files
5053 * README (INSTALLATION): explain how to enable the extra VC tests
5055 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5056 level to, so old pickled builds can be displayed ok
5058 2004-11-22 Brian Warner <warner@lothar.com>
5060 * NEWS: summarize updates since last release
5062 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5063 Yoz Grahame. Closes SF#1050138.
5065 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5068 * buildbot/process/step_twisted.py (Trial): update docs a bit
5070 * docs/factories.xhtml: fix Trial factory docs to match reality.
5073 * buildbot/process/factory.py (Trial.__init__): add args for
5074 randomly= and recurse=, making them available to instantiators
5075 instead of only to subclassers. Closes: SF#1049759.
5077 2004-11-15 Brian Warner <warner@lothar.com>
5079 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5080 try to teach the Quick factory to use multiple versions of python
5082 2004-11-12 Brian Warner <warner@lothar.com>
5084 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5085 safer w32-compatible approach, and only use it on windows
5086 (BuildStatus.saveYourself): same
5088 2004-11-11 Brian Warner <warner@lothar.com>
5090 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5091 it: one string merge per chunk. There are now separate .entries
5092 and .runEntries lists: when enumerating over all chunks, make sure
5094 * buildbot/test/test_status.py (Log): more tests
5096 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5097 chunks together, up to 10kb per chunk. This ought to cut down on
5098 the CPU-burning overhead of large log files. Thanks to Alexander
5099 Staubo for spotting the problem.
5100 * buildbot/test/test_status.py (Log): tests for same
5102 2004-11-10 Brian Warner <warner@lothar.com>
5104 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5105 header to outbound mail
5106 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5108 2004-11-08 Brian Warner <warner@lothar.com>
5110 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5111 can't do os.rename() onto an existing file, so catch the exception
5112 and unlink the target file first. This introduces a slight window
5113 where the existing file could be lost, but the main failure case
5114 (disk full) should still be handled safely.
5115 (BuildStatus.saveYourself): same
5117 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5118 separator character instead of os.sep, because the filenames being
5119 split here are coming from the VC system, which can have a
5120 different pathname convention than the local host. This should
5121 help a buildmaster running on windows that uses a CVS repository
5122 which runs under unix.
5123 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5125 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5126 when there are no test failures to be parsed
5128 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5129 instead of the unix-specific os.system("cp"), thanks to Elliot
5130 Murphy for this and the other buildbot-vs-windows catches.
5131 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5133 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5134 echo the command as it is run
5136 * setup.py: install sample.mk too, not just sample.cfg
5137 (scripts): install contrib/windows/buildbot.bat on windows
5139 2004-11-07 Brian Warner <warner@lothar.com>
5141 * buildbot/process/builder.py (Builder._detached): clear the
5142 self.currentBuild reference, otherwise the next build will be
5143 skipped because we think the Builder is already in use.
5145 * docs/examples/twisted_master.cfg: update to match current usage
5146 on the Twisted buildbot
5148 2004-10-29 Brian Warner <warner@lothar.com>
5150 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5152 2004-10-28 Brian Warner <warner@lothar.com>
5154 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5155 have separate doVCUpdate/doVCFull methods. Catch an update failure
5156 and respond by clobbering the source directory and re-trying. This
5157 will handle local changes (like replacing a file with a directory)
5158 that will cause CVS and SVN updates to fail.
5159 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5161 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5164 2004-10-19 Brian Warner <warner@lothar.com>
5166 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5168 * buildbot/status/html.py (StatusResourceTestResults): display any
5169 TestResults that the Build might have
5170 (StatusResourceTestResult): and the logs for each TestResult
5171 (StatusResourceBuild): add link from the per-build page
5173 2004-10-15 Brian Warner <warner@lothar.com>
5175 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5176 the 'problems' portion of stdout, add TestResults to our build
5177 * buildbot/test/test_twisted.py (Parse.testParse): test it
5179 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5180 to retrieve a dict of accumulated test results
5181 (ITestResult): define what a single test result can do
5182 * buildbot/status/builder.py (TestResult): implement ITestResult
5183 (BuildStatus.getTestResults): retrieve dict of TestResults
5184 (BuildStatus.addTestResult): add TestResults
5185 * buildbot/test/test_status.py (Results.testAddResults): test it
5187 2004-10-14 Brian Warner <warner@lothar.com>
5189 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5190 instead of os.system("rm -rf") for win32 portability
5192 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5193 SignalMixin instead of starting/stopping the reactor, which is
5194 likely to cause problems with other tests
5196 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5197 self.copyComplete() call. Yoz Grahame makes the catch.
5199 * contrib/windows/buildbot.bat: helper script to deal with path
5200 issues. Thanks to Yoz Grahame.
5202 * buildbot/master.py (BuildMaster.startService): don't register a
5203 SIGHUP handler if the signal module has no SIGHUP attribute.
5204 Apparently win32 does this.
5206 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5208 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5209 test if the reactor can't offer UNIX sockets
5211 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5212 error introduced in the last commit. We really need that
5215 2004-10-12 Brian Warner <warner@lothar.com>
5217 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5218 when describing a maildir source. Thanks to Stephen Davis.
5220 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5223 * buildbot/scripts/runner.py (createMaster): install Makefile too
5224 (start): add --no_save to 'start' command
5225 * buildbot/scripts/sample.mk: simple convenience Makefile with
5226 start/stop/reload targets
5228 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5231 2004-09-30 Brian Warner <warner@lothar.com>
5233 * setup.py: Releasing buildbot-0.6.0
5235 2004-09-30 Brian Warner <warner@lothar.com>
5237 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5238 test_trial.py from the source tarball until support is complete.
5240 * NEWS: update for 0.6.0 release
5241 * buildbot/__init__.py (version): same
5244 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5245 'source' command to tell users where to get the Buildbot source
5247 * docs/examples/*.cfg: update to modern standards
5249 * NEWS: update for release
5251 * buildbot/scripts/runner.py (createMaster): remove the
5252 -shutdown.tap stuff now that it isn't necessary
5254 (start): launch buildbot.tap, not buildbot-shutdown.tap
5257 * buildbot/status/mail.py (Domain): shorten class name
5258 (MailNotifier): if lookup= is a string, pass it to Domain()
5259 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5260 (Mail.testBuild2): test the string-to-Domain shortcut
5261 (Mail.testMail): fix test
5264 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5267 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5268 more attributes on load
5269 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5270 to accomodate the whole waterfall page at once, and the thrashing
5271 results in a lot of unnecessary loads
5272 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5273 (BuilderStatus.saveYourself): same
5274 (BuilderStatus.eventGenerator): stop generating on the first missing
5275 build. We assume that saved builds are deleted oldest-first.
5276 (BuildStepStatus.__getstate__): .progress might not exist
5278 * buildbot/changes/changes.py (ChangeMaster): make it
5279 serializable, in $masterdir/changes.pck
5280 (ChangeMaster.stopService): save on shutdown
5281 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5282 * buildbot/test/test_config.py: load Changes before config file
5285 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5286 "Oh my god, you killed the command" header on a separate line
5288 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5289 skip over corrupted build pickles
5290 (BuilderStatus.getFullBuildByNumber): same
5291 (BuilderStatus.eventGenerator): skip over unavailable builds
5292 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5293 do an atomic rename. This prevents a corrupted pickle when some
5294 internal serialization error occurs.
5295 (BuilderStatus.saveYourself): same
5297 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5298 the timeout for shell commands, it got lost somehow
5300 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5301 run out of build steps, return the rest of the builder events
5303 * buildbot/interfaces.py (IBuilderControl.ping): add method
5305 * buildbot/process/builder.py (BuilderControl.ping): move
5306 slave-ping to BuilderControl, and fix the failure case in the
5307 process (Event.finish() is the verb, Event.finished is the noun).
5309 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5310 through the BuilderControl instead of the BuilderStatus
5311 (EventBox): add adapter for builder.Event, allowing builder events to
5312 be displayed in the waterfall display
5314 * buildbot/master.py (BotMaster.stopService): add a 'master
5315 shutdown' event to the builder's log
5316 (BuildMaster.startService): and a 'master started' on startup
5318 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5319 builder events into the BuildStep event stream
5320 (Status.builderAdded): add a 'builder created' event
5323 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5324 command to announce the completion of a running build
5325 (IrcStatusBot.command_FORCE): announce when the build finishes
5327 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5328 don't evict unfinished builds from the cache: they must stay in
5329 the full-cache until their logfiles have stopped changing. Make
5330 sure the eviction loop terminates if an unfinished build was hit.
5331 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5332 This lets exceptions be dumped in an email status message. Really
5333 we need LogFiles which contain both text and HTML, instead of two
5335 (BuildStatus.__getstate__): handle self.finished=False
5336 (Status.builderAdded): if the pickle is corrupted, abandon the
5337 history and create a new BuilderStatus object.
5339 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5340 self.progress attribute, helped one test which doesn't fully set
5341 up the Build object.
5343 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5344 IStatusLog methods into an Interface that is implemented by "stub"
5345 logs, for which all the actual text chunks are on disk (in the
5346 pickled Build instance). To show the log contents, you must first
5347 adapt the stub log to a full IStatusLog object.
5349 * buildbot/status/builder.py (LogFileStub): create separate stub
5350 log objects, which can be upgraded to a real one if necessary.
5351 (LogFile): make them persistable, and let them stubify themselves
5353 (BuildStepStatus): same
5355 (BuildStatus.saveYourself): save the whole build out to disk
5356 (BuilderStatus): make it persistable
5357 (BuilderStatus.saveYourself): save the builder to disk
5358 (BuilderStatus.addFullBuildToCache): implement two caches which
5359 hold Build objects: a small one which holds full Builds, and a
5360 larger one which holds "stubbed" Builds (ones with their LogFiles
5361 turned into LogFileStubs). This reduces memory usage by the
5362 buildmaster by not keeping more than a few (default is 2) whole
5363 build logs in RAM all the time.
5364 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5366 (BuilderStatus.eventGenerator): rewrite since .builds went away
5367 (BuilderStatus.buildStarted): remove the .builds array. Add the
5368 build to the "full" cache when it starts.
5369 (BuilderStatus._buildFinished): save the build to disk when it
5371 (Status): give it a basedir (same as the BuildMaster's basedir)
5372 where the builder pickles can be saved
5373 (Status.builderAdded): create the BuilderStatus ourselves, by
5374 loading a pickle from disk (or creating a new instance if there
5375 was none on disk). Return the BuilderStatus so the master can glue
5376 it into the new Builder object.
5378 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5379 all BuilderStatuses to save themselves out to disk. This is in
5380 lieu of saving anything important in the main Application pickle
5381 (the -shutdown.tap file).
5382 (BuildMaster.__init__): give Status() a basedir for its files
5383 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5384 to get the BuilderStatus, then give it to the Builder (instead of
5385 doing it the other way around). It's ok if the status announces
5386 the new Builder before it's really ready, as the outside world can
5387 only see the BuilderStatus object anyway (and it is ready before
5388 builderAdded returns). Use the builder's "builddir" (which
5389 normally specifies where the slave will run the builder) as the
5390 master's basedir (for saving serialized builds).
5392 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5393 coerce the logfile to IStatusLog before trying to get the text
5394 chunks out of it. This will pull the full (non-stubified) Build in
5395 from disk if necessary.
5396 (TextLog): fix the adapter registration
5398 * buildbot/test/test_control.py (Force.setUp): create the basedir
5399 * buildbot/test/test_web.py: same
5400 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5401 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5402 * buildbot/test/test_run.py (Run.testMaster): same
5403 (Status.setUp): same
5405 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5407 * buildbot/status/html.py (Waterfall.__init__): store actual
5408 allowForce flag passed in rather than using True for everyone;
5409 make sure setting it to False doesn't cause a NameError
5411 (StatusResourceBuilder.__init__) add the builder name to the page
5413 (StatusResourceBuilder.body) move HTML generation for a name/value
5414 row into a helper method (StatusResourceBuilder.make_row); only
5415 generate the "Force Build" form if allowForce was True and the
5416 slave is connected. Use class attributes in the generated HTML to
5417 spread a little CSS-joy.
5419 2004-09-28 Brian Warner <warner@lothar.com>
5421 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5422 warning-scanner to not ignore things like
5423 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5425 * buildbot/status/html.py (StatusResource.control): add some
5426 class-level values for .control in an attempt to make upgrading
5429 * buildbot/util.py (ComparableMixin): survive missing attributes,
5430 such as when a class is modified and we're comparing old instances
5433 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5434 failure handling, remove a redundant try/except block. Don't
5435 return the full traceback to the IRC channel.
5436 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5437 error messages. Get ETA properly.
5439 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5440 the reason, since (at least) IRC message will have <> in them.
5441 (StatusResourceBuilder.__init__): take an IBuilderControl
5442 (StatusResourceBuilder.force): use the IBuilderControl we get in
5443 the constructor instead of trying to make our own. Catch the
5444 new exceptions and ignore them for now (until we make an
5445 intermediate web page where we could show the error message)
5446 (StatusResource): create with an IControl, use it to give an
5447 IBuilderControl to all children
5448 (Waterfall): take an allowForce= option, pass an IControl object
5449 to StatusResource if it is True
5451 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5453 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5454 catch new exceptions and return string forms
5456 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5457 * buildbot/process/builder.py (Builder.forceBuild): raise them
5458 * buildbot/test/test_control.py (Force.testNoSlave): new test
5459 (Force.testBuilderInUse): same
5462 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5464 * buildbot/test/test_run.py: use IControl
5465 * buildbot/test/test_vc.py: same
5467 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5468 to use IControl. Still offline.
5469 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5471 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5472 who=None so periodic builds don't send out status mail
5473 (Builder.forceBuild): include reason in the log message
5474 (BuilderControl.forceBuild): rename 'name' to 'who'
5476 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5477 'who' parameter, but make it None by default so builds forced by
5478 slave admins don't cause status mail to be sent to anybody
5479 (BotMaster.forceBuild): same. this method is deprecated.
5480 (DebugPerspective.perspective_forceBuild): same, use IControl.
5481 (DebugPerspective.perspective_fakeChange): use IControl..
5482 (Dispatcher.requestAvatar): .. so don't set .changemaster
5484 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5485 parameter to avoid confusion with the name of the builder
5488 * buildbot/status/mail.py: refine comment about needing 2.3
5490 * buildbot/status/html.py: move all imports to the top
5492 * buildbot/test/test_control.py: test new interfaces
5493 * buildbot/test/test_run.py (Status): handle new interfaces
5494 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5496 * buildbot/process/base.py (BuildControl): implement IBuildControl
5497 and its lonely getStatus() method
5499 * buildbot/process/builder.py (BuilderControl): implement
5500 IBuilderControl, obtained by adapting the Builder instance
5501 (Builder.startBuild): return a BuilderControl instead of a
5502 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5503 accomplish the same thing.
5505 * buildbot/master.py: move all import statements to the top
5506 (Control): implement IControl, obtained by adapting the
5507 BuildMaster instance.
5509 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5510 IBuildControl. These are used to force builds. Eventually they
5511 will provide ways to reconfigure the Builders, pause or abandon a
5512 Build, and perhaps control the BuildMaster itself.
5514 2004-09-26 Brian Warner <warner@lothar.com>
5516 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5517 ends up comparing us against something without a .__class__
5519 2004-09-24 Brian Warner <warner@lothar.com>
5521 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5524 * Makefile: add 'deb-snapshot' target, to create a timestamped
5527 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5529 2004-09-23 Brian Warner <warner@lothar.com>
5531 * buildbot/__init__.py (version): move version string here
5532 * setup.py: get version string from buildbot.version
5533 * buildbot/status/html.py (WaterfallStatusResource.body): add
5534 buildbot version to the page footer
5535 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5538 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5539 slaves, let the second know where the first one is coming from
5540 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5541 see our exceptions. It would be nice if there were a way to just
5542 send them the exception type and value, not the full traceback.
5545 * buildbot/status/mail.py (MailNotifier): add a new argument
5546 sendToInterestedUsers=, which can be set to False to disable the
5547 usual send-to-blamelist behavior.
5548 (top): handle python-2.2 which has no email.MIMEMultipart
5549 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5550 (MailNotifier.disownServiceParent): unsubscribe on removal
5552 * buildbot/test/test_status.py (Mail.testBuild2): test it
5555 * buildbot/status/progress.py (Expectations.wavg): tolerate
5556 current=None, which happens when steps start failing badly
5557 * buildbot/test/test_status.py (Progress.testWavg): test for it
5559 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5560 doesn't understand args['revision'], emit a warning instead of
5561 bailing completely. Updating to -rHEAD is probably close enough.
5563 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5565 * buildbot/test/test_status.py: at least import bb.status.client
5566 even if we don't have any test coverage for it yet
5568 * contrib/svn_buildbot.py: don't require python2.3
5569 (main): wait, do require it (for sets.py), but explain how to
5570 make it work under python2.2
5572 2004-09-23 Brian Warner <warner@lothar.com>
5574 * contrib/svn_buildbot.py: include the revision number in the Change
5576 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5577 using util.now() because FreshCVS is a realtime service
5579 * buildbot/status/event.py: delete dead code
5580 * buildbot/process/step.py: don't import dead Event class
5581 * buildbot/process/step_twisted.py: same
5582 * buildbot/status/builder.py: same
5583 * buildbot/status/client.py: same
5585 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5587 * buildbot/changes/changes.py (Change): set .when from an __init__
5588 argument (which defaults to now()), rather than having
5589 ChangeMaster.addChange set it later.
5590 (ChangeMaster.addChange): same
5592 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5593 (parseSyncmail): same. Just use util.now() for now.
5594 (parseBonsaiMail): parse the timestamp field for when=
5596 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5597 instead of setting .when after the fact
5601 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5602 results when the target project uses retrial. Still under
5604 * buildbot/test/test_trial.py: same
5606 2004-09-21 Brian Warner <warner@lothar.com>
5608 * buildbot/status/mail.py (MailNotifier.__init__): include
5609 success/warnings/failure in the Subject line
5610 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5611 use step.logname for the addLogs=True attachment filenames
5612 * buildbot/test/test_status.py (Mail): test Subject lines
5613 (Mail.testLogs): test attachment filenames
5615 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5616 accept a 'who' argument from the debug tool
5617 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5618 * contrib/debug.glade: add text box to set 'who'
5620 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5621 .getBuilderName with .getBuilder().getName(), more flexible
5622 (IStatusLog.getName): logs have short names, but you can prefix
5623 them with log.getStep().getName() to make them more useful
5624 * buildbot/status/builder.py: same
5625 * buildbot/status/client.py: same
5626 * buildbot/status/html.py: same
5627 * buildbot/test/test_run.py (Status.testSlave): same
5628 * buildbot/process/step.py: tweak logfile names
5630 * buildbot/status/mail.py (MailNotifier): add lookup, change
5631 argument to extraRecipients. The notifier is now aimed at sending
5632 mail to the people involved in a particular build, with additional
5633 constant recipients as a secondary function.
5635 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5636 including slow-lookup and failing-lookup. Make sure the blamelist
5637 members are included.
5639 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5640 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5641 (IBuildStatus.getInterestedUsers): new method
5642 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5643 * buildbot/status/client.py (remote_getResponsibleUsers): same
5644 * buildbot/status/html.py (StatusResourceBuild.body): same
5645 * buildbot/test/test_run.py (Status.testSlave): same
5647 2004-09-20 Brian Warner <warner@lothar.com>
5649 * docs/users.xhtml: update concepts
5651 * Makefile: add a convenience makefile, for things like 'make
5652 test'. It is not included in the source tarball.
5654 2004-09-16 Brian Warner <warner@lothar.com>
5656 * NEWS: mention /usr/bin/buildbot, debian/*
5658 * debian/*: add preliminary debian packaging. Many thanks to
5659 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5660 it considerably since it left their hands, I am responsible for
5661 all breakage that's resulted.
5663 * bin/buildbot: create a top-level 'buildbot' command, to be
5664 installed in /usr/bin/buildbot . For now it's just a simple
5665 frontend to mktap/twistd/kill, but eventually it will be the entry
5666 point to the 'try' command and also a status client. It is also
5667 intended to support the upcoming debian-packaging init.d scripts.
5668 * buildbot/scripts/runner.py: the real work is done here
5669 * buildbot/scripts/__init__.py: need this too
5670 * buildbot/scripts/sample.cfg: this is installed in new
5671 buildmaster directories
5672 * setup.py: install new stuff
5674 2004-09-15 Brian Warner <warner@lothar.com>
5676 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5677 'file:' schema (the version shipped with OS-X was built without the
5679 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5680 updates the log-timestamp, to make sure it isn't still running after
5683 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5684 values to the config file.
5685 * docs/examples/hello.cfg: add examples
5686 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5687 * buildbot/status/builder.py (Status.getProjectURL): implement them
5688 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5689 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5690 * buildbot/status/html.py (WaterfallStatusResource): display them
5693 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5694 certain error cases don't suffer a secondary exception.
5695 (top): Skip tests if the corresponding VC tool is not installed.
5697 * buildbot/process/factory.py (Trial): introduce separate
5698 'buildpython' and 'trialpython' lists, since trialpython=[] is
5699 what you want to invoke /usr/bin/python, whereas ./setup.py is
5700 less likely to be executable. Add env= parameter to pass options
5701 to test cases (which is how I usually write tests, I don't know if
5702 anyone else does it this way).
5704 * buildbot/process/step_twisted.py (Trial): handle python=None.
5705 Require 'testpath' be a string, not a list. Fix tests= typo.
5706 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5708 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5709 way to deal with the possibility of removing the disconnect notify
5711 (CVS): add a 'login' parameter to give a password to 'cvs login',
5712 commonly used with pserver methods (where pw="" or pw="guest")
5714 * buildbot/slave/commands.py (SourceBase): move common args
5715 extraction and setup() to __init__, so everything is ready by the
5716 time setup() is called
5717 (CVS.start): call 'cvs login' if a password was supplied
5718 (ShellCommand): special-case PYTHONPATH: prepend the master's
5719 value to any existing slave-local value.
5721 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5722 don't have a remote, mark the builder as Offline. This whole
5723 function should probably go away and be replaced by individual
5725 (Builder.buildFinished): return the results to the build-finished
5726 deferred callback, helps with testing
5728 2004-09-14 Brian Warner <warner@lothar.com>
5730 * buildbot/test/test_vc.py: put all the repositories needed to run
5731 the complete tests into a single small (1.3MB) tarball, so I can
5732 make that tarball available on the buildbot web site. Test HTTP
5733 access (for Arch and Darcs) by spawning a temporary web server
5734 while the test runs.
5736 * docs/users.xhtml: new document, describe Buildbot's limited
5737 understanding of different human users
5739 * buildbot/test/test_vc.py: rearrange test cases a bit
5741 * buildbot/process/step_twisted.py (Trial): handle testpath=
5742 * buildbot/process/factory.py (Trial): update to use step.Trial
5744 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5746 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5747 the overall build text (which gives you 'failed 2 tests' rather
5749 (BuildStepStatus.text2): default to [], not None
5751 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5754 2004-09-12 Brian Warner <warner@lothar.com>
5756 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5757 log the whole exception if it's just an AttributeError (old slave)
5759 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5760 so (e.g.) sub-commands can be run in the right directory.
5761 (ShellCommand.start): accept an optional errorMessage= argument
5762 to make life easier for SVN.start
5763 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5765 (ShellCommand.start): move ['dir'] compatibility hack..
5766 (RemoteShellCommand.start): .. to here so everyone can use it
5768 * buildbot/process/step_twisted.py (Trial): use .workdir
5770 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5771 text displayed when debuild fails completely
5772 (Trial): snarf _trial_temp/test.log from the slave and display it
5774 2004-09-11 Brian Warner <warner@lothar.com>
5776 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5778 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5779 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5781 * buildbot/process/step.py (ShellCommand): call .createSummary
5782 before .evaluateCommand instead of the other way around. This
5783 makes it slightly easier to count warnings and then use that to
5784 set results=WARNINGS
5785 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5787 * buildbot/process/base.py (Build.buildFinished): update status
5788 before doing progress. It's embarrassing for the build to be stuck
5789 in the "building" state when an exceptions occurs elsewhere..
5791 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5792 python2.2 doesn't have 'sum'
5794 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5795 to prevent clients from accidentally sorting it
5797 * buildbot/master.py (Manhole): add username/password
5798 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5799 c['manholePort'], deprecate old usage
5800 * docs/config.xhtml: document c['manhole']
5801 * docs/examples/hello.cfg: show example of using a Manhole
5804 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5805 pretend the slave is up to date
5807 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5808 the module, overlaps with 'log', the local variable
5810 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5812 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5813 new method to let Steps find out the version of their
5814 corresponding SlaveCommand.
5815 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5816 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5817 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5819 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5820 (Arch.startVC): same
5821 (P4Sync.startVC): same
5823 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5824 Deferred so we can catch errors in remote_startCommand
5825 (RemoteShellCommand.start): same
5827 * docs/examples/twisted_master.cfg: update sample config file
5829 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5830 after connectionMade() is called, not before. Close stdin at that
5833 * buildbot/process/process_twisted.py: update to use Trial, clean
5834 up argument passing (move to argv arrays instead of string
5837 * buildbot/process/step_twisted.py (Trial): new step to replace
5838 RunUnitTests, usable by any trial-using project (not just
5839 Twisted). Arguments have changed, see the docstring for details.
5841 * buildbot/process/base.py (Build.startBuild): this now returns a
5842 Deferred. Exceptions that occur during setupBuild are now
5843 caught better and lead to fewer build_status weirdnesses, like
5844 finishing a build that was never started.
5845 (Build.buildFinished): fire the Deferred instead of calling
5846 builder.buildFinished directly. The callback argument is this
5847 Build, everything else can be extracted from it, including the
5848 new build.results attribute.
5849 * buildbot/process/builder.py (Builder.startBuild): same
5850 (Builder.buildFinished): same, extract results from build
5852 * buildbot/process/step.py (ShellCommands): remove dead code
5854 2004-09-08 Brian Warner <warner@lothar.com>
5856 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5857 doesn't try to use the leftover patched workdir
5858 (SourceStamp): test source-stamp computation for CVS and SVN
5860 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5861 patched workdir ('touch .buildbot-patched') so we don't try to
5863 (SourceBase.start): add ['revision'] for all Source steps
5864 (CVS): change args: use ['branch'] for -r, remove ['files']
5865 (CVS.buildVC): fix revision/branch stuff
5866 (SVN): add revision stuff
5868 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5869 kwargs (except 'workdir') to avoid silent spelling errors
5870 (ShellCommand.__init__): same
5871 (Source): new base class for CVS/SVN/etc. Factor out everything
5872 common, add revision computation (perform the checkout with a -D
5873 DATE or -r REVISION that gets exactly the sources described by the
5874 last Change), overridable with step.alwaysUseLatest. Add patch
5875 handling (build.getSourceStamp can trigger the use of a base
5876 revision and a patch).
5877 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5878 * docs/steps.xhtml: update docs
5879 * docs/source.xhtml: mention .checkoutDelay
5880 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5882 * buildbot/process/base.py (Build.setSourceStamp): add a
5883 .sourceStamp attribute to each Build. If set, this indicates that
5884 the build should be done with something other than the most
5885 recent source tree. This will be used to implement "try" builds.
5886 (Build.allChanges): new support method
5887 (Build.lastChangeTime): remove, functionality moved to Source steps
5888 (Build.setupBuild): copy the Step args before adding ['workdir'],
5889 to avoid modifying the BuildFactory (and thus triggering spurious
5893 * buildbot/status/html.py: rename s/commits/changes/
5894 (StatusResourceChanges): same
5895 (CommitBox.getBox): same, update URL
5896 (WaterfallStatusResource): same
5897 (StatusResource.getChild): same
5899 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5900 * contrib/debug.glade: add optional 'revision' to the fakeChange
5902 * buildbot/changes/changes.py (html_tmpl): display .revision
5903 (ChangeMaster.addChange): note .revision in log
5904 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5905 accept a ['revision'] attribute
5907 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5909 * buildbot/master.py (BotMaster.getPerspective): update the
5910 .connected flag in SlaveStatus when it connects
5911 (BotMaster.detach): and when it disconnects
5912 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5913 (BuildMaster.loadConfig_Builders): walk old list correctly
5915 * buildbot/test/test_config.py: fix prefix= usage
5917 2004-09-06 Brian Warner <warner@lothar.com>
5921 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5922 poll a P4 depot looking for recent changes. Thanks to Dave
5923 Peticolas for the contribution. Probably needs some testing after
5926 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5927 requires manual client setup for each buildslave. Rather
5928 experimental. Thanks again to Dave Peticolas.
5929 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5931 * buildbot/changes/changes.py (Change): add a .revision attribute,
5932 which will eventually be used to generate source-stamp values.
5934 * buildbot/process/step.py (RemoteCommand.start): use
5935 notifyOnDisconnect to notice when we lose the slave, then treat it
5936 like an exception. This allows LogFiles to be closed and the build
5937 to be wrapped up normally. Be sure to remove the disconnect
5938 notification when the step completes so we don't accumulate a
5939 bazillion such notifications which will fire weeks later (when the
5940 slave finally disconnects normally). Fixes SF#915807, thanks to
5941 spiv (Andrew Bennetts) for the report.
5942 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5943 really isn't Logged- specific
5944 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5945 header, since it's almost always going to be appended to an
5947 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5948 update test to handle use of notifyOnDisconnect
5950 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5951 don't clear .ETA and .currentBuild when going offline, let the
5952 current build clean up after itself
5954 * buildbot/process/builder.py (Builder.detached): wait a moment
5955 before doing things like stopping the current build, because the
5956 current step will probably notice the disconnect and cleanup the
5958 * buildbot/test/test_run.py (Status.tearDown): update test to
5959 handle asynchronous build-detachment
5961 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5963 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5964 hush a debug message
5966 2004-09-05 Brian Warner <warner@lothar.com>
5968 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5969 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5970 kernels do this: the fcntl module has the F_NOTIFY constant, but
5971 the kernel itself doesn't support the operation. Thanks to Olly
5972 Betts for spotting the problem.
5974 * buildbot/process/step.py (Darcs): new source-checkout command
5975 (Arch): new source-checkout command
5976 (todo_P4): fix constructor syntax, still just a placeholder
5977 * buildbot/test/test_vc.py (VC.testDarcs): test it
5978 (VC.testDarcsHTTP): same, via localhost HTTP
5980 (VC.testArchHTTP): same
5981 * NEWS: mention new features
5983 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5984 which tells the step to stash stdout text locally (in .stdout).
5985 Slave-side Commands can use this to make decisions based upon the
5986 output of the the ShellCommand (not just the exit code).
5987 (Darcs): New source-checkout command
5988 (Arch): New source-checkout command, uses .keepStdout in one place
5989 where it needs to discover the archive's default name.
5991 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5992 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5993 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5995 * buildbot/process/step.py (ShellCommand.describe): add an
5996 alternate .descriptionDone attribute which provides descriptive
5997 text when the step is complete. .description can be ["compiling"],
5998 for use while the step is running, then .descriptionDone can be
5999 ["compile"], used alone when the step succeeds or with "failed" when
6000 it does not. Updated other steps to use the new text.
6001 * buildbot/process/step_twisted.py: same
6002 * buildbot/test/test_run.py: update tests to match
6004 2004-08-30 Brian Warner <warner@lothar.com>
6006 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6007 (CVS.__init__): send 'patch' argument to slave
6008 (CVS.start): don't create the LoggedRemoteCommand until start(),
6009 so we can catch a .patch added after __init__
6010 (SVN.__init__): add 'patch' to SVN too
6013 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6014 argument, to let commands push data into the process' stdin pipe.
6015 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6016 is in use, since closing a PTY doesn't really affect the process
6017 in the right way (in particular, I couldn't run /usr/bin/patch
6019 (SourceBase.doPatch): handle 'patch' argument
6021 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6024 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6025 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6027 * buildbot/master.py (BotPerspective.got_commands): get command
6028 versions from slave, give to each builder
6029 * buildbot/process/builder.py (Builder.attached): stash slave
6030 command versions in .remoteCommands
6032 * docs/steps.xhtml: bring docs in-line with reality
6034 * buildbot/process/step.py (CVS.__init__): more brutal
6035 compatibility code removal
6036 (SVN.__init__): same
6038 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6039 (SlaveShellCommand.start): require ['workdir'] argument, remove
6040 the ['dir'] fallback (compatibility will come later)
6041 (SourceBase): update docs
6042 (SourceBase.start): remove ['directory'] fallback
6045 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6046 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6047 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6049 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6050 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6051 code.. I will figure out 0.5.0-compatibility hooks later)
6053 2004-08-30 Brian Warner <warner@lothar.com>
6055 * buildbot/process/process_twisted.py: rewrite in terms of new
6056 BuildFactory base class. It got significantly shorter. Yay
6059 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6060 work with the new "self.build isn't nailed down until we call
6061 step.start()" scheme: specifically, __init__ is called before the
6062 build has decided on which Changes are going in, so we don't scan
6063 build.allFiles() for .xhtml files until start()
6064 (HLint.commandComplete): use getText(), not getStdout()
6065 (RunUnitTests.start): same: don't use .build until start()
6066 (RunUnitTests.describe): oops, don't report (None) when using
6068 (RunUnitTests.commandComplete): use getText()
6069 (RunUnitTests.createSummary): same
6070 (BuildDebs.commandComplete): same
6072 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6073 set args['command'] until start(), since our BuildStep is allowed
6074 to change their mind up until that point
6075 (TreeSize.commandComplete): use getText(), not getStdout()
6077 * docs/examples/twisted_master.cfg: update to current standards
6079 * docs/factories.xhtml: update
6080 * buildbot/process/factory.py: implement all the common factories
6081 described in the docs. The Trial factory doesn't work yet, and
6082 I've probably broken all the process_twisted.py factories in the
6083 process. There are compatibility classes left in for things like
6084 the old BasicBuildFactory, but subclasses of them are unlikely to
6086 * docs/examples/glib_master.cfg: use new BuildFactories
6087 * docs/examples/hello.cfg: same
6089 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6090 explicit 'workdir' args
6092 * buildbot/process/base.py (BuildFactory): move factories to ..
6093 * buildbot/process/factory.py (BuildFactory): .. here
6094 * buildbot/process/process_twisted.py: handle move
6095 * buildbot/test/test_config.py: same
6096 * buildbot/test/test_run.py: same
6097 * buildbot/test/test_steps.py: same
6098 * buildbot/test/test_vc.py: same
6099 * docs/factories.xhtml: same
6101 * NEWS: mention config changes that require updating master.cfg
6103 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6104 argument to all steps that weren't given one already, pointing at
6105 the "build/" directory.
6107 * docs/examples/hello.cfg: remove explicit 'workdir' args
6109 * docs/factories.xhtml: document standard BuildFactory clases,
6110 including a bunch which are have not yet been written
6112 2004-08-29 Brian Warner <warner@lothar.com>
6114 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6115 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6116 buildbot.status.builder so they aren't quite so internal
6117 * buildbot/process/base.py, buildbot/process/builder.py: same
6118 * buildbot/process/maxq.py, buildbot/process/step.py: same
6119 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6120 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6121 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6123 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6124 to handle new getLogs()-returns-list behavior
6125 (StatusResourceBuildStep.getChild): same
6126 (StepBox.getBox): same
6127 (WaterfallStatusResource.phase0): same
6129 * docs/source.xhtml: document how Buildbot uses version-control
6130 systems (output side: how we get source trees)
6131 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6132 systems (input side: how we learn about Changes)
6134 * buildbot/master.py (Manhole): use ComparableMixin
6135 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6136 * buildbot/changes/mail.py (MaildirSource): same
6137 * buildbot/status/client.py (PBListener): same
6138 * buildbot/status/html.py (Waterfall): same
6139 * buildbot/status/words.py (IRC): same
6141 * NEWS: start describing new features
6143 * buildbot/status/mail.py (MailNotifier): finish implementation.
6144 The message body is still a bit sparse.
6145 * buildbot/test/test_status.py (Mail): test it
6147 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6148 and __hash__ methods I wind up adding everywhere. Specifically
6149 intended to support the buildbot config-file update scheme where
6150 we compare, say, the old list of IStatusTargets against the new
6151 one and don't touch something which shows up on both lists.
6152 * buildbot/test/test_util.py (Compare): test case for it
6154 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6155 return a list instead of a dict
6156 (IBuildStepStatus.getLogs): same. The idea is that steps create
6157 logs with vaguely unique names (although their uniqueness is not
6158 guaranteed). Thus a compilation step should create its sole
6159 logfile with the name 'compile', and contribute it to the
6160 BuildStatus. If a step has two logfiles, try to create them with
6161 different names (like 'test.log' and 'test.summary'), and only
6162 contribute the important ones to the overall BuildStatus.
6163 * buildbot/status/builder.py (Event.getLogs): same
6164 (BuildStepStatus): fix default .text and .results
6165 (BuildStepStatus.addLog): switch to list-like .getLogs()
6166 (BuildStepStatus.stepFinished): same
6167 (BuildStatus.text): fix default .text
6168 (BuildStatus.getLogs): temporary hack to return all logs (from all
6169 child BuildStepStatus objects). Needs to be fixed to only report
6170 the significant ones (as contributed by the steps themselves)
6171 * buildbot/test/test_run.py: handle list-like .getLogs()
6172 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6174 2004-08-28 Brian Warner <warner@lothar.com>
6176 * buildbot/process/builder.py (Builder.attached): serialize the
6177 attachment process, so the attach-watcher isn't called until the
6178 slave is really available. Add detached watchers too, which makes
6181 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6183 * buildbot/test/test_swap.py: remove dead code
6185 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6186 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6187 sort of as if the command being run exited with a -1. There may
6188 still be some holes in this scheme.
6189 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6190 -r option appears before the module list
6191 * buildbot/process/step.py (CVS): add 'revision' argument
6193 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6194 when sending updates or stepComplete messages to the master, since
6195 we don't currently care whether they arrive or not. When we revamp
6196 the master/slave protocol to really resume interrupted builds,
6197 this will need revisiting.
6198 (lostRemote): remove spurious print
6200 * buildbot/master.py (BotPerspective.attached): serialize the
6201 new-builder interrogation process, to make testing easier
6202 (BotMaster.waitUntilBuilderDetached): convenience function
6204 * buildbot/status/builder.py (BuilderStatus): prune old builds
6205 (BuildStatus.pruneSteps): .. and steps
6206 (BuildStepStatus.pruneLogs): .. and logs
6207 (BuilderStatus.getBuild): handle missing builds
6208 * buildbot/status/html.py (StatusResourceBuild.body): display build
6209 status in the per-build page
6210 (BuildBox.getBox): color finished builds in the per-build box
6212 2004-08-27 Brian Warner <warner@lothar.com>
6214 * buildbot/status/mail.py (MailNotifier): new notification class,
6217 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6218 variants of a common base class which handles all the mode= logic
6220 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6222 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6224 2004-08-26 Brian Warner <warner@lothar.com>
6226 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6229 * buildbot/test/test_run.py: update to new Logfile interface, new
6230 buildbot.slave modules
6231 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6233 * MANIFEST.in: new sample config file
6234 * docs/examples/hello.cfg: same
6236 * buildbot/process/step_twisted.py: remove dead import
6238 * buildbot/process/step.py (RemoteCommand.run): catch errors
6240 (RemoteCommand.remote_update): ignore updates that arrive after
6242 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6243 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6244 the responsibilities of the subclass's methods
6245 (BuildStep.failed): catch errors during failure processing
6246 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6247 (CVS): move to a mode= argument (described in docstring), rather
6248 than the ungainly clobber=/export=/copydir= combination.
6249 (SVN): add mode= functionality to SVN too
6250 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6252 * buildbot/process/base.py (Build.startNextStep): catch errors
6253 during s.startStep()
6255 * buildbot/clients/base.py: update to new PB client interface.
6256 gtkPanes is still broken
6258 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6259 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6260 * setup.py: add buildbot.slave module
6261 * buildbot/bb_tap.py: handle move
6262 * buildbot/slave/registry.py: place to register commands, w/versions
6263 * buildbot/slave/bot.py: major simplifications
6264 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6265 instead of a fixed table. Eventually this will make the slave more
6266 extensible. Use 'start' method on the command, not .startCommand.
6267 Fix unsafeTracebacks handling (I think).
6268 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6269 helper class with a .start method that returns a Deferred.
6270 SlaveShellCommand is the form reached by the buildmaster. Commands
6271 which use multiple ShellCommands can just chain them as Deferreds,
6272 with some helper methods in Command (_abandonOnFailure and
6273 _checkAbandoned) to bail on rc!=0.
6274 (CVSCommand): prefer new mode= argument
6275 (SVNFetch): add mode= argument
6277 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6278 put a useful reason string on the build
6280 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6281 core functionality into an IStatusLog object
6282 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6283 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6284 (StatusResourceBuild.body): use proper accessor methods
6285 * buildbot/status/client.py (RemoteLog): PB-access goes here
6286 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6287 which delivers log contents too
6288 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6289 * buildbot/status/event.py: remove old Logfile completely
6291 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6292 subscription interface for IStatusLog subscriptions just like all
6293 other the status subscriptions
6294 (IStatusReceiver.logChunk): method called on subscribers
6296 2004-08-24 Brian Warner <warner@lothar.com>
6298 * buildbot/process/builder.py (Builder._pong): oops, ping response
6299 includes a result (the implicit None returned by remote_print).
6300 Accept it so the _pong method handles the response correctly.
6302 2004-08-06 Brian Warner <warner@lothar.com>
6304 * buildbot/test/test_config.py: update IRC, PBListener tests
6306 * buildbot/status/client.py (StatusClientPerspective): total
6307 rewrite to match new IStatus interfaces. New subscription scheme.
6308 There are still a few optimizations to make (sending down extra
6309 information with event messages so the client doesn't have to do a
6310 round trip). The logfile-retrieval code is probably still broken.
6311 Moved the PB service into its own port, you can no longer share a
6312 TCP socket between a PBListener and, say, the slaveport (this
6313 should be fixed eventually).
6314 * buildbot/clients/base.py (Client): revamp to match. still needs
6315 a lot of work, but basic event reporting works fine. gtkPanes is
6318 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6319 instance talks to a single irc server. Threw out all the old
6320 multi-server handling code. Still need to add back in
6321 builder-control (i.e. "force build")
6323 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6324 more random text to the as-yet-unreachable per-step page
6326 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6327 rename to stepETAUpdate
6328 (BuildStatus.subscribe): add build-wide ETA updates
6329 (BuilderStatus.getState): remove more cruft
6330 (BuilderStatus.getCurrentBuild): remove more cruft
6331 (BuilderStatus.buildStarted): really handle tuple-subscription
6332 * buildbot/test/test_run.py (Status.testSlave): handle the
6333 stepETAUpdate rename
6335 * buildbot/master.py (BuildMaster): don't add a default
6336 StatusClientService. Don't add a default IrcStatusFactory. Both
6337 are now added through c['status'] in the config file. c['irc'] is
6338 accepted for backwards compatibility, the only quirk is you cannot
6339 use c['irc'] to specify IRC servers on ports other than 6667.
6341 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6342 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6343 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6344 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6347 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6348 the buildmaster to re-read its config file
6351 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6352 find out the port our server is running on
6353 (WebTest.test_webPathname_port): same
6355 * buildbot/test/test_config.py (testWebPortnum): test it
6356 (testWebPathname): ditto
6358 * docs/config.xhtml: document new c['status'] configuration option
6360 * buildbot/status/html.py (Waterfall): new top-level class which
6361 can be added to c['status']. This creates the Site as well as the
6362 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6363 reachable as .parent, for everything.
6365 * buildbot/master.py (Manhole): make it a normal service Child
6366 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6367 webPathname. It will eventually replace c['irc'] and the implicit
6368 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6369 in as (deprecated) backward compatibility hooks for now.
6372 * buildbot/process/builder.py (Builder.buildFinished): don't
6373 inform out builder_status about a finished build, as it finds out
6374 through its child BuildStatus object
6376 * buildbot/status/html.py: extensive revamp. Use adapters to make
6377 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6378 have both starting and finishing times and adjust the waterfall
6379 display accordingly, using spacers if necessary. Use SlaveStatus
6380 to get buildslave info.
6381 (StatusResourceBuildStep): new just-one-step resource, used to get
6382 logfiles. No actual href to it yet.
6384 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6385 the time being, until I get the file-naming scheme right
6387 * buildbot/status/builder.py (Event): clean started/finished names
6388 (BuildStatus.isFinished): .finished is not None is the right test
6389 (BuildStatus.buildStarted): track started/finished times ourselves
6390 (BuilderStatus.getSlave): provide access to SlaveStatus object
6391 (BuilderStatus.getLastFinishedBuild): all builds are now in
6392 .builds, even the currently-running one. Accomodate this change.
6393 (BuilderStatus.eventGenerator): new per-builder event generator.
6394 Returns BuildStepStatus and BuildStatus objects, since they can
6395 both be adapted as necessary.
6396 (BuilderStatus.addEvent): clean up started/finished attributes
6397 (BuilderStatus.startBuild,finishBuild): remove dead code
6398 (SlaveStatus): new object to provide ISlaveStatus
6400 * buildbot/process/step.py (ShellCommand.getColor): actually
6401 return the color instead of setting it ourselves
6402 (CVS.__init__): pull .timeout and .workdir options out of
6403 **kwargs, since BuildStep will ignore them. Without this neither
6404 will be sent to the slave correctly.
6405 (SVN.__init__): same
6407 * buildbot/process/builder.py (Builder): move flags to class-level
6409 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6410 SlaveStatus handle that
6412 * buildbot/process/base.py (Build.firstEvent): remove dead code
6413 (Build.stopBuild): bugfix
6415 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6417 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6418 (ChangeMaster.eventGenerator): yield Changes, since there are now
6419 Adapters to turn them into HTML boxes
6421 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6422 (BotPerspective.attached): feed a SlaveStatus object
6423 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6424 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6426 * buildbot/interfaces.py: API additions
6427 (ISlaveStatus): place to get slave status
6429 2004-08-04 Brian Warner <warner@lothar.com>
6431 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6432 the delay finishes, so the step is marked as SUCCESS
6434 * buildbot/test/test_run.py (Status.testSlave): cover more of
6435 IBuildStatus and IBuildStepStatus
6437 * buildbot/status/progress.py (StepProgress): move some flags to
6438 class-level attributes
6439 (StepProgress.remaining): if there are no other progress metrics
6440 to go by, fall back to elapsed time
6441 (StepProgress.setExpectations): take a dict of metrics instead of
6443 (BuildProgress.setExpectationsFrom): pull expectations from the
6444 Expectations, instead of having it push them to the BuildProgress
6445 (Expectations): move some flags to class-level attributes
6446 (Expectations.__init__): copy per-step times from the
6448 (Expectations.expectedBuildTime): new method for per-build ETA
6450 * buildbot/status/event.py (Logfile): move some flags to
6451 class-level attributes
6452 (Logfile.logProgressTo): better method name, let step set the
6453 progress axis name (instead of always being "output")
6455 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6456 times directly, rather than depending upon the (possibly missing)
6457 .progress object. Use 'None' to indicate "not started/finished
6459 (BuildStepStatus.getExpectations): oops, return the full list of
6461 (BuilderStatus._buildFinished): append finished builds to .builds
6463 * buildbot/process/step.py (BuildStep): add separate .useProgress
6464 flag, since empty .progressMetrics[] still implies that time is a
6466 (CVS): set up the cmd in __init__, instead of waiting for start()
6468 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6469 calculation, this will eventually turn into a proper sourceStamp
6470 (Build.setupBuild): tell the Progress to load from the Expectations,
6471 instead of having the Expectations stuff things into the Progress
6472 (Build.buildException): add a build-level errback to make sure the
6473 build's Deferred fires even in case of exceptions
6475 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6477 * buildbot/process/builder.py (Builder.forceBuild): convey the
6478 reason instead of creating a fake Change
6480 * docs/examples/twisted_master.cfg: update to match reality
6482 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6483 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6484 fix or remove broken/breaking tests
6486 * buildbot/status/event.py (Logfile.__len__): remove evil method
6488 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6489 missing .build, for test convenience
6491 * buildbot/process/step_twisted.py: import fixes
6493 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6495 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6496 .statusbag reference
6498 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6499 connection at shutdown, and stop it from reconnecting
6501 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6502 chase down remote-execution bugs
6504 * buildbot/process/step.py: more fixes, remove
6505 BuildStep.setStatus()
6506 * buildbot/status/builder.py: move setStatus() functionality into
6508 * buildbot/status/event.py: minor fixes
6510 2004-08-03 Brian Warner <warner@lothar.com>
6512 * buildbot/process/base.py, buildbot/process/builder.py
6513 * buildbot/process/step.py, buildbot/status/builder.py
6514 * buildbot/status/event.py, buildbot/test/test_run.py:
6515 fix status delivery, get a basic test case working
6516 * buildbot/master.py: finish implementing basic status delivery,
6517 temporarily disable HTML/IRC/PB status sources
6519 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6521 * buildbot/status/progress.py (BuildProgress): remove dead code
6523 * buildbot/interfaces.py
6524 * buildbot/process/base.py, buildbot/process/builder.py
6525 * buildbot/process/step.py, buildbot/process/step_twisted.py
6526 * buildbot/status/builder.py: Complete overhaul of the all
6527 status-delivery code, unifying all types of status clients (HTML,
6528 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6529 look like. This commit is a checkpointing of the work-in-progress:
6530 the input side is mostly done (Builders/Builds sending status
6531 to the BuilderStatus/BuildStatus objects), but the output side has
6532 not yet been started (HTML resources querying BuilderStatus
6533 objects). Things are probably very broken right now and may remain
6534 so for several weeks, I apologize for the disruption.
6536 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6537 HTML as the log's contents. Currently used for exception tracebacks.
6538 * buildbot/status/progress.py: minor spelling changes
6540 2004-08-02 Brian Warner <warner@lothar.com>
6542 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6543 in mozilla. Also added stylesheets copied from Twisted's docs.
6544 Remember that these files are meant to be run through Lore first.
6545 Thanks to Philipp Frauenfelder for the fixes.
6546 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6547 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6548 * docs/template.tpl: added a Lore template
6550 2004-07-29 Brian Warner <warner@lothar.com>
6552 * buildbot/interfaces.py: revamp status delivery. This is the
6553 preview: these are the Interfaces that will be provided by new
6554 Builder code, and to which the current HTML/IRC/PB status
6555 displayers will be adapted.
6557 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6558 on the SlaveBuilder, not the Bot.
6559 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6561 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6562 set .usePTY on the FakeSlaveBuilder
6564 2004-07-25 Brian Warner <warner@lothar.com>
6566 * buildbot/changes/freshcvs.py: add some debug log messages
6567 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6568 disabled 'setFilter' syntax
6569 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6570 don't end with a slash
6572 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6574 * setup.py: bump to 0.5.0+ while between releases
6576 2004-07-23 Brian Warner <warner@lothar.com>
6578 * setup.py (version): Releasing buildbot-0.5.0
6580 2004-07-23 Brian Warner <warner@lothar.com>
6582 * README: update for 0.5.0 release
6584 * NEWS: update for 0.5.0 release
6586 2004-07-22 Brian Warner <warner@lothar.com>
6588 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6589 mktap-time configuration flag (--usepty=1, --usepty=0)
6590 * buildbot/bot.py: same
6592 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6593 an 'info' directory being unwanted
6595 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6596 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6597 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6598 and earlier), use a FreshCVSSourceOldcred instead.
6599 (test): simple test routine: connect to server, print changes
6601 * buildbot/changes/changes.py (Change.getTime): make it possible
6602 to print un-timestamped changes
6604 * buildbot/master.py (makeApp): delete ancient dead code
6605 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6606 * buildbot/test/test_config.py (testFindConfigFile): test it
6608 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6609 instead of win32 one
6612 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6613 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6616 * buildbot/process/base.py (Builder.__init__): change constructor
6617 to accept a dictionary of config data, rather than discrete
6618 name/slave/builddir/factory arguments
6620 * docs/examples/twisted_master.cfg: update to new syntax
6621 * docs/examples/glib_master.cfg: same
6622 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6623 rough tests of the new syntax
6626 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6627 to be an int, which means "run a web.distrib sub-server on a TCP
6628 port". This lets you publish the buildbot status page to a remote
6629 twisted.web server (using distrib.ResourceSubscription). Also
6630 rename the local attributes used to hold these web things so
6631 they're more in touch with reality.
6632 * buildbot/test/test_web.py: test webPortnum and webPathname
6633 * docs/config.xhtml: document this new use of webPathname
6635 * docs/config.xhtml: new document, slightly ahead of reality
6637 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6638 'prefix' handling: treat it as a simple string to check with
6639 .startswith, instead of treating it as a directory. This allows
6640 sub-directories to be used. If you use prefix=, you should give it
6641 a string that starts just below the CVSROOT and ends with a slash.
6642 This prefix will be stripped from all filenames, and filenames
6643 which do not start with it will be ignored.
6645 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6647 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6648 and --exclude (inverse of --include). SVN post-commit hooks
6649 now have total control over which changes get sent to buildbot and which
6652 2004-07-10 Brian Warner <warner@lothar.com>
6654 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6655 test case to match new API
6657 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6658 which crashed HTML display when self.entries=[] (needed to
6659 distinguish between [], which means "no entries yet", and None,
6660 which means "the entries have been swapped out to disk, go fetch
6663 2004-07-04 Brian Warner <warner@lothar.com>
6665 * buildbot/process/step_twisted.py (countFailedTests): Count
6666 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6667 10kb from the end because any import errors are wedged there and
6668 they would make us think the test log was unparseable.
6669 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6671 2004-06-26 Brian Warner <warner@lothar.com>
6673 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6674 delete-*.pyc command into an actual BuildStep, so we can label it
6676 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6677 (FullTwistedBuildFactory): same
6679 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6681 * contrib/fakechange.py: Add an errback when sending the fake
6682 change, so we know it didn't work.
6684 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6686 * buildbot/process/step_twisted.py: Delete *.pyc files before
6687 calling trial, so it doesn't catch any old .pyc files whose .py
6688 files have been moved or deleted.
6690 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6691 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6692 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6693 instead of ["twisted.test"], so that the end result is "trial -R
6696 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6697 regular expression to match filenames that should be ignored when
6698 changed. Also add a --revision parameter that specifies the
6699 revision to examine, which is useful for debugging.
6701 2004-06-25 Brian Warner <warner@lothar.com>
6703 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6704 summary of warnings (like DeprecationWarnings), next to the
6707 2004-05-13 Brian Warner <warner@lothar.com>
6709 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6710 we now have a w32 build slave courtesy of Mike Taylor.
6712 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6713 so broken. Fixed a race condition that tripped up interlocked
6714 builds and caused the status to be stuck at "Interlocked" forever.
6715 The twisted buildbot's one interlocked build just so happened to
6716 never hit this case until recently (the feeding builds both pass
6717 before the interlocked build is attempted.. usually it has to wait
6719 (Builder._pong_failed): fix method signature
6721 * setup.py: bump to 0.4.3+ while between releases
6723 2004-04-30 Brian Warner <warner@lothar.com>
6725 * setup.py (version): Releasing buildbot-0.4.3
6727 2004-04-30 Brian Warner <warner@lothar.com>
6729 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6731 * README: update for 0.4.3 release
6733 * NEWS: update for 0.4.3 release
6735 * buildbot/master.py (BuildMaster.__getstate__): make sure
6736 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6738 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6739 .trial as a class attribute, for upgrade from 0.4.2
6741 * buildbot/changes/changes.py (Change.links): add .links for
6744 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6745 .textWatchers and .htmlWatchers at save time, since they are both
6746 volatile, should allow smooth 0.4.2 upgrade
6748 * buildbot/process/step.py (CVS.finishStatus): catch failed
6749 CVS/SVN commands so we can make the status box red
6751 2004-04-29 Brian Warner <warner@lothar.com>
6753 * buildbot/changes/freshcvs.py
6754 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6755 code to do setFilter(), which tells the freshcvs daemon to not
6756 send us stuff that we're not interested in. I will uncomment it
6757 when a new version of CVSToys is available in which setFilter()
6758 actually works, and I get a chance to test it better.
6760 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6762 * buildbot/master.py (Dispatcher): use a registration scheme
6763 instead of hardwired service names
6764 (BuildMaster): keep track of the Dispatcher to support
6767 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6768 PBChangeSource class instead of having it be an undocumented
6769 internal feature of the ChangeMaster. Split out the code into a
6771 * buildbot/changes/pb.py (PBChangeSource): same
6772 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6774 * docs/{factories|sources|steps}.xhtml: document some pieces
6776 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6777 using FCMaildirSource
6778 (f23osx): update OS-X builder to use python2.3, since the slave
6779 was updated to Panther (10.3.3)
6781 2004-03-21 Brian Warner <warner@lothar.com>
6783 * buildbot/process/process_twisted.py: factor out doCheckout, change
6784 to use SVN instead of CVS
6786 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6787 an SVN subclass easier
6788 (BasicSVN): subclass which uses Subversion instead of CVS
6790 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6792 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6794 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6796 2004-02-25 Brian Warner <warner@lothar.com>
6798 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6799 is now either a list (which is passed to spawnProcess directly) or
6800 a string (which gets passed to /bin/sh -c). This removes the useSH
6801 flag and the ArgslistCommand class. Also send status header at the
6802 start and end of each command, instead of having the master-side
6804 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6805 -r'. Update to use list-based arguments.
6806 (SVNFetch): use list-based arguments, use ['dir'] argument to
6808 * buildbot/test/test_steps.py (Commands): match changes
6810 * buildbot/process/step.py (InternalShellCommand.words): handle
6812 (SVN): inherit from CVS, cleanup
6814 * buildbot/status/event.py (Logfile.content): render in HTML, with
6815 stderr in red and headers (like the name of the command we're
6816 about to run) in blue. Add link to a second URL (url + "?text=1")
6817 to get just stdout/stderr in text/plain without markup. There is
6818 still a problem with .entries=None causing a crash, it seems to occur
6819 when the logfile is read before it is finished.
6821 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6822 timeout to the keepalives, and use it to explicitly do a
6823 loseConnection instead of waiting for TCP to notice the loss. This
6824 ought to clear up the silent-lossage problem.
6825 (unsafeTracebacks): pass exception tracebacks back to the master,
6826 makes it much easier to debug problems
6828 2004-02-23 Brian Warner <warner@lothar.com>
6830 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6831 the whole command to /bin/sh instead of execve [Johan Dahlin]
6832 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6833 '-r HEAD' [Johan Dahlin]
6834 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6836 * buildbot/changes/changes.py (Change): add links= argument, add
6837 asHTML method [Johan Dahlin]. Modified to make a bit more
6838 XHTMLish. Still not sure how to best use links= .
6840 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6841 Change.asHTML to display the change, not asText
6843 * buildbot/status/html.py (StatusResourceBuilder): web button to
6846 * buildbot/test/test_run.py: test to actually start a buildmaster
6849 * MANIFEST.in: bring back accidentally-dropped test helper files
6851 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6852 that require cvstoys if it is not installed
6854 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6855 values of "bin/trial" [Dave Peticolas]
6856 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6857 tests passed" when we didn't happen to run any tests
6859 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6860 flunkOnFailure [Johan Dahlin]
6862 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6863 multiple instances of the same Step class by suffixing "_2", etc,
6864 to the name until it is unique. This name needs to be unique
6865 because it is used as a key in the dictionary that tracks build
6867 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6870 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6872 2004-01-14 Brian Warner <warner@lothar.com>
6874 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6875 kicked from a channel, log it
6877 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6878 something over whatever IRC channels the buildmaster is currently
6879 connected to. Added to try and track down a problem in which the
6880 master thinks it is still connected but the IRCd doesn't see it. I
6881 used a styles.Versioned this time, so hopefully users won't have
6882 to rebuild their .tap files this time.
6883 * contrib/debug.glade: add a "Poke IRC" button
6884 * contrib/debugclient.py: same
6886 * setup.py: bump to 0.4.2+ while between releases
6888 2004-01-08 Brian Warner <warner@lothar.com>
6890 * setup.py (version): Releasing buildbot-0.4.2
6892 2004-01-08 Brian Warner <warner@lothar.com>
6894 * NEWS: update for 0.4.2 release
6896 * README: document how to run the tests, now that they all pass
6898 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6900 * buildbot/process/step.py (CVS): add a global_options= argument,
6901 which lets you set CVS global options for the command like "-r"
6902 for read-only checkout, or "-R" to avoid writing in the
6904 * buildbot/slavecommand.py (CVSCommand): same
6906 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6907 testing easier (it is turned off when testing, to avoid the
6910 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6911 to make it easier to test: break generateStepID() out to a
6912 separate function, only update statusbag if it exists.
6913 (ShellCommands): create useful text for dict-based commands too.
6915 * test/*, buildbot/test/*: move unit tests under the buildbot/
6917 * setup.py (packages): install buildbot.test too
6919 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6920 * buildbot/test/test_steps.py: fix it, tests pass now
6922 2004-01-06 Brian Warner <warner@lothar.com>
6924 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6925 freshcvs mail uses a slightly different syntax for new
6926 directories. Update parser to handle either.
6927 * test/test_mailparse.py (Test1.testMsg9): test for same
6929 2003-12-21 Brian Warner <warner@lothar.com>
6931 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6932 'warnOnWarnings' so that lintian errors mark the build orange
6934 2003-12-17 Brian Warner <warner@lothar.com>
6936 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6937 messages emitted by Bonsai, contributed by Stephen Davis.
6939 * test/*: moved all tests to use trial instead of unittest. Some
6940 still fail (test_steps, test_slavecommand, and test_process).
6942 * setup.py (version): bump to 0.4.1+ while between releases
6944 2003-12-09 Brian Warner <warner@lothar.com>
6946 * setup.py (version): Releasing buildbot-0.4.1
6948 2003-12-09 Brian Warner <warner@lothar.com>
6950 * NEWS: update for 0.4.1 release
6952 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6953 freebsd builder code a little bit
6955 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6956 don't try to compare attributes of different classes
6957 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6958 (MaildirSource.messageReceived): fix Change delivery
6960 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6961 into the config file's namespace before loading it, like the
6962 documentation claims it does
6963 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6964 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6965 daemon comes back online
6967 2003-12-08 Brian Warner <warner@lothar.com>
6969 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6970 so the example will work with online=0 as well
6972 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6973 fix the __implements__ line
6975 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6976 class a twisted.application.service.Service, use startService to
6979 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6980 directory fd instead of simple open(). I'm sure this used to work,
6981 but the current version of python refuses to open directories with
6984 2003-12-05 Brian Warner <warner@lothar.com>
6986 * setup.py (version): bump to 0.4.0+ while between releases
6988 2003-12-05 Brian Warner <warner@lothar.com>
6990 * setup.py (version): Releasing buildbot-0.4.0
6992 2003-12-05 Brian Warner <warner@lothar.com>
6994 * docs/examples/glib_master.cfg: replace old sample scripts with
6995 new-style config files
6996 * MANIFEST.in: include .cfg files in distribution tarball
6998 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6999 implement a dummy method to avoid the exception that occurs when
7000 freshcvs sends this to us.
7002 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7003 removed the method, as it broke reconnection. Apparently
7004 stopFactory is called each time the connection attempt fails. Must
7006 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7007 attribute before serialization, since without stopFactory the
7008 reconnect timer may still be active and they aren't serializable.
7010 * test/test_mailparse.py (ParseTest): test with 'self' argument
7012 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7013 argument, as these "functions" are invoked like methods from class
7014 attributes and therefore always get an instance as the first
7017 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7018 message: thanks to Stephen Davis for the catch
7020 2003-12-04 Brian Warner <warner@lothar.com>
7022 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7023 twisted's standard ReconnectingClientFactory. Handles both oldcred
7024 and newcred connections. Also has a bug-workaround for
7025 ReconnectingClientFactory serializing its connector when it
7028 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7029 pbutil. Replace makeApp stuff with proper newcred/mktap
7030 makeService(). Don't serialize Ephemerals on shutdown.
7032 * buildbot/changes/changes.py (ChangeMaster): make it a
7033 MultiService and add the sources as children, to get startService
7034 and stopService for free. This also gets rid of the .running flag.
7036 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7037 new pbutil, turn into a TCPClient at the same time (to get
7038 startService for free). Two variants exist: FreshCVSSourceOldcred
7039 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7040 yet, but when it does, we'll be ready).
7041 (FreshCVSSource.notify): handle paths which are empty after the
7042 prefix is stripped. This only happens when the top-level (prefix)
7043 directory is added, at the very beginning of a Repository's life.
7045 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7046 Now the only reconnecting code is in the factory where it belongs.
7047 (Builder.unsubscribe): unregister the disconnect callback when we
7048 delete the builder on command from the master (i.e. when the
7049 buildmaster is reconfigured and that builder goes away). This
7050 fixes a multiple-delete exception when the status client is shut
7052 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7055 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7056 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7058 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7060 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7061 a list of globs (ugh). The testdir will be searched for files
7062 named *.tests and run the tests in the order specified in each of
7063 those files. This allows for "dependancies" between tests to be
7066 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7067 argument to pass to run_maxq.py, instead of a glob.
7069 2003-10-17 Brian Warner <warner@lothar.com>
7071 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7072 files that live in the sandbox
7074 2003-10-15 Brian Warner <warner@lothar.com>
7076 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7077 spelling error in "docs" count-warnings output
7078 (HLint.start): stupid thinko meant .xhtml files were ignored
7080 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7081 tests now that cReactor is banished to the sandbox
7083 2003-10-10 Brian Warner <warner@lothar.com>
7085 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7086 scheme: now .xhtml are sources and .html are generated
7088 2003-10-08 Brian Warner <warner@lothar.com>
7090 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7091 we were ignoring the 'randomly' parameter.
7093 2003-10-01 Brian Warner <warner@lothar.com>
7095 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7096 posix, to kill sub-children of aborted slavecommands.
7098 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7099 Clean up initialization: lastBuildStatus remains None until the
7100 first build has been completed.
7102 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7103 None as a lastBuildStatus
7104 * buildbot/clients/gtkPanes.py: same
7106 * buildbot/status/client.py (StatusClientService): keep
7107 BuilderStatus objects in self.statusbags . These objects now live
7108 here in the StatusClientService and are referenced by the Builder
7109 object, rather than the other way around.
7110 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7111 * buildbot/process/base.py (Builder): same
7112 * test/test_config.py (ConfigTest.testBuilders): same
7114 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7115 an existing builder, leave the statusbag alone. This will preserve the
7118 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7119 hook. This will probably go away in favor of a class in upcoming
7122 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7123 serviceName from newcred FreshCVSNotifiee setup
7125 2003-09-29 Brian Warner <warner@lothar.com>
7127 * buildbot/process/process_twisted.py: switch to new reactor
7129 * docs/examples/twisted_master.cfg: same
7131 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7133 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7134 botmaster reference instead of the oldapp service lookup
7136 * buildbot/master.py (BuildMaster.__init__): give the
7137 StatusClientService a reference to the botmaster to make it easier to
7140 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7142 * buildbot/status/html.py (Box.td): escape hreffy things so you
7143 can have spaces in things like builder names
7144 (StatusResourceBuilder.body)
7145 (WaterfallStatusResource.body)
7146 (WaterfallStatusResource.body0): same
7148 2003-09-25 Brian Warner <warner@lothar.com>
7150 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7151 rearrange the builder list when adding or removing builders: keep
7152 them in the order the user requested.
7153 * test/test_config.py (ConfigTest.testBuilders): verify it
7155 * contrib/debug.glade: give the debug window a name
7157 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7158 now wait on multiple interlocks. Fix code relating to that.
7159 (Builder.checkInterlocks): same
7160 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7162 * buildbot/master.py (BuildMaster.loadConfig): move from
7163 deprecated pb.BrokerFactory to new pb.PBServerFactory
7164 * test/test_config.py (ConfigTest.testWebPathname): same
7166 * docs/examples/twisted_master.cfg: fix interlock declaration
7168 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7169 Interlocks to their Builders into interlock.py .
7170 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7172 * test/test_config.py (ConfigTest.testInterlocks): validate
7175 * buildbot/process/base.py (Builder.__init__): better comments
7176 * buildbot/process/interlock.py (Interlock.__repr__): same
7177 (Interlock.deactivate): add .active flag, move the code that
7178 attaches/detaches builders into the Interlock
7180 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7182 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7183 tests using the new run_maxq.py script, and reporting failures by
7186 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7187 tests, reporting their success or failure in a buildbot-friendly
7190 2003-09-24 Brian Warner <warner@lothar.com>
7192 * docs/examples/twisted_master.cfg: example of a new-style config
7193 file. This lives in the buildmaster base directory as
7196 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7197 button to make the master re-read its config file
7199 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7200 buildmaster configuration from a file. This file can be re-read
7201 later, and the buildmaster will update itself to match the new
7202 desired configuration. Also use new Twisted Application class.
7203 * test/Makefile, test/test_config.py: unit tests for same
7205 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7206 FreshCVSSources comparable, to support reload.
7207 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7209 * buildbot/process/base.py (Builder): make them comparable, make
7210 Interlocks easier to attach, to support reload. Handle
7211 re-attachment of remote slaves.
7212 * buildbot/process/interlock.py (Interlock): same
7214 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7215 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7216 buildmaster taps are now constructed with mktap.
7217 * buildbot/status/client.py (StatusClientService): same
7219 * buildbot/status/words.py: move to new Services, add support to
7220 connect to multiple networks, add reload support, allow nickname
7221 to be configured on a per-network basis
7223 2003-09-20 Brian Warner <warner@lothar.com>
7225 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7226 the freebsd builder, now that the machine has been upgraded and no
7227 longer has python2.2
7229 * setup.py (version): bump to 0.3.5+ while between releases
7231 2003-09-19 Brian Warner <warner@lothar.com>
7233 * setup.py (version): Releasing buildbot-0.3.5
7235 2003-09-19 Brian Warner <warner@lothar.com>
7237 * NEWS: add post-0.3.4 notes
7239 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7241 * MANIFEST.in: add contrib/*
7243 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7244 use a remote root now: cvs.twistedmatrix.com
7246 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7248 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7249 compatibility with old servers
7250 (FreshCVSSource.start): and provide a way to use it
7251 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7253 * docs/examples/twisted_master.py (twisted_app): update to new
7255 (twisted_app): listen on new ~buildbot socket
7256 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7258 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7259 to reduce cvs bandwidth (update instead of full checkout)
7261 2003-09-11 Brian Warner <warner@lothar.com>
7263 * contrib/fakechange.py: demo how to connect to the changemaster
7264 port. You can use this technique to submit changes to the
7265 buildmaster from source control systems that offer a hook to run a
7266 script when changes are committed.
7268 * contrib/debugclient.py: tool to connect to the debug port. You
7269 can use it to force builds, submit fake changes, and wiggle the
7272 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7273 'Dispatcher' realm to handle all the different kinds of
7274 connections and Perspectives: buildslaves, the changemaster port,
7275 the debug port, and the status client port. NewCredPerspectives
7276 now have .attached/.detached methods called with the remote 'mind'
7277 reference, much like old perspectives did. All the pb.Services
7278 turned into ordinary app.ApplicationServices .
7279 (DebugService): went away, DebugPerspectives are now created
7280 directly by the Dispatcher.
7281 (makeApp): changed interface a little bit
7283 * buildbot/changes/changes.py: newcred
7284 * buildbot/status/client.py: newcred
7286 * buildbot/clients/base.py: newcred client side changes
7287 * buildbot/bot.py: ditto
7289 * docs/examples/glib_master.py: handle new makeApp() interface
7290 * docs/examples/twisted_master.py: ditto
7292 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7293 base newcred Perspectives on. This should go away once Twisted
7294 itself provides something sensible.
7297 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7299 * contrib/svn_buildbot.py: A program that you can call from your
7300 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7301 when a change in an SVN repository has happened. See the top of
7302 the file for some minimal usage info.
7304 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7306 * buildbot/slavecommand.py (ArglistCommand): Add new
7307 ArglistCommand that takes an argument list rather than a string as
7308 a parameter. Using a st.split() for argv is very bad.
7310 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7311 update to a particular revision rather than always checking out
7312 (still not very smart about it, there may be cases where the
7313 checkout becomes inconsistent).
7315 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7317 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7318 SVN fetch support. It can checkout (not update!) a specified
7319 revision from a specified repository to a specified directory.
7321 * buildbot/status/progress.py (Expectations.update): Fix an
7322 obvious bug (apparently created by the change described in the
7323 previous ChangeLog message) by moving a check to *after* the
7324 variable it checks is defined.
7327 2003-09-08 Brian Warner <warner@lothar.com>
7329 * buildbot/status/progress.py (Expectations.update): hack to catch
7330 an exception TTimo sees: sometimes the update() method seems to
7331 get called before the step has actually finished, so the .stopTime
7332 is not set, so no totalTime() is available and we average None
7333 with the previous value. Catch this and just don't update the
7334 metrics, and emit a log message.
7336 2003-08-24 Brian Warner <warner@lothar.com>
7338 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7339 parameter to set copydir='original' in CVS commands.
7341 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7343 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7344 which tells the command to maintain a separate original-source CVS
7345 workspace. For each build, this workspace will be updated, then
7346 the tree copied into a new workdir. This reduces CVS bandwidth
7347 (from a full checkout to a mere update) while doubling the local
7348 disk usage (to keep two copies of the tree).
7350 2003-08-21 Brian Warner <warner@lothar.com>
7352 * buildbot/status/event.py (Logfile.addEntry): if the master web
7353 server dies while we're serving a page, request.write raises
7354 pb.DeadReferenceError . Catch this and treat it like a
7355 notifyFinish event by dropping the request.
7357 2003-08-18 Brian Warner <warner@lothar.com>
7359 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7360 (instead of blowing up) if a force-build command is given without
7363 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7364 don't blow up if there aren't yet any Changes in the list
7366 2003-08-02 Brian Warner <warner@lothar.com>
7368 * buildbot/bot.py (updateApplication): don't set the .tap name,
7369 since we shouldn't assume we own the whole .tap file
7371 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7372 'mktap buildbot' (without a subcommand) better
7374 2003-07-29 Brian Warner <warner@lothar.com>
7376 * buildbot/status/words.py
7377 (IrcStatusFactory.clientConnectionLost): when we lose the
7378 connection to the IRC server, schedule a reconnection attempt.
7380 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7381 use shutil.rmtree instead of forking off an "rm -rf" command.
7382 rmtree may take a while and will block until it finishes, so we
7383 use "rm -rf" if available.
7385 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7386 freebsd buildslave badly
7388 * setup.py (version): bump to 0.3.4+ while between releases
7390 2003-07-28 Brian Warner <warner@lothar.com>
7392 * setup.py (version): Releasing buildbot-0.3.4
7394 2003-07-28 Brian Warner <warner@lothar.com>
7396 * NEWS: update in preparation for release
7398 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7399 process.signalProcess instead of os.kill, to improve w32
7402 * docs/examples/twisted_master.py (twisted_app): turn off
7403 win32eventreactor: the tests hang the buildslave badly
7405 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7406 failed builds, since usually the failures are consistent
7408 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7409 add compileOpts/compileOpts2 to reactors build
7411 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7412 (twisted_app): use both default and win32eventreactor on w32 build.
7413 Use both default and kqreactor on freebsd build.
7415 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7416 add compileOpts2, which is put after the build_ext argument. w32
7417 needs "-c mingw32" here.
7419 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7420 touch .acqpath, it goes away in recent Twisted releases
7422 * docs/examples/twisted_master.py (twisted_app): use "python" for
7423 the w32 buildslave, not "python2.2"
7425 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7426 the directory exists.. should hush an exception under w32
7428 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7429 ProcessTerminated -provided values for signal and exitCode rather
7430 than parsing the unix status code directly. This should remove one
7431 more roadblock for a w32-hosted buildslave.
7433 * test/test_mailparse.py: add test cases for Syncmail parser
7435 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7436 temporary compatibility import. Note! Start importing
7437 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7439 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7441 2003-07-27 Brian Warner <warner@lothar.com>
7443 * NEWS: started adding new features
7445 * buildbot/changes/mail.py: start work on Syncmail parser, move
7446 mail sources into their own file
7448 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7449 as implementing IChangeSource
7450 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7452 * buildbot/interfaces.py: define the IChangeSource interface
7454 2003-07-26 Brian Warner <warner@lothar.com>
7456 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7458 2003-06-25 Brian Warner <warner@lothar.com>
7460 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7463 2003-06-17 Brian Warner <warner@lothar.com>
7465 * buildbot/status/words.py: clean up method usage to avoid error
7466 in silly IRC command
7467 (IrcStatusBot.emit_status): round off seconds display
7469 * buildbot/process/base.py (Build): delete the timer when saving
7470 to the .tap file, and restore it (if it should still be running)
7471 upon restore. This should fix the "next build in -34 seconds"
7472 messages that result when the master is restarted while builds are
7473 sitting in the .waiting slot. If the time for the build has
7474 already passed, start it very soon (in 1 second).
7476 * buildbot/status/words.py: more silly commands
7478 * README (REQUIREMENTS): add URLs to all required software
7480 * buildbot/status/words.py ('last'): mention results of, and time
7483 2003-05-28 Brian Warner <warner@lothar.com>
7485 * buildbot/status/words.py: add 'last' command
7486 (IrcStatusBot.emit_status): add current-small text to 'status' output
7488 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7489 (twisted_app): remove spaces from OS-X builder name
7491 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7492 * buildbot/status/words.py: IRC bot should actually be useful now
7494 2003-05-23 Brian Warner <warner@lothar.com>
7496 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7497 "slave information" from $(slavedir)/info/* . These files are
7498 maintained by the slave administrator, and describe the
7499 machine/environment that is hosting the slave. Information from
7500 them is put into the "Builder" HTML page. Still need to establish
7501 a set of well-known filenames and meanings for this data: at the
7502 moment, *all* info/* files are sent to the master, but only
7503 'admin' and 'host' are used on that end.
7504 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7505 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7506 * buildbot/master.py (BotPerspective.got_info): ditto
7508 2003-05-22 Brian Warner <warner@lothar.com>
7510 * setup.py (version): bump version to 0.3.3+ while between releases
7512 2003-05-21 Brian Warner <warner@lothar.com>
7514 * setup.py: Releasing buildbot-0.3.3
7516 2003-05-21 Brian Warner <warner@lothar.com>
7518 * NEWS: 0.3.3 news items
7520 * README: describe --keepalive and life behind a NAT box
7522 * buildbot/bot.py (Bot.connected): implement application-level
7523 keepalives to deal with NAT timeouts, turn them on with
7524 --keepalive option or when SO_KEEPALIVE doesn't work.
7526 * buildbot/master.py (BotPerspective): accept keepalives silently
7528 * buildbot/process/base.py (Build.buildException): CopiedFailures
7529 don't carry as much information as local ones, so don't try to
7530 create a big HTMLized version of them.
7532 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7533 log file when step fails due to an exception, such as when the slave
7536 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7537 --testmodule argument instead of grepping for test-case-name tags
7538 ourselves. Remove FindUnitTests code.
7539 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7541 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7543 2003-05-16 Brian Warner <warner@lothar.com>
7545 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7546 argument to allow things like CFLAGS=-O0 to be passed without relying
7547 upon /bin/sh processing on the slave.
7549 * buildbot/process/step.py (InternalShellCommand.start): send
7551 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7552 'split' instead of letting /bin/sh do it. This should also remove
7553 the need for /bin/sh on the buildslave, making it more likely to
7556 * buildbot/status/html.py: html-escape text in blamelist.
7557 Add "force build" button to the Builder page.
7559 * buildbot/process/step_twisted.py (countFailedTests): look at
7560 last 1000 characters for status line, as import errors can put it
7561 before the -200 point.
7563 2003-05-15 Brian Warner <warner@lothar.com>
7565 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7567 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7568 make 'clobber' a parameter, so it is possible to have builds which
7569 do full tests but do a cvs update instead of hammering the CVS
7570 server with a full checkout each build
7572 * buildbot/process/step.py (InternalShellCommand): bump default
7573 timeout to 20 minutes
7575 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7576 the master to trigger a build. Run it via manhole.
7578 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7579 allow slaves to trigger any build that they host, to make life
7580 easier for slave admins who are testing out new build processes
7582 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7583 don't flunk cReactor or qtreactor on failure, since they fail alot
7584 these days. Do warnOnFailure instead.
7586 * buildbot/process/base.py: change Builder.buildable from a list
7587 into a single slot. When we don't have a slave, new builds (once
7588 they make it past the timeout) are now merged into an existing
7589 buildable one instead of being queued. With this change, a slave
7590 which has been away for a while doesn't get pounded with all the
7591 builds it missed, but instead just does a single build.
7593 2003-05-07 Brian Warner <warner@lothar.com>
7595 * setup.py (version): bump version to 0.3.2+ while between releases
7597 2003-05-07 Brian Warner <warner@lothar.com>
7599 * setup.py: Releasing buildbot-0.3.2
7601 2003-05-07 Brian Warner <warner@lothar.com>
7603 * setup.py: fix major packaging error: include subdirectories!
7605 * NEWS: add changes since last release
7607 * README (REQUIREMENTS): update twisted/python dependencies
7609 * buildbot/status/builder.py (Builder.startBuild): change
7610 BuildProcess API: now they should call startBuild/finishBuild
7611 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7612 keeping a list of builds in the statusbag, to support other kinds of
7614 (Builder.addClient): send current-activity-small to new clients
7615 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7618 * buildbot/status/client.py: drop RemoteReferences at shutdown
7620 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7622 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7623 more debug messages for remote status client
7625 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7626 (.stepFailed): only fire the Deferred once, even if both
7627 stepComplete and stepFailed are called. I think this can happen if
7628 an exception occurs at a weird time.
7630 * buildbot/status/words.py: work-in-progress: IRC status delivery
7632 2003-05-05 Brian Warner <warner@lothar.com>
7634 * docs/examples/twisted_master.py (twisted_app): hush internal
7635 python2.3 distutils deprecation warnings
7636 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7637 add compileOpts= argument which inserts extra args before the
7638 "setup.py build_ext" command. This can be used to give -Wignore
7639 warnings, to hush some internal python-2.3 deprecation messages.
7641 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7642 the ['twisted.test'] default test case to make it easier to change
7645 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7646 * buildbot/clients/gtkPanes.py: ditto
7648 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7649 arg to collapse RunUnitTestsRandomly into RunUnitTests
7650 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7651 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7653 * buildbot/status/html.py (StatusResource): shuffle Resources
7654 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7655 would serve the waterfall display, but the internal links were
7656 only valid on the trailing-slash version. The correct behavior is
7657 for the non-slashed one to serve a Redirect to the slashed one.
7658 This only shows up when the buildbot page is hanging off another
7659 server, like a Twisted-Web distributed server.
7661 * buildbot/status/event.py (Event, RemoteEvent): make Events
7662 pb.Cacheable, with RemoteEvent as the cached version. This removes
7663 a lot of explicit send-an-update code.
7664 * buildbot/status/builder.py (Builder): remove send-update code
7665 * buildbot/status/client.py (ClientBuilder): remove send-update
7666 code, and log errors that occur during callRemote (mostly to catch
7667 InsecureJelly exceptions)
7669 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7670 run Lore with the same python used in the rest of the build
7672 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7674 * buildbot/process/step_twisted.py (HLint): accept 'python'
7675 argument. Catch rc!=0 and mark the step as failed. This marks the
7676 build orange ("has warnings").
7677 (RunUnitTestsJelly): move out to step_twisted2.py
7679 * buildbot/util.py (ignoreStaleRefs): add utility function
7681 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7682 don't fake ETA object, it's too hard to get right
7684 2003-05-02 Brian Warner <warner@lothar.com>
7686 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7688 2003-05-01 Brian Warner <warner@lothar.com>
7690 * buildbot/status/html.py (StatusResource.body): oops, I was
7691 missing a <tr>, causing the waterfall page to be misrendered in
7692 everything except Galeon.
7694 2003-04-29 Brian Warner <warner@lothar.com>
7696 * docs/examples/twisted_master.py: make debuild use python-2.2
7697 explicitly, now that Twisted stopped supporting 2.1
7699 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7700 handle tuple results too. I keep forgetting this, which suggests
7701 it needs to be rethought.
7703 * setup.py (setup): bump version to 0.3.1+ while between releases
7705 2003-04-29 Brian Warner <warner@lothar.com>
7707 * setup.py: Releasing buildbot-0.3.1
7709 2003-04-29 Brian Warner <warner@lothar.com>
7711 * README (SUPPORT): add plea to send questions to the mailing list
7713 * NEWS, MANIFEST.in: add description of recent changes
7715 * docs/examples/twisted_master.py: add the code used to create the
7716 Twisted buildmaster, with passwords and such removed out to a
7719 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7720 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7721 buildmasters to not require CVSToys be installed.
7722 * README, docs/examples/glib_master: update to match the change
7724 * buildbot/clients/base.py, buildbot/bot.py,
7725 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7726 ReconnectingPB from CVSToys distribution to remove CVSToys
7727 dependency for build slaves and status clients. Buildmasters which
7728 use FreshCVSSources still require cvstoys be installed, of course.
7730 2003-04-25 Brian Warner <warner@lothar.com>
7732 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7733 runTestsRandomly arg to turn on trial -z
7735 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7736 experimental code to use trial's machine-parseable output to get
7737 more detailed test results. Still has some major issues.
7738 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7741 * buildbot/status/builder.py (Builder.setCurrentBuild):
7742 anticipating moving build history into statusbag, not used yet
7744 * buildbot/status/tests.py: code to centralize test results,
7745 doesn't work quite yet
7747 * buildbot/status/event.py (Event): use hasattr("setName") instead
7748 of isinstance for now.. need better long-term solution
7750 * buildbot/status/html.py: Remove old imports
7752 2003-04-24 Brian Warner <warner@lothar.com>
7754 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7755 ignore changes under doc/fun/ and sandbox/
7757 * buildbot/process/step_twisted.py: update pushEvent and friends.
7759 * buildbot/status/html.py (Box.td): replace event.buildername with
7760 event.parent.getSwappableName(). Needs more thought.
7762 * buildbot/status/builder.py (Builder): Replace pushEvent and
7763 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7764 Tell events they are being pruned with event.delete().
7766 * buildbot/process/base.py (Build): Remove Builder status-handling
7767 methods. s/pushEvent/setCurrentActivity/.
7769 * buildbot/process/step.py (BuildStep): clean up status delivery.
7770 Gouse builder.statusbag methods instead of intermediate builder
7771 methods. s/updateLastEvent/updateCurrentActivity/.
7772 s/finalizeLastEvent/finishCurrentActivity/. Use
7773 addFileToCurrentActivity for summaryFunction.
7775 * buildbot/status/event.py (Logfile): put data in a Swappable when
7777 (Event): add more setter methods. Remove .buildername, use .parent
7778 and getSwappableName instead (needs more thought).
7780 * buildbot/util.py (Swappable):
7781 * test/test_swap.py: don't bother setting filename at __init__
7782 time, do it later. Change setFilename args to take parent first,
7783 since it provides the most significant part of the filename.
7785 2003-04-23 Brian Warner <warner@lothar.com>
7787 * buildbot/status/event.py (Logfile.addEntry): append to previous
7790 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7791 anticipating Swappable
7792 (InternalShellCommand.remoteUpdate): split out various log-adding
7793 methods so subclasses can snarf stdout separately
7795 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7796 in anticipation of Swappable build logs
7797 (Builder.testsFinished): anticipating TestResults, still disabled
7799 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7802 * buildbot/status/event.py (Logfile): add (disabled) support for
7803 Swappable, not ready for use yet
7805 * buildbot/util.py (Swappable): object which is swapped out to
7806 disk after some period of no use.
7807 * test/test_swap.py: test buildbot.utils.Swappable
7809 2003-04-14 Brian Warner <warner@lothar.com>
7811 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7812 periodic-build timer. Set the .periodicBuildTime on a builder
7813 instance to some number of seconds to activate it.
7815 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7817 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7818 a way that survives result tuples
7820 2003-04-12 Brian Warner <warner@lothar.com>
7822 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7823 return a dict instead of a tuple: allow summarizers to provide
7824 multiple summaries if they want
7825 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7826 (debuildSummarizer): summarize lintian warnings/errors
7828 2003-04-10 Brian Warner <warner@lothar.com>
7830 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7832 2003-04-09 Brian Warner <warner@lothar.com>
7834 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7835 empty summaries: happens when the tests fail so hard they don't emit
7836 a parseable summary line.
7838 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7839 Allow summaryFunction to return None to indicate no summary should
7842 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7843 writing to stale HTTP requests: notice when they disconnect and
7844 remove the request from the list. Also add CacheToFile from
7845 moshez, will be used later.
7847 2003-04-08 Brian Warner <warner@lothar.com>
7849 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7850 should be an int, not a list of strings
7852 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7853 if we weren't actually connected
7855 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7856 to show the tail end of the trial text output
7858 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7859 hook to summarize the results of a ShellCommand
7861 2003-04-07 Brian Warner <warner@lothar.com>
7863 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7864 twisted test suite code into a single class.
7865 * buildbot/process/process_twisted.py: same
7867 2003-04-04 Brian Warner <warner@lothar.com>
7869 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7871 * README (SLAVE): document use of mktap to create slave .tap file
7872 (REQUIREMENTS): describe dependencies
7874 * buildbot/bb_tap.py, buildbot/plugins.tml:
7875 * buildbot/bot.py (updateApplication): Add mktap support for creating
7876 buildslave .tap files
7878 2003-03-28 Brian Warner <warner@lothar.com>
7880 * buildbot/process/step.py (InternalShellCommand.finished): handle
7881 new tuple result values (fix embarrasing bug that appeared during
7884 2003-03-27 Brian Warner <warner@lothar.com>
7886 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7889 2003-03-25 Brian Warner <warner@lothar.com>
7891 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7892 to overall build status
7893 * buildbot/clients/base.py (Builder): improve event printing
7894 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7895 instead of generic ShellCommand
7896 (Build): Add .stopBuild, use it when slave is detached
7898 * buildbot/process/step.py (Configure,Test): give the steps their
7899 own names and status strings
7901 * buildbot/status/html.py (StatusResource): add "show" argument,
7902 lets you limit the set of Builders being displayed.
7904 2003-03-20 Brian Warner <warner@lothar.com>
7906 * buildbot/process/basic.py: removed
7908 2003-03-19 Brian Warner <warner@lothar.com>
7910 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7911 turn off process-docs by default
7913 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7914 when displaying build information without anything in allBuilds[]
7916 * buildbot/bot.py (makeApp): really take password from sys.argv
7918 2003-03-18 Brian Warner <warner@lothar.com>
7920 * buildbot/bot.py (buildApp): take password from sys.argv
7922 * README: replace with more useful text
7924 * setup.py: add a real one
7925 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7927 * docs/PyCon-2003/: added sources for PyCon paper.
7929 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7930 now Build objects control the process and Builder only handles
7931 slave stuff and distribution of changes/status. A new BuildFactory
7932 class creates Build objects on demand.
7934 Created ConfigurableBuild which takes a list of steps to run. This
7935 makes it a lot easier to set up a new kind of build and moves us
7936 closer to being able to configure a build from a web page.
7938 * buildbot/process/step_twisted.py, process_twisted.py: move to
7939 new model. A lot of code went away.
7941 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7942 send lots of empty progress messages to the client.
7944 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7946 2003-02-20 Brian Warner <warner@lothar.com>
7948 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7950 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7951 Twisted bug that prevented non-pty processes from working just got
7952 fixed, and the bug that leaks ptys is still being investigated.
7954 * buildbot/process/step.py (CVS): send timeout arg to slave
7956 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7957 builders coming and going
7958 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7959 from CVSToys, handle lost-buildmaster
7961 * buildbot/status/client.py (StatusClientService.removeBuilder):
7962 Clean up status client protocol: send builders (with references)
7963 as they are created, rather than sending a list and requiring the
7964 client to figure out which ones are new.
7965 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7966 attempts to force a build on an unknown builder
7968 2003-02-19 Brian Warner <warner@lothar.com>
7970 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7971 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7972 Twisted stops leaking them.
7973 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7974 builder goes to an idle state.
7976 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7977 I figure out why CVS commands hang without them, and/or I fix the
7978 hung-command timeout
7980 2003-02-16 Brian Warner <warner@lothar.com>
7982 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7983 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7984 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7985 GenerateDocs now that they are prefixed with WARNING:.
7987 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7988 use manual href target instead of request.childLink
7990 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7991 display every second, but update the ETA every 5 seconds (or
7992 whenever) as remote_progress messages arrive.
7995 2003-02-12 Brian Warner <warner@lothar.com>
7997 * *: import current sources from home CVS repository
8001 # add-log-time-format: add-log-iso8601-time-string