1 2006-09-19 Brian Warner <warner@lothar.com>
3 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
4 (PyFlakes.createSummary): make it compatible with python-2.2
6 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
7 for at least the output-parsing parts of PyFlakes
9 2006-09-18 Brian Warner <warner@lothar.com>
11 * buildbot/steps/python.py: oops, fix import of StringIO
13 2006-09-17 Brian Warner <warner@lothar.com>
15 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
16 turns out that SVN-1.4.0 doesn't fail to update once you've
17 replaced a file with a directory, unlike older versions of SVN and
18 pretty much every other VC tool we support. Since what we really
19 care about is that the update succeeds anyway, stop checking that
20 the tree got clobbered and just assert that the build succeeded.
21 (VCBase.printLogs): add a utility function for debugging
23 * buildbot/process/step.py: oops, added extra imports by mistake
25 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
26 rstrip() on the first line coming out of the 'p4 describe'
27 process, to remove the stray ^M that Wade Brainerd reports seeing
28 in the 'when' field. Fixes SF#1555985.
30 * buildbot/master.py (BuildMaster.loadConfig): improve the error
31 message logged when c['schedulers'] is not right
32 * buildbot/scheduler.py (Scheduler.__init__): improve error
33 message when a Scheduler() is created with the wrong arguments
34 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
35 verify that these error messages are emitted
37 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
38 The idea is that all the base classes (like BuildStep and
39 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
40 will be a leftover backwards-compatibility file that only contains
41 aliases for the steps that were moved out to buildbot.steps.*
42 * lots: change imports to match
43 * buildbot/process/step.py: add a DeprecationWarning if it ever
46 2006-09-12 Brian Warner <warner@lothar.com>
48 * buildbot/scheduler.py (Scheduler.__init__): make sure that
49 builderNames= is actually a sequence, since if you happen to give
50 it a single builder-specification dictionary instead, it won't get
51 caught by the existing assert. Thanks to Brett Neely for the
54 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
56 * docs/buildbot.texinfo (Python BuildSteps): document them
57 (sendchange): include a link to PBChangeSource, since you need one
59 * buildbot/steps/shell.py: clean up test-case-name line, remove some
61 * buildbot/steps/dummy.py: same
63 2006-09-08 Brian Warner <warner@lothar.com>
65 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
66 BuildStep which lets you transfer files from the master to the
67 slave or vice versa. Thanks to Albert Hofkamp for the original
68 patch. Fixes SF#1504631.
69 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
71 (SlaveFileDownloadCommand): same
72 * docs/buildbot.texinfo (Transferring Files): document it
73 * buildbot/test/test_transfer.py: test it
74 * buildbot/test/runutils.py (StepTester): new utility class for
75 testing BuildSteps and RemoteCommands without Builds or Bots or PB
76 * buildbot/test/test_steps.py (CheckStepTester): validate that the
79 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
80 walk through StatusLogs one line at a time, mostly for the benefit
81 of ShellCommand.createSummary methods. You can either walk through
82 STDOUT or STDERR, but the default is STDOUT.
84 * buildbot/status/builder.py (LogFile.readlines): implement it.
85 Note that this is not yet memory-efficient, it just pulls the
86 whole file into RAM and then splits it up with a StringIO.
87 Eventually this should be a generator that only pulls chunks from
89 * buildbot/test/test_status.py (Log.testReadlines): test it
91 * docs/buildbot.texinfo: update to match changes
92 * buildbot/process/factory.py: stop using old definitions
93 * buildbot/process/process_twisted.py: same
94 * buildbot/test/test_*.py: same
96 * buildbot/process/step_twisted.py: move definition to..
97 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
98 relative-import mechanisms prevent this from being named 'twisted'
99 or 'python/twisted' as I would have preferred.
101 * buildbot/process/maxq.py: move definition to..
102 * buildbot/steps/maxq.py: .. here, leave a compatibility import
104 * buildbot/process/step.py: split the user-visible BuildSteps into
105 separate files, all under buildbot/steps/
106 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
107 * buildbot/steps/shell.py: this holds ShellCommand and friends
108 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
110 2006-09-05 Brian Warner <warner@lothar.com>
112 * lots: run pyflakes, removed a lot of unused imports, changed the
113 form of some conditional imports to remove false pyflakes
114 warnings. There are still a number of warnings left, mostly from
115 imports that are done for their side-effects.
116 * buildbot/test/test_vc.py: import twisted.python.failure, since it
119 2006-08-26 Brian Warner <warner@lothar.com>
121 * buildbot/test/test_locks.py (Unit.testLater): make the tests
122 compatible with twisted-1.3.0, for some reason I just can't seem
123 to let go of the past.
125 2006-08-25 Brian Warner <warner@lothar.com>
127 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
129 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
130 all logfiles= in startCommand(), rather than in start() . This
131 makes it easier to have the 'stdio' log come before any secondary
132 logfiles, which I feel makes the waterfall display more
134 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
135 from ShellCommand up into LoggingBuildStep
136 (LoggingBuildStep.__init__): move the handling of logfiles= from
137 ShellCommand up to LoggingBuildStep, because startCommand is
138 provided by LoggingBuildStep, whereas start() was specific to
139 subclasses like ShellCommand and Source. This removes code
140 duplication in those subclasses.
141 (ShellCommand.__init__): same
142 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
143 for a slave that's too old to understand logfiles= into a separate
144 method, so it can live in ShellCommand. The rest of
145 setupLogfiles() can live in LoggingBuildStep.
147 2006-08-24 Brian Warner <warner@lothar.com>
149 * buildbot/locks.py (BaseLock): you can now configure Locks to
150 allow multiple simultaneous owners. They still default to
151 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
153 * docs/buildbot.texinfo (Interlocks): document the new options
154 * buildbot/test/test_locks.py: add a bunch of new unit tests
155 * buildbot/process/base.py (Build.acquireLocks): locks now offer
156 waitUntilMaybeAvailable, not waitUntilAvailable
157 * buildbot/process/step.py (BuildStep.acquireLocks): same
158 * buildbot/master.py (BotMaster.getLockByID): real locks now use
159 the whole lockid in their constructor, not just the name. Also,
160 keep track of which real locks we've handed out by the full
161 lockid, not just class+name, otherwise changing just the maxCount=
162 in the master.cfg file would not actually cause a behavioral
165 2006-08-23 Brian Warner <warner@lothar.com>
167 * buildbot/__init__.py (version): bump to 0.7.4+ while between
169 * docs/buildbot.texinfo: same
171 2006-08-23 Brian Warner <warner@lothar.com>
173 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
174 * docs/buildbot.texinfo: set version to match
175 * NEWS: update for 0.7.4
176 * buildbot/slave/commands.py (command_version): mention that this
177 version (2.1) was released with buildbot-0.7.4
179 2006-08-22 Brian Warner <warner@lothar.com>
183 * CREDITS: new file, list of people who have helped. Thanks!
184 * MANIFEST.in: ship it
186 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
187 new diagrams, the user's manual is more informative than it was.
188 Start shipping the .html user's manual (and generated .png
190 * Makefile: update 'release' target to match
192 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
193 test.. I think the web-parts effort will render it pointless well
194 before it ever actually starts to work.
196 2006-08-20 Brian Warner <warner@lothar.com>
198 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
199 meaning of the prefix= argument. It is now just a string which is
200 stripped from the beginning of the filename. If prefix= is set but
201 not found on any given filename, that filename is ignored. If all
202 filenames in a Change are ignored, the Change is dropped. This is
203 much simpler than the previous sep= nonsense, and I should have
204 implemented it this way from the beginning. Effectively resolves
205 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
206 Gedminas for the catch and suggested fixes.
207 (ChangePerspective.perspective_addChange): implement the actual
209 * buildbot/test/test_changes.py (TestChangePerspective): test it
210 * docs/buildbot.texinfo (PBChangeSource): document it, explain
211 how to properly use prefix=
212 * docs/examples/twisted_master.cfg (source): update prefix= by
213 adding the trailing slash
216 * docs/examples/twisted_master.cfg: update to actual practice
218 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
219 update test case to match new link text.. the HREF has both a
220 class= setting and an enclosing [] pair that I didn't match in the
223 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
224 list of strings is preferred over a single string with embedded
226 (ShellCommand.description=): explain that either single strings or
227 a list of strings is acceptable, and why you might prefer one over
228 the other. Add an example. Fixes SF#1524659, thanks to Paul
229 Winkler for the catch.
230 (Build Steps): update to use f.addStep() rather than using s()
231 and the constructor list
233 * buildbot/process/step.py (ShellCommand): accept either a single
234 string or a list of strings in both description= and
236 * buildbot/test/test_steps.py (Steps.test_description): test it
237 * buildbot/test/runutils.py (makeBuildStep): support for that test
239 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
240 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
241 collecting the files and creating the patch.
243 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
244 per-step URLs that will be displayed on the waterfall display,
245 for things like the HTML output of code-coverage tools, when
246 the results are hosted elsewhere.
247 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
248 way to retrieve these URLs
249 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
250 the method to retrieve these URLs. Also provide backwards
251 compatibility for saved BuildStepStatus instances that didn't have
253 * buildbot/process/step.py (BuildStep.addURL): method to set these
254 URLs from within a BuildStep
255 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
256 (StepBox.getBox): give these external links a distinct CSS class
257 named "BuildStep external" so a .css file can display them
260 * buildbot/test/test_web.py (WaterfallSteps): test that we really
262 * buildbot/test/test_steps.py (Steps): test that we can all the
263 URLs. Also add a bunch of other tests on methods that can be
264 called from within BuildSteps
265 * buildbot/test/runutils.py (makeBuildStep): add utility function
267 2006-08-13 Brian Warner <warner@lothar.com>
269 * docs/buildbot.texinfo (BuildStep LogFiles): document them
271 2006-08-10 Brian Warner <warner@lothar.com>
273 * docs/buildbot.texinfo (Index of master.cfg keys): add another
274 index, this one of things like c['sources'] and c['schedulers']
275 (indices): it looks like my clever idea of putting the @fooindex
276 commands in between the @node and the @subsection (to make the
277 HREF anchor jump to slightly above the section title, which works
278 much better in html) confused texinfo horribly, so I'm moving the
279 index tags back to be just after the @subsection marker. I also
280 added extra lines between the @node/@section paragraph and the
281 index tags, since I think maybe texinfo wants to see these be
284 * docs/Makefile (images): make sure images get built when
286 * docs/images/Makefile: same
288 * buildbot/scripts/runner.py: rename 'buildbot master' to
289 'buildbot create-master', and 'buildbot slave' to 'buildbot
291 * docs/buildbot.texinfo: same
294 * docs/buildbot.texinfo: reimplement the "useful classes" index
295 with actual texinfo indices. The .info rendering is a bit
296 weird-looking but it works well, and the HTML rendering is quite
297 nice. This also puts the index targets in the regular flow of the
298 text, which is easier to maintain.
300 2006-08-06 Brian Warner <warner@lothar.com>
302 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
303 Kevin Turner to prefer the environ= argument be a list rather than
304 a string. If it is a list, it will be joined with a platform-local
305 os.pathsep delimiter, and then prepended to any existing
306 $PYTHONPATH value. This works better in cross-platform (i.e.
307 windows buildslaves) environments when you need to push multiple
308 directories onto the front of the path.
309 (SlaveShellCommand): documented the new magic
310 * docs/buildbot.texinfo (ShellCommand): documented the new magic
311 in a user-visible form
313 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
314 Turner to prefer lists over strings when creating/running VC
315 commands during unit tests. This is clearly necessary to survive
316 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
317 renamed the wq() function to qw() though, since that's how it's
318 spelled in perl. Eventually I'd prefer all commands to be
319 specified with lists.
321 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
322 which are deleted (or not yet created) correctly. Also add
323 failsafe code to not explode if the file-watching poller doesn't
324 get started. Thanks to JP Calderone for the catch and the poller
326 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
328 * buildbot/test/emitlogs.py: same
330 * NEWS: summarize recent changes
332 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
333 clause to avoid the "host key mismatch" warning
335 * buildbot/process/step_twisted.py (Trial.start): if the
336 buildslave is too old to understand logfiles=, fall back to
337 running 'cat _trial_temp/test.log' like before.
338 (Trial.commandComplete): same. this takes advantage of the
339 LoggingBuildStep refactoring to stall commandComplete long enough
340 to run a second RemoteShellCommand.
342 * buildbot/process/step.py (LoggingBuildStep.startCommand):
343 refactor command-completion handling, to allow methods like
344 commandComplete/createSummary/evaluateCommand to return Deferreds.
345 (LoggingBuildStep._commandComplete): delete the refactored method
346 (ShellCommand.setupLogfiles): if the buildslave is too old to
347 understand logfiles=, put a warning message both into twistd.log
348 and into the otherwise empty user-visible LogFiles.
350 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
351 callers to provide the slave-side logfile name, rather than
352 forcing it to come from the local name of the LogFile.
353 (BuildStep.getSlaveName): new method
355 * buildbot/process/base.py (Build.getSlaveName): new method, so
356 steps can find out which buildslave they're running on
358 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
359 to match the s/cvs_ver/command_version/ change
361 2006-08-05 Brian Warner <warner@lothar.com>
363 * buildbot/slave/commands.py (command_version): replace the CVS
364 auto-updated cvs_ver keyword with a manually-updated variable,
365 since CVS is no longer the master repository. Add a description of
366 the remote API change starting in this version (2.1), specifically
367 the fact that SlaveShellCommand now accepts 'initial_stdin',
368 'keep_stdin_open', and 'logfiles'.
370 2006-07-31 Brian Warner <warner@lothar.com>
372 * docs/buildbot.texinfo (System Architecture): Finally add lots of
373 diagrams to describe how the whole system fits together. The
374 images themselves are kept in SVG files, with ascii-art versions
375 in corresponding .txt files. Texinfo knows how to interpolate the
376 text version into .info files, reference the .png versions from
377 .html files, and include .eps versions in the .ps format.
378 * docs/images/Makefile: tools to create .png and .eps
379 * docs/images/*.svg: created pictures with Inkscape.
380 * .darcs-boring: ignore the generated .eps and .png files
382 2006-07-24 Brian Warner <warner@lothar.com>
384 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
385 Scheduler names, since they cause setServiceParent to explode
387 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
389 2006-07-20 Brian Warner <warner@lothar.com>
391 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
392 which runs the buildbot unit tests
394 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
395 classes that are useful in master.cfg
397 2006-07-15 Brian Warner <warner@lothar.com>
399 * Makefile (some-apidocs): new target to build only some epydocs
401 * setup.py: minor comment.. does the classifiers= argument prevent
402 the setup.py script from working on python2.2/2.3?
404 * buildbot/scripts/sample.cfg: update manhole example, arrange into
407 * buildbot/twcompat.py: fix minor typo in comments
409 * buildbot/manhole.py: move all Manhole-related code out to this
410 module. Implement SSH-based manholes (with TwistedConch), and move
411 to conch's nifty line-editing syntax-coloring REPL shell instead
412 of the boring non-editing monochromatic (and deprecated) old
414 * buildbot/master.py: remove all Manhole-related code
415 (BuildMaster.loadConfig._add): make sure the old manhole is
416 removed before we add the new one
417 * docs/buildbot.texinfo (Debug options): document new Manhole options
419 * buildbot/twcompat.py (_which): fix some epydoc issues
420 * buildbot/status/html.py (Waterfall.__init__): same
422 2006-06-29 Brian Warner <warner@lothar.com>
424 * buildbot/interfaces.py: get Interface from b.twcompat to hush
425 deprecation warnings under newer Twisteds (by using
426 zope.interface.Interface instead of old twisted.python.components
428 * buildbot/slave/interfaces.py: same
430 2006-06-28 Brian Warner <warner@lothar.com>
432 * buildbot/slave/commands.py (SVN): add --non-interactive to all
433 svn commands, so it will fail immediately instead of hanging while
434 it waits for a username/password to be typed in.
436 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
437 log message if the step was shut down
439 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
440 obsolete reference to mktap.
442 2006-06-20 Brian Warner <warner@lothar.com>
444 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
445 test to include new 'logfiles' argument sent from master to slave
447 2006-06-19 Brian Warner <warner@lothar.com>
449 * buildbot/process/step_twisted.py (Trial): track Progress from
450 _trial_temp/test.log too
452 * buildbot/process/step.py (OutputProgressObserver): generalize
453 the earlier StdioProgressObserver into an OutputProgressObserver
454 that can track LogFiles other than stdio.
455 (LoggingBuildStep.__init__): same
457 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
458 _trial_temp/test.log, not a separate 'cat' command. TODO: this
459 will fail under windows because of os.sep issues. It might have
460 worked before if 'cat' was doing cygwin path conversion.
462 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
463 creation of LogFileWatchers
464 (ShellCommand._startCommand): and record the files that were
465 watched in the 'headers' section of the ShellCommand output
467 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
468 need to actually pass it to the slave if you want it to work.
469 (ShellCommand): document it a bit
471 * buildbot/test/test_shell.py: new test to validate LogFiles
472 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
474 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
475 before printing the last batch of lines, to test that the polling
476 logic is working properly
478 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
479 handling, making it possible to track multiple logs for a single
480 RemoteCommand. The previous single logfile is now known as the
482 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
483 (RemoteShellCommand.__init__): accept logfiles=
484 (LoggingBuildStep.startCommand): stdio_log is now one of many
485 (ShellCommand): added logfiles= argument, as well as a class-level
486 .logfiles attribute, which will be merged together to figure out
487 which logfiles should be tracked. The latter maybe be useful for
488 subclasses of ShellCommand which know they will aways produce
489 secondary logfiles in the same location.
491 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
492 and closeStdin() methods, preparing to make it possible to write
493 to a ShellCommand's stdin at any time, not just at startup. These
494 writes are buffered if the child process hasn't started yet.
495 (LogFileWatcher): new helper class to watch arbitrary logfiles
496 while a ShellCommand runs. This class polls the file every two
497 seconds, and sends back 10k chunks to the buildmaster.
498 (ShellCommand): rename stdin= to initialStdin=, and add
499 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
501 (ShellCommand.addLogfile): LogFile text is sent in updates with a
502 key of "log" and a value of (logname, data).
503 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
504 'logfiles' to the master-visible args dictionary.
505 (SourceBase.doPatch): match s/stdin/initialStdin/ change
508 * buildbot/test/test_vc.py (Patch.testPatch): same
511 * buildbot/test/emit.py: write to a logfile in the current
512 directory. We use this to figure out what was used as a basedir
513 rather than looking to see which copy of emit.py gets run, so that
514 we can run the commands from inside _trial_temp rather than inside
516 * buildbot/test/subdir/emit.py: same
517 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
518 argument rather than running from buildbot/test/
519 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
520 rather than using an implicit setUp()
521 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
522 (ShellBase.testShell1, etc): use explicit path to emit.py instead
523 of assuming that we're running in buildbot/test/ (and that '.' is
526 * buildbot/slave/commands.py (Command.doStart): refactor Command
527 startup/completion a bit: now the SlaveBuilder calls doStart(),
528 which is not meant for overridding by subclasses, and doStart()
529 calls start(), which is. Likewise the SlaveBuilder calls
530 doInterrupt(), and subclasses override interrupt(). This also puts
531 responsibility for maintaining .running in Command rather than in
533 (Command.doInterrupt): same
534 (Command.commandComplete): same, this is called when the deferred
535 returned by start() completes.
536 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
537 (SlaveBuilder.remote_interruptCommand): same
538 (SlaveBuilder.stopCommand): same
540 2006-06-16 Brian Warner <warner@lothar.com>
542 * buildbot/test/test_shell.py: new test file to contain everything
543 relating to ShellCommand
544 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
545 multiple logfiles in realtime" feature, not yet implemented
546 * buildbot/test/emitlogs.py: support file for testLogFiles
547 * docs/buildbot.texinfo (ShellCommand): document the feature
549 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
551 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
552 for tests which exercise SlaveCommands in isolation.
554 * buildbot/test/test_slavecommand.py: Move some utilities like
555 SignalMixin and FakeSlaveBuilder from here ..
556 * buildbot/test/runutils.py: .. to here, so they can be used by
557 other test classes too
558 * buildbot/test/test_vc.py: more SignalMixin refactoring
559 * buildbot/test/test_control.py: same
560 * buildbot/test/test_run.py: and some rmtree refactoring
562 2006-06-15 Brian Warner <warner@lothar.com>
564 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
565 'testBranch' to match other VC tests and have the tests run in
566 roughly increasing order of dependency
568 * buildbot/test/test_steps.py (LogObserver): new test to verify
569 LogObservers can be created at various times and still get
570 connected up properly
572 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
573 to create BuildStepStatus instances that actually work.
575 * buildbot/process/step.py (LogObserver): add outReceived and
576 errReceived base methods, to be overridden
578 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
579 API to take a name instead of a step, reducing the coupling
580 somewhat. This returns the BuildStepStatus object so it can be
581 passed to the new Step, instead of jamming it directly into the
583 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
585 * buildbot/process/base.py (Build.setupBuild): use both methods
586 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
587 process a bit to match
589 2006-06-14 Brian Warner <warner@lothar.com>
591 * docs/buildbot.texinfo (Adding LogObservers): add some limited
592 docs on writing new LogObserver classes
593 (Writing New Status Plugins): brief docs on how Status Plugins fit
596 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
597 implement a LogObserver that counts how many unit tests have been
599 (Trial.__init__): wire it in
600 * buildbot/test/test_twisted.py (Counter): unit test for it
602 * buildbot/process/step_twisted.py (HLint.commandComplete): update
603 to new cmd.logs['stdio'] scheme
604 (Trial.commandComplete): same
605 (BuildDebs.commandComplete): same
607 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
608 LogFiles, instead of just a single one. The old single logfile is
609 now called "stdio". LoggedRemoteCommand no longer creates a
610 LogFile for you (the code to do that was broken anyway). If you
611 don't create a "stdio" LogFile, then stdout/stderr will be
613 (LogObserver): implement "LogObservers", which a BuildStep can add
614 to parse the output of a command in real-time. The primary use is
615 to provide more useful information to the Progress code, allowing
616 better ETA estimates.
617 (LogLineObserver): utility subclass which feeds complete lines to
618 the parser instead of bytes.
619 (BuildStep.progressMetrics): this is safer as a tuple
620 (BuildStep.setProgress): utility method, meant to be called by
622 (BuildStep.addLogObserver): new method, to be called at any time
623 during the BuildStep (even before any LogFiles have been created),
624 to attach (or schedule for eventual attachment) a LogObserver to a
626 (StdioProgressObserver): new LogObserver which replaces the old
627 "output" progress gatherer
628 (LoggingBuildStep.__init__): same
629 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
630 (LoggingBuildStep._commandComplete): must use logs['stdio']
631 instead of the old single ".log" attribute.
632 * buildbot/status/builder.py (LogFile): remove old logProgressTo
633 functionality, now subsumed into StdioProgressObserver
634 * buildbot/test/test_status.py (Subscription._testSlave_2): the
635 log name changed from "output" to "stdio".
638 * buildbot/interfaces.py (ILogFile): add the Interface used from
639 the BuildStep towards the LogFile
640 (ILogObserver): and the one provided by a LogObserver
641 * buildbot/status/builder.py (LogFile): implement it
643 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
644 HEADER constants here ..
645 * buildbot/status/builder.py (STDOUT): .. from here
647 2006-06-13 Brian Warner <warner@lothar.com>
649 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
650 compatibility with python2.2, which doesn't have the 'substr in
652 (TestP4Poller.makeTime): utility function to construct the
653 timestamp using the same strptime() approach as p4poller does. It
654 turns out that time.mktime() behaves slightly differently under
655 python2.2, probably something to do with the DST flag, and that
656 causes the test to fail under python2.2. (changing the mktime()
657 arguments to have dst=0 instead of -1 caused it to fail under
658 python2.3. Go figure.)
659 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
661 2006-06-12 Brian Warner <warner@lothar.com>
663 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
664 proper Perforce (P4) support. Many many thanks to Scott Lamb for
665 contributing such an excellent patch, including docs and unit
666 tests! This makes it *so* much easier to apply. I had to update
667 test_vc.py to handle some recent refactorings, but everything else
668 applied smoothly. The only remaining thing I'd like to fix would
669 be to remove the hard-wired port 1666 used by p4d, and allow it to
670 claim any unused port. This would allow two copies of the test
671 suite to run on the same host at the same time, as well as
672 allowing the test suite to run while a real (production) p4d was
673 running on the same host. Oh, and maybe we should add a warning to
674 step.P4 that gets emitted if the slave is too old to provide the
675 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
676 * buildbot/slave/commands.py (P4): same
677 (P4Sync): same, some minor updates
678 * buildbot/changes/p4poller.py: same
679 * docs/buildbot.texinfo: same
680 * buildbot/test/test_p4poller.py: same
681 * buildbot/test/test_vc.py (P4): same
683 * setup.py: add Trove classifiers for PyPI
685 2006-06-08 Brian Warner <warner@allmydata.com>
687 * buildbot/status/client.py
688 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
689 changing this from getCurrentBuild() to getCurrentBuilds(). Each
690 build needs to be IRemote'd separately, rather than IRemote'ing
691 the whole list at once. I can't wait until newpb's serialization
692 adapters make this unnecessary.
694 2006-06-06 Brian Warner <warner@lothar.com>
696 * buildbot/process/step.py (WithProperties): make this inherit
697 from ComparableMixin, so that reloading an unchanged config file
698 doesn't cause us to spuriously reload any Builders which use them.
699 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
702 2006-06-03 Brian Warner <warner@lothar.com>
704 * contrib/windows/{setup.py, buildbot_service.py}: add support for
705 running py2exe on windows, contributed by Mark Hammond. Addresses
706 SF#1401121, but I think we still need to include
707 buildbot/scripts/sample.cfg
708 * setup.py: include buildbot_service.py as a script under windows
709 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
710 a py2exe application), get the icon/css datafiles from a different
713 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
714 double-escape the build URL. Thanks to Olivier Bonnet for the
715 patch. Fixes SF#1452801.
717 2006-06-02 Brian Warner <warner@lothar.com>
719 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
720 first six columns of 'svnlook' output, not just the first column,
721 since property changes appear in the other five. Thanks to Olivier
722 Bonnet for the patch. Fixes SF#1398174.
724 2006-06-01 Brian Warner <warner@lothar.com>
726 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
727 the fake build, so that title= has something to be set to
729 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
730 attribute of the "Build #NN" link in the yellow start-the-build
731 box to the build's reason. This means that you get a little
732 tooltip explaining why the build was done when you hover over the
733 yellow box. Thanks to Zandr Milewski for the suggestion.
735 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
736 (Box.setETA): handle ETA=None (by stopping the timer)
737 (Box.update): make the [soon] text less different than the usual
738 text, so the rest of the text doesn't flop around so much. It
739 would be awfully nice to figure out how to center this stuff.
740 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
742 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
743 by default, so that any ShellCommand which fails marks the overall
744 build as a failure. I should have done this from the beginning.
745 Add flunkOnFailure=False to the arguments if you want to turn off
748 2006-05-30 Brian Warner <warner@lothar.com>
750 * buildbot/clients/gtkPanes.py: add a third row: now it shows
751 last-build/current-build/current-step. Show what step is currently
752 running. Show ETA for both the overall build and the current step.
753 Update GTK calls to modern non-deprecated forms. There's still a
754 lot of dead code and debug noise to remove.
756 * buildbot/process/step_twisted.py (Trial): set the step name, so it
757 shows up properly in status displays
759 2006-05-28 Brian Warner <warner@lothar.com>
761 * buildbot/test/test_properties.py (Run.testInterpolate): on the
762 build we use to verify that WithProperties works:
764 ** set flunkOnFailure=True so that build failures get noticed
765 ** set workdir='.' so that the build succeeds, otherwise it is trying
766 to touch 'build/something', and 'build/' doesn't exist because
767 usually that's created by a Source step
768 ** set timeout=10, because Twisted-1.3.0 has a race condition that
769 this test somehow triggers, in which the 'touch' process becomes
770 a zombie and we wait for th etimeout before giving up on it.
772 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
773 to log the Build results and step logs to the twisted log.
774 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
775 what went wrong if a build was expected to succeed but didn't.
777 * buildbot/process/step_twisted.py (Trial): set the default
778 trialMode to '--reporter=bwverbose', which specifies verbose
779 black-and-white text. Back in twisted-1.3/2.0 days we had to use
780 '-to', but those are completely missing in modern Twisteds.
782 * buildbot/scripts/sample.cfg: make the sample Manhole config use
783 a localhost-only port, to encourage better security
785 * docs/buildbot.texinfo (Change Sources): mention
788 * .darcs-boring: add a Darcs boringfile
790 * README (REQUIREMENTS): stop claiming compatibility with
793 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
796 2006-05-27 Brian Warner <warner@lothar.com>
798 * buildbot/__init__.py: bump to 0.7.3+ while between releases
799 * docs/buildbot.texinfo: same
801 2006-05-23 Brian Warner <warner@lothar.com>
803 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
804 * docs/buildbot.texinfo: set version to match
805 * NEWS: update for 0.7.3
807 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
808 give a quick mapping from VC system to possible ChangeSources
809 (Build Properties): add 'buildername'
811 * buildbot/process/base.py (Build.setupStatus): oops, set
812 'buildername' and 'buildnumber' properties
813 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
816 2006-05-22 Brian Warner <warner@lothar.com>
818 * docs/buildbot.texinfo (Build Properties): explain the syntax of
819 property interpolation better
821 * README (INSTALLATION): remove old '-v' argument from recommended
824 * docs/buildbot.texinfo (ShellCommand): add docs for description=
825 and descriptionDone= arguments. Thanks to Niklaus Giger for the
828 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
829 'svnversion' instead of grepping the output of 'svn info', much
830 simpler and avoids CR/LF problems on windows. Thanks to Olivier
831 Bonnet for the suggestion.
832 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
833 require the WC_PATH argument, so run 'svnversion .' instead.
835 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
836 aren't supposed to have 'self' in their argument list
838 2006-05-21 Brian Warner <warner@lothar.com>
840 * buildbot/process/step.py (ShellCommand.start): make
841 testInterpolate pass. I was passing the uninterpolated command to
842 the RemoteShellCommand constructor
843 (ShellCommand._interpolateProperties): oops, handle non-list
844 commands (i.e. strings with multiple words separated by spaces in
845 them) properly, instead of forgetting about them.
847 * buildbot/test/test_properties.py (Run.testInterpolate): new test
848 to actually try to use build properties in a real build. This test
850 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
851 to start and evaluate builds
853 * buildbot/test/test__versions.py: add a pseudo-test to record
854 what version of Twisted/Python/Buildbot are running. This should
855 show up at the beginning of _trial_tmp/test.log, and exists to help
856 debug other problems.
858 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
859 a filename to be served as 'robots.txt' to discourage web spiders.
860 Adapted from a patch by Tobi Vollebregt, thanks!
861 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
862 (Waterfall.test_waterfall): tweak the way that filenames are put
863 into the config file, to accomodate windows pathnames better.
865 * docs/buildbot.texinfo (HTML Waterfall): document it
867 * buildbot/process/process_twisted.py
868 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
869 changed the build process. The new setup.py no longer takes the
871 (FullTwistedBuildFactory.__init__): same
872 (TwistedReactorsBuildFactory.__init__): same
874 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
875 be placed in the [hooks] section of the central repository (the
876 one that everybody pushes changes to).
878 2006-05-20 Brian Warner <warner@lothar.com>
880 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
881 .darcs-context file, use binary mode. I think this was causing a
882 Darcs failure under windows.
884 2006-05-19 Brian Warner <warner@lothar.com>
886 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
887 use a timezone string of +0000 and gmtime, since this timestamp is
888 sent to a buildmaster and %z is broken.
890 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
891 string and localtime, since this timestamp will only be consumed
892 locally, and %z is broken.
894 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
895 gmtime, since this timestamp is returned to the buildmaster, and
898 2006-05-18 Brian Warner <warner@lothar.com>
900 * NEWS: update in preparation for next release
902 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
903 setup-repository and do-we-have-the-vc-tools code into a separate
904 "helper" class, which sticks around in a single module-level
905 object. This seems more likely to continue to work in the future
906 than having it hide in the TestCase and hope that TestCases stick
907 around for a long time.
909 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
910 addremove' has been deprecated in recent versions of mercurial, so
913 2006-05-07 Brian Warner <warner@lothar.com>
915 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
916 operating under windows, move the file before opening it, since
917 you can't rename a file that somebody has open.
919 * buildbot/process/base.py (Build.setupBuild): if something goes
920 wrong while creating a Step, log the name and arguments, since the
921 error message when you get the number of arguments wrong is really
924 2006-05-06 Brian Warner <warner@lothar.com>
926 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
927 bugs in twisted-specific code not covered by my unit tests, this
928 time use 'cmd' argument instead of self.cmd
930 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
931 fix stupid braino: either use startwith or find()==0, not both.
932 (TwistedReactorsBuildFactory.__init__): another dumb typo
934 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
935 mark this test as TODO under windows, since process-killing seems
936 dodgy there. We'll come back to this later and try to fix it
939 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
940 and don't include a timezone
941 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
942 This should avoid the windows-with-verbose-timezone-name problem
944 (Patch.testPatch): add a test which runs 'patch' with less
945 overhead than the full VCBase.do_patch sequence, to try to isolate
946 a windows test failure. This one uses slave.commands.ShellCommand
947 and 'patch', but none of the VC code.
949 * buildbot/slave/commands.py (getCommand): use which() to find the
950 executables for 'cvs', 'svn', etc. This ought to help under
953 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
954 working directory before starting. If an earlier test failed, the
955 leftover directory would mistakenly flunk a later test.
956 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
957 Make sure that we use the right commandlines if which("tla") picks
958 up "tla.exe" (as it does under windows).
959 (TlaSupport.do_get): factor out this tla-vs-baz difference
960 (TlaSupport.vc_create): more tla-vs-baz differences
962 * buildbot/test/test_slavecommand.py
963 (ShellBase.testShellMissingCommand): stop trying to assert
964 anything about the error message: different shells on different
965 OSes with different languages makes it hard, and it really isn't
966 that interesting of a thing to test anyway.
968 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
969 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
970 "Panther"), because it has a bug which flunks a couple tests in
971 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
972 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
973 able to test that yet.
975 2006-04-30 Brian Warner <warner@lothar.com>
977 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
978 make sure child commands emit messages in english, so our regexps
979 will match. Thanks to Nikaus Giger for identifying the problems.
980 (VCBase._do_vctest_export_1): mode="export" is not responsible
981 for setting the "got_revision" property, since in many cases it is
982 not convenient to determine.
983 (SVNSupport.capable): when running 'svn --version' to check for
984 ra_local, we want error messages in english
985 * buildbot/test/test_slavecommand.py
986 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
987 to emit the error message in english
989 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
990 the environment with $LC_ALL="C" so that Commands which need to
991 parse the output of their child processes can obtain it in
993 (SVN.parseGotRevision): call "svn info" afterwards instead of
994 watching the output of the "svn update" or "svn checkout".
995 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
996 (Arch.parseGotRevision): same
997 (Bazaar.parseGotRevision): same
998 (Mercurial.parseGotRevision): same
1000 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1001 $LC_ALL="C" when running commands under 'buildbot try', too
1003 * buildbot/test/__init__.py: remove the global os.environ()
1004 setting, instead we do it just for the tests that run commands and
1005 need to parse their output.
1007 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1008 remove the overly-short .timeout on this test, because non-DNotify
1009 platforms must fall back to polling which happens at 10 second
1010 intervals, so a 5 second timeout would never succeed.
1012 2006-04-24 Brian Warner <warner@lothar.com>
1014 * docs/buildbot.texinfo (Installing the code): update trial
1015 invocation, SF#1469116 by Niklaus Giger.
1016 (Attributes of Changes): updated branch-name examples to be
1017 a bit more realistic, SF#1475240 by Stephen Davis.
1019 * contrib/windows/buildbot2.bat: utility wrapper for windows
1020 developers, contributed by Nick Trout (after a year of neglect..
1021 sorry!). SF#1194231.
1023 * buildbot/test/test_vc.py (*.capable): store the actual VC
1024 binary's pathname in VCS[vcname], so it can be retrieved later
1025 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1026 strip out non-numeric timezone information, specifically the funky
1027 German string that his system produced that confuses CVS.
1028 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1029 allow Darcs tests to work on windows
1030 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1031 procutils.which() everywhere, to allow tryclient to work under
1032 windows. Also from Niklaus Giger, SF#1463394.
1034 * buildbot/twcompat.py (which): move the replacement for a missing
1035 twisted.python.procutils.which from test_vc.py to here, so it can
1036 be used in other places too (specifically tryclient.py)
1038 2006-04-23 Brian Warner <warner@lothar.com>
1040 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1041 bare buildbotURL/projectName line with a proper DIV, along with a
1042 CSS class of "title", from Stefan Seefeld (SF#1461675).
1043 (WaterfallStatusResource.body0): remove the redundant 'table'
1044 class from the table
1045 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1046 to the top-row TR, and class="Activity" to the second-row TR,
1047 rather than putting them in the individual TD nodes.
1049 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1050 'got_revision' build property for all VC systems that implement
1051 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1053 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1054 to determine which revision we actually obtained
1055 (CVS.parseGotRevision): implement this for CVS, which just means
1056 to grab a timestamp. Not ideal, and it depends upon the buildslave
1057 having a clock that is reasonably well syncronized with the server,
1058 but it's better than nothing.
1059 (SVN.parseGotRevision): implement it for SVN, which is accurate
1060 (Darcs.parseGotRevision): same
1061 (Arch.parseGotRevision): same
1062 (Bazaar.parseGotRevision): same
1063 (Mercurial.parseGotRevision): same
1065 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1066 keep a record of all non-stdout/stderr/header/rc status updates,
1067 for the benefit of RemoteCommands that send other useful things,
1069 (Source.commandComplete): put any 'got_revision' status values
1070 into a build property of the same name
1073 * buildbot/process/step_twisted.py (Trial): update to deal with
1074 new ShellCommand refactoring
1076 * docs/buildbot.texinfo (Build Properties): document new feature
1077 that allows BuildSteps to get/set Build-wide properties like which
1078 revision was requested and/or checked out.
1080 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1081 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1082 it. Note that this bumps the persistenceVersion of the saved Build
1083 object, so add the necessary upgrade-old-version logic to include
1084 an empty properties dict.
1086 * buildbot/process/base.py (Build.setProperty): implement it
1087 (Build.getProperty): same
1088 (Build.startBuild): change build startup to set 'branch',
1089 'revision', and 'slavename' properties at the right time
1091 * buildbot/process/step.py (BuildStep.__init__): change setup to
1092 require 'build' argument in a better way
1093 (LoggingBuildStep): split ShellCommand into two pieces, for better
1094 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1095 a single RemoteCommand that sends stdout/stderr status text. It
1096 also provides the usual commandComplete / createSummary /
1097 evaluateCommand / getText methods to be overridden...
1098 (ShellCommand): .. whereas ShellCommand is specifically for
1099 running RemoteShellCommands. Other shell-like BuildSteps (like
1100 Source) can inherit from LoggingBuildStep instead of ShellCommand
1101 (WithProperties): marker class to do build-property interpolation
1102 (Source): inherit from LoggingBuildStep instead of ShellCommand
1105 * buildbot/test/test_properties.py: test new functionality
1107 2006-04-21 Brian Warner <warner@lothar.com>
1109 * buildbot/test/test_vc.py: rename testBranch to
1110 testCheckoutBranch to keep the tests in about the right
1113 2006-04-18 Brian Warner <warner@lothar.com>
1115 * docs/buildbot.texinfo (PBListener): improve cross-references
1116 between PBListener and 'buildbot statusgui', thanks to John Pye
1119 2006-04-17 Brian Warner <warner@lothar.com>
1121 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1122 running under Twisted-1.3.0, otherwise skipped tests are reported
1125 * all: use isinstance() instead of 'type(x) is foo', suggested by
1128 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1129 oops, fix a brain-fade from the other week, when making the
1130 addStep changes. I changed all the __init__ upcalls to use the
1131 wrong superclass name.
1132 (FullTwistedBuildFactory.__init__): same
1133 (TwistedDebsBuildFactory.__init__): same
1134 (TwistedReactorsBuildFactory.__init__): same
1135 (TwistedBuild.isFileImportant): use .startswith for clarity,
1136 thanks to Neal Norwitz for the suggestions.
1138 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1139 changes, then deliver them over PB to a remote buildmaster.
1141 * contrib/svnpoller.py: added script by John Pye to poll a remote
1142 SVN repository (by running 'svn log') from a cronjob, and run
1143 'buildbot sendchange' to deliver the changes to a remote
1145 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1146 modification of svnpoller.py), same purpose, but this one loops
1147 internally (rather than expecting to run from a cronjob) and works
1149 * contrib/README.txt: same
1151 2006-04-11 Brian Warner <warner@lothar.com>
1153 * all: fix a number of incorrect names and missing imports, thanks
1154 to Anthony Baxter for the patch.
1155 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1156 remove unused buggy method.
1157 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1158 comes from shutil, not "shutils"
1159 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1160 (Arch.checkSlaveVersion): same
1161 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1163 * buildbot/process/step_twisted2.py: add some missing imports
1164 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1165 this code used to live in twisted.internet.defer
1167 2006-04-10 Brian Warner <warner@lothar.com>
1169 * buildbot/process/step.py (Mercurial): add Mercurial support
1170 * buildbot/slave/commands.py (Mercurial): same
1171 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1172 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1173 not yet tested, but 'try' support *is* covered
1174 * docs/buildbot.texinfo (Mercurial): document it
1176 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1177 some debugging messages (turned off)
1178 * buildbot/test/test_vc.py: improve debug messages
1180 2006-04-07 Brian Warner <warner@lothar.com>
1182 * buildbot/test/test_vc.py (which): define our own which() in case
1183 we can't import twisted.python.procutils, because procutils doesn't
1184 exist in Twisted-1.3
1186 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1187 of SlaveLocks for performance tests
1189 * docs/examples/twisted_master.cfg: update to match current usage
1191 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1192 password, p4 binary, pollinterval, maximum history to check.
1193 Patch from an anonymous sf.net contributor, SF#1219384.
1194 * buildbot/process/step.py (P4Sync.__init__): add username,
1195 password, and client arguments.
1196 * buildbot/slave/commands.py (P4Sync): same
1198 2006-04-05 Brian Warner <warner@lothar.com>
1200 * buildbot/process/factory.py (BuildFactory.addStep): new method
1201 to add steps to a BuildFactory. Use it instead of f.steps.append,
1202 and you can probably avoid using the s() convenience function.
1203 Patch from Neal Norwitz, sf.net #1412605.
1204 (other): update all factories to use addStep
1205 * buildbot/process/process_twisted.py: update all factories to use
1208 2006-04-03 Brian Warner <warner@lothar.com>
1210 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1211 work under windows too. Adapted from a patch by Niklaus Giger,
1212 addresses SF#1463399.
1214 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1215 spawned commands emit parseable results in english and not some
1216 other language. Patch from Niklaus Giger, SF#1463395.
1218 * README (INSTALLATION): discourage users from running unit tests on
1219 a "network drive", patch from Niklaus Giger, SF#1463394.
1221 2006-03-22 Brian Warner <warner@lothar.com>
1223 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1224 function to turn a repository-relative pathname into a (branch,
1225 branch-relative-filename) tuple. Change this function to handle
1226 the branch naming policy used by your Subversion repository.
1227 Thanks to AllMyData.com for sponsoring this work.
1229 2006-03-16 Brian Warner <warner@lothar.com>
1231 * buildbot/scripts/sample.cfg: add python-mode declaration for
1232 vim. Thanks to John Pye for the patch.
1234 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1235 command line, mention the importance of running 'crontab' as the
1236 buildmaster/buildslave user. Thanks to John Pye for the catch.
1238 2006-03-13 Brian Warner <warner@lothar.com>
1240 * buildbot/status/words.py (IRC): add an optional password=
1241 argument, which will be sent to Nickserv in an IDENTIFY message at
1242 login, to claim the nickname. freenode requires this before the
1243 bot can sent (or reply to) private messages. Thanks to Clement
1244 Stenac for the patch.
1245 * docs/buildbot.texinfo (IRC Bot): document it
1247 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1248 larger than chunkSize. Fixes SF#1349253.
1249 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1250 (Log.testConsumer): update to match new internal chunking behavior
1252 2006-03-12 Brian Warner <warner@lothar.com>
1254 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1256 * buildbot/test/test_maildir.py (MaildirTest): rename the
1257 'timeout' method, as it collides with trial's internals
1259 * buildbot/scripts/runner.py: add 'buildbot restart' command
1260 (stop): don't sys.exit() out of here, otherwise restart can't work
1261 * docs/buildbot.texinfo (Shutdown): document it
1263 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1264 * buildbot/status/html.py (Waterfall.__init__): same
1265 * buildbot/process/builder.py (Builder.startBuild): same
1266 * buildbot/process/base.py (BuildRequest): same
1267 * buildbot/sourcestamp.py (SourceStamp): same
1268 * buildbot/scheduler.py (Nightly): same
1270 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1272 * docs/buildbot.texinfo: same
1274 2006-02-17 Brian Warner <warner@lothar.com>
1276 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1277 * docs/buildbot.texinfo: set version number to match
1278 * NEWS: update for 0.7.2
1280 2006-02-16 Brian Warner <warner@lothar.com>
1282 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1284 2006-02-09 Brian Warner <warner@lothar.com>
1286 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1287 add text to explain per-build branch parameters
1288 * NEWS: mention --umask
1290 2006-02-08 Brian Warner <warner@lothar.com>
1292 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1294 (SlaveOptions.optParameters): add --umask, to make it possible to
1295 make buildslave-generated files (including build products) be
1298 * buildbot/slave/bot.py (BuildSlave.startService): same
1300 2006-01-23 Brian Warner <warner@lothar.com>
1302 * buildbot/status/builder.py: urllib.quote() all URLs that include
1303 Builder names, so that builders can include characters like '/'
1304 and ' ' without completely breaking the resulting HTML. Thanks to
1305 Kevin Turner for the patch.
1306 * buildbot/status/html.py: same
1307 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1309 * NEWS: update in preparation for upcoming release
1311 2006-01-18 Brian Warner <warner@lothar.com>
1313 * docs/examples/twisted_master.cfg: update to match the Twisted
1314 buildbot: remove python2.2, switch to exarkun's buildslaves,
1315 disable the .deb builder until we figure out how to build twisted
1316 .debs from SVN, add some ktrace debugging to the OS-X build
1317 process and remove the qt build, remove threadless builders,
1318 change freebsd builder to use landonf's buildslave.
1320 2006-01-12 Brian Warner <warner@lothar.com>
1322 * buildbot/master.py (Manhole.__init__): let port= be a strports
1323 specification string, but handle a regular int for backwards
1324 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1325 used in master.cfg to limit connections to just the local host.
1326 (BuildMaster.loadConfig): same for c['slavePortnum']
1327 * buildbot/scheduler.py (Try_Userpass.__init__): same
1328 * buildbot/status/client.py (PBListener.__init__): same
1329 * buildbot/status/html.py (Waterfall.__init__): same, for both
1330 http_port and distrib_port. Include backwards-compatibility checks
1331 so distrib_port can be a filename string and still mean unix:/foo
1332 * docs/buildbot.texinfo (Setting the slaveport): document it
1333 (Debug options): same
1334 (HTML Waterfall): same
1337 * buildbot/test/test_config.py (ConfigTest): test it
1339 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1340 slaveport's disownServiceParent deferred to fire before opening
1341 the new one. Fixes an annoying bug in the unit tests.
1343 2006-01-03 Brian Warner <warner@lothar.com>
1345 * buildbot/master.py (BuildMaster): remove the .schedulers
1346 attribute, replacing it with an allSchedulers() method that looks
1347 for all IService children that implement IScheduler. Having only
1348 one parent/child relationship means fewer opportunities for bugs.
1349 (BuildMaster.allSchedulers): new method
1350 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1351 also fix ugly bug that caused any config-file reload to
1352 half-forget about the earlier Schedulers, causing an exception
1353 when a Change arrived and was handed to a half-connected
1354 Scheduler. The exception was in scheduler.py line 54ish:
1355 self.parent.submitBuildSet(bs)
1356 exceptions.AttributeError: 'NoneType' object has no attribute
1358 (BuildMaster.addChange): update to use allSchedulers()
1360 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1361 to work properly with twisted-1.3.0, where you must explicitly
1362 include the __implements__ from parent classes
1363 (BaseScheduler.__repr__): make it easier to distinguish distinct
1365 (BaseUpstreamScheduler.__implements__): same
1367 * buildbot/status/builder.py (Status.getSchedulers): update to
1369 * buildbot/test/test_run.py (Run.testMaster): same
1370 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1371 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1372 make sure Scheduler instances are left alone when an identical
1373 config file is reloaded
1374 (ConfigElements.testSchedulers): make sure Schedulers are properly
1377 * Makefile (TRIALARGS): my local default Twisted version is now
1378 2.1.0, update the trial arguments accordingly
1380 2005-12-22 Brian Warner <warner@lothar.com>
1382 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1385 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1386 addChange in the parent class, although I suspect this should be
1387 fixed better in the future.
1389 2005-11-26 Brian Warner <warner@lothar.com>
1391 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1392 explode when branch==None, thanks to Kevin Turner for the catch
1393 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1396 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1398 * docs/buildbot.texinfo: same
1400 2005-11-26 Brian Warner <warner@lothar.com>
1402 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1403 * docs/buildbot.texinfo: set version number to match
1405 2005-11-26 Brian Warner <warner@lothar.com>
1407 * NEWS: update for 0.7.1
1409 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1410 sure that unsubscribe works even if we never sent an ETA update.
1411 Also, don't explode on duplicate unsubscribe.
1412 (BuildStepStatus.addLog): make the convenience "return self"-added
1413 watcher automatically unsubscribe when the Step finishes.
1414 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1415 (BuildStatus.stepStarted): same auto-unsubscribe
1416 (BuilderStatus.buildStarted): same auto-unsubscribe
1418 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1420 (IStatusReceiver.stepStarted): same
1421 (IStatusReceiver.logStarted): same
1423 * buildbot/test/test_run.py (Status): move the Status test..
1424 * buildbot/test/test_status.py (Subscription): .. to here
1426 2005-11-25 Brian Warner <warner@lothar.com>
1428 * NEWS: more updates
1430 * buildbot/locks.py: fix the problem in which loading a master.cfg
1431 file that changes some Builders (but not all of them) can result
1432 in having multiple copies of the same Lock. Now, the real Locks
1433 are kept in a table inside the BotMaster, and the Builders/Steps
1434 use "LockIDs", which are still instances of MasterLock and
1435 SlaveLock. The real Locks are instances of the new RealMasterLock
1436 and RealSlaveLock classes.
1437 * buildbot/master.py (BotMaster.getLockByID): new method to
1438 convert LockIDs into real Locks.
1439 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1440 into real Locks before building
1441 * buildbot/process/step.py (BuildStep.startStep): same
1442 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1443 exercises the problem
1446 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1447 what Schedulers are available
1449 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1450 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1451 'cron'-style build scheduling at certain times of day, week,
1453 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1455 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1456 handling: treat self.fileIsImportant more as an attribute that
1457 contains a callable than as a method. If the attribute is None,
1458 don't call it and assume all filenames are important. It is still
1459 possible to provide a fileIsImportant method in a subclass,
1461 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1463 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1464 test using AnyBranchScheduler with fileIsImportant=None
1466 2005-11-24 Brian Warner <warner@lothar.com>
1468 * buildbot/test/test_config.py (StartService): don't claim a fixed
1469 port number, instead set slavePort=0 on the first pass, figure out
1470 what port was allocated, then switch to a config file that uses
1473 * buildbot/master.py (BuildMaster.loadConfig): close the old
1474 slaveport before opening the new one, because unit tests might
1475 replace slavePort=0 with the same allocated portnumber, and if we
1476 don't wait for the old port to close first, we get a "port already
1477 in use" error. There is a tiny race condition here, but the only
1478 threat is from other programs that bind (statically) to the same
1479 port number we happened to be allocated, and only if those
1480 programs use SO_REUSEADDR, and only if they get control in between
1483 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1485 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1486 deleted ChangeSources before adding any new ones
1487 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1488 compare_attrs, to make sure that a config-file reload does not
1489 unnecessarily replace an unmodified ChangeSource instance
1490 * buildbot/test/test_config.py (ConfigTest.testSources): update
1492 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1493 mean "don't build anything", and add a warning if it gets used
1494 because it isn't actually useful.
1496 * contrib/svn_buildbot.py: update example usage to match the port
1497 number that gets used by the PBChangeSource
1498 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1500 2005-11-22 Brian Warner <warner@lothar.com>
1502 * NEWS: start collecting items for next release
1504 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1505 revisions are strings
1506 (P4Sync.computeSourceRevision): same
1508 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1509 to the Buildbot's overall status page
1510 (StatusResourceBuilder.body): same
1512 2005-11-15 Brian Warner <warner@lothar.com>
1514 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1515 config-file loading, specifically to make sure old StatusTargets
1516 are finished shutting down before new ones start up (thus
1517 resolving a bug in which changing the Waterfall object would fail
1518 because both new and old instances were claiming the same
1519 listening port). Also load new Schedulers after all the new
1520 Builders are set up, in case they fire off a new build right away.
1521 * buildbot/test/test_config.py (StartService): test it
1523 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1524 the branch name to the mail body
1526 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1527 Without it, a config-file reload fails to update an existing
1529 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1530 username/passwd to compare_attrs, for the same reason
1531 * buildbot/status/html.py (Waterfall): add favicon to
1532 compare_attrs, same reason
1534 2005-11-05 Brian Warner <warner@lothar.com>
1536 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1537 baserev before stuffing it in the jobfile. This resolves problems
1538 under SVN (and probably Arch) where revisions are expressed as
1539 numbers. I'm inclined to use string-based revisions everywhere in
1540 the future, but this fix should be safe for now. Thanks to Steven
1541 Walter for the patch.
1543 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1544 binary mode when opening pickle files, to make windows work
1545 better. Thanks to Dobes Vandermeer for the catch.
1546 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1547 (BuilderStatus.getBuildByNumber): same
1548 (Status.builderAdded): same
1549 * buildbot/master.py (BuildMaster.loadChanges): same
1551 * buildbot/util.py (Swappable): delete unused leftover code
1553 * buildbot/process/step.py (SVN): when building on a non-default
1554 branch, add the word "[branch]" to the VC step's description, so
1555 it is obvious that we're not building the usual stuff. Likewise,
1556 when we are building a specific revision, add the text "rNNN" to
1557 indicate what that revision number is. Thanks to Brad Hards and
1558 Nathaniel Smith for the suggestion.
1559 (Darcs.startVC): same
1560 (Arch.startVC): same
1561 (Bazaar.startVC): same
1563 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1564 typo, caught by Mark Dillavou, closes SF#1216636.
1566 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1567 about a test to add some day
1569 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1570 the 'full-2.3' build, and the 'reactors' build is now run under
1571 python-2.4 because the buildslave no longer has gtk/etc bindings
1572 for earlier versions.
1574 2005-11-03 Brian Warner <warner@lothar.com>
1576 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1577 method, takes an IBuildStatus and rebuilds it. It might make more
1578 sense to add this to IBuildControl instead, but that instance goes
1579 away completely once the build has finished, and resubmitting
1580 builds can take place weeks later.
1581 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1582 * buildbot/status/html.py (StatusResourceBuild): also stash an
1583 IBuilderControl so we can use resubmitBuild.
1584 (StatusResourceBuild.body): render "resubmit" button if we can.
1585 Also add hrefs for each BuildStep
1586 (StatusResourceBuild.rebuild): add action for "resubmit" button
1587 (StatusResourceBuilder.getChild): give it an IBuilderControl
1589 * buildbot/status/builder.py (Status.getURLForThing): change the
1590 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1591 that live as targets of buttons like "stop" and "rebuild" can't
1593 * buildbot/status/builder.py (Status.getURLForThing): same
1594 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1595 (StepBox.getBox): same
1596 * buildbot/test/test_web.py (GetURL): same
1599 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1600 exclusivity checks after Source.__init__ upcall, so misspelled
1601 arguments will be reported more usefully
1602 (Darcs.__init__): same
1604 2005-10-29 Brian Warner <warner@lothar.com>
1606 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1607 builder. Move the Try scheduler off to a separate port.
1609 2005-10-27 Brian Warner <warner@lothar.com>
1611 * buildbot/clients/gtkPanes.py
1612 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1613 to cause the app to crash, now they don't.
1615 * buildbot/clients/debug.py: display the buildmaster's location
1616 in the window's title bar
1618 2005-10-26 Brian Warner <warner@lothar.com>
1620 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
1621 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
1622 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
1624 * buildbot/status/html.py (td): put a single non-breaking space
1625 inside otherwise empty <td> elements, as a workaround for buggy
1626 browsers which would optimize them away (along with any associated
1627 styles, like the kind that create the waterfall grid borders).
1628 Patch from Frerich Raabe.
1630 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
1631 argv-list as an argument, defaulting to ["-to"], which is
1632 appropriate for the Trial that comes with Twisted-2.1.0 and
1633 earlier. The Trial in current Twisted SVN wants
1634 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
1635 defaults to an empty list.
1636 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
1637 match it, now that trialMode= is a list instead of a single string
1639 * buildbot/__init__.py (version): bump to 0.7.0+ while between
1641 * docs/buildbot.texinfo: same
1643 2005-10-24 Brian Warner <warner@lothar.com>
1645 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
1646 * docs/buildbot.texinfo: set version number to match
1648 2005-10-24 Brian Warner <warner@lothar.com>
1650 * README: update for 0.7.0
1652 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
1654 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
1655 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
1656 send the branch= argument unless the user really provided one, to
1657 retain compatibility with older buildmasters that don't accept
1659 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
1662 * docs/buildbot.texinfo: update lots of stuff
1664 * buildbot/scripts/runner.py (sendchange): add a --branch argument
1665 to the 'buildbot sendchange' command
1666 * buildbot/clients/sendchange.py (Sender.send): same
1667 * buildbot/changes/pb.py (ChangePerspective): same
1668 * buildbot/test/test_changes.py (Sender.testSender): test it
1670 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
1671 'default_branch' argument names to 'baseURL' and 'defaultBranch',
1672 for consistency with other BuildStep arguments that use camelCase.
1673 Well, at least more of them use camelCase (like flunkOnWarnings)
1674 than don't.. I wish I'd picked one style and stuck with it
1675 earlier. Annoying, but it's best done before the release, since
1676 these arguments didn't exist at all in 0.6.6 .
1678 * buildbot/test/test_vc.py (SVN.testCheckout): same
1679 (Darcs.testPatch): same
1680 * docs/buildbot.texinfo (SVN): document the change
1681 (Darcs): same, add some build-on-branch docs
1682 * docs/examples/twisted_master.cfg: match change
1684 * buildbot/process/step.py (BuildStep): rename
1685 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
1686 how it is normally used.
1687 * buildbot/test/test_steps.py (Version.checkCompare): same
1689 * buildbot/process/step.py (CVS.startVC): refuse to build
1690 update/copy -style builds on a non-default branch with an old
1691 buildslave (<=0.6.6) that doesn't know how to do it properly. The
1692 concern is that it will do a VC 'update' in an existing tree when
1693 it is supposed to be switching branches (and therefore clobbering
1694 the tree to do a full checkout), thus building the wrong source.
1695 This used to be a warning, but I think the confusion it is likely
1696 to cause warrants making it an error.
1697 (SVN.startVC): same, also make mode=export on old slaves an error
1698 (Darcs.startVC): same
1699 (Git.startVC): improve error message for non-Git-enabled slaves
1700 (Arch.checkSlaveVersion): same. continue to emit a warning when a
1701 specific revision is built on a slave that doesn't pay attention
1702 to args['revision'], because for slowly-changing trees it will
1703 probably do the right thing, and because we have no way to tell
1704 whether we're asking it to build the most recent version or not.
1705 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
1707 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
1708 that 'master' is in host:portnum format, to catch errors sooner
1710 2005-10-23 Brian Warner <warner@lothar.com>
1712 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
1713 when creating the list of warning messages, include the line
1714 immediately after each WARNING: line, since that's usually where
1715 the file and line number wind up.
1717 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
1722 2005-10-22 Brian Warner <warner@lothar.com>
1724 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
1725 patch from Brad Hards
1726 * buildbot/status/classic.css: same
1727 * buildbot/test/test_web.py (Waterfall): match changes
1729 * buildbot/test/test_steps.py (BuildStep.setUp): set
1730 nextBuildNumber so the test passes
1731 * buildbot/test/test_status.py (MyBuilder): same
1733 * buildbot/status/html.py (StatusResourceBuild.body): revision
1734 might be numeric, so stringify it before html-escapifying it
1735 (CurrentBox.getBox): add a "waiting" state, and show a countdown
1736 timer for the upcoming build
1737 * buildbot/status/classic.css: add background-color attributes for
1738 offline/waiting/building classes
1740 * buildbot/status/builder.py (BuildStatus): derive from
1741 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
1742 the default (i.e. unknown) .slavename to "???" instead of None,
1743 since even unknown slavenames need to be printed eventually.
1744 (BuilderStatus): also derive from styles.Versioned . More
1745 importantly, determine .nextBuildNumber at creation/unpickling
1746 time by scanning the directory of saved BuildStatus instances and
1747 choosing one larger than the highest-numbered one found. This
1748 should fix the problem where random errors during upgrades cause
1749 the buildbot to forget about earlier builds. .nextBuildNumber is
1750 no longer stored in the pickle.
1751 (Status.builderAdded): if we can't unpickle the BuilderStatus,
1752 at least log the error. Also call Builder.determineNextBuildNumber
1753 once the basedir is set.
1755 * buildbot/master.py (BuildMaster.loadChanges): do
1756 styles.doUpgrade afterwards, in case I decide to make Changes
1757 derived from styles.Versioned some day and forget to make this
1761 * buildbot/test/test_runner.py (Options.testForceOptions): skip
1762 when running under older pythons (<2.3) in which the shlex module
1763 doesn't have a 'split' function.
1765 * buildbot/process/step.py (ShellCommand.start): make
1766 errorMessages= be a list of strings to stuff in the log before the
1767 command actually starts. This makes it easier to flag multiple
1768 warning messages, e.g. when the Source steps have to deal with an
1770 (CVS.startVC): handle slaves that don't handle multiple branches
1771 by switching into 'clobber' mode
1772 (SVN.startVC): same. Also reject branches without base_url
1773 (Darcs.startVC): same. Also reject revision= in older slaves
1774 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
1775 (Bazaar.startVC): same, and test for baz separately than for arch
1777 * buildbot/slave/commands.py (cvs_ver): document new features
1779 * buildbot/process/step.py (BuildStep.slaveVersion): document it
1780 (BuildStep.slaveVersionNewEnough): more useful utility method
1781 * buildbot/test/test_steps.py (Version): start testing it
1783 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
1784 the 'force' command requires python2.3, for the shlex.split method
1786 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
1787 since we don't use it anymore. The Twisted buildbot uses a
1790 2005-10-21 Brian Warner <warner@lothar.com>
1792 * buildbot/process/process_twisted.py: rework all BuildFactory
1793 classes to take a 'source' step as an argument, instead of
1794 building up the SVN instance in the factory.
1795 * docs/examples/twisted_master.cfg: enable build-on-branch by
1796 providing a base_url and default_branch
1798 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
1799 control over --branch and --revision, not that they are always
1801 * buildbot/status/html.py (StatusResourceBuilder.force): same
1802 (StatusResourceBuild.body): display SourceStamp components
1804 * buildbot/scripts/runner.py (ForceOptions): option parser for the
1805 IRC 'force' command, so it can be shared with an eventual
1806 command-line-tool 'buildbot force' mode.
1807 * buildbot/test/test_runner.py (Options.testForceOptions): test it
1809 2005-10-20 Brian Warner <warner@lothar.com>
1811 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
1813 * docs/examples/twisted_master.cfg: update to use Schedulers
1815 * buildbot/scripts/sample.cfg: update with Schedulers
1817 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
1818 method specifically for use by HTML "force build" button and the
1819 IRC "force" command. Raises an immediate error if there are no
1821 (IBuilderControl.requestBuild): make this just submit a build, not
1822 try to check for existing slaves or set up any when-finished
1823 Deferreds or anything.
1824 * buildbot/process/builder.py (BuilderControl): same
1825 * buildbot/status/html.py (StatusResourceBuilder.force): same
1826 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
1827 * buildbot/test/test_slaves.py: same
1828 * buildbot/test/test_web.py: same
1830 2005-10-19 Brian Warner <warner@lothar.com>
1832 * docs/examples/twisted_master.cfg: re-sync with reality: bring
1833 back python2.2 tests, turn off OS-X threadedselect-reactor tests
1835 2005-10-18 Brian Warner <warner@lothar.com>
1837 * buildbot/status/html.py: provide 'status' argument to most
1838 StatusResourceFOO objects
1839 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
1840 and Logfiles" section to make the Build page into a more-or-less
1841 comprehensive source of status information about the build
1843 * buildbot/status/mail.py (MailNotifier): include the Build's URL
1844 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
1846 2005-10-17 Brian Warner <warner@lothar.com>
1848 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
1849 arguments to accomodate Twisted >=2.1.0 . I will have to figure
1850 out what to do about other projects: the correct options for
1851 recent Twisteds will not work for older ones.
1853 2005-10-15 Brian Warner <warner@lothar.com>
1855 * buildbot/status/builder.py (Status.getURLForThing): add method
1856 to provide a URL for arbitrary IStatusFoo objects. The idea is to
1857 use this in email/IRC status clients to make them more useful, by
1858 providing the end user with hints on where to learn more about the
1859 object being reported on.
1860 * buildbot/test/test_web.py (GetURL): tests for it
1862 2005-10-14 Brian Warner <warner@lothar.com>
1864 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
1865 fix bug resulting from deferredResult changes
1867 2005-10-13 Brian Warner <warner@lothar.com>
1869 * buildbot/test/test_changes.py: remove use of deferredResult
1870 * buildbot/test/test_config.py: same
1871 * buildbot/test/test_control.py: same
1872 * buildbot/test/test_status.py: same
1873 * buildbot/test/test_vc.py: this is the only remaining use, since
1874 it gets used at module level. This needs to be replaced by some
1875 sort of class-level run-once routine.
1877 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
1879 * lots: implement multiple slaves per Builder, which means multiple
1880 current builds per Builder. Some highlights:
1881 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
1882 of (state,currentBuilds) instead of (state,currentBuild)
1883 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
1884 (IBuildStatus.getSlavename): new method, so you can tell which
1885 slave got used. This only gets set when the build completes.
1886 (IBuildRequestStatus.getBuilds): new method
1888 * buildbot/process/builder.py (SlaveBuilder): add a .state
1889 attribute to track things like ATTACHING and IDLE and BUILDING,
1891 (Builder): .. the .slaves attribute here, which has been turned
1892 into a simple list of available slaves. Added a separate
1893 attaching_slaves list to track ones that are not yet ready for
1895 (Builder.fireTestEvent): put off the test-event callback for a
1896 reactor turn, to make tests a bit more consistent.
1897 (Ping): cleaned up the slaveping a bit, now it disconnects if the
1898 ping fails due to an exception. This needs work, I'm worried that
1899 a code error could lead to a constantly re-connecting slave.
1900 Especially since I'm trying to move to a distinct remote_ping
1901 method, separate from the remote_print that we currently use.
1902 (BuilderControl.requestBuild): return a convenience Deferred that
1903 provides an IBuildStatus when the build finishes.
1904 (BuilderControl.ping): ping all connected slaves, only return True
1905 if they all respond.
1907 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
1908 reconnect when we shut down.
1910 * buildbot/status/builder.py: implement new methods, convert
1911 one-build-at-a-time methods to handle multiple builds
1912 * buildbot/status/*.py: do the same in all default status targets
1913 * buildbot/status/html.py: report the build's slavename in the
1914 per-Build page, report all buildslaves on the per-Builder page
1916 * buildbot/test/test_run.py: update/create tests
1917 * buildbot/test/test_slaves.py: same
1918 * buildbot/test/test_scheduler.py: remove stale test
1920 * docs/buildbot.texinfo: document the new builder-specification
1921 'slavenames' parameter
1923 2005-10-12 Brian Warner <warner@lothar.com>
1925 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
1926 report failure correctly, causing Dependent builds to run when
1927 they shouldn't have.
1928 * buildbot/status/builder.py (BuildSetStatus): same
1929 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
1930 (Set.testSuccess): test the both-pass case too
1931 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
1932 fix this test: it was ending too early, masking the failure before
1933 (Logger): specialized StatusReceiver to make sure the dependent
1934 builds aren't even started, much less completed.
1936 2005-10-07 Brian Warner <warner@lothar.com>
1938 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
1939 bot.SlaveBuilder being disowned in the middle of a build
1941 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
1942 this inherit from StatusReceiver. Also upcall in __init__. This
1943 fixes the embarrasing crash when the new buildSetSubmitted method
1944 is invoked and Waterfall/etc don't implement their own.
1945 * buildbot/test/test_run.py: add a TODO note about a test to catch
1946 just this sort of thing.
1948 * buildbot/process/builder.py (Builder.attached): remove the
1949 already-attached warning, this situation is normal. Add some
1950 comments explaining it.
1952 2005-10-02 Brian Warner <warner@lothar.com>
1954 * buildbot/changes/maildir.py (Maildir.start): Tolerate
1955 OverflowError when setting up dnotify, because some 64-bit systems
1956 have problems with signed-vs-unsigned constants and trip up on the
1957 DN_MULTISHOT flag. Patch from Brad Hards.
1959 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
1961 * buildbot/process/step.py (BuildStep, ShellCommand): Add
1962 progressMetrics, description, descriptionDone to the 'parms' list,
1963 and make use the 'parms' list from the implementation class
1964 instead of only BuildStep to initialize the parameters. This
1965 allows buildbot.process.factory.s() to initialize all the parms,
1966 not just those defined in directly by BuildStep.
1968 2005-09-03 Brian Warner <warner@lothar.com>
1970 * NEWS: start adding items for the next release
1972 * docs/examples/twisted_master.cfg: (sync with reality) turn off
1973 python2.2 tests, change 'Quick' builder to only use python2.3
1975 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
1977 * buildbot/status/html.py (StatusResourceBuilder.body): only show
1978 the "Ping Builder" button if the build control is available; the
1979 user sees an exception otherwise
1981 * docs/buildbot.texinfo (PBChangeSource): fix a typo
1983 2005-09-01 Brian Warner <warner@lothar.com>
1985 * buildbot/interfaces.py (IBuilderStatus.getState): update
1986 signature, point out that 'build' can be None
1987 (IBuildStatus.getETA): point out ETA can be none
1989 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
1991 * buildbot/status/words.py (IrcStatusBot.emit_status): same
1993 2005-08-31 Brian Warner <warner@lothar.com>
1995 * buildbot/status/base.py (StatusReceiver.builderChangedState):
1996 update to match correct signature: removed 'eta' argument
1997 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
1999 2005-08-30 Brian Warner <warner@lothar.com>
2001 * buildbot/status/builder.py (LogFile): remove the assertion that
2002 blows up when you try to overwrite an existing logfile, instead
2003 just emit a warning. This case gets hit when the buildmaster is
2004 killed and doesn't get a chance to write out the serialized
2005 BuilderStatus object, so the .nextBuildNumber attribute gets out
2008 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2009 the 'buildbot sendchange' arguments, for the Darcs context file
2010 * docs/buildbot.texinfo (sendchange): document it
2012 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2013 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2014 (IStatus.getSchedulers): new method
2015 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2016 (Status.getSchedulers): implement
2017 * buildbot/process/builder.py (Builder): maintain
2018 BuilderStatus.pendingBuilds
2019 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2020 (TryBase.addChange): Try schedulers should ignore Changes
2022 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2023 for 'try' on CVS/SVN
2024 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2026 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2027 report status properly.
2028 (Try.createJob): implement unique buildset IDs
2030 * buildbot/status/client.py (StatusClientPerspective): add a
2031 perspective_getBuildSets method for the benefit of jobdir-style
2033 * docs/buildbot.texinfo (try): more docs
2034 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2037 2005-08-18 Brian Warner <warner@lothar.com>
2039 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2040 actually work. It's functional but still kind of clunky. Also, it
2041 only works with the pb-style.. needs to be made to work with the
2044 * buildbot/status/client.py (RemoteBuildSet): new class
2045 (RemoteBuildRequest): same
2046 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2047 object, not the internal BuildStatus object.
2048 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2049 outside of the usual buildStarted() return value.
2050 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2052 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2053 (Try_Userpass_Perspective.perspective_try): return a remotely
2054 usable BuildSetStatus object
2056 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2057 isStarted()/waitUntilStarted()
2059 2005-08-16 Brian Warner <warner@lothar.com>
2061 * buildbot/status/builder.py: implement IBuildSetStatus and
2062 IBuildRequestStatus, wire them into place.
2063 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2064 methods into the BuildSetStatus object.
2065 * buildbot/interfaces.py: same
2066 (IStatus.getBuildSets): new method to get pending BuildSets
2067 (IStatusReceiver.buildsetSubmitted): new method which hears about
2069 * buildbot/master.py (BuildMaster.submitBuildSet): same
2070 * buildbot/process/base.py (BuildRequest): same, replace
2071 waitUntilStarted with subscribe/unsubscribe
2072 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2073 subscribe instead of waitUntilStarted
2074 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2076 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2078 * buildbot/test/test_buildreq.py: update for new code
2079 * buildbot/test/test_control.py (Force.testRequest): same
2082 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2083 for Darcs to not use the tempfile module, so it works under
2084 python-2.2 too. We really didn't need the full cleverness of that
2085 module, since the slave has exclusive control of its own builddir.
2087 2005-08-15 Brian Warner <warner@lothar.com>
2089 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2090 for CVS trees. It doesn't work for non-trunk branches,
2092 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2095 * Makefile: make it easier to test against python2.2
2097 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2098 tearDown2, so things like Arch can unregister archives as they're
2099 shutting down. The previous subclass-override-tearDown technique
2100 resulted in a nested maybeWait() and test failures under
2103 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2104 where we can (Arch), add a branch= argument to set the branch used
2106 (BazExtractor): extract the branch too
2107 (TlaExtractor): same
2108 * buildbot/scripts/runner.py (TryOptions): add --branch
2109 * docs/buildbot.texinfo (try): document --branch/try_branch
2111 * buildbot/slave/commands.py (Darcs): implement get-revision for
2112 Darcs, so that 'try' will work. This requires the tempfile module
2115 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2116 of revisions, branches, and 'try' in the process.
2118 2005-08-11 Brian Warner <warner@lothar.com>
2120 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2121 this, it got broken at some point in the last few releases
2122 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2123 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2124 specifically the removal of ETA information from the tuple
2126 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2129 * docs/buildbot.texinfo (try): document both --builder and
2130 'try_builders' in .buildbot/options
2131 * buildbot/scripts/runner.py (TryOptions): add --builder,
2132 accumulate the values into opts['builders']
2133 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2134 * buildbot/test/test_runner.py (Try): add some quick tests to make
2135 sure 'buildbot try --options' and .buildbot/options get parsed
2136 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2137 use --builder control
2139 * docs/buildbot.texinfo (try): add --port argument to PB style
2141 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2142 actual SourceStamp. Still need to extract a branch name, somehow.
2143 (Try): finish implementing the try client side, still need a UI
2144 for specifying which builders to use
2145 (Try.getopt): factor our options/config-file reading
2146 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2148 * buildbot/test/test_vc.py: match SourceStampExtractor change
2150 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2151 causes the twisted log to be sent to stderr
2153 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2155 2005-08-10 Brian Warner <warner@lothar.com>
2157 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2158 style is 90% done, still missing status reporting or waiting for
2159 the buildsets to finish, and it is completely untested.
2161 * buildbot/trybuild.py: delete file, move contents to ..
2162 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2163 * buildbot/test/test_vc.py: match the move
2165 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2166 of the TryScheduler, no buildsetID or status-tracking support yet
2167 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2169 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2170 possible to set the basedir after __init__ time, so it is easier
2171 to use as a Service-child of the BuildMaster instance
2173 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2174 that delivers messages to its Service parent instead of requiring
2175 a subclass to be useful. This turns out to be much easier to build
2178 * buildbot/scripts/tryclient.py (createJob): utility code to
2179 create jobfiles, will eventually be used by 'buildbot try'
2181 2005-08-08 Brian Warner <warner@lothar.com>
2183 * docs/buildbot.texinfo (try): add docs on the
2184 as-yet-unimplemented Try scheduler
2186 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2187 * buildbot/test/test_scheduler.py: .. here
2188 (Scheduling.testTryJobdir): add placeholder test for 'try'
2190 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2191 addEntry merging (>=chunkSize) behavior
2192 (Log.testConsumer): update to handle new callLater(0) behavior
2194 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2195 both the MAX_LENGTH bugfix and the resumeProducing hang.
2197 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2198 put off the actual resumeProducing for a moment with
2199 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2200 causes large logfiles to hang midway through.
2202 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2203 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2204 and to improve memory usage when streaming the file out to a web
2206 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2207 make this work cleanly
2209 2005-08-03 Brian Warner <warner@lothar.com>
2211 * buildbot/trybuild.py: new file for 'try' utilities
2212 (getSourceStamp): run in a tree, find out the baserev+patch
2213 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2214 implemented for SVN and Darcs, still working on Arch. I don't know
2215 how to make CVS work yet.
2217 * docs/buildbot.texinfo: document the 'buildbot' command-line
2218 tool, including the not-yet-implemented 'try' feature, and the
2219 in-flux .buildbot/ options directory.
2221 2005-07-20 Brian Warner <warner@lothar.com>
2223 * buildbot/locks.py: added temporary id() numbers to Lock
2224 descriptions, to track down a not-really-sharing-the-Lock bug
2226 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2228 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2229 needed for python2.2 compatibility
2230 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2231 are from the __future__
2233 2005-07-19 Brian Warner <warner@lothar.com>
2235 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2236 message when schedulers use unknown builders
2238 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2239 SlaveLock('name') and MasterLock('name') are distinct
2241 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2242 c['schedulers'] in such a way that we can actually accept
2244 * buildbot/test/test_config.py: check it
2246 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2247 utility method to *all* the Schedulers
2248 (Periodic.listBuilderNames): same
2250 * docs/buildbot.texinfo (Interlocks): update chapter to match
2253 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2254 to make sure that c['sources'], c['schedulers'], and c['status']
2255 are all lists of the appropriate objects, and that the Schedulers
2256 all point to real Builders
2257 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2258 'listBuilderNames' utility method to support this
2259 * buildbot/scheduler.py: implement the utility method
2260 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2262 * docs/buildbot.texinfo: add some @cindex entries
2264 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2265 if it wasn't already set: most tla commands will fail unless one
2267 (Arch.createRepository): and disable bazaar's revision cache, since
2268 they cause test failures (the multiple repositories we create all
2269 interfere with each other through the cache)
2271 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2272 bring it properly up to date with twisted-2.0 test guidelines
2274 * buildbot/master.py (BuildMaster): remove references to old
2275 'interlock' module, this caused a bunch of post-merge test
2277 * buildbot/test/test_config.py: same
2278 * buildbot/process/base.py (Build): same
2280 * buildbot/test/test_slaves.py: stubs for new test case
2282 * buildbot/scheduler.py: add test-case-name tag
2283 * buildbot/test/test_buildreq.py: same
2285 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2286 unnecessary init code
2287 (Bot.remote_setBuilderList): match it
2289 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2291 * buildbot/changes/mail.py (parseSyncmail): update comment
2293 * buildbot/test/test_slavecommand.py: disable Shell tests on
2294 platforms that don't suport IReactorProcess
2296 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2297 all places where we open logfiles. It causes OS-X to open the file
2298 in some weird mode that that prevents us from mixing reads and
2299 writes to the same filehandle, which we depend upon to implement
2300 _generateChunks properly. This change doesn't appear to break
2301 win32, on which "b" and "t" are treated differently but a missing
2302 flag seems to be interpreted as "t".
2304 2005-07-18 Brian Warner <warner@lothar.com>
2306 * buildbot/slave/commands.py (ShellCommand): overhaul
2307 error-handling code, to try and make timeout/interrupt work
2308 properly, and make win32 happier
2309 * buildbot/test/test_slavecommand.py: clean up, stop using
2310 reactor.iterate, add tests for timeout and interrupt
2311 * buildbot/test/sleep.py: utility for a new timeout test
2313 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2314 code from the local-usebranches branch
2316 2005-07-17 Brian Warner <warner@lothar.com>
2318 * buildbot/process/process_twisted.py
2319 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2320 minutes, to match the other twisted BuildFactories, and don't
2321 excuse failures in c/qt/win32 reactors any more.
2323 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2324 'freebsd' builders, since the buildslaves have been unavailable
2327 2005-07-13 Brian Warner <warner@lothar.com>
2329 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2330 build-on-branch feature
2332 * buildbot/process/step.py (Darcs.__init__): add base_url and
2333 default_branch arguments, just like SVN
2334 (Arch.__init__): note that the version= argument is really the
2337 * buildbot/slave/commands.py (SourceBase): keep track of the
2338 repository+branch that was used for the last checkout in
2339 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2340 match, we clobber the directory and perform a fresh checkout
2341 rather than trying to do an in-place update. This should protect
2342 us against trying to get to branch B by doing an update in a tree
2343 obtained from branch A.
2344 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2345 (SVN.setup): same, just the svnurl
2346 (Darcs.setup): same, just the repourl
2347 (Arch.setup): same, arch coordinates (url), version, and
2348 buildconfig. Also pull the buildconfig from the args dictionary,
2349 which we weren't doing before, so the build-config was effectively
2351 (Arch.sourcedirIsUpdateable): don't try to update when we're
2352 moving to a specific revision: arch can't go backwards, so it is
2353 safer to just clobber the tree and checkout a new one at the
2355 (Bazaar.setup): same sourcedata as Arch
2357 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2358 use maybeWait, to work with twisted-1.3.0 and twcompat
2359 (Dependencies.testRun_Pass): same
2361 * buildbot/test/test_vc.py: rearrange, cleanup
2363 * buildbot/twcompat.py: add defer.waitForDeferred and
2364 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2365 can work under twisted-1.3.0 .
2367 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2368 now created at setUp time. This increases the runtime of the test
2369 suite considerably (from 91 seconds to 151), but it removes the
2370 need for an offline tarball, which should solve a problem I've
2371 seen where the test host has a different version of svn than the
2372 tarball build host. The new code also validates that mode=update
2373 really picks up recent commits. This approach will also make it
2374 easier to test out branches, because the code which creates the VC
2375 branches is next to the code which uses them. It will also make it
2376 possible to test some change-notification hooks, by actually
2377 performing a VC commit and watching to see the ChangeSource get
2380 2005-07-12 Brian Warner <warner@lothar.com>
2382 * docs/buildbot.texinfo (SVN): add branches example
2383 * docs/Makefile (buildbot.ps): add target for postscript manual
2385 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2386 * buildbot/test/test_locks.py: same
2388 * buildbot/process/step.py (Darcs): comment about default branches
2390 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2391 c['interlocks'] in the config file, complain if it is present.
2392 Scan all locks in c['builders'] to make sure the Locks they use
2394 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2395 add some tests to check for non-uniquely-named Locks
2396 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2397 since the unique-Lock validation code requires it now
2399 * buildbot/locks.py: fix test-case-name
2401 * buildbot/interlock.py: remove old file
2403 2005-07-11 Brian Warner <warner@lothar.com>
2405 * buildbot/test/test_interlock.py: rename to..
2406 * buildbot/test/test_locks.py: .. something shorter
2408 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2409 versions (after 2.0.1) changed internet.TCPClient to shut down the
2410 connection in stopService. Change the code to handle this
2413 * buildbot/process/base.py (Build): handle whole-Build locks
2414 * buildbot/process/builder.py (Builder.compareToSetup): same
2415 * buildbot/test/test_interlock.py: make tests work
2417 * buildbot/process/step.py (BuildStep.startStep): complain if a
2418 Step tries to claim a lock that's owned by its own Build
2419 (BuildStep.releaseLocks): typo
2421 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2422 file reloads don't replace unchanged Builders
2424 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2425 rewrite to cover new Locks instead of old c['interlocks']
2426 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2430 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2431 start the master and connect the buildslave
2433 * buildbot/process/step.py (FailingDummy.done): finish with a
2434 FAILURE status rather than raising an exception
2436 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2437 stringify a BuildRequest.reason that is None
2439 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2441 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2442 allow scheduler.Dependent to work
2443 * buildbot/buildset.py (BuildSet): set .reason and .results
2445 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2446 slaves, to make the test stop hanging. It still fails, of course,
2447 because I haven't even started to implement Locks.
2449 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2451 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2452 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2453 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2454 (Dependent): new class for downstream build dependencies
2455 * buildbot/test/test_dependencies.py: tests (still failing)
2457 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2459 2005-07-07 Brian Warner <warner@lothar.com>
2461 * buildbot/test/runutils.py (RunMixin): factored this class out..
2462 * buildbot/test/test_run.py: .. from here
2463 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2464 added new buildbot.locks tests (which all hang right now)
2465 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2466 * buildbot/process/step.py: claim/release per-BuildStep locks
2468 * docs/Makefile: add 'buildbot.html' target
2470 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2471 interpreted as "HEAD", so that all VC steps can accept branch=None
2472 and have it mean the "default branch".
2474 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2476 2005-07-07 Brian Warner <warner@lothar.com>
2478 * docs/examples/twisted_master.cfg: update to match current usage
2480 * docs/buildbot.texinfo (System Architecture): comment out the
2481 image, it doesn't exist yet and just screws up the HTML manual.
2483 2005-07-05 Brian Warner <warner@lothar.com>
2485 * debian/.cvsignore: oops, missed one. Removing leftover file.
2487 2005-06-17 Brian Warner <warner@lothar.com>
2489 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2490 changed its output in 1.2.0, don't mistakenly think that the
2491 subversion we find isn't capable of supporting our tests.
2493 * debian/*: remove the debian/ directory and its contents, to make
2494 life easier for the proper Debian maintainer
2496 * Makefile (release): same
2498 2005-06-07 Brian Warner <warner@lothar.com>
2500 * everything: create a distinct SourceStamp class to replace the
2501 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2502 Changed the signature of Source.startVC to include the revision
2503 information (instead of passing it through self.args). Implement
2504 branches for SVN (now only Darcs/Git is missing support). Add more
2507 2005-06-06 Brian Warner <warner@lothar.com>
2509 * everything: rearrange build scheduling. Create a new Scheduler
2510 object (configured in c['schedulers'], which submit BuildSets to a
2511 set of Builders. Builders can now use multiple slaves. Builds can
2512 be run on alternate branches, either requested manually or driven
2513 by changes. This changed some of the Status classes. Interlocks
2514 are out of service until they've been properly split into Locks
2515 and Dependencies. treeStableTimer, isFileImportant, and
2516 periodicBuild have all been moved from the Builder to the
2518 (BuilderStatus.currentBigState): removed the 'waiting' and
2519 'interlocked' states, removed the 'ETA' argument.
2521 2005-05-24 Brian Warner <warner@lothar.com>
2523 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2524 erroneously abandons the connection (in clientConnectionFailed)
2525 for non-UserErrors, which means that if we lose the connection due
2526 to a network problem or a timeout, we'll never try to reconnect.
2527 Fix this by not upcalling to the buggy parent method. Note:
2528 twisted-2.0 fixes this, but the function only has 3 lines so it
2529 makes more sense to copy it than to try and detect the buggyness
2530 of the parent class. Fixes SF#1207588.
2532 * buildbot/changes/changes.py (Change.branch): doh! Add a
2533 class-level attribute to accomodate old Change instances that were
2534 pickled before 0.6.5 (where .branch was added for new Changes).
2535 This fixes the exception that occurs when you try to look at an
2536 old Change (through asHTML).
2538 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2541 2005-05-23 Brian Warner <warner@lothar.com>
2543 * buildbot/__init__.py (version): release 0.6.6
2545 2005-05-23 Brian Warner <warner@lothar.com>
2547 * NEWS: update for 0.6.6 release
2548 * debian/changelog: same
2550 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2551 before starting: this was done by twistd back when we spawned it,
2552 now that we're importing the pieces and running them in the
2553 current process, we have to do it ourselves. This allows
2554 master.cfg to import files from the same directory without
2555 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2556 Stichele for the catch.
2557 (Options.opt_version): Add a --version command (actually, just make
2558 the existing --version command emit Buildbot's version too)
2560 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2561 fix to make this behave like other LogFiles, this time to handle
2562 existing LogFiles on disk. (add the missing .upgrade method)
2563 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2565 2005-05-21 Brian Warner <warner@lothar.com>
2567 * buildbot/test/test_runner.py (Create.testMaster): match the
2568 rawstring change in runner.py:masterTAC
2570 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2571 TwistedWords is installed
2572 * buildbot/test/test_status.py: same, with TwistedMail
2574 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2575 some old, deprecated, and removed config keys). This should enable
2576 you to use the base buildbot functionality with Twisted-2.0.0 when
2577 you don't also have TwistedWeb and TwistedWords installed
2579 2005-05-20 Brian Warner <warner@lothar.com>
2581 * buildbot/scripts/runner.py (run): call sendchange(), not
2582 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2583 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2584 (stop): don't wait for process to die when sending SIGHUP
2585 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2586 directory name gets interpreted, which you don't want
2589 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2592 2005-05-18 Brian Warner <warner@lothar.com>
2594 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2596 2005-05-18 Brian Warner <warner@lothar.com>
2598 * README: update for 0.6.5
2599 * debian/changelog: same
2601 * buildbot/changes/changes.py: rename tag= to branch=, since
2602 that's how we're using it, and my design for the upcoming "build a
2603 specific branch" feature wants it. also, tag= was too CVS-centric
2604 * buildbot/changes/mail.py (parseSyncmail): same
2605 * buildbot/process/base.py (Build.isBranchImportant): same
2606 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2607 * docs/buildbot.texinfo (Attributes of Changes): same
2609 * NEWS: update tag=, update for upcoming release
2611 2005-05-17 Brian Warner <warner@lothar.com>
2613 * buildbot/scripts/runner.py (stop): actually poll once per
2614 second, instead of re-killing the poor daemon once per second.
2615 Sleep briefly (0.1s) before the first poll, since there's a good
2616 chance we can avoid waiting the full second if the daemon shuts
2617 down quickly. Also remove the sys.exit() at the end.
2618 (start): remove the unneighborly sys.exit()
2620 * Makefile: improve permission-setting to not kick Arch so badly
2622 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
2623 default --keepalive=600, since it doesn't hurt very much, and it's
2624 a hassle to discover that you need it.
2625 * buildbot/test/test_runner.py (Create.testSlave): test it
2627 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
2628 IRC bot about EXCEPTION
2630 * buildbot/status/client.py (PBListener): upcall more correctly
2632 * buildbot/process/base.py (Build.allStepsDone): if a step caused
2633 an exception mark the overall build with EXCEPTION, not SUCCESS
2635 * buildbot/scripts/runner.py (makefile_sample): remove the leading
2637 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
2638 * Makefile: update some release-related stuff
2640 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
2641 gets called when there isn't actually an active process, just end
2642 the Command instead of blowing up. I don't know how it gets into
2643 this state, but the twisted win32 buildslave will sometimes hang,
2644 and when it shakes its head and comes back, it thinks it's still
2645 running a Command. The next build causes this command to be
2646 interrupted, but the lack of self.process.pid breaks the interrupt
2649 * NEWS: document changes since the last release
2651 * buildbot/scripts/runner.py (start): change 'buildbot start' to
2652 look for Makefile.buildbot instead of a bare Makefile . The
2653 'buildbot start' does not install this file, so you have to
2654 manually copy it if you want to customize startup behavior.
2655 (createMaster): change 'buildbot master' command to create
2656 Makefile.sample instead of Makefile, to create master.cfg.sample
2657 instead of master.cfg (requiring you to copy it before the
2658 buildmaster can be started). Both sample files are kept up to
2659 date, i.e. they are overwritten if they have been changed. The
2660 'buildbot.tac' file is *not* overwritten, but if the new contents
2661 don't match the old, a 'buildbot.tac.new' file is created and the
2662 user is warned. This seems to be a much more sane way to handle
2663 startup files. Also, don't sys.exit(0) when done, so we can run
2664 unit tests against it.
2665 (createSlave): same. Don't overwrite the sample info/ files.
2666 * buildbot/scripts/sample.mk: remove. the contents were pulled
2667 into runner.py, since they need to match the behavior of start()
2671 * docs/buildbot.texinfo (Launching the daemons): document it
2672 * buildbot/test/test_runner.py (Create): test it
2674 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
2675 version that can handle string-in-string tests, because otherwise
2676 python-2.2 fails the tests. It'd be tremendous if Trial's test
2677 took two strings under 2.2 too.
2679 * everything: fixed all deprecation warnings when running against
2680 Twisted-2.0 . (at least all the ones in buildbot code, there are a
2681 few that come from Twisted itself). This involved putting most of
2682 the Twisted-version specific code in the new buildbot.twcompat
2683 module, and creating some abstract base classes in
2684 buildbot.changes.base and buildbot.status.base (which might be
2685 useful anyway). __implements__ is a nuisance and requires an ugly
2686 'if' clause everywhere.
2688 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
2689 delay before finishing the test: it seems that smtp.sendmail
2690 doesn't hang up on the server, so we must wait a moment so it can
2691 hang up on us. This removes the trial warning about an unclean
2694 2005-05-16 Brian Warner <warner@lothar.com>
2696 * buildbot/process/step.py (Source): add 'retry' argument. It is a
2697 tuple of (delay, repeats).
2698 * buildbot/test/test_vc.py (Retry): test it
2699 * docs/buildbot.texinfo (Source Checkout): document it
2700 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
2701 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
2702 doVCFull() are handled by re-trying the checkout (after a delay)
2703 some number of times.
2704 (ShellCommand._startCommand): make header lines easier to read
2706 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
2708 (WebTest.test_logfile): make sure master gets shut down, silences
2709 some "unclean reactor" test errors
2711 * buildbot/test/test_changes.py (Sender.tearDown): spin the
2712 reactor once after shutdown, something in certain versions of
2713 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
2714 fails, svn-trunk is ok.
2716 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
2717 second win32 error message
2719 * buildbot/test/test_run.py (Status.testSlave): be smarter about
2720 validating the ETA, so the tests don't fail on slow systems
2722 2005-05-15 Brian Warner <warner@lothar.com>
2724 * buildbot/status/builder.py (HTMLLogFile): make this behave like
2725 the new LogFile class, so upgrading works properly
2726 (LogFileProducer.resumeProducing): survive resumeProducing after
2727 we've exhausted the chunkGenerator
2729 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
2731 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
2732 (Log.testUpgrade): same
2734 * docs/buildbot.texinfo (Maintenance): describe how to delete old
2735 Builds and logs with a cron job.
2737 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
2738 of the old non-offline LogFile, added code to upgrade these to
2739 new-style contents-live-on-disk instances at load time (in a way
2740 that doesn't invalidate the old Build pickles, so upgrading to
2741 0.6.5 is not a one-way operation). Got rid of everything related
2743 (LogFile.__init__): create LogFiles with the parent step status,
2744 the log's name, and a builder-relative filename where it can keep
2745 the contents on disk.
2746 (LogFile.hasContents): new method, clients are advised to call it
2747 before getText or getChunks and friends. If it returns False, the
2748 log's contents have been deleted and getText() will raise an
2750 (LogFile.getChunks): made it a generator
2751 (LogFile.subscribeConsumer): new method, takes a Twisted-style
2752 Consumer (except one that takes chunks instead of strings). This
2753 enables streaming of very large logfiles without storing the whole
2755 (BuildStatus.generateLogfileName): create names like
2756 12-log-compile-output, with a _0 suffix if required to be unique
2757 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
2758 or earlier) logfiles into new-style ones
2759 (BuilderStatus): remove everything related to 'stub' builds. There
2760 is now only one build cache, and we don't strip logs from old
2762 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
2763 since we no longer fight to keep it in the cache
2765 * buildbot/status/html.py (TextLog.render_GET): use a
2766 ChunkConsumer to stream the log entries efficiently.
2767 (ChunkConsumer): wrapper which consumes chunks and writes
2770 * buildbot/test/test_twisted.py (Parse.testParse): use a
2771 LogFile-like object instead of a real one
2773 * buildbot/test/test_status.py (MyLog): handle new LogFile code
2774 (Log.testMerge3): validate more merge behavior
2775 (Log.testChunks): validate LogFile.getChunks
2776 (Log.testUpgrade): validate old-style LogFile upgrading
2777 (Log.testSubscribe): validate LogFile.subscribe
2778 (Log.testConsumer): validate LogFile.subscribeConsumer
2780 * buildbot/interfaces.py (IStatusLogStub): remove
2781 (IStatusLog.subscribeConsumer): new method
2782 (IStatusLog.hasContents): new method
2783 (IStatusLogConsumer): describes things passed to subscribeConsumer
2785 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
2786 the log contents if it does not have any contents.
2787 (StatusResourceBuildStep.body): same
2788 (StatusResourceBuildStep.getChild): give a 404 for empty logs
2790 2005-05-14 Brian Warner <warner@lothar.com>
2792 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
2793 timeouts to try and make the windows metabuildslave not hang
2795 2005-05-13 Mike Taylor <bear@code-bear.com>
2797 * buildbot/slave/commands.py (rmdirRecursive): added a check
2798 to ensure the path passed into rmdirRecursive actually exists.
2799 On win32 a non-existant path would generate an exception.
2801 2005-05-13 Brian Warner <warner@lothar.com>
2803 * buildbot/slave/commands.py (rmdirRecursive): replacement for
2804 shutil.rmtree which behaves correctly on windows in the face of
2805 files that you have to chmod before deleting. Thanks to Bear at
2806 the OSAF for the routine.
2807 (SourceBase.doClobber): use rmdirRecursive
2809 2005-05-12 Brian Warner <warner@lothar.com>
2811 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
2812 method generate chunks instead of returning a big list. This
2813 allows the same method to be used for both old LogFile and new
2815 (OfflineLogFile.getText): use the generator
2816 (OfflineLogFile.subscribe): same
2817 * buildbot/status/html.py (TextLog.resumeProducing): same
2818 * buildbot/interfaces.py (IStatusLog.getChunks): document it
2820 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
2821 point out that OfflineLogFile does not currently work with
2822 html.Waterfall . Fixing this is high-priority.
2824 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
2825 apparently windows defaults to using stdout
2827 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
2828 better message on failure so I can figure out the win32 problem
2830 * buildbot/slave/commands.py (ShellCommand._startCommand): update
2831 log messages to include more useful copies of the command being
2832 run, the argv array, and the child command's environment.
2833 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
2835 2005-05-11 Brian Warner <warner@lothar.com>
2837 * setup.py: oops, install debug.glade so 'buildbot debugclient'
2839 * Makefile: update the deb-snapshot version
2841 * docs/buildbot.texinfo: move all .xhtml docs into a new
2842 .texinfo-format document, adding a lot of material in the process.
2843 This is starting to look like a real user's manual. Removed all
2844 the Lore-related files: *.xhtml, *.css, template.tpl .
2845 * docs/Makefile: simple makefile to run 'makeinfo'
2846 * buildbot/scripts/sample.cfg: rearrange slightly
2847 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
2849 2005-05-10 Brian Warner <warner@lothar.com>
2851 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
2852 different name for the internal twistw module, handle it.
2854 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
2855 * setup.py: .. and stop trying to install it
2857 * buildbot/process/step.py (Git): added support for 'cogito' (aka
2858 'git'), the new linux kernel VC system (http://kernel.org/git/).
2859 Thanks to Brandon Philips for the patch.
2860 * buildbot/slave/commands.py (Git): same
2862 2005-05-06 Brian Warner <warner@lothar.com>
2864 * buildbot/status/builder.py (OfflineLogFile): replace the default
2865 LogFile with a form that appends its new contents to a disk file
2866 as they arrive. The complete log data is never kept in RAM. This
2867 is the first step towards handling very large (100MB+) logfiles
2868 without choking quite so badly. (The other half is
2869 producer/consumer on the HTML pages).
2870 (BuildStepStatus.addLog): use OfflineLogFile by default
2871 (BuildStatus.getLogfileName): helper code to give the
2872 OfflineLogFile a filename to work with
2874 * buildbot/test/test_status.py (Results.testAddResults): update
2875 tests to handle new asserts
2876 * buildbot/test/test_vc.py (Patch.doPatch): same
2877 * buildbot/test/test_steps.py (BuildStep.setUp): same
2879 2005-05-05 Brian Warner <warner@lothar.com>
2881 * buildbot/scripts/runner.py (start): if there is no Makefile,
2882 launch the app by importing twistd's internals and calling run(),
2883 rather than spawning a new twistd process. This stands a much
2884 better chance of working under windows.
2885 (stop): kill the process with os.kill instead of spawning
2886 /bin/kill, again to reduce the number of external programs which
2887 windows might not have in the PATH. Also wait up to 5 seconds for
2888 the process to go away, allowing things like 'buildbot stop;
2889 buildbot start' to be reliable in the face of slow shutdowns.
2891 * buildbot/master.py (Dispatcher.__getstate__): remove old
2892 .tap-related methods
2893 (BuildMaster.__getstate__): same
2895 * buildbot/slave/bot.py (makeService): same
2896 (Options.longdesc): same
2897 * buildbot/scripts/runner.py: copy over some old mktap option text
2899 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
2900 'buildbot master' now creates a buildbot.tac file, so there is no
2901 longer a create-instance/save/reload sequence. mktap is dead, long
2903 * buildbot/scripts/sample.mk: use twistd -y, not -f
2904 * buildbot/test/test_config.py: remove mktap-based test
2905 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
2906 * README: don't reference mktap
2908 * docs/source.xhtml: document some of the attributes that Changes
2911 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
2913 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
2914 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
2915 * buildbot/changes/changes.py (Change)
2916 * buildbot/changes/mail.py (parseSyncmail)
2917 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
2919 * buildbot/process/base.py (Build.isTagImportant)
2923 2005-05-04 Brian Warner <warner@lothar.com>
2925 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
2926 connection after sending the change, so that unit tests don't
2927 complain about sockets being left around
2929 * buildbot/status/html.py (WaterfallStatusResource.body): fix
2930 exception in phase=0 rendering
2931 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
2933 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
2935 * buildbot/master.py (BuildMaster.loadConfig): finally remove
2936 deprecated config keys: webPortnum, webPathname, irc, manholePort,
2937 and configuring builders with tuples.
2938 * buildbot/test/test_config.py: stop testing compatibility with
2939 deprecated config keys
2940 * buildbot/test/test_run.py: same
2942 2005-05-03 Brian Warner <warner@lothar.com>
2944 * contrib/arch_buildbot.py: survive if there are no logfiles
2945 (username): just use a string, os.getlogin isn't reliable
2947 * buildbot/scripts/runner.py (sendchange): oops, fix the command
2948 so 'buildbot sendchange' actually works. The earlier test only
2949 covered the internal (non-reactor-running) form.
2951 * contrib/arch_buildbot.py: utility that can run as an Arch hook
2952 script to notify the buildmaster about changes
2954 * buildbot/scripts/runner.py (sendchange): new command to send a
2955 change to a buildbot.changes.pb.PBChangeSource receiver.
2956 * buildbot/test/test_changes.py (Sender): test it
2958 * buildbot/master.py (BuildMaster.startService): mark .readConfig
2959 after any reading of the config file, not just when we do it in
2960 startService. This makes some tests a bit cleaner.
2962 * buildbot/changes/pb.py: add some log messages
2964 * buildbot/process/base.py (Build.startBuild): fix a bug that
2965 caused an exception when the build terminated in the very first
2967 (Build.stepDone): let steps return a status of EXCEPTION. This
2968 terminates the build right away, and sets the build's overall
2969 status to EXCEPTION too.
2970 * buildbot/process/step.py (BuildStep.failed): return a status of
2971 EXCEPTION when that is what has happened.
2973 * buildbot/process/step.py (Arch.computeSourceRevision): finally
2974 implement this, allowing Arch-based projects to get precise
2975 checkouts instead of always using the latest code
2976 (Bazaar): create variant of Arch to let folks use baz instead of
2977 tla. Requires a new buildslave too.
2978 * buildbot/slave/commands.py (Arch): add 'revision' argument
2979 (Bazaar): create variant of Arch that uses baz instead of tla.
2980 Remove the code that extracts the archive name from the
2981 register-archive output, since baz doesn't provide it, and require
2982 the user provide both the archive name and its location.
2983 * buildbot/test/test_vc.py (VC.testBazaar): added tests
2985 2005-05-02 Brian Warner <warner@lothar.com>
2987 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
2988 thanks to Nick Trout.
2990 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
2991 deals better with source Makefile coming from a read-only CVS
2992 checkout. Thanks to Nick Trout for the catch.
2994 * buildbot/__init__.py (version): bump to 0.6.4+ while between
2997 2005-04-28 Brian Warner <warner@lothar.com>
2999 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3001 * debian/changelog: update for 0.6.4
3003 2005-04-28 Brian Warner <warner@lothar.com>
3005 * README.w32: add a checklist of steps for getting buildbot
3007 * MANIFEST.in: include it in the tarball
3011 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3012 broken .tap files from 0.6.3 by getting rid of .services,
3013 .namedServices, and .change_svc at load time.
3015 2005-04-27 Brian Warner <warner@lothar.com>
3017 * NEWS: update in preparation for new release
3019 * buildbot/test/test_config.py (Save.testSave): don't pull in
3020 twisted.scripts.twistd, we don't need it and it isn't for windows
3023 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3024 accomodate win32 which can't do atomic-rename
3026 2005-04-27 Brian Warner <warner@lothar.com>
3028 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3029 timeouts to help the slow metabuildbot not flunk them so much
3030 (Disconnect.testBuild3): same
3031 (Disconnect.testBuild4): same
3032 (Disconnect.testInterrupt): same
3034 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3035 setup, it was completely broken for new buildmasters (those which
3036 did not have a 'change.pck' already saved. Thanks to Paul Warren
3037 for catching this (embarrassing!) bug.
3038 (Dispatcher.__getstate__): don't save our registered avatar
3039 factories, since they'll be re-populated when the config file is
3041 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3042 tests (since the real mktap-generated BuildMaster doesn't save
3044 (BuildMaster.__getstate__): don't save any service children,
3045 they'll all be re-populated when the config file is re-read.
3046 * buildbot/test/test_config.py (Save.testSave): test for this
3048 2005-04-26 Brian Warner <warner@lothar.com>
3050 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3051 rendered with Blender.. looks a bit nicer.
3052 * buildbot/docs/images/icon.blend: add the Blender file for it
3054 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3055 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3056 running under windows. This appears to be the best way to allow
3057 BuildSteps to do something normal like 'trial -v buildbot.test' or
3058 'make foo' and still expect it to work. The idea is to make the
3059 BuildSteps look as much like what a developer would type when
3060 compiling or testing the tree by hand. This approach probably has
3061 problems when there are spaces in the arguments, so if you've got
3062 windows buildslaves, you'll need to pay close attention to your
3065 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3066 timezone to the timestamp column.
3067 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3069 * buildbot/scripts/runner.py (loadOptions): do something sane for
3070 windows, I think. We use %APPDATA%/buildbot instead of
3071 ~/.buildbot, but we still search everywhere from the current
3072 directory up to the root for a .buildbot/ subdir. The "is it under
3073 $HOME" security test was replaced with "is it owned by the current
3074 user", which is only performed under posix.
3075 * buildbot/test/test_runner.py (Options.testFindOptions): update
3076 tests to match. The "is it owned by the current user" check is
3077 untested. The test has been re-enabled for windows.
3079 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3080 any "\n" in the expected output with the platform-specific line
3081 separator. Make this separator "\r\n" on PTYs under unix, they
3082 seem to do that and I don't know why
3084 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3085 windows for now, I don't know what ~/.buildbot/ should mean there.
3087 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3088 win32 compatibility, don't use "/tmp"
3089 (Basedir.testChangeBuilddir): remove more unixisms
3091 2005-04-26 Brian Warner <warner@lothar.com>
3093 * buildbot/test/test_control.py (Force.rmtree): python2.2
3094 compatibility, apparently its shutil.rmtree ignore_errors=
3095 argument is ignored.
3096 * buildbot/test/test_run.py (Run.rmtree): same
3097 (RunMixin.setUp): same
3099 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3102 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3103 'substring in string' operator, must use string.find(substr)!=-1
3104 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3105 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3107 * buildbot/scripts/runner.py (loadOptions): add code to search for
3108 ~/.buildbot/, a directory with things like 'options', containing
3109 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3110 the current directory, your $HOME directory, or anywhere
3111 inbetween, as long as you're somewhere inside your home directory.
3112 (debugclient): look in ~/.buildbot/options for master and passwd
3113 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3114 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3116 * buildbot/status/client.py (makeRemote): new approach to making
3117 IRemote(None) be None, which works under Twisted-2.0
3118 * buildbot/test/test_status.py (Client.testAdaptation): test it
3120 * buildbot/status/builder.py (Status.builderAdded): when loading a
3121 pickled BuilderStatus in from disk, set its name after loading.
3122 The config file might have changed its name (but not its
3123 directory) while it wasn't looking.
3125 * buildbot/process/builder.py (Builder.attached): always return a
3126 Deferred, even if the builder was already attached
3127 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3129 2005-04-25 Brian Warner <warner@lothar.com>
3131 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3132 category-related exception when announcing a build has finished
3134 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3135 reference no-longer-existent changemaster.sources
3136 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3138 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3141 2005-04-25 Brian Warner <warner@lothar.com>
3143 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3145 * debian/changelog: update for 0.6.3
3147 2005-04-25 Brian Warner <warner@lothar.com>
3149 * MANIFEST.in: make sure debug.glade is in the tarball
3151 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3153 * NEWS: update for the imminent 0.6.3 release
3155 * buildbot/status/html.py (HtmlResource.content): make the
3156 stylesheet <link> always point at "buildbot.css".
3157 (StatusResource.getChild): map "buildbot.css" to a static.File
3158 containing whatever css= argument was provided to Waterfall()
3159 (Waterfall): provide the "classic" css as the default.
3160 * docs/waterfall.classic.css: move default CSS from here ..
3161 * buildbot/status/classic.css: .. to here
3163 * MANIFEST.in: make sure classic.css is included in the tarball
3164 * setup.py: and that it is installed too, under buildbot/status/
3166 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3167 the module level, because buildbot.tap files from 0.6.2 don't have
3168 it in their attribute dictionary.
3170 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3171 really exists at startup, might save some confusion somewhere.
3173 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3175 * docs/waterfall.classic.css:
3176 add a stylesheet that's almost the same as the "classic"
3179 * buildbot/status/builder.py:
3180 add EXCEPTION as a result - this is a problem for the bot
3181 maintainer, not a build problem for the changers
3182 * buildbot/process/step.py:
3183 use EXCEPTION instead of FAILURE for exceptions
3184 * buildbot/status/html.py:
3185 add build_get_class to get a class out of a build/buildstep
3186 finish naming the classes
3187 split out sourceNames to changeNames and builderNames so we
3188 can style them separately
3189 * docs/config.xhtml:
3190 finish documenting classes as they are right now
3192 * buildbot/status/html.py:
3193 name the classes as we agreed on IRC
3194 * docs/config.xhtml:
3197 * buildbot/status/html.py:
3198 same for cssclass->class_
3200 * buildbot/status/html.py:
3201 as decided on IRC, use class_ for the "class" attribute to not
3202 conflict with the class keyword, and clean up the messy **{} stuff.
3204 * buildbot/status/mail.py:
3205 put back "builders" argument, and fix docstring, because the
3206 code *ignores* builders listed in this argument
3208 * buildbot/process/builder.py:
3209 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3211 * docs/config.xhtml:
3212 describe the category argument for builders
3214 * buildbot/status/builder.py:
3215 Fix a silly bug due to merging
3217 * buildbot/process/builder.py:
3218 remove category from the process Builder ...
3219 * buildbot/status/builder.py:
3220 ... and add it to BuilderStatus instead.
3221 Set category on unpickled builder statuses, they might not have it.
3222 * buildbot/master.py:
3223 include category when doing builderAdded
3224 * buildbot/status/mail.py:
3225 return None instead of self for builders we are not interested in.
3226 * buildbot/test/test_run.py:
3227 fix a bug due to only doing deferredResult on "dummy" waiting
3228 * buildbot/test/test_status.py:
3229 add checks for the Mail IStatusReceiver returning None or self
3231 * buildbot/status/html.py:
3232 fix testsuite by prefixing page title with BuildBot
3234 * buildbot/status/builder.py:
3235 have .category in builder status ...
3236 * buildbot/process/builder.py:
3237 ... and set it from Builder
3238 * buildbot/status/html.py:
3239 make .css a class variable
3240 * buildbot/test/test_status.py:
3241 write more tests to cover our categories stuff ...
3242 * buildbot/status/mail.py:
3243 ... and fix the bug that this uncovered
3245 * buildbot/changes/mail.py:
3246 * buildbot/changes/pb.py:
3247 * buildbot/master.py:
3248 * buildbot/process/base.py:
3249 * buildbot/process/factory.py:
3250 * buildbot/process/interlock.py:
3251 * buildbot/process/step.py:
3252 * buildbot/process/step_twisted.py:
3253 * buildbot/slave/commands.py:
3254 * buildbot/status/builder.py:
3255 * buildbot/status/client.py:
3256 * buildbot/status/html.py:
3257 * buildbot/status/mail.py:
3258 * buildbot/status/progress.py:
3259 * buildbot/test/test_changes.py:
3260 * buildbot/test/test_config.py:
3261 * buildbot/test/test_control.py:
3262 * buildbot/test/test_interlock.py:
3263 * buildbot/test/test_maildir.py:
3264 * buildbot/test/test_mailparse.py:
3265 * buildbot/test/test_run.py:
3266 * buildbot/test/test_slavecommand.py:
3267 * buildbot/test/test_status.py:
3268 * buildbot/test/test_steps.py:
3269 * buildbot/test/test_twisted.py:
3270 * buildbot/test/test_util.py:
3271 * buildbot/test/test_vc.py:
3272 * buildbot/test/test_web.py:
3274 add test-case-name at the top of a whole set of files
3276 * buildbot/status/builder.py:
3277 keep order of addition when getting builder names
3278 * buildbot/status/words.py:
3279 * buildbot/test/test_run.py:
3280 add test for getBuilderNames
3282 * buildbot/process/base.py:
3283 * buildbot/process/step.py:
3284 * buildbot/status/builder.py:
3285 * buildbot/status/html.py:
3286 make buildbot css-able
3287 replace the color code for purple with purple, don't understand
3288 why it wasn't purple to start with
3290 * buildbot/status/words.py:
3291 ok, so it doesn't look like BuilderStatus.remote is still valid.
3292 Use what waterfall uses instead.
3294 * buildbot/interfaces.py:
3295 * buildbot/status/builder.py:
3296 * buildbot/status/html.py:
3297 * buildbot/status/mail.py:
3298 * buildbot/status/words.py:
3299 * buildbot/test/test_run.py:
3300 use categories everywhere and make it be a list. More sensible
3301 for the future. Also make words actually respect this in
3304 * buildbot/interfaces.py:
3305 add category argument to getBuilderNames
3306 * buildbot/process/builder.py:
3307 * buildbot/status/builder.py:
3308 * buildbot/status/html.py:
3309 * buildbot/status/mail.py:
3310 * buildbot/status/words.py:
3311 * buildbot/test/test_run.py:
3312 move from specifying builders by name to specifying the category
3314 * buildbot/status/html.py:
3315 * buildbot/status/words.py:
3316 add "builders=" to __init__ of status clients so they can
3317 limit themselves to the given list of builders to report on
3319 * buildbot/status/html.py: set the title to the product name
3321 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3323 * buildbot/interfaces.py:
3324 * buildbot/status/builder.py:
3325 more documentation. Hm, not sure if ChangeLog entries make sense
3328 2005-04-23 Brian Warner <warner@lothar.com>
3330 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3332 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3334 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3335 the sub-commands that log buildmaster status to stdout and to a
3336 GUI window, respectively.
3338 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3339 functionality is working again, but all the step-status and ETA
3340 stuff is missing. Commented out a lot of code pending more
3343 * buildbot/status/client.py: make sure that IRemote(None) is None
3345 * buildbot/changes/changes.py: import defer, oops
3346 (ChangeMaster): remove the .sources list, rely upon the fact that
3347 MultiServices can be treated as sequences of their children. This
3348 cleans up the add/remove ChangeSource routines a lot, as we keep
3349 exactly one list of the current sources instead of three.
3351 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3352 up an empty ChangeMaster at init time.
3353 (BuildMaster.loadChanges): if there are changes to be had from
3354 disk, replace self.change_svc with the new ones. If not, keep
3355 using the empty ChangeMaster set up in __init__.
3356 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3357 instead of a separate list, makes the code a bit cleaner.
3358 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3359 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3360 Extend the test to make sure we can get rid of the sources when
3363 2005-04-22 Brian Warner <warner@lothar.com>
3365 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3366 and info/host files when making the slave directory
3368 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3369 whendone= argument, just return the Deferred and let the caller do
3370 what they want with it.
3371 (Disconnect.testBuild1): wait for shutdownSlave
3372 (Basedir.testChangeBuilddir): new test to make sure changes to the
3373 builddir actually get propagated to the slave
3375 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3376 explicit method, rather than passing the builddir in __init__ .
3377 Make sure to update self.basedir too, this was broken before.
3378 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3379 builders and for ones that have just had their builddir changed.
3380 (BotFactory): add a class-level .perspective attribute, so
3381 BuildSlave.waitUntilDisconnected won't get upset when the
3382 connection hasn't yet been established
3383 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3384 tests can reach through it to inspect the SlaveBuilders
3386 * buildbot/process/base.py (Build.buildException): explain the
3387 log.err with a log.msg
3388 * buildbot/process/builder.py (Builder.startBuild): same
3389 (Builder._startBuildFailed): improve error message
3391 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3392 occurred because we lost the brand-new connection, retry instead
3393 of giving up. If not, it's probably an authorization failure, and
3394 it makes sense to stop trying. Make sure we log.msg the reason
3395 that we're log.err'ing the failure, otherwise test failures are
3396 really hard to figure out.
3398 * buildbot/master.py: change loadConfig() to return a Deferred
3399 that doesn't fire until the change has been fully implemented.
3400 This means any connected slaves have been updated with the new
3401 builddir. This change makes it easier to test the code which
3402 actually implements this builddir-updating.
3403 (BotPerspective.addBuilder): return Deferred
3404 (BotPerspective.removeBuilder): same
3405 (BotPerspective.attached): same
3406 (BotPerspective._attached): same. finish with remote_print before
3407 starting the getSlaveInfo, instead of doing them in parallel
3408 (BotPerspective.list_done): same
3409 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3410 actually calling slave.disconnect()
3411 (BotMaster.addBuilder): same
3412 (BotMaster.removeBuilder): same
3413 (BuildMaster.loadConfig): same
3414 (BuildMaster.loadConfig_Slaves): same
3415 (BuildMaster.loadConfig_Sources): same
3416 (BuildMaster.loadConfig_Builders): same
3417 (BuildMaster.loadConfig_status): same
3419 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3420 a Deferred that fires when the source is finally removed
3422 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3423 the previous tree on win32, where we have to do it synchronously,
3424 make sure we return a Deferred anyway.
3425 (SourceBase.doCopy): same
3427 * buildbot/scripts/runner.py (statusgui): use the text client for
3428 now, while I rewrite the Gtk one
3429 * buildbot/clients/base.py: strip out old code, leaving just the
3430 basic print-message-on-event functionality. I also remove the
3431 ReconnectingPBClientFactory, but it does at least quit when it
3432 loses the connection instead of going silent
3434 2005-04-21 Brian Warner <warner@lothar.com>
3436 * Makefile: minor tweaks
3438 * NEWS: point out deprecation warnings, new features for
3441 * buildbot/master.py (BuildMaster.loadConfig): emit
3442 DeprecationWarnings for Builders defined with tuples. Rearrange
3443 code to facility removal of deprecated configuration keys in the
3446 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3447 'buildbot' command to put a little Makefile in the target that
3448 helps you re-create the buildbot.tap file, start or stop the
3449 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3450 all the files 0600, since they contain passwords.
3451 (start): if there is a Makefile, and /usr/bin/make exists, use
3452 'make start' in preference to a raw twistd command. This lets
3453 slave admins put things like PYTHONPATH variables in their
3454 Makefiles and have them still work when the slave is started with
3455 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3456 be nice to first try the 'make' command and only fall back to
3457 twistd if it fails. TODO: the Makefile's "start" command does not
3458 add the --reactor=win32 argument when running under windows.
3459 (Options.debugclient, Options.statusgui): add sub-commands to launch
3460 the debug client (formerly in contrib/debugclient.py) and the
3461 Gtk status application (currently broken)
3462 * buildbot/clients/debug.py: move from contrib/debugclient.py
3463 * buildbot/clients/debug.glade: same
3465 * buildbot/test/test_trial.py: remove it. This requires some
3466 functionality out of Twisted that isn't there yet, and until then
3467 having it around just confuses things.
3469 * buildbot/test/test_slavecommand.py (Shell): test both with and
3470 without PTYs, and make sure that command output is properly
3471 interleaved in the with-PTY case. I think the without-PTY test
3472 should pass on windows, where we never use PTYs anyway.
3474 2005-04-20 Brian Warner <warner@lothar.com>
3476 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3478 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3480 * NEWS: start creating entries for the next release
3482 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3484 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3485 (WebTest.test_webPathname): same
3486 (WebTest.test_webPathname_port): same
3487 (WebTest.test_waterfall): use the default favicon rather than
3488 rooting around the filesystem for it. Open the expected-icon file
3489 in binary mode, to make win32 tests happier (thanks to Nick Trout
3491 * buildbot/status/html.py (buildbot_icon): win32 portability
3493 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3494 win32-compatibility fixes from Nick Trout, the "file not found" message
3495 is different under windows
3496 (FakeSlaveBuilder.__init__): clean up setup a bit
3497 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3499 2005-04-19 Brian Warner <warner@lothar.com>
3501 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3502 skip-if-repositories-are-unavailable test to not kill the trial
3503 that comes with Twisted-1.3.0
3505 * setup.py: install buildbot.png icon file when installing code
3507 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3508 environment used by the command, at least on the child side.
3510 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3511 this method needs to be added and implemented because it gets
3512 called under heavy load. I don't quite understand the
3513 producer/consumer API enough to write it.
3514 (StatusResource.getChild): add a resource for /favicon.ico
3515 (Waterfall.__init__): add favicon= argument
3516 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3517 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3518 (WebTest.test_webPathname): same
3519 (WebTest.test_webPathname_port): same
3520 * docs/config.xhtml: mention favicon=
3521 * buildbot/buildbot.png: add a default icon, dorky as it is
3523 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3525 * buildbot/master.py:
3526 * buildbot/process/base.py:
3527 * buildbot/process/builder.py:
3528 * buildbot/process/interlock.py:
3529 * buildbot/status/builder.py:
3530 * buildbot/status/html.py:
3531 * buildbot/status/mail.py:
3532 * buildbot/status/words.py:
3533 new documentation while digging through the code
3535 2005-04-17 Brian Warner <warner@lothar.com>
3537 * general: try to fix file modes on all .py files: a+r, a-x,
3538 but let buildbot/clients/*.py be +x since they're tools
3540 * docs/epyrun (addMod): when an import fails, say why
3542 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3544 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3546 * buildbot/process/base.py:
3547 * buildbot/process/builder.py:
3548 * buildbot/status/builder.py:
3549 new documentation while digging through the code
3551 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3553 * buildbot/changes/changes.py:
3554 * buildbot/changes/p4poller.py:
3555 * buildbot/interfaces.py:
3556 * buildbot/process/base.py:
3557 * buildbot/process/builder.py:
3558 * buildbot/process/step.py:
3559 * buildbot/process/step_twisted.py:
3560 * buildbot/slave/bot.py:
3561 * buildbot/slave/commands.py:
3562 * buildbot/status/builder.py:
3563 fix all docstrings to make epydoc happy. In the process of fixing
3564 some, I also moved pieces of docs, and removed some deprecated
3567 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3569 * buildbot/process/builder.py:
3570 * buildbot/process/interlock.py:
3571 * buildbot/process/process_twisted.py:
3572 * buildbot/process/step.py:
3573 BuildProcess -> Build, as it looks like that's what happened
3574 * buildbot/process/base.py:
3575 * buildbot/process/factory.py:
3578 2005-04-17 Brian Warner <warner@lothar.com>
3580 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3581 update compile command to accomodate the Twisted split.. now
3582 instead of './setup.py build_ext -i', you do './setup.py all
3583 build_ext -i', to run build_ext over all sub-projects.
3584 (FullTwistedBuildFactory): same
3585 (TwistedReactorsBuildFactory): same
3587 * buildbot/status/html.py (TextLog.finished): null out self.req
3588 when we're done, otherwise the reference cycle of TextLog to .req
3589 to .notifications to a Deferred to TextLog.stop keeps them from
3590 being collected, and consumes a huge (610MB on pyramid at last
3591 check) amount of memory.
3593 2005-04-11 Brian Warner <warner@lothar.com>
3595 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3596 normalize the VC-repository location.. makes SVN happier with
3597 certain test environments.
3599 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3600 RemoteShellCommand gets its own .env dictionary, so that code in
3601 start() doesn't mutate the original. I think this should fix the
3602 step_twisted.Trial problem where multiple identical components
3603 kept getting added to PYTHONPATH= over and over again.
3605 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3606 adding epydoc-format docstrings to many classes. Thanks to Thomas
3607 Vander Stichele for the patches.
3608 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3609 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3610 * buildbot/slave/bot.py, commands.py, registry.py: same
3612 2005-04-05 Brian Warner <warner@lothar.com>
3614 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3615 preserve timestamps, helps incremental builds of large trees.
3616 Patch from Rene Rivera.
3618 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
3619 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
3622 2005-04-03 Brian Warner <warner@lothar.com>
3624 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
3625 with one dict, apparently exec has some scoping bugs when used
3626 with both global/local dicts. Thanks to Nathaniel Smith for the
3629 2005-04-02 Brian Warner <warner@lothar.com>
3631 * buildbot/process/step_twisted.py (countFailedTests): the new
3632 trial in Twisted-2.0 emits a slightly different status line than
3633 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
3634 mistakenly think the test count is unparseable.
3635 (Trial.start): note that for some reason each build causes another
3636 copy of self.testpath to be prepended to PYTHONPATH. This needs to
3637 be fixed but I'm not sure quite where the problem is.
3639 2005-04-01 Brian Warner <warner@lothar.com>
3641 * buildbot/test/test_run.py (Run.testMaster): change some uses of
3642 deferredResult to avoid hangs/warnings under twisted-2.0
3643 (RunMixin.tearDown): same
3644 (RunMixin.shutdownSlave): same
3645 (Disconnect.testIdle1): same
3646 (Disconnect.testBuild2): same: wait one second after the build
3647 finishes for test to really be done.. this should be cleaned up to
3648 avoid wasting that second. Builder.detach uses a callLater(0),
3649 either that should be done in-line (something else needed that
3650 behavior), or it should return a Deferred that fires when the
3651 builder is really offline.
3652 (Disconnect.testBuild3): same
3653 (Disconnect.testDisappear): same
3655 * buildbot/test/test_web.py: rearrange server-setup and teardown
3656 code to remove unclean-reactor warnings from twisted-2.0
3658 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
3659 so the tests don't hang under twisted-2.0
3661 2005-03-31 Brian Warner <warner@lothar.com>
3663 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
3664 caused a warning each time the master changed our set of builders
3666 * buildbot/status/builder.py (BuildStatus.saveYourself): under
3667 w32, don't unlink the file unless it already exists. Thanks to
3668 Baptiste Lepilleur for the catch.
3669 (BuilderStatus.saveYourself): same
3671 2005-02-01 Brian Warner <warner@lothar.com>
3673 * buildbot/status/html.py (TextLog.getChild): use a /text child
3674 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
3675 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
3676 logfile as text/plain (no markup, no headers). This replaces the
3677 previous scheme (which used an ?text=1 argument), and gets us back
3678 to a relative link (which works better when the buildbot lives
3679 behind another web server, such as Apache configured as a reverse
3680 proxy). Thanks to Gerald Combs for spotting the problem.
3682 * buildbot/__init__.py (version): bump to 0.6.2+ while between
3685 2004-12-13 Brian Warner <warner@lothar.com>
3687 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
3689 * debian/changelog: update for 0.6.2
3690 * NEWS: finalize for 0.6.2
3692 2004-12-11 Brian Warner <warner@lothar.com>
3694 * NEWS: bring it up to date
3696 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
3697 detection code. Require some sign of life from the buildmaster
3698 every BotFactory.keepaliveInterval seconds. Provoke this
3699 indication at BotFactory.keepaliveTimeout seconds before the
3700 deadline by sending a keepalive request. We don't actually care if
3701 that request is answered in a timely fashion, what we care about
3702 is that .activity() is called before the deadline. .activity() is
3703 triggered by any PB message from the master (including an ack to
3704 one of the slave's status-update messages). With this new scheme,
3705 large status messages over slow pipes are OK, as long as any given
3706 message can be sent (and thus acked) within .keepaliveTimeout
3707 seconds (which defaults to 30).
3708 (SlaveBuilder.remote_startCommand): record activity
3709 (SlaveBuilder.ackUpdate): same
3710 (SlaveBuilder.ackComplete): same
3711 (BotFactory.gotPerspective): same
3712 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
3714 2004-12-09 Brian Warner <warner@lothar.com>
3716 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
3719 * buildbot/process/step_twisted.py (Trial._commandComplete):
3720 update self.cmd when we start the 'cat test.log' transfer. Without
3721 this, we cannot interrupt the correct RemoteCommand when we lose
3724 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
3725 trying to tell the slave to stop the command if we're already
3726 inactive, or if we no longer have a .remote
3728 * buildbot/process/builder.py (Builder._detached): don't let an
3729 exception in currentBuild.stopBuild() prevent the builder from
3730 being marked offline
3732 2004-12-07 Brian Warner <warner@lothar.com>
3734 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
3735 KeyError that happens when you ask for a non-existent Builder, and
3736 translate it into a UsageError.
3738 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
3739 losing the slave in the middle of a remote step is handled too
3741 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
3742 be a Failure, so be sure to stringify it before using it as the
3743 contents of the 'interrupt' logfile
3744 (RemoteCommand.interrupt): use stringified 'why' in
3745 remote_interruptCommand too, just in case
3747 2004-12-06 Brian Warner <warner@lothar.com>
3749 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
3750 instead of 'tla update', which is more efficient in case we've
3751 missed a couple of patches since the last update.
3753 * debian/changelog: update for previous (0.6.1) release. Obviously
3754 this needs to be handled better.
3756 2004-12-05 Brian Warner <warner@lothar.com>
3758 * NEWS: update for stuff since last release
3760 * buildbot/master.py (DebugPerspective.attached): return 'self', to
3761 match the maybeDeferred change in Dispatcher.requestAvatar
3762 * buildbot/changes/pb.py (ChangePerspective.attached): same
3763 * buildbot/status/client.py (StatusClientPerspective.attached): same
3764 * buildbot/process/builder.py (Builder._attached3): same
3765 * buildbot/pbutil.py (NewCredPerspective.attached): same
3767 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
3768 the date to the top-most box, if it is not the same as today's
3771 * docs/slave.xhtml: provide a buildslave setup checklist
3773 * docs/source.xhtml (Arch): correct terminology
3775 2004-12-04 Brian Warner <warner@lothar.com>
3777 * buildbot/test/test_slavecommand.py: use sys.executable instead
3778 of hard-coding 'python' for child commands, might help portability
3780 * docs/examples/twisted_master.cfg: update to current usage
3782 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
3783 'stop build' command to the IRC bot
3785 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
3786 message that broke PBChangeSource
3788 * buildbot/slave/bot.py: clean up shutdown/lose-master code
3789 (SlaveBuilder): make some attributes class-level, remove the old
3790 "update queue" which existed to support resuming a build after the
3791 master connection was lost. Try to reimplement that feature later.
3792 (SlaveBuilder.stopCommand): clear self.command when the
3793 SlaveCommand finishes, so that we don't try to kill a leftover one
3795 (SlaveBuilder.commandComplete): same, merge with commandFailed and
3798 * buildbot/slave/commands.py (SourceBase): set self.command for
3799 all VC commands, so they can be interrupted.
3801 2004-12-03 Brian Warner <warner@lothar.com>
3803 * buildbot/master.py: clean up slave-handling code, to handle
3804 slave-disconnect and multiple-connect better
3805 (BotPerspective): make these long-lasting, exactly one per bot
3806 listed in the config file.
3807 (BotPerspective.attached): if a slave connects while an existing
3808 one appears to still be connected, disconnect the old one first.
3809 (BotPerspective.disconnect): new method to forcibly disconnect a
3810 buildslave. Use some hacks to empty the transmit buffer quickly to
3811 avoid the long (20-min?) TCP timeout that could occur if the old
3812 slave has dropped off the net.
3813 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
3814 own their own SlaveStatus objects. Remove .attached/.detached, add
3815 .addSlave/.removeSlave, treat slaves like Builders (config file
3816 parsing sends deltas to the BotMaster). Inform the slave
3817 instances, i.e. the BotPerspective, about addBuilder and
3819 (BotMaster.getPerspective): turns into a single dict lookup
3820 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
3821 which gives BotPerspective.attached a chance to disconnect the old
3823 (BuildMaster.loadConfig): add code (disabled) to validate that all
3824 builders use known slaves (listed in c['bots']). The check won't
3825 work with tuple-specified builders, which are deprecated but not
3826 yet invalid, so the check is disabled for now.
3827 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
3828 routine, do the add/changed/removed dance with them like we do
3830 (BuildMaster.loadConfig_Sources): move source-config into a
3831 separate routine too
3833 * buildbot/status/builder.py (Status.getSlave): get the
3834 SlaveStatus object from the BotPerspective, not the BotMaster.
3836 * buildbot/test/test_run.py: bunch of new tests for losing the
3837 buildslave at various points in the build, handling a slave that
3838 connects multiple times, and making sure we can interrupt a
3841 * buildbot/slave/bot.py (BuildSlave): make it possible to use
3842 something other than 'Bot' for the Bot object, to make certain
3843 test cases easier to write.
3844 (BuildSlave.waitUntilDisconnected): utility method for testing
3846 2004-11-30 Brian Warner <warner@lothar.com>
3848 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
3850 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
3851 argument, return a Deferred that always fires with True or False.
3852 I don't use an errback to indicate 'ping failed' so that callers
3853 are free to ignore the deferred without causing spurious errors in
3855 * buildbot/process/builder.py (BuilderControl.ping): implement it
3857 * buildbot/test/test_run.py (Status.testDisappear): test ping
3858 (Status.disappearSlave): fix it
3860 2004-11-30 Brian Warner <warner@lothar.com>
3862 * buildbot/interfaces.py (IBuildControl): add .stopBuild
3863 (IBuilderControl): add .getBuild(num), only works for the current
3864 build, of course, although it might be interesting to offer
3865 something for builds in the .waiting or .interlocked state.
3867 * buildbot/process/base.py (Build): have .stopBuild just do the
3868 interrupt, then let the build die by itself.
3869 (BuildControl): add .stopBuild, and add a point-event named
3870 'interrupt' just after the build so status viewers can tell that
3872 (BuilderControl): add .getBuild
3874 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
3875 stops when you kill it, good for testing
3876 (ShellCommand.interrupt): add a logfile named 'interrupt' which
3877 contains the 'reason' text.
3879 * buildbot/status/html.py: Add Stop Build button, if the build can
3880 still be stopped. Send a Redirect (to the top page) one second
3881 later, hopefully long enough for the interrupt to have an effect.
3882 Move make_row() up to top-level to share it between Stop Build and
3885 * buildbot/slave/commands.py: only kill the child process once
3887 * buildbot/test/test_run.py: add testInterrupt
3889 2004-11-29 Brian Warner <warner@lothar.com>
3891 * buildbot/process/base.py: Refactor command interruption. The
3892 Build is now responsible for noticing that the slave has gone
3893 away: Build.lostRemote() interrupts the current step and makes
3894 sure that no further ones will be started.
3896 * buildbot/process/builder.py: When the initial remote_startBuild
3897 message fails, log it: this usually indicates that the slave has
3898 gone away, but we don't really start paying attention until they
3899 fail to respond to the first step's command.
3901 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
3902 slave disconnect. Now sports a new interrupt() method. Error
3903 handling was simplified a lot by chaining deferreds, so
3904 remoteFailed/remoteComplete were merged into a single
3905 remoteComplete method (which can now get a Failure object).
3906 Likewise failed/finished were merged into just _finished.
3907 (BuildStep): Add interrupt(why) method, and if why is a
3908 ConnectionLost Failure then the step is failed with some useful
3911 * buildbot/slave/bot.py: stop the current command when the remote
3912 Step reference is lost, and when the slave is shut down.
3913 (Bot): make it a MultiService, so it can have children. Use
3914 stopService to tell when the slave is shutting down.
3915 (SlaveBuilder): make it a Service, and a child of the Bot. Add
3916 remote_interruptCommand (which asks the current SlaveCommand to
3917 stop but allows it to keep emitting status messages), and
3918 stopCommand (which tells it to shut up and die).
3920 * buildbot/slave/commands.py: make commands interruptible
3921 (ShellCommand.kill): factor out os.kill logic
3922 (Command): factor out setup()
3923 (Command.sendStatus): don't send status if .running is false, this
3924 happens when the command has been halted.
3925 (Command.interrupt): new method, used to tell the command to die
3926 (SlaveShellCommand): implement .interrupt
3927 (DummyCommand): implement .interrupt
3928 (SourceBase, etc): factor out setup(), don't continue substeps if
3931 * buildbot/status/builder.py: fix all waitUntilFinished() methods
3932 so they can be called after finishing
3934 * buildbot/test/test_run.py: new tests for disconnect behavior,
3935 refactor slave-shutdown routines, add different kinds of
3938 2004-11-27 Brian Warner <warner@lothar.com>
3940 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
3941 method to express ETA time like "2m45s" instead of "165 seconds"
3943 2004-11-24 Brian Warner <warner@lothar.com>
3945 * buildbot/test/test_vc.py (VC.testArch): unregister the test
3946 archive after the test completes, to avoid cluttering the user's
3947 'tla archives' listing with a bogus entry. Arch doesn't happen to
3948 provide any way to override the use of ~/.arch-params/, so there
3949 isn't a convenient way to avoid touching the setup of the user who
3951 (VC_HTTP.testArchHTTP): same
3953 2004-11-23 Brian Warner <warner@lothar.com>
3955 * buildbot/status/html.py (TextLog): split render() up into
3956 render_HEAD and render_GET. Use a Producer when sending log
3957 chunks, to reduce memory requirements and avoid sending huge
3958 non-Banana-able strings over web.distrib connections. Requires
3959 peeking under the covers of IStatusLog.
3960 (TextLog.resumeProducing): fix the "as text" link, handle client
3961 disconnects that occur while we're still sending old chunks.
3963 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
3964 use defer.succeed, not the non-existent defer.success
3965 (LogFile.waitUntilFinished): same
3966 (LogFile.subscribe): don't add watchers to a finished logfile
3968 * buildbot/__init__.py (version): bump to 0.6.1+ while between
3971 2004-11-23 Brian Warner <warner@lothar.com>
3973 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
3975 2004-11-23 Brian Warner <warner@lothar.com>
3977 * NEWS: update for the 0.6.1 release
3978 * MANIFEST.in: add new files
3980 * README (INSTALLATION): explain how to enable the extra VC tests
3982 * buildbot/status/builder.py (LogFile): add .runEntries at the class
3983 level to, so old pickled builds can be displayed ok
3985 2004-11-22 Brian Warner <warner@lothar.com>
3987 * NEWS: summarize updates since last release
3989 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
3990 Yoz Grahame. Closes SF#1050138.
3992 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
3995 * buildbot/process/step_twisted.py (Trial): update docs a bit
3997 * docs/factories.xhtml: fix Trial factory docs to match reality.
4000 * buildbot/process/factory.py (Trial.__init__): add args for
4001 randomly= and recurse=, making them available to instantiators
4002 instead of only to subclassers. Closes: SF#1049759.
4004 2004-11-15 Brian Warner <warner@lothar.com>
4006 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4007 try to teach the Quick factory to use multiple versions of python
4009 2004-11-12 Brian Warner <warner@lothar.com>
4011 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4012 safer w32-compatible approach, and only use it on windows
4013 (BuildStatus.saveYourself): same
4015 2004-11-11 Brian Warner <warner@lothar.com>
4017 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4018 it: one string merge per chunk. There are now separate .entries
4019 and .runEntries lists: when enumerating over all chunks, make sure
4021 * buildbot/test/test_status.py (Log): more tests
4023 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4024 chunks together, up to 10kb per chunk. This ought to cut down on
4025 the CPU-burning overhead of large log files. Thanks to Alexander
4026 Staubo for spotting the problem.
4027 * buildbot/test/test_status.py (Log): tests for same
4029 2004-11-10 Brian Warner <warner@lothar.com>
4031 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4032 header to outbound mail
4033 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4035 2004-11-08 Brian Warner <warner@lothar.com>
4037 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4038 can't do os.rename() onto an existing file, so catch the exception
4039 and unlink the target file first. This introduces a slight window
4040 where the existing file could be lost, but the main failure case
4041 (disk full) should still be handled safely.
4042 (BuildStatus.saveYourself): same
4044 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4045 separator character instead of os.sep, because the filenames being
4046 split here are coming from the VC system, which can have a
4047 different pathname convention than the local host. This should
4048 help a buildmaster running on windows that uses a CVS repository
4049 which runs under unix.
4050 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4052 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4053 when there are no test failures to be parsed
4055 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4056 instead of the unix-specific os.system("cp"), thanks to Elliot
4057 Murphy for this and the other buildbot-vs-windows catches.
4058 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4060 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4061 echo the command as it is run
4063 * setup.py: install sample.mk too, not just sample.cfg
4064 (scripts): install contrib/windows/buildbot.bat on windows
4066 2004-11-07 Brian Warner <warner@lothar.com>
4068 * buildbot/process/builder.py (Builder._detached): clear the
4069 self.currentBuild reference, otherwise the next build will be
4070 skipped because we think the Builder is already in use.
4072 * docs/examples/twisted_master.cfg: update to match current usage
4073 on the Twisted buildbot
4075 2004-10-29 Brian Warner <warner@lothar.com>
4077 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4079 2004-10-28 Brian Warner <warner@lothar.com>
4081 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4082 have separate doVCUpdate/doVCFull methods. Catch an update failure
4083 and respond by clobbering the source directory and re-trying. This
4084 will handle local changes (like replacing a file with a directory)
4085 that will cause CVS and SVN updates to fail.
4086 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4088 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4091 2004-10-19 Brian Warner <warner@lothar.com>
4093 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4095 * buildbot/status/html.py (StatusResourceTestResults): display any
4096 TestResults that the Build might have
4097 (StatusResourceTestResult): and the logs for each TestResult
4098 (StatusResourceBuild): add link from the per-build page
4100 2004-10-15 Brian Warner <warner@lothar.com>
4102 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4103 the 'problems' portion of stdout, add TestResults to our build
4104 * buildbot/test/test_twisted.py (Parse.testParse): test it
4106 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4107 to retrieve a dict of accumulated test results
4108 (ITestResult): define what a single test result can do
4109 * buildbot/status/builder.py (TestResult): implement ITestResult
4110 (BuildStatus.getTestResults): retrieve dict of TestResults
4111 (BuildStatus.addTestResult): add TestResults
4112 * buildbot/test/test_status.py (Results.testAddResults): test it
4114 2004-10-14 Brian Warner <warner@lothar.com>
4116 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4117 instead of os.system("rm -rf") for win32 portability
4119 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4120 SignalMixin instead of starting/stopping the reactor, which is
4121 likely to cause problems with other tests
4123 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4124 self.copyComplete() call. Yoz Grahame makes the catch.
4126 * contrib/windows/buildbot.bat: helper script to deal with path
4127 issues. Thanks to Yoz Grahame.
4129 * buildbot/master.py (BuildMaster.startService): don't register a
4130 SIGHUP handler if the signal module has no SIGHUP attribute.
4131 Apparently win32 does this.
4133 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4135 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4136 test if the reactor can't offer UNIX sockets
4138 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4139 error introduced in the last commit. We really need that
4142 2004-10-12 Brian Warner <warner@lothar.com>
4144 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4145 when describing a maildir source. Thanks to Stephen Davis.
4147 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4150 * buildbot/scripts/runner.py (createMaster): install Makefile too
4151 (start): add --no_save to 'start' command
4152 * buildbot/scripts/sample.mk: simple convenience Makefile with
4153 start/stop/reload targets
4155 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4158 2004-09-30 Brian Warner <warner@lothar.com>
4160 * setup.py: Releasing buildbot-0.6.0
4162 2004-09-30 Brian Warner <warner@lothar.com>
4164 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4165 test_trial.py from the source tarball until support is complete.
4167 * NEWS: update for 0.6.0 release
4168 * buildbot/__init__.py (version): same
4171 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4172 'source' command to tell users where to get the Buildbot source
4174 * docs/examples/*.cfg: update to modern standards
4176 * NEWS: update for release
4178 * buildbot/scripts/runner.py (createMaster): remove the
4179 -shutdown.tap stuff now that it isn't necessary
4181 (start): launch buildbot.tap, not buildbot-shutdown.tap
4184 * buildbot/status/mail.py (Domain): shorten class name
4185 (MailNotifier): if lookup= is a string, pass it to Domain()
4186 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4187 (Mail.testBuild2): test the string-to-Domain shortcut
4188 (Mail.testMail): fix test
4191 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4194 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4195 more attributes on load
4196 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4197 to accomodate the whole waterfall page at once, and the thrashing
4198 results in a lot of unnecessary loads
4199 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4200 (BuilderStatus.saveYourself): same
4201 (BuilderStatus.eventGenerator): stop generating on the first missing
4202 build. We assume that saved builds are deleted oldest-first.
4203 (BuildStepStatus.__getstate__): .progress might not exist
4205 * buildbot/changes/changes.py (ChangeMaster): make it
4206 serializable, in $masterdir/changes.pck
4207 (ChangeMaster.stopService): save on shutdown
4208 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4209 * buildbot/test/test_config.py: load Changes before config file
4212 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4213 "Oh my god, you killed the command" header on a separate line
4215 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4216 skip over corrupted build pickles
4217 (BuilderStatus.getFullBuildByNumber): same
4218 (BuilderStatus.eventGenerator): skip over unavailable builds
4219 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4220 do an atomic rename. This prevents a corrupted pickle when some
4221 internal serialization error occurs.
4222 (BuilderStatus.saveYourself): same
4224 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4225 the timeout for shell commands, it got lost somehow
4227 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4228 run out of build steps, return the rest of the builder events
4230 * buildbot/interfaces.py (IBuilderControl.ping): add method
4232 * buildbot/process/builder.py (BuilderControl.ping): move
4233 slave-ping to BuilderControl, and fix the failure case in the
4234 process (Event.finish() is the verb, Event.finished is the noun).
4236 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4237 through the BuilderControl instead of the BuilderStatus
4238 (EventBox): add adapter for builder.Event, allowing builder events to
4239 be displayed in the waterfall display
4241 * buildbot/master.py (BotMaster.stopService): add a 'master
4242 shutdown' event to the builder's log
4243 (BuildMaster.startService): and a 'master started' on startup
4245 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4246 builder events into the BuildStep event stream
4247 (Status.builderAdded): add a 'builder created' event
4250 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4251 command to announce the completion of a running build
4252 (IrcStatusBot.command_FORCE): announce when the build finishes
4254 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4255 don't evict unfinished builds from the cache: they must stay in
4256 the full-cache until their logfiles have stopped changing. Make
4257 sure the eviction loop terminates if an unfinished build was hit.
4258 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4259 This lets exceptions be dumped in an email status message. Really
4260 we need LogFiles which contain both text and HTML, instead of two
4262 (BuildStatus.__getstate__): handle self.finished=False
4263 (Status.builderAdded): if the pickle is corrupted, abandon the
4264 history and create a new BuilderStatus object.
4266 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4267 self.progress attribute, helped one test which doesn't fully set
4268 up the Build object.
4270 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4271 IStatusLog methods into an Interface that is implemented by "stub"
4272 logs, for which all the actual text chunks are on disk (in the
4273 pickled Build instance). To show the log contents, you must first
4274 adapt the stub log to a full IStatusLog object.
4276 * buildbot/status/builder.py (LogFileStub): create separate stub
4277 log objects, which can be upgraded to a real one if necessary.
4278 (LogFile): make them persistable, and let them stubify themselves
4280 (BuildStepStatus): same
4282 (BuildStatus.saveYourself): save the whole build out to disk
4283 (BuilderStatus): make it persistable
4284 (BuilderStatus.saveYourself): save the builder to disk
4285 (BuilderStatus.addFullBuildToCache): implement two caches which
4286 hold Build objects: a small one which holds full Builds, and a
4287 larger one which holds "stubbed" Builds (ones with their LogFiles
4288 turned into LogFileStubs). This reduces memory usage by the
4289 buildmaster by not keeping more than a few (default is 2) whole
4290 build logs in RAM all the time.
4291 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4293 (BuilderStatus.eventGenerator): rewrite since .builds went away
4294 (BuilderStatus.buildStarted): remove the .builds array. Add the
4295 build to the "full" cache when it starts.
4296 (BuilderStatus._buildFinished): save the build to disk when it
4298 (Status): give it a basedir (same as the BuildMaster's basedir)
4299 where the builder pickles can be saved
4300 (Status.builderAdded): create the BuilderStatus ourselves, by
4301 loading a pickle from disk (or creating a new instance if there
4302 was none on disk). Return the BuilderStatus so the master can glue
4303 it into the new Builder object.
4305 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4306 all BuilderStatuses to save themselves out to disk. This is in
4307 lieu of saving anything important in the main Application pickle
4308 (the -shutdown.tap file).
4309 (BuildMaster.__init__): give Status() a basedir for its files
4310 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4311 to get the BuilderStatus, then give it to the Builder (instead of
4312 doing it the other way around). It's ok if the status announces
4313 the new Builder before it's really ready, as the outside world can
4314 only see the BuilderStatus object anyway (and it is ready before
4315 builderAdded returns). Use the builder's "builddir" (which
4316 normally specifies where the slave will run the builder) as the
4317 master's basedir (for saving serialized builds).
4319 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4320 coerce the logfile to IStatusLog before trying to get the text
4321 chunks out of it. This will pull the full (non-stubified) Build in
4322 from disk if necessary.
4323 (TextLog): fix the adapter registration
4325 * buildbot/test/test_control.py (Force.setUp): create the basedir
4326 * buildbot/test/test_web.py: same
4327 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4328 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4329 * buildbot/test/test_run.py (Run.testMaster): same
4330 (Status.setUp): same
4332 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4334 * buildbot/status/html.py (Waterfall.__init__): store actual
4335 allowForce flag passed in rather than using True for everyone;
4336 make sure setting it to False doesn't cause a NameError
4338 (StatusResourceBuilder.__init__) add the builder name to the page
4340 (StatusResourceBuilder.body) move HTML generation for a name/value
4341 row into a helper method (StatusResourceBuilder.make_row); only
4342 generate the "Force Build" form if allowForce was True and the
4343 slave is connected. Use class attributes in the generated HTML to
4344 spread a little CSS-joy.
4346 2004-09-28 Brian Warner <warner@lothar.com>
4348 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4349 warning-scanner to not ignore things like
4350 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4352 * buildbot/status/html.py (StatusResource.control): add some
4353 class-level values for .control in an attempt to make upgrading
4356 * buildbot/util.py (ComparableMixin): survive missing attributes,
4357 such as when a class is modified and we're comparing old instances
4360 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4361 failure handling, remove a redundant try/except block. Don't
4362 return the full traceback to the IRC channel.
4363 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4364 error messages. Get ETA properly.
4366 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4367 the reason, since (at least) IRC message will have <> in them.
4368 (StatusResourceBuilder.__init__): take an IBuilderControl
4369 (StatusResourceBuilder.force): use the IBuilderControl we get in
4370 the constructor instead of trying to make our own. Catch the
4371 new exceptions and ignore them for now (until we make an
4372 intermediate web page where we could show the error message)
4373 (StatusResource): create with an IControl, use it to give an
4374 IBuilderControl to all children
4375 (Waterfall): take an allowForce= option, pass an IControl object
4376 to StatusResource if it is True
4378 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4380 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4381 catch new exceptions and return string forms
4383 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4384 * buildbot/process/builder.py (Builder.forceBuild): raise them
4385 * buildbot/test/test_control.py (Force.testNoSlave): new test
4386 (Force.testBuilderInUse): same
4389 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4391 * buildbot/test/test_run.py: use IControl
4392 * buildbot/test/test_vc.py: same
4394 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4395 to use IControl. Still offline.
4396 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4398 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4399 who=None so periodic builds don't send out status mail
4400 (Builder.forceBuild): include reason in the log message
4401 (BuilderControl.forceBuild): rename 'name' to 'who'
4403 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4404 'who' parameter, but make it None by default so builds forced by
4405 slave admins don't cause status mail to be sent to anybody
4406 (BotMaster.forceBuild): same. this method is deprecated.
4407 (DebugPerspective.perspective_forceBuild): same, use IControl.
4408 (DebugPerspective.perspective_fakeChange): use IControl..
4409 (Dispatcher.requestAvatar): .. so don't set .changemaster
4411 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4412 parameter to avoid confusion with the name of the builder
4415 * buildbot/status/mail.py: refine comment about needing 2.3
4417 * buildbot/status/html.py: move all imports to the top
4419 * buildbot/test/test_control.py: test new interfaces
4420 * buildbot/test/test_run.py (Status): handle new interfaces
4421 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4423 * buildbot/process/base.py (BuildControl): implement IBuildControl
4424 and its lonely getStatus() method
4426 * buildbot/process/builder.py (BuilderControl): implement
4427 IBuilderControl, obtained by adapting the Builder instance
4428 (Builder.startBuild): return a BuilderControl instead of a
4429 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4430 accomplish the same thing.
4432 * buildbot/master.py: move all import statements to the top
4433 (Control): implement IControl, obtained by adapting the
4434 BuildMaster instance.
4436 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4437 IBuildControl. These are used to force builds. Eventually they
4438 will provide ways to reconfigure the Builders, pause or abandon a
4439 Build, and perhaps control the BuildMaster itself.
4441 2004-09-26 Brian Warner <warner@lothar.com>
4443 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4444 ends up comparing us against something without a .__class__
4446 2004-09-24 Brian Warner <warner@lothar.com>
4448 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4451 * Makefile: add 'deb-snapshot' target, to create a timestamped
4454 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4456 2004-09-23 Brian Warner <warner@lothar.com>
4458 * buildbot/__init__.py (version): move version string here
4459 * setup.py: get version string from buildbot.version
4460 * buildbot/status/html.py (WaterfallStatusResource.body): add
4461 buildbot version to the page footer
4462 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4465 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4466 slaves, let the second know where the first one is coming from
4467 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4468 see our exceptions. It would be nice if there were a way to just
4469 send them the exception type and value, not the full traceback.
4472 * buildbot/status/mail.py (MailNotifier): add a new argument
4473 sendToInterestedUsers=, which can be set to False to disable the
4474 usual send-to-blamelist behavior.
4475 (top): handle python-2.2 which has no email.MIMEMultipart
4476 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4477 (MailNotifier.disownServiceParent): unsubscribe on removal
4479 * buildbot/test/test_status.py (Mail.testBuild2): test it
4482 * buildbot/status/progress.py (Expectations.wavg): tolerate
4483 current=None, which happens when steps start failing badly
4484 * buildbot/test/test_status.py (Progress.testWavg): test for it
4486 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4487 doesn't understand args['revision'], emit a warning instead of
4488 bailing completely. Updating to -rHEAD is probably close enough.
4490 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4492 * buildbot/test/test_status.py: at least import bb.status.client
4493 even if we don't have any test coverage for it yet
4495 * contrib/svn_buildbot.py: don't require python2.3
4496 (main): wait, do require it (for sets.py), but explain how to
4497 make it work under python2.2
4499 2004-09-23 Brian Warner <warner@lothar.com>
4501 * contrib/svn_buildbot.py: include the revision number in the Change
4503 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4504 using util.now() because FreshCVS is a realtime service
4506 * buildbot/status/event.py: delete dead code
4507 * buildbot/process/step.py: don't import dead Event class
4508 * buildbot/process/step_twisted.py: same
4509 * buildbot/status/builder.py: same
4510 * buildbot/status/client.py: same
4512 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4514 * buildbot/changes/changes.py (Change): set .when from an __init__
4515 argument (which defaults to now()), rather than having
4516 ChangeMaster.addChange set it later.
4517 (ChangeMaster.addChange): same
4519 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4520 (parseSyncmail): same. Just use util.now() for now.
4521 (parseBonsaiMail): parse the timestamp field for when=
4523 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4524 instead of setting .when after the fact
4528 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4529 results when the target project uses retrial. Still under
4531 * buildbot/test/test_trial.py: same
4533 2004-09-21 Brian Warner <warner@lothar.com>
4535 * buildbot/status/mail.py (MailNotifier.__init__): include
4536 success/warnings/failure in the Subject line
4537 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4538 use step.logname for the addLogs=True attachment filenames
4539 * buildbot/test/test_status.py (Mail): test Subject lines
4540 (Mail.testLogs): test attachment filenames
4542 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4543 accept a 'who' argument from the debug tool
4544 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4545 * contrib/debug.glade: add text box to set 'who'
4547 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4548 .getBuilderName with .getBuilder().getName(), more flexible
4549 (IStatusLog.getName): logs have short names, but you can prefix
4550 them with log.getStep().getName() to make them more useful
4551 * buildbot/status/builder.py: same
4552 * buildbot/status/client.py: same
4553 * buildbot/status/html.py: same
4554 * buildbot/test/test_run.py (Status.testSlave): same
4555 * buildbot/process/step.py: tweak logfile names
4557 * buildbot/status/mail.py (MailNotifier): add lookup, change
4558 argument to extraRecipients. The notifier is now aimed at sending
4559 mail to the people involved in a particular build, with additional
4560 constant recipients as a secondary function.
4562 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4563 including slow-lookup and failing-lookup. Make sure the blamelist
4564 members are included.
4566 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4567 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4568 (IBuildStatus.getInterestedUsers): new method
4569 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4570 * buildbot/status/client.py (remote_getResponsibleUsers): same
4571 * buildbot/status/html.py (StatusResourceBuild.body): same
4572 * buildbot/test/test_run.py (Status.testSlave): same
4574 2004-09-20 Brian Warner <warner@lothar.com>
4576 * docs/users.xhtml: update concepts
4578 * Makefile: add a convenience makefile, for things like 'make
4579 test'. It is not included in the source tarball.
4581 2004-09-16 Brian Warner <warner@lothar.com>
4583 * NEWS: mention /usr/bin/buildbot, debian/*
4585 * debian/*: add preliminary debian packaging. Many thanks to
4586 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4587 it considerably since it left their hands, I am responsible for
4588 all breakage that's resulted.
4590 * bin/buildbot: create a top-level 'buildbot' command, to be
4591 installed in /usr/bin/buildbot . For now it's just a simple
4592 frontend to mktap/twistd/kill, but eventually it will be the entry
4593 point to the 'try' command and also a status client. It is also
4594 intended to support the upcoming debian-packaging init.d scripts.
4595 * buildbot/scripts/runner.py: the real work is done here
4596 * buildbot/scripts/__init__.py: need this too
4597 * buildbot/scripts/sample.cfg: this is installed in new
4598 buildmaster directories
4599 * setup.py: install new stuff
4601 2004-09-15 Brian Warner <warner@lothar.com>
4603 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4604 'file:' schema (the version shipped with OS-X was built without the
4606 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4607 updates the log-timestamp, to make sure it isn't still running after
4610 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4611 values to the config file.
4612 * docs/examples/hello.cfg: add examples
4613 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4614 * buildbot/status/builder.py (Status.getProjectURL): implement them
4615 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4616 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
4617 * buildbot/status/html.py (WaterfallStatusResource): display them
4620 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
4621 certain error cases don't suffer a secondary exception.
4622 (top): Skip tests if the corresponding VC tool is not installed.
4624 * buildbot/process/factory.py (Trial): introduce separate
4625 'buildpython' and 'trialpython' lists, since trialpython=[] is
4626 what you want to invoke /usr/bin/python, whereas ./setup.py is
4627 less likely to be executable. Add env= parameter to pass options
4628 to test cases (which is how I usually write tests, I don't know if
4629 anyone else does it this way).
4631 * buildbot/process/step_twisted.py (Trial): handle python=None.
4632 Require 'testpath' be a string, not a list. Fix tests= typo.
4633 (Trial.start): sanity-check any PYTHONPATH value for stringness.
4635 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
4636 way to deal with the possibility of removing the disconnect notify
4638 (CVS): add a 'login' parameter to give a password to 'cvs login',
4639 commonly used with pserver methods (where pw="" or pw="guest")
4641 * buildbot/slave/commands.py (SourceBase): move common args
4642 extraction and setup() to __init__, so everything is ready by the
4643 time setup() is called
4644 (CVS.start): call 'cvs login' if a password was supplied
4645 (ShellCommand): special-case PYTHONPATH: prepend the master's
4646 value to any existing slave-local value.
4648 * buildbot/process/builder.py (Builder.updateBigStatus): if we
4649 don't have a remote, mark the builder as Offline. This whole
4650 function should probably go away and be replaced by individual
4652 (Builder.buildFinished): return the results to the build-finished
4653 deferred callback, helps with testing
4655 2004-09-14 Brian Warner <warner@lothar.com>
4657 * buildbot/test/test_vc.py: put all the repositories needed to run
4658 the complete tests into a single small (1.3MB) tarball, so I can
4659 make that tarball available on the buildbot web site. Test HTTP
4660 access (for Arch and Darcs) by spawning a temporary web server
4661 while the test runs.
4663 * docs/users.xhtml: new document, describe Buildbot's limited
4664 understanding of different human users
4666 * buildbot/test/test_vc.py: rearrange test cases a bit
4668 * buildbot/process/step_twisted.py (Trial): handle testpath=
4669 * buildbot/process/factory.py (Trial): update to use step.Trial
4671 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
4673 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
4674 the overall build text (which gives you 'failed 2 tests' rather
4676 (BuildStepStatus.text2): default to [], not None
4678 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
4681 2004-09-12 Brian Warner <warner@lothar.com>
4683 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
4684 log the whole exception if it's just an AttributeError (old slave)
4686 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
4687 so (e.g.) sub-commands can be run in the right directory.
4688 (ShellCommand.start): accept an optional errorMessage= argument
4689 to make life easier for SVN.start
4690 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
4692 (ShellCommand.start): move ['dir'] compatibility hack..
4693 (RemoteShellCommand.start): .. to here so everyone can use it
4695 * buildbot/process/step_twisted.py (Trial): use .workdir
4697 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
4698 text displayed when debuild fails completely
4699 (Trial): snarf _trial_temp/test.log from the slave and display it
4701 2004-09-11 Brian Warner <warner@lothar.com>
4703 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
4705 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
4706 set to 'twisted', so --recurse can find twisted/web/test/*, etc
4708 * buildbot/process/step.py (ShellCommand): call .createSummary
4709 before .evaluateCommand instead of the other way around. This
4710 makes it slightly easier to count warnings and then use that to
4711 set results=WARNINGS
4712 * buildbot/process/step_twisted.py: cosmetic, swap the methods
4714 * buildbot/process/base.py (Build.buildFinished): update status
4715 before doing progress. It's embarrassing for the build to be stuck
4716 in the "building" state when an exceptions occurs elsewhere..
4718 * buildbot/status/progress.py (Expectations.expectedBuildTime):
4719 python2.2 doesn't have 'sum'
4721 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
4722 to prevent clients from accidentally sorting it
4724 * buildbot/master.py (Manhole): add username/password
4725 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
4726 c['manholePort'], deprecate old usage
4727 * docs/config.xhtml: document c['manhole']
4728 * docs/examples/hello.cfg: show example of using a Manhole
4731 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
4732 pretend the slave is up to date
4734 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
4735 the module, overlaps with 'log', the local variable
4737 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
4739 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
4740 new method to let Steps find out the version of their
4741 corresponding SlaveCommand.
4742 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
4743 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
4744 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
4746 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
4747 (Arch.startVC): same
4748 (P4Sync.startVC): same
4750 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
4751 Deferred so we can catch errors in remote_startCommand
4752 (RemoteShellCommand.start): same
4754 * docs/examples/twisted_master.cfg: update sample config file
4756 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
4757 after connectionMade() is called, not before. Close stdin at that
4760 * buildbot/process/process_twisted.py: update to use Trial, clean
4761 up argument passing (move to argv arrays instead of string
4764 * buildbot/process/step_twisted.py (Trial): new step to replace
4765 RunUnitTests, usable by any trial-using project (not just
4766 Twisted). Arguments have changed, see the docstring for details.
4768 * buildbot/process/base.py (Build.startBuild): this now returns a
4769 Deferred. Exceptions that occur during setupBuild are now
4770 caught better and lead to fewer build_status weirdnesses, like
4771 finishing a build that was never started.
4772 (Build.buildFinished): fire the Deferred instead of calling
4773 builder.buildFinished directly. The callback argument is this
4774 Build, everything else can be extracted from it, including the
4775 new build.results attribute.
4776 * buildbot/process/builder.py (Builder.startBuild): same
4777 (Builder.buildFinished): same, extract results from build
4779 * buildbot/process/step.py (ShellCommands): remove dead code
4781 2004-09-08 Brian Warner <warner@lothar.com>
4783 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
4784 doesn't try to use the leftover patched workdir
4785 (SourceStamp): test source-stamp computation for CVS and SVN
4787 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
4788 patched workdir ('touch .buildbot-patched') so we don't try to
4790 (SourceBase.start): add ['revision'] for all Source steps
4791 (CVS): change args: use ['branch'] for -r, remove ['files']
4792 (CVS.buildVC): fix revision/branch stuff
4793 (SVN): add revision stuff
4795 * buildbot/process/step.py (BuildStep.__init__): reject unknown
4796 kwargs (except 'workdir') to avoid silent spelling errors
4797 (ShellCommand.__init__): same
4798 (Source): new base class for CVS/SVN/etc. Factor out everything
4799 common, add revision computation (perform the checkout with a -D
4800 DATE or -r REVISION that gets exactly the sources described by the
4801 last Change), overridable with step.alwaysUseLatest. Add patch
4802 handling (build.getSourceStamp can trigger the use of a base
4803 revision and a patch).
4804 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
4805 * docs/steps.xhtml: update docs
4806 * docs/source.xhtml: mention .checkoutDelay
4807 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
4809 * buildbot/process/base.py (Build.setSourceStamp): add a
4810 .sourceStamp attribute to each Build. If set, this indicates that
4811 the build should be done with something other than the most
4812 recent source tree. This will be used to implement "try" builds.
4813 (Build.allChanges): new support method
4814 (Build.lastChangeTime): remove, functionality moved to Source steps
4815 (Build.setupBuild): copy the Step args before adding ['workdir'],
4816 to avoid modifying the BuildFactory (and thus triggering spurious
4820 * buildbot/status/html.py: rename s/commits/changes/
4821 (StatusResourceChanges): same
4822 (CommitBox.getBox): same, update URL
4823 (WaterfallStatusResource): same
4824 (StatusResource.getChild): same
4826 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
4827 * contrib/debug.glade: add optional 'revision' to the fakeChange
4829 * buildbot/changes/changes.py (html_tmpl): display .revision
4830 (ChangeMaster.addChange): note .revision in log
4831 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
4832 accept a ['revision'] attribute
4834 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
4836 * buildbot/master.py (BotMaster.getPerspective): update the
4837 .connected flag in SlaveStatus when it connects
4838 (BotMaster.detach): and when it disconnects
4839 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
4840 (BuildMaster.loadConfig_Builders): walk old list correctly
4842 * buildbot/test/test_config.py: fix prefix= usage
4844 2004-09-06 Brian Warner <warner@lothar.com>
4848 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
4849 poll a P4 depot looking for recent changes. Thanks to Dave
4850 Peticolas for the contribution. Probably needs some testing after
4853 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
4854 requires manual client setup for each buildslave. Rather
4855 experimental. Thanks again to Dave Peticolas.
4856 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
4858 * buildbot/changes/changes.py (Change): add a .revision attribute,
4859 which will eventually be used to generate source-stamp values.
4861 * buildbot/process/step.py (RemoteCommand.start): use
4862 notifyOnDisconnect to notice when we lose the slave, then treat it
4863 like an exception. This allows LogFiles to be closed and the build
4864 to be wrapped up normally. Be sure to remove the disconnect
4865 notification when the step completes so we don't accumulate a
4866 bazillion such notifications which will fire weeks later (when the
4867 slave finally disconnects normally). Fixes SF#915807, thanks to
4868 spiv (Andrew Bennetts) for the report.
4869 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
4870 really isn't Logged- specific
4871 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
4872 header, since it's almost always going to be appended to an
4874 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
4875 update test to handle use of notifyOnDisconnect
4877 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
4878 don't clear .ETA and .currentBuild when going offline, let the
4879 current build clean up after itself
4881 * buildbot/process/builder.py (Builder.detached): wait a moment
4882 before doing things like stopping the current build, because the
4883 current step will probably notice the disconnect and cleanup the
4885 * buildbot/test/test_run.py (Status.tearDown): update test to
4886 handle asynchronous build-detachment
4888 * buildbot/process/base.py (Build.stopBuild): minor shuffles
4890 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
4891 hush a debug message
4893 2004-09-05 Brian Warner <warner@lothar.com>
4895 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
4896 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
4897 kernels do this: the fcntl module has the F_NOTIFY constant, but
4898 the kernel itself doesn't support the operation. Thanks to Olly
4899 Betts for spotting the problem.
4901 * buildbot/process/step.py (Darcs): new source-checkout command
4902 (Arch): new source-checkout command
4903 (todo_P4): fix constructor syntax, still just a placeholder
4904 * buildbot/test/test_vc.py (VC.testDarcs): test it
4905 (VC.testDarcsHTTP): same, via localhost HTTP
4907 (VC.testArchHTTP): same
4908 * NEWS: mention new features
4910 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
4911 which tells the step to stash stdout text locally (in .stdout).
4912 Slave-side Commands can use this to make decisions based upon the
4913 output of the the ShellCommand (not just the exit code).
4914 (Darcs): New source-checkout command
4915 (Arch): New source-checkout command, uses .keepStdout in one place
4916 where it needs to discover the archive's default name.
4918 * docs/steps.xhtml: Document options taken by Darcs and Arch.
4919 * docs/source.xhtml: add brief descriptions of Darcs and Arch
4920 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
4922 * buildbot/process/step.py (ShellCommand.describe): add an
4923 alternate .descriptionDone attribute which provides descriptive
4924 text when the step is complete. .description can be ["compiling"],
4925 for use while the step is running, then .descriptionDone can be
4926 ["compile"], used alone when the step succeeds or with "failed" when
4927 it does not. Updated other steps to use the new text.
4928 * buildbot/process/step_twisted.py: same
4929 * buildbot/test/test_run.py: update tests to match
4931 2004-08-30 Brian Warner <warner@lothar.com>
4933 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
4934 (CVS.__init__): send 'patch' argument to slave
4935 (CVS.start): don't create the LoggedRemoteCommand until start(),
4936 so we can catch a .patch added after __init__
4937 (SVN.__init__): add 'patch' to SVN too
4940 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
4941 argument, to let commands push data into the process' stdin pipe.
4942 Move usePTY to a per-instance attribute, and clear it if 'stdin'
4943 is in use, since closing a PTY doesn't really affect the process
4944 in the right way (in particular, I couldn't run /usr/bin/patch
4946 (SourceBase.doPatch): handle 'patch' argument
4948 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
4951 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
4952 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
4954 * buildbot/master.py (BotPerspective.got_commands): get command
4955 versions from slave, give to each builder
4956 * buildbot/process/builder.py (Builder.attached): stash slave
4957 command versions in .remoteCommands
4959 * docs/steps.xhtml: bring docs in-line with reality
4961 * buildbot/process/step.py (CVS.__init__): more brutal
4962 compatibility code removal
4963 (SVN.__init__): same
4965 * buildbot/slave/commands.py (SlaveShellCommand): update docs
4966 (SlaveShellCommand.start): require ['workdir'] argument, remove
4967 the ['dir'] fallback (compatibility will come later)
4968 (SourceBase): update docs
4969 (SourceBase.start): remove ['directory'] fallback
4972 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
4973 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
4974 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
4976 * buildbot/process/step.py (RemoteShellCommand.__init__): add
4977 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
4978 code.. I will figure out 0.5.0-compatibility hooks later)
4980 2004-08-30 Brian Warner <warner@lothar.com>
4982 * buildbot/process/process_twisted.py: rewrite in terms of new
4983 BuildFactory base class. It got significantly shorter. Yay
4986 * buildbot/process/step_twisted.py (HLint.start): fix to make it
4987 work with the new "self.build isn't nailed down until we call
4988 step.start()" scheme: specifically, __init__ is called before the
4989 build has decided on which Changes are going in, so we don't scan
4990 build.allFiles() for .xhtml files until start()
4991 (HLint.commandComplete): use getText(), not getStdout()
4992 (RunUnitTests.start): same: don't use .build until start()
4993 (RunUnitTests.describe): oops, don't report (None) when using
4995 (RunUnitTests.commandComplete): use getText()
4996 (RunUnitTests.createSummary): same
4997 (BuildDebs.commandComplete): same
4999 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5000 set args['command'] until start(), since our BuildStep is allowed
5001 to change their mind up until that point
5002 (TreeSize.commandComplete): use getText(), not getStdout()
5004 * docs/examples/twisted_master.cfg: update to current standards
5006 * docs/factories.xhtml: update
5007 * buildbot/process/factory.py: implement all the common factories
5008 described in the docs. The Trial factory doesn't work yet, and
5009 I've probably broken all the process_twisted.py factories in the
5010 process. There are compatibility classes left in for things like
5011 the old BasicBuildFactory, but subclasses of them are unlikely to
5013 * docs/examples/glib_master.cfg: use new BuildFactories
5014 * docs/examples/hello.cfg: same
5016 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5017 explicit 'workdir' args
5019 * buildbot/process/base.py (BuildFactory): move factories to ..
5020 * buildbot/process/factory.py (BuildFactory): .. here
5021 * buildbot/process/process_twisted.py: handle move
5022 * buildbot/test/test_config.py: same
5023 * buildbot/test/test_run.py: same
5024 * buildbot/test/test_steps.py: same
5025 * buildbot/test/test_vc.py: same
5026 * docs/factories.xhtml: same
5028 * NEWS: mention config changes that require updating master.cfg
5030 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5031 argument to all steps that weren't given one already, pointing at
5032 the "build/" directory.
5034 * docs/examples/hello.cfg: remove explicit 'workdir' args
5036 * docs/factories.xhtml: document standard BuildFactory clases,
5037 including a bunch which are have not yet been written
5039 2004-08-29 Brian Warner <warner@lothar.com>
5041 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5042 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5043 buildbot.status.builder so they aren't quite so internal
5044 * buildbot/process/base.py, buildbot/process/builder.py: same
5045 * buildbot/process/maxq.py, buildbot/process/step.py: same
5046 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5047 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5048 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5050 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5051 to handle new getLogs()-returns-list behavior
5052 (StatusResourceBuildStep.getChild): same
5053 (StepBox.getBox): same
5054 (WaterfallStatusResource.phase0): same
5056 * docs/source.xhtml: document how Buildbot uses version-control
5057 systems (output side: how we get source trees)
5058 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5059 systems (input side: how we learn about Changes)
5061 * buildbot/master.py (Manhole): use ComparableMixin
5062 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5063 * buildbot/changes/mail.py (MaildirSource): same
5064 * buildbot/status/client.py (PBListener): same
5065 * buildbot/status/html.py (Waterfall): same
5066 * buildbot/status/words.py (IRC): same
5068 * NEWS: start describing new features
5070 * buildbot/status/mail.py (MailNotifier): finish implementation.
5071 The message body is still a bit sparse.
5072 * buildbot/test/test_status.py (Mail): test it
5074 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5075 and __hash__ methods I wind up adding everywhere. Specifically
5076 intended to support the buildbot config-file update scheme where
5077 we compare, say, the old list of IStatusTargets against the new
5078 one and don't touch something which shows up on both lists.
5079 * buildbot/test/test_util.py (Compare): test case for it
5081 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5082 return a list instead of a dict
5083 (IBuildStepStatus.getLogs): same. The idea is that steps create
5084 logs with vaguely unique names (although their uniqueness is not
5085 guaranteed). Thus a compilation step should create its sole
5086 logfile with the name 'compile', and contribute it to the
5087 BuildStatus. If a step has two logfiles, try to create them with
5088 different names (like 'test.log' and 'test.summary'), and only
5089 contribute the important ones to the overall BuildStatus.
5090 * buildbot/status/builder.py (Event.getLogs): same
5091 (BuildStepStatus): fix default .text and .results
5092 (BuildStepStatus.addLog): switch to list-like .getLogs()
5093 (BuildStepStatus.stepFinished): same
5094 (BuildStatus.text): fix default .text
5095 (BuildStatus.getLogs): temporary hack to return all logs (from all
5096 child BuildStepStatus objects). Needs to be fixed to only report
5097 the significant ones (as contributed by the steps themselves)
5098 * buildbot/test/test_run.py: handle list-like .getLogs()
5099 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5101 2004-08-28 Brian Warner <warner@lothar.com>
5103 * buildbot/process/builder.py (Builder.attached): serialize the
5104 attachment process, so the attach-watcher isn't called until the
5105 slave is really available. Add detached watchers too, which makes
5108 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5110 * buildbot/test/test_swap.py: remove dead code
5112 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5113 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5114 sort of as if the command being run exited with a -1. There may
5115 still be some holes in this scheme.
5116 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5117 -r option appears before the module list
5118 * buildbot/process/step.py (CVS): add 'revision' argument
5120 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5121 when sending updates or stepComplete messages to the master, since
5122 we don't currently care whether they arrive or not. When we revamp
5123 the master/slave protocol to really resume interrupted builds,
5124 this will need revisiting.
5125 (lostRemote): remove spurious print
5127 * buildbot/master.py (BotPerspective.attached): serialize the
5128 new-builder interrogation process, to make testing easier
5129 (BotMaster.waitUntilBuilderDetached): convenience function
5131 * buildbot/status/builder.py (BuilderStatus): prune old builds
5132 (BuildStatus.pruneSteps): .. and steps
5133 (BuildStepStatus.pruneLogs): .. and logs
5134 (BuilderStatus.getBuild): handle missing builds
5135 * buildbot/status/html.py (StatusResourceBuild.body): display build
5136 status in the per-build page
5137 (BuildBox.getBox): color finished builds in the per-build box
5139 2004-08-27 Brian Warner <warner@lothar.com>
5141 * buildbot/status/mail.py (MailNotifier): new notification class,
5144 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5145 variants of a common base class which handles all the mode= logic
5147 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5149 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5151 2004-08-26 Brian Warner <warner@lothar.com>
5153 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5156 * buildbot/test/test_run.py: update to new Logfile interface, new
5157 buildbot.slave modules
5158 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5160 * MANIFEST.in: new sample config file
5161 * docs/examples/hello.cfg: same
5163 * buildbot/process/step_twisted.py: remove dead import
5165 * buildbot/process/step.py (RemoteCommand.run): catch errors
5167 (RemoteCommand.remote_update): ignore updates that arrive after
5169 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5170 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5171 the responsibilities of the subclass's methods
5172 (BuildStep.failed): catch errors during failure processing
5173 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5174 (CVS): move to a mode= argument (described in docstring), rather
5175 than the ungainly clobber=/export=/copydir= combination.
5176 (SVN): add mode= functionality to SVN too
5177 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5179 * buildbot/process/base.py (Build.startNextStep): catch errors
5180 during s.startStep()
5182 * buildbot/clients/base.py: update to new PB client interface.
5183 gtkPanes is still broken
5185 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5186 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5187 * setup.py: add buildbot.slave module
5188 * buildbot/bb_tap.py: handle move
5189 * buildbot/slave/registry.py: place to register commands, w/versions
5190 * buildbot/slave/bot.py: major simplifications
5191 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5192 instead of a fixed table. Eventually this will make the slave more
5193 extensible. Use 'start' method on the command, not .startCommand.
5194 Fix unsafeTracebacks handling (I think).
5195 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5196 helper class with a .start method that returns a Deferred.
5197 SlaveShellCommand is the form reached by the buildmaster. Commands
5198 which use multiple ShellCommands can just chain them as Deferreds,
5199 with some helper methods in Command (_abandonOnFailure and
5200 _checkAbandoned) to bail on rc!=0.
5201 (CVSCommand): prefer new mode= argument
5202 (SVNFetch): add mode= argument
5204 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5205 put a useful reason string on the build
5207 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5208 core functionality into an IStatusLog object
5209 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5210 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5211 (StatusResourceBuild.body): use proper accessor methods
5212 * buildbot/status/client.py (RemoteLog): PB-access goes here
5213 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5214 which delivers log contents too
5215 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5216 * buildbot/status/event.py: remove old Logfile completely
5218 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5219 subscription interface for IStatusLog subscriptions just like all
5220 other the status subscriptions
5221 (IStatusReceiver.logChunk): method called on subscribers
5223 2004-08-24 Brian Warner <warner@lothar.com>
5225 * buildbot/process/builder.py (Builder._pong): oops, ping response
5226 includes a result (the implicit None returned by remote_print).
5227 Accept it so the _pong method handles the response correctly.
5229 2004-08-06 Brian Warner <warner@lothar.com>
5231 * buildbot/test/test_config.py: update IRC, PBListener tests
5233 * buildbot/status/client.py (StatusClientPerspective): total
5234 rewrite to match new IStatus interfaces. New subscription scheme.
5235 There are still a few optimizations to make (sending down extra
5236 information with event messages so the client doesn't have to do a
5237 round trip). The logfile-retrieval code is probably still broken.
5238 Moved the PB service into its own port, you can no longer share a
5239 TCP socket between a PBListener and, say, the slaveport (this
5240 should be fixed eventually).
5241 * buildbot/clients/base.py (Client): revamp to match. still needs
5242 a lot of work, but basic event reporting works fine. gtkPanes is
5245 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5246 instance talks to a single irc server. Threw out all the old
5247 multi-server handling code. Still need to add back in
5248 builder-control (i.e. "force build")
5250 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5251 more random text to the as-yet-unreachable per-step page
5253 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5254 rename to stepETAUpdate
5255 (BuildStatus.subscribe): add build-wide ETA updates
5256 (BuilderStatus.getState): remove more cruft
5257 (BuilderStatus.getCurrentBuild): remove more cruft
5258 (BuilderStatus.buildStarted): really handle tuple-subscription
5259 * buildbot/test/test_run.py (Status.testSlave): handle the
5260 stepETAUpdate rename
5262 * buildbot/master.py (BuildMaster): don't add a default
5263 StatusClientService. Don't add a default IrcStatusFactory. Both
5264 are now added through c['status'] in the config file. c['irc'] is
5265 accepted for backwards compatibility, the only quirk is you cannot
5266 use c['irc'] to specify IRC servers on ports other than 6667.
5268 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5269 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5270 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5271 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5274 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5275 the buildmaster to re-read its config file
5278 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5279 find out the port our server is running on
5280 (WebTest.test_webPathname_port): same
5282 * buildbot/test/test_config.py (testWebPortnum): test it
5283 (testWebPathname): ditto
5285 * docs/config.xhtml: document new c['status'] configuration option
5287 * buildbot/status/html.py (Waterfall): new top-level class which
5288 can be added to c['status']. This creates the Site as well as the
5289 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5290 reachable as .parent, for everything.
5292 * buildbot/master.py (Manhole): make it a normal service Child
5293 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5294 webPathname. It will eventually replace c['irc'] and the implicit
5295 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5296 in as (deprecated) backward compatibility hooks for now.
5299 * buildbot/process/builder.py (Builder.buildFinished): don't
5300 inform out builder_status about a finished build, as it finds out
5301 through its child BuildStatus object
5303 * buildbot/status/html.py: extensive revamp. Use adapters to make
5304 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5305 have both starting and finishing times and adjust the waterfall
5306 display accordingly, using spacers if necessary. Use SlaveStatus
5307 to get buildslave info.
5308 (StatusResourceBuildStep): new just-one-step resource, used to get
5309 logfiles. No actual href to it yet.
5311 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5312 the time being, until I get the file-naming scheme right
5314 * buildbot/status/builder.py (Event): clean started/finished names
5315 (BuildStatus.isFinished): .finished is not None is the right test
5316 (BuildStatus.buildStarted): track started/finished times ourselves
5317 (BuilderStatus.getSlave): provide access to SlaveStatus object
5318 (BuilderStatus.getLastFinishedBuild): all builds are now in
5319 .builds, even the currently-running one. Accomodate this change.
5320 (BuilderStatus.eventGenerator): new per-builder event generator.
5321 Returns BuildStepStatus and BuildStatus objects, since they can
5322 both be adapted as necessary.
5323 (BuilderStatus.addEvent): clean up started/finished attributes
5324 (BuilderStatus.startBuild,finishBuild): remove dead code
5325 (SlaveStatus): new object to provide ISlaveStatus
5327 * buildbot/process/step.py (ShellCommand.getColor): actually
5328 return the color instead of setting it ourselves
5329 (CVS.__init__): pull .timeout and .workdir options out of
5330 **kwargs, since BuildStep will ignore them. Without this neither
5331 will be sent to the slave correctly.
5332 (SVN.__init__): same
5334 * buildbot/process/builder.py (Builder): move flags to class-level
5336 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5337 SlaveStatus handle that
5339 * buildbot/process/base.py (Build.firstEvent): remove dead code
5340 (Build.stopBuild): bugfix
5342 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5344 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5345 (ChangeMaster.eventGenerator): yield Changes, since there are now
5346 Adapters to turn them into HTML boxes
5348 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5349 (BotPerspective.attached): feed a SlaveStatus object
5350 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5351 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5353 * buildbot/interfaces.py: API additions
5354 (ISlaveStatus): place to get slave status
5356 2004-08-04 Brian Warner <warner@lothar.com>
5358 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5359 the delay finishes, so the step is marked as SUCCESS
5361 * buildbot/test/test_run.py (Status.testSlave): cover more of
5362 IBuildStatus and IBuildStepStatus
5364 * buildbot/status/progress.py (StepProgress): move some flags to
5365 class-level attributes
5366 (StepProgress.remaining): if there are no other progress metrics
5367 to go by, fall back to elapsed time
5368 (StepProgress.setExpectations): take a dict of metrics instead of
5370 (BuildProgress.setExpectationsFrom): pull expectations from the
5371 Expectations, instead of having it push them to the BuildProgress
5372 (Expectations): move some flags to class-level attributes
5373 (Expectations.__init__): copy per-step times from the
5375 (Expectations.expectedBuildTime): new method for per-build ETA
5377 * buildbot/status/event.py (Logfile): move some flags to
5378 class-level attributes
5379 (Logfile.logProgressTo): better method name, let step set the
5380 progress axis name (instead of always being "output")
5382 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5383 times directly, rather than depending upon the (possibly missing)
5384 .progress object. Use 'None' to indicate "not started/finished
5386 (BuildStepStatus.getExpectations): oops, return the full list of
5388 (BuilderStatus._buildFinished): append finished builds to .builds
5390 * buildbot/process/step.py (BuildStep): add separate .useProgress
5391 flag, since empty .progressMetrics[] still implies that time is a
5393 (CVS): set up the cmd in __init__, instead of waiting for start()
5395 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5396 calculation, this will eventually turn into a proper sourceStamp
5397 (Build.setupBuild): tell the Progress to load from the Expectations,
5398 instead of having the Expectations stuff things into the Progress
5399 (Build.buildException): add a build-level errback to make sure the
5400 build's Deferred fires even in case of exceptions
5402 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5404 * buildbot/process/builder.py (Builder.forceBuild): convey the
5405 reason instead of creating a fake Change
5407 * docs/examples/twisted_master.cfg: update to match reality
5409 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5410 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5411 fix or remove broken/breaking tests
5413 * buildbot/status/event.py (Logfile.__len__): remove evil method
5415 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5416 missing .build, for test convenience
5418 * buildbot/process/step_twisted.py: import fixes
5420 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5422 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5423 .statusbag reference
5425 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5426 connection at shutdown, and stop it from reconnecting
5428 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5429 chase down remote-execution bugs
5431 * buildbot/process/step.py: more fixes, remove
5432 BuildStep.setStatus()
5433 * buildbot/status/builder.py: move setStatus() functionality into
5435 * buildbot/status/event.py: minor fixes
5437 2004-08-03 Brian Warner <warner@lothar.com>
5439 * buildbot/process/base.py, buildbot/process/builder.py
5440 * buildbot/process/step.py, buildbot/status/builder.py
5441 * buildbot/status/event.py, buildbot/test/test_run.py:
5442 fix status delivery, get a basic test case working
5443 * buildbot/master.py: finish implementing basic status delivery,
5444 temporarily disable HTML/IRC/PB status sources
5446 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5448 * buildbot/status/progress.py (BuildProgress): remove dead code
5450 * buildbot/interfaces.py
5451 * buildbot/process/base.py, buildbot/process/builder.py
5452 * buildbot/process/step.py, buildbot/process/step_twisted.py
5453 * buildbot/status/builder.py: Complete overhaul of the all
5454 status-delivery code, unifying all types of status clients (HTML,
5455 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5456 look like. This commit is a checkpointing of the work-in-progress:
5457 the input side is mostly done (Builders/Builds sending status
5458 to the BuilderStatus/BuildStatus objects), but the output side has
5459 not yet been started (HTML resources querying BuilderStatus
5460 objects). Things are probably very broken right now and may remain
5461 so for several weeks, I apologize for the disruption.
5463 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5464 HTML as the log's contents. Currently used for exception tracebacks.
5465 * buildbot/status/progress.py: minor spelling changes
5467 2004-08-02 Brian Warner <warner@lothar.com>
5469 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5470 in mozilla. Also added stylesheets copied from Twisted's docs.
5471 Remember that these files are meant to be run through Lore first.
5472 Thanks to Philipp Frauenfelder for the fixes.
5473 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5474 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5475 * docs/template.tpl: added a Lore template
5477 2004-07-29 Brian Warner <warner@lothar.com>
5479 * buildbot/interfaces.py: revamp status delivery. This is the
5480 preview: these are the Interfaces that will be provided by new
5481 Builder code, and to which the current HTML/IRC/PB status
5482 displayers will be adapted.
5484 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5485 on the SlaveBuilder, not the Bot.
5486 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5488 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5489 set .usePTY on the FakeSlaveBuilder
5491 2004-07-25 Brian Warner <warner@lothar.com>
5493 * buildbot/changes/freshcvs.py: add some debug log messages
5494 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5495 disabled 'setFilter' syntax
5496 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5497 don't end with a slash
5499 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5501 * setup.py: bump to 0.5.0+ while between releases
5503 2004-07-23 Brian Warner <warner@lothar.com>
5505 * setup.py (version): Releasing buildbot-0.5.0
5507 2004-07-23 Brian Warner <warner@lothar.com>
5509 * README: update for 0.5.0 release
5511 * NEWS: update for 0.5.0 release
5513 2004-07-22 Brian Warner <warner@lothar.com>
5515 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5516 mktap-time configuration flag (--usepty=1, --usepty=0)
5517 * buildbot/bot.py: same
5519 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5520 an 'info' directory being unwanted
5522 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5523 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5524 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5525 and earlier), use a FreshCVSSourceOldcred instead.
5526 (test): simple test routine: connect to server, print changes
5528 * buildbot/changes/changes.py (Change.getTime): make it possible
5529 to print un-timestamped changes
5531 * buildbot/master.py (makeApp): delete ancient dead code
5532 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5533 * buildbot/test/test_config.py (testFindConfigFile): test it
5535 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5536 instead of win32 one
5539 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5540 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5543 * buildbot/process/base.py (Builder.__init__): change constructor
5544 to accept a dictionary of config data, rather than discrete
5545 name/slave/builddir/factory arguments
5547 * docs/examples/twisted_master.cfg: update to new syntax
5548 * docs/examples/glib_master.cfg: same
5549 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5550 rough tests of the new syntax
5553 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5554 to be an int, which means "run a web.distrib sub-server on a TCP
5555 port". This lets you publish the buildbot status page to a remote
5556 twisted.web server (using distrib.ResourceSubscription). Also
5557 rename the local attributes used to hold these web things so
5558 they're more in touch with reality.
5559 * buildbot/test/test_web.py: test webPortnum and webPathname
5560 * docs/config.xhtml: document this new use of webPathname
5562 * docs/config.xhtml: new document, slightly ahead of reality
5564 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5565 'prefix' handling: treat it as a simple string to check with
5566 .startswith, instead of treating it as a directory. This allows
5567 sub-directories to be used. If you use prefix=, you should give it
5568 a string that starts just below the CVSROOT and ends with a slash.
5569 This prefix will be stripped from all filenames, and filenames
5570 which do not start with it will be ignored.
5572 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5574 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5575 and --exclude (inverse of --include). SVN post-commit hooks
5576 now have total control over which changes get sent to buildbot and which
5579 2004-07-10 Brian Warner <warner@lothar.com>
5581 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5582 test case to match new API
5584 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5585 which crashed HTML display when self.entries=[] (needed to
5586 distinguish between [], which means "no entries yet", and None,
5587 which means "the entries have been swapped out to disk, go fetch
5590 2004-07-04 Brian Warner <warner@lothar.com>
5592 * buildbot/process/step_twisted.py (countFailedTests): Count
5593 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5594 10kb from the end because any import errors are wedged there and
5595 they would make us think the test log was unparseable.
5596 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5598 2004-06-26 Brian Warner <warner@lothar.com>
5600 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5601 delete-*.pyc command into an actual BuildStep, so we can label it
5603 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5604 (FullTwistedBuildFactory): same
5606 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5608 * contrib/fakechange.py: Add an errback when sending the fake
5609 change, so we know it didn't work.
5611 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5613 * buildbot/process/step_twisted.py: Delete *.pyc files before
5614 calling trial, so it doesn't catch any old .pyc files whose .py
5615 files have been moved or deleted.
5617 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
5618 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
5619 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
5620 instead of ["twisted.test"], so that the end result is "trial -R
5623 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
5624 regular expression to match filenames that should be ignored when
5625 changed. Also add a --revision parameter that specifies the
5626 revision to examine, which is useful for debugging.
5628 2004-06-25 Brian Warner <warner@lothar.com>
5630 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
5631 summary of warnings (like DeprecationWarnings), next to the
5634 2004-05-13 Brian Warner <warner@lothar.com>
5636 * docs/examples/twisted_master.cfg: enable the win32 builder, as
5637 we now have a w32 build slave courtesy of Mike Taylor.
5639 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
5640 so broken. Fixed a race condition that tripped up interlocked
5641 builds and caused the status to be stuck at "Interlocked" forever.
5642 The twisted buildbot's one interlocked build just so happened to
5643 never hit this case until recently (the feeding builds both pass
5644 before the interlocked build is attempted.. usually it has to wait
5646 (Builder._pong_failed): fix method signature
5648 * setup.py: bump to 0.4.3+ while between releases
5650 2004-04-30 Brian Warner <warner@lothar.com>
5652 * setup.py (version): Releasing buildbot-0.4.3
5654 2004-04-30 Brian Warner <warner@lothar.com>
5656 * MANIFEST.in: add the doc fragments in docs/*.xhtml
5658 * README: update for 0.4.3 release
5660 * NEWS: update for 0.4.3 release
5662 * buildbot/master.py (BuildMaster.__getstate__): make sure
5663 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
5665 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
5666 .trial as a class attribute, for upgrade from 0.4.2
5668 * buildbot/changes/changes.py (Change.links): add .links for
5671 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
5672 .textWatchers and .htmlWatchers at save time, since they are both
5673 volatile, should allow smooth 0.4.2 upgrade
5675 * buildbot/process/step.py (CVS.finishStatus): catch failed
5676 CVS/SVN commands so we can make the status box red
5678 2004-04-29 Brian Warner <warner@lothar.com>
5680 * buildbot/changes/freshcvs.py
5681 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
5682 code to do setFilter(), which tells the freshcvs daemon to not
5683 send us stuff that we're not interested in. I will uncomment it
5684 when a new version of CVSToys is available in which setFilter()
5685 actually works, and I get a chance to test it better.
5687 * docs/examples/twisted_master.cfg: start using a PBChangeSource
5689 * buildbot/master.py (Dispatcher): use a registration scheme
5690 instead of hardwired service names
5691 (BuildMaster): keep track of the Dispatcher to support
5694 * buildbot/changes/changes.py (ChangeMaster): create a distinct
5695 PBChangeSource class instead of having it be an undocumented
5696 internal feature of the ChangeMaster. Split out the code into a
5698 * buildbot/changes/pb.py (PBChangeSource): same
5699 * buildbot/test/test_changes.py: a few tests for PBChangeSource
5701 * docs/{factories|sources|steps}.xhtml: document some pieces
5703 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
5704 using FCMaildirSource
5705 (f23osx): update OS-X builder to use python2.3, since the slave
5706 was updated to Panther (10.3.3)
5708 2004-03-21 Brian Warner <warner@lothar.com>
5710 * buildbot/process/process_twisted.py: factor out doCheckout, change
5711 to use SVN instead of CVS
5713 * buildbot/process/base.py (BasicBuildFactory): refactor to make
5714 an SVN subclass easier
5715 (BasicSVN): subclass which uses Subversion instead of CVS
5717 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
5719 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
5721 (CVSCommand.cvsComplete): don't assume chdir worked on win32
5723 2004-02-25 Brian Warner <warner@lothar.com>
5725 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
5726 is now either a list (which is passed to spawnProcess directly) or
5727 a string (which gets passed to /bin/sh -c). This removes the useSH
5728 flag and the ArgslistCommand class. Also send status header at the
5729 start and end of each command, instead of having the master-side
5731 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
5732 -r'. Update to use list-based arguments.
5733 (SVNFetch): use list-based arguments, use ['dir'] argument to
5735 * buildbot/test/test_steps.py (Commands): match changes
5737 * buildbot/process/step.py (InternalShellCommand.words): handle
5739 (SVN): inherit from CVS, cleanup
5741 * buildbot/status/event.py (Logfile.content): render in HTML, with
5742 stderr in red and headers (like the name of the command we're
5743 about to run) in blue. Add link to a second URL (url + "?text=1")
5744 to get just stdout/stderr in text/plain without markup. There is
5745 still a problem with .entries=None causing a crash, it seems to occur
5746 when the logfile is read before it is finished.
5748 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
5749 timeout to the keepalives, and use it to explicitly do a
5750 loseConnection instead of waiting for TCP to notice the loss. This
5751 ought to clear up the silent-lossage problem.
5752 (unsafeTracebacks): pass exception tracebacks back to the master,
5753 makes it much easier to debug problems
5755 2004-02-23 Brian Warner <warner@lothar.com>
5757 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
5758 the whole command to /bin/sh instead of execve [Johan Dahlin]
5759 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
5760 '-r HEAD' [Johan Dahlin]
5761 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
5763 * buildbot/changes/changes.py (Change): add links= argument, add
5764 asHTML method [Johan Dahlin]. Modified to make a bit more
5765 XHTMLish. Still not sure how to best use links= .
5767 * buildbot/status/html.py (StatusResourceCommits.getChild): use
5768 Change.asHTML to display the change, not asText
5770 * buildbot/status/html.py (StatusResourceBuilder): web button to
5773 * buildbot/test/test_run.py: test to actually start a buildmaster
5776 * MANIFEST.in: bring back accidentally-dropped test helper files
5778 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
5779 that require cvstoys if it is not installed
5781 * buildbot/process/step_twisted.py (RunUnitTests): allow other
5782 values of "bin/trial" [Dave Peticolas]
5783 (RunUnitTests.finishStatus): say "no tests run" instead of "0
5784 tests passed" when we didn't happen to run any tests
5786 * buildbot/process/step.py (Compile): use haltOnFailure instead of
5787 flunkOnFailure [Johan Dahlin]
5789 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
5790 multiple instances of the same Step class by suffixing "_2", etc,
5791 to the name until it is unique. This name needs to be unique
5792 because it is used as a key in the dictionary that tracks build
5794 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
5797 * buildbot/process/base.py (Builder.ping): add "ping slave" command
5799 2004-01-14 Brian Warner <warner@lothar.com>
5801 * buildbot/status/words.py (IrcStatusBot): when we leave or get
5802 kicked from a channel, log it
5804 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
5805 something over whatever IRC channels the buildmaster is currently
5806 connected to. Added to try and track down a problem in which the
5807 master thinks it is still connected but the IRCd doesn't see it. I
5808 used a styles.Versioned this time, so hopefully users won't have
5809 to rebuild their .tap files this time.
5810 * contrib/debug.glade: add a "Poke IRC" button
5811 * contrib/debugclient.py: same
5813 * setup.py: bump to 0.4.2+ while between releases
5815 2004-01-08 Brian Warner <warner@lothar.com>
5817 * setup.py (version): Releasing buildbot-0.4.2
5819 2004-01-08 Brian Warner <warner@lothar.com>
5821 * NEWS: update for 0.4.2 release
5823 * README: document how to run the tests, now that they all pass
5825 * buildbot/changes/maildir.py (Maildir.poll): minor comment
5827 * buildbot/process/step.py (CVS): add a global_options= argument,
5828 which lets you set CVS global options for the command like "-r"
5829 for read-only checkout, or "-R" to avoid writing in the
5831 * buildbot/slavecommand.py (CVSCommand): same
5833 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
5834 testing easier (it is turned off when testing, to avoid the
5837 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
5838 to make it easier to test: break generateStepID() out to a
5839 separate function, only update statusbag if it exists.
5840 (ShellCommands): create useful text for dict-based commands too.
5842 * test/*, buildbot/test/*: move unit tests under the buildbot/
5844 * setup.py (packages): install buildbot.test too
5846 * buildbot/test/test_slavecommand.py: fix it, tests pass now
5847 * buildbot/test/test_steps.py: fix it, tests pass now
5849 2004-01-06 Brian Warner <warner@lothar.com>
5851 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
5852 freshcvs mail uses a slightly different syntax for new
5853 directories. Update parser to handle either.
5854 * test/test_mailparse.py (Test1.testMsg9): test for same
5856 2003-12-21 Brian Warner <warner@lothar.com>
5858 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
5859 'warnOnWarnings' so that lintian errors mark the build orange
5861 2003-12-17 Brian Warner <warner@lothar.com>
5863 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
5864 messages emitted by Bonsai, contributed by Stephen Davis.
5866 * test/*: moved all tests to use trial instead of unittest. Some
5867 still fail (test_steps, test_slavecommand, and test_process).
5869 * setup.py (version): bump to 0.4.1+ while between releases
5871 2003-12-09 Brian Warner <warner@lothar.com>
5873 * setup.py (version): Releasing buildbot-0.4.1
5875 2003-12-09 Brian Warner <warner@lothar.com>
5877 * NEWS: update for 0.4.1 release
5879 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
5880 freebsd builder code a little bit
5882 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
5883 don't try to compare attributes of different classes
5884 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
5885 (MaildirSource.messageReceived): fix Change delivery
5887 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
5888 into the config file's namespace before loading it, like the
5889 documentation claims it does
5890 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
5891 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
5892 daemon comes back online
5894 2003-12-08 Brian Warner <warner@lothar.com>
5896 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
5897 so the example will work with online=0 as well
5899 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
5900 fix the __implements__ line
5902 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
5903 class a twisted.application.service.Service, use startService to
5906 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
5907 directory fd instead of simple open(). I'm sure this used to work,
5908 but the current version of python refuses to open directories with
5911 2003-12-05 Brian Warner <warner@lothar.com>
5913 * setup.py (version): bump to 0.4.0+ while between releases
5915 2003-12-05 Brian Warner <warner@lothar.com>
5917 * setup.py (version): Releasing buildbot-0.4.0
5919 2003-12-05 Brian Warner <warner@lothar.com>
5921 * docs/examples/glib_master.cfg: replace old sample scripts with
5922 new-style config files
5923 * MANIFEST.in: include .cfg files in distribution tarball
5925 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
5926 implement a dummy method to avoid the exception that occurs when
5927 freshcvs sends this to us.
5929 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
5930 removed the method, as it broke reconnection. Apparently
5931 stopFactory is called each time the connection attempt fails. Must
5933 (ReconnectingPBClientFactory.__getstate__): squash the _callID
5934 attribute before serialization, since without stopFactory the
5935 reconnect timer may still be active and they aren't serializable.
5937 * test/test_mailparse.py (ParseTest): test with 'self' argument
5939 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
5940 argument, as these "functions" are invoked like methods from class
5941 attributes and therefore always get an instance as the first
5944 * buildbot/changes/maildir.py (Maildir.start): fix error in error
5945 message: thanks to Stephen Davis for the catch
5947 2003-12-04 Brian Warner <warner@lothar.com>
5949 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
5950 twisted's standard ReconnectingClientFactory. Handles both oldcred
5951 and newcred connections. Also has a bug-workaround for
5952 ReconnectingClientFactory serializing its connector when it
5955 * buildbot/bot.py (BotFactory): rewrite connection layer with new
5956 pbutil. Replace makeApp stuff with proper newcred/mktap
5957 makeService(). Don't serialize Ephemerals on shutdown.
5959 * buildbot/changes/changes.py (ChangeMaster): make it a
5960 MultiService and add the sources as children, to get startService
5961 and stopService for free. This also gets rid of the .running flag.
5963 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
5964 new pbutil, turn into a TCPClient at the same time (to get
5965 startService for free). Two variants exist: FreshCVSSourceOldcred
5966 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
5967 yet, but when it does, we'll be ready).
5968 (FreshCVSSource.notify): handle paths which are empty after the
5969 prefix is stripped. This only happens when the top-level (prefix)
5970 directory is added, at the very beginning of a Repository's life.
5972 * buildbot/clients/base.py: use new pbutil, clean up startup code.
5973 Now the only reconnecting code is in the factory where it belongs.
5974 (Builder.unsubscribe): unregister the disconnect callback when we
5975 delete the builder on command from the master (i.e. when the
5976 buildmaster is reconfigured and that builder goes away). This
5977 fixes a multiple-delete exception when the status client is shut
5979 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
5982 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
5983 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
5985 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
5987 * contrib/run_maxq.py: Accept a testdir as an argument rather than
5988 a list of globs (ugh). The testdir will be searched for files
5989 named *.tests and run the tests in the order specified in each of
5990 those files. This allows for "dependancies" between tests to be
5993 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
5994 argument to pass to run_maxq.py, instead of a glob.
5996 2003-10-17 Brian Warner <warner@lothar.com>
5998 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
5999 files that live in the sandbox
6001 2003-10-15 Brian Warner <warner@lothar.com>
6003 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6004 spelling error in "docs" count-warnings output
6005 (HLint.start): stupid thinko meant .xhtml files were ignored
6007 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6008 tests now that cReactor is banished to the sandbox
6010 2003-10-10 Brian Warner <warner@lothar.com>
6012 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6013 scheme: now .xhtml are sources and .html are generated
6015 2003-10-08 Brian Warner <warner@lothar.com>
6017 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6018 we were ignoring the 'randomly' parameter.
6020 2003-10-01 Brian Warner <warner@lothar.com>
6022 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6023 posix, to kill sub-children of aborted slavecommands.
6025 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6026 Clean up initialization: lastBuildStatus remains None until the
6027 first build has been completed.
6029 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6030 None as a lastBuildStatus
6031 * buildbot/clients/gtkPanes.py: same
6033 * buildbot/status/client.py (StatusClientService): keep
6034 BuilderStatus objects in self.statusbags . These objects now live
6035 here in the StatusClientService and are referenced by the Builder
6036 object, rather than the other way around.
6037 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6038 * buildbot/process/base.py (Builder): same
6039 * test/test_config.py (ConfigTest.testBuilders): same
6041 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6042 an existing builder, leave the statusbag alone. This will preserve the
6045 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6046 hook. This will probably go away in favor of a class in upcoming
6049 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6050 serviceName from newcred FreshCVSNotifiee setup
6052 2003-09-29 Brian Warner <warner@lothar.com>
6054 * buildbot/process/process_twisted.py: switch to new reactor
6056 * docs/examples/twisted_master.cfg: same
6058 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6060 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6061 botmaster reference instead of the oldapp service lookup
6063 * buildbot/master.py (BuildMaster.__init__): give the
6064 StatusClientService a reference to the botmaster to make it easier to
6067 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6069 * buildbot/status/html.py (Box.td): escape hreffy things so you
6070 can have spaces in things like builder names
6071 (StatusResourceBuilder.body)
6072 (WaterfallStatusResource.body)
6073 (WaterfallStatusResource.body0): same
6075 2003-09-25 Brian Warner <warner@lothar.com>
6077 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6078 rearrange the builder list when adding or removing builders: keep
6079 them in the order the user requested.
6080 * test/test_config.py (ConfigTest.testBuilders): verify it
6082 * contrib/debug.glade: give the debug window a name
6084 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6085 now wait on multiple interlocks. Fix code relating to that.
6086 (Builder.checkInterlocks): same
6087 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6089 * buildbot/master.py (BuildMaster.loadConfig): move from
6090 deprecated pb.BrokerFactory to new pb.PBServerFactory
6091 * test/test_config.py (ConfigTest.testWebPathname): same
6093 * docs/examples/twisted_master.cfg: fix interlock declaration
6095 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6096 Interlocks to their Builders into interlock.py .
6097 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6099 * test/test_config.py (ConfigTest.testInterlocks): validate
6102 * buildbot/process/base.py (Builder.__init__): better comments
6103 * buildbot/process/interlock.py (Interlock.__repr__): same
6104 (Interlock.deactivate): add .active flag, move the code that
6105 attaches/detaches builders into the Interlock
6107 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6109 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6110 tests using the new run_maxq.py script, and reporting failures by
6113 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6114 tests, reporting their success or failure in a buildbot-friendly
6117 2003-09-24 Brian Warner <warner@lothar.com>
6119 * docs/examples/twisted_master.cfg: example of a new-style config
6120 file. This lives in the buildmaster base directory as
6123 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6124 button to make the master re-read its config file
6126 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6127 buildmaster configuration from a file. This file can be re-read
6128 later, and the buildmaster will update itself to match the new
6129 desired configuration. Also use new Twisted Application class.
6130 * test/Makefile, test/test_config.py: unit tests for same
6132 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6133 FreshCVSSources comparable, to support reload.
6134 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6136 * buildbot/process/base.py (Builder): make them comparable, make
6137 Interlocks easier to attach, to support reload. Handle
6138 re-attachment of remote slaves.
6139 * buildbot/process/interlock.py (Interlock): same
6141 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6142 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6143 buildmaster taps are now constructed with mktap.
6144 * buildbot/status/client.py (StatusClientService): same
6146 * buildbot/status/words.py: move to new Services, add support to
6147 connect to multiple networks, add reload support, allow nickname
6148 to be configured on a per-network basis
6150 2003-09-20 Brian Warner <warner@lothar.com>
6152 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6153 the freebsd builder, now that the machine has been upgraded and no
6154 longer has python2.2
6156 * setup.py (version): bump to 0.3.5+ while between releases
6158 2003-09-19 Brian Warner <warner@lothar.com>
6160 * setup.py (version): Releasing buildbot-0.3.5
6162 2003-09-19 Brian Warner <warner@lothar.com>
6164 * NEWS: add post-0.3.4 notes
6166 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6168 * MANIFEST.in: add contrib/*
6170 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6171 use a remote root now: cvs.twistedmatrix.com
6173 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6175 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6176 compatibility with old servers
6177 (FreshCVSSource.start): and provide a way to use it
6178 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6180 * docs/examples/twisted_master.py (twisted_app): update to new
6182 (twisted_app): listen on new ~buildbot socket
6183 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6185 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6186 to reduce cvs bandwidth (update instead of full checkout)
6188 2003-09-11 Brian Warner <warner@lothar.com>
6190 * contrib/fakechange.py: demo how to connect to the changemaster
6191 port. You can use this technique to submit changes to the
6192 buildmaster from source control systems that offer a hook to run a
6193 script when changes are committed.
6195 * contrib/debugclient.py: tool to connect to the debug port. You
6196 can use it to force builds, submit fake changes, and wiggle the
6199 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6200 'Dispatcher' realm to handle all the different kinds of
6201 connections and Perspectives: buildslaves, the changemaster port,
6202 the debug port, and the status client port. NewCredPerspectives
6203 now have .attached/.detached methods called with the remote 'mind'
6204 reference, much like old perspectives did. All the pb.Services
6205 turned into ordinary app.ApplicationServices .
6206 (DebugService): went away, DebugPerspectives are now created
6207 directly by the Dispatcher.
6208 (makeApp): changed interface a little bit
6210 * buildbot/changes/changes.py: newcred
6211 * buildbot/status/client.py: newcred
6213 * buildbot/clients/base.py: newcred client side changes
6214 * buildbot/bot.py: ditto
6216 * docs/examples/glib_master.py: handle new makeApp() interface
6217 * docs/examples/twisted_master.py: ditto
6219 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6220 base newcred Perspectives on. This should go away once Twisted
6221 itself provides something sensible.
6224 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6226 * contrib/svn_buildbot.py: A program that you can call from your
6227 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6228 when a change in an SVN repository has happened. See the top of
6229 the file for some minimal usage info.
6231 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6233 * buildbot/slavecommand.py (ArglistCommand): Add new
6234 ArglistCommand that takes an argument list rather than a string as
6235 a parameter. Using a st.split() for argv is very bad.
6237 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6238 update to a particular revision rather than always checking out
6239 (still not very smart about it, there may be cases where the
6240 checkout becomes inconsistent).
6242 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6244 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6245 SVN fetch support. It can checkout (not update!) a specified
6246 revision from a specified repository to a specified directory.
6248 * buildbot/status/progress.py (Expectations.update): Fix an
6249 obvious bug (apparently created by the change described in the
6250 previous ChangeLog message) by moving a check to *after* the
6251 variable it checks is defined.
6254 2003-09-08 Brian Warner <warner@lothar.com>
6256 * buildbot/status/progress.py (Expectations.update): hack to catch
6257 an exception TTimo sees: sometimes the update() method seems to
6258 get called before the step has actually finished, so the .stopTime
6259 is not set, so no totalTime() is available and we average None
6260 with the previous value. Catch this and just don't update the
6261 metrics, and emit a log message.
6263 2003-08-24 Brian Warner <warner@lothar.com>
6265 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6266 parameter to set copydir='original' in CVS commands.
6268 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6270 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6271 which tells the command to maintain a separate original-source CVS
6272 workspace. For each build, this workspace will be updated, then
6273 the tree copied into a new workdir. This reduces CVS bandwidth
6274 (from a full checkout to a mere update) while doubling the local
6275 disk usage (to keep two copies of the tree).
6277 2003-08-21 Brian Warner <warner@lothar.com>
6279 * buildbot/status/event.py (Logfile.addEntry): if the master web
6280 server dies while we're serving a page, request.write raises
6281 pb.DeadReferenceError . Catch this and treat it like a
6282 notifyFinish event by dropping the request.
6284 2003-08-18 Brian Warner <warner@lothar.com>
6286 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6287 (instead of blowing up) if a force-build command is given without
6290 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6291 don't blow up if there aren't yet any Changes in the list
6293 2003-08-02 Brian Warner <warner@lothar.com>
6295 * buildbot/bot.py (updateApplication): don't set the .tap name,
6296 since we shouldn't assume we own the whole .tap file
6298 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6299 'mktap buildbot' (without a subcommand) better
6301 2003-07-29 Brian Warner <warner@lothar.com>
6303 * buildbot/status/words.py
6304 (IrcStatusFactory.clientConnectionLost): when we lose the
6305 connection to the IRC server, schedule a reconnection attempt.
6307 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6308 use shutil.rmtree instead of forking off an "rm -rf" command.
6309 rmtree may take a while and will block until it finishes, so we
6310 use "rm -rf" if available.
6312 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6313 freebsd buildslave badly
6315 * setup.py (version): bump to 0.3.4+ while between releases
6317 2003-07-28 Brian Warner <warner@lothar.com>
6319 * setup.py (version): Releasing buildbot-0.3.4
6321 2003-07-28 Brian Warner <warner@lothar.com>
6323 * NEWS: update in preparation for release
6325 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6326 process.signalProcess instead of os.kill, to improve w32
6329 * docs/examples/twisted_master.py (twisted_app): turn off
6330 win32eventreactor: the tests hang the buildslave badly
6332 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6333 failed builds, since usually the failures are consistent
6335 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6336 add compileOpts/compileOpts2 to reactors build
6338 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6339 (twisted_app): use both default and win32eventreactor on w32 build.
6340 Use both default and kqreactor on freebsd build.
6342 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6343 add compileOpts2, which is put after the build_ext argument. w32
6344 needs "-c mingw32" here.
6346 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6347 touch .acqpath, it goes away in recent Twisted releases
6349 * docs/examples/twisted_master.py (twisted_app): use "python" for
6350 the w32 buildslave, not "python2.2"
6352 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6353 the directory exists.. should hush an exception under w32
6355 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6356 ProcessTerminated -provided values for signal and exitCode rather
6357 than parsing the unix status code directly. This should remove one
6358 more roadblock for a w32-hosted buildslave.
6360 * test/test_mailparse.py: add test cases for Syncmail parser
6362 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6363 temporary compatibility import. Note! Start importing
6364 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6366 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6368 2003-07-27 Brian Warner <warner@lothar.com>
6370 * NEWS: started adding new features
6372 * buildbot/changes/mail.py: start work on Syncmail parser, move
6373 mail sources into their own file
6375 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6376 as implementing IChangeSource
6377 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6379 * buildbot/interfaces.py: define the IChangeSource interface
6381 2003-07-26 Brian Warner <warner@lothar.com>
6383 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6385 2003-06-25 Brian Warner <warner@lothar.com>
6387 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6390 2003-06-17 Brian Warner <warner@lothar.com>
6392 * buildbot/status/words.py: clean up method usage to avoid error
6393 in silly IRC command
6394 (IrcStatusBot.emit_status): round off seconds display
6396 * buildbot/process/base.py (Build): delete the timer when saving
6397 to the .tap file, and restore it (if it should still be running)
6398 upon restore. This should fix the "next build in -34 seconds"
6399 messages that result when the master is restarted while builds are
6400 sitting in the .waiting slot. If the time for the build has
6401 already passed, start it very soon (in 1 second).
6403 * buildbot/status/words.py: more silly commands
6405 * README (REQUIREMENTS): add URLs to all required software
6407 * buildbot/status/words.py ('last'): mention results of, and time
6410 2003-05-28 Brian Warner <warner@lothar.com>
6412 * buildbot/status/words.py: add 'last' command
6413 (IrcStatusBot.emit_status): add current-small text to 'status' output
6415 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6416 (twisted_app): remove spaces from OS-X builder name
6418 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6419 * buildbot/status/words.py: IRC bot should actually be useful now
6421 2003-05-23 Brian Warner <warner@lothar.com>
6423 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6424 "slave information" from $(slavedir)/info/* . These files are
6425 maintained by the slave administrator, and describe the
6426 machine/environment that is hosting the slave. Information from
6427 them is put into the "Builder" HTML page. Still need to establish
6428 a set of well-known filenames and meanings for this data: at the
6429 moment, *all* info/* files are sent to the master, but only
6430 'admin' and 'host' are used on that end.
6431 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6432 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6433 * buildbot/master.py (BotPerspective.got_info): ditto
6435 2003-05-22 Brian Warner <warner@lothar.com>
6437 * setup.py (version): bump version to 0.3.3+ while between releases
6439 2003-05-21 Brian Warner <warner@lothar.com>
6441 * setup.py: Releasing buildbot-0.3.3
6443 2003-05-21 Brian Warner <warner@lothar.com>
6445 * NEWS: 0.3.3 news items
6447 * README: describe --keepalive and life behind a NAT box
6449 * buildbot/bot.py (Bot.connected): implement application-level
6450 keepalives to deal with NAT timeouts, turn them on with
6451 --keepalive option or when SO_KEEPALIVE doesn't work.
6453 * buildbot/master.py (BotPerspective): accept keepalives silently
6455 * buildbot/process/base.py (Build.buildException): CopiedFailures
6456 don't carry as much information as local ones, so don't try to
6457 create a big HTMLized version of them.
6459 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6460 log file when step fails due to an exception, such as when the slave
6463 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6464 --testmodule argument instead of grepping for test-case-name tags
6465 ourselves. Remove FindUnitTests code.
6466 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6468 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6470 2003-05-16 Brian Warner <warner@lothar.com>
6472 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6473 argument to allow things like CFLAGS=-O0 to be passed without relying
6474 upon /bin/sh processing on the slave.
6476 * buildbot/process/step.py (InternalShellCommand.start): send
6478 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6479 'split' instead of letting /bin/sh do it. This should also remove
6480 the need for /bin/sh on the buildslave, making it more likely to
6483 * buildbot/status/html.py: html-escape text in blamelist.
6484 Add "force build" button to the Builder page.
6486 * buildbot/process/step_twisted.py (countFailedTests): look at
6487 last 1000 characters for status line, as import errors can put it
6488 before the -200 point.
6490 2003-05-15 Brian Warner <warner@lothar.com>
6492 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6494 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6495 make 'clobber' a parameter, so it is possible to have builds which
6496 do full tests but do a cvs update instead of hammering the CVS
6497 server with a full checkout each build
6499 * buildbot/process/step.py (InternalShellCommand): bump default
6500 timeout to 20 minutes
6502 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6503 the master to trigger a build. Run it via manhole.
6505 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6506 allow slaves to trigger any build that they host, to make life
6507 easier for slave admins who are testing out new build processes
6509 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6510 don't flunk cReactor or qtreactor on failure, since they fail alot
6511 these days. Do warnOnFailure instead.
6513 * buildbot/process/base.py: change Builder.buildable from a list
6514 into a single slot. When we don't have a slave, new builds (once
6515 they make it past the timeout) are now merged into an existing
6516 buildable one instead of being queued. With this change, a slave
6517 which has been away for a while doesn't get pounded with all the
6518 builds it missed, but instead just does a single build.
6520 2003-05-07 Brian Warner <warner@lothar.com>
6522 * setup.py (version): bump version to 0.3.2+ while between releases
6524 2003-05-07 Brian Warner <warner@lothar.com>
6526 * setup.py: Releasing buildbot-0.3.2
6528 2003-05-07 Brian Warner <warner@lothar.com>
6530 * setup.py: fix major packaging error: include subdirectories!
6532 * NEWS: add changes since last release
6534 * README (REQUIREMENTS): update twisted/python dependencies
6536 * buildbot/status/builder.py (Builder.startBuild): change
6537 BuildProcess API: now they should call startBuild/finishBuild
6538 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6539 keeping a list of builds in the statusbag, to support other kinds of
6541 (Builder.addClient): send current-activity-small to new clients
6542 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6545 * buildbot/status/client.py: drop RemoteReferences at shutdown
6547 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6549 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6550 more debug messages for remote status client
6552 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6553 (.stepFailed): only fire the Deferred once, even if both
6554 stepComplete and stepFailed are called. I think this can happen if
6555 an exception occurs at a weird time.
6557 * buildbot/status/words.py: work-in-progress: IRC status delivery
6559 2003-05-05 Brian Warner <warner@lothar.com>
6561 * docs/examples/twisted_master.py (twisted_app): hush internal
6562 python2.3 distutils deprecation warnings
6563 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6564 add compileOpts= argument which inserts extra args before the
6565 "setup.py build_ext" command. This can be used to give -Wignore
6566 warnings, to hush some internal python-2.3 deprecation messages.
6568 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6569 the ['twisted.test'] default test case to make it easier to change
6572 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6573 * buildbot/clients/gtkPanes.py: ditto
6575 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6576 arg to collapse RunUnitTestsRandomly into RunUnitTests
6577 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6578 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6580 * buildbot/status/html.py (StatusResource): shuffle Resources
6581 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6582 would serve the waterfall display, but the internal links were
6583 only valid on the trailing-slash version. The correct behavior is
6584 for the non-slashed one to serve a Redirect to the slashed one.
6585 This only shows up when the buildbot page is hanging off another
6586 server, like a Twisted-Web distributed server.
6588 * buildbot/status/event.py (Event, RemoteEvent): make Events
6589 pb.Cacheable, with RemoteEvent as the cached version. This removes
6590 a lot of explicit send-an-update code.
6591 * buildbot/status/builder.py (Builder): remove send-update code
6592 * buildbot/status/client.py (ClientBuilder): remove send-update
6593 code, and log errors that occur during callRemote (mostly to catch
6594 InsecureJelly exceptions)
6596 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6597 run Lore with the same python used in the rest of the build
6599 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6601 * buildbot/process/step_twisted.py (HLint): accept 'python'
6602 argument. Catch rc!=0 and mark the step as failed. This marks the
6603 build orange ("has warnings").
6604 (RunUnitTestsJelly): move out to step_twisted2.py
6606 * buildbot/util.py (ignoreStaleRefs): add utility function
6608 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6609 don't fake ETA object, it's too hard to get right
6611 2003-05-02 Brian Warner <warner@lothar.com>
6613 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6615 2003-05-01 Brian Warner <warner@lothar.com>
6617 * buildbot/status/html.py (StatusResource.body): oops, I was
6618 missing a <tr>, causing the waterfall page to be misrendered in
6619 everything except Galeon.
6621 2003-04-29 Brian Warner <warner@lothar.com>
6623 * docs/examples/twisted_master.py: make debuild use python-2.2
6624 explicitly, now that Twisted stopped supporting 2.1
6626 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
6627 handle tuple results too. I keep forgetting this, which suggests
6628 it needs to be rethought.
6630 * setup.py (setup): bump version to 0.3.1+ while between releases
6632 2003-04-29 Brian Warner <warner@lothar.com>
6634 * setup.py: Releasing buildbot-0.3.1
6636 2003-04-29 Brian Warner <warner@lothar.com>
6638 * README (SUPPORT): add plea to send questions to the mailing list
6640 * NEWS, MANIFEST.in: add description of recent changes
6642 * docs/examples/twisted_master.py: add the code used to create the
6643 Twisted buildmaster, with passwords and such removed out to a
6646 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
6647 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
6648 buildmasters to not require CVSToys be installed.
6649 * README, docs/examples/glib_master: update to match the change
6651 * buildbot/clients/base.py, buildbot/bot.py,
6652 buildbot/changes/changes.py, buildbot/pbutil.py: copy
6653 ReconnectingPB from CVSToys distribution to remove CVSToys
6654 dependency for build slaves and status clients. Buildmasters which
6655 use FreshCVSSources still require cvstoys be installed, of course.
6657 2003-04-25 Brian Warner <warner@lothar.com>
6659 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
6660 runTestsRandomly arg to turn on trial -z
6662 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
6663 experimental code to use trial's machine-parseable output to get
6664 more detailed test results. Still has some major issues.
6665 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
6668 * buildbot/status/builder.py (Builder.setCurrentBuild):
6669 anticipating moving build history into statusbag, not used yet
6671 * buildbot/status/tests.py: code to centralize test results,
6672 doesn't work quite yet
6674 * buildbot/status/event.py (Event): use hasattr("setName") instead
6675 of isinstance for now.. need better long-term solution
6677 * buildbot/status/html.py: Remove old imports
6679 2003-04-24 Brian Warner <warner@lothar.com>
6681 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
6682 ignore changes under doc/fun/ and sandbox/
6684 * buildbot/process/step_twisted.py: update pushEvent and friends.
6686 * buildbot/status/html.py (Box.td): replace event.buildername with
6687 event.parent.getSwappableName(). Needs more thought.
6689 * buildbot/status/builder.py (Builder): Replace pushEvent and
6690 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
6691 Tell events they are being pruned with event.delete().
6693 * buildbot/process/base.py (Build): Remove Builder status-handling
6694 methods. s/pushEvent/setCurrentActivity/.
6696 * buildbot/process/step.py (BuildStep): clean up status delivery.
6697 Gouse builder.statusbag methods instead of intermediate builder
6698 methods. s/updateLastEvent/updateCurrentActivity/.
6699 s/finalizeLastEvent/finishCurrentActivity/. Use
6700 addFileToCurrentActivity for summaryFunction.
6702 * buildbot/status/event.py (Logfile): put data in a Swappable when
6704 (Event): add more setter methods. Remove .buildername, use .parent
6705 and getSwappableName instead (needs more thought).
6707 * buildbot/util.py (Swappable):
6708 * test/test_swap.py: don't bother setting filename at __init__
6709 time, do it later. Change setFilename args to take parent first,
6710 since it provides the most significant part of the filename.
6712 2003-04-23 Brian Warner <warner@lothar.com>
6714 * buildbot/status/event.py (Logfile.addEntry): append to previous
6717 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
6718 anticipating Swappable
6719 (InternalShellCommand.remoteUpdate): split out various log-adding
6720 methods so subclasses can snarf stdout separately
6722 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
6723 in anticipation of Swappable build logs
6724 (Builder.testsFinished): anticipating TestResults, still disabled
6726 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
6729 * buildbot/status/event.py (Logfile): add (disabled) support for
6730 Swappable, not ready for use yet
6732 * buildbot/util.py (Swappable): object which is swapped out to
6733 disk after some period of no use.
6734 * test/test_swap.py: test buildbot.utils.Swappable
6736 2003-04-14 Brian Warner <warner@lothar.com>
6738 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
6739 periodic-build timer. Set the .periodicBuildTime on a builder
6740 instance to some number of seconds to activate it.
6742 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
6744 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
6745 a way that survives result tuples
6747 2003-04-12 Brian Warner <warner@lothar.com>
6749 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
6750 return a dict instead of a tuple: allow summarizers to provide
6751 multiple summaries if they want
6752 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
6753 (debuildSummarizer): summarize lintian warnings/errors
6755 2003-04-10 Brian Warner <warner@lothar.com>
6757 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
6759 2003-04-09 Brian Warner <warner@lothar.com>
6761 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
6762 empty summaries: happens when the tests fail so hard they don't emit
6763 a parseable summary line.
6765 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
6766 Allow summaryFunction to return None to indicate no summary should
6769 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
6770 writing to stale HTTP requests: notice when they disconnect and
6771 remove the request from the list. Also add CacheToFile from
6772 moshez, will be used later.
6774 2003-04-08 Brian Warner <warner@lothar.com>
6776 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
6777 should be an int, not a list of strings
6779 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
6780 if we weren't actually connected
6782 * buildbot/process/step_twisted.py (trialTextSummarizer): function
6783 to show the tail end of the trial text output
6785 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
6786 hook to summarize the results of a ShellCommand
6788 2003-04-07 Brian Warner <warner@lothar.com>
6790 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
6791 twisted test suite code into a single class.
6792 * buildbot/process/process_twisted.py: same
6794 2003-04-04 Brian Warner <warner@lothar.com>
6796 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
6798 * README (SLAVE): document use of mktap to create slave .tap file
6799 (REQUIREMENTS): describe dependencies
6801 * buildbot/bb_tap.py, buildbot/plugins.tml:
6802 * buildbot/bot.py (updateApplication): Add mktap support for creating
6803 buildslave .tap files
6805 2003-03-28 Brian Warner <warner@lothar.com>
6807 * buildbot/process/step.py (InternalShellCommand.finished): handle
6808 new tuple result values (fix embarrasing bug that appeared during
6811 2003-03-27 Brian Warner <warner@lothar.com>
6813 * docs/examples/glib_master.py, README: add sample buildmaster.tap
6816 2003-03-25 Brian Warner <warner@lothar.com>
6818 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
6819 to overall build status
6820 * buildbot/clients/base.py (Builder): improve event printing
6821 * buildbot/process/base.py (BasicBuildFactory): use specific steps
6822 instead of generic ShellCommand
6823 (Build): Add .stopBuild, use it when slave is detached
6825 * buildbot/process/step.py (Configure,Test): give the steps their
6826 own names and status strings
6828 * buildbot/status/html.py (StatusResource): add "show" argument,
6829 lets you limit the set of Builders being displayed.
6831 2003-03-20 Brian Warner <warner@lothar.com>
6833 * buildbot/process/basic.py: removed
6835 2003-03-19 Brian Warner <warner@lothar.com>
6837 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6838 turn off process-docs by default
6840 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
6841 when displaying build information without anything in allBuilds[]
6843 * buildbot/bot.py (makeApp): really take password from sys.argv
6845 2003-03-18 Brian Warner <warner@lothar.com>
6847 * buildbot/bot.py (buildApp): take password from sys.argv
6849 * README: replace with more useful text
6851 * setup.py: add a real one
6852 * MANIFEST.in, .cvsignore: more distutils packaging stuff
6854 * docs/PyCon-2003/: added sources for PyCon paper.
6856 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
6857 now Build objects control the process and Builder only handles
6858 slave stuff and distribution of changes/status. A new BuildFactory
6859 class creates Build objects on demand.
6861 Created ConfigurableBuild which takes a list of steps to run. This
6862 makes it a lot easier to set up a new kind of build and moves us
6863 closer to being able to configure a build from a web page.
6865 * buildbot/process/step_twisted.py, process_twisted.py: move to
6866 new model. A lot of code went away.
6868 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
6869 send lots of empty progress messages to the client.
6871 * buildbot/master.py (makeApp): enforce builder-name uniqueness
6873 2003-02-20 Brian Warner <warner@lothar.com>
6875 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
6877 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
6878 Twisted bug that prevented non-pty processes from working just got
6879 fixed, and the bug that leaks ptys is still being investigated.
6881 * buildbot/process/step.py (CVS): send timeout arg to slave
6883 * buildbot/clients/gtkPanes.py: add connection-status row, handle
6884 builders coming and going
6885 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
6886 from CVSToys, handle lost-buildmaster
6888 * buildbot/status/client.py (StatusClientService.removeBuilder):
6889 Clean up status client protocol: send builders (with references)
6890 as they are created, rather than sending a list and requiring the
6891 client to figure out which ones are new.
6892 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
6893 attempts to force a build on an unknown builder
6895 2003-02-19 Brian Warner <warner@lothar.com>
6897 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
6898 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
6899 Twisted stops leaking them.
6900 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
6901 builder goes to an idle state.
6903 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
6904 I figure out why CVS commands hang without them, and/or I fix the
6905 hung-command timeout
6907 2003-02-16 Brian Warner <warner@lothar.com>
6909 * buildbot/process/step_twisted.py: bin/hlint went away, replace
6910 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
6911 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
6912 GenerateDocs now that they are prefixed with WARNING:.
6914 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
6915 use manual href target instead of request.childLink
6917 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
6918 display every second, but update the ETA every 5 seconds (or
6919 whenever) as remote_progress messages arrive.
6922 2003-02-12 Brian Warner <warner@lothar.com>
6924 * *: import current sources from home CVS repository
6928 # add-log-time-format: add-log-iso8601-time-string