| blob | 4f0a1841c4cd42a0879aff70c9f053194bb4cf06 |
1 2007-09-25 Brian Warner <warner@lothar.com>
3 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
4 new 'upgrade-master' command, which will bring an old buildmaster
5 directory up-to-date. Right now the only thing it does is populate
6 public_html/ if it wasn't already there. Still to do: check the
7 other files, add documentation.
8 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
10 2007-08-13 Brian Warner <warner@lothar.com>
12 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
13 that contains the checkin comments when you hover over the entry
14 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
15 for the patch.
17 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
18 'help' page linkage
20 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
21 page with versions of python, buildbot, and twisted
22 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
23 * buildbot/status/web/index.html: add links to most pages
24 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
26 * buildbot/status/web/robots.txt: put a robots.txt in new installs
27 which discourages robot access to all large dynamically-generated
28 pages. The intention is that the index page and the 'about' page
29 are the only ones which should be crawlable.
30 * buildbot/scripts/runner.py (Maker.public_html): same
31 (createMaster): same
32 * setup.py: ship index.html and robots.txt in source distributions
34 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
35 activate automatic reloading of the page (using a meta Refresh:
36 tag). Closes #69.
37 (WaterfallHelp): new page to explain all the nifty query arguments
38 you can use on the Waterfall, along with forms to set them for
39 you. From this page, you can add filters for builder=, branch=,
40 show_events=, as well as turning on reload=.
41 (WaterfallStatusResource.buildGrid): new query args: last_time=,
42 first_time=, show_time=, num_events= . The old show= is still
43 accepted, but the new builder= is preferred. We ignore empty
44 branch= arguments, to make the WaterfallHelp form easier to
45 implement.
46 (WaterfallStatusResource.head): new method to add text to the
47 <head> of the page.
48 * buildbot/status/web/base.py (HtmlResource.content): use head()
49 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
50 empty branch= arguments
51 (OneLinePerBuildOneBuilder.body): same
53 2007-08-12 Brian Warner <warner@lothar.com>
55 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
56 new query args: 'last_time' is a timestamp of the top-most event
57 on the display, 'first_time' is a timestamp for the bottom-most
58 event. 'show_time' is the difference between them, and overrides
59 'first_time'. 'num_events' puts an upper limit on the number of
60 timestamps that will be displayed on the left hand edge.
61 (WaterfallStatusResource.body): add a 'next page' link to the
62 bottom, which shows the events that come just after those shown on
63 the current page. This is a first step towards #67, but we need
64 some more controls before we can close that one.
66 * buildbot/buildslave.py (BuildSlave): these are now MultiService
67 instances too, and live as children of the BotMaster. The main
68 advantage of this approach is that BuildSlaves can know when they
69 are being removed (so they can shut off the upcoming
70 when-do-we-email-an-admin-because-we-lost-our-slave timer).
71 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
72 identify which service children are BuildSlaves
73 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
74 Checker updates here, but delegate the rest to..
75 (BotMaster.loadConfig_Slaves): .. here, which looks at the
76 BotMaster's service children to identify the old slaves. I think
77 the previous approach of using master.slaves was broken in the
78 face of config updates that modified BuildSlave instances but did
79 not completely replace them.
80 * docs/buildbot.texinfo (Developer's Appendix): note the change to
81 the Service hierarchy
83 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
84 page (at URL /buildslaves/) to view status of all buildslaves at
85 once, including how long it's been since we last heard from them,
86 and which Builders use them.
88 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
89 pages
91 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
92 list all buildslaves
94 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
95 use the BuildSlave to keep track of the last time we've heard from
96 the buildslave. This is updated upon receipt of any message from
97 any SlaveBuilder (which generally means when RemoteCommands are
98 giving us status updates, as BuildSteps run). In the future this
99 will include slave pings too.
100 * buildbot/process/base.py
101 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
102 * buildbot/process/buildstep.py:
103 (BuildStep.setBuildSlave): accept that reference
104 (BuildStep.runCommand): pass the reference on to the RemoteCommand
105 (RemoteCommand.remote_update): update the timestamp
106 (RemoteCommand.remote_complete): same
107 * buildbot/test/runutils.py (StepTester.makeStep): match the change
108 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
109 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
110 interface to retrieve this timestamp
111 * buildbot/status/builder.py (SlaveStatus): track a copy of the
112 timestamp
115 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
116 up the format a bit
117 (OneLinePerBuild.body): use a <ul> instead of <div>s
118 (OneLinePerBuildOneBuilder.body): same
120 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
121 by adding the file's new name to the list of changed files. This
122 ought to be sufficient for things like isFileImportant and trial
123 tests that only exercise tests for files that have been modified.
124 Closes #31.
126 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
127 XMLRPC server to the WebStatus page. This only has two methods
128 right now (getAllBuildsInInterval and getBuild), but we'll be
129 adding more in the future. This server is extracted from the
130 trac-plugin branch.
132 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
133 generateFinishedBuilds, and improve the data displayed.
134 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
135 the per-Build page, add some information like ETA and got_revision
136 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
137 adding a list of recently completed builds
138 * buildbot/status/web/base.py (css_classes): factor this out
140 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
141 new method, to make status display classes easier to write,
142 especially the WebStatus 'one_line_per_build' page.
143 (IBuilderStatus.generateFinishedBuilds): same
144 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
145 (Status.generateFinishedBuilds): implement it
147 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
148 'source' to be a BuildStep instance, since BuildFactory accepts
149 them now.
150 (CPAN.__init__): same
151 (Distutils.__init__): same
152 (Trial.__init__): same
154 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
155 this might raise KeyError
157 2007-08-07 Brian Warner <warner@lothar.com>
159 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
160 'Owner:' field of the view, rather than 'p4logname', since
161 p4logname comes from the buildslave's environment and seems
162 unlikely to ever do the right thing. Thanks to Wade Brainerd for
163 the patch. Closes #40.
165 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
166 which imposes a per-slave limit on how many builds are allowed to
167 run simultaneously. This has a the same scope than the SlaveLock,
168 but is different because max_builds= gives the buildmaster the
169 freedom to assign the build to a different slave, whereas the
170 SlaveLock doesn't get tested until after the build is irrevocably
171 assigned to a slave. Therefore using max_builds= will improve
172 utilization in the presence of multiple buildslaves that are
173 attached to the same Builder. This completes the incorporation of
174 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
175 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
176 any Builder finishes, potentially trigger *all* Builders, since
177 max_builds= may have stalled someone else while waiting for the
178 slave.
179 * buildbot/scripts/sample.cfg: mention max_builds=
180 * buildbot/test/test_run.py (ConcurrencyLimit): test it
181 * docs/buildbot.texinfo (Buildslave Specifiers): document it
183 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
184 inherit from RunMixin do not need to call master.stopService()
185 themselves, since RunMixin.tearDown does that. The double call
186 fails on Twisted-2.0.x, which didn't happen to protect against it.
187 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
189 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
190 from #48, this one to have the BuildSlave objects track
191 SlaveBuilders, so they'll be able to use that knowledge to
192 influence their canStartBuild() response.
193 * buildbot/process/builder.py (SlaveBuilder.attached): call it
194 (SlaveBuilder.detached): same
195 * buildbot/test/test_slaves.py (BuildSlave): test it
197 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
198 the second of Dustin's #48 patches, this one adding a method to
199 the BuildSlave that allows it to decide whether it is willing to
200 participate in a build or not.
201 (SlaveBuilder.isAvailable): use canStartBuild() to decide
203 * buildbot/test/test_run.py (CanStartBuild): test for it
205 * all: incorporate the first of four patches by Dustin Mitchell
206 from ticket #48, working towards improving control over slave
207 concurrency. The first patch is to use a long-lived BuildSlave
208 object per slave, on which other behavior can be added later. I've
209 modified his patch considerably.
210 * buildbot/buildslave.py (BuildSlave): move class out of
211 slave/__init__.py (where it would get loaded by the slave as well
212 as the master, making dependencies trickier), and merge it with
213 BotPerspective. Now these BuildSlave instances are created once in
214 the master.cfg file, and not destroyed until they are either
215 removed from the config file or changed so
216 much (name/password/class changes) that we cannot continue to use
217 the old one. This affects config files: they must use
218 'from buildbot.buildslave import BuildSlave' instead of using
219 'from buildbot.slave import BuildSlave'.
220 * buildbot/master.py: move BotPerspective out
221 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
222 add or remove as necessary, update the rest using data from
223 the new config file.
224 * buildbot/slave/__init__.py: move BuildSlave out
225 * buildbot/test/test*.py: import BuildSlave from the new place
226 * buildbot/scripts/sample.cfg: update to match
227 * docs/buildbot.texinfo: update to match
228 * buildbot/process/builder.py: update comments to match
230 2007-08-02 Brian Warner <warner@lothar.com>
232 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
233 one-line-per-build pages a bit, add a header, refactor slightly
235 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
236 the TimeOutError timer, patch by Dustin Mitchell.
238 2007-08-01 Brian Warner <warner@lothar.com>
240 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
241 mostly work (branch= is still ignored, we need a useful header)
242 (OneLinePerBuildOneBuilder.body): this too
244 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
245 bring this up-to-date w.r.t. recent refactorings, and fix
246 redirections to bounce the browser to the top page after hitting
247 the 'force' button. This needs to be improved, but at least it now
248 redirects to a valid page.
249 (StatusResourceBuilder.ping): same
250 (StatusResourceBuilder.getChild): same, although I think this code
251 might be dead anyways
253 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
254 a branch= query argument, to filter the display down to builds and
255 changes that involve the given branch. You can add multiple
256 branch= arguments to see multiple branches (using a logical OR).
257 Note that there is no way to include the default branch (i.e.
258 None, i.e. trunk) yet, there is still work to be done to allow for
259 simple+uniform names of branches (i.e. removing the VC-specific
260 details of how branches are implemented, so calling the branch
261 'beta4' even though the SVN checkout step requires
262 'branches/beta4').
263 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
264 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
265 * buildbot/interfaces.py (IEventSource.eventGenerator): same
266 * docs/buildbot.texinfo (Buildbot Web Resources): document it
268 * all: bring import statements up-to-date: don't import
269 __future__, assume cPickle and cStringIO are always available.
270 Also remove #!/usr/bin/python lines from non-scripts, my editor
271 has been a bit over-enthusiastic about stuffing them into new .py
272 files.
274 * buildbot/status/web/index.html: put a link to the waterfall page
275 on the index, otherwise first-time users of WebStatus aren't going
276 to see anything very interesting.
278 * buildbot/interfaces.py (IEventSource): document this interface.
279 Thanks to Dustin Mitchell for the patch. Closes #60.
280 * buildbot/status/builder.py (BuilderStatus): same
281 * buildbot/changes/changes.py (ChangeMaster): same
283 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
284 add a query arg of 'show_events=true' to display non-build events,
285 like slaves attaching/detaching and reconfig events, or
286 'show_events=false' to hide them. The default is 'true'.
287 * docs/buildbot.texinfo (Buildbot Web Resources): document it
289 * web-parts: merge in web-parts branch. Lots of changes. The new
290 functionality is to add buildbot.status.html.WebStatus, which is a
291 superset of the Waterfall that adds new status pages and serves
292 regular files from BASEDIR/public_html/ , which is now the preferred
293 place to put robots.txt, buildbot.css, and index.html .
294 * buildbot/scripts/runner.py: the 'create-master' command now
295 creates public_html/ too, and populates it with a couple of
296 static files.
297 * buildbot/status/web: split waterfall code into smaller pieces
299 2007-07-31 Brian Warner <warner@lothar.com>
301 * buildbot/scripts/startup.py (launch): import twistd.run in a
302 different way to hush pyflakes
303 * buildbot/process/builder.py: remove unused import
305 2007-07-30 Brian Warner <warner@lothar.com>
307 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
308 Mitchell: pass SourceStamps around rather than branch/version/etc
309 tuples. Thanks Dustin! Closes #70.
310 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
311 tuple rather than a list, to avoid surprising mutations
312 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
313 * buildbot/status/mail.py (MailNotifier.buildMessage): same
314 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
315 * buildbot/test/test_status.py (Subscription): same
316 * buildbot/test/test_control.py (Force): same
317 * buildbot/test/test_buildreq.py (Request.testMerge): same
319 2007-07-29 Brian Warner <warner@lothar.com>
321 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
322 variable, since it wasn't used and is confusing in the presence of
323 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
324 for the suggestion.
326 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
327 the Buildbot home-page link to point at buildbot.net instead of
328 sourceforge, and add a current-version query parameter so we can
329 get some statistics on which versions are in use out there.
331 2007-07-28 Brian Warner <warner@lothar.com>
333 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
334 with c['change_source'], leaving c['sources'] for backwards
335 compatibility (but deprecated), scheduled for removal in 0.8.0
336 * docs/buildbot.texinfo: same
337 * buildbot/test/test_config.py: verify that c['sources'] still works
338 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
339 * buildbot/scripts/sample.cfg: update to match
341 * buildbot/changes/mail.py (MaildirSource): parse with python's
342 stdlib 'email' module, which has been available since python2.2,
343 and drop use of the 'rfc822' module, which has been depreceated
344 since python2.3 .
345 * buildbot/test/test_maildir.py: same: use parse_file() not parse
347 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
348 this needs to match the renaming in test/mail/msg*
350 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
351 Closes SF#1752648.
353 * buildbot/test/test_mailparse.py: rename sample emails a bit
354 * buildbot/test/mail/msg*: same
356 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
357 parser for the "commit-email.pl" script that is shipped with SVN,
358 written by Justin Mason. Thanks! Closes SF#1072845.
359 * buildbot/test/mail/svn-commit.*: sample messages
360 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
361 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
363 2007-07-27 Brian Warner <warner@lothar.com>
365 * buildbot/changes/mail.py: refactor: move parsing into a method
366 named 'parse', each parser type gets a separate subclass. Remove
367 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
368 to be a simple leading-substring match. Add a warning to the logs
369 if prefix= does not end in a slash, since that's probably a
370 mistake. Fix both places where a prefix= mismatch would skip all
371 subsequent files in the same email, instead of just skipping the
372 one that didn't match.
373 * buildbot/test/test_mailparse.py: match changes
375 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
376 docs on email-based ChangeSources
378 * docs/buildbot.texinfo (Getting Source Code Changes): move all
379 the changesource types up a level, removing the one-entry menu in
380 the process
382 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
383 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
384 instances instead of tuples. Closes #63.
385 * buildbot/slave/__init__.py (BuildSlave): define marker class
386 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
387 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
388 * buildbot/test/test_*.py: update tests to match
389 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
390 the c['bots'] backwards-compatibility handler works
392 2007-07-26 Brian Warner <warner@lothar.com>
394 * buildbot/changes/hgbuildbot.py (hook): add an in-process
395 Mercurial change-sending hook, contributed by Frederic Leroy.
396 Thanks! Addresses #50.
397 * docs/buildbot.texinfo (MercurialHook): document it
399 * buildbot/changes/hgbuildbot.py: change the way imports are done,
400 to make it compatible with at least hg-0.9.1 and the current 0.9.4
402 2007-07-17 Brian Warner <warner@lothar.com>
404 * buildbot/process/buildstep.py (BuildStep.getLog): add a
405 convenience method to retrieve a log added with
406 addLog()/addCompleteLog()/etc or logfiles= . I should have added
407 this two years ago..
409 2007-07-03 Brian Warner <warner@lothar.com>
411 * buildbot/slave/commands.py (ShellCommand._startCommand): when
412 logging the environment variables, put one variable on each line,
413 rather than having one really long line with all of them. This
414 should make them a bit more readable and not trigger the
415 horizontal scrollbar (when viewing it in a web browser) quite so
416 much. Thanks to Albert Hofkamp for the patch.
418 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
419 WithProperties instance. Thanks to Axel Hecht for the patch.
420 Closes #43.
421 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
422 * docs/buildbot.texinfo (Build Properties): document it
423 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
424 workdir if it didn't already exist.
426 * docs/buildbot.texinfo (Scheduler Types): correct the description
427 of Dependent schedulers. Thanks to Greg Ward for the patch.
429 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
430 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
431 the patch. Closes #49.
433 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
434 0700 before removing it, to deal with situations where a build will
435 leave files around without write permissions and the 'copy' or
436 'clobber' VC checkout modes need to blow away the tree first.
437 Thanks to Steve Milner for the suggestion and the patch (which I
438 mangled horribly). Closes #29.
439 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
440 test for it
442 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
443 an allowReconnect= argument to let callers control whether they
444 want this don't-let-it-reconnect behavior, since some tests care.
445 Factor out the .continueTrying=False lines from those callers.
446 * buildbot/test/test_slaves.py: same
447 * buildbot/test/test_run.py: same
449 2007-07-02 Brian Warner <warner@lothar.com>
451 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
452 slave has been disappeared, don't let it reconnect. This was
453 causing an intermittent failure in test_slaves.py, when the slave
454 that was supposed to be gone managed to come back by the end of
455 the test and affect the count.
456 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
457 refactorings
458 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
459 diagnostic messages to track down this problem
460 (Builder.startBuild): same
462 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
463 the slave randomly rather than always taking the first one. Thanks
464 to Pike for the patch. Closes #36.
465 * buildbot/test/test_slaves.py: match the change. to avoid huge
466 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
467 enables/disables the round-robin-ness (enabled by default), and
468 some unit tests disable it.
469 * docs/buildbot.texinfo (Buildmaster Architecture): document it
471 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
472 argument to 'buildmaster_host', to make it more obvious that this
473 points to the buildmaster. Thanks to Bob Proulx for the
474 suggestion.
475 * buildbot/scripts/runner.py (slaveTAC): same
476 * buildbot/test/test_runner.py (Create.testSlave): match the change
478 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
479 work better.
481 2007-06-17 Brian Warner <warner@lothar.com>
483 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
484 we can round-trip all of our current step classes by calling
485 getStepFactory() and using the results to make a clone of the
486 original step.
488 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
489 used in a while..
491 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
492 the config file, we're moving to using actual instances instead of
493 the (class, kwargs) 'step specification' tuples. BuildFactory
494 still keeps a list of tuples internally, but when real instances
495 are passed in to addStep(), they are asked for their class and
496 kwargs using the new BuildStep.getStepFactory method. BuildFactory
497 accepts both instances and the tuple form, and converts instances
498 to the tuple form, but the instance form is preferred because it
499 gives the Steps a chance to do argument validation. Closes: #11.
501 * buildbot/process/buildstep.py (BuildStep.__init__): record the
502 factory information necessary to implement getStepFactory. The
503 addFactoryArguments() method can be used to include arguments that
504 aren't passed to the BuildStep base class constructor.
505 (BuildStep.setBuild):
506 (BuildStep.setDefaultWorkdir): new methods to take parameters that
507 are needed for live BuildSteps but not to construct the specification
508 tuples that are stashed in the factory.
510 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
511 'workdir' into new BuildSteps by using methods instead of
512 arguments. This makes the constructor for BuildSteps a lot
513 simpler.
515 * buildbot/steps/*.py: update to match this change. Basically this
516 means adding calls to addFactoryArguments() in the __init__
517 methods to capture the arguments that aren't passed through to the
518 base class.
519 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
520 the new workdir (if any) into the RemoteShellCommands arguments.
521 * buildbot/steps/source.py: allow workdir= to be optional,
522 implement setDefaultWorkdir() since we don't inherit from
523 (CVS): finally remove old clobber=/export=/copydir= arguments,
524 in favor of the mode= argument that's been around forever now.
525 * buildbot/steps/transfer.py: remove build= argument
527 * buildbot/test/*.py: update to match, generally by turning all
528 build= arguments into subsequent calls to s.setBuild()
529 * buildbot/test/test_config.py (Factories): verify that we can
530 use either BuildStep instances or class/kwarg tuples in both
531 BuildFactory.addStep and BuildFactory.__init__
533 * docs/buildbot.texinfo (Build Steps): document the new approach,
534 mention compatibility with the old approach, update all examples
535 to use the new style.
537 2007-06-16 Brian Warner <warner@lothar.com>
539 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
540 the LoopingCall, just eat the failure so that we'll poll again
541 next time. This should allow us to tolerate (e.g.) sf.net SVN
542 failures more gracefully. Many thanks to Dustin Mitchell for the
543 patch. Closes #34.
545 2007-05-17 Brian Warner <warner@lothar.com>
547 * buildbot/status/words.py: refactor the IRC status bot into
548 separate 'Contact' and 'Channel' classes. The base Contact class
549 contains the interaction code: commands and responses. The
550 IRCContact subclass (and IrcStatusBot 'Channel') handle the
551 IRC-specific aspects. The plan is to write other subclasses for
552 other IM protocols like AIM and Jabber.
554 2007-04-16 Brian Warner <warner@lothar.com>
556 * CREDITS: update list of contributors. Thank you all!
558 2007-04-13 Brian Warner <warner@lothar.com>
560 * buildbot/status/mail.py (MailNotifier): add the project name to
561 the subject line and message body, to make it easier to
562 distinguish email coming from different buildmasters. Thanks to
563 Benoit Sigoure for the patch.
564 * buildbot/test/test_status.py (Mail): update to match
566 2007-03-24 Brian Warner <warner@lothar.com>
568 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
569 avoid text-conversion problems between DOS/windows and unix.
570 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
572 2007-03-03 Brian Warner <warner@lothar.com>
574 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
575 warning about the use of Waterfall here
577 2007-03-01 Brian Warner <warner@lothar.com>
579 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
581 2007-02-28 Brian Warner <warner@lothar.com>
583 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
584 Lamb to use a more optimal form of 'p4 changes', to reduce server
585 load. He reports that this optimization was added to p4d release
586 2005.2, but it should work in all versions. Closes #27.
587 * buildbot/test/test_p4poller.py: match it
589 2007-02-27 Brian Warner <warner@lothar.com>
591 * buildbot/status/web/*.py: move all web status stuff into a
592 separate directory, in anticipation of splitting it into smaller
593 pieces and adding more files. html.py was getting way too big.
594 * buildbot/status/classic.css: move it too
595 * setup.py: add the new sub-package
596 * buildbot/test/test_web.py: match the changes
597 * MANIFEST.in: handle the move of classic.css
599 2007-02-07 Brian Warner <warner@lothar.com>
601 * contrib/OS-X/*: add some launchd .plist files for automatically
602 starting a buildmaster or buildslave under OS-X (10.4 or later).
603 Thanks to Mark Pauley for these.
605 2007-02-06 Brian Warner <warner@lothar.com>
607 * docs/buildbot.texinfo (Requirements): update requirements to
608 stop claiming compatibility with python-2.2 or twisted-1.3.x .
609 Closes #13.
610 * README: mention python-2.5 and twisted-2.5 compatibility
612 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
613 redundant import
614 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
615 compatibility
616 * buildbot/status/builder.py: same, by requiring cStringIO
617 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
618 * buildbot/test/test_vc.py: same
619 * buildbot/test/test_web.py:
620 * buildbot/test/test_steps.py: same, remove unused import
622 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
623 the FORM tag
625 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
626 see any Builders that don't have Schedulers to drive them
628 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
629 attributes this uses went away
631 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
632 dialog, to allow you to reset the buildmaster and force
633 connect/disconnect. Correctly handle losing the buildmaster
634 connection (by switching the display to the hexnut, at which point
635 you can use the 'Connect' menu item to reconnect).
637 * buildbot/steps/source.py (Source.start): if we're using a patch,
638 add it as a LogFile to the checkout/update step. This will turn
639 into a link on the waterfall page.
641 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
642 option, to take the patch from a pre-made file rather than
643 generating it from the local tree. Thanks to Robert Helmer for the
644 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
645 * buildbot/scripts/runner.py (TryOptions): add --diff,
646 --patchlevel, and --baserev options
647 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
648 as None, meaning HEAD.
649 * buildbot/sourcestamp.py (SourceStamp): update docstring to
650 indicate that baserev=None means HEAD
651 * docs/buildbot.texinfo (try --diff): document it
653 * buildbot/test/test_steps.py (BuildStep): remove use of
654 reactor.iterate(), although the technique I replaced it with is a
655 gross polling hack that must be cleaned up properly some day. This
656 was the last use of reactor.iterate in the entire tree, yay.
658 2007-02-05 Brian Warner <warner@lothar.com>
660 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
661 is one of the three known values, otherwise we emit some confusing
662 messages later on. Thanks to Grig Gheorghiu for the catch.
664 2007-01-30 Brian Warner <warner@lothar.com>
666 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
667 Hearsum contributed a patch to let BonsaiPoller work with results
668 that contain non-ascii characters. Closes SF#1632641.
670 2007-01-27 Brian Warner <warner@lothar.com>
672 * Makefile (release): produce both .tar.gz and .zip source bundles.
673 Closes SF#1222216.
675 2007-01-23 Brian Warner <warner@lothar.com>
677 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
678 * buildbot/changes/monotone.py: same
680 * buildbot/changes/maildir.py: combine several files into one,
681 clean up maildir.py to use Services properly.
682 * buildbot/changes/maildirtwisted.py: remove
683 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
684 buildbot anyways.
685 * buildbot/changes/mail.py: match the change
686 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
687 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
689 * buildbot/slave/commands.py (command_version): bump to "2.3" to
690 indicate that the buildslave knows about the 'bzr' command
692 2007-01-22 Brian Warner <warner@lothar.com>
694 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
695 'with', it will become a reserved work in python2.6 .
697 * contrib/bb_applet.py: add a simple gnome-panel applet, to
698 display a terse summary of buildbot status.
699 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
700 some icons, small versions of the Blender object that lives in
701 docs/images/icon.blend
703 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
704 * buildbot/slave/commands.py (Bzr): same
705 * buildbot/scripts/tryclient.py (BzrExtractor): same
706 (SourceStampExtractor.dovc): modify this to allow non-zero exit
707 status, since 'bzr diff' does that
708 * buildbot/test/test_vc.py (Bzr): same
709 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
710 add notes on bzr
711 (Bzr): document it
713 2007-01-20 Brian Warner <warner@lothar.com>
715 * contrib/darcs_buildbot.py: tidy up the progress messages
717 2007-01-17 Brian Warner <warner@lothar.com>
719 * contrib/darcs_buildbot.py: enhance to handle multiple patches
720 being pushed at a time. This keeps state in the repository in a
721 small file named .darcs_buildbot-lastchange, but that shouldn't
722 interfere with normal repository operations. Fixes SF#1534049.
723 * buildbot/clients/sendchange.py (Sender): make a single Sender
724 capable of sending Changes with different usernames.
726 2006-12-11 Brian Warner <warner@lothar.com>
728 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
729 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
730 buildbot.changes.mail a long time ago, but I forgot to add the
731 DeprecationWarning until now.
733 * buildbot/process/maxq.py: remove this, the functionality now
734 lives in buildbot.steps.maxq
736 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
737 * buildbot/clients/gtkPanes.py: remove unused import
739 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
740 that was meant to provide a special Reporter to run inside trial
741 and give the buildslave lots of machine-readable status. We never
742 finished this project.
744 * buildbot/changes/bonsaipoller.py: remove unused imports
745 * buildbot/changes/svnpoller.py: same
746 * buildbot/process/builder.py: same
747 * buildbot/process/buildstep.py: same
748 * buildbot/slave/bot.py: hush pyflakes warning
749 * buildbot/status/tests.py: remove unused imports
750 * buildbot/status/tinderbox.py: same
751 * buildbot/steps/python_twisted.py: same
753 * buildbot/process/step.py: remove this file, these names were
754 deprecated in 0.7.5 and are now being removed.
755 * buildbot/process/step_twisted.py: same
756 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
758 * buildbot/twcompat.py: remove the empty file, yay it is gone
760 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
761 tw-2.0.0 and newer have the method we need.
762 (getProcessOutputAndValue): same
763 (which): remove this method, tw-2.0.0 t.p.procutils has it
765 * buildbot/twcompat.py (implements): remove this method
766 * buildbot/*: import implements() from zope.interface directly
768 * buildbot/status/mail.py: stop falling back to importing
769 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
770 support
772 * buildbot/twcompat.py (Interface): remove this import
773 * buildbot/*: import Interface from zope.interface directly
775 * buildbot/twcompat.py (providedBy): remove this method
776 * buildbot/*: turn all uses of providedBy(obj, iface) into
777 iface.providedBy(obj)
779 * buildbot/twcompat.py (maybeWait): remove this method, now that
780 we no longer maintain compatibility with Twisted<=1.3.0 .
781 Twisted-2.0.0 and later allow trial methods to return Deferreds
782 directly.
783 * buildbot/test/*: remove all uses of maybeWait
785 * buildbot/__init__.py (version): bump to 0.7.5+ while between
786 releases
787 * docs/buildbot.texinfo: same
789 2006-12-10 Brian Warner <warner@lothar.com>
791 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
792 * docs/buildbot.texinfo: set version to match
794 2006-12-10 Brian Warner <warner@lothar.com>
796 * README (REQUIREMENTS): update for release
797 * NEWS: update for release
798 * buildbot/slave/commands.py (command_version): mention that this
799 version (2.2) was released with buildbot-0.7.5
801 * buildbot/test/test_config.py (StartService.testStartService):
802 inhibit the usual read-config-on-startup behavior, since otherwise
803 the log.err that gets recorded causes the test to fail
805 * buildbot/status/builder.py (LogFile.finish): forget about all
806 subscribers once the log has finished, since after that point
807 we're never going to use them again. This might help free up some
808 memory somewhere.
810 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
811 than the old/deprecated gtk.mainquit()
813 2006-12-09 Brian Warner <warner@lothar.com>
815 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
816 better when we can't open the masterdst file
818 * buildbot/scripts/startup.py (Follower._failure): add missing
819 import statement for BuildSlaveDetectedError
821 * buildbot/steps/transfer.py (FileUpload): cleanup
822 (FileDownload): same. Add tests for slave version, add mode=.
823 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
824 (SlaveFileDownloadCommand): same
825 * buildbot/test/test_transfer.py: enhance tests
826 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
827 step.slaveVersion
829 2006-12-08 Brian Warner <warner@lothar.com>
831 * buildbot/scripts/runner.py (sendchange): halt the reactor on
832 both success *and* failure. Without this, the 'buildbot
833 sendchange' command would hang if it could not contact the
834 buildmaster or deliver the Change, which would generally cause the
835 user's commit/record/checkin command to hang too. Thanks to
836 Christian Unger for the catch.
838 2006-12-06 Brian Warner <warner@lothar.com>
840 * NEWS: update with items for the next release
842 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
843 whimsical example pulled from a punch-drunk email I sent out late
844 one night.
845 (Transferring Files): document some of the other parameters
846 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
847 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
848 * buildbot/test/test_svnpoller.py: same
849 * buildbot/changes/svnpoller.py (SVNPoller): same
851 2006-11-26 Brian Warner <warner@lothar.com>
853 * docs/buildbot.texinfo (Build Properties): remind users that
854 WithProperties must appear in a command= list, not as a top-level
855 instance.
856 * buildbot/steps/shell.py (ShellCommand.start): and assert that
857 we're sending a list or a single string to the RemoteShellCommand
859 * buildbot/scheduler.py (Nightly): Improve docs slightly.
861 * buildbot/scripts/startup.py (start): skip the whole
862 watch-the-logfile thing under windows, since it needs os.fork()
864 * buildbot/scripts/runner.py (restart): remove the old message
865 that got printed after the buildbot was restarted.. it most cases
866 it didn't get printed at the right time anyways
868 2006-11-25 Brian Warner <warner@lothar.com>
870 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
871 follow twistd.log and print lines until the process has started
872 started properly. For the buildmaster, this means until the config
873 file has been parsed and accepted. For the buildslave, this means
874 until we've connected to the master. We give up after 5 seconds in
875 any case. Helpful error messages and troubleshooting suggestions
876 are printed when we don't see a successful startup. This closes the
877 remainder of SF#1517975.
878 * buildbot/scripts/startup.py: moved app startup code to here
879 * buildbot/scripts/logwatcher.py: utility class to follow log
880 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
881 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
882 so the LogWatcher can tell the difference between a buildmaster
883 and a buildslave
885 2006-11-24 Brian Warner <warner@lothar.com>
887 * docs/examples/twisted_master.cfg: update to match the version
888 in use on twistedmatrix.com
889 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
890 was using before stopped working, but 'irc.freenode.net' works
891 just fine.
893 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
894 'reconfig' command
896 * buildbot/clients/base.py (TextClient.not_connected): upon
897 UnauthorizedLogin failures, remind the user to connect to the
898 PBListener port instead of the slaveport.
899 (TextClient.disconnected): shut down more quietly
900 * docs/buildbot.texinfo (statuslog): add another reminder
902 * buildbot/scripts/runner.py (Options.subCommands): rename
903 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
904 'sighup' as an alias.
905 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
906 reconfig command to follow twistd.log and print all of the lines
907 from the start of the config-file reload to its completion. This
908 should make it a lot easier to discover bugs in the config file.
909 Use --quiet to disable this behavior. This addresses half of
910 SF#1517975, the other half will be to add this same utility to
911 'buildbot start' and 'buildbot restart'.
912 * docs/buildbot.texinfo (Loading the Config File): same
913 (Shutdown): same
915 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
916 method, it has been deprecated for a long time. Use
917 IBuilderControl.requestBuild instead.
918 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
919 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
920 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
921 * buildbot/test/test_control.py (Force.testForce): same
922 * buildbot/test/test_run.py: use requestBuild instead
924 * buildbot/clients/debug.py: replace 'Force Build' button with
925 'Request Build' (which just adds one to the queue), add Ping
926 Builder, add branch/revision fields to Request Build.
927 * buildbot/clients/debug.glade: same
928 * buildbot/master.py: update interface to match. This creates an
929 incompatibility between new debugclients and old buildmasters.
931 * buildbot/process/builder.py (Builder._attached): delay the call
932 to maybeStartBuild for a reactor turn, to avoid starting a build
933 in the middle of a reconfig (say, if the new Builder uses a new
934 slave which is already connected).
936 2006-11-23 Brian Warner <warner@lothar.com>
938 * buildbot/test/test_transfer.py: appease pyflakes
939 * buildbot/test/test_steps.py: same
941 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
942 keeps pyflakes from finding undefined names
944 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
945 Builder no longer induces a disconnect/reconnect cycle. This means
946 that any builds currently in progress will not be interrupted, and
947 any builds which are queued in the Builder will not be lost. This
948 is implemented by having the new Builder extract the state (i.e.
949 all pending Builds and any desired SlaveBuilders) from the old
950 Builder.
951 (BotPerspective): refactor. The BotPerspective no longer keeps
952 track of all the Builders that want to use this slave; instead, it
953 asks the BotMaster each time it needs this list. This removes
954 addBuilder and removeBuilder. Clean up attached() to acquire all
955 the slave's information in a more atomic fashion. updateSlave() is
956 now the way to make sure the slave is using the right set of
957 Builders: just call it after everything else has been
958 reconfigured.
959 (BotMaster): refactor, removing addBuilder/removeBuilder and
960 replacing them with an all-at-once setBuilders() call.
962 * buildbot/test/test_slaves.py (Reconfig): new test case to
963 exercise this functionality
964 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
965 * buildbot/slave/commands.py (WaitCommand): same
967 * docs/buildbot.texinfo (Loading the Config File): document the
968 changes
970 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
971 SlaveBuilder to have its parent Builder changed.
972 (SlaveBuilder.isAvailable): new method to give access to state,
973 which is now a private attribute
974 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
975 the SlaveBuilder about how it is being used. These methods update
976 its internal state. buildFinished() is now the place that invokes
977 maybeStartBuild() on its parent Builder.
978 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
979 new Builder to take over for an old one, transferring state from
980 the old one.
981 (Buider): refactor the way that SlaveBuilders are used to match,
982 giving them a bit more autonomy.
983 (Builder.buildFinished): this no longer calls maybeStartBuild():
984 instead the SlaveBuilder calls it on whoever its parent Builder is
985 at the time. This way, when an old Builder is replaced by a new
986 one, and there was a build in progress during the transition, when
987 that build finishes, it will be the new Builder that is told about
988 the newly available slave so it can start a new build.
990 * buildbot/process/base.py (Build.startBuild._release_slave): when
991 the Build finishes, tell the SlaveBuilder that they've been
992 released.
994 * buildbot/status/builder.py (SlaveStatus): add some new setter
995 methods for use by BotPerspective, to keep some attributes more
996 private
998 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
999 called by the buildmaster.
1000 (Bot.setBuilderList): instead, we locally announce any leftover
1001 directories based upon which Builders we were told about. The
1002 master doesn't really care; it's the local admin who may or may not
1003 wish to delete them.
1006 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1007 to allow use of python2.4 or whatever. This tool still requires
1008 python2.3 or newer.
1010 2006-11-19 Brian Warner <warner@lothar.com>
1012 * NEWS (IStatusLog.readlines): more news items
1014 2006-11-18 Brian Warner <warner@lothar.com>
1016 * NEWS: start collecting items for the next release.
1018 2006-11-04 Brian Warner <warner@lothar.com>
1020 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1021 Hearsum. Closes SF#1590310.
1022 * buildbot/test/test_bonsaipoller.py: and tests
1024 * buildbot/status/tinderbox.py
1025 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1026 status when the build results in WARNINGS. Patch from Dave
1027 Liebreich. Closes SF#1587352.
1029 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1030 linux-vs-osx behavior difference w.r.t. reading from files that
1031 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1032 to Mark Rowe for the patch.
1034 2006-10-15 Brian Warner <warner@lothar.com>
1036 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1037 method name was misspelled in the interface definition. Thanks to
1038 Roy Rapoport for the catch.
1040 2006-10-13 Brian Warner <warner@lothar.com>
1042 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1043 to match the great Steps renaming
1045 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1046 Maybe I should run my own unit tests before recording a big
1047 change. Good thing I've got a buildbot to remind me.
1049 2006-10-12 Brian Warner <warner@lothar.com>
1051 * buildbot/steps/transfer.py: rework __init__ and args setup
1052 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1053 docs improvements
1054 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1055 when opening the target file, only catch IOError (to report via
1056 stderr/rc!=0), let the others be reported as normal exceptions
1058 2006-10-08 Brian Warner <warner@lothar.com>
1060 * contrib/svn_watcher.py: fix security holes by using proper argv
1061 arrays and subprocess.Popen() rather than commands.getoutput().
1062 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1063 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1064 probably be removed by the next release.
1065 * CREDITS: add Nick
1067 2006-10-04 Brian Warner <warner@lothar.com>
1069 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1070 initial lines that weren't emitted by pyflakes. When the pyflakes
1071 command is run under a Makefile, 'make' will echo the command it
1072 runs to stdio, and that was getting logged as a "misc" warning.
1073 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1074 * buildbot/test/test_steps.py (testPyFlakes3): another test
1076 2006-10-01 Brian Warner <warner@lothar.com>
1078 * buildbot/status/html.py (HtmlResource.render): if we get a
1079 unicode object from our content() method, encode it into utf-8
1080 like we've been claiming to all along. This allows the comments
1081 and author names from svnpoller.py to be delivered properly.
1083 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1084 de-unicodify filenames before creating the Change, because the
1085 rest of buildbot is unlikely to handle them well. Leave the 'who'
1086 field as a unicode object.. I don't think there's anything that
1087 will break very soon, and it will probably nudge us towards
1088 accepting unicode everywhere sooner or later. Stop using the
1089 "date" field that comes out of SVN, since it is using the
1090 repository's clock (and timezone) and what we care about is the
1091 buildmaster's (otherwise Changes from the future show up later
1092 than the builds they triggered).
1093 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1094 change to .when
1096 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1097 Suvbersion repository polling ChangeSource. I've hacked it up
1098 considerably: any bugs are entirely my own fault. Thank you
1099 Niklaus!
1100 * buildbot/test/test_svnpoller.py: tests for it
1101 * docs/buildbot.texinfo (SvnSource): document it
1103 2006-09-30 Brian Warner <warner@lothar.com>
1105 * buildbot/scheduler.py (Periodic): submit a reason= to the
1106 BuildSet to indicate which Scheduler triggered the build. Thanks
1107 to Mateusz Loskot for the suggestion.
1108 (Nightly): same
1109 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1111 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1112 changes: set self.loop in __init__, remove unused volatile=
1114 * docs/buildbot.texinfo (.buildbot config directory): add more
1115 docs on the .buildbot/options keys used by "buildbot try"
1116 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1117 (Try.deliverJob): same
1119 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1120 from Robert Helmer
1121 (BonsaiPoller): same
1123 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1124 close the filehandle when we stop watching the file. Before, the
1125 filehandle was only closed when the LogFileWatcher was
1126 garbage-collected, which could be quite a while in the future. If
1127 it was still open by the time the next build started, windows will
1128 refuse to let the new build delete the old build/ directory. Fixes
1129 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1130 #twisted for the catch.
1132 2006-09-29 Brian Warner <warner@lothar.com>
1134 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1135 from Robert Helmer
1137 2006-09-25 Brian Warner <warner@lothar.com>
1139 * setup.py: the new buildbot.steps module wasn't being installed.
1140 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1141 (testmsgs): add the extra stuff from buildbot/test/* so you can
1142 run unit tests on an installed copy of buildbot, not just from
1143 the source tree.
1145 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1146 columns of 'svnlook changed' output contain status information, so
1147 strip [:4] instead of [:6]. Depending upon what the status flags
1148 were, this would sometimes lead to mangled filenames. Thanks to
1149 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1151 * buildbot/steps/source.py (Monotone): initial Monotone support,
1152 contributed by Nathaniel Smith. Still needs docs and tests, but
1153 this code has been in use on the Monotone buildbot for a long
1154 time now.
1155 * buildbot/slave/commands.py (Monotone): slave-side support
1156 * buildbot/changes/monotone.py (MonotoneSource): polling change
1157 source
1159 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1160 contributed a Change Source that polls a Bonsai server (a
1161 kind of web-based viewcvs CGI script).
1163 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1164 Hearsum contributed a status plugin which sends email in the same
1165 format that Tinderbox does: this allows a number of tinderbox
1166 tools to be driven by Buildbot instead. Thanks Ben!
1168 2006-09-24 Brian Warner <warner@lothar.com>
1170 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1171 Thanks to Robert Helmer for the patch.
1173 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1174 BuildStatus about the buildslave name at the *beginning* of the
1175 build, rather than at the end. Thanks to Alexander Lorenz for the
1176 patch.
1177 * buildbot/status/html.py (StatusResourceBuild.body): always
1178 include the slavename in the build page, not just when the build
1179 has finished.
1180 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1181 slavename in the email message
1183 2006-09-21 Brian Warner <warner@lothar.com>
1185 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1186 from buildbot.steps
1187 * docs/examples/glib_master.cfg: same
1188 * docs/examples/hello.cfg: same
1189 * docs/examples/twisted_master.cfg: same, update to current usage
1191 2006-09-19 Brian Warner <warner@lothar.com>
1193 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1194 (PyFlakes.createSummary): make it compatible with python-2.2
1196 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1197 for at least the output-parsing parts of PyFlakes
1199 2006-09-18 Brian Warner <warner@lothar.com>
1201 * buildbot/steps/python.py: oops, fix import of StringIO
1203 2006-09-17 Brian Warner <warner@lothar.com>
1205 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1206 turns out that SVN-1.4.0 doesn't fail to update once you've
1207 replaced a file with a directory, unlike older versions of SVN and
1208 pretty much every other VC tool we support. Since what we really
1209 care about is that the update succeeds anyway, stop checking that
1210 the tree got clobbered and just assert that the build succeeded.
1211 (VCBase.printLogs): add a utility function for debugging
1213 * buildbot/process/step.py: oops, added extra imports by mistake
1215 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1216 rstrip() on the first line coming out of the 'p4 describe'
1217 process, to remove the stray ^M that Wade Brainerd reports seeing
1218 in the 'when' field. Fixes SF#1555985.
1220 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1221 message logged when c['schedulers'] is not right
1222 * buildbot/scheduler.py (Scheduler.__init__): improve error
1223 message when a Scheduler() is created with the wrong arguments
1224 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1225 verify that these error messages are emitted
1227 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1228 The idea is that all the base classes (like BuildStep and
1229 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1230 will be a leftover backwards-compatibility file that only contains
1231 aliases for the steps that were moved out to buildbot.steps.*
1232 * lots: change imports to match
1233 * buildbot/process/step.py: add a DeprecationWarning if it ever
1234 gets imported
1236 2006-09-12 Brian Warner <warner@lothar.com>
1238 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1239 builderNames= is actually a sequence, since if you happen to give
1240 it a single builder-specification dictionary instead, it won't get
1241 caught by the existing assert. Thanks to Brett Neely for the
1242 catch.
1244 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1245 tests yet, alas.
1246 * docs/buildbot.texinfo (Python BuildSteps): document them
1247 (sendchange): include a link to PBChangeSource, since you need one
1249 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1250 unnecessary imports
1251 * buildbot/steps/dummy.py: same
1253 2006-09-08 Brian Warner <warner@lothar.com>
1255 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1256 BuildStep which lets you transfer files from the master to the
1257 slave or vice versa. Thanks to Albert Hofkamp for the original
1258 patch. Fixes SF#1504631.
1259 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1260 support for it
1261 (SlaveFileDownloadCommand): same
1262 * docs/buildbot.texinfo (Transferring Files): document it
1263 * buildbot/test/test_transfer.py: test it
1264 * buildbot/test/runutils.py (StepTester): new utility class for
1265 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1266 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1267 utility class works
1269 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1270 walk through StatusLogs one line at a time, mostly for the benefit
1271 of ShellCommand.createSummary methods. You can either walk through
1272 STDOUT or STDERR, but the default is STDOUT.
1274 * buildbot/status/builder.py (LogFile.readlines): implement it.
1275 Note that this is not yet memory-efficient, it just pulls the
1276 whole file into RAM and then splits it up with a StringIO.
1277 Eventually this should be a generator that only pulls chunks from
1278 disk as necessary.
1279 * buildbot/test/test_status.py (Log.testReadlines): test it
1281 * docs/buildbot.texinfo: update to match changes
1282 * buildbot/process/factory.py: stop using old definitions
1283 * buildbot/process/process_twisted.py: same
1284 * buildbot/test/test_*.py: same
1286 * buildbot/process/step_twisted.py: move definition to..
1287 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1288 relative-import mechanisms prevent this from being named 'twisted'
1289 or 'python/twisted' as I would have preferred.
1291 * buildbot/process/maxq.py: move definition to..
1292 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1294 * buildbot/process/step.py: split the user-visible BuildSteps into
1295 separate files, all under buildbot/steps/
1296 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1297 * buildbot/steps/shell.py: this holds ShellCommand and friends
1298 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1300 2006-09-05 Brian Warner <warner@lothar.com>
1302 * lots: run pyflakes, removed a lot of unused imports, changed the
1303 form of some conditional imports to remove false pyflakes
1304 warnings. There are still a number of warnings left, mostly from
1305 imports that are done for their side-effects.
1306 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1307 was missing
1309 2006-08-26 Brian Warner <warner@lothar.com>
1311 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1312 compatible with twisted-1.3.0, for some reason I just can't seem
1313 to let go of the past.
1315 2006-08-25 Brian Warner <warner@lothar.com>
1317 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1319 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1320 all logfiles= in startCommand(), rather than in start() . This
1321 makes it easier to have the 'stdio' log come before any secondary
1322 logfiles, which I feel makes the waterfall display more
1323 understandable.
1324 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1325 from ShellCommand up into LoggingBuildStep
1326 (LoggingBuildStep.__init__): move the handling of logfiles= from
1327 ShellCommand up to LoggingBuildStep, because startCommand is
1328 provided by LoggingBuildStep, whereas start() was specific to
1329 subclasses like ShellCommand and Source. This removes code
1330 duplication in those subclasses.
1331 (ShellCommand.__init__): same
1332 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1333 for a slave that's too old to understand logfiles= into a separate
1334 method, so it can live in ShellCommand. The rest of
1335 setupLogfiles() can live in LoggingBuildStep.
1337 2006-08-24 Brian Warner <warner@lothar.com>
1339 * buildbot/locks.py (BaseLock): you can now configure Locks to
1340 allow multiple simultaneous owners. They still default to
1341 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1342 the patch.
1343 * docs/buildbot.texinfo (Interlocks): document the new options
1344 * buildbot/test/test_locks.py: add a bunch of new unit tests
1345 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1346 waitUntilMaybeAvailable, not waitUntilAvailable
1347 * buildbot/process/step.py (BuildStep.acquireLocks): same
1348 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1349 the whole lockid in their constructor, not just the name. Also,
1350 keep track of which real locks we've handed out by the full
1351 lockid, not just class+name, otherwise changing just the maxCount=
1352 in the master.cfg file would not actually cause a behavioral
1353 change
1355 2006-08-23 Brian Warner <warner@lothar.com>
1357 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1358 releases
1359 * docs/buildbot.texinfo: same
1361 2006-08-23 Brian Warner <warner@lothar.com>
1363 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1364 * docs/buildbot.texinfo: set version to match
1365 * NEWS: update for 0.7.4
1366 * buildbot/slave/commands.py (command_version): mention that this
1367 version (2.1) was released with buildbot-0.7.4
1369 2006-08-22 Brian Warner <warner@lothar.com>
1371 * README: update
1373 * CREDITS: new file, list of people who have helped. Thanks!
1374 * MANIFEST.in: ship it
1376 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1377 new diagrams, the user's manual is more informative than it was.
1378 Start shipping the .html user's manual (and generated .png
1379 images).
1380 * Makefile: update 'release' target to match
1382 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1383 test.. I think the web-parts effort will render it pointless well
1384 before it ever actually starts to work.
1386 2006-08-20 Brian Warner <warner@lothar.com>
1388 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1389 meaning of the prefix= argument. It is now just a string which is
1390 stripped from the beginning of the filename. If prefix= is set but
1391 not found on any given filename, that filename is ignored. If all
1392 filenames in a Change are ignored, the Change is dropped. This is
1393 much simpler than the previous sep= nonsense, and I should have
1394 implemented it this way from the beginning. Effectively resolves
1395 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1396 Gedminas for the catch and suggested fixes.
1397 (ChangePerspective.perspective_addChange): implement the actual
1398 prefix comparison
1399 * buildbot/test/test_changes.py (TestChangePerspective): test it
1400 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1401 how to properly use prefix=
1402 * docs/examples/twisted_master.cfg (source): update prefix= by
1403 adding the trailing slash
1406 * docs/examples/twisted_master.cfg: update to actual practice
1408 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1409 update test case to match new link text.. the HREF has both a
1410 class= setting and an enclosing [] pair that I didn't match in the
1411 test.
1413 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1414 list of strings is preferred over a single string with embedded
1415 spaces
1416 (ShellCommand.description=): explain that either single strings or
1417 a list of strings is acceptable, and why you might prefer one over
1418 the other. Add an example. Fixes SF#1524659, thanks to Paul
1419 Winkler for the catch.
1420 (Build Steps): update to use f.addStep() rather than using s()
1421 and the constructor list
1423 * buildbot/process/step.py (ShellCommand): accept either a single
1424 string or a list of strings in both description= and
1425 descriptionDone=
1426 * buildbot/test/test_steps.py (Steps.test_description): test it
1427 * buildbot/test/runutils.py (makeBuildStep): support for that test
1429 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1430 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1431 collecting the files and creating the patch.
1433 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1434 per-step URLs that will be displayed on the waterfall display,
1435 for things like the HTML output of code-coverage tools, when
1436 the results are hosted elsewhere.
1437 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1438 way to retrieve these URLs
1439 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1440 the method to retrieve these URLs. Also provide backwards
1441 compatibility for saved BuildStepStatus instances that didn't have
1442 the .urls attribute
1443 * buildbot/process/step.py (BuildStep.addURL): method to set these
1444 URLs from within a BuildStep
1445 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1446 (StepBox.getBox): give these external links a distinct CSS class
1447 named "BuildStep external" so a .css file can display them
1448 differently
1450 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1451 do emit those links
1452 * buildbot/test/test_steps.py (Steps): test that we can all the
1453 URLs. Also add a bunch of other tests on methods that can be
1454 called from within BuildSteps
1455 * buildbot/test/runutils.py (makeBuildStep): add utility function
1457 2006-08-13 Brian Warner <warner@lothar.com>
1459 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1461 2006-08-10 Brian Warner <warner@lothar.com>
1463 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1464 index, this one of things like c['sources'] and c['schedulers']
1465 (indices): it looks like my clever idea of putting the @fooindex
1466 commands in between the @node and the @subsection (to make the
1467 HREF anchor jump to slightly above the section title, which works
1468 much better in html) confused texinfo horribly, so I'm moving the
1469 index tags back to be just after the @subsection marker. I also
1470 added extra lines between the @node/@section paragraph and the
1471 index tags, since I think maybe texinfo wants to see these be
1472 separate paragraphs.
1474 * docs/Makefile (images): make sure images get built when
1475 rendering the manual
1476 * docs/images/Makefile: same
1478 * buildbot/scripts/runner.py: rename 'buildbot master' to
1479 'buildbot create-master', and 'buildbot slave' to 'buildbot
1480 create-slave'
1481 * docs/buildbot.texinfo: same
1482 * README: same
1484 * docs/buildbot.texinfo: reimplement the "useful classes" index
1485 with actual texinfo indices. The .info rendering is a bit
1486 weird-looking but it works well, and the HTML rendering is quite
1487 nice. This also puts the index targets in the regular flow of the
1488 text, which is easier to maintain.
1490 2006-08-06 Brian Warner <warner@lothar.com>
1492 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1493 Kevin Turner to prefer the environ= argument be a list rather than
1494 a string. If it is a list, it will be joined with a platform-local
1495 os.pathsep delimiter, and then prepended to any existing
1496 $PYTHONPATH value. This works better in cross-platform (i.e.
1497 windows buildslaves) environments when you need to push multiple
1498 directories onto the front of the path.
1499 (SlaveShellCommand): documented the new magic
1500 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1501 in a user-visible form
1503 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1504 Turner to prefer lists over strings when creating/running VC
1505 commands during unit tests. This is clearly necessary to survive
1506 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1507 renamed the wq() function to qw() though, since that's how it's
1508 spelled in perl. Eventually I'd prefer all commands to be
1509 specified with lists.
1511 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1512 which are deleted (or not yet created) correctly. Also add
1513 failsafe code to not explode if the file-watching poller doesn't
1514 get started. Thanks to JP Calderone for the catch and the poller
1515 patch.
1516 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1517 for that case
1518 * buildbot/test/emitlogs.py: same
1520 * NEWS: summarize recent changes
1522 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1523 clause to avoid the "host key mismatch" warning
1525 * buildbot/process/step_twisted.py (Trial.start): if the
1526 buildslave is too old to understand logfiles=, fall back to
1527 running 'cat _trial_temp/test.log' like before.
1528 (Trial.commandComplete): same. this takes advantage of the
1529 LoggingBuildStep refactoring to stall commandComplete long enough
1530 to run a second RemoteShellCommand.
1532 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1533 refactor command-completion handling, to allow methods like
1534 commandComplete/createSummary/evaluateCommand to return Deferreds.
1535 (LoggingBuildStep._commandComplete): delete the refactored method
1536 (ShellCommand.setupLogfiles): if the buildslave is too old to
1537 understand logfiles=, put a warning message both into twistd.log
1538 and into the otherwise empty user-visible LogFiles.
1540 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1541 callers to provide the slave-side logfile name, rather than
1542 forcing it to come from the local name of the LogFile.
1543 (BuildStep.getSlaveName): new method
1545 * buildbot/process/base.py (Build.getSlaveName): new method, so
1546 steps can find out which buildslave they're running on
1548 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1549 to match the s/cvs_ver/command_version/ change
1551 2006-08-05 Brian Warner <warner@lothar.com>
1553 * buildbot/slave/commands.py (command_version): replace the CVS
1554 auto-updated cvs_ver keyword with a manually-updated variable,
1555 since CVS is no longer the master repository. Add a description of
1556 the remote API change starting in this version (2.1), specifically
1557 the fact that SlaveShellCommand now accepts 'initial_stdin',
1558 'keep_stdin_open', and 'logfiles'.
1560 2006-07-31 Brian Warner <warner@lothar.com>
1562 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1563 diagrams to describe how the whole system fits together. The
1564 images themselves are kept in SVG files, with ascii-art versions
1565 in corresponding .txt files. Texinfo knows how to interpolate the
1566 text version into .info files, reference the .png versions from
1567 .html files, and include .eps versions in the .ps format.
1568 * docs/images/Makefile: tools to create .png and .eps
1569 * docs/images/*.svg: created pictures with Inkscape.
1570 * .darcs-boring: ignore the generated .eps and .png files
1572 2006-07-24 Brian Warner <warner@lothar.com>
1574 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1575 Scheduler names, since they cause setServiceParent to explode
1576 later.
1577 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1579 2006-07-20 Brian Warner <warner@lothar.com>
1581 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1582 which runs the buildbot unit tests
1584 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1585 classes that are useful in master.cfg
1587 2006-07-15 Brian Warner <warner@lothar.com>
1589 * Makefile (some-apidocs): new target to build only some epydocs
1591 * setup.py: minor comment.. does the classifiers= argument prevent
1592 the setup.py script from working on python2.2/2.3?
1594 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1595 major sections
1597 * buildbot/twcompat.py: fix minor typo in comments
1599 * buildbot/manhole.py: move all Manhole-related code out to this
1600 module. Implement SSH-based manholes (with TwistedConch), and move
1601 to conch's nifty line-editing syntax-coloring REPL shell instead
1602 of the boring non-editing monochromatic (and deprecated) old
1603 'telnet' protocol.
1604 * buildbot/master.py: remove all Manhole-related code
1605 (BuildMaster.loadConfig._add): make sure the old manhole is
1606 removed before we add the new one
1607 * docs/buildbot.texinfo (Debug options): document new Manhole options
1609 * buildbot/twcompat.py (_which): fix some epydoc issues
1610 * buildbot/status/html.py (Waterfall.__init__): same
1612 2006-06-29 Brian Warner <warner@lothar.com>
1614 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1615 deprecation warnings under newer Twisteds (by using
1616 zope.interface.Interface instead of old twisted.python.components
1617 stuff)
1618 * buildbot/slave/interfaces.py: same
1620 2006-06-28 Brian Warner <warner@lothar.com>
1622 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1623 svn commands, so it will fail immediately instead of hanging while
1624 it waits for a username/password to be typed in.
1626 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1627 log message if the step was shut down
1629 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1630 obsolete reference to mktap.
1632 2006-06-20 Brian Warner <warner@lothar.com>
1634 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1635 test to include new 'logfiles' argument sent from master to slave
1637 2006-06-19 Brian Warner <warner@lothar.com>
1639 * buildbot/process/step_twisted.py (Trial): track Progress from
1640 _trial_temp/test.log too
1642 * buildbot/process/step.py (OutputProgressObserver): generalize
1643 the earlier StdioProgressObserver into an OutputProgressObserver
1644 that can track LogFiles other than stdio.
1645 (LoggingBuildStep.__init__): same
1647 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1648 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1649 will fail under windows because of os.sep issues. It might have
1650 worked before if 'cat' was doing cygwin path conversion.
1652 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1653 creation of LogFileWatchers
1654 (ShellCommand._startCommand): and record the files that were
1655 watched in the 'headers' section of the ShellCommand output
1657 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1658 need to actually pass it to the slave if you want it to work.
1659 (ShellCommand): document it a bit
1661 * buildbot/test/test_shell.py: new test to validate LogFiles
1662 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1663 test LogFiles
1664 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1665 before printing the last batch of lines, to test that the polling
1666 logic is working properly
1668 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1669 handling, making it possible to track multiple logs for a single
1670 RemoteCommand. The previous single logfile is now known as the
1671 'stdio' log.
1672 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1673 (RemoteShellCommand.__init__): accept logfiles=
1674 (LoggingBuildStep.startCommand): stdio_log is now one of many
1675 (ShellCommand): added logfiles= argument, as well as a class-level
1676 .logfiles attribute, which will be merged together to figure out
1677 which logfiles should be tracked. The latter maybe be useful for
1678 subclasses of ShellCommand which know they will aways produce
1679 secondary logfiles in the same location.
1681 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1682 and closeStdin() methods, preparing to make it possible to write
1683 to a ShellCommand's stdin at any time, not just at startup. These
1684 writes are buffered if the child process hasn't started yet.
1685 (LogFileWatcher): new helper class to watch arbitrary logfiles
1686 while a ShellCommand runs. This class polls the file every two
1687 seconds, and sends back 10k chunks to the buildmaster.
1688 (ShellCommand): rename stdin= to initialStdin=, and add
1689 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1690 at startup.
1691 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1692 key of "log" and a value of (logname, data).
1693 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1694 'logfiles' to the master-visible args dictionary.
1695 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1696 (CVS.start): same
1697 (P4.doVCFull): same
1698 * buildbot/test/test_vc.py (Patch.testPatch): same
1701 * buildbot/test/emit.py: write to a logfile in the current
1702 directory. We use this to figure out what was used as a basedir
1703 rather than looking to see which copy of emit.py gets run, so that
1704 we can run the commands from inside _trial_temp rather than inside
1705 buildbot/test
1706 * buildbot/test/subdir/emit.py: same
1707 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1708 argument rather than running from buildbot/test/
1709 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1710 rather than using an implicit setUp()
1711 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1712 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1713 of assuming that we're running in buildbot/test/ (and that '.' is
1714 on our $PATH)
1716 * buildbot/slave/commands.py (Command.doStart): refactor Command
1717 startup/completion a bit: now the SlaveBuilder calls doStart(),
1718 which is not meant for overridding by subclasses, and doStart()
1719 calls start(), which is. Likewise the SlaveBuilder calls
1720 doInterrupt(), and subclasses override interrupt(). This also puts
1721 responsibility for maintaining .running in Command rather than in
1722 SlaveBuilder.
1723 (Command.doInterrupt): same
1724 (Command.commandComplete): same, this is called when the deferred
1725 returned by start() completes.
1726 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1727 (SlaveBuilder.remote_interruptCommand): same
1728 (SlaveBuilder.stopCommand): same
1730 2006-06-16 Brian Warner <warner@lothar.com>
1732 * buildbot/test/test_shell.py: new test file to contain everything
1733 relating to ShellCommand
1734 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1735 multiple logfiles in realtime" feature, not yet implemented
1736 * buildbot/test/emitlogs.py: support file for testLogFiles
1737 * docs/buildbot.texinfo (ShellCommand): document the feature
1739 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1741 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1742 for tests which exercise SlaveCommands in isolation.
1744 * buildbot/test/test_slavecommand.py: Move some utilities like
1745 SignalMixin and FakeSlaveBuilder from here ..
1746 * buildbot/test/runutils.py: .. to here, so they can be used by
1747 other test classes too
1748 * buildbot/test/test_vc.py: more SignalMixin refactoring
1749 * buildbot/test/test_control.py: same
1750 * buildbot/test/test_run.py: and some rmtree refactoring
1752 2006-06-15 Brian Warner <warner@lothar.com>
1754 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1755 'testBranch' to match other VC tests and have the tests run in
1756 roughly increasing order of dependency
1758 * buildbot/test/test_steps.py (LogObserver): new test to verify
1759 LogObservers can be created at various times and still get
1760 connected up properly
1762 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1763 to create BuildStepStatus instances that actually work.
1765 * buildbot/process/step.py (LogObserver): add outReceived and
1766 errReceived base methods, to be overridden
1768 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1769 API to take a name instead of a step, reducing the coupling
1770 somewhat. This returns the BuildStepStatus object so it can be
1771 passed to the new Step, instead of jamming it directly into the
1772 Step.
1773 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1774 method
1775 * buildbot/process/base.py (Build.setupBuild): use both methods
1776 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1777 process a bit to match
1779 2006-06-14 Brian Warner <warner@lothar.com>
1781 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1782 docs on writing new LogObserver classes
1783 (Writing New Status Plugins): brief docs on how Status Plugins fit
1784 together
1786 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1787 implement a LogObserver that counts how many unit tests have been
1788 run so far
1789 (Trial.__init__): wire it in
1790 * buildbot/test/test_twisted.py (Counter): unit test for it
1792 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1793 to new cmd.logs['stdio'] scheme
1794 (Trial.commandComplete): same
1795 (BuildDebs.commandComplete): same
1797 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1798 LogFiles, instead of just a single one. The old single logfile is
1799 now called "stdio". LoggedRemoteCommand no longer creates a
1800 LogFile for you (the code to do that was broken anyway). If you
1801 don't create a "stdio" LogFile, then stdout/stderr will be
1802 discarded.
1803 (LogObserver): implement "LogObservers", which a BuildStep can add
1804 to parse the output of a command in real-time. The primary use is
1805 to provide more useful information to the Progress code, allowing
1806 better ETA estimates.
1807 (LogLineObserver): utility subclass which feeds complete lines to
1808 the parser instead of bytes.
1809 (BuildStep.progressMetrics): this is safer as a tuple
1810 (BuildStep.setProgress): utility method, meant to be called by
1811 LogObservers
1812 (BuildStep.addLogObserver): new method, to be called at any time
1813 during the BuildStep (even before any LogFiles have been created),
1814 to attach (or schedule for eventual attachment) a LogObserver to a
1815 LogFile.
1816 (StdioProgressObserver): new LogObserver which replaces the old
1817 "output" progress gatherer
1818 (LoggingBuildStep.__init__): same
1819 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1820 (LoggingBuildStep._commandComplete): must use logs['stdio']
1821 instead of the old single ".log" attribute.
1822 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1823 functionality, now subsumed into StdioProgressObserver
1824 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1825 log name changed from "output" to "stdio".
1828 * buildbot/interfaces.py (ILogFile): add the Interface used from
1829 the BuildStep towards the LogFile
1830 (ILogObserver): and the one provided by a LogObserver
1831 * buildbot/status/builder.py (LogFile): implement it
1833 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1834 HEADER constants here ..
1835 * buildbot/status/builder.py (STDOUT): .. from here
1837 2006-06-13 Brian Warner <warner@lothar.com>
1839 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1840 compatibility with python2.2, which doesn't have the 'substr in
1841 str' feature.
1842 (TestP4Poller.makeTime): utility function to construct the
1843 timestamp using the same strptime() approach as p4poller does. It
1844 turns out that time.mktime() behaves slightly differently under
1845 python2.2, probably something to do with the DST flag, and that
1846 causes the test to fail under python2.2. (changing the mktime()
1847 arguments to have dst=0 instead of -1 caused it to fail under
1848 python2.3. Go figure.)
1849 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1851 2006-06-12 Brian Warner <warner@lothar.com>
1853 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1854 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1855 contributing such an excellent patch, including docs and unit
1856 tests! This makes it *so* much easier to apply. I had to update
1857 test_vc.py to handle some recent refactorings, but everything else
1858 applied smoothly. The only remaining thing I'd like to fix would
1859 be to remove the hard-wired port 1666 used by p4d, and allow it to
1860 claim any unused port. This would allow two copies of the test
1861 suite to run on the same host at the same time, as well as
1862 allowing the test suite to run while a real (production) p4d was
1863 running on the same host. Oh, and maybe we should add a warning to
1864 step.P4 that gets emitted if the slave is too old to provide the
1865 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1866 * buildbot/slave/commands.py (P4): same
1867 (P4Sync): same, some minor updates
1868 * buildbot/changes/p4poller.py: same
1869 * docs/buildbot.texinfo: same
1870 * buildbot/test/test_p4poller.py: same
1871 * buildbot/test/test_vc.py (P4): same
1873 * setup.py: add Trove classifiers for PyPI
1875 2006-06-08 Brian Warner <warner@allmydata.com>
1877 * buildbot/status/client.py
1878 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1879 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1880 build needs to be IRemote'd separately, rather than IRemote'ing
1881 the whole list at once. I can't wait until newpb's serialization
1882 adapters make this unnecessary.
1884 2006-06-06 Brian Warner <warner@lothar.com>
1886 * buildbot/process/step.py (WithProperties): make this inherit
1887 from ComparableMixin, so that reloading an unchanged config file
1888 doesn't cause us to spuriously reload any Builders which use them.
1889 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1890 add a test for it
1892 2006-06-03 Brian Warner <warner@lothar.com>
1894 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1895 running py2exe on windows, contributed by Mark Hammond. Addresses
1896 SF#1401121, but I think we still need to include
1897 buildbot/scripts/sample.cfg
1898 * setup.py: include buildbot_service.py as a script under windows
1899 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1900 a py2exe application), get the icon/css datafiles from a different
1901 place than usual.
1903 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1904 double-escape the build URL. Thanks to Olivier Bonnet for the
1905 patch. Fixes SF#1452801.
1907 2006-06-02 Brian Warner <warner@lothar.com>
1909 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1910 first six columns of 'svnlook' output, not just the first column,
1911 since property changes appear in the other five. Thanks to Olivier
1912 Bonnet for the patch. Fixes SF#1398174.
1914 2006-06-01 Brian Warner <warner@lothar.com>
1916 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1917 the fake build, so that title= has something to be set to
1919 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1920 attribute of the "Build #NN" link in the yellow start-the-build
1921 box to the build's reason. This means that you get a little
1922 tooltip explaining why the build was done when you hover over the
1923 yellow box. Thanks to Zandr Milewski for the suggestion.
1925 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1926 (Box.setETA): handle ETA=None (by stopping the timer)
1927 (Box.update): make the [soon] text less different than the usual
1928 text, so the rest of the text doesn't flop around so much. It
1929 would be awfully nice to figure out how to center this stuff.
1930 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1932 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1933 by default, so that any ShellCommand which fails marks the overall
1934 build as a failure. I should have done this from the beginning.
1935 Add flunkOnFailure=False to the arguments if you want to turn off
1936 this behavior.
1938 2006-05-30 Brian Warner <warner@lothar.com>
1940 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1941 last-build/current-build/current-step. Show what step is currently
1942 running. Show ETA for both the overall build and the current step.
1943 Update GTK calls to modern non-deprecated forms. There's still a
1944 lot of dead code and debug noise to remove.
1946 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1947 shows up properly in status displays
1949 2006-05-28 Brian Warner <warner@lothar.com>
1951 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1952 build we use to verify that WithProperties works:
1954 ** set flunkOnFailure=True so that build failures get noticed
1955 ** set workdir='.' so that the build succeeds, otherwise it is trying
1956 to touch 'build/something', and 'build/' doesn't exist because
1957 usually that's created by a Source step
1958 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1959 this test somehow triggers, in which the 'touch' process becomes
1960 a zombie and we wait for th etimeout before giving up on it.
1962 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1963 to log the Build results and step logs to the twisted log.
1964 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1965 what went wrong if a build was expected to succeed but didn't.
1967 * buildbot/process/step_twisted.py (Trial): set the default
1968 trialMode to '--reporter=bwverbose', which specifies verbose
1969 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1970 '-to', but those are completely missing in modern Twisteds.
1972 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1973 a localhost-only port, to encourage better security
1975 * docs/buildbot.texinfo (Change Sources): mention
1976 darcs_buildbot.py
1978 * .darcs-boring: add a Darcs boringfile
1980 * README (REQUIREMENTS): stop claiming compatibility with
1981 Twisted-1.3.0
1983 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1984 sender
1986 2006-05-27 Brian Warner <warner@lothar.com>
1988 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1989 * docs/buildbot.texinfo: same
1991 2006-05-23 Brian Warner <warner@lothar.com>
1993 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1994 * docs/buildbot.texinfo: set version to match
1995 * NEWS: update for 0.7.3
1997 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1998 give a quick mapping from VC system to possible ChangeSources
1999 (Build Properties): add 'buildername'
2001 * buildbot/process/base.py (Build.setupStatus): oops, set
2002 'buildername' and 'buildnumber' properties
2003 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2004 test them
2006 2006-05-22 Brian Warner <warner@lothar.com>
2008 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2009 property interpolation better
2011 * README (INSTALLATION): remove old '-v' argument from recommended
2012 trial command line
2014 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2015 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2016 patch. SF#1475494.
2018 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2019 'svnversion' instead of grepping the output of 'svn info', much
2020 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2021 Bonnet for the suggestion.
2022 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2023 require the WC_PATH argument, so run 'svnversion .' instead.
2025 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2026 aren't supposed to have 'self' in their argument list
2028 2006-05-21 Brian Warner <warner@lothar.com>
2030 * buildbot/process/step.py (ShellCommand.start): make
2031 testInterpolate pass. I was passing the uninterpolated command to
2032 the RemoteShellCommand constructor
2033 (ShellCommand._interpolateProperties): oops, handle non-list
2034 commands (i.e. strings with multiple words separated by spaces in
2035 them) properly, instead of forgetting about them.
2037 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2038 to actually try to use build properties in a real build. This test
2039 fails.
2040 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2041 to start and evaluate builds
2043 * buildbot/test/test__versions.py: add a pseudo-test to record
2044 what version of Twisted/Python/Buildbot are running. This should
2045 show up at the beginning of _trial_tmp/test.log, and exists to help
2046 debug other problems.
2048 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2049 a filename to be served as 'robots.txt' to discourage web spiders.
2050 Adapted from a patch by Tobi Vollebregt, thanks!
2051 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2052 (Waterfall.test_waterfall): tweak the way that filenames are put
2053 into the config file, to accomodate windows pathnames better.
2055 * docs/buildbot.texinfo (HTML Waterfall): document it
2057 * buildbot/process/process_twisted.py
2058 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2059 changed the build process. The new setup.py no longer takes the
2060 'all' argument.
2061 (FullTwistedBuildFactory.__init__): same
2062 (TwistedReactorsBuildFactory.__init__): same
2064 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2065 be placed in the [hooks] section of the central repository (the
2066 one that everybody pushes changes to).
2068 2006-05-20 Brian Warner <warner@lothar.com>
2070 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2071 .darcs-context file, use binary mode. I think this was causing a
2072 Darcs failure under windows.
2074 2006-05-19 Brian Warner <warner@lothar.com>
2076 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2077 use a timezone string of +0000 and gmtime, since this timestamp is
2078 sent to a buildmaster and %z is broken.
2080 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2081 string and localtime, since this timestamp will only be consumed
2082 locally, and %z is broken.
2084 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2085 gmtime, since this timestamp is returned to the buildmaster, and
2086 %z is broken.
2088 2006-05-18 Brian Warner <warner@lothar.com>
2090 * NEWS: update in preparation for next release
2092 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2093 setup-repository and do-we-have-the-vc-tools code into a separate
2094 "helper" class, which sticks around in a single module-level
2095 object. This seems more likely to continue to work in the future
2096 than having it hide in the TestCase and hope that TestCases stick
2097 around for a long time.
2099 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2100 addremove' has been deprecated in recent versions of mercurial, so
2101 use 'hg add' instead
2103 2006-05-07 Brian Warner <warner@lothar.com>
2105 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2106 operating under windows, move the file before opening it, since
2107 you can't rename a file that somebody has open.
2109 * buildbot/process/base.py (Build.setupBuild): if something goes
2110 wrong while creating a Step, log the name and arguments, since the
2111 error message when you get the number of arguments wrong is really
2112 opaque.
2114 2006-05-06 Brian Warner <warner@lothar.com>
2116 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2117 bugs in twisted-specific code not covered by my unit tests, this
2118 time use 'cmd' argument instead of self.cmd
2120 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2121 fix stupid braino: either use startwith or find()==0, not both.
2122 (TwistedReactorsBuildFactory.__init__): another dumb typo
2124 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2125 mark this test as TODO under windows, since process-killing seems
2126 dodgy there. We'll come back to this later and try to fix it
2127 properly.
2129 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2130 and don't include a timezone
2131 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2132 This should avoid the windows-with-verbose-timezone-name problem
2133 altogether.
2134 (Patch.testPatch): add a test which runs 'patch' with less
2135 overhead than the full VCBase.do_patch sequence, to try to isolate
2136 a windows test failure. This one uses slave.commands.ShellCommand
2137 and 'patch', but none of the VC code.
2139 * buildbot/slave/commands.py (getCommand): use which() to find the
2140 executables for 'cvs', 'svn', etc. This ought to help under
2141 windows.
2143 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2144 working directory before starting. If an earlier test failed, the
2145 leftover directory would mistakenly flunk a later test.
2146 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2147 Make sure that we use the right commandlines if which("tla") picks
2148 up "tla.exe" (as it does under windows).
2149 (TlaSupport.do_get): factor out this tla-vs-baz difference
2150 (TlaSupport.vc_create): more tla-vs-baz differences
2152 * buildbot/test/test_slavecommand.py
2153 (ShellBase.testShellMissingCommand): stop trying to assert
2154 anything about the error message: different shells on different
2155 OSes with different languages makes it hard, and it really isn't
2156 that interesting of a thing to test anyway.
2158 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2159 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2160 "Panther"), because it has a bug which flunks a couple tests in
2161 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2162 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2163 able to test that yet.
2165 2006-04-30 Brian Warner <warner@lothar.com>
2167 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2168 make sure child commands emit messages in english, so our regexps
2169 will match. Thanks to Nikaus Giger for identifying the problems.
2170 (VCBase._do_vctest_export_1): mode="export" is not responsible
2171 for setting the "got_revision" property, since in many cases it is
2172 not convenient to determine.
2173 (SVNSupport.capable): when running 'svn --version' to check for
2174 ra_local, we want error messages in english
2175 * buildbot/test/test_slavecommand.py
2176 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2177 to emit the error message in english
2179 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2180 the environment with $LC_ALL="C" so that Commands which need to
2181 parse the output of their child processes can obtain it in
2182 english.
2183 (SVN.parseGotRevision): call "svn info" afterwards instead of
2184 watching the output of the "svn update" or "svn checkout".
2185 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2186 (Arch.parseGotRevision): same
2187 (Bazaar.parseGotRevision): same
2188 (Mercurial.parseGotRevision): same
2190 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2191 $LC_ALL="C" when running commands under 'buildbot try', too
2193 * buildbot/test/__init__.py: remove the global os.environ()
2194 setting, instead we do it just for the tests that run commands and
2195 need to parse their output.
2197 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2198 remove the overly-short .timeout on this test, because non-DNotify
2199 platforms must fall back to polling which happens at 10 second
2200 intervals, so a 5 second timeout would never succeed.
2202 2006-04-24 Brian Warner <warner@lothar.com>
2204 * docs/buildbot.texinfo (Installing the code): update trial
2205 invocation, SF#1469116 by Niklaus Giger.
2206 (Attributes of Changes): updated branch-name examples to be
2207 a bit more realistic, SF#1475240 by Stephen Davis.
2209 * contrib/windows/buildbot2.bat: utility wrapper for windows
2210 developers, contributed by Nick Trout (after a year of neglect..
2211 sorry!). SF#1194231.
2213 * buildbot/test/test_vc.py (*.capable): store the actual VC
2214 binary's pathname in VCS[vcname], so it can be retrieved later
2215 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2216 strip out non-numeric timezone information, specifically the funky
2217 German string that his system produced that confuses CVS.
2218 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2219 allow Darcs tests to work on windows
2220 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2221 procutils.which() everywhere, to allow tryclient to work under
2222 windows. Also from Niklaus Giger, SF#1463394.
2224 * buildbot/twcompat.py (which): move the replacement for a missing
2225 twisted.python.procutils.which from test_vc.py to here, so it can
2226 be used in other places too (specifically tryclient.py)
2228 2006-04-23 Brian Warner <warner@lothar.com>
2230 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2231 bare buildbotURL/projectName line with a proper DIV, along with a
2232 CSS class of "title", from Stefan Seefeld (SF#1461675).
2233 (WaterfallStatusResource.body0): remove the redundant 'table'
2234 class from the table
2235 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2236 to the top-row TR, and class="Activity" to the second-row TR,
2237 rather than putting them in the individual TD nodes.
2239 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2240 'got_revision' build property for all VC systems that implement
2241 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2243 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2244 to determine which revision we actually obtained
2245 (CVS.parseGotRevision): implement this for CVS, which just means
2246 to grab a timestamp. Not ideal, and it depends upon the buildslave
2247 having a clock that is reasonably well syncronized with the server,
2248 but it's better than nothing.
2249 (SVN.parseGotRevision): implement it for SVN, which is accurate
2250 (Darcs.parseGotRevision): same
2251 (Arch.parseGotRevision): same
2252 (Bazaar.parseGotRevision): same
2253 (Mercurial.parseGotRevision): same
2255 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2256 keep a record of all non-stdout/stderr/header/rc status updates,
2257 for the benefit of RemoteCommands that send other useful things,
2258 like got_revision
2259 (Source.commandComplete): put any 'got_revision' status values
2260 into a build property of the same name
2263 * buildbot/process/step_twisted.py (Trial): update to deal with
2264 new ShellCommand refactoring
2266 * docs/buildbot.texinfo (Build Properties): document new feature
2267 that allows BuildSteps to get/set Build-wide properties like which
2268 revision was requested and/or checked out.
2270 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2271 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2272 it. Note that this bumps the persistenceVersion of the saved Build
2273 object, so add the necessary upgrade-old-version logic to include
2274 an empty properties dict.
2276 * buildbot/process/base.py (Build.setProperty): implement it
2277 (Build.getProperty): same
2278 (Build.startBuild): change build startup to set 'branch',
2279 'revision', and 'slavename' properties at the right time
2281 * buildbot/process/step.py (BuildStep.__init__): change setup to
2282 require 'build' argument in a better way
2283 (LoggingBuildStep): split ShellCommand into two pieces, for better
2284 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2285 a single RemoteCommand that sends stdout/stderr status text. It
2286 also provides the usual commandComplete / createSummary /
2287 evaluateCommand / getText methods to be overridden...
2288 (ShellCommand): .. whereas ShellCommand is specifically for
2289 running RemoteShellCommands. Other shell-like BuildSteps (like
2290 Source) can inherit from LoggingBuildStep instead of ShellCommand
2291 (WithProperties): marker class to do build-property interpolation
2292 (Source): inherit from LoggingBuildStep instead of ShellCommand
2293 (RemoteDummy): same
2295 * buildbot/test/test_properties.py: test new functionality
2297 2006-04-21 Brian Warner <warner@lothar.com>
2299 * buildbot/test/test_vc.py: rename testBranch to
2300 testCheckoutBranch to keep the tests in about the right
2301 alphabetical order
2303 2006-04-18 Brian Warner <warner@lothar.com>
2305 * docs/buildbot.texinfo (PBListener): improve cross-references
2306 between PBListener and 'buildbot statusgui', thanks to John Pye
2307 for the suggestion.
2309 2006-04-17 Brian Warner <warner@lothar.com>
2311 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2312 running under Twisted-1.3.0, otherwise skipped tests are reported
2313 as errors.
2315 * all: use isinstance() instead of 'type(x) is foo', suggested by
2316 Neal Norwitz
2318 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2319 oops, fix a brain-fade from the other week, when making the
2320 addStep changes. I changed all the __init__ upcalls to use the
2321 wrong superclass name.
2322 (FullTwistedBuildFactory.__init__): same
2323 (TwistedDebsBuildFactory.__init__): same
2324 (TwistedReactorsBuildFactory.__init__): same
2325 (TwistedBuild.isFileImportant): use .startswith for clarity,
2326 thanks to Neal Norwitz for the suggestions.
2328 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2329 changes, then deliver them over PB to a remote buildmaster.
2331 * contrib/svnpoller.py: added script by John Pye to poll a remote
2332 SVN repository (by running 'svn log') from a cronjob, and run
2333 'buildbot sendchange' to deliver the changes to a remote
2334 buildmaster.
2335 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2336 modification of svnpoller.py), same purpose, but this one loops
2337 internally (rather than expecting to run from a cronjob) and works
2338 under windows.
2339 * contrib/README.txt: same
2341 2006-04-11 Brian Warner <warner@lothar.com>
2343 * all: fix a number of incorrect names and missing imports, thanks
2344 to Anthony Baxter for the patch.
2345 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2346 remove unused buggy method.
2347 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2348 comes from shutil, not "shutils"
2349 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2350 (Arch.checkSlaveVersion): same
2351 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2352 some disabled code
2353 * buildbot/process/step_twisted2.py: add some missing imports
2354 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2355 this code used to live in twisted.internet.defer
2357 2006-04-10 Brian Warner <warner@lothar.com>
2359 * buildbot/process/step.py (Mercurial): add Mercurial support
2360 * buildbot/slave/commands.py (Mercurial): same
2361 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2362 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2363 not yet tested, but 'try' support *is* covered
2364 * docs/buildbot.texinfo (Mercurial): document it
2366 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2367 some debugging messages (turned off)
2368 * buildbot/test/test_vc.py: improve debug messages
2370 2006-04-07 Brian Warner <warner@lothar.com>
2372 * buildbot/test/test_vc.py (which): define our own which() in case
2373 we can't import twisted.python.procutils, because procutils doesn't
2374 exist in Twisted-1.3
2376 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2377 of SlaveLocks for performance tests
2379 * docs/examples/twisted_master.cfg: update to match current usage
2381 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2382 password, p4 binary, pollinterval, maximum history to check.
2383 Patch from an anonymous sf.net contributor, SF#1219384.
2384 * buildbot/process/step.py (P4Sync.__init__): add username,
2385 password, and client arguments.
2386 * buildbot/slave/commands.py (P4Sync): same
2388 2006-04-05 Brian Warner <warner@lothar.com>
2390 * buildbot/process/factory.py (BuildFactory.addStep): new method
2391 to add steps to a BuildFactory. Use it instead of f.steps.append,
2392 and you can probably avoid using the s() convenience function.
2393 Patch from Neal Norwitz, sf.net #1412605.
2394 (other): update all factories to use addStep
2395 * buildbot/process/process_twisted.py: update all factories to use
2396 addStep.
2398 2006-04-03 Brian Warner <warner@lothar.com>
2400 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2401 work under windows too. Adapted from a patch by Niklaus Giger,
2402 addresses SF#1463399.
2404 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2405 spawned commands emit parseable results in english and not some
2406 other language. Patch from Niklaus Giger, SF#1463395.
2408 * README (INSTALLATION): discourage users from running unit tests on
2409 a "network drive", patch from Niklaus Giger, SF#1463394.
2411 2006-03-22 Brian Warner <warner@lothar.com>
2413 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2414 function to turn a repository-relative pathname into a (branch,
2415 branch-relative-filename) tuple. Change this function to handle
2416 the branch naming policy used by your Subversion repository.
2417 Thanks to AllMyData.com for sponsoring this work.
2419 2006-03-16 Brian Warner <warner@lothar.com>
2421 * buildbot/scripts/sample.cfg: add python-mode declaration for
2422 vim. Thanks to John Pye for the patch.
2424 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2425 command line, mention the importance of running 'crontab' as the
2426 buildmaster/buildslave user. Thanks to John Pye for the catch.
2428 2006-03-13 Brian Warner <warner@lothar.com>
2430 * buildbot/status/words.py (IRC): add an optional password=
2431 argument, which will be sent to Nickserv in an IDENTIFY message at
2432 login, to claim the nickname. freenode requires this before the
2433 bot can sent (or reply to) private messages. Thanks to Clement
2434 Stenac for the patch.
2435 * docs/buildbot.texinfo (IRC Bot): document it
2437 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2438 larger than chunkSize. Fixes SF#1349253.
2439 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2440 (Log.testConsumer): update to match new internal chunking behavior
2442 2006-03-12 Brian Warner <warner@lothar.com>
2444 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2446 * buildbot/test/test_maildir.py (MaildirTest): rename the
2447 'timeout' method, as it collides with trial's internals
2449 * buildbot/scripts/runner.py: add 'buildbot restart' command
2450 (stop): don't sys.exit() out of here, otherwise restart can't work
2451 * docs/buildbot.texinfo (Shutdown): document it
2453 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2454 * buildbot/status/html.py (Waterfall.__init__): same
2455 * buildbot/process/builder.py (Builder.startBuild): same
2456 * buildbot/process/base.py (BuildRequest): same
2457 * buildbot/sourcestamp.py (SourceStamp): same
2458 * buildbot/scheduler.py (Nightly): same
2460 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2461 releases
2462 * docs/buildbot.texinfo: same
2464 2006-02-17 Brian Warner <warner@lothar.com>
2466 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2467 * docs/buildbot.texinfo: set version number to match
2468 * NEWS: update for 0.7.2
2470 2006-02-16 Brian Warner <warner@lothar.com>
2472 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2474 2006-02-09 Brian Warner <warner@lothar.com>
2476 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2477 add text to explain per-build branch parameters
2478 * NEWS: mention --umask
2480 2006-02-08 Brian Warner <warner@lothar.com>
2482 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2483 method
2484 (SlaveOptions.optParameters): add --umask, to make it possible to
2485 make buildslave-generated files (including build products) be
2486 world-readable
2487 (slaveTAC): same
2488 * buildbot/slave/bot.py (BuildSlave.startService): same
2490 2006-01-23 Brian Warner <warner@lothar.com>
2492 * buildbot/status/builder.py: urllib.quote() all URLs that include
2493 Builder names, so that builders can include characters like '/'
2494 and ' ' without completely breaking the resulting HTML. Thanks to
2495 Kevin Turner for the patch.
2496 * buildbot/status/html.py: same
2497 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2499 * NEWS: update in preparation for upcoming release
2501 2006-01-18 Brian Warner <warner@lothar.com>
2503 * docs/examples/twisted_master.cfg: update to match the Twisted
2504 buildbot: remove python2.2, switch to exarkun's buildslaves,
2505 disable the .deb builder until we figure out how to build twisted
2506 .debs from SVN, add some ktrace debugging to the OS-X build
2507 process and remove the qt build, remove threadless builders,
2508 change freebsd builder to use landonf's buildslave.
2510 2006-01-12 Brian Warner <warner@lothar.com>
2512 * buildbot/master.py (Manhole.__init__): let port= be a strports
2513 specification string, but handle a regular int for backwards
2514 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2515 used in master.cfg to limit connections to just the local host.
2516 (BuildMaster.loadConfig): same for c['slavePortnum']
2517 * buildbot/scheduler.py (Try_Userpass.__init__): same
2518 * buildbot/status/client.py (PBListener.__init__): same
2519 * buildbot/status/html.py (Waterfall.__init__): same, for both
2520 http_port and distrib_port. Include backwards-compatibility checks
2521 so distrib_port can be a filename string and still mean unix:/foo
2522 * docs/buildbot.texinfo (Setting the slaveport): document it
2523 (Debug options): same
2524 (HTML Waterfall): same
2525 (PBListener): same
2526 (try): same
2527 * buildbot/test/test_config.py (ConfigTest): test it
2529 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2530 slaveport's disownServiceParent deferred to fire before opening
2531 the new one. Fixes an annoying bug in the unit tests.
2533 2006-01-03 Brian Warner <warner@lothar.com>
2535 * buildbot/master.py (BuildMaster): remove the .schedulers
2536 attribute, replacing it with an allSchedulers() method that looks
2537 for all IService children that implement IScheduler. Having only
2538 one parent/child relationship means fewer opportunities for bugs.
2539 (BuildMaster.allSchedulers): new method
2540 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2541 also fix ugly bug that caused any config-file reload to
2542 half-forget about the earlier Schedulers, causing an exception
2543 when a Change arrived and was handed to a half-connected
2544 Scheduler. The exception was in scheduler.py line 54ish:
2545 self.parent.submitBuildSet(bs)
2546 exceptions.AttributeError: 'NoneType' object has no attribute
2547 'submitBuildSet'
2548 (BuildMaster.addChange): update to use allSchedulers()
2550 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2551 to work properly with twisted-1.3.0, where you must explicitly
2552 include the __implements__ from parent classes
2553 (BaseScheduler.__repr__): make it easier to distinguish distinct
2554 instances
2555 (BaseUpstreamScheduler.__implements__): same
2557 * buildbot/status/builder.py (Status.getSchedulers): update to
2558 use allSchedulers()
2559 * buildbot/test/test_run.py (Run.testMaster): same
2560 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2561 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2562 make sure Scheduler instances are left alone when an identical
2563 config file is reloaded
2564 (ConfigElements.testSchedulers): make sure Schedulers are properly
2565 comparable
2567 * Makefile (TRIALARGS): my local default Twisted version is now
2568 2.1.0, update the trial arguments accordingly
2570 2005-12-22 Brian Warner <warner@lothar.com>
2572 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2573 new win32 builders
2575 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2576 addChange in the parent class, although I suspect this should be
2577 fixed better in the future.
2579 2005-11-26 Brian Warner <warner@lothar.com>
2581 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2582 explode when branch==None, thanks to Kevin Turner for the catch
2583 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2584 it
2586 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2587 releases
2588 * docs/buildbot.texinfo: same
2590 2005-11-26 Brian Warner <warner@lothar.com>
2592 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2593 * docs/buildbot.texinfo: set version number to match
2595 2005-11-26 Brian Warner <warner@lothar.com>
2597 * NEWS: update for 0.7.1
2599 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2600 sure that unsubscribe works even if we never sent an ETA update.
2601 Also, don't explode on duplicate unsubscribe.
2602 (BuildStepStatus.addLog): make the convenience "return self"-added
2603 watcher automatically unsubscribe when the Step finishes.
2604 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2605 (BuildStatus.stepStarted): same auto-unsubscribe
2606 (BuilderStatus.buildStarted): same auto-unsubscribe
2608 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2609 auto-unsubscribe
2610 (IStatusReceiver.stepStarted): same
2611 (IStatusReceiver.logStarted): same
2613 * buildbot/test/test_run.py (Status): move the Status test..
2614 * buildbot/test/test_status.py (Subscription): .. to here
2616 2005-11-25 Brian Warner <warner@lothar.com>
2618 * NEWS: more updates
2620 * buildbot/locks.py: fix the problem in which loading a master.cfg
2621 file that changes some Builders (but not all of them) can result
2622 in having multiple copies of the same Lock. Now, the real Locks
2623 are kept in a table inside the BotMaster, and the Builders/Steps
2624 use "LockIDs", which are still instances of MasterLock and
2625 SlaveLock. The real Locks are instances of the new RealMasterLock
2626 and RealSlaveLock classes.
2627 * buildbot/master.py (BotMaster.getLockByID): new method to
2628 convert LockIDs into real Locks.
2629 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2630 into real Locks before building
2631 * buildbot/process/step.py (BuildStep.startStep): same
2632 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2633 exercises the problem
2636 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2637 what Schedulers are available
2639 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2640 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2641 'cron'-style build scheduling at certain times of day, week,
2642 month, or year.
2643 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2645 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2646 handling: treat self.fileIsImportant more as an attribute that
2647 contains a callable than as a method. If the attribute is None,
2648 don't call it and assume all filenames are important. It is still
2649 possible to provide a fileIsImportant method in a subclass,
2650 however.
2651 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2652 was broken
2653 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2654 test using AnyBranchScheduler with fileIsImportant=None
2656 2005-11-24 Brian Warner <warner@lothar.com>
2658 * buildbot/test/test_config.py (StartService): don't claim a fixed
2659 port number, instead set slavePort=0 on the first pass, figure out
2660 what port was allocated, then switch to a config file that uses
2661 the allocated port.
2663 * buildbot/master.py (BuildMaster.loadConfig): close the old
2664 slaveport before opening the new one, because unit tests might
2665 replace slavePort=0 with the same allocated portnumber, and if we
2666 don't wait for the old port to close first, we get a "port already
2667 in use" error. There is a tiny race condition here, but the only
2668 threat is from other programs that bind (statically) to the same
2669 port number we happened to be allocated, and only if those
2670 programs use SO_REUSEADDR, and only if they get control in between
2671 reactor turns.
2673 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2675 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2676 deleted ChangeSources before adding any new ones
2677 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2678 compare_attrs, to make sure that a config-file reload does not
2679 unnecessarily replace an unmodified ChangeSource instance
2680 * buildbot/test/test_config.py (ConfigTest.testSources): update
2682 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2683 mean "don't build anything", and add a warning if it gets used
2684 because it isn't actually useful.
2686 * contrib/svn_buildbot.py: update example usage to match the port
2687 number that gets used by the PBChangeSource
2688 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2690 2005-11-22 Brian Warner <warner@lothar.com>
2692 * NEWS: start collecting items for next release
2694 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2695 revisions are strings
2696 (P4Sync.computeSourceRevision): same
2698 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2699 to the Buildbot's overall status page
2700 (StatusResourceBuilder.body): same
2702 2005-11-15 Brian Warner <warner@lothar.com>
2704 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2705 config-file loading, specifically to make sure old StatusTargets
2706 are finished shutting down before new ones start up (thus
2707 resolving a bug in which changing the Waterfall object would fail
2708 because both new and old instances were claiming the same
2709 listening port). Also load new Schedulers after all the new
2710 Builders are set up, in case they fire off a new build right away.
2711 * buildbot/test/test_config.py (StartService): test it
2713 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2714 the branch name to the mail body
2716 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2717 Without it, a config-file reload fails to update an existing
2718 PBChangeSource.
2719 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2720 username/passwd to compare_attrs, for the same reason
2721 * buildbot/status/html.py (Waterfall): add favicon to
2722 compare_attrs, same reason
2724 2005-11-05 Brian Warner <warner@lothar.com>
2726 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2727 baserev before stuffing it in the jobfile. This resolves problems
2728 under SVN (and probably Arch) where revisions are expressed as
2729 numbers. I'm inclined to use string-based revisions everywhere in
2730 the future, but this fix should be safe for now. Thanks to Steven
2731 Walter for the patch.
2733 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2734 binary mode when opening pickle files, to make windows work
2735 better. Thanks to Dobes Vandermeer for the catch.
2736 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2737 (BuilderStatus.getBuildByNumber): same
2738 (Status.builderAdded): same
2739 * buildbot/master.py (BuildMaster.loadChanges): same
2741 * buildbot/util.py (Swappable): delete unused leftover code
2743 * buildbot/process/step.py (SVN): when building on a non-default
2744 branch, add the word "[branch]" to the VC step's description, so
2745 it is obvious that we're not building the usual stuff. Likewise,
2746 when we are building a specific revision, add the text "rNNN" to
2747 indicate what that revision number is. Thanks to Brad Hards and
2748 Nathaniel Smith for the suggestion.
2749 (Darcs.startVC): same
2750 (Arch.startVC): same
2751 (Bazaar.startVC): same
2753 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2754 typo, caught by Mark Dillavou, closes SF#1216636.
2756 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2757 about a test to add some day
2759 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2760 the 'full-2.3' build, and the 'reactors' build is now run under
2761 python-2.4 because the buildslave no longer has gtk/etc bindings
2762 for earlier versions.
2764 2005-11-03 Brian Warner <warner@lothar.com>
2766 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2767 method, takes an IBuildStatus and rebuilds it. It might make more
2768 sense to add this to IBuildControl instead, but that instance goes
2769 away completely once the build has finished, and resubmitting
2770 builds can take place weeks later.
2771 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2772 * buildbot/status/html.py (StatusResourceBuild): also stash an
2773 IBuilderControl so we can use resubmitBuild.
2774 (StatusResourceBuild.body): render "resubmit" button if we can.
2775 Also add hrefs for each BuildStep
2776 (StatusResourceBuild.rebuild): add action for "resubmit" button
2777 (StatusResourceBuilder.getChild): give it an IBuilderControl
2779 * buildbot/status/builder.py (Status.getURLForThing): change the
2780 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2781 that live as targets of buttons like "stop" and "rebuild" can't
2782 collide with them.
2783 * buildbot/status/builder.py (Status.getURLForThing): same
2784 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2785 (StepBox.getBox): same
2786 * buildbot/test/test_web.py (GetURL): same
2787 (Logfile): same
2789 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2790 exclusivity checks after Source.__init__ upcall, so misspelled
2791 arguments will be reported more usefully
2792 (Darcs.__init__): same
2794 2005-10-29 Brian Warner <warner@lothar.com>
2796 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2797 builder. Move the Try scheduler off to a separate port.
2799 2005-10-27 Brian Warner <warner@lothar.com>
2801 * buildbot/clients/gtkPanes.py
2802 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2803 to cause the app to crash, now they don't.
2805 * buildbot/clients/debug.py: display the buildmaster's location
2806 in the window's title bar
2808 2005-10-26 Brian Warner <warner@lothar.com>
2810 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2811 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2812 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2814 * buildbot/status/html.py (td): put a single non-breaking space
2815 inside otherwise empty <td> elements, as a workaround for buggy
2816 browsers which would optimize them away (along with any associated
2817 styles, like the kind that create the waterfall grid borders).
2818 Patch from Frerich Raabe.
2820 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2821 argv-list as an argument, defaulting to ["-to"], which is
2822 appropriate for the Trial that comes with Twisted-2.1.0 and
2823 earlier. The Trial in current Twisted SVN wants
2824 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2825 defaults to an empty list.
2826 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2827 match it, now that trialMode= is a list instead of a single string
2829 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2830 releases
2831 * docs/buildbot.texinfo: same
2833 2005-10-24 Brian Warner <warner@lothar.com>
2835 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2836 * docs/buildbot.texinfo: set version number to match
2838 2005-10-24 Brian Warner <warner@lothar.com>
2840 * README: update for 0.7.0
2841 * NEWS: same
2842 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2844 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2845 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2846 send the branch= argument unless the user really provided one, to
2847 retain compatibility with older buildmasters that don't accept
2848 that argument.
2849 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2850 same
2852 * docs/buildbot.texinfo: update lots of stuff
2854 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2855 to the 'buildbot sendchange' command
2856 * buildbot/clients/sendchange.py (Sender.send): same
2857 * buildbot/changes/pb.py (ChangePerspective): same
2858 * buildbot/test/test_changes.py (Sender.testSender): test it
2860 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2861 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2862 for consistency with other BuildStep arguments that use camelCase.
2863 Well, at least more of them use camelCase (like flunkOnWarnings)
2864 than don't.. I wish I'd picked one style and stuck with it
2865 earlier. Annoying, but it's best done before the release, since
2866 these arguments didn't exist at all in 0.6.6 .
2867 (Darcs): same
2868 * buildbot/test/test_vc.py (SVN.testCheckout): same
2869 (Darcs.testPatch): same
2870 * docs/buildbot.texinfo (SVN): document the change
2871 (Darcs): same, add some build-on-branch docs
2872 * docs/examples/twisted_master.cfg: match change
2874 * buildbot/process/step.py (BuildStep): rename
2875 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2876 how it is normally used.
2877 * buildbot/test/test_steps.py (Version.checkCompare): same
2879 * buildbot/process/step.py (CVS.startVC): refuse to build
2880 update/copy -style builds on a non-default branch with an old
2881 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2882 concern is that it will do a VC 'update' in an existing tree when
2883 it is supposed to be switching branches (and therefore clobbering
2884 the tree to do a full checkout), thus building the wrong source.
2885 This used to be a warning, but I think the confusion it is likely
2886 to cause warrants making it an error.
2887 (SVN.startVC): same, also make mode=export on old slaves an error
2888 (Darcs.startVC): same
2889 (Git.startVC): improve error message for non-Git-enabled slaves
2890 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2891 specific revision is built on a slave that doesn't pay attention
2892 to args['revision'], because for slowly-changing trees it will
2893 probably do the right thing, and because we have no way to tell
2894 whether we're asking it to build the most recent version or not.
2895 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2897 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2898 that 'master' is in host:portnum format, to catch errors sooner
2900 2005-10-23 Brian Warner <warner@lothar.com>
2902 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2903 when creating the list of warning messages, include the line
2904 immediately after each WARNING: line, since that's usually where
2905 the file and line number wind up.
2907 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2908 TryScheduler
2910 * NEWS: update
2912 2005-10-22 Brian Warner <warner@lothar.com>
2914 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2915 patch from Brad Hards
2916 * buildbot/status/classic.css: same
2917 * buildbot/test/test_web.py (Waterfall): match changes
2919 * buildbot/test/test_steps.py (BuildStep.setUp): set
2920 nextBuildNumber so the test passes
2921 * buildbot/test/test_status.py (MyBuilder): same
2923 * buildbot/status/html.py (StatusResourceBuild.body): revision
2924 might be numeric, so stringify it before html-escapifying it
2925 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2926 timer for the upcoming build
2927 * buildbot/status/classic.css: add background-color attributes for
2928 offline/waiting/building classes
2930 * buildbot/status/builder.py (BuildStatus): derive from
2931 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2932 the default (i.e. unknown) .slavename to "???" instead of None,
2933 since even unknown slavenames need to be printed eventually.
2934 (BuilderStatus): also derive from styles.Versioned . More
2935 importantly, determine .nextBuildNumber at creation/unpickling
2936 time by scanning the directory of saved BuildStatus instances and
2937 choosing one larger than the highest-numbered one found. This
2938 should fix the problem where random errors during upgrades cause
2939 the buildbot to forget about earlier builds. .nextBuildNumber is
2940 no longer stored in the pickle.
2941 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2942 at least log the error. Also call Builder.determineNextBuildNumber
2943 once the basedir is set.
2945 * buildbot/master.py (BuildMaster.loadChanges): do
2946 styles.doUpgrade afterwards, in case I decide to make Changes
2947 derived from styles.Versioned some day and forget to make this
2948 change later.
2951 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2952 when running under older pythons (<2.3) in which the shlex module
2953 doesn't have a 'split' function.
2955 * buildbot/process/step.py (ShellCommand.start): make
2956 errorMessages= be a list of strings to stuff in the log before the
2957 command actually starts. This makes it easier to flag multiple
2958 warning messages, e.g. when the Source steps have to deal with an
2959 old buildslave.
2960 (CVS.startVC): handle slaves that don't handle multiple branches
2961 by switching into 'clobber' mode
2962 (SVN.startVC): same. Also reject branches without base_url
2963 (Darcs.startVC): same. Also reject revision= in older slaves
2964 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2965 (Bazaar.startVC): same, and test for baz separately than for arch
2967 * buildbot/slave/commands.py (cvs_ver): document new features
2969 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2970 (BuildStep.slaveVersionNewEnough): more useful utility method
2971 * buildbot/test/test_steps.py (Version): start testing it
2973 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2974 the 'force' command requires python2.3, for the shlex.split method
2976 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2977 since we don't use it anymore. The Twisted buildbot uses a
2978 PBChangeSource now.
2980 2005-10-21 Brian Warner <warner@lothar.com>
2982 * buildbot/process/process_twisted.py: rework all BuildFactory
2983 classes to take a 'source' step as an argument, instead of
2984 building up the SVN instance in the factory.
2985 * docs/examples/twisted_master.cfg: enable build-on-branch by
2986 providing a base_url and default_branch
2988 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2989 control over --branch and --revision, not that they are always
2990 legal to provide
2991 * buildbot/status/html.py (StatusResourceBuilder.force): same
2992 (StatusResourceBuild.body): display SourceStamp components
2994 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2995 IRC 'force' command, so it can be shared with an eventual
2996 command-line-tool 'buildbot force' mode.
2997 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2999 2005-10-20 Brian Warner <warner@lothar.com>
3001 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3003 * docs/examples/twisted_master.cfg: update to use Schedulers
3005 * buildbot/scripts/sample.cfg: update with Schedulers
3007 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3008 method specifically for use by HTML "force build" button and the
3009 IRC "force" command. Raises an immediate error if there are no
3010 slaves available.
3011 (IBuilderControl.requestBuild): make this just submit a build, not
3012 try to check for existing slaves or set up any when-finished
3013 Deferreds or anything.
3014 * buildbot/process/builder.py (BuilderControl): same
3015 * buildbot/status/html.py (StatusResourceBuilder.force): same
3016 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3017 * buildbot/test/test_slaves.py: same
3018 * buildbot/test/test_web.py: same
3020 2005-10-19 Brian Warner <warner@lothar.com>
3022 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3023 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3025 2005-10-18 Brian Warner <warner@lothar.com>
3027 * buildbot/status/html.py: provide 'status' argument to most
3028 StatusResourceFOO objects
3029 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3030 and Logfiles" section to make the Build page into a more-or-less
3031 comprehensive source of status information about the build
3033 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3034 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3036 2005-10-17 Brian Warner <warner@lothar.com>
3038 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3039 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3040 out what to do about other projects: the correct options for
3041 recent Twisteds will not work for older ones.
3043 2005-10-15 Brian Warner <warner@lothar.com>
3045 * buildbot/status/builder.py (Status.getURLForThing): add method
3046 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3047 use this in email/IRC status clients to make them more useful, by
3048 providing the end user with hints on where to learn more about the
3049 object being reported on.
3050 * buildbot/test/test_web.py (GetURL): tests for it
3052 2005-10-14 Brian Warner <warner@lothar.com>
3054 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3055 fix bug resulting from deferredResult changes
3057 2005-10-13 Brian Warner <warner@lothar.com>
3059 * buildbot/test/test_changes.py: remove use of deferredResult
3060 * buildbot/test/test_config.py: same
3061 * buildbot/test/test_control.py: same
3062 * buildbot/test/test_status.py: same
3063 * buildbot/test/test_vc.py: this is the only remaining use, since
3064 it gets used at module level. This needs to be replaced by some
3065 sort of class-level run-once routine.
3067 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3069 * lots: implement multiple slaves per Builder, which means multiple
3070 current builds per Builder. Some highlights:
3071 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3072 of (state,currentBuilds) instead of (state,currentBuild)
3073 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3074 (IBuildStatus.getSlavename): new method, so you can tell which
3075 slave got used. This only gets set when the build completes.
3076 (IBuildRequestStatus.getBuilds): new method
3078 * buildbot/process/builder.py (SlaveBuilder): add a .state
3079 attribute to track things like ATTACHING and IDLE and BUILDING,
3080 instead of..
3081 (Builder): .. the .slaves attribute here, which has been turned
3082 into a simple list of available slaves. Added a separate
3083 attaching_slaves list to track ones that are not yet ready for
3084 builds.
3085 (Builder.fireTestEvent): put off the test-event callback for a
3086 reactor turn, to make tests a bit more consistent.
3087 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3088 ping fails due to an exception. This needs work, I'm worried that
3089 a code error could lead to a constantly re-connecting slave.
3090 Especially since I'm trying to move to a distinct remote_ping
3091 method, separate from the remote_print that we currently use.
3092 (BuilderControl.requestBuild): return a convenience Deferred that
3093 provides an IBuildStatus when the build finishes.
3094 (BuilderControl.ping): ping all connected slaves, only return True
3095 if they all respond.
3097 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3098 reconnect when we shut down.
3100 * buildbot/status/builder.py: implement new methods, convert
3101 one-build-at-a-time methods to handle multiple builds
3102 * buildbot/status/*.py: do the same in all default status targets
3103 * buildbot/status/html.py: report the build's slavename in the
3104 per-Build page, report all buildslaves on the per-Builder page
3106 * buildbot/test/test_run.py: update/create tests
3107 * buildbot/test/test_slaves.py: same
3108 * buildbot/test/test_scheduler.py: remove stale test
3110 * docs/buildbot.texinfo: document the new builder-specification
3111 'slavenames' parameter
3113 2005-10-12 Brian Warner <warner@lothar.com>
3115 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3116 report failure correctly, causing Dependent builds to run when
3117 they shouldn't have.
3118 * buildbot/status/builder.py (BuildSetStatus): same
3119 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3120 (Set.testSuccess): test the both-pass case too
3121 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3122 fix this test: it was ending too early, masking the failure before
3123 (Logger): specialized StatusReceiver to make sure the dependent
3124 builds aren't even started, much less completed.
3126 2005-10-07 Brian Warner <warner@lothar.com>
3128 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3129 bot.SlaveBuilder being disowned in the middle of a build
3131 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3132 this inherit from StatusReceiver. Also upcall in __init__. This
3133 fixes the embarrasing crash when the new buildSetSubmitted method
3134 is invoked and Waterfall/etc don't implement their own.
3135 * buildbot/test/test_run.py: add a TODO note about a test to catch
3136 just this sort of thing.
3138 * buildbot/process/builder.py (Builder.attached): remove the
3139 already-attached warning, this situation is normal. Add some
3140 comments explaining it.
3142 2005-10-02 Brian Warner <warner@lothar.com>
3144 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3145 OverflowError when setting up dnotify, because some 64-bit systems
3146 have problems with signed-vs-unsigned constants and trip up on the
3147 DN_MULTISHOT flag. Patch from Brad Hards.
3149 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3151 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3152 progressMetrics, description, descriptionDone to the 'parms' list,
3153 and make use the 'parms' list from the implementation class
3154 instead of only BuildStep to initialize the parameters. This
3155 allows buildbot.process.factory.s() to initialize all the parms,
3156 not just those defined in directly by BuildStep.
3158 2005-09-03 Brian Warner <warner@lothar.com>
3160 * NEWS: start adding items for the next release
3162 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3163 python2.2 tests, change 'Quick' builder to only use python2.3
3165 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3167 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3168 the "Ping Builder" button if the build control is available; the
3169 user sees an exception otherwise
3171 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3173 2005-09-01 Brian Warner <warner@lothar.com>
3175 * buildbot/interfaces.py (IBuilderStatus.getState): update
3176 signature, point out that 'build' can be None
3177 (IBuildStatus.getETA): point out ETA can be none
3179 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3180 being None
3181 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3183 2005-08-31 Brian Warner <warner@lothar.com>
3185 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3186 update to match correct signature: removed 'eta' argument
3187 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3189 2005-08-30 Brian Warner <warner@lothar.com>
3191 * buildbot/status/builder.py (LogFile): remove the assertion that
3192 blows up when you try to overwrite an existing logfile, instead
3193 just emit a warning. This case gets hit when the buildmaster is
3194 killed and doesn't get a chance to write out the serialized
3195 BuilderStatus object, so the .nextBuildNumber attribute gets out
3196 of date.
3198 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3199 the 'buildbot sendchange' arguments, for the Darcs context file
3200 * docs/buildbot.texinfo (sendchange): document it
3202 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3203 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3204 (IStatus.getSchedulers): new method
3205 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3206 (Status.getSchedulers): implement
3207 * buildbot/process/builder.py (Builder): maintain
3208 BuilderStatus.pendingBuilds
3209 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3210 (TryBase.addChange): Try schedulers should ignore Changes
3212 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3213 for 'try' on CVS/SVN
3214 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3216 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3217 report status properly.
3218 (Try.createJob): implement unique buildset IDs
3220 * buildbot/status/client.py (StatusClientPerspective): add a
3221 perspective_getBuildSets method for the benefit of jobdir-style
3222 'try'.
3223 * docs/buildbot.texinfo (try): more docs
3224 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3225 new test case
3227 2005-08-18 Brian Warner <warner@lothar.com>
3229 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3230 actually work. It's functional but still kind of clunky. Also, it
3231 only works with the pb-style.. needs to be made to work with the
3232 jobdir-style too.
3234 * buildbot/status/client.py (RemoteBuildSet): new class
3235 (RemoteBuildRequest): same
3236 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3237 object, not the internal BuildStatus object.
3238 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3239 outside of the usual buildStarted() return value.
3240 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3242 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3243 (Try_Userpass_Perspective.perspective_try): return a remotely
3244 usable BuildSetStatus object
3246 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3247 isStarted()/waitUntilStarted()
3249 2005-08-16 Brian Warner <warner@lothar.com>
3251 * buildbot/status/builder.py: implement IBuildSetStatus and
3252 IBuildRequestStatus, wire them into place.
3253 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3254 methods into the BuildSetStatus object.
3255 * buildbot/interfaces.py: same
3256 (IStatus.getBuildSets): new method to get pending BuildSets
3257 (IStatusReceiver.buildsetSubmitted): new method which hears about
3258 new BuildSets
3259 * buildbot/master.py (BuildMaster.submitBuildSet): same
3260 * buildbot/process/base.py (BuildRequest): same, replace
3261 waitUntilStarted with subscribe/unsubscribe
3262 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3263 subscribe instead of waitUntilStarted
3264 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3265 for new method
3266 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3267 same
3268 * buildbot/test/test_buildreq.py: update for new code
3269 * buildbot/test/test_control.py (Force.testRequest): same
3272 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3273 for Darcs to not use the tempfile module, so it works under
3274 python-2.2 too. We really didn't need the full cleverness of that
3275 module, since the slave has exclusive control of its own builddir.
3277 2005-08-15 Brian Warner <warner@lothar.com>
3279 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3280 for CVS trees. It doesn't work for non-trunk branches,
3281 unfortunately.
3282 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3283 branch test
3285 * Makefile: make it easier to test against python2.2
3287 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3288 tearDown2, so things like Arch can unregister archives as they're
3289 shutting down. The previous subclass-override-tearDown technique
3290 resulted in a nested maybeWait() and test failures under
3291 Twisted-1.3.0
3293 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3294 where we can (Arch), add a branch= argument to set the branch used
3295 when we can't
3296 (BazExtractor): extract the branch too
3297 (TlaExtractor): same
3298 * buildbot/scripts/runner.py (TryOptions): add --branch
3299 * docs/buildbot.texinfo (try): document --branch/try_branch
3301 * buildbot/slave/commands.py (Darcs): implement get-revision for
3302 Darcs, so that 'try' will work. This requires the tempfile module
3303 from python-2.3 .
3305 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3306 of revisions, branches, and 'try' in the process.
3308 2005-08-11 Brian Warner <warner@lothar.com>
3310 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3311 this, it got broken at some point in the last few releases
3312 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3313 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3314 specifically the removal of ETA information from the tuple
3316 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3317 warning message
3319 * docs/buildbot.texinfo (try): document both --builder and
3320 'try_builders' in .buildbot/options
3321 * buildbot/scripts/runner.py (TryOptions): add --builder,
3322 accumulate the values into opts['builders']
3323 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3324 * buildbot/test/test_runner.py (Try): add some quick tests to make
3325 sure 'buildbot try --options' and .buildbot/options get parsed
3326 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3327 use --builder control
3329 * docs/buildbot.texinfo (try): add --port argument to PB style
3331 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3332 actual SourceStamp. Still need to extract a branch name, somehow.
3333 (Try): finish implementing the try client side, still need a UI
3334 for specifying which builders to use
3335 (Try.getopt): factor our options/config-file reading
3336 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3337 test it
3338 * buildbot/test/test_vc.py: match SourceStampExtractor change
3340 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3341 causes the twisted log to be sent to stderr
3343 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3345 2005-08-10 Brian Warner <warner@lothar.com>
3347 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3348 style is 90% done, still missing status reporting or waiting for
3349 the buildsets to finish, and it is completely untested.
3351 * buildbot/trybuild.py: delete file, move contents to ..
3352 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3353 * buildbot/test/test_vc.py: match the move
3355 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3356 of the TryScheduler, no buildsetID or status-tracking support yet
3357 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3359 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3360 possible to set the basedir after __init__ time, so it is easier
3361 to use as a Service-child of the BuildMaster instance
3363 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3364 that delivers messages to its Service parent instead of requiring
3365 a subclass to be useful. This turns out to be much easier to build
3366 unit tests around.
3368 * buildbot/scripts/tryclient.py (createJob): utility code to
3369 create jobfiles, will eventually be used by 'buildbot try'
3371 2005-08-08 Brian Warner <warner@lothar.com>
3373 * docs/buildbot.texinfo (try): add docs on the
3374 as-yet-unimplemented Try scheduler
3376 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3377 * buildbot/test/test_scheduler.py: .. here
3378 (Scheduling.testTryJobdir): add placeholder test for 'try'
3380 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3381 addEntry merging (>=chunkSize) behavior
3382 (Log.testConsumer): update to handle new callLater(0) behavior
3384 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3385 both the MAX_LENGTH bugfix and the resumeProducing hang.
3387 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3388 put off the actual resumeProducing for a moment with
3389 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3390 causes large logfiles to hang midway through.
3392 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3393 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3394 and to improve memory usage when streaming the file out to a web
3395 browser.
3396 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3397 make this work cleanly
3399 2005-08-03 Brian Warner <warner@lothar.com>
3401 * buildbot/trybuild.py: new file for 'try' utilities
3402 (getSourceStamp): run in a tree, find out the baserev+patch
3403 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3404 implemented for SVN and Darcs, still working on Arch. I don't know
3405 how to make CVS work yet.
3407 * docs/buildbot.texinfo: document the 'buildbot' command-line
3408 tool, including the not-yet-implemented 'try' feature, and the
3409 in-flux .buildbot/ options directory.
3411 2005-07-20 Brian Warner <warner@lothar.com>
3413 * buildbot/locks.py: added temporary id() numbers to Lock
3414 descriptions, to track down a not-really-sharing-the-Lock bug
3416 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3418 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3419 needed for python2.2 compatibility
3420 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3421 are from the __future__
3423 2005-07-19 Brian Warner <warner@lothar.com>
3425 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3426 message when schedulers use unknown builders
3428 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3429 SlaveLock('name') and MasterLock('name') are distinct
3431 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3432 c['schedulers'] in such a way that we can actually accept
3433 Dependent instances
3434 * buildbot/test/test_config.py: check it
3436 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3437 utility method to *all* the Schedulers
3438 (Periodic.listBuilderNames): same
3440 * docs/buildbot.texinfo (Interlocks): update chapter to match
3441 reality
3443 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3444 to make sure that c['sources'], c['schedulers'], and c['status']
3445 are all lists of the appropriate objects, and that the Schedulers
3446 all point to real Builders
3447 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3448 'listBuilderNames' utility method to support this
3449 * buildbot/scheduler.py: implement the utility method
3450 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3452 * docs/buildbot.texinfo: add some @cindex entries
3454 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3455 if it wasn't already set: most tla commands will fail unless one
3456 has been set.
3457 (Arch.createRepository): and disable bazaar's revision cache, since
3458 they cause test failures (the multiple repositories we create all
3459 interfere with each other through the cache)
3461 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3462 bring it properly up to date with twisted-2.0 test guidelines
3464 * buildbot/master.py (BuildMaster): remove references to old
3465 'interlock' module, this caused a bunch of post-merge test
3466 failures
3467 * buildbot/test/test_config.py: same
3468 * buildbot/process/base.py (Build): same
3470 * buildbot/test/test_slaves.py: stubs for new test case
3472 * buildbot/scheduler.py: add test-case-name tag
3473 * buildbot/test/test_buildreq.py: same
3475 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3476 unnecessary init code
3477 (Bot.remote_setBuilderList): match it
3479 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3481 * buildbot/changes/mail.py (parseSyncmail): update comment
3483 * buildbot/test/test_slavecommand.py: disable Shell tests on
3484 platforms that don't suport IReactorProcess
3486 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3487 all places where we open logfiles. It causes OS-X to open the file
3488 in some weird mode that that prevents us from mixing reads and
3489 writes to the same filehandle, which we depend upon to implement
3490 _generateChunks properly. This change doesn't appear to break
3491 win32, on which "b" and "t" are treated differently but a missing
3492 flag seems to be interpreted as "t".
3494 2005-07-18 Brian Warner <warner@lothar.com>
3496 * buildbot/slave/commands.py (ShellCommand): overhaul
3497 error-handling code, to try and make timeout/interrupt work
3498 properly, and make win32 happier
3499 * buildbot/test/test_slavecommand.py: clean up, stop using
3500 reactor.iterate, add tests for timeout and interrupt
3501 * buildbot/test/sleep.py: utility for a new timeout test
3503 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3504 code from the local-usebranches branch
3506 2005-07-17 Brian Warner <warner@lothar.com>
3508 * buildbot/process/process_twisted.py
3509 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3510 minutes, to match the other twisted BuildFactories, and don't
3511 excuse failures in c/qt/win32 reactors any more.
3513 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3514 'freebsd' builders, since the buildslaves have been unavailable
3515 for quite a while
3517 2005-07-13 Brian Warner <warner@lothar.com>
3519 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3520 build-on-branch feature
3522 * buildbot/process/step.py (Darcs.__init__): add base_url and
3523 default_branch arguments, just like SVN
3524 (Arch.__init__): note that the version= argument is really the
3525 default branch name
3527 * buildbot/slave/commands.py (SourceBase): keep track of the
3528 repository+branch that was used for the last checkout in
3529 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3530 match, we clobber the directory and perform a fresh checkout
3531 rather than trying to do an in-place update. This should protect
3532 us against trying to get to branch B by doing an update in a tree
3533 obtained from branch A.
3534 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3535 (SVN.setup): same, just the svnurl
3536 (Darcs.setup): same, just the repourl
3537 (Arch.setup): same, arch coordinates (url), version, and
3538 buildconfig. Also pull the buildconfig from the args dictionary,
3539 which we weren't doing before, so the build-config was effectively
3540 disabled.
3541 (Arch.sourcedirIsUpdateable): don't try to update when we're
3542 moving to a specific revision: arch can't go backwards, so it is
3543 safer to just clobber the tree and checkout a new one at the
3544 desired revision.
3545 (Bazaar.setup): same sourcedata as Arch
3547 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3548 use maybeWait, to work with twisted-1.3.0 and twcompat
3549 (Dependencies.testRun_Pass): same
3551 * buildbot/test/test_vc.py: rearrange, cleanup
3553 * buildbot/twcompat.py: add defer.waitForDeferred and
3554 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3555 can work under twisted-1.3.0 .
3557 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3558 now created at setUp time. This increases the runtime of the test
3559 suite considerably (from 91 seconds to 151), but it removes the
3560 need for an offline tarball, which should solve a problem I've
3561 seen where the test host has a different version of svn than the
3562 tarball build host. The new code also validates that mode=update
3563 really picks up recent commits. This approach will also make it
3564 easier to test out branches, because the code which creates the VC
3565 branches is next to the code which uses them. It will also make it
3566 possible to test some change-notification hooks, by actually
3567 performing a VC commit and watching to see the ChangeSource get
3568 notified.
3570 2005-07-12 Brian Warner <warner@lothar.com>
3572 * docs/buildbot.texinfo (SVN): add branches example
3573 * docs/Makefile (buildbot.ps): add target for postscript manual
3575 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3576 * buildbot/test/test_locks.py: same
3578 * buildbot/process/step.py (Darcs): comment about default branches
3580 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3581 c['interlocks'] in the config file, complain if it is present.
3582 Scan all locks in c['builders'] to make sure the Locks they use
3583 are uniquely named.
3584 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3585 add some tests to check for non-uniquely-named Locks
3586 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3587 since the unique-Lock validation code requires it now
3589 * buildbot/locks.py: fix test-case-name
3591 * buildbot/interlock.py: remove old file
3593 2005-07-11 Brian Warner <warner@lothar.com>
3595 * buildbot/test/test_interlock.py: rename to..
3596 * buildbot/test/test_locks.py: .. something shorter
3598 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3599 versions (after 2.0.1) changed internet.TCPClient to shut down the
3600 connection in stopService. Change the code to handle this
3601 gracefully.
3603 * buildbot/process/base.py (Build): handle whole-Build locks
3604 * buildbot/process/builder.py (Builder.compareToSetup): same
3605 * buildbot/test/test_interlock.py: make tests work
3607 * buildbot/process/step.py (BuildStep.startStep): complain if a
3608 Step tries to claim a lock that's owned by its own Build
3609 (BuildStep.releaseLocks): typo
3611 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3612 file reloads don't replace unchanged Builders
3613 (SlaveLock): same
3614 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3615 rewrite to cover new Locks instead of old c['interlocks']
3616 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3617 slave2 too
3620 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3621 start the master and connect the buildslave
3623 * buildbot/process/step.py (FailingDummy.done): finish with a
3624 FAILURE status rather than raising an exception
3626 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3627 stringify a BuildRequest.reason that is None
3629 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3630 minor fix
3631 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3632 allow scheduler.Dependent to work
3633 * buildbot/buildset.py (BuildSet): set .reason and .results
3635 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3636 slaves, to make the test stop hanging. It still fails, of course,
3637 because I haven't even started to implement Locks.
3639 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3641 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3642 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3643 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3644 (Dependent): new class for downstream build dependencies
3645 * buildbot/test/test_dependencies.py: tests (still failing)
3647 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3649 2005-07-07 Brian Warner <warner@lothar.com>
3651 * buildbot/test/runutils.py (RunMixin): factored this class out..
3652 * buildbot/test/test_run.py: .. from here
3653 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3654 added new buildbot.locks tests (which all hang right now)
3655 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3656 * buildbot/process/step.py: claim/release per-BuildStep locks
3658 * docs/Makefile: add 'buildbot.html' target
3660 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3661 interpreted as "HEAD", so that all VC steps can accept branch=None
3662 and have it mean the "default branch".
3664 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3666 2005-07-07 Brian Warner <warner@lothar.com>
3668 * docs/examples/twisted_master.cfg: update to match current usage
3670 * docs/buildbot.texinfo (System Architecture): comment out the
3671 image, it doesn't exist yet and just screws up the HTML manual.
3673 2005-07-05 Brian Warner <warner@lothar.com>
3675 * debian/.cvsignore: oops, missed one. Removing leftover file.
3677 2005-06-17 Brian Warner <warner@lothar.com>
3679 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3680 changed its output in 1.2.0, don't mistakenly think that the
3681 subversion we find isn't capable of supporting our tests.
3683 * debian/*: remove the debian/ directory and its contents, to make
3684 life easier for the proper Debian maintainer
3685 * MANIFEST.in: same
3686 * Makefile (release): same
3688 2005-06-07 Brian Warner <warner@lothar.com>
3690 * everything: create a distinct SourceStamp class to replace the
3691 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3692 Changed the signature of Source.startVC to include the revision
3693 information (instead of passing it through self.args). Implement
3694 branches for SVN (now only Darcs/Git is missing support). Add more
3695 Scheduler tests.
3697 2005-06-06 Brian Warner <warner@lothar.com>
3699 * everything: rearrange build scheduling. Create a new Scheduler
3700 object (configured in c['schedulers'], which submit BuildSets to a
3701 set of Builders. Builders can now use multiple slaves. Builds can
3702 be run on alternate branches, either requested manually or driven
3703 by changes. This changed some of the Status classes. Interlocks
3704 are out of service until they've been properly split into Locks
3705 and Dependencies. treeStableTimer, isFileImportant, and
3706 periodicBuild have all been moved from the Builder to the
3707 Scheduler.
3708 (BuilderStatus.currentBigState): removed the 'waiting' and
3709 'interlocked' states, removed the 'ETA' argument.
3711 2005-05-24 Brian Warner <warner@lothar.com>
3713 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3714 erroneously abandons the connection (in clientConnectionFailed)
3715 for non-UserErrors, which means that if we lose the connection due
3716 to a network problem or a timeout, we'll never try to reconnect.
3717 Fix this by not upcalling to the buggy parent method. Note:
3718 twisted-2.0 fixes this, but the function only has 3 lines so it
3719 makes more sense to copy it than to try and detect the buggyness
3720 of the parent class. Fixes SF#1207588.
3722 * buildbot/changes/changes.py (Change.branch): doh! Add a
3723 class-level attribute to accomodate old Change instances that were
3724 pickled before 0.6.5 (where .branch was added for new Changes).
3725 This fixes the exception that occurs when you try to look at an
3726 old Change (through asHTML).
3728 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3729 releases
3731 2005-05-23 Brian Warner <warner@lothar.com>
3733 * buildbot/__init__.py (version): release 0.6.6
3735 2005-05-23 Brian Warner <warner@lothar.com>
3737 * NEWS: update for 0.6.6 release
3738 * debian/changelog: same
3740 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3741 before starting: this was done by twistd back when we spawned it,
3742 now that we're importing the pieces and running them in the
3743 current process, we have to do it ourselves. This allows
3744 master.cfg to import files from the same directory without
3745 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3746 Stichele for the catch.
3747 (Options.opt_version): Add a --version command (actually, just make
3748 the existing --version command emit Buildbot's version too)
3750 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3751 fix to make this behave like other LogFiles, this time to handle
3752 existing LogFiles on disk. (add the missing .upgrade method)
3753 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3755 2005-05-21 Brian Warner <warner@lothar.com>
3757 * buildbot/test/test_runner.py (Create.testMaster): match the
3758 rawstring change in runner.py:masterTAC
3760 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3761 TwistedWords is installed
3762 * buildbot/test/test_status.py: same, with TwistedMail
3764 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3765 some old, deprecated, and removed config keys). This should enable
3766 you to use the base buildbot functionality with Twisted-2.0.0 when
3767 you don't also have TwistedWeb and TwistedWords installed
3769 2005-05-20 Brian Warner <warner@lothar.com>
3771 * buildbot/scripts/runner.py (run): call sendchange(), not
3772 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3773 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3774 (stop): don't wait for process to die when sending SIGHUP
3775 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3776 directory name gets interpreted, which you don't want
3777 (slaveTAC): same
3779 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3780 releases
3782 2005-05-18 Brian Warner <warner@lothar.com>
3784 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3786 2005-05-18 Brian Warner <warner@lothar.com>
3788 * README: update for 0.6.5
3789 * debian/changelog: same
3791 * buildbot/changes/changes.py: rename tag= to branch=, since
3792 that's how we're using it, and my design for the upcoming "build a
3793 specific branch" feature wants it. also, tag= was too CVS-centric
3794 * buildbot/changes/mail.py (parseSyncmail): same
3795 * buildbot/process/base.py (Build.isBranchImportant): same
3796 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3797 * docs/buildbot.texinfo (Attributes of Changes): same
3799 * NEWS: update tag=, update for upcoming release
3801 2005-05-17 Brian Warner <warner@lothar.com>
3803 * buildbot/scripts/runner.py (stop): actually poll once per
3804 second, instead of re-killing the poor daemon once per second.
3805 Sleep briefly (0.1s) before the first poll, since there's a good
3806 chance we can avoid waiting the full second if the daemon shuts
3807 down quickly. Also remove the sys.exit() at the end.
3808 (start): remove the unneighborly sys.exit()
3810 * Makefile: improve permission-setting to not kick Arch so badly
3812 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3813 default --keepalive=600, since it doesn't hurt very much, and it's
3814 a hassle to discover that you need it.
3815 * buildbot/test/test_runner.py (Create.testSlave): test it
3817 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3818 IRC bot about EXCEPTION
3820 * buildbot/status/client.py (PBListener): upcall more correctly
3822 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3823 an exception mark the overall build with EXCEPTION, not SUCCESS
3825 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3826 newline
3827 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3828 * Makefile: update some release-related stuff
3830 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3831 gets called when there isn't actually an active process, just end
3832 the Command instead of blowing up. I don't know how it gets into
3833 this state, but the twisted win32 buildslave will sometimes hang,
3834 and when it shakes its head and comes back, it thinks it's still
3835 running a Command. The next build causes this command to be
3836 interrupted, but the lack of self.process.pid breaks the interrupt
3837 attempt.
3839 * NEWS: document changes since the last release
3841 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3842 look for Makefile.buildbot instead of a bare Makefile . The
3843 'buildbot start' does not install this file, so you have to
3844 manually copy it if you want to customize startup behavior.
3845 (createMaster): change 'buildbot master' command to create
3846 Makefile.sample instead of Makefile, to create master.cfg.sample
3847 instead of master.cfg (requiring you to copy it before the
3848 buildmaster can be started). Both sample files are kept up to
3849 date, i.e. they are overwritten if they have been changed. The
3850 'buildbot.tac' file is *not* overwritten, but if the new contents
3851 don't match the old, a 'buildbot.tac.new' file is created and the
3852 user is warned. This seems to be a much more sane way to handle
3853 startup files. Also, don't sys.exit(0) when done, so we can run
3854 unit tests against it.
3855 (createSlave): same. Don't overwrite the sample info/ files.
3856 * buildbot/scripts/sample.mk: remove. the contents were pulled
3857 into runner.py, since they need to match the behavior of start()
3858 * setup.py: same
3859 * MANIFEST.in: same
3861 * docs/buildbot.texinfo (Launching the daemons): document it
3862 * buildbot/test/test_runner.py (Create): test it
3864 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3865 version that can handle string-in-string tests, because otherwise
3866 python-2.2 fails the tests. It'd be tremendous if Trial's test
3867 took two strings under 2.2 too.
3869 * everything: fixed all deprecation warnings when running against
3870 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3871 few that come from Twisted itself). This involved putting most of
3872 the Twisted-version specific code in the new buildbot.twcompat
3873 module, and creating some abstract base classes in
3874 buildbot.changes.base and buildbot.status.base (which might be
3875 useful anyway). __implements__ is a nuisance and requires an ugly
3876 'if' clause everywhere.
3878 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3879 delay before finishing the test: it seems that smtp.sendmail
3880 doesn't hang up on the server, so we must wait a moment so it can
3881 hang up on us. This removes the trial warning about an unclean
3882 reactor.
3884 2005-05-16 Brian Warner <warner@lothar.com>
3886 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3887 tuple of (delay, repeats).
3888 * buildbot/test/test_vc.py (Retry): test it
3889 * docs/buildbot.texinfo (Source Checkout): document it
3890 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3891 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3892 doVCFull() are handled by re-trying the checkout (after a delay)
3893 some number of times.
3894 (ShellCommand._startCommand): make header lines easier to read
3896 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3897 shutdown
3898 (WebTest.test_logfile): make sure master gets shut down, silences
3899 some "unclean reactor" test errors
3901 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3902 reactor once after shutdown, something in certain versions of
3903 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3904 fails, svn-trunk is ok.
3906 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3907 second win32 error message
3909 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3910 validating the ETA, so the tests don't fail on slow systems
3912 2005-05-15 Brian Warner <warner@lothar.com>
3914 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3915 the new LogFile class, so upgrading works properly
3916 (LogFileProducer.resumeProducing): survive resumeProducing after
3917 we've exhausted the chunkGenerator
3919 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3920 logs too
3921 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3922 (Log.testUpgrade): same
3924 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3925 Builds and logs with a cron job.
3927 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3928 of the old non-offline LogFile, added code to upgrade these to
3929 new-style contents-live-on-disk instances at load time (in a way
3930 that doesn't invalidate the old Build pickles, so upgrading to
3931 0.6.5 is not a one-way operation). Got rid of everything related
3932 to 'stub' builds.
3933 (LogFile.__init__): create LogFiles with the parent step status,
3934 the log's name, and a builder-relative filename where it can keep
3935 the contents on disk.
3936 (LogFile.hasContents): new method, clients are advised to call it
3937 before getText or getChunks and friends. If it returns False, the
3938 log's contents have been deleted and getText() will raise an
3939 error.
3940 (LogFile.getChunks): made it a generator
3941 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3942 Consumer (except one that takes chunks instead of strings). This
3943 enables streaming of very large logfiles without storing the whole
3944 thing in memory.
3945 (BuildStatus.generateLogfileName): create names like
3946 12-log-compile-output, with a _0 suffix if required to be unique
3947 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3948 or earlier) logfiles into new-style ones
3949 (BuilderStatus): remove everything related to 'stub' builds. There
3950 is now only one build cache, and we don't strip logs from old
3951 builds anymore.
3952 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3953 since we no longer fight to keep it in the cache
3955 * buildbot/status/html.py (TextLog.render_GET): use a
3956 ChunkConsumer to stream the log entries efficiently.
3957 (ChunkConsumer): wrapper which consumes chunks and writes
3958 formatted HTML.
3960 * buildbot/test/test_twisted.py (Parse.testParse): use a
3961 LogFile-like object instead of a real one
3963 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3964 (Log.testMerge3): validate more merge behavior
3965 (Log.testChunks): validate LogFile.getChunks
3966 (Log.testUpgrade): validate old-style LogFile upgrading
3967 (Log.testSubscribe): validate LogFile.subscribe
3968 (Log.testConsumer): validate LogFile.subscribeConsumer
3970 * buildbot/interfaces.py (IStatusLogStub): remove
3971 (IStatusLog.subscribeConsumer): new method
3972 (IStatusLog.hasContents): new method
3973 (IStatusLogConsumer): describes things passed to subscribeConsumer
3975 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3976 the log contents if it does not have any contents.
3977 (StatusResourceBuildStep.body): same
3978 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3980 2005-05-14 Brian Warner <warner@lothar.com>
3982 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3983 timeouts to try and make the windows metabuildslave not hang
3985 2005-05-13 Mike Taylor <bear@code-bear.com>
3987 * buildbot/slave/commands.py (rmdirRecursive): added a check
3988 to ensure the path passed into rmdirRecursive actually exists.
3989 On win32 a non-existant path would generate an exception.
3991 2005-05-13 Brian Warner <warner@lothar.com>
3993 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3994 shutil.rmtree which behaves correctly on windows in the face of
3995 files that you have to chmod before deleting. Thanks to Bear at
3996 the OSAF for the routine.
3997 (SourceBase.doClobber): use rmdirRecursive
3999 2005-05-12 Brian Warner <warner@lothar.com>
4001 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4002 method generate chunks instead of returning a big list. This
4003 allows the same method to be used for both old LogFile and new
4004 OfflineLogFile.
4005 (OfflineLogFile.getText): use the generator
4006 (OfflineLogFile.subscribe): same
4007 * buildbot/status/html.py (TextLog.resumeProducing): same
4008 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4010 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4011 point out that OfflineLogFile does not currently work with
4012 html.Waterfall . Fixing this is high-priority.
4014 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4015 apparently windows defaults to using stdout
4017 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4018 better message on failure so I can figure out the win32 problem
4020 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4021 log messages to include more useful copies of the command being
4022 run, the argv array, and the child command's environment.
4023 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4025 2005-05-11 Brian Warner <warner@lothar.com>
4027 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4028 will actually work
4029 * Makefile: update the deb-snapshot version
4031 * docs/buildbot.texinfo: move all .xhtml docs into a new
4032 .texinfo-format document, adding a lot of material in the process.
4033 This is starting to look like a real user's manual. Removed all
4034 the Lore-related files: *.xhtml, *.css, template.tpl .
4035 * docs/Makefile: simple makefile to run 'makeinfo'
4036 * buildbot/scripts/sample.cfg: rearrange slightly
4037 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4039 2005-05-10 Brian Warner <warner@lothar.com>
4041 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4042 different name for the internal twistw module, handle it.
4044 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4045 * setup.py: .. and stop trying to install it
4047 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4048 'git'), the new linux kernel VC system (http://kernel.org/git/).
4049 Thanks to Brandon Philips for the patch.
4050 * buildbot/slave/commands.py (Git): same
4052 2005-05-06 Brian Warner <warner@lothar.com>
4054 * buildbot/status/builder.py (OfflineLogFile): replace the default
4055 LogFile with a form that appends its new contents to a disk file
4056 as they arrive. The complete log data is never kept in RAM. This
4057 is the first step towards handling very large (100MB+) logfiles
4058 without choking quite so badly. (The other half is
4059 producer/consumer on the HTML pages).
4060 (BuildStepStatus.addLog): use OfflineLogFile by default
4061 (BuildStatus.getLogfileName): helper code to give the
4062 OfflineLogFile a filename to work with
4064 * buildbot/test/test_status.py (Results.testAddResults): update
4065 tests to handle new asserts
4066 * buildbot/test/test_vc.py (Patch.doPatch): same
4067 * buildbot/test/test_steps.py (BuildStep.setUp): same
4069 2005-05-05 Brian Warner <warner@lothar.com>
4071 * buildbot/scripts/runner.py (start): if there is no Makefile,
4072 launch the app by importing twistd's internals and calling run(),
4073 rather than spawning a new twistd process. This stands a much
4074 better chance of working under windows.
4075 (stop): kill the process with os.kill instead of spawning
4076 /bin/kill, again to reduce the number of external programs which
4077 windows might not have in the PATH. Also wait up to 5 seconds for
4078 the process to go away, allowing things like 'buildbot stop;
4079 buildbot start' to be reliable in the face of slow shutdowns.
4081 * buildbot/master.py (Dispatcher.__getstate__): remove old
4082 .tap-related methods
4083 (BuildMaster.__getstate__): same
4084 (makeService): same
4085 * buildbot/slave/bot.py (makeService): same
4086 (Options.longdesc): same
4087 * buildbot/scripts/runner.py: copy over some old mktap option text
4089 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4090 'buildbot master' now creates a buildbot.tac file, so there is no
4091 longer a create-instance/save/reload sequence. mktap is dead, long
4092 live twistd -y.
4093 * buildbot/scripts/sample.mk: use twistd -y, not -f
4094 * buildbot/test/test_config.py: remove mktap-based test
4095 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4096 * README: don't reference mktap
4098 * docs/source.xhtml: document some of the attributes that Changes
4099 might have
4101 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4103 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4104 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4105 * buildbot/changes/changes.py (Change)
4106 * buildbot/changes/mail.py (parseSyncmail)
4107 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4108 (Test3.testMsgS5)
4109 * buildbot/process/base.py (Build.isTagImportant)
4110 (Build.addChange)
4113 2005-05-04 Brian Warner <warner@lothar.com>
4115 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4116 connection after sending the change, so that unit tests don't
4117 complain about sockets being left around
4119 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4120 exception in phase=0 rendering
4121 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4123 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4125 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4126 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4127 and configuring builders with tuples.
4128 * buildbot/test/test_config.py: stop testing compatibility with
4129 deprecated config keys
4130 * buildbot/test/test_run.py: same
4132 2005-05-03 Brian Warner <warner@lothar.com>
4134 * contrib/arch_buildbot.py: survive if there are no logfiles
4135 (username): just use a string, os.getlogin isn't reliable
4137 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4138 so 'buildbot sendchange' actually works. The earlier test only
4139 covered the internal (non-reactor-running) form.
4141 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4142 script to notify the buildmaster about changes
4144 * buildbot/scripts/runner.py (sendchange): new command to send a
4145 change to a buildbot.changes.pb.PBChangeSource receiver.
4146 * buildbot/test/test_changes.py (Sender): test it
4148 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4149 after any reading of the config file, not just when we do it in
4150 startService. This makes some tests a bit cleaner.
4152 * buildbot/changes/pb.py: add some log messages
4154 * buildbot/process/base.py (Build.startBuild): fix a bug that
4155 caused an exception when the build terminated in the very first
4156 step.
4157 (Build.stepDone): let steps return a status of EXCEPTION. This
4158 terminates the build right away, and sets the build's overall
4159 status to EXCEPTION too.
4160 * buildbot/process/step.py (BuildStep.failed): return a status of
4161 EXCEPTION when that is what has happened.
4163 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4164 implement this, allowing Arch-based projects to get precise
4165 checkouts instead of always using the latest code
4166 (Bazaar): create variant of Arch to let folks use baz instead of
4167 tla. Requires a new buildslave too.
4168 * buildbot/slave/commands.py (Arch): add 'revision' argument
4169 (Bazaar): create variant of Arch that uses baz instead of tla.
4170 Remove the code that extracts the archive name from the
4171 register-archive output, since baz doesn't provide it, and require
4172 the user provide both the archive name and its location.
4173 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4175 2005-05-02 Brian Warner <warner@lothar.com>
4177 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4178 thanks to Nick Trout.
4180 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4181 deals better with source Makefile coming from a read-only CVS
4182 checkout. Thanks to Nick Trout for the catch.
4184 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4185 releases
4187 2005-04-28 Brian Warner <warner@lothar.com>
4189 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4191 * debian/changelog: update for 0.6.4
4193 2005-04-28 Brian Warner <warner@lothar.com>
4195 * README.w32: add a checklist of steps for getting buildbot
4196 running on windows.
4197 * MANIFEST.in: include it in the tarball
4199 * NEWS: update
4201 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4202 broken .tap files from 0.6.3 by getting rid of .services,
4203 .namedServices, and .change_svc at load time.
4205 2005-04-27 Brian Warner <warner@lothar.com>
4207 * NEWS: update in preparation for new release
4209 * buildbot/test/test_config.py (Save.testSave): don't pull in
4210 twisted.scripts.twistd, we don't need it and it isn't for windows
4211 anyway.
4213 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4214 accomodate win32 which can't do atomic-rename
4216 2005-04-27 Brian Warner <warner@lothar.com>
4218 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4219 timeouts to help the slow metabuildbot not flunk them so much
4220 (Disconnect.testBuild3): same
4221 (Disconnect.testBuild4): same
4222 (Disconnect.testInterrupt): same
4224 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4225 setup, it was completely broken for new buildmasters (those which
4226 did not have a 'change.pck' already saved. Thanks to Paul Warren
4227 for catching this (embarrassing!) bug.
4228 (Dispatcher.__getstate__): don't save our registered avatar
4229 factories, since they'll be re-populated when the config file is
4230 re-read.
4231 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4232 tests (since the real mktap-generated BuildMaster doesn't save
4233 this attribute).
4234 (BuildMaster.__getstate__): don't save any service children,
4235 they'll all be re-populated when the config file is re-read.
4236 * buildbot/test/test_config.py (Save.testSave): test for this
4238 2005-04-26 Brian Warner <warner@lothar.com>
4240 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4241 rendered with Blender.. looks a bit nicer.
4242 * buildbot/docs/images/icon.blend: add the Blender file for it
4244 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4245 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4246 running under windows. This appears to be the best way to allow
4247 BuildSteps to do something normal like 'trial -v buildbot.test' or
4248 'make foo' and still expect it to work. The idea is to make the
4249 BuildSteps look as much like what a developer would type when
4250 compiling or testing the tree by hand. This approach probably has
4251 problems when there are spaces in the arguments, so if you've got
4252 windows buildslaves, you'll need to pay close attention to your
4253 commands.
4255 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4256 timezone to the timestamp column.
4257 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4259 * buildbot/scripts/runner.py (loadOptions): do something sane for
4260 windows, I think. We use %APPDATA%/buildbot instead of
4261 ~/.buildbot, but we still search everywhere from the current
4262 directory up to the root for a .buildbot/ subdir. The "is it under
4263 $HOME" security test was replaced with "is it owned by the current
4264 user", which is only performed under posix.
4265 * buildbot/test/test_runner.py (Options.testFindOptions): update
4266 tests to match. The "is it owned by the current user" check is
4267 untested. The test has been re-enabled for windows.
4269 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4270 any "\n" in the expected output with the platform-specific line
4271 separator. Make this separator "\r\n" on PTYs under unix, they
4272 seem to do that and I don't know why
4274 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4275 windows for now, I don't know what ~/.buildbot/ should mean there.
4277 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4278 win32 compatibility, don't use "/tmp"
4279 (Basedir.testChangeBuilddir): remove more unixisms
4281 2005-04-26 Brian Warner <warner@lothar.com>
4283 * buildbot/test/test_control.py (Force.rmtree): python2.2
4284 compatibility, apparently its shutil.rmtree ignore_errors=
4285 argument is ignored.
4286 * buildbot/test/test_run.py (Run.rmtree): same
4287 (RunMixin.setUp): same
4289 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4290 not os.path.sep
4292 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4293 'substring in string' operator, must use string.find(substr)!=-1
4294 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4295 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4297 * buildbot/scripts/runner.py (loadOptions): add code to search for
4298 ~/.buildbot/, a directory with things like 'options', containing
4299 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4300 the current directory, your $HOME directory, or anywhere
4301 inbetween, as long as you're somewhere inside your home directory.
4302 (debugclient): look in ~/.buildbot/options for master and passwd
4303 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4304 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4306 * buildbot/status/client.py (makeRemote): new approach to making
4307 IRemote(None) be None, which works under Twisted-2.0
4308 * buildbot/test/test_status.py (Client.testAdaptation): test it
4310 * buildbot/status/builder.py (Status.builderAdded): when loading a
4311 pickled BuilderStatus in from disk, set its name after loading.
4312 The config file might have changed its name (but not its
4313 directory) while it wasn't looking.
4315 * buildbot/process/builder.py (Builder.attached): always return a
4316 Deferred, even if the builder was already attached
4317 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4319 2005-04-25 Brian Warner <warner@lothar.com>
4321 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4322 category-related exception when announcing a build has finished
4324 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4325 reference no-longer-existent changemaster.sources
4326 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4328 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4329 releases
4331 2005-04-25 Brian Warner <warner@lothar.com>
4333 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4335 * debian/changelog: update for 0.6.3
4337 2005-04-25 Brian Warner <warner@lothar.com>
4339 * MANIFEST.in: make sure debug.glade is in the tarball
4341 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4343 * NEWS: update for the imminent 0.6.3 release
4345 * buildbot/status/html.py (HtmlResource.content): make the
4346 stylesheet <link> always point at "buildbot.css".
4347 (StatusResource.getChild): map "buildbot.css" to a static.File
4348 containing whatever css= argument was provided to Waterfall()
4349 (Waterfall): provide the "classic" css as the default.
4350 * docs/waterfall.classic.css: move default CSS from here ..
4351 * buildbot/status/classic.css: .. to here
4353 * MANIFEST.in: make sure classic.css is included in the tarball
4354 * setup.py: and that it is installed too, under buildbot/status/
4356 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4357 the module level, because buildbot.tap files from 0.6.2 don't have
4358 it in their attribute dictionary.
4360 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4361 really exists at startup, might save some confusion somewhere.
4363 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4365 * docs/waterfall.classic.css:
4366 add a stylesheet that's almost the same as the "classic"
4367 buildbot style
4369 * buildbot/status/builder.py:
4370 add EXCEPTION as a result - this is a problem for the bot
4371 maintainer, not a build problem for the changers
4372 * buildbot/process/step.py:
4373 use EXCEPTION instead of FAILURE for exceptions
4374 * buildbot/status/html.py:
4375 add build_get_class to get a class out of a build/buildstep
4376 finish naming the classes
4377 split out sourceNames to changeNames and builderNames so we
4378 can style them separately
4379 * docs/config.xhtml:
4380 finish documenting classes as they are right now
4382 * buildbot/status/html.py:
4383 name the classes as we agreed on IRC
4384 * docs/config.xhtml:
4385 and document them
4387 * buildbot/status/html.py:
4388 same for cssclass->class_
4390 * buildbot/status/html.py:
4391 as decided on IRC, use class_ for the "class" attribute to not
4392 conflict with the class keyword, and clean up the messy **{} stuff.
4394 * buildbot/status/mail.py:
4395 put back "builders" argument, and fix docstring, because the
4396 code *ignores* builders listed in this argument
4398 * buildbot/process/builder.py:
4399 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4401 * docs/config.xhtml:
4402 describe the category argument for builders
4404 * buildbot/status/builder.py:
4405 Fix a silly bug due to merging
4407 * buildbot/process/builder.py:
4408 remove category from the process Builder ...
4409 * buildbot/status/builder.py:
4410 ... and add it to BuilderStatus instead.
4411 Set category on unpickled builder statuses, they might not have it.
4412 * buildbot/master.py:
4413 include category when doing builderAdded
4414 * buildbot/status/mail.py:
4415 return None instead of self for builders we are not interested in.
4416 * buildbot/test/test_run.py:
4417 fix a bug due to only doing deferredResult on "dummy" waiting
4418 * buildbot/test/test_status.py:
4419 add checks for the Mail IStatusReceiver returning None or self
4421 * buildbot/status/html.py:
4422 fix testsuite by prefixing page title with BuildBot
4424 * buildbot/status/builder.py:
4425 have .category in builder status ...
4426 * buildbot/process/builder.py:
4427 ... and set it from Builder
4428 * buildbot/status/html.py:
4429 make .css a class variable
4430 * buildbot/test/test_status.py:
4431 write more tests to cover our categories stuff ...
4432 * buildbot/status/mail.py:
4433 ... and fix the bug that this uncovered
4435 * buildbot/changes/mail.py:
4436 * buildbot/changes/pb.py:
4437 * buildbot/master.py:
4438 * buildbot/process/base.py:
4439 * buildbot/process/factory.py:
4440 * buildbot/process/interlock.py:
4441 * buildbot/process/step.py:
4442 * buildbot/process/step_twisted.py:
4443 * buildbot/slave/commands.py:
4444 * buildbot/status/builder.py:
4445 * buildbot/status/client.py:
4446 * buildbot/status/html.py:
4447 * buildbot/status/mail.py:
4448 * buildbot/status/progress.py:
4449 * buildbot/test/test_changes.py:
4450 * buildbot/test/test_config.py:
4451 * buildbot/test/test_control.py:
4452 * buildbot/test/test_interlock.py:
4453 * buildbot/test/test_maildir.py:
4454 * buildbot/test/test_mailparse.py:
4455 * buildbot/test/test_run.py:
4456 * buildbot/test/test_slavecommand.py:
4457 * buildbot/test/test_status.py:
4458 * buildbot/test/test_steps.py:
4459 * buildbot/test/test_twisted.py:
4460 * buildbot/test/test_util.py:
4461 * buildbot/test/test_vc.py:
4462 * buildbot/test/test_web.py:
4463 * buildbot/util.py:
4464 add test-case-name at the top of a whole set of files
4466 * buildbot/status/builder.py:
4467 keep order of addition when getting builder names
4468 * buildbot/status/words.py:
4469 * buildbot/test/test_run.py:
4470 add test for getBuilderNames
4472 * buildbot/process/base.py:
4473 * buildbot/process/step.py:
4474 * buildbot/status/builder.py:
4475 * buildbot/status/html.py:
4476 make buildbot css-able
4477 replace the color code for purple with purple, don't understand
4478 why it wasn't purple to start with
4480 * buildbot/status/words.py:
4481 ok, so it doesn't look like BuilderStatus.remote is still valid.
4482 Use what waterfall uses instead.
4484 * buildbot/interfaces.py:
4485 * buildbot/status/builder.py:
4486 * buildbot/status/html.py:
4487 * buildbot/status/mail.py:
4488 * buildbot/status/words.py:
4489 * buildbot/test/test_run.py:
4490 use categories everywhere and make it be a list. More sensible
4491 for the future. Also make words actually respect this in
4492 buildFinished.
4494 * buildbot/interfaces.py:
4495 add category argument to getBuilderNames
4496 * buildbot/process/builder.py:
4497 * buildbot/status/builder.py:
4498 * buildbot/status/html.py:
4499 * buildbot/status/mail.py:
4500 * buildbot/status/words.py:
4501 * buildbot/test/test_run.py:
4502 move from specifying builders by name to specifying the category
4504 * buildbot/status/html.py:
4505 * buildbot/status/words.py:
4506 add "builders=" to __init__ of status clients so they can
4507 limit themselves to the given list of builders to report on
4509 * buildbot/status/html.py: set the title to the product name
4511 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4513 * buildbot/interfaces.py:
4514 * buildbot/status/builder.py:
4515 more documentation. Hm, not sure if ChangeLog entries make sense
4516 here...
4518 2005-04-23 Brian Warner <warner@lothar.com>
4520 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4522 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4524 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4525 the sub-commands that log buildmaster status to stdout and to a
4526 GUI window, respectively.
4528 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4529 functionality is working again, but all the step-status and ETA
4530 stuff is missing. Commented out a lot of code pending more
4531 overhaul work.
4533 * buildbot/status/client.py: make sure that IRemote(None) is None
4535 * buildbot/changes/changes.py: import defer, oops
4536 (ChangeMaster): remove the .sources list, rely upon the fact that
4537 MultiServices can be treated as sequences of their children. This
4538 cleans up the add/remove ChangeSource routines a lot, as we keep
4539 exactly one list of the current sources instead of three.
4541 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4542 up an empty ChangeMaster at init time.
4543 (BuildMaster.loadChanges): if there are changes to be had from
4544 disk, replace self.change_svc with the new ones. If not, keep
4545 using the empty ChangeMaster set up in __init__.
4546 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4547 instead of a separate list, makes the code a bit cleaner.
4548 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4549 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4550 Extend the test to make sure we can get rid of the sources when
4551 we're done.
4553 2005-04-22 Brian Warner <warner@lothar.com>
4555 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4556 and info/host files when making the slave directory
4558 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4559 whendone= argument, just return the Deferred and let the caller do
4560 what they want with it.
4561 (Disconnect.testBuild1): wait for shutdownSlave
4562 (Basedir.testChangeBuilddir): new test to make sure changes to the
4563 builddir actually get propagated to the slave
4565 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4566 explicit method, rather than passing the builddir in __init__ .
4567 Make sure to update self.basedir too, this was broken before.
4568 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4569 builders and for ones that have just had their builddir changed.
4570 (BotFactory): add a class-level .perspective attribute, so
4571 BuildSlave.waitUntilDisconnected won't get upset when the
4572 connection hasn't yet been established
4573 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4574 tests can reach through it to inspect the SlaveBuilders
4576 * buildbot/process/base.py (Build.buildException): explain the
4577 log.err with a log.msg
4578 * buildbot/process/builder.py (Builder.startBuild): same
4579 (Builder._startBuildFailed): improve error message
4581 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4582 occurred because we lost the brand-new connection, retry instead
4583 of giving up. If not, it's probably an authorization failure, and
4584 it makes sense to stop trying. Make sure we log.msg the reason
4585 that we're log.err'ing the failure, otherwise test failures are
4586 really hard to figure out.
4588 * buildbot/master.py: change loadConfig() to return a Deferred
4589 that doesn't fire until the change has been fully implemented.
4590 This means any connected slaves have been updated with the new
4591 builddir. This change makes it easier to test the code which
4592 actually implements this builddir-updating.
4593 (BotPerspective.addBuilder): return Deferred
4594 (BotPerspective.removeBuilder): same
4595 (BotPerspective.attached): same
4596 (BotPerspective._attached): same. finish with remote_print before
4597 starting the getSlaveInfo, instead of doing them in parallel
4598 (BotPerspective.list_done): same
4599 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4600 actually calling slave.disconnect()
4601 (BotMaster.addBuilder): same
4602 (BotMaster.removeBuilder): same
4603 (BuildMaster.loadConfig): same
4604 (BuildMaster.loadConfig_Slaves): same
4605 (BuildMaster.loadConfig_Sources): same
4606 (BuildMaster.loadConfig_Builders): same
4607 (BuildMaster.loadConfig_status): same
4609 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4610 a Deferred that fires when the source is finally removed
4612 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4613 the previous tree on win32, where we have to do it synchronously,
4614 make sure we return a Deferred anyway.
4615 (SourceBase.doCopy): same
4617 * buildbot/scripts/runner.py (statusgui): use the text client for
4618 now, while I rewrite the Gtk one
4619 * buildbot/clients/base.py: strip out old code, leaving just the
4620 basic print-message-on-event functionality. I also remove the
4621 ReconnectingPBClientFactory, but it does at least quit when it
4622 loses the connection instead of going silent
4624 2005-04-21 Brian Warner <warner@lothar.com>
4626 * Makefile: minor tweaks
4628 * NEWS: point out deprecation warnings, new features for
4629 /usr/bin/buildbot
4631 * buildbot/master.py (BuildMaster.loadConfig): emit
4632 DeprecationWarnings for Builders defined with tuples. Rearrange
4633 code to facility removal of deprecated configuration keys in the
4634 next release.
4636 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4637 'buildbot' command to put a little Makefile in the target that
4638 helps you re-create the buildbot.tap file, start or stop the
4639 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4640 all the files 0600, since they contain passwords.
4641 (start): if there is a Makefile, and /usr/bin/make exists, use
4642 'make start' in preference to a raw twistd command. This lets
4643 slave admins put things like PYTHONPATH variables in their
4644 Makefiles and have them still work when the slave is started with
4645 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4646 be nice to first try the 'make' command and only fall back to
4647 twistd if it fails. TODO: the Makefile's "start" command does not
4648 add the --reactor=win32 argument when running under windows.
4649 (Options.debugclient, Options.statusgui): add sub-commands to launch
4650 the debug client (formerly in contrib/debugclient.py) and the
4651 Gtk status application (currently broken)
4652 * buildbot/clients/debug.py: move from contrib/debugclient.py
4653 * buildbot/clients/debug.glade: same
4655 * buildbot/test/test_trial.py: remove it. This requires some
4656 functionality out of Twisted that isn't there yet, and until then
4657 having it around just confuses things.
4659 * buildbot/test/test_slavecommand.py (Shell): test both with and
4660 without PTYs, and make sure that command output is properly
4661 interleaved in the with-PTY case. I think the without-PTY test
4662 should pass on windows, where we never use PTYs anyway.
4664 2005-04-20 Brian Warner <warner@lothar.com>
4666 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4668 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4670 * NEWS: start creating entries for the next release
4672 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4674 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4675 (WebTest.test_webPathname): same
4676 (WebTest.test_webPathname_port): same
4677 (WebTest.test_waterfall): use the default favicon rather than
4678 rooting around the filesystem for it. Open the expected-icon file
4679 in binary mode, to make win32 tests happier (thanks to Nick Trout
4680 for the catch)
4681 * buildbot/status/html.py (buildbot_icon): win32 portability
4683 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4684 win32-compatibility fixes from Nick Trout, the "file not found" message
4685 is different under windows
4686 (FakeSlaveBuilder.__init__): clean up setup a bit
4687 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4689 2005-04-19 Brian Warner <warner@lothar.com>
4691 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4692 skip-if-repositories-are-unavailable test to not kill the trial
4693 that comes with Twisted-1.3.0
4695 * setup.py: install buildbot.png icon file when installing code
4697 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4698 environment used by the command, at least on the child side.
4700 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4701 this method needs to be added and implemented because it gets
4702 called under heavy load. I don't quite understand the
4703 producer/consumer API enough to write it.
4704 (StatusResource.getChild): add a resource for /favicon.ico
4705 (Waterfall.__init__): add favicon= argument
4706 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4707 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4708 (WebTest.test_webPathname): same
4709 (WebTest.test_webPathname_port): same
4710 * docs/config.xhtml: mention favicon=
4711 * buildbot/buildbot.png: add a default icon, dorky as it is
4713 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4715 * buildbot/master.py:
4716 * buildbot/process/base.py:
4717 * buildbot/process/builder.py:
4718 * buildbot/process/interlock.py:
4719 * buildbot/status/builder.py:
4720 * buildbot/status/html.py:
4721 * buildbot/status/mail.py:
4722 * buildbot/status/words.py:
4723 new documentation while digging through the code
4725 2005-04-17 Brian Warner <warner@lothar.com>
4727 * general: try to fix file modes on all .py files: a+r, a-x,
4728 but let buildbot/clients/*.py be +x since they're tools
4730 * docs/epyrun (addMod): when an import fails, say why
4732 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4734 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4736 * buildbot/process/base.py:
4737 * buildbot/process/builder.py:
4738 * buildbot/status/builder.py:
4739 new documentation while digging through the code
4741 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4743 * buildbot/changes/changes.py:
4744 * buildbot/changes/p4poller.py:
4745 * buildbot/interfaces.py:
4746 * buildbot/process/base.py:
4747 * buildbot/process/builder.py:
4748 * buildbot/process/step.py:
4749 * buildbot/process/step_twisted.py:
4750 * buildbot/slave/bot.py:
4751 * buildbot/slave/commands.py:
4752 * buildbot/status/builder.py:
4753 fix all docstrings to make epydoc happy. In the process of fixing
4754 some, I also moved pieces of docs, and removed some deprecated
4755 documentation
4757 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4759 * buildbot/process/builder.py:
4760 * buildbot/process/interlock.py:
4761 * buildbot/process/process_twisted.py:
4762 * buildbot/process/step.py:
4763 BuildProcess -> Build, as it looks like that's what happened
4764 * buildbot/process/base.py:
4765 * buildbot/process/factory.py:
4766 update epydoc stuff
4768 2005-04-17 Brian Warner <warner@lothar.com>
4770 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4771 update compile command to accomodate the Twisted split.. now
4772 instead of './setup.py build_ext -i', you do './setup.py all
4773 build_ext -i', to run build_ext over all sub-projects.
4774 (FullTwistedBuildFactory): same
4775 (TwistedReactorsBuildFactory): same
4777 * buildbot/status/html.py (TextLog.finished): null out self.req
4778 when we're done, otherwise the reference cycle of TextLog to .req
4779 to .notifications to a Deferred to TextLog.stop keeps them from
4780 being collected, and consumes a huge (610MB on pyramid at last
4781 check) amount of memory.
4783 2005-04-11 Brian Warner <warner@lothar.com>
4785 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4786 normalize the VC-repository location.. makes SVN happier with
4787 certain test environments.
4789 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4790 RemoteShellCommand gets its own .env dictionary, so that code in
4791 start() doesn't mutate the original. I think this should fix the
4792 step_twisted.Trial problem where multiple identical components
4793 kept getting added to PYTHONPATH= over and over again.
4795 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4796 adding epydoc-format docstrings to many classes. Thanks to Thomas
4797 Vander Stichele for the patches.
4798 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4799 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4800 * buildbot/slave/bot.py, commands.py, registry.py: same
4802 2005-04-05 Brian Warner <warner@lothar.com>
4804 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4805 preserve timestamps, helps incremental builds of large trees.
4806 Patch from Rene Rivera.
4808 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4809 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4810 for the catch.
4812 2005-04-03 Brian Warner <warner@lothar.com>
4814 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4815 with one dict, apparently exec has some scoping bugs when used
4816 with both global/local dicts. Thanks to Nathaniel Smith for the
4817 catch.
4819 2005-04-02 Brian Warner <warner@lothar.com>
4821 * buildbot/process/step_twisted.py (countFailedTests): the new
4822 trial in Twisted-2.0 emits a slightly different status line than
4823 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4824 mistakenly think the test count is unparseable.
4825 (Trial.start): note that for some reason each build causes another
4826 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4827 be fixed but I'm not sure quite where the problem is.
4829 2005-04-01 Brian Warner <warner@lothar.com>
4831 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4832 deferredResult to avoid hangs/warnings under twisted-2.0
4833 (RunMixin.tearDown): same
4834 (RunMixin.shutdownSlave): same
4835 (Disconnect.testIdle1): same
4836 (Disconnect.testBuild2): same: wait one second after the build
4837 finishes for test to really be done.. this should be cleaned up to
4838 avoid wasting that second. Builder.detach uses a callLater(0),
4839 either that should be done in-line (something else needed that
4840 behavior), or it should return a Deferred that fires when the
4841 builder is really offline.
4842 (Disconnect.testBuild3): same
4843 (Disconnect.testDisappear): same
4845 * buildbot/test/test_web.py: rearrange server-setup and teardown
4846 code to remove unclean-reactor warnings from twisted-2.0
4848 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4849 so the tests don't hang under twisted-2.0
4851 2005-03-31 Brian Warner <warner@lothar.com>
4853 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4854 caused a warning each time the master changed our set of builders
4856 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4857 w32, don't unlink the file unless it already exists. Thanks to
4858 Baptiste Lepilleur for the catch.
4859 (BuilderStatus.saveYourself): same
4861 2005-02-01 Brian Warner <warner@lothar.com>
4863 * buildbot/status/html.py (TextLog.getChild): use a /text child
4864 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4865 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4866 logfile as text/plain (no markup, no headers). This replaces the
4867 previous scheme (which used an ?text=1 argument), and gets us back
4868 to a relative link (which works better when the buildbot lives
4869 behind another web server, such as Apache configured as a reverse
4870 proxy). Thanks to Gerald Combs for spotting the problem.
4872 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4873 releases
4875 2004-12-13 Brian Warner <warner@lothar.com>
4877 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4879 * debian/changelog: update for 0.6.2
4880 * NEWS: finalize for 0.6.2
4882 2004-12-11 Brian Warner <warner@lothar.com>
4884 * NEWS: bring it up to date
4886 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4887 detection code. Require some sign of life from the buildmaster
4888 every BotFactory.keepaliveInterval seconds. Provoke this
4889 indication at BotFactory.keepaliveTimeout seconds before the
4890 deadline by sending a keepalive request. We don't actually care if
4891 that request is answered in a timely fashion, what we care about
4892 is that .activity() is called before the deadline. .activity() is
4893 triggered by any PB message from the master (including an ack to
4894 one of the slave's status-update messages). With this new scheme,
4895 large status messages over slow pipes are OK, as long as any given
4896 message can be sent (and thus acked) within .keepaliveTimeout
4897 seconds (which defaults to 30).
4898 (SlaveBuilder.remote_startCommand): record activity
4899 (SlaveBuilder.ackUpdate): same
4900 (SlaveBuilder.ackComplete): same
4901 (BotFactory.gotPerspective): same
4902 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4904 2004-12-09 Brian Warner <warner@lothar.com>
4906 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4907 debug message
4909 * buildbot/process/step_twisted.py (Trial._commandComplete):
4910 update self.cmd when we start the 'cat test.log' transfer. Without
4911 this, we cannot interrupt the correct RemoteCommand when we lose
4912 the connection.
4914 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4915 trying to tell the slave to stop the command if we're already
4916 inactive, or if we no longer have a .remote
4918 * buildbot/process/builder.py (Builder._detached): don't let an
4919 exception in currentBuild.stopBuild() prevent the builder from
4920 being marked offline
4922 2004-12-07 Brian Warner <warner@lothar.com>
4924 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4925 KeyError that happens when you ask for a non-existent Builder, and
4926 translate it into a UsageError.
4928 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4929 losing the slave in the middle of a remote step is handled too
4931 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4932 be a Failure, so be sure to stringify it before using it as the
4933 contents of the 'interrupt' logfile
4934 (RemoteCommand.interrupt): use stringified 'why' in
4935 remote_interruptCommand too, just in case
4937 2004-12-06 Brian Warner <warner@lothar.com>
4939 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4940 instead of 'tla update', which is more efficient in case we've
4941 missed a couple of patches since the last update.
4943 * debian/changelog: update for previous (0.6.1) release. Obviously
4944 this needs to be handled better.
4946 2004-12-05 Brian Warner <warner@lothar.com>
4948 * NEWS: update for stuff since last release
4950 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4951 match the maybeDeferred change in Dispatcher.requestAvatar
4952 * buildbot/changes/pb.py (ChangePerspective.attached): same
4953 * buildbot/status/client.py (StatusClientPerspective.attached): same
4954 * buildbot/process/builder.py (Builder._attached3): same
4955 * buildbot/pbutil.py (NewCredPerspective.attached): same
4957 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4958 the date to the top-most box, if it is not the same as today's
4959 date.
4961 * docs/slave.xhtml: provide a buildslave setup checklist
4963 * docs/source.xhtml (Arch): correct terminology
4965 2004-12-04 Brian Warner <warner@lothar.com>
4967 * buildbot/test/test_slavecommand.py: use sys.executable instead
4968 of hard-coding 'python' for child commands, might help portability
4970 * docs/examples/twisted_master.cfg: update to current usage
4972 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4973 'stop build' command to the IRC bot
4975 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4976 message that broke PBChangeSource
4978 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4979 (SlaveBuilder): make some attributes class-level, remove the old
4980 "update queue" which existed to support resuming a build after the
4981 master connection was lost. Try to reimplement that feature later.
4982 (SlaveBuilder.stopCommand): clear self.command when the
4983 SlaveCommand finishes, so that we don't try to kill a leftover one
4984 at shutdown time.
4985 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4986 .finishCommand
4988 * buildbot/slave/commands.py (SourceBase): set self.command for
4989 all VC commands, so they can be interrupted.
4991 2004-12-03 Brian Warner <warner@lothar.com>
4993 * buildbot/master.py: clean up slave-handling code, to handle
4994 slave-disconnect and multiple-connect better
4995 (BotPerspective): make these long-lasting, exactly one per bot
4996 listed in the config file.
4997 (BotPerspective.attached): if a slave connects while an existing
4998 one appears to still be connected, disconnect the old one first.
4999 (BotPerspective.disconnect): new method to forcibly disconnect a
5000 buildslave. Use some hacks to empty the transmit buffer quickly to
5001 avoid the long (20-min?) TCP timeout that could occur if the old
5002 slave has dropped off the net.
5003 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5004 own their own SlaveStatus objects. Remove .attached/.detached, add
5005 .addSlave/.removeSlave, treat slaves like Builders (config file
5006 parsing sends deltas to the BotMaster). Inform the slave
5007 instances, i.e. the BotPerspective, about addBuilder and
5008 removeBuilder.
5009 (BotMaster.getPerspective): turns into a single dict lookup
5010 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5011 which gives BotPerspective.attached a chance to disconnect the old
5012 slave first.
5013 (BuildMaster.loadConfig): add code (disabled) to validate that all
5014 builders use known slaves (listed in c['bots']). The check won't
5015 work with tuple-specified builders, which are deprecated but not
5016 yet invalid, so the check is disabled for now.
5017 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5018 routine, do the add/changed/removed dance with them like we do
5019 with builders.
5020 (BuildMaster.loadConfig_Sources): move source-config into a
5021 separate routine too
5023 * buildbot/status/builder.py (Status.getSlave): get the
5024 SlaveStatus object from the BotPerspective, not the BotMaster.
5026 * buildbot/test/test_run.py: bunch of new tests for losing the
5027 buildslave at various points in the build, handling a slave that
5028 connects multiple times, and making sure we can interrupt a
5029 running build
5031 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5032 something other than 'Bot' for the Bot object, to make certain
5033 test cases easier to write.
5034 (BuildSlave.waitUntilDisconnected): utility method for testing
5036 2004-11-30 Brian Warner <warner@lothar.com>
5038 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5040 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5041 argument, return a Deferred that always fires with True or False.
5042 I don't use an errback to indicate 'ping failed' so that callers
5043 are free to ignore the deferred without causing spurious errors in
5044 the logs.
5045 * buildbot/process/builder.py (BuilderControl.ping): implement it
5047 * buildbot/test/test_run.py (Status.testDisappear): test ping
5048 (Status.disappearSlave): fix it
5050 2004-11-30 Brian Warner <warner@lothar.com>
5052 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5053 (IBuilderControl): add .getBuild(num), only works for the current
5054 build, of course, although it might be interesting to offer
5055 something for builds in the .waiting or .interlocked state.
5057 * buildbot/process/base.py (Build): have .stopBuild just do the
5058 interrupt, then let the build die by itself.
5059 (BuildControl): add .stopBuild, and add a point-event named
5060 'interrupt' just after the build so status viewers can tell that
5061 someone killed it.
5062 (BuilderControl): add .getBuild
5064 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5065 stops when you kill it, good for testing
5066 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5067 contains the 'reason' text.
5069 * buildbot/status/html.py: Add Stop Build button, if the build can
5070 still be stopped. Send a Redirect (to the top page) one second
5071 later, hopefully long enough for the interrupt to have an effect.
5072 Move make_row() up to top-level to share it between Stop Build and
5073 Force Build.
5075 * buildbot/slave/commands.py: only kill the child process once
5077 * buildbot/test/test_run.py: add testInterrupt
5079 2004-11-29 Brian Warner <warner@lothar.com>
5081 * buildbot/process/base.py: Refactor command interruption. The
5082 Build is now responsible for noticing that the slave has gone
5083 away: Build.lostRemote() interrupts the current step and makes
5084 sure that no further ones will be started.
5086 * buildbot/process/builder.py: When the initial remote_startBuild
5087 message fails, log it: this usually indicates that the slave has
5088 gone away, but we don't really start paying attention until they
5089 fail to respond to the first step's command.
5091 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5092 slave disconnect. Now sports a new interrupt() method. Error
5093 handling was simplified a lot by chaining deferreds, so
5094 remoteFailed/remoteComplete were merged into a single
5095 remoteComplete method (which can now get a Failure object).
5096 Likewise failed/finished were merged into just _finished.
5097 (BuildStep): Add interrupt(why) method, and if why is a
5098 ConnectionLost Failure then the step is failed with some useful
5099 error text.
5101 * buildbot/slave/bot.py: stop the current command when the remote
5102 Step reference is lost, and when the slave is shut down.
5103 (Bot): make it a MultiService, so it can have children. Use
5104 stopService to tell when the slave is shutting down.
5105 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5106 remote_interruptCommand (which asks the current SlaveCommand to
5107 stop but allows it to keep emitting status messages), and
5108 stopCommand (which tells it to shut up and die).
5110 * buildbot/slave/commands.py: make commands interruptible
5111 (ShellCommand.kill): factor out os.kill logic
5112 (Command): factor out setup()
5113 (Command.sendStatus): don't send status if .running is false, this
5114 happens when the command has been halted.
5115 (Command.interrupt): new method, used to tell the command to die
5116 (SlaveShellCommand): implement .interrupt
5117 (DummyCommand): implement .interrupt
5118 (SourceBase, etc): factor out setup(), don't continue substeps if
5119 .interrupted is set
5121 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5122 so they can be called after finishing
5124 * buildbot/test/test_run.py: new tests for disconnect behavior,
5125 refactor slave-shutdown routines, add different kinds of
5126 slave-shutdown
5128 2004-11-27 Brian Warner <warner@lothar.com>
5130 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5131 method to express ETA time like "2m45s" instead of "165 seconds"
5133 2004-11-24 Brian Warner <warner@lothar.com>
5135 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5136 archive after the test completes, to avoid cluttering the user's
5137 'tla archives' listing with a bogus entry. Arch doesn't happen to
5138 provide any way to override the use of ~/.arch-params/, so there
5139 isn't a convenient way to avoid touching the setup of the user who
5140 runs the test.
5141 (VC_HTTP.testArchHTTP): same
5143 2004-11-23 Brian Warner <warner@lothar.com>
5145 * buildbot/status/html.py (TextLog): split render() up into
5146 render_HEAD and render_GET. Use a Producer when sending log
5147 chunks, to reduce memory requirements and avoid sending huge
5148 non-Banana-able strings over web.distrib connections. Requires
5149 peeking under the covers of IStatusLog.
5150 (TextLog.resumeProducing): fix the "as text" link, handle client
5151 disconnects that occur while we're still sending old chunks.
5153 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5154 use defer.succeed, not the non-existent defer.success
5155 (LogFile.waitUntilFinished): same
5156 (LogFile.subscribe): don't add watchers to a finished logfile
5158 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5159 releases
5161 2004-11-23 Brian Warner <warner@lothar.com>
5163 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5165 2004-11-23 Brian Warner <warner@lothar.com>
5167 * NEWS: update for the 0.6.1 release
5168 * MANIFEST.in: add new files
5170 * README (INSTALLATION): explain how to enable the extra VC tests
5172 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5173 level to, so old pickled builds can be displayed ok
5175 2004-11-22 Brian Warner <warner@lothar.com>
5177 * NEWS: summarize updates since last release
5179 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5180 Yoz Grahame. Closes SF#1050138.
5182 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5183 SF#1042563.
5185 * buildbot/process/step_twisted.py (Trial): update docs a bit
5187 * docs/factories.xhtml: fix Trial factory docs to match reality.
5188 Closes: SF#1049758.
5190 * buildbot/process/factory.py (Trial.__init__): add args for
5191 randomly= and recurse=, making them available to instantiators
5192 instead of only to subclassers. Closes: SF#1049759.
5194 2004-11-15 Brian Warner <warner@lothar.com>
5196 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5197 try to teach the Quick factory to use multiple versions of python
5199 2004-11-12 Brian Warner <warner@lothar.com>
5201 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5202 safer w32-compatible approach, and only use it on windows
5203 (BuildStatus.saveYourself): same
5205 2004-11-11 Brian Warner <warner@lothar.com>
5207 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5208 it: one string merge per chunk. There are now separate .entries
5209 and .runEntries lists: when enumerating over all chunks, make sure
5210 to look at both.
5211 * buildbot/test/test_status.py (Log): more tests
5213 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5214 chunks together, up to 10kb per chunk. This ought to cut down on
5215 the CPU-burning overhead of large log files. Thanks to Alexander
5216 Staubo for spotting the problem.
5217 * buildbot/test/test_status.py (Log): tests for same
5219 2004-11-10 Brian Warner <warner@lothar.com>
5221 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5222 header to outbound mail
5223 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5225 2004-11-08 Brian Warner <warner@lothar.com>
5227 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5228 can't do os.rename() onto an existing file, so catch the exception
5229 and unlink the target file first. This introduces a slight window
5230 where the existing file could be lost, but the main failure case
5231 (disk full) should still be handled safely.
5232 (BuildStatus.saveYourself): same
5234 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5235 separator character instead of os.sep, because the filenames being
5236 split here are coming from the VC system, which can have a
5237 different pathname convention than the local host. This should
5238 help a buildmaster running on windows that uses a CVS repository
5239 which runs under unix.
5240 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5242 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5243 when there are no test failures to be parsed
5245 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5246 instead of the unix-specific os.system("cp"), thanks to Elliot
5247 Murphy for this and the other buildbot-vs-windows catches.
5248 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5250 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5251 echo the command as it is run
5253 * setup.py: install sample.mk too, not just sample.cfg
5254 (scripts): install contrib/windows/buildbot.bat on windows
5256 2004-11-07 Brian Warner <warner@lothar.com>
5258 * buildbot/process/builder.py (Builder._detached): clear the
5259 self.currentBuild reference, otherwise the next build will be
5260 skipped because we think the Builder is already in use.
5262 * docs/examples/twisted_master.cfg: update to match current usage
5263 on the Twisted buildbot
5265 2004-10-29 Brian Warner <warner@lothar.com>
5267 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5269 2004-10-28 Brian Warner <warner@lothar.com>
5271 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5272 have separate doVCUpdate/doVCFull methods. Catch an update failure
5273 and respond by clobbering the source directory and re-trying. This
5274 will handle local changes (like replacing a file with a directory)
5275 that will cause CVS and SVN updates to fail.
5276 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5278 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5279 python-2.4 warning
5281 2004-10-19 Brian Warner <warner@lothar.com>
5283 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5285 * buildbot/status/html.py (StatusResourceTestResults): display any
5286 TestResults that the Build might have
5287 (StatusResourceTestResult): and the logs for each TestResult
5288 (StatusResourceBuild): add link from the per-build page
5290 2004-10-15 Brian Warner <warner@lothar.com>
5292 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5293 the 'problems' portion of stdout, add TestResults to our build
5294 * buildbot/test/test_twisted.py (Parse.testParse): test it
5296 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5297 to retrieve a dict of accumulated test results
5298 (ITestResult): define what a single test result can do
5299 * buildbot/status/builder.py (TestResult): implement ITestResult
5300 (BuildStatus.getTestResults): retrieve dict of TestResults
5301 (BuildStatus.addTestResult): add TestResults
5302 * buildbot/test/test_status.py (Results.testAddResults): test it
5304 2004-10-14 Brian Warner <warner@lothar.com>
5306 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5307 instead of os.system("rm -rf") for win32 portability
5309 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5310 SignalMixin instead of starting/stopping the reactor, which is
5311 likely to cause problems with other tests
5313 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5314 self.copyComplete() call. Yoz Grahame makes the catch.
5316 * contrib/windows/buildbot.bat: helper script to deal with path
5317 issues. Thanks to Yoz Grahame.
5319 * buildbot/master.py (BuildMaster.startService): don't register a
5320 SIGHUP handler if the signal module has no SIGHUP attribute.
5321 Apparently win32 does this.
5323 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5325 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5326 test if the reactor can't offer UNIX sockets
5328 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5329 error introduced in the last commit. We really need that
5330 metabuildbot :).
5332 2004-10-12 Brian Warner <warner@lothar.com>
5334 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5335 when describing a maildir source. Thanks to Stephen Davis.
5337 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5338 ETA seconds
5340 * buildbot/scripts/runner.py (createMaster): install Makefile too
5341 (start): add --no_save to 'start' command
5342 * buildbot/scripts/sample.mk: simple convenience Makefile with
5343 start/stop/reload targets
5345 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5346 releases
5348 2004-09-30 Brian Warner <warner@lothar.com>
5350 * setup.py: Releasing buildbot-0.6.0
5352 2004-09-30 Brian Warner <warner@lothar.com>
5354 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5355 test_trial.py from the source tarball until support is complete.
5357 * NEWS: update for 0.6.0 release
5358 * buildbot/__init__.py (version): same
5359 * README: same
5361 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5362 'source' command to tell users where to get the Buildbot source
5364 * docs/examples/*.cfg: update to modern standards
5366 * NEWS: update for release
5368 * buildbot/scripts/runner.py (createMaster): remove the
5369 -shutdown.tap stuff now that it isn't necessary
5370 (createSlave): same
5371 (start): launch buildbot.tap, not buildbot-shutdown.tap
5374 * buildbot/status/mail.py (Domain): shorten class name
5375 (MailNotifier): if lookup= is a string, pass it to Domain()
5376 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5377 (Mail.testBuild2): test the string-to-Domain shortcut
5378 (Mail.testMail): fix test
5381 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5382 example config file
5384 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5385 more attributes on load
5386 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5387 to accomodate the whole waterfall page at once, and the thrashing
5388 results in a lot of unnecessary loads
5389 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5390 (BuilderStatus.saveYourself): same
5391 (BuilderStatus.eventGenerator): stop generating on the first missing
5392 build. We assume that saved builds are deleted oldest-first.
5393 (BuildStepStatus.__getstate__): .progress might not exist
5395 * buildbot/changes/changes.py (ChangeMaster): make it
5396 serializable, in $masterdir/changes.pck
5397 (ChangeMaster.stopService): save on shutdown
5398 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5399 * buildbot/test/test_config.py: load Changes before config file
5402 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5403 "Oh my god, you killed the command" header on a separate line
5405 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5406 skip over corrupted build pickles
5407 (BuilderStatus.getFullBuildByNumber): same
5408 (BuilderStatus.eventGenerator): skip over unavailable builds
5409 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5410 do an atomic rename. This prevents a corrupted pickle when some
5411 internal serialization error occurs.
5412 (BuilderStatus.saveYourself): same
5414 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5415 the timeout for shell commands, it got lost somehow
5417 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5418 run out of build steps, return the rest of the builder events
5420 * buildbot/interfaces.py (IBuilderControl.ping): add method
5422 * buildbot/process/builder.py (BuilderControl.ping): move
5423 slave-ping to BuilderControl, and fix the failure case in the
5424 process (Event.finish() is the verb, Event.finished is the noun).
5426 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5427 through the BuilderControl instead of the BuilderStatus
5428 (EventBox): add adapter for builder.Event, allowing builder events to
5429 be displayed in the waterfall display
5431 * buildbot/master.py (BotMaster.stopService): add a 'master
5432 shutdown' event to the builder's log
5433 (BuildMaster.startService): and a 'master started' on startup
5435 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5436 builder events into the BuildStep event stream
5437 (Status.builderAdded): add a 'builder created' event
5440 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5441 command to announce the completion of a running build
5442 (IrcStatusBot.command_FORCE): announce when the build finishes
5444 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5445 don't evict unfinished builds from the cache: they must stay in
5446 the full-cache until their logfiles have stopped changing. Make
5447 sure the eviction loop terminates if an unfinished build was hit.
5448 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5449 This lets exceptions be dumped in an email status message. Really
5450 we need LogFiles which contain both text and HTML, instead of two
5451 separate classes.
5452 (BuildStatus.__getstate__): handle self.finished=False
5453 (Status.builderAdded): if the pickle is corrupted, abandon the
5454 history and create a new BuilderStatus object.
5456 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5457 self.progress attribute, helped one test which doesn't fully set
5458 up the Build object.
5460 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5461 IStatusLog methods into an Interface that is implemented by "stub"
5462 logs, for which all the actual text chunks are on disk (in the
5463 pickled Build instance). To show the log contents, you must first
5464 adapt the stub log to a full IStatusLog object.
5466 * buildbot/status/builder.py (LogFileStub): create separate stub
5467 log objects, which can be upgraded to a real one if necessary.
5468 (LogFile): make them persistable, and let them stubify themselves
5469 (HTMLLogFile): same
5470 (BuildStepStatus): same
5471 (BuildStatus): same
5472 (BuildStatus.saveYourself): save the whole build out to disk
5473 (BuilderStatus): make it persistable
5474 (BuilderStatus.saveYourself): save the builder to disk
5475 (BuilderStatus.addFullBuildToCache): implement two caches which
5476 hold Build objects: a small one which holds full Builds, and a
5477 larger one which holds "stubbed" Builds (ones with their LogFiles
5478 turned into LogFileStubs). This reduces memory usage by the
5479 buildmaster by not keeping more than a few (default is 2) whole
5480 build logs in RAM all the time.
5481 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5482 cache)
5483 (BuilderStatus.eventGenerator): rewrite since .builds went away
5484 (BuilderStatus.buildStarted): remove the .builds array. Add the
5485 build to the "full" cache when it starts.
5486 (BuilderStatus._buildFinished): save the build to disk when it
5487 finishes
5488 (Status): give it a basedir (same as the BuildMaster's basedir)
5489 where the builder pickles can be saved
5490 (Status.builderAdded): create the BuilderStatus ourselves, by
5491 loading a pickle from disk (or creating a new instance if there
5492 was none on disk). Return the BuilderStatus so the master can glue
5493 it into the new Builder object.
5495 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5496 all BuilderStatuses to save themselves out to disk. This is in
5497 lieu of saving anything important in the main Application pickle
5498 (the -shutdown.tap file).
5499 (BuildMaster.__init__): give Status() a basedir for its files
5500 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5501 to get the BuilderStatus, then give it to the Builder (instead of
5502 doing it the other way around). It's ok if the status announces
5503 the new Builder before it's really ready, as the outside world can
5504 only see the BuilderStatus object anyway (and it is ready before
5505 builderAdded returns). Use the builder's "builddir" (which
5506 normally specifies where the slave will run the builder) as the
5507 master's basedir (for saving serialized builds).
5509 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5510 coerce the logfile to IStatusLog before trying to get the text
5511 chunks out of it. This will pull the full (non-stubified) Build in
5512 from disk if necessary.
5513 (TextLog): fix the adapter registration
5515 * buildbot/test/test_control.py (Force.setUp): create the basedir
5516 * buildbot/test/test_web.py: same
5517 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5518 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5519 * buildbot/test/test_run.py (Run.testMaster): same
5520 (Status.setUp): same
5522 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5524 * buildbot/status/html.py (Waterfall.__init__): store actual
5525 allowForce flag passed in rather than using True for everyone;
5526 make sure setting it to False doesn't cause a NameError
5527 (Waterfall.setup).
5528 (StatusResourceBuilder.__init__) add the builder name to the page
5529 title.
5530 (StatusResourceBuilder.body) move HTML generation for a name/value
5531 row into a helper method (StatusResourceBuilder.make_row); only
5532 generate the "Force Build" form if allowForce was True and the
5533 slave is connected. Use class attributes in the generated HTML to
5534 spread a little CSS-joy.
5536 2004-09-28 Brian Warner <warner@lothar.com>
5538 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5539 warning-scanner to not ignore things like
5540 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5542 * buildbot/status/html.py (StatusResource.control): add some
5543 class-level values for .control in an attempt to make upgrading
5544 smoother
5546 * buildbot/util.py (ComparableMixin): survive missing attributes,
5547 such as when a class is modified and we're comparing old instances
5548 against new ones
5550 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5551 failure handling, remove a redundant try/except block. Don't
5552 return the full traceback to the IRC channel.
5553 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5554 error messages. Get ETA properly.
5556 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5557 the reason, since (at least) IRC message will have <> in them.
5558 (StatusResourceBuilder.__init__): take an IBuilderControl
5559 (StatusResourceBuilder.force): use the IBuilderControl we get in
5560 the constructor instead of trying to make our own. Catch the
5561 new exceptions and ignore them for now (until we make an
5562 intermediate web page where we could show the error message)
5563 (StatusResource): create with an IControl, use it to give an
5564 IBuilderControl to all children
5565 (Waterfall): take an allowForce= option, pass an IControl object
5566 to StatusResource if it is True
5568 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5570 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5571 catch new exceptions and return string forms
5573 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5574 * buildbot/process/builder.py (Builder.forceBuild): raise them
5575 * buildbot/test/test_control.py (Force.testNoSlave): new test
5576 (Force.testBuilderInUse): same
5579 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5581 * buildbot/test/test_run.py: use IControl
5582 * buildbot/test/test_vc.py: same
5584 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5585 to use IControl. Still offline.
5586 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5588 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5589 who=None so periodic builds don't send out status mail
5590 (Builder.forceBuild): include reason in the log message
5591 (BuilderControl.forceBuild): rename 'name' to 'who'
5593 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5594 'who' parameter, but make it None by default so builds forced by
5595 slave admins don't cause status mail to be sent to anybody
5596 (BotMaster.forceBuild): same. this method is deprecated.
5597 (DebugPerspective.perspective_forceBuild): same, use IControl.
5598 (DebugPerspective.perspective_fakeChange): use IControl..
5599 (Dispatcher.requestAvatar): .. so don't set .changemaster
5601 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5602 parameter to avoid confusion with the name of the builder
5605 * buildbot/status/mail.py: refine comment about needing 2.3
5607 * buildbot/status/html.py: move all imports to the top
5609 * buildbot/test/test_control.py: test new interfaces
5610 * buildbot/test/test_run.py (Status): handle new interfaces
5611 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5613 * buildbot/process/base.py (BuildControl): implement IBuildControl
5614 and its lonely getStatus() method
5616 * buildbot/process/builder.py (BuilderControl): implement
5617 IBuilderControl, obtained by adapting the Builder instance
5618 (Builder.startBuild): return a BuilderControl instead of a
5619 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5620 accomplish the same thing.
5622 * buildbot/master.py: move all import statements to the top
5623 (Control): implement IControl, obtained by adapting the
5624 BuildMaster instance.
5626 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5627 IBuildControl. These are used to force builds. Eventually they
5628 will provide ways to reconfigure the Builders, pause or abandon a
5629 Build, and perhaps control the BuildMaster itself.
5631 2004-09-26 Brian Warner <warner@lothar.com>
5633 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5634 ends up comparing us against something without a .__class__
5636 2004-09-24 Brian Warner <warner@lothar.com>
5638 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5639 usage text right.
5641 * Makefile: add 'deb-snapshot' target, to create a timestamped
5642 .deb package
5644 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5646 2004-09-23 Brian Warner <warner@lothar.com>
5648 * buildbot/__init__.py (version): move version string here
5649 * setup.py: get version string from buildbot.version
5650 * buildbot/status/html.py (WaterfallStatusResource.body): add
5651 buildbot version to the page footer
5652 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5653 version when asked
5655 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5656 slaves, let the second know where the first one is coming from
5657 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5658 see our exceptions. It would be nice if there were a way to just
5659 send them the exception type and value, not the full traceback.
5662 * buildbot/status/mail.py (MailNotifier): add a new argument
5663 sendToInterestedUsers=, which can be set to False to disable the
5664 usual send-to-blamelist behavior.
5665 (top): handle python-2.2 which has no email.MIMEMultipart
5666 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5667 (MailNotifier.disownServiceParent): unsubscribe on removal
5669 * buildbot/test/test_status.py (Mail.testBuild2): test it
5672 * buildbot/status/progress.py (Expectations.wavg): tolerate
5673 current=None, which happens when steps start failing badly
5674 * buildbot/test/test_status.py (Progress.testWavg): test for it
5676 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5677 doesn't understand args['revision'], emit a warning instead of
5678 bailing completely. Updating to -rHEAD is probably close enough.
5680 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5682 * buildbot/test/test_status.py: at least import bb.status.client
5683 even if we don't have any test coverage for it yet
5685 * contrib/svn_buildbot.py: don't require python2.3
5686 (main): wait, do require it (for sets.py), but explain how to
5687 make it work under python2.2
5689 2004-09-23 Brian Warner <warner@lothar.com>
5691 * contrib/svn_buildbot.py: include the revision number in the Change
5693 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5694 using util.now() because FreshCVS is a realtime service
5696 * buildbot/status/event.py: delete dead code
5697 * buildbot/process/step.py: don't import dead Event class
5698 * buildbot/process/step_twisted.py: same
5699 * buildbot/status/builder.py: same
5700 * buildbot/status/client.py: same
5702 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5704 * buildbot/changes/changes.py (Change): set .when from an __init__
5705 argument (which defaults to now()), rather than having
5706 ChangeMaster.addChange set it later.
5707 (ChangeMaster.addChange): same
5709 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5710 (parseSyncmail): same. Just use util.now() for now.
5711 (parseBonsaiMail): parse the timestamp field for when=
5713 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5714 instead of setting .when after the fact
5716 2004-09-22 slyphon
5718 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5719 results when the target project uses retrial. Still under
5720 development.
5721 * buildbot/test/test_trial.py: same
5723 2004-09-21 Brian Warner <warner@lothar.com>
5725 * buildbot/status/mail.py (MailNotifier.__init__): include
5726 success/warnings/failure in the Subject line
5727 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5728 use step.logname for the addLogs=True attachment filenames
5729 * buildbot/test/test_status.py (Mail): test Subject lines
5730 (Mail.testLogs): test attachment filenames
5732 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5733 accept a 'who' argument from the debug tool
5734 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5735 * contrib/debug.glade: add text box to set 'who'
5737 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5738 .getBuilderName with .getBuilder().getName(), more flexible
5739 (IStatusLog.getName): logs have short names, but you can prefix
5740 them with log.getStep().getName() to make them more useful
5741 * buildbot/status/builder.py: same
5742 * buildbot/status/client.py: same
5743 * buildbot/status/html.py: same
5744 * buildbot/test/test_run.py (Status.testSlave): same
5745 * buildbot/process/step.py: tweak logfile names
5747 * buildbot/status/mail.py (MailNotifier): add lookup, change
5748 argument to extraRecipients. The notifier is now aimed at sending
5749 mail to the people involved in a particular build, with additional
5750 constant recipients as a secondary function.
5752 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5753 including slow-lookup and failing-lookup. Make sure the blamelist
5754 members are included.
5756 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5757 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5758 (IBuildStatus.getInterestedUsers): new method
5759 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5760 * buildbot/status/client.py (remote_getResponsibleUsers): same
5761 * buildbot/status/html.py (StatusResourceBuild.body): same
5762 * buildbot/test/test_run.py (Status.testSlave): same
5764 2004-09-20 Brian Warner <warner@lothar.com>
5766 * docs/users.xhtml: update concepts
5768 * Makefile: add a convenience makefile, for things like 'make
5769 test'. It is not included in the source tarball.
5771 2004-09-16 Brian Warner <warner@lothar.com>
5773 * NEWS: mention /usr/bin/buildbot, debian/*
5775 * debian/*: add preliminary debian packaging. Many thanks to
5776 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5777 it considerably since it left their hands, I am responsible for
5778 all breakage that's resulted.
5780 * bin/buildbot: create a top-level 'buildbot' command, to be
5781 installed in /usr/bin/buildbot . For now it's just a simple
5782 frontend to mktap/twistd/kill, but eventually it will be the entry
5783 point to the 'try' command and also a status client. It is also
5784 intended to support the upcoming debian-packaging init.d scripts.
5785 * buildbot/scripts/runner.py: the real work is done here
5786 * buildbot/scripts/__init__.py: need this too
5787 * buildbot/scripts/sample.cfg: this is installed in new
5788 buildmaster directories
5789 * setup.py: install new stuff
5791 2004-09-15 Brian Warner <warner@lothar.com>
5793 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5794 'file:' schema (the version shipped with OS-X was built without the
5795 ra_local plugin).
5796 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5797 updates the log-timestamp, to make sure it isn't still running after
5798 the test finishes
5800 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5801 values to the config file.
5802 * docs/examples/hello.cfg: add examples
5803 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5804 * buildbot/status/builder.py (Status.getProjectURL): implement them
5805 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5806 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5807 * buildbot/status/html.py (WaterfallStatusResource): display them
5810 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5811 certain error cases don't suffer a secondary exception.
5812 (top): Skip tests if the corresponding VC tool is not installed.
5814 * buildbot/process/factory.py (Trial): introduce separate
5815 'buildpython' and 'trialpython' lists, since trialpython=[] is
5816 what you want to invoke /usr/bin/python, whereas ./setup.py is
5817 less likely to be executable. Add env= parameter to pass options
5818 to test cases (which is how I usually write tests, I don't know if
5819 anyone else does it this way).
5821 * buildbot/process/step_twisted.py (Trial): handle python=None.
5822 Require 'testpath' be a string, not a list. Fix tests= typo.
5823 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5825 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5826 way to deal with the possibility of removing the disconnect notify
5827 twice.
5828 (CVS): add a 'login' parameter to give a password to 'cvs login',
5829 commonly used with pserver methods (where pw="" or pw="guest")
5831 * buildbot/slave/commands.py (SourceBase): move common args
5832 extraction and setup() to __init__, so everything is ready by the
5833 time setup() is called
5834 (CVS.start): call 'cvs login' if a password was supplied
5835 (ShellCommand): special-case PYTHONPATH: prepend the master's
5836 value to any existing slave-local value.
5838 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5839 don't have a remote, mark the builder as Offline. This whole
5840 function should probably go away and be replaced by individual
5841 deltas.
5842 (Builder.buildFinished): return the results to the build-finished
5843 deferred callback, helps with testing
5845 2004-09-14 Brian Warner <warner@lothar.com>
5847 * buildbot/test/test_vc.py: put all the repositories needed to run
5848 the complete tests into a single small (1.3MB) tarball, so I can
5849 make that tarball available on the buildbot web site. Test HTTP
5850 access (for Arch and Darcs) by spawning a temporary web server
5851 while the test runs.
5853 * docs/users.xhtml: new document, describe Buildbot's limited
5854 understanding of different human users
5856 * buildbot/test/test_vc.py: rearrange test cases a bit
5858 * buildbot/process/step_twisted.py (Trial): handle testpath=
5859 * buildbot/process/factory.py (Trial): update to use step.Trial
5861 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5863 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5864 the overall build text (which gives you 'failed 2 tests' rather
5865 than just 'failed')
5866 (BuildStepStatus.text2): default to [], not None
5868 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5869 must be a list
5871 2004-09-12 Brian Warner <warner@lothar.com>
5873 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5874 log the whole exception if it's just an AttributeError (old slave)
5876 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5877 so (e.g.) sub-commands can be run in the right directory.
5878 (ShellCommand.start): accept an optional errorMessage= argument
5879 to make life easier for SVN.start
5880 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5881 headers
5882 (ShellCommand.start): move ['dir'] compatibility hack..
5883 (RemoteShellCommand.start): .. to here so everyone can use it
5885 * buildbot/process/step_twisted.py (Trial): use .workdir
5887 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5888 text displayed when debuild fails completely
5889 (Trial): snarf _trial_temp/test.log from the slave and display it
5891 2004-09-11 Brian Warner <warner@lothar.com>
5893 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5895 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5896 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5898 * buildbot/process/step.py (ShellCommand): call .createSummary
5899 before .evaluateCommand instead of the other way around. This
5900 makes it slightly easier to count warnings and then use that to
5901 set results=WARNINGS
5902 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5904 * buildbot/process/base.py (Build.buildFinished): update status
5905 before doing progress. It's embarrassing for the build to be stuck
5906 in the "building" state when an exceptions occurs elsewhere..
5908 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5909 python2.2 doesn't have 'sum'
5911 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5912 to prevent clients from accidentally sorting it
5914 * buildbot/master.py (Manhole): add username/password
5915 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5916 c['manholePort'], deprecate old usage
5917 * docs/config.xhtml: document c['manhole']
5918 * docs/examples/hello.cfg: show example of using a Manhole
5921 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5922 pretend the slave is up to date
5924 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5925 the module, overlaps with 'log', the local variable
5927 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5929 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5930 new method to let Steps find out the version of their
5931 corresponding SlaveCommand.
5932 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5933 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5934 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5935 (SVN.startVC): same
5936 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5937 (Arch.startVC): same
5938 (P4Sync.startVC): same
5940 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5941 Deferred so we can catch errors in remote_startCommand
5942 (RemoteShellCommand.start): same
5944 * docs/examples/twisted_master.cfg: update sample config file
5946 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5947 after connectionMade() is called, not before. Close stdin at that
5948 point too.
5950 * buildbot/process/process_twisted.py: update to use Trial, clean
5951 up argument passing (move to argv arrays instead of string
5952 commands)
5954 * buildbot/process/step_twisted.py (Trial): new step to replace
5955 RunUnitTests, usable by any trial-using project (not just
5956 Twisted). Arguments have changed, see the docstring for details.
5958 * buildbot/process/base.py (Build.startBuild): this now returns a
5959 Deferred. Exceptions that occur during setupBuild are now
5960 caught better and lead to fewer build_status weirdnesses, like
5961 finishing a build that was never started.
5962 (Build.buildFinished): fire the Deferred instead of calling
5963 builder.buildFinished directly. The callback argument is this
5964 Build, everything else can be extracted from it, including the
5965 new build.results attribute.
5966 * buildbot/process/builder.py (Builder.startBuild): same
5967 (Builder.buildFinished): same, extract results from build
5969 * buildbot/process/step.py (ShellCommands): remove dead code
5971 2004-09-08 Brian Warner <warner@lothar.com>
5973 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5974 doesn't try to use the leftover patched workdir
5975 (SourceStamp): test source-stamp computation for CVS and SVN
5977 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5978 patched workdir ('touch .buildbot-patched') so we don't try to
5979 update it later
5980 (SourceBase.start): add ['revision'] for all Source steps
5981 (CVS): change args: use ['branch'] for -r, remove ['files']
5982 (CVS.buildVC): fix revision/branch stuff
5983 (SVN): add revision stuff
5985 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5986 kwargs (except 'workdir') to avoid silent spelling errors
5987 (ShellCommand.__init__): same
5988 (Source): new base class for CVS/SVN/etc. Factor out everything
5989 common, add revision computation (perform the checkout with a -D
5990 DATE or -r REVISION that gets exactly the sources described by the
5991 last Change), overridable with step.alwaysUseLatest. Add patch
5992 handling (build.getSourceStamp can trigger the use of a base
5993 revision and a patch).
5994 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5995 * docs/steps.xhtml: update docs
5996 * docs/source.xhtml: mention .checkoutDelay
5997 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5999 * buildbot/process/base.py (Build.setSourceStamp): add a
6000 .sourceStamp attribute to each Build. If set, this indicates that
6001 the build should be done with something other than the most
6002 recent source tree. This will be used to implement "try" builds.
6003 (Build.allChanges): new support method
6004 (Build.lastChangeTime): remove, functionality moved to Source steps
6005 (Build.setupBuild): copy the Step args before adding ['workdir'],
6006 to avoid modifying the BuildFactory (and thus triggering spurious
6007 config changes)
6010 * buildbot/status/html.py: rename s/commits/changes/
6011 (StatusResourceChanges): same
6012 (CommitBox.getBox): same, update URL
6013 (WaterfallStatusResource): same
6014 (StatusResource.getChild): same
6016 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6017 * contrib/debug.glade: add optional 'revision' to the fakeChange
6019 * buildbot/changes/changes.py (html_tmpl): display .revision
6020 (ChangeMaster.addChange): note .revision in log
6021 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6022 accept a ['revision'] attribute
6024 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6026 * buildbot/master.py (BotMaster.getPerspective): update the
6027 .connected flag in SlaveStatus when it connects
6028 (BotMaster.detach): and when it disconnects
6029 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6030 (BuildMaster.loadConfig_Builders): walk old list correctly
6032 * buildbot/test/test_config.py: fix prefix= usage
6034 2004-09-06 Brian Warner <warner@lothar.com>
6036 * NEWS: mention P4
6038 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6039 poll a P4 depot looking for recent changes. Thanks to Dave
6040 Peticolas for the contribution. Probably needs some testing after
6041 I mangled it.
6043 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6044 requires manual client setup for each buildslave. Rather
6045 experimental. Thanks again to Dave Peticolas.
6046 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6048 * buildbot/changes/changes.py (Change): add a .revision attribute,
6049 which will eventually be used to generate source-stamp values.
6051 * buildbot/process/step.py (RemoteCommand.start): use
6052 notifyOnDisconnect to notice when we lose the slave, then treat it
6053 like an exception. This allows LogFiles to be closed and the build
6054 to be wrapped up normally. Be sure to remove the disconnect
6055 notification when the step completes so we don't accumulate a
6056 bazillion such notifications which will fire weeks later (when the
6057 slave finally disconnects normally). Fixes SF#915807, thanks to
6058 spiv (Andrew Bennetts) for the report.
6059 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6060 really isn't Logged- specific
6061 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6062 header, since it's almost always going to be appended to an
6063 incomplete line
6064 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6065 update test to handle use of notifyOnDisconnect
6067 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6068 don't clear .ETA and .currentBuild when going offline, let the
6069 current build clean up after itself
6071 * buildbot/process/builder.py (Builder.detached): wait a moment
6072 before doing things like stopping the current build, because the
6073 current step will probably notice the disconnect and cleanup the
6074 build by itself
6075 * buildbot/test/test_run.py (Status.tearDown): update test to
6076 handle asynchronous build-detachment
6078 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6080 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6081 hush a debug message
6083 2004-09-05 Brian Warner <warner@lothar.com>
6085 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6086 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6087 kernels do this: the fcntl module has the F_NOTIFY constant, but
6088 the kernel itself doesn't support the operation. Thanks to Olly
6089 Betts for spotting the problem.
6091 * buildbot/process/step.py (Darcs): new source-checkout command
6092 (Arch): new source-checkout command
6093 (todo_P4): fix constructor syntax, still just a placeholder
6094 * buildbot/test/test_vc.py (VC.testDarcs): test it
6095 (VC.testDarcsHTTP): same, via localhost HTTP
6096 (VC.testArch): same
6097 (VC.testArchHTTP): same
6098 * NEWS: mention new features
6100 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6101 which tells the step to stash stdout text locally (in .stdout).
6102 Slave-side Commands can use this to make decisions based upon the
6103 output of the the ShellCommand (not just the exit code).
6104 (Darcs): New source-checkout command
6105 (Arch): New source-checkout command, uses .keepStdout in one place
6106 where it needs to discover the archive's default name.
6108 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6109 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6110 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6112 * buildbot/process/step.py (ShellCommand.describe): add an
6113 alternate .descriptionDone attribute which provides descriptive
6114 text when the step is complete. .description can be ["compiling"],
6115 for use while the step is running, then .descriptionDone can be
6116 ["compile"], used alone when the step succeeds or with "failed" when
6117 it does not. Updated other steps to use the new text.
6118 * buildbot/process/step_twisted.py: same
6119 * buildbot/test/test_run.py: update tests to match
6121 2004-08-30 Brian Warner <warner@lothar.com>
6123 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6124 (CVS.__init__): send 'patch' argument to slave
6125 (CVS.start): don't create the LoggedRemoteCommand until start(),
6126 so we can catch a .patch added after __init__
6127 (SVN.__init__): add 'patch' to SVN too
6128 (SVN.start): same
6130 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6131 argument, to let commands push data into the process' stdin pipe.
6132 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6133 is in use, since closing a PTY doesn't really affect the process
6134 in the right way (in particular, I couldn't run /usr/bin/patch
6135 under a pty).
6136 (SourceBase.doPatch): handle 'patch' argument
6138 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6139 both CVS and SVN
6141 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6142 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6143 versions to master
6144 * buildbot/master.py (BotPerspective.got_commands): get command
6145 versions from slave, give to each builder
6146 * buildbot/process/builder.py (Builder.attached): stash slave
6147 command versions in .remoteCommands
6149 * docs/steps.xhtml: bring docs in-line with reality
6151 * buildbot/process/step.py (CVS.__init__): more brutal
6152 compatibility code removal
6153 (SVN.__init__): same
6155 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6156 (SlaveShellCommand.start): require ['workdir'] argument, remove
6157 the ['dir'] fallback (compatibility will come later)
6158 (SourceBase): update docs
6159 (SourceBase.start): remove ['directory'] fallback
6160 (CVS): update docs
6161 (SVN): update docs
6162 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6163 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6164 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6166 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6167 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6168 code.. I will figure out 0.5.0-compatibility hooks later)
6170 2004-08-30 Brian Warner <warner@lothar.com>
6172 * buildbot/process/process_twisted.py: rewrite in terms of new
6173 BuildFactory base class. It got significantly shorter. Yay
6174 negative code days.
6176 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6177 work with the new "self.build isn't nailed down until we call
6178 step.start()" scheme: specifically, __init__ is called before the
6179 build has decided on which Changes are going in, so we don't scan
6180 build.allFiles() for .xhtml files until start()
6181 (HLint.commandComplete): use getText(), not getStdout()
6182 (RunUnitTests.start): same: don't use .build until start()
6183 (RunUnitTests.describe): oops, don't report (None) when using
6184 the default reactor
6185 (RunUnitTests.commandComplete): use getText()
6186 (RunUnitTests.createSummary): same
6187 (BuildDebs.commandComplete): same
6189 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6190 set args['command'] until start(), since our BuildStep is allowed
6191 to change their mind up until that point
6192 (TreeSize.commandComplete): use getText(), not getStdout()
6194 * docs/examples/twisted_master.cfg: update to current standards
6196 * docs/factories.xhtml: update
6197 * buildbot/process/factory.py: implement all the common factories
6198 described in the docs. The Trial factory doesn't work yet, and
6199 I've probably broken all the process_twisted.py factories in the
6200 process. There are compatibility classes left in for things like
6201 the old BasicBuildFactory, but subclasses of them are unlikely to
6202 work.
6203 * docs/examples/glib_master.cfg: use new BuildFactories
6204 * docs/examples/hello.cfg: same
6206 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6207 explicit 'workdir' args
6209 * buildbot/process/base.py (BuildFactory): move factories to ..
6210 * buildbot/process/factory.py (BuildFactory): .. here
6211 * buildbot/process/process_twisted.py: handle move
6212 * buildbot/test/test_config.py: same
6213 * buildbot/test/test_run.py: same
6214 * buildbot/test/test_steps.py: same
6215 * buildbot/test/test_vc.py: same
6216 * docs/factories.xhtml: same
6218 * NEWS: mention config changes that require updating master.cfg
6220 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6221 argument to all steps that weren't given one already, pointing at
6222 the "build/" directory.
6224 * docs/examples/hello.cfg: remove explicit 'workdir' args
6226 * docs/factories.xhtml: document standard BuildFactory clases,
6227 including a bunch which are have not yet been written
6229 2004-08-29 Brian Warner <warner@lothar.com>
6231 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6232 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6233 buildbot.status.builder so they aren't quite so internal
6234 * buildbot/process/base.py, buildbot/process/builder.py: same
6235 * buildbot/process/maxq.py, buildbot/process/step.py: same
6236 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6237 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6238 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6240 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6241 to handle new getLogs()-returns-list behavior
6242 (StatusResourceBuildStep.getChild): same
6243 (StepBox.getBox): same
6244 (WaterfallStatusResource.phase0): same
6246 * docs/source.xhtml: document how Buildbot uses version-control
6247 systems (output side: how we get source trees)
6248 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6249 systems (input side: how we learn about Changes)
6251 * buildbot/master.py (Manhole): use ComparableMixin
6252 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6253 * buildbot/changes/mail.py (MaildirSource): same
6254 * buildbot/status/client.py (PBListener): same
6255 * buildbot/status/html.py (Waterfall): same
6256 * buildbot/status/words.py (IRC): same
6258 * NEWS: start describing new features
6260 * buildbot/status/mail.py (MailNotifier): finish implementation.
6261 The message body is still a bit sparse.
6262 * buildbot/test/test_status.py (Mail): test it
6264 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6265 and __hash__ methods I wind up adding everywhere. Specifically
6266 intended to support the buildbot config-file update scheme where
6267 we compare, say, the old list of IStatusTargets against the new
6268 one and don't touch something which shows up on both lists.
6269 * buildbot/test/test_util.py (Compare): test case for it
6271 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6272 return a list instead of a dict
6273 (IBuildStepStatus.getLogs): same. The idea is that steps create
6274 logs with vaguely unique names (although their uniqueness is not
6275 guaranteed). Thus a compilation step should create its sole
6276 logfile with the name 'compile', and contribute it to the
6277 BuildStatus. If a step has two logfiles, try to create them with
6278 different names (like 'test.log' and 'test.summary'), and only
6279 contribute the important ones to the overall BuildStatus.
6280 * buildbot/status/builder.py (Event.getLogs): same
6281 (BuildStepStatus): fix default .text and .results
6282 (BuildStepStatus.addLog): switch to list-like .getLogs()
6283 (BuildStepStatus.stepFinished): same
6284 (BuildStatus.text): fix default .text
6285 (BuildStatus.getLogs): temporary hack to return all logs (from all
6286 child BuildStepStatus objects). Needs to be fixed to only report
6287 the significant ones (as contributed by the steps themselves)
6288 * buildbot/test/test_run.py: handle list-like .getLogs()
6289 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6291 2004-08-28 Brian Warner <warner@lothar.com>
6293 * buildbot/process/builder.py (Builder.attached): serialize the
6294 attachment process, so the attach-watcher isn't called until the
6295 slave is really available. Add detached watchers too, which makes
6296 testing easier.
6298 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6300 * buildbot/test/test_swap.py: remove dead code
6302 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6303 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6304 sort of as if the command being run exited with a -1. There may
6305 still be some holes in this scheme.
6306 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6307 -r option appears before the module list
6308 * buildbot/process/step.py (CVS): add 'revision' argument
6310 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6311 when sending updates or stepComplete messages to the master, since
6312 we don't currently care whether they arrive or not. When we revamp
6313 the master/slave protocol to really resume interrupted builds,
6314 this will need revisiting.
6315 (lostRemote): remove spurious print
6317 * buildbot/master.py (BotPerspective.attached): serialize the
6318 new-builder interrogation process, to make testing easier
6319 (BotMaster.waitUntilBuilderDetached): convenience function
6321 * buildbot/status/builder.py (BuilderStatus): prune old builds
6322 (BuildStatus.pruneSteps): .. and steps
6323 (BuildStepStatus.pruneLogs): .. and logs
6324 (BuilderStatus.getBuild): handle missing builds
6325 * buildbot/status/html.py (StatusResourceBuild.body): display build
6326 status in the per-build page
6327 (BuildBox.getBox): color finished builds in the per-build box
6329 2004-08-27 Brian Warner <warner@lothar.com>
6331 * buildbot/status/mail.py (MailNotifier): new notification class,
6332 not yet finished
6334 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6335 variants of a common base class which handles all the mode= logic
6337 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6338 convenience method
6339 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6341 2004-08-26 Brian Warner <warner@lothar.com>
6343 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6344 interfaces
6346 * buildbot/test/test_run.py: update to new Logfile interface, new
6347 buildbot.slave modules
6348 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6350 * MANIFEST.in: new sample config file
6351 * docs/examples/hello.cfg: same
6353 * buildbot/process/step_twisted.py: remove dead import
6355 * buildbot/process/step.py (RemoteCommand.run): catch errors
6356 during .start
6357 (RemoteCommand.remote_update): ignore updates that arrive after
6358 we've shut down
6359 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6360 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6361 the responsibilities of the subclass's methods
6362 (BuildStep.failed): catch errors during failure processing
6363 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6364 (CVS): move to a mode= argument (described in docstring), rather
6365 than the ungainly clobber=/export=/copydir= combination.
6366 (SVN): add mode= functionality to SVN too
6367 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6369 * buildbot/process/base.py (Build.startNextStep): catch errors
6370 during s.startStep()
6372 * buildbot/clients/base.py: update to new PB client interface.
6373 gtkPanes is still broken
6375 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6376 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6377 * setup.py: add buildbot.slave module
6378 * buildbot/bb_tap.py: handle move
6379 * buildbot/slave/registry.py: place to register commands, w/versions
6380 * buildbot/slave/bot.py: major simplifications
6381 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6382 instead of a fixed table. Eventually this will make the slave more
6383 extensible. Use 'start' method on the command, not .startCommand.
6384 Fix unsafeTracebacks handling (I think).
6385 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6386 helper class with a .start method that returns a Deferred.
6387 SlaveShellCommand is the form reached by the buildmaster. Commands
6388 which use multiple ShellCommands can just chain them as Deferreds,
6389 with some helper methods in Command (_abandonOnFailure and
6390 _checkAbandoned) to bail on rc!=0.
6391 (CVSCommand): prefer new mode= argument
6392 (SVNFetch): add mode= argument
6394 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6395 put a useful reason string on the build
6397 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6398 core functionality into an IStatusLog object
6399 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6400 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6401 (StatusResourceBuild.body): use proper accessor methods
6402 * buildbot/status/client.py (RemoteLog): PB-access goes here
6403 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6404 which delivers log contents too
6405 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6406 * buildbot/status/event.py: remove old Logfile completely
6408 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6409 subscription interface for IStatusLog subscriptions just like all
6410 other the status subscriptions
6411 (IStatusReceiver.logChunk): method called on subscribers
6413 2004-08-24 Brian Warner <warner@lothar.com>
6415 * buildbot/process/builder.py (Builder._pong): oops, ping response
6416 includes a result (the implicit None returned by remote_print).
6417 Accept it so the _pong method handles the response correctly.
6419 2004-08-06 Brian Warner <warner@lothar.com>
6421 * buildbot/test/test_config.py: update IRC, PBListener tests
6423 * buildbot/status/client.py (StatusClientPerspective): total
6424 rewrite to match new IStatus interfaces. New subscription scheme.
6425 There are still a few optimizations to make (sending down extra
6426 information with event messages so the client doesn't have to do a
6427 round trip). The logfile-retrieval code is probably still broken.
6428 Moved the PB service into its own port, you can no longer share a
6429 TCP socket between a PBListener and, say, the slaveport (this
6430 should be fixed eventually).
6431 * buildbot/clients/base.py (Client): revamp to match. still needs
6432 a lot of work, but basic event reporting works fine. gtkPanes is
6433 completely broken.
6435 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6436 instance talks to a single irc server. Threw out all the old
6437 multi-server handling code. Still need to add back in
6438 builder-control (i.e. "force build")
6440 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6441 more random text to the as-yet-unreachable per-step page
6443 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6444 rename to stepETAUpdate
6445 (BuildStatus.subscribe): add build-wide ETA updates
6446 (BuilderStatus.getState): remove more cruft
6447 (BuilderStatus.getCurrentBuild): remove more cruft
6448 (BuilderStatus.buildStarted): really handle tuple-subscription
6449 * buildbot/test/test_run.py (Status.testSlave): handle the
6450 stepETAUpdate rename
6452 * buildbot/master.py (BuildMaster): don't add a default
6453 StatusClientService. Don't add a default IrcStatusFactory. Both
6454 are now added through c['status'] in the config file. c['irc'] is
6455 accepted for backwards compatibility, the only quirk is you cannot
6456 use c['irc'] to specify IRC servers on ports other than 6667.
6458 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6459 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6460 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6461 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6464 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6465 the buildmaster to re-read its config file
6468 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6469 find out the port our server is running on
6470 (WebTest.test_webPathname_port): same
6472 * buildbot/test/test_config.py (testWebPortnum): test it
6473 (testWebPathname): ditto
6475 * docs/config.xhtml: document new c['status'] configuration option
6477 * buildbot/status/html.py (Waterfall): new top-level class which
6478 can be added to c['status']. This creates the Site as well as the
6479 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6480 reachable as .parent, for everything.
6482 * buildbot/master.py (Manhole): make it a normal service Child
6483 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6484 webPathname. It will eventually replace c['irc'] and the implicit
6485 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6486 in as (deprecated) backward compatibility hooks for now.
6489 * buildbot/process/builder.py (Builder.buildFinished): don't
6490 inform out builder_status about a finished build, as it finds out
6491 through its child BuildStatus object
6493 * buildbot/status/html.py: extensive revamp. Use adapters to make
6494 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6495 have both starting and finishing times and adjust the waterfall
6496 display accordingly, using spacers if necessary. Use SlaveStatus
6497 to get buildslave info.
6498 (StatusResourceBuildStep): new just-one-step resource, used to get
6499 logfiles. No actual href to it yet.
6501 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6502 the time being, until I get the file-naming scheme right
6504 * buildbot/status/builder.py (Event): clean started/finished names
6505 (BuildStatus.isFinished): .finished is not None is the right test
6506 (BuildStatus.buildStarted): track started/finished times ourselves
6507 (BuilderStatus.getSlave): provide access to SlaveStatus object
6508 (BuilderStatus.getLastFinishedBuild): all builds are now in
6509 .builds, even the currently-running one. Accomodate this change.
6510 (BuilderStatus.eventGenerator): new per-builder event generator.
6511 Returns BuildStepStatus and BuildStatus objects, since they can
6512 both be adapted as necessary.
6513 (BuilderStatus.addEvent): clean up started/finished attributes
6514 (BuilderStatus.startBuild,finishBuild): remove dead code
6515 (SlaveStatus): new object to provide ISlaveStatus
6517 * buildbot/process/step.py (ShellCommand.getColor): actually
6518 return the color instead of setting it ourselves
6519 (CVS.__init__): pull .timeout and .workdir options out of
6520 **kwargs, since BuildStep will ignore them. Without this neither
6521 will be sent to the slave correctly.
6522 (SVN.__init__): same
6524 * buildbot/process/builder.py (Builder): move flags to class-level
6525 attributes
6526 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6527 SlaveStatus handle that
6529 * buildbot/process/base.py (Build.firstEvent): remove dead code
6530 (Build.stopBuild): bugfix
6532 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6534 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6535 (ChangeMaster.eventGenerator): yield Changes, since there are now
6536 Adapters to turn them into HTML boxes
6538 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6539 (BotPerspective.attached): feed a SlaveStatus object
6540 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6541 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6543 * buildbot/interfaces.py: API additions
6544 (ISlaveStatus): place to get slave status
6546 2004-08-04 Brian Warner <warner@lothar.com>
6548 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6549 the delay finishes, so the step is marked as SUCCESS
6551 * buildbot/test/test_run.py (Status.testSlave): cover more of
6552 IBuildStatus and IBuildStepStatus
6554 * buildbot/status/progress.py (StepProgress): move some flags to
6555 class-level attributes
6556 (StepProgress.remaining): if there are no other progress metrics
6557 to go by, fall back to elapsed time
6558 (StepProgress.setExpectations): take a dict of metrics instead of
6559 a list
6560 (BuildProgress.setExpectationsFrom): pull expectations from the
6561 Expectations, instead of having it push them to the BuildProgress
6562 (Expectations): move some flags to class-level attributes
6563 (Expectations.__init__): copy per-step times from the
6564 BuildProgress too
6565 (Expectations.expectedBuildTime): new method for per-build ETA
6567 * buildbot/status/event.py (Logfile): move some flags to
6568 class-level attributes
6569 (Logfile.logProgressTo): better method name, let step set the
6570 progress axis name (instead of always being "output")
6572 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6573 times directly, rather than depending upon the (possibly missing)
6574 .progress object. Use 'None' to indicate "not started/finished
6575 yet"
6576 (BuildStepStatus.getExpectations): oops, return the full list of
6577 expectations
6578 (BuilderStatus._buildFinished): append finished builds to .builds
6580 * buildbot/process/step.py (BuildStep): add separate .useProgress
6581 flag, since empty .progressMetrics[] still implies that time is a
6582 useful predictor
6583 (CVS): set up the cmd in __init__, instead of waiting for start()
6585 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6586 calculation, this will eventually turn into a proper sourceStamp
6587 (Build.setupBuild): tell the Progress to load from the Expectations,
6588 instead of having the Expectations stuff things into the Progress
6589 (Build.buildException): add a build-level errback to make sure the
6590 build's Deferred fires even in case of exceptions
6592 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6593 the forced build
6594 * buildbot/process/builder.py (Builder.forceBuild): convey the
6595 reason instead of creating a fake Change
6597 * docs/examples/twisted_master.cfg: update to match reality
6599 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6600 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6601 fix or remove broken/breaking tests
6603 * buildbot/status/event.py (Logfile.__len__): remove evil method
6605 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6606 missing .build, for test convenience
6608 * buildbot/process/step_twisted.py: import fixes
6610 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6612 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6613 .statusbag reference
6615 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6616 connection at shutdown, and stop it from reconnecting
6618 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6619 chase down remote-execution bugs
6621 * buildbot/process/step.py: more fixes, remove
6622 BuildStep.setStatus()
6623 * buildbot/status/builder.py: move setStatus() functionality into
6624 BuildStatus.addStep
6625 * buildbot/status/event.py: minor fixes
6627 2004-08-03 Brian Warner <warner@lothar.com>
6629 * buildbot/process/base.py, buildbot/process/builder.py
6630 * buildbot/process/step.py, buildbot/status/builder.py
6631 * buildbot/status/event.py, buildbot/test/test_run.py:
6632 fix status delivery, get a basic test case working
6633 * buildbot/master.py: finish implementing basic status delivery,
6634 temporarily disable HTML/IRC/PB status sources
6636 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6638 * buildbot/status/progress.py (BuildProgress): remove dead code
6640 * buildbot/interfaces.py
6641 * buildbot/process/base.py, buildbot/process/builder.py
6642 * buildbot/process/step.py, buildbot/process/step_twisted.py
6643 * buildbot/status/builder.py: Complete overhaul of the all
6644 status-delivery code, unifying all types of status clients (HTML,
6645 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6646 look like. This commit is a checkpointing of the work-in-progress:
6647 the input side is mostly done (Builders/Builds sending status
6648 to the BuilderStatus/BuildStatus objects), but the output side has
6649 not yet been started (HTML resources querying BuilderStatus
6650 objects). Things are probably very broken right now and may remain
6651 so for several weeks, I apologize for the disruption.
6653 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6654 HTML as the log's contents. Currently used for exception tracebacks.
6655 * buildbot/status/progress.py: minor spelling changes
6657 2004-08-02 Brian Warner <warner@lothar.com>
6659 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6660 in mozilla. Also added stylesheets copied from Twisted's docs.
6661 Remember that these files are meant to be run through Lore first.
6662 Thanks to Philipp Frauenfelder for the fixes.
6663 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6664 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6665 * docs/template.tpl: added a Lore template
6667 2004-07-29 Brian Warner <warner@lothar.com>
6669 * buildbot/interfaces.py: revamp status delivery. This is the
6670 preview: these are the Interfaces that will be provided by new
6671 Builder code, and to which the current HTML/IRC/PB status
6672 displayers will be adapted.
6674 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6675 on the SlaveBuilder, not the Bot.
6676 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6677 SlaveBuilder.usePTY
6678 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6679 set .usePTY on the FakeSlaveBuilder
6681 2004-07-25 Brian Warner <warner@lothar.com>
6683 * buildbot/changes/freshcvs.py: add some debug log messages
6684 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6685 disabled 'setFilter' syntax
6686 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6687 don't end with a slash
6689 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6691 * setup.py: bump to 0.5.0+ while between releases
6693 2004-07-23 Brian Warner <warner@lothar.com>
6695 * setup.py (version): Releasing buildbot-0.5.0
6697 2004-07-23 Brian Warner <warner@lothar.com>
6699 * README: update for 0.5.0 release
6701 * NEWS: update for 0.5.0 release
6703 2004-07-22 Brian Warner <warner@lothar.com>
6705 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6706 mktap-time configuration flag (--usepty=1, --usepty=0)
6707 * buildbot/bot.py: same
6709 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6710 an 'info' directory being unwanted
6712 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6713 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6714 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6715 and earlier), use a FreshCVSSourceOldcred instead.
6716 (test): simple test routine: connect to server, print changes
6718 * buildbot/changes/changes.py (Change.getTime): make it possible
6719 to print un-timestamped changes
6721 * buildbot/master.py (makeApp): delete ancient dead code
6722 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6723 * buildbot/test/test_config.py (testFindConfigFile): test it
6725 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6726 instead of win32 one
6729 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6730 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6731 details.
6733 * buildbot/process/base.py (Builder.__init__): change constructor
6734 to accept a dictionary of config data, rather than discrete
6735 name/slave/builddir/factory arguments
6737 * docs/examples/twisted_master.cfg: update to new syntax
6738 * docs/examples/glib_master.cfg: same
6739 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6740 rough tests of the new syntax
6743 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6744 to be an int, which means "run a web.distrib sub-server on a TCP
6745 port". This lets you publish the buildbot status page to a remote
6746 twisted.web server (using distrib.ResourceSubscription). Also
6747 rename the local attributes used to hold these web things so
6748 they're more in touch with reality.
6749 * buildbot/test/test_web.py: test webPortnum and webPathname
6750 * docs/config.xhtml: document this new use of webPathname
6752 * docs/config.xhtml: new document, slightly ahead of reality
6754 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6755 'prefix' handling: treat it as a simple string to check with
6756 .startswith, instead of treating it as a directory. This allows
6757 sub-directories to be used. If you use prefix=, you should give it
6758 a string that starts just below the CVSROOT and ends with a slash.
6759 This prefix will be stripped from all filenames, and filenames
6760 which do not start with it will be ignored.
6762 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6764 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6765 and --exclude (inverse of --include). SVN post-commit hooks
6766 now have total control over which changes get sent to buildbot and which
6767 do not.
6769 2004-07-10 Brian Warner <warner@lothar.com>
6771 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6772 test case to match new API
6774 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6775 which crashed HTML display when self.entries=[] (needed to
6776 distinguish between [], which means "no entries yet", and None,
6777 which means "the entries have been swapped out to disk, go fetch
6778 them").
6780 2004-07-04 Brian Warner <warner@lothar.com>
6782 * buildbot/process/step_twisted.py (countFailedTests): Count
6783 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6784 10kb from the end because any import errors are wedged there and
6785 they would make us think the test log was unparseable.
6786 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6788 2004-06-26 Brian Warner <warner@lothar.com>
6790 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6791 delete-*.pyc command into an actual BuildStep, so we can label it
6792 nicely
6793 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6794 (FullTwistedBuildFactory): same
6796 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6798 * contrib/fakechange.py: Add an errback when sending the fake
6799 change, so we know it didn't work.
6801 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6803 * buildbot/process/step_twisted.py: Delete *.pyc files before
6804 calling trial, so it doesn't catch any old .pyc files whose .py
6805 files have been moved or deleted.
6807 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6808 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6809 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6810 instead of ["twisted.test"], so that the end result is "trial -R
6811 twisted".
6813 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6814 regular expression to match filenames that should be ignored when
6815 changed. Also add a --revision parameter that specifies the
6816 revision to examine, which is useful for debugging.
6818 2004-06-25 Brian Warner <warner@lothar.com>
6820 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6821 summary of warnings (like DeprecationWarnings), next to the
6822 "summary" file
6824 2004-05-13 Brian Warner <warner@lothar.com>
6826 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6827 we now have a w32 build slave courtesy of Mike Taylor.
6829 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6830 so broken. Fixed a race condition that tripped up interlocked
6831 builds and caused the status to be stuck at "Interlocked" forever.
6832 The twisted buildbot's one interlocked build just so happened to
6833 never hit this case until recently (the feeding builds both pass
6834 before the interlocked build is attempted.. usually it has to wait
6835 a while).
6836 (Builder._pong_failed): fix method signature
6838 * setup.py: bump to 0.4.3+ while between releases
6840 2004-04-30 Brian Warner <warner@lothar.com>
6842 * setup.py (version): Releasing buildbot-0.4.3
6844 2004-04-30 Brian Warner <warner@lothar.com>
6846 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6848 * README: update for 0.4.3 release
6850 * NEWS: update for 0.4.3 release
6852 * buildbot/master.py (BuildMaster.__getstate__): make sure
6853 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6855 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6856 .trial as a class attribute, for upgrade from 0.4.2
6858 * buildbot/changes/changes.py (Change.links): add .links for
6859 upgrade from 0.4.2
6861 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6862 .textWatchers and .htmlWatchers at save time, since they are both
6863 volatile, should allow smooth 0.4.2 upgrade
6865 * buildbot/process/step.py (CVS.finishStatus): catch failed
6866 CVS/SVN commands so we can make the status box red
6868 2004-04-29 Brian Warner <warner@lothar.com>
6870 * buildbot/changes/freshcvs.py
6871 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6872 code to do setFilter(), which tells the freshcvs daemon to not
6873 send us stuff that we're not interested in. I will uncomment it
6874 when a new version of CVSToys is available in which setFilter()
6875 actually works, and I get a chance to test it better.
6877 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6879 * buildbot/master.py (Dispatcher): use a registration scheme
6880 instead of hardwired service names
6881 (BuildMaster): keep track of the Dispatcher to support
6882 registration
6884 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6885 PBChangeSource class instead of having it be an undocumented
6886 internal feature of the ChangeMaster. Split out the code into a
6887 new file.
6888 * buildbot/changes/pb.py (PBChangeSource): same
6889 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6891 * docs/{factories|sources|steps}.xhtml: document some pieces
6893 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6894 using FCMaildirSource
6895 (f23osx): update OS-X builder to use python2.3, since the slave
6896 was updated to Panther (10.3.3)
6898 2004-03-21 Brian Warner <warner@lothar.com>
6900 * buildbot/process/process_twisted.py: factor out doCheckout, change
6901 to use SVN instead of CVS
6903 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6904 an SVN subclass easier
6905 (BasicSVN): subclass which uses Subversion instead of CVS
6907 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6909 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6910 of /bin/sh on win32
6911 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6913 2004-02-25 Brian Warner <warner@lothar.com>
6915 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6916 is now either a list (which is passed to spawnProcess directly) or
6917 a string (which gets passed to /bin/sh -c). This removes the useSH
6918 flag and the ArgslistCommand class. Also send status header at the
6919 start and end of each command, instead of having the master-side
6920 code do that.
6921 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6922 -r'. Update to use list-based arguments.
6923 (SVNFetch): use list-based arguments, use ['dir'] argument to
6924 simplify code.
6925 * buildbot/test/test_steps.py (Commands): match changes
6927 * buildbot/process/step.py (InternalShellCommand.words): handle
6928 command lists
6929 (SVN): inherit from CVS, cleanup
6931 * buildbot/status/event.py (Logfile.content): render in HTML, with
6932 stderr in red and headers (like the name of the command we're
6933 about to run) in blue. Add link to a second URL (url + "?text=1")
6934 to get just stdout/stderr in text/plain without markup. There is
6935 still a problem with .entries=None causing a crash, it seems to occur
6936 when the logfile is read before it is finished.
6938 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6939 timeout to the keepalives, and use it to explicitly do a
6940 loseConnection instead of waiting for TCP to notice the loss. This
6941 ought to clear up the silent-lossage problem.
6942 (unsafeTracebacks): pass exception tracebacks back to the master,
6943 makes it much easier to debug problems
6945 2004-02-23 Brian Warner <warner@lothar.com>
6947 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6948 the whole command to /bin/sh instead of execve [Johan Dahlin]
6949 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6950 '-r HEAD' [Johan Dahlin]
6951 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6953 * buildbot/changes/changes.py (Change): add links= argument, add
6954 asHTML method [Johan Dahlin]. Modified to make a bit more
6955 XHTMLish. Still not sure how to best use links= .
6957 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6958 Change.asHTML to display the change, not asText
6960 * buildbot/status/html.py (StatusResourceBuilder): web button to
6961 ping slave
6963 * buildbot/test/test_run.py: test to actually start a buildmaster
6964 and poke at it
6966 * MANIFEST.in: bring back accidentally-dropped test helper files
6968 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6969 that require cvstoys if it is not installed
6971 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6972 values of "bin/trial" [Dave Peticolas]
6973 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6974 tests passed" when we didn't happen to run any tests
6976 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6977 flunkOnFailure [Johan Dahlin]
6979 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6980 multiple instances of the same Step class by suffixing "_2", etc,
6981 to the name until it is unique. This name needs to be unique
6982 because it is used as a key in the dictionary that tracks build
6983 progress.
6984 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6985 add test for it
6987 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6989 2004-01-14 Brian Warner <warner@lothar.com>
6991 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6992 kicked from a channel, log it
6994 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6995 something over whatever IRC channels the buildmaster is currently
6996 connected to. Added to try and track down a problem in which the
6997 master thinks it is still connected but the IRCd doesn't see it. I
6998 used a styles.Versioned this time, so hopefully users won't have
6999 to rebuild their .tap files this time.
7000 * contrib/debug.glade: add a "Poke IRC" button
7001 * contrib/debugclient.py: same
7003 * setup.py: bump to 0.4.2+ while between releases
7005 2004-01-08 Brian Warner <warner@lothar.com>
7007 * setup.py (version): Releasing buildbot-0.4.2
7009 2004-01-08 Brian Warner <warner@lothar.com>
7011 * NEWS: update for 0.4.2 release
7013 * README: document how to run the tests, now that they all pass
7015 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7017 * buildbot/process/step.py (CVS): add a global_options= argument,
7018 which lets you set CVS global options for the command like "-r"
7019 for read-only checkout, or "-R" to avoid writing in the
7020 repository.
7021 * buildbot/slavecommand.py (CVSCommand): same
7023 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7024 testing easier (it is turned off when testing, to avoid the
7025 leftover timer)
7027 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7028 to make it easier to test: break generateStepID() out to a
7029 separate function, only update statusbag if it exists.
7030 (ShellCommands): create useful text for dict-based commands too.
7032 * test/*, buildbot/test/*: move unit tests under the buildbot/
7033 directory
7034 * setup.py (packages): install buildbot.test too
7036 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7037 * buildbot/test/test_steps.py: fix it, tests pass now
7039 2004-01-06 Brian Warner <warner@lothar.com>
7041 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7042 freshcvs mail uses a slightly different syntax for new
7043 directories. Update parser to handle either.
7044 * test/test_mailparse.py (Test1.testMsg9): test for same
7046 2003-12-21 Brian Warner <warner@lothar.com>
7048 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7049 'warnOnWarnings' so that lintian errors mark the build orange
7051 2003-12-17 Brian Warner <warner@lothar.com>
7053 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7054 messages emitted by Bonsai, contributed by Stephen Davis.
7056 * test/*: moved all tests to use trial instead of unittest. Some
7057 still fail (test_steps, test_slavecommand, and test_process).
7059 * setup.py (version): bump to 0.4.1+ while between releases
7061 2003-12-09 Brian Warner <warner@lothar.com>
7063 * setup.py (version): Releasing buildbot-0.4.1
7065 2003-12-09 Brian Warner <warner@lothar.com>
7067 * NEWS: update for 0.4.1 release
7069 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7070 freebsd builder code a little bit
7072 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7073 don't try to compare attributes of different classes
7074 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7075 (MaildirSource.messageReceived): fix Change delivery
7077 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7078 into the config file's namespace before loading it, like the
7079 documentation claims it does
7080 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7081 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7082 daemon comes back online
7084 2003-12-08 Brian Warner <warner@lothar.com>
7086 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7087 so the example will work with online=0 as well
7089 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7090 fix the __implements__ line
7092 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7093 class a twisted.application.service.Service, use startService to
7094 get it moving.
7096 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7097 directory fd instead of simple open(). I'm sure this used to work,
7098 but the current version of python refuses to open directories with
7099 open().
7101 2003-12-05 Brian Warner <warner@lothar.com>
7103 * setup.py (version): bump to 0.4.0+ while between releases
7105 2003-12-05 Brian Warner <warner@lothar.com>
7107 * setup.py (version): Releasing buildbot-0.4.0
7109 2003-12-05 Brian Warner <warner@lothar.com>
7111 * docs/examples/glib_master.cfg: replace old sample scripts with
7112 new-style config files
7113 * MANIFEST.in: include .cfg files in distribution tarball
7115 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7116 implement a dummy method to avoid the exception that occurs when
7117 freshcvs sends this to us.
7119 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7120 removed the method, as it broke reconnection. Apparently
7121 stopFactory is called each time the connection attempt fails. Must
7122 rethink this.
7123 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7124 attribute before serialization, since without stopFactory the
7125 reconnect timer may still be active and they aren't serializable.
7127 * test/test_mailparse.py (ParseTest): test with 'self' argument
7129 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7130 argument, as these "functions" are invoked like methods from class
7131 attributes and therefore always get an instance as the first
7132 argument.
7134 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7135 message: thanks to Stephen Davis for the catch
7137 2003-12-04 Brian Warner <warner@lothar.com>
7139 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7140 twisted's standard ReconnectingClientFactory. Handles both oldcred
7141 and newcred connections. Also has a bug-workaround for
7142 ReconnectingClientFactory serializing its connector when it
7143 shouldn't.
7145 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7146 pbutil. Replace makeApp stuff with proper newcred/mktap
7147 makeService(). Don't serialize Ephemerals on shutdown.
7149 * buildbot/changes/changes.py (ChangeMaster): make it a
7150 MultiService and add the sources as children, to get startService
7151 and stopService for free. This also gets rid of the .running flag.
7153 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7154 new pbutil, turn into a TCPClient at the same time (to get
7155 startService for free). Two variants exist: FreshCVSSourceOldcred
7156 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7157 yet, but when it does, we'll be ready).
7158 (FreshCVSSource.notify): handle paths which are empty after the
7159 prefix is stripped. This only happens when the top-level (prefix)
7160 directory is added, at the very beginning of a Repository's life.
7162 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7163 Now the only reconnecting code is in the factory where it belongs.
7164 (Builder.unsubscribe): unregister the disconnect callback when we
7165 delete the builder on command from the master (i.e. when the
7166 buildmaster is reconfigured and that builder goes away). This
7167 fixes a multiple-delete exception when the status client is shut
7168 down afterwards.
7169 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7170 base Client.
7172 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7173 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7175 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7177 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7178 a list of globs (ugh). The testdir will be searched for files
7179 named *.tests and run the tests in the order specified in each of
7180 those files. This allows for "dependancies" between tests to be
7181 codified.
7183 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7184 argument to pass to run_maxq.py, instead of a glob.
7186 2003-10-17 Brian Warner <warner@lothar.com>
7188 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7189 files that live in the sandbox
7191 2003-10-15 Brian Warner <warner@lothar.com>
7193 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7194 spelling error in "docs" count-warnings output
7195 (HLint.start): stupid thinko meant .xhtml files were ignored
7197 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7198 tests now that cReactor is banished to the sandbox
7200 2003-10-10 Brian Warner <warner@lothar.com>
7202 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7203 scheme: now .xhtml are sources and .html are generated
7205 2003-10-08 Brian Warner <warner@lothar.com>
7207 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7208 we were ignoring the 'randomly' parameter.
7210 2003-10-01 Brian Warner <warner@lothar.com>
7212 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7213 posix, to kill sub-children of aborted slavecommands.
7215 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7216 Clean up initialization: lastBuildStatus remains None until the
7217 first build has been completed.
7219 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7220 None as a lastBuildStatus
7221 * buildbot/clients/gtkPanes.py: same
7223 * buildbot/status/client.py (StatusClientService): keep
7224 BuilderStatus objects in self.statusbags . These objects now live
7225 here in the StatusClientService and are referenced by the Builder
7226 object, rather than the other way around.
7227 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7228 * buildbot/process/base.py (Builder): same
7229 * test/test_config.py (ConfigTest.testBuilders): same
7231 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7232 an existing builder, leave the statusbag alone. This will preserve the
7233 event history.
7235 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7236 hook. This will probably go away in favor of a class in upcoming
7237 Twisted versions.
7239 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7240 serviceName from newcred FreshCVSNotifiee setup
7242 2003-09-29 Brian Warner <warner@lothar.com>
7244 * buildbot/process/process_twisted.py: switch to new reactor
7245 abbreviations
7246 * docs/examples/twisted_master.cfg: same
7248 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7250 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7251 botmaster reference instead of the oldapp service lookup
7253 * buildbot/master.py (BuildMaster.__init__): give the
7254 StatusClientService a reference to the botmaster to make it easier to
7255 force builds
7257 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7259 * buildbot/status/html.py (Box.td): escape hreffy things so you
7260 can have spaces in things like builder names
7261 (StatusResourceBuilder.body)
7262 (WaterfallStatusResource.body)
7263 (WaterfallStatusResource.body0): same
7265 2003-09-25 Brian Warner <warner@lothar.com>
7267 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7268 rearrange the builder list when adding or removing builders: keep
7269 them in the order the user requested.
7270 * test/test_config.py (ConfigTest.testBuilders): verify it
7272 * contrib/debug.glade: give the debug window a name
7274 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7275 now wait on multiple interlocks. Fix code relating to that.
7276 (Builder.checkInterlocks): same
7277 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7279 * buildbot/master.py (BuildMaster.loadConfig): move from
7280 deprecated pb.BrokerFactory to new pb.PBServerFactory
7281 * test/test_config.py (ConfigTest.testWebPathname): same
7283 * docs/examples/twisted_master.cfg: fix interlock declaration
7285 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7286 Interlocks to their Builders into interlock.py .
7287 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7289 * test/test_config.py (ConfigTest.testInterlocks): validate
7290 interlock handling
7292 * buildbot/process/base.py (Builder.__init__): better comments
7293 * buildbot/process/interlock.py (Interlock.__repr__): same
7294 (Interlock.deactivate): add .active flag, move the code that
7295 attaches/detaches builders into the Interlock
7297 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7299 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7300 tests using the new run_maxq.py script, and reporting failures by
7301 parsing its output.
7303 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7304 tests, reporting their success or failure in a buildbot-friendly
7305 manner.
7307 2003-09-24 Brian Warner <warner@lothar.com>
7309 * docs/examples/twisted_master.cfg: example of a new-style config
7310 file. This lives in the buildmaster base directory as
7311 "master.cfg".
7313 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7314 button to make the master re-read its config file
7316 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7317 buildmaster configuration from a file. This file can be re-read
7318 later, and the buildmaster will update itself to match the new
7319 desired configuration. Also use new Twisted Application class.
7320 * test/Makefile, test/test_config.py: unit tests for same
7322 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7323 FreshCVSSources comparable, to support reload.
7324 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7326 * buildbot/process/base.py (Builder): make them comparable, make
7327 Interlocks easier to attach, to support reload. Handle
7328 re-attachment of remote slaves.
7329 * buildbot/process/interlock.py (Interlock): same
7331 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7332 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7333 buildmaster taps are now constructed with mktap.
7334 * buildbot/status/client.py (StatusClientService): same
7336 * buildbot/status/words.py: move to new Services, add support to
7337 connect to multiple networks, add reload support, allow nickname
7338 to be configured on a per-network basis
7340 2003-09-20 Brian Warner <warner@lothar.com>
7342 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7343 the freebsd builder, now that the machine has been upgraded and no
7344 longer has python2.2
7346 * setup.py (version): bump to 0.3.5+ while between releases
7348 2003-09-19 Brian Warner <warner@lothar.com>
7350 * setup.py (version): Releasing buildbot-0.3.5
7352 2003-09-19 Brian Warner <warner@lothar.com>
7354 * NEWS: add post-0.3.4 notes
7356 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7358 * MANIFEST.in: add contrib/*
7360 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7361 use a remote root now: cvs.twistedmatrix.com
7363 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7364 to newcred
7365 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7366 compatibility with old servers
7367 (FreshCVSSource.start): and provide a way to use it
7368 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7370 * docs/examples/twisted_master.py (twisted_app): update to new
7371 makeApp interface.
7372 (twisted_app): listen on new ~buildbot socket
7373 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7375 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7376 to reduce cvs bandwidth (update instead of full checkout)
7378 2003-09-11 Brian Warner <warner@lothar.com>
7380 * contrib/fakechange.py: demo how to connect to the changemaster
7381 port. You can use this technique to submit changes to the
7382 buildmaster from source control systems that offer a hook to run a
7383 script when changes are committed.
7385 * contrib/debugclient.py: tool to connect to the debug port. You
7386 can use it to force builds, submit fake changes, and wiggle the
7387 builder state
7389 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7390 'Dispatcher' realm to handle all the different kinds of
7391 connections and Perspectives: buildslaves, the changemaster port,
7392 the debug port, and the status client port. NewCredPerspectives
7393 now have .attached/.detached methods called with the remote 'mind'
7394 reference, much like old perspectives did. All the pb.Services
7395 turned into ordinary app.ApplicationServices .
7396 (DebugService): went away, DebugPerspectives are now created
7397 directly by the Dispatcher.
7398 (makeApp): changed interface a little bit
7400 * buildbot/changes/changes.py: newcred
7401 * buildbot/status/client.py: newcred
7403 * buildbot/clients/base.py: newcred client side changes
7404 * buildbot/bot.py: ditto
7406 * docs/examples/glib_master.py: handle new makeApp() interface
7407 * docs/examples/twisted_master.py: ditto
7409 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7410 base newcred Perspectives on. This should go away once Twisted
7411 itself provides something sensible.
7414 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7416 * contrib/svn_buildbot.py: A program that you can call from your
7417 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7418 when a change in an SVN repository has happened. See the top of
7419 the file for some minimal usage info.
7421 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7423 * buildbot/slavecommand.py (ArglistCommand): Add new
7424 ArglistCommand that takes an argument list rather than a string as
7425 a parameter. Using a st.split() for argv is very bad.
7427 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7428 update to a particular revision rather than always checking out
7429 (still not very smart about it, there may be cases where the
7430 checkout becomes inconsistent).
7432 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7434 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7435 SVN fetch support. It can checkout (not update!) a specified
7436 revision from a specified repository to a specified directory.
7438 * buildbot/status/progress.py (Expectations.update): Fix an
7439 obvious bug (apparently created by the change described in the
7440 previous ChangeLog message) by moving a check to *after* the
7441 variable it checks is defined.
7444 2003-09-08 Brian Warner <warner@lothar.com>
7446 * buildbot/status/progress.py (Expectations.update): hack to catch
7447 an exception TTimo sees: sometimes the update() method seems to
7448 get called before the step has actually finished, so the .stopTime
7449 is not set, so no totalTime() is available and we average None
7450 with the previous value. Catch this and just don't update the
7451 metrics, and emit a log message.
7453 2003-08-24 Brian Warner <warner@lothar.com>
7455 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7456 parameter to set copydir='original' in CVS commands.
7458 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7460 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7461 which tells the command to maintain a separate original-source CVS
7462 workspace. For each build, this workspace will be updated, then
7463 the tree copied into a new workdir. This reduces CVS bandwidth
7464 (from a full checkout to a mere update) while doubling the local
7465 disk usage (to keep two copies of the tree).
7467 2003-08-21 Brian Warner <warner@lothar.com>
7469 * buildbot/status/event.py (Logfile.addEntry): if the master web
7470 server dies while we're serving a page, request.write raises
7471 pb.DeadReferenceError . Catch this and treat it like a
7472 notifyFinish event by dropping the request.
7474 2003-08-18 Brian Warner <warner@lothar.com>
7476 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7477 (instead of blowing up) if a force-build command is given without
7478 a reason field
7480 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7481 don't blow up if there aren't yet any Changes in the list
7483 2003-08-02 Brian Warner <warner@lothar.com>
7485 * buildbot/bot.py (updateApplication): don't set the .tap name,
7486 since we shouldn't assume we own the whole .tap file
7488 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7489 'mktap buildbot' (without a subcommand) better
7491 2003-07-29 Brian Warner <warner@lothar.com>
7493 * buildbot/status/words.py
7494 (IrcStatusFactory.clientConnectionLost): when we lose the
7495 connection to the IRC server, schedule a reconnection attempt.
7497 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7498 use shutil.rmtree instead of forking off an "rm -rf" command.
7499 rmtree may take a while and will block until it finishes, so we
7500 use "rm -rf" if available.
7502 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7503 freebsd buildslave badly
7505 * setup.py (version): bump to 0.3.4+ while between releases
7507 2003-07-28 Brian Warner <warner@lothar.com>
7509 * setup.py (version): Releasing buildbot-0.3.4
7511 2003-07-28 Brian Warner <warner@lothar.com>
7513 * NEWS: update in preparation for release
7515 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7516 process.signalProcess instead of os.kill, to improve w32
7517 portability
7519 * docs/examples/twisted_master.py (twisted_app): turn off
7520 win32eventreactor: the tests hang the buildslave badly
7522 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7523 failed builds, since usually the failures are consistent
7525 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7526 add compileOpts/compileOpts2 to reactors build
7528 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7529 (twisted_app): use both default and win32eventreactor on w32 build.
7530 Use both default and kqreactor on freebsd build.
7532 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7533 add compileOpts2, which is put after the build_ext argument. w32
7534 needs "-c mingw32" here.
7536 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7537 touch .acqpath, it goes away in recent Twisted releases
7539 * docs/examples/twisted_master.py (twisted_app): use "python" for
7540 the w32 buildslave, not "python2.2"
7542 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7543 the directory exists.. should hush an exception under w32
7545 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7546 ProcessTerminated -provided values for signal and exitCode rather
7547 than parsing the unix status code directly. This should remove one
7548 more roadblock for a w32-hosted buildslave.
7550 * test/test_mailparse.py: add test cases for Syncmail parser
7552 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7553 temporary compatibility import. Note! Start importing
7554 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7556 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7558 2003-07-27 Brian Warner <warner@lothar.com>
7560 * NEWS: started adding new features
7562 * buildbot/changes/mail.py: start work on Syncmail parser, move
7563 mail sources into their own file
7565 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7566 as implementing IChangeSource
7567 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7569 * buildbot/interfaces.py: define the IChangeSource interface
7571 2003-07-26 Brian Warner <warner@lothar.com>
7573 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7575 2003-06-25 Brian Warner <warner@lothar.com>
7577 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7578 seconds display
7580 2003-06-17 Brian Warner <warner@lothar.com>
7582 * buildbot/status/words.py: clean up method usage to avoid error
7583 in silly IRC command
7584 (IrcStatusBot.emit_status): round off seconds display
7586 * buildbot/process/base.py (Build): delete the timer when saving
7587 to the .tap file, and restore it (if it should still be running)
7588 upon restore. This should fix the "next build in -34 seconds"
7589 messages that result when the master is restarted while builds are
7590 sitting in the .waiting slot. If the time for the build has
7591 already passed, start it very soon (in 1 second).
7593 * buildbot/status/words.py: more silly commands
7595 * README (REQUIREMENTS): add URLs to all required software
7597 * buildbot/status/words.py ('last'): mention results of, and time
7598 since last build
7600 2003-05-28 Brian Warner <warner@lothar.com>
7602 * buildbot/status/words.py: add 'last' command
7603 (IrcStatusBot.emit_status): add current-small text to 'status' output
7605 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7606 (twisted_app): remove spaces from OS-X builder name
7608 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7609 * buildbot/status/words.py: IRC bot should actually be useful now
7611 2003-05-23 Brian Warner <warner@lothar.com>
7613 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7614 "slave information" from $(slavedir)/info/* . These files are
7615 maintained by the slave administrator, and describe the
7616 machine/environment that is hosting the slave. Information from
7617 them is put into the "Builder" HTML page. Still need to establish
7618 a set of well-known filenames and meanings for this data: at the
7619 moment, *all* info/* files are sent to the master, but only
7620 'admin' and 'host' are used on that end.
7621 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7622 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7623 * buildbot/master.py (BotPerspective.got_info): ditto
7625 2003-05-22 Brian Warner <warner@lothar.com>
7627 * setup.py (version): bump version to 0.3.3+ while between releases
7629 2003-05-21 Brian Warner <warner@lothar.com>
7631 * setup.py: Releasing buildbot-0.3.3
7633 2003-05-21 Brian Warner <warner@lothar.com>
7635 * NEWS: 0.3.3 news items
7637 * README: describe --keepalive and life behind a NAT box
7639 * buildbot/bot.py (Bot.connected): implement application-level
7640 keepalives to deal with NAT timeouts, turn them on with
7641 --keepalive option or when SO_KEEPALIVE doesn't work.
7643 * buildbot/master.py (BotPerspective): accept keepalives silently
7645 * buildbot/process/base.py (Build.buildException): CopiedFailures
7646 don't carry as much information as local ones, so don't try to
7647 create a big HTMLized version of them.
7649 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7650 log file when step fails due to an exception, such as when the slave
7651 becomes unreachable
7653 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7654 --testmodule argument instead of grepping for test-case-name tags
7655 ourselves. Remove FindUnitTests code.
7656 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7658 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7660 2003-05-16 Brian Warner <warner@lothar.com>
7662 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7663 argument to allow things like CFLAGS=-O0 to be passed without relying
7664 upon /bin/sh processing on the slave.
7666 * buildbot/process/step.py (InternalShellCommand.start): send
7667 'env' dict to slave
7668 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7669 'split' instead of letting /bin/sh do it. This should also remove
7670 the need for /bin/sh on the buildslave, making it more likely to
7671 work with win32.
7673 * buildbot/status/html.py: html-escape text in blamelist.
7674 Add "force build" button to the Builder page.
7676 * buildbot/process/step_twisted.py (countFailedTests): look at
7677 last 1000 characters for status line, as import errors can put it
7678 before the -200 point.
7680 2003-05-15 Brian Warner <warner@lothar.com>
7682 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7684 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7685 make 'clobber' a parameter, so it is possible to have builds which
7686 do full tests but do a cvs update instead of hammering the CVS
7687 server with a full checkout each build
7689 * buildbot/process/step.py (InternalShellCommand): bump default
7690 timeout to 20 minutes
7692 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7693 the master to trigger a build. Run it via manhole.
7695 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7696 allow slaves to trigger any build that they host, to make life
7697 easier for slave admins who are testing out new build processes
7699 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7700 don't flunk cReactor or qtreactor on failure, since they fail alot
7701 these days. Do warnOnFailure instead.
7703 * buildbot/process/base.py: change Builder.buildable from a list
7704 into a single slot. When we don't have a slave, new builds (once
7705 they make it past the timeout) are now merged into an existing
7706 buildable one instead of being queued. With this change, a slave
7707 which has been away for a while doesn't get pounded with all the
7708 builds it missed, but instead just does a single build.
7710 2003-05-07 Brian Warner <warner@lothar.com>
7712 * setup.py (version): bump version to 0.3.2+ while between releases
7714 2003-05-07 Brian Warner <warner@lothar.com>
7716 * setup.py: Releasing buildbot-0.3.2
7718 2003-05-07 Brian Warner <warner@lothar.com>
7720 * setup.py: fix major packaging error: include subdirectories!
7722 * NEWS: add changes since last release
7724 * README (REQUIREMENTS): update twisted/python dependencies
7726 * buildbot/status/builder.py (Builder.startBuild): change
7727 BuildProcess API: now they should call startBuild/finishBuild
7728 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7729 keeping a list of builds in the statusbag, to support other kinds of
7730 status delivery.
7731 (Builder.addClient): send current-activity-small to new clients
7732 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7733 new API
7735 * buildbot/status/client.py: drop RemoteReferences at shutdown
7737 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7739 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7740 more debug messages for remote status client
7742 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7743 (.stepFailed): only fire the Deferred once, even if both
7744 stepComplete and stepFailed are called. I think this can happen if
7745 an exception occurs at a weird time.
7747 * buildbot/status/words.py: work-in-progress: IRC status delivery
7749 2003-05-05 Brian Warner <warner@lothar.com>
7751 * docs/examples/twisted_master.py (twisted_app): hush internal
7752 python2.3 distutils deprecation warnings
7753 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7754 add compileOpts= argument which inserts extra args before the
7755 "setup.py build_ext" command. This can be used to give -Wignore
7756 warnings, to hush some internal python-2.3 deprecation messages.
7758 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7759 the ['twisted.test'] default test case to make it easier to change
7760 in subclasses
7762 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7763 * buildbot/clients/gtkPanes.py: ditto
7765 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7766 arg to collapse RunUnitTestsRandomly into RunUnitTests
7767 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7768 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7770 * buildbot/status/html.py (StatusResource): shuffle Resources
7771 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7772 would serve the waterfall display, but the internal links were
7773 only valid on the trailing-slash version. The correct behavior is
7774 for the non-slashed one to serve a Redirect to the slashed one.
7775 This only shows up when the buildbot page is hanging off another
7776 server, like a Twisted-Web distributed server.
7778 * buildbot/status/event.py (Event, RemoteEvent): make Events
7779 pb.Cacheable, with RemoteEvent as the cached version. This removes
7780 a lot of explicit send-an-update code.
7781 * buildbot/status/builder.py (Builder): remove send-update code
7782 * buildbot/status/client.py (ClientBuilder): remove send-update
7783 code, and log errors that occur during callRemote (mostly to catch
7784 InsecureJelly exceptions)
7786 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7787 run Lore with the same python used in the rest of the build
7789 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7791 * buildbot/process/step_twisted.py (HLint): accept 'python'
7792 argument. Catch rc!=0 and mark the step as failed. This marks the
7793 build orange ("has warnings").
7794 (RunUnitTestsJelly): move out to step_twisted2.py
7796 * buildbot/util.py (ignoreStaleRefs): add utility function
7798 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7799 don't fake ETA object, it's too hard to get right
7801 2003-05-02 Brian Warner <warner@lothar.com>
7803 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7805 2003-05-01 Brian Warner <warner@lothar.com>
7807 * buildbot/status/html.py (StatusResource.body): oops, I was
7808 missing a <tr>, causing the waterfall page to be misrendered in
7809 everything except Galeon.
7811 2003-04-29 Brian Warner <warner@lothar.com>
7813 * docs/examples/twisted_master.py: make debuild use python-2.2
7814 explicitly, now that Twisted stopped supporting 2.1
7816 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7817 handle tuple results too. I keep forgetting this, which suggests
7818 it needs to be rethought.
7820 * setup.py (setup): bump version to 0.3.1+ while between releases
7822 2003-04-29 Brian Warner <warner@lothar.com>
7824 * setup.py: Releasing buildbot-0.3.1
7826 2003-04-29 Brian Warner <warner@lothar.com>
7828 * README (SUPPORT): add plea to send questions to the mailing list
7830 * NEWS, MANIFEST.in: add description of recent changes
7832 * docs/examples/twisted_master.py: add the code used to create the
7833 Twisted buildmaster, with passwords and such removed out to a
7834 separate file.
7836 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7837 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7838 buildmasters to not require CVSToys be installed.
7839 * README, docs/examples/glib_master: update to match the change
7841 * buildbot/clients/base.py, buildbot/bot.py,
7842 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7843 ReconnectingPB from CVSToys distribution to remove CVSToys
7844 dependency for build slaves and status clients. Buildmasters which
7845 use FreshCVSSources still require cvstoys be installed, of course.
7847 2003-04-25 Brian Warner <warner@lothar.com>
7849 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7850 runTestsRandomly arg to turn on trial -z
7852 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7853 experimental code to use trial's machine-parseable output to get
7854 more detailed test results. Still has some major issues.
7855 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7856 in random sequence
7858 * buildbot/status/builder.py (Builder.setCurrentBuild):
7859 anticipating moving build history into statusbag, not used yet
7861 * buildbot/status/tests.py: code to centralize test results,
7862 doesn't work quite yet
7864 * buildbot/status/event.py (Event): use hasattr("setName") instead
7865 of isinstance for now.. need better long-term solution
7867 * buildbot/status/html.py: Remove old imports
7869 2003-04-24 Brian Warner <warner@lothar.com>
7871 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7872 ignore changes under doc/fun/ and sandbox/
7874 * buildbot/process/step_twisted.py: update pushEvent and friends.
7876 * buildbot/status/html.py (Box.td): replace event.buildername with
7877 event.parent.getSwappableName(). Needs more thought.
7879 * buildbot/status/builder.py (Builder): Replace pushEvent and
7880 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7881 Tell events they are being pruned with event.delete().
7883 * buildbot/process/base.py (Build): Remove Builder status-handling
7884 methods. s/pushEvent/setCurrentActivity/.
7886 * buildbot/process/step.py (BuildStep): clean up status delivery.
7887 Gouse builder.statusbag methods instead of intermediate builder
7888 methods. s/updateLastEvent/updateCurrentActivity/.
7889 s/finalizeLastEvent/finishCurrentActivity/. Use
7890 addFileToCurrentActivity for summaryFunction.
7892 * buildbot/status/event.py (Logfile): put data in a Swappable when
7893 .finish is called.
7894 (Event): add more setter methods. Remove .buildername, use .parent
7895 and getSwappableName instead (needs more thought).
7897 * buildbot/util.py (Swappable):
7898 * test/test_swap.py: don't bother setting filename at __init__
7899 time, do it later. Change setFilename args to take parent first,
7900 since it provides the most significant part of the filename.
7902 2003-04-23 Brian Warner <warner@lothar.com>
7904 * buildbot/status/event.py (Logfile.addEntry): append to previous
7905 entry, if possible
7907 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7908 anticipating Swappable
7909 (InternalShellCommand.remoteUpdate): split out various log-adding
7910 methods so subclasses can snarf stdout separately
7912 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7913 in anticipation of Swappable build logs
7914 (Builder.testsFinished): anticipating TestResults, still disabled
7916 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7917 last 100 events
7919 * buildbot/status/event.py (Logfile): add (disabled) support for
7920 Swappable, not ready for use yet
7922 * buildbot/util.py (Swappable): object which is swapped out to
7923 disk after some period of no use.
7924 * test/test_swap.py: test buildbot.utils.Swappable
7926 2003-04-14 Brian Warner <warner@lothar.com>
7928 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7929 periodic-build timer. Set the .periodicBuildTime on a builder
7930 instance to some number of seconds to activate it.
7932 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7934 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7935 a way that survives result tuples
7937 2003-04-12 Brian Warner <warner@lothar.com>
7939 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7940 return a dict instead of a tuple: allow summarizers to provide
7941 multiple summaries if they want
7942 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7943 (debuildSummarizer): summarize lintian warnings/errors
7945 2003-04-10 Brian Warner <warner@lothar.com>
7947 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7949 2003-04-09 Brian Warner <warner@lothar.com>
7951 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7952 empty summaries: happens when the tests fail so hard they don't emit
7953 a parseable summary line.
7955 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7956 Allow summaryFunction to return None to indicate no summary should
7957 be added.
7959 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7960 writing to stale HTTP requests: notice when they disconnect and
7961 remove the request from the list. Also add CacheToFile from
7962 moshez, will be used later.
7964 2003-04-08 Brian Warner <warner@lothar.com>
7966 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7967 should be an int, not a list of strings
7969 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7970 if we weren't actually connected
7972 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7973 to show the tail end of the trial text output
7975 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7976 hook to summarize the results of a ShellCommand
7978 2003-04-07 Brian Warner <warner@lothar.com>
7980 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7981 twisted test suite code into a single class.
7982 * buildbot/process/process_twisted.py: same
7984 2003-04-04 Brian Warner <warner@lothar.com>
7986 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7988 * README (SLAVE): document use of mktap to create slave .tap file
7989 (REQUIREMENTS): describe dependencies
7991 * buildbot/bb_tap.py, buildbot/plugins.tml:
7992 * buildbot/bot.py (updateApplication): Add mktap support for creating
7993 buildslave .tap files
7995 2003-03-28 Brian Warner <warner@lothar.com>
7997 * buildbot/process/step.py (InternalShellCommand.finished): handle
7998 new tuple result values (fix embarrasing bug that appeared during
7999 PyCon demo)
8001 2003-03-27 Brian Warner <warner@lothar.com>
8003 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8004 -making program
8006 2003-03-25 Brian Warner <warner@lothar.com>
8008 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8009 to overall build status
8010 * buildbot/clients/base.py (Builder): improve event printing
8011 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8012 instead of generic ShellCommand
8013 (Build): Add .stopBuild, use it when slave is detached
8015 * buildbot/process/step.py (Configure,Test): give the steps their
8016 own names and status strings
8018 * buildbot/status/html.py (StatusResource): add "show" argument,
8019 lets you limit the set of Builders being displayed.
8021 2003-03-20 Brian Warner <warner@lothar.com>
8023 * buildbot/process/basic.py: removed
8025 2003-03-19 Brian Warner <warner@lothar.com>
8027 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8028 turn off process-docs by default
8030 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8031 when displaying build information without anything in allBuilds[]
8033 * buildbot/bot.py (makeApp): really take password from sys.argv
8035 2003-03-18 Brian Warner <warner@lothar.com>
8037 * buildbot/bot.py (buildApp): take password from sys.argv
8039 * README: replace with more useful text
8041 * setup.py: add a real one
8042 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8044 * docs/PyCon-2003/: added sources for PyCon paper.
8046 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8047 now Build objects control the process and Builder only handles
8048 slave stuff and distribution of changes/status. A new BuildFactory
8049 class creates Build objects on demand.
8051 Created ConfigurableBuild which takes a list of steps to run. This
8052 makes it a lot easier to set up a new kind of build and moves us
8053 closer to being able to configure a build from a web page.
8055 * buildbot/process/step_twisted.py, process_twisted.py: move to
8056 new model. A lot of code went away.
8058 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8059 send lots of empty progress messages to the client.
8061 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8063 2003-02-20 Brian Warner <warner@lothar.com>
8065 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8067 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8068 Twisted bug that prevented non-pty processes from working just got
8069 fixed, and the bug that leaks ptys is still being investigated.
8071 * buildbot/process/step.py (CVS): send timeout arg to slave
8073 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8074 builders coming and going
8075 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8076 from CVSToys, handle lost-buildmaster
8078 * buildbot/status/client.py (StatusClientService.removeBuilder):
8079 Clean up status client protocol: send builders (with references)
8080 as they are created, rather than sending a list and requiring the
8081 client to figure out which ones are new.
8082 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8083 attempts to force a build on an unknown builder
8085 2003-02-19 Brian Warner <warner@lothar.com>
8087 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8088 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8089 Twisted stops leaking them.
8090 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8091 builder goes to an idle state.
8093 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8094 I figure out why CVS commands hang without them, and/or I fix the
8095 hung-command timeout
8097 2003-02-16 Brian Warner <warner@lothar.com>
8099 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8100 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8101 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8102 GenerateDocs now that they are prefixed with WARNING:.
8104 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8105 use manual href target instead of request.childLink
8107 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8108 display every second, but update the ETA every 5 seconds (or
8109 whenever) as remote_progress messages arrive.
8112 2003-02-12 Brian Warner <warner@lothar.com>
8114 * *: import current sources from home CVS repository
8117 # Local Variables:
8118 # add-log-time-format: add-log-iso8601-time-string
8119 # End: