1 2007-07-31 Brian Warner <warner@lothar.com>
3 * buildbot/scripts/startup.py (launch): import twistd.run in a
4 different way to hush pyflakes
5 * buildbot/process/builder.py: remove unused import
7 2007-07-30 Brian Warner <warner@lothar.com>
9 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
10 Mitchell: pass SourceStamps around rather than branch/version/etc
11 tuples. Thanks Dustin! Closes #70.
12 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
13 tuple rather than a list, to avoid surprising mutations
14 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
15 * buildbot/status/mail.py (MailNotifier.buildMessage): same
16 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
17 * buildbot/test/test_status.py (Subscription): same
18 * buildbot/test/test_control.py (Force): same
19 * buildbot/test/test_buildreq.py (Request.testMerge): same
21 2007-07-29 Brian Warner <warner@lothar.com>
23 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
24 variable, since it wasn't used and is confusing in the presence of
25 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
28 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
29 the Buildbot home-page link to point at buildbot.net instead of
30 sourceforge, and add a current-version query parameter so we can
31 get some statistics on which versions are in use out there.
33 2007-07-28 Brian Warner <warner@lothar.com>
35 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
36 with c['change_source'], leaving c['sources'] for backwards
37 compatibility (but deprecated), scheduled for removal in 0.8.0
38 * docs/buildbot.texinfo: same
39 * buildbot/test/test_config.py: verify that c['sources'] still works
40 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
41 * buildbot/scripts/sample.cfg: update to match
43 * buildbot/changes/mail.py (MaildirSource): parse with python's
44 stdlib 'email' module, which has been available since python2.2,
45 and drop use of the 'rfc822' module, which has been depreceated
47 * buildbot/test/test_maildir.py: same: use parse_file() not parse
49 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
50 this needs to match the renaming in test/mail/msg*
52 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
55 * buildbot/test/test_mailparse.py: rename sample emails a bit
56 * buildbot/test/mail/msg*: same
58 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
59 parser for the "commit-email.pl" script that is shipped with SVN,
60 written by Justin Mason. Thanks! Closes SF#1072845.
61 * buildbot/test/mail/svn-commit.*: sample messages
62 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
63 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
65 2007-07-27 Brian Warner <warner@lothar.com>
67 * buildbot/changes/mail.py: refactor: move parsing into a method
68 named 'parse', each parser type gets a separate subclass. Remove
69 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
70 to be a simple leading-substring match. Add a warning to the logs
71 if prefix= does not end in a slash, since that's probably a
72 mistake. Fix both places where a prefix= mismatch would skip all
73 subsequent files in the same email, instead of just skipping the
74 one that didn't match.
75 * buildbot/test/test_mailparse.py: match changes
77 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
78 docs on email-based ChangeSources
80 * docs/buildbot.texinfo (Getting Source Code Changes): move all
81 the changesource types up a level, removing the one-entry menu in
84 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
85 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
86 instances instead of tuples. Closes #63.
87 * buildbot/slave/__init__.py (BuildSlave): define marker class
88 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
89 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
90 * buildbot/test/test_*.py: update tests to match
91 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
92 the c['bots'] backwards-compatibility handler works
94 2007-07-26 Brian Warner <warner@lothar.com>
96 * buildbot/changes/hgbuildbot.py (hook): add an in-process
97 Mercurial change-sending hook, contributed by Frederic Leroy.
98 Thanks! Addresses #50.
99 * docs/buildbot.texinfo (MercurialHook): document it
101 * buildbot/changes/hgbuildbot.py: change the way imports are done,
102 to make it compatible with at least hg-0.9.1 and the current 0.9.4
104 2007-07-17 Brian Warner <warner@lothar.com>
106 * buildbot/process/buildstep.py (BuildStep.getLog): add a
107 convenience method to retrieve a log added with
108 addLog()/addCompleteLog()/etc or logfiles= . I should have added
111 2007-07-03 Brian Warner <warner@lothar.com>
113 * buildbot/slave/commands.py (ShellCommand._startCommand): when
114 logging the environment variables, put one variable on each line,
115 rather than having one really long line with all of them. This
116 should make them a bit more readable and not trigger the
117 horizontal scrollbar (when viewing it in a web browser) quite so
118 much. Thanks to Albert Hofkamp for the patch.
120 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
121 WithProperties instance. Thanks to Axel Hecht for the patch.
123 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
124 * docs/buildbot.texinfo (Build Properties): document it
125 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
126 workdir if it didn't already exist.
128 * docs/buildbot.texinfo (Scheduler Types): correct the description
129 of Dependent schedulers. Thanks to Greg Ward for the patch.
131 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
132 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
133 the patch. Closes #49.
135 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
136 0700 before removing it, to deal with situations where a build will
137 leave files around without write permissions and the 'copy' or
138 'clobber' VC checkout modes need to blow away the tree first.
139 Thanks to Steve Milner for the suggestion and the patch (which I
140 mangled horribly). Closes #29.
141 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
144 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
145 an allowReconnect= argument to let callers control whether they
146 want this don't-let-it-reconnect behavior, since some tests care.
147 Factor out the .continueTrying=False lines from those callers.
148 * buildbot/test/test_slaves.py: same
149 * buildbot/test/test_run.py: same
151 2007-07-02 Brian Warner <warner@lothar.com>
153 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
154 slave has been disappeared, don't let it reconnect. This was
155 causing an intermittent failure in test_slaves.py, when the slave
156 that was supposed to be gone managed to come back by the end of
157 the test and affect the count.
158 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
160 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
161 diagnostic messages to track down this problem
162 (Builder.startBuild): same
164 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
165 the slave randomly rather than always taking the first one. Thanks
166 to Pike for the patch. Closes #36.
167 * buildbot/test/test_slaves.py: match the change. to avoid huge
168 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
169 enables/disables the round-robin-ness (enabled by default), and
170 some unit tests disable it.
171 * docs/buildbot.texinfo (Buildmaster Architecture): document it
173 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
174 argument to 'buildmaster_host', to make it more obvious that this
175 points to the buildmaster. Thanks to Bob Proulx for the
177 * buildbot/scripts/runner.py (slaveTAC): same
178 * buildbot/test/test_runner.py (Create.testSlave): match the change
180 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
183 2007-06-17 Brian Warner <warner@lothar.com>
185 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
186 we can round-trip all of our current step classes by calling
187 getStepFactory() and using the results to make a clone of the
190 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
193 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
194 the config file, we're moving to using actual instances instead of
195 the (class, kwargs) 'step specification' tuples. BuildFactory
196 still keeps a list of tuples internally, but when real instances
197 are passed in to addStep(), they are asked for their class and
198 kwargs using the new BuildStep.getStepFactory method. BuildFactory
199 accepts both instances and the tuple form, and converts instances
200 to the tuple form, but the instance form is preferred because it
201 gives the Steps a chance to do argument validation. Closes: #11.
203 * buildbot/process/buildstep.py (BuildStep.__init__): record the
204 factory information necessary to implement getStepFactory. The
205 addFactoryArguments() method can be used to include arguments that
206 aren't passed to the BuildStep base class constructor.
207 (BuildStep.setBuild):
208 (BuildStep.setDefaultWorkdir): new methods to take parameters that
209 are needed for live BuildSteps but not to construct the specification
210 tuples that are stashed in the factory.
212 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
213 'workdir' into new BuildSteps by using methods instead of
214 arguments. This makes the constructor for BuildSteps a lot
217 * buildbot/steps/*.py: update to match this change. Basically this
218 means adding calls to addFactoryArguments() in the __init__
219 methods to capture the arguments that aren't passed through to the
221 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
222 the new workdir (if any) into the RemoteShellCommands arguments.
223 * buildbot/steps/source.py: allow workdir= to be optional,
224 implement setDefaultWorkdir() since we don't inherit from
225 (CVS): finally remove old clobber=/export=/copydir= arguments,
226 in favor of the mode= argument that's been around forever now.
227 * buildbot/steps/transfer.py: remove build= argument
229 * buildbot/test/*.py: update to match, generally by turning all
230 build= arguments into subsequent calls to s.setBuild()
231 * buildbot/test/test_config.py (Factories): verify that we can
232 use either BuildStep instances or class/kwarg tuples in both
233 BuildFactory.addStep and BuildFactory.__init__
235 * docs/buildbot.texinfo (Build Steps): document the new approach,
236 mention compatibility with the old approach, update all examples
237 to use the new style.
239 2007-06-16 Brian Warner <warner@lothar.com>
241 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
242 the LoopingCall, just eat the failure so that we'll poll again
243 next time. This should allow us to tolerate (e.g.) sf.net SVN
244 failures more gracefully. Many thanks to Dustin Mitchell for the
247 2007-05-17 Brian Warner <warner@lothar.com>
249 * buildbot/status/words.py: refactor the IRC status bot into
250 separate 'Contact' and 'Channel' classes. The base Contact class
251 contains the interaction code: commands and responses. The
252 IRCContact subclass (and IrcStatusBot 'Channel') handle the
253 IRC-specific aspects. The plan is to write other subclasses for
254 other IM protocols like AIM and Jabber.
256 2007-04-16 Brian Warner <warner@lothar.com>
258 * CREDITS: update list of contributors. Thank you all!
260 2007-04-13 Brian Warner <warner@lothar.com>
262 * buildbot/status/mail.py (MailNotifier): add the project name to
263 the subject line and message body, to make it easier to
264 distinguish email coming from different buildmasters. Thanks to
265 Benoit Sigoure for the patch.
266 * buildbot/test/test_status.py (Mail): update to match
268 2007-03-24 Brian Warner <warner@lothar.com>
270 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
271 avoid text-conversion problems between DOS/windows and unix.
272 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
274 2007-03-03 Brian Warner <warner@lothar.com>
276 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
277 warning about the use of Waterfall here
279 2007-03-01 Brian Warner <warner@lothar.com>
281 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
283 2007-02-28 Brian Warner <warner@lothar.com>
285 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
286 Lamb to use a more optimal form of 'p4 changes', to reduce server
287 load. He reports that this optimization was added to p4d release
288 2005.2, but it should work in all versions. Closes #27.
289 * buildbot/test/test_p4poller.py: match it
291 2007-02-27 Brian Warner <warner@lothar.com>
293 * buildbot/status/web/*.py: move all web status stuff into a
294 separate directory, in anticipation of splitting it into smaller
295 pieces and adding more files. html.py was getting way too big.
296 * buildbot/status/classic.css: move it too
297 * setup.py: add the new sub-package
298 * buildbot/test/test_web.py: match the changes
299 * MANIFEST.in: handle the move of classic.css
301 2007-02-07 Brian Warner <warner@lothar.com>
303 * contrib/OS-X/*: add some launchd .plist files for automatically
304 starting a buildmaster or buildslave under OS-X (10.4 or later).
305 Thanks to Mark Pauley for these.
307 2007-02-06 Brian Warner <warner@lothar.com>
309 * docs/buildbot.texinfo (Requirements): update requirements to
310 stop claiming compatibility with python-2.2 or twisted-1.3.x .
312 * README: mention python-2.5 and twisted-2.5 compatibility
314 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
316 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
318 * buildbot/status/builder.py: same, by requiring cStringIO
319 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
320 * buildbot/test/test_vc.py: same
321 * buildbot/test/test_web.py:
322 * buildbot/test/test_steps.py: same, remove unused import
324 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
327 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
328 see any Builders that don't have Schedulers to drive them
330 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
331 attributes this uses went away
333 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
334 dialog, to allow you to reset the buildmaster and force
335 connect/disconnect. Correctly handle losing the buildmaster
336 connection (by switching the display to the hexnut, at which point
337 you can use the 'Connect' menu item to reconnect).
339 * buildbot/steps/source.py (Source.start): if we're using a patch,
340 add it as a LogFile to the checkout/update step. This will turn
341 into a link on the waterfall page.
343 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
344 option, to take the patch from a pre-made file rather than
345 generating it from the local tree. Thanks to Robert Helmer for the
346 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
347 * buildbot/scripts/runner.py (TryOptions): add --diff,
348 --patchlevel, and --baserev options
349 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
350 as None, meaning HEAD.
351 * buildbot/sourcestamp.py (SourceStamp): update docstring to
352 indicate that baserev=None means HEAD
353 * docs/buildbot.texinfo (try --diff): document it
355 * buildbot/test/test_steps.py (BuildStep): remove use of
356 reactor.iterate(), although the technique I replaced it with is a
357 gross polling hack that must be cleaned up properly some day. This
358 was the last use of reactor.iterate in the entire tree, yay.
360 2007-02-05 Brian Warner <warner@lothar.com>
362 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
363 is one of the three known values, otherwise we emit some confusing
364 messages later on. Thanks to Grig Gheorghiu for the catch.
366 2007-01-30 Brian Warner <warner@lothar.com>
368 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
369 Hearsum contributed a patch to let BonsaiPoller work with results
370 that contain non-ascii characters. Closes SF#1632641.
372 2007-01-27 Brian Warner <warner@lothar.com>
374 * Makefile (release): produce both .tar.gz and .zip source bundles.
377 2007-01-23 Brian Warner <warner@lothar.com>
379 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
380 * buildbot/changes/monotone.py: same
382 * buildbot/changes/maildir.py: combine several files into one,
383 clean up maildir.py to use Services properly.
384 * buildbot/changes/maildirtwisted.py: remove
385 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
387 * buildbot/changes/mail.py: match the change
388 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
389 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
391 * buildbot/slave/commands.py (command_version): bump to "2.3" to
392 indicate that the buildslave knows about the 'bzr' command
394 2007-01-22 Brian Warner <warner@lothar.com>
396 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
397 'with', it will become a reserved work in python2.6 .
399 * contrib/bb_applet.py: add a simple gnome-panel applet, to
400 display a terse summary of buildbot status.
401 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
402 some icons, small versions of the Blender object that lives in
403 docs/images/icon.blend
405 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
406 * buildbot/slave/commands.py (Bzr): same
407 * buildbot/scripts/tryclient.py (BzrExtractor): same
408 (SourceStampExtractor.dovc): modify this to allow non-zero exit
409 status, since 'bzr diff' does that
410 * buildbot/test/test_vc.py (Bzr): same
411 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
415 2007-01-20 Brian Warner <warner@lothar.com>
417 * contrib/darcs_buildbot.py: tidy up the progress messages
419 2007-01-17 Brian Warner <warner@lothar.com>
421 * contrib/darcs_buildbot.py: enhance to handle multiple patches
422 being pushed at a time. This keeps state in the repository in a
423 small file named .darcs_buildbot-lastchange, but that shouldn't
424 interfere with normal repository operations. Fixes SF#1534049.
425 * buildbot/clients/sendchange.py (Sender): make a single Sender
426 capable of sending Changes with different usernames.
428 2006-12-11 Brian Warner <warner@lothar.com>
430 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
431 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
432 buildbot.changes.mail a long time ago, but I forgot to add the
433 DeprecationWarning until now.
435 * buildbot/process/maxq.py: remove this, the functionality now
436 lives in buildbot.steps.maxq
438 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
439 * buildbot/clients/gtkPanes.py: remove unused import
441 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
442 that was meant to provide a special Reporter to run inside trial
443 and give the buildslave lots of machine-readable status. We never
444 finished this project.
446 * buildbot/changes/bonsaipoller.py: remove unused imports
447 * buildbot/changes/svnpoller.py: same
448 * buildbot/process/builder.py: same
449 * buildbot/process/buildstep.py: same
450 * buildbot/slave/bot.py: hush pyflakes warning
451 * buildbot/status/tests.py: remove unused imports
452 * buildbot/status/tinderbox.py: same
453 * buildbot/steps/python_twisted.py: same
455 * buildbot/process/step.py: remove this file, these names were
456 deprecated in 0.7.5 and are now being removed.
457 * buildbot/process/step_twisted.py: same
458 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
460 * buildbot/twcompat.py: remove the empty file, yay it is gone
462 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
463 tw-2.0.0 and newer have the method we need.
464 (getProcessOutputAndValue): same
465 (which): remove this method, tw-2.0.0 t.p.procutils has it
467 * buildbot/twcompat.py (implements): remove this method
468 * buildbot/*: import implements() from zope.interface directly
470 * buildbot/status/mail.py: stop falling back to importing
471 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
474 * buildbot/twcompat.py (Interface): remove this import
475 * buildbot/*: import Interface from zope.interface directly
477 * buildbot/twcompat.py (providedBy): remove this method
478 * buildbot/*: turn all uses of providedBy(obj, iface) into
479 iface.providedBy(obj)
481 * buildbot/twcompat.py (maybeWait): remove this method, now that
482 we no longer maintain compatibility with Twisted<=1.3.0 .
483 Twisted-2.0.0 and later allow trial methods to return Deferreds
485 * buildbot/test/*: remove all uses of maybeWait
487 * buildbot/__init__.py (version): bump to 0.7.5+ while between
489 * docs/buildbot.texinfo: same
491 2006-12-10 Brian Warner <warner@lothar.com>
493 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
494 * docs/buildbot.texinfo: set version to match
496 2006-12-10 Brian Warner <warner@lothar.com>
498 * README (REQUIREMENTS): update for release
499 * NEWS: update for release
500 * buildbot/slave/commands.py (command_version): mention that this
501 version (2.2) was released with buildbot-0.7.5
503 * buildbot/test/test_config.py (StartService.testStartService):
504 inhibit the usual read-config-on-startup behavior, since otherwise
505 the log.err that gets recorded causes the test to fail
507 * buildbot/status/builder.py (LogFile.finish): forget about all
508 subscribers once the log has finished, since after that point
509 we're never going to use them again. This might help free up some
512 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
513 than the old/deprecated gtk.mainquit()
515 2006-12-09 Brian Warner <warner@lothar.com>
517 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
518 better when we can't open the masterdst file
520 * buildbot/scripts/startup.py (Follower._failure): add missing
521 import statement for BuildSlaveDetectedError
523 * buildbot/steps/transfer.py (FileUpload): cleanup
524 (FileDownload): same. Add tests for slave version, add mode=.
525 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
526 (SlaveFileDownloadCommand): same
527 * buildbot/test/test_transfer.py: enhance tests
528 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
531 2006-12-08 Brian Warner <warner@lothar.com>
533 * buildbot/scripts/runner.py (sendchange): halt the reactor on
534 both success *and* failure. Without this, the 'buildbot
535 sendchange' command would hang if it could not contact the
536 buildmaster or deliver the Change, which would generally cause the
537 user's commit/record/checkin command to hang too. Thanks to
538 Christian Unger for the catch.
540 2006-12-06 Brian Warner <warner@lothar.com>
542 * NEWS: update with items for the next release
544 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
545 whimsical example pulled from a punch-drunk email I sent out late
547 (Transferring Files): document some of the other parameters
548 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
549 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
550 * buildbot/test/test_svnpoller.py: same
551 * buildbot/changes/svnpoller.py (SVNPoller): same
553 2006-11-26 Brian Warner <warner@lothar.com>
555 * docs/buildbot.texinfo (Build Properties): remind users that
556 WithProperties must appear in a command= list, not as a top-level
558 * buildbot/steps/shell.py (ShellCommand.start): and assert that
559 we're sending a list or a single string to the RemoteShellCommand
561 * buildbot/scheduler.py (Nightly): Improve docs slightly.
563 * buildbot/scripts/startup.py (start): skip the whole
564 watch-the-logfile thing under windows, since it needs os.fork()
566 * buildbot/scripts/runner.py (restart): remove the old message
567 that got printed after the buildbot was restarted.. it most cases
568 it didn't get printed at the right time anyways
570 2006-11-25 Brian Warner <warner@lothar.com>
572 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
573 follow twistd.log and print lines until the process has started
574 started properly. For the buildmaster, this means until the config
575 file has been parsed and accepted. For the buildslave, this means
576 until we've connected to the master. We give up after 5 seconds in
577 any case. Helpful error messages and troubleshooting suggestions
578 are printed when we don't see a successful startup. This closes the
579 remainder of SF#1517975.
580 * buildbot/scripts/startup.py: moved app startup code to here
581 * buildbot/scripts/logwatcher.py: utility class to follow log
582 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
583 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
584 so the LogWatcher can tell the difference between a buildmaster
587 2006-11-24 Brian Warner <warner@lothar.com>
589 * docs/examples/twisted_master.cfg: update to match the version
590 in use on twistedmatrix.com
591 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
592 was using before stopped working, but 'irc.freenode.net' works
595 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
598 * buildbot/clients/base.py (TextClient.not_connected): upon
599 UnauthorizedLogin failures, remind the user to connect to the
600 PBListener port instead of the slaveport.
601 (TextClient.disconnected): shut down more quietly
602 * docs/buildbot.texinfo (statuslog): add another reminder
604 * buildbot/scripts/runner.py (Options.subCommands): rename
605 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
606 'sighup' as an alias.
607 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
608 reconfig command to follow twistd.log and print all of the lines
609 from the start of the config-file reload to its completion. This
610 should make it a lot easier to discover bugs in the config file.
611 Use --quiet to disable this behavior. This addresses half of
612 SF#1517975, the other half will be to add this same utility to
613 'buildbot start' and 'buildbot restart'.
614 * docs/buildbot.texinfo (Loading the Config File): same
617 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
618 method, it has been deprecated for a long time. Use
619 IBuilderControl.requestBuild instead.
620 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
621 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
622 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
623 * buildbot/test/test_control.py (Force.testForce): same
624 * buildbot/test/test_run.py: use requestBuild instead
626 * buildbot/clients/debug.py: replace 'Force Build' button with
627 'Request Build' (which just adds one to the queue), add Ping
628 Builder, add branch/revision fields to Request Build.
629 * buildbot/clients/debug.glade: same
630 * buildbot/master.py: update interface to match. This creates an
631 incompatibility between new debugclients and old buildmasters.
633 * buildbot/process/builder.py (Builder._attached): delay the call
634 to maybeStartBuild for a reactor turn, to avoid starting a build
635 in the middle of a reconfig (say, if the new Builder uses a new
636 slave which is already connected).
638 2006-11-23 Brian Warner <warner@lothar.com>
640 * buildbot/test/test_transfer.py: appease pyflakes
641 * buildbot/test/test_steps.py: same
643 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
644 keeps pyflakes from finding undefined names
646 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
647 Builder no longer induces a disconnect/reconnect cycle. This means
648 that any builds currently in progress will not be interrupted, and
649 any builds which are queued in the Builder will not be lost. This
650 is implemented by having the new Builder extract the state (i.e.
651 all pending Builds and any desired SlaveBuilders) from the old
653 (BotPerspective): refactor. The BotPerspective no longer keeps
654 track of all the Builders that want to use this slave; instead, it
655 asks the BotMaster each time it needs this list. This removes
656 addBuilder and removeBuilder. Clean up attached() to acquire all
657 the slave's information in a more atomic fashion. updateSlave() is
658 now the way to make sure the slave is using the right set of
659 Builders: just call it after everything else has been
661 (BotMaster): refactor, removing addBuilder/removeBuilder and
662 replacing them with an all-at-once setBuilders() call.
664 * buildbot/test/test_slaves.py (Reconfig): new test case to
665 exercise this functionality
666 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
667 * buildbot/slave/commands.py (WaitCommand): same
669 * docs/buildbot.texinfo (Loading the Config File): document the
672 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
673 SlaveBuilder to have its parent Builder changed.
674 (SlaveBuilder.isAvailable): new method to give access to state,
675 which is now a private attribute
676 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
677 the SlaveBuilder about how it is being used. These methods update
678 its internal state. buildFinished() is now the place that invokes
679 maybeStartBuild() on its parent Builder.
680 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
681 new Builder to take over for an old one, transferring state from
683 (Buider): refactor the way that SlaveBuilders are used to match,
684 giving them a bit more autonomy.
685 (Builder.buildFinished): this no longer calls maybeStartBuild():
686 instead the SlaveBuilder calls it on whoever its parent Builder is
687 at the time. This way, when an old Builder is replaced by a new
688 one, and there was a build in progress during the transition, when
689 that build finishes, it will be the new Builder that is told about
690 the newly available slave so it can start a new build.
692 * buildbot/process/base.py (Build.startBuild._release_slave): when
693 the Build finishes, tell the SlaveBuilder that they've been
696 * buildbot/status/builder.py (SlaveStatus): add some new setter
697 methods for use by BotPerspective, to keep some attributes more
700 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
701 called by the buildmaster.
702 (Bot.setBuilderList): instead, we locally announce any leftover
703 directories based upon which Builders we were told about. The
704 master doesn't really care; it's the local admin who may or may not
708 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
709 to allow use of python2.4 or whatever. This tool still requires
712 2006-11-19 Brian Warner <warner@lothar.com>
714 * NEWS (IStatusLog.readlines): more news items
716 2006-11-18 Brian Warner <warner@lothar.com>
718 * NEWS: start collecting items for the next release.
720 2006-11-04 Brian Warner <warner@lothar.com>
722 * buildbot/changes/bonsaipoller.py: apply updates from Ben
723 Hearsum. Closes SF#1590310.
724 * buildbot/test/test_bonsaipoller.py: and tests
726 * buildbot/status/tinderbox.py
727 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
728 status when the build results in WARNINGS. Patch from Dave
729 Liebreich. Closes SF#1587352.
731 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
732 linux-vs-osx behavior difference w.r.t. reading from files that
733 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
734 to Mark Rowe for the patch.
736 2006-10-15 Brian Warner <warner@lothar.com>
738 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
739 method name was misspelled in the interface definition. Thanks to
740 Roy Rapoport for the catch.
742 2006-10-13 Brian Warner <warner@lothar.com>
744 * docs/buildbot.texinfo (Adding LogObservers): update sample code
745 to match the great Steps renaming
747 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
748 Maybe I should run my own unit tests before recording a big
749 change. Good thing I've got a buildbot to remind me.
751 2006-10-12 Brian Warner <warner@lothar.com>
753 * buildbot/steps/transfer.py: rework __init__ and args setup
754 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
756 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
757 when opening the target file, only catch IOError (to report via
758 stderr/rc!=0), let the others be reported as normal exceptions
760 2006-10-08 Brian Warner <warner@lothar.com>
762 * contrib/svn_watcher.py: fix security holes by using proper argv
763 arrays and subprocess.Popen() rather than commands.getoutput().
764 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
765 is deprecated in favor of buildbot/changes/svnpoller.py, and will
766 probably be removed by the next release.
769 2006-10-04 Brian Warner <warner@lothar.com>
771 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
772 initial lines that weren't emitted by pyflakes. When the pyflakes
773 command is run under a Makefile, 'make' will echo the command it
774 runs to stdio, and that was getting logged as a "misc" warning.
775 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
776 * buildbot/test/test_steps.py (testPyFlakes3): another test
778 2006-10-01 Brian Warner <warner@lothar.com>
780 * buildbot/status/html.py (HtmlResource.render): if we get a
781 unicode object from our content() method, encode it into utf-8
782 like we've been claiming to all along. This allows the comments
783 and author names from svnpoller.py to be delivered properly.
785 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
786 de-unicodify filenames before creating the Change, because the
787 rest of buildbot is unlikely to handle them well. Leave the 'who'
788 field as a unicode object.. I don't think there's anything that
789 will break very soon, and it will probably nudge us towards
790 accepting unicode everywhere sooner or later. Stop using the
791 "date" field that comes out of SVN, since it is using the
792 repository's clock (and timezone) and what we care about is the
793 buildmaster's (otherwise Changes from the future show up later
794 than the builds they triggered).
795 * buildbot/test/test_svnpoller.py (Everything.test1): match the
798 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
799 Suvbersion repository polling ChangeSource. I've hacked it up
800 considerably: any bugs are entirely my own fault. Thank you
802 * buildbot/test/test_svnpoller.py: tests for it
803 * docs/buildbot.texinfo (SvnSource): document it
805 2006-09-30 Brian Warner <warner@lothar.com>
807 * buildbot/scheduler.py (Periodic): submit a reason= to the
808 BuildSet to indicate which Scheduler triggered the build. Thanks
809 to Mateusz Loskot for the suggestion.
811 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
813 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
814 changes: set self.loop in __init__, remove unused volatile=
816 * docs/buildbot.texinfo (.buildbot config directory): add more
817 docs on the .buildbot/options keys used by "buildbot try"
818 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
819 (Try.deliverJob): same
821 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
825 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
826 close the filehandle when we stop watching the file. Before, the
827 filehandle was only closed when the LogFileWatcher was
828 garbage-collected, which could be quite a while in the future. If
829 it was still open by the time the next build started, windows will
830 refuse to let the new build delete the old build/ directory. Fixes
831 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
832 #twisted for the catch.
834 2006-09-29 Brian Warner <warner@lothar.com>
836 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
839 2006-09-25 Brian Warner <warner@lothar.com>
841 * setup.py: the new buildbot.steps module wasn't being installed.
842 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
843 (testmsgs): add the extra stuff from buildbot/test/* so you can
844 run unit tests on an installed copy of buildbot, not just from
847 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
848 columns of 'svnlook changed' output contain status information, so
849 strip [:4] instead of [:6]. Depending upon what the status flags
850 were, this would sometimes lead to mangled filenames. Thanks to
851 Riccardo Magliocchetti for the patch. Closes SF#1545146.
853 * buildbot/steps/source.py (Monotone): initial Monotone support,
854 contributed by Nathaniel Smith. Still needs docs and tests, but
855 this code has been in use on the Monotone buildbot for a long
857 * buildbot/slave/commands.py (Monotone): slave-side support
858 * buildbot/changes/monotone.py (MonotoneSource): polling change
861 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
862 contributed a Change Source that polls a Bonsai server (a
863 kind of web-based viewcvs CGI script).
865 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
866 Hearsum contributed a status plugin which sends email in the same
867 format that Tinderbox does: this allows a number of tinderbox
868 tools to be driven by Buildbot instead. Thanks Ben!
870 2006-09-24 Brian Warner <warner@lothar.com>
872 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
873 Thanks to Robert Helmer for the patch.
875 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
876 BuildStatus about the buildslave name at the *beginning* of the
877 build, rather than at the end. Thanks to Alexander Lorenz for the
879 * buildbot/status/html.py (StatusResourceBuild.body): always
880 include the slavename in the build page, not just when the build
882 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
883 slavename in the email message
885 2006-09-21 Brian Warner <warner@lothar.com>
887 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
889 * docs/examples/glib_master.cfg: same
890 * docs/examples/hello.cfg: same
891 * docs/examples/twisted_master.cfg: same, update to current usage
893 2006-09-19 Brian Warner <warner@lothar.com>
895 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
896 (PyFlakes.createSummary): make it compatible with python-2.2
898 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
899 for at least the output-parsing parts of PyFlakes
901 2006-09-18 Brian Warner <warner@lothar.com>
903 * buildbot/steps/python.py: oops, fix import of StringIO
905 2006-09-17 Brian Warner <warner@lothar.com>
907 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
908 turns out that SVN-1.4.0 doesn't fail to update once you've
909 replaced a file with a directory, unlike older versions of SVN and
910 pretty much every other VC tool we support. Since what we really
911 care about is that the update succeeds anyway, stop checking that
912 the tree got clobbered and just assert that the build succeeded.
913 (VCBase.printLogs): add a utility function for debugging
915 * buildbot/process/step.py: oops, added extra imports by mistake
917 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
918 rstrip() on the first line coming out of the 'p4 describe'
919 process, to remove the stray ^M that Wade Brainerd reports seeing
920 in the 'when' field. Fixes SF#1555985.
922 * buildbot/master.py (BuildMaster.loadConfig): improve the error
923 message logged when c['schedulers'] is not right
924 * buildbot/scheduler.py (Scheduler.__init__): improve error
925 message when a Scheduler() is created with the wrong arguments
926 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
927 verify that these error messages are emitted
929 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
930 The idea is that all the base classes (like BuildStep and
931 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
932 will be a leftover backwards-compatibility file that only contains
933 aliases for the steps that were moved out to buildbot.steps.*
934 * lots: change imports to match
935 * buildbot/process/step.py: add a DeprecationWarning if it ever
938 2006-09-12 Brian Warner <warner@lothar.com>
940 * buildbot/scheduler.py (Scheduler.__init__): make sure that
941 builderNames= is actually a sequence, since if you happen to give
942 it a single builder-specification dictionary instead, it won't get
943 caught by the existing assert. Thanks to Brett Neely for the
946 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
948 * docs/buildbot.texinfo (Python BuildSteps): document them
949 (sendchange): include a link to PBChangeSource, since you need one
951 * buildbot/steps/shell.py: clean up test-case-name line, remove some
953 * buildbot/steps/dummy.py: same
955 2006-09-08 Brian Warner <warner@lothar.com>
957 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
958 BuildStep which lets you transfer files from the master to the
959 slave or vice versa. Thanks to Albert Hofkamp for the original
960 patch. Fixes SF#1504631.
961 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
963 (SlaveFileDownloadCommand): same
964 * docs/buildbot.texinfo (Transferring Files): document it
965 * buildbot/test/test_transfer.py: test it
966 * buildbot/test/runutils.py (StepTester): new utility class for
967 testing BuildSteps and RemoteCommands without Builds or Bots or PB
968 * buildbot/test/test_steps.py (CheckStepTester): validate that the
971 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
972 walk through StatusLogs one line at a time, mostly for the benefit
973 of ShellCommand.createSummary methods. You can either walk through
974 STDOUT or STDERR, but the default is STDOUT.
976 * buildbot/status/builder.py (LogFile.readlines): implement it.
977 Note that this is not yet memory-efficient, it just pulls the
978 whole file into RAM and then splits it up with a StringIO.
979 Eventually this should be a generator that only pulls chunks from
981 * buildbot/test/test_status.py (Log.testReadlines): test it
983 * docs/buildbot.texinfo: update to match changes
984 * buildbot/process/factory.py: stop using old definitions
985 * buildbot/process/process_twisted.py: same
986 * buildbot/test/test_*.py: same
988 * buildbot/process/step_twisted.py: move definition to..
989 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
990 relative-import mechanisms prevent this from being named 'twisted'
991 or 'python/twisted' as I would have preferred.
993 * buildbot/process/maxq.py: move definition to..
994 * buildbot/steps/maxq.py: .. here, leave a compatibility import
996 * buildbot/process/step.py: split the user-visible BuildSteps into
997 separate files, all under buildbot/steps/
998 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
999 * buildbot/steps/shell.py: this holds ShellCommand and friends
1000 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1002 2006-09-05 Brian Warner <warner@lothar.com>
1004 * lots: run pyflakes, removed a lot of unused imports, changed the
1005 form of some conditional imports to remove false pyflakes
1006 warnings. There are still a number of warnings left, mostly from
1007 imports that are done for their side-effects.
1008 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1011 2006-08-26 Brian Warner <warner@lothar.com>
1013 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1014 compatible with twisted-1.3.0, for some reason I just can't seem
1015 to let go of the past.
1017 2006-08-25 Brian Warner <warner@lothar.com>
1019 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1021 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1022 all logfiles= in startCommand(), rather than in start() . This
1023 makes it easier to have the 'stdio' log come before any secondary
1024 logfiles, which I feel makes the waterfall display more
1026 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1027 from ShellCommand up into LoggingBuildStep
1028 (LoggingBuildStep.__init__): move the handling of logfiles= from
1029 ShellCommand up to LoggingBuildStep, because startCommand is
1030 provided by LoggingBuildStep, whereas start() was specific to
1031 subclasses like ShellCommand and Source. This removes code
1032 duplication in those subclasses.
1033 (ShellCommand.__init__): same
1034 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1035 for a slave that's too old to understand logfiles= into a separate
1036 method, so it can live in ShellCommand. The rest of
1037 setupLogfiles() can live in LoggingBuildStep.
1039 2006-08-24 Brian Warner <warner@lothar.com>
1041 * buildbot/locks.py (BaseLock): you can now configure Locks to
1042 allow multiple simultaneous owners. They still default to
1043 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1045 * docs/buildbot.texinfo (Interlocks): document the new options
1046 * buildbot/test/test_locks.py: add a bunch of new unit tests
1047 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1048 waitUntilMaybeAvailable, not waitUntilAvailable
1049 * buildbot/process/step.py (BuildStep.acquireLocks): same
1050 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1051 the whole lockid in their constructor, not just the name. Also,
1052 keep track of which real locks we've handed out by the full
1053 lockid, not just class+name, otherwise changing just the maxCount=
1054 in the master.cfg file would not actually cause a behavioral
1057 2006-08-23 Brian Warner <warner@lothar.com>
1059 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1061 * docs/buildbot.texinfo: same
1063 2006-08-23 Brian Warner <warner@lothar.com>
1065 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1066 * docs/buildbot.texinfo: set version to match
1067 * NEWS: update for 0.7.4
1068 * buildbot/slave/commands.py (command_version): mention that this
1069 version (2.1) was released with buildbot-0.7.4
1071 2006-08-22 Brian Warner <warner@lothar.com>
1075 * CREDITS: new file, list of people who have helped. Thanks!
1076 * MANIFEST.in: ship it
1078 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1079 new diagrams, the user's manual is more informative than it was.
1080 Start shipping the .html user's manual (and generated .png
1082 * Makefile: update 'release' target to match
1084 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1085 test.. I think the web-parts effort will render it pointless well
1086 before it ever actually starts to work.
1088 2006-08-20 Brian Warner <warner@lothar.com>
1090 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1091 meaning of the prefix= argument. It is now just a string which is
1092 stripped from the beginning of the filename. If prefix= is set but
1093 not found on any given filename, that filename is ignored. If all
1094 filenames in a Change are ignored, the Change is dropped. This is
1095 much simpler than the previous sep= nonsense, and I should have
1096 implemented it this way from the beginning. Effectively resolves
1097 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1098 Gedminas for the catch and suggested fixes.
1099 (ChangePerspective.perspective_addChange): implement the actual
1101 * buildbot/test/test_changes.py (TestChangePerspective): test it
1102 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1103 how to properly use prefix=
1104 * docs/examples/twisted_master.cfg (source): update prefix= by
1105 adding the trailing slash
1108 * docs/examples/twisted_master.cfg: update to actual practice
1110 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1111 update test case to match new link text.. the HREF has both a
1112 class= setting and an enclosing [] pair that I didn't match in the
1115 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1116 list of strings is preferred over a single string with embedded
1118 (ShellCommand.description=): explain that either single strings or
1119 a list of strings is acceptable, and why you might prefer one over
1120 the other. Add an example. Fixes SF#1524659, thanks to Paul
1121 Winkler for the catch.
1122 (Build Steps): update to use f.addStep() rather than using s()
1123 and the constructor list
1125 * buildbot/process/step.py (ShellCommand): accept either a single
1126 string or a list of strings in both description= and
1128 * buildbot/test/test_steps.py (Steps.test_description): test it
1129 * buildbot/test/runutils.py (makeBuildStep): support for that test
1131 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1132 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1133 collecting the files and creating the patch.
1135 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1136 per-step URLs that will be displayed on the waterfall display,
1137 for things like the HTML output of code-coverage tools, when
1138 the results are hosted elsewhere.
1139 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1140 way to retrieve these URLs
1141 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1142 the method to retrieve these URLs. Also provide backwards
1143 compatibility for saved BuildStepStatus instances that didn't have
1145 * buildbot/process/step.py (BuildStep.addURL): method to set these
1146 URLs from within a BuildStep
1147 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1148 (StepBox.getBox): give these external links a distinct CSS class
1149 named "BuildStep external" so a .css file can display them
1152 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1154 * buildbot/test/test_steps.py (Steps): test that we can all the
1155 URLs. Also add a bunch of other tests on methods that can be
1156 called from within BuildSteps
1157 * buildbot/test/runutils.py (makeBuildStep): add utility function
1159 2006-08-13 Brian Warner <warner@lothar.com>
1161 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1163 2006-08-10 Brian Warner <warner@lothar.com>
1165 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1166 index, this one of things like c['sources'] and c['schedulers']
1167 (indices): it looks like my clever idea of putting the @fooindex
1168 commands in between the @node and the @subsection (to make the
1169 HREF anchor jump to slightly above the section title, which works
1170 much better in html) confused texinfo horribly, so I'm moving the
1171 index tags back to be just after the @subsection marker. I also
1172 added extra lines between the @node/@section paragraph and the
1173 index tags, since I think maybe texinfo wants to see these be
1174 separate paragraphs.
1176 * docs/Makefile (images): make sure images get built when
1177 rendering the manual
1178 * docs/images/Makefile: same
1180 * buildbot/scripts/runner.py: rename 'buildbot master' to
1181 'buildbot create-master', and 'buildbot slave' to 'buildbot
1183 * docs/buildbot.texinfo: same
1186 * docs/buildbot.texinfo: reimplement the "useful classes" index
1187 with actual texinfo indices. The .info rendering is a bit
1188 weird-looking but it works well, and the HTML rendering is quite
1189 nice. This also puts the index targets in the regular flow of the
1190 text, which is easier to maintain.
1192 2006-08-06 Brian Warner <warner@lothar.com>
1194 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1195 Kevin Turner to prefer the environ= argument be a list rather than
1196 a string. If it is a list, it will be joined with a platform-local
1197 os.pathsep delimiter, and then prepended to any existing
1198 $PYTHONPATH value. This works better in cross-platform (i.e.
1199 windows buildslaves) environments when you need to push multiple
1200 directories onto the front of the path.
1201 (SlaveShellCommand): documented the new magic
1202 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1203 in a user-visible form
1205 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1206 Turner to prefer lists over strings when creating/running VC
1207 commands during unit tests. This is clearly necessary to survive
1208 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1209 renamed the wq() function to qw() though, since that's how it's
1210 spelled in perl. Eventually I'd prefer all commands to be
1211 specified with lists.
1213 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1214 which are deleted (or not yet created) correctly. Also add
1215 failsafe code to not explode if the file-watching poller doesn't
1216 get started. Thanks to JP Calderone for the catch and the poller
1218 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1220 * buildbot/test/emitlogs.py: same
1222 * NEWS: summarize recent changes
1224 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1225 clause to avoid the "host key mismatch" warning
1227 * buildbot/process/step_twisted.py (Trial.start): if the
1228 buildslave is too old to understand logfiles=, fall back to
1229 running 'cat _trial_temp/test.log' like before.
1230 (Trial.commandComplete): same. this takes advantage of the
1231 LoggingBuildStep refactoring to stall commandComplete long enough
1232 to run a second RemoteShellCommand.
1234 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1235 refactor command-completion handling, to allow methods like
1236 commandComplete/createSummary/evaluateCommand to return Deferreds.
1237 (LoggingBuildStep._commandComplete): delete the refactored method
1238 (ShellCommand.setupLogfiles): if the buildslave is too old to
1239 understand logfiles=, put a warning message both into twistd.log
1240 and into the otherwise empty user-visible LogFiles.
1242 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1243 callers to provide the slave-side logfile name, rather than
1244 forcing it to come from the local name of the LogFile.
1245 (BuildStep.getSlaveName): new method
1247 * buildbot/process/base.py (Build.getSlaveName): new method, so
1248 steps can find out which buildslave they're running on
1250 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1251 to match the s/cvs_ver/command_version/ change
1253 2006-08-05 Brian Warner <warner@lothar.com>
1255 * buildbot/slave/commands.py (command_version): replace the CVS
1256 auto-updated cvs_ver keyword with a manually-updated variable,
1257 since CVS is no longer the master repository. Add a description of
1258 the remote API change starting in this version (2.1), specifically
1259 the fact that SlaveShellCommand now accepts 'initial_stdin',
1260 'keep_stdin_open', and 'logfiles'.
1262 2006-07-31 Brian Warner <warner@lothar.com>
1264 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1265 diagrams to describe how the whole system fits together. The
1266 images themselves are kept in SVG files, with ascii-art versions
1267 in corresponding .txt files. Texinfo knows how to interpolate the
1268 text version into .info files, reference the .png versions from
1269 .html files, and include .eps versions in the .ps format.
1270 * docs/images/Makefile: tools to create .png and .eps
1271 * docs/images/*.svg: created pictures with Inkscape.
1272 * .darcs-boring: ignore the generated .eps and .png files
1274 2006-07-24 Brian Warner <warner@lothar.com>
1276 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1277 Scheduler names, since they cause setServiceParent to explode
1279 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1281 2006-07-20 Brian Warner <warner@lothar.com>
1283 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1284 which runs the buildbot unit tests
1286 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1287 classes that are useful in master.cfg
1289 2006-07-15 Brian Warner <warner@lothar.com>
1291 * Makefile (some-apidocs): new target to build only some epydocs
1293 * setup.py: minor comment.. does the classifiers= argument prevent
1294 the setup.py script from working on python2.2/2.3?
1296 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1299 * buildbot/twcompat.py: fix minor typo in comments
1301 * buildbot/manhole.py: move all Manhole-related code out to this
1302 module. Implement SSH-based manholes (with TwistedConch), and move
1303 to conch's nifty line-editing syntax-coloring REPL shell instead
1304 of the boring non-editing monochromatic (and deprecated) old
1306 * buildbot/master.py: remove all Manhole-related code
1307 (BuildMaster.loadConfig._add): make sure the old manhole is
1308 removed before we add the new one
1309 * docs/buildbot.texinfo (Debug options): document new Manhole options
1311 * buildbot/twcompat.py (_which): fix some epydoc issues
1312 * buildbot/status/html.py (Waterfall.__init__): same
1314 2006-06-29 Brian Warner <warner@lothar.com>
1316 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1317 deprecation warnings under newer Twisteds (by using
1318 zope.interface.Interface instead of old twisted.python.components
1320 * buildbot/slave/interfaces.py: same
1322 2006-06-28 Brian Warner <warner@lothar.com>
1324 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1325 svn commands, so it will fail immediately instead of hanging while
1326 it waits for a username/password to be typed in.
1328 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1329 log message if the step was shut down
1331 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1332 obsolete reference to mktap.
1334 2006-06-20 Brian Warner <warner@lothar.com>
1336 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1337 test to include new 'logfiles' argument sent from master to slave
1339 2006-06-19 Brian Warner <warner@lothar.com>
1341 * buildbot/process/step_twisted.py (Trial): track Progress from
1342 _trial_temp/test.log too
1344 * buildbot/process/step.py (OutputProgressObserver): generalize
1345 the earlier StdioProgressObserver into an OutputProgressObserver
1346 that can track LogFiles other than stdio.
1347 (LoggingBuildStep.__init__): same
1349 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1350 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1351 will fail under windows because of os.sep issues. It might have
1352 worked before if 'cat' was doing cygwin path conversion.
1354 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1355 creation of LogFileWatchers
1356 (ShellCommand._startCommand): and record the files that were
1357 watched in the 'headers' section of the ShellCommand output
1359 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1360 need to actually pass it to the slave if you want it to work.
1361 (ShellCommand): document it a bit
1363 * buildbot/test/test_shell.py: new test to validate LogFiles
1364 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1366 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1367 before printing the last batch of lines, to test that the polling
1368 logic is working properly
1370 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1371 handling, making it possible to track multiple logs for a single
1372 RemoteCommand. The previous single logfile is now known as the
1374 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1375 (RemoteShellCommand.__init__): accept logfiles=
1376 (LoggingBuildStep.startCommand): stdio_log is now one of many
1377 (ShellCommand): added logfiles= argument, as well as a class-level
1378 .logfiles attribute, which will be merged together to figure out
1379 which logfiles should be tracked. The latter maybe be useful for
1380 subclasses of ShellCommand which know they will aways produce
1381 secondary logfiles in the same location.
1383 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1384 and closeStdin() methods, preparing to make it possible to write
1385 to a ShellCommand's stdin at any time, not just at startup. These
1386 writes are buffered if the child process hasn't started yet.
1387 (LogFileWatcher): new helper class to watch arbitrary logfiles
1388 while a ShellCommand runs. This class polls the file every two
1389 seconds, and sends back 10k chunks to the buildmaster.
1390 (ShellCommand): rename stdin= to initialStdin=, and add
1391 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1393 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1394 key of "log" and a value of (logname, data).
1395 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1396 'logfiles' to the master-visible args dictionary.
1397 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1400 * buildbot/test/test_vc.py (Patch.testPatch): same
1403 * buildbot/test/emit.py: write to a logfile in the current
1404 directory. We use this to figure out what was used as a basedir
1405 rather than looking to see which copy of emit.py gets run, so that
1406 we can run the commands from inside _trial_temp rather than inside
1408 * buildbot/test/subdir/emit.py: same
1409 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1410 argument rather than running from buildbot/test/
1411 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1412 rather than using an implicit setUp()
1413 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1414 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1415 of assuming that we're running in buildbot/test/ (and that '.' is
1418 * buildbot/slave/commands.py (Command.doStart): refactor Command
1419 startup/completion a bit: now the SlaveBuilder calls doStart(),
1420 which is not meant for overridding by subclasses, and doStart()
1421 calls start(), which is. Likewise the SlaveBuilder calls
1422 doInterrupt(), and subclasses override interrupt(). This also puts
1423 responsibility for maintaining .running in Command rather than in
1425 (Command.doInterrupt): same
1426 (Command.commandComplete): same, this is called when the deferred
1427 returned by start() completes.
1428 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1429 (SlaveBuilder.remote_interruptCommand): same
1430 (SlaveBuilder.stopCommand): same
1432 2006-06-16 Brian Warner <warner@lothar.com>
1434 * buildbot/test/test_shell.py: new test file to contain everything
1435 relating to ShellCommand
1436 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1437 multiple logfiles in realtime" feature, not yet implemented
1438 * buildbot/test/emitlogs.py: support file for testLogFiles
1439 * docs/buildbot.texinfo (ShellCommand): document the feature
1441 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1443 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1444 for tests which exercise SlaveCommands in isolation.
1446 * buildbot/test/test_slavecommand.py: Move some utilities like
1447 SignalMixin and FakeSlaveBuilder from here ..
1448 * buildbot/test/runutils.py: .. to here, so they can be used by
1449 other test classes too
1450 * buildbot/test/test_vc.py: more SignalMixin refactoring
1451 * buildbot/test/test_control.py: same
1452 * buildbot/test/test_run.py: and some rmtree refactoring
1454 2006-06-15 Brian Warner <warner@lothar.com>
1456 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1457 'testBranch' to match other VC tests and have the tests run in
1458 roughly increasing order of dependency
1460 * buildbot/test/test_steps.py (LogObserver): new test to verify
1461 LogObservers can be created at various times and still get
1462 connected up properly
1464 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1465 to create BuildStepStatus instances that actually work.
1467 * buildbot/process/step.py (LogObserver): add outReceived and
1468 errReceived base methods, to be overridden
1470 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1471 API to take a name instead of a step, reducing the coupling
1472 somewhat. This returns the BuildStepStatus object so it can be
1473 passed to the new Step, instead of jamming it directly into the
1475 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1477 * buildbot/process/base.py (Build.setupBuild): use both methods
1478 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1479 process a bit to match
1481 2006-06-14 Brian Warner <warner@lothar.com>
1483 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1484 docs on writing new LogObserver classes
1485 (Writing New Status Plugins): brief docs on how Status Plugins fit
1488 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1489 implement a LogObserver that counts how many unit tests have been
1491 (Trial.__init__): wire it in
1492 * buildbot/test/test_twisted.py (Counter): unit test for it
1494 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1495 to new cmd.logs['stdio'] scheme
1496 (Trial.commandComplete): same
1497 (BuildDebs.commandComplete): same
1499 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1500 LogFiles, instead of just a single one. The old single logfile is
1501 now called "stdio". LoggedRemoteCommand no longer creates a
1502 LogFile for you (the code to do that was broken anyway). If you
1503 don't create a "stdio" LogFile, then stdout/stderr will be
1505 (LogObserver): implement "LogObservers", which a BuildStep can add
1506 to parse the output of a command in real-time. The primary use is
1507 to provide more useful information to the Progress code, allowing
1508 better ETA estimates.
1509 (LogLineObserver): utility subclass which feeds complete lines to
1510 the parser instead of bytes.
1511 (BuildStep.progressMetrics): this is safer as a tuple
1512 (BuildStep.setProgress): utility method, meant to be called by
1514 (BuildStep.addLogObserver): new method, to be called at any time
1515 during the BuildStep (even before any LogFiles have been created),
1516 to attach (or schedule for eventual attachment) a LogObserver to a
1518 (StdioProgressObserver): new LogObserver which replaces the old
1519 "output" progress gatherer
1520 (LoggingBuildStep.__init__): same
1521 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1522 (LoggingBuildStep._commandComplete): must use logs['stdio']
1523 instead of the old single ".log" attribute.
1524 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1525 functionality, now subsumed into StdioProgressObserver
1526 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1527 log name changed from "output" to "stdio".
1530 * buildbot/interfaces.py (ILogFile): add the Interface used from
1531 the BuildStep towards the LogFile
1532 (ILogObserver): and the one provided by a LogObserver
1533 * buildbot/status/builder.py (LogFile): implement it
1535 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1536 HEADER constants here ..
1537 * buildbot/status/builder.py (STDOUT): .. from here
1539 2006-06-13 Brian Warner <warner@lothar.com>
1541 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1542 compatibility with python2.2, which doesn't have the 'substr in
1544 (TestP4Poller.makeTime): utility function to construct the
1545 timestamp using the same strptime() approach as p4poller does. It
1546 turns out that time.mktime() behaves slightly differently under
1547 python2.2, probably something to do with the DST flag, and that
1548 causes the test to fail under python2.2. (changing the mktime()
1549 arguments to have dst=0 instead of -1 caused it to fail under
1550 python2.3. Go figure.)
1551 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1553 2006-06-12 Brian Warner <warner@lothar.com>
1555 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1556 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1557 contributing such an excellent patch, including docs and unit
1558 tests! This makes it *so* much easier to apply. I had to update
1559 test_vc.py to handle some recent refactorings, but everything else
1560 applied smoothly. The only remaining thing I'd like to fix would
1561 be to remove the hard-wired port 1666 used by p4d, and allow it to
1562 claim any unused port. This would allow two copies of the test
1563 suite to run on the same host at the same time, as well as
1564 allowing the test suite to run while a real (production) p4d was
1565 running on the same host. Oh, and maybe we should add a warning to
1566 step.P4 that gets emitted if the slave is too old to provide the
1567 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1568 * buildbot/slave/commands.py (P4): same
1569 (P4Sync): same, some minor updates
1570 * buildbot/changes/p4poller.py: same
1571 * docs/buildbot.texinfo: same
1572 * buildbot/test/test_p4poller.py: same
1573 * buildbot/test/test_vc.py (P4): same
1575 * setup.py: add Trove classifiers for PyPI
1577 2006-06-08 Brian Warner <warner@allmydata.com>
1579 * buildbot/status/client.py
1580 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1581 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1582 build needs to be IRemote'd separately, rather than IRemote'ing
1583 the whole list at once. I can't wait until newpb's serialization
1584 adapters make this unnecessary.
1586 2006-06-06 Brian Warner <warner@lothar.com>
1588 * buildbot/process/step.py (WithProperties): make this inherit
1589 from ComparableMixin, so that reloading an unchanged config file
1590 doesn't cause us to spuriously reload any Builders which use them.
1591 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1594 2006-06-03 Brian Warner <warner@lothar.com>
1596 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1597 running py2exe on windows, contributed by Mark Hammond. Addresses
1598 SF#1401121, but I think we still need to include
1599 buildbot/scripts/sample.cfg
1600 * setup.py: include buildbot_service.py as a script under windows
1601 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1602 a py2exe application), get the icon/css datafiles from a different
1605 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1606 double-escape the build URL. Thanks to Olivier Bonnet for the
1607 patch. Fixes SF#1452801.
1609 2006-06-02 Brian Warner <warner@lothar.com>
1611 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1612 first six columns of 'svnlook' output, not just the first column,
1613 since property changes appear in the other five. Thanks to Olivier
1614 Bonnet for the patch. Fixes SF#1398174.
1616 2006-06-01 Brian Warner <warner@lothar.com>
1618 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1619 the fake build, so that title= has something to be set to
1621 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1622 attribute of the "Build #NN" link in the yellow start-the-build
1623 box to the build's reason. This means that you get a little
1624 tooltip explaining why the build was done when you hover over the
1625 yellow box. Thanks to Zandr Milewski for the suggestion.
1627 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1628 (Box.setETA): handle ETA=None (by stopping the timer)
1629 (Box.update): make the [soon] text less different than the usual
1630 text, so the rest of the text doesn't flop around so much. It
1631 would be awfully nice to figure out how to center this stuff.
1632 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1634 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1635 by default, so that any ShellCommand which fails marks the overall
1636 build as a failure. I should have done this from the beginning.
1637 Add flunkOnFailure=False to the arguments if you want to turn off
1640 2006-05-30 Brian Warner <warner@lothar.com>
1642 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1643 last-build/current-build/current-step. Show what step is currently
1644 running. Show ETA for both the overall build and the current step.
1645 Update GTK calls to modern non-deprecated forms. There's still a
1646 lot of dead code and debug noise to remove.
1648 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1649 shows up properly in status displays
1651 2006-05-28 Brian Warner <warner@lothar.com>
1653 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1654 build we use to verify that WithProperties works:
1656 ** set flunkOnFailure=True so that build failures get noticed
1657 ** set workdir='.' so that the build succeeds, otherwise it is trying
1658 to touch 'build/something', and 'build/' doesn't exist because
1659 usually that's created by a Source step
1660 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1661 this test somehow triggers, in which the 'touch' process becomes
1662 a zombie and we wait for th etimeout before giving up on it.
1664 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1665 to log the Build results and step logs to the twisted log.
1666 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1667 what went wrong if a build was expected to succeed but didn't.
1669 * buildbot/process/step_twisted.py (Trial): set the default
1670 trialMode to '--reporter=bwverbose', which specifies verbose
1671 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1672 '-to', but those are completely missing in modern Twisteds.
1674 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1675 a localhost-only port, to encourage better security
1677 * docs/buildbot.texinfo (Change Sources): mention
1680 * .darcs-boring: add a Darcs boringfile
1682 * README (REQUIREMENTS): stop claiming compatibility with
1685 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1688 2006-05-27 Brian Warner <warner@lothar.com>
1690 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1691 * docs/buildbot.texinfo: same
1693 2006-05-23 Brian Warner <warner@lothar.com>
1695 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1696 * docs/buildbot.texinfo: set version to match
1697 * NEWS: update for 0.7.3
1699 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1700 give a quick mapping from VC system to possible ChangeSources
1701 (Build Properties): add 'buildername'
1703 * buildbot/process/base.py (Build.setupStatus): oops, set
1704 'buildername' and 'buildnumber' properties
1705 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1708 2006-05-22 Brian Warner <warner@lothar.com>
1710 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1711 property interpolation better
1713 * README (INSTALLATION): remove old '-v' argument from recommended
1716 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1717 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1720 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1721 'svnversion' instead of grepping the output of 'svn info', much
1722 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1723 Bonnet for the suggestion.
1724 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1725 require the WC_PATH argument, so run 'svnversion .' instead.
1727 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1728 aren't supposed to have 'self' in their argument list
1730 2006-05-21 Brian Warner <warner@lothar.com>
1732 * buildbot/process/step.py (ShellCommand.start): make
1733 testInterpolate pass. I was passing the uninterpolated command to
1734 the RemoteShellCommand constructor
1735 (ShellCommand._interpolateProperties): oops, handle non-list
1736 commands (i.e. strings with multiple words separated by spaces in
1737 them) properly, instead of forgetting about them.
1739 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1740 to actually try to use build properties in a real build. This test
1742 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1743 to start and evaluate builds
1745 * buildbot/test/test__versions.py: add a pseudo-test to record
1746 what version of Twisted/Python/Buildbot are running. This should
1747 show up at the beginning of _trial_tmp/test.log, and exists to help
1748 debug other problems.
1750 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1751 a filename to be served as 'robots.txt' to discourage web spiders.
1752 Adapted from a patch by Tobi Vollebregt, thanks!
1753 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1754 (Waterfall.test_waterfall): tweak the way that filenames are put
1755 into the config file, to accomodate windows pathnames better.
1757 * docs/buildbot.texinfo (HTML Waterfall): document it
1759 * buildbot/process/process_twisted.py
1760 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1761 changed the build process. The new setup.py no longer takes the
1763 (FullTwistedBuildFactory.__init__): same
1764 (TwistedReactorsBuildFactory.__init__): same
1766 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1767 be placed in the [hooks] section of the central repository (the
1768 one that everybody pushes changes to).
1770 2006-05-20 Brian Warner <warner@lothar.com>
1772 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1773 .darcs-context file, use binary mode. I think this was causing a
1774 Darcs failure under windows.
1776 2006-05-19 Brian Warner <warner@lothar.com>
1778 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1779 use a timezone string of +0000 and gmtime, since this timestamp is
1780 sent to a buildmaster and %z is broken.
1782 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1783 string and localtime, since this timestamp will only be consumed
1784 locally, and %z is broken.
1786 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1787 gmtime, since this timestamp is returned to the buildmaster, and
1790 2006-05-18 Brian Warner <warner@lothar.com>
1792 * NEWS: update in preparation for next release
1794 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1795 setup-repository and do-we-have-the-vc-tools code into a separate
1796 "helper" class, which sticks around in a single module-level
1797 object. This seems more likely to continue to work in the future
1798 than having it hide in the TestCase and hope that TestCases stick
1799 around for a long time.
1801 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1802 addremove' has been deprecated in recent versions of mercurial, so
1803 use 'hg add' instead
1805 2006-05-07 Brian Warner <warner@lothar.com>
1807 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1808 operating under windows, move the file before opening it, since
1809 you can't rename a file that somebody has open.
1811 * buildbot/process/base.py (Build.setupBuild): if something goes
1812 wrong while creating a Step, log the name and arguments, since the
1813 error message when you get the number of arguments wrong is really
1816 2006-05-06 Brian Warner <warner@lothar.com>
1818 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1819 bugs in twisted-specific code not covered by my unit tests, this
1820 time use 'cmd' argument instead of self.cmd
1822 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1823 fix stupid braino: either use startwith or find()==0, not both.
1824 (TwistedReactorsBuildFactory.__init__): another dumb typo
1826 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1827 mark this test as TODO under windows, since process-killing seems
1828 dodgy there. We'll come back to this later and try to fix it
1831 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1832 and don't include a timezone
1833 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1834 This should avoid the windows-with-verbose-timezone-name problem
1836 (Patch.testPatch): add a test which runs 'patch' with less
1837 overhead than the full VCBase.do_patch sequence, to try to isolate
1838 a windows test failure. This one uses slave.commands.ShellCommand
1839 and 'patch', but none of the VC code.
1841 * buildbot/slave/commands.py (getCommand): use which() to find the
1842 executables for 'cvs', 'svn', etc. This ought to help under
1845 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1846 working directory before starting. If an earlier test failed, the
1847 leftover directory would mistakenly flunk a later test.
1848 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1849 Make sure that we use the right commandlines if which("tla") picks
1850 up "tla.exe" (as it does under windows).
1851 (TlaSupport.do_get): factor out this tla-vs-baz difference
1852 (TlaSupport.vc_create): more tla-vs-baz differences
1854 * buildbot/test/test_slavecommand.py
1855 (ShellBase.testShellMissingCommand): stop trying to assert
1856 anything about the error message: different shells on different
1857 OSes with different languages makes it hard, and it really isn't
1858 that interesting of a thing to test anyway.
1860 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1861 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1862 "Panther"), because it has a bug which flunks a couple tests in
1863 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1864 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1865 able to test that yet.
1867 2006-04-30 Brian Warner <warner@lothar.com>
1869 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1870 make sure child commands emit messages in english, so our regexps
1871 will match. Thanks to Nikaus Giger for identifying the problems.
1872 (VCBase._do_vctest_export_1): mode="export" is not responsible
1873 for setting the "got_revision" property, since in many cases it is
1874 not convenient to determine.
1875 (SVNSupport.capable): when running 'svn --version' to check for
1876 ra_local, we want error messages in english
1877 * buildbot/test/test_slavecommand.py
1878 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1879 to emit the error message in english
1881 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1882 the environment with $LC_ALL="C" so that Commands which need to
1883 parse the output of their child processes can obtain it in
1885 (SVN.parseGotRevision): call "svn info" afterwards instead of
1886 watching the output of the "svn update" or "svn checkout".
1887 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1888 (Arch.parseGotRevision): same
1889 (Bazaar.parseGotRevision): same
1890 (Mercurial.parseGotRevision): same
1892 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1893 $LC_ALL="C" when running commands under 'buildbot try', too
1895 * buildbot/test/__init__.py: remove the global os.environ()
1896 setting, instead we do it just for the tests that run commands and
1897 need to parse their output.
1899 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1900 remove the overly-short .timeout on this test, because non-DNotify
1901 platforms must fall back to polling which happens at 10 second
1902 intervals, so a 5 second timeout would never succeed.
1904 2006-04-24 Brian Warner <warner@lothar.com>
1906 * docs/buildbot.texinfo (Installing the code): update trial
1907 invocation, SF#1469116 by Niklaus Giger.
1908 (Attributes of Changes): updated branch-name examples to be
1909 a bit more realistic, SF#1475240 by Stephen Davis.
1911 * contrib/windows/buildbot2.bat: utility wrapper for windows
1912 developers, contributed by Nick Trout (after a year of neglect..
1913 sorry!). SF#1194231.
1915 * buildbot/test/test_vc.py (*.capable): store the actual VC
1916 binary's pathname in VCS[vcname], so it can be retrieved later
1917 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1918 strip out non-numeric timezone information, specifically the funky
1919 German string that his system produced that confuses CVS.
1920 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1921 allow Darcs tests to work on windows
1922 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1923 procutils.which() everywhere, to allow tryclient to work under
1924 windows. Also from Niklaus Giger, SF#1463394.
1926 * buildbot/twcompat.py (which): move the replacement for a missing
1927 twisted.python.procutils.which from test_vc.py to here, so it can
1928 be used in other places too (specifically tryclient.py)
1930 2006-04-23 Brian Warner <warner@lothar.com>
1932 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1933 bare buildbotURL/projectName line with a proper DIV, along with a
1934 CSS class of "title", from Stefan Seefeld (SF#1461675).
1935 (WaterfallStatusResource.body0): remove the redundant 'table'
1936 class from the table
1937 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1938 to the top-row TR, and class="Activity" to the second-row TR,
1939 rather than putting them in the individual TD nodes.
1941 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1942 'got_revision' build property for all VC systems that implement
1943 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1945 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1946 to determine which revision we actually obtained
1947 (CVS.parseGotRevision): implement this for CVS, which just means
1948 to grab a timestamp. Not ideal, and it depends upon the buildslave
1949 having a clock that is reasonably well syncronized with the server,
1950 but it's better than nothing.
1951 (SVN.parseGotRevision): implement it for SVN, which is accurate
1952 (Darcs.parseGotRevision): same
1953 (Arch.parseGotRevision): same
1954 (Bazaar.parseGotRevision): same
1955 (Mercurial.parseGotRevision): same
1957 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1958 keep a record of all non-stdout/stderr/header/rc status updates,
1959 for the benefit of RemoteCommands that send other useful things,
1961 (Source.commandComplete): put any 'got_revision' status values
1962 into a build property of the same name
1965 * buildbot/process/step_twisted.py (Trial): update to deal with
1966 new ShellCommand refactoring
1968 * docs/buildbot.texinfo (Build Properties): document new feature
1969 that allows BuildSteps to get/set Build-wide properties like which
1970 revision was requested and/or checked out.
1972 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1973 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1974 it. Note that this bumps the persistenceVersion of the saved Build
1975 object, so add the necessary upgrade-old-version logic to include
1976 an empty properties dict.
1978 * buildbot/process/base.py (Build.setProperty): implement it
1979 (Build.getProperty): same
1980 (Build.startBuild): change build startup to set 'branch',
1981 'revision', and 'slavename' properties at the right time
1983 * buildbot/process/step.py (BuildStep.__init__): change setup to
1984 require 'build' argument in a better way
1985 (LoggingBuildStep): split ShellCommand into two pieces, for better
1986 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1987 a single RemoteCommand that sends stdout/stderr status text. It
1988 also provides the usual commandComplete / createSummary /
1989 evaluateCommand / getText methods to be overridden...
1990 (ShellCommand): .. whereas ShellCommand is specifically for
1991 running RemoteShellCommands. Other shell-like BuildSteps (like
1992 Source) can inherit from LoggingBuildStep instead of ShellCommand
1993 (WithProperties): marker class to do build-property interpolation
1994 (Source): inherit from LoggingBuildStep instead of ShellCommand
1997 * buildbot/test/test_properties.py: test new functionality
1999 2006-04-21 Brian Warner <warner@lothar.com>
2001 * buildbot/test/test_vc.py: rename testBranch to
2002 testCheckoutBranch to keep the tests in about the right
2005 2006-04-18 Brian Warner <warner@lothar.com>
2007 * docs/buildbot.texinfo (PBListener): improve cross-references
2008 between PBListener and 'buildbot statusgui', thanks to John Pye
2011 2006-04-17 Brian Warner <warner@lothar.com>
2013 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2014 running under Twisted-1.3.0, otherwise skipped tests are reported
2017 * all: use isinstance() instead of 'type(x) is foo', suggested by
2020 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2021 oops, fix a brain-fade from the other week, when making the
2022 addStep changes. I changed all the __init__ upcalls to use the
2023 wrong superclass name.
2024 (FullTwistedBuildFactory.__init__): same
2025 (TwistedDebsBuildFactory.__init__): same
2026 (TwistedReactorsBuildFactory.__init__): same
2027 (TwistedBuild.isFileImportant): use .startswith for clarity,
2028 thanks to Neal Norwitz for the suggestions.
2030 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2031 changes, then deliver them over PB to a remote buildmaster.
2033 * contrib/svnpoller.py: added script by John Pye to poll a remote
2034 SVN repository (by running 'svn log') from a cronjob, and run
2035 'buildbot sendchange' to deliver the changes to a remote
2037 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2038 modification of svnpoller.py), same purpose, but this one loops
2039 internally (rather than expecting to run from a cronjob) and works
2041 * contrib/README.txt: same
2043 2006-04-11 Brian Warner <warner@lothar.com>
2045 * all: fix a number of incorrect names and missing imports, thanks
2046 to Anthony Baxter for the patch.
2047 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2048 remove unused buggy method.
2049 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2050 comes from shutil, not "shutils"
2051 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2052 (Arch.checkSlaveVersion): same
2053 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2055 * buildbot/process/step_twisted2.py: add some missing imports
2056 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2057 this code used to live in twisted.internet.defer
2059 2006-04-10 Brian Warner <warner@lothar.com>
2061 * buildbot/process/step.py (Mercurial): add Mercurial support
2062 * buildbot/slave/commands.py (Mercurial): same
2063 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2064 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2065 not yet tested, but 'try' support *is* covered
2066 * docs/buildbot.texinfo (Mercurial): document it
2068 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2069 some debugging messages (turned off)
2070 * buildbot/test/test_vc.py: improve debug messages
2072 2006-04-07 Brian Warner <warner@lothar.com>
2074 * buildbot/test/test_vc.py (which): define our own which() in case
2075 we can't import twisted.python.procutils, because procutils doesn't
2076 exist in Twisted-1.3
2078 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2079 of SlaveLocks for performance tests
2081 * docs/examples/twisted_master.cfg: update to match current usage
2083 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2084 password, p4 binary, pollinterval, maximum history to check.
2085 Patch from an anonymous sf.net contributor, SF#1219384.
2086 * buildbot/process/step.py (P4Sync.__init__): add username,
2087 password, and client arguments.
2088 * buildbot/slave/commands.py (P4Sync): same
2090 2006-04-05 Brian Warner <warner@lothar.com>
2092 * buildbot/process/factory.py (BuildFactory.addStep): new method
2093 to add steps to a BuildFactory. Use it instead of f.steps.append,
2094 and you can probably avoid using the s() convenience function.
2095 Patch from Neal Norwitz, sf.net #1412605.
2096 (other): update all factories to use addStep
2097 * buildbot/process/process_twisted.py: update all factories to use
2100 2006-04-03 Brian Warner <warner@lothar.com>
2102 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2103 work under windows too. Adapted from a patch by Niklaus Giger,
2104 addresses SF#1463399.
2106 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2107 spawned commands emit parseable results in english and not some
2108 other language. Patch from Niklaus Giger, SF#1463395.
2110 * README (INSTALLATION): discourage users from running unit tests on
2111 a "network drive", patch from Niklaus Giger, SF#1463394.
2113 2006-03-22 Brian Warner <warner@lothar.com>
2115 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2116 function to turn a repository-relative pathname into a (branch,
2117 branch-relative-filename) tuple. Change this function to handle
2118 the branch naming policy used by your Subversion repository.
2119 Thanks to AllMyData.com for sponsoring this work.
2121 2006-03-16 Brian Warner <warner@lothar.com>
2123 * buildbot/scripts/sample.cfg: add python-mode declaration for
2124 vim. Thanks to John Pye for the patch.
2126 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2127 command line, mention the importance of running 'crontab' as the
2128 buildmaster/buildslave user. Thanks to John Pye for the catch.
2130 2006-03-13 Brian Warner <warner@lothar.com>
2132 * buildbot/status/words.py (IRC): add an optional password=
2133 argument, which will be sent to Nickserv in an IDENTIFY message at
2134 login, to claim the nickname. freenode requires this before the
2135 bot can sent (or reply to) private messages. Thanks to Clement
2136 Stenac for the patch.
2137 * docs/buildbot.texinfo (IRC Bot): document it
2139 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2140 larger than chunkSize. Fixes SF#1349253.
2141 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2142 (Log.testConsumer): update to match new internal chunking behavior
2144 2006-03-12 Brian Warner <warner@lothar.com>
2146 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2148 * buildbot/test/test_maildir.py (MaildirTest): rename the
2149 'timeout' method, as it collides with trial's internals
2151 * buildbot/scripts/runner.py: add 'buildbot restart' command
2152 (stop): don't sys.exit() out of here, otherwise restart can't work
2153 * docs/buildbot.texinfo (Shutdown): document it
2155 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2156 * buildbot/status/html.py (Waterfall.__init__): same
2157 * buildbot/process/builder.py (Builder.startBuild): same
2158 * buildbot/process/base.py (BuildRequest): same
2159 * buildbot/sourcestamp.py (SourceStamp): same
2160 * buildbot/scheduler.py (Nightly): same
2162 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2164 * docs/buildbot.texinfo: same
2166 2006-02-17 Brian Warner <warner@lothar.com>
2168 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2169 * docs/buildbot.texinfo: set version number to match
2170 * NEWS: update for 0.7.2
2172 2006-02-16 Brian Warner <warner@lothar.com>
2174 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2176 2006-02-09 Brian Warner <warner@lothar.com>
2178 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2179 add text to explain per-build branch parameters
2180 * NEWS: mention --umask
2182 2006-02-08 Brian Warner <warner@lothar.com>
2184 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2186 (SlaveOptions.optParameters): add --umask, to make it possible to
2187 make buildslave-generated files (including build products) be
2190 * buildbot/slave/bot.py (BuildSlave.startService): same
2192 2006-01-23 Brian Warner <warner@lothar.com>
2194 * buildbot/status/builder.py: urllib.quote() all URLs that include
2195 Builder names, so that builders can include characters like '/'
2196 and ' ' without completely breaking the resulting HTML. Thanks to
2197 Kevin Turner for the patch.
2198 * buildbot/status/html.py: same
2199 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2201 * NEWS: update in preparation for upcoming release
2203 2006-01-18 Brian Warner <warner@lothar.com>
2205 * docs/examples/twisted_master.cfg: update to match the Twisted
2206 buildbot: remove python2.2, switch to exarkun's buildslaves,
2207 disable the .deb builder until we figure out how to build twisted
2208 .debs from SVN, add some ktrace debugging to the OS-X build
2209 process and remove the qt build, remove threadless builders,
2210 change freebsd builder to use landonf's buildslave.
2212 2006-01-12 Brian Warner <warner@lothar.com>
2214 * buildbot/master.py (Manhole.__init__): let port= be a strports
2215 specification string, but handle a regular int for backwards
2216 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2217 used in master.cfg to limit connections to just the local host.
2218 (BuildMaster.loadConfig): same for c['slavePortnum']
2219 * buildbot/scheduler.py (Try_Userpass.__init__): same
2220 * buildbot/status/client.py (PBListener.__init__): same
2221 * buildbot/status/html.py (Waterfall.__init__): same, for both
2222 http_port and distrib_port. Include backwards-compatibility checks
2223 so distrib_port can be a filename string and still mean unix:/foo
2224 * docs/buildbot.texinfo (Setting the slaveport): document it
2225 (Debug options): same
2226 (HTML Waterfall): same
2229 * buildbot/test/test_config.py (ConfigTest): test it
2231 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2232 slaveport's disownServiceParent deferred to fire before opening
2233 the new one. Fixes an annoying bug in the unit tests.
2235 2006-01-03 Brian Warner <warner@lothar.com>
2237 * buildbot/master.py (BuildMaster): remove the .schedulers
2238 attribute, replacing it with an allSchedulers() method that looks
2239 for all IService children that implement IScheduler. Having only
2240 one parent/child relationship means fewer opportunities for bugs.
2241 (BuildMaster.allSchedulers): new method
2242 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2243 also fix ugly bug that caused any config-file reload to
2244 half-forget about the earlier Schedulers, causing an exception
2245 when a Change arrived and was handed to a half-connected
2246 Scheduler. The exception was in scheduler.py line 54ish:
2247 self.parent.submitBuildSet(bs)
2248 exceptions.AttributeError: 'NoneType' object has no attribute
2250 (BuildMaster.addChange): update to use allSchedulers()
2252 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2253 to work properly with twisted-1.3.0, where you must explicitly
2254 include the __implements__ from parent classes
2255 (BaseScheduler.__repr__): make it easier to distinguish distinct
2257 (BaseUpstreamScheduler.__implements__): same
2259 * buildbot/status/builder.py (Status.getSchedulers): update to
2261 * buildbot/test/test_run.py (Run.testMaster): same
2262 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2263 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2264 make sure Scheduler instances are left alone when an identical
2265 config file is reloaded
2266 (ConfigElements.testSchedulers): make sure Schedulers are properly
2269 * Makefile (TRIALARGS): my local default Twisted version is now
2270 2.1.0, update the trial arguments accordingly
2272 2005-12-22 Brian Warner <warner@lothar.com>
2274 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2277 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2278 addChange in the parent class, although I suspect this should be
2279 fixed better in the future.
2281 2005-11-26 Brian Warner <warner@lothar.com>
2283 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2284 explode when branch==None, thanks to Kevin Turner for the catch
2285 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2288 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2290 * docs/buildbot.texinfo: same
2292 2005-11-26 Brian Warner <warner@lothar.com>
2294 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2295 * docs/buildbot.texinfo: set version number to match
2297 2005-11-26 Brian Warner <warner@lothar.com>
2299 * NEWS: update for 0.7.1
2301 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2302 sure that unsubscribe works even if we never sent an ETA update.
2303 Also, don't explode on duplicate unsubscribe.
2304 (BuildStepStatus.addLog): make the convenience "return self"-added
2305 watcher automatically unsubscribe when the Step finishes.
2306 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2307 (BuildStatus.stepStarted): same auto-unsubscribe
2308 (BuilderStatus.buildStarted): same auto-unsubscribe
2310 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2312 (IStatusReceiver.stepStarted): same
2313 (IStatusReceiver.logStarted): same
2315 * buildbot/test/test_run.py (Status): move the Status test..
2316 * buildbot/test/test_status.py (Subscription): .. to here
2318 2005-11-25 Brian Warner <warner@lothar.com>
2320 * NEWS: more updates
2322 * buildbot/locks.py: fix the problem in which loading a master.cfg
2323 file that changes some Builders (but not all of them) can result
2324 in having multiple copies of the same Lock. Now, the real Locks
2325 are kept in a table inside the BotMaster, and the Builders/Steps
2326 use "LockIDs", which are still instances of MasterLock and
2327 SlaveLock. The real Locks are instances of the new RealMasterLock
2328 and RealSlaveLock classes.
2329 * buildbot/master.py (BotMaster.getLockByID): new method to
2330 convert LockIDs into real Locks.
2331 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2332 into real Locks before building
2333 * buildbot/process/step.py (BuildStep.startStep): same
2334 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2335 exercises the problem
2338 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2339 what Schedulers are available
2341 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2342 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2343 'cron'-style build scheduling at certain times of day, week,
2345 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2347 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2348 handling: treat self.fileIsImportant more as an attribute that
2349 contains a callable than as a method. If the attribute is None,
2350 don't call it and assume all filenames are important. It is still
2351 possible to provide a fileIsImportant method in a subclass,
2353 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2355 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2356 test using AnyBranchScheduler with fileIsImportant=None
2358 2005-11-24 Brian Warner <warner@lothar.com>
2360 * buildbot/test/test_config.py (StartService): don't claim a fixed
2361 port number, instead set slavePort=0 on the first pass, figure out
2362 what port was allocated, then switch to a config file that uses
2365 * buildbot/master.py (BuildMaster.loadConfig): close the old
2366 slaveport before opening the new one, because unit tests might
2367 replace slavePort=0 with the same allocated portnumber, and if we
2368 don't wait for the old port to close first, we get a "port already
2369 in use" error. There is a tiny race condition here, but the only
2370 threat is from other programs that bind (statically) to the same
2371 port number we happened to be allocated, and only if those
2372 programs use SO_REUSEADDR, and only if they get control in between
2375 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2377 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2378 deleted ChangeSources before adding any new ones
2379 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2380 compare_attrs, to make sure that a config-file reload does not
2381 unnecessarily replace an unmodified ChangeSource instance
2382 * buildbot/test/test_config.py (ConfigTest.testSources): update
2384 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2385 mean "don't build anything", and add a warning if it gets used
2386 because it isn't actually useful.
2388 * contrib/svn_buildbot.py: update example usage to match the port
2389 number that gets used by the PBChangeSource
2390 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2392 2005-11-22 Brian Warner <warner@lothar.com>
2394 * NEWS: start collecting items for next release
2396 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2397 revisions are strings
2398 (P4Sync.computeSourceRevision): same
2400 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2401 to the Buildbot's overall status page
2402 (StatusResourceBuilder.body): same
2404 2005-11-15 Brian Warner <warner@lothar.com>
2406 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2407 config-file loading, specifically to make sure old StatusTargets
2408 are finished shutting down before new ones start up (thus
2409 resolving a bug in which changing the Waterfall object would fail
2410 because both new and old instances were claiming the same
2411 listening port). Also load new Schedulers after all the new
2412 Builders are set up, in case they fire off a new build right away.
2413 * buildbot/test/test_config.py (StartService): test it
2415 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2416 the branch name to the mail body
2418 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2419 Without it, a config-file reload fails to update an existing
2421 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2422 username/passwd to compare_attrs, for the same reason
2423 * buildbot/status/html.py (Waterfall): add favicon to
2424 compare_attrs, same reason
2426 2005-11-05 Brian Warner <warner@lothar.com>
2428 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2429 baserev before stuffing it in the jobfile. This resolves problems
2430 under SVN (and probably Arch) where revisions are expressed as
2431 numbers. I'm inclined to use string-based revisions everywhere in
2432 the future, but this fix should be safe for now. Thanks to Steven
2433 Walter for the patch.
2435 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2436 binary mode when opening pickle files, to make windows work
2437 better. Thanks to Dobes Vandermeer for the catch.
2438 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2439 (BuilderStatus.getBuildByNumber): same
2440 (Status.builderAdded): same
2441 * buildbot/master.py (BuildMaster.loadChanges): same
2443 * buildbot/util.py (Swappable): delete unused leftover code
2445 * buildbot/process/step.py (SVN): when building on a non-default
2446 branch, add the word "[branch]" to the VC step's description, so
2447 it is obvious that we're not building the usual stuff. Likewise,
2448 when we are building a specific revision, add the text "rNNN" to
2449 indicate what that revision number is. Thanks to Brad Hards and
2450 Nathaniel Smith for the suggestion.
2451 (Darcs.startVC): same
2452 (Arch.startVC): same
2453 (Bazaar.startVC): same
2455 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2456 typo, caught by Mark Dillavou, closes SF#1216636.
2458 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2459 about a test to add some day
2461 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2462 the 'full-2.3' build, and the 'reactors' build is now run under
2463 python-2.4 because the buildslave no longer has gtk/etc bindings
2464 for earlier versions.
2466 2005-11-03 Brian Warner <warner@lothar.com>
2468 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2469 method, takes an IBuildStatus and rebuilds it. It might make more
2470 sense to add this to IBuildControl instead, but that instance goes
2471 away completely once the build has finished, and resubmitting
2472 builds can take place weeks later.
2473 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2474 * buildbot/status/html.py (StatusResourceBuild): also stash an
2475 IBuilderControl so we can use resubmitBuild.
2476 (StatusResourceBuild.body): render "resubmit" button if we can.
2477 Also add hrefs for each BuildStep
2478 (StatusResourceBuild.rebuild): add action for "resubmit" button
2479 (StatusResourceBuilder.getChild): give it an IBuilderControl
2481 * buildbot/status/builder.py (Status.getURLForThing): change the
2482 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2483 that live as targets of buttons like "stop" and "rebuild" can't
2485 * buildbot/status/builder.py (Status.getURLForThing): same
2486 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2487 (StepBox.getBox): same
2488 * buildbot/test/test_web.py (GetURL): same
2491 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2492 exclusivity checks after Source.__init__ upcall, so misspelled
2493 arguments will be reported more usefully
2494 (Darcs.__init__): same
2496 2005-10-29 Brian Warner <warner@lothar.com>
2498 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2499 builder. Move the Try scheduler off to a separate port.
2501 2005-10-27 Brian Warner <warner@lothar.com>
2503 * buildbot/clients/gtkPanes.py
2504 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2505 to cause the app to crash, now they don't.
2507 * buildbot/clients/debug.py: display the buildmaster's location
2508 in the window's title bar
2510 2005-10-26 Brian Warner <warner@lothar.com>
2512 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2513 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2514 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2516 * buildbot/status/html.py (td): put a single non-breaking space
2517 inside otherwise empty <td> elements, as a workaround for buggy
2518 browsers which would optimize them away (along with any associated
2519 styles, like the kind that create the waterfall grid borders).
2520 Patch from Frerich Raabe.
2522 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2523 argv-list as an argument, defaulting to ["-to"], which is
2524 appropriate for the Trial that comes with Twisted-2.1.0 and
2525 earlier. The Trial in current Twisted SVN wants
2526 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2527 defaults to an empty list.
2528 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2529 match it, now that trialMode= is a list instead of a single string
2531 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2533 * docs/buildbot.texinfo: same
2535 2005-10-24 Brian Warner <warner@lothar.com>
2537 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2538 * docs/buildbot.texinfo: set version number to match
2540 2005-10-24 Brian Warner <warner@lothar.com>
2542 * README: update for 0.7.0
2544 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2546 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2547 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2548 send the branch= argument unless the user really provided one, to
2549 retain compatibility with older buildmasters that don't accept
2551 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2554 * docs/buildbot.texinfo: update lots of stuff
2556 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2557 to the 'buildbot sendchange' command
2558 * buildbot/clients/sendchange.py (Sender.send): same
2559 * buildbot/changes/pb.py (ChangePerspective): same
2560 * buildbot/test/test_changes.py (Sender.testSender): test it
2562 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2563 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2564 for consistency with other BuildStep arguments that use camelCase.
2565 Well, at least more of them use camelCase (like flunkOnWarnings)
2566 than don't.. I wish I'd picked one style and stuck with it
2567 earlier. Annoying, but it's best done before the release, since
2568 these arguments didn't exist at all in 0.6.6 .
2570 * buildbot/test/test_vc.py (SVN.testCheckout): same
2571 (Darcs.testPatch): same
2572 * docs/buildbot.texinfo (SVN): document the change
2573 (Darcs): same, add some build-on-branch docs
2574 * docs/examples/twisted_master.cfg: match change
2576 * buildbot/process/step.py (BuildStep): rename
2577 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2578 how it is normally used.
2579 * buildbot/test/test_steps.py (Version.checkCompare): same
2581 * buildbot/process/step.py (CVS.startVC): refuse to build
2582 update/copy -style builds on a non-default branch with an old
2583 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2584 concern is that it will do a VC 'update' in an existing tree when
2585 it is supposed to be switching branches (and therefore clobbering
2586 the tree to do a full checkout), thus building the wrong source.
2587 This used to be a warning, but I think the confusion it is likely
2588 to cause warrants making it an error.
2589 (SVN.startVC): same, also make mode=export on old slaves an error
2590 (Darcs.startVC): same
2591 (Git.startVC): improve error message for non-Git-enabled slaves
2592 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2593 specific revision is built on a slave that doesn't pay attention
2594 to args['revision'], because for slowly-changing trees it will
2595 probably do the right thing, and because we have no way to tell
2596 whether we're asking it to build the most recent version or not.
2597 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2599 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2600 that 'master' is in host:portnum format, to catch errors sooner
2602 2005-10-23 Brian Warner <warner@lothar.com>
2604 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2605 when creating the list of warning messages, include the line
2606 immediately after each WARNING: line, since that's usually where
2607 the file and line number wind up.
2609 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2614 2005-10-22 Brian Warner <warner@lothar.com>
2616 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2617 patch from Brad Hards
2618 * buildbot/status/classic.css: same
2619 * buildbot/test/test_web.py (Waterfall): match changes
2621 * buildbot/test/test_steps.py (BuildStep.setUp): set
2622 nextBuildNumber so the test passes
2623 * buildbot/test/test_status.py (MyBuilder): same
2625 * buildbot/status/html.py (StatusResourceBuild.body): revision
2626 might be numeric, so stringify it before html-escapifying it
2627 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2628 timer for the upcoming build
2629 * buildbot/status/classic.css: add background-color attributes for
2630 offline/waiting/building classes
2632 * buildbot/status/builder.py (BuildStatus): derive from
2633 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2634 the default (i.e. unknown) .slavename to "???" instead of None,
2635 since even unknown slavenames need to be printed eventually.
2636 (BuilderStatus): also derive from styles.Versioned . More
2637 importantly, determine .nextBuildNumber at creation/unpickling
2638 time by scanning the directory of saved BuildStatus instances and
2639 choosing one larger than the highest-numbered one found. This
2640 should fix the problem where random errors during upgrades cause
2641 the buildbot to forget about earlier builds. .nextBuildNumber is
2642 no longer stored in the pickle.
2643 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2644 at least log the error. Also call Builder.determineNextBuildNumber
2645 once the basedir is set.
2647 * buildbot/master.py (BuildMaster.loadChanges): do
2648 styles.doUpgrade afterwards, in case I decide to make Changes
2649 derived from styles.Versioned some day and forget to make this
2653 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2654 when running under older pythons (<2.3) in which the shlex module
2655 doesn't have a 'split' function.
2657 * buildbot/process/step.py (ShellCommand.start): make
2658 errorMessages= be a list of strings to stuff in the log before the
2659 command actually starts. This makes it easier to flag multiple
2660 warning messages, e.g. when the Source steps have to deal with an
2662 (CVS.startVC): handle slaves that don't handle multiple branches
2663 by switching into 'clobber' mode
2664 (SVN.startVC): same. Also reject branches without base_url
2665 (Darcs.startVC): same. Also reject revision= in older slaves
2666 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2667 (Bazaar.startVC): same, and test for baz separately than for arch
2669 * buildbot/slave/commands.py (cvs_ver): document new features
2671 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2672 (BuildStep.slaveVersionNewEnough): more useful utility method
2673 * buildbot/test/test_steps.py (Version): start testing it
2675 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2676 the 'force' command requires python2.3, for the shlex.split method
2678 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2679 since we don't use it anymore. The Twisted buildbot uses a
2682 2005-10-21 Brian Warner <warner@lothar.com>
2684 * buildbot/process/process_twisted.py: rework all BuildFactory
2685 classes to take a 'source' step as an argument, instead of
2686 building up the SVN instance in the factory.
2687 * docs/examples/twisted_master.cfg: enable build-on-branch by
2688 providing a base_url and default_branch
2690 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2691 control over --branch and --revision, not that they are always
2693 * buildbot/status/html.py (StatusResourceBuilder.force): same
2694 (StatusResourceBuild.body): display SourceStamp components
2696 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2697 IRC 'force' command, so it can be shared with an eventual
2698 command-line-tool 'buildbot force' mode.
2699 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2701 2005-10-20 Brian Warner <warner@lothar.com>
2703 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2705 * docs/examples/twisted_master.cfg: update to use Schedulers
2707 * buildbot/scripts/sample.cfg: update with Schedulers
2709 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2710 method specifically for use by HTML "force build" button and the
2711 IRC "force" command. Raises an immediate error if there are no
2713 (IBuilderControl.requestBuild): make this just submit a build, not
2714 try to check for existing slaves or set up any when-finished
2715 Deferreds or anything.
2716 * buildbot/process/builder.py (BuilderControl): same
2717 * buildbot/status/html.py (StatusResourceBuilder.force): same
2718 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2719 * buildbot/test/test_slaves.py: same
2720 * buildbot/test/test_web.py: same
2722 2005-10-19 Brian Warner <warner@lothar.com>
2724 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2725 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2727 2005-10-18 Brian Warner <warner@lothar.com>
2729 * buildbot/status/html.py: provide 'status' argument to most
2730 StatusResourceFOO objects
2731 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2732 and Logfiles" section to make the Build page into a more-or-less
2733 comprehensive source of status information about the build
2735 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2736 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2738 2005-10-17 Brian Warner <warner@lothar.com>
2740 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2741 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2742 out what to do about other projects: the correct options for
2743 recent Twisteds will not work for older ones.
2745 2005-10-15 Brian Warner <warner@lothar.com>
2747 * buildbot/status/builder.py (Status.getURLForThing): add method
2748 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2749 use this in email/IRC status clients to make them more useful, by
2750 providing the end user with hints on where to learn more about the
2751 object being reported on.
2752 * buildbot/test/test_web.py (GetURL): tests for it
2754 2005-10-14 Brian Warner <warner@lothar.com>
2756 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2757 fix bug resulting from deferredResult changes
2759 2005-10-13 Brian Warner <warner@lothar.com>
2761 * buildbot/test/test_changes.py: remove use of deferredResult
2762 * buildbot/test/test_config.py: same
2763 * buildbot/test/test_control.py: same
2764 * buildbot/test/test_status.py: same
2765 * buildbot/test/test_vc.py: this is the only remaining use, since
2766 it gets used at module level. This needs to be replaced by some
2767 sort of class-level run-once routine.
2769 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2771 * lots: implement multiple slaves per Builder, which means multiple
2772 current builds per Builder. Some highlights:
2773 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2774 of (state,currentBuilds) instead of (state,currentBuild)
2775 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2776 (IBuildStatus.getSlavename): new method, so you can tell which
2777 slave got used. This only gets set when the build completes.
2778 (IBuildRequestStatus.getBuilds): new method
2780 * buildbot/process/builder.py (SlaveBuilder): add a .state
2781 attribute to track things like ATTACHING and IDLE and BUILDING,
2783 (Builder): .. the .slaves attribute here, which has been turned
2784 into a simple list of available slaves. Added a separate
2785 attaching_slaves list to track ones that are not yet ready for
2787 (Builder.fireTestEvent): put off the test-event callback for a
2788 reactor turn, to make tests a bit more consistent.
2789 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2790 ping fails due to an exception. This needs work, I'm worried that
2791 a code error could lead to a constantly re-connecting slave.
2792 Especially since I'm trying to move to a distinct remote_ping
2793 method, separate from the remote_print that we currently use.
2794 (BuilderControl.requestBuild): return a convenience Deferred that
2795 provides an IBuildStatus when the build finishes.
2796 (BuilderControl.ping): ping all connected slaves, only return True
2797 if they all respond.
2799 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2800 reconnect when we shut down.
2802 * buildbot/status/builder.py: implement new methods, convert
2803 one-build-at-a-time methods to handle multiple builds
2804 * buildbot/status/*.py: do the same in all default status targets
2805 * buildbot/status/html.py: report the build's slavename in the
2806 per-Build page, report all buildslaves on the per-Builder page
2808 * buildbot/test/test_run.py: update/create tests
2809 * buildbot/test/test_slaves.py: same
2810 * buildbot/test/test_scheduler.py: remove stale test
2812 * docs/buildbot.texinfo: document the new builder-specification
2813 'slavenames' parameter
2815 2005-10-12 Brian Warner <warner@lothar.com>
2817 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2818 report failure correctly, causing Dependent builds to run when
2819 they shouldn't have.
2820 * buildbot/status/builder.py (BuildSetStatus): same
2821 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2822 (Set.testSuccess): test the both-pass case too
2823 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2824 fix this test: it was ending too early, masking the failure before
2825 (Logger): specialized StatusReceiver to make sure the dependent
2826 builds aren't even started, much less completed.
2828 2005-10-07 Brian Warner <warner@lothar.com>
2830 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2831 bot.SlaveBuilder being disowned in the middle of a build
2833 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2834 this inherit from StatusReceiver. Also upcall in __init__. This
2835 fixes the embarrasing crash when the new buildSetSubmitted method
2836 is invoked and Waterfall/etc don't implement their own.
2837 * buildbot/test/test_run.py: add a TODO note about a test to catch
2838 just this sort of thing.
2840 * buildbot/process/builder.py (Builder.attached): remove the
2841 already-attached warning, this situation is normal. Add some
2842 comments explaining it.
2844 2005-10-02 Brian Warner <warner@lothar.com>
2846 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2847 OverflowError when setting up dnotify, because some 64-bit systems
2848 have problems with signed-vs-unsigned constants and trip up on the
2849 DN_MULTISHOT flag. Patch from Brad Hards.
2851 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2853 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2854 progressMetrics, description, descriptionDone to the 'parms' list,
2855 and make use the 'parms' list from the implementation class
2856 instead of only BuildStep to initialize the parameters. This
2857 allows buildbot.process.factory.s() to initialize all the parms,
2858 not just those defined in directly by BuildStep.
2860 2005-09-03 Brian Warner <warner@lothar.com>
2862 * NEWS: start adding items for the next release
2864 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2865 python2.2 tests, change 'Quick' builder to only use python2.3
2867 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2869 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2870 the "Ping Builder" button if the build control is available; the
2871 user sees an exception otherwise
2873 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2875 2005-09-01 Brian Warner <warner@lothar.com>
2877 * buildbot/interfaces.py (IBuilderStatus.getState): update
2878 signature, point out that 'build' can be None
2879 (IBuildStatus.getETA): point out ETA can be none
2881 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2883 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2885 2005-08-31 Brian Warner <warner@lothar.com>
2887 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2888 update to match correct signature: removed 'eta' argument
2889 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2891 2005-08-30 Brian Warner <warner@lothar.com>
2893 * buildbot/status/builder.py (LogFile): remove the assertion that
2894 blows up when you try to overwrite an existing logfile, instead
2895 just emit a warning. This case gets hit when the buildmaster is
2896 killed and doesn't get a chance to write out the serialized
2897 BuilderStatus object, so the .nextBuildNumber attribute gets out
2900 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2901 the 'buildbot sendchange' arguments, for the Darcs context file
2902 * docs/buildbot.texinfo (sendchange): document it
2904 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2905 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2906 (IStatus.getSchedulers): new method
2907 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2908 (Status.getSchedulers): implement
2909 * buildbot/process/builder.py (Builder): maintain
2910 BuilderStatus.pendingBuilds
2911 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2912 (TryBase.addChange): Try schedulers should ignore Changes
2914 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2915 for 'try' on CVS/SVN
2916 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2918 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2919 report status properly.
2920 (Try.createJob): implement unique buildset IDs
2922 * buildbot/status/client.py (StatusClientPerspective): add a
2923 perspective_getBuildSets method for the benefit of jobdir-style
2925 * docs/buildbot.texinfo (try): more docs
2926 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2929 2005-08-18 Brian Warner <warner@lothar.com>
2931 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2932 actually work. It's functional but still kind of clunky. Also, it
2933 only works with the pb-style.. needs to be made to work with the
2936 * buildbot/status/client.py (RemoteBuildSet): new class
2937 (RemoteBuildRequest): same
2938 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2939 object, not the internal BuildStatus object.
2940 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2941 outside of the usual buildStarted() return value.
2942 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2944 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2945 (Try_Userpass_Perspective.perspective_try): return a remotely
2946 usable BuildSetStatus object
2948 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2949 isStarted()/waitUntilStarted()
2951 2005-08-16 Brian Warner <warner@lothar.com>
2953 * buildbot/status/builder.py: implement IBuildSetStatus and
2954 IBuildRequestStatus, wire them into place.
2955 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2956 methods into the BuildSetStatus object.
2957 * buildbot/interfaces.py: same
2958 (IStatus.getBuildSets): new method to get pending BuildSets
2959 (IStatusReceiver.buildsetSubmitted): new method which hears about
2961 * buildbot/master.py (BuildMaster.submitBuildSet): same
2962 * buildbot/process/base.py (BuildRequest): same, replace
2963 waitUntilStarted with subscribe/unsubscribe
2964 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2965 subscribe instead of waitUntilStarted
2966 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2968 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2970 * buildbot/test/test_buildreq.py: update for new code
2971 * buildbot/test/test_control.py (Force.testRequest): same
2974 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2975 for Darcs to not use the tempfile module, so it works under
2976 python-2.2 too. We really didn't need the full cleverness of that
2977 module, since the slave has exclusive control of its own builddir.
2979 2005-08-15 Brian Warner <warner@lothar.com>
2981 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2982 for CVS trees. It doesn't work for non-trunk branches,
2984 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2987 * Makefile: make it easier to test against python2.2
2989 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2990 tearDown2, so things like Arch can unregister archives as they're
2991 shutting down. The previous subclass-override-tearDown technique
2992 resulted in a nested maybeWait() and test failures under
2995 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2996 where we can (Arch), add a branch= argument to set the branch used
2998 (BazExtractor): extract the branch too
2999 (TlaExtractor): same
3000 * buildbot/scripts/runner.py (TryOptions): add --branch
3001 * docs/buildbot.texinfo (try): document --branch/try_branch
3003 * buildbot/slave/commands.py (Darcs): implement get-revision for
3004 Darcs, so that 'try' will work. This requires the tempfile module
3007 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3008 of revisions, branches, and 'try' in the process.
3010 2005-08-11 Brian Warner <warner@lothar.com>
3012 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3013 this, it got broken at some point in the last few releases
3014 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3015 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3016 specifically the removal of ETA information from the tuple
3018 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3021 * docs/buildbot.texinfo (try): document both --builder and
3022 'try_builders' in .buildbot/options
3023 * buildbot/scripts/runner.py (TryOptions): add --builder,
3024 accumulate the values into opts['builders']
3025 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3026 * buildbot/test/test_runner.py (Try): add some quick tests to make
3027 sure 'buildbot try --options' and .buildbot/options get parsed
3028 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3029 use --builder control
3031 * docs/buildbot.texinfo (try): add --port argument to PB style
3033 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3034 actual SourceStamp. Still need to extract a branch name, somehow.
3035 (Try): finish implementing the try client side, still need a UI
3036 for specifying which builders to use
3037 (Try.getopt): factor our options/config-file reading
3038 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3040 * buildbot/test/test_vc.py: match SourceStampExtractor change
3042 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3043 causes the twisted log to be sent to stderr
3045 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3047 2005-08-10 Brian Warner <warner@lothar.com>
3049 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3050 style is 90% done, still missing status reporting or waiting for
3051 the buildsets to finish, and it is completely untested.
3053 * buildbot/trybuild.py: delete file, move contents to ..
3054 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3055 * buildbot/test/test_vc.py: match the move
3057 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3058 of the TryScheduler, no buildsetID or status-tracking support yet
3059 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3061 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3062 possible to set the basedir after __init__ time, so it is easier
3063 to use as a Service-child of the BuildMaster instance
3065 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3066 that delivers messages to its Service parent instead of requiring
3067 a subclass to be useful. This turns out to be much easier to build
3070 * buildbot/scripts/tryclient.py (createJob): utility code to
3071 create jobfiles, will eventually be used by 'buildbot try'
3073 2005-08-08 Brian Warner <warner@lothar.com>
3075 * docs/buildbot.texinfo (try): add docs on the
3076 as-yet-unimplemented Try scheduler
3078 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3079 * buildbot/test/test_scheduler.py: .. here
3080 (Scheduling.testTryJobdir): add placeholder test for 'try'
3082 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3083 addEntry merging (>=chunkSize) behavior
3084 (Log.testConsumer): update to handle new callLater(0) behavior
3086 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3087 both the MAX_LENGTH bugfix and the resumeProducing hang.
3089 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3090 put off the actual resumeProducing for a moment with
3091 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3092 causes large logfiles to hang midway through.
3094 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3095 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3096 and to improve memory usage when streaming the file out to a web
3098 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3099 make this work cleanly
3101 2005-08-03 Brian Warner <warner@lothar.com>
3103 * buildbot/trybuild.py: new file for 'try' utilities
3104 (getSourceStamp): run in a tree, find out the baserev+patch
3105 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3106 implemented for SVN and Darcs, still working on Arch. I don't know
3107 how to make CVS work yet.
3109 * docs/buildbot.texinfo: document the 'buildbot' command-line
3110 tool, including the not-yet-implemented 'try' feature, and the
3111 in-flux .buildbot/ options directory.
3113 2005-07-20 Brian Warner <warner@lothar.com>
3115 * buildbot/locks.py: added temporary id() numbers to Lock
3116 descriptions, to track down a not-really-sharing-the-Lock bug
3118 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3120 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3121 needed for python2.2 compatibility
3122 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3123 are from the __future__
3125 2005-07-19 Brian Warner <warner@lothar.com>
3127 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3128 message when schedulers use unknown builders
3130 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3131 SlaveLock('name') and MasterLock('name') are distinct
3133 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3134 c['schedulers'] in such a way that we can actually accept
3136 * buildbot/test/test_config.py: check it
3138 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3139 utility method to *all* the Schedulers
3140 (Periodic.listBuilderNames): same
3142 * docs/buildbot.texinfo (Interlocks): update chapter to match
3145 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3146 to make sure that c['sources'], c['schedulers'], and c['status']
3147 are all lists of the appropriate objects, and that the Schedulers
3148 all point to real Builders
3149 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3150 'listBuilderNames' utility method to support this
3151 * buildbot/scheduler.py: implement the utility method
3152 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3154 * docs/buildbot.texinfo: add some @cindex entries
3156 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3157 if it wasn't already set: most tla commands will fail unless one
3159 (Arch.createRepository): and disable bazaar's revision cache, since
3160 they cause test failures (the multiple repositories we create all
3161 interfere with each other through the cache)
3163 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3164 bring it properly up to date with twisted-2.0 test guidelines
3166 * buildbot/master.py (BuildMaster): remove references to old
3167 'interlock' module, this caused a bunch of post-merge test
3169 * buildbot/test/test_config.py: same
3170 * buildbot/process/base.py (Build): same
3172 * buildbot/test/test_slaves.py: stubs for new test case
3174 * buildbot/scheduler.py: add test-case-name tag
3175 * buildbot/test/test_buildreq.py: same
3177 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3178 unnecessary init code
3179 (Bot.remote_setBuilderList): match it
3181 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3183 * buildbot/changes/mail.py (parseSyncmail): update comment
3185 * buildbot/test/test_slavecommand.py: disable Shell tests on
3186 platforms that don't suport IReactorProcess
3188 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3189 all places where we open logfiles. It causes OS-X to open the file
3190 in some weird mode that that prevents us from mixing reads and
3191 writes to the same filehandle, which we depend upon to implement
3192 _generateChunks properly. This change doesn't appear to break
3193 win32, on which "b" and "t" are treated differently but a missing
3194 flag seems to be interpreted as "t".
3196 2005-07-18 Brian Warner <warner@lothar.com>
3198 * buildbot/slave/commands.py (ShellCommand): overhaul
3199 error-handling code, to try and make timeout/interrupt work
3200 properly, and make win32 happier
3201 * buildbot/test/test_slavecommand.py: clean up, stop using
3202 reactor.iterate, add tests for timeout and interrupt
3203 * buildbot/test/sleep.py: utility for a new timeout test
3205 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3206 code from the local-usebranches branch
3208 2005-07-17 Brian Warner <warner@lothar.com>
3210 * buildbot/process/process_twisted.py
3211 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3212 minutes, to match the other twisted BuildFactories, and don't
3213 excuse failures in c/qt/win32 reactors any more.
3215 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3216 'freebsd' builders, since the buildslaves have been unavailable
3219 2005-07-13 Brian Warner <warner@lothar.com>
3221 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3222 build-on-branch feature
3224 * buildbot/process/step.py (Darcs.__init__): add base_url and
3225 default_branch arguments, just like SVN
3226 (Arch.__init__): note that the version= argument is really the
3229 * buildbot/slave/commands.py (SourceBase): keep track of the
3230 repository+branch that was used for the last checkout in
3231 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3232 match, we clobber the directory and perform a fresh checkout
3233 rather than trying to do an in-place update. This should protect
3234 us against trying to get to branch B by doing an update in a tree
3235 obtained from branch A.
3236 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3237 (SVN.setup): same, just the svnurl
3238 (Darcs.setup): same, just the repourl
3239 (Arch.setup): same, arch coordinates (url), version, and
3240 buildconfig. Also pull the buildconfig from the args dictionary,
3241 which we weren't doing before, so the build-config was effectively
3243 (Arch.sourcedirIsUpdateable): don't try to update when we're
3244 moving to a specific revision: arch can't go backwards, so it is
3245 safer to just clobber the tree and checkout a new one at the
3247 (Bazaar.setup): same sourcedata as Arch
3249 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3250 use maybeWait, to work with twisted-1.3.0 and twcompat
3251 (Dependencies.testRun_Pass): same
3253 * buildbot/test/test_vc.py: rearrange, cleanup
3255 * buildbot/twcompat.py: add defer.waitForDeferred and
3256 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3257 can work under twisted-1.3.0 .
3259 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3260 now created at setUp time. This increases the runtime of the test
3261 suite considerably (from 91 seconds to 151), but it removes the
3262 need for an offline tarball, which should solve a problem I've
3263 seen where the test host has a different version of svn than the
3264 tarball build host. The new code also validates that mode=update
3265 really picks up recent commits. This approach will also make it
3266 easier to test out branches, because the code which creates the VC
3267 branches is next to the code which uses them. It will also make it
3268 possible to test some change-notification hooks, by actually
3269 performing a VC commit and watching to see the ChangeSource get
3272 2005-07-12 Brian Warner <warner@lothar.com>
3274 * docs/buildbot.texinfo (SVN): add branches example
3275 * docs/Makefile (buildbot.ps): add target for postscript manual
3277 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3278 * buildbot/test/test_locks.py: same
3280 * buildbot/process/step.py (Darcs): comment about default branches
3282 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3283 c['interlocks'] in the config file, complain if it is present.
3284 Scan all locks in c['builders'] to make sure the Locks they use
3286 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3287 add some tests to check for non-uniquely-named Locks
3288 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3289 since the unique-Lock validation code requires it now
3291 * buildbot/locks.py: fix test-case-name
3293 * buildbot/interlock.py: remove old file
3295 2005-07-11 Brian Warner <warner@lothar.com>
3297 * buildbot/test/test_interlock.py: rename to..
3298 * buildbot/test/test_locks.py: .. something shorter
3300 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3301 versions (after 2.0.1) changed internet.TCPClient to shut down the
3302 connection in stopService. Change the code to handle this
3305 * buildbot/process/base.py (Build): handle whole-Build locks
3306 * buildbot/process/builder.py (Builder.compareToSetup): same
3307 * buildbot/test/test_interlock.py: make tests work
3309 * buildbot/process/step.py (BuildStep.startStep): complain if a
3310 Step tries to claim a lock that's owned by its own Build
3311 (BuildStep.releaseLocks): typo
3313 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3314 file reloads don't replace unchanged Builders
3316 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3317 rewrite to cover new Locks instead of old c['interlocks']
3318 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3322 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3323 start the master and connect the buildslave
3325 * buildbot/process/step.py (FailingDummy.done): finish with a
3326 FAILURE status rather than raising an exception
3328 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3329 stringify a BuildRequest.reason that is None
3331 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3333 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3334 allow scheduler.Dependent to work
3335 * buildbot/buildset.py (BuildSet): set .reason and .results
3337 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3338 slaves, to make the test stop hanging. It still fails, of course,
3339 because I haven't even started to implement Locks.
3341 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3343 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3344 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3345 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3346 (Dependent): new class for downstream build dependencies
3347 * buildbot/test/test_dependencies.py: tests (still failing)
3349 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3351 2005-07-07 Brian Warner <warner@lothar.com>
3353 * buildbot/test/runutils.py (RunMixin): factored this class out..
3354 * buildbot/test/test_run.py: .. from here
3355 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3356 added new buildbot.locks tests (which all hang right now)
3357 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3358 * buildbot/process/step.py: claim/release per-BuildStep locks
3360 * docs/Makefile: add 'buildbot.html' target
3362 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3363 interpreted as "HEAD", so that all VC steps can accept branch=None
3364 and have it mean the "default branch".
3366 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3368 2005-07-07 Brian Warner <warner@lothar.com>
3370 * docs/examples/twisted_master.cfg: update to match current usage
3372 * docs/buildbot.texinfo (System Architecture): comment out the
3373 image, it doesn't exist yet and just screws up the HTML manual.
3375 2005-07-05 Brian Warner <warner@lothar.com>
3377 * debian/.cvsignore: oops, missed one. Removing leftover file.
3379 2005-06-17 Brian Warner <warner@lothar.com>
3381 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3382 changed its output in 1.2.0, don't mistakenly think that the
3383 subversion we find isn't capable of supporting our tests.
3385 * debian/*: remove the debian/ directory and its contents, to make
3386 life easier for the proper Debian maintainer
3388 * Makefile (release): same
3390 2005-06-07 Brian Warner <warner@lothar.com>
3392 * everything: create a distinct SourceStamp class to replace the
3393 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3394 Changed the signature of Source.startVC to include the revision
3395 information (instead of passing it through self.args). Implement
3396 branches for SVN (now only Darcs/Git is missing support). Add more
3399 2005-06-06 Brian Warner <warner@lothar.com>
3401 * everything: rearrange build scheduling. Create a new Scheduler
3402 object (configured in c['schedulers'], which submit BuildSets to a
3403 set of Builders. Builders can now use multiple slaves. Builds can
3404 be run on alternate branches, either requested manually or driven
3405 by changes. This changed some of the Status classes. Interlocks
3406 are out of service until they've been properly split into Locks
3407 and Dependencies. treeStableTimer, isFileImportant, and
3408 periodicBuild have all been moved from the Builder to the
3410 (BuilderStatus.currentBigState): removed the 'waiting' and
3411 'interlocked' states, removed the 'ETA' argument.
3413 2005-05-24 Brian Warner <warner@lothar.com>
3415 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3416 erroneously abandons the connection (in clientConnectionFailed)
3417 for non-UserErrors, which means that if we lose the connection due
3418 to a network problem or a timeout, we'll never try to reconnect.
3419 Fix this by not upcalling to the buggy parent method. Note:
3420 twisted-2.0 fixes this, but the function only has 3 lines so it
3421 makes more sense to copy it than to try and detect the buggyness
3422 of the parent class. Fixes SF#1207588.
3424 * buildbot/changes/changes.py (Change.branch): doh! Add a
3425 class-level attribute to accomodate old Change instances that were
3426 pickled before 0.6.5 (where .branch was added for new Changes).
3427 This fixes the exception that occurs when you try to look at an
3428 old Change (through asHTML).
3430 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3433 2005-05-23 Brian Warner <warner@lothar.com>
3435 * buildbot/__init__.py (version): release 0.6.6
3437 2005-05-23 Brian Warner <warner@lothar.com>
3439 * NEWS: update for 0.6.6 release
3440 * debian/changelog: same
3442 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3443 before starting: this was done by twistd back when we spawned it,
3444 now that we're importing the pieces and running them in the
3445 current process, we have to do it ourselves. This allows
3446 master.cfg to import files from the same directory without
3447 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3448 Stichele for the catch.
3449 (Options.opt_version): Add a --version command (actually, just make
3450 the existing --version command emit Buildbot's version too)
3452 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3453 fix to make this behave like other LogFiles, this time to handle
3454 existing LogFiles on disk. (add the missing .upgrade method)
3455 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3457 2005-05-21 Brian Warner <warner@lothar.com>
3459 * buildbot/test/test_runner.py (Create.testMaster): match the
3460 rawstring change in runner.py:masterTAC
3462 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3463 TwistedWords is installed
3464 * buildbot/test/test_status.py: same, with TwistedMail
3466 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3467 some old, deprecated, and removed config keys). This should enable
3468 you to use the base buildbot functionality with Twisted-2.0.0 when
3469 you don't also have TwistedWeb and TwistedWords installed
3471 2005-05-20 Brian Warner <warner@lothar.com>
3473 * buildbot/scripts/runner.py (run): call sendchange(), not
3474 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3475 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3476 (stop): don't wait for process to die when sending SIGHUP
3477 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3478 directory name gets interpreted, which you don't want
3481 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3484 2005-05-18 Brian Warner <warner@lothar.com>
3486 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3488 2005-05-18 Brian Warner <warner@lothar.com>
3490 * README: update for 0.6.5
3491 * debian/changelog: same
3493 * buildbot/changes/changes.py: rename tag= to branch=, since
3494 that's how we're using it, and my design for the upcoming "build a
3495 specific branch" feature wants it. also, tag= was too CVS-centric
3496 * buildbot/changes/mail.py (parseSyncmail): same
3497 * buildbot/process/base.py (Build.isBranchImportant): same
3498 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3499 * docs/buildbot.texinfo (Attributes of Changes): same
3501 * NEWS: update tag=, update for upcoming release
3503 2005-05-17 Brian Warner <warner@lothar.com>
3505 * buildbot/scripts/runner.py (stop): actually poll once per
3506 second, instead of re-killing the poor daemon once per second.
3507 Sleep briefly (0.1s) before the first poll, since there's a good
3508 chance we can avoid waiting the full second if the daemon shuts
3509 down quickly. Also remove the sys.exit() at the end.
3510 (start): remove the unneighborly sys.exit()
3512 * Makefile: improve permission-setting to not kick Arch so badly
3514 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3515 default --keepalive=600, since it doesn't hurt very much, and it's
3516 a hassle to discover that you need it.
3517 * buildbot/test/test_runner.py (Create.testSlave): test it
3519 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3520 IRC bot about EXCEPTION
3522 * buildbot/status/client.py (PBListener): upcall more correctly
3524 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3525 an exception mark the overall build with EXCEPTION, not SUCCESS
3527 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3529 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3530 * Makefile: update some release-related stuff
3532 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3533 gets called when there isn't actually an active process, just end
3534 the Command instead of blowing up. I don't know how it gets into
3535 this state, but the twisted win32 buildslave will sometimes hang,
3536 and when it shakes its head and comes back, it thinks it's still
3537 running a Command. The next build causes this command to be
3538 interrupted, but the lack of self.process.pid breaks the interrupt
3541 * NEWS: document changes since the last release
3543 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3544 look for Makefile.buildbot instead of a bare Makefile . The
3545 'buildbot start' does not install this file, so you have to
3546 manually copy it if you want to customize startup behavior.
3547 (createMaster): change 'buildbot master' command to create
3548 Makefile.sample instead of Makefile, to create master.cfg.sample
3549 instead of master.cfg (requiring you to copy it before the
3550 buildmaster can be started). Both sample files are kept up to
3551 date, i.e. they are overwritten if they have been changed. The
3552 'buildbot.tac' file is *not* overwritten, but if the new contents
3553 don't match the old, a 'buildbot.tac.new' file is created and the
3554 user is warned. This seems to be a much more sane way to handle
3555 startup files. Also, don't sys.exit(0) when done, so we can run
3556 unit tests against it.
3557 (createSlave): same. Don't overwrite the sample info/ files.
3558 * buildbot/scripts/sample.mk: remove. the contents were pulled
3559 into runner.py, since they need to match the behavior of start()
3563 * docs/buildbot.texinfo (Launching the daemons): document it
3564 * buildbot/test/test_runner.py (Create): test it
3566 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3567 version that can handle string-in-string tests, because otherwise
3568 python-2.2 fails the tests. It'd be tremendous if Trial's test
3569 took two strings under 2.2 too.
3571 * everything: fixed all deprecation warnings when running against
3572 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3573 few that come from Twisted itself). This involved putting most of
3574 the Twisted-version specific code in the new buildbot.twcompat
3575 module, and creating some abstract base classes in
3576 buildbot.changes.base and buildbot.status.base (which might be
3577 useful anyway). __implements__ is a nuisance and requires an ugly
3578 'if' clause everywhere.
3580 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3581 delay before finishing the test: it seems that smtp.sendmail
3582 doesn't hang up on the server, so we must wait a moment so it can
3583 hang up on us. This removes the trial warning about an unclean
3586 2005-05-16 Brian Warner <warner@lothar.com>
3588 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3589 tuple of (delay, repeats).
3590 * buildbot/test/test_vc.py (Retry): test it
3591 * docs/buildbot.texinfo (Source Checkout): document it
3592 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3593 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3594 doVCFull() are handled by re-trying the checkout (after a delay)
3595 some number of times.
3596 (ShellCommand._startCommand): make header lines easier to read
3598 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3600 (WebTest.test_logfile): make sure master gets shut down, silences
3601 some "unclean reactor" test errors
3603 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3604 reactor once after shutdown, something in certain versions of
3605 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3606 fails, svn-trunk is ok.
3608 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3609 second win32 error message
3611 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3612 validating the ETA, so the tests don't fail on slow systems
3614 2005-05-15 Brian Warner <warner@lothar.com>
3616 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3617 the new LogFile class, so upgrading works properly
3618 (LogFileProducer.resumeProducing): survive resumeProducing after
3619 we've exhausted the chunkGenerator
3621 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3623 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3624 (Log.testUpgrade): same
3626 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3627 Builds and logs with a cron job.
3629 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3630 of the old non-offline LogFile, added code to upgrade these to
3631 new-style contents-live-on-disk instances at load time (in a way
3632 that doesn't invalidate the old Build pickles, so upgrading to
3633 0.6.5 is not a one-way operation). Got rid of everything related
3635 (LogFile.__init__): create LogFiles with the parent step status,
3636 the log's name, and a builder-relative filename where it can keep
3637 the contents on disk.
3638 (LogFile.hasContents): new method, clients are advised to call it
3639 before getText or getChunks and friends. If it returns False, the
3640 log's contents have been deleted and getText() will raise an
3642 (LogFile.getChunks): made it a generator
3643 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3644 Consumer (except one that takes chunks instead of strings). This
3645 enables streaming of very large logfiles without storing the whole
3647 (BuildStatus.generateLogfileName): create names like
3648 12-log-compile-output, with a _0 suffix if required to be unique
3649 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3650 or earlier) logfiles into new-style ones
3651 (BuilderStatus): remove everything related to 'stub' builds. There
3652 is now only one build cache, and we don't strip logs from old
3654 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3655 since we no longer fight to keep it in the cache
3657 * buildbot/status/html.py (TextLog.render_GET): use a
3658 ChunkConsumer to stream the log entries efficiently.
3659 (ChunkConsumer): wrapper which consumes chunks and writes
3662 * buildbot/test/test_twisted.py (Parse.testParse): use a
3663 LogFile-like object instead of a real one
3665 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3666 (Log.testMerge3): validate more merge behavior
3667 (Log.testChunks): validate LogFile.getChunks
3668 (Log.testUpgrade): validate old-style LogFile upgrading
3669 (Log.testSubscribe): validate LogFile.subscribe
3670 (Log.testConsumer): validate LogFile.subscribeConsumer
3672 * buildbot/interfaces.py (IStatusLogStub): remove
3673 (IStatusLog.subscribeConsumer): new method
3674 (IStatusLog.hasContents): new method
3675 (IStatusLogConsumer): describes things passed to subscribeConsumer
3677 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3678 the log contents if it does not have any contents.
3679 (StatusResourceBuildStep.body): same
3680 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3682 2005-05-14 Brian Warner <warner@lothar.com>
3684 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3685 timeouts to try and make the windows metabuildslave not hang
3687 2005-05-13 Mike Taylor <bear@code-bear.com>
3689 * buildbot/slave/commands.py (rmdirRecursive): added a check
3690 to ensure the path passed into rmdirRecursive actually exists.
3691 On win32 a non-existant path would generate an exception.
3693 2005-05-13 Brian Warner <warner@lothar.com>
3695 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3696 shutil.rmtree which behaves correctly on windows in the face of
3697 files that you have to chmod before deleting. Thanks to Bear at
3698 the OSAF for the routine.
3699 (SourceBase.doClobber): use rmdirRecursive
3701 2005-05-12 Brian Warner <warner@lothar.com>
3703 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3704 method generate chunks instead of returning a big list. This
3705 allows the same method to be used for both old LogFile and new
3707 (OfflineLogFile.getText): use the generator
3708 (OfflineLogFile.subscribe): same
3709 * buildbot/status/html.py (TextLog.resumeProducing): same
3710 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3712 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3713 point out that OfflineLogFile does not currently work with
3714 html.Waterfall . Fixing this is high-priority.
3716 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3717 apparently windows defaults to using stdout
3719 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3720 better message on failure so I can figure out the win32 problem
3722 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3723 log messages to include more useful copies of the command being
3724 run, the argv array, and the child command's environment.
3725 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3727 2005-05-11 Brian Warner <warner@lothar.com>
3729 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3731 * Makefile: update the deb-snapshot version
3733 * docs/buildbot.texinfo: move all .xhtml docs into a new
3734 .texinfo-format document, adding a lot of material in the process.
3735 This is starting to look like a real user's manual. Removed all
3736 the Lore-related files: *.xhtml, *.css, template.tpl .
3737 * docs/Makefile: simple makefile to run 'makeinfo'
3738 * buildbot/scripts/sample.cfg: rearrange slightly
3739 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3741 2005-05-10 Brian Warner <warner@lothar.com>
3743 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3744 different name for the internal twistw module, handle it.
3746 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3747 * setup.py: .. and stop trying to install it
3749 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3750 'git'), the new linux kernel VC system (http://kernel.org/git/).
3751 Thanks to Brandon Philips for the patch.
3752 * buildbot/slave/commands.py (Git): same
3754 2005-05-06 Brian Warner <warner@lothar.com>
3756 * buildbot/status/builder.py (OfflineLogFile): replace the default
3757 LogFile with a form that appends its new contents to a disk file
3758 as they arrive. The complete log data is never kept in RAM. This
3759 is the first step towards handling very large (100MB+) logfiles
3760 without choking quite so badly. (The other half is
3761 producer/consumer on the HTML pages).
3762 (BuildStepStatus.addLog): use OfflineLogFile by default
3763 (BuildStatus.getLogfileName): helper code to give the
3764 OfflineLogFile a filename to work with
3766 * buildbot/test/test_status.py (Results.testAddResults): update
3767 tests to handle new asserts
3768 * buildbot/test/test_vc.py (Patch.doPatch): same
3769 * buildbot/test/test_steps.py (BuildStep.setUp): same
3771 2005-05-05 Brian Warner <warner@lothar.com>
3773 * buildbot/scripts/runner.py (start): if there is no Makefile,
3774 launch the app by importing twistd's internals and calling run(),
3775 rather than spawning a new twistd process. This stands a much
3776 better chance of working under windows.
3777 (stop): kill the process with os.kill instead of spawning
3778 /bin/kill, again to reduce the number of external programs which
3779 windows might not have in the PATH. Also wait up to 5 seconds for
3780 the process to go away, allowing things like 'buildbot stop;
3781 buildbot start' to be reliable in the face of slow shutdowns.
3783 * buildbot/master.py (Dispatcher.__getstate__): remove old
3784 .tap-related methods
3785 (BuildMaster.__getstate__): same
3787 * buildbot/slave/bot.py (makeService): same
3788 (Options.longdesc): same
3789 * buildbot/scripts/runner.py: copy over some old mktap option text
3791 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3792 'buildbot master' now creates a buildbot.tac file, so there is no
3793 longer a create-instance/save/reload sequence. mktap is dead, long
3795 * buildbot/scripts/sample.mk: use twistd -y, not -f
3796 * buildbot/test/test_config.py: remove mktap-based test
3797 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3798 * README: don't reference mktap
3800 * docs/source.xhtml: document some of the attributes that Changes
3803 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3805 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3806 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3807 * buildbot/changes/changes.py (Change)
3808 * buildbot/changes/mail.py (parseSyncmail)
3809 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3811 * buildbot/process/base.py (Build.isTagImportant)
3815 2005-05-04 Brian Warner <warner@lothar.com>
3817 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3818 connection after sending the change, so that unit tests don't
3819 complain about sockets being left around
3821 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3822 exception in phase=0 rendering
3823 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3825 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3827 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3828 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3829 and configuring builders with tuples.
3830 * buildbot/test/test_config.py: stop testing compatibility with
3831 deprecated config keys
3832 * buildbot/test/test_run.py: same
3834 2005-05-03 Brian Warner <warner@lothar.com>
3836 * contrib/arch_buildbot.py: survive if there are no logfiles
3837 (username): just use a string, os.getlogin isn't reliable
3839 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3840 so 'buildbot sendchange' actually works. The earlier test only
3841 covered the internal (non-reactor-running) form.
3843 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3844 script to notify the buildmaster about changes
3846 * buildbot/scripts/runner.py (sendchange): new command to send a
3847 change to a buildbot.changes.pb.PBChangeSource receiver.
3848 * buildbot/test/test_changes.py (Sender): test it
3850 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3851 after any reading of the config file, not just when we do it in
3852 startService. This makes some tests a bit cleaner.
3854 * buildbot/changes/pb.py: add some log messages
3856 * buildbot/process/base.py (Build.startBuild): fix a bug that
3857 caused an exception when the build terminated in the very first
3859 (Build.stepDone): let steps return a status of EXCEPTION. This
3860 terminates the build right away, and sets the build's overall
3861 status to EXCEPTION too.
3862 * buildbot/process/step.py (BuildStep.failed): return a status of
3863 EXCEPTION when that is what has happened.
3865 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3866 implement this, allowing Arch-based projects to get precise
3867 checkouts instead of always using the latest code
3868 (Bazaar): create variant of Arch to let folks use baz instead of
3869 tla. Requires a new buildslave too.
3870 * buildbot/slave/commands.py (Arch): add 'revision' argument
3871 (Bazaar): create variant of Arch that uses baz instead of tla.
3872 Remove the code that extracts the archive name from the
3873 register-archive output, since baz doesn't provide it, and require
3874 the user provide both the archive name and its location.
3875 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3877 2005-05-02 Brian Warner <warner@lothar.com>
3879 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3880 thanks to Nick Trout.
3882 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3883 deals better with source Makefile coming from a read-only CVS
3884 checkout. Thanks to Nick Trout for the catch.
3886 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3889 2005-04-28 Brian Warner <warner@lothar.com>
3891 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3893 * debian/changelog: update for 0.6.4
3895 2005-04-28 Brian Warner <warner@lothar.com>
3897 * README.w32: add a checklist of steps for getting buildbot
3899 * MANIFEST.in: include it in the tarball
3903 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3904 broken .tap files from 0.6.3 by getting rid of .services,
3905 .namedServices, and .change_svc at load time.
3907 2005-04-27 Brian Warner <warner@lothar.com>
3909 * NEWS: update in preparation for new release
3911 * buildbot/test/test_config.py (Save.testSave): don't pull in
3912 twisted.scripts.twistd, we don't need it and it isn't for windows
3915 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3916 accomodate win32 which can't do atomic-rename
3918 2005-04-27 Brian Warner <warner@lothar.com>
3920 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3921 timeouts to help the slow metabuildbot not flunk them so much
3922 (Disconnect.testBuild3): same
3923 (Disconnect.testBuild4): same
3924 (Disconnect.testInterrupt): same
3926 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3927 setup, it was completely broken for new buildmasters (those which
3928 did not have a 'change.pck' already saved. Thanks to Paul Warren
3929 for catching this (embarrassing!) bug.
3930 (Dispatcher.__getstate__): don't save our registered avatar
3931 factories, since they'll be re-populated when the config file is
3933 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3934 tests (since the real mktap-generated BuildMaster doesn't save
3936 (BuildMaster.__getstate__): don't save any service children,
3937 they'll all be re-populated when the config file is re-read.
3938 * buildbot/test/test_config.py (Save.testSave): test for this
3940 2005-04-26 Brian Warner <warner@lothar.com>
3942 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3943 rendered with Blender.. looks a bit nicer.
3944 * buildbot/docs/images/icon.blend: add the Blender file for it
3946 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3947 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3948 running under windows. This appears to be the best way to allow
3949 BuildSteps to do something normal like 'trial -v buildbot.test' or
3950 'make foo' and still expect it to work. The idea is to make the
3951 BuildSteps look as much like what a developer would type when
3952 compiling or testing the tree by hand. This approach probably has
3953 problems when there are spaces in the arguments, so if you've got
3954 windows buildslaves, you'll need to pay close attention to your
3957 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3958 timezone to the timestamp column.
3959 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3961 * buildbot/scripts/runner.py (loadOptions): do something sane for
3962 windows, I think. We use %APPDATA%/buildbot instead of
3963 ~/.buildbot, but we still search everywhere from the current
3964 directory up to the root for a .buildbot/ subdir. The "is it under
3965 $HOME" security test was replaced with "is it owned by the current
3966 user", which is only performed under posix.
3967 * buildbot/test/test_runner.py (Options.testFindOptions): update
3968 tests to match. The "is it owned by the current user" check is
3969 untested. The test has been re-enabled for windows.
3971 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3972 any "\n" in the expected output with the platform-specific line
3973 separator. Make this separator "\r\n" on PTYs under unix, they
3974 seem to do that and I don't know why
3976 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3977 windows for now, I don't know what ~/.buildbot/ should mean there.
3979 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3980 win32 compatibility, don't use "/tmp"
3981 (Basedir.testChangeBuilddir): remove more unixisms
3983 2005-04-26 Brian Warner <warner@lothar.com>
3985 * buildbot/test/test_control.py (Force.rmtree): python2.2
3986 compatibility, apparently its shutil.rmtree ignore_errors=
3987 argument is ignored.
3988 * buildbot/test/test_run.py (Run.rmtree): same
3989 (RunMixin.setUp): same
3991 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3994 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3995 'substring in string' operator, must use string.find(substr)!=-1
3996 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3997 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3999 * buildbot/scripts/runner.py (loadOptions): add code to search for
4000 ~/.buildbot/, a directory with things like 'options', containing
4001 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4002 the current directory, your $HOME directory, or anywhere
4003 inbetween, as long as you're somewhere inside your home directory.
4004 (debugclient): look in ~/.buildbot/options for master and passwd
4005 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4006 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4008 * buildbot/status/client.py (makeRemote): new approach to making
4009 IRemote(None) be None, which works under Twisted-2.0
4010 * buildbot/test/test_status.py (Client.testAdaptation): test it
4012 * buildbot/status/builder.py (Status.builderAdded): when loading a
4013 pickled BuilderStatus in from disk, set its name after loading.
4014 The config file might have changed its name (but not its
4015 directory) while it wasn't looking.
4017 * buildbot/process/builder.py (Builder.attached): always return a
4018 Deferred, even if the builder was already attached
4019 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4021 2005-04-25 Brian Warner <warner@lothar.com>
4023 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4024 category-related exception when announcing a build has finished
4026 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4027 reference no-longer-existent changemaster.sources
4028 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4030 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4033 2005-04-25 Brian Warner <warner@lothar.com>
4035 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4037 * debian/changelog: update for 0.6.3
4039 2005-04-25 Brian Warner <warner@lothar.com>
4041 * MANIFEST.in: make sure debug.glade is in the tarball
4043 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4045 * NEWS: update for the imminent 0.6.3 release
4047 * buildbot/status/html.py (HtmlResource.content): make the
4048 stylesheet <link> always point at "buildbot.css".
4049 (StatusResource.getChild): map "buildbot.css" to a static.File
4050 containing whatever css= argument was provided to Waterfall()
4051 (Waterfall): provide the "classic" css as the default.
4052 * docs/waterfall.classic.css: move default CSS from here ..
4053 * buildbot/status/classic.css: .. to here
4055 * MANIFEST.in: make sure classic.css is included in the tarball
4056 * setup.py: and that it is installed too, under buildbot/status/
4058 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4059 the module level, because buildbot.tap files from 0.6.2 don't have
4060 it in their attribute dictionary.
4062 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4063 really exists at startup, might save some confusion somewhere.
4065 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4067 * docs/waterfall.classic.css:
4068 add a stylesheet that's almost the same as the "classic"
4071 * buildbot/status/builder.py:
4072 add EXCEPTION as a result - this is a problem for the bot
4073 maintainer, not a build problem for the changers
4074 * buildbot/process/step.py:
4075 use EXCEPTION instead of FAILURE for exceptions
4076 * buildbot/status/html.py:
4077 add build_get_class to get a class out of a build/buildstep
4078 finish naming the classes
4079 split out sourceNames to changeNames and builderNames so we
4080 can style them separately
4081 * docs/config.xhtml:
4082 finish documenting classes as they are right now
4084 * buildbot/status/html.py:
4085 name the classes as we agreed on IRC
4086 * docs/config.xhtml:
4089 * buildbot/status/html.py:
4090 same for cssclass->class_
4092 * buildbot/status/html.py:
4093 as decided on IRC, use class_ for the "class" attribute to not
4094 conflict with the class keyword, and clean up the messy **{} stuff.
4096 * buildbot/status/mail.py:
4097 put back "builders" argument, and fix docstring, because the
4098 code *ignores* builders listed in this argument
4100 * buildbot/process/builder.py:
4101 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4103 * docs/config.xhtml:
4104 describe the category argument for builders
4106 * buildbot/status/builder.py:
4107 Fix a silly bug due to merging
4109 * buildbot/process/builder.py:
4110 remove category from the process Builder ...
4111 * buildbot/status/builder.py:
4112 ... and add it to BuilderStatus instead.
4113 Set category on unpickled builder statuses, they might not have it.
4114 * buildbot/master.py:
4115 include category when doing builderAdded
4116 * buildbot/status/mail.py:
4117 return None instead of self for builders we are not interested in.
4118 * buildbot/test/test_run.py:
4119 fix a bug due to only doing deferredResult on "dummy" waiting
4120 * buildbot/test/test_status.py:
4121 add checks for the Mail IStatusReceiver returning None or self
4123 * buildbot/status/html.py:
4124 fix testsuite by prefixing page title with BuildBot
4126 * buildbot/status/builder.py:
4127 have .category in builder status ...
4128 * buildbot/process/builder.py:
4129 ... and set it from Builder
4130 * buildbot/status/html.py:
4131 make .css a class variable
4132 * buildbot/test/test_status.py:
4133 write more tests to cover our categories stuff ...
4134 * buildbot/status/mail.py:
4135 ... and fix the bug that this uncovered
4137 * buildbot/changes/mail.py:
4138 * buildbot/changes/pb.py:
4139 * buildbot/master.py:
4140 * buildbot/process/base.py:
4141 * buildbot/process/factory.py:
4142 * buildbot/process/interlock.py:
4143 * buildbot/process/step.py:
4144 * buildbot/process/step_twisted.py:
4145 * buildbot/slave/commands.py:
4146 * buildbot/status/builder.py:
4147 * buildbot/status/client.py:
4148 * buildbot/status/html.py:
4149 * buildbot/status/mail.py:
4150 * buildbot/status/progress.py:
4151 * buildbot/test/test_changes.py:
4152 * buildbot/test/test_config.py:
4153 * buildbot/test/test_control.py:
4154 * buildbot/test/test_interlock.py:
4155 * buildbot/test/test_maildir.py:
4156 * buildbot/test/test_mailparse.py:
4157 * buildbot/test/test_run.py:
4158 * buildbot/test/test_slavecommand.py:
4159 * buildbot/test/test_status.py:
4160 * buildbot/test/test_steps.py:
4161 * buildbot/test/test_twisted.py:
4162 * buildbot/test/test_util.py:
4163 * buildbot/test/test_vc.py:
4164 * buildbot/test/test_web.py:
4166 add test-case-name at the top of a whole set of files
4168 * buildbot/status/builder.py:
4169 keep order of addition when getting builder names
4170 * buildbot/status/words.py:
4171 * buildbot/test/test_run.py:
4172 add test for getBuilderNames
4174 * buildbot/process/base.py:
4175 * buildbot/process/step.py:
4176 * buildbot/status/builder.py:
4177 * buildbot/status/html.py:
4178 make buildbot css-able
4179 replace the color code for purple with purple, don't understand
4180 why it wasn't purple to start with
4182 * buildbot/status/words.py:
4183 ok, so it doesn't look like BuilderStatus.remote is still valid.
4184 Use what waterfall uses instead.
4186 * buildbot/interfaces.py:
4187 * buildbot/status/builder.py:
4188 * buildbot/status/html.py:
4189 * buildbot/status/mail.py:
4190 * buildbot/status/words.py:
4191 * buildbot/test/test_run.py:
4192 use categories everywhere and make it be a list. More sensible
4193 for the future. Also make words actually respect this in
4196 * buildbot/interfaces.py:
4197 add category argument to getBuilderNames
4198 * buildbot/process/builder.py:
4199 * buildbot/status/builder.py:
4200 * buildbot/status/html.py:
4201 * buildbot/status/mail.py:
4202 * buildbot/status/words.py:
4203 * buildbot/test/test_run.py:
4204 move from specifying builders by name to specifying the category
4206 * buildbot/status/html.py:
4207 * buildbot/status/words.py:
4208 add "builders=" to __init__ of status clients so they can
4209 limit themselves to the given list of builders to report on
4211 * buildbot/status/html.py: set the title to the product name
4213 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4215 * buildbot/interfaces.py:
4216 * buildbot/status/builder.py:
4217 more documentation. Hm, not sure if ChangeLog entries make sense
4220 2005-04-23 Brian Warner <warner@lothar.com>
4222 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4224 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4226 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4227 the sub-commands that log buildmaster status to stdout and to a
4228 GUI window, respectively.
4230 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4231 functionality is working again, but all the step-status and ETA
4232 stuff is missing. Commented out a lot of code pending more
4235 * buildbot/status/client.py: make sure that IRemote(None) is None
4237 * buildbot/changes/changes.py: import defer, oops
4238 (ChangeMaster): remove the .sources list, rely upon the fact that
4239 MultiServices can be treated as sequences of their children. This
4240 cleans up the add/remove ChangeSource routines a lot, as we keep
4241 exactly one list of the current sources instead of three.
4243 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4244 up an empty ChangeMaster at init time.
4245 (BuildMaster.loadChanges): if there are changes to be had from
4246 disk, replace self.change_svc with the new ones. If not, keep
4247 using the empty ChangeMaster set up in __init__.
4248 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4249 instead of a separate list, makes the code a bit cleaner.
4250 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4251 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4252 Extend the test to make sure we can get rid of the sources when
4255 2005-04-22 Brian Warner <warner@lothar.com>
4257 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4258 and info/host files when making the slave directory
4260 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4261 whendone= argument, just return the Deferred and let the caller do
4262 what they want with it.
4263 (Disconnect.testBuild1): wait for shutdownSlave
4264 (Basedir.testChangeBuilddir): new test to make sure changes to the
4265 builddir actually get propagated to the slave
4267 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4268 explicit method, rather than passing the builddir in __init__ .
4269 Make sure to update self.basedir too, this was broken before.
4270 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4271 builders and for ones that have just had their builddir changed.
4272 (BotFactory): add a class-level .perspective attribute, so
4273 BuildSlave.waitUntilDisconnected won't get upset when the
4274 connection hasn't yet been established
4275 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4276 tests can reach through it to inspect the SlaveBuilders
4278 * buildbot/process/base.py (Build.buildException): explain the
4279 log.err with a log.msg
4280 * buildbot/process/builder.py (Builder.startBuild): same
4281 (Builder._startBuildFailed): improve error message
4283 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4284 occurred because we lost the brand-new connection, retry instead
4285 of giving up. If not, it's probably an authorization failure, and
4286 it makes sense to stop trying. Make sure we log.msg the reason
4287 that we're log.err'ing the failure, otherwise test failures are
4288 really hard to figure out.
4290 * buildbot/master.py: change loadConfig() to return a Deferred
4291 that doesn't fire until the change has been fully implemented.
4292 This means any connected slaves have been updated with the new
4293 builddir. This change makes it easier to test the code which
4294 actually implements this builddir-updating.
4295 (BotPerspective.addBuilder): return Deferred
4296 (BotPerspective.removeBuilder): same
4297 (BotPerspective.attached): same
4298 (BotPerspective._attached): same. finish with remote_print before
4299 starting the getSlaveInfo, instead of doing them in parallel
4300 (BotPerspective.list_done): same
4301 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4302 actually calling slave.disconnect()
4303 (BotMaster.addBuilder): same
4304 (BotMaster.removeBuilder): same
4305 (BuildMaster.loadConfig): same
4306 (BuildMaster.loadConfig_Slaves): same
4307 (BuildMaster.loadConfig_Sources): same
4308 (BuildMaster.loadConfig_Builders): same
4309 (BuildMaster.loadConfig_status): same
4311 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4312 a Deferred that fires when the source is finally removed
4314 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4315 the previous tree on win32, where we have to do it synchronously,
4316 make sure we return a Deferred anyway.
4317 (SourceBase.doCopy): same
4319 * buildbot/scripts/runner.py (statusgui): use the text client for
4320 now, while I rewrite the Gtk one
4321 * buildbot/clients/base.py: strip out old code, leaving just the
4322 basic print-message-on-event functionality. I also remove the
4323 ReconnectingPBClientFactory, but it does at least quit when it
4324 loses the connection instead of going silent
4326 2005-04-21 Brian Warner <warner@lothar.com>
4328 * Makefile: minor tweaks
4330 * NEWS: point out deprecation warnings, new features for
4333 * buildbot/master.py (BuildMaster.loadConfig): emit
4334 DeprecationWarnings for Builders defined with tuples. Rearrange
4335 code to facility removal of deprecated configuration keys in the
4338 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4339 'buildbot' command to put a little Makefile in the target that
4340 helps you re-create the buildbot.tap file, start or stop the
4341 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4342 all the files 0600, since they contain passwords.
4343 (start): if there is a Makefile, and /usr/bin/make exists, use
4344 'make start' in preference to a raw twistd command. This lets
4345 slave admins put things like PYTHONPATH variables in their
4346 Makefiles and have them still work when the slave is started with
4347 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4348 be nice to first try the 'make' command and only fall back to
4349 twistd if it fails. TODO: the Makefile's "start" command does not
4350 add the --reactor=win32 argument when running under windows.
4351 (Options.debugclient, Options.statusgui): add sub-commands to launch
4352 the debug client (formerly in contrib/debugclient.py) and the
4353 Gtk status application (currently broken)
4354 * buildbot/clients/debug.py: move from contrib/debugclient.py
4355 * buildbot/clients/debug.glade: same
4357 * buildbot/test/test_trial.py: remove it. This requires some
4358 functionality out of Twisted that isn't there yet, and until then
4359 having it around just confuses things.
4361 * buildbot/test/test_slavecommand.py (Shell): test both with and
4362 without PTYs, and make sure that command output is properly
4363 interleaved in the with-PTY case. I think the without-PTY test
4364 should pass on windows, where we never use PTYs anyway.
4366 2005-04-20 Brian Warner <warner@lothar.com>
4368 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4370 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4372 * NEWS: start creating entries for the next release
4374 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4376 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4377 (WebTest.test_webPathname): same
4378 (WebTest.test_webPathname_port): same
4379 (WebTest.test_waterfall): use the default favicon rather than
4380 rooting around the filesystem for it. Open the expected-icon file
4381 in binary mode, to make win32 tests happier (thanks to Nick Trout
4383 * buildbot/status/html.py (buildbot_icon): win32 portability
4385 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4386 win32-compatibility fixes from Nick Trout, the "file not found" message
4387 is different under windows
4388 (FakeSlaveBuilder.__init__): clean up setup a bit
4389 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4391 2005-04-19 Brian Warner <warner@lothar.com>
4393 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4394 skip-if-repositories-are-unavailable test to not kill the trial
4395 that comes with Twisted-1.3.0
4397 * setup.py: install buildbot.png icon file when installing code
4399 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4400 environment used by the command, at least on the child side.
4402 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4403 this method needs to be added and implemented because it gets
4404 called under heavy load. I don't quite understand the
4405 producer/consumer API enough to write it.
4406 (StatusResource.getChild): add a resource for /favicon.ico
4407 (Waterfall.__init__): add favicon= argument
4408 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4409 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4410 (WebTest.test_webPathname): same
4411 (WebTest.test_webPathname_port): same
4412 * docs/config.xhtml: mention favicon=
4413 * buildbot/buildbot.png: add a default icon, dorky as it is
4415 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4417 * buildbot/master.py:
4418 * buildbot/process/base.py:
4419 * buildbot/process/builder.py:
4420 * buildbot/process/interlock.py:
4421 * buildbot/status/builder.py:
4422 * buildbot/status/html.py:
4423 * buildbot/status/mail.py:
4424 * buildbot/status/words.py:
4425 new documentation while digging through the code
4427 2005-04-17 Brian Warner <warner@lothar.com>
4429 * general: try to fix file modes on all .py files: a+r, a-x,
4430 but let buildbot/clients/*.py be +x since they're tools
4432 * docs/epyrun (addMod): when an import fails, say why
4434 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4436 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4438 * buildbot/process/base.py:
4439 * buildbot/process/builder.py:
4440 * buildbot/status/builder.py:
4441 new documentation while digging through the code
4443 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4445 * buildbot/changes/changes.py:
4446 * buildbot/changes/p4poller.py:
4447 * buildbot/interfaces.py:
4448 * buildbot/process/base.py:
4449 * buildbot/process/builder.py:
4450 * buildbot/process/step.py:
4451 * buildbot/process/step_twisted.py:
4452 * buildbot/slave/bot.py:
4453 * buildbot/slave/commands.py:
4454 * buildbot/status/builder.py:
4455 fix all docstrings to make epydoc happy. In the process of fixing
4456 some, I also moved pieces of docs, and removed some deprecated
4459 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4461 * buildbot/process/builder.py:
4462 * buildbot/process/interlock.py:
4463 * buildbot/process/process_twisted.py:
4464 * buildbot/process/step.py:
4465 BuildProcess -> Build, as it looks like that's what happened
4466 * buildbot/process/base.py:
4467 * buildbot/process/factory.py:
4470 2005-04-17 Brian Warner <warner@lothar.com>
4472 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4473 update compile command to accomodate the Twisted split.. now
4474 instead of './setup.py build_ext -i', you do './setup.py all
4475 build_ext -i', to run build_ext over all sub-projects.
4476 (FullTwistedBuildFactory): same
4477 (TwistedReactorsBuildFactory): same
4479 * buildbot/status/html.py (TextLog.finished): null out self.req
4480 when we're done, otherwise the reference cycle of TextLog to .req
4481 to .notifications to a Deferred to TextLog.stop keeps them from
4482 being collected, and consumes a huge (610MB on pyramid at last
4483 check) amount of memory.
4485 2005-04-11 Brian Warner <warner@lothar.com>
4487 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4488 normalize the VC-repository location.. makes SVN happier with
4489 certain test environments.
4491 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4492 RemoteShellCommand gets its own .env dictionary, so that code in
4493 start() doesn't mutate the original. I think this should fix the
4494 step_twisted.Trial problem where multiple identical components
4495 kept getting added to PYTHONPATH= over and over again.
4497 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4498 adding epydoc-format docstrings to many classes. Thanks to Thomas
4499 Vander Stichele for the patches.
4500 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4501 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4502 * buildbot/slave/bot.py, commands.py, registry.py: same
4504 2005-04-05 Brian Warner <warner@lothar.com>
4506 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4507 preserve timestamps, helps incremental builds of large trees.
4508 Patch from Rene Rivera.
4510 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4511 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4514 2005-04-03 Brian Warner <warner@lothar.com>
4516 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4517 with one dict, apparently exec has some scoping bugs when used
4518 with both global/local dicts. Thanks to Nathaniel Smith for the
4521 2005-04-02 Brian Warner <warner@lothar.com>
4523 * buildbot/process/step_twisted.py (countFailedTests): the new
4524 trial in Twisted-2.0 emits a slightly different status line than
4525 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4526 mistakenly think the test count is unparseable.
4527 (Trial.start): note that for some reason each build causes another
4528 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4529 be fixed but I'm not sure quite where the problem is.
4531 2005-04-01 Brian Warner <warner@lothar.com>
4533 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4534 deferredResult to avoid hangs/warnings under twisted-2.0
4535 (RunMixin.tearDown): same
4536 (RunMixin.shutdownSlave): same
4537 (Disconnect.testIdle1): same
4538 (Disconnect.testBuild2): same: wait one second after the build
4539 finishes for test to really be done.. this should be cleaned up to
4540 avoid wasting that second. Builder.detach uses a callLater(0),
4541 either that should be done in-line (something else needed that
4542 behavior), or it should return a Deferred that fires when the
4543 builder is really offline.
4544 (Disconnect.testBuild3): same
4545 (Disconnect.testDisappear): same
4547 * buildbot/test/test_web.py: rearrange server-setup and teardown
4548 code to remove unclean-reactor warnings from twisted-2.0
4550 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4551 so the tests don't hang under twisted-2.0
4553 2005-03-31 Brian Warner <warner@lothar.com>
4555 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4556 caused a warning each time the master changed our set of builders
4558 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4559 w32, don't unlink the file unless it already exists. Thanks to
4560 Baptiste Lepilleur for the catch.
4561 (BuilderStatus.saveYourself): same
4563 2005-02-01 Brian Warner <warner@lothar.com>
4565 * buildbot/status/html.py (TextLog.getChild): use a /text child
4566 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4567 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4568 logfile as text/plain (no markup, no headers). This replaces the
4569 previous scheme (which used an ?text=1 argument), and gets us back
4570 to a relative link (which works better when the buildbot lives
4571 behind another web server, such as Apache configured as a reverse
4572 proxy). Thanks to Gerald Combs for spotting the problem.
4574 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4577 2004-12-13 Brian Warner <warner@lothar.com>
4579 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4581 * debian/changelog: update for 0.6.2
4582 * NEWS: finalize for 0.6.2
4584 2004-12-11 Brian Warner <warner@lothar.com>
4586 * NEWS: bring it up to date
4588 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4589 detection code. Require some sign of life from the buildmaster
4590 every BotFactory.keepaliveInterval seconds. Provoke this
4591 indication at BotFactory.keepaliveTimeout seconds before the
4592 deadline by sending a keepalive request. We don't actually care if
4593 that request is answered in a timely fashion, what we care about
4594 is that .activity() is called before the deadline. .activity() is
4595 triggered by any PB message from the master (including an ack to
4596 one of the slave's status-update messages). With this new scheme,
4597 large status messages over slow pipes are OK, as long as any given
4598 message can be sent (and thus acked) within .keepaliveTimeout
4599 seconds (which defaults to 30).
4600 (SlaveBuilder.remote_startCommand): record activity
4601 (SlaveBuilder.ackUpdate): same
4602 (SlaveBuilder.ackComplete): same
4603 (BotFactory.gotPerspective): same
4604 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4606 2004-12-09 Brian Warner <warner@lothar.com>
4608 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4611 * buildbot/process/step_twisted.py (Trial._commandComplete):
4612 update self.cmd when we start the 'cat test.log' transfer. Without
4613 this, we cannot interrupt the correct RemoteCommand when we lose
4616 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4617 trying to tell the slave to stop the command if we're already
4618 inactive, or if we no longer have a .remote
4620 * buildbot/process/builder.py (Builder._detached): don't let an
4621 exception in currentBuild.stopBuild() prevent the builder from
4622 being marked offline
4624 2004-12-07 Brian Warner <warner@lothar.com>
4626 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4627 KeyError that happens when you ask for a non-existent Builder, and
4628 translate it into a UsageError.
4630 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4631 losing the slave in the middle of a remote step is handled too
4633 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4634 be a Failure, so be sure to stringify it before using it as the
4635 contents of the 'interrupt' logfile
4636 (RemoteCommand.interrupt): use stringified 'why' in
4637 remote_interruptCommand too, just in case
4639 2004-12-06 Brian Warner <warner@lothar.com>
4641 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4642 instead of 'tla update', which is more efficient in case we've
4643 missed a couple of patches since the last update.
4645 * debian/changelog: update for previous (0.6.1) release. Obviously
4646 this needs to be handled better.
4648 2004-12-05 Brian Warner <warner@lothar.com>
4650 * NEWS: update for stuff since last release
4652 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4653 match the maybeDeferred change in Dispatcher.requestAvatar
4654 * buildbot/changes/pb.py (ChangePerspective.attached): same
4655 * buildbot/status/client.py (StatusClientPerspective.attached): same
4656 * buildbot/process/builder.py (Builder._attached3): same
4657 * buildbot/pbutil.py (NewCredPerspective.attached): same
4659 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4660 the date to the top-most box, if it is not the same as today's
4663 * docs/slave.xhtml: provide a buildslave setup checklist
4665 * docs/source.xhtml (Arch): correct terminology
4667 2004-12-04 Brian Warner <warner@lothar.com>
4669 * buildbot/test/test_slavecommand.py: use sys.executable instead
4670 of hard-coding 'python' for child commands, might help portability
4672 * docs/examples/twisted_master.cfg: update to current usage
4674 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4675 'stop build' command to the IRC bot
4677 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4678 message that broke PBChangeSource
4680 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4681 (SlaveBuilder): make some attributes class-level, remove the old
4682 "update queue" which existed to support resuming a build after the
4683 master connection was lost. Try to reimplement that feature later.
4684 (SlaveBuilder.stopCommand): clear self.command when the
4685 SlaveCommand finishes, so that we don't try to kill a leftover one
4687 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4690 * buildbot/slave/commands.py (SourceBase): set self.command for
4691 all VC commands, so they can be interrupted.
4693 2004-12-03 Brian Warner <warner@lothar.com>
4695 * buildbot/master.py: clean up slave-handling code, to handle
4696 slave-disconnect and multiple-connect better
4697 (BotPerspective): make these long-lasting, exactly one per bot
4698 listed in the config file.
4699 (BotPerspective.attached): if a slave connects while an existing
4700 one appears to still be connected, disconnect the old one first.
4701 (BotPerspective.disconnect): new method to forcibly disconnect a
4702 buildslave. Use some hacks to empty the transmit buffer quickly to
4703 avoid the long (20-min?) TCP timeout that could occur if the old
4704 slave has dropped off the net.
4705 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4706 own their own SlaveStatus objects. Remove .attached/.detached, add
4707 .addSlave/.removeSlave, treat slaves like Builders (config file
4708 parsing sends deltas to the BotMaster). Inform the slave
4709 instances, i.e. the BotPerspective, about addBuilder and
4711 (BotMaster.getPerspective): turns into a single dict lookup
4712 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4713 which gives BotPerspective.attached a chance to disconnect the old
4715 (BuildMaster.loadConfig): add code (disabled) to validate that all
4716 builders use known slaves (listed in c['bots']). The check won't
4717 work with tuple-specified builders, which are deprecated but not
4718 yet invalid, so the check is disabled for now.
4719 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4720 routine, do the add/changed/removed dance with them like we do
4722 (BuildMaster.loadConfig_Sources): move source-config into a
4723 separate routine too
4725 * buildbot/status/builder.py (Status.getSlave): get the
4726 SlaveStatus object from the BotPerspective, not the BotMaster.
4728 * buildbot/test/test_run.py: bunch of new tests for losing the
4729 buildslave at various points in the build, handling a slave that
4730 connects multiple times, and making sure we can interrupt a
4733 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4734 something other than 'Bot' for the Bot object, to make certain
4735 test cases easier to write.
4736 (BuildSlave.waitUntilDisconnected): utility method for testing
4738 2004-11-30 Brian Warner <warner@lothar.com>
4740 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4742 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4743 argument, return a Deferred that always fires with True or False.
4744 I don't use an errback to indicate 'ping failed' so that callers
4745 are free to ignore the deferred without causing spurious errors in
4747 * buildbot/process/builder.py (BuilderControl.ping): implement it
4749 * buildbot/test/test_run.py (Status.testDisappear): test ping
4750 (Status.disappearSlave): fix it
4752 2004-11-30 Brian Warner <warner@lothar.com>
4754 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4755 (IBuilderControl): add .getBuild(num), only works for the current
4756 build, of course, although it might be interesting to offer
4757 something for builds in the .waiting or .interlocked state.
4759 * buildbot/process/base.py (Build): have .stopBuild just do the
4760 interrupt, then let the build die by itself.
4761 (BuildControl): add .stopBuild, and add a point-event named
4762 'interrupt' just after the build so status viewers can tell that
4764 (BuilderControl): add .getBuild
4766 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4767 stops when you kill it, good for testing
4768 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4769 contains the 'reason' text.
4771 * buildbot/status/html.py: Add Stop Build button, if the build can
4772 still be stopped. Send a Redirect (to the top page) one second
4773 later, hopefully long enough for the interrupt to have an effect.
4774 Move make_row() up to top-level to share it between Stop Build and
4777 * buildbot/slave/commands.py: only kill the child process once
4779 * buildbot/test/test_run.py: add testInterrupt
4781 2004-11-29 Brian Warner <warner@lothar.com>
4783 * buildbot/process/base.py: Refactor command interruption. The
4784 Build is now responsible for noticing that the slave has gone
4785 away: Build.lostRemote() interrupts the current step and makes
4786 sure that no further ones will be started.
4788 * buildbot/process/builder.py: When the initial remote_startBuild
4789 message fails, log it: this usually indicates that the slave has
4790 gone away, but we don't really start paying attention until they
4791 fail to respond to the first step's command.
4793 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4794 slave disconnect. Now sports a new interrupt() method. Error
4795 handling was simplified a lot by chaining deferreds, so
4796 remoteFailed/remoteComplete were merged into a single
4797 remoteComplete method (which can now get a Failure object).
4798 Likewise failed/finished were merged into just _finished.
4799 (BuildStep): Add interrupt(why) method, and if why is a
4800 ConnectionLost Failure then the step is failed with some useful
4803 * buildbot/slave/bot.py: stop the current command when the remote
4804 Step reference is lost, and when the slave is shut down.
4805 (Bot): make it a MultiService, so it can have children. Use
4806 stopService to tell when the slave is shutting down.
4807 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4808 remote_interruptCommand (which asks the current SlaveCommand to
4809 stop but allows it to keep emitting status messages), and
4810 stopCommand (which tells it to shut up and die).
4812 * buildbot/slave/commands.py: make commands interruptible
4813 (ShellCommand.kill): factor out os.kill logic
4814 (Command): factor out setup()
4815 (Command.sendStatus): don't send status if .running is false, this
4816 happens when the command has been halted.
4817 (Command.interrupt): new method, used to tell the command to die
4818 (SlaveShellCommand): implement .interrupt
4819 (DummyCommand): implement .interrupt
4820 (SourceBase, etc): factor out setup(), don't continue substeps if
4823 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4824 so they can be called after finishing
4826 * buildbot/test/test_run.py: new tests for disconnect behavior,
4827 refactor slave-shutdown routines, add different kinds of
4830 2004-11-27 Brian Warner <warner@lothar.com>
4832 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4833 method to express ETA time like "2m45s" instead of "165 seconds"
4835 2004-11-24 Brian Warner <warner@lothar.com>
4837 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4838 archive after the test completes, to avoid cluttering the user's
4839 'tla archives' listing with a bogus entry. Arch doesn't happen to
4840 provide any way to override the use of ~/.arch-params/, so there
4841 isn't a convenient way to avoid touching the setup of the user who
4843 (VC_HTTP.testArchHTTP): same
4845 2004-11-23 Brian Warner <warner@lothar.com>
4847 * buildbot/status/html.py (TextLog): split render() up into
4848 render_HEAD and render_GET. Use a Producer when sending log
4849 chunks, to reduce memory requirements and avoid sending huge
4850 non-Banana-able strings over web.distrib connections. Requires
4851 peeking under the covers of IStatusLog.
4852 (TextLog.resumeProducing): fix the "as text" link, handle client
4853 disconnects that occur while we're still sending old chunks.
4855 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4856 use defer.succeed, not the non-existent defer.success
4857 (LogFile.waitUntilFinished): same
4858 (LogFile.subscribe): don't add watchers to a finished logfile
4860 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4863 2004-11-23 Brian Warner <warner@lothar.com>
4865 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4867 2004-11-23 Brian Warner <warner@lothar.com>
4869 * NEWS: update for the 0.6.1 release
4870 * MANIFEST.in: add new files
4872 * README (INSTALLATION): explain how to enable the extra VC tests
4874 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4875 level to, so old pickled builds can be displayed ok
4877 2004-11-22 Brian Warner <warner@lothar.com>
4879 * NEWS: summarize updates since last release
4881 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4882 Yoz Grahame. Closes SF#1050138.
4884 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4887 * buildbot/process/step_twisted.py (Trial): update docs a bit
4889 * docs/factories.xhtml: fix Trial factory docs to match reality.
4892 * buildbot/process/factory.py (Trial.__init__): add args for
4893 randomly= and recurse=, making them available to instantiators
4894 instead of only to subclassers. Closes: SF#1049759.
4896 2004-11-15 Brian Warner <warner@lothar.com>
4898 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4899 try to teach the Quick factory to use multiple versions of python
4901 2004-11-12 Brian Warner <warner@lothar.com>
4903 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4904 safer w32-compatible approach, and only use it on windows
4905 (BuildStatus.saveYourself): same
4907 2004-11-11 Brian Warner <warner@lothar.com>
4909 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4910 it: one string merge per chunk. There are now separate .entries
4911 and .runEntries lists: when enumerating over all chunks, make sure
4913 * buildbot/test/test_status.py (Log): more tests
4915 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4916 chunks together, up to 10kb per chunk. This ought to cut down on
4917 the CPU-burning overhead of large log files. Thanks to Alexander
4918 Staubo for spotting the problem.
4919 * buildbot/test/test_status.py (Log): tests for same
4921 2004-11-10 Brian Warner <warner@lothar.com>
4923 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4924 header to outbound mail
4925 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4927 2004-11-08 Brian Warner <warner@lothar.com>
4929 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4930 can't do os.rename() onto an existing file, so catch the exception
4931 and unlink the target file first. This introduces a slight window
4932 where the existing file could be lost, but the main failure case
4933 (disk full) should still be handled safely.
4934 (BuildStatus.saveYourself): same
4936 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4937 separator character instead of os.sep, because the filenames being
4938 split here are coming from the VC system, which can have a
4939 different pathname convention than the local host. This should
4940 help a buildmaster running on windows that uses a CVS repository
4941 which runs under unix.
4942 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4944 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4945 when there are no test failures to be parsed
4947 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4948 instead of the unix-specific os.system("cp"), thanks to Elliot
4949 Murphy for this and the other buildbot-vs-windows catches.
4950 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4952 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4953 echo the command as it is run
4955 * setup.py: install sample.mk too, not just sample.cfg
4956 (scripts): install contrib/windows/buildbot.bat on windows
4958 2004-11-07 Brian Warner <warner@lothar.com>
4960 * buildbot/process/builder.py (Builder._detached): clear the
4961 self.currentBuild reference, otherwise the next build will be
4962 skipped because we think the Builder is already in use.
4964 * docs/examples/twisted_master.cfg: update to match current usage
4965 on the Twisted buildbot
4967 2004-10-29 Brian Warner <warner@lothar.com>
4969 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4971 2004-10-28 Brian Warner <warner@lothar.com>
4973 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4974 have separate doVCUpdate/doVCFull methods. Catch an update failure
4975 and respond by clobbering the source directory and re-trying. This
4976 will handle local changes (like replacing a file with a directory)
4977 that will cause CVS and SVN updates to fail.
4978 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4980 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4983 2004-10-19 Brian Warner <warner@lothar.com>
4985 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4987 * buildbot/status/html.py (StatusResourceTestResults): display any
4988 TestResults that the Build might have
4989 (StatusResourceTestResult): and the logs for each TestResult
4990 (StatusResourceBuild): add link from the per-build page
4992 2004-10-15 Brian Warner <warner@lothar.com>
4994 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4995 the 'problems' portion of stdout, add TestResults to our build
4996 * buildbot/test/test_twisted.py (Parse.testParse): test it
4998 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4999 to retrieve a dict of accumulated test results
5000 (ITestResult): define what a single test result can do
5001 * buildbot/status/builder.py (TestResult): implement ITestResult
5002 (BuildStatus.getTestResults): retrieve dict of TestResults
5003 (BuildStatus.addTestResult): add TestResults
5004 * buildbot/test/test_status.py (Results.testAddResults): test it
5006 2004-10-14 Brian Warner <warner@lothar.com>
5008 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5009 instead of os.system("rm -rf") for win32 portability
5011 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5012 SignalMixin instead of starting/stopping the reactor, which is
5013 likely to cause problems with other tests
5015 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5016 self.copyComplete() call. Yoz Grahame makes the catch.
5018 * contrib/windows/buildbot.bat: helper script to deal with path
5019 issues. Thanks to Yoz Grahame.
5021 * buildbot/master.py (BuildMaster.startService): don't register a
5022 SIGHUP handler if the signal module has no SIGHUP attribute.
5023 Apparently win32 does this.
5025 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5027 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5028 test if the reactor can't offer UNIX sockets
5030 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5031 error introduced in the last commit. We really need that
5034 2004-10-12 Brian Warner <warner@lothar.com>
5036 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5037 when describing a maildir source. Thanks to Stephen Davis.
5039 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5042 * buildbot/scripts/runner.py (createMaster): install Makefile too
5043 (start): add --no_save to 'start' command
5044 * buildbot/scripts/sample.mk: simple convenience Makefile with
5045 start/stop/reload targets
5047 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5050 2004-09-30 Brian Warner <warner@lothar.com>
5052 * setup.py: Releasing buildbot-0.6.0
5054 2004-09-30 Brian Warner <warner@lothar.com>
5056 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5057 test_trial.py from the source tarball until support is complete.
5059 * NEWS: update for 0.6.0 release
5060 * buildbot/__init__.py (version): same
5063 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5064 'source' command to tell users where to get the Buildbot source
5066 * docs/examples/*.cfg: update to modern standards
5068 * NEWS: update for release
5070 * buildbot/scripts/runner.py (createMaster): remove the
5071 -shutdown.tap stuff now that it isn't necessary
5073 (start): launch buildbot.tap, not buildbot-shutdown.tap
5076 * buildbot/status/mail.py (Domain): shorten class name
5077 (MailNotifier): if lookup= is a string, pass it to Domain()
5078 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5079 (Mail.testBuild2): test the string-to-Domain shortcut
5080 (Mail.testMail): fix test
5083 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5086 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5087 more attributes on load
5088 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5089 to accomodate the whole waterfall page at once, and the thrashing
5090 results in a lot of unnecessary loads
5091 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5092 (BuilderStatus.saveYourself): same
5093 (BuilderStatus.eventGenerator): stop generating on the first missing
5094 build. We assume that saved builds are deleted oldest-first.
5095 (BuildStepStatus.__getstate__): .progress might not exist
5097 * buildbot/changes/changes.py (ChangeMaster): make it
5098 serializable, in $masterdir/changes.pck
5099 (ChangeMaster.stopService): save on shutdown
5100 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5101 * buildbot/test/test_config.py: load Changes before config file
5104 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5105 "Oh my god, you killed the command" header on a separate line
5107 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5108 skip over corrupted build pickles
5109 (BuilderStatus.getFullBuildByNumber): same
5110 (BuilderStatus.eventGenerator): skip over unavailable builds
5111 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5112 do an atomic rename. This prevents a corrupted pickle when some
5113 internal serialization error occurs.
5114 (BuilderStatus.saveYourself): same
5116 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5117 the timeout for shell commands, it got lost somehow
5119 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5120 run out of build steps, return the rest of the builder events
5122 * buildbot/interfaces.py (IBuilderControl.ping): add method
5124 * buildbot/process/builder.py (BuilderControl.ping): move
5125 slave-ping to BuilderControl, and fix the failure case in the
5126 process (Event.finish() is the verb, Event.finished is the noun).
5128 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5129 through the BuilderControl instead of the BuilderStatus
5130 (EventBox): add adapter for builder.Event, allowing builder events to
5131 be displayed in the waterfall display
5133 * buildbot/master.py (BotMaster.stopService): add a 'master
5134 shutdown' event to the builder's log
5135 (BuildMaster.startService): and a 'master started' on startup
5137 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5138 builder events into the BuildStep event stream
5139 (Status.builderAdded): add a 'builder created' event
5142 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5143 command to announce the completion of a running build
5144 (IrcStatusBot.command_FORCE): announce when the build finishes
5146 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5147 don't evict unfinished builds from the cache: they must stay in
5148 the full-cache until their logfiles have stopped changing. Make
5149 sure the eviction loop terminates if an unfinished build was hit.
5150 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5151 This lets exceptions be dumped in an email status message. Really
5152 we need LogFiles which contain both text and HTML, instead of two
5154 (BuildStatus.__getstate__): handle self.finished=False
5155 (Status.builderAdded): if the pickle is corrupted, abandon the
5156 history and create a new BuilderStatus object.
5158 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5159 self.progress attribute, helped one test which doesn't fully set
5160 up the Build object.
5162 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5163 IStatusLog methods into an Interface that is implemented by "stub"
5164 logs, for which all the actual text chunks are on disk (in the
5165 pickled Build instance). To show the log contents, you must first
5166 adapt the stub log to a full IStatusLog object.
5168 * buildbot/status/builder.py (LogFileStub): create separate stub
5169 log objects, which can be upgraded to a real one if necessary.
5170 (LogFile): make them persistable, and let them stubify themselves
5172 (BuildStepStatus): same
5174 (BuildStatus.saveYourself): save the whole build out to disk
5175 (BuilderStatus): make it persistable
5176 (BuilderStatus.saveYourself): save the builder to disk
5177 (BuilderStatus.addFullBuildToCache): implement two caches which
5178 hold Build objects: a small one which holds full Builds, and a
5179 larger one which holds "stubbed" Builds (ones with their LogFiles
5180 turned into LogFileStubs). This reduces memory usage by the
5181 buildmaster by not keeping more than a few (default is 2) whole
5182 build logs in RAM all the time.
5183 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5185 (BuilderStatus.eventGenerator): rewrite since .builds went away
5186 (BuilderStatus.buildStarted): remove the .builds array. Add the
5187 build to the "full" cache when it starts.
5188 (BuilderStatus._buildFinished): save the build to disk when it
5190 (Status): give it a basedir (same as the BuildMaster's basedir)
5191 where the builder pickles can be saved
5192 (Status.builderAdded): create the BuilderStatus ourselves, by
5193 loading a pickle from disk (or creating a new instance if there
5194 was none on disk). Return the BuilderStatus so the master can glue
5195 it into the new Builder object.
5197 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5198 all BuilderStatuses to save themselves out to disk. This is in
5199 lieu of saving anything important in the main Application pickle
5200 (the -shutdown.tap file).
5201 (BuildMaster.__init__): give Status() a basedir for its files
5202 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5203 to get the BuilderStatus, then give it to the Builder (instead of
5204 doing it the other way around). It's ok if the status announces
5205 the new Builder before it's really ready, as the outside world can
5206 only see the BuilderStatus object anyway (and it is ready before
5207 builderAdded returns). Use the builder's "builddir" (which
5208 normally specifies where the slave will run the builder) as the
5209 master's basedir (for saving serialized builds).
5211 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5212 coerce the logfile to IStatusLog before trying to get the text
5213 chunks out of it. This will pull the full (non-stubified) Build in
5214 from disk if necessary.
5215 (TextLog): fix the adapter registration
5217 * buildbot/test/test_control.py (Force.setUp): create the basedir
5218 * buildbot/test/test_web.py: same
5219 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5220 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5221 * buildbot/test/test_run.py (Run.testMaster): same
5222 (Status.setUp): same
5224 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5226 * buildbot/status/html.py (Waterfall.__init__): store actual
5227 allowForce flag passed in rather than using True for everyone;
5228 make sure setting it to False doesn't cause a NameError
5230 (StatusResourceBuilder.__init__) add the builder name to the page
5232 (StatusResourceBuilder.body) move HTML generation for a name/value
5233 row into a helper method (StatusResourceBuilder.make_row); only
5234 generate the "Force Build" form if allowForce was True and the
5235 slave is connected. Use class attributes in the generated HTML to
5236 spread a little CSS-joy.
5238 2004-09-28 Brian Warner <warner@lothar.com>
5240 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5241 warning-scanner to not ignore things like
5242 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5244 * buildbot/status/html.py (StatusResource.control): add some
5245 class-level values for .control in an attempt to make upgrading
5248 * buildbot/util.py (ComparableMixin): survive missing attributes,
5249 such as when a class is modified and we're comparing old instances
5252 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5253 failure handling, remove a redundant try/except block. Don't
5254 return the full traceback to the IRC channel.
5255 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5256 error messages. Get ETA properly.
5258 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5259 the reason, since (at least) IRC message will have <> in them.
5260 (StatusResourceBuilder.__init__): take an IBuilderControl
5261 (StatusResourceBuilder.force): use the IBuilderControl we get in
5262 the constructor instead of trying to make our own. Catch the
5263 new exceptions and ignore them for now (until we make an
5264 intermediate web page where we could show the error message)
5265 (StatusResource): create with an IControl, use it to give an
5266 IBuilderControl to all children
5267 (Waterfall): take an allowForce= option, pass an IControl object
5268 to StatusResource if it is True
5270 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5272 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5273 catch new exceptions and return string forms
5275 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5276 * buildbot/process/builder.py (Builder.forceBuild): raise them
5277 * buildbot/test/test_control.py (Force.testNoSlave): new test
5278 (Force.testBuilderInUse): same
5281 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5283 * buildbot/test/test_run.py: use IControl
5284 * buildbot/test/test_vc.py: same
5286 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5287 to use IControl. Still offline.
5288 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5290 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5291 who=None so periodic builds don't send out status mail
5292 (Builder.forceBuild): include reason in the log message
5293 (BuilderControl.forceBuild): rename 'name' to 'who'
5295 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5296 'who' parameter, but make it None by default so builds forced by
5297 slave admins don't cause status mail to be sent to anybody
5298 (BotMaster.forceBuild): same. this method is deprecated.
5299 (DebugPerspective.perspective_forceBuild): same, use IControl.
5300 (DebugPerspective.perspective_fakeChange): use IControl..
5301 (Dispatcher.requestAvatar): .. so don't set .changemaster
5303 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5304 parameter to avoid confusion with the name of the builder
5307 * buildbot/status/mail.py: refine comment about needing 2.3
5309 * buildbot/status/html.py: move all imports to the top
5311 * buildbot/test/test_control.py: test new interfaces
5312 * buildbot/test/test_run.py (Status): handle new interfaces
5313 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5315 * buildbot/process/base.py (BuildControl): implement IBuildControl
5316 and its lonely getStatus() method
5318 * buildbot/process/builder.py (BuilderControl): implement
5319 IBuilderControl, obtained by adapting the Builder instance
5320 (Builder.startBuild): return a BuilderControl instead of a
5321 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5322 accomplish the same thing.
5324 * buildbot/master.py: move all import statements to the top
5325 (Control): implement IControl, obtained by adapting the
5326 BuildMaster instance.
5328 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5329 IBuildControl. These are used to force builds. Eventually they
5330 will provide ways to reconfigure the Builders, pause or abandon a
5331 Build, and perhaps control the BuildMaster itself.
5333 2004-09-26 Brian Warner <warner@lothar.com>
5335 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5336 ends up comparing us against something without a .__class__
5338 2004-09-24 Brian Warner <warner@lothar.com>
5340 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5343 * Makefile: add 'deb-snapshot' target, to create a timestamped
5346 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5348 2004-09-23 Brian Warner <warner@lothar.com>
5350 * buildbot/__init__.py (version): move version string here
5351 * setup.py: get version string from buildbot.version
5352 * buildbot/status/html.py (WaterfallStatusResource.body): add
5353 buildbot version to the page footer
5354 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5357 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5358 slaves, let the second know where the first one is coming from
5359 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5360 see our exceptions. It would be nice if there were a way to just
5361 send them the exception type and value, not the full traceback.
5364 * buildbot/status/mail.py (MailNotifier): add a new argument
5365 sendToInterestedUsers=, which can be set to False to disable the
5366 usual send-to-blamelist behavior.
5367 (top): handle python-2.2 which has no email.MIMEMultipart
5368 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5369 (MailNotifier.disownServiceParent): unsubscribe on removal
5371 * buildbot/test/test_status.py (Mail.testBuild2): test it
5374 * buildbot/status/progress.py (Expectations.wavg): tolerate
5375 current=None, which happens when steps start failing badly
5376 * buildbot/test/test_status.py (Progress.testWavg): test for it
5378 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5379 doesn't understand args['revision'], emit a warning instead of
5380 bailing completely. Updating to -rHEAD is probably close enough.
5382 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5384 * buildbot/test/test_status.py: at least import bb.status.client
5385 even if we don't have any test coverage for it yet
5387 * contrib/svn_buildbot.py: don't require python2.3
5388 (main): wait, do require it (for sets.py), but explain how to
5389 make it work under python2.2
5391 2004-09-23 Brian Warner <warner@lothar.com>
5393 * contrib/svn_buildbot.py: include the revision number in the Change
5395 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5396 using util.now() because FreshCVS is a realtime service
5398 * buildbot/status/event.py: delete dead code
5399 * buildbot/process/step.py: don't import dead Event class
5400 * buildbot/process/step_twisted.py: same
5401 * buildbot/status/builder.py: same
5402 * buildbot/status/client.py: same
5404 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5406 * buildbot/changes/changes.py (Change): set .when from an __init__
5407 argument (which defaults to now()), rather than having
5408 ChangeMaster.addChange set it later.
5409 (ChangeMaster.addChange): same
5411 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5412 (parseSyncmail): same. Just use util.now() for now.
5413 (parseBonsaiMail): parse the timestamp field for when=
5415 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5416 instead of setting .when after the fact
5420 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5421 results when the target project uses retrial. Still under
5423 * buildbot/test/test_trial.py: same
5425 2004-09-21 Brian Warner <warner@lothar.com>
5427 * buildbot/status/mail.py (MailNotifier.__init__): include
5428 success/warnings/failure in the Subject line
5429 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5430 use step.logname for the addLogs=True attachment filenames
5431 * buildbot/test/test_status.py (Mail): test Subject lines
5432 (Mail.testLogs): test attachment filenames
5434 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5435 accept a 'who' argument from the debug tool
5436 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5437 * contrib/debug.glade: add text box to set 'who'
5439 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5440 .getBuilderName with .getBuilder().getName(), more flexible
5441 (IStatusLog.getName): logs have short names, but you can prefix
5442 them with log.getStep().getName() to make them more useful
5443 * buildbot/status/builder.py: same
5444 * buildbot/status/client.py: same
5445 * buildbot/status/html.py: same
5446 * buildbot/test/test_run.py (Status.testSlave): same
5447 * buildbot/process/step.py: tweak logfile names
5449 * buildbot/status/mail.py (MailNotifier): add lookup, change
5450 argument to extraRecipients. The notifier is now aimed at sending
5451 mail to the people involved in a particular build, with additional
5452 constant recipients as a secondary function.
5454 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5455 including slow-lookup and failing-lookup. Make sure the blamelist
5456 members are included.
5458 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5459 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5460 (IBuildStatus.getInterestedUsers): new method
5461 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5462 * buildbot/status/client.py (remote_getResponsibleUsers): same
5463 * buildbot/status/html.py (StatusResourceBuild.body): same
5464 * buildbot/test/test_run.py (Status.testSlave): same
5466 2004-09-20 Brian Warner <warner@lothar.com>
5468 * docs/users.xhtml: update concepts
5470 * Makefile: add a convenience makefile, for things like 'make
5471 test'. It is not included in the source tarball.
5473 2004-09-16 Brian Warner <warner@lothar.com>
5475 * NEWS: mention /usr/bin/buildbot, debian/*
5477 * debian/*: add preliminary debian packaging. Many thanks to
5478 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5479 it considerably since it left their hands, I am responsible for
5480 all breakage that's resulted.
5482 * bin/buildbot: create a top-level 'buildbot' command, to be
5483 installed in /usr/bin/buildbot . For now it's just a simple
5484 frontend to mktap/twistd/kill, but eventually it will be the entry
5485 point to the 'try' command and also a status client. It is also
5486 intended to support the upcoming debian-packaging init.d scripts.
5487 * buildbot/scripts/runner.py: the real work is done here
5488 * buildbot/scripts/__init__.py: need this too
5489 * buildbot/scripts/sample.cfg: this is installed in new
5490 buildmaster directories
5491 * setup.py: install new stuff
5493 2004-09-15 Brian Warner <warner@lothar.com>
5495 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5496 'file:' schema (the version shipped with OS-X was built without the
5498 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5499 updates the log-timestamp, to make sure it isn't still running after
5502 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5503 values to the config file.
5504 * docs/examples/hello.cfg: add examples
5505 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5506 * buildbot/status/builder.py (Status.getProjectURL): implement them
5507 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5508 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5509 * buildbot/status/html.py (WaterfallStatusResource): display them
5512 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5513 certain error cases don't suffer a secondary exception.
5514 (top): Skip tests if the corresponding VC tool is not installed.
5516 * buildbot/process/factory.py (Trial): introduce separate
5517 'buildpython' and 'trialpython' lists, since trialpython=[] is
5518 what you want to invoke /usr/bin/python, whereas ./setup.py is
5519 less likely to be executable. Add env= parameter to pass options
5520 to test cases (which is how I usually write tests, I don't know if
5521 anyone else does it this way).
5523 * buildbot/process/step_twisted.py (Trial): handle python=None.
5524 Require 'testpath' be a string, not a list. Fix tests= typo.
5525 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5527 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5528 way to deal with the possibility of removing the disconnect notify
5530 (CVS): add a 'login' parameter to give a password to 'cvs login',
5531 commonly used with pserver methods (where pw="" or pw="guest")
5533 * buildbot/slave/commands.py (SourceBase): move common args
5534 extraction and setup() to __init__, so everything is ready by the
5535 time setup() is called
5536 (CVS.start): call 'cvs login' if a password was supplied
5537 (ShellCommand): special-case PYTHONPATH: prepend the master's
5538 value to any existing slave-local value.
5540 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5541 don't have a remote, mark the builder as Offline. This whole
5542 function should probably go away and be replaced by individual
5544 (Builder.buildFinished): return the results to the build-finished
5545 deferred callback, helps with testing
5547 2004-09-14 Brian Warner <warner@lothar.com>
5549 * buildbot/test/test_vc.py: put all the repositories needed to run
5550 the complete tests into a single small (1.3MB) tarball, so I can
5551 make that tarball available on the buildbot web site. Test HTTP
5552 access (for Arch and Darcs) by spawning a temporary web server
5553 while the test runs.
5555 * docs/users.xhtml: new document, describe Buildbot's limited
5556 understanding of different human users
5558 * buildbot/test/test_vc.py: rearrange test cases a bit
5560 * buildbot/process/step_twisted.py (Trial): handle testpath=
5561 * buildbot/process/factory.py (Trial): update to use step.Trial
5563 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5565 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5566 the overall build text (which gives you 'failed 2 tests' rather
5568 (BuildStepStatus.text2): default to [], not None
5570 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5573 2004-09-12 Brian Warner <warner@lothar.com>
5575 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5576 log the whole exception if it's just an AttributeError (old slave)
5578 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5579 so (e.g.) sub-commands can be run in the right directory.
5580 (ShellCommand.start): accept an optional errorMessage= argument
5581 to make life easier for SVN.start
5582 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5584 (ShellCommand.start): move ['dir'] compatibility hack..
5585 (RemoteShellCommand.start): .. to here so everyone can use it
5587 * buildbot/process/step_twisted.py (Trial): use .workdir
5589 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5590 text displayed when debuild fails completely
5591 (Trial): snarf _trial_temp/test.log from the slave and display it
5593 2004-09-11 Brian Warner <warner@lothar.com>
5595 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5597 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5598 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5600 * buildbot/process/step.py (ShellCommand): call .createSummary
5601 before .evaluateCommand instead of the other way around. This
5602 makes it slightly easier to count warnings and then use that to
5603 set results=WARNINGS
5604 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5606 * buildbot/process/base.py (Build.buildFinished): update status
5607 before doing progress. It's embarrassing for the build to be stuck
5608 in the "building" state when an exceptions occurs elsewhere..
5610 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5611 python2.2 doesn't have 'sum'
5613 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5614 to prevent clients from accidentally sorting it
5616 * buildbot/master.py (Manhole): add username/password
5617 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5618 c['manholePort'], deprecate old usage
5619 * docs/config.xhtml: document c['manhole']
5620 * docs/examples/hello.cfg: show example of using a Manhole
5623 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5624 pretend the slave is up to date
5626 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5627 the module, overlaps with 'log', the local variable
5629 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5631 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5632 new method to let Steps find out the version of their
5633 corresponding SlaveCommand.
5634 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5635 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5636 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5638 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5639 (Arch.startVC): same
5640 (P4Sync.startVC): same
5642 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5643 Deferred so we can catch errors in remote_startCommand
5644 (RemoteShellCommand.start): same
5646 * docs/examples/twisted_master.cfg: update sample config file
5648 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5649 after connectionMade() is called, not before. Close stdin at that
5652 * buildbot/process/process_twisted.py: update to use Trial, clean
5653 up argument passing (move to argv arrays instead of string
5656 * buildbot/process/step_twisted.py (Trial): new step to replace
5657 RunUnitTests, usable by any trial-using project (not just
5658 Twisted). Arguments have changed, see the docstring for details.
5660 * buildbot/process/base.py (Build.startBuild): this now returns a
5661 Deferred. Exceptions that occur during setupBuild are now
5662 caught better and lead to fewer build_status weirdnesses, like
5663 finishing a build that was never started.
5664 (Build.buildFinished): fire the Deferred instead of calling
5665 builder.buildFinished directly. The callback argument is this
5666 Build, everything else can be extracted from it, including the
5667 new build.results attribute.
5668 * buildbot/process/builder.py (Builder.startBuild): same
5669 (Builder.buildFinished): same, extract results from build
5671 * buildbot/process/step.py (ShellCommands): remove dead code
5673 2004-09-08 Brian Warner <warner@lothar.com>
5675 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5676 doesn't try to use the leftover patched workdir
5677 (SourceStamp): test source-stamp computation for CVS and SVN
5679 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5680 patched workdir ('touch .buildbot-patched') so we don't try to
5682 (SourceBase.start): add ['revision'] for all Source steps
5683 (CVS): change args: use ['branch'] for -r, remove ['files']
5684 (CVS.buildVC): fix revision/branch stuff
5685 (SVN): add revision stuff
5687 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5688 kwargs (except 'workdir') to avoid silent spelling errors
5689 (ShellCommand.__init__): same
5690 (Source): new base class for CVS/SVN/etc. Factor out everything
5691 common, add revision computation (perform the checkout with a -D
5692 DATE or -r REVISION that gets exactly the sources described by the
5693 last Change), overridable with step.alwaysUseLatest. Add patch
5694 handling (build.getSourceStamp can trigger the use of a base
5695 revision and a patch).
5696 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5697 * docs/steps.xhtml: update docs
5698 * docs/source.xhtml: mention .checkoutDelay
5699 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5701 * buildbot/process/base.py (Build.setSourceStamp): add a
5702 .sourceStamp attribute to each Build. If set, this indicates that
5703 the build should be done with something other than the most
5704 recent source tree. This will be used to implement "try" builds.
5705 (Build.allChanges): new support method
5706 (Build.lastChangeTime): remove, functionality moved to Source steps
5707 (Build.setupBuild): copy the Step args before adding ['workdir'],
5708 to avoid modifying the BuildFactory (and thus triggering spurious
5712 * buildbot/status/html.py: rename s/commits/changes/
5713 (StatusResourceChanges): same
5714 (CommitBox.getBox): same, update URL
5715 (WaterfallStatusResource): same
5716 (StatusResource.getChild): same
5718 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5719 * contrib/debug.glade: add optional 'revision' to the fakeChange
5721 * buildbot/changes/changes.py (html_tmpl): display .revision
5722 (ChangeMaster.addChange): note .revision in log
5723 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5724 accept a ['revision'] attribute
5726 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5728 * buildbot/master.py (BotMaster.getPerspective): update the
5729 .connected flag in SlaveStatus when it connects
5730 (BotMaster.detach): and when it disconnects
5731 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5732 (BuildMaster.loadConfig_Builders): walk old list correctly
5734 * buildbot/test/test_config.py: fix prefix= usage
5736 2004-09-06 Brian Warner <warner@lothar.com>
5740 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5741 poll a P4 depot looking for recent changes. Thanks to Dave
5742 Peticolas for the contribution. Probably needs some testing after
5745 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5746 requires manual client setup for each buildslave. Rather
5747 experimental. Thanks again to Dave Peticolas.
5748 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5750 * buildbot/changes/changes.py (Change): add a .revision attribute,
5751 which will eventually be used to generate source-stamp values.
5753 * buildbot/process/step.py (RemoteCommand.start): use
5754 notifyOnDisconnect to notice when we lose the slave, then treat it
5755 like an exception. This allows LogFiles to be closed and the build
5756 to be wrapped up normally. Be sure to remove the disconnect
5757 notification when the step completes so we don't accumulate a
5758 bazillion such notifications which will fire weeks later (when the
5759 slave finally disconnects normally). Fixes SF#915807, thanks to
5760 spiv (Andrew Bennetts) for the report.
5761 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5762 really isn't Logged- specific
5763 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5764 header, since it's almost always going to be appended to an
5766 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5767 update test to handle use of notifyOnDisconnect
5769 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5770 don't clear .ETA and .currentBuild when going offline, let the
5771 current build clean up after itself
5773 * buildbot/process/builder.py (Builder.detached): wait a moment
5774 before doing things like stopping the current build, because the
5775 current step will probably notice the disconnect and cleanup the
5777 * buildbot/test/test_run.py (Status.tearDown): update test to
5778 handle asynchronous build-detachment
5780 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5782 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5783 hush a debug message
5785 2004-09-05 Brian Warner <warner@lothar.com>
5787 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5788 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5789 kernels do this: the fcntl module has the F_NOTIFY constant, but
5790 the kernel itself doesn't support the operation. Thanks to Olly
5791 Betts for spotting the problem.
5793 * buildbot/process/step.py (Darcs): new source-checkout command
5794 (Arch): new source-checkout command
5795 (todo_P4): fix constructor syntax, still just a placeholder
5796 * buildbot/test/test_vc.py (VC.testDarcs): test it
5797 (VC.testDarcsHTTP): same, via localhost HTTP
5799 (VC.testArchHTTP): same
5800 * NEWS: mention new features
5802 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5803 which tells the step to stash stdout text locally (in .stdout).
5804 Slave-side Commands can use this to make decisions based upon the
5805 output of the the ShellCommand (not just the exit code).
5806 (Darcs): New source-checkout command
5807 (Arch): New source-checkout command, uses .keepStdout in one place
5808 where it needs to discover the archive's default name.
5810 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5811 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5812 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5814 * buildbot/process/step.py (ShellCommand.describe): add an
5815 alternate .descriptionDone attribute which provides descriptive
5816 text when the step is complete. .description can be ["compiling"],
5817 for use while the step is running, then .descriptionDone can be
5818 ["compile"], used alone when the step succeeds or with "failed" when
5819 it does not. Updated other steps to use the new text.
5820 * buildbot/process/step_twisted.py: same
5821 * buildbot/test/test_run.py: update tests to match
5823 2004-08-30 Brian Warner <warner@lothar.com>
5825 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5826 (CVS.__init__): send 'patch' argument to slave
5827 (CVS.start): don't create the LoggedRemoteCommand until start(),
5828 so we can catch a .patch added after __init__
5829 (SVN.__init__): add 'patch' to SVN too
5832 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5833 argument, to let commands push data into the process' stdin pipe.
5834 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5835 is in use, since closing a PTY doesn't really affect the process
5836 in the right way (in particular, I couldn't run /usr/bin/patch
5838 (SourceBase.doPatch): handle 'patch' argument
5840 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5843 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5844 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5846 * buildbot/master.py (BotPerspective.got_commands): get command
5847 versions from slave, give to each builder
5848 * buildbot/process/builder.py (Builder.attached): stash slave
5849 command versions in .remoteCommands
5851 * docs/steps.xhtml: bring docs in-line with reality
5853 * buildbot/process/step.py (CVS.__init__): more brutal
5854 compatibility code removal
5855 (SVN.__init__): same
5857 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5858 (SlaveShellCommand.start): require ['workdir'] argument, remove
5859 the ['dir'] fallback (compatibility will come later)
5860 (SourceBase): update docs
5861 (SourceBase.start): remove ['directory'] fallback
5864 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5865 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5866 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5868 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5869 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5870 code.. I will figure out 0.5.0-compatibility hooks later)
5872 2004-08-30 Brian Warner <warner@lothar.com>
5874 * buildbot/process/process_twisted.py: rewrite in terms of new
5875 BuildFactory base class. It got significantly shorter. Yay
5878 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5879 work with the new "self.build isn't nailed down until we call
5880 step.start()" scheme: specifically, __init__ is called before the
5881 build has decided on which Changes are going in, so we don't scan
5882 build.allFiles() for .xhtml files until start()
5883 (HLint.commandComplete): use getText(), not getStdout()
5884 (RunUnitTests.start): same: don't use .build until start()
5885 (RunUnitTests.describe): oops, don't report (None) when using
5887 (RunUnitTests.commandComplete): use getText()
5888 (RunUnitTests.createSummary): same
5889 (BuildDebs.commandComplete): same
5891 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5892 set args['command'] until start(), since our BuildStep is allowed
5893 to change their mind up until that point
5894 (TreeSize.commandComplete): use getText(), not getStdout()
5896 * docs/examples/twisted_master.cfg: update to current standards
5898 * docs/factories.xhtml: update
5899 * buildbot/process/factory.py: implement all the common factories
5900 described in the docs. The Trial factory doesn't work yet, and
5901 I've probably broken all the process_twisted.py factories in the
5902 process. There are compatibility classes left in for things like
5903 the old BasicBuildFactory, but subclasses of them are unlikely to
5905 * docs/examples/glib_master.cfg: use new BuildFactories
5906 * docs/examples/hello.cfg: same
5908 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5909 explicit 'workdir' args
5911 * buildbot/process/base.py (BuildFactory): move factories to ..
5912 * buildbot/process/factory.py (BuildFactory): .. here
5913 * buildbot/process/process_twisted.py: handle move
5914 * buildbot/test/test_config.py: same
5915 * buildbot/test/test_run.py: same
5916 * buildbot/test/test_steps.py: same
5917 * buildbot/test/test_vc.py: same
5918 * docs/factories.xhtml: same
5920 * NEWS: mention config changes that require updating master.cfg
5922 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5923 argument to all steps that weren't given one already, pointing at
5924 the "build/" directory.
5926 * docs/examples/hello.cfg: remove explicit 'workdir' args
5928 * docs/factories.xhtml: document standard BuildFactory clases,
5929 including a bunch which are have not yet been written
5931 2004-08-29 Brian Warner <warner@lothar.com>
5933 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5934 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5935 buildbot.status.builder so they aren't quite so internal
5936 * buildbot/process/base.py, buildbot/process/builder.py: same
5937 * buildbot/process/maxq.py, buildbot/process/step.py: same
5938 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5939 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5940 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5942 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5943 to handle new getLogs()-returns-list behavior
5944 (StatusResourceBuildStep.getChild): same
5945 (StepBox.getBox): same
5946 (WaterfallStatusResource.phase0): same
5948 * docs/source.xhtml: document how Buildbot uses version-control
5949 systems (output side: how we get source trees)
5950 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5951 systems (input side: how we learn about Changes)
5953 * buildbot/master.py (Manhole): use ComparableMixin
5954 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5955 * buildbot/changes/mail.py (MaildirSource): same
5956 * buildbot/status/client.py (PBListener): same
5957 * buildbot/status/html.py (Waterfall): same
5958 * buildbot/status/words.py (IRC): same
5960 * NEWS: start describing new features
5962 * buildbot/status/mail.py (MailNotifier): finish implementation.
5963 The message body is still a bit sparse.
5964 * buildbot/test/test_status.py (Mail): test it
5966 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5967 and __hash__ methods I wind up adding everywhere. Specifically
5968 intended to support the buildbot config-file update scheme where
5969 we compare, say, the old list of IStatusTargets against the new
5970 one and don't touch something which shows up on both lists.
5971 * buildbot/test/test_util.py (Compare): test case for it
5973 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5974 return a list instead of a dict
5975 (IBuildStepStatus.getLogs): same. The idea is that steps create
5976 logs with vaguely unique names (although their uniqueness is not
5977 guaranteed). Thus a compilation step should create its sole
5978 logfile with the name 'compile', and contribute it to the
5979 BuildStatus. If a step has two logfiles, try to create them with
5980 different names (like 'test.log' and 'test.summary'), and only
5981 contribute the important ones to the overall BuildStatus.
5982 * buildbot/status/builder.py (Event.getLogs): same
5983 (BuildStepStatus): fix default .text and .results
5984 (BuildStepStatus.addLog): switch to list-like .getLogs()
5985 (BuildStepStatus.stepFinished): same
5986 (BuildStatus.text): fix default .text
5987 (BuildStatus.getLogs): temporary hack to return all logs (from all
5988 child BuildStepStatus objects). Needs to be fixed to only report
5989 the significant ones (as contributed by the steps themselves)
5990 * buildbot/test/test_run.py: handle list-like .getLogs()
5991 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5993 2004-08-28 Brian Warner <warner@lothar.com>
5995 * buildbot/process/builder.py (Builder.attached): serialize the
5996 attachment process, so the attach-watcher isn't called until the
5997 slave is really available. Add detached watchers too, which makes
6000 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6002 * buildbot/test/test_swap.py: remove dead code
6004 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6005 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6006 sort of as if the command being run exited with a -1. There may
6007 still be some holes in this scheme.
6008 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6009 -r option appears before the module list
6010 * buildbot/process/step.py (CVS): add 'revision' argument
6012 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6013 when sending updates or stepComplete messages to the master, since
6014 we don't currently care whether they arrive or not. When we revamp
6015 the master/slave protocol to really resume interrupted builds,
6016 this will need revisiting.
6017 (lostRemote): remove spurious print
6019 * buildbot/master.py (BotPerspective.attached): serialize the
6020 new-builder interrogation process, to make testing easier
6021 (BotMaster.waitUntilBuilderDetached): convenience function
6023 * buildbot/status/builder.py (BuilderStatus): prune old builds
6024 (BuildStatus.pruneSteps): .. and steps
6025 (BuildStepStatus.pruneLogs): .. and logs
6026 (BuilderStatus.getBuild): handle missing builds
6027 * buildbot/status/html.py (StatusResourceBuild.body): display build
6028 status in the per-build page
6029 (BuildBox.getBox): color finished builds in the per-build box
6031 2004-08-27 Brian Warner <warner@lothar.com>
6033 * buildbot/status/mail.py (MailNotifier): new notification class,
6036 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6037 variants of a common base class which handles all the mode= logic
6039 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6041 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6043 2004-08-26 Brian Warner <warner@lothar.com>
6045 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6048 * buildbot/test/test_run.py: update to new Logfile interface, new
6049 buildbot.slave modules
6050 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6052 * MANIFEST.in: new sample config file
6053 * docs/examples/hello.cfg: same
6055 * buildbot/process/step_twisted.py: remove dead import
6057 * buildbot/process/step.py (RemoteCommand.run): catch errors
6059 (RemoteCommand.remote_update): ignore updates that arrive after
6061 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6062 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6063 the responsibilities of the subclass's methods
6064 (BuildStep.failed): catch errors during failure processing
6065 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6066 (CVS): move to a mode= argument (described in docstring), rather
6067 than the ungainly clobber=/export=/copydir= combination.
6068 (SVN): add mode= functionality to SVN too
6069 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6071 * buildbot/process/base.py (Build.startNextStep): catch errors
6072 during s.startStep()
6074 * buildbot/clients/base.py: update to new PB client interface.
6075 gtkPanes is still broken
6077 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6078 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6079 * setup.py: add buildbot.slave module
6080 * buildbot/bb_tap.py: handle move
6081 * buildbot/slave/registry.py: place to register commands, w/versions
6082 * buildbot/slave/bot.py: major simplifications
6083 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6084 instead of a fixed table. Eventually this will make the slave more
6085 extensible. Use 'start' method on the command, not .startCommand.
6086 Fix unsafeTracebacks handling (I think).
6087 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6088 helper class with a .start method that returns a Deferred.
6089 SlaveShellCommand is the form reached by the buildmaster. Commands
6090 which use multiple ShellCommands can just chain them as Deferreds,
6091 with some helper methods in Command (_abandonOnFailure and
6092 _checkAbandoned) to bail on rc!=0.
6093 (CVSCommand): prefer new mode= argument
6094 (SVNFetch): add mode= argument
6096 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6097 put a useful reason string on the build
6099 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6100 core functionality into an IStatusLog object
6101 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6102 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6103 (StatusResourceBuild.body): use proper accessor methods
6104 * buildbot/status/client.py (RemoteLog): PB-access goes here
6105 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6106 which delivers log contents too
6107 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6108 * buildbot/status/event.py: remove old Logfile completely
6110 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6111 subscription interface for IStatusLog subscriptions just like all
6112 other the status subscriptions
6113 (IStatusReceiver.logChunk): method called on subscribers
6115 2004-08-24 Brian Warner <warner@lothar.com>
6117 * buildbot/process/builder.py (Builder._pong): oops, ping response
6118 includes a result (the implicit None returned by remote_print).
6119 Accept it so the _pong method handles the response correctly.
6121 2004-08-06 Brian Warner <warner@lothar.com>
6123 * buildbot/test/test_config.py: update IRC, PBListener tests
6125 * buildbot/status/client.py (StatusClientPerspective): total
6126 rewrite to match new IStatus interfaces. New subscription scheme.
6127 There are still a few optimizations to make (sending down extra
6128 information with event messages so the client doesn't have to do a
6129 round trip). The logfile-retrieval code is probably still broken.
6130 Moved the PB service into its own port, you can no longer share a
6131 TCP socket between a PBListener and, say, the slaveport (this
6132 should be fixed eventually).
6133 * buildbot/clients/base.py (Client): revamp to match. still needs
6134 a lot of work, but basic event reporting works fine. gtkPanes is
6137 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6138 instance talks to a single irc server. Threw out all the old
6139 multi-server handling code. Still need to add back in
6140 builder-control (i.e. "force build")
6142 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6143 more random text to the as-yet-unreachable per-step page
6145 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6146 rename to stepETAUpdate
6147 (BuildStatus.subscribe): add build-wide ETA updates
6148 (BuilderStatus.getState): remove more cruft
6149 (BuilderStatus.getCurrentBuild): remove more cruft
6150 (BuilderStatus.buildStarted): really handle tuple-subscription
6151 * buildbot/test/test_run.py (Status.testSlave): handle the
6152 stepETAUpdate rename
6154 * buildbot/master.py (BuildMaster): don't add a default
6155 StatusClientService. Don't add a default IrcStatusFactory. Both
6156 are now added through c['status'] in the config file. c['irc'] is
6157 accepted for backwards compatibility, the only quirk is you cannot
6158 use c['irc'] to specify IRC servers on ports other than 6667.
6160 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6161 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6162 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6163 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6166 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6167 the buildmaster to re-read its config file
6170 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6171 find out the port our server is running on
6172 (WebTest.test_webPathname_port): same
6174 * buildbot/test/test_config.py (testWebPortnum): test it
6175 (testWebPathname): ditto
6177 * docs/config.xhtml: document new c['status'] configuration option
6179 * buildbot/status/html.py (Waterfall): new top-level class which
6180 can be added to c['status']. This creates the Site as well as the
6181 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6182 reachable as .parent, for everything.
6184 * buildbot/master.py (Manhole): make it a normal service Child
6185 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6186 webPathname. It will eventually replace c['irc'] and the implicit
6187 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6188 in as (deprecated) backward compatibility hooks for now.
6191 * buildbot/process/builder.py (Builder.buildFinished): don't
6192 inform out builder_status about a finished build, as it finds out
6193 through its child BuildStatus object
6195 * buildbot/status/html.py: extensive revamp. Use adapters to make
6196 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6197 have both starting and finishing times and adjust the waterfall
6198 display accordingly, using spacers if necessary. Use SlaveStatus
6199 to get buildslave info.
6200 (StatusResourceBuildStep): new just-one-step resource, used to get
6201 logfiles. No actual href to it yet.
6203 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6204 the time being, until I get the file-naming scheme right
6206 * buildbot/status/builder.py (Event): clean started/finished names
6207 (BuildStatus.isFinished): .finished is not None is the right test
6208 (BuildStatus.buildStarted): track started/finished times ourselves
6209 (BuilderStatus.getSlave): provide access to SlaveStatus object
6210 (BuilderStatus.getLastFinishedBuild): all builds are now in
6211 .builds, even the currently-running one. Accomodate this change.
6212 (BuilderStatus.eventGenerator): new per-builder event generator.
6213 Returns BuildStepStatus and BuildStatus objects, since they can
6214 both be adapted as necessary.
6215 (BuilderStatus.addEvent): clean up started/finished attributes
6216 (BuilderStatus.startBuild,finishBuild): remove dead code
6217 (SlaveStatus): new object to provide ISlaveStatus
6219 * buildbot/process/step.py (ShellCommand.getColor): actually
6220 return the color instead of setting it ourselves
6221 (CVS.__init__): pull .timeout and .workdir options out of
6222 **kwargs, since BuildStep will ignore them. Without this neither
6223 will be sent to the slave correctly.
6224 (SVN.__init__): same
6226 * buildbot/process/builder.py (Builder): move flags to class-level
6228 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6229 SlaveStatus handle that
6231 * buildbot/process/base.py (Build.firstEvent): remove dead code
6232 (Build.stopBuild): bugfix
6234 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6236 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6237 (ChangeMaster.eventGenerator): yield Changes, since there are now
6238 Adapters to turn them into HTML boxes
6240 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6241 (BotPerspective.attached): feed a SlaveStatus object
6242 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6243 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6245 * buildbot/interfaces.py: API additions
6246 (ISlaveStatus): place to get slave status
6248 2004-08-04 Brian Warner <warner@lothar.com>
6250 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6251 the delay finishes, so the step is marked as SUCCESS
6253 * buildbot/test/test_run.py (Status.testSlave): cover more of
6254 IBuildStatus and IBuildStepStatus
6256 * buildbot/status/progress.py (StepProgress): move some flags to
6257 class-level attributes
6258 (StepProgress.remaining): if there are no other progress metrics
6259 to go by, fall back to elapsed time
6260 (StepProgress.setExpectations): take a dict of metrics instead of
6262 (BuildProgress.setExpectationsFrom): pull expectations from the
6263 Expectations, instead of having it push them to the BuildProgress
6264 (Expectations): move some flags to class-level attributes
6265 (Expectations.__init__): copy per-step times from the
6267 (Expectations.expectedBuildTime): new method for per-build ETA
6269 * buildbot/status/event.py (Logfile): move some flags to
6270 class-level attributes
6271 (Logfile.logProgressTo): better method name, let step set the
6272 progress axis name (instead of always being "output")
6274 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6275 times directly, rather than depending upon the (possibly missing)
6276 .progress object. Use 'None' to indicate "not started/finished
6278 (BuildStepStatus.getExpectations): oops, return the full list of
6280 (BuilderStatus._buildFinished): append finished builds to .builds
6282 * buildbot/process/step.py (BuildStep): add separate .useProgress
6283 flag, since empty .progressMetrics[] still implies that time is a
6285 (CVS): set up the cmd in __init__, instead of waiting for start()
6287 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6288 calculation, this will eventually turn into a proper sourceStamp
6289 (Build.setupBuild): tell the Progress to load from the Expectations,
6290 instead of having the Expectations stuff things into the Progress
6291 (Build.buildException): add a build-level errback to make sure the
6292 build's Deferred fires even in case of exceptions
6294 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6296 * buildbot/process/builder.py (Builder.forceBuild): convey the
6297 reason instead of creating a fake Change
6299 * docs/examples/twisted_master.cfg: update to match reality
6301 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6302 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6303 fix or remove broken/breaking tests
6305 * buildbot/status/event.py (Logfile.__len__): remove evil method
6307 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6308 missing .build, for test convenience
6310 * buildbot/process/step_twisted.py: import fixes
6312 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6314 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6315 .statusbag reference
6317 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6318 connection at shutdown, and stop it from reconnecting
6320 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6321 chase down remote-execution bugs
6323 * buildbot/process/step.py: more fixes, remove
6324 BuildStep.setStatus()
6325 * buildbot/status/builder.py: move setStatus() functionality into
6327 * buildbot/status/event.py: minor fixes
6329 2004-08-03 Brian Warner <warner@lothar.com>
6331 * buildbot/process/base.py, buildbot/process/builder.py
6332 * buildbot/process/step.py, buildbot/status/builder.py
6333 * buildbot/status/event.py, buildbot/test/test_run.py:
6334 fix status delivery, get a basic test case working
6335 * buildbot/master.py: finish implementing basic status delivery,
6336 temporarily disable HTML/IRC/PB status sources
6338 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6340 * buildbot/status/progress.py (BuildProgress): remove dead code
6342 * buildbot/interfaces.py
6343 * buildbot/process/base.py, buildbot/process/builder.py
6344 * buildbot/process/step.py, buildbot/process/step_twisted.py
6345 * buildbot/status/builder.py: Complete overhaul of the all
6346 status-delivery code, unifying all types of status clients (HTML,
6347 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6348 look like. This commit is a checkpointing of the work-in-progress:
6349 the input side is mostly done (Builders/Builds sending status
6350 to the BuilderStatus/BuildStatus objects), but the output side has
6351 not yet been started (HTML resources querying BuilderStatus
6352 objects). Things are probably very broken right now and may remain
6353 so for several weeks, I apologize for the disruption.
6355 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6356 HTML as the log's contents. Currently used for exception tracebacks.
6357 * buildbot/status/progress.py: minor spelling changes
6359 2004-08-02 Brian Warner <warner@lothar.com>
6361 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6362 in mozilla. Also added stylesheets copied from Twisted's docs.
6363 Remember that these files are meant to be run through Lore first.
6364 Thanks to Philipp Frauenfelder for the fixes.
6365 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6366 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6367 * docs/template.tpl: added a Lore template
6369 2004-07-29 Brian Warner <warner@lothar.com>
6371 * buildbot/interfaces.py: revamp status delivery. This is the
6372 preview: these are the Interfaces that will be provided by new
6373 Builder code, and to which the current HTML/IRC/PB status
6374 displayers will be adapted.
6376 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6377 on the SlaveBuilder, not the Bot.
6378 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6380 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6381 set .usePTY on the FakeSlaveBuilder
6383 2004-07-25 Brian Warner <warner@lothar.com>
6385 * buildbot/changes/freshcvs.py: add some debug log messages
6386 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6387 disabled 'setFilter' syntax
6388 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6389 don't end with a slash
6391 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6393 * setup.py: bump to 0.5.0+ while between releases
6395 2004-07-23 Brian Warner <warner@lothar.com>
6397 * setup.py (version): Releasing buildbot-0.5.0
6399 2004-07-23 Brian Warner <warner@lothar.com>
6401 * README: update for 0.5.0 release
6403 * NEWS: update for 0.5.0 release
6405 2004-07-22 Brian Warner <warner@lothar.com>
6407 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6408 mktap-time configuration flag (--usepty=1, --usepty=0)
6409 * buildbot/bot.py: same
6411 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6412 an 'info' directory being unwanted
6414 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6415 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6416 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6417 and earlier), use a FreshCVSSourceOldcred instead.
6418 (test): simple test routine: connect to server, print changes
6420 * buildbot/changes/changes.py (Change.getTime): make it possible
6421 to print un-timestamped changes
6423 * buildbot/master.py (makeApp): delete ancient dead code
6424 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6425 * buildbot/test/test_config.py (testFindConfigFile): test it
6427 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6428 instead of win32 one
6431 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6432 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6435 * buildbot/process/base.py (Builder.__init__): change constructor
6436 to accept a dictionary of config data, rather than discrete
6437 name/slave/builddir/factory arguments
6439 * docs/examples/twisted_master.cfg: update to new syntax
6440 * docs/examples/glib_master.cfg: same
6441 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6442 rough tests of the new syntax
6445 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6446 to be an int, which means "run a web.distrib sub-server on a TCP
6447 port". This lets you publish the buildbot status page to a remote
6448 twisted.web server (using distrib.ResourceSubscription). Also
6449 rename the local attributes used to hold these web things so
6450 they're more in touch with reality.
6451 * buildbot/test/test_web.py: test webPortnum and webPathname
6452 * docs/config.xhtml: document this new use of webPathname
6454 * docs/config.xhtml: new document, slightly ahead of reality
6456 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6457 'prefix' handling: treat it as a simple string to check with
6458 .startswith, instead of treating it as a directory. This allows
6459 sub-directories to be used. If you use prefix=, you should give it
6460 a string that starts just below the CVSROOT and ends with a slash.
6461 This prefix will be stripped from all filenames, and filenames
6462 which do not start with it will be ignored.
6464 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6466 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6467 and --exclude (inverse of --include). SVN post-commit hooks
6468 now have total control over which changes get sent to buildbot and which
6471 2004-07-10 Brian Warner <warner@lothar.com>
6473 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6474 test case to match new API
6476 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6477 which crashed HTML display when self.entries=[] (needed to
6478 distinguish between [], which means "no entries yet", and None,
6479 which means "the entries have been swapped out to disk, go fetch
6482 2004-07-04 Brian Warner <warner@lothar.com>
6484 * buildbot/process/step_twisted.py (countFailedTests): Count
6485 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6486 10kb from the end because any import errors are wedged there and
6487 they would make us think the test log was unparseable.
6488 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6490 2004-06-26 Brian Warner <warner@lothar.com>
6492 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6493 delete-*.pyc command into an actual BuildStep, so we can label it
6495 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6496 (FullTwistedBuildFactory): same
6498 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6500 * contrib/fakechange.py: Add an errback when sending the fake
6501 change, so we know it didn't work.
6503 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6505 * buildbot/process/step_twisted.py: Delete *.pyc files before
6506 calling trial, so it doesn't catch any old .pyc files whose .py
6507 files have been moved or deleted.
6509 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6510 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6511 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6512 instead of ["twisted.test"], so that the end result is "trial -R
6515 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6516 regular expression to match filenames that should be ignored when
6517 changed. Also add a --revision parameter that specifies the
6518 revision to examine, which is useful for debugging.
6520 2004-06-25 Brian Warner <warner@lothar.com>
6522 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6523 summary of warnings (like DeprecationWarnings), next to the
6526 2004-05-13 Brian Warner <warner@lothar.com>
6528 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6529 we now have a w32 build slave courtesy of Mike Taylor.
6531 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6532 so broken. Fixed a race condition that tripped up interlocked
6533 builds and caused the status to be stuck at "Interlocked" forever.
6534 The twisted buildbot's one interlocked build just so happened to
6535 never hit this case until recently (the feeding builds both pass
6536 before the interlocked build is attempted.. usually it has to wait
6538 (Builder._pong_failed): fix method signature
6540 * setup.py: bump to 0.4.3+ while between releases
6542 2004-04-30 Brian Warner <warner@lothar.com>
6544 * setup.py (version): Releasing buildbot-0.4.3
6546 2004-04-30 Brian Warner <warner@lothar.com>
6548 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6550 * README: update for 0.4.3 release
6552 * NEWS: update for 0.4.3 release
6554 * buildbot/master.py (BuildMaster.__getstate__): make sure
6555 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6557 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6558 .trial as a class attribute, for upgrade from 0.4.2
6560 * buildbot/changes/changes.py (Change.links): add .links for
6563 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6564 .textWatchers and .htmlWatchers at save time, since they are both
6565 volatile, should allow smooth 0.4.2 upgrade
6567 * buildbot/process/step.py (CVS.finishStatus): catch failed
6568 CVS/SVN commands so we can make the status box red
6570 2004-04-29 Brian Warner <warner@lothar.com>
6572 * buildbot/changes/freshcvs.py
6573 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6574 code to do setFilter(), which tells the freshcvs daemon to not
6575 send us stuff that we're not interested in. I will uncomment it
6576 when a new version of CVSToys is available in which setFilter()
6577 actually works, and I get a chance to test it better.
6579 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6581 * buildbot/master.py (Dispatcher): use a registration scheme
6582 instead of hardwired service names
6583 (BuildMaster): keep track of the Dispatcher to support
6586 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6587 PBChangeSource class instead of having it be an undocumented
6588 internal feature of the ChangeMaster. Split out the code into a
6590 * buildbot/changes/pb.py (PBChangeSource): same
6591 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6593 * docs/{factories|sources|steps}.xhtml: document some pieces
6595 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6596 using FCMaildirSource
6597 (f23osx): update OS-X builder to use python2.3, since the slave
6598 was updated to Panther (10.3.3)
6600 2004-03-21 Brian Warner <warner@lothar.com>
6602 * buildbot/process/process_twisted.py: factor out doCheckout, change
6603 to use SVN instead of CVS
6605 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6606 an SVN subclass easier
6607 (BasicSVN): subclass which uses Subversion instead of CVS
6609 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6611 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6613 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6615 2004-02-25 Brian Warner <warner@lothar.com>
6617 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6618 is now either a list (which is passed to spawnProcess directly) or
6619 a string (which gets passed to /bin/sh -c). This removes the useSH
6620 flag and the ArgslistCommand class. Also send status header at the
6621 start and end of each command, instead of having the master-side
6623 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6624 -r'. Update to use list-based arguments.
6625 (SVNFetch): use list-based arguments, use ['dir'] argument to
6627 * buildbot/test/test_steps.py (Commands): match changes
6629 * buildbot/process/step.py (InternalShellCommand.words): handle
6631 (SVN): inherit from CVS, cleanup
6633 * buildbot/status/event.py (Logfile.content): render in HTML, with
6634 stderr in red and headers (like the name of the command we're
6635 about to run) in blue. Add link to a second URL (url + "?text=1")
6636 to get just stdout/stderr in text/plain without markup. There is
6637 still a problem with .entries=None causing a crash, it seems to occur
6638 when the logfile is read before it is finished.
6640 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6641 timeout to the keepalives, and use it to explicitly do a
6642 loseConnection instead of waiting for TCP to notice the loss. This
6643 ought to clear up the silent-lossage problem.
6644 (unsafeTracebacks): pass exception tracebacks back to the master,
6645 makes it much easier to debug problems
6647 2004-02-23 Brian Warner <warner@lothar.com>
6649 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6650 the whole command to /bin/sh instead of execve [Johan Dahlin]
6651 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6652 '-r HEAD' [Johan Dahlin]
6653 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6655 * buildbot/changes/changes.py (Change): add links= argument, add
6656 asHTML method [Johan Dahlin]. Modified to make a bit more
6657 XHTMLish. Still not sure how to best use links= .
6659 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6660 Change.asHTML to display the change, not asText
6662 * buildbot/status/html.py (StatusResourceBuilder): web button to
6665 * buildbot/test/test_run.py: test to actually start a buildmaster
6668 * MANIFEST.in: bring back accidentally-dropped test helper files
6670 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6671 that require cvstoys if it is not installed
6673 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6674 values of "bin/trial" [Dave Peticolas]
6675 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6676 tests passed" when we didn't happen to run any tests
6678 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6679 flunkOnFailure [Johan Dahlin]
6681 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6682 multiple instances of the same Step class by suffixing "_2", etc,
6683 to the name until it is unique. This name needs to be unique
6684 because it is used as a key in the dictionary that tracks build
6686 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6689 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6691 2004-01-14 Brian Warner <warner@lothar.com>
6693 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6694 kicked from a channel, log it
6696 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6697 something over whatever IRC channels the buildmaster is currently
6698 connected to. Added to try and track down a problem in which the
6699 master thinks it is still connected but the IRCd doesn't see it. I
6700 used a styles.Versioned this time, so hopefully users won't have
6701 to rebuild their .tap files this time.
6702 * contrib/debug.glade: add a "Poke IRC" button
6703 * contrib/debugclient.py: same
6705 * setup.py: bump to 0.4.2+ while between releases
6707 2004-01-08 Brian Warner <warner@lothar.com>
6709 * setup.py (version): Releasing buildbot-0.4.2
6711 2004-01-08 Brian Warner <warner@lothar.com>
6713 * NEWS: update for 0.4.2 release
6715 * README: document how to run the tests, now that they all pass
6717 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6719 * buildbot/process/step.py (CVS): add a global_options= argument,
6720 which lets you set CVS global options for the command like "-r"
6721 for read-only checkout, or "-R" to avoid writing in the
6723 * buildbot/slavecommand.py (CVSCommand): same
6725 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6726 testing easier (it is turned off when testing, to avoid the
6729 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6730 to make it easier to test: break generateStepID() out to a
6731 separate function, only update statusbag if it exists.
6732 (ShellCommands): create useful text for dict-based commands too.
6734 * test/*, buildbot/test/*: move unit tests under the buildbot/
6736 * setup.py (packages): install buildbot.test too
6738 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6739 * buildbot/test/test_steps.py: fix it, tests pass now
6741 2004-01-06 Brian Warner <warner@lothar.com>
6743 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6744 freshcvs mail uses a slightly different syntax for new
6745 directories. Update parser to handle either.
6746 * test/test_mailparse.py (Test1.testMsg9): test for same
6748 2003-12-21 Brian Warner <warner@lothar.com>
6750 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6751 'warnOnWarnings' so that lintian errors mark the build orange
6753 2003-12-17 Brian Warner <warner@lothar.com>
6755 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6756 messages emitted by Bonsai, contributed by Stephen Davis.
6758 * test/*: moved all tests to use trial instead of unittest. Some
6759 still fail (test_steps, test_slavecommand, and test_process).
6761 * setup.py (version): bump to 0.4.1+ while between releases
6763 2003-12-09 Brian Warner <warner@lothar.com>
6765 * setup.py (version): Releasing buildbot-0.4.1
6767 2003-12-09 Brian Warner <warner@lothar.com>
6769 * NEWS: update for 0.4.1 release
6771 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6772 freebsd builder code a little bit
6774 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6775 don't try to compare attributes of different classes
6776 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6777 (MaildirSource.messageReceived): fix Change delivery
6779 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6780 into the config file's namespace before loading it, like the
6781 documentation claims it does
6782 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6783 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6784 daemon comes back online
6786 2003-12-08 Brian Warner <warner@lothar.com>
6788 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6789 so the example will work with online=0 as well
6791 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6792 fix the __implements__ line
6794 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6795 class a twisted.application.service.Service, use startService to
6798 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6799 directory fd instead of simple open(). I'm sure this used to work,
6800 but the current version of python refuses to open directories with
6803 2003-12-05 Brian Warner <warner@lothar.com>
6805 * setup.py (version): bump to 0.4.0+ while between releases
6807 2003-12-05 Brian Warner <warner@lothar.com>
6809 * setup.py (version): Releasing buildbot-0.4.0
6811 2003-12-05 Brian Warner <warner@lothar.com>
6813 * docs/examples/glib_master.cfg: replace old sample scripts with
6814 new-style config files
6815 * MANIFEST.in: include .cfg files in distribution tarball
6817 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6818 implement a dummy method to avoid the exception that occurs when
6819 freshcvs sends this to us.
6821 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6822 removed the method, as it broke reconnection. Apparently
6823 stopFactory is called each time the connection attempt fails. Must
6825 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6826 attribute before serialization, since without stopFactory the
6827 reconnect timer may still be active and they aren't serializable.
6829 * test/test_mailparse.py (ParseTest): test with 'self' argument
6831 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6832 argument, as these "functions" are invoked like methods from class
6833 attributes and therefore always get an instance as the first
6836 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6837 message: thanks to Stephen Davis for the catch
6839 2003-12-04 Brian Warner <warner@lothar.com>
6841 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6842 twisted's standard ReconnectingClientFactory. Handles both oldcred
6843 and newcred connections. Also has a bug-workaround for
6844 ReconnectingClientFactory serializing its connector when it
6847 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6848 pbutil. Replace makeApp stuff with proper newcred/mktap
6849 makeService(). Don't serialize Ephemerals on shutdown.
6851 * buildbot/changes/changes.py (ChangeMaster): make it a
6852 MultiService and add the sources as children, to get startService
6853 and stopService for free. This also gets rid of the .running flag.
6855 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6856 new pbutil, turn into a TCPClient at the same time (to get
6857 startService for free). Two variants exist: FreshCVSSourceOldcred
6858 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6859 yet, but when it does, we'll be ready).
6860 (FreshCVSSource.notify): handle paths which are empty after the
6861 prefix is stripped. This only happens when the top-level (prefix)
6862 directory is added, at the very beginning of a Repository's life.
6864 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6865 Now the only reconnecting code is in the factory where it belongs.
6866 (Builder.unsubscribe): unregister the disconnect callback when we
6867 delete the builder on command from the master (i.e. when the
6868 buildmaster is reconfigured and that builder goes away). This
6869 fixes a multiple-delete exception when the status client is shut
6871 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6874 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6875 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6877 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6879 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6880 a list of globs (ugh). The testdir will be searched for files
6881 named *.tests and run the tests in the order specified in each of
6882 those files. This allows for "dependancies" between tests to be
6885 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6886 argument to pass to run_maxq.py, instead of a glob.
6888 2003-10-17 Brian Warner <warner@lothar.com>
6890 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6891 files that live in the sandbox
6893 2003-10-15 Brian Warner <warner@lothar.com>
6895 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6896 spelling error in "docs" count-warnings output
6897 (HLint.start): stupid thinko meant .xhtml files were ignored
6899 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6900 tests now that cReactor is banished to the sandbox
6902 2003-10-10 Brian Warner <warner@lothar.com>
6904 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6905 scheme: now .xhtml are sources and .html are generated
6907 2003-10-08 Brian Warner <warner@lothar.com>
6909 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6910 we were ignoring the 'randomly' parameter.
6912 2003-10-01 Brian Warner <warner@lothar.com>
6914 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6915 posix, to kill sub-children of aborted slavecommands.
6917 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6918 Clean up initialization: lastBuildStatus remains None until the
6919 first build has been completed.
6921 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6922 None as a lastBuildStatus
6923 * buildbot/clients/gtkPanes.py: same
6925 * buildbot/status/client.py (StatusClientService): keep
6926 BuilderStatus objects in self.statusbags . These objects now live
6927 here in the StatusClientService and are referenced by the Builder
6928 object, rather than the other way around.
6929 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6930 * buildbot/process/base.py (Builder): same
6931 * test/test_config.py (ConfigTest.testBuilders): same
6933 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6934 an existing builder, leave the statusbag alone. This will preserve the
6937 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6938 hook. This will probably go away in favor of a class in upcoming
6941 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6942 serviceName from newcred FreshCVSNotifiee setup
6944 2003-09-29 Brian Warner <warner@lothar.com>
6946 * buildbot/process/process_twisted.py: switch to new reactor
6948 * docs/examples/twisted_master.cfg: same
6950 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6952 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6953 botmaster reference instead of the oldapp service lookup
6955 * buildbot/master.py (BuildMaster.__init__): give the
6956 StatusClientService a reference to the botmaster to make it easier to
6959 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6961 * buildbot/status/html.py (Box.td): escape hreffy things so you
6962 can have spaces in things like builder names
6963 (StatusResourceBuilder.body)
6964 (WaterfallStatusResource.body)
6965 (WaterfallStatusResource.body0): same
6967 2003-09-25 Brian Warner <warner@lothar.com>
6969 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6970 rearrange the builder list when adding or removing builders: keep
6971 them in the order the user requested.
6972 * test/test_config.py (ConfigTest.testBuilders): verify it
6974 * contrib/debug.glade: give the debug window a name
6976 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6977 now wait on multiple interlocks. Fix code relating to that.
6978 (Builder.checkInterlocks): same
6979 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6981 * buildbot/master.py (BuildMaster.loadConfig): move from
6982 deprecated pb.BrokerFactory to new pb.PBServerFactory
6983 * test/test_config.py (ConfigTest.testWebPathname): same
6985 * docs/examples/twisted_master.cfg: fix interlock declaration
6987 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6988 Interlocks to their Builders into interlock.py .
6989 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6991 * test/test_config.py (ConfigTest.testInterlocks): validate
6994 * buildbot/process/base.py (Builder.__init__): better comments
6995 * buildbot/process/interlock.py (Interlock.__repr__): same
6996 (Interlock.deactivate): add .active flag, move the code that
6997 attaches/detaches builders into the Interlock
6999 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7001 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7002 tests using the new run_maxq.py script, and reporting failures by
7005 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7006 tests, reporting their success or failure in a buildbot-friendly
7009 2003-09-24 Brian Warner <warner@lothar.com>
7011 * docs/examples/twisted_master.cfg: example of a new-style config
7012 file. This lives in the buildmaster base directory as
7015 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7016 button to make the master re-read its config file
7018 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7019 buildmaster configuration from a file. This file can be re-read
7020 later, and the buildmaster will update itself to match the new
7021 desired configuration. Also use new Twisted Application class.
7022 * test/Makefile, test/test_config.py: unit tests for same
7024 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7025 FreshCVSSources comparable, to support reload.
7026 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7028 * buildbot/process/base.py (Builder): make them comparable, make
7029 Interlocks easier to attach, to support reload. Handle
7030 re-attachment of remote slaves.
7031 * buildbot/process/interlock.py (Interlock): same
7033 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7034 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7035 buildmaster taps are now constructed with mktap.
7036 * buildbot/status/client.py (StatusClientService): same
7038 * buildbot/status/words.py: move to new Services, add support to
7039 connect to multiple networks, add reload support, allow nickname
7040 to be configured on a per-network basis
7042 2003-09-20 Brian Warner <warner@lothar.com>
7044 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7045 the freebsd builder, now that the machine has been upgraded and no
7046 longer has python2.2
7048 * setup.py (version): bump to 0.3.5+ while between releases
7050 2003-09-19 Brian Warner <warner@lothar.com>
7052 * setup.py (version): Releasing buildbot-0.3.5
7054 2003-09-19 Brian Warner <warner@lothar.com>
7056 * NEWS: add post-0.3.4 notes
7058 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7060 * MANIFEST.in: add contrib/*
7062 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7063 use a remote root now: cvs.twistedmatrix.com
7065 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7067 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7068 compatibility with old servers
7069 (FreshCVSSource.start): and provide a way to use it
7070 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7072 * docs/examples/twisted_master.py (twisted_app): update to new
7074 (twisted_app): listen on new ~buildbot socket
7075 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7077 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7078 to reduce cvs bandwidth (update instead of full checkout)
7080 2003-09-11 Brian Warner <warner@lothar.com>
7082 * contrib/fakechange.py: demo how to connect to the changemaster
7083 port. You can use this technique to submit changes to the
7084 buildmaster from source control systems that offer a hook to run a
7085 script when changes are committed.
7087 * contrib/debugclient.py: tool to connect to the debug port. You
7088 can use it to force builds, submit fake changes, and wiggle the
7091 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7092 'Dispatcher' realm to handle all the different kinds of
7093 connections and Perspectives: buildslaves, the changemaster port,
7094 the debug port, and the status client port. NewCredPerspectives
7095 now have .attached/.detached methods called with the remote 'mind'
7096 reference, much like old perspectives did. All the pb.Services
7097 turned into ordinary app.ApplicationServices .
7098 (DebugService): went away, DebugPerspectives are now created
7099 directly by the Dispatcher.
7100 (makeApp): changed interface a little bit
7102 * buildbot/changes/changes.py: newcred
7103 * buildbot/status/client.py: newcred
7105 * buildbot/clients/base.py: newcred client side changes
7106 * buildbot/bot.py: ditto
7108 * docs/examples/glib_master.py: handle new makeApp() interface
7109 * docs/examples/twisted_master.py: ditto
7111 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7112 base newcred Perspectives on. This should go away once Twisted
7113 itself provides something sensible.
7116 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7118 * contrib/svn_buildbot.py: A program that you can call from your
7119 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7120 when a change in an SVN repository has happened. See the top of
7121 the file for some minimal usage info.
7123 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7125 * buildbot/slavecommand.py (ArglistCommand): Add new
7126 ArglistCommand that takes an argument list rather than a string as
7127 a parameter. Using a st.split() for argv is very bad.
7129 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7130 update to a particular revision rather than always checking out
7131 (still not very smart about it, there may be cases where the
7132 checkout becomes inconsistent).
7134 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7136 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7137 SVN fetch support. It can checkout (not update!) a specified
7138 revision from a specified repository to a specified directory.
7140 * buildbot/status/progress.py (Expectations.update): Fix an
7141 obvious bug (apparently created by the change described in the
7142 previous ChangeLog message) by moving a check to *after* the
7143 variable it checks is defined.
7146 2003-09-08 Brian Warner <warner@lothar.com>
7148 * buildbot/status/progress.py (Expectations.update): hack to catch
7149 an exception TTimo sees: sometimes the update() method seems to
7150 get called before the step has actually finished, so the .stopTime
7151 is not set, so no totalTime() is available and we average None
7152 with the previous value. Catch this and just don't update the
7153 metrics, and emit a log message.
7155 2003-08-24 Brian Warner <warner@lothar.com>
7157 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7158 parameter to set copydir='original' in CVS commands.
7160 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7162 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7163 which tells the command to maintain a separate original-source CVS
7164 workspace. For each build, this workspace will be updated, then
7165 the tree copied into a new workdir. This reduces CVS bandwidth
7166 (from a full checkout to a mere update) while doubling the local
7167 disk usage (to keep two copies of the tree).
7169 2003-08-21 Brian Warner <warner@lothar.com>
7171 * buildbot/status/event.py (Logfile.addEntry): if the master web
7172 server dies while we're serving a page, request.write raises
7173 pb.DeadReferenceError . Catch this and treat it like a
7174 notifyFinish event by dropping the request.
7176 2003-08-18 Brian Warner <warner@lothar.com>
7178 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7179 (instead of blowing up) if a force-build command is given without
7182 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7183 don't blow up if there aren't yet any Changes in the list
7185 2003-08-02 Brian Warner <warner@lothar.com>
7187 * buildbot/bot.py (updateApplication): don't set the .tap name,
7188 since we shouldn't assume we own the whole .tap file
7190 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7191 'mktap buildbot' (without a subcommand) better
7193 2003-07-29 Brian Warner <warner@lothar.com>
7195 * buildbot/status/words.py
7196 (IrcStatusFactory.clientConnectionLost): when we lose the
7197 connection to the IRC server, schedule a reconnection attempt.
7199 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7200 use shutil.rmtree instead of forking off an "rm -rf" command.
7201 rmtree may take a while and will block until it finishes, so we
7202 use "rm -rf" if available.
7204 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7205 freebsd buildslave badly
7207 * setup.py (version): bump to 0.3.4+ while between releases
7209 2003-07-28 Brian Warner <warner@lothar.com>
7211 * setup.py (version): Releasing buildbot-0.3.4
7213 2003-07-28 Brian Warner <warner@lothar.com>
7215 * NEWS: update in preparation for release
7217 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7218 process.signalProcess instead of os.kill, to improve w32
7221 * docs/examples/twisted_master.py (twisted_app): turn off
7222 win32eventreactor: the tests hang the buildslave badly
7224 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7225 failed builds, since usually the failures are consistent
7227 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7228 add compileOpts/compileOpts2 to reactors build
7230 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7231 (twisted_app): use both default and win32eventreactor on w32 build.
7232 Use both default and kqreactor on freebsd build.
7234 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7235 add compileOpts2, which is put after the build_ext argument. w32
7236 needs "-c mingw32" here.
7238 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7239 touch .acqpath, it goes away in recent Twisted releases
7241 * docs/examples/twisted_master.py (twisted_app): use "python" for
7242 the w32 buildslave, not "python2.2"
7244 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7245 the directory exists.. should hush an exception under w32
7247 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7248 ProcessTerminated -provided values for signal and exitCode rather
7249 than parsing the unix status code directly. This should remove one
7250 more roadblock for a w32-hosted buildslave.
7252 * test/test_mailparse.py: add test cases for Syncmail parser
7254 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7255 temporary compatibility import. Note! Start importing
7256 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7258 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7260 2003-07-27 Brian Warner <warner@lothar.com>
7262 * NEWS: started adding new features
7264 * buildbot/changes/mail.py: start work on Syncmail parser, move
7265 mail sources into their own file
7267 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7268 as implementing IChangeSource
7269 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7271 * buildbot/interfaces.py: define the IChangeSource interface
7273 2003-07-26 Brian Warner <warner@lothar.com>
7275 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7277 2003-06-25 Brian Warner <warner@lothar.com>
7279 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7282 2003-06-17 Brian Warner <warner@lothar.com>
7284 * buildbot/status/words.py: clean up method usage to avoid error
7285 in silly IRC command
7286 (IrcStatusBot.emit_status): round off seconds display
7288 * buildbot/process/base.py (Build): delete the timer when saving
7289 to the .tap file, and restore it (if it should still be running)
7290 upon restore. This should fix the "next build in -34 seconds"
7291 messages that result when the master is restarted while builds are
7292 sitting in the .waiting slot. If the time for the build has
7293 already passed, start it very soon (in 1 second).
7295 * buildbot/status/words.py: more silly commands
7297 * README (REQUIREMENTS): add URLs to all required software
7299 * buildbot/status/words.py ('last'): mention results of, and time
7302 2003-05-28 Brian Warner <warner@lothar.com>
7304 * buildbot/status/words.py: add 'last' command
7305 (IrcStatusBot.emit_status): add current-small text to 'status' output
7307 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7308 (twisted_app): remove spaces from OS-X builder name
7310 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7311 * buildbot/status/words.py: IRC bot should actually be useful now
7313 2003-05-23 Brian Warner <warner@lothar.com>
7315 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7316 "slave information" from $(slavedir)/info/* . These files are
7317 maintained by the slave administrator, and describe the
7318 machine/environment that is hosting the slave. Information from
7319 them is put into the "Builder" HTML page. Still need to establish
7320 a set of well-known filenames and meanings for this data: at the
7321 moment, *all* info/* files are sent to the master, but only
7322 'admin' and 'host' are used on that end.
7323 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7324 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7325 * buildbot/master.py (BotPerspective.got_info): ditto
7327 2003-05-22 Brian Warner <warner@lothar.com>
7329 * setup.py (version): bump version to 0.3.3+ while between releases
7331 2003-05-21 Brian Warner <warner@lothar.com>
7333 * setup.py: Releasing buildbot-0.3.3
7335 2003-05-21 Brian Warner <warner@lothar.com>
7337 * NEWS: 0.3.3 news items
7339 * README: describe --keepalive and life behind a NAT box
7341 * buildbot/bot.py (Bot.connected): implement application-level
7342 keepalives to deal with NAT timeouts, turn them on with
7343 --keepalive option or when SO_KEEPALIVE doesn't work.
7345 * buildbot/master.py (BotPerspective): accept keepalives silently
7347 * buildbot/process/base.py (Build.buildException): CopiedFailures
7348 don't carry as much information as local ones, so don't try to
7349 create a big HTMLized version of them.
7351 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7352 log file when step fails due to an exception, such as when the slave
7355 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7356 --testmodule argument instead of grepping for test-case-name tags
7357 ourselves. Remove FindUnitTests code.
7358 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7360 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7362 2003-05-16 Brian Warner <warner@lothar.com>
7364 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7365 argument to allow things like CFLAGS=-O0 to be passed without relying
7366 upon /bin/sh processing on the slave.
7368 * buildbot/process/step.py (InternalShellCommand.start): send
7370 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7371 'split' instead of letting /bin/sh do it. This should also remove
7372 the need for /bin/sh on the buildslave, making it more likely to
7375 * buildbot/status/html.py: html-escape text in blamelist.
7376 Add "force build" button to the Builder page.
7378 * buildbot/process/step_twisted.py (countFailedTests): look at
7379 last 1000 characters for status line, as import errors can put it
7380 before the -200 point.
7382 2003-05-15 Brian Warner <warner@lothar.com>
7384 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7386 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7387 make 'clobber' a parameter, so it is possible to have builds which
7388 do full tests but do a cvs update instead of hammering the CVS
7389 server with a full checkout each build
7391 * buildbot/process/step.py (InternalShellCommand): bump default
7392 timeout to 20 minutes
7394 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7395 the master to trigger a build. Run it via manhole.
7397 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7398 allow slaves to trigger any build that they host, to make life
7399 easier for slave admins who are testing out new build processes
7401 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7402 don't flunk cReactor or qtreactor on failure, since they fail alot
7403 these days. Do warnOnFailure instead.
7405 * buildbot/process/base.py: change Builder.buildable from a list
7406 into a single slot. When we don't have a slave, new builds (once
7407 they make it past the timeout) are now merged into an existing
7408 buildable one instead of being queued. With this change, a slave
7409 which has been away for a while doesn't get pounded with all the
7410 builds it missed, but instead just does a single build.
7412 2003-05-07 Brian Warner <warner@lothar.com>
7414 * setup.py (version): bump version to 0.3.2+ while between releases
7416 2003-05-07 Brian Warner <warner@lothar.com>
7418 * setup.py: Releasing buildbot-0.3.2
7420 2003-05-07 Brian Warner <warner@lothar.com>
7422 * setup.py: fix major packaging error: include subdirectories!
7424 * NEWS: add changes since last release
7426 * README (REQUIREMENTS): update twisted/python dependencies
7428 * buildbot/status/builder.py (Builder.startBuild): change
7429 BuildProcess API: now they should call startBuild/finishBuild
7430 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7431 keeping a list of builds in the statusbag, to support other kinds of
7433 (Builder.addClient): send current-activity-small to new clients
7434 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7437 * buildbot/status/client.py: drop RemoteReferences at shutdown
7439 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7441 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7442 more debug messages for remote status client
7444 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7445 (.stepFailed): only fire the Deferred once, even if both
7446 stepComplete and stepFailed are called. I think this can happen if
7447 an exception occurs at a weird time.
7449 * buildbot/status/words.py: work-in-progress: IRC status delivery
7451 2003-05-05 Brian Warner <warner@lothar.com>
7453 * docs/examples/twisted_master.py (twisted_app): hush internal
7454 python2.3 distutils deprecation warnings
7455 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7456 add compileOpts= argument which inserts extra args before the
7457 "setup.py build_ext" command. This can be used to give -Wignore
7458 warnings, to hush some internal python-2.3 deprecation messages.
7460 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7461 the ['twisted.test'] default test case to make it easier to change
7464 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7465 * buildbot/clients/gtkPanes.py: ditto
7467 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7468 arg to collapse RunUnitTestsRandomly into RunUnitTests
7469 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7470 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7472 * buildbot/status/html.py (StatusResource): shuffle Resources
7473 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7474 would serve the waterfall display, but the internal links were
7475 only valid on the trailing-slash version. The correct behavior is
7476 for the non-slashed one to serve a Redirect to the slashed one.
7477 This only shows up when the buildbot page is hanging off another
7478 server, like a Twisted-Web distributed server.
7480 * buildbot/status/event.py (Event, RemoteEvent): make Events
7481 pb.Cacheable, with RemoteEvent as the cached version. This removes
7482 a lot of explicit send-an-update code.
7483 * buildbot/status/builder.py (Builder): remove send-update code
7484 * buildbot/status/client.py (ClientBuilder): remove send-update
7485 code, and log errors that occur during callRemote (mostly to catch
7486 InsecureJelly exceptions)
7488 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7489 run Lore with the same python used in the rest of the build
7491 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7493 * buildbot/process/step_twisted.py (HLint): accept 'python'
7494 argument. Catch rc!=0 and mark the step as failed. This marks the
7495 build orange ("has warnings").
7496 (RunUnitTestsJelly): move out to step_twisted2.py
7498 * buildbot/util.py (ignoreStaleRefs): add utility function
7500 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7501 don't fake ETA object, it's too hard to get right
7503 2003-05-02 Brian Warner <warner@lothar.com>
7505 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7507 2003-05-01 Brian Warner <warner@lothar.com>
7509 * buildbot/status/html.py (StatusResource.body): oops, I was
7510 missing a <tr>, causing the waterfall page to be misrendered in
7511 everything except Galeon.
7513 2003-04-29 Brian Warner <warner@lothar.com>
7515 * docs/examples/twisted_master.py: make debuild use python-2.2
7516 explicitly, now that Twisted stopped supporting 2.1
7518 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7519 handle tuple results too. I keep forgetting this, which suggests
7520 it needs to be rethought.
7522 * setup.py (setup): bump version to 0.3.1+ while between releases
7524 2003-04-29 Brian Warner <warner@lothar.com>
7526 * setup.py: Releasing buildbot-0.3.1
7528 2003-04-29 Brian Warner <warner@lothar.com>
7530 * README (SUPPORT): add plea to send questions to the mailing list
7532 * NEWS, MANIFEST.in: add description of recent changes
7534 * docs/examples/twisted_master.py: add the code used to create the
7535 Twisted buildmaster, with passwords and such removed out to a
7538 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7539 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7540 buildmasters to not require CVSToys be installed.
7541 * README, docs/examples/glib_master: update to match the change
7543 * buildbot/clients/base.py, buildbot/bot.py,
7544 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7545 ReconnectingPB from CVSToys distribution to remove CVSToys
7546 dependency for build slaves and status clients. Buildmasters which
7547 use FreshCVSSources still require cvstoys be installed, of course.
7549 2003-04-25 Brian Warner <warner@lothar.com>
7551 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7552 runTestsRandomly arg to turn on trial -z
7554 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7555 experimental code to use trial's machine-parseable output to get
7556 more detailed test results. Still has some major issues.
7557 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7560 * buildbot/status/builder.py (Builder.setCurrentBuild):
7561 anticipating moving build history into statusbag, not used yet
7563 * buildbot/status/tests.py: code to centralize test results,
7564 doesn't work quite yet
7566 * buildbot/status/event.py (Event): use hasattr("setName") instead
7567 of isinstance for now.. need better long-term solution
7569 * buildbot/status/html.py: Remove old imports
7571 2003-04-24 Brian Warner <warner@lothar.com>
7573 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7574 ignore changes under doc/fun/ and sandbox/
7576 * buildbot/process/step_twisted.py: update pushEvent and friends.
7578 * buildbot/status/html.py (Box.td): replace event.buildername with
7579 event.parent.getSwappableName(). Needs more thought.
7581 * buildbot/status/builder.py (Builder): Replace pushEvent and
7582 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7583 Tell events they are being pruned with event.delete().
7585 * buildbot/process/base.py (Build): Remove Builder status-handling
7586 methods. s/pushEvent/setCurrentActivity/.
7588 * buildbot/process/step.py (BuildStep): clean up status delivery.
7589 Gouse builder.statusbag methods instead of intermediate builder
7590 methods. s/updateLastEvent/updateCurrentActivity/.
7591 s/finalizeLastEvent/finishCurrentActivity/. Use
7592 addFileToCurrentActivity for summaryFunction.
7594 * buildbot/status/event.py (Logfile): put data in a Swappable when
7596 (Event): add more setter methods. Remove .buildername, use .parent
7597 and getSwappableName instead (needs more thought).
7599 * buildbot/util.py (Swappable):
7600 * test/test_swap.py: don't bother setting filename at __init__
7601 time, do it later. Change setFilename args to take parent first,
7602 since it provides the most significant part of the filename.
7604 2003-04-23 Brian Warner <warner@lothar.com>
7606 * buildbot/status/event.py (Logfile.addEntry): append to previous
7609 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7610 anticipating Swappable
7611 (InternalShellCommand.remoteUpdate): split out various log-adding
7612 methods so subclasses can snarf stdout separately
7614 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7615 in anticipation of Swappable build logs
7616 (Builder.testsFinished): anticipating TestResults, still disabled
7618 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7621 * buildbot/status/event.py (Logfile): add (disabled) support for
7622 Swappable, not ready for use yet
7624 * buildbot/util.py (Swappable): object which is swapped out to
7625 disk after some period of no use.
7626 * test/test_swap.py: test buildbot.utils.Swappable
7628 2003-04-14 Brian Warner <warner@lothar.com>
7630 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7631 periodic-build timer. Set the .periodicBuildTime on a builder
7632 instance to some number of seconds to activate it.
7634 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7636 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7637 a way that survives result tuples
7639 2003-04-12 Brian Warner <warner@lothar.com>
7641 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7642 return a dict instead of a tuple: allow summarizers to provide
7643 multiple summaries if they want
7644 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7645 (debuildSummarizer): summarize lintian warnings/errors
7647 2003-04-10 Brian Warner <warner@lothar.com>
7649 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7651 2003-04-09 Brian Warner <warner@lothar.com>
7653 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7654 empty summaries: happens when the tests fail so hard they don't emit
7655 a parseable summary line.
7657 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7658 Allow summaryFunction to return None to indicate no summary should
7661 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7662 writing to stale HTTP requests: notice when they disconnect and
7663 remove the request from the list. Also add CacheToFile from
7664 moshez, will be used later.
7666 2003-04-08 Brian Warner <warner@lothar.com>
7668 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7669 should be an int, not a list of strings
7671 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7672 if we weren't actually connected
7674 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7675 to show the tail end of the trial text output
7677 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7678 hook to summarize the results of a ShellCommand
7680 2003-04-07 Brian Warner <warner@lothar.com>
7682 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7683 twisted test suite code into a single class.
7684 * buildbot/process/process_twisted.py: same
7686 2003-04-04 Brian Warner <warner@lothar.com>
7688 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7690 * README (SLAVE): document use of mktap to create slave .tap file
7691 (REQUIREMENTS): describe dependencies
7693 * buildbot/bb_tap.py, buildbot/plugins.tml:
7694 * buildbot/bot.py (updateApplication): Add mktap support for creating
7695 buildslave .tap files
7697 2003-03-28 Brian Warner <warner@lothar.com>
7699 * buildbot/process/step.py (InternalShellCommand.finished): handle
7700 new tuple result values (fix embarrasing bug that appeared during
7703 2003-03-27 Brian Warner <warner@lothar.com>
7705 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7708 2003-03-25 Brian Warner <warner@lothar.com>
7710 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7711 to overall build status
7712 * buildbot/clients/base.py (Builder): improve event printing
7713 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7714 instead of generic ShellCommand
7715 (Build): Add .stopBuild, use it when slave is detached
7717 * buildbot/process/step.py (Configure,Test): give the steps their
7718 own names and status strings
7720 * buildbot/status/html.py (StatusResource): add "show" argument,
7721 lets you limit the set of Builders being displayed.
7723 2003-03-20 Brian Warner <warner@lothar.com>
7725 * buildbot/process/basic.py: removed
7727 2003-03-19 Brian Warner <warner@lothar.com>
7729 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7730 turn off process-docs by default
7732 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7733 when displaying build information without anything in allBuilds[]
7735 * buildbot/bot.py (makeApp): really take password from sys.argv
7737 2003-03-18 Brian Warner <warner@lothar.com>
7739 * buildbot/bot.py (buildApp): take password from sys.argv
7741 * README: replace with more useful text
7743 * setup.py: add a real one
7744 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7746 * docs/PyCon-2003/: added sources for PyCon paper.
7748 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7749 now Build objects control the process and Builder only handles
7750 slave stuff and distribution of changes/status. A new BuildFactory
7751 class creates Build objects on demand.
7753 Created ConfigurableBuild which takes a list of steps to run. This
7754 makes it a lot easier to set up a new kind of build and moves us
7755 closer to being able to configure a build from a web page.
7757 * buildbot/process/step_twisted.py, process_twisted.py: move to
7758 new model. A lot of code went away.
7760 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7761 send lots of empty progress messages to the client.
7763 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7765 2003-02-20 Brian Warner <warner@lothar.com>
7767 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7769 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7770 Twisted bug that prevented non-pty processes from working just got
7771 fixed, and the bug that leaks ptys is still being investigated.
7773 * buildbot/process/step.py (CVS): send timeout arg to slave
7775 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7776 builders coming and going
7777 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7778 from CVSToys, handle lost-buildmaster
7780 * buildbot/status/client.py (StatusClientService.removeBuilder):
7781 Clean up status client protocol: send builders (with references)
7782 as they are created, rather than sending a list and requiring the
7783 client to figure out which ones are new.
7784 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7785 attempts to force a build on an unknown builder
7787 2003-02-19 Brian Warner <warner@lothar.com>
7789 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7790 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7791 Twisted stops leaking them.
7792 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7793 builder goes to an idle state.
7795 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7796 I figure out why CVS commands hang without them, and/or I fix the
7797 hung-command timeout
7799 2003-02-16 Brian Warner <warner@lothar.com>
7801 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7802 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7803 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7804 GenerateDocs now that they are prefixed with WARNING:.
7806 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7807 use manual href target instead of request.childLink
7809 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7810 display every second, but update the ETA every 5 seconds (or
7811 whenever) as remote_progress messages arrive.
7814 2003-02-12 Brian Warner <warner@lothar.com>
7816 * *: import current sources from home CVS repository
7820 # add-log-time-format: add-log-iso8601-time-string