1 2007-08-12 Brian Warner <warner@lothar.com>
3 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
4 use the BuildSlave to keep track of the last time we've heard from
5 the buildslave. This is updated upon receipt of any message from
6 any SlaveBuilder (which generally means when RemoteCommands are
7 giving us status updates, as BuildSteps run). In the future this
8 will include slave pings too.
9 * buildbot/process/base.py
10 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
11 * buildbot/process/buildstep.py:
12 (BuildStep.setBuildSlave): accept that reference
13 (BuildStep.runCommand): pass the reference on to the RemoteCommand
14 (RemoteCommand.remote_update): update the timestamp
15 (RemoteCommand.remote_complete): same
16 * buildbot/test/runutils.py (StepTester.makeStep): match the change
17 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
18 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
19 interface to retrieve this timestamp
20 * buildbot/status/builder.py (SlaveStatus): track a copy of the
24 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
26 (OneLinePerBuild.body): use a <ul> instead of <div>s
27 (OneLinePerBuildOneBuilder.body): same
29 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
30 by adding the file's new name to the list of changed files. This
31 ought to be sufficient for things like isFileImportant and trial
32 tests that only exercise tests for files that have been modified.
35 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
36 XMLRPC server to the WebStatus page. This only has two methods
37 right now (getAllBuildsInInterval and getBuild), but we'll be
38 adding more in the future. This server is extracted from the
41 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
42 generateFinishedBuilds, and improve the data displayed.
43 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
44 the per-Build page, add some information like ETA and got_revision
45 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
46 adding a list of recently completed builds
47 * buildbot/status/web/base.py (css_classes): factor this out
49 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
50 new method, to make status display classes easier to write,
51 especially the WebStatus 'one_line_per_build' page.
52 (IBuilderStatus.generateFinishedBuilds): same
53 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
54 (Status.generateFinishedBuilds): implement it
56 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
57 'source' to be a BuildStep instance, since BuildFactory accepts
60 (Distutils.__init__): same
61 (Trial.__init__): same
63 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
64 this might raise KeyError
66 2007-08-07 Brian Warner <warner@lothar.com>
68 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
69 'Owner:' field of the view, rather than 'p4logname', since
70 p4logname comes from the buildslave's environment and seems
71 unlikely to ever do the right thing. Thanks to Wade Brainerd for
72 the patch. Closes #40.
74 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
75 which imposes a per-slave limit on how many builds are allowed to
76 run simultaneously. This has a the same scope than the SlaveLock,
77 but is different because max_builds= gives the buildmaster the
78 freedom to assign the build to a different slave, whereas the
79 SlaveLock doesn't get tested until after the build is irrevocably
80 assigned to a slave. Therefore using max_builds= will improve
81 utilization in the presence of multiple buildslaves that are
82 attached to the same Builder. This completes the incorporation of
83 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
84 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
85 any Builder finishes, potentially trigger *all* Builders, since
86 max_builds= may have stalled someone else while waiting for the
88 * buildbot/scripts/sample.cfg: mention max_builds=
89 * buildbot/test/test_run.py (ConcurrencyLimit): test it
90 * docs/buildbot.texinfo (Buildslave Specifiers): document it
92 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
93 inherit from RunMixin do not need to call master.stopService()
94 themselves, since RunMixin.tearDown does that. The double call
95 fails on Twisted-2.0.x, which didn't happen to protect against it.
96 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
98 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
99 from #48, this one to have the BuildSlave objects track
100 SlaveBuilders, so they'll be able to use that knowledge to
101 influence their canStartBuild() response.
102 * buildbot/process/builder.py (SlaveBuilder.attached): call it
103 (SlaveBuilder.detached): same
104 * buildbot/test/test_slaves.py (BuildSlave): test it
106 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
107 the second of Dustin's #48 patches, this one adding a method to
108 the BuildSlave that allows it to decide whether it is willing to
109 participate in a build or not.
110 (SlaveBuilder.isAvailable): use canStartBuild() to decide
112 * buildbot/test/test_run.py (CanStartBuild): test for it
114 * all: incorporate the first of four patches by Dustin Mitchell
115 from ticket #48, working towards improving control over slave
116 concurrency. The first patch is to use a long-lived BuildSlave
117 object per slave, on which other behavior can be added later. I've
118 modified his patch considerably.
119 * buildbot/buildslave.py (BuildSlave): move class out of
120 slave/__init__.py (where it would get loaded by the slave as well
121 as the master, making dependencies trickier), and merge it with
122 BotPerspective. Now these BuildSlave instances are created once in
123 the master.cfg file, and not destroyed until they are either
124 removed from the config file or changed so
125 much (name/password/class changes) that we cannot continue to use
126 the old one. This affects config files: they must use
127 'from buildbot.buildslave import BuildSlave' instead of using
128 'from buildbot.slave import BuildSlave'.
129 * buildbot/master.py: move BotPerspective out
130 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
131 add or remove as necessary, update the rest using data from
133 * buildbot/slave/__init__.py: move BuildSlave out
134 * buildbot/test/test*.py: import BuildSlave from the new place
135 * buildbot/scripts/sample.cfg: update to match
136 * docs/buildbot.texinfo: update to match
137 * buildbot/process/builder.py: update comments to match
139 2007-08-02 Brian Warner <warner@lothar.com>
141 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
142 one-line-per-build pages a bit, add a header, refactor slightly
144 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
145 the TimeOutError timer, patch by Dustin Mitchell.
147 2007-08-01 Brian Warner <warner@lothar.com>
149 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
150 mostly work (branch= is still ignored, we need a useful header)
151 (OneLinePerBuildOneBuilder.body): this too
153 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
154 bring this up-to-date w.r.t. recent refactorings, and fix
155 redirections to bounce the browser to the top page after hitting
156 the 'force' button. This needs to be improved, but at least it now
157 redirects to a valid page.
158 (StatusResourceBuilder.ping): same
159 (StatusResourceBuilder.getChild): same, although I think this code
160 might be dead anyways
162 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
163 a branch= query argument, to filter the display down to builds and
164 changes that involve the given branch. You can add multiple
165 branch= arguments to see multiple branches (using a logical OR).
166 Note that there is no way to include the default branch (i.e.
167 None, i.e. trunk) yet, there is still work to be done to allow for
168 simple+uniform names of branches (i.e. removing the VC-specific
169 details of how branches are implemented, so calling the branch
170 'beta4' even though the SVN checkout step requires
172 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
173 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
174 * buildbot/interfaces.py (IEventSource.eventGenerator): same
175 * docs/buildbot.texinfo (Buildbot Web Resources): document it
177 * all: bring import statements up-to-date: don't import
178 __future__, assume cPickle and cStringIO are always available.
179 Also remove #!/usr/bin/python lines from non-scripts, my editor
180 has been a bit over-enthusiastic about stuffing them into new .py
183 * buildbot/status/web/index.html: put a link to the waterfall page
184 on the index, otherwise first-time users of WebStatus aren't going
185 to see anything very interesting.
187 * buildbot/interfaces.py (IEventSource): document this interface.
188 Thanks to Dustin Mitchell for the patch. Closes #60.
189 * buildbot/status/builder.py (BuilderStatus): same
190 * buildbot/changes/changes.py (ChangeMaster): same
192 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
193 add a query arg of 'show_events=true' to display non-build events,
194 like slaves attaching/detaching and reconfig events, or
195 'show_events=false' to hide them. The default is 'true'.
196 * docs/buildbot.texinfo (Buildbot Web Resources): document it
198 * web-parts: merge in web-parts branch. Lots of changes. The new
199 functionality is to add buildbot.status.html.WebStatus, which is a
200 superset of the Waterfall that adds new status pages and serves
201 regular files from BASEDIR/public_html/ , which is now the preferred
202 place to put robots.txt, buildbot.css, and index.html .
203 * buildbot/scripts/runner.py: the 'create-master' command now
204 creates public_html/ too, and populates it with a couple of
206 * buildbot/status/web: split waterfall code into smaller pieces
208 2007-07-31 Brian Warner <warner@lothar.com>
210 * buildbot/scripts/startup.py (launch): import twistd.run in a
211 different way to hush pyflakes
212 * buildbot/process/builder.py: remove unused import
214 2007-07-30 Brian Warner <warner@lothar.com>
216 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
217 Mitchell: pass SourceStamps around rather than branch/version/etc
218 tuples. Thanks Dustin! Closes #70.
219 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
220 tuple rather than a list, to avoid surprising mutations
221 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
222 * buildbot/status/mail.py (MailNotifier.buildMessage): same
223 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
224 * buildbot/test/test_status.py (Subscription): same
225 * buildbot/test/test_control.py (Force): same
226 * buildbot/test/test_buildreq.py (Request.testMerge): same
228 2007-07-29 Brian Warner <warner@lothar.com>
230 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
231 variable, since it wasn't used and is confusing in the presence of
232 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
235 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
236 the Buildbot home-page link to point at buildbot.net instead of
237 sourceforge, and add a current-version query parameter so we can
238 get some statistics on which versions are in use out there.
240 2007-07-28 Brian Warner <warner@lothar.com>
242 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
243 with c['change_source'], leaving c['sources'] for backwards
244 compatibility (but deprecated), scheduled for removal in 0.8.0
245 * docs/buildbot.texinfo: same
246 * buildbot/test/test_config.py: verify that c['sources'] still works
247 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
248 * buildbot/scripts/sample.cfg: update to match
250 * buildbot/changes/mail.py (MaildirSource): parse with python's
251 stdlib 'email' module, which has been available since python2.2,
252 and drop use of the 'rfc822' module, which has been depreceated
254 * buildbot/test/test_maildir.py: same: use parse_file() not parse
256 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
257 this needs to match the renaming in test/mail/msg*
259 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
262 * buildbot/test/test_mailparse.py: rename sample emails a bit
263 * buildbot/test/mail/msg*: same
265 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
266 parser for the "commit-email.pl" script that is shipped with SVN,
267 written by Justin Mason. Thanks! Closes SF#1072845.
268 * buildbot/test/mail/svn-commit.*: sample messages
269 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
270 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
272 2007-07-27 Brian Warner <warner@lothar.com>
274 * buildbot/changes/mail.py: refactor: move parsing into a method
275 named 'parse', each parser type gets a separate subclass. Remove
276 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
277 to be a simple leading-substring match. Add a warning to the logs
278 if prefix= does not end in a slash, since that's probably a
279 mistake. Fix both places where a prefix= mismatch would skip all
280 subsequent files in the same email, instead of just skipping the
281 one that didn't match.
282 * buildbot/test/test_mailparse.py: match changes
284 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
285 docs on email-based ChangeSources
287 * docs/buildbot.texinfo (Getting Source Code Changes): move all
288 the changesource types up a level, removing the one-entry menu in
291 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
292 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
293 instances instead of tuples. Closes #63.
294 * buildbot/slave/__init__.py (BuildSlave): define marker class
295 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
296 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
297 * buildbot/test/test_*.py: update tests to match
298 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
299 the c['bots'] backwards-compatibility handler works
301 2007-07-26 Brian Warner <warner@lothar.com>
303 * buildbot/changes/hgbuildbot.py (hook): add an in-process
304 Mercurial change-sending hook, contributed by Frederic Leroy.
305 Thanks! Addresses #50.
306 * docs/buildbot.texinfo (MercurialHook): document it
308 * buildbot/changes/hgbuildbot.py: change the way imports are done,
309 to make it compatible with at least hg-0.9.1 and the current 0.9.4
311 2007-07-17 Brian Warner <warner@lothar.com>
313 * buildbot/process/buildstep.py (BuildStep.getLog): add a
314 convenience method to retrieve a log added with
315 addLog()/addCompleteLog()/etc or logfiles= . I should have added
318 2007-07-03 Brian Warner <warner@lothar.com>
320 * buildbot/slave/commands.py (ShellCommand._startCommand): when
321 logging the environment variables, put one variable on each line,
322 rather than having one really long line with all of them. This
323 should make them a bit more readable and not trigger the
324 horizontal scrollbar (when viewing it in a web browser) quite so
325 much. Thanks to Albert Hofkamp for the patch.
327 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
328 WithProperties instance. Thanks to Axel Hecht for the patch.
330 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
331 * docs/buildbot.texinfo (Build Properties): document it
332 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
333 workdir if it didn't already exist.
335 * docs/buildbot.texinfo (Scheduler Types): correct the description
336 of Dependent schedulers. Thanks to Greg Ward for the patch.
338 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
339 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
340 the patch. Closes #49.
342 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
343 0700 before removing it, to deal with situations where a build will
344 leave files around without write permissions and the 'copy' or
345 'clobber' VC checkout modes need to blow away the tree first.
346 Thanks to Steve Milner for the suggestion and the patch (which I
347 mangled horribly). Closes #29.
348 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
351 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
352 an allowReconnect= argument to let callers control whether they
353 want this don't-let-it-reconnect behavior, since some tests care.
354 Factor out the .continueTrying=False lines from those callers.
355 * buildbot/test/test_slaves.py: same
356 * buildbot/test/test_run.py: same
358 2007-07-02 Brian Warner <warner@lothar.com>
360 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
361 slave has been disappeared, don't let it reconnect. This was
362 causing an intermittent failure in test_slaves.py, when the slave
363 that was supposed to be gone managed to come back by the end of
364 the test and affect the count.
365 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
367 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
368 diagnostic messages to track down this problem
369 (Builder.startBuild): same
371 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
372 the slave randomly rather than always taking the first one. Thanks
373 to Pike for the patch. Closes #36.
374 * buildbot/test/test_slaves.py: match the change. to avoid huge
375 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
376 enables/disables the round-robin-ness (enabled by default), and
377 some unit tests disable it.
378 * docs/buildbot.texinfo (Buildmaster Architecture): document it
380 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
381 argument to 'buildmaster_host', to make it more obvious that this
382 points to the buildmaster. Thanks to Bob Proulx for the
384 * buildbot/scripts/runner.py (slaveTAC): same
385 * buildbot/test/test_runner.py (Create.testSlave): match the change
387 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
390 2007-06-17 Brian Warner <warner@lothar.com>
392 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
393 we can round-trip all of our current step classes by calling
394 getStepFactory() and using the results to make a clone of the
397 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
400 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
401 the config file, we're moving to using actual instances instead of
402 the (class, kwargs) 'step specification' tuples. BuildFactory
403 still keeps a list of tuples internally, but when real instances
404 are passed in to addStep(), they are asked for their class and
405 kwargs using the new BuildStep.getStepFactory method. BuildFactory
406 accepts both instances and the tuple form, and converts instances
407 to the tuple form, but the instance form is preferred because it
408 gives the Steps a chance to do argument validation. Closes: #11.
410 * buildbot/process/buildstep.py (BuildStep.__init__): record the
411 factory information necessary to implement getStepFactory. The
412 addFactoryArguments() method can be used to include arguments that
413 aren't passed to the BuildStep base class constructor.
414 (BuildStep.setBuild):
415 (BuildStep.setDefaultWorkdir): new methods to take parameters that
416 are needed for live BuildSteps but not to construct the specification
417 tuples that are stashed in the factory.
419 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
420 'workdir' into new BuildSteps by using methods instead of
421 arguments. This makes the constructor for BuildSteps a lot
424 * buildbot/steps/*.py: update to match this change. Basically this
425 means adding calls to addFactoryArguments() in the __init__
426 methods to capture the arguments that aren't passed through to the
428 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
429 the new workdir (if any) into the RemoteShellCommands arguments.
430 * buildbot/steps/source.py: allow workdir= to be optional,
431 implement setDefaultWorkdir() since we don't inherit from
432 (CVS): finally remove old clobber=/export=/copydir= arguments,
433 in favor of the mode= argument that's been around forever now.
434 * buildbot/steps/transfer.py: remove build= argument
436 * buildbot/test/*.py: update to match, generally by turning all
437 build= arguments into subsequent calls to s.setBuild()
438 * buildbot/test/test_config.py (Factories): verify that we can
439 use either BuildStep instances or class/kwarg tuples in both
440 BuildFactory.addStep and BuildFactory.__init__
442 * docs/buildbot.texinfo (Build Steps): document the new approach,
443 mention compatibility with the old approach, update all examples
444 to use the new style.
446 2007-06-16 Brian Warner <warner@lothar.com>
448 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
449 the LoopingCall, just eat the failure so that we'll poll again
450 next time. This should allow us to tolerate (e.g.) sf.net SVN
451 failures more gracefully. Many thanks to Dustin Mitchell for the
454 2007-05-17 Brian Warner <warner@lothar.com>
456 * buildbot/status/words.py: refactor the IRC status bot into
457 separate 'Contact' and 'Channel' classes. The base Contact class
458 contains the interaction code: commands and responses. The
459 IRCContact subclass (and IrcStatusBot 'Channel') handle the
460 IRC-specific aspects. The plan is to write other subclasses for
461 other IM protocols like AIM and Jabber.
463 2007-04-16 Brian Warner <warner@lothar.com>
465 * CREDITS: update list of contributors. Thank you all!
467 2007-04-13 Brian Warner <warner@lothar.com>
469 * buildbot/status/mail.py (MailNotifier): add the project name to
470 the subject line and message body, to make it easier to
471 distinguish email coming from different buildmasters. Thanks to
472 Benoit Sigoure for the patch.
473 * buildbot/test/test_status.py (Mail): update to match
475 2007-03-24 Brian Warner <warner@lothar.com>
477 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
478 avoid text-conversion problems between DOS/windows and unix.
479 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
481 2007-03-03 Brian Warner <warner@lothar.com>
483 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
484 warning about the use of Waterfall here
486 2007-03-01 Brian Warner <warner@lothar.com>
488 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
490 2007-02-28 Brian Warner <warner@lothar.com>
492 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
493 Lamb to use a more optimal form of 'p4 changes', to reduce server
494 load. He reports that this optimization was added to p4d release
495 2005.2, but it should work in all versions. Closes #27.
496 * buildbot/test/test_p4poller.py: match it
498 2007-02-27 Brian Warner <warner@lothar.com>
500 * buildbot/status/web/*.py: move all web status stuff into a
501 separate directory, in anticipation of splitting it into smaller
502 pieces and adding more files. html.py was getting way too big.
503 * buildbot/status/classic.css: move it too
504 * setup.py: add the new sub-package
505 * buildbot/test/test_web.py: match the changes
506 * MANIFEST.in: handle the move of classic.css
508 2007-02-07 Brian Warner <warner@lothar.com>
510 * contrib/OS-X/*: add some launchd .plist files for automatically
511 starting a buildmaster or buildslave under OS-X (10.4 or later).
512 Thanks to Mark Pauley for these.
514 2007-02-06 Brian Warner <warner@lothar.com>
516 * docs/buildbot.texinfo (Requirements): update requirements to
517 stop claiming compatibility with python-2.2 or twisted-1.3.x .
519 * README: mention python-2.5 and twisted-2.5 compatibility
521 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
523 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
525 * buildbot/status/builder.py: same, by requiring cStringIO
526 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
527 * buildbot/test/test_vc.py: same
528 * buildbot/test/test_web.py:
529 * buildbot/test/test_steps.py: same, remove unused import
531 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
534 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
535 see any Builders that don't have Schedulers to drive them
537 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
538 attributes this uses went away
540 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
541 dialog, to allow you to reset the buildmaster and force
542 connect/disconnect. Correctly handle losing the buildmaster
543 connection (by switching the display to the hexnut, at which point
544 you can use the 'Connect' menu item to reconnect).
546 * buildbot/steps/source.py (Source.start): if we're using a patch,
547 add it as a LogFile to the checkout/update step. This will turn
548 into a link on the waterfall page.
550 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
551 option, to take the patch from a pre-made file rather than
552 generating it from the local tree. Thanks to Robert Helmer for the
553 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
554 * buildbot/scripts/runner.py (TryOptions): add --diff,
555 --patchlevel, and --baserev options
556 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
557 as None, meaning HEAD.
558 * buildbot/sourcestamp.py (SourceStamp): update docstring to
559 indicate that baserev=None means HEAD
560 * docs/buildbot.texinfo (try --diff): document it
562 * buildbot/test/test_steps.py (BuildStep): remove use of
563 reactor.iterate(), although the technique I replaced it with is a
564 gross polling hack that must be cleaned up properly some day. This
565 was the last use of reactor.iterate in the entire tree, yay.
567 2007-02-05 Brian Warner <warner@lothar.com>
569 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
570 is one of the three known values, otherwise we emit some confusing
571 messages later on. Thanks to Grig Gheorghiu for the catch.
573 2007-01-30 Brian Warner <warner@lothar.com>
575 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
576 Hearsum contributed a patch to let BonsaiPoller work with results
577 that contain non-ascii characters. Closes SF#1632641.
579 2007-01-27 Brian Warner <warner@lothar.com>
581 * Makefile (release): produce both .tar.gz and .zip source bundles.
584 2007-01-23 Brian Warner <warner@lothar.com>
586 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
587 * buildbot/changes/monotone.py: same
589 * buildbot/changes/maildir.py: combine several files into one,
590 clean up maildir.py to use Services properly.
591 * buildbot/changes/maildirtwisted.py: remove
592 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
594 * buildbot/changes/mail.py: match the change
595 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
596 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
598 * buildbot/slave/commands.py (command_version): bump to "2.3" to
599 indicate that the buildslave knows about the 'bzr' command
601 2007-01-22 Brian Warner <warner@lothar.com>
603 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
604 'with', it will become a reserved work in python2.6 .
606 * contrib/bb_applet.py: add a simple gnome-panel applet, to
607 display a terse summary of buildbot status.
608 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
609 some icons, small versions of the Blender object that lives in
610 docs/images/icon.blend
612 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
613 * buildbot/slave/commands.py (Bzr): same
614 * buildbot/scripts/tryclient.py (BzrExtractor): same
615 (SourceStampExtractor.dovc): modify this to allow non-zero exit
616 status, since 'bzr diff' does that
617 * buildbot/test/test_vc.py (Bzr): same
618 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
622 2007-01-20 Brian Warner <warner@lothar.com>
624 * contrib/darcs_buildbot.py: tidy up the progress messages
626 2007-01-17 Brian Warner <warner@lothar.com>
628 * contrib/darcs_buildbot.py: enhance to handle multiple patches
629 being pushed at a time. This keeps state in the repository in a
630 small file named .darcs_buildbot-lastchange, but that shouldn't
631 interfere with normal repository operations. Fixes SF#1534049.
632 * buildbot/clients/sendchange.py (Sender): make a single Sender
633 capable of sending Changes with different usernames.
635 2006-12-11 Brian Warner <warner@lothar.com>
637 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
638 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
639 buildbot.changes.mail a long time ago, but I forgot to add the
640 DeprecationWarning until now.
642 * buildbot/process/maxq.py: remove this, the functionality now
643 lives in buildbot.steps.maxq
645 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
646 * buildbot/clients/gtkPanes.py: remove unused import
648 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
649 that was meant to provide a special Reporter to run inside trial
650 and give the buildslave lots of machine-readable status. We never
651 finished this project.
653 * buildbot/changes/bonsaipoller.py: remove unused imports
654 * buildbot/changes/svnpoller.py: same
655 * buildbot/process/builder.py: same
656 * buildbot/process/buildstep.py: same
657 * buildbot/slave/bot.py: hush pyflakes warning
658 * buildbot/status/tests.py: remove unused imports
659 * buildbot/status/tinderbox.py: same
660 * buildbot/steps/python_twisted.py: same
662 * buildbot/process/step.py: remove this file, these names were
663 deprecated in 0.7.5 and are now being removed.
664 * buildbot/process/step_twisted.py: same
665 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
667 * buildbot/twcompat.py: remove the empty file, yay it is gone
669 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
670 tw-2.0.0 and newer have the method we need.
671 (getProcessOutputAndValue): same
672 (which): remove this method, tw-2.0.0 t.p.procutils has it
674 * buildbot/twcompat.py (implements): remove this method
675 * buildbot/*: import implements() from zope.interface directly
677 * buildbot/status/mail.py: stop falling back to importing
678 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
681 * buildbot/twcompat.py (Interface): remove this import
682 * buildbot/*: import Interface from zope.interface directly
684 * buildbot/twcompat.py (providedBy): remove this method
685 * buildbot/*: turn all uses of providedBy(obj, iface) into
686 iface.providedBy(obj)
688 * buildbot/twcompat.py (maybeWait): remove this method, now that
689 we no longer maintain compatibility with Twisted<=1.3.0 .
690 Twisted-2.0.0 and later allow trial methods to return Deferreds
692 * buildbot/test/*: remove all uses of maybeWait
694 * buildbot/__init__.py (version): bump to 0.7.5+ while between
696 * docs/buildbot.texinfo: same
698 2006-12-10 Brian Warner <warner@lothar.com>
700 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
701 * docs/buildbot.texinfo: set version to match
703 2006-12-10 Brian Warner <warner@lothar.com>
705 * README (REQUIREMENTS): update for release
706 * NEWS: update for release
707 * buildbot/slave/commands.py (command_version): mention that this
708 version (2.2) was released with buildbot-0.7.5
710 * buildbot/test/test_config.py (StartService.testStartService):
711 inhibit the usual read-config-on-startup behavior, since otherwise
712 the log.err that gets recorded causes the test to fail
714 * buildbot/status/builder.py (LogFile.finish): forget about all
715 subscribers once the log has finished, since after that point
716 we're never going to use them again. This might help free up some
719 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
720 than the old/deprecated gtk.mainquit()
722 2006-12-09 Brian Warner <warner@lothar.com>
724 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
725 better when we can't open the masterdst file
727 * buildbot/scripts/startup.py (Follower._failure): add missing
728 import statement for BuildSlaveDetectedError
730 * buildbot/steps/transfer.py (FileUpload): cleanup
731 (FileDownload): same. Add tests for slave version, add mode=.
732 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
733 (SlaveFileDownloadCommand): same
734 * buildbot/test/test_transfer.py: enhance tests
735 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
738 2006-12-08 Brian Warner <warner@lothar.com>
740 * buildbot/scripts/runner.py (sendchange): halt the reactor on
741 both success *and* failure. Without this, the 'buildbot
742 sendchange' command would hang if it could not contact the
743 buildmaster or deliver the Change, which would generally cause the
744 user's commit/record/checkin command to hang too. Thanks to
745 Christian Unger for the catch.
747 2006-12-06 Brian Warner <warner@lothar.com>
749 * NEWS: update with items for the next release
751 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
752 whimsical example pulled from a punch-drunk email I sent out late
754 (Transferring Files): document some of the other parameters
755 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
756 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
757 * buildbot/test/test_svnpoller.py: same
758 * buildbot/changes/svnpoller.py (SVNPoller): same
760 2006-11-26 Brian Warner <warner@lothar.com>
762 * docs/buildbot.texinfo (Build Properties): remind users that
763 WithProperties must appear in a command= list, not as a top-level
765 * buildbot/steps/shell.py (ShellCommand.start): and assert that
766 we're sending a list or a single string to the RemoteShellCommand
768 * buildbot/scheduler.py (Nightly): Improve docs slightly.
770 * buildbot/scripts/startup.py (start): skip the whole
771 watch-the-logfile thing under windows, since it needs os.fork()
773 * buildbot/scripts/runner.py (restart): remove the old message
774 that got printed after the buildbot was restarted.. it most cases
775 it didn't get printed at the right time anyways
777 2006-11-25 Brian Warner <warner@lothar.com>
779 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
780 follow twistd.log and print lines until the process has started
781 started properly. For the buildmaster, this means until the config
782 file has been parsed and accepted. For the buildslave, this means
783 until we've connected to the master. We give up after 5 seconds in
784 any case. Helpful error messages and troubleshooting suggestions
785 are printed when we don't see a successful startup. This closes the
786 remainder of SF#1517975.
787 * buildbot/scripts/startup.py: moved app startup code to here
788 * buildbot/scripts/logwatcher.py: utility class to follow log
789 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
790 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
791 so the LogWatcher can tell the difference between a buildmaster
794 2006-11-24 Brian Warner <warner@lothar.com>
796 * docs/examples/twisted_master.cfg: update to match the version
797 in use on twistedmatrix.com
798 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
799 was using before stopped working, but 'irc.freenode.net' works
802 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
805 * buildbot/clients/base.py (TextClient.not_connected): upon
806 UnauthorizedLogin failures, remind the user to connect to the
807 PBListener port instead of the slaveport.
808 (TextClient.disconnected): shut down more quietly
809 * docs/buildbot.texinfo (statuslog): add another reminder
811 * buildbot/scripts/runner.py (Options.subCommands): rename
812 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
813 'sighup' as an alias.
814 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
815 reconfig command to follow twistd.log and print all of the lines
816 from the start of the config-file reload to its completion. This
817 should make it a lot easier to discover bugs in the config file.
818 Use --quiet to disable this behavior. This addresses half of
819 SF#1517975, the other half will be to add this same utility to
820 'buildbot start' and 'buildbot restart'.
821 * docs/buildbot.texinfo (Loading the Config File): same
824 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
825 method, it has been deprecated for a long time. Use
826 IBuilderControl.requestBuild instead.
827 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
828 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
829 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
830 * buildbot/test/test_control.py (Force.testForce): same
831 * buildbot/test/test_run.py: use requestBuild instead
833 * buildbot/clients/debug.py: replace 'Force Build' button with
834 'Request Build' (which just adds one to the queue), add Ping
835 Builder, add branch/revision fields to Request Build.
836 * buildbot/clients/debug.glade: same
837 * buildbot/master.py: update interface to match. This creates an
838 incompatibility between new debugclients and old buildmasters.
840 * buildbot/process/builder.py (Builder._attached): delay the call
841 to maybeStartBuild for a reactor turn, to avoid starting a build
842 in the middle of a reconfig (say, if the new Builder uses a new
843 slave which is already connected).
845 2006-11-23 Brian Warner <warner@lothar.com>
847 * buildbot/test/test_transfer.py: appease pyflakes
848 * buildbot/test/test_steps.py: same
850 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
851 keeps pyflakes from finding undefined names
853 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
854 Builder no longer induces a disconnect/reconnect cycle. This means
855 that any builds currently in progress will not be interrupted, and
856 any builds which are queued in the Builder will not be lost. This
857 is implemented by having the new Builder extract the state (i.e.
858 all pending Builds and any desired SlaveBuilders) from the old
860 (BotPerspective): refactor. The BotPerspective no longer keeps
861 track of all the Builders that want to use this slave; instead, it
862 asks the BotMaster each time it needs this list. This removes
863 addBuilder and removeBuilder. Clean up attached() to acquire all
864 the slave's information in a more atomic fashion. updateSlave() is
865 now the way to make sure the slave is using the right set of
866 Builders: just call it after everything else has been
868 (BotMaster): refactor, removing addBuilder/removeBuilder and
869 replacing them with an all-at-once setBuilders() call.
871 * buildbot/test/test_slaves.py (Reconfig): new test case to
872 exercise this functionality
873 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
874 * buildbot/slave/commands.py (WaitCommand): same
876 * docs/buildbot.texinfo (Loading the Config File): document the
879 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
880 SlaveBuilder to have its parent Builder changed.
881 (SlaveBuilder.isAvailable): new method to give access to state,
882 which is now a private attribute
883 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
884 the SlaveBuilder about how it is being used. These methods update
885 its internal state. buildFinished() is now the place that invokes
886 maybeStartBuild() on its parent Builder.
887 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
888 new Builder to take over for an old one, transferring state from
890 (Buider): refactor the way that SlaveBuilders are used to match,
891 giving them a bit more autonomy.
892 (Builder.buildFinished): this no longer calls maybeStartBuild():
893 instead the SlaveBuilder calls it on whoever its parent Builder is
894 at the time. This way, when an old Builder is replaced by a new
895 one, and there was a build in progress during the transition, when
896 that build finishes, it will be the new Builder that is told about
897 the newly available slave so it can start a new build.
899 * buildbot/process/base.py (Build.startBuild._release_slave): when
900 the Build finishes, tell the SlaveBuilder that they've been
903 * buildbot/status/builder.py (SlaveStatus): add some new setter
904 methods for use by BotPerspective, to keep some attributes more
907 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
908 called by the buildmaster.
909 (Bot.setBuilderList): instead, we locally announce any leftover
910 directories based upon which Builders we were told about. The
911 master doesn't really care; it's the local admin who may or may not
915 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
916 to allow use of python2.4 or whatever. This tool still requires
919 2006-11-19 Brian Warner <warner@lothar.com>
921 * NEWS (IStatusLog.readlines): more news items
923 2006-11-18 Brian Warner <warner@lothar.com>
925 * NEWS: start collecting items for the next release.
927 2006-11-04 Brian Warner <warner@lothar.com>
929 * buildbot/changes/bonsaipoller.py: apply updates from Ben
930 Hearsum. Closes SF#1590310.
931 * buildbot/test/test_bonsaipoller.py: and tests
933 * buildbot/status/tinderbox.py
934 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
935 status when the build results in WARNINGS. Patch from Dave
936 Liebreich. Closes SF#1587352.
938 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
939 linux-vs-osx behavior difference w.r.t. reading from files that
940 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
941 to Mark Rowe for the patch.
943 2006-10-15 Brian Warner <warner@lothar.com>
945 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
946 method name was misspelled in the interface definition. Thanks to
947 Roy Rapoport for the catch.
949 2006-10-13 Brian Warner <warner@lothar.com>
951 * docs/buildbot.texinfo (Adding LogObservers): update sample code
952 to match the great Steps renaming
954 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
955 Maybe I should run my own unit tests before recording a big
956 change. Good thing I've got a buildbot to remind me.
958 2006-10-12 Brian Warner <warner@lothar.com>
960 * buildbot/steps/transfer.py: rework __init__ and args setup
961 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
963 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
964 when opening the target file, only catch IOError (to report via
965 stderr/rc!=0), let the others be reported as normal exceptions
967 2006-10-08 Brian Warner <warner@lothar.com>
969 * contrib/svn_watcher.py: fix security holes by using proper argv
970 arrays and subprocess.Popen() rather than commands.getoutput().
971 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
972 is deprecated in favor of buildbot/changes/svnpoller.py, and will
973 probably be removed by the next release.
976 2006-10-04 Brian Warner <warner@lothar.com>
978 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
979 initial lines that weren't emitted by pyflakes. When the pyflakes
980 command is run under a Makefile, 'make' will echo the command it
981 runs to stdio, and that was getting logged as a "misc" warning.
982 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
983 * buildbot/test/test_steps.py (testPyFlakes3): another test
985 2006-10-01 Brian Warner <warner@lothar.com>
987 * buildbot/status/html.py (HtmlResource.render): if we get a
988 unicode object from our content() method, encode it into utf-8
989 like we've been claiming to all along. This allows the comments
990 and author names from svnpoller.py to be delivered properly.
992 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
993 de-unicodify filenames before creating the Change, because the
994 rest of buildbot is unlikely to handle them well. Leave the 'who'
995 field as a unicode object.. I don't think there's anything that
996 will break very soon, and it will probably nudge us towards
997 accepting unicode everywhere sooner or later. Stop using the
998 "date" field that comes out of SVN, since it is using the
999 repository's clock (and timezone) and what we care about is the
1000 buildmaster's (otherwise Changes from the future show up later
1001 than the builds they triggered).
1002 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1005 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1006 Suvbersion repository polling ChangeSource. I've hacked it up
1007 considerably: any bugs are entirely my own fault. Thank you
1009 * buildbot/test/test_svnpoller.py: tests for it
1010 * docs/buildbot.texinfo (SvnSource): document it
1012 2006-09-30 Brian Warner <warner@lothar.com>
1014 * buildbot/scheduler.py (Periodic): submit a reason= to the
1015 BuildSet to indicate which Scheduler triggered the build. Thanks
1016 to Mateusz Loskot for the suggestion.
1018 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1020 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1021 changes: set self.loop in __init__, remove unused volatile=
1023 * docs/buildbot.texinfo (.buildbot config directory): add more
1024 docs on the .buildbot/options keys used by "buildbot try"
1025 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1026 (Try.deliverJob): same
1028 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1030 (BonsaiPoller): same
1032 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1033 close the filehandle when we stop watching the file. Before, the
1034 filehandle was only closed when the LogFileWatcher was
1035 garbage-collected, which could be quite a while in the future. If
1036 it was still open by the time the next build started, windows will
1037 refuse to let the new build delete the old build/ directory. Fixes
1038 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1039 #twisted for the catch.
1041 2006-09-29 Brian Warner <warner@lothar.com>
1043 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1046 2006-09-25 Brian Warner <warner@lothar.com>
1048 * setup.py: the new buildbot.steps module wasn't being installed.
1049 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1050 (testmsgs): add the extra stuff from buildbot/test/* so you can
1051 run unit tests on an installed copy of buildbot, not just from
1054 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1055 columns of 'svnlook changed' output contain status information, so
1056 strip [:4] instead of [:6]. Depending upon what the status flags
1057 were, this would sometimes lead to mangled filenames. Thanks to
1058 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1060 * buildbot/steps/source.py (Monotone): initial Monotone support,
1061 contributed by Nathaniel Smith. Still needs docs and tests, but
1062 this code has been in use on the Monotone buildbot for a long
1064 * buildbot/slave/commands.py (Monotone): slave-side support
1065 * buildbot/changes/monotone.py (MonotoneSource): polling change
1068 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1069 contributed a Change Source that polls a Bonsai server (a
1070 kind of web-based viewcvs CGI script).
1072 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1073 Hearsum contributed a status plugin which sends email in the same
1074 format that Tinderbox does: this allows a number of tinderbox
1075 tools to be driven by Buildbot instead. Thanks Ben!
1077 2006-09-24 Brian Warner <warner@lothar.com>
1079 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1080 Thanks to Robert Helmer for the patch.
1082 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1083 BuildStatus about the buildslave name at the *beginning* of the
1084 build, rather than at the end. Thanks to Alexander Lorenz for the
1086 * buildbot/status/html.py (StatusResourceBuild.body): always
1087 include the slavename in the build page, not just when the build
1089 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1090 slavename in the email message
1092 2006-09-21 Brian Warner <warner@lothar.com>
1094 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1096 * docs/examples/glib_master.cfg: same
1097 * docs/examples/hello.cfg: same
1098 * docs/examples/twisted_master.cfg: same, update to current usage
1100 2006-09-19 Brian Warner <warner@lothar.com>
1102 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1103 (PyFlakes.createSummary): make it compatible with python-2.2
1105 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1106 for at least the output-parsing parts of PyFlakes
1108 2006-09-18 Brian Warner <warner@lothar.com>
1110 * buildbot/steps/python.py: oops, fix import of StringIO
1112 2006-09-17 Brian Warner <warner@lothar.com>
1114 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1115 turns out that SVN-1.4.0 doesn't fail to update once you've
1116 replaced a file with a directory, unlike older versions of SVN and
1117 pretty much every other VC tool we support. Since what we really
1118 care about is that the update succeeds anyway, stop checking that
1119 the tree got clobbered and just assert that the build succeeded.
1120 (VCBase.printLogs): add a utility function for debugging
1122 * buildbot/process/step.py: oops, added extra imports by mistake
1124 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1125 rstrip() on the first line coming out of the 'p4 describe'
1126 process, to remove the stray ^M that Wade Brainerd reports seeing
1127 in the 'when' field. Fixes SF#1555985.
1129 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1130 message logged when c['schedulers'] is not right
1131 * buildbot/scheduler.py (Scheduler.__init__): improve error
1132 message when a Scheduler() is created with the wrong arguments
1133 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1134 verify that these error messages are emitted
1136 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1137 The idea is that all the base classes (like BuildStep and
1138 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1139 will be a leftover backwards-compatibility file that only contains
1140 aliases for the steps that were moved out to buildbot.steps.*
1141 * lots: change imports to match
1142 * buildbot/process/step.py: add a DeprecationWarning if it ever
1145 2006-09-12 Brian Warner <warner@lothar.com>
1147 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1148 builderNames= is actually a sequence, since if you happen to give
1149 it a single builder-specification dictionary instead, it won't get
1150 caught by the existing assert. Thanks to Brett Neely for the
1153 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1155 * docs/buildbot.texinfo (Python BuildSteps): document them
1156 (sendchange): include a link to PBChangeSource, since you need one
1158 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1160 * buildbot/steps/dummy.py: same
1162 2006-09-08 Brian Warner <warner@lothar.com>
1164 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1165 BuildStep which lets you transfer files from the master to the
1166 slave or vice versa. Thanks to Albert Hofkamp for the original
1167 patch. Fixes SF#1504631.
1168 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1170 (SlaveFileDownloadCommand): same
1171 * docs/buildbot.texinfo (Transferring Files): document it
1172 * buildbot/test/test_transfer.py: test it
1173 * buildbot/test/runutils.py (StepTester): new utility class for
1174 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1175 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1178 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1179 walk through StatusLogs one line at a time, mostly for the benefit
1180 of ShellCommand.createSummary methods. You can either walk through
1181 STDOUT or STDERR, but the default is STDOUT.
1183 * buildbot/status/builder.py (LogFile.readlines): implement it.
1184 Note that this is not yet memory-efficient, it just pulls the
1185 whole file into RAM and then splits it up with a StringIO.
1186 Eventually this should be a generator that only pulls chunks from
1188 * buildbot/test/test_status.py (Log.testReadlines): test it
1190 * docs/buildbot.texinfo: update to match changes
1191 * buildbot/process/factory.py: stop using old definitions
1192 * buildbot/process/process_twisted.py: same
1193 * buildbot/test/test_*.py: same
1195 * buildbot/process/step_twisted.py: move definition to..
1196 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1197 relative-import mechanisms prevent this from being named 'twisted'
1198 or 'python/twisted' as I would have preferred.
1200 * buildbot/process/maxq.py: move definition to..
1201 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1203 * buildbot/process/step.py: split the user-visible BuildSteps into
1204 separate files, all under buildbot/steps/
1205 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1206 * buildbot/steps/shell.py: this holds ShellCommand and friends
1207 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1209 2006-09-05 Brian Warner <warner@lothar.com>
1211 * lots: run pyflakes, removed a lot of unused imports, changed the
1212 form of some conditional imports to remove false pyflakes
1213 warnings. There are still a number of warnings left, mostly from
1214 imports that are done for their side-effects.
1215 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1218 2006-08-26 Brian Warner <warner@lothar.com>
1220 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1221 compatible with twisted-1.3.0, for some reason I just can't seem
1222 to let go of the past.
1224 2006-08-25 Brian Warner <warner@lothar.com>
1226 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1228 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1229 all logfiles= in startCommand(), rather than in start() . This
1230 makes it easier to have the 'stdio' log come before any secondary
1231 logfiles, which I feel makes the waterfall display more
1233 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1234 from ShellCommand up into LoggingBuildStep
1235 (LoggingBuildStep.__init__): move the handling of logfiles= from
1236 ShellCommand up to LoggingBuildStep, because startCommand is
1237 provided by LoggingBuildStep, whereas start() was specific to
1238 subclasses like ShellCommand and Source. This removes code
1239 duplication in those subclasses.
1240 (ShellCommand.__init__): same
1241 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1242 for a slave that's too old to understand logfiles= into a separate
1243 method, so it can live in ShellCommand. The rest of
1244 setupLogfiles() can live in LoggingBuildStep.
1246 2006-08-24 Brian Warner <warner@lothar.com>
1248 * buildbot/locks.py (BaseLock): you can now configure Locks to
1249 allow multiple simultaneous owners. They still default to
1250 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1252 * docs/buildbot.texinfo (Interlocks): document the new options
1253 * buildbot/test/test_locks.py: add a bunch of new unit tests
1254 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1255 waitUntilMaybeAvailable, not waitUntilAvailable
1256 * buildbot/process/step.py (BuildStep.acquireLocks): same
1257 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1258 the whole lockid in their constructor, not just the name. Also,
1259 keep track of which real locks we've handed out by the full
1260 lockid, not just class+name, otherwise changing just the maxCount=
1261 in the master.cfg file would not actually cause a behavioral
1264 2006-08-23 Brian Warner <warner@lothar.com>
1266 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1268 * docs/buildbot.texinfo: same
1270 2006-08-23 Brian Warner <warner@lothar.com>
1272 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1273 * docs/buildbot.texinfo: set version to match
1274 * NEWS: update for 0.7.4
1275 * buildbot/slave/commands.py (command_version): mention that this
1276 version (2.1) was released with buildbot-0.7.4
1278 2006-08-22 Brian Warner <warner@lothar.com>
1282 * CREDITS: new file, list of people who have helped. Thanks!
1283 * MANIFEST.in: ship it
1285 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1286 new diagrams, the user's manual is more informative than it was.
1287 Start shipping the .html user's manual (and generated .png
1289 * Makefile: update 'release' target to match
1291 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1292 test.. I think the web-parts effort will render it pointless well
1293 before it ever actually starts to work.
1295 2006-08-20 Brian Warner <warner@lothar.com>
1297 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1298 meaning of the prefix= argument. It is now just a string which is
1299 stripped from the beginning of the filename. If prefix= is set but
1300 not found on any given filename, that filename is ignored. If all
1301 filenames in a Change are ignored, the Change is dropped. This is
1302 much simpler than the previous sep= nonsense, and I should have
1303 implemented it this way from the beginning. Effectively resolves
1304 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1305 Gedminas for the catch and suggested fixes.
1306 (ChangePerspective.perspective_addChange): implement the actual
1308 * buildbot/test/test_changes.py (TestChangePerspective): test it
1309 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1310 how to properly use prefix=
1311 * docs/examples/twisted_master.cfg (source): update prefix= by
1312 adding the trailing slash
1315 * docs/examples/twisted_master.cfg: update to actual practice
1317 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1318 update test case to match new link text.. the HREF has both a
1319 class= setting and an enclosing [] pair that I didn't match in the
1322 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1323 list of strings is preferred over a single string with embedded
1325 (ShellCommand.description=): explain that either single strings or
1326 a list of strings is acceptable, and why you might prefer one over
1327 the other. Add an example. Fixes SF#1524659, thanks to Paul
1328 Winkler for the catch.
1329 (Build Steps): update to use f.addStep() rather than using s()
1330 and the constructor list
1332 * buildbot/process/step.py (ShellCommand): accept either a single
1333 string or a list of strings in both description= and
1335 * buildbot/test/test_steps.py (Steps.test_description): test it
1336 * buildbot/test/runutils.py (makeBuildStep): support for that test
1338 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1339 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1340 collecting the files and creating the patch.
1342 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1343 per-step URLs that will be displayed on the waterfall display,
1344 for things like the HTML output of code-coverage tools, when
1345 the results are hosted elsewhere.
1346 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1347 way to retrieve these URLs
1348 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1349 the method to retrieve these URLs. Also provide backwards
1350 compatibility for saved BuildStepStatus instances that didn't have
1352 * buildbot/process/step.py (BuildStep.addURL): method to set these
1353 URLs from within a BuildStep
1354 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1355 (StepBox.getBox): give these external links a distinct CSS class
1356 named "BuildStep external" so a .css file can display them
1359 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1361 * buildbot/test/test_steps.py (Steps): test that we can all the
1362 URLs. Also add a bunch of other tests on methods that can be
1363 called from within BuildSteps
1364 * buildbot/test/runutils.py (makeBuildStep): add utility function
1366 2006-08-13 Brian Warner <warner@lothar.com>
1368 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1370 2006-08-10 Brian Warner <warner@lothar.com>
1372 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1373 index, this one of things like c['sources'] and c['schedulers']
1374 (indices): it looks like my clever idea of putting the @fooindex
1375 commands in between the @node and the @subsection (to make the
1376 HREF anchor jump to slightly above the section title, which works
1377 much better in html) confused texinfo horribly, so I'm moving the
1378 index tags back to be just after the @subsection marker. I also
1379 added extra lines between the @node/@section paragraph and the
1380 index tags, since I think maybe texinfo wants to see these be
1381 separate paragraphs.
1383 * docs/Makefile (images): make sure images get built when
1384 rendering the manual
1385 * docs/images/Makefile: same
1387 * buildbot/scripts/runner.py: rename 'buildbot master' to
1388 'buildbot create-master', and 'buildbot slave' to 'buildbot
1390 * docs/buildbot.texinfo: same
1393 * docs/buildbot.texinfo: reimplement the "useful classes" index
1394 with actual texinfo indices. The .info rendering is a bit
1395 weird-looking but it works well, and the HTML rendering is quite
1396 nice. This also puts the index targets in the regular flow of the
1397 text, which is easier to maintain.
1399 2006-08-06 Brian Warner <warner@lothar.com>
1401 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1402 Kevin Turner to prefer the environ= argument be a list rather than
1403 a string. If it is a list, it will be joined with a platform-local
1404 os.pathsep delimiter, and then prepended to any existing
1405 $PYTHONPATH value. This works better in cross-platform (i.e.
1406 windows buildslaves) environments when you need to push multiple
1407 directories onto the front of the path.
1408 (SlaveShellCommand): documented the new magic
1409 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1410 in a user-visible form
1412 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1413 Turner to prefer lists over strings when creating/running VC
1414 commands during unit tests. This is clearly necessary to survive
1415 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1416 renamed the wq() function to qw() though, since that's how it's
1417 spelled in perl. Eventually I'd prefer all commands to be
1418 specified with lists.
1420 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1421 which are deleted (or not yet created) correctly. Also add
1422 failsafe code to not explode if the file-watching poller doesn't
1423 get started. Thanks to JP Calderone for the catch and the poller
1425 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1427 * buildbot/test/emitlogs.py: same
1429 * NEWS: summarize recent changes
1431 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1432 clause to avoid the "host key mismatch" warning
1434 * buildbot/process/step_twisted.py (Trial.start): if the
1435 buildslave is too old to understand logfiles=, fall back to
1436 running 'cat _trial_temp/test.log' like before.
1437 (Trial.commandComplete): same. this takes advantage of the
1438 LoggingBuildStep refactoring to stall commandComplete long enough
1439 to run a second RemoteShellCommand.
1441 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1442 refactor command-completion handling, to allow methods like
1443 commandComplete/createSummary/evaluateCommand to return Deferreds.
1444 (LoggingBuildStep._commandComplete): delete the refactored method
1445 (ShellCommand.setupLogfiles): if the buildslave is too old to
1446 understand logfiles=, put a warning message both into twistd.log
1447 and into the otherwise empty user-visible LogFiles.
1449 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1450 callers to provide the slave-side logfile name, rather than
1451 forcing it to come from the local name of the LogFile.
1452 (BuildStep.getSlaveName): new method
1454 * buildbot/process/base.py (Build.getSlaveName): new method, so
1455 steps can find out which buildslave they're running on
1457 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1458 to match the s/cvs_ver/command_version/ change
1460 2006-08-05 Brian Warner <warner@lothar.com>
1462 * buildbot/slave/commands.py (command_version): replace the CVS
1463 auto-updated cvs_ver keyword with a manually-updated variable,
1464 since CVS is no longer the master repository. Add a description of
1465 the remote API change starting in this version (2.1), specifically
1466 the fact that SlaveShellCommand now accepts 'initial_stdin',
1467 'keep_stdin_open', and 'logfiles'.
1469 2006-07-31 Brian Warner <warner@lothar.com>
1471 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1472 diagrams to describe how the whole system fits together. The
1473 images themselves are kept in SVG files, with ascii-art versions
1474 in corresponding .txt files. Texinfo knows how to interpolate the
1475 text version into .info files, reference the .png versions from
1476 .html files, and include .eps versions in the .ps format.
1477 * docs/images/Makefile: tools to create .png and .eps
1478 * docs/images/*.svg: created pictures with Inkscape.
1479 * .darcs-boring: ignore the generated .eps and .png files
1481 2006-07-24 Brian Warner <warner@lothar.com>
1483 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1484 Scheduler names, since they cause setServiceParent to explode
1486 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1488 2006-07-20 Brian Warner <warner@lothar.com>
1490 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1491 which runs the buildbot unit tests
1493 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1494 classes that are useful in master.cfg
1496 2006-07-15 Brian Warner <warner@lothar.com>
1498 * Makefile (some-apidocs): new target to build only some epydocs
1500 * setup.py: minor comment.. does the classifiers= argument prevent
1501 the setup.py script from working on python2.2/2.3?
1503 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1506 * buildbot/twcompat.py: fix minor typo in comments
1508 * buildbot/manhole.py: move all Manhole-related code out to this
1509 module. Implement SSH-based manholes (with TwistedConch), and move
1510 to conch's nifty line-editing syntax-coloring REPL shell instead
1511 of the boring non-editing monochromatic (and deprecated) old
1513 * buildbot/master.py: remove all Manhole-related code
1514 (BuildMaster.loadConfig._add): make sure the old manhole is
1515 removed before we add the new one
1516 * docs/buildbot.texinfo (Debug options): document new Manhole options
1518 * buildbot/twcompat.py (_which): fix some epydoc issues
1519 * buildbot/status/html.py (Waterfall.__init__): same
1521 2006-06-29 Brian Warner <warner@lothar.com>
1523 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1524 deprecation warnings under newer Twisteds (by using
1525 zope.interface.Interface instead of old twisted.python.components
1527 * buildbot/slave/interfaces.py: same
1529 2006-06-28 Brian Warner <warner@lothar.com>
1531 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1532 svn commands, so it will fail immediately instead of hanging while
1533 it waits for a username/password to be typed in.
1535 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1536 log message if the step was shut down
1538 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1539 obsolete reference to mktap.
1541 2006-06-20 Brian Warner <warner@lothar.com>
1543 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1544 test to include new 'logfiles' argument sent from master to slave
1546 2006-06-19 Brian Warner <warner@lothar.com>
1548 * buildbot/process/step_twisted.py (Trial): track Progress from
1549 _trial_temp/test.log too
1551 * buildbot/process/step.py (OutputProgressObserver): generalize
1552 the earlier StdioProgressObserver into an OutputProgressObserver
1553 that can track LogFiles other than stdio.
1554 (LoggingBuildStep.__init__): same
1556 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1557 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1558 will fail under windows because of os.sep issues. It might have
1559 worked before if 'cat' was doing cygwin path conversion.
1561 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1562 creation of LogFileWatchers
1563 (ShellCommand._startCommand): and record the files that were
1564 watched in the 'headers' section of the ShellCommand output
1566 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1567 need to actually pass it to the slave if you want it to work.
1568 (ShellCommand): document it a bit
1570 * buildbot/test/test_shell.py: new test to validate LogFiles
1571 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1573 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1574 before printing the last batch of lines, to test that the polling
1575 logic is working properly
1577 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1578 handling, making it possible to track multiple logs for a single
1579 RemoteCommand. The previous single logfile is now known as the
1581 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1582 (RemoteShellCommand.__init__): accept logfiles=
1583 (LoggingBuildStep.startCommand): stdio_log is now one of many
1584 (ShellCommand): added logfiles= argument, as well as a class-level
1585 .logfiles attribute, which will be merged together to figure out
1586 which logfiles should be tracked. The latter maybe be useful for
1587 subclasses of ShellCommand which know they will aways produce
1588 secondary logfiles in the same location.
1590 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1591 and closeStdin() methods, preparing to make it possible to write
1592 to a ShellCommand's stdin at any time, not just at startup. These
1593 writes are buffered if the child process hasn't started yet.
1594 (LogFileWatcher): new helper class to watch arbitrary logfiles
1595 while a ShellCommand runs. This class polls the file every two
1596 seconds, and sends back 10k chunks to the buildmaster.
1597 (ShellCommand): rename stdin= to initialStdin=, and add
1598 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1600 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1601 key of "log" and a value of (logname, data).
1602 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1603 'logfiles' to the master-visible args dictionary.
1604 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1607 * buildbot/test/test_vc.py (Patch.testPatch): same
1610 * buildbot/test/emit.py: write to a logfile in the current
1611 directory. We use this to figure out what was used as a basedir
1612 rather than looking to see which copy of emit.py gets run, so that
1613 we can run the commands from inside _trial_temp rather than inside
1615 * buildbot/test/subdir/emit.py: same
1616 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1617 argument rather than running from buildbot/test/
1618 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1619 rather than using an implicit setUp()
1620 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1621 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1622 of assuming that we're running in buildbot/test/ (and that '.' is
1625 * buildbot/slave/commands.py (Command.doStart): refactor Command
1626 startup/completion a bit: now the SlaveBuilder calls doStart(),
1627 which is not meant for overridding by subclasses, and doStart()
1628 calls start(), which is. Likewise the SlaveBuilder calls
1629 doInterrupt(), and subclasses override interrupt(). This also puts
1630 responsibility for maintaining .running in Command rather than in
1632 (Command.doInterrupt): same
1633 (Command.commandComplete): same, this is called when the deferred
1634 returned by start() completes.
1635 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1636 (SlaveBuilder.remote_interruptCommand): same
1637 (SlaveBuilder.stopCommand): same
1639 2006-06-16 Brian Warner <warner@lothar.com>
1641 * buildbot/test/test_shell.py: new test file to contain everything
1642 relating to ShellCommand
1643 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1644 multiple logfiles in realtime" feature, not yet implemented
1645 * buildbot/test/emitlogs.py: support file for testLogFiles
1646 * docs/buildbot.texinfo (ShellCommand): document the feature
1648 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1650 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1651 for tests which exercise SlaveCommands in isolation.
1653 * buildbot/test/test_slavecommand.py: Move some utilities like
1654 SignalMixin and FakeSlaveBuilder from here ..
1655 * buildbot/test/runutils.py: .. to here, so they can be used by
1656 other test classes too
1657 * buildbot/test/test_vc.py: more SignalMixin refactoring
1658 * buildbot/test/test_control.py: same
1659 * buildbot/test/test_run.py: and some rmtree refactoring
1661 2006-06-15 Brian Warner <warner@lothar.com>
1663 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1664 'testBranch' to match other VC tests and have the tests run in
1665 roughly increasing order of dependency
1667 * buildbot/test/test_steps.py (LogObserver): new test to verify
1668 LogObservers can be created at various times and still get
1669 connected up properly
1671 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1672 to create BuildStepStatus instances that actually work.
1674 * buildbot/process/step.py (LogObserver): add outReceived and
1675 errReceived base methods, to be overridden
1677 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1678 API to take a name instead of a step, reducing the coupling
1679 somewhat. This returns the BuildStepStatus object so it can be
1680 passed to the new Step, instead of jamming it directly into the
1682 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1684 * buildbot/process/base.py (Build.setupBuild): use both methods
1685 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1686 process a bit to match
1688 2006-06-14 Brian Warner <warner@lothar.com>
1690 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1691 docs on writing new LogObserver classes
1692 (Writing New Status Plugins): brief docs on how Status Plugins fit
1695 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1696 implement a LogObserver that counts how many unit tests have been
1698 (Trial.__init__): wire it in
1699 * buildbot/test/test_twisted.py (Counter): unit test for it
1701 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1702 to new cmd.logs['stdio'] scheme
1703 (Trial.commandComplete): same
1704 (BuildDebs.commandComplete): same
1706 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1707 LogFiles, instead of just a single one. The old single logfile is
1708 now called "stdio". LoggedRemoteCommand no longer creates a
1709 LogFile for you (the code to do that was broken anyway). If you
1710 don't create a "stdio" LogFile, then stdout/stderr will be
1712 (LogObserver): implement "LogObservers", which a BuildStep can add
1713 to parse the output of a command in real-time. The primary use is
1714 to provide more useful information to the Progress code, allowing
1715 better ETA estimates.
1716 (LogLineObserver): utility subclass which feeds complete lines to
1717 the parser instead of bytes.
1718 (BuildStep.progressMetrics): this is safer as a tuple
1719 (BuildStep.setProgress): utility method, meant to be called by
1721 (BuildStep.addLogObserver): new method, to be called at any time
1722 during the BuildStep (even before any LogFiles have been created),
1723 to attach (or schedule for eventual attachment) a LogObserver to a
1725 (StdioProgressObserver): new LogObserver which replaces the old
1726 "output" progress gatherer
1727 (LoggingBuildStep.__init__): same
1728 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1729 (LoggingBuildStep._commandComplete): must use logs['stdio']
1730 instead of the old single ".log" attribute.
1731 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1732 functionality, now subsumed into StdioProgressObserver
1733 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1734 log name changed from "output" to "stdio".
1737 * buildbot/interfaces.py (ILogFile): add the Interface used from
1738 the BuildStep towards the LogFile
1739 (ILogObserver): and the one provided by a LogObserver
1740 * buildbot/status/builder.py (LogFile): implement it
1742 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1743 HEADER constants here ..
1744 * buildbot/status/builder.py (STDOUT): .. from here
1746 2006-06-13 Brian Warner <warner@lothar.com>
1748 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1749 compatibility with python2.2, which doesn't have the 'substr in
1751 (TestP4Poller.makeTime): utility function to construct the
1752 timestamp using the same strptime() approach as p4poller does. It
1753 turns out that time.mktime() behaves slightly differently under
1754 python2.2, probably something to do with the DST flag, and that
1755 causes the test to fail under python2.2. (changing the mktime()
1756 arguments to have dst=0 instead of -1 caused it to fail under
1757 python2.3. Go figure.)
1758 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1760 2006-06-12 Brian Warner <warner@lothar.com>
1762 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1763 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1764 contributing such an excellent patch, including docs and unit
1765 tests! This makes it *so* much easier to apply. I had to update
1766 test_vc.py to handle some recent refactorings, but everything else
1767 applied smoothly. The only remaining thing I'd like to fix would
1768 be to remove the hard-wired port 1666 used by p4d, and allow it to
1769 claim any unused port. This would allow two copies of the test
1770 suite to run on the same host at the same time, as well as
1771 allowing the test suite to run while a real (production) p4d was
1772 running on the same host. Oh, and maybe we should add a warning to
1773 step.P4 that gets emitted if the slave is too old to provide the
1774 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1775 * buildbot/slave/commands.py (P4): same
1776 (P4Sync): same, some minor updates
1777 * buildbot/changes/p4poller.py: same
1778 * docs/buildbot.texinfo: same
1779 * buildbot/test/test_p4poller.py: same
1780 * buildbot/test/test_vc.py (P4): same
1782 * setup.py: add Trove classifiers for PyPI
1784 2006-06-08 Brian Warner <warner@allmydata.com>
1786 * buildbot/status/client.py
1787 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1788 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1789 build needs to be IRemote'd separately, rather than IRemote'ing
1790 the whole list at once. I can't wait until newpb's serialization
1791 adapters make this unnecessary.
1793 2006-06-06 Brian Warner <warner@lothar.com>
1795 * buildbot/process/step.py (WithProperties): make this inherit
1796 from ComparableMixin, so that reloading an unchanged config file
1797 doesn't cause us to spuriously reload any Builders which use them.
1798 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1801 2006-06-03 Brian Warner <warner@lothar.com>
1803 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1804 running py2exe on windows, contributed by Mark Hammond. Addresses
1805 SF#1401121, but I think we still need to include
1806 buildbot/scripts/sample.cfg
1807 * setup.py: include buildbot_service.py as a script under windows
1808 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1809 a py2exe application), get the icon/css datafiles from a different
1812 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1813 double-escape the build URL. Thanks to Olivier Bonnet for the
1814 patch. Fixes SF#1452801.
1816 2006-06-02 Brian Warner <warner@lothar.com>
1818 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1819 first six columns of 'svnlook' output, not just the first column,
1820 since property changes appear in the other five. Thanks to Olivier
1821 Bonnet for the patch. Fixes SF#1398174.
1823 2006-06-01 Brian Warner <warner@lothar.com>
1825 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1826 the fake build, so that title= has something to be set to
1828 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1829 attribute of the "Build #NN" link in the yellow start-the-build
1830 box to the build's reason. This means that you get a little
1831 tooltip explaining why the build was done when you hover over the
1832 yellow box. Thanks to Zandr Milewski for the suggestion.
1834 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1835 (Box.setETA): handle ETA=None (by stopping the timer)
1836 (Box.update): make the [soon] text less different than the usual
1837 text, so the rest of the text doesn't flop around so much. It
1838 would be awfully nice to figure out how to center this stuff.
1839 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1841 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1842 by default, so that any ShellCommand which fails marks the overall
1843 build as a failure. I should have done this from the beginning.
1844 Add flunkOnFailure=False to the arguments if you want to turn off
1847 2006-05-30 Brian Warner <warner@lothar.com>
1849 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1850 last-build/current-build/current-step. Show what step is currently
1851 running. Show ETA for both the overall build and the current step.
1852 Update GTK calls to modern non-deprecated forms. There's still a
1853 lot of dead code and debug noise to remove.
1855 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1856 shows up properly in status displays
1858 2006-05-28 Brian Warner <warner@lothar.com>
1860 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1861 build we use to verify that WithProperties works:
1863 ** set flunkOnFailure=True so that build failures get noticed
1864 ** set workdir='.' so that the build succeeds, otherwise it is trying
1865 to touch 'build/something', and 'build/' doesn't exist because
1866 usually that's created by a Source step
1867 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1868 this test somehow triggers, in which the 'touch' process becomes
1869 a zombie and we wait for th etimeout before giving up on it.
1871 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1872 to log the Build results and step logs to the twisted log.
1873 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1874 what went wrong if a build was expected to succeed but didn't.
1876 * buildbot/process/step_twisted.py (Trial): set the default
1877 trialMode to '--reporter=bwverbose', which specifies verbose
1878 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1879 '-to', but those are completely missing in modern Twisteds.
1881 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1882 a localhost-only port, to encourage better security
1884 * docs/buildbot.texinfo (Change Sources): mention
1887 * .darcs-boring: add a Darcs boringfile
1889 * README (REQUIREMENTS): stop claiming compatibility with
1892 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1895 2006-05-27 Brian Warner <warner@lothar.com>
1897 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1898 * docs/buildbot.texinfo: same
1900 2006-05-23 Brian Warner <warner@lothar.com>
1902 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1903 * docs/buildbot.texinfo: set version to match
1904 * NEWS: update for 0.7.3
1906 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1907 give a quick mapping from VC system to possible ChangeSources
1908 (Build Properties): add 'buildername'
1910 * buildbot/process/base.py (Build.setupStatus): oops, set
1911 'buildername' and 'buildnumber' properties
1912 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1915 2006-05-22 Brian Warner <warner@lothar.com>
1917 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1918 property interpolation better
1920 * README (INSTALLATION): remove old '-v' argument from recommended
1923 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1924 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1927 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1928 'svnversion' instead of grepping the output of 'svn info', much
1929 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1930 Bonnet for the suggestion.
1931 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1932 require the WC_PATH argument, so run 'svnversion .' instead.
1934 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1935 aren't supposed to have 'self' in their argument list
1937 2006-05-21 Brian Warner <warner@lothar.com>
1939 * buildbot/process/step.py (ShellCommand.start): make
1940 testInterpolate pass. I was passing the uninterpolated command to
1941 the RemoteShellCommand constructor
1942 (ShellCommand._interpolateProperties): oops, handle non-list
1943 commands (i.e. strings with multiple words separated by spaces in
1944 them) properly, instead of forgetting about them.
1946 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1947 to actually try to use build properties in a real build. This test
1949 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1950 to start and evaluate builds
1952 * buildbot/test/test__versions.py: add a pseudo-test to record
1953 what version of Twisted/Python/Buildbot are running. This should
1954 show up at the beginning of _trial_tmp/test.log, and exists to help
1955 debug other problems.
1957 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1958 a filename to be served as 'robots.txt' to discourage web spiders.
1959 Adapted from a patch by Tobi Vollebregt, thanks!
1960 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1961 (Waterfall.test_waterfall): tweak the way that filenames are put
1962 into the config file, to accomodate windows pathnames better.
1964 * docs/buildbot.texinfo (HTML Waterfall): document it
1966 * buildbot/process/process_twisted.py
1967 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1968 changed the build process. The new setup.py no longer takes the
1970 (FullTwistedBuildFactory.__init__): same
1971 (TwistedReactorsBuildFactory.__init__): same
1973 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1974 be placed in the [hooks] section of the central repository (the
1975 one that everybody pushes changes to).
1977 2006-05-20 Brian Warner <warner@lothar.com>
1979 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1980 .darcs-context file, use binary mode. I think this was causing a
1981 Darcs failure under windows.
1983 2006-05-19 Brian Warner <warner@lothar.com>
1985 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1986 use a timezone string of +0000 and gmtime, since this timestamp is
1987 sent to a buildmaster and %z is broken.
1989 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1990 string and localtime, since this timestamp will only be consumed
1991 locally, and %z is broken.
1993 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1994 gmtime, since this timestamp is returned to the buildmaster, and
1997 2006-05-18 Brian Warner <warner@lothar.com>
1999 * NEWS: update in preparation for next release
2001 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2002 setup-repository and do-we-have-the-vc-tools code into a separate
2003 "helper" class, which sticks around in a single module-level
2004 object. This seems more likely to continue to work in the future
2005 than having it hide in the TestCase and hope that TestCases stick
2006 around for a long time.
2008 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2009 addremove' has been deprecated in recent versions of mercurial, so
2010 use 'hg add' instead
2012 2006-05-07 Brian Warner <warner@lothar.com>
2014 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2015 operating under windows, move the file before opening it, since
2016 you can't rename a file that somebody has open.
2018 * buildbot/process/base.py (Build.setupBuild): if something goes
2019 wrong while creating a Step, log the name and arguments, since the
2020 error message when you get the number of arguments wrong is really
2023 2006-05-06 Brian Warner <warner@lothar.com>
2025 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2026 bugs in twisted-specific code not covered by my unit tests, this
2027 time use 'cmd' argument instead of self.cmd
2029 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2030 fix stupid braino: either use startwith or find()==0, not both.
2031 (TwistedReactorsBuildFactory.__init__): another dumb typo
2033 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2034 mark this test as TODO under windows, since process-killing seems
2035 dodgy there. We'll come back to this later and try to fix it
2038 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2039 and don't include a timezone
2040 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2041 This should avoid the windows-with-verbose-timezone-name problem
2043 (Patch.testPatch): add a test which runs 'patch' with less
2044 overhead than the full VCBase.do_patch sequence, to try to isolate
2045 a windows test failure. This one uses slave.commands.ShellCommand
2046 and 'patch', but none of the VC code.
2048 * buildbot/slave/commands.py (getCommand): use which() to find the
2049 executables for 'cvs', 'svn', etc. This ought to help under
2052 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2053 working directory before starting. If an earlier test failed, the
2054 leftover directory would mistakenly flunk a later test.
2055 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2056 Make sure that we use the right commandlines if which("tla") picks
2057 up "tla.exe" (as it does under windows).
2058 (TlaSupport.do_get): factor out this tla-vs-baz difference
2059 (TlaSupport.vc_create): more tla-vs-baz differences
2061 * buildbot/test/test_slavecommand.py
2062 (ShellBase.testShellMissingCommand): stop trying to assert
2063 anything about the error message: different shells on different
2064 OSes with different languages makes it hard, and it really isn't
2065 that interesting of a thing to test anyway.
2067 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2068 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2069 "Panther"), because it has a bug which flunks a couple tests in
2070 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2071 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2072 able to test that yet.
2074 2006-04-30 Brian Warner <warner@lothar.com>
2076 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2077 make sure child commands emit messages in english, so our regexps
2078 will match. Thanks to Nikaus Giger for identifying the problems.
2079 (VCBase._do_vctest_export_1): mode="export" is not responsible
2080 for setting the "got_revision" property, since in many cases it is
2081 not convenient to determine.
2082 (SVNSupport.capable): when running 'svn --version' to check for
2083 ra_local, we want error messages in english
2084 * buildbot/test/test_slavecommand.py
2085 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2086 to emit the error message in english
2088 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2089 the environment with $LC_ALL="C" so that Commands which need to
2090 parse the output of their child processes can obtain it in
2092 (SVN.parseGotRevision): call "svn info" afterwards instead of
2093 watching the output of the "svn update" or "svn checkout".
2094 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2095 (Arch.parseGotRevision): same
2096 (Bazaar.parseGotRevision): same
2097 (Mercurial.parseGotRevision): same
2099 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2100 $LC_ALL="C" when running commands under 'buildbot try', too
2102 * buildbot/test/__init__.py: remove the global os.environ()
2103 setting, instead we do it just for the tests that run commands and
2104 need to parse their output.
2106 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2107 remove the overly-short .timeout on this test, because non-DNotify
2108 platforms must fall back to polling which happens at 10 second
2109 intervals, so a 5 second timeout would never succeed.
2111 2006-04-24 Brian Warner <warner@lothar.com>
2113 * docs/buildbot.texinfo (Installing the code): update trial
2114 invocation, SF#1469116 by Niklaus Giger.
2115 (Attributes of Changes): updated branch-name examples to be
2116 a bit more realistic, SF#1475240 by Stephen Davis.
2118 * contrib/windows/buildbot2.bat: utility wrapper for windows
2119 developers, contributed by Nick Trout (after a year of neglect..
2120 sorry!). SF#1194231.
2122 * buildbot/test/test_vc.py (*.capable): store the actual VC
2123 binary's pathname in VCS[vcname], so it can be retrieved later
2124 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2125 strip out non-numeric timezone information, specifically the funky
2126 German string that his system produced that confuses CVS.
2127 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2128 allow Darcs tests to work on windows
2129 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2130 procutils.which() everywhere, to allow tryclient to work under
2131 windows. Also from Niklaus Giger, SF#1463394.
2133 * buildbot/twcompat.py (which): move the replacement for a missing
2134 twisted.python.procutils.which from test_vc.py to here, so it can
2135 be used in other places too (specifically tryclient.py)
2137 2006-04-23 Brian Warner <warner@lothar.com>
2139 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2140 bare buildbotURL/projectName line with a proper DIV, along with a
2141 CSS class of "title", from Stefan Seefeld (SF#1461675).
2142 (WaterfallStatusResource.body0): remove the redundant 'table'
2143 class from the table
2144 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2145 to the top-row TR, and class="Activity" to the second-row TR,
2146 rather than putting them in the individual TD nodes.
2148 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2149 'got_revision' build property for all VC systems that implement
2150 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2152 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2153 to determine which revision we actually obtained
2154 (CVS.parseGotRevision): implement this for CVS, which just means
2155 to grab a timestamp. Not ideal, and it depends upon the buildslave
2156 having a clock that is reasonably well syncronized with the server,
2157 but it's better than nothing.
2158 (SVN.parseGotRevision): implement it for SVN, which is accurate
2159 (Darcs.parseGotRevision): same
2160 (Arch.parseGotRevision): same
2161 (Bazaar.parseGotRevision): same
2162 (Mercurial.parseGotRevision): same
2164 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2165 keep a record of all non-stdout/stderr/header/rc status updates,
2166 for the benefit of RemoteCommands that send other useful things,
2168 (Source.commandComplete): put any 'got_revision' status values
2169 into a build property of the same name
2172 * buildbot/process/step_twisted.py (Trial): update to deal with
2173 new ShellCommand refactoring
2175 * docs/buildbot.texinfo (Build Properties): document new feature
2176 that allows BuildSteps to get/set Build-wide properties like which
2177 revision was requested and/or checked out.
2179 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2180 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2181 it. Note that this bumps the persistenceVersion of the saved Build
2182 object, so add the necessary upgrade-old-version logic to include
2183 an empty properties dict.
2185 * buildbot/process/base.py (Build.setProperty): implement it
2186 (Build.getProperty): same
2187 (Build.startBuild): change build startup to set 'branch',
2188 'revision', and 'slavename' properties at the right time
2190 * buildbot/process/step.py (BuildStep.__init__): change setup to
2191 require 'build' argument in a better way
2192 (LoggingBuildStep): split ShellCommand into two pieces, for better
2193 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2194 a single RemoteCommand that sends stdout/stderr status text. It
2195 also provides the usual commandComplete / createSummary /
2196 evaluateCommand / getText methods to be overridden...
2197 (ShellCommand): .. whereas ShellCommand is specifically for
2198 running RemoteShellCommands. Other shell-like BuildSteps (like
2199 Source) can inherit from LoggingBuildStep instead of ShellCommand
2200 (WithProperties): marker class to do build-property interpolation
2201 (Source): inherit from LoggingBuildStep instead of ShellCommand
2204 * buildbot/test/test_properties.py: test new functionality
2206 2006-04-21 Brian Warner <warner@lothar.com>
2208 * buildbot/test/test_vc.py: rename testBranch to
2209 testCheckoutBranch to keep the tests in about the right
2212 2006-04-18 Brian Warner <warner@lothar.com>
2214 * docs/buildbot.texinfo (PBListener): improve cross-references
2215 between PBListener and 'buildbot statusgui', thanks to John Pye
2218 2006-04-17 Brian Warner <warner@lothar.com>
2220 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2221 running under Twisted-1.3.0, otherwise skipped tests are reported
2224 * all: use isinstance() instead of 'type(x) is foo', suggested by
2227 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2228 oops, fix a brain-fade from the other week, when making the
2229 addStep changes. I changed all the __init__ upcalls to use the
2230 wrong superclass name.
2231 (FullTwistedBuildFactory.__init__): same
2232 (TwistedDebsBuildFactory.__init__): same
2233 (TwistedReactorsBuildFactory.__init__): same
2234 (TwistedBuild.isFileImportant): use .startswith for clarity,
2235 thanks to Neal Norwitz for the suggestions.
2237 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2238 changes, then deliver them over PB to a remote buildmaster.
2240 * contrib/svnpoller.py: added script by John Pye to poll a remote
2241 SVN repository (by running 'svn log') from a cronjob, and run
2242 'buildbot sendchange' to deliver the changes to a remote
2244 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2245 modification of svnpoller.py), same purpose, but this one loops
2246 internally (rather than expecting to run from a cronjob) and works
2248 * contrib/README.txt: same
2250 2006-04-11 Brian Warner <warner@lothar.com>
2252 * all: fix a number of incorrect names and missing imports, thanks
2253 to Anthony Baxter for the patch.
2254 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2255 remove unused buggy method.
2256 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2257 comes from shutil, not "shutils"
2258 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2259 (Arch.checkSlaveVersion): same
2260 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2262 * buildbot/process/step_twisted2.py: add some missing imports
2263 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2264 this code used to live in twisted.internet.defer
2266 2006-04-10 Brian Warner <warner@lothar.com>
2268 * buildbot/process/step.py (Mercurial): add Mercurial support
2269 * buildbot/slave/commands.py (Mercurial): same
2270 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2271 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2272 not yet tested, but 'try' support *is* covered
2273 * docs/buildbot.texinfo (Mercurial): document it
2275 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2276 some debugging messages (turned off)
2277 * buildbot/test/test_vc.py: improve debug messages
2279 2006-04-07 Brian Warner <warner@lothar.com>
2281 * buildbot/test/test_vc.py (which): define our own which() in case
2282 we can't import twisted.python.procutils, because procutils doesn't
2283 exist in Twisted-1.3
2285 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2286 of SlaveLocks for performance tests
2288 * docs/examples/twisted_master.cfg: update to match current usage
2290 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2291 password, p4 binary, pollinterval, maximum history to check.
2292 Patch from an anonymous sf.net contributor, SF#1219384.
2293 * buildbot/process/step.py (P4Sync.__init__): add username,
2294 password, and client arguments.
2295 * buildbot/slave/commands.py (P4Sync): same
2297 2006-04-05 Brian Warner <warner@lothar.com>
2299 * buildbot/process/factory.py (BuildFactory.addStep): new method
2300 to add steps to a BuildFactory. Use it instead of f.steps.append,
2301 and you can probably avoid using the s() convenience function.
2302 Patch from Neal Norwitz, sf.net #1412605.
2303 (other): update all factories to use addStep
2304 * buildbot/process/process_twisted.py: update all factories to use
2307 2006-04-03 Brian Warner <warner@lothar.com>
2309 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2310 work under windows too. Adapted from a patch by Niklaus Giger,
2311 addresses SF#1463399.
2313 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2314 spawned commands emit parseable results in english and not some
2315 other language. Patch from Niklaus Giger, SF#1463395.
2317 * README (INSTALLATION): discourage users from running unit tests on
2318 a "network drive", patch from Niklaus Giger, SF#1463394.
2320 2006-03-22 Brian Warner <warner@lothar.com>
2322 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2323 function to turn a repository-relative pathname into a (branch,
2324 branch-relative-filename) tuple. Change this function to handle
2325 the branch naming policy used by your Subversion repository.
2326 Thanks to AllMyData.com for sponsoring this work.
2328 2006-03-16 Brian Warner <warner@lothar.com>
2330 * buildbot/scripts/sample.cfg: add python-mode declaration for
2331 vim. Thanks to John Pye for the patch.
2333 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2334 command line, mention the importance of running 'crontab' as the
2335 buildmaster/buildslave user. Thanks to John Pye for the catch.
2337 2006-03-13 Brian Warner <warner@lothar.com>
2339 * buildbot/status/words.py (IRC): add an optional password=
2340 argument, which will be sent to Nickserv in an IDENTIFY message at
2341 login, to claim the nickname. freenode requires this before the
2342 bot can sent (or reply to) private messages. Thanks to Clement
2343 Stenac for the patch.
2344 * docs/buildbot.texinfo (IRC Bot): document it
2346 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2347 larger than chunkSize. Fixes SF#1349253.
2348 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2349 (Log.testConsumer): update to match new internal chunking behavior
2351 2006-03-12 Brian Warner <warner@lothar.com>
2353 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2355 * buildbot/test/test_maildir.py (MaildirTest): rename the
2356 'timeout' method, as it collides with trial's internals
2358 * buildbot/scripts/runner.py: add 'buildbot restart' command
2359 (stop): don't sys.exit() out of here, otherwise restart can't work
2360 * docs/buildbot.texinfo (Shutdown): document it
2362 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2363 * buildbot/status/html.py (Waterfall.__init__): same
2364 * buildbot/process/builder.py (Builder.startBuild): same
2365 * buildbot/process/base.py (BuildRequest): same
2366 * buildbot/sourcestamp.py (SourceStamp): same
2367 * buildbot/scheduler.py (Nightly): same
2369 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2371 * docs/buildbot.texinfo: same
2373 2006-02-17 Brian Warner <warner@lothar.com>
2375 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2376 * docs/buildbot.texinfo: set version number to match
2377 * NEWS: update for 0.7.2
2379 2006-02-16 Brian Warner <warner@lothar.com>
2381 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2383 2006-02-09 Brian Warner <warner@lothar.com>
2385 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2386 add text to explain per-build branch parameters
2387 * NEWS: mention --umask
2389 2006-02-08 Brian Warner <warner@lothar.com>
2391 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2393 (SlaveOptions.optParameters): add --umask, to make it possible to
2394 make buildslave-generated files (including build products) be
2397 * buildbot/slave/bot.py (BuildSlave.startService): same
2399 2006-01-23 Brian Warner <warner@lothar.com>
2401 * buildbot/status/builder.py: urllib.quote() all URLs that include
2402 Builder names, so that builders can include characters like '/'
2403 and ' ' without completely breaking the resulting HTML. Thanks to
2404 Kevin Turner for the patch.
2405 * buildbot/status/html.py: same
2406 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2408 * NEWS: update in preparation for upcoming release
2410 2006-01-18 Brian Warner <warner@lothar.com>
2412 * docs/examples/twisted_master.cfg: update to match the Twisted
2413 buildbot: remove python2.2, switch to exarkun's buildslaves,
2414 disable the .deb builder until we figure out how to build twisted
2415 .debs from SVN, add some ktrace debugging to the OS-X build
2416 process and remove the qt build, remove threadless builders,
2417 change freebsd builder to use landonf's buildslave.
2419 2006-01-12 Brian Warner <warner@lothar.com>
2421 * buildbot/master.py (Manhole.__init__): let port= be a strports
2422 specification string, but handle a regular int for backwards
2423 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2424 used in master.cfg to limit connections to just the local host.
2425 (BuildMaster.loadConfig): same for c['slavePortnum']
2426 * buildbot/scheduler.py (Try_Userpass.__init__): same
2427 * buildbot/status/client.py (PBListener.__init__): same
2428 * buildbot/status/html.py (Waterfall.__init__): same, for both
2429 http_port and distrib_port. Include backwards-compatibility checks
2430 so distrib_port can be a filename string and still mean unix:/foo
2431 * docs/buildbot.texinfo (Setting the slaveport): document it
2432 (Debug options): same
2433 (HTML Waterfall): same
2436 * buildbot/test/test_config.py (ConfigTest): test it
2438 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2439 slaveport's disownServiceParent deferred to fire before opening
2440 the new one. Fixes an annoying bug in the unit tests.
2442 2006-01-03 Brian Warner <warner@lothar.com>
2444 * buildbot/master.py (BuildMaster): remove the .schedulers
2445 attribute, replacing it with an allSchedulers() method that looks
2446 for all IService children that implement IScheduler. Having only
2447 one parent/child relationship means fewer opportunities for bugs.
2448 (BuildMaster.allSchedulers): new method
2449 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2450 also fix ugly bug that caused any config-file reload to
2451 half-forget about the earlier Schedulers, causing an exception
2452 when a Change arrived and was handed to a half-connected
2453 Scheduler. The exception was in scheduler.py line 54ish:
2454 self.parent.submitBuildSet(bs)
2455 exceptions.AttributeError: 'NoneType' object has no attribute
2457 (BuildMaster.addChange): update to use allSchedulers()
2459 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2460 to work properly with twisted-1.3.0, where you must explicitly
2461 include the __implements__ from parent classes
2462 (BaseScheduler.__repr__): make it easier to distinguish distinct
2464 (BaseUpstreamScheduler.__implements__): same
2466 * buildbot/status/builder.py (Status.getSchedulers): update to
2468 * buildbot/test/test_run.py (Run.testMaster): same
2469 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2470 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2471 make sure Scheduler instances are left alone when an identical
2472 config file is reloaded
2473 (ConfigElements.testSchedulers): make sure Schedulers are properly
2476 * Makefile (TRIALARGS): my local default Twisted version is now
2477 2.1.0, update the trial arguments accordingly
2479 2005-12-22 Brian Warner <warner@lothar.com>
2481 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2484 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2485 addChange in the parent class, although I suspect this should be
2486 fixed better in the future.
2488 2005-11-26 Brian Warner <warner@lothar.com>
2490 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2491 explode when branch==None, thanks to Kevin Turner for the catch
2492 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2495 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2497 * docs/buildbot.texinfo: same
2499 2005-11-26 Brian Warner <warner@lothar.com>
2501 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2502 * docs/buildbot.texinfo: set version number to match
2504 2005-11-26 Brian Warner <warner@lothar.com>
2506 * NEWS: update for 0.7.1
2508 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2509 sure that unsubscribe works even if we never sent an ETA update.
2510 Also, don't explode on duplicate unsubscribe.
2511 (BuildStepStatus.addLog): make the convenience "return self"-added
2512 watcher automatically unsubscribe when the Step finishes.
2513 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2514 (BuildStatus.stepStarted): same auto-unsubscribe
2515 (BuilderStatus.buildStarted): same auto-unsubscribe
2517 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2519 (IStatusReceiver.stepStarted): same
2520 (IStatusReceiver.logStarted): same
2522 * buildbot/test/test_run.py (Status): move the Status test..
2523 * buildbot/test/test_status.py (Subscription): .. to here
2525 2005-11-25 Brian Warner <warner@lothar.com>
2527 * NEWS: more updates
2529 * buildbot/locks.py: fix the problem in which loading a master.cfg
2530 file that changes some Builders (but not all of them) can result
2531 in having multiple copies of the same Lock. Now, the real Locks
2532 are kept in a table inside the BotMaster, and the Builders/Steps
2533 use "LockIDs", which are still instances of MasterLock and
2534 SlaveLock. The real Locks are instances of the new RealMasterLock
2535 and RealSlaveLock classes.
2536 * buildbot/master.py (BotMaster.getLockByID): new method to
2537 convert LockIDs into real Locks.
2538 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2539 into real Locks before building
2540 * buildbot/process/step.py (BuildStep.startStep): same
2541 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2542 exercises the problem
2545 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2546 what Schedulers are available
2548 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2549 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2550 'cron'-style build scheduling at certain times of day, week,
2552 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2554 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2555 handling: treat self.fileIsImportant more as an attribute that
2556 contains a callable than as a method. If the attribute is None,
2557 don't call it and assume all filenames are important. It is still
2558 possible to provide a fileIsImportant method in a subclass,
2560 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2562 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2563 test using AnyBranchScheduler with fileIsImportant=None
2565 2005-11-24 Brian Warner <warner@lothar.com>
2567 * buildbot/test/test_config.py (StartService): don't claim a fixed
2568 port number, instead set slavePort=0 on the first pass, figure out
2569 what port was allocated, then switch to a config file that uses
2572 * buildbot/master.py (BuildMaster.loadConfig): close the old
2573 slaveport before opening the new one, because unit tests might
2574 replace slavePort=0 with the same allocated portnumber, and if we
2575 don't wait for the old port to close first, we get a "port already
2576 in use" error. There is a tiny race condition here, but the only
2577 threat is from other programs that bind (statically) to the same
2578 port number we happened to be allocated, and only if those
2579 programs use SO_REUSEADDR, and only if they get control in between
2582 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2584 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2585 deleted ChangeSources before adding any new ones
2586 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2587 compare_attrs, to make sure that a config-file reload does not
2588 unnecessarily replace an unmodified ChangeSource instance
2589 * buildbot/test/test_config.py (ConfigTest.testSources): update
2591 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2592 mean "don't build anything", and add a warning if it gets used
2593 because it isn't actually useful.
2595 * contrib/svn_buildbot.py: update example usage to match the port
2596 number that gets used by the PBChangeSource
2597 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2599 2005-11-22 Brian Warner <warner@lothar.com>
2601 * NEWS: start collecting items for next release
2603 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2604 revisions are strings
2605 (P4Sync.computeSourceRevision): same
2607 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2608 to the Buildbot's overall status page
2609 (StatusResourceBuilder.body): same
2611 2005-11-15 Brian Warner <warner@lothar.com>
2613 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2614 config-file loading, specifically to make sure old StatusTargets
2615 are finished shutting down before new ones start up (thus
2616 resolving a bug in which changing the Waterfall object would fail
2617 because both new and old instances were claiming the same
2618 listening port). Also load new Schedulers after all the new
2619 Builders are set up, in case they fire off a new build right away.
2620 * buildbot/test/test_config.py (StartService): test it
2622 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2623 the branch name to the mail body
2625 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2626 Without it, a config-file reload fails to update an existing
2628 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2629 username/passwd to compare_attrs, for the same reason
2630 * buildbot/status/html.py (Waterfall): add favicon to
2631 compare_attrs, same reason
2633 2005-11-05 Brian Warner <warner@lothar.com>
2635 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2636 baserev before stuffing it in the jobfile. This resolves problems
2637 under SVN (and probably Arch) where revisions are expressed as
2638 numbers. I'm inclined to use string-based revisions everywhere in
2639 the future, but this fix should be safe for now. Thanks to Steven
2640 Walter for the patch.
2642 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2643 binary mode when opening pickle files, to make windows work
2644 better. Thanks to Dobes Vandermeer for the catch.
2645 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2646 (BuilderStatus.getBuildByNumber): same
2647 (Status.builderAdded): same
2648 * buildbot/master.py (BuildMaster.loadChanges): same
2650 * buildbot/util.py (Swappable): delete unused leftover code
2652 * buildbot/process/step.py (SVN): when building on a non-default
2653 branch, add the word "[branch]" to the VC step's description, so
2654 it is obvious that we're not building the usual stuff. Likewise,
2655 when we are building a specific revision, add the text "rNNN" to
2656 indicate what that revision number is. Thanks to Brad Hards and
2657 Nathaniel Smith for the suggestion.
2658 (Darcs.startVC): same
2659 (Arch.startVC): same
2660 (Bazaar.startVC): same
2662 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2663 typo, caught by Mark Dillavou, closes SF#1216636.
2665 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2666 about a test to add some day
2668 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2669 the 'full-2.3' build, and the 'reactors' build is now run under
2670 python-2.4 because the buildslave no longer has gtk/etc bindings
2671 for earlier versions.
2673 2005-11-03 Brian Warner <warner@lothar.com>
2675 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2676 method, takes an IBuildStatus and rebuilds it. It might make more
2677 sense to add this to IBuildControl instead, but that instance goes
2678 away completely once the build has finished, and resubmitting
2679 builds can take place weeks later.
2680 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2681 * buildbot/status/html.py (StatusResourceBuild): also stash an
2682 IBuilderControl so we can use resubmitBuild.
2683 (StatusResourceBuild.body): render "resubmit" button if we can.
2684 Also add hrefs for each BuildStep
2685 (StatusResourceBuild.rebuild): add action for "resubmit" button
2686 (StatusResourceBuilder.getChild): give it an IBuilderControl
2688 * buildbot/status/builder.py (Status.getURLForThing): change the
2689 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2690 that live as targets of buttons like "stop" and "rebuild" can't
2692 * buildbot/status/builder.py (Status.getURLForThing): same
2693 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2694 (StepBox.getBox): same
2695 * buildbot/test/test_web.py (GetURL): same
2698 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2699 exclusivity checks after Source.__init__ upcall, so misspelled
2700 arguments will be reported more usefully
2701 (Darcs.__init__): same
2703 2005-10-29 Brian Warner <warner@lothar.com>
2705 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2706 builder. Move the Try scheduler off to a separate port.
2708 2005-10-27 Brian Warner <warner@lothar.com>
2710 * buildbot/clients/gtkPanes.py
2711 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2712 to cause the app to crash, now they don't.
2714 * buildbot/clients/debug.py: display the buildmaster's location
2715 in the window's title bar
2717 2005-10-26 Brian Warner <warner@lothar.com>
2719 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2720 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2721 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2723 * buildbot/status/html.py (td): put a single non-breaking space
2724 inside otherwise empty <td> elements, as a workaround for buggy
2725 browsers which would optimize them away (along with any associated
2726 styles, like the kind that create the waterfall grid borders).
2727 Patch from Frerich Raabe.
2729 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2730 argv-list as an argument, defaulting to ["-to"], which is
2731 appropriate for the Trial that comes with Twisted-2.1.0 and
2732 earlier. The Trial in current Twisted SVN wants
2733 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2734 defaults to an empty list.
2735 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2736 match it, now that trialMode= is a list instead of a single string
2738 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2740 * docs/buildbot.texinfo: same
2742 2005-10-24 Brian Warner <warner@lothar.com>
2744 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2745 * docs/buildbot.texinfo: set version number to match
2747 2005-10-24 Brian Warner <warner@lothar.com>
2749 * README: update for 0.7.0
2751 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2753 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2754 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2755 send the branch= argument unless the user really provided one, to
2756 retain compatibility with older buildmasters that don't accept
2758 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2761 * docs/buildbot.texinfo: update lots of stuff
2763 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2764 to the 'buildbot sendchange' command
2765 * buildbot/clients/sendchange.py (Sender.send): same
2766 * buildbot/changes/pb.py (ChangePerspective): same
2767 * buildbot/test/test_changes.py (Sender.testSender): test it
2769 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2770 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2771 for consistency with other BuildStep arguments that use camelCase.
2772 Well, at least more of them use camelCase (like flunkOnWarnings)
2773 than don't.. I wish I'd picked one style and stuck with it
2774 earlier. Annoying, but it's best done before the release, since
2775 these arguments didn't exist at all in 0.6.6 .
2777 * buildbot/test/test_vc.py (SVN.testCheckout): same
2778 (Darcs.testPatch): same
2779 * docs/buildbot.texinfo (SVN): document the change
2780 (Darcs): same, add some build-on-branch docs
2781 * docs/examples/twisted_master.cfg: match change
2783 * buildbot/process/step.py (BuildStep): rename
2784 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2785 how it is normally used.
2786 * buildbot/test/test_steps.py (Version.checkCompare): same
2788 * buildbot/process/step.py (CVS.startVC): refuse to build
2789 update/copy -style builds on a non-default branch with an old
2790 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2791 concern is that it will do a VC 'update' in an existing tree when
2792 it is supposed to be switching branches (and therefore clobbering
2793 the tree to do a full checkout), thus building the wrong source.
2794 This used to be a warning, but I think the confusion it is likely
2795 to cause warrants making it an error.
2796 (SVN.startVC): same, also make mode=export on old slaves an error
2797 (Darcs.startVC): same
2798 (Git.startVC): improve error message for non-Git-enabled slaves
2799 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2800 specific revision is built on a slave that doesn't pay attention
2801 to args['revision'], because for slowly-changing trees it will
2802 probably do the right thing, and because we have no way to tell
2803 whether we're asking it to build the most recent version or not.
2804 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2806 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2807 that 'master' is in host:portnum format, to catch errors sooner
2809 2005-10-23 Brian Warner <warner@lothar.com>
2811 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2812 when creating the list of warning messages, include the line
2813 immediately after each WARNING: line, since that's usually where
2814 the file and line number wind up.
2816 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2821 2005-10-22 Brian Warner <warner@lothar.com>
2823 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2824 patch from Brad Hards
2825 * buildbot/status/classic.css: same
2826 * buildbot/test/test_web.py (Waterfall): match changes
2828 * buildbot/test/test_steps.py (BuildStep.setUp): set
2829 nextBuildNumber so the test passes
2830 * buildbot/test/test_status.py (MyBuilder): same
2832 * buildbot/status/html.py (StatusResourceBuild.body): revision
2833 might be numeric, so stringify it before html-escapifying it
2834 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2835 timer for the upcoming build
2836 * buildbot/status/classic.css: add background-color attributes for
2837 offline/waiting/building classes
2839 * buildbot/status/builder.py (BuildStatus): derive from
2840 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2841 the default (i.e. unknown) .slavename to "???" instead of None,
2842 since even unknown slavenames need to be printed eventually.
2843 (BuilderStatus): also derive from styles.Versioned . More
2844 importantly, determine .nextBuildNumber at creation/unpickling
2845 time by scanning the directory of saved BuildStatus instances and
2846 choosing one larger than the highest-numbered one found. This
2847 should fix the problem where random errors during upgrades cause
2848 the buildbot to forget about earlier builds. .nextBuildNumber is
2849 no longer stored in the pickle.
2850 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2851 at least log the error. Also call Builder.determineNextBuildNumber
2852 once the basedir is set.
2854 * buildbot/master.py (BuildMaster.loadChanges): do
2855 styles.doUpgrade afterwards, in case I decide to make Changes
2856 derived from styles.Versioned some day and forget to make this
2860 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2861 when running under older pythons (<2.3) in which the shlex module
2862 doesn't have a 'split' function.
2864 * buildbot/process/step.py (ShellCommand.start): make
2865 errorMessages= be a list of strings to stuff in the log before the
2866 command actually starts. This makes it easier to flag multiple
2867 warning messages, e.g. when the Source steps have to deal with an
2869 (CVS.startVC): handle slaves that don't handle multiple branches
2870 by switching into 'clobber' mode
2871 (SVN.startVC): same. Also reject branches without base_url
2872 (Darcs.startVC): same. Also reject revision= in older slaves
2873 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2874 (Bazaar.startVC): same, and test for baz separately than for arch
2876 * buildbot/slave/commands.py (cvs_ver): document new features
2878 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2879 (BuildStep.slaveVersionNewEnough): more useful utility method
2880 * buildbot/test/test_steps.py (Version): start testing it
2882 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2883 the 'force' command requires python2.3, for the shlex.split method
2885 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2886 since we don't use it anymore. The Twisted buildbot uses a
2889 2005-10-21 Brian Warner <warner@lothar.com>
2891 * buildbot/process/process_twisted.py: rework all BuildFactory
2892 classes to take a 'source' step as an argument, instead of
2893 building up the SVN instance in the factory.
2894 * docs/examples/twisted_master.cfg: enable build-on-branch by
2895 providing a base_url and default_branch
2897 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2898 control over --branch and --revision, not that they are always
2900 * buildbot/status/html.py (StatusResourceBuilder.force): same
2901 (StatusResourceBuild.body): display SourceStamp components
2903 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2904 IRC 'force' command, so it can be shared with an eventual
2905 command-line-tool 'buildbot force' mode.
2906 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2908 2005-10-20 Brian Warner <warner@lothar.com>
2910 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2912 * docs/examples/twisted_master.cfg: update to use Schedulers
2914 * buildbot/scripts/sample.cfg: update with Schedulers
2916 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2917 method specifically for use by HTML "force build" button and the
2918 IRC "force" command. Raises an immediate error if there are no
2920 (IBuilderControl.requestBuild): make this just submit a build, not
2921 try to check for existing slaves or set up any when-finished
2922 Deferreds or anything.
2923 * buildbot/process/builder.py (BuilderControl): same
2924 * buildbot/status/html.py (StatusResourceBuilder.force): same
2925 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2926 * buildbot/test/test_slaves.py: same
2927 * buildbot/test/test_web.py: same
2929 2005-10-19 Brian Warner <warner@lothar.com>
2931 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2932 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2934 2005-10-18 Brian Warner <warner@lothar.com>
2936 * buildbot/status/html.py: provide 'status' argument to most
2937 StatusResourceFOO objects
2938 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2939 and Logfiles" section to make the Build page into a more-or-less
2940 comprehensive source of status information about the build
2942 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2943 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2945 2005-10-17 Brian Warner <warner@lothar.com>
2947 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2948 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2949 out what to do about other projects: the correct options for
2950 recent Twisteds will not work for older ones.
2952 2005-10-15 Brian Warner <warner@lothar.com>
2954 * buildbot/status/builder.py (Status.getURLForThing): add method
2955 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2956 use this in email/IRC status clients to make them more useful, by
2957 providing the end user with hints on where to learn more about the
2958 object being reported on.
2959 * buildbot/test/test_web.py (GetURL): tests for it
2961 2005-10-14 Brian Warner <warner@lothar.com>
2963 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2964 fix bug resulting from deferredResult changes
2966 2005-10-13 Brian Warner <warner@lothar.com>
2968 * buildbot/test/test_changes.py: remove use of deferredResult
2969 * buildbot/test/test_config.py: same
2970 * buildbot/test/test_control.py: same
2971 * buildbot/test/test_status.py: same
2972 * buildbot/test/test_vc.py: this is the only remaining use, since
2973 it gets used at module level. This needs to be replaced by some
2974 sort of class-level run-once routine.
2976 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2978 * lots: implement multiple slaves per Builder, which means multiple
2979 current builds per Builder. Some highlights:
2980 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2981 of (state,currentBuilds) instead of (state,currentBuild)
2982 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2983 (IBuildStatus.getSlavename): new method, so you can tell which
2984 slave got used. This only gets set when the build completes.
2985 (IBuildRequestStatus.getBuilds): new method
2987 * buildbot/process/builder.py (SlaveBuilder): add a .state
2988 attribute to track things like ATTACHING and IDLE and BUILDING,
2990 (Builder): .. the .slaves attribute here, which has been turned
2991 into a simple list of available slaves. Added a separate
2992 attaching_slaves list to track ones that are not yet ready for
2994 (Builder.fireTestEvent): put off the test-event callback for a
2995 reactor turn, to make tests a bit more consistent.
2996 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2997 ping fails due to an exception. This needs work, I'm worried that
2998 a code error could lead to a constantly re-connecting slave.
2999 Especially since I'm trying to move to a distinct remote_ping
3000 method, separate from the remote_print that we currently use.
3001 (BuilderControl.requestBuild): return a convenience Deferred that
3002 provides an IBuildStatus when the build finishes.
3003 (BuilderControl.ping): ping all connected slaves, only return True
3004 if they all respond.
3006 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3007 reconnect when we shut down.
3009 * buildbot/status/builder.py: implement new methods, convert
3010 one-build-at-a-time methods to handle multiple builds
3011 * buildbot/status/*.py: do the same in all default status targets
3012 * buildbot/status/html.py: report the build's slavename in the
3013 per-Build page, report all buildslaves on the per-Builder page
3015 * buildbot/test/test_run.py: update/create tests
3016 * buildbot/test/test_slaves.py: same
3017 * buildbot/test/test_scheduler.py: remove stale test
3019 * docs/buildbot.texinfo: document the new builder-specification
3020 'slavenames' parameter
3022 2005-10-12 Brian Warner <warner@lothar.com>
3024 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3025 report failure correctly, causing Dependent builds to run when
3026 they shouldn't have.
3027 * buildbot/status/builder.py (BuildSetStatus): same
3028 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3029 (Set.testSuccess): test the both-pass case too
3030 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3031 fix this test: it was ending too early, masking the failure before
3032 (Logger): specialized StatusReceiver to make sure the dependent
3033 builds aren't even started, much less completed.
3035 2005-10-07 Brian Warner <warner@lothar.com>
3037 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3038 bot.SlaveBuilder being disowned in the middle of a build
3040 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3041 this inherit from StatusReceiver. Also upcall in __init__. This
3042 fixes the embarrasing crash when the new buildSetSubmitted method
3043 is invoked and Waterfall/etc don't implement their own.
3044 * buildbot/test/test_run.py: add a TODO note about a test to catch
3045 just this sort of thing.
3047 * buildbot/process/builder.py (Builder.attached): remove the
3048 already-attached warning, this situation is normal. Add some
3049 comments explaining it.
3051 2005-10-02 Brian Warner <warner@lothar.com>
3053 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3054 OverflowError when setting up dnotify, because some 64-bit systems
3055 have problems with signed-vs-unsigned constants and trip up on the
3056 DN_MULTISHOT flag. Patch from Brad Hards.
3058 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3060 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3061 progressMetrics, description, descriptionDone to the 'parms' list,
3062 and make use the 'parms' list from the implementation class
3063 instead of only BuildStep to initialize the parameters. This
3064 allows buildbot.process.factory.s() to initialize all the parms,
3065 not just those defined in directly by BuildStep.
3067 2005-09-03 Brian Warner <warner@lothar.com>
3069 * NEWS: start adding items for the next release
3071 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3072 python2.2 tests, change 'Quick' builder to only use python2.3
3074 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3076 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3077 the "Ping Builder" button if the build control is available; the
3078 user sees an exception otherwise
3080 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3082 2005-09-01 Brian Warner <warner@lothar.com>
3084 * buildbot/interfaces.py (IBuilderStatus.getState): update
3085 signature, point out that 'build' can be None
3086 (IBuildStatus.getETA): point out ETA can be none
3088 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3090 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3092 2005-08-31 Brian Warner <warner@lothar.com>
3094 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3095 update to match correct signature: removed 'eta' argument
3096 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3098 2005-08-30 Brian Warner <warner@lothar.com>
3100 * buildbot/status/builder.py (LogFile): remove the assertion that
3101 blows up when you try to overwrite an existing logfile, instead
3102 just emit a warning. This case gets hit when the buildmaster is
3103 killed and doesn't get a chance to write out the serialized
3104 BuilderStatus object, so the .nextBuildNumber attribute gets out
3107 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3108 the 'buildbot sendchange' arguments, for the Darcs context file
3109 * docs/buildbot.texinfo (sendchange): document it
3111 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3112 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3113 (IStatus.getSchedulers): new method
3114 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3115 (Status.getSchedulers): implement
3116 * buildbot/process/builder.py (Builder): maintain
3117 BuilderStatus.pendingBuilds
3118 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3119 (TryBase.addChange): Try schedulers should ignore Changes
3121 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3122 for 'try' on CVS/SVN
3123 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3125 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3126 report status properly.
3127 (Try.createJob): implement unique buildset IDs
3129 * buildbot/status/client.py (StatusClientPerspective): add a
3130 perspective_getBuildSets method for the benefit of jobdir-style
3132 * docs/buildbot.texinfo (try): more docs
3133 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3136 2005-08-18 Brian Warner <warner@lothar.com>
3138 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3139 actually work. It's functional but still kind of clunky. Also, it
3140 only works with the pb-style.. needs to be made to work with the
3143 * buildbot/status/client.py (RemoteBuildSet): new class
3144 (RemoteBuildRequest): same
3145 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3146 object, not the internal BuildStatus object.
3147 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3148 outside of the usual buildStarted() return value.
3149 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3151 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3152 (Try_Userpass_Perspective.perspective_try): return a remotely
3153 usable BuildSetStatus object
3155 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3156 isStarted()/waitUntilStarted()
3158 2005-08-16 Brian Warner <warner@lothar.com>
3160 * buildbot/status/builder.py: implement IBuildSetStatus and
3161 IBuildRequestStatus, wire them into place.
3162 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3163 methods into the BuildSetStatus object.
3164 * buildbot/interfaces.py: same
3165 (IStatus.getBuildSets): new method to get pending BuildSets
3166 (IStatusReceiver.buildsetSubmitted): new method which hears about
3168 * buildbot/master.py (BuildMaster.submitBuildSet): same
3169 * buildbot/process/base.py (BuildRequest): same, replace
3170 waitUntilStarted with subscribe/unsubscribe
3171 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3172 subscribe instead of waitUntilStarted
3173 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3175 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3177 * buildbot/test/test_buildreq.py: update for new code
3178 * buildbot/test/test_control.py (Force.testRequest): same
3181 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3182 for Darcs to not use the tempfile module, so it works under
3183 python-2.2 too. We really didn't need the full cleverness of that
3184 module, since the slave has exclusive control of its own builddir.
3186 2005-08-15 Brian Warner <warner@lothar.com>
3188 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3189 for CVS trees. It doesn't work for non-trunk branches,
3191 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3194 * Makefile: make it easier to test against python2.2
3196 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3197 tearDown2, so things like Arch can unregister archives as they're
3198 shutting down. The previous subclass-override-tearDown technique
3199 resulted in a nested maybeWait() and test failures under
3202 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3203 where we can (Arch), add a branch= argument to set the branch used
3205 (BazExtractor): extract the branch too
3206 (TlaExtractor): same
3207 * buildbot/scripts/runner.py (TryOptions): add --branch
3208 * docs/buildbot.texinfo (try): document --branch/try_branch
3210 * buildbot/slave/commands.py (Darcs): implement get-revision for
3211 Darcs, so that 'try' will work. This requires the tempfile module
3214 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3215 of revisions, branches, and 'try' in the process.
3217 2005-08-11 Brian Warner <warner@lothar.com>
3219 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3220 this, it got broken at some point in the last few releases
3221 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3222 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3223 specifically the removal of ETA information from the tuple
3225 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3228 * docs/buildbot.texinfo (try): document both --builder and
3229 'try_builders' in .buildbot/options
3230 * buildbot/scripts/runner.py (TryOptions): add --builder,
3231 accumulate the values into opts['builders']
3232 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3233 * buildbot/test/test_runner.py (Try): add some quick tests to make
3234 sure 'buildbot try --options' and .buildbot/options get parsed
3235 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3236 use --builder control
3238 * docs/buildbot.texinfo (try): add --port argument to PB style
3240 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3241 actual SourceStamp. Still need to extract a branch name, somehow.
3242 (Try): finish implementing the try client side, still need a UI
3243 for specifying which builders to use
3244 (Try.getopt): factor our options/config-file reading
3245 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3247 * buildbot/test/test_vc.py: match SourceStampExtractor change
3249 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3250 causes the twisted log to be sent to stderr
3252 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3254 2005-08-10 Brian Warner <warner@lothar.com>
3256 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3257 style is 90% done, still missing status reporting or waiting for
3258 the buildsets to finish, and it is completely untested.
3260 * buildbot/trybuild.py: delete file, move contents to ..
3261 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3262 * buildbot/test/test_vc.py: match the move
3264 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3265 of the TryScheduler, no buildsetID or status-tracking support yet
3266 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3268 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3269 possible to set the basedir after __init__ time, so it is easier
3270 to use as a Service-child of the BuildMaster instance
3272 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3273 that delivers messages to its Service parent instead of requiring
3274 a subclass to be useful. This turns out to be much easier to build
3277 * buildbot/scripts/tryclient.py (createJob): utility code to
3278 create jobfiles, will eventually be used by 'buildbot try'
3280 2005-08-08 Brian Warner <warner@lothar.com>
3282 * docs/buildbot.texinfo (try): add docs on the
3283 as-yet-unimplemented Try scheduler
3285 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3286 * buildbot/test/test_scheduler.py: .. here
3287 (Scheduling.testTryJobdir): add placeholder test for 'try'
3289 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3290 addEntry merging (>=chunkSize) behavior
3291 (Log.testConsumer): update to handle new callLater(0) behavior
3293 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3294 both the MAX_LENGTH bugfix and the resumeProducing hang.
3296 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3297 put off the actual resumeProducing for a moment with
3298 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3299 causes large logfiles to hang midway through.
3301 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3302 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3303 and to improve memory usage when streaming the file out to a web
3305 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3306 make this work cleanly
3308 2005-08-03 Brian Warner <warner@lothar.com>
3310 * buildbot/trybuild.py: new file for 'try' utilities
3311 (getSourceStamp): run in a tree, find out the baserev+patch
3312 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3313 implemented for SVN and Darcs, still working on Arch. I don't know
3314 how to make CVS work yet.
3316 * docs/buildbot.texinfo: document the 'buildbot' command-line
3317 tool, including the not-yet-implemented 'try' feature, and the
3318 in-flux .buildbot/ options directory.
3320 2005-07-20 Brian Warner <warner@lothar.com>
3322 * buildbot/locks.py: added temporary id() numbers to Lock
3323 descriptions, to track down a not-really-sharing-the-Lock bug
3325 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3327 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3328 needed for python2.2 compatibility
3329 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3330 are from the __future__
3332 2005-07-19 Brian Warner <warner@lothar.com>
3334 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3335 message when schedulers use unknown builders
3337 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3338 SlaveLock('name') and MasterLock('name') are distinct
3340 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3341 c['schedulers'] in such a way that we can actually accept
3343 * buildbot/test/test_config.py: check it
3345 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3346 utility method to *all* the Schedulers
3347 (Periodic.listBuilderNames): same
3349 * docs/buildbot.texinfo (Interlocks): update chapter to match
3352 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3353 to make sure that c['sources'], c['schedulers'], and c['status']
3354 are all lists of the appropriate objects, and that the Schedulers
3355 all point to real Builders
3356 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3357 'listBuilderNames' utility method to support this
3358 * buildbot/scheduler.py: implement the utility method
3359 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3361 * docs/buildbot.texinfo: add some @cindex entries
3363 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3364 if it wasn't already set: most tla commands will fail unless one
3366 (Arch.createRepository): and disable bazaar's revision cache, since
3367 they cause test failures (the multiple repositories we create all
3368 interfere with each other through the cache)
3370 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3371 bring it properly up to date with twisted-2.0 test guidelines
3373 * buildbot/master.py (BuildMaster): remove references to old
3374 'interlock' module, this caused a bunch of post-merge test
3376 * buildbot/test/test_config.py: same
3377 * buildbot/process/base.py (Build): same
3379 * buildbot/test/test_slaves.py: stubs for new test case
3381 * buildbot/scheduler.py: add test-case-name tag
3382 * buildbot/test/test_buildreq.py: same
3384 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3385 unnecessary init code
3386 (Bot.remote_setBuilderList): match it
3388 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3390 * buildbot/changes/mail.py (parseSyncmail): update comment
3392 * buildbot/test/test_slavecommand.py: disable Shell tests on
3393 platforms that don't suport IReactorProcess
3395 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3396 all places where we open logfiles. It causes OS-X to open the file
3397 in some weird mode that that prevents us from mixing reads and
3398 writes to the same filehandle, which we depend upon to implement
3399 _generateChunks properly. This change doesn't appear to break
3400 win32, on which "b" and "t" are treated differently but a missing
3401 flag seems to be interpreted as "t".
3403 2005-07-18 Brian Warner <warner@lothar.com>
3405 * buildbot/slave/commands.py (ShellCommand): overhaul
3406 error-handling code, to try and make timeout/interrupt work
3407 properly, and make win32 happier
3408 * buildbot/test/test_slavecommand.py: clean up, stop using
3409 reactor.iterate, add tests for timeout and interrupt
3410 * buildbot/test/sleep.py: utility for a new timeout test
3412 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3413 code from the local-usebranches branch
3415 2005-07-17 Brian Warner <warner@lothar.com>
3417 * buildbot/process/process_twisted.py
3418 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3419 minutes, to match the other twisted BuildFactories, and don't
3420 excuse failures in c/qt/win32 reactors any more.
3422 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3423 'freebsd' builders, since the buildslaves have been unavailable
3426 2005-07-13 Brian Warner <warner@lothar.com>
3428 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3429 build-on-branch feature
3431 * buildbot/process/step.py (Darcs.__init__): add base_url and
3432 default_branch arguments, just like SVN
3433 (Arch.__init__): note that the version= argument is really the
3436 * buildbot/slave/commands.py (SourceBase): keep track of the
3437 repository+branch that was used for the last checkout in
3438 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3439 match, we clobber the directory and perform a fresh checkout
3440 rather than trying to do an in-place update. This should protect
3441 us against trying to get to branch B by doing an update in a tree
3442 obtained from branch A.
3443 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3444 (SVN.setup): same, just the svnurl
3445 (Darcs.setup): same, just the repourl
3446 (Arch.setup): same, arch coordinates (url), version, and
3447 buildconfig. Also pull the buildconfig from the args dictionary,
3448 which we weren't doing before, so the build-config was effectively
3450 (Arch.sourcedirIsUpdateable): don't try to update when we're
3451 moving to a specific revision: arch can't go backwards, so it is
3452 safer to just clobber the tree and checkout a new one at the
3454 (Bazaar.setup): same sourcedata as Arch
3456 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3457 use maybeWait, to work with twisted-1.3.0 and twcompat
3458 (Dependencies.testRun_Pass): same
3460 * buildbot/test/test_vc.py: rearrange, cleanup
3462 * buildbot/twcompat.py: add defer.waitForDeferred and
3463 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3464 can work under twisted-1.3.0 .
3466 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3467 now created at setUp time. This increases the runtime of the test
3468 suite considerably (from 91 seconds to 151), but it removes the
3469 need for an offline tarball, which should solve a problem I've
3470 seen where the test host has a different version of svn than the
3471 tarball build host. The new code also validates that mode=update
3472 really picks up recent commits. This approach will also make it
3473 easier to test out branches, because the code which creates the VC
3474 branches is next to the code which uses them. It will also make it
3475 possible to test some change-notification hooks, by actually
3476 performing a VC commit and watching to see the ChangeSource get
3479 2005-07-12 Brian Warner <warner@lothar.com>
3481 * docs/buildbot.texinfo (SVN): add branches example
3482 * docs/Makefile (buildbot.ps): add target for postscript manual
3484 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3485 * buildbot/test/test_locks.py: same
3487 * buildbot/process/step.py (Darcs): comment about default branches
3489 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3490 c['interlocks'] in the config file, complain if it is present.
3491 Scan all locks in c['builders'] to make sure the Locks they use
3493 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3494 add some tests to check for non-uniquely-named Locks
3495 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3496 since the unique-Lock validation code requires it now
3498 * buildbot/locks.py: fix test-case-name
3500 * buildbot/interlock.py: remove old file
3502 2005-07-11 Brian Warner <warner@lothar.com>
3504 * buildbot/test/test_interlock.py: rename to..
3505 * buildbot/test/test_locks.py: .. something shorter
3507 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3508 versions (after 2.0.1) changed internet.TCPClient to shut down the
3509 connection in stopService. Change the code to handle this
3512 * buildbot/process/base.py (Build): handle whole-Build locks
3513 * buildbot/process/builder.py (Builder.compareToSetup): same
3514 * buildbot/test/test_interlock.py: make tests work
3516 * buildbot/process/step.py (BuildStep.startStep): complain if a
3517 Step tries to claim a lock that's owned by its own Build
3518 (BuildStep.releaseLocks): typo
3520 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3521 file reloads don't replace unchanged Builders
3523 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3524 rewrite to cover new Locks instead of old c['interlocks']
3525 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3529 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3530 start the master and connect the buildslave
3532 * buildbot/process/step.py (FailingDummy.done): finish with a
3533 FAILURE status rather than raising an exception
3535 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3536 stringify a BuildRequest.reason that is None
3538 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3540 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3541 allow scheduler.Dependent to work
3542 * buildbot/buildset.py (BuildSet): set .reason and .results
3544 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3545 slaves, to make the test stop hanging. It still fails, of course,
3546 because I haven't even started to implement Locks.
3548 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3550 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3551 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3552 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3553 (Dependent): new class for downstream build dependencies
3554 * buildbot/test/test_dependencies.py: tests (still failing)
3556 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3558 2005-07-07 Brian Warner <warner@lothar.com>
3560 * buildbot/test/runutils.py (RunMixin): factored this class out..
3561 * buildbot/test/test_run.py: .. from here
3562 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3563 added new buildbot.locks tests (which all hang right now)
3564 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3565 * buildbot/process/step.py: claim/release per-BuildStep locks
3567 * docs/Makefile: add 'buildbot.html' target
3569 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3570 interpreted as "HEAD", so that all VC steps can accept branch=None
3571 and have it mean the "default branch".
3573 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3575 2005-07-07 Brian Warner <warner@lothar.com>
3577 * docs/examples/twisted_master.cfg: update to match current usage
3579 * docs/buildbot.texinfo (System Architecture): comment out the
3580 image, it doesn't exist yet and just screws up the HTML manual.
3582 2005-07-05 Brian Warner <warner@lothar.com>
3584 * debian/.cvsignore: oops, missed one. Removing leftover file.
3586 2005-06-17 Brian Warner <warner@lothar.com>
3588 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3589 changed its output in 1.2.0, don't mistakenly think that the
3590 subversion we find isn't capable of supporting our tests.
3592 * debian/*: remove the debian/ directory and its contents, to make
3593 life easier for the proper Debian maintainer
3595 * Makefile (release): same
3597 2005-06-07 Brian Warner <warner@lothar.com>
3599 * everything: create a distinct SourceStamp class to replace the
3600 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3601 Changed the signature of Source.startVC to include the revision
3602 information (instead of passing it through self.args). Implement
3603 branches for SVN (now only Darcs/Git is missing support). Add more
3606 2005-06-06 Brian Warner <warner@lothar.com>
3608 * everything: rearrange build scheduling. Create a new Scheduler
3609 object (configured in c['schedulers'], which submit BuildSets to a
3610 set of Builders. Builders can now use multiple slaves. Builds can
3611 be run on alternate branches, either requested manually or driven
3612 by changes. This changed some of the Status classes. Interlocks
3613 are out of service until they've been properly split into Locks
3614 and Dependencies. treeStableTimer, isFileImportant, and
3615 periodicBuild have all been moved from the Builder to the
3617 (BuilderStatus.currentBigState): removed the 'waiting' and
3618 'interlocked' states, removed the 'ETA' argument.
3620 2005-05-24 Brian Warner <warner@lothar.com>
3622 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3623 erroneously abandons the connection (in clientConnectionFailed)
3624 for non-UserErrors, which means that if we lose the connection due
3625 to a network problem or a timeout, we'll never try to reconnect.
3626 Fix this by not upcalling to the buggy parent method. Note:
3627 twisted-2.0 fixes this, but the function only has 3 lines so it
3628 makes more sense to copy it than to try and detect the buggyness
3629 of the parent class. Fixes SF#1207588.
3631 * buildbot/changes/changes.py (Change.branch): doh! Add a
3632 class-level attribute to accomodate old Change instances that were
3633 pickled before 0.6.5 (where .branch was added for new Changes).
3634 This fixes the exception that occurs when you try to look at an
3635 old Change (through asHTML).
3637 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3640 2005-05-23 Brian Warner <warner@lothar.com>
3642 * buildbot/__init__.py (version): release 0.6.6
3644 2005-05-23 Brian Warner <warner@lothar.com>
3646 * NEWS: update for 0.6.6 release
3647 * debian/changelog: same
3649 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3650 before starting: this was done by twistd back when we spawned it,
3651 now that we're importing the pieces and running them in the
3652 current process, we have to do it ourselves. This allows
3653 master.cfg to import files from the same directory without
3654 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3655 Stichele for the catch.
3656 (Options.opt_version): Add a --version command (actually, just make
3657 the existing --version command emit Buildbot's version too)
3659 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3660 fix to make this behave like other LogFiles, this time to handle
3661 existing LogFiles on disk. (add the missing .upgrade method)
3662 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3664 2005-05-21 Brian Warner <warner@lothar.com>
3666 * buildbot/test/test_runner.py (Create.testMaster): match the
3667 rawstring change in runner.py:masterTAC
3669 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3670 TwistedWords is installed
3671 * buildbot/test/test_status.py: same, with TwistedMail
3673 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3674 some old, deprecated, and removed config keys). This should enable
3675 you to use the base buildbot functionality with Twisted-2.0.0 when
3676 you don't also have TwistedWeb and TwistedWords installed
3678 2005-05-20 Brian Warner <warner@lothar.com>
3680 * buildbot/scripts/runner.py (run): call sendchange(), not
3681 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3682 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3683 (stop): don't wait for process to die when sending SIGHUP
3684 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3685 directory name gets interpreted, which you don't want
3688 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3691 2005-05-18 Brian Warner <warner@lothar.com>
3693 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3695 2005-05-18 Brian Warner <warner@lothar.com>
3697 * README: update for 0.6.5
3698 * debian/changelog: same
3700 * buildbot/changes/changes.py: rename tag= to branch=, since
3701 that's how we're using it, and my design for the upcoming "build a
3702 specific branch" feature wants it. also, tag= was too CVS-centric
3703 * buildbot/changes/mail.py (parseSyncmail): same
3704 * buildbot/process/base.py (Build.isBranchImportant): same
3705 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3706 * docs/buildbot.texinfo (Attributes of Changes): same
3708 * NEWS: update tag=, update for upcoming release
3710 2005-05-17 Brian Warner <warner@lothar.com>
3712 * buildbot/scripts/runner.py (stop): actually poll once per
3713 second, instead of re-killing the poor daemon once per second.
3714 Sleep briefly (0.1s) before the first poll, since there's a good
3715 chance we can avoid waiting the full second if the daemon shuts
3716 down quickly. Also remove the sys.exit() at the end.
3717 (start): remove the unneighborly sys.exit()
3719 * Makefile: improve permission-setting to not kick Arch so badly
3721 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3722 default --keepalive=600, since it doesn't hurt very much, and it's
3723 a hassle to discover that you need it.
3724 * buildbot/test/test_runner.py (Create.testSlave): test it
3726 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3727 IRC bot about EXCEPTION
3729 * buildbot/status/client.py (PBListener): upcall more correctly
3731 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3732 an exception mark the overall build with EXCEPTION, not SUCCESS
3734 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3736 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3737 * Makefile: update some release-related stuff
3739 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3740 gets called when there isn't actually an active process, just end
3741 the Command instead of blowing up. I don't know how it gets into
3742 this state, but the twisted win32 buildslave will sometimes hang,
3743 and when it shakes its head and comes back, it thinks it's still
3744 running a Command. The next build causes this command to be
3745 interrupted, but the lack of self.process.pid breaks the interrupt
3748 * NEWS: document changes since the last release
3750 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3751 look for Makefile.buildbot instead of a bare Makefile . The
3752 'buildbot start' does not install this file, so you have to
3753 manually copy it if you want to customize startup behavior.
3754 (createMaster): change 'buildbot master' command to create
3755 Makefile.sample instead of Makefile, to create master.cfg.sample
3756 instead of master.cfg (requiring you to copy it before the
3757 buildmaster can be started). Both sample files are kept up to
3758 date, i.e. they are overwritten if they have been changed. The
3759 'buildbot.tac' file is *not* overwritten, but if the new contents
3760 don't match the old, a 'buildbot.tac.new' file is created and the
3761 user is warned. This seems to be a much more sane way to handle
3762 startup files. Also, don't sys.exit(0) when done, so we can run
3763 unit tests against it.
3764 (createSlave): same. Don't overwrite the sample info/ files.
3765 * buildbot/scripts/sample.mk: remove. the contents were pulled
3766 into runner.py, since they need to match the behavior of start()
3770 * docs/buildbot.texinfo (Launching the daemons): document it
3771 * buildbot/test/test_runner.py (Create): test it
3773 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3774 version that can handle string-in-string tests, because otherwise
3775 python-2.2 fails the tests. It'd be tremendous if Trial's test
3776 took two strings under 2.2 too.
3778 * everything: fixed all deprecation warnings when running against
3779 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3780 few that come from Twisted itself). This involved putting most of
3781 the Twisted-version specific code in the new buildbot.twcompat
3782 module, and creating some abstract base classes in
3783 buildbot.changes.base and buildbot.status.base (which might be
3784 useful anyway). __implements__ is a nuisance and requires an ugly
3785 'if' clause everywhere.
3787 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3788 delay before finishing the test: it seems that smtp.sendmail
3789 doesn't hang up on the server, so we must wait a moment so it can
3790 hang up on us. This removes the trial warning about an unclean
3793 2005-05-16 Brian Warner <warner@lothar.com>
3795 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3796 tuple of (delay, repeats).
3797 * buildbot/test/test_vc.py (Retry): test it
3798 * docs/buildbot.texinfo (Source Checkout): document it
3799 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3800 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3801 doVCFull() are handled by re-trying the checkout (after a delay)
3802 some number of times.
3803 (ShellCommand._startCommand): make header lines easier to read
3805 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3807 (WebTest.test_logfile): make sure master gets shut down, silences
3808 some "unclean reactor" test errors
3810 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3811 reactor once after shutdown, something in certain versions of
3812 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3813 fails, svn-trunk is ok.
3815 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3816 second win32 error message
3818 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3819 validating the ETA, so the tests don't fail on slow systems
3821 2005-05-15 Brian Warner <warner@lothar.com>
3823 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3824 the new LogFile class, so upgrading works properly
3825 (LogFileProducer.resumeProducing): survive resumeProducing after
3826 we've exhausted the chunkGenerator
3828 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3830 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3831 (Log.testUpgrade): same
3833 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3834 Builds and logs with a cron job.
3836 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3837 of the old non-offline LogFile, added code to upgrade these to
3838 new-style contents-live-on-disk instances at load time (in a way
3839 that doesn't invalidate the old Build pickles, so upgrading to
3840 0.6.5 is not a one-way operation). Got rid of everything related
3842 (LogFile.__init__): create LogFiles with the parent step status,
3843 the log's name, and a builder-relative filename where it can keep
3844 the contents on disk.
3845 (LogFile.hasContents): new method, clients are advised to call it
3846 before getText or getChunks and friends. If it returns False, the
3847 log's contents have been deleted and getText() will raise an
3849 (LogFile.getChunks): made it a generator
3850 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3851 Consumer (except one that takes chunks instead of strings). This
3852 enables streaming of very large logfiles without storing the whole
3854 (BuildStatus.generateLogfileName): create names like
3855 12-log-compile-output, with a _0 suffix if required to be unique
3856 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3857 or earlier) logfiles into new-style ones
3858 (BuilderStatus): remove everything related to 'stub' builds. There
3859 is now only one build cache, and we don't strip logs from old
3861 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3862 since we no longer fight to keep it in the cache
3864 * buildbot/status/html.py (TextLog.render_GET): use a
3865 ChunkConsumer to stream the log entries efficiently.
3866 (ChunkConsumer): wrapper which consumes chunks and writes
3869 * buildbot/test/test_twisted.py (Parse.testParse): use a
3870 LogFile-like object instead of a real one
3872 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3873 (Log.testMerge3): validate more merge behavior
3874 (Log.testChunks): validate LogFile.getChunks
3875 (Log.testUpgrade): validate old-style LogFile upgrading
3876 (Log.testSubscribe): validate LogFile.subscribe
3877 (Log.testConsumer): validate LogFile.subscribeConsumer
3879 * buildbot/interfaces.py (IStatusLogStub): remove
3880 (IStatusLog.subscribeConsumer): new method
3881 (IStatusLog.hasContents): new method
3882 (IStatusLogConsumer): describes things passed to subscribeConsumer
3884 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3885 the log contents if it does not have any contents.
3886 (StatusResourceBuildStep.body): same
3887 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3889 2005-05-14 Brian Warner <warner@lothar.com>
3891 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3892 timeouts to try and make the windows metabuildslave not hang
3894 2005-05-13 Mike Taylor <bear@code-bear.com>
3896 * buildbot/slave/commands.py (rmdirRecursive): added a check
3897 to ensure the path passed into rmdirRecursive actually exists.
3898 On win32 a non-existant path would generate an exception.
3900 2005-05-13 Brian Warner <warner@lothar.com>
3902 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3903 shutil.rmtree which behaves correctly on windows in the face of
3904 files that you have to chmod before deleting. Thanks to Bear at
3905 the OSAF for the routine.
3906 (SourceBase.doClobber): use rmdirRecursive
3908 2005-05-12 Brian Warner <warner@lothar.com>
3910 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3911 method generate chunks instead of returning a big list. This
3912 allows the same method to be used for both old LogFile and new
3914 (OfflineLogFile.getText): use the generator
3915 (OfflineLogFile.subscribe): same
3916 * buildbot/status/html.py (TextLog.resumeProducing): same
3917 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3919 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3920 point out that OfflineLogFile does not currently work with
3921 html.Waterfall . Fixing this is high-priority.
3923 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3924 apparently windows defaults to using stdout
3926 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3927 better message on failure so I can figure out the win32 problem
3929 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3930 log messages to include more useful copies of the command being
3931 run, the argv array, and the child command's environment.
3932 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3934 2005-05-11 Brian Warner <warner@lothar.com>
3936 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3938 * Makefile: update the deb-snapshot version
3940 * docs/buildbot.texinfo: move all .xhtml docs into a new
3941 .texinfo-format document, adding a lot of material in the process.
3942 This is starting to look like a real user's manual. Removed all
3943 the Lore-related files: *.xhtml, *.css, template.tpl .
3944 * docs/Makefile: simple makefile to run 'makeinfo'
3945 * buildbot/scripts/sample.cfg: rearrange slightly
3946 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3948 2005-05-10 Brian Warner <warner@lothar.com>
3950 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3951 different name for the internal twistw module, handle it.
3953 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3954 * setup.py: .. and stop trying to install it
3956 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3957 'git'), the new linux kernel VC system (http://kernel.org/git/).
3958 Thanks to Brandon Philips for the patch.
3959 * buildbot/slave/commands.py (Git): same
3961 2005-05-06 Brian Warner <warner@lothar.com>
3963 * buildbot/status/builder.py (OfflineLogFile): replace the default
3964 LogFile with a form that appends its new contents to a disk file
3965 as they arrive. The complete log data is never kept in RAM. This
3966 is the first step towards handling very large (100MB+) logfiles
3967 without choking quite so badly. (The other half is
3968 producer/consumer on the HTML pages).
3969 (BuildStepStatus.addLog): use OfflineLogFile by default
3970 (BuildStatus.getLogfileName): helper code to give the
3971 OfflineLogFile a filename to work with
3973 * buildbot/test/test_status.py (Results.testAddResults): update
3974 tests to handle new asserts
3975 * buildbot/test/test_vc.py (Patch.doPatch): same
3976 * buildbot/test/test_steps.py (BuildStep.setUp): same
3978 2005-05-05 Brian Warner <warner@lothar.com>
3980 * buildbot/scripts/runner.py (start): if there is no Makefile,
3981 launch the app by importing twistd's internals and calling run(),
3982 rather than spawning a new twistd process. This stands a much
3983 better chance of working under windows.
3984 (stop): kill the process with os.kill instead of spawning
3985 /bin/kill, again to reduce the number of external programs which
3986 windows might not have in the PATH. Also wait up to 5 seconds for
3987 the process to go away, allowing things like 'buildbot stop;
3988 buildbot start' to be reliable in the face of slow shutdowns.
3990 * buildbot/master.py (Dispatcher.__getstate__): remove old
3991 .tap-related methods
3992 (BuildMaster.__getstate__): same
3994 * buildbot/slave/bot.py (makeService): same
3995 (Options.longdesc): same
3996 * buildbot/scripts/runner.py: copy over some old mktap option text
3998 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3999 'buildbot master' now creates a buildbot.tac file, so there is no
4000 longer a create-instance/save/reload sequence. mktap is dead, long
4002 * buildbot/scripts/sample.mk: use twistd -y, not -f
4003 * buildbot/test/test_config.py: remove mktap-based test
4004 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4005 * README: don't reference mktap
4007 * docs/source.xhtml: document some of the attributes that Changes
4010 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4012 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4013 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4014 * buildbot/changes/changes.py (Change)
4015 * buildbot/changes/mail.py (parseSyncmail)
4016 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4018 * buildbot/process/base.py (Build.isTagImportant)
4022 2005-05-04 Brian Warner <warner@lothar.com>
4024 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4025 connection after sending the change, so that unit tests don't
4026 complain about sockets being left around
4028 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4029 exception in phase=0 rendering
4030 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4032 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4034 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4035 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4036 and configuring builders with tuples.
4037 * buildbot/test/test_config.py: stop testing compatibility with
4038 deprecated config keys
4039 * buildbot/test/test_run.py: same
4041 2005-05-03 Brian Warner <warner@lothar.com>
4043 * contrib/arch_buildbot.py: survive if there are no logfiles
4044 (username): just use a string, os.getlogin isn't reliable
4046 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4047 so 'buildbot sendchange' actually works. The earlier test only
4048 covered the internal (non-reactor-running) form.
4050 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4051 script to notify the buildmaster about changes
4053 * buildbot/scripts/runner.py (sendchange): new command to send a
4054 change to a buildbot.changes.pb.PBChangeSource receiver.
4055 * buildbot/test/test_changes.py (Sender): test it
4057 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4058 after any reading of the config file, not just when we do it in
4059 startService. This makes some tests a bit cleaner.
4061 * buildbot/changes/pb.py: add some log messages
4063 * buildbot/process/base.py (Build.startBuild): fix a bug that
4064 caused an exception when the build terminated in the very first
4066 (Build.stepDone): let steps return a status of EXCEPTION. This
4067 terminates the build right away, and sets the build's overall
4068 status to EXCEPTION too.
4069 * buildbot/process/step.py (BuildStep.failed): return a status of
4070 EXCEPTION when that is what has happened.
4072 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4073 implement this, allowing Arch-based projects to get precise
4074 checkouts instead of always using the latest code
4075 (Bazaar): create variant of Arch to let folks use baz instead of
4076 tla. Requires a new buildslave too.
4077 * buildbot/slave/commands.py (Arch): add 'revision' argument
4078 (Bazaar): create variant of Arch that uses baz instead of tla.
4079 Remove the code that extracts the archive name from the
4080 register-archive output, since baz doesn't provide it, and require
4081 the user provide both the archive name and its location.
4082 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4084 2005-05-02 Brian Warner <warner@lothar.com>
4086 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4087 thanks to Nick Trout.
4089 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4090 deals better with source Makefile coming from a read-only CVS
4091 checkout. Thanks to Nick Trout for the catch.
4093 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4096 2005-04-28 Brian Warner <warner@lothar.com>
4098 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4100 * debian/changelog: update for 0.6.4
4102 2005-04-28 Brian Warner <warner@lothar.com>
4104 * README.w32: add a checklist of steps for getting buildbot
4106 * MANIFEST.in: include it in the tarball
4110 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4111 broken .tap files from 0.6.3 by getting rid of .services,
4112 .namedServices, and .change_svc at load time.
4114 2005-04-27 Brian Warner <warner@lothar.com>
4116 * NEWS: update in preparation for new release
4118 * buildbot/test/test_config.py (Save.testSave): don't pull in
4119 twisted.scripts.twistd, we don't need it and it isn't for windows
4122 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4123 accomodate win32 which can't do atomic-rename
4125 2005-04-27 Brian Warner <warner@lothar.com>
4127 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4128 timeouts to help the slow metabuildbot not flunk them so much
4129 (Disconnect.testBuild3): same
4130 (Disconnect.testBuild4): same
4131 (Disconnect.testInterrupt): same
4133 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4134 setup, it was completely broken for new buildmasters (those which
4135 did not have a 'change.pck' already saved. Thanks to Paul Warren
4136 for catching this (embarrassing!) bug.
4137 (Dispatcher.__getstate__): don't save our registered avatar
4138 factories, since they'll be re-populated when the config file is
4140 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4141 tests (since the real mktap-generated BuildMaster doesn't save
4143 (BuildMaster.__getstate__): don't save any service children,
4144 they'll all be re-populated when the config file is re-read.
4145 * buildbot/test/test_config.py (Save.testSave): test for this
4147 2005-04-26 Brian Warner <warner@lothar.com>
4149 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4150 rendered with Blender.. looks a bit nicer.
4151 * buildbot/docs/images/icon.blend: add the Blender file for it
4153 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4154 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4155 running under windows. This appears to be the best way to allow
4156 BuildSteps to do something normal like 'trial -v buildbot.test' or
4157 'make foo' and still expect it to work. The idea is to make the
4158 BuildSteps look as much like what a developer would type when
4159 compiling or testing the tree by hand. This approach probably has
4160 problems when there are spaces in the arguments, so if you've got
4161 windows buildslaves, you'll need to pay close attention to your
4164 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4165 timezone to the timestamp column.
4166 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4168 * buildbot/scripts/runner.py (loadOptions): do something sane for
4169 windows, I think. We use %APPDATA%/buildbot instead of
4170 ~/.buildbot, but we still search everywhere from the current
4171 directory up to the root for a .buildbot/ subdir. The "is it under
4172 $HOME" security test was replaced with "is it owned by the current
4173 user", which is only performed under posix.
4174 * buildbot/test/test_runner.py (Options.testFindOptions): update
4175 tests to match. The "is it owned by the current user" check is
4176 untested. The test has been re-enabled for windows.
4178 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4179 any "\n" in the expected output with the platform-specific line
4180 separator. Make this separator "\r\n" on PTYs under unix, they
4181 seem to do that and I don't know why
4183 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4184 windows for now, I don't know what ~/.buildbot/ should mean there.
4186 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4187 win32 compatibility, don't use "/tmp"
4188 (Basedir.testChangeBuilddir): remove more unixisms
4190 2005-04-26 Brian Warner <warner@lothar.com>
4192 * buildbot/test/test_control.py (Force.rmtree): python2.2
4193 compatibility, apparently its shutil.rmtree ignore_errors=
4194 argument is ignored.
4195 * buildbot/test/test_run.py (Run.rmtree): same
4196 (RunMixin.setUp): same
4198 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4201 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4202 'substring in string' operator, must use string.find(substr)!=-1
4203 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4204 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4206 * buildbot/scripts/runner.py (loadOptions): add code to search for
4207 ~/.buildbot/, a directory with things like 'options', containing
4208 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4209 the current directory, your $HOME directory, or anywhere
4210 inbetween, as long as you're somewhere inside your home directory.
4211 (debugclient): look in ~/.buildbot/options for master and passwd
4212 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4213 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4215 * buildbot/status/client.py (makeRemote): new approach to making
4216 IRemote(None) be None, which works under Twisted-2.0
4217 * buildbot/test/test_status.py (Client.testAdaptation): test it
4219 * buildbot/status/builder.py (Status.builderAdded): when loading a
4220 pickled BuilderStatus in from disk, set its name after loading.
4221 The config file might have changed its name (but not its
4222 directory) while it wasn't looking.
4224 * buildbot/process/builder.py (Builder.attached): always return a
4225 Deferred, even if the builder was already attached
4226 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4228 2005-04-25 Brian Warner <warner@lothar.com>
4230 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4231 category-related exception when announcing a build has finished
4233 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4234 reference no-longer-existent changemaster.sources
4235 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4237 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4240 2005-04-25 Brian Warner <warner@lothar.com>
4242 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4244 * debian/changelog: update for 0.6.3
4246 2005-04-25 Brian Warner <warner@lothar.com>
4248 * MANIFEST.in: make sure debug.glade is in the tarball
4250 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4252 * NEWS: update for the imminent 0.6.3 release
4254 * buildbot/status/html.py (HtmlResource.content): make the
4255 stylesheet <link> always point at "buildbot.css".
4256 (StatusResource.getChild): map "buildbot.css" to a static.File
4257 containing whatever css= argument was provided to Waterfall()
4258 (Waterfall): provide the "classic" css as the default.
4259 * docs/waterfall.classic.css: move default CSS from here ..
4260 * buildbot/status/classic.css: .. to here
4262 * MANIFEST.in: make sure classic.css is included in the tarball
4263 * setup.py: and that it is installed too, under buildbot/status/
4265 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4266 the module level, because buildbot.tap files from 0.6.2 don't have
4267 it in their attribute dictionary.
4269 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4270 really exists at startup, might save some confusion somewhere.
4272 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4274 * docs/waterfall.classic.css:
4275 add a stylesheet that's almost the same as the "classic"
4278 * buildbot/status/builder.py:
4279 add EXCEPTION as a result - this is a problem for the bot
4280 maintainer, not a build problem for the changers
4281 * buildbot/process/step.py:
4282 use EXCEPTION instead of FAILURE for exceptions
4283 * buildbot/status/html.py:
4284 add build_get_class to get a class out of a build/buildstep
4285 finish naming the classes
4286 split out sourceNames to changeNames and builderNames so we
4287 can style them separately
4288 * docs/config.xhtml:
4289 finish documenting classes as they are right now
4291 * buildbot/status/html.py:
4292 name the classes as we agreed on IRC
4293 * docs/config.xhtml:
4296 * buildbot/status/html.py:
4297 same for cssclass->class_
4299 * buildbot/status/html.py:
4300 as decided on IRC, use class_ for the "class" attribute to not
4301 conflict with the class keyword, and clean up the messy **{} stuff.
4303 * buildbot/status/mail.py:
4304 put back "builders" argument, and fix docstring, because the
4305 code *ignores* builders listed in this argument
4307 * buildbot/process/builder.py:
4308 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4310 * docs/config.xhtml:
4311 describe the category argument for builders
4313 * buildbot/status/builder.py:
4314 Fix a silly bug due to merging
4316 * buildbot/process/builder.py:
4317 remove category from the process Builder ...
4318 * buildbot/status/builder.py:
4319 ... and add it to BuilderStatus instead.
4320 Set category on unpickled builder statuses, they might not have it.
4321 * buildbot/master.py:
4322 include category when doing builderAdded
4323 * buildbot/status/mail.py:
4324 return None instead of self for builders we are not interested in.
4325 * buildbot/test/test_run.py:
4326 fix a bug due to only doing deferredResult on "dummy" waiting
4327 * buildbot/test/test_status.py:
4328 add checks for the Mail IStatusReceiver returning None or self
4330 * buildbot/status/html.py:
4331 fix testsuite by prefixing page title with BuildBot
4333 * buildbot/status/builder.py:
4334 have .category in builder status ...
4335 * buildbot/process/builder.py:
4336 ... and set it from Builder
4337 * buildbot/status/html.py:
4338 make .css a class variable
4339 * buildbot/test/test_status.py:
4340 write more tests to cover our categories stuff ...
4341 * buildbot/status/mail.py:
4342 ... and fix the bug that this uncovered
4344 * buildbot/changes/mail.py:
4345 * buildbot/changes/pb.py:
4346 * buildbot/master.py:
4347 * buildbot/process/base.py:
4348 * buildbot/process/factory.py:
4349 * buildbot/process/interlock.py:
4350 * buildbot/process/step.py:
4351 * buildbot/process/step_twisted.py:
4352 * buildbot/slave/commands.py:
4353 * buildbot/status/builder.py:
4354 * buildbot/status/client.py:
4355 * buildbot/status/html.py:
4356 * buildbot/status/mail.py:
4357 * buildbot/status/progress.py:
4358 * buildbot/test/test_changes.py:
4359 * buildbot/test/test_config.py:
4360 * buildbot/test/test_control.py:
4361 * buildbot/test/test_interlock.py:
4362 * buildbot/test/test_maildir.py:
4363 * buildbot/test/test_mailparse.py:
4364 * buildbot/test/test_run.py:
4365 * buildbot/test/test_slavecommand.py:
4366 * buildbot/test/test_status.py:
4367 * buildbot/test/test_steps.py:
4368 * buildbot/test/test_twisted.py:
4369 * buildbot/test/test_util.py:
4370 * buildbot/test/test_vc.py:
4371 * buildbot/test/test_web.py:
4373 add test-case-name at the top of a whole set of files
4375 * buildbot/status/builder.py:
4376 keep order of addition when getting builder names
4377 * buildbot/status/words.py:
4378 * buildbot/test/test_run.py:
4379 add test for getBuilderNames
4381 * buildbot/process/base.py:
4382 * buildbot/process/step.py:
4383 * buildbot/status/builder.py:
4384 * buildbot/status/html.py:
4385 make buildbot css-able
4386 replace the color code for purple with purple, don't understand
4387 why it wasn't purple to start with
4389 * buildbot/status/words.py:
4390 ok, so it doesn't look like BuilderStatus.remote is still valid.
4391 Use what waterfall uses instead.
4393 * buildbot/interfaces.py:
4394 * buildbot/status/builder.py:
4395 * buildbot/status/html.py:
4396 * buildbot/status/mail.py:
4397 * buildbot/status/words.py:
4398 * buildbot/test/test_run.py:
4399 use categories everywhere and make it be a list. More sensible
4400 for the future. Also make words actually respect this in
4403 * buildbot/interfaces.py:
4404 add category argument to getBuilderNames
4405 * buildbot/process/builder.py:
4406 * buildbot/status/builder.py:
4407 * buildbot/status/html.py:
4408 * buildbot/status/mail.py:
4409 * buildbot/status/words.py:
4410 * buildbot/test/test_run.py:
4411 move from specifying builders by name to specifying the category
4413 * buildbot/status/html.py:
4414 * buildbot/status/words.py:
4415 add "builders=" to __init__ of status clients so they can
4416 limit themselves to the given list of builders to report on
4418 * buildbot/status/html.py: set the title to the product name
4420 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4422 * buildbot/interfaces.py:
4423 * buildbot/status/builder.py:
4424 more documentation. Hm, not sure if ChangeLog entries make sense
4427 2005-04-23 Brian Warner <warner@lothar.com>
4429 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4431 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4433 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4434 the sub-commands that log buildmaster status to stdout and to a
4435 GUI window, respectively.
4437 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4438 functionality is working again, but all the step-status and ETA
4439 stuff is missing. Commented out a lot of code pending more
4442 * buildbot/status/client.py: make sure that IRemote(None) is None
4444 * buildbot/changes/changes.py: import defer, oops
4445 (ChangeMaster): remove the .sources list, rely upon the fact that
4446 MultiServices can be treated as sequences of their children. This
4447 cleans up the add/remove ChangeSource routines a lot, as we keep
4448 exactly one list of the current sources instead of three.
4450 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4451 up an empty ChangeMaster at init time.
4452 (BuildMaster.loadChanges): if there are changes to be had from
4453 disk, replace self.change_svc with the new ones. If not, keep
4454 using the empty ChangeMaster set up in __init__.
4455 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4456 instead of a separate list, makes the code a bit cleaner.
4457 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4458 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4459 Extend the test to make sure we can get rid of the sources when
4462 2005-04-22 Brian Warner <warner@lothar.com>
4464 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4465 and info/host files when making the slave directory
4467 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4468 whendone= argument, just return the Deferred and let the caller do
4469 what they want with it.
4470 (Disconnect.testBuild1): wait for shutdownSlave
4471 (Basedir.testChangeBuilddir): new test to make sure changes to the
4472 builddir actually get propagated to the slave
4474 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4475 explicit method, rather than passing the builddir in __init__ .
4476 Make sure to update self.basedir too, this was broken before.
4477 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4478 builders and for ones that have just had their builddir changed.
4479 (BotFactory): add a class-level .perspective attribute, so
4480 BuildSlave.waitUntilDisconnected won't get upset when the
4481 connection hasn't yet been established
4482 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4483 tests can reach through it to inspect the SlaveBuilders
4485 * buildbot/process/base.py (Build.buildException): explain the
4486 log.err with a log.msg
4487 * buildbot/process/builder.py (Builder.startBuild): same
4488 (Builder._startBuildFailed): improve error message
4490 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4491 occurred because we lost the brand-new connection, retry instead
4492 of giving up. If not, it's probably an authorization failure, and
4493 it makes sense to stop trying. Make sure we log.msg the reason
4494 that we're log.err'ing the failure, otherwise test failures are
4495 really hard to figure out.
4497 * buildbot/master.py: change loadConfig() to return a Deferred
4498 that doesn't fire until the change has been fully implemented.
4499 This means any connected slaves have been updated with the new
4500 builddir. This change makes it easier to test the code which
4501 actually implements this builddir-updating.
4502 (BotPerspective.addBuilder): return Deferred
4503 (BotPerspective.removeBuilder): same
4504 (BotPerspective.attached): same
4505 (BotPerspective._attached): same. finish with remote_print before
4506 starting the getSlaveInfo, instead of doing them in parallel
4507 (BotPerspective.list_done): same
4508 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4509 actually calling slave.disconnect()
4510 (BotMaster.addBuilder): same
4511 (BotMaster.removeBuilder): same
4512 (BuildMaster.loadConfig): same
4513 (BuildMaster.loadConfig_Slaves): same
4514 (BuildMaster.loadConfig_Sources): same
4515 (BuildMaster.loadConfig_Builders): same
4516 (BuildMaster.loadConfig_status): same
4518 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4519 a Deferred that fires when the source is finally removed
4521 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4522 the previous tree on win32, where we have to do it synchronously,
4523 make sure we return a Deferred anyway.
4524 (SourceBase.doCopy): same
4526 * buildbot/scripts/runner.py (statusgui): use the text client for
4527 now, while I rewrite the Gtk one
4528 * buildbot/clients/base.py: strip out old code, leaving just the
4529 basic print-message-on-event functionality. I also remove the
4530 ReconnectingPBClientFactory, but it does at least quit when it
4531 loses the connection instead of going silent
4533 2005-04-21 Brian Warner <warner@lothar.com>
4535 * Makefile: minor tweaks
4537 * NEWS: point out deprecation warnings, new features for
4540 * buildbot/master.py (BuildMaster.loadConfig): emit
4541 DeprecationWarnings for Builders defined with tuples. Rearrange
4542 code to facility removal of deprecated configuration keys in the
4545 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4546 'buildbot' command to put a little Makefile in the target that
4547 helps you re-create the buildbot.tap file, start or stop the
4548 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4549 all the files 0600, since they contain passwords.
4550 (start): if there is a Makefile, and /usr/bin/make exists, use
4551 'make start' in preference to a raw twistd command. This lets
4552 slave admins put things like PYTHONPATH variables in their
4553 Makefiles and have them still work when the slave is started with
4554 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4555 be nice to first try the 'make' command and only fall back to
4556 twistd if it fails. TODO: the Makefile's "start" command does not
4557 add the --reactor=win32 argument when running under windows.
4558 (Options.debugclient, Options.statusgui): add sub-commands to launch
4559 the debug client (formerly in contrib/debugclient.py) and the
4560 Gtk status application (currently broken)
4561 * buildbot/clients/debug.py: move from contrib/debugclient.py
4562 * buildbot/clients/debug.glade: same
4564 * buildbot/test/test_trial.py: remove it. This requires some
4565 functionality out of Twisted that isn't there yet, and until then
4566 having it around just confuses things.
4568 * buildbot/test/test_slavecommand.py (Shell): test both with and
4569 without PTYs, and make sure that command output is properly
4570 interleaved in the with-PTY case. I think the without-PTY test
4571 should pass on windows, where we never use PTYs anyway.
4573 2005-04-20 Brian Warner <warner@lothar.com>
4575 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4577 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4579 * NEWS: start creating entries for the next release
4581 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4583 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4584 (WebTest.test_webPathname): same
4585 (WebTest.test_webPathname_port): same
4586 (WebTest.test_waterfall): use the default favicon rather than
4587 rooting around the filesystem for it. Open the expected-icon file
4588 in binary mode, to make win32 tests happier (thanks to Nick Trout
4590 * buildbot/status/html.py (buildbot_icon): win32 portability
4592 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4593 win32-compatibility fixes from Nick Trout, the "file not found" message
4594 is different under windows
4595 (FakeSlaveBuilder.__init__): clean up setup a bit
4596 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4598 2005-04-19 Brian Warner <warner@lothar.com>
4600 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4601 skip-if-repositories-are-unavailable test to not kill the trial
4602 that comes with Twisted-1.3.0
4604 * setup.py: install buildbot.png icon file when installing code
4606 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4607 environment used by the command, at least on the child side.
4609 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4610 this method needs to be added and implemented because it gets
4611 called under heavy load. I don't quite understand the
4612 producer/consumer API enough to write it.
4613 (StatusResource.getChild): add a resource for /favicon.ico
4614 (Waterfall.__init__): add favicon= argument
4615 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4616 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4617 (WebTest.test_webPathname): same
4618 (WebTest.test_webPathname_port): same
4619 * docs/config.xhtml: mention favicon=
4620 * buildbot/buildbot.png: add a default icon, dorky as it is
4622 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4624 * buildbot/master.py:
4625 * buildbot/process/base.py:
4626 * buildbot/process/builder.py:
4627 * buildbot/process/interlock.py:
4628 * buildbot/status/builder.py:
4629 * buildbot/status/html.py:
4630 * buildbot/status/mail.py:
4631 * buildbot/status/words.py:
4632 new documentation while digging through the code
4634 2005-04-17 Brian Warner <warner@lothar.com>
4636 * general: try to fix file modes on all .py files: a+r, a-x,
4637 but let buildbot/clients/*.py be +x since they're tools
4639 * docs/epyrun (addMod): when an import fails, say why
4641 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4643 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4645 * buildbot/process/base.py:
4646 * buildbot/process/builder.py:
4647 * buildbot/status/builder.py:
4648 new documentation while digging through the code
4650 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4652 * buildbot/changes/changes.py:
4653 * buildbot/changes/p4poller.py:
4654 * buildbot/interfaces.py:
4655 * buildbot/process/base.py:
4656 * buildbot/process/builder.py:
4657 * buildbot/process/step.py:
4658 * buildbot/process/step_twisted.py:
4659 * buildbot/slave/bot.py:
4660 * buildbot/slave/commands.py:
4661 * buildbot/status/builder.py:
4662 fix all docstrings to make epydoc happy. In the process of fixing
4663 some, I also moved pieces of docs, and removed some deprecated
4666 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4668 * buildbot/process/builder.py:
4669 * buildbot/process/interlock.py:
4670 * buildbot/process/process_twisted.py:
4671 * buildbot/process/step.py:
4672 BuildProcess -> Build, as it looks like that's what happened
4673 * buildbot/process/base.py:
4674 * buildbot/process/factory.py:
4677 2005-04-17 Brian Warner <warner@lothar.com>
4679 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4680 update compile command to accomodate the Twisted split.. now
4681 instead of './setup.py build_ext -i', you do './setup.py all
4682 build_ext -i', to run build_ext over all sub-projects.
4683 (FullTwistedBuildFactory): same
4684 (TwistedReactorsBuildFactory): same
4686 * buildbot/status/html.py (TextLog.finished): null out self.req
4687 when we're done, otherwise the reference cycle of TextLog to .req
4688 to .notifications to a Deferred to TextLog.stop keeps them from
4689 being collected, and consumes a huge (610MB on pyramid at last
4690 check) amount of memory.
4692 2005-04-11 Brian Warner <warner@lothar.com>
4694 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4695 normalize the VC-repository location.. makes SVN happier with
4696 certain test environments.
4698 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4699 RemoteShellCommand gets its own .env dictionary, so that code in
4700 start() doesn't mutate the original. I think this should fix the
4701 step_twisted.Trial problem where multiple identical components
4702 kept getting added to PYTHONPATH= over and over again.
4704 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4705 adding epydoc-format docstrings to many classes. Thanks to Thomas
4706 Vander Stichele for the patches.
4707 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4708 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4709 * buildbot/slave/bot.py, commands.py, registry.py: same
4711 2005-04-05 Brian Warner <warner@lothar.com>
4713 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4714 preserve timestamps, helps incremental builds of large trees.
4715 Patch from Rene Rivera.
4717 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4718 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4721 2005-04-03 Brian Warner <warner@lothar.com>
4723 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4724 with one dict, apparently exec has some scoping bugs when used
4725 with both global/local dicts. Thanks to Nathaniel Smith for the
4728 2005-04-02 Brian Warner <warner@lothar.com>
4730 * buildbot/process/step_twisted.py (countFailedTests): the new
4731 trial in Twisted-2.0 emits a slightly different status line than
4732 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4733 mistakenly think the test count is unparseable.
4734 (Trial.start): note that for some reason each build causes another
4735 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4736 be fixed but I'm not sure quite where the problem is.
4738 2005-04-01 Brian Warner <warner@lothar.com>
4740 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4741 deferredResult to avoid hangs/warnings under twisted-2.0
4742 (RunMixin.tearDown): same
4743 (RunMixin.shutdownSlave): same
4744 (Disconnect.testIdle1): same
4745 (Disconnect.testBuild2): same: wait one second after the build
4746 finishes for test to really be done.. this should be cleaned up to
4747 avoid wasting that second. Builder.detach uses a callLater(0),
4748 either that should be done in-line (something else needed that
4749 behavior), or it should return a Deferred that fires when the
4750 builder is really offline.
4751 (Disconnect.testBuild3): same
4752 (Disconnect.testDisappear): same
4754 * buildbot/test/test_web.py: rearrange server-setup and teardown
4755 code to remove unclean-reactor warnings from twisted-2.0
4757 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4758 so the tests don't hang under twisted-2.0
4760 2005-03-31 Brian Warner <warner@lothar.com>
4762 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4763 caused a warning each time the master changed our set of builders
4765 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4766 w32, don't unlink the file unless it already exists. Thanks to
4767 Baptiste Lepilleur for the catch.
4768 (BuilderStatus.saveYourself): same
4770 2005-02-01 Brian Warner <warner@lothar.com>
4772 * buildbot/status/html.py (TextLog.getChild): use a /text child
4773 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4774 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4775 logfile as text/plain (no markup, no headers). This replaces the
4776 previous scheme (which used an ?text=1 argument), and gets us back
4777 to a relative link (which works better when the buildbot lives
4778 behind another web server, such as Apache configured as a reverse
4779 proxy). Thanks to Gerald Combs for spotting the problem.
4781 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4784 2004-12-13 Brian Warner <warner@lothar.com>
4786 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4788 * debian/changelog: update for 0.6.2
4789 * NEWS: finalize for 0.6.2
4791 2004-12-11 Brian Warner <warner@lothar.com>
4793 * NEWS: bring it up to date
4795 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4796 detection code. Require some sign of life from the buildmaster
4797 every BotFactory.keepaliveInterval seconds. Provoke this
4798 indication at BotFactory.keepaliveTimeout seconds before the
4799 deadline by sending a keepalive request. We don't actually care if
4800 that request is answered in a timely fashion, what we care about
4801 is that .activity() is called before the deadline. .activity() is
4802 triggered by any PB message from the master (including an ack to
4803 one of the slave's status-update messages). With this new scheme,
4804 large status messages over slow pipes are OK, as long as any given
4805 message can be sent (and thus acked) within .keepaliveTimeout
4806 seconds (which defaults to 30).
4807 (SlaveBuilder.remote_startCommand): record activity
4808 (SlaveBuilder.ackUpdate): same
4809 (SlaveBuilder.ackComplete): same
4810 (BotFactory.gotPerspective): same
4811 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4813 2004-12-09 Brian Warner <warner@lothar.com>
4815 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4818 * buildbot/process/step_twisted.py (Trial._commandComplete):
4819 update self.cmd when we start the 'cat test.log' transfer. Without
4820 this, we cannot interrupt the correct RemoteCommand when we lose
4823 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4824 trying to tell the slave to stop the command if we're already
4825 inactive, or if we no longer have a .remote
4827 * buildbot/process/builder.py (Builder._detached): don't let an
4828 exception in currentBuild.stopBuild() prevent the builder from
4829 being marked offline
4831 2004-12-07 Brian Warner <warner@lothar.com>
4833 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4834 KeyError that happens when you ask for a non-existent Builder, and
4835 translate it into a UsageError.
4837 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4838 losing the slave in the middle of a remote step is handled too
4840 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4841 be a Failure, so be sure to stringify it before using it as the
4842 contents of the 'interrupt' logfile
4843 (RemoteCommand.interrupt): use stringified 'why' in
4844 remote_interruptCommand too, just in case
4846 2004-12-06 Brian Warner <warner@lothar.com>
4848 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4849 instead of 'tla update', which is more efficient in case we've
4850 missed a couple of patches since the last update.
4852 * debian/changelog: update for previous (0.6.1) release. Obviously
4853 this needs to be handled better.
4855 2004-12-05 Brian Warner <warner@lothar.com>
4857 * NEWS: update for stuff since last release
4859 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4860 match the maybeDeferred change in Dispatcher.requestAvatar
4861 * buildbot/changes/pb.py (ChangePerspective.attached): same
4862 * buildbot/status/client.py (StatusClientPerspective.attached): same
4863 * buildbot/process/builder.py (Builder._attached3): same
4864 * buildbot/pbutil.py (NewCredPerspective.attached): same
4866 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4867 the date to the top-most box, if it is not the same as today's
4870 * docs/slave.xhtml: provide a buildslave setup checklist
4872 * docs/source.xhtml (Arch): correct terminology
4874 2004-12-04 Brian Warner <warner@lothar.com>
4876 * buildbot/test/test_slavecommand.py: use sys.executable instead
4877 of hard-coding 'python' for child commands, might help portability
4879 * docs/examples/twisted_master.cfg: update to current usage
4881 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4882 'stop build' command to the IRC bot
4884 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4885 message that broke PBChangeSource
4887 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4888 (SlaveBuilder): make some attributes class-level, remove the old
4889 "update queue" which existed to support resuming a build after the
4890 master connection was lost. Try to reimplement that feature later.
4891 (SlaveBuilder.stopCommand): clear self.command when the
4892 SlaveCommand finishes, so that we don't try to kill a leftover one
4894 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4897 * buildbot/slave/commands.py (SourceBase): set self.command for
4898 all VC commands, so they can be interrupted.
4900 2004-12-03 Brian Warner <warner@lothar.com>
4902 * buildbot/master.py: clean up slave-handling code, to handle
4903 slave-disconnect and multiple-connect better
4904 (BotPerspective): make these long-lasting, exactly one per bot
4905 listed in the config file.
4906 (BotPerspective.attached): if a slave connects while an existing
4907 one appears to still be connected, disconnect the old one first.
4908 (BotPerspective.disconnect): new method to forcibly disconnect a
4909 buildslave. Use some hacks to empty the transmit buffer quickly to
4910 avoid the long (20-min?) TCP timeout that could occur if the old
4911 slave has dropped off the net.
4912 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4913 own their own SlaveStatus objects. Remove .attached/.detached, add
4914 .addSlave/.removeSlave, treat slaves like Builders (config file
4915 parsing sends deltas to the BotMaster). Inform the slave
4916 instances, i.e. the BotPerspective, about addBuilder and
4918 (BotMaster.getPerspective): turns into a single dict lookup
4919 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4920 which gives BotPerspective.attached a chance to disconnect the old
4922 (BuildMaster.loadConfig): add code (disabled) to validate that all
4923 builders use known slaves (listed in c['bots']). The check won't
4924 work with tuple-specified builders, which are deprecated but not
4925 yet invalid, so the check is disabled for now.
4926 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4927 routine, do the add/changed/removed dance with them like we do
4929 (BuildMaster.loadConfig_Sources): move source-config into a
4930 separate routine too
4932 * buildbot/status/builder.py (Status.getSlave): get the
4933 SlaveStatus object from the BotPerspective, not the BotMaster.
4935 * buildbot/test/test_run.py: bunch of new tests for losing the
4936 buildslave at various points in the build, handling a slave that
4937 connects multiple times, and making sure we can interrupt a
4940 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4941 something other than 'Bot' for the Bot object, to make certain
4942 test cases easier to write.
4943 (BuildSlave.waitUntilDisconnected): utility method for testing
4945 2004-11-30 Brian Warner <warner@lothar.com>
4947 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4949 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4950 argument, return a Deferred that always fires with True or False.
4951 I don't use an errback to indicate 'ping failed' so that callers
4952 are free to ignore the deferred without causing spurious errors in
4954 * buildbot/process/builder.py (BuilderControl.ping): implement it
4956 * buildbot/test/test_run.py (Status.testDisappear): test ping
4957 (Status.disappearSlave): fix it
4959 2004-11-30 Brian Warner <warner@lothar.com>
4961 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4962 (IBuilderControl): add .getBuild(num), only works for the current
4963 build, of course, although it might be interesting to offer
4964 something for builds in the .waiting or .interlocked state.
4966 * buildbot/process/base.py (Build): have .stopBuild just do the
4967 interrupt, then let the build die by itself.
4968 (BuildControl): add .stopBuild, and add a point-event named
4969 'interrupt' just after the build so status viewers can tell that
4971 (BuilderControl): add .getBuild
4973 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4974 stops when you kill it, good for testing
4975 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4976 contains the 'reason' text.
4978 * buildbot/status/html.py: Add Stop Build button, if the build can
4979 still be stopped. Send a Redirect (to the top page) one second
4980 later, hopefully long enough for the interrupt to have an effect.
4981 Move make_row() up to top-level to share it between Stop Build and
4984 * buildbot/slave/commands.py: only kill the child process once
4986 * buildbot/test/test_run.py: add testInterrupt
4988 2004-11-29 Brian Warner <warner@lothar.com>
4990 * buildbot/process/base.py: Refactor command interruption. The
4991 Build is now responsible for noticing that the slave has gone
4992 away: Build.lostRemote() interrupts the current step and makes
4993 sure that no further ones will be started.
4995 * buildbot/process/builder.py: When the initial remote_startBuild
4996 message fails, log it: this usually indicates that the slave has
4997 gone away, but we don't really start paying attention until they
4998 fail to respond to the first step's command.
5000 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5001 slave disconnect. Now sports a new interrupt() method. Error
5002 handling was simplified a lot by chaining deferreds, so
5003 remoteFailed/remoteComplete were merged into a single
5004 remoteComplete method (which can now get a Failure object).
5005 Likewise failed/finished were merged into just _finished.
5006 (BuildStep): Add interrupt(why) method, and if why is a
5007 ConnectionLost Failure then the step is failed with some useful
5010 * buildbot/slave/bot.py: stop the current command when the remote
5011 Step reference is lost, and when the slave is shut down.
5012 (Bot): make it a MultiService, so it can have children. Use
5013 stopService to tell when the slave is shutting down.
5014 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5015 remote_interruptCommand (which asks the current SlaveCommand to
5016 stop but allows it to keep emitting status messages), and
5017 stopCommand (which tells it to shut up and die).
5019 * buildbot/slave/commands.py: make commands interruptible
5020 (ShellCommand.kill): factor out os.kill logic
5021 (Command): factor out setup()
5022 (Command.sendStatus): don't send status if .running is false, this
5023 happens when the command has been halted.
5024 (Command.interrupt): new method, used to tell the command to die
5025 (SlaveShellCommand): implement .interrupt
5026 (DummyCommand): implement .interrupt
5027 (SourceBase, etc): factor out setup(), don't continue substeps if
5030 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5031 so they can be called after finishing
5033 * buildbot/test/test_run.py: new tests for disconnect behavior,
5034 refactor slave-shutdown routines, add different kinds of
5037 2004-11-27 Brian Warner <warner@lothar.com>
5039 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5040 method to express ETA time like "2m45s" instead of "165 seconds"
5042 2004-11-24 Brian Warner <warner@lothar.com>
5044 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5045 archive after the test completes, to avoid cluttering the user's
5046 'tla archives' listing with a bogus entry. Arch doesn't happen to
5047 provide any way to override the use of ~/.arch-params/, so there
5048 isn't a convenient way to avoid touching the setup of the user who
5050 (VC_HTTP.testArchHTTP): same
5052 2004-11-23 Brian Warner <warner@lothar.com>
5054 * buildbot/status/html.py (TextLog): split render() up into
5055 render_HEAD and render_GET. Use a Producer when sending log
5056 chunks, to reduce memory requirements and avoid sending huge
5057 non-Banana-able strings over web.distrib connections. Requires
5058 peeking under the covers of IStatusLog.
5059 (TextLog.resumeProducing): fix the "as text" link, handle client
5060 disconnects that occur while we're still sending old chunks.
5062 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5063 use defer.succeed, not the non-existent defer.success
5064 (LogFile.waitUntilFinished): same
5065 (LogFile.subscribe): don't add watchers to a finished logfile
5067 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5070 2004-11-23 Brian Warner <warner@lothar.com>
5072 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5074 2004-11-23 Brian Warner <warner@lothar.com>
5076 * NEWS: update for the 0.6.1 release
5077 * MANIFEST.in: add new files
5079 * README (INSTALLATION): explain how to enable the extra VC tests
5081 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5082 level to, so old pickled builds can be displayed ok
5084 2004-11-22 Brian Warner <warner@lothar.com>
5086 * NEWS: summarize updates since last release
5088 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5089 Yoz Grahame. Closes SF#1050138.
5091 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5094 * buildbot/process/step_twisted.py (Trial): update docs a bit
5096 * docs/factories.xhtml: fix Trial factory docs to match reality.
5099 * buildbot/process/factory.py (Trial.__init__): add args for
5100 randomly= and recurse=, making them available to instantiators
5101 instead of only to subclassers. Closes: SF#1049759.
5103 2004-11-15 Brian Warner <warner@lothar.com>
5105 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5106 try to teach the Quick factory to use multiple versions of python
5108 2004-11-12 Brian Warner <warner@lothar.com>
5110 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5111 safer w32-compatible approach, and only use it on windows
5112 (BuildStatus.saveYourself): same
5114 2004-11-11 Brian Warner <warner@lothar.com>
5116 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5117 it: one string merge per chunk. There are now separate .entries
5118 and .runEntries lists: when enumerating over all chunks, make sure
5120 * buildbot/test/test_status.py (Log): more tests
5122 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5123 chunks together, up to 10kb per chunk. This ought to cut down on
5124 the CPU-burning overhead of large log files. Thanks to Alexander
5125 Staubo for spotting the problem.
5126 * buildbot/test/test_status.py (Log): tests for same
5128 2004-11-10 Brian Warner <warner@lothar.com>
5130 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5131 header to outbound mail
5132 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5134 2004-11-08 Brian Warner <warner@lothar.com>
5136 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5137 can't do os.rename() onto an existing file, so catch the exception
5138 and unlink the target file first. This introduces a slight window
5139 where the existing file could be lost, but the main failure case
5140 (disk full) should still be handled safely.
5141 (BuildStatus.saveYourself): same
5143 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5144 separator character instead of os.sep, because the filenames being
5145 split here are coming from the VC system, which can have a
5146 different pathname convention than the local host. This should
5147 help a buildmaster running on windows that uses a CVS repository
5148 which runs under unix.
5149 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5151 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5152 when there are no test failures to be parsed
5154 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5155 instead of the unix-specific os.system("cp"), thanks to Elliot
5156 Murphy for this and the other buildbot-vs-windows catches.
5157 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5159 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5160 echo the command as it is run
5162 * setup.py: install sample.mk too, not just sample.cfg
5163 (scripts): install contrib/windows/buildbot.bat on windows
5165 2004-11-07 Brian Warner <warner@lothar.com>
5167 * buildbot/process/builder.py (Builder._detached): clear the
5168 self.currentBuild reference, otherwise the next build will be
5169 skipped because we think the Builder is already in use.
5171 * docs/examples/twisted_master.cfg: update to match current usage
5172 on the Twisted buildbot
5174 2004-10-29 Brian Warner <warner@lothar.com>
5176 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5178 2004-10-28 Brian Warner <warner@lothar.com>
5180 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5181 have separate doVCUpdate/doVCFull methods. Catch an update failure
5182 and respond by clobbering the source directory and re-trying. This
5183 will handle local changes (like replacing a file with a directory)
5184 that will cause CVS and SVN updates to fail.
5185 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5187 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5190 2004-10-19 Brian Warner <warner@lothar.com>
5192 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5194 * buildbot/status/html.py (StatusResourceTestResults): display any
5195 TestResults that the Build might have
5196 (StatusResourceTestResult): and the logs for each TestResult
5197 (StatusResourceBuild): add link from the per-build page
5199 2004-10-15 Brian Warner <warner@lothar.com>
5201 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5202 the 'problems' portion of stdout, add TestResults to our build
5203 * buildbot/test/test_twisted.py (Parse.testParse): test it
5205 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5206 to retrieve a dict of accumulated test results
5207 (ITestResult): define what a single test result can do
5208 * buildbot/status/builder.py (TestResult): implement ITestResult
5209 (BuildStatus.getTestResults): retrieve dict of TestResults
5210 (BuildStatus.addTestResult): add TestResults
5211 * buildbot/test/test_status.py (Results.testAddResults): test it
5213 2004-10-14 Brian Warner <warner@lothar.com>
5215 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5216 instead of os.system("rm -rf") for win32 portability
5218 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5219 SignalMixin instead of starting/stopping the reactor, which is
5220 likely to cause problems with other tests
5222 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5223 self.copyComplete() call. Yoz Grahame makes the catch.
5225 * contrib/windows/buildbot.bat: helper script to deal with path
5226 issues. Thanks to Yoz Grahame.
5228 * buildbot/master.py (BuildMaster.startService): don't register a
5229 SIGHUP handler if the signal module has no SIGHUP attribute.
5230 Apparently win32 does this.
5232 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5234 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5235 test if the reactor can't offer UNIX sockets
5237 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5238 error introduced in the last commit. We really need that
5241 2004-10-12 Brian Warner <warner@lothar.com>
5243 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5244 when describing a maildir source. Thanks to Stephen Davis.
5246 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5249 * buildbot/scripts/runner.py (createMaster): install Makefile too
5250 (start): add --no_save to 'start' command
5251 * buildbot/scripts/sample.mk: simple convenience Makefile with
5252 start/stop/reload targets
5254 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5257 2004-09-30 Brian Warner <warner@lothar.com>
5259 * setup.py: Releasing buildbot-0.6.0
5261 2004-09-30 Brian Warner <warner@lothar.com>
5263 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5264 test_trial.py from the source tarball until support is complete.
5266 * NEWS: update for 0.6.0 release
5267 * buildbot/__init__.py (version): same
5270 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5271 'source' command to tell users where to get the Buildbot source
5273 * docs/examples/*.cfg: update to modern standards
5275 * NEWS: update for release
5277 * buildbot/scripts/runner.py (createMaster): remove the
5278 -shutdown.tap stuff now that it isn't necessary
5280 (start): launch buildbot.tap, not buildbot-shutdown.tap
5283 * buildbot/status/mail.py (Domain): shorten class name
5284 (MailNotifier): if lookup= is a string, pass it to Domain()
5285 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5286 (Mail.testBuild2): test the string-to-Domain shortcut
5287 (Mail.testMail): fix test
5290 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5293 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5294 more attributes on load
5295 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5296 to accomodate the whole waterfall page at once, and the thrashing
5297 results in a lot of unnecessary loads
5298 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5299 (BuilderStatus.saveYourself): same
5300 (BuilderStatus.eventGenerator): stop generating on the first missing
5301 build. We assume that saved builds are deleted oldest-first.
5302 (BuildStepStatus.__getstate__): .progress might not exist
5304 * buildbot/changes/changes.py (ChangeMaster): make it
5305 serializable, in $masterdir/changes.pck
5306 (ChangeMaster.stopService): save on shutdown
5307 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5308 * buildbot/test/test_config.py: load Changes before config file
5311 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5312 "Oh my god, you killed the command" header on a separate line
5314 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5315 skip over corrupted build pickles
5316 (BuilderStatus.getFullBuildByNumber): same
5317 (BuilderStatus.eventGenerator): skip over unavailable builds
5318 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5319 do an atomic rename. This prevents a corrupted pickle when some
5320 internal serialization error occurs.
5321 (BuilderStatus.saveYourself): same
5323 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5324 the timeout for shell commands, it got lost somehow
5326 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5327 run out of build steps, return the rest of the builder events
5329 * buildbot/interfaces.py (IBuilderControl.ping): add method
5331 * buildbot/process/builder.py (BuilderControl.ping): move
5332 slave-ping to BuilderControl, and fix the failure case in the
5333 process (Event.finish() is the verb, Event.finished is the noun).
5335 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5336 through the BuilderControl instead of the BuilderStatus
5337 (EventBox): add adapter for builder.Event, allowing builder events to
5338 be displayed in the waterfall display
5340 * buildbot/master.py (BotMaster.stopService): add a 'master
5341 shutdown' event to the builder's log
5342 (BuildMaster.startService): and a 'master started' on startup
5344 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5345 builder events into the BuildStep event stream
5346 (Status.builderAdded): add a 'builder created' event
5349 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5350 command to announce the completion of a running build
5351 (IrcStatusBot.command_FORCE): announce when the build finishes
5353 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5354 don't evict unfinished builds from the cache: they must stay in
5355 the full-cache until their logfiles have stopped changing. Make
5356 sure the eviction loop terminates if an unfinished build was hit.
5357 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5358 This lets exceptions be dumped in an email status message. Really
5359 we need LogFiles which contain both text and HTML, instead of two
5361 (BuildStatus.__getstate__): handle self.finished=False
5362 (Status.builderAdded): if the pickle is corrupted, abandon the
5363 history and create a new BuilderStatus object.
5365 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5366 self.progress attribute, helped one test which doesn't fully set
5367 up the Build object.
5369 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5370 IStatusLog methods into an Interface that is implemented by "stub"
5371 logs, for which all the actual text chunks are on disk (in the
5372 pickled Build instance). To show the log contents, you must first
5373 adapt the stub log to a full IStatusLog object.
5375 * buildbot/status/builder.py (LogFileStub): create separate stub
5376 log objects, which can be upgraded to a real one if necessary.
5377 (LogFile): make them persistable, and let them stubify themselves
5379 (BuildStepStatus): same
5381 (BuildStatus.saveYourself): save the whole build out to disk
5382 (BuilderStatus): make it persistable
5383 (BuilderStatus.saveYourself): save the builder to disk
5384 (BuilderStatus.addFullBuildToCache): implement two caches which
5385 hold Build objects: a small one which holds full Builds, and a
5386 larger one which holds "stubbed" Builds (ones with their LogFiles
5387 turned into LogFileStubs). This reduces memory usage by the
5388 buildmaster by not keeping more than a few (default is 2) whole
5389 build logs in RAM all the time.
5390 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5392 (BuilderStatus.eventGenerator): rewrite since .builds went away
5393 (BuilderStatus.buildStarted): remove the .builds array. Add the
5394 build to the "full" cache when it starts.
5395 (BuilderStatus._buildFinished): save the build to disk when it
5397 (Status): give it a basedir (same as the BuildMaster's basedir)
5398 where the builder pickles can be saved
5399 (Status.builderAdded): create the BuilderStatus ourselves, by
5400 loading a pickle from disk (or creating a new instance if there
5401 was none on disk). Return the BuilderStatus so the master can glue
5402 it into the new Builder object.
5404 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5405 all BuilderStatuses to save themselves out to disk. This is in
5406 lieu of saving anything important in the main Application pickle
5407 (the -shutdown.tap file).
5408 (BuildMaster.__init__): give Status() a basedir for its files
5409 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5410 to get the BuilderStatus, then give it to the Builder (instead of
5411 doing it the other way around). It's ok if the status announces
5412 the new Builder before it's really ready, as the outside world can
5413 only see the BuilderStatus object anyway (and it is ready before
5414 builderAdded returns). Use the builder's "builddir" (which
5415 normally specifies where the slave will run the builder) as the
5416 master's basedir (for saving serialized builds).
5418 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5419 coerce the logfile to IStatusLog before trying to get the text
5420 chunks out of it. This will pull the full (non-stubified) Build in
5421 from disk if necessary.
5422 (TextLog): fix the adapter registration
5424 * buildbot/test/test_control.py (Force.setUp): create the basedir
5425 * buildbot/test/test_web.py: same
5426 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5427 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5428 * buildbot/test/test_run.py (Run.testMaster): same
5429 (Status.setUp): same
5431 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5433 * buildbot/status/html.py (Waterfall.__init__): store actual
5434 allowForce flag passed in rather than using True for everyone;
5435 make sure setting it to False doesn't cause a NameError
5437 (StatusResourceBuilder.__init__) add the builder name to the page
5439 (StatusResourceBuilder.body) move HTML generation for a name/value
5440 row into a helper method (StatusResourceBuilder.make_row); only
5441 generate the "Force Build" form if allowForce was True and the
5442 slave is connected. Use class attributes in the generated HTML to
5443 spread a little CSS-joy.
5445 2004-09-28 Brian Warner <warner@lothar.com>
5447 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5448 warning-scanner to not ignore things like
5449 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5451 * buildbot/status/html.py (StatusResource.control): add some
5452 class-level values for .control in an attempt to make upgrading
5455 * buildbot/util.py (ComparableMixin): survive missing attributes,
5456 such as when a class is modified and we're comparing old instances
5459 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5460 failure handling, remove a redundant try/except block. Don't
5461 return the full traceback to the IRC channel.
5462 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5463 error messages. Get ETA properly.
5465 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5466 the reason, since (at least) IRC message will have <> in them.
5467 (StatusResourceBuilder.__init__): take an IBuilderControl
5468 (StatusResourceBuilder.force): use the IBuilderControl we get in
5469 the constructor instead of trying to make our own. Catch the
5470 new exceptions and ignore them for now (until we make an
5471 intermediate web page where we could show the error message)
5472 (StatusResource): create with an IControl, use it to give an
5473 IBuilderControl to all children
5474 (Waterfall): take an allowForce= option, pass an IControl object
5475 to StatusResource if it is True
5477 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5479 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5480 catch new exceptions and return string forms
5482 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5483 * buildbot/process/builder.py (Builder.forceBuild): raise them
5484 * buildbot/test/test_control.py (Force.testNoSlave): new test
5485 (Force.testBuilderInUse): same
5488 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5490 * buildbot/test/test_run.py: use IControl
5491 * buildbot/test/test_vc.py: same
5493 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5494 to use IControl. Still offline.
5495 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5497 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5498 who=None so periodic builds don't send out status mail
5499 (Builder.forceBuild): include reason in the log message
5500 (BuilderControl.forceBuild): rename 'name' to 'who'
5502 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5503 'who' parameter, but make it None by default so builds forced by
5504 slave admins don't cause status mail to be sent to anybody
5505 (BotMaster.forceBuild): same. this method is deprecated.
5506 (DebugPerspective.perspective_forceBuild): same, use IControl.
5507 (DebugPerspective.perspective_fakeChange): use IControl..
5508 (Dispatcher.requestAvatar): .. so don't set .changemaster
5510 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5511 parameter to avoid confusion with the name of the builder
5514 * buildbot/status/mail.py: refine comment about needing 2.3
5516 * buildbot/status/html.py: move all imports to the top
5518 * buildbot/test/test_control.py: test new interfaces
5519 * buildbot/test/test_run.py (Status): handle new interfaces
5520 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5522 * buildbot/process/base.py (BuildControl): implement IBuildControl
5523 and its lonely getStatus() method
5525 * buildbot/process/builder.py (BuilderControl): implement
5526 IBuilderControl, obtained by adapting the Builder instance
5527 (Builder.startBuild): return a BuilderControl instead of a
5528 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5529 accomplish the same thing.
5531 * buildbot/master.py: move all import statements to the top
5532 (Control): implement IControl, obtained by adapting the
5533 BuildMaster instance.
5535 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5536 IBuildControl. These are used to force builds. Eventually they
5537 will provide ways to reconfigure the Builders, pause or abandon a
5538 Build, and perhaps control the BuildMaster itself.
5540 2004-09-26 Brian Warner <warner@lothar.com>
5542 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5543 ends up comparing us against something without a .__class__
5545 2004-09-24 Brian Warner <warner@lothar.com>
5547 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5550 * Makefile: add 'deb-snapshot' target, to create a timestamped
5553 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5555 2004-09-23 Brian Warner <warner@lothar.com>
5557 * buildbot/__init__.py (version): move version string here
5558 * setup.py: get version string from buildbot.version
5559 * buildbot/status/html.py (WaterfallStatusResource.body): add
5560 buildbot version to the page footer
5561 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5564 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5565 slaves, let the second know where the first one is coming from
5566 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5567 see our exceptions. It would be nice if there were a way to just
5568 send them the exception type and value, not the full traceback.
5571 * buildbot/status/mail.py (MailNotifier): add a new argument
5572 sendToInterestedUsers=, which can be set to False to disable the
5573 usual send-to-blamelist behavior.
5574 (top): handle python-2.2 which has no email.MIMEMultipart
5575 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5576 (MailNotifier.disownServiceParent): unsubscribe on removal
5578 * buildbot/test/test_status.py (Mail.testBuild2): test it
5581 * buildbot/status/progress.py (Expectations.wavg): tolerate
5582 current=None, which happens when steps start failing badly
5583 * buildbot/test/test_status.py (Progress.testWavg): test for it
5585 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5586 doesn't understand args['revision'], emit a warning instead of
5587 bailing completely. Updating to -rHEAD is probably close enough.
5589 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5591 * buildbot/test/test_status.py: at least import bb.status.client
5592 even if we don't have any test coverage for it yet
5594 * contrib/svn_buildbot.py: don't require python2.3
5595 (main): wait, do require it (for sets.py), but explain how to
5596 make it work under python2.2
5598 2004-09-23 Brian Warner <warner@lothar.com>
5600 * contrib/svn_buildbot.py: include the revision number in the Change
5602 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5603 using util.now() because FreshCVS is a realtime service
5605 * buildbot/status/event.py: delete dead code
5606 * buildbot/process/step.py: don't import dead Event class
5607 * buildbot/process/step_twisted.py: same
5608 * buildbot/status/builder.py: same
5609 * buildbot/status/client.py: same
5611 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5613 * buildbot/changes/changes.py (Change): set .when from an __init__
5614 argument (which defaults to now()), rather than having
5615 ChangeMaster.addChange set it later.
5616 (ChangeMaster.addChange): same
5618 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5619 (parseSyncmail): same. Just use util.now() for now.
5620 (parseBonsaiMail): parse the timestamp field for when=
5622 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5623 instead of setting .when after the fact
5627 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5628 results when the target project uses retrial. Still under
5630 * buildbot/test/test_trial.py: same
5632 2004-09-21 Brian Warner <warner@lothar.com>
5634 * buildbot/status/mail.py (MailNotifier.__init__): include
5635 success/warnings/failure in the Subject line
5636 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5637 use step.logname for the addLogs=True attachment filenames
5638 * buildbot/test/test_status.py (Mail): test Subject lines
5639 (Mail.testLogs): test attachment filenames
5641 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5642 accept a 'who' argument from the debug tool
5643 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5644 * contrib/debug.glade: add text box to set 'who'
5646 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5647 .getBuilderName with .getBuilder().getName(), more flexible
5648 (IStatusLog.getName): logs have short names, but you can prefix
5649 them with log.getStep().getName() to make them more useful
5650 * buildbot/status/builder.py: same
5651 * buildbot/status/client.py: same
5652 * buildbot/status/html.py: same
5653 * buildbot/test/test_run.py (Status.testSlave): same
5654 * buildbot/process/step.py: tweak logfile names
5656 * buildbot/status/mail.py (MailNotifier): add lookup, change
5657 argument to extraRecipients. The notifier is now aimed at sending
5658 mail to the people involved in a particular build, with additional
5659 constant recipients as a secondary function.
5661 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5662 including slow-lookup and failing-lookup. Make sure the blamelist
5663 members are included.
5665 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5666 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5667 (IBuildStatus.getInterestedUsers): new method
5668 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5669 * buildbot/status/client.py (remote_getResponsibleUsers): same
5670 * buildbot/status/html.py (StatusResourceBuild.body): same
5671 * buildbot/test/test_run.py (Status.testSlave): same
5673 2004-09-20 Brian Warner <warner@lothar.com>
5675 * docs/users.xhtml: update concepts
5677 * Makefile: add a convenience makefile, for things like 'make
5678 test'. It is not included in the source tarball.
5680 2004-09-16 Brian Warner <warner@lothar.com>
5682 * NEWS: mention /usr/bin/buildbot, debian/*
5684 * debian/*: add preliminary debian packaging. Many thanks to
5685 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5686 it considerably since it left their hands, I am responsible for
5687 all breakage that's resulted.
5689 * bin/buildbot: create a top-level 'buildbot' command, to be
5690 installed in /usr/bin/buildbot . For now it's just a simple
5691 frontend to mktap/twistd/kill, but eventually it will be the entry
5692 point to the 'try' command and also a status client. It is also
5693 intended to support the upcoming debian-packaging init.d scripts.
5694 * buildbot/scripts/runner.py: the real work is done here
5695 * buildbot/scripts/__init__.py: need this too
5696 * buildbot/scripts/sample.cfg: this is installed in new
5697 buildmaster directories
5698 * setup.py: install new stuff
5700 2004-09-15 Brian Warner <warner@lothar.com>
5702 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5703 'file:' schema (the version shipped with OS-X was built without the
5705 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5706 updates the log-timestamp, to make sure it isn't still running after
5709 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5710 values to the config file.
5711 * docs/examples/hello.cfg: add examples
5712 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5713 * buildbot/status/builder.py (Status.getProjectURL): implement them
5714 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5715 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5716 * buildbot/status/html.py (WaterfallStatusResource): display them
5719 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5720 certain error cases don't suffer a secondary exception.
5721 (top): Skip tests if the corresponding VC tool is not installed.
5723 * buildbot/process/factory.py (Trial): introduce separate
5724 'buildpython' and 'trialpython' lists, since trialpython=[] is
5725 what you want to invoke /usr/bin/python, whereas ./setup.py is
5726 less likely to be executable. Add env= parameter to pass options
5727 to test cases (which is how I usually write tests, I don't know if
5728 anyone else does it this way).
5730 * buildbot/process/step_twisted.py (Trial): handle python=None.
5731 Require 'testpath' be a string, not a list. Fix tests= typo.
5732 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5734 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5735 way to deal with the possibility of removing the disconnect notify
5737 (CVS): add a 'login' parameter to give a password to 'cvs login',
5738 commonly used with pserver methods (where pw="" or pw="guest")
5740 * buildbot/slave/commands.py (SourceBase): move common args
5741 extraction and setup() to __init__, so everything is ready by the
5742 time setup() is called
5743 (CVS.start): call 'cvs login' if a password was supplied
5744 (ShellCommand): special-case PYTHONPATH: prepend the master's
5745 value to any existing slave-local value.
5747 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5748 don't have a remote, mark the builder as Offline. This whole
5749 function should probably go away and be replaced by individual
5751 (Builder.buildFinished): return the results to the build-finished
5752 deferred callback, helps with testing
5754 2004-09-14 Brian Warner <warner@lothar.com>
5756 * buildbot/test/test_vc.py: put all the repositories needed to run
5757 the complete tests into a single small (1.3MB) tarball, so I can
5758 make that tarball available on the buildbot web site. Test HTTP
5759 access (for Arch and Darcs) by spawning a temporary web server
5760 while the test runs.
5762 * docs/users.xhtml: new document, describe Buildbot's limited
5763 understanding of different human users
5765 * buildbot/test/test_vc.py: rearrange test cases a bit
5767 * buildbot/process/step_twisted.py (Trial): handle testpath=
5768 * buildbot/process/factory.py (Trial): update to use step.Trial
5770 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5772 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5773 the overall build text (which gives you 'failed 2 tests' rather
5775 (BuildStepStatus.text2): default to [], not None
5777 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5780 2004-09-12 Brian Warner <warner@lothar.com>
5782 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5783 log the whole exception if it's just an AttributeError (old slave)
5785 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5786 so (e.g.) sub-commands can be run in the right directory.
5787 (ShellCommand.start): accept an optional errorMessage= argument
5788 to make life easier for SVN.start
5789 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5791 (ShellCommand.start): move ['dir'] compatibility hack..
5792 (RemoteShellCommand.start): .. to here so everyone can use it
5794 * buildbot/process/step_twisted.py (Trial): use .workdir
5796 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5797 text displayed when debuild fails completely
5798 (Trial): snarf _trial_temp/test.log from the slave and display it
5800 2004-09-11 Brian Warner <warner@lothar.com>
5802 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5804 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5805 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5807 * buildbot/process/step.py (ShellCommand): call .createSummary
5808 before .evaluateCommand instead of the other way around. This
5809 makes it slightly easier to count warnings and then use that to
5810 set results=WARNINGS
5811 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5813 * buildbot/process/base.py (Build.buildFinished): update status
5814 before doing progress. It's embarrassing for the build to be stuck
5815 in the "building" state when an exceptions occurs elsewhere..
5817 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5818 python2.2 doesn't have 'sum'
5820 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5821 to prevent clients from accidentally sorting it
5823 * buildbot/master.py (Manhole): add username/password
5824 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5825 c['manholePort'], deprecate old usage
5826 * docs/config.xhtml: document c['manhole']
5827 * docs/examples/hello.cfg: show example of using a Manhole
5830 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5831 pretend the slave is up to date
5833 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5834 the module, overlaps with 'log', the local variable
5836 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5838 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5839 new method to let Steps find out the version of their
5840 corresponding SlaveCommand.
5841 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5842 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5843 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5845 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5846 (Arch.startVC): same
5847 (P4Sync.startVC): same
5849 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5850 Deferred so we can catch errors in remote_startCommand
5851 (RemoteShellCommand.start): same
5853 * docs/examples/twisted_master.cfg: update sample config file
5855 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5856 after connectionMade() is called, not before. Close stdin at that
5859 * buildbot/process/process_twisted.py: update to use Trial, clean
5860 up argument passing (move to argv arrays instead of string
5863 * buildbot/process/step_twisted.py (Trial): new step to replace
5864 RunUnitTests, usable by any trial-using project (not just
5865 Twisted). Arguments have changed, see the docstring for details.
5867 * buildbot/process/base.py (Build.startBuild): this now returns a
5868 Deferred. Exceptions that occur during setupBuild are now
5869 caught better and lead to fewer build_status weirdnesses, like
5870 finishing a build that was never started.
5871 (Build.buildFinished): fire the Deferred instead of calling
5872 builder.buildFinished directly. The callback argument is this
5873 Build, everything else can be extracted from it, including the
5874 new build.results attribute.
5875 * buildbot/process/builder.py (Builder.startBuild): same
5876 (Builder.buildFinished): same, extract results from build
5878 * buildbot/process/step.py (ShellCommands): remove dead code
5880 2004-09-08 Brian Warner <warner@lothar.com>
5882 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5883 doesn't try to use the leftover patched workdir
5884 (SourceStamp): test source-stamp computation for CVS and SVN
5886 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5887 patched workdir ('touch .buildbot-patched') so we don't try to
5889 (SourceBase.start): add ['revision'] for all Source steps
5890 (CVS): change args: use ['branch'] for -r, remove ['files']
5891 (CVS.buildVC): fix revision/branch stuff
5892 (SVN): add revision stuff
5894 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5895 kwargs (except 'workdir') to avoid silent spelling errors
5896 (ShellCommand.__init__): same
5897 (Source): new base class for CVS/SVN/etc. Factor out everything
5898 common, add revision computation (perform the checkout with a -D
5899 DATE or -r REVISION that gets exactly the sources described by the
5900 last Change), overridable with step.alwaysUseLatest. Add patch
5901 handling (build.getSourceStamp can trigger the use of a base
5902 revision and a patch).
5903 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5904 * docs/steps.xhtml: update docs
5905 * docs/source.xhtml: mention .checkoutDelay
5906 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5908 * buildbot/process/base.py (Build.setSourceStamp): add a
5909 .sourceStamp attribute to each Build. If set, this indicates that
5910 the build should be done with something other than the most
5911 recent source tree. This will be used to implement "try" builds.
5912 (Build.allChanges): new support method
5913 (Build.lastChangeTime): remove, functionality moved to Source steps
5914 (Build.setupBuild): copy the Step args before adding ['workdir'],
5915 to avoid modifying the BuildFactory (and thus triggering spurious
5919 * buildbot/status/html.py: rename s/commits/changes/
5920 (StatusResourceChanges): same
5921 (CommitBox.getBox): same, update URL
5922 (WaterfallStatusResource): same
5923 (StatusResource.getChild): same
5925 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5926 * contrib/debug.glade: add optional 'revision' to the fakeChange
5928 * buildbot/changes/changes.py (html_tmpl): display .revision
5929 (ChangeMaster.addChange): note .revision in log
5930 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5931 accept a ['revision'] attribute
5933 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5935 * buildbot/master.py (BotMaster.getPerspective): update the
5936 .connected flag in SlaveStatus when it connects
5937 (BotMaster.detach): and when it disconnects
5938 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5939 (BuildMaster.loadConfig_Builders): walk old list correctly
5941 * buildbot/test/test_config.py: fix prefix= usage
5943 2004-09-06 Brian Warner <warner@lothar.com>
5947 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5948 poll a P4 depot looking for recent changes. Thanks to Dave
5949 Peticolas for the contribution. Probably needs some testing after
5952 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5953 requires manual client setup for each buildslave. Rather
5954 experimental. Thanks again to Dave Peticolas.
5955 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5957 * buildbot/changes/changes.py (Change): add a .revision attribute,
5958 which will eventually be used to generate source-stamp values.
5960 * buildbot/process/step.py (RemoteCommand.start): use
5961 notifyOnDisconnect to notice when we lose the slave, then treat it
5962 like an exception. This allows LogFiles to be closed and the build
5963 to be wrapped up normally. Be sure to remove the disconnect
5964 notification when the step completes so we don't accumulate a
5965 bazillion such notifications which will fire weeks later (when the
5966 slave finally disconnects normally). Fixes SF#915807, thanks to
5967 spiv (Andrew Bennetts) for the report.
5968 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5969 really isn't Logged- specific
5970 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5971 header, since it's almost always going to be appended to an
5973 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5974 update test to handle use of notifyOnDisconnect
5976 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5977 don't clear .ETA and .currentBuild when going offline, let the
5978 current build clean up after itself
5980 * buildbot/process/builder.py (Builder.detached): wait a moment
5981 before doing things like stopping the current build, because the
5982 current step will probably notice the disconnect and cleanup the
5984 * buildbot/test/test_run.py (Status.tearDown): update test to
5985 handle asynchronous build-detachment
5987 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5989 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5990 hush a debug message
5992 2004-09-05 Brian Warner <warner@lothar.com>
5994 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5995 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5996 kernels do this: the fcntl module has the F_NOTIFY constant, but
5997 the kernel itself doesn't support the operation. Thanks to Olly
5998 Betts for spotting the problem.
6000 * buildbot/process/step.py (Darcs): new source-checkout command
6001 (Arch): new source-checkout command
6002 (todo_P4): fix constructor syntax, still just a placeholder
6003 * buildbot/test/test_vc.py (VC.testDarcs): test it
6004 (VC.testDarcsHTTP): same, via localhost HTTP
6006 (VC.testArchHTTP): same
6007 * NEWS: mention new features
6009 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6010 which tells the step to stash stdout text locally (in .stdout).
6011 Slave-side Commands can use this to make decisions based upon the
6012 output of the the ShellCommand (not just the exit code).
6013 (Darcs): New source-checkout command
6014 (Arch): New source-checkout command, uses .keepStdout in one place
6015 where it needs to discover the archive's default name.
6017 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6018 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6019 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6021 * buildbot/process/step.py (ShellCommand.describe): add an
6022 alternate .descriptionDone attribute which provides descriptive
6023 text when the step is complete. .description can be ["compiling"],
6024 for use while the step is running, then .descriptionDone can be
6025 ["compile"], used alone when the step succeeds or with "failed" when
6026 it does not. Updated other steps to use the new text.
6027 * buildbot/process/step_twisted.py: same
6028 * buildbot/test/test_run.py: update tests to match
6030 2004-08-30 Brian Warner <warner@lothar.com>
6032 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6033 (CVS.__init__): send 'patch' argument to slave
6034 (CVS.start): don't create the LoggedRemoteCommand until start(),
6035 so we can catch a .patch added after __init__
6036 (SVN.__init__): add 'patch' to SVN too
6039 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6040 argument, to let commands push data into the process' stdin pipe.
6041 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6042 is in use, since closing a PTY doesn't really affect the process
6043 in the right way (in particular, I couldn't run /usr/bin/patch
6045 (SourceBase.doPatch): handle 'patch' argument
6047 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6050 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6051 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6053 * buildbot/master.py (BotPerspective.got_commands): get command
6054 versions from slave, give to each builder
6055 * buildbot/process/builder.py (Builder.attached): stash slave
6056 command versions in .remoteCommands
6058 * docs/steps.xhtml: bring docs in-line with reality
6060 * buildbot/process/step.py (CVS.__init__): more brutal
6061 compatibility code removal
6062 (SVN.__init__): same
6064 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6065 (SlaveShellCommand.start): require ['workdir'] argument, remove
6066 the ['dir'] fallback (compatibility will come later)
6067 (SourceBase): update docs
6068 (SourceBase.start): remove ['directory'] fallback
6071 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6072 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6073 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6075 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6076 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6077 code.. I will figure out 0.5.0-compatibility hooks later)
6079 2004-08-30 Brian Warner <warner@lothar.com>
6081 * buildbot/process/process_twisted.py: rewrite in terms of new
6082 BuildFactory base class. It got significantly shorter. Yay
6085 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6086 work with the new "self.build isn't nailed down until we call
6087 step.start()" scheme: specifically, __init__ is called before the
6088 build has decided on which Changes are going in, so we don't scan
6089 build.allFiles() for .xhtml files until start()
6090 (HLint.commandComplete): use getText(), not getStdout()
6091 (RunUnitTests.start): same: don't use .build until start()
6092 (RunUnitTests.describe): oops, don't report (None) when using
6094 (RunUnitTests.commandComplete): use getText()
6095 (RunUnitTests.createSummary): same
6096 (BuildDebs.commandComplete): same
6098 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6099 set args['command'] until start(), since our BuildStep is allowed
6100 to change their mind up until that point
6101 (TreeSize.commandComplete): use getText(), not getStdout()
6103 * docs/examples/twisted_master.cfg: update to current standards
6105 * docs/factories.xhtml: update
6106 * buildbot/process/factory.py: implement all the common factories
6107 described in the docs. The Trial factory doesn't work yet, and
6108 I've probably broken all the process_twisted.py factories in the
6109 process. There are compatibility classes left in for things like
6110 the old BasicBuildFactory, but subclasses of them are unlikely to
6112 * docs/examples/glib_master.cfg: use new BuildFactories
6113 * docs/examples/hello.cfg: same
6115 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6116 explicit 'workdir' args
6118 * buildbot/process/base.py (BuildFactory): move factories to ..
6119 * buildbot/process/factory.py (BuildFactory): .. here
6120 * buildbot/process/process_twisted.py: handle move
6121 * buildbot/test/test_config.py: same
6122 * buildbot/test/test_run.py: same
6123 * buildbot/test/test_steps.py: same
6124 * buildbot/test/test_vc.py: same
6125 * docs/factories.xhtml: same
6127 * NEWS: mention config changes that require updating master.cfg
6129 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6130 argument to all steps that weren't given one already, pointing at
6131 the "build/" directory.
6133 * docs/examples/hello.cfg: remove explicit 'workdir' args
6135 * docs/factories.xhtml: document standard BuildFactory clases,
6136 including a bunch which are have not yet been written
6138 2004-08-29 Brian Warner <warner@lothar.com>
6140 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6141 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6142 buildbot.status.builder so they aren't quite so internal
6143 * buildbot/process/base.py, buildbot/process/builder.py: same
6144 * buildbot/process/maxq.py, buildbot/process/step.py: same
6145 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6146 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6147 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6149 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6150 to handle new getLogs()-returns-list behavior
6151 (StatusResourceBuildStep.getChild): same
6152 (StepBox.getBox): same
6153 (WaterfallStatusResource.phase0): same
6155 * docs/source.xhtml: document how Buildbot uses version-control
6156 systems (output side: how we get source trees)
6157 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6158 systems (input side: how we learn about Changes)
6160 * buildbot/master.py (Manhole): use ComparableMixin
6161 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6162 * buildbot/changes/mail.py (MaildirSource): same
6163 * buildbot/status/client.py (PBListener): same
6164 * buildbot/status/html.py (Waterfall): same
6165 * buildbot/status/words.py (IRC): same
6167 * NEWS: start describing new features
6169 * buildbot/status/mail.py (MailNotifier): finish implementation.
6170 The message body is still a bit sparse.
6171 * buildbot/test/test_status.py (Mail): test it
6173 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6174 and __hash__ methods I wind up adding everywhere. Specifically
6175 intended to support the buildbot config-file update scheme where
6176 we compare, say, the old list of IStatusTargets against the new
6177 one and don't touch something which shows up on both lists.
6178 * buildbot/test/test_util.py (Compare): test case for it
6180 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6181 return a list instead of a dict
6182 (IBuildStepStatus.getLogs): same. The idea is that steps create
6183 logs with vaguely unique names (although their uniqueness is not
6184 guaranteed). Thus a compilation step should create its sole
6185 logfile with the name 'compile', and contribute it to the
6186 BuildStatus. If a step has two logfiles, try to create them with
6187 different names (like 'test.log' and 'test.summary'), and only
6188 contribute the important ones to the overall BuildStatus.
6189 * buildbot/status/builder.py (Event.getLogs): same
6190 (BuildStepStatus): fix default .text and .results
6191 (BuildStepStatus.addLog): switch to list-like .getLogs()
6192 (BuildStepStatus.stepFinished): same
6193 (BuildStatus.text): fix default .text
6194 (BuildStatus.getLogs): temporary hack to return all logs (from all
6195 child BuildStepStatus objects). Needs to be fixed to only report
6196 the significant ones (as contributed by the steps themselves)
6197 * buildbot/test/test_run.py: handle list-like .getLogs()
6198 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6200 2004-08-28 Brian Warner <warner@lothar.com>
6202 * buildbot/process/builder.py (Builder.attached): serialize the
6203 attachment process, so the attach-watcher isn't called until the
6204 slave is really available. Add detached watchers too, which makes
6207 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6209 * buildbot/test/test_swap.py: remove dead code
6211 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6212 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6213 sort of as if the command being run exited with a -1. There may
6214 still be some holes in this scheme.
6215 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6216 -r option appears before the module list
6217 * buildbot/process/step.py (CVS): add 'revision' argument
6219 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6220 when sending updates or stepComplete messages to the master, since
6221 we don't currently care whether they arrive or not. When we revamp
6222 the master/slave protocol to really resume interrupted builds,
6223 this will need revisiting.
6224 (lostRemote): remove spurious print
6226 * buildbot/master.py (BotPerspective.attached): serialize the
6227 new-builder interrogation process, to make testing easier
6228 (BotMaster.waitUntilBuilderDetached): convenience function
6230 * buildbot/status/builder.py (BuilderStatus): prune old builds
6231 (BuildStatus.pruneSteps): .. and steps
6232 (BuildStepStatus.pruneLogs): .. and logs
6233 (BuilderStatus.getBuild): handle missing builds
6234 * buildbot/status/html.py (StatusResourceBuild.body): display build
6235 status in the per-build page
6236 (BuildBox.getBox): color finished builds in the per-build box
6238 2004-08-27 Brian Warner <warner@lothar.com>
6240 * buildbot/status/mail.py (MailNotifier): new notification class,
6243 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6244 variants of a common base class which handles all the mode= logic
6246 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6248 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6250 2004-08-26 Brian Warner <warner@lothar.com>
6252 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6255 * buildbot/test/test_run.py: update to new Logfile interface, new
6256 buildbot.slave modules
6257 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6259 * MANIFEST.in: new sample config file
6260 * docs/examples/hello.cfg: same
6262 * buildbot/process/step_twisted.py: remove dead import
6264 * buildbot/process/step.py (RemoteCommand.run): catch errors
6266 (RemoteCommand.remote_update): ignore updates that arrive after
6268 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6269 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6270 the responsibilities of the subclass's methods
6271 (BuildStep.failed): catch errors during failure processing
6272 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6273 (CVS): move to a mode= argument (described in docstring), rather
6274 than the ungainly clobber=/export=/copydir= combination.
6275 (SVN): add mode= functionality to SVN too
6276 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6278 * buildbot/process/base.py (Build.startNextStep): catch errors
6279 during s.startStep()
6281 * buildbot/clients/base.py: update to new PB client interface.
6282 gtkPanes is still broken
6284 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6285 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6286 * setup.py: add buildbot.slave module
6287 * buildbot/bb_tap.py: handle move
6288 * buildbot/slave/registry.py: place to register commands, w/versions
6289 * buildbot/slave/bot.py: major simplifications
6290 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6291 instead of a fixed table. Eventually this will make the slave more
6292 extensible. Use 'start' method on the command, not .startCommand.
6293 Fix unsafeTracebacks handling (I think).
6294 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6295 helper class with a .start method that returns a Deferred.
6296 SlaveShellCommand is the form reached by the buildmaster. Commands
6297 which use multiple ShellCommands can just chain them as Deferreds,
6298 with some helper methods in Command (_abandonOnFailure and
6299 _checkAbandoned) to bail on rc!=0.
6300 (CVSCommand): prefer new mode= argument
6301 (SVNFetch): add mode= argument
6303 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6304 put a useful reason string on the build
6306 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6307 core functionality into an IStatusLog object
6308 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6309 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6310 (StatusResourceBuild.body): use proper accessor methods
6311 * buildbot/status/client.py (RemoteLog): PB-access goes here
6312 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6313 which delivers log contents too
6314 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6315 * buildbot/status/event.py: remove old Logfile completely
6317 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6318 subscription interface for IStatusLog subscriptions just like all
6319 other the status subscriptions
6320 (IStatusReceiver.logChunk): method called on subscribers
6322 2004-08-24 Brian Warner <warner@lothar.com>
6324 * buildbot/process/builder.py (Builder._pong): oops, ping response
6325 includes a result (the implicit None returned by remote_print).
6326 Accept it so the _pong method handles the response correctly.
6328 2004-08-06 Brian Warner <warner@lothar.com>
6330 * buildbot/test/test_config.py: update IRC, PBListener tests
6332 * buildbot/status/client.py (StatusClientPerspective): total
6333 rewrite to match new IStatus interfaces. New subscription scheme.
6334 There are still a few optimizations to make (sending down extra
6335 information with event messages so the client doesn't have to do a
6336 round trip). The logfile-retrieval code is probably still broken.
6337 Moved the PB service into its own port, you can no longer share a
6338 TCP socket between a PBListener and, say, the slaveport (this
6339 should be fixed eventually).
6340 * buildbot/clients/base.py (Client): revamp to match. still needs
6341 a lot of work, but basic event reporting works fine. gtkPanes is
6344 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6345 instance talks to a single irc server. Threw out all the old
6346 multi-server handling code. Still need to add back in
6347 builder-control (i.e. "force build")
6349 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6350 more random text to the as-yet-unreachable per-step page
6352 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6353 rename to stepETAUpdate
6354 (BuildStatus.subscribe): add build-wide ETA updates
6355 (BuilderStatus.getState): remove more cruft
6356 (BuilderStatus.getCurrentBuild): remove more cruft
6357 (BuilderStatus.buildStarted): really handle tuple-subscription
6358 * buildbot/test/test_run.py (Status.testSlave): handle the
6359 stepETAUpdate rename
6361 * buildbot/master.py (BuildMaster): don't add a default
6362 StatusClientService. Don't add a default IrcStatusFactory. Both
6363 are now added through c['status'] in the config file. c['irc'] is
6364 accepted for backwards compatibility, the only quirk is you cannot
6365 use c['irc'] to specify IRC servers on ports other than 6667.
6367 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6368 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6369 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6370 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6373 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6374 the buildmaster to re-read its config file
6377 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6378 find out the port our server is running on
6379 (WebTest.test_webPathname_port): same
6381 * buildbot/test/test_config.py (testWebPortnum): test it
6382 (testWebPathname): ditto
6384 * docs/config.xhtml: document new c['status'] configuration option
6386 * buildbot/status/html.py (Waterfall): new top-level class which
6387 can be added to c['status']. This creates the Site as well as the
6388 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6389 reachable as .parent, for everything.
6391 * buildbot/master.py (Manhole): make it a normal service Child
6392 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6393 webPathname. It will eventually replace c['irc'] and the implicit
6394 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6395 in as (deprecated) backward compatibility hooks for now.
6398 * buildbot/process/builder.py (Builder.buildFinished): don't
6399 inform out builder_status about a finished build, as it finds out
6400 through its child BuildStatus object
6402 * buildbot/status/html.py: extensive revamp. Use adapters to make
6403 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6404 have both starting and finishing times and adjust the waterfall
6405 display accordingly, using spacers if necessary. Use SlaveStatus
6406 to get buildslave info.
6407 (StatusResourceBuildStep): new just-one-step resource, used to get
6408 logfiles. No actual href to it yet.
6410 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6411 the time being, until I get the file-naming scheme right
6413 * buildbot/status/builder.py (Event): clean started/finished names
6414 (BuildStatus.isFinished): .finished is not None is the right test
6415 (BuildStatus.buildStarted): track started/finished times ourselves
6416 (BuilderStatus.getSlave): provide access to SlaveStatus object
6417 (BuilderStatus.getLastFinishedBuild): all builds are now in
6418 .builds, even the currently-running one. Accomodate this change.
6419 (BuilderStatus.eventGenerator): new per-builder event generator.
6420 Returns BuildStepStatus and BuildStatus objects, since they can
6421 both be adapted as necessary.
6422 (BuilderStatus.addEvent): clean up started/finished attributes
6423 (BuilderStatus.startBuild,finishBuild): remove dead code
6424 (SlaveStatus): new object to provide ISlaveStatus
6426 * buildbot/process/step.py (ShellCommand.getColor): actually
6427 return the color instead of setting it ourselves
6428 (CVS.__init__): pull .timeout and .workdir options out of
6429 **kwargs, since BuildStep will ignore them. Without this neither
6430 will be sent to the slave correctly.
6431 (SVN.__init__): same
6433 * buildbot/process/builder.py (Builder): move flags to class-level
6435 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6436 SlaveStatus handle that
6438 * buildbot/process/base.py (Build.firstEvent): remove dead code
6439 (Build.stopBuild): bugfix
6441 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6443 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6444 (ChangeMaster.eventGenerator): yield Changes, since there are now
6445 Adapters to turn them into HTML boxes
6447 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6448 (BotPerspective.attached): feed a SlaveStatus object
6449 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6450 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6452 * buildbot/interfaces.py: API additions
6453 (ISlaveStatus): place to get slave status
6455 2004-08-04 Brian Warner <warner@lothar.com>
6457 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6458 the delay finishes, so the step is marked as SUCCESS
6460 * buildbot/test/test_run.py (Status.testSlave): cover more of
6461 IBuildStatus and IBuildStepStatus
6463 * buildbot/status/progress.py (StepProgress): move some flags to
6464 class-level attributes
6465 (StepProgress.remaining): if there are no other progress metrics
6466 to go by, fall back to elapsed time
6467 (StepProgress.setExpectations): take a dict of metrics instead of
6469 (BuildProgress.setExpectationsFrom): pull expectations from the
6470 Expectations, instead of having it push them to the BuildProgress
6471 (Expectations): move some flags to class-level attributes
6472 (Expectations.__init__): copy per-step times from the
6474 (Expectations.expectedBuildTime): new method for per-build ETA
6476 * buildbot/status/event.py (Logfile): move some flags to
6477 class-level attributes
6478 (Logfile.logProgressTo): better method name, let step set the
6479 progress axis name (instead of always being "output")
6481 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6482 times directly, rather than depending upon the (possibly missing)
6483 .progress object. Use 'None' to indicate "not started/finished
6485 (BuildStepStatus.getExpectations): oops, return the full list of
6487 (BuilderStatus._buildFinished): append finished builds to .builds
6489 * buildbot/process/step.py (BuildStep): add separate .useProgress
6490 flag, since empty .progressMetrics[] still implies that time is a
6492 (CVS): set up the cmd in __init__, instead of waiting for start()
6494 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6495 calculation, this will eventually turn into a proper sourceStamp
6496 (Build.setupBuild): tell the Progress to load from the Expectations,
6497 instead of having the Expectations stuff things into the Progress
6498 (Build.buildException): add a build-level errback to make sure the
6499 build's Deferred fires even in case of exceptions
6501 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6503 * buildbot/process/builder.py (Builder.forceBuild): convey the
6504 reason instead of creating a fake Change
6506 * docs/examples/twisted_master.cfg: update to match reality
6508 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6509 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6510 fix or remove broken/breaking tests
6512 * buildbot/status/event.py (Logfile.__len__): remove evil method
6514 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6515 missing .build, for test convenience
6517 * buildbot/process/step_twisted.py: import fixes
6519 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6521 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6522 .statusbag reference
6524 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6525 connection at shutdown, and stop it from reconnecting
6527 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6528 chase down remote-execution bugs
6530 * buildbot/process/step.py: more fixes, remove
6531 BuildStep.setStatus()
6532 * buildbot/status/builder.py: move setStatus() functionality into
6534 * buildbot/status/event.py: minor fixes
6536 2004-08-03 Brian Warner <warner@lothar.com>
6538 * buildbot/process/base.py, buildbot/process/builder.py
6539 * buildbot/process/step.py, buildbot/status/builder.py
6540 * buildbot/status/event.py, buildbot/test/test_run.py:
6541 fix status delivery, get a basic test case working
6542 * buildbot/master.py: finish implementing basic status delivery,
6543 temporarily disable HTML/IRC/PB status sources
6545 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6547 * buildbot/status/progress.py (BuildProgress): remove dead code
6549 * buildbot/interfaces.py
6550 * buildbot/process/base.py, buildbot/process/builder.py
6551 * buildbot/process/step.py, buildbot/process/step_twisted.py
6552 * buildbot/status/builder.py: Complete overhaul of the all
6553 status-delivery code, unifying all types of status clients (HTML,
6554 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6555 look like. This commit is a checkpointing of the work-in-progress:
6556 the input side is mostly done (Builders/Builds sending status
6557 to the BuilderStatus/BuildStatus objects), but the output side has
6558 not yet been started (HTML resources querying BuilderStatus
6559 objects). Things are probably very broken right now and may remain
6560 so for several weeks, I apologize for the disruption.
6562 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6563 HTML as the log's contents. Currently used for exception tracebacks.
6564 * buildbot/status/progress.py: minor spelling changes
6566 2004-08-02 Brian Warner <warner@lothar.com>
6568 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6569 in mozilla. Also added stylesheets copied from Twisted's docs.
6570 Remember that these files are meant to be run through Lore first.
6571 Thanks to Philipp Frauenfelder for the fixes.
6572 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6573 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6574 * docs/template.tpl: added a Lore template
6576 2004-07-29 Brian Warner <warner@lothar.com>
6578 * buildbot/interfaces.py: revamp status delivery. This is the
6579 preview: these are the Interfaces that will be provided by new
6580 Builder code, and to which the current HTML/IRC/PB status
6581 displayers will be adapted.
6583 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6584 on the SlaveBuilder, not the Bot.
6585 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6587 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6588 set .usePTY on the FakeSlaveBuilder
6590 2004-07-25 Brian Warner <warner@lothar.com>
6592 * buildbot/changes/freshcvs.py: add some debug log messages
6593 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6594 disabled 'setFilter' syntax
6595 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6596 don't end with a slash
6598 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6600 * setup.py: bump to 0.5.0+ while between releases
6602 2004-07-23 Brian Warner <warner@lothar.com>
6604 * setup.py (version): Releasing buildbot-0.5.0
6606 2004-07-23 Brian Warner <warner@lothar.com>
6608 * README: update for 0.5.0 release
6610 * NEWS: update for 0.5.0 release
6612 2004-07-22 Brian Warner <warner@lothar.com>
6614 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6615 mktap-time configuration flag (--usepty=1, --usepty=0)
6616 * buildbot/bot.py: same
6618 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6619 an 'info' directory being unwanted
6621 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6622 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6623 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6624 and earlier), use a FreshCVSSourceOldcred instead.
6625 (test): simple test routine: connect to server, print changes
6627 * buildbot/changes/changes.py (Change.getTime): make it possible
6628 to print un-timestamped changes
6630 * buildbot/master.py (makeApp): delete ancient dead code
6631 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6632 * buildbot/test/test_config.py (testFindConfigFile): test it
6634 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6635 instead of win32 one
6638 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6639 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6642 * buildbot/process/base.py (Builder.__init__): change constructor
6643 to accept a dictionary of config data, rather than discrete
6644 name/slave/builddir/factory arguments
6646 * docs/examples/twisted_master.cfg: update to new syntax
6647 * docs/examples/glib_master.cfg: same
6648 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6649 rough tests of the new syntax
6652 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6653 to be an int, which means "run a web.distrib sub-server on a TCP
6654 port". This lets you publish the buildbot status page to a remote
6655 twisted.web server (using distrib.ResourceSubscription). Also
6656 rename the local attributes used to hold these web things so
6657 they're more in touch with reality.
6658 * buildbot/test/test_web.py: test webPortnum and webPathname
6659 * docs/config.xhtml: document this new use of webPathname
6661 * docs/config.xhtml: new document, slightly ahead of reality
6663 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6664 'prefix' handling: treat it as a simple string to check with
6665 .startswith, instead of treating it as a directory. This allows
6666 sub-directories to be used. If you use prefix=, you should give it
6667 a string that starts just below the CVSROOT and ends with a slash.
6668 This prefix will be stripped from all filenames, and filenames
6669 which do not start with it will be ignored.
6671 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6673 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6674 and --exclude (inverse of --include). SVN post-commit hooks
6675 now have total control over which changes get sent to buildbot and which
6678 2004-07-10 Brian Warner <warner@lothar.com>
6680 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6681 test case to match new API
6683 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6684 which crashed HTML display when self.entries=[] (needed to
6685 distinguish between [], which means "no entries yet", and None,
6686 which means "the entries have been swapped out to disk, go fetch
6689 2004-07-04 Brian Warner <warner@lothar.com>
6691 * buildbot/process/step_twisted.py (countFailedTests): Count
6692 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6693 10kb from the end because any import errors are wedged there and
6694 they would make us think the test log was unparseable.
6695 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6697 2004-06-26 Brian Warner <warner@lothar.com>
6699 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6700 delete-*.pyc command into an actual BuildStep, so we can label it
6702 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6703 (FullTwistedBuildFactory): same
6705 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6707 * contrib/fakechange.py: Add an errback when sending the fake
6708 change, so we know it didn't work.
6710 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6712 * buildbot/process/step_twisted.py: Delete *.pyc files before
6713 calling trial, so it doesn't catch any old .pyc files whose .py
6714 files have been moved or deleted.
6716 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6717 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6718 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6719 instead of ["twisted.test"], so that the end result is "trial -R
6722 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6723 regular expression to match filenames that should be ignored when
6724 changed. Also add a --revision parameter that specifies the
6725 revision to examine, which is useful for debugging.
6727 2004-06-25 Brian Warner <warner@lothar.com>
6729 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6730 summary of warnings (like DeprecationWarnings), next to the
6733 2004-05-13 Brian Warner <warner@lothar.com>
6735 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6736 we now have a w32 build slave courtesy of Mike Taylor.
6738 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6739 so broken. Fixed a race condition that tripped up interlocked
6740 builds and caused the status to be stuck at "Interlocked" forever.
6741 The twisted buildbot's one interlocked build just so happened to
6742 never hit this case until recently (the feeding builds both pass
6743 before the interlocked build is attempted.. usually it has to wait
6745 (Builder._pong_failed): fix method signature
6747 * setup.py: bump to 0.4.3+ while between releases
6749 2004-04-30 Brian Warner <warner@lothar.com>
6751 * setup.py (version): Releasing buildbot-0.4.3
6753 2004-04-30 Brian Warner <warner@lothar.com>
6755 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6757 * README: update for 0.4.3 release
6759 * NEWS: update for 0.4.3 release
6761 * buildbot/master.py (BuildMaster.__getstate__): make sure
6762 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6764 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6765 .trial as a class attribute, for upgrade from 0.4.2
6767 * buildbot/changes/changes.py (Change.links): add .links for
6770 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6771 .textWatchers and .htmlWatchers at save time, since they are both
6772 volatile, should allow smooth 0.4.2 upgrade
6774 * buildbot/process/step.py (CVS.finishStatus): catch failed
6775 CVS/SVN commands so we can make the status box red
6777 2004-04-29 Brian Warner <warner@lothar.com>
6779 * buildbot/changes/freshcvs.py
6780 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6781 code to do setFilter(), which tells the freshcvs daemon to not
6782 send us stuff that we're not interested in. I will uncomment it
6783 when a new version of CVSToys is available in which setFilter()
6784 actually works, and I get a chance to test it better.
6786 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6788 * buildbot/master.py (Dispatcher): use a registration scheme
6789 instead of hardwired service names
6790 (BuildMaster): keep track of the Dispatcher to support
6793 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6794 PBChangeSource class instead of having it be an undocumented
6795 internal feature of the ChangeMaster. Split out the code into a
6797 * buildbot/changes/pb.py (PBChangeSource): same
6798 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6800 * docs/{factories|sources|steps}.xhtml: document some pieces
6802 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6803 using FCMaildirSource
6804 (f23osx): update OS-X builder to use python2.3, since the slave
6805 was updated to Panther (10.3.3)
6807 2004-03-21 Brian Warner <warner@lothar.com>
6809 * buildbot/process/process_twisted.py: factor out doCheckout, change
6810 to use SVN instead of CVS
6812 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6813 an SVN subclass easier
6814 (BasicSVN): subclass which uses Subversion instead of CVS
6816 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6818 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6820 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6822 2004-02-25 Brian Warner <warner@lothar.com>
6824 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6825 is now either a list (which is passed to spawnProcess directly) or
6826 a string (which gets passed to /bin/sh -c). This removes the useSH
6827 flag and the ArgslistCommand class. Also send status header at the
6828 start and end of each command, instead of having the master-side
6830 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6831 -r'. Update to use list-based arguments.
6832 (SVNFetch): use list-based arguments, use ['dir'] argument to
6834 * buildbot/test/test_steps.py (Commands): match changes
6836 * buildbot/process/step.py (InternalShellCommand.words): handle
6838 (SVN): inherit from CVS, cleanup
6840 * buildbot/status/event.py (Logfile.content): render in HTML, with
6841 stderr in red and headers (like the name of the command we're
6842 about to run) in blue. Add link to a second URL (url + "?text=1")
6843 to get just stdout/stderr in text/plain without markup. There is
6844 still a problem with .entries=None causing a crash, it seems to occur
6845 when the logfile is read before it is finished.
6847 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6848 timeout to the keepalives, and use it to explicitly do a
6849 loseConnection instead of waiting for TCP to notice the loss. This
6850 ought to clear up the silent-lossage problem.
6851 (unsafeTracebacks): pass exception tracebacks back to the master,
6852 makes it much easier to debug problems
6854 2004-02-23 Brian Warner <warner@lothar.com>
6856 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6857 the whole command to /bin/sh instead of execve [Johan Dahlin]
6858 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6859 '-r HEAD' [Johan Dahlin]
6860 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6862 * buildbot/changes/changes.py (Change): add links= argument, add
6863 asHTML method [Johan Dahlin]. Modified to make a bit more
6864 XHTMLish. Still not sure how to best use links= .
6866 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6867 Change.asHTML to display the change, not asText
6869 * buildbot/status/html.py (StatusResourceBuilder): web button to
6872 * buildbot/test/test_run.py: test to actually start a buildmaster
6875 * MANIFEST.in: bring back accidentally-dropped test helper files
6877 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6878 that require cvstoys if it is not installed
6880 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6881 values of "bin/trial" [Dave Peticolas]
6882 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6883 tests passed" when we didn't happen to run any tests
6885 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6886 flunkOnFailure [Johan Dahlin]
6888 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6889 multiple instances of the same Step class by suffixing "_2", etc,
6890 to the name until it is unique. This name needs to be unique
6891 because it is used as a key in the dictionary that tracks build
6893 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6896 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6898 2004-01-14 Brian Warner <warner@lothar.com>
6900 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6901 kicked from a channel, log it
6903 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6904 something over whatever IRC channels the buildmaster is currently
6905 connected to. Added to try and track down a problem in which the
6906 master thinks it is still connected but the IRCd doesn't see it. I
6907 used a styles.Versioned this time, so hopefully users won't have
6908 to rebuild their .tap files this time.
6909 * contrib/debug.glade: add a "Poke IRC" button
6910 * contrib/debugclient.py: same
6912 * setup.py: bump to 0.4.2+ while between releases
6914 2004-01-08 Brian Warner <warner@lothar.com>
6916 * setup.py (version): Releasing buildbot-0.4.2
6918 2004-01-08 Brian Warner <warner@lothar.com>
6920 * NEWS: update for 0.4.2 release
6922 * README: document how to run the tests, now that they all pass
6924 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6926 * buildbot/process/step.py (CVS): add a global_options= argument,
6927 which lets you set CVS global options for the command like "-r"
6928 for read-only checkout, or "-R" to avoid writing in the
6930 * buildbot/slavecommand.py (CVSCommand): same
6932 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6933 testing easier (it is turned off when testing, to avoid the
6936 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6937 to make it easier to test: break generateStepID() out to a
6938 separate function, only update statusbag if it exists.
6939 (ShellCommands): create useful text for dict-based commands too.
6941 * test/*, buildbot/test/*: move unit tests under the buildbot/
6943 * setup.py (packages): install buildbot.test too
6945 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6946 * buildbot/test/test_steps.py: fix it, tests pass now
6948 2004-01-06 Brian Warner <warner@lothar.com>
6950 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6951 freshcvs mail uses a slightly different syntax for new
6952 directories. Update parser to handle either.
6953 * test/test_mailparse.py (Test1.testMsg9): test for same
6955 2003-12-21 Brian Warner <warner@lothar.com>
6957 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6958 'warnOnWarnings' so that lintian errors mark the build orange
6960 2003-12-17 Brian Warner <warner@lothar.com>
6962 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6963 messages emitted by Bonsai, contributed by Stephen Davis.
6965 * test/*: moved all tests to use trial instead of unittest. Some
6966 still fail (test_steps, test_slavecommand, and test_process).
6968 * setup.py (version): bump to 0.4.1+ while between releases
6970 2003-12-09 Brian Warner <warner@lothar.com>
6972 * setup.py (version): Releasing buildbot-0.4.1
6974 2003-12-09 Brian Warner <warner@lothar.com>
6976 * NEWS: update for 0.4.1 release
6978 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6979 freebsd builder code a little bit
6981 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6982 don't try to compare attributes of different classes
6983 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6984 (MaildirSource.messageReceived): fix Change delivery
6986 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6987 into the config file's namespace before loading it, like the
6988 documentation claims it does
6989 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6990 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6991 daemon comes back online
6993 2003-12-08 Brian Warner <warner@lothar.com>
6995 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6996 so the example will work with online=0 as well
6998 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6999 fix the __implements__ line
7001 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7002 class a twisted.application.service.Service, use startService to
7005 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7006 directory fd instead of simple open(). I'm sure this used to work,
7007 but the current version of python refuses to open directories with
7010 2003-12-05 Brian Warner <warner@lothar.com>
7012 * setup.py (version): bump to 0.4.0+ while between releases
7014 2003-12-05 Brian Warner <warner@lothar.com>
7016 * setup.py (version): Releasing buildbot-0.4.0
7018 2003-12-05 Brian Warner <warner@lothar.com>
7020 * docs/examples/glib_master.cfg: replace old sample scripts with
7021 new-style config files
7022 * MANIFEST.in: include .cfg files in distribution tarball
7024 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7025 implement a dummy method to avoid the exception that occurs when
7026 freshcvs sends this to us.
7028 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7029 removed the method, as it broke reconnection. Apparently
7030 stopFactory is called each time the connection attempt fails. Must
7032 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7033 attribute before serialization, since without stopFactory the
7034 reconnect timer may still be active and they aren't serializable.
7036 * test/test_mailparse.py (ParseTest): test with 'self' argument
7038 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7039 argument, as these "functions" are invoked like methods from class
7040 attributes and therefore always get an instance as the first
7043 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7044 message: thanks to Stephen Davis for the catch
7046 2003-12-04 Brian Warner <warner@lothar.com>
7048 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7049 twisted's standard ReconnectingClientFactory. Handles both oldcred
7050 and newcred connections. Also has a bug-workaround for
7051 ReconnectingClientFactory serializing its connector when it
7054 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7055 pbutil. Replace makeApp stuff with proper newcred/mktap
7056 makeService(). Don't serialize Ephemerals on shutdown.
7058 * buildbot/changes/changes.py (ChangeMaster): make it a
7059 MultiService and add the sources as children, to get startService
7060 and stopService for free. This also gets rid of the .running flag.
7062 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7063 new pbutil, turn into a TCPClient at the same time (to get
7064 startService for free). Two variants exist: FreshCVSSourceOldcred
7065 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7066 yet, but when it does, we'll be ready).
7067 (FreshCVSSource.notify): handle paths which are empty after the
7068 prefix is stripped. This only happens when the top-level (prefix)
7069 directory is added, at the very beginning of a Repository's life.
7071 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7072 Now the only reconnecting code is in the factory where it belongs.
7073 (Builder.unsubscribe): unregister the disconnect callback when we
7074 delete the builder on command from the master (i.e. when the
7075 buildmaster is reconfigured and that builder goes away). This
7076 fixes a multiple-delete exception when the status client is shut
7078 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7081 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7082 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7084 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7086 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7087 a list of globs (ugh). The testdir will be searched for files
7088 named *.tests and run the tests in the order specified in each of
7089 those files. This allows for "dependancies" between tests to be
7092 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7093 argument to pass to run_maxq.py, instead of a glob.
7095 2003-10-17 Brian Warner <warner@lothar.com>
7097 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7098 files that live in the sandbox
7100 2003-10-15 Brian Warner <warner@lothar.com>
7102 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7103 spelling error in "docs" count-warnings output
7104 (HLint.start): stupid thinko meant .xhtml files were ignored
7106 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7107 tests now that cReactor is banished to the sandbox
7109 2003-10-10 Brian Warner <warner@lothar.com>
7111 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7112 scheme: now .xhtml are sources and .html are generated
7114 2003-10-08 Brian Warner <warner@lothar.com>
7116 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7117 we were ignoring the 'randomly' parameter.
7119 2003-10-01 Brian Warner <warner@lothar.com>
7121 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7122 posix, to kill sub-children of aborted slavecommands.
7124 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7125 Clean up initialization: lastBuildStatus remains None until the
7126 first build has been completed.
7128 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7129 None as a lastBuildStatus
7130 * buildbot/clients/gtkPanes.py: same
7132 * buildbot/status/client.py (StatusClientService): keep
7133 BuilderStatus objects in self.statusbags . These objects now live
7134 here in the StatusClientService and are referenced by the Builder
7135 object, rather than the other way around.
7136 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7137 * buildbot/process/base.py (Builder): same
7138 * test/test_config.py (ConfigTest.testBuilders): same
7140 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7141 an existing builder, leave the statusbag alone. This will preserve the
7144 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7145 hook. This will probably go away in favor of a class in upcoming
7148 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7149 serviceName from newcred FreshCVSNotifiee setup
7151 2003-09-29 Brian Warner <warner@lothar.com>
7153 * buildbot/process/process_twisted.py: switch to new reactor
7155 * docs/examples/twisted_master.cfg: same
7157 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7159 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7160 botmaster reference instead of the oldapp service lookup
7162 * buildbot/master.py (BuildMaster.__init__): give the
7163 StatusClientService a reference to the botmaster to make it easier to
7166 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7168 * buildbot/status/html.py (Box.td): escape hreffy things so you
7169 can have spaces in things like builder names
7170 (StatusResourceBuilder.body)
7171 (WaterfallStatusResource.body)
7172 (WaterfallStatusResource.body0): same
7174 2003-09-25 Brian Warner <warner@lothar.com>
7176 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7177 rearrange the builder list when adding or removing builders: keep
7178 them in the order the user requested.
7179 * test/test_config.py (ConfigTest.testBuilders): verify it
7181 * contrib/debug.glade: give the debug window a name
7183 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7184 now wait on multiple interlocks. Fix code relating to that.
7185 (Builder.checkInterlocks): same
7186 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7188 * buildbot/master.py (BuildMaster.loadConfig): move from
7189 deprecated pb.BrokerFactory to new pb.PBServerFactory
7190 * test/test_config.py (ConfigTest.testWebPathname): same
7192 * docs/examples/twisted_master.cfg: fix interlock declaration
7194 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7195 Interlocks to their Builders into interlock.py .
7196 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7198 * test/test_config.py (ConfigTest.testInterlocks): validate
7201 * buildbot/process/base.py (Builder.__init__): better comments
7202 * buildbot/process/interlock.py (Interlock.__repr__): same
7203 (Interlock.deactivate): add .active flag, move the code that
7204 attaches/detaches builders into the Interlock
7206 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7208 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7209 tests using the new run_maxq.py script, and reporting failures by
7212 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7213 tests, reporting their success or failure in a buildbot-friendly
7216 2003-09-24 Brian Warner <warner@lothar.com>
7218 * docs/examples/twisted_master.cfg: example of a new-style config
7219 file. This lives in the buildmaster base directory as
7222 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7223 button to make the master re-read its config file
7225 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7226 buildmaster configuration from a file. This file can be re-read
7227 later, and the buildmaster will update itself to match the new
7228 desired configuration. Also use new Twisted Application class.
7229 * test/Makefile, test/test_config.py: unit tests for same
7231 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7232 FreshCVSSources comparable, to support reload.
7233 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7235 * buildbot/process/base.py (Builder): make them comparable, make
7236 Interlocks easier to attach, to support reload. Handle
7237 re-attachment of remote slaves.
7238 * buildbot/process/interlock.py (Interlock): same
7240 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7241 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7242 buildmaster taps are now constructed with mktap.
7243 * buildbot/status/client.py (StatusClientService): same
7245 * buildbot/status/words.py: move to new Services, add support to
7246 connect to multiple networks, add reload support, allow nickname
7247 to be configured on a per-network basis
7249 2003-09-20 Brian Warner <warner@lothar.com>
7251 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7252 the freebsd builder, now that the machine has been upgraded and no
7253 longer has python2.2
7255 * setup.py (version): bump to 0.3.5+ while between releases
7257 2003-09-19 Brian Warner <warner@lothar.com>
7259 * setup.py (version): Releasing buildbot-0.3.5
7261 2003-09-19 Brian Warner <warner@lothar.com>
7263 * NEWS: add post-0.3.4 notes
7265 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7267 * MANIFEST.in: add contrib/*
7269 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7270 use a remote root now: cvs.twistedmatrix.com
7272 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7274 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7275 compatibility with old servers
7276 (FreshCVSSource.start): and provide a way to use it
7277 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7279 * docs/examples/twisted_master.py (twisted_app): update to new
7281 (twisted_app): listen on new ~buildbot socket
7282 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7284 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7285 to reduce cvs bandwidth (update instead of full checkout)
7287 2003-09-11 Brian Warner <warner@lothar.com>
7289 * contrib/fakechange.py: demo how to connect to the changemaster
7290 port. You can use this technique to submit changes to the
7291 buildmaster from source control systems that offer a hook to run a
7292 script when changes are committed.
7294 * contrib/debugclient.py: tool to connect to the debug port. You
7295 can use it to force builds, submit fake changes, and wiggle the
7298 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7299 'Dispatcher' realm to handle all the different kinds of
7300 connections and Perspectives: buildslaves, the changemaster port,
7301 the debug port, and the status client port. NewCredPerspectives
7302 now have .attached/.detached methods called with the remote 'mind'
7303 reference, much like old perspectives did. All the pb.Services
7304 turned into ordinary app.ApplicationServices .
7305 (DebugService): went away, DebugPerspectives are now created
7306 directly by the Dispatcher.
7307 (makeApp): changed interface a little bit
7309 * buildbot/changes/changes.py: newcred
7310 * buildbot/status/client.py: newcred
7312 * buildbot/clients/base.py: newcred client side changes
7313 * buildbot/bot.py: ditto
7315 * docs/examples/glib_master.py: handle new makeApp() interface
7316 * docs/examples/twisted_master.py: ditto
7318 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7319 base newcred Perspectives on. This should go away once Twisted
7320 itself provides something sensible.
7323 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7325 * contrib/svn_buildbot.py: A program that you can call from your
7326 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7327 when a change in an SVN repository has happened. See the top of
7328 the file for some minimal usage info.
7330 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7332 * buildbot/slavecommand.py (ArglistCommand): Add new
7333 ArglistCommand that takes an argument list rather than a string as
7334 a parameter. Using a st.split() for argv is very bad.
7336 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7337 update to a particular revision rather than always checking out
7338 (still not very smart about it, there may be cases where the
7339 checkout becomes inconsistent).
7341 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7343 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7344 SVN fetch support. It can checkout (not update!) a specified
7345 revision from a specified repository to a specified directory.
7347 * buildbot/status/progress.py (Expectations.update): Fix an
7348 obvious bug (apparently created by the change described in the
7349 previous ChangeLog message) by moving a check to *after* the
7350 variable it checks is defined.
7353 2003-09-08 Brian Warner <warner@lothar.com>
7355 * buildbot/status/progress.py (Expectations.update): hack to catch
7356 an exception TTimo sees: sometimes the update() method seems to
7357 get called before the step has actually finished, so the .stopTime
7358 is not set, so no totalTime() is available and we average None
7359 with the previous value. Catch this and just don't update the
7360 metrics, and emit a log message.
7362 2003-08-24 Brian Warner <warner@lothar.com>
7364 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7365 parameter to set copydir='original' in CVS commands.
7367 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7369 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7370 which tells the command to maintain a separate original-source CVS
7371 workspace. For each build, this workspace will be updated, then
7372 the tree copied into a new workdir. This reduces CVS bandwidth
7373 (from a full checkout to a mere update) while doubling the local
7374 disk usage (to keep two copies of the tree).
7376 2003-08-21 Brian Warner <warner@lothar.com>
7378 * buildbot/status/event.py (Logfile.addEntry): if the master web
7379 server dies while we're serving a page, request.write raises
7380 pb.DeadReferenceError . Catch this and treat it like a
7381 notifyFinish event by dropping the request.
7383 2003-08-18 Brian Warner <warner@lothar.com>
7385 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7386 (instead of blowing up) if a force-build command is given without
7389 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7390 don't blow up if there aren't yet any Changes in the list
7392 2003-08-02 Brian Warner <warner@lothar.com>
7394 * buildbot/bot.py (updateApplication): don't set the .tap name,
7395 since we shouldn't assume we own the whole .tap file
7397 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7398 'mktap buildbot' (without a subcommand) better
7400 2003-07-29 Brian Warner <warner@lothar.com>
7402 * buildbot/status/words.py
7403 (IrcStatusFactory.clientConnectionLost): when we lose the
7404 connection to the IRC server, schedule a reconnection attempt.
7406 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7407 use shutil.rmtree instead of forking off an "rm -rf" command.
7408 rmtree may take a while and will block until it finishes, so we
7409 use "rm -rf" if available.
7411 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7412 freebsd buildslave badly
7414 * setup.py (version): bump to 0.3.4+ while between releases
7416 2003-07-28 Brian Warner <warner@lothar.com>
7418 * setup.py (version): Releasing buildbot-0.3.4
7420 2003-07-28 Brian Warner <warner@lothar.com>
7422 * NEWS: update in preparation for release
7424 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7425 process.signalProcess instead of os.kill, to improve w32
7428 * docs/examples/twisted_master.py (twisted_app): turn off
7429 win32eventreactor: the tests hang the buildslave badly
7431 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7432 failed builds, since usually the failures are consistent
7434 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7435 add compileOpts/compileOpts2 to reactors build
7437 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7438 (twisted_app): use both default and win32eventreactor on w32 build.
7439 Use both default and kqreactor on freebsd build.
7441 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7442 add compileOpts2, which is put after the build_ext argument. w32
7443 needs "-c mingw32" here.
7445 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7446 touch .acqpath, it goes away in recent Twisted releases
7448 * docs/examples/twisted_master.py (twisted_app): use "python" for
7449 the w32 buildslave, not "python2.2"
7451 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7452 the directory exists.. should hush an exception under w32
7454 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7455 ProcessTerminated -provided values for signal and exitCode rather
7456 than parsing the unix status code directly. This should remove one
7457 more roadblock for a w32-hosted buildslave.
7459 * test/test_mailparse.py: add test cases for Syncmail parser
7461 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7462 temporary compatibility import. Note! Start importing
7463 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7465 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7467 2003-07-27 Brian Warner <warner@lothar.com>
7469 * NEWS: started adding new features
7471 * buildbot/changes/mail.py: start work on Syncmail parser, move
7472 mail sources into their own file
7474 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7475 as implementing IChangeSource
7476 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7478 * buildbot/interfaces.py: define the IChangeSource interface
7480 2003-07-26 Brian Warner <warner@lothar.com>
7482 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7484 2003-06-25 Brian Warner <warner@lothar.com>
7486 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7489 2003-06-17 Brian Warner <warner@lothar.com>
7491 * buildbot/status/words.py: clean up method usage to avoid error
7492 in silly IRC command
7493 (IrcStatusBot.emit_status): round off seconds display
7495 * buildbot/process/base.py (Build): delete the timer when saving
7496 to the .tap file, and restore it (if it should still be running)
7497 upon restore. This should fix the "next build in -34 seconds"
7498 messages that result when the master is restarted while builds are
7499 sitting in the .waiting slot. If the time for the build has
7500 already passed, start it very soon (in 1 second).
7502 * buildbot/status/words.py: more silly commands
7504 * README (REQUIREMENTS): add URLs to all required software
7506 * buildbot/status/words.py ('last'): mention results of, and time
7509 2003-05-28 Brian Warner <warner@lothar.com>
7511 * buildbot/status/words.py: add 'last' command
7512 (IrcStatusBot.emit_status): add current-small text to 'status' output
7514 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7515 (twisted_app): remove spaces from OS-X builder name
7517 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7518 * buildbot/status/words.py: IRC bot should actually be useful now
7520 2003-05-23 Brian Warner <warner@lothar.com>
7522 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7523 "slave information" from $(slavedir)/info/* . These files are
7524 maintained by the slave administrator, and describe the
7525 machine/environment that is hosting the slave. Information from
7526 them is put into the "Builder" HTML page. Still need to establish
7527 a set of well-known filenames and meanings for this data: at the
7528 moment, *all* info/* files are sent to the master, but only
7529 'admin' and 'host' are used on that end.
7530 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7531 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7532 * buildbot/master.py (BotPerspective.got_info): ditto
7534 2003-05-22 Brian Warner <warner@lothar.com>
7536 * setup.py (version): bump version to 0.3.3+ while between releases
7538 2003-05-21 Brian Warner <warner@lothar.com>
7540 * setup.py: Releasing buildbot-0.3.3
7542 2003-05-21 Brian Warner <warner@lothar.com>
7544 * NEWS: 0.3.3 news items
7546 * README: describe --keepalive and life behind a NAT box
7548 * buildbot/bot.py (Bot.connected): implement application-level
7549 keepalives to deal with NAT timeouts, turn them on with
7550 --keepalive option or when SO_KEEPALIVE doesn't work.
7552 * buildbot/master.py (BotPerspective): accept keepalives silently
7554 * buildbot/process/base.py (Build.buildException): CopiedFailures
7555 don't carry as much information as local ones, so don't try to
7556 create a big HTMLized version of them.
7558 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7559 log file when step fails due to an exception, such as when the slave
7562 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7563 --testmodule argument instead of grepping for test-case-name tags
7564 ourselves. Remove FindUnitTests code.
7565 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7567 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7569 2003-05-16 Brian Warner <warner@lothar.com>
7571 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7572 argument to allow things like CFLAGS=-O0 to be passed without relying
7573 upon /bin/sh processing on the slave.
7575 * buildbot/process/step.py (InternalShellCommand.start): send
7577 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7578 'split' instead of letting /bin/sh do it. This should also remove
7579 the need for /bin/sh on the buildslave, making it more likely to
7582 * buildbot/status/html.py: html-escape text in blamelist.
7583 Add "force build" button to the Builder page.
7585 * buildbot/process/step_twisted.py (countFailedTests): look at
7586 last 1000 characters for status line, as import errors can put it
7587 before the -200 point.
7589 2003-05-15 Brian Warner <warner@lothar.com>
7591 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7593 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7594 make 'clobber' a parameter, so it is possible to have builds which
7595 do full tests but do a cvs update instead of hammering the CVS
7596 server with a full checkout each build
7598 * buildbot/process/step.py (InternalShellCommand): bump default
7599 timeout to 20 minutes
7601 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7602 the master to trigger a build. Run it via manhole.
7604 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7605 allow slaves to trigger any build that they host, to make life
7606 easier for slave admins who are testing out new build processes
7608 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7609 don't flunk cReactor or qtreactor on failure, since they fail alot
7610 these days. Do warnOnFailure instead.
7612 * buildbot/process/base.py: change Builder.buildable from a list
7613 into a single slot. When we don't have a slave, new builds (once
7614 they make it past the timeout) are now merged into an existing
7615 buildable one instead of being queued. With this change, a slave
7616 which has been away for a while doesn't get pounded with all the
7617 builds it missed, but instead just does a single build.
7619 2003-05-07 Brian Warner <warner@lothar.com>
7621 * setup.py (version): bump version to 0.3.2+ while between releases
7623 2003-05-07 Brian Warner <warner@lothar.com>
7625 * setup.py: Releasing buildbot-0.3.2
7627 2003-05-07 Brian Warner <warner@lothar.com>
7629 * setup.py: fix major packaging error: include subdirectories!
7631 * NEWS: add changes since last release
7633 * README (REQUIREMENTS): update twisted/python dependencies
7635 * buildbot/status/builder.py (Builder.startBuild): change
7636 BuildProcess API: now they should call startBuild/finishBuild
7637 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7638 keeping a list of builds in the statusbag, to support other kinds of
7640 (Builder.addClient): send current-activity-small to new clients
7641 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7644 * buildbot/status/client.py: drop RemoteReferences at shutdown
7646 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7648 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7649 more debug messages for remote status client
7651 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7652 (.stepFailed): only fire the Deferred once, even if both
7653 stepComplete and stepFailed are called. I think this can happen if
7654 an exception occurs at a weird time.
7656 * buildbot/status/words.py: work-in-progress: IRC status delivery
7658 2003-05-05 Brian Warner <warner@lothar.com>
7660 * docs/examples/twisted_master.py (twisted_app): hush internal
7661 python2.3 distutils deprecation warnings
7662 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7663 add compileOpts= argument which inserts extra args before the
7664 "setup.py build_ext" command. This can be used to give -Wignore
7665 warnings, to hush some internal python-2.3 deprecation messages.
7667 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7668 the ['twisted.test'] default test case to make it easier to change
7671 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7672 * buildbot/clients/gtkPanes.py: ditto
7674 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7675 arg to collapse RunUnitTestsRandomly into RunUnitTests
7676 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7677 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7679 * buildbot/status/html.py (StatusResource): shuffle Resources
7680 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7681 would serve the waterfall display, but the internal links were
7682 only valid on the trailing-slash version. The correct behavior is
7683 for the non-slashed one to serve a Redirect to the slashed one.
7684 This only shows up when the buildbot page is hanging off another
7685 server, like a Twisted-Web distributed server.
7687 * buildbot/status/event.py (Event, RemoteEvent): make Events
7688 pb.Cacheable, with RemoteEvent as the cached version. This removes
7689 a lot of explicit send-an-update code.
7690 * buildbot/status/builder.py (Builder): remove send-update code
7691 * buildbot/status/client.py (ClientBuilder): remove send-update
7692 code, and log errors that occur during callRemote (mostly to catch
7693 InsecureJelly exceptions)
7695 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7696 run Lore with the same python used in the rest of the build
7698 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7700 * buildbot/process/step_twisted.py (HLint): accept 'python'
7701 argument. Catch rc!=0 and mark the step as failed. This marks the
7702 build orange ("has warnings").
7703 (RunUnitTestsJelly): move out to step_twisted2.py
7705 * buildbot/util.py (ignoreStaleRefs): add utility function
7707 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7708 don't fake ETA object, it's too hard to get right
7710 2003-05-02 Brian Warner <warner@lothar.com>
7712 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7714 2003-05-01 Brian Warner <warner@lothar.com>
7716 * buildbot/status/html.py (StatusResource.body): oops, I was
7717 missing a <tr>, causing the waterfall page to be misrendered in
7718 everything except Galeon.
7720 2003-04-29 Brian Warner <warner@lothar.com>
7722 * docs/examples/twisted_master.py: make debuild use python-2.2
7723 explicitly, now that Twisted stopped supporting 2.1
7725 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7726 handle tuple results too. I keep forgetting this, which suggests
7727 it needs to be rethought.
7729 * setup.py (setup): bump version to 0.3.1+ while between releases
7731 2003-04-29 Brian Warner <warner@lothar.com>
7733 * setup.py: Releasing buildbot-0.3.1
7735 2003-04-29 Brian Warner <warner@lothar.com>
7737 * README (SUPPORT): add plea to send questions to the mailing list
7739 * NEWS, MANIFEST.in: add description of recent changes
7741 * docs/examples/twisted_master.py: add the code used to create the
7742 Twisted buildmaster, with passwords and such removed out to a
7745 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7746 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7747 buildmasters to not require CVSToys be installed.
7748 * README, docs/examples/glib_master: update to match the change
7750 * buildbot/clients/base.py, buildbot/bot.py,
7751 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7752 ReconnectingPB from CVSToys distribution to remove CVSToys
7753 dependency for build slaves and status clients. Buildmasters which
7754 use FreshCVSSources still require cvstoys be installed, of course.
7756 2003-04-25 Brian Warner <warner@lothar.com>
7758 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7759 runTestsRandomly arg to turn on trial -z
7761 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7762 experimental code to use trial's machine-parseable output to get
7763 more detailed test results. Still has some major issues.
7764 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7767 * buildbot/status/builder.py (Builder.setCurrentBuild):
7768 anticipating moving build history into statusbag, not used yet
7770 * buildbot/status/tests.py: code to centralize test results,
7771 doesn't work quite yet
7773 * buildbot/status/event.py (Event): use hasattr("setName") instead
7774 of isinstance for now.. need better long-term solution
7776 * buildbot/status/html.py: Remove old imports
7778 2003-04-24 Brian Warner <warner@lothar.com>
7780 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7781 ignore changes under doc/fun/ and sandbox/
7783 * buildbot/process/step_twisted.py: update pushEvent and friends.
7785 * buildbot/status/html.py (Box.td): replace event.buildername with
7786 event.parent.getSwappableName(). Needs more thought.
7788 * buildbot/status/builder.py (Builder): Replace pushEvent and
7789 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7790 Tell events they are being pruned with event.delete().
7792 * buildbot/process/base.py (Build): Remove Builder status-handling
7793 methods. s/pushEvent/setCurrentActivity/.
7795 * buildbot/process/step.py (BuildStep): clean up status delivery.
7796 Gouse builder.statusbag methods instead of intermediate builder
7797 methods. s/updateLastEvent/updateCurrentActivity/.
7798 s/finalizeLastEvent/finishCurrentActivity/. Use
7799 addFileToCurrentActivity for summaryFunction.
7801 * buildbot/status/event.py (Logfile): put data in a Swappable when
7803 (Event): add more setter methods. Remove .buildername, use .parent
7804 and getSwappableName instead (needs more thought).
7806 * buildbot/util.py (Swappable):
7807 * test/test_swap.py: don't bother setting filename at __init__
7808 time, do it later. Change setFilename args to take parent first,
7809 since it provides the most significant part of the filename.
7811 2003-04-23 Brian Warner <warner@lothar.com>
7813 * buildbot/status/event.py (Logfile.addEntry): append to previous
7816 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7817 anticipating Swappable
7818 (InternalShellCommand.remoteUpdate): split out various log-adding
7819 methods so subclasses can snarf stdout separately
7821 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7822 in anticipation of Swappable build logs
7823 (Builder.testsFinished): anticipating TestResults, still disabled
7825 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7828 * buildbot/status/event.py (Logfile): add (disabled) support for
7829 Swappable, not ready for use yet
7831 * buildbot/util.py (Swappable): object which is swapped out to
7832 disk after some period of no use.
7833 * test/test_swap.py: test buildbot.utils.Swappable
7835 2003-04-14 Brian Warner <warner@lothar.com>
7837 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7838 periodic-build timer. Set the .periodicBuildTime on a builder
7839 instance to some number of seconds to activate it.
7841 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7843 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7844 a way that survives result tuples
7846 2003-04-12 Brian Warner <warner@lothar.com>
7848 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7849 return a dict instead of a tuple: allow summarizers to provide
7850 multiple summaries if they want
7851 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7852 (debuildSummarizer): summarize lintian warnings/errors
7854 2003-04-10 Brian Warner <warner@lothar.com>
7856 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7858 2003-04-09 Brian Warner <warner@lothar.com>
7860 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7861 empty summaries: happens when the tests fail so hard they don't emit
7862 a parseable summary line.
7864 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7865 Allow summaryFunction to return None to indicate no summary should
7868 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7869 writing to stale HTTP requests: notice when they disconnect and
7870 remove the request from the list. Also add CacheToFile from
7871 moshez, will be used later.
7873 2003-04-08 Brian Warner <warner@lothar.com>
7875 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7876 should be an int, not a list of strings
7878 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7879 if we weren't actually connected
7881 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7882 to show the tail end of the trial text output
7884 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7885 hook to summarize the results of a ShellCommand
7887 2003-04-07 Brian Warner <warner@lothar.com>
7889 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7890 twisted test suite code into a single class.
7891 * buildbot/process/process_twisted.py: same
7893 2003-04-04 Brian Warner <warner@lothar.com>
7895 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7897 * README (SLAVE): document use of mktap to create slave .tap file
7898 (REQUIREMENTS): describe dependencies
7900 * buildbot/bb_tap.py, buildbot/plugins.tml:
7901 * buildbot/bot.py (updateApplication): Add mktap support for creating
7902 buildslave .tap files
7904 2003-03-28 Brian Warner <warner@lothar.com>
7906 * buildbot/process/step.py (InternalShellCommand.finished): handle
7907 new tuple result values (fix embarrasing bug that appeared during
7910 2003-03-27 Brian Warner <warner@lothar.com>
7912 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7915 2003-03-25 Brian Warner <warner@lothar.com>
7917 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7918 to overall build status
7919 * buildbot/clients/base.py (Builder): improve event printing
7920 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7921 instead of generic ShellCommand
7922 (Build): Add .stopBuild, use it when slave is detached
7924 * buildbot/process/step.py (Configure,Test): give the steps their
7925 own names and status strings
7927 * buildbot/status/html.py (StatusResource): add "show" argument,
7928 lets you limit the set of Builders being displayed.
7930 2003-03-20 Brian Warner <warner@lothar.com>
7932 * buildbot/process/basic.py: removed
7934 2003-03-19 Brian Warner <warner@lothar.com>
7936 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7937 turn off process-docs by default
7939 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7940 when displaying build information without anything in allBuilds[]
7942 * buildbot/bot.py (makeApp): really take password from sys.argv
7944 2003-03-18 Brian Warner <warner@lothar.com>
7946 * buildbot/bot.py (buildApp): take password from sys.argv
7948 * README: replace with more useful text
7950 * setup.py: add a real one
7951 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7953 * docs/PyCon-2003/: added sources for PyCon paper.
7955 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7956 now Build objects control the process and Builder only handles
7957 slave stuff and distribution of changes/status. A new BuildFactory
7958 class creates Build objects on demand.
7960 Created ConfigurableBuild which takes a list of steps to run. This
7961 makes it a lot easier to set up a new kind of build and moves us
7962 closer to being able to configure a build from a web page.
7964 * buildbot/process/step_twisted.py, process_twisted.py: move to
7965 new model. A lot of code went away.
7967 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7968 send lots of empty progress messages to the client.
7970 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7972 2003-02-20 Brian Warner <warner@lothar.com>
7974 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7976 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7977 Twisted bug that prevented non-pty processes from working just got
7978 fixed, and the bug that leaks ptys is still being investigated.
7980 * buildbot/process/step.py (CVS): send timeout arg to slave
7982 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7983 builders coming and going
7984 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7985 from CVSToys, handle lost-buildmaster
7987 * buildbot/status/client.py (StatusClientService.removeBuilder):
7988 Clean up status client protocol: send builders (with references)
7989 as they are created, rather than sending a list and requiring the
7990 client to figure out which ones are new.
7991 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7992 attempts to force a build on an unknown builder
7994 2003-02-19 Brian Warner <warner@lothar.com>
7996 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7997 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7998 Twisted stops leaking them.
7999 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8000 builder goes to an idle state.
8002 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8003 I figure out why CVS commands hang without them, and/or I fix the
8004 hung-command timeout
8006 2003-02-16 Brian Warner <warner@lothar.com>
8008 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8009 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8010 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8011 GenerateDocs now that they are prefixed with WARNING:.
8013 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8014 use manual href target instead of request.childLink
8016 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8017 display every second, but update the ETA every 5 seconds (or
8018 whenever) as remote_progress messages arrive.
8021 2003-02-12 Brian Warner <warner@lothar.com>
8023 * *: import current sources from home CVS repository
8027 # add-log-time-format: add-log-iso8601-time-string