1 2007-08-07 Brian Warner <warner@lothar.com>
3 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
4 'Owner:' field of the view, rather than 'p4logname', since
5 p4logname comes from the buildslave's environment and seems
6 unlikely to ever do the right thing. Thanks to Wade Brainerd for
9 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
10 which imposes a per-slave limit on how many builds are allowed to
11 run simultaneously. This has a the same scope than the SlaveLock,
12 but is different because max_builds= gives the buildmaster the
13 freedom to assign the build to a different slave, whereas the
14 SlaveLock doesn't get tested until after the build is irrevocably
15 assigned to a slave. Therefore using max_builds= will improve
16 utilization in the presence of multiple buildslaves that are
17 attached to the same Builder. This completes the incorporation of
18 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
19 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
20 any Builder finishes, potentially trigger *all* Builders, since
21 max_builds= may have stalled someone else while waiting for the
23 * buildbot/scripts/sample.cfg: mention max_builds=
24 * buildbot/test/test_run.py (ConcurrencyLimit): test it
25 * docs/buildbot.texinfo (Buildslave Specifiers): document it
27 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
28 inherit from RunMixin do not need to call master.stopService()
29 themselves, since RunMixin.tearDown does that. The double call
30 fails on Twisted-2.0.x, which didn't happen to protect against it.
31 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
33 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
34 from #48, this one to have the BuildSlave objects track
35 SlaveBuilders, so they'll be able to use that knowledge to
36 influence their canStartBuild() response.
37 * buildbot/process/builder.py (SlaveBuilder.attached): call it
38 (SlaveBuilder.detached): same
39 * buildbot/test/test_slaves.py (BuildSlave): test it
41 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
42 the second of Dustin's #48 patches, this one adding a method to
43 the BuildSlave that allows it to decide whether it is willing to
44 participate in a build or not.
45 (SlaveBuilder.isAvailable): use canStartBuild() to decide
47 * buildbot/test/test_run.py (CanStartBuild): test for it
49 * all: incorporate the first of four patches by Dustin Mitchell
50 from ticket #48, working towards improving control over slave
51 concurrency. The first patch is to use a long-lived BuildSlave
52 object per slave, on which other behavior can be added later. I've
53 modified his patch considerably.
54 * buildbot/buildslave.py (BuildSlave): move class out of
55 slave/__init__.py (where it would get loaded by the slave as well
56 as the master, making dependencies trickier), and merge it with
57 BotPerspective. Now these BuildSlave instances are created once in
58 the master.cfg file, and not destroyed until they are either
59 removed from the config file or changed so
60 much (name/password/class changes) that we cannot continue to use
61 the old one. This affects config files: they must use
62 'from buildbot.buildslave import BuildSlave' instead of using
63 'from buildbot.slave import BuildSlave'.
64 * buildbot/master.py: move BotPerspective out
65 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
66 add or remove as necessary, update the rest using data from
68 * buildbot/slave/__init__.py: move BuildSlave out
69 * buildbot/test/test*.py: import BuildSlave from the new place
70 * buildbot/scripts/sample.cfg: update to match
71 * docs/buildbot.texinfo: update to match
72 * buildbot/process/builder.py: update comments to match
74 2007-08-02 Brian Warner <warner@lothar.com>
76 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
77 one-line-per-build pages a bit, add a header, refactor slightly
79 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
80 the TimeOutError timer, patch by Dustin Mitchell.
82 2007-08-01 Brian Warner <warner@lothar.com>
84 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
85 mostly work (branch= is still ignored, we need a useful header)
86 (OneLinePerBuildOneBuilder.body): this too
88 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
89 bring this up-to-date w.r.t. recent refactorings, and fix
90 redirections to bounce the browser to the top page after hitting
91 the 'force' button. This needs to be improved, but at least it now
92 redirects to a valid page.
93 (StatusResourceBuilder.ping): same
94 (StatusResourceBuilder.getChild): same, although I think this code
97 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
98 a branch= query argument, to filter the display down to builds and
99 changes that involve the given branch. You can add multiple
100 branch= arguments to see multiple branches (using a logical OR).
101 Note that there is no way to include the default branch (i.e.
102 None, i.e. trunk) yet, there is still work to be done to allow for
103 simple+uniform names of branches (i.e. removing the VC-specific
104 details of how branches are implemented, so calling the branch
105 'beta4' even though the SVN checkout step requires
107 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
108 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
109 * buildbot/interfaces.py (IEventSource.eventGenerator): same
110 * docs/buildbot.texinfo (Buildbot Web Resources): document it
112 * all: bring import statements up-to-date: don't import
113 __future__, assume cPickle and cStringIO are always available.
114 Also remove #!/usr/bin/python lines from non-scripts, my editor
115 has been a bit over-enthusiastic about stuffing them into new .py
118 * buildbot/status/web/index.html: put a link to the waterfall page
119 on the index, otherwise first-time users of WebStatus aren't going
120 to see anything very interesting.
122 * buildbot/interfaces.py (IEventSource): document this interface.
123 Thanks to Dustin Mitchell for the patch. Closes #60.
124 * buildbot/status/builder.py (BuilderStatus): same
125 * buildbot/changes/changes.py (ChangeMaster): same
127 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
128 add a query arg of 'show_events=true' to display non-build events,
129 like slaves attaching/detaching and reconfig events, or
130 'show_events=false' to hide them. The default is 'true'.
131 * docs/buildbot.texinfo (Buildbot Web Resources): document it
133 * web-parts: merge in web-parts branch. Lots of changes. The new
134 functionality is to add buildbot.status.html.WebStatus, which is a
135 superset of the Waterfall that adds new status pages and serves
136 regular files from BASEDIR/public_html/ , which is now the preferred
137 place to put robots.txt, buildbot.css, and index.html .
138 * buildbot/scripts/runner.py: the 'create-master' command now
139 creates public_html/ too, and populates it with a couple of
141 * buildbot/status/web: split waterfall code into smaller pieces
143 2007-07-31 Brian Warner <warner@lothar.com>
145 * buildbot/scripts/startup.py (launch): import twistd.run in a
146 different way to hush pyflakes
147 * buildbot/process/builder.py: remove unused import
149 2007-07-30 Brian Warner <warner@lothar.com>
151 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
152 Mitchell: pass SourceStamps around rather than branch/version/etc
153 tuples. Thanks Dustin! Closes #70.
154 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
155 tuple rather than a list, to avoid surprising mutations
156 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
157 * buildbot/status/mail.py (MailNotifier.buildMessage): same
158 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
159 * buildbot/test/test_status.py (Subscription): same
160 * buildbot/test/test_control.py (Force): same
161 * buildbot/test/test_buildreq.py (Request.testMerge): same
163 2007-07-29 Brian Warner <warner@lothar.com>
165 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
166 variable, since it wasn't used and is confusing in the presence of
167 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
170 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
171 the Buildbot home-page link to point at buildbot.net instead of
172 sourceforge, and add a current-version query parameter so we can
173 get some statistics on which versions are in use out there.
175 2007-07-28 Brian Warner <warner@lothar.com>
177 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
178 with c['change_source'], leaving c['sources'] for backwards
179 compatibility (but deprecated), scheduled for removal in 0.8.0
180 * docs/buildbot.texinfo: same
181 * buildbot/test/test_config.py: verify that c['sources'] still works
182 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
183 * buildbot/scripts/sample.cfg: update to match
185 * buildbot/changes/mail.py (MaildirSource): parse with python's
186 stdlib 'email' module, which has been available since python2.2,
187 and drop use of the 'rfc822' module, which has been depreceated
189 * buildbot/test/test_maildir.py: same: use parse_file() not parse
191 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
192 this needs to match the renaming in test/mail/msg*
194 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
197 * buildbot/test/test_mailparse.py: rename sample emails a bit
198 * buildbot/test/mail/msg*: same
200 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
201 parser for the "commit-email.pl" script that is shipped with SVN,
202 written by Justin Mason. Thanks! Closes SF#1072845.
203 * buildbot/test/mail/svn-commit.*: sample messages
204 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
205 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
207 2007-07-27 Brian Warner <warner@lothar.com>
209 * buildbot/changes/mail.py: refactor: move parsing into a method
210 named 'parse', each parser type gets a separate subclass. Remove
211 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
212 to be a simple leading-substring match. Add a warning to the logs
213 if prefix= does not end in a slash, since that's probably a
214 mistake. Fix both places where a prefix= mismatch would skip all
215 subsequent files in the same email, instead of just skipping the
216 one that didn't match.
217 * buildbot/test/test_mailparse.py: match changes
219 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
220 docs on email-based ChangeSources
222 * docs/buildbot.texinfo (Getting Source Code Changes): move all
223 the changesource types up a level, removing the one-entry menu in
226 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
227 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
228 instances instead of tuples. Closes #63.
229 * buildbot/slave/__init__.py (BuildSlave): define marker class
230 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
231 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
232 * buildbot/test/test_*.py: update tests to match
233 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
234 the c['bots'] backwards-compatibility handler works
236 2007-07-26 Brian Warner <warner@lothar.com>
238 * buildbot/changes/hgbuildbot.py (hook): add an in-process
239 Mercurial change-sending hook, contributed by Frederic Leroy.
240 Thanks! Addresses #50.
241 * docs/buildbot.texinfo (MercurialHook): document it
243 * buildbot/changes/hgbuildbot.py: change the way imports are done,
244 to make it compatible with at least hg-0.9.1 and the current 0.9.4
246 2007-07-17 Brian Warner <warner@lothar.com>
248 * buildbot/process/buildstep.py (BuildStep.getLog): add a
249 convenience method to retrieve a log added with
250 addLog()/addCompleteLog()/etc or logfiles= . I should have added
253 2007-07-03 Brian Warner <warner@lothar.com>
255 * buildbot/slave/commands.py (ShellCommand._startCommand): when
256 logging the environment variables, put one variable on each line,
257 rather than having one really long line with all of them. This
258 should make them a bit more readable and not trigger the
259 horizontal scrollbar (when viewing it in a web browser) quite so
260 much. Thanks to Albert Hofkamp for the patch.
262 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
263 WithProperties instance. Thanks to Axel Hecht for the patch.
265 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
266 * docs/buildbot.texinfo (Build Properties): document it
267 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
268 workdir if it didn't already exist.
270 * docs/buildbot.texinfo (Scheduler Types): correct the description
271 of Dependent schedulers. Thanks to Greg Ward for the patch.
273 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
274 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
275 the patch. Closes #49.
277 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
278 0700 before removing it, to deal with situations where a build will
279 leave files around without write permissions and the 'copy' or
280 'clobber' VC checkout modes need to blow away the tree first.
281 Thanks to Steve Milner for the suggestion and the patch (which I
282 mangled horribly). Closes #29.
283 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
286 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
287 an allowReconnect= argument to let callers control whether they
288 want this don't-let-it-reconnect behavior, since some tests care.
289 Factor out the .continueTrying=False lines from those callers.
290 * buildbot/test/test_slaves.py: same
291 * buildbot/test/test_run.py: same
293 2007-07-02 Brian Warner <warner@lothar.com>
295 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
296 slave has been disappeared, don't let it reconnect. This was
297 causing an intermittent failure in test_slaves.py, when the slave
298 that was supposed to be gone managed to come back by the end of
299 the test and affect the count.
300 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
302 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
303 diagnostic messages to track down this problem
304 (Builder.startBuild): same
306 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
307 the slave randomly rather than always taking the first one. Thanks
308 to Pike for the patch. Closes #36.
309 * buildbot/test/test_slaves.py: match the change. to avoid huge
310 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
311 enables/disables the round-robin-ness (enabled by default), and
312 some unit tests disable it.
313 * docs/buildbot.texinfo (Buildmaster Architecture): document it
315 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
316 argument to 'buildmaster_host', to make it more obvious that this
317 points to the buildmaster. Thanks to Bob Proulx for the
319 * buildbot/scripts/runner.py (slaveTAC): same
320 * buildbot/test/test_runner.py (Create.testSlave): match the change
322 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
325 2007-06-17 Brian Warner <warner@lothar.com>
327 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
328 we can round-trip all of our current step classes by calling
329 getStepFactory() and using the results to make a clone of the
332 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
335 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
336 the config file, we're moving to using actual instances instead of
337 the (class, kwargs) 'step specification' tuples. BuildFactory
338 still keeps a list of tuples internally, but when real instances
339 are passed in to addStep(), they are asked for their class and
340 kwargs using the new BuildStep.getStepFactory method. BuildFactory
341 accepts both instances and the tuple form, and converts instances
342 to the tuple form, but the instance form is preferred because it
343 gives the Steps a chance to do argument validation. Closes: #11.
345 * buildbot/process/buildstep.py (BuildStep.__init__): record the
346 factory information necessary to implement getStepFactory. The
347 addFactoryArguments() method can be used to include arguments that
348 aren't passed to the BuildStep base class constructor.
349 (BuildStep.setBuild):
350 (BuildStep.setDefaultWorkdir): new methods to take parameters that
351 are needed for live BuildSteps but not to construct the specification
352 tuples that are stashed in the factory.
354 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
355 'workdir' into new BuildSteps by using methods instead of
356 arguments. This makes the constructor for BuildSteps a lot
359 * buildbot/steps/*.py: update to match this change. Basically this
360 means adding calls to addFactoryArguments() in the __init__
361 methods to capture the arguments that aren't passed through to the
363 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
364 the new workdir (if any) into the RemoteShellCommands arguments.
365 * buildbot/steps/source.py: allow workdir= to be optional,
366 implement setDefaultWorkdir() since we don't inherit from
367 (CVS): finally remove old clobber=/export=/copydir= arguments,
368 in favor of the mode= argument that's been around forever now.
369 * buildbot/steps/transfer.py: remove build= argument
371 * buildbot/test/*.py: update to match, generally by turning all
372 build= arguments into subsequent calls to s.setBuild()
373 * buildbot/test/test_config.py (Factories): verify that we can
374 use either BuildStep instances or class/kwarg tuples in both
375 BuildFactory.addStep and BuildFactory.__init__
377 * docs/buildbot.texinfo (Build Steps): document the new approach,
378 mention compatibility with the old approach, update all examples
379 to use the new style.
381 2007-06-16 Brian Warner <warner@lothar.com>
383 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
384 the LoopingCall, just eat the failure so that we'll poll again
385 next time. This should allow us to tolerate (e.g.) sf.net SVN
386 failures more gracefully. Many thanks to Dustin Mitchell for the
389 2007-05-17 Brian Warner <warner@lothar.com>
391 * buildbot/status/words.py: refactor the IRC status bot into
392 separate 'Contact' and 'Channel' classes. The base Contact class
393 contains the interaction code: commands and responses. The
394 IRCContact subclass (and IrcStatusBot 'Channel') handle the
395 IRC-specific aspects. The plan is to write other subclasses for
396 other IM protocols like AIM and Jabber.
398 2007-04-16 Brian Warner <warner@lothar.com>
400 * CREDITS: update list of contributors. Thank you all!
402 2007-04-13 Brian Warner <warner@lothar.com>
404 * buildbot/status/mail.py (MailNotifier): add the project name to
405 the subject line and message body, to make it easier to
406 distinguish email coming from different buildmasters. Thanks to
407 Benoit Sigoure for the patch.
408 * buildbot/test/test_status.py (Mail): update to match
410 2007-03-24 Brian Warner <warner@lothar.com>
412 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
413 avoid text-conversion problems between DOS/windows and unix.
414 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
416 2007-03-03 Brian Warner <warner@lothar.com>
418 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
419 warning about the use of Waterfall here
421 2007-03-01 Brian Warner <warner@lothar.com>
423 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
425 2007-02-28 Brian Warner <warner@lothar.com>
427 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
428 Lamb to use a more optimal form of 'p4 changes', to reduce server
429 load. He reports that this optimization was added to p4d release
430 2005.2, but it should work in all versions. Closes #27.
431 * buildbot/test/test_p4poller.py: match it
433 2007-02-27 Brian Warner <warner@lothar.com>
435 * buildbot/status/web/*.py: move all web status stuff into a
436 separate directory, in anticipation of splitting it into smaller
437 pieces and adding more files. html.py was getting way too big.
438 * buildbot/status/classic.css: move it too
439 * setup.py: add the new sub-package
440 * buildbot/test/test_web.py: match the changes
441 * MANIFEST.in: handle the move of classic.css
443 2007-02-07 Brian Warner <warner@lothar.com>
445 * contrib/OS-X/*: add some launchd .plist files for automatically
446 starting a buildmaster or buildslave under OS-X (10.4 or later).
447 Thanks to Mark Pauley for these.
449 2007-02-06 Brian Warner <warner@lothar.com>
451 * docs/buildbot.texinfo (Requirements): update requirements to
452 stop claiming compatibility with python-2.2 or twisted-1.3.x .
454 * README: mention python-2.5 and twisted-2.5 compatibility
456 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
458 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
460 * buildbot/status/builder.py: same, by requiring cStringIO
461 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
462 * buildbot/test/test_vc.py: same
463 * buildbot/test/test_web.py:
464 * buildbot/test/test_steps.py: same, remove unused import
466 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
469 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
470 see any Builders that don't have Schedulers to drive them
472 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
473 attributes this uses went away
475 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
476 dialog, to allow you to reset the buildmaster and force
477 connect/disconnect. Correctly handle losing the buildmaster
478 connection (by switching the display to the hexnut, at which point
479 you can use the 'Connect' menu item to reconnect).
481 * buildbot/steps/source.py (Source.start): if we're using a patch,
482 add it as a LogFile to the checkout/update step. This will turn
483 into a link on the waterfall page.
485 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
486 option, to take the patch from a pre-made file rather than
487 generating it from the local tree. Thanks to Robert Helmer for the
488 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
489 * buildbot/scripts/runner.py (TryOptions): add --diff,
490 --patchlevel, and --baserev options
491 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
492 as None, meaning HEAD.
493 * buildbot/sourcestamp.py (SourceStamp): update docstring to
494 indicate that baserev=None means HEAD
495 * docs/buildbot.texinfo (try --diff): document it
497 * buildbot/test/test_steps.py (BuildStep): remove use of
498 reactor.iterate(), although the technique I replaced it with is a
499 gross polling hack that must be cleaned up properly some day. This
500 was the last use of reactor.iterate in the entire tree, yay.
502 2007-02-05 Brian Warner <warner@lothar.com>
504 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
505 is one of the three known values, otherwise we emit some confusing
506 messages later on. Thanks to Grig Gheorghiu for the catch.
508 2007-01-30 Brian Warner <warner@lothar.com>
510 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
511 Hearsum contributed a patch to let BonsaiPoller work with results
512 that contain non-ascii characters. Closes SF#1632641.
514 2007-01-27 Brian Warner <warner@lothar.com>
516 * Makefile (release): produce both .tar.gz and .zip source bundles.
519 2007-01-23 Brian Warner <warner@lothar.com>
521 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
522 * buildbot/changes/monotone.py: same
524 * buildbot/changes/maildir.py: combine several files into one,
525 clean up maildir.py to use Services properly.
526 * buildbot/changes/maildirtwisted.py: remove
527 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
529 * buildbot/changes/mail.py: match the change
530 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
531 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
533 * buildbot/slave/commands.py (command_version): bump to "2.3" to
534 indicate that the buildslave knows about the 'bzr' command
536 2007-01-22 Brian Warner <warner@lothar.com>
538 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
539 'with', it will become a reserved work in python2.6 .
541 * contrib/bb_applet.py: add a simple gnome-panel applet, to
542 display a terse summary of buildbot status.
543 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
544 some icons, small versions of the Blender object that lives in
545 docs/images/icon.blend
547 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
548 * buildbot/slave/commands.py (Bzr): same
549 * buildbot/scripts/tryclient.py (BzrExtractor): same
550 (SourceStampExtractor.dovc): modify this to allow non-zero exit
551 status, since 'bzr diff' does that
552 * buildbot/test/test_vc.py (Bzr): same
553 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
557 2007-01-20 Brian Warner <warner@lothar.com>
559 * contrib/darcs_buildbot.py: tidy up the progress messages
561 2007-01-17 Brian Warner <warner@lothar.com>
563 * contrib/darcs_buildbot.py: enhance to handle multiple patches
564 being pushed at a time. This keeps state in the repository in a
565 small file named .darcs_buildbot-lastchange, but that shouldn't
566 interfere with normal repository operations. Fixes SF#1534049.
567 * buildbot/clients/sendchange.py (Sender): make a single Sender
568 capable of sending Changes with different usernames.
570 2006-12-11 Brian Warner <warner@lothar.com>
572 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
573 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
574 buildbot.changes.mail a long time ago, but I forgot to add the
575 DeprecationWarning until now.
577 * buildbot/process/maxq.py: remove this, the functionality now
578 lives in buildbot.steps.maxq
580 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
581 * buildbot/clients/gtkPanes.py: remove unused import
583 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
584 that was meant to provide a special Reporter to run inside trial
585 and give the buildslave lots of machine-readable status. We never
586 finished this project.
588 * buildbot/changes/bonsaipoller.py: remove unused imports
589 * buildbot/changes/svnpoller.py: same
590 * buildbot/process/builder.py: same
591 * buildbot/process/buildstep.py: same
592 * buildbot/slave/bot.py: hush pyflakes warning
593 * buildbot/status/tests.py: remove unused imports
594 * buildbot/status/tinderbox.py: same
595 * buildbot/steps/python_twisted.py: same
597 * buildbot/process/step.py: remove this file, these names were
598 deprecated in 0.7.5 and are now being removed.
599 * buildbot/process/step_twisted.py: same
600 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
602 * buildbot/twcompat.py: remove the empty file, yay it is gone
604 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
605 tw-2.0.0 and newer have the method we need.
606 (getProcessOutputAndValue): same
607 (which): remove this method, tw-2.0.0 t.p.procutils has it
609 * buildbot/twcompat.py (implements): remove this method
610 * buildbot/*: import implements() from zope.interface directly
612 * buildbot/status/mail.py: stop falling back to importing
613 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
616 * buildbot/twcompat.py (Interface): remove this import
617 * buildbot/*: import Interface from zope.interface directly
619 * buildbot/twcompat.py (providedBy): remove this method
620 * buildbot/*: turn all uses of providedBy(obj, iface) into
621 iface.providedBy(obj)
623 * buildbot/twcompat.py (maybeWait): remove this method, now that
624 we no longer maintain compatibility with Twisted<=1.3.0 .
625 Twisted-2.0.0 and later allow trial methods to return Deferreds
627 * buildbot/test/*: remove all uses of maybeWait
629 * buildbot/__init__.py (version): bump to 0.7.5+ while between
631 * docs/buildbot.texinfo: same
633 2006-12-10 Brian Warner <warner@lothar.com>
635 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
636 * docs/buildbot.texinfo: set version to match
638 2006-12-10 Brian Warner <warner@lothar.com>
640 * README (REQUIREMENTS): update for release
641 * NEWS: update for release
642 * buildbot/slave/commands.py (command_version): mention that this
643 version (2.2) was released with buildbot-0.7.5
645 * buildbot/test/test_config.py (StartService.testStartService):
646 inhibit the usual read-config-on-startup behavior, since otherwise
647 the log.err that gets recorded causes the test to fail
649 * buildbot/status/builder.py (LogFile.finish): forget about all
650 subscribers once the log has finished, since after that point
651 we're never going to use them again. This might help free up some
654 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
655 than the old/deprecated gtk.mainquit()
657 2006-12-09 Brian Warner <warner@lothar.com>
659 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
660 better when we can't open the masterdst file
662 * buildbot/scripts/startup.py (Follower._failure): add missing
663 import statement for BuildSlaveDetectedError
665 * buildbot/steps/transfer.py (FileUpload): cleanup
666 (FileDownload): same. Add tests for slave version, add mode=.
667 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
668 (SlaveFileDownloadCommand): same
669 * buildbot/test/test_transfer.py: enhance tests
670 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
673 2006-12-08 Brian Warner <warner@lothar.com>
675 * buildbot/scripts/runner.py (sendchange): halt the reactor on
676 both success *and* failure. Without this, the 'buildbot
677 sendchange' command would hang if it could not contact the
678 buildmaster or deliver the Change, which would generally cause the
679 user's commit/record/checkin command to hang too. Thanks to
680 Christian Unger for the catch.
682 2006-12-06 Brian Warner <warner@lothar.com>
684 * NEWS: update with items for the next release
686 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
687 whimsical example pulled from a punch-drunk email I sent out late
689 (Transferring Files): document some of the other parameters
690 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
691 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
692 * buildbot/test/test_svnpoller.py: same
693 * buildbot/changes/svnpoller.py (SVNPoller): same
695 2006-11-26 Brian Warner <warner@lothar.com>
697 * docs/buildbot.texinfo (Build Properties): remind users that
698 WithProperties must appear in a command= list, not as a top-level
700 * buildbot/steps/shell.py (ShellCommand.start): and assert that
701 we're sending a list or a single string to the RemoteShellCommand
703 * buildbot/scheduler.py (Nightly): Improve docs slightly.
705 * buildbot/scripts/startup.py (start): skip the whole
706 watch-the-logfile thing under windows, since it needs os.fork()
708 * buildbot/scripts/runner.py (restart): remove the old message
709 that got printed after the buildbot was restarted.. it most cases
710 it didn't get printed at the right time anyways
712 2006-11-25 Brian Warner <warner@lothar.com>
714 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
715 follow twistd.log and print lines until the process has started
716 started properly. For the buildmaster, this means until the config
717 file has been parsed and accepted. For the buildslave, this means
718 until we've connected to the master. We give up after 5 seconds in
719 any case. Helpful error messages and troubleshooting suggestions
720 are printed when we don't see a successful startup. This closes the
721 remainder of SF#1517975.
722 * buildbot/scripts/startup.py: moved app startup code to here
723 * buildbot/scripts/logwatcher.py: utility class to follow log
724 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
725 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
726 so the LogWatcher can tell the difference between a buildmaster
729 2006-11-24 Brian Warner <warner@lothar.com>
731 * docs/examples/twisted_master.cfg: update to match the version
732 in use on twistedmatrix.com
733 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
734 was using before stopped working, but 'irc.freenode.net' works
737 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
740 * buildbot/clients/base.py (TextClient.not_connected): upon
741 UnauthorizedLogin failures, remind the user to connect to the
742 PBListener port instead of the slaveport.
743 (TextClient.disconnected): shut down more quietly
744 * docs/buildbot.texinfo (statuslog): add another reminder
746 * buildbot/scripts/runner.py (Options.subCommands): rename
747 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
748 'sighup' as an alias.
749 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
750 reconfig command to follow twistd.log and print all of the lines
751 from the start of the config-file reload to its completion. This
752 should make it a lot easier to discover bugs in the config file.
753 Use --quiet to disable this behavior. This addresses half of
754 SF#1517975, the other half will be to add this same utility to
755 'buildbot start' and 'buildbot restart'.
756 * docs/buildbot.texinfo (Loading the Config File): same
759 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
760 method, it has been deprecated for a long time. Use
761 IBuilderControl.requestBuild instead.
762 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
763 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
764 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
765 * buildbot/test/test_control.py (Force.testForce): same
766 * buildbot/test/test_run.py: use requestBuild instead
768 * buildbot/clients/debug.py: replace 'Force Build' button with
769 'Request Build' (which just adds one to the queue), add Ping
770 Builder, add branch/revision fields to Request Build.
771 * buildbot/clients/debug.glade: same
772 * buildbot/master.py: update interface to match. This creates an
773 incompatibility between new debugclients and old buildmasters.
775 * buildbot/process/builder.py (Builder._attached): delay the call
776 to maybeStartBuild for a reactor turn, to avoid starting a build
777 in the middle of a reconfig (say, if the new Builder uses a new
778 slave which is already connected).
780 2006-11-23 Brian Warner <warner@lothar.com>
782 * buildbot/test/test_transfer.py: appease pyflakes
783 * buildbot/test/test_steps.py: same
785 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
786 keeps pyflakes from finding undefined names
788 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
789 Builder no longer induces a disconnect/reconnect cycle. This means
790 that any builds currently in progress will not be interrupted, and
791 any builds which are queued in the Builder will not be lost. This
792 is implemented by having the new Builder extract the state (i.e.
793 all pending Builds and any desired SlaveBuilders) from the old
795 (BotPerspective): refactor. The BotPerspective no longer keeps
796 track of all the Builders that want to use this slave; instead, it
797 asks the BotMaster each time it needs this list. This removes
798 addBuilder and removeBuilder. Clean up attached() to acquire all
799 the slave's information in a more atomic fashion. updateSlave() is
800 now the way to make sure the slave is using the right set of
801 Builders: just call it after everything else has been
803 (BotMaster): refactor, removing addBuilder/removeBuilder and
804 replacing them with an all-at-once setBuilders() call.
806 * buildbot/test/test_slaves.py (Reconfig): new test case to
807 exercise this functionality
808 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
809 * buildbot/slave/commands.py (WaitCommand): same
811 * docs/buildbot.texinfo (Loading the Config File): document the
814 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
815 SlaveBuilder to have its parent Builder changed.
816 (SlaveBuilder.isAvailable): new method to give access to state,
817 which is now a private attribute
818 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
819 the SlaveBuilder about how it is being used. These methods update
820 its internal state. buildFinished() is now the place that invokes
821 maybeStartBuild() on its parent Builder.
822 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
823 new Builder to take over for an old one, transferring state from
825 (Buider): refactor the way that SlaveBuilders are used to match,
826 giving them a bit more autonomy.
827 (Builder.buildFinished): this no longer calls maybeStartBuild():
828 instead the SlaveBuilder calls it on whoever its parent Builder is
829 at the time. This way, when an old Builder is replaced by a new
830 one, and there was a build in progress during the transition, when
831 that build finishes, it will be the new Builder that is told about
832 the newly available slave so it can start a new build.
834 * buildbot/process/base.py (Build.startBuild._release_slave): when
835 the Build finishes, tell the SlaveBuilder that they've been
838 * buildbot/status/builder.py (SlaveStatus): add some new setter
839 methods for use by BotPerspective, to keep some attributes more
842 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
843 called by the buildmaster.
844 (Bot.setBuilderList): instead, we locally announce any leftover
845 directories based upon which Builders we were told about. The
846 master doesn't really care; it's the local admin who may or may not
850 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
851 to allow use of python2.4 or whatever. This tool still requires
854 2006-11-19 Brian Warner <warner@lothar.com>
856 * NEWS (IStatusLog.readlines): more news items
858 2006-11-18 Brian Warner <warner@lothar.com>
860 * NEWS: start collecting items for the next release.
862 2006-11-04 Brian Warner <warner@lothar.com>
864 * buildbot/changes/bonsaipoller.py: apply updates from Ben
865 Hearsum. Closes SF#1590310.
866 * buildbot/test/test_bonsaipoller.py: and tests
868 * buildbot/status/tinderbox.py
869 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
870 status when the build results in WARNINGS. Patch from Dave
871 Liebreich. Closes SF#1587352.
873 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
874 linux-vs-osx behavior difference w.r.t. reading from files that
875 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
876 to Mark Rowe for the patch.
878 2006-10-15 Brian Warner <warner@lothar.com>
880 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
881 method name was misspelled in the interface definition. Thanks to
882 Roy Rapoport for the catch.
884 2006-10-13 Brian Warner <warner@lothar.com>
886 * docs/buildbot.texinfo (Adding LogObservers): update sample code
887 to match the great Steps renaming
889 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
890 Maybe I should run my own unit tests before recording a big
891 change. Good thing I've got a buildbot to remind me.
893 2006-10-12 Brian Warner <warner@lothar.com>
895 * buildbot/steps/transfer.py: rework __init__ and args setup
896 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
898 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
899 when opening the target file, only catch IOError (to report via
900 stderr/rc!=0), let the others be reported as normal exceptions
902 2006-10-08 Brian Warner <warner@lothar.com>
904 * contrib/svn_watcher.py: fix security holes by using proper argv
905 arrays and subprocess.Popen() rather than commands.getoutput().
906 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
907 is deprecated in favor of buildbot/changes/svnpoller.py, and will
908 probably be removed by the next release.
911 2006-10-04 Brian Warner <warner@lothar.com>
913 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
914 initial lines that weren't emitted by pyflakes. When the pyflakes
915 command is run under a Makefile, 'make' will echo the command it
916 runs to stdio, and that was getting logged as a "misc" warning.
917 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
918 * buildbot/test/test_steps.py (testPyFlakes3): another test
920 2006-10-01 Brian Warner <warner@lothar.com>
922 * buildbot/status/html.py (HtmlResource.render): if we get a
923 unicode object from our content() method, encode it into utf-8
924 like we've been claiming to all along. This allows the comments
925 and author names from svnpoller.py to be delivered properly.
927 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
928 de-unicodify filenames before creating the Change, because the
929 rest of buildbot is unlikely to handle them well. Leave the 'who'
930 field as a unicode object.. I don't think there's anything that
931 will break very soon, and it will probably nudge us towards
932 accepting unicode everywhere sooner or later. Stop using the
933 "date" field that comes out of SVN, since it is using the
934 repository's clock (and timezone) and what we care about is the
935 buildmaster's (otherwise Changes from the future show up later
936 than the builds they triggered).
937 * buildbot/test/test_svnpoller.py (Everything.test1): match the
940 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
941 Suvbersion repository polling ChangeSource. I've hacked it up
942 considerably: any bugs are entirely my own fault. Thank you
944 * buildbot/test/test_svnpoller.py: tests for it
945 * docs/buildbot.texinfo (SvnSource): document it
947 2006-09-30 Brian Warner <warner@lothar.com>
949 * buildbot/scheduler.py (Periodic): submit a reason= to the
950 BuildSet to indicate which Scheduler triggered the build. Thanks
951 to Mateusz Loskot for the suggestion.
953 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
955 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
956 changes: set self.loop in __init__, remove unused volatile=
958 * docs/buildbot.texinfo (.buildbot config directory): add more
959 docs on the .buildbot/options keys used by "buildbot try"
960 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
961 (Try.deliverJob): same
963 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
967 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
968 close the filehandle when we stop watching the file. Before, the
969 filehandle was only closed when the LogFileWatcher was
970 garbage-collected, which could be quite a while in the future. If
971 it was still open by the time the next build started, windows will
972 refuse to let the new build delete the old build/ directory. Fixes
973 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
974 #twisted for the catch.
976 2006-09-29 Brian Warner <warner@lothar.com>
978 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
981 2006-09-25 Brian Warner <warner@lothar.com>
983 * setup.py: the new buildbot.steps module wasn't being installed.
984 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
985 (testmsgs): add the extra stuff from buildbot/test/* so you can
986 run unit tests on an installed copy of buildbot, not just from
989 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
990 columns of 'svnlook changed' output contain status information, so
991 strip [:4] instead of [:6]. Depending upon what the status flags
992 were, this would sometimes lead to mangled filenames. Thanks to
993 Riccardo Magliocchetti for the patch. Closes SF#1545146.
995 * buildbot/steps/source.py (Monotone): initial Monotone support,
996 contributed by Nathaniel Smith. Still needs docs and tests, but
997 this code has been in use on the Monotone buildbot for a long
999 * buildbot/slave/commands.py (Monotone): slave-side support
1000 * buildbot/changes/monotone.py (MonotoneSource): polling change
1003 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1004 contributed a Change Source that polls a Bonsai server (a
1005 kind of web-based viewcvs CGI script).
1007 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1008 Hearsum contributed a status plugin which sends email in the same
1009 format that Tinderbox does: this allows a number of tinderbox
1010 tools to be driven by Buildbot instead. Thanks Ben!
1012 2006-09-24 Brian Warner <warner@lothar.com>
1014 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1015 Thanks to Robert Helmer for the patch.
1017 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1018 BuildStatus about the buildslave name at the *beginning* of the
1019 build, rather than at the end. Thanks to Alexander Lorenz for the
1021 * buildbot/status/html.py (StatusResourceBuild.body): always
1022 include the slavename in the build page, not just when the build
1024 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1025 slavename in the email message
1027 2006-09-21 Brian Warner <warner@lothar.com>
1029 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1031 * docs/examples/glib_master.cfg: same
1032 * docs/examples/hello.cfg: same
1033 * docs/examples/twisted_master.cfg: same, update to current usage
1035 2006-09-19 Brian Warner <warner@lothar.com>
1037 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1038 (PyFlakes.createSummary): make it compatible with python-2.2
1040 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1041 for at least the output-parsing parts of PyFlakes
1043 2006-09-18 Brian Warner <warner@lothar.com>
1045 * buildbot/steps/python.py: oops, fix import of StringIO
1047 2006-09-17 Brian Warner <warner@lothar.com>
1049 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1050 turns out that SVN-1.4.0 doesn't fail to update once you've
1051 replaced a file with a directory, unlike older versions of SVN and
1052 pretty much every other VC tool we support. Since what we really
1053 care about is that the update succeeds anyway, stop checking that
1054 the tree got clobbered and just assert that the build succeeded.
1055 (VCBase.printLogs): add a utility function for debugging
1057 * buildbot/process/step.py: oops, added extra imports by mistake
1059 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1060 rstrip() on the first line coming out of the 'p4 describe'
1061 process, to remove the stray ^M that Wade Brainerd reports seeing
1062 in the 'when' field. Fixes SF#1555985.
1064 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1065 message logged when c['schedulers'] is not right
1066 * buildbot/scheduler.py (Scheduler.__init__): improve error
1067 message when a Scheduler() is created with the wrong arguments
1068 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1069 verify that these error messages are emitted
1071 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1072 The idea is that all the base classes (like BuildStep and
1073 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1074 will be a leftover backwards-compatibility file that only contains
1075 aliases for the steps that were moved out to buildbot.steps.*
1076 * lots: change imports to match
1077 * buildbot/process/step.py: add a DeprecationWarning if it ever
1080 2006-09-12 Brian Warner <warner@lothar.com>
1082 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1083 builderNames= is actually a sequence, since if you happen to give
1084 it a single builder-specification dictionary instead, it won't get
1085 caught by the existing assert. Thanks to Brett Neely for the
1088 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1090 * docs/buildbot.texinfo (Python BuildSteps): document them
1091 (sendchange): include a link to PBChangeSource, since you need one
1093 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1095 * buildbot/steps/dummy.py: same
1097 2006-09-08 Brian Warner <warner@lothar.com>
1099 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1100 BuildStep which lets you transfer files from the master to the
1101 slave or vice versa. Thanks to Albert Hofkamp for the original
1102 patch. Fixes SF#1504631.
1103 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1105 (SlaveFileDownloadCommand): same
1106 * docs/buildbot.texinfo (Transferring Files): document it
1107 * buildbot/test/test_transfer.py: test it
1108 * buildbot/test/runutils.py (StepTester): new utility class for
1109 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1110 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1113 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1114 walk through StatusLogs one line at a time, mostly for the benefit
1115 of ShellCommand.createSummary methods. You can either walk through
1116 STDOUT or STDERR, but the default is STDOUT.
1118 * buildbot/status/builder.py (LogFile.readlines): implement it.
1119 Note that this is not yet memory-efficient, it just pulls the
1120 whole file into RAM and then splits it up with a StringIO.
1121 Eventually this should be a generator that only pulls chunks from
1123 * buildbot/test/test_status.py (Log.testReadlines): test it
1125 * docs/buildbot.texinfo: update to match changes
1126 * buildbot/process/factory.py: stop using old definitions
1127 * buildbot/process/process_twisted.py: same
1128 * buildbot/test/test_*.py: same
1130 * buildbot/process/step_twisted.py: move definition to..
1131 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1132 relative-import mechanisms prevent this from being named 'twisted'
1133 or 'python/twisted' as I would have preferred.
1135 * buildbot/process/maxq.py: move definition to..
1136 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1138 * buildbot/process/step.py: split the user-visible BuildSteps into
1139 separate files, all under buildbot/steps/
1140 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1141 * buildbot/steps/shell.py: this holds ShellCommand and friends
1142 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1144 2006-09-05 Brian Warner <warner@lothar.com>
1146 * lots: run pyflakes, removed a lot of unused imports, changed the
1147 form of some conditional imports to remove false pyflakes
1148 warnings. There are still a number of warnings left, mostly from
1149 imports that are done for their side-effects.
1150 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1153 2006-08-26 Brian Warner <warner@lothar.com>
1155 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1156 compatible with twisted-1.3.0, for some reason I just can't seem
1157 to let go of the past.
1159 2006-08-25 Brian Warner <warner@lothar.com>
1161 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1163 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1164 all logfiles= in startCommand(), rather than in start() . This
1165 makes it easier to have the 'stdio' log come before any secondary
1166 logfiles, which I feel makes the waterfall display more
1168 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1169 from ShellCommand up into LoggingBuildStep
1170 (LoggingBuildStep.__init__): move the handling of logfiles= from
1171 ShellCommand up to LoggingBuildStep, because startCommand is
1172 provided by LoggingBuildStep, whereas start() was specific to
1173 subclasses like ShellCommand and Source. This removes code
1174 duplication in those subclasses.
1175 (ShellCommand.__init__): same
1176 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1177 for a slave that's too old to understand logfiles= into a separate
1178 method, so it can live in ShellCommand. The rest of
1179 setupLogfiles() can live in LoggingBuildStep.
1181 2006-08-24 Brian Warner <warner@lothar.com>
1183 * buildbot/locks.py (BaseLock): you can now configure Locks to
1184 allow multiple simultaneous owners. They still default to
1185 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1187 * docs/buildbot.texinfo (Interlocks): document the new options
1188 * buildbot/test/test_locks.py: add a bunch of new unit tests
1189 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1190 waitUntilMaybeAvailable, not waitUntilAvailable
1191 * buildbot/process/step.py (BuildStep.acquireLocks): same
1192 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1193 the whole lockid in their constructor, not just the name. Also,
1194 keep track of which real locks we've handed out by the full
1195 lockid, not just class+name, otherwise changing just the maxCount=
1196 in the master.cfg file would not actually cause a behavioral
1199 2006-08-23 Brian Warner <warner@lothar.com>
1201 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1203 * docs/buildbot.texinfo: same
1205 2006-08-23 Brian Warner <warner@lothar.com>
1207 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1208 * docs/buildbot.texinfo: set version to match
1209 * NEWS: update for 0.7.4
1210 * buildbot/slave/commands.py (command_version): mention that this
1211 version (2.1) was released with buildbot-0.7.4
1213 2006-08-22 Brian Warner <warner@lothar.com>
1217 * CREDITS: new file, list of people who have helped. Thanks!
1218 * MANIFEST.in: ship it
1220 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1221 new diagrams, the user's manual is more informative than it was.
1222 Start shipping the .html user's manual (and generated .png
1224 * Makefile: update 'release' target to match
1226 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1227 test.. I think the web-parts effort will render it pointless well
1228 before it ever actually starts to work.
1230 2006-08-20 Brian Warner <warner@lothar.com>
1232 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1233 meaning of the prefix= argument. It is now just a string which is
1234 stripped from the beginning of the filename. If prefix= is set but
1235 not found on any given filename, that filename is ignored. If all
1236 filenames in a Change are ignored, the Change is dropped. This is
1237 much simpler than the previous sep= nonsense, and I should have
1238 implemented it this way from the beginning. Effectively resolves
1239 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1240 Gedminas for the catch and suggested fixes.
1241 (ChangePerspective.perspective_addChange): implement the actual
1243 * buildbot/test/test_changes.py (TestChangePerspective): test it
1244 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1245 how to properly use prefix=
1246 * docs/examples/twisted_master.cfg (source): update prefix= by
1247 adding the trailing slash
1250 * docs/examples/twisted_master.cfg: update to actual practice
1252 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1253 update test case to match new link text.. the HREF has both a
1254 class= setting and an enclosing [] pair that I didn't match in the
1257 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1258 list of strings is preferred over a single string with embedded
1260 (ShellCommand.description=): explain that either single strings or
1261 a list of strings is acceptable, and why you might prefer one over
1262 the other. Add an example. Fixes SF#1524659, thanks to Paul
1263 Winkler for the catch.
1264 (Build Steps): update to use f.addStep() rather than using s()
1265 and the constructor list
1267 * buildbot/process/step.py (ShellCommand): accept either a single
1268 string or a list of strings in both description= and
1270 * buildbot/test/test_steps.py (Steps.test_description): test it
1271 * buildbot/test/runutils.py (makeBuildStep): support for that test
1273 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1274 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1275 collecting the files and creating the patch.
1277 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1278 per-step URLs that will be displayed on the waterfall display,
1279 for things like the HTML output of code-coverage tools, when
1280 the results are hosted elsewhere.
1281 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1282 way to retrieve these URLs
1283 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1284 the method to retrieve these URLs. Also provide backwards
1285 compatibility for saved BuildStepStatus instances that didn't have
1287 * buildbot/process/step.py (BuildStep.addURL): method to set these
1288 URLs from within a BuildStep
1289 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1290 (StepBox.getBox): give these external links a distinct CSS class
1291 named "BuildStep external" so a .css file can display them
1294 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1296 * buildbot/test/test_steps.py (Steps): test that we can all the
1297 URLs. Also add a bunch of other tests on methods that can be
1298 called from within BuildSteps
1299 * buildbot/test/runutils.py (makeBuildStep): add utility function
1301 2006-08-13 Brian Warner <warner@lothar.com>
1303 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1305 2006-08-10 Brian Warner <warner@lothar.com>
1307 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1308 index, this one of things like c['sources'] and c['schedulers']
1309 (indices): it looks like my clever idea of putting the @fooindex
1310 commands in between the @node and the @subsection (to make the
1311 HREF anchor jump to slightly above the section title, which works
1312 much better in html) confused texinfo horribly, so I'm moving the
1313 index tags back to be just after the @subsection marker. I also
1314 added extra lines between the @node/@section paragraph and the
1315 index tags, since I think maybe texinfo wants to see these be
1316 separate paragraphs.
1318 * docs/Makefile (images): make sure images get built when
1319 rendering the manual
1320 * docs/images/Makefile: same
1322 * buildbot/scripts/runner.py: rename 'buildbot master' to
1323 'buildbot create-master', and 'buildbot slave' to 'buildbot
1325 * docs/buildbot.texinfo: same
1328 * docs/buildbot.texinfo: reimplement the "useful classes" index
1329 with actual texinfo indices. The .info rendering is a bit
1330 weird-looking but it works well, and the HTML rendering is quite
1331 nice. This also puts the index targets in the regular flow of the
1332 text, which is easier to maintain.
1334 2006-08-06 Brian Warner <warner@lothar.com>
1336 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1337 Kevin Turner to prefer the environ= argument be a list rather than
1338 a string. If it is a list, it will be joined with a platform-local
1339 os.pathsep delimiter, and then prepended to any existing
1340 $PYTHONPATH value. This works better in cross-platform (i.e.
1341 windows buildslaves) environments when you need to push multiple
1342 directories onto the front of the path.
1343 (SlaveShellCommand): documented the new magic
1344 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1345 in a user-visible form
1347 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1348 Turner to prefer lists over strings when creating/running VC
1349 commands during unit tests. This is clearly necessary to survive
1350 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1351 renamed the wq() function to qw() though, since that's how it's
1352 spelled in perl. Eventually I'd prefer all commands to be
1353 specified with lists.
1355 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1356 which are deleted (or not yet created) correctly. Also add
1357 failsafe code to not explode if the file-watching poller doesn't
1358 get started. Thanks to JP Calderone for the catch and the poller
1360 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1362 * buildbot/test/emitlogs.py: same
1364 * NEWS: summarize recent changes
1366 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1367 clause to avoid the "host key mismatch" warning
1369 * buildbot/process/step_twisted.py (Trial.start): if the
1370 buildslave is too old to understand logfiles=, fall back to
1371 running 'cat _trial_temp/test.log' like before.
1372 (Trial.commandComplete): same. this takes advantage of the
1373 LoggingBuildStep refactoring to stall commandComplete long enough
1374 to run a second RemoteShellCommand.
1376 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1377 refactor command-completion handling, to allow methods like
1378 commandComplete/createSummary/evaluateCommand to return Deferreds.
1379 (LoggingBuildStep._commandComplete): delete the refactored method
1380 (ShellCommand.setupLogfiles): if the buildslave is too old to
1381 understand logfiles=, put a warning message both into twistd.log
1382 and into the otherwise empty user-visible LogFiles.
1384 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1385 callers to provide the slave-side logfile name, rather than
1386 forcing it to come from the local name of the LogFile.
1387 (BuildStep.getSlaveName): new method
1389 * buildbot/process/base.py (Build.getSlaveName): new method, so
1390 steps can find out which buildslave they're running on
1392 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1393 to match the s/cvs_ver/command_version/ change
1395 2006-08-05 Brian Warner <warner@lothar.com>
1397 * buildbot/slave/commands.py (command_version): replace the CVS
1398 auto-updated cvs_ver keyword with a manually-updated variable,
1399 since CVS is no longer the master repository. Add a description of
1400 the remote API change starting in this version (2.1), specifically
1401 the fact that SlaveShellCommand now accepts 'initial_stdin',
1402 'keep_stdin_open', and 'logfiles'.
1404 2006-07-31 Brian Warner <warner@lothar.com>
1406 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1407 diagrams to describe how the whole system fits together. The
1408 images themselves are kept in SVG files, with ascii-art versions
1409 in corresponding .txt files. Texinfo knows how to interpolate the
1410 text version into .info files, reference the .png versions from
1411 .html files, and include .eps versions in the .ps format.
1412 * docs/images/Makefile: tools to create .png and .eps
1413 * docs/images/*.svg: created pictures with Inkscape.
1414 * .darcs-boring: ignore the generated .eps and .png files
1416 2006-07-24 Brian Warner <warner@lothar.com>
1418 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1419 Scheduler names, since they cause setServiceParent to explode
1421 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1423 2006-07-20 Brian Warner <warner@lothar.com>
1425 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1426 which runs the buildbot unit tests
1428 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1429 classes that are useful in master.cfg
1431 2006-07-15 Brian Warner <warner@lothar.com>
1433 * Makefile (some-apidocs): new target to build only some epydocs
1435 * setup.py: minor comment.. does the classifiers= argument prevent
1436 the setup.py script from working on python2.2/2.3?
1438 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1441 * buildbot/twcompat.py: fix minor typo in comments
1443 * buildbot/manhole.py: move all Manhole-related code out to this
1444 module. Implement SSH-based manholes (with TwistedConch), and move
1445 to conch's nifty line-editing syntax-coloring REPL shell instead
1446 of the boring non-editing monochromatic (and deprecated) old
1448 * buildbot/master.py: remove all Manhole-related code
1449 (BuildMaster.loadConfig._add): make sure the old manhole is
1450 removed before we add the new one
1451 * docs/buildbot.texinfo (Debug options): document new Manhole options
1453 * buildbot/twcompat.py (_which): fix some epydoc issues
1454 * buildbot/status/html.py (Waterfall.__init__): same
1456 2006-06-29 Brian Warner <warner@lothar.com>
1458 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1459 deprecation warnings under newer Twisteds (by using
1460 zope.interface.Interface instead of old twisted.python.components
1462 * buildbot/slave/interfaces.py: same
1464 2006-06-28 Brian Warner <warner@lothar.com>
1466 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1467 svn commands, so it will fail immediately instead of hanging while
1468 it waits for a username/password to be typed in.
1470 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1471 log message if the step was shut down
1473 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1474 obsolete reference to mktap.
1476 2006-06-20 Brian Warner <warner@lothar.com>
1478 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1479 test to include new 'logfiles' argument sent from master to slave
1481 2006-06-19 Brian Warner <warner@lothar.com>
1483 * buildbot/process/step_twisted.py (Trial): track Progress from
1484 _trial_temp/test.log too
1486 * buildbot/process/step.py (OutputProgressObserver): generalize
1487 the earlier StdioProgressObserver into an OutputProgressObserver
1488 that can track LogFiles other than stdio.
1489 (LoggingBuildStep.__init__): same
1491 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1492 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1493 will fail under windows because of os.sep issues. It might have
1494 worked before if 'cat' was doing cygwin path conversion.
1496 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1497 creation of LogFileWatchers
1498 (ShellCommand._startCommand): and record the files that were
1499 watched in the 'headers' section of the ShellCommand output
1501 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1502 need to actually pass it to the slave if you want it to work.
1503 (ShellCommand): document it a bit
1505 * buildbot/test/test_shell.py: new test to validate LogFiles
1506 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1508 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1509 before printing the last batch of lines, to test that the polling
1510 logic is working properly
1512 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1513 handling, making it possible to track multiple logs for a single
1514 RemoteCommand. The previous single logfile is now known as the
1516 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1517 (RemoteShellCommand.__init__): accept logfiles=
1518 (LoggingBuildStep.startCommand): stdio_log is now one of many
1519 (ShellCommand): added logfiles= argument, as well as a class-level
1520 .logfiles attribute, which will be merged together to figure out
1521 which logfiles should be tracked. The latter maybe be useful for
1522 subclasses of ShellCommand which know they will aways produce
1523 secondary logfiles in the same location.
1525 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1526 and closeStdin() methods, preparing to make it possible to write
1527 to a ShellCommand's stdin at any time, not just at startup. These
1528 writes are buffered if the child process hasn't started yet.
1529 (LogFileWatcher): new helper class to watch arbitrary logfiles
1530 while a ShellCommand runs. This class polls the file every two
1531 seconds, and sends back 10k chunks to the buildmaster.
1532 (ShellCommand): rename stdin= to initialStdin=, and add
1533 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1535 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1536 key of "log" and a value of (logname, data).
1537 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1538 'logfiles' to the master-visible args dictionary.
1539 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1542 * buildbot/test/test_vc.py (Patch.testPatch): same
1545 * buildbot/test/emit.py: write to a logfile in the current
1546 directory. We use this to figure out what was used as a basedir
1547 rather than looking to see which copy of emit.py gets run, so that
1548 we can run the commands from inside _trial_temp rather than inside
1550 * buildbot/test/subdir/emit.py: same
1551 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1552 argument rather than running from buildbot/test/
1553 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1554 rather than using an implicit setUp()
1555 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1556 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1557 of assuming that we're running in buildbot/test/ (and that '.' is
1560 * buildbot/slave/commands.py (Command.doStart): refactor Command
1561 startup/completion a bit: now the SlaveBuilder calls doStart(),
1562 which is not meant for overridding by subclasses, and doStart()
1563 calls start(), which is. Likewise the SlaveBuilder calls
1564 doInterrupt(), and subclasses override interrupt(). This also puts
1565 responsibility for maintaining .running in Command rather than in
1567 (Command.doInterrupt): same
1568 (Command.commandComplete): same, this is called when the deferred
1569 returned by start() completes.
1570 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1571 (SlaveBuilder.remote_interruptCommand): same
1572 (SlaveBuilder.stopCommand): same
1574 2006-06-16 Brian Warner <warner@lothar.com>
1576 * buildbot/test/test_shell.py: new test file to contain everything
1577 relating to ShellCommand
1578 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1579 multiple logfiles in realtime" feature, not yet implemented
1580 * buildbot/test/emitlogs.py: support file for testLogFiles
1581 * docs/buildbot.texinfo (ShellCommand): document the feature
1583 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1585 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1586 for tests which exercise SlaveCommands in isolation.
1588 * buildbot/test/test_slavecommand.py: Move some utilities like
1589 SignalMixin and FakeSlaveBuilder from here ..
1590 * buildbot/test/runutils.py: .. to here, so they can be used by
1591 other test classes too
1592 * buildbot/test/test_vc.py: more SignalMixin refactoring
1593 * buildbot/test/test_control.py: same
1594 * buildbot/test/test_run.py: and some rmtree refactoring
1596 2006-06-15 Brian Warner <warner@lothar.com>
1598 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1599 'testBranch' to match other VC tests and have the tests run in
1600 roughly increasing order of dependency
1602 * buildbot/test/test_steps.py (LogObserver): new test to verify
1603 LogObservers can be created at various times and still get
1604 connected up properly
1606 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1607 to create BuildStepStatus instances that actually work.
1609 * buildbot/process/step.py (LogObserver): add outReceived and
1610 errReceived base methods, to be overridden
1612 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1613 API to take a name instead of a step, reducing the coupling
1614 somewhat. This returns the BuildStepStatus object so it can be
1615 passed to the new Step, instead of jamming it directly into the
1617 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1619 * buildbot/process/base.py (Build.setupBuild): use both methods
1620 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1621 process a bit to match
1623 2006-06-14 Brian Warner <warner@lothar.com>
1625 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1626 docs on writing new LogObserver classes
1627 (Writing New Status Plugins): brief docs on how Status Plugins fit
1630 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1631 implement a LogObserver that counts how many unit tests have been
1633 (Trial.__init__): wire it in
1634 * buildbot/test/test_twisted.py (Counter): unit test for it
1636 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1637 to new cmd.logs['stdio'] scheme
1638 (Trial.commandComplete): same
1639 (BuildDebs.commandComplete): same
1641 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1642 LogFiles, instead of just a single one. The old single logfile is
1643 now called "stdio". LoggedRemoteCommand no longer creates a
1644 LogFile for you (the code to do that was broken anyway). If you
1645 don't create a "stdio" LogFile, then stdout/stderr will be
1647 (LogObserver): implement "LogObservers", which a BuildStep can add
1648 to parse the output of a command in real-time. The primary use is
1649 to provide more useful information to the Progress code, allowing
1650 better ETA estimates.
1651 (LogLineObserver): utility subclass which feeds complete lines to
1652 the parser instead of bytes.
1653 (BuildStep.progressMetrics): this is safer as a tuple
1654 (BuildStep.setProgress): utility method, meant to be called by
1656 (BuildStep.addLogObserver): new method, to be called at any time
1657 during the BuildStep (even before any LogFiles have been created),
1658 to attach (or schedule for eventual attachment) a LogObserver to a
1660 (StdioProgressObserver): new LogObserver which replaces the old
1661 "output" progress gatherer
1662 (LoggingBuildStep.__init__): same
1663 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1664 (LoggingBuildStep._commandComplete): must use logs['stdio']
1665 instead of the old single ".log" attribute.
1666 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1667 functionality, now subsumed into StdioProgressObserver
1668 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1669 log name changed from "output" to "stdio".
1672 * buildbot/interfaces.py (ILogFile): add the Interface used from
1673 the BuildStep towards the LogFile
1674 (ILogObserver): and the one provided by a LogObserver
1675 * buildbot/status/builder.py (LogFile): implement it
1677 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1678 HEADER constants here ..
1679 * buildbot/status/builder.py (STDOUT): .. from here
1681 2006-06-13 Brian Warner <warner@lothar.com>
1683 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1684 compatibility with python2.2, which doesn't have the 'substr in
1686 (TestP4Poller.makeTime): utility function to construct the
1687 timestamp using the same strptime() approach as p4poller does. It
1688 turns out that time.mktime() behaves slightly differently under
1689 python2.2, probably something to do with the DST flag, and that
1690 causes the test to fail under python2.2. (changing the mktime()
1691 arguments to have dst=0 instead of -1 caused it to fail under
1692 python2.3. Go figure.)
1693 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1695 2006-06-12 Brian Warner <warner@lothar.com>
1697 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1698 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1699 contributing such an excellent patch, including docs and unit
1700 tests! This makes it *so* much easier to apply. I had to update
1701 test_vc.py to handle some recent refactorings, but everything else
1702 applied smoothly. The only remaining thing I'd like to fix would
1703 be to remove the hard-wired port 1666 used by p4d, and allow it to
1704 claim any unused port. This would allow two copies of the test
1705 suite to run on the same host at the same time, as well as
1706 allowing the test suite to run while a real (production) p4d was
1707 running on the same host. Oh, and maybe we should add a warning to
1708 step.P4 that gets emitted if the slave is too old to provide the
1709 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1710 * buildbot/slave/commands.py (P4): same
1711 (P4Sync): same, some minor updates
1712 * buildbot/changes/p4poller.py: same
1713 * docs/buildbot.texinfo: same
1714 * buildbot/test/test_p4poller.py: same
1715 * buildbot/test/test_vc.py (P4): same
1717 * setup.py: add Trove classifiers for PyPI
1719 2006-06-08 Brian Warner <warner@allmydata.com>
1721 * buildbot/status/client.py
1722 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1723 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1724 build needs to be IRemote'd separately, rather than IRemote'ing
1725 the whole list at once. I can't wait until newpb's serialization
1726 adapters make this unnecessary.
1728 2006-06-06 Brian Warner <warner@lothar.com>
1730 * buildbot/process/step.py (WithProperties): make this inherit
1731 from ComparableMixin, so that reloading an unchanged config file
1732 doesn't cause us to spuriously reload any Builders which use them.
1733 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1736 2006-06-03 Brian Warner <warner@lothar.com>
1738 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1739 running py2exe on windows, contributed by Mark Hammond. Addresses
1740 SF#1401121, but I think we still need to include
1741 buildbot/scripts/sample.cfg
1742 * setup.py: include buildbot_service.py as a script under windows
1743 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1744 a py2exe application), get the icon/css datafiles from a different
1747 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1748 double-escape the build URL. Thanks to Olivier Bonnet for the
1749 patch. Fixes SF#1452801.
1751 2006-06-02 Brian Warner <warner@lothar.com>
1753 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1754 first six columns of 'svnlook' output, not just the first column,
1755 since property changes appear in the other five. Thanks to Olivier
1756 Bonnet for the patch. Fixes SF#1398174.
1758 2006-06-01 Brian Warner <warner@lothar.com>
1760 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1761 the fake build, so that title= has something to be set to
1763 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1764 attribute of the "Build #NN" link in the yellow start-the-build
1765 box to the build's reason. This means that you get a little
1766 tooltip explaining why the build was done when you hover over the
1767 yellow box. Thanks to Zandr Milewski for the suggestion.
1769 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1770 (Box.setETA): handle ETA=None (by stopping the timer)
1771 (Box.update): make the [soon] text less different than the usual
1772 text, so the rest of the text doesn't flop around so much. It
1773 would be awfully nice to figure out how to center this stuff.
1774 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1776 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1777 by default, so that any ShellCommand which fails marks the overall
1778 build as a failure. I should have done this from the beginning.
1779 Add flunkOnFailure=False to the arguments if you want to turn off
1782 2006-05-30 Brian Warner <warner@lothar.com>
1784 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1785 last-build/current-build/current-step. Show what step is currently
1786 running. Show ETA for both the overall build and the current step.
1787 Update GTK calls to modern non-deprecated forms. There's still a
1788 lot of dead code and debug noise to remove.
1790 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1791 shows up properly in status displays
1793 2006-05-28 Brian Warner <warner@lothar.com>
1795 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1796 build we use to verify that WithProperties works:
1798 ** set flunkOnFailure=True so that build failures get noticed
1799 ** set workdir='.' so that the build succeeds, otherwise it is trying
1800 to touch 'build/something', and 'build/' doesn't exist because
1801 usually that's created by a Source step
1802 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1803 this test somehow triggers, in which the 'touch' process becomes
1804 a zombie and we wait for th etimeout before giving up on it.
1806 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1807 to log the Build results and step logs to the twisted log.
1808 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1809 what went wrong if a build was expected to succeed but didn't.
1811 * buildbot/process/step_twisted.py (Trial): set the default
1812 trialMode to '--reporter=bwverbose', which specifies verbose
1813 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1814 '-to', but those are completely missing in modern Twisteds.
1816 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1817 a localhost-only port, to encourage better security
1819 * docs/buildbot.texinfo (Change Sources): mention
1822 * .darcs-boring: add a Darcs boringfile
1824 * README (REQUIREMENTS): stop claiming compatibility with
1827 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1830 2006-05-27 Brian Warner <warner@lothar.com>
1832 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1833 * docs/buildbot.texinfo: same
1835 2006-05-23 Brian Warner <warner@lothar.com>
1837 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1838 * docs/buildbot.texinfo: set version to match
1839 * NEWS: update for 0.7.3
1841 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1842 give a quick mapping from VC system to possible ChangeSources
1843 (Build Properties): add 'buildername'
1845 * buildbot/process/base.py (Build.setupStatus): oops, set
1846 'buildername' and 'buildnumber' properties
1847 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1850 2006-05-22 Brian Warner <warner@lothar.com>
1852 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1853 property interpolation better
1855 * README (INSTALLATION): remove old '-v' argument from recommended
1858 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1859 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1862 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1863 'svnversion' instead of grepping the output of 'svn info', much
1864 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1865 Bonnet for the suggestion.
1866 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1867 require the WC_PATH argument, so run 'svnversion .' instead.
1869 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1870 aren't supposed to have 'self' in their argument list
1872 2006-05-21 Brian Warner <warner@lothar.com>
1874 * buildbot/process/step.py (ShellCommand.start): make
1875 testInterpolate pass. I was passing the uninterpolated command to
1876 the RemoteShellCommand constructor
1877 (ShellCommand._interpolateProperties): oops, handle non-list
1878 commands (i.e. strings with multiple words separated by spaces in
1879 them) properly, instead of forgetting about them.
1881 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1882 to actually try to use build properties in a real build. This test
1884 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1885 to start and evaluate builds
1887 * buildbot/test/test__versions.py: add a pseudo-test to record
1888 what version of Twisted/Python/Buildbot are running. This should
1889 show up at the beginning of _trial_tmp/test.log, and exists to help
1890 debug other problems.
1892 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1893 a filename to be served as 'robots.txt' to discourage web spiders.
1894 Adapted from a patch by Tobi Vollebregt, thanks!
1895 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1896 (Waterfall.test_waterfall): tweak the way that filenames are put
1897 into the config file, to accomodate windows pathnames better.
1899 * docs/buildbot.texinfo (HTML Waterfall): document it
1901 * buildbot/process/process_twisted.py
1902 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1903 changed the build process. The new setup.py no longer takes the
1905 (FullTwistedBuildFactory.__init__): same
1906 (TwistedReactorsBuildFactory.__init__): same
1908 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1909 be placed in the [hooks] section of the central repository (the
1910 one that everybody pushes changes to).
1912 2006-05-20 Brian Warner <warner@lothar.com>
1914 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1915 .darcs-context file, use binary mode. I think this was causing a
1916 Darcs failure under windows.
1918 2006-05-19 Brian Warner <warner@lothar.com>
1920 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1921 use a timezone string of +0000 and gmtime, since this timestamp is
1922 sent to a buildmaster and %z is broken.
1924 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1925 string and localtime, since this timestamp will only be consumed
1926 locally, and %z is broken.
1928 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1929 gmtime, since this timestamp is returned to the buildmaster, and
1932 2006-05-18 Brian Warner <warner@lothar.com>
1934 * NEWS: update in preparation for next release
1936 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1937 setup-repository and do-we-have-the-vc-tools code into a separate
1938 "helper" class, which sticks around in a single module-level
1939 object. This seems more likely to continue to work in the future
1940 than having it hide in the TestCase and hope that TestCases stick
1941 around for a long time.
1943 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1944 addremove' has been deprecated in recent versions of mercurial, so
1945 use 'hg add' instead
1947 2006-05-07 Brian Warner <warner@lothar.com>
1949 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1950 operating under windows, move the file before opening it, since
1951 you can't rename a file that somebody has open.
1953 * buildbot/process/base.py (Build.setupBuild): if something goes
1954 wrong while creating a Step, log the name and arguments, since the
1955 error message when you get the number of arguments wrong is really
1958 2006-05-06 Brian Warner <warner@lothar.com>
1960 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1961 bugs in twisted-specific code not covered by my unit tests, this
1962 time use 'cmd' argument instead of self.cmd
1964 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1965 fix stupid braino: either use startwith or find()==0, not both.
1966 (TwistedReactorsBuildFactory.__init__): another dumb typo
1968 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1969 mark this test as TODO under windows, since process-killing seems
1970 dodgy there. We'll come back to this later and try to fix it
1973 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1974 and don't include a timezone
1975 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1976 This should avoid the windows-with-verbose-timezone-name problem
1978 (Patch.testPatch): add a test which runs 'patch' with less
1979 overhead than the full VCBase.do_patch sequence, to try to isolate
1980 a windows test failure. This one uses slave.commands.ShellCommand
1981 and 'patch', but none of the VC code.
1983 * buildbot/slave/commands.py (getCommand): use which() to find the
1984 executables for 'cvs', 'svn', etc. This ought to help under
1987 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1988 working directory before starting. If an earlier test failed, the
1989 leftover directory would mistakenly flunk a later test.
1990 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1991 Make sure that we use the right commandlines if which("tla") picks
1992 up "tla.exe" (as it does under windows).
1993 (TlaSupport.do_get): factor out this tla-vs-baz difference
1994 (TlaSupport.vc_create): more tla-vs-baz differences
1996 * buildbot/test/test_slavecommand.py
1997 (ShellBase.testShellMissingCommand): stop trying to assert
1998 anything about the error message: different shells on different
1999 OSes with different languages makes it hard, and it really isn't
2000 that interesting of a thing to test anyway.
2002 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2003 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2004 "Panther"), because it has a bug which flunks a couple tests in
2005 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2006 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2007 able to test that yet.
2009 2006-04-30 Brian Warner <warner@lothar.com>
2011 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2012 make sure child commands emit messages in english, so our regexps
2013 will match. Thanks to Nikaus Giger for identifying the problems.
2014 (VCBase._do_vctest_export_1): mode="export" is not responsible
2015 for setting the "got_revision" property, since in many cases it is
2016 not convenient to determine.
2017 (SVNSupport.capable): when running 'svn --version' to check for
2018 ra_local, we want error messages in english
2019 * buildbot/test/test_slavecommand.py
2020 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2021 to emit the error message in english
2023 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2024 the environment with $LC_ALL="C" so that Commands which need to
2025 parse the output of their child processes can obtain it in
2027 (SVN.parseGotRevision): call "svn info" afterwards instead of
2028 watching the output of the "svn update" or "svn checkout".
2029 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2030 (Arch.parseGotRevision): same
2031 (Bazaar.parseGotRevision): same
2032 (Mercurial.parseGotRevision): same
2034 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2035 $LC_ALL="C" when running commands under 'buildbot try', too
2037 * buildbot/test/__init__.py: remove the global os.environ()
2038 setting, instead we do it just for the tests that run commands and
2039 need to parse their output.
2041 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2042 remove the overly-short .timeout on this test, because non-DNotify
2043 platforms must fall back to polling which happens at 10 second
2044 intervals, so a 5 second timeout would never succeed.
2046 2006-04-24 Brian Warner <warner@lothar.com>
2048 * docs/buildbot.texinfo (Installing the code): update trial
2049 invocation, SF#1469116 by Niklaus Giger.
2050 (Attributes of Changes): updated branch-name examples to be
2051 a bit more realistic, SF#1475240 by Stephen Davis.
2053 * contrib/windows/buildbot2.bat: utility wrapper for windows
2054 developers, contributed by Nick Trout (after a year of neglect..
2055 sorry!). SF#1194231.
2057 * buildbot/test/test_vc.py (*.capable): store the actual VC
2058 binary's pathname in VCS[vcname], so it can be retrieved later
2059 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2060 strip out non-numeric timezone information, specifically the funky
2061 German string that his system produced that confuses CVS.
2062 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2063 allow Darcs tests to work on windows
2064 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2065 procutils.which() everywhere, to allow tryclient to work under
2066 windows. Also from Niklaus Giger, SF#1463394.
2068 * buildbot/twcompat.py (which): move the replacement for a missing
2069 twisted.python.procutils.which from test_vc.py to here, so it can
2070 be used in other places too (specifically tryclient.py)
2072 2006-04-23 Brian Warner <warner@lothar.com>
2074 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2075 bare buildbotURL/projectName line with a proper DIV, along with a
2076 CSS class of "title", from Stefan Seefeld (SF#1461675).
2077 (WaterfallStatusResource.body0): remove the redundant 'table'
2078 class from the table
2079 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2080 to the top-row TR, and class="Activity" to the second-row TR,
2081 rather than putting them in the individual TD nodes.
2083 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2084 'got_revision' build property for all VC systems that implement
2085 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2087 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2088 to determine which revision we actually obtained
2089 (CVS.parseGotRevision): implement this for CVS, which just means
2090 to grab a timestamp. Not ideal, and it depends upon the buildslave
2091 having a clock that is reasonably well syncronized with the server,
2092 but it's better than nothing.
2093 (SVN.parseGotRevision): implement it for SVN, which is accurate
2094 (Darcs.parseGotRevision): same
2095 (Arch.parseGotRevision): same
2096 (Bazaar.parseGotRevision): same
2097 (Mercurial.parseGotRevision): same
2099 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2100 keep a record of all non-stdout/stderr/header/rc status updates,
2101 for the benefit of RemoteCommands that send other useful things,
2103 (Source.commandComplete): put any 'got_revision' status values
2104 into a build property of the same name
2107 * buildbot/process/step_twisted.py (Trial): update to deal with
2108 new ShellCommand refactoring
2110 * docs/buildbot.texinfo (Build Properties): document new feature
2111 that allows BuildSteps to get/set Build-wide properties like which
2112 revision was requested and/or checked out.
2114 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2115 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2116 it. Note that this bumps the persistenceVersion of the saved Build
2117 object, so add the necessary upgrade-old-version logic to include
2118 an empty properties dict.
2120 * buildbot/process/base.py (Build.setProperty): implement it
2121 (Build.getProperty): same
2122 (Build.startBuild): change build startup to set 'branch',
2123 'revision', and 'slavename' properties at the right time
2125 * buildbot/process/step.py (BuildStep.__init__): change setup to
2126 require 'build' argument in a better way
2127 (LoggingBuildStep): split ShellCommand into two pieces, for better
2128 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2129 a single RemoteCommand that sends stdout/stderr status text. It
2130 also provides the usual commandComplete / createSummary /
2131 evaluateCommand / getText methods to be overridden...
2132 (ShellCommand): .. whereas ShellCommand is specifically for
2133 running RemoteShellCommands. Other shell-like BuildSteps (like
2134 Source) can inherit from LoggingBuildStep instead of ShellCommand
2135 (WithProperties): marker class to do build-property interpolation
2136 (Source): inherit from LoggingBuildStep instead of ShellCommand
2139 * buildbot/test/test_properties.py: test new functionality
2141 2006-04-21 Brian Warner <warner@lothar.com>
2143 * buildbot/test/test_vc.py: rename testBranch to
2144 testCheckoutBranch to keep the tests in about the right
2147 2006-04-18 Brian Warner <warner@lothar.com>
2149 * docs/buildbot.texinfo (PBListener): improve cross-references
2150 between PBListener and 'buildbot statusgui', thanks to John Pye
2153 2006-04-17 Brian Warner <warner@lothar.com>
2155 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2156 running under Twisted-1.3.0, otherwise skipped tests are reported
2159 * all: use isinstance() instead of 'type(x) is foo', suggested by
2162 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2163 oops, fix a brain-fade from the other week, when making the
2164 addStep changes. I changed all the __init__ upcalls to use the
2165 wrong superclass name.
2166 (FullTwistedBuildFactory.__init__): same
2167 (TwistedDebsBuildFactory.__init__): same
2168 (TwistedReactorsBuildFactory.__init__): same
2169 (TwistedBuild.isFileImportant): use .startswith for clarity,
2170 thanks to Neal Norwitz for the suggestions.
2172 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2173 changes, then deliver them over PB to a remote buildmaster.
2175 * contrib/svnpoller.py: added script by John Pye to poll a remote
2176 SVN repository (by running 'svn log') from a cronjob, and run
2177 'buildbot sendchange' to deliver the changes to a remote
2179 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2180 modification of svnpoller.py), same purpose, but this one loops
2181 internally (rather than expecting to run from a cronjob) and works
2183 * contrib/README.txt: same
2185 2006-04-11 Brian Warner <warner@lothar.com>
2187 * all: fix a number of incorrect names and missing imports, thanks
2188 to Anthony Baxter for the patch.
2189 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2190 remove unused buggy method.
2191 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2192 comes from shutil, not "shutils"
2193 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2194 (Arch.checkSlaveVersion): same
2195 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2197 * buildbot/process/step_twisted2.py: add some missing imports
2198 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2199 this code used to live in twisted.internet.defer
2201 2006-04-10 Brian Warner <warner@lothar.com>
2203 * buildbot/process/step.py (Mercurial): add Mercurial support
2204 * buildbot/slave/commands.py (Mercurial): same
2205 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2206 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2207 not yet tested, but 'try' support *is* covered
2208 * docs/buildbot.texinfo (Mercurial): document it
2210 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2211 some debugging messages (turned off)
2212 * buildbot/test/test_vc.py: improve debug messages
2214 2006-04-07 Brian Warner <warner@lothar.com>
2216 * buildbot/test/test_vc.py (which): define our own which() in case
2217 we can't import twisted.python.procutils, because procutils doesn't
2218 exist in Twisted-1.3
2220 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2221 of SlaveLocks for performance tests
2223 * docs/examples/twisted_master.cfg: update to match current usage
2225 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2226 password, p4 binary, pollinterval, maximum history to check.
2227 Patch from an anonymous sf.net contributor, SF#1219384.
2228 * buildbot/process/step.py (P4Sync.__init__): add username,
2229 password, and client arguments.
2230 * buildbot/slave/commands.py (P4Sync): same
2232 2006-04-05 Brian Warner <warner@lothar.com>
2234 * buildbot/process/factory.py (BuildFactory.addStep): new method
2235 to add steps to a BuildFactory. Use it instead of f.steps.append,
2236 and you can probably avoid using the s() convenience function.
2237 Patch from Neal Norwitz, sf.net #1412605.
2238 (other): update all factories to use addStep
2239 * buildbot/process/process_twisted.py: update all factories to use
2242 2006-04-03 Brian Warner <warner@lothar.com>
2244 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2245 work under windows too. Adapted from a patch by Niklaus Giger,
2246 addresses SF#1463399.
2248 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2249 spawned commands emit parseable results in english and not some
2250 other language. Patch from Niklaus Giger, SF#1463395.
2252 * README (INSTALLATION): discourage users from running unit tests on
2253 a "network drive", patch from Niklaus Giger, SF#1463394.
2255 2006-03-22 Brian Warner <warner@lothar.com>
2257 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2258 function to turn a repository-relative pathname into a (branch,
2259 branch-relative-filename) tuple. Change this function to handle
2260 the branch naming policy used by your Subversion repository.
2261 Thanks to AllMyData.com for sponsoring this work.
2263 2006-03-16 Brian Warner <warner@lothar.com>
2265 * buildbot/scripts/sample.cfg: add python-mode declaration for
2266 vim. Thanks to John Pye for the patch.
2268 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2269 command line, mention the importance of running 'crontab' as the
2270 buildmaster/buildslave user. Thanks to John Pye for the catch.
2272 2006-03-13 Brian Warner <warner@lothar.com>
2274 * buildbot/status/words.py (IRC): add an optional password=
2275 argument, which will be sent to Nickserv in an IDENTIFY message at
2276 login, to claim the nickname. freenode requires this before the
2277 bot can sent (or reply to) private messages. Thanks to Clement
2278 Stenac for the patch.
2279 * docs/buildbot.texinfo (IRC Bot): document it
2281 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2282 larger than chunkSize. Fixes SF#1349253.
2283 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2284 (Log.testConsumer): update to match new internal chunking behavior
2286 2006-03-12 Brian Warner <warner@lothar.com>
2288 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2290 * buildbot/test/test_maildir.py (MaildirTest): rename the
2291 'timeout' method, as it collides with trial's internals
2293 * buildbot/scripts/runner.py: add 'buildbot restart' command
2294 (stop): don't sys.exit() out of here, otherwise restart can't work
2295 * docs/buildbot.texinfo (Shutdown): document it
2297 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2298 * buildbot/status/html.py (Waterfall.__init__): same
2299 * buildbot/process/builder.py (Builder.startBuild): same
2300 * buildbot/process/base.py (BuildRequest): same
2301 * buildbot/sourcestamp.py (SourceStamp): same
2302 * buildbot/scheduler.py (Nightly): same
2304 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2306 * docs/buildbot.texinfo: same
2308 2006-02-17 Brian Warner <warner@lothar.com>
2310 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2311 * docs/buildbot.texinfo: set version number to match
2312 * NEWS: update for 0.7.2
2314 2006-02-16 Brian Warner <warner@lothar.com>
2316 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2318 2006-02-09 Brian Warner <warner@lothar.com>
2320 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2321 add text to explain per-build branch parameters
2322 * NEWS: mention --umask
2324 2006-02-08 Brian Warner <warner@lothar.com>
2326 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2328 (SlaveOptions.optParameters): add --umask, to make it possible to
2329 make buildslave-generated files (including build products) be
2332 * buildbot/slave/bot.py (BuildSlave.startService): same
2334 2006-01-23 Brian Warner <warner@lothar.com>
2336 * buildbot/status/builder.py: urllib.quote() all URLs that include
2337 Builder names, so that builders can include characters like '/'
2338 and ' ' without completely breaking the resulting HTML. Thanks to
2339 Kevin Turner for the patch.
2340 * buildbot/status/html.py: same
2341 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2343 * NEWS: update in preparation for upcoming release
2345 2006-01-18 Brian Warner <warner@lothar.com>
2347 * docs/examples/twisted_master.cfg: update to match the Twisted
2348 buildbot: remove python2.2, switch to exarkun's buildslaves,
2349 disable the .deb builder until we figure out how to build twisted
2350 .debs from SVN, add some ktrace debugging to the OS-X build
2351 process and remove the qt build, remove threadless builders,
2352 change freebsd builder to use landonf's buildslave.
2354 2006-01-12 Brian Warner <warner@lothar.com>
2356 * buildbot/master.py (Manhole.__init__): let port= be a strports
2357 specification string, but handle a regular int for backwards
2358 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2359 used in master.cfg to limit connections to just the local host.
2360 (BuildMaster.loadConfig): same for c['slavePortnum']
2361 * buildbot/scheduler.py (Try_Userpass.__init__): same
2362 * buildbot/status/client.py (PBListener.__init__): same
2363 * buildbot/status/html.py (Waterfall.__init__): same, for both
2364 http_port and distrib_port. Include backwards-compatibility checks
2365 so distrib_port can be a filename string and still mean unix:/foo
2366 * docs/buildbot.texinfo (Setting the slaveport): document it
2367 (Debug options): same
2368 (HTML Waterfall): same
2371 * buildbot/test/test_config.py (ConfigTest): test it
2373 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2374 slaveport's disownServiceParent deferred to fire before opening
2375 the new one. Fixes an annoying bug in the unit tests.
2377 2006-01-03 Brian Warner <warner@lothar.com>
2379 * buildbot/master.py (BuildMaster): remove the .schedulers
2380 attribute, replacing it with an allSchedulers() method that looks
2381 for all IService children that implement IScheduler. Having only
2382 one parent/child relationship means fewer opportunities for bugs.
2383 (BuildMaster.allSchedulers): new method
2384 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2385 also fix ugly bug that caused any config-file reload to
2386 half-forget about the earlier Schedulers, causing an exception
2387 when a Change arrived and was handed to a half-connected
2388 Scheduler. The exception was in scheduler.py line 54ish:
2389 self.parent.submitBuildSet(bs)
2390 exceptions.AttributeError: 'NoneType' object has no attribute
2392 (BuildMaster.addChange): update to use allSchedulers()
2394 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2395 to work properly with twisted-1.3.0, where you must explicitly
2396 include the __implements__ from parent classes
2397 (BaseScheduler.__repr__): make it easier to distinguish distinct
2399 (BaseUpstreamScheduler.__implements__): same
2401 * buildbot/status/builder.py (Status.getSchedulers): update to
2403 * buildbot/test/test_run.py (Run.testMaster): same
2404 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2405 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2406 make sure Scheduler instances are left alone when an identical
2407 config file is reloaded
2408 (ConfigElements.testSchedulers): make sure Schedulers are properly
2411 * Makefile (TRIALARGS): my local default Twisted version is now
2412 2.1.0, update the trial arguments accordingly
2414 2005-12-22 Brian Warner <warner@lothar.com>
2416 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2419 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2420 addChange in the parent class, although I suspect this should be
2421 fixed better in the future.
2423 2005-11-26 Brian Warner <warner@lothar.com>
2425 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2426 explode when branch==None, thanks to Kevin Turner for the catch
2427 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2430 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2432 * docs/buildbot.texinfo: same
2434 2005-11-26 Brian Warner <warner@lothar.com>
2436 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2437 * docs/buildbot.texinfo: set version number to match
2439 2005-11-26 Brian Warner <warner@lothar.com>
2441 * NEWS: update for 0.7.1
2443 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2444 sure that unsubscribe works even if we never sent an ETA update.
2445 Also, don't explode on duplicate unsubscribe.
2446 (BuildStepStatus.addLog): make the convenience "return self"-added
2447 watcher automatically unsubscribe when the Step finishes.
2448 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2449 (BuildStatus.stepStarted): same auto-unsubscribe
2450 (BuilderStatus.buildStarted): same auto-unsubscribe
2452 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2454 (IStatusReceiver.stepStarted): same
2455 (IStatusReceiver.logStarted): same
2457 * buildbot/test/test_run.py (Status): move the Status test..
2458 * buildbot/test/test_status.py (Subscription): .. to here
2460 2005-11-25 Brian Warner <warner@lothar.com>
2462 * NEWS: more updates
2464 * buildbot/locks.py: fix the problem in which loading a master.cfg
2465 file that changes some Builders (but not all of them) can result
2466 in having multiple copies of the same Lock. Now, the real Locks
2467 are kept in a table inside the BotMaster, and the Builders/Steps
2468 use "LockIDs", which are still instances of MasterLock and
2469 SlaveLock. The real Locks are instances of the new RealMasterLock
2470 and RealSlaveLock classes.
2471 * buildbot/master.py (BotMaster.getLockByID): new method to
2472 convert LockIDs into real Locks.
2473 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2474 into real Locks before building
2475 * buildbot/process/step.py (BuildStep.startStep): same
2476 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2477 exercises the problem
2480 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2481 what Schedulers are available
2483 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2484 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2485 'cron'-style build scheduling at certain times of day, week,
2487 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2489 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2490 handling: treat self.fileIsImportant more as an attribute that
2491 contains a callable than as a method. If the attribute is None,
2492 don't call it and assume all filenames are important. It is still
2493 possible to provide a fileIsImportant method in a subclass,
2495 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2497 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2498 test using AnyBranchScheduler with fileIsImportant=None
2500 2005-11-24 Brian Warner <warner@lothar.com>
2502 * buildbot/test/test_config.py (StartService): don't claim a fixed
2503 port number, instead set slavePort=0 on the first pass, figure out
2504 what port was allocated, then switch to a config file that uses
2507 * buildbot/master.py (BuildMaster.loadConfig): close the old
2508 slaveport before opening the new one, because unit tests might
2509 replace slavePort=0 with the same allocated portnumber, and if we
2510 don't wait for the old port to close first, we get a "port already
2511 in use" error. There is a tiny race condition here, but the only
2512 threat is from other programs that bind (statically) to the same
2513 port number we happened to be allocated, and only if those
2514 programs use SO_REUSEADDR, and only if they get control in between
2517 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2519 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2520 deleted ChangeSources before adding any new ones
2521 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2522 compare_attrs, to make sure that a config-file reload does not
2523 unnecessarily replace an unmodified ChangeSource instance
2524 * buildbot/test/test_config.py (ConfigTest.testSources): update
2526 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2527 mean "don't build anything", and add a warning if it gets used
2528 because it isn't actually useful.
2530 * contrib/svn_buildbot.py: update example usage to match the port
2531 number that gets used by the PBChangeSource
2532 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2534 2005-11-22 Brian Warner <warner@lothar.com>
2536 * NEWS: start collecting items for next release
2538 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2539 revisions are strings
2540 (P4Sync.computeSourceRevision): same
2542 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2543 to the Buildbot's overall status page
2544 (StatusResourceBuilder.body): same
2546 2005-11-15 Brian Warner <warner@lothar.com>
2548 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2549 config-file loading, specifically to make sure old StatusTargets
2550 are finished shutting down before new ones start up (thus
2551 resolving a bug in which changing the Waterfall object would fail
2552 because both new and old instances were claiming the same
2553 listening port). Also load new Schedulers after all the new
2554 Builders are set up, in case they fire off a new build right away.
2555 * buildbot/test/test_config.py (StartService): test it
2557 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2558 the branch name to the mail body
2560 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2561 Without it, a config-file reload fails to update an existing
2563 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2564 username/passwd to compare_attrs, for the same reason
2565 * buildbot/status/html.py (Waterfall): add favicon to
2566 compare_attrs, same reason
2568 2005-11-05 Brian Warner <warner@lothar.com>
2570 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2571 baserev before stuffing it in the jobfile. This resolves problems
2572 under SVN (and probably Arch) where revisions are expressed as
2573 numbers. I'm inclined to use string-based revisions everywhere in
2574 the future, but this fix should be safe for now. Thanks to Steven
2575 Walter for the patch.
2577 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2578 binary mode when opening pickle files, to make windows work
2579 better. Thanks to Dobes Vandermeer for the catch.
2580 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2581 (BuilderStatus.getBuildByNumber): same
2582 (Status.builderAdded): same
2583 * buildbot/master.py (BuildMaster.loadChanges): same
2585 * buildbot/util.py (Swappable): delete unused leftover code
2587 * buildbot/process/step.py (SVN): when building on a non-default
2588 branch, add the word "[branch]" to the VC step's description, so
2589 it is obvious that we're not building the usual stuff. Likewise,
2590 when we are building a specific revision, add the text "rNNN" to
2591 indicate what that revision number is. Thanks to Brad Hards and
2592 Nathaniel Smith for the suggestion.
2593 (Darcs.startVC): same
2594 (Arch.startVC): same
2595 (Bazaar.startVC): same
2597 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2598 typo, caught by Mark Dillavou, closes SF#1216636.
2600 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2601 about a test to add some day
2603 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2604 the 'full-2.3' build, and the 'reactors' build is now run under
2605 python-2.4 because the buildslave no longer has gtk/etc bindings
2606 for earlier versions.
2608 2005-11-03 Brian Warner <warner@lothar.com>
2610 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2611 method, takes an IBuildStatus and rebuilds it. It might make more
2612 sense to add this to IBuildControl instead, but that instance goes
2613 away completely once the build has finished, and resubmitting
2614 builds can take place weeks later.
2615 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2616 * buildbot/status/html.py (StatusResourceBuild): also stash an
2617 IBuilderControl so we can use resubmitBuild.
2618 (StatusResourceBuild.body): render "resubmit" button if we can.
2619 Also add hrefs for each BuildStep
2620 (StatusResourceBuild.rebuild): add action for "resubmit" button
2621 (StatusResourceBuilder.getChild): give it an IBuilderControl
2623 * buildbot/status/builder.py (Status.getURLForThing): change the
2624 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2625 that live as targets of buttons like "stop" and "rebuild" can't
2627 * buildbot/status/builder.py (Status.getURLForThing): same
2628 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2629 (StepBox.getBox): same
2630 * buildbot/test/test_web.py (GetURL): same
2633 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2634 exclusivity checks after Source.__init__ upcall, so misspelled
2635 arguments will be reported more usefully
2636 (Darcs.__init__): same
2638 2005-10-29 Brian Warner <warner@lothar.com>
2640 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2641 builder. Move the Try scheduler off to a separate port.
2643 2005-10-27 Brian Warner <warner@lothar.com>
2645 * buildbot/clients/gtkPanes.py
2646 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2647 to cause the app to crash, now they don't.
2649 * buildbot/clients/debug.py: display the buildmaster's location
2650 in the window's title bar
2652 2005-10-26 Brian Warner <warner@lothar.com>
2654 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2655 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2656 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2658 * buildbot/status/html.py (td): put a single non-breaking space
2659 inside otherwise empty <td> elements, as a workaround for buggy
2660 browsers which would optimize them away (along with any associated
2661 styles, like the kind that create the waterfall grid borders).
2662 Patch from Frerich Raabe.
2664 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2665 argv-list as an argument, defaulting to ["-to"], which is
2666 appropriate for the Trial that comes with Twisted-2.1.0 and
2667 earlier. The Trial in current Twisted SVN wants
2668 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2669 defaults to an empty list.
2670 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2671 match it, now that trialMode= is a list instead of a single string
2673 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2675 * docs/buildbot.texinfo: same
2677 2005-10-24 Brian Warner <warner@lothar.com>
2679 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2680 * docs/buildbot.texinfo: set version number to match
2682 2005-10-24 Brian Warner <warner@lothar.com>
2684 * README: update for 0.7.0
2686 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2688 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2689 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2690 send the branch= argument unless the user really provided one, to
2691 retain compatibility with older buildmasters that don't accept
2693 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2696 * docs/buildbot.texinfo: update lots of stuff
2698 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2699 to the 'buildbot sendchange' command
2700 * buildbot/clients/sendchange.py (Sender.send): same
2701 * buildbot/changes/pb.py (ChangePerspective): same
2702 * buildbot/test/test_changes.py (Sender.testSender): test it
2704 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2705 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2706 for consistency with other BuildStep arguments that use camelCase.
2707 Well, at least more of them use camelCase (like flunkOnWarnings)
2708 than don't.. I wish I'd picked one style and stuck with it
2709 earlier. Annoying, but it's best done before the release, since
2710 these arguments didn't exist at all in 0.6.6 .
2712 * buildbot/test/test_vc.py (SVN.testCheckout): same
2713 (Darcs.testPatch): same
2714 * docs/buildbot.texinfo (SVN): document the change
2715 (Darcs): same, add some build-on-branch docs
2716 * docs/examples/twisted_master.cfg: match change
2718 * buildbot/process/step.py (BuildStep): rename
2719 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2720 how it is normally used.
2721 * buildbot/test/test_steps.py (Version.checkCompare): same
2723 * buildbot/process/step.py (CVS.startVC): refuse to build
2724 update/copy -style builds on a non-default branch with an old
2725 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2726 concern is that it will do a VC 'update' in an existing tree when
2727 it is supposed to be switching branches (and therefore clobbering
2728 the tree to do a full checkout), thus building the wrong source.
2729 This used to be a warning, but I think the confusion it is likely
2730 to cause warrants making it an error.
2731 (SVN.startVC): same, also make mode=export on old slaves an error
2732 (Darcs.startVC): same
2733 (Git.startVC): improve error message for non-Git-enabled slaves
2734 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2735 specific revision is built on a slave that doesn't pay attention
2736 to args['revision'], because for slowly-changing trees it will
2737 probably do the right thing, and because we have no way to tell
2738 whether we're asking it to build the most recent version or not.
2739 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2741 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2742 that 'master' is in host:portnum format, to catch errors sooner
2744 2005-10-23 Brian Warner <warner@lothar.com>
2746 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2747 when creating the list of warning messages, include the line
2748 immediately after each WARNING: line, since that's usually where
2749 the file and line number wind up.
2751 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2756 2005-10-22 Brian Warner <warner@lothar.com>
2758 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2759 patch from Brad Hards
2760 * buildbot/status/classic.css: same
2761 * buildbot/test/test_web.py (Waterfall): match changes
2763 * buildbot/test/test_steps.py (BuildStep.setUp): set
2764 nextBuildNumber so the test passes
2765 * buildbot/test/test_status.py (MyBuilder): same
2767 * buildbot/status/html.py (StatusResourceBuild.body): revision
2768 might be numeric, so stringify it before html-escapifying it
2769 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2770 timer for the upcoming build
2771 * buildbot/status/classic.css: add background-color attributes for
2772 offline/waiting/building classes
2774 * buildbot/status/builder.py (BuildStatus): derive from
2775 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2776 the default (i.e. unknown) .slavename to "???" instead of None,
2777 since even unknown slavenames need to be printed eventually.
2778 (BuilderStatus): also derive from styles.Versioned . More
2779 importantly, determine .nextBuildNumber at creation/unpickling
2780 time by scanning the directory of saved BuildStatus instances and
2781 choosing one larger than the highest-numbered one found. This
2782 should fix the problem where random errors during upgrades cause
2783 the buildbot to forget about earlier builds. .nextBuildNumber is
2784 no longer stored in the pickle.
2785 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2786 at least log the error. Also call Builder.determineNextBuildNumber
2787 once the basedir is set.
2789 * buildbot/master.py (BuildMaster.loadChanges): do
2790 styles.doUpgrade afterwards, in case I decide to make Changes
2791 derived from styles.Versioned some day and forget to make this
2795 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2796 when running under older pythons (<2.3) in which the shlex module
2797 doesn't have a 'split' function.
2799 * buildbot/process/step.py (ShellCommand.start): make
2800 errorMessages= be a list of strings to stuff in the log before the
2801 command actually starts. This makes it easier to flag multiple
2802 warning messages, e.g. when the Source steps have to deal with an
2804 (CVS.startVC): handle slaves that don't handle multiple branches
2805 by switching into 'clobber' mode
2806 (SVN.startVC): same. Also reject branches without base_url
2807 (Darcs.startVC): same. Also reject revision= in older slaves
2808 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2809 (Bazaar.startVC): same, and test for baz separately than for arch
2811 * buildbot/slave/commands.py (cvs_ver): document new features
2813 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2814 (BuildStep.slaveVersionNewEnough): more useful utility method
2815 * buildbot/test/test_steps.py (Version): start testing it
2817 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2818 the 'force' command requires python2.3, for the shlex.split method
2820 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2821 since we don't use it anymore. The Twisted buildbot uses a
2824 2005-10-21 Brian Warner <warner@lothar.com>
2826 * buildbot/process/process_twisted.py: rework all BuildFactory
2827 classes to take a 'source' step as an argument, instead of
2828 building up the SVN instance in the factory.
2829 * docs/examples/twisted_master.cfg: enable build-on-branch by
2830 providing a base_url and default_branch
2832 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2833 control over --branch and --revision, not that they are always
2835 * buildbot/status/html.py (StatusResourceBuilder.force): same
2836 (StatusResourceBuild.body): display SourceStamp components
2838 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2839 IRC 'force' command, so it can be shared with an eventual
2840 command-line-tool 'buildbot force' mode.
2841 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2843 2005-10-20 Brian Warner <warner@lothar.com>
2845 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2847 * docs/examples/twisted_master.cfg: update to use Schedulers
2849 * buildbot/scripts/sample.cfg: update with Schedulers
2851 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2852 method specifically for use by HTML "force build" button and the
2853 IRC "force" command. Raises an immediate error if there are no
2855 (IBuilderControl.requestBuild): make this just submit a build, not
2856 try to check for existing slaves or set up any when-finished
2857 Deferreds or anything.
2858 * buildbot/process/builder.py (BuilderControl): same
2859 * buildbot/status/html.py (StatusResourceBuilder.force): same
2860 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2861 * buildbot/test/test_slaves.py: same
2862 * buildbot/test/test_web.py: same
2864 2005-10-19 Brian Warner <warner@lothar.com>
2866 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2867 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2869 2005-10-18 Brian Warner <warner@lothar.com>
2871 * buildbot/status/html.py: provide 'status' argument to most
2872 StatusResourceFOO objects
2873 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2874 and Logfiles" section to make the Build page into a more-or-less
2875 comprehensive source of status information about the build
2877 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2878 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2880 2005-10-17 Brian Warner <warner@lothar.com>
2882 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2883 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2884 out what to do about other projects: the correct options for
2885 recent Twisteds will not work for older ones.
2887 2005-10-15 Brian Warner <warner@lothar.com>
2889 * buildbot/status/builder.py (Status.getURLForThing): add method
2890 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2891 use this in email/IRC status clients to make them more useful, by
2892 providing the end user with hints on where to learn more about the
2893 object being reported on.
2894 * buildbot/test/test_web.py (GetURL): tests for it
2896 2005-10-14 Brian Warner <warner@lothar.com>
2898 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2899 fix bug resulting from deferredResult changes
2901 2005-10-13 Brian Warner <warner@lothar.com>
2903 * buildbot/test/test_changes.py: remove use of deferredResult
2904 * buildbot/test/test_config.py: same
2905 * buildbot/test/test_control.py: same
2906 * buildbot/test/test_status.py: same
2907 * buildbot/test/test_vc.py: this is the only remaining use, since
2908 it gets used at module level. This needs to be replaced by some
2909 sort of class-level run-once routine.
2911 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2913 * lots: implement multiple slaves per Builder, which means multiple
2914 current builds per Builder. Some highlights:
2915 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2916 of (state,currentBuilds) instead of (state,currentBuild)
2917 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2918 (IBuildStatus.getSlavename): new method, so you can tell which
2919 slave got used. This only gets set when the build completes.
2920 (IBuildRequestStatus.getBuilds): new method
2922 * buildbot/process/builder.py (SlaveBuilder): add a .state
2923 attribute to track things like ATTACHING and IDLE and BUILDING,
2925 (Builder): .. the .slaves attribute here, which has been turned
2926 into a simple list of available slaves. Added a separate
2927 attaching_slaves list to track ones that are not yet ready for
2929 (Builder.fireTestEvent): put off the test-event callback for a
2930 reactor turn, to make tests a bit more consistent.
2931 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2932 ping fails due to an exception. This needs work, I'm worried that
2933 a code error could lead to a constantly re-connecting slave.
2934 Especially since I'm trying to move to a distinct remote_ping
2935 method, separate from the remote_print that we currently use.
2936 (BuilderControl.requestBuild): return a convenience Deferred that
2937 provides an IBuildStatus when the build finishes.
2938 (BuilderControl.ping): ping all connected slaves, only return True
2939 if they all respond.
2941 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2942 reconnect when we shut down.
2944 * buildbot/status/builder.py: implement new methods, convert
2945 one-build-at-a-time methods to handle multiple builds
2946 * buildbot/status/*.py: do the same in all default status targets
2947 * buildbot/status/html.py: report the build's slavename in the
2948 per-Build page, report all buildslaves on the per-Builder page
2950 * buildbot/test/test_run.py: update/create tests
2951 * buildbot/test/test_slaves.py: same
2952 * buildbot/test/test_scheduler.py: remove stale test
2954 * docs/buildbot.texinfo: document the new builder-specification
2955 'slavenames' parameter
2957 2005-10-12 Brian Warner <warner@lothar.com>
2959 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2960 report failure correctly, causing Dependent builds to run when
2961 they shouldn't have.
2962 * buildbot/status/builder.py (BuildSetStatus): same
2963 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2964 (Set.testSuccess): test the both-pass case too
2965 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2966 fix this test: it was ending too early, masking the failure before
2967 (Logger): specialized StatusReceiver to make sure the dependent
2968 builds aren't even started, much less completed.
2970 2005-10-07 Brian Warner <warner@lothar.com>
2972 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2973 bot.SlaveBuilder being disowned in the middle of a build
2975 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2976 this inherit from StatusReceiver. Also upcall in __init__. This
2977 fixes the embarrasing crash when the new buildSetSubmitted method
2978 is invoked and Waterfall/etc don't implement their own.
2979 * buildbot/test/test_run.py: add a TODO note about a test to catch
2980 just this sort of thing.
2982 * buildbot/process/builder.py (Builder.attached): remove the
2983 already-attached warning, this situation is normal. Add some
2984 comments explaining it.
2986 2005-10-02 Brian Warner <warner@lothar.com>
2988 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2989 OverflowError when setting up dnotify, because some 64-bit systems
2990 have problems with signed-vs-unsigned constants and trip up on the
2991 DN_MULTISHOT flag. Patch from Brad Hards.
2993 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2995 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2996 progressMetrics, description, descriptionDone to the 'parms' list,
2997 and make use the 'parms' list from the implementation class
2998 instead of only BuildStep to initialize the parameters. This
2999 allows buildbot.process.factory.s() to initialize all the parms,
3000 not just those defined in directly by BuildStep.
3002 2005-09-03 Brian Warner <warner@lothar.com>
3004 * NEWS: start adding items for the next release
3006 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3007 python2.2 tests, change 'Quick' builder to only use python2.3
3009 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3011 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3012 the "Ping Builder" button if the build control is available; the
3013 user sees an exception otherwise
3015 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3017 2005-09-01 Brian Warner <warner@lothar.com>
3019 * buildbot/interfaces.py (IBuilderStatus.getState): update
3020 signature, point out that 'build' can be None
3021 (IBuildStatus.getETA): point out ETA can be none
3023 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3025 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3027 2005-08-31 Brian Warner <warner@lothar.com>
3029 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3030 update to match correct signature: removed 'eta' argument
3031 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3033 2005-08-30 Brian Warner <warner@lothar.com>
3035 * buildbot/status/builder.py (LogFile): remove the assertion that
3036 blows up when you try to overwrite an existing logfile, instead
3037 just emit a warning. This case gets hit when the buildmaster is
3038 killed and doesn't get a chance to write out the serialized
3039 BuilderStatus object, so the .nextBuildNumber attribute gets out
3042 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3043 the 'buildbot sendchange' arguments, for the Darcs context file
3044 * docs/buildbot.texinfo (sendchange): document it
3046 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3047 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3048 (IStatus.getSchedulers): new method
3049 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3050 (Status.getSchedulers): implement
3051 * buildbot/process/builder.py (Builder): maintain
3052 BuilderStatus.pendingBuilds
3053 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3054 (TryBase.addChange): Try schedulers should ignore Changes
3056 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3057 for 'try' on CVS/SVN
3058 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3060 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3061 report status properly.
3062 (Try.createJob): implement unique buildset IDs
3064 * buildbot/status/client.py (StatusClientPerspective): add a
3065 perspective_getBuildSets method for the benefit of jobdir-style
3067 * docs/buildbot.texinfo (try): more docs
3068 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3071 2005-08-18 Brian Warner <warner@lothar.com>
3073 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3074 actually work. It's functional but still kind of clunky. Also, it
3075 only works with the pb-style.. needs to be made to work with the
3078 * buildbot/status/client.py (RemoteBuildSet): new class
3079 (RemoteBuildRequest): same
3080 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3081 object, not the internal BuildStatus object.
3082 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3083 outside of the usual buildStarted() return value.
3084 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3086 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3087 (Try_Userpass_Perspective.perspective_try): return a remotely
3088 usable BuildSetStatus object
3090 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3091 isStarted()/waitUntilStarted()
3093 2005-08-16 Brian Warner <warner@lothar.com>
3095 * buildbot/status/builder.py: implement IBuildSetStatus and
3096 IBuildRequestStatus, wire them into place.
3097 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3098 methods into the BuildSetStatus object.
3099 * buildbot/interfaces.py: same
3100 (IStatus.getBuildSets): new method to get pending BuildSets
3101 (IStatusReceiver.buildsetSubmitted): new method which hears about
3103 * buildbot/master.py (BuildMaster.submitBuildSet): same
3104 * buildbot/process/base.py (BuildRequest): same, replace
3105 waitUntilStarted with subscribe/unsubscribe
3106 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3107 subscribe instead of waitUntilStarted
3108 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3110 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3112 * buildbot/test/test_buildreq.py: update for new code
3113 * buildbot/test/test_control.py (Force.testRequest): same
3116 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3117 for Darcs to not use the tempfile module, so it works under
3118 python-2.2 too. We really didn't need the full cleverness of that
3119 module, since the slave has exclusive control of its own builddir.
3121 2005-08-15 Brian Warner <warner@lothar.com>
3123 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3124 for CVS trees. It doesn't work for non-trunk branches,
3126 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3129 * Makefile: make it easier to test against python2.2
3131 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3132 tearDown2, so things like Arch can unregister archives as they're
3133 shutting down. The previous subclass-override-tearDown technique
3134 resulted in a nested maybeWait() and test failures under
3137 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3138 where we can (Arch), add a branch= argument to set the branch used
3140 (BazExtractor): extract the branch too
3141 (TlaExtractor): same
3142 * buildbot/scripts/runner.py (TryOptions): add --branch
3143 * docs/buildbot.texinfo (try): document --branch/try_branch
3145 * buildbot/slave/commands.py (Darcs): implement get-revision for
3146 Darcs, so that 'try' will work. This requires the tempfile module
3149 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3150 of revisions, branches, and 'try' in the process.
3152 2005-08-11 Brian Warner <warner@lothar.com>
3154 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3155 this, it got broken at some point in the last few releases
3156 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3157 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3158 specifically the removal of ETA information from the tuple
3160 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3163 * docs/buildbot.texinfo (try): document both --builder and
3164 'try_builders' in .buildbot/options
3165 * buildbot/scripts/runner.py (TryOptions): add --builder,
3166 accumulate the values into opts['builders']
3167 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3168 * buildbot/test/test_runner.py (Try): add some quick tests to make
3169 sure 'buildbot try --options' and .buildbot/options get parsed
3170 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3171 use --builder control
3173 * docs/buildbot.texinfo (try): add --port argument to PB style
3175 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3176 actual SourceStamp. Still need to extract a branch name, somehow.
3177 (Try): finish implementing the try client side, still need a UI
3178 for specifying which builders to use
3179 (Try.getopt): factor our options/config-file reading
3180 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3182 * buildbot/test/test_vc.py: match SourceStampExtractor change
3184 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3185 causes the twisted log to be sent to stderr
3187 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3189 2005-08-10 Brian Warner <warner@lothar.com>
3191 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3192 style is 90% done, still missing status reporting or waiting for
3193 the buildsets to finish, and it is completely untested.
3195 * buildbot/trybuild.py: delete file, move contents to ..
3196 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3197 * buildbot/test/test_vc.py: match the move
3199 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3200 of the TryScheduler, no buildsetID or status-tracking support yet
3201 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3203 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3204 possible to set the basedir after __init__ time, so it is easier
3205 to use as a Service-child of the BuildMaster instance
3207 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3208 that delivers messages to its Service parent instead of requiring
3209 a subclass to be useful. This turns out to be much easier to build
3212 * buildbot/scripts/tryclient.py (createJob): utility code to
3213 create jobfiles, will eventually be used by 'buildbot try'
3215 2005-08-08 Brian Warner <warner@lothar.com>
3217 * docs/buildbot.texinfo (try): add docs on the
3218 as-yet-unimplemented Try scheduler
3220 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3221 * buildbot/test/test_scheduler.py: .. here
3222 (Scheduling.testTryJobdir): add placeholder test for 'try'
3224 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3225 addEntry merging (>=chunkSize) behavior
3226 (Log.testConsumer): update to handle new callLater(0) behavior
3228 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3229 both the MAX_LENGTH bugfix and the resumeProducing hang.
3231 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3232 put off the actual resumeProducing for a moment with
3233 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3234 causes large logfiles to hang midway through.
3236 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3237 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3238 and to improve memory usage when streaming the file out to a web
3240 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3241 make this work cleanly
3243 2005-08-03 Brian Warner <warner@lothar.com>
3245 * buildbot/trybuild.py: new file for 'try' utilities
3246 (getSourceStamp): run in a tree, find out the baserev+patch
3247 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3248 implemented for SVN and Darcs, still working on Arch. I don't know
3249 how to make CVS work yet.
3251 * docs/buildbot.texinfo: document the 'buildbot' command-line
3252 tool, including the not-yet-implemented 'try' feature, and the
3253 in-flux .buildbot/ options directory.
3255 2005-07-20 Brian Warner <warner@lothar.com>
3257 * buildbot/locks.py: added temporary id() numbers to Lock
3258 descriptions, to track down a not-really-sharing-the-Lock bug
3260 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3262 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3263 needed for python2.2 compatibility
3264 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3265 are from the __future__
3267 2005-07-19 Brian Warner <warner@lothar.com>
3269 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3270 message when schedulers use unknown builders
3272 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3273 SlaveLock('name') and MasterLock('name') are distinct
3275 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3276 c['schedulers'] in such a way that we can actually accept
3278 * buildbot/test/test_config.py: check it
3280 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3281 utility method to *all* the Schedulers
3282 (Periodic.listBuilderNames): same
3284 * docs/buildbot.texinfo (Interlocks): update chapter to match
3287 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3288 to make sure that c['sources'], c['schedulers'], and c['status']
3289 are all lists of the appropriate objects, and that the Schedulers
3290 all point to real Builders
3291 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3292 'listBuilderNames' utility method to support this
3293 * buildbot/scheduler.py: implement the utility method
3294 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3296 * docs/buildbot.texinfo: add some @cindex entries
3298 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3299 if it wasn't already set: most tla commands will fail unless one
3301 (Arch.createRepository): and disable bazaar's revision cache, since
3302 they cause test failures (the multiple repositories we create all
3303 interfere with each other through the cache)
3305 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3306 bring it properly up to date with twisted-2.0 test guidelines
3308 * buildbot/master.py (BuildMaster): remove references to old
3309 'interlock' module, this caused a bunch of post-merge test
3311 * buildbot/test/test_config.py: same
3312 * buildbot/process/base.py (Build): same
3314 * buildbot/test/test_slaves.py: stubs for new test case
3316 * buildbot/scheduler.py: add test-case-name tag
3317 * buildbot/test/test_buildreq.py: same
3319 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3320 unnecessary init code
3321 (Bot.remote_setBuilderList): match it
3323 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3325 * buildbot/changes/mail.py (parseSyncmail): update comment
3327 * buildbot/test/test_slavecommand.py: disable Shell tests on
3328 platforms that don't suport IReactorProcess
3330 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3331 all places where we open logfiles. It causes OS-X to open the file
3332 in some weird mode that that prevents us from mixing reads and
3333 writes to the same filehandle, which we depend upon to implement
3334 _generateChunks properly. This change doesn't appear to break
3335 win32, on which "b" and "t" are treated differently but a missing
3336 flag seems to be interpreted as "t".
3338 2005-07-18 Brian Warner <warner@lothar.com>
3340 * buildbot/slave/commands.py (ShellCommand): overhaul
3341 error-handling code, to try and make timeout/interrupt work
3342 properly, and make win32 happier
3343 * buildbot/test/test_slavecommand.py: clean up, stop using
3344 reactor.iterate, add tests for timeout and interrupt
3345 * buildbot/test/sleep.py: utility for a new timeout test
3347 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3348 code from the local-usebranches branch
3350 2005-07-17 Brian Warner <warner@lothar.com>
3352 * buildbot/process/process_twisted.py
3353 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3354 minutes, to match the other twisted BuildFactories, and don't
3355 excuse failures in c/qt/win32 reactors any more.
3357 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3358 'freebsd' builders, since the buildslaves have been unavailable
3361 2005-07-13 Brian Warner <warner@lothar.com>
3363 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3364 build-on-branch feature
3366 * buildbot/process/step.py (Darcs.__init__): add base_url and
3367 default_branch arguments, just like SVN
3368 (Arch.__init__): note that the version= argument is really the
3371 * buildbot/slave/commands.py (SourceBase): keep track of the
3372 repository+branch that was used for the last checkout in
3373 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3374 match, we clobber the directory and perform a fresh checkout
3375 rather than trying to do an in-place update. This should protect
3376 us against trying to get to branch B by doing an update in a tree
3377 obtained from branch A.
3378 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3379 (SVN.setup): same, just the svnurl
3380 (Darcs.setup): same, just the repourl
3381 (Arch.setup): same, arch coordinates (url), version, and
3382 buildconfig. Also pull the buildconfig from the args dictionary,
3383 which we weren't doing before, so the build-config was effectively
3385 (Arch.sourcedirIsUpdateable): don't try to update when we're
3386 moving to a specific revision: arch can't go backwards, so it is
3387 safer to just clobber the tree and checkout a new one at the
3389 (Bazaar.setup): same sourcedata as Arch
3391 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3392 use maybeWait, to work with twisted-1.3.0 and twcompat
3393 (Dependencies.testRun_Pass): same
3395 * buildbot/test/test_vc.py: rearrange, cleanup
3397 * buildbot/twcompat.py: add defer.waitForDeferred and
3398 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3399 can work under twisted-1.3.0 .
3401 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3402 now created at setUp time. This increases the runtime of the test
3403 suite considerably (from 91 seconds to 151), but it removes the
3404 need for an offline tarball, which should solve a problem I've
3405 seen where the test host has a different version of svn than the
3406 tarball build host. The new code also validates that mode=update
3407 really picks up recent commits. This approach will also make it
3408 easier to test out branches, because the code which creates the VC
3409 branches is next to the code which uses them. It will also make it
3410 possible to test some change-notification hooks, by actually
3411 performing a VC commit and watching to see the ChangeSource get
3414 2005-07-12 Brian Warner <warner@lothar.com>
3416 * docs/buildbot.texinfo (SVN): add branches example
3417 * docs/Makefile (buildbot.ps): add target for postscript manual
3419 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3420 * buildbot/test/test_locks.py: same
3422 * buildbot/process/step.py (Darcs): comment about default branches
3424 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3425 c['interlocks'] in the config file, complain if it is present.
3426 Scan all locks in c['builders'] to make sure the Locks they use
3428 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3429 add some tests to check for non-uniquely-named Locks
3430 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3431 since the unique-Lock validation code requires it now
3433 * buildbot/locks.py: fix test-case-name
3435 * buildbot/interlock.py: remove old file
3437 2005-07-11 Brian Warner <warner@lothar.com>
3439 * buildbot/test/test_interlock.py: rename to..
3440 * buildbot/test/test_locks.py: .. something shorter
3442 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3443 versions (after 2.0.1) changed internet.TCPClient to shut down the
3444 connection in stopService. Change the code to handle this
3447 * buildbot/process/base.py (Build): handle whole-Build locks
3448 * buildbot/process/builder.py (Builder.compareToSetup): same
3449 * buildbot/test/test_interlock.py: make tests work
3451 * buildbot/process/step.py (BuildStep.startStep): complain if a
3452 Step tries to claim a lock that's owned by its own Build
3453 (BuildStep.releaseLocks): typo
3455 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3456 file reloads don't replace unchanged Builders
3458 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3459 rewrite to cover new Locks instead of old c['interlocks']
3460 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3464 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3465 start the master and connect the buildslave
3467 * buildbot/process/step.py (FailingDummy.done): finish with a
3468 FAILURE status rather than raising an exception
3470 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3471 stringify a BuildRequest.reason that is None
3473 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3475 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3476 allow scheduler.Dependent to work
3477 * buildbot/buildset.py (BuildSet): set .reason and .results
3479 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3480 slaves, to make the test stop hanging. It still fails, of course,
3481 because I haven't even started to implement Locks.
3483 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3485 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3486 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3487 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3488 (Dependent): new class for downstream build dependencies
3489 * buildbot/test/test_dependencies.py: tests (still failing)
3491 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3493 2005-07-07 Brian Warner <warner@lothar.com>
3495 * buildbot/test/runutils.py (RunMixin): factored this class out..
3496 * buildbot/test/test_run.py: .. from here
3497 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3498 added new buildbot.locks tests (which all hang right now)
3499 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3500 * buildbot/process/step.py: claim/release per-BuildStep locks
3502 * docs/Makefile: add 'buildbot.html' target
3504 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3505 interpreted as "HEAD", so that all VC steps can accept branch=None
3506 and have it mean the "default branch".
3508 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3510 2005-07-07 Brian Warner <warner@lothar.com>
3512 * docs/examples/twisted_master.cfg: update to match current usage
3514 * docs/buildbot.texinfo (System Architecture): comment out the
3515 image, it doesn't exist yet and just screws up the HTML manual.
3517 2005-07-05 Brian Warner <warner@lothar.com>
3519 * debian/.cvsignore: oops, missed one. Removing leftover file.
3521 2005-06-17 Brian Warner <warner@lothar.com>
3523 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3524 changed its output in 1.2.0, don't mistakenly think that the
3525 subversion we find isn't capable of supporting our tests.
3527 * debian/*: remove the debian/ directory and its contents, to make
3528 life easier for the proper Debian maintainer
3530 * Makefile (release): same
3532 2005-06-07 Brian Warner <warner@lothar.com>
3534 * everything: create a distinct SourceStamp class to replace the
3535 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3536 Changed the signature of Source.startVC to include the revision
3537 information (instead of passing it through self.args). Implement
3538 branches for SVN (now only Darcs/Git is missing support). Add more
3541 2005-06-06 Brian Warner <warner@lothar.com>
3543 * everything: rearrange build scheduling. Create a new Scheduler
3544 object (configured in c['schedulers'], which submit BuildSets to a
3545 set of Builders. Builders can now use multiple slaves. Builds can
3546 be run on alternate branches, either requested manually or driven
3547 by changes. This changed some of the Status classes. Interlocks
3548 are out of service until they've been properly split into Locks
3549 and Dependencies. treeStableTimer, isFileImportant, and
3550 periodicBuild have all been moved from the Builder to the
3552 (BuilderStatus.currentBigState): removed the 'waiting' and
3553 'interlocked' states, removed the 'ETA' argument.
3555 2005-05-24 Brian Warner <warner@lothar.com>
3557 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3558 erroneously abandons the connection (in clientConnectionFailed)
3559 for non-UserErrors, which means that if we lose the connection due
3560 to a network problem or a timeout, we'll never try to reconnect.
3561 Fix this by not upcalling to the buggy parent method. Note:
3562 twisted-2.0 fixes this, but the function only has 3 lines so it
3563 makes more sense to copy it than to try and detect the buggyness
3564 of the parent class. Fixes SF#1207588.
3566 * buildbot/changes/changes.py (Change.branch): doh! Add a
3567 class-level attribute to accomodate old Change instances that were
3568 pickled before 0.6.5 (where .branch was added for new Changes).
3569 This fixes the exception that occurs when you try to look at an
3570 old Change (through asHTML).
3572 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3575 2005-05-23 Brian Warner <warner@lothar.com>
3577 * buildbot/__init__.py (version): release 0.6.6
3579 2005-05-23 Brian Warner <warner@lothar.com>
3581 * NEWS: update for 0.6.6 release
3582 * debian/changelog: same
3584 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3585 before starting: this was done by twistd back when we spawned it,
3586 now that we're importing the pieces and running them in the
3587 current process, we have to do it ourselves. This allows
3588 master.cfg to import files from the same directory without
3589 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3590 Stichele for the catch.
3591 (Options.opt_version): Add a --version command (actually, just make
3592 the existing --version command emit Buildbot's version too)
3594 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3595 fix to make this behave like other LogFiles, this time to handle
3596 existing LogFiles on disk. (add the missing .upgrade method)
3597 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3599 2005-05-21 Brian Warner <warner@lothar.com>
3601 * buildbot/test/test_runner.py (Create.testMaster): match the
3602 rawstring change in runner.py:masterTAC
3604 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3605 TwistedWords is installed
3606 * buildbot/test/test_status.py: same, with TwistedMail
3608 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3609 some old, deprecated, and removed config keys). This should enable
3610 you to use the base buildbot functionality with Twisted-2.0.0 when
3611 you don't also have TwistedWeb and TwistedWords installed
3613 2005-05-20 Brian Warner <warner@lothar.com>
3615 * buildbot/scripts/runner.py (run): call sendchange(), not
3616 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3617 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3618 (stop): don't wait for process to die when sending SIGHUP
3619 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3620 directory name gets interpreted, which you don't want
3623 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3626 2005-05-18 Brian Warner <warner@lothar.com>
3628 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3630 2005-05-18 Brian Warner <warner@lothar.com>
3632 * README: update for 0.6.5
3633 * debian/changelog: same
3635 * buildbot/changes/changes.py: rename tag= to branch=, since
3636 that's how we're using it, and my design for the upcoming "build a
3637 specific branch" feature wants it. also, tag= was too CVS-centric
3638 * buildbot/changes/mail.py (parseSyncmail): same
3639 * buildbot/process/base.py (Build.isBranchImportant): same
3640 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3641 * docs/buildbot.texinfo (Attributes of Changes): same
3643 * NEWS: update tag=, update for upcoming release
3645 2005-05-17 Brian Warner <warner@lothar.com>
3647 * buildbot/scripts/runner.py (stop): actually poll once per
3648 second, instead of re-killing the poor daemon once per second.
3649 Sleep briefly (0.1s) before the first poll, since there's a good
3650 chance we can avoid waiting the full second if the daemon shuts
3651 down quickly. Also remove the sys.exit() at the end.
3652 (start): remove the unneighborly sys.exit()
3654 * Makefile: improve permission-setting to not kick Arch so badly
3656 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3657 default --keepalive=600, since it doesn't hurt very much, and it's
3658 a hassle to discover that you need it.
3659 * buildbot/test/test_runner.py (Create.testSlave): test it
3661 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3662 IRC bot about EXCEPTION
3664 * buildbot/status/client.py (PBListener): upcall more correctly
3666 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3667 an exception mark the overall build with EXCEPTION, not SUCCESS
3669 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3671 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3672 * Makefile: update some release-related stuff
3674 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3675 gets called when there isn't actually an active process, just end
3676 the Command instead of blowing up. I don't know how it gets into
3677 this state, but the twisted win32 buildslave will sometimes hang,
3678 and when it shakes its head and comes back, it thinks it's still
3679 running a Command. The next build causes this command to be
3680 interrupted, but the lack of self.process.pid breaks the interrupt
3683 * NEWS: document changes since the last release
3685 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3686 look for Makefile.buildbot instead of a bare Makefile . The
3687 'buildbot start' does not install this file, so you have to
3688 manually copy it if you want to customize startup behavior.
3689 (createMaster): change 'buildbot master' command to create
3690 Makefile.sample instead of Makefile, to create master.cfg.sample
3691 instead of master.cfg (requiring you to copy it before the
3692 buildmaster can be started). Both sample files are kept up to
3693 date, i.e. they are overwritten if they have been changed. The
3694 'buildbot.tac' file is *not* overwritten, but if the new contents
3695 don't match the old, a 'buildbot.tac.new' file is created and the
3696 user is warned. This seems to be a much more sane way to handle
3697 startup files. Also, don't sys.exit(0) when done, so we can run
3698 unit tests against it.
3699 (createSlave): same. Don't overwrite the sample info/ files.
3700 * buildbot/scripts/sample.mk: remove. the contents were pulled
3701 into runner.py, since they need to match the behavior of start()
3705 * docs/buildbot.texinfo (Launching the daemons): document it
3706 * buildbot/test/test_runner.py (Create): test it
3708 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3709 version that can handle string-in-string tests, because otherwise
3710 python-2.2 fails the tests. It'd be tremendous if Trial's test
3711 took two strings under 2.2 too.
3713 * everything: fixed all deprecation warnings when running against
3714 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3715 few that come from Twisted itself). This involved putting most of
3716 the Twisted-version specific code in the new buildbot.twcompat
3717 module, and creating some abstract base classes in
3718 buildbot.changes.base and buildbot.status.base (which might be
3719 useful anyway). __implements__ is a nuisance and requires an ugly
3720 'if' clause everywhere.
3722 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3723 delay before finishing the test: it seems that smtp.sendmail
3724 doesn't hang up on the server, so we must wait a moment so it can
3725 hang up on us. This removes the trial warning about an unclean
3728 2005-05-16 Brian Warner <warner@lothar.com>
3730 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3731 tuple of (delay, repeats).
3732 * buildbot/test/test_vc.py (Retry): test it
3733 * docs/buildbot.texinfo (Source Checkout): document it
3734 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3735 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3736 doVCFull() are handled by re-trying the checkout (after a delay)
3737 some number of times.
3738 (ShellCommand._startCommand): make header lines easier to read
3740 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3742 (WebTest.test_logfile): make sure master gets shut down, silences
3743 some "unclean reactor" test errors
3745 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3746 reactor once after shutdown, something in certain versions of
3747 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3748 fails, svn-trunk is ok.
3750 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3751 second win32 error message
3753 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3754 validating the ETA, so the tests don't fail on slow systems
3756 2005-05-15 Brian Warner <warner@lothar.com>
3758 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3759 the new LogFile class, so upgrading works properly
3760 (LogFileProducer.resumeProducing): survive resumeProducing after
3761 we've exhausted the chunkGenerator
3763 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3765 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3766 (Log.testUpgrade): same
3768 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3769 Builds and logs with a cron job.
3771 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3772 of the old non-offline LogFile, added code to upgrade these to
3773 new-style contents-live-on-disk instances at load time (in a way
3774 that doesn't invalidate the old Build pickles, so upgrading to
3775 0.6.5 is not a one-way operation). Got rid of everything related
3777 (LogFile.__init__): create LogFiles with the parent step status,
3778 the log's name, and a builder-relative filename where it can keep
3779 the contents on disk.
3780 (LogFile.hasContents): new method, clients are advised to call it
3781 before getText or getChunks and friends. If it returns False, the
3782 log's contents have been deleted and getText() will raise an
3784 (LogFile.getChunks): made it a generator
3785 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3786 Consumer (except one that takes chunks instead of strings). This
3787 enables streaming of very large logfiles without storing the whole
3789 (BuildStatus.generateLogfileName): create names like
3790 12-log-compile-output, with a _0 suffix if required to be unique
3791 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3792 or earlier) logfiles into new-style ones
3793 (BuilderStatus): remove everything related to 'stub' builds. There
3794 is now only one build cache, and we don't strip logs from old
3796 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3797 since we no longer fight to keep it in the cache
3799 * buildbot/status/html.py (TextLog.render_GET): use a
3800 ChunkConsumer to stream the log entries efficiently.
3801 (ChunkConsumer): wrapper which consumes chunks and writes
3804 * buildbot/test/test_twisted.py (Parse.testParse): use a
3805 LogFile-like object instead of a real one
3807 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3808 (Log.testMerge3): validate more merge behavior
3809 (Log.testChunks): validate LogFile.getChunks
3810 (Log.testUpgrade): validate old-style LogFile upgrading
3811 (Log.testSubscribe): validate LogFile.subscribe
3812 (Log.testConsumer): validate LogFile.subscribeConsumer
3814 * buildbot/interfaces.py (IStatusLogStub): remove
3815 (IStatusLog.subscribeConsumer): new method
3816 (IStatusLog.hasContents): new method
3817 (IStatusLogConsumer): describes things passed to subscribeConsumer
3819 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3820 the log contents if it does not have any contents.
3821 (StatusResourceBuildStep.body): same
3822 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3824 2005-05-14 Brian Warner <warner@lothar.com>
3826 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3827 timeouts to try and make the windows metabuildslave not hang
3829 2005-05-13 Mike Taylor <bear@code-bear.com>
3831 * buildbot/slave/commands.py (rmdirRecursive): added a check
3832 to ensure the path passed into rmdirRecursive actually exists.
3833 On win32 a non-existant path would generate an exception.
3835 2005-05-13 Brian Warner <warner@lothar.com>
3837 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3838 shutil.rmtree which behaves correctly on windows in the face of
3839 files that you have to chmod before deleting. Thanks to Bear at
3840 the OSAF for the routine.
3841 (SourceBase.doClobber): use rmdirRecursive
3843 2005-05-12 Brian Warner <warner@lothar.com>
3845 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3846 method generate chunks instead of returning a big list. This
3847 allows the same method to be used for both old LogFile and new
3849 (OfflineLogFile.getText): use the generator
3850 (OfflineLogFile.subscribe): same
3851 * buildbot/status/html.py (TextLog.resumeProducing): same
3852 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3854 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3855 point out that OfflineLogFile does not currently work with
3856 html.Waterfall . Fixing this is high-priority.
3858 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3859 apparently windows defaults to using stdout
3861 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3862 better message on failure so I can figure out the win32 problem
3864 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3865 log messages to include more useful copies of the command being
3866 run, the argv array, and the child command's environment.
3867 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3869 2005-05-11 Brian Warner <warner@lothar.com>
3871 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3873 * Makefile: update the deb-snapshot version
3875 * docs/buildbot.texinfo: move all .xhtml docs into a new
3876 .texinfo-format document, adding a lot of material in the process.
3877 This is starting to look like a real user's manual. Removed all
3878 the Lore-related files: *.xhtml, *.css, template.tpl .
3879 * docs/Makefile: simple makefile to run 'makeinfo'
3880 * buildbot/scripts/sample.cfg: rearrange slightly
3881 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3883 2005-05-10 Brian Warner <warner@lothar.com>
3885 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3886 different name for the internal twistw module, handle it.
3888 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3889 * setup.py: .. and stop trying to install it
3891 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3892 'git'), the new linux kernel VC system (http://kernel.org/git/).
3893 Thanks to Brandon Philips for the patch.
3894 * buildbot/slave/commands.py (Git): same
3896 2005-05-06 Brian Warner <warner@lothar.com>
3898 * buildbot/status/builder.py (OfflineLogFile): replace the default
3899 LogFile with a form that appends its new contents to a disk file
3900 as they arrive. The complete log data is never kept in RAM. This
3901 is the first step towards handling very large (100MB+) logfiles
3902 without choking quite so badly. (The other half is
3903 producer/consumer on the HTML pages).
3904 (BuildStepStatus.addLog): use OfflineLogFile by default
3905 (BuildStatus.getLogfileName): helper code to give the
3906 OfflineLogFile a filename to work with
3908 * buildbot/test/test_status.py (Results.testAddResults): update
3909 tests to handle new asserts
3910 * buildbot/test/test_vc.py (Patch.doPatch): same
3911 * buildbot/test/test_steps.py (BuildStep.setUp): same
3913 2005-05-05 Brian Warner <warner@lothar.com>
3915 * buildbot/scripts/runner.py (start): if there is no Makefile,
3916 launch the app by importing twistd's internals and calling run(),
3917 rather than spawning a new twistd process. This stands a much
3918 better chance of working under windows.
3919 (stop): kill the process with os.kill instead of spawning
3920 /bin/kill, again to reduce the number of external programs which
3921 windows might not have in the PATH. Also wait up to 5 seconds for
3922 the process to go away, allowing things like 'buildbot stop;
3923 buildbot start' to be reliable in the face of slow shutdowns.
3925 * buildbot/master.py (Dispatcher.__getstate__): remove old
3926 .tap-related methods
3927 (BuildMaster.__getstate__): same
3929 * buildbot/slave/bot.py (makeService): same
3930 (Options.longdesc): same
3931 * buildbot/scripts/runner.py: copy over some old mktap option text
3933 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3934 'buildbot master' now creates a buildbot.tac file, so there is no
3935 longer a create-instance/save/reload sequence. mktap is dead, long
3937 * buildbot/scripts/sample.mk: use twistd -y, not -f
3938 * buildbot/test/test_config.py: remove mktap-based test
3939 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3940 * README: don't reference mktap
3942 * docs/source.xhtml: document some of the attributes that Changes
3945 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3947 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3948 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3949 * buildbot/changes/changes.py (Change)
3950 * buildbot/changes/mail.py (parseSyncmail)
3951 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3953 * buildbot/process/base.py (Build.isTagImportant)
3957 2005-05-04 Brian Warner <warner@lothar.com>
3959 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3960 connection after sending the change, so that unit tests don't
3961 complain about sockets being left around
3963 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3964 exception in phase=0 rendering
3965 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3967 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3969 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3970 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3971 and configuring builders with tuples.
3972 * buildbot/test/test_config.py: stop testing compatibility with
3973 deprecated config keys
3974 * buildbot/test/test_run.py: same
3976 2005-05-03 Brian Warner <warner@lothar.com>
3978 * contrib/arch_buildbot.py: survive if there are no logfiles
3979 (username): just use a string, os.getlogin isn't reliable
3981 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3982 so 'buildbot sendchange' actually works. The earlier test only
3983 covered the internal (non-reactor-running) form.
3985 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3986 script to notify the buildmaster about changes
3988 * buildbot/scripts/runner.py (sendchange): new command to send a
3989 change to a buildbot.changes.pb.PBChangeSource receiver.
3990 * buildbot/test/test_changes.py (Sender): test it
3992 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3993 after any reading of the config file, not just when we do it in
3994 startService. This makes some tests a bit cleaner.
3996 * buildbot/changes/pb.py: add some log messages
3998 * buildbot/process/base.py (Build.startBuild): fix a bug that
3999 caused an exception when the build terminated in the very first
4001 (Build.stepDone): let steps return a status of EXCEPTION. This
4002 terminates the build right away, and sets the build's overall
4003 status to EXCEPTION too.
4004 * buildbot/process/step.py (BuildStep.failed): return a status of
4005 EXCEPTION when that is what has happened.
4007 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4008 implement this, allowing Arch-based projects to get precise
4009 checkouts instead of always using the latest code
4010 (Bazaar): create variant of Arch to let folks use baz instead of
4011 tla. Requires a new buildslave too.
4012 * buildbot/slave/commands.py (Arch): add 'revision' argument
4013 (Bazaar): create variant of Arch that uses baz instead of tla.
4014 Remove the code that extracts the archive name from the
4015 register-archive output, since baz doesn't provide it, and require
4016 the user provide both the archive name and its location.
4017 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4019 2005-05-02 Brian Warner <warner@lothar.com>
4021 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4022 thanks to Nick Trout.
4024 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4025 deals better with source Makefile coming from a read-only CVS
4026 checkout. Thanks to Nick Trout for the catch.
4028 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4031 2005-04-28 Brian Warner <warner@lothar.com>
4033 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4035 * debian/changelog: update for 0.6.4
4037 2005-04-28 Brian Warner <warner@lothar.com>
4039 * README.w32: add a checklist of steps for getting buildbot
4041 * MANIFEST.in: include it in the tarball
4045 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4046 broken .tap files from 0.6.3 by getting rid of .services,
4047 .namedServices, and .change_svc at load time.
4049 2005-04-27 Brian Warner <warner@lothar.com>
4051 * NEWS: update in preparation for new release
4053 * buildbot/test/test_config.py (Save.testSave): don't pull in
4054 twisted.scripts.twistd, we don't need it and it isn't for windows
4057 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4058 accomodate win32 which can't do atomic-rename
4060 2005-04-27 Brian Warner <warner@lothar.com>
4062 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4063 timeouts to help the slow metabuildbot not flunk them so much
4064 (Disconnect.testBuild3): same
4065 (Disconnect.testBuild4): same
4066 (Disconnect.testInterrupt): same
4068 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4069 setup, it was completely broken for new buildmasters (those which
4070 did not have a 'change.pck' already saved. Thanks to Paul Warren
4071 for catching this (embarrassing!) bug.
4072 (Dispatcher.__getstate__): don't save our registered avatar
4073 factories, since they'll be re-populated when the config file is
4075 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4076 tests (since the real mktap-generated BuildMaster doesn't save
4078 (BuildMaster.__getstate__): don't save any service children,
4079 they'll all be re-populated when the config file is re-read.
4080 * buildbot/test/test_config.py (Save.testSave): test for this
4082 2005-04-26 Brian Warner <warner@lothar.com>
4084 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4085 rendered with Blender.. looks a bit nicer.
4086 * buildbot/docs/images/icon.blend: add the Blender file for it
4088 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4089 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4090 running under windows. This appears to be the best way to allow
4091 BuildSteps to do something normal like 'trial -v buildbot.test' or
4092 'make foo' and still expect it to work. The idea is to make the
4093 BuildSteps look as much like what a developer would type when
4094 compiling or testing the tree by hand. This approach probably has
4095 problems when there are spaces in the arguments, so if you've got
4096 windows buildslaves, you'll need to pay close attention to your
4099 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4100 timezone to the timestamp column.
4101 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4103 * buildbot/scripts/runner.py (loadOptions): do something sane for
4104 windows, I think. We use %APPDATA%/buildbot instead of
4105 ~/.buildbot, but we still search everywhere from the current
4106 directory up to the root for a .buildbot/ subdir. The "is it under
4107 $HOME" security test was replaced with "is it owned by the current
4108 user", which is only performed under posix.
4109 * buildbot/test/test_runner.py (Options.testFindOptions): update
4110 tests to match. The "is it owned by the current user" check is
4111 untested. The test has been re-enabled for windows.
4113 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4114 any "\n" in the expected output with the platform-specific line
4115 separator. Make this separator "\r\n" on PTYs under unix, they
4116 seem to do that and I don't know why
4118 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4119 windows for now, I don't know what ~/.buildbot/ should mean there.
4121 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4122 win32 compatibility, don't use "/tmp"
4123 (Basedir.testChangeBuilddir): remove more unixisms
4125 2005-04-26 Brian Warner <warner@lothar.com>
4127 * buildbot/test/test_control.py (Force.rmtree): python2.2
4128 compatibility, apparently its shutil.rmtree ignore_errors=
4129 argument is ignored.
4130 * buildbot/test/test_run.py (Run.rmtree): same
4131 (RunMixin.setUp): same
4133 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4136 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4137 'substring in string' operator, must use string.find(substr)!=-1
4138 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4139 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4141 * buildbot/scripts/runner.py (loadOptions): add code to search for
4142 ~/.buildbot/, a directory with things like 'options', containing
4143 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4144 the current directory, your $HOME directory, or anywhere
4145 inbetween, as long as you're somewhere inside your home directory.
4146 (debugclient): look in ~/.buildbot/options for master and passwd
4147 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4148 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4150 * buildbot/status/client.py (makeRemote): new approach to making
4151 IRemote(None) be None, which works under Twisted-2.0
4152 * buildbot/test/test_status.py (Client.testAdaptation): test it
4154 * buildbot/status/builder.py (Status.builderAdded): when loading a
4155 pickled BuilderStatus in from disk, set its name after loading.
4156 The config file might have changed its name (but not its
4157 directory) while it wasn't looking.
4159 * buildbot/process/builder.py (Builder.attached): always return a
4160 Deferred, even if the builder was already attached
4161 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4163 2005-04-25 Brian Warner <warner@lothar.com>
4165 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4166 category-related exception when announcing a build has finished
4168 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4169 reference no-longer-existent changemaster.sources
4170 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4172 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4175 2005-04-25 Brian Warner <warner@lothar.com>
4177 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4179 * debian/changelog: update for 0.6.3
4181 2005-04-25 Brian Warner <warner@lothar.com>
4183 * MANIFEST.in: make sure debug.glade is in the tarball
4185 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4187 * NEWS: update for the imminent 0.6.3 release
4189 * buildbot/status/html.py (HtmlResource.content): make the
4190 stylesheet <link> always point at "buildbot.css".
4191 (StatusResource.getChild): map "buildbot.css" to a static.File
4192 containing whatever css= argument was provided to Waterfall()
4193 (Waterfall): provide the "classic" css as the default.
4194 * docs/waterfall.classic.css: move default CSS from here ..
4195 * buildbot/status/classic.css: .. to here
4197 * MANIFEST.in: make sure classic.css is included in the tarball
4198 * setup.py: and that it is installed too, under buildbot/status/
4200 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4201 the module level, because buildbot.tap files from 0.6.2 don't have
4202 it in their attribute dictionary.
4204 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4205 really exists at startup, might save some confusion somewhere.
4207 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4209 * docs/waterfall.classic.css:
4210 add a stylesheet that's almost the same as the "classic"
4213 * buildbot/status/builder.py:
4214 add EXCEPTION as a result - this is a problem for the bot
4215 maintainer, not a build problem for the changers
4216 * buildbot/process/step.py:
4217 use EXCEPTION instead of FAILURE for exceptions
4218 * buildbot/status/html.py:
4219 add build_get_class to get a class out of a build/buildstep
4220 finish naming the classes
4221 split out sourceNames to changeNames and builderNames so we
4222 can style them separately
4223 * docs/config.xhtml:
4224 finish documenting classes as they are right now
4226 * buildbot/status/html.py:
4227 name the classes as we agreed on IRC
4228 * docs/config.xhtml:
4231 * buildbot/status/html.py:
4232 same for cssclass->class_
4234 * buildbot/status/html.py:
4235 as decided on IRC, use class_ for the "class" attribute to not
4236 conflict with the class keyword, and clean up the messy **{} stuff.
4238 * buildbot/status/mail.py:
4239 put back "builders" argument, and fix docstring, because the
4240 code *ignores* builders listed in this argument
4242 * buildbot/process/builder.py:
4243 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4245 * docs/config.xhtml:
4246 describe the category argument for builders
4248 * buildbot/status/builder.py:
4249 Fix a silly bug due to merging
4251 * buildbot/process/builder.py:
4252 remove category from the process Builder ...
4253 * buildbot/status/builder.py:
4254 ... and add it to BuilderStatus instead.
4255 Set category on unpickled builder statuses, they might not have it.
4256 * buildbot/master.py:
4257 include category when doing builderAdded
4258 * buildbot/status/mail.py:
4259 return None instead of self for builders we are not interested in.
4260 * buildbot/test/test_run.py:
4261 fix a bug due to only doing deferredResult on "dummy" waiting
4262 * buildbot/test/test_status.py:
4263 add checks for the Mail IStatusReceiver returning None or self
4265 * buildbot/status/html.py:
4266 fix testsuite by prefixing page title with BuildBot
4268 * buildbot/status/builder.py:
4269 have .category in builder status ...
4270 * buildbot/process/builder.py:
4271 ... and set it from Builder
4272 * buildbot/status/html.py:
4273 make .css a class variable
4274 * buildbot/test/test_status.py:
4275 write more tests to cover our categories stuff ...
4276 * buildbot/status/mail.py:
4277 ... and fix the bug that this uncovered
4279 * buildbot/changes/mail.py:
4280 * buildbot/changes/pb.py:
4281 * buildbot/master.py:
4282 * buildbot/process/base.py:
4283 * buildbot/process/factory.py:
4284 * buildbot/process/interlock.py:
4285 * buildbot/process/step.py:
4286 * buildbot/process/step_twisted.py:
4287 * buildbot/slave/commands.py:
4288 * buildbot/status/builder.py:
4289 * buildbot/status/client.py:
4290 * buildbot/status/html.py:
4291 * buildbot/status/mail.py:
4292 * buildbot/status/progress.py:
4293 * buildbot/test/test_changes.py:
4294 * buildbot/test/test_config.py:
4295 * buildbot/test/test_control.py:
4296 * buildbot/test/test_interlock.py:
4297 * buildbot/test/test_maildir.py:
4298 * buildbot/test/test_mailparse.py:
4299 * buildbot/test/test_run.py:
4300 * buildbot/test/test_slavecommand.py:
4301 * buildbot/test/test_status.py:
4302 * buildbot/test/test_steps.py:
4303 * buildbot/test/test_twisted.py:
4304 * buildbot/test/test_util.py:
4305 * buildbot/test/test_vc.py:
4306 * buildbot/test/test_web.py:
4308 add test-case-name at the top of a whole set of files
4310 * buildbot/status/builder.py:
4311 keep order of addition when getting builder names
4312 * buildbot/status/words.py:
4313 * buildbot/test/test_run.py:
4314 add test for getBuilderNames
4316 * buildbot/process/base.py:
4317 * buildbot/process/step.py:
4318 * buildbot/status/builder.py:
4319 * buildbot/status/html.py:
4320 make buildbot css-able
4321 replace the color code for purple with purple, don't understand
4322 why it wasn't purple to start with
4324 * buildbot/status/words.py:
4325 ok, so it doesn't look like BuilderStatus.remote is still valid.
4326 Use what waterfall uses instead.
4328 * buildbot/interfaces.py:
4329 * buildbot/status/builder.py:
4330 * buildbot/status/html.py:
4331 * buildbot/status/mail.py:
4332 * buildbot/status/words.py:
4333 * buildbot/test/test_run.py:
4334 use categories everywhere and make it be a list. More sensible
4335 for the future. Also make words actually respect this in
4338 * buildbot/interfaces.py:
4339 add category argument to getBuilderNames
4340 * buildbot/process/builder.py:
4341 * buildbot/status/builder.py:
4342 * buildbot/status/html.py:
4343 * buildbot/status/mail.py:
4344 * buildbot/status/words.py:
4345 * buildbot/test/test_run.py:
4346 move from specifying builders by name to specifying the category
4348 * buildbot/status/html.py:
4349 * buildbot/status/words.py:
4350 add "builders=" to __init__ of status clients so they can
4351 limit themselves to the given list of builders to report on
4353 * buildbot/status/html.py: set the title to the product name
4355 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4357 * buildbot/interfaces.py:
4358 * buildbot/status/builder.py:
4359 more documentation. Hm, not sure if ChangeLog entries make sense
4362 2005-04-23 Brian Warner <warner@lothar.com>
4364 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4366 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4368 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4369 the sub-commands that log buildmaster status to stdout and to a
4370 GUI window, respectively.
4372 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4373 functionality is working again, but all the step-status and ETA
4374 stuff is missing. Commented out a lot of code pending more
4377 * buildbot/status/client.py: make sure that IRemote(None) is None
4379 * buildbot/changes/changes.py: import defer, oops
4380 (ChangeMaster): remove the .sources list, rely upon the fact that
4381 MultiServices can be treated as sequences of their children. This
4382 cleans up the add/remove ChangeSource routines a lot, as we keep
4383 exactly one list of the current sources instead of three.
4385 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4386 up an empty ChangeMaster at init time.
4387 (BuildMaster.loadChanges): if there are changes to be had from
4388 disk, replace self.change_svc with the new ones. If not, keep
4389 using the empty ChangeMaster set up in __init__.
4390 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4391 instead of a separate list, makes the code a bit cleaner.
4392 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4393 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4394 Extend the test to make sure we can get rid of the sources when
4397 2005-04-22 Brian Warner <warner@lothar.com>
4399 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4400 and info/host files when making the slave directory
4402 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4403 whendone= argument, just return the Deferred and let the caller do
4404 what they want with it.
4405 (Disconnect.testBuild1): wait for shutdownSlave
4406 (Basedir.testChangeBuilddir): new test to make sure changes to the
4407 builddir actually get propagated to the slave
4409 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4410 explicit method, rather than passing the builddir in __init__ .
4411 Make sure to update self.basedir too, this was broken before.
4412 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4413 builders and for ones that have just had their builddir changed.
4414 (BotFactory): add a class-level .perspective attribute, so
4415 BuildSlave.waitUntilDisconnected won't get upset when the
4416 connection hasn't yet been established
4417 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4418 tests can reach through it to inspect the SlaveBuilders
4420 * buildbot/process/base.py (Build.buildException): explain the
4421 log.err with a log.msg
4422 * buildbot/process/builder.py (Builder.startBuild): same
4423 (Builder._startBuildFailed): improve error message
4425 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4426 occurred because we lost the brand-new connection, retry instead
4427 of giving up. If not, it's probably an authorization failure, and
4428 it makes sense to stop trying. Make sure we log.msg the reason
4429 that we're log.err'ing the failure, otherwise test failures are
4430 really hard to figure out.
4432 * buildbot/master.py: change loadConfig() to return a Deferred
4433 that doesn't fire until the change has been fully implemented.
4434 This means any connected slaves have been updated with the new
4435 builddir. This change makes it easier to test the code which
4436 actually implements this builddir-updating.
4437 (BotPerspective.addBuilder): return Deferred
4438 (BotPerspective.removeBuilder): same
4439 (BotPerspective.attached): same
4440 (BotPerspective._attached): same. finish with remote_print before
4441 starting the getSlaveInfo, instead of doing them in parallel
4442 (BotPerspective.list_done): same
4443 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4444 actually calling slave.disconnect()
4445 (BotMaster.addBuilder): same
4446 (BotMaster.removeBuilder): same
4447 (BuildMaster.loadConfig): same
4448 (BuildMaster.loadConfig_Slaves): same
4449 (BuildMaster.loadConfig_Sources): same
4450 (BuildMaster.loadConfig_Builders): same
4451 (BuildMaster.loadConfig_status): same
4453 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4454 a Deferred that fires when the source is finally removed
4456 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4457 the previous tree on win32, where we have to do it synchronously,
4458 make sure we return a Deferred anyway.
4459 (SourceBase.doCopy): same
4461 * buildbot/scripts/runner.py (statusgui): use the text client for
4462 now, while I rewrite the Gtk one
4463 * buildbot/clients/base.py: strip out old code, leaving just the
4464 basic print-message-on-event functionality. I also remove the
4465 ReconnectingPBClientFactory, but it does at least quit when it
4466 loses the connection instead of going silent
4468 2005-04-21 Brian Warner <warner@lothar.com>
4470 * Makefile: minor tweaks
4472 * NEWS: point out deprecation warnings, new features for
4475 * buildbot/master.py (BuildMaster.loadConfig): emit
4476 DeprecationWarnings for Builders defined with tuples. Rearrange
4477 code to facility removal of deprecated configuration keys in the
4480 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4481 'buildbot' command to put a little Makefile in the target that
4482 helps you re-create the buildbot.tap file, start or stop the
4483 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4484 all the files 0600, since they contain passwords.
4485 (start): if there is a Makefile, and /usr/bin/make exists, use
4486 'make start' in preference to a raw twistd command. This lets
4487 slave admins put things like PYTHONPATH variables in their
4488 Makefiles and have them still work when the slave is started with
4489 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4490 be nice to first try the 'make' command and only fall back to
4491 twistd if it fails. TODO: the Makefile's "start" command does not
4492 add the --reactor=win32 argument when running under windows.
4493 (Options.debugclient, Options.statusgui): add sub-commands to launch
4494 the debug client (formerly in contrib/debugclient.py) and the
4495 Gtk status application (currently broken)
4496 * buildbot/clients/debug.py: move from contrib/debugclient.py
4497 * buildbot/clients/debug.glade: same
4499 * buildbot/test/test_trial.py: remove it. This requires some
4500 functionality out of Twisted that isn't there yet, and until then
4501 having it around just confuses things.
4503 * buildbot/test/test_slavecommand.py (Shell): test both with and
4504 without PTYs, and make sure that command output is properly
4505 interleaved in the with-PTY case. I think the without-PTY test
4506 should pass on windows, where we never use PTYs anyway.
4508 2005-04-20 Brian Warner <warner@lothar.com>
4510 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4512 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4514 * NEWS: start creating entries for the next release
4516 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4518 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4519 (WebTest.test_webPathname): same
4520 (WebTest.test_webPathname_port): same
4521 (WebTest.test_waterfall): use the default favicon rather than
4522 rooting around the filesystem for it. Open the expected-icon file
4523 in binary mode, to make win32 tests happier (thanks to Nick Trout
4525 * buildbot/status/html.py (buildbot_icon): win32 portability
4527 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4528 win32-compatibility fixes from Nick Trout, the "file not found" message
4529 is different under windows
4530 (FakeSlaveBuilder.__init__): clean up setup a bit
4531 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4533 2005-04-19 Brian Warner <warner@lothar.com>
4535 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4536 skip-if-repositories-are-unavailable test to not kill the trial
4537 that comes with Twisted-1.3.0
4539 * setup.py: install buildbot.png icon file when installing code
4541 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4542 environment used by the command, at least on the child side.
4544 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4545 this method needs to be added and implemented because it gets
4546 called under heavy load. I don't quite understand the
4547 producer/consumer API enough to write it.
4548 (StatusResource.getChild): add a resource for /favicon.ico
4549 (Waterfall.__init__): add favicon= argument
4550 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4551 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4552 (WebTest.test_webPathname): same
4553 (WebTest.test_webPathname_port): same
4554 * docs/config.xhtml: mention favicon=
4555 * buildbot/buildbot.png: add a default icon, dorky as it is
4557 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4559 * buildbot/master.py:
4560 * buildbot/process/base.py:
4561 * buildbot/process/builder.py:
4562 * buildbot/process/interlock.py:
4563 * buildbot/status/builder.py:
4564 * buildbot/status/html.py:
4565 * buildbot/status/mail.py:
4566 * buildbot/status/words.py:
4567 new documentation while digging through the code
4569 2005-04-17 Brian Warner <warner@lothar.com>
4571 * general: try to fix file modes on all .py files: a+r, a-x,
4572 but let buildbot/clients/*.py be +x since they're tools
4574 * docs/epyrun (addMod): when an import fails, say why
4576 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4578 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4580 * buildbot/process/base.py:
4581 * buildbot/process/builder.py:
4582 * buildbot/status/builder.py:
4583 new documentation while digging through the code
4585 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4587 * buildbot/changes/changes.py:
4588 * buildbot/changes/p4poller.py:
4589 * buildbot/interfaces.py:
4590 * buildbot/process/base.py:
4591 * buildbot/process/builder.py:
4592 * buildbot/process/step.py:
4593 * buildbot/process/step_twisted.py:
4594 * buildbot/slave/bot.py:
4595 * buildbot/slave/commands.py:
4596 * buildbot/status/builder.py:
4597 fix all docstrings to make epydoc happy. In the process of fixing
4598 some, I also moved pieces of docs, and removed some deprecated
4601 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4603 * buildbot/process/builder.py:
4604 * buildbot/process/interlock.py:
4605 * buildbot/process/process_twisted.py:
4606 * buildbot/process/step.py:
4607 BuildProcess -> Build, as it looks like that's what happened
4608 * buildbot/process/base.py:
4609 * buildbot/process/factory.py:
4612 2005-04-17 Brian Warner <warner@lothar.com>
4614 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4615 update compile command to accomodate the Twisted split.. now
4616 instead of './setup.py build_ext -i', you do './setup.py all
4617 build_ext -i', to run build_ext over all sub-projects.
4618 (FullTwistedBuildFactory): same
4619 (TwistedReactorsBuildFactory): same
4621 * buildbot/status/html.py (TextLog.finished): null out self.req
4622 when we're done, otherwise the reference cycle of TextLog to .req
4623 to .notifications to a Deferred to TextLog.stop keeps them from
4624 being collected, and consumes a huge (610MB on pyramid at last
4625 check) amount of memory.
4627 2005-04-11 Brian Warner <warner@lothar.com>
4629 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4630 normalize the VC-repository location.. makes SVN happier with
4631 certain test environments.
4633 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4634 RemoteShellCommand gets its own .env dictionary, so that code in
4635 start() doesn't mutate the original. I think this should fix the
4636 step_twisted.Trial problem where multiple identical components
4637 kept getting added to PYTHONPATH= over and over again.
4639 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4640 adding epydoc-format docstrings to many classes. Thanks to Thomas
4641 Vander Stichele for the patches.
4642 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4643 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4644 * buildbot/slave/bot.py, commands.py, registry.py: same
4646 2005-04-05 Brian Warner <warner@lothar.com>
4648 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4649 preserve timestamps, helps incremental builds of large trees.
4650 Patch from Rene Rivera.
4652 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4653 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4656 2005-04-03 Brian Warner <warner@lothar.com>
4658 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4659 with one dict, apparently exec has some scoping bugs when used
4660 with both global/local dicts. Thanks to Nathaniel Smith for the
4663 2005-04-02 Brian Warner <warner@lothar.com>
4665 * buildbot/process/step_twisted.py (countFailedTests): the new
4666 trial in Twisted-2.0 emits a slightly different status line than
4667 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4668 mistakenly think the test count is unparseable.
4669 (Trial.start): note that for some reason each build causes another
4670 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4671 be fixed but I'm not sure quite where the problem is.
4673 2005-04-01 Brian Warner <warner@lothar.com>
4675 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4676 deferredResult to avoid hangs/warnings under twisted-2.0
4677 (RunMixin.tearDown): same
4678 (RunMixin.shutdownSlave): same
4679 (Disconnect.testIdle1): same
4680 (Disconnect.testBuild2): same: wait one second after the build
4681 finishes for test to really be done.. this should be cleaned up to
4682 avoid wasting that second. Builder.detach uses a callLater(0),
4683 either that should be done in-line (something else needed that
4684 behavior), or it should return a Deferred that fires when the
4685 builder is really offline.
4686 (Disconnect.testBuild3): same
4687 (Disconnect.testDisappear): same
4689 * buildbot/test/test_web.py: rearrange server-setup and teardown
4690 code to remove unclean-reactor warnings from twisted-2.0
4692 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4693 so the tests don't hang under twisted-2.0
4695 2005-03-31 Brian Warner <warner@lothar.com>
4697 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4698 caused a warning each time the master changed our set of builders
4700 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4701 w32, don't unlink the file unless it already exists. Thanks to
4702 Baptiste Lepilleur for the catch.
4703 (BuilderStatus.saveYourself): same
4705 2005-02-01 Brian Warner <warner@lothar.com>
4707 * buildbot/status/html.py (TextLog.getChild): use a /text child
4708 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4709 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4710 logfile as text/plain (no markup, no headers). This replaces the
4711 previous scheme (which used an ?text=1 argument), and gets us back
4712 to a relative link (which works better when the buildbot lives
4713 behind another web server, such as Apache configured as a reverse
4714 proxy). Thanks to Gerald Combs for spotting the problem.
4716 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4719 2004-12-13 Brian Warner <warner@lothar.com>
4721 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4723 * debian/changelog: update for 0.6.2
4724 * NEWS: finalize for 0.6.2
4726 2004-12-11 Brian Warner <warner@lothar.com>
4728 * NEWS: bring it up to date
4730 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4731 detection code. Require some sign of life from the buildmaster
4732 every BotFactory.keepaliveInterval seconds. Provoke this
4733 indication at BotFactory.keepaliveTimeout seconds before the
4734 deadline by sending a keepalive request. We don't actually care if
4735 that request is answered in a timely fashion, what we care about
4736 is that .activity() is called before the deadline. .activity() is
4737 triggered by any PB message from the master (including an ack to
4738 one of the slave's status-update messages). With this new scheme,
4739 large status messages over slow pipes are OK, as long as any given
4740 message can be sent (and thus acked) within .keepaliveTimeout
4741 seconds (which defaults to 30).
4742 (SlaveBuilder.remote_startCommand): record activity
4743 (SlaveBuilder.ackUpdate): same
4744 (SlaveBuilder.ackComplete): same
4745 (BotFactory.gotPerspective): same
4746 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4748 2004-12-09 Brian Warner <warner@lothar.com>
4750 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4753 * buildbot/process/step_twisted.py (Trial._commandComplete):
4754 update self.cmd when we start the 'cat test.log' transfer. Without
4755 this, we cannot interrupt the correct RemoteCommand when we lose
4758 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4759 trying to tell the slave to stop the command if we're already
4760 inactive, or if we no longer have a .remote
4762 * buildbot/process/builder.py (Builder._detached): don't let an
4763 exception in currentBuild.stopBuild() prevent the builder from
4764 being marked offline
4766 2004-12-07 Brian Warner <warner@lothar.com>
4768 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4769 KeyError that happens when you ask for a non-existent Builder, and
4770 translate it into a UsageError.
4772 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4773 losing the slave in the middle of a remote step is handled too
4775 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4776 be a Failure, so be sure to stringify it before using it as the
4777 contents of the 'interrupt' logfile
4778 (RemoteCommand.interrupt): use stringified 'why' in
4779 remote_interruptCommand too, just in case
4781 2004-12-06 Brian Warner <warner@lothar.com>
4783 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4784 instead of 'tla update', which is more efficient in case we've
4785 missed a couple of patches since the last update.
4787 * debian/changelog: update for previous (0.6.1) release. Obviously
4788 this needs to be handled better.
4790 2004-12-05 Brian Warner <warner@lothar.com>
4792 * NEWS: update for stuff since last release
4794 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4795 match the maybeDeferred change in Dispatcher.requestAvatar
4796 * buildbot/changes/pb.py (ChangePerspective.attached): same
4797 * buildbot/status/client.py (StatusClientPerspective.attached): same
4798 * buildbot/process/builder.py (Builder._attached3): same
4799 * buildbot/pbutil.py (NewCredPerspective.attached): same
4801 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4802 the date to the top-most box, if it is not the same as today's
4805 * docs/slave.xhtml: provide a buildslave setup checklist
4807 * docs/source.xhtml (Arch): correct terminology
4809 2004-12-04 Brian Warner <warner@lothar.com>
4811 * buildbot/test/test_slavecommand.py: use sys.executable instead
4812 of hard-coding 'python' for child commands, might help portability
4814 * docs/examples/twisted_master.cfg: update to current usage
4816 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4817 'stop build' command to the IRC bot
4819 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4820 message that broke PBChangeSource
4822 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4823 (SlaveBuilder): make some attributes class-level, remove the old
4824 "update queue" which existed to support resuming a build after the
4825 master connection was lost. Try to reimplement that feature later.
4826 (SlaveBuilder.stopCommand): clear self.command when the
4827 SlaveCommand finishes, so that we don't try to kill a leftover one
4829 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4832 * buildbot/slave/commands.py (SourceBase): set self.command for
4833 all VC commands, so they can be interrupted.
4835 2004-12-03 Brian Warner <warner@lothar.com>
4837 * buildbot/master.py: clean up slave-handling code, to handle
4838 slave-disconnect and multiple-connect better
4839 (BotPerspective): make these long-lasting, exactly one per bot
4840 listed in the config file.
4841 (BotPerspective.attached): if a slave connects while an existing
4842 one appears to still be connected, disconnect the old one first.
4843 (BotPerspective.disconnect): new method to forcibly disconnect a
4844 buildslave. Use some hacks to empty the transmit buffer quickly to
4845 avoid the long (20-min?) TCP timeout that could occur if the old
4846 slave has dropped off the net.
4847 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4848 own their own SlaveStatus objects. Remove .attached/.detached, add
4849 .addSlave/.removeSlave, treat slaves like Builders (config file
4850 parsing sends deltas to the BotMaster). Inform the slave
4851 instances, i.e. the BotPerspective, about addBuilder and
4853 (BotMaster.getPerspective): turns into a single dict lookup
4854 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4855 which gives BotPerspective.attached a chance to disconnect the old
4857 (BuildMaster.loadConfig): add code (disabled) to validate that all
4858 builders use known slaves (listed in c['bots']). The check won't
4859 work with tuple-specified builders, which are deprecated but not
4860 yet invalid, so the check is disabled for now.
4861 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4862 routine, do the add/changed/removed dance with them like we do
4864 (BuildMaster.loadConfig_Sources): move source-config into a
4865 separate routine too
4867 * buildbot/status/builder.py (Status.getSlave): get the
4868 SlaveStatus object from the BotPerspective, not the BotMaster.
4870 * buildbot/test/test_run.py: bunch of new tests for losing the
4871 buildslave at various points in the build, handling a slave that
4872 connects multiple times, and making sure we can interrupt a
4875 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4876 something other than 'Bot' for the Bot object, to make certain
4877 test cases easier to write.
4878 (BuildSlave.waitUntilDisconnected): utility method for testing
4880 2004-11-30 Brian Warner <warner@lothar.com>
4882 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4884 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4885 argument, return a Deferred that always fires with True or False.
4886 I don't use an errback to indicate 'ping failed' so that callers
4887 are free to ignore the deferred without causing spurious errors in
4889 * buildbot/process/builder.py (BuilderControl.ping): implement it
4891 * buildbot/test/test_run.py (Status.testDisappear): test ping
4892 (Status.disappearSlave): fix it
4894 2004-11-30 Brian Warner <warner@lothar.com>
4896 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4897 (IBuilderControl): add .getBuild(num), only works for the current
4898 build, of course, although it might be interesting to offer
4899 something for builds in the .waiting or .interlocked state.
4901 * buildbot/process/base.py (Build): have .stopBuild just do the
4902 interrupt, then let the build die by itself.
4903 (BuildControl): add .stopBuild, and add a point-event named
4904 'interrupt' just after the build so status viewers can tell that
4906 (BuilderControl): add .getBuild
4908 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4909 stops when you kill it, good for testing
4910 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4911 contains the 'reason' text.
4913 * buildbot/status/html.py: Add Stop Build button, if the build can
4914 still be stopped. Send a Redirect (to the top page) one second
4915 later, hopefully long enough for the interrupt to have an effect.
4916 Move make_row() up to top-level to share it between Stop Build and
4919 * buildbot/slave/commands.py: only kill the child process once
4921 * buildbot/test/test_run.py: add testInterrupt
4923 2004-11-29 Brian Warner <warner@lothar.com>
4925 * buildbot/process/base.py: Refactor command interruption. The
4926 Build is now responsible for noticing that the slave has gone
4927 away: Build.lostRemote() interrupts the current step and makes
4928 sure that no further ones will be started.
4930 * buildbot/process/builder.py: When the initial remote_startBuild
4931 message fails, log it: this usually indicates that the slave has
4932 gone away, but we don't really start paying attention until they
4933 fail to respond to the first step's command.
4935 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4936 slave disconnect. Now sports a new interrupt() method. Error
4937 handling was simplified a lot by chaining deferreds, so
4938 remoteFailed/remoteComplete were merged into a single
4939 remoteComplete method (which can now get a Failure object).
4940 Likewise failed/finished were merged into just _finished.
4941 (BuildStep): Add interrupt(why) method, and if why is a
4942 ConnectionLost Failure then the step is failed with some useful
4945 * buildbot/slave/bot.py: stop the current command when the remote
4946 Step reference is lost, and when the slave is shut down.
4947 (Bot): make it a MultiService, so it can have children. Use
4948 stopService to tell when the slave is shutting down.
4949 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4950 remote_interruptCommand (which asks the current SlaveCommand to
4951 stop but allows it to keep emitting status messages), and
4952 stopCommand (which tells it to shut up and die).
4954 * buildbot/slave/commands.py: make commands interruptible
4955 (ShellCommand.kill): factor out os.kill logic
4956 (Command): factor out setup()
4957 (Command.sendStatus): don't send status if .running is false, this
4958 happens when the command has been halted.
4959 (Command.interrupt): new method, used to tell the command to die
4960 (SlaveShellCommand): implement .interrupt
4961 (DummyCommand): implement .interrupt
4962 (SourceBase, etc): factor out setup(), don't continue substeps if
4965 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4966 so they can be called after finishing
4968 * buildbot/test/test_run.py: new tests for disconnect behavior,
4969 refactor slave-shutdown routines, add different kinds of
4972 2004-11-27 Brian Warner <warner@lothar.com>
4974 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4975 method to express ETA time like "2m45s" instead of "165 seconds"
4977 2004-11-24 Brian Warner <warner@lothar.com>
4979 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4980 archive after the test completes, to avoid cluttering the user's
4981 'tla archives' listing with a bogus entry. Arch doesn't happen to
4982 provide any way to override the use of ~/.arch-params/, so there
4983 isn't a convenient way to avoid touching the setup of the user who
4985 (VC_HTTP.testArchHTTP): same
4987 2004-11-23 Brian Warner <warner@lothar.com>
4989 * buildbot/status/html.py (TextLog): split render() up into
4990 render_HEAD and render_GET. Use a Producer when sending log
4991 chunks, to reduce memory requirements and avoid sending huge
4992 non-Banana-able strings over web.distrib connections. Requires
4993 peeking under the covers of IStatusLog.
4994 (TextLog.resumeProducing): fix the "as text" link, handle client
4995 disconnects that occur while we're still sending old chunks.
4997 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4998 use defer.succeed, not the non-existent defer.success
4999 (LogFile.waitUntilFinished): same
5000 (LogFile.subscribe): don't add watchers to a finished logfile
5002 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5005 2004-11-23 Brian Warner <warner@lothar.com>
5007 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5009 2004-11-23 Brian Warner <warner@lothar.com>
5011 * NEWS: update for the 0.6.1 release
5012 * MANIFEST.in: add new files
5014 * README (INSTALLATION): explain how to enable the extra VC tests
5016 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5017 level to, so old pickled builds can be displayed ok
5019 2004-11-22 Brian Warner <warner@lothar.com>
5021 * NEWS: summarize updates since last release
5023 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5024 Yoz Grahame. Closes SF#1050138.
5026 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5029 * buildbot/process/step_twisted.py (Trial): update docs a bit
5031 * docs/factories.xhtml: fix Trial factory docs to match reality.
5034 * buildbot/process/factory.py (Trial.__init__): add args for
5035 randomly= and recurse=, making them available to instantiators
5036 instead of only to subclassers. Closes: SF#1049759.
5038 2004-11-15 Brian Warner <warner@lothar.com>
5040 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5041 try to teach the Quick factory to use multiple versions of python
5043 2004-11-12 Brian Warner <warner@lothar.com>
5045 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5046 safer w32-compatible approach, and only use it on windows
5047 (BuildStatus.saveYourself): same
5049 2004-11-11 Brian Warner <warner@lothar.com>
5051 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5052 it: one string merge per chunk. There are now separate .entries
5053 and .runEntries lists: when enumerating over all chunks, make sure
5055 * buildbot/test/test_status.py (Log): more tests
5057 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5058 chunks together, up to 10kb per chunk. This ought to cut down on
5059 the CPU-burning overhead of large log files. Thanks to Alexander
5060 Staubo for spotting the problem.
5061 * buildbot/test/test_status.py (Log): tests for same
5063 2004-11-10 Brian Warner <warner@lothar.com>
5065 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5066 header to outbound mail
5067 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5069 2004-11-08 Brian Warner <warner@lothar.com>
5071 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5072 can't do os.rename() onto an existing file, so catch the exception
5073 and unlink the target file first. This introduces a slight window
5074 where the existing file could be lost, but the main failure case
5075 (disk full) should still be handled safely.
5076 (BuildStatus.saveYourself): same
5078 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5079 separator character instead of os.sep, because the filenames being
5080 split here are coming from the VC system, which can have a
5081 different pathname convention than the local host. This should
5082 help a buildmaster running on windows that uses a CVS repository
5083 which runs under unix.
5084 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5086 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5087 when there are no test failures to be parsed
5089 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5090 instead of the unix-specific os.system("cp"), thanks to Elliot
5091 Murphy for this and the other buildbot-vs-windows catches.
5092 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5094 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5095 echo the command as it is run
5097 * setup.py: install sample.mk too, not just sample.cfg
5098 (scripts): install contrib/windows/buildbot.bat on windows
5100 2004-11-07 Brian Warner <warner@lothar.com>
5102 * buildbot/process/builder.py (Builder._detached): clear the
5103 self.currentBuild reference, otherwise the next build will be
5104 skipped because we think the Builder is already in use.
5106 * docs/examples/twisted_master.cfg: update to match current usage
5107 on the Twisted buildbot
5109 2004-10-29 Brian Warner <warner@lothar.com>
5111 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5113 2004-10-28 Brian Warner <warner@lothar.com>
5115 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5116 have separate doVCUpdate/doVCFull methods. Catch an update failure
5117 and respond by clobbering the source directory and re-trying. This
5118 will handle local changes (like replacing a file with a directory)
5119 that will cause CVS and SVN updates to fail.
5120 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5122 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5125 2004-10-19 Brian Warner <warner@lothar.com>
5127 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5129 * buildbot/status/html.py (StatusResourceTestResults): display any
5130 TestResults that the Build might have
5131 (StatusResourceTestResult): and the logs for each TestResult
5132 (StatusResourceBuild): add link from the per-build page
5134 2004-10-15 Brian Warner <warner@lothar.com>
5136 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5137 the 'problems' portion of stdout, add TestResults to our build
5138 * buildbot/test/test_twisted.py (Parse.testParse): test it
5140 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5141 to retrieve a dict of accumulated test results
5142 (ITestResult): define what a single test result can do
5143 * buildbot/status/builder.py (TestResult): implement ITestResult
5144 (BuildStatus.getTestResults): retrieve dict of TestResults
5145 (BuildStatus.addTestResult): add TestResults
5146 * buildbot/test/test_status.py (Results.testAddResults): test it
5148 2004-10-14 Brian Warner <warner@lothar.com>
5150 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5151 instead of os.system("rm -rf") for win32 portability
5153 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5154 SignalMixin instead of starting/stopping the reactor, which is
5155 likely to cause problems with other tests
5157 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5158 self.copyComplete() call. Yoz Grahame makes the catch.
5160 * contrib/windows/buildbot.bat: helper script to deal with path
5161 issues. Thanks to Yoz Grahame.
5163 * buildbot/master.py (BuildMaster.startService): don't register a
5164 SIGHUP handler if the signal module has no SIGHUP attribute.
5165 Apparently win32 does this.
5167 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5169 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5170 test if the reactor can't offer UNIX sockets
5172 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5173 error introduced in the last commit. We really need that
5176 2004-10-12 Brian Warner <warner@lothar.com>
5178 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5179 when describing a maildir source. Thanks to Stephen Davis.
5181 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5184 * buildbot/scripts/runner.py (createMaster): install Makefile too
5185 (start): add --no_save to 'start' command
5186 * buildbot/scripts/sample.mk: simple convenience Makefile with
5187 start/stop/reload targets
5189 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5192 2004-09-30 Brian Warner <warner@lothar.com>
5194 * setup.py: Releasing buildbot-0.6.0
5196 2004-09-30 Brian Warner <warner@lothar.com>
5198 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5199 test_trial.py from the source tarball until support is complete.
5201 * NEWS: update for 0.6.0 release
5202 * buildbot/__init__.py (version): same
5205 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5206 'source' command to tell users where to get the Buildbot source
5208 * docs/examples/*.cfg: update to modern standards
5210 * NEWS: update for release
5212 * buildbot/scripts/runner.py (createMaster): remove the
5213 -shutdown.tap stuff now that it isn't necessary
5215 (start): launch buildbot.tap, not buildbot-shutdown.tap
5218 * buildbot/status/mail.py (Domain): shorten class name
5219 (MailNotifier): if lookup= is a string, pass it to Domain()
5220 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5221 (Mail.testBuild2): test the string-to-Domain shortcut
5222 (Mail.testMail): fix test
5225 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5228 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5229 more attributes on load
5230 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5231 to accomodate the whole waterfall page at once, and the thrashing
5232 results in a lot of unnecessary loads
5233 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5234 (BuilderStatus.saveYourself): same
5235 (BuilderStatus.eventGenerator): stop generating on the first missing
5236 build. We assume that saved builds are deleted oldest-first.
5237 (BuildStepStatus.__getstate__): .progress might not exist
5239 * buildbot/changes/changes.py (ChangeMaster): make it
5240 serializable, in $masterdir/changes.pck
5241 (ChangeMaster.stopService): save on shutdown
5242 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5243 * buildbot/test/test_config.py: load Changes before config file
5246 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5247 "Oh my god, you killed the command" header on a separate line
5249 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5250 skip over corrupted build pickles
5251 (BuilderStatus.getFullBuildByNumber): same
5252 (BuilderStatus.eventGenerator): skip over unavailable builds
5253 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5254 do an atomic rename. This prevents a corrupted pickle when some
5255 internal serialization error occurs.
5256 (BuilderStatus.saveYourself): same
5258 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5259 the timeout for shell commands, it got lost somehow
5261 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5262 run out of build steps, return the rest of the builder events
5264 * buildbot/interfaces.py (IBuilderControl.ping): add method
5266 * buildbot/process/builder.py (BuilderControl.ping): move
5267 slave-ping to BuilderControl, and fix the failure case in the
5268 process (Event.finish() is the verb, Event.finished is the noun).
5270 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5271 through the BuilderControl instead of the BuilderStatus
5272 (EventBox): add adapter for builder.Event, allowing builder events to
5273 be displayed in the waterfall display
5275 * buildbot/master.py (BotMaster.stopService): add a 'master
5276 shutdown' event to the builder's log
5277 (BuildMaster.startService): and a 'master started' on startup
5279 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5280 builder events into the BuildStep event stream
5281 (Status.builderAdded): add a 'builder created' event
5284 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5285 command to announce the completion of a running build
5286 (IrcStatusBot.command_FORCE): announce when the build finishes
5288 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5289 don't evict unfinished builds from the cache: they must stay in
5290 the full-cache until their logfiles have stopped changing. Make
5291 sure the eviction loop terminates if an unfinished build was hit.
5292 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5293 This lets exceptions be dumped in an email status message. Really
5294 we need LogFiles which contain both text and HTML, instead of two
5296 (BuildStatus.__getstate__): handle self.finished=False
5297 (Status.builderAdded): if the pickle is corrupted, abandon the
5298 history and create a new BuilderStatus object.
5300 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5301 self.progress attribute, helped one test which doesn't fully set
5302 up the Build object.
5304 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5305 IStatusLog methods into an Interface that is implemented by "stub"
5306 logs, for which all the actual text chunks are on disk (in the
5307 pickled Build instance). To show the log contents, you must first
5308 adapt the stub log to a full IStatusLog object.
5310 * buildbot/status/builder.py (LogFileStub): create separate stub
5311 log objects, which can be upgraded to a real one if necessary.
5312 (LogFile): make them persistable, and let them stubify themselves
5314 (BuildStepStatus): same
5316 (BuildStatus.saveYourself): save the whole build out to disk
5317 (BuilderStatus): make it persistable
5318 (BuilderStatus.saveYourself): save the builder to disk
5319 (BuilderStatus.addFullBuildToCache): implement two caches which
5320 hold Build objects: a small one which holds full Builds, and a
5321 larger one which holds "stubbed" Builds (ones with their LogFiles
5322 turned into LogFileStubs). This reduces memory usage by the
5323 buildmaster by not keeping more than a few (default is 2) whole
5324 build logs in RAM all the time.
5325 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5327 (BuilderStatus.eventGenerator): rewrite since .builds went away
5328 (BuilderStatus.buildStarted): remove the .builds array. Add the
5329 build to the "full" cache when it starts.
5330 (BuilderStatus._buildFinished): save the build to disk when it
5332 (Status): give it a basedir (same as the BuildMaster's basedir)
5333 where the builder pickles can be saved
5334 (Status.builderAdded): create the BuilderStatus ourselves, by
5335 loading a pickle from disk (or creating a new instance if there
5336 was none on disk). Return the BuilderStatus so the master can glue
5337 it into the new Builder object.
5339 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5340 all BuilderStatuses to save themselves out to disk. This is in
5341 lieu of saving anything important in the main Application pickle
5342 (the -shutdown.tap file).
5343 (BuildMaster.__init__): give Status() a basedir for its files
5344 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5345 to get the BuilderStatus, then give it to the Builder (instead of
5346 doing it the other way around). It's ok if the status announces
5347 the new Builder before it's really ready, as the outside world can
5348 only see the BuilderStatus object anyway (and it is ready before
5349 builderAdded returns). Use the builder's "builddir" (which
5350 normally specifies where the slave will run the builder) as the
5351 master's basedir (for saving serialized builds).
5353 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5354 coerce the logfile to IStatusLog before trying to get the text
5355 chunks out of it. This will pull the full (non-stubified) Build in
5356 from disk if necessary.
5357 (TextLog): fix the adapter registration
5359 * buildbot/test/test_control.py (Force.setUp): create the basedir
5360 * buildbot/test/test_web.py: same
5361 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5362 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5363 * buildbot/test/test_run.py (Run.testMaster): same
5364 (Status.setUp): same
5366 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5368 * buildbot/status/html.py (Waterfall.__init__): store actual
5369 allowForce flag passed in rather than using True for everyone;
5370 make sure setting it to False doesn't cause a NameError
5372 (StatusResourceBuilder.__init__) add the builder name to the page
5374 (StatusResourceBuilder.body) move HTML generation for a name/value
5375 row into a helper method (StatusResourceBuilder.make_row); only
5376 generate the "Force Build" form if allowForce was True and the
5377 slave is connected. Use class attributes in the generated HTML to
5378 spread a little CSS-joy.
5380 2004-09-28 Brian Warner <warner@lothar.com>
5382 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5383 warning-scanner to not ignore things like
5384 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5386 * buildbot/status/html.py (StatusResource.control): add some
5387 class-level values for .control in an attempt to make upgrading
5390 * buildbot/util.py (ComparableMixin): survive missing attributes,
5391 such as when a class is modified and we're comparing old instances
5394 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5395 failure handling, remove a redundant try/except block. Don't
5396 return the full traceback to the IRC channel.
5397 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5398 error messages. Get ETA properly.
5400 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5401 the reason, since (at least) IRC message will have <> in them.
5402 (StatusResourceBuilder.__init__): take an IBuilderControl
5403 (StatusResourceBuilder.force): use the IBuilderControl we get in
5404 the constructor instead of trying to make our own. Catch the
5405 new exceptions and ignore them for now (until we make an
5406 intermediate web page where we could show the error message)
5407 (StatusResource): create with an IControl, use it to give an
5408 IBuilderControl to all children
5409 (Waterfall): take an allowForce= option, pass an IControl object
5410 to StatusResource if it is True
5412 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5414 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5415 catch new exceptions and return string forms
5417 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5418 * buildbot/process/builder.py (Builder.forceBuild): raise them
5419 * buildbot/test/test_control.py (Force.testNoSlave): new test
5420 (Force.testBuilderInUse): same
5423 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5425 * buildbot/test/test_run.py: use IControl
5426 * buildbot/test/test_vc.py: same
5428 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5429 to use IControl. Still offline.
5430 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5432 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5433 who=None so periodic builds don't send out status mail
5434 (Builder.forceBuild): include reason in the log message
5435 (BuilderControl.forceBuild): rename 'name' to 'who'
5437 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5438 'who' parameter, but make it None by default so builds forced by
5439 slave admins don't cause status mail to be sent to anybody
5440 (BotMaster.forceBuild): same. this method is deprecated.
5441 (DebugPerspective.perspective_forceBuild): same, use IControl.
5442 (DebugPerspective.perspective_fakeChange): use IControl..
5443 (Dispatcher.requestAvatar): .. so don't set .changemaster
5445 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5446 parameter to avoid confusion with the name of the builder
5449 * buildbot/status/mail.py: refine comment about needing 2.3
5451 * buildbot/status/html.py: move all imports to the top
5453 * buildbot/test/test_control.py: test new interfaces
5454 * buildbot/test/test_run.py (Status): handle new interfaces
5455 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5457 * buildbot/process/base.py (BuildControl): implement IBuildControl
5458 and its lonely getStatus() method
5460 * buildbot/process/builder.py (BuilderControl): implement
5461 IBuilderControl, obtained by adapting the Builder instance
5462 (Builder.startBuild): return a BuilderControl instead of a
5463 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5464 accomplish the same thing.
5466 * buildbot/master.py: move all import statements to the top
5467 (Control): implement IControl, obtained by adapting the
5468 BuildMaster instance.
5470 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5471 IBuildControl. These are used to force builds. Eventually they
5472 will provide ways to reconfigure the Builders, pause or abandon a
5473 Build, and perhaps control the BuildMaster itself.
5475 2004-09-26 Brian Warner <warner@lothar.com>
5477 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5478 ends up comparing us against something without a .__class__
5480 2004-09-24 Brian Warner <warner@lothar.com>
5482 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5485 * Makefile: add 'deb-snapshot' target, to create a timestamped
5488 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5490 2004-09-23 Brian Warner <warner@lothar.com>
5492 * buildbot/__init__.py (version): move version string here
5493 * setup.py: get version string from buildbot.version
5494 * buildbot/status/html.py (WaterfallStatusResource.body): add
5495 buildbot version to the page footer
5496 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5499 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5500 slaves, let the second know where the first one is coming from
5501 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5502 see our exceptions. It would be nice if there were a way to just
5503 send them the exception type and value, not the full traceback.
5506 * buildbot/status/mail.py (MailNotifier): add a new argument
5507 sendToInterestedUsers=, which can be set to False to disable the
5508 usual send-to-blamelist behavior.
5509 (top): handle python-2.2 which has no email.MIMEMultipart
5510 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5511 (MailNotifier.disownServiceParent): unsubscribe on removal
5513 * buildbot/test/test_status.py (Mail.testBuild2): test it
5516 * buildbot/status/progress.py (Expectations.wavg): tolerate
5517 current=None, which happens when steps start failing badly
5518 * buildbot/test/test_status.py (Progress.testWavg): test for it
5520 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5521 doesn't understand args['revision'], emit a warning instead of
5522 bailing completely. Updating to -rHEAD is probably close enough.
5524 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5526 * buildbot/test/test_status.py: at least import bb.status.client
5527 even if we don't have any test coverage for it yet
5529 * contrib/svn_buildbot.py: don't require python2.3
5530 (main): wait, do require it (for sets.py), but explain how to
5531 make it work under python2.2
5533 2004-09-23 Brian Warner <warner@lothar.com>
5535 * contrib/svn_buildbot.py: include the revision number in the Change
5537 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5538 using util.now() because FreshCVS is a realtime service
5540 * buildbot/status/event.py: delete dead code
5541 * buildbot/process/step.py: don't import dead Event class
5542 * buildbot/process/step_twisted.py: same
5543 * buildbot/status/builder.py: same
5544 * buildbot/status/client.py: same
5546 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5548 * buildbot/changes/changes.py (Change): set .when from an __init__
5549 argument (which defaults to now()), rather than having
5550 ChangeMaster.addChange set it later.
5551 (ChangeMaster.addChange): same
5553 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5554 (parseSyncmail): same. Just use util.now() for now.
5555 (parseBonsaiMail): parse the timestamp field for when=
5557 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5558 instead of setting .when after the fact
5562 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5563 results when the target project uses retrial. Still under
5565 * buildbot/test/test_trial.py: same
5567 2004-09-21 Brian Warner <warner@lothar.com>
5569 * buildbot/status/mail.py (MailNotifier.__init__): include
5570 success/warnings/failure in the Subject line
5571 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5572 use step.logname for the addLogs=True attachment filenames
5573 * buildbot/test/test_status.py (Mail): test Subject lines
5574 (Mail.testLogs): test attachment filenames
5576 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5577 accept a 'who' argument from the debug tool
5578 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5579 * contrib/debug.glade: add text box to set 'who'
5581 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5582 .getBuilderName with .getBuilder().getName(), more flexible
5583 (IStatusLog.getName): logs have short names, but you can prefix
5584 them with log.getStep().getName() to make them more useful
5585 * buildbot/status/builder.py: same
5586 * buildbot/status/client.py: same
5587 * buildbot/status/html.py: same
5588 * buildbot/test/test_run.py (Status.testSlave): same
5589 * buildbot/process/step.py: tweak logfile names
5591 * buildbot/status/mail.py (MailNotifier): add lookup, change
5592 argument to extraRecipients. The notifier is now aimed at sending
5593 mail to the people involved in a particular build, with additional
5594 constant recipients as a secondary function.
5596 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5597 including slow-lookup and failing-lookup. Make sure the blamelist
5598 members are included.
5600 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5601 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5602 (IBuildStatus.getInterestedUsers): new method
5603 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5604 * buildbot/status/client.py (remote_getResponsibleUsers): same
5605 * buildbot/status/html.py (StatusResourceBuild.body): same
5606 * buildbot/test/test_run.py (Status.testSlave): same
5608 2004-09-20 Brian Warner <warner@lothar.com>
5610 * docs/users.xhtml: update concepts
5612 * Makefile: add a convenience makefile, for things like 'make
5613 test'. It is not included in the source tarball.
5615 2004-09-16 Brian Warner <warner@lothar.com>
5617 * NEWS: mention /usr/bin/buildbot, debian/*
5619 * debian/*: add preliminary debian packaging. Many thanks to
5620 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5621 it considerably since it left their hands, I am responsible for
5622 all breakage that's resulted.
5624 * bin/buildbot: create a top-level 'buildbot' command, to be
5625 installed in /usr/bin/buildbot . For now it's just a simple
5626 frontend to mktap/twistd/kill, but eventually it will be the entry
5627 point to the 'try' command and also a status client. It is also
5628 intended to support the upcoming debian-packaging init.d scripts.
5629 * buildbot/scripts/runner.py: the real work is done here
5630 * buildbot/scripts/__init__.py: need this too
5631 * buildbot/scripts/sample.cfg: this is installed in new
5632 buildmaster directories
5633 * setup.py: install new stuff
5635 2004-09-15 Brian Warner <warner@lothar.com>
5637 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5638 'file:' schema (the version shipped with OS-X was built without the
5640 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5641 updates the log-timestamp, to make sure it isn't still running after
5644 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5645 values to the config file.
5646 * docs/examples/hello.cfg: add examples
5647 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5648 * buildbot/status/builder.py (Status.getProjectURL): implement them
5649 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5650 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5651 * buildbot/status/html.py (WaterfallStatusResource): display them
5654 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5655 certain error cases don't suffer a secondary exception.
5656 (top): Skip tests if the corresponding VC tool is not installed.
5658 * buildbot/process/factory.py (Trial): introduce separate
5659 'buildpython' and 'trialpython' lists, since trialpython=[] is
5660 what you want to invoke /usr/bin/python, whereas ./setup.py is
5661 less likely to be executable. Add env= parameter to pass options
5662 to test cases (which is how I usually write tests, I don't know if
5663 anyone else does it this way).
5665 * buildbot/process/step_twisted.py (Trial): handle python=None.
5666 Require 'testpath' be a string, not a list. Fix tests= typo.
5667 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5669 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5670 way to deal with the possibility of removing the disconnect notify
5672 (CVS): add a 'login' parameter to give a password to 'cvs login',
5673 commonly used with pserver methods (where pw="" or pw="guest")
5675 * buildbot/slave/commands.py (SourceBase): move common args
5676 extraction and setup() to __init__, so everything is ready by the
5677 time setup() is called
5678 (CVS.start): call 'cvs login' if a password was supplied
5679 (ShellCommand): special-case PYTHONPATH: prepend the master's
5680 value to any existing slave-local value.
5682 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5683 don't have a remote, mark the builder as Offline. This whole
5684 function should probably go away and be replaced by individual
5686 (Builder.buildFinished): return the results to the build-finished
5687 deferred callback, helps with testing
5689 2004-09-14 Brian Warner <warner@lothar.com>
5691 * buildbot/test/test_vc.py: put all the repositories needed to run
5692 the complete tests into a single small (1.3MB) tarball, so I can
5693 make that tarball available on the buildbot web site. Test HTTP
5694 access (for Arch and Darcs) by spawning a temporary web server
5695 while the test runs.
5697 * docs/users.xhtml: new document, describe Buildbot's limited
5698 understanding of different human users
5700 * buildbot/test/test_vc.py: rearrange test cases a bit
5702 * buildbot/process/step_twisted.py (Trial): handle testpath=
5703 * buildbot/process/factory.py (Trial): update to use step.Trial
5705 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5707 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5708 the overall build text (which gives you 'failed 2 tests' rather
5710 (BuildStepStatus.text2): default to [], not None
5712 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5715 2004-09-12 Brian Warner <warner@lothar.com>
5717 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5718 log the whole exception if it's just an AttributeError (old slave)
5720 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5721 so (e.g.) sub-commands can be run in the right directory.
5722 (ShellCommand.start): accept an optional errorMessage= argument
5723 to make life easier for SVN.start
5724 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5726 (ShellCommand.start): move ['dir'] compatibility hack..
5727 (RemoteShellCommand.start): .. to here so everyone can use it
5729 * buildbot/process/step_twisted.py (Trial): use .workdir
5731 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5732 text displayed when debuild fails completely
5733 (Trial): snarf _trial_temp/test.log from the slave and display it
5735 2004-09-11 Brian Warner <warner@lothar.com>
5737 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5739 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5740 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5742 * buildbot/process/step.py (ShellCommand): call .createSummary
5743 before .evaluateCommand instead of the other way around. This
5744 makes it slightly easier to count warnings and then use that to
5745 set results=WARNINGS
5746 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5748 * buildbot/process/base.py (Build.buildFinished): update status
5749 before doing progress. It's embarrassing for the build to be stuck
5750 in the "building" state when an exceptions occurs elsewhere..
5752 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5753 python2.2 doesn't have 'sum'
5755 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5756 to prevent clients from accidentally sorting it
5758 * buildbot/master.py (Manhole): add username/password
5759 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5760 c['manholePort'], deprecate old usage
5761 * docs/config.xhtml: document c['manhole']
5762 * docs/examples/hello.cfg: show example of using a Manhole
5765 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5766 pretend the slave is up to date
5768 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5769 the module, overlaps with 'log', the local variable
5771 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5773 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5774 new method to let Steps find out the version of their
5775 corresponding SlaveCommand.
5776 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5777 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5778 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5780 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5781 (Arch.startVC): same
5782 (P4Sync.startVC): same
5784 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5785 Deferred so we can catch errors in remote_startCommand
5786 (RemoteShellCommand.start): same
5788 * docs/examples/twisted_master.cfg: update sample config file
5790 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5791 after connectionMade() is called, not before. Close stdin at that
5794 * buildbot/process/process_twisted.py: update to use Trial, clean
5795 up argument passing (move to argv arrays instead of string
5798 * buildbot/process/step_twisted.py (Trial): new step to replace
5799 RunUnitTests, usable by any trial-using project (not just
5800 Twisted). Arguments have changed, see the docstring for details.
5802 * buildbot/process/base.py (Build.startBuild): this now returns a
5803 Deferred. Exceptions that occur during setupBuild are now
5804 caught better and lead to fewer build_status weirdnesses, like
5805 finishing a build that was never started.
5806 (Build.buildFinished): fire the Deferred instead of calling
5807 builder.buildFinished directly. The callback argument is this
5808 Build, everything else can be extracted from it, including the
5809 new build.results attribute.
5810 * buildbot/process/builder.py (Builder.startBuild): same
5811 (Builder.buildFinished): same, extract results from build
5813 * buildbot/process/step.py (ShellCommands): remove dead code
5815 2004-09-08 Brian Warner <warner@lothar.com>
5817 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5818 doesn't try to use the leftover patched workdir
5819 (SourceStamp): test source-stamp computation for CVS and SVN
5821 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5822 patched workdir ('touch .buildbot-patched') so we don't try to
5824 (SourceBase.start): add ['revision'] for all Source steps
5825 (CVS): change args: use ['branch'] for -r, remove ['files']
5826 (CVS.buildVC): fix revision/branch stuff
5827 (SVN): add revision stuff
5829 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5830 kwargs (except 'workdir') to avoid silent spelling errors
5831 (ShellCommand.__init__): same
5832 (Source): new base class for CVS/SVN/etc. Factor out everything
5833 common, add revision computation (perform the checkout with a -D
5834 DATE or -r REVISION that gets exactly the sources described by the
5835 last Change), overridable with step.alwaysUseLatest. Add patch
5836 handling (build.getSourceStamp can trigger the use of a base
5837 revision and a patch).
5838 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5839 * docs/steps.xhtml: update docs
5840 * docs/source.xhtml: mention .checkoutDelay
5841 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5843 * buildbot/process/base.py (Build.setSourceStamp): add a
5844 .sourceStamp attribute to each Build. If set, this indicates that
5845 the build should be done with something other than the most
5846 recent source tree. This will be used to implement "try" builds.
5847 (Build.allChanges): new support method
5848 (Build.lastChangeTime): remove, functionality moved to Source steps
5849 (Build.setupBuild): copy the Step args before adding ['workdir'],
5850 to avoid modifying the BuildFactory (and thus triggering spurious
5854 * buildbot/status/html.py: rename s/commits/changes/
5855 (StatusResourceChanges): same
5856 (CommitBox.getBox): same, update URL
5857 (WaterfallStatusResource): same
5858 (StatusResource.getChild): same
5860 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5861 * contrib/debug.glade: add optional 'revision' to the fakeChange
5863 * buildbot/changes/changes.py (html_tmpl): display .revision
5864 (ChangeMaster.addChange): note .revision in log
5865 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5866 accept a ['revision'] attribute
5868 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5870 * buildbot/master.py (BotMaster.getPerspective): update the
5871 .connected flag in SlaveStatus when it connects
5872 (BotMaster.detach): and when it disconnects
5873 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5874 (BuildMaster.loadConfig_Builders): walk old list correctly
5876 * buildbot/test/test_config.py: fix prefix= usage
5878 2004-09-06 Brian Warner <warner@lothar.com>
5882 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5883 poll a P4 depot looking for recent changes. Thanks to Dave
5884 Peticolas for the contribution. Probably needs some testing after
5887 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5888 requires manual client setup for each buildslave. Rather
5889 experimental. Thanks again to Dave Peticolas.
5890 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5892 * buildbot/changes/changes.py (Change): add a .revision attribute,
5893 which will eventually be used to generate source-stamp values.
5895 * buildbot/process/step.py (RemoteCommand.start): use
5896 notifyOnDisconnect to notice when we lose the slave, then treat it
5897 like an exception. This allows LogFiles to be closed and the build
5898 to be wrapped up normally. Be sure to remove the disconnect
5899 notification when the step completes so we don't accumulate a
5900 bazillion such notifications which will fire weeks later (when the
5901 slave finally disconnects normally). Fixes SF#915807, thanks to
5902 spiv (Andrew Bennetts) for the report.
5903 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5904 really isn't Logged- specific
5905 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5906 header, since it's almost always going to be appended to an
5908 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5909 update test to handle use of notifyOnDisconnect
5911 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5912 don't clear .ETA and .currentBuild when going offline, let the
5913 current build clean up after itself
5915 * buildbot/process/builder.py (Builder.detached): wait a moment
5916 before doing things like stopping the current build, because the
5917 current step will probably notice the disconnect and cleanup the
5919 * buildbot/test/test_run.py (Status.tearDown): update test to
5920 handle asynchronous build-detachment
5922 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5924 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5925 hush a debug message
5927 2004-09-05 Brian Warner <warner@lothar.com>
5929 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5930 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5931 kernels do this: the fcntl module has the F_NOTIFY constant, but
5932 the kernel itself doesn't support the operation. Thanks to Olly
5933 Betts for spotting the problem.
5935 * buildbot/process/step.py (Darcs): new source-checkout command
5936 (Arch): new source-checkout command
5937 (todo_P4): fix constructor syntax, still just a placeholder
5938 * buildbot/test/test_vc.py (VC.testDarcs): test it
5939 (VC.testDarcsHTTP): same, via localhost HTTP
5941 (VC.testArchHTTP): same
5942 * NEWS: mention new features
5944 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5945 which tells the step to stash stdout text locally (in .stdout).
5946 Slave-side Commands can use this to make decisions based upon the
5947 output of the the ShellCommand (not just the exit code).
5948 (Darcs): New source-checkout command
5949 (Arch): New source-checkout command, uses .keepStdout in one place
5950 where it needs to discover the archive's default name.
5952 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5953 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5954 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5956 * buildbot/process/step.py (ShellCommand.describe): add an
5957 alternate .descriptionDone attribute which provides descriptive
5958 text when the step is complete. .description can be ["compiling"],
5959 for use while the step is running, then .descriptionDone can be
5960 ["compile"], used alone when the step succeeds or with "failed" when
5961 it does not. Updated other steps to use the new text.
5962 * buildbot/process/step_twisted.py: same
5963 * buildbot/test/test_run.py: update tests to match
5965 2004-08-30 Brian Warner <warner@lothar.com>
5967 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5968 (CVS.__init__): send 'patch' argument to slave
5969 (CVS.start): don't create the LoggedRemoteCommand until start(),
5970 so we can catch a .patch added after __init__
5971 (SVN.__init__): add 'patch' to SVN too
5974 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5975 argument, to let commands push data into the process' stdin pipe.
5976 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5977 is in use, since closing a PTY doesn't really affect the process
5978 in the right way (in particular, I couldn't run /usr/bin/patch
5980 (SourceBase.doPatch): handle 'patch' argument
5982 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5985 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5986 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5988 * buildbot/master.py (BotPerspective.got_commands): get command
5989 versions from slave, give to each builder
5990 * buildbot/process/builder.py (Builder.attached): stash slave
5991 command versions in .remoteCommands
5993 * docs/steps.xhtml: bring docs in-line with reality
5995 * buildbot/process/step.py (CVS.__init__): more brutal
5996 compatibility code removal
5997 (SVN.__init__): same
5999 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6000 (SlaveShellCommand.start): require ['workdir'] argument, remove
6001 the ['dir'] fallback (compatibility will come later)
6002 (SourceBase): update docs
6003 (SourceBase.start): remove ['directory'] fallback
6006 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6007 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6008 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6010 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6011 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6012 code.. I will figure out 0.5.0-compatibility hooks later)
6014 2004-08-30 Brian Warner <warner@lothar.com>
6016 * buildbot/process/process_twisted.py: rewrite in terms of new
6017 BuildFactory base class. It got significantly shorter. Yay
6020 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6021 work with the new "self.build isn't nailed down until we call
6022 step.start()" scheme: specifically, __init__ is called before the
6023 build has decided on which Changes are going in, so we don't scan
6024 build.allFiles() for .xhtml files until start()
6025 (HLint.commandComplete): use getText(), not getStdout()
6026 (RunUnitTests.start): same: don't use .build until start()
6027 (RunUnitTests.describe): oops, don't report (None) when using
6029 (RunUnitTests.commandComplete): use getText()
6030 (RunUnitTests.createSummary): same
6031 (BuildDebs.commandComplete): same
6033 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6034 set args['command'] until start(), since our BuildStep is allowed
6035 to change their mind up until that point
6036 (TreeSize.commandComplete): use getText(), not getStdout()
6038 * docs/examples/twisted_master.cfg: update to current standards
6040 * docs/factories.xhtml: update
6041 * buildbot/process/factory.py: implement all the common factories
6042 described in the docs. The Trial factory doesn't work yet, and
6043 I've probably broken all the process_twisted.py factories in the
6044 process. There are compatibility classes left in for things like
6045 the old BasicBuildFactory, but subclasses of them are unlikely to
6047 * docs/examples/glib_master.cfg: use new BuildFactories
6048 * docs/examples/hello.cfg: same
6050 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6051 explicit 'workdir' args
6053 * buildbot/process/base.py (BuildFactory): move factories to ..
6054 * buildbot/process/factory.py (BuildFactory): .. here
6055 * buildbot/process/process_twisted.py: handle move
6056 * buildbot/test/test_config.py: same
6057 * buildbot/test/test_run.py: same
6058 * buildbot/test/test_steps.py: same
6059 * buildbot/test/test_vc.py: same
6060 * docs/factories.xhtml: same
6062 * NEWS: mention config changes that require updating master.cfg
6064 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6065 argument to all steps that weren't given one already, pointing at
6066 the "build/" directory.
6068 * docs/examples/hello.cfg: remove explicit 'workdir' args
6070 * docs/factories.xhtml: document standard BuildFactory clases,
6071 including a bunch which are have not yet been written
6073 2004-08-29 Brian Warner <warner@lothar.com>
6075 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6076 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6077 buildbot.status.builder so they aren't quite so internal
6078 * buildbot/process/base.py, buildbot/process/builder.py: same
6079 * buildbot/process/maxq.py, buildbot/process/step.py: same
6080 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6081 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6082 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6084 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6085 to handle new getLogs()-returns-list behavior
6086 (StatusResourceBuildStep.getChild): same
6087 (StepBox.getBox): same
6088 (WaterfallStatusResource.phase0): same
6090 * docs/source.xhtml: document how Buildbot uses version-control
6091 systems (output side: how we get source trees)
6092 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6093 systems (input side: how we learn about Changes)
6095 * buildbot/master.py (Manhole): use ComparableMixin
6096 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6097 * buildbot/changes/mail.py (MaildirSource): same
6098 * buildbot/status/client.py (PBListener): same
6099 * buildbot/status/html.py (Waterfall): same
6100 * buildbot/status/words.py (IRC): same
6102 * NEWS: start describing new features
6104 * buildbot/status/mail.py (MailNotifier): finish implementation.
6105 The message body is still a bit sparse.
6106 * buildbot/test/test_status.py (Mail): test it
6108 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6109 and __hash__ methods I wind up adding everywhere. Specifically
6110 intended to support the buildbot config-file update scheme where
6111 we compare, say, the old list of IStatusTargets against the new
6112 one and don't touch something which shows up on both lists.
6113 * buildbot/test/test_util.py (Compare): test case for it
6115 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6116 return a list instead of a dict
6117 (IBuildStepStatus.getLogs): same. The idea is that steps create
6118 logs with vaguely unique names (although their uniqueness is not
6119 guaranteed). Thus a compilation step should create its sole
6120 logfile with the name 'compile', and contribute it to the
6121 BuildStatus. If a step has two logfiles, try to create them with
6122 different names (like 'test.log' and 'test.summary'), and only
6123 contribute the important ones to the overall BuildStatus.
6124 * buildbot/status/builder.py (Event.getLogs): same
6125 (BuildStepStatus): fix default .text and .results
6126 (BuildStepStatus.addLog): switch to list-like .getLogs()
6127 (BuildStepStatus.stepFinished): same
6128 (BuildStatus.text): fix default .text
6129 (BuildStatus.getLogs): temporary hack to return all logs (from all
6130 child BuildStepStatus objects). Needs to be fixed to only report
6131 the significant ones (as contributed by the steps themselves)
6132 * buildbot/test/test_run.py: handle list-like .getLogs()
6133 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6135 2004-08-28 Brian Warner <warner@lothar.com>
6137 * buildbot/process/builder.py (Builder.attached): serialize the
6138 attachment process, so the attach-watcher isn't called until the
6139 slave is really available. Add detached watchers too, which makes
6142 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6144 * buildbot/test/test_swap.py: remove dead code
6146 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6147 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6148 sort of as if the command being run exited with a -1. There may
6149 still be some holes in this scheme.
6150 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6151 -r option appears before the module list
6152 * buildbot/process/step.py (CVS): add 'revision' argument
6154 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6155 when sending updates or stepComplete messages to the master, since
6156 we don't currently care whether they arrive or not. When we revamp
6157 the master/slave protocol to really resume interrupted builds,
6158 this will need revisiting.
6159 (lostRemote): remove spurious print
6161 * buildbot/master.py (BotPerspective.attached): serialize the
6162 new-builder interrogation process, to make testing easier
6163 (BotMaster.waitUntilBuilderDetached): convenience function
6165 * buildbot/status/builder.py (BuilderStatus): prune old builds
6166 (BuildStatus.pruneSteps): .. and steps
6167 (BuildStepStatus.pruneLogs): .. and logs
6168 (BuilderStatus.getBuild): handle missing builds
6169 * buildbot/status/html.py (StatusResourceBuild.body): display build
6170 status in the per-build page
6171 (BuildBox.getBox): color finished builds in the per-build box
6173 2004-08-27 Brian Warner <warner@lothar.com>
6175 * buildbot/status/mail.py (MailNotifier): new notification class,
6178 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6179 variants of a common base class which handles all the mode= logic
6181 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6183 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6185 2004-08-26 Brian Warner <warner@lothar.com>
6187 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6190 * buildbot/test/test_run.py: update to new Logfile interface, new
6191 buildbot.slave modules
6192 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6194 * MANIFEST.in: new sample config file
6195 * docs/examples/hello.cfg: same
6197 * buildbot/process/step_twisted.py: remove dead import
6199 * buildbot/process/step.py (RemoteCommand.run): catch errors
6201 (RemoteCommand.remote_update): ignore updates that arrive after
6203 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6204 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6205 the responsibilities of the subclass's methods
6206 (BuildStep.failed): catch errors during failure processing
6207 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6208 (CVS): move to a mode= argument (described in docstring), rather
6209 than the ungainly clobber=/export=/copydir= combination.
6210 (SVN): add mode= functionality to SVN too
6211 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6213 * buildbot/process/base.py (Build.startNextStep): catch errors
6214 during s.startStep()
6216 * buildbot/clients/base.py: update to new PB client interface.
6217 gtkPanes is still broken
6219 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6220 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6221 * setup.py: add buildbot.slave module
6222 * buildbot/bb_tap.py: handle move
6223 * buildbot/slave/registry.py: place to register commands, w/versions
6224 * buildbot/slave/bot.py: major simplifications
6225 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6226 instead of a fixed table. Eventually this will make the slave more
6227 extensible. Use 'start' method on the command, not .startCommand.
6228 Fix unsafeTracebacks handling (I think).
6229 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6230 helper class with a .start method that returns a Deferred.
6231 SlaveShellCommand is the form reached by the buildmaster. Commands
6232 which use multiple ShellCommands can just chain them as Deferreds,
6233 with some helper methods in Command (_abandonOnFailure and
6234 _checkAbandoned) to bail on rc!=0.
6235 (CVSCommand): prefer new mode= argument
6236 (SVNFetch): add mode= argument
6238 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6239 put a useful reason string on the build
6241 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6242 core functionality into an IStatusLog object
6243 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6244 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6245 (StatusResourceBuild.body): use proper accessor methods
6246 * buildbot/status/client.py (RemoteLog): PB-access goes here
6247 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6248 which delivers log contents too
6249 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6250 * buildbot/status/event.py: remove old Logfile completely
6252 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6253 subscription interface for IStatusLog subscriptions just like all
6254 other the status subscriptions
6255 (IStatusReceiver.logChunk): method called on subscribers
6257 2004-08-24 Brian Warner <warner@lothar.com>
6259 * buildbot/process/builder.py (Builder._pong): oops, ping response
6260 includes a result (the implicit None returned by remote_print).
6261 Accept it so the _pong method handles the response correctly.
6263 2004-08-06 Brian Warner <warner@lothar.com>
6265 * buildbot/test/test_config.py: update IRC, PBListener tests
6267 * buildbot/status/client.py (StatusClientPerspective): total
6268 rewrite to match new IStatus interfaces. New subscription scheme.
6269 There are still a few optimizations to make (sending down extra
6270 information with event messages so the client doesn't have to do a
6271 round trip). The logfile-retrieval code is probably still broken.
6272 Moved the PB service into its own port, you can no longer share a
6273 TCP socket between a PBListener and, say, the slaveport (this
6274 should be fixed eventually).
6275 * buildbot/clients/base.py (Client): revamp to match. still needs
6276 a lot of work, but basic event reporting works fine. gtkPanes is
6279 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6280 instance talks to a single irc server. Threw out all the old
6281 multi-server handling code. Still need to add back in
6282 builder-control (i.e. "force build")
6284 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6285 more random text to the as-yet-unreachable per-step page
6287 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6288 rename to stepETAUpdate
6289 (BuildStatus.subscribe): add build-wide ETA updates
6290 (BuilderStatus.getState): remove more cruft
6291 (BuilderStatus.getCurrentBuild): remove more cruft
6292 (BuilderStatus.buildStarted): really handle tuple-subscription
6293 * buildbot/test/test_run.py (Status.testSlave): handle the
6294 stepETAUpdate rename
6296 * buildbot/master.py (BuildMaster): don't add a default
6297 StatusClientService. Don't add a default IrcStatusFactory. Both
6298 are now added through c['status'] in the config file. c['irc'] is
6299 accepted for backwards compatibility, the only quirk is you cannot
6300 use c['irc'] to specify IRC servers on ports other than 6667.
6302 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6303 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6304 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6305 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6308 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6309 the buildmaster to re-read its config file
6312 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6313 find out the port our server is running on
6314 (WebTest.test_webPathname_port): same
6316 * buildbot/test/test_config.py (testWebPortnum): test it
6317 (testWebPathname): ditto
6319 * docs/config.xhtml: document new c['status'] configuration option
6321 * buildbot/status/html.py (Waterfall): new top-level class which
6322 can be added to c['status']. This creates the Site as well as the
6323 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6324 reachable as .parent, for everything.
6326 * buildbot/master.py (Manhole): make it a normal service Child
6327 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6328 webPathname. It will eventually replace c['irc'] and the implicit
6329 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6330 in as (deprecated) backward compatibility hooks for now.
6333 * buildbot/process/builder.py (Builder.buildFinished): don't
6334 inform out builder_status about a finished build, as it finds out
6335 through its child BuildStatus object
6337 * buildbot/status/html.py: extensive revamp. Use adapters to make
6338 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6339 have both starting and finishing times and adjust the waterfall
6340 display accordingly, using spacers if necessary. Use SlaveStatus
6341 to get buildslave info.
6342 (StatusResourceBuildStep): new just-one-step resource, used to get
6343 logfiles. No actual href to it yet.
6345 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6346 the time being, until I get the file-naming scheme right
6348 * buildbot/status/builder.py (Event): clean started/finished names
6349 (BuildStatus.isFinished): .finished is not None is the right test
6350 (BuildStatus.buildStarted): track started/finished times ourselves
6351 (BuilderStatus.getSlave): provide access to SlaveStatus object
6352 (BuilderStatus.getLastFinishedBuild): all builds are now in
6353 .builds, even the currently-running one. Accomodate this change.
6354 (BuilderStatus.eventGenerator): new per-builder event generator.
6355 Returns BuildStepStatus and BuildStatus objects, since they can
6356 both be adapted as necessary.
6357 (BuilderStatus.addEvent): clean up started/finished attributes
6358 (BuilderStatus.startBuild,finishBuild): remove dead code
6359 (SlaveStatus): new object to provide ISlaveStatus
6361 * buildbot/process/step.py (ShellCommand.getColor): actually
6362 return the color instead of setting it ourselves
6363 (CVS.__init__): pull .timeout and .workdir options out of
6364 **kwargs, since BuildStep will ignore them. Without this neither
6365 will be sent to the slave correctly.
6366 (SVN.__init__): same
6368 * buildbot/process/builder.py (Builder): move flags to class-level
6370 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6371 SlaveStatus handle that
6373 * buildbot/process/base.py (Build.firstEvent): remove dead code
6374 (Build.stopBuild): bugfix
6376 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6378 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6379 (ChangeMaster.eventGenerator): yield Changes, since there are now
6380 Adapters to turn them into HTML boxes
6382 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6383 (BotPerspective.attached): feed a SlaveStatus object
6384 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6385 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6387 * buildbot/interfaces.py: API additions
6388 (ISlaveStatus): place to get slave status
6390 2004-08-04 Brian Warner <warner@lothar.com>
6392 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6393 the delay finishes, so the step is marked as SUCCESS
6395 * buildbot/test/test_run.py (Status.testSlave): cover more of
6396 IBuildStatus and IBuildStepStatus
6398 * buildbot/status/progress.py (StepProgress): move some flags to
6399 class-level attributes
6400 (StepProgress.remaining): if there are no other progress metrics
6401 to go by, fall back to elapsed time
6402 (StepProgress.setExpectations): take a dict of metrics instead of
6404 (BuildProgress.setExpectationsFrom): pull expectations from the
6405 Expectations, instead of having it push them to the BuildProgress
6406 (Expectations): move some flags to class-level attributes
6407 (Expectations.__init__): copy per-step times from the
6409 (Expectations.expectedBuildTime): new method for per-build ETA
6411 * buildbot/status/event.py (Logfile): move some flags to
6412 class-level attributes
6413 (Logfile.logProgressTo): better method name, let step set the
6414 progress axis name (instead of always being "output")
6416 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6417 times directly, rather than depending upon the (possibly missing)
6418 .progress object. Use 'None' to indicate "not started/finished
6420 (BuildStepStatus.getExpectations): oops, return the full list of
6422 (BuilderStatus._buildFinished): append finished builds to .builds
6424 * buildbot/process/step.py (BuildStep): add separate .useProgress
6425 flag, since empty .progressMetrics[] still implies that time is a
6427 (CVS): set up the cmd in __init__, instead of waiting for start()
6429 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6430 calculation, this will eventually turn into a proper sourceStamp
6431 (Build.setupBuild): tell the Progress to load from the Expectations,
6432 instead of having the Expectations stuff things into the Progress
6433 (Build.buildException): add a build-level errback to make sure the
6434 build's Deferred fires even in case of exceptions
6436 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6438 * buildbot/process/builder.py (Builder.forceBuild): convey the
6439 reason instead of creating a fake Change
6441 * docs/examples/twisted_master.cfg: update to match reality
6443 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6444 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6445 fix or remove broken/breaking tests
6447 * buildbot/status/event.py (Logfile.__len__): remove evil method
6449 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6450 missing .build, for test convenience
6452 * buildbot/process/step_twisted.py: import fixes
6454 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6456 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6457 .statusbag reference
6459 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6460 connection at shutdown, and stop it from reconnecting
6462 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6463 chase down remote-execution bugs
6465 * buildbot/process/step.py: more fixes, remove
6466 BuildStep.setStatus()
6467 * buildbot/status/builder.py: move setStatus() functionality into
6469 * buildbot/status/event.py: minor fixes
6471 2004-08-03 Brian Warner <warner@lothar.com>
6473 * buildbot/process/base.py, buildbot/process/builder.py
6474 * buildbot/process/step.py, buildbot/status/builder.py
6475 * buildbot/status/event.py, buildbot/test/test_run.py:
6476 fix status delivery, get a basic test case working
6477 * buildbot/master.py: finish implementing basic status delivery,
6478 temporarily disable HTML/IRC/PB status sources
6480 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6482 * buildbot/status/progress.py (BuildProgress): remove dead code
6484 * buildbot/interfaces.py
6485 * buildbot/process/base.py, buildbot/process/builder.py
6486 * buildbot/process/step.py, buildbot/process/step_twisted.py
6487 * buildbot/status/builder.py: Complete overhaul of the all
6488 status-delivery code, unifying all types of status clients (HTML,
6489 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6490 look like. This commit is a checkpointing of the work-in-progress:
6491 the input side is mostly done (Builders/Builds sending status
6492 to the BuilderStatus/BuildStatus objects), but the output side has
6493 not yet been started (HTML resources querying BuilderStatus
6494 objects). Things are probably very broken right now and may remain
6495 so for several weeks, I apologize for the disruption.
6497 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6498 HTML as the log's contents. Currently used for exception tracebacks.
6499 * buildbot/status/progress.py: minor spelling changes
6501 2004-08-02 Brian Warner <warner@lothar.com>
6503 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6504 in mozilla. Also added stylesheets copied from Twisted's docs.
6505 Remember that these files are meant to be run through Lore first.
6506 Thanks to Philipp Frauenfelder for the fixes.
6507 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6508 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6509 * docs/template.tpl: added a Lore template
6511 2004-07-29 Brian Warner <warner@lothar.com>
6513 * buildbot/interfaces.py: revamp status delivery. This is the
6514 preview: these are the Interfaces that will be provided by new
6515 Builder code, and to which the current HTML/IRC/PB status
6516 displayers will be adapted.
6518 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6519 on the SlaveBuilder, not the Bot.
6520 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6522 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6523 set .usePTY on the FakeSlaveBuilder
6525 2004-07-25 Brian Warner <warner@lothar.com>
6527 * buildbot/changes/freshcvs.py: add some debug log messages
6528 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6529 disabled 'setFilter' syntax
6530 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6531 don't end with a slash
6533 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6535 * setup.py: bump to 0.5.0+ while between releases
6537 2004-07-23 Brian Warner <warner@lothar.com>
6539 * setup.py (version): Releasing buildbot-0.5.0
6541 2004-07-23 Brian Warner <warner@lothar.com>
6543 * README: update for 0.5.0 release
6545 * NEWS: update for 0.5.0 release
6547 2004-07-22 Brian Warner <warner@lothar.com>
6549 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6550 mktap-time configuration flag (--usepty=1, --usepty=0)
6551 * buildbot/bot.py: same
6553 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6554 an 'info' directory being unwanted
6556 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6557 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6558 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6559 and earlier), use a FreshCVSSourceOldcred instead.
6560 (test): simple test routine: connect to server, print changes
6562 * buildbot/changes/changes.py (Change.getTime): make it possible
6563 to print un-timestamped changes
6565 * buildbot/master.py (makeApp): delete ancient dead code
6566 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6567 * buildbot/test/test_config.py (testFindConfigFile): test it
6569 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6570 instead of win32 one
6573 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6574 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6577 * buildbot/process/base.py (Builder.__init__): change constructor
6578 to accept a dictionary of config data, rather than discrete
6579 name/slave/builddir/factory arguments
6581 * docs/examples/twisted_master.cfg: update to new syntax
6582 * docs/examples/glib_master.cfg: same
6583 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6584 rough tests of the new syntax
6587 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6588 to be an int, which means "run a web.distrib sub-server on a TCP
6589 port". This lets you publish the buildbot status page to a remote
6590 twisted.web server (using distrib.ResourceSubscription). Also
6591 rename the local attributes used to hold these web things so
6592 they're more in touch with reality.
6593 * buildbot/test/test_web.py: test webPortnum and webPathname
6594 * docs/config.xhtml: document this new use of webPathname
6596 * docs/config.xhtml: new document, slightly ahead of reality
6598 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6599 'prefix' handling: treat it as a simple string to check with
6600 .startswith, instead of treating it as a directory. This allows
6601 sub-directories to be used. If you use prefix=, you should give it
6602 a string that starts just below the CVSROOT and ends with a slash.
6603 This prefix will be stripped from all filenames, and filenames
6604 which do not start with it will be ignored.
6606 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6608 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6609 and --exclude (inverse of --include). SVN post-commit hooks
6610 now have total control over which changes get sent to buildbot and which
6613 2004-07-10 Brian Warner <warner@lothar.com>
6615 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6616 test case to match new API
6618 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6619 which crashed HTML display when self.entries=[] (needed to
6620 distinguish between [], which means "no entries yet", and None,
6621 which means "the entries have been swapped out to disk, go fetch
6624 2004-07-04 Brian Warner <warner@lothar.com>
6626 * buildbot/process/step_twisted.py (countFailedTests): Count
6627 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6628 10kb from the end because any import errors are wedged there and
6629 they would make us think the test log was unparseable.
6630 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6632 2004-06-26 Brian Warner <warner@lothar.com>
6634 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6635 delete-*.pyc command into an actual BuildStep, so we can label it
6637 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6638 (FullTwistedBuildFactory): same
6640 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6642 * contrib/fakechange.py: Add an errback when sending the fake
6643 change, so we know it didn't work.
6645 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6647 * buildbot/process/step_twisted.py: Delete *.pyc files before
6648 calling trial, so it doesn't catch any old .pyc files whose .py
6649 files have been moved or deleted.
6651 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6652 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6653 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6654 instead of ["twisted.test"], so that the end result is "trial -R
6657 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6658 regular expression to match filenames that should be ignored when
6659 changed. Also add a --revision parameter that specifies the
6660 revision to examine, which is useful for debugging.
6662 2004-06-25 Brian Warner <warner@lothar.com>
6664 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6665 summary of warnings (like DeprecationWarnings), next to the
6668 2004-05-13 Brian Warner <warner@lothar.com>
6670 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6671 we now have a w32 build slave courtesy of Mike Taylor.
6673 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6674 so broken. Fixed a race condition that tripped up interlocked
6675 builds and caused the status to be stuck at "Interlocked" forever.
6676 The twisted buildbot's one interlocked build just so happened to
6677 never hit this case until recently (the feeding builds both pass
6678 before the interlocked build is attempted.. usually it has to wait
6680 (Builder._pong_failed): fix method signature
6682 * setup.py: bump to 0.4.3+ while between releases
6684 2004-04-30 Brian Warner <warner@lothar.com>
6686 * setup.py (version): Releasing buildbot-0.4.3
6688 2004-04-30 Brian Warner <warner@lothar.com>
6690 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6692 * README: update for 0.4.3 release
6694 * NEWS: update for 0.4.3 release
6696 * buildbot/master.py (BuildMaster.__getstate__): make sure
6697 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6699 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6700 .trial as a class attribute, for upgrade from 0.4.2
6702 * buildbot/changes/changes.py (Change.links): add .links for
6705 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6706 .textWatchers and .htmlWatchers at save time, since they are both
6707 volatile, should allow smooth 0.4.2 upgrade
6709 * buildbot/process/step.py (CVS.finishStatus): catch failed
6710 CVS/SVN commands so we can make the status box red
6712 2004-04-29 Brian Warner <warner@lothar.com>
6714 * buildbot/changes/freshcvs.py
6715 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6716 code to do setFilter(), which tells the freshcvs daemon to not
6717 send us stuff that we're not interested in. I will uncomment it
6718 when a new version of CVSToys is available in which setFilter()
6719 actually works, and I get a chance to test it better.
6721 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6723 * buildbot/master.py (Dispatcher): use a registration scheme
6724 instead of hardwired service names
6725 (BuildMaster): keep track of the Dispatcher to support
6728 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6729 PBChangeSource class instead of having it be an undocumented
6730 internal feature of the ChangeMaster. Split out the code into a
6732 * buildbot/changes/pb.py (PBChangeSource): same
6733 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6735 * docs/{factories|sources|steps}.xhtml: document some pieces
6737 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6738 using FCMaildirSource
6739 (f23osx): update OS-X builder to use python2.3, since the slave
6740 was updated to Panther (10.3.3)
6742 2004-03-21 Brian Warner <warner@lothar.com>
6744 * buildbot/process/process_twisted.py: factor out doCheckout, change
6745 to use SVN instead of CVS
6747 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6748 an SVN subclass easier
6749 (BasicSVN): subclass which uses Subversion instead of CVS
6751 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6753 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6755 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6757 2004-02-25 Brian Warner <warner@lothar.com>
6759 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6760 is now either a list (which is passed to spawnProcess directly) or
6761 a string (which gets passed to /bin/sh -c). This removes the useSH
6762 flag and the ArgslistCommand class. Also send status header at the
6763 start and end of each command, instead of having the master-side
6765 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6766 -r'. Update to use list-based arguments.
6767 (SVNFetch): use list-based arguments, use ['dir'] argument to
6769 * buildbot/test/test_steps.py (Commands): match changes
6771 * buildbot/process/step.py (InternalShellCommand.words): handle
6773 (SVN): inherit from CVS, cleanup
6775 * buildbot/status/event.py (Logfile.content): render in HTML, with
6776 stderr in red and headers (like the name of the command we're
6777 about to run) in blue. Add link to a second URL (url + "?text=1")
6778 to get just stdout/stderr in text/plain without markup. There is
6779 still a problem with .entries=None causing a crash, it seems to occur
6780 when the logfile is read before it is finished.
6782 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6783 timeout to the keepalives, and use it to explicitly do a
6784 loseConnection instead of waiting for TCP to notice the loss. This
6785 ought to clear up the silent-lossage problem.
6786 (unsafeTracebacks): pass exception tracebacks back to the master,
6787 makes it much easier to debug problems
6789 2004-02-23 Brian Warner <warner@lothar.com>
6791 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6792 the whole command to /bin/sh instead of execve [Johan Dahlin]
6793 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6794 '-r HEAD' [Johan Dahlin]
6795 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6797 * buildbot/changes/changes.py (Change): add links= argument, add
6798 asHTML method [Johan Dahlin]. Modified to make a bit more
6799 XHTMLish. Still not sure how to best use links= .
6801 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6802 Change.asHTML to display the change, not asText
6804 * buildbot/status/html.py (StatusResourceBuilder): web button to
6807 * buildbot/test/test_run.py: test to actually start a buildmaster
6810 * MANIFEST.in: bring back accidentally-dropped test helper files
6812 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6813 that require cvstoys if it is not installed
6815 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6816 values of "bin/trial" [Dave Peticolas]
6817 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6818 tests passed" when we didn't happen to run any tests
6820 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6821 flunkOnFailure [Johan Dahlin]
6823 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6824 multiple instances of the same Step class by suffixing "_2", etc,
6825 to the name until it is unique. This name needs to be unique
6826 because it is used as a key in the dictionary that tracks build
6828 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6831 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6833 2004-01-14 Brian Warner <warner@lothar.com>
6835 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6836 kicked from a channel, log it
6838 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6839 something over whatever IRC channels the buildmaster is currently
6840 connected to. Added to try and track down a problem in which the
6841 master thinks it is still connected but the IRCd doesn't see it. I
6842 used a styles.Versioned this time, so hopefully users won't have
6843 to rebuild their .tap files this time.
6844 * contrib/debug.glade: add a "Poke IRC" button
6845 * contrib/debugclient.py: same
6847 * setup.py: bump to 0.4.2+ while between releases
6849 2004-01-08 Brian Warner <warner@lothar.com>
6851 * setup.py (version): Releasing buildbot-0.4.2
6853 2004-01-08 Brian Warner <warner@lothar.com>
6855 * NEWS: update for 0.4.2 release
6857 * README: document how to run the tests, now that they all pass
6859 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6861 * buildbot/process/step.py (CVS): add a global_options= argument,
6862 which lets you set CVS global options for the command like "-r"
6863 for read-only checkout, or "-R" to avoid writing in the
6865 * buildbot/slavecommand.py (CVSCommand): same
6867 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6868 testing easier (it is turned off when testing, to avoid the
6871 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6872 to make it easier to test: break generateStepID() out to a
6873 separate function, only update statusbag if it exists.
6874 (ShellCommands): create useful text for dict-based commands too.
6876 * test/*, buildbot/test/*: move unit tests under the buildbot/
6878 * setup.py (packages): install buildbot.test too
6880 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6881 * buildbot/test/test_steps.py: fix it, tests pass now
6883 2004-01-06 Brian Warner <warner@lothar.com>
6885 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6886 freshcvs mail uses a slightly different syntax for new
6887 directories. Update parser to handle either.
6888 * test/test_mailparse.py (Test1.testMsg9): test for same
6890 2003-12-21 Brian Warner <warner@lothar.com>
6892 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6893 'warnOnWarnings' so that lintian errors mark the build orange
6895 2003-12-17 Brian Warner <warner@lothar.com>
6897 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6898 messages emitted by Bonsai, contributed by Stephen Davis.
6900 * test/*: moved all tests to use trial instead of unittest. Some
6901 still fail (test_steps, test_slavecommand, and test_process).
6903 * setup.py (version): bump to 0.4.1+ while between releases
6905 2003-12-09 Brian Warner <warner@lothar.com>
6907 * setup.py (version): Releasing buildbot-0.4.1
6909 2003-12-09 Brian Warner <warner@lothar.com>
6911 * NEWS: update for 0.4.1 release
6913 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6914 freebsd builder code a little bit
6916 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6917 don't try to compare attributes of different classes
6918 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6919 (MaildirSource.messageReceived): fix Change delivery
6921 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6922 into the config file's namespace before loading it, like the
6923 documentation claims it does
6924 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6925 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6926 daemon comes back online
6928 2003-12-08 Brian Warner <warner@lothar.com>
6930 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6931 so the example will work with online=0 as well
6933 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6934 fix the __implements__ line
6936 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6937 class a twisted.application.service.Service, use startService to
6940 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6941 directory fd instead of simple open(). I'm sure this used to work,
6942 but the current version of python refuses to open directories with
6945 2003-12-05 Brian Warner <warner@lothar.com>
6947 * setup.py (version): bump to 0.4.0+ while between releases
6949 2003-12-05 Brian Warner <warner@lothar.com>
6951 * setup.py (version): Releasing buildbot-0.4.0
6953 2003-12-05 Brian Warner <warner@lothar.com>
6955 * docs/examples/glib_master.cfg: replace old sample scripts with
6956 new-style config files
6957 * MANIFEST.in: include .cfg files in distribution tarball
6959 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6960 implement a dummy method to avoid the exception that occurs when
6961 freshcvs sends this to us.
6963 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6964 removed the method, as it broke reconnection. Apparently
6965 stopFactory is called each time the connection attempt fails. Must
6967 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6968 attribute before serialization, since without stopFactory the
6969 reconnect timer may still be active and they aren't serializable.
6971 * test/test_mailparse.py (ParseTest): test with 'self' argument
6973 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6974 argument, as these "functions" are invoked like methods from class
6975 attributes and therefore always get an instance as the first
6978 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6979 message: thanks to Stephen Davis for the catch
6981 2003-12-04 Brian Warner <warner@lothar.com>
6983 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6984 twisted's standard ReconnectingClientFactory. Handles both oldcred
6985 and newcred connections. Also has a bug-workaround for
6986 ReconnectingClientFactory serializing its connector when it
6989 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6990 pbutil. Replace makeApp stuff with proper newcred/mktap
6991 makeService(). Don't serialize Ephemerals on shutdown.
6993 * buildbot/changes/changes.py (ChangeMaster): make it a
6994 MultiService and add the sources as children, to get startService
6995 and stopService for free. This also gets rid of the .running flag.
6997 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6998 new pbutil, turn into a TCPClient at the same time (to get
6999 startService for free). Two variants exist: FreshCVSSourceOldcred
7000 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7001 yet, but when it does, we'll be ready).
7002 (FreshCVSSource.notify): handle paths which are empty after the
7003 prefix is stripped. This only happens when the top-level (prefix)
7004 directory is added, at the very beginning of a Repository's life.
7006 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7007 Now the only reconnecting code is in the factory where it belongs.
7008 (Builder.unsubscribe): unregister the disconnect callback when we
7009 delete the builder on command from the master (i.e. when the
7010 buildmaster is reconfigured and that builder goes away). This
7011 fixes a multiple-delete exception when the status client is shut
7013 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7016 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7017 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7019 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7021 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7022 a list of globs (ugh). The testdir will be searched for files
7023 named *.tests and run the tests in the order specified in each of
7024 those files. This allows for "dependancies" between tests to be
7027 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7028 argument to pass to run_maxq.py, instead of a glob.
7030 2003-10-17 Brian Warner <warner@lothar.com>
7032 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7033 files that live in the sandbox
7035 2003-10-15 Brian Warner <warner@lothar.com>
7037 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7038 spelling error in "docs" count-warnings output
7039 (HLint.start): stupid thinko meant .xhtml files were ignored
7041 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7042 tests now that cReactor is banished to the sandbox
7044 2003-10-10 Brian Warner <warner@lothar.com>
7046 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7047 scheme: now .xhtml are sources and .html are generated
7049 2003-10-08 Brian Warner <warner@lothar.com>
7051 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7052 we were ignoring the 'randomly' parameter.
7054 2003-10-01 Brian Warner <warner@lothar.com>
7056 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7057 posix, to kill sub-children of aborted slavecommands.
7059 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7060 Clean up initialization: lastBuildStatus remains None until the
7061 first build has been completed.
7063 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7064 None as a lastBuildStatus
7065 * buildbot/clients/gtkPanes.py: same
7067 * buildbot/status/client.py (StatusClientService): keep
7068 BuilderStatus objects in self.statusbags . These objects now live
7069 here in the StatusClientService and are referenced by the Builder
7070 object, rather than the other way around.
7071 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7072 * buildbot/process/base.py (Builder): same
7073 * test/test_config.py (ConfigTest.testBuilders): same
7075 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7076 an existing builder, leave the statusbag alone. This will preserve the
7079 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7080 hook. This will probably go away in favor of a class in upcoming
7083 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7084 serviceName from newcred FreshCVSNotifiee setup
7086 2003-09-29 Brian Warner <warner@lothar.com>
7088 * buildbot/process/process_twisted.py: switch to new reactor
7090 * docs/examples/twisted_master.cfg: same
7092 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7094 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7095 botmaster reference instead of the oldapp service lookup
7097 * buildbot/master.py (BuildMaster.__init__): give the
7098 StatusClientService a reference to the botmaster to make it easier to
7101 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7103 * buildbot/status/html.py (Box.td): escape hreffy things so you
7104 can have spaces in things like builder names
7105 (StatusResourceBuilder.body)
7106 (WaterfallStatusResource.body)
7107 (WaterfallStatusResource.body0): same
7109 2003-09-25 Brian Warner <warner@lothar.com>
7111 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7112 rearrange the builder list when adding or removing builders: keep
7113 them in the order the user requested.
7114 * test/test_config.py (ConfigTest.testBuilders): verify it
7116 * contrib/debug.glade: give the debug window a name
7118 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7119 now wait on multiple interlocks. Fix code relating to that.
7120 (Builder.checkInterlocks): same
7121 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7123 * buildbot/master.py (BuildMaster.loadConfig): move from
7124 deprecated pb.BrokerFactory to new pb.PBServerFactory
7125 * test/test_config.py (ConfigTest.testWebPathname): same
7127 * docs/examples/twisted_master.cfg: fix interlock declaration
7129 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7130 Interlocks to their Builders into interlock.py .
7131 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7133 * test/test_config.py (ConfigTest.testInterlocks): validate
7136 * buildbot/process/base.py (Builder.__init__): better comments
7137 * buildbot/process/interlock.py (Interlock.__repr__): same
7138 (Interlock.deactivate): add .active flag, move the code that
7139 attaches/detaches builders into the Interlock
7141 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7143 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7144 tests using the new run_maxq.py script, and reporting failures by
7147 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7148 tests, reporting their success or failure in a buildbot-friendly
7151 2003-09-24 Brian Warner <warner@lothar.com>
7153 * docs/examples/twisted_master.cfg: example of a new-style config
7154 file. This lives in the buildmaster base directory as
7157 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7158 button to make the master re-read its config file
7160 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7161 buildmaster configuration from a file. This file can be re-read
7162 later, and the buildmaster will update itself to match the new
7163 desired configuration. Also use new Twisted Application class.
7164 * test/Makefile, test/test_config.py: unit tests for same
7166 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7167 FreshCVSSources comparable, to support reload.
7168 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7170 * buildbot/process/base.py (Builder): make them comparable, make
7171 Interlocks easier to attach, to support reload. Handle
7172 re-attachment of remote slaves.
7173 * buildbot/process/interlock.py (Interlock): same
7175 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7176 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7177 buildmaster taps are now constructed with mktap.
7178 * buildbot/status/client.py (StatusClientService): same
7180 * buildbot/status/words.py: move to new Services, add support to
7181 connect to multiple networks, add reload support, allow nickname
7182 to be configured on a per-network basis
7184 2003-09-20 Brian Warner <warner@lothar.com>
7186 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7187 the freebsd builder, now that the machine has been upgraded and no
7188 longer has python2.2
7190 * setup.py (version): bump to 0.3.5+ while between releases
7192 2003-09-19 Brian Warner <warner@lothar.com>
7194 * setup.py (version): Releasing buildbot-0.3.5
7196 2003-09-19 Brian Warner <warner@lothar.com>
7198 * NEWS: add post-0.3.4 notes
7200 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7202 * MANIFEST.in: add contrib/*
7204 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7205 use a remote root now: cvs.twistedmatrix.com
7207 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7209 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7210 compatibility with old servers
7211 (FreshCVSSource.start): and provide a way to use it
7212 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7214 * docs/examples/twisted_master.py (twisted_app): update to new
7216 (twisted_app): listen on new ~buildbot socket
7217 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7219 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7220 to reduce cvs bandwidth (update instead of full checkout)
7222 2003-09-11 Brian Warner <warner@lothar.com>
7224 * contrib/fakechange.py: demo how to connect to the changemaster
7225 port. You can use this technique to submit changes to the
7226 buildmaster from source control systems that offer a hook to run a
7227 script when changes are committed.
7229 * contrib/debugclient.py: tool to connect to the debug port. You
7230 can use it to force builds, submit fake changes, and wiggle the
7233 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7234 'Dispatcher' realm to handle all the different kinds of
7235 connections and Perspectives: buildslaves, the changemaster port,
7236 the debug port, and the status client port. NewCredPerspectives
7237 now have .attached/.detached methods called with the remote 'mind'
7238 reference, much like old perspectives did. All the pb.Services
7239 turned into ordinary app.ApplicationServices .
7240 (DebugService): went away, DebugPerspectives are now created
7241 directly by the Dispatcher.
7242 (makeApp): changed interface a little bit
7244 * buildbot/changes/changes.py: newcred
7245 * buildbot/status/client.py: newcred
7247 * buildbot/clients/base.py: newcred client side changes
7248 * buildbot/bot.py: ditto
7250 * docs/examples/glib_master.py: handle new makeApp() interface
7251 * docs/examples/twisted_master.py: ditto
7253 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7254 base newcred Perspectives on. This should go away once Twisted
7255 itself provides something sensible.
7258 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7260 * contrib/svn_buildbot.py: A program that you can call from your
7261 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7262 when a change in an SVN repository has happened. See the top of
7263 the file for some minimal usage info.
7265 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7267 * buildbot/slavecommand.py (ArglistCommand): Add new
7268 ArglistCommand that takes an argument list rather than a string as
7269 a parameter. Using a st.split() for argv is very bad.
7271 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7272 update to a particular revision rather than always checking out
7273 (still not very smart about it, there may be cases where the
7274 checkout becomes inconsistent).
7276 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7278 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7279 SVN fetch support. It can checkout (not update!) a specified
7280 revision from a specified repository to a specified directory.
7282 * buildbot/status/progress.py (Expectations.update): Fix an
7283 obvious bug (apparently created by the change described in the
7284 previous ChangeLog message) by moving a check to *after* the
7285 variable it checks is defined.
7288 2003-09-08 Brian Warner <warner@lothar.com>
7290 * buildbot/status/progress.py (Expectations.update): hack to catch
7291 an exception TTimo sees: sometimes the update() method seems to
7292 get called before the step has actually finished, so the .stopTime
7293 is not set, so no totalTime() is available and we average None
7294 with the previous value. Catch this and just don't update the
7295 metrics, and emit a log message.
7297 2003-08-24 Brian Warner <warner@lothar.com>
7299 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7300 parameter to set copydir='original' in CVS commands.
7302 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7304 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7305 which tells the command to maintain a separate original-source CVS
7306 workspace. For each build, this workspace will be updated, then
7307 the tree copied into a new workdir. This reduces CVS bandwidth
7308 (from a full checkout to a mere update) while doubling the local
7309 disk usage (to keep two copies of the tree).
7311 2003-08-21 Brian Warner <warner@lothar.com>
7313 * buildbot/status/event.py (Logfile.addEntry): if the master web
7314 server dies while we're serving a page, request.write raises
7315 pb.DeadReferenceError . Catch this and treat it like a
7316 notifyFinish event by dropping the request.
7318 2003-08-18 Brian Warner <warner@lothar.com>
7320 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7321 (instead of blowing up) if a force-build command is given without
7324 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7325 don't blow up if there aren't yet any Changes in the list
7327 2003-08-02 Brian Warner <warner@lothar.com>
7329 * buildbot/bot.py (updateApplication): don't set the .tap name,
7330 since we shouldn't assume we own the whole .tap file
7332 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7333 'mktap buildbot' (without a subcommand) better
7335 2003-07-29 Brian Warner <warner@lothar.com>
7337 * buildbot/status/words.py
7338 (IrcStatusFactory.clientConnectionLost): when we lose the
7339 connection to the IRC server, schedule a reconnection attempt.
7341 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7342 use shutil.rmtree instead of forking off an "rm -rf" command.
7343 rmtree may take a while and will block until it finishes, so we
7344 use "rm -rf" if available.
7346 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7347 freebsd buildslave badly
7349 * setup.py (version): bump to 0.3.4+ while between releases
7351 2003-07-28 Brian Warner <warner@lothar.com>
7353 * setup.py (version): Releasing buildbot-0.3.4
7355 2003-07-28 Brian Warner <warner@lothar.com>
7357 * NEWS: update in preparation for release
7359 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7360 process.signalProcess instead of os.kill, to improve w32
7363 * docs/examples/twisted_master.py (twisted_app): turn off
7364 win32eventreactor: the tests hang the buildslave badly
7366 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7367 failed builds, since usually the failures are consistent
7369 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7370 add compileOpts/compileOpts2 to reactors build
7372 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7373 (twisted_app): use both default and win32eventreactor on w32 build.
7374 Use both default and kqreactor on freebsd build.
7376 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7377 add compileOpts2, which is put after the build_ext argument. w32
7378 needs "-c mingw32" here.
7380 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7381 touch .acqpath, it goes away in recent Twisted releases
7383 * docs/examples/twisted_master.py (twisted_app): use "python" for
7384 the w32 buildslave, not "python2.2"
7386 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7387 the directory exists.. should hush an exception under w32
7389 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7390 ProcessTerminated -provided values for signal and exitCode rather
7391 than parsing the unix status code directly. This should remove one
7392 more roadblock for a w32-hosted buildslave.
7394 * test/test_mailparse.py: add test cases for Syncmail parser
7396 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7397 temporary compatibility import. Note! Start importing
7398 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7400 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7402 2003-07-27 Brian Warner <warner@lothar.com>
7404 * NEWS: started adding new features
7406 * buildbot/changes/mail.py: start work on Syncmail parser, move
7407 mail sources into their own file
7409 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7410 as implementing IChangeSource
7411 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7413 * buildbot/interfaces.py: define the IChangeSource interface
7415 2003-07-26 Brian Warner <warner@lothar.com>
7417 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7419 2003-06-25 Brian Warner <warner@lothar.com>
7421 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7424 2003-06-17 Brian Warner <warner@lothar.com>
7426 * buildbot/status/words.py: clean up method usage to avoid error
7427 in silly IRC command
7428 (IrcStatusBot.emit_status): round off seconds display
7430 * buildbot/process/base.py (Build): delete the timer when saving
7431 to the .tap file, and restore it (if it should still be running)
7432 upon restore. This should fix the "next build in -34 seconds"
7433 messages that result when the master is restarted while builds are
7434 sitting in the .waiting slot. If the time for the build has
7435 already passed, start it very soon (in 1 second).
7437 * buildbot/status/words.py: more silly commands
7439 * README (REQUIREMENTS): add URLs to all required software
7441 * buildbot/status/words.py ('last'): mention results of, and time
7444 2003-05-28 Brian Warner <warner@lothar.com>
7446 * buildbot/status/words.py: add 'last' command
7447 (IrcStatusBot.emit_status): add current-small text to 'status' output
7449 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7450 (twisted_app): remove spaces from OS-X builder name
7452 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7453 * buildbot/status/words.py: IRC bot should actually be useful now
7455 2003-05-23 Brian Warner <warner@lothar.com>
7457 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7458 "slave information" from $(slavedir)/info/* . These files are
7459 maintained by the slave administrator, and describe the
7460 machine/environment that is hosting the slave. Information from
7461 them is put into the "Builder" HTML page. Still need to establish
7462 a set of well-known filenames and meanings for this data: at the
7463 moment, *all* info/* files are sent to the master, but only
7464 'admin' and 'host' are used on that end.
7465 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7466 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7467 * buildbot/master.py (BotPerspective.got_info): ditto
7469 2003-05-22 Brian Warner <warner@lothar.com>
7471 * setup.py (version): bump version to 0.3.3+ while between releases
7473 2003-05-21 Brian Warner <warner@lothar.com>
7475 * setup.py: Releasing buildbot-0.3.3
7477 2003-05-21 Brian Warner <warner@lothar.com>
7479 * NEWS: 0.3.3 news items
7481 * README: describe --keepalive and life behind a NAT box
7483 * buildbot/bot.py (Bot.connected): implement application-level
7484 keepalives to deal with NAT timeouts, turn them on with
7485 --keepalive option or when SO_KEEPALIVE doesn't work.
7487 * buildbot/master.py (BotPerspective): accept keepalives silently
7489 * buildbot/process/base.py (Build.buildException): CopiedFailures
7490 don't carry as much information as local ones, so don't try to
7491 create a big HTMLized version of them.
7493 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7494 log file when step fails due to an exception, such as when the slave
7497 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7498 --testmodule argument instead of grepping for test-case-name tags
7499 ourselves. Remove FindUnitTests code.
7500 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7502 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7504 2003-05-16 Brian Warner <warner@lothar.com>
7506 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7507 argument to allow things like CFLAGS=-O0 to be passed without relying
7508 upon /bin/sh processing on the slave.
7510 * buildbot/process/step.py (InternalShellCommand.start): send
7512 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7513 'split' instead of letting /bin/sh do it. This should also remove
7514 the need for /bin/sh on the buildslave, making it more likely to
7517 * buildbot/status/html.py: html-escape text in blamelist.
7518 Add "force build" button to the Builder page.
7520 * buildbot/process/step_twisted.py (countFailedTests): look at
7521 last 1000 characters for status line, as import errors can put it
7522 before the -200 point.
7524 2003-05-15 Brian Warner <warner@lothar.com>
7526 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7528 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7529 make 'clobber' a parameter, so it is possible to have builds which
7530 do full tests but do a cvs update instead of hammering the CVS
7531 server with a full checkout each build
7533 * buildbot/process/step.py (InternalShellCommand): bump default
7534 timeout to 20 minutes
7536 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7537 the master to trigger a build. Run it via manhole.
7539 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7540 allow slaves to trigger any build that they host, to make life
7541 easier for slave admins who are testing out new build processes
7543 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7544 don't flunk cReactor or qtreactor on failure, since they fail alot
7545 these days. Do warnOnFailure instead.
7547 * buildbot/process/base.py: change Builder.buildable from a list
7548 into a single slot. When we don't have a slave, new builds (once
7549 they make it past the timeout) are now merged into an existing
7550 buildable one instead of being queued. With this change, a slave
7551 which has been away for a while doesn't get pounded with all the
7552 builds it missed, but instead just does a single build.
7554 2003-05-07 Brian Warner <warner@lothar.com>
7556 * setup.py (version): bump version to 0.3.2+ while between releases
7558 2003-05-07 Brian Warner <warner@lothar.com>
7560 * setup.py: Releasing buildbot-0.3.2
7562 2003-05-07 Brian Warner <warner@lothar.com>
7564 * setup.py: fix major packaging error: include subdirectories!
7566 * NEWS: add changes since last release
7568 * README (REQUIREMENTS): update twisted/python dependencies
7570 * buildbot/status/builder.py (Builder.startBuild): change
7571 BuildProcess API: now they should call startBuild/finishBuild
7572 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7573 keeping a list of builds in the statusbag, to support other kinds of
7575 (Builder.addClient): send current-activity-small to new clients
7576 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7579 * buildbot/status/client.py: drop RemoteReferences at shutdown
7581 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7583 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7584 more debug messages for remote status client
7586 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7587 (.stepFailed): only fire the Deferred once, even if both
7588 stepComplete and stepFailed are called. I think this can happen if
7589 an exception occurs at a weird time.
7591 * buildbot/status/words.py: work-in-progress: IRC status delivery
7593 2003-05-05 Brian Warner <warner@lothar.com>
7595 * docs/examples/twisted_master.py (twisted_app): hush internal
7596 python2.3 distutils deprecation warnings
7597 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7598 add compileOpts= argument which inserts extra args before the
7599 "setup.py build_ext" command. This can be used to give -Wignore
7600 warnings, to hush some internal python-2.3 deprecation messages.
7602 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7603 the ['twisted.test'] default test case to make it easier to change
7606 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7607 * buildbot/clients/gtkPanes.py: ditto
7609 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7610 arg to collapse RunUnitTestsRandomly into RunUnitTests
7611 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7612 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7614 * buildbot/status/html.py (StatusResource): shuffle Resources
7615 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7616 would serve the waterfall display, but the internal links were
7617 only valid on the trailing-slash version. The correct behavior is
7618 for the non-slashed one to serve a Redirect to the slashed one.
7619 This only shows up when the buildbot page is hanging off another
7620 server, like a Twisted-Web distributed server.
7622 * buildbot/status/event.py (Event, RemoteEvent): make Events
7623 pb.Cacheable, with RemoteEvent as the cached version. This removes
7624 a lot of explicit send-an-update code.
7625 * buildbot/status/builder.py (Builder): remove send-update code
7626 * buildbot/status/client.py (ClientBuilder): remove send-update
7627 code, and log errors that occur during callRemote (mostly to catch
7628 InsecureJelly exceptions)
7630 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7631 run Lore with the same python used in the rest of the build
7633 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7635 * buildbot/process/step_twisted.py (HLint): accept 'python'
7636 argument. Catch rc!=0 and mark the step as failed. This marks the
7637 build orange ("has warnings").
7638 (RunUnitTestsJelly): move out to step_twisted2.py
7640 * buildbot/util.py (ignoreStaleRefs): add utility function
7642 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7643 don't fake ETA object, it's too hard to get right
7645 2003-05-02 Brian Warner <warner@lothar.com>
7647 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7649 2003-05-01 Brian Warner <warner@lothar.com>
7651 * buildbot/status/html.py (StatusResource.body): oops, I was
7652 missing a <tr>, causing the waterfall page to be misrendered in
7653 everything except Galeon.
7655 2003-04-29 Brian Warner <warner@lothar.com>
7657 * docs/examples/twisted_master.py: make debuild use python-2.2
7658 explicitly, now that Twisted stopped supporting 2.1
7660 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7661 handle tuple results too. I keep forgetting this, which suggests
7662 it needs to be rethought.
7664 * setup.py (setup): bump version to 0.3.1+ while between releases
7666 2003-04-29 Brian Warner <warner@lothar.com>
7668 * setup.py: Releasing buildbot-0.3.1
7670 2003-04-29 Brian Warner <warner@lothar.com>
7672 * README (SUPPORT): add plea to send questions to the mailing list
7674 * NEWS, MANIFEST.in: add description of recent changes
7676 * docs/examples/twisted_master.py: add the code used to create the
7677 Twisted buildmaster, with passwords and such removed out to a
7680 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7681 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7682 buildmasters to not require CVSToys be installed.
7683 * README, docs/examples/glib_master: update to match the change
7685 * buildbot/clients/base.py, buildbot/bot.py,
7686 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7687 ReconnectingPB from CVSToys distribution to remove CVSToys
7688 dependency for build slaves and status clients. Buildmasters which
7689 use FreshCVSSources still require cvstoys be installed, of course.
7691 2003-04-25 Brian Warner <warner@lothar.com>
7693 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7694 runTestsRandomly arg to turn on trial -z
7696 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7697 experimental code to use trial's machine-parseable output to get
7698 more detailed test results. Still has some major issues.
7699 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7702 * buildbot/status/builder.py (Builder.setCurrentBuild):
7703 anticipating moving build history into statusbag, not used yet
7705 * buildbot/status/tests.py: code to centralize test results,
7706 doesn't work quite yet
7708 * buildbot/status/event.py (Event): use hasattr("setName") instead
7709 of isinstance for now.. need better long-term solution
7711 * buildbot/status/html.py: Remove old imports
7713 2003-04-24 Brian Warner <warner@lothar.com>
7715 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7716 ignore changes under doc/fun/ and sandbox/
7718 * buildbot/process/step_twisted.py: update pushEvent and friends.
7720 * buildbot/status/html.py (Box.td): replace event.buildername with
7721 event.parent.getSwappableName(). Needs more thought.
7723 * buildbot/status/builder.py (Builder): Replace pushEvent and
7724 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7725 Tell events they are being pruned with event.delete().
7727 * buildbot/process/base.py (Build): Remove Builder status-handling
7728 methods. s/pushEvent/setCurrentActivity/.
7730 * buildbot/process/step.py (BuildStep): clean up status delivery.
7731 Gouse builder.statusbag methods instead of intermediate builder
7732 methods. s/updateLastEvent/updateCurrentActivity/.
7733 s/finalizeLastEvent/finishCurrentActivity/. Use
7734 addFileToCurrentActivity for summaryFunction.
7736 * buildbot/status/event.py (Logfile): put data in a Swappable when
7738 (Event): add more setter methods. Remove .buildername, use .parent
7739 and getSwappableName instead (needs more thought).
7741 * buildbot/util.py (Swappable):
7742 * test/test_swap.py: don't bother setting filename at __init__
7743 time, do it later. Change setFilename args to take parent first,
7744 since it provides the most significant part of the filename.
7746 2003-04-23 Brian Warner <warner@lothar.com>
7748 * buildbot/status/event.py (Logfile.addEntry): append to previous
7751 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7752 anticipating Swappable
7753 (InternalShellCommand.remoteUpdate): split out various log-adding
7754 methods so subclasses can snarf stdout separately
7756 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7757 in anticipation of Swappable build logs
7758 (Builder.testsFinished): anticipating TestResults, still disabled
7760 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7763 * buildbot/status/event.py (Logfile): add (disabled) support for
7764 Swappable, not ready for use yet
7766 * buildbot/util.py (Swappable): object which is swapped out to
7767 disk after some period of no use.
7768 * test/test_swap.py: test buildbot.utils.Swappable
7770 2003-04-14 Brian Warner <warner@lothar.com>
7772 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7773 periodic-build timer. Set the .periodicBuildTime on a builder
7774 instance to some number of seconds to activate it.
7776 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7778 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7779 a way that survives result tuples
7781 2003-04-12 Brian Warner <warner@lothar.com>
7783 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7784 return a dict instead of a tuple: allow summarizers to provide
7785 multiple summaries if they want
7786 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7787 (debuildSummarizer): summarize lintian warnings/errors
7789 2003-04-10 Brian Warner <warner@lothar.com>
7791 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7793 2003-04-09 Brian Warner <warner@lothar.com>
7795 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7796 empty summaries: happens when the tests fail so hard they don't emit
7797 a parseable summary line.
7799 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7800 Allow summaryFunction to return None to indicate no summary should
7803 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7804 writing to stale HTTP requests: notice when they disconnect and
7805 remove the request from the list. Also add CacheToFile from
7806 moshez, will be used later.
7808 2003-04-08 Brian Warner <warner@lothar.com>
7810 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7811 should be an int, not a list of strings
7813 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7814 if we weren't actually connected
7816 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7817 to show the tail end of the trial text output
7819 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7820 hook to summarize the results of a ShellCommand
7822 2003-04-07 Brian Warner <warner@lothar.com>
7824 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7825 twisted test suite code into a single class.
7826 * buildbot/process/process_twisted.py: same
7828 2003-04-04 Brian Warner <warner@lothar.com>
7830 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7832 * README (SLAVE): document use of mktap to create slave .tap file
7833 (REQUIREMENTS): describe dependencies
7835 * buildbot/bb_tap.py, buildbot/plugins.tml:
7836 * buildbot/bot.py (updateApplication): Add mktap support for creating
7837 buildslave .tap files
7839 2003-03-28 Brian Warner <warner@lothar.com>
7841 * buildbot/process/step.py (InternalShellCommand.finished): handle
7842 new tuple result values (fix embarrasing bug that appeared during
7845 2003-03-27 Brian Warner <warner@lothar.com>
7847 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7850 2003-03-25 Brian Warner <warner@lothar.com>
7852 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7853 to overall build status
7854 * buildbot/clients/base.py (Builder): improve event printing
7855 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7856 instead of generic ShellCommand
7857 (Build): Add .stopBuild, use it when slave is detached
7859 * buildbot/process/step.py (Configure,Test): give the steps their
7860 own names and status strings
7862 * buildbot/status/html.py (StatusResource): add "show" argument,
7863 lets you limit the set of Builders being displayed.
7865 2003-03-20 Brian Warner <warner@lothar.com>
7867 * buildbot/process/basic.py: removed
7869 2003-03-19 Brian Warner <warner@lothar.com>
7871 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7872 turn off process-docs by default
7874 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7875 when displaying build information without anything in allBuilds[]
7877 * buildbot/bot.py (makeApp): really take password from sys.argv
7879 2003-03-18 Brian Warner <warner@lothar.com>
7881 * buildbot/bot.py (buildApp): take password from sys.argv
7883 * README: replace with more useful text
7885 * setup.py: add a real one
7886 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7888 * docs/PyCon-2003/: added sources for PyCon paper.
7890 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7891 now Build objects control the process and Builder only handles
7892 slave stuff and distribution of changes/status. A new BuildFactory
7893 class creates Build objects on demand.
7895 Created ConfigurableBuild which takes a list of steps to run. This
7896 makes it a lot easier to set up a new kind of build and moves us
7897 closer to being able to configure a build from a web page.
7899 * buildbot/process/step_twisted.py, process_twisted.py: move to
7900 new model. A lot of code went away.
7902 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7903 send lots of empty progress messages to the client.
7905 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7907 2003-02-20 Brian Warner <warner@lothar.com>
7909 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7911 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7912 Twisted bug that prevented non-pty processes from working just got
7913 fixed, and the bug that leaks ptys is still being investigated.
7915 * buildbot/process/step.py (CVS): send timeout arg to slave
7917 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7918 builders coming and going
7919 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7920 from CVSToys, handle lost-buildmaster
7922 * buildbot/status/client.py (StatusClientService.removeBuilder):
7923 Clean up status client protocol: send builders (with references)
7924 as they are created, rather than sending a list and requiring the
7925 client to figure out which ones are new.
7926 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7927 attempts to force a build on an unknown builder
7929 2003-02-19 Brian Warner <warner@lothar.com>
7931 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7932 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7933 Twisted stops leaking them.
7934 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7935 builder goes to an idle state.
7937 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7938 I figure out why CVS commands hang without them, and/or I fix the
7939 hung-command timeout
7941 2003-02-16 Brian Warner <warner@lothar.com>
7943 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7944 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7945 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7946 GenerateDocs now that they are prefixed with WARNING:.
7948 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7949 use manual href target instead of request.childLink
7951 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7952 display every second, but update the ETA every 5 seconds (or
7953 whenever) as remote_progress messages arrive.
7956 2003-02-12 Brian Warner <warner@lothar.com>
7958 * *: import current sources from home CVS repository
7962 # add-log-time-format: add-log-iso8601-time-string