1 2008-07-24 Brian Warner <warner@lothar.com>
3 * buildbot/__init__.py (version): Releasing buildbot-0.7.8
4 * docs/buildbot.texinfo: same
6 2008-07-24 Brian Warner <warner@lothar.com>
8 * README: update dependencies, tested against twisted-8.1.0
9 * NEWS: update for 0.7.8 release
11 * buildbot/steps/shell.py (Test.getText): include summary text
12 from the parent class (so 'test' or 'running tests' or whatever),
13 and don't add anything if there weren't any test results.
15 * buildbot/status/web/build.py (StatusResourceBuild.body): don't
16 show more than 500 characters of a property value, since the
17 got_revision property for Darcs checkouts can be 10kB or more.
18 Also HTML-escape everything, so <> in the value doesn't confuse
21 * buildbot/process/buildstep.py (BuildStep.setProperty): provide a
22 default value for source=, to accomodate custom buildsteps that
23 don't otherwise provide one
25 * buildbot/master.py (DebugPerspective.perspective_requestBuild):
26 fix variable-name collision that broke the debugclient's 'force
28 * buildbot/clients/debug.py (DebugWidget.err): print errors
30 * buildbot/test/test_bonsaipoller.py
31 (TestBonsaiPoller.testParserWorksAfterInvalidResult): increment
32 the .lastPoll timestamp between calls to _process_changes,
33 otherwise the test fails on a machine with low-res time.time()
35 * setup.py: reduce the setuptools-visible dependency on Twisted to
36 be >=2.0.0 (rather than >=2.4.0), since we can handle older
37 Twisteds without problems.
39 * NEWS: update with recent changes in preparation for the upcoming
42 2008-07-21 Dustin J. Mitchell <dustin@zmanda.com>
44 * buildbot/status/web/waterfall.py (BuildTopBox): show summary
45 even if there were no test results, patch from Pike
46 (BuildTopBox): use the right statistic name, 'tests-failed'
47 instead of just 'failed'
48 * buildbot/status/tinderbox.py: fix regression, patch from Axel
51 2008-07-23 Brian Warner <warner@lothar.com>
53 * buildbot/status/web/build.py (StatusResourceBuild.stop): fix
54 failure due to typo, caught by pyflakes
56 * buildbot/steps/shell.py (Test.setTestResults): set statistics
57 with names like "tests-total" instead of just "total".
59 * buildbot/test/test_steps.py (PerlModuleTest): use
60 getStatistic (with "tests-total") instead of getProperty, and call
61 it on the step_status, not the step itself. This pair makes the
62 PerlModuleTest pass again
64 * docs/buildbot.texinfo: update node names and menus
65 * .darcs-boring: resurrect this file after it was accidentally
68 2008-07-21 Dustin J. Mitchell <dustin@zmanda.com>
70 * buildbot/steps/shell.py (WarningCountingShellCommand): add
71 warning count to the 'warnings' statistic
72 (Test.setTestResults): count stats
73 (Test.getText): include stats in summary text
74 (PerlModuleTest): use setTestResults
76 2008-06-25 Dustin J. Mitchell <dustin@zmanda.com>
78 * docs/buildbot.texinfo: Patch by Albert Hofkamp to use step
79 instances universally in the documentation. (#305)
81 * buildbot/status/builder.py: Upgrading from version 2 to 3
82 of BuildStatus had an incorrect call to properties.update.
85 * buildbot/status/builder.py (BuildStepStatus): introduce
86 'statistics': counters of things that happen a build that
87 aren't better expressed as logfiles or properties. Examples
88 include the number of tests that pass/fail/skip.
89 (BuildStepStatus.hasStatistic)
90 (BuildStepStatus.getStatistic): accessor methods
91 (BuildStepStatus.setStatistic): setter
92 (BuildStatus.getSummaryStatistic): method to summarize stats,
93 using a caller-provided sum() function
94 * buildbot/test/test_status.py (StepStatistics): test it
96 * buildbot/status/web/waterfall.py (BuildTopBox): use stats instead
99 2008-06-13 Dustin J. Mitchell <dustin@zmanda.com>
101 * buildbot/status/web/grid.py (GridStatusResource): Sort the
102 builders in the grid display (#300)
104 2008-06-01 Dustin J. Mitchell <dustin@zmanda.com>
106 * buildbot/status/web/slaves.py (BuildSlavesResource): short patch
107 by Ben Hearsum to make the /buildslaves WebStatus? page a little
108 more useful. It does do things: 1) bolds the 'slave is NOT
109 connected' line to make it more visible 2) shows whether each
110 slave is busy (building) or not (#278)
111 * buildbot/buildslave.py (BuildSlave.updateSlaveStatus): notify
112 the SlaveStatus monitor each time we start or finish a build
113 * buildbot/status/builder.py: same
114 * buildbot/process/base.py: call updateSlaveStatus at start/finish
115 * buildbot/test/test_slaves.py (SlaveBusyness): test it
117 2008-05-26 Dustin J. Mitchell <dustin@zmanda.com>
119 * buildbot/steps/shell.py (PerlModuleTest): Patch by Neil Hemingway
120 <nhemingway@googlemail.com> to add a PerlModuleTest step (#228)
121 * buildbot/process/factory.py (CPAN): use PerlModuleTest, not Test
122 * buildbot/status/web/waterfall.py (BuildTopBox): include count of
123 failed tests in top text, along with 'failed' or 'passed'.
124 * buildbot/test/test_steps.py (PerlModuleTest): test it
125 * docs/buildbot.texinfo (PerlModuleTest): docs
127 2008-05-19 Dustin J. Mitchell <dustin@zmanda.com>
129 * buildbot/changes/dnotify.py: Patch by Gianluca Sforna
130 <giallu@gmail.com> to remove unnecessary shebangs about which
131 rpmlint complains. (#282)
132 * buildbot/clients/base.py: same
133 * buildbot/clients/debug.py: same
134 * buildbot/clients/gtkPanes.py: same
135 * buildbot/dnotify.py: same
136 * buildbot/test/emit.py: same
137 * buildbot/test/emitlogs.py: same
138 * buildbot/test/sleep.py: same
140 2008-05-17 Dustin J. Mitchell <dustin@zmanda.com>
142 * buildbot/test/test_vc.py: Configure username and email in
143 case the user running trial does not have git config in their
144 home directory. (#281)
146 2008-05-16 Dustin J. Mitchell <dustin@zmanda.com>
148 * buildbot/changes/svnpoller.py: Patch by Neil Hemingway
149 <neil.hemingway@googlemail.com> that has svnpoller checking
150 whether the change reported by SVN is a branch deletion. If it is,
151 a buildbot Change is not created. (#261)
152 * buildbot/test/test_svnpoller.py: test it
154 2008-05-15 Dustin J. Mitchell <dustin@zmanda.com>
156 * buildbot/status/words.py (Contact.command_NOTIFY): Patch by Neil
157 Hemingway <nhemingway@googlemail.com>: allow the IRC daemon to
158 notify users on build events, either via private messages or
159 channel messages. (#171)
160 (IRCContact.command_JOIN, IRCContact.command_LEAVE): new commands
161 to tell the buildbot to join or leave irc channels.
162 * buildbot/test/test_status.py (ContactTester): test it
163 * docs/buildbot.texinfo: docs
165 2008-05-14 Dustin J. Mitchell <dustin@zmanda.com>
167 * buildbot/steps/shell.py (SetProperty): A buildstep that is
168 similar to ShellCommand, except that it captures the output of the
169 command into a property. (#232)
170 * buildbot/test/test_properties.py (Run.testSetPropertySimple): same
171 * docs/buildbot.texinfo (SetProperty): same
173 2008-04-29 Brian Warner <warner@lothar.com>
175 * buildbot/slave/commands.py (SourceBase.doCopy): use 'cp -RPp'
176 instead of 'cp -rp': this fixes freebsd-vs-svn-vs-symlinks, and
177 should work with both POSIX and GNU cp. Thanks to Pete Curry for
178 the patch. Closes #86.
179 * buildbot/steps/source.py (Source.__init__): update docstring
181 * buildbot/scripts/sample.cfg: fix comment, thanks to 'ludovic'
182 for the catch. Closes #193.
184 * buildbot/changes/bonsaipoller.py: apply fixes from Ben Hearsum,
186 * buildbot/test/test_bonsaipoller.py: same
188 * buildbot/status/mail.py (MailNotifier): add mode="passing",
189 thanks to 'matisse' for the patch, closes #169.
191 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
192 useChangeTime= argument, from Ben Hearsum, closes #213.
194 * buildbot/changes/svnpoller.py (SVNPoller.checksvn): fix missing
195 argument, thanks to 'thatch' for the catch.
197 * buildbot/status/tinderbox.py (TinderboxMailNotifier): fix scope
198 of logEncoding, patch by Ben Hearsum. Closes #214.
200 * docs/buildbot.texinfo (IRC Bot): fix typo, patch by Christian
203 2008-04-28 Dustin J. Mitchell <dustin@zmanda.com>
205 * buildbot/status/web/xmlrpc.py: Change xmlrpc_getStatus to
206 xmlrpc_getLastBuildResults as Brian suggested (#195)
208 2008-04-24 Brian Warner <warner@lothar.com>
210 * setup.py (setup_args): apply patches from zooko: prepare
211 setup.py for optional setuptoolsification
212 (entry_points): zooko's other patches: if setuptools is available,
213 create an executable via 'entry_points', and declare a dependency
216 * bin/buildbot: apply patch from zooko: use /usr/bin/env in shbang
218 * README (REQUIREMENTS): we handle twisted-8.0.1 just fine.
220 2008-04-21 Dustin J. Mitchell <dustin@zmanda.com>
222 * buildbot/process/base.py: Patch by Ben Hearsum
223 <bhearsum@wittydomain.com>: delay status notification
224 about build start until _startBuild_2 (after a lock has
225 been acquired) (#107)
227 2008-04-20 Dustin J. Mitchell <dustin@zmanda.com>
229 * buildbot/status/web/baseweb.py: Patch by Ben Hearsum
230 <bhearsum@wittydomain.com>: don't appear to be able to control
231 builds when you can't (#246)
233 2008-04-15 Brian Warner <warner@lothar.com>
235 * buildbot/__init__.py (version): bump to 0.7.7+ while between
237 * docs/buildbot.texinfo: same
239 2008-04-15 Dustin J. Mitchell <dustin@zmanda.com>
241 * buildbot/process/properties.py
242 buildbot/test/test_properties.py docs/buildbot.texinfo:
243 Add support for shell-style substitutions, e.g.,
244 %(propname:-replacement)s and %(propname:+replacement)s (#234)
246 2008-04-14 Dustin J. Mitchell <dustin@zmanda.com>
248 * buildbot/process/properties.py buildbot/status/web/build.py
249 buildbot/steps/shell.py buildbot/steps/source.py: Display
250 build properties in the build status page.
252 * docs/buildbot.texinfo: Add properties to the documentation,
253 along with a nontrivial reorganization of the scheduler
254 section of the documentation. (#124)
256 2008-04-13 Dustin J. Mitchell <dustin@zmanda.com>
258 * buildbot/buildset.py buildbot/clients/debug.py
259 buildbot/master.py buildbot/process/base.py
260 buildbot/scheduler.py buildbot/scripts/runner.py
261 buildbot/scripts/tryclient.py buildbot/status/web/builder.py:
262 Remove custom properties, which are now largely redundant,
263 and on which the properties interface was modeled. (#124)
265 2008-04-13 Dustin J. Mitchell <dustin@zmanda.com>
267 * buildbot/buildset.py buildbot/interfaces.py
268 buildbot/process/properties.py buildbot/scheduler.py
269 buildbot/steps/trigger.py buildbot/test/runutils.py
270 buildbot/test/test_properties.py buildbot/test/test_run.py:
271 Make the scheduler classes actually provide properties to
272 the buildsets they submit. Triggerable schedulers also do
273 a nice job of configurably propagating properties from the
274 triggering build. (#124)
276 2008-04-12 Dustin J. Mitchell <dustin@zmanda.com>
278 * buildbot/master.py buildbot/process/base.py
279 buildbot/process/properties.py buildbot/test/runutils.py
280 buildbot/test/test_properties.py: Support global properties,
281 defined with c['properties'] = {} in master.cfg (#124)
283 2008-04-12 Dustin J. Mitchell <dustin@zmanda.com>
285 * buildbot/buildset.py buildbot/buildslave.py
286 buildbot/process/base.py buildbot/process/builder.py
287 buildbot/process/properties.py buildbot/scheduler.py
288 buildbot/steps/trigger.py buildbot/test/runutils.py
289 buildbot/test/test_properties.py: Arrange for properties to
290 come down from schedulers, via BuildStep and BuildRequest
291 objects. custom_props are still present, in parallel, but
292 will go eventually. Triggered builds no longer propagate
295 2008-04-12 Dustin J. Mitchell <dustin@zmanda.com>
297 * buildbot/process/properties.py
298 buildbot/test/test_properties.py: Change Property.getProperty
299 to just return the property value, since having getProperty
300 return different things on different objects is confusing. (#124)
302 2008-04-12 Dustin J. Mitchell <dustin@zmanda.com>
304 * buildbot/process/base.py buildbot/process/buildstep.py
305 buildbot/process/properties.py buildbot/status/builder.py
306 buildbot/steps/python.py buildbot/steps/shell.py
307 buildbot/steps/source.py buildbot/steps/transfer.py
308 buildbot/test/test_properties.py buildbot/test/test_steps.py
309 buildbot/test/test_vc.py: Add and use a Properties class,
310 refactor the way properties are rendered, and update unit
311 tests accordingly. (#124)
313 2008-04-12 Dustin J. Mitchell <dustin@zmanda.com>
315 * buildbot/master.py buildbot/status/builder.py: Remove unused
316 and undocumented customBuildProperties config. This did not
317 allow users to specify global properties; rather, it specified
318 descriptions for properties that were not used anywhere in
321 2008-04-11 Dustin J. Mitchell <dustin@zmanda.com>
323 * docs/buildbot.texinfo: fix typo (thanks to Christian Theune)
325 2008-04-04 Dustin J. Mitchell <dustin@zmanda.com>
327 * buildbot/clients/debug.py buildbot/master.py
328 buildbot/process/base.py: Patch by gward to teach
329 DebugPerspective and debugclient about custom build properties
332 2008-04-03 Dustin J. Mitchell <dustin@zmanda.com>
334 * buildbot/buildset.py buildbot/master.py
335 buildbot/process/base.py buildbot/scheduler.py
336 buildbot/scripts/runner.py buildbot/scripts/tryclient.py
337 buildbot/status/builder.py buildbot/status/web/builder.py
338 buildbot/steps/shell.py buildbot/steps/trigger.py: Patch
339 by Paul Gain, Roch Gadson <rochester.gadsdon@bakbone.com>,
340 and Aaron Maxwell <amax@snaplogic.org> to implement "custom
341 properties": build properties that can be specified when the
342 build is initially created, e.g., by a scheduler. (#87)
344 2008-04-03 Dustin J. Mitchell <dustin@zmanda.com>
346 * buildbot/status/web/base.py: Patch from Aaron Maxwell
347 <amax@snaplogic.org>. Refactor OneLineMixin.make_line(),
348 splitting in into two methods: one that gathers all the data
349 needed for a build (get_line_values), and one that takes that
350 data, and renders it into an HTML line (make_line). (#145)
352 2008-04-03 Dustin J. Mitchell <dustin@zmanda.com>
354 * buildbot/slave/commands.py: Patch from Aaron
355 Maxwell <amax@snaplogic.org>: introduce a method
356 SVN.getSvnVersionCommand() that returns the shell command used
357 to determine the svn version. Useful for subclassing. (#140)
359 2008-04-03 Dustin J. Mitchell <dustin@zmanda.com>
361 * buildbot/buildset.py buildbot/process/base.py
362 buildbot/scheduler.py buildbot/test/test_properties.py: Patch
363 by Dossy Shiobara <dossy@panoptic.com>: It is useful to know
364 the name of the scheduler that initiated a build request,
365 i.e., to conditionally FileUpload the results of a Nightly
366 scheduled build. This patch passes the Scheduler along the
367 BuildRequest chain so that Build can setProperty("scheduler",
368 self.scheduler.name) in Build.setupStatus(). (#227)
370 * docs/buildbot.texinfo: docs for same
372 2008-03-29 Brian Warner <warner@lothar.com>
374 * buildbot/__init__.py (version): Releasing buildbot-0.7.7
375 * docs/buildbot.texinfo: same
377 2008-03-29 Brian Warner <warner@lothar.com>
379 * NEWS: update with all changes since the last release. I left the
380 bugs-fixed section somewhat terse, but there's a link to the Trac
381 page with more details.
384 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
385 accept category= arguments in the query-arg portion of the URL.
386 These behave like the builder= queryargs: if any category=
387 queryargs are present, we'll only show Builders that fit into one
388 of the specified categories. Using multiple category= arguments
389 will show more Builders. Thanks to Jerome Davann (hollowman) for
390 the idea and the patch. Closes #117.
391 * docs/buildbot.texinfo (Buildbot Web Resources): document it
393 * buildbot/changes/svnpoller.py (SVNPoller.create_changes): pass
394 revision as a string, not an int. This fixes a problem in
395 MailNotifier, which expects a string. Thanks to Dan Locks for the
396 patch, and Dustin Mitchell for the test fixups. Closes #208.
397 * buildbot/steps/source.py (Source.commandComplete): treat
398 got_revision as a string too.
399 * buildbot/test/test_svnpoller.py: update test to match
400 * buildbot/test/test_vc.py: same
402 2008-03-27 Brian Warner <warner@lothar.com>
404 * buildbot/scripts/runner.py (doCheckConfig): patch from Ben
405 Hearsum to implement 'buildbot checkconfig': validate that your
406 master.cfg is good without actually touching the buildmaster.
408 * buildbot/scripts/checkconfig.py: same
409 * docs/buildbot.texinfo (Testing the Config File): document it
411 2008-03-22 Brian Warner <warner@lothar.com>
413 * buildbot/test/test_vc.py (Mercurial.serveHTTP): another attempt
414 to make Mercurial.testCheckoutHTTP not fail on heavily loaded
415 machines: avoid overlapping poll() calls.
417 * NEWS: preliminary list of changes for the upcoming release.
418 Needs editing and explanations.
420 * buildbot/status/web/base.py (make_stop_form): add a label=
421 argument so that the button says "Stop Builds" or "Stop Build" as
422 appropriate. It used to say "Stop Builder", which was wrong.
423 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
424 (OneBoxPerBuilder.body): same
426 * buildbot/process/builder.py (Builder): use self.old_building to
427 track Builds from a previous version of this Builder and are still
428 running. This makes it possible for IBuilderControl to get at
429 them, allowing the "Stop Build" button to work after a
430 Builder-replacing reconfig. Closes #22.
431 (Builder.consumeTheSoulOfYourPredecessor): grab weakrefs from the
432 old Builder's self.building attribute, instead of strongrefs,
433 since there's no good place to explicitly forget about them.
434 (Builder.getBuild): factor this out of BuilderControl
436 * buildbot/process/buildstep.py (LogLineObserver.setMaxLineLength):
437 new method to override the default 16KiB line length. Lines that
438 are longer than this will cause the rest of the log file to be
439 ignored. Thanks to Greg Ward for the patch. Closes #201.
440 * buildbot/test/test_buildstep.py: new tests for log observers
441 * docs/buildbot.texinfo (Adding LogObservers): document it
443 * buildbot/slave/commands.py (ShellCommand): record more
444 information in the 'header' section: how much we write into stdin,
445 do we close stdin, are we using a PTY. There are lingering
446 problems with PTYs and with closing stdin (see #198 and #158).
447 This doesn't fix those problems, but it should provide more
448 information to developers.
450 * buildbot/status/client.py: hush pyflakes, log.msg vs log
451 * buildbot/status/mail.py: same
453 * buildbot/locks.py (debuglog): hush pyflakes
455 * buildbot/steps/source.py (SVN.__init__): fix pyflakes: it
456 doesn't like a variable named 'warnings' that shadows the import
458 * buildbot/test/test_web.py: fix some pyflakes warnings, caused by
459 having a variable name shadow a top-level import
461 * buildbot/test/test_run.py (Disconnect.testBuild2): fix old
462 cut-and-paste typo that was causing us to run the wrong callback
464 * Makefile (pyflakes): sort+uniqify, since newer pyflakes isn't
465 smart enough to do this on its own
466 * buildbot/test/runutils.py (myGetProcessOutputAndValue): move this
467 method out from test_vc.py, hush pyflakes complaints
469 * buildbot/test/test_vc.py (Mercurial.serveHTTP): wait for the 'hg
470 serve' command to be ready, by polling with twisted.web's
471 client.getPage . Unfortunately mercurial doesn't flush its stdout
472 at startup, so we can't just wait for the 'listening at..' line to
473 be printed. This should fix the sporadic "connection refused" test
474 failures I've seen on the metabuildbot when the buildslave is
475 overloaded and 'hg serve' takes a while to start up.
477 * buildbot/steps/python_twisted.py (TrialTestCaseCounter): modify
478 regexp to count "Doctest:" lines as well as normal tests. Thanks to
479 Martin Geisler for the patch. Closes #196.
481 2008-03-20 Brian Warner <warner@lothar.com>
483 * buildbot/status/web/waterfall.py (CurrentBox.formatETA): apply
484 patch from TedMielczarek to display hours/minutes/seconds in the
485 ETA display. Thanks Ted! Also make 'next build starts in' box use
486 the same format. Closes #95.
488 * buildbot/process/buildstep.py (render_properties): more cleanup:
489 rename 'render' to 'render_properties'.
490 * buildbot/steps/shell.py: same
491 (ShellCommand._interpolateProperties): tolerate None in the value,
492 clean up the isinstance checks, stop using the 'types' module
494 * buildbot/steps/transfer.py (FileUpload.start): same, other cleanups
496 * buildbot/steps/shell.py (render): oops, remove redundant
497 definition that probably crept in during a merge conflict
499 * buildbot/scheduler.py (Triggerable): cleanup: wrap docstring
500 * buildbot/steps/trigger.py (Trigger): cleanup: rename schedulers=
501 to schedulerNames=, make updateSourceStamp=True by default, tolerate
502 missing got_revision property (i.e. if updateSourceStamp=True but
503 there was no checkout/update step run), add TODO notes for further
505 * buildbot/test/test_run.py (Triggers): update to match
506 * docs/buildbot.texinfo (Build Dependencies): same
508 * buildbot/slave/commands.py (SVN.doVCFull): merge Dustin's patch:
509 add --no-auth-cache option to svn invocations to avoid caching
510 buildbot's credentials. This also helps when users run a
511 buildslave from their personal account, to keep the buildslave
512 from clobbering their manually-provided svn password. Closes #188.
513 (SVN.doVCUpdate): do it for 'svn update' too.
515 * buildbot/steps/shell.py: merge Greg Ward's patch (via Dustin):
516 refactor WithProperties handling, allow WithProperties in more
518 * buildbot/process/buildstep.py: same
519 * buildbot/steps/transfer.py: same, allow WithProperties in filenames
521 * buildbot/steps/trigger.py: remove unused imports to hush pyflakes
523 * docs/buildbot.texinfo (Build Properties): fix up nodes+menus
525 2008-03-19 Brian Warner <warner@lothar.com>
527 * buildbot/status/web/xmlrpc.py (XMLRPCServer.xmlrpc_getAllBuilders):
528 merge Etienne Pierre's patch (via Dustin): add new XMLRPC methods.
529 (XMLRPCServer.xmlrpc_getStatus): same
530 (XMLRPCServer.xmlrpc_getLastBuilds): same, returns the last N
531 completed builds for a given Builder
533 * buildbot/test/test_config.py (ConfigTest.setUp): merge Dustin's
534 patch: suppress DeprecationWarnings in our tests of deprecated
535 features that aren't scheduled for removal quite yet. In the long
536 run, we'll remove the old features and the tests.
538 * NEWS: add a deprecation schedule
539 * buildbot/changes/freshcvsmail.py: remove this file, it was
540 replaced by mail.FCMaildirSource in the previous release.
542 * buildbot/test/runutils.py: set usePTY=False everywhere we aren't
543 explicitly testing =True, to avoid SIGHUP-based failures that I
544 now see about 10% of the time.
546 * buildbot/scheduler.py (Triggerable): merge Dustin's patch: add
547 "Triggerable" Schedulers, to start builds at specific phases of
548 other builds rather than in response to source code changes or
549 periodic timers. These phases are marked by "Trigger" steps, which
550 are configured with a list of Triggerable schedulers that they
551 should fire. Closes #56.
552 * buildbot/steps/trigger.py (Trigger): buildstep to match
553 * buildbot/test/test_run.py (Triggers): test for it
554 * docs/buildbot.texinfo (Build Dependencies): document it
555 (Triggering Schedulers): same
557 2008-03-18 Brian Warner <warner@lothar.com>
559 * buildbot/interfaces.py (ISourceStamp.getAbsoluteSourceStamp):
560 merge patch from Dustin to add "absolute source stamps": just like
561 normal SourceStamp instances except that they have a .revision
562 attribute copied out of the got_revision property of a build. If
563 the input SourceStamp says .revision=None (i.e. HEAD), and the
564 build is done when the tree is at r1234, then the "absolute"
565 SourceStamp should have .revision=1234 .
566 * buildbot/sourcestamp.py (SourceStamp.getAbsoluteSourceStamp): same
567 * buildbot/status/builder.py (BuildStatus.getSourceStamp): add
570 * buildbot/test/runutils.py (SetTestFlagStep): test utility class,
571 adding 'flags' that can be set by specific buildsteps. This makes
572 it easier to write tests that detect whether certain buildsteps
573 have been reached or not. Patch by Dustin Mitchell.
574 * buildbot/test/test_run.py (TestFlag.testTestFlag): test for it.
576 * buildbot/buildslave.py (BuildSlave.__repr__): protect against
577 .botmaster being empty, to allow pretty-printing of configuration
578 files before the twisted reactor starts. Patch from Dustin
581 * docs/buildbot.texinfo (Shutdown): make it clear that 'buildbot
582 reconfig' (which uses SIGHUP) doesn't work on windows. Acknowledge
583 the occasional failures in reconfig (and suggest 'buildbot
584 restart' as a fallback). Closes #105.
586 * buildbot/steps/shell.py (ShellCommand._interpolateProperties):
587 apply patch from Albert Hofkamp to allow WithProperties in
588 environment variables and the workdir= argument. Closes #52.
589 * buildbot/test/test_properties.py (Interpolate.testCustomBuildStep):
590 remove this test, it was pretty weird and didn't work with the
591 new _interpolateProperties approach.
593 * buildbot/test/test_vc.py (VCBase.connectSlave): turn off usePTY
594 for all slave commands: I'm seeing 'cp' and 'rm' fail with SIGHUP,
595 probably when we close stdin. This happens on my debian/sid
596 system, but not on older unixes, so I suspect some change in
597 behavior in the kernel or glibc or something similar.
599 2008-03-12 Dustin J. Mitchell <dustin@zmanda.com>
601 * buildbot/status/web/grid.py: Use "absolute" instead
602 of "specific" sourcestamps; thanks to Ivan Chelyubeev
603 <ivan.chelubeev@gmail.com> for providing the patch. (#72)
605 2008-02-17 Dustin J. Mitchell <dustin@zmanda.com>
607 Bug #72: the grid display
608 * buildbot/status/web/grid.py: new 'grid' display to complement waterfall
609 * buildbot/status/web/baseweb.py: add link to grid
610 * buildbot/status/web/build.py: add footer, fix redirects
611 * buildbot/status/web/builder.py: same
612 * buildbot/status/web/classic.css: grid styles
613 * buildbot/status/web/index.html: link to grid
614 * buildbot/status/web/waterfall.py: fix footer
616 2008-02-05 Brian Warner <warner@lothar.com>
618 * buildbot/buildslave.py (BuildSlave._missing_timer_fired): add a
619 To: header to the email message we're composing. Oops. Thanks
620 to Zandr Milewski for the catch.
621 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
624 2007-12-31 Brian Warner <warner@lothar.com>
626 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): remove
627 the short timeouts, these can cause false test failures on slow
628 systems, and were only needed while developing the recent patch
629 (Download.testLotsOfBlocks): same
631 * buildbot/scripts/reconfig.py (Reconfigurator.run): if we're on
632 windows, make 'buildbot reconfig' emit a warning message (since
633 there's no SIGHUP to be had) rather than just hanging. Addresses
634 #105, but we still need to document this somewhere. Thanks to
635 Ben Hearsum for the patch.
637 * buildbot/slave/commands.py (SlaveFileUploadCommand.start):
638 rewrite the main loop to avoid tail recursion, since Deferreds
639 don't optimize those out. Without this, at the end of the transfer
640 we'd hit a stack depth of about two or three frames per block
641 transferred, and for large transfers this would run into a "stack
642 depth exceeded" error. Closes #106.
643 (SlaveFileDownloadCommand.start): same, for downloads.
644 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): test it
645 (Download.testLotsOfBlocks): same
647 2007-12-22 Brian Warner <warner@lothar.com>
649 * buildbot/steps/shell.py (TreeSize): This never worked properly.
650 Fix it. Also, stash the tree size in a build property named
651 'tree-size-kb'. Note that this records size in KiB (1024 bytes),
652 not KB (1000 bytes), because that's what du will give us. This
654 * docs/buildbot.texinfo (TreeSize): document it
655 * buildbot/test/test_steps.py (TreeSize.testTreeSize): test it
657 * buildbot/steps/shell.py (WarningCountingShellCommand): utility
658 subclass which uses a regular expression to count warning messages
659 in the output. This also puts warning messages in a new 'warnings'
660 logfile, sets the 'warnings-count' build property with the total
661 count, and marks the step results as WARNINGS if there are any
662 warnings. Thanks to Roch Gadsdon (rochg) for the patch. Closes
664 (Compile): derive from WarningCountingShellCommand
666 * docs/buildbot.texinfo (Compile): document it
667 * buildbot/test/test_steps.py (Warnings): test it
669 * buildbot/slave/commands.py (ShellCommand._chunkForSend): don't
670 send more than 128kB of stdout/stderr/logfile text in a single PB
671 string, since PB has a hardwired limit of 640kB. This should fix
672 crashes that occur when the test process generates output very
673 very quickly. Patch by chops@demiurgestudios.com, thanks! I
674 haven't been able to reproduce this locally, but the potential bug
675 is clear. This should close #129.
677 2007-12-21 Brian Warner <warner@lothar.com>
679 * buildbot/scripts/startup.py (start): check to see if there's a
680 buildbot.tac before doing anything else. This improves the error
681 message when you do 'buildbot start' in the wrong directory.
683 * buildbot/scripts/logwatcher.py (LogWatcher.start): rewrite to
684 spawn /usr/bin/tail to follow the target's twistd.log . It turns
685 out that OS-X file EOF semantics are different, and the naive
686 read-then-read-again approach I was using doesn't work (the first
687 EOF we hit is sticky). tail gets it right, so rely upon it instead
688 of reimplementing the wheel. This should make 'buildbot start'
689 correctly follow the logfile on OS-X, thus closing #141.
691 2007-12-14 Brian Warner <warner@lothar.com>
693 * buildbot/steps/shell.py (ShellCommand.__init__): stash the
694 RemoteShellCommands args too, so things like 'workdir' and 'env'
695 and 'timeout' are preserved. This ought to fix #150.
696 * buildbot/test/test_steps.py (Steps.testClone): test it
698 2007-12-11 Brian Warner <warner@lothar.com>
700 * buildbot/scripts/startup.py (launch): use twisted.__version__,
701 rather than twisted.version, since the latter didn't appear until
702 Twisted-2.4.0 . This unbreaks 'buildbot start' on older Twisteds.
704 2007-12-08 Brian Warner <warner@lothar.com>
706 * docs/buildbot.texinfo (Git): document the fact that we require
707 Git 1.2.0 or later, and that the one shipped in dapper is too old.
709 * buildbot/scripts/startup.py (launch): twisted-2.5.0 and later
710 doesn't need twisted.scripts._twistw.run; instead, it uses
711 twisted.scripts.twistd.run on all platforms. Closes #53.
713 2007-11-30 Brian Warner <warner@lothar.com>
715 * buildbot/status/builder.py (BuilderStatus): small docs patches
716 from Greg Ward.. thanks!
717 * buildbot/process/base.py (Build): same
719 2007-11-29 Brian Warner <warner@lothar.com>
721 * buildbot/slave/commands.py (Mercurial._maybeFallback): add an
722 _abandonOnFailure call to the fallback, to skip the 'update' step
723 if the checkout fails.
724 (Mercurial._maybeFallback): More fixes: look for error messages
725 generated by every version of hg from 0.7 to the current 0.9.5,
726 including development versions as of rev 92991422a847. Also make
727 sure to return the exit code of non-fallbackable errors so that
728 other steps can attempt a workaround.
730 2007-11-28 Brian Warner <warner@lothar.com>
732 * buildbot/slave/commands.py (Mercurial._maybeFallback): improve
733 hg fallback so that it works when the client hg is new and the
734 server hg is old (the error message is different in this case).
736 2007-11-27 Brian Warner <warner@lothar.com>
738 * buildbot/test/test_p4poller.py: hush pyflakes warning
740 * buildbot/slave/commands.py (Mercurial._maybeFallback): when hg
741 is doing a 'clone' operation, to a remote repository (e.g. over
742 HTTP), and either the server or the client is hg-0.9.1 or older,
743 'hg clone' cannot accept a --rev argument: instead, you have to
744 clone the tip and then update back to the desired revision. Added
745 code to detect this failure mode and fall back to the clone+update
746 scheme. Closes #122 and #103.
747 (ShellCommand.__init__): add a keepStderr= flag to support this
749 * buildbot/test/test_vc.py (VCBase._do_vctest_clobber_2): add a
750 test that does a checkout to a specific version, to exercise the
751 mercurial limitation workaround.
752 (Mercurial.serveHTTP): add code to test hg checkout over HTTP,
753 using mercurial's built-in 'hg serve' command. Because of
754 limitations in hg, this code uses a randomly-selected TCP
755 port (rather than claiming a free one), so every once in a while
756 this test is going to fail because of a port-number collision.
758 * buildbot/test/test_vc.py (GitHelper.capable): skip Git tests if
759 the version of Git installed is older than 1.2.x . Git 1.1.3
760 doesn't accept 'git init' (it wants 'git init-db' instead) and the
761 branch tests fail. I know that Git 1.5.3.6 works. I don't know
762 what the dividing line is.. if someone can figure it out, please
763 update this check. Also, if someone can make buildbot's git
764 support handle older versions, please do that too! Addresses #130.
766 2007-11-21 Brian Warner <warner@lothar.com>
768 * lots: improve Git support, AMAZING patch from Haavard
769 Skinnemoen, complete with unit tests and docs, thanks! Closes #130.
770 * buildbot/scripts/tryclient.py (GitExtractor): add 'try' support
771 * buildbot/slave/commands.py (Git): accept branch and revisions,
772 and use 'git' instead of the 'cogito' wrapper
773 * buildbot/steps/source.py (Git.__init__): same
774 * buildbot/test/test_vc.py (BaseHelper.runCommand): offer control
776 (BaseHelper.do): same
777 (BaseHelper.dovc): same
778 (Git): unit tests for Git support. Wow!
779 * docs/buildbot.texinfo (Git): docs for Git support. Double Wow!
780 * contrib/git_buildbot.py: commit-hook script for git
783 * buildbot/changes/p4poller.py (P4Source._finished): don't let a
784 failure cause us to stop polling. Thanks to John Backstrand for
785 the patch. Closes #135.
786 * buildbot/test/test_p4poller.py (TestP4Poller.testFailedChanges):
788 (TestP4Poller.testFailedDescribe): same
790 * buildbot/status/web/waterfall.py (WaterfallStatusResource.body):
791 fix timezone calculation, we were always emitting DST, even in
792 winter. Thanks to Charles Lepple and John Saxton for the patch.
794 * buildbot/test/test_web.py (Waterfall.test_waterfall._check1): same
797 * lots: a whole batch of patches from Benoit Sigoure, referenced
798 in ticket #138. Thanks!
800 * buildbot/master.py (BuildMaster.loadConfig): builder names that
801 begin with an underscore are now reserved, so prohibit them from
802 appearing in the config file.
803 * NEWS: announce this change.
805 * buildbot/status/web/base.py: add buttons (to one_line_per_build
806 and one_box_per_builder) to force/stop builds on all Builders at
808 * buildbot/status/web/baseweb.py: same
809 (OneBoxPerBuilder.body): add links to the per-Builder page
811 * buildbot/status/web/builder.py: same
813 * buildbot/status/web/builder.py (StatusResourceBuilder.body):
814 factor out force/stop form generation
815 * buildbot/status/web/base.py: same
816 * buildbot/status/web/build.py: same
818 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
819 simplify some 'if' statements
820 (StatusResourceBuilder.build_line): add a 'Stop Build' button next
821 to the 'Force Build' button, so you can start and stop a build
823 (StatusResourceBuilder.force): redirect back to the waterfall,
824 rather than the index page
825 (StatusResourceBuilder.ping): same
826 * buildbot/status/web/build.py (StatusResourceBuild.stop): same
828 * buildbot/slave/bot.py (Bot.remote_setBuilderList): don't
829 consider the 'info' directory as a leftover directory. Patch from
830 Benoit Sigoure, ticket #138.
831 (others): remove trailing whitespace
833 2007-11-01 Brian Warner <warner@lothar.com>
835 * buildbot/status/web/builder.py (StatusResourceBuilder.build_line):
836 if there's no current step, don't try to display its description.
837 Same crash as in #96, this time in the web page. Closes #111.
839 * buildbot/status/web/base.py (OneLineMixin.make_line): tolerate
840 results == None (i.e. when the build hasn't finished yet);
841 previously this code exploded when trying to find a CSS class for
842 that results value. Patch from Greg Ward. Closes #118.
844 * buildbot/status/client.py (RemoteBuildStep.remote_getLogs):
845 IBuildStepStatus.getLogs() returns a list, not a dict. Patch from
846 Fabrice Crestois. Closes #121.
848 2007-10-31 Brian Warner <warner@lothar.com>
850 * buildbot/status/words.py (Contact.emit_status): if there's no
851 current step, don't try to display its description. This should
852 fix the crash when asking the irc bot about builds which are
853 waiting for a build-wide Lock. Closes #96.
855 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
856 'columnName' argument, from a patch by Ben Hearsum. Closes #120.
858 2007-10-16 Brian Warner <warner@lothar.com>
860 * buildbot/status/web/slaves.py (BuildSlavesResource.body): fix
861 timestamp, I was using %M (minutes) where I meant to be using
862 %b (abbreviated month name). Closes #109.
864 2007-10-13 Brian Warner <warner@lothar.com>
866 * README (COPYING): make it clear that buildbot is distributed under
868 * COPYING: add a copy of the GPLv2 to the source tree
869 * MANIFEST.in: .. and to the source distribution too
871 2007-10-10 Brian Warner <warner@lothar.com>
873 * buildbot/status/builder.py (Status.getURLForThing): update this
874 to match new URL layout, I completely forgot about it. Closes #112.
875 * buildbot/test/test_web.py (GetURL): add unit tests
877 * buildbot/status/web/build.py (BuildsResource.getChild): fix
878 silly typo which prevented the Build page from ever offering
879 control options like 'Stop Build'. Thanks to Aaron Hsieh for the
881 * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd
884 * buildbot/__init__.py (version): bump to 0.7.6+ while between
886 * docs/buildbot.texinfo: same
888 2007-09-30 Brian Warner <warner@lothar.com>
890 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
891 * docs/buildbot.texinfo: same
893 2007-09-30 Brian Warner <warner@lothar.com>
895 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
896 * setup.py: install all test files from buildbot/test/mail/* . Also
897 update URL to point at buildbot.net
898 * MANIFEST.in: update with new files
900 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
901 auto-create an empty public_html directory, otherwise we get
902 internal server errors instead of 404s.
904 * README: reference buildbot.net, remove CVSToys section (does
905 anyone still use it?)
907 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
908 message when public_html/ is missing (indicating that you should
909 probably run 'upgrade-master'), and don't auto-create an empty
910 directory in that case.
912 * contrib/darcs_buildbot.py: refactor internals a bit, make it
913 possible to use as an importable module (to make it easier to
914 write some unit tests for it)
916 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
917 DeprecationWarning for Waterfall, advising users to switch over to
920 * NEWS: update with user-visible changes since the last release
922 * buildbot/status/web/waterfall.py
923 (WaterfallStatusResource.get_reload_time): if the suggest a
924 reload time of less than 15 seconds, give them 15 seconds instead
925 of ignoring their request entirely, because that'd be confusing.
927 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
928 warning if we must invoke the last-change-is-most-recent guess
930 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
931 Waterfall is running in an upgraded master (which is the usual
932 case for folks who have followed the instructions to run
933 'upgrade-master' but who have not yet resolved all the
934 DeprecationWarnings), prefer the buildbot.css from public_html/
935 rather than the one passed in on the buildbot= argument.
936 Otherwise, the resulting pages don't quite use CSS right..
937 sometimes it works, sometimes it doesn't, and I don't know why.
938 Sites that are using custom CSS will see the default CSS until
939 they modify public_html/buildbot.css to include their
942 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
943 * buildbot/status/web/robots.txt (Disallow): update to cover all
944 dynamically-generated pages
946 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
947 include both 'trunk' and None in the output list, since some VC
948 systems (SVN, frequently) refer to trunk as 'trunk'.
950 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
951 point the 'welcome' link explicitly at index.html, rather than
952 '.', so that old Waterfall users can reach it and discover all the
955 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
956 build's text to the end of the line, without a CSS class so it
959 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
960 'max_search=' argument, to limit the number of builds that are
961 examined while trying to find ones that match the other criteria.
962 This helps to limit the work we do, since otherwise we might have
963 to trawl through all history.
964 (IBuilderStatus.generateFinishedBuilds): same
965 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
966 (BuilderStatus.generateFinishedBuilds): same
968 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
969 our got_revision before checking its length: SVN (at least) still
970 reports numeric values for this.
971 * buildbot/status/web/build.py (StatusResourceBuild.body): same
972 * buildbot/status/web/xmlrpc.py
973 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
974 serving a completely fake revision
976 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
977 basedir to sys.path, to mimic what a real buildmaster would have
978 access to, since it is common for master.cfg to import helper
979 classes from .py files in the buildmaster directory, and we want
980 config-file checking to accomodate this.
982 * buildbot/status/web/base.py (map_branches): when referring to
983 branches through WebStatus (i.e. by appending ?branch=FOO query
984 arguments to the URL), make "trunk" mean trunk, by mapping it to
985 None before passing it to generateFinishedBuilds() and the like.
986 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
987 (OneBoxPerBuilder.body): same, also improve display of branches in
989 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
990 (WaterfallStatusResource.buildGrid): same. Note that this filters
991 Changes as well as Builds.
992 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
993 caveat about trunk branches, now that it's fixed
995 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
996 from builder.py, use it on the Builder page too
998 * buildbot/status/web/builder.py (StatusResourceBuilder): same
999 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
1000 names, add some CSS classes
1001 * buildbot/status/web/classic.css (td.box): new class, for
1004 * docs/buildbot.texinfo (WebStatus): update docs
1006 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
1007 the trailing "M" indicator that tells us this is a modified file.
1008 This should help with mode="update" builds that modify files
1009 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
1012 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
1013 new copies of files (to .new) when those files already exist,
1014 check the master.cfg file for errors (and give DeprecationWarnings
1015 a chance to be displayed).
1016 * buildbot/test/test_runner.py: add more tests
1017 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
1019 2007-09-29 Brian Warner <warner@lothar.com>
1021 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
1022 the revision id from the last change in our list, since that's the
1023 best we can do without knowing the full ancestry graph. Closes #103.
1025 * buildbot/scripts/sample.cfg: use buildstep instances in
1026 f.addStep, to demonstrate the (correct) modern usage.
1027 * docs/examples/hello.cfg: bring this up to date. Closes #79.
1028 * docs/examples/twisted_master.cfg: add a big warning about how
1030 * docs/examples/glib_master.cfg: delete this one entirely, it is
1031 ancient and not a very useful example anyways
1033 * buildbot/status/web/base.py (HtmlResource.render): keep track of
1034 HTTPChannels, so we can shut them down at reconfig time (when the
1035 WebStatus goes away). Closes #102.
1036 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
1037 (WebStatus.registerChannel): same
1038 (WebStatus.stopService): do .loseConnection() here
1040 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
1041 WebStatus, make sure all pages are still retrievable. I thought
1042 this would exercise a bug, but it turns out that it was firefox
1043 caching connections (and continuing to talk to the old WebStatus
1044 even though I'd loaded a new one).
1045 * buildbot/status/web/baseweb.py (WebStatus): add some comments
1046 (WebStatus.__repr__): include id() in the repr
1048 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
1049 this to specify an errorparser. From Ted Mielczarek and the
1050 mozilla crew. Closes #94.
1052 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
1053 bonsaipoller ignore funkyness in xml output for empy log
1054 messages", from Axel Hecht. Closes #90.
1055 * buildbot/test/test_bonsaipoller.py
1056 (TestBonsaiPoller.testMergeEmptyLogMsg): same
1058 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
1059 respect 'builders' arg, from Ben Hearsum. Closes #89.
1061 * buildbot/scripts/runner.py (stop): increase the timeout from 5
1062 seconds to 10, to give heavily loaded machines a better chance to
1063 finish shutting down. Addresses (partially) #68.
1064 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
1066 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
1067 * buildbot/scripts/startup.py (Follower._failure): update message
1069 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
1070 team, to fix some bugs and avoid the use of blocking urlopen().
1072 * buildbot/test/test_bonsaipoller.py: same
1074 2007-09-28 Brian Warner <warner@lothar.com>
1076 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
1077 argument, to send email about buildslaves which are disconnected
1078 for more than an hour. Closes #64.
1079 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
1081 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
1082 (MailNotifier): add docs for this too
1085 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
1086 respect branch= queryargs, by restricting the builds displayed to
1087 those matching the given branch names
1088 * buildbot/status/web/waterfall.py (BuildTopBox): same
1090 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
1091 fix a test failure by adding .prepath to this fake object
1093 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
1094 up generation of relative URLs. With luck, this should play with
1095 reverse proxies much better now.
1096 * buildbot/test/test_webparts.py: new test for most of the subpages
1097 * buildbot/test/test_web.py (base_config): add enough of a config
1098 to exercise more Waterfall code
1100 2007-09-27 Brian Warner <warner@lothar.com>
1102 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
1103 relative URL to the buildbot welcome page, rather than
1105 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
1107 * buildbot/status/web/base.py (HtmlResource.title): change the
1108 default title of all Buildbot-generated page to "Buildbot"
1109 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
1110 change the title to include the Builder name
1111 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
1112 same, and also show the build number
1113 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
1114 redirect the browser to the Builder page
1116 2007-09-26 Brian Warner <warner@lothar.com>
1118 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
1119 problem with the build links
1121 2007-09-25 Brian Warner <warner@lothar.com>
1123 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
1124 to emit relative URLs instead of using URLPath,
1126 * docs/buildbot.texinfo (WebStatus): provide an example
1128 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
1129 page, shows a simple table with one row per Builder. Still pretty
1130 ugly, but functional.
1131 * buildbot/status/web/index.html: reference it
1133 * buildbot/status/web/waterfall.py (Spacer): make this *not*
1134 inherit from builder.Event, so that show_events=false doesn't hide
1135 spacers, since that would make the waterfall weirdly compressed.
1137 * buildbot/status/web/waterfall.py (HELP): put the View button in
1138 its own section, so it doesn't get visually confused with the
1139 reload-timer section
1140 (WaterfallStatusResource.body): make the '[help]' links more
1141 visually distinct from each other, and add a link to the Welcome
1143 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
1144 unused buildslaves without exploding
1146 * buildbot/status/web/waterfall.py
1147 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
1148 it gives us absolute paths that break proxies
1149 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
1150 this, it was giving bad results when the Waterfall is behind a
1153 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
1154 new 'upgrade-master' command, which will bring an old buildmaster
1155 directory up-to-date. Right now the only thing it does is populate
1156 public_html/ if it wasn't already there. Still to do: check the
1157 other files, add documentation.
1158 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
1159 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
1161 2007-08-13 Brian Warner <warner@lothar.com>
1163 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
1164 that contains the checkin comments when you hover over the entry
1165 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
1168 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
1171 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
1172 page with versions of python, buildbot, and twisted
1173 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
1174 * buildbot/status/web/index.html: add links to most pages
1175 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
1177 * buildbot/status/web/robots.txt: put a robots.txt in new installs
1178 which discourages robot access to all large dynamically-generated
1179 pages. The intention is that the index page and the 'about' page
1180 are the only ones which should be crawlable.
1181 * buildbot/scripts/runner.py (Maker.public_html): same
1182 (createMaster): same
1183 * setup.py: ship index.html and robots.txt in source distributions
1185 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
1186 activate automatic reloading of the page (using a meta Refresh:
1188 (WaterfallHelp): new page to explain all the nifty query arguments
1189 you can use on the Waterfall, along with forms to set them for
1190 you. From this page, you can add filters for builder=, branch=,
1191 show_events=, as well as turning on reload=.
1192 (WaterfallStatusResource.buildGrid): new query args: last_time=,
1193 first_time=, show_time=, num_events= . The old show= is still
1194 accepted, but the new builder= is preferred. We ignore empty
1195 branch= arguments, to make the WaterfallHelp form easier to
1197 (WaterfallStatusResource.head): new method to add text to the
1199 * buildbot/status/web/base.py (HtmlResource.content): use head()
1200 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
1201 empty branch= arguments
1202 (OneLinePerBuildOneBuilder.body): same
1204 2007-08-12 Brian Warner <warner@lothar.com>
1206 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
1207 new query args: 'last_time' is a timestamp of the top-most event
1208 on the display, 'first_time' is a timestamp for the bottom-most
1209 event. 'show_time' is the difference between them, and overrides
1210 'first_time'. 'num_events' puts an upper limit on the number of
1211 timestamps that will be displayed on the left hand edge.
1212 (WaterfallStatusResource.body): add a 'next page' link to the
1213 bottom, which shows the events that come just after those shown on
1214 the current page. This is a first step towards #67, but we need
1215 some more controls before we can close that one.
1217 * buildbot/buildslave.py (BuildSlave): these are now MultiService
1218 instances too, and live as children of the BotMaster. The main
1219 advantage of this approach is that BuildSlaves can know when they
1220 are being removed (so they can shut off the upcoming
1221 when-do-we-email-an-admin-because-we-lost-our-slave timer).
1222 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
1223 identify which service children are BuildSlaves
1224 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
1225 Checker updates here, but delegate the rest to..
1226 (BotMaster.loadConfig_Slaves): .. here, which looks at the
1227 BotMaster's service children to identify the old slaves. I think
1228 the previous approach of using master.slaves was broken in the
1229 face of config updates that modified BuildSlave instances but did
1230 not completely replace them.
1231 * docs/buildbot.texinfo (Developer's Appendix): note the change to
1232 the Service hierarchy
1234 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
1235 page (at URL /buildslaves/) to view status of all buildslaves at
1236 once, including how long it's been since we last heard from them,
1237 and which Builders use them.
1239 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
1242 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
1243 list all buildslaves
1245 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
1246 use the BuildSlave to keep track of the last time we've heard from
1247 the buildslave. This is updated upon receipt of any message from
1248 any SlaveBuilder (which generally means when RemoteCommands are
1249 giving us status updates, as BuildSteps run). In the future this
1250 will include slave pings too.
1251 * buildbot/process/base.py
1252 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
1253 * buildbot/process/buildstep.py:
1254 (BuildStep.setBuildSlave): accept that reference
1255 (BuildStep.runCommand): pass the reference on to the RemoteCommand
1256 (RemoteCommand.remote_update): update the timestamp
1257 (RemoteCommand.remote_complete): same
1258 * buildbot/test/runutils.py (StepTester.makeStep): match the change
1259 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
1260 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
1261 interface to retrieve this timestamp
1262 * buildbot/status/builder.py (SlaveStatus): track a copy of the
1266 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
1268 (OneLinePerBuild.body): use a <ul> instead of <div>s
1269 (OneLinePerBuildOneBuilder.body): same
1271 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
1272 by adding the file's new name to the list of changed files. This
1273 ought to be sufficient for things like isFileImportant and trial
1274 tests that only exercise tests for files that have been modified.
1277 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
1278 XMLRPC server to the WebStatus page. This only has two methods
1279 right now (getAllBuildsInInterval and getBuild), but we'll be
1280 adding more in the future. This server is extracted from the
1283 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
1284 generateFinishedBuilds, and improve the data displayed.
1285 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
1286 the per-Build page, add some information like ETA and got_revision
1287 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
1288 adding a list of recently completed builds
1289 * buildbot/status/web/base.py (css_classes): factor this out
1291 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
1292 new method, to make status display classes easier to write,
1293 especially the WebStatus 'one_line_per_build' page.
1294 (IBuilderStatus.generateFinishedBuilds): same
1295 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
1296 (Status.generateFinishedBuilds): implement it
1298 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
1299 'source' to be a BuildStep instance, since BuildFactory accepts
1301 (CPAN.__init__): same
1302 (Distutils.__init__): same
1303 (Trial.__init__): same
1305 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
1306 this might raise KeyError
1308 2007-08-07 Brian Warner <warner@lothar.com>
1310 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
1311 'Owner:' field of the view, rather than 'p4logname', since
1312 p4logname comes from the buildslave's environment and seems
1313 unlikely to ever do the right thing. Thanks to Wade Brainerd for
1314 the patch. Closes #40.
1316 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
1317 which imposes a per-slave limit on how many builds are allowed to
1318 run simultaneously. This has a the same scope than the SlaveLock,
1319 but is different because max_builds= gives the buildmaster the
1320 freedom to assign the build to a different slave, whereas the
1321 SlaveLock doesn't get tested until after the build is irrevocably
1322 assigned to a slave. Therefore using max_builds= will improve
1323 utilization in the presence of multiple buildslaves that are
1324 attached to the same Builder. This completes the incorporation of
1325 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
1326 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
1327 any Builder finishes, potentially trigger *all* Builders, since
1328 max_builds= may have stalled someone else while waiting for the
1330 * buildbot/scripts/sample.cfg: mention max_builds=
1331 * buildbot/test/test_run.py (ConcurrencyLimit): test it
1332 * docs/buildbot.texinfo (Buildslave Specifiers): document it
1334 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
1335 inherit from RunMixin do not need to call master.stopService()
1336 themselves, since RunMixin.tearDown does that. The double call
1337 fails on Twisted-2.0.x, which didn't happen to protect against it.
1338 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
1340 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
1341 from #48, this one to have the BuildSlave objects track
1342 SlaveBuilders, so they'll be able to use that knowledge to
1343 influence their canStartBuild() response.
1344 * buildbot/process/builder.py (SlaveBuilder.attached): call it
1345 (SlaveBuilder.detached): same
1346 * buildbot/test/test_slaves.py (BuildSlave): test it
1348 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
1349 the second of Dustin's #48 patches, this one adding a method to
1350 the BuildSlave that allows it to decide whether it is willing to
1351 participate in a build or not.
1352 (SlaveBuilder.isAvailable): use canStartBuild() to decide
1354 * buildbot/test/test_run.py (CanStartBuild): test for it
1356 * all: incorporate the first of four patches by Dustin Mitchell
1357 from ticket #48, working towards improving control over slave
1358 concurrency. The first patch is to use a long-lived BuildSlave
1359 object per slave, on which other behavior can be added later. I've
1360 modified his patch considerably.
1361 * buildbot/buildslave.py (BuildSlave): move class out of
1362 slave/__init__.py (where it would get loaded by the slave as well
1363 as the master, making dependencies trickier), and merge it with
1364 BotPerspective. Now these BuildSlave instances are created once in
1365 the master.cfg file, and not destroyed until they are either
1366 removed from the config file or changed so
1367 much (name/password/class changes) that we cannot continue to use
1368 the old one. This affects config files: they must use
1369 'from buildbot.buildslave import BuildSlave' instead of using
1370 'from buildbot.slave import BuildSlave'.
1371 * buildbot/master.py: move BotPerspective out
1372 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
1373 add or remove as necessary, update the rest using data from
1374 the new config file.
1375 * buildbot/slave/__init__.py: move BuildSlave out
1376 * buildbot/test/test*.py: import BuildSlave from the new place
1377 * buildbot/scripts/sample.cfg: update to match
1378 * docs/buildbot.texinfo: update to match
1379 * buildbot/process/builder.py: update comments to match
1381 2007-08-02 Brian Warner <warner@lothar.com>
1383 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
1384 one-line-per-build pages a bit, add a header, refactor slightly
1386 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
1387 the TimeOutError timer, patch by Dustin Mitchell.
1389 2007-08-01 Brian Warner <warner@lothar.com>
1391 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
1392 mostly work (branch= is still ignored, we need a useful header)
1393 (OneLinePerBuildOneBuilder.body): this too
1395 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
1396 bring this up-to-date w.r.t. recent refactorings, and fix
1397 redirections to bounce the browser to the top page after hitting
1398 the 'force' button. This needs to be improved, but at least it now
1399 redirects to a valid page.
1400 (StatusResourceBuilder.ping): same
1401 (StatusResourceBuilder.getChild): same, although I think this code
1402 might be dead anyways
1404 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
1405 a branch= query argument, to filter the display down to builds and
1406 changes that involve the given branch. You can add multiple
1407 branch= arguments to see multiple branches (using a logical OR).
1408 Note that there is no way to include the default branch (i.e.
1409 None, i.e. trunk) yet, there is still work to be done to allow for
1410 simple+uniform names of branches (i.e. removing the VC-specific
1411 details of how branches are implemented, so calling the branch
1412 'beta4' even though the SVN checkout step requires
1414 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
1415 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
1416 * buildbot/interfaces.py (IEventSource.eventGenerator): same
1417 * docs/buildbot.texinfo (Buildbot Web Resources): document it
1419 * all: bring import statements up-to-date: don't import
1420 __future__, assume cPickle and cStringIO are always available.
1421 Also remove #!/usr/bin/python lines from non-scripts, my editor
1422 has been a bit over-enthusiastic about stuffing them into new .py
1425 * buildbot/status/web/index.html: put a link to the waterfall page
1426 on the index, otherwise first-time users of WebStatus aren't going
1427 to see anything very interesting.
1429 * buildbot/interfaces.py (IEventSource): document this interface.
1430 Thanks to Dustin Mitchell for the patch. Closes #60.
1431 * buildbot/status/builder.py (BuilderStatus): same
1432 * buildbot/changes/changes.py (ChangeMaster): same
1434 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
1435 add a query arg of 'show_events=true' to display non-build events,
1436 like slaves attaching/detaching and reconfig events, or
1437 'show_events=false' to hide them. The default is 'true'.
1438 * docs/buildbot.texinfo (Buildbot Web Resources): document it
1440 * web-parts: merge in web-parts branch. Lots of changes. The new
1441 functionality is to add buildbot.status.html.WebStatus, which is a
1442 superset of the Waterfall that adds new status pages and serves
1443 regular files from BASEDIR/public_html/ , which is now the preferred
1444 place to put robots.txt, buildbot.css, and index.html .
1445 * buildbot/scripts/runner.py: the 'create-master' command now
1446 creates public_html/ too, and populates it with a couple of
1448 * buildbot/status/web: split waterfall code into smaller pieces
1450 2007-07-31 Brian Warner <warner@lothar.com>
1452 * buildbot/scripts/startup.py (launch): import twistd.run in a
1453 different way to hush pyflakes
1454 * buildbot/process/builder.py: remove unused import
1456 2007-07-30 Brian Warner <warner@lothar.com>
1458 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
1459 Mitchell: pass SourceStamps around rather than branch/version/etc
1460 tuples. Thanks Dustin! Closes #70.
1461 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
1462 tuple rather than a list, to avoid surprising mutations
1463 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1464 * buildbot/status/mail.py (MailNotifier.buildMessage): same
1465 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
1466 * buildbot/test/test_status.py (Subscription): same
1467 * buildbot/test/test_control.py (Force): same
1468 * buildbot/test/test_buildreq.py (Request.testMerge): same
1470 2007-07-29 Brian Warner <warner@lothar.com>
1472 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
1473 variable, since it wasn't used and is confusing in the presence of
1474 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
1477 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
1478 the Buildbot home-page link to point at buildbot.net instead of
1479 sourceforge, and add a current-version query parameter so we can
1480 get some statistics on which versions are in use out there.
1482 2007-07-28 Brian Warner <warner@lothar.com>
1484 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
1485 with c['change_source'], leaving c['sources'] for backwards
1486 compatibility (but deprecated), scheduled for removal in 0.8.0
1487 * docs/buildbot.texinfo: same
1488 * buildbot/test/test_config.py: verify that c['sources'] still works
1489 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
1490 * buildbot/scripts/sample.cfg: update to match
1492 * buildbot/changes/mail.py (MaildirSource): parse with python's
1493 stdlib 'email' module, which has been available since python2.2,
1494 and drop use of the 'rfc822' module, which has been depreceated
1496 * buildbot/test/test_maildir.py: same: use parse_file() not parse
1498 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
1499 this needs to match the renaming in test/mail/msg*
1501 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
1504 * buildbot/test/test_mailparse.py: rename sample emails a bit
1505 * buildbot/test/mail/msg*: same
1507 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
1508 parser for the "commit-email.pl" script that is shipped with SVN,
1509 written by Justin Mason. Thanks! Closes SF#1072845.
1510 * buildbot/test/mail/svn-commit.*: sample messages
1511 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
1512 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
1514 2007-07-27 Brian Warner <warner@lothar.com>
1516 * buildbot/changes/mail.py: refactor: move parsing into a method
1517 named 'parse', each parser type gets a separate subclass. Remove
1518 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
1519 to be a simple leading-substring match. Add a warning to the logs
1520 if prefix= does not end in a slash, since that's probably a
1521 mistake. Fix both places where a prefix= mismatch would skip all
1522 subsequent files in the same email, instead of just skipping the
1523 one that didn't match.
1524 * buildbot/test/test_mailparse.py: match changes
1526 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
1527 docs on email-based ChangeSources
1529 * docs/buildbot.texinfo (Getting Source Code Changes): move all
1530 the changesource types up a level, removing the one-entry menu in
1533 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
1534 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
1535 instances instead of tuples. Closes #63.
1536 * buildbot/slave/__init__.py (BuildSlave): define marker class
1537 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
1538 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
1539 * buildbot/test/test_*.py: update tests to match
1540 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
1541 the c['bots'] backwards-compatibility handler works
1543 2007-07-26 Brian Warner <warner@lothar.com>
1545 * buildbot/changes/hgbuildbot.py (hook): add an in-process
1546 Mercurial change-sending hook, contributed by Frederic Leroy.
1547 Thanks! Addresses #50.
1548 * docs/buildbot.texinfo (MercurialHook): document it
1550 * buildbot/changes/hgbuildbot.py: change the way imports are done,
1551 to make it compatible with at least hg-0.9.1 and the current 0.9.4
1553 2007-07-17 Brian Warner <warner@lothar.com>
1555 * buildbot/process/buildstep.py (BuildStep.getLog): add a
1556 convenience method to retrieve a log added with
1557 addLog()/addCompleteLog()/etc or logfiles= . I should have added
1558 this two years ago..
1560 2007-07-03 Brian Warner <warner@lothar.com>
1562 * buildbot/slave/commands.py (ShellCommand._startCommand): when
1563 logging the environment variables, put one variable on each line,
1564 rather than having one really long line with all of them. This
1565 should make them a bit more readable and not trigger the
1566 horizontal scrollbar (when viewing it in a web browser) quite so
1567 much. Thanks to Albert Hofkamp for the patch.
1569 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
1570 WithProperties instance. Thanks to Axel Hecht for the patch.
1572 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
1573 * docs/buildbot.texinfo (Build Properties): document it
1574 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
1575 workdir if it didn't already exist.
1577 * docs/buildbot.texinfo (Scheduler Types): correct the description
1578 of Dependent schedulers. Thanks to Greg Ward for the patch.
1580 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
1581 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
1582 the patch. Closes #49.
1584 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
1585 0700 before removing it, to deal with situations where a build will
1586 leave files around without write permissions and the 'copy' or
1587 'clobber' VC checkout modes need to blow away the tree first.
1588 Thanks to Steve Milner for the suggestion and the patch (which I
1589 mangled horribly). Closes #29.
1590 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
1593 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
1594 an allowReconnect= argument to let callers control whether they
1595 want this don't-let-it-reconnect behavior, since some tests care.
1596 Factor out the .continueTrying=False lines from those callers.
1597 * buildbot/test/test_slaves.py: same
1598 * buildbot/test/test_run.py: same
1600 2007-07-02 Brian Warner <warner@lothar.com>
1602 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
1603 slave has been disappeared, don't let it reconnect. This was
1604 causing an intermittent failure in test_slaves.py, when the slave
1605 that was supposed to be gone managed to come back by the end of
1606 the test and affect the count.
1607 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
1609 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
1610 diagnostic messages to track down this problem
1611 (Builder.startBuild): same
1613 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
1614 the slave randomly rather than always taking the first one. Thanks
1615 to Pike for the patch. Closes #36.
1616 * buildbot/test/test_slaves.py: match the change. to avoid huge
1617 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
1618 enables/disables the round-robin-ness (enabled by default), and
1619 some unit tests disable it.
1620 * docs/buildbot.texinfo (Buildmaster Architecture): document it
1622 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
1623 argument to 'buildmaster_host', to make it more obvious that this
1624 points to the buildmaster. Thanks to Bob Proulx for the
1626 * buildbot/scripts/runner.py (slaveTAC): same
1627 * buildbot/test/test_runner.py (Create.testSlave): match the change
1629 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
1632 2007-06-17 Brian Warner <warner@lothar.com>
1634 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
1635 we can round-trip all of our current step classes by calling
1636 getStepFactory() and using the results to make a clone of the
1639 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
1642 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
1643 the config file, we're moving to using actual instances instead of
1644 the (class, kwargs) 'step specification' tuples. BuildFactory
1645 still keeps a list of tuples internally, but when real instances
1646 are passed in to addStep(), they are asked for their class and
1647 kwargs using the new BuildStep.getStepFactory method. BuildFactory
1648 accepts both instances and the tuple form, and converts instances
1649 to the tuple form, but the instance form is preferred because it
1650 gives the Steps a chance to do argument validation. Closes: #11.
1652 * buildbot/process/buildstep.py (BuildStep.__init__): record the
1653 factory information necessary to implement getStepFactory. The
1654 addFactoryArguments() method can be used to include arguments that
1655 aren't passed to the BuildStep base class constructor.
1656 (BuildStep.setBuild):
1657 (BuildStep.setDefaultWorkdir): new methods to take parameters that
1658 are needed for live BuildSteps but not to construct the specification
1659 tuples that are stashed in the factory.
1661 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
1662 'workdir' into new BuildSteps by using methods instead of
1663 arguments. This makes the constructor for BuildSteps a lot
1666 * buildbot/steps/*.py: update to match this change. Basically this
1667 means adding calls to addFactoryArguments() in the __init__
1668 methods to capture the arguments that aren't passed through to the
1670 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
1671 the new workdir (if any) into the RemoteShellCommands arguments.
1672 * buildbot/steps/source.py: allow workdir= to be optional,
1673 implement setDefaultWorkdir() since we don't inherit from
1674 (CVS): finally remove old clobber=/export=/copydir= arguments,
1675 in favor of the mode= argument that's been around forever now.
1676 * buildbot/steps/transfer.py: remove build= argument
1678 * buildbot/test/*.py: update to match, generally by turning all
1679 build= arguments into subsequent calls to s.setBuild()
1680 * buildbot/test/test_config.py (Factories): verify that we can
1681 use either BuildStep instances or class/kwarg tuples in both
1682 BuildFactory.addStep and BuildFactory.__init__
1684 * docs/buildbot.texinfo (Build Steps): document the new approach,
1685 mention compatibility with the old approach, update all examples
1686 to use the new style.
1688 2007-06-16 Brian Warner <warner@lothar.com>
1690 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
1691 the LoopingCall, just eat the failure so that we'll poll again
1692 next time. This should allow us to tolerate (e.g.) sf.net SVN
1693 failures more gracefully. Many thanks to Dustin Mitchell for the
1696 2007-05-17 Brian Warner <warner@lothar.com>
1698 * buildbot/status/words.py: refactor the IRC status bot into
1699 separate 'Contact' and 'Channel' classes. The base Contact class
1700 contains the interaction code: commands and responses. The
1701 IRCContact subclass (and IrcStatusBot 'Channel') handle the
1702 IRC-specific aspects. The plan is to write other subclasses for
1703 other IM protocols like AIM and Jabber.
1705 2007-04-16 Brian Warner <warner@lothar.com>
1707 * CREDITS: update list of contributors. Thank you all!
1709 2007-04-13 Brian Warner <warner@lothar.com>
1711 * buildbot/status/mail.py (MailNotifier): add the project name to
1712 the subject line and message body, to make it easier to
1713 distinguish email coming from different buildmasters. Thanks to
1714 Benoit Sigoure for the patch.
1715 * buildbot/test/test_status.py (Mail): update to match
1717 2007-03-24 Brian Warner <warner@lothar.com>
1719 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
1720 avoid text-conversion problems between DOS/windows and unix.
1721 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
1723 2007-03-03 Brian Warner <warner@lothar.com>
1725 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
1726 warning about the use of Waterfall here
1728 2007-03-01 Brian Warner <warner@lothar.com>
1730 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
1732 2007-02-28 Brian Warner <warner@lothar.com>
1734 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
1735 Lamb to use a more optimal form of 'p4 changes', to reduce server
1736 load. He reports that this optimization was added to p4d release
1737 2005.2, but it should work in all versions. Closes #27.
1738 * buildbot/test/test_p4poller.py: match it
1740 2007-02-27 Brian Warner <warner@lothar.com>
1742 * buildbot/status/web/*.py: move all web status stuff into a
1743 separate directory, in anticipation of splitting it into smaller
1744 pieces and adding more files. html.py was getting way too big.
1745 * buildbot/status/classic.css: move it too
1746 * setup.py: add the new sub-package
1747 * buildbot/test/test_web.py: match the changes
1748 * MANIFEST.in: handle the move of classic.css
1750 2007-02-07 Brian Warner <warner@lothar.com>
1752 * contrib/OS-X/*: add some launchd .plist files for automatically
1753 starting a buildmaster or buildslave under OS-X (10.4 or later).
1754 Thanks to Mark Pauley for these.
1756 2007-02-06 Brian Warner <warner@lothar.com>
1758 * docs/buildbot.texinfo (Requirements): update requirements to
1759 stop claiming compatibility with python-2.2 or twisted-1.3.x .
1761 * README: mention python-2.5 and twisted-2.5 compatibility
1763 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
1765 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
1767 * buildbot/status/builder.py: same, by requiring cStringIO
1768 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
1769 * buildbot/test/test_vc.py: same
1770 * buildbot/test/test_web.py:
1771 * buildbot/test/test_steps.py: same, remove unused import
1773 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
1776 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
1777 see any Builders that don't have Schedulers to drive them
1779 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
1780 attributes this uses went away
1782 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
1783 dialog, to allow you to reset the buildmaster and force
1784 connect/disconnect. Correctly handle losing the buildmaster
1785 connection (by switching the display to the hexnut, at which point
1786 you can use the 'Connect' menu item to reconnect).
1788 * buildbot/steps/source.py (Source.start): if we're using a patch,
1789 add it as a LogFile to the checkout/update step. This will turn
1790 into a link on the waterfall page.
1792 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
1793 option, to take the patch from a pre-made file rather than
1794 generating it from the local tree. Thanks to Robert Helmer for the
1795 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
1796 * buildbot/scripts/runner.py (TryOptions): add --diff,
1797 --patchlevel, and --baserev options
1798 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
1799 as None, meaning HEAD.
1800 * buildbot/sourcestamp.py (SourceStamp): update docstring to
1801 indicate that baserev=None means HEAD
1802 * docs/buildbot.texinfo (try --diff): document it
1804 * buildbot/test/test_steps.py (BuildStep): remove use of
1805 reactor.iterate(), although the technique I replaced it with is a
1806 gross polling hack that must be cleaned up properly some day. This
1807 was the last use of reactor.iterate in the entire tree, yay.
1809 2007-02-05 Brian Warner <warner@lothar.com>
1811 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
1812 is one of the three known values, otherwise we emit some confusing
1813 messages later on. Thanks to Grig Gheorghiu for the catch.
1815 2007-01-30 Brian Warner <warner@lothar.com>
1817 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
1818 Hearsum contributed a patch to let BonsaiPoller work with results
1819 that contain non-ascii characters. Closes SF#1632641.
1821 2007-01-27 Brian Warner <warner@lothar.com>
1823 * Makefile (release): produce both .tar.gz and .zip source bundles.
1826 2007-01-23 Brian Warner <warner@lothar.com>
1828 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
1829 * buildbot/changes/monotone.py: same
1831 * buildbot/changes/maildir.py: combine several files into one,
1832 clean up maildir.py to use Services properly.
1833 * buildbot/changes/maildirtwisted.py: remove
1834 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
1836 * buildbot/changes/mail.py: match the change
1837 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
1838 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
1840 * buildbot/slave/commands.py (command_version): bump to "2.3" to
1841 indicate that the buildslave knows about the 'bzr' command
1843 2007-01-22 Brian Warner <warner@lothar.com>
1845 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
1846 'with', it will become a reserved work in python2.6 .
1848 * contrib/bb_applet.py: add a simple gnome-panel applet, to
1849 display a terse summary of buildbot status.
1850 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
1851 some icons, small versions of the Blender object that lives in
1852 docs/images/icon.blend
1854 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
1855 * buildbot/slave/commands.py (Bzr): same
1856 * buildbot/scripts/tryclient.py (BzrExtractor): same
1857 (SourceStampExtractor.dovc): modify this to allow non-zero exit
1858 status, since 'bzr diff' does that
1859 * buildbot/test/test_vc.py (Bzr): same
1860 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1864 2007-01-20 Brian Warner <warner@lothar.com>
1866 * contrib/darcs_buildbot.py: tidy up the progress messages
1868 2007-01-17 Brian Warner <warner@lothar.com>
1870 * contrib/darcs_buildbot.py: enhance to handle multiple patches
1871 being pushed at a time. This keeps state in the repository in a
1872 small file named .darcs_buildbot-lastchange, but that shouldn't
1873 interfere with normal repository operations. Fixes SF#1534049.
1874 * buildbot/clients/sendchange.py (Sender): make a single Sender
1875 capable of sending Changes with different usernames.
1877 2006-12-11 Brian Warner <warner@lothar.com>
1879 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
1880 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
1881 buildbot.changes.mail a long time ago, but I forgot to add the
1882 DeprecationWarning until now.
1884 * buildbot/process/maxq.py: remove this, the functionality now
1885 lives in buildbot.steps.maxq
1887 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1888 * buildbot/clients/gtkPanes.py: remove unused import
1890 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1891 that was meant to provide a special Reporter to run inside trial
1892 and give the buildslave lots of machine-readable status. We never
1893 finished this project.
1895 * buildbot/changes/bonsaipoller.py: remove unused imports
1896 * buildbot/changes/svnpoller.py: same
1897 * buildbot/process/builder.py: same
1898 * buildbot/process/buildstep.py: same
1899 * buildbot/slave/bot.py: hush pyflakes warning
1900 * buildbot/status/tests.py: remove unused imports
1901 * buildbot/status/tinderbox.py: same
1902 * buildbot/steps/python_twisted.py: same
1904 * buildbot/process/step.py: remove this file, these names were
1905 deprecated in 0.7.5 and are now being removed.
1906 * buildbot/process/step_twisted.py: same
1907 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1909 * buildbot/twcompat.py: remove the empty file, yay it is gone
1911 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1912 tw-2.0.0 and newer have the method we need.
1913 (getProcessOutputAndValue): same
1914 (which): remove this method, tw-2.0.0 t.p.procutils has it
1916 * buildbot/twcompat.py (implements): remove this method
1917 * buildbot/*: import implements() from zope.interface directly
1919 * buildbot/status/mail.py: stop falling back to importing
1920 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1923 * buildbot/twcompat.py (Interface): remove this import
1924 * buildbot/*: import Interface from zope.interface directly
1926 * buildbot/twcompat.py (providedBy): remove this method
1927 * buildbot/*: turn all uses of providedBy(obj, iface) into
1928 iface.providedBy(obj)
1930 * buildbot/twcompat.py (maybeWait): remove this method, now that
1931 we no longer maintain compatibility with Twisted<=1.3.0 .
1932 Twisted-2.0.0 and later allow trial methods to return Deferreds
1934 * buildbot/test/*: remove all uses of maybeWait
1936 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1938 * docs/buildbot.texinfo: same
1940 2006-12-10 Brian Warner <warner@lothar.com>
1942 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1943 * docs/buildbot.texinfo: set version to match
1945 2006-12-10 Brian Warner <warner@lothar.com>
1947 * README (REQUIREMENTS): update for release
1948 * NEWS: update for release
1949 * buildbot/slave/commands.py (command_version): mention that this
1950 version (2.2) was released with buildbot-0.7.5
1952 * buildbot/test/test_config.py (StartService.testStartService):
1953 inhibit the usual read-config-on-startup behavior, since otherwise
1954 the log.err that gets recorded causes the test to fail
1956 * buildbot/status/builder.py (LogFile.finish): forget about all
1957 subscribers once the log has finished, since after that point
1958 we're never going to use them again. This might help free up some
1961 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1962 than the old/deprecated gtk.mainquit()
1964 2006-12-09 Brian Warner <warner@lothar.com>
1966 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1967 better when we can't open the masterdst file
1969 * buildbot/scripts/startup.py (Follower._failure): add missing
1970 import statement for BuildSlaveDetectedError
1972 * buildbot/steps/transfer.py (FileUpload): cleanup
1973 (FileDownload): same. Add tests for slave version, add mode=.
1974 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1975 (SlaveFileDownloadCommand): same
1976 * buildbot/test/test_transfer.py: enhance tests
1977 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1980 2006-12-08 Brian Warner <warner@lothar.com>
1982 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1983 both success *and* failure. Without this, the 'buildbot
1984 sendchange' command would hang if it could not contact the
1985 buildmaster or deliver the Change, which would generally cause the
1986 user's commit/record/checkin command to hang too. Thanks to
1987 Christian Unger for the catch.
1989 2006-12-06 Brian Warner <warner@lothar.com>
1991 * NEWS: update with items for the next release
1993 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1994 whimsical example pulled from a punch-drunk email I sent out late
1996 (Transferring Files): document some of the other parameters
1997 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1998 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1999 * buildbot/test/test_svnpoller.py: same
2000 * buildbot/changes/svnpoller.py (SVNPoller): same
2002 2006-11-26 Brian Warner <warner@lothar.com>
2004 * docs/buildbot.texinfo (Build Properties): remind users that
2005 WithProperties must appear in a command= list, not as a top-level
2007 * buildbot/steps/shell.py (ShellCommand.start): and assert that
2008 we're sending a list or a single string to the RemoteShellCommand
2010 * buildbot/scheduler.py (Nightly): Improve docs slightly.
2012 * buildbot/scripts/startup.py (start): skip the whole
2013 watch-the-logfile thing under windows, since it needs os.fork()
2015 * buildbot/scripts/runner.py (restart): remove the old message
2016 that got printed after the buildbot was restarted.. it most cases
2017 it didn't get printed at the right time anyways
2019 2006-11-25 Brian Warner <warner@lothar.com>
2021 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
2022 follow twistd.log and print lines until the process has started
2023 started properly. For the buildmaster, this means until the config
2024 file has been parsed and accepted. For the buildslave, this means
2025 until we've connected to the master. We give up after 5 seconds in
2026 any case. Helpful error messages and troubleshooting suggestions
2027 are printed when we don't see a successful startup. This closes the
2028 remainder of SF#1517975.
2029 * buildbot/scripts/startup.py: moved app startup code to here
2030 * buildbot/scripts/logwatcher.py: utility class to follow log
2031 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
2032 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
2033 so the LogWatcher can tell the difference between a buildmaster
2036 2006-11-24 Brian Warner <warner@lothar.com>
2038 * docs/examples/twisted_master.cfg: update to match the version
2039 in use on twistedmatrix.com
2040 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
2041 was using before stopped working, but 'irc.freenode.net' works
2044 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
2047 * buildbot/clients/base.py (TextClient.not_connected): upon
2048 UnauthorizedLogin failures, remind the user to connect to the
2049 PBListener port instead of the slaveport.
2050 (TextClient.disconnected): shut down more quietly
2051 * docs/buildbot.texinfo (statuslog): add another reminder
2053 * buildbot/scripts/runner.py (Options.subCommands): rename
2054 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
2055 'sighup' as an alias.
2056 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
2057 reconfig command to follow twistd.log and print all of the lines
2058 from the start of the config-file reload to its completion. This
2059 should make it a lot easier to discover bugs in the config file.
2060 Use --quiet to disable this behavior. This addresses half of
2061 SF#1517975, the other half will be to add this same utility to
2062 'buildbot start' and 'buildbot restart'.
2063 * docs/buildbot.texinfo (Loading the Config File): same
2066 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
2067 method, it has been deprecated for a long time. Use
2068 IBuilderControl.requestBuild instead.
2069 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
2070 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
2071 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
2072 * buildbot/test/test_control.py (Force.testForce): same
2073 * buildbot/test/test_run.py: use requestBuild instead
2075 * buildbot/clients/debug.py: replace 'Force Build' button with
2076 'Request Build' (which just adds one to the queue), add Ping
2077 Builder, add branch/revision fields to Request Build.
2078 * buildbot/clients/debug.glade: same
2079 * buildbot/master.py: update interface to match. This creates an
2080 incompatibility between new debugclients and old buildmasters.
2082 * buildbot/process/builder.py (Builder._attached): delay the call
2083 to maybeStartBuild for a reactor turn, to avoid starting a build
2084 in the middle of a reconfig (say, if the new Builder uses a new
2085 slave which is already connected).
2087 2006-11-23 Brian Warner <warner@lothar.com>
2089 * buildbot/test/test_transfer.py: appease pyflakes
2090 * buildbot/test/test_steps.py: same
2092 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
2093 keeps pyflakes from finding undefined names
2095 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
2096 Builder no longer induces a disconnect/reconnect cycle. This means
2097 that any builds currently in progress will not be interrupted, and
2098 any builds which are queued in the Builder will not be lost. This
2099 is implemented by having the new Builder extract the state (i.e.
2100 all pending Builds and any desired SlaveBuilders) from the old
2102 (BotPerspective): refactor. The BotPerspective no longer keeps
2103 track of all the Builders that want to use this slave; instead, it
2104 asks the BotMaster each time it needs this list. This removes
2105 addBuilder and removeBuilder. Clean up attached() to acquire all
2106 the slave's information in a more atomic fashion. updateSlave() is
2107 now the way to make sure the slave is using the right set of
2108 Builders: just call it after everything else has been
2110 (BotMaster): refactor, removing addBuilder/removeBuilder and
2111 replacing them with an all-at-once setBuilders() call.
2113 * buildbot/test/test_slaves.py (Reconfig): new test case to
2114 exercise this functionality
2115 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
2116 * buildbot/slave/commands.py (WaitCommand): same
2118 * docs/buildbot.texinfo (Loading the Config File): document the
2121 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
2122 SlaveBuilder to have its parent Builder changed.
2123 (SlaveBuilder.isAvailable): new method to give access to state,
2124 which is now a private attribute
2125 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
2126 the SlaveBuilder about how it is being used. These methods update
2127 its internal state. buildFinished() is now the place that invokes
2128 maybeStartBuild() on its parent Builder.
2129 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
2130 new Builder to take over for an old one, transferring state from
2132 (Buider): refactor the way that SlaveBuilders are used to match,
2133 giving them a bit more autonomy.
2134 (Builder.buildFinished): this no longer calls maybeStartBuild():
2135 instead the SlaveBuilder calls it on whoever its parent Builder is
2136 at the time. This way, when an old Builder is replaced by a new
2137 one, and there was a build in progress during the transition, when
2138 that build finishes, it will be the new Builder that is told about
2139 the newly available slave so it can start a new build.
2141 * buildbot/process/base.py (Build.startBuild._release_slave): when
2142 the Build finishes, tell the SlaveBuilder that they've been
2145 * buildbot/status/builder.py (SlaveStatus): add some new setter
2146 methods for use by BotPerspective, to keep some attributes more
2149 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
2150 called by the buildmaster.
2151 (Bot.setBuilderList): instead, we locally announce any leftover
2152 directories based upon which Builders we were told about. The
2153 master doesn't really care; it's the local admin who may or may not
2154 wish to delete them.
2157 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
2158 to allow use of python2.4 or whatever. This tool still requires
2161 2006-11-19 Brian Warner <warner@lothar.com>
2163 * NEWS (IStatusLog.readlines): more news items
2165 2006-11-18 Brian Warner <warner@lothar.com>
2167 * NEWS: start collecting items for the next release.
2169 2006-11-04 Brian Warner <warner@lothar.com>
2171 * buildbot/changes/bonsaipoller.py: apply updates from Ben
2172 Hearsum. Closes SF#1590310.
2173 * buildbot/test/test_bonsaipoller.py: and tests
2175 * buildbot/status/tinderbox.py
2176 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
2177 status when the build results in WARNINGS. Patch from Dave
2178 Liebreich. Closes SF#1587352.
2180 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
2181 linux-vs-osx behavior difference w.r.t. reading from files that
2182 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
2183 to Mark Rowe for the patch.
2185 2006-10-15 Brian Warner <warner@lothar.com>
2187 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
2188 method name was misspelled in the interface definition. Thanks to
2189 Roy Rapoport for the catch.
2191 2006-10-13 Brian Warner <warner@lothar.com>
2193 * docs/buildbot.texinfo (Adding LogObservers): update sample code
2194 to match the great Steps renaming
2196 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
2197 Maybe I should run my own unit tests before recording a big
2198 change. Good thing I've got a buildbot to remind me.
2200 2006-10-12 Brian Warner <warner@lothar.com>
2202 * buildbot/steps/transfer.py: rework __init__ and args setup
2203 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
2205 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
2206 when opening the target file, only catch IOError (to report via
2207 stderr/rc!=0), let the others be reported as normal exceptions
2209 2006-10-08 Brian Warner <warner@lothar.com>
2211 * contrib/svn_watcher.py: fix security holes by using proper argv
2212 arrays and subprocess.Popen() rather than commands.getoutput().
2213 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
2214 is deprecated in favor of buildbot/changes/svnpoller.py, and will
2215 probably be removed by the next release.
2218 2006-10-04 Brian Warner <warner@lothar.com>
2220 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
2221 initial lines that weren't emitted by pyflakes. When the pyflakes
2222 command is run under a Makefile, 'make' will echo the command it
2223 runs to stdio, and that was getting logged as a "misc" warning.
2224 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
2225 * buildbot/test/test_steps.py (testPyFlakes3): another test
2227 2006-10-01 Brian Warner <warner@lothar.com>
2229 * buildbot/status/html.py (HtmlResource.render): if we get a
2230 unicode object from our content() method, encode it into utf-8
2231 like we've been claiming to all along. This allows the comments
2232 and author names from svnpoller.py to be delivered properly.
2234 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
2235 de-unicodify filenames before creating the Change, because the
2236 rest of buildbot is unlikely to handle them well. Leave the 'who'
2237 field as a unicode object.. I don't think there's anything that
2238 will break very soon, and it will probably nudge us towards
2239 accepting unicode everywhere sooner or later. Stop using the
2240 "date" field that comes out of SVN, since it is using the
2241 repository's clock (and timezone) and what we care about is the
2242 buildmaster's (otherwise Changes from the future show up later
2243 than the builds they triggered).
2244 * buildbot/test/test_svnpoller.py (Everything.test1): match the
2247 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
2248 Suvbersion repository polling ChangeSource. I've hacked it up
2249 considerably: any bugs are entirely my own fault. Thank you
2251 * buildbot/test/test_svnpoller.py: tests for it
2252 * docs/buildbot.texinfo (SvnSource): document it
2254 2006-09-30 Brian Warner <warner@lothar.com>
2256 * buildbot/scheduler.py (Periodic): submit a reason= to the
2257 BuildSet to indicate which Scheduler triggered the build. Thanks
2258 to Mateusz Loskot for the suggestion.
2260 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
2262 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
2263 changes: set self.loop in __init__, remove unused volatile=
2265 * docs/buildbot.texinfo (.buildbot config directory): add more
2266 docs on the .buildbot/options keys used by "buildbot try"
2267 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
2268 (Try.deliverJob): same
2270 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
2272 (BonsaiPoller): same
2274 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
2275 close the filehandle when we stop watching the file. Before, the
2276 filehandle was only closed when the LogFileWatcher was
2277 garbage-collected, which could be quite a while in the future. If
2278 it was still open by the time the next build started, windows will
2279 refuse to let the new build delete the old build/ directory. Fixes
2280 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
2281 #twisted for the catch.
2283 2006-09-29 Brian Warner <warner@lothar.com>
2285 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
2288 2006-09-25 Brian Warner <warner@lothar.com>
2290 * setup.py: the new buildbot.steps module wasn't being installed.
2291 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
2292 (testmsgs): add the extra stuff from buildbot/test/* so you can
2293 run unit tests on an installed copy of buildbot, not just from
2296 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
2297 columns of 'svnlook changed' output contain status information, so
2298 strip [:4] instead of [:6]. Depending upon what the status flags
2299 were, this would sometimes lead to mangled filenames. Thanks to
2300 Riccardo Magliocchetti for the patch. Closes SF#1545146.
2302 * buildbot/steps/source.py (Monotone): initial Monotone support,
2303 contributed by Nathaniel Smith. Still needs docs and tests, but
2304 this code has been in use on the Monotone buildbot for a long
2306 * buildbot/slave/commands.py (Monotone): slave-side support
2307 * buildbot/changes/monotone.py (MonotoneSource): polling change
2310 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
2311 contributed a Change Source that polls a Bonsai server (a
2312 kind of web-based viewcvs CGI script).
2314 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
2315 Hearsum contributed a status plugin which sends email in the same
2316 format that Tinderbox does: this allows a number of tinderbox
2317 tools to be driven by Buildbot instead. Thanks Ben!
2319 2006-09-24 Brian Warner <warner@lothar.com>
2321 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
2322 Thanks to Robert Helmer for the patch.
2324 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
2325 BuildStatus about the buildslave name at the *beginning* of the
2326 build, rather than at the end. Thanks to Alexander Lorenz for the
2328 * buildbot/status/html.py (StatusResourceBuild.body): always
2329 include the slavename in the build page, not just when the build
2331 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
2332 slavename in the email message
2334 2006-09-21 Brian Warner <warner@lothar.com>
2336 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
2338 * docs/examples/glib_master.cfg: same
2339 * docs/examples/hello.cfg: same
2340 * docs/examples/twisted_master.cfg: same, update to current usage
2342 2006-09-19 Brian Warner <warner@lothar.com>
2344 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
2345 (PyFlakes.createSummary): make it compatible with python-2.2
2347 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
2348 for at least the output-parsing parts of PyFlakes
2350 2006-09-18 Brian Warner <warner@lothar.com>
2352 * buildbot/steps/python.py: oops, fix import of StringIO
2354 2006-09-17 Brian Warner <warner@lothar.com>
2356 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
2357 turns out that SVN-1.4.0 doesn't fail to update once you've
2358 replaced a file with a directory, unlike older versions of SVN and
2359 pretty much every other VC tool we support. Since what we really
2360 care about is that the update succeeds anyway, stop checking that
2361 the tree got clobbered and just assert that the build succeeded.
2362 (VCBase.printLogs): add a utility function for debugging
2364 * buildbot/process/step.py: oops, added extra imports by mistake
2366 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
2367 rstrip() on the first line coming out of the 'p4 describe'
2368 process, to remove the stray ^M that Wade Brainerd reports seeing
2369 in the 'when' field. Fixes SF#1555985.
2371 * buildbot/master.py (BuildMaster.loadConfig): improve the error
2372 message logged when c['schedulers'] is not right
2373 * buildbot/scheduler.py (Scheduler.__init__): improve error
2374 message when a Scheduler() is created with the wrong arguments
2375 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
2376 verify that these error messages are emitted
2378 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
2379 The idea is that all the base classes (like BuildStep and
2380 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
2381 will be a leftover backwards-compatibility file that only contains
2382 aliases for the steps that were moved out to buildbot.steps.*
2383 * lots: change imports to match
2384 * buildbot/process/step.py: add a DeprecationWarning if it ever
2387 2006-09-12 Brian Warner <warner@lothar.com>
2389 * buildbot/scheduler.py (Scheduler.__init__): make sure that
2390 builderNames= is actually a sequence, since if you happen to give
2391 it a single builder-specification dictionary instead, it won't get
2392 caught by the existing assert. Thanks to Brett Neely for the
2395 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
2397 * docs/buildbot.texinfo (Python BuildSteps): document them
2398 (sendchange): include a link to PBChangeSource, since you need one
2400 * buildbot/steps/shell.py: clean up test-case-name line, remove some
2402 * buildbot/steps/dummy.py: same
2404 2006-09-08 Brian Warner <warner@lothar.com>
2406 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
2407 BuildStep which lets you transfer files from the master to the
2408 slave or vice versa. Thanks to Albert Hofkamp for the original
2409 patch. Fixes SF#1504631.
2410 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
2412 (SlaveFileDownloadCommand): same
2413 * docs/buildbot.texinfo (Transferring Files): document it
2414 * buildbot/test/test_transfer.py: test it
2415 * buildbot/test/runutils.py (StepTester): new utility class for
2416 testing BuildSteps and RemoteCommands without Builds or Bots or PB
2417 * buildbot/test/test_steps.py (CheckStepTester): validate that the
2420 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
2421 walk through StatusLogs one line at a time, mostly for the benefit
2422 of ShellCommand.createSummary methods. You can either walk through
2423 STDOUT or STDERR, but the default is STDOUT.
2425 * buildbot/status/builder.py (LogFile.readlines): implement it.
2426 Note that this is not yet memory-efficient, it just pulls the
2427 whole file into RAM and then splits it up with a StringIO.
2428 Eventually this should be a generator that only pulls chunks from
2430 * buildbot/test/test_status.py (Log.testReadlines): test it
2432 * docs/buildbot.texinfo: update to match changes
2433 * buildbot/process/factory.py: stop using old definitions
2434 * buildbot/process/process_twisted.py: same
2435 * buildbot/test/test_*.py: same
2437 * buildbot/process/step_twisted.py: move definition to..
2438 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
2439 relative-import mechanisms prevent this from being named 'twisted'
2440 or 'python/twisted' as I would have preferred.
2442 * buildbot/process/maxq.py: move definition to..
2443 * buildbot/steps/maxq.py: .. here, leave a compatibility import
2445 * buildbot/process/step.py: split the user-visible BuildSteps into
2446 separate files, all under buildbot/steps/
2447 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
2448 * buildbot/steps/shell.py: this holds ShellCommand and friends
2449 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
2451 2006-09-05 Brian Warner <warner@lothar.com>
2453 * lots: run pyflakes, removed a lot of unused imports, changed the
2454 form of some conditional imports to remove false pyflakes
2455 warnings. There are still a number of warnings left, mostly from
2456 imports that are done for their side-effects.
2457 * buildbot/test/test_vc.py: import twisted.python.failure, since it
2460 2006-08-26 Brian Warner <warner@lothar.com>
2462 * buildbot/test/test_locks.py (Unit.testLater): make the tests
2463 compatible with twisted-1.3.0, for some reason I just can't seem
2464 to let go of the past.
2466 2006-08-25 Brian Warner <warner@lothar.com>
2468 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
2470 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
2471 all logfiles= in startCommand(), rather than in start() . This
2472 makes it easier to have the 'stdio' log come before any secondary
2473 logfiles, which I feel makes the waterfall display more
2475 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
2476 from ShellCommand up into LoggingBuildStep
2477 (LoggingBuildStep.__init__): move the handling of logfiles= from
2478 ShellCommand up to LoggingBuildStep, because startCommand is
2479 provided by LoggingBuildStep, whereas start() was specific to
2480 subclasses like ShellCommand and Source. This removes code
2481 duplication in those subclasses.
2482 (ShellCommand.__init__): same
2483 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
2484 for a slave that's too old to understand logfiles= into a separate
2485 method, so it can live in ShellCommand. The rest of
2486 setupLogfiles() can live in LoggingBuildStep.
2488 2006-08-24 Brian Warner <warner@lothar.com>
2490 * buildbot/locks.py (BaseLock): you can now configure Locks to
2491 allow multiple simultaneous owners. They still default to
2492 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
2494 * docs/buildbot.texinfo (Interlocks): document the new options
2495 * buildbot/test/test_locks.py: add a bunch of new unit tests
2496 * buildbot/process/base.py (Build.acquireLocks): locks now offer
2497 waitUntilMaybeAvailable, not waitUntilAvailable
2498 * buildbot/process/step.py (BuildStep.acquireLocks): same
2499 * buildbot/master.py (BotMaster.getLockByID): real locks now use
2500 the whole lockid in their constructor, not just the name. Also,
2501 keep track of which real locks we've handed out by the full
2502 lockid, not just class+name, otherwise changing just the maxCount=
2503 in the master.cfg file would not actually cause a behavioral
2506 2006-08-23 Brian Warner <warner@lothar.com>
2508 * buildbot/__init__.py (version): bump to 0.7.4+ while between
2510 * docs/buildbot.texinfo: same
2512 2006-08-23 Brian Warner <warner@lothar.com>
2514 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
2515 * docs/buildbot.texinfo: set version to match
2516 * NEWS: update for 0.7.4
2517 * buildbot/slave/commands.py (command_version): mention that this
2518 version (2.1) was released with buildbot-0.7.4
2520 2006-08-22 Brian Warner <warner@lothar.com>
2524 * CREDITS: new file, list of people who have helped. Thanks!
2525 * MANIFEST.in: ship it
2527 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
2528 new diagrams, the user's manual is more informative than it was.
2529 Start shipping the .html user's manual (and generated .png
2531 * Makefile: update 'release' target to match
2533 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
2534 test.. I think the web-parts effort will render it pointless well
2535 before it ever actually starts to work.
2537 2006-08-20 Brian Warner <warner@lothar.com>
2539 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
2540 meaning of the prefix= argument. It is now just a string which is
2541 stripped from the beginning of the filename. If prefix= is set but
2542 not found on any given filename, that filename is ignored. If all
2543 filenames in a Change are ignored, the Change is dropped. This is
2544 much simpler than the previous sep= nonsense, and I should have
2545 implemented it this way from the beginning. Effectively resolves
2546 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
2547 Gedminas for the catch and suggested fixes.
2548 (ChangePerspective.perspective_addChange): implement the actual
2550 * buildbot/test/test_changes.py (TestChangePerspective): test it
2551 * docs/buildbot.texinfo (PBChangeSource): document it, explain
2552 how to properly use prefix=
2553 * docs/examples/twisted_master.cfg (source): update prefix= by
2554 adding the trailing slash
2557 * docs/examples/twisted_master.cfg: update to actual practice
2559 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
2560 update test case to match new link text.. the HREF has both a
2561 class= setting and an enclosing [] pair that I didn't match in the
2564 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
2565 list of strings is preferred over a single string with embedded
2567 (ShellCommand.description=): explain that either single strings or
2568 a list of strings is acceptable, and why you might prefer one over
2569 the other. Add an example. Fixes SF#1524659, thanks to Paul
2570 Winkler for the catch.
2571 (Build Steps): update to use f.addStep() rather than using s()
2572 and the constructor list
2574 * buildbot/process/step.py (ShellCommand): accept either a single
2575 string or a list of strings in both description= and
2577 * buildbot/test/test_steps.py (Steps.test_description): test it
2578 * buildbot/test/runutils.py (makeBuildStep): support for that test
2580 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
2581 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
2582 collecting the files and creating the patch.
2584 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
2585 per-step URLs that will be displayed on the waterfall display,
2586 for things like the HTML output of code-coverage tools, when
2587 the results are hosted elsewhere.
2588 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
2589 way to retrieve these URLs
2590 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
2591 the method to retrieve these URLs. Also provide backwards
2592 compatibility for saved BuildStepStatus instances that didn't have
2594 * buildbot/process/step.py (BuildStep.addURL): method to set these
2595 URLs from within a BuildStep
2596 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
2597 (StepBox.getBox): give these external links a distinct CSS class
2598 named "BuildStep external" so a .css file can display them
2601 * buildbot/test/test_web.py (WaterfallSteps): test that we really
2603 * buildbot/test/test_steps.py (Steps): test that we can all the
2604 URLs. Also add a bunch of other tests on methods that can be
2605 called from within BuildSteps
2606 * buildbot/test/runutils.py (makeBuildStep): add utility function
2608 2006-08-13 Brian Warner <warner@lothar.com>
2610 * docs/buildbot.texinfo (BuildStep LogFiles): document them
2612 2006-08-10 Brian Warner <warner@lothar.com>
2614 * docs/buildbot.texinfo (Index of master.cfg keys): add another
2615 index, this one of things like c['sources'] and c['schedulers']
2616 (indices): it looks like my clever idea of putting the @fooindex
2617 commands in between the @node and the @subsection (to make the
2618 HREF anchor jump to slightly above the section title, which works
2619 much better in html) confused texinfo horribly, so I'm moving the
2620 index tags back to be just after the @subsection marker. I also
2621 added extra lines between the @node/@section paragraph and the
2622 index tags, since I think maybe texinfo wants to see these be
2623 separate paragraphs.
2625 * docs/Makefile (images): make sure images get built when
2626 rendering the manual
2627 * docs/images/Makefile: same
2629 * buildbot/scripts/runner.py: rename 'buildbot master' to
2630 'buildbot create-master', and 'buildbot slave' to 'buildbot
2632 * docs/buildbot.texinfo: same
2635 * docs/buildbot.texinfo: reimplement the "useful classes" index
2636 with actual texinfo indices. The .info rendering is a bit
2637 weird-looking but it works well, and the HTML rendering is quite
2638 nice. This also puts the index targets in the regular flow of the
2639 text, which is easier to maintain.
2641 2006-08-06 Brian Warner <warner@lothar.com>
2643 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
2644 Kevin Turner to prefer the environ= argument be a list rather than
2645 a string. If it is a list, it will be joined with a platform-local
2646 os.pathsep delimiter, and then prepended to any existing
2647 $PYTHONPATH value. This works better in cross-platform (i.e.
2648 windows buildslaves) environments when you need to push multiple
2649 directories onto the front of the path.
2650 (SlaveShellCommand): documented the new magic
2651 * docs/buildbot.texinfo (ShellCommand): documented the new magic
2652 in a user-visible form
2654 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
2655 Turner to prefer lists over strings when creating/running VC
2656 commands during unit tests. This is clearly necessary to survive
2657 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
2658 renamed the wq() function to qw() though, since that's how it's
2659 spelled in perl. Eventually I'd prefer all commands to be
2660 specified with lists.
2662 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
2663 which are deleted (or not yet created) correctly. Also add
2664 failsafe code to not explode if the file-watching poller doesn't
2665 get started. Thanks to JP Calderone for the catch and the poller
2667 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
2669 * buildbot/test/emitlogs.py: same
2671 * NEWS: summarize recent changes
2673 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
2674 clause to avoid the "host key mismatch" warning
2676 * buildbot/process/step_twisted.py (Trial.start): if the
2677 buildslave is too old to understand logfiles=, fall back to
2678 running 'cat _trial_temp/test.log' like before.
2679 (Trial.commandComplete): same. this takes advantage of the
2680 LoggingBuildStep refactoring to stall commandComplete long enough
2681 to run a second RemoteShellCommand.
2683 * buildbot/process/step.py (LoggingBuildStep.startCommand):
2684 refactor command-completion handling, to allow methods like
2685 commandComplete/createSummary/evaluateCommand to return Deferreds.
2686 (LoggingBuildStep._commandComplete): delete the refactored method
2687 (ShellCommand.setupLogfiles): if the buildslave is too old to
2688 understand logfiles=, put a warning message both into twistd.log
2689 and into the otherwise empty user-visible LogFiles.
2691 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
2692 callers to provide the slave-side logfile name, rather than
2693 forcing it to come from the local name of the LogFile.
2694 (BuildStep.getSlaveName): new method
2696 * buildbot/process/base.py (Build.getSlaveName): new method, so
2697 steps can find out which buildslave they're running on
2699 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
2700 to match the s/cvs_ver/command_version/ change
2702 2006-08-05 Brian Warner <warner@lothar.com>
2704 * buildbot/slave/commands.py (command_version): replace the CVS
2705 auto-updated cvs_ver keyword with a manually-updated variable,
2706 since CVS is no longer the master repository. Add a description of
2707 the remote API change starting in this version (2.1), specifically
2708 the fact that SlaveShellCommand now accepts 'initial_stdin',
2709 'keep_stdin_open', and 'logfiles'.
2711 2006-07-31 Brian Warner <warner@lothar.com>
2713 * docs/buildbot.texinfo (System Architecture): Finally add lots of
2714 diagrams to describe how the whole system fits together. The
2715 images themselves are kept in SVG files, with ascii-art versions
2716 in corresponding .txt files. Texinfo knows how to interpolate the
2717 text version into .info files, reference the .png versions from
2718 .html files, and include .eps versions in the .ps format.
2719 * docs/images/Makefile: tools to create .png and .eps
2720 * docs/images/*.svg: created pictures with Inkscape.
2721 * .darcs-boring: ignore the generated .eps and .png files
2723 2006-07-24 Brian Warner <warner@lothar.com>
2725 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
2726 Scheduler names, since they cause setServiceParent to explode
2728 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
2730 2006-07-20 Brian Warner <warner@lothar.com>
2732 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
2733 which runs the buildbot unit tests
2735 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
2736 classes that are useful in master.cfg
2738 2006-07-15 Brian Warner <warner@lothar.com>
2740 * Makefile (some-apidocs): new target to build only some epydocs
2742 * setup.py: minor comment.. does the classifiers= argument prevent
2743 the setup.py script from working on python2.2/2.3?
2745 * buildbot/scripts/sample.cfg: update manhole example, arrange into
2748 * buildbot/twcompat.py: fix minor typo in comments
2750 * buildbot/manhole.py: move all Manhole-related code out to this
2751 module. Implement SSH-based manholes (with TwistedConch), and move
2752 to conch's nifty line-editing syntax-coloring REPL shell instead
2753 of the boring non-editing monochromatic (and deprecated) old
2755 * buildbot/master.py: remove all Manhole-related code
2756 (BuildMaster.loadConfig._add): make sure the old manhole is
2757 removed before we add the new one
2758 * docs/buildbot.texinfo (Debug options): document new Manhole options
2760 * buildbot/twcompat.py (_which): fix some epydoc issues
2761 * buildbot/status/html.py (Waterfall.__init__): same
2763 2006-06-29 Brian Warner <warner@lothar.com>
2765 * buildbot/interfaces.py: get Interface from b.twcompat to hush
2766 deprecation warnings under newer Twisteds (by using
2767 zope.interface.Interface instead of old twisted.python.components
2769 * buildbot/slave/interfaces.py: same
2771 2006-06-28 Brian Warner <warner@lothar.com>
2773 * buildbot/slave/commands.py (SVN): add --non-interactive to all
2774 svn commands, so it will fail immediately instead of hanging while
2775 it waits for a username/password to be typed in.
2777 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
2778 log message if the step was shut down
2780 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
2781 obsolete reference to mktap.
2783 2006-06-20 Brian Warner <warner@lothar.com>
2785 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
2786 test to include new 'logfiles' argument sent from master to slave
2788 2006-06-19 Brian Warner <warner@lothar.com>
2790 * buildbot/process/step_twisted.py (Trial): track Progress from
2791 _trial_temp/test.log too
2793 * buildbot/process/step.py (OutputProgressObserver): generalize
2794 the earlier StdioProgressObserver into an OutputProgressObserver
2795 that can track LogFiles other than stdio.
2796 (LoggingBuildStep.__init__): same
2798 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
2799 _trial_temp/test.log, not a separate 'cat' command. TODO: this
2800 will fail under windows because of os.sep issues. It might have
2801 worked before if 'cat' was doing cygwin path conversion.
2803 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
2804 creation of LogFileWatchers
2805 (ShellCommand._startCommand): and record the files that were
2806 watched in the 'headers' section of the ShellCommand output
2808 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
2809 need to actually pass it to the slave if you want it to work.
2810 (ShellCommand): document it a bit
2812 * buildbot/test/test_shell.py: new test to validate LogFiles
2813 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
2815 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
2816 before printing the last batch of lines, to test that the polling
2817 logic is working properly
2819 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
2820 handling, making it possible to track multiple logs for a single
2821 RemoteCommand. The previous single logfile is now known as the
2823 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
2824 (RemoteShellCommand.__init__): accept logfiles=
2825 (LoggingBuildStep.startCommand): stdio_log is now one of many
2826 (ShellCommand): added logfiles= argument, as well as a class-level
2827 .logfiles attribute, which will be merged together to figure out
2828 which logfiles should be tracked. The latter maybe be useful for
2829 subclasses of ShellCommand which know they will aways produce
2830 secondary logfiles in the same location.
2832 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
2833 and closeStdin() methods, preparing to make it possible to write
2834 to a ShellCommand's stdin at any time, not just at startup. These
2835 writes are buffered if the child process hasn't started yet.
2836 (LogFileWatcher): new helper class to watch arbitrary logfiles
2837 while a ShellCommand runs. This class polls the file every two
2838 seconds, and sends back 10k chunks to the buildmaster.
2839 (ShellCommand): rename stdin= to initialStdin=, and add
2840 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
2842 (ShellCommand.addLogfile): LogFile text is sent in updates with a
2843 key of "log" and a value of (logname, data).
2844 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
2845 'logfiles' to the master-visible args dictionary.
2846 (SourceBase.doPatch): match s/stdin/initialStdin/ change
2849 * buildbot/test/test_vc.py (Patch.testPatch): same
2852 * buildbot/test/emit.py: write to a logfile in the current
2853 directory. We use this to figure out what was used as a basedir
2854 rather than looking to see which copy of emit.py gets run, so that
2855 we can run the commands from inside _trial_temp rather than inside
2857 * buildbot/test/subdir/emit.py: same
2858 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
2859 argument rather than running from buildbot/test/
2860 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
2861 rather than using an implicit setUp()
2862 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
2863 (ShellBase.testShell1, etc): use explicit path to emit.py instead
2864 of assuming that we're running in buildbot/test/ (and that '.' is
2867 * buildbot/slave/commands.py (Command.doStart): refactor Command
2868 startup/completion a bit: now the SlaveBuilder calls doStart(),
2869 which is not meant for overridding by subclasses, and doStart()
2870 calls start(), which is. Likewise the SlaveBuilder calls
2871 doInterrupt(), and subclasses override interrupt(). This also puts
2872 responsibility for maintaining .running in Command rather than in
2874 (Command.doInterrupt): same
2875 (Command.commandComplete): same, this is called when the deferred
2876 returned by start() completes.
2877 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
2878 (SlaveBuilder.remote_interruptCommand): same
2879 (SlaveBuilder.stopCommand): same
2881 2006-06-16 Brian Warner <warner@lothar.com>
2883 * buildbot/test/test_shell.py: new test file to contain everything
2884 relating to ShellCommand
2885 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
2886 multiple logfiles in realtime" feature, not yet implemented
2887 * buildbot/test/emitlogs.py: support file for testLogFiles
2888 * docs/buildbot.texinfo (ShellCommand): document the feature
2890 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2892 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2893 for tests which exercise SlaveCommands in isolation.
2895 * buildbot/test/test_slavecommand.py: Move some utilities like
2896 SignalMixin and FakeSlaveBuilder from here ..
2897 * buildbot/test/runutils.py: .. to here, so they can be used by
2898 other test classes too
2899 * buildbot/test/test_vc.py: more SignalMixin refactoring
2900 * buildbot/test/test_control.py: same
2901 * buildbot/test/test_run.py: and some rmtree refactoring
2903 2006-06-15 Brian Warner <warner@lothar.com>
2905 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2906 'testBranch' to match other VC tests and have the tests run in
2907 roughly increasing order of dependency
2909 * buildbot/test/test_steps.py (LogObserver): new test to verify
2910 LogObservers can be created at various times and still get
2911 connected up properly
2913 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2914 to create BuildStepStatus instances that actually work.
2916 * buildbot/process/step.py (LogObserver): add outReceived and
2917 errReceived base methods, to be overridden
2919 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2920 API to take a name instead of a step, reducing the coupling
2921 somewhat. This returns the BuildStepStatus object so it can be
2922 passed to the new Step, instead of jamming it directly into the
2924 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2926 * buildbot/process/base.py (Build.setupBuild): use both methods
2927 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2928 process a bit to match
2930 2006-06-14 Brian Warner <warner@lothar.com>
2932 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2933 docs on writing new LogObserver classes
2934 (Writing New Status Plugins): brief docs on how Status Plugins fit
2937 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2938 implement a LogObserver that counts how many unit tests have been
2940 (Trial.__init__): wire it in
2941 * buildbot/test/test_twisted.py (Counter): unit test for it
2943 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2944 to new cmd.logs['stdio'] scheme
2945 (Trial.commandComplete): same
2946 (BuildDebs.commandComplete): same
2948 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2949 LogFiles, instead of just a single one. The old single logfile is
2950 now called "stdio". LoggedRemoteCommand no longer creates a
2951 LogFile for you (the code to do that was broken anyway). If you
2952 don't create a "stdio" LogFile, then stdout/stderr will be
2954 (LogObserver): implement "LogObservers", which a BuildStep can add
2955 to parse the output of a command in real-time. The primary use is
2956 to provide more useful information to the Progress code, allowing
2957 better ETA estimates.
2958 (LogLineObserver): utility subclass which feeds complete lines to
2959 the parser instead of bytes.
2960 (BuildStep.progressMetrics): this is safer as a tuple
2961 (BuildStep.setProgress): utility method, meant to be called by
2963 (BuildStep.addLogObserver): new method, to be called at any time
2964 during the BuildStep (even before any LogFiles have been created),
2965 to attach (or schedule for eventual attachment) a LogObserver to a
2967 (StdioProgressObserver): new LogObserver which replaces the old
2968 "output" progress gatherer
2969 (LoggingBuildStep.__init__): same
2970 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2971 (LoggingBuildStep._commandComplete): must use logs['stdio']
2972 instead of the old single ".log" attribute.
2973 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2974 functionality, now subsumed into StdioProgressObserver
2975 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2976 log name changed from "output" to "stdio".
2979 * buildbot/interfaces.py (ILogFile): add the Interface used from
2980 the BuildStep towards the LogFile
2981 (ILogObserver): and the one provided by a LogObserver
2982 * buildbot/status/builder.py (LogFile): implement it
2984 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2985 HEADER constants here ..
2986 * buildbot/status/builder.py (STDOUT): .. from here
2988 2006-06-13 Brian Warner <warner@lothar.com>
2990 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2991 compatibility with python2.2, which doesn't have the 'substr in
2993 (TestP4Poller.makeTime): utility function to construct the
2994 timestamp using the same strptime() approach as p4poller does. It
2995 turns out that time.mktime() behaves slightly differently under
2996 python2.2, probably something to do with the DST flag, and that
2997 causes the test to fail under python2.2. (changing the mktime()
2998 arguments to have dst=0 instead of -1 caused it to fail under
2999 python2.3. Go figure.)
3000 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
3002 2006-06-12 Brian Warner <warner@lothar.com>
3004 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
3005 proper Perforce (P4) support. Many many thanks to Scott Lamb for
3006 contributing such an excellent patch, including docs and unit
3007 tests! This makes it *so* much easier to apply. I had to update
3008 test_vc.py to handle some recent refactorings, but everything else
3009 applied smoothly. The only remaining thing I'd like to fix would
3010 be to remove the hard-wired port 1666 used by p4d, and allow it to
3011 claim any unused port. This would allow two copies of the test
3012 suite to run on the same host at the same time, as well as
3013 allowing the test suite to run while a real (production) p4d was
3014 running on the same host. Oh, and maybe we should add a warning to
3015 step.P4 that gets emitted if the slave is too old to provide the
3016 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
3017 * buildbot/slave/commands.py (P4): same
3018 (P4Sync): same, some minor updates
3019 * buildbot/changes/p4poller.py: same
3020 * docs/buildbot.texinfo: same
3021 * buildbot/test/test_p4poller.py: same
3022 * buildbot/test/test_vc.py (P4): same
3024 * setup.py: add Trove classifiers for PyPI
3026 2006-06-08 Brian Warner <warner@allmydata.com>
3028 * buildbot/status/client.py
3029 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
3030 changing this from getCurrentBuild() to getCurrentBuilds(). Each
3031 build needs to be IRemote'd separately, rather than IRemote'ing
3032 the whole list at once. I can't wait until newpb's serialization
3033 adapters make this unnecessary.
3035 2006-06-06 Brian Warner <warner@lothar.com>
3037 * buildbot/process/step.py (WithProperties): make this inherit
3038 from ComparableMixin, so that reloading an unchanged config file
3039 doesn't cause us to spuriously reload any Builders which use them.
3040 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
3043 2006-06-03 Brian Warner <warner@lothar.com>
3045 * contrib/windows/{setup.py, buildbot_service.py}: add support for
3046 running py2exe on windows, contributed by Mark Hammond. Addresses
3047 SF#1401121, but I think we still need to include
3048 buildbot/scripts/sample.cfg
3049 * setup.py: include buildbot_service.py as a script under windows
3050 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
3051 a py2exe application), get the icon/css datafiles from a different
3054 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
3055 double-escape the build URL. Thanks to Olivier Bonnet for the
3056 patch. Fixes SF#1452801.
3058 2006-06-02 Brian Warner <warner@lothar.com>
3060 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
3061 first six columns of 'svnlook' output, not just the first column,
3062 since property changes appear in the other five. Thanks to Olivier
3063 Bonnet for the patch. Fixes SF#1398174.
3065 2006-06-01 Brian Warner <warner@lothar.com>
3067 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
3068 the fake build, so that title= has something to be set to
3070 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
3071 attribute of the "Build #NN" link in the yellow start-the-build
3072 box to the build's reason. This means that you get a little
3073 tooltip explaining why the build was done when you hover over the
3074 yellow box. Thanks to Zandr Milewski for the suggestion.
3076 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
3077 (Box.setETA): handle ETA=None (by stopping the timer)
3078 (Box.update): make the [soon] text less different than the usual
3079 text, so the rest of the text doesn't flop around so much. It
3080 would be awfully nice to figure out how to center this stuff.
3081 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
3083 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
3084 by default, so that any ShellCommand which fails marks the overall
3085 build as a failure. I should have done this from the beginning.
3086 Add flunkOnFailure=False to the arguments if you want to turn off
3089 2006-05-30 Brian Warner <warner@lothar.com>
3091 * buildbot/clients/gtkPanes.py: add a third row: now it shows
3092 last-build/current-build/current-step. Show what step is currently
3093 running. Show ETA for both the overall build and the current step.
3094 Update GTK calls to modern non-deprecated forms. There's still a
3095 lot of dead code and debug noise to remove.
3097 * buildbot/process/step_twisted.py (Trial): set the step name, so it
3098 shows up properly in status displays
3100 2006-05-28 Brian Warner <warner@lothar.com>
3102 * buildbot/test/test_properties.py (Run.testInterpolate): on the
3103 build we use to verify that WithProperties works:
3105 ** set flunkOnFailure=True so that build failures get noticed
3106 ** set workdir='.' so that the build succeeds, otherwise it is trying
3107 to touch 'build/something', and 'build/' doesn't exist because
3108 usually that's created by a Source step
3109 ** set timeout=10, because Twisted-1.3.0 has a race condition that
3110 this test somehow triggers, in which the 'touch' process becomes
3111 a zombie and we wait for th etimeout before giving up on it.
3113 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
3114 to log the Build results and step logs to the twisted log.
3115 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
3116 what went wrong if a build was expected to succeed but didn't.
3118 * buildbot/process/step_twisted.py (Trial): set the default
3119 trialMode to '--reporter=bwverbose', which specifies verbose
3120 black-and-white text. Back in twisted-1.3/2.0 days we had to use
3121 '-to', but those are completely missing in modern Twisteds.
3123 * buildbot/scripts/sample.cfg: make the sample Manhole config use
3124 a localhost-only port, to encourage better security
3126 * docs/buildbot.texinfo (Change Sources): mention
3129 * .darcs-boring: add a Darcs boringfile
3131 * README (REQUIREMENTS): stop claiming compatibility with
3134 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
3137 2006-05-27 Brian Warner <warner@lothar.com>
3139 * buildbot/__init__.py: bump to 0.7.3+ while between releases
3140 * docs/buildbot.texinfo: same
3142 2006-05-23 Brian Warner <warner@lothar.com>
3144 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
3145 * docs/buildbot.texinfo: set version to match
3146 * NEWS: update for 0.7.3
3148 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
3149 give a quick mapping from VC system to possible ChangeSources
3150 (Build Properties): add 'buildername'
3152 * buildbot/process/base.py (Build.setupStatus): oops, set
3153 'buildername' and 'buildnumber' properties
3154 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
3157 2006-05-22 Brian Warner <warner@lothar.com>
3159 * docs/buildbot.texinfo (Build Properties): explain the syntax of
3160 property interpolation better
3162 * README (INSTALLATION): remove old '-v' argument from recommended
3165 * docs/buildbot.texinfo (ShellCommand): add docs for description=
3166 and descriptionDone= arguments. Thanks to Niklaus Giger for the
3169 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
3170 'svnversion' instead of grepping the output of 'svn info', much
3171 simpler and avoids CR/LF problems on windows. Thanks to Olivier
3172 Bonnet for the suggestion.
3173 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
3174 require the WC_PATH argument, so run 'svnversion .' instead.
3176 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
3177 aren't supposed to have 'self' in their argument list
3179 2006-05-21 Brian Warner <warner@lothar.com>
3181 * buildbot/process/step.py (ShellCommand.start): make
3182 testInterpolate pass. I was passing the uninterpolated command to
3183 the RemoteShellCommand constructor
3184 (ShellCommand._interpolateProperties): oops, handle non-list
3185 commands (i.e. strings with multiple words separated by spaces in
3186 them) properly, instead of forgetting about them.
3188 * buildbot/test/test_properties.py (Run.testInterpolate): new test
3189 to actually try to use build properties in a real build. This test
3191 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
3192 to start and evaluate builds
3194 * buildbot/test/test__versions.py: add a pseudo-test to record
3195 what version of Twisted/Python/Buildbot are running. This should
3196 show up at the beginning of _trial_tmp/test.log, and exists to help
3197 debug other problems.
3199 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
3200 a filename to be served as 'robots.txt' to discourage web spiders.
3201 Adapted from a patch by Tobi Vollebregt, thanks!
3202 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
3203 (Waterfall.test_waterfall): tweak the way that filenames are put
3204 into the config file, to accomodate windows pathnames better.
3206 * docs/buildbot.texinfo (HTML Waterfall): document it
3208 * buildbot/process/process_twisted.py
3209 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
3210 changed the build process. The new setup.py no longer takes the
3212 (FullTwistedBuildFactory.__init__): same
3213 (TwistedReactorsBuildFactory.__init__): same
3215 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
3216 be placed in the [hooks] section of the central repository (the
3217 one that everybody pushes changes to).
3219 2006-05-20 Brian Warner <warner@lothar.com>
3221 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
3222 .darcs-context file, use binary mode. I think this was causing a
3223 Darcs failure under windows.
3225 2006-05-19 Brian Warner <warner@lothar.com>
3227 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
3228 use a timezone string of +0000 and gmtime, since this timestamp is
3229 sent to a buildmaster and %z is broken.
3231 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
3232 string and localtime, since this timestamp will only be consumed
3233 locally, and %z is broken.
3235 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
3236 gmtime, since this timestamp is returned to the buildmaster, and
3239 2006-05-18 Brian Warner <warner@lothar.com>
3241 * NEWS: update in preparation for next release
3243 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
3244 setup-repository and do-we-have-the-vc-tools code into a separate
3245 "helper" class, which sticks around in a single module-level
3246 object. This seems more likely to continue to work in the future
3247 than having it hide in the TestCase and hope that TestCases stick
3248 around for a long time.
3250 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
3251 addremove' has been deprecated in recent versions of mercurial, so
3252 use 'hg add' instead
3254 2006-05-07 Brian Warner <warner@lothar.com>
3256 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
3257 operating under windows, move the file before opening it, since
3258 you can't rename a file that somebody has open.
3260 * buildbot/process/base.py (Build.setupBuild): if something goes
3261 wrong while creating a Step, log the name and arguments, since the
3262 error message when you get the number of arguments wrong is really
3265 2006-05-06 Brian Warner <warner@lothar.com>
3267 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
3268 bugs in twisted-specific code not covered by my unit tests, this
3269 time use 'cmd' argument instead of self.cmd
3271 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
3272 fix stupid braino: either use startwith or find()==0, not both.
3273 (TwistedReactorsBuildFactory.__init__): another dumb typo
3275 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
3276 mark this test as TODO under windows, since process-killing seems
3277 dodgy there. We'll come back to this later and try to fix it
3280 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
3281 and don't include a timezone
3282 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
3283 This should avoid the windows-with-verbose-timezone-name problem
3285 (Patch.testPatch): add a test which runs 'patch' with less
3286 overhead than the full VCBase.do_patch sequence, to try to isolate
3287 a windows test failure. This one uses slave.commands.ShellCommand
3288 and 'patch', but none of the VC code.
3290 * buildbot/slave/commands.py (getCommand): use which() to find the
3291 executables for 'cvs', 'svn', etc. This ought to help under
3294 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
3295 working directory before starting. If an earlier test failed, the
3296 leftover directory would mistakenly flunk a later test.
3297 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
3298 Make sure that we use the right commandlines if which("tla") picks
3299 up "tla.exe" (as it does under windows).
3300 (TlaSupport.do_get): factor out this tla-vs-baz difference
3301 (TlaSupport.vc_create): more tla-vs-baz differences
3303 * buildbot/test/test_slavecommand.py
3304 (ShellBase.testShellMissingCommand): stop trying to assert
3305 anything about the error message: different shells on different
3306 OSes with different languages makes it hard, and it really isn't
3307 that interesting of a thing to test anyway.
3309 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
3310 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
3311 "Panther"), because it has a bug which flunks a couple tests in
3312 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
3313 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
3314 able to test that yet.
3316 2006-04-30 Brian Warner <warner@lothar.com>
3318 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
3319 make sure child commands emit messages in english, so our regexps
3320 will match. Thanks to Nikaus Giger for identifying the problems.
3321 (VCBase._do_vctest_export_1): mode="export" is not responsible
3322 for setting the "got_revision" property, since in many cases it is
3323 not convenient to determine.
3324 (SVNSupport.capable): when running 'svn --version' to check for
3325 ra_local, we want error messages in english
3326 * buildbot/test/test_slavecommand.py
3327 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
3328 to emit the error message in english
3330 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
3331 the environment with $LC_ALL="C" so that Commands which need to
3332 parse the output of their child processes can obtain it in
3334 (SVN.parseGotRevision): call "svn info" afterwards instead of
3335 watching the output of the "svn update" or "svn checkout".
3336 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
3337 (Arch.parseGotRevision): same
3338 (Bazaar.parseGotRevision): same
3339 (Mercurial.parseGotRevision): same
3341 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
3342 $LC_ALL="C" when running commands under 'buildbot try', too
3344 * buildbot/test/__init__.py: remove the global os.environ()
3345 setting, instead we do it just for the tests that run commands and
3346 need to parse their output.
3348 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
3349 remove the overly-short .timeout on this test, because non-DNotify
3350 platforms must fall back to polling which happens at 10 second
3351 intervals, so a 5 second timeout would never succeed.
3353 2006-04-24 Brian Warner <warner@lothar.com>
3355 * docs/buildbot.texinfo (Installing the code): update trial
3356 invocation, SF#1469116 by Niklaus Giger.
3357 (Attributes of Changes): updated branch-name examples to be
3358 a bit more realistic, SF#1475240 by Stephen Davis.
3360 * contrib/windows/buildbot2.bat: utility wrapper for windows
3361 developers, contributed by Nick Trout (after a year of neglect..
3362 sorry!). SF#1194231.
3364 * buildbot/test/test_vc.py (*.capable): store the actual VC
3365 binary's pathname in VCS[vcname], so it can be retrieved later
3366 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
3367 strip out non-numeric timezone information, specifically the funky
3368 German string that his system produced that confuses CVS.
3369 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
3370 allow Darcs tests to work on windows
3371 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
3372 procutils.which() everywhere, to allow tryclient to work under
3373 windows. Also from Niklaus Giger, SF#1463394.
3375 * buildbot/twcompat.py (which): move the replacement for a missing
3376 twisted.python.procutils.which from test_vc.py to here, so it can
3377 be used in other places too (specifically tryclient.py)
3379 2006-04-23 Brian Warner <warner@lothar.com>
3381 * buildbot/status/html.py (StatusResourceBuild.body): replace the
3382 bare buildbotURL/projectName line with a proper DIV, along with a
3383 CSS class of "title", from Stefan Seefeld (SF#1461675).
3384 (WaterfallStatusResource.body0): remove the redundant 'table'
3385 class from the table
3386 (WaterfallStatusResource.body): same. Also add class="LastBuild"
3387 to the top-row TR, and class="Activity" to the second-row TR,
3388 rather than putting them in the individual TD nodes.
3390 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
3391 'got_revision' build property for all VC systems that implement
3392 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
3394 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
3395 to determine which revision we actually obtained
3396 (CVS.parseGotRevision): implement this for CVS, which just means
3397 to grab a timestamp. Not ideal, and it depends upon the buildslave
3398 having a clock that is reasonably well syncronized with the server,
3399 but it's better than nothing.
3400 (SVN.parseGotRevision): implement it for SVN, which is accurate
3401 (Darcs.parseGotRevision): same
3402 (Arch.parseGotRevision): same
3403 (Bazaar.parseGotRevision): same
3404 (Mercurial.parseGotRevision): same
3406 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
3407 keep a record of all non-stdout/stderr/header/rc status updates,
3408 for the benefit of RemoteCommands that send other useful things,
3410 (Source.commandComplete): put any 'got_revision' status values
3411 into a build property of the same name
3414 * buildbot/process/step_twisted.py (Trial): update to deal with
3415 new ShellCommand refactoring
3417 * docs/buildbot.texinfo (Build Properties): document new feature
3418 that allows BuildSteps to get/set Build-wide properties like which
3419 revision was requested and/or checked out.
3421 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
3422 * buildbot/status/builder.py (BuildStatus.getProperty): implement
3423 it. Note that this bumps the persistenceVersion of the saved Build
3424 object, so add the necessary upgrade-old-version logic to include
3425 an empty properties dict.
3427 * buildbot/process/base.py (Build.setProperty): implement it
3428 (Build.getProperty): same
3429 (Build.startBuild): change build startup to set 'branch',
3430 'revision', and 'slavename' properties at the right time
3432 * buildbot/process/step.py (BuildStep.__init__): change setup to
3433 require 'build' argument in a better way
3434 (LoggingBuildStep): split ShellCommand into two pieces, for better
3435 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
3436 a single RemoteCommand that sends stdout/stderr status text. It
3437 also provides the usual commandComplete / createSummary /
3438 evaluateCommand / getText methods to be overridden...
3439 (ShellCommand): .. whereas ShellCommand is specifically for
3440 running RemoteShellCommands. Other shell-like BuildSteps (like
3441 Source) can inherit from LoggingBuildStep instead of ShellCommand
3442 (WithProperties): marker class to do build-property interpolation
3443 (Source): inherit from LoggingBuildStep instead of ShellCommand
3446 * buildbot/test/test_properties.py: test new functionality
3448 2006-04-21 Brian Warner <warner@lothar.com>
3450 * buildbot/test/test_vc.py: rename testBranch to
3451 testCheckoutBranch to keep the tests in about the right
3454 2006-04-18 Brian Warner <warner@lothar.com>
3456 * docs/buildbot.texinfo (PBListener): improve cross-references
3457 between PBListener and 'buildbot statusgui', thanks to John Pye
3460 2006-04-17 Brian Warner <warner@lothar.com>
3462 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
3463 running under Twisted-1.3.0, otherwise skipped tests are reported
3466 * all: use isinstance() instead of 'type(x) is foo', suggested by
3469 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3470 oops, fix a brain-fade from the other week, when making the
3471 addStep changes. I changed all the __init__ upcalls to use the
3472 wrong superclass name.
3473 (FullTwistedBuildFactory.__init__): same
3474 (TwistedDebsBuildFactory.__init__): same
3475 (TwistedReactorsBuildFactory.__init__): same
3476 (TwistedBuild.isFileImportant): use .startswith for clarity,
3477 thanks to Neal Norwitz for the suggestions.
3479 * contrib/viewcvspoll.py: script to poll a viewcvs database for
3480 changes, then deliver them over PB to a remote buildmaster.
3482 * contrib/svnpoller.py: added script by John Pye to poll a remote
3483 SVN repository (by running 'svn log') from a cronjob, and run
3484 'buildbot sendchange' to deliver the changes to a remote
3486 * contrib/svn_watcher.py: added script by Niklaus Giger (a
3487 modification of svnpoller.py), same purpose, but this one loops
3488 internally (rather than expecting to run from a cronjob) and works
3490 * contrib/README.txt: same
3492 2006-04-11 Brian Warner <warner@lothar.com>
3494 * all: fix a number of incorrect names and missing imports, thanks
3495 to Anthony Baxter for the patch.
3496 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
3497 remove unused buggy method.
3498 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
3499 comes from shutil, not "shutils"
3500 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
3501 (Arch.checkSlaveVersion): same
3502 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
3504 * buildbot/process/step_twisted2.py: add some missing imports
3505 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
3506 this code used to live in twisted.internet.defer
3508 2006-04-10 Brian Warner <warner@lothar.com>
3510 * buildbot/process/step.py (Mercurial): add Mercurial support
3511 * buildbot/slave/commands.py (Mercurial): same
3512 * buildbot/scripts/tryclient.py (MercurialExtractor): same
3513 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
3514 not yet tested, but 'try' support *is* covered
3515 * docs/buildbot.texinfo (Mercurial): document it
3517 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
3518 some debugging messages (turned off)
3519 * buildbot/test/test_vc.py: improve debug messages
3521 2006-04-07 Brian Warner <warner@lothar.com>
3523 * buildbot/test/test_vc.py (which): define our own which() in case
3524 we can't import twisted.python.procutils, because procutils doesn't
3525 exist in Twisted-1.3
3527 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
3528 of SlaveLocks for performance tests
3530 * docs/examples/twisted_master.cfg: update to match current usage
3532 * buildbot/changes/p4poller.py (P4Source): add new arguments:
3533 password, p4 binary, pollinterval, maximum history to check.
3534 Patch from an anonymous sf.net contributor, SF#1219384.
3535 * buildbot/process/step.py (P4Sync.__init__): add username,
3536 password, and client arguments.
3537 * buildbot/slave/commands.py (P4Sync): same
3539 2006-04-05 Brian Warner <warner@lothar.com>
3541 * buildbot/process/factory.py (BuildFactory.addStep): new method
3542 to add steps to a BuildFactory. Use it instead of f.steps.append,
3543 and you can probably avoid using the s() convenience function.
3544 Patch from Neal Norwitz, sf.net #1412605.
3545 (other): update all factories to use addStep
3546 * buildbot/process/process_twisted.py: update all factories to use
3549 2006-04-03 Brian Warner <warner@lothar.com>
3551 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
3552 work under windows too. Adapted from a patch by Niklaus Giger,
3553 addresses SF#1463399.
3555 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
3556 spawned commands emit parseable results in english and not some
3557 other language. Patch from Niklaus Giger, SF#1463395.
3559 * README (INSTALLATION): discourage users from running unit tests on
3560 a "network drive", patch from Niklaus Giger, SF#1463394.
3562 2006-03-22 Brian Warner <warner@lothar.com>
3564 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
3565 function to turn a repository-relative pathname into a (branch,
3566 branch-relative-filename) tuple. Change this function to handle
3567 the branch naming policy used by your Subversion repository.
3568 Thanks to AllMyData.com for sponsoring this work.
3570 2006-03-16 Brian Warner <warner@lothar.com>
3572 * buildbot/scripts/sample.cfg: add python-mode declaration for
3573 vim. Thanks to John Pye for the patch.
3575 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
3576 command line, mention the importance of running 'crontab' as the
3577 buildmaster/buildslave user. Thanks to John Pye for the catch.
3579 2006-03-13 Brian Warner <warner@lothar.com>
3581 * buildbot/status/words.py (IRC): add an optional password=
3582 argument, which will be sent to Nickserv in an IDENTIFY message at
3583 login, to claim the nickname. freenode requires this before the
3584 bot can sent (or reply to) private messages. Thanks to Clement
3585 Stenac for the patch.
3586 * docs/buildbot.texinfo (IRC Bot): document it
3588 * buildbot/status/builder.py (LogFile.merge): don't write chunks
3589 larger than chunkSize. Fixes SF#1349253.
3590 * buildbot/test/test_status.py (Log.testLargeSummary): test it
3591 (Log.testConsumer): update to match new internal chunking behavior
3593 2006-03-12 Brian Warner <warner@lothar.com>
3595 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
3597 * buildbot/test/test_maildir.py (MaildirTest): rename the
3598 'timeout' method, as it collides with trial's internals
3600 * buildbot/scripts/runner.py: add 'buildbot restart' command
3601 (stop): don't sys.exit() out of here, otherwise restart can't work
3602 * docs/buildbot.texinfo (Shutdown): document it
3604 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
3605 * buildbot/status/html.py (Waterfall.__init__): same
3606 * buildbot/process/builder.py (Builder.startBuild): same
3607 * buildbot/process/base.py (BuildRequest): same
3608 * buildbot/sourcestamp.py (SourceStamp): same
3609 * buildbot/scheduler.py (Nightly): same
3611 * buildbot/__init__.py (version): bump to 0.7.2+ while between
3613 * docs/buildbot.texinfo: same
3615 2006-02-17 Brian Warner <warner@lothar.com>
3617 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
3618 * docs/buildbot.texinfo: set version number to match
3619 * NEWS: update for 0.7.2
3621 2006-02-16 Brian Warner <warner@lothar.com>
3623 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
3625 2006-02-09 Brian Warner <warner@lothar.com>
3627 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
3628 add text to explain per-build branch parameters
3629 * NEWS: mention --umask
3631 2006-02-08 Brian Warner <warner@lothar.com>
3633 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
3635 (SlaveOptions.optParameters): add --umask, to make it possible to
3636 make buildslave-generated files (including build products) be
3639 * buildbot/slave/bot.py (BuildSlave.startService): same
3641 2006-01-23 Brian Warner <warner@lothar.com>
3643 * buildbot/status/builder.py: urllib.quote() all URLs that include
3644 Builder names, so that builders can include characters like '/'
3645 and ' ' without completely breaking the resulting HTML. Thanks to
3646 Kevin Turner for the patch.
3647 * buildbot/status/html.py: same
3648 * buildbot/test/test_web.py (GetURL.testBuild): match changes
3650 * NEWS: update in preparation for upcoming release
3652 2006-01-18 Brian Warner <warner@lothar.com>
3654 * docs/examples/twisted_master.cfg: update to match the Twisted
3655 buildbot: remove python2.2, switch to exarkun's buildslaves,
3656 disable the .deb builder until we figure out how to build twisted
3657 .debs from SVN, add some ktrace debugging to the OS-X build
3658 process and remove the qt build, remove threadless builders,
3659 change freebsd builder to use landonf's buildslave.
3661 2006-01-12 Brian Warner <warner@lothar.com>
3663 * buildbot/master.py (Manhole.__init__): let port= be a strports
3664 specification string, but handle a regular int for backwards
3665 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
3666 used in master.cfg to limit connections to just the local host.
3667 (BuildMaster.loadConfig): same for c['slavePortnum']
3668 * buildbot/scheduler.py (Try_Userpass.__init__): same
3669 * buildbot/status/client.py (PBListener.__init__): same
3670 * buildbot/status/html.py (Waterfall.__init__): same, for both
3671 http_port and distrib_port. Include backwards-compatibility checks
3672 so distrib_port can be a filename string and still mean unix:/foo
3673 * docs/buildbot.texinfo (Setting the slaveport): document it
3674 (Debug options): same
3675 (HTML Waterfall): same
3678 * buildbot/test/test_config.py (ConfigTest): test it
3680 * buildbot/master.py (BuildMaster.loadConfig): wait for the
3681 slaveport's disownServiceParent deferred to fire before opening
3682 the new one. Fixes an annoying bug in the unit tests.
3684 2006-01-03 Brian Warner <warner@lothar.com>
3686 * buildbot/master.py (BuildMaster): remove the .schedulers
3687 attribute, replacing it with an allSchedulers() method that looks
3688 for all IService children that implement IScheduler. Having only
3689 one parent/child relationship means fewer opportunities for bugs.
3690 (BuildMaster.allSchedulers): new method
3691 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
3692 also fix ugly bug that caused any config-file reload to
3693 half-forget about the earlier Schedulers, causing an exception
3694 when a Change arrived and was handed to a half-connected
3695 Scheduler. The exception was in scheduler.py line 54ish:
3696 self.parent.submitBuildSet(bs)
3697 exceptions.AttributeError: 'NoneType' object has no attribute
3699 (BuildMaster.addChange): update to use allSchedulers()
3701 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
3702 to work properly with twisted-1.3.0, where you must explicitly
3703 include the __implements__ from parent classes
3704 (BaseScheduler.__repr__): make it easier to distinguish distinct
3706 (BaseUpstreamScheduler.__implements__): same
3708 * buildbot/status/builder.py (Status.getSchedulers): update to
3710 * buildbot/test/test_run.py (Run.testMaster): same
3711 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
3712 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
3713 make sure Scheduler instances are left alone when an identical
3714 config file is reloaded
3715 (ConfigElements.testSchedulers): make sure Schedulers are properly
3718 * Makefile (TRIALARGS): my local default Twisted version is now
3719 2.1.0, update the trial arguments accordingly
3721 2005-12-22 Brian Warner <warner@lothar.com>
3723 * docs/examples/twisted_master.cfg: merge changes from pyr: add
3726 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
3727 addChange in the parent class, although I suspect this should be
3728 fixed better in the future.
3730 2005-11-26 Brian Warner <warner@lothar.com>
3732 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
3733 explode when branch==None, thanks to Kevin Turner for the catch
3734 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
3737 * buildbot/__init__.py (version): bump to 0.7.1+ while between
3739 * docs/buildbot.texinfo: same
3741 2005-11-26 Brian Warner <warner@lothar.com>
3743 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
3744 * docs/buildbot.texinfo: set version number to match
3746 2005-11-26 Brian Warner <warner@lothar.com>
3748 * NEWS: update for 0.7.1
3750 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
3751 sure that unsubscribe works even if we never sent an ETA update.
3752 Also, don't explode on duplicate unsubscribe.
3753 (BuildStepStatus.addLog): make the convenience "return self"-added
3754 watcher automatically unsubscribe when the Step finishes.
3755 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
3756 (BuildStatus.stepStarted): same auto-unsubscribe
3757 (BuilderStatus.buildStarted): same auto-unsubscribe
3759 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
3761 (IStatusReceiver.stepStarted): same
3762 (IStatusReceiver.logStarted): same
3764 * buildbot/test/test_run.py (Status): move the Status test..
3765 * buildbot/test/test_status.py (Subscription): .. to here
3767 2005-11-25 Brian Warner <warner@lothar.com>
3769 * NEWS: more updates
3771 * buildbot/locks.py: fix the problem in which loading a master.cfg
3772 file that changes some Builders (but not all of them) can result
3773 in having multiple copies of the same Lock. Now, the real Locks
3774 are kept in a table inside the BotMaster, and the Builders/Steps
3775 use "LockIDs", which are still instances of MasterLock and
3776 SlaveLock. The real Locks are instances of the new RealMasterLock
3777 and RealSlaveLock classes.
3778 * buildbot/master.py (BotMaster.getLockByID): new method to
3779 convert LockIDs into real Locks.
3780 * buildbot/process/base.py (Build.startBuild): convert LockIDs
3781 into real Locks before building
3782 * buildbot/process/step.py (BuildStep.startStep): same
3783 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
3784 exercises the problem
3787 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
3788 what Schedulers are available
3790 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
3791 work by Dobes Vandermeer and hacked mercilessly by me. This offers
3792 'cron'-style build scheduling at certain times of day, week,
3794 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
3796 * buildbot/scheduler.py (Scheduler): change fileIsImportant
3797 handling: treat self.fileIsImportant more as an attribute that
3798 contains a callable than as a method. If the attribute is None,
3799 don't call it and assume all filenames are important. It is still
3800 possible to provide a fileIsImportant method in a subclass,
3802 (AnyBranchScheduler): handle fileIsImportant=None, previously it
3804 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
3805 test using AnyBranchScheduler with fileIsImportant=None
3807 2005-11-24 Brian Warner <warner@lothar.com>
3809 * buildbot/test/test_config.py (StartService): don't claim a fixed
3810 port number, instead set slavePort=0 on the first pass, figure out
3811 what port was allocated, then switch to a config file that uses
3814 * buildbot/master.py (BuildMaster.loadConfig): close the old
3815 slaveport before opening the new one, because unit tests might
3816 replace slavePort=0 with the same allocated portnumber, and if we
3817 don't wait for the old port to close first, we get a "port already
3818 in use" error. There is a tiny race condition here, but the only
3819 threat is from other programs that bind (statically) to the same
3820 port number we happened to be allocated, and only if those
3821 programs use SO_REUSEADDR, and only if they get control in between
3824 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
3826 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
3827 deleted ChangeSources before adding any new ones
3828 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
3829 compare_attrs, to make sure that a config-file reload does not
3830 unnecessarily replace an unmodified ChangeSource instance
3831 * buildbot/test/test_config.py (ConfigTest.testSources): update
3833 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
3834 mean "don't build anything", and add a warning if it gets used
3835 because it isn't actually useful.
3837 * contrib/svn_buildbot.py: update example usage to match the port
3838 number that gets used by the PBChangeSource
3839 * buildbot/scripts/sample.cfg: add example of PBChangeSource
3841 2005-11-22 Brian Warner <warner@lothar.com>
3843 * NEWS: start collecting items for next release
3845 * buildbot/process/step.py (SVN.computeSourceRevision): assume
3846 revisions are strings
3847 (P4Sync.computeSourceRevision): same
3849 * buildbot/status/html.py (StatusResourceBuild.body): add a link
3850 to the Buildbot's overall status page
3851 (StatusResourceBuilder.body): same
3853 2005-11-15 Brian Warner <warner@lothar.com>
3855 * buildbot/master.py (BuildMaster.loadConfig): serialize the
3856 config-file loading, specifically to make sure old StatusTargets
3857 are finished shutting down before new ones start up (thus
3858 resolving a bug in which changing the Waterfall object would fail
3859 because both new and old instances were claiming the same
3860 listening port). Also load new Schedulers after all the new
3861 Builders are set up, in case they fire off a new build right away.
3862 * buildbot/test/test_config.py (StartService): test it
3864 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
3865 the branch name to the mail body
3867 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
3868 Without it, a config-file reload fails to update an existing
3870 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
3871 username/passwd to compare_attrs, for the same reason
3872 * buildbot/status/html.py (Waterfall): add favicon to
3873 compare_attrs, same reason
3875 2005-11-05 Brian Warner <warner@lothar.com>
3877 * buildbot/scripts/tryclient.py (createJobfile): stringify the
3878 baserev before stuffing it in the jobfile. This resolves problems
3879 under SVN (and probably Arch) where revisions are expressed as
3880 numbers. I'm inclined to use string-based revisions everywhere in
3881 the future, but this fix should be safe for now. Thanks to Steven
3882 Walter for the patch.
3884 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
3885 binary mode when opening pickle files, to make windows work
3886 better. Thanks to Dobes Vandermeer for the catch.
3887 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3888 (BuilderStatus.getBuildByNumber): same
3889 (Status.builderAdded): same
3890 * buildbot/master.py (BuildMaster.loadChanges): same
3892 * buildbot/util.py (Swappable): delete unused leftover code
3894 * buildbot/process/step.py (SVN): when building on a non-default
3895 branch, add the word "[branch]" to the VC step's description, so
3896 it is obvious that we're not building the usual stuff. Likewise,
3897 when we are building a specific revision, add the text "rNNN" to
3898 indicate what that revision number is. Thanks to Brad Hards and
3899 Nathaniel Smith for the suggestion.
3900 (Darcs.startVC): same
3901 (Arch.startVC): same
3902 (Bazaar.startVC): same
3904 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3905 typo, caught by Mark Dillavou, closes SF#1216636.
3907 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3908 about a test to add some day
3910 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3911 the 'full-2.3' build, and the 'reactors' build is now run under
3912 python-2.4 because the buildslave no longer has gtk/etc bindings
3913 for earlier versions.
3915 2005-11-03 Brian Warner <warner@lothar.com>
3917 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3918 method, takes an IBuildStatus and rebuilds it. It might make more
3919 sense to add this to IBuildControl instead, but that instance goes
3920 away completely once the build has finished, and resubmitting
3921 builds can take place weeks later.
3922 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3923 * buildbot/status/html.py (StatusResourceBuild): also stash an
3924 IBuilderControl so we can use resubmitBuild.
3925 (StatusResourceBuild.body): render "resubmit" button if we can.
3926 Also add hrefs for each BuildStep
3927 (StatusResourceBuild.rebuild): add action for "resubmit" button
3928 (StatusResourceBuilder.getChild): give it an IBuilderControl
3930 * buildbot/status/builder.py (Status.getURLForThing): change the
3931 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3932 that live as targets of buttons like "stop" and "rebuild" can't
3934 * buildbot/status/builder.py (Status.getURLForThing): same
3935 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3936 (StepBox.getBox): same
3937 * buildbot/test/test_web.py (GetURL): same
3940 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3941 exclusivity checks after Source.__init__ upcall, so misspelled
3942 arguments will be reported more usefully
3943 (Darcs.__init__): same
3945 2005-10-29 Brian Warner <warner@lothar.com>
3947 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3948 builder. Move the Try scheduler off to a separate port.
3950 2005-10-27 Brian Warner <warner@lothar.com>
3952 * buildbot/clients/gtkPanes.py
3953 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3954 to cause the app to crash, now they don't.
3956 * buildbot/clients/debug.py: display the buildmaster's location
3957 in the window's title bar
3959 2005-10-26 Brian Warner <warner@lothar.com>
3961 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3962 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3963 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3965 * buildbot/status/html.py (td): put a single non-breaking space
3966 inside otherwise empty <td> elements, as a workaround for buggy
3967 browsers which would optimize them away (along with any associated
3968 styles, like the kind that create the waterfall grid borders).
3969 Patch from Frerich Raabe.
3971 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3972 argv-list as an argument, defaulting to ["-to"], which is
3973 appropriate for the Trial that comes with Twisted-2.1.0 and
3974 earlier. The Trial in current Twisted SVN wants
3975 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3976 defaults to an empty list.
3977 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3978 match it, now that trialMode= is a list instead of a single string
3980 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3982 * docs/buildbot.texinfo: same
3984 2005-10-24 Brian Warner <warner@lothar.com>
3986 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3987 * docs/buildbot.texinfo: set version number to match
3989 2005-10-24 Brian Warner <warner@lothar.com>
3991 * README: update for 0.7.0
3993 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3995 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3996 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3997 send the branch= argument unless the user really provided one, to
3998 retain compatibility with older buildmasters that don't accept
4000 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4003 * docs/buildbot.texinfo: update lots of stuff
4005 * buildbot/scripts/runner.py (sendchange): add a --branch argument
4006 to the 'buildbot sendchange' command
4007 * buildbot/clients/sendchange.py (Sender.send): same
4008 * buildbot/changes/pb.py (ChangePerspective): same
4009 * buildbot/test/test_changes.py (Sender.testSender): test it
4011 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
4012 'default_branch' argument names to 'baseURL' and 'defaultBranch',
4013 for consistency with other BuildStep arguments that use camelCase.
4014 Well, at least more of them use camelCase (like flunkOnWarnings)
4015 than don't.. I wish I'd picked one style and stuck with it
4016 earlier. Annoying, but it's best done before the release, since
4017 these arguments didn't exist at all in 0.6.6 .
4019 * buildbot/test/test_vc.py (SVN.testCheckout): same
4020 (Darcs.testPatch): same
4021 * docs/buildbot.texinfo (SVN): document the change
4022 (Darcs): same, add some build-on-branch docs
4023 * docs/examples/twisted_master.cfg: match change
4025 * buildbot/process/step.py (BuildStep): rename
4026 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
4027 how it is normally used.
4028 * buildbot/test/test_steps.py (Version.checkCompare): same
4030 * buildbot/process/step.py (CVS.startVC): refuse to build
4031 update/copy -style builds on a non-default branch with an old
4032 buildslave (<=0.6.6) that doesn't know how to do it properly. The
4033 concern is that it will do a VC 'update' in an existing tree when
4034 it is supposed to be switching branches (and therefore clobbering
4035 the tree to do a full checkout), thus building the wrong source.
4036 This used to be a warning, but I think the confusion it is likely
4037 to cause warrants making it an error.
4038 (SVN.startVC): same, also make mode=export on old slaves an error
4039 (Darcs.startVC): same
4040 (Git.startVC): improve error message for non-Git-enabled slaves
4041 (Arch.checkSlaveVersion): same. continue to emit a warning when a
4042 specific revision is built on a slave that doesn't pay attention
4043 to args['revision'], because for slowly-changing trees it will
4044 probably do the right thing, and because we have no way to tell
4045 whether we're asking it to build the most recent version or not.
4046 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
4048 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
4049 that 'master' is in host:portnum format, to catch errors sooner
4051 2005-10-23 Brian Warner <warner@lothar.com>
4053 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
4054 when creating the list of warning messages, include the line
4055 immediately after each WARNING: line, since that's usually where
4056 the file and line number wind up.
4058 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
4063 2005-10-22 Brian Warner <warner@lothar.com>
4065 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
4066 patch from Brad Hards
4067 * buildbot/status/classic.css: same
4068 * buildbot/test/test_web.py (Waterfall): match changes
4070 * buildbot/test/test_steps.py (BuildStep.setUp): set
4071 nextBuildNumber so the test passes
4072 * buildbot/test/test_status.py (MyBuilder): same
4074 * buildbot/status/html.py (StatusResourceBuild.body): revision
4075 might be numeric, so stringify it before html-escapifying it
4076 (CurrentBox.getBox): add a "waiting" state, and show a countdown
4077 timer for the upcoming build
4078 * buildbot/status/classic.css: add background-color attributes for
4079 offline/waiting/building classes
4081 * buildbot/status/builder.py (BuildStatus): derive from
4082 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
4083 the default (i.e. unknown) .slavename to "???" instead of None,
4084 since even unknown slavenames need to be printed eventually.
4085 (BuilderStatus): also derive from styles.Versioned . More
4086 importantly, determine .nextBuildNumber at creation/unpickling
4087 time by scanning the directory of saved BuildStatus instances and
4088 choosing one larger than the highest-numbered one found. This
4089 should fix the problem where random errors during upgrades cause
4090 the buildbot to forget about earlier builds. .nextBuildNumber is
4091 no longer stored in the pickle.
4092 (Status.builderAdded): if we can't unpickle the BuilderStatus,
4093 at least log the error. Also call Builder.determineNextBuildNumber
4094 once the basedir is set.
4096 * buildbot/master.py (BuildMaster.loadChanges): do
4097 styles.doUpgrade afterwards, in case I decide to make Changes
4098 derived from styles.Versioned some day and forget to make this
4102 * buildbot/test/test_runner.py (Options.testForceOptions): skip
4103 when running under older pythons (<2.3) in which the shlex module
4104 doesn't have a 'split' function.
4106 * buildbot/process/step.py (ShellCommand.start): make
4107 errorMessages= be a list of strings to stuff in the log before the
4108 command actually starts. This makes it easier to flag multiple
4109 warning messages, e.g. when the Source steps have to deal with an
4111 (CVS.startVC): handle slaves that don't handle multiple branches
4112 by switching into 'clobber' mode
4113 (SVN.startVC): same. Also reject branches without base_url
4114 (Darcs.startVC): same. Also reject revision= in older slaves
4115 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
4116 (Bazaar.startVC): same, and test for baz separately than for arch
4118 * buildbot/slave/commands.py (cvs_ver): document new features
4120 * buildbot/process/step.py (BuildStep.slaveVersion): document it
4121 (BuildStep.slaveVersionNewEnough): more useful utility method
4122 * buildbot/test/test_steps.py (Version): start testing it
4124 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
4125 the 'force' command requires python2.3, for the shlex.split method
4127 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
4128 since we don't use it anymore. The Twisted buildbot uses a
4131 2005-10-21 Brian Warner <warner@lothar.com>
4133 * buildbot/process/process_twisted.py: rework all BuildFactory
4134 classes to take a 'source' step as an argument, instead of
4135 building up the SVN instance in the factory.
4136 * docs/examples/twisted_master.cfg: enable build-on-branch by
4137 providing a base_url and default_branch
4139 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
4140 control over --branch and --revision, not that they are always
4142 * buildbot/status/html.py (StatusResourceBuilder.force): same
4143 (StatusResourceBuild.body): display SourceStamp components
4145 * buildbot/scripts/runner.py (ForceOptions): option parser for the
4146 IRC 'force' command, so it can be shared with an eventual
4147 command-line-tool 'buildbot force' mode.
4148 * buildbot/test/test_runner.py (Options.testForceOptions): test it
4150 2005-10-20 Brian Warner <warner@lothar.com>
4152 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
4154 * docs/examples/twisted_master.cfg: update to use Schedulers
4156 * buildbot/scripts/sample.cfg: update with Schedulers
4158 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
4159 method specifically for use by HTML "force build" button and the
4160 IRC "force" command. Raises an immediate error if there are no
4162 (IBuilderControl.requestBuild): make this just submit a build, not
4163 try to check for existing slaves or set up any when-finished
4164 Deferreds or anything.
4165 * buildbot/process/builder.py (BuilderControl): same
4166 * buildbot/status/html.py (StatusResourceBuilder.force): same
4167 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4168 * buildbot/test/test_slaves.py: same
4169 * buildbot/test/test_web.py: same
4171 2005-10-19 Brian Warner <warner@lothar.com>
4173 * docs/examples/twisted_master.cfg: re-sync with reality: bring
4174 back python2.2 tests, turn off OS-X threadedselect-reactor tests
4176 2005-10-18 Brian Warner <warner@lothar.com>
4178 * buildbot/status/html.py: provide 'status' argument to most
4179 StatusResourceFOO objects
4180 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
4181 and Logfiles" section to make the Build page into a more-or-less
4182 comprehensive source of status information about the build
4184 * buildbot/status/mail.py (MailNotifier): include the Build's URL
4185 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
4187 2005-10-17 Brian Warner <warner@lothar.com>
4189 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
4190 arguments to accomodate Twisted >=2.1.0 . I will have to figure
4191 out what to do about other projects: the correct options for
4192 recent Twisteds will not work for older ones.
4194 2005-10-15 Brian Warner <warner@lothar.com>
4196 * buildbot/status/builder.py (Status.getURLForThing): add method
4197 to provide a URL for arbitrary IStatusFoo objects. The idea is to
4198 use this in email/IRC status clients to make them more useful, by
4199 providing the end user with hints on where to learn more about the
4200 object being reported on.
4201 * buildbot/test/test_web.py (GetURL): tests for it
4203 2005-10-14 Brian Warner <warner@lothar.com>
4205 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
4206 fix bug resulting from deferredResult changes
4208 2005-10-13 Brian Warner <warner@lothar.com>
4210 * buildbot/test/test_changes.py: remove use of deferredResult
4211 * buildbot/test/test_config.py: same
4212 * buildbot/test/test_control.py: same
4213 * buildbot/test/test_status.py: same
4214 * buildbot/test/test_vc.py: this is the only remaining use, since
4215 it gets used at module level. This needs to be replaced by some
4216 sort of class-level run-once routine.
4218 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
4220 * lots: implement multiple slaves per Builder, which means multiple
4221 current builds per Builder. Some highlights:
4222 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
4223 of (state,currentBuilds) instead of (state,currentBuild)
4224 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
4225 (IBuildStatus.getSlavename): new method, so you can tell which
4226 slave got used. This only gets set when the build completes.
4227 (IBuildRequestStatus.getBuilds): new method
4229 * buildbot/process/builder.py (SlaveBuilder): add a .state
4230 attribute to track things like ATTACHING and IDLE and BUILDING,
4232 (Builder): .. the .slaves attribute here, which has been turned
4233 into a simple list of available slaves. Added a separate
4234 attaching_slaves list to track ones that are not yet ready for
4236 (Builder.fireTestEvent): put off the test-event callback for a
4237 reactor turn, to make tests a bit more consistent.
4238 (Ping): cleaned up the slaveping a bit, now it disconnects if the
4239 ping fails due to an exception. This needs work, I'm worried that
4240 a code error could lead to a constantly re-connecting slave.
4241 Especially since I'm trying to move to a distinct remote_ping
4242 method, separate from the remote_print that we currently use.
4243 (BuilderControl.requestBuild): return a convenience Deferred that
4244 provides an IBuildStatus when the build finishes.
4245 (BuilderControl.ping): ping all connected slaves, only return True
4246 if they all respond.
4248 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
4249 reconnect when we shut down.
4251 * buildbot/status/builder.py: implement new methods, convert
4252 one-build-at-a-time methods to handle multiple builds
4253 * buildbot/status/*.py: do the same in all default status targets
4254 * buildbot/status/html.py: report the build's slavename in the
4255 per-Build page, report all buildslaves on the per-Builder page
4257 * buildbot/test/test_run.py: update/create tests
4258 * buildbot/test/test_slaves.py: same
4259 * buildbot/test/test_scheduler.py: remove stale test
4261 * docs/buildbot.texinfo: document the new builder-specification
4262 'slavenames' parameter
4264 2005-10-12 Brian Warner <warner@lothar.com>
4266 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
4267 report failure correctly, causing Dependent builds to run when
4268 they shouldn't have.
4269 * buildbot/status/builder.py (BuildSetStatus): same
4270 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
4271 (Set.testSuccess): test the both-pass case too
4272 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
4273 fix this test: it was ending too early, masking the failure before
4274 (Logger): specialized StatusReceiver to make sure the dependent
4275 builds aren't even started, much less completed.
4277 2005-10-07 Brian Warner <warner@lothar.com>
4279 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
4280 bot.SlaveBuilder being disowned in the middle of a build
4282 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
4283 this inherit from StatusReceiver. Also upcall in __init__. This
4284 fixes the embarrasing crash when the new buildSetSubmitted method
4285 is invoked and Waterfall/etc don't implement their own.
4286 * buildbot/test/test_run.py: add a TODO note about a test to catch
4287 just this sort of thing.
4289 * buildbot/process/builder.py (Builder.attached): remove the
4290 already-attached warning, this situation is normal. Add some
4291 comments explaining it.
4293 2005-10-02 Brian Warner <warner@lothar.com>
4295 * buildbot/changes/maildir.py (Maildir.start): Tolerate
4296 OverflowError when setting up dnotify, because some 64-bit systems
4297 have problems with signed-vs-unsigned constants and trip up on the
4298 DN_MULTISHOT flag. Patch from Brad Hards.
4300 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
4302 * buildbot/process/step.py (BuildStep, ShellCommand): Add
4303 progressMetrics, description, descriptionDone to the 'parms' list,
4304 and make use the 'parms' list from the implementation class
4305 instead of only BuildStep to initialize the parameters. This
4306 allows buildbot.process.factory.s() to initialize all the parms,
4307 not just those defined in directly by BuildStep.
4309 2005-09-03 Brian Warner <warner@lothar.com>
4311 * NEWS: start adding items for the next release
4313 * docs/examples/twisted_master.cfg: (sync with reality) turn off
4314 python2.2 tests, change 'Quick' builder to only use python2.3
4316 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
4318 * buildbot/status/html.py (StatusResourceBuilder.body): only show
4319 the "Ping Builder" button if the build control is available; the
4320 user sees an exception otherwise
4322 * docs/buildbot.texinfo (PBChangeSource): fix a typo
4324 2005-09-01 Brian Warner <warner@lothar.com>
4326 * buildbot/interfaces.py (IBuilderStatus.getState): update
4327 signature, point out that 'build' can be None
4328 (IBuildStatus.getETA): point out ETA can be none
4330 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
4332 * buildbot/status/words.py (IrcStatusBot.emit_status): same
4334 2005-08-31 Brian Warner <warner@lothar.com>
4336 * buildbot/status/base.py (StatusReceiver.builderChangedState):
4337 update to match correct signature: removed 'eta' argument
4338 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
4340 2005-08-30 Brian Warner <warner@lothar.com>
4342 * buildbot/status/builder.py (LogFile): remove the assertion that
4343 blows up when you try to overwrite an existing logfile, instead
4344 just emit a warning. This case gets hit when the buildmaster is
4345 killed and doesn't get a chance to write out the serialized
4346 BuilderStatus object, so the .nextBuildNumber attribute gets out
4349 * buildbot/scripts/runner.py (sendchange): add --revision_file to
4350 the 'buildbot sendchange' arguments, for the Darcs context file
4351 * docs/buildbot.texinfo (sendchange): document it
4353 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
4354 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
4355 (IStatus.getSchedulers): new method
4356 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
4357 (Status.getSchedulers): implement
4358 * buildbot/process/builder.py (Builder): maintain
4359 BuilderStatus.pendingBuilds
4360 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
4361 (TryBase.addChange): Try schedulers should ignore Changes
4363 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
4364 for 'try' on CVS/SVN
4365 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
4367 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
4368 report status properly.
4369 (Try.createJob): implement unique buildset IDs
4371 * buildbot/status/client.py (StatusClientPerspective): add a
4372 perspective_getBuildSets method for the benefit of jobdir-style
4374 * docs/buildbot.texinfo (try): more docs
4375 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
4378 2005-08-18 Brian Warner <warner@lothar.com>
4380 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
4381 actually work. It's functional but still kind of clunky. Also, it
4382 only works with the pb-style.. needs to be made to work with the
4385 * buildbot/status/client.py (RemoteBuildSet): new class
4386 (RemoteBuildRequest): same
4387 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
4388 object, not the internal BuildStatus object.
4389 (RemoteBuild.remote_subscribe): new method to subscribe to builds
4390 outside of the usual buildStarted() return value.
4391 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
4393 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
4394 (Try_Userpass_Perspective.perspective_try): return a remotely
4395 usable BuildSetStatus object
4397 * buildbot/interfaces.py (IBuildStatus): remove obsolete
4398 isStarted()/waitUntilStarted()
4400 2005-08-16 Brian Warner <warner@lothar.com>
4402 * buildbot/status/builder.py: implement IBuildSetStatus and
4403 IBuildRequestStatus, wire them into place.
4404 * buildbot/buildset.py: same. Add ID, move wait-until-finished
4405 methods into the BuildSetStatus object.
4406 * buildbot/interfaces.py: same
4407 (IStatus.getBuildSets): new method to get pending BuildSets
4408 (IStatusReceiver.buildsetSubmitted): new method which hears about
4410 * buildbot/master.py (BuildMaster.submitBuildSet): same
4411 * buildbot/process/base.py (BuildRequest): same, replace
4412 waitUntilStarted with subscribe/unsubscribe
4413 * buildbot/process/builder.py (BuilderControl.forceBuild): use
4414 subscribe instead of waitUntilStarted
4415 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
4417 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
4419 * buildbot/test/test_buildreq.py: update for new code
4420 * buildbot/test/test_control.py (Force.testRequest): same
4423 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
4424 for Darcs to not use the tempfile module, so it works under
4425 python-2.2 too. We really didn't need the full cleverness of that
4426 module, since the slave has exclusive control of its own builddir.
4428 2005-08-15 Brian Warner <warner@lothar.com>
4430 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
4431 for CVS trees. It doesn't work for non-trunk branches,
4433 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
4436 * Makefile: make it easier to test against python2.2
4438 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
4439 tearDown2, so things like Arch can unregister archives as they're
4440 shutting down. The previous subclass-override-tearDown technique
4441 resulted in a nested maybeWait() and test failures under
4444 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
4445 where we can (Arch), add a branch= argument to set the branch used
4447 (BazExtractor): extract the branch too
4448 (TlaExtractor): same
4449 * buildbot/scripts/runner.py (TryOptions): add --branch
4450 * docs/buildbot.texinfo (try): document --branch/try_branch
4452 * buildbot/slave/commands.py (Darcs): implement get-revision for
4453 Darcs, so that 'try' will work. This requires the tempfile module
4456 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
4457 of revisions, branches, and 'try' in the process.
4459 2005-08-11 Brian Warner <warner@lothar.com>
4461 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
4462 this, it got broken at some point in the last few releases
4463 * buildbot/status/words.py (IrcBuildRequest): reply was broken
4464 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
4465 specifically the removal of ETA information from the tuple
4467 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
4470 * docs/buildbot.texinfo (try): document both --builder and
4471 'try_builders' in .buildbot/options
4472 * buildbot/scripts/runner.py (TryOptions): add --builder,
4473 accumulate the values into opts['builders']
4474 * buildbot/scripts/tryclient.py (Try.__init__): set builders
4475 * buildbot/test/test_runner.py (Try): add some quick tests to make
4476 sure 'buildbot try --options' and .buildbot/options get parsed
4477 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
4478 use --builder control
4480 * docs/buildbot.texinfo (try): add --port argument to PB style
4482 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
4483 actual SourceStamp. Still need to extract a branch name, somehow.
4484 (Try): finish implementing the try client side, still need a UI
4485 for specifying which builders to use
4486 (Try.getopt): factor our options/config-file reading
4487 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
4489 * buildbot/test/test_vc.py: match SourceStampExtractor change
4491 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
4492 causes the twisted log to be sent to stderr
4494 * buildbot/scheduler.py (Try_Userpass): implement the PB style
4496 2005-08-10 Brian Warner <warner@lothar.com>
4498 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
4499 style is 90% done, still missing status reporting or waiting for
4500 the buildsets to finish, and it is completely untested.
4502 * buildbot/trybuild.py: delete file, move contents to ..
4503 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
4504 * buildbot/test/test_vc.py: match the move
4506 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
4507 of the TryScheduler, no buildsetID or status-tracking support yet
4508 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
4510 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
4511 possible to set the basedir after __init__ time, so it is easier
4512 to use as a Service-child of the BuildMaster instance
4514 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
4515 that delivers messages to its Service parent instead of requiring
4516 a subclass to be useful. This turns out to be much easier to build
4519 * buildbot/scripts/tryclient.py (createJob): utility code to
4520 create jobfiles, will eventually be used by 'buildbot try'
4522 2005-08-08 Brian Warner <warner@lothar.com>
4524 * docs/buildbot.texinfo (try): add docs on the
4525 as-yet-unimplemented Try scheduler
4527 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
4528 * buildbot/test/test_scheduler.py: .. here
4529 (Scheduling.testTryJobdir): add placeholder test for 'try'
4531 * buildbot/test/test_status.py (Log.testMerge3): update to match new
4532 addEntry merging (>=chunkSize) behavior
4533 (Log.testConsumer): update to handle new callLater(0) behavior
4535 * buildbot/test/test_web.py: rearrange tests a bit, add test for
4536 both the MAX_LENGTH bugfix and the resumeProducing hang.
4538 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
4539 put off the actual resumeProducing for a moment with
4540 reactor.callLater(0). This works around a twisted-1.3.0 bug which
4541 causes large logfiles to hang midway through.
4543 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
4544 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
4545 and to improve memory usage when streaming the file out to a web
4547 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
4548 make this work cleanly
4550 2005-08-03 Brian Warner <warner@lothar.com>
4552 * buildbot/trybuild.py: new file for 'try' utilities
4553 (getSourceStamp): run in a tree, find out the baserev+patch
4554 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
4555 implemented for SVN and Darcs, still working on Arch. I don't know
4556 how to make CVS work yet.
4558 * docs/buildbot.texinfo: document the 'buildbot' command-line
4559 tool, including the not-yet-implemented 'try' feature, and the
4560 in-flux .buildbot/ options directory.
4562 2005-07-20 Brian Warner <warner@lothar.com>
4564 * buildbot/locks.py: added temporary id() numbers to Lock
4565 descriptions, to track down a not-really-sharing-the-Lock bug
4567 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
4569 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
4570 needed for python2.2 compatibility
4571 * buildbot/test/test_vc.py: python2.2 compatibility: generators
4572 are from the __future__
4574 2005-07-19 Brian Warner <warner@lothar.com>
4576 * buildbot/master.py (BuildMaster.loadConfig): give a better error
4577 message when schedulers use unknown builders
4579 * buildbot/process/builder.py (Builder.compareToSetup): make sure
4580 SlaveLock('name') and MasterLock('name') are distinct
4582 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
4583 c['schedulers'] in such a way that we can actually accept
4585 * buildbot/test/test_config.py: check it
4587 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
4588 utility method to *all* the Schedulers
4589 (Periodic.listBuilderNames): same
4591 * docs/buildbot.texinfo (Interlocks): update chapter to match
4594 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
4595 to make sure that c['sources'], c['schedulers'], and c['status']
4596 are all lists of the appropriate objects, and that the Schedulers
4597 all point to real Builders
4598 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
4599 'listBuilderNames' utility method to support this
4600 * buildbot/scheduler.py: implement the utility method
4601 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
4603 * docs/buildbot.texinfo: add some @cindex entries
4605 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
4606 if it wasn't already set: most tla commands will fail unless one
4608 (Arch.createRepository): and disable bazaar's revision cache, since
4609 they cause test failures (the multiple repositories we create all
4610 interfere with each other through the cache)
4612 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
4613 bring it properly up to date with twisted-2.0 test guidelines
4615 * buildbot/master.py (BuildMaster): remove references to old
4616 'interlock' module, this caused a bunch of post-merge test
4618 * buildbot/test/test_config.py: same
4619 * buildbot/process/base.py (Build): same
4621 * buildbot/test/test_slaves.py: stubs for new test case
4623 * buildbot/scheduler.py: add test-case-name tag
4624 * buildbot/test/test_buildreq.py: same
4626 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
4627 unnecessary init code
4628 (Bot.remote_setBuilderList): match it
4630 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
4632 * buildbot/changes/mail.py (parseSyncmail): update comment
4634 * buildbot/test/test_slavecommand.py: disable Shell tests on
4635 platforms that don't suport IReactorProcess
4637 * buildbot/status/builder.py (LogFile): remove the 't' mode from
4638 all places where we open logfiles. It causes OS-X to open the file
4639 in some weird mode that that prevents us from mixing reads and
4640 writes to the same filehandle, which we depend upon to implement
4641 _generateChunks properly. This change doesn't appear to break
4642 win32, on which "b" and "t" are treated differently but a missing
4643 flag seems to be interpreted as "t".
4645 2005-07-18 Brian Warner <warner@lothar.com>
4647 * buildbot/slave/commands.py (ShellCommand): overhaul
4648 error-handling code, to try and make timeout/interrupt work
4649 properly, and make win32 happier
4650 * buildbot/test/test_slavecommand.py: clean up, stop using
4651 reactor.iterate, add tests for timeout and interrupt
4652 * buildbot/test/sleep.py: utility for a new timeout test
4654 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
4655 code from the local-usebranches branch
4657 2005-07-17 Brian Warner <warner@lothar.com>
4659 * buildbot/process/process_twisted.py
4660 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
4661 minutes, to match the other twisted BuildFactories, and don't
4662 excuse failures in c/qt/win32 reactors any more.
4664 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
4665 'freebsd' builders, since the buildslaves have been unavailable
4668 2005-07-13 Brian Warner <warner@lothar.com>
4670 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
4671 build-on-branch feature
4673 * buildbot/process/step.py (Darcs.__init__): add base_url and
4674 default_branch arguments, just like SVN
4675 (Arch.__init__): note that the version= argument is really the
4678 * buildbot/slave/commands.py (SourceBase): keep track of the
4679 repository+branch that was used for the last checkout in
4680 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
4681 match, we clobber the directory and perform a fresh checkout
4682 rather than trying to do an in-place update. This should protect
4683 us against trying to get to branch B by doing an update in a tree
4684 obtained from branch A.
4685 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
4686 (SVN.setup): same, just the svnurl
4687 (Darcs.setup): same, just the repourl
4688 (Arch.setup): same, arch coordinates (url), version, and
4689 buildconfig. Also pull the buildconfig from the args dictionary,
4690 which we weren't doing before, so the build-config was effectively
4692 (Arch.sourcedirIsUpdateable): don't try to update when we're
4693 moving to a specific revision: arch can't go backwards, so it is
4694 safer to just clobber the tree and checkout a new one at the
4696 (Bazaar.setup): same sourcedata as Arch
4698 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
4699 use maybeWait, to work with twisted-1.3.0 and twcompat
4700 (Dependencies.testRun_Pass): same
4702 * buildbot/test/test_vc.py: rearrange, cleanup
4704 * buildbot/twcompat.py: add defer.waitForDeferred and
4705 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
4706 can work under twisted-1.3.0 .
4708 * buildbot/test/test_vc.py: rewrite. The sample repositories are
4709 now created at setUp time. This increases the runtime of the test
4710 suite considerably (from 91 seconds to 151), but it removes the
4711 need for an offline tarball, which should solve a problem I've
4712 seen where the test host has a different version of svn than the
4713 tarball build host. The new code also validates that mode=update
4714 really picks up recent commits. This approach will also make it
4715 easier to test out branches, because the code which creates the VC
4716 branches is next to the code which uses them. It will also make it
4717 possible to test some change-notification hooks, by actually
4718 performing a VC commit and watching to see the ChangeSource get
4721 2005-07-12 Brian Warner <warner@lothar.com>
4723 * docs/buildbot.texinfo (SVN): add branches example
4724 * docs/Makefile (buildbot.ps): add target for postscript manual
4726 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
4727 * buildbot/test/test_locks.py: same
4729 * buildbot/process/step.py (Darcs): comment about default branches
4731 * buildbot/master.py (BuildMaster.loadConfig): don't look for
4732 c['interlocks'] in the config file, complain if it is present.
4733 Scan all locks in c['builders'] to make sure the Locks they use
4735 * buildbot/test/test_config.py: remove old c['interlocks'] test,
4736 add some tests to check for non-uniquely-named Locks
4737 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
4738 since the unique-Lock validation code requires it now
4740 * buildbot/locks.py: fix test-case-name
4742 * buildbot/interlock.py: remove old file
4744 2005-07-11 Brian Warner <warner@lothar.com>
4746 * buildbot/test/test_interlock.py: rename to..
4747 * buildbot/test/test_locks.py: .. something shorter
4749 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
4750 versions (after 2.0.1) changed internet.TCPClient to shut down the
4751 connection in stopService. Change the code to handle this
4754 * buildbot/process/base.py (Build): handle whole-Build locks
4755 * buildbot/process/builder.py (Builder.compareToSetup): same
4756 * buildbot/test/test_interlock.py: make tests work
4758 * buildbot/process/step.py (BuildStep.startStep): complain if a
4759 Step tries to claim a lock that's owned by its own Build
4760 (BuildStep.releaseLocks): typo
4762 * buildbot/locks.py (MasterLock): use ComparableMixin so config
4763 file reloads don't replace unchanged Builders
4765 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
4766 rewrite to cover new Locks instead of old c['interlocks']
4767 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
4771 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
4772 start the master and connect the buildslave
4774 * buildbot/process/step.py (FailingDummy.done): finish with a
4775 FAILURE status rather than raising an exception
4777 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
4778 stringify a BuildRequest.reason that is None
4780 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
4782 * buildbot/status/builder.py (BuildSetStatus): implement enough to
4783 allow scheduler.Dependent to work
4784 * buildbot/buildset.py (BuildSet): set .reason and .results
4786 * buildbot/test/test_interlock.py (Locks.setUp): connect both
4787 slaves, to make the test stop hanging. It still fails, of course,
4788 because I haven't even started to implement Locks.
4790 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
4792 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
4793 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
4794 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
4795 (Dependent): new class for downstream build dependencies
4796 * buildbot/test/test_dependencies.py: tests (still failing)
4798 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
4800 2005-07-07 Brian Warner <warner@lothar.com>
4802 * buildbot/test/runutils.py (RunMixin): factored this class out..
4803 * buildbot/test/test_run.py: .. from here
4804 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
4805 added new buildbot.locks tests (which all hang right now)
4806 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
4807 * buildbot/process/step.py: claim/release per-BuildStep locks
4809 * docs/Makefile: add 'buildbot.html' target
4811 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
4812 interpreted as "HEAD", so that all VC steps can accept branch=None
4813 and have it mean the "default branch".
4815 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
4817 2005-07-07 Brian Warner <warner@lothar.com>
4819 * docs/examples/twisted_master.cfg: update to match current usage
4821 * docs/buildbot.texinfo (System Architecture): comment out the
4822 image, it doesn't exist yet and just screws up the HTML manual.
4824 2005-07-05 Brian Warner <warner@lothar.com>
4826 * debian/.cvsignore: oops, missed one. Removing leftover file.
4828 2005-06-17 Brian Warner <warner@lothar.com>
4830 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
4831 changed its output in 1.2.0, don't mistakenly think that the
4832 subversion we find isn't capable of supporting our tests.
4834 * debian/*: remove the debian/ directory and its contents, to make
4835 life easier for the proper Debian maintainer
4837 * Makefile (release): same
4839 2005-06-07 Brian Warner <warner@lothar.com>
4841 * everything: create a distinct SourceStamp class to replace the
4842 ungainly 4-tuple, let it handle merging instead of BuildRequest.
4843 Changed the signature of Source.startVC to include the revision
4844 information (instead of passing it through self.args). Implement
4845 branches for SVN (now only Darcs/Git is missing support). Add more
4848 2005-06-06 Brian Warner <warner@lothar.com>
4850 * everything: rearrange build scheduling. Create a new Scheduler
4851 object (configured in c['schedulers'], which submit BuildSets to a
4852 set of Builders. Builders can now use multiple slaves. Builds can
4853 be run on alternate branches, either requested manually or driven
4854 by changes. This changed some of the Status classes. Interlocks
4855 are out of service until they've been properly split into Locks
4856 and Dependencies. treeStableTimer, isFileImportant, and
4857 periodicBuild have all been moved from the Builder to the
4859 (BuilderStatus.currentBigState): removed the 'waiting' and
4860 'interlocked' states, removed the 'ETA' argument.
4862 2005-05-24 Brian Warner <warner@lothar.com>
4864 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
4865 erroneously abandons the connection (in clientConnectionFailed)
4866 for non-UserErrors, which means that if we lose the connection due
4867 to a network problem or a timeout, we'll never try to reconnect.
4868 Fix this by not upcalling to the buggy parent method. Note:
4869 twisted-2.0 fixes this, but the function only has 3 lines so it
4870 makes more sense to copy it than to try and detect the buggyness
4871 of the parent class. Fixes SF#1207588.
4873 * buildbot/changes/changes.py (Change.branch): doh! Add a
4874 class-level attribute to accomodate old Change instances that were
4875 pickled before 0.6.5 (where .branch was added for new Changes).
4876 This fixes the exception that occurs when you try to look at an
4877 old Change (through asHTML).
4879 * buildbot/__init__.py (version): bump to 0.6.6+ while between
4882 2005-05-23 Brian Warner <warner@lothar.com>
4884 * buildbot/__init__.py (version): release 0.6.6
4886 2005-05-23 Brian Warner <warner@lothar.com>
4888 * NEWS: update for 0.6.6 release
4889 * debian/changelog: same
4891 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4892 before starting: this was done by twistd back when we spawned it,
4893 now that we're importing the pieces and running them in the
4894 current process, we have to do it ourselves. This allows
4895 master.cfg to import files from the same directory without
4896 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4897 Stichele for the catch.
4898 (Options.opt_version): Add a --version command (actually, just make
4899 the existing --version command emit Buildbot's version too)
4901 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4902 fix to make this behave like other LogFiles, this time to handle
4903 existing LogFiles on disk. (add the missing .upgrade method)
4904 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4906 2005-05-21 Brian Warner <warner@lothar.com>
4908 * buildbot/test/test_runner.py (Create.testMaster): match the
4909 rawstring change in runner.py:masterTAC
4911 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4912 TwistedWords is installed
4913 * buildbot/test/test_status.py: same, with TwistedMail
4915 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4916 some old, deprecated, and removed config keys). This should enable
4917 you to use the base buildbot functionality with Twisted-2.0.0 when
4918 you don't also have TwistedWeb and TwistedWords installed
4920 2005-05-20 Brian Warner <warner@lothar.com>
4922 * buildbot/scripts/runner.py (run): call sendchange(), not
4923 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4924 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4925 (stop): don't wait for process to die when sending SIGHUP
4926 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4927 directory name gets interpreted, which you don't want
4930 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4933 2005-05-18 Brian Warner <warner@lothar.com>
4935 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4937 2005-05-18 Brian Warner <warner@lothar.com>
4939 * README: update for 0.6.5
4940 * debian/changelog: same
4942 * buildbot/changes/changes.py: rename tag= to branch=, since
4943 that's how we're using it, and my design for the upcoming "build a
4944 specific branch" feature wants it. also, tag= was too CVS-centric
4945 * buildbot/changes/mail.py (parseSyncmail): same
4946 * buildbot/process/base.py (Build.isBranchImportant): same
4947 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4948 * docs/buildbot.texinfo (Attributes of Changes): same
4950 * NEWS: update tag=, update for upcoming release
4952 2005-05-17 Brian Warner <warner@lothar.com>
4954 * buildbot/scripts/runner.py (stop): actually poll once per
4955 second, instead of re-killing the poor daemon once per second.
4956 Sleep briefly (0.1s) before the first poll, since there's a good
4957 chance we can avoid waiting the full second if the daemon shuts
4958 down quickly. Also remove the sys.exit() at the end.
4959 (start): remove the unneighborly sys.exit()
4961 * Makefile: improve permission-setting to not kick Arch so badly
4963 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4964 default --keepalive=600, since it doesn't hurt very much, and it's
4965 a hassle to discover that you need it.
4966 * buildbot/test/test_runner.py (Create.testSlave): test it
4968 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4969 IRC bot about EXCEPTION
4971 * buildbot/status/client.py (PBListener): upcall more correctly
4973 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4974 an exception mark the overall build with EXCEPTION, not SUCCESS
4976 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4978 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4979 * Makefile: update some release-related stuff
4981 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4982 gets called when there isn't actually an active process, just end
4983 the Command instead of blowing up. I don't know how it gets into
4984 this state, but the twisted win32 buildslave will sometimes hang,
4985 and when it shakes its head and comes back, it thinks it's still
4986 running a Command. The next build causes this command to be
4987 interrupted, but the lack of self.process.pid breaks the interrupt
4990 * NEWS: document changes since the last release
4992 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4993 look for Makefile.buildbot instead of a bare Makefile . The
4994 'buildbot start' does not install this file, so you have to
4995 manually copy it if you want to customize startup behavior.
4996 (createMaster): change 'buildbot master' command to create
4997 Makefile.sample instead of Makefile, to create master.cfg.sample
4998 instead of master.cfg (requiring you to copy it before the
4999 buildmaster can be started). Both sample files are kept up to
5000 date, i.e. they are overwritten if they have been changed. The
5001 'buildbot.tac' file is *not* overwritten, but if the new contents
5002 don't match the old, a 'buildbot.tac.new' file is created and the
5003 user is warned. This seems to be a much more sane way to handle
5004 startup files. Also, don't sys.exit(0) when done, so we can run
5005 unit tests against it.
5006 (createSlave): same. Don't overwrite the sample info/ files.
5007 * buildbot/scripts/sample.mk: remove. the contents were pulled
5008 into runner.py, since they need to match the behavior of start()
5012 * docs/buildbot.texinfo (Launching the daemons): document it
5013 * buildbot/test/test_runner.py (Create): test it
5015 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
5016 version that can handle string-in-string tests, because otherwise
5017 python-2.2 fails the tests. It'd be tremendous if Trial's test
5018 took two strings under 2.2 too.
5020 * everything: fixed all deprecation warnings when running against
5021 Twisted-2.0 . (at least all the ones in buildbot code, there are a
5022 few that come from Twisted itself). This involved putting most of
5023 the Twisted-version specific code in the new buildbot.twcompat
5024 module, and creating some abstract base classes in
5025 buildbot.changes.base and buildbot.status.base (which might be
5026 useful anyway). __implements__ is a nuisance and requires an ugly
5027 'if' clause everywhere.
5029 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
5030 delay before finishing the test: it seems that smtp.sendmail
5031 doesn't hang up on the server, so we must wait a moment so it can
5032 hang up on us. This removes the trial warning about an unclean
5035 2005-05-16 Brian Warner <warner@lothar.com>
5037 * buildbot/process/step.py (Source): add 'retry' argument. It is a
5038 tuple of (delay, repeats).
5039 * buildbot/test/test_vc.py (Retry): test it
5040 * docs/buildbot.texinfo (Source Checkout): document it
5041 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
5042 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
5043 doVCFull() are handled by re-trying the checkout (after a delay)
5044 some number of times.
5045 (ShellCommand._startCommand): make header lines easier to read
5047 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
5049 (WebTest.test_logfile): make sure master gets shut down, silences
5050 some "unclean reactor" test errors
5052 * buildbot/test/test_changes.py (Sender.tearDown): spin the
5053 reactor once after shutdown, something in certain versions of
5054 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
5055 fails, svn-trunk is ok.
5057 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
5058 second win32 error message
5060 * buildbot/test/test_run.py (Status.testSlave): be smarter about
5061 validating the ETA, so the tests don't fail on slow systems
5063 2005-05-15 Brian Warner <warner@lothar.com>
5065 * buildbot/status/builder.py (HTMLLogFile): make this behave like
5066 the new LogFile class, so upgrading works properly
5067 (LogFileProducer.resumeProducing): survive resumeProducing after
5068 we've exhausted the chunkGenerator
5070 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
5072 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
5073 (Log.testUpgrade): same
5075 * docs/buildbot.texinfo (Maintenance): describe how to delete old
5076 Builds and logs with a cron job.
5078 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
5079 of the old non-offline LogFile, added code to upgrade these to
5080 new-style contents-live-on-disk instances at load time (in a way
5081 that doesn't invalidate the old Build pickles, so upgrading to
5082 0.6.5 is not a one-way operation). Got rid of everything related
5084 (LogFile.__init__): create LogFiles with the parent step status,
5085 the log's name, and a builder-relative filename where it can keep
5086 the contents on disk.
5087 (LogFile.hasContents): new method, clients are advised to call it
5088 before getText or getChunks and friends. If it returns False, the
5089 log's contents have been deleted and getText() will raise an
5091 (LogFile.getChunks): made it a generator
5092 (LogFile.subscribeConsumer): new method, takes a Twisted-style
5093 Consumer (except one that takes chunks instead of strings). This
5094 enables streaming of very large logfiles without storing the whole
5096 (BuildStatus.generateLogfileName): create names like
5097 12-log-compile-output, with a _0 suffix if required to be unique
5098 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
5099 or earlier) logfiles into new-style ones
5100 (BuilderStatus): remove everything related to 'stub' builds. There
5101 is now only one build cache, and we don't strip logs from old
5103 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
5104 since we no longer fight to keep it in the cache
5106 * buildbot/status/html.py (TextLog.render_GET): use a
5107 ChunkConsumer to stream the log entries efficiently.
5108 (ChunkConsumer): wrapper which consumes chunks and writes
5111 * buildbot/test/test_twisted.py (Parse.testParse): use a
5112 LogFile-like object instead of a real one
5114 * buildbot/test/test_status.py (MyLog): handle new LogFile code
5115 (Log.testMerge3): validate more merge behavior
5116 (Log.testChunks): validate LogFile.getChunks
5117 (Log.testUpgrade): validate old-style LogFile upgrading
5118 (Log.testSubscribe): validate LogFile.subscribe
5119 (Log.testConsumer): validate LogFile.subscribeConsumer
5121 * buildbot/interfaces.py (IStatusLogStub): remove
5122 (IStatusLog.subscribeConsumer): new method
5123 (IStatusLog.hasContents): new method
5124 (IStatusLogConsumer): describes things passed to subscribeConsumer
5126 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
5127 the log contents if it does not have any contents.
5128 (StatusResourceBuildStep.body): same
5129 (StatusResourceBuildStep.getChild): give a 404 for empty logs
5131 2005-05-14 Brian Warner <warner@lothar.com>
5133 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
5134 timeouts to try and make the windows metabuildslave not hang
5136 2005-05-13 Mike Taylor <bear@code-bear.com>
5138 * buildbot/slave/commands.py (rmdirRecursive): added a check
5139 to ensure the path passed into rmdirRecursive actually exists.
5140 On win32 a non-existant path would generate an exception.
5142 2005-05-13 Brian Warner <warner@lothar.com>
5144 * buildbot/slave/commands.py (rmdirRecursive): replacement for
5145 shutil.rmtree which behaves correctly on windows in the face of
5146 files that you have to chmod before deleting. Thanks to Bear at
5147 the OSAF for the routine.
5148 (SourceBase.doClobber): use rmdirRecursive
5150 2005-05-12 Brian Warner <warner@lothar.com>
5152 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
5153 method generate chunks instead of returning a big list. This
5154 allows the same method to be used for both old LogFile and new
5156 (OfflineLogFile.getText): use the generator
5157 (OfflineLogFile.subscribe): same
5158 * buildbot/status/html.py (TextLog.resumeProducing): same
5159 * buildbot/interfaces.py (IStatusLog.getChunks): document it
5161 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
5162 point out that OfflineLogFile does not currently work with
5163 html.Waterfall . Fixing this is high-priority.
5165 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
5166 apparently windows defaults to using stdout
5168 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
5169 better message on failure so I can figure out the win32 problem
5171 * buildbot/slave/commands.py (ShellCommand._startCommand): update
5172 log messages to include more useful copies of the command being
5173 run, the argv array, and the child command's environment.
5174 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
5176 2005-05-11 Brian Warner <warner@lothar.com>
5178 * setup.py: oops, install debug.glade so 'buildbot debugclient'
5180 * Makefile: update the deb-snapshot version
5182 * docs/buildbot.texinfo: move all .xhtml docs into a new
5183 .texinfo-format document, adding a lot of material in the process.
5184 This is starting to look like a real user's manual. Removed all
5185 the Lore-related files: *.xhtml, *.css, template.tpl .
5186 * docs/Makefile: simple makefile to run 'makeinfo'
5187 * buildbot/scripts/sample.cfg: rearrange slightly
5188 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
5190 2005-05-10 Brian Warner <warner@lothar.com>
5192 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
5193 different name for the internal twistw module, handle it.
5195 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
5196 * setup.py: .. and stop trying to install it
5198 * buildbot/process/step.py (Git): added support for 'cogito' (aka
5199 'git'), the new linux kernel VC system (http://kernel.org/git/).
5200 Thanks to Brandon Philips for the patch.
5201 * buildbot/slave/commands.py (Git): same
5203 2005-05-06 Brian Warner <warner@lothar.com>
5205 * buildbot/status/builder.py (OfflineLogFile): replace the default
5206 LogFile with a form that appends its new contents to a disk file
5207 as they arrive. The complete log data is never kept in RAM. This
5208 is the first step towards handling very large (100MB+) logfiles
5209 without choking quite so badly. (The other half is
5210 producer/consumer on the HTML pages).
5211 (BuildStepStatus.addLog): use OfflineLogFile by default
5212 (BuildStatus.getLogfileName): helper code to give the
5213 OfflineLogFile a filename to work with
5215 * buildbot/test/test_status.py (Results.testAddResults): update
5216 tests to handle new asserts
5217 * buildbot/test/test_vc.py (Patch.doPatch): same
5218 * buildbot/test/test_steps.py (BuildStep.setUp): same
5220 2005-05-05 Brian Warner <warner@lothar.com>
5222 * buildbot/scripts/runner.py (start): if there is no Makefile,
5223 launch the app by importing twistd's internals and calling run(),
5224 rather than spawning a new twistd process. This stands a much
5225 better chance of working under windows.
5226 (stop): kill the process with os.kill instead of spawning
5227 /bin/kill, again to reduce the number of external programs which
5228 windows might not have in the PATH. Also wait up to 5 seconds for
5229 the process to go away, allowing things like 'buildbot stop;
5230 buildbot start' to be reliable in the face of slow shutdowns.
5232 * buildbot/master.py (Dispatcher.__getstate__): remove old
5233 .tap-related methods
5234 (BuildMaster.__getstate__): same
5236 * buildbot/slave/bot.py (makeService): same
5237 (Options.longdesc): same
5238 * buildbot/scripts/runner.py: copy over some old mktap option text
5240 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
5241 'buildbot master' now creates a buildbot.tac file, so there is no
5242 longer a create-instance/save/reload sequence. mktap is dead, long
5244 * buildbot/scripts/sample.mk: use twistd -y, not -f
5245 * buildbot/test/test_config.py: remove mktap-based test
5246 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
5247 * README: don't reference mktap
5249 * docs/source.xhtml: document some of the attributes that Changes
5252 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
5254 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
5255 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
5256 * buildbot/changes/changes.py (Change)
5257 * buildbot/changes/mail.py (parseSyncmail)
5258 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
5260 * buildbot/process/base.py (Build.isTagImportant)
5264 2005-05-04 Brian Warner <warner@lothar.com>
5266 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
5267 connection after sending the change, so that unit tests don't
5268 complain about sockets being left around
5270 * buildbot/status/html.py (WaterfallStatusResource.body): fix
5271 exception in phase=0 rendering
5272 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5274 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
5276 * buildbot/master.py (BuildMaster.loadConfig): finally remove
5277 deprecated config keys: webPortnum, webPathname, irc, manholePort,
5278 and configuring builders with tuples.
5279 * buildbot/test/test_config.py: stop testing compatibility with
5280 deprecated config keys
5281 * buildbot/test/test_run.py: same
5283 2005-05-03 Brian Warner <warner@lothar.com>
5285 * contrib/arch_buildbot.py: survive if there are no logfiles
5286 (username): just use a string, os.getlogin isn't reliable
5288 * buildbot/scripts/runner.py (sendchange): oops, fix the command
5289 so 'buildbot sendchange' actually works. The earlier test only
5290 covered the internal (non-reactor-running) form.
5292 * contrib/arch_buildbot.py: utility that can run as an Arch hook
5293 script to notify the buildmaster about changes
5295 * buildbot/scripts/runner.py (sendchange): new command to send a
5296 change to a buildbot.changes.pb.PBChangeSource receiver.
5297 * buildbot/test/test_changes.py (Sender): test it
5299 * buildbot/master.py (BuildMaster.startService): mark .readConfig
5300 after any reading of the config file, not just when we do it in
5301 startService. This makes some tests a bit cleaner.
5303 * buildbot/changes/pb.py: add some log messages
5305 * buildbot/process/base.py (Build.startBuild): fix a bug that
5306 caused an exception when the build terminated in the very first
5308 (Build.stepDone): let steps return a status of EXCEPTION. This
5309 terminates the build right away, and sets the build's overall
5310 status to EXCEPTION too.
5311 * buildbot/process/step.py (BuildStep.failed): return a status of
5312 EXCEPTION when that is what has happened.
5314 * buildbot/process/step.py (Arch.computeSourceRevision): finally
5315 implement this, allowing Arch-based projects to get precise
5316 checkouts instead of always using the latest code
5317 (Bazaar): create variant of Arch to let folks use baz instead of
5318 tla. Requires a new buildslave too.
5319 * buildbot/slave/commands.py (Arch): add 'revision' argument
5320 (Bazaar): create variant of Arch that uses baz instead of tla.
5321 Remove the code that extracts the archive name from the
5322 register-archive output, since baz doesn't provide it, and require
5323 the user provide both the archive name and its location.
5324 * buildbot/test/test_vc.py (VC.testBazaar): added tests
5326 2005-05-02 Brian Warner <warner@lothar.com>
5328 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
5329 thanks to Nick Trout.
5331 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
5332 deals better with source Makefile coming from a read-only CVS
5333 checkout. Thanks to Nick Trout for the catch.
5335 * buildbot/__init__.py (version): bump to 0.6.4+ while between
5338 2005-04-28 Brian Warner <warner@lothar.com>
5340 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
5342 * debian/changelog: update for 0.6.4
5344 2005-04-28 Brian Warner <warner@lothar.com>
5346 * README.w32: add a checklist of steps for getting buildbot
5348 * MANIFEST.in: include it in the tarball
5352 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
5353 broken .tap files from 0.6.3 by getting rid of .services,
5354 .namedServices, and .change_svc at load time.
5356 2005-04-27 Brian Warner <warner@lothar.com>
5358 * NEWS: update in preparation for new release
5360 * buildbot/test/test_config.py (Save.testSave): don't pull in
5361 twisted.scripts.twistd, we don't need it and it isn't for windows
5364 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
5365 accomodate win32 which can't do atomic-rename
5367 2005-04-27 Brian Warner <warner@lothar.com>
5369 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
5370 timeouts to help the slow metabuildbot not flunk them so much
5371 (Disconnect.testBuild3): same
5372 (Disconnect.testBuild4): same
5373 (Disconnect.testInterrupt): same
5375 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
5376 setup, it was completely broken for new buildmasters (those which
5377 did not have a 'change.pck' already saved. Thanks to Paul Warren
5378 for catching this (embarrassing!) bug.
5379 (Dispatcher.__getstate__): don't save our registered avatar
5380 factories, since they'll be re-populated when the config file is
5382 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
5383 tests (since the real mktap-generated BuildMaster doesn't save
5385 (BuildMaster.__getstate__): don't save any service children,
5386 they'll all be re-populated when the config file is re-read.
5387 * buildbot/test/test_config.py (Save.testSave): test for this
5389 2005-04-26 Brian Warner <warner@lothar.com>
5391 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
5392 rendered with Blender.. looks a bit nicer.
5393 * buildbot/docs/images/icon.blend: add the Blender file for it
5395 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
5396 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
5397 running under windows. This appears to be the best way to allow
5398 BuildSteps to do something normal like 'trial -v buildbot.test' or
5399 'make foo' and still expect it to work. The idea is to make the
5400 BuildSteps look as much like what a developer would type when
5401 compiling or testing the tree by hand. This approach probably has
5402 problems when there are spaces in the arguments, so if you've got
5403 windows buildslaves, you'll need to pay close attention to your
5406 * buildbot/status/html.py (WaterfallStatusResource.body): add the
5407 timezone to the timestamp column.
5408 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5410 * buildbot/scripts/runner.py (loadOptions): do something sane for
5411 windows, I think. We use %APPDATA%/buildbot instead of
5412 ~/.buildbot, but we still search everywhere from the current
5413 directory up to the root for a .buildbot/ subdir. The "is it under
5414 $HOME" security test was replaced with "is it owned by the current
5415 user", which is only performed under posix.
5416 * buildbot/test/test_runner.py (Options.testFindOptions): update
5417 tests to match. The "is it owned by the current user" check is
5418 untested. The test has been re-enabled for windows.
5420 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
5421 any "\n" in the expected output with the platform-specific line
5422 separator. Make this separator "\r\n" on PTYs under unix, they
5423 seem to do that and I don't know why
5425 * buildbot/test/test_runner.py (Options.optionsFile): disable on
5426 windows for now, I don't know what ~/.buildbot/ should mean there.
5428 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
5429 win32 compatibility, don't use "/tmp"
5430 (Basedir.testChangeBuilddir): remove more unixisms
5432 2005-04-26 Brian Warner <warner@lothar.com>
5434 * buildbot/test/test_control.py (Force.rmtree): python2.2
5435 compatibility, apparently its shutil.rmtree ignore_errors=
5436 argument is ignored.
5437 * buildbot/test/test_run.py (Run.rmtree): same
5438 (RunMixin.setUp): same
5440 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
5443 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
5444 'substring in string' operator, must use string.find(substr)!=-1
5445 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
5446 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
5448 * buildbot/scripts/runner.py (loadOptions): add code to search for
5449 ~/.buildbot/, a directory with things like 'options', containing
5450 defaults for various 'buildbot' subcommands. .buildbot/ can be in
5451 the current directory, your $HOME directory, or anywhere
5452 inbetween, as long as you're somewhere inside your home directory.
5453 (debugclient): look in ~/.buildbot/options for master and passwd
5454 (statuslog): look in ~/.buildbot/options for 'masterstatus'
5455 * buildbot/test/test_runner.py (Options.testFindOptions): test it
5457 * buildbot/status/client.py (makeRemote): new approach to making
5458 IRemote(None) be None, which works under Twisted-2.0
5459 * buildbot/test/test_status.py (Client.testAdaptation): test it
5461 * buildbot/status/builder.py (Status.builderAdded): when loading a
5462 pickled BuilderStatus in from disk, set its name after loading.
5463 The config file might have changed its name (but not its
5464 directory) while it wasn't looking.
5466 * buildbot/process/builder.py (Builder.attached): always return a
5467 Deferred, even if the builder was already attached
5468 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
5470 2005-04-25 Brian Warner <warner@lothar.com>
5472 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
5473 category-related exception when announcing a build has finished
5475 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
5476 reference no-longer-existent changemaster.sources
5477 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
5479 * buildbot/__init__.py (version): bump to 0.6.3+ while between
5482 2005-04-25 Brian Warner <warner@lothar.com>
5484 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
5486 * debian/changelog: update for 0.6.3
5488 2005-04-25 Brian Warner <warner@lothar.com>
5490 * MANIFEST.in: make sure debug.glade is in the tarball
5492 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
5494 * NEWS: update for the imminent 0.6.3 release
5496 * buildbot/status/html.py (HtmlResource.content): make the
5497 stylesheet <link> always point at "buildbot.css".
5498 (StatusResource.getChild): map "buildbot.css" to a static.File
5499 containing whatever css= argument was provided to Waterfall()
5500 (Waterfall): provide the "classic" css as the default.
5501 * docs/waterfall.classic.css: move default CSS from here ..
5502 * buildbot/status/classic.css: .. to here
5504 * MANIFEST.in: make sure classic.css is included in the tarball
5505 * setup.py: and that it is installed too, under buildbot/status/
5507 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
5508 the module level, because buildbot.tap files from 0.6.2 don't have
5509 it in their attribute dictionary.
5511 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
5512 really exists at startup, might save some confusion somewhere.
5514 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
5516 * docs/waterfall.classic.css:
5517 add a stylesheet that's almost the same as the "classic"
5520 * buildbot/status/builder.py:
5521 add EXCEPTION as a result - this is a problem for the bot
5522 maintainer, not a build problem for the changers
5523 * buildbot/process/step.py:
5524 use EXCEPTION instead of FAILURE for exceptions
5525 * buildbot/status/html.py:
5526 add build_get_class to get a class out of a build/buildstep
5527 finish naming the classes
5528 split out sourceNames to changeNames and builderNames so we
5529 can style them separately
5530 * docs/config.xhtml:
5531 finish documenting classes as they are right now
5533 * buildbot/status/html.py:
5534 name the classes as we agreed on IRC
5535 * docs/config.xhtml:
5538 * buildbot/status/html.py:
5539 same for cssclass->class_
5541 * buildbot/status/html.py:
5542 as decided on IRC, use class_ for the "class" attribute to not
5543 conflict with the class keyword, and clean up the messy **{} stuff.
5545 * buildbot/status/mail.py:
5546 put back "builders" argument, and fix docstring, because the
5547 code *ignores* builders listed in this argument
5549 * buildbot/process/builder.py:
5550 remove FIXME notes - category is now indeed a cvar of BuilderStatus
5552 * docs/config.xhtml:
5553 describe the category argument for builders
5555 * buildbot/status/builder.py:
5556 Fix a silly bug due to merging
5558 * buildbot/process/builder.py:
5559 remove category from the process Builder ...
5560 * buildbot/status/builder.py:
5561 ... and add it to BuilderStatus instead.
5562 Set category on unpickled builder statuses, they might not have it.
5563 * buildbot/master.py:
5564 include category when doing builderAdded
5565 * buildbot/status/mail.py:
5566 return None instead of self for builders we are not interested in.
5567 * buildbot/test/test_run.py:
5568 fix a bug due to only doing deferredResult on "dummy" waiting
5569 * buildbot/test/test_status.py:
5570 add checks for the Mail IStatusReceiver returning None or self
5572 * buildbot/status/html.py:
5573 fix testsuite by prefixing page title with BuildBot
5575 * buildbot/status/builder.py:
5576 have .category in builder status ...
5577 * buildbot/process/builder.py:
5578 ... and set it from Builder
5579 * buildbot/status/html.py:
5580 make .css a class variable
5581 * buildbot/test/test_status.py:
5582 write more tests to cover our categories stuff ...
5583 * buildbot/status/mail.py:
5584 ... and fix the bug that this uncovered
5586 * buildbot/changes/mail.py:
5587 * buildbot/changes/pb.py:
5588 * buildbot/master.py:
5589 * buildbot/process/base.py:
5590 * buildbot/process/factory.py:
5591 * buildbot/process/interlock.py:
5592 * buildbot/process/step.py:
5593 * buildbot/process/step_twisted.py:
5594 * buildbot/slave/commands.py:
5595 * buildbot/status/builder.py:
5596 * buildbot/status/client.py:
5597 * buildbot/status/html.py:
5598 * buildbot/status/mail.py:
5599 * buildbot/status/progress.py:
5600 * buildbot/test/test_changes.py:
5601 * buildbot/test/test_config.py:
5602 * buildbot/test/test_control.py:
5603 * buildbot/test/test_interlock.py:
5604 * buildbot/test/test_maildir.py:
5605 * buildbot/test/test_mailparse.py:
5606 * buildbot/test/test_run.py:
5607 * buildbot/test/test_slavecommand.py:
5608 * buildbot/test/test_status.py:
5609 * buildbot/test/test_steps.py:
5610 * buildbot/test/test_twisted.py:
5611 * buildbot/test/test_util.py:
5612 * buildbot/test/test_vc.py:
5613 * buildbot/test/test_web.py:
5615 add test-case-name at the top of a whole set of files
5617 * buildbot/status/builder.py:
5618 keep order of addition when getting builder names
5619 * buildbot/status/words.py:
5620 * buildbot/test/test_run.py:
5621 add test for getBuilderNames
5623 * buildbot/process/base.py:
5624 * buildbot/process/step.py:
5625 * buildbot/status/builder.py:
5626 * buildbot/status/html.py:
5627 make buildbot css-able
5628 replace the color code for purple with purple, don't understand
5629 why it wasn't purple to start with
5631 * buildbot/status/words.py:
5632 ok, so it doesn't look like BuilderStatus.remote is still valid.
5633 Use what waterfall uses instead.
5635 * buildbot/interfaces.py:
5636 * buildbot/status/builder.py:
5637 * buildbot/status/html.py:
5638 * buildbot/status/mail.py:
5639 * buildbot/status/words.py:
5640 * buildbot/test/test_run.py:
5641 use categories everywhere and make it be a list. More sensible
5642 for the future. Also make words actually respect this in
5645 * buildbot/interfaces.py:
5646 add category argument to getBuilderNames
5647 * buildbot/process/builder.py:
5648 * buildbot/status/builder.py:
5649 * buildbot/status/html.py:
5650 * buildbot/status/mail.py:
5651 * buildbot/status/words.py:
5652 * buildbot/test/test_run.py:
5653 move from specifying builders by name to specifying the category
5655 * buildbot/status/html.py:
5656 * buildbot/status/words.py:
5657 add "builders=" to __init__ of status clients so they can
5658 limit themselves to the given list of builders to report on
5660 * buildbot/status/html.py: set the title to the product name
5662 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
5664 * buildbot/interfaces.py:
5665 * buildbot/status/builder.py:
5666 more documentation. Hm, not sure if ChangeLog entries make sense
5669 2005-04-23 Brian Warner <warner@lothar.com>
5671 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
5673 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
5675 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
5676 the sub-commands that log buildmaster status to stdout and to a
5677 GUI window, respectively.
5679 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
5680 functionality is working again, but all the step-status and ETA
5681 stuff is missing. Commented out a lot of code pending more
5684 * buildbot/status/client.py: make sure that IRemote(None) is None
5686 * buildbot/changes/changes.py: import defer, oops
5687 (ChangeMaster): remove the .sources list, rely upon the fact that
5688 MultiServices can be treated as sequences of their children. This
5689 cleans up the add/remove ChangeSource routines a lot, as we keep
5690 exactly one list of the current sources instead of three.
5692 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
5693 up an empty ChangeMaster at init time.
5694 (BuildMaster.loadChanges): if there are changes to be had from
5695 disk, replace self.change_svc with the new ones. If not, keep
5696 using the empty ChangeMaster set up in __init__.
5697 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
5698 instead of a separate list, makes the code a bit cleaner.
5699 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
5700 (ConfigTest.testSources): same, also wait for loadConfig to finish.
5701 Extend the test to make sure we can get rid of the sources when
5704 2005-04-22 Brian Warner <warner@lothar.com>
5706 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
5707 and info/host files when making the slave directory
5709 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
5710 whendone= argument, just return the Deferred and let the caller do
5711 what they want with it.
5712 (Disconnect.testBuild1): wait for shutdownSlave
5713 (Basedir.testChangeBuilddir): new test to make sure changes to the
5714 builddir actually get propagated to the slave
5716 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
5717 explicit method, rather than passing the builddir in __init__ .
5718 Make sure to update self.basedir too, this was broken before.
5719 (Bot.remote_setBuilderList): use b.setBuilddir for both new
5720 builders and for ones that have just had their builddir changed.
5721 (BotFactory): add a class-level .perspective attribute, so
5722 BuildSlave.waitUntilDisconnected won't get upset when the
5723 connection hasn't yet been established
5724 (BuildSlave.__init__): keep track of the bot.Bot instance, so
5725 tests can reach through it to inspect the SlaveBuilders
5727 * buildbot/process/base.py (Build.buildException): explain the
5728 log.err with a log.msg
5729 * buildbot/process/builder.py (Builder.startBuild): same
5730 (Builder._startBuildFailed): improve error message
5732 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
5733 occurred because we lost the brand-new connection, retry instead
5734 of giving up. If not, it's probably an authorization failure, and
5735 it makes sense to stop trying. Make sure we log.msg the reason
5736 that we're log.err'ing the failure, otherwise test failures are
5737 really hard to figure out.
5739 * buildbot/master.py: change loadConfig() to return a Deferred
5740 that doesn't fire until the change has been fully implemented.
5741 This means any connected slaves have been updated with the new
5742 builddir. This change makes it easier to test the code which
5743 actually implements this builddir-updating.
5744 (BotPerspective.addBuilder): return Deferred
5745 (BotPerspective.removeBuilder): same
5746 (BotPerspective.attached): same
5747 (BotPerspective._attached): same. finish with remote_print before
5748 starting the getSlaveInfo, instead of doing them in parallel
5749 (BotPerspective.list_done): same
5750 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
5751 actually calling slave.disconnect()
5752 (BotMaster.addBuilder): same
5753 (BotMaster.removeBuilder): same
5754 (BuildMaster.loadConfig): same
5755 (BuildMaster.loadConfig_Slaves): same
5756 (BuildMaster.loadConfig_Sources): same
5757 (BuildMaster.loadConfig_Builders): same
5758 (BuildMaster.loadConfig_status): same
5760 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
5761 a Deferred that fires when the source is finally removed
5763 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
5764 the previous tree on win32, where we have to do it synchronously,
5765 make sure we return a Deferred anyway.
5766 (SourceBase.doCopy): same
5768 * buildbot/scripts/runner.py (statusgui): use the text client for
5769 now, while I rewrite the Gtk one
5770 * buildbot/clients/base.py: strip out old code, leaving just the
5771 basic print-message-on-event functionality. I also remove the
5772 ReconnectingPBClientFactory, but it does at least quit when it
5773 loses the connection instead of going silent
5775 2005-04-21 Brian Warner <warner@lothar.com>
5777 * Makefile: minor tweaks
5779 * NEWS: point out deprecation warnings, new features for
5782 * buildbot/master.py (BuildMaster.loadConfig): emit
5783 DeprecationWarnings for Builders defined with tuples. Rearrange
5784 code to facility removal of deprecated configuration keys in the
5787 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
5788 'buildbot' command to put a little Makefile in the target that
5789 helps you re-create the buildbot.tap file, start or stop the
5790 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
5791 all the files 0600, since they contain passwords.
5792 (start): if there is a Makefile, and /usr/bin/make exists, use
5793 'make start' in preference to a raw twistd command. This lets
5794 slave admins put things like PYTHONPATH variables in their
5795 Makefiles and have them still work when the slave is started with
5796 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
5797 be nice to first try the 'make' command and only fall back to
5798 twistd if it fails. TODO: the Makefile's "start" command does not
5799 add the --reactor=win32 argument when running under windows.
5800 (Options.debugclient, Options.statusgui): add sub-commands to launch
5801 the debug client (formerly in contrib/debugclient.py) and the
5802 Gtk status application (currently broken)
5803 * buildbot/clients/debug.py: move from contrib/debugclient.py
5804 * buildbot/clients/debug.glade: same
5806 * buildbot/test/test_trial.py: remove it. This requires some
5807 functionality out of Twisted that isn't there yet, and until then
5808 having it around just confuses things.
5810 * buildbot/test/test_slavecommand.py (Shell): test both with and
5811 without PTYs, and make sure that command output is properly
5812 interleaved in the with-PTY case. I think the without-PTY test
5813 should pass on windows, where we never use PTYs anyway.
5815 2005-04-20 Brian Warner <warner@lothar.com>
5817 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
5819 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
5821 * NEWS: start creating entries for the next release
5823 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
5825 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
5826 (WebTest.test_webPathname): same
5827 (WebTest.test_webPathname_port): same
5828 (WebTest.test_waterfall): use the default favicon rather than
5829 rooting around the filesystem for it. Open the expected-icon file
5830 in binary mode, to make win32 tests happier (thanks to Nick Trout
5832 * buildbot/status/html.py (buildbot_icon): win32 portability
5834 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
5835 win32-compatibility fixes from Nick Trout, the "file not found" message
5836 is different under windows
5837 (FakeSlaveBuilder.__init__): clean up setup a bit
5838 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
5840 2005-04-19 Brian Warner <warner@lothar.com>
5842 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
5843 skip-if-repositories-are-unavailable test to not kill the trial
5844 that comes with Twisted-1.3.0
5846 * setup.py: install buildbot.png icon file when installing code
5848 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
5849 environment used by the command, at least on the child side.
5851 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
5852 this method needs to be added and implemented because it gets
5853 called under heavy load. I don't quite understand the
5854 producer/consumer API enough to write it.
5855 (StatusResource.getChild): add a resource for /favicon.ico
5856 (Waterfall.__init__): add favicon= argument
5857 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5858 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
5859 (WebTest.test_webPathname): same
5860 (WebTest.test_webPathname_port): same
5861 * docs/config.xhtml: mention favicon=
5862 * buildbot/buildbot.png: add a default icon, dorky as it is
5864 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
5866 * buildbot/master.py:
5867 * buildbot/process/base.py:
5868 * buildbot/process/builder.py:
5869 * buildbot/process/interlock.py:
5870 * buildbot/status/builder.py:
5871 * buildbot/status/html.py:
5872 * buildbot/status/mail.py:
5873 * buildbot/status/words.py:
5874 new documentation while digging through the code
5876 2005-04-17 Brian Warner <warner@lothar.com>
5878 * general: try to fix file modes on all .py files: a+r, a-x,
5879 but let buildbot/clients/*.py be +x since they're tools
5881 * docs/epyrun (addMod): when an import fails, say why
5883 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
5885 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5887 * buildbot/process/base.py:
5888 * buildbot/process/builder.py:
5889 * buildbot/status/builder.py:
5890 new documentation while digging through the code
5892 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5894 * buildbot/changes/changes.py:
5895 * buildbot/changes/p4poller.py:
5896 * buildbot/interfaces.py:
5897 * buildbot/process/base.py:
5898 * buildbot/process/builder.py:
5899 * buildbot/process/step.py:
5900 * buildbot/process/step_twisted.py:
5901 * buildbot/slave/bot.py:
5902 * buildbot/slave/commands.py:
5903 * buildbot/status/builder.py:
5904 fix all docstrings to make epydoc happy. In the process of fixing
5905 some, I also moved pieces of docs, and removed some deprecated
5908 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5910 * buildbot/process/builder.py:
5911 * buildbot/process/interlock.py:
5912 * buildbot/process/process_twisted.py:
5913 * buildbot/process/step.py:
5914 BuildProcess -> Build, as it looks like that's what happened
5915 * buildbot/process/base.py:
5916 * buildbot/process/factory.py:
5919 2005-04-17 Brian Warner <warner@lothar.com>
5921 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5922 update compile command to accomodate the Twisted split.. now
5923 instead of './setup.py build_ext -i', you do './setup.py all
5924 build_ext -i', to run build_ext over all sub-projects.
5925 (FullTwistedBuildFactory): same
5926 (TwistedReactorsBuildFactory): same
5928 * buildbot/status/html.py (TextLog.finished): null out self.req
5929 when we're done, otherwise the reference cycle of TextLog to .req
5930 to .notifications to a Deferred to TextLog.stop keeps them from
5931 being collected, and consumes a huge (610MB on pyramid at last
5932 check) amount of memory.
5934 2005-04-11 Brian Warner <warner@lothar.com>
5936 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5937 normalize the VC-repository location.. makes SVN happier with
5938 certain test environments.
5940 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5941 RemoteShellCommand gets its own .env dictionary, so that code in
5942 start() doesn't mutate the original. I think this should fix the
5943 step_twisted.Trial problem where multiple identical components
5944 kept getting added to PYTHONPATH= over and over again.
5946 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5947 adding epydoc-format docstrings to many classes. Thanks to Thomas
5948 Vander Stichele for the patches.
5949 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5950 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5951 * buildbot/slave/bot.py, commands.py, registry.py: same
5953 2005-04-05 Brian Warner <warner@lothar.com>
5955 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5956 preserve timestamps, helps incremental builds of large trees.
5957 Patch from Rene Rivera.
5959 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5960 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5963 2005-04-03 Brian Warner <warner@lothar.com>
5965 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5966 with one dict, apparently exec has some scoping bugs when used
5967 with both global/local dicts. Thanks to Nathaniel Smith for the
5970 2005-04-02 Brian Warner <warner@lothar.com>
5972 * buildbot/process/step_twisted.py (countFailedTests): the new
5973 trial in Twisted-2.0 emits a slightly different status line than
5974 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5975 mistakenly think the test count is unparseable.
5976 (Trial.start): note that for some reason each build causes another
5977 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5978 be fixed but I'm not sure quite where the problem is.
5980 2005-04-01 Brian Warner <warner@lothar.com>
5982 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5983 deferredResult to avoid hangs/warnings under twisted-2.0
5984 (RunMixin.tearDown): same
5985 (RunMixin.shutdownSlave): same
5986 (Disconnect.testIdle1): same
5987 (Disconnect.testBuild2): same: wait one second after the build
5988 finishes for test to really be done.. this should be cleaned up to
5989 avoid wasting that second. Builder.detach uses a callLater(0),
5990 either that should be done in-line (something else needed that
5991 behavior), or it should return a Deferred that fires when the
5992 builder is really offline.
5993 (Disconnect.testBuild3): same
5994 (Disconnect.testDisappear): same
5996 * buildbot/test/test_web.py: rearrange server-setup and teardown
5997 code to remove unclean-reactor warnings from twisted-2.0
5999 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
6000 so the tests don't hang under twisted-2.0
6002 2005-03-31 Brian Warner <warner@lothar.com>
6004 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
6005 caused a warning each time the master changed our set of builders
6007 * buildbot/status/builder.py (BuildStatus.saveYourself): under
6008 w32, don't unlink the file unless it already exists. Thanks to
6009 Baptiste Lepilleur for the catch.
6010 (BuilderStatus.saveYourself): same
6012 2005-02-01 Brian Warner <warner@lothar.com>
6014 * buildbot/status/html.py (TextLog.getChild): use a /text child
6015 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
6016 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
6017 logfile as text/plain (no markup, no headers). This replaces the
6018 previous scheme (which used an ?text=1 argument), and gets us back
6019 to a relative link (which works better when the buildbot lives
6020 behind another web server, such as Apache configured as a reverse
6021 proxy). Thanks to Gerald Combs for spotting the problem.
6023 * buildbot/__init__.py (version): bump to 0.6.2+ while between
6026 2004-12-13 Brian Warner <warner@lothar.com>
6028 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
6030 * debian/changelog: update for 0.6.2
6031 * NEWS: finalize for 0.6.2
6033 2004-12-11 Brian Warner <warner@lothar.com>
6035 * NEWS: bring it up to date
6037 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
6038 detection code. Require some sign of life from the buildmaster
6039 every BotFactory.keepaliveInterval seconds. Provoke this
6040 indication at BotFactory.keepaliveTimeout seconds before the
6041 deadline by sending a keepalive request. We don't actually care if
6042 that request is answered in a timely fashion, what we care about
6043 is that .activity() is called before the deadline. .activity() is
6044 triggered by any PB message from the master (including an ack to
6045 one of the slave's status-update messages). With this new scheme,
6046 large status messages over slow pipes are OK, as long as any given
6047 message can be sent (and thus acked) within .keepaliveTimeout
6048 seconds (which defaults to 30).
6049 (SlaveBuilder.remote_startCommand): record activity
6050 (SlaveBuilder.ackUpdate): same
6051 (SlaveBuilder.ackComplete): same
6052 (BotFactory.gotPerspective): same
6053 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
6055 2004-12-09 Brian Warner <warner@lothar.com>
6057 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
6060 * buildbot/process/step_twisted.py (Trial._commandComplete):
6061 update self.cmd when we start the 'cat test.log' transfer. Without
6062 this, we cannot interrupt the correct RemoteCommand when we lose
6065 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
6066 trying to tell the slave to stop the command if we're already
6067 inactive, or if we no longer have a .remote
6069 * buildbot/process/builder.py (Builder._detached): don't let an
6070 exception in currentBuild.stopBuild() prevent the builder from
6071 being marked offline
6073 2004-12-07 Brian Warner <warner@lothar.com>
6075 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
6076 KeyError that happens when you ask for a non-existent Builder, and
6077 translate it into a UsageError.
6079 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
6080 losing the slave in the middle of a remote step is handled too
6082 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
6083 be a Failure, so be sure to stringify it before using it as the
6084 contents of the 'interrupt' logfile
6085 (RemoteCommand.interrupt): use stringified 'why' in
6086 remote_interruptCommand too, just in case
6088 2004-12-06 Brian Warner <warner@lothar.com>
6090 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
6091 instead of 'tla update', which is more efficient in case we've
6092 missed a couple of patches since the last update.
6094 * debian/changelog: update for previous (0.6.1) release. Obviously
6095 this needs to be handled better.
6097 2004-12-05 Brian Warner <warner@lothar.com>
6099 * NEWS: update for stuff since last release
6101 * buildbot/master.py (DebugPerspective.attached): return 'self', to
6102 match the maybeDeferred change in Dispatcher.requestAvatar
6103 * buildbot/changes/pb.py (ChangePerspective.attached): same
6104 * buildbot/status/client.py (StatusClientPerspective.attached): same
6105 * buildbot/process/builder.py (Builder._attached3): same
6106 * buildbot/pbutil.py (NewCredPerspective.attached): same
6108 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
6109 the date to the top-most box, if it is not the same as today's
6112 * docs/slave.xhtml: provide a buildslave setup checklist
6114 * docs/source.xhtml (Arch): correct terminology
6116 2004-12-04 Brian Warner <warner@lothar.com>
6118 * buildbot/test/test_slavecommand.py: use sys.executable instead
6119 of hard-coding 'python' for child commands, might help portability
6121 * docs/examples/twisted_master.cfg: update to current usage
6123 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
6124 'stop build' command to the IRC bot
6126 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
6127 message that broke PBChangeSource
6129 * buildbot/slave/bot.py: clean up shutdown/lose-master code
6130 (SlaveBuilder): make some attributes class-level, remove the old
6131 "update queue" which existed to support resuming a build after the
6132 master connection was lost. Try to reimplement that feature later.
6133 (SlaveBuilder.stopCommand): clear self.command when the
6134 SlaveCommand finishes, so that we don't try to kill a leftover one
6136 (SlaveBuilder.commandComplete): same, merge with commandFailed and
6139 * buildbot/slave/commands.py (SourceBase): set self.command for
6140 all VC commands, so they can be interrupted.
6142 2004-12-03 Brian Warner <warner@lothar.com>
6144 * buildbot/master.py: clean up slave-handling code, to handle
6145 slave-disconnect and multiple-connect better
6146 (BotPerspective): make these long-lasting, exactly one per bot
6147 listed in the config file.
6148 (BotPerspective.attached): if a slave connects while an existing
6149 one appears to still be connected, disconnect the old one first.
6150 (BotPerspective.disconnect): new method to forcibly disconnect a
6151 buildslave. Use some hacks to empty the transmit buffer quickly to
6152 avoid the long (20-min?) TCP timeout that could occur if the old
6153 slave has dropped off the net.
6154 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
6155 own their own SlaveStatus objects. Remove .attached/.detached, add
6156 .addSlave/.removeSlave, treat slaves like Builders (config file
6157 parsing sends deltas to the BotMaster). Inform the slave
6158 instances, i.e. the BotPerspective, about addBuilder and
6160 (BotMaster.getPerspective): turns into a single dict lookup
6161 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
6162 which gives BotPerspective.attached a chance to disconnect the old
6164 (BuildMaster.loadConfig): add code (disabled) to validate that all
6165 builders use known slaves (listed in c['bots']). The check won't
6166 work with tuple-specified builders, which are deprecated but not
6167 yet invalid, so the check is disabled for now.
6168 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
6169 routine, do the add/changed/removed dance with them like we do
6171 (BuildMaster.loadConfig_Sources): move source-config into a
6172 separate routine too
6174 * buildbot/status/builder.py (Status.getSlave): get the
6175 SlaveStatus object from the BotPerspective, not the BotMaster.
6177 * buildbot/test/test_run.py: bunch of new tests for losing the
6178 buildslave at various points in the build, handling a slave that
6179 connects multiple times, and making sure we can interrupt a
6182 * buildbot/slave/bot.py (BuildSlave): make it possible to use
6183 something other than 'Bot' for the Bot object, to make certain
6184 test cases easier to write.
6185 (BuildSlave.waitUntilDisconnected): utility method for testing
6187 2004-11-30 Brian Warner <warner@lothar.com>
6189 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
6191 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
6192 argument, return a Deferred that always fires with True or False.
6193 I don't use an errback to indicate 'ping failed' so that callers
6194 are free to ignore the deferred without causing spurious errors in
6196 * buildbot/process/builder.py (BuilderControl.ping): implement it
6198 * buildbot/test/test_run.py (Status.testDisappear): test ping
6199 (Status.disappearSlave): fix it
6201 2004-11-30 Brian Warner <warner@lothar.com>
6203 * buildbot/interfaces.py (IBuildControl): add .stopBuild
6204 (IBuilderControl): add .getBuild(num), only works for the current
6205 build, of course, although it might be interesting to offer
6206 something for builds in the .waiting or .interlocked state.
6208 * buildbot/process/base.py (Build): have .stopBuild just do the
6209 interrupt, then let the build die by itself.
6210 (BuildControl): add .stopBuild, and add a point-event named
6211 'interrupt' just after the build so status viewers can tell that
6213 (BuilderControl): add .getBuild
6215 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
6216 stops when you kill it, good for testing
6217 (ShellCommand.interrupt): add a logfile named 'interrupt' which
6218 contains the 'reason' text.
6220 * buildbot/status/html.py: Add Stop Build button, if the build can
6221 still be stopped. Send a Redirect (to the top page) one second
6222 later, hopefully long enough for the interrupt to have an effect.
6223 Move make_row() up to top-level to share it between Stop Build and
6226 * buildbot/slave/commands.py: only kill the child process once
6228 * buildbot/test/test_run.py: add testInterrupt
6230 2004-11-29 Brian Warner <warner@lothar.com>
6232 * buildbot/process/base.py: Refactor command interruption. The
6233 Build is now responsible for noticing that the slave has gone
6234 away: Build.lostRemote() interrupts the current step and makes
6235 sure that no further ones will be started.
6237 * buildbot/process/builder.py: When the initial remote_startBuild
6238 message fails, log it: this usually indicates that the slave has
6239 gone away, but we don't really start paying attention until they
6240 fail to respond to the first step's command.
6242 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
6243 slave disconnect. Now sports a new interrupt() method. Error
6244 handling was simplified a lot by chaining deferreds, so
6245 remoteFailed/remoteComplete were merged into a single
6246 remoteComplete method (which can now get a Failure object).
6247 Likewise failed/finished were merged into just _finished.
6248 (BuildStep): Add interrupt(why) method, and if why is a
6249 ConnectionLost Failure then the step is failed with some useful
6252 * buildbot/slave/bot.py: stop the current command when the remote
6253 Step reference is lost, and when the slave is shut down.
6254 (Bot): make it a MultiService, so it can have children. Use
6255 stopService to tell when the slave is shutting down.
6256 (SlaveBuilder): make it a Service, and a child of the Bot. Add
6257 remote_interruptCommand (which asks the current SlaveCommand to
6258 stop but allows it to keep emitting status messages), and
6259 stopCommand (which tells it to shut up and die).
6261 * buildbot/slave/commands.py: make commands interruptible
6262 (ShellCommand.kill): factor out os.kill logic
6263 (Command): factor out setup()
6264 (Command.sendStatus): don't send status if .running is false, this
6265 happens when the command has been halted.
6266 (Command.interrupt): new method, used to tell the command to die
6267 (SlaveShellCommand): implement .interrupt
6268 (DummyCommand): implement .interrupt
6269 (SourceBase, etc): factor out setup(), don't continue substeps if
6272 * buildbot/status/builder.py: fix all waitUntilFinished() methods
6273 so they can be called after finishing
6275 * buildbot/test/test_run.py: new tests for disconnect behavior,
6276 refactor slave-shutdown routines, add different kinds of
6279 2004-11-27 Brian Warner <warner@lothar.com>
6281 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
6282 method to express ETA time like "2m45s" instead of "165 seconds"
6284 2004-11-24 Brian Warner <warner@lothar.com>
6286 * buildbot/test/test_vc.py (VC.testArch): unregister the test
6287 archive after the test completes, to avoid cluttering the user's
6288 'tla archives' listing with a bogus entry. Arch doesn't happen to
6289 provide any way to override the use of ~/.arch-params/, so there
6290 isn't a convenient way to avoid touching the setup of the user who
6292 (VC_HTTP.testArchHTTP): same
6294 2004-11-23 Brian Warner <warner@lothar.com>
6296 * buildbot/status/html.py (TextLog): split render() up into
6297 render_HEAD and render_GET. Use a Producer when sending log
6298 chunks, to reduce memory requirements and avoid sending huge
6299 non-Banana-able strings over web.distrib connections. Requires
6300 peeking under the covers of IStatusLog.
6301 (TextLog.resumeProducing): fix the "as text" link, handle client
6302 disconnects that occur while we're still sending old chunks.
6304 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
6305 use defer.succeed, not the non-existent defer.success
6306 (LogFile.waitUntilFinished): same
6307 (LogFile.subscribe): don't add watchers to a finished logfile
6309 * buildbot/__init__.py (version): bump to 0.6.1+ while between
6312 2004-11-23 Brian Warner <warner@lothar.com>
6314 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
6316 2004-11-23 Brian Warner <warner@lothar.com>
6318 * NEWS: update for the 0.6.1 release
6319 * MANIFEST.in: add new files
6321 * README (INSTALLATION): explain how to enable the extra VC tests
6323 * buildbot/status/builder.py (LogFile): add .runEntries at the class
6324 level to, so old pickled builds can be displayed ok
6326 2004-11-22 Brian Warner <warner@lothar.com>
6328 * NEWS: summarize updates since last release
6330 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
6331 Yoz Grahame. Closes SF#1050138.
6333 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
6336 * buildbot/process/step_twisted.py (Trial): update docs a bit
6338 * docs/factories.xhtml: fix Trial factory docs to match reality.
6341 * buildbot/process/factory.py (Trial.__init__): add args for
6342 randomly= and recurse=, making them available to instantiators
6343 instead of only to subclassers. Closes: SF#1049759.
6345 2004-11-15 Brian Warner <warner@lothar.com>
6347 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6348 try to teach the Quick factory to use multiple versions of python
6350 2004-11-12 Brian Warner <warner@lothar.com>
6352 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
6353 safer w32-compatible approach, and only use it on windows
6354 (BuildStatus.saveYourself): same
6356 2004-11-11 Brian Warner <warner@lothar.com>
6358 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
6359 it: one string merge per chunk. There are now separate .entries
6360 and .runEntries lists: when enumerating over all chunks, make sure
6362 * buildbot/test/test_status.py (Log): more tests
6364 * buildbot/status/builder.py (LogFile.addEntry): Merge string
6365 chunks together, up to 10kb per chunk. This ought to cut down on
6366 the CPU-burning overhead of large log files. Thanks to Alexander
6367 Staubo for spotting the problem.
6368 * buildbot/test/test_status.py (Log): tests for same
6370 2004-11-10 Brian Warner <warner@lothar.com>
6372 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
6373 header to outbound mail
6374 * buildbot/test/test_status.py (Mail.testBuild1): test for same
6376 2004-11-08 Brian Warner <warner@lothar.com>
6378 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
6379 can't do os.rename() onto an existing file, so catch the exception
6380 and unlink the target file first. This introduces a slight window
6381 where the existing file could be lost, but the main failure case
6382 (disk full) should still be handled safely.
6383 (BuildStatus.saveYourself): same
6385 * buildbot/changes/pb.py (ChangePerspective): use a configurable
6386 separator character instead of os.sep, because the filenames being
6387 split here are coming from the VC system, which can have a
6388 different pathname convention than the local host. This should
6389 help a buildmaster running on windows that uses a CVS repository
6390 which runs under unix.
6391 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
6393 * buildbot/process/step_twisted.py (Trial.createSummary): survive
6394 when there are no test failures to be parsed
6396 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
6397 instead of the unix-specific os.system("cp"), thanks to Elliot
6398 Murphy for this and the other buildbot-vs-windows catches.
6399 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
6401 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
6402 echo the command as it is run
6404 * setup.py: install sample.mk too, not just sample.cfg
6405 (scripts): install contrib/windows/buildbot.bat on windows
6407 2004-11-07 Brian Warner <warner@lothar.com>
6409 * buildbot/process/builder.py (Builder._detached): clear the
6410 self.currentBuild reference, otherwise the next build will be
6411 skipped because we think the Builder is already in use.
6413 * docs/examples/twisted_master.cfg: update to match current usage
6414 on the Twisted buildbot
6416 2004-10-29 Brian Warner <warner@lothar.com>
6418 * buildbot/status/mail.py (MailNotifier): fix typo in docs
6420 2004-10-28 Brian Warner <warner@lothar.com>
6422 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
6423 have separate doVCUpdate/doVCFull methods. Catch an update failure
6424 and respond by clobbering the source directory and re-trying. This
6425 will handle local changes (like replacing a file with a directory)
6426 that will cause CVS and SVN updates to fail.
6427 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
6429 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
6432 2004-10-19 Brian Warner <warner@lothar.com>
6434 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
6436 * buildbot/status/html.py (StatusResourceTestResults): display any
6437 TestResults that the Build might have
6438 (StatusResourceTestResult): and the logs for each TestResult
6439 (StatusResourceBuild): add link from the per-build page
6441 2004-10-15 Brian Warner <warner@lothar.com>
6443 * buildbot/process/step_twisted.py (Trial.createSummary): parse
6444 the 'problems' portion of stdout, add TestResults to our build
6445 * buildbot/test/test_twisted.py (Parse.testParse): test it
6447 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
6448 to retrieve a dict of accumulated test results
6449 (ITestResult): define what a single test result can do
6450 * buildbot/status/builder.py (TestResult): implement ITestResult
6451 (BuildStatus.getTestResults): retrieve dict of TestResults
6452 (BuildStatus.addTestResult): add TestResults
6453 * buildbot/test/test_status.py (Results.testAddResults): test it
6455 2004-10-14 Brian Warner <warner@lothar.com>
6457 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
6458 instead of os.system("rm -rf") for win32 portability
6460 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
6461 SignalMixin instead of starting/stopping the reactor, which is
6462 likely to cause problems with other tests
6464 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
6465 self.copyComplete() call. Yoz Grahame makes the catch.
6467 * contrib/windows/buildbot.bat: helper script to deal with path
6468 issues. Thanks to Yoz Grahame.
6470 * buildbot/master.py (BuildMaster.startService): don't register a
6471 SIGHUP handler if the signal module has no SIGHUP attribute.
6472 Apparently win32 does this.
6474 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
6476 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
6477 test if the reactor can't offer UNIX sockets
6479 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
6480 error introduced in the last commit. We really need that
6483 2004-10-12 Brian Warner <warner@lothar.com>
6485 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
6486 when describing a maildir source. Thanks to Stephen Davis.
6488 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
6491 * buildbot/scripts/runner.py (createMaster): install Makefile too
6492 (start): add --no_save to 'start' command
6493 * buildbot/scripts/sample.mk: simple convenience Makefile with
6494 start/stop/reload targets
6496 * buildbot/__init__.py (version): bump to 0.6.0+ while between
6499 2004-09-30 Brian Warner <warner@lothar.com>
6501 * setup.py: Releasing buildbot-0.6.0
6503 2004-09-30 Brian Warner <warner@lothar.com>
6505 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
6506 test_trial.py from the source tarball until support is complete.
6508 * NEWS: update for 0.6.0 release
6509 * buildbot/__init__.py (version): same
6512 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
6513 'source' command to tell users where to get the Buildbot source
6515 * docs/examples/*.cfg: update to modern standards
6517 * NEWS: update for release
6519 * buildbot/scripts/runner.py (createMaster): remove the
6520 -shutdown.tap stuff now that it isn't necessary
6522 (start): launch buildbot.tap, not buildbot-shutdown.tap
6525 * buildbot/status/mail.py (Domain): shorten class name
6526 (MailNotifier): if lookup= is a string, pass it to Domain()
6527 * buildbot/test/test_status.py (Mail.testBuild1): new class name
6528 (Mail.testBuild2): test the string-to-Domain shortcut
6529 (Mail.testMail): fix test
6532 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
6535 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
6536 more attributes on load
6537 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
6538 to accomodate the whole waterfall page at once, and the thrashing
6539 results in a lot of unnecessary loads
6540 (BuildStatus.saveYourself): use binary pickles, not fluffy text
6541 (BuilderStatus.saveYourself): same
6542 (BuilderStatus.eventGenerator): stop generating on the first missing
6543 build. We assume that saved builds are deleted oldest-first.
6544 (BuildStepStatus.__getstate__): .progress might not exist
6546 * buildbot/changes/changes.py (ChangeMaster): make it
6547 serializable, in $masterdir/changes.pck
6548 (ChangeMaster.stopService): save on shutdown
6549 * buildbot/master.py (BuildMaster.loadChanges): load at startup
6550 * buildbot/test/test_config.py: load Changes before config file
6553 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
6554 "Oh my god, you killed the command" header on a separate line
6556 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
6557 skip over corrupted build pickles
6558 (BuilderStatus.getFullBuildByNumber): same
6559 (BuilderStatus.eventGenerator): skip over unavailable builds
6560 (BuildStatus.saveYourself): save builds to a .tmp file first, then
6561 do an atomic rename. This prevents a corrupted pickle when some
6562 internal serialization error occurs.
6563 (BuilderStatus.saveYourself): same
6565 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
6566 the timeout for shell commands, it got lost somehow
6568 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
6569 run out of build steps, return the rest of the builder events
6571 * buildbot/interfaces.py (IBuilderControl.ping): add method
6573 * buildbot/process/builder.py (BuilderControl.ping): move
6574 slave-ping to BuilderControl, and fix the failure case in the
6575 process (Event.finish() is the verb, Event.finished is the noun).
6577 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
6578 through the BuilderControl instead of the BuilderStatus
6579 (EventBox): add adapter for builder.Event, allowing builder events to
6580 be displayed in the waterfall display
6582 * buildbot/master.py (BotMaster.stopService): add a 'master
6583 shutdown' event to the builder's log
6584 (BuildMaster.startService): and a 'master started' on startup
6586 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
6587 builder events into the BuildStep event stream
6588 (Status.builderAdded): add a 'builder created' event
6591 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
6592 command to announce the completion of a running build
6593 (IrcStatusBot.command_FORCE): announce when the build finishes
6595 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
6596 don't evict unfinished builds from the cache: they must stay in
6597 the full-cache until their logfiles have stopped changing. Make
6598 sure the eviction loop terminates if an unfinished build was hit.
6599 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
6600 This lets exceptions be dumped in an email status message. Really
6601 we need LogFiles which contain both text and HTML, instead of two
6603 (BuildStatus.__getstate__): handle self.finished=False
6604 (Status.builderAdded): if the pickle is corrupted, abandon the
6605 history and create a new BuilderStatus object.
6607 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
6608 self.progress attribute, helped one test which doesn't fully set
6609 up the Build object.
6611 * buildbot/interfaces.py (IStatusLogStub): split out some of the
6612 IStatusLog methods into an Interface that is implemented by "stub"
6613 logs, for which all the actual text chunks are on disk (in the
6614 pickled Build instance). To show the log contents, you must first
6615 adapt the stub log to a full IStatusLog object.
6617 * buildbot/status/builder.py (LogFileStub): create separate stub
6618 log objects, which can be upgraded to a real one if necessary.
6619 (LogFile): make them persistable, and let them stubify themselves
6621 (BuildStepStatus): same
6623 (BuildStatus.saveYourself): save the whole build out to disk
6624 (BuilderStatus): make it persistable
6625 (BuilderStatus.saveYourself): save the builder to disk
6626 (BuilderStatus.addFullBuildToCache): implement two caches which
6627 hold Build objects: a small one which holds full Builds, and a
6628 larger one which holds "stubbed" Builds (ones with their LogFiles
6629 turned into LogFileStubs). This reduces memory usage by the
6630 buildmaster by not keeping more than a few (default is 2) whole
6631 build logs in RAM all the time.
6632 (BuilderStatus.getBuild): rewrite to pull from disk (through the
6634 (BuilderStatus.eventGenerator): rewrite since .builds went away
6635 (BuilderStatus.buildStarted): remove the .builds array. Add the
6636 build to the "full" cache when it starts.
6637 (BuilderStatus._buildFinished): save the build to disk when it
6639 (Status): give it a basedir (same as the BuildMaster's basedir)
6640 where the builder pickles can be saved
6641 (Status.builderAdded): create the BuilderStatus ourselves, by
6642 loading a pickle from disk (or creating a new instance if there
6643 was none on disk). Return the BuilderStatus so the master can glue
6644 it into the new Builder object.
6646 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
6647 all BuilderStatuses to save themselves out to disk. This is in
6648 lieu of saving anything important in the main Application pickle
6649 (the -shutdown.tap file).
6650 (BuildMaster.__init__): give Status() a basedir for its files
6651 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
6652 to get the BuilderStatus, then give it to the Builder (instead of
6653 doing it the other way around). It's ok if the status announces
6654 the new Builder before it's really ready, as the outside world can
6655 only see the BuilderStatus object anyway (and it is ready before
6656 builderAdded returns). Use the builder's "builddir" (which
6657 normally specifies where the slave will run the builder) as the
6658 master's basedir (for saving serialized builds).
6660 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
6661 coerce the logfile to IStatusLog before trying to get the text
6662 chunks out of it. This will pull the full (non-stubified) Build in
6663 from disk if necessary.
6664 (TextLog): fix the adapter registration
6666 * buildbot/test/test_control.py (Force.setUp): create the basedir
6667 * buildbot/test/test_web.py: same
6668 * buildbot/test/test_vc.py (SetupMixin.setUp): same
6669 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
6670 * buildbot/test/test_run.py (Run.testMaster): same
6671 (Status.setUp): same
6673 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
6675 * buildbot/status/html.py (Waterfall.__init__): store actual
6676 allowForce flag passed in rather than using True for everyone;
6677 make sure setting it to False doesn't cause a NameError
6679 (StatusResourceBuilder.__init__) add the builder name to the page
6681 (StatusResourceBuilder.body) move HTML generation for a name/value
6682 row into a helper method (StatusResourceBuilder.make_row); only
6683 generate the "Force Build" form if allowForce was True and the
6684 slave is connected. Use class attributes in the generated HTML to
6685 spread a little CSS-joy.
6687 2004-09-28 Brian Warner <warner@lothar.com>
6689 * buildbot/process/step_twisted.py (Trial.createSummary): fix
6690 warning-scanner to not ignore things like
6691 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
6693 * buildbot/status/html.py (StatusResource.control): add some
6694 class-level values for .control in an attempt to make upgrading
6697 * buildbot/util.py (ComparableMixin): survive missing attributes,
6698 such as when a class is modified and we're comparing old instances
6701 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
6702 failure handling, remove a redundant try/except block. Don't
6703 return the full traceback to the IRC channel.
6704 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
6705 error messages. Get ETA properly.
6707 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
6708 the reason, since (at least) IRC message will have <> in them.
6709 (StatusResourceBuilder.__init__): take an IBuilderControl
6710 (StatusResourceBuilder.force): use the IBuilderControl we get in
6711 the constructor instead of trying to make our own. Catch the
6712 new exceptions and ignore them for now (until we make an
6713 intermediate web page where we could show the error message)
6714 (StatusResource): create with an IControl, use it to give an
6715 IBuilderControl to all children
6716 (Waterfall): take an allowForce= option, pass an IControl object
6717 to StatusResource if it is True
6719 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
6721 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6722 catch new exceptions and return string forms
6724 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
6725 * buildbot/process/builder.py (Builder.forceBuild): raise them
6726 * buildbot/test/test_control.py (Force.testNoSlave): new test
6727 (Force.testBuilderInUse): same
6730 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
6732 * buildbot/test/test_run.py: use IControl
6733 * buildbot/test/test_vc.py: same
6735 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
6736 to use IControl. Still offline.
6737 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
6739 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
6740 who=None so periodic builds don't send out status mail
6741 (Builder.forceBuild): include reason in the log message
6742 (BuilderControl.forceBuild): rename 'name' to 'who'
6744 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
6745 'who' parameter, but make it None by default so builds forced by
6746 slave admins don't cause status mail to be sent to anybody
6747 (BotMaster.forceBuild): same. this method is deprecated.
6748 (DebugPerspective.perspective_forceBuild): same, use IControl.
6749 (DebugPerspective.perspective_fakeChange): use IControl..
6750 (Dispatcher.requestAvatar): .. so don't set .changemaster
6752 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
6753 parameter to avoid confusion with the name of the builder
6756 * buildbot/status/mail.py: refine comment about needing 2.3
6758 * buildbot/status/html.py: move all imports to the top
6760 * buildbot/test/test_control.py: test new interfaces
6761 * buildbot/test/test_run.py (Status): handle new interfaces
6762 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
6764 * buildbot/process/base.py (BuildControl): implement IBuildControl
6765 and its lonely getStatus() method
6767 * buildbot/process/builder.py (BuilderControl): implement
6768 IBuilderControl, obtained by adapting the Builder instance
6769 (Builder.startBuild): return a BuilderControl instead of a
6770 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
6771 accomplish the same thing.
6773 * buildbot/master.py: move all import statements to the top
6774 (Control): implement IControl, obtained by adapting the
6775 BuildMaster instance.
6777 * buildbot/interfaces.py: add IControl, IBuilderControl, and
6778 IBuildControl. These are used to force builds. Eventually they
6779 will provide ways to reconfigure the Builders, pause or abandon a
6780 Build, and perhaps control the BuildMaster itself.
6782 2004-09-26 Brian Warner <warner@lothar.com>
6784 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
6785 ends up comparing us against something without a .__class__
6787 2004-09-24 Brian Warner <warner@lothar.com>
6789 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
6792 * Makefile: add 'deb-snapshot' target, to create a timestamped
6795 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
6797 2004-09-23 Brian Warner <warner@lothar.com>
6799 * buildbot/__init__.py (version): move version string here
6800 * setup.py: get version string from buildbot.version
6801 * buildbot/status/html.py (WaterfallStatusResource.body): add
6802 buildbot version to the page footer
6803 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
6806 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
6807 slaves, let the second know where the first one is coming from
6808 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
6809 see our exceptions. It would be nice if there were a way to just
6810 send them the exception type and value, not the full traceback.
6813 * buildbot/status/mail.py (MailNotifier): add a new argument
6814 sendToInterestedUsers=, which can be set to False to disable the
6815 usual send-to-blamelist behavior.
6816 (top): handle python-2.2 which has no email.MIMEMultipart
6817 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
6818 (MailNotifier.disownServiceParent): unsubscribe on removal
6820 * buildbot/test/test_status.py (Mail.testBuild2): test it
6823 * buildbot/status/progress.py (Expectations.wavg): tolerate
6824 current=None, which happens when steps start failing badly
6825 * buildbot/test/test_status.py (Progress.testWavg): test for it
6827 * buildbot/process/step.py (SVN.startVC): when the (old) slave
6828 doesn't understand args['revision'], emit a warning instead of
6829 bailing completely. Updating to -rHEAD is probably close enough.
6831 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
6833 * buildbot/test/test_status.py: at least import bb.status.client
6834 even if we don't have any test coverage for it yet
6836 * contrib/svn_buildbot.py: don't require python2.3
6837 (main): wait, do require it (for sets.py), but explain how to
6838 make it work under python2.2
6840 2004-09-23 Brian Warner <warner@lothar.com>
6842 * contrib/svn_buildbot.py: include the revision number in the Change
6844 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
6845 using util.now() because FreshCVS is a realtime service
6847 * buildbot/status/event.py: delete dead code
6848 * buildbot/process/step.py: don't import dead Event class
6849 * buildbot/process/step_twisted.py: same
6850 * buildbot/status/builder.py: same
6851 * buildbot/status/client.py: same
6853 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
6855 * buildbot/changes/changes.py (Change): set .when from an __init__
6856 argument (which defaults to now()), rather than having
6857 ChangeMaster.addChange set it later.
6858 (ChangeMaster.addChange): same
6860 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
6861 (parseSyncmail): same. Just use util.now() for now.
6862 (parseBonsaiMail): parse the timestamp field for when=
6864 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
6865 instead of setting .when after the fact
6869 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
6870 results when the target project uses retrial. Still under
6872 * buildbot/test/test_trial.py: same
6874 2004-09-21 Brian Warner <warner@lothar.com>
6876 * buildbot/status/mail.py (MailNotifier.__init__): include
6877 success/warnings/failure in the Subject line
6878 (MailNotifier.buildMessage): add the buildbot's URL to the body,
6879 use step.logname for the addLogs=True attachment filenames
6880 * buildbot/test/test_status.py (Mail): test Subject lines
6881 (Mail.testLogs): test attachment filenames
6883 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
6884 accept a 'who' argument from the debug tool
6885 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
6886 * contrib/debug.glade: add text box to set 'who'
6888 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6889 .getBuilderName with .getBuilder().getName(), more flexible
6890 (IStatusLog.getName): logs have short names, but you can prefix
6891 them with log.getStep().getName() to make them more useful
6892 * buildbot/status/builder.py: same
6893 * buildbot/status/client.py: same
6894 * buildbot/status/html.py: same
6895 * buildbot/test/test_run.py (Status.testSlave): same
6896 * buildbot/process/step.py: tweak logfile names
6898 * buildbot/status/mail.py (MailNotifier): add lookup, change
6899 argument to extraRecipients. The notifier is now aimed at sending
6900 mail to the people involved in a particular build, with additional
6901 constant recipients as a secondary function.
6903 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6904 including slow-lookup and failing-lookup. Make sure the blamelist
6905 members are included.
6907 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6908 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6909 (IBuildStatus.getInterestedUsers): new method
6910 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6911 * buildbot/status/client.py (remote_getResponsibleUsers): same
6912 * buildbot/status/html.py (StatusResourceBuild.body): same
6913 * buildbot/test/test_run.py (Status.testSlave): same
6915 2004-09-20 Brian Warner <warner@lothar.com>
6917 * docs/users.xhtml: update concepts
6919 * Makefile: add a convenience makefile, for things like 'make
6920 test'. It is not included in the source tarball.
6922 2004-09-16 Brian Warner <warner@lothar.com>
6924 * NEWS: mention /usr/bin/buildbot, debian/*
6926 * debian/*: add preliminary debian packaging. Many thanks to
6927 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6928 it considerably since it left their hands, I am responsible for
6929 all breakage that's resulted.
6931 * bin/buildbot: create a top-level 'buildbot' command, to be
6932 installed in /usr/bin/buildbot . For now it's just a simple
6933 frontend to mktap/twistd/kill, but eventually it will be the entry
6934 point to the 'try' command and also a status client. It is also
6935 intended to support the upcoming debian-packaging init.d scripts.
6936 * buildbot/scripts/runner.py: the real work is done here
6937 * buildbot/scripts/__init__.py: need this too
6938 * buildbot/scripts/sample.cfg: this is installed in new
6939 buildmaster directories
6940 * setup.py: install new stuff
6942 2004-09-15 Brian Warner <warner@lothar.com>
6944 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6945 'file:' schema (the version shipped with OS-X was built without the
6947 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6948 updates the log-timestamp, to make sure it isn't still running after
6951 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6952 values to the config file.
6953 * docs/examples/hello.cfg: add examples
6954 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6955 * buildbot/status/builder.py (Status.getProjectURL): implement them
6956 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6957 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6958 * buildbot/status/html.py (WaterfallStatusResource): display them
6961 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6962 certain error cases don't suffer a secondary exception.
6963 (top): Skip tests if the corresponding VC tool is not installed.
6965 * buildbot/process/factory.py (Trial): introduce separate
6966 'buildpython' and 'trialpython' lists, since trialpython=[] is
6967 what you want to invoke /usr/bin/python, whereas ./setup.py is
6968 less likely to be executable. Add env= parameter to pass options
6969 to test cases (which is how I usually write tests, I don't know if
6970 anyone else does it this way).
6972 * buildbot/process/step_twisted.py (Trial): handle python=None.
6973 Require 'testpath' be a string, not a list. Fix tests= typo.
6974 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6976 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6977 way to deal with the possibility of removing the disconnect notify
6979 (CVS): add a 'login' parameter to give a password to 'cvs login',
6980 commonly used with pserver methods (where pw="" or pw="guest")
6982 * buildbot/slave/commands.py (SourceBase): move common args
6983 extraction and setup() to __init__, so everything is ready by the
6984 time setup() is called
6985 (CVS.start): call 'cvs login' if a password was supplied
6986 (ShellCommand): special-case PYTHONPATH: prepend the master's
6987 value to any existing slave-local value.
6989 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6990 don't have a remote, mark the builder as Offline. This whole
6991 function should probably go away and be replaced by individual
6993 (Builder.buildFinished): return the results to the build-finished
6994 deferred callback, helps with testing
6996 2004-09-14 Brian Warner <warner@lothar.com>
6998 * buildbot/test/test_vc.py: put all the repositories needed to run
6999 the complete tests into a single small (1.3MB) tarball, so I can
7000 make that tarball available on the buildbot web site. Test HTTP
7001 access (for Arch and Darcs) by spawning a temporary web server
7002 while the test runs.
7004 * docs/users.xhtml: new document, describe Buildbot's limited
7005 understanding of different human users
7007 * buildbot/test/test_vc.py: rearrange test cases a bit
7009 * buildbot/process/step_twisted.py (Trial): handle testpath=
7010 * buildbot/process/factory.py (Trial): update to use step.Trial
7012 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
7014 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
7015 the overall build text (which gives you 'failed 2 tests' rather
7017 (BuildStepStatus.text2): default to [], not None
7019 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
7022 2004-09-12 Brian Warner <warner@lothar.com>
7024 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
7025 log the whole exception if it's just an AttributeError (old slave)
7027 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
7028 so (e.g.) sub-commands can be run in the right directory.
7029 (ShellCommand.start): accept an optional errorMessage= argument
7030 to make life easier for SVN.start
7031 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
7033 (ShellCommand.start): move ['dir'] compatibility hack..
7034 (RemoteShellCommand.start): .. to here so everyone can use it
7036 * buildbot/process/step_twisted.py (Trial): use .workdir
7038 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
7039 text displayed when debuild fails completely
7040 (Trial): snarf _trial_temp/test.log from the slave and display it
7042 2004-09-11 Brian Warner <warner@lothar.com>
7044 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
7046 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
7047 set to 'twisted', so --recurse can find twisted/web/test/*, etc
7049 * buildbot/process/step.py (ShellCommand): call .createSummary
7050 before .evaluateCommand instead of the other way around. This
7051 makes it slightly easier to count warnings and then use that to
7052 set results=WARNINGS
7053 * buildbot/process/step_twisted.py: cosmetic, swap the methods
7055 * buildbot/process/base.py (Build.buildFinished): update status
7056 before doing progress. It's embarrassing for the build to be stuck
7057 in the "building" state when an exceptions occurs elsewhere..
7059 * buildbot/status/progress.py (Expectations.expectedBuildTime):
7060 python2.2 doesn't have 'sum'
7062 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
7063 to prevent clients from accidentally sorting it
7065 * buildbot/master.py (Manhole): add username/password
7066 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
7067 c['manholePort'], deprecate old usage
7068 * docs/config.xhtml: document c['manhole']
7069 * docs/examples/hello.cfg: show example of using a Manhole
7072 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
7073 pretend the slave is up to date
7075 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
7076 the module, overlaps with 'log', the local variable
7078 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
7080 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
7081 new method to let Steps find out the version of their
7082 corresponding SlaveCommand.
7083 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
7084 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
7085 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
7087 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
7088 (Arch.startVC): same
7089 (P4Sync.startVC): same
7091 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
7092 Deferred so we can catch errors in remote_startCommand
7093 (RemoteShellCommand.start): same
7095 * docs/examples/twisted_master.cfg: update sample config file
7097 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
7098 after connectionMade() is called, not before. Close stdin at that
7101 * buildbot/process/process_twisted.py: update to use Trial, clean
7102 up argument passing (move to argv arrays instead of string
7105 * buildbot/process/step_twisted.py (Trial): new step to replace
7106 RunUnitTests, usable by any trial-using project (not just
7107 Twisted). Arguments have changed, see the docstring for details.
7109 * buildbot/process/base.py (Build.startBuild): this now returns a
7110 Deferred. Exceptions that occur during setupBuild are now
7111 caught better and lead to fewer build_status weirdnesses, like
7112 finishing a build that was never started.
7113 (Build.buildFinished): fire the Deferred instead of calling
7114 builder.buildFinished directly. The callback argument is this
7115 Build, everything else can be extracted from it, including the
7116 new build.results attribute.
7117 * buildbot/process/builder.py (Builder.startBuild): same
7118 (Builder.buildFinished): same, extract results from build
7120 * buildbot/process/step.py (ShellCommands): remove dead code
7122 2004-09-08 Brian Warner <warner@lothar.com>
7124 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
7125 doesn't try to use the leftover patched workdir
7126 (SourceStamp): test source-stamp computation for CVS and SVN
7128 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
7129 patched workdir ('touch .buildbot-patched') so we don't try to
7131 (SourceBase.start): add ['revision'] for all Source steps
7132 (CVS): change args: use ['branch'] for -r, remove ['files']
7133 (CVS.buildVC): fix revision/branch stuff
7134 (SVN): add revision stuff
7136 * buildbot/process/step.py (BuildStep.__init__): reject unknown
7137 kwargs (except 'workdir') to avoid silent spelling errors
7138 (ShellCommand.__init__): same
7139 (Source): new base class for CVS/SVN/etc. Factor out everything
7140 common, add revision computation (perform the checkout with a -D
7141 DATE or -r REVISION that gets exactly the sources described by the
7142 last Change), overridable with step.alwaysUseLatest. Add patch
7143 handling (build.getSourceStamp can trigger the use of a base
7144 revision and a patch).
7145 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
7146 * docs/steps.xhtml: update docs
7147 * docs/source.xhtml: mention .checkoutDelay
7148 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
7150 * buildbot/process/base.py (Build.setSourceStamp): add a
7151 .sourceStamp attribute to each Build. If set, this indicates that
7152 the build should be done with something other than the most
7153 recent source tree. This will be used to implement "try" builds.
7154 (Build.allChanges): new support method
7155 (Build.lastChangeTime): remove, functionality moved to Source steps
7156 (Build.setupBuild): copy the Step args before adding ['workdir'],
7157 to avoid modifying the BuildFactory (and thus triggering spurious
7161 * buildbot/status/html.py: rename s/commits/changes/
7162 (StatusResourceChanges): same
7163 (CommitBox.getBox): same, update URL
7164 (WaterfallStatusResource): same
7165 (StatusResource.getChild): same
7167 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
7168 * contrib/debug.glade: add optional 'revision' to the fakeChange
7170 * buildbot/changes/changes.py (html_tmpl): display .revision
7171 (ChangeMaster.addChange): note .revision in log
7172 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
7173 accept a ['revision'] attribute
7175 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
7177 * buildbot/master.py (BotMaster.getPerspective): update the
7178 .connected flag in SlaveStatus when it connects
7179 (BotMaster.detach): and when it disconnects
7180 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
7181 (BuildMaster.loadConfig_Builders): walk old list correctly
7183 * buildbot/test/test_config.py: fix prefix= usage
7185 2004-09-06 Brian Warner <warner@lothar.com>
7189 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
7190 poll a P4 depot looking for recent changes. Thanks to Dave
7191 Peticolas for the contribution. Probably needs some testing after
7194 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
7195 requires manual client setup for each buildslave. Rather
7196 experimental. Thanks again to Dave Peticolas.
7197 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
7199 * buildbot/changes/changes.py (Change): add a .revision attribute,
7200 which will eventually be used to generate source-stamp values.
7202 * buildbot/process/step.py (RemoteCommand.start): use
7203 notifyOnDisconnect to notice when we lose the slave, then treat it
7204 like an exception. This allows LogFiles to be closed and the build
7205 to be wrapped up normally. Be sure to remove the disconnect
7206 notification when the step completes so we don't accumulate a
7207 bazillion such notifications which will fire weeks later (when the
7208 slave finally disconnects normally). Fixes SF#915807, thanks to
7209 spiv (Andrew Bennetts) for the report.
7210 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
7211 really isn't Logged- specific
7212 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
7213 header, since it's almost always going to be appended to an
7215 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
7216 update test to handle use of notifyOnDisconnect
7218 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
7219 don't clear .ETA and .currentBuild when going offline, let the
7220 current build clean up after itself
7222 * buildbot/process/builder.py (Builder.detached): wait a moment
7223 before doing things like stopping the current build, because the
7224 current step will probably notice the disconnect and cleanup the
7226 * buildbot/test/test_run.py (Status.tearDown): update test to
7227 handle asynchronous build-detachment
7229 * buildbot/process/base.py (Build.stopBuild): minor shuffles
7231 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
7232 hush a debug message
7234 2004-09-05 Brian Warner <warner@lothar.com>
7236 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
7237 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
7238 kernels do this: the fcntl module has the F_NOTIFY constant, but
7239 the kernel itself doesn't support the operation. Thanks to Olly
7240 Betts for spotting the problem.
7242 * buildbot/process/step.py (Darcs): new source-checkout command
7243 (Arch): new source-checkout command
7244 (todo_P4): fix constructor syntax, still just a placeholder
7245 * buildbot/test/test_vc.py (VC.testDarcs): test it
7246 (VC.testDarcsHTTP): same, via localhost HTTP
7248 (VC.testArchHTTP): same
7249 * NEWS: mention new features
7251 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
7252 which tells the step to stash stdout text locally (in .stdout).
7253 Slave-side Commands can use this to make decisions based upon the
7254 output of the the ShellCommand (not just the exit code).
7255 (Darcs): New source-checkout command
7256 (Arch): New source-checkout command, uses .keepStdout in one place
7257 where it needs to discover the archive's default name.
7259 * docs/steps.xhtml: Document options taken by Darcs and Arch.
7260 * docs/source.xhtml: add brief descriptions of Darcs and Arch
7261 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
7263 * buildbot/process/step.py (ShellCommand.describe): add an
7264 alternate .descriptionDone attribute which provides descriptive
7265 text when the step is complete. .description can be ["compiling"],
7266 for use while the step is running, then .descriptionDone can be
7267 ["compile"], used alone when the step succeeds or with "failed" when
7268 it does not. Updated other steps to use the new text.
7269 * buildbot/process/step_twisted.py: same
7270 * buildbot/test/test_run.py: update tests to match
7272 2004-08-30 Brian Warner <warner@lothar.com>
7274 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
7275 (CVS.__init__): send 'patch' argument to slave
7276 (CVS.start): don't create the LoggedRemoteCommand until start(),
7277 so we can catch a .patch added after __init__
7278 (SVN.__init__): add 'patch' to SVN too
7281 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
7282 argument, to let commands push data into the process' stdin pipe.
7283 Move usePTY to a per-instance attribute, and clear it if 'stdin'
7284 is in use, since closing a PTY doesn't really affect the process
7285 in the right way (in particular, I couldn't run /usr/bin/patch
7287 (SourceBase.doPatch): handle 'patch' argument
7289 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
7292 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
7293 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
7295 * buildbot/master.py (BotPerspective.got_commands): get command
7296 versions from slave, give to each builder
7297 * buildbot/process/builder.py (Builder.attached): stash slave
7298 command versions in .remoteCommands
7300 * docs/steps.xhtml: bring docs in-line with reality
7302 * buildbot/process/step.py (CVS.__init__): more brutal
7303 compatibility code removal
7304 (SVN.__init__): same
7306 * buildbot/slave/commands.py (SlaveShellCommand): update docs
7307 (SlaveShellCommand.start): require ['workdir'] argument, remove
7308 the ['dir'] fallback (compatibility will come later)
7309 (SourceBase): update docs
7310 (SourceBase.start): remove ['directory'] fallback
7313 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
7314 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
7315 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
7317 * buildbot/process/step.py (RemoteShellCommand.__init__): add
7318 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
7319 code.. I will figure out 0.5.0-compatibility hooks later)
7321 2004-08-30 Brian Warner <warner@lothar.com>
7323 * buildbot/process/process_twisted.py: rewrite in terms of new
7324 BuildFactory base class. It got significantly shorter. Yay
7327 * buildbot/process/step_twisted.py (HLint.start): fix to make it
7328 work with the new "self.build isn't nailed down until we call
7329 step.start()" scheme: specifically, __init__ is called before the
7330 build has decided on which Changes are going in, so we don't scan
7331 build.allFiles() for .xhtml files until start()
7332 (HLint.commandComplete): use getText(), not getStdout()
7333 (RunUnitTests.start): same: don't use .build until start()
7334 (RunUnitTests.describe): oops, don't report (None) when using
7336 (RunUnitTests.commandComplete): use getText()
7337 (RunUnitTests.createSummary): same
7338 (BuildDebs.commandComplete): same
7340 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
7341 set args['command'] until start(), since our BuildStep is allowed
7342 to change their mind up until that point
7343 (TreeSize.commandComplete): use getText(), not getStdout()
7345 * docs/examples/twisted_master.cfg: update to current standards
7347 * docs/factories.xhtml: update
7348 * buildbot/process/factory.py: implement all the common factories
7349 described in the docs. The Trial factory doesn't work yet, and
7350 I've probably broken all the process_twisted.py factories in the
7351 process. There are compatibility classes left in for things like
7352 the old BasicBuildFactory, but subclasses of them are unlikely to
7354 * docs/examples/glib_master.cfg: use new BuildFactories
7355 * docs/examples/hello.cfg: same
7357 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
7358 explicit 'workdir' args
7360 * buildbot/process/base.py (BuildFactory): move factories to ..
7361 * buildbot/process/factory.py (BuildFactory): .. here
7362 * buildbot/process/process_twisted.py: handle move
7363 * buildbot/test/test_config.py: same
7364 * buildbot/test/test_run.py: same
7365 * buildbot/test/test_steps.py: same
7366 * buildbot/test/test_vc.py: same
7367 * docs/factories.xhtml: same
7369 * NEWS: mention config changes that require updating master.cfg
7371 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
7372 argument to all steps that weren't given one already, pointing at
7373 the "build/" directory.
7375 * docs/examples/hello.cfg: remove explicit 'workdir' args
7377 * docs/factories.xhtml: document standard BuildFactory clases,
7378 including a bunch which are have not yet been written
7380 2004-08-29 Brian Warner <warner@lothar.com>
7382 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
7383 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
7384 buildbot.status.builder so they aren't quite so internal
7385 * buildbot/process/base.py, buildbot/process/builder.py: same
7386 * buildbot/process/maxq.py, buildbot/process/step.py: same
7387 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
7388 * buildbot/status/mail.py, buildbot/test/test_run.py: same
7389 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
7391 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
7392 to handle new getLogs()-returns-list behavior
7393 (StatusResourceBuildStep.getChild): same
7394 (StepBox.getBox): same
7395 (WaterfallStatusResource.phase0): same
7397 * docs/source.xhtml: document how Buildbot uses version-control
7398 systems (output side: how we get source trees)
7399 * docs/changes.xhtml: rename from sources.xhtml, documents VC
7400 systems (input side: how we learn about Changes)
7402 * buildbot/master.py (Manhole): use ComparableMixin
7403 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
7404 * buildbot/changes/mail.py (MaildirSource): same
7405 * buildbot/status/client.py (PBListener): same
7406 * buildbot/status/html.py (Waterfall): same
7407 * buildbot/status/words.py (IRC): same
7409 * NEWS: start describing new features
7411 * buildbot/status/mail.py (MailNotifier): finish implementation.
7412 The message body is still a bit sparse.
7413 * buildbot/test/test_status.py (Mail): test it
7415 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
7416 and __hash__ methods I wind up adding everywhere. Specifically
7417 intended to support the buildbot config-file update scheme where
7418 we compare, say, the old list of IStatusTargets against the new
7419 one and don't touch something which shows up on both lists.
7420 * buildbot/test/test_util.py (Compare): test case for it
7422 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
7423 return a list instead of a dict
7424 (IBuildStepStatus.getLogs): same. The idea is that steps create
7425 logs with vaguely unique names (although their uniqueness is not
7426 guaranteed). Thus a compilation step should create its sole
7427 logfile with the name 'compile', and contribute it to the
7428 BuildStatus. If a step has two logfiles, try to create them with
7429 different names (like 'test.log' and 'test.summary'), and only
7430 contribute the important ones to the overall BuildStatus.
7431 * buildbot/status/builder.py (Event.getLogs): same
7432 (BuildStepStatus): fix default .text and .results
7433 (BuildStepStatus.addLog): switch to list-like .getLogs()
7434 (BuildStepStatus.stepFinished): same
7435 (BuildStatus.text): fix default .text
7436 (BuildStatus.getLogs): temporary hack to return all logs (from all
7437 child BuildStepStatus objects). Needs to be fixed to only report
7438 the significant ones (as contributed by the steps themselves)
7439 * buildbot/test/test_run.py: handle list-like .getLogs()
7440 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
7442 2004-08-28 Brian Warner <warner@lothar.com>
7444 * buildbot/process/builder.py (Builder.attached): serialize the
7445 attachment process, so the attach-watcher isn't called until the
7446 slave is really available. Add detached watchers too, which makes
7449 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
7451 * buildbot/test/test_swap.py: remove dead code
7453 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
7454 (ShellCommand.start): treat errors in _startCommand/spawnProcess
7455 sort of as if the command being run exited with a -1. There may
7456 still be some holes in this scheme.
7457 (CVSCommand): add 'revision' tag to the VC commands, make sure the
7458 -r option appears before the module list
7459 * buildbot/process/step.py (CVS): add 'revision' argument
7461 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
7462 when sending updates or stepComplete messages to the master, since
7463 we don't currently care whether they arrive or not. When we revamp
7464 the master/slave protocol to really resume interrupted builds,
7465 this will need revisiting.
7466 (lostRemote): remove spurious print
7468 * buildbot/master.py (BotPerspective.attached): serialize the
7469 new-builder interrogation process, to make testing easier
7470 (BotMaster.waitUntilBuilderDetached): convenience function
7472 * buildbot/status/builder.py (BuilderStatus): prune old builds
7473 (BuildStatus.pruneSteps): .. and steps
7474 (BuildStepStatus.pruneLogs): .. and logs
7475 (BuilderStatus.getBuild): handle missing builds
7476 * buildbot/status/html.py (StatusResourceBuild.body): display build
7477 status in the per-build page
7478 (BuildBox.getBox): color finished builds in the per-build box
7480 2004-08-27 Brian Warner <warner@lothar.com>
7482 * buildbot/status/mail.py (MailNotifier): new notification class,
7485 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
7486 variants of a common base class which handles all the mode= logic
7488 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
7490 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
7492 2004-08-26 Brian Warner <warner@lothar.com>
7494 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
7497 * buildbot/test/test_run.py: update to new Logfile interface, new
7498 buildbot.slave modules
7499 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
7501 * MANIFEST.in: new sample config file
7502 * docs/examples/hello.cfg: same
7504 * buildbot/process/step_twisted.py: remove dead import
7506 * buildbot/process/step.py (RemoteCommand.run): catch errors
7508 (RemoteCommand.remote_update): ignore updates that arrive after
7510 (RemoteCommand.remote_complete): ignore duplicate complete msgs
7511 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
7512 the responsibilities of the subclass's methods
7513 (BuildStep.failed): catch errors during failure processing
7514 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
7515 (CVS): move to a mode= argument (described in docstring), rather
7516 than the ungainly clobber=/export=/copydir= combination.
7517 (SVN): add mode= functionality to SVN too
7518 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
7520 * buildbot/process/base.py (Build.startNextStep): catch errors
7521 during s.startStep()
7523 * buildbot/clients/base.py: update to new PB client interface.
7524 gtkPanes is still broken
7526 * buildbot/bot.py, buildbot/slavecommand.py: move to..
7527 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
7528 * setup.py: add buildbot.slave module
7529 * buildbot/bb_tap.py: handle move
7530 * buildbot/slave/registry.py: place to register commands, w/versions
7531 * buildbot/slave/bot.py: major simplifications
7532 (SlaveBuilder.remote_startCommand): use registry for slave commands,
7533 instead of a fixed table. Eventually this will make the slave more
7534 extensible. Use 'start' method on the command, not .startCommand.
7535 Fix unsafeTracebacks handling (I think).
7536 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
7537 helper class with a .start method that returns a Deferred.
7538 SlaveShellCommand is the form reached by the buildmaster. Commands
7539 which use multiple ShellCommands can just chain them as Deferreds,
7540 with some helper methods in Command (_abandonOnFailure and
7541 _checkAbandoned) to bail on rc!=0.
7542 (CVSCommand): prefer new mode= argument
7543 (SVNFetch): add mode= argument
7545 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
7546 put a useful reason string on the build
7548 * buildbot/status/builder.py (LogFile): do LogFile right: move the
7549 core functionality into an IStatusLog object
7550 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
7551 * buildbot/status/html.py (TextLog): HTML-rendering goes here
7552 (StatusResourceBuild.body): use proper accessor methods
7553 * buildbot/status/client.py (RemoteLog): PB-access goes here
7554 (StatusClientPerspective.perspective_subscribe): add "full" mode,
7555 which delivers log contents too
7556 (PBListener.__cmp__): make PBListeners comparable, thus removeable
7557 * buildbot/status/event.py: remove old Logfile completely
7559 * buildbot/interfaces.py (IStatusLog.subscribe): make the
7560 subscription interface for IStatusLog subscriptions just like all
7561 other the status subscriptions
7562 (IStatusReceiver.logChunk): method called on subscribers
7564 2004-08-24 Brian Warner <warner@lothar.com>
7566 * buildbot/process/builder.py (Builder._pong): oops, ping response
7567 includes a result (the implicit None returned by remote_print).
7568 Accept it so the _pong method handles the response correctly.
7570 2004-08-06 Brian Warner <warner@lothar.com>
7572 * buildbot/test/test_config.py: update IRC, PBListener tests
7574 * buildbot/status/client.py (StatusClientPerspective): total
7575 rewrite to match new IStatus interfaces. New subscription scheme.
7576 There are still a few optimizations to make (sending down extra
7577 information with event messages so the client doesn't have to do a
7578 round trip). The logfile-retrieval code is probably still broken.
7579 Moved the PB service into its own port, you can no longer share a
7580 TCP socket between a PBListener and, say, the slaveport (this
7581 should be fixed eventually).
7582 * buildbot/clients/base.py (Client): revamp to match. still needs
7583 a lot of work, but basic event reporting works fine. gtkPanes is
7586 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
7587 instance talks to a single irc server. Threw out all the old
7588 multi-server handling code. Still need to add back in
7589 builder-control (i.e. "force build")
7591 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
7592 more random text to the as-yet-unreachable per-step page
7594 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
7595 rename to stepETAUpdate
7596 (BuildStatus.subscribe): add build-wide ETA updates
7597 (BuilderStatus.getState): remove more cruft
7598 (BuilderStatus.getCurrentBuild): remove more cruft
7599 (BuilderStatus.buildStarted): really handle tuple-subscription
7600 * buildbot/test/test_run.py (Status.testSlave): handle the
7601 stepETAUpdate rename
7603 * buildbot/master.py (BuildMaster): don't add a default
7604 StatusClientService. Don't add a default IrcStatusFactory. Both
7605 are now added through c['status'] in the config file. c['irc'] is
7606 accepted for backwards compatibility, the only quirk is you cannot
7607 use c['irc'] to specify IRC servers on ports other than 6667.
7609 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
7610 (IStatusReceiver.buildStarted): allow update-interval on subscribe
7611 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
7612 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
7615 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
7616 the buildmaster to re-read its config file
7619 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
7620 find out the port our server is running on
7621 (WebTest.test_webPathname_port): same
7623 * buildbot/test/test_config.py (testWebPortnum): test it
7624 (testWebPathname): ditto
7626 * docs/config.xhtml: document new c['status'] configuration option
7628 * buildbot/status/html.py (Waterfall): new top-level class which
7629 can be added to c['status']. This creates the Site as well as the
7630 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
7631 reachable as .parent, for everything.
7633 * buildbot/master.py (Manhole): make it a normal service Child
7634 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
7635 webPathname. It will eventually replace c['irc'] and the implicit
7636 PB listener as well. c['webPortnum'] and c['webPathname'] are left
7637 in as (deprecated) backward compatibility hooks for now.
7640 * buildbot/process/builder.py (Builder.buildFinished): don't
7641 inform out builder_status about a finished build, as it finds out
7642 through its child BuildStatus object
7644 * buildbot/status/html.py: extensive revamp. Use adapters to make
7645 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
7646 have both starting and finishing times and adjust the waterfall
7647 display accordingly, using spacers if necessary. Use SlaveStatus
7648 to get buildslave info.
7649 (StatusResourceBuildStep): new just-one-step resource, used to get
7650 logfiles. No actual href to it yet.
7652 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
7653 the time being, until I get the file-naming scheme right
7655 * buildbot/status/builder.py (Event): clean started/finished names
7656 (BuildStatus.isFinished): .finished is not None is the right test
7657 (BuildStatus.buildStarted): track started/finished times ourselves
7658 (BuilderStatus.getSlave): provide access to SlaveStatus object
7659 (BuilderStatus.getLastFinishedBuild): all builds are now in
7660 .builds, even the currently-running one. Accomodate this change.
7661 (BuilderStatus.eventGenerator): new per-builder event generator.
7662 Returns BuildStepStatus and BuildStatus objects, since they can
7663 both be adapted as necessary.
7664 (BuilderStatus.addEvent): clean up started/finished attributes
7665 (BuilderStatus.startBuild,finishBuild): remove dead code
7666 (SlaveStatus): new object to provide ISlaveStatus
7668 * buildbot/process/step.py (ShellCommand.getColor): actually
7669 return the color instead of setting it ourselves
7670 (CVS.__init__): pull .timeout and .workdir options out of
7671 **kwargs, since BuildStep will ignore them. Without this neither
7672 will be sent to the slave correctly.
7673 (SVN.__init__): same
7675 * buildbot/process/builder.py (Builder): move flags to class-level
7677 (Builder.attached): remove .remoteInfo, let the BotPerspective and
7678 SlaveStatus handle that
7680 * buildbot/process/base.py (Build.firstEvent): remove dead code
7681 (Build.stopBuild): bugfix
7683 * buildbot/changes/pb.py (PBChangeSource.describe): add method
7685 * buildbot/changes/changes.py (Change): add IStatusEvent methods
7686 (ChangeMaster.eventGenerator): yield Changes, since there are now
7687 Adapters to turn them into HTML boxes
7689 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
7690 (BotPerspective.attached): feed a SlaveStatus object
7691 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
7692 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
7694 * buildbot/interfaces.py: API additions
7695 (ISlaveStatus): place to get slave status
7697 2004-08-04 Brian Warner <warner@lothar.com>
7699 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
7700 the delay finishes, so the step is marked as SUCCESS
7702 * buildbot/test/test_run.py (Status.testSlave): cover more of
7703 IBuildStatus and IBuildStepStatus
7705 * buildbot/status/progress.py (StepProgress): move some flags to
7706 class-level attributes
7707 (StepProgress.remaining): if there are no other progress metrics
7708 to go by, fall back to elapsed time
7709 (StepProgress.setExpectations): take a dict of metrics instead of
7711 (BuildProgress.setExpectationsFrom): pull expectations from the
7712 Expectations, instead of having it push them to the BuildProgress
7713 (Expectations): move some flags to class-level attributes
7714 (Expectations.__init__): copy per-step times from the
7716 (Expectations.expectedBuildTime): new method for per-build ETA
7718 * buildbot/status/event.py (Logfile): move some flags to
7719 class-level attributes
7720 (Logfile.logProgressTo): better method name, let step set the
7721 progress axis name (instead of always being "output")
7723 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
7724 times directly, rather than depending upon the (possibly missing)
7725 .progress object. Use 'None' to indicate "not started/finished
7727 (BuildStepStatus.getExpectations): oops, return the full list of
7729 (BuilderStatus._buildFinished): append finished builds to .builds
7731 * buildbot/process/step.py (BuildStep): add separate .useProgress
7732 flag, since empty .progressMetrics[] still implies that time is a
7734 (CVS): set up the cmd in __init__, instead of waiting for start()
7736 * buildbot/process/base.py (Build.startBuild): disable the 'when'
7737 calculation, this will eventually turn into a proper sourceStamp
7738 (Build.setupBuild): tell the Progress to load from the Expectations,
7739 instead of having the Expectations stuff things into the Progress
7740 (Build.buildException): add a build-level errback to make sure the
7741 build's Deferred fires even in case of exceptions
7743 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
7745 * buildbot/process/builder.py (Builder.forceBuild): convey the
7746 reason instead of creating a fake Change
7748 * docs/examples/twisted_master.cfg: update to match reality
7750 * buildbot/test/test_config.py, buildbot/test/test_process.py:
7751 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
7752 fix or remove broken/breaking tests
7754 * buildbot/status/event.py (Logfile.__len__): remove evil method
7756 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
7757 missing .build, for test convenience
7759 * buildbot/process/step_twisted.py: import fixes
7761 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
7763 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
7764 .statusbag reference
7766 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
7767 connection at shutdown, and stop it from reconnecting
7769 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
7770 chase down remote-execution bugs
7772 * buildbot/process/step.py: more fixes, remove
7773 BuildStep.setStatus()
7774 * buildbot/status/builder.py: move setStatus() functionality into
7776 * buildbot/status/event.py: minor fixes
7778 2004-08-03 Brian Warner <warner@lothar.com>
7780 * buildbot/process/base.py, buildbot/process/builder.py
7781 * buildbot/process/step.py, buildbot/status/builder.py
7782 * buildbot/status/event.py, buildbot/test/test_run.py:
7783 fix status delivery, get a basic test case working
7784 * buildbot/master.py: finish implementing basic status delivery,
7785 temporarily disable HTML/IRC/PB status sources
7787 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
7789 * buildbot/status/progress.py (BuildProgress): remove dead code
7791 * buildbot/interfaces.py
7792 * buildbot/process/base.py, buildbot/process/builder.py
7793 * buildbot/process/step.py, buildbot/process/step_twisted.py
7794 * buildbot/status/builder.py: Complete overhaul of the all
7795 status-delivery code, unifying all types of status clients (HTML,
7796 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
7797 look like. This commit is a checkpointing of the work-in-progress:
7798 the input side is mostly done (Builders/Builds sending status
7799 to the BuilderStatus/BuildStatus objects), but the output side has
7800 not yet been started (HTML resources querying BuilderStatus
7801 objects). Things are probably very broken right now and may remain
7802 so for several weeks, I apologize for the disruption.
7804 * buildbot/status/event.py: add a setHTML method to use pre-rendered
7805 HTML as the log's contents. Currently used for exception tracebacks.
7806 * buildbot/status/progress.py: minor spelling changes
7808 2004-08-02 Brian Warner <warner@lothar.com>
7810 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
7811 in mozilla. Also added stylesheets copied from Twisted's docs.
7812 Remember that these files are meant to be run through Lore first.
7813 Thanks to Philipp Frauenfelder for the fixes.
7814 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
7815 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
7816 * docs/template.tpl: added a Lore template
7818 2004-07-29 Brian Warner <warner@lothar.com>
7820 * buildbot/interfaces.py: revamp status delivery. This is the
7821 preview: these are the Interfaces that will be provided by new
7822 Builder code, and to which the current HTML/IRC/PB status
7823 displayers will be adapted.
7825 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
7826 on the SlaveBuilder, not the Bot.
7827 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
7829 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
7830 set .usePTY on the FakeSlaveBuilder
7832 2004-07-25 Brian Warner <warner@lothar.com>
7834 * buildbot/changes/freshcvs.py: add some debug log messages
7835 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
7836 disabled 'setFilter' syntax
7837 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
7838 don't end with a slash
7840 * buildbot/process/base.py (Builder._pong_failed): add TODO note
7842 * setup.py: bump to 0.5.0+ while between releases
7844 2004-07-23 Brian Warner <warner@lothar.com>
7846 * setup.py (version): Releasing buildbot-0.5.0
7848 2004-07-23 Brian Warner <warner@lothar.com>
7850 * README: update for 0.5.0 release
7852 * NEWS: update for 0.5.0 release
7854 2004-07-22 Brian Warner <warner@lothar.com>
7856 * buildbot/slavecommand.py (ShellCommand): make usePTY a
7857 mktap-time configuration flag (--usepty=1, --usepty=0)
7858 * buildbot/bot.py: same
7860 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
7861 an 'info' directory being unwanted
7863 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
7864 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
7865 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
7866 and earlier), use a FreshCVSSourceOldcred instead.
7867 (test): simple test routine: connect to server, print changes
7869 * buildbot/changes/changes.py (Change.getTime): make it possible
7870 to print un-timestamped changes
7872 * buildbot/master.py (makeApp): delete ancient dead code
7873 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
7874 * buildbot/test/test_config.py (testFindConfigFile): test it
7876 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
7877 instead of win32 one
7880 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
7881 now takes a dictionary instead of a tuple. See docs/config.xhtml for
7884 * buildbot/process/base.py (Builder.__init__): change constructor
7885 to accept a dictionary of config data, rather than discrete
7886 name/slave/builddir/factory arguments
7888 * docs/examples/twisted_master.cfg: update to new syntax
7889 * docs/examples/glib_master.cfg: same
7890 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7891 rough tests of the new syntax
7894 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7895 to be an int, which means "run a web.distrib sub-server on a TCP
7896 port". This lets you publish the buildbot status page to a remote
7897 twisted.web server (using distrib.ResourceSubscription). Also
7898 rename the local attributes used to hold these web things so
7899 they're more in touch with reality.
7900 * buildbot/test/test_web.py: test webPortnum and webPathname
7901 * docs/config.xhtml: document this new use of webPathname
7903 * docs/config.xhtml: new document, slightly ahead of reality
7905 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7906 'prefix' handling: treat it as a simple string to check with
7907 .startswith, instead of treating it as a directory. This allows
7908 sub-directories to be used. If you use prefix=, you should give it
7909 a string that starts just below the CVSROOT and ends with a slash.
7910 This prefix will be stripped from all filenames, and filenames
7911 which do not start with it will be ignored.
7913 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7915 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7916 and --exclude (inverse of --include). SVN post-commit hooks
7917 now have total control over which changes get sent to buildbot and which
7920 2004-07-10 Brian Warner <warner@lothar.com>
7922 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7923 test case to match new API
7925 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7926 which crashed HTML display when self.entries=[] (needed to
7927 distinguish between [], which means "no entries yet", and None,
7928 which means "the entries have been swapped out to disk, go fetch
7931 2004-07-04 Brian Warner <warner@lothar.com>
7933 * buildbot/process/step_twisted.py (countFailedTests): Count
7934 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7935 10kb from the end because any import errors are wedged there and
7936 they would make us think the test log was unparseable.
7937 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7939 2004-06-26 Brian Warner <warner@lothar.com>
7941 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7942 delete-*.pyc command into an actual BuildStep, so we can label it
7944 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7945 (FullTwistedBuildFactory): same
7947 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7949 * contrib/fakechange.py: Add an errback when sending the fake
7950 change, so we know it didn't work.
7952 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7954 * buildbot/process/step_twisted.py: Delete *.pyc files before
7955 calling trial, so it doesn't catch any old .pyc files whose .py
7956 files have been moved or deleted.
7958 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7959 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7960 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7961 instead of ["twisted.test"], so that the end result is "trial -R
7964 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7965 regular expression to match filenames that should be ignored when
7966 changed. Also add a --revision parameter that specifies the
7967 revision to examine, which is useful for debugging.
7969 2004-06-25 Brian Warner <warner@lothar.com>
7971 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7972 summary of warnings (like DeprecationWarnings), next to the
7975 2004-05-13 Brian Warner <warner@lothar.com>
7977 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7978 we now have a w32 build slave courtesy of Mike Taylor.
7980 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7981 so broken. Fixed a race condition that tripped up interlocked
7982 builds and caused the status to be stuck at "Interlocked" forever.
7983 The twisted buildbot's one interlocked build just so happened to
7984 never hit this case until recently (the feeding builds both pass
7985 before the interlocked build is attempted.. usually it has to wait
7987 (Builder._pong_failed): fix method signature
7989 * setup.py: bump to 0.4.3+ while between releases
7991 2004-04-30 Brian Warner <warner@lothar.com>
7993 * setup.py (version): Releasing buildbot-0.4.3
7995 2004-04-30 Brian Warner <warner@lothar.com>
7997 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7999 * README: update for 0.4.3 release
8001 * NEWS: update for 0.4.3 release
8003 * buildbot/master.py (BuildMaster.__getstate__): make sure
8004 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
8006 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
8007 .trial as a class attribute, for upgrade from 0.4.2
8009 * buildbot/changes/changes.py (Change.links): add .links for
8012 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
8013 .textWatchers and .htmlWatchers at save time, since they are both
8014 volatile, should allow smooth 0.4.2 upgrade
8016 * buildbot/process/step.py (CVS.finishStatus): catch failed
8017 CVS/SVN commands so we can make the status box red
8019 2004-04-29 Brian Warner <warner@lothar.com>
8021 * buildbot/changes/freshcvs.py
8022 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
8023 code to do setFilter(), which tells the freshcvs daemon to not
8024 send us stuff that we're not interested in. I will uncomment it
8025 when a new version of CVSToys is available in which setFilter()
8026 actually works, and I get a chance to test it better.
8028 * docs/examples/twisted_master.cfg: start using a PBChangeSource
8030 * buildbot/master.py (Dispatcher): use a registration scheme
8031 instead of hardwired service names
8032 (BuildMaster): keep track of the Dispatcher to support
8035 * buildbot/changes/changes.py (ChangeMaster): create a distinct
8036 PBChangeSource class instead of having it be an undocumented
8037 internal feature of the ChangeMaster. Split out the code into a
8039 * buildbot/changes/pb.py (PBChangeSource): same
8040 * buildbot/test/test_changes.py: a few tests for PBChangeSource
8042 * docs/{factories|sources|steps}.xhtml: document some pieces
8044 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
8045 using FCMaildirSource
8046 (f23osx): update OS-X builder to use python2.3, since the slave
8047 was updated to Panther (10.3.3)
8049 2004-03-21 Brian Warner <warner@lothar.com>
8051 * buildbot/process/process_twisted.py: factor out doCheckout, change
8052 to use SVN instead of CVS
8054 * buildbot/process/base.py (BasicBuildFactory): refactor to make
8055 an SVN subclass easier
8056 (BasicSVN): subclass which uses Subversion instead of CVS
8058 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
8060 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
8062 (CVSCommand.cvsComplete): don't assume chdir worked on win32
8064 2004-02-25 Brian Warner <warner@lothar.com>
8066 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
8067 is now either a list (which is passed to spawnProcess directly) or
8068 a string (which gets passed to /bin/sh -c). This removes the useSH
8069 flag and the ArgslistCommand class. Also send status header at the
8070 start and end of each command, instead of having the master-side
8072 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
8073 -r'. Update to use list-based arguments.
8074 (SVNFetch): use list-based arguments, use ['dir'] argument to
8076 * buildbot/test/test_steps.py (Commands): match changes
8078 * buildbot/process/step.py (InternalShellCommand.words): handle
8080 (SVN): inherit from CVS, cleanup
8082 * buildbot/status/event.py (Logfile.content): render in HTML, with
8083 stderr in red and headers (like the name of the command we're
8084 about to run) in blue. Add link to a second URL (url + "?text=1")
8085 to get just stdout/stderr in text/plain without markup. There is
8086 still a problem with .entries=None causing a crash, it seems to occur
8087 when the logfile is read before it is finished.
8089 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
8090 timeout to the keepalives, and use it to explicitly do a
8091 loseConnection instead of waiting for TCP to notice the loss. This
8092 ought to clear up the silent-lossage problem.
8093 (unsafeTracebacks): pass exception tracebacks back to the master,
8094 makes it much easier to debug problems
8096 2004-02-23 Brian Warner <warner@lothar.com>
8098 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
8099 the whole command to /bin/sh instead of execve [Johan Dahlin]
8100 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
8101 '-r HEAD' [Johan Dahlin]
8102 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
8104 * buildbot/changes/changes.py (Change): add links= argument, add
8105 asHTML method [Johan Dahlin]. Modified to make a bit more
8106 XHTMLish. Still not sure how to best use links= .
8108 * buildbot/status/html.py (StatusResourceCommits.getChild): use
8109 Change.asHTML to display the change, not asText
8111 * buildbot/status/html.py (StatusResourceBuilder): web button to
8114 * buildbot/test/test_run.py: test to actually start a buildmaster
8117 * MANIFEST.in: bring back accidentally-dropped test helper files
8119 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
8120 that require cvstoys if it is not installed
8122 * buildbot/process/step_twisted.py (RunUnitTests): allow other
8123 values of "bin/trial" [Dave Peticolas]
8124 (RunUnitTests.finishStatus): say "no tests run" instead of "0
8125 tests passed" when we didn't happen to run any tests
8127 * buildbot/process/step.py (Compile): use haltOnFailure instead of
8128 flunkOnFailure [Johan Dahlin]
8130 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
8131 multiple instances of the same Step class by suffixing "_2", etc,
8132 to the name until it is unique. This name needs to be unique
8133 because it is used as a key in the dictionary that tracks build
8135 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
8138 * buildbot/process/base.py (Builder.ping): add "ping slave" command
8140 2004-01-14 Brian Warner <warner@lothar.com>
8142 * buildbot/status/words.py (IrcStatusBot): when we leave or get
8143 kicked from a channel, log it
8145 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
8146 something over whatever IRC channels the buildmaster is currently
8147 connected to. Added to try and track down a problem in which the
8148 master thinks it is still connected but the IRCd doesn't see it. I
8149 used a styles.Versioned this time, so hopefully users won't have
8150 to rebuild their .tap files this time.
8151 * contrib/debug.glade: add a "Poke IRC" button
8152 * contrib/debugclient.py: same
8154 * setup.py: bump to 0.4.2+ while between releases
8156 2004-01-08 Brian Warner <warner@lothar.com>
8158 * setup.py (version): Releasing buildbot-0.4.2
8160 2004-01-08 Brian Warner <warner@lothar.com>
8162 * NEWS: update for 0.4.2 release
8164 * README: document how to run the tests, now that they all pass
8166 * buildbot/changes/maildir.py (Maildir.poll): minor comment
8168 * buildbot/process/step.py (CVS): add a global_options= argument,
8169 which lets you set CVS global options for the command like "-r"
8170 for read-only checkout, or "-R" to avoid writing in the
8172 * buildbot/slavecommand.py (CVSCommand): same
8174 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
8175 testing easier (it is turned off when testing, to avoid the
8178 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
8179 to make it easier to test: break generateStepID() out to a
8180 separate function, only update statusbag if it exists.
8181 (ShellCommands): create useful text for dict-based commands too.
8183 * test/*, buildbot/test/*: move unit tests under the buildbot/
8185 * setup.py (packages): install buildbot.test too
8187 * buildbot/test/test_slavecommand.py: fix it, tests pass now
8188 * buildbot/test/test_steps.py: fix it, tests pass now
8190 2004-01-06 Brian Warner <warner@lothar.com>
8192 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
8193 freshcvs mail uses a slightly different syntax for new
8194 directories. Update parser to handle either.
8195 * test/test_mailparse.py (Test1.testMsg9): test for same
8197 2003-12-21 Brian Warner <warner@lothar.com>
8199 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
8200 'warnOnWarnings' so that lintian errors mark the build orange
8202 2003-12-17 Brian Warner <warner@lothar.com>
8204 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
8205 messages emitted by Bonsai, contributed by Stephen Davis.
8207 * test/*: moved all tests to use trial instead of unittest. Some
8208 still fail (test_steps, test_slavecommand, and test_process).
8210 * setup.py (version): bump to 0.4.1+ while between releases
8212 2003-12-09 Brian Warner <warner@lothar.com>
8214 * setup.py (version): Releasing buildbot-0.4.1
8216 2003-12-09 Brian Warner <warner@lothar.com>
8218 * NEWS: update for 0.4.1 release
8220 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
8221 freebsd builder code a little bit
8223 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
8224 don't try to compare attributes of different classes
8225 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
8226 (MaildirSource.messageReceived): fix Change delivery
8228 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
8229 into the config file's namespace before loading it, like the
8230 documentation claims it does
8231 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
8232 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
8233 daemon comes back online
8235 2003-12-08 Brian Warner <warner@lothar.com>
8237 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
8238 so the example will work with online=0 as well
8240 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
8241 fix the __implements__ line
8243 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
8244 class a twisted.application.service.Service, use startService to
8247 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
8248 directory fd instead of simple open(). I'm sure this used to work,
8249 but the current version of python refuses to open directories with
8252 2003-12-05 Brian Warner <warner@lothar.com>
8254 * setup.py (version): bump to 0.4.0+ while between releases
8256 2003-12-05 Brian Warner <warner@lothar.com>
8258 * setup.py (version): Releasing buildbot-0.4.0
8260 2003-12-05 Brian Warner <warner@lothar.com>
8262 * docs/examples/glib_master.cfg: replace old sample scripts with
8263 new-style config files
8264 * MANIFEST.in: include .cfg files in distribution tarball
8266 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
8267 implement a dummy method to avoid the exception that occurs when
8268 freshcvs sends this to us.
8270 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
8271 removed the method, as it broke reconnection. Apparently
8272 stopFactory is called each time the connection attempt fails. Must
8274 (ReconnectingPBClientFactory.__getstate__): squash the _callID
8275 attribute before serialization, since without stopFactory the
8276 reconnect timer may still be active and they aren't serializable.
8278 * test/test_mailparse.py (ParseTest): test with 'self' argument
8280 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
8281 argument, as these "functions" are invoked like methods from class
8282 attributes and therefore always get an instance as the first
8285 * buildbot/changes/maildir.py (Maildir.start): fix error in error
8286 message: thanks to Stephen Davis for the catch
8288 2003-12-04 Brian Warner <warner@lothar.com>
8290 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
8291 twisted's standard ReconnectingClientFactory. Handles both oldcred
8292 and newcred connections. Also has a bug-workaround for
8293 ReconnectingClientFactory serializing its connector when it
8296 * buildbot/bot.py (BotFactory): rewrite connection layer with new
8297 pbutil. Replace makeApp stuff with proper newcred/mktap
8298 makeService(). Don't serialize Ephemerals on shutdown.
8300 * buildbot/changes/changes.py (ChangeMaster): make it a
8301 MultiService and add the sources as children, to get startService
8302 and stopService for free. This also gets rid of the .running flag.
8304 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
8305 new pbutil, turn into a TCPClient at the same time (to get
8306 startService for free). Two variants exist: FreshCVSSourceOldcred
8307 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
8308 yet, but when it does, we'll be ready).
8309 (FreshCVSSource.notify): handle paths which are empty after the
8310 prefix is stripped. This only happens when the top-level (prefix)
8311 directory is added, at the very beginning of a Repository's life.
8313 * buildbot/clients/base.py: use new pbutil, clean up startup code.
8314 Now the only reconnecting code is in the factory where it belongs.
8315 (Builder.unsubscribe): unregister the disconnect callback when we
8316 delete the builder on command from the master (i.e. when the
8317 buildmaster is reconfigured and that builder goes away). This
8318 fixes a multiple-delete exception when the status client is shut
8320 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
8323 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
8324 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
8326 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
8328 * contrib/run_maxq.py: Accept a testdir as an argument rather than
8329 a list of globs (ugh). The testdir will be searched for files
8330 named *.tests and run the tests in the order specified in each of
8331 those files. This allows for "dependancies" between tests to be
8334 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
8335 argument to pass to run_maxq.py, instead of a glob.
8337 2003-10-17 Brian Warner <warner@lothar.com>
8339 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
8340 files that live in the sandbox
8342 2003-10-15 Brian Warner <warner@lothar.com>
8344 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
8345 spelling error in "docs" count-warnings output
8346 (HLint.start): stupid thinko meant .xhtml files were ignored
8348 * docs/examples/twisted_master.cfg (reactors): disable cReactor
8349 tests now that cReactor is banished to the sandbox
8351 2003-10-10 Brian Warner <warner@lothar.com>
8353 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
8354 scheme: now .xhtml are sources and .html are generated
8356 2003-10-08 Brian Warner <warner@lothar.com>
8358 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
8359 we were ignoring the 'randomly' parameter.
8361 2003-10-01 Brian Warner <warner@lothar.com>
8363 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
8364 posix, to kill sub-children of aborted slavecommands.
8366 * buildbot/status/builder.py: rename Builder to BuilderStatus.
8367 Clean up initialization: lastBuildStatus remains None until the
8368 first build has been completed.
8370 * buildbot/status/html.py (WaterfallStatusResource.body): handle
8371 None as a lastBuildStatus
8372 * buildbot/clients/gtkPanes.py: same
8374 * buildbot/status/client.py (StatusClientService): keep
8375 BuilderStatus objects in self.statusbags . These objects now live
8376 here in the StatusClientService and are referenced by the Builder
8377 object, rather than the other way around.
8378 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
8379 * buildbot/process/base.py (Builder): same
8380 * test/test_config.py (ConfigTest.testBuilders): same
8382 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
8383 an existing builder, leave the statusbag alone. This will preserve the
8386 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
8387 hook. This will probably go away in favor of a class in upcoming
8390 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
8391 serviceName from newcred FreshCVSNotifiee setup
8393 2003-09-29 Brian Warner <warner@lothar.com>
8395 * buildbot/process/process_twisted.py: switch to new reactor
8397 * docs/examples/twisted_master.cfg: same
8399 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
8401 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
8402 botmaster reference instead of the oldapp service lookup
8404 * buildbot/master.py (BuildMaster.__init__): give the
8405 StatusClientService a reference to the botmaster to make it easier to
8408 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
8410 * buildbot/status/html.py (Box.td): escape hreffy things so you
8411 can have spaces in things like builder names
8412 (StatusResourceBuilder.body)
8413 (WaterfallStatusResource.body)
8414 (WaterfallStatusResource.body0): same
8416 2003-09-25 Brian Warner <warner@lothar.com>
8418 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
8419 rearrange the builder list when adding or removing builders: keep
8420 them in the order the user requested.
8421 * test/test_config.py (ConfigTest.testBuilders): verify it
8423 * contrib/debug.glade: give the debug window a name
8425 * buildbot/process/base.py (Builder.buildTimerFired): builders can
8426 now wait on multiple interlocks. Fix code relating to that.
8427 (Builder.checkInterlocks): same
8428 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
8430 * buildbot/master.py (BuildMaster.loadConfig): move from
8431 deprecated pb.BrokerFactory to new pb.PBServerFactory
8432 * test/test_config.py (ConfigTest.testWebPathname): same
8434 * docs/examples/twisted_master.cfg: fix interlock declaration
8436 * buildbot/master.py (BotMaster.addInterlock): move code to attach
8437 Interlocks to their Builders into interlock.py .
8438 (BuildMaster.loadConfig_Interlocks): fix interlock handling
8440 * test/test_config.py (ConfigTest.testInterlocks): validate
8443 * buildbot/process/base.py (Builder.__init__): better comments
8444 * buildbot/process/interlock.py (Interlock.__repr__): same
8445 (Interlock.deactivate): add .active flag, move the code that
8446 attaches/detaches builders into the Interlock
8448 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
8450 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
8451 tests using the new run_maxq.py script, and reporting failures by
8454 * contrib/run_maxq.py: Hacky little script for running a set of maxq
8455 tests, reporting their success or failure in a buildbot-friendly
8458 2003-09-24 Brian Warner <warner@lothar.com>
8460 * docs/examples/twisted_master.cfg: example of a new-style config
8461 file. This lives in the buildmaster base directory as
8464 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
8465 button to make the master re-read its config file
8467 * buildbot/master.py (BuildMaster.loadConfig): new code to load
8468 buildmaster configuration from a file. This file can be re-read
8469 later, and the buildmaster will update itself to match the new
8470 desired configuration. Also use new Twisted Application class.
8471 * test/Makefile, test/test_config.py: unit tests for same
8473 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
8474 FreshCVSSources comparable, to support reload.
8475 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
8477 * buildbot/process/base.py (Builder): make them comparable, make
8478 Interlocks easier to attach, to support reload. Handle
8479 re-attachment of remote slaves.
8480 * buildbot/process/interlock.py (Interlock): same
8482 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
8483 Twisted's new Application class. Requires Twisted >= 1.0.8 .
8484 buildmaster taps are now constructed with mktap.
8485 * buildbot/status/client.py (StatusClientService): same
8487 * buildbot/status/words.py: move to new Services, add support to
8488 connect to multiple networks, add reload support, allow nickname
8489 to be configured on a per-network basis
8491 2003-09-20 Brian Warner <warner@lothar.com>
8493 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
8494 the freebsd builder, now that the machine has been upgraded and no
8495 longer has python2.2
8497 * setup.py (version): bump to 0.3.5+ while between releases
8499 2003-09-19 Brian Warner <warner@lothar.com>
8501 * setup.py (version): Releasing buildbot-0.3.5
8503 2003-09-19 Brian Warner <warner@lothar.com>
8505 * NEWS: add post-0.3.4 notes
8507 * README (REQUIREMENTS): note twisted-1.0.7 requirement
8509 * MANIFEST.in: add contrib/*
8511 * docs/examples/twisted_master.py (twisted_app): all build slaves must
8512 use a remote root now: cvs.twistedmatrix.com
8514 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
8516 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
8517 compatibility with old servers
8518 (FreshCVSSource.start): and provide a way to use it
8519 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
8521 * docs/examples/twisted_master.py (twisted_app): update to new
8523 (twisted_app): listen on new ~buildbot socket
8524 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
8526 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
8527 to reduce cvs bandwidth (update instead of full checkout)
8529 2003-09-11 Brian Warner <warner@lothar.com>
8531 * contrib/fakechange.py: demo how to connect to the changemaster
8532 port. You can use this technique to submit changes to the
8533 buildmaster from source control systems that offer a hook to run a
8534 script when changes are committed.
8536 * contrib/debugclient.py: tool to connect to the debug port. You
8537 can use it to force builds, submit fake changes, and wiggle the
8540 * buildbot/master.py: the Big NewCred Reorganization. Use a single
8541 'Dispatcher' realm to handle all the different kinds of
8542 connections and Perspectives: buildslaves, the changemaster port,
8543 the debug port, and the status client port. NewCredPerspectives
8544 now have .attached/.detached methods called with the remote 'mind'
8545 reference, much like old perspectives did. All the pb.Services
8546 turned into ordinary app.ApplicationServices .
8547 (DebugService): went away, DebugPerspectives are now created
8548 directly by the Dispatcher.
8549 (makeApp): changed interface a little bit
8551 * buildbot/changes/changes.py: newcred
8552 * buildbot/status/client.py: newcred
8554 * buildbot/clients/base.py: newcred client side changes
8555 * buildbot/bot.py: ditto
8557 * docs/examples/glib_master.py: handle new makeApp() interface
8558 * docs/examples/twisted_master.py: ditto
8560 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
8561 base newcred Perspectives on. This should go away once Twisted
8562 itself provides something sensible.
8565 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
8567 * contrib/svn_buildbot.py: A program that you can call from your
8568 SVNREPO/hooks/post-commit file that will notify a BuildBot master
8569 when a change in an SVN repository has happened. See the top of
8570 the file for some minimal usage info.
8572 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8574 * buildbot/slavecommand.py (ArglistCommand): Add new
8575 ArglistCommand that takes an argument list rather than a string as
8576 a parameter. Using a st.split() for argv is very bad.
8578 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
8579 update to a particular revision rather than always checking out
8580 (still not very smart about it, there may be cases where the
8581 checkout becomes inconsistent).
8583 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8585 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
8586 SVN fetch support. It can checkout (not update!) a specified
8587 revision from a specified repository to a specified directory.
8589 * buildbot/status/progress.py (Expectations.update): Fix an
8590 obvious bug (apparently created by the change described in the
8591 previous ChangeLog message) by moving a check to *after* the
8592 variable it checks is defined.
8595 2003-09-08 Brian Warner <warner@lothar.com>
8597 * buildbot/status/progress.py (Expectations.update): hack to catch
8598 an exception TTimo sees: sometimes the update() method seems to
8599 get called before the step has actually finished, so the .stopTime
8600 is not set, so no totalTime() is available and we average None
8601 with the previous value. Catch this and just don't update the
8602 metrics, and emit a log message.
8604 2003-08-24 Brian Warner <warner@lothar.com>
8606 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
8607 parameter to set copydir='original' in CVS commands.
8609 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
8611 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
8612 which tells the command to maintain a separate original-source CVS
8613 workspace. For each build, this workspace will be updated, then
8614 the tree copied into a new workdir. This reduces CVS bandwidth
8615 (from a full checkout to a mere update) while doubling the local
8616 disk usage (to keep two copies of the tree).
8618 2003-08-21 Brian Warner <warner@lothar.com>
8620 * buildbot/status/event.py (Logfile.addEntry): if the master web
8621 server dies while we're serving a page, request.write raises
8622 pb.DeadReferenceError . Catch this and treat it like a
8623 notifyFinish event by dropping the request.
8625 2003-08-18 Brian Warner <warner@lothar.com>
8627 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
8628 (instead of blowing up) if a force-build command is given without
8631 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
8632 don't blow up if there aren't yet any Changes in the list
8634 2003-08-02 Brian Warner <warner@lothar.com>
8636 * buildbot/bot.py (updateApplication): don't set the .tap name,
8637 since we shouldn't assume we own the whole .tap file
8639 * buildbot/bb_tap.py (updateApplication): clean up code, detect
8640 'mktap buildbot' (without a subcommand) better
8642 2003-07-29 Brian Warner <warner@lothar.com>
8644 * buildbot/status/words.py
8645 (IrcStatusFactory.clientConnectionLost): when we lose the
8646 connection to the IRC server, schedule a reconnection attempt.
8648 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
8649 use shutil.rmtree instead of forking off an "rm -rf" command.
8650 rmtree may take a while and will block until it finishes, so we
8651 use "rm -rf" if available.
8653 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
8654 freebsd buildslave badly
8656 * setup.py (version): bump to 0.3.4+ while between releases
8658 2003-07-28 Brian Warner <warner@lothar.com>
8660 * setup.py (version): Releasing buildbot-0.3.4
8662 2003-07-28 Brian Warner <warner@lothar.com>
8664 * NEWS: update in preparation for release
8666 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
8667 process.signalProcess instead of os.kill, to improve w32
8670 * docs/examples/twisted_master.py (twisted_app): turn off
8671 win32eventreactor: the tests hang the buildslave badly
8673 * buildbot/process/base.py (Build.buildFinished): update ETA even on
8674 failed builds, since usually the failures are consistent
8676 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8677 add compileOpts/compileOpts2 to reactors build
8679 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
8680 (twisted_app): use both default and win32eventreactor on w32 build.
8681 Use both default and kqreactor on freebsd build.
8683 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8684 add compileOpts2, which is put after the build_ext argument. w32
8685 needs "-c mingw32" here.
8687 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
8688 touch .acqpath, it goes away in recent Twisted releases
8690 * docs/examples/twisted_master.py (twisted_app): use "python" for
8691 the w32 buildslave, not "python2.2"
8693 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
8694 the directory exists.. should hush an exception under w32
8696 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
8697 ProcessTerminated -provided values for signal and exitCode rather
8698 than parsing the unix status code directly. This should remove one
8699 more roadblock for a w32-hosted buildslave.
8701 * test/test_mailparse.py: add test cases for Syncmail parser
8703 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
8704 temporary compatibility import. Note! Start importing
8705 FCMaildirSource from changes.mail instead of changes.freshcvsmail
8707 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
8709 2003-07-27 Brian Warner <warner@lothar.com>
8711 * NEWS: started adding new features
8713 * buildbot/changes/mail.py: start work on Syncmail parser, move
8714 mail sources into their own file
8716 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
8717 as implementing IChangeSource
8718 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
8720 * buildbot/interfaces.py: define the IChangeSource interface
8722 2003-07-26 Brian Warner <warner@lothar.com>
8724 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
8726 2003-06-25 Brian Warner <warner@lothar.com>
8728 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
8731 2003-06-17 Brian Warner <warner@lothar.com>
8733 * buildbot/status/words.py: clean up method usage to avoid error
8734 in silly IRC command
8735 (IrcStatusBot.emit_status): round off seconds display
8737 * buildbot/process/base.py (Build): delete the timer when saving
8738 to the .tap file, and restore it (if it should still be running)
8739 upon restore. This should fix the "next build in -34 seconds"
8740 messages that result when the master is restarted while builds are
8741 sitting in the .waiting slot. If the time for the build has
8742 already passed, start it very soon (in 1 second).
8744 * buildbot/status/words.py: more silly commands
8746 * README (REQUIREMENTS): add URLs to all required software
8748 * buildbot/status/words.py ('last'): mention results of, and time
8751 2003-05-28 Brian Warner <warner@lothar.com>
8753 * buildbot/status/words.py: add 'last' command
8754 (IrcStatusBot.emit_status): add current-small text to 'status' output
8756 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
8757 (twisted_app): remove spaces from OS-X builder name
8759 * buildbot/master.py (makeApp): add knob to turn on IRC bot
8760 * buildbot/status/words.py: IRC bot should actually be useful now
8762 2003-05-23 Brian Warner <warner@lothar.com>
8764 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
8765 "slave information" from $(slavedir)/info/* . These files are
8766 maintained by the slave administrator, and describe the
8767 machine/environment that is hosting the slave. Information from
8768 them is put into the "Builder" HTML page. Still need to establish
8769 a set of well-known filenames and meanings for this data: at the
8770 moment, *all* info/* files are sent to the master, but only
8771 'admin' and 'host' are used on that end.
8772 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
8773 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
8774 * buildbot/master.py (BotPerspective.got_info): ditto
8776 2003-05-22 Brian Warner <warner@lothar.com>
8778 * setup.py (version): bump version to 0.3.3+ while between releases
8780 2003-05-21 Brian Warner <warner@lothar.com>
8782 * setup.py: Releasing buildbot-0.3.3
8784 2003-05-21 Brian Warner <warner@lothar.com>
8786 * NEWS: 0.3.3 news items
8788 * README: describe --keepalive and life behind a NAT box
8790 * buildbot/bot.py (Bot.connected): implement application-level
8791 keepalives to deal with NAT timeouts, turn them on with
8792 --keepalive option or when SO_KEEPALIVE doesn't work.
8794 * buildbot/master.py (BotPerspective): accept keepalives silently
8796 * buildbot/process/base.py (Build.buildException): CopiedFailures
8797 don't carry as much information as local ones, so don't try to
8798 create a big HTMLized version of them.
8800 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
8801 log file when step fails due to an exception, such as when the slave
8804 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
8805 --testmodule argument instead of grepping for test-case-name tags
8806 ourselves. Remove FindUnitTests code.
8807 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
8809 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
8811 2003-05-16 Brian Warner <warner@lothar.com>
8813 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
8814 argument to allow things like CFLAGS=-O0 to be passed without relying
8815 upon /bin/sh processing on the slave.
8817 * buildbot/process/step.py (InternalShellCommand.start): send
8819 * buildbot/slavecommand.py (ShellCommand.start): create argv with
8820 'split' instead of letting /bin/sh do it. This should also remove
8821 the need for /bin/sh on the buildslave, making it more likely to
8824 * buildbot/status/html.py: html-escape text in blamelist.
8825 Add "force build" button to the Builder page.
8827 * buildbot/process/step_twisted.py (countFailedTests): look at
8828 last 1000 characters for status line, as import errors can put it
8829 before the -200 point.
8831 2003-05-15 Brian Warner <warner@lothar.com>
8833 * docs/examples/twisted_master.py: use clobber=0 for remote builds
8835 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8836 make 'clobber' a parameter, so it is possible to have builds which
8837 do full tests but do a cvs update instead of hammering the CVS
8838 server with a full checkout each build
8840 * buildbot/process/step.py (InternalShellCommand): bump default
8841 timeout to 20 minutes
8843 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
8844 the master to trigger a build. Run it via manhole.
8846 * buildbot/master.py (BotPerspective.perspective_forceBuild):
8847 allow slaves to trigger any build that they host, to make life
8848 easier for slave admins who are testing out new build processes
8850 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8851 don't flunk cReactor or qtreactor on failure, since they fail alot
8852 these days. Do warnOnFailure instead.
8854 * buildbot/process/base.py: change Builder.buildable from a list
8855 into a single slot. When we don't have a slave, new builds (once
8856 they make it past the timeout) are now merged into an existing
8857 buildable one instead of being queued. With this change, a slave
8858 which has been away for a while doesn't get pounded with all the
8859 builds it missed, but instead just does a single build.
8861 2003-05-07 Brian Warner <warner@lothar.com>
8863 * setup.py (version): bump version to 0.3.2+ while between releases
8865 2003-05-07 Brian Warner <warner@lothar.com>
8867 * setup.py: Releasing buildbot-0.3.2
8869 2003-05-07 Brian Warner <warner@lothar.com>
8871 * setup.py: fix major packaging error: include subdirectories!
8873 * NEWS: add changes since last release
8875 * README (REQUIREMENTS): update twisted/python dependencies
8877 * buildbot/status/builder.py (Builder.startBuild): change
8878 BuildProcess API: now they should call startBuild/finishBuild
8879 instead of pushing firstEvent / setLastBuildStatus. Moving towards
8880 keeping a list of builds in the statusbag, to support other kinds of
8882 (Builder.addClient): send current-activity-small to new clients
8883 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
8886 * buildbot/status/client.py: drop RemoteReferences at shutdown
8888 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8890 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8891 more debug messages for remote status client
8893 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8894 (.stepFailed): only fire the Deferred once, even if both
8895 stepComplete and stepFailed are called. I think this can happen if
8896 an exception occurs at a weird time.
8898 * buildbot/status/words.py: work-in-progress: IRC status delivery
8900 2003-05-05 Brian Warner <warner@lothar.com>
8902 * docs/examples/twisted_master.py (twisted_app): hush internal
8903 python2.3 distutils deprecation warnings
8904 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8905 add compileOpts= argument which inserts extra args before the
8906 "setup.py build_ext" command. This can be used to give -Wignore
8907 warnings, to hush some internal python-2.3 deprecation messages.
8909 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8910 the ['twisted.test'] default test case to make it easier to change
8913 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8914 * buildbot/clients/gtkPanes.py: ditto
8916 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8917 arg to collapse RunUnitTestsRandomly into RunUnitTests
8918 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8919 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8921 * buildbot/status/html.py (StatusResource): shuffle Resources
8922 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8923 would serve the waterfall display, but the internal links were
8924 only valid on the trailing-slash version. The correct behavior is
8925 for the non-slashed one to serve a Redirect to the slashed one.
8926 This only shows up when the buildbot page is hanging off another
8927 server, like a Twisted-Web distributed server.
8929 * buildbot/status/event.py (Event, RemoteEvent): make Events
8930 pb.Cacheable, with RemoteEvent as the cached version. This removes
8931 a lot of explicit send-an-update code.
8932 * buildbot/status/builder.py (Builder): remove send-update code
8933 * buildbot/status/client.py (ClientBuilder): remove send-update
8934 code, and log errors that occur during callRemote (mostly to catch
8935 InsecureJelly exceptions)
8937 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8938 run Lore with the same python used in the rest of the build
8940 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8942 * buildbot/process/step_twisted.py (HLint): accept 'python'
8943 argument. Catch rc!=0 and mark the step as failed. This marks the
8944 build orange ("has warnings").
8945 (RunUnitTestsJelly): move out to step_twisted2.py
8947 * buildbot/util.py (ignoreStaleRefs): add utility function
8949 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8950 don't fake ETA object, it's too hard to get right
8952 2003-05-02 Brian Warner <warner@lothar.com>
8954 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8956 2003-05-01 Brian Warner <warner@lothar.com>
8958 * buildbot/status/html.py (StatusResource.body): oops, I was
8959 missing a <tr>, causing the waterfall page to be misrendered in
8960 everything except Galeon.
8962 2003-04-29 Brian Warner <warner@lothar.com>
8964 * docs/examples/twisted_master.py: make debuild use python-2.2
8965 explicitly, now that Twisted stopped supporting 2.1
8967 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8968 handle tuple results too. I keep forgetting this, which suggests
8969 it needs to be rethought.
8971 * setup.py (setup): bump version to 0.3.1+ while between releases
8973 2003-04-29 Brian Warner <warner@lothar.com>
8975 * setup.py: Releasing buildbot-0.3.1
8977 2003-04-29 Brian Warner <warner@lothar.com>
8979 * README (SUPPORT): add plea to send questions to the mailing list
8981 * NEWS, MANIFEST.in: add description of recent changes
8983 * docs/examples/twisted_master.py: add the code used to create the
8984 Twisted buildmaster, with passwords and such removed out to a
8987 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8988 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8989 buildmasters to not require CVSToys be installed.
8990 * README, docs/examples/glib_master: update to match the change
8992 * buildbot/clients/base.py, buildbot/bot.py,
8993 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8994 ReconnectingPB from CVSToys distribution to remove CVSToys
8995 dependency for build slaves and status clients. Buildmasters which
8996 use FreshCVSSources still require cvstoys be installed, of course.
8998 2003-04-25 Brian Warner <warner@lothar.com>
9000 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
9001 runTestsRandomly arg to turn on trial -z
9003 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
9004 experimental code to use trial's machine-parseable output to get
9005 more detailed test results. Still has some major issues.
9006 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
9009 * buildbot/status/builder.py (Builder.setCurrentBuild):
9010 anticipating moving build history into statusbag, not used yet
9012 * buildbot/status/tests.py: code to centralize test results,
9013 doesn't work quite yet
9015 * buildbot/status/event.py (Event): use hasattr("setName") instead
9016 of isinstance for now.. need better long-term solution
9018 * buildbot/status/html.py: Remove old imports
9020 2003-04-24 Brian Warner <warner@lothar.com>
9022 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
9023 ignore changes under doc/fun/ and sandbox/
9025 * buildbot/process/step_twisted.py: update pushEvent and friends.
9027 * buildbot/status/html.py (Box.td): replace event.buildername with
9028 event.parent.getSwappableName(). Needs more thought.
9030 * buildbot/status/builder.py (Builder): Replace pushEvent and
9031 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
9032 Tell events they are being pruned with event.delete().
9034 * buildbot/process/base.py (Build): Remove Builder status-handling
9035 methods. s/pushEvent/setCurrentActivity/.
9037 * buildbot/process/step.py (BuildStep): clean up status delivery.
9038 Gouse builder.statusbag methods instead of intermediate builder
9039 methods. s/updateLastEvent/updateCurrentActivity/.
9040 s/finalizeLastEvent/finishCurrentActivity/. Use
9041 addFileToCurrentActivity for summaryFunction.
9043 * buildbot/status/event.py (Logfile): put data in a Swappable when
9045 (Event): add more setter methods. Remove .buildername, use .parent
9046 and getSwappableName instead (needs more thought).
9048 * buildbot/util.py (Swappable):
9049 * test/test_swap.py: don't bother setting filename at __init__
9050 time, do it later. Change setFilename args to take parent first,
9051 since it provides the most significant part of the filename.
9053 2003-04-23 Brian Warner <warner@lothar.com>
9055 * buildbot/status/event.py (Logfile.addEntry): append to previous
9058 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
9059 anticipating Swappable
9060 (InternalShellCommand.remoteUpdate): split out various log-adding
9061 methods so subclasses can snarf stdout separately
9063 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
9064 in anticipation of Swappable build logs
9065 (Builder.testsFinished): anticipating TestResults, still disabled
9067 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
9070 * buildbot/status/event.py (Logfile): add (disabled) support for
9071 Swappable, not ready for use yet
9073 * buildbot/util.py (Swappable): object which is swapped out to
9074 disk after some period of no use.
9075 * test/test_swap.py: test buildbot.utils.Swappable
9077 2003-04-14 Brian Warner <warner@lothar.com>
9079 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
9080 periodic-build timer. Set the .periodicBuildTime on a builder
9081 instance to some number of seconds to activate it.
9083 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
9085 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
9086 a way that survives result tuples
9088 2003-04-12 Brian Warner <warner@lothar.com>
9090 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
9091 return a dict instead of a tuple: allow summarizers to provide
9092 multiple summaries if they want
9093 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
9094 (debuildSummarizer): summarize lintian warnings/errors
9096 2003-04-10 Brian Warner <warner@lothar.com>
9098 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
9100 2003-04-09 Brian Warner <warner@lothar.com>
9102 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
9103 empty summaries: happens when the tests fail so hard they don't emit
9104 a parseable summary line.
9106 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
9107 Allow summaryFunction to return None to indicate no summary should
9110 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
9111 writing to stale HTTP requests: notice when they disconnect and
9112 remove the request from the list. Also add CacheToFile from
9113 moshez, will be used later.
9115 2003-04-08 Brian Warner <warner@lothar.com>
9117 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
9118 should be an int, not a list of strings
9120 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
9121 if we weren't actually connected
9123 * buildbot/process/step_twisted.py (trialTextSummarizer): function
9124 to show the tail end of the trial text output
9126 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
9127 hook to summarize the results of a ShellCommand
9129 2003-04-07 Brian Warner <warner@lothar.com>
9131 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
9132 twisted test suite code into a single class.
9133 * buildbot/process/process_twisted.py: same
9135 2003-04-04 Brian Warner <warner@lothar.com>
9137 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
9139 * README (SLAVE): document use of mktap to create slave .tap file
9140 (REQUIREMENTS): describe dependencies
9142 * buildbot/bb_tap.py, buildbot/plugins.tml:
9143 * buildbot/bot.py (updateApplication): Add mktap support for creating
9144 buildslave .tap files
9146 2003-03-28 Brian Warner <warner@lothar.com>
9148 * buildbot/process/step.py (InternalShellCommand.finished): handle
9149 new tuple result values (fix embarrasing bug that appeared during
9152 2003-03-27 Brian Warner <warner@lothar.com>
9154 * docs/examples/glib_master.py, README: add sample buildmaster.tap
9157 2003-03-25 Brian Warner <warner@lothar.com>
9159 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
9160 to overall build status
9161 * buildbot/clients/base.py (Builder): improve event printing
9162 * buildbot/process/base.py (BasicBuildFactory): use specific steps
9163 instead of generic ShellCommand
9164 (Build): Add .stopBuild, use it when slave is detached
9166 * buildbot/process/step.py (Configure,Test): give the steps their
9167 own names and status strings
9169 * buildbot/status/html.py (StatusResource): add "show" argument,
9170 lets you limit the set of Builders being displayed.
9172 2003-03-20 Brian Warner <warner@lothar.com>
9174 * buildbot/process/basic.py: removed
9176 2003-03-19 Brian Warner <warner@lothar.com>
9178 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
9179 turn off process-docs by default
9181 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
9182 when displaying build information without anything in allBuilds[]
9184 * buildbot/bot.py (makeApp): really take password from sys.argv
9186 2003-03-18 Brian Warner <warner@lothar.com>
9188 * buildbot/bot.py (buildApp): take password from sys.argv
9190 * README: replace with more useful text
9192 * setup.py: add a real one
9193 * MANIFEST.in, .cvsignore: more distutils packaging stuff
9195 * docs/PyCon-2003/: added sources for PyCon paper.
9197 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
9198 now Build objects control the process and Builder only handles
9199 slave stuff and distribution of changes/status. A new BuildFactory
9200 class creates Build objects on demand.
9202 Created ConfigurableBuild which takes a list of steps to run. This
9203 makes it a lot easier to set up a new kind of build and moves us
9204 closer to being able to configure a build from a web page.
9206 * buildbot/process/step_twisted.py, process_twisted.py: move to
9207 new model. A lot of code went away.
9209 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
9210 send lots of empty progress messages to the client.
9212 * buildbot/master.py (makeApp): enforce builder-name uniqueness
9214 2003-02-20 Brian Warner <warner@lothar.com>
9216 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
9218 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
9219 Twisted bug that prevented non-pty processes from working just got
9220 fixed, and the bug that leaks ptys is still being investigated.
9222 * buildbot/process/step.py (CVS): send timeout arg to slave
9224 * buildbot/clients/gtkPanes.py: add connection-status row, handle
9225 builders coming and going
9226 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
9227 from CVSToys, handle lost-buildmaster
9229 * buildbot/status/client.py (StatusClientService.removeBuilder):
9230 Clean up status client protocol: send builders (with references)
9231 as they are created, rather than sending a list and requiring the
9232 client to figure out which ones are new.
9233 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
9234 attempts to force a build on an unknown builder
9236 2003-02-19 Brian Warner <warner@lothar.com>
9238 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
9239 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
9240 Twisted stops leaking them.
9241 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
9242 builder goes to an idle state.
9244 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
9245 I figure out why CVS commands hang without them, and/or I fix the
9246 hung-command timeout
9248 2003-02-16 Brian Warner <warner@lothar.com>
9250 * buildbot/process/step_twisted.py: bin/hlint went away, replace
9251 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
9252 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
9253 GenerateDocs now that they are prefixed with WARNING:.
9255 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
9256 use manual href target instead of request.childLink
9258 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
9259 display every second, but update the ETA every 5 seconds (or
9260 whenever) as remote_progress messages arrive.
9263 2003-02-12 Brian Warner <warner@lothar.com>
9265 * *: import current sources from home CVS repository
9269 # add-log-time-format: add-log-iso8601-time-string