1 2008-04-15 Brian Warner <warner@lothar.com>
3 * buildbot/__init__.py (version): bump to 0.7.7+ while between
5 * docs/buildbot.texinfo: same
7 2008-03-29 Brian Warner <warner@lothar.com>
9 * buildbot/__init__.py (version): Releasing buildbot-0.7.7
10 * docs/buildbot.texinfo: same
12 2008-03-29 Brian Warner <warner@lothar.com>
14 * NEWS: update with all changes since the last release. I left the
15 bugs-fixed section somewhat terse, but there's a link to the Trac
16 page with more details.
19 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
20 accept category= arguments in the query-arg portion of the URL.
21 These behave like the builder= queryargs: if any category=
22 queryargs are present, we'll only show Builders that fit into one
23 of the specified categories. Using multiple category= arguments
24 will show more Builders. Thanks to Jerome Davann (hollowman) for
25 the idea and the patch. Closes #117.
26 * docs/buildbot.texinfo (Buildbot Web Resources): document it
28 * buildbot/changes/svnpoller.py (SVNPoller.create_changes): pass
29 revision as a string, not an int. This fixes a problem in
30 MailNotifier, which expects a string. Thanks to Dan Locks for the
31 patch, and Dustin Mitchell for the test fixups. Closes #208.
32 * buildbot/steps/source.py (Source.commandComplete): treat
33 got_revision as a string too.
34 * buildbot/test/test_svnpoller.py: update test to match
35 * buildbot/test/test_vc.py: same
37 2008-03-27 Brian Warner <warner@lothar.com>
39 * buildbot/scripts/runner.py (doCheckConfig): patch from Ben
40 Hearsum to implement 'buildbot checkconfig': validate that your
41 master.cfg is good without actually touching the buildmaster.
43 * buildbot/scripts/checkconfig.py: same
44 * docs/buildbot.texinfo (Testing the Config File): document it
46 2008-03-22 Brian Warner <warner@lothar.com>
48 * buildbot/test/test_vc.py (Mercurial.serveHTTP): another attempt
49 to make Mercurial.testCheckoutHTTP not fail on heavily loaded
50 machines: avoid overlapping poll() calls.
52 * NEWS: preliminary list of changes for the upcoming release.
53 Needs editing and explanations.
55 * buildbot/status/web/base.py (make_stop_form): add a label=
56 argument so that the button says "Stop Builds" or "Stop Build" as
57 appropriate. It used to say "Stop Builder", which was wrong.
58 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
59 (OneBoxPerBuilder.body): same
61 * buildbot/process/builder.py (Builder): use self.old_building to
62 track Builds from a previous version of this Builder and are still
63 running. This makes it possible for IBuilderControl to get at
64 them, allowing the "Stop Build" button to work after a
65 Builder-replacing reconfig. Closes #22.
66 (Builder.consumeTheSoulOfYourPredecessor): grab weakrefs from the
67 old Builder's self.building attribute, instead of strongrefs,
68 since there's no good place to explicitly forget about them.
69 (Builder.getBuild): factor this out of BuilderControl
71 * buildbot/process/buildstep.py (LogLineObserver.setMaxLineLength):
72 new method to override the default 16KiB line length. Lines that
73 are longer than this will cause the rest of the log file to be
74 ignored. Thanks to Greg Ward for the patch. Closes #201.
75 * buildbot/test/test_buildstep.py: new tests for log observers
76 * docs/buildbot.texinfo (Adding LogObservers): document it
78 * buildbot/slave/commands.py (ShellCommand): record more
79 information in the 'header' section: how much we write into stdin,
80 do we close stdin, are we using a PTY. There are lingering
81 problems with PTYs and with closing stdin (see #198 and #158).
82 This doesn't fix those problems, but it should provide more
83 information to developers.
85 * buildbot/status/client.py: hush pyflakes, log.msg vs log
86 * buildbot/status/mail.py: same
88 * buildbot/locks.py (debuglog): hush pyflakes
90 * buildbot/steps/source.py (SVN.__init__): fix pyflakes: it
91 doesn't like a variable named 'warnings' that shadows the import
93 * buildbot/test/test_web.py: fix some pyflakes warnings, caused by
94 having a variable name shadow a top-level import
96 * buildbot/test/test_run.py (Disconnect.testBuild2): fix old
97 cut-and-paste typo that was causing us to run the wrong callback
99 * Makefile (pyflakes): sort+uniqify, since newer pyflakes isn't
100 smart enough to do this on its own
101 * buildbot/test/runutils.py (myGetProcessOutputAndValue): move this
102 method out from test_vc.py, hush pyflakes complaints
104 * buildbot/test/test_vc.py (Mercurial.serveHTTP): wait for the 'hg
105 serve' command to be ready, by polling with twisted.web's
106 client.getPage . Unfortunately mercurial doesn't flush its stdout
107 at startup, so we can't just wait for the 'listening at..' line to
108 be printed. This should fix the sporadic "connection refused" test
109 failures I've seen on the metabuildbot when the buildslave is
110 overloaded and 'hg serve' takes a while to start up.
112 * buildbot/steps/python_twisted.py (TrialTestCaseCounter): modify
113 regexp to count "Doctest:" lines as well as normal tests. Thanks to
114 Martin Geisler for the patch. Closes #196.
116 2008-03-20 Brian Warner <warner@lothar.com>
118 * buildbot/status/web/waterfall.py (CurrentBox.formatETA): apply
119 patch from TedMielczarek to display hours/minutes/seconds in the
120 ETA display. Thanks Ted! Also make 'next build starts in' box use
121 the same format. Closes #95.
123 * buildbot/process/buildstep.py (render_properties): more cleanup:
124 rename 'render' to 'render_properties'.
125 * buildbot/steps/shell.py: same
126 (ShellCommand._interpolateProperties): tolerate None in the value,
127 clean up the isinstance checks, stop using the 'types' module
129 * buildbot/steps/transfer.py (FileUpload.start): same, other cleanups
131 * buildbot/steps/shell.py (render): oops, remove redundant
132 definition that probably crept in during a merge conflict
134 * buildbot/scheduler.py (Triggerable): cleanup: wrap docstring
135 * buildbot/steps/trigger.py (Trigger): cleanup: rename schedulers=
136 to schedulerNames=, make updateSourceStamp=True by default, tolerate
137 missing got_revision property (i.e. if updateSourceStamp=True but
138 there was no checkout/update step run), add TODO notes for further
140 * buildbot/test/test_run.py (Triggers): update to match
141 * docs/buildbot.texinfo (Build Dependencies): same
143 * buildbot/slave/commands.py (SVN.doVCFull): merge Dustin's patch:
144 add --no-auth-cache option to svn invocations to avoid caching
145 buildbot's credentials. This also helps when users run a
146 buildslave from their personal account, to keep the buildslave
147 from clobbering their manually-provided svn password. Closes #188.
148 (SVN.doVCUpdate): do it for 'svn update' too.
150 * buildbot/steps/shell.py: merge Greg Ward's patch (via Dustin):
151 refactor WithProperties handling, allow WithProperties in more
153 * buildbot/process/buildstep.py: same
154 * buildbot/steps/transfer.py: same, allow WithProperties in filenames
156 * buildbot/steps/trigger.py: remove unused imports to hush pyflakes
158 * docs/buildbot.texinfo (Build Properties): fix up nodes+menus
160 2008-03-19 Brian Warner <warner@lothar.com>
162 * buildbot/status/web/xmlrpc.py (XMLRPCServer.xmlrpc_getAllBuilders):
163 merge Etienne Pierre's patch (via Dustin): add new XMLRPC methods.
164 (XMLRPCServer.xmlrpc_getStatus): same
165 (XMLRPCServer.xmlrpc_getLastBuilds): same, returns the last N
166 completed builds for a given Builder
168 * buildbot/test/test_config.py (ConfigTest.setUp): merge Dustin's
169 patch: suppress DeprecationWarnings in our tests of deprecated
170 features that aren't scheduled for removal quite yet. In the long
171 run, we'll remove the old features and the tests.
173 * NEWS: add a deprecation schedule
174 * buildbot/changes/freshcvsmail.py: remove this file, it was
175 replaced by mail.FCMaildirSource in the previous release.
177 * buildbot/test/runutils.py: set usePTY=False everywhere we aren't
178 explicitly testing =True, to avoid SIGHUP-based failures that I
179 now see about 10% of the time.
181 * buildbot/scheduler.py (Triggerable): merge Dustin's patch: add
182 "Triggerable" Schedulers, to start builds at specific phases of
183 other builds rather than in response to source code changes or
184 periodic timers. These phases are marked by "Trigger" steps, which
185 are configured with a list of Triggerable schedulers that they
186 should fire. Closes #56.
187 * buildbot/steps/trigger.py (Trigger): buildstep to match
188 * buildbot/test/test_run.py (Triggers): test for it
189 * docs/buildbot.texinfo (Build Dependencies): document it
190 (Triggering Schedulers): same
192 2008-03-18 Brian Warner <warner@lothar.com>
194 * buildbot/interfaces.py (ISourceStamp.getAbsoluteSourceStamp):
195 merge patch from Dustin to add "absolute source stamps": just like
196 normal SourceStamp instances except that they have a .revision
197 attribute copied out of the got_revision property of a build. If
198 the input SourceStamp says .revision=None (i.e. HEAD), and the
199 build is done when the tree is at r1234, then the "absolute"
200 SourceStamp should have .revision=1234 .
201 * buildbot/sourcestamp.py (SourceStamp.getAbsoluteSourceStamp): same
202 * buildbot/status/builder.py (BuildStatus.getSourceStamp): add
205 * buildbot/test/runutils.py (SetTestFlagStep): test utility class,
206 adding 'flags' that can be set by specific buildsteps. This makes
207 it easier to write tests that detect whether certain buildsteps
208 have been reached or not. Patch by Dustin Mitchell.
209 * buildbot/test/test_run.py (TestFlag.testTestFlag): test for it.
211 * buildbot/buildslave.py (BuildSlave.__repr__): protect against
212 .botmaster being empty, to allow pretty-printing of configuration
213 files before the twisted reactor starts. Patch from Dustin
216 * docs/buildbot.texinfo (Shutdown): make it clear that 'buildbot
217 reconfig' (which uses SIGHUP) doesn't work on windows. Acknowledge
218 the occasional failures in reconfig (and suggest 'buildbot
219 restart' as a fallback). Closes #105.
221 * buildbot/steps/shell.py (ShellCommand._interpolateProperties):
222 apply patch from Albert Hofkamp to allow WithProperties in
223 environment variables and the workdir= argument. Closes #52.
224 * buildbot/test/test_properties.py (Interpolate.testCustomBuildStep):
225 remove this test, it was pretty weird and didn't work with the
226 new _interpolateProperties approach.
228 * buildbot/test/test_vc.py (VCBase.connectSlave): turn off usePTY
229 for all slave commands: I'm seeing 'cp' and 'rm' fail with SIGHUP,
230 probably when we close stdin. This happens on my debian/sid
231 system, but not on older unixes, so I suspect some change in
232 behavior in the kernel or glibc or something similar.
234 2008-02-05 Brian Warner <warner@lothar.com>
236 * buildbot/buildslave.py (BuildSlave._missing_timer_fired): add a
237 To: header to the email message we're composing. Oops. Thanks
238 to Zandr Milewski for the catch.
239 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
242 2007-12-31 Brian Warner <warner@lothar.com>
244 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): remove
245 the short timeouts, these can cause false test failures on slow
246 systems, and were only needed while developing the recent patch
247 (Download.testLotsOfBlocks): same
249 * buildbot/scripts/reconfig.py (Reconfigurator.run): if we're on
250 windows, make 'buildbot reconfig' emit a warning message (since
251 there's no SIGHUP to be had) rather than just hanging. Addresses
252 #105, but we still need to document this somewhere. Thanks to
253 Ben Hearsum for the patch.
255 * buildbot/slave/commands.py (SlaveFileUploadCommand.start):
256 rewrite the main loop to avoid tail recursion, since Deferreds
257 don't optimize those out. Without this, at the end of the transfer
258 we'd hit a stack depth of about two or three frames per block
259 transferred, and for large transfers this would run into a "stack
260 depth exceeded" error. Closes #106.
261 (SlaveFileDownloadCommand.start): same, for downloads.
262 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): test it
263 (Download.testLotsOfBlocks): same
265 2007-12-22 Brian Warner <warner@lothar.com>
267 * buildbot/steps/shell.py (TreeSize): This never worked properly.
268 Fix it. Also, stash the tree size in a build property named
269 'tree-size-kb'. Note that this records size in KiB (1024 bytes),
270 not KB (1000 bytes), because that's what du will give us. This
272 * docs/buildbot.texinfo (TreeSize): document it
273 * buildbot/test/test_steps.py (TreeSize.testTreeSize): test it
275 * buildbot/steps/shell.py (WarningCountingShellCommand): utility
276 subclass which uses a regular expression to count warning messages
277 in the output. This also puts warning messages in a new 'warnings'
278 logfile, sets the 'warnings-count' build property with the total
279 count, and marks the step results as WARNINGS if there are any
280 warnings. Thanks to Roch Gadsdon (rochg) for the patch. Closes
282 (Compile): derive from WarningCountingShellCommand
284 * docs/buildbot.texinfo (Compile): document it
285 * buildbot/test/test_steps.py (Warnings): test it
287 * buildbot/slave/commands.py (ShellCommand._chunkForSend): don't
288 send more than 128kB of stdout/stderr/logfile text in a single PB
289 string, since PB has a hardwired limit of 640kB. This should fix
290 crashes that occur when the test process generates output very
291 very quickly. Patch by chops@demiurgestudios.com, thanks! I
292 haven't been able to reproduce this locally, but the potential bug
293 is clear. This should close #129.
295 2007-12-21 Brian Warner <warner@lothar.com>
297 * buildbot/scripts/startup.py (start): check to see if there's a
298 buildbot.tac before doing anything else. This improves the error
299 message when you do 'buildbot start' in the wrong directory.
301 * buildbot/scripts/logwatcher.py (LogWatcher.start): rewrite to
302 spawn /usr/bin/tail to follow the target's twistd.log . It turns
303 out that OS-X file EOF semantics are different, and the naive
304 read-then-read-again approach I was using doesn't work (the first
305 EOF we hit is sticky). tail gets it right, so rely upon it instead
306 of reimplementing the wheel. This should make 'buildbot start'
307 correctly follow the logfile on OS-X, thus closing #141.
309 2007-12-14 Brian Warner <warner@lothar.com>
311 * buildbot/steps/shell.py (ShellCommand.__init__): stash the
312 RemoteShellCommands args too, so things like 'workdir' and 'env'
313 and 'timeout' are preserved. This ought to fix #150.
314 * buildbot/test/test_steps.py (Steps.testClone): test it
316 2007-12-11 Brian Warner <warner@lothar.com>
318 * buildbot/scripts/startup.py (launch): use twisted.__version__,
319 rather than twisted.version, since the latter didn't appear until
320 Twisted-2.4.0 . This unbreaks 'buildbot start' on older Twisteds.
322 2007-12-08 Brian Warner <warner@lothar.com>
324 * docs/buildbot.texinfo (Git): document the fact that we require
325 Git 1.2.0 or later, and that the one shipped in dapper is too old.
327 * buildbot/scripts/startup.py (launch): twisted-2.5.0 and later
328 doesn't need twisted.scripts._twistw.run; instead, it uses
329 twisted.scripts.twistd.run on all platforms. Closes #53.
331 2007-11-30 Brian Warner <warner@lothar.com>
333 * buildbot/status/builder.py (BuilderStatus): small docs patches
334 from Greg Ward.. thanks!
335 * buildbot/process/base.py (Build): same
337 2007-11-29 Brian Warner <warner@lothar.com>
339 * buildbot/slave/commands.py (Mercurial._maybeFallback): add an
340 _abandonOnFailure call to the fallback, to skip the 'update' step
341 if the checkout fails.
342 (Mercurial._maybeFallback): More fixes: look for error messages
343 generated by every version of hg from 0.7 to the current 0.9.5,
344 including development versions as of rev 92991422a847. Also make
345 sure to return the exit code of non-fallbackable errors so that
346 other steps can attempt a workaround.
348 2007-11-28 Brian Warner <warner@lothar.com>
350 * buildbot/slave/commands.py (Mercurial._maybeFallback): improve
351 hg fallback so that it works when the client hg is new and the
352 server hg is old (the error message is different in this case).
354 2007-11-27 Brian Warner <warner@lothar.com>
356 * buildbot/test/test_p4poller.py: hush pyflakes warning
358 * buildbot/slave/commands.py (Mercurial._maybeFallback): when hg
359 is doing a 'clone' operation, to a remote repository (e.g. over
360 HTTP), and either the server or the client is hg-0.9.1 or older,
361 'hg clone' cannot accept a --rev argument: instead, you have to
362 clone the tip and then update back to the desired revision. Added
363 code to detect this failure mode and fall back to the clone+update
364 scheme. Closes #122 and #103.
365 (ShellCommand.__init__): add a keepStderr= flag to support this
367 * buildbot/test/test_vc.py (VCBase._do_vctest_clobber_2): add a
368 test that does a checkout to a specific version, to exercise the
369 mercurial limitation workaround.
370 (Mercurial.serveHTTP): add code to test hg checkout over HTTP,
371 using mercurial's built-in 'hg serve' command. Because of
372 limitations in hg, this code uses a randomly-selected TCP
373 port (rather than claiming a free one), so every once in a while
374 this test is going to fail because of a port-number collision.
376 * buildbot/test/test_vc.py (GitHelper.capable): skip Git tests if
377 the version of Git installed is older than 1.2.x . Git 1.1.3
378 doesn't accept 'git init' (it wants 'git init-db' instead) and the
379 branch tests fail. I know that Git 1.5.3.6 works. I don't know
380 what the dividing line is.. if someone can figure it out, please
381 update this check. Also, if someone can make buildbot's git
382 support handle older versions, please do that too! Addresses #130.
384 2007-11-21 Brian Warner <warner@lothar.com>
386 * lots: improve Git support, AMAZING patch from Haavard
387 Skinnemoen, complete with unit tests and docs, thanks! Closes #130.
388 * buildbot/scripts/tryclient.py (GitExtractor): add 'try' support
389 * buildbot/slave/commands.py (Git): accept branch and revisions,
390 and use 'git' instead of the 'cogito' wrapper
391 * buildbot/steps/source.py (Git.__init__): same
392 * buildbot/test/test_vc.py (BaseHelper.runCommand): offer control
394 (BaseHelper.do): same
395 (BaseHelper.dovc): same
396 (Git): unit tests for Git support. Wow!
397 * docs/buildbot.texinfo (Git): docs for Git support. Double Wow!
398 * contrib/git_buildbot.py: commit-hook script for git
401 * buildbot/changes/p4poller.py (P4Source._finished): don't let a
402 failure cause us to stop polling. Thanks to John Backstrand for
403 the patch. Closes #135.
404 * buildbot/test/test_p4poller.py (TestP4Poller.testFailedChanges):
406 (TestP4Poller.testFailedDescribe): same
408 * buildbot/status/web/waterfall.py (WaterfallStatusResource.body):
409 fix timezone calculation, we were always emitting DST, even in
410 winter. Thanks to Charles Lepple and John Saxton for the patch.
412 * buildbot/test/test_web.py (Waterfall.test_waterfall._check1): same
415 * lots: a whole batch of patches from Benoit Sigoure, referenced
416 in ticket #138. Thanks!
418 * buildbot/master.py (BuildMaster.loadConfig): builder names that
419 begin with an underscore are now reserved, so prohibit them from
420 appearing in the config file.
421 * NEWS: announce this change.
423 * buildbot/status/web/base.py: add buttons (to one_line_per_build
424 and one_box_per_builder) to force/stop builds on all Builders at
426 * buildbot/status/web/baseweb.py: same
427 (OneBoxPerBuilder.body): add links to the per-Builder page
429 * buildbot/status/web/builder.py: same
431 * buildbot/status/web/builder.py (StatusResourceBuilder.body):
432 factor out force/stop form generation
433 * buildbot/status/web/base.py: same
434 * buildbot/status/web/build.py: same
436 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
437 simplify some 'if' statements
438 (StatusResourceBuilder.build_line): add a 'Stop Build' button next
439 to the 'Force Build' button, so you can start and stop a build
441 (StatusResourceBuilder.force): redirect back to the waterfall,
442 rather than the index page
443 (StatusResourceBuilder.ping): same
444 * buildbot/status/web/build.py (StatusResourceBuild.stop): same
446 * buildbot/slave/bot.py (Bot.remote_setBuilderList): don't
447 consider the 'info' directory as a leftover directory. Patch from
448 Benoit Sigoure, ticket #138.
449 (others): remove trailing whitespace
451 2007-11-01 Brian Warner <warner@lothar.com>
453 * buildbot/status/web/builder.py (StatusResourceBuilder.build_line):
454 if there's no current step, don't try to display its description.
455 Same crash as in #96, this time in the web page. Closes #111.
457 * buildbot/status/web/base.py (OneLineMixin.make_line): tolerate
458 results == None (i.e. when the build hasn't finished yet);
459 previously this code exploded when trying to find a CSS class for
460 that results value. Patch from Greg Ward. Closes #118.
462 * buildbot/status/client.py (RemoteBuildStep.remote_getLogs):
463 IBuildStepStatus.getLogs() returns a list, not a dict. Patch from
464 Fabrice Crestois. Closes #121.
466 2007-10-31 Brian Warner <warner@lothar.com>
468 * buildbot/status/words.py (Contact.emit_status): if there's no
469 current step, don't try to display its description. This should
470 fix the crash when asking the irc bot about builds which are
471 waiting for a build-wide Lock. Closes #96.
473 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
474 'columnName' argument, from a patch by Ben Hearsum. Closes #120.
476 2007-10-16 Brian Warner <warner@lothar.com>
478 * buildbot/status/web/slaves.py (BuildSlavesResource.body): fix
479 timestamp, I was using %M (minutes) where I meant to be using
480 %b (abbreviated month name). Closes #109.
482 2007-10-13 Brian Warner <warner@lothar.com>
484 * README (COPYING): make it clear that buildbot is distributed under
486 * COPYING: add a copy of the GPLv2 to the source tree
487 * MANIFEST.in: .. and to the source distribution too
489 2007-10-10 Brian Warner <warner@lothar.com>
491 * buildbot/status/builder.py (Status.getURLForThing): update this
492 to match new URL layout, I completely forgot about it. Closes #112.
493 * buildbot/test/test_web.py (GetURL): add unit tests
495 * buildbot/status/web/build.py (BuildsResource.getChild): fix
496 silly typo which prevented the Build page from ever offering
497 control options like 'Stop Build'. Thanks to Aaron Hsieh for the
499 * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd
502 * buildbot/__init__.py (version): bump to 0.7.6+ while between
504 * docs/buildbot.texinfo: same
506 2007-09-30 Brian Warner <warner@lothar.com>
508 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
509 * docs/buildbot.texinfo: same
511 2007-09-30 Brian Warner <warner@lothar.com>
513 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
514 * setup.py: install all test files from buildbot/test/mail/* . Also
515 update URL to point at buildbot.net
516 * MANIFEST.in: update with new files
518 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
519 auto-create an empty public_html directory, otherwise we get
520 internal server errors instead of 404s.
522 * README: reference buildbot.net, remove CVSToys section (does
523 anyone still use it?)
525 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
526 message when public_html/ is missing (indicating that you should
527 probably run 'upgrade-master'), and don't auto-create an empty
528 directory in that case.
530 * contrib/darcs_buildbot.py: refactor internals a bit, make it
531 possible to use as an importable module (to make it easier to
532 write some unit tests for it)
534 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
535 DeprecationWarning for Waterfall, advising users to switch over to
538 * NEWS: update with user-visible changes since the last release
540 * buildbot/status/web/waterfall.py
541 (WaterfallStatusResource.get_reload_time): if the suggest a
542 reload time of less than 15 seconds, give them 15 seconds instead
543 of ignoring their request entirely, because that'd be confusing.
545 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
546 warning if we must invoke the last-change-is-most-recent guess
548 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
549 Waterfall is running in an upgraded master (which is the usual
550 case for folks who have followed the instructions to run
551 'upgrade-master' but who have not yet resolved all the
552 DeprecationWarnings), prefer the buildbot.css from public_html/
553 rather than the one passed in on the buildbot= argument.
554 Otherwise, the resulting pages don't quite use CSS right..
555 sometimes it works, sometimes it doesn't, and I don't know why.
556 Sites that are using custom CSS will see the default CSS until
557 they modify public_html/buildbot.css to include their
560 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
561 * buildbot/status/web/robots.txt (Disallow): update to cover all
562 dynamically-generated pages
564 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
565 include both 'trunk' and None in the output list, since some VC
566 systems (SVN, frequently) refer to trunk as 'trunk'.
568 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
569 point the 'welcome' link explicitly at index.html, rather than
570 '.', so that old Waterfall users can reach it and discover all the
573 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
574 build's text to the end of the line, without a CSS class so it
577 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
578 'max_search=' argument, to limit the number of builds that are
579 examined while trying to find ones that match the other criteria.
580 This helps to limit the work we do, since otherwise we might have
581 to trawl through all history.
582 (IBuilderStatus.generateFinishedBuilds): same
583 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
584 (BuilderStatus.generateFinishedBuilds): same
586 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
587 our got_revision before checking its length: SVN (at least) still
588 reports numeric values for this.
589 * buildbot/status/web/build.py (StatusResourceBuild.body): same
590 * buildbot/status/web/xmlrpc.py
591 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
592 serving a completely fake revision
594 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
595 basedir to sys.path, to mimic what a real buildmaster would have
596 access to, since it is common for master.cfg to import helper
597 classes from .py files in the buildmaster directory, and we want
598 config-file checking to accomodate this.
600 * buildbot/status/web/base.py (map_branches): when referring to
601 branches through WebStatus (i.e. by appending ?branch=FOO query
602 arguments to the URL), make "trunk" mean trunk, by mapping it to
603 None before passing it to generateFinishedBuilds() and the like.
604 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
605 (OneBoxPerBuilder.body): same, also improve display of branches in
607 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
608 (WaterfallStatusResource.buildGrid): same. Note that this filters
609 Changes as well as Builds.
610 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
611 caveat about trunk branches, now that it's fixed
613 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
614 from builder.py, use it on the Builder page too
616 * buildbot/status/web/builder.py (StatusResourceBuilder): same
617 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
618 names, add some CSS classes
619 * buildbot/status/web/classic.css (td.box): new class, for
622 * docs/buildbot.texinfo (WebStatus): update docs
624 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
625 the trailing "M" indicator that tells us this is a modified file.
626 This should help with mode="update" builds that modify files
627 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
630 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
631 new copies of files (to .new) when those files already exist,
632 check the master.cfg file for errors (and give DeprecationWarnings
633 a chance to be displayed).
634 * buildbot/test/test_runner.py: add more tests
635 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
637 2007-09-29 Brian Warner <warner@lothar.com>
639 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
640 the revision id from the last change in our list, since that's the
641 best we can do without knowing the full ancestry graph. Closes #103.
643 * buildbot/scripts/sample.cfg: use buildstep instances in
644 f.addStep, to demonstrate the (correct) modern usage.
645 * docs/examples/hello.cfg: bring this up to date. Closes #79.
646 * docs/examples/twisted_master.cfg: add a big warning about how
648 * docs/examples/glib_master.cfg: delete this one entirely, it is
649 ancient and not a very useful example anyways
651 * buildbot/status/web/base.py (HtmlResource.render): keep track of
652 HTTPChannels, so we can shut them down at reconfig time (when the
653 WebStatus goes away). Closes #102.
654 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
655 (WebStatus.registerChannel): same
656 (WebStatus.stopService): do .loseConnection() here
658 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
659 WebStatus, make sure all pages are still retrievable. I thought
660 this would exercise a bug, but it turns out that it was firefox
661 caching connections (and continuing to talk to the old WebStatus
662 even though I'd loaded a new one).
663 * buildbot/status/web/baseweb.py (WebStatus): add some comments
664 (WebStatus.__repr__): include id() in the repr
666 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
667 this to specify an errorparser. From Ted Mielczarek and the
668 mozilla crew. Closes #94.
670 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
671 bonsaipoller ignore funkyness in xml output for empy log
672 messages", from Axel Hecht. Closes #90.
673 * buildbot/test/test_bonsaipoller.py
674 (TestBonsaiPoller.testMergeEmptyLogMsg): same
676 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
677 respect 'builders' arg, from Ben Hearsum. Closes #89.
679 * buildbot/scripts/runner.py (stop): increase the timeout from 5
680 seconds to 10, to give heavily loaded machines a better chance to
681 finish shutting down. Addresses (partially) #68.
682 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
684 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
685 * buildbot/scripts/startup.py (Follower._failure): update message
687 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
688 team, to fix some bugs and avoid the use of blocking urlopen().
690 * buildbot/test/test_bonsaipoller.py: same
692 2007-09-28 Brian Warner <warner@lothar.com>
694 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
695 argument, to send email about buildslaves which are disconnected
696 for more than an hour. Closes #64.
697 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
699 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
700 (MailNotifier): add docs for this too
703 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
704 respect branch= queryargs, by restricting the builds displayed to
705 those matching the given branch names
706 * buildbot/status/web/waterfall.py (BuildTopBox): same
708 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
709 fix a test failure by adding .prepath to this fake object
711 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
712 up generation of relative URLs. With luck, this should play with
713 reverse proxies much better now.
714 * buildbot/test/test_webparts.py: new test for most of the subpages
715 * buildbot/test/test_web.py (base_config): add enough of a config
716 to exercise more Waterfall code
718 2007-09-27 Brian Warner <warner@lothar.com>
720 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
721 relative URL to the buildbot welcome page, rather than
723 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
725 * buildbot/status/web/base.py (HtmlResource.title): change the
726 default title of all Buildbot-generated page to "Buildbot"
727 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
728 change the title to include the Builder name
729 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
730 same, and also show the build number
731 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
732 redirect the browser to the Builder page
734 2007-09-26 Brian Warner <warner@lothar.com>
736 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
737 problem with the build links
739 2007-09-25 Brian Warner <warner@lothar.com>
741 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
742 to emit relative URLs instead of using URLPath,
744 * docs/buildbot.texinfo (WebStatus): provide an example
746 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
747 page, shows a simple table with one row per Builder. Still pretty
748 ugly, but functional.
749 * buildbot/status/web/index.html: reference it
751 * buildbot/status/web/waterfall.py (Spacer): make this *not*
752 inherit from builder.Event, so that show_events=false doesn't hide
753 spacers, since that would make the waterfall weirdly compressed.
755 * buildbot/status/web/waterfall.py (HELP): put the View button in
756 its own section, so it doesn't get visually confused with the
758 (WaterfallStatusResource.body): make the '[help]' links more
759 visually distinct from each other, and add a link to the Welcome
761 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
762 unused buildslaves without exploding
764 * buildbot/status/web/waterfall.py
765 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
766 it gives us absolute paths that break proxies
767 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
768 this, it was giving bad results when the Waterfall is behind a
771 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
772 new 'upgrade-master' command, which will bring an old buildmaster
773 directory up-to-date. Right now the only thing it does is populate
774 public_html/ if it wasn't already there. Still to do: check the
775 other files, add documentation.
776 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
777 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
779 2007-08-13 Brian Warner <warner@lothar.com>
781 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
782 that contains the checkin comments when you hover over the entry
783 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
786 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
789 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
790 page with versions of python, buildbot, and twisted
791 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
792 * buildbot/status/web/index.html: add links to most pages
793 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
795 * buildbot/status/web/robots.txt: put a robots.txt in new installs
796 which discourages robot access to all large dynamically-generated
797 pages. The intention is that the index page and the 'about' page
798 are the only ones which should be crawlable.
799 * buildbot/scripts/runner.py (Maker.public_html): same
801 * setup.py: ship index.html and robots.txt in source distributions
803 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
804 activate automatic reloading of the page (using a meta Refresh:
806 (WaterfallHelp): new page to explain all the nifty query arguments
807 you can use on the Waterfall, along with forms to set them for
808 you. From this page, you can add filters for builder=, branch=,
809 show_events=, as well as turning on reload=.
810 (WaterfallStatusResource.buildGrid): new query args: last_time=,
811 first_time=, show_time=, num_events= . The old show= is still
812 accepted, but the new builder= is preferred. We ignore empty
813 branch= arguments, to make the WaterfallHelp form easier to
815 (WaterfallStatusResource.head): new method to add text to the
817 * buildbot/status/web/base.py (HtmlResource.content): use head()
818 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
819 empty branch= arguments
820 (OneLinePerBuildOneBuilder.body): same
822 2007-08-12 Brian Warner <warner@lothar.com>
824 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
825 new query args: 'last_time' is a timestamp of the top-most event
826 on the display, 'first_time' is a timestamp for the bottom-most
827 event. 'show_time' is the difference between them, and overrides
828 'first_time'. 'num_events' puts an upper limit on the number of
829 timestamps that will be displayed on the left hand edge.
830 (WaterfallStatusResource.body): add a 'next page' link to the
831 bottom, which shows the events that come just after those shown on
832 the current page. This is a first step towards #67, but we need
833 some more controls before we can close that one.
835 * buildbot/buildslave.py (BuildSlave): these are now MultiService
836 instances too, and live as children of the BotMaster. The main
837 advantage of this approach is that BuildSlaves can know when they
838 are being removed (so they can shut off the upcoming
839 when-do-we-email-an-admin-because-we-lost-our-slave timer).
840 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
841 identify which service children are BuildSlaves
842 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
843 Checker updates here, but delegate the rest to..
844 (BotMaster.loadConfig_Slaves): .. here, which looks at the
845 BotMaster's service children to identify the old slaves. I think
846 the previous approach of using master.slaves was broken in the
847 face of config updates that modified BuildSlave instances but did
848 not completely replace them.
849 * docs/buildbot.texinfo (Developer's Appendix): note the change to
850 the Service hierarchy
852 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
853 page (at URL /buildslaves/) to view status of all buildslaves at
854 once, including how long it's been since we last heard from them,
855 and which Builders use them.
857 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
860 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
863 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
864 use the BuildSlave to keep track of the last time we've heard from
865 the buildslave. This is updated upon receipt of any message from
866 any SlaveBuilder (which generally means when RemoteCommands are
867 giving us status updates, as BuildSteps run). In the future this
868 will include slave pings too.
869 * buildbot/process/base.py
870 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
871 * buildbot/process/buildstep.py:
872 (BuildStep.setBuildSlave): accept that reference
873 (BuildStep.runCommand): pass the reference on to the RemoteCommand
874 (RemoteCommand.remote_update): update the timestamp
875 (RemoteCommand.remote_complete): same
876 * buildbot/test/runutils.py (StepTester.makeStep): match the change
877 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
878 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
879 interface to retrieve this timestamp
880 * buildbot/status/builder.py (SlaveStatus): track a copy of the
884 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
886 (OneLinePerBuild.body): use a <ul> instead of <div>s
887 (OneLinePerBuildOneBuilder.body): same
889 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
890 by adding the file's new name to the list of changed files. This
891 ought to be sufficient for things like isFileImportant and trial
892 tests that only exercise tests for files that have been modified.
895 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
896 XMLRPC server to the WebStatus page. This only has two methods
897 right now (getAllBuildsInInterval and getBuild), but we'll be
898 adding more in the future. This server is extracted from the
901 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
902 generateFinishedBuilds, and improve the data displayed.
903 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
904 the per-Build page, add some information like ETA and got_revision
905 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
906 adding a list of recently completed builds
907 * buildbot/status/web/base.py (css_classes): factor this out
909 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
910 new method, to make status display classes easier to write,
911 especially the WebStatus 'one_line_per_build' page.
912 (IBuilderStatus.generateFinishedBuilds): same
913 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
914 (Status.generateFinishedBuilds): implement it
916 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
917 'source' to be a BuildStep instance, since BuildFactory accepts
919 (CPAN.__init__): same
920 (Distutils.__init__): same
921 (Trial.__init__): same
923 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
924 this might raise KeyError
926 2007-08-07 Brian Warner <warner@lothar.com>
928 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
929 'Owner:' field of the view, rather than 'p4logname', since
930 p4logname comes from the buildslave's environment and seems
931 unlikely to ever do the right thing. Thanks to Wade Brainerd for
932 the patch. Closes #40.
934 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
935 which imposes a per-slave limit on how many builds are allowed to
936 run simultaneously. This has a the same scope than the SlaveLock,
937 but is different because max_builds= gives the buildmaster the
938 freedom to assign the build to a different slave, whereas the
939 SlaveLock doesn't get tested until after the build is irrevocably
940 assigned to a slave. Therefore using max_builds= will improve
941 utilization in the presence of multiple buildslaves that are
942 attached to the same Builder. This completes the incorporation of
943 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
944 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
945 any Builder finishes, potentially trigger *all* Builders, since
946 max_builds= may have stalled someone else while waiting for the
948 * buildbot/scripts/sample.cfg: mention max_builds=
949 * buildbot/test/test_run.py (ConcurrencyLimit): test it
950 * docs/buildbot.texinfo (Buildslave Specifiers): document it
952 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
953 inherit from RunMixin do not need to call master.stopService()
954 themselves, since RunMixin.tearDown does that. The double call
955 fails on Twisted-2.0.x, which didn't happen to protect against it.
956 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
958 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
959 from #48, this one to have the BuildSlave objects track
960 SlaveBuilders, so they'll be able to use that knowledge to
961 influence their canStartBuild() response.
962 * buildbot/process/builder.py (SlaveBuilder.attached): call it
963 (SlaveBuilder.detached): same
964 * buildbot/test/test_slaves.py (BuildSlave): test it
966 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
967 the second of Dustin's #48 patches, this one adding a method to
968 the BuildSlave that allows it to decide whether it is willing to
969 participate in a build or not.
970 (SlaveBuilder.isAvailable): use canStartBuild() to decide
972 * buildbot/test/test_run.py (CanStartBuild): test for it
974 * all: incorporate the first of four patches by Dustin Mitchell
975 from ticket #48, working towards improving control over slave
976 concurrency. The first patch is to use a long-lived BuildSlave
977 object per slave, on which other behavior can be added later. I've
978 modified his patch considerably.
979 * buildbot/buildslave.py (BuildSlave): move class out of
980 slave/__init__.py (where it would get loaded by the slave as well
981 as the master, making dependencies trickier), and merge it with
982 BotPerspective. Now these BuildSlave instances are created once in
983 the master.cfg file, and not destroyed until they are either
984 removed from the config file or changed so
985 much (name/password/class changes) that we cannot continue to use
986 the old one. This affects config files: they must use
987 'from buildbot.buildslave import BuildSlave' instead of using
988 'from buildbot.slave import BuildSlave'.
989 * buildbot/master.py: move BotPerspective out
990 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
991 add or remove as necessary, update the rest using data from
993 * buildbot/slave/__init__.py: move BuildSlave out
994 * buildbot/test/test*.py: import BuildSlave from the new place
995 * buildbot/scripts/sample.cfg: update to match
996 * docs/buildbot.texinfo: update to match
997 * buildbot/process/builder.py: update comments to match
999 2007-08-02 Brian Warner <warner@lothar.com>
1001 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
1002 one-line-per-build pages a bit, add a header, refactor slightly
1004 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
1005 the TimeOutError timer, patch by Dustin Mitchell.
1007 2007-08-01 Brian Warner <warner@lothar.com>
1009 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
1010 mostly work (branch= is still ignored, we need a useful header)
1011 (OneLinePerBuildOneBuilder.body): this too
1013 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
1014 bring this up-to-date w.r.t. recent refactorings, and fix
1015 redirections to bounce the browser to the top page after hitting
1016 the 'force' button. This needs to be improved, but at least it now
1017 redirects to a valid page.
1018 (StatusResourceBuilder.ping): same
1019 (StatusResourceBuilder.getChild): same, although I think this code
1020 might be dead anyways
1022 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
1023 a branch= query argument, to filter the display down to builds and
1024 changes that involve the given branch. You can add multiple
1025 branch= arguments to see multiple branches (using a logical OR).
1026 Note that there is no way to include the default branch (i.e.
1027 None, i.e. trunk) yet, there is still work to be done to allow for
1028 simple+uniform names of branches (i.e. removing the VC-specific
1029 details of how branches are implemented, so calling the branch
1030 'beta4' even though the SVN checkout step requires
1032 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
1033 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
1034 * buildbot/interfaces.py (IEventSource.eventGenerator): same
1035 * docs/buildbot.texinfo (Buildbot Web Resources): document it
1037 * all: bring import statements up-to-date: don't import
1038 __future__, assume cPickle and cStringIO are always available.
1039 Also remove #!/usr/bin/python lines from non-scripts, my editor
1040 has been a bit over-enthusiastic about stuffing them into new .py
1043 * buildbot/status/web/index.html: put a link to the waterfall page
1044 on the index, otherwise first-time users of WebStatus aren't going
1045 to see anything very interesting.
1047 * buildbot/interfaces.py (IEventSource): document this interface.
1048 Thanks to Dustin Mitchell for the patch. Closes #60.
1049 * buildbot/status/builder.py (BuilderStatus): same
1050 * buildbot/changes/changes.py (ChangeMaster): same
1052 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
1053 add a query arg of 'show_events=true' to display non-build events,
1054 like slaves attaching/detaching and reconfig events, or
1055 'show_events=false' to hide them. The default is 'true'.
1056 * docs/buildbot.texinfo (Buildbot Web Resources): document it
1058 * web-parts: merge in web-parts branch. Lots of changes. The new
1059 functionality is to add buildbot.status.html.WebStatus, which is a
1060 superset of the Waterfall that adds new status pages and serves
1061 regular files from BASEDIR/public_html/ , which is now the preferred
1062 place to put robots.txt, buildbot.css, and index.html .
1063 * buildbot/scripts/runner.py: the 'create-master' command now
1064 creates public_html/ too, and populates it with a couple of
1066 * buildbot/status/web: split waterfall code into smaller pieces
1068 2007-07-31 Brian Warner <warner@lothar.com>
1070 * buildbot/scripts/startup.py (launch): import twistd.run in a
1071 different way to hush pyflakes
1072 * buildbot/process/builder.py: remove unused import
1074 2007-07-30 Brian Warner <warner@lothar.com>
1076 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
1077 Mitchell: pass SourceStamps around rather than branch/version/etc
1078 tuples. Thanks Dustin! Closes #70.
1079 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
1080 tuple rather than a list, to avoid surprising mutations
1081 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1082 * buildbot/status/mail.py (MailNotifier.buildMessage): same
1083 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
1084 * buildbot/test/test_status.py (Subscription): same
1085 * buildbot/test/test_control.py (Force): same
1086 * buildbot/test/test_buildreq.py (Request.testMerge): same
1088 2007-07-29 Brian Warner <warner@lothar.com>
1090 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
1091 variable, since it wasn't used and is confusing in the presence of
1092 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
1095 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
1096 the Buildbot home-page link to point at buildbot.net instead of
1097 sourceforge, and add a current-version query parameter so we can
1098 get some statistics on which versions are in use out there.
1100 2007-07-28 Brian Warner <warner@lothar.com>
1102 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
1103 with c['change_source'], leaving c['sources'] for backwards
1104 compatibility (but deprecated), scheduled for removal in 0.8.0
1105 * docs/buildbot.texinfo: same
1106 * buildbot/test/test_config.py: verify that c['sources'] still works
1107 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
1108 * buildbot/scripts/sample.cfg: update to match
1110 * buildbot/changes/mail.py (MaildirSource): parse with python's
1111 stdlib 'email' module, which has been available since python2.2,
1112 and drop use of the 'rfc822' module, which has been depreceated
1114 * buildbot/test/test_maildir.py: same: use parse_file() not parse
1116 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
1117 this needs to match the renaming in test/mail/msg*
1119 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
1122 * buildbot/test/test_mailparse.py: rename sample emails a bit
1123 * buildbot/test/mail/msg*: same
1125 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
1126 parser for the "commit-email.pl" script that is shipped with SVN,
1127 written by Justin Mason. Thanks! Closes SF#1072845.
1128 * buildbot/test/mail/svn-commit.*: sample messages
1129 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
1130 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
1132 2007-07-27 Brian Warner <warner@lothar.com>
1134 * buildbot/changes/mail.py: refactor: move parsing into a method
1135 named 'parse', each parser type gets a separate subclass. Remove
1136 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
1137 to be a simple leading-substring match. Add a warning to the logs
1138 if prefix= does not end in a slash, since that's probably a
1139 mistake. Fix both places where a prefix= mismatch would skip all
1140 subsequent files in the same email, instead of just skipping the
1141 one that didn't match.
1142 * buildbot/test/test_mailparse.py: match changes
1144 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
1145 docs on email-based ChangeSources
1147 * docs/buildbot.texinfo (Getting Source Code Changes): move all
1148 the changesource types up a level, removing the one-entry menu in
1151 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
1152 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
1153 instances instead of tuples. Closes #63.
1154 * buildbot/slave/__init__.py (BuildSlave): define marker class
1155 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
1156 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
1157 * buildbot/test/test_*.py: update tests to match
1158 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
1159 the c['bots'] backwards-compatibility handler works
1161 2007-07-26 Brian Warner <warner@lothar.com>
1163 * buildbot/changes/hgbuildbot.py (hook): add an in-process
1164 Mercurial change-sending hook, contributed by Frederic Leroy.
1165 Thanks! Addresses #50.
1166 * docs/buildbot.texinfo (MercurialHook): document it
1168 * buildbot/changes/hgbuildbot.py: change the way imports are done,
1169 to make it compatible with at least hg-0.9.1 and the current 0.9.4
1171 2007-07-17 Brian Warner <warner@lothar.com>
1173 * buildbot/process/buildstep.py (BuildStep.getLog): add a
1174 convenience method to retrieve a log added with
1175 addLog()/addCompleteLog()/etc or logfiles= . I should have added
1176 this two years ago..
1178 2007-07-03 Brian Warner <warner@lothar.com>
1180 * buildbot/slave/commands.py (ShellCommand._startCommand): when
1181 logging the environment variables, put one variable on each line,
1182 rather than having one really long line with all of them. This
1183 should make them a bit more readable and not trigger the
1184 horizontal scrollbar (when viewing it in a web browser) quite so
1185 much. Thanks to Albert Hofkamp for the patch.
1187 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
1188 WithProperties instance. Thanks to Axel Hecht for the patch.
1190 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
1191 * docs/buildbot.texinfo (Build Properties): document it
1192 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
1193 workdir if it didn't already exist.
1195 * docs/buildbot.texinfo (Scheduler Types): correct the description
1196 of Dependent schedulers. Thanks to Greg Ward for the patch.
1198 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
1199 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
1200 the patch. Closes #49.
1202 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
1203 0700 before removing it, to deal with situations where a build will
1204 leave files around without write permissions and the 'copy' or
1205 'clobber' VC checkout modes need to blow away the tree first.
1206 Thanks to Steve Milner for the suggestion and the patch (which I
1207 mangled horribly). Closes #29.
1208 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
1211 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
1212 an allowReconnect= argument to let callers control whether they
1213 want this don't-let-it-reconnect behavior, since some tests care.
1214 Factor out the .continueTrying=False lines from those callers.
1215 * buildbot/test/test_slaves.py: same
1216 * buildbot/test/test_run.py: same
1218 2007-07-02 Brian Warner <warner@lothar.com>
1220 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
1221 slave has been disappeared, don't let it reconnect. This was
1222 causing an intermittent failure in test_slaves.py, when the slave
1223 that was supposed to be gone managed to come back by the end of
1224 the test and affect the count.
1225 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
1227 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
1228 diagnostic messages to track down this problem
1229 (Builder.startBuild): same
1231 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
1232 the slave randomly rather than always taking the first one. Thanks
1233 to Pike for the patch. Closes #36.
1234 * buildbot/test/test_slaves.py: match the change. to avoid huge
1235 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
1236 enables/disables the round-robin-ness (enabled by default), and
1237 some unit tests disable it.
1238 * docs/buildbot.texinfo (Buildmaster Architecture): document it
1240 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
1241 argument to 'buildmaster_host', to make it more obvious that this
1242 points to the buildmaster. Thanks to Bob Proulx for the
1244 * buildbot/scripts/runner.py (slaveTAC): same
1245 * buildbot/test/test_runner.py (Create.testSlave): match the change
1247 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
1250 2007-06-17 Brian Warner <warner@lothar.com>
1252 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
1253 we can round-trip all of our current step classes by calling
1254 getStepFactory() and using the results to make a clone of the
1257 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
1260 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
1261 the config file, we're moving to using actual instances instead of
1262 the (class, kwargs) 'step specification' tuples. BuildFactory
1263 still keeps a list of tuples internally, but when real instances
1264 are passed in to addStep(), they are asked for their class and
1265 kwargs using the new BuildStep.getStepFactory method. BuildFactory
1266 accepts both instances and the tuple form, and converts instances
1267 to the tuple form, but the instance form is preferred because it
1268 gives the Steps a chance to do argument validation. Closes: #11.
1270 * buildbot/process/buildstep.py (BuildStep.__init__): record the
1271 factory information necessary to implement getStepFactory. The
1272 addFactoryArguments() method can be used to include arguments that
1273 aren't passed to the BuildStep base class constructor.
1274 (BuildStep.setBuild):
1275 (BuildStep.setDefaultWorkdir): new methods to take parameters that
1276 are needed for live BuildSteps but not to construct the specification
1277 tuples that are stashed in the factory.
1279 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
1280 'workdir' into new BuildSteps by using methods instead of
1281 arguments. This makes the constructor for BuildSteps a lot
1284 * buildbot/steps/*.py: update to match this change. Basically this
1285 means adding calls to addFactoryArguments() in the __init__
1286 methods to capture the arguments that aren't passed through to the
1288 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
1289 the new workdir (if any) into the RemoteShellCommands arguments.
1290 * buildbot/steps/source.py: allow workdir= to be optional,
1291 implement setDefaultWorkdir() since we don't inherit from
1292 (CVS): finally remove old clobber=/export=/copydir= arguments,
1293 in favor of the mode= argument that's been around forever now.
1294 * buildbot/steps/transfer.py: remove build= argument
1296 * buildbot/test/*.py: update to match, generally by turning all
1297 build= arguments into subsequent calls to s.setBuild()
1298 * buildbot/test/test_config.py (Factories): verify that we can
1299 use either BuildStep instances or class/kwarg tuples in both
1300 BuildFactory.addStep and BuildFactory.__init__
1302 * docs/buildbot.texinfo (Build Steps): document the new approach,
1303 mention compatibility with the old approach, update all examples
1304 to use the new style.
1306 2007-06-16 Brian Warner <warner@lothar.com>
1308 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
1309 the LoopingCall, just eat the failure so that we'll poll again
1310 next time. This should allow us to tolerate (e.g.) sf.net SVN
1311 failures more gracefully. Many thanks to Dustin Mitchell for the
1314 2007-05-17 Brian Warner <warner@lothar.com>
1316 * buildbot/status/words.py: refactor the IRC status bot into
1317 separate 'Contact' and 'Channel' classes. The base Contact class
1318 contains the interaction code: commands and responses. The
1319 IRCContact subclass (and IrcStatusBot 'Channel') handle the
1320 IRC-specific aspects. The plan is to write other subclasses for
1321 other IM protocols like AIM and Jabber.
1323 2007-04-16 Brian Warner <warner@lothar.com>
1325 * CREDITS: update list of contributors. Thank you all!
1327 2007-04-13 Brian Warner <warner@lothar.com>
1329 * buildbot/status/mail.py (MailNotifier): add the project name to
1330 the subject line and message body, to make it easier to
1331 distinguish email coming from different buildmasters. Thanks to
1332 Benoit Sigoure for the patch.
1333 * buildbot/test/test_status.py (Mail): update to match
1335 2007-03-24 Brian Warner <warner@lothar.com>
1337 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
1338 avoid text-conversion problems between DOS/windows and unix.
1339 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
1341 2007-03-03 Brian Warner <warner@lothar.com>
1343 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
1344 warning about the use of Waterfall here
1346 2007-03-01 Brian Warner <warner@lothar.com>
1348 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
1350 2007-02-28 Brian Warner <warner@lothar.com>
1352 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
1353 Lamb to use a more optimal form of 'p4 changes', to reduce server
1354 load. He reports that this optimization was added to p4d release
1355 2005.2, but it should work in all versions. Closes #27.
1356 * buildbot/test/test_p4poller.py: match it
1358 2007-02-27 Brian Warner <warner@lothar.com>
1360 * buildbot/status/web/*.py: move all web status stuff into a
1361 separate directory, in anticipation of splitting it into smaller
1362 pieces and adding more files. html.py was getting way too big.
1363 * buildbot/status/classic.css: move it too
1364 * setup.py: add the new sub-package
1365 * buildbot/test/test_web.py: match the changes
1366 * MANIFEST.in: handle the move of classic.css
1368 2007-02-07 Brian Warner <warner@lothar.com>
1370 * contrib/OS-X/*: add some launchd .plist files for automatically
1371 starting a buildmaster or buildslave under OS-X (10.4 or later).
1372 Thanks to Mark Pauley for these.
1374 2007-02-06 Brian Warner <warner@lothar.com>
1376 * docs/buildbot.texinfo (Requirements): update requirements to
1377 stop claiming compatibility with python-2.2 or twisted-1.3.x .
1379 * README: mention python-2.5 and twisted-2.5 compatibility
1381 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
1383 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
1385 * buildbot/status/builder.py: same, by requiring cStringIO
1386 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
1387 * buildbot/test/test_vc.py: same
1388 * buildbot/test/test_web.py:
1389 * buildbot/test/test_steps.py: same, remove unused import
1391 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
1394 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
1395 see any Builders that don't have Schedulers to drive them
1397 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
1398 attributes this uses went away
1400 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
1401 dialog, to allow you to reset the buildmaster and force
1402 connect/disconnect. Correctly handle losing the buildmaster
1403 connection (by switching the display to the hexnut, at which point
1404 you can use the 'Connect' menu item to reconnect).
1406 * buildbot/steps/source.py (Source.start): if we're using a patch,
1407 add it as a LogFile to the checkout/update step. This will turn
1408 into a link on the waterfall page.
1410 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
1411 option, to take the patch from a pre-made file rather than
1412 generating it from the local tree. Thanks to Robert Helmer for the
1413 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
1414 * buildbot/scripts/runner.py (TryOptions): add --diff,
1415 --patchlevel, and --baserev options
1416 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
1417 as None, meaning HEAD.
1418 * buildbot/sourcestamp.py (SourceStamp): update docstring to
1419 indicate that baserev=None means HEAD
1420 * docs/buildbot.texinfo (try --diff): document it
1422 * buildbot/test/test_steps.py (BuildStep): remove use of
1423 reactor.iterate(), although the technique I replaced it with is a
1424 gross polling hack that must be cleaned up properly some day. This
1425 was the last use of reactor.iterate in the entire tree, yay.
1427 2007-02-05 Brian Warner <warner@lothar.com>
1429 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
1430 is one of the three known values, otherwise we emit some confusing
1431 messages later on. Thanks to Grig Gheorghiu for the catch.
1433 2007-01-30 Brian Warner <warner@lothar.com>
1435 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
1436 Hearsum contributed a patch to let BonsaiPoller work with results
1437 that contain non-ascii characters. Closes SF#1632641.
1439 2007-01-27 Brian Warner <warner@lothar.com>
1441 * Makefile (release): produce both .tar.gz and .zip source bundles.
1444 2007-01-23 Brian Warner <warner@lothar.com>
1446 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
1447 * buildbot/changes/monotone.py: same
1449 * buildbot/changes/maildir.py: combine several files into one,
1450 clean up maildir.py to use Services properly.
1451 * buildbot/changes/maildirtwisted.py: remove
1452 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
1454 * buildbot/changes/mail.py: match the change
1455 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
1456 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
1458 * buildbot/slave/commands.py (command_version): bump to "2.3" to
1459 indicate that the buildslave knows about the 'bzr' command
1461 2007-01-22 Brian Warner <warner@lothar.com>
1463 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
1464 'with', it will become a reserved work in python2.6 .
1466 * contrib/bb_applet.py: add a simple gnome-panel applet, to
1467 display a terse summary of buildbot status.
1468 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
1469 some icons, small versions of the Blender object that lives in
1470 docs/images/icon.blend
1472 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
1473 * buildbot/slave/commands.py (Bzr): same
1474 * buildbot/scripts/tryclient.py (BzrExtractor): same
1475 (SourceStampExtractor.dovc): modify this to allow non-zero exit
1476 status, since 'bzr diff' does that
1477 * buildbot/test/test_vc.py (Bzr): same
1478 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1482 2007-01-20 Brian Warner <warner@lothar.com>
1484 * contrib/darcs_buildbot.py: tidy up the progress messages
1486 2007-01-17 Brian Warner <warner@lothar.com>
1488 * contrib/darcs_buildbot.py: enhance to handle multiple patches
1489 being pushed at a time. This keeps state in the repository in a
1490 small file named .darcs_buildbot-lastchange, but that shouldn't
1491 interfere with normal repository operations. Fixes SF#1534049.
1492 * buildbot/clients/sendchange.py (Sender): make a single Sender
1493 capable of sending Changes with different usernames.
1495 2006-12-11 Brian Warner <warner@lothar.com>
1497 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
1498 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
1499 buildbot.changes.mail a long time ago, but I forgot to add the
1500 DeprecationWarning until now.
1502 * buildbot/process/maxq.py: remove this, the functionality now
1503 lives in buildbot.steps.maxq
1505 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1506 * buildbot/clients/gtkPanes.py: remove unused import
1508 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1509 that was meant to provide a special Reporter to run inside trial
1510 and give the buildslave lots of machine-readable status. We never
1511 finished this project.
1513 * buildbot/changes/bonsaipoller.py: remove unused imports
1514 * buildbot/changes/svnpoller.py: same
1515 * buildbot/process/builder.py: same
1516 * buildbot/process/buildstep.py: same
1517 * buildbot/slave/bot.py: hush pyflakes warning
1518 * buildbot/status/tests.py: remove unused imports
1519 * buildbot/status/tinderbox.py: same
1520 * buildbot/steps/python_twisted.py: same
1522 * buildbot/process/step.py: remove this file, these names were
1523 deprecated in 0.7.5 and are now being removed.
1524 * buildbot/process/step_twisted.py: same
1525 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1527 * buildbot/twcompat.py: remove the empty file, yay it is gone
1529 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1530 tw-2.0.0 and newer have the method we need.
1531 (getProcessOutputAndValue): same
1532 (which): remove this method, tw-2.0.0 t.p.procutils has it
1534 * buildbot/twcompat.py (implements): remove this method
1535 * buildbot/*: import implements() from zope.interface directly
1537 * buildbot/status/mail.py: stop falling back to importing
1538 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1541 * buildbot/twcompat.py (Interface): remove this import
1542 * buildbot/*: import Interface from zope.interface directly
1544 * buildbot/twcompat.py (providedBy): remove this method
1545 * buildbot/*: turn all uses of providedBy(obj, iface) into
1546 iface.providedBy(obj)
1548 * buildbot/twcompat.py (maybeWait): remove this method, now that
1549 we no longer maintain compatibility with Twisted<=1.3.0 .
1550 Twisted-2.0.0 and later allow trial methods to return Deferreds
1552 * buildbot/test/*: remove all uses of maybeWait
1554 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1556 * docs/buildbot.texinfo: same
1558 2006-12-10 Brian Warner <warner@lothar.com>
1560 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1561 * docs/buildbot.texinfo: set version to match
1563 2006-12-10 Brian Warner <warner@lothar.com>
1565 * README (REQUIREMENTS): update for release
1566 * NEWS: update for release
1567 * buildbot/slave/commands.py (command_version): mention that this
1568 version (2.2) was released with buildbot-0.7.5
1570 * buildbot/test/test_config.py (StartService.testStartService):
1571 inhibit the usual read-config-on-startup behavior, since otherwise
1572 the log.err that gets recorded causes the test to fail
1574 * buildbot/status/builder.py (LogFile.finish): forget about all
1575 subscribers once the log has finished, since after that point
1576 we're never going to use them again. This might help free up some
1579 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1580 than the old/deprecated gtk.mainquit()
1582 2006-12-09 Brian Warner <warner@lothar.com>
1584 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1585 better when we can't open the masterdst file
1587 * buildbot/scripts/startup.py (Follower._failure): add missing
1588 import statement for BuildSlaveDetectedError
1590 * buildbot/steps/transfer.py (FileUpload): cleanup
1591 (FileDownload): same. Add tests for slave version, add mode=.
1592 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1593 (SlaveFileDownloadCommand): same
1594 * buildbot/test/test_transfer.py: enhance tests
1595 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1598 2006-12-08 Brian Warner <warner@lothar.com>
1600 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1601 both success *and* failure. Without this, the 'buildbot
1602 sendchange' command would hang if it could not contact the
1603 buildmaster or deliver the Change, which would generally cause the
1604 user's commit/record/checkin command to hang too. Thanks to
1605 Christian Unger for the catch.
1607 2006-12-06 Brian Warner <warner@lothar.com>
1609 * NEWS: update with items for the next release
1611 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1612 whimsical example pulled from a punch-drunk email I sent out late
1614 (Transferring Files): document some of the other parameters
1615 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1616 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1617 * buildbot/test/test_svnpoller.py: same
1618 * buildbot/changes/svnpoller.py (SVNPoller): same
1620 2006-11-26 Brian Warner <warner@lothar.com>
1622 * docs/buildbot.texinfo (Build Properties): remind users that
1623 WithProperties must appear in a command= list, not as a top-level
1625 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1626 we're sending a list or a single string to the RemoteShellCommand
1628 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1630 * buildbot/scripts/startup.py (start): skip the whole
1631 watch-the-logfile thing under windows, since it needs os.fork()
1633 * buildbot/scripts/runner.py (restart): remove the old message
1634 that got printed after the buildbot was restarted.. it most cases
1635 it didn't get printed at the right time anyways
1637 2006-11-25 Brian Warner <warner@lothar.com>
1639 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1640 follow twistd.log and print lines until the process has started
1641 started properly. For the buildmaster, this means until the config
1642 file has been parsed and accepted. For the buildslave, this means
1643 until we've connected to the master. We give up after 5 seconds in
1644 any case. Helpful error messages and troubleshooting suggestions
1645 are printed when we don't see a successful startup. This closes the
1646 remainder of SF#1517975.
1647 * buildbot/scripts/startup.py: moved app startup code to here
1648 * buildbot/scripts/logwatcher.py: utility class to follow log
1649 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1650 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1651 so the LogWatcher can tell the difference between a buildmaster
1654 2006-11-24 Brian Warner <warner@lothar.com>
1656 * docs/examples/twisted_master.cfg: update to match the version
1657 in use on twistedmatrix.com
1658 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1659 was using before stopped working, but 'irc.freenode.net' works
1662 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1665 * buildbot/clients/base.py (TextClient.not_connected): upon
1666 UnauthorizedLogin failures, remind the user to connect to the
1667 PBListener port instead of the slaveport.
1668 (TextClient.disconnected): shut down more quietly
1669 * docs/buildbot.texinfo (statuslog): add another reminder
1671 * buildbot/scripts/runner.py (Options.subCommands): rename
1672 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1673 'sighup' as an alias.
1674 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1675 reconfig command to follow twistd.log and print all of the lines
1676 from the start of the config-file reload to its completion. This
1677 should make it a lot easier to discover bugs in the config file.
1678 Use --quiet to disable this behavior. This addresses half of
1679 SF#1517975, the other half will be to add this same utility to
1680 'buildbot start' and 'buildbot restart'.
1681 * docs/buildbot.texinfo (Loading the Config File): same
1684 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1685 method, it has been deprecated for a long time. Use
1686 IBuilderControl.requestBuild instead.
1687 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1688 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1689 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1690 * buildbot/test/test_control.py (Force.testForce): same
1691 * buildbot/test/test_run.py: use requestBuild instead
1693 * buildbot/clients/debug.py: replace 'Force Build' button with
1694 'Request Build' (which just adds one to the queue), add Ping
1695 Builder, add branch/revision fields to Request Build.
1696 * buildbot/clients/debug.glade: same
1697 * buildbot/master.py: update interface to match. This creates an
1698 incompatibility between new debugclients and old buildmasters.
1700 * buildbot/process/builder.py (Builder._attached): delay the call
1701 to maybeStartBuild for a reactor turn, to avoid starting a build
1702 in the middle of a reconfig (say, if the new Builder uses a new
1703 slave which is already connected).
1705 2006-11-23 Brian Warner <warner@lothar.com>
1707 * buildbot/test/test_transfer.py: appease pyflakes
1708 * buildbot/test/test_steps.py: same
1710 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1711 keeps pyflakes from finding undefined names
1713 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1714 Builder no longer induces a disconnect/reconnect cycle. This means
1715 that any builds currently in progress will not be interrupted, and
1716 any builds which are queued in the Builder will not be lost. This
1717 is implemented by having the new Builder extract the state (i.e.
1718 all pending Builds and any desired SlaveBuilders) from the old
1720 (BotPerspective): refactor. The BotPerspective no longer keeps
1721 track of all the Builders that want to use this slave; instead, it
1722 asks the BotMaster each time it needs this list. This removes
1723 addBuilder and removeBuilder. Clean up attached() to acquire all
1724 the slave's information in a more atomic fashion. updateSlave() is
1725 now the way to make sure the slave is using the right set of
1726 Builders: just call it after everything else has been
1728 (BotMaster): refactor, removing addBuilder/removeBuilder and
1729 replacing them with an all-at-once setBuilders() call.
1731 * buildbot/test/test_slaves.py (Reconfig): new test case to
1732 exercise this functionality
1733 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1734 * buildbot/slave/commands.py (WaitCommand): same
1736 * docs/buildbot.texinfo (Loading the Config File): document the
1739 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1740 SlaveBuilder to have its parent Builder changed.
1741 (SlaveBuilder.isAvailable): new method to give access to state,
1742 which is now a private attribute
1743 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1744 the SlaveBuilder about how it is being used. These methods update
1745 its internal state. buildFinished() is now the place that invokes
1746 maybeStartBuild() on its parent Builder.
1747 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1748 new Builder to take over for an old one, transferring state from
1750 (Buider): refactor the way that SlaveBuilders are used to match,
1751 giving them a bit more autonomy.
1752 (Builder.buildFinished): this no longer calls maybeStartBuild():
1753 instead the SlaveBuilder calls it on whoever its parent Builder is
1754 at the time. This way, when an old Builder is replaced by a new
1755 one, and there was a build in progress during the transition, when
1756 that build finishes, it will be the new Builder that is told about
1757 the newly available slave so it can start a new build.
1759 * buildbot/process/base.py (Build.startBuild._release_slave): when
1760 the Build finishes, tell the SlaveBuilder that they've been
1763 * buildbot/status/builder.py (SlaveStatus): add some new setter
1764 methods for use by BotPerspective, to keep some attributes more
1767 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1768 called by the buildmaster.
1769 (Bot.setBuilderList): instead, we locally announce any leftover
1770 directories based upon which Builders we were told about. The
1771 master doesn't really care; it's the local admin who may or may not
1772 wish to delete them.
1775 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1776 to allow use of python2.4 or whatever. This tool still requires
1779 2006-11-19 Brian Warner <warner@lothar.com>
1781 * NEWS (IStatusLog.readlines): more news items
1783 2006-11-18 Brian Warner <warner@lothar.com>
1785 * NEWS: start collecting items for the next release.
1787 2006-11-04 Brian Warner <warner@lothar.com>
1789 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1790 Hearsum. Closes SF#1590310.
1791 * buildbot/test/test_bonsaipoller.py: and tests
1793 * buildbot/status/tinderbox.py
1794 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1795 status when the build results in WARNINGS. Patch from Dave
1796 Liebreich. Closes SF#1587352.
1798 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1799 linux-vs-osx behavior difference w.r.t. reading from files that
1800 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1801 to Mark Rowe for the patch.
1803 2006-10-15 Brian Warner <warner@lothar.com>
1805 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1806 method name was misspelled in the interface definition. Thanks to
1807 Roy Rapoport for the catch.
1809 2006-10-13 Brian Warner <warner@lothar.com>
1811 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1812 to match the great Steps renaming
1814 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1815 Maybe I should run my own unit tests before recording a big
1816 change. Good thing I've got a buildbot to remind me.
1818 2006-10-12 Brian Warner <warner@lothar.com>
1820 * buildbot/steps/transfer.py: rework __init__ and args setup
1821 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1823 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1824 when opening the target file, only catch IOError (to report via
1825 stderr/rc!=0), let the others be reported as normal exceptions
1827 2006-10-08 Brian Warner <warner@lothar.com>
1829 * contrib/svn_watcher.py: fix security holes by using proper argv
1830 arrays and subprocess.Popen() rather than commands.getoutput().
1831 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1832 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1833 probably be removed by the next release.
1836 2006-10-04 Brian Warner <warner@lothar.com>
1838 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1839 initial lines that weren't emitted by pyflakes. When the pyflakes
1840 command is run under a Makefile, 'make' will echo the command it
1841 runs to stdio, and that was getting logged as a "misc" warning.
1842 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1843 * buildbot/test/test_steps.py (testPyFlakes3): another test
1845 2006-10-01 Brian Warner <warner@lothar.com>
1847 * buildbot/status/html.py (HtmlResource.render): if we get a
1848 unicode object from our content() method, encode it into utf-8
1849 like we've been claiming to all along. This allows the comments
1850 and author names from svnpoller.py to be delivered properly.
1852 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1853 de-unicodify filenames before creating the Change, because the
1854 rest of buildbot is unlikely to handle them well. Leave the 'who'
1855 field as a unicode object.. I don't think there's anything that
1856 will break very soon, and it will probably nudge us towards
1857 accepting unicode everywhere sooner or later. Stop using the
1858 "date" field that comes out of SVN, since it is using the
1859 repository's clock (and timezone) and what we care about is the
1860 buildmaster's (otherwise Changes from the future show up later
1861 than the builds they triggered).
1862 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1865 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1866 Suvbersion repository polling ChangeSource. I've hacked it up
1867 considerably: any bugs are entirely my own fault. Thank you
1869 * buildbot/test/test_svnpoller.py: tests for it
1870 * docs/buildbot.texinfo (SvnSource): document it
1872 2006-09-30 Brian Warner <warner@lothar.com>
1874 * buildbot/scheduler.py (Periodic): submit a reason= to the
1875 BuildSet to indicate which Scheduler triggered the build. Thanks
1876 to Mateusz Loskot for the suggestion.
1878 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1880 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1881 changes: set self.loop in __init__, remove unused volatile=
1883 * docs/buildbot.texinfo (.buildbot config directory): add more
1884 docs on the .buildbot/options keys used by "buildbot try"
1885 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1886 (Try.deliverJob): same
1888 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1890 (BonsaiPoller): same
1892 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1893 close the filehandle when we stop watching the file. Before, the
1894 filehandle was only closed when the LogFileWatcher was
1895 garbage-collected, which could be quite a while in the future. If
1896 it was still open by the time the next build started, windows will
1897 refuse to let the new build delete the old build/ directory. Fixes
1898 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1899 #twisted for the catch.
1901 2006-09-29 Brian Warner <warner@lothar.com>
1903 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1906 2006-09-25 Brian Warner <warner@lothar.com>
1908 * setup.py: the new buildbot.steps module wasn't being installed.
1909 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1910 (testmsgs): add the extra stuff from buildbot/test/* so you can
1911 run unit tests on an installed copy of buildbot, not just from
1914 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1915 columns of 'svnlook changed' output contain status information, so
1916 strip [:4] instead of [:6]. Depending upon what the status flags
1917 were, this would sometimes lead to mangled filenames. Thanks to
1918 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1920 * buildbot/steps/source.py (Monotone): initial Monotone support,
1921 contributed by Nathaniel Smith. Still needs docs and tests, but
1922 this code has been in use on the Monotone buildbot for a long
1924 * buildbot/slave/commands.py (Monotone): slave-side support
1925 * buildbot/changes/monotone.py (MonotoneSource): polling change
1928 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1929 contributed a Change Source that polls a Bonsai server (a
1930 kind of web-based viewcvs CGI script).
1932 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1933 Hearsum contributed a status plugin which sends email in the same
1934 format that Tinderbox does: this allows a number of tinderbox
1935 tools to be driven by Buildbot instead. Thanks Ben!
1937 2006-09-24 Brian Warner <warner@lothar.com>
1939 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1940 Thanks to Robert Helmer for the patch.
1942 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1943 BuildStatus about the buildslave name at the *beginning* of the
1944 build, rather than at the end. Thanks to Alexander Lorenz for the
1946 * buildbot/status/html.py (StatusResourceBuild.body): always
1947 include the slavename in the build page, not just when the build
1949 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1950 slavename in the email message
1952 2006-09-21 Brian Warner <warner@lothar.com>
1954 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1956 * docs/examples/glib_master.cfg: same
1957 * docs/examples/hello.cfg: same
1958 * docs/examples/twisted_master.cfg: same, update to current usage
1960 2006-09-19 Brian Warner <warner@lothar.com>
1962 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1963 (PyFlakes.createSummary): make it compatible with python-2.2
1965 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1966 for at least the output-parsing parts of PyFlakes
1968 2006-09-18 Brian Warner <warner@lothar.com>
1970 * buildbot/steps/python.py: oops, fix import of StringIO
1972 2006-09-17 Brian Warner <warner@lothar.com>
1974 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1975 turns out that SVN-1.4.0 doesn't fail to update once you've
1976 replaced a file with a directory, unlike older versions of SVN and
1977 pretty much every other VC tool we support. Since what we really
1978 care about is that the update succeeds anyway, stop checking that
1979 the tree got clobbered and just assert that the build succeeded.
1980 (VCBase.printLogs): add a utility function for debugging
1982 * buildbot/process/step.py: oops, added extra imports by mistake
1984 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1985 rstrip() on the first line coming out of the 'p4 describe'
1986 process, to remove the stray ^M that Wade Brainerd reports seeing
1987 in the 'when' field. Fixes SF#1555985.
1989 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1990 message logged when c['schedulers'] is not right
1991 * buildbot/scheduler.py (Scheduler.__init__): improve error
1992 message when a Scheduler() is created with the wrong arguments
1993 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1994 verify that these error messages are emitted
1996 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1997 The idea is that all the base classes (like BuildStep and
1998 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1999 will be a leftover backwards-compatibility file that only contains
2000 aliases for the steps that were moved out to buildbot.steps.*
2001 * lots: change imports to match
2002 * buildbot/process/step.py: add a DeprecationWarning if it ever
2005 2006-09-12 Brian Warner <warner@lothar.com>
2007 * buildbot/scheduler.py (Scheduler.__init__): make sure that
2008 builderNames= is actually a sequence, since if you happen to give
2009 it a single builder-specification dictionary instead, it won't get
2010 caught by the existing assert. Thanks to Brett Neely for the
2013 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
2015 * docs/buildbot.texinfo (Python BuildSteps): document them
2016 (sendchange): include a link to PBChangeSource, since you need one
2018 * buildbot/steps/shell.py: clean up test-case-name line, remove some
2020 * buildbot/steps/dummy.py: same
2022 2006-09-08 Brian Warner <warner@lothar.com>
2024 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
2025 BuildStep which lets you transfer files from the master to the
2026 slave or vice versa. Thanks to Albert Hofkamp for the original
2027 patch. Fixes SF#1504631.
2028 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
2030 (SlaveFileDownloadCommand): same
2031 * docs/buildbot.texinfo (Transferring Files): document it
2032 * buildbot/test/test_transfer.py: test it
2033 * buildbot/test/runutils.py (StepTester): new utility class for
2034 testing BuildSteps and RemoteCommands without Builds or Bots or PB
2035 * buildbot/test/test_steps.py (CheckStepTester): validate that the
2038 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
2039 walk through StatusLogs one line at a time, mostly for the benefit
2040 of ShellCommand.createSummary methods. You can either walk through
2041 STDOUT or STDERR, but the default is STDOUT.
2043 * buildbot/status/builder.py (LogFile.readlines): implement it.
2044 Note that this is not yet memory-efficient, it just pulls the
2045 whole file into RAM and then splits it up with a StringIO.
2046 Eventually this should be a generator that only pulls chunks from
2048 * buildbot/test/test_status.py (Log.testReadlines): test it
2050 * docs/buildbot.texinfo: update to match changes
2051 * buildbot/process/factory.py: stop using old definitions
2052 * buildbot/process/process_twisted.py: same
2053 * buildbot/test/test_*.py: same
2055 * buildbot/process/step_twisted.py: move definition to..
2056 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
2057 relative-import mechanisms prevent this from being named 'twisted'
2058 or 'python/twisted' as I would have preferred.
2060 * buildbot/process/maxq.py: move definition to..
2061 * buildbot/steps/maxq.py: .. here, leave a compatibility import
2063 * buildbot/process/step.py: split the user-visible BuildSteps into
2064 separate files, all under buildbot/steps/
2065 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
2066 * buildbot/steps/shell.py: this holds ShellCommand and friends
2067 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
2069 2006-09-05 Brian Warner <warner@lothar.com>
2071 * lots: run pyflakes, removed a lot of unused imports, changed the
2072 form of some conditional imports to remove false pyflakes
2073 warnings. There are still a number of warnings left, mostly from
2074 imports that are done for their side-effects.
2075 * buildbot/test/test_vc.py: import twisted.python.failure, since it
2078 2006-08-26 Brian Warner <warner@lothar.com>
2080 * buildbot/test/test_locks.py (Unit.testLater): make the tests
2081 compatible with twisted-1.3.0, for some reason I just can't seem
2082 to let go of the past.
2084 2006-08-25 Brian Warner <warner@lothar.com>
2086 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
2088 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
2089 all logfiles= in startCommand(), rather than in start() . This
2090 makes it easier to have the 'stdio' log come before any secondary
2091 logfiles, which I feel makes the waterfall display more
2093 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
2094 from ShellCommand up into LoggingBuildStep
2095 (LoggingBuildStep.__init__): move the handling of logfiles= from
2096 ShellCommand up to LoggingBuildStep, because startCommand is
2097 provided by LoggingBuildStep, whereas start() was specific to
2098 subclasses like ShellCommand and Source. This removes code
2099 duplication in those subclasses.
2100 (ShellCommand.__init__): same
2101 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
2102 for a slave that's too old to understand logfiles= into a separate
2103 method, so it can live in ShellCommand. The rest of
2104 setupLogfiles() can live in LoggingBuildStep.
2106 2006-08-24 Brian Warner <warner@lothar.com>
2108 * buildbot/locks.py (BaseLock): you can now configure Locks to
2109 allow multiple simultaneous owners. They still default to
2110 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
2112 * docs/buildbot.texinfo (Interlocks): document the new options
2113 * buildbot/test/test_locks.py: add a bunch of new unit tests
2114 * buildbot/process/base.py (Build.acquireLocks): locks now offer
2115 waitUntilMaybeAvailable, not waitUntilAvailable
2116 * buildbot/process/step.py (BuildStep.acquireLocks): same
2117 * buildbot/master.py (BotMaster.getLockByID): real locks now use
2118 the whole lockid in their constructor, not just the name. Also,
2119 keep track of which real locks we've handed out by the full
2120 lockid, not just class+name, otherwise changing just the maxCount=
2121 in the master.cfg file would not actually cause a behavioral
2124 2006-08-23 Brian Warner <warner@lothar.com>
2126 * buildbot/__init__.py (version): bump to 0.7.4+ while between
2128 * docs/buildbot.texinfo: same
2130 2006-08-23 Brian Warner <warner@lothar.com>
2132 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
2133 * docs/buildbot.texinfo: set version to match
2134 * NEWS: update for 0.7.4
2135 * buildbot/slave/commands.py (command_version): mention that this
2136 version (2.1) was released with buildbot-0.7.4
2138 2006-08-22 Brian Warner <warner@lothar.com>
2142 * CREDITS: new file, list of people who have helped. Thanks!
2143 * MANIFEST.in: ship it
2145 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
2146 new diagrams, the user's manual is more informative than it was.
2147 Start shipping the .html user's manual (and generated .png
2149 * Makefile: update 'release' target to match
2151 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
2152 test.. I think the web-parts effort will render it pointless well
2153 before it ever actually starts to work.
2155 2006-08-20 Brian Warner <warner@lothar.com>
2157 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
2158 meaning of the prefix= argument. It is now just a string which is
2159 stripped from the beginning of the filename. If prefix= is set but
2160 not found on any given filename, that filename is ignored. If all
2161 filenames in a Change are ignored, the Change is dropped. This is
2162 much simpler than the previous sep= nonsense, and I should have
2163 implemented it this way from the beginning. Effectively resolves
2164 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
2165 Gedminas for the catch and suggested fixes.
2166 (ChangePerspective.perspective_addChange): implement the actual
2168 * buildbot/test/test_changes.py (TestChangePerspective): test it
2169 * docs/buildbot.texinfo (PBChangeSource): document it, explain
2170 how to properly use prefix=
2171 * docs/examples/twisted_master.cfg (source): update prefix= by
2172 adding the trailing slash
2175 * docs/examples/twisted_master.cfg: update to actual practice
2177 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
2178 update test case to match new link text.. the HREF has both a
2179 class= setting and an enclosing [] pair that I didn't match in the
2182 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
2183 list of strings is preferred over a single string with embedded
2185 (ShellCommand.description=): explain that either single strings or
2186 a list of strings is acceptable, and why you might prefer one over
2187 the other. Add an example. Fixes SF#1524659, thanks to Paul
2188 Winkler for the catch.
2189 (Build Steps): update to use f.addStep() rather than using s()
2190 and the constructor list
2192 * buildbot/process/step.py (ShellCommand): accept either a single
2193 string or a list of strings in both description= and
2195 * buildbot/test/test_steps.py (Steps.test_description): test it
2196 * buildbot/test/runutils.py (makeBuildStep): support for that test
2198 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
2199 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
2200 collecting the files and creating the patch.
2202 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
2203 per-step URLs that will be displayed on the waterfall display,
2204 for things like the HTML output of code-coverage tools, when
2205 the results are hosted elsewhere.
2206 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
2207 way to retrieve these URLs
2208 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
2209 the method to retrieve these URLs. Also provide backwards
2210 compatibility for saved BuildStepStatus instances that didn't have
2212 * buildbot/process/step.py (BuildStep.addURL): method to set these
2213 URLs from within a BuildStep
2214 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
2215 (StepBox.getBox): give these external links a distinct CSS class
2216 named "BuildStep external" so a .css file can display them
2219 * buildbot/test/test_web.py (WaterfallSteps): test that we really
2221 * buildbot/test/test_steps.py (Steps): test that we can all the
2222 URLs. Also add a bunch of other tests on methods that can be
2223 called from within BuildSteps
2224 * buildbot/test/runutils.py (makeBuildStep): add utility function
2226 2006-08-13 Brian Warner <warner@lothar.com>
2228 * docs/buildbot.texinfo (BuildStep LogFiles): document them
2230 2006-08-10 Brian Warner <warner@lothar.com>
2232 * docs/buildbot.texinfo (Index of master.cfg keys): add another
2233 index, this one of things like c['sources'] and c['schedulers']
2234 (indices): it looks like my clever idea of putting the @fooindex
2235 commands in between the @node and the @subsection (to make the
2236 HREF anchor jump to slightly above the section title, which works
2237 much better in html) confused texinfo horribly, so I'm moving the
2238 index tags back to be just after the @subsection marker. I also
2239 added extra lines between the @node/@section paragraph and the
2240 index tags, since I think maybe texinfo wants to see these be
2241 separate paragraphs.
2243 * docs/Makefile (images): make sure images get built when
2244 rendering the manual
2245 * docs/images/Makefile: same
2247 * buildbot/scripts/runner.py: rename 'buildbot master' to
2248 'buildbot create-master', and 'buildbot slave' to 'buildbot
2250 * docs/buildbot.texinfo: same
2253 * docs/buildbot.texinfo: reimplement the "useful classes" index
2254 with actual texinfo indices. The .info rendering is a bit
2255 weird-looking but it works well, and the HTML rendering is quite
2256 nice. This also puts the index targets in the regular flow of the
2257 text, which is easier to maintain.
2259 2006-08-06 Brian Warner <warner@lothar.com>
2261 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
2262 Kevin Turner to prefer the environ= argument be a list rather than
2263 a string. If it is a list, it will be joined with a platform-local
2264 os.pathsep delimiter, and then prepended to any existing
2265 $PYTHONPATH value. This works better in cross-platform (i.e.
2266 windows buildslaves) environments when you need to push multiple
2267 directories onto the front of the path.
2268 (SlaveShellCommand): documented the new magic
2269 * docs/buildbot.texinfo (ShellCommand): documented the new magic
2270 in a user-visible form
2272 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
2273 Turner to prefer lists over strings when creating/running VC
2274 commands during unit tests. This is clearly necessary to survive
2275 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
2276 renamed the wq() function to qw() though, since that's how it's
2277 spelled in perl. Eventually I'd prefer all commands to be
2278 specified with lists.
2280 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
2281 which are deleted (or not yet created) correctly. Also add
2282 failsafe code to not explode if the file-watching poller doesn't
2283 get started. Thanks to JP Calderone for the catch and the poller
2285 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
2287 * buildbot/test/emitlogs.py: same
2289 * NEWS: summarize recent changes
2291 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
2292 clause to avoid the "host key mismatch" warning
2294 * buildbot/process/step_twisted.py (Trial.start): if the
2295 buildslave is too old to understand logfiles=, fall back to
2296 running 'cat _trial_temp/test.log' like before.
2297 (Trial.commandComplete): same. this takes advantage of the
2298 LoggingBuildStep refactoring to stall commandComplete long enough
2299 to run a second RemoteShellCommand.
2301 * buildbot/process/step.py (LoggingBuildStep.startCommand):
2302 refactor command-completion handling, to allow methods like
2303 commandComplete/createSummary/evaluateCommand to return Deferreds.
2304 (LoggingBuildStep._commandComplete): delete the refactored method
2305 (ShellCommand.setupLogfiles): if the buildslave is too old to
2306 understand logfiles=, put a warning message both into twistd.log
2307 and into the otherwise empty user-visible LogFiles.
2309 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
2310 callers to provide the slave-side logfile name, rather than
2311 forcing it to come from the local name of the LogFile.
2312 (BuildStep.getSlaveName): new method
2314 * buildbot/process/base.py (Build.getSlaveName): new method, so
2315 steps can find out which buildslave they're running on
2317 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
2318 to match the s/cvs_ver/command_version/ change
2320 2006-08-05 Brian Warner <warner@lothar.com>
2322 * buildbot/slave/commands.py (command_version): replace the CVS
2323 auto-updated cvs_ver keyword with a manually-updated variable,
2324 since CVS is no longer the master repository. Add a description of
2325 the remote API change starting in this version (2.1), specifically
2326 the fact that SlaveShellCommand now accepts 'initial_stdin',
2327 'keep_stdin_open', and 'logfiles'.
2329 2006-07-31 Brian Warner <warner@lothar.com>
2331 * docs/buildbot.texinfo (System Architecture): Finally add lots of
2332 diagrams to describe how the whole system fits together. The
2333 images themselves are kept in SVG files, with ascii-art versions
2334 in corresponding .txt files. Texinfo knows how to interpolate the
2335 text version into .info files, reference the .png versions from
2336 .html files, and include .eps versions in the .ps format.
2337 * docs/images/Makefile: tools to create .png and .eps
2338 * docs/images/*.svg: created pictures with Inkscape.
2339 * .darcs-boring: ignore the generated .eps and .png files
2341 2006-07-24 Brian Warner <warner@lothar.com>
2343 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
2344 Scheduler names, since they cause setServiceParent to explode
2346 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
2348 2006-07-20 Brian Warner <warner@lothar.com>
2350 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
2351 which runs the buildbot unit tests
2353 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
2354 classes that are useful in master.cfg
2356 2006-07-15 Brian Warner <warner@lothar.com>
2358 * Makefile (some-apidocs): new target to build only some epydocs
2360 * setup.py: minor comment.. does the classifiers= argument prevent
2361 the setup.py script from working on python2.2/2.3?
2363 * buildbot/scripts/sample.cfg: update manhole example, arrange into
2366 * buildbot/twcompat.py: fix minor typo in comments
2368 * buildbot/manhole.py: move all Manhole-related code out to this
2369 module. Implement SSH-based manholes (with TwistedConch), and move
2370 to conch's nifty line-editing syntax-coloring REPL shell instead
2371 of the boring non-editing monochromatic (and deprecated) old
2373 * buildbot/master.py: remove all Manhole-related code
2374 (BuildMaster.loadConfig._add): make sure the old manhole is
2375 removed before we add the new one
2376 * docs/buildbot.texinfo (Debug options): document new Manhole options
2378 * buildbot/twcompat.py (_which): fix some epydoc issues
2379 * buildbot/status/html.py (Waterfall.__init__): same
2381 2006-06-29 Brian Warner <warner@lothar.com>
2383 * buildbot/interfaces.py: get Interface from b.twcompat to hush
2384 deprecation warnings under newer Twisteds (by using
2385 zope.interface.Interface instead of old twisted.python.components
2387 * buildbot/slave/interfaces.py: same
2389 2006-06-28 Brian Warner <warner@lothar.com>
2391 * buildbot/slave/commands.py (SVN): add --non-interactive to all
2392 svn commands, so it will fail immediately instead of hanging while
2393 it waits for a username/password to be typed in.
2395 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
2396 log message if the step was shut down
2398 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
2399 obsolete reference to mktap.
2401 2006-06-20 Brian Warner <warner@lothar.com>
2403 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
2404 test to include new 'logfiles' argument sent from master to slave
2406 2006-06-19 Brian Warner <warner@lothar.com>
2408 * buildbot/process/step_twisted.py (Trial): track Progress from
2409 _trial_temp/test.log too
2411 * buildbot/process/step.py (OutputProgressObserver): generalize
2412 the earlier StdioProgressObserver into an OutputProgressObserver
2413 that can track LogFiles other than stdio.
2414 (LoggingBuildStep.__init__): same
2416 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
2417 _trial_temp/test.log, not a separate 'cat' command. TODO: this
2418 will fail under windows because of os.sep issues. It might have
2419 worked before if 'cat' was doing cygwin path conversion.
2421 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
2422 creation of LogFileWatchers
2423 (ShellCommand._startCommand): and record the files that were
2424 watched in the 'headers' section of the ShellCommand output
2426 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
2427 need to actually pass it to the slave if you want it to work.
2428 (ShellCommand): document it a bit
2430 * buildbot/test/test_shell.py: new test to validate LogFiles
2431 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
2433 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
2434 before printing the last batch of lines, to test that the polling
2435 logic is working properly
2437 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
2438 handling, making it possible to track multiple logs for a single
2439 RemoteCommand. The previous single logfile is now known as the
2441 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
2442 (RemoteShellCommand.__init__): accept logfiles=
2443 (LoggingBuildStep.startCommand): stdio_log is now one of many
2444 (ShellCommand): added logfiles= argument, as well as a class-level
2445 .logfiles attribute, which will be merged together to figure out
2446 which logfiles should be tracked. The latter maybe be useful for
2447 subclasses of ShellCommand which know they will aways produce
2448 secondary logfiles in the same location.
2450 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
2451 and closeStdin() methods, preparing to make it possible to write
2452 to a ShellCommand's stdin at any time, not just at startup. These
2453 writes are buffered if the child process hasn't started yet.
2454 (LogFileWatcher): new helper class to watch arbitrary logfiles
2455 while a ShellCommand runs. This class polls the file every two
2456 seconds, and sends back 10k chunks to the buildmaster.
2457 (ShellCommand): rename stdin= to initialStdin=, and add
2458 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
2460 (ShellCommand.addLogfile): LogFile text is sent in updates with a
2461 key of "log" and a value of (logname, data).
2462 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
2463 'logfiles' to the master-visible args dictionary.
2464 (SourceBase.doPatch): match s/stdin/initialStdin/ change
2467 * buildbot/test/test_vc.py (Patch.testPatch): same
2470 * buildbot/test/emit.py: write to a logfile in the current
2471 directory. We use this to figure out what was used as a basedir
2472 rather than looking to see which copy of emit.py gets run, so that
2473 we can run the commands from inside _trial_temp rather than inside
2475 * buildbot/test/subdir/emit.py: same
2476 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
2477 argument rather than running from buildbot/test/
2478 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
2479 rather than using an implicit setUp()
2480 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
2481 (ShellBase.testShell1, etc): use explicit path to emit.py instead
2482 of assuming that we're running in buildbot/test/ (and that '.' is
2485 * buildbot/slave/commands.py (Command.doStart): refactor Command
2486 startup/completion a bit: now the SlaveBuilder calls doStart(),
2487 which is not meant for overridding by subclasses, and doStart()
2488 calls start(), which is. Likewise the SlaveBuilder calls
2489 doInterrupt(), and subclasses override interrupt(). This also puts
2490 responsibility for maintaining .running in Command rather than in
2492 (Command.doInterrupt): same
2493 (Command.commandComplete): same, this is called when the deferred
2494 returned by start() completes.
2495 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
2496 (SlaveBuilder.remote_interruptCommand): same
2497 (SlaveBuilder.stopCommand): same
2499 2006-06-16 Brian Warner <warner@lothar.com>
2501 * buildbot/test/test_shell.py: new test file to contain everything
2502 relating to ShellCommand
2503 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
2504 multiple logfiles in realtime" feature, not yet implemented
2505 * buildbot/test/emitlogs.py: support file for testLogFiles
2506 * docs/buildbot.texinfo (ShellCommand): document the feature
2508 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2510 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2511 for tests which exercise SlaveCommands in isolation.
2513 * buildbot/test/test_slavecommand.py: Move some utilities like
2514 SignalMixin and FakeSlaveBuilder from here ..
2515 * buildbot/test/runutils.py: .. to here, so they can be used by
2516 other test classes too
2517 * buildbot/test/test_vc.py: more SignalMixin refactoring
2518 * buildbot/test/test_control.py: same
2519 * buildbot/test/test_run.py: and some rmtree refactoring
2521 2006-06-15 Brian Warner <warner@lothar.com>
2523 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2524 'testBranch' to match other VC tests and have the tests run in
2525 roughly increasing order of dependency
2527 * buildbot/test/test_steps.py (LogObserver): new test to verify
2528 LogObservers can be created at various times and still get
2529 connected up properly
2531 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2532 to create BuildStepStatus instances that actually work.
2534 * buildbot/process/step.py (LogObserver): add outReceived and
2535 errReceived base methods, to be overridden
2537 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2538 API to take a name instead of a step, reducing the coupling
2539 somewhat. This returns the BuildStepStatus object so it can be
2540 passed to the new Step, instead of jamming it directly into the
2542 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2544 * buildbot/process/base.py (Build.setupBuild): use both methods
2545 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2546 process a bit to match
2548 2006-06-14 Brian Warner <warner@lothar.com>
2550 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2551 docs on writing new LogObserver classes
2552 (Writing New Status Plugins): brief docs on how Status Plugins fit
2555 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2556 implement a LogObserver that counts how many unit tests have been
2558 (Trial.__init__): wire it in
2559 * buildbot/test/test_twisted.py (Counter): unit test for it
2561 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2562 to new cmd.logs['stdio'] scheme
2563 (Trial.commandComplete): same
2564 (BuildDebs.commandComplete): same
2566 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2567 LogFiles, instead of just a single one. The old single logfile is
2568 now called "stdio". LoggedRemoteCommand no longer creates a
2569 LogFile for you (the code to do that was broken anyway). If you
2570 don't create a "stdio" LogFile, then stdout/stderr will be
2572 (LogObserver): implement "LogObservers", which a BuildStep can add
2573 to parse the output of a command in real-time. The primary use is
2574 to provide more useful information to the Progress code, allowing
2575 better ETA estimates.
2576 (LogLineObserver): utility subclass which feeds complete lines to
2577 the parser instead of bytes.
2578 (BuildStep.progressMetrics): this is safer as a tuple
2579 (BuildStep.setProgress): utility method, meant to be called by
2581 (BuildStep.addLogObserver): new method, to be called at any time
2582 during the BuildStep (even before any LogFiles have been created),
2583 to attach (or schedule for eventual attachment) a LogObserver to a
2585 (StdioProgressObserver): new LogObserver which replaces the old
2586 "output" progress gatherer
2587 (LoggingBuildStep.__init__): same
2588 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2589 (LoggingBuildStep._commandComplete): must use logs['stdio']
2590 instead of the old single ".log" attribute.
2591 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2592 functionality, now subsumed into StdioProgressObserver
2593 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2594 log name changed from "output" to "stdio".
2597 * buildbot/interfaces.py (ILogFile): add the Interface used from
2598 the BuildStep towards the LogFile
2599 (ILogObserver): and the one provided by a LogObserver
2600 * buildbot/status/builder.py (LogFile): implement it
2602 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2603 HEADER constants here ..
2604 * buildbot/status/builder.py (STDOUT): .. from here
2606 2006-06-13 Brian Warner <warner@lothar.com>
2608 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2609 compatibility with python2.2, which doesn't have the 'substr in
2611 (TestP4Poller.makeTime): utility function to construct the
2612 timestamp using the same strptime() approach as p4poller does. It
2613 turns out that time.mktime() behaves slightly differently under
2614 python2.2, probably something to do with the DST flag, and that
2615 causes the test to fail under python2.2. (changing the mktime()
2616 arguments to have dst=0 instead of -1 caused it to fail under
2617 python2.3. Go figure.)
2618 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2620 2006-06-12 Brian Warner <warner@lothar.com>
2622 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2623 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2624 contributing such an excellent patch, including docs and unit
2625 tests! This makes it *so* much easier to apply. I had to update
2626 test_vc.py to handle some recent refactorings, but everything else
2627 applied smoothly. The only remaining thing I'd like to fix would
2628 be to remove the hard-wired port 1666 used by p4d, and allow it to
2629 claim any unused port. This would allow two copies of the test
2630 suite to run on the same host at the same time, as well as
2631 allowing the test suite to run while a real (production) p4d was
2632 running on the same host. Oh, and maybe we should add a warning to
2633 step.P4 that gets emitted if the slave is too old to provide the
2634 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2635 * buildbot/slave/commands.py (P4): same
2636 (P4Sync): same, some minor updates
2637 * buildbot/changes/p4poller.py: same
2638 * docs/buildbot.texinfo: same
2639 * buildbot/test/test_p4poller.py: same
2640 * buildbot/test/test_vc.py (P4): same
2642 * setup.py: add Trove classifiers for PyPI
2644 2006-06-08 Brian Warner <warner@allmydata.com>
2646 * buildbot/status/client.py
2647 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2648 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2649 build needs to be IRemote'd separately, rather than IRemote'ing
2650 the whole list at once. I can't wait until newpb's serialization
2651 adapters make this unnecessary.
2653 2006-06-06 Brian Warner <warner@lothar.com>
2655 * buildbot/process/step.py (WithProperties): make this inherit
2656 from ComparableMixin, so that reloading an unchanged config file
2657 doesn't cause us to spuriously reload any Builders which use them.
2658 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2661 2006-06-03 Brian Warner <warner@lothar.com>
2663 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2664 running py2exe on windows, contributed by Mark Hammond. Addresses
2665 SF#1401121, but I think we still need to include
2666 buildbot/scripts/sample.cfg
2667 * setup.py: include buildbot_service.py as a script under windows
2668 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2669 a py2exe application), get the icon/css datafiles from a different
2672 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2673 double-escape the build URL. Thanks to Olivier Bonnet for the
2674 patch. Fixes SF#1452801.
2676 2006-06-02 Brian Warner <warner@lothar.com>
2678 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2679 first six columns of 'svnlook' output, not just the first column,
2680 since property changes appear in the other five. Thanks to Olivier
2681 Bonnet for the patch. Fixes SF#1398174.
2683 2006-06-01 Brian Warner <warner@lothar.com>
2685 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2686 the fake build, so that title= has something to be set to
2688 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2689 attribute of the "Build #NN" link in the yellow start-the-build
2690 box to the build's reason. This means that you get a little
2691 tooltip explaining why the build was done when you hover over the
2692 yellow box. Thanks to Zandr Milewski for the suggestion.
2694 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2695 (Box.setETA): handle ETA=None (by stopping the timer)
2696 (Box.update): make the [soon] text less different than the usual
2697 text, so the rest of the text doesn't flop around so much. It
2698 would be awfully nice to figure out how to center this stuff.
2699 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2701 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2702 by default, so that any ShellCommand which fails marks the overall
2703 build as a failure. I should have done this from the beginning.
2704 Add flunkOnFailure=False to the arguments if you want to turn off
2707 2006-05-30 Brian Warner <warner@lothar.com>
2709 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2710 last-build/current-build/current-step. Show what step is currently
2711 running. Show ETA for both the overall build and the current step.
2712 Update GTK calls to modern non-deprecated forms. There's still a
2713 lot of dead code and debug noise to remove.
2715 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2716 shows up properly in status displays
2718 2006-05-28 Brian Warner <warner@lothar.com>
2720 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2721 build we use to verify that WithProperties works:
2723 ** set flunkOnFailure=True so that build failures get noticed
2724 ** set workdir='.' so that the build succeeds, otherwise it is trying
2725 to touch 'build/something', and 'build/' doesn't exist because
2726 usually that's created by a Source step
2727 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2728 this test somehow triggers, in which the 'touch' process becomes
2729 a zombie and we wait for th etimeout before giving up on it.
2731 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2732 to log the Build results and step logs to the twisted log.
2733 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2734 what went wrong if a build was expected to succeed but didn't.
2736 * buildbot/process/step_twisted.py (Trial): set the default
2737 trialMode to '--reporter=bwverbose', which specifies verbose
2738 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2739 '-to', but those are completely missing in modern Twisteds.
2741 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2742 a localhost-only port, to encourage better security
2744 * docs/buildbot.texinfo (Change Sources): mention
2747 * .darcs-boring: add a Darcs boringfile
2749 * README (REQUIREMENTS): stop claiming compatibility with
2752 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2755 2006-05-27 Brian Warner <warner@lothar.com>
2757 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2758 * docs/buildbot.texinfo: same
2760 2006-05-23 Brian Warner <warner@lothar.com>
2762 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2763 * docs/buildbot.texinfo: set version to match
2764 * NEWS: update for 0.7.3
2766 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2767 give a quick mapping from VC system to possible ChangeSources
2768 (Build Properties): add 'buildername'
2770 * buildbot/process/base.py (Build.setupStatus): oops, set
2771 'buildername' and 'buildnumber' properties
2772 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2775 2006-05-22 Brian Warner <warner@lothar.com>
2777 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2778 property interpolation better
2780 * README (INSTALLATION): remove old '-v' argument from recommended
2783 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2784 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2787 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2788 'svnversion' instead of grepping the output of 'svn info', much
2789 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2790 Bonnet for the suggestion.
2791 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2792 require the WC_PATH argument, so run 'svnversion .' instead.
2794 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2795 aren't supposed to have 'self' in their argument list
2797 2006-05-21 Brian Warner <warner@lothar.com>
2799 * buildbot/process/step.py (ShellCommand.start): make
2800 testInterpolate pass. I was passing the uninterpolated command to
2801 the RemoteShellCommand constructor
2802 (ShellCommand._interpolateProperties): oops, handle non-list
2803 commands (i.e. strings with multiple words separated by spaces in
2804 them) properly, instead of forgetting about them.
2806 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2807 to actually try to use build properties in a real build. This test
2809 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2810 to start and evaluate builds
2812 * buildbot/test/test__versions.py: add a pseudo-test to record
2813 what version of Twisted/Python/Buildbot are running. This should
2814 show up at the beginning of _trial_tmp/test.log, and exists to help
2815 debug other problems.
2817 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2818 a filename to be served as 'robots.txt' to discourage web spiders.
2819 Adapted from a patch by Tobi Vollebregt, thanks!
2820 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2821 (Waterfall.test_waterfall): tweak the way that filenames are put
2822 into the config file, to accomodate windows pathnames better.
2824 * docs/buildbot.texinfo (HTML Waterfall): document it
2826 * buildbot/process/process_twisted.py
2827 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2828 changed the build process. The new setup.py no longer takes the
2830 (FullTwistedBuildFactory.__init__): same
2831 (TwistedReactorsBuildFactory.__init__): same
2833 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2834 be placed in the [hooks] section of the central repository (the
2835 one that everybody pushes changes to).
2837 2006-05-20 Brian Warner <warner@lothar.com>
2839 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2840 .darcs-context file, use binary mode. I think this was causing a
2841 Darcs failure under windows.
2843 2006-05-19 Brian Warner <warner@lothar.com>
2845 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2846 use a timezone string of +0000 and gmtime, since this timestamp is
2847 sent to a buildmaster and %z is broken.
2849 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2850 string and localtime, since this timestamp will only be consumed
2851 locally, and %z is broken.
2853 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2854 gmtime, since this timestamp is returned to the buildmaster, and
2857 2006-05-18 Brian Warner <warner@lothar.com>
2859 * NEWS: update in preparation for next release
2861 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2862 setup-repository and do-we-have-the-vc-tools code into a separate
2863 "helper" class, which sticks around in a single module-level
2864 object. This seems more likely to continue to work in the future
2865 than having it hide in the TestCase and hope that TestCases stick
2866 around for a long time.
2868 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2869 addremove' has been deprecated in recent versions of mercurial, so
2870 use 'hg add' instead
2872 2006-05-07 Brian Warner <warner@lothar.com>
2874 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2875 operating under windows, move the file before opening it, since
2876 you can't rename a file that somebody has open.
2878 * buildbot/process/base.py (Build.setupBuild): if something goes
2879 wrong while creating a Step, log the name and arguments, since the
2880 error message when you get the number of arguments wrong is really
2883 2006-05-06 Brian Warner <warner@lothar.com>
2885 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2886 bugs in twisted-specific code not covered by my unit tests, this
2887 time use 'cmd' argument instead of self.cmd
2889 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2890 fix stupid braino: either use startwith or find()==0, not both.
2891 (TwistedReactorsBuildFactory.__init__): another dumb typo
2893 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2894 mark this test as TODO under windows, since process-killing seems
2895 dodgy there. We'll come back to this later and try to fix it
2898 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2899 and don't include a timezone
2900 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2901 This should avoid the windows-with-verbose-timezone-name problem
2903 (Patch.testPatch): add a test which runs 'patch' with less
2904 overhead than the full VCBase.do_patch sequence, to try to isolate
2905 a windows test failure. This one uses slave.commands.ShellCommand
2906 and 'patch', but none of the VC code.
2908 * buildbot/slave/commands.py (getCommand): use which() to find the
2909 executables for 'cvs', 'svn', etc. This ought to help under
2912 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2913 working directory before starting. If an earlier test failed, the
2914 leftover directory would mistakenly flunk a later test.
2915 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2916 Make sure that we use the right commandlines if which("tla") picks
2917 up "tla.exe" (as it does under windows).
2918 (TlaSupport.do_get): factor out this tla-vs-baz difference
2919 (TlaSupport.vc_create): more tla-vs-baz differences
2921 * buildbot/test/test_slavecommand.py
2922 (ShellBase.testShellMissingCommand): stop trying to assert
2923 anything about the error message: different shells on different
2924 OSes with different languages makes it hard, and it really isn't
2925 that interesting of a thing to test anyway.
2927 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2928 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2929 "Panther"), because it has a bug which flunks a couple tests in
2930 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2931 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2932 able to test that yet.
2934 2006-04-30 Brian Warner <warner@lothar.com>
2936 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2937 make sure child commands emit messages in english, so our regexps
2938 will match. Thanks to Nikaus Giger for identifying the problems.
2939 (VCBase._do_vctest_export_1): mode="export" is not responsible
2940 for setting the "got_revision" property, since in many cases it is
2941 not convenient to determine.
2942 (SVNSupport.capable): when running 'svn --version' to check for
2943 ra_local, we want error messages in english
2944 * buildbot/test/test_slavecommand.py
2945 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2946 to emit the error message in english
2948 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2949 the environment with $LC_ALL="C" so that Commands which need to
2950 parse the output of their child processes can obtain it in
2952 (SVN.parseGotRevision): call "svn info" afterwards instead of
2953 watching the output of the "svn update" or "svn checkout".
2954 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2955 (Arch.parseGotRevision): same
2956 (Bazaar.parseGotRevision): same
2957 (Mercurial.parseGotRevision): same
2959 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2960 $LC_ALL="C" when running commands under 'buildbot try', too
2962 * buildbot/test/__init__.py: remove the global os.environ()
2963 setting, instead we do it just for the tests that run commands and
2964 need to parse their output.
2966 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2967 remove the overly-short .timeout on this test, because non-DNotify
2968 platforms must fall back to polling which happens at 10 second
2969 intervals, so a 5 second timeout would never succeed.
2971 2006-04-24 Brian Warner <warner@lothar.com>
2973 * docs/buildbot.texinfo (Installing the code): update trial
2974 invocation, SF#1469116 by Niklaus Giger.
2975 (Attributes of Changes): updated branch-name examples to be
2976 a bit more realistic, SF#1475240 by Stephen Davis.
2978 * contrib/windows/buildbot2.bat: utility wrapper for windows
2979 developers, contributed by Nick Trout (after a year of neglect..
2980 sorry!). SF#1194231.
2982 * buildbot/test/test_vc.py (*.capable): store the actual VC
2983 binary's pathname in VCS[vcname], so it can be retrieved later
2984 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2985 strip out non-numeric timezone information, specifically the funky
2986 German string that his system produced that confuses CVS.
2987 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2988 allow Darcs tests to work on windows
2989 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2990 procutils.which() everywhere, to allow tryclient to work under
2991 windows. Also from Niklaus Giger, SF#1463394.
2993 * buildbot/twcompat.py (which): move the replacement for a missing
2994 twisted.python.procutils.which from test_vc.py to here, so it can
2995 be used in other places too (specifically tryclient.py)
2997 2006-04-23 Brian Warner <warner@lothar.com>
2999 * buildbot/status/html.py (StatusResourceBuild.body): replace the
3000 bare buildbotURL/projectName line with a proper DIV, along with a
3001 CSS class of "title", from Stefan Seefeld (SF#1461675).
3002 (WaterfallStatusResource.body0): remove the redundant 'table'
3003 class from the table
3004 (WaterfallStatusResource.body): same. Also add class="LastBuild"
3005 to the top-row TR, and class="Activity" to the second-row TR,
3006 rather than putting them in the individual TD nodes.
3008 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
3009 'got_revision' build property for all VC systems that implement
3010 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
3012 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
3013 to determine which revision we actually obtained
3014 (CVS.parseGotRevision): implement this for CVS, which just means
3015 to grab a timestamp. Not ideal, and it depends upon the buildslave
3016 having a clock that is reasonably well syncronized with the server,
3017 but it's better than nothing.
3018 (SVN.parseGotRevision): implement it for SVN, which is accurate
3019 (Darcs.parseGotRevision): same
3020 (Arch.parseGotRevision): same
3021 (Bazaar.parseGotRevision): same
3022 (Mercurial.parseGotRevision): same
3024 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
3025 keep a record of all non-stdout/stderr/header/rc status updates,
3026 for the benefit of RemoteCommands that send other useful things,
3028 (Source.commandComplete): put any 'got_revision' status values
3029 into a build property of the same name
3032 * buildbot/process/step_twisted.py (Trial): update to deal with
3033 new ShellCommand refactoring
3035 * docs/buildbot.texinfo (Build Properties): document new feature
3036 that allows BuildSteps to get/set Build-wide properties like which
3037 revision was requested and/or checked out.
3039 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
3040 * buildbot/status/builder.py (BuildStatus.getProperty): implement
3041 it. Note that this bumps the persistenceVersion of the saved Build
3042 object, so add the necessary upgrade-old-version logic to include
3043 an empty properties dict.
3045 * buildbot/process/base.py (Build.setProperty): implement it
3046 (Build.getProperty): same
3047 (Build.startBuild): change build startup to set 'branch',
3048 'revision', and 'slavename' properties at the right time
3050 * buildbot/process/step.py (BuildStep.__init__): change setup to
3051 require 'build' argument in a better way
3052 (LoggingBuildStep): split ShellCommand into two pieces, for better
3053 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
3054 a single RemoteCommand that sends stdout/stderr status text. It
3055 also provides the usual commandComplete / createSummary /
3056 evaluateCommand / getText methods to be overridden...
3057 (ShellCommand): .. whereas ShellCommand is specifically for
3058 running RemoteShellCommands. Other shell-like BuildSteps (like
3059 Source) can inherit from LoggingBuildStep instead of ShellCommand
3060 (WithProperties): marker class to do build-property interpolation
3061 (Source): inherit from LoggingBuildStep instead of ShellCommand
3064 * buildbot/test/test_properties.py: test new functionality
3066 2006-04-21 Brian Warner <warner@lothar.com>
3068 * buildbot/test/test_vc.py: rename testBranch to
3069 testCheckoutBranch to keep the tests in about the right
3072 2006-04-18 Brian Warner <warner@lothar.com>
3074 * docs/buildbot.texinfo (PBListener): improve cross-references
3075 between PBListener and 'buildbot statusgui', thanks to John Pye
3078 2006-04-17 Brian Warner <warner@lothar.com>
3080 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
3081 running under Twisted-1.3.0, otherwise skipped tests are reported
3084 * all: use isinstance() instead of 'type(x) is foo', suggested by
3087 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3088 oops, fix a brain-fade from the other week, when making the
3089 addStep changes. I changed all the __init__ upcalls to use the
3090 wrong superclass name.
3091 (FullTwistedBuildFactory.__init__): same
3092 (TwistedDebsBuildFactory.__init__): same
3093 (TwistedReactorsBuildFactory.__init__): same
3094 (TwistedBuild.isFileImportant): use .startswith for clarity,
3095 thanks to Neal Norwitz for the suggestions.
3097 * contrib/viewcvspoll.py: script to poll a viewcvs database for
3098 changes, then deliver them over PB to a remote buildmaster.
3100 * contrib/svnpoller.py: added script by John Pye to poll a remote
3101 SVN repository (by running 'svn log') from a cronjob, and run
3102 'buildbot sendchange' to deliver the changes to a remote
3104 * contrib/svn_watcher.py: added script by Niklaus Giger (a
3105 modification of svnpoller.py), same purpose, but this one loops
3106 internally (rather than expecting to run from a cronjob) and works
3108 * contrib/README.txt: same
3110 2006-04-11 Brian Warner <warner@lothar.com>
3112 * all: fix a number of incorrect names and missing imports, thanks
3113 to Anthony Baxter for the patch.
3114 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
3115 remove unused buggy method.
3116 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
3117 comes from shutil, not "shutils"
3118 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
3119 (Arch.checkSlaveVersion): same
3120 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
3122 * buildbot/process/step_twisted2.py: add some missing imports
3123 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
3124 this code used to live in twisted.internet.defer
3126 2006-04-10 Brian Warner <warner@lothar.com>
3128 * buildbot/process/step.py (Mercurial): add Mercurial support
3129 * buildbot/slave/commands.py (Mercurial): same
3130 * buildbot/scripts/tryclient.py (MercurialExtractor): same
3131 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
3132 not yet tested, but 'try' support *is* covered
3133 * docs/buildbot.texinfo (Mercurial): document it
3135 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
3136 some debugging messages (turned off)
3137 * buildbot/test/test_vc.py: improve debug messages
3139 2006-04-07 Brian Warner <warner@lothar.com>
3141 * buildbot/test/test_vc.py (which): define our own which() in case
3142 we can't import twisted.python.procutils, because procutils doesn't
3143 exist in Twisted-1.3
3145 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
3146 of SlaveLocks for performance tests
3148 * docs/examples/twisted_master.cfg: update to match current usage
3150 * buildbot/changes/p4poller.py (P4Source): add new arguments:
3151 password, p4 binary, pollinterval, maximum history to check.
3152 Patch from an anonymous sf.net contributor, SF#1219384.
3153 * buildbot/process/step.py (P4Sync.__init__): add username,
3154 password, and client arguments.
3155 * buildbot/slave/commands.py (P4Sync): same
3157 2006-04-05 Brian Warner <warner@lothar.com>
3159 * buildbot/process/factory.py (BuildFactory.addStep): new method
3160 to add steps to a BuildFactory. Use it instead of f.steps.append,
3161 and you can probably avoid using the s() convenience function.
3162 Patch from Neal Norwitz, sf.net #1412605.
3163 (other): update all factories to use addStep
3164 * buildbot/process/process_twisted.py: update all factories to use
3167 2006-04-03 Brian Warner <warner@lothar.com>
3169 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
3170 work under windows too. Adapted from a patch by Niklaus Giger,
3171 addresses SF#1463399.
3173 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
3174 spawned commands emit parseable results in english and not some
3175 other language. Patch from Niklaus Giger, SF#1463395.
3177 * README (INSTALLATION): discourage users from running unit tests on
3178 a "network drive", patch from Niklaus Giger, SF#1463394.
3180 2006-03-22 Brian Warner <warner@lothar.com>
3182 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
3183 function to turn a repository-relative pathname into a (branch,
3184 branch-relative-filename) tuple. Change this function to handle
3185 the branch naming policy used by your Subversion repository.
3186 Thanks to AllMyData.com for sponsoring this work.
3188 2006-03-16 Brian Warner <warner@lothar.com>
3190 * buildbot/scripts/sample.cfg: add python-mode declaration for
3191 vim. Thanks to John Pye for the patch.
3193 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
3194 command line, mention the importance of running 'crontab' as the
3195 buildmaster/buildslave user. Thanks to John Pye for the catch.
3197 2006-03-13 Brian Warner <warner@lothar.com>
3199 * buildbot/status/words.py (IRC): add an optional password=
3200 argument, which will be sent to Nickserv in an IDENTIFY message at
3201 login, to claim the nickname. freenode requires this before the
3202 bot can sent (or reply to) private messages. Thanks to Clement
3203 Stenac for the patch.
3204 * docs/buildbot.texinfo (IRC Bot): document it
3206 * buildbot/status/builder.py (LogFile.merge): don't write chunks
3207 larger than chunkSize. Fixes SF#1349253.
3208 * buildbot/test/test_status.py (Log.testLargeSummary): test it
3209 (Log.testConsumer): update to match new internal chunking behavior
3211 2006-03-12 Brian Warner <warner@lothar.com>
3213 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
3215 * buildbot/test/test_maildir.py (MaildirTest): rename the
3216 'timeout' method, as it collides with trial's internals
3218 * buildbot/scripts/runner.py: add 'buildbot restart' command
3219 (stop): don't sys.exit() out of here, otherwise restart can't work
3220 * docs/buildbot.texinfo (Shutdown): document it
3222 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
3223 * buildbot/status/html.py (Waterfall.__init__): same
3224 * buildbot/process/builder.py (Builder.startBuild): same
3225 * buildbot/process/base.py (BuildRequest): same
3226 * buildbot/sourcestamp.py (SourceStamp): same
3227 * buildbot/scheduler.py (Nightly): same
3229 * buildbot/__init__.py (version): bump to 0.7.2+ while between
3231 * docs/buildbot.texinfo: same
3233 2006-02-17 Brian Warner <warner@lothar.com>
3235 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
3236 * docs/buildbot.texinfo: set version number to match
3237 * NEWS: update for 0.7.2
3239 2006-02-16 Brian Warner <warner@lothar.com>
3241 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
3243 2006-02-09 Brian Warner <warner@lothar.com>
3245 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
3246 add text to explain per-build branch parameters
3247 * NEWS: mention --umask
3249 2006-02-08 Brian Warner <warner@lothar.com>
3251 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
3253 (SlaveOptions.optParameters): add --umask, to make it possible to
3254 make buildslave-generated files (including build products) be
3257 * buildbot/slave/bot.py (BuildSlave.startService): same
3259 2006-01-23 Brian Warner <warner@lothar.com>
3261 * buildbot/status/builder.py: urllib.quote() all URLs that include
3262 Builder names, so that builders can include characters like '/'
3263 and ' ' without completely breaking the resulting HTML. Thanks to
3264 Kevin Turner for the patch.
3265 * buildbot/status/html.py: same
3266 * buildbot/test/test_web.py (GetURL.testBuild): match changes
3268 * NEWS: update in preparation for upcoming release
3270 2006-01-18 Brian Warner <warner@lothar.com>
3272 * docs/examples/twisted_master.cfg: update to match the Twisted
3273 buildbot: remove python2.2, switch to exarkun's buildslaves,
3274 disable the .deb builder until we figure out how to build twisted
3275 .debs from SVN, add some ktrace debugging to the OS-X build
3276 process and remove the qt build, remove threadless builders,
3277 change freebsd builder to use landonf's buildslave.
3279 2006-01-12 Brian Warner <warner@lothar.com>
3281 * buildbot/master.py (Manhole.__init__): let port= be a strports
3282 specification string, but handle a regular int for backwards
3283 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
3284 used in master.cfg to limit connections to just the local host.
3285 (BuildMaster.loadConfig): same for c['slavePortnum']
3286 * buildbot/scheduler.py (Try_Userpass.__init__): same
3287 * buildbot/status/client.py (PBListener.__init__): same
3288 * buildbot/status/html.py (Waterfall.__init__): same, for both
3289 http_port and distrib_port. Include backwards-compatibility checks
3290 so distrib_port can be a filename string and still mean unix:/foo
3291 * docs/buildbot.texinfo (Setting the slaveport): document it
3292 (Debug options): same
3293 (HTML Waterfall): same
3296 * buildbot/test/test_config.py (ConfigTest): test it
3298 * buildbot/master.py (BuildMaster.loadConfig): wait for the
3299 slaveport's disownServiceParent deferred to fire before opening
3300 the new one. Fixes an annoying bug in the unit tests.
3302 2006-01-03 Brian Warner <warner@lothar.com>
3304 * buildbot/master.py (BuildMaster): remove the .schedulers
3305 attribute, replacing it with an allSchedulers() method that looks
3306 for all IService children that implement IScheduler. Having only
3307 one parent/child relationship means fewer opportunities for bugs.
3308 (BuildMaster.allSchedulers): new method
3309 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
3310 also fix ugly bug that caused any config-file reload to
3311 half-forget about the earlier Schedulers, causing an exception
3312 when a Change arrived and was handed to a half-connected
3313 Scheduler. The exception was in scheduler.py line 54ish:
3314 self.parent.submitBuildSet(bs)
3315 exceptions.AttributeError: 'NoneType' object has no attribute
3317 (BuildMaster.addChange): update to use allSchedulers()
3319 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
3320 to work properly with twisted-1.3.0, where you must explicitly
3321 include the __implements__ from parent classes
3322 (BaseScheduler.__repr__): make it easier to distinguish distinct
3324 (BaseUpstreamScheduler.__implements__): same
3326 * buildbot/status/builder.py (Status.getSchedulers): update to
3328 * buildbot/test/test_run.py (Run.testMaster): same
3329 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
3330 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
3331 make sure Scheduler instances are left alone when an identical
3332 config file is reloaded
3333 (ConfigElements.testSchedulers): make sure Schedulers are properly
3336 * Makefile (TRIALARGS): my local default Twisted version is now
3337 2.1.0, update the trial arguments accordingly
3339 2005-12-22 Brian Warner <warner@lothar.com>
3341 * docs/examples/twisted_master.cfg: merge changes from pyr: add
3344 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
3345 addChange in the parent class, although I suspect this should be
3346 fixed better in the future.
3348 2005-11-26 Brian Warner <warner@lothar.com>
3350 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
3351 explode when branch==None, thanks to Kevin Turner for the catch
3352 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
3355 * buildbot/__init__.py (version): bump to 0.7.1+ while between
3357 * docs/buildbot.texinfo: same
3359 2005-11-26 Brian Warner <warner@lothar.com>
3361 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
3362 * docs/buildbot.texinfo: set version number to match
3364 2005-11-26 Brian Warner <warner@lothar.com>
3366 * NEWS: update for 0.7.1
3368 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
3369 sure that unsubscribe works even if we never sent an ETA update.
3370 Also, don't explode on duplicate unsubscribe.
3371 (BuildStepStatus.addLog): make the convenience "return self"-added
3372 watcher automatically unsubscribe when the Step finishes.
3373 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
3374 (BuildStatus.stepStarted): same auto-unsubscribe
3375 (BuilderStatus.buildStarted): same auto-unsubscribe
3377 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
3379 (IStatusReceiver.stepStarted): same
3380 (IStatusReceiver.logStarted): same
3382 * buildbot/test/test_run.py (Status): move the Status test..
3383 * buildbot/test/test_status.py (Subscription): .. to here
3385 2005-11-25 Brian Warner <warner@lothar.com>
3387 * NEWS: more updates
3389 * buildbot/locks.py: fix the problem in which loading a master.cfg
3390 file that changes some Builders (but not all of them) can result
3391 in having multiple copies of the same Lock. Now, the real Locks
3392 are kept in a table inside the BotMaster, and the Builders/Steps
3393 use "LockIDs", which are still instances of MasterLock and
3394 SlaveLock. The real Locks are instances of the new RealMasterLock
3395 and RealSlaveLock classes.
3396 * buildbot/master.py (BotMaster.getLockByID): new method to
3397 convert LockIDs into real Locks.
3398 * buildbot/process/base.py (Build.startBuild): convert LockIDs
3399 into real Locks before building
3400 * buildbot/process/step.py (BuildStep.startStep): same
3401 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
3402 exercises the problem
3405 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
3406 what Schedulers are available
3408 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
3409 work by Dobes Vandermeer and hacked mercilessly by me. This offers
3410 'cron'-style build scheduling at certain times of day, week,
3412 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
3414 * buildbot/scheduler.py (Scheduler): change fileIsImportant
3415 handling: treat self.fileIsImportant more as an attribute that
3416 contains a callable than as a method. If the attribute is None,
3417 don't call it and assume all filenames are important. It is still
3418 possible to provide a fileIsImportant method in a subclass,
3420 (AnyBranchScheduler): handle fileIsImportant=None, previously it
3422 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
3423 test using AnyBranchScheduler with fileIsImportant=None
3425 2005-11-24 Brian Warner <warner@lothar.com>
3427 * buildbot/test/test_config.py (StartService): don't claim a fixed
3428 port number, instead set slavePort=0 on the first pass, figure out
3429 what port was allocated, then switch to a config file that uses
3432 * buildbot/master.py (BuildMaster.loadConfig): close the old
3433 slaveport before opening the new one, because unit tests might
3434 replace slavePort=0 with the same allocated portnumber, and if we
3435 don't wait for the old port to close first, we get a "port already
3436 in use" error. There is a tiny race condition here, but the only
3437 threat is from other programs that bind (statically) to the same
3438 port number we happened to be allocated, and only if those
3439 programs use SO_REUSEADDR, and only if they get control in between
3442 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
3444 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
3445 deleted ChangeSources before adding any new ones
3446 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
3447 compare_attrs, to make sure that a config-file reload does not
3448 unnecessarily replace an unmodified ChangeSource instance
3449 * buildbot/test/test_config.py (ConfigTest.testSources): update
3451 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
3452 mean "don't build anything", and add a warning if it gets used
3453 because it isn't actually useful.
3455 * contrib/svn_buildbot.py: update example usage to match the port
3456 number that gets used by the PBChangeSource
3457 * buildbot/scripts/sample.cfg: add example of PBChangeSource
3459 2005-11-22 Brian Warner <warner@lothar.com>
3461 * NEWS: start collecting items for next release
3463 * buildbot/process/step.py (SVN.computeSourceRevision): assume
3464 revisions are strings
3465 (P4Sync.computeSourceRevision): same
3467 * buildbot/status/html.py (StatusResourceBuild.body): add a link
3468 to the Buildbot's overall status page
3469 (StatusResourceBuilder.body): same
3471 2005-11-15 Brian Warner <warner@lothar.com>
3473 * buildbot/master.py (BuildMaster.loadConfig): serialize the
3474 config-file loading, specifically to make sure old StatusTargets
3475 are finished shutting down before new ones start up (thus
3476 resolving a bug in which changing the Waterfall object would fail
3477 because both new and old instances were claiming the same
3478 listening port). Also load new Schedulers after all the new
3479 Builders are set up, in case they fire off a new build right away.
3480 * buildbot/test/test_config.py (StartService): test it
3482 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
3483 the branch name to the mail body
3485 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
3486 Without it, a config-file reload fails to update an existing
3488 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
3489 username/passwd to compare_attrs, for the same reason
3490 * buildbot/status/html.py (Waterfall): add favicon to
3491 compare_attrs, same reason
3493 2005-11-05 Brian Warner <warner@lothar.com>
3495 * buildbot/scripts/tryclient.py (createJobfile): stringify the
3496 baserev before stuffing it in the jobfile. This resolves problems
3497 under SVN (and probably Arch) where revisions are expressed as
3498 numbers. I'm inclined to use string-based revisions everywhere in
3499 the future, but this fix should be safe for now. Thanks to Steven
3500 Walter for the patch.
3502 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
3503 binary mode when opening pickle files, to make windows work
3504 better. Thanks to Dobes Vandermeer for the catch.
3505 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3506 (BuilderStatus.getBuildByNumber): same
3507 (Status.builderAdded): same
3508 * buildbot/master.py (BuildMaster.loadChanges): same
3510 * buildbot/util.py (Swappable): delete unused leftover code
3512 * buildbot/process/step.py (SVN): when building on a non-default
3513 branch, add the word "[branch]" to the VC step's description, so
3514 it is obvious that we're not building the usual stuff. Likewise,
3515 when we are building a specific revision, add the text "rNNN" to
3516 indicate what that revision number is. Thanks to Brad Hards and
3517 Nathaniel Smith for the suggestion.
3518 (Darcs.startVC): same
3519 (Arch.startVC): same
3520 (Bazaar.startVC): same
3522 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3523 typo, caught by Mark Dillavou, closes SF#1216636.
3525 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3526 about a test to add some day
3528 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3529 the 'full-2.3' build, and the 'reactors' build is now run under
3530 python-2.4 because the buildslave no longer has gtk/etc bindings
3531 for earlier versions.
3533 2005-11-03 Brian Warner <warner@lothar.com>
3535 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3536 method, takes an IBuildStatus and rebuilds it. It might make more
3537 sense to add this to IBuildControl instead, but that instance goes
3538 away completely once the build has finished, and resubmitting
3539 builds can take place weeks later.
3540 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3541 * buildbot/status/html.py (StatusResourceBuild): also stash an
3542 IBuilderControl so we can use resubmitBuild.
3543 (StatusResourceBuild.body): render "resubmit" button if we can.
3544 Also add hrefs for each BuildStep
3545 (StatusResourceBuild.rebuild): add action for "resubmit" button
3546 (StatusResourceBuilder.getChild): give it an IBuilderControl
3548 * buildbot/status/builder.py (Status.getURLForThing): change the
3549 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3550 that live as targets of buttons like "stop" and "rebuild" can't
3552 * buildbot/status/builder.py (Status.getURLForThing): same
3553 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3554 (StepBox.getBox): same
3555 * buildbot/test/test_web.py (GetURL): same
3558 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3559 exclusivity checks after Source.__init__ upcall, so misspelled
3560 arguments will be reported more usefully
3561 (Darcs.__init__): same
3563 2005-10-29 Brian Warner <warner@lothar.com>
3565 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3566 builder. Move the Try scheduler off to a separate port.
3568 2005-10-27 Brian Warner <warner@lothar.com>
3570 * buildbot/clients/gtkPanes.py
3571 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3572 to cause the app to crash, now they don't.
3574 * buildbot/clients/debug.py: display the buildmaster's location
3575 in the window's title bar
3577 2005-10-26 Brian Warner <warner@lothar.com>
3579 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3580 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3581 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3583 * buildbot/status/html.py (td): put a single non-breaking space
3584 inside otherwise empty <td> elements, as a workaround for buggy
3585 browsers which would optimize them away (along with any associated
3586 styles, like the kind that create the waterfall grid borders).
3587 Patch from Frerich Raabe.
3589 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3590 argv-list as an argument, defaulting to ["-to"], which is
3591 appropriate for the Trial that comes with Twisted-2.1.0 and
3592 earlier. The Trial in current Twisted SVN wants
3593 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3594 defaults to an empty list.
3595 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3596 match it, now that trialMode= is a list instead of a single string
3598 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3600 * docs/buildbot.texinfo: same
3602 2005-10-24 Brian Warner <warner@lothar.com>
3604 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3605 * docs/buildbot.texinfo: set version number to match
3607 2005-10-24 Brian Warner <warner@lothar.com>
3609 * README: update for 0.7.0
3611 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3613 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3614 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3615 send the branch= argument unless the user really provided one, to
3616 retain compatibility with older buildmasters that don't accept
3618 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3621 * docs/buildbot.texinfo: update lots of stuff
3623 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3624 to the 'buildbot sendchange' command
3625 * buildbot/clients/sendchange.py (Sender.send): same
3626 * buildbot/changes/pb.py (ChangePerspective): same
3627 * buildbot/test/test_changes.py (Sender.testSender): test it
3629 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3630 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3631 for consistency with other BuildStep arguments that use camelCase.
3632 Well, at least more of them use camelCase (like flunkOnWarnings)
3633 than don't.. I wish I'd picked one style and stuck with it
3634 earlier. Annoying, but it's best done before the release, since
3635 these arguments didn't exist at all in 0.6.6 .
3637 * buildbot/test/test_vc.py (SVN.testCheckout): same
3638 (Darcs.testPatch): same
3639 * docs/buildbot.texinfo (SVN): document the change
3640 (Darcs): same, add some build-on-branch docs
3641 * docs/examples/twisted_master.cfg: match change
3643 * buildbot/process/step.py (BuildStep): rename
3644 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3645 how it is normally used.
3646 * buildbot/test/test_steps.py (Version.checkCompare): same
3648 * buildbot/process/step.py (CVS.startVC): refuse to build
3649 update/copy -style builds on a non-default branch with an old
3650 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3651 concern is that it will do a VC 'update' in an existing tree when
3652 it is supposed to be switching branches (and therefore clobbering
3653 the tree to do a full checkout), thus building the wrong source.
3654 This used to be a warning, but I think the confusion it is likely
3655 to cause warrants making it an error.
3656 (SVN.startVC): same, also make mode=export on old slaves an error
3657 (Darcs.startVC): same
3658 (Git.startVC): improve error message for non-Git-enabled slaves
3659 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3660 specific revision is built on a slave that doesn't pay attention
3661 to args['revision'], because for slowly-changing trees it will
3662 probably do the right thing, and because we have no way to tell
3663 whether we're asking it to build the most recent version or not.
3664 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3666 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3667 that 'master' is in host:portnum format, to catch errors sooner
3669 2005-10-23 Brian Warner <warner@lothar.com>
3671 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3672 when creating the list of warning messages, include the line
3673 immediately after each WARNING: line, since that's usually where
3674 the file and line number wind up.
3676 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3681 2005-10-22 Brian Warner <warner@lothar.com>
3683 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3684 patch from Brad Hards
3685 * buildbot/status/classic.css: same
3686 * buildbot/test/test_web.py (Waterfall): match changes
3688 * buildbot/test/test_steps.py (BuildStep.setUp): set
3689 nextBuildNumber so the test passes
3690 * buildbot/test/test_status.py (MyBuilder): same
3692 * buildbot/status/html.py (StatusResourceBuild.body): revision
3693 might be numeric, so stringify it before html-escapifying it
3694 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3695 timer for the upcoming build
3696 * buildbot/status/classic.css: add background-color attributes for
3697 offline/waiting/building classes
3699 * buildbot/status/builder.py (BuildStatus): derive from
3700 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3701 the default (i.e. unknown) .slavename to "???" instead of None,
3702 since even unknown slavenames need to be printed eventually.
3703 (BuilderStatus): also derive from styles.Versioned . More
3704 importantly, determine .nextBuildNumber at creation/unpickling
3705 time by scanning the directory of saved BuildStatus instances and
3706 choosing one larger than the highest-numbered one found. This
3707 should fix the problem where random errors during upgrades cause
3708 the buildbot to forget about earlier builds. .nextBuildNumber is
3709 no longer stored in the pickle.
3710 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3711 at least log the error. Also call Builder.determineNextBuildNumber
3712 once the basedir is set.
3714 * buildbot/master.py (BuildMaster.loadChanges): do
3715 styles.doUpgrade afterwards, in case I decide to make Changes
3716 derived from styles.Versioned some day and forget to make this
3720 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3721 when running under older pythons (<2.3) in which the shlex module
3722 doesn't have a 'split' function.
3724 * buildbot/process/step.py (ShellCommand.start): make
3725 errorMessages= be a list of strings to stuff in the log before the
3726 command actually starts. This makes it easier to flag multiple
3727 warning messages, e.g. when the Source steps have to deal with an
3729 (CVS.startVC): handle slaves that don't handle multiple branches
3730 by switching into 'clobber' mode
3731 (SVN.startVC): same. Also reject branches without base_url
3732 (Darcs.startVC): same. Also reject revision= in older slaves
3733 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3734 (Bazaar.startVC): same, and test for baz separately than for arch
3736 * buildbot/slave/commands.py (cvs_ver): document new features
3738 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3739 (BuildStep.slaveVersionNewEnough): more useful utility method
3740 * buildbot/test/test_steps.py (Version): start testing it
3742 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3743 the 'force' command requires python2.3, for the shlex.split method
3745 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3746 since we don't use it anymore. The Twisted buildbot uses a
3749 2005-10-21 Brian Warner <warner@lothar.com>
3751 * buildbot/process/process_twisted.py: rework all BuildFactory
3752 classes to take a 'source' step as an argument, instead of
3753 building up the SVN instance in the factory.
3754 * docs/examples/twisted_master.cfg: enable build-on-branch by
3755 providing a base_url and default_branch
3757 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3758 control over --branch and --revision, not that they are always
3760 * buildbot/status/html.py (StatusResourceBuilder.force): same
3761 (StatusResourceBuild.body): display SourceStamp components
3763 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3764 IRC 'force' command, so it can be shared with an eventual
3765 command-line-tool 'buildbot force' mode.
3766 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3768 2005-10-20 Brian Warner <warner@lothar.com>
3770 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3772 * docs/examples/twisted_master.cfg: update to use Schedulers
3774 * buildbot/scripts/sample.cfg: update with Schedulers
3776 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3777 method specifically for use by HTML "force build" button and the
3778 IRC "force" command. Raises an immediate error if there are no
3780 (IBuilderControl.requestBuild): make this just submit a build, not
3781 try to check for existing slaves or set up any when-finished
3782 Deferreds or anything.
3783 * buildbot/process/builder.py (BuilderControl): same
3784 * buildbot/status/html.py (StatusResourceBuilder.force): same
3785 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3786 * buildbot/test/test_slaves.py: same
3787 * buildbot/test/test_web.py: same
3789 2005-10-19 Brian Warner <warner@lothar.com>
3791 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3792 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3794 2005-10-18 Brian Warner <warner@lothar.com>
3796 * buildbot/status/html.py: provide 'status' argument to most
3797 StatusResourceFOO objects
3798 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3799 and Logfiles" section to make the Build page into a more-or-less
3800 comprehensive source of status information about the build
3802 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3803 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3805 2005-10-17 Brian Warner <warner@lothar.com>
3807 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3808 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3809 out what to do about other projects: the correct options for
3810 recent Twisteds will not work for older ones.
3812 2005-10-15 Brian Warner <warner@lothar.com>
3814 * buildbot/status/builder.py (Status.getURLForThing): add method
3815 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3816 use this in email/IRC status clients to make them more useful, by
3817 providing the end user with hints on where to learn more about the
3818 object being reported on.
3819 * buildbot/test/test_web.py (GetURL): tests for it
3821 2005-10-14 Brian Warner <warner@lothar.com>
3823 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3824 fix bug resulting from deferredResult changes
3826 2005-10-13 Brian Warner <warner@lothar.com>
3828 * buildbot/test/test_changes.py: remove use of deferredResult
3829 * buildbot/test/test_config.py: same
3830 * buildbot/test/test_control.py: same
3831 * buildbot/test/test_status.py: same
3832 * buildbot/test/test_vc.py: this is the only remaining use, since
3833 it gets used at module level. This needs to be replaced by some
3834 sort of class-level run-once routine.
3836 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3838 * lots: implement multiple slaves per Builder, which means multiple
3839 current builds per Builder. Some highlights:
3840 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3841 of (state,currentBuilds) instead of (state,currentBuild)
3842 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3843 (IBuildStatus.getSlavename): new method, so you can tell which
3844 slave got used. This only gets set when the build completes.
3845 (IBuildRequestStatus.getBuilds): new method
3847 * buildbot/process/builder.py (SlaveBuilder): add a .state
3848 attribute to track things like ATTACHING and IDLE and BUILDING,
3850 (Builder): .. the .slaves attribute here, which has been turned
3851 into a simple list of available slaves. Added a separate
3852 attaching_slaves list to track ones that are not yet ready for
3854 (Builder.fireTestEvent): put off the test-event callback for a
3855 reactor turn, to make tests a bit more consistent.
3856 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3857 ping fails due to an exception. This needs work, I'm worried that
3858 a code error could lead to a constantly re-connecting slave.
3859 Especially since I'm trying to move to a distinct remote_ping
3860 method, separate from the remote_print that we currently use.
3861 (BuilderControl.requestBuild): return a convenience Deferred that
3862 provides an IBuildStatus when the build finishes.
3863 (BuilderControl.ping): ping all connected slaves, only return True
3864 if they all respond.
3866 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3867 reconnect when we shut down.
3869 * buildbot/status/builder.py: implement new methods, convert
3870 one-build-at-a-time methods to handle multiple builds
3871 * buildbot/status/*.py: do the same in all default status targets
3872 * buildbot/status/html.py: report the build's slavename in the
3873 per-Build page, report all buildslaves on the per-Builder page
3875 * buildbot/test/test_run.py: update/create tests
3876 * buildbot/test/test_slaves.py: same
3877 * buildbot/test/test_scheduler.py: remove stale test
3879 * docs/buildbot.texinfo: document the new builder-specification
3880 'slavenames' parameter
3882 2005-10-12 Brian Warner <warner@lothar.com>
3884 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3885 report failure correctly, causing Dependent builds to run when
3886 they shouldn't have.
3887 * buildbot/status/builder.py (BuildSetStatus): same
3888 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3889 (Set.testSuccess): test the both-pass case too
3890 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3891 fix this test: it was ending too early, masking the failure before
3892 (Logger): specialized StatusReceiver to make sure the dependent
3893 builds aren't even started, much less completed.
3895 2005-10-07 Brian Warner <warner@lothar.com>
3897 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3898 bot.SlaveBuilder being disowned in the middle of a build
3900 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3901 this inherit from StatusReceiver. Also upcall in __init__. This
3902 fixes the embarrasing crash when the new buildSetSubmitted method
3903 is invoked and Waterfall/etc don't implement their own.
3904 * buildbot/test/test_run.py: add a TODO note about a test to catch
3905 just this sort of thing.
3907 * buildbot/process/builder.py (Builder.attached): remove the
3908 already-attached warning, this situation is normal. Add some
3909 comments explaining it.
3911 2005-10-02 Brian Warner <warner@lothar.com>
3913 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3914 OverflowError when setting up dnotify, because some 64-bit systems
3915 have problems with signed-vs-unsigned constants and trip up on the
3916 DN_MULTISHOT flag. Patch from Brad Hards.
3918 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3920 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3921 progressMetrics, description, descriptionDone to the 'parms' list,
3922 and make use the 'parms' list from the implementation class
3923 instead of only BuildStep to initialize the parameters. This
3924 allows buildbot.process.factory.s() to initialize all the parms,
3925 not just those defined in directly by BuildStep.
3927 2005-09-03 Brian Warner <warner@lothar.com>
3929 * NEWS: start adding items for the next release
3931 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3932 python2.2 tests, change 'Quick' builder to only use python2.3
3934 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3936 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3937 the "Ping Builder" button if the build control is available; the
3938 user sees an exception otherwise
3940 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3942 2005-09-01 Brian Warner <warner@lothar.com>
3944 * buildbot/interfaces.py (IBuilderStatus.getState): update
3945 signature, point out that 'build' can be None
3946 (IBuildStatus.getETA): point out ETA can be none
3948 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3950 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3952 2005-08-31 Brian Warner <warner@lothar.com>
3954 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3955 update to match correct signature: removed 'eta' argument
3956 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3958 2005-08-30 Brian Warner <warner@lothar.com>
3960 * buildbot/status/builder.py (LogFile): remove the assertion that
3961 blows up when you try to overwrite an existing logfile, instead
3962 just emit a warning. This case gets hit when the buildmaster is
3963 killed and doesn't get a chance to write out the serialized
3964 BuilderStatus object, so the .nextBuildNumber attribute gets out
3967 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3968 the 'buildbot sendchange' arguments, for the Darcs context file
3969 * docs/buildbot.texinfo (sendchange): document it
3971 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3972 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3973 (IStatus.getSchedulers): new method
3974 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3975 (Status.getSchedulers): implement
3976 * buildbot/process/builder.py (Builder): maintain
3977 BuilderStatus.pendingBuilds
3978 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3979 (TryBase.addChange): Try schedulers should ignore Changes
3981 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3982 for 'try' on CVS/SVN
3983 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3985 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3986 report status properly.
3987 (Try.createJob): implement unique buildset IDs
3989 * buildbot/status/client.py (StatusClientPerspective): add a
3990 perspective_getBuildSets method for the benefit of jobdir-style
3992 * docs/buildbot.texinfo (try): more docs
3993 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3996 2005-08-18 Brian Warner <warner@lothar.com>
3998 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3999 actually work. It's functional but still kind of clunky. Also, it
4000 only works with the pb-style.. needs to be made to work with the
4003 * buildbot/status/client.py (RemoteBuildSet): new class
4004 (RemoteBuildRequest): same
4005 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
4006 object, not the internal BuildStatus object.
4007 (RemoteBuild.remote_subscribe): new method to subscribe to builds
4008 outside of the usual buildStarted() return value.
4009 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
4011 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
4012 (Try_Userpass_Perspective.perspective_try): return a remotely
4013 usable BuildSetStatus object
4015 * buildbot/interfaces.py (IBuildStatus): remove obsolete
4016 isStarted()/waitUntilStarted()
4018 2005-08-16 Brian Warner <warner@lothar.com>
4020 * buildbot/status/builder.py: implement IBuildSetStatus and
4021 IBuildRequestStatus, wire them into place.
4022 * buildbot/buildset.py: same. Add ID, move wait-until-finished
4023 methods into the BuildSetStatus object.
4024 * buildbot/interfaces.py: same
4025 (IStatus.getBuildSets): new method to get pending BuildSets
4026 (IStatusReceiver.buildsetSubmitted): new method which hears about
4028 * buildbot/master.py (BuildMaster.submitBuildSet): same
4029 * buildbot/process/base.py (BuildRequest): same, replace
4030 waitUntilStarted with subscribe/unsubscribe
4031 * buildbot/process/builder.py (BuilderControl.forceBuild): use
4032 subscribe instead of waitUntilStarted
4033 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
4035 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
4037 * buildbot/test/test_buildreq.py: update for new code
4038 * buildbot/test/test_control.py (Force.testRequest): same
4041 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
4042 for Darcs to not use the tempfile module, so it works under
4043 python-2.2 too. We really didn't need the full cleverness of that
4044 module, since the slave has exclusive control of its own builddir.
4046 2005-08-15 Brian Warner <warner@lothar.com>
4048 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
4049 for CVS trees. It doesn't work for non-trunk branches,
4051 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
4054 * Makefile: make it easier to test against python2.2
4056 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
4057 tearDown2, so things like Arch can unregister archives as they're
4058 shutting down. The previous subclass-override-tearDown technique
4059 resulted in a nested maybeWait() and test failures under
4062 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
4063 where we can (Arch), add a branch= argument to set the branch used
4065 (BazExtractor): extract the branch too
4066 (TlaExtractor): same
4067 * buildbot/scripts/runner.py (TryOptions): add --branch
4068 * docs/buildbot.texinfo (try): document --branch/try_branch
4070 * buildbot/slave/commands.py (Darcs): implement get-revision for
4071 Darcs, so that 'try' will work. This requires the tempfile module
4074 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
4075 of revisions, branches, and 'try' in the process.
4077 2005-08-11 Brian Warner <warner@lothar.com>
4079 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
4080 this, it got broken at some point in the last few releases
4081 * buildbot/status/words.py (IrcBuildRequest): reply was broken
4082 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
4083 specifically the removal of ETA information from the tuple
4085 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
4088 * docs/buildbot.texinfo (try): document both --builder and
4089 'try_builders' in .buildbot/options
4090 * buildbot/scripts/runner.py (TryOptions): add --builder,
4091 accumulate the values into opts['builders']
4092 * buildbot/scripts/tryclient.py (Try.__init__): set builders
4093 * buildbot/test/test_runner.py (Try): add some quick tests to make
4094 sure 'buildbot try --options' and .buildbot/options get parsed
4095 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
4096 use --builder control
4098 * docs/buildbot.texinfo (try): add --port argument to PB style
4100 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
4101 actual SourceStamp. Still need to extract a branch name, somehow.
4102 (Try): finish implementing the try client side, still need a UI
4103 for specifying which builders to use
4104 (Try.getopt): factor our options/config-file reading
4105 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
4107 * buildbot/test/test_vc.py: match SourceStampExtractor change
4109 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
4110 causes the twisted log to be sent to stderr
4112 * buildbot/scheduler.py (Try_Userpass): implement the PB style
4114 2005-08-10 Brian Warner <warner@lothar.com>
4116 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
4117 style is 90% done, still missing status reporting or waiting for
4118 the buildsets to finish, and it is completely untested.
4120 * buildbot/trybuild.py: delete file, move contents to ..
4121 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
4122 * buildbot/test/test_vc.py: match the move
4124 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
4125 of the TryScheduler, no buildsetID or status-tracking support yet
4126 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
4128 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
4129 possible to set the basedir after __init__ time, so it is easier
4130 to use as a Service-child of the BuildMaster instance
4132 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
4133 that delivers messages to its Service parent instead of requiring
4134 a subclass to be useful. This turns out to be much easier to build
4137 * buildbot/scripts/tryclient.py (createJob): utility code to
4138 create jobfiles, will eventually be used by 'buildbot try'
4140 2005-08-08 Brian Warner <warner@lothar.com>
4142 * docs/buildbot.texinfo (try): add docs on the
4143 as-yet-unimplemented Try scheduler
4145 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
4146 * buildbot/test/test_scheduler.py: .. here
4147 (Scheduling.testTryJobdir): add placeholder test for 'try'
4149 * buildbot/test/test_status.py (Log.testMerge3): update to match new
4150 addEntry merging (>=chunkSize) behavior
4151 (Log.testConsumer): update to handle new callLater(0) behavior
4153 * buildbot/test/test_web.py: rearrange tests a bit, add test for
4154 both the MAX_LENGTH bugfix and the resumeProducing hang.
4156 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
4157 put off the actual resumeProducing for a moment with
4158 reactor.callLater(0). This works around a twisted-1.3.0 bug which
4159 causes large logfiles to hang midway through.
4161 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
4162 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
4163 and to improve memory usage when streaming the file out to a web
4165 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
4166 make this work cleanly
4168 2005-08-03 Brian Warner <warner@lothar.com>
4170 * buildbot/trybuild.py: new file for 'try' utilities
4171 (getSourceStamp): run in a tree, find out the baserev+patch
4172 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
4173 implemented for SVN and Darcs, still working on Arch. I don't know
4174 how to make CVS work yet.
4176 * docs/buildbot.texinfo: document the 'buildbot' command-line
4177 tool, including the not-yet-implemented 'try' feature, and the
4178 in-flux .buildbot/ options directory.
4180 2005-07-20 Brian Warner <warner@lothar.com>
4182 * buildbot/locks.py: added temporary id() numbers to Lock
4183 descriptions, to track down a not-really-sharing-the-Lock bug
4185 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
4187 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
4188 needed for python2.2 compatibility
4189 * buildbot/test/test_vc.py: python2.2 compatibility: generators
4190 are from the __future__
4192 2005-07-19 Brian Warner <warner@lothar.com>
4194 * buildbot/master.py (BuildMaster.loadConfig): give a better error
4195 message when schedulers use unknown builders
4197 * buildbot/process/builder.py (Builder.compareToSetup): make sure
4198 SlaveLock('name') and MasterLock('name') are distinct
4200 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
4201 c['schedulers'] in such a way that we can actually accept
4203 * buildbot/test/test_config.py: check it
4205 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
4206 utility method to *all* the Schedulers
4207 (Periodic.listBuilderNames): same
4209 * docs/buildbot.texinfo (Interlocks): update chapter to match
4212 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
4213 to make sure that c['sources'], c['schedulers'], and c['status']
4214 are all lists of the appropriate objects, and that the Schedulers
4215 all point to real Builders
4216 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
4217 'listBuilderNames' utility method to support this
4218 * buildbot/scheduler.py: implement the utility method
4219 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
4221 * docs/buildbot.texinfo: add some @cindex entries
4223 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
4224 if it wasn't already set: most tla commands will fail unless one
4226 (Arch.createRepository): and disable bazaar's revision cache, since
4227 they cause test failures (the multiple repositories we create all
4228 interfere with each other through the cache)
4230 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
4231 bring it properly up to date with twisted-2.0 test guidelines
4233 * buildbot/master.py (BuildMaster): remove references to old
4234 'interlock' module, this caused a bunch of post-merge test
4236 * buildbot/test/test_config.py: same
4237 * buildbot/process/base.py (Build): same
4239 * buildbot/test/test_slaves.py: stubs for new test case
4241 * buildbot/scheduler.py: add test-case-name tag
4242 * buildbot/test/test_buildreq.py: same
4244 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
4245 unnecessary init code
4246 (Bot.remote_setBuilderList): match it
4248 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
4250 * buildbot/changes/mail.py (parseSyncmail): update comment
4252 * buildbot/test/test_slavecommand.py: disable Shell tests on
4253 platforms that don't suport IReactorProcess
4255 * buildbot/status/builder.py (LogFile): remove the 't' mode from
4256 all places where we open logfiles. It causes OS-X to open the file
4257 in some weird mode that that prevents us from mixing reads and
4258 writes to the same filehandle, which we depend upon to implement
4259 _generateChunks properly. This change doesn't appear to break
4260 win32, on which "b" and "t" are treated differently but a missing
4261 flag seems to be interpreted as "t".
4263 2005-07-18 Brian Warner <warner@lothar.com>
4265 * buildbot/slave/commands.py (ShellCommand): overhaul
4266 error-handling code, to try and make timeout/interrupt work
4267 properly, and make win32 happier
4268 * buildbot/test/test_slavecommand.py: clean up, stop using
4269 reactor.iterate, add tests for timeout and interrupt
4270 * buildbot/test/sleep.py: utility for a new timeout test
4272 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
4273 code from the local-usebranches branch
4275 2005-07-17 Brian Warner <warner@lothar.com>
4277 * buildbot/process/process_twisted.py
4278 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
4279 minutes, to match the other twisted BuildFactories, and don't
4280 excuse failures in c/qt/win32 reactors any more.
4282 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
4283 'freebsd' builders, since the buildslaves have been unavailable
4286 2005-07-13 Brian Warner <warner@lothar.com>
4288 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
4289 build-on-branch feature
4291 * buildbot/process/step.py (Darcs.__init__): add base_url and
4292 default_branch arguments, just like SVN
4293 (Arch.__init__): note that the version= argument is really the
4296 * buildbot/slave/commands.py (SourceBase): keep track of the
4297 repository+branch that was used for the last checkout in
4298 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
4299 match, we clobber the directory and perform a fresh checkout
4300 rather than trying to do an in-place update. This should protect
4301 us against trying to get to branch B by doing an update in a tree
4302 obtained from branch A.
4303 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
4304 (SVN.setup): same, just the svnurl
4305 (Darcs.setup): same, just the repourl
4306 (Arch.setup): same, arch coordinates (url), version, and
4307 buildconfig. Also pull the buildconfig from the args dictionary,
4308 which we weren't doing before, so the build-config was effectively
4310 (Arch.sourcedirIsUpdateable): don't try to update when we're
4311 moving to a specific revision: arch can't go backwards, so it is
4312 safer to just clobber the tree and checkout a new one at the
4314 (Bazaar.setup): same sourcedata as Arch
4316 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
4317 use maybeWait, to work with twisted-1.3.0 and twcompat
4318 (Dependencies.testRun_Pass): same
4320 * buildbot/test/test_vc.py: rearrange, cleanup
4322 * buildbot/twcompat.py: add defer.waitForDeferred and
4323 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
4324 can work under twisted-1.3.0 .
4326 * buildbot/test/test_vc.py: rewrite. The sample repositories are
4327 now created at setUp time. This increases the runtime of the test
4328 suite considerably (from 91 seconds to 151), but it removes the
4329 need for an offline tarball, which should solve a problem I've
4330 seen where the test host has a different version of svn than the
4331 tarball build host. The new code also validates that mode=update
4332 really picks up recent commits. This approach will also make it
4333 easier to test out branches, because the code which creates the VC
4334 branches is next to the code which uses them. It will also make it
4335 possible to test some change-notification hooks, by actually
4336 performing a VC commit and watching to see the ChangeSource get
4339 2005-07-12 Brian Warner <warner@lothar.com>
4341 * docs/buildbot.texinfo (SVN): add branches example
4342 * docs/Makefile (buildbot.ps): add target for postscript manual
4344 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
4345 * buildbot/test/test_locks.py: same
4347 * buildbot/process/step.py (Darcs): comment about default branches
4349 * buildbot/master.py (BuildMaster.loadConfig): don't look for
4350 c['interlocks'] in the config file, complain if it is present.
4351 Scan all locks in c['builders'] to make sure the Locks they use
4353 * buildbot/test/test_config.py: remove old c['interlocks'] test,
4354 add some tests to check for non-uniquely-named Locks
4355 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
4356 since the unique-Lock validation code requires it now
4358 * buildbot/locks.py: fix test-case-name
4360 * buildbot/interlock.py: remove old file
4362 2005-07-11 Brian Warner <warner@lothar.com>
4364 * buildbot/test/test_interlock.py: rename to..
4365 * buildbot/test/test_locks.py: .. something shorter
4367 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
4368 versions (after 2.0.1) changed internet.TCPClient to shut down the
4369 connection in stopService. Change the code to handle this
4372 * buildbot/process/base.py (Build): handle whole-Build locks
4373 * buildbot/process/builder.py (Builder.compareToSetup): same
4374 * buildbot/test/test_interlock.py: make tests work
4376 * buildbot/process/step.py (BuildStep.startStep): complain if a
4377 Step tries to claim a lock that's owned by its own Build
4378 (BuildStep.releaseLocks): typo
4380 * buildbot/locks.py (MasterLock): use ComparableMixin so config
4381 file reloads don't replace unchanged Builders
4383 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
4384 rewrite to cover new Locks instead of old c['interlocks']
4385 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
4389 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
4390 start the master and connect the buildslave
4392 * buildbot/process/step.py (FailingDummy.done): finish with a
4393 FAILURE status rather than raising an exception
4395 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
4396 stringify a BuildRequest.reason that is None
4398 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
4400 * buildbot/status/builder.py (BuildSetStatus): implement enough to
4401 allow scheduler.Dependent to work
4402 * buildbot/buildset.py (BuildSet): set .reason and .results
4404 * buildbot/test/test_interlock.py (Locks.setUp): connect both
4405 slaves, to make the test stop hanging. It still fails, of course,
4406 because I haven't even started to implement Locks.
4408 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
4410 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
4411 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
4412 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
4413 (Dependent): new class for downstream build dependencies
4414 * buildbot/test/test_dependencies.py: tests (still failing)
4416 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
4418 2005-07-07 Brian Warner <warner@lothar.com>
4420 * buildbot/test/runutils.py (RunMixin): factored this class out..
4421 * buildbot/test/test_run.py: .. from here
4422 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
4423 added new buildbot.locks tests (which all hang right now)
4424 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
4425 * buildbot/process/step.py: claim/release per-BuildStep locks
4427 * docs/Makefile: add 'buildbot.html' target
4429 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
4430 interpreted as "HEAD", so that all VC steps can accept branch=None
4431 and have it mean the "default branch".
4433 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
4435 2005-07-07 Brian Warner <warner@lothar.com>
4437 * docs/examples/twisted_master.cfg: update to match current usage
4439 * docs/buildbot.texinfo (System Architecture): comment out the
4440 image, it doesn't exist yet and just screws up the HTML manual.
4442 2005-07-05 Brian Warner <warner@lothar.com>
4444 * debian/.cvsignore: oops, missed one. Removing leftover file.
4446 2005-06-17 Brian Warner <warner@lothar.com>
4448 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
4449 changed its output in 1.2.0, don't mistakenly think that the
4450 subversion we find isn't capable of supporting our tests.
4452 * debian/*: remove the debian/ directory and its contents, to make
4453 life easier for the proper Debian maintainer
4455 * Makefile (release): same
4457 2005-06-07 Brian Warner <warner@lothar.com>
4459 * everything: create a distinct SourceStamp class to replace the
4460 ungainly 4-tuple, let it handle merging instead of BuildRequest.
4461 Changed the signature of Source.startVC to include the revision
4462 information (instead of passing it through self.args). Implement
4463 branches for SVN (now only Darcs/Git is missing support). Add more
4466 2005-06-06 Brian Warner <warner@lothar.com>
4468 * everything: rearrange build scheduling. Create a new Scheduler
4469 object (configured in c['schedulers'], which submit BuildSets to a
4470 set of Builders. Builders can now use multiple slaves. Builds can
4471 be run on alternate branches, either requested manually or driven
4472 by changes. This changed some of the Status classes. Interlocks
4473 are out of service until they've been properly split into Locks
4474 and Dependencies. treeStableTimer, isFileImportant, and
4475 periodicBuild have all been moved from the Builder to the
4477 (BuilderStatus.currentBigState): removed the 'waiting' and
4478 'interlocked' states, removed the 'ETA' argument.
4480 2005-05-24 Brian Warner <warner@lothar.com>
4482 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
4483 erroneously abandons the connection (in clientConnectionFailed)
4484 for non-UserErrors, which means that if we lose the connection due
4485 to a network problem or a timeout, we'll never try to reconnect.
4486 Fix this by not upcalling to the buggy parent method. Note:
4487 twisted-2.0 fixes this, but the function only has 3 lines so it
4488 makes more sense to copy it than to try and detect the buggyness
4489 of the parent class. Fixes SF#1207588.
4491 * buildbot/changes/changes.py (Change.branch): doh! Add a
4492 class-level attribute to accomodate old Change instances that were
4493 pickled before 0.6.5 (where .branch was added for new Changes).
4494 This fixes the exception that occurs when you try to look at an
4495 old Change (through asHTML).
4497 * buildbot/__init__.py (version): bump to 0.6.6+ while between
4500 2005-05-23 Brian Warner <warner@lothar.com>
4502 * buildbot/__init__.py (version): release 0.6.6
4504 2005-05-23 Brian Warner <warner@lothar.com>
4506 * NEWS: update for 0.6.6 release
4507 * debian/changelog: same
4509 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4510 before starting: this was done by twistd back when we spawned it,
4511 now that we're importing the pieces and running them in the
4512 current process, we have to do it ourselves. This allows
4513 master.cfg to import files from the same directory without
4514 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4515 Stichele for the catch.
4516 (Options.opt_version): Add a --version command (actually, just make
4517 the existing --version command emit Buildbot's version too)
4519 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4520 fix to make this behave like other LogFiles, this time to handle
4521 existing LogFiles on disk. (add the missing .upgrade method)
4522 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4524 2005-05-21 Brian Warner <warner@lothar.com>
4526 * buildbot/test/test_runner.py (Create.testMaster): match the
4527 rawstring change in runner.py:masterTAC
4529 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4530 TwistedWords is installed
4531 * buildbot/test/test_status.py: same, with TwistedMail
4533 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4534 some old, deprecated, and removed config keys). This should enable
4535 you to use the base buildbot functionality with Twisted-2.0.0 when
4536 you don't also have TwistedWeb and TwistedWords installed
4538 2005-05-20 Brian Warner <warner@lothar.com>
4540 * buildbot/scripts/runner.py (run): call sendchange(), not
4541 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4542 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4543 (stop): don't wait for process to die when sending SIGHUP
4544 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4545 directory name gets interpreted, which you don't want
4548 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4551 2005-05-18 Brian Warner <warner@lothar.com>
4553 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4555 2005-05-18 Brian Warner <warner@lothar.com>
4557 * README: update for 0.6.5
4558 * debian/changelog: same
4560 * buildbot/changes/changes.py: rename tag= to branch=, since
4561 that's how we're using it, and my design for the upcoming "build a
4562 specific branch" feature wants it. also, tag= was too CVS-centric
4563 * buildbot/changes/mail.py (parseSyncmail): same
4564 * buildbot/process/base.py (Build.isBranchImportant): same
4565 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4566 * docs/buildbot.texinfo (Attributes of Changes): same
4568 * NEWS: update tag=, update for upcoming release
4570 2005-05-17 Brian Warner <warner@lothar.com>
4572 * buildbot/scripts/runner.py (stop): actually poll once per
4573 second, instead of re-killing the poor daemon once per second.
4574 Sleep briefly (0.1s) before the first poll, since there's a good
4575 chance we can avoid waiting the full second if the daemon shuts
4576 down quickly. Also remove the sys.exit() at the end.
4577 (start): remove the unneighborly sys.exit()
4579 * Makefile: improve permission-setting to not kick Arch so badly
4581 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4582 default --keepalive=600, since it doesn't hurt very much, and it's
4583 a hassle to discover that you need it.
4584 * buildbot/test/test_runner.py (Create.testSlave): test it
4586 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4587 IRC bot about EXCEPTION
4589 * buildbot/status/client.py (PBListener): upcall more correctly
4591 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4592 an exception mark the overall build with EXCEPTION, not SUCCESS
4594 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4596 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4597 * Makefile: update some release-related stuff
4599 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4600 gets called when there isn't actually an active process, just end
4601 the Command instead of blowing up. I don't know how it gets into
4602 this state, but the twisted win32 buildslave will sometimes hang,
4603 and when it shakes its head and comes back, it thinks it's still
4604 running a Command. The next build causes this command to be
4605 interrupted, but the lack of self.process.pid breaks the interrupt
4608 * NEWS: document changes since the last release
4610 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4611 look for Makefile.buildbot instead of a bare Makefile . The
4612 'buildbot start' does not install this file, so you have to
4613 manually copy it if you want to customize startup behavior.
4614 (createMaster): change 'buildbot master' command to create
4615 Makefile.sample instead of Makefile, to create master.cfg.sample
4616 instead of master.cfg (requiring you to copy it before the
4617 buildmaster can be started). Both sample files are kept up to
4618 date, i.e. they are overwritten if they have been changed. The
4619 'buildbot.tac' file is *not* overwritten, but if the new contents
4620 don't match the old, a 'buildbot.tac.new' file is created and the
4621 user is warned. This seems to be a much more sane way to handle
4622 startup files. Also, don't sys.exit(0) when done, so we can run
4623 unit tests against it.
4624 (createSlave): same. Don't overwrite the sample info/ files.
4625 * buildbot/scripts/sample.mk: remove. the contents were pulled
4626 into runner.py, since they need to match the behavior of start()
4630 * docs/buildbot.texinfo (Launching the daemons): document it
4631 * buildbot/test/test_runner.py (Create): test it
4633 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4634 version that can handle string-in-string tests, because otherwise
4635 python-2.2 fails the tests. It'd be tremendous if Trial's test
4636 took two strings under 2.2 too.
4638 * everything: fixed all deprecation warnings when running against
4639 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4640 few that come from Twisted itself). This involved putting most of
4641 the Twisted-version specific code in the new buildbot.twcompat
4642 module, and creating some abstract base classes in
4643 buildbot.changes.base and buildbot.status.base (which might be
4644 useful anyway). __implements__ is a nuisance and requires an ugly
4645 'if' clause everywhere.
4647 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4648 delay before finishing the test: it seems that smtp.sendmail
4649 doesn't hang up on the server, so we must wait a moment so it can
4650 hang up on us. This removes the trial warning about an unclean
4653 2005-05-16 Brian Warner <warner@lothar.com>
4655 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4656 tuple of (delay, repeats).
4657 * buildbot/test/test_vc.py (Retry): test it
4658 * docs/buildbot.texinfo (Source Checkout): document it
4659 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4660 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4661 doVCFull() are handled by re-trying the checkout (after a delay)
4662 some number of times.
4663 (ShellCommand._startCommand): make header lines easier to read
4665 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4667 (WebTest.test_logfile): make sure master gets shut down, silences
4668 some "unclean reactor" test errors
4670 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4671 reactor once after shutdown, something in certain versions of
4672 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4673 fails, svn-trunk is ok.
4675 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4676 second win32 error message
4678 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4679 validating the ETA, so the tests don't fail on slow systems
4681 2005-05-15 Brian Warner <warner@lothar.com>
4683 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4684 the new LogFile class, so upgrading works properly
4685 (LogFileProducer.resumeProducing): survive resumeProducing after
4686 we've exhausted the chunkGenerator
4688 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4690 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4691 (Log.testUpgrade): same
4693 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4694 Builds and logs with a cron job.
4696 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4697 of the old non-offline LogFile, added code to upgrade these to
4698 new-style contents-live-on-disk instances at load time (in a way
4699 that doesn't invalidate the old Build pickles, so upgrading to
4700 0.6.5 is not a one-way operation). Got rid of everything related
4702 (LogFile.__init__): create LogFiles with the parent step status,
4703 the log's name, and a builder-relative filename where it can keep
4704 the contents on disk.
4705 (LogFile.hasContents): new method, clients are advised to call it
4706 before getText or getChunks and friends. If it returns False, the
4707 log's contents have been deleted and getText() will raise an
4709 (LogFile.getChunks): made it a generator
4710 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4711 Consumer (except one that takes chunks instead of strings). This
4712 enables streaming of very large logfiles without storing the whole
4714 (BuildStatus.generateLogfileName): create names like
4715 12-log-compile-output, with a _0 suffix if required to be unique
4716 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4717 or earlier) logfiles into new-style ones
4718 (BuilderStatus): remove everything related to 'stub' builds. There
4719 is now only one build cache, and we don't strip logs from old
4721 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4722 since we no longer fight to keep it in the cache
4724 * buildbot/status/html.py (TextLog.render_GET): use a
4725 ChunkConsumer to stream the log entries efficiently.
4726 (ChunkConsumer): wrapper which consumes chunks and writes
4729 * buildbot/test/test_twisted.py (Parse.testParse): use a
4730 LogFile-like object instead of a real one
4732 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4733 (Log.testMerge3): validate more merge behavior
4734 (Log.testChunks): validate LogFile.getChunks
4735 (Log.testUpgrade): validate old-style LogFile upgrading
4736 (Log.testSubscribe): validate LogFile.subscribe
4737 (Log.testConsumer): validate LogFile.subscribeConsumer
4739 * buildbot/interfaces.py (IStatusLogStub): remove
4740 (IStatusLog.subscribeConsumer): new method
4741 (IStatusLog.hasContents): new method
4742 (IStatusLogConsumer): describes things passed to subscribeConsumer
4744 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4745 the log contents if it does not have any contents.
4746 (StatusResourceBuildStep.body): same
4747 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4749 2005-05-14 Brian Warner <warner@lothar.com>
4751 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4752 timeouts to try and make the windows metabuildslave not hang
4754 2005-05-13 Mike Taylor <bear@code-bear.com>
4756 * buildbot/slave/commands.py (rmdirRecursive): added a check
4757 to ensure the path passed into rmdirRecursive actually exists.
4758 On win32 a non-existant path would generate an exception.
4760 2005-05-13 Brian Warner <warner@lothar.com>
4762 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4763 shutil.rmtree which behaves correctly on windows in the face of
4764 files that you have to chmod before deleting. Thanks to Bear at
4765 the OSAF for the routine.
4766 (SourceBase.doClobber): use rmdirRecursive
4768 2005-05-12 Brian Warner <warner@lothar.com>
4770 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4771 method generate chunks instead of returning a big list. This
4772 allows the same method to be used for both old LogFile and new
4774 (OfflineLogFile.getText): use the generator
4775 (OfflineLogFile.subscribe): same
4776 * buildbot/status/html.py (TextLog.resumeProducing): same
4777 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4779 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4780 point out that OfflineLogFile does not currently work with
4781 html.Waterfall . Fixing this is high-priority.
4783 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4784 apparently windows defaults to using stdout
4786 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4787 better message on failure so I can figure out the win32 problem
4789 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4790 log messages to include more useful copies of the command being
4791 run, the argv array, and the child command's environment.
4792 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4794 2005-05-11 Brian Warner <warner@lothar.com>
4796 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4798 * Makefile: update the deb-snapshot version
4800 * docs/buildbot.texinfo: move all .xhtml docs into a new
4801 .texinfo-format document, adding a lot of material in the process.
4802 This is starting to look like a real user's manual. Removed all
4803 the Lore-related files: *.xhtml, *.css, template.tpl .
4804 * docs/Makefile: simple makefile to run 'makeinfo'
4805 * buildbot/scripts/sample.cfg: rearrange slightly
4806 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4808 2005-05-10 Brian Warner <warner@lothar.com>
4810 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4811 different name for the internal twistw module, handle it.
4813 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4814 * setup.py: .. and stop trying to install it
4816 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4817 'git'), the new linux kernel VC system (http://kernel.org/git/).
4818 Thanks to Brandon Philips for the patch.
4819 * buildbot/slave/commands.py (Git): same
4821 2005-05-06 Brian Warner <warner@lothar.com>
4823 * buildbot/status/builder.py (OfflineLogFile): replace the default
4824 LogFile with a form that appends its new contents to a disk file
4825 as they arrive. The complete log data is never kept in RAM. This
4826 is the first step towards handling very large (100MB+) logfiles
4827 without choking quite so badly. (The other half is
4828 producer/consumer on the HTML pages).
4829 (BuildStepStatus.addLog): use OfflineLogFile by default
4830 (BuildStatus.getLogfileName): helper code to give the
4831 OfflineLogFile a filename to work with
4833 * buildbot/test/test_status.py (Results.testAddResults): update
4834 tests to handle new asserts
4835 * buildbot/test/test_vc.py (Patch.doPatch): same
4836 * buildbot/test/test_steps.py (BuildStep.setUp): same
4838 2005-05-05 Brian Warner <warner@lothar.com>
4840 * buildbot/scripts/runner.py (start): if there is no Makefile,
4841 launch the app by importing twistd's internals and calling run(),
4842 rather than spawning a new twistd process. This stands a much
4843 better chance of working under windows.
4844 (stop): kill the process with os.kill instead of spawning
4845 /bin/kill, again to reduce the number of external programs which
4846 windows might not have in the PATH. Also wait up to 5 seconds for
4847 the process to go away, allowing things like 'buildbot stop;
4848 buildbot start' to be reliable in the face of slow shutdowns.
4850 * buildbot/master.py (Dispatcher.__getstate__): remove old
4851 .tap-related methods
4852 (BuildMaster.__getstate__): same
4854 * buildbot/slave/bot.py (makeService): same
4855 (Options.longdesc): same
4856 * buildbot/scripts/runner.py: copy over some old mktap option text
4858 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4859 'buildbot master' now creates a buildbot.tac file, so there is no
4860 longer a create-instance/save/reload sequence. mktap is dead, long
4862 * buildbot/scripts/sample.mk: use twistd -y, not -f
4863 * buildbot/test/test_config.py: remove mktap-based test
4864 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4865 * README: don't reference mktap
4867 * docs/source.xhtml: document some of the attributes that Changes
4870 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4872 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4873 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4874 * buildbot/changes/changes.py (Change)
4875 * buildbot/changes/mail.py (parseSyncmail)
4876 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4878 * buildbot/process/base.py (Build.isTagImportant)
4882 2005-05-04 Brian Warner <warner@lothar.com>
4884 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4885 connection after sending the change, so that unit tests don't
4886 complain about sockets being left around
4888 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4889 exception in phase=0 rendering
4890 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4892 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4894 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4895 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4896 and configuring builders with tuples.
4897 * buildbot/test/test_config.py: stop testing compatibility with
4898 deprecated config keys
4899 * buildbot/test/test_run.py: same
4901 2005-05-03 Brian Warner <warner@lothar.com>
4903 * contrib/arch_buildbot.py: survive if there are no logfiles
4904 (username): just use a string, os.getlogin isn't reliable
4906 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4907 so 'buildbot sendchange' actually works. The earlier test only
4908 covered the internal (non-reactor-running) form.
4910 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4911 script to notify the buildmaster about changes
4913 * buildbot/scripts/runner.py (sendchange): new command to send a
4914 change to a buildbot.changes.pb.PBChangeSource receiver.
4915 * buildbot/test/test_changes.py (Sender): test it
4917 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4918 after any reading of the config file, not just when we do it in
4919 startService. This makes some tests a bit cleaner.
4921 * buildbot/changes/pb.py: add some log messages
4923 * buildbot/process/base.py (Build.startBuild): fix a bug that
4924 caused an exception when the build terminated in the very first
4926 (Build.stepDone): let steps return a status of EXCEPTION. This
4927 terminates the build right away, and sets the build's overall
4928 status to EXCEPTION too.
4929 * buildbot/process/step.py (BuildStep.failed): return a status of
4930 EXCEPTION when that is what has happened.
4932 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4933 implement this, allowing Arch-based projects to get precise
4934 checkouts instead of always using the latest code
4935 (Bazaar): create variant of Arch to let folks use baz instead of
4936 tla. Requires a new buildslave too.
4937 * buildbot/slave/commands.py (Arch): add 'revision' argument
4938 (Bazaar): create variant of Arch that uses baz instead of tla.
4939 Remove the code that extracts the archive name from the
4940 register-archive output, since baz doesn't provide it, and require
4941 the user provide both the archive name and its location.
4942 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4944 2005-05-02 Brian Warner <warner@lothar.com>
4946 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4947 thanks to Nick Trout.
4949 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4950 deals better with source Makefile coming from a read-only CVS
4951 checkout. Thanks to Nick Trout for the catch.
4953 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4956 2005-04-28 Brian Warner <warner@lothar.com>
4958 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4960 * debian/changelog: update for 0.6.4
4962 2005-04-28 Brian Warner <warner@lothar.com>
4964 * README.w32: add a checklist of steps for getting buildbot
4966 * MANIFEST.in: include it in the tarball
4970 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4971 broken .tap files from 0.6.3 by getting rid of .services,
4972 .namedServices, and .change_svc at load time.
4974 2005-04-27 Brian Warner <warner@lothar.com>
4976 * NEWS: update in preparation for new release
4978 * buildbot/test/test_config.py (Save.testSave): don't pull in
4979 twisted.scripts.twistd, we don't need it and it isn't for windows
4982 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4983 accomodate win32 which can't do atomic-rename
4985 2005-04-27 Brian Warner <warner@lothar.com>
4987 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4988 timeouts to help the slow metabuildbot not flunk them so much
4989 (Disconnect.testBuild3): same
4990 (Disconnect.testBuild4): same
4991 (Disconnect.testInterrupt): same
4993 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4994 setup, it was completely broken for new buildmasters (those which
4995 did not have a 'change.pck' already saved. Thanks to Paul Warren
4996 for catching this (embarrassing!) bug.
4997 (Dispatcher.__getstate__): don't save our registered avatar
4998 factories, since they'll be re-populated when the config file is
5000 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
5001 tests (since the real mktap-generated BuildMaster doesn't save
5003 (BuildMaster.__getstate__): don't save any service children,
5004 they'll all be re-populated when the config file is re-read.
5005 * buildbot/test/test_config.py (Save.testSave): test for this
5007 2005-04-26 Brian Warner <warner@lothar.com>
5009 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
5010 rendered with Blender.. looks a bit nicer.
5011 * buildbot/docs/images/icon.blend: add the Blender file for it
5013 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
5014 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
5015 running under windows. This appears to be the best way to allow
5016 BuildSteps to do something normal like 'trial -v buildbot.test' or
5017 'make foo' and still expect it to work. The idea is to make the
5018 BuildSteps look as much like what a developer would type when
5019 compiling or testing the tree by hand. This approach probably has
5020 problems when there are spaces in the arguments, so if you've got
5021 windows buildslaves, you'll need to pay close attention to your
5024 * buildbot/status/html.py (WaterfallStatusResource.body): add the
5025 timezone to the timestamp column.
5026 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5028 * buildbot/scripts/runner.py (loadOptions): do something sane for
5029 windows, I think. We use %APPDATA%/buildbot instead of
5030 ~/.buildbot, but we still search everywhere from the current
5031 directory up to the root for a .buildbot/ subdir. The "is it under
5032 $HOME" security test was replaced with "is it owned by the current
5033 user", which is only performed under posix.
5034 * buildbot/test/test_runner.py (Options.testFindOptions): update
5035 tests to match. The "is it owned by the current user" check is
5036 untested. The test has been re-enabled for windows.
5038 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
5039 any "\n" in the expected output with the platform-specific line
5040 separator. Make this separator "\r\n" on PTYs under unix, they
5041 seem to do that and I don't know why
5043 * buildbot/test/test_runner.py (Options.optionsFile): disable on
5044 windows for now, I don't know what ~/.buildbot/ should mean there.
5046 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
5047 win32 compatibility, don't use "/tmp"
5048 (Basedir.testChangeBuilddir): remove more unixisms
5050 2005-04-26 Brian Warner <warner@lothar.com>
5052 * buildbot/test/test_control.py (Force.rmtree): python2.2
5053 compatibility, apparently its shutil.rmtree ignore_errors=
5054 argument is ignored.
5055 * buildbot/test/test_run.py (Run.rmtree): same
5056 (RunMixin.setUp): same
5058 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
5061 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
5062 'substring in string' operator, must use string.find(substr)!=-1
5063 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
5064 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
5066 * buildbot/scripts/runner.py (loadOptions): add code to search for
5067 ~/.buildbot/, a directory with things like 'options', containing
5068 defaults for various 'buildbot' subcommands. .buildbot/ can be in
5069 the current directory, your $HOME directory, or anywhere
5070 inbetween, as long as you're somewhere inside your home directory.
5071 (debugclient): look in ~/.buildbot/options for master and passwd
5072 (statuslog): look in ~/.buildbot/options for 'masterstatus'
5073 * buildbot/test/test_runner.py (Options.testFindOptions): test it
5075 * buildbot/status/client.py (makeRemote): new approach to making
5076 IRemote(None) be None, which works under Twisted-2.0
5077 * buildbot/test/test_status.py (Client.testAdaptation): test it
5079 * buildbot/status/builder.py (Status.builderAdded): when loading a
5080 pickled BuilderStatus in from disk, set its name after loading.
5081 The config file might have changed its name (but not its
5082 directory) while it wasn't looking.
5084 * buildbot/process/builder.py (Builder.attached): always return a
5085 Deferred, even if the builder was already attached
5086 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
5088 2005-04-25 Brian Warner <warner@lothar.com>
5090 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
5091 category-related exception when announcing a build has finished
5093 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
5094 reference no-longer-existent changemaster.sources
5095 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
5097 * buildbot/__init__.py (version): bump to 0.6.3+ while between
5100 2005-04-25 Brian Warner <warner@lothar.com>
5102 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
5104 * debian/changelog: update for 0.6.3
5106 2005-04-25 Brian Warner <warner@lothar.com>
5108 * MANIFEST.in: make sure debug.glade is in the tarball
5110 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
5112 * NEWS: update for the imminent 0.6.3 release
5114 * buildbot/status/html.py (HtmlResource.content): make the
5115 stylesheet <link> always point at "buildbot.css".
5116 (StatusResource.getChild): map "buildbot.css" to a static.File
5117 containing whatever css= argument was provided to Waterfall()
5118 (Waterfall): provide the "classic" css as the default.
5119 * docs/waterfall.classic.css: move default CSS from here ..
5120 * buildbot/status/classic.css: .. to here
5122 * MANIFEST.in: make sure classic.css is included in the tarball
5123 * setup.py: and that it is installed too, under buildbot/status/
5125 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
5126 the module level, because buildbot.tap files from 0.6.2 don't have
5127 it in their attribute dictionary.
5129 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
5130 really exists at startup, might save some confusion somewhere.
5132 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
5134 * docs/waterfall.classic.css:
5135 add a stylesheet that's almost the same as the "classic"
5138 * buildbot/status/builder.py:
5139 add EXCEPTION as a result - this is a problem for the bot
5140 maintainer, not a build problem for the changers
5141 * buildbot/process/step.py:
5142 use EXCEPTION instead of FAILURE for exceptions
5143 * buildbot/status/html.py:
5144 add build_get_class to get a class out of a build/buildstep
5145 finish naming the classes
5146 split out sourceNames to changeNames and builderNames so we
5147 can style them separately
5148 * docs/config.xhtml:
5149 finish documenting classes as they are right now
5151 * buildbot/status/html.py:
5152 name the classes as we agreed on IRC
5153 * docs/config.xhtml:
5156 * buildbot/status/html.py:
5157 same for cssclass->class_
5159 * buildbot/status/html.py:
5160 as decided on IRC, use class_ for the "class" attribute to not
5161 conflict with the class keyword, and clean up the messy **{} stuff.
5163 * buildbot/status/mail.py:
5164 put back "builders" argument, and fix docstring, because the
5165 code *ignores* builders listed in this argument
5167 * buildbot/process/builder.py:
5168 remove FIXME notes - category is now indeed a cvar of BuilderStatus
5170 * docs/config.xhtml:
5171 describe the category argument for builders
5173 * buildbot/status/builder.py:
5174 Fix a silly bug due to merging
5176 * buildbot/process/builder.py:
5177 remove category from the process Builder ...
5178 * buildbot/status/builder.py:
5179 ... and add it to BuilderStatus instead.
5180 Set category on unpickled builder statuses, they might not have it.
5181 * buildbot/master.py:
5182 include category when doing builderAdded
5183 * buildbot/status/mail.py:
5184 return None instead of self for builders we are not interested in.
5185 * buildbot/test/test_run.py:
5186 fix a bug due to only doing deferredResult on "dummy" waiting
5187 * buildbot/test/test_status.py:
5188 add checks for the Mail IStatusReceiver returning None or self
5190 * buildbot/status/html.py:
5191 fix testsuite by prefixing page title with BuildBot
5193 * buildbot/status/builder.py:
5194 have .category in builder status ...
5195 * buildbot/process/builder.py:
5196 ... and set it from Builder
5197 * buildbot/status/html.py:
5198 make .css a class variable
5199 * buildbot/test/test_status.py:
5200 write more tests to cover our categories stuff ...
5201 * buildbot/status/mail.py:
5202 ... and fix the bug that this uncovered
5204 * buildbot/changes/mail.py:
5205 * buildbot/changes/pb.py:
5206 * buildbot/master.py:
5207 * buildbot/process/base.py:
5208 * buildbot/process/factory.py:
5209 * buildbot/process/interlock.py:
5210 * buildbot/process/step.py:
5211 * buildbot/process/step_twisted.py:
5212 * buildbot/slave/commands.py:
5213 * buildbot/status/builder.py:
5214 * buildbot/status/client.py:
5215 * buildbot/status/html.py:
5216 * buildbot/status/mail.py:
5217 * buildbot/status/progress.py:
5218 * buildbot/test/test_changes.py:
5219 * buildbot/test/test_config.py:
5220 * buildbot/test/test_control.py:
5221 * buildbot/test/test_interlock.py:
5222 * buildbot/test/test_maildir.py:
5223 * buildbot/test/test_mailparse.py:
5224 * buildbot/test/test_run.py:
5225 * buildbot/test/test_slavecommand.py:
5226 * buildbot/test/test_status.py:
5227 * buildbot/test/test_steps.py:
5228 * buildbot/test/test_twisted.py:
5229 * buildbot/test/test_util.py:
5230 * buildbot/test/test_vc.py:
5231 * buildbot/test/test_web.py:
5233 add test-case-name at the top of a whole set of files
5235 * buildbot/status/builder.py:
5236 keep order of addition when getting builder names
5237 * buildbot/status/words.py:
5238 * buildbot/test/test_run.py:
5239 add test for getBuilderNames
5241 * buildbot/process/base.py:
5242 * buildbot/process/step.py:
5243 * buildbot/status/builder.py:
5244 * buildbot/status/html.py:
5245 make buildbot css-able
5246 replace the color code for purple with purple, don't understand
5247 why it wasn't purple to start with
5249 * buildbot/status/words.py:
5250 ok, so it doesn't look like BuilderStatus.remote is still valid.
5251 Use what waterfall uses instead.
5253 * buildbot/interfaces.py:
5254 * buildbot/status/builder.py:
5255 * buildbot/status/html.py:
5256 * buildbot/status/mail.py:
5257 * buildbot/status/words.py:
5258 * buildbot/test/test_run.py:
5259 use categories everywhere and make it be a list. More sensible
5260 for the future. Also make words actually respect this in
5263 * buildbot/interfaces.py:
5264 add category argument to getBuilderNames
5265 * buildbot/process/builder.py:
5266 * buildbot/status/builder.py:
5267 * buildbot/status/html.py:
5268 * buildbot/status/mail.py:
5269 * buildbot/status/words.py:
5270 * buildbot/test/test_run.py:
5271 move from specifying builders by name to specifying the category
5273 * buildbot/status/html.py:
5274 * buildbot/status/words.py:
5275 add "builders=" to __init__ of status clients so they can
5276 limit themselves to the given list of builders to report on
5278 * buildbot/status/html.py: set the title to the product name
5280 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
5282 * buildbot/interfaces.py:
5283 * buildbot/status/builder.py:
5284 more documentation. Hm, not sure if ChangeLog entries make sense
5287 2005-04-23 Brian Warner <warner@lothar.com>
5289 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
5291 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
5293 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
5294 the sub-commands that log buildmaster status to stdout and to a
5295 GUI window, respectively.
5297 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
5298 functionality is working again, but all the step-status and ETA
5299 stuff is missing. Commented out a lot of code pending more
5302 * buildbot/status/client.py: make sure that IRemote(None) is None
5304 * buildbot/changes/changes.py: import defer, oops
5305 (ChangeMaster): remove the .sources list, rely upon the fact that
5306 MultiServices can be treated as sequences of their children. This
5307 cleans up the add/remove ChangeSource routines a lot, as we keep
5308 exactly one list of the current sources instead of three.
5310 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
5311 up an empty ChangeMaster at init time.
5312 (BuildMaster.loadChanges): if there are changes to be had from
5313 disk, replace self.change_svc with the new ones. If not, keep
5314 using the empty ChangeMaster set up in __init__.
5315 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
5316 instead of a separate list, makes the code a bit cleaner.
5317 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
5318 (ConfigTest.testSources): same, also wait for loadConfig to finish.
5319 Extend the test to make sure we can get rid of the sources when
5322 2005-04-22 Brian Warner <warner@lothar.com>
5324 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
5325 and info/host files when making the slave directory
5327 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
5328 whendone= argument, just return the Deferred and let the caller do
5329 what they want with it.
5330 (Disconnect.testBuild1): wait for shutdownSlave
5331 (Basedir.testChangeBuilddir): new test to make sure changes to the
5332 builddir actually get propagated to the slave
5334 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
5335 explicit method, rather than passing the builddir in __init__ .
5336 Make sure to update self.basedir too, this was broken before.
5337 (Bot.remote_setBuilderList): use b.setBuilddir for both new
5338 builders and for ones that have just had their builddir changed.
5339 (BotFactory): add a class-level .perspective attribute, so
5340 BuildSlave.waitUntilDisconnected won't get upset when the
5341 connection hasn't yet been established
5342 (BuildSlave.__init__): keep track of the bot.Bot instance, so
5343 tests can reach through it to inspect the SlaveBuilders
5345 * buildbot/process/base.py (Build.buildException): explain the
5346 log.err with a log.msg
5347 * buildbot/process/builder.py (Builder.startBuild): same
5348 (Builder._startBuildFailed): improve error message
5350 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
5351 occurred because we lost the brand-new connection, retry instead
5352 of giving up. If not, it's probably an authorization failure, and
5353 it makes sense to stop trying. Make sure we log.msg the reason
5354 that we're log.err'ing the failure, otherwise test failures are
5355 really hard to figure out.
5357 * buildbot/master.py: change loadConfig() to return a Deferred
5358 that doesn't fire until the change has been fully implemented.
5359 This means any connected slaves have been updated with the new
5360 builddir. This change makes it easier to test the code which
5361 actually implements this builddir-updating.
5362 (BotPerspective.addBuilder): return Deferred
5363 (BotPerspective.removeBuilder): same
5364 (BotPerspective.attached): same
5365 (BotPerspective._attached): same. finish with remote_print before
5366 starting the getSlaveInfo, instead of doing them in parallel
5367 (BotPerspective.list_done): same
5368 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
5369 actually calling slave.disconnect()
5370 (BotMaster.addBuilder): same
5371 (BotMaster.removeBuilder): same
5372 (BuildMaster.loadConfig): same
5373 (BuildMaster.loadConfig_Slaves): same
5374 (BuildMaster.loadConfig_Sources): same
5375 (BuildMaster.loadConfig_Builders): same
5376 (BuildMaster.loadConfig_status): same
5378 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
5379 a Deferred that fires when the source is finally removed
5381 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
5382 the previous tree on win32, where we have to do it synchronously,
5383 make sure we return a Deferred anyway.
5384 (SourceBase.doCopy): same
5386 * buildbot/scripts/runner.py (statusgui): use the text client for
5387 now, while I rewrite the Gtk one
5388 * buildbot/clients/base.py: strip out old code, leaving just the
5389 basic print-message-on-event functionality. I also remove the
5390 ReconnectingPBClientFactory, but it does at least quit when it
5391 loses the connection instead of going silent
5393 2005-04-21 Brian Warner <warner@lothar.com>
5395 * Makefile: minor tweaks
5397 * NEWS: point out deprecation warnings, new features for
5400 * buildbot/master.py (BuildMaster.loadConfig): emit
5401 DeprecationWarnings for Builders defined with tuples. Rearrange
5402 code to facility removal of deprecated configuration keys in the
5405 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
5406 'buildbot' command to put a little Makefile in the target that
5407 helps you re-create the buildbot.tap file, start or stop the
5408 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
5409 all the files 0600, since they contain passwords.
5410 (start): if there is a Makefile, and /usr/bin/make exists, use
5411 'make start' in preference to a raw twistd command. This lets
5412 slave admins put things like PYTHONPATH variables in their
5413 Makefiles and have them still work when the slave is started with
5414 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
5415 be nice to first try the 'make' command and only fall back to
5416 twistd if it fails. TODO: the Makefile's "start" command does not
5417 add the --reactor=win32 argument when running under windows.
5418 (Options.debugclient, Options.statusgui): add sub-commands to launch
5419 the debug client (formerly in contrib/debugclient.py) and the
5420 Gtk status application (currently broken)
5421 * buildbot/clients/debug.py: move from contrib/debugclient.py
5422 * buildbot/clients/debug.glade: same
5424 * buildbot/test/test_trial.py: remove it. This requires some
5425 functionality out of Twisted that isn't there yet, and until then
5426 having it around just confuses things.
5428 * buildbot/test/test_slavecommand.py (Shell): test both with and
5429 without PTYs, and make sure that command output is properly
5430 interleaved in the with-PTY case. I think the without-PTY test
5431 should pass on windows, where we never use PTYs anyway.
5433 2005-04-20 Brian Warner <warner@lothar.com>
5435 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
5437 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
5439 * NEWS: start creating entries for the next release
5441 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
5443 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
5444 (WebTest.test_webPathname): same
5445 (WebTest.test_webPathname_port): same
5446 (WebTest.test_waterfall): use the default favicon rather than
5447 rooting around the filesystem for it. Open the expected-icon file
5448 in binary mode, to make win32 tests happier (thanks to Nick Trout
5450 * buildbot/status/html.py (buildbot_icon): win32 portability
5452 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
5453 win32-compatibility fixes from Nick Trout, the "file not found" message
5454 is different under windows
5455 (FakeSlaveBuilder.__init__): clean up setup a bit
5456 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
5458 2005-04-19 Brian Warner <warner@lothar.com>
5460 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
5461 skip-if-repositories-are-unavailable test to not kill the trial
5462 that comes with Twisted-1.3.0
5464 * setup.py: install buildbot.png icon file when installing code
5466 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
5467 environment used by the command, at least on the child side.
5469 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
5470 this method needs to be added and implemented because it gets
5471 called under heavy load. I don't quite understand the
5472 producer/consumer API enough to write it.
5473 (StatusResource.getChild): add a resource for /favicon.ico
5474 (Waterfall.__init__): add favicon= argument
5475 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5476 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
5477 (WebTest.test_webPathname): same
5478 (WebTest.test_webPathname_port): same
5479 * docs/config.xhtml: mention favicon=
5480 * buildbot/buildbot.png: add a default icon, dorky as it is
5482 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
5484 * buildbot/master.py:
5485 * buildbot/process/base.py:
5486 * buildbot/process/builder.py:
5487 * buildbot/process/interlock.py:
5488 * buildbot/status/builder.py:
5489 * buildbot/status/html.py:
5490 * buildbot/status/mail.py:
5491 * buildbot/status/words.py:
5492 new documentation while digging through the code
5494 2005-04-17 Brian Warner <warner@lothar.com>
5496 * general: try to fix file modes on all .py files: a+r, a-x,
5497 but let buildbot/clients/*.py be +x since they're tools
5499 * docs/epyrun (addMod): when an import fails, say why
5501 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
5503 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5505 * buildbot/process/base.py:
5506 * buildbot/process/builder.py:
5507 * buildbot/status/builder.py:
5508 new documentation while digging through the code
5510 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5512 * buildbot/changes/changes.py:
5513 * buildbot/changes/p4poller.py:
5514 * buildbot/interfaces.py:
5515 * buildbot/process/base.py:
5516 * buildbot/process/builder.py:
5517 * buildbot/process/step.py:
5518 * buildbot/process/step_twisted.py:
5519 * buildbot/slave/bot.py:
5520 * buildbot/slave/commands.py:
5521 * buildbot/status/builder.py:
5522 fix all docstrings to make epydoc happy. In the process of fixing
5523 some, I also moved pieces of docs, and removed some deprecated
5526 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5528 * buildbot/process/builder.py:
5529 * buildbot/process/interlock.py:
5530 * buildbot/process/process_twisted.py:
5531 * buildbot/process/step.py:
5532 BuildProcess -> Build, as it looks like that's what happened
5533 * buildbot/process/base.py:
5534 * buildbot/process/factory.py:
5537 2005-04-17 Brian Warner <warner@lothar.com>
5539 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5540 update compile command to accomodate the Twisted split.. now
5541 instead of './setup.py build_ext -i', you do './setup.py all
5542 build_ext -i', to run build_ext over all sub-projects.
5543 (FullTwistedBuildFactory): same
5544 (TwistedReactorsBuildFactory): same
5546 * buildbot/status/html.py (TextLog.finished): null out self.req
5547 when we're done, otherwise the reference cycle of TextLog to .req
5548 to .notifications to a Deferred to TextLog.stop keeps them from
5549 being collected, and consumes a huge (610MB on pyramid at last
5550 check) amount of memory.
5552 2005-04-11 Brian Warner <warner@lothar.com>
5554 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5555 normalize the VC-repository location.. makes SVN happier with
5556 certain test environments.
5558 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5559 RemoteShellCommand gets its own .env dictionary, so that code in
5560 start() doesn't mutate the original. I think this should fix the
5561 step_twisted.Trial problem where multiple identical components
5562 kept getting added to PYTHONPATH= over and over again.
5564 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5565 adding epydoc-format docstrings to many classes. Thanks to Thomas
5566 Vander Stichele for the patches.
5567 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5568 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5569 * buildbot/slave/bot.py, commands.py, registry.py: same
5571 2005-04-05 Brian Warner <warner@lothar.com>
5573 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5574 preserve timestamps, helps incremental builds of large trees.
5575 Patch from Rene Rivera.
5577 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5578 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5581 2005-04-03 Brian Warner <warner@lothar.com>
5583 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5584 with one dict, apparently exec has some scoping bugs when used
5585 with both global/local dicts. Thanks to Nathaniel Smith for the
5588 2005-04-02 Brian Warner <warner@lothar.com>
5590 * buildbot/process/step_twisted.py (countFailedTests): the new
5591 trial in Twisted-2.0 emits a slightly different status line than
5592 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5593 mistakenly think the test count is unparseable.
5594 (Trial.start): note that for some reason each build causes another
5595 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5596 be fixed but I'm not sure quite where the problem is.
5598 2005-04-01 Brian Warner <warner@lothar.com>
5600 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5601 deferredResult to avoid hangs/warnings under twisted-2.0
5602 (RunMixin.tearDown): same
5603 (RunMixin.shutdownSlave): same
5604 (Disconnect.testIdle1): same
5605 (Disconnect.testBuild2): same: wait one second after the build
5606 finishes for test to really be done.. this should be cleaned up to
5607 avoid wasting that second. Builder.detach uses a callLater(0),
5608 either that should be done in-line (something else needed that
5609 behavior), or it should return a Deferred that fires when the
5610 builder is really offline.
5611 (Disconnect.testBuild3): same
5612 (Disconnect.testDisappear): same
5614 * buildbot/test/test_web.py: rearrange server-setup and teardown
5615 code to remove unclean-reactor warnings from twisted-2.0
5617 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5618 so the tests don't hang under twisted-2.0
5620 2005-03-31 Brian Warner <warner@lothar.com>
5622 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5623 caused a warning each time the master changed our set of builders
5625 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5626 w32, don't unlink the file unless it already exists. Thanks to
5627 Baptiste Lepilleur for the catch.
5628 (BuilderStatus.saveYourself): same
5630 2005-02-01 Brian Warner <warner@lothar.com>
5632 * buildbot/status/html.py (TextLog.getChild): use a /text child
5633 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5634 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5635 logfile as text/plain (no markup, no headers). This replaces the
5636 previous scheme (which used an ?text=1 argument), and gets us back
5637 to a relative link (which works better when the buildbot lives
5638 behind another web server, such as Apache configured as a reverse
5639 proxy). Thanks to Gerald Combs for spotting the problem.
5641 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5644 2004-12-13 Brian Warner <warner@lothar.com>
5646 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5648 * debian/changelog: update for 0.6.2
5649 * NEWS: finalize for 0.6.2
5651 2004-12-11 Brian Warner <warner@lothar.com>
5653 * NEWS: bring it up to date
5655 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5656 detection code. Require some sign of life from the buildmaster
5657 every BotFactory.keepaliveInterval seconds. Provoke this
5658 indication at BotFactory.keepaliveTimeout seconds before the
5659 deadline by sending a keepalive request. We don't actually care if
5660 that request is answered in a timely fashion, what we care about
5661 is that .activity() is called before the deadline. .activity() is
5662 triggered by any PB message from the master (including an ack to
5663 one of the slave's status-update messages). With this new scheme,
5664 large status messages over slow pipes are OK, as long as any given
5665 message can be sent (and thus acked) within .keepaliveTimeout
5666 seconds (which defaults to 30).
5667 (SlaveBuilder.remote_startCommand): record activity
5668 (SlaveBuilder.ackUpdate): same
5669 (SlaveBuilder.ackComplete): same
5670 (BotFactory.gotPerspective): same
5671 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5673 2004-12-09 Brian Warner <warner@lothar.com>
5675 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5678 * buildbot/process/step_twisted.py (Trial._commandComplete):
5679 update self.cmd when we start the 'cat test.log' transfer. Without
5680 this, we cannot interrupt the correct RemoteCommand when we lose
5683 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5684 trying to tell the slave to stop the command if we're already
5685 inactive, or if we no longer have a .remote
5687 * buildbot/process/builder.py (Builder._detached): don't let an
5688 exception in currentBuild.stopBuild() prevent the builder from
5689 being marked offline
5691 2004-12-07 Brian Warner <warner@lothar.com>
5693 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5694 KeyError that happens when you ask for a non-existent Builder, and
5695 translate it into a UsageError.
5697 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5698 losing the slave in the middle of a remote step is handled too
5700 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5701 be a Failure, so be sure to stringify it before using it as the
5702 contents of the 'interrupt' logfile
5703 (RemoteCommand.interrupt): use stringified 'why' in
5704 remote_interruptCommand too, just in case
5706 2004-12-06 Brian Warner <warner@lothar.com>
5708 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5709 instead of 'tla update', which is more efficient in case we've
5710 missed a couple of patches since the last update.
5712 * debian/changelog: update for previous (0.6.1) release. Obviously
5713 this needs to be handled better.
5715 2004-12-05 Brian Warner <warner@lothar.com>
5717 * NEWS: update for stuff since last release
5719 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5720 match the maybeDeferred change in Dispatcher.requestAvatar
5721 * buildbot/changes/pb.py (ChangePerspective.attached): same
5722 * buildbot/status/client.py (StatusClientPerspective.attached): same
5723 * buildbot/process/builder.py (Builder._attached3): same
5724 * buildbot/pbutil.py (NewCredPerspective.attached): same
5726 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5727 the date to the top-most box, if it is not the same as today's
5730 * docs/slave.xhtml: provide a buildslave setup checklist
5732 * docs/source.xhtml (Arch): correct terminology
5734 2004-12-04 Brian Warner <warner@lothar.com>
5736 * buildbot/test/test_slavecommand.py: use sys.executable instead
5737 of hard-coding 'python' for child commands, might help portability
5739 * docs/examples/twisted_master.cfg: update to current usage
5741 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5742 'stop build' command to the IRC bot
5744 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5745 message that broke PBChangeSource
5747 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5748 (SlaveBuilder): make some attributes class-level, remove the old
5749 "update queue" which existed to support resuming a build after the
5750 master connection was lost. Try to reimplement that feature later.
5751 (SlaveBuilder.stopCommand): clear self.command when the
5752 SlaveCommand finishes, so that we don't try to kill a leftover one
5754 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5757 * buildbot/slave/commands.py (SourceBase): set self.command for
5758 all VC commands, so they can be interrupted.
5760 2004-12-03 Brian Warner <warner@lothar.com>
5762 * buildbot/master.py: clean up slave-handling code, to handle
5763 slave-disconnect and multiple-connect better
5764 (BotPerspective): make these long-lasting, exactly one per bot
5765 listed in the config file.
5766 (BotPerspective.attached): if a slave connects while an existing
5767 one appears to still be connected, disconnect the old one first.
5768 (BotPerspective.disconnect): new method to forcibly disconnect a
5769 buildslave. Use some hacks to empty the transmit buffer quickly to
5770 avoid the long (20-min?) TCP timeout that could occur if the old
5771 slave has dropped off the net.
5772 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5773 own their own SlaveStatus objects. Remove .attached/.detached, add
5774 .addSlave/.removeSlave, treat slaves like Builders (config file
5775 parsing sends deltas to the BotMaster). Inform the slave
5776 instances, i.e. the BotPerspective, about addBuilder and
5778 (BotMaster.getPerspective): turns into a single dict lookup
5779 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5780 which gives BotPerspective.attached a chance to disconnect the old
5782 (BuildMaster.loadConfig): add code (disabled) to validate that all
5783 builders use known slaves (listed in c['bots']). The check won't
5784 work with tuple-specified builders, which are deprecated but not
5785 yet invalid, so the check is disabled for now.
5786 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5787 routine, do the add/changed/removed dance with them like we do
5789 (BuildMaster.loadConfig_Sources): move source-config into a
5790 separate routine too
5792 * buildbot/status/builder.py (Status.getSlave): get the
5793 SlaveStatus object from the BotPerspective, not the BotMaster.
5795 * buildbot/test/test_run.py: bunch of new tests for losing the
5796 buildslave at various points in the build, handling a slave that
5797 connects multiple times, and making sure we can interrupt a
5800 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5801 something other than 'Bot' for the Bot object, to make certain
5802 test cases easier to write.
5803 (BuildSlave.waitUntilDisconnected): utility method for testing
5805 2004-11-30 Brian Warner <warner@lothar.com>
5807 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5809 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5810 argument, return a Deferred that always fires with True or False.
5811 I don't use an errback to indicate 'ping failed' so that callers
5812 are free to ignore the deferred without causing spurious errors in
5814 * buildbot/process/builder.py (BuilderControl.ping): implement it
5816 * buildbot/test/test_run.py (Status.testDisappear): test ping
5817 (Status.disappearSlave): fix it
5819 2004-11-30 Brian Warner <warner@lothar.com>
5821 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5822 (IBuilderControl): add .getBuild(num), only works for the current
5823 build, of course, although it might be interesting to offer
5824 something for builds in the .waiting or .interlocked state.
5826 * buildbot/process/base.py (Build): have .stopBuild just do the
5827 interrupt, then let the build die by itself.
5828 (BuildControl): add .stopBuild, and add a point-event named
5829 'interrupt' just after the build so status viewers can tell that
5831 (BuilderControl): add .getBuild
5833 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5834 stops when you kill it, good for testing
5835 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5836 contains the 'reason' text.
5838 * buildbot/status/html.py: Add Stop Build button, if the build can
5839 still be stopped. Send a Redirect (to the top page) one second
5840 later, hopefully long enough for the interrupt to have an effect.
5841 Move make_row() up to top-level to share it between Stop Build and
5844 * buildbot/slave/commands.py: only kill the child process once
5846 * buildbot/test/test_run.py: add testInterrupt
5848 2004-11-29 Brian Warner <warner@lothar.com>
5850 * buildbot/process/base.py: Refactor command interruption. The
5851 Build is now responsible for noticing that the slave has gone
5852 away: Build.lostRemote() interrupts the current step and makes
5853 sure that no further ones will be started.
5855 * buildbot/process/builder.py: When the initial remote_startBuild
5856 message fails, log it: this usually indicates that the slave has
5857 gone away, but we don't really start paying attention until they
5858 fail to respond to the first step's command.
5860 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5861 slave disconnect. Now sports a new interrupt() method. Error
5862 handling was simplified a lot by chaining deferreds, so
5863 remoteFailed/remoteComplete were merged into a single
5864 remoteComplete method (which can now get a Failure object).
5865 Likewise failed/finished were merged into just _finished.
5866 (BuildStep): Add interrupt(why) method, and if why is a
5867 ConnectionLost Failure then the step is failed with some useful
5870 * buildbot/slave/bot.py: stop the current command when the remote
5871 Step reference is lost, and when the slave is shut down.
5872 (Bot): make it a MultiService, so it can have children. Use
5873 stopService to tell when the slave is shutting down.
5874 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5875 remote_interruptCommand (which asks the current SlaveCommand to
5876 stop but allows it to keep emitting status messages), and
5877 stopCommand (which tells it to shut up and die).
5879 * buildbot/slave/commands.py: make commands interruptible
5880 (ShellCommand.kill): factor out os.kill logic
5881 (Command): factor out setup()
5882 (Command.sendStatus): don't send status if .running is false, this
5883 happens when the command has been halted.
5884 (Command.interrupt): new method, used to tell the command to die
5885 (SlaveShellCommand): implement .interrupt
5886 (DummyCommand): implement .interrupt
5887 (SourceBase, etc): factor out setup(), don't continue substeps if
5890 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5891 so they can be called after finishing
5893 * buildbot/test/test_run.py: new tests for disconnect behavior,
5894 refactor slave-shutdown routines, add different kinds of
5897 2004-11-27 Brian Warner <warner@lothar.com>
5899 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5900 method to express ETA time like "2m45s" instead of "165 seconds"
5902 2004-11-24 Brian Warner <warner@lothar.com>
5904 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5905 archive after the test completes, to avoid cluttering the user's
5906 'tla archives' listing with a bogus entry. Arch doesn't happen to
5907 provide any way to override the use of ~/.arch-params/, so there
5908 isn't a convenient way to avoid touching the setup of the user who
5910 (VC_HTTP.testArchHTTP): same
5912 2004-11-23 Brian Warner <warner@lothar.com>
5914 * buildbot/status/html.py (TextLog): split render() up into
5915 render_HEAD and render_GET. Use a Producer when sending log
5916 chunks, to reduce memory requirements and avoid sending huge
5917 non-Banana-able strings over web.distrib connections. Requires
5918 peeking under the covers of IStatusLog.
5919 (TextLog.resumeProducing): fix the "as text" link, handle client
5920 disconnects that occur while we're still sending old chunks.
5922 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5923 use defer.succeed, not the non-existent defer.success
5924 (LogFile.waitUntilFinished): same
5925 (LogFile.subscribe): don't add watchers to a finished logfile
5927 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5930 2004-11-23 Brian Warner <warner@lothar.com>
5932 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5934 2004-11-23 Brian Warner <warner@lothar.com>
5936 * NEWS: update for the 0.6.1 release
5937 * MANIFEST.in: add new files
5939 * README (INSTALLATION): explain how to enable the extra VC tests
5941 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5942 level to, so old pickled builds can be displayed ok
5944 2004-11-22 Brian Warner <warner@lothar.com>
5946 * NEWS: summarize updates since last release
5948 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5949 Yoz Grahame. Closes SF#1050138.
5951 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5954 * buildbot/process/step_twisted.py (Trial): update docs a bit
5956 * docs/factories.xhtml: fix Trial factory docs to match reality.
5959 * buildbot/process/factory.py (Trial.__init__): add args for
5960 randomly= and recurse=, making them available to instantiators
5961 instead of only to subclassers. Closes: SF#1049759.
5963 2004-11-15 Brian Warner <warner@lothar.com>
5965 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5966 try to teach the Quick factory to use multiple versions of python
5968 2004-11-12 Brian Warner <warner@lothar.com>
5970 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5971 safer w32-compatible approach, and only use it on windows
5972 (BuildStatus.saveYourself): same
5974 2004-11-11 Brian Warner <warner@lothar.com>
5976 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5977 it: one string merge per chunk. There are now separate .entries
5978 and .runEntries lists: when enumerating over all chunks, make sure
5980 * buildbot/test/test_status.py (Log): more tests
5982 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5983 chunks together, up to 10kb per chunk. This ought to cut down on
5984 the CPU-burning overhead of large log files. Thanks to Alexander
5985 Staubo for spotting the problem.
5986 * buildbot/test/test_status.py (Log): tests for same
5988 2004-11-10 Brian Warner <warner@lothar.com>
5990 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5991 header to outbound mail
5992 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5994 2004-11-08 Brian Warner <warner@lothar.com>
5996 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5997 can't do os.rename() onto an existing file, so catch the exception
5998 and unlink the target file first. This introduces a slight window
5999 where the existing file could be lost, but the main failure case
6000 (disk full) should still be handled safely.
6001 (BuildStatus.saveYourself): same
6003 * buildbot/changes/pb.py (ChangePerspective): use a configurable
6004 separator character instead of os.sep, because the filenames being
6005 split here are coming from the VC system, which can have a
6006 different pathname convention than the local host. This should
6007 help a buildmaster running on windows that uses a CVS repository
6008 which runs under unix.
6009 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
6011 * buildbot/process/step_twisted.py (Trial.createSummary): survive
6012 when there are no test failures to be parsed
6014 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
6015 instead of the unix-specific os.system("cp"), thanks to Elliot
6016 Murphy for this and the other buildbot-vs-windows catches.
6017 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
6019 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
6020 echo the command as it is run
6022 * setup.py: install sample.mk too, not just sample.cfg
6023 (scripts): install contrib/windows/buildbot.bat on windows
6025 2004-11-07 Brian Warner <warner@lothar.com>
6027 * buildbot/process/builder.py (Builder._detached): clear the
6028 self.currentBuild reference, otherwise the next build will be
6029 skipped because we think the Builder is already in use.
6031 * docs/examples/twisted_master.cfg: update to match current usage
6032 on the Twisted buildbot
6034 2004-10-29 Brian Warner <warner@lothar.com>
6036 * buildbot/status/mail.py (MailNotifier): fix typo in docs
6038 2004-10-28 Brian Warner <warner@lothar.com>
6040 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
6041 have separate doVCUpdate/doVCFull methods. Catch an update failure
6042 and respond by clobbering the source directory and re-trying. This
6043 will handle local changes (like replacing a file with a directory)
6044 that will cause CVS and SVN updates to fail.
6045 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
6047 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
6050 2004-10-19 Brian Warner <warner@lothar.com>
6052 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
6054 * buildbot/status/html.py (StatusResourceTestResults): display any
6055 TestResults that the Build might have
6056 (StatusResourceTestResult): and the logs for each TestResult
6057 (StatusResourceBuild): add link from the per-build page
6059 2004-10-15 Brian Warner <warner@lothar.com>
6061 * buildbot/process/step_twisted.py (Trial.createSummary): parse
6062 the 'problems' portion of stdout, add TestResults to our build
6063 * buildbot/test/test_twisted.py (Parse.testParse): test it
6065 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
6066 to retrieve a dict of accumulated test results
6067 (ITestResult): define what a single test result can do
6068 * buildbot/status/builder.py (TestResult): implement ITestResult
6069 (BuildStatus.getTestResults): retrieve dict of TestResults
6070 (BuildStatus.addTestResult): add TestResults
6071 * buildbot/test/test_status.py (Results.testAddResults): test it
6073 2004-10-14 Brian Warner <warner@lothar.com>
6075 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
6076 instead of os.system("rm -rf") for win32 portability
6078 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
6079 SignalMixin instead of starting/stopping the reactor, which is
6080 likely to cause problems with other tests
6082 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
6083 self.copyComplete() call. Yoz Grahame makes the catch.
6085 * contrib/windows/buildbot.bat: helper script to deal with path
6086 issues. Thanks to Yoz Grahame.
6088 * buildbot/master.py (BuildMaster.startService): don't register a
6089 SIGHUP handler if the signal module has no SIGHUP attribute.
6090 Apparently win32 does this.
6092 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
6094 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
6095 test if the reactor can't offer UNIX sockets
6097 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
6098 error introduced in the last commit. We really need that
6101 2004-10-12 Brian Warner <warner@lothar.com>
6103 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
6104 when describing a maildir source. Thanks to Stephen Davis.
6106 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
6109 * buildbot/scripts/runner.py (createMaster): install Makefile too
6110 (start): add --no_save to 'start' command
6111 * buildbot/scripts/sample.mk: simple convenience Makefile with
6112 start/stop/reload targets
6114 * buildbot/__init__.py (version): bump to 0.6.0+ while between
6117 2004-09-30 Brian Warner <warner@lothar.com>
6119 * setup.py: Releasing buildbot-0.6.0
6121 2004-09-30 Brian Warner <warner@lothar.com>
6123 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
6124 test_trial.py from the source tarball until support is complete.
6126 * NEWS: update for 0.6.0 release
6127 * buildbot/__init__.py (version): same
6130 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
6131 'source' command to tell users where to get the Buildbot source
6133 * docs/examples/*.cfg: update to modern standards
6135 * NEWS: update for release
6137 * buildbot/scripts/runner.py (createMaster): remove the
6138 -shutdown.tap stuff now that it isn't necessary
6140 (start): launch buildbot.tap, not buildbot-shutdown.tap
6143 * buildbot/status/mail.py (Domain): shorten class name
6144 (MailNotifier): if lookup= is a string, pass it to Domain()
6145 * buildbot/test/test_status.py (Mail.testBuild1): new class name
6146 (Mail.testBuild2): test the string-to-Domain shortcut
6147 (Mail.testMail): fix test
6150 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
6153 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
6154 more attributes on load
6155 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
6156 to accomodate the whole waterfall page at once, and the thrashing
6157 results in a lot of unnecessary loads
6158 (BuildStatus.saveYourself): use binary pickles, not fluffy text
6159 (BuilderStatus.saveYourself): same
6160 (BuilderStatus.eventGenerator): stop generating on the first missing
6161 build. We assume that saved builds are deleted oldest-first.
6162 (BuildStepStatus.__getstate__): .progress might not exist
6164 * buildbot/changes/changes.py (ChangeMaster): make it
6165 serializable, in $masterdir/changes.pck
6166 (ChangeMaster.stopService): save on shutdown
6167 * buildbot/master.py (BuildMaster.loadChanges): load at startup
6168 * buildbot/test/test_config.py: load Changes before config file
6171 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
6172 "Oh my god, you killed the command" header on a separate line
6174 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
6175 skip over corrupted build pickles
6176 (BuilderStatus.getFullBuildByNumber): same
6177 (BuilderStatus.eventGenerator): skip over unavailable builds
6178 (BuildStatus.saveYourself): save builds to a .tmp file first, then
6179 do an atomic rename. This prevents a corrupted pickle when some
6180 internal serialization error occurs.
6181 (BuilderStatus.saveYourself): same
6183 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
6184 the timeout for shell commands, it got lost somehow
6186 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
6187 run out of build steps, return the rest of the builder events
6189 * buildbot/interfaces.py (IBuilderControl.ping): add method
6191 * buildbot/process/builder.py (BuilderControl.ping): move
6192 slave-ping to BuilderControl, and fix the failure case in the
6193 process (Event.finish() is the verb, Event.finished is the noun).
6195 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
6196 through the BuilderControl instead of the BuilderStatus
6197 (EventBox): add adapter for builder.Event, allowing builder events to
6198 be displayed in the waterfall display
6200 * buildbot/master.py (BotMaster.stopService): add a 'master
6201 shutdown' event to the builder's log
6202 (BuildMaster.startService): and a 'master started' on startup
6204 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
6205 builder events into the BuildStep event stream
6206 (Status.builderAdded): add a 'builder created' event
6209 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
6210 command to announce the completion of a running build
6211 (IrcStatusBot.command_FORCE): announce when the build finishes
6213 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
6214 don't evict unfinished builds from the cache: they must stay in
6215 the full-cache until their logfiles have stopped changing. Make
6216 sure the eviction loop terminates if an unfinished build was hit.
6217 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
6218 This lets exceptions be dumped in an email status message. Really
6219 we need LogFiles which contain both text and HTML, instead of two
6221 (BuildStatus.__getstate__): handle self.finished=False
6222 (Status.builderAdded): if the pickle is corrupted, abandon the
6223 history and create a new BuilderStatus object.
6225 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
6226 self.progress attribute, helped one test which doesn't fully set
6227 up the Build object.
6229 * buildbot/interfaces.py (IStatusLogStub): split out some of the
6230 IStatusLog methods into an Interface that is implemented by "stub"
6231 logs, for which all the actual text chunks are on disk (in the
6232 pickled Build instance). To show the log contents, you must first
6233 adapt the stub log to a full IStatusLog object.
6235 * buildbot/status/builder.py (LogFileStub): create separate stub
6236 log objects, which can be upgraded to a real one if necessary.
6237 (LogFile): make them persistable, and let them stubify themselves
6239 (BuildStepStatus): same
6241 (BuildStatus.saveYourself): save the whole build out to disk
6242 (BuilderStatus): make it persistable
6243 (BuilderStatus.saveYourself): save the builder to disk
6244 (BuilderStatus.addFullBuildToCache): implement two caches which
6245 hold Build objects: a small one which holds full Builds, and a
6246 larger one which holds "stubbed" Builds (ones with their LogFiles
6247 turned into LogFileStubs). This reduces memory usage by the
6248 buildmaster by not keeping more than a few (default is 2) whole
6249 build logs in RAM all the time.
6250 (BuilderStatus.getBuild): rewrite to pull from disk (through the
6252 (BuilderStatus.eventGenerator): rewrite since .builds went away
6253 (BuilderStatus.buildStarted): remove the .builds array. Add the
6254 build to the "full" cache when it starts.
6255 (BuilderStatus._buildFinished): save the build to disk when it
6257 (Status): give it a basedir (same as the BuildMaster's basedir)
6258 where the builder pickles can be saved
6259 (Status.builderAdded): create the BuilderStatus ourselves, by
6260 loading a pickle from disk (or creating a new instance if there
6261 was none on disk). Return the BuilderStatus so the master can glue
6262 it into the new Builder object.
6264 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
6265 all BuilderStatuses to save themselves out to disk. This is in
6266 lieu of saving anything important in the main Application pickle
6267 (the -shutdown.tap file).
6268 (BuildMaster.__init__): give Status() a basedir for its files
6269 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
6270 to get the BuilderStatus, then give it to the Builder (instead of
6271 doing it the other way around). It's ok if the status announces
6272 the new Builder before it's really ready, as the outside world can
6273 only see the BuilderStatus object anyway (and it is ready before
6274 builderAdded returns). Use the builder's "builddir" (which
6275 normally specifies where the slave will run the builder) as the
6276 master's basedir (for saving serialized builds).
6278 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
6279 coerce the logfile to IStatusLog before trying to get the text
6280 chunks out of it. This will pull the full (non-stubified) Build in
6281 from disk if necessary.
6282 (TextLog): fix the adapter registration
6284 * buildbot/test/test_control.py (Force.setUp): create the basedir
6285 * buildbot/test/test_web.py: same
6286 * buildbot/test/test_vc.py (SetupMixin.setUp): same
6287 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
6288 * buildbot/test/test_run.py (Run.testMaster): same
6289 (Status.setUp): same
6291 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
6293 * buildbot/status/html.py (Waterfall.__init__): store actual
6294 allowForce flag passed in rather than using True for everyone;
6295 make sure setting it to False doesn't cause a NameError
6297 (StatusResourceBuilder.__init__) add the builder name to the page
6299 (StatusResourceBuilder.body) move HTML generation for a name/value
6300 row into a helper method (StatusResourceBuilder.make_row); only
6301 generate the "Force Build" form if allowForce was True and the
6302 slave is connected. Use class attributes in the generated HTML to
6303 spread a little CSS-joy.
6305 2004-09-28 Brian Warner <warner@lothar.com>
6307 * buildbot/process/step_twisted.py (Trial.createSummary): fix
6308 warning-scanner to not ignore things like
6309 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
6311 * buildbot/status/html.py (StatusResource.control): add some
6312 class-level values for .control in an attempt to make upgrading
6315 * buildbot/util.py (ComparableMixin): survive missing attributes,
6316 such as when a class is modified and we're comparing old instances
6319 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
6320 failure handling, remove a redundant try/except block. Don't
6321 return the full traceback to the IRC channel.
6322 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
6323 error messages. Get ETA properly.
6325 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
6326 the reason, since (at least) IRC message will have <> in them.
6327 (StatusResourceBuilder.__init__): take an IBuilderControl
6328 (StatusResourceBuilder.force): use the IBuilderControl we get in
6329 the constructor instead of trying to make our own. Catch the
6330 new exceptions and ignore them for now (until we make an
6331 intermediate web page where we could show the error message)
6332 (StatusResource): create with an IControl, use it to give an
6333 IBuilderControl to all children
6334 (Waterfall): take an allowForce= option, pass an IControl object
6335 to StatusResource if it is True
6337 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
6339 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6340 catch new exceptions and return string forms
6342 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
6343 * buildbot/process/builder.py (Builder.forceBuild): raise them
6344 * buildbot/test/test_control.py (Force.testNoSlave): new test
6345 (Force.testBuilderInUse): same
6348 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
6350 * buildbot/test/test_run.py: use IControl
6351 * buildbot/test/test_vc.py: same
6353 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
6354 to use IControl. Still offline.
6355 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
6357 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
6358 who=None so periodic builds don't send out status mail
6359 (Builder.forceBuild): include reason in the log message
6360 (BuilderControl.forceBuild): rename 'name' to 'who'
6362 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
6363 'who' parameter, but make it None by default so builds forced by
6364 slave admins don't cause status mail to be sent to anybody
6365 (BotMaster.forceBuild): same. this method is deprecated.
6366 (DebugPerspective.perspective_forceBuild): same, use IControl.
6367 (DebugPerspective.perspective_fakeChange): use IControl..
6368 (Dispatcher.requestAvatar): .. so don't set .changemaster
6370 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
6371 parameter to avoid confusion with the name of the builder
6374 * buildbot/status/mail.py: refine comment about needing 2.3
6376 * buildbot/status/html.py: move all imports to the top
6378 * buildbot/test/test_control.py: test new interfaces
6379 * buildbot/test/test_run.py (Status): handle new interfaces
6380 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
6382 * buildbot/process/base.py (BuildControl): implement IBuildControl
6383 and its lonely getStatus() method
6385 * buildbot/process/builder.py (BuilderControl): implement
6386 IBuilderControl, obtained by adapting the Builder instance
6387 (Builder.startBuild): return a BuilderControl instead of a
6388 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
6389 accomplish the same thing.
6391 * buildbot/master.py: move all import statements to the top
6392 (Control): implement IControl, obtained by adapting the
6393 BuildMaster instance.
6395 * buildbot/interfaces.py: add IControl, IBuilderControl, and
6396 IBuildControl. These are used to force builds. Eventually they
6397 will provide ways to reconfigure the Builders, pause or abandon a
6398 Build, and perhaps control the BuildMaster itself.
6400 2004-09-26 Brian Warner <warner@lothar.com>
6402 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
6403 ends up comparing us against something without a .__class__
6405 2004-09-24 Brian Warner <warner@lothar.com>
6407 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
6410 * Makefile: add 'deb-snapshot' target, to create a timestamped
6413 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
6415 2004-09-23 Brian Warner <warner@lothar.com>
6417 * buildbot/__init__.py (version): move version string here
6418 * setup.py: get version string from buildbot.version
6419 * buildbot/status/html.py (WaterfallStatusResource.body): add
6420 buildbot version to the page footer
6421 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
6424 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
6425 slaves, let the second know where the first one is coming from
6426 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
6427 see our exceptions. It would be nice if there were a way to just
6428 send them the exception type and value, not the full traceback.
6431 * buildbot/status/mail.py (MailNotifier): add a new argument
6432 sendToInterestedUsers=, which can be set to False to disable the
6433 usual send-to-blamelist behavior.
6434 (top): handle python-2.2 which has no email.MIMEMultipart
6435 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
6436 (MailNotifier.disownServiceParent): unsubscribe on removal
6438 * buildbot/test/test_status.py (Mail.testBuild2): test it
6441 * buildbot/status/progress.py (Expectations.wavg): tolerate
6442 current=None, which happens when steps start failing badly
6443 * buildbot/test/test_status.py (Progress.testWavg): test for it
6445 * buildbot/process/step.py (SVN.startVC): when the (old) slave
6446 doesn't understand args['revision'], emit a warning instead of
6447 bailing completely. Updating to -rHEAD is probably close enough.
6449 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
6451 * buildbot/test/test_status.py: at least import bb.status.client
6452 even if we don't have any test coverage for it yet
6454 * contrib/svn_buildbot.py: don't require python2.3
6455 (main): wait, do require it (for sets.py), but explain how to
6456 make it work under python2.2
6458 2004-09-23 Brian Warner <warner@lothar.com>
6460 * contrib/svn_buildbot.py: include the revision number in the Change
6462 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
6463 using util.now() because FreshCVS is a realtime service
6465 * buildbot/status/event.py: delete dead code
6466 * buildbot/process/step.py: don't import dead Event class
6467 * buildbot/process/step_twisted.py: same
6468 * buildbot/status/builder.py: same
6469 * buildbot/status/client.py: same
6471 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
6473 * buildbot/changes/changes.py (Change): set .when from an __init__
6474 argument (which defaults to now()), rather than having
6475 ChangeMaster.addChange set it later.
6476 (ChangeMaster.addChange): same
6478 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
6479 (parseSyncmail): same. Just use util.now() for now.
6480 (parseBonsaiMail): parse the timestamp field for when=
6482 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
6483 instead of setting .when after the fact
6487 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
6488 results when the target project uses retrial. Still under
6490 * buildbot/test/test_trial.py: same
6492 2004-09-21 Brian Warner <warner@lothar.com>
6494 * buildbot/status/mail.py (MailNotifier.__init__): include
6495 success/warnings/failure in the Subject line
6496 (MailNotifier.buildMessage): add the buildbot's URL to the body,
6497 use step.logname for the addLogs=True attachment filenames
6498 * buildbot/test/test_status.py (Mail): test Subject lines
6499 (Mail.testLogs): test attachment filenames
6501 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
6502 accept a 'who' argument from the debug tool
6503 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
6504 * contrib/debug.glade: add text box to set 'who'
6506 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6507 .getBuilderName with .getBuilder().getName(), more flexible
6508 (IStatusLog.getName): logs have short names, but you can prefix
6509 them with log.getStep().getName() to make them more useful
6510 * buildbot/status/builder.py: same
6511 * buildbot/status/client.py: same
6512 * buildbot/status/html.py: same
6513 * buildbot/test/test_run.py (Status.testSlave): same
6514 * buildbot/process/step.py: tweak logfile names
6516 * buildbot/status/mail.py (MailNotifier): add lookup, change
6517 argument to extraRecipients. The notifier is now aimed at sending
6518 mail to the people involved in a particular build, with additional
6519 constant recipients as a secondary function.
6521 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6522 including slow-lookup and failing-lookup. Make sure the blamelist
6523 members are included.
6525 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6526 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6527 (IBuildStatus.getInterestedUsers): new method
6528 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6529 * buildbot/status/client.py (remote_getResponsibleUsers): same
6530 * buildbot/status/html.py (StatusResourceBuild.body): same
6531 * buildbot/test/test_run.py (Status.testSlave): same
6533 2004-09-20 Brian Warner <warner@lothar.com>
6535 * docs/users.xhtml: update concepts
6537 * Makefile: add a convenience makefile, for things like 'make
6538 test'. It is not included in the source tarball.
6540 2004-09-16 Brian Warner <warner@lothar.com>
6542 * NEWS: mention /usr/bin/buildbot, debian/*
6544 * debian/*: add preliminary debian packaging. Many thanks to
6545 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6546 it considerably since it left their hands, I am responsible for
6547 all breakage that's resulted.
6549 * bin/buildbot: create a top-level 'buildbot' command, to be
6550 installed in /usr/bin/buildbot . For now it's just a simple
6551 frontend to mktap/twistd/kill, but eventually it will be the entry
6552 point to the 'try' command and also a status client. It is also
6553 intended to support the upcoming debian-packaging init.d scripts.
6554 * buildbot/scripts/runner.py: the real work is done here
6555 * buildbot/scripts/__init__.py: need this too
6556 * buildbot/scripts/sample.cfg: this is installed in new
6557 buildmaster directories
6558 * setup.py: install new stuff
6560 2004-09-15 Brian Warner <warner@lothar.com>
6562 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6563 'file:' schema (the version shipped with OS-X was built without the
6565 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6566 updates the log-timestamp, to make sure it isn't still running after
6569 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6570 values to the config file.
6571 * docs/examples/hello.cfg: add examples
6572 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6573 * buildbot/status/builder.py (Status.getProjectURL): implement them
6574 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6575 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6576 * buildbot/status/html.py (WaterfallStatusResource): display them
6579 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6580 certain error cases don't suffer a secondary exception.
6581 (top): Skip tests if the corresponding VC tool is not installed.
6583 * buildbot/process/factory.py (Trial): introduce separate
6584 'buildpython' and 'trialpython' lists, since trialpython=[] is
6585 what you want to invoke /usr/bin/python, whereas ./setup.py is
6586 less likely to be executable. Add env= parameter to pass options
6587 to test cases (which is how I usually write tests, I don't know if
6588 anyone else does it this way).
6590 * buildbot/process/step_twisted.py (Trial): handle python=None.
6591 Require 'testpath' be a string, not a list. Fix tests= typo.
6592 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6594 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6595 way to deal with the possibility of removing the disconnect notify
6597 (CVS): add a 'login' parameter to give a password to 'cvs login',
6598 commonly used with pserver methods (where pw="" or pw="guest")
6600 * buildbot/slave/commands.py (SourceBase): move common args
6601 extraction and setup() to __init__, so everything is ready by the
6602 time setup() is called
6603 (CVS.start): call 'cvs login' if a password was supplied
6604 (ShellCommand): special-case PYTHONPATH: prepend the master's
6605 value to any existing slave-local value.
6607 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6608 don't have a remote, mark the builder as Offline. This whole
6609 function should probably go away and be replaced by individual
6611 (Builder.buildFinished): return the results to the build-finished
6612 deferred callback, helps with testing
6614 2004-09-14 Brian Warner <warner@lothar.com>
6616 * buildbot/test/test_vc.py: put all the repositories needed to run
6617 the complete tests into a single small (1.3MB) tarball, so I can
6618 make that tarball available on the buildbot web site. Test HTTP
6619 access (for Arch and Darcs) by spawning a temporary web server
6620 while the test runs.
6622 * docs/users.xhtml: new document, describe Buildbot's limited
6623 understanding of different human users
6625 * buildbot/test/test_vc.py: rearrange test cases a bit
6627 * buildbot/process/step_twisted.py (Trial): handle testpath=
6628 * buildbot/process/factory.py (Trial): update to use step.Trial
6630 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6632 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6633 the overall build text (which gives you 'failed 2 tests' rather
6635 (BuildStepStatus.text2): default to [], not None
6637 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6640 2004-09-12 Brian Warner <warner@lothar.com>
6642 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6643 log the whole exception if it's just an AttributeError (old slave)
6645 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6646 so (e.g.) sub-commands can be run in the right directory.
6647 (ShellCommand.start): accept an optional errorMessage= argument
6648 to make life easier for SVN.start
6649 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6651 (ShellCommand.start): move ['dir'] compatibility hack..
6652 (RemoteShellCommand.start): .. to here so everyone can use it
6654 * buildbot/process/step_twisted.py (Trial): use .workdir
6656 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6657 text displayed when debuild fails completely
6658 (Trial): snarf _trial_temp/test.log from the slave and display it
6660 2004-09-11 Brian Warner <warner@lothar.com>
6662 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6664 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6665 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6667 * buildbot/process/step.py (ShellCommand): call .createSummary
6668 before .evaluateCommand instead of the other way around. This
6669 makes it slightly easier to count warnings and then use that to
6670 set results=WARNINGS
6671 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6673 * buildbot/process/base.py (Build.buildFinished): update status
6674 before doing progress. It's embarrassing for the build to be stuck
6675 in the "building" state when an exceptions occurs elsewhere..
6677 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6678 python2.2 doesn't have 'sum'
6680 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6681 to prevent clients from accidentally sorting it
6683 * buildbot/master.py (Manhole): add username/password
6684 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6685 c['manholePort'], deprecate old usage
6686 * docs/config.xhtml: document c['manhole']
6687 * docs/examples/hello.cfg: show example of using a Manhole
6690 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6691 pretend the slave is up to date
6693 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6694 the module, overlaps with 'log', the local variable
6696 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6698 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6699 new method to let Steps find out the version of their
6700 corresponding SlaveCommand.
6701 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6702 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6703 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6705 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6706 (Arch.startVC): same
6707 (P4Sync.startVC): same
6709 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6710 Deferred so we can catch errors in remote_startCommand
6711 (RemoteShellCommand.start): same
6713 * docs/examples/twisted_master.cfg: update sample config file
6715 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6716 after connectionMade() is called, not before. Close stdin at that
6719 * buildbot/process/process_twisted.py: update to use Trial, clean
6720 up argument passing (move to argv arrays instead of string
6723 * buildbot/process/step_twisted.py (Trial): new step to replace
6724 RunUnitTests, usable by any trial-using project (not just
6725 Twisted). Arguments have changed, see the docstring for details.
6727 * buildbot/process/base.py (Build.startBuild): this now returns a
6728 Deferred. Exceptions that occur during setupBuild are now
6729 caught better and lead to fewer build_status weirdnesses, like
6730 finishing a build that was never started.
6731 (Build.buildFinished): fire the Deferred instead of calling
6732 builder.buildFinished directly. The callback argument is this
6733 Build, everything else can be extracted from it, including the
6734 new build.results attribute.
6735 * buildbot/process/builder.py (Builder.startBuild): same
6736 (Builder.buildFinished): same, extract results from build
6738 * buildbot/process/step.py (ShellCommands): remove dead code
6740 2004-09-08 Brian Warner <warner@lothar.com>
6742 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6743 doesn't try to use the leftover patched workdir
6744 (SourceStamp): test source-stamp computation for CVS and SVN
6746 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6747 patched workdir ('touch .buildbot-patched') so we don't try to
6749 (SourceBase.start): add ['revision'] for all Source steps
6750 (CVS): change args: use ['branch'] for -r, remove ['files']
6751 (CVS.buildVC): fix revision/branch stuff
6752 (SVN): add revision stuff
6754 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6755 kwargs (except 'workdir') to avoid silent spelling errors
6756 (ShellCommand.__init__): same
6757 (Source): new base class for CVS/SVN/etc. Factor out everything
6758 common, add revision computation (perform the checkout with a -D
6759 DATE or -r REVISION that gets exactly the sources described by the
6760 last Change), overridable with step.alwaysUseLatest. Add patch
6761 handling (build.getSourceStamp can trigger the use of a base
6762 revision and a patch).
6763 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6764 * docs/steps.xhtml: update docs
6765 * docs/source.xhtml: mention .checkoutDelay
6766 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6768 * buildbot/process/base.py (Build.setSourceStamp): add a
6769 .sourceStamp attribute to each Build. If set, this indicates that
6770 the build should be done with something other than the most
6771 recent source tree. This will be used to implement "try" builds.
6772 (Build.allChanges): new support method
6773 (Build.lastChangeTime): remove, functionality moved to Source steps
6774 (Build.setupBuild): copy the Step args before adding ['workdir'],
6775 to avoid modifying the BuildFactory (and thus triggering spurious
6779 * buildbot/status/html.py: rename s/commits/changes/
6780 (StatusResourceChanges): same
6781 (CommitBox.getBox): same, update URL
6782 (WaterfallStatusResource): same
6783 (StatusResource.getChild): same
6785 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6786 * contrib/debug.glade: add optional 'revision' to the fakeChange
6788 * buildbot/changes/changes.py (html_tmpl): display .revision
6789 (ChangeMaster.addChange): note .revision in log
6790 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6791 accept a ['revision'] attribute
6793 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6795 * buildbot/master.py (BotMaster.getPerspective): update the
6796 .connected flag in SlaveStatus when it connects
6797 (BotMaster.detach): and when it disconnects
6798 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6799 (BuildMaster.loadConfig_Builders): walk old list correctly
6801 * buildbot/test/test_config.py: fix prefix= usage
6803 2004-09-06 Brian Warner <warner@lothar.com>
6807 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6808 poll a P4 depot looking for recent changes. Thanks to Dave
6809 Peticolas for the contribution. Probably needs some testing after
6812 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6813 requires manual client setup for each buildslave. Rather
6814 experimental. Thanks again to Dave Peticolas.
6815 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6817 * buildbot/changes/changes.py (Change): add a .revision attribute,
6818 which will eventually be used to generate source-stamp values.
6820 * buildbot/process/step.py (RemoteCommand.start): use
6821 notifyOnDisconnect to notice when we lose the slave, then treat it
6822 like an exception. This allows LogFiles to be closed and the build
6823 to be wrapped up normally. Be sure to remove the disconnect
6824 notification when the step completes so we don't accumulate a
6825 bazillion such notifications which will fire weeks later (when the
6826 slave finally disconnects normally). Fixes SF#915807, thanks to
6827 spiv (Andrew Bennetts) for the report.
6828 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6829 really isn't Logged- specific
6830 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6831 header, since it's almost always going to be appended to an
6833 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6834 update test to handle use of notifyOnDisconnect
6836 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6837 don't clear .ETA and .currentBuild when going offline, let the
6838 current build clean up after itself
6840 * buildbot/process/builder.py (Builder.detached): wait a moment
6841 before doing things like stopping the current build, because the
6842 current step will probably notice the disconnect and cleanup the
6844 * buildbot/test/test_run.py (Status.tearDown): update test to
6845 handle asynchronous build-detachment
6847 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6849 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6850 hush a debug message
6852 2004-09-05 Brian Warner <warner@lothar.com>
6854 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6855 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6856 kernels do this: the fcntl module has the F_NOTIFY constant, but
6857 the kernel itself doesn't support the operation. Thanks to Olly
6858 Betts for spotting the problem.
6860 * buildbot/process/step.py (Darcs): new source-checkout command
6861 (Arch): new source-checkout command
6862 (todo_P4): fix constructor syntax, still just a placeholder
6863 * buildbot/test/test_vc.py (VC.testDarcs): test it
6864 (VC.testDarcsHTTP): same, via localhost HTTP
6866 (VC.testArchHTTP): same
6867 * NEWS: mention new features
6869 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6870 which tells the step to stash stdout text locally (in .stdout).
6871 Slave-side Commands can use this to make decisions based upon the
6872 output of the the ShellCommand (not just the exit code).
6873 (Darcs): New source-checkout command
6874 (Arch): New source-checkout command, uses .keepStdout in one place
6875 where it needs to discover the archive's default name.
6877 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6878 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6879 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6881 * buildbot/process/step.py (ShellCommand.describe): add an
6882 alternate .descriptionDone attribute which provides descriptive
6883 text when the step is complete. .description can be ["compiling"],
6884 for use while the step is running, then .descriptionDone can be
6885 ["compile"], used alone when the step succeeds or with "failed" when
6886 it does not. Updated other steps to use the new text.
6887 * buildbot/process/step_twisted.py: same
6888 * buildbot/test/test_run.py: update tests to match
6890 2004-08-30 Brian Warner <warner@lothar.com>
6892 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6893 (CVS.__init__): send 'patch' argument to slave
6894 (CVS.start): don't create the LoggedRemoteCommand until start(),
6895 so we can catch a .patch added after __init__
6896 (SVN.__init__): add 'patch' to SVN too
6899 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6900 argument, to let commands push data into the process' stdin pipe.
6901 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6902 is in use, since closing a PTY doesn't really affect the process
6903 in the right way (in particular, I couldn't run /usr/bin/patch
6905 (SourceBase.doPatch): handle 'patch' argument
6907 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6910 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6911 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6913 * buildbot/master.py (BotPerspective.got_commands): get command
6914 versions from slave, give to each builder
6915 * buildbot/process/builder.py (Builder.attached): stash slave
6916 command versions in .remoteCommands
6918 * docs/steps.xhtml: bring docs in-line with reality
6920 * buildbot/process/step.py (CVS.__init__): more brutal
6921 compatibility code removal
6922 (SVN.__init__): same
6924 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6925 (SlaveShellCommand.start): require ['workdir'] argument, remove
6926 the ['dir'] fallback (compatibility will come later)
6927 (SourceBase): update docs
6928 (SourceBase.start): remove ['directory'] fallback
6931 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6932 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6933 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6935 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6936 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6937 code.. I will figure out 0.5.0-compatibility hooks later)
6939 2004-08-30 Brian Warner <warner@lothar.com>
6941 * buildbot/process/process_twisted.py: rewrite in terms of new
6942 BuildFactory base class. It got significantly shorter. Yay
6945 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6946 work with the new "self.build isn't nailed down until we call
6947 step.start()" scheme: specifically, __init__ is called before the
6948 build has decided on which Changes are going in, so we don't scan
6949 build.allFiles() for .xhtml files until start()
6950 (HLint.commandComplete): use getText(), not getStdout()
6951 (RunUnitTests.start): same: don't use .build until start()
6952 (RunUnitTests.describe): oops, don't report (None) when using
6954 (RunUnitTests.commandComplete): use getText()
6955 (RunUnitTests.createSummary): same
6956 (BuildDebs.commandComplete): same
6958 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6959 set args['command'] until start(), since our BuildStep is allowed
6960 to change their mind up until that point
6961 (TreeSize.commandComplete): use getText(), not getStdout()
6963 * docs/examples/twisted_master.cfg: update to current standards
6965 * docs/factories.xhtml: update
6966 * buildbot/process/factory.py: implement all the common factories
6967 described in the docs. The Trial factory doesn't work yet, and
6968 I've probably broken all the process_twisted.py factories in the
6969 process. There are compatibility classes left in for things like
6970 the old BasicBuildFactory, but subclasses of them are unlikely to
6972 * docs/examples/glib_master.cfg: use new BuildFactories
6973 * docs/examples/hello.cfg: same
6975 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6976 explicit 'workdir' args
6978 * buildbot/process/base.py (BuildFactory): move factories to ..
6979 * buildbot/process/factory.py (BuildFactory): .. here
6980 * buildbot/process/process_twisted.py: handle move
6981 * buildbot/test/test_config.py: same
6982 * buildbot/test/test_run.py: same
6983 * buildbot/test/test_steps.py: same
6984 * buildbot/test/test_vc.py: same
6985 * docs/factories.xhtml: same
6987 * NEWS: mention config changes that require updating master.cfg
6989 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6990 argument to all steps that weren't given one already, pointing at
6991 the "build/" directory.
6993 * docs/examples/hello.cfg: remove explicit 'workdir' args
6995 * docs/factories.xhtml: document standard BuildFactory clases,
6996 including a bunch which are have not yet been written
6998 2004-08-29 Brian Warner <warner@lothar.com>
7000 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
7001 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
7002 buildbot.status.builder so they aren't quite so internal
7003 * buildbot/process/base.py, buildbot/process/builder.py: same
7004 * buildbot/process/maxq.py, buildbot/process/step.py: same
7005 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
7006 * buildbot/status/mail.py, buildbot/test/test_run.py: same
7007 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
7009 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
7010 to handle new getLogs()-returns-list behavior
7011 (StatusResourceBuildStep.getChild): same
7012 (StepBox.getBox): same
7013 (WaterfallStatusResource.phase0): same
7015 * docs/source.xhtml: document how Buildbot uses version-control
7016 systems (output side: how we get source trees)
7017 * docs/changes.xhtml: rename from sources.xhtml, documents VC
7018 systems (input side: how we learn about Changes)
7020 * buildbot/master.py (Manhole): use ComparableMixin
7021 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
7022 * buildbot/changes/mail.py (MaildirSource): same
7023 * buildbot/status/client.py (PBListener): same
7024 * buildbot/status/html.py (Waterfall): same
7025 * buildbot/status/words.py (IRC): same
7027 * NEWS: start describing new features
7029 * buildbot/status/mail.py (MailNotifier): finish implementation.
7030 The message body is still a bit sparse.
7031 * buildbot/test/test_status.py (Mail): test it
7033 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
7034 and __hash__ methods I wind up adding everywhere. Specifically
7035 intended to support the buildbot config-file update scheme where
7036 we compare, say, the old list of IStatusTargets against the new
7037 one and don't touch something which shows up on both lists.
7038 * buildbot/test/test_util.py (Compare): test case for it
7040 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
7041 return a list instead of a dict
7042 (IBuildStepStatus.getLogs): same. The idea is that steps create
7043 logs with vaguely unique names (although their uniqueness is not
7044 guaranteed). Thus a compilation step should create its sole
7045 logfile with the name 'compile', and contribute it to the
7046 BuildStatus. If a step has two logfiles, try to create them with
7047 different names (like 'test.log' and 'test.summary'), and only
7048 contribute the important ones to the overall BuildStatus.
7049 * buildbot/status/builder.py (Event.getLogs): same
7050 (BuildStepStatus): fix default .text and .results
7051 (BuildStepStatus.addLog): switch to list-like .getLogs()
7052 (BuildStepStatus.stepFinished): same
7053 (BuildStatus.text): fix default .text
7054 (BuildStatus.getLogs): temporary hack to return all logs (from all
7055 child BuildStepStatus objects). Needs to be fixed to only report
7056 the significant ones (as contributed by the steps themselves)
7057 * buildbot/test/test_run.py: handle list-like .getLogs()
7058 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
7060 2004-08-28 Brian Warner <warner@lothar.com>
7062 * buildbot/process/builder.py (Builder.attached): serialize the
7063 attachment process, so the attach-watcher isn't called until the
7064 slave is really available. Add detached watchers too, which makes
7067 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
7069 * buildbot/test/test_swap.py: remove dead code
7071 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
7072 (ShellCommand.start): treat errors in _startCommand/spawnProcess
7073 sort of as if the command being run exited with a -1. There may
7074 still be some holes in this scheme.
7075 (CVSCommand): add 'revision' tag to the VC commands, make sure the
7076 -r option appears before the module list
7077 * buildbot/process/step.py (CVS): add 'revision' argument
7079 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
7080 when sending updates or stepComplete messages to the master, since
7081 we don't currently care whether they arrive or not. When we revamp
7082 the master/slave protocol to really resume interrupted builds,
7083 this will need revisiting.
7084 (lostRemote): remove spurious print
7086 * buildbot/master.py (BotPerspective.attached): serialize the
7087 new-builder interrogation process, to make testing easier
7088 (BotMaster.waitUntilBuilderDetached): convenience function
7090 * buildbot/status/builder.py (BuilderStatus): prune old builds
7091 (BuildStatus.pruneSteps): .. and steps
7092 (BuildStepStatus.pruneLogs): .. and logs
7093 (BuilderStatus.getBuild): handle missing builds
7094 * buildbot/status/html.py (StatusResourceBuild.body): display build
7095 status in the per-build page
7096 (BuildBox.getBox): color finished builds in the per-build box
7098 2004-08-27 Brian Warner <warner@lothar.com>
7100 * buildbot/status/mail.py (MailNotifier): new notification class,
7103 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
7104 variants of a common base class which handles all the mode= logic
7106 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
7108 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
7110 2004-08-26 Brian Warner <warner@lothar.com>
7112 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
7115 * buildbot/test/test_run.py: update to new Logfile interface, new
7116 buildbot.slave modules
7117 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
7119 * MANIFEST.in: new sample config file
7120 * docs/examples/hello.cfg: same
7122 * buildbot/process/step_twisted.py: remove dead import
7124 * buildbot/process/step.py (RemoteCommand.run): catch errors
7126 (RemoteCommand.remote_update): ignore updates that arrive after
7128 (RemoteCommand.remote_complete): ignore duplicate complete msgs
7129 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
7130 the responsibilities of the subclass's methods
7131 (BuildStep.failed): catch errors during failure processing
7132 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
7133 (CVS): move to a mode= argument (described in docstring), rather
7134 than the ungainly clobber=/export=/copydir= combination.
7135 (SVN): add mode= functionality to SVN too
7136 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
7138 * buildbot/process/base.py (Build.startNextStep): catch errors
7139 during s.startStep()
7141 * buildbot/clients/base.py: update to new PB client interface.
7142 gtkPanes is still broken
7144 * buildbot/bot.py, buildbot/slavecommand.py: move to..
7145 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
7146 * setup.py: add buildbot.slave module
7147 * buildbot/bb_tap.py: handle move
7148 * buildbot/slave/registry.py: place to register commands, w/versions
7149 * buildbot/slave/bot.py: major simplifications
7150 (SlaveBuilder.remote_startCommand): use registry for slave commands,
7151 instead of a fixed table. Eventually this will make the slave more
7152 extensible. Use 'start' method on the command, not .startCommand.
7153 Fix unsafeTracebacks handling (I think).
7154 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
7155 helper class with a .start method that returns a Deferred.
7156 SlaveShellCommand is the form reached by the buildmaster. Commands
7157 which use multiple ShellCommands can just chain them as Deferreds,
7158 with some helper methods in Command (_abandonOnFailure and
7159 _checkAbandoned) to bail on rc!=0.
7160 (CVSCommand): prefer new mode= argument
7161 (SVNFetch): add mode= argument
7163 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
7164 put a useful reason string on the build
7166 * buildbot/status/builder.py (LogFile): do LogFile right: move the
7167 core functionality into an IStatusLog object
7168 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
7169 * buildbot/status/html.py (TextLog): HTML-rendering goes here
7170 (StatusResourceBuild.body): use proper accessor methods
7171 * buildbot/status/client.py (RemoteLog): PB-access goes here
7172 (StatusClientPerspective.perspective_subscribe): add "full" mode,
7173 which delivers log contents too
7174 (PBListener.__cmp__): make PBListeners comparable, thus removeable
7175 * buildbot/status/event.py: remove old Logfile completely
7177 * buildbot/interfaces.py (IStatusLog.subscribe): make the
7178 subscription interface for IStatusLog subscriptions just like all
7179 other the status subscriptions
7180 (IStatusReceiver.logChunk): method called on subscribers
7182 2004-08-24 Brian Warner <warner@lothar.com>
7184 * buildbot/process/builder.py (Builder._pong): oops, ping response
7185 includes a result (the implicit None returned by remote_print).
7186 Accept it so the _pong method handles the response correctly.
7188 2004-08-06 Brian Warner <warner@lothar.com>
7190 * buildbot/test/test_config.py: update IRC, PBListener tests
7192 * buildbot/status/client.py (StatusClientPerspective): total
7193 rewrite to match new IStatus interfaces. New subscription scheme.
7194 There are still a few optimizations to make (sending down extra
7195 information with event messages so the client doesn't have to do a
7196 round trip). The logfile-retrieval code is probably still broken.
7197 Moved the PB service into its own port, you can no longer share a
7198 TCP socket between a PBListener and, say, the slaveport (this
7199 should be fixed eventually).
7200 * buildbot/clients/base.py (Client): revamp to match. still needs
7201 a lot of work, but basic event reporting works fine. gtkPanes is
7204 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
7205 instance talks to a single irc server. Threw out all the old
7206 multi-server handling code. Still need to add back in
7207 builder-control (i.e. "force build")
7209 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
7210 more random text to the as-yet-unreachable per-step page
7212 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
7213 rename to stepETAUpdate
7214 (BuildStatus.subscribe): add build-wide ETA updates
7215 (BuilderStatus.getState): remove more cruft
7216 (BuilderStatus.getCurrentBuild): remove more cruft
7217 (BuilderStatus.buildStarted): really handle tuple-subscription
7218 * buildbot/test/test_run.py (Status.testSlave): handle the
7219 stepETAUpdate rename
7221 * buildbot/master.py (BuildMaster): don't add a default
7222 StatusClientService. Don't add a default IrcStatusFactory. Both
7223 are now added through c['status'] in the config file. c['irc'] is
7224 accepted for backwards compatibility, the only quirk is you cannot
7225 use c['irc'] to specify IRC servers on ports other than 6667.
7227 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
7228 (IStatusReceiver.buildStarted): allow update-interval on subscribe
7229 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
7230 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
7233 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
7234 the buildmaster to re-read its config file
7237 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
7238 find out the port our server is running on
7239 (WebTest.test_webPathname_port): same
7241 * buildbot/test/test_config.py (testWebPortnum): test it
7242 (testWebPathname): ditto
7244 * docs/config.xhtml: document new c['status'] configuration option
7246 * buildbot/status/html.py (Waterfall): new top-level class which
7247 can be added to c['status']. This creates the Site as well as the
7248 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
7249 reachable as .parent, for everything.
7251 * buildbot/master.py (Manhole): make it a normal service Child
7252 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
7253 webPathname. It will eventually replace c['irc'] and the implicit
7254 PB listener as well. c['webPortnum'] and c['webPathname'] are left
7255 in as (deprecated) backward compatibility hooks for now.
7258 * buildbot/process/builder.py (Builder.buildFinished): don't
7259 inform out builder_status about a finished build, as it finds out
7260 through its child BuildStatus object
7262 * buildbot/status/html.py: extensive revamp. Use adapters to make
7263 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
7264 have both starting and finishing times and adjust the waterfall
7265 display accordingly, using spacers if necessary. Use SlaveStatus
7266 to get buildslave info.
7267 (StatusResourceBuildStep): new just-one-step resource, used to get
7268 logfiles. No actual href to it yet.
7270 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
7271 the time being, until I get the file-naming scheme right
7273 * buildbot/status/builder.py (Event): clean started/finished names
7274 (BuildStatus.isFinished): .finished is not None is the right test
7275 (BuildStatus.buildStarted): track started/finished times ourselves
7276 (BuilderStatus.getSlave): provide access to SlaveStatus object
7277 (BuilderStatus.getLastFinishedBuild): all builds are now in
7278 .builds, even the currently-running one. Accomodate this change.
7279 (BuilderStatus.eventGenerator): new per-builder event generator.
7280 Returns BuildStepStatus and BuildStatus objects, since they can
7281 both be adapted as necessary.
7282 (BuilderStatus.addEvent): clean up started/finished attributes
7283 (BuilderStatus.startBuild,finishBuild): remove dead code
7284 (SlaveStatus): new object to provide ISlaveStatus
7286 * buildbot/process/step.py (ShellCommand.getColor): actually
7287 return the color instead of setting it ourselves
7288 (CVS.__init__): pull .timeout and .workdir options out of
7289 **kwargs, since BuildStep will ignore them. Without this neither
7290 will be sent to the slave correctly.
7291 (SVN.__init__): same
7293 * buildbot/process/builder.py (Builder): move flags to class-level
7295 (Builder.attached): remove .remoteInfo, let the BotPerspective and
7296 SlaveStatus handle that
7298 * buildbot/process/base.py (Build.firstEvent): remove dead code
7299 (Build.stopBuild): bugfix
7301 * buildbot/changes/pb.py (PBChangeSource.describe): add method
7303 * buildbot/changes/changes.py (Change): add IStatusEvent methods
7304 (ChangeMaster.eventGenerator): yield Changes, since there are now
7305 Adapters to turn them into HTML boxes
7307 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
7308 (BotPerspective.attached): feed a SlaveStatus object
7309 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
7310 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
7312 * buildbot/interfaces.py: API additions
7313 (ISlaveStatus): place to get slave status
7315 2004-08-04 Brian Warner <warner@lothar.com>
7317 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
7318 the delay finishes, so the step is marked as SUCCESS
7320 * buildbot/test/test_run.py (Status.testSlave): cover more of
7321 IBuildStatus and IBuildStepStatus
7323 * buildbot/status/progress.py (StepProgress): move some flags to
7324 class-level attributes
7325 (StepProgress.remaining): if there are no other progress metrics
7326 to go by, fall back to elapsed time
7327 (StepProgress.setExpectations): take a dict of metrics instead of
7329 (BuildProgress.setExpectationsFrom): pull expectations from the
7330 Expectations, instead of having it push them to the BuildProgress
7331 (Expectations): move some flags to class-level attributes
7332 (Expectations.__init__): copy per-step times from the
7334 (Expectations.expectedBuildTime): new method for per-build ETA
7336 * buildbot/status/event.py (Logfile): move some flags to
7337 class-level attributes
7338 (Logfile.logProgressTo): better method name, let step set the
7339 progress axis name (instead of always being "output")
7341 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
7342 times directly, rather than depending upon the (possibly missing)
7343 .progress object. Use 'None' to indicate "not started/finished
7345 (BuildStepStatus.getExpectations): oops, return the full list of
7347 (BuilderStatus._buildFinished): append finished builds to .builds
7349 * buildbot/process/step.py (BuildStep): add separate .useProgress
7350 flag, since empty .progressMetrics[] still implies that time is a
7352 (CVS): set up the cmd in __init__, instead of waiting for start()
7354 * buildbot/process/base.py (Build.startBuild): disable the 'when'
7355 calculation, this will eventually turn into a proper sourceStamp
7356 (Build.setupBuild): tell the Progress to load from the Expectations,
7357 instead of having the Expectations stuff things into the Progress
7358 (Build.buildException): add a build-level errback to make sure the
7359 build's Deferred fires even in case of exceptions
7361 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
7363 * buildbot/process/builder.py (Builder.forceBuild): convey the
7364 reason instead of creating a fake Change
7366 * docs/examples/twisted_master.cfg: update to match reality
7368 * buildbot/test/test_config.py, buildbot/test/test_process.py:
7369 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
7370 fix or remove broken/breaking tests
7372 * buildbot/status/event.py (Logfile.__len__): remove evil method
7374 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
7375 missing .build, for test convenience
7377 * buildbot/process/step_twisted.py: import fixes
7379 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
7381 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
7382 .statusbag reference
7384 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
7385 connection at shutdown, and stop it from reconnecting
7387 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
7388 chase down remote-execution bugs
7390 * buildbot/process/step.py: more fixes, remove
7391 BuildStep.setStatus()
7392 * buildbot/status/builder.py: move setStatus() functionality into
7394 * buildbot/status/event.py: minor fixes
7396 2004-08-03 Brian Warner <warner@lothar.com>
7398 * buildbot/process/base.py, buildbot/process/builder.py
7399 * buildbot/process/step.py, buildbot/status/builder.py
7400 * buildbot/status/event.py, buildbot/test/test_run.py:
7401 fix status delivery, get a basic test case working
7402 * buildbot/master.py: finish implementing basic status delivery,
7403 temporarily disable HTML/IRC/PB status sources
7405 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
7407 * buildbot/status/progress.py (BuildProgress): remove dead code
7409 * buildbot/interfaces.py
7410 * buildbot/process/base.py, buildbot/process/builder.py
7411 * buildbot/process/step.py, buildbot/process/step_twisted.py
7412 * buildbot/status/builder.py: Complete overhaul of the all
7413 status-delivery code, unifying all types of status clients (HTML,
7414 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
7415 look like. This commit is a checkpointing of the work-in-progress:
7416 the input side is mostly done (Builders/Builds sending status
7417 to the BuilderStatus/BuildStatus objects), but the output side has
7418 not yet been started (HTML resources querying BuilderStatus
7419 objects). Things are probably very broken right now and may remain
7420 so for several weeks, I apologize for the disruption.
7422 * buildbot/status/event.py: add a setHTML method to use pre-rendered
7423 HTML as the log's contents. Currently used for exception tracebacks.
7424 * buildbot/status/progress.py: minor spelling changes
7426 2004-08-02 Brian Warner <warner@lothar.com>
7428 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
7429 in mozilla. Also added stylesheets copied from Twisted's docs.
7430 Remember that these files are meant to be run through Lore first.
7431 Thanks to Philipp Frauenfelder for the fixes.
7432 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
7433 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
7434 * docs/template.tpl: added a Lore template
7436 2004-07-29 Brian Warner <warner@lothar.com>
7438 * buildbot/interfaces.py: revamp status delivery. This is the
7439 preview: these are the Interfaces that will be provided by new
7440 Builder code, and to which the current HTML/IRC/PB status
7441 displayers will be adapted.
7443 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
7444 on the SlaveBuilder, not the Bot.
7445 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
7447 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
7448 set .usePTY on the FakeSlaveBuilder
7450 2004-07-25 Brian Warner <warner@lothar.com>
7452 * buildbot/changes/freshcvs.py: add some debug log messages
7453 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
7454 disabled 'setFilter' syntax
7455 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
7456 don't end with a slash
7458 * buildbot/process/base.py (Builder._pong_failed): add TODO note
7460 * setup.py: bump to 0.5.0+ while between releases
7462 2004-07-23 Brian Warner <warner@lothar.com>
7464 * setup.py (version): Releasing buildbot-0.5.0
7466 2004-07-23 Brian Warner <warner@lothar.com>
7468 * README: update for 0.5.0 release
7470 * NEWS: update for 0.5.0 release
7472 2004-07-22 Brian Warner <warner@lothar.com>
7474 * buildbot/slavecommand.py (ShellCommand): make usePTY a
7475 mktap-time configuration flag (--usepty=1, --usepty=0)
7476 * buildbot/bot.py: same
7478 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
7479 an 'info' directory being unwanted
7481 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
7482 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
7483 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
7484 and earlier), use a FreshCVSSourceOldcred instead.
7485 (test): simple test routine: connect to server, print changes
7487 * buildbot/changes/changes.py (Change.getTime): make it possible
7488 to print un-timestamped changes
7490 * buildbot/master.py (makeApp): delete ancient dead code
7491 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
7492 * buildbot/test/test_config.py (testFindConfigFile): test it
7494 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
7495 instead of win32 one
7498 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
7499 now takes a dictionary instead of a tuple. See docs/config.xhtml for
7502 * buildbot/process/base.py (Builder.__init__): change constructor
7503 to accept a dictionary of config data, rather than discrete
7504 name/slave/builddir/factory arguments
7506 * docs/examples/twisted_master.cfg: update to new syntax
7507 * docs/examples/glib_master.cfg: same
7508 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7509 rough tests of the new syntax
7512 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7513 to be an int, which means "run a web.distrib sub-server on a TCP
7514 port". This lets you publish the buildbot status page to a remote
7515 twisted.web server (using distrib.ResourceSubscription). Also
7516 rename the local attributes used to hold these web things so
7517 they're more in touch with reality.
7518 * buildbot/test/test_web.py: test webPortnum and webPathname
7519 * docs/config.xhtml: document this new use of webPathname
7521 * docs/config.xhtml: new document, slightly ahead of reality
7523 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7524 'prefix' handling: treat it as a simple string to check with
7525 .startswith, instead of treating it as a directory. This allows
7526 sub-directories to be used. If you use prefix=, you should give it
7527 a string that starts just below the CVSROOT and ends with a slash.
7528 This prefix will be stripped from all filenames, and filenames
7529 which do not start with it will be ignored.
7531 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7533 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7534 and --exclude (inverse of --include). SVN post-commit hooks
7535 now have total control over which changes get sent to buildbot and which
7538 2004-07-10 Brian Warner <warner@lothar.com>
7540 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7541 test case to match new API
7543 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7544 which crashed HTML display when self.entries=[] (needed to
7545 distinguish between [], which means "no entries yet", and None,
7546 which means "the entries have been swapped out to disk, go fetch
7549 2004-07-04 Brian Warner <warner@lothar.com>
7551 * buildbot/process/step_twisted.py (countFailedTests): Count
7552 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7553 10kb from the end because any import errors are wedged there and
7554 they would make us think the test log was unparseable.
7555 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7557 2004-06-26 Brian Warner <warner@lothar.com>
7559 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7560 delete-*.pyc command into an actual BuildStep, so we can label it
7562 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7563 (FullTwistedBuildFactory): same
7565 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7567 * contrib/fakechange.py: Add an errback when sending the fake
7568 change, so we know it didn't work.
7570 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7572 * buildbot/process/step_twisted.py: Delete *.pyc files before
7573 calling trial, so it doesn't catch any old .pyc files whose .py
7574 files have been moved or deleted.
7576 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7577 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7578 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7579 instead of ["twisted.test"], so that the end result is "trial -R
7582 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7583 regular expression to match filenames that should be ignored when
7584 changed. Also add a --revision parameter that specifies the
7585 revision to examine, which is useful for debugging.
7587 2004-06-25 Brian Warner <warner@lothar.com>
7589 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7590 summary of warnings (like DeprecationWarnings), next to the
7593 2004-05-13 Brian Warner <warner@lothar.com>
7595 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7596 we now have a w32 build slave courtesy of Mike Taylor.
7598 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7599 so broken. Fixed a race condition that tripped up interlocked
7600 builds and caused the status to be stuck at "Interlocked" forever.
7601 The twisted buildbot's one interlocked build just so happened to
7602 never hit this case until recently (the feeding builds both pass
7603 before the interlocked build is attempted.. usually it has to wait
7605 (Builder._pong_failed): fix method signature
7607 * setup.py: bump to 0.4.3+ while between releases
7609 2004-04-30 Brian Warner <warner@lothar.com>
7611 * setup.py (version): Releasing buildbot-0.4.3
7613 2004-04-30 Brian Warner <warner@lothar.com>
7615 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7617 * README: update for 0.4.3 release
7619 * NEWS: update for 0.4.3 release
7621 * buildbot/master.py (BuildMaster.__getstate__): make sure
7622 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7624 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7625 .trial as a class attribute, for upgrade from 0.4.2
7627 * buildbot/changes/changes.py (Change.links): add .links for
7630 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7631 .textWatchers and .htmlWatchers at save time, since they are both
7632 volatile, should allow smooth 0.4.2 upgrade
7634 * buildbot/process/step.py (CVS.finishStatus): catch failed
7635 CVS/SVN commands so we can make the status box red
7637 2004-04-29 Brian Warner <warner@lothar.com>
7639 * buildbot/changes/freshcvs.py
7640 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7641 code to do setFilter(), which tells the freshcvs daemon to not
7642 send us stuff that we're not interested in. I will uncomment it
7643 when a new version of CVSToys is available in which setFilter()
7644 actually works, and I get a chance to test it better.
7646 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7648 * buildbot/master.py (Dispatcher): use a registration scheme
7649 instead of hardwired service names
7650 (BuildMaster): keep track of the Dispatcher to support
7653 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7654 PBChangeSource class instead of having it be an undocumented
7655 internal feature of the ChangeMaster. Split out the code into a
7657 * buildbot/changes/pb.py (PBChangeSource): same
7658 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7660 * docs/{factories|sources|steps}.xhtml: document some pieces
7662 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7663 using FCMaildirSource
7664 (f23osx): update OS-X builder to use python2.3, since the slave
7665 was updated to Panther (10.3.3)
7667 2004-03-21 Brian Warner <warner@lothar.com>
7669 * buildbot/process/process_twisted.py: factor out doCheckout, change
7670 to use SVN instead of CVS
7672 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7673 an SVN subclass easier
7674 (BasicSVN): subclass which uses Subversion instead of CVS
7676 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7678 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7680 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7682 2004-02-25 Brian Warner <warner@lothar.com>
7684 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7685 is now either a list (which is passed to spawnProcess directly) or
7686 a string (which gets passed to /bin/sh -c). This removes the useSH
7687 flag and the ArgslistCommand class. Also send status header at the
7688 start and end of each command, instead of having the master-side
7690 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7691 -r'. Update to use list-based arguments.
7692 (SVNFetch): use list-based arguments, use ['dir'] argument to
7694 * buildbot/test/test_steps.py (Commands): match changes
7696 * buildbot/process/step.py (InternalShellCommand.words): handle
7698 (SVN): inherit from CVS, cleanup
7700 * buildbot/status/event.py (Logfile.content): render in HTML, with
7701 stderr in red and headers (like the name of the command we're
7702 about to run) in blue. Add link to a second URL (url + "?text=1")
7703 to get just stdout/stderr in text/plain without markup. There is
7704 still a problem with .entries=None causing a crash, it seems to occur
7705 when the logfile is read before it is finished.
7707 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7708 timeout to the keepalives, and use it to explicitly do a
7709 loseConnection instead of waiting for TCP to notice the loss. This
7710 ought to clear up the silent-lossage problem.
7711 (unsafeTracebacks): pass exception tracebacks back to the master,
7712 makes it much easier to debug problems
7714 2004-02-23 Brian Warner <warner@lothar.com>
7716 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7717 the whole command to /bin/sh instead of execve [Johan Dahlin]
7718 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7719 '-r HEAD' [Johan Dahlin]
7720 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7722 * buildbot/changes/changes.py (Change): add links= argument, add
7723 asHTML method [Johan Dahlin]. Modified to make a bit more
7724 XHTMLish. Still not sure how to best use links= .
7726 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7727 Change.asHTML to display the change, not asText
7729 * buildbot/status/html.py (StatusResourceBuilder): web button to
7732 * buildbot/test/test_run.py: test to actually start a buildmaster
7735 * MANIFEST.in: bring back accidentally-dropped test helper files
7737 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7738 that require cvstoys if it is not installed
7740 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7741 values of "bin/trial" [Dave Peticolas]
7742 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7743 tests passed" when we didn't happen to run any tests
7745 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7746 flunkOnFailure [Johan Dahlin]
7748 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7749 multiple instances of the same Step class by suffixing "_2", etc,
7750 to the name until it is unique. This name needs to be unique
7751 because it is used as a key in the dictionary that tracks build
7753 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7756 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7758 2004-01-14 Brian Warner <warner@lothar.com>
7760 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7761 kicked from a channel, log it
7763 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7764 something over whatever IRC channels the buildmaster is currently
7765 connected to. Added to try and track down a problem in which the
7766 master thinks it is still connected but the IRCd doesn't see it. I
7767 used a styles.Versioned this time, so hopefully users won't have
7768 to rebuild their .tap files this time.
7769 * contrib/debug.glade: add a "Poke IRC" button
7770 * contrib/debugclient.py: same
7772 * setup.py: bump to 0.4.2+ while between releases
7774 2004-01-08 Brian Warner <warner@lothar.com>
7776 * setup.py (version): Releasing buildbot-0.4.2
7778 2004-01-08 Brian Warner <warner@lothar.com>
7780 * NEWS: update for 0.4.2 release
7782 * README: document how to run the tests, now that they all pass
7784 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7786 * buildbot/process/step.py (CVS): add a global_options= argument,
7787 which lets you set CVS global options for the command like "-r"
7788 for read-only checkout, or "-R" to avoid writing in the
7790 * buildbot/slavecommand.py (CVSCommand): same
7792 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7793 testing easier (it is turned off when testing, to avoid the
7796 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7797 to make it easier to test: break generateStepID() out to a
7798 separate function, only update statusbag if it exists.
7799 (ShellCommands): create useful text for dict-based commands too.
7801 * test/*, buildbot/test/*: move unit tests under the buildbot/
7803 * setup.py (packages): install buildbot.test too
7805 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7806 * buildbot/test/test_steps.py: fix it, tests pass now
7808 2004-01-06 Brian Warner <warner@lothar.com>
7810 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7811 freshcvs mail uses a slightly different syntax for new
7812 directories. Update parser to handle either.
7813 * test/test_mailparse.py (Test1.testMsg9): test for same
7815 2003-12-21 Brian Warner <warner@lothar.com>
7817 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7818 'warnOnWarnings' so that lintian errors mark the build orange
7820 2003-12-17 Brian Warner <warner@lothar.com>
7822 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7823 messages emitted by Bonsai, contributed by Stephen Davis.
7825 * test/*: moved all tests to use trial instead of unittest. Some
7826 still fail (test_steps, test_slavecommand, and test_process).
7828 * setup.py (version): bump to 0.4.1+ while between releases
7830 2003-12-09 Brian Warner <warner@lothar.com>
7832 * setup.py (version): Releasing buildbot-0.4.1
7834 2003-12-09 Brian Warner <warner@lothar.com>
7836 * NEWS: update for 0.4.1 release
7838 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7839 freebsd builder code a little bit
7841 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7842 don't try to compare attributes of different classes
7843 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7844 (MaildirSource.messageReceived): fix Change delivery
7846 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7847 into the config file's namespace before loading it, like the
7848 documentation claims it does
7849 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7850 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7851 daemon comes back online
7853 2003-12-08 Brian Warner <warner@lothar.com>
7855 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7856 so the example will work with online=0 as well
7858 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7859 fix the __implements__ line
7861 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7862 class a twisted.application.service.Service, use startService to
7865 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7866 directory fd instead of simple open(). I'm sure this used to work,
7867 but the current version of python refuses to open directories with
7870 2003-12-05 Brian Warner <warner@lothar.com>
7872 * setup.py (version): bump to 0.4.0+ while between releases
7874 2003-12-05 Brian Warner <warner@lothar.com>
7876 * setup.py (version): Releasing buildbot-0.4.0
7878 2003-12-05 Brian Warner <warner@lothar.com>
7880 * docs/examples/glib_master.cfg: replace old sample scripts with
7881 new-style config files
7882 * MANIFEST.in: include .cfg files in distribution tarball
7884 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7885 implement a dummy method to avoid the exception that occurs when
7886 freshcvs sends this to us.
7888 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7889 removed the method, as it broke reconnection. Apparently
7890 stopFactory is called each time the connection attempt fails. Must
7892 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7893 attribute before serialization, since without stopFactory the
7894 reconnect timer may still be active and they aren't serializable.
7896 * test/test_mailparse.py (ParseTest): test with 'self' argument
7898 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7899 argument, as these "functions" are invoked like methods from class
7900 attributes and therefore always get an instance as the first
7903 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7904 message: thanks to Stephen Davis for the catch
7906 2003-12-04 Brian Warner <warner@lothar.com>
7908 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7909 twisted's standard ReconnectingClientFactory. Handles both oldcred
7910 and newcred connections. Also has a bug-workaround for
7911 ReconnectingClientFactory serializing its connector when it
7914 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7915 pbutil. Replace makeApp stuff with proper newcred/mktap
7916 makeService(). Don't serialize Ephemerals on shutdown.
7918 * buildbot/changes/changes.py (ChangeMaster): make it a
7919 MultiService and add the sources as children, to get startService
7920 and stopService for free. This also gets rid of the .running flag.
7922 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7923 new pbutil, turn into a TCPClient at the same time (to get
7924 startService for free). Two variants exist: FreshCVSSourceOldcred
7925 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7926 yet, but when it does, we'll be ready).
7927 (FreshCVSSource.notify): handle paths which are empty after the
7928 prefix is stripped. This only happens when the top-level (prefix)
7929 directory is added, at the very beginning of a Repository's life.
7931 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7932 Now the only reconnecting code is in the factory where it belongs.
7933 (Builder.unsubscribe): unregister the disconnect callback when we
7934 delete the builder on command from the master (i.e. when the
7935 buildmaster is reconfigured and that builder goes away). This
7936 fixes a multiple-delete exception when the status client is shut
7938 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7941 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7942 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7944 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7946 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7947 a list of globs (ugh). The testdir will be searched for files
7948 named *.tests and run the tests in the order specified in each of
7949 those files. This allows for "dependancies" between tests to be
7952 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7953 argument to pass to run_maxq.py, instead of a glob.
7955 2003-10-17 Brian Warner <warner@lothar.com>
7957 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7958 files that live in the sandbox
7960 2003-10-15 Brian Warner <warner@lothar.com>
7962 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7963 spelling error in "docs" count-warnings output
7964 (HLint.start): stupid thinko meant .xhtml files were ignored
7966 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7967 tests now that cReactor is banished to the sandbox
7969 2003-10-10 Brian Warner <warner@lothar.com>
7971 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7972 scheme: now .xhtml are sources and .html are generated
7974 2003-10-08 Brian Warner <warner@lothar.com>
7976 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7977 we were ignoring the 'randomly' parameter.
7979 2003-10-01 Brian Warner <warner@lothar.com>
7981 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7982 posix, to kill sub-children of aborted slavecommands.
7984 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7985 Clean up initialization: lastBuildStatus remains None until the
7986 first build has been completed.
7988 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7989 None as a lastBuildStatus
7990 * buildbot/clients/gtkPanes.py: same
7992 * buildbot/status/client.py (StatusClientService): keep
7993 BuilderStatus objects in self.statusbags . These objects now live
7994 here in the StatusClientService and are referenced by the Builder
7995 object, rather than the other way around.
7996 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7997 * buildbot/process/base.py (Builder): same
7998 * test/test_config.py (ConfigTest.testBuilders): same
8000 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
8001 an existing builder, leave the statusbag alone. This will preserve the
8004 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
8005 hook. This will probably go away in favor of a class in upcoming
8008 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
8009 serviceName from newcred FreshCVSNotifiee setup
8011 2003-09-29 Brian Warner <warner@lothar.com>
8013 * buildbot/process/process_twisted.py: switch to new reactor
8015 * docs/examples/twisted_master.cfg: same
8017 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
8019 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
8020 botmaster reference instead of the oldapp service lookup
8022 * buildbot/master.py (BuildMaster.__init__): give the
8023 StatusClientService a reference to the botmaster to make it easier to
8026 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
8028 * buildbot/status/html.py (Box.td): escape hreffy things so you
8029 can have spaces in things like builder names
8030 (StatusResourceBuilder.body)
8031 (WaterfallStatusResource.body)
8032 (WaterfallStatusResource.body0): same
8034 2003-09-25 Brian Warner <warner@lothar.com>
8036 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
8037 rearrange the builder list when adding or removing builders: keep
8038 them in the order the user requested.
8039 * test/test_config.py (ConfigTest.testBuilders): verify it
8041 * contrib/debug.glade: give the debug window a name
8043 * buildbot/process/base.py (Builder.buildTimerFired): builders can
8044 now wait on multiple interlocks. Fix code relating to that.
8045 (Builder.checkInterlocks): same
8046 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
8048 * buildbot/master.py (BuildMaster.loadConfig): move from
8049 deprecated pb.BrokerFactory to new pb.PBServerFactory
8050 * test/test_config.py (ConfigTest.testWebPathname): same
8052 * docs/examples/twisted_master.cfg: fix interlock declaration
8054 * buildbot/master.py (BotMaster.addInterlock): move code to attach
8055 Interlocks to their Builders into interlock.py .
8056 (BuildMaster.loadConfig_Interlocks): fix interlock handling
8058 * test/test_config.py (ConfigTest.testInterlocks): validate
8061 * buildbot/process/base.py (Builder.__init__): better comments
8062 * buildbot/process/interlock.py (Interlock.__repr__): same
8063 (Interlock.deactivate): add .active flag, move the code that
8064 attaches/detaches builders into the Interlock
8066 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
8068 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
8069 tests using the new run_maxq.py script, and reporting failures by
8072 * contrib/run_maxq.py: Hacky little script for running a set of maxq
8073 tests, reporting their success or failure in a buildbot-friendly
8076 2003-09-24 Brian Warner <warner@lothar.com>
8078 * docs/examples/twisted_master.cfg: example of a new-style config
8079 file. This lives in the buildmaster base directory as
8082 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
8083 button to make the master re-read its config file
8085 * buildbot/master.py (BuildMaster.loadConfig): new code to load
8086 buildmaster configuration from a file. This file can be re-read
8087 later, and the buildmaster will update itself to match the new
8088 desired configuration. Also use new Twisted Application class.
8089 * test/Makefile, test/test_config.py: unit tests for same
8091 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
8092 FreshCVSSources comparable, to support reload.
8093 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
8095 * buildbot/process/base.py (Builder): make them comparable, make
8096 Interlocks easier to attach, to support reload. Handle
8097 re-attachment of remote slaves.
8098 * buildbot/process/interlock.py (Interlock): same
8100 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
8101 Twisted's new Application class. Requires Twisted >= 1.0.8 .
8102 buildmaster taps are now constructed with mktap.
8103 * buildbot/status/client.py (StatusClientService): same
8105 * buildbot/status/words.py: move to new Services, add support to
8106 connect to multiple networks, add reload support, allow nickname
8107 to be configured on a per-network basis
8109 2003-09-20 Brian Warner <warner@lothar.com>
8111 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
8112 the freebsd builder, now that the machine has been upgraded and no
8113 longer has python2.2
8115 * setup.py (version): bump to 0.3.5+ while between releases
8117 2003-09-19 Brian Warner <warner@lothar.com>
8119 * setup.py (version): Releasing buildbot-0.3.5
8121 2003-09-19 Brian Warner <warner@lothar.com>
8123 * NEWS: add post-0.3.4 notes
8125 * README (REQUIREMENTS): note twisted-1.0.7 requirement
8127 * MANIFEST.in: add contrib/*
8129 * docs/examples/twisted_master.py (twisted_app): all build slaves must
8130 use a remote root now: cvs.twistedmatrix.com
8132 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
8134 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
8135 compatibility with old servers
8136 (FreshCVSSource.start): and provide a way to use it
8137 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
8139 * docs/examples/twisted_master.py (twisted_app): update to new
8141 (twisted_app): listen on new ~buildbot socket
8142 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
8144 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
8145 to reduce cvs bandwidth (update instead of full checkout)
8147 2003-09-11 Brian Warner <warner@lothar.com>
8149 * contrib/fakechange.py: demo how to connect to the changemaster
8150 port. You can use this technique to submit changes to the
8151 buildmaster from source control systems that offer a hook to run a
8152 script when changes are committed.
8154 * contrib/debugclient.py: tool to connect to the debug port. You
8155 can use it to force builds, submit fake changes, and wiggle the
8158 * buildbot/master.py: the Big NewCred Reorganization. Use a single
8159 'Dispatcher' realm to handle all the different kinds of
8160 connections and Perspectives: buildslaves, the changemaster port,
8161 the debug port, and the status client port. NewCredPerspectives
8162 now have .attached/.detached methods called with the remote 'mind'
8163 reference, much like old perspectives did. All the pb.Services
8164 turned into ordinary app.ApplicationServices .
8165 (DebugService): went away, DebugPerspectives are now created
8166 directly by the Dispatcher.
8167 (makeApp): changed interface a little bit
8169 * buildbot/changes/changes.py: newcred
8170 * buildbot/status/client.py: newcred
8172 * buildbot/clients/base.py: newcred client side changes
8173 * buildbot/bot.py: ditto
8175 * docs/examples/glib_master.py: handle new makeApp() interface
8176 * docs/examples/twisted_master.py: ditto
8178 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
8179 base newcred Perspectives on. This should go away once Twisted
8180 itself provides something sensible.
8183 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
8185 * contrib/svn_buildbot.py: A program that you can call from your
8186 SVNREPO/hooks/post-commit file that will notify a BuildBot master
8187 when a change in an SVN repository has happened. See the top of
8188 the file for some minimal usage info.
8190 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8192 * buildbot/slavecommand.py (ArglistCommand): Add new
8193 ArglistCommand that takes an argument list rather than a string as
8194 a parameter. Using a st.split() for argv is very bad.
8196 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
8197 update to a particular revision rather than always checking out
8198 (still not very smart about it, there may be cases where the
8199 checkout becomes inconsistent).
8201 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8203 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
8204 SVN fetch support. It can checkout (not update!) a specified
8205 revision from a specified repository to a specified directory.
8207 * buildbot/status/progress.py (Expectations.update): Fix an
8208 obvious bug (apparently created by the change described in the
8209 previous ChangeLog message) by moving a check to *after* the
8210 variable it checks is defined.
8213 2003-09-08 Brian Warner <warner@lothar.com>
8215 * buildbot/status/progress.py (Expectations.update): hack to catch
8216 an exception TTimo sees: sometimes the update() method seems to
8217 get called before the step has actually finished, so the .stopTime
8218 is not set, so no totalTime() is available and we average None
8219 with the previous value. Catch this and just don't update the
8220 metrics, and emit a log message.
8222 2003-08-24 Brian Warner <warner@lothar.com>
8224 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
8225 parameter to set copydir='original' in CVS commands.
8227 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
8229 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
8230 which tells the command to maintain a separate original-source CVS
8231 workspace. For each build, this workspace will be updated, then
8232 the tree copied into a new workdir. This reduces CVS bandwidth
8233 (from a full checkout to a mere update) while doubling the local
8234 disk usage (to keep two copies of the tree).
8236 2003-08-21 Brian Warner <warner@lothar.com>
8238 * buildbot/status/event.py (Logfile.addEntry): if the master web
8239 server dies while we're serving a page, request.write raises
8240 pb.DeadReferenceError . Catch this and treat it like a
8241 notifyFinish event by dropping the request.
8243 2003-08-18 Brian Warner <warner@lothar.com>
8245 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
8246 (instead of blowing up) if a force-build command is given without
8249 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
8250 don't blow up if there aren't yet any Changes in the list
8252 2003-08-02 Brian Warner <warner@lothar.com>
8254 * buildbot/bot.py (updateApplication): don't set the .tap name,
8255 since we shouldn't assume we own the whole .tap file
8257 * buildbot/bb_tap.py (updateApplication): clean up code, detect
8258 'mktap buildbot' (without a subcommand) better
8260 2003-07-29 Brian Warner <warner@lothar.com>
8262 * buildbot/status/words.py
8263 (IrcStatusFactory.clientConnectionLost): when we lose the
8264 connection to the IRC server, schedule a reconnection attempt.
8266 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
8267 use shutil.rmtree instead of forking off an "rm -rf" command.
8268 rmtree may take a while and will block until it finishes, so we
8269 use "rm -rf" if available.
8271 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
8272 freebsd buildslave badly
8274 * setup.py (version): bump to 0.3.4+ while between releases
8276 2003-07-28 Brian Warner <warner@lothar.com>
8278 * setup.py (version): Releasing buildbot-0.3.4
8280 2003-07-28 Brian Warner <warner@lothar.com>
8282 * NEWS: update in preparation for release
8284 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
8285 process.signalProcess instead of os.kill, to improve w32
8288 * docs/examples/twisted_master.py (twisted_app): turn off
8289 win32eventreactor: the tests hang the buildslave badly
8291 * buildbot/process/base.py (Build.buildFinished): update ETA even on
8292 failed builds, since usually the failures are consistent
8294 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8295 add compileOpts/compileOpts2 to reactors build
8297 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
8298 (twisted_app): use both default and win32eventreactor on w32 build.
8299 Use both default and kqreactor on freebsd build.
8301 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8302 add compileOpts2, which is put after the build_ext argument. w32
8303 needs "-c mingw32" here.
8305 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
8306 touch .acqpath, it goes away in recent Twisted releases
8308 * docs/examples/twisted_master.py (twisted_app): use "python" for
8309 the w32 buildslave, not "python2.2"
8311 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
8312 the directory exists.. should hush an exception under w32
8314 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
8315 ProcessTerminated -provided values for signal and exitCode rather
8316 than parsing the unix status code directly. This should remove one
8317 more roadblock for a w32-hosted buildslave.
8319 * test/test_mailparse.py: add test cases for Syncmail parser
8321 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
8322 temporary compatibility import. Note! Start importing
8323 FCMaildirSource from changes.mail instead of changes.freshcvsmail
8325 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
8327 2003-07-27 Brian Warner <warner@lothar.com>
8329 * NEWS: started adding new features
8331 * buildbot/changes/mail.py: start work on Syncmail parser, move
8332 mail sources into their own file
8334 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
8335 as implementing IChangeSource
8336 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
8338 * buildbot/interfaces.py: define the IChangeSource interface
8340 2003-07-26 Brian Warner <warner@lothar.com>
8342 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
8344 2003-06-25 Brian Warner <warner@lothar.com>
8346 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
8349 2003-06-17 Brian Warner <warner@lothar.com>
8351 * buildbot/status/words.py: clean up method usage to avoid error
8352 in silly IRC command
8353 (IrcStatusBot.emit_status): round off seconds display
8355 * buildbot/process/base.py (Build): delete the timer when saving
8356 to the .tap file, and restore it (if it should still be running)
8357 upon restore. This should fix the "next build in -34 seconds"
8358 messages that result when the master is restarted while builds are
8359 sitting in the .waiting slot. If the time for the build has
8360 already passed, start it very soon (in 1 second).
8362 * buildbot/status/words.py: more silly commands
8364 * README (REQUIREMENTS): add URLs to all required software
8366 * buildbot/status/words.py ('last'): mention results of, and time
8369 2003-05-28 Brian Warner <warner@lothar.com>
8371 * buildbot/status/words.py: add 'last' command
8372 (IrcStatusBot.emit_status): add current-small text to 'status' output
8374 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
8375 (twisted_app): remove spaces from OS-X builder name
8377 * buildbot/master.py (makeApp): add knob to turn on IRC bot
8378 * buildbot/status/words.py: IRC bot should actually be useful now
8380 2003-05-23 Brian Warner <warner@lothar.com>
8382 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
8383 "slave information" from $(slavedir)/info/* . These files are
8384 maintained by the slave administrator, and describe the
8385 machine/environment that is hosting the slave. Information from
8386 them is put into the "Builder" HTML page. Still need to establish
8387 a set of well-known filenames and meanings for this data: at the
8388 moment, *all* info/* files are sent to the master, but only
8389 'admin' and 'host' are used on that end.
8390 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
8391 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
8392 * buildbot/master.py (BotPerspective.got_info): ditto
8394 2003-05-22 Brian Warner <warner@lothar.com>
8396 * setup.py (version): bump version to 0.3.3+ while between releases
8398 2003-05-21 Brian Warner <warner@lothar.com>
8400 * setup.py: Releasing buildbot-0.3.3
8402 2003-05-21 Brian Warner <warner@lothar.com>
8404 * NEWS: 0.3.3 news items
8406 * README: describe --keepalive and life behind a NAT box
8408 * buildbot/bot.py (Bot.connected): implement application-level
8409 keepalives to deal with NAT timeouts, turn them on with
8410 --keepalive option or when SO_KEEPALIVE doesn't work.
8412 * buildbot/master.py (BotPerspective): accept keepalives silently
8414 * buildbot/process/base.py (Build.buildException): CopiedFailures
8415 don't carry as much information as local ones, so don't try to
8416 create a big HTMLized version of them.
8418 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
8419 log file when step fails due to an exception, such as when the slave
8422 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
8423 --testmodule argument instead of grepping for test-case-name tags
8424 ourselves. Remove FindUnitTests code.
8425 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
8427 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
8429 2003-05-16 Brian Warner <warner@lothar.com>
8431 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
8432 argument to allow things like CFLAGS=-O0 to be passed without relying
8433 upon /bin/sh processing on the slave.
8435 * buildbot/process/step.py (InternalShellCommand.start): send
8437 * buildbot/slavecommand.py (ShellCommand.start): create argv with
8438 'split' instead of letting /bin/sh do it. This should also remove
8439 the need for /bin/sh on the buildslave, making it more likely to
8442 * buildbot/status/html.py: html-escape text in blamelist.
8443 Add "force build" button to the Builder page.
8445 * buildbot/process/step_twisted.py (countFailedTests): look at
8446 last 1000 characters for status line, as import errors can put it
8447 before the -200 point.
8449 2003-05-15 Brian Warner <warner@lothar.com>
8451 * docs/examples/twisted_master.py: use clobber=0 for remote builds
8453 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8454 make 'clobber' a parameter, so it is possible to have builds which
8455 do full tests but do a cvs update instead of hammering the CVS
8456 server with a full checkout each build
8458 * buildbot/process/step.py (InternalShellCommand): bump default
8459 timeout to 20 minutes
8461 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
8462 the master to trigger a build. Run it via manhole.
8464 * buildbot/master.py (BotPerspective.perspective_forceBuild):
8465 allow slaves to trigger any build that they host, to make life
8466 easier for slave admins who are testing out new build processes
8468 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8469 don't flunk cReactor or qtreactor on failure, since they fail alot
8470 these days. Do warnOnFailure instead.
8472 * buildbot/process/base.py: change Builder.buildable from a list
8473 into a single slot. When we don't have a slave, new builds (once
8474 they make it past the timeout) are now merged into an existing
8475 buildable one instead of being queued. With this change, a slave
8476 which has been away for a while doesn't get pounded with all the
8477 builds it missed, but instead just does a single build.
8479 2003-05-07 Brian Warner <warner@lothar.com>
8481 * setup.py (version): bump version to 0.3.2+ while between releases
8483 2003-05-07 Brian Warner <warner@lothar.com>
8485 * setup.py: Releasing buildbot-0.3.2
8487 2003-05-07 Brian Warner <warner@lothar.com>
8489 * setup.py: fix major packaging error: include subdirectories!
8491 * NEWS: add changes since last release
8493 * README (REQUIREMENTS): update twisted/python dependencies
8495 * buildbot/status/builder.py (Builder.startBuild): change
8496 BuildProcess API: now they should call startBuild/finishBuild
8497 instead of pushing firstEvent / setLastBuildStatus. Moving towards
8498 keeping a list of builds in the statusbag, to support other kinds of
8500 (Builder.addClient): send current-activity-small to new clients
8501 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
8504 * buildbot/status/client.py: drop RemoteReferences at shutdown
8506 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8508 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8509 more debug messages for remote status client
8511 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8512 (.stepFailed): only fire the Deferred once, even if both
8513 stepComplete and stepFailed are called. I think this can happen if
8514 an exception occurs at a weird time.
8516 * buildbot/status/words.py: work-in-progress: IRC status delivery
8518 2003-05-05 Brian Warner <warner@lothar.com>
8520 * docs/examples/twisted_master.py (twisted_app): hush internal
8521 python2.3 distutils deprecation warnings
8522 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8523 add compileOpts= argument which inserts extra args before the
8524 "setup.py build_ext" command. This can be used to give -Wignore
8525 warnings, to hush some internal python-2.3 deprecation messages.
8527 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8528 the ['twisted.test'] default test case to make it easier to change
8531 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8532 * buildbot/clients/gtkPanes.py: ditto
8534 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8535 arg to collapse RunUnitTestsRandomly into RunUnitTests
8536 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8537 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8539 * buildbot/status/html.py (StatusResource): shuffle Resources
8540 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8541 would serve the waterfall display, but the internal links were
8542 only valid on the trailing-slash version. The correct behavior is
8543 for the non-slashed one to serve a Redirect to the slashed one.
8544 This only shows up when the buildbot page is hanging off another
8545 server, like a Twisted-Web distributed server.
8547 * buildbot/status/event.py (Event, RemoteEvent): make Events
8548 pb.Cacheable, with RemoteEvent as the cached version. This removes
8549 a lot of explicit send-an-update code.
8550 * buildbot/status/builder.py (Builder): remove send-update code
8551 * buildbot/status/client.py (ClientBuilder): remove send-update
8552 code, and log errors that occur during callRemote (mostly to catch
8553 InsecureJelly exceptions)
8555 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8556 run Lore with the same python used in the rest of the build
8558 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8560 * buildbot/process/step_twisted.py (HLint): accept 'python'
8561 argument. Catch rc!=0 and mark the step as failed. This marks the
8562 build orange ("has warnings").
8563 (RunUnitTestsJelly): move out to step_twisted2.py
8565 * buildbot/util.py (ignoreStaleRefs): add utility function
8567 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8568 don't fake ETA object, it's too hard to get right
8570 2003-05-02 Brian Warner <warner@lothar.com>
8572 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8574 2003-05-01 Brian Warner <warner@lothar.com>
8576 * buildbot/status/html.py (StatusResource.body): oops, I was
8577 missing a <tr>, causing the waterfall page to be misrendered in
8578 everything except Galeon.
8580 2003-04-29 Brian Warner <warner@lothar.com>
8582 * docs/examples/twisted_master.py: make debuild use python-2.2
8583 explicitly, now that Twisted stopped supporting 2.1
8585 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8586 handle tuple results too. I keep forgetting this, which suggests
8587 it needs to be rethought.
8589 * setup.py (setup): bump version to 0.3.1+ while between releases
8591 2003-04-29 Brian Warner <warner@lothar.com>
8593 * setup.py: Releasing buildbot-0.3.1
8595 2003-04-29 Brian Warner <warner@lothar.com>
8597 * README (SUPPORT): add plea to send questions to the mailing list
8599 * NEWS, MANIFEST.in: add description of recent changes
8601 * docs/examples/twisted_master.py: add the code used to create the
8602 Twisted buildmaster, with passwords and such removed out to a
8605 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8606 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8607 buildmasters to not require CVSToys be installed.
8608 * README, docs/examples/glib_master: update to match the change
8610 * buildbot/clients/base.py, buildbot/bot.py,
8611 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8612 ReconnectingPB from CVSToys distribution to remove CVSToys
8613 dependency for build slaves and status clients. Buildmasters which
8614 use FreshCVSSources still require cvstoys be installed, of course.
8616 2003-04-25 Brian Warner <warner@lothar.com>
8618 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8619 runTestsRandomly arg to turn on trial -z
8621 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8622 experimental code to use trial's machine-parseable output to get
8623 more detailed test results. Still has some major issues.
8624 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8627 * buildbot/status/builder.py (Builder.setCurrentBuild):
8628 anticipating moving build history into statusbag, not used yet
8630 * buildbot/status/tests.py: code to centralize test results,
8631 doesn't work quite yet
8633 * buildbot/status/event.py (Event): use hasattr("setName") instead
8634 of isinstance for now.. need better long-term solution
8636 * buildbot/status/html.py: Remove old imports
8638 2003-04-24 Brian Warner <warner@lothar.com>
8640 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8641 ignore changes under doc/fun/ and sandbox/
8643 * buildbot/process/step_twisted.py: update pushEvent and friends.
8645 * buildbot/status/html.py (Box.td): replace event.buildername with
8646 event.parent.getSwappableName(). Needs more thought.
8648 * buildbot/status/builder.py (Builder): Replace pushEvent and
8649 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8650 Tell events they are being pruned with event.delete().
8652 * buildbot/process/base.py (Build): Remove Builder status-handling
8653 methods. s/pushEvent/setCurrentActivity/.
8655 * buildbot/process/step.py (BuildStep): clean up status delivery.
8656 Gouse builder.statusbag methods instead of intermediate builder
8657 methods. s/updateLastEvent/updateCurrentActivity/.
8658 s/finalizeLastEvent/finishCurrentActivity/. Use
8659 addFileToCurrentActivity for summaryFunction.
8661 * buildbot/status/event.py (Logfile): put data in a Swappable when
8663 (Event): add more setter methods. Remove .buildername, use .parent
8664 and getSwappableName instead (needs more thought).
8666 * buildbot/util.py (Swappable):
8667 * test/test_swap.py: don't bother setting filename at __init__
8668 time, do it later. Change setFilename args to take parent first,
8669 since it provides the most significant part of the filename.
8671 2003-04-23 Brian Warner <warner@lothar.com>
8673 * buildbot/status/event.py (Logfile.addEntry): append to previous
8676 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8677 anticipating Swappable
8678 (InternalShellCommand.remoteUpdate): split out various log-adding
8679 methods so subclasses can snarf stdout separately
8681 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8682 in anticipation of Swappable build logs
8683 (Builder.testsFinished): anticipating TestResults, still disabled
8685 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8688 * buildbot/status/event.py (Logfile): add (disabled) support for
8689 Swappable, not ready for use yet
8691 * buildbot/util.py (Swappable): object which is swapped out to
8692 disk after some period of no use.
8693 * test/test_swap.py: test buildbot.utils.Swappable
8695 2003-04-14 Brian Warner <warner@lothar.com>
8697 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8698 periodic-build timer. Set the .periodicBuildTime on a builder
8699 instance to some number of seconds to activate it.
8701 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8703 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8704 a way that survives result tuples
8706 2003-04-12 Brian Warner <warner@lothar.com>
8708 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8709 return a dict instead of a tuple: allow summarizers to provide
8710 multiple summaries if they want
8711 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8712 (debuildSummarizer): summarize lintian warnings/errors
8714 2003-04-10 Brian Warner <warner@lothar.com>
8716 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8718 2003-04-09 Brian Warner <warner@lothar.com>
8720 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8721 empty summaries: happens when the tests fail so hard they don't emit
8722 a parseable summary line.
8724 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8725 Allow summaryFunction to return None to indicate no summary should
8728 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8729 writing to stale HTTP requests: notice when they disconnect and
8730 remove the request from the list. Also add CacheToFile from
8731 moshez, will be used later.
8733 2003-04-08 Brian Warner <warner@lothar.com>
8735 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8736 should be an int, not a list of strings
8738 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8739 if we weren't actually connected
8741 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8742 to show the tail end of the trial text output
8744 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8745 hook to summarize the results of a ShellCommand
8747 2003-04-07 Brian Warner <warner@lothar.com>
8749 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8750 twisted test suite code into a single class.
8751 * buildbot/process/process_twisted.py: same
8753 2003-04-04 Brian Warner <warner@lothar.com>
8755 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8757 * README (SLAVE): document use of mktap to create slave .tap file
8758 (REQUIREMENTS): describe dependencies
8760 * buildbot/bb_tap.py, buildbot/plugins.tml:
8761 * buildbot/bot.py (updateApplication): Add mktap support for creating
8762 buildslave .tap files
8764 2003-03-28 Brian Warner <warner@lothar.com>
8766 * buildbot/process/step.py (InternalShellCommand.finished): handle
8767 new tuple result values (fix embarrasing bug that appeared during
8770 2003-03-27 Brian Warner <warner@lothar.com>
8772 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8775 2003-03-25 Brian Warner <warner@lothar.com>
8777 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8778 to overall build status
8779 * buildbot/clients/base.py (Builder): improve event printing
8780 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8781 instead of generic ShellCommand
8782 (Build): Add .stopBuild, use it when slave is detached
8784 * buildbot/process/step.py (Configure,Test): give the steps their
8785 own names and status strings
8787 * buildbot/status/html.py (StatusResource): add "show" argument,
8788 lets you limit the set of Builders being displayed.
8790 2003-03-20 Brian Warner <warner@lothar.com>
8792 * buildbot/process/basic.py: removed
8794 2003-03-19 Brian Warner <warner@lothar.com>
8796 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8797 turn off process-docs by default
8799 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8800 when displaying build information without anything in allBuilds[]
8802 * buildbot/bot.py (makeApp): really take password from sys.argv
8804 2003-03-18 Brian Warner <warner@lothar.com>
8806 * buildbot/bot.py (buildApp): take password from sys.argv
8808 * README: replace with more useful text
8810 * setup.py: add a real one
8811 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8813 * docs/PyCon-2003/: added sources for PyCon paper.
8815 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8816 now Build objects control the process and Builder only handles
8817 slave stuff and distribution of changes/status. A new BuildFactory
8818 class creates Build objects on demand.
8820 Created ConfigurableBuild which takes a list of steps to run. This
8821 makes it a lot easier to set up a new kind of build and moves us
8822 closer to being able to configure a build from a web page.
8824 * buildbot/process/step_twisted.py, process_twisted.py: move to
8825 new model. A lot of code went away.
8827 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8828 send lots of empty progress messages to the client.
8830 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8832 2003-02-20 Brian Warner <warner@lothar.com>
8834 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8836 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8837 Twisted bug that prevented non-pty processes from working just got
8838 fixed, and the bug that leaks ptys is still being investigated.
8840 * buildbot/process/step.py (CVS): send timeout arg to slave
8842 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8843 builders coming and going
8844 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8845 from CVSToys, handle lost-buildmaster
8847 * buildbot/status/client.py (StatusClientService.removeBuilder):
8848 Clean up status client protocol: send builders (with references)
8849 as they are created, rather than sending a list and requiring the
8850 client to figure out which ones are new.
8851 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8852 attempts to force a build on an unknown builder
8854 2003-02-19 Brian Warner <warner@lothar.com>
8856 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8857 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8858 Twisted stops leaking them.
8859 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8860 builder goes to an idle state.
8862 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8863 I figure out why CVS commands hang without them, and/or I fix the
8864 hung-command timeout
8866 2003-02-16 Brian Warner <warner@lothar.com>
8868 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8869 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8870 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8871 GenerateDocs now that they are prefixed with WARNING:.
8873 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8874 use manual href target instead of request.childLink
8876 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8877 display every second, but update the ETA every 5 seconds (or
8878 whenever) as remote_progress messages arrive.
8881 2003-02-12 Brian Warner <warner@lothar.com>
8883 * *: import current sources from home CVS repository
8887 # add-log-time-format: add-log-iso8601-time-string