1 2007-02-07 Brian Warner <warner@lothar.com>
3 * contrib/OS-X/*: add some launchd .plist files for automatically
4 starting a buildmaster or buildslave under OS-X (10.4 or later).
5 Thanks to Mark Pauley for these.
7 2007-02-06 Brian Warner <warner@lothar.com>
9 * docs/buildbot.texinfo (Requirements): update requirements to
10 stop claiming compatibility with python-2.2 or twisted-1.3.x .
12 * README: mention python-2.5 and twisted-2.5 compatibility
14 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
16 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
18 * buildbot/status/builder.py: same, by requiring cStringIO
19 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
20 * buildbot/test/test_vc.py: same
21 * buildbot/test/test_web.py:
22 * buildbot/test/test_steps.py: same, remove unused import
24 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
27 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
28 see any Builders that don't have Schedulers to drive them
30 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
31 attributes this uses went away
33 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
34 dialog, to allow you to reset the buildmaster and force
35 connect/disconnect. Correctly handle losing the buildmaster
36 connection (by switching the display to the hexnut, at which point
37 you can use the 'Connect' menu item to reconnect).
39 * buildbot/steps/source.py (Source.start): if we're using a patch,
40 add it as a LogFile to the checkout/update step. This will turn
41 into a link on the waterfall page.
43 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
44 option, to take the patch from a pre-made file rather than
45 generating it from the local tree. Thanks to Robert Helmer for the
46 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
47 * buildbot/scripts/runner.py (TryOptions): add --diff,
48 --patchlevel, and --baserev options
49 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
50 as None, meaning HEAD.
51 * buildbot/sourcestamp.py (SourceStamp): update docstring to
52 indicate that baserev=None means HEAD
53 * docs/buildbot.texinfo (try --diff): document it
55 * buildbot/test/test_steps.py (BuildStep): remove use of
56 reactor.iterate(), although the technique I replaced it with is a
57 gross polling hack that must be cleaned up properly some day. This
58 was the last use of reactor.iterate in the entire tree, yay.
60 2007-02-05 Brian Warner <warner@lothar.com>
62 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
63 is one of the three known values, otherwise we emit some confusing
64 messages later on. Thanks to Grig Gheorghiu for the catch.
66 2007-01-30 Brian Warner <warner@lothar.com>
68 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
69 Hearsum contributed a patch to let BonsaiPoller work with results
70 that contain non-ascii characters. Closes SF#1632641.
72 2007-01-27 Brian Warner <warner@lothar.com>
74 * Makefile (release): produce both .tar.gz and .zip source bundles.
77 2007-01-23 Brian Warner <warner@lothar.com>
79 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
80 * buildbot/changes/monotone.py: same
82 * buildbot/changes/maildir.py: combine several files into one,
83 clean up maildir.py to use Services properly.
84 * buildbot/changes/maildirtwisted.py: remove
85 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
87 * buildbot/changes/mail.py: match the change
88 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
89 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
91 * buildbot/slave/commands.py (command_version): bump to "2.3" to
92 indicate that the buildslave knows about the 'bzr' command
94 2007-01-22 Brian Warner <warner@lothar.com>
96 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
97 'with', it will become a reserved work in python2.6 .
99 * contrib/bb_applet.py: add a simple gnome-panel applet, to
100 display a terse summary of buildbot status.
101 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
102 some icons, small versions of the Blender object that lives in
103 docs/images/icon.blend
105 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
106 * buildbot/slave/commands.py (Bzr): same
107 * buildbot/scripts/tryclient.py (BzrExtractor): same
108 (SourceStampExtractor.dovc): modify this to allow non-zero exit
109 status, since 'bzr diff' does that
110 * buildbot/test/test_vc.py (Bzr): same
111 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
115 2007-01-20 Brian Warner <warner@lothar.com>
117 * contrib/darcs_buildbot.py: tidy up the progress messages
119 2007-01-17 Brian Warner <warner@lothar.com>
121 * contrib/darcs_buildbot.py: enhance to handle multiple patches
122 being pushed at a time. This keeps state in the repository in a
123 small file named .darcs_buildbot-lastchange, but that shouldn't
124 interfere with normal repository operations. Fixes SF#1534049.
125 * buildbot/clients/sendchange.py (Sender): make a single Sender
126 capable of sending Changes with different usernames.
128 2006-12-11 Brian Warner <warner@lothar.com>
130 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
131 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
132 buildbot.changes.mail a long time ago, but I forgot to add the
133 DeprecationWarning until now.
135 * buildbot/process/maxq.py: remove this, the functionality now
136 lives in buildbot.steps.maxq
138 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
139 * buildbot/clients/gtkPanes.py: remove unused import
141 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
142 that was meant to provide a special Reporter to run inside trial
143 and give the buildslave lots of machine-readable status. We never
144 finished this project.
146 * buildbot/changes/bonsaipoller.py: remove unused imports
147 * buildbot/changes/svnpoller.py: same
148 * buildbot/process/builder.py: same
149 * buildbot/process/buildstep.py: same
150 * buildbot/slave/bot.py: hush pyflakes warning
151 * buildbot/status/tests.py: remove unused imports
152 * buildbot/status/tinderbox.py: same
153 * buildbot/steps/python_twisted.py: same
155 * buildbot/process/step.py: remove this file, these names were
156 deprecated in 0.7.5 and are now being removed.
157 * buildbot/process/step_twisted.py: same
158 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
160 * buildbot/twcompat.py: remove the empty file, yay it is gone
162 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
163 tw-2.0.0 and newer have the method we need.
164 (getProcessOutputAndValue): same
165 (which): remove this method, tw-2.0.0 t.p.procutils has it
167 * buildbot/twcompat.py (implements): remove this method
168 * buildbot/*: import implements() from zope.interface directly
170 * buildbot/status/mail.py: stop falling back to importing
171 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
174 * buildbot/twcompat.py (Interface): remove this import
175 * buildbot/*: import Interface from zope.interface directly
177 * buildbot/twcompat.py (providedBy): remove this method
178 * buildbot/*: turn all uses of providedBy(obj, iface) into
179 iface.providedBy(obj)
181 * buildbot/twcompat.py (maybeWait): remove this method, now that
182 we no longer maintain compatibility with Twisted<=1.3.0 .
183 Twisted-2.0.0 and later allow trial methods to return Deferreds
185 * buildbot/test/*: remove all uses of maybeWait
187 * buildbot/__init__.py (version): bump to 0.7.5+ while between
189 * docs/buildbot.texinfo: same
191 2006-12-10 Brian Warner <warner@lothar.com>
193 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
194 * docs/buildbot.texinfo: set version to match
196 2006-12-10 Brian Warner <warner@lothar.com>
198 * README (REQUIREMENTS): update for release
199 * NEWS: update for release
200 * buildbot/slave/commands.py (command_version): mention that this
201 version (2.2) was released with buildbot-0.7.5
203 * buildbot/test/test_config.py (StartService.testStartService):
204 inhibit the usual read-config-on-startup behavior, since otherwise
205 the log.err that gets recorded causes the test to fail
207 * buildbot/status/builder.py (LogFile.finish): forget about all
208 subscribers once the log has finished, since after that point
209 we're never going to use them again. This might help free up some
212 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
213 than the old/deprecated gtk.mainquit()
215 2006-12-09 Brian Warner <warner@lothar.com>
217 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
218 better when we can't open the masterdst file
220 * buildbot/scripts/startup.py (Follower._failure): add missing
221 import statement for BuildSlaveDetectedError
223 * buildbot/steps/transfer.py (FileUpload): cleanup
224 (FileDownload): same. Add tests for slave version, add mode=.
225 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
226 (SlaveFileDownloadCommand): same
227 * buildbot/test/test_transfer.py: enhance tests
228 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
231 2006-12-08 Brian Warner <warner@lothar.com>
233 * buildbot/scripts/runner.py (sendchange): halt the reactor on
234 both success *and* failure. Without this, the 'buildbot
235 sendchange' command would hang if it could not contact the
236 buildmaster or deliver the Change, which would generally cause the
237 user's commit/record/checkin command to hang too. Thanks to
238 Christian Unger for the catch.
240 2006-12-06 Brian Warner <warner@lothar.com>
242 * NEWS: update with items for the next release
244 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
245 whimsical example pulled from a punch-drunk email I sent out late
247 (Transferring Files): document some of the other parameters
248 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
249 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
250 * buildbot/test/test_svnpoller.py: same
251 * buildbot/changes/svnpoller.py (SVNPoller): same
253 2006-11-26 Brian Warner <warner@lothar.com>
255 * docs/buildbot.texinfo (Build Properties): remind users that
256 WithProperties must appear in a command= list, not as a top-level
258 * buildbot/steps/shell.py (ShellCommand.start): and assert that
259 we're sending a list or a single string to the RemoteShellCommand
261 * buildbot/scheduler.py (Nightly): Improve docs slightly.
263 * buildbot/scripts/startup.py (start): skip the whole
264 watch-the-logfile thing under windows, since it needs os.fork()
266 * buildbot/scripts/runner.py (restart): remove the old message
267 that got printed after the buildbot was restarted.. it most cases
268 it didn't get printed at the right time anyways
270 2006-11-25 Brian Warner <warner@lothar.com>
272 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
273 follow twistd.log and print lines until the process has started
274 started properly. For the buildmaster, this means until the config
275 file has been parsed and accepted. For the buildslave, this means
276 until we've connected to the master. We give up after 5 seconds in
277 any case. Helpful error messages and troubleshooting suggestions
278 are printed when we don't see a successful startup. This closes the
279 remainder of SF#1517975.
280 * buildbot/scripts/startup.py: moved app startup code to here
281 * buildbot/scripts/logwatcher.py: utility class to follow log
282 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
283 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
284 so the LogWatcher can tell the difference between a buildmaster
287 2006-11-24 Brian Warner <warner@lothar.com>
289 * docs/examples/twisted_master.cfg: update to match the version
290 in use on twistedmatrix.com
291 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
292 was using before stopped working, but 'irc.freenode.net' works
295 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
298 * buildbot/clients/base.py (TextClient.not_connected): upon
299 UnauthorizedLogin failures, remind the user to connect to the
300 PBListener port instead of the slaveport.
301 (TextClient.disconnected): shut down more quietly
302 * docs/buildbot.texinfo (statuslog): add another reminder
304 * buildbot/scripts/runner.py (Options.subCommands): rename
305 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
306 'sighup' as an alias.
307 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
308 reconfig command to follow twistd.log and print all of the lines
309 from the start of the config-file reload to its completion. This
310 should make it a lot easier to discover bugs in the config file.
311 Use --quiet to disable this behavior. This addresses half of
312 SF#1517975, the other half will be to add this same utility to
313 'buildbot start' and 'buildbot restart'.
314 * docs/buildbot.texinfo (Loading the Config File): same
317 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
318 method, it has been deprecated for a long time. Use
319 IBuilderControl.requestBuild instead.
320 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
321 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
322 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
323 * buildbot/test/test_control.py (Force.testForce): same
324 * buildbot/test/test_run.py: use requestBuild instead
326 * buildbot/clients/debug.py: replace 'Force Build' button with
327 'Request Build' (which just adds one to the queue), add Ping
328 Builder, add branch/revision fields to Request Build.
329 * buildbot/clients/debug.glade: same
330 * buildbot/master.py: update interface to match. This creates an
331 incompatibility between new debugclients and old buildmasters.
333 * buildbot/process/builder.py (Builder._attached): delay the call
334 to maybeStartBuild for a reactor turn, to avoid starting a build
335 in the middle of a reconfig (say, if the new Builder uses a new
336 slave which is already connected).
338 2006-11-23 Brian Warner <warner@lothar.com>
340 * buildbot/test/test_transfer.py: appease pyflakes
341 * buildbot/test/test_steps.py: same
343 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
344 keeps pyflakes from finding undefined names
346 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
347 Builder no longer induces a disconnect/reconnect cycle. This means
348 that any builds currently in progress will not be interrupted, and
349 any builds which are queued in the Builder will not be lost. This
350 is implemented by having the new Builder extract the state (i.e.
351 all pending Builds and any desired SlaveBuilders) from the old
353 (BotPerspective): refactor. The BotPerspective no longer keeps
354 track of all the Builders that want to use this slave; instead, it
355 asks the BotMaster each time it needs this list. This removes
356 addBuilder and removeBuilder. Clean up attached() to acquire all
357 the slave's information in a more atomic fashion. updateSlave() is
358 now the way to make sure the slave is using the right set of
359 Builders: just call it after everything else has been
361 (BotMaster): refactor, removing addBuilder/removeBuilder and
362 replacing them with an all-at-once setBuilders() call.
364 * buildbot/test/test_slaves.py (Reconfig): new test case to
365 exercise this functionality
366 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
367 * buildbot/slave/commands.py (WaitCommand): same
369 * docs/buildbot.texinfo (Loading the Config File): document the
372 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
373 SlaveBuilder to have its parent Builder changed.
374 (SlaveBuilder.isAvailable): new method to give access to state,
375 which is now a private attribute
376 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
377 the SlaveBuilder about how it is being used. These methods update
378 its internal state. buildFinished() is now the place that invokes
379 maybeStartBuild() on its parent Builder.
380 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
381 new Builder to take over for an old one, transferring state from
383 (Buider): refactor the way that SlaveBuilders are used to match,
384 giving them a bit more autonomy.
385 (Builder.buildFinished): this no longer calls maybeStartBuild():
386 instead the SlaveBuilder calls it on whoever its parent Builder is
387 at the time. This way, when an old Builder is replaced by a new
388 one, and there was a build in progress during the transition, when
389 that build finishes, it will be the new Builder that is told about
390 the newly available slave so it can start a new build.
392 * buildbot/process/base.py (Build.startBuild._release_slave): when
393 the Build finishes, tell the SlaveBuilder that they've been
396 * buildbot/status/builder.py (SlaveStatus): add some new setter
397 methods for use by BotPerspective, to keep some attributes more
400 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
401 called by the buildmaster.
402 (Bot.setBuilderList): instead, we locally announce any leftover
403 directories based upon which Builders we were told about. The
404 master doesn't really care; it's the local admin who may or may not
408 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
409 to allow use of python2.4 or whatever. This tool still requires
412 2006-11-19 Brian Warner <warner@lothar.com>
414 * NEWS (IStatusLog.readlines): more news items
416 2006-11-18 Brian Warner <warner@lothar.com>
418 * NEWS: start collecting items for the next release.
420 2006-11-04 Brian Warner <warner@lothar.com>
422 * buildbot/changes/bonsaipoller.py: apply updates from Ben
423 Hearsum. Closes SF#1590310.
424 * buildbot/test/test_bonsaipoller.py: and tests
426 * buildbot/status/tinderbox.py
427 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
428 status when the build results in WARNINGS. Patch from Dave
429 Liebreich. Closes SF#1587352.
431 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
432 linux-vs-osx behavior difference w.r.t. reading from files that
433 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
434 to Mark Rowe for the patch.
436 2006-10-15 Brian Warner <warner@lothar.com>
438 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
439 method name was misspelled in the interface definition. Thanks to
440 Roy Rapoport for the catch.
442 2006-10-13 Brian Warner <warner@lothar.com>
444 * docs/buildbot.texinfo (Adding LogObservers): update sample code
445 to match the great Steps renaming
447 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
448 Maybe I should run my own unit tests before recording a big
449 change. Good thing I've got a buildbot to remind me.
451 2006-10-12 Brian Warner <warner@lothar.com>
453 * buildbot/steps/transfer.py: rework __init__ and args setup
454 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
456 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
457 when opening the target file, only catch IOError (to report via
458 stderr/rc!=0), let the others be reported as normal exceptions
460 2006-10-08 Brian Warner <warner@lothar.com>
462 * contrib/svn_watcher.py: fix security holes by using proper argv
463 arrays and subprocess.Popen() rather than commands.getoutput().
464 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
465 is deprecated in favor of buildbot/changes/svnpoller.py, and will
466 probably be removed by the next release.
469 2006-10-04 Brian Warner <warner@lothar.com>
471 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
472 initial lines that weren't emitted by pyflakes. When the pyflakes
473 command is run under a Makefile, 'make' will echo the command it
474 runs to stdio, and that was getting logged as a "misc" warning.
475 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
476 * buildbot/test/test_steps.py (testPyFlakes3): another test
478 2006-10-01 Brian Warner <warner@lothar.com>
480 * buildbot/status/html.py (HtmlResource.render): if we get a
481 unicode object from our content() method, encode it into utf-8
482 like we've been claiming to all along. This allows the comments
483 and author names from svnpoller.py to be delivered properly.
485 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
486 de-unicodify filenames before creating the Change, because the
487 rest of buildbot is unlikely to handle them well. Leave the 'who'
488 field as a unicode object.. I don't think there's anything that
489 will break very soon, and it will probably nudge us towards
490 accepting unicode everywhere sooner or later. Stop using the
491 "date" field that comes out of SVN, since it is using the
492 repository's clock (and timezone) and what we care about is the
493 buildmaster's (otherwise Changes from the future show up later
494 than the builds they triggered).
495 * buildbot/test/test_svnpoller.py (Everything.test1): match the
498 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
499 Suvbersion repository polling ChangeSource. I've hacked it up
500 considerably: any bugs are entirely my own fault. Thank you
502 * buildbot/test/test_svnpoller.py: tests for it
503 * docs/buildbot.texinfo (SvnSource): document it
505 2006-09-30 Brian Warner <warner@lothar.com>
507 * buildbot/scheduler.py (Periodic): submit a reason= to the
508 BuildSet to indicate which Scheduler triggered the build. Thanks
509 to Mateusz Loskot for the suggestion.
511 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
513 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
514 changes: set self.loop in __init__, remove unused volatile=
516 * docs/buildbot.texinfo (.buildbot config directory): add more
517 docs on the .buildbot/options keys used by "buildbot try"
518 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
519 (Try.deliverJob): same
521 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
525 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
526 close the filehandle when we stop watching the file. Before, the
527 filehandle was only closed when the LogFileWatcher was
528 garbage-collected, which could be quite a while in the future. If
529 it was still open by the time the next build started, windows will
530 refuse to let the new build delete the old build/ directory. Fixes
531 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
532 #twisted for the catch.
534 2006-09-29 Brian Warner <warner@lothar.com>
536 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
539 2006-09-25 Brian Warner <warner@lothar.com>
541 * setup.py: the new buildbot.steps module wasn't being installed.
542 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
543 (testmsgs): add the extra stuff from buildbot/test/* so you can
544 run unit tests on an installed copy of buildbot, not just from
547 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
548 columns of 'svnlook changed' output contain status information, so
549 strip [:4] instead of [:6]. Depending upon what the status flags
550 were, this would sometimes lead to mangled filenames. Thanks to
551 Riccardo Magliocchetti for the patch. Closes SF#1545146.
553 * buildbot/steps/source.py (Monotone): initial Monotone support,
554 contributed by Nathaniel Smith. Still needs docs and tests, but
555 this code has been in use on the Monotone buildbot for a long
557 * buildbot/slave/commands.py (Monotone): slave-side support
558 * buildbot/changes/monotone.py (MonotoneSource): polling change
561 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
562 contributed a Change Source that polls a Bonsai server (a
563 kind of web-based viewcvs CGI script).
565 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
566 Hearsum contributed a status plugin which sends email in the same
567 format that Tinderbox does: this allows a number of tinderbox
568 tools to be driven by Buildbot instead. Thanks Ben!
570 2006-09-24 Brian Warner <warner@lothar.com>
572 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
573 Thanks to Robert Helmer for the patch.
575 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
576 BuildStatus about the buildslave name at the *beginning* of the
577 build, rather than at the end. Thanks to Alexander Lorenz for the
579 * buildbot/status/html.py (StatusResourceBuild.body): always
580 include the slavename in the build page, not just when the build
582 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
583 slavename in the email message
585 2006-09-21 Brian Warner <warner@lothar.com>
587 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
589 * docs/examples/glib_master.cfg: same
590 * docs/examples/hello.cfg: same
591 * docs/examples/twisted_master.cfg: same, update to current usage
593 2006-09-19 Brian Warner <warner@lothar.com>
595 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
596 (PyFlakes.createSummary): make it compatible with python-2.2
598 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
599 for at least the output-parsing parts of PyFlakes
601 2006-09-18 Brian Warner <warner@lothar.com>
603 * buildbot/steps/python.py: oops, fix import of StringIO
605 2006-09-17 Brian Warner <warner@lothar.com>
607 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
608 turns out that SVN-1.4.0 doesn't fail to update once you've
609 replaced a file with a directory, unlike older versions of SVN and
610 pretty much every other VC tool we support. Since what we really
611 care about is that the update succeeds anyway, stop checking that
612 the tree got clobbered and just assert that the build succeeded.
613 (VCBase.printLogs): add a utility function for debugging
615 * buildbot/process/step.py: oops, added extra imports by mistake
617 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
618 rstrip() on the first line coming out of the 'p4 describe'
619 process, to remove the stray ^M that Wade Brainerd reports seeing
620 in the 'when' field. Fixes SF#1555985.
622 * buildbot/master.py (BuildMaster.loadConfig): improve the error
623 message logged when c['schedulers'] is not right
624 * buildbot/scheduler.py (Scheduler.__init__): improve error
625 message when a Scheduler() is created with the wrong arguments
626 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
627 verify that these error messages are emitted
629 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
630 The idea is that all the base classes (like BuildStep and
631 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
632 will be a leftover backwards-compatibility file that only contains
633 aliases for the steps that were moved out to buildbot.steps.*
634 * lots: change imports to match
635 * buildbot/process/step.py: add a DeprecationWarning if it ever
638 2006-09-12 Brian Warner <warner@lothar.com>
640 * buildbot/scheduler.py (Scheduler.__init__): make sure that
641 builderNames= is actually a sequence, since if you happen to give
642 it a single builder-specification dictionary instead, it won't get
643 caught by the existing assert. Thanks to Brett Neely for the
646 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
648 * docs/buildbot.texinfo (Python BuildSteps): document them
649 (sendchange): include a link to PBChangeSource, since you need one
651 * buildbot/steps/shell.py: clean up test-case-name line, remove some
653 * buildbot/steps/dummy.py: same
655 2006-09-08 Brian Warner <warner@lothar.com>
657 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
658 BuildStep which lets you transfer files from the master to the
659 slave or vice versa. Thanks to Albert Hofkamp for the original
660 patch. Fixes SF#1504631.
661 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
663 (SlaveFileDownloadCommand): same
664 * docs/buildbot.texinfo (Transferring Files): document it
665 * buildbot/test/test_transfer.py: test it
666 * buildbot/test/runutils.py (StepTester): new utility class for
667 testing BuildSteps and RemoteCommands without Builds or Bots or PB
668 * buildbot/test/test_steps.py (CheckStepTester): validate that the
671 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
672 walk through StatusLogs one line at a time, mostly for the benefit
673 of ShellCommand.createSummary methods. You can either walk through
674 STDOUT or STDERR, but the default is STDOUT.
676 * buildbot/status/builder.py (LogFile.readlines): implement it.
677 Note that this is not yet memory-efficient, it just pulls the
678 whole file into RAM and then splits it up with a StringIO.
679 Eventually this should be a generator that only pulls chunks from
681 * buildbot/test/test_status.py (Log.testReadlines): test it
683 * docs/buildbot.texinfo: update to match changes
684 * buildbot/process/factory.py: stop using old definitions
685 * buildbot/process/process_twisted.py: same
686 * buildbot/test/test_*.py: same
688 * buildbot/process/step_twisted.py: move definition to..
689 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
690 relative-import mechanisms prevent this from being named 'twisted'
691 or 'python/twisted' as I would have preferred.
693 * buildbot/process/maxq.py: move definition to..
694 * buildbot/steps/maxq.py: .. here, leave a compatibility import
696 * buildbot/process/step.py: split the user-visible BuildSteps into
697 separate files, all under buildbot/steps/
698 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
699 * buildbot/steps/shell.py: this holds ShellCommand and friends
700 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
702 2006-09-05 Brian Warner <warner@lothar.com>
704 * lots: run pyflakes, removed a lot of unused imports, changed the
705 form of some conditional imports to remove false pyflakes
706 warnings. There are still a number of warnings left, mostly from
707 imports that are done for their side-effects.
708 * buildbot/test/test_vc.py: import twisted.python.failure, since it
711 2006-08-26 Brian Warner <warner@lothar.com>
713 * buildbot/test/test_locks.py (Unit.testLater): make the tests
714 compatible with twisted-1.3.0, for some reason I just can't seem
715 to let go of the past.
717 2006-08-25 Brian Warner <warner@lothar.com>
719 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
721 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
722 all logfiles= in startCommand(), rather than in start() . This
723 makes it easier to have the 'stdio' log come before any secondary
724 logfiles, which I feel makes the waterfall display more
726 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
727 from ShellCommand up into LoggingBuildStep
728 (LoggingBuildStep.__init__): move the handling of logfiles= from
729 ShellCommand up to LoggingBuildStep, because startCommand is
730 provided by LoggingBuildStep, whereas start() was specific to
731 subclasses like ShellCommand and Source. This removes code
732 duplication in those subclasses.
733 (ShellCommand.__init__): same
734 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
735 for a slave that's too old to understand logfiles= into a separate
736 method, so it can live in ShellCommand. The rest of
737 setupLogfiles() can live in LoggingBuildStep.
739 2006-08-24 Brian Warner <warner@lothar.com>
741 * buildbot/locks.py (BaseLock): you can now configure Locks to
742 allow multiple simultaneous owners. They still default to
743 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
745 * docs/buildbot.texinfo (Interlocks): document the new options
746 * buildbot/test/test_locks.py: add a bunch of new unit tests
747 * buildbot/process/base.py (Build.acquireLocks): locks now offer
748 waitUntilMaybeAvailable, not waitUntilAvailable
749 * buildbot/process/step.py (BuildStep.acquireLocks): same
750 * buildbot/master.py (BotMaster.getLockByID): real locks now use
751 the whole lockid in their constructor, not just the name. Also,
752 keep track of which real locks we've handed out by the full
753 lockid, not just class+name, otherwise changing just the maxCount=
754 in the master.cfg file would not actually cause a behavioral
757 2006-08-23 Brian Warner <warner@lothar.com>
759 * buildbot/__init__.py (version): bump to 0.7.4+ while between
761 * docs/buildbot.texinfo: same
763 2006-08-23 Brian Warner <warner@lothar.com>
765 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
766 * docs/buildbot.texinfo: set version to match
767 * NEWS: update for 0.7.4
768 * buildbot/slave/commands.py (command_version): mention that this
769 version (2.1) was released with buildbot-0.7.4
771 2006-08-22 Brian Warner <warner@lothar.com>
775 * CREDITS: new file, list of people who have helped. Thanks!
776 * MANIFEST.in: ship it
778 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
779 new diagrams, the user's manual is more informative than it was.
780 Start shipping the .html user's manual (and generated .png
782 * Makefile: update 'release' target to match
784 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
785 test.. I think the web-parts effort will render it pointless well
786 before it ever actually starts to work.
788 2006-08-20 Brian Warner <warner@lothar.com>
790 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
791 meaning of the prefix= argument. It is now just a string which is
792 stripped from the beginning of the filename. If prefix= is set but
793 not found on any given filename, that filename is ignored. If all
794 filenames in a Change are ignored, the Change is dropped. This is
795 much simpler than the previous sep= nonsense, and I should have
796 implemented it this way from the beginning. Effectively resolves
797 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
798 Gedminas for the catch and suggested fixes.
799 (ChangePerspective.perspective_addChange): implement the actual
801 * buildbot/test/test_changes.py (TestChangePerspective): test it
802 * docs/buildbot.texinfo (PBChangeSource): document it, explain
803 how to properly use prefix=
804 * docs/examples/twisted_master.cfg (source): update prefix= by
805 adding the trailing slash
808 * docs/examples/twisted_master.cfg: update to actual practice
810 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
811 update test case to match new link text.. the HREF has both a
812 class= setting and an enclosing [] pair that I didn't match in the
815 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
816 list of strings is preferred over a single string with embedded
818 (ShellCommand.description=): explain that either single strings or
819 a list of strings is acceptable, and why you might prefer one over
820 the other. Add an example. Fixes SF#1524659, thanks to Paul
821 Winkler for the catch.
822 (Build Steps): update to use f.addStep() rather than using s()
823 and the constructor list
825 * buildbot/process/step.py (ShellCommand): accept either a single
826 string or a list of strings in both description= and
828 * buildbot/test/test_steps.py (Steps.test_description): test it
829 * buildbot/test/runutils.py (makeBuildStep): support for that test
831 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
832 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
833 collecting the files and creating the patch.
835 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
836 per-step URLs that will be displayed on the waterfall display,
837 for things like the HTML output of code-coverage tools, when
838 the results are hosted elsewhere.
839 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
840 way to retrieve these URLs
841 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
842 the method to retrieve these URLs. Also provide backwards
843 compatibility for saved BuildStepStatus instances that didn't have
845 * buildbot/process/step.py (BuildStep.addURL): method to set these
846 URLs from within a BuildStep
847 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
848 (StepBox.getBox): give these external links a distinct CSS class
849 named "BuildStep external" so a .css file can display them
852 * buildbot/test/test_web.py (WaterfallSteps): test that we really
854 * buildbot/test/test_steps.py (Steps): test that we can all the
855 URLs. Also add a bunch of other tests on methods that can be
856 called from within BuildSteps
857 * buildbot/test/runutils.py (makeBuildStep): add utility function
859 2006-08-13 Brian Warner <warner@lothar.com>
861 * docs/buildbot.texinfo (BuildStep LogFiles): document them
863 2006-08-10 Brian Warner <warner@lothar.com>
865 * docs/buildbot.texinfo (Index of master.cfg keys): add another
866 index, this one of things like c['sources'] and c['schedulers']
867 (indices): it looks like my clever idea of putting the @fooindex
868 commands in between the @node and the @subsection (to make the
869 HREF anchor jump to slightly above the section title, which works
870 much better in html) confused texinfo horribly, so I'm moving the
871 index tags back to be just after the @subsection marker. I also
872 added extra lines between the @node/@section paragraph and the
873 index tags, since I think maybe texinfo wants to see these be
876 * docs/Makefile (images): make sure images get built when
878 * docs/images/Makefile: same
880 * buildbot/scripts/runner.py: rename 'buildbot master' to
881 'buildbot create-master', and 'buildbot slave' to 'buildbot
883 * docs/buildbot.texinfo: same
886 * docs/buildbot.texinfo: reimplement the "useful classes" index
887 with actual texinfo indices. The .info rendering is a bit
888 weird-looking but it works well, and the HTML rendering is quite
889 nice. This also puts the index targets in the regular flow of the
890 text, which is easier to maintain.
892 2006-08-06 Brian Warner <warner@lothar.com>
894 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
895 Kevin Turner to prefer the environ= argument be a list rather than
896 a string. If it is a list, it will be joined with a platform-local
897 os.pathsep delimiter, and then prepended to any existing
898 $PYTHONPATH value. This works better in cross-platform (i.e.
899 windows buildslaves) environments when you need to push multiple
900 directories onto the front of the path.
901 (SlaveShellCommand): documented the new magic
902 * docs/buildbot.texinfo (ShellCommand): documented the new magic
903 in a user-visible form
905 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
906 Turner to prefer lists over strings when creating/running VC
907 commands during unit tests. This is clearly necessary to survive
908 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
909 renamed the wq() function to qw() though, since that's how it's
910 spelled in perl. Eventually I'd prefer all commands to be
911 specified with lists.
913 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
914 which are deleted (or not yet created) correctly. Also add
915 failsafe code to not explode if the file-watching poller doesn't
916 get started. Thanks to JP Calderone for the catch and the poller
918 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
920 * buildbot/test/emitlogs.py: same
922 * NEWS: summarize recent changes
924 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
925 clause to avoid the "host key mismatch" warning
927 * buildbot/process/step_twisted.py (Trial.start): if the
928 buildslave is too old to understand logfiles=, fall back to
929 running 'cat _trial_temp/test.log' like before.
930 (Trial.commandComplete): same. this takes advantage of the
931 LoggingBuildStep refactoring to stall commandComplete long enough
932 to run a second RemoteShellCommand.
934 * buildbot/process/step.py (LoggingBuildStep.startCommand):
935 refactor command-completion handling, to allow methods like
936 commandComplete/createSummary/evaluateCommand to return Deferreds.
937 (LoggingBuildStep._commandComplete): delete the refactored method
938 (ShellCommand.setupLogfiles): if the buildslave is too old to
939 understand logfiles=, put a warning message both into twistd.log
940 and into the otherwise empty user-visible LogFiles.
942 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
943 callers to provide the slave-side logfile name, rather than
944 forcing it to come from the local name of the LogFile.
945 (BuildStep.getSlaveName): new method
947 * buildbot/process/base.py (Build.getSlaveName): new method, so
948 steps can find out which buildslave they're running on
950 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
951 to match the s/cvs_ver/command_version/ change
953 2006-08-05 Brian Warner <warner@lothar.com>
955 * buildbot/slave/commands.py (command_version): replace the CVS
956 auto-updated cvs_ver keyword with a manually-updated variable,
957 since CVS is no longer the master repository. Add a description of
958 the remote API change starting in this version (2.1), specifically
959 the fact that SlaveShellCommand now accepts 'initial_stdin',
960 'keep_stdin_open', and 'logfiles'.
962 2006-07-31 Brian Warner <warner@lothar.com>
964 * docs/buildbot.texinfo (System Architecture): Finally add lots of
965 diagrams to describe how the whole system fits together. The
966 images themselves are kept in SVG files, with ascii-art versions
967 in corresponding .txt files. Texinfo knows how to interpolate the
968 text version into .info files, reference the .png versions from
969 .html files, and include .eps versions in the .ps format.
970 * docs/images/Makefile: tools to create .png and .eps
971 * docs/images/*.svg: created pictures with Inkscape.
972 * .darcs-boring: ignore the generated .eps and .png files
974 2006-07-24 Brian Warner <warner@lothar.com>
976 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
977 Scheduler names, since they cause setServiceParent to explode
979 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
981 2006-07-20 Brian Warner <warner@lothar.com>
983 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
984 which runs the buildbot unit tests
986 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
987 classes that are useful in master.cfg
989 2006-07-15 Brian Warner <warner@lothar.com>
991 * Makefile (some-apidocs): new target to build only some epydocs
993 * setup.py: minor comment.. does the classifiers= argument prevent
994 the setup.py script from working on python2.2/2.3?
996 * buildbot/scripts/sample.cfg: update manhole example, arrange into
999 * buildbot/twcompat.py: fix minor typo in comments
1001 * buildbot/manhole.py: move all Manhole-related code out to this
1002 module. Implement SSH-based manholes (with TwistedConch), and move
1003 to conch's nifty line-editing syntax-coloring REPL shell instead
1004 of the boring non-editing monochromatic (and deprecated) old
1006 * buildbot/master.py: remove all Manhole-related code
1007 (BuildMaster.loadConfig._add): make sure the old manhole is
1008 removed before we add the new one
1009 * docs/buildbot.texinfo (Debug options): document new Manhole options
1011 * buildbot/twcompat.py (_which): fix some epydoc issues
1012 * buildbot/status/html.py (Waterfall.__init__): same
1014 2006-06-29 Brian Warner <warner@lothar.com>
1016 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1017 deprecation warnings under newer Twisteds (by using
1018 zope.interface.Interface instead of old twisted.python.components
1020 * buildbot/slave/interfaces.py: same
1022 2006-06-28 Brian Warner <warner@lothar.com>
1024 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1025 svn commands, so it will fail immediately instead of hanging while
1026 it waits for a username/password to be typed in.
1028 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1029 log message if the step was shut down
1031 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1032 obsolete reference to mktap.
1034 2006-06-20 Brian Warner <warner@lothar.com>
1036 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1037 test to include new 'logfiles' argument sent from master to slave
1039 2006-06-19 Brian Warner <warner@lothar.com>
1041 * buildbot/process/step_twisted.py (Trial): track Progress from
1042 _trial_temp/test.log too
1044 * buildbot/process/step.py (OutputProgressObserver): generalize
1045 the earlier StdioProgressObserver into an OutputProgressObserver
1046 that can track LogFiles other than stdio.
1047 (LoggingBuildStep.__init__): same
1049 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1050 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1051 will fail under windows because of os.sep issues. It might have
1052 worked before if 'cat' was doing cygwin path conversion.
1054 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1055 creation of LogFileWatchers
1056 (ShellCommand._startCommand): and record the files that were
1057 watched in the 'headers' section of the ShellCommand output
1059 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1060 need to actually pass it to the slave if you want it to work.
1061 (ShellCommand): document it a bit
1063 * buildbot/test/test_shell.py: new test to validate LogFiles
1064 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1066 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1067 before printing the last batch of lines, to test that the polling
1068 logic is working properly
1070 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1071 handling, making it possible to track multiple logs for a single
1072 RemoteCommand. The previous single logfile is now known as the
1074 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1075 (RemoteShellCommand.__init__): accept logfiles=
1076 (LoggingBuildStep.startCommand): stdio_log is now one of many
1077 (ShellCommand): added logfiles= argument, as well as a class-level
1078 .logfiles attribute, which will be merged together to figure out
1079 which logfiles should be tracked. The latter maybe be useful for
1080 subclasses of ShellCommand which know they will aways produce
1081 secondary logfiles in the same location.
1083 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1084 and closeStdin() methods, preparing to make it possible to write
1085 to a ShellCommand's stdin at any time, not just at startup. These
1086 writes are buffered if the child process hasn't started yet.
1087 (LogFileWatcher): new helper class to watch arbitrary logfiles
1088 while a ShellCommand runs. This class polls the file every two
1089 seconds, and sends back 10k chunks to the buildmaster.
1090 (ShellCommand): rename stdin= to initialStdin=, and add
1091 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1093 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1094 key of "log" and a value of (logname, data).
1095 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1096 'logfiles' to the master-visible args dictionary.
1097 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1100 * buildbot/test/test_vc.py (Patch.testPatch): same
1103 * buildbot/test/emit.py: write to a logfile in the current
1104 directory. We use this to figure out what was used as a basedir
1105 rather than looking to see which copy of emit.py gets run, so that
1106 we can run the commands from inside _trial_temp rather than inside
1108 * buildbot/test/subdir/emit.py: same
1109 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1110 argument rather than running from buildbot/test/
1111 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1112 rather than using an implicit setUp()
1113 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1114 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1115 of assuming that we're running in buildbot/test/ (and that '.' is
1118 * buildbot/slave/commands.py (Command.doStart): refactor Command
1119 startup/completion a bit: now the SlaveBuilder calls doStart(),
1120 which is not meant for overridding by subclasses, and doStart()
1121 calls start(), which is. Likewise the SlaveBuilder calls
1122 doInterrupt(), and subclasses override interrupt(). This also puts
1123 responsibility for maintaining .running in Command rather than in
1125 (Command.doInterrupt): same
1126 (Command.commandComplete): same, this is called when the deferred
1127 returned by start() completes.
1128 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1129 (SlaveBuilder.remote_interruptCommand): same
1130 (SlaveBuilder.stopCommand): same
1132 2006-06-16 Brian Warner <warner@lothar.com>
1134 * buildbot/test/test_shell.py: new test file to contain everything
1135 relating to ShellCommand
1136 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1137 multiple logfiles in realtime" feature, not yet implemented
1138 * buildbot/test/emitlogs.py: support file for testLogFiles
1139 * docs/buildbot.texinfo (ShellCommand): document the feature
1141 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1143 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1144 for tests which exercise SlaveCommands in isolation.
1146 * buildbot/test/test_slavecommand.py: Move some utilities like
1147 SignalMixin and FakeSlaveBuilder from here ..
1148 * buildbot/test/runutils.py: .. to here, so they can be used by
1149 other test classes too
1150 * buildbot/test/test_vc.py: more SignalMixin refactoring
1151 * buildbot/test/test_control.py: same
1152 * buildbot/test/test_run.py: and some rmtree refactoring
1154 2006-06-15 Brian Warner <warner@lothar.com>
1156 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1157 'testBranch' to match other VC tests and have the tests run in
1158 roughly increasing order of dependency
1160 * buildbot/test/test_steps.py (LogObserver): new test to verify
1161 LogObservers can be created at various times and still get
1162 connected up properly
1164 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1165 to create BuildStepStatus instances that actually work.
1167 * buildbot/process/step.py (LogObserver): add outReceived and
1168 errReceived base methods, to be overridden
1170 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1171 API to take a name instead of a step, reducing the coupling
1172 somewhat. This returns the BuildStepStatus object so it can be
1173 passed to the new Step, instead of jamming it directly into the
1175 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1177 * buildbot/process/base.py (Build.setupBuild): use both methods
1178 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1179 process a bit to match
1181 2006-06-14 Brian Warner <warner@lothar.com>
1183 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1184 docs on writing new LogObserver classes
1185 (Writing New Status Plugins): brief docs on how Status Plugins fit
1188 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1189 implement a LogObserver that counts how many unit tests have been
1191 (Trial.__init__): wire it in
1192 * buildbot/test/test_twisted.py (Counter): unit test for it
1194 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1195 to new cmd.logs['stdio'] scheme
1196 (Trial.commandComplete): same
1197 (BuildDebs.commandComplete): same
1199 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1200 LogFiles, instead of just a single one. The old single logfile is
1201 now called "stdio". LoggedRemoteCommand no longer creates a
1202 LogFile for you (the code to do that was broken anyway). If you
1203 don't create a "stdio" LogFile, then stdout/stderr will be
1205 (LogObserver): implement "LogObservers", which a BuildStep can add
1206 to parse the output of a command in real-time. The primary use is
1207 to provide more useful information to the Progress code, allowing
1208 better ETA estimates.
1209 (LogLineObserver): utility subclass which feeds complete lines to
1210 the parser instead of bytes.
1211 (BuildStep.progressMetrics): this is safer as a tuple
1212 (BuildStep.setProgress): utility method, meant to be called by
1214 (BuildStep.addLogObserver): new method, to be called at any time
1215 during the BuildStep (even before any LogFiles have been created),
1216 to attach (or schedule for eventual attachment) a LogObserver to a
1218 (StdioProgressObserver): new LogObserver which replaces the old
1219 "output" progress gatherer
1220 (LoggingBuildStep.__init__): same
1221 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1222 (LoggingBuildStep._commandComplete): must use logs['stdio']
1223 instead of the old single ".log" attribute.
1224 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1225 functionality, now subsumed into StdioProgressObserver
1226 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1227 log name changed from "output" to "stdio".
1230 * buildbot/interfaces.py (ILogFile): add the Interface used from
1231 the BuildStep towards the LogFile
1232 (ILogObserver): and the one provided by a LogObserver
1233 * buildbot/status/builder.py (LogFile): implement it
1235 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1236 HEADER constants here ..
1237 * buildbot/status/builder.py (STDOUT): .. from here
1239 2006-06-13 Brian Warner <warner@lothar.com>
1241 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1242 compatibility with python2.2, which doesn't have the 'substr in
1244 (TestP4Poller.makeTime): utility function to construct the
1245 timestamp using the same strptime() approach as p4poller does. It
1246 turns out that time.mktime() behaves slightly differently under
1247 python2.2, probably something to do with the DST flag, and that
1248 causes the test to fail under python2.2. (changing the mktime()
1249 arguments to have dst=0 instead of -1 caused it to fail under
1250 python2.3. Go figure.)
1251 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1253 2006-06-12 Brian Warner <warner@lothar.com>
1255 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1256 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1257 contributing such an excellent patch, including docs and unit
1258 tests! This makes it *so* much easier to apply. I had to update
1259 test_vc.py to handle some recent refactorings, but everything else
1260 applied smoothly. The only remaining thing I'd like to fix would
1261 be to remove the hard-wired port 1666 used by p4d, and allow it to
1262 claim any unused port. This would allow two copies of the test
1263 suite to run on the same host at the same time, as well as
1264 allowing the test suite to run while a real (production) p4d was
1265 running on the same host. Oh, and maybe we should add a warning to
1266 step.P4 that gets emitted if the slave is too old to provide the
1267 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1268 * buildbot/slave/commands.py (P4): same
1269 (P4Sync): same, some minor updates
1270 * buildbot/changes/p4poller.py: same
1271 * docs/buildbot.texinfo: same
1272 * buildbot/test/test_p4poller.py: same
1273 * buildbot/test/test_vc.py (P4): same
1275 * setup.py: add Trove classifiers for PyPI
1277 2006-06-08 Brian Warner <warner@allmydata.com>
1279 * buildbot/status/client.py
1280 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1281 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1282 build needs to be IRemote'd separately, rather than IRemote'ing
1283 the whole list at once. I can't wait until newpb's serialization
1284 adapters make this unnecessary.
1286 2006-06-06 Brian Warner <warner@lothar.com>
1288 * buildbot/process/step.py (WithProperties): make this inherit
1289 from ComparableMixin, so that reloading an unchanged config file
1290 doesn't cause us to spuriously reload any Builders which use them.
1291 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1294 2006-06-03 Brian Warner <warner@lothar.com>
1296 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1297 running py2exe on windows, contributed by Mark Hammond. Addresses
1298 SF#1401121, but I think we still need to include
1299 buildbot/scripts/sample.cfg
1300 * setup.py: include buildbot_service.py as a script under windows
1301 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1302 a py2exe application), get the icon/css datafiles from a different
1305 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1306 double-escape the build URL. Thanks to Olivier Bonnet for the
1307 patch. Fixes SF#1452801.
1309 2006-06-02 Brian Warner <warner@lothar.com>
1311 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1312 first six columns of 'svnlook' output, not just the first column,
1313 since property changes appear in the other five. Thanks to Olivier
1314 Bonnet for the patch. Fixes SF#1398174.
1316 2006-06-01 Brian Warner <warner@lothar.com>
1318 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1319 the fake build, so that title= has something to be set to
1321 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1322 attribute of the "Build #NN" link in the yellow start-the-build
1323 box to the build's reason. This means that you get a little
1324 tooltip explaining why the build was done when you hover over the
1325 yellow box. Thanks to Zandr Milewski for the suggestion.
1327 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1328 (Box.setETA): handle ETA=None (by stopping the timer)
1329 (Box.update): make the [soon] text less different than the usual
1330 text, so the rest of the text doesn't flop around so much. It
1331 would be awfully nice to figure out how to center this stuff.
1332 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1334 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1335 by default, so that any ShellCommand which fails marks the overall
1336 build as a failure. I should have done this from the beginning.
1337 Add flunkOnFailure=False to the arguments if you want to turn off
1340 2006-05-30 Brian Warner <warner@lothar.com>
1342 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1343 last-build/current-build/current-step. Show what step is currently
1344 running. Show ETA for both the overall build and the current step.
1345 Update GTK calls to modern non-deprecated forms. There's still a
1346 lot of dead code and debug noise to remove.
1348 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1349 shows up properly in status displays
1351 2006-05-28 Brian Warner <warner@lothar.com>
1353 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1354 build we use to verify that WithProperties works:
1356 ** set flunkOnFailure=True so that build failures get noticed
1357 ** set workdir='.' so that the build succeeds, otherwise it is trying
1358 to touch 'build/something', and 'build/' doesn't exist because
1359 usually that's created by a Source step
1360 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1361 this test somehow triggers, in which the 'touch' process becomes
1362 a zombie and we wait for th etimeout before giving up on it.
1364 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1365 to log the Build results and step logs to the twisted log.
1366 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1367 what went wrong if a build was expected to succeed but didn't.
1369 * buildbot/process/step_twisted.py (Trial): set the default
1370 trialMode to '--reporter=bwverbose', which specifies verbose
1371 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1372 '-to', but those are completely missing in modern Twisteds.
1374 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1375 a localhost-only port, to encourage better security
1377 * docs/buildbot.texinfo (Change Sources): mention
1380 * .darcs-boring: add a Darcs boringfile
1382 * README (REQUIREMENTS): stop claiming compatibility with
1385 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1388 2006-05-27 Brian Warner <warner@lothar.com>
1390 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1391 * docs/buildbot.texinfo: same
1393 2006-05-23 Brian Warner <warner@lothar.com>
1395 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1396 * docs/buildbot.texinfo: set version to match
1397 * NEWS: update for 0.7.3
1399 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1400 give a quick mapping from VC system to possible ChangeSources
1401 (Build Properties): add 'buildername'
1403 * buildbot/process/base.py (Build.setupStatus): oops, set
1404 'buildername' and 'buildnumber' properties
1405 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1408 2006-05-22 Brian Warner <warner@lothar.com>
1410 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1411 property interpolation better
1413 * README (INSTALLATION): remove old '-v' argument from recommended
1416 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1417 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1420 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1421 'svnversion' instead of grepping the output of 'svn info', much
1422 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1423 Bonnet for the suggestion.
1424 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1425 require the WC_PATH argument, so run 'svnversion .' instead.
1427 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1428 aren't supposed to have 'self' in their argument list
1430 2006-05-21 Brian Warner <warner@lothar.com>
1432 * buildbot/process/step.py (ShellCommand.start): make
1433 testInterpolate pass. I was passing the uninterpolated command to
1434 the RemoteShellCommand constructor
1435 (ShellCommand._interpolateProperties): oops, handle non-list
1436 commands (i.e. strings with multiple words separated by spaces in
1437 them) properly, instead of forgetting about them.
1439 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1440 to actually try to use build properties in a real build. This test
1442 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1443 to start and evaluate builds
1445 * buildbot/test/test__versions.py: add a pseudo-test to record
1446 what version of Twisted/Python/Buildbot are running. This should
1447 show up at the beginning of _trial_tmp/test.log, and exists to help
1448 debug other problems.
1450 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1451 a filename to be served as 'robots.txt' to discourage web spiders.
1452 Adapted from a patch by Tobi Vollebregt, thanks!
1453 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1454 (Waterfall.test_waterfall): tweak the way that filenames are put
1455 into the config file, to accomodate windows pathnames better.
1457 * docs/buildbot.texinfo (HTML Waterfall): document it
1459 * buildbot/process/process_twisted.py
1460 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1461 changed the build process. The new setup.py no longer takes the
1463 (FullTwistedBuildFactory.__init__): same
1464 (TwistedReactorsBuildFactory.__init__): same
1466 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1467 be placed in the [hooks] section of the central repository (the
1468 one that everybody pushes changes to).
1470 2006-05-20 Brian Warner <warner@lothar.com>
1472 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1473 .darcs-context file, use binary mode. I think this was causing a
1474 Darcs failure under windows.
1476 2006-05-19 Brian Warner <warner@lothar.com>
1478 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1479 use a timezone string of +0000 and gmtime, since this timestamp is
1480 sent to a buildmaster and %z is broken.
1482 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1483 string and localtime, since this timestamp will only be consumed
1484 locally, and %z is broken.
1486 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1487 gmtime, since this timestamp is returned to the buildmaster, and
1490 2006-05-18 Brian Warner <warner@lothar.com>
1492 * NEWS: update in preparation for next release
1494 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1495 setup-repository and do-we-have-the-vc-tools code into a separate
1496 "helper" class, which sticks around in a single module-level
1497 object. This seems more likely to continue to work in the future
1498 than having it hide in the TestCase and hope that TestCases stick
1499 around for a long time.
1501 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1502 addremove' has been deprecated in recent versions of mercurial, so
1503 use 'hg add' instead
1505 2006-05-07 Brian Warner <warner@lothar.com>
1507 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1508 operating under windows, move the file before opening it, since
1509 you can't rename a file that somebody has open.
1511 * buildbot/process/base.py (Build.setupBuild): if something goes
1512 wrong while creating a Step, log the name and arguments, since the
1513 error message when you get the number of arguments wrong is really
1516 2006-05-06 Brian Warner <warner@lothar.com>
1518 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1519 bugs in twisted-specific code not covered by my unit tests, this
1520 time use 'cmd' argument instead of self.cmd
1522 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1523 fix stupid braino: either use startwith or find()==0, not both.
1524 (TwistedReactorsBuildFactory.__init__): another dumb typo
1526 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1527 mark this test as TODO under windows, since process-killing seems
1528 dodgy there. We'll come back to this later and try to fix it
1531 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1532 and don't include a timezone
1533 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1534 This should avoid the windows-with-verbose-timezone-name problem
1536 (Patch.testPatch): add a test which runs 'patch' with less
1537 overhead than the full VCBase.do_patch sequence, to try to isolate
1538 a windows test failure. This one uses slave.commands.ShellCommand
1539 and 'patch', but none of the VC code.
1541 * buildbot/slave/commands.py (getCommand): use which() to find the
1542 executables for 'cvs', 'svn', etc. This ought to help under
1545 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1546 working directory before starting. If an earlier test failed, the
1547 leftover directory would mistakenly flunk a later test.
1548 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1549 Make sure that we use the right commandlines if which("tla") picks
1550 up "tla.exe" (as it does under windows).
1551 (TlaSupport.do_get): factor out this tla-vs-baz difference
1552 (TlaSupport.vc_create): more tla-vs-baz differences
1554 * buildbot/test/test_slavecommand.py
1555 (ShellBase.testShellMissingCommand): stop trying to assert
1556 anything about the error message: different shells on different
1557 OSes with different languages makes it hard, and it really isn't
1558 that interesting of a thing to test anyway.
1560 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1561 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1562 "Panther"), because it has a bug which flunks a couple tests in
1563 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1564 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1565 able to test that yet.
1567 2006-04-30 Brian Warner <warner@lothar.com>
1569 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1570 make sure child commands emit messages in english, so our regexps
1571 will match. Thanks to Nikaus Giger for identifying the problems.
1572 (VCBase._do_vctest_export_1): mode="export" is not responsible
1573 for setting the "got_revision" property, since in many cases it is
1574 not convenient to determine.
1575 (SVNSupport.capable): when running 'svn --version' to check for
1576 ra_local, we want error messages in english
1577 * buildbot/test/test_slavecommand.py
1578 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1579 to emit the error message in english
1581 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1582 the environment with $LC_ALL="C" so that Commands which need to
1583 parse the output of their child processes can obtain it in
1585 (SVN.parseGotRevision): call "svn info" afterwards instead of
1586 watching the output of the "svn update" or "svn checkout".
1587 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1588 (Arch.parseGotRevision): same
1589 (Bazaar.parseGotRevision): same
1590 (Mercurial.parseGotRevision): same
1592 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1593 $LC_ALL="C" when running commands under 'buildbot try', too
1595 * buildbot/test/__init__.py: remove the global os.environ()
1596 setting, instead we do it just for the tests that run commands and
1597 need to parse their output.
1599 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1600 remove the overly-short .timeout on this test, because non-DNotify
1601 platforms must fall back to polling which happens at 10 second
1602 intervals, so a 5 second timeout would never succeed.
1604 2006-04-24 Brian Warner <warner@lothar.com>
1606 * docs/buildbot.texinfo (Installing the code): update trial
1607 invocation, SF#1469116 by Niklaus Giger.
1608 (Attributes of Changes): updated branch-name examples to be
1609 a bit more realistic, SF#1475240 by Stephen Davis.
1611 * contrib/windows/buildbot2.bat: utility wrapper for windows
1612 developers, contributed by Nick Trout (after a year of neglect..
1613 sorry!). SF#1194231.
1615 * buildbot/test/test_vc.py (*.capable): store the actual VC
1616 binary's pathname in VCS[vcname], so it can be retrieved later
1617 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1618 strip out non-numeric timezone information, specifically the funky
1619 German string that his system produced that confuses CVS.
1620 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1621 allow Darcs tests to work on windows
1622 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1623 procutils.which() everywhere, to allow tryclient to work under
1624 windows. Also from Niklaus Giger, SF#1463394.
1626 * buildbot/twcompat.py (which): move the replacement for a missing
1627 twisted.python.procutils.which from test_vc.py to here, so it can
1628 be used in other places too (specifically tryclient.py)
1630 2006-04-23 Brian Warner <warner@lothar.com>
1632 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1633 bare buildbotURL/projectName line with a proper DIV, along with a
1634 CSS class of "title", from Stefan Seefeld (SF#1461675).
1635 (WaterfallStatusResource.body0): remove the redundant 'table'
1636 class from the table
1637 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1638 to the top-row TR, and class="Activity" to the second-row TR,
1639 rather than putting them in the individual TD nodes.
1641 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1642 'got_revision' build property for all VC systems that implement
1643 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1645 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1646 to determine which revision we actually obtained
1647 (CVS.parseGotRevision): implement this for CVS, which just means
1648 to grab a timestamp. Not ideal, and it depends upon the buildslave
1649 having a clock that is reasonably well syncronized with the server,
1650 but it's better than nothing.
1651 (SVN.parseGotRevision): implement it for SVN, which is accurate
1652 (Darcs.parseGotRevision): same
1653 (Arch.parseGotRevision): same
1654 (Bazaar.parseGotRevision): same
1655 (Mercurial.parseGotRevision): same
1657 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1658 keep a record of all non-stdout/stderr/header/rc status updates,
1659 for the benefit of RemoteCommands that send other useful things,
1661 (Source.commandComplete): put any 'got_revision' status values
1662 into a build property of the same name
1665 * buildbot/process/step_twisted.py (Trial): update to deal with
1666 new ShellCommand refactoring
1668 * docs/buildbot.texinfo (Build Properties): document new feature
1669 that allows BuildSteps to get/set Build-wide properties like which
1670 revision was requested and/or checked out.
1672 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1673 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1674 it. Note that this bumps the persistenceVersion of the saved Build
1675 object, so add the necessary upgrade-old-version logic to include
1676 an empty properties dict.
1678 * buildbot/process/base.py (Build.setProperty): implement it
1679 (Build.getProperty): same
1680 (Build.startBuild): change build startup to set 'branch',
1681 'revision', and 'slavename' properties at the right time
1683 * buildbot/process/step.py (BuildStep.__init__): change setup to
1684 require 'build' argument in a better way
1685 (LoggingBuildStep): split ShellCommand into two pieces, for better
1686 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1687 a single RemoteCommand that sends stdout/stderr status text. It
1688 also provides the usual commandComplete / createSummary /
1689 evaluateCommand / getText methods to be overridden...
1690 (ShellCommand): .. whereas ShellCommand is specifically for
1691 running RemoteShellCommands. Other shell-like BuildSteps (like
1692 Source) can inherit from LoggingBuildStep instead of ShellCommand
1693 (WithProperties): marker class to do build-property interpolation
1694 (Source): inherit from LoggingBuildStep instead of ShellCommand
1697 * buildbot/test/test_properties.py: test new functionality
1699 2006-04-21 Brian Warner <warner@lothar.com>
1701 * buildbot/test/test_vc.py: rename testBranch to
1702 testCheckoutBranch to keep the tests in about the right
1705 2006-04-18 Brian Warner <warner@lothar.com>
1707 * docs/buildbot.texinfo (PBListener): improve cross-references
1708 between PBListener and 'buildbot statusgui', thanks to John Pye
1711 2006-04-17 Brian Warner <warner@lothar.com>
1713 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1714 running under Twisted-1.3.0, otherwise skipped tests are reported
1717 * all: use isinstance() instead of 'type(x) is foo', suggested by
1720 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1721 oops, fix a brain-fade from the other week, when making the
1722 addStep changes. I changed all the __init__ upcalls to use the
1723 wrong superclass name.
1724 (FullTwistedBuildFactory.__init__): same
1725 (TwistedDebsBuildFactory.__init__): same
1726 (TwistedReactorsBuildFactory.__init__): same
1727 (TwistedBuild.isFileImportant): use .startswith for clarity,
1728 thanks to Neal Norwitz for the suggestions.
1730 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1731 changes, then deliver them over PB to a remote buildmaster.
1733 * contrib/svnpoller.py: added script by John Pye to poll a remote
1734 SVN repository (by running 'svn log') from a cronjob, and run
1735 'buildbot sendchange' to deliver the changes to a remote
1737 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1738 modification of svnpoller.py), same purpose, but this one loops
1739 internally (rather than expecting to run from a cronjob) and works
1741 * contrib/README.txt: same
1743 2006-04-11 Brian Warner <warner@lothar.com>
1745 * all: fix a number of incorrect names and missing imports, thanks
1746 to Anthony Baxter for the patch.
1747 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1748 remove unused buggy method.
1749 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1750 comes from shutil, not "shutils"
1751 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1752 (Arch.checkSlaveVersion): same
1753 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1755 * buildbot/process/step_twisted2.py: add some missing imports
1756 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1757 this code used to live in twisted.internet.defer
1759 2006-04-10 Brian Warner <warner@lothar.com>
1761 * buildbot/process/step.py (Mercurial): add Mercurial support
1762 * buildbot/slave/commands.py (Mercurial): same
1763 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1764 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1765 not yet tested, but 'try' support *is* covered
1766 * docs/buildbot.texinfo (Mercurial): document it
1768 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1769 some debugging messages (turned off)
1770 * buildbot/test/test_vc.py: improve debug messages
1772 2006-04-07 Brian Warner <warner@lothar.com>
1774 * buildbot/test/test_vc.py (which): define our own which() in case
1775 we can't import twisted.python.procutils, because procutils doesn't
1776 exist in Twisted-1.3
1778 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1779 of SlaveLocks for performance tests
1781 * docs/examples/twisted_master.cfg: update to match current usage
1783 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1784 password, p4 binary, pollinterval, maximum history to check.
1785 Patch from an anonymous sf.net contributor, SF#1219384.
1786 * buildbot/process/step.py (P4Sync.__init__): add username,
1787 password, and client arguments.
1788 * buildbot/slave/commands.py (P4Sync): same
1790 2006-04-05 Brian Warner <warner@lothar.com>
1792 * buildbot/process/factory.py (BuildFactory.addStep): new method
1793 to add steps to a BuildFactory. Use it instead of f.steps.append,
1794 and you can probably avoid using the s() convenience function.
1795 Patch from Neal Norwitz, sf.net #1412605.
1796 (other): update all factories to use addStep
1797 * buildbot/process/process_twisted.py: update all factories to use
1800 2006-04-03 Brian Warner <warner@lothar.com>
1802 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1803 work under windows too. Adapted from a patch by Niklaus Giger,
1804 addresses SF#1463399.
1806 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1807 spawned commands emit parseable results in english and not some
1808 other language. Patch from Niklaus Giger, SF#1463395.
1810 * README (INSTALLATION): discourage users from running unit tests on
1811 a "network drive", patch from Niklaus Giger, SF#1463394.
1813 2006-03-22 Brian Warner <warner@lothar.com>
1815 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1816 function to turn a repository-relative pathname into a (branch,
1817 branch-relative-filename) tuple. Change this function to handle
1818 the branch naming policy used by your Subversion repository.
1819 Thanks to AllMyData.com for sponsoring this work.
1821 2006-03-16 Brian Warner <warner@lothar.com>
1823 * buildbot/scripts/sample.cfg: add python-mode declaration for
1824 vim. Thanks to John Pye for the patch.
1826 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1827 command line, mention the importance of running 'crontab' as the
1828 buildmaster/buildslave user. Thanks to John Pye for the catch.
1830 2006-03-13 Brian Warner <warner@lothar.com>
1832 * buildbot/status/words.py (IRC): add an optional password=
1833 argument, which will be sent to Nickserv in an IDENTIFY message at
1834 login, to claim the nickname. freenode requires this before the
1835 bot can sent (or reply to) private messages. Thanks to Clement
1836 Stenac for the patch.
1837 * docs/buildbot.texinfo (IRC Bot): document it
1839 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1840 larger than chunkSize. Fixes SF#1349253.
1841 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1842 (Log.testConsumer): update to match new internal chunking behavior
1844 2006-03-12 Brian Warner <warner@lothar.com>
1846 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1848 * buildbot/test/test_maildir.py (MaildirTest): rename the
1849 'timeout' method, as it collides with trial's internals
1851 * buildbot/scripts/runner.py: add 'buildbot restart' command
1852 (stop): don't sys.exit() out of here, otherwise restart can't work
1853 * docs/buildbot.texinfo (Shutdown): document it
1855 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1856 * buildbot/status/html.py (Waterfall.__init__): same
1857 * buildbot/process/builder.py (Builder.startBuild): same
1858 * buildbot/process/base.py (BuildRequest): same
1859 * buildbot/sourcestamp.py (SourceStamp): same
1860 * buildbot/scheduler.py (Nightly): same
1862 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1864 * docs/buildbot.texinfo: same
1866 2006-02-17 Brian Warner <warner@lothar.com>
1868 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1869 * docs/buildbot.texinfo: set version number to match
1870 * NEWS: update for 0.7.2
1872 2006-02-16 Brian Warner <warner@lothar.com>
1874 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1876 2006-02-09 Brian Warner <warner@lothar.com>
1878 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1879 add text to explain per-build branch parameters
1880 * NEWS: mention --umask
1882 2006-02-08 Brian Warner <warner@lothar.com>
1884 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1886 (SlaveOptions.optParameters): add --umask, to make it possible to
1887 make buildslave-generated files (including build products) be
1890 * buildbot/slave/bot.py (BuildSlave.startService): same
1892 2006-01-23 Brian Warner <warner@lothar.com>
1894 * buildbot/status/builder.py: urllib.quote() all URLs that include
1895 Builder names, so that builders can include characters like '/'
1896 and ' ' without completely breaking the resulting HTML. Thanks to
1897 Kevin Turner for the patch.
1898 * buildbot/status/html.py: same
1899 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1901 * NEWS: update in preparation for upcoming release
1903 2006-01-18 Brian Warner <warner@lothar.com>
1905 * docs/examples/twisted_master.cfg: update to match the Twisted
1906 buildbot: remove python2.2, switch to exarkun's buildslaves,
1907 disable the .deb builder until we figure out how to build twisted
1908 .debs from SVN, add some ktrace debugging to the OS-X build
1909 process and remove the qt build, remove threadless builders,
1910 change freebsd builder to use landonf's buildslave.
1912 2006-01-12 Brian Warner <warner@lothar.com>
1914 * buildbot/master.py (Manhole.__init__): let port= be a strports
1915 specification string, but handle a regular int for backwards
1916 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1917 used in master.cfg to limit connections to just the local host.
1918 (BuildMaster.loadConfig): same for c['slavePortnum']
1919 * buildbot/scheduler.py (Try_Userpass.__init__): same
1920 * buildbot/status/client.py (PBListener.__init__): same
1921 * buildbot/status/html.py (Waterfall.__init__): same, for both
1922 http_port and distrib_port. Include backwards-compatibility checks
1923 so distrib_port can be a filename string and still mean unix:/foo
1924 * docs/buildbot.texinfo (Setting the slaveport): document it
1925 (Debug options): same
1926 (HTML Waterfall): same
1929 * buildbot/test/test_config.py (ConfigTest): test it
1931 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1932 slaveport's disownServiceParent deferred to fire before opening
1933 the new one. Fixes an annoying bug in the unit tests.
1935 2006-01-03 Brian Warner <warner@lothar.com>
1937 * buildbot/master.py (BuildMaster): remove the .schedulers
1938 attribute, replacing it with an allSchedulers() method that looks
1939 for all IService children that implement IScheduler. Having only
1940 one parent/child relationship means fewer opportunities for bugs.
1941 (BuildMaster.allSchedulers): new method
1942 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1943 also fix ugly bug that caused any config-file reload to
1944 half-forget about the earlier Schedulers, causing an exception
1945 when a Change arrived and was handed to a half-connected
1946 Scheduler. The exception was in scheduler.py line 54ish:
1947 self.parent.submitBuildSet(bs)
1948 exceptions.AttributeError: 'NoneType' object has no attribute
1950 (BuildMaster.addChange): update to use allSchedulers()
1952 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1953 to work properly with twisted-1.3.0, where you must explicitly
1954 include the __implements__ from parent classes
1955 (BaseScheduler.__repr__): make it easier to distinguish distinct
1957 (BaseUpstreamScheduler.__implements__): same
1959 * buildbot/status/builder.py (Status.getSchedulers): update to
1961 * buildbot/test/test_run.py (Run.testMaster): same
1962 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1963 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1964 make sure Scheduler instances are left alone when an identical
1965 config file is reloaded
1966 (ConfigElements.testSchedulers): make sure Schedulers are properly
1969 * Makefile (TRIALARGS): my local default Twisted version is now
1970 2.1.0, update the trial arguments accordingly
1972 2005-12-22 Brian Warner <warner@lothar.com>
1974 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1977 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1978 addChange in the parent class, although I suspect this should be
1979 fixed better in the future.
1981 2005-11-26 Brian Warner <warner@lothar.com>
1983 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1984 explode when branch==None, thanks to Kevin Turner for the catch
1985 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1988 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1990 * docs/buildbot.texinfo: same
1992 2005-11-26 Brian Warner <warner@lothar.com>
1994 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1995 * docs/buildbot.texinfo: set version number to match
1997 2005-11-26 Brian Warner <warner@lothar.com>
1999 * NEWS: update for 0.7.1
2001 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2002 sure that unsubscribe works even if we never sent an ETA update.
2003 Also, don't explode on duplicate unsubscribe.
2004 (BuildStepStatus.addLog): make the convenience "return self"-added
2005 watcher automatically unsubscribe when the Step finishes.
2006 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2007 (BuildStatus.stepStarted): same auto-unsubscribe
2008 (BuilderStatus.buildStarted): same auto-unsubscribe
2010 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2012 (IStatusReceiver.stepStarted): same
2013 (IStatusReceiver.logStarted): same
2015 * buildbot/test/test_run.py (Status): move the Status test..
2016 * buildbot/test/test_status.py (Subscription): .. to here
2018 2005-11-25 Brian Warner <warner@lothar.com>
2020 * NEWS: more updates
2022 * buildbot/locks.py: fix the problem in which loading a master.cfg
2023 file that changes some Builders (but not all of them) can result
2024 in having multiple copies of the same Lock. Now, the real Locks
2025 are kept in a table inside the BotMaster, and the Builders/Steps
2026 use "LockIDs", which are still instances of MasterLock and
2027 SlaveLock. The real Locks are instances of the new RealMasterLock
2028 and RealSlaveLock classes.
2029 * buildbot/master.py (BotMaster.getLockByID): new method to
2030 convert LockIDs into real Locks.
2031 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2032 into real Locks before building
2033 * buildbot/process/step.py (BuildStep.startStep): same
2034 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2035 exercises the problem
2038 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2039 what Schedulers are available
2041 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2042 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2043 'cron'-style build scheduling at certain times of day, week,
2045 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2047 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2048 handling: treat self.fileIsImportant more as an attribute that
2049 contains a callable than as a method. If the attribute is None,
2050 don't call it and assume all filenames are important. It is still
2051 possible to provide a fileIsImportant method in a subclass,
2053 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2055 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2056 test using AnyBranchScheduler with fileIsImportant=None
2058 2005-11-24 Brian Warner <warner@lothar.com>
2060 * buildbot/test/test_config.py (StartService): don't claim a fixed
2061 port number, instead set slavePort=0 on the first pass, figure out
2062 what port was allocated, then switch to a config file that uses
2065 * buildbot/master.py (BuildMaster.loadConfig): close the old
2066 slaveport before opening the new one, because unit tests might
2067 replace slavePort=0 with the same allocated portnumber, and if we
2068 don't wait for the old port to close first, we get a "port already
2069 in use" error. There is a tiny race condition here, but the only
2070 threat is from other programs that bind (statically) to the same
2071 port number we happened to be allocated, and only if those
2072 programs use SO_REUSEADDR, and only if they get control in between
2075 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2077 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2078 deleted ChangeSources before adding any new ones
2079 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2080 compare_attrs, to make sure that a config-file reload does not
2081 unnecessarily replace an unmodified ChangeSource instance
2082 * buildbot/test/test_config.py (ConfigTest.testSources): update
2084 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2085 mean "don't build anything", and add a warning if it gets used
2086 because it isn't actually useful.
2088 * contrib/svn_buildbot.py: update example usage to match the port
2089 number that gets used by the PBChangeSource
2090 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2092 2005-11-22 Brian Warner <warner@lothar.com>
2094 * NEWS: start collecting items for next release
2096 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2097 revisions are strings
2098 (P4Sync.computeSourceRevision): same
2100 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2101 to the Buildbot's overall status page
2102 (StatusResourceBuilder.body): same
2104 2005-11-15 Brian Warner <warner@lothar.com>
2106 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2107 config-file loading, specifically to make sure old StatusTargets
2108 are finished shutting down before new ones start up (thus
2109 resolving a bug in which changing the Waterfall object would fail
2110 because both new and old instances were claiming the same
2111 listening port). Also load new Schedulers after all the new
2112 Builders are set up, in case they fire off a new build right away.
2113 * buildbot/test/test_config.py (StartService): test it
2115 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2116 the branch name to the mail body
2118 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2119 Without it, a config-file reload fails to update an existing
2121 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2122 username/passwd to compare_attrs, for the same reason
2123 * buildbot/status/html.py (Waterfall): add favicon to
2124 compare_attrs, same reason
2126 2005-11-05 Brian Warner <warner@lothar.com>
2128 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2129 baserev before stuffing it in the jobfile. This resolves problems
2130 under SVN (and probably Arch) where revisions are expressed as
2131 numbers. I'm inclined to use string-based revisions everywhere in
2132 the future, but this fix should be safe for now. Thanks to Steven
2133 Walter for the patch.
2135 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2136 binary mode when opening pickle files, to make windows work
2137 better. Thanks to Dobes Vandermeer for the catch.
2138 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2139 (BuilderStatus.getBuildByNumber): same
2140 (Status.builderAdded): same
2141 * buildbot/master.py (BuildMaster.loadChanges): same
2143 * buildbot/util.py (Swappable): delete unused leftover code
2145 * buildbot/process/step.py (SVN): when building on a non-default
2146 branch, add the word "[branch]" to the VC step's description, so
2147 it is obvious that we're not building the usual stuff. Likewise,
2148 when we are building a specific revision, add the text "rNNN" to
2149 indicate what that revision number is. Thanks to Brad Hards and
2150 Nathaniel Smith for the suggestion.
2151 (Darcs.startVC): same
2152 (Arch.startVC): same
2153 (Bazaar.startVC): same
2155 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2156 typo, caught by Mark Dillavou, closes SF#1216636.
2158 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2159 about a test to add some day
2161 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2162 the 'full-2.3' build, and the 'reactors' build is now run under
2163 python-2.4 because the buildslave no longer has gtk/etc bindings
2164 for earlier versions.
2166 2005-11-03 Brian Warner <warner@lothar.com>
2168 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2169 method, takes an IBuildStatus and rebuilds it. It might make more
2170 sense to add this to IBuildControl instead, but that instance goes
2171 away completely once the build has finished, and resubmitting
2172 builds can take place weeks later.
2173 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2174 * buildbot/status/html.py (StatusResourceBuild): also stash an
2175 IBuilderControl so we can use resubmitBuild.
2176 (StatusResourceBuild.body): render "resubmit" button if we can.
2177 Also add hrefs for each BuildStep
2178 (StatusResourceBuild.rebuild): add action for "resubmit" button
2179 (StatusResourceBuilder.getChild): give it an IBuilderControl
2181 * buildbot/status/builder.py (Status.getURLForThing): change the
2182 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2183 that live as targets of buttons like "stop" and "rebuild" can't
2185 * buildbot/status/builder.py (Status.getURLForThing): same
2186 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2187 (StepBox.getBox): same
2188 * buildbot/test/test_web.py (GetURL): same
2191 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2192 exclusivity checks after Source.__init__ upcall, so misspelled
2193 arguments will be reported more usefully
2194 (Darcs.__init__): same
2196 2005-10-29 Brian Warner <warner@lothar.com>
2198 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2199 builder. Move the Try scheduler off to a separate port.
2201 2005-10-27 Brian Warner <warner@lothar.com>
2203 * buildbot/clients/gtkPanes.py
2204 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2205 to cause the app to crash, now they don't.
2207 * buildbot/clients/debug.py: display the buildmaster's location
2208 in the window's title bar
2210 2005-10-26 Brian Warner <warner@lothar.com>
2212 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2213 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2214 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2216 * buildbot/status/html.py (td): put a single non-breaking space
2217 inside otherwise empty <td> elements, as a workaround for buggy
2218 browsers which would optimize them away (along with any associated
2219 styles, like the kind that create the waterfall grid borders).
2220 Patch from Frerich Raabe.
2222 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2223 argv-list as an argument, defaulting to ["-to"], which is
2224 appropriate for the Trial that comes with Twisted-2.1.0 and
2225 earlier. The Trial in current Twisted SVN wants
2226 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2227 defaults to an empty list.
2228 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2229 match it, now that trialMode= is a list instead of a single string
2231 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2233 * docs/buildbot.texinfo: same
2235 2005-10-24 Brian Warner <warner@lothar.com>
2237 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2238 * docs/buildbot.texinfo: set version number to match
2240 2005-10-24 Brian Warner <warner@lothar.com>
2242 * README: update for 0.7.0
2244 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2246 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2247 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2248 send the branch= argument unless the user really provided one, to
2249 retain compatibility with older buildmasters that don't accept
2251 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2254 * docs/buildbot.texinfo: update lots of stuff
2256 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2257 to the 'buildbot sendchange' command
2258 * buildbot/clients/sendchange.py (Sender.send): same
2259 * buildbot/changes/pb.py (ChangePerspective): same
2260 * buildbot/test/test_changes.py (Sender.testSender): test it
2262 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2263 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2264 for consistency with other BuildStep arguments that use camelCase.
2265 Well, at least more of them use camelCase (like flunkOnWarnings)
2266 than don't.. I wish I'd picked one style and stuck with it
2267 earlier. Annoying, but it's best done before the release, since
2268 these arguments didn't exist at all in 0.6.6 .
2270 * buildbot/test/test_vc.py (SVN.testCheckout): same
2271 (Darcs.testPatch): same
2272 * docs/buildbot.texinfo (SVN): document the change
2273 (Darcs): same, add some build-on-branch docs
2274 * docs/examples/twisted_master.cfg: match change
2276 * buildbot/process/step.py (BuildStep): rename
2277 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2278 how it is normally used.
2279 * buildbot/test/test_steps.py (Version.checkCompare): same
2281 * buildbot/process/step.py (CVS.startVC): refuse to build
2282 update/copy -style builds on a non-default branch with an old
2283 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2284 concern is that it will do a VC 'update' in an existing tree when
2285 it is supposed to be switching branches (and therefore clobbering
2286 the tree to do a full checkout), thus building the wrong source.
2287 This used to be a warning, but I think the confusion it is likely
2288 to cause warrants making it an error.
2289 (SVN.startVC): same, also make mode=export on old slaves an error
2290 (Darcs.startVC): same
2291 (Git.startVC): improve error message for non-Git-enabled slaves
2292 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2293 specific revision is built on a slave that doesn't pay attention
2294 to args['revision'], because for slowly-changing trees it will
2295 probably do the right thing, and because we have no way to tell
2296 whether we're asking it to build the most recent version or not.
2297 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2299 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2300 that 'master' is in host:portnum format, to catch errors sooner
2302 2005-10-23 Brian Warner <warner@lothar.com>
2304 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2305 when creating the list of warning messages, include the line
2306 immediately after each WARNING: line, since that's usually where
2307 the file and line number wind up.
2309 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2314 2005-10-22 Brian Warner <warner@lothar.com>
2316 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2317 patch from Brad Hards
2318 * buildbot/status/classic.css: same
2319 * buildbot/test/test_web.py (Waterfall): match changes
2321 * buildbot/test/test_steps.py (BuildStep.setUp): set
2322 nextBuildNumber so the test passes
2323 * buildbot/test/test_status.py (MyBuilder): same
2325 * buildbot/status/html.py (StatusResourceBuild.body): revision
2326 might be numeric, so stringify it before html-escapifying it
2327 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2328 timer for the upcoming build
2329 * buildbot/status/classic.css: add background-color attributes for
2330 offline/waiting/building classes
2332 * buildbot/status/builder.py (BuildStatus): derive from
2333 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2334 the default (i.e. unknown) .slavename to "???" instead of None,
2335 since even unknown slavenames need to be printed eventually.
2336 (BuilderStatus): also derive from styles.Versioned . More
2337 importantly, determine .nextBuildNumber at creation/unpickling
2338 time by scanning the directory of saved BuildStatus instances and
2339 choosing one larger than the highest-numbered one found. This
2340 should fix the problem where random errors during upgrades cause
2341 the buildbot to forget about earlier builds. .nextBuildNumber is
2342 no longer stored in the pickle.
2343 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2344 at least log the error. Also call Builder.determineNextBuildNumber
2345 once the basedir is set.
2347 * buildbot/master.py (BuildMaster.loadChanges): do
2348 styles.doUpgrade afterwards, in case I decide to make Changes
2349 derived from styles.Versioned some day and forget to make this
2353 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2354 when running under older pythons (<2.3) in which the shlex module
2355 doesn't have a 'split' function.
2357 * buildbot/process/step.py (ShellCommand.start): make
2358 errorMessages= be a list of strings to stuff in the log before the
2359 command actually starts. This makes it easier to flag multiple
2360 warning messages, e.g. when the Source steps have to deal with an
2362 (CVS.startVC): handle slaves that don't handle multiple branches
2363 by switching into 'clobber' mode
2364 (SVN.startVC): same. Also reject branches without base_url
2365 (Darcs.startVC): same. Also reject revision= in older slaves
2366 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2367 (Bazaar.startVC): same, and test for baz separately than for arch
2369 * buildbot/slave/commands.py (cvs_ver): document new features
2371 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2372 (BuildStep.slaveVersionNewEnough): more useful utility method
2373 * buildbot/test/test_steps.py (Version): start testing it
2375 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2376 the 'force' command requires python2.3, for the shlex.split method
2378 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2379 since we don't use it anymore. The Twisted buildbot uses a
2382 2005-10-21 Brian Warner <warner@lothar.com>
2384 * buildbot/process/process_twisted.py: rework all BuildFactory
2385 classes to take a 'source' step as an argument, instead of
2386 building up the SVN instance in the factory.
2387 * docs/examples/twisted_master.cfg: enable build-on-branch by
2388 providing a base_url and default_branch
2390 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2391 control over --branch and --revision, not that they are always
2393 * buildbot/status/html.py (StatusResourceBuilder.force): same
2394 (StatusResourceBuild.body): display SourceStamp components
2396 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2397 IRC 'force' command, so it can be shared with an eventual
2398 command-line-tool 'buildbot force' mode.
2399 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2401 2005-10-20 Brian Warner <warner@lothar.com>
2403 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2405 * docs/examples/twisted_master.cfg: update to use Schedulers
2407 * buildbot/scripts/sample.cfg: update with Schedulers
2409 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2410 method specifically for use by HTML "force build" button and the
2411 IRC "force" command. Raises an immediate error if there are no
2413 (IBuilderControl.requestBuild): make this just submit a build, not
2414 try to check for existing slaves or set up any when-finished
2415 Deferreds or anything.
2416 * buildbot/process/builder.py (BuilderControl): same
2417 * buildbot/status/html.py (StatusResourceBuilder.force): same
2418 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2419 * buildbot/test/test_slaves.py: same
2420 * buildbot/test/test_web.py: same
2422 2005-10-19 Brian Warner <warner@lothar.com>
2424 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2425 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2427 2005-10-18 Brian Warner <warner@lothar.com>
2429 * buildbot/status/html.py: provide 'status' argument to most
2430 StatusResourceFOO objects
2431 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2432 and Logfiles" section to make the Build page into a more-or-less
2433 comprehensive source of status information about the build
2435 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2436 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2438 2005-10-17 Brian Warner <warner@lothar.com>
2440 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2441 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2442 out what to do about other projects: the correct options for
2443 recent Twisteds will not work for older ones.
2445 2005-10-15 Brian Warner <warner@lothar.com>
2447 * buildbot/status/builder.py (Status.getURLForThing): add method
2448 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2449 use this in email/IRC status clients to make them more useful, by
2450 providing the end user with hints on where to learn more about the
2451 object being reported on.
2452 * buildbot/test/test_web.py (GetURL): tests for it
2454 2005-10-14 Brian Warner <warner@lothar.com>
2456 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2457 fix bug resulting from deferredResult changes
2459 2005-10-13 Brian Warner <warner@lothar.com>
2461 * buildbot/test/test_changes.py: remove use of deferredResult
2462 * buildbot/test/test_config.py: same
2463 * buildbot/test/test_control.py: same
2464 * buildbot/test/test_status.py: same
2465 * buildbot/test/test_vc.py: this is the only remaining use, since
2466 it gets used at module level. This needs to be replaced by some
2467 sort of class-level run-once routine.
2469 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2471 * lots: implement multiple slaves per Builder, which means multiple
2472 current builds per Builder. Some highlights:
2473 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2474 of (state,currentBuilds) instead of (state,currentBuild)
2475 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2476 (IBuildStatus.getSlavename): new method, so you can tell which
2477 slave got used. This only gets set when the build completes.
2478 (IBuildRequestStatus.getBuilds): new method
2480 * buildbot/process/builder.py (SlaveBuilder): add a .state
2481 attribute to track things like ATTACHING and IDLE and BUILDING,
2483 (Builder): .. the .slaves attribute here, which has been turned
2484 into a simple list of available slaves. Added a separate
2485 attaching_slaves list to track ones that are not yet ready for
2487 (Builder.fireTestEvent): put off the test-event callback for a
2488 reactor turn, to make tests a bit more consistent.
2489 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2490 ping fails due to an exception. This needs work, I'm worried that
2491 a code error could lead to a constantly re-connecting slave.
2492 Especially since I'm trying to move to a distinct remote_ping
2493 method, separate from the remote_print that we currently use.
2494 (BuilderControl.requestBuild): return a convenience Deferred that
2495 provides an IBuildStatus when the build finishes.
2496 (BuilderControl.ping): ping all connected slaves, only return True
2497 if they all respond.
2499 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2500 reconnect when we shut down.
2502 * buildbot/status/builder.py: implement new methods, convert
2503 one-build-at-a-time methods to handle multiple builds
2504 * buildbot/status/*.py: do the same in all default status targets
2505 * buildbot/status/html.py: report the build's slavename in the
2506 per-Build page, report all buildslaves on the per-Builder page
2508 * buildbot/test/test_run.py: update/create tests
2509 * buildbot/test/test_slaves.py: same
2510 * buildbot/test/test_scheduler.py: remove stale test
2512 * docs/buildbot.texinfo: document the new builder-specification
2513 'slavenames' parameter
2515 2005-10-12 Brian Warner <warner@lothar.com>
2517 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2518 report failure correctly, causing Dependent builds to run when
2519 they shouldn't have.
2520 * buildbot/status/builder.py (BuildSetStatus): same
2521 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2522 (Set.testSuccess): test the both-pass case too
2523 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2524 fix this test: it was ending too early, masking the failure before
2525 (Logger): specialized StatusReceiver to make sure the dependent
2526 builds aren't even started, much less completed.
2528 2005-10-07 Brian Warner <warner@lothar.com>
2530 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2531 bot.SlaveBuilder being disowned in the middle of a build
2533 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2534 this inherit from StatusReceiver. Also upcall in __init__. This
2535 fixes the embarrasing crash when the new buildSetSubmitted method
2536 is invoked and Waterfall/etc don't implement their own.
2537 * buildbot/test/test_run.py: add a TODO note about a test to catch
2538 just this sort of thing.
2540 * buildbot/process/builder.py (Builder.attached): remove the
2541 already-attached warning, this situation is normal. Add some
2542 comments explaining it.
2544 2005-10-02 Brian Warner <warner@lothar.com>
2546 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2547 OverflowError when setting up dnotify, because some 64-bit systems
2548 have problems with signed-vs-unsigned constants and trip up on the
2549 DN_MULTISHOT flag. Patch from Brad Hards.
2551 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2553 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2554 progressMetrics, description, descriptionDone to the 'parms' list,
2555 and make use the 'parms' list from the implementation class
2556 instead of only BuildStep to initialize the parameters. This
2557 allows buildbot.process.factory.s() to initialize all the parms,
2558 not just those defined in directly by BuildStep.
2560 2005-09-03 Brian Warner <warner@lothar.com>
2562 * NEWS: start adding items for the next release
2564 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2565 python2.2 tests, change 'Quick' builder to only use python2.3
2567 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2569 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2570 the "Ping Builder" button if the build control is available; the
2571 user sees an exception otherwise
2573 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2575 2005-09-01 Brian Warner <warner@lothar.com>
2577 * buildbot/interfaces.py (IBuilderStatus.getState): update
2578 signature, point out that 'build' can be None
2579 (IBuildStatus.getETA): point out ETA can be none
2581 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2583 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2585 2005-08-31 Brian Warner <warner@lothar.com>
2587 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2588 update to match correct signature: removed 'eta' argument
2589 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2591 2005-08-30 Brian Warner <warner@lothar.com>
2593 * buildbot/status/builder.py (LogFile): remove the assertion that
2594 blows up when you try to overwrite an existing logfile, instead
2595 just emit a warning. This case gets hit when the buildmaster is
2596 killed and doesn't get a chance to write out the serialized
2597 BuilderStatus object, so the .nextBuildNumber attribute gets out
2600 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2601 the 'buildbot sendchange' arguments, for the Darcs context file
2602 * docs/buildbot.texinfo (sendchange): document it
2604 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2605 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2606 (IStatus.getSchedulers): new method
2607 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2608 (Status.getSchedulers): implement
2609 * buildbot/process/builder.py (Builder): maintain
2610 BuilderStatus.pendingBuilds
2611 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2612 (TryBase.addChange): Try schedulers should ignore Changes
2614 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2615 for 'try' on CVS/SVN
2616 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2618 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2619 report status properly.
2620 (Try.createJob): implement unique buildset IDs
2622 * buildbot/status/client.py (StatusClientPerspective): add a
2623 perspective_getBuildSets method for the benefit of jobdir-style
2625 * docs/buildbot.texinfo (try): more docs
2626 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2629 2005-08-18 Brian Warner <warner@lothar.com>
2631 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2632 actually work. It's functional but still kind of clunky. Also, it
2633 only works with the pb-style.. needs to be made to work with the
2636 * buildbot/status/client.py (RemoteBuildSet): new class
2637 (RemoteBuildRequest): same
2638 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2639 object, not the internal BuildStatus object.
2640 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2641 outside of the usual buildStarted() return value.
2642 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2644 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2645 (Try_Userpass_Perspective.perspective_try): return a remotely
2646 usable BuildSetStatus object
2648 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2649 isStarted()/waitUntilStarted()
2651 2005-08-16 Brian Warner <warner@lothar.com>
2653 * buildbot/status/builder.py: implement IBuildSetStatus and
2654 IBuildRequestStatus, wire them into place.
2655 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2656 methods into the BuildSetStatus object.
2657 * buildbot/interfaces.py: same
2658 (IStatus.getBuildSets): new method to get pending BuildSets
2659 (IStatusReceiver.buildsetSubmitted): new method which hears about
2661 * buildbot/master.py (BuildMaster.submitBuildSet): same
2662 * buildbot/process/base.py (BuildRequest): same, replace
2663 waitUntilStarted with subscribe/unsubscribe
2664 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2665 subscribe instead of waitUntilStarted
2666 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2668 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2670 * buildbot/test/test_buildreq.py: update for new code
2671 * buildbot/test/test_control.py (Force.testRequest): same
2674 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2675 for Darcs to not use the tempfile module, so it works under
2676 python-2.2 too. We really didn't need the full cleverness of that
2677 module, since the slave has exclusive control of its own builddir.
2679 2005-08-15 Brian Warner <warner@lothar.com>
2681 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2682 for CVS trees. It doesn't work for non-trunk branches,
2684 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2687 * Makefile: make it easier to test against python2.2
2689 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2690 tearDown2, so things like Arch can unregister archives as they're
2691 shutting down. The previous subclass-override-tearDown technique
2692 resulted in a nested maybeWait() and test failures under
2695 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2696 where we can (Arch), add a branch= argument to set the branch used
2698 (BazExtractor): extract the branch too
2699 (TlaExtractor): same
2700 * buildbot/scripts/runner.py (TryOptions): add --branch
2701 * docs/buildbot.texinfo (try): document --branch/try_branch
2703 * buildbot/slave/commands.py (Darcs): implement get-revision for
2704 Darcs, so that 'try' will work. This requires the tempfile module
2707 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2708 of revisions, branches, and 'try' in the process.
2710 2005-08-11 Brian Warner <warner@lothar.com>
2712 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2713 this, it got broken at some point in the last few releases
2714 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2715 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2716 specifically the removal of ETA information from the tuple
2718 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2721 * docs/buildbot.texinfo (try): document both --builder and
2722 'try_builders' in .buildbot/options
2723 * buildbot/scripts/runner.py (TryOptions): add --builder,
2724 accumulate the values into opts['builders']
2725 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2726 * buildbot/test/test_runner.py (Try): add some quick tests to make
2727 sure 'buildbot try --options' and .buildbot/options get parsed
2728 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2729 use --builder control
2731 * docs/buildbot.texinfo (try): add --port argument to PB style
2733 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2734 actual SourceStamp. Still need to extract a branch name, somehow.
2735 (Try): finish implementing the try client side, still need a UI
2736 for specifying which builders to use
2737 (Try.getopt): factor our options/config-file reading
2738 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2740 * buildbot/test/test_vc.py: match SourceStampExtractor change
2742 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2743 causes the twisted log to be sent to stderr
2745 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2747 2005-08-10 Brian Warner <warner@lothar.com>
2749 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2750 style is 90% done, still missing status reporting or waiting for
2751 the buildsets to finish, and it is completely untested.
2753 * buildbot/trybuild.py: delete file, move contents to ..
2754 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2755 * buildbot/test/test_vc.py: match the move
2757 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2758 of the TryScheduler, no buildsetID or status-tracking support yet
2759 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2761 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2762 possible to set the basedir after __init__ time, so it is easier
2763 to use as a Service-child of the BuildMaster instance
2765 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2766 that delivers messages to its Service parent instead of requiring
2767 a subclass to be useful. This turns out to be much easier to build
2770 * buildbot/scripts/tryclient.py (createJob): utility code to
2771 create jobfiles, will eventually be used by 'buildbot try'
2773 2005-08-08 Brian Warner <warner@lothar.com>
2775 * docs/buildbot.texinfo (try): add docs on the
2776 as-yet-unimplemented Try scheduler
2778 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2779 * buildbot/test/test_scheduler.py: .. here
2780 (Scheduling.testTryJobdir): add placeholder test for 'try'
2782 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2783 addEntry merging (>=chunkSize) behavior
2784 (Log.testConsumer): update to handle new callLater(0) behavior
2786 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2787 both the MAX_LENGTH bugfix and the resumeProducing hang.
2789 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2790 put off the actual resumeProducing for a moment with
2791 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2792 causes large logfiles to hang midway through.
2794 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2795 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2796 and to improve memory usage when streaming the file out to a web
2798 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2799 make this work cleanly
2801 2005-08-03 Brian Warner <warner@lothar.com>
2803 * buildbot/trybuild.py: new file for 'try' utilities
2804 (getSourceStamp): run in a tree, find out the baserev+patch
2805 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2806 implemented for SVN and Darcs, still working on Arch. I don't know
2807 how to make CVS work yet.
2809 * docs/buildbot.texinfo: document the 'buildbot' command-line
2810 tool, including the not-yet-implemented 'try' feature, and the
2811 in-flux .buildbot/ options directory.
2813 2005-07-20 Brian Warner <warner@lothar.com>
2815 * buildbot/locks.py: added temporary id() numbers to Lock
2816 descriptions, to track down a not-really-sharing-the-Lock bug
2818 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2820 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2821 needed for python2.2 compatibility
2822 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2823 are from the __future__
2825 2005-07-19 Brian Warner <warner@lothar.com>
2827 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2828 message when schedulers use unknown builders
2830 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2831 SlaveLock('name') and MasterLock('name') are distinct
2833 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2834 c['schedulers'] in such a way that we can actually accept
2836 * buildbot/test/test_config.py: check it
2838 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2839 utility method to *all* the Schedulers
2840 (Periodic.listBuilderNames): same
2842 * docs/buildbot.texinfo (Interlocks): update chapter to match
2845 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2846 to make sure that c['sources'], c['schedulers'], and c['status']
2847 are all lists of the appropriate objects, and that the Schedulers
2848 all point to real Builders
2849 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2850 'listBuilderNames' utility method to support this
2851 * buildbot/scheduler.py: implement the utility method
2852 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2854 * docs/buildbot.texinfo: add some @cindex entries
2856 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2857 if it wasn't already set: most tla commands will fail unless one
2859 (Arch.createRepository): and disable bazaar's revision cache, since
2860 they cause test failures (the multiple repositories we create all
2861 interfere with each other through the cache)
2863 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2864 bring it properly up to date with twisted-2.0 test guidelines
2866 * buildbot/master.py (BuildMaster): remove references to old
2867 'interlock' module, this caused a bunch of post-merge test
2869 * buildbot/test/test_config.py: same
2870 * buildbot/process/base.py (Build): same
2872 * buildbot/test/test_slaves.py: stubs for new test case
2874 * buildbot/scheduler.py: add test-case-name tag
2875 * buildbot/test/test_buildreq.py: same
2877 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2878 unnecessary init code
2879 (Bot.remote_setBuilderList): match it
2881 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2883 * buildbot/changes/mail.py (parseSyncmail): update comment
2885 * buildbot/test/test_slavecommand.py: disable Shell tests on
2886 platforms that don't suport IReactorProcess
2888 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2889 all places where we open logfiles. It causes OS-X to open the file
2890 in some weird mode that that prevents us from mixing reads and
2891 writes to the same filehandle, which we depend upon to implement
2892 _generateChunks properly. This change doesn't appear to break
2893 win32, on which "b" and "t" are treated differently but a missing
2894 flag seems to be interpreted as "t".
2896 2005-07-18 Brian Warner <warner@lothar.com>
2898 * buildbot/slave/commands.py (ShellCommand): overhaul
2899 error-handling code, to try and make timeout/interrupt work
2900 properly, and make win32 happier
2901 * buildbot/test/test_slavecommand.py: clean up, stop using
2902 reactor.iterate, add tests for timeout and interrupt
2903 * buildbot/test/sleep.py: utility for a new timeout test
2905 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2906 code from the local-usebranches branch
2908 2005-07-17 Brian Warner <warner@lothar.com>
2910 * buildbot/process/process_twisted.py
2911 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2912 minutes, to match the other twisted BuildFactories, and don't
2913 excuse failures in c/qt/win32 reactors any more.
2915 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2916 'freebsd' builders, since the buildslaves have been unavailable
2919 2005-07-13 Brian Warner <warner@lothar.com>
2921 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2922 build-on-branch feature
2924 * buildbot/process/step.py (Darcs.__init__): add base_url and
2925 default_branch arguments, just like SVN
2926 (Arch.__init__): note that the version= argument is really the
2929 * buildbot/slave/commands.py (SourceBase): keep track of the
2930 repository+branch that was used for the last checkout in
2931 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2932 match, we clobber the directory and perform a fresh checkout
2933 rather than trying to do an in-place update. This should protect
2934 us against trying to get to branch B by doing an update in a tree
2935 obtained from branch A.
2936 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2937 (SVN.setup): same, just the svnurl
2938 (Darcs.setup): same, just the repourl
2939 (Arch.setup): same, arch coordinates (url), version, and
2940 buildconfig. Also pull the buildconfig from the args dictionary,
2941 which we weren't doing before, so the build-config was effectively
2943 (Arch.sourcedirIsUpdateable): don't try to update when we're
2944 moving to a specific revision: arch can't go backwards, so it is
2945 safer to just clobber the tree and checkout a new one at the
2947 (Bazaar.setup): same sourcedata as Arch
2949 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2950 use maybeWait, to work with twisted-1.3.0 and twcompat
2951 (Dependencies.testRun_Pass): same
2953 * buildbot/test/test_vc.py: rearrange, cleanup
2955 * buildbot/twcompat.py: add defer.waitForDeferred and
2956 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2957 can work under twisted-1.3.0 .
2959 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2960 now created at setUp time. This increases the runtime of the test
2961 suite considerably (from 91 seconds to 151), but it removes the
2962 need for an offline tarball, which should solve a problem I've
2963 seen where the test host has a different version of svn than the
2964 tarball build host. The new code also validates that mode=update
2965 really picks up recent commits. This approach will also make it
2966 easier to test out branches, because the code which creates the VC
2967 branches is next to the code which uses them. It will also make it
2968 possible to test some change-notification hooks, by actually
2969 performing a VC commit and watching to see the ChangeSource get
2972 2005-07-12 Brian Warner <warner@lothar.com>
2974 * docs/buildbot.texinfo (SVN): add branches example
2975 * docs/Makefile (buildbot.ps): add target for postscript manual
2977 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2978 * buildbot/test/test_locks.py: same
2980 * buildbot/process/step.py (Darcs): comment about default branches
2982 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2983 c['interlocks'] in the config file, complain if it is present.
2984 Scan all locks in c['builders'] to make sure the Locks they use
2986 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2987 add some tests to check for non-uniquely-named Locks
2988 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2989 since the unique-Lock validation code requires it now
2991 * buildbot/locks.py: fix test-case-name
2993 * buildbot/interlock.py: remove old file
2995 2005-07-11 Brian Warner <warner@lothar.com>
2997 * buildbot/test/test_interlock.py: rename to..
2998 * buildbot/test/test_locks.py: .. something shorter
3000 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3001 versions (after 2.0.1) changed internet.TCPClient to shut down the
3002 connection in stopService. Change the code to handle this
3005 * buildbot/process/base.py (Build): handle whole-Build locks
3006 * buildbot/process/builder.py (Builder.compareToSetup): same
3007 * buildbot/test/test_interlock.py: make tests work
3009 * buildbot/process/step.py (BuildStep.startStep): complain if a
3010 Step tries to claim a lock that's owned by its own Build
3011 (BuildStep.releaseLocks): typo
3013 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3014 file reloads don't replace unchanged Builders
3016 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3017 rewrite to cover new Locks instead of old c['interlocks']
3018 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3022 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3023 start the master and connect the buildslave
3025 * buildbot/process/step.py (FailingDummy.done): finish with a
3026 FAILURE status rather than raising an exception
3028 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3029 stringify a BuildRequest.reason that is None
3031 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3033 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3034 allow scheduler.Dependent to work
3035 * buildbot/buildset.py (BuildSet): set .reason and .results
3037 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3038 slaves, to make the test stop hanging. It still fails, of course,
3039 because I haven't even started to implement Locks.
3041 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3043 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3044 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3045 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3046 (Dependent): new class for downstream build dependencies
3047 * buildbot/test/test_dependencies.py: tests (still failing)
3049 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3051 2005-07-07 Brian Warner <warner@lothar.com>
3053 * buildbot/test/runutils.py (RunMixin): factored this class out..
3054 * buildbot/test/test_run.py: .. from here
3055 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3056 added new buildbot.locks tests (which all hang right now)
3057 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3058 * buildbot/process/step.py: claim/release per-BuildStep locks
3060 * docs/Makefile: add 'buildbot.html' target
3062 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3063 interpreted as "HEAD", so that all VC steps can accept branch=None
3064 and have it mean the "default branch".
3066 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3068 2005-07-07 Brian Warner <warner@lothar.com>
3070 * docs/examples/twisted_master.cfg: update to match current usage
3072 * docs/buildbot.texinfo (System Architecture): comment out the
3073 image, it doesn't exist yet and just screws up the HTML manual.
3075 2005-07-05 Brian Warner <warner@lothar.com>
3077 * debian/.cvsignore: oops, missed one. Removing leftover file.
3079 2005-06-17 Brian Warner <warner@lothar.com>
3081 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3082 changed its output in 1.2.0, don't mistakenly think that the
3083 subversion we find isn't capable of supporting our tests.
3085 * debian/*: remove the debian/ directory and its contents, to make
3086 life easier for the proper Debian maintainer
3088 * Makefile (release): same
3090 2005-06-07 Brian Warner <warner@lothar.com>
3092 * everything: create a distinct SourceStamp class to replace the
3093 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3094 Changed the signature of Source.startVC to include the revision
3095 information (instead of passing it through self.args). Implement
3096 branches for SVN (now only Darcs/Git is missing support). Add more
3099 2005-06-06 Brian Warner <warner@lothar.com>
3101 * everything: rearrange build scheduling. Create a new Scheduler
3102 object (configured in c['schedulers'], which submit BuildSets to a
3103 set of Builders. Builders can now use multiple slaves. Builds can
3104 be run on alternate branches, either requested manually or driven
3105 by changes. This changed some of the Status classes. Interlocks
3106 are out of service until they've been properly split into Locks
3107 and Dependencies. treeStableTimer, isFileImportant, and
3108 periodicBuild have all been moved from the Builder to the
3110 (BuilderStatus.currentBigState): removed the 'waiting' and
3111 'interlocked' states, removed the 'ETA' argument.
3113 2005-05-24 Brian Warner <warner@lothar.com>
3115 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3116 erroneously abandons the connection (in clientConnectionFailed)
3117 for non-UserErrors, which means that if we lose the connection due
3118 to a network problem or a timeout, we'll never try to reconnect.
3119 Fix this by not upcalling to the buggy parent method. Note:
3120 twisted-2.0 fixes this, but the function only has 3 lines so it
3121 makes more sense to copy it than to try and detect the buggyness
3122 of the parent class. Fixes SF#1207588.
3124 * buildbot/changes/changes.py (Change.branch): doh! Add a
3125 class-level attribute to accomodate old Change instances that were
3126 pickled before 0.6.5 (where .branch was added for new Changes).
3127 This fixes the exception that occurs when you try to look at an
3128 old Change (through asHTML).
3130 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3133 2005-05-23 Brian Warner <warner@lothar.com>
3135 * buildbot/__init__.py (version): release 0.6.6
3137 2005-05-23 Brian Warner <warner@lothar.com>
3139 * NEWS: update for 0.6.6 release
3140 * debian/changelog: same
3142 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3143 before starting: this was done by twistd back when we spawned it,
3144 now that we're importing the pieces and running them in the
3145 current process, we have to do it ourselves. This allows
3146 master.cfg to import files from the same directory without
3147 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3148 Stichele for the catch.
3149 (Options.opt_version): Add a --version command (actually, just make
3150 the existing --version command emit Buildbot's version too)
3152 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3153 fix to make this behave like other LogFiles, this time to handle
3154 existing LogFiles on disk. (add the missing .upgrade method)
3155 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3157 2005-05-21 Brian Warner <warner@lothar.com>
3159 * buildbot/test/test_runner.py (Create.testMaster): match the
3160 rawstring change in runner.py:masterTAC
3162 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3163 TwistedWords is installed
3164 * buildbot/test/test_status.py: same, with TwistedMail
3166 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3167 some old, deprecated, and removed config keys). This should enable
3168 you to use the base buildbot functionality with Twisted-2.0.0 when
3169 you don't also have TwistedWeb and TwistedWords installed
3171 2005-05-20 Brian Warner <warner@lothar.com>
3173 * buildbot/scripts/runner.py (run): call sendchange(), not
3174 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3175 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3176 (stop): don't wait for process to die when sending SIGHUP
3177 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3178 directory name gets interpreted, which you don't want
3181 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3184 2005-05-18 Brian Warner <warner@lothar.com>
3186 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3188 2005-05-18 Brian Warner <warner@lothar.com>
3190 * README: update for 0.6.5
3191 * debian/changelog: same
3193 * buildbot/changes/changes.py: rename tag= to branch=, since
3194 that's how we're using it, and my design for the upcoming "build a
3195 specific branch" feature wants it. also, tag= was too CVS-centric
3196 * buildbot/changes/mail.py (parseSyncmail): same
3197 * buildbot/process/base.py (Build.isBranchImportant): same
3198 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3199 * docs/buildbot.texinfo (Attributes of Changes): same
3201 * NEWS: update tag=, update for upcoming release
3203 2005-05-17 Brian Warner <warner@lothar.com>
3205 * buildbot/scripts/runner.py (stop): actually poll once per
3206 second, instead of re-killing the poor daemon once per second.
3207 Sleep briefly (0.1s) before the first poll, since there's a good
3208 chance we can avoid waiting the full second if the daemon shuts
3209 down quickly. Also remove the sys.exit() at the end.
3210 (start): remove the unneighborly sys.exit()
3212 * Makefile: improve permission-setting to not kick Arch so badly
3214 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3215 default --keepalive=600, since it doesn't hurt very much, and it's
3216 a hassle to discover that you need it.
3217 * buildbot/test/test_runner.py (Create.testSlave): test it
3219 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3220 IRC bot about EXCEPTION
3222 * buildbot/status/client.py (PBListener): upcall more correctly
3224 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3225 an exception mark the overall build with EXCEPTION, not SUCCESS
3227 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3229 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3230 * Makefile: update some release-related stuff
3232 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3233 gets called when there isn't actually an active process, just end
3234 the Command instead of blowing up. I don't know how it gets into
3235 this state, but the twisted win32 buildslave will sometimes hang,
3236 and when it shakes its head and comes back, it thinks it's still
3237 running a Command. The next build causes this command to be
3238 interrupted, but the lack of self.process.pid breaks the interrupt
3241 * NEWS: document changes since the last release
3243 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3244 look for Makefile.buildbot instead of a bare Makefile . The
3245 'buildbot start' does not install this file, so you have to
3246 manually copy it if you want to customize startup behavior.
3247 (createMaster): change 'buildbot master' command to create
3248 Makefile.sample instead of Makefile, to create master.cfg.sample
3249 instead of master.cfg (requiring you to copy it before the
3250 buildmaster can be started). Both sample files are kept up to
3251 date, i.e. they are overwritten if they have been changed. The
3252 'buildbot.tac' file is *not* overwritten, but if the new contents
3253 don't match the old, a 'buildbot.tac.new' file is created and the
3254 user is warned. This seems to be a much more sane way to handle
3255 startup files. Also, don't sys.exit(0) when done, so we can run
3256 unit tests against it.
3257 (createSlave): same. Don't overwrite the sample info/ files.
3258 * buildbot/scripts/sample.mk: remove. the contents were pulled
3259 into runner.py, since they need to match the behavior of start()
3263 * docs/buildbot.texinfo (Launching the daemons): document it
3264 * buildbot/test/test_runner.py (Create): test it
3266 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3267 version that can handle string-in-string tests, because otherwise
3268 python-2.2 fails the tests. It'd be tremendous if Trial's test
3269 took two strings under 2.2 too.
3271 * everything: fixed all deprecation warnings when running against
3272 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3273 few that come from Twisted itself). This involved putting most of
3274 the Twisted-version specific code in the new buildbot.twcompat
3275 module, and creating some abstract base classes in
3276 buildbot.changes.base and buildbot.status.base (which might be
3277 useful anyway). __implements__ is a nuisance and requires an ugly
3278 'if' clause everywhere.
3280 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3281 delay before finishing the test: it seems that smtp.sendmail
3282 doesn't hang up on the server, so we must wait a moment so it can
3283 hang up on us. This removes the trial warning about an unclean
3286 2005-05-16 Brian Warner <warner@lothar.com>
3288 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3289 tuple of (delay, repeats).
3290 * buildbot/test/test_vc.py (Retry): test it
3291 * docs/buildbot.texinfo (Source Checkout): document it
3292 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3293 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3294 doVCFull() are handled by re-trying the checkout (after a delay)
3295 some number of times.
3296 (ShellCommand._startCommand): make header lines easier to read
3298 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3300 (WebTest.test_logfile): make sure master gets shut down, silences
3301 some "unclean reactor" test errors
3303 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3304 reactor once after shutdown, something in certain versions of
3305 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3306 fails, svn-trunk is ok.
3308 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3309 second win32 error message
3311 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3312 validating the ETA, so the tests don't fail on slow systems
3314 2005-05-15 Brian Warner <warner@lothar.com>
3316 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3317 the new LogFile class, so upgrading works properly
3318 (LogFileProducer.resumeProducing): survive resumeProducing after
3319 we've exhausted the chunkGenerator
3321 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3323 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3324 (Log.testUpgrade): same
3326 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3327 Builds and logs with a cron job.
3329 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3330 of the old non-offline LogFile, added code to upgrade these to
3331 new-style contents-live-on-disk instances at load time (in a way
3332 that doesn't invalidate the old Build pickles, so upgrading to
3333 0.6.5 is not a one-way operation). Got rid of everything related
3335 (LogFile.__init__): create LogFiles with the parent step status,
3336 the log's name, and a builder-relative filename where it can keep
3337 the contents on disk.
3338 (LogFile.hasContents): new method, clients are advised to call it
3339 before getText or getChunks and friends. If it returns False, the
3340 log's contents have been deleted and getText() will raise an
3342 (LogFile.getChunks): made it a generator
3343 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3344 Consumer (except one that takes chunks instead of strings). This
3345 enables streaming of very large logfiles without storing the whole
3347 (BuildStatus.generateLogfileName): create names like
3348 12-log-compile-output, with a _0 suffix if required to be unique
3349 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3350 or earlier) logfiles into new-style ones
3351 (BuilderStatus): remove everything related to 'stub' builds. There
3352 is now only one build cache, and we don't strip logs from old
3354 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3355 since we no longer fight to keep it in the cache
3357 * buildbot/status/html.py (TextLog.render_GET): use a
3358 ChunkConsumer to stream the log entries efficiently.
3359 (ChunkConsumer): wrapper which consumes chunks and writes
3362 * buildbot/test/test_twisted.py (Parse.testParse): use a
3363 LogFile-like object instead of a real one
3365 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3366 (Log.testMerge3): validate more merge behavior
3367 (Log.testChunks): validate LogFile.getChunks
3368 (Log.testUpgrade): validate old-style LogFile upgrading
3369 (Log.testSubscribe): validate LogFile.subscribe
3370 (Log.testConsumer): validate LogFile.subscribeConsumer
3372 * buildbot/interfaces.py (IStatusLogStub): remove
3373 (IStatusLog.subscribeConsumer): new method
3374 (IStatusLog.hasContents): new method
3375 (IStatusLogConsumer): describes things passed to subscribeConsumer
3377 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3378 the log contents if it does not have any contents.
3379 (StatusResourceBuildStep.body): same
3380 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3382 2005-05-14 Brian Warner <warner@lothar.com>
3384 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3385 timeouts to try and make the windows metabuildslave not hang
3387 2005-05-13 Mike Taylor <bear@code-bear.com>
3389 * buildbot/slave/commands.py (rmdirRecursive): added a check
3390 to ensure the path passed into rmdirRecursive actually exists.
3391 On win32 a non-existant path would generate an exception.
3393 2005-05-13 Brian Warner <warner@lothar.com>
3395 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3396 shutil.rmtree which behaves correctly on windows in the face of
3397 files that you have to chmod before deleting. Thanks to Bear at
3398 the OSAF for the routine.
3399 (SourceBase.doClobber): use rmdirRecursive
3401 2005-05-12 Brian Warner <warner@lothar.com>
3403 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3404 method generate chunks instead of returning a big list. This
3405 allows the same method to be used for both old LogFile and new
3407 (OfflineLogFile.getText): use the generator
3408 (OfflineLogFile.subscribe): same
3409 * buildbot/status/html.py (TextLog.resumeProducing): same
3410 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3412 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3413 point out that OfflineLogFile does not currently work with
3414 html.Waterfall . Fixing this is high-priority.
3416 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3417 apparently windows defaults to using stdout
3419 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3420 better message on failure so I can figure out the win32 problem
3422 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3423 log messages to include more useful copies of the command being
3424 run, the argv array, and the child command's environment.
3425 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3427 2005-05-11 Brian Warner <warner@lothar.com>
3429 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3431 * Makefile: update the deb-snapshot version
3433 * docs/buildbot.texinfo: move all .xhtml docs into a new
3434 .texinfo-format document, adding a lot of material in the process.
3435 This is starting to look like a real user's manual. Removed all
3436 the Lore-related files: *.xhtml, *.css, template.tpl .
3437 * docs/Makefile: simple makefile to run 'makeinfo'
3438 * buildbot/scripts/sample.cfg: rearrange slightly
3439 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3441 2005-05-10 Brian Warner <warner@lothar.com>
3443 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3444 different name for the internal twistw module, handle it.
3446 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3447 * setup.py: .. and stop trying to install it
3449 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3450 'git'), the new linux kernel VC system (http://kernel.org/git/).
3451 Thanks to Brandon Philips for the patch.
3452 * buildbot/slave/commands.py (Git): same
3454 2005-05-06 Brian Warner <warner@lothar.com>
3456 * buildbot/status/builder.py (OfflineLogFile): replace the default
3457 LogFile with a form that appends its new contents to a disk file
3458 as they arrive. The complete log data is never kept in RAM. This
3459 is the first step towards handling very large (100MB+) logfiles
3460 without choking quite so badly. (The other half is
3461 producer/consumer on the HTML pages).
3462 (BuildStepStatus.addLog): use OfflineLogFile by default
3463 (BuildStatus.getLogfileName): helper code to give the
3464 OfflineLogFile a filename to work with
3466 * buildbot/test/test_status.py (Results.testAddResults): update
3467 tests to handle new asserts
3468 * buildbot/test/test_vc.py (Patch.doPatch): same
3469 * buildbot/test/test_steps.py (BuildStep.setUp): same
3471 2005-05-05 Brian Warner <warner@lothar.com>
3473 * buildbot/scripts/runner.py (start): if there is no Makefile,
3474 launch the app by importing twistd's internals and calling run(),
3475 rather than spawning a new twistd process. This stands a much
3476 better chance of working under windows.
3477 (stop): kill the process with os.kill instead of spawning
3478 /bin/kill, again to reduce the number of external programs which
3479 windows might not have in the PATH. Also wait up to 5 seconds for
3480 the process to go away, allowing things like 'buildbot stop;
3481 buildbot start' to be reliable in the face of slow shutdowns.
3483 * buildbot/master.py (Dispatcher.__getstate__): remove old
3484 .tap-related methods
3485 (BuildMaster.__getstate__): same
3487 * buildbot/slave/bot.py (makeService): same
3488 (Options.longdesc): same
3489 * buildbot/scripts/runner.py: copy over some old mktap option text
3491 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3492 'buildbot master' now creates a buildbot.tac file, so there is no
3493 longer a create-instance/save/reload sequence. mktap is dead, long
3495 * buildbot/scripts/sample.mk: use twistd -y, not -f
3496 * buildbot/test/test_config.py: remove mktap-based test
3497 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3498 * README: don't reference mktap
3500 * docs/source.xhtml: document some of the attributes that Changes
3503 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3505 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3506 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3507 * buildbot/changes/changes.py (Change)
3508 * buildbot/changes/mail.py (parseSyncmail)
3509 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3511 * buildbot/process/base.py (Build.isTagImportant)
3515 2005-05-04 Brian Warner <warner@lothar.com>
3517 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3518 connection after sending the change, so that unit tests don't
3519 complain about sockets being left around
3521 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3522 exception in phase=0 rendering
3523 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3525 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3527 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3528 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3529 and configuring builders with tuples.
3530 * buildbot/test/test_config.py: stop testing compatibility with
3531 deprecated config keys
3532 * buildbot/test/test_run.py: same
3534 2005-05-03 Brian Warner <warner@lothar.com>
3536 * contrib/arch_buildbot.py: survive if there are no logfiles
3537 (username): just use a string, os.getlogin isn't reliable
3539 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3540 so 'buildbot sendchange' actually works. The earlier test only
3541 covered the internal (non-reactor-running) form.
3543 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3544 script to notify the buildmaster about changes
3546 * buildbot/scripts/runner.py (sendchange): new command to send a
3547 change to a buildbot.changes.pb.PBChangeSource receiver.
3548 * buildbot/test/test_changes.py (Sender): test it
3550 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3551 after any reading of the config file, not just when we do it in
3552 startService. This makes some tests a bit cleaner.
3554 * buildbot/changes/pb.py: add some log messages
3556 * buildbot/process/base.py (Build.startBuild): fix a bug that
3557 caused an exception when the build terminated in the very first
3559 (Build.stepDone): let steps return a status of EXCEPTION. This
3560 terminates the build right away, and sets the build's overall
3561 status to EXCEPTION too.
3562 * buildbot/process/step.py (BuildStep.failed): return a status of
3563 EXCEPTION when that is what has happened.
3565 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3566 implement this, allowing Arch-based projects to get precise
3567 checkouts instead of always using the latest code
3568 (Bazaar): create variant of Arch to let folks use baz instead of
3569 tla. Requires a new buildslave too.
3570 * buildbot/slave/commands.py (Arch): add 'revision' argument
3571 (Bazaar): create variant of Arch that uses baz instead of tla.
3572 Remove the code that extracts the archive name from the
3573 register-archive output, since baz doesn't provide it, and require
3574 the user provide both the archive name and its location.
3575 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3577 2005-05-02 Brian Warner <warner@lothar.com>
3579 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3580 thanks to Nick Trout.
3582 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3583 deals better with source Makefile coming from a read-only CVS
3584 checkout. Thanks to Nick Trout for the catch.
3586 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3589 2005-04-28 Brian Warner <warner@lothar.com>
3591 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3593 * debian/changelog: update for 0.6.4
3595 2005-04-28 Brian Warner <warner@lothar.com>
3597 * README.w32: add a checklist of steps for getting buildbot
3599 * MANIFEST.in: include it in the tarball
3603 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3604 broken .tap files from 0.6.3 by getting rid of .services,
3605 .namedServices, and .change_svc at load time.
3607 2005-04-27 Brian Warner <warner@lothar.com>
3609 * NEWS: update in preparation for new release
3611 * buildbot/test/test_config.py (Save.testSave): don't pull in
3612 twisted.scripts.twistd, we don't need it and it isn't for windows
3615 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3616 accomodate win32 which can't do atomic-rename
3618 2005-04-27 Brian Warner <warner@lothar.com>
3620 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3621 timeouts to help the slow metabuildbot not flunk them so much
3622 (Disconnect.testBuild3): same
3623 (Disconnect.testBuild4): same
3624 (Disconnect.testInterrupt): same
3626 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3627 setup, it was completely broken for new buildmasters (those which
3628 did not have a 'change.pck' already saved. Thanks to Paul Warren
3629 for catching this (embarrassing!) bug.
3630 (Dispatcher.__getstate__): don't save our registered avatar
3631 factories, since they'll be re-populated when the config file is
3633 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3634 tests (since the real mktap-generated BuildMaster doesn't save
3636 (BuildMaster.__getstate__): don't save any service children,
3637 they'll all be re-populated when the config file is re-read.
3638 * buildbot/test/test_config.py (Save.testSave): test for this
3640 2005-04-26 Brian Warner <warner@lothar.com>
3642 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3643 rendered with Blender.. looks a bit nicer.
3644 * buildbot/docs/images/icon.blend: add the Blender file for it
3646 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3647 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3648 running under windows. This appears to be the best way to allow
3649 BuildSteps to do something normal like 'trial -v buildbot.test' or
3650 'make foo' and still expect it to work. The idea is to make the
3651 BuildSteps look as much like what a developer would type when
3652 compiling or testing the tree by hand. This approach probably has
3653 problems when there are spaces in the arguments, so if you've got
3654 windows buildslaves, you'll need to pay close attention to your
3657 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3658 timezone to the timestamp column.
3659 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3661 * buildbot/scripts/runner.py (loadOptions): do something sane for
3662 windows, I think. We use %APPDATA%/buildbot instead of
3663 ~/.buildbot, but we still search everywhere from the current
3664 directory up to the root for a .buildbot/ subdir. The "is it under
3665 $HOME" security test was replaced with "is it owned by the current
3666 user", which is only performed under posix.
3667 * buildbot/test/test_runner.py (Options.testFindOptions): update
3668 tests to match. The "is it owned by the current user" check is
3669 untested. The test has been re-enabled for windows.
3671 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3672 any "\n" in the expected output with the platform-specific line
3673 separator. Make this separator "\r\n" on PTYs under unix, they
3674 seem to do that and I don't know why
3676 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3677 windows for now, I don't know what ~/.buildbot/ should mean there.
3679 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3680 win32 compatibility, don't use "/tmp"
3681 (Basedir.testChangeBuilddir): remove more unixisms
3683 2005-04-26 Brian Warner <warner@lothar.com>
3685 * buildbot/test/test_control.py (Force.rmtree): python2.2
3686 compatibility, apparently its shutil.rmtree ignore_errors=
3687 argument is ignored.
3688 * buildbot/test/test_run.py (Run.rmtree): same
3689 (RunMixin.setUp): same
3691 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3694 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3695 'substring in string' operator, must use string.find(substr)!=-1
3696 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3697 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3699 * buildbot/scripts/runner.py (loadOptions): add code to search for
3700 ~/.buildbot/, a directory with things like 'options', containing
3701 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3702 the current directory, your $HOME directory, or anywhere
3703 inbetween, as long as you're somewhere inside your home directory.
3704 (debugclient): look in ~/.buildbot/options for master and passwd
3705 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3706 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3708 * buildbot/status/client.py (makeRemote): new approach to making
3709 IRemote(None) be None, which works under Twisted-2.0
3710 * buildbot/test/test_status.py (Client.testAdaptation): test it
3712 * buildbot/status/builder.py (Status.builderAdded): when loading a
3713 pickled BuilderStatus in from disk, set its name after loading.
3714 The config file might have changed its name (but not its
3715 directory) while it wasn't looking.
3717 * buildbot/process/builder.py (Builder.attached): always return a
3718 Deferred, even if the builder was already attached
3719 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3721 2005-04-25 Brian Warner <warner@lothar.com>
3723 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3724 category-related exception when announcing a build has finished
3726 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3727 reference no-longer-existent changemaster.sources
3728 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3730 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3733 2005-04-25 Brian Warner <warner@lothar.com>
3735 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3737 * debian/changelog: update for 0.6.3
3739 2005-04-25 Brian Warner <warner@lothar.com>
3741 * MANIFEST.in: make sure debug.glade is in the tarball
3743 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3745 * NEWS: update for the imminent 0.6.3 release
3747 * buildbot/status/html.py (HtmlResource.content): make the
3748 stylesheet <link> always point at "buildbot.css".
3749 (StatusResource.getChild): map "buildbot.css" to a static.File
3750 containing whatever css= argument was provided to Waterfall()
3751 (Waterfall): provide the "classic" css as the default.
3752 * docs/waterfall.classic.css: move default CSS from here ..
3753 * buildbot/status/classic.css: .. to here
3755 * MANIFEST.in: make sure classic.css is included in the tarball
3756 * setup.py: and that it is installed too, under buildbot/status/
3758 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3759 the module level, because buildbot.tap files from 0.6.2 don't have
3760 it in their attribute dictionary.
3762 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3763 really exists at startup, might save some confusion somewhere.
3765 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3767 * docs/waterfall.classic.css:
3768 add a stylesheet that's almost the same as the "classic"
3771 * buildbot/status/builder.py:
3772 add EXCEPTION as a result - this is a problem for the bot
3773 maintainer, not a build problem for the changers
3774 * buildbot/process/step.py:
3775 use EXCEPTION instead of FAILURE for exceptions
3776 * buildbot/status/html.py:
3777 add build_get_class to get a class out of a build/buildstep
3778 finish naming the classes
3779 split out sourceNames to changeNames and builderNames so we
3780 can style them separately
3781 * docs/config.xhtml:
3782 finish documenting classes as they are right now
3784 * buildbot/status/html.py:
3785 name the classes as we agreed on IRC
3786 * docs/config.xhtml:
3789 * buildbot/status/html.py:
3790 same for cssclass->class_
3792 * buildbot/status/html.py:
3793 as decided on IRC, use class_ for the "class" attribute to not
3794 conflict with the class keyword, and clean up the messy **{} stuff.
3796 * buildbot/status/mail.py:
3797 put back "builders" argument, and fix docstring, because the
3798 code *ignores* builders listed in this argument
3800 * buildbot/process/builder.py:
3801 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3803 * docs/config.xhtml:
3804 describe the category argument for builders
3806 * buildbot/status/builder.py:
3807 Fix a silly bug due to merging
3809 * buildbot/process/builder.py:
3810 remove category from the process Builder ...
3811 * buildbot/status/builder.py:
3812 ... and add it to BuilderStatus instead.
3813 Set category on unpickled builder statuses, they might not have it.
3814 * buildbot/master.py:
3815 include category when doing builderAdded
3816 * buildbot/status/mail.py:
3817 return None instead of self for builders we are not interested in.
3818 * buildbot/test/test_run.py:
3819 fix a bug due to only doing deferredResult on "dummy" waiting
3820 * buildbot/test/test_status.py:
3821 add checks for the Mail IStatusReceiver returning None or self
3823 * buildbot/status/html.py:
3824 fix testsuite by prefixing page title with BuildBot
3826 * buildbot/status/builder.py:
3827 have .category in builder status ...
3828 * buildbot/process/builder.py:
3829 ... and set it from Builder
3830 * buildbot/status/html.py:
3831 make .css a class variable
3832 * buildbot/test/test_status.py:
3833 write more tests to cover our categories stuff ...
3834 * buildbot/status/mail.py:
3835 ... and fix the bug that this uncovered
3837 * buildbot/changes/mail.py:
3838 * buildbot/changes/pb.py:
3839 * buildbot/master.py:
3840 * buildbot/process/base.py:
3841 * buildbot/process/factory.py:
3842 * buildbot/process/interlock.py:
3843 * buildbot/process/step.py:
3844 * buildbot/process/step_twisted.py:
3845 * buildbot/slave/commands.py:
3846 * buildbot/status/builder.py:
3847 * buildbot/status/client.py:
3848 * buildbot/status/html.py:
3849 * buildbot/status/mail.py:
3850 * buildbot/status/progress.py:
3851 * buildbot/test/test_changes.py:
3852 * buildbot/test/test_config.py:
3853 * buildbot/test/test_control.py:
3854 * buildbot/test/test_interlock.py:
3855 * buildbot/test/test_maildir.py:
3856 * buildbot/test/test_mailparse.py:
3857 * buildbot/test/test_run.py:
3858 * buildbot/test/test_slavecommand.py:
3859 * buildbot/test/test_status.py:
3860 * buildbot/test/test_steps.py:
3861 * buildbot/test/test_twisted.py:
3862 * buildbot/test/test_util.py:
3863 * buildbot/test/test_vc.py:
3864 * buildbot/test/test_web.py:
3866 add test-case-name at the top of a whole set of files
3868 * buildbot/status/builder.py:
3869 keep order of addition when getting builder names
3870 * buildbot/status/words.py:
3871 * buildbot/test/test_run.py:
3872 add test for getBuilderNames
3874 * buildbot/process/base.py:
3875 * buildbot/process/step.py:
3876 * buildbot/status/builder.py:
3877 * buildbot/status/html.py:
3878 make buildbot css-able
3879 replace the color code for purple with purple, don't understand
3880 why it wasn't purple to start with
3882 * buildbot/status/words.py:
3883 ok, so it doesn't look like BuilderStatus.remote is still valid.
3884 Use what waterfall uses instead.
3886 * buildbot/interfaces.py:
3887 * buildbot/status/builder.py:
3888 * buildbot/status/html.py:
3889 * buildbot/status/mail.py:
3890 * buildbot/status/words.py:
3891 * buildbot/test/test_run.py:
3892 use categories everywhere and make it be a list. More sensible
3893 for the future. Also make words actually respect this in
3896 * buildbot/interfaces.py:
3897 add category argument to getBuilderNames
3898 * buildbot/process/builder.py:
3899 * buildbot/status/builder.py:
3900 * buildbot/status/html.py:
3901 * buildbot/status/mail.py:
3902 * buildbot/status/words.py:
3903 * buildbot/test/test_run.py:
3904 move from specifying builders by name to specifying the category
3906 * buildbot/status/html.py:
3907 * buildbot/status/words.py:
3908 add "builders=" to __init__ of status clients so they can
3909 limit themselves to the given list of builders to report on
3911 * buildbot/status/html.py: set the title to the product name
3913 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3915 * buildbot/interfaces.py:
3916 * buildbot/status/builder.py:
3917 more documentation. Hm, not sure if ChangeLog entries make sense
3920 2005-04-23 Brian Warner <warner@lothar.com>
3922 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3924 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3926 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3927 the sub-commands that log buildmaster status to stdout and to a
3928 GUI window, respectively.
3930 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3931 functionality is working again, but all the step-status and ETA
3932 stuff is missing. Commented out a lot of code pending more
3935 * buildbot/status/client.py: make sure that IRemote(None) is None
3937 * buildbot/changes/changes.py: import defer, oops
3938 (ChangeMaster): remove the .sources list, rely upon the fact that
3939 MultiServices can be treated as sequences of their children. This
3940 cleans up the add/remove ChangeSource routines a lot, as we keep
3941 exactly one list of the current sources instead of three.
3943 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3944 up an empty ChangeMaster at init time.
3945 (BuildMaster.loadChanges): if there are changes to be had from
3946 disk, replace self.change_svc with the new ones. If not, keep
3947 using the empty ChangeMaster set up in __init__.
3948 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3949 instead of a separate list, makes the code a bit cleaner.
3950 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3951 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3952 Extend the test to make sure we can get rid of the sources when
3955 2005-04-22 Brian Warner <warner@lothar.com>
3957 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3958 and info/host files when making the slave directory
3960 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3961 whendone= argument, just return the Deferred and let the caller do
3962 what they want with it.
3963 (Disconnect.testBuild1): wait for shutdownSlave
3964 (Basedir.testChangeBuilddir): new test to make sure changes to the
3965 builddir actually get propagated to the slave
3967 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3968 explicit method, rather than passing the builddir in __init__ .
3969 Make sure to update self.basedir too, this was broken before.
3970 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3971 builders and for ones that have just had their builddir changed.
3972 (BotFactory): add a class-level .perspective attribute, so
3973 BuildSlave.waitUntilDisconnected won't get upset when the
3974 connection hasn't yet been established
3975 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3976 tests can reach through it to inspect the SlaveBuilders
3978 * buildbot/process/base.py (Build.buildException): explain the
3979 log.err with a log.msg
3980 * buildbot/process/builder.py (Builder.startBuild): same
3981 (Builder._startBuildFailed): improve error message
3983 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3984 occurred because we lost the brand-new connection, retry instead
3985 of giving up. If not, it's probably an authorization failure, and
3986 it makes sense to stop trying. Make sure we log.msg the reason
3987 that we're log.err'ing the failure, otherwise test failures are
3988 really hard to figure out.
3990 * buildbot/master.py: change loadConfig() to return a Deferred
3991 that doesn't fire until the change has been fully implemented.
3992 This means any connected slaves have been updated with the new
3993 builddir. This change makes it easier to test the code which
3994 actually implements this builddir-updating.
3995 (BotPerspective.addBuilder): return Deferred
3996 (BotPerspective.removeBuilder): same
3997 (BotPerspective.attached): same
3998 (BotPerspective._attached): same. finish with remote_print before
3999 starting the getSlaveInfo, instead of doing them in parallel
4000 (BotPerspective.list_done): same
4001 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4002 actually calling slave.disconnect()
4003 (BotMaster.addBuilder): same
4004 (BotMaster.removeBuilder): same
4005 (BuildMaster.loadConfig): same
4006 (BuildMaster.loadConfig_Slaves): same
4007 (BuildMaster.loadConfig_Sources): same
4008 (BuildMaster.loadConfig_Builders): same
4009 (BuildMaster.loadConfig_status): same
4011 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4012 a Deferred that fires when the source is finally removed
4014 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4015 the previous tree on win32, where we have to do it synchronously,
4016 make sure we return a Deferred anyway.
4017 (SourceBase.doCopy): same
4019 * buildbot/scripts/runner.py (statusgui): use the text client for
4020 now, while I rewrite the Gtk one
4021 * buildbot/clients/base.py: strip out old code, leaving just the
4022 basic print-message-on-event functionality. I also remove the
4023 ReconnectingPBClientFactory, but it does at least quit when it
4024 loses the connection instead of going silent
4026 2005-04-21 Brian Warner <warner@lothar.com>
4028 * Makefile: minor tweaks
4030 * NEWS: point out deprecation warnings, new features for
4033 * buildbot/master.py (BuildMaster.loadConfig): emit
4034 DeprecationWarnings for Builders defined with tuples. Rearrange
4035 code to facility removal of deprecated configuration keys in the
4038 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4039 'buildbot' command to put a little Makefile in the target that
4040 helps you re-create the buildbot.tap file, start or stop the
4041 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4042 all the files 0600, since they contain passwords.
4043 (start): if there is a Makefile, and /usr/bin/make exists, use
4044 'make start' in preference to a raw twistd command. This lets
4045 slave admins put things like PYTHONPATH variables in their
4046 Makefiles and have them still work when the slave is started with
4047 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4048 be nice to first try the 'make' command and only fall back to
4049 twistd if it fails. TODO: the Makefile's "start" command does not
4050 add the --reactor=win32 argument when running under windows.
4051 (Options.debugclient, Options.statusgui): add sub-commands to launch
4052 the debug client (formerly in contrib/debugclient.py) and the
4053 Gtk status application (currently broken)
4054 * buildbot/clients/debug.py: move from contrib/debugclient.py
4055 * buildbot/clients/debug.glade: same
4057 * buildbot/test/test_trial.py: remove it. This requires some
4058 functionality out of Twisted that isn't there yet, and until then
4059 having it around just confuses things.
4061 * buildbot/test/test_slavecommand.py (Shell): test both with and
4062 without PTYs, and make sure that command output is properly
4063 interleaved in the with-PTY case. I think the without-PTY test
4064 should pass on windows, where we never use PTYs anyway.
4066 2005-04-20 Brian Warner <warner@lothar.com>
4068 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4070 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4072 * NEWS: start creating entries for the next release
4074 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4076 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4077 (WebTest.test_webPathname): same
4078 (WebTest.test_webPathname_port): same
4079 (WebTest.test_waterfall): use the default favicon rather than
4080 rooting around the filesystem for it. Open the expected-icon file
4081 in binary mode, to make win32 tests happier (thanks to Nick Trout
4083 * buildbot/status/html.py (buildbot_icon): win32 portability
4085 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4086 win32-compatibility fixes from Nick Trout, the "file not found" message
4087 is different under windows
4088 (FakeSlaveBuilder.__init__): clean up setup a bit
4089 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4091 2005-04-19 Brian Warner <warner@lothar.com>
4093 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4094 skip-if-repositories-are-unavailable test to not kill the trial
4095 that comes with Twisted-1.3.0
4097 * setup.py: install buildbot.png icon file when installing code
4099 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4100 environment used by the command, at least on the child side.
4102 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4103 this method needs to be added and implemented because it gets
4104 called under heavy load. I don't quite understand the
4105 producer/consumer API enough to write it.
4106 (StatusResource.getChild): add a resource for /favicon.ico
4107 (Waterfall.__init__): add favicon= argument
4108 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4109 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4110 (WebTest.test_webPathname): same
4111 (WebTest.test_webPathname_port): same
4112 * docs/config.xhtml: mention favicon=
4113 * buildbot/buildbot.png: add a default icon, dorky as it is
4115 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4117 * buildbot/master.py:
4118 * buildbot/process/base.py:
4119 * buildbot/process/builder.py:
4120 * buildbot/process/interlock.py:
4121 * buildbot/status/builder.py:
4122 * buildbot/status/html.py:
4123 * buildbot/status/mail.py:
4124 * buildbot/status/words.py:
4125 new documentation while digging through the code
4127 2005-04-17 Brian Warner <warner@lothar.com>
4129 * general: try to fix file modes on all .py files: a+r, a-x,
4130 but let buildbot/clients/*.py be +x since they're tools
4132 * docs/epyrun (addMod): when an import fails, say why
4134 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4136 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4138 * buildbot/process/base.py:
4139 * buildbot/process/builder.py:
4140 * buildbot/status/builder.py:
4141 new documentation while digging through the code
4143 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4145 * buildbot/changes/changes.py:
4146 * buildbot/changes/p4poller.py:
4147 * buildbot/interfaces.py:
4148 * buildbot/process/base.py:
4149 * buildbot/process/builder.py:
4150 * buildbot/process/step.py:
4151 * buildbot/process/step_twisted.py:
4152 * buildbot/slave/bot.py:
4153 * buildbot/slave/commands.py:
4154 * buildbot/status/builder.py:
4155 fix all docstrings to make epydoc happy. In the process of fixing
4156 some, I also moved pieces of docs, and removed some deprecated
4159 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4161 * buildbot/process/builder.py:
4162 * buildbot/process/interlock.py:
4163 * buildbot/process/process_twisted.py:
4164 * buildbot/process/step.py:
4165 BuildProcess -> Build, as it looks like that's what happened
4166 * buildbot/process/base.py:
4167 * buildbot/process/factory.py:
4170 2005-04-17 Brian Warner <warner@lothar.com>
4172 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4173 update compile command to accomodate the Twisted split.. now
4174 instead of './setup.py build_ext -i', you do './setup.py all
4175 build_ext -i', to run build_ext over all sub-projects.
4176 (FullTwistedBuildFactory): same
4177 (TwistedReactorsBuildFactory): same
4179 * buildbot/status/html.py (TextLog.finished): null out self.req
4180 when we're done, otherwise the reference cycle of TextLog to .req
4181 to .notifications to a Deferred to TextLog.stop keeps them from
4182 being collected, and consumes a huge (610MB on pyramid at last
4183 check) amount of memory.
4185 2005-04-11 Brian Warner <warner@lothar.com>
4187 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4188 normalize the VC-repository location.. makes SVN happier with
4189 certain test environments.
4191 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4192 RemoteShellCommand gets its own .env dictionary, so that code in
4193 start() doesn't mutate the original. I think this should fix the
4194 step_twisted.Trial problem where multiple identical components
4195 kept getting added to PYTHONPATH= over and over again.
4197 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4198 adding epydoc-format docstrings to many classes. Thanks to Thomas
4199 Vander Stichele for the patches.
4200 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4201 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4202 * buildbot/slave/bot.py, commands.py, registry.py: same
4204 2005-04-05 Brian Warner <warner@lothar.com>
4206 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4207 preserve timestamps, helps incremental builds of large trees.
4208 Patch from Rene Rivera.
4210 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4211 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4214 2005-04-03 Brian Warner <warner@lothar.com>
4216 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4217 with one dict, apparently exec has some scoping bugs when used
4218 with both global/local dicts. Thanks to Nathaniel Smith for the
4221 2005-04-02 Brian Warner <warner@lothar.com>
4223 * buildbot/process/step_twisted.py (countFailedTests): the new
4224 trial in Twisted-2.0 emits a slightly different status line than
4225 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4226 mistakenly think the test count is unparseable.
4227 (Trial.start): note that for some reason each build causes another
4228 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4229 be fixed but I'm not sure quite where the problem is.
4231 2005-04-01 Brian Warner <warner@lothar.com>
4233 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4234 deferredResult to avoid hangs/warnings under twisted-2.0
4235 (RunMixin.tearDown): same
4236 (RunMixin.shutdownSlave): same
4237 (Disconnect.testIdle1): same
4238 (Disconnect.testBuild2): same: wait one second after the build
4239 finishes for test to really be done.. this should be cleaned up to
4240 avoid wasting that second. Builder.detach uses a callLater(0),
4241 either that should be done in-line (something else needed that
4242 behavior), or it should return a Deferred that fires when the
4243 builder is really offline.
4244 (Disconnect.testBuild3): same
4245 (Disconnect.testDisappear): same
4247 * buildbot/test/test_web.py: rearrange server-setup and teardown
4248 code to remove unclean-reactor warnings from twisted-2.0
4250 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4251 so the tests don't hang under twisted-2.0
4253 2005-03-31 Brian Warner <warner@lothar.com>
4255 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4256 caused a warning each time the master changed our set of builders
4258 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4259 w32, don't unlink the file unless it already exists. Thanks to
4260 Baptiste Lepilleur for the catch.
4261 (BuilderStatus.saveYourself): same
4263 2005-02-01 Brian Warner <warner@lothar.com>
4265 * buildbot/status/html.py (TextLog.getChild): use a /text child
4266 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4267 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4268 logfile as text/plain (no markup, no headers). This replaces the
4269 previous scheme (which used an ?text=1 argument), and gets us back
4270 to a relative link (which works better when the buildbot lives
4271 behind another web server, such as Apache configured as a reverse
4272 proxy). Thanks to Gerald Combs for spotting the problem.
4274 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4277 2004-12-13 Brian Warner <warner@lothar.com>
4279 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4281 * debian/changelog: update for 0.6.2
4282 * NEWS: finalize for 0.6.2
4284 2004-12-11 Brian Warner <warner@lothar.com>
4286 * NEWS: bring it up to date
4288 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4289 detection code. Require some sign of life from the buildmaster
4290 every BotFactory.keepaliveInterval seconds. Provoke this
4291 indication at BotFactory.keepaliveTimeout seconds before the
4292 deadline by sending a keepalive request. We don't actually care if
4293 that request is answered in a timely fashion, what we care about
4294 is that .activity() is called before the deadline. .activity() is
4295 triggered by any PB message from the master (including an ack to
4296 one of the slave's status-update messages). With this new scheme,
4297 large status messages over slow pipes are OK, as long as any given
4298 message can be sent (and thus acked) within .keepaliveTimeout
4299 seconds (which defaults to 30).
4300 (SlaveBuilder.remote_startCommand): record activity
4301 (SlaveBuilder.ackUpdate): same
4302 (SlaveBuilder.ackComplete): same
4303 (BotFactory.gotPerspective): same
4304 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4306 2004-12-09 Brian Warner <warner@lothar.com>
4308 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4311 * buildbot/process/step_twisted.py (Trial._commandComplete):
4312 update self.cmd when we start the 'cat test.log' transfer. Without
4313 this, we cannot interrupt the correct RemoteCommand when we lose
4316 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4317 trying to tell the slave to stop the command if we're already
4318 inactive, or if we no longer have a .remote
4320 * buildbot/process/builder.py (Builder._detached): don't let an
4321 exception in currentBuild.stopBuild() prevent the builder from
4322 being marked offline
4324 2004-12-07 Brian Warner <warner@lothar.com>
4326 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4327 KeyError that happens when you ask for a non-existent Builder, and
4328 translate it into a UsageError.
4330 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4331 losing the slave in the middle of a remote step is handled too
4333 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4334 be a Failure, so be sure to stringify it before using it as the
4335 contents of the 'interrupt' logfile
4336 (RemoteCommand.interrupt): use stringified 'why' in
4337 remote_interruptCommand too, just in case
4339 2004-12-06 Brian Warner <warner@lothar.com>
4341 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4342 instead of 'tla update', which is more efficient in case we've
4343 missed a couple of patches since the last update.
4345 * debian/changelog: update for previous (0.6.1) release. Obviously
4346 this needs to be handled better.
4348 2004-12-05 Brian Warner <warner@lothar.com>
4350 * NEWS: update for stuff since last release
4352 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4353 match the maybeDeferred change in Dispatcher.requestAvatar
4354 * buildbot/changes/pb.py (ChangePerspective.attached): same
4355 * buildbot/status/client.py (StatusClientPerspective.attached): same
4356 * buildbot/process/builder.py (Builder._attached3): same
4357 * buildbot/pbutil.py (NewCredPerspective.attached): same
4359 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4360 the date to the top-most box, if it is not the same as today's
4363 * docs/slave.xhtml: provide a buildslave setup checklist
4365 * docs/source.xhtml (Arch): correct terminology
4367 2004-12-04 Brian Warner <warner@lothar.com>
4369 * buildbot/test/test_slavecommand.py: use sys.executable instead
4370 of hard-coding 'python' for child commands, might help portability
4372 * docs/examples/twisted_master.cfg: update to current usage
4374 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4375 'stop build' command to the IRC bot
4377 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4378 message that broke PBChangeSource
4380 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4381 (SlaveBuilder): make some attributes class-level, remove the old
4382 "update queue" which existed to support resuming a build after the
4383 master connection was lost. Try to reimplement that feature later.
4384 (SlaveBuilder.stopCommand): clear self.command when the
4385 SlaveCommand finishes, so that we don't try to kill a leftover one
4387 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4390 * buildbot/slave/commands.py (SourceBase): set self.command for
4391 all VC commands, so they can be interrupted.
4393 2004-12-03 Brian Warner <warner@lothar.com>
4395 * buildbot/master.py: clean up slave-handling code, to handle
4396 slave-disconnect and multiple-connect better
4397 (BotPerspective): make these long-lasting, exactly one per bot
4398 listed in the config file.
4399 (BotPerspective.attached): if a slave connects while an existing
4400 one appears to still be connected, disconnect the old one first.
4401 (BotPerspective.disconnect): new method to forcibly disconnect a
4402 buildslave. Use some hacks to empty the transmit buffer quickly to
4403 avoid the long (20-min?) TCP timeout that could occur if the old
4404 slave has dropped off the net.
4405 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4406 own their own SlaveStatus objects. Remove .attached/.detached, add
4407 .addSlave/.removeSlave, treat slaves like Builders (config file
4408 parsing sends deltas to the BotMaster). Inform the slave
4409 instances, i.e. the BotPerspective, about addBuilder and
4411 (BotMaster.getPerspective): turns into a single dict lookup
4412 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4413 which gives BotPerspective.attached a chance to disconnect the old
4415 (BuildMaster.loadConfig): add code (disabled) to validate that all
4416 builders use known slaves (listed in c['bots']). The check won't
4417 work with tuple-specified builders, which are deprecated but not
4418 yet invalid, so the check is disabled for now.
4419 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4420 routine, do the add/changed/removed dance with them like we do
4422 (BuildMaster.loadConfig_Sources): move source-config into a
4423 separate routine too
4425 * buildbot/status/builder.py (Status.getSlave): get the
4426 SlaveStatus object from the BotPerspective, not the BotMaster.
4428 * buildbot/test/test_run.py: bunch of new tests for losing the
4429 buildslave at various points in the build, handling a slave that
4430 connects multiple times, and making sure we can interrupt a
4433 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4434 something other than 'Bot' for the Bot object, to make certain
4435 test cases easier to write.
4436 (BuildSlave.waitUntilDisconnected): utility method for testing
4438 2004-11-30 Brian Warner <warner@lothar.com>
4440 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4442 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4443 argument, return a Deferred that always fires with True or False.
4444 I don't use an errback to indicate 'ping failed' so that callers
4445 are free to ignore the deferred without causing spurious errors in
4447 * buildbot/process/builder.py (BuilderControl.ping): implement it
4449 * buildbot/test/test_run.py (Status.testDisappear): test ping
4450 (Status.disappearSlave): fix it
4452 2004-11-30 Brian Warner <warner@lothar.com>
4454 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4455 (IBuilderControl): add .getBuild(num), only works for the current
4456 build, of course, although it might be interesting to offer
4457 something for builds in the .waiting or .interlocked state.
4459 * buildbot/process/base.py (Build): have .stopBuild just do the
4460 interrupt, then let the build die by itself.
4461 (BuildControl): add .stopBuild, and add a point-event named
4462 'interrupt' just after the build so status viewers can tell that
4464 (BuilderControl): add .getBuild
4466 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4467 stops when you kill it, good for testing
4468 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4469 contains the 'reason' text.
4471 * buildbot/status/html.py: Add Stop Build button, if the build can
4472 still be stopped. Send a Redirect (to the top page) one second
4473 later, hopefully long enough for the interrupt to have an effect.
4474 Move make_row() up to top-level to share it between Stop Build and
4477 * buildbot/slave/commands.py: only kill the child process once
4479 * buildbot/test/test_run.py: add testInterrupt
4481 2004-11-29 Brian Warner <warner@lothar.com>
4483 * buildbot/process/base.py: Refactor command interruption. The
4484 Build is now responsible for noticing that the slave has gone
4485 away: Build.lostRemote() interrupts the current step and makes
4486 sure that no further ones will be started.
4488 * buildbot/process/builder.py: When the initial remote_startBuild
4489 message fails, log it: this usually indicates that the slave has
4490 gone away, but we don't really start paying attention until they
4491 fail to respond to the first step's command.
4493 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4494 slave disconnect. Now sports a new interrupt() method. Error
4495 handling was simplified a lot by chaining deferreds, so
4496 remoteFailed/remoteComplete were merged into a single
4497 remoteComplete method (which can now get a Failure object).
4498 Likewise failed/finished were merged into just _finished.
4499 (BuildStep): Add interrupt(why) method, and if why is a
4500 ConnectionLost Failure then the step is failed with some useful
4503 * buildbot/slave/bot.py: stop the current command when the remote
4504 Step reference is lost, and when the slave is shut down.
4505 (Bot): make it a MultiService, so it can have children. Use
4506 stopService to tell when the slave is shutting down.
4507 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4508 remote_interruptCommand (which asks the current SlaveCommand to
4509 stop but allows it to keep emitting status messages), and
4510 stopCommand (which tells it to shut up and die).
4512 * buildbot/slave/commands.py: make commands interruptible
4513 (ShellCommand.kill): factor out os.kill logic
4514 (Command): factor out setup()
4515 (Command.sendStatus): don't send status if .running is false, this
4516 happens when the command has been halted.
4517 (Command.interrupt): new method, used to tell the command to die
4518 (SlaveShellCommand): implement .interrupt
4519 (DummyCommand): implement .interrupt
4520 (SourceBase, etc): factor out setup(), don't continue substeps if
4523 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4524 so they can be called after finishing
4526 * buildbot/test/test_run.py: new tests for disconnect behavior,
4527 refactor slave-shutdown routines, add different kinds of
4530 2004-11-27 Brian Warner <warner@lothar.com>
4532 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4533 method to express ETA time like "2m45s" instead of "165 seconds"
4535 2004-11-24 Brian Warner <warner@lothar.com>
4537 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4538 archive after the test completes, to avoid cluttering the user's
4539 'tla archives' listing with a bogus entry. Arch doesn't happen to
4540 provide any way to override the use of ~/.arch-params/, so there
4541 isn't a convenient way to avoid touching the setup of the user who
4543 (VC_HTTP.testArchHTTP): same
4545 2004-11-23 Brian Warner <warner@lothar.com>
4547 * buildbot/status/html.py (TextLog): split render() up into
4548 render_HEAD and render_GET. Use a Producer when sending log
4549 chunks, to reduce memory requirements and avoid sending huge
4550 non-Banana-able strings over web.distrib connections. Requires
4551 peeking under the covers of IStatusLog.
4552 (TextLog.resumeProducing): fix the "as text" link, handle client
4553 disconnects that occur while we're still sending old chunks.
4555 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4556 use defer.succeed, not the non-existent defer.success
4557 (LogFile.waitUntilFinished): same
4558 (LogFile.subscribe): don't add watchers to a finished logfile
4560 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4563 2004-11-23 Brian Warner <warner@lothar.com>
4565 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4567 2004-11-23 Brian Warner <warner@lothar.com>
4569 * NEWS: update for the 0.6.1 release
4570 * MANIFEST.in: add new files
4572 * README (INSTALLATION): explain how to enable the extra VC tests
4574 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4575 level to, so old pickled builds can be displayed ok
4577 2004-11-22 Brian Warner <warner@lothar.com>
4579 * NEWS: summarize updates since last release
4581 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4582 Yoz Grahame. Closes SF#1050138.
4584 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4587 * buildbot/process/step_twisted.py (Trial): update docs a bit
4589 * docs/factories.xhtml: fix Trial factory docs to match reality.
4592 * buildbot/process/factory.py (Trial.__init__): add args for
4593 randomly= and recurse=, making them available to instantiators
4594 instead of only to subclassers. Closes: SF#1049759.
4596 2004-11-15 Brian Warner <warner@lothar.com>
4598 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4599 try to teach the Quick factory to use multiple versions of python
4601 2004-11-12 Brian Warner <warner@lothar.com>
4603 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4604 safer w32-compatible approach, and only use it on windows
4605 (BuildStatus.saveYourself): same
4607 2004-11-11 Brian Warner <warner@lothar.com>
4609 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4610 it: one string merge per chunk. There are now separate .entries
4611 and .runEntries lists: when enumerating over all chunks, make sure
4613 * buildbot/test/test_status.py (Log): more tests
4615 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4616 chunks together, up to 10kb per chunk. This ought to cut down on
4617 the CPU-burning overhead of large log files. Thanks to Alexander
4618 Staubo for spotting the problem.
4619 * buildbot/test/test_status.py (Log): tests for same
4621 2004-11-10 Brian Warner <warner@lothar.com>
4623 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4624 header to outbound mail
4625 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4627 2004-11-08 Brian Warner <warner@lothar.com>
4629 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4630 can't do os.rename() onto an existing file, so catch the exception
4631 and unlink the target file first. This introduces a slight window
4632 where the existing file could be lost, but the main failure case
4633 (disk full) should still be handled safely.
4634 (BuildStatus.saveYourself): same
4636 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4637 separator character instead of os.sep, because the filenames being
4638 split here are coming from the VC system, which can have a
4639 different pathname convention than the local host. This should
4640 help a buildmaster running on windows that uses a CVS repository
4641 which runs under unix.
4642 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4644 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4645 when there are no test failures to be parsed
4647 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4648 instead of the unix-specific os.system("cp"), thanks to Elliot
4649 Murphy for this and the other buildbot-vs-windows catches.
4650 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4652 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4653 echo the command as it is run
4655 * setup.py: install sample.mk too, not just sample.cfg
4656 (scripts): install contrib/windows/buildbot.bat on windows
4658 2004-11-07 Brian Warner <warner@lothar.com>
4660 * buildbot/process/builder.py (Builder._detached): clear the
4661 self.currentBuild reference, otherwise the next build will be
4662 skipped because we think the Builder is already in use.
4664 * docs/examples/twisted_master.cfg: update to match current usage
4665 on the Twisted buildbot
4667 2004-10-29 Brian Warner <warner@lothar.com>
4669 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4671 2004-10-28 Brian Warner <warner@lothar.com>
4673 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4674 have separate doVCUpdate/doVCFull methods. Catch an update failure
4675 and respond by clobbering the source directory and re-trying. This
4676 will handle local changes (like replacing a file with a directory)
4677 that will cause CVS and SVN updates to fail.
4678 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4680 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4683 2004-10-19 Brian Warner <warner@lothar.com>
4685 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4687 * buildbot/status/html.py (StatusResourceTestResults): display any
4688 TestResults that the Build might have
4689 (StatusResourceTestResult): and the logs for each TestResult
4690 (StatusResourceBuild): add link from the per-build page
4692 2004-10-15 Brian Warner <warner@lothar.com>
4694 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4695 the 'problems' portion of stdout, add TestResults to our build
4696 * buildbot/test/test_twisted.py (Parse.testParse): test it
4698 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4699 to retrieve a dict of accumulated test results
4700 (ITestResult): define what a single test result can do
4701 * buildbot/status/builder.py (TestResult): implement ITestResult
4702 (BuildStatus.getTestResults): retrieve dict of TestResults
4703 (BuildStatus.addTestResult): add TestResults
4704 * buildbot/test/test_status.py (Results.testAddResults): test it
4706 2004-10-14 Brian Warner <warner@lothar.com>
4708 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4709 instead of os.system("rm -rf") for win32 portability
4711 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4712 SignalMixin instead of starting/stopping the reactor, which is
4713 likely to cause problems with other tests
4715 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4716 self.copyComplete() call. Yoz Grahame makes the catch.
4718 * contrib/windows/buildbot.bat: helper script to deal with path
4719 issues. Thanks to Yoz Grahame.
4721 * buildbot/master.py (BuildMaster.startService): don't register a
4722 SIGHUP handler if the signal module has no SIGHUP attribute.
4723 Apparently win32 does this.
4725 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4727 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4728 test if the reactor can't offer UNIX sockets
4730 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4731 error introduced in the last commit. We really need that
4734 2004-10-12 Brian Warner <warner@lothar.com>
4736 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4737 when describing a maildir source. Thanks to Stephen Davis.
4739 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4742 * buildbot/scripts/runner.py (createMaster): install Makefile too
4743 (start): add --no_save to 'start' command
4744 * buildbot/scripts/sample.mk: simple convenience Makefile with
4745 start/stop/reload targets
4747 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4750 2004-09-30 Brian Warner <warner@lothar.com>
4752 * setup.py: Releasing buildbot-0.6.0
4754 2004-09-30 Brian Warner <warner@lothar.com>
4756 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4757 test_trial.py from the source tarball until support is complete.
4759 * NEWS: update for 0.6.0 release
4760 * buildbot/__init__.py (version): same
4763 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4764 'source' command to tell users where to get the Buildbot source
4766 * docs/examples/*.cfg: update to modern standards
4768 * NEWS: update for release
4770 * buildbot/scripts/runner.py (createMaster): remove the
4771 -shutdown.tap stuff now that it isn't necessary
4773 (start): launch buildbot.tap, not buildbot-shutdown.tap
4776 * buildbot/status/mail.py (Domain): shorten class name
4777 (MailNotifier): if lookup= is a string, pass it to Domain()
4778 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4779 (Mail.testBuild2): test the string-to-Domain shortcut
4780 (Mail.testMail): fix test
4783 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4786 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4787 more attributes on load
4788 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4789 to accomodate the whole waterfall page at once, and the thrashing
4790 results in a lot of unnecessary loads
4791 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4792 (BuilderStatus.saveYourself): same
4793 (BuilderStatus.eventGenerator): stop generating on the first missing
4794 build. We assume that saved builds are deleted oldest-first.
4795 (BuildStepStatus.__getstate__): .progress might not exist
4797 * buildbot/changes/changes.py (ChangeMaster): make it
4798 serializable, in $masterdir/changes.pck
4799 (ChangeMaster.stopService): save on shutdown
4800 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4801 * buildbot/test/test_config.py: load Changes before config file
4804 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4805 "Oh my god, you killed the command" header on a separate line
4807 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4808 skip over corrupted build pickles
4809 (BuilderStatus.getFullBuildByNumber): same
4810 (BuilderStatus.eventGenerator): skip over unavailable builds
4811 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4812 do an atomic rename. This prevents a corrupted pickle when some
4813 internal serialization error occurs.
4814 (BuilderStatus.saveYourself): same
4816 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4817 the timeout for shell commands, it got lost somehow
4819 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4820 run out of build steps, return the rest of the builder events
4822 * buildbot/interfaces.py (IBuilderControl.ping): add method
4824 * buildbot/process/builder.py (BuilderControl.ping): move
4825 slave-ping to BuilderControl, and fix the failure case in the
4826 process (Event.finish() is the verb, Event.finished is the noun).
4828 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4829 through the BuilderControl instead of the BuilderStatus
4830 (EventBox): add adapter for builder.Event, allowing builder events to
4831 be displayed in the waterfall display
4833 * buildbot/master.py (BotMaster.stopService): add a 'master
4834 shutdown' event to the builder's log
4835 (BuildMaster.startService): and a 'master started' on startup
4837 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4838 builder events into the BuildStep event stream
4839 (Status.builderAdded): add a 'builder created' event
4842 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4843 command to announce the completion of a running build
4844 (IrcStatusBot.command_FORCE): announce when the build finishes
4846 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4847 don't evict unfinished builds from the cache: they must stay in
4848 the full-cache until their logfiles have stopped changing. Make
4849 sure the eviction loop terminates if an unfinished build was hit.
4850 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4851 This lets exceptions be dumped in an email status message. Really
4852 we need LogFiles which contain both text and HTML, instead of two
4854 (BuildStatus.__getstate__): handle self.finished=False
4855 (Status.builderAdded): if the pickle is corrupted, abandon the
4856 history and create a new BuilderStatus object.
4858 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4859 self.progress attribute, helped one test which doesn't fully set
4860 up the Build object.
4862 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4863 IStatusLog methods into an Interface that is implemented by "stub"
4864 logs, for which all the actual text chunks are on disk (in the
4865 pickled Build instance). To show the log contents, you must first
4866 adapt the stub log to a full IStatusLog object.
4868 * buildbot/status/builder.py (LogFileStub): create separate stub
4869 log objects, which can be upgraded to a real one if necessary.
4870 (LogFile): make them persistable, and let them stubify themselves
4872 (BuildStepStatus): same
4874 (BuildStatus.saveYourself): save the whole build out to disk
4875 (BuilderStatus): make it persistable
4876 (BuilderStatus.saveYourself): save the builder to disk
4877 (BuilderStatus.addFullBuildToCache): implement two caches which
4878 hold Build objects: a small one which holds full Builds, and a
4879 larger one which holds "stubbed" Builds (ones with their LogFiles
4880 turned into LogFileStubs). This reduces memory usage by the
4881 buildmaster by not keeping more than a few (default is 2) whole
4882 build logs in RAM all the time.
4883 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4885 (BuilderStatus.eventGenerator): rewrite since .builds went away
4886 (BuilderStatus.buildStarted): remove the .builds array. Add the
4887 build to the "full" cache when it starts.
4888 (BuilderStatus._buildFinished): save the build to disk when it
4890 (Status): give it a basedir (same as the BuildMaster's basedir)
4891 where the builder pickles can be saved
4892 (Status.builderAdded): create the BuilderStatus ourselves, by
4893 loading a pickle from disk (or creating a new instance if there
4894 was none on disk). Return the BuilderStatus so the master can glue
4895 it into the new Builder object.
4897 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4898 all BuilderStatuses to save themselves out to disk. This is in
4899 lieu of saving anything important in the main Application pickle
4900 (the -shutdown.tap file).
4901 (BuildMaster.__init__): give Status() a basedir for its files
4902 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4903 to get the BuilderStatus, then give it to the Builder (instead of
4904 doing it the other way around). It's ok if the status announces
4905 the new Builder before it's really ready, as the outside world can
4906 only see the BuilderStatus object anyway (and it is ready before
4907 builderAdded returns). Use the builder's "builddir" (which
4908 normally specifies where the slave will run the builder) as the
4909 master's basedir (for saving serialized builds).
4911 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4912 coerce the logfile to IStatusLog before trying to get the text
4913 chunks out of it. This will pull the full (non-stubified) Build in
4914 from disk if necessary.
4915 (TextLog): fix the adapter registration
4917 * buildbot/test/test_control.py (Force.setUp): create the basedir
4918 * buildbot/test/test_web.py: same
4919 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4920 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4921 * buildbot/test/test_run.py (Run.testMaster): same
4922 (Status.setUp): same
4924 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4926 * buildbot/status/html.py (Waterfall.__init__): store actual
4927 allowForce flag passed in rather than using True for everyone;
4928 make sure setting it to False doesn't cause a NameError
4930 (StatusResourceBuilder.__init__) add the builder name to the page
4932 (StatusResourceBuilder.body) move HTML generation for a name/value
4933 row into a helper method (StatusResourceBuilder.make_row); only
4934 generate the "Force Build" form if allowForce was True and the
4935 slave is connected. Use class attributes in the generated HTML to
4936 spread a little CSS-joy.
4938 2004-09-28 Brian Warner <warner@lothar.com>
4940 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4941 warning-scanner to not ignore things like
4942 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4944 * buildbot/status/html.py (StatusResource.control): add some
4945 class-level values for .control in an attempt to make upgrading
4948 * buildbot/util.py (ComparableMixin): survive missing attributes,
4949 such as when a class is modified and we're comparing old instances
4952 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4953 failure handling, remove a redundant try/except block. Don't
4954 return the full traceback to the IRC channel.
4955 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4956 error messages. Get ETA properly.
4958 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4959 the reason, since (at least) IRC message will have <> in them.
4960 (StatusResourceBuilder.__init__): take an IBuilderControl
4961 (StatusResourceBuilder.force): use the IBuilderControl we get in
4962 the constructor instead of trying to make our own. Catch the
4963 new exceptions and ignore them for now (until we make an
4964 intermediate web page where we could show the error message)
4965 (StatusResource): create with an IControl, use it to give an
4966 IBuilderControl to all children
4967 (Waterfall): take an allowForce= option, pass an IControl object
4968 to StatusResource if it is True
4970 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4972 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4973 catch new exceptions and return string forms
4975 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4976 * buildbot/process/builder.py (Builder.forceBuild): raise them
4977 * buildbot/test/test_control.py (Force.testNoSlave): new test
4978 (Force.testBuilderInUse): same
4981 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4983 * buildbot/test/test_run.py: use IControl
4984 * buildbot/test/test_vc.py: same
4986 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4987 to use IControl. Still offline.
4988 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4990 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4991 who=None so periodic builds don't send out status mail
4992 (Builder.forceBuild): include reason in the log message
4993 (BuilderControl.forceBuild): rename 'name' to 'who'
4995 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4996 'who' parameter, but make it None by default so builds forced by
4997 slave admins don't cause status mail to be sent to anybody
4998 (BotMaster.forceBuild): same. this method is deprecated.
4999 (DebugPerspective.perspective_forceBuild): same, use IControl.
5000 (DebugPerspective.perspective_fakeChange): use IControl..
5001 (Dispatcher.requestAvatar): .. so don't set .changemaster
5003 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5004 parameter to avoid confusion with the name of the builder
5007 * buildbot/status/mail.py: refine comment about needing 2.3
5009 * buildbot/status/html.py: move all imports to the top
5011 * buildbot/test/test_control.py: test new interfaces
5012 * buildbot/test/test_run.py (Status): handle new interfaces
5013 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5015 * buildbot/process/base.py (BuildControl): implement IBuildControl
5016 and its lonely getStatus() method
5018 * buildbot/process/builder.py (BuilderControl): implement
5019 IBuilderControl, obtained by adapting the Builder instance
5020 (Builder.startBuild): return a BuilderControl instead of a
5021 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5022 accomplish the same thing.
5024 * buildbot/master.py: move all import statements to the top
5025 (Control): implement IControl, obtained by adapting the
5026 BuildMaster instance.
5028 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5029 IBuildControl. These are used to force builds. Eventually they
5030 will provide ways to reconfigure the Builders, pause or abandon a
5031 Build, and perhaps control the BuildMaster itself.
5033 2004-09-26 Brian Warner <warner@lothar.com>
5035 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5036 ends up comparing us against something without a .__class__
5038 2004-09-24 Brian Warner <warner@lothar.com>
5040 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5043 * Makefile: add 'deb-snapshot' target, to create a timestamped
5046 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5048 2004-09-23 Brian Warner <warner@lothar.com>
5050 * buildbot/__init__.py (version): move version string here
5051 * setup.py: get version string from buildbot.version
5052 * buildbot/status/html.py (WaterfallStatusResource.body): add
5053 buildbot version to the page footer
5054 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5057 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5058 slaves, let the second know where the first one is coming from
5059 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5060 see our exceptions. It would be nice if there were a way to just
5061 send them the exception type and value, not the full traceback.
5064 * buildbot/status/mail.py (MailNotifier): add a new argument
5065 sendToInterestedUsers=, which can be set to False to disable the
5066 usual send-to-blamelist behavior.
5067 (top): handle python-2.2 which has no email.MIMEMultipart
5068 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5069 (MailNotifier.disownServiceParent): unsubscribe on removal
5071 * buildbot/test/test_status.py (Mail.testBuild2): test it
5074 * buildbot/status/progress.py (Expectations.wavg): tolerate
5075 current=None, which happens when steps start failing badly
5076 * buildbot/test/test_status.py (Progress.testWavg): test for it
5078 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5079 doesn't understand args['revision'], emit a warning instead of
5080 bailing completely. Updating to -rHEAD is probably close enough.
5082 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5084 * buildbot/test/test_status.py: at least import bb.status.client
5085 even if we don't have any test coverage for it yet
5087 * contrib/svn_buildbot.py: don't require python2.3
5088 (main): wait, do require it (for sets.py), but explain how to
5089 make it work under python2.2
5091 2004-09-23 Brian Warner <warner@lothar.com>
5093 * contrib/svn_buildbot.py: include the revision number in the Change
5095 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5096 using util.now() because FreshCVS is a realtime service
5098 * buildbot/status/event.py: delete dead code
5099 * buildbot/process/step.py: don't import dead Event class
5100 * buildbot/process/step_twisted.py: same
5101 * buildbot/status/builder.py: same
5102 * buildbot/status/client.py: same
5104 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5106 * buildbot/changes/changes.py (Change): set .when from an __init__
5107 argument (which defaults to now()), rather than having
5108 ChangeMaster.addChange set it later.
5109 (ChangeMaster.addChange): same
5111 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5112 (parseSyncmail): same. Just use util.now() for now.
5113 (parseBonsaiMail): parse the timestamp field for when=
5115 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5116 instead of setting .when after the fact
5120 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5121 results when the target project uses retrial. Still under
5123 * buildbot/test/test_trial.py: same
5125 2004-09-21 Brian Warner <warner@lothar.com>
5127 * buildbot/status/mail.py (MailNotifier.__init__): include
5128 success/warnings/failure in the Subject line
5129 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5130 use step.logname for the addLogs=True attachment filenames
5131 * buildbot/test/test_status.py (Mail): test Subject lines
5132 (Mail.testLogs): test attachment filenames
5134 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5135 accept a 'who' argument from the debug tool
5136 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5137 * contrib/debug.glade: add text box to set 'who'
5139 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5140 .getBuilderName with .getBuilder().getName(), more flexible
5141 (IStatusLog.getName): logs have short names, but you can prefix
5142 them with log.getStep().getName() to make them more useful
5143 * buildbot/status/builder.py: same
5144 * buildbot/status/client.py: same
5145 * buildbot/status/html.py: same
5146 * buildbot/test/test_run.py (Status.testSlave): same
5147 * buildbot/process/step.py: tweak logfile names
5149 * buildbot/status/mail.py (MailNotifier): add lookup, change
5150 argument to extraRecipients. The notifier is now aimed at sending
5151 mail to the people involved in a particular build, with additional
5152 constant recipients as a secondary function.
5154 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5155 including slow-lookup and failing-lookup. Make sure the blamelist
5156 members are included.
5158 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5159 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5160 (IBuildStatus.getInterestedUsers): new method
5161 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5162 * buildbot/status/client.py (remote_getResponsibleUsers): same
5163 * buildbot/status/html.py (StatusResourceBuild.body): same
5164 * buildbot/test/test_run.py (Status.testSlave): same
5166 2004-09-20 Brian Warner <warner@lothar.com>
5168 * docs/users.xhtml: update concepts
5170 * Makefile: add a convenience makefile, for things like 'make
5171 test'. It is not included in the source tarball.
5173 2004-09-16 Brian Warner <warner@lothar.com>
5175 * NEWS: mention /usr/bin/buildbot, debian/*
5177 * debian/*: add preliminary debian packaging. Many thanks to
5178 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5179 it considerably since it left their hands, I am responsible for
5180 all breakage that's resulted.
5182 * bin/buildbot: create a top-level 'buildbot' command, to be
5183 installed in /usr/bin/buildbot . For now it's just a simple
5184 frontend to mktap/twistd/kill, but eventually it will be the entry
5185 point to the 'try' command and also a status client. It is also
5186 intended to support the upcoming debian-packaging init.d scripts.
5187 * buildbot/scripts/runner.py: the real work is done here
5188 * buildbot/scripts/__init__.py: need this too
5189 * buildbot/scripts/sample.cfg: this is installed in new
5190 buildmaster directories
5191 * setup.py: install new stuff
5193 2004-09-15 Brian Warner <warner@lothar.com>
5195 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5196 'file:' schema (the version shipped with OS-X was built without the
5198 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5199 updates the log-timestamp, to make sure it isn't still running after
5202 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5203 values to the config file.
5204 * docs/examples/hello.cfg: add examples
5205 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5206 * buildbot/status/builder.py (Status.getProjectURL): implement them
5207 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5208 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5209 * buildbot/status/html.py (WaterfallStatusResource): display them
5212 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5213 certain error cases don't suffer a secondary exception.
5214 (top): Skip tests if the corresponding VC tool is not installed.
5216 * buildbot/process/factory.py (Trial): introduce separate
5217 'buildpython' and 'trialpython' lists, since trialpython=[] is
5218 what you want to invoke /usr/bin/python, whereas ./setup.py is
5219 less likely to be executable. Add env= parameter to pass options
5220 to test cases (which is how I usually write tests, I don't know if
5221 anyone else does it this way).
5223 * buildbot/process/step_twisted.py (Trial): handle python=None.
5224 Require 'testpath' be a string, not a list. Fix tests= typo.
5225 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5227 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5228 way to deal with the possibility of removing the disconnect notify
5230 (CVS): add a 'login' parameter to give a password to 'cvs login',
5231 commonly used with pserver methods (where pw="" or pw="guest")
5233 * buildbot/slave/commands.py (SourceBase): move common args
5234 extraction and setup() to __init__, so everything is ready by the
5235 time setup() is called
5236 (CVS.start): call 'cvs login' if a password was supplied
5237 (ShellCommand): special-case PYTHONPATH: prepend the master's
5238 value to any existing slave-local value.
5240 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5241 don't have a remote, mark the builder as Offline. This whole
5242 function should probably go away and be replaced by individual
5244 (Builder.buildFinished): return the results to the build-finished
5245 deferred callback, helps with testing
5247 2004-09-14 Brian Warner <warner@lothar.com>
5249 * buildbot/test/test_vc.py: put all the repositories needed to run
5250 the complete tests into a single small (1.3MB) tarball, so I can
5251 make that tarball available on the buildbot web site. Test HTTP
5252 access (for Arch and Darcs) by spawning a temporary web server
5253 while the test runs.
5255 * docs/users.xhtml: new document, describe Buildbot's limited
5256 understanding of different human users
5258 * buildbot/test/test_vc.py: rearrange test cases a bit
5260 * buildbot/process/step_twisted.py (Trial): handle testpath=
5261 * buildbot/process/factory.py (Trial): update to use step.Trial
5263 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5265 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5266 the overall build text (which gives you 'failed 2 tests' rather
5268 (BuildStepStatus.text2): default to [], not None
5270 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5273 2004-09-12 Brian Warner <warner@lothar.com>
5275 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5276 log the whole exception if it's just an AttributeError (old slave)
5278 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5279 so (e.g.) sub-commands can be run in the right directory.
5280 (ShellCommand.start): accept an optional errorMessage= argument
5281 to make life easier for SVN.start
5282 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5284 (ShellCommand.start): move ['dir'] compatibility hack..
5285 (RemoteShellCommand.start): .. to here so everyone can use it
5287 * buildbot/process/step_twisted.py (Trial): use .workdir
5289 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5290 text displayed when debuild fails completely
5291 (Trial): snarf _trial_temp/test.log from the slave and display it
5293 2004-09-11 Brian Warner <warner@lothar.com>
5295 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5297 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5298 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5300 * buildbot/process/step.py (ShellCommand): call .createSummary
5301 before .evaluateCommand instead of the other way around. This
5302 makes it slightly easier to count warnings and then use that to
5303 set results=WARNINGS
5304 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5306 * buildbot/process/base.py (Build.buildFinished): update status
5307 before doing progress. It's embarrassing for the build to be stuck
5308 in the "building" state when an exceptions occurs elsewhere..
5310 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5311 python2.2 doesn't have 'sum'
5313 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5314 to prevent clients from accidentally sorting it
5316 * buildbot/master.py (Manhole): add username/password
5317 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5318 c['manholePort'], deprecate old usage
5319 * docs/config.xhtml: document c['manhole']
5320 * docs/examples/hello.cfg: show example of using a Manhole
5323 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5324 pretend the slave is up to date
5326 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5327 the module, overlaps with 'log', the local variable
5329 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5331 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5332 new method to let Steps find out the version of their
5333 corresponding SlaveCommand.
5334 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5335 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5336 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5338 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5339 (Arch.startVC): same
5340 (P4Sync.startVC): same
5342 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5343 Deferred so we can catch errors in remote_startCommand
5344 (RemoteShellCommand.start): same
5346 * docs/examples/twisted_master.cfg: update sample config file
5348 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5349 after connectionMade() is called, not before. Close stdin at that
5352 * buildbot/process/process_twisted.py: update to use Trial, clean
5353 up argument passing (move to argv arrays instead of string
5356 * buildbot/process/step_twisted.py (Trial): new step to replace
5357 RunUnitTests, usable by any trial-using project (not just
5358 Twisted). Arguments have changed, see the docstring for details.
5360 * buildbot/process/base.py (Build.startBuild): this now returns a
5361 Deferred. Exceptions that occur during setupBuild are now
5362 caught better and lead to fewer build_status weirdnesses, like
5363 finishing a build that was never started.
5364 (Build.buildFinished): fire the Deferred instead of calling
5365 builder.buildFinished directly. The callback argument is this
5366 Build, everything else can be extracted from it, including the
5367 new build.results attribute.
5368 * buildbot/process/builder.py (Builder.startBuild): same
5369 (Builder.buildFinished): same, extract results from build
5371 * buildbot/process/step.py (ShellCommands): remove dead code
5373 2004-09-08 Brian Warner <warner@lothar.com>
5375 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5376 doesn't try to use the leftover patched workdir
5377 (SourceStamp): test source-stamp computation for CVS and SVN
5379 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5380 patched workdir ('touch .buildbot-patched') so we don't try to
5382 (SourceBase.start): add ['revision'] for all Source steps
5383 (CVS): change args: use ['branch'] for -r, remove ['files']
5384 (CVS.buildVC): fix revision/branch stuff
5385 (SVN): add revision stuff
5387 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5388 kwargs (except 'workdir') to avoid silent spelling errors
5389 (ShellCommand.__init__): same
5390 (Source): new base class for CVS/SVN/etc. Factor out everything
5391 common, add revision computation (perform the checkout with a -D
5392 DATE or -r REVISION that gets exactly the sources described by the
5393 last Change), overridable with step.alwaysUseLatest. Add patch
5394 handling (build.getSourceStamp can trigger the use of a base
5395 revision and a patch).
5396 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5397 * docs/steps.xhtml: update docs
5398 * docs/source.xhtml: mention .checkoutDelay
5399 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5401 * buildbot/process/base.py (Build.setSourceStamp): add a
5402 .sourceStamp attribute to each Build. If set, this indicates that
5403 the build should be done with something other than the most
5404 recent source tree. This will be used to implement "try" builds.
5405 (Build.allChanges): new support method
5406 (Build.lastChangeTime): remove, functionality moved to Source steps
5407 (Build.setupBuild): copy the Step args before adding ['workdir'],
5408 to avoid modifying the BuildFactory (and thus triggering spurious
5412 * buildbot/status/html.py: rename s/commits/changes/
5413 (StatusResourceChanges): same
5414 (CommitBox.getBox): same, update URL
5415 (WaterfallStatusResource): same
5416 (StatusResource.getChild): same
5418 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5419 * contrib/debug.glade: add optional 'revision' to the fakeChange
5421 * buildbot/changes/changes.py (html_tmpl): display .revision
5422 (ChangeMaster.addChange): note .revision in log
5423 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5424 accept a ['revision'] attribute
5426 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5428 * buildbot/master.py (BotMaster.getPerspective): update the
5429 .connected flag in SlaveStatus when it connects
5430 (BotMaster.detach): and when it disconnects
5431 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5432 (BuildMaster.loadConfig_Builders): walk old list correctly
5434 * buildbot/test/test_config.py: fix prefix= usage
5436 2004-09-06 Brian Warner <warner@lothar.com>
5440 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5441 poll a P4 depot looking for recent changes. Thanks to Dave
5442 Peticolas for the contribution. Probably needs some testing after
5445 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5446 requires manual client setup for each buildslave. Rather
5447 experimental. Thanks again to Dave Peticolas.
5448 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5450 * buildbot/changes/changes.py (Change): add a .revision attribute,
5451 which will eventually be used to generate source-stamp values.
5453 * buildbot/process/step.py (RemoteCommand.start): use
5454 notifyOnDisconnect to notice when we lose the slave, then treat it
5455 like an exception. This allows LogFiles to be closed and the build
5456 to be wrapped up normally. Be sure to remove the disconnect
5457 notification when the step completes so we don't accumulate a
5458 bazillion such notifications which will fire weeks later (when the
5459 slave finally disconnects normally). Fixes SF#915807, thanks to
5460 spiv (Andrew Bennetts) for the report.
5461 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5462 really isn't Logged- specific
5463 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5464 header, since it's almost always going to be appended to an
5466 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5467 update test to handle use of notifyOnDisconnect
5469 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5470 don't clear .ETA and .currentBuild when going offline, let the
5471 current build clean up after itself
5473 * buildbot/process/builder.py (Builder.detached): wait a moment
5474 before doing things like stopping the current build, because the
5475 current step will probably notice the disconnect and cleanup the
5477 * buildbot/test/test_run.py (Status.tearDown): update test to
5478 handle asynchronous build-detachment
5480 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5482 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5483 hush a debug message
5485 2004-09-05 Brian Warner <warner@lothar.com>
5487 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5488 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5489 kernels do this: the fcntl module has the F_NOTIFY constant, but
5490 the kernel itself doesn't support the operation. Thanks to Olly
5491 Betts for spotting the problem.
5493 * buildbot/process/step.py (Darcs): new source-checkout command
5494 (Arch): new source-checkout command
5495 (todo_P4): fix constructor syntax, still just a placeholder
5496 * buildbot/test/test_vc.py (VC.testDarcs): test it
5497 (VC.testDarcsHTTP): same, via localhost HTTP
5499 (VC.testArchHTTP): same
5500 * NEWS: mention new features
5502 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5503 which tells the step to stash stdout text locally (in .stdout).
5504 Slave-side Commands can use this to make decisions based upon the
5505 output of the the ShellCommand (not just the exit code).
5506 (Darcs): New source-checkout command
5507 (Arch): New source-checkout command, uses .keepStdout in one place
5508 where it needs to discover the archive's default name.
5510 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5511 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5512 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5514 * buildbot/process/step.py (ShellCommand.describe): add an
5515 alternate .descriptionDone attribute which provides descriptive
5516 text when the step is complete. .description can be ["compiling"],
5517 for use while the step is running, then .descriptionDone can be
5518 ["compile"], used alone when the step succeeds or with "failed" when
5519 it does not. Updated other steps to use the new text.
5520 * buildbot/process/step_twisted.py: same
5521 * buildbot/test/test_run.py: update tests to match
5523 2004-08-30 Brian Warner <warner@lothar.com>
5525 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5526 (CVS.__init__): send 'patch' argument to slave
5527 (CVS.start): don't create the LoggedRemoteCommand until start(),
5528 so we can catch a .patch added after __init__
5529 (SVN.__init__): add 'patch' to SVN too
5532 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5533 argument, to let commands push data into the process' stdin pipe.
5534 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5535 is in use, since closing a PTY doesn't really affect the process
5536 in the right way (in particular, I couldn't run /usr/bin/patch
5538 (SourceBase.doPatch): handle 'patch' argument
5540 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5543 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5544 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5546 * buildbot/master.py (BotPerspective.got_commands): get command
5547 versions from slave, give to each builder
5548 * buildbot/process/builder.py (Builder.attached): stash slave
5549 command versions in .remoteCommands
5551 * docs/steps.xhtml: bring docs in-line with reality
5553 * buildbot/process/step.py (CVS.__init__): more brutal
5554 compatibility code removal
5555 (SVN.__init__): same
5557 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5558 (SlaveShellCommand.start): require ['workdir'] argument, remove
5559 the ['dir'] fallback (compatibility will come later)
5560 (SourceBase): update docs
5561 (SourceBase.start): remove ['directory'] fallback
5564 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5565 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5566 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5568 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5569 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5570 code.. I will figure out 0.5.0-compatibility hooks later)
5572 2004-08-30 Brian Warner <warner@lothar.com>
5574 * buildbot/process/process_twisted.py: rewrite in terms of new
5575 BuildFactory base class. It got significantly shorter. Yay
5578 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5579 work with the new "self.build isn't nailed down until we call
5580 step.start()" scheme: specifically, __init__ is called before the
5581 build has decided on which Changes are going in, so we don't scan
5582 build.allFiles() for .xhtml files until start()
5583 (HLint.commandComplete): use getText(), not getStdout()
5584 (RunUnitTests.start): same: don't use .build until start()
5585 (RunUnitTests.describe): oops, don't report (None) when using
5587 (RunUnitTests.commandComplete): use getText()
5588 (RunUnitTests.createSummary): same
5589 (BuildDebs.commandComplete): same
5591 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5592 set args['command'] until start(), since our BuildStep is allowed
5593 to change their mind up until that point
5594 (TreeSize.commandComplete): use getText(), not getStdout()
5596 * docs/examples/twisted_master.cfg: update to current standards
5598 * docs/factories.xhtml: update
5599 * buildbot/process/factory.py: implement all the common factories
5600 described in the docs. The Trial factory doesn't work yet, and
5601 I've probably broken all the process_twisted.py factories in the
5602 process. There are compatibility classes left in for things like
5603 the old BasicBuildFactory, but subclasses of them are unlikely to
5605 * docs/examples/glib_master.cfg: use new BuildFactories
5606 * docs/examples/hello.cfg: same
5608 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5609 explicit 'workdir' args
5611 * buildbot/process/base.py (BuildFactory): move factories to ..
5612 * buildbot/process/factory.py (BuildFactory): .. here
5613 * buildbot/process/process_twisted.py: handle move
5614 * buildbot/test/test_config.py: same
5615 * buildbot/test/test_run.py: same
5616 * buildbot/test/test_steps.py: same
5617 * buildbot/test/test_vc.py: same
5618 * docs/factories.xhtml: same
5620 * NEWS: mention config changes that require updating master.cfg
5622 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5623 argument to all steps that weren't given one already, pointing at
5624 the "build/" directory.
5626 * docs/examples/hello.cfg: remove explicit 'workdir' args
5628 * docs/factories.xhtml: document standard BuildFactory clases,
5629 including a bunch which are have not yet been written
5631 2004-08-29 Brian Warner <warner@lothar.com>
5633 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5634 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5635 buildbot.status.builder so they aren't quite so internal
5636 * buildbot/process/base.py, buildbot/process/builder.py: same
5637 * buildbot/process/maxq.py, buildbot/process/step.py: same
5638 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5639 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5640 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5642 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5643 to handle new getLogs()-returns-list behavior
5644 (StatusResourceBuildStep.getChild): same
5645 (StepBox.getBox): same
5646 (WaterfallStatusResource.phase0): same
5648 * docs/source.xhtml: document how Buildbot uses version-control
5649 systems (output side: how we get source trees)
5650 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5651 systems (input side: how we learn about Changes)
5653 * buildbot/master.py (Manhole): use ComparableMixin
5654 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5655 * buildbot/changes/mail.py (MaildirSource): same
5656 * buildbot/status/client.py (PBListener): same
5657 * buildbot/status/html.py (Waterfall): same
5658 * buildbot/status/words.py (IRC): same
5660 * NEWS: start describing new features
5662 * buildbot/status/mail.py (MailNotifier): finish implementation.
5663 The message body is still a bit sparse.
5664 * buildbot/test/test_status.py (Mail): test it
5666 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5667 and __hash__ methods I wind up adding everywhere. Specifically
5668 intended to support the buildbot config-file update scheme where
5669 we compare, say, the old list of IStatusTargets against the new
5670 one and don't touch something which shows up on both lists.
5671 * buildbot/test/test_util.py (Compare): test case for it
5673 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5674 return a list instead of a dict
5675 (IBuildStepStatus.getLogs): same. The idea is that steps create
5676 logs with vaguely unique names (although their uniqueness is not
5677 guaranteed). Thus a compilation step should create its sole
5678 logfile with the name 'compile', and contribute it to the
5679 BuildStatus. If a step has two logfiles, try to create them with
5680 different names (like 'test.log' and 'test.summary'), and only
5681 contribute the important ones to the overall BuildStatus.
5682 * buildbot/status/builder.py (Event.getLogs): same
5683 (BuildStepStatus): fix default .text and .results
5684 (BuildStepStatus.addLog): switch to list-like .getLogs()
5685 (BuildStepStatus.stepFinished): same
5686 (BuildStatus.text): fix default .text
5687 (BuildStatus.getLogs): temporary hack to return all logs (from all
5688 child BuildStepStatus objects). Needs to be fixed to only report
5689 the significant ones (as contributed by the steps themselves)
5690 * buildbot/test/test_run.py: handle list-like .getLogs()
5691 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5693 2004-08-28 Brian Warner <warner@lothar.com>
5695 * buildbot/process/builder.py (Builder.attached): serialize the
5696 attachment process, so the attach-watcher isn't called until the
5697 slave is really available. Add detached watchers too, which makes
5700 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5702 * buildbot/test/test_swap.py: remove dead code
5704 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5705 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5706 sort of as if the command being run exited with a -1. There may
5707 still be some holes in this scheme.
5708 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5709 -r option appears before the module list
5710 * buildbot/process/step.py (CVS): add 'revision' argument
5712 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5713 when sending updates or stepComplete messages to the master, since
5714 we don't currently care whether they arrive or not. When we revamp
5715 the master/slave protocol to really resume interrupted builds,
5716 this will need revisiting.
5717 (lostRemote): remove spurious print
5719 * buildbot/master.py (BotPerspective.attached): serialize the
5720 new-builder interrogation process, to make testing easier
5721 (BotMaster.waitUntilBuilderDetached): convenience function
5723 * buildbot/status/builder.py (BuilderStatus): prune old builds
5724 (BuildStatus.pruneSteps): .. and steps
5725 (BuildStepStatus.pruneLogs): .. and logs
5726 (BuilderStatus.getBuild): handle missing builds
5727 * buildbot/status/html.py (StatusResourceBuild.body): display build
5728 status in the per-build page
5729 (BuildBox.getBox): color finished builds in the per-build box
5731 2004-08-27 Brian Warner <warner@lothar.com>
5733 * buildbot/status/mail.py (MailNotifier): new notification class,
5736 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5737 variants of a common base class which handles all the mode= logic
5739 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5741 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5743 2004-08-26 Brian Warner <warner@lothar.com>
5745 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5748 * buildbot/test/test_run.py: update to new Logfile interface, new
5749 buildbot.slave modules
5750 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5752 * MANIFEST.in: new sample config file
5753 * docs/examples/hello.cfg: same
5755 * buildbot/process/step_twisted.py: remove dead import
5757 * buildbot/process/step.py (RemoteCommand.run): catch errors
5759 (RemoteCommand.remote_update): ignore updates that arrive after
5761 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5762 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5763 the responsibilities of the subclass's methods
5764 (BuildStep.failed): catch errors during failure processing
5765 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5766 (CVS): move to a mode= argument (described in docstring), rather
5767 than the ungainly clobber=/export=/copydir= combination.
5768 (SVN): add mode= functionality to SVN too
5769 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5771 * buildbot/process/base.py (Build.startNextStep): catch errors
5772 during s.startStep()
5774 * buildbot/clients/base.py: update to new PB client interface.
5775 gtkPanes is still broken
5777 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5778 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5779 * setup.py: add buildbot.slave module
5780 * buildbot/bb_tap.py: handle move
5781 * buildbot/slave/registry.py: place to register commands, w/versions
5782 * buildbot/slave/bot.py: major simplifications
5783 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5784 instead of a fixed table. Eventually this will make the slave more
5785 extensible. Use 'start' method on the command, not .startCommand.
5786 Fix unsafeTracebacks handling (I think).
5787 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5788 helper class with a .start method that returns a Deferred.
5789 SlaveShellCommand is the form reached by the buildmaster. Commands
5790 which use multiple ShellCommands can just chain them as Deferreds,
5791 with some helper methods in Command (_abandonOnFailure and
5792 _checkAbandoned) to bail on rc!=0.
5793 (CVSCommand): prefer new mode= argument
5794 (SVNFetch): add mode= argument
5796 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5797 put a useful reason string on the build
5799 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5800 core functionality into an IStatusLog object
5801 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5802 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5803 (StatusResourceBuild.body): use proper accessor methods
5804 * buildbot/status/client.py (RemoteLog): PB-access goes here
5805 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5806 which delivers log contents too
5807 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5808 * buildbot/status/event.py: remove old Logfile completely
5810 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5811 subscription interface for IStatusLog subscriptions just like all
5812 other the status subscriptions
5813 (IStatusReceiver.logChunk): method called on subscribers
5815 2004-08-24 Brian Warner <warner@lothar.com>
5817 * buildbot/process/builder.py (Builder._pong): oops, ping response
5818 includes a result (the implicit None returned by remote_print).
5819 Accept it so the _pong method handles the response correctly.
5821 2004-08-06 Brian Warner <warner@lothar.com>
5823 * buildbot/test/test_config.py: update IRC, PBListener tests
5825 * buildbot/status/client.py (StatusClientPerspective): total
5826 rewrite to match new IStatus interfaces. New subscription scheme.
5827 There are still a few optimizations to make (sending down extra
5828 information with event messages so the client doesn't have to do a
5829 round trip). The logfile-retrieval code is probably still broken.
5830 Moved the PB service into its own port, you can no longer share a
5831 TCP socket between a PBListener and, say, the slaveport (this
5832 should be fixed eventually).
5833 * buildbot/clients/base.py (Client): revamp to match. still needs
5834 a lot of work, but basic event reporting works fine. gtkPanes is
5837 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5838 instance talks to a single irc server. Threw out all the old
5839 multi-server handling code. Still need to add back in
5840 builder-control (i.e. "force build")
5842 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5843 more random text to the as-yet-unreachable per-step page
5845 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5846 rename to stepETAUpdate
5847 (BuildStatus.subscribe): add build-wide ETA updates
5848 (BuilderStatus.getState): remove more cruft
5849 (BuilderStatus.getCurrentBuild): remove more cruft
5850 (BuilderStatus.buildStarted): really handle tuple-subscription
5851 * buildbot/test/test_run.py (Status.testSlave): handle the
5852 stepETAUpdate rename
5854 * buildbot/master.py (BuildMaster): don't add a default
5855 StatusClientService. Don't add a default IrcStatusFactory. Both
5856 are now added through c['status'] in the config file. c['irc'] is
5857 accepted for backwards compatibility, the only quirk is you cannot
5858 use c['irc'] to specify IRC servers on ports other than 6667.
5860 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5861 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5862 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5863 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5866 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5867 the buildmaster to re-read its config file
5870 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5871 find out the port our server is running on
5872 (WebTest.test_webPathname_port): same
5874 * buildbot/test/test_config.py (testWebPortnum): test it
5875 (testWebPathname): ditto
5877 * docs/config.xhtml: document new c['status'] configuration option
5879 * buildbot/status/html.py (Waterfall): new top-level class which
5880 can be added to c['status']. This creates the Site as well as the
5881 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5882 reachable as .parent, for everything.
5884 * buildbot/master.py (Manhole): make it a normal service Child
5885 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5886 webPathname. It will eventually replace c['irc'] and the implicit
5887 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5888 in as (deprecated) backward compatibility hooks for now.
5891 * buildbot/process/builder.py (Builder.buildFinished): don't
5892 inform out builder_status about a finished build, as it finds out
5893 through its child BuildStatus object
5895 * buildbot/status/html.py: extensive revamp. Use adapters to make
5896 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5897 have both starting and finishing times and adjust the waterfall
5898 display accordingly, using spacers if necessary. Use SlaveStatus
5899 to get buildslave info.
5900 (StatusResourceBuildStep): new just-one-step resource, used to get
5901 logfiles. No actual href to it yet.
5903 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5904 the time being, until I get the file-naming scheme right
5906 * buildbot/status/builder.py (Event): clean started/finished names
5907 (BuildStatus.isFinished): .finished is not None is the right test
5908 (BuildStatus.buildStarted): track started/finished times ourselves
5909 (BuilderStatus.getSlave): provide access to SlaveStatus object
5910 (BuilderStatus.getLastFinishedBuild): all builds are now in
5911 .builds, even the currently-running one. Accomodate this change.
5912 (BuilderStatus.eventGenerator): new per-builder event generator.
5913 Returns BuildStepStatus and BuildStatus objects, since they can
5914 both be adapted as necessary.
5915 (BuilderStatus.addEvent): clean up started/finished attributes
5916 (BuilderStatus.startBuild,finishBuild): remove dead code
5917 (SlaveStatus): new object to provide ISlaveStatus
5919 * buildbot/process/step.py (ShellCommand.getColor): actually
5920 return the color instead of setting it ourselves
5921 (CVS.__init__): pull .timeout and .workdir options out of
5922 **kwargs, since BuildStep will ignore them. Without this neither
5923 will be sent to the slave correctly.
5924 (SVN.__init__): same
5926 * buildbot/process/builder.py (Builder): move flags to class-level
5928 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5929 SlaveStatus handle that
5931 * buildbot/process/base.py (Build.firstEvent): remove dead code
5932 (Build.stopBuild): bugfix
5934 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5936 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5937 (ChangeMaster.eventGenerator): yield Changes, since there are now
5938 Adapters to turn them into HTML boxes
5940 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5941 (BotPerspective.attached): feed a SlaveStatus object
5942 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5943 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5945 * buildbot/interfaces.py: API additions
5946 (ISlaveStatus): place to get slave status
5948 2004-08-04 Brian Warner <warner@lothar.com>
5950 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5951 the delay finishes, so the step is marked as SUCCESS
5953 * buildbot/test/test_run.py (Status.testSlave): cover more of
5954 IBuildStatus and IBuildStepStatus
5956 * buildbot/status/progress.py (StepProgress): move some flags to
5957 class-level attributes
5958 (StepProgress.remaining): if there are no other progress metrics
5959 to go by, fall back to elapsed time
5960 (StepProgress.setExpectations): take a dict of metrics instead of
5962 (BuildProgress.setExpectationsFrom): pull expectations from the
5963 Expectations, instead of having it push them to the BuildProgress
5964 (Expectations): move some flags to class-level attributes
5965 (Expectations.__init__): copy per-step times from the
5967 (Expectations.expectedBuildTime): new method for per-build ETA
5969 * buildbot/status/event.py (Logfile): move some flags to
5970 class-level attributes
5971 (Logfile.logProgressTo): better method name, let step set the
5972 progress axis name (instead of always being "output")
5974 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5975 times directly, rather than depending upon the (possibly missing)
5976 .progress object. Use 'None' to indicate "not started/finished
5978 (BuildStepStatus.getExpectations): oops, return the full list of
5980 (BuilderStatus._buildFinished): append finished builds to .builds
5982 * buildbot/process/step.py (BuildStep): add separate .useProgress
5983 flag, since empty .progressMetrics[] still implies that time is a
5985 (CVS): set up the cmd in __init__, instead of waiting for start()
5987 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5988 calculation, this will eventually turn into a proper sourceStamp
5989 (Build.setupBuild): tell the Progress to load from the Expectations,
5990 instead of having the Expectations stuff things into the Progress
5991 (Build.buildException): add a build-level errback to make sure the
5992 build's Deferred fires even in case of exceptions
5994 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5996 * buildbot/process/builder.py (Builder.forceBuild): convey the
5997 reason instead of creating a fake Change
5999 * docs/examples/twisted_master.cfg: update to match reality
6001 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6002 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6003 fix or remove broken/breaking tests
6005 * buildbot/status/event.py (Logfile.__len__): remove evil method
6007 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6008 missing .build, for test convenience
6010 * buildbot/process/step_twisted.py: import fixes
6012 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6014 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6015 .statusbag reference
6017 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6018 connection at shutdown, and stop it from reconnecting
6020 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6021 chase down remote-execution bugs
6023 * buildbot/process/step.py: more fixes, remove
6024 BuildStep.setStatus()
6025 * buildbot/status/builder.py: move setStatus() functionality into
6027 * buildbot/status/event.py: minor fixes
6029 2004-08-03 Brian Warner <warner@lothar.com>
6031 * buildbot/process/base.py, buildbot/process/builder.py
6032 * buildbot/process/step.py, buildbot/status/builder.py
6033 * buildbot/status/event.py, buildbot/test/test_run.py:
6034 fix status delivery, get a basic test case working
6035 * buildbot/master.py: finish implementing basic status delivery,
6036 temporarily disable HTML/IRC/PB status sources
6038 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6040 * buildbot/status/progress.py (BuildProgress): remove dead code
6042 * buildbot/interfaces.py
6043 * buildbot/process/base.py, buildbot/process/builder.py
6044 * buildbot/process/step.py, buildbot/process/step_twisted.py
6045 * buildbot/status/builder.py: Complete overhaul of the all
6046 status-delivery code, unifying all types of status clients (HTML,
6047 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6048 look like. This commit is a checkpointing of the work-in-progress:
6049 the input side is mostly done (Builders/Builds sending status
6050 to the BuilderStatus/BuildStatus objects), but the output side has
6051 not yet been started (HTML resources querying BuilderStatus
6052 objects). Things are probably very broken right now and may remain
6053 so for several weeks, I apologize for the disruption.
6055 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6056 HTML as the log's contents. Currently used for exception tracebacks.
6057 * buildbot/status/progress.py: minor spelling changes
6059 2004-08-02 Brian Warner <warner@lothar.com>
6061 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6062 in mozilla. Also added stylesheets copied from Twisted's docs.
6063 Remember that these files are meant to be run through Lore first.
6064 Thanks to Philipp Frauenfelder for the fixes.
6065 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6066 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6067 * docs/template.tpl: added a Lore template
6069 2004-07-29 Brian Warner <warner@lothar.com>
6071 * buildbot/interfaces.py: revamp status delivery. This is the
6072 preview: these are the Interfaces that will be provided by new
6073 Builder code, and to which the current HTML/IRC/PB status
6074 displayers will be adapted.
6076 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6077 on the SlaveBuilder, not the Bot.
6078 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6080 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6081 set .usePTY on the FakeSlaveBuilder
6083 2004-07-25 Brian Warner <warner@lothar.com>
6085 * buildbot/changes/freshcvs.py: add some debug log messages
6086 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6087 disabled 'setFilter' syntax
6088 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6089 don't end with a slash
6091 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6093 * setup.py: bump to 0.5.0+ while between releases
6095 2004-07-23 Brian Warner <warner@lothar.com>
6097 * setup.py (version): Releasing buildbot-0.5.0
6099 2004-07-23 Brian Warner <warner@lothar.com>
6101 * README: update for 0.5.0 release
6103 * NEWS: update for 0.5.0 release
6105 2004-07-22 Brian Warner <warner@lothar.com>
6107 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6108 mktap-time configuration flag (--usepty=1, --usepty=0)
6109 * buildbot/bot.py: same
6111 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6112 an 'info' directory being unwanted
6114 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6115 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6116 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6117 and earlier), use a FreshCVSSourceOldcred instead.
6118 (test): simple test routine: connect to server, print changes
6120 * buildbot/changes/changes.py (Change.getTime): make it possible
6121 to print un-timestamped changes
6123 * buildbot/master.py (makeApp): delete ancient dead code
6124 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6125 * buildbot/test/test_config.py (testFindConfigFile): test it
6127 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6128 instead of win32 one
6131 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6132 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6135 * buildbot/process/base.py (Builder.__init__): change constructor
6136 to accept a dictionary of config data, rather than discrete
6137 name/slave/builddir/factory arguments
6139 * docs/examples/twisted_master.cfg: update to new syntax
6140 * docs/examples/glib_master.cfg: same
6141 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6142 rough tests of the new syntax
6145 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6146 to be an int, which means "run a web.distrib sub-server on a TCP
6147 port". This lets you publish the buildbot status page to a remote
6148 twisted.web server (using distrib.ResourceSubscription). Also
6149 rename the local attributes used to hold these web things so
6150 they're more in touch with reality.
6151 * buildbot/test/test_web.py: test webPortnum and webPathname
6152 * docs/config.xhtml: document this new use of webPathname
6154 * docs/config.xhtml: new document, slightly ahead of reality
6156 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6157 'prefix' handling: treat it as a simple string to check with
6158 .startswith, instead of treating it as a directory. This allows
6159 sub-directories to be used. If you use prefix=, you should give it
6160 a string that starts just below the CVSROOT and ends with a slash.
6161 This prefix will be stripped from all filenames, and filenames
6162 which do not start with it will be ignored.
6164 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6166 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6167 and --exclude (inverse of --include). SVN post-commit hooks
6168 now have total control over which changes get sent to buildbot and which
6171 2004-07-10 Brian Warner <warner@lothar.com>
6173 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6174 test case to match new API
6176 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6177 which crashed HTML display when self.entries=[] (needed to
6178 distinguish between [], which means "no entries yet", and None,
6179 which means "the entries have been swapped out to disk, go fetch
6182 2004-07-04 Brian Warner <warner@lothar.com>
6184 * buildbot/process/step_twisted.py (countFailedTests): Count
6185 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6186 10kb from the end because any import errors are wedged there and
6187 they would make us think the test log was unparseable.
6188 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6190 2004-06-26 Brian Warner <warner@lothar.com>
6192 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6193 delete-*.pyc command into an actual BuildStep, so we can label it
6195 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6196 (FullTwistedBuildFactory): same
6198 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6200 * contrib/fakechange.py: Add an errback when sending the fake
6201 change, so we know it didn't work.
6203 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6205 * buildbot/process/step_twisted.py: Delete *.pyc files before
6206 calling trial, so it doesn't catch any old .pyc files whose .py
6207 files have been moved or deleted.
6209 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6210 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6211 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6212 instead of ["twisted.test"], so that the end result is "trial -R
6215 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6216 regular expression to match filenames that should be ignored when
6217 changed. Also add a --revision parameter that specifies the
6218 revision to examine, which is useful for debugging.
6220 2004-06-25 Brian Warner <warner@lothar.com>
6222 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6223 summary of warnings (like DeprecationWarnings), next to the
6226 2004-05-13 Brian Warner <warner@lothar.com>
6228 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6229 we now have a w32 build slave courtesy of Mike Taylor.
6231 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6232 so broken. Fixed a race condition that tripped up interlocked
6233 builds and caused the status to be stuck at "Interlocked" forever.
6234 The twisted buildbot's one interlocked build just so happened to
6235 never hit this case until recently (the feeding builds both pass
6236 before the interlocked build is attempted.. usually it has to wait
6238 (Builder._pong_failed): fix method signature
6240 * setup.py: bump to 0.4.3+ while between releases
6242 2004-04-30 Brian Warner <warner@lothar.com>
6244 * setup.py (version): Releasing buildbot-0.4.3
6246 2004-04-30 Brian Warner <warner@lothar.com>
6248 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6250 * README: update for 0.4.3 release
6252 * NEWS: update for 0.4.3 release
6254 * buildbot/master.py (BuildMaster.__getstate__): make sure
6255 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6257 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6258 .trial as a class attribute, for upgrade from 0.4.2
6260 * buildbot/changes/changes.py (Change.links): add .links for
6263 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6264 .textWatchers and .htmlWatchers at save time, since they are both
6265 volatile, should allow smooth 0.4.2 upgrade
6267 * buildbot/process/step.py (CVS.finishStatus): catch failed
6268 CVS/SVN commands so we can make the status box red
6270 2004-04-29 Brian Warner <warner@lothar.com>
6272 * buildbot/changes/freshcvs.py
6273 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6274 code to do setFilter(), which tells the freshcvs daemon to not
6275 send us stuff that we're not interested in. I will uncomment it
6276 when a new version of CVSToys is available in which setFilter()
6277 actually works, and I get a chance to test it better.
6279 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6281 * buildbot/master.py (Dispatcher): use a registration scheme
6282 instead of hardwired service names
6283 (BuildMaster): keep track of the Dispatcher to support
6286 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6287 PBChangeSource class instead of having it be an undocumented
6288 internal feature of the ChangeMaster. Split out the code into a
6290 * buildbot/changes/pb.py (PBChangeSource): same
6291 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6293 * docs/{factories|sources|steps}.xhtml: document some pieces
6295 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6296 using FCMaildirSource
6297 (f23osx): update OS-X builder to use python2.3, since the slave
6298 was updated to Panther (10.3.3)
6300 2004-03-21 Brian Warner <warner@lothar.com>
6302 * buildbot/process/process_twisted.py: factor out doCheckout, change
6303 to use SVN instead of CVS
6305 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6306 an SVN subclass easier
6307 (BasicSVN): subclass which uses Subversion instead of CVS
6309 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6311 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6313 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6315 2004-02-25 Brian Warner <warner@lothar.com>
6317 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6318 is now either a list (which is passed to spawnProcess directly) or
6319 a string (which gets passed to /bin/sh -c). This removes the useSH
6320 flag and the ArgslistCommand class. Also send status header at the
6321 start and end of each command, instead of having the master-side
6323 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6324 -r'. Update to use list-based arguments.
6325 (SVNFetch): use list-based arguments, use ['dir'] argument to
6327 * buildbot/test/test_steps.py (Commands): match changes
6329 * buildbot/process/step.py (InternalShellCommand.words): handle
6331 (SVN): inherit from CVS, cleanup
6333 * buildbot/status/event.py (Logfile.content): render in HTML, with
6334 stderr in red and headers (like the name of the command we're
6335 about to run) in blue. Add link to a second URL (url + "?text=1")
6336 to get just stdout/stderr in text/plain without markup. There is
6337 still a problem with .entries=None causing a crash, it seems to occur
6338 when the logfile is read before it is finished.
6340 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6341 timeout to the keepalives, and use it to explicitly do a
6342 loseConnection instead of waiting for TCP to notice the loss. This
6343 ought to clear up the silent-lossage problem.
6344 (unsafeTracebacks): pass exception tracebacks back to the master,
6345 makes it much easier to debug problems
6347 2004-02-23 Brian Warner <warner@lothar.com>
6349 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6350 the whole command to /bin/sh instead of execve [Johan Dahlin]
6351 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6352 '-r HEAD' [Johan Dahlin]
6353 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6355 * buildbot/changes/changes.py (Change): add links= argument, add
6356 asHTML method [Johan Dahlin]. Modified to make a bit more
6357 XHTMLish. Still not sure how to best use links= .
6359 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6360 Change.asHTML to display the change, not asText
6362 * buildbot/status/html.py (StatusResourceBuilder): web button to
6365 * buildbot/test/test_run.py: test to actually start a buildmaster
6368 * MANIFEST.in: bring back accidentally-dropped test helper files
6370 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6371 that require cvstoys if it is not installed
6373 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6374 values of "bin/trial" [Dave Peticolas]
6375 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6376 tests passed" when we didn't happen to run any tests
6378 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6379 flunkOnFailure [Johan Dahlin]
6381 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6382 multiple instances of the same Step class by suffixing "_2", etc,
6383 to the name until it is unique. This name needs to be unique
6384 because it is used as a key in the dictionary that tracks build
6386 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6389 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6391 2004-01-14 Brian Warner <warner@lothar.com>
6393 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6394 kicked from a channel, log it
6396 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6397 something over whatever IRC channels the buildmaster is currently
6398 connected to. Added to try and track down a problem in which the
6399 master thinks it is still connected but the IRCd doesn't see it. I
6400 used a styles.Versioned this time, so hopefully users won't have
6401 to rebuild their .tap files this time.
6402 * contrib/debug.glade: add a "Poke IRC" button
6403 * contrib/debugclient.py: same
6405 * setup.py: bump to 0.4.2+ while between releases
6407 2004-01-08 Brian Warner <warner@lothar.com>
6409 * setup.py (version): Releasing buildbot-0.4.2
6411 2004-01-08 Brian Warner <warner@lothar.com>
6413 * NEWS: update for 0.4.2 release
6415 * README: document how to run the tests, now that they all pass
6417 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6419 * buildbot/process/step.py (CVS): add a global_options= argument,
6420 which lets you set CVS global options for the command like "-r"
6421 for read-only checkout, or "-R" to avoid writing in the
6423 * buildbot/slavecommand.py (CVSCommand): same
6425 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6426 testing easier (it is turned off when testing, to avoid the
6429 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6430 to make it easier to test: break generateStepID() out to a
6431 separate function, only update statusbag if it exists.
6432 (ShellCommands): create useful text for dict-based commands too.
6434 * test/*, buildbot/test/*: move unit tests under the buildbot/
6436 * setup.py (packages): install buildbot.test too
6438 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6439 * buildbot/test/test_steps.py: fix it, tests pass now
6441 2004-01-06 Brian Warner <warner@lothar.com>
6443 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6444 freshcvs mail uses a slightly different syntax for new
6445 directories. Update parser to handle either.
6446 * test/test_mailparse.py (Test1.testMsg9): test for same
6448 2003-12-21 Brian Warner <warner@lothar.com>
6450 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6451 'warnOnWarnings' so that lintian errors mark the build orange
6453 2003-12-17 Brian Warner <warner@lothar.com>
6455 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6456 messages emitted by Bonsai, contributed by Stephen Davis.
6458 * test/*: moved all tests to use trial instead of unittest. Some
6459 still fail (test_steps, test_slavecommand, and test_process).
6461 * setup.py (version): bump to 0.4.1+ while between releases
6463 2003-12-09 Brian Warner <warner@lothar.com>
6465 * setup.py (version): Releasing buildbot-0.4.1
6467 2003-12-09 Brian Warner <warner@lothar.com>
6469 * NEWS: update for 0.4.1 release
6471 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6472 freebsd builder code a little bit
6474 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6475 don't try to compare attributes of different classes
6476 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6477 (MaildirSource.messageReceived): fix Change delivery
6479 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6480 into the config file's namespace before loading it, like the
6481 documentation claims it does
6482 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6483 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6484 daemon comes back online
6486 2003-12-08 Brian Warner <warner@lothar.com>
6488 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6489 so the example will work with online=0 as well
6491 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6492 fix the __implements__ line
6494 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6495 class a twisted.application.service.Service, use startService to
6498 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6499 directory fd instead of simple open(). I'm sure this used to work,
6500 but the current version of python refuses to open directories with
6503 2003-12-05 Brian Warner <warner@lothar.com>
6505 * setup.py (version): bump to 0.4.0+ while between releases
6507 2003-12-05 Brian Warner <warner@lothar.com>
6509 * setup.py (version): Releasing buildbot-0.4.0
6511 2003-12-05 Brian Warner <warner@lothar.com>
6513 * docs/examples/glib_master.cfg: replace old sample scripts with
6514 new-style config files
6515 * MANIFEST.in: include .cfg files in distribution tarball
6517 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6518 implement a dummy method to avoid the exception that occurs when
6519 freshcvs sends this to us.
6521 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6522 removed the method, as it broke reconnection. Apparently
6523 stopFactory is called each time the connection attempt fails. Must
6525 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6526 attribute before serialization, since without stopFactory the
6527 reconnect timer may still be active and they aren't serializable.
6529 * test/test_mailparse.py (ParseTest): test with 'self' argument
6531 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6532 argument, as these "functions" are invoked like methods from class
6533 attributes and therefore always get an instance as the first
6536 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6537 message: thanks to Stephen Davis for the catch
6539 2003-12-04 Brian Warner <warner@lothar.com>
6541 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6542 twisted's standard ReconnectingClientFactory. Handles both oldcred
6543 and newcred connections. Also has a bug-workaround for
6544 ReconnectingClientFactory serializing its connector when it
6547 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6548 pbutil. Replace makeApp stuff with proper newcred/mktap
6549 makeService(). Don't serialize Ephemerals on shutdown.
6551 * buildbot/changes/changes.py (ChangeMaster): make it a
6552 MultiService and add the sources as children, to get startService
6553 and stopService for free. This also gets rid of the .running flag.
6555 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6556 new pbutil, turn into a TCPClient at the same time (to get
6557 startService for free). Two variants exist: FreshCVSSourceOldcred
6558 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6559 yet, but when it does, we'll be ready).
6560 (FreshCVSSource.notify): handle paths which are empty after the
6561 prefix is stripped. This only happens when the top-level (prefix)
6562 directory is added, at the very beginning of a Repository's life.
6564 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6565 Now the only reconnecting code is in the factory where it belongs.
6566 (Builder.unsubscribe): unregister the disconnect callback when we
6567 delete the builder on command from the master (i.e. when the
6568 buildmaster is reconfigured and that builder goes away). This
6569 fixes a multiple-delete exception when the status client is shut
6571 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6574 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6575 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6577 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6579 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6580 a list of globs (ugh). The testdir will be searched for files
6581 named *.tests and run the tests in the order specified in each of
6582 those files. This allows for "dependancies" between tests to be
6585 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6586 argument to pass to run_maxq.py, instead of a glob.
6588 2003-10-17 Brian Warner <warner@lothar.com>
6590 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6591 files that live in the sandbox
6593 2003-10-15 Brian Warner <warner@lothar.com>
6595 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6596 spelling error in "docs" count-warnings output
6597 (HLint.start): stupid thinko meant .xhtml files were ignored
6599 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6600 tests now that cReactor is banished to the sandbox
6602 2003-10-10 Brian Warner <warner@lothar.com>
6604 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6605 scheme: now .xhtml are sources and .html are generated
6607 2003-10-08 Brian Warner <warner@lothar.com>
6609 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6610 we were ignoring the 'randomly' parameter.
6612 2003-10-01 Brian Warner <warner@lothar.com>
6614 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6615 posix, to kill sub-children of aborted slavecommands.
6617 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6618 Clean up initialization: lastBuildStatus remains None until the
6619 first build has been completed.
6621 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6622 None as a lastBuildStatus
6623 * buildbot/clients/gtkPanes.py: same
6625 * buildbot/status/client.py (StatusClientService): keep
6626 BuilderStatus objects in self.statusbags . These objects now live
6627 here in the StatusClientService and are referenced by the Builder
6628 object, rather than the other way around.
6629 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6630 * buildbot/process/base.py (Builder): same
6631 * test/test_config.py (ConfigTest.testBuilders): same
6633 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6634 an existing builder, leave the statusbag alone. This will preserve the
6637 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6638 hook. This will probably go away in favor of a class in upcoming
6641 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6642 serviceName from newcred FreshCVSNotifiee setup
6644 2003-09-29 Brian Warner <warner@lothar.com>
6646 * buildbot/process/process_twisted.py: switch to new reactor
6648 * docs/examples/twisted_master.cfg: same
6650 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6652 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6653 botmaster reference instead of the oldapp service lookup
6655 * buildbot/master.py (BuildMaster.__init__): give the
6656 StatusClientService a reference to the botmaster to make it easier to
6659 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6661 * buildbot/status/html.py (Box.td): escape hreffy things so you
6662 can have spaces in things like builder names
6663 (StatusResourceBuilder.body)
6664 (WaterfallStatusResource.body)
6665 (WaterfallStatusResource.body0): same
6667 2003-09-25 Brian Warner <warner@lothar.com>
6669 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6670 rearrange the builder list when adding or removing builders: keep
6671 them in the order the user requested.
6672 * test/test_config.py (ConfigTest.testBuilders): verify it
6674 * contrib/debug.glade: give the debug window a name
6676 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6677 now wait on multiple interlocks. Fix code relating to that.
6678 (Builder.checkInterlocks): same
6679 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6681 * buildbot/master.py (BuildMaster.loadConfig): move from
6682 deprecated pb.BrokerFactory to new pb.PBServerFactory
6683 * test/test_config.py (ConfigTest.testWebPathname): same
6685 * docs/examples/twisted_master.cfg: fix interlock declaration
6687 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6688 Interlocks to their Builders into interlock.py .
6689 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6691 * test/test_config.py (ConfigTest.testInterlocks): validate
6694 * buildbot/process/base.py (Builder.__init__): better comments
6695 * buildbot/process/interlock.py (Interlock.__repr__): same
6696 (Interlock.deactivate): add .active flag, move the code that
6697 attaches/detaches builders into the Interlock
6699 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6701 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6702 tests using the new run_maxq.py script, and reporting failures by
6705 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6706 tests, reporting their success or failure in a buildbot-friendly
6709 2003-09-24 Brian Warner <warner@lothar.com>
6711 * docs/examples/twisted_master.cfg: example of a new-style config
6712 file. This lives in the buildmaster base directory as
6715 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6716 button to make the master re-read its config file
6718 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6719 buildmaster configuration from a file. This file can be re-read
6720 later, and the buildmaster will update itself to match the new
6721 desired configuration. Also use new Twisted Application class.
6722 * test/Makefile, test/test_config.py: unit tests for same
6724 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6725 FreshCVSSources comparable, to support reload.
6726 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6728 * buildbot/process/base.py (Builder): make them comparable, make
6729 Interlocks easier to attach, to support reload. Handle
6730 re-attachment of remote slaves.
6731 * buildbot/process/interlock.py (Interlock): same
6733 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6734 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6735 buildmaster taps are now constructed with mktap.
6736 * buildbot/status/client.py (StatusClientService): same
6738 * buildbot/status/words.py: move to new Services, add support to
6739 connect to multiple networks, add reload support, allow nickname
6740 to be configured on a per-network basis
6742 2003-09-20 Brian Warner <warner@lothar.com>
6744 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6745 the freebsd builder, now that the machine has been upgraded and no
6746 longer has python2.2
6748 * setup.py (version): bump to 0.3.5+ while between releases
6750 2003-09-19 Brian Warner <warner@lothar.com>
6752 * setup.py (version): Releasing buildbot-0.3.5
6754 2003-09-19 Brian Warner <warner@lothar.com>
6756 * NEWS: add post-0.3.4 notes
6758 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6760 * MANIFEST.in: add contrib/*
6762 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6763 use a remote root now: cvs.twistedmatrix.com
6765 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6767 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6768 compatibility with old servers
6769 (FreshCVSSource.start): and provide a way to use it
6770 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6772 * docs/examples/twisted_master.py (twisted_app): update to new
6774 (twisted_app): listen on new ~buildbot socket
6775 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6777 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6778 to reduce cvs bandwidth (update instead of full checkout)
6780 2003-09-11 Brian Warner <warner@lothar.com>
6782 * contrib/fakechange.py: demo how to connect to the changemaster
6783 port. You can use this technique to submit changes to the
6784 buildmaster from source control systems that offer a hook to run a
6785 script when changes are committed.
6787 * contrib/debugclient.py: tool to connect to the debug port. You
6788 can use it to force builds, submit fake changes, and wiggle the
6791 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6792 'Dispatcher' realm to handle all the different kinds of
6793 connections and Perspectives: buildslaves, the changemaster port,
6794 the debug port, and the status client port. NewCredPerspectives
6795 now have .attached/.detached methods called with the remote 'mind'
6796 reference, much like old perspectives did. All the pb.Services
6797 turned into ordinary app.ApplicationServices .
6798 (DebugService): went away, DebugPerspectives are now created
6799 directly by the Dispatcher.
6800 (makeApp): changed interface a little bit
6802 * buildbot/changes/changes.py: newcred
6803 * buildbot/status/client.py: newcred
6805 * buildbot/clients/base.py: newcred client side changes
6806 * buildbot/bot.py: ditto
6808 * docs/examples/glib_master.py: handle new makeApp() interface
6809 * docs/examples/twisted_master.py: ditto
6811 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6812 base newcred Perspectives on. This should go away once Twisted
6813 itself provides something sensible.
6816 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6818 * contrib/svn_buildbot.py: A program that you can call from your
6819 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6820 when a change in an SVN repository has happened. See the top of
6821 the file for some minimal usage info.
6823 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6825 * buildbot/slavecommand.py (ArglistCommand): Add new
6826 ArglistCommand that takes an argument list rather than a string as
6827 a parameter. Using a st.split() for argv is very bad.
6829 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6830 update to a particular revision rather than always checking out
6831 (still not very smart about it, there may be cases where the
6832 checkout becomes inconsistent).
6834 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6836 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6837 SVN fetch support. It can checkout (not update!) a specified
6838 revision from a specified repository to a specified directory.
6840 * buildbot/status/progress.py (Expectations.update): Fix an
6841 obvious bug (apparently created by the change described in the
6842 previous ChangeLog message) by moving a check to *after* the
6843 variable it checks is defined.
6846 2003-09-08 Brian Warner <warner@lothar.com>
6848 * buildbot/status/progress.py (Expectations.update): hack to catch
6849 an exception TTimo sees: sometimes the update() method seems to
6850 get called before the step has actually finished, so the .stopTime
6851 is not set, so no totalTime() is available and we average None
6852 with the previous value. Catch this and just don't update the
6853 metrics, and emit a log message.
6855 2003-08-24 Brian Warner <warner@lothar.com>
6857 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6858 parameter to set copydir='original' in CVS commands.
6860 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6862 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6863 which tells the command to maintain a separate original-source CVS
6864 workspace. For each build, this workspace will be updated, then
6865 the tree copied into a new workdir. This reduces CVS bandwidth
6866 (from a full checkout to a mere update) while doubling the local
6867 disk usage (to keep two copies of the tree).
6869 2003-08-21 Brian Warner <warner@lothar.com>
6871 * buildbot/status/event.py (Logfile.addEntry): if the master web
6872 server dies while we're serving a page, request.write raises
6873 pb.DeadReferenceError . Catch this and treat it like a
6874 notifyFinish event by dropping the request.
6876 2003-08-18 Brian Warner <warner@lothar.com>
6878 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6879 (instead of blowing up) if a force-build command is given without
6882 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6883 don't blow up if there aren't yet any Changes in the list
6885 2003-08-02 Brian Warner <warner@lothar.com>
6887 * buildbot/bot.py (updateApplication): don't set the .tap name,
6888 since we shouldn't assume we own the whole .tap file
6890 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6891 'mktap buildbot' (without a subcommand) better
6893 2003-07-29 Brian Warner <warner@lothar.com>
6895 * buildbot/status/words.py
6896 (IrcStatusFactory.clientConnectionLost): when we lose the
6897 connection to the IRC server, schedule a reconnection attempt.
6899 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6900 use shutil.rmtree instead of forking off an "rm -rf" command.
6901 rmtree may take a while and will block until it finishes, so we
6902 use "rm -rf" if available.
6904 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6905 freebsd buildslave badly
6907 * setup.py (version): bump to 0.3.4+ while between releases
6909 2003-07-28 Brian Warner <warner@lothar.com>
6911 * setup.py (version): Releasing buildbot-0.3.4
6913 2003-07-28 Brian Warner <warner@lothar.com>
6915 * NEWS: update in preparation for release
6917 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6918 process.signalProcess instead of os.kill, to improve w32
6921 * docs/examples/twisted_master.py (twisted_app): turn off
6922 win32eventreactor: the tests hang the buildslave badly
6924 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6925 failed builds, since usually the failures are consistent
6927 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6928 add compileOpts/compileOpts2 to reactors build
6930 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6931 (twisted_app): use both default and win32eventreactor on w32 build.
6932 Use both default and kqreactor on freebsd build.
6934 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6935 add compileOpts2, which is put after the build_ext argument. w32
6936 needs "-c mingw32" here.
6938 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6939 touch .acqpath, it goes away in recent Twisted releases
6941 * docs/examples/twisted_master.py (twisted_app): use "python" for
6942 the w32 buildslave, not "python2.2"
6944 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6945 the directory exists.. should hush an exception under w32
6947 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6948 ProcessTerminated -provided values for signal and exitCode rather
6949 than parsing the unix status code directly. This should remove one
6950 more roadblock for a w32-hosted buildslave.
6952 * test/test_mailparse.py: add test cases for Syncmail parser
6954 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6955 temporary compatibility import. Note! Start importing
6956 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6958 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6960 2003-07-27 Brian Warner <warner@lothar.com>
6962 * NEWS: started adding new features
6964 * buildbot/changes/mail.py: start work on Syncmail parser, move
6965 mail sources into their own file
6967 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6968 as implementing IChangeSource
6969 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6971 * buildbot/interfaces.py: define the IChangeSource interface
6973 2003-07-26 Brian Warner <warner@lothar.com>
6975 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6977 2003-06-25 Brian Warner <warner@lothar.com>
6979 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6982 2003-06-17 Brian Warner <warner@lothar.com>
6984 * buildbot/status/words.py: clean up method usage to avoid error
6985 in silly IRC command
6986 (IrcStatusBot.emit_status): round off seconds display
6988 * buildbot/process/base.py (Build): delete the timer when saving
6989 to the .tap file, and restore it (if it should still be running)
6990 upon restore. This should fix the "next build in -34 seconds"
6991 messages that result when the master is restarted while builds are
6992 sitting in the .waiting slot. If the time for the build has
6993 already passed, start it very soon (in 1 second).
6995 * buildbot/status/words.py: more silly commands
6997 * README (REQUIREMENTS): add URLs to all required software
6999 * buildbot/status/words.py ('last'): mention results of, and time
7002 2003-05-28 Brian Warner <warner@lothar.com>
7004 * buildbot/status/words.py: add 'last' command
7005 (IrcStatusBot.emit_status): add current-small text to 'status' output
7007 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7008 (twisted_app): remove spaces from OS-X builder name
7010 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7011 * buildbot/status/words.py: IRC bot should actually be useful now
7013 2003-05-23 Brian Warner <warner@lothar.com>
7015 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7016 "slave information" from $(slavedir)/info/* . These files are
7017 maintained by the slave administrator, and describe the
7018 machine/environment that is hosting the slave. Information from
7019 them is put into the "Builder" HTML page. Still need to establish
7020 a set of well-known filenames and meanings for this data: at the
7021 moment, *all* info/* files are sent to the master, but only
7022 'admin' and 'host' are used on that end.
7023 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7024 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7025 * buildbot/master.py (BotPerspective.got_info): ditto
7027 2003-05-22 Brian Warner <warner@lothar.com>
7029 * setup.py (version): bump version to 0.3.3+ while between releases
7031 2003-05-21 Brian Warner <warner@lothar.com>
7033 * setup.py: Releasing buildbot-0.3.3
7035 2003-05-21 Brian Warner <warner@lothar.com>
7037 * NEWS: 0.3.3 news items
7039 * README: describe --keepalive and life behind a NAT box
7041 * buildbot/bot.py (Bot.connected): implement application-level
7042 keepalives to deal with NAT timeouts, turn them on with
7043 --keepalive option or when SO_KEEPALIVE doesn't work.
7045 * buildbot/master.py (BotPerspective): accept keepalives silently
7047 * buildbot/process/base.py (Build.buildException): CopiedFailures
7048 don't carry as much information as local ones, so don't try to
7049 create a big HTMLized version of them.
7051 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7052 log file when step fails due to an exception, such as when the slave
7055 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7056 --testmodule argument instead of grepping for test-case-name tags
7057 ourselves. Remove FindUnitTests code.
7058 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7060 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7062 2003-05-16 Brian Warner <warner@lothar.com>
7064 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7065 argument to allow things like CFLAGS=-O0 to be passed without relying
7066 upon /bin/sh processing on the slave.
7068 * buildbot/process/step.py (InternalShellCommand.start): send
7070 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7071 'split' instead of letting /bin/sh do it. This should also remove
7072 the need for /bin/sh on the buildslave, making it more likely to
7075 * buildbot/status/html.py: html-escape text in blamelist.
7076 Add "force build" button to the Builder page.
7078 * buildbot/process/step_twisted.py (countFailedTests): look at
7079 last 1000 characters for status line, as import errors can put it
7080 before the -200 point.
7082 2003-05-15 Brian Warner <warner@lothar.com>
7084 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7086 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7087 make 'clobber' a parameter, so it is possible to have builds which
7088 do full tests but do a cvs update instead of hammering the CVS
7089 server with a full checkout each build
7091 * buildbot/process/step.py (InternalShellCommand): bump default
7092 timeout to 20 minutes
7094 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7095 the master to trigger a build. Run it via manhole.
7097 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7098 allow slaves to trigger any build that they host, to make life
7099 easier for slave admins who are testing out new build processes
7101 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7102 don't flunk cReactor or qtreactor on failure, since they fail alot
7103 these days. Do warnOnFailure instead.
7105 * buildbot/process/base.py: change Builder.buildable from a list
7106 into a single slot. When we don't have a slave, new builds (once
7107 they make it past the timeout) are now merged into an existing
7108 buildable one instead of being queued. With this change, a slave
7109 which has been away for a while doesn't get pounded with all the
7110 builds it missed, but instead just does a single build.
7112 2003-05-07 Brian Warner <warner@lothar.com>
7114 * setup.py (version): bump version to 0.3.2+ while between releases
7116 2003-05-07 Brian Warner <warner@lothar.com>
7118 * setup.py: Releasing buildbot-0.3.2
7120 2003-05-07 Brian Warner <warner@lothar.com>
7122 * setup.py: fix major packaging error: include subdirectories!
7124 * NEWS: add changes since last release
7126 * README (REQUIREMENTS): update twisted/python dependencies
7128 * buildbot/status/builder.py (Builder.startBuild): change
7129 BuildProcess API: now they should call startBuild/finishBuild
7130 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7131 keeping a list of builds in the statusbag, to support other kinds of
7133 (Builder.addClient): send current-activity-small to new clients
7134 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7137 * buildbot/status/client.py: drop RemoteReferences at shutdown
7139 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7141 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7142 more debug messages for remote status client
7144 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7145 (.stepFailed): only fire the Deferred once, even if both
7146 stepComplete and stepFailed are called. I think this can happen if
7147 an exception occurs at a weird time.
7149 * buildbot/status/words.py: work-in-progress: IRC status delivery
7151 2003-05-05 Brian Warner <warner@lothar.com>
7153 * docs/examples/twisted_master.py (twisted_app): hush internal
7154 python2.3 distutils deprecation warnings
7155 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7156 add compileOpts= argument which inserts extra args before the
7157 "setup.py build_ext" command. This can be used to give -Wignore
7158 warnings, to hush some internal python-2.3 deprecation messages.
7160 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7161 the ['twisted.test'] default test case to make it easier to change
7164 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7165 * buildbot/clients/gtkPanes.py: ditto
7167 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7168 arg to collapse RunUnitTestsRandomly into RunUnitTests
7169 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7170 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7172 * buildbot/status/html.py (StatusResource): shuffle Resources
7173 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7174 would serve the waterfall display, but the internal links were
7175 only valid on the trailing-slash version. The correct behavior is
7176 for the non-slashed one to serve a Redirect to the slashed one.
7177 This only shows up when the buildbot page is hanging off another
7178 server, like a Twisted-Web distributed server.
7180 * buildbot/status/event.py (Event, RemoteEvent): make Events
7181 pb.Cacheable, with RemoteEvent as the cached version. This removes
7182 a lot of explicit send-an-update code.
7183 * buildbot/status/builder.py (Builder): remove send-update code
7184 * buildbot/status/client.py (ClientBuilder): remove send-update
7185 code, and log errors that occur during callRemote (mostly to catch
7186 InsecureJelly exceptions)
7188 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7189 run Lore with the same python used in the rest of the build
7191 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7193 * buildbot/process/step_twisted.py (HLint): accept 'python'
7194 argument. Catch rc!=0 and mark the step as failed. This marks the
7195 build orange ("has warnings").
7196 (RunUnitTestsJelly): move out to step_twisted2.py
7198 * buildbot/util.py (ignoreStaleRefs): add utility function
7200 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7201 don't fake ETA object, it's too hard to get right
7203 2003-05-02 Brian Warner <warner@lothar.com>
7205 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7207 2003-05-01 Brian Warner <warner@lothar.com>
7209 * buildbot/status/html.py (StatusResource.body): oops, I was
7210 missing a <tr>, causing the waterfall page to be misrendered in
7211 everything except Galeon.
7213 2003-04-29 Brian Warner <warner@lothar.com>
7215 * docs/examples/twisted_master.py: make debuild use python-2.2
7216 explicitly, now that Twisted stopped supporting 2.1
7218 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7219 handle tuple results too. I keep forgetting this, which suggests
7220 it needs to be rethought.
7222 * setup.py (setup): bump version to 0.3.1+ while between releases
7224 2003-04-29 Brian Warner <warner@lothar.com>
7226 * setup.py: Releasing buildbot-0.3.1
7228 2003-04-29 Brian Warner <warner@lothar.com>
7230 * README (SUPPORT): add plea to send questions to the mailing list
7232 * NEWS, MANIFEST.in: add description of recent changes
7234 * docs/examples/twisted_master.py: add the code used to create the
7235 Twisted buildmaster, with passwords and such removed out to a
7238 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7239 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7240 buildmasters to not require CVSToys be installed.
7241 * README, docs/examples/glib_master: update to match the change
7243 * buildbot/clients/base.py, buildbot/bot.py,
7244 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7245 ReconnectingPB from CVSToys distribution to remove CVSToys
7246 dependency for build slaves and status clients. Buildmasters which
7247 use FreshCVSSources still require cvstoys be installed, of course.
7249 2003-04-25 Brian Warner <warner@lothar.com>
7251 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7252 runTestsRandomly arg to turn on trial -z
7254 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7255 experimental code to use trial's machine-parseable output to get
7256 more detailed test results. Still has some major issues.
7257 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7260 * buildbot/status/builder.py (Builder.setCurrentBuild):
7261 anticipating moving build history into statusbag, not used yet
7263 * buildbot/status/tests.py: code to centralize test results,
7264 doesn't work quite yet
7266 * buildbot/status/event.py (Event): use hasattr("setName") instead
7267 of isinstance for now.. need better long-term solution
7269 * buildbot/status/html.py: Remove old imports
7271 2003-04-24 Brian Warner <warner@lothar.com>
7273 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7274 ignore changes under doc/fun/ and sandbox/
7276 * buildbot/process/step_twisted.py: update pushEvent and friends.
7278 * buildbot/status/html.py (Box.td): replace event.buildername with
7279 event.parent.getSwappableName(). Needs more thought.
7281 * buildbot/status/builder.py (Builder): Replace pushEvent and
7282 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7283 Tell events they are being pruned with event.delete().
7285 * buildbot/process/base.py (Build): Remove Builder status-handling
7286 methods. s/pushEvent/setCurrentActivity/.
7288 * buildbot/process/step.py (BuildStep): clean up status delivery.
7289 Gouse builder.statusbag methods instead of intermediate builder
7290 methods. s/updateLastEvent/updateCurrentActivity/.
7291 s/finalizeLastEvent/finishCurrentActivity/. Use
7292 addFileToCurrentActivity for summaryFunction.
7294 * buildbot/status/event.py (Logfile): put data in a Swappable when
7296 (Event): add more setter methods. Remove .buildername, use .parent
7297 and getSwappableName instead (needs more thought).
7299 * buildbot/util.py (Swappable):
7300 * test/test_swap.py: don't bother setting filename at __init__
7301 time, do it later. Change setFilename args to take parent first,
7302 since it provides the most significant part of the filename.
7304 2003-04-23 Brian Warner <warner@lothar.com>
7306 * buildbot/status/event.py (Logfile.addEntry): append to previous
7309 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7310 anticipating Swappable
7311 (InternalShellCommand.remoteUpdate): split out various log-adding
7312 methods so subclasses can snarf stdout separately
7314 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7315 in anticipation of Swappable build logs
7316 (Builder.testsFinished): anticipating TestResults, still disabled
7318 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7321 * buildbot/status/event.py (Logfile): add (disabled) support for
7322 Swappable, not ready for use yet
7324 * buildbot/util.py (Swappable): object which is swapped out to
7325 disk after some period of no use.
7326 * test/test_swap.py: test buildbot.utils.Swappable
7328 2003-04-14 Brian Warner <warner@lothar.com>
7330 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7331 periodic-build timer. Set the .periodicBuildTime on a builder
7332 instance to some number of seconds to activate it.
7334 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7336 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7337 a way that survives result tuples
7339 2003-04-12 Brian Warner <warner@lothar.com>
7341 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7342 return a dict instead of a tuple: allow summarizers to provide
7343 multiple summaries if they want
7344 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7345 (debuildSummarizer): summarize lintian warnings/errors
7347 2003-04-10 Brian Warner <warner@lothar.com>
7349 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7351 2003-04-09 Brian Warner <warner@lothar.com>
7353 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7354 empty summaries: happens when the tests fail so hard they don't emit
7355 a parseable summary line.
7357 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7358 Allow summaryFunction to return None to indicate no summary should
7361 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7362 writing to stale HTTP requests: notice when they disconnect and
7363 remove the request from the list. Also add CacheToFile from
7364 moshez, will be used later.
7366 2003-04-08 Brian Warner <warner@lothar.com>
7368 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7369 should be an int, not a list of strings
7371 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7372 if we weren't actually connected
7374 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7375 to show the tail end of the trial text output
7377 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7378 hook to summarize the results of a ShellCommand
7380 2003-04-07 Brian Warner <warner@lothar.com>
7382 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7383 twisted test suite code into a single class.
7384 * buildbot/process/process_twisted.py: same
7386 2003-04-04 Brian Warner <warner@lothar.com>
7388 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7390 * README (SLAVE): document use of mktap to create slave .tap file
7391 (REQUIREMENTS): describe dependencies
7393 * buildbot/bb_tap.py, buildbot/plugins.tml:
7394 * buildbot/bot.py (updateApplication): Add mktap support for creating
7395 buildslave .tap files
7397 2003-03-28 Brian Warner <warner@lothar.com>
7399 * buildbot/process/step.py (InternalShellCommand.finished): handle
7400 new tuple result values (fix embarrasing bug that appeared during
7403 2003-03-27 Brian Warner <warner@lothar.com>
7405 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7408 2003-03-25 Brian Warner <warner@lothar.com>
7410 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7411 to overall build status
7412 * buildbot/clients/base.py (Builder): improve event printing
7413 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7414 instead of generic ShellCommand
7415 (Build): Add .stopBuild, use it when slave is detached
7417 * buildbot/process/step.py (Configure,Test): give the steps their
7418 own names and status strings
7420 * buildbot/status/html.py (StatusResource): add "show" argument,
7421 lets you limit the set of Builders being displayed.
7423 2003-03-20 Brian Warner <warner@lothar.com>
7425 * buildbot/process/basic.py: removed
7427 2003-03-19 Brian Warner <warner@lothar.com>
7429 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7430 turn off process-docs by default
7432 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7433 when displaying build information without anything in allBuilds[]
7435 * buildbot/bot.py (makeApp): really take password from sys.argv
7437 2003-03-18 Brian Warner <warner@lothar.com>
7439 * buildbot/bot.py (buildApp): take password from sys.argv
7441 * README: replace with more useful text
7443 * setup.py: add a real one
7444 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7446 * docs/PyCon-2003/: added sources for PyCon paper.
7448 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7449 now Build objects control the process and Builder only handles
7450 slave stuff and distribution of changes/status. A new BuildFactory
7451 class creates Build objects on demand.
7453 Created ConfigurableBuild which takes a list of steps to run. This
7454 makes it a lot easier to set up a new kind of build and moves us
7455 closer to being able to configure a build from a web page.
7457 * buildbot/process/step_twisted.py, process_twisted.py: move to
7458 new model. A lot of code went away.
7460 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7461 send lots of empty progress messages to the client.
7463 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7465 2003-02-20 Brian Warner <warner@lothar.com>
7467 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7469 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7470 Twisted bug that prevented non-pty processes from working just got
7471 fixed, and the bug that leaks ptys is still being investigated.
7473 * buildbot/process/step.py (CVS): send timeout arg to slave
7475 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7476 builders coming and going
7477 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7478 from CVSToys, handle lost-buildmaster
7480 * buildbot/status/client.py (StatusClientService.removeBuilder):
7481 Clean up status client protocol: send builders (with references)
7482 as they are created, rather than sending a list and requiring the
7483 client to figure out which ones are new.
7484 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7485 attempts to force a build on an unknown builder
7487 2003-02-19 Brian Warner <warner@lothar.com>
7489 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7490 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7491 Twisted stops leaking them.
7492 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7493 builder goes to an idle state.
7495 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7496 I figure out why CVS commands hang without them, and/or I fix the
7497 hung-command timeout
7499 2003-02-16 Brian Warner <warner@lothar.com>
7501 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7502 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7503 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7504 GenerateDocs now that they are prefixed with WARNING:.
7506 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7507 use manual href target instead of request.childLink
7509 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7510 display every second, but update the ETA every 5 seconds (or
7511 whenever) as remote_progress messages arrive.
7514 2003-02-12 Brian Warner <warner@lothar.com>
7516 * *: import current sources from home CVS repository
7520 # add-log-time-format: add-log-iso8601-time-string