1 2007-09-30 Brian Warner <warner@lothar.com>
3 * setup.py: install all test files from buildbot/test/mail/* . Also
4 update URL to point at buildbot.net
5 * MANIFEST.in: update with new files
7 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
8 auto-create an empty public_html directory, otherwise we get
9 internal server errors instead of 404s.
11 * README: reference buildbot.net, remove CVSToys section (does
14 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
15 message when public_html/ is missing (indicating that you should
16 probably run 'upgrade-master'), and don't auto-create an empty
17 directory in that case.
19 * contrib/darcs_buildbot.py: refactor internals a bit, make it
20 possible to use as an importable module (to make it easier to
21 write some unit tests for it)
23 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
24 DeprecationWarning for Waterfall, advising users to switch over to
27 * NEWS: update with user-visible changes since the last release
29 * buildbot/status/web/waterfall.py
30 (WaterfallStatusResource.get_reload_time): if the suggest a
31 reload time of less than 15 seconds, give them 15 seconds instead
32 of ignoring their request entirely, because that'd be confusing.
34 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
35 warning if we must invoke the last-change-is-most-recent guess
37 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
38 Waterfall is running in an upgraded master (which is the usual
39 case for folks who have followed the instructions to run
40 'upgrade-master' but who have not yet resolved all the
41 DeprecationWarnings), prefer the buildbot.css from public_html/
42 rather than the one passed in on the buildbot= argument.
43 Otherwise, the resulting pages don't quite use CSS right..
44 sometimes it works, sometimes it doesn't, and I don't know why.
45 Sites that are using custom CSS will see the default CSS until
46 they modify public_html/buildbot.css to include their
49 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
50 * buildbot/status/web/robots.txt (Disallow): update to cover all
51 dynamically-generated pages
53 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
54 include both 'trunk' and None in the output list, since some VC
55 systems (SVN, frequently) refer to trunk as 'trunk'.
57 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
58 point the 'welcome' link explicitly at index.html, rather than
59 '.', so that old Waterfall users can reach it and discover all the
62 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
63 build's text to the end of the line, without a CSS class so it
66 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
67 'max_search=' argument, to limit the number of builds that are
68 examined while trying to find ones that match the other criteria.
69 This helps to limit the work we do, since otherwise we might have
70 to trawl through all history.
71 (IBuilderStatus.generateFinishedBuilds): same
72 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
73 (BuilderStatus.generateFinishedBuilds): same
75 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
76 our got_revision before checking its length: SVN (at least) still
77 reports numeric values for this.
78 * buildbot/status/web/build.py (StatusResourceBuild.body): same
79 * buildbot/status/web/xmlrpc.py
80 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
81 serving a completely fake revision
83 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
84 basedir to sys.path, to mimic what a real buildmaster would have
85 access to, since it is common for master.cfg to import helper
86 classes from .py files in the buildmaster directory, and we want
87 config-file checking to accomodate this.
89 * buildbot/status/web/base.py (map_branches): when referring to
90 branches through WebStatus (i.e. by appending ?branch=FOO query
91 arguments to the URL), make "trunk" mean trunk, by mapping it to
92 None before passing it to generateFinishedBuilds() and the like.
93 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
94 (OneBoxPerBuilder.body): same, also improve display of branches in
96 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
97 (WaterfallStatusResource.buildGrid): same. Note that this filters
98 Changes as well as Builds.
99 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
100 caveat about trunk branches, now that it's fixed
102 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
103 from builder.py, use it on the Builder page too
105 * buildbot/status/web/builder.py (StatusResourceBuilder): same
106 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
107 names, add some CSS classes
108 * buildbot/status/web/classic.css (td.box): new class, for
111 * docs/buildbot.texinfo (WebStatus): update docs
113 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
114 the trailing "M" indicator that tells us this is a modified file.
115 This should help with mode="update" builds that modify files
116 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
119 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
120 new copies of files (to .new) when those files already exist,
121 check the master.cfg file for errors (and give DeprecationWarnings
122 a chance to be displayed).
123 * buildbot/test/test_runner.py: add more tests
124 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
126 2007-09-29 Brian Warner <warner@lothar.com>
128 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
129 the revision id from the last change in our list, since that's the
130 best we can do without knowing the full ancestry graph. Closes #103.
132 * buildbot/scripts/sample.cfg: use buildstep instances in
133 f.addStep, to demonstrate the (correct) modern usage.
134 * docs/examples/hello.cfg: bring this up to date. Closes #79.
135 * docs/examples/twisted_master.cfg: add a big warning about how
137 * docs/examples/glib_master.cfg: delete this one entirely, it is
138 ancient and not a very useful example anyways
140 * buildbot/status/web/base.py (HtmlResource.render): keep track of
141 HTTPChannels, so we can shut them down at reconfig time (when the
142 WebStatus goes away). Closes #102.
143 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
144 (WebStatus.registerChannel): same
145 (WebStatus.stopService): do .loseConnection() here
147 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
148 WebStatus, make sure all pages are still retrievable. I thought
149 this would exercise a bug, but it turns out that it was firefox
150 caching connections (and continuing to talk to the old WebStatus
151 even though I'd loaded a new one).
152 * buildbot/status/web/baseweb.py (WebStatus): add some comments
153 (WebStatus.__repr__): include id() in the repr
155 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
156 this to specify an errorparser. From Ted Mielczarek and the
157 mozilla crew. Closes #94.
159 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
160 bonsaipoller ignore funkyness in xml output for empy log
161 messages", from Axel Hecht. Closes #90.
162 * buildbot/test/test_bonsaipoller.py
163 (TestBonsaiPoller.testMergeEmptyLogMsg): same
165 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
166 respect 'builders' arg, from Ben Hearsum. Closes #89.
168 * buildbot/scripts/runner.py (stop): increase the timeout from 5
169 seconds to 10, to give heavily loaded machines a better chance to
170 finish shutting down. Addresses (partially) #68.
171 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
173 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
174 * buildbot/scripts/startup.py (Follower._failure): update message
176 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
177 team, to fix some bugs and avoid the use of blocking urlopen().
179 * buildbot/test/test_bonsaipoller.py: same
181 2007-09-28 Brian Warner <warner@lothar.com>
183 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
184 argument, to send email about buildslaves which are disconnected
185 for more than an hour. Closes #64.
186 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
188 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
189 (MailNotifier): add docs for this too
192 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
193 respect branch= queryargs, by restricting the builds displayed to
194 those matching the given branch names
195 * buildbot/status/web/waterfall.py (BuildTopBox): same
197 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
198 fix a test failure by adding .prepath to this fake object
200 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
201 up generation of relative URLs. With luck, this should play with
202 reverse proxies much better now.
203 * buildbot/test/test_webparts.py: new test for most of the subpages
204 * buildbot/test/test_web.py (base_config): add enough of a config
205 to exercise more Waterfall code
207 2007-09-27 Brian Warner <warner@lothar.com>
209 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
210 relative URL to the buildbot welcome page, rather than
212 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
214 * buildbot/status/web/base.py (HtmlResource.title): change the
215 default title of all Buildbot-generated page to "Buildbot"
216 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
217 change the title to include the Builder name
218 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
219 same, and also show the build number
220 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
221 redirect the browser to the Builder page
223 2007-09-26 Brian Warner <warner@lothar.com>
225 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
226 problem with the build links
228 2007-09-25 Brian Warner <warner@lothar.com>
230 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
231 to emit relative URLs instead of using URLPath,
233 * docs/buildbot.texinfo (WebStatus): provide an example
235 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
236 page, shows a simple table with one row per Builder. Still pretty
237 ugly, but functional.
238 * buildbot/status/web/index.html: reference it
240 * buildbot/status/web/waterfall.py (Spacer): make this *not*
241 inherit from builder.Event, so that show_events=false doesn't hide
242 spacers, since that would make the waterfall weirdly compressed.
244 * buildbot/status/web/waterfall.py (HELP): put the View button in
245 its own section, so it doesn't get visually confused with the
247 (WaterfallStatusResource.body): make the '[help]' links more
248 visually distinct from each other, and add a link to the Welcome
250 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
251 unused buildslaves without exploding
253 * buildbot/status/web/waterfall.py
254 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
255 it gives us absolute paths that break proxies
256 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
257 this, it was giving bad results when the Waterfall is behind a
260 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
261 new 'upgrade-master' command, which will bring an old buildmaster
262 directory up-to-date. Right now the only thing it does is populate
263 public_html/ if it wasn't already there. Still to do: check the
264 other files, add documentation.
265 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
266 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
268 2007-08-13 Brian Warner <warner@lothar.com>
270 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
271 that contains the checkin comments when you hover over the entry
272 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
275 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
278 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
279 page with versions of python, buildbot, and twisted
280 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
281 * buildbot/status/web/index.html: add links to most pages
282 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
284 * buildbot/status/web/robots.txt: put a robots.txt in new installs
285 which discourages robot access to all large dynamically-generated
286 pages. The intention is that the index page and the 'about' page
287 are the only ones which should be crawlable.
288 * buildbot/scripts/runner.py (Maker.public_html): same
290 * setup.py: ship index.html and robots.txt in source distributions
292 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
293 activate automatic reloading of the page (using a meta Refresh:
295 (WaterfallHelp): new page to explain all the nifty query arguments
296 you can use on the Waterfall, along with forms to set them for
297 you. From this page, you can add filters for builder=, branch=,
298 show_events=, as well as turning on reload=.
299 (WaterfallStatusResource.buildGrid): new query args: last_time=,
300 first_time=, show_time=, num_events= . The old show= is still
301 accepted, but the new builder= is preferred. We ignore empty
302 branch= arguments, to make the WaterfallHelp form easier to
304 (WaterfallStatusResource.head): new method to add text to the
306 * buildbot/status/web/base.py (HtmlResource.content): use head()
307 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
308 empty branch= arguments
309 (OneLinePerBuildOneBuilder.body): same
311 2007-08-12 Brian Warner <warner@lothar.com>
313 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
314 new query args: 'last_time' is a timestamp of the top-most event
315 on the display, 'first_time' is a timestamp for the bottom-most
316 event. 'show_time' is the difference between them, and overrides
317 'first_time'. 'num_events' puts an upper limit on the number of
318 timestamps that will be displayed on the left hand edge.
319 (WaterfallStatusResource.body): add a 'next page' link to the
320 bottom, which shows the events that come just after those shown on
321 the current page. This is a first step towards #67, but we need
322 some more controls before we can close that one.
324 * buildbot/buildslave.py (BuildSlave): these are now MultiService
325 instances too, and live as children of the BotMaster. The main
326 advantage of this approach is that BuildSlaves can know when they
327 are being removed (so they can shut off the upcoming
328 when-do-we-email-an-admin-because-we-lost-our-slave timer).
329 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
330 identify which service children are BuildSlaves
331 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
332 Checker updates here, but delegate the rest to..
333 (BotMaster.loadConfig_Slaves): .. here, which looks at the
334 BotMaster's service children to identify the old slaves. I think
335 the previous approach of using master.slaves was broken in the
336 face of config updates that modified BuildSlave instances but did
337 not completely replace them.
338 * docs/buildbot.texinfo (Developer's Appendix): note the change to
339 the Service hierarchy
341 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
342 page (at URL /buildslaves/) to view status of all buildslaves at
343 once, including how long it's been since we last heard from them,
344 and which Builders use them.
346 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
349 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
352 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
353 use the BuildSlave to keep track of the last time we've heard from
354 the buildslave. This is updated upon receipt of any message from
355 any SlaveBuilder (which generally means when RemoteCommands are
356 giving us status updates, as BuildSteps run). In the future this
357 will include slave pings too.
358 * buildbot/process/base.py
359 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
360 * buildbot/process/buildstep.py:
361 (BuildStep.setBuildSlave): accept that reference
362 (BuildStep.runCommand): pass the reference on to the RemoteCommand
363 (RemoteCommand.remote_update): update the timestamp
364 (RemoteCommand.remote_complete): same
365 * buildbot/test/runutils.py (StepTester.makeStep): match the change
366 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
367 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
368 interface to retrieve this timestamp
369 * buildbot/status/builder.py (SlaveStatus): track a copy of the
373 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
375 (OneLinePerBuild.body): use a <ul> instead of <div>s
376 (OneLinePerBuildOneBuilder.body): same
378 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
379 by adding the file's new name to the list of changed files. This
380 ought to be sufficient for things like isFileImportant and trial
381 tests that only exercise tests for files that have been modified.
384 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
385 XMLRPC server to the WebStatus page. This only has two methods
386 right now (getAllBuildsInInterval and getBuild), but we'll be
387 adding more in the future. This server is extracted from the
390 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
391 generateFinishedBuilds, and improve the data displayed.
392 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
393 the per-Build page, add some information like ETA and got_revision
394 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
395 adding a list of recently completed builds
396 * buildbot/status/web/base.py (css_classes): factor this out
398 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
399 new method, to make status display classes easier to write,
400 especially the WebStatus 'one_line_per_build' page.
401 (IBuilderStatus.generateFinishedBuilds): same
402 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
403 (Status.generateFinishedBuilds): implement it
405 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
406 'source' to be a BuildStep instance, since BuildFactory accepts
408 (CPAN.__init__): same
409 (Distutils.__init__): same
410 (Trial.__init__): same
412 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
413 this might raise KeyError
415 2007-08-07 Brian Warner <warner@lothar.com>
417 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
418 'Owner:' field of the view, rather than 'p4logname', since
419 p4logname comes from the buildslave's environment and seems
420 unlikely to ever do the right thing. Thanks to Wade Brainerd for
421 the patch. Closes #40.
423 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
424 which imposes a per-slave limit on how many builds are allowed to
425 run simultaneously. This has a the same scope than the SlaveLock,
426 but is different because max_builds= gives the buildmaster the
427 freedom to assign the build to a different slave, whereas the
428 SlaveLock doesn't get tested until after the build is irrevocably
429 assigned to a slave. Therefore using max_builds= will improve
430 utilization in the presence of multiple buildslaves that are
431 attached to the same Builder. This completes the incorporation of
432 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
433 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
434 any Builder finishes, potentially trigger *all* Builders, since
435 max_builds= may have stalled someone else while waiting for the
437 * buildbot/scripts/sample.cfg: mention max_builds=
438 * buildbot/test/test_run.py (ConcurrencyLimit): test it
439 * docs/buildbot.texinfo (Buildslave Specifiers): document it
441 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
442 inherit from RunMixin do not need to call master.stopService()
443 themselves, since RunMixin.tearDown does that. The double call
444 fails on Twisted-2.0.x, which didn't happen to protect against it.
445 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
447 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
448 from #48, this one to have the BuildSlave objects track
449 SlaveBuilders, so they'll be able to use that knowledge to
450 influence their canStartBuild() response.
451 * buildbot/process/builder.py (SlaveBuilder.attached): call it
452 (SlaveBuilder.detached): same
453 * buildbot/test/test_slaves.py (BuildSlave): test it
455 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
456 the second of Dustin's #48 patches, this one adding a method to
457 the BuildSlave that allows it to decide whether it is willing to
458 participate in a build or not.
459 (SlaveBuilder.isAvailable): use canStartBuild() to decide
461 * buildbot/test/test_run.py (CanStartBuild): test for it
463 * all: incorporate the first of four patches by Dustin Mitchell
464 from ticket #48, working towards improving control over slave
465 concurrency. The first patch is to use a long-lived BuildSlave
466 object per slave, on which other behavior can be added later. I've
467 modified his patch considerably.
468 * buildbot/buildslave.py (BuildSlave): move class out of
469 slave/__init__.py (where it would get loaded by the slave as well
470 as the master, making dependencies trickier), and merge it with
471 BotPerspective. Now these BuildSlave instances are created once in
472 the master.cfg file, and not destroyed until they are either
473 removed from the config file or changed so
474 much (name/password/class changes) that we cannot continue to use
475 the old one. This affects config files: they must use
476 'from buildbot.buildslave import BuildSlave' instead of using
477 'from buildbot.slave import BuildSlave'.
478 * buildbot/master.py: move BotPerspective out
479 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
480 add or remove as necessary, update the rest using data from
482 * buildbot/slave/__init__.py: move BuildSlave out
483 * buildbot/test/test*.py: import BuildSlave from the new place
484 * buildbot/scripts/sample.cfg: update to match
485 * docs/buildbot.texinfo: update to match
486 * buildbot/process/builder.py: update comments to match
488 2007-08-02 Brian Warner <warner@lothar.com>
490 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
491 one-line-per-build pages a bit, add a header, refactor slightly
493 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
494 the TimeOutError timer, patch by Dustin Mitchell.
496 2007-08-01 Brian Warner <warner@lothar.com>
498 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
499 mostly work (branch= is still ignored, we need a useful header)
500 (OneLinePerBuildOneBuilder.body): this too
502 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
503 bring this up-to-date w.r.t. recent refactorings, and fix
504 redirections to bounce the browser to the top page after hitting
505 the 'force' button. This needs to be improved, but at least it now
506 redirects to a valid page.
507 (StatusResourceBuilder.ping): same
508 (StatusResourceBuilder.getChild): same, although I think this code
509 might be dead anyways
511 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
512 a branch= query argument, to filter the display down to builds and
513 changes that involve the given branch. You can add multiple
514 branch= arguments to see multiple branches (using a logical OR).
515 Note that there is no way to include the default branch (i.e.
516 None, i.e. trunk) yet, there is still work to be done to allow for
517 simple+uniform names of branches (i.e. removing the VC-specific
518 details of how branches are implemented, so calling the branch
519 'beta4' even though the SVN checkout step requires
521 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
522 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
523 * buildbot/interfaces.py (IEventSource.eventGenerator): same
524 * docs/buildbot.texinfo (Buildbot Web Resources): document it
526 * all: bring import statements up-to-date: don't import
527 __future__, assume cPickle and cStringIO are always available.
528 Also remove #!/usr/bin/python lines from non-scripts, my editor
529 has been a bit over-enthusiastic about stuffing them into new .py
532 * buildbot/status/web/index.html: put a link to the waterfall page
533 on the index, otherwise first-time users of WebStatus aren't going
534 to see anything very interesting.
536 * buildbot/interfaces.py (IEventSource): document this interface.
537 Thanks to Dustin Mitchell for the patch. Closes #60.
538 * buildbot/status/builder.py (BuilderStatus): same
539 * buildbot/changes/changes.py (ChangeMaster): same
541 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
542 add a query arg of 'show_events=true' to display non-build events,
543 like slaves attaching/detaching and reconfig events, or
544 'show_events=false' to hide them. The default is 'true'.
545 * docs/buildbot.texinfo (Buildbot Web Resources): document it
547 * web-parts: merge in web-parts branch. Lots of changes. The new
548 functionality is to add buildbot.status.html.WebStatus, which is a
549 superset of the Waterfall that adds new status pages and serves
550 regular files from BASEDIR/public_html/ , which is now the preferred
551 place to put robots.txt, buildbot.css, and index.html .
552 * buildbot/scripts/runner.py: the 'create-master' command now
553 creates public_html/ too, and populates it with a couple of
555 * buildbot/status/web: split waterfall code into smaller pieces
557 2007-07-31 Brian Warner <warner@lothar.com>
559 * buildbot/scripts/startup.py (launch): import twistd.run in a
560 different way to hush pyflakes
561 * buildbot/process/builder.py: remove unused import
563 2007-07-30 Brian Warner <warner@lothar.com>
565 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
566 Mitchell: pass SourceStamps around rather than branch/version/etc
567 tuples. Thanks Dustin! Closes #70.
568 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
569 tuple rather than a list, to avoid surprising mutations
570 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
571 * buildbot/status/mail.py (MailNotifier.buildMessage): same
572 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
573 * buildbot/test/test_status.py (Subscription): same
574 * buildbot/test/test_control.py (Force): same
575 * buildbot/test/test_buildreq.py (Request.testMerge): same
577 2007-07-29 Brian Warner <warner@lothar.com>
579 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
580 variable, since it wasn't used and is confusing in the presence of
581 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
584 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
585 the Buildbot home-page link to point at buildbot.net instead of
586 sourceforge, and add a current-version query parameter so we can
587 get some statistics on which versions are in use out there.
589 2007-07-28 Brian Warner <warner@lothar.com>
591 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
592 with c['change_source'], leaving c['sources'] for backwards
593 compatibility (but deprecated), scheduled for removal in 0.8.0
594 * docs/buildbot.texinfo: same
595 * buildbot/test/test_config.py: verify that c['sources'] still works
596 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
597 * buildbot/scripts/sample.cfg: update to match
599 * buildbot/changes/mail.py (MaildirSource): parse with python's
600 stdlib 'email' module, which has been available since python2.2,
601 and drop use of the 'rfc822' module, which has been depreceated
603 * buildbot/test/test_maildir.py: same: use parse_file() not parse
605 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
606 this needs to match the renaming in test/mail/msg*
608 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
611 * buildbot/test/test_mailparse.py: rename sample emails a bit
612 * buildbot/test/mail/msg*: same
614 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
615 parser for the "commit-email.pl" script that is shipped with SVN,
616 written by Justin Mason. Thanks! Closes SF#1072845.
617 * buildbot/test/mail/svn-commit.*: sample messages
618 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
619 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
621 2007-07-27 Brian Warner <warner@lothar.com>
623 * buildbot/changes/mail.py: refactor: move parsing into a method
624 named 'parse', each parser type gets a separate subclass. Remove
625 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
626 to be a simple leading-substring match. Add a warning to the logs
627 if prefix= does not end in a slash, since that's probably a
628 mistake. Fix both places where a prefix= mismatch would skip all
629 subsequent files in the same email, instead of just skipping the
630 one that didn't match.
631 * buildbot/test/test_mailparse.py: match changes
633 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
634 docs on email-based ChangeSources
636 * docs/buildbot.texinfo (Getting Source Code Changes): move all
637 the changesource types up a level, removing the one-entry menu in
640 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
641 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
642 instances instead of tuples. Closes #63.
643 * buildbot/slave/__init__.py (BuildSlave): define marker class
644 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
645 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
646 * buildbot/test/test_*.py: update tests to match
647 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
648 the c['bots'] backwards-compatibility handler works
650 2007-07-26 Brian Warner <warner@lothar.com>
652 * buildbot/changes/hgbuildbot.py (hook): add an in-process
653 Mercurial change-sending hook, contributed by Frederic Leroy.
654 Thanks! Addresses #50.
655 * docs/buildbot.texinfo (MercurialHook): document it
657 * buildbot/changes/hgbuildbot.py: change the way imports are done,
658 to make it compatible with at least hg-0.9.1 and the current 0.9.4
660 2007-07-17 Brian Warner <warner@lothar.com>
662 * buildbot/process/buildstep.py (BuildStep.getLog): add a
663 convenience method to retrieve a log added with
664 addLog()/addCompleteLog()/etc or logfiles= . I should have added
667 2007-07-03 Brian Warner <warner@lothar.com>
669 * buildbot/slave/commands.py (ShellCommand._startCommand): when
670 logging the environment variables, put one variable on each line,
671 rather than having one really long line with all of them. This
672 should make them a bit more readable and not trigger the
673 horizontal scrollbar (when viewing it in a web browser) quite so
674 much. Thanks to Albert Hofkamp for the patch.
676 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
677 WithProperties instance. Thanks to Axel Hecht for the patch.
679 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
680 * docs/buildbot.texinfo (Build Properties): document it
681 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
682 workdir if it didn't already exist.
684 * docs/buildbot.texinfo (Scheduler Types): correct the description
685 of Dependent schedulers. Thanks to Greg Ward for the patch.
687 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
688 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
689 the patch. Closes #49.
691 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
692 0700 before removing it, to deal with situations where a build will
693 leave files around without write permissions and the 'copy' or
694 'clobber' VC checkout modes need to blow away the tree first.
695 Thanks to Steve Milner for the suggestion and the patch (which I
696 mangled horribly). Closes #29.
697 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
700 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
701 an allowReconnect= argument to let callers control whether they
702 want this don't-let-it-reconnect behavior, since some tests care.
703 Factor out the .continueTrying=False lines from those callers.
704 * buildbot/test/test_slaves.py: same
705 * buildbot/test/test_run.py: same
707 2007-07-02 Brian Warner <warner@lothar.com>
709 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
710 slave has been disappeared, don't let it reconnect. This was
711 causing an intermittent failure in test_slaves.py, when the slave
712 that was supposed to be gone managed to come back by the end of
713 the test and affect the count.
714 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
716 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
717 diagnostic messages to track down this problem
718 (Builder.startBuild): same
720 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
721 the slave randomly rather than always taking the first one. Thanks
722 to Pike for the patch. Closes #36.
723 * buildbot/test/test_slaves.py: match the change. to avoid huge
724 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
725 enables/disables the round-robin-ness (enabled by default), and
726 some unit tests disable it.
727 * docs/buildbot.texinfo (Buildmaster Architecture): document it
729 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
730 argument to 'buildmaster_host', to make it more obvious that this
731 points to the buildmaster. Thanks to Bob Proulx for the
733 * buildbot/scripts/runner.py (slaveTAC): same
734 * buildbot/test/test_runner.py (Create.testSlave): match the change
736 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
739 2007-06-17 Brian Warner <warner@lothar.com>
741 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
742 we can round-trip all of our current step classes by calling
743 getStepFactory() and using the results to make a clone of the
746 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
749 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
750 the config file, we're moving to using actual instances instead of
751 the (class, kwargs) 'step specification' tuples. BuildFactory
752 still keeps a list of tuples internally, but when real instances
753 are passed in to addStep(), they are asked for their class and
754 kwargs using the new BuildStep.getStepFactory method. BuildFactory
755 accepts both instances and the tuple form, and converts instances
756 to the tuple form, but the instance form is preferred because it
757 gives the Steps a chance to do argument validation. Closes: #11.
759 * buildbot/process/buildstep.py (BuildStep.__init__): record the
760 factory information necessary to implement getStepFactory. The
761 addFactoryArguments() method can be used to include arguments that
762 aren't passed to the BuildStep base class constructor.
763 (BuildStep.setBuild):
764 (BuildStep.setDefaultWorkdir): new methods to take parameters that
765 are needed for live BuildSteps but not to construct the specification
766 tuples that are stashed in the factory.
768 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
769 'workdir' into new BuildSteps by using methods instead of
770 arguments. This makes the constructor for BuildSteps a lot
773 * buildbot/steps/*.py: update to match this change. Basically this
774 means adding calls to addFactoryArguments() in the __init__
775 methods to capture the arguments that aren't passed through to the
777 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
778 the new workdir (if any) into the RemoteShellCommands arguments.
779 * buildbot/steps/source.py: allow workdir= to be optional,
780 implement setDefaultWorkdir() since we don't inherit from
781 (CVS): finally remove old clobber=/export=/copydir= arguments,
782 in favor of the mode= argument that's been around forever now.
783 * buildbot/steps/transfer.py: remove build= argument
785 * buildbot/test/*.py: update to match, generally by turning all
786 build= arguments into subsequent calls to s.setBuild()
787 * buildbot/test/test_config.py (Factories): verify that we can
788 use either BuildStep instances or class/kwarg tuples in both
789 BuildFactory.addStep and BuildFactory.__init__
791 * docs/buildbot.texinfo (Build Steps): document the new approach,
792 mention compatibility with the old approach, update all examples
793 to use the new style.
795 2007-06-16 Brian Warner <warner@lothar.com>
797 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
798 the LoopingCall, just eat the failure so that we'll poll again
799 next time. This should allow us to tolerate (e.g.) sf.net SVN
800 failures more gracefully. Many thanks to Dustin Mitchell for the
803 2007-05-17 Brian Warner <warner@lothar.com>
805 * buildbot/status/words.py: refactor the IRC status bot into
806 separate 'Contact' and 'Channel' classes. The base Contact class
807 contains the interaction code: commands and responses. The
808 IRCContact subclass (and IrcStatusBot 'Channel') handle the
809 IRC-specific aspects. The plan is to write other subclasses for
810 other IM protocols like AIM and Jabber.
812 2007-04-16 Brian Warner <warner@lothar.com>
814 * CREDITS: update list of contributors. Thank you all!
816 2007-04-13 Brian Warner <warner@lothar.com>
818 * buildbot/status/mail.py (MailNotifier): add the project name to
819 the subject line and message body, to make it easier to
820 distinguish email coming from different buildmasters. Thanks to
821 Benoit Sigoure for the patch.
822 * buildbot/test/test_status.py (Mail): update to match
824 2007-03-24 Brian Warner <warner@lothar.com>
826 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
827 avoid text-conversion problems between DOS/windows and unix.
828 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
830 2007-03-03 Brian Warner <warner@lothar.com>
832 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
833 warning about the use of Waterfall here
835 2007-03-01 Brian Warner <warner@lothar.com>
837 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
839 2007-02-28 Brian Warner <warner@lothar.com>
841 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
842 Lamb to use a more optimal form of 'p4 changes', to reduce server
843 load. He reports that this optimization was added to p4d release
844 2005.2, but it should work in all versions. Closes #27.
845 * buildbot/test/test_p4poller.py: match it
847 2007-02-27 Brian Warner <warner@lothar.com>
849 * buildbot/status/web/*.py: move all web status stuff into a
850 separate directory, in anticipation of splitting it into smaller
851 pieces and adding more files. html.py was getting way too big.
852 * buildbot/status/classic.css: move it too
853 * setup.py: add the new sub-package
854 * buildbot/test/test_web.py: match the changes
855 * MANIFEST.in: handle the move of classic.css
857 2007-02-07 Brian Warner <warner@lothar.com>
859 * contrib/OS-X/*: add some launchd .plist files for automatically
860 starting a buildmaster or buildslave under OS-X (10.4 or later).
861 Thanks to Mark Pauley for these.
863 2007-02-06 Brian Warner <warner@lothar.com>
865 * docs/buildbot.texinfo (Requirements): update requirements to
866 stop claiming compatibility with python-2.2 or twisted-1.3.x .
868 * README: mention python-2.5 and twisted-2.5 compatibility
870 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
872 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
874 * buildbot/status/builder.py: same, by requiring cStringIO
875 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
876 * buildbot/test/test_vc.py: same
877 * buildbot/test/test_web.py:
878 * buildbot/test/test_steps.py: same, remove unused import
880 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
883 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
884 see any Builders that don't have Schedulers to drive them
886 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
887 attributes this uses went away
889 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
890 dialog, to allow you to reset the buildmaster and force
891 connect/disconnect. Correctly handle losing the buildmaster
892 connection (by switching the display to the hexnut, at which point
893 you can use the 'Connect' menu item to reconnect).
895 * buildbot/steps/source.py (Source.start): if we're using a patch,
896 add it as a LogFile to the checkout/update step. This will turn
897 into a link on the waterfall page.
899 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
900 option, to take the patch from a pre-made file rather than
901 generating it from the local tree. Thanks to Robert Helmer for the
902 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
903 * buildbot/scripts/runner.py (TryOptions): add --diff,
904 --patchlevel, and --baserev options
905 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
906 as None, meaning HEAD.
907 * buildbot/sourcestamp.py (SourceStamp): update docstring to
908 indicate that baserev=None means HEAD
909 * docs/buildbot.texinfo (try --diff): document it
911 * buildbot/test/test_steps.py (BuildStep): remove use of
912 reactor.iterate(), although the technique I replaced it with is a
913 gross polling hack that must be cleaned up properly some day. This
914 was the last use of reactor.iterate in the entire tree, yay.
916 2007-02-05 Brian Warner <warner@lothar.com>
918 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
919 is one of the three known values, otherwise we emit some confusing
920 messages later on. Thanks to Grig Gheorghiu for the catch.
922 2007-01-30 Brian Warner <warner@lothar.com>
924 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
925 Hearsum contributed a patch to let BonsaiPoller work with results
926 that contain non-ascii characters. Closes SF#1632641.
928 2007-01-27 Brian Warner <warner@lothar.com>
930 * Makefile (release): produce both .tar.gz and .zip source bundles.
933 2007-01-23 Brian Warner <warner@lothar.com>
935 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
936 * buildbot/changes/monotone.py: same
938 * buildbot/changes/maildir.py: combine several files into one,
939 clean up maildir.py to use Services properly.
940 * buildbot/changes/maildirtwisted.py: remove
941 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
943 * buildbot/changes/mail.py: match the change
944 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
945 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
947 * buildbot/slave/commands.py (command_version): bump to "2.3" to
948 indicate that the buildslave knows about the 'bzr' command
950 2007-01-22 Brian Warner <warner@lothar.com>
952 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
953 'with', it will become a reserved work in python2.6 .
955 * contrib/bb_applet.py: add a simple gnome-panel applet, to
956 display a terse summary of buildbot status.
957 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
958 some icons, small versions of the Blender object that lives in
959 docs/images/icon.blend
961 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
962 * buildbot/slave/commands.py (Bzr): same
963 * buildbot/scripts/tryclient.py (BzrExtractor): same
964 (SourceStampExtractor.dovc): modify this to allow non-zero exit
965 status, since 'bzr diff' does that
966 * buildbot/test/test_vc.py (Bzr): same
967 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
971 2007-01-20 Brian Warner <warner@lothar.com>
973 * contrib/darcs_buildbot.py: tidy up the progress messages
975 2007-01-17 Brian Warner <warner@lothar.com>
977 * contrib/darcs_buildbot.py: enhance to handle multiple patches
978 being pushed at a time. This keeps state in the repository in a
979 small file named .darcs_buildbot-lastchange, but that shouldn't
980 interfere with normal repository operations. Fixes SF#1534049.
981 * buildbot/clients/sendchange.py (Sender): make a single Sender
982 capable of sending Changes with different usernames.
984 2006-12-11 Brian Warner <warner@lothar.com>
986 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
987 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
988 buildbot.changes.mail a long time ago, but I forgot to add the
989 DeprecationWarning until now.
991 * buildbot/process/maxq.py: remove this, the functionality now
992 lives in buildbot.steps.maxq
994 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
995 * buildbot/clients/gtkPanes.py: remove unused import
997 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
998 that was meant to provide a special Reporter to run inside trial
999 and give the buildslave lots of machine-readable status. We never
1000 finished this project.
1002 * buildbot/changes/bonsaipoller.py: remove unused imports
1003 * buildbot/changes/svnpoller.py: same
1004 * buildbot/process/builder.py: same
1005 * buildbot/process/buildstep.py: same
1006 * buildbot/slave/bot.py: hush pyflakes warning
1007 * buildbot/status/tests.py: remove unused imports
1008 * buildbot/status/tinderbox.py: same
1009 * buildbot/steps/python_twisted.py: same
1011 * buildbot/process/step.py: remove this file, these names were
1012 deprecated in 0.7.5 and are now being removed.
1013 * buildbot/process/step_twisted.py: same
1014 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1016 * buildbot/twcompat.py: remove the empty file, yay it is gone
1018 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1019 tw-2.0.0 and newer have the method we need.
1020 (getProcessOutputAndValue): same
1021 (which): remove this method, tw-2.0.0 t.p.procutils has it
1023 * buildbot/twcompat.py (implements): remove this method
1024 * buildbot/*: import implements() from zope.interface directly
1026 * buildbot/status/mail.py: stop falling back to importing
1027 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1030 * buildbot/twcompat.py (Interface): remove this import
1031 * buildbot/*: import Interface from zope.interface directly
1033 * buildbot/twcompat.py (providedBy): remove this method
1034 * buildbot/*: turn all uses of providedBy(obj, iface) into
1035 iface.providedBy(obj)
1037 * buildbot/twcompat.py (maybeWait): remove this method, now that
1038 we no longer maintain compatibility with Twisted<=1.3.0 .
1039 Twisted-2.0.0 and later allow trial methods to return Deferreds
1041 * buildbot/test/*: remove all uses of maybeWait
1043 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1045 * docs/buildbot.texinfo: same
1047 2006-12-10 Brian Warner <warner@lothar.com>
1049 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1050 * docs/buildbot.texinfo: set version to match
1052 2006-12-10 Brian Warner <warner@lothar.com>
1054 * README (REQUIREMENTS): update for release
1055 * NEWS: update for release
1056 * buildbot/slave/commands.py (command_version): mention that this
1057 version (2.2) was released with buildbot-0.7.5
1059 * buildbot/test/test_config.py (StartService.testStartService):
1060 inhibit the usual read-config-on-startup behavior, since otherwise
1061 the log.err that gets recorded causes the test to fail
1063 * buildbot/status/builder.py (LogFile.finish): forget about all
1064 subscribers once the log has finished, since after that point
1065 we're never going to use them again. This might help free up some
1068 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1069 than the old/deprecated gtk.mainquit()
1071 2006-12-09 Brian Warner <warner@lothar.com>
1073 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1074 better when we can't open the masterdst file
1076 * buildbot/scripts/startup.py (Follower._failure): add missing
1077 import statement for BuildSlaveDetectedError
1079 * buildbot/steps/transfer.py (FileUpload): cleanup
1080 (FileDownload): same. Add tests for slave version, add mode=.
1081 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1082 (SlaveFileDownloadCommand): same
1083 * buildbot/test/test_transfer.py: enhance tests
1084 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1087 2006-12-08 Brian Warner <warner@lothar.com>
1089 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1090 both success *and* failure. Without this, the 'buildbot
1091 sendchange' command would hang if it could not contact the
1092 buildmaster or deliver the Change, which would generally cause the
1093 user's commit/record/checkin command to hang too. Thanks to
1094 Christian Unger for the catch.
1096 2006-12-06 Brian Warner <warner@lothar.com>
1098 * NEWS: update with items for the next release
1100 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1101 whimsical example pulled from a punch-drunk email I sent out late
1103 (Transferring Files): document some of the other parameters
1104 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1105 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1106 * buildbot/test/test_svnpoller.py: same
1107 * buildbot/changes/svnpoller.py (SVNPoller): same
1109 2006-11-26 Brian Warner <warner@lothar.com>
1111 * docs/buildbot.texinfo (Build Properties): remind users that
1112 WithProperties must appear in a command= list, not as a top-level
1114 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1115 we're sending a list or a single string to the RemoteShellCommand
1117 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1119 * buildbot/scripts/startup.py (start): skip the whole
1120 watch-the-logfile thing under windows, since it needs os.fork()
1122 * buildbot/scripts/runner.py (restart): remove the old message
1123 that got printed after the buildbot was restarted.. it most cases
1124 it didn't get printed at the right time anyways
1126 2006-11-25 Brian Warner <warner@lothar.com>
1128 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1129 follow twistd.log and print lines until the process has started
1130 started properly. For the buildmaster, this means until the config
1131 file has been parsed and accepted. For the buildslave, this means
1132 until we've connected to the master. We give up after 5 seconds in
1133 any case. Helpful error messages and troubleshooting suggestions
1134 are printed when we don't see a successful startup. This closes the
1135 remainder of SF#1517975.
1136 * buildbot/scripts/startup.py: moved app startup code to here
1137 * buildbot/scripts/logwatcher.py: utility class to follow log
1138 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1139 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1140 so the LogWatcher can tell the difference between a buildmaster
1143 2006-11-24 Brian Warner <warner@lothar.com>
1145 * docs/examples/twisted_master.cfg: update to match the version
1146 in use on twistedmatrix.com
1147 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1148 was using before stopped working, but 'irc.freenode.net' works
1151 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1154 * buildbot/clients/base.py (TextClient.not_connected): upon
1155 UnauthorizedLogin failures, remind the user to connect to the
1156 PBListener port instead of the slaveport.
1157 (TextClient.disconnected): shut down more quietly
1158 * docs/buildbot.texinfo (statuslog): add another reminder
1160 * buildbot/scripts/runner.py (Options.subCommands): rename
1161 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1162 'sighup' as an alias.
1163 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1164 reconfig command to follow twistd.log and print all of the lines
1165 from the start of the config-file reload to its completion. This
1166 should make it a lot easier to discover bugs in the config file.
1167 Use --quiet to disable this behavior. This addresses half of
1168 SF#1517975, the other half will be to add this same utility to
1169 'buildbot start' and 'buildbot restart'.
1170 * docs/buildbot.texinfo (Loading the Config File): same
1173 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1174 method, it has been deprecated for a long time. Use
1175 IBuilderControl.requestBuild instead.
1176 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1177 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1178 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1179 * buildbot/test/test_control.py (Force.testForce): same
1180 * buildbot/test/test_run.py: use requestBuild instead
1182 * buildbot/clients/debug.py: replace 'Force Build' button with
1183 'Request Build' (which just adds one to the queue), add Ping
1184 Builder, add branch/revision fields to Request Build.
1185 * buildbot/clients/debug.glade: same
1186 * buildbot/master.py: update interface to match. This creates an
1187 incompatibility between new debugclients and old buildmasters.
1189 * buildbot/process/builder.py (Builder._attached): delay the call
1190 to maybeStartBuild for a reactor turn, to avoid starting a build
1191 in the middle of a reconfig (say, if the new Builder uses a new
1192 slave which is already connected).
1194 2006-11-23 Brian Warner <warner@lothar.com>
1196 * buildbot/test/test_transfer.py: appease pyflakes
1197 * buildbot/test/test_steps.py: same
1199 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1200 keeps pyflakes from finding undefined names
1202 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1203 Builder no longer induces a disconnect/reconnect cycle. This means
1204 that any builds currently in progress will not be interrupted, and
1205 any builds which are queued in the Builder will not be lost. This
1206 is implemented by having the new Builder extract the state (i.e.
1207 all pending Builds and any desired SlaveBuilders) from the old
1209 (BotPerspective): refactor. The BotPerspective no longer keeps
1210 track of all the Builders that want to use this slave; instead, it
1211 asks the BotMaster each time it needs this list. This removes
1212 addBuilder and removeBuilder. Clean up attached() to acquire all
1213 the slave's information in a more atomic fashion. updateSlave() is
1214 now the way to make sure the slave is using the right set of
1215 Builders: just call it after everything else has been
1217 (BotMaster): refactor, removing addBuilder/removeBuilder and
1218 replacing them with an all-at-once setBuilders() call.
1220 * buildbot/test/test_slaves.py (Reconfig): new test case to
1221 exercise this functionality
1222 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1223 * buildbot/slave/commands.py (WaitCommand): same
1225 * docs/buildbot.texinfo (Loading the Config File): document the
1228 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1229 SlaveBuilder to have its parent Builder changed.
1230 (SlaveBuilder.isAvailable): new method to give access to state,
1231 which is now a private attribute
1232 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1233 the SlaveBuilder about how it is being used. These methods update
1234 its internal state. buildFinished() is now the place that invokes
1235 maybeStartBuild() on its parent Builder.
1236 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1237 new Builder to take over for an old one, transferring state from
1239 (Buider): refactor the way that SlaveBuilders are used to match,
1240 giving them a bit more autonomy.
1241 (Builder.buildFinished): this no longer calls maybeStartBuild():
1242 instead the SlaveBuilder calls it on whoever its parent Builder is
1243 at the time. This way, when an old Builder is replaced by a new
1244 one, and there was a build in progress during the transition, when
1245 that build finishes, it will be the new Builder that is told about
1246 the newly available slave so it can start a new build.
1248 * buildbot/process/base.py (Build.startBuild._release_slave): when
1249 the Build finishes, tell the SlaveBuilder that they've been
1252 * buildbot/status/builder.py (SlaveStatus): add some new setter
1253 methods for use by BotPerspective, to keep some attributes more
1256 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1257 called by the buildmaster.
1258 (Bot.setBuilderList): instead, we locally announce any leftover
1259 directories based upon which Builders we were told about. The
1260 master doesn't really care; it's the local admin who may or may not
1261 wish to delete them.
1264 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1265 to allow use of python2.4 or whatever. This tool still requires
1268 2006-11-19 Brian Warner <warner@lothar.com>
1270 * NEWS (IStatusLog.readlines): more news items
1272 2006-11-18 Brian Warner <warner@lothar.com>
1274 * NEWS: start collecting items for the next release.
1276 2006-11-04 Brian Warner <warner@lothar.com>
1278 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1279 Hearsum. Closes SF#1590310.
1280 * buildbot/test/test_bonsaipoller.py: and tests
1282 * buildbot/status/tinderbox.py
1283 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1284 status when the build results in WARNINGS. Patch from Dave
1285 Liebreich. Closes SF#1587352.
1287 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1288 linux-vs-osx behavior difference w.r.t. reading from files that
1289 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1290 to Mark Rowe for the patch.
1292 2006-10-15 Brian Warner <warner@lothar.com>
1294 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1295 method name was misspelled in the interface definition. Thanks to
1296 Roy Rapoport for the catch.
1298 2006-10-13 Brian Warner <warner@lothar.com>
1300 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1301 to match the great Steps renaming
1303 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1304 Maybe I should run my own unit tests before recording a big
1305 change. Good thing I've got a buildbot to remind me.
1307 2006-10-12 Brian Warner <warner@lothar.com>
1309 * buildbot/steps/transfer.py: rework __init__ and args setup
1310 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1312 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1313 when opening the target file, only catch IOError (to report via
1314 stderr/rc!=0), let the others be reported as normal exceptions
1316 2006-10-08 Brian Warner <warner@lothar.com>
1318 * contrib/svn_watcher.py: fix security holes by using proper argv
1319 arrays and subprocess.Popen() rather than commands.getoutput().
1320 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1321 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1322 probably be removed by the next release.
1325 2006-10-04 Brian Warner <warner@lothar.com>
1327 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1328 initial lines that weren't emitted by pyflakes. When the pyflakes
1329 command is run under a Makefile, 'make' will echo the command it
1330 runs to stdio, and that was getting logged as a "misc" warning.
1331 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1332 * buildbot/test/test_steps.py (testPyFlakes3): another test
1334 2006-10-01 Brian Warner <warner@lothar.com>
1336 * buildbot/status/html.py (HtmlResource.render): if we get a
1337 unicode object from our content() method, encode it into utf-8
1338 like we've been claiming to all along. This allows the comments
1339 and author names from svnpoller.py to be delivered properly.
1341 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1342 de-unicodify filenames before creating the Change, because the
1343 rest of buildbot is unlikely to handle them well. Leave the 'who'
1344 field as a unicode object.. I don't think there's anything that
1345 will break very soon, and it will probably nudge us towards
1346 accepting unicode everywhere sooner or later. Stop using the
1347 "date" field that comes out of SVN, since it is using the
1348 repository's clock (and timezone) and what we care about is the
1349 buildmaster's (otherwise Changes from the future show up later
1350 than the builds they triggered).
1351 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1354 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1355 Suvbersion repository polling ChangeSource. I've hacked it up
1356 considerably: any bugs are entirely my own fault. Thank you
1358 * buildbot/test/test_svnpoller.py: tests for it
1359 * docs/buildbot.texinfo (SvnSource): document it
1361 2006-09-30 Brian Warner <warner@lothar.com>
1363 * buildbot/scheduler.py (Periodic): submit a reason= to the
1364 BuildSet to indicate which Scheduler triggered the build. Thanks
1365 to Mateusz Loskot for the suggestion.
1367 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1369 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1370 changes: set self.loop in __init__, remove unused volatile=
1372 * docs/buildbot.texinfo (.buildbot config directory): add more
1373 docs on the .buildbot/options keys used by "buildbot try"
1374 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1375 (Try.deliverJob): same
1377 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1379 (BonsaiPoller): same
1381 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1382 close the filehandle when we stop watching the file. Before, the
1383 filehandle was only closed when the LogFileWatcher was
1384 garbage-collected, which could be quite a while in the future. If
1385 it was still open by the time the next build started, windows will
1386 refuse to let the new build delete the old build/ directory. Fixes
1387 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1388 #twisted for the catch.
1390 2006-09-29 Brian Warner <warner@lothar.com>
1392 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1395 2006-09-25 Brian Warner <warner@lothar.com>
1397 * setup.py: the new buildbot.steps module wasn't being installed.
1398 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1399 (testmsgs): add the extra stuff from buildbot/test/* so you can
1400 run unit tests on an installed copy of buildbot, not just from
1403 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1404 columns of 'svnlook changed' output contain status information, so
1405 strip [:4] instead of [:6]. Depending upon what the status flags
1406 were, this would sometimes lead to mangled filenames. Thanks to
1407 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1409 * buildbot/steps/source.py (Monotone): initial Monotone support,
1410 contributed by Nathaniel Smith. Still needs docs and tests, but
1411 this code has been in use on the Monotone buildbot for a long
1413 * buildbot/slave/commands.py (Monotone): slave-side support
1414 * buildbot/changes/monotone.py (MonotoneSource): polling change
1417 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1418 contributed a Change Source that polls a Bonsai server (a
1419 kind of web-based viewcvs CGI script).
1421 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1422 Hearsum contributed a status plugin which sends email in the same
1423 format that Tinderbox does: this allows a number of tinderbox
1424 tools to be driven by Buildbot instead. Thanks Ben!
1426 2006-09-24 Brian Warner <warner@lothar.com>
1428 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1429 Thanks to Robert Helmer for the patch.
1431 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1432 BuildStatus about the buildslave name at the *beginning* of the
1433 build, rather than at the end. Thanks to Alexander Lorenz for the
1435 * buildbot/status/html.py (StatusResourceBuild.body): always
1436 include the slavename in the build page, not just when the build
1438 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1439 slavename in the email message
1441 2006-09-21 Brian Warner <warner@lothar.com>
1443 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1445 * docs/examples/glib_master.cfg: same
1446 * docs/examples/hello.cfg: same
1447 * docs/examples/twisted_master.cfg: same, update to current usage
1449 2006-09-19 Brian Warner <warner@lothar.com>
1451 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1452 (PyFlakes.createSummary): make it compatible with python-2.2
1454 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1455 for at least the output-parsing parts of PyFlakes
1457 2006-09-18 Brian Warner <warner@lothar.com>
1459 * buildbot/steps/python.py: oops, fix import of StringIO
1461 2006-09-17 Brian Warner <warner@lothar.com>
1463 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1464 turns out that SVN-1.4.0 doesn't fail to update once you've
1465 replaced a file with a directory, unlike older versions of SVN and
1466 pretty much every other VC tool we support. Since what we really
1467 care about is that the update succeeds anyway, stop checking that
1468 the tree got clobbered and just assert that the build succeeded.
1469 (VCBase.printLogs): add a utility function for debugging
1471 * buildbot/process/step.py: oops, added extra imports by mistake
1473 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1474 rstrip() on the first line coming out of the 'p4 describe'
1475 process, to remove the stray ^M that Wade Brainerd reports seeing
1476 in the 'when' field. Fixes SF#1555985.
1478 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1479 message logged when c['schedulers'] is not right
1480 * buildbot/scheduler.py (Scheduler.__init__): improve error
1481 message when a Scheduler() is created with the wrong arguments
1482 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1483 verify that these error messages are emitted
1485 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1486 The idea is that all the base classes (like BuildStep and
1487 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1488 will be a leftover backwards-compatibility file that only contains
1489 aliases for the steps that were moved out to buildbot.steps.*
1490 * lots: change imports to match
1491 * buildbot/process/step.py: add a DeprecationWarning if it ever
1494 2006-09-12 Brian Warner <warner@lothar.com>
1496 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1497 builderNames= is actually a sequence, since if you happen to give
1498 it a single builder-specification dictionary instead, it won't get
1499 caught by the existing assert. Thanks to Brett Neely for the
1502 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1504 * docs/buildbot.texinfo (Python BuildSteps): document them
1505 (sendchange): include a link to PBChangeSource, since you need one
1507 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1509 * buildbot/steps/dummy.py: same
1511 2006-09-08 Brian Warner <warner@lothar.com>
1513 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1514 BuildStep which lets you transfer files from the master to the
1515 slave or vice versa. Thanks to Albert Hofkamp for the original
1516 patch. Fixes SF#1504631.
1517 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1519 (SlaveFileDownloadCommand): same
1520 * docs/buildbot.texinfo (Transferring Files): document it
1521 * buildbot/test/test_transfer.py: test it
1522 * buildbot/test/runutils.py (StepTester): new utility class for
1523 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1524 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1527 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1528 walk through StatusLogs one line at a time, mostly for the benefit
1529 of ShellCommand.createSummary methods. You can either walk through
1530 STDOUT or STDERR, but the default is STDOUT.
1532 * buildbot/status/builder.py (LogFile.readlines): implement it.
1533 Note that this is not yet memory-efficient, it just pulls the
1534 whole file into RAM and then splits it up with a StringIO.
1535 Eventually this should be a generator that only pulls chunks from
1537 * buildbot/test/test_status.py (Log.testReadlines): test it
1539 * docs/buildbot.texinfo: update to match changes
1540 * buildbot/process/factory.py: stop using old definitions
1541 * buildbot/process/process_twisted.py: same
1542 * buildbot/test/test_*.py: same
1544 * buildbot/process/step_twisted.py: move definition to..
1545 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1546 relative-import mechanisms prevent this from being named 'twisted'
1547 or 'python/twisted' as I would have preferred.
1549 * buildbot/process/maxq.py: move definition to..
1550 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1552 * buildbot/process/step.py: split the user-visible BuildSteps into
1553 separate files, all under buildbot/steps/
1554 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1555 * buildbot/steps/shell.py: this holds ShellCommand and friends
1556 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1558 2006-09-05 Brian Warner <warner@lothar.com>
1560 * lots: run pyflakes, removed a lot of unused imports, changed the
1561 form of some conditional imports to remove false pyflakes
1562 warnings. There are still a number of warnings left, mostly from
1563 imports that are done for their side-effects.
1564 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1567 2006-08-26 Brian Warner <warner@lothar.com>
1569 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1570 compatible with twisted-1.3.0, for some reason I just can't seem
1571 to let go of the past.
1573 2006-08-25 Brian Warner <warner@lothar.com>
1575 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1577 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1578 all logfiles= in startCommand(), rather than in start() . This
1579 makes it easier to have the 'stdio' log come before any secondary
1580 logfiles, which I feel makes the waterfall display more
1582 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1583 from ShellCommand up into LoggingBuildStep
1584 (LoggingBuildStep.__init__): move the handling of logfiles= from
1585 ShellCommand up to LoggingBuildStep, because startCommand is
1586 provided by LoggingBuildStep, whereas start() was specific to
1587 subclasses like ShellCommand and Source. This removes code
1588 duplication in those subclasses.
1589 (ShellCommand.__init__): same
1590 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1591 for a slave that's too old to understand logfiles= into a separate
1592 method, so it can live in ShellCommand. The rest of
1593 setupLogfiles() can live in LoggingBuildStep.
1595 2006-08-24 Brian Warner <warner@lothar.com>
1597 * buildbot/locks.py (BaseLock): you can now configure Locks to
1598 allow multiple simultaneous owners. They still default to
1599 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1601 * docs/buildbot.texinfo (Interlocks): document the new options
1602 * buildbot/test/test_locks.py: add a bunch of new unit tests
1603 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1604 waitUntilMaybeAvailable, not waitUntilAvailable
1605 * buildbot/process/step.py (BuildStep.acquireLocks): same
1606 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1607 the whole lockid in their constructor, not just the name. Also,
1608 keep track of which real locks we've handed out by the full
1609 lockid, not just class+name, otherwise changing just the maxCount=
1610 in the master.cfg file would not actually cause a behavioral
1613 2006-08-23 Brian Warner <warner@lothar.com>
1615 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1617 * docs/buildbot.texinfo: same
1619 2006-08-23 Brian Warner <warner@lothar.com>
1621 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1622 * docs/buildbot.texinfo: set version to match
1623 * NEWS: update for 0.7.4
1624 * buildbot/slave/commands.py (command_version): mention that this
1625 version (2.1) was released with buildbot-0.7.4
1627 2006-08-22 Brian Warner <warner@lothar.com>
1631 * CREDITS: new file, list of people who have helped. Thanks!
1632 * MANIFEST.in: ship it
1634 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1635 new diagrams, the user's manual is more informative than it was.
1636 Start shipping the .html user's manual (and generated .png
1638 * Makefile: update 'release' target to match
1640 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1641 test.. I think the web-parts effort will render it pointless well
1642 before it ever actually starts to work.
1644 2006-08-20 Brian Warner <warner@lothar.com>
1646 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1647 meaning of the prefix= argument. It is now just a string which is
1648 stripped from the beginning of the filename. If prefix= is set but
1649 not found on any given filename, that filename is ignored. If all
1650 filenames in a Change are ignored, the Change is dropped. This is
1651 much simpler than the previous sep= nonsense, and I should have
1652 implemented it this way from the beginning. Effectively resolves
1653 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1654 Gedminas for the catch and suggested fixes.
1655 (ChangePerspective.perspective_addChange): implement the actual
1657 * buildbot/test/test_changes.py (TestChangePerspective): test it
1658 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1659 how to properly use prefix=
1660 * docs/examples/twisted_master.cfg (source): update prefix= by
1661 adding the trailing slash
1664 * docs/examples/twisted_master.cfg: update to actual practice
1666 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1667 update test case to match new link text.. the HREF has both a
1668 class= setting and an enclosing [] pair that I didn't match in the
1671 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1672 list of strings is preferred over a single string with embedded
1674 (ShellCommand.description=): explain that either single strings or
1675 a list of strings is acceptable, and why you might prefer one over
1676 the other. Add an example. Fixes SF#1524659, thanks to Paul
1677 Winkler for the catch.
1678 (Build Steps): update to use f.addStep() rather than using s()
1679 and the constructor list
1681 * buildbot/process/step.py (ShellCommand): accept either a single
1682 string or a list of strings in both description= and
1684 * buildbot/test/test_steps.py (Steps.test_description): test it
1685 * buildbot/test/runutils.py (makeBuildStep): support for that test
1687 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1688 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1689 collecting the files and creating the patch.
1691 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1692 per-step URLs that will be displayed on the waterfall display,
1693 for things like the HTML output of code-coverage tools, when
1694 the results are hosted elsewhere.
1695 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1696 way to retrieve these URLs
1697 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1698 the method to retrieve these URLs. Also provide backwards
1699 compatibility for saved BuildStepStatus instances that didn't have
1701 * buildbot/process/step.py (BuildStep.addURL): method to set these
1702 URLs from within a BuildStep
1703 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1704 (StepBox.getBox): give these external links a distinct CSS class
1705 named "BuildStep external" so a .css file can display them
1708 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1710 * buildbot/test/test_steps.py (Steps): test that we can all the
1711 URLs. Also add a bunch of other tests on methods that can be
1712 called from within BuildSteps
1713 * buildbot/test/runutils.py (makeBuildStep): add utility function
1715 2006-08-13 Brian Warner <warner@lothar.com>
1717 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1719 2006-08-10 Brian Warner <warner@lothar.com>
1721 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1722 index, this one of things like c['sources'] and c['schedulers']
1723 (indices): it looks like my clever idea of putting the @fooindex
1724 commands in between the @node and the @subsection (to make the
1725 HREF anchor jump to slightly above the section title, which works
1726 much better in html) confused texinfo horribly, so I'm moving the
1727 index tags back to be just after the @subsection marker. I also
1728 added extra lines between the @node/@section paragraph and the
1729 index tags, since I think maybe texinfo wants to see these be
1730 separate paragraphs.
1732 * docs/Makefile (images): make sure images get built when
1733 rendering the manual
1734 * docs/images/Makefile: same
1736 * buildbot/scripts/runner.py: rename 'buildbot master' to
1737 'buildbot create-master', and 'buildbot slave' to 'buildbot
1739 * docs/buildbot.texinfo: same
1742 * docs/buildbot.texinfo: reimplement the "useful classes" index
1743 with actual texinfo indices. The .info rendering is a bit
1744 weird-looking but it works well, and the HTML rendering is quite
1745 nice. This also puts the index targets in the regular flow of the
1746 text, which is easier to maintain.
1748 2006-08-06 Brian Warner <warner@lothar.com>
1750 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1751 Kevin Turner to prefer the environ= argument be a list rather than
1752 a string. If it is a list, it will be joined with a platform-local
1753 os.pathsep delimiter, and then prepended to any existing
1754 $PYTHONPATH value. This works better in cross-platform (i.e.
1755 windows buildslaves) environments when you need to push multiple
1756 directories onto the front of the path.
1757 (SlaveShellCommand): documented the new magic
1758 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1759 in a user-visible form
1761 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1762 Turner to prefer lists over strings when creating/running VC
1763 commands during unit tests. This is clearly necessary to survive
1764 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1765 renamed the wq() function to qw() though, since that's how it's
1766 spelled in perl. Eventually I'd prefer all commands to be
1767 specified with lists.
1769 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1770 which are deleted (or not yet created) correctly. Also add
1771 failsafe code to not explode if the file-watching poller doesn't
1772 get started. Thanks to JP Calderone for the catch and the poller
1774 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1776 * buildbot/test/emitlogs.py: same
1778 * NEWS: summarize recent changes
1780 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1781 clause to avoid the "host key mismatch" warning
1783 * buildbot/process/step_twisted.py (Trial.start): if the
1784 buildslave is too old to understand logfiles=, fall back to
1785 running 'cat _trial_temp/test.log' like before.
1786 (Trial.commandComplete): same. this takes advantage of the
1787 LoggingBuildStep refactoring to stall commandComplete long enough
1788 to run a second RemoteShellCommand.
1790 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1791 refactor command-completion handling, to allow methods like
1792 commandComplete/createSummary/evaluateCommand to return Deferreds.
1793 (LoggingBuildStep._commandComplete): delete the refactored method
1794 (ShellCommand.setupLogfiles): if the buildslave is too old to
1795 understand logfiles=, put a warning message both into twistd.log
1796 and into the otherwise empty user-visible LogFiles.
1798 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1799 callers to provide the slave-side logfile name, rather than
1800 forcing it to come from the local name of the LogFile.
1801 (BuildStep.getSlaveName): new method
1803 * buildbot/process/base.py (Build.getSlaveName): new method, so
1804 steps can find out which buildslave they're running on
1806 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1807 to match the s/cvs_ver/command_version/ change
1809 2006-08-05 Brian Warner <warner@lothar.com>
1811 * buildbot/slave/commands.py (command_version): replace the CVS
1812 auto-updated cvs_ver keyword with a manually-updated variable,
1813 since CVS is no longer the master repository. Add a description of
1814 the remote API change starting in this version (2.1), specifically
1815 the fact that SlaveShellCommand now accepts 'initial_stdin',
1816 'keep_stdin_open', and 'logfiles'.
1818 2006-07-31 Brian Warner <warner@lothar.com>
1820 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1821 diagrams to describe how the whole system fits together. The
1822 images themselves are kept in SVG files, with ascii-art versions
1823 in corresponding .txt files. Texinfo knows how to interpolate the
1824 text version into .info files, reference the .png versions from
1825 .html files, and include .eps versions in the .ps format.
1826 * docs/images/Makefile: tools to create .png and .eps
1827 * docs/images/*.svg: created pictures with Inkscape.
1828 * .darcs-boring: ignore the generated .eps and .png files
1830 2006-07-24 Brian Warner <warner@lothar.com>
1832 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1833 Scheduler names, since they cause setServiceParent to explode
1835 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1837 2006-07-20 Brian Warner <warner@lothar.com>
1839 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1840 which runs the buildbot unit tests
1842 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1843 classes that are useful in master.cfg
1845 2006-07-15 Brian Warner <warner@lothar.com>
1847 * Makefile (some-apidocs): new target to build only some epydocs
1849 * setup.py: minor comment.. does the classifiers= argument prevent
1850 the setup.py script from working on python2.2/2.3?
1852 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1855 * buildbot/twcompat.py: fix minor typo in comments
1857 * buildbot/manhole.py: move all Manhole-related code out to this
1858 module. Implement SSH-based manholes (with TwistedConch), and move
1859 to conch's nifty line-editing syntax-coloring REPL shell instead
1860 of the boring non-editing monochromatic (and deprecated) old
1862 * buildbot/master.py: remove all Manhole-related code
1863 (BuildMaster.loadConfig._add): make sure the old manhole is
1864 removed before we add the new one
1865 * docs/buildbot.texinfo (Debug options): document new Manhole options
1867 * buildbot/twcompat.py (_which): fix some epydoc issues
1868 * buildbot/status/html.py (Waterfall.__init__): same
1870 2006-06-29 Brian Warner <warner@lothar.com>
1872 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1873 deprecation warnings under newer Twisteds (by using
1874 zope.interface.Interface instead of old twisted.python.components
1876 * buildbot/slave/interfaces.py: same
1878 2006-06-28 Brian Warner <warner@lothar.com>
1880 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1881 svn commands, so it will fail immediately instead of hanging while
1882 it waits for a username/password to be typed in.
1884 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1885 log message if the step was shut down
1887 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1888 obsolete reference to mktap.
1890 2006-06-20 Brian Warner <warner@lothar.com>
1892 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1893 test to include new 'logfiles' argument sent from master to slave
1895 2006-06-19 Brian Warner <warner@lothar.com>
1897 * buildbot/process/step_twisted.py (Trial): track Progress from
1898 _trial_temp/test.log too
1900 * buildbot/process/step.py (OutputProgressObserver): generalize
1901 the earlier StdioProgressObserver into an OutputProgressObserver
1902 that can track LogFiles other than stdio.
1903 (LoggingBuildStep.__init__): same
1905 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1906 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1907 will fail under windows because of os.sep issues. It might have
1908 worked before if 'cat' was doing cygwin path conversion.
1910 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1911 creation of LogFileWatchers
1912 (ShellCommand._startCommand): and record the files that were
1913 watched in the 'headers' section of the ShellCommand output
1915 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1916 need to actually pass it to the slave if you want it to work.
1917 (ShellCommand): document it a bit
1919 * buildbot/test/test_shell.py: new test to validate LogFiles
1920 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1922 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1923 before printing the last batch of lines, to test that the polling
1924 logic is working properly
1926 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1927 handling, making it possible to track multiple logs for a single
1928 RemoteCommand. The previous single logfile is now known as the
1930 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1931 (RemoteShellCommand.__init__): accept logfiles=
1932 (LoggingBuildStep.startCommand): stdio_log is now one of many
1933 (ShellCommand): added logfiles= argument, as well as a class-level
1934 .logfiles attribute, which will be merged together to figure out
1935 which logfiles should be tracked. The latter maybe be useful for
1936 subclasses of ShellCommand which know they will aways produce
1937 secondary logfiles in the same location.
1939 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1940 and closeStdin() methods, preparing to make it possible to write
1941 to a ShellCommand's stdin at any time, not just at startup. These
1942 writes are buffered if the child process hasn't started yet.
1943 (LogFileWatcher): new helper class to watch arbitrary logfiles
1944 while a ShellCommand runs. This class polls the file every two
1945 seconds, and sends back 10k chunks to the buildmaster.
1946 (ShellCommand): rename stdin= to initialStdin=, and add
1947 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1949 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1950 key of "log" and a value of (logname, data).
1951 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1952 'logfiles' to the master-visible args dictionary.
1953 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1956 * buildbot/test/test_vc.py (Patch.testPatch): same
1959 * buildbot/test/emit.py: write to a logfile in the current
1960 directory. We use this to figure out what was used as a basedir
1961 rather than looking to see which copy of emit.py gets run, so that
1962 we can run the commands from inside _trial_temp rather than inside
1964 * buildbot/test/subdir/emit.py: same
1965 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1966 argument rather than running from buildbot/test/
1967 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1968 rather than using an implicit setUp()
1969 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1970 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1971 of assuming that we're running in buildbot/test/ (and that '.' is
1974 * buildbot/slave/commands.py (Command.doStart): refactor Command
1975 startup/completion a bit: now the SlaveBuilder calls doStart(),
1976 which is not meant for overridding by subclasses, and doStart()
1977 calls start(), which is. Likewise the SlaveBuilder calls
1978 doInterrupt(), and subclasses override interrupt(). This also puts
1979 responsibility for maintaining .running in Command rather than in
1981 (Command.doInterrupt): same
1982 (Command.commandComplete): same, this is called when the deferred
1983 returned by start() completes.
1984 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1985 (SlaveBuilder.remote_interruptCommand): same
1986 (SlaveBuilder.stopCommand): same
1988 2006-06-16 Brian Warner <warner@lothar.com>
1990 * buildbot/test/test_shell.py: new test file to contain everything
1991 relating to ShellCommand
1992 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1993 multiple logfiles in realtime" feature, not yet implemented
1994 * buildbot/test/emitlogs.py: support file for testLogFiles
1995 * docs/buildbot.texinfo (ShellCommand): document the feature
1997 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1999 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2000 for tests which exercise SlaveCommands in isolation.
2002 * buildbot/test/test_slavecommand.py: Move some utilities like
2003 SignalMixin and FakeSlaveBuilder from here ..
2004 * buildbot/test/runutils.py: .. to here, so they can be used by
2005 other test classes too
2006 * buildbot/test/test_vc.py: more SignalMixin refactoring
2007 * buildbot/test/test_control.py: same
2008 * buildbot/test/test_run.py: and some rmtree refactoring
2010 2006-06-15 Brian Warner <warner@lothar.com>
2012 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2013 'testBranch' to match other VC tests and have the tests run in
2014 roughly increasing order of dependency
2016 * buildbot/test/test_steps.py (LogObserver): new test to verify
2017 LogObservers can be created at various times and still get
2018 connected up properly
2020 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2021 to create BuildStepStatus instances that actually work.
2023 * buildbot/process/step.py (LogObserver): add outReceived and
2024 errReceived base methods, to be overridden
2026 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2027 API to take a name instead of a step, reducing the coupling
2028 somewhat. This returns the BuildStepStatus object so it can be
2029 passed to the new Step, instead of jamming it directly into the
2031 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2033 * buildbot/process/base.py (Build.setupBuild): use both methods
2034 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2035 process a bit to match
2037 2006-06-14 Brian Warner <warner@lothar.com>
2039 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2040 docs on writing new LogObserver classes
2041 (Writing New Status Plugins): brief docs on how Status Plugins fit
2044 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2045 implement a LogObserver that counts how many unit tests have been
2047 (Trial.__init__): wire it in
2048 * buildbot/test/test_twisted.py (Counter): unit test for it
2050 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2051 to new cmd.logs['stdio'] scheme
2052 (Trial.commandComplete): same
2053 (BuildDebs.commandComplete): same
2055 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2056 LogFiles, instead of just a single one. The old single logfile is
2057 now called "stdio". LoggedRemoteCommand no longer creates a
2058 LogFile for you (the code to do that was broken anyway). If you
2059 don't create a "stdio" LogFile, then stdout/stderr will be
2061 (LogObserver): implement "LogObservers", which a BuildStep can add
2062 to parse the output of a command in real-time. The primary use is
2063 to provide more useful information to the Progress code, allowing
2064 better ETA estimates.
2065 (LogLineObserver): utility subclass which feeds complete lines to
2066 the parser instead of bytes.
2067 (BuildStep.progressMetrics): this is safer as a tuple
2068 (BuildStep.setProgress): utility method, meant to be called by
2070 (BuildStep.addLogObserver): new method, to be called at any time
2071 during the BuildStep (even before any LogFiles have been created),
2072 to attach (or schedule for eventual attachment) a LogObserver to a
2074 (StdioProgressObserver): new LogObserver which replaces the old
2075 "output" progress gatherer
2076 (LoggingBuildStep.__init__): same
2077 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2078 (LoggingBuildStep._commandComplete): must use logs['stdio']
2079 instead of the old single ".log" attribute.
2080 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2081 functionality, now subsumed into StdioProgressObserver
2082 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2083 log name changed from "output" to "stdio".
2086 * buildbot/interfaces.py (ILogFile): add the Interface used from
2087 the BuildStep towards the LogFile
2088 (ILogObserver): and the one provided by a LogObserver
2089 * buildbot/status/builder.py (LogFile): implement it
2091 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2092 HEADER constants here ..
2093 * buildbot/status/builder.py (STDOUT): .. from here
2095 2006-06-13 Brian Warner <warner@lothar.com>
2097 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2098 compatibility with python2.2, which doesn't have the 'substr in
2100 (TestP4Poller.makeTime): utility function to construct the
2101 timestamp using the same strptime() approach as p4poller does. It
2102 turns out that time.mktime() behaves slightly differently under
2103 python2.2, probably something to do with the DST flag, and that
2104 causes the test to fail under python2.2. (changing the mktime()
2105 arguments to have dst=0 instead of -1 caused it to fail under
2106 python2.3. Go figure.)
2107 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2109 2006-06-12 Brian Warner <warner@lothar.com>
2111 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2112 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2113 contributing such an excellent patch, including docs and unit
2114 tests! This makes it *so* much easier to apply. I had to update
2115 test_vc.py to handle some recent refactorings, but everything else
2116 applied smoothly. The only remaining thing I'd like to fix would
2117 be to remove the hard-wired port 1666 used by p4d, and allow it to
2118 claim any unused port. This would allow two copies of the test
2119 suite to run on the same host at the same time, as well as
2120 allowing the test suite to run while a real (production) p4d was
2121 running on the same host. Oh, and maybe we should add a warning to
2122 step.P4 that gets emitted if the slave is too old to provide the
2123 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2124 * buildbot/slave/commands.py (P4): same
2125 (P4Sync): same, some minor updates
2126 * buildbot/changes/p4poller.py: same
2127 * docs/buildbot.texinfo: same
2128 * buildbot/test/test_p4poller.py: same
2129 * buildbot/test/test_vc.py (P4): same
2131 * setup.py: add Trove classifiers for PyPI
2133 2006-06-08 Brian Warner <warner@allmydata.com>
2135 * buildbot/status/client.py
2136 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2137 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2138 build needs to be IRemote'd separately, rather than IRemote'ing
2139 the whole list at once. I can't wait until newpb's serialization
2140 adapters make this unnecessary.
2142 2006-06-06 Brian Warner <warner@lothar.com>
2144 * buildbot/process/step.py (WithProperties): make this inherit
2145 from ComparableMixin, so that reloading an unchanged config file
2146 doesn't cause us to spuriously reload any Builders which use them.
2147 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2150 2006-06-03 Brian Warner <warner@lothar.com>
2152 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2153 running py2exe on windows, contributed by Mark Hammond. Addresses
2154 SF#1401121, but I think we still need to include
2155 buildbot/scripts/sample.cfg
2156 * setup.py: include buildbot_service.py as a script under windows
2157 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2158 a py2exe application), get the icon/css datafiles from a different
2161 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2162 double-escape the build URL. Thanks to Olivier Bonnet for the
2163 patch. Fixes SF#1452801.
2165 2006-06-02 Brian Warner <warner@lothar.com>
2167 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2168 first six columns of 'svnlook' output, not just the first column,
2169 since property changes appear in the other five. Thanks to Olivier
2170 Bonnet for the patch. Fixes SF#1398174.
2172 2006-06-01 Brian Warner <warner@lothar.com>
2174 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2175 the fake build, so that title= has something to be set to
2177 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2178 attribute of the "Build #NN" link in the yellow start-the-build
2179 box to the build's reason. This means that you get a little
2180 tooltip explaining why the build was done when you hover over the
2181 yellow box. Thanks to Zandr Milewski for the suggestion.
2183 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2184 (Box.setETA): handle ETA=None (by stopping the timer)
2185 (Box.update): make the [soon] text less different than the usual
2186 text, so the rest of the text doesn't flop around so much. It
2187 would be awfully nice to figure out how to center this stuff.
2188 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2190 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2191 by default, so that any ShellCommand which fails marks the overall
2192 build as a failure. I should have done this from the beginning.
2193 Add flunkOnFailure=False to the arguments if you want to turn off
2196 2006-05-30 Brian Warner <warner@lothar.com>
2198 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2199 last-build/current-build/current-step. Show what step is currently
2200 running. Show ETA for both the overall build and the current step.
2201 Update GTK calls to modern non-deprecated forms. There's still a
2202 lot of dead code and debug noise to remove.
2204 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2205 shows up properly in status displays
2207 2006-05-28 Brian Warner <warner@lothar.com>
2209 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2210 build we use to verify that WithProperties works:
2212 ** set flunkOnFailure=True so that build failures get noticed
2213 ** set workdir='.' so that the build succeeds, otherwise it is trying
2214 to touch 'build/something', and 'build/' doesn't exist because
2215 usually that's created by a Source step
2216 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2217 this test somehow triggers, in which the 'touch' process becomes
2218 a zombie and we wait for th etimeout before giving up on it.
2220 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2221 to log the Build results and step logs to the twisted log.
2222 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2223 what went wrong if a build was expected to succeed but didn't.
2225 * buildbot/process/step_twisted.py (Trial): set the default
2226 trialMode to '--reporter=bwverbose', which specifies verbose
2227 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2228 '-to', but those are completely missing in modern Twisteds.
2230 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2231 a localhost-only port, to encourage better security
2233 * docs/buildbot.texinfo (Change Sources): mention
2236 * .darcs-boring: add a Darcs boringfile
2238 * README (REQUIREMENTS): stop claiming compatibility with
2241 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2244 2006-05-27 Brian Warner <warner@lothar.com>
2246 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2247 * docs/buildbot.texinfo: same
2249 2006-05-23 Brian Warner <warner@lothar.com>
2251 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2252 * docs/buildbot.texinfo: set version to match
2253 * NEWS: update for 0.7.3
2255 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2256 give a quick mapping from VC system to possible ChangeSources
2257 (Build Properties): add 'buildername'
2259 * buildbot/process/base.py (Build.setupStatus): oops, set
2260 'buildername' and 'buildnumber' properties
2261 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2264 2006-05-22 Brian Warner <warner@lothar.com>
2266 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2267 property interpolation better
2269 * README (INSTALLATION): remove old '-v' argument from recommended
2272 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2273 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2276 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2277 'svnversion' instead of grepping the output of 'svn info', much
2278 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2279 Bonnet for the suggestion.
2280 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2281 require the WC_PATH argument, so run 'svnversion .' instead.
2283 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2284 aren't supposed to have 'self' in their argument list
2286 2006-05-21 Brian Warner <warner@lothar.com>
2288 * buildbot/process/step.py (ShellCommand.start): make
2289 testInterpolate pass. I was passing the uninterpolated command to
2290 the RemoteShellCommand constructor
2291 (ShellCommand._interpolateProperties): oops, handle non-list
2292 commands (i.e. strings with multiple words separated by spaces in
2293 them) properly, instead of forgetting about them.
2295 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2296 to actually try to use build properties in a real build. This test
2298 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2299 to start and evaluate builds
2301 * buildbot/test/test__versions.py: add a pseudo-test to record
2302 what version of Twisted/Python/Buildbot are running. This should
2303 show up at the beginning of _trial_tmp/test.log, and exists to help
2304 debug other problems.
2306 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2307 a filename to be served as 'robots.txt' to discourage web spiders.
2308 Adapted from a patch by Tobi Vollebregt, thanks!
2309 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2310 (Waterfall.test_waterfall): tweak the way that filenames are put
2311 into the config file, to accomodate windows pathnames better.
2313 * docs/buildbot.texinfo (HTML Waterfall): document it
2315 * buildbot/process/process_twisted.py
2316 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2317 changed the build process. The new setup.py no longer takes the
2319 (FullTwistedBuildFactory.__init__): same
2320 (TwistedReactorsBuildFactory.__init__): same
2322 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2323 be placed in the [hooks] section of the central repository (the
2324 one that everybody pushes changes to).
2326 2006-05-20 Brian Warner <warner@lothar.com>
2328 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2329 .darcs-context file, use binary mode. I think this was causing a
2330 Darcs failure under windows.
2332 2006-05-19 Brian Warner <warner@lothar.com>
2334 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2335 use a timezone string of +0000 and gmtime, since this timestamp is
2336 sent to a buildmaster and %z is broken.
2338 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2339 string and localtime, since this timestamp will only be consumed
2340 locally, and %z is broken.
2342 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2343 gmtime, since this timestamp is returned to the buildmaster, and
2346 2006-05-18 Brian Warner <warner@lothar.com>
2348 * NEWS: update in preparation for next release
2350 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2351 setup-repository and do-we-have-the-vc-tools code into a separate
2352 "helper" class, which sticks around in a single module-level
2353 object. This seems more likely to continue to work in the future
2354 than having it hide in the TestCase and hope that TestCases stick
2355 around for a long time.
2357 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2358 addremove' has been deprecated in recent versions of mercurial, so
2359 use 'hg add' instead
2361 2006-05-07 Brian Warner <warner@lothar.com>
2363 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2364 operating under windows, move the file before opening it, since
2365 you can't rename a file that somebody has open.
2367 * buildbot/process/base.py (Build.setupBuild): if something goes
2368 wrong while creating a Step, log the name and arguments, since the
2369 error message when you get the number of arguments wrong is really
2372 2006-05-06 Brian Warner <warner@lothar.com>
2374 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2375 bugs in twisted-specific code not covered by my unit tests, this
2376 time use 'cmd' argument instead of self.cmd
2378 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2379 fix stupid braino: either use startwith or find()==0, not both.
2380 (TwistedReactorsBuildFactory.__init__): another dumb typo
2382 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2383 mark this test as TODO under windows, since process-killing seems
2384 dodgy there. We'll come back to this later and try to fix it
2387 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2388 and don't include a timezone
2389 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2390 This should avoid the windows-with-verbose-timezone-name problem
2392 (Patch.testPatch): add a test which runs 'patch' with less
2393 overhead than the full VCBase.do_patch sequence, to try to isolate
2394 a windows test failure. This one uses slave.commands.ShellCommand
2395 and 'patch', but none of the VC code.
2397 * buildbot/slave/commands.py (getCommand): use which() to find the
2398 executables for 'cvs', 'svn', etc. This ought to help under
2401 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2402 working directory before starting. If an earlier test failed, the
2403 leftover directory would mistakenly flunk a later test.
2404 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2405 Make sure that we use the right commandlines if which("tla") picks
2406 up "tla.exe" (as it does under windows).
2407 (TlaSupport.do_get): factor out this tla-vs-baz difference
2408 (TlaSupport.vc_create): more tla-vs-baz differences
2410 * buildbot/test/test_slavecommand.py
2411 (ShellBase.testShellMissingCommand): stop trying to assert
2412 anything about the error message: different shells on different
2413 OSes with different languages makes it hard, and it really isn't
2414 that interesting of a thing to test anyway.
2416 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2417 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2418 "Panther"), because it has a bug which flunks a couple tests in
2419 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2420 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2421 able to test that yet.
2423 2006-04-30 Brian Warner <warner@lothar.com>
2425 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2426 make sure child commands emit messages in english, so our regexps
2427 will match. Thanks to Nikaus Giger for identifying the problems.
2428 (VCBase._do_vctest_export_1): mode="export" is not responsible
2429 for setting the "got_revision" property, since in many cases it is
2430 not convenient to determine.
2431 (SVNSupport.capable): when running 'svn --version' to check for
2432 ra_local, we want error messages in english
2433 * buildbot/test/test_slavecommand.py
2434 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2435 to emit the error message in english
2437 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2438 the environment with $LC_ALL="C" so that Commands which need to
2439 parse the output of their child processes can obtain it in
2441 (SVN.parseGotRevision): call "svn info" afterwards instead of
2442 watching the output of the "svn update" or "svn checkout".
2443 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2444 (Arch.parseGotRevision): same
2445 (Bazaar.parseGotRevision): same
2446 (Mercurial.parseGotRevision): same
2448 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2449 $LC_ALL="C" when running commands under 'buildbot try', too
2451 * buildbot/test/__init__.py: remove the global os.environ()
2452 setting, instead we do it just for the tests that run commands and
2453 need to parse their output.
2455 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2456 remove the overly-short .timeout on this test, because non-DNotify
2457 platforms must fall back to polling which happens at 10 second
2458 intervals, so a 5 second timeout would never succeed.
2460 2006-04-24 Brian Warner <warner@lothar.com>
2462 * docs/buildbot.texinfo (Installing the code): update trial
2463 invocation, SF#1469116 by Niklaus Giger.
2464 (Attributes of Changes): updated branch-name examples to be
2465 a bit more realistic, SF#1475240 by Stephen Davis.
2467 * contrib/windows/buildbot2.bat: utility wrapper for windows
2468 developers, contributed by Nick Trout (after a year of neglect..
2469 sorry!). SF#1194231.
2471 * buildbot/test/test_vc.py (*.capable): store the actual VC
2472 binary's pathname in VCS[vcname], so it can be retrieved later
2473 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2474 strip out non-numeric timezone information, specifically the funky
2475 German string that his system produced that confuses CVS.
2476 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2477 allow Darcs tests to work on windows
2478 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2479 procutils.which() everywhere, to allow tryclient to work under
2480 windows. Also from Niklaus Giger, SF#1463394.
2482 * buildbot/twcompat.py (which): move the replacement for a missing
2483 twisted.python.procutils.which from test_vc.py to here, so it can
2484 be used in other places too (specifically tryclient.py)
2486 2006-04-23 Brian Warner <warner@lothar.com>
2488 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2489 bare buildbotURL/projectName line with a proper DIV, along with a
2490 CSS class of "title", from Stefan Seefeld (SF#1461675).
2491 (WaterfallStatusResource.body0): remove the redundant 'table'
2492 class from the table
2493 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2494 to the top-row TR, and class="Activity" to the second-row TR,
2495 rather than putting them in the individual TD nodes.
2497 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2498 'got_revision' build property for all VC systems that implement
2499 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2501 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2502 to determine which revision we actually obtained
2503 (CVS.parseGotRevision): implement this for CVS, which just means
2504 to grab a timestamp. Not ideal, and it depends upon the buildslave
2505 having a clock that is reasonably well syncronized with the server,
2506 but it's better than nothing.
2507 (SVN.parseGotRevision): implement it for SVN, which is accurate
2508 (Darcs.parseGotRevision): same
2509 (Arch.parseGotRevision): same
2510 (Bazaar.parseGotRevision): same
2511 (Mercurial.parseGotRevision): same
2513 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2514 keep a record of all non-stdout/stderr/header/rc status updates,
2515 for the benefit of RemoteCommands that send other useful things,
2517 (Source.commandComplete): put any 'got_revision' status values
2518 into a build property of the same name
2521 * buildbot/process/step_twisted.py (Trial): update to deal with
2522 new ShellCommand refactoring
2524 * docs/buildbot.texinfo (Build Properties): document new feature
2525 that allows BuildSteps to get/set Build-wide properties like which
2526 revision was requested and/or checked out.
2528 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2529 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2530 it. Note that this bumps the persistenceVersion of the saved Build
2531 object, so add the necessary upgrade-old-version logic to include
2532 an empty properties dict.
2534 * buildbot/process/base.py (Build.setProperty): implement it
2535 (Build.getProperty): same
2536 (Build.startBuild): change build startup to set 'branch',
2537 'revision', and 'slavename' properties at the right time
2539 * buildbot/process/step.py (BuildStep.__init__): change setup to
2540 require 'build' argument in a better way
2541 (LoggingBuildStep): split ShellCommand into two pieces, for better
2542 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2543 a single RemoteCommand that sends stdout/stderr status text. It
2544 also provides the usual commandComplete / createSummary /
2545 evaluateCommand / getText methods to be overridden...
2546 (ShellCommand): .. whereas ShellCommand is specifically for
2547 running RemoteShellCommands. Other shell-like BuildSteps (like
2548 Source) can inherit from LoggingBuildStep instead of ShellCommand
2549 (WithProperties): marker class to do build-property interpolation
2550 (Source): inherit from LoggingBuildStep instead of ShellCommand
2553 * buildbot/test/test_properties.py: test new functionality
2555 2006-04-21 Brian Warner <warner@lothar.com>
2557 * buildbot/test/test_vc.py: rename testBranch to
2558 testCheckoutBranch to keep the tests in about the right
2561 2006-04-18 Brian Warner <warner@lothar.com>
2563 * docs/buildbot.texinfo (PBListener): improve cross-references
2564 between PBListener and 'buildbot statusgui', thanks to John Pye
2567 2006-04-17 Brian Warner <warner@lothar.com>
2569 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2570 running under Twisted-1.3.0, otherwise skipped tests are reported
2573 * all: use isinstance() instead of 'type(x) is foo', suggested by
2576 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2577 oops, fix a brain-fade from the other week, when making the
2578 addStep changes. I changed all the __init__ upcalls to use the
2579 wrong superclass name.
2580 (FullTwistedBuildFactory.__init__): same
2581 (TwistedDebsBuildFactory.__init__): same
2582 (TwistedReactorsBuildFactory.__init__): same
2583 (TwistedBuild.isFileImportant): use .startswith for clarity,
2584 thanks to Neal Norwitz for the suggestions.
2586 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2587 changes, then deliver them over PB to a remote buildmaster.
2589 * contrib/svnpoller.py: added script by John Pye to poll a remote
2590 SVN repository (by running 'svn log') from a cronjob, and run
2591 'buildbot sendchange' to deliver the changes to a remote
2593 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2594 modification of svnpoller.py), same purpose, but this one loops
2595 internally (rather than expecting to run from a cronjob) and works
2597 * contrib/README.txt: same
2599 2006-04-11 Brian Warner <warner@lothar.com>
2601 * all: fix a number of incorrect names and missing imports, thanks
2602 to Anthony Baxter for the patch.
2603 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2604 remove unused buggy method.
2605 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2606 comes from shutil, not "shutils"
2607 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2608 (Arch.checkSlaveVersion): same
2609 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2611 * buildbot/process/step_twisted2.py: add some missing imports
2612 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2613 this code used to live in twisted.internet.defer
2615 2006-04-10 Brian Warner <warner@lothar.com>
2617 * buildbot/process/step.py (Mercurial): add Mercurial support
2618 * buildbot/slave/commands.py (Mercurial): same
2619 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2620 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2621 not yet tested, but 'try' support *is* covered
2622 * docs/buildbot.texinfo (Mercurial): document it
2624 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2625 some debugging messages (turned off)
2626 * buildbot/test/test_vc.py: improve debug messages
2628 2006-04-07 Brian Warner <warner@lothar.com>
2630 * buildbot/test/test_vc.py (which): define our own which() in case
2631 we can't import twisted.python.procutils, because procutils doesn't
2632 exist in Twisted-1.3
2634 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2635 of SlaveLocks for performance tests
2637 * docs/examples/twisted_master.cfg: update to match current usage
2639 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2640 password, p4 binary, pollinterval, maximum history to check.
2641 Patch from an anonymous sf.net contributor, SF#1219384.
2642 * buildbot/process/step.py (P4Sync.__init__): add username,
2643 password, and client arguments.
2644 * buildbot/slave/commands.py (P4Sync): same
2646 2006-04-05 Brian Warner <warner@lothar.com>
2648 * buildbot/process/factory.py (BuildFactory.addStep): new method
2649 to add steps to a BuildFactory. Use it instead of f.steps.append,
2650 and you can probably avoid using the s() convenience function.
2651 Patch from Neal Norwitz, sf.net #1412605.
2652 (other): update all factories to use addStep
2653 * buildbot/process/process_twisted.py: update all factories to use
2656 2006-04-03 Brian Warner <warner@lothar.com>
2658 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2659 work under windows too. Adapted from a patch by Niklaus Giger,
2660 addresses SF#1463399.
2662 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2663 spawned commands emit parseable results in english and not some
2664 other language. Patch from Niklaus Giger, SF#1463395.
2666 * README (INSTALLATION): discourage users from running unit tests on
2667 a "network drive", patch from Niklaus Giger, SF#1463394.
2669 2006-03-22 Brian Warner <warner@lothar.com>
2671 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2672 function to turn a repository-relative pathname into a (branch,
2673 branch-relative-filename) tuple. Change this function to handle
2674 the branch naming policy used by your Subversion repository.
2675 Thanks to AllMyData.com for sponsoring this work.
2677 2006-03-16 Brian Warner <warner@lothar.com>
2679 * buildbot/scripts/sample.cfg: add python-mode declaration for
2680 vim. Thanks to John Pye for the patch.
2682 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2683 command line, mention the importance of running 'crontab' as the
2684 buildmaster/buildslave user. Thanks to John Pye for the catch.
2686 2006-03-13 Brian Warner <warner@lothar.com>
2688 * buildbot/status/words.py (IRC): add an optional password=
2689 argument, which will be sent to Nickserv in an IDENTIFY message at
2690 login, to claim the nickname. freenode requires this before the
2691 bot can sent (or reply to) private messages. Thanks to Clement
2692 Stenac for the patch.
2693 * docs/buildbot.texinfo (IRC Bot): document it
2695 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2696 larger than chunkSize. Fixes SF#1349253.
2697 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2698 (Log.testConsumer): update to match new internal chunking behavior
2700 2006-03-12 Brian Warner <warner@lothar.com>
2702 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2704 * buildbot/test/test_maildir.py (MaildirTest): rename the
2705 'timeout' method, as it collides with trial's internals
2707 * buildbot/scripts/runner.py: add 'buildbot restart' command
2708 (stop): don't sys.exit() out of here, otherwise restart can't work
2709 * docs/buildbot.texinfo (Shutdown): document it
2711 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2712 * buildbot/status/html.py (Waterfall.__init__): same
2713 * buildbot/process/builder.py (Builder.startBuild): same
2714 * buildbot/process/base.py (BuildRequest): same
2715 * buildbot/sourcestamp.py (SourceStamp): same
2716 * buildbot/scheduler.py (Nightly): same
2718 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2720 * docs/buildbot.texinfo: same
2722 2006-02-17 Brian Warner <warner@lothar.com>
2724 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2725 * docs/buildbot.texinfo: set version number to match
2726 * NEWS: update for 0.7.2
2728 2006-02-16 Brian Warner <warner@lothar.com>
2730 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2732 2006-02-09 Brian Warner <warner@lothar.com>
2734 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2735 add text to explain per-build branch parameters
2736 * NEWS: mention --umask
2738 2006-02-08 Brian Warner <warner@lothar.com>
2740 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2742 (SlaveOptions.optParameters): add --umask, to make it possible to
2743 make buildslave-generated files (including build products) be
2746 * buildbot/slave/bot.py (BuildSlave.startService): same
2748 2006-01-23 Brian Warner <warner@lothar.com>
2750 * buildbot/status/builder.py: urllib.quote() all URLs that include
2751 Builder names, so that builders can include characters like '/'
2752 and ' ' without completely breaking the resulting HTML. Thanks to
2753 Kevin Turner for the patch.
2754 * buildbot/status/html.py: same
2755 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2757 * NEWS: update in preparation for upcoming release
2759 2006-01-18 Brian Warner <warner@lothar.com>
2761 * docs/examples/twisted_master.cfg: update to match the Twisted
2762 buildbot: remove python2.2, switch to exarkun's buildslaves,
2763 disable the .deb builder until we figure out how to build twisted
2764 .debs from SVN, add some ktrace debugging to the OS-X build
2765 process and remove the qt build, remove threadless builders,
2766 change freebsd builder to use landonf's buildslave.
2768 2006-01-12 Brian Warner <warner@lothar.com>
2770 * buildbot/master.py (Manhole.__init__): let port= be a strports
2771 specification string, but handle a regular int for backwards
2772 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2773 used in master.cfg to limit connections to just the local host.
2774 (BuildMaster.loadConfig): same for c['slavePortnum']
2775 * buildbot/scheduler.py (Try_Userpass.__init__): same
2776 * buildbot/status/client.py (PBListener.__init__): same
2777 * buildbot/status/html.py (Waterfall.__init__): same, for both
2778 http_port and distrib_port. Include backwards-compatibility checks
2779 so distrib_port can be a filename string and still mean unix:/foo
2780 * docs/buildbot.texinfo (Setting the slaveport): document it
2781 (Debug options): same
2782 (HTML Waterfall): same
2785 * buildbot/test/test_config.py (ConfigTest): test it
2787 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2788 slaveport's disownServiceParent deferred to fire before opening
2789 the new one. Fixes an annoying bug in the unit tests.
2791 2006-01-03 Brian Warner <warner@lothar.com>
2793 * buildbot/master.py (BuildMaster): remove the .schedulers
2794 attribute, replacing it with an allSchedulers() method that looks
2795 for all IService children that implement IScheduler. Having only
2796 one parent/child relationship means fewer opportunities for bugs.
2797 (BuildMaster.allSchedulers): new method
2798 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2799 also fix ugly bug that caused any config-file reload to
2800 half-forget about the earlier Schedulers, causing an exception
2801 when a Change arrived and was handed to a half-connected
2802 Scheduler. The exception was in scheduler.py line 54ish:
2803 self.parent.submitBuildSet(bs)
2804 exceptions.AttributeError: 'NoneType' object has no attribute
2806 (BuildMaster.addChange): update to use allSchedulers()
2808 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2809 to work properly with twisted-1.3.0, where you must explicitly
2810 include the __implements__ from parent classes
2811 (BaseScheduler.__repr__): make it easier to distinguish distinct
2813 (BaseUpstreamScheduler.__implements__): same
2815 * buildbot/status/builder.py (Status.getSchedulers): update to
2817 * buildbot/test/test_run.py (Run.testMaster): same
2818 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2819 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2820 make sure Scheduler instances are left alone when an identical
2821 config file is reloaded
2822 (ConfigElements.testSchedulers): make sure Schedulers are properly
2825 * Makefile (TRIALARGS): my local default Twisted version is now
2826 2.1.0, update the trial arguments accordingly
2828 2005-12-22 Brian Warner <warner@lothar.com>
2830 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2833 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2834 addChange in the parent class, although I suspect this should be
2835 fixed better in the future.
2837 2005-11-26 Brian Warner <warner@lothar.com>
2839 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2840 explode when branch==None, thanks to Kevin Turner for the catch
2841 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2844 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2846 * docs/buildbot.texinfo: same
2848 2005-11-26 Brian Warner <warner@lothar.com>
2850 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2851 * docs/buildbot.texinfo: set version number to match
2853 2005-11-26 Brian Warner <warner@lothar.com>
2855 * NEWS: update for 0.7.1
2857 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2858 sure that unsubscribe works even if we never sent an ETA update.
2859 Also, don't explode on duplicate unsubscribe.
2860 (BuildStepStatus.addLog): make the convenience "return self"-added
2861 watcher automatically unsubscribe when the Step finishes.
2862 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2863 (BuildStatus.stepStarted): same auto-unsubscribe
2864 (BuilderStatus.buildStarted): same auto-unsubscribe
2866 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2868 (IStatusReceiver.stepStarted): same
2869 (IStatusReceiver.logStarted): same
2871 * buildbot/test/test_run.py (Status): move the Status test..
2872 * buildbot/test/test_status.py (Subscription): .. to here
2874 2005-11-25 Brian Warner <warner@lothar.com>
2876 * NEWS: more updates
2878 * buildbot/locks.py: fix the problem in which loading a master.cfg
2879 file that changes some Builders (but not all of them) can result
2880 in having multiple copies of the same Lock. Now, the real Locks
2881 are kept in a table inside the BotMaster, and the Builders/Steps
2882 use "LockIDs", which are still instances of MasterLock and
2883 SlaveLock. The real Locks are instances of the new RealMasterLock
2884 and RealSlaveLock classes.
2885 * buildbot/master.py (BotMaster.getLockByID): new method to
2886 convert LockIDs into real Locks.
2887 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2888 into real Locks before building
2889 * buildbot/process/step.py (BuildStep.startStep): same
2890 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2891 exercises the problem
2894 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2895 what Schedulers are available
2897 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2898 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2899 'cron'-style build scheduling at certain times of day, week,
2901 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2903 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2904 handling: treat self.fileIsImportant more as an attribute that
2905 contains a callable than as a method. If the attribute is None,
2906 don't call it and assume all filenames are important. It is still
2907 possible to provide a fileIsImportant method in a subclass,
2909 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2911 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2912 test using AnyBranchScheduler with fileIsImportant=None
2914 2005-11-24 Brian Warner <warner@lothar.com>
2916 * buildbot/test/test_config.py (StartService): don't claim a fixed
2917 port number, instead set slavePort=0 on the first pass, figure out
2918 what port was allocated, then switch to a config file that uses
2921 * buildbot/master.py (BuildMaster.loadConfig): close the old
2922 slaveport before opening the new one, because unit tests might
2923 replace slavePort=0 with the same allocated portnumber, and if we
2924 don't wait for the old port to close first, we get a "port already
2925 in use" error. There is a tiny race condition here, but the only
2926 threat is from other programs that bind (statically) to the same
2927 port number we happened to be allocated, and only if those
2928 programs use SO_REUSEADDR, and only if they get control in between
2931 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2933 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2934 deleted ChangeSources before adding any new ones
2935 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2936 compare_attrs, to make sure that a config-file reload does not
2937 unnecessarily replace an unmodified ChangeSource instance
2938 * buildbot/test/test_config.py (ConfigTest.testSources): update
2940 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2941 mean "don't build anything", and add a warning if it gets used
2942 because it isn't actually useful.
2944 * contrib/svn_buildbot.py: update example usage to match the port
2945 number that gets used by the PBChangeSource
2946 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2948 2005-11-22 Brian Warner <warner@lothar.com>
2950 * NEWS: start collecting items for next release
2952 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2953 revisions are strings
2954 (P4Sync.computeSourceRevision): same
2956 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2957 to the Buildbot's overall status page
2958 (StatusResourceBuilder.body): same
2960 2005-11-15 Brian Warner <warner@lothar.com>
2962 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2963 config-file loading, specifically to make sure old StatusTargets
2964 are finished shutting down before new ones start up (thus
2965 resolving a bug in which changing the Waterfall object would fail
2966 because both new and old instances were claiming the same
2967 listening port). Also load new Schedulers after all the new
2968 Builders are set up, in case they fire off a new build right away.
2969 * buildbot/test/test_config.py (StartService): test it
2971 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2972 the branch name to the mail body
2974 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2975 Without it, a config-file reload fails to update an existing
2977 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2978 username/passwd to compare_attrs, for the same reason
2979 * buildbot/status/html.py (Waterfall): add favicon to
2980 compare_attrs, same reason
2982 2005-11-05 Brian Warner <warner@lothar.com>
2984 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2985 baserev before stuffing it in the jobfile. This resolves problems
2986 under SVN (and probably Arch) where revisions are expressed as
2987 numbers. I'm inclined to use string-based revisions everywhere in
2988 the future, but this fix should be safe for now. Thanks to Steven
2989 Walter for the patch.
2991 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2992 binary mode when opening pickle files, to make windows work
2993 better. Thanks to Dobes Vandermeer for the catch.
2994 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2995 (BuilderStatus.getBuildByNumber): same
2996 (Status.builderAdded): same
2997 * buildbot/master.py (BuildMaster.loadChanges): same
2999 * buildbot/util.py (Swappable): delete unused leftover code
3001 * buildbot/process/step.py (SVN): when building on a non-default
3002 branch, add the word "[branch]" to the VC step's description, so
3003 it is obvious that we're not building the usual stuff. Likewise,
3004 when we are building a specific revision, add the text "rNNN" to
3005 indicate what that revision number is. Thanks to Brad Hards and
3006 Nathaniel Smith for the suggestion.
3007 (Darcs.startVC): same
3008 (Arch.startVC): same
3009 (Bazaar.startVC): same
3011 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3012 typo, caught by Mark Dillavou, closes SF#1216636.
3014 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3015 about a test to add some day
3017 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3018 the 'full-2.3' build, and the 'reactors' build is now run under
3019 python-2.4 because the buildslave no longer has gtk/etc bindings
3020 for earlier versions.
3022 2005-11-03 Brian Warner <warner@lothar.com>
3024 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3025 method, takes an IBuildStatus and rebuilds it. It might make more
3026 sense to add this to IBuildControl instead, but that instance goes
3027 away completely once the build has finished, and resubmitting
3028 builds can take place weeks later.
3029 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3030 * buildbot/status/html.py (StatusResourceBuild): also stash an
3031 IBuilderControl so we can use resubmitBuild.
3032 (StatusResourceBuild.body): render "resubmit" button if we can.
3033 Also add hrefs for each BuildStep
3034 (StatusResourceBuild.rebuild): add action for "resubmit" button
3035 (StatusResourceBuilder.getChild): give it an IBuilderControl
3037 * buildbot/status/builder.py (Status.getURLForThing): change the
3038 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3039 that live as targets of buttons like "stop" and "rebuild" can't
3041 * buildbot/status/builder.py (Status.getURLForThing): same
3042 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3043 (StepBox.getBox): same
3044 * buildbot/test/test_web.py (GetURL): same
3047 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3048 exclusivity checks after Source.__init__ upcall, so misspelled
3049 arguments will be reported more usefully
3050 (Darcs.__init__): same
3052 2005-10-29 Brian Warner <warner@lothar.com>
3054 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3055 builder. Move the Try scheduler off to a separate port.
3057 2005-10-27 Brian Warner <warner@lothar.com>
3059 * buildbot/clients/gtkPanes.py
3060 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3061 to cause the app to crash, now they don't.
3063 * buildbot/clients/debug.py: display the buildmaster's location
3064 in the window's title bar
3066 2005-10-26 Brian Warner <warner@lothar.com>
3068 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3069 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3070 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3072 * buildbot/status/html.py (td): put a single non-breaking space
3073 inside otherwise empty <td> elements, as a workaround for buggy
3074 browsers which would optimize them away (along with any associated
3075 styles, like the kind that create the waterfall grid borders).
3076 Patch from Frerich Raabe.
3078 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3079 argv-list as an argument, defaulting to ["-to"], which is
3080 appropriate for the Trial that comes with Twisted-2.1.0 and
3081 earlier. The Trial in current Twisted SVN wants
3082 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3083 defaults to an empty list.
3084 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3085 match it, now that trialMode= is a list instead of a single string
3087 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3089 * docs/buildbot.texinfo: same
3091 2005-10-24 Brian Warner <warner@lothar.com>
3093 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3094 * docs/buildbot.texinfo: set version number to match
3096 2005-10-24 Brian Warner <warner@lothar.com>
3098 * README: update for 0.7.0
3100 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3102 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3103 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3104 send the branch= argument unless the user really provided one, to
3105 retain compatibility with older buildmasters that don't accept
3107 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3110 * docs/buildbot.texinfo: update lots of stuff
3112 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3113 to the 'buildbot sendchange' command
3114 * buildbot/clients/sendchange.py (Sender.send): same
3115 * buildbot/changes/pb.py (ChangePerspective): same
3116 * buildbot/test/test_changes.py (Sender.testSender): test it
3118 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3119 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3120 for consistency with other BuildStep arguments that use camelCase.
3121 Well, at least more of them use camelCase (like flunkOnWarnings)
3122 than don't.. I wish I'd picked one style and stuck with it
3123 earlier. Annoying, but it's best done before the release, since
3124 these arguments didn't exist at all in 0.6.6 .
3126 * buildbot/test/test_vc.py (SVN.testCheckout): same
3127 (Darcs.testPatch): same
3128 * docs/buildbot.texinfo (SVN): document the change
3129 (Darcs): same, add some build-on-branch docs
3130 * docs/examples/twisted_master.cfg: match change
3132 * buildbot/process/step.py (BuildStep): rename
3133 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3134 how it is normally used.
3135 * buildbot/test/test_steps.py (Version.checkCompare): same
3137 * buildbot/process/step.py (CVS.startVC): refuse to build
3138 update/copy -style builds on a non-default branch with an old
3139 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3140 concern is that it will do a VC 'update' in an existing tree when
3141 it is supposed to be switching branches (and therefore clobbering
3142 the tree to do a full checkout), thus building the wrong source.
3143 This used to be a warning, but I think the confusion it is likely
3144 to cause warrants making it an error.
3145 (SVN.startVC): same, also make mode=export on old slaves an error
3146 (Darcs.startVC): same
3147 (Git.startVC): improve error message for non-Git-enabled slaves
3148 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3149 specific revision is built on a slave that doesn't pay attention
3150 to args['revision'], because for slowly-changing trees it will
3151 probably do the right thing, and because we have no way to tell
3152 whether we're asking it to build the most recent version or not.
3153 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3155 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3156 that 'master' is in host:portnum format, to catch errors sooner
3158 2005-10-23 Brian Warner <warner@lothar.com>
3160 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3161 when creating the list of warning messages, include the line
3162 immediately after each WARNING: line, since that's usually where
3163 the file and line number wind up.
3165 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3170 2005-10-22 Brian Warner <warner@lothar.com>
3172 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3173 patch from Brad Hards
3174 * buildbot/status/classic.css: same
3175 * buildbot/test/test_web.py (Waterfall): match changes
3177 * buildbot/test/test_steps.py (BuildStep.setUp): set
3178 nextBuildNumber so the test passes
3179 * buildbot/test/test_status.py (MyBuilder): same
3181 * buildbot/status/html.py (StatusResourceBuild.body): revision
3182 might be numeric, so stringify it before html-escapifying it
3183 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3184 timer for the upcoming build
3185 * buildbot/status/classic.css: add background-color attributes for
3186 offline/waiting/building classes
3188 * buildbot/status/builder.py (BuildStatus): derive from
3189 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3190 the default (i.e. unknown) .slavename to "???" instead of None,
3191 since even unknown slavenames need to be printed eventually.
3192 (BuilderStatus): also derive from styles.Versioned . More
3193 importantly, determine .nextBuildNumber at creation/unpickling
3194 time by scanning the directory of saved BuildStatus instances and
3195 choosing one larger than the highest-numbered one found. This
3196 should fix the problem where random errors during upgrades cause
3197 the buildbot to forget about earlier builds. .nextBuildNumber is
3198 no longer stored in the pickle.
3199 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3200 at least log the error. Also call Builder.determineNextBuildNumber
3201 once the basedir is set.
3203 * buildbot/master.py (BuildMaster.loadChanges): do
3204 styles.doUpgrade afterwards, in case I decide to make Changes
3205 derived from styles.Versioned some day and forget to make this
3209 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3210 when running under older pythons (<2.3) in which the shlex module
3211 doesn't have a 'split' function.
3213 * buildbot/process/step.py (ShellCommand.start): make
3214 errorMessages= be a list of strings to stuff in the log before the
3215 command actually starts. This makes it easier to flag multiple
3216 warning messages, e.g. when the Source steps have to deal with an
3218 (CVS.startVC): handle slaves that don't handle multiple branches
3219 by switching into 'clobber' mode
3220 (SVN.startVC): same. Also reject branches without base_url
3221 (Darcs.startVC): same. Also reject revision= in older slaves
3222 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3223 (Bazaar.startVC): same, and test for baz separately than for arch
3225 * buildbot/slave/commands.py (cvs_ver): document new features
3227 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3228 (BuildStep.slaveVersionNewEnough): more useful utility method
3229 * buildbot/test/test_steps.py (Version): start testing it
3231 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3232 the 'force' command requires python2.3, for the shlex.split method
3234 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3235 since we don't use it anymore. The Twisted buildbot uses a
3238 2005-10-21 Brian Warner <warner@lothar.com>
3240 * buildbot/process/process_twisted.py: rework all BuildFactory
3241 classes to take a 'source' step as an argument, instead of
3242 building up the SVN instance in the factory.
3243 * docs/examples/twisted_master.cfg: enable build-on-branch by
3244 providing a base_url and default_branch
3246 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3247 control over --branch and --revision, not that they are always
3249 * buildbot/status/html.py (StatusResourceBuilder.force): same
3250 (StatusResourceBuild.body): display SourceStamp components
3252 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3253 IRC 'force' command, so it can be shared with an eventual
3254 command-line-tool 'buildbot force' mode.
3255 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3257 2005-10-20 Brian Warner <warner@lothar.com>
3259 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3261 * docs/examples/twisted_master.cfg: update to use Schedulers
3263 * buildbot/scripts/sample.cfg: update with Schedulers
3265 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3266 method specifically for use by HTML "force build" button and the
3267 IRC "force" command. Raises an immediate error if there are no
3269 (IBuilderControl.requestBuild): make this just submit a build, not
3270 try to check for existing slaves or set up any when-finished
3271 Deferreds or anything.
3272 * buildbot/process/builder.py (BuilderControl): same
3273 * buildbot/status/html.py (StatusResourceBuilder.force): same
3274 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3275 * buildbot/test/test_slaves.py: same
3276 * buildbot/test/test_web.py: same
3278 2005-10-19 Brian Warner <warner@lothar.com>
3280 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3281 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3283 2005-10-18 Brian Warner <warner@lothar.com>
3285 * buildbot/status/html.py: provide 'status' argument to most
3286 StatusResourceFOO objects
3287 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3288 and Logfiles" section to make the Build page into a more-or-less
3289 comprehensive source of status information about the build
3291 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3292 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3294 2005-10-17 Brian Warner <warner@lothar.com>
3296 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3297 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3298 out what to do about other projects: the correct options for
3299 recent Twisteds will not work for older ones.
3301 2005-10-15 Brian Warner <warner@lothar.com>
3303 * buildbot/status/builder.py (Status.getURLForThing): add method
3304 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3305 use this in email/IRC status clients to make them more useful, by
3306 providing the end user with hints on where to learn more about the
3307 object being reported on.
3308 * buildbot/test/test_web.py (GetURL): tests for it
3310 2005-10-14 Brian Warner <warner@lothar.com>
3312 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3313 fix bug resulting from deferredResult changes
3315 2005-10-13 Brian Warner <warner@lothar.com>
3317 * buildbot/test/test_changes.py: remove use of deferredResult
3318 * buildbot/test/test_config.py: same
3319 * buildbot/test/test_control.py: same
3320 * buildbot/test/test_status.py: same
3321 * buildbot/test/test_vc.py: this is the only remaining use, since
3322 it gets used at module level. This needs to be replaced by some
3323 sort of class-level run-once routine.
3325 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3327 * lots: implement multiple slaves per Builder, which means multiple
3328 current builds per Builder. Some highlights:
3329 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3330 of (state,currentBuilds) instead of (state,currentBuild)
3331 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3332 (IBuildStatus.getSlavename): new method, so you can tell which
3333 slave got used. This only gets set when the build completes.
3334 (IBuildRequestStatus.getBuilds): new method
3336 * buildbot/process/builder.py (SlaveBuilder): add a .state
3337 attribute to track things like ATTACHING and IDLE and BUILDING,
3339 (Builder): .. the .slaves attribute here, which has been turned
3340 into a simple list of available slaves. Added a separate
3341 attaching_slaves list to track ones that are not yet ready for
3343 (Builder.fireTestEvent): put off the test-event callback for a
3344 reactor turn, to make tests a bit more consistent.
3345 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3346 ping fails due to an exception. This needs work, I'm worried that
3347 a code error could lead to a constantly re-connecting slave.
3348 Especially since I'm trying to move to a distinct remote_ping
3349 method, separate from the remote_print that we currently use.
3350 (BuilderControl.requestBuild): return a convenience Deferred that
3351 provides an IBuildStatus when the build finishes.
3352 (BuilderControl.ping): ping all connected slaves, only return True
3353 if they all respond.
3355 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3356 reconnect when we shut down.
3358 * buildbot/status/builder.py: implement new methods, convert
3359 one-build-at-a-time methods to handle multiple builds
3360 * buildbot/status/*.py: do the same in all default status targets
3361 * buildbot/status/html.py: report the build's slavename in the
3362 per-Build page, report all buildslaves on the per-Builder page
3364 * buildbot/test/test_run.py: update/create tests
3365 * buildbot/test/test_slaves.py: same
3366 * buildbot/test/test_scheduler.py: remove stale test
3368 * docs/buildbot.texinfo: document the new builder-specification
3369 'slavenames' parameter
3371 2005-10-12 Brian Warner <warner@lothar.com>
3373 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3374 report failure correctly, causing Dependent builds to run when
3375 they shouldn't have.
3376 * buildbot/status/builder.py (BuildSetStatus): same
3377 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3378 (Set.testSuccess): test the both-pass case too
3379 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3380 fix this test: it was ending too early, masking the failure before
3381 (Logger): specialized StatusReceiver to make sure the dependent
3382 builds aren't even started, much less completed.
3384 2005-10-07 Brian Warner <warner@lothar.com>
3386 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3387 bot.SlaveBuilder being disowned in the middle of a build
3389 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3390 this inherit from StatusReceiver. Also upcall in __init__. This
3391 fixes the embarrasing crash when the new buildSetSubmitted method
3392 is invoked and Waterfall/etc don't implement their own.
3393 * buildbot/test/test_run.py: add a TODO note about a test to catch
3394 just this sort of thing.
3396 * buildbot/process/builder.py (Builder.attached): remove the
3397 already-attached warning, this situation is normal. Add some
3398 comments explaining it.
3400 2005-10-02 Brian Warner <warner@lothar.com>
3402 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3403 OverflowError when setting up dnotify, because some 64-bit systems
3404 have problems with signed-vs-unsigned constants and trip up on the
3405 DN_MULTISHOT flag. Patch from Brad Hards.
3407 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3409 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3410 progressMetrics, description, descriptionDone to the 'parms' list,
3411 and make use the 'parms' list from the implementation class
3412 instead of only BuildStep to initialize the parameters. This
3413 allows buildbot.process.factory.s() to initialize all the parms,
3414 not just those defined in directly by BuildStep.
3416 2005-09-03 Brian Warner <warner@lothar.com>
3418 * NEWS: start adding items for the next release
3420 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3421 python2.2 tests, change 'Quick' builder to only use python2.3
3423 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3425 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3426 the "Ping Builder" button if the build control is available; the
3427 user sees an exception otherwise
3429 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3431 2005-09-01 Brian Warner <warner@lothar.com>
3433 * buildbot/interfaces.py (IBuilderStatus.getState): update
3434 signature, point out that 'build' can be None
3435 (IBuildStatus.getETA): point out ETA can be none
3437 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3439 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3441 2005-08-31 Brian Warner <warner@lothar.com>
3443 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3444 update to match correct signature: removed 'eta' argument
3445 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3447 2005-08-30 Brian Warner <warner@lothar.com>
3449 * buildbot/status/builder.py (LogFile): remove the assertion that
3450 blows up when you try to overwrite an existing logfile, instead
3451 just emit a warning. This case gets hit when the buildmaster is
3452 killed and doesn't get a chance to write out the serialized
3453 BuilderStatus object, so the .nextBuildNumber attribute gets out
3456 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3457 the 'buildbot sendchange' arguments, for the Darcs context file
3458 * docs/buildbot.texinfo (sendchange): document it
3460 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3461 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3462 (IStatus.getSchedulers): new method
3463 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3464 (Status.getSchedulers): implement
3465 * buildbot/process/builder.py (Builder): maintain
3466 BuilderStatus.pendingBuilds
3467 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3468 (TryBase.addChange): Try schedulers should ignore Changes
3470 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3471 for 'try' on CVS/SVN
3472 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3474 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3475 report status properly.
3476 (Try.createJob): implement unique buildset IDs
3478 * buildbot/status/client.py (StatusClientPerspective): add a
3479 perspective_getBuildSets method for the benefit of jobdir-style
3481 * docs/buildbot.texinfo (try): more docs
3482 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3485 2005-08-18 Brian Warner <warner@lothar.com>
3487 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3488 actually work. It's functional but still kind of clunky. Also, it
3489 only works with the pb-style.. needs to be made to work with the
3492 * buildbot/status/client.py (RemoteBuildSet): new class
3493 (RemoteBuildRequest): same
3494 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3495 object, not the internal BuildStatus object.
3496 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3497 outside of the usual buildStarted() return value.
3498 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3500 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3501 (Try_Userpass_Perspective.perspective_try): return a remotely
3502 usable BuildSetStatus object
3504 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3505 isStarted()/waitUntilStarted()
3507 2005-08-16 Brian Warner <warner@lothar.com>
3509 * buildbot/status/builder.py: implement IBuildSetStatus and
3510 IBuildRequestStatus, wire them into place.
3511 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3512 methods into the BuildSetStatus object.
3513 * buildbot/interfaces.py: same
3514 (IStatus.getBuildSets): new method to get pending BuildSets
3515 (IStatusReceiver.buildsetSubmitted): new method which hears about
3517 * buildbot/master.py (BuildMaster.submitBuildSet): same
3518 * buildbot/process/base.py (BuildRequest): same, replace
3519 waitUntilStarted with subscribe/unsubscribe
3520 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3521 subscribe instead of waitUntilStarted
3522 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3524 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3526 * buildbot/test/test_buildreq.py: update for new code
3527 * buildbot/test/test_control.py (Force.testRequest): same
3530 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3531 for Darcs to not use the tempfile module, so it works under
3532 python-2.2 too. We really didn't need the full cleverness of that
3533 module, since the slave has exclusive control of its own builddir.
3535 2005-08-15 Brian Warner <warner@lothar.com>
3537 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3538 for CVS trees. It doesn't work for non-trunk branches,
3540 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3543 * Makefile: make it easier to test against python2.2
3545 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3546 tearDown2, so things like Arch can unregister archives as they're
3547 shutting down. The previous subclass-override-tearDown technique
3548 resulted in a nested maybeWait() and test failures under
3551 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3552 where we can (Arch), add a branch= argument to set the branch used
3554 (BazExtractor): extract the branch too
3555 (TlaExtractor): same
3556 * buildbot/scripts/runner.py (TryOptions): add --branch
3557 * docs/buildbot.texinfo (try): document --branch/try_branch
3559 * buildbot/slave/commands.py (Darcs): implement get-revision for
3560 Darcs, so that 'try' will work. This requires the tempfile module
3563 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3564 of revisions, branches, and 'try' in the process.
3566 2005-08-11 Brian Warner <warner@lothar.com>
3568 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3569 this, it got broken at some point in the last few releases
3570 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3571 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3572 specifically the removal of ETA information from the tuple
3574 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3577 * docs/buildbot.texinfo (try): document both --builder and
3578 'try_builders' in .buildbot/options
3579 * buildbot/scripts/runner.py (TryOptions): add --builder,
3580 accumulate the values into opts['builders']
3581 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3582 * buildbot/test/test_runner.py (Try): add some quick tests to make
3583 sure 'buildbot try --options' and .buildbot/options get parsed
3584 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3585 use --builder control
3587 * docs/buildbot.texinfo (try): add --port argument to PB style
3589 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3590 actual SourceStamp. Still need to extract a branch name, somehow.
3591 (Try): finish implementing the try client side, still need a UI
3592 for specifying which builders to use
3593 (Try.getopt): factor our options/config-file reading
3594 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3596 * buildbot/test/test_vc.py: match SourceStampExtractor change
3598 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3599 causes the twisted log to be sent to stderr
3601 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3603 2005-08-10 Brian Warner <warner@lothar.com>
3605 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3606 style is 90% done, still missing status reporting or waiting for
3607 the buildsets to finish, and it is completely untested.
3609 * buildbot/trybuild.py: delete file, move contents to ..
3610 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3611 * buildbot/test/test_vc.py: match the move
3613 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3614 of the TryScheduler, no buildsetID or status-tracking support yet
3615 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3617 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3618 possible to set the basedir after __init__ time, so it is easier
3619 to use as a Service-child of the BuildMaster instance
3621 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3622 that delivers messages to its Service parent instead of requiring
3623 a subclass to be useful. This turns out to be much easier to build
3626 * buildbot/scripts/tryclient.py (createJob): utility code to
3627 create jobfiles, will eventually be used by 'buildbot try'
3629 2005-08-08 Brian Warner <warner@lothar.com>
3631 * docs/buildbot.texinfo (try): add docs on the
3632 as-yet-unimplemented Try scheduler
3634 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3635 * buildbot/test/test_scheduler.py: .. here
3636 (Scheduling.testTryJobdir): add placeholder test for 'try'
3638 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3639 addEntry merging (>=chunkSize) behavior
3640 (Log.testConsumer): update to handle new callLater(0) behavior
3642 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3643 both the MAX_LENGTH bugfix and the resumeProducing hang.
3645 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3646 put off the actual resumeProducing for a moment with
3647 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3648 causes large logfiles to hang midway through.
3650 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3651 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3652 and to improve memory usage when streaming the file out to a web
3654 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3655 make this work cleanly
3657 2005-08-03 Brian Warner <warner@lothar.com>
3659 * buildbot/trybuild.py: new file for 'try' utilities
3660 (getSourceStamp): run in a tree, find out the baserev+patch
3661 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3662 implemented for SVN and Darcs, still working on Arch. I don't know
3663 how to make CVS work yet.
3665 * docs/buildbot.texinfo: document the 'buildbot' command-line
3666 tool, including the not-yet-implemented 'try' feature, and the
3667 in-flux .buildbot/ options directory.
3669 2005-07-20 Brian Warner <warner@lothar.com>
3671 * buildbot/locks.py: added temporary id() numbers to Lock
3672 descriptions, to track down a not-really-sharing-the-Lock bug
3674 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3676 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3677 needed for python2.2 compatibility
3678 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3679 are from the __future__
3681 2005-07-19 Brian Warner <warner@lothar.com>
3683 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3684 message when schedulers use unknown builders
3686 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3687 SlaveLock('name') and MasterLock('name') are distinct
3689 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3690 c['schedulers'] in such a way that we can actually accept
3692 * buildbot/test/test_config.py: check it
3694 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3695 utility method to *all* the Schedulers
3696 (Periodic.listBuilderNames): same
3698 * docs/buildbot.texinfo (Interlocks): update chapter to match
3701 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3702 to make sure that c['sources'], c['schedulers'], and c['status']
3703 are all lists of the appropriate objects, and that the Schedulers
3704 all point to real Builders
3705 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3706 'listBuilderNames' utility method to support this
3707 * buildbot/scheduler.py: implement the utility method
3708 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3710 * docs/buildbot.texinfo: add some @cindex entries
3712 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3713 if it wasn't already set: most tla commands will fail unless one
3715 (Arch.createRepository): and disable bazaar's revision cache, since
3716 they cause test failures (the multiple repositories we create all
3717 interfere with each other through the cache)
3719 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3720 bring it properly up to date with twisted-2.0 test guidelines
3722 * buildbot/master.py (BuildMaster): remove references to old
3723 'interlock' module, this caused a bunch of post-merge test
3725 * buildbot/test/test_config.py: same
3726 * buildbot/process/base.py (Build): same
3728 * buildbot/test/test_slaves.py: stubs for new test case
3730 * buildbot/scheduler.py: add test-case-name tag
3731 * buildbot/test/test_buildreq.py: same
3733 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3734 unnecessary init code
3735 (Bot.remote_setBuilderList): match it
3737 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3739 * buildbot/changes/mail.py (parseSyncmail): update comment
3741 * buildbot/test/test_slavecommand.py: disable Shell tests on
3742 platforms that don't suport IReactorProcess
3744 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3745 all places where we open logfiles. It causes OS-X to open the file
3746 in some weird mode that that prevents us from mixing reads and
3747 writes to the same filehandle, which we depend upon to implement
3748 _generateChunks properly. This change doesn't appear to break
3749 win32, on which "b" and "t" are treated differently but a missing
3750 flag seems to be interpreted as "t".
3752 2005-07-18 Brian Warner <warner@lothar.com>
3754 * buildbot/slave/commands.py (ShellCommand): overhaul
3755 error-handling code, to try and make timeout/interrupt work
3756 properly, and make win32 happier
3757 * buildbot/test/test_slavecommand.py: clean up, stop using
3758 reactor.iterate, add tests for timeout and interrupt
3759 * buildbot/test/sleep.py: utility for a new timeout test
3761 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3762 code from the local-usebranches branch
3764 2005-07-17 Brian Warner <warner@lothar.com>
3766 * buildbot/process/process_twisted.py
3767 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3768 minutes, to match the other twisted BuildFactories, and don't
3769 excuse failures in c/qt/win32 reactors any more.
3771 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3772 'freebsd' builders, since the buildslaves have been unavailable
3775 2005-07-13 Brian Warner <warner@lothar.com>
3777 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3778 build-on-branch feature
3780 * buildbot/process/step.py (Darcs.__init__): add base_url and
3781 default_branch arguments, just like SVN
3782 (Arch.__init__): note that the version= argument is really the
3785 * buildbot/slave/commands.py (SourceBase): keep track of the
3786 repository+branch that was used for the last checkout in
3787 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3788 match, we clobber the directory and perform a fresh checkout
3789 rather than trying to do an in-place update. This should protect
3790 us against trying to get to branch B by doing an update in a tree
3791 obtained from branch A.
3792 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3793 (SVN.setup): same, just the svnurl
3794 (Darcs.setup): same, just the repourl
3795 (Arch.setup): same, arch coordinates (url), version, and
3796 buildconfig. Also pull the buildconfig from the args dictionary,
3797 which we weren't doing before, so the build-config was effectively
3799 (Arch.sourcedirIsUpdateable): don't try to update when we're
3800 moving to a specific revision: arch can't go backwards, so it is
3801 safer to just clobber the tree and checkout a new one at the
3803 (Bazaar.setup): same sourcedata as Arch
3805 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3806 use maybeWait, to work with twisted-1.3.0 and twcompat
3807 (Dependencies.testRun_Pass): same
3809 * buildbot/test/test_vc.py: rearrange, cleanup
3811 * buildbot/twcompat.py: add defer.waitForDeferred and
3812 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3813 can work under twisted-1.3.0 .
3815 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3816 now created at setUp time. This increases the runtime of the test
3817 suite considerably (from 91 seconds to 151), but it removes the
3818 need for an offline tarball, which should solve a problem I've
3819 seen where the test host has a different version of svn than the
3820 tarball build host. The new code also validates that mode=update
3821 really picks up recent commits. This approach will also make it
3822 easier to test out branches, because the code which creates the VC
3823 branches is next to the code which uses them. It will also make it
3824 possible to test some change-notification hooks, by actually
3825 performing a VC commit and watching to see the ChangeSource get
3828 2005-07-12 Brian Warner <warner@lothar.com>
3830 * docs/buildbot.texinfo (SVN): add branches example
3831 * docs/Makefile (buildbot.ps): add target for postscript manual
3833 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3834 * buildbot/test/test_locks.py: same
3836 * buildbot/process/step.py (Darcs): comment about default branches
3838 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3839 c['interlocks'] in the config file, complain if it is present.
3840 Scan all locks in c['builders'] to make sure the Locks they use
3842 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3843 add some tests to check for non-uniquely-named Locks
3844 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3845 since the unique-Lock validation code requires it now
3847 * buildbot/locks.py: fix test-case-name
3849 * buildbot/interlock.py: remove old file
3851 2005-07-11 Brian Warner <warner@lothar.com>
3853 * buildbot/test/test_interlock.py: rename to..
3854 * buildbot/test/test_locks.py: .. something shorter
3856 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3857 versions (after 2.0.1) changed internet.TCPClient to shut down the
3858 connection in stopService. Change the code to handle this
3861 * buildbot/process/base.py (Build): handle whole-Build locks
3862 * buildbot/process/builder.py (Builder.compareToSetup): same
3863 * buildbot/test/test_interlock.py: make tests work
3865 * buildbot/process/step.py (BuildStep.startStep): complain if a
3866 Step tries to claim a lock that's owned by its own Build
3867 (BuildStep.releaseLocks): typo
3869 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3870 file reloads don't replace unchanged Builders
3872 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3873 rewrite to cover new Locks instead of old c['interlocks']
3874 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3878 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3879 start the master and connect the buildslave
3881 * buildbot/process/step.py (FailingDummy.done): finish with a
3882 FAILURE status rather than raising an exception
3884 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3885 stringify a BuildRequest.reason that is None
3887 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3889 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3890 allow scheduler.Dependent to work
3891 * buildbot/buildset.py (BuildSet): set .reason and .results
3893 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3894 slaves, to make the test stop hanging. It still fails, of course,
3895 because I haven't even started to implement Locks.
3897 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3899 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3900 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3901 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3902 (Dependent): new class for downstream build dependencies
3903 * buildbot/test/test_dependencies.py: tests (still failing)
3905 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3907 2005-07-07 Brian Warner <warner@lothar.com>
3909 * buildbot/test/runutils.py (RunMixin): factored this class out..
3910 * buildbot/test/test_run.py: .. from here
3911 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3912 added new buildbot.locks tests (which all hang right now)
3913 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3914 * buildbot/process/step.py: claim/release per-BuildStep locks
3916 * docs/Makefile: add 'buildbot.html' target
3918 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3919 interpreted as "HEAD", so that all VC steps can accept branch=None
3920 and have it mean the "default branch".
3922 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3924 2005-07-07 Brian Warner <warner@lothar.com>
3926 * docs/examples/twisted_master.cfg: update to match current usage
3928 * docs/buildbot.texinfo (System Architecture): comment out the
3929 image, it doesn't exist yet and just screws up the HTML manual.
3931 2005-07-05 Brian Warner <warner@lothar.com>
3933 * debian/.cvsignore: oops, missed one. Removing leftover file.
3935 2005-06-17 Brian Warner <warner@lothar.com>
3937 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3938 changed its output in 1.2.0, don't mistakenly think that the
3939 subversion we find isn't capable of supporting our tests.
3941 * debian/*: remove the debian/ directory and its contents, to make
3942 life easier for the proper Debian maintainer
3944 * Makefile (release): same
3946 2005-06-07 Brian Warner <warner@lothar.com>
3948 * everything: create a distinct SourceStamp class to replace the
3949 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3950 Changed the signature of Source.startVC to include the revision
3951 information (instead of passing it through self.args). Implement
3952 branches for SVN (now only Darcs/Git is missing support). Add more
3955 2005-06-06 Brian Warner <warner@lothar.com>
3957 * everything: rearrange build scheduling. Create a new Scheduler
3958 object (configured in c['schedulers'], which submit BuildSets to a
3959 set of Builders. Builders can now use multiple slaves. Builds can
3960 be run on alternate branches, either requested manually or driven
3961 by changes. This changed some of the Status classes. Interlocks
3962 are out of service until they've been properly split into Locks
3963 and Dependencies. treeStableTimer, isFileImportant, and
3964 periodicBuild have all been moved from the Builder to the
3966 (BuilderStatus.currentBigState): removed the 'waiting' and
3967 'interlocked' states, removed the 'ETA' argument.
3969 2005-05-24 Brian Warner <warner@lothar.com>
3971 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3972 erroneously abandons the connection (in clientConnectionFailed)
3973 for non-UserErrors, which means that if we lose the connection due
3974 to a network problem or a timeout, we'll never try to reconnect.
3975 Fix this by not upcalling to the buggy parent method. Note:
3976 twisted-2.0 fixes this, but the function only has 3 lines so it
3977 makes more sense to copy it than to try and detect the buggyness
3978 of the parent class. Fixes SF#1207588.
3980 * buildbot/changes/changes.py (Change.branch): doh! Add a
3981 class-level attribute to accomodate old Change instances that were
3982 pickled before 0.6.5 (where .branch was added for new Changes).
3983 This fixes the exception that occurs when you try to look at an
3984 old Change (through asHTML).
3986 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3989 2005-05-23 Brian Warner <warner@lothar.com>
3991 * buildbot/__init__.py (version): release 0.6.6
3993 2005-05-23 Brian Warner <warner@lothar.com>
3995 * NEWS: update for 0.6.6 release
3996 * debian/changelog: same
3998 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3999 before starting: this was done by twistd back when we spawned it,
4000 now that we're importing the pieces and running them in the
4001 current process, we have to do it ourselves. This allows
4002 master.cfg to import files from the same directory without
4003 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4004 Stichele for the catch.
4005 (Options.opt_version): Add a --version command (actually, just make
4006 the existing --version command emit Buildbot's version too)
4008 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4009 fix to make this behave like other LogFiles, this time to handle
4010 existing LogFiles on disk. (add the missing .upgrade method)
4011 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4013 2005-05-21 Brian Warner <warner@lothar.com>
4015 * buildbot/test/test_runner.py (Create.testMaster): match the
4016 rawstring change in runner.py:masterTAC
4018 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4019 TwistedWords is installed
4020 * buildbot/test/test_status.py: same, with TwistedMail
4022 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4023 some old, deprecated, and removed config keys). This should enable
4024 you to use the base buildbot functionality with Twisted-2.0.0 when
4025 you don't also have TwistedWeb and TwistedWords installed
4027 2005-05-20 Brian Warner <warner@lothar.com>
4029 * buildbot/scripts/runner.py (run): call sendchange(), not
4030 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4031 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4032 (stop): don't wait for process to die when sending SIGHUP
4033 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4034 directory name gets interpreted, which you don't want
4037 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4040 2005-05-18 Brian Warner <warner@lothar.com>
4042 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4044 2005-05-18 Brian Warner <warner@lothar.com>
4046 * README: update for 0.6.5
4047 * debian/changelog: same
4049 * buildbot/changes/changes.py: rename tag= to branch=, since
4050 that's how we're using it, and my design for the upcoming "build a
4051 specific branch" feature wants it. also, tag= was too CVS-centric
4052 * buildbot/changes/mail.py (parseSyncmail): same
4053 * buildbot/process/base.py (Build.isBranchImportant): same
4054 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4055 * docs/buildbot.texinfo (Attributes of Changes): same
4057 * NEWS: update tag=, update for upcoming release
4059 2005-05-17 Brian Warner <warner@lothar.com>
4061 * buildbot/scripts/runner.py (stop): actually poll once per
4062 second, instead of re-killing the poor daemon once per second.
4063 Sleep briefly (0.1s) before the first poll, since there's a good
4064 chance we can avoid waiting the full second if the daemon shuts
4065 down quickly. Also remove the sys.exit() at the end.
4066 (start): remove the unneighborly sys.exit()
4068 * Makefile: improve permission-setting to not kick Arch so badly
4070 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4071 default --keepalive=600, since it doesn't hurt very much, and it's
4072 a hassle to discover that you need it.
4073 * buildbot/test/test_runner.py (Create.testSlave): test it
4075 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4076 IRC bot about EXCEPTION
4078 * buildbot/status/client.py (PBListener): upcall more correctly
4080 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4081 an exception mark the overall build with EXCEPTION, not SUCCESS
4083 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4085 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4086 * Makefile: update some release-related stuff
4088 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4089 gets called when there isn't actually an active process, just end
4090 the Command instead of blowing up. I don't know how it gets into
4091 this state, but the twisted win32 buildslave will sometimes hang,
4092 and when it shakes its head and comes back, it thinks it's still
4093 running a Command. The next build causes this command to be
4094 interrupted, but the lack of self.process.pid breaks the interrupt
4097 * NEWS: document changes since the last release
4099 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4100 look for Makefile.buildbot instead of a bare Makefile . The
4101 'buildbot start' does not install this file, so you have to
4102 manually copy it if you want to customize startup behavior.
4103 (createMaster): change 'buildbot master' command to create
4104 Makefile.sample instead of Makefile, to create master.cfg.sample
4105 instead of master.cfg (requiring you to copy it before the
4106 buildmaster can be started). Both sample files are kept up to
4107 date, i.e. they are overwritten if they have been changed. The
4108 'buildbot.tac' file is *not* overwritten, but if the new contents
4109 don't match the old, a 'buildbot.tac.new' file is created and the
4110 user is warned. This seems to be a much more sane way to handle
4111 startup files. Also, don't sys.exit(0) when done, so we can run
4112 unit tests against it.
4113 (createSlave): same. Don't overwrite the sample info/ files.
4114 * buildbot/scripts/sample.mk: remove. the contents were pulled
4115 into runner.py, since they need to match the behavior of start()
4119 * docs/buildbot.texinfo (Launching the daemons): document it
4120 * buildbot/test/test_runner.py (Create): test it
4122 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4123 version that can handle string-in-string tests, because otherwise
4124 python-2.2 fails the tests. It'd be tremendous if Trial's test
4125 took two strings under 2.2 too.
4127 * everything: fixed all deprecation warnings when running against
4128 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4129 few that come from Twisted itself). This involved putting most of
4130 the Twisted-version specific code in the new buildbot.twcompat
4131 module, and creating some abstract base classes in
4132 buildbot.changes.base and buildbot.status.base (which might be
4133 useful anyway). __implements__ is a nuisance and requires an ugly
4134 'if' clause everywhere.
4136 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4137 delay before finishing the test: it seems that smtp.sendmail
4138 doesn't hang up on the server, so we must wait a moment so it can
4139 hang up on us. This removes the trial warning about an unclean
4142 2005-05-16 Brian Warner <warner@lothar.com>
4144 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4145 tuple of (delay, repeats).
4146 * buildbot/test/test_vc.py (Retry): test it
4147 * docs/buildbot.texinfo (Source Checkout): document it
4148 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4149 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4150 doVCFull() are handled by re-trying the checkout (after a delay)
4151 some number of times.
4152 (ShellCommand._startCommand): make header lines easier to read
4154 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4156 (WebTest.test_logfile): make sure master gets shut down, silences
4157 some "unclean reactor" test errors
4159 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4160 reactor once after shutdown, something in certain versions of
4161 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4162 fails, svn-trunk is ok.
4164 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4165 second win32 error message
4167 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4168 validating the ETA, so the tests don't fail on slow systems
4170 2005-05-15 Brian Warner <warner@lothar.com>
4172 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4173 the new LogFile class, so upgrading works properly
4174 (LogFileProducer.resumeProducing): survive resumeProducing after
4175 we've exhausted the chunkGenerator
4177 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4179 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4180 (Log.testUpgrade): same
4182 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4183 Builds and logs with a cron job.
4185 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4186 of the old non-offline LogFile, added code to upgrade these to
4187 new-style contents-live-on-disk instances at load time (in a way
4188 that doesn't invalidate the old Build pickles, so upgrading to
4189 0.6.5 is not a one-way operation). Got rid of everything related
4191 (LogFile.__init__): create LogFiles with the parent step status,
4192 the log's name, and a builder-relative filename where it can keep
4193 the contents on disk.
4194 (LogFile.hasContents): new method, clients are advised to call it
4195 before getText or getChunks and friends. If it returns False, the
4196 log's contents have been deleted and getText() will raise an
4198 (LogFile.getChunks): made it a generator
4199 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4200 Consumer (except one that takes chunks instead of strings). This
4201 enables streaming of very large logfiles without storing the whole
4203 (BuildStatus.generateLogfileName): create names like
4204 12-log-compile-output, with a _0 suffix if required to be unique
4205 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4206 or earlier) logfiles into new-style ones
4207 (BuilderStatus): remove everything related to 'stub' builds. There
4208 is now only one build cache, and we don't strip logs from old
4210 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4211 since we no longer fight to keep it in the cache
4213 * buildbot/status/html.py (TextLog.render_GET): use a
4214 ChunkConsumer to stream the log entries efficiently.
4215 (ChunkConsumer): wrapper which consumes chunks and writes
4218 * buildbot/test/test_twisted.py (Parse.testParse): use a
4219 LogFile-like object instead of a real one
4221 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4222 (Log.testMerge3): validate more merge behavior
4223 (Log.testChunks): validate LogFile.getChunks
4224 (Log.testUpgrade): validate old-style LogFile upgrading
4225 (Log.testSubscribe): validate LogFile.subscribe
4226 (Log.testConsumer): validate LogFile.subscribeConsumer
4228 * buildbot/interfaces.py (IStatusLogStub): remove
4229 (IStatusLog.subscribeConsumer): new method
4230 (IStatusLog.hasContents): new method
4231 (IStatusLogConsumer): describes things passed to subscribeConsumer
4233 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4234 the log contents if it does not have any contents.
4235 (StatusResourceBuildStep.body): same
4236 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4238 2005-05-14 Brian Warner <warner@lothar.com>
4240 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4241 timeouts to try and make the windows metabuildslave not hang
4243 2005-05-13 Mike Taylor <bear@code-bear.com>
4245 * buildbot/slave/commands.py (rmdirRecursive): added a check
4246 to ensure the path passed into rmdirRecursive actually exists.
4247 On win32 a non-existant path would generate an exception.
4249 2005-05-13 Brian Warner <warner@lothar.com>
4251 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4252 shutil.rmtree which behaves correctly on windows in the face of
4253 files that you have to chmod before deleting. Thanks to Bear at
4254 the OSAF for the routine.
4255 (SourceBase.doClobber): use rmdirRecursive
4257 2005-05-12 Brian Warner <warner@lothar.com>
4259 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4260 method generate chunks instead of returning a big list. This
4261 allows the same method to be used for both old LogFile and new
4263 (OfflineLogFile.getText): use the generator
4264 (OfflineLogFile.subscribe): same
4265 * buildbot/status/html.py (TextLog.resumeProducing): same
4266 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4268 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4269 point out that OfflineLogFile does not currently work with
4270 html.Waterfall . Fixing this is high-priority.
4272 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4273 apparently windows defaults to using stdout
4275 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4276 better message on failure so I can figure out the win32 problem
4278 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4279 log messages to include more useful copies of the command being
4280 run, the argv array, and the child command's environment.
4281 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4283 2005-05-11 Brian Warner <warner@lothar.com>
4285 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4287 * Makefile: update the deb-snapshot version
4289 * docs/buildbot.texinfo: move all .xhtml docs into a new
4290 .texinfo-format document, adding a lot of material in the process.
4291 This is starting to look like a real user's manual. Removed all
4292 the Lore-related files: *.xhtml, *.css, template.tpl .
4293 * docs/Makefile: simple makefile to run 'makeinfo'
4294 * buildbot/scripts/sample.cfg: rearrange slightly
4295 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4297 2005-05-10 Brian Warner <warner@lothar.com>
4299 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4300 different name for the internal twistw module, handle it.
4302 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4303 * setup.py: .. and stop trying to install it
4305 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4306 'git'), the new linux kernel VC system (http://kernel.org/git/).
4307 Thanks to Brandon Philips for the patch.
4308 * buildbot/slave/commands.py (Git): same
4310 2005-05-06 Brian Warner <warner@lothar.com>
4312 * buildbot/status/builder.py (OfflineLogFile): replace the default
4313 LogFile with a form that appends its new contents to a disk file
4314 as they arrive. The complete log data is never kept in RAM. This
4315 is the first step towards handling very large (100MB+) logfiles
4316 without choking quite so badly. (The other half is
4317 producer/consumer on the HTML pages).
4318 (BuildStepStatus.addLog): use OfflineLogFile by default
4319 (BuildStatus.getLogfileName): helper code to give the
4320 OfflineLogFile a filename to work with
4322 * buildbot/test/test_status.py (Results.testAddResults): update
4323 tests to handle new asserts
4324 * buildbot/test/test_vc.py (Patch.doPatch): same
4325 * buildbot/test/test_steps.py (BuildStep.setUp): same
4327 2005-05-05 Brian Warner <warner@lothar.com>
4329 * buildbot/scripts/runner.py (start): if there is no Makefile,
4330 launch the app by importing twistd's internals and calling run(),
4331 rather than spawning a new twistd process. This stands a much
4332 better chance of working under windows.
4333 (stop): kill the process with os.kill instead of spawning
4334 /bin/kill, again to reduce the number of external programs which
4335 windows might not have in the PATH. Also wait up to 5 seconds for
4336 the process to go away, allowing things like 'buildbot stop;
4337 buildbot start' to be reliable in the face of slow shutdowns.
4339 * buildbot/master.py (Dispatcher.__getstate__): remove old
4340 .tap-related methods
4341 (BuildMaster.__getstate__): same
4343 * buildbot/slave/bot.py (makeService): same
4344 (Options.longdesc): same
4345 * buildbot/scripts/runner.py: copy over some old mktap option text
4347 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4348 'buildbot master' now creates a buildbot.tac file, so there is no
4349 longer a create-instance/save/reload sequence. mktap is dead, long
4351 * buildbot/scripts/sample.mk: use twistd -y, not -f
4352 * buildbot/test/test_config.py: remove mktap-based test
4353 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4354 * README: don't reference mktap
4356 * docs/source.xhtml: document some of the attributes that Changes
4359 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4361 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4362 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4363 * buildbot/changes/changes.py (Change)
4364 * buildbot/changes/mail.py (parseSyncmail)
4365 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4367 * buildbot/process/base.py (Build.isTagImportant)
4371 2005-05-04 Brian Warner <warner@lothar.com>
4373 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4374 connection after sending the change, so that unit tests don't
4375 complain about sockets being left around
4377 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4378 exception in phase=0 rendering
4379 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4381 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4383 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4384 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4385 and configuring builders with tuples.
4386 * buildbot/test/test_config.py: stop testing compatibility with
4387 deprecated config keys
4388 * buildbot/test/test_run.py: same
4390 2005-05-03 Brian Warner <warner@lothar.com>
4392 * contrib/arch_buildbot.py: survive if there are no logfiles
4393 (username): just use a string, os.getlogin isn't reliable
4395 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4396 so 'buildbot sendchange' actually works. The earlier test only
4397 covered the internal (non-reactor-running) form.
4399 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4400 script to notify the buildmaster about changes
4402 * buildbot/scripts/runner.py (sendchange): new command to send a
4403 change to a buildbot.changes.pb.PBChangeSource receiver.
4404 * buildbot/test/test_changes.py (Sender): test it
4406 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4407 after any reading of the config file, not just when we do it in
4408 startService. This makes some tests a bit cleaner.
4410 * buildbot/changes/pb.py: add some log messages
4412 * buildbot/process/base.py (Build.startBuild): fix a bug that
4413 caused an exception when the build terminated in the very first
4415 (Build.stepDone): let steps return a status of EXCEPTION. This
4416 terminates the build right away, and sets the build's overall
4417 status to EXCEPTION too.
4418 * buildbot/process/step.py (BuildStep.failed): return a status of
4419 EXCEPTION when that is what has happened.
4421 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4422 implement this, allowing Arch-based projects to get precise
4423 checkouts instead of always using the latest code
4424 (Bazaar): create variant of Arch to let folks use baz instead of
4425 tla. Requires a new buildslave too.
4426 * buildbot/slave/commands.py (Arch): add 'revision' argument
4427 (Bazaar): create variant of Arch that uses baz instead of tla.
4428 Remove the code that extracts the archive name from the
4429 register-archive output, since baz doesn't provide it, and require
4430 the user provide both the archive name and its location.
4431 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4433 2005-05-02 Brian Warner <warner@lothar.com>
4435 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4436 thanks to Nick Trout.
4438 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4439 deals better with source Makefile coming from a read-only CVS
4440 checkout. Thanks to Nick Trout for the catch.
4442 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4445 2005-04-28 Brian Warner <warner@lothar.com>
4447 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4449 * debian/changelog: update for 0.6.4
4451 2005-04-28 Brian Warner <warner@lothar.com>
4453 * README.w32: add a checklist of steps for getting buildbot
4455 * MANIFEST.in: include it in the tarball
4459 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4460 broken .tap files from 0.6.3 by getting rid of .services,
4461 .namedServices, and .change_svc at load time.
4463 2005-04-27 Brian Warner <warner@lothar.com>
4465 * NEWS: update in preparation for new release
4467 * buildbot/test/test_config.py (Save.testSave): don't pull in
4468 twisted.scripts.twistd, we don't need it and it isn't for windows
4471 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4472 accomodate win32 which can't do atomic-rename
4474 2005-04-27 Brian Warner <warner@lothar.com>
4476 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4477 timeouts to help the slow metabuildbot not flunk them so much
4478 (Disconnect.testBuild3): same
4479 (Disconnect.testBuild4): same
4480 (Disconnect.testInterrupt): same
4482 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4483 setup, it was completely broken for new buildmasters (those which
4484 did not have a 'change.pck' already saved. Thanks to Paul Warren
4485 for catching this (embarrassing!) bug.
4486 (Dispatcher.__getstate__): don't save our registered avatar
4487 factories, since they'll be re-populated when the config file is
4489 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4490 tests (since the real mktap-generated BuildMaster doesn't save
4492 (BuildMaster.__getstate__): don't save any service children,
4493 they'll all be re-populated when the config file is re-read.
4494 * buildbot/test/test_config.py (Save.testSave): test for this
4496 2005-04-26 Brian Warner <warner@lothar.com>
4498 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4499 rendered with Blender.. looks a bit nicer.
4500 * buildbot/docs/images/icon.blend: add the Blender file for it
4502 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4503 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4504 running under windows. This appears to be the best way to allow
4505 BuildSteps to do something normal like 'trial -v buildbot.test' or
4506 'make foo' and still expect it to work. The idea is to make the
4507 BuildSteps look as much like what a developer would type when
4508 compiling or testing the tree by hand. This approach probably has
4509 problems when there are spaces in the arguments, so if you've got
4510 windows buildslaves, you'll need to pay close attention to your
4513 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4514 timezone to the timestamp column.
4515 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4517 * buildbot/scripts/runner.py (loadOptions): do something sane for
4518 windows, I think. We use %APPDATA%/buildbot instead of
4519 ~/.buildbot, but we still search everywhere from the current
4520 directory up to the root for a .buildbot/ subdir. The "is it under
4521 $HOME" security test was replaced with "is it owned by the current
4522 user", which is only performed under posix.
4523 * buildbot/test/test_runner.py (Options.testFindOptions): update
4524 tests to match. The "is it owned by the current user" check is
4525 untested. The test has been re-enabled for windows.
4527 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4528 any "\n" in the expected output with the platform-specific line
4529 separator. Make this separator "\r\n" on PTYs under unix, they
4530 seem to do that and I don't know why
4532 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4533 windows for now, I don't know what ~/.buildbot/ should mean there.
4535 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4536 win32 compatibility, don't use "/tmp"
4537 (Basedir.testChangeBuilddir): remove more unixisms
4539 2005-04-26 Brian Warner <warner@lothar.com>
4541 * buildbot/test/test_control.py (Force.rmtree): python2.2
4542 compatibility, apparently its shutil.rmtree ignore_errors=
4543 argument is ignored.
4544 * buildbot/test/test_run.py (Run.rmtree): same
4545 (RunMixin.setUp): same
4547 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4550 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4551 'substring in string' operator, must use string.find(substr)!=-1
4552 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4553 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4555 * buildbot/scripts/runner.py (loadOptions): add code to search for
4556 ~/.buildbot/, a directory with things like 'options', containing
4557 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4558 the current directory, your $HOME directory, or anywhere
4559 inbetween, as long as you're somewhere inside your home directory.
4560 (debugclient): look in ~/.buildbot/options for master and passwd
4561 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4562 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4564 * buildbot/status/client.py (makeRemote): new approach to making
4565 IRemote(None) be None, which works under Twisted-2.0
4566 * buildbot/test/test_status.py (Client.testAdaptation): test it
4568 * buildbot/status/builder.py (Status.builderAdded): when loading a
4569 pickled BuilderStatus in from disk, set its name after loading.
4570 The config file might have changed its name (but not its
4571 directory) while it wasn't looking.
4573 * buildbot/process/builder.py (Builder.attached): always return a
4574 Deferred, even if the builder was already attached
4575 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4577 2005-04-25 Brian Warner <warner@lothar.com>
4579 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4580 category-related exception when announcing a build has finished
4582 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4583 reference no-longer-existent changemaster.sources
4584 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4586 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4589 2005-04-25 Brian Warner <warner@lothar.com>
4591 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4593 * debian/changelog: update for 0.6.3
4595 2005-04-25 Brian Warner <warner@lothar.com>
4597 * MANIFEST.in: make sure debug.glade is in the tarball
4599 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4601 * NEWS: update for the imminent 0.6.3 release
4603 * buildbot/status/html.py (HtmlResource.content): make the
4604 stylesheet <link> always point at "buildbot.css".
4605 (StatusResource.getChild): map "buildbot.css" to a static.File
4606 containing whatever css= argument was provided to Waterfall()
4607 (Waterfall): provide the "classic" css as the default.
4608 * docs/waterfall.classic.css: move default CSS from here ..
4609 * buildbot/status/classic.css: .. to here
4611 * MANIFEST.in: make sure classic.css is included in the tarball
4612 * setup.py: and that it is installed too, under buildbot/status/
4614 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4615 the module level, because buildbot.tap files from 0.6.2 don't have
4616 it in their attribute dictionary.
4618 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4619 really exists at startup, might save some confusion somewhere.
4621 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4623 * docs/waterfall.classic.css:
4624 add a stylesheet that's almost the same as the "classic"
4627 * buildbot/status/builder.py:
4628 add EXCEPTION as a result - this is a problem for the bot
4629 maintainer, not a build problem for the changers
4630 * buildbot/process/step.py:
4631 use EXCEPTION instead of FAILURE for exceptions
4632 * buildbot/status/html.py:
4633 add build_get_class to get a class out of a build/buildstep
4634 finish naming the classes
4635 split out sourceNames to changeNames and builderNames so we
4636 can style them separately
4637 * docs/config.xhtml:
4638 finish documenting classes as they are right now
4640 * buildbot/status/html.py:
4641 name the classes as we agreed on IRC
4642 * docs/config.xhtml:
4645 * buildbot/status/html.py:
4646 same for cssclass->class_
4648 * buildbot/status/html.py:
4649 as decided on IRC, use class_ for the "class" attribute to not
4650 conflict with the class keyword, and clean up the messy **{} stuff.
4652 * buildbot/status/mail.py:
4653 put back "builders" argument, and fix docstring, because the
4654 code *ignores* builders listed in this argument
4656 * buildbot/process/builder.py:
4657 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4659 * docs/config.xhtml:
4660 describe the category argument for builders
4662 * buildbot/status/builder.py:
4663 Fix a silly bug due to merging
4665 * buildbot/process/builder.py:
4666 remove category from the process Builder ...
4667 * buildbot/status/builder.py:
4668 ... and add it to BuilderStatus instead.
4669 Set category on unpickled builder statuses, they might not have it.
4670 * buildbot/master.py:
4671 include category when doing builderAdded
4672 * buildbot/status/mail.py:
4673 return None instead of self for builders we are not interested in.
4674 * buildbot/test/test_run.py:
4675 fix a bug due to only doing deferredResult on "dummy" waiting
4676 * buildbot/test/test_status.py:
4677 add checks for the Mail IStatusReceiver returning None or self
4679 * buildbot/status/html.py:
4680 fix testsuite by prefixing page title with BuildBot
4682 * buildbot/status/builder.py:
4683 have .category in builder status ...
4684 * buildbot/process/builder.py:
4685 ... and set it from Builder
4686 * buildbot/status/html.py:
4687 make .css a class variable
4688 * buildbot/test/test_status.py:
4689 write more tests to cover our categories stuff ...
4690 * buildbot/status/mail.py:
4691 ... and fix the bug that this uncovered
4693 * buildbot/changes/mail.py:
4694 * buildbot/changes/pb.py:
4695 * buildbot/master.py:
4696 * buildbot/process/base.py:
4697 * buildbot/process/factory.py:
4698 * buildbot/process/interlock.py:
4699 * buildbot/process/step.py:
4700 * buildbot/process/step_twisted.py:
4701 * buildbot/slave/commands.py:
4702 * buildbot/status/builder.py:
4703 * buildbot/status/client.py:
4704 * buildbot/status/html.py:
4705 * buildbot/status/mail.py:
4706 * buildbot/status/progress.py:
4707 * buildbot/test/test_changes.py:
4708 * buildbot/test/test_config.py:
4709 * buildbot/test/test_control.py:
4710 * buildbot/test/test_interlock.py:
4711 * buildbot/test/test_maildir.py:
4712 * buildbot/test/test_mailparse.py:
4713 * buildbot/test/test_run.py:
4714 * buildbot/test/test_slavecommand.py:
4715 * buildbot/test/test_status.py:
4716 * buildbot/test/test_steps.py:
4717 * buildbot/test/test_twisted.py:
4718 * buildbot/test/test_util.py:
4719 * buildbot/test/test_vc.py:
4720 * buildbot/test/test_web.py:
4722 add test-case-name at the top of a whole set of files
4724 * buildbot/status/builder.py:
4725 keep order of addition when getting builder names
4726 * buildbot/status/words.py:
4727 * buildbot/test/test_run.py:
4728 add test for getBuilderNames
4730 * buildbot/process/base.py:
4731 * buildbot/process/step.py:
4732 * buildbot/status/builder.py:
4733 * buildbot/status/html.py:
4734 make buildbot css-able
4735 replace the color code for purple with purple, don't understand
4736 why it wasn't purple to start with
4738 * buildbot/status/words.py:
4739 ok, so it doesn't look like BuilderStatus.remote is still valid.
4740 Use what waterfall uses instead.
4742 * buildbot/interfaces.py:
4743 * buildbot/status/builder.py:
4744 * buildbot/status/html.py:
4745 * buildbot/status/mail.py:
4746 * buildbot/status/words.py:
4747 * buildbot/test/test_run.py:
4748 use categories everywhere and make it be a list. More sensible
4749 for the future. Also make words actually respect this in
4752 * buildbot/interfaces.py:
4753 add category argument to getBuilderNames
4754 * buildbot/process/builder.py:
4755 * buildbot/status/builder.py:
4756 * buildbot/status/html.py:
4757 * buildbot/status/mail.py:
4758 * buildbot/status/words.py:
4759 * buildbot/test/test_run.py:
4760 move from specifying builders by name to specifying the category
4762 * buildbot/status/html.py:
4763 * buildbot/status/words.py:
4764 add "builders=" to __init__ of status clients so they can
4765 limit themselves to the given list of builders to report on
4767 * buildbot/status/html.py: set the title to the product name
4769 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4771 * buildbot/interfaces.py:
4772 * buildbot/status/builder.py:
4773 more documentation. Hm, not sure if ChangeLog entries make sense
4776 2005-04-23 Brian Warner <warner@lothar.com>
4778 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4780 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4782 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4783 the sub-commands that log buildmaster status to stdout and to a
4784 GUI window, respectively.
4786 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4787 functionality is working again, but all the step-status and ETA
4788 stuff is missing. Commented out a lot of code pending more
4791 * buildbot/status/client.py: make sure that IRemote(None) is None
4793 * buildbot/changes/changes.py: import defer, oops
4794 (ChangeMaster): remove the .sources list, rely upon the fact that
4795 MultiServices can be treated as sequences of their children. This
4796 cleans up the add/remove ChangeSource routines a lot, as we keep
4797 exactly one list of the current sources instead of three.
4799 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4800 up an empty ChangeMaster at init time.
4801 (BuildMaster.loadChanges): if there are changes to be had from
4802 disk, replace self.change_svc with the new ones. If not, keep
4803 using the empty ChangeMaster set up in __init__.
4804 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4805 instead of a separate list, makes the code a bit cleaner.
4806 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4807 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4808 Extend the test to make sure we can get rid of the sources when
4811 2005-04-22 Brian Warner <warner@lothar.com>
4813 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4814 and info/host files when making the slave directory
4816 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4817 whendone= argument, just return the Deferred and let the caller do
4818 what they want with it.
4819 (Disconnect.testBuild1): wait for shutdownSlave
4820 (Basedir.testChangeBuilddir): new test to make sure changes to the
4821 builddir actually get propagated to the slave
4823 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4824 explicit method, rather than passing the builddir in __init__ .
4825 Make sure to update self.basedir too, this was broken before.
4826 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4827 builders and for ones that have just had their builddir changed.
4828 (BotFactory): add a class-level .perspective attribute, so
4829 BuildSlave.waitUntilDisconnected won't get upset when the
4830 connection hasn't yet been established
4831 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4832 tests can reach through it to inspect the SlaveBuilders
4834 * buildbot/process/base.py (Build.buildException): explain the
4835 log.err with a log.msg
4836 * buildbot/process/builder.py (Builder.startBuild): same
4837 (Builder._startBuildFailed): improve error message
4839 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4840 occurred because we lost the brand-new connection, retry instead
4841 of giving up. If not, it's probably an authorization failure, and
4842 it makes sense to stop trying. Make sure we log.msg the reason
4843 that we're log.err'ing the failure, otherwise test failures are
4844 really hard to figure out.
4846 * buildbot/master.py: change loadConfig() to return a Deferred
4847 that doesn't fire until the change has been fully implemented.
4848 This means any connected slaves have been updated with the new
4849 builddir. This change makes it easier to test the code which
4850 actually implements this builddir-updating.
4851 (BotPerspective.addBuilder): return Deferred
4852 (BotPerspective.removeBuilder): same
4853 (BotPerspective.attached): same
4854 (BotPerspective._attached): same. finish with remote_print before
4855 starting the getSlaveInfo, instead of doing them in parallel
4856 (BotPerspective.list_done): same
4857 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4858 actually calling slave.disconnect()
4859 (BotMaster.addBuilder): same
4860 (BotMaster.removeBuilder): same
4861 (BuildMaster.loadConfig): same
4862 (BuildMaster.loadConfig_Slaves): same
4863 (BuildMaster.loadConfig_Sources): same
4864 (BuildMaster.loadConfig_Builders): same
4865 (BuildMaster.loadConfig_status): same
4867 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4868 a Deferred that fires when the source is finally removed
4870 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4871 the previous tree on win32, where we have to do it synchronously,
4872 make sure we return a Deferred anyway.
4873 (SourceBase.doCopy): same
4875 * buildbot/scripts/runner.py (statusgui): use the text client for
4876 now, while I rewrite the Gtk one
4877 * buildbot/clients/base.py: strip out old code, leaving just the
4878 basic print-message-on-event functionality. I also remove the
4879 ReconnectingPBClientFactory, but it does at least quit when it
4880 loses the connection instead of going silent
4882 2005-04-21 Brian Warner <warner@lothar.com>
4884 * Makefile: minor tweaks
4886 * NEWS: point out deprecation warnings, new features for
4889 * buildbot/master.py (BuildMaster.loadConfig): emit
4890 DeprecationWarnings for Builders defined with tuples. Rearrange
4891 code to facility removal of deprecated configuration keys in the
4894 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4895 'buildbot' command to put a little Makefile in the target that
4896 helps you re-create the buildbot.tap file, start or stop the
4897 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4898 all the files 0600, since they contain passwords.
4899 (start): if there is a Makefile, and /usr/bin/make exists, use
4900 'make start' in preference to a raw twistd command. This lets
4901 slave admins put things like PYTHONPATH variables in their
4902 Makefiles and have them still work when the slave is started with
4903 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4904 be nice to first try the 'make' command and only fall back to
4905 twistd if it fails. TODO: the Makefile's "start" command does not
4906 add the --reactor=win32 argument when running under windows.
4907 (Options.debugclient, Options.statusgui): add sub-commands to launch
4908 the debug client (formerly in contrib/debugclient.py) and the
4909 Gtk status application (currently broken)
4910 * buildbot/clients/debug.py: move from contrib/debugclient.py
4911 * buildbot/clients/debug.glade: same
4913 * buildbot/test/test_trial.py: remove it. This requires some
4914 functionality out of Twisted that isn't there yet, and until then
4915 having it around just confuses things.
4917 * buildbot/test/test_slavecommand.py (Shell): test both with and
4918 without PTYs, and make sure that command output is properly
4919 interleaved in the with-PTY case. I think the without-PTY test
4920 should pass on windows, where we never use PTYs anyway.
4922 2005-04-20 Brian Warner <warner@lothar.com>
4924 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4926 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4928 * NEWS: start creating entries for the next release
4930 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4932 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4933 (WebTest.test_webPathname): same
4934 (WebTest.test_webPathname_port): same
4935 (WebTest.test_waterfall): use the default favicon rather than
4936 rooting around the filesystem for it. Open the expected-icon file
4937 in binary mode, to make win32 tests happier (thanks to Nick Trout
4939 * buildbot/status/html.py (buildbot_icon): win32 portability
4941 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4942 win32-compatibility fixes from Nick Trout, the "file not found" message
4943 is different under windows
4944 (FakeSlaveBuilder.__init__): clean up setup a bit
4945 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4947 2005-04-19 Brian Warner <warner@lothar.com>
4949 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4950 skip-if-repositories-are-unavailable test to not kill the trial
4951 that comes with Twisted-1.3.0
4953 * setup.py: install buildbot.png icon file when installing code
4955 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4956 environment used by the command, at least on the child side.
4958 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4959 this method needs to be added and implemented because it gets
4960 called under heavy load. I don't quite understand the
4961 producer/consumer API enough to write it.
4962 (StatusResource.getChild): add a resource for /favicon.ico
4963 (Waterfall.__init__): add favicon= argument
4964 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4965 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4966 (WebTest.test_webPathname): same
4967 (WebTest.test_webPathname_port): same
4968 * docs/config.xhtml: mention favicon=
4969 * buildbot/buildbot.png: add a default icon, dorky as it is
4971 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4973 * buildbot/master.py:
4974 * buildbot/process/base.py:
4975 * buildbot/process/builder.py:
4976 * buildbot/process/interlock.py:
4977 * buildbot/status/builder.py:
4978 * buildbot/status/html.py:
4979 * buildbot/status/mail.py:
4980 * buildbot/status/words.py:
4981 new documentation while digging through the code
4983 2005-04-17 Brian Warner <warner@lothar.com>
4985 * general: try to fix file modes on all .py files: a+r, a-x,
4986 but let buildbot/clients/*.py be +x since they're tools
4988 * docs/epyrun (addMod): when an import fails, say why
4990 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4992 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4994 * buildbot/process/base.py:
4995 * buildbot/process/builder.py:
4996 * buildbot/status/builder.py:
4997 new documentation while digging through the code
4999 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5001 * buildbot/changes/changes.py:
5002 * buildbot/changes/p4poller.py:
5003 * buildbot/interfaces.py:
5004 * buildbot/process/base.py:
5005 * buildbot/process/builder.py:
5006 * buildbot/process/step.py:
5007 * buildbot/process/step_twisted.py:
5008 * buildbot/slave/bot.py:
5009 * buildbot/slave/commands.py:
5010 * buildbot/status/builder.py:
5011 fix all docstrings to make epydoc happy. In the process of fixing
5012 some, I also moved pieces of docs, and removed some deprecated
5015 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5017 * buildbot/process/builder.py:
5018 * buildbot/process/interlock.py:
5019 * buildbot/process/process_twisted.py:
5020 * buildbot/process/step.py:
5021 BuildProcess -> Build, as it looks like that's what happened
5022 * buildbot/process/base.py:
5023 * buildbot/process/factory.py:
5026 2005-04-17 Brian Warner <warner@lothar.com>
5028 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5029 update compile command to accomodate the Twisted split.. now
5030 instead of './setup.py build_ext -i', you do './setup.py all
5031 build_ext -i', to run build_ext over all sub-projects.
5032 (FullTwistedBuildFactory): same
5033 (TwistedReactorsBuildFactory): same
5035 * buildbot/status/html.py (TextLog.finished): null out self.req
5036 when we're done, otherwise the reference cycle of TextLog to .req
5037 to .notifications to a Deferred to TextLog.stop keeps them from
5038 being collected, and consumes a huge (610MB on pyramid at last
5039 check) amount of memory.
5041 2005-04-11 Brian Warner <warner@lothar.com>
5043 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5044 normalize the VC-repository location.. makes SVN happier with
5045 certain test environments.
5047 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5048 RemoteShellCommand gets its own .env dictionary, so that code in
5049 start() doesn't mutate the original. I think this should fix the
5050 step_twisted.Trial problem where multiple identical components
5051 kept getting added to PYTHONPATH= over and over again.
5053 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5054 adding epydoc-format docstrings to many classes. Thanks to Thomas
5055 Vander Stichele for the patches.
5056 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5057 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5058 * buildbot/slave/bot.py, commands.py, registry.py: same
5060 2005-04-05 Brian Warner <warner@lothar.com>
5062 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5063 preserve timestamps, helps incremental builds of large trees.
5064 Patch from Rene Rivera.
5066 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5067 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5070 2005-04-03 Brian Warner <warner@lothar.com>
5072 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5073 with one dict, apparently exec has some scoping bugs when used
5074 with both global/local dicts. Thanks to Nathaniel Smith for the
5077 2005-04-02 Brian Warner <warner@lothar.com>
5079 * buildbot/process/step_twisted.py (countFailedTests): the new
5080 trial in Twisted-2.0 emits a slightly different status line than
5081 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5082 mistakenly think the test count is unparseable.
5083 (Trial.start): note that for some reason each build causes another
5084 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5085 be fixed but I'm not sure quite where the problem is.
5087 2005-04-01 Brian Warner <warner@lothar.com>
5089 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5090 deferredResult to avoid hangs/warnings under twisted-2.0
5091 (RunMixin.tearDown): same
5092 (RunMixin.shutdownSlave): same
5093 (Disconnect.testIdle1): same
5094 (Disconnect.testBuild2): same: wait one second after the build
5095 finishes for test to really be done.. this should be cleaned up to
5096 avoid wasting that second. Builder.detach uses a callLater(0),
5097 either that should be done in-line (something else needed that
5098 behavior), or it should return a Deferred that fires when the
5099 builder is really offline.
5100 (Disconnect.testBuild3): same
5101 (Disconnect.testDisappear): same
5103 * buildbot/test/test_web.py: rearrange server-setup and teardown
5104 code to remove unclean-reactor warnings from twisted-2.0
5106 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5107 so the tests don't hang under twisted-2.0
5109 2005-03-31 Brian Warner <warner@lothar.com>
5111 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5112 caused a warning each time the master changed our set of builders
5114 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5115 w32, don't unlink the file unless it already exists. Thanks to
5116 Baptiste Lepilleur for the catch.
5117 (BuilderStatus.saveYourself): same
5119 2005-02-01 Brian Warner <warner@lothar.com>
5121 * buildbot/status/html.py (TextLog.getChild): use a /text child
5122 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5123 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5124 logfile as text/plain (no markup, no headers). This replaces the
5125 previous scheme (which used an ?text=1 argument), and gets us back
5126 to a relative link (which works better when the buildbot lives
5127 behind another web server, such as Apache configured as a reverse
5128 proxy). Thanks to Gerald Combs for spotting the problem.
5130 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5133 2004-12-13 Brian Warner <warner@lothar.com>
5135 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5137 * debian/changelog: update for 0.6.2
5138 * NEWS: finalize for 0.6.2
5140 2004-12-11 Brian Warner <warner@lothar.com>
5142 * NEWS: bring it up to date
5144 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5145 detection code. Require some sign of life from the buildmaster
5146 every BotFactory.keepaliveInterval seconds. Provoke this
5147 indication at BotFactory.keepaliveTimeout seconds before the
5148 deadline by sending a keepalive request. We don't actually care if
5149 that request is answered in a timely fashion, what we care about
5150 is that .activity() is called before the deadline. .activity() is
5151 triggered by any PB message from the master (including an ack to
5152 one of the slave's status-update messages). With this new scheme,
5153 large status messages over slow pipes are OK, as long as any given
5154 message can be sent (and thus acked) within .keepaliveTimeout
5155 seconds (which defaults to 30).
5156 (SlaveBuilder.remote_startCommand): record activity
5157 (SlaveBuilder.ackUpdate): same
5158 (SlaveBuilder.ackComplete): same
5159 (BotFactory.gotPerspective): same
5160 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5162 2004-12-09 Brian Warner <warner@lothar.com>
5164 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5167 * buildbot/process/step_twisted.py (Trial._commandComplete):
5168 update self.cmd when we start the 'cat test.log' transfer. Without
5169 this, we cannot interrupt the correct RemoteCommand when we lose
5172 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5173 trying to tell the slave to stop the command if we're already
5174 inactive, or if we no longer have a .remote
5176 * buildbot/process/builder.py (Builder._detached): don't let an
5177 exception in currentBuild.stopBuild() prevent the builder from
5178 being marked offline
5180 2004-12-07 Brian Warner <warner@lothar.com>
5182 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5183 KeyError that happens when you ask for a non-existent Builder, and
5184 translate it into a UsageError.
5186 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5187 losing the slave in the middle of a remote step is handled too
5189 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5190 be a Failure, so be sure to stringify it before using it as the
5191 contents of the 'interrupt' logfile
5192 (RemoteCommand.interrupt): use stringified 'why' in
5193 remote_interruptCommand too, just in case
5195 2004-12-06 Brian Warner <warner@lothar.com>
5197 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5198 instead of 'tla update', which is more efficient in case we've
5199 missed a couple of patches since the last update.
5201 * debian/changelog: update for previous (0.6.1) release. Obviously
5202 this needs to be handled better.
5204 2004-12-05 Brian Warner <warner@lothar.com>
5206 * NEWS: update for stuff since last release
5208 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5209 match the maybeDeferred change in Dispatcher.requestAvatar
5210 * buildbot/changes/pb.py (ChangePerspective.attached): same
5211 * buildbot/status/client.py (StatusClientPerspective.attached): same
5212 * buildbot/process/builder.py (Builder._attached3): same
5213 * buildbot/pbutil.py (NewCredPerspective.attached): same
5215 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5216 the date to the top-most box, if it is not the same as today's
5219 * docs/slave.xhtml: provide a buildslave setup checklist
5221 * docs/source.xhtml (Arch): correct terminology
5223 2004-12-04 Brian Warner <warner@lothar.com>
5225 * buildbot/test/test_slavecommand.py: use sys.executable instead
5226 of hard-coding 'python' for child commands, might help portability
5228 * docs/examples/twisted_master.cfg: update to current usage
5230 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5231 'stop build' command to the IRC bot
5233 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5234 message that broke PBChangeSource
5236 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5237 (SlaveBuilder): make some attributes class-level, remove the old
5238 "update queue" which existed to support resuming a build after the
5239 master connection was lost. Try to reimplement that feature later.
5240 (SlaveBuilder.stopCommand): clear self.command when the
5241 SlaveCommand finishes, so that we don't try to kill a leftover one
5243 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5246 * buildbot/slave/commands.py (SourceBase): set self.command for
5247 all VC commands, so they can be interrupted.
5249 2004-12-03 Brian Warner <warner@lothar.com>
5251 * buildbot/master.py: clean up slave-handling code, to handle
5252 slave-disconnect and multiple-connect better
5253 (BotPerspective): make these long-lasting, exactly one per bot
5254 listed in the config file.
5255 (BotPerspective.attached): if a slave connects while an existing
5256 one appears to still be connected, disconnect the old one first.
5257 (BotPerspective.disconnect): new method to forcibly disconnect a
5258 buildslave. Use some hacks to empty the transmit buffer quickly to
5259 avoid the long (20-min?) TCP timeout that could occur if the old
5260 slave has dropped off the net.
5261 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5262 own their own SlaveStatus objects. Remove .attached/.detached, add
5263 .addSlave/.removeSlave, treat slaves like Builders (config file
5264 parsing sends deltas to the BotMaster). Inform the slave
5265 instances, i.e. the BotPerspective, about addBuilder and
5267 (BotMaster.getPerspective): turns into a single dict lookup
5268 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5269 which gives BotPerspective.attached a chance to disconnect the old
5271 (BuildMaster.loadConfig): add code (disabled) to validate that all
5272 builders use known slaves (listed in c['bots']). The check won't
5273 work with tuple-specified builders, which are deprecated but not
5274 yet invalid, so the check is disabled for now.
5275 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5276 routine, do the add/changed/removed dance with them like we do
5278 (BuildMaster.loadConfig_Sources): move source-config into a
5279 separate routine too
5281 * buildbot/status/builder.py (Status.getSlave): get the
5282 SlaveStatus object from the BotPerspective, not the BotMaster.
5284 * buildbot/test/test_run.py: bunch of new tests for losing the
5285 buildslave at various points in the build, handling a slave that
5286 connects multiple times, and making sure we can interrupt a
5289 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5290 something other than 'Bot' for the Bot object, to make certain
5291 test cases easier to write.
5292 (BuildSlave.waitUntilDisconnected): utility method for testing
5294 2004-11-30 Brian Warner <warner@lothar.com>
5296 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5298 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5299 argument, return a Deferred that always fires with True or False.
5300 I don't use an errback to indicate 'ping failed' so that callers
5301 are free to ignore the deferred without causing spurious errors in
5303 * buildbot/process/builder.py (BuilderControl.ping): implement it
5305 * buildbot/test/test_run.py (Status.testDisappear): test ping
5306 (Status.disappearSlave): fix it
5308 2004-11-30 Brian Warner <warner@lothar.com>
5310 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5311 (IBuilderControl): add .getBuild(num), only works for the current
5312 build, of course, although it might be interesting to offer
5313 something for builds in the .waiting or .interlocked state.
5315 * buildbot/process/base.py (Build): have .stopBuild just do the
5316 interrupt, then let the build die by itself.
5317 (BuildControl): add .stopBuild, and add a point-event named
5318 'interrupt' just after the build so status viewers can tell that
5320 (BuilderControl): add .getBuild
5322 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5323 stops when you kill it, good for testing
5324 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5325 contains the 'reason' text.
5327 * buildbot/status/html.py: Add Stop Build button, if the build can
5328 still be stopped. Send a Redirect (to the top page) one second
5329 later, hopefully long enough for the interrupt to have an effect.
5330 Move make_row() up to top-level to share it between Stop Build and
5333 * buildbot/slave/commands.py: only kill the child process once
5335 * buildbot/test/test_run.py: add testInterrupt
5337 2004-11-29 Brian Warner <warner@lothar.com>
5339 * buildbot/process/base.py: Refactor command interruption. The
5340 Build is now responsible for noticing that the slave has gone
5341 away: Build.lostRemote() interrupts the current step and makes
5342 sure that no further ones will be started.
5344 * buildbot/process/builder.py: When the initial remote_startBuild
5345 message fails, log it: this usually indicates that the slave has
5346 gone away, but we don't really start paying attention until they
5347 fail to respond to the first step's command.
5349 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5350 slave disconnect. Now sports a new interrupt() method. Error
5351 handling was simplified a lot by chaining deferreds, so
5352 remoteFailed/remoteComplete were merged into a single
5353 remoteComplete method (which can now get a Failure object).
5354 Likewise failed/finished were merged into just _finished.
5355 (BuildStep): Add interrupt(why) method, and if why is a
5356 ConnectionLost Failure then the step is failed with some useful
5359 * buildbot/slave/bot.py: stop the current command when the remote
5360 Step reference is lost, and when the slave is shut down.
5361 (Bot): make it a MultiService, so it can have children. Use
5362 stopService to tell when the slave is shutting down.
5363 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5364 remote_interruptCommand (which asks the current SlaveCommand to
5365 stop but allows it to keep emitting status messages), and
5366 stopCommand (which tells it to shut up and die).
5368 * buildbot/slave/commands.py: make commands interruptible
5369 (ShellCommand.kill): factor out os.kill logic
5370 (Command): factor out setup()
5371 (Command.sendStatus): don't send status if .running is false, this
5372 happens when the command has been halted.
5373 (Command.interrupt): new method, used to tell the command to die
5374 (SlaveShellCommand): implement .interrupt
5375 (DummyCommand): implement .interrupt
5376 (SourceBase, etc): factor out setup(), don't continue substeps if
5379 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5380 so they can be called after finishing
5382 * buildbot/test/test_run.py: new tests for disconnect behavior,
5383 refactor slave-shutdown routines, add different kinds of
5386 2004-11-27 Brian Warner <warner@lothar.com>
5388 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5389 method to express ETA time like "2m45s" instead of "165 seconds"
5391 2004-11-24 Brian Warner <warner@lothar.com>
5393 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5394 archive after the test completes, to avoid cluttering the user's
5395 'tla archives' listing with a bogus entry. Arch doesn't happen to
5396 provide any way to override the use of ~/.arch-params/, so there
5397 isn't a convenient way to avoid touching the setup of the user who
5399 (VC_HTTP.testArchHTTP): same
5401 2004-11-23 Brian Warner <warner@lothar.com>
5403 * buildbot/status/html.py (TextLog): split render() up into
5404 render_HEAD and render_GET. Use a Producer when sending log
5405 chunks, to reduce memory requirements and avoid sending huge
5406 non-Banana-able strings over web.distrib connections. Requires
5407 peeking under the covers of IStatusLog.
5408 (TextLog.resumeProducing): fix the "as text" link, handle client
5409 disconnects that occur while we're still sending old chunks.
5411 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5412 use defer.succeed, not the non-existent defer.success
5413 (LogFile.waitUntilFinished): same
5414 (LogFile.subscribe): don't add watchers to a finished logfile
5416 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5419 2004-11-23 Brian Warner <warner@lothar.com>
5421 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5423 2004-11-23 Brian Warner <warner@lothar.com>
5425 * NEWS: update for the 0.6.1 release
5426 * MANIFEST.in: add new files
5428 * README (INSTALLATION): explain how to enable the extra VC tests
5430 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5431 level to, so old pickled builds can be displayed ok
5433 2004-11-22 Brian Warner <warner@lothar.com>
5435 * NEWS: summarize updates since last release
5437 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5438 Yoz Grahame. Closes SF#1050138.
5440 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5443 * buildbot/process/step_twisted.py (Trial): update docs a bit
5445 * docs/factories.xhtml: fix Trial factory docs to match reality.
5448 * buildbot/process/factory.py (Trial.__init__): add args for
5449 randomly= and recurse=, making them available to instantiators
5450 instead of only to subclassers. Closes: SF#1049759.
5452 2004-11-15 Brian Warner <warner@lothar.com>
5454 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5455 try to teach the Quick factory to use multiple versions of python
5457 2004-11-12 Brian Warner <warner@lothar.com>
5459 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5460 safer w32-compatible approach, and only use it on windows
5461 (BuildStatus.saveYourself): same
5463 2004-11-11 Brian Warner <warner@lothar.com>
5465 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5466 it: one string merge per chunk. There are now separate .entries
5467 and .runEntries lists: when enumerating over all chunks, make sure
5469 * buildbot/test/test_status.py (Log): more tests
5471 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5472 chunks together, up to 10kb per chunk. This ought to cut down on
5473 the CPU-burning overhead of large log files. Thanks to Alexander
5474 Staubo for spotting the problem.
5475 * buildbot/test/test_status.py (Log): tests for same
5477 2004-11-10 Brian Warner <warner@lothar.com>
5479 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5480 header to outbound mail
5481 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5483 2004-11-08 Brian Warner <warner@lothar.com>
5485 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5486 can't do os.rename() onto an existing file, so catch the exception
5487 and unlink the target file first. This introduces a slight window
5488 where the existing file could be lost, but the main failure case
5489 (disk full) should still be handled safely.
5490 (BuildStatus.saveYourself): same
5492 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5493 separator character instead of os.sep, because the filenames being
5494 split here are coming from the VC system, which can have a
5495 different pathname convention than the local host. This should
5496 help a buildmaster running on windows that uses a CVS repository
5497 which runs under unix.
5498 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5500 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5501 when there are no test failures to be parsed
5503 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5504 instead of the unix-specific os.system("cp"), thanks to Elliot
5505 Murphy for this and the other buildbot-vs-windows catches.
5506 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5508 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5509 echo the command as it is run
5511 * setup.py: install sample.mk too, not just sample.cfg
5512 (scripts): install contrib/windows/buildbot.bat on windows
5514 2004-11-07 Brian Warner <warner@lothar.com>
5516 * buildbot/process/builder.py (Builder._detached): clear the
5517 self.currentBuild reference, otherwise the next build will be
5518 skipped because we think the Builder is already in use.
5520 * docs/examples/twisted_master.cfg: update to match current usage
5521 on the Twisted buildbot
5523 2004-10-29 Brian Warner <warner@lothar.com>
5525 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5527 2004-10-28 Brian Warner <warner@lothar.com>
5529 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5530 have separate doVCUpdate/doVCFull methods. Catch an update failure
5531 and respond by clobbering the source directory and re-trying. This
5532 will handle local changes (like replacing a file with a directory)
5533 that will cause CVS and SVN updates to fail.
5534 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5536 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5539 2004-10-19 Brian Warner <warner@lothar.com>
5541 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5543 * buildbot/status/html.py (StatusResourceTestResults): display any
5544 TestResults that the Build might have
5545 (StatusResourceTestResult): and the logs for each TestResult
5546 (StatusResourceBuild): add link from the per-build page
5548 2004-10-15 Brian Warner <warner@lothar.com>
5550 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5551 the 'problems' portion of stdout, add TestResults to our build
5552 * buildbot/test/test_twisted.py (Parse.testParse): test it
5554 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5555 to retrieve a dict of accumulated test results
5556 (ITestResult): define what a single test result can do
5557 * buildbot/status/builder.py (TestResult): implement ITestResult
5558 (BuildStatus.getTestResults): retrieve dict of TestResults
5559 (BuildStatus.addTestResult): add TestResults
5560 * buildbot/test/test_status.py (Results.testAddResults): test it
5562 2004-10-14 Brian Warner <warner@lothar.com>
5564 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5565 instead of os.system("rm -rf") for win32 portability
5567 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5568 SignalMixin instead of starting/stopping the reactor, which is
5569 likely to cause problems with other tests
5571 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5572 self.copyComplete() call. Yoz Grahame makes the catch.
5574 * contrib/windows/buildbot.bat: helper script to deal with path
5575 issues. Thanks to Yoz Grahame.
5577 * buildbot/master.py (BuildMaster.startService): don't register a
5578 SIGHUP handler if the signal module has no SIGHUP attribute.
5579 Apparently win32 does this.
5581 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5583 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5584 test if the reactor can't offer UNIX sockets
5586 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5587 error introduced in the last commit. We really need that
5590 2004-10-12 Brian Warner <warner@lothar.com>
5592 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5593 when describing a maildir source. Thanks to Stephen Davis.
5595 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5598 * buildbot/scripts/runner.py (createMaster): install Makefile too
5599 (start): add --no_save to 'start' command
5600 * buildbot/scripts/sample.mk: simple convenience Makefile with
5601 start/stop/reload targets
5603 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5606 2004-09-30 Brian Warner <warner@lothar.com>
5608 * setup.py: Releasing buildbot-0.6.0
5610 2004-09-30 Brian Warner <warner@lothar.com>
5612 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5613 test_trial.py from the source tarball until support is complete.
5615 * NEWS: update for 0.6.0 release
5616 * buildbot/__init__.py (version): same
5619 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5620 'source' command to tell users where to get the Buildbot source
5622 * docs/examples/*.cfg: update to modern standards
5624 * NEWS: update for release
5626 * buildbot/scripts/runner.py (createMaster): remove the
5627 -shutdown.tap stuff now that it isn't necessary
5629 (start): launch buildbot.tap, not buildbot-shutdown.tap
5632 * buildbot/status/mail.py (Domain): shorten class name
5633 (MailNotifier): if lookup= is a string, pass it to Domain()
5634 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5635 (Mail.testBuild2): test the string-to-Domain shortcut
5636 (Mail.testMail): fix test
5639 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5642 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5643 more attributes on load
5644 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5645 to accomodate the whole waterfall page at once, and the thrashing
5646 results in a lot of unnecessary loads
5647 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5648 (BuilderStatus.saveYourself): same
5649 (BuilderStatus.eventGenerator): stop generating on the first missing
5650 build. We assume that saved builds are deleted oldest-first.
5651 (BuildStepStatus.__getstate__): .progress might not exist
5653 * buildbot/changes/changes.py (ChangeMaster): make it
5654 serializable, in $masterdir/changes.pck
5655 (ChangeMaster.stopService): save on shutdown
5656 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5657 * buildbot/test/test_config.py: load Changes before config file
5660 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5661 "Oh my god, you killed the command" header on a separate line
5663 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5664 skip over corrupted build pickles
5665 (BuilderStatus.getFullBuildByNumber): same
5666 (BuilderStatus.eventGenerator): skip over unavailable builds
5667 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5668 do an atomic rename. This prevents a corrupted pickle when some
5669 internal serialization error occurs.
5670 (BuilderStatus.saveYourself): same
5672 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5673 the timeout for shell commands, it got lost somehow
5675 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5676 run out of build steps, return the rest of the builder events
5678 * buildbot/interfaces.py (IBuilderControl.ping): add method
5680 * buildbot/process/builder.py (BuilderControl.ping): move
5681 slave-ping to BuilderControl, and fix the failure case in the
5682 process (Event.finish() is the verb, Event.finished is the noun).
5684 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5685 through the BuilderControl instead of the BuilderStatus
5686 (EventBox): add adapter for builder.Event, allowing builder events to
5687 be displayed in the waterfall display
5689 * buildbot/master.py (BotMaster.stopService): add a 'master
5690 shutdown' event to the builder's log
5691 (BuildMaster.startService): and a 'master started' on startup
5693 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5694 builder events into the BuildStep event stream
5695 (Status.builderAdded): add a 'builder created' event
5698 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5699 command to announce the completion of a running build
5700 (IrcStatusBot.command_FORCE): announce when the build finishes
5702 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5703 don't evict unfinished builds from the cache: they must stay in
5704 the full-cache until their logfiles have stopped changing. Make
5705 sure the eviction loop terminates if an unfinished build was hit.
5706 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5707 This lets exceptions be dumped in an email status message. Really
5708 we need LogFiles which contain both text and HTML, instead of two
5710 (BuildStatus.__getstate__): handle self.finished=False
5711 (Status.builderAdded): if the pickle is corrupted, abandon the
5712 history and create a new BuilderStatus object.
5714 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5715 self.progress attribute, helped one test which doesn't fully set
5716 up the Build object.
5718 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5719 IStatusLog methods into an Interface that is implemented by "stub"
5720 logs, for which all the actual text chunks are on disk (in the
5721 pickled Build instance). To show the log contents, you must first
5722 adapt the stub log to a full IStatusLog object.
5724 * buildbot/status/builder.py (LogFileStub): create separate stub
5725 log objects, which can be upgraded to a real one if necessary.
5726 (LogFile): make them persistable, and let them stubify themselves
5728 (BuildStepStatus): same
5730 (BuildStatus.saveYourself): save the whole build out to disk
5731 (BuilderStatus): make it persistable
5732 (BuilderStatus.saveYourself): save the builder to disk
5733 (BuilderStatus.addFullBuildToCache): implement two caches which
5734 hold Build objects: a small one which holds full Builds, and a
5735 larger one which holds "stubbed" Builds (ones with their LogFiles
5736 turned into LogFileStubs). This reduces memory usage by the
5737 buildmaster by not keeping more than a few (default is 2) whole
5738 build logs in RAM all the time.
5739 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5741 (BuilderStatus.eventGenerator): rewrite since .builds went away
5742 (BuilderStatus.buildStarted): remove the .builds array. Add the
5743 build to the "full" cache when it starts.
5744 (BuilderStatus._buildFinished): save the build to disk when it
5746 (Status): give it a basedir (same as the BuildMaster's basedir)
5747 where the builder pickles can be saved
5748 (Status.builderAdded): create the BuilderStatus ourselves, by
5749 loading a pickle from disk (or creating a new instance if there
5750 was none on disk). Return the BuilderStatus so the master can glue
5751 it into the new Builder object.
5753 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5754 all BuilderStatuses to save themselves out to disk. This is in
5755 lieu of saving anything important in the main Application pickle
5756 (the -shutdown.tap file).
5757 (BuildMaster.__init__): give Status() a basedir for its files
5758 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5759 to get the BuilderStatus, then give it to the Builder (instead of
5760 doing it the other way around). It's ok if the status announces
5761 the new Builder before it's really ready, as the outside world can
5762 only see the BuilderStatus object anyway (and it is ready before
5763 builderAdded returns). Use the builder's "builddir" (which
5764 normally specifies where the slave will run the builder) as the
5765 master's basedir (for saving serialized builds).
5767 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5768 coerce the logfile to IStatusLog before trying to get the text
5769 chunks out of it. This will pull the full (non-stubified) Build in
5770 from disk if necessary.
5771 (TextLog): fix the adapter registration
5773 * buildbot/test/test_control.py (Force.setUp): create the basedir
5774 * buildbot/test/test_web.py: same
5775 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5776 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5777 * buildbot/test/test_run.py (Run.testMaster): same
5778 (Status.setUp): same
5780 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5782 * buildbot/status/html.py (Waterfall.__init__): store actual
5783 allowForce flag passed in rather than using True for everyone;
5784 make sure setting it to False doesn't cause a NameError
5786 (StatusResourceBuilder.__init__) add the builder name to the page
5788 (StatusResourceBuilder.body) move HTML generation for a name/value
5789 row into a helper method (StatusResourceBuilder.make_row); only
5790 generate the "Force Build" form if allowForce was True and the
5791 slave is connected. Use class attributes in the generated HTML to
5792 spread a little CSS-joy.
5794 2004-09-28 Brian Warner <warner@lothar.com>
5796 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5797 warning-scanner to not ignore things like
5798 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5800 * buildbot/status/html.py (StatusResource.control): add some
5801 class-level values for .control in an attempt to make upgrading
5804 * buildbot/util.py (ComparableMixin): survive missing attributes,
5805 such as when a class is modified and we're comparing old instances
5808 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5809 failure handling, remove a redundant try/except block. Don't
5810 return the full traceback to the IRC channel.
5811 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5812 error messages. Get ETA properly.
5814 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5815 the reason, since (at least) IRC message will have <> in them.
5816 (StatusResourceBuilder.__init__): take an IBuilderControl
5817 (StatusResourceBuilder.force): use the IBuilderControl we get in
5818 the constructor instead of trying to make our own. Catch the
5819 new exceptions and ignore them for now (until we make an
5820 intermediate web page where we could show the error message)
5821 (StatusResource): create with an IControl, use it to give an
5822 IBuilderControl to all children
5823 (Waterfall): take an allowForce= option, pass an IControl object
5824 to StatusResource if it is True
5826 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5828 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5829 catch new exceptions and return string forms
5831 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5832 * buildbot/process/builder.py (Builder.forceBuild): raise them
5833 * buildbot/test/test_control.py (Force.testNoSlave): new test
5834 (Force.testBuilderInUse): same
5837 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5839 * buildbot/test/test_run.py: use IControl
5840 * buildbot/test/test_vc.py: same
5842 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5843 to use IControl. Still offline.
5844 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5846 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5847 who=None so periodic builds don't send out status mail
5848 (Builder.forceBuild): include reason in the log message
5849 (BuilderControl.forceBuild): rename 'name' to 'who'
5851 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5852 'who' parameter, but make it None by default so builds forced by
5853 slave admins don't cause status mail to be sent to anybody
5854 (BotMaster.forceBuild): same. this method is deprecated.
5855 (DebugPerspective.perspective_forceBuild): same, use IControl.
5856 (DebugPerspective.perspective_fakeChange): use IControl..
5857 (Dispatcher.requestAvatar): .. so don't set .changemaster
5859 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5860 parameter to avoid confusion with the name of the builder
5863 * buildbot/status/mail.py: refine comment about needing 2.3
5865 * buildbot/status/html.py: move all imports to the top
5867 * buildbot/test/test_control.py: test new interfaces
5868 * buildbot/test/test_run.py (Status): handle new interfaces
5869 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5871 * buildbot/process/base.py (BuildControl): implement IBuildControl
5872 and its lonely getStatus() method
5874 * buildbot/process/builder.py (BuilderControl): implement
5875 IBuilderControl, obtained by adapting the Builder instance
5876 (Builder.startBuild): return a BuilderControl instead of a
5877 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5878 accomplish the same thing.
5880 * buildbot/master.py: move all import statements to the top
5881 (Control): implement IControl, obtained by adapting the
5882 BuildMaster instance.
5884 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5885 IBuildControl. These are used to force builds. Eventually they
5886 will provide ways to reconfigure the Builders, pause or abandon a
5887 Build, and perhaps control the BuildMaster itself.
5889 2004-09-26 Brian Warner <warner@lothar.com>
5891 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5892 ends up comparing us against something without a .__class__
5894 2004-09-24 Brian Warner <warner@lothar.com>
5896 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5899 * Makefile: add 'deb-snapshot' target, to create a timestamped
5902 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5904 2004-09-23 Brian Warner <warner@lothar.com>
5906 * buildbot/__init__.py (version): move version string here
5907 * setup.py: get version string from buildbot.version
5908 * buildbot/status/html.py (WaterfallStatusResource.body): add
5909 buildbot version to the page footer
5910 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5913 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5914 slaves, let the second know where the first one is coming from
5915 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5916 see our exceptions. It would be nice if there were a way to just
5917 send them the exception type and value, not the full traceback.
5920 * buildbot/status/mail.py (MailNotifier): add a new argument
5921 sendToInterestedUsers=, which can be set to False to disable the
5922 usual send-to-blamelist behavior.
5923 (top): handle python-2.2 which has no email.MIMEMultipart
5924 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5925 (MailNotifier.disownServiceParent): unsubscribe on removal
5927 * buildbot/test/test_status.py (Mail.testBuild2): test it
5930 * buildbot/status/progress.py (Expectations.wavg): tolerate
5931 current=None, which happens when steps start failing badly
5932 * buildbot/test/test_status.py (Progress.testWavg): test for it
5934 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5935 doesn't understand args['revision'], emit a warning instead of
5936 bailing completely. Updating to -rHEAD is probably close enough.
5938 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5940 * buildbot/test/test_status.py: at least import bb.status.client
5941 even if we don't have any test coverage for it yet
5943 * contrib/svn_buildbot.py: don't require python2.3
5944 (main): wait, do require it (for sets.py), but explain how to
5945 make it work under python2.2
5947 2004-09-23 Brian Warner <warner@lothar.com>
5949 * contrib/svn_buildbot.py: include the revision number in the Change
5951 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5952 using util.now() because FreshCVS is a realtime service
5954 * buildbot/status/event.py: delete dead code
5955 * buildbot/process/step.py: don't import dead Event class
5956 * buildbot/process/step_twisted.py: same
5957 * buildbot/status/builder.py: same
5958 * buildbot/status/client.py: same
5960 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5962 * buildbot/changes/changes.py (Change): set .when from an __init__
5963 argument (which defaults to now()), rather than having
5964 ChangeMaster.addChange set it later.
5965 (ChangeMaster.addChange): same
5967 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5968 (parseSyncmail): same. Just use util.now() for now.
5969 (parseBonsaiMail): parse the timestamp field for when=
5971 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5972 instead of setting .when after the fact
5976 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5977 results when the target project uses retrial. Still under
5979 * buildbot/test/test_trial.py: same
5981 2004-09-21 Brian Warner <warner@lothar.com>
5983 * buildbot/status/mail.py (MailNotifier.__init__): include
5984 success/warnings/failure in the Subject line
5985 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5986 use step.logname for the addLogs=True attachment filenames
5987 * buildbot/test/test_status.py (Mail): test Subject lines
5988 (Mail.testLogs): test attachment filenames
5990 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5991 accept a 'who' argument from the debug tool
5992 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5993 * contrib/debug.glade: add text box to set 'who'
5995 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5996 .getBuilderName with .getBuilder().getName(), more flexible
5997 (IStatusLog.getName): logs have short names, but you can prefix
5998 them with log.getStep().getName() to make them more useful
5999 * buildbot/status/builder.py: same
6000 * buildbot/status/client.py: same
6001 * buildbot/status/html.py: same
6002 * buildbot/test/test_run.py (Status.testSlave): same
6003 * buildbot/process/step.py: tweak logfile names
6005 * buildbot/status/mail.py (MailNotifier): add lookup, change
6006 argument to extraRecipients. The notifier is now aimed at sending
6007 mail to the people involved in a particular build, with additional
6008 constant recipients as a secondary function.
6010 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6011 including slow-lookup and failing-lookup. Make sure the blamelist
6012 members are included.
6014 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6015 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6016 (IBuildStatus.getInterestedUsers): new method
6017 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6018 * buildbot/status/client.py (remote_getResponsibleUsers): same
6019 * buildbot/status/html.py (StatusResourceBuild.body): same
6020 * buildbot/test/test_run.py (Status.testSlave): same
6022 2004-09-20 Brian Warner <warner@lothar.com>
6024 * docs/users.xhtml: update concepts
6026 * Makefile: add a convenience makefile, for things like 'make
6027 test'. It is not included in the source tarball.
6029 2004-09-16 Brian Warner <warner@lothar.com>
6031 * NEWS: mention /usr/bin/buildbot, debian/*
6033 * debian/*: add preliminary debian packaging. Many thanks to
6034 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6035 it considerably since it left their hands, I am responsible for
6036 all breakage that's resulted.
6038 * bin/buildbot: create a top-level 'buildbot' command, to be
6039 installed in /usr/bin/buildbot . For now it's just a simple
6040 frontend to mktap/twistd/kill, but eventually it will be the entry
6041 point to the 'try' command and also a status client. It is also
6042 intended to support the upcoming debian-packaging init.d scripts.
6043 * buildbot/scripts/runner.py: the real work is done here
6044 * buildbot/scripts/__init__.py: need this too
6045 * buildbot/scripts/sample.cfg: this is installed in new
6046 buildmaster directories
6047 * setup.py: install new stuff
6049 2004-09-15 Brian Warner <warner@lothar.com>
6051 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6052 'file:' schema (the version shipped with OS-X was built without the
6054 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6055 updates the log-timestamp, to make sure it isn't still running after
6058 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6059 values to the config file.
6060 * docs/examples/hello.cfg: add examples
6061 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6062 * buildbot/status/builder.py (Status.getProjectURL): implement them
6063 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6064 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6065 * buildbot/status/html.py (WaterfallStatusResource): display them
6068 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6069 certain error cases don't suffer a secondary exception.
6070 (top): Skip tests if the corresponding VC tool is not installed.
6072 * buildbot/process/factory.py (Trial): introduce separate
6073 'buildpython' and 'trialpython' lists, since trialpython=[] is
6074 what you want to invoke /usr/bin/python, whereas ./setup.py is
6075 less likely to be executable. Add env= parameter to pass options
6076 to test cases (which is how I usually write tests, I don't know if
6077 anyone else does it this way).
6079 * buildbot/process/step_twisted.py (Trial): handle python=None.
6080 Require 'testpath' be a string, not a list. Fix tests= typo.
6081 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6083 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6084 way to deal with the possibility of removing the disconnect notify
6086 (CVS): add a 'login' parameter to give a password to 'cvs login',
6087 commonly used with pserver methods (where pw="" or pw="guest")
6089 * buildbot/slave/commands.py (SourceBase): move common args
6090 extraction and setup() to __init__, so everything is ready by the
6091 time setup() is called
6092 (CVS.start): call 'cvs login' if a password was supplied
6093 (ShellCommand): special-case PYTHONPATH: prepend the master's
6094 value to any existing slave-local value.
6096 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6097 don't have a remote, mark the builder as Offline. This whole
6098 function should probably go away and be replaced by individual
6100 (Builder.buildFinished): return the results to the build-finished
6101 deferred callback, helps with testing
6103 2004-09-14 Brian Warner <warner@lothar.com>
6105 * buildbot/test/test_vc.py: put all the repositories needed to run
6106 the complete tests into a single small (1.3MB) tarball, so I can
6107 make that tarball available on the buildbot web site. Test HTTP
6108 access (for Arch and Darcs) by spawning a temporary web server
6109 while the test runs.
6111 * docs/users.xhtml: new document, describe Buildbot's limited
6112 understanding of different human users
6114 * buildbot/test/test_vc.py: rearrange test cases a bit
6116 * buildbot/process/step_twisted.py (Trial): handle testpath=
6117 * buildbot/process/factory.py (Trial): update to use step.Trial
6119 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6121 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6122 the overall build text (which gives you 'failed 2 tests' rather
6124 (BuildStepStatus.text2): default to [], not None
6126 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6129 2004-09-12 Brian Warner <warner@lothar.com>
6131 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6132 log the whole exception if it's just an AttributeError (old slave)
6134 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6135 so (e.g.) sub-commands can be run in the right directory.
6136 (ShellCommand.start): accept an optional errorMessage= argument
6137 to make life easier for SVN.start
6138 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6140 (ShellCommand.start): move ['dir'] compatibility hack..
6141 (RemoteShellCommand.start): .. to here so everyone can use it
6143 * buildbot/process/step_twisted.py (Trial): use .workdir
6145 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6146 text displayed when debuild fails completely
6147 (Trial): snarf _trial_temp/test.log from the slave and display it
6149 2004-09-11 Brian Warner <warner@lothar.com>
6151 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6153 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6154 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6156 * buildbot/process/step.py (ShellCommand): call .createSummary
6157 before .evaluateCommand instead of the other way around. This
6158 makes it slightly easier to count warnings and then use that to
6159 set results=WARNINGS
6160 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6162 * buildbot/process/base.py (Build.buildFinished): update status
6163 before doing progress. It's embarrassing for the build to be stuck
6164 in the "building" state when an exceptions occurs elsewhere..
6166 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6167 python2.2 doesn't have 'sum'
6169 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6170 to prevent clients from accidentally sorting it
6172 * buildbot/master.py (Manhole): add username/password
6173 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6174 c['manholePort'], deprecate old usage
6175 * docs/config.xhtml: document c['manhole']
6176 * docs/examples/hello.cfg: show example of using a Manhole
6179 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6180 pretend the slave is up to date
6182 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6183 the module, overlaps with 'log', the local variable
6185 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6187 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6188 new method to let Steps find out the version of their
6189 corresponding SlaveCommand.
6190 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6191 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6192 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6194 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6195 (Arch.startVC): same
6196 (P4Sync.startVC): same
6198 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6199 Deferred so we can catch errors in remote_startCommand
6200 (RemoteShellCommand.start): same
6202 * docs/examples/twisted_master.cfg: update sample config file
6204 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6205 after connectionMade() is called, not before. Close stdin at that
6208 * buildbot/process/process_twisted.py: update to use Trial, clean
6209 up argument passing (move to argv arrays instead of string
6212 * buildbot/process/step_twisted.py (Trial): new step to replace
6213 RunUnitTests, usable by any trial-using project (not just
6214 Twisted). Arguments have changed, see the docstring for details.
6216 * buildbot/process/base.py (Build.startBuild): this now returns a
6217 Deferred. Exceptions that occur during setupBuild are now
6218 caught better and lead to fewer build_status weirdnesses, like
6219 finishing a build that was never started.
6220 (Build.buildFinished): fire the Deferred instead of calling
6221 builder.buildFinished directly. The callback argument is this
6222 Build, everything else can be extracted from it, including the
6223 new build.results attribute.
6224 * buildbot/process/builder.py (Builder.startBuild): same
6225 (Builder.buildFinished): same, extract results from build
6227 * buildbot/process/step.py (ShellCommands): remove dead code
6229 2004-09-08 Brian Warner <warner@lothar.com>
6231 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6232 doesn't try to use the leftover patched workdir
6233 (SourceStamp): test source-stamp computation for CVS and SVN
6235 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6236 patched workdir ('touch .buildbot-patched') so we don't try to
6238 (SourceBase.start): add ['revision'] for all Source steps
6239 (CVS): change args: use ['branch'] for -r, remove ['files']
6240 (CVS.buildVC): fix revision/branch stuff
6241 (SVN): add revision stuff
6243 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6244 kwargs (except 'workdir') to avoid silent spelling errors
6245 (ShellCommand.__init__): same
6246 (Source): new base class for CVS/SVN/etc. Factor out everything
6247 common, add revision computation (perform the checkout with a -D
6248 DATE or -r REVISION that gets exactly the sources described by the
6249 last Change), overridable with step.alwaysUseLatest. Add patch
6250 handling (build.getSourceStamp can trigger the use of a base
6251 revision and a patch).
6252 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6253 * docs/steps.xhtml: update docs
6254 * docs/source.xhtml: mention .checkoutDelay
6255 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6257 * buildbot/process/base.py (Build.setSourceStamp): add a
6258 .sourceStamp attribute to each Build. If set, this indicates that
6259 the build should be done with something other than the most
6260 recent source tree. This will be used to implement "try" builds.
6261 (Build.allChanges): new support method
6262 (Build.lastChangeTime): remove, functionality moved to Source steps
6263 (Build.setupBuild): copy the Step args before adding ['workdir'],
6264 to avoid modifying the BuildFactory (and thus triggering spurious
6268 * buildbot/status/html.py: rename s/commits/changes/
6269 (StatusResourceChanges): same
6270 (CommitBox.getBox): same, update URL
6271 (WaterfallStatusResource): same
6272 (StatusResource.getChild): same
6274 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6275 * contrib/debug.glade: add optional 'revision' to the fakeChange
6277 * buildbot/changes/changes.py (html_tmpl): display .revision
6278 (ChangeMaster.addChange): note .revision in log
6279 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6280 accept a ['revision'] attribute
6282 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6284 * buildbot/master.py (BotMaster.getPerspective): update the
6285 .connected flag in SlaveStatus when it connects
6286 (BotMaster.detach): and when it disconnects
6287 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6288 (BuildMaster.loadConfig_Builders): walk old list correctly
6290 * buildbot/test/test_config.py: fix prefix= usage
6292 2004-09-06 Brian Warner <warner@lothar.com>
6296 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6297 poll a P4 depot looking for recent changes. Thanks to Dave
6298 Peticolas for the contribution. Probably needs some testing after
6301 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6302 requires manual client setup for each buildslave. Rather
6303 experimental. Thanks again to Dave Peticolas.
6304 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6306 * buildbot/changes/changes.py (Change): add a .revision attribute,
6307 which will eventually be used to generate source-stamp values.
6309 * buildbot/process/step.py (RemoteCommand.start): use
6310 notifyOnDisconnect to notice when we lose the slave, then treat it
6311 like an exception. This allows LogFiles to be closed and the build
6312 to be wrapped up normally. Be sure to remove the disconnect
6313 notification when the step completes so we don't accumulate a
6314 bazillion such notifications which will fire weeks later (when the
6315 slave finally disconnects normally). Fixes SF#915807, thanks to
6316 spiv (Andrew Bennetts) for the report.
6317 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6318 really isn't Logged- specific
6319 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6320 header, since it's almost always going to be appended to an
6322 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6323 update test to handle use of notifyOnDisconnect
6325 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6326 don't clear .ETA and .currentBuild when going offline, let the
6327 current build clean up after itself
6329 * buildbot/process/builder.py (Builder.detached): wait a moment
6330 before doing things like stopping the current build, because the
6331 current step will probably notice the disconnect and cleanup the
6333 * buildbot/test/test_run.py (Status.tearDown): update test to
6334 handle asynchronous build-detachment
6336 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6338 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6339 hush a debug message
6341 2004-09-05 Brian Warner <warner@lothar.com>
6343 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6344 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6345 kernels do this: the fcntl module has the F_NOTIFY constant, but
6346 the kernel itself doesn't support the operation. Thanks to Olly
6347 Betts for spotting the problem.
6349 * buildbot/process/step.py (Darcs): new source-checkout command
6350 (Arch): new source-checkout command
6351 (todo_P4): fix constructor syntax, still just a placeholder
6352 * buildbot/test/test_vc.py (VC.testDarcs): test it
6353 (VC.testDarcsHTTP): same, via localhost HTTP
6355 (VC.testArchHTTP): same
6356 * NEWS: mention new features
6358 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6359 which tells the step to stash stdout text locally (in .stdout).
6360 Slave-side Commands can use this to make decisions based upon the
6361 output of the the ShellCommand (not just the exit code).
6362 (Darcs): New source-checkout command
6363 (Arch): New source-checkout command, uses .keepStdout in one place
6364 where it needs to discover the archive's default name.
6366 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6367 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6368 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6370 * buildbot/process/step.py (ShellCommand.describe): add an
6371 alternate .descriptionDone attribute which provides descriptive
6372 text when the step is complete. .description can be ["compiling"],
6373 for use while the step is running, then .descriptionDone can be
6374 ["compile"], used alone when the step succeeds or with "failed" when
6375 it does not. Updated other steps to use the new text.
6376 * buildbot/process/step_twisted.py: same
6377 * buildbot/test/test_run.py: update tests to match
6379 2004-08-30 Brian Warner <warner@lothar.com>
6381 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6382 (CVS.__init__): send 'patch' argument to slave
6383 (CVS.start): don't create the LoggedRemoteCommand until start(),
6384 so we can catch a .patch added after __init__
6385 (SVN.__init__): add 'patch' to SVN too
6388 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6389 argument, to let commands push data into the process' stdin pipe.
6390 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6391 is in use, since closing a PTY doesn't really affect the process
6392 in the right way (in particular, I couldn't run /usr/bin/patch
6394 (SourceBase.doPatch): handle 'patch' argument
6396 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6399 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6400 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6402 * buildbot/master.py (BotPerspective.got_commands): get command
6403 versions from slave, give to each builder
6404 * buildbot/process/builder.py (Builder.attached): stash slave
6405 command versions in .remoteCommands
6407 * docs/steps.xhtml: bring docs in-line with reality
6409 * buildbot/process/step.py (CVS.__init__): more brutal
6410 compatibility code removal
6411 (SVN.__init__): same
6413 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6414 (SlaveShellCommand.start): require ['workdir'] argument, remove
6415 the ['dir'] fallback (compatibility will come later)
6416 (SourceBase): update docs
6417 (SourceBase.start): remove ['directory'] fallback
6420 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6421 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6422 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6424 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6425 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6426 code.. I will figure out 0.5.0-compatibility hooks later)
6428 2004-08-30 Brian Warner <warner@lothar.com>
6430 * buildbot/process/process_twisted.py: rewrite in terms of new
6431 BuildFactory base class. It got significantly shorter. Yay
6434 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6435 work with the new "self.build isn't nailed down until we call
6436 step.start()" scheme: specifically, __init__ is called before the
6437 build has decided on which Changes are going in, so we don't scan
6438 build.allFiles() for .xhtml files until start()
6439 (HLint.commandComplete): use getText(), not getStdout()
6440 (RunUnitTests.start): same: don't use .build until start()
6441 (RunUnitTests.describe): oops, don't report (None) when using
6443 (RunUnitTests.commandComplete): use getText()
6444 (RunUnitTests.createSummary): same
6445 (BuildDebs.commandComplete): same
6447 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6448 set args['command'] until start(), since our BuildStep is allowed
6449 to change their mind up until that point
6450 (TreeSize.commandComplete): use getText(), not getStdout()
6452 * docs/examples/twisted_master.cfg: update to current standards
6454 * docs/factories.xhtml: update
6455 * buildbot/process/factory.py: implement all the common factories
6456 described in the docs. The Trial factory doesn't work yet, and
6457 I've probably broken all the process_twisted.py factories in the
6458 process. There are compatibility classes left in for things like
6459 the old BasicBuildFactory, but subclasses of them are unlikely to
6461 * docs/examples/glib_master.cfg: use new BuildFactories
6462 * docs/examples/hello.cfg: same
6464 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6465 explicit 'workdir' args
6467 * buildbot/process/base.py (BuildFactory): move factories to ..
6468 * buildbot/process/factory.py (BuildFactory): .. here
6469 * buildbot/process/process_twisted.py: handle move
6470 * buildbot/test/test_config.py: same
6471 * buildbot/test/test_run.py: same
6472 * buildbot/test/test_steps.py: same
6473 * buildbot/test/test_vc.py: same
6474 * docs/factories.xhtml: same
6476 * NEWS: mention config changes that require updating master.cfg
6478 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6479 argument to all steps that weren't given one already, pointing at
6480 the "build/" directory.
6482 * docs/examples/hello.cfg: remove explicit 'workdir' args
6484 * docs/factories.xhtml: document standard BuildFactory clases,
6485 including a bunch which are have not yet been written
6487 2004-08-29 Brian Warner <warner@lothar.com>
6489 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6490 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6491 buildbot.status.builder so they aren't quite so internal
6492 * buildbot/process/base.py, buildbot/process/builder.py: same
6493 * buildbot/process/maxq.py, buildbot/process/step.py: same
6494 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6495 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6496 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6498 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6499 to handle new getLogs()-returns-list behavior
6500 (StatusResourceBuildStep.getChild): same
6501 (StepBox.getBox): same
6502 (WaterfallStatusResource.phase0): same
6504 * docs/source.xhtml: document how Buildbot uses version-control
6505 systems (output side: how we get source trees)
6506 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6507 systems (input side: how we learn about Changes)
6509 * buildbot/master.py (Manhole): use ComparableMixin
6510 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6511 * buildbot/changes/mail.py (MaildirSource): same
6512 * buildbot/status/client.py (PBListener): same
6513 * buildbot/status/html.py (Waterfall): same
6514 * buildbot/status/words.py (IRC): same
6516 * NEWS: start describing new features
6518 * buildbot/status/mail.py (MailNotifier): finish implementation.
6519 The message body is still a bit sparse.
6520 * buildbot/test/test_status.py (Mail): test it
6522 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6523 and __hash__ methods I wind up adding everywhere. Specifically
6524 intended to support the buildbot config-file update scheme where
6525 we compare, say, the old list of IStatusTargets against the new
6526 one and don't touch something which shows up on both lists.
6527 * buildbot/test/test_util.py (Compare): test case for it
6529 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6530 return a list instead of a dict
6531 (IBuildStepStatus.getLogs): same. The idea is that steps create
6532 logs with vaguely unique names (although their uniqueness is not
6533 guaranteed). Thus a compilation step should create its sole
6534 logfile with the name 'compile', and contribute it to the
6535 BuildStatus. If a step has two logfiles, try to create them with
6536 different names (like 'test.log' and 'test.summary'), and only
6537 contribute the important ones to the overall BuildStatus.
6538 * buildbot/status/builder.py (Event.getLogs): same
6539 (BuildStepStatus): fix default .text and .results
6540 (BuildStepStatus.addLog): switch to list-like .getLogs()
6541 (BuildStepStatus.stepFinished): same
6542 (BuildStatus.text): fix default .text
6543 (BuildStatus.getLogs): temporary hack to return all logs (from all
6544 child BuildStepStatus objects). Needs to be fixed to only report
6545 the significant ones (as contributed by the steps themselves)
6546 * buildbot/test/test_run.py: handle list-like .getLogs()
6547 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6549 2004-08-28 Brian Warner <warner@lothar.com>
6551 * buildbot/process/builder.py (Builder.attached): serialize the
6552 attachment process, so the attach-watcher isn't called until the
6553 slave is really available. Add detached watchers too, which makes
6556 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6558 * buildbot/test/test_swap.py: remove dead code
6560 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6561 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6562 sort of as if the command being run exited with a -1. There may
6563 still be some holes in this scheme.
6564 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6565 -r option appears before the module list
6566 * buildbot/process/step.py (CVS): add 'revision' argument
6568 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6569 when sending updates or stepComplete messages to the master, since
6570 we don't currently care whether they arrive or not. When we revamp
6571 the master/slave protocol to really resume interrupted builds,
6572 this will need revisiting.
6573 (lostRemote): remove spurious print
6575 * buildbot/master.py (BotPerspective.attached): serialize the
6576 new-builder interrogation process, to make testing easier
6577 (BotMaster.waitUntilBuilderDetached): convenience function
6579 * buildbot/status/builder.py (BuilderStatus): prune old builds
6580 (BuildStatus.pruneSteps): .. and steps
6581 (BuildStepStatus.pruneLogs): .. and logs
6582 (BuilderStatus.getBuild): handle missing builds
6583 * buildbot/status/html.py (StatusResourceBuild.body): display build
6584 status in the per-build page
6585 (BuildBox.getBox): color finished builds in the per-build box
6587 2004-08-27 Brian Warner <warner@lothar.com>
6589 * buildbot/status/mail.py (MailNotifier): new notification class,
6592 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6593 variants of a common base class which handles all the mode= logic
6595 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6597 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6599 2004-08-26 Brian Warner <warner@lothar.com>
6601 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6604 * buildbot/test/test_run.py: update to new Logfile interface, new
6605 buildbot.slave modules
6606 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6608 * MANIFEST.in: new sample config file
6609 * docs/examples/hello.cfg: same
6611 * buildbot/process/step_twisted.py: remove dead import
6613 * buildbot/process/step.py (RemoteCommand.run): catch errors
6615 (RemoteCommand.remote_update): ignore updates that arrive after
6617 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6618 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6619 the responsibilities of the subclass's methods
6620 (BuildStep.failed): catch errors during failure processing
6621 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6622 (CVS): move to a mode= argument (described in docstring), rather
6623 than the ungainly clobber=/export=/copydir= combination.
6624 (SVN): add mode= functionality to SVN too
6625 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6627 * buildbot/process/base.py (Build.startNextStep): catch errors
6628 during s.startStep()
6630 * buildbot/clients/base.py: update to new PB client interface.
6631 gtkPanes is still broken
6633 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6634 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6635 * setup.py: add buildbot.slave module
6636 * buildbot/bb_tap.py: handle move
6637 * buildbot/slave/registry.py: place to register commands, w/versions
6638 * buildbot/slave/bot.py: major simplifications
6639 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6640 instead of a fixed table. Eventually this will make the slave more
6641 extensible. Use 'start' method on the command, not .startCommand.
6642 Fix unsafeTracebacks handling (I think).
6643 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6644 helper class with a .start method that returns a Deferred.
6645 SlaveShellCommand is the form reached by the buildmaster. Commands
6646 which use multiple ShellCommands can just chain them as Deferreds,
6647 with some helper methods in Command (_abandonOnFailure and
6648 _checkAbandoned) to bail on rc!=0.
6649 (CVSCommand): prefer new mode= argument
6650 (SVNFetch): add mode= argument
6652 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6653 put a useful reason string on the build
6655 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6656 core functionality into an IStatusLog object
6657 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6658 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6659 (StatusResourceBuild.body): use proper accessor methods
6660 * buildbot/status/client.py (RemoteLog): PB-access goes here
6661 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6662 which delivers log contents too
6663 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6664 * buildbot/status/event.py: remove old Logfile completely
6666 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6667 subscription interface for IStatusLog subscriptions just like all
6668 other the status subscriptions
6669 (IStatusReceiver.logChunk): method called on subscribers
6671 2004-08-24 Brian Warner <warner@lothar.com>
6673 * buildbot/process/builder.py (Builder._pong): oops, ping response
6674 includes a result (the implicit None returned by remote_print).
6675 Accept it so the _pong method handles the response correctly.
6677 2004-08-06 Brian Warner <warner@lothar.com>
6679 * buildbot/test/test_config.py: update IRC, PBListener tests
6681 * buildbot/status/client.py (StatusClientPerspective): total
6682 rewrite to match new IStatus interfaces. New subscription scheme.
6683 There are still a few optimizations to make (sending down extra
6684 information with event messages so the client doesn't have to do a
6685 round trip). The logfile-retrieval code is probably still broken.
6686 Moved the PB service into its own port, you can no longer share a
6687 TCP socket between a PBListener and, say, the slaveport (this
6688 should be fixed eventually).
6689 * buildbot/clients/base.py (Client): revamp to match. still needs
6690 a lot of work, but basic event reporting works fine. gtkPanes is
6693 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6694 instance talks to a single irc server. Threw out all the old
6695 multi-server handling code. Still need to add back in
6696 builder-control (i.e. "force build")
6698 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6699 more random text to the as-yet-unreachable per-step page
6701 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6702 rename to stepETAUpdate
6703 (BuildStatus.subscribe): add build-wide ETA updates
6704 (BuilderStatus.getState): remove more cruft
6705 (BuilderStatus.getCurrentBuild): remove more cruft
6706 (BuilderStatus.buildStarted): really handle tuple-subscription
6707 * buildbot/test/test_run.py (Status.testSlave): handle the
6708 stepETAUpdate rename
6710 * buildbot/master.py (BuildMaster): don't add a default
6711 StatusClientService. Don't add a default IrcStatusFactory. Both
6712 are now added through c['status'] in the config file. c['irc'] is
6713 accepted for backwards compatibility, the only quirk is you cannot
6714 use c['irc'] to specify IRC servers on ports other than 6667.
6716 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6717 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6718 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6719 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6722 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6723 the buildmaster to re-read its config file
6726 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6727 find out the port our server is running on
6728 (WebTest.test_webPathname_port): same
6730 * buildbot/test/test_config.py (testWebPortnum): test it
6731 (testWebPathname): ditto
6733 * docs/config.xhtml: document new c['status'] configuration option
6735 * buildbot/status/html.py (Waterfall): new top-level class which
6736 can be added to c['status']. This creates the Site as well as the
6737 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6738 reachable as .parent, for everything.
6740 * buildbot/master.py (Manhole): make it a normal service Child
6741 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6742 webPathname. It will eventually replace c['irc'] and the implicit
6743 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6744 in as (deprecated) backward compatibility hooks for now.
6747 * buildbot/process/builder.py (Builder.buildFinished): don't
6748 inform out builder_status about a finished build, as it finds out
6749 through its child BuildStatus object
6751 * buildbot/status/html.py: extensive revamp. Use adapters to make
6752 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6753 have both starting and finishing times and adjust the waterfall
6754 display accordingly, using spacers if necessary. Use SlaveStatus
6755 to get buildslave info.
6756 (StatusResourceBuildStep): new just-one-step resource, used to get
6757 logfiles. No actual href to it yet.
6759 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6760 the time being, until I get the file-naming scheme right
6762 * buildbot/status/builder.py (Event): clean started/finished names
6763 (BuildStatus.isFinished): .finished is not None is the right test
6764 (BuildStatus.buildStarted): track started/finished times ourselves
6765 (BuilderStatus.getSlave): provide access to SlaveStatus object
6766 (BuilderStatus.getLastFinishedBuild): all builds are now in
6767 .builds, even the currently-running one. Accomodate this change.
6768 (BuilderStatus.eventGenerator): new per-builder event generator.
6769 Returns BuildStepStatus and BuildStatus objects, since they can
6770 both be adapted as necessary.
6771 (BuilderStatus.addEvent): clean up started/finished attributes
6772 (BuilderStatus.startBuild,finishBuild): remove dead code
6773 (SlaveStatus): new object to provide ISlaveStatus
6775 * buildbot/process/step.py (ShellCommand.getColor): actually
6776 return the color instead of setting it ourselves
6777 (CVS.__init__): pull .timeout and .workdir options out of
6778 **kwargs, since BuildStep will ignore them. Without this neither
6779 will be sent to the slave correctly.
6780 (SVN.__init__): same
6782 * buildbot/process/builder.py (Builder): move flags to class-level
6784 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6785 SlaveStatus handle that
6787 * buildbot/process/base.py (Build.firstEvent): remove dead code
6788 (Build.stopBuild): bugfix
6790 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6792 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6793 (ChangeMaster.eventGenerator): yield Changes, since there are now
6794 Adapters to turn them into HTML boxes
6796 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6797 (BotPerspective.attached): feed a SlaveStatus object
6798 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6799 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6801 * buildbot/interfaces.py: API additions
6802 (ISlaveStatus): place to get slave status
6804 2004-08-04 Brian Warner <warner@lothar.com>
6806 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6807 the delay finishes, so the step is marked as SUCCESS
6809 * buildbot/test/test_run.py (Status.testSlave): cover more of
6810 IBuildStatus and IBuildStepStatus
6812 * buildbot/status/progress.py (StepProgress): move some flags to
6813 class-level attributes
6814 (StepProgress.remaining): if there are no other progress metrics
6815 to go by, fall back to elapsed time
6816 (StepProgress.setExpectations): take a dict of metrics instead of
6818 (BuildProgress.setExpectationsFrom): pull expectations from the
6819 Expectations, instead of having it push them to the BuildProgress
6820 (Expectations): move some flags to class-level attributes
6821 (Expectations.__init__): copy per-step times from the
6823 (Expectations.expectedBuildTime): new method for per-build ETA
6825 * buildbot/status/event.py (Logfile): move some flags to
6826 class-level attributes
6827 (Logfile.logProgressTo): better method name, let step set the
6828 progress axis name (instead of always being "output")
6830 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6831 times directly, rather than depending upon the (possibly missing)
6832 .progress object. Use 'None' to indicate "not started/finished
6834 (BuildStepStatus.getExpectations): oops, return the full list of
6836 (BuilderStatus._buildFinished): append finished builds to .builds
6838 * buildbot/process/step.py (BuildStep): add separate .useProgress
6839 flag, since empty .progressMetrics[] still implies that time is a
6841 (CVS): set up the cmd in __init__, instead of waiting for start()
6843 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6844 calculation, this will eventually turn into a proper sourceStamp
6845 (Build.setupBuild): tell the Progress to load from the Expectations,
6846 instead of having the Expectations stuff things into the Progress
6847 (Build.buildException): add a build-level errback to make sure the
6848 build's Deferred fires even in case of exceptions
6850 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6852 * buildbot/process/builder.py (Builder.forceBuild): convey the
6853 reason instead of creating a fake Change
6855 * docs/examples/twisted_master.cfg: update to match reality
6857 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6858 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6859 fix or remove broken/breaking tests
6861 * buildbot/status/event.py (Logfile.__len__): remove evil method
6863 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6864 missing .build, for test convenience
6866 * buildbot/process/step_twisted.py: import fixes
6868 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6870 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6871 .statusbag reference
6873 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6874 connection at shutdown, and stop it from reconnecting
6876 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6877 chase down remote-execution bugs
6879 * buildbot/process/step.py: more fixes, remove
6880 BuildStep.setStatus()
6881 * buildbot/status/builder.py: move setStatus() functionality into
6883 * buildbot/status/event.py: minor fixes
6885 2004-08-03 Brian Warner <warner@lothar.com>
6887 * buildbot/process/base.py, buildbot/process/builder.py
6888 * buildbot/process/step.py, buildbot/status/builder.py
6889 * buildbot/status/event.py, buildbot/test/test_run.py:
6890 fix status delivery, get a basic test case working
6891 * buildbot/master.py: finish implementing basic status delivery,
6892 temporarily disable HTML/IRC/PB status sources
6894 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6896 * buildbot/status/progress.py (BuildProgress): remove dead code
6898 * buildbot/interfaces.py
6899 * buildbot/process/base.py, buildbot/process/builder.py
6900 * buildbot/process/step.py, buildbot/process/step_twisted.py
6901 * buildbot/status/builder.py: Complete overhaul of the all
6902 status-delivery code, unifying all types of status clients (HTML,
6903 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6904 look like. This commit is a checkpointing of the work-in-progress:
6905 the input side is mostly done (Builders/Builds sending status
6906 to the BuilderStatus/BuildStatus objects), but the output side has
6907 not yet been started (HTML resources querying BuilderStatus
6908 objects). Things are probably very broken right now and may remain
6909 so for several weeks, I apologize for the disruption.
6911 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6912 HTML as the log's contents. Currently used for exception tracebacks.
6913 * buildbot/status/progress.py: minor spelling changes
6915 2004-08-02 Brian Warner <warner@lothar.com>
6917 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6918 in mozilla. Also added stylesheets copied from Twisted's docs.
6919 Remember that these files are meant to be run through Lore first.
6920 Thanks to Philipp Frauenfelder for the fixes.
6921 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6922 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6923 * docs/template.tpl: added a Lore template
6925 2004-07-29 Brian Warner <warner@lothar.com>
6927 * buildbot/interfaces.py: revamp status delivery. This is the
6928 preview: these are the Interfaces that will be provided by new
6929 Builder code, and to which the current HTML/IRC/PB status
6930 displayers will be adapted.
6932 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6933 on the SlaveBuilder, not the Bot.
6934 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6936 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6937 set .usePTY on the FakeSlaveBuilder
6939 2004-07-25 Brian Warner <warner@lothar.com>
6941 * buildbot/changes/freshcvs.py: add some debug log messages
6942 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6943 disabled 'setFilter' syntax
6944 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6945 don't end with a slash
6947 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6949 * setup.py: bump to 0.5.0+ while between releases
6951 2004-07-23 Brian Warner <warner@lothar.com>
6953 * setup.py (version): Releasing buildbot-0.5.0
6955 2004-07-23 Brian Warner <warner@lothar.com>
6957 * README: update for 0.5.0 release
6959 * NEWS: update for 0.5.0 release
6961 2004-07-22 Brian Warner <warner@lothar.com>
6963 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6964 mktap-time configuration flag (--usepty=1, --usepty=0)
6965 * buildbot/bot.py: same
6967 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6968 an 'info' directory being unwanted
6970 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6971 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6972 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6973 and earlier), use a FreshCVSSourceOldcred instead.
6974 (test): simple test routine: connect to server, print changes
6976 * buildbot/changes/changes.py (Change.getTime): make it possible
6977 to print un-timestamped changes
6979 * buildbot/master.py (makeApp): delete ancient dead code
6980 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6981 * buildbot/test/test_config.py (testFindConfigFile): test it
6983 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6984 instead of win32 one
6987 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6988 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6991 * buildbot/process/base.py (Builder.__init__): change constructor
6992 to accept a dictionary of config data, rather than discrete
6993 name/slave/builddir/factory arguments
6995 * docs/examples/twisted_master.cfg: update to new syntax
6996 * docs/examples/glib_master.cfg: same
6997 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6998 rough tests of the new syntax
7001 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7002 to be an int, which means "run a web.distrib sub-server on a TCP
7003 port". This lets you publish the buildbot status page to a remote
7004 twisted.web server (using distrib.ResourceSubscription). Also
7005 rename the local attributes used to hold these web things so
7006 they're more in touch with reality.
7007 * buildbot/test/test_web.py: test webPortnum and webPathname
7008 * docs/config.xhtml: document this new use of webPathname
7010 * docs/config.xhtml: new document, slightly ahead of reality
7012 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7013 'prefix' handling: treat it as a simple string to check with
7014 .startswith, instead of treating it as a directory. This allows
7015 sub-directories to be used. If you use prefix=, you should give it
7016 a string that starts just below the CVSROOT and ends with a slash.
7017 This prefix will be stripped from all filenames, and filenames
7018 which do not start with it will be ignored.
7020 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7022 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7023 and --exclude (inverse of --include). SVN post-commit hooks
7024 now have total control over which changes get sent to buildbot and which
7027 2004-07-10 Brian Warner <warner@lothar.com>
7029 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7030 test case to match new API
7032 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7033 which crashed HTML display when self.entries=[] (needed to
7034 distinguish between [], which means "no entries yet", and None,
7035 which means "the entries have been swapped out to disk, go fetch
7038 2004-07-04 Brian Warner <warner@lothar.com>
7040 * buildbot/process/step_twisted.py (countFailedTests): Count
7041 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7042 10kb from the end because any import errors are wedged there and
7043 they would make us think the test log was unparseable.
7044 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7046 2004-06-26 Brian Warner <warner@lothar.com>
7048 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7049 delete-*.pyc command into an actual BuildStep, so we can label it
7051 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7052 (FullTwistedBuildFactory): same
7054 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7056 * contrib/fakechange.py: Add an errback when sending the fake
7057 change, so we know it didn't work.
7059 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7061 * buildbot/process/step_twisted.py: Delete *.pyc files before
7062 calling trial, so it doesn't catch any old .pyc files whose .py
7063 files have been moved or deleted.
7065 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7066 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7067 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7068 instead of ["twisted.test"], so that the end result is "trial -R
7071 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7072 regular expression to match filenames that should be ignored when
7073 changed. Also add a --revision parameter that specifies the
7074 revision to examine, which is useful for debugging.
7076 2004-06-25 Brian Warner <warner@lothar.com>
7078 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7079 summary of warnings (like DeprecationWarnings), next to the
7082 2004-05-13 Brian Warner <warner@lothar.com>
7084 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7085 we now have a w32 build slave courtesy of Mike Taylor.
7087 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7088 so broken. Fixed a race condition that tripped up interlocked
7089 builds and caused the status to be stuck at "Interlocked" forever.
7090 The twisted buildbot's one interlocked build just so happened to
7091 never hit this case until recently (the feeding builds both pass
7092 before the interlocked build is attempted.. usually it has to wait
7094 (Builder._pong_failed): fix method signature
7096 * setup.py: bump to 0.4.3+ while between releases
7098 2004-04-30 Brian Warner <warner@lothar.com>
7100 * setup.py (version): Releasing buildbot-0.4.3
7102 2004-04-30 Brian Warner <warner@lothar.com>
7104 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7106 * README: update for 0.4.3 release
7108 * NEWS: update for 0.4.3 release
7110 * buildbot/master.py (BuildMaster.__getstate__): make sure
7111 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7113 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7114 .trial as a class attribute, for upgrade from 0.4.2
7116 * buildbot/changes/changes.py (Change.links): add .links for
7119 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7120 .textWatchers and .htmlWatchers at save time, since they are both
7121 volatile, should allow smooth 0.4.2 upgrade
7123 * buildbot/process/step.py (CVS.finishStatus): catch failed
7124 CVS/SVN commands so we can make the status box red
7126 2004-04-29 Brian Warner <warner@lothar.com>
7128 * buildbot/changes/freshcvs.py
7129 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7130 code to do setFilter(), which tells the freshcvs daemon to not
7131 send us stuff that we're not interested in. I will uncomment it
7132 when a new version of CVSToys is available in which setFilter()
7133 actually works, and I get a chance to test it better.
7135 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7137 * buildbot/master.py (Dispatcher): use a registration scheme
7138 instead of hardwired service names
7139 (BuildMaster): keep track of the Dispatcher to support
7142 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7143 PBChangeSource class instead of having it be an undocumented
7144 internal feature of the ChangeMaster. Split out the code into a
7146 * buildbot/changes/pb.py (PBChangeSource): same
7147 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7149 * docs/{factories|sources|steps}.xhtml: document some pieces
7151 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7152 using FCMaildirSource
7153 (f23osx): update OS-X builder to use python2.3, since the slave
7154 was updated to Panther (10.3.3)
7156 2004-03-21 Brian Warner <warner@lothar.com>
7158 * buildbot/process/process_twisted.py: factor out doCheckout, change
7159 to use SVN instead of CVS
7161 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7162 an SVN subclass easier
7163 (BasicSVN): subclass which uses Subversion instead of CVS
7165 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7167 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7169 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7171 2004-02-25 Brian Warner <warner@lothar.com>
7173 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7174 is now either a list (which is passed to spawnProcess directly) or
7175 a string (which gets passed to /bin/sh -c). This removes the useSH
7176 flag and the ArgslistCommand class. Also send status header at the
7177 start and end of each command, instead of having the master-side
7179 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7180 -r'. Update to use list-based arguments.
7181 (SVNFetch): use list-based arguments, use ['dir'] argument to
7183 * buildbot/test/test_steps.py (Commands): match changes
7185 * buildbot/process/step.py (InternalShellCommand.words): handle
7187 (SVN): inherit from CVS, cleanup
7189 * buildbot/status/event.py (Logfile.content): render in HTML, with
7190 stderr in red and headers (like the name of the command we're
7191 about to run) in blue. Add link to a second URL (url + "?text=1")
7192 to get just stdout/stderr in text/plain without markup. There is
7193 still a problem with .entries=None causing a crash, it seems to occur
7194 when the logfile is read before it is finished.
7196 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7197 timeout to the keepalives, and use it to explicitly do a
7198 loseConnection instead of waiting for TCP to notice the loss. This
7199 ought to clear up the silent-lossage problem.
7200 (unsafeTracebacks): pass exception tracebacks back to the master,
7201 makes it much easier to debug problems
7203 2004-02-23 Brian Warner <warner@lothar.com>
7205 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7206 the whole command to /bin/sh instead of execve [Johan Dahlin]
7207 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7208 '-r HEAD' [Johan Dahlin]
7209 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7211 * buildbot/changes/changes.py (Change): add links= argument, add
7212 asHTML method [Johan Dahlin]. Modified to make a bit more
7213 XHTMLish. Still not sure how to best use links= .
7215 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7216 Change.asHTML to display the change, not asText
7218 * buildbot/status/html.py (StatusResourceBuilder): web button to
7221 * buildbot/test/test_run.py: test to actually start a buildmaster
7224 * MANIFEST.in: bring back accidentally-dropped test helper files
7226 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7227 that require cvstoys if it is not installed
7229 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7230 values of "bin/trial" [Dave Peticolas]
7231 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7232 tests passed" when we didn't happen to run any tests
7234 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7235 flunkOnFailure [Johan Dahlin]
7237 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7238 multiple instances of the same Step class by suffixing "_2", etc,
7239 to the name until it is unique. This name needs to be unique
7240 because it is used as a key in the dictionary that tracks build
7242 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7245 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7247 2004-01-14 Brian Warner <warner@lothar.com>
7249 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7250 kicked from a channel, log it
7252 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7253 something over whatever IRC channels the buildmaster is currently
7254 connected to. Added to try and track down a problem in which the
7255 master thinks it is still connected but the IRCd doesn't see it. I
7256 used a styles.Versioned this time, so hopefully users won't have
7257 to rebuild their .tap files this time.
7258 * contrib/debug.glade: add a "Poke IRC" button
7259 * contrib/debugclient.py: same
7261 * setup.py: bump to 0.4.2+ while between releases
7263 2004-01-08 Brian Warner <warner@lothar.com>
7265 * setup.py (version): Releasing buildbot-0.4.2
7267 2004-01-08 Brian Warner <warner@lothar.com>
7269 * NEWS: update for 0.4.2 release
7271 * README: document how to run the tests, now that they all pass
7273 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7275 * buildbot/process/step.py (CVS): add a global_options= argument,
7276 which lets you set CVS global options for the command like "-r"
7277 for read-only checkout, or "-R" to avoid writing in the
7279 * buildbot/slavecommand.py (CVSCommand): same
7281 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7282 testing easier (it is turned off when testing, to avoid the
7285 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7286 to make it easier to test: break generateStepID() out to a
7287 separate function, only update statusbag if it exists.
7288 (ShellCommands): create useful text for dict-based commands too.
7290 * test/*, buildbot/test/*: move unit tests under the buildbot/
7292 * setup.py (packages): install buildbot.test too
7294 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7295 * buildbot/test/test_steps.py: fix it, tests pass now
7297 2004-01-06 Brian Warner <warner@lothar.com>
7299 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7300 freshcvs mail uses a slightly different syntax for new
7301 directories. Update parser to handle either.
7302 * test/test_mailparse.py (Test1.testMsg9): test for same
7304 2003-12-21 Brian Warner <warner@lothar.com>
7306 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7307 'warnOnWarnings' so that lintian errors mark the build orange
7309 2003-12-17 Brian Warner <warner@lothar.com>
7311 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7312 messages emitted by Bonsai, contributed by Stephen Davis.
7314 * test/*: moved all tests to use trial instead of unittest. Some
7315 still fail (test_steps, test_slavecommand, and test_process).
7317 * setup.py (version): bump to 0.4.1+ while between releases
7319 2003-12-09 Brian Warner <warner@lothar.com>
7321 * setup.py (version): Releasing buildbot-0.4.1
7323 2003-12-09 Brian Warner <warner@lothar.com>
7325 * NEWS: update for 0.4.1 release
7327 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7328 freebsd builder code a little bit
7330 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7331 don't try to compare attributes of different classes
7332 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7333 (MaildirSource.messageReceived): fix Change delivery
7335 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7336 into the config file's namespace before loading it, like the
7337 documentation claims it does
7338 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7339 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7340 daemon comes back online
7342 2003-12-08 Brian Warner <warner@lothar.com>
7344 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7345 so the example will work with online=0 as well
7347 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7348 fix the __implements__ line
7350 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7351 class a twisted.application.service.Service, use startService to
7354 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7355 directory fd instead of simple open(). I'm sure this used to work,
7356 but the current version of python refuses to open directories with
7359 2003-12-05 Brian Warner <warner@lothar.com>
7361 * setup.py (version): bump to 0.4.0+ while between releases
7363 2003-12-05 Brian Warner <warner@lothar.com>
7365 * setup.py (version): Releasing buildbot-0.4.0
7367 2003-12-05 Brian Warner <warner@lothar.com>
7369 * docs/examples/glib_master.cfg: replace old sample scripts with
7370 new-style config files
7371 * MANIFEST.in: include .cfg files in distribution tarball
7373 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7374 implement a dummy method to avoid the exception that occurs when
7375 freshcvs sends this to us.
7377 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7378 removed the method, as it broke reconnection. Apparently
7379 stopFactory is called each time the connection attempt fails. Must
7381 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7382 attribute before serialization, since without stopFactory the
7383 reconnect timer may still be active and they aren't serializable.
7385 * test/test_mailparse.py (ParseTest): test with 'self' argument
7387 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7388 argument, as these "functions" are invoked like methods from class
7389 attributes and therefore always get an instance as the first
7392 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7393 message: thanks to Stephen Davis for the catch
7395 2003-12-04 Brian Warner <warner@lothar.com>
7397 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7398 twisted's standard ReconnectingClientFactory. Handles both oldcred
7399 and newcred connections. Also has a bug-workaround for
7400 ReconnectingClientFactory serializing its connector when it
7403 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7404 pbutil. Replace makeApp stuff with proper newcred/mktap
7405 makeService(). Don't serialize Ephemerals on shutdown.
7407 * buildbot/changes/changes.py (ChangeMaster): make it a
7408 MultiService and add the sources as children, to get startService
7409 and stopService for free. This also gets rid of the .running flag.
7411 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7412 new pbutil, turn into a TCPClient at the same time (to get
7413 startService for free). Two variants exist: FreshCVSSourceOldcred
7414 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7415 yet, but when it does, we'll be ready).
7416 (FreshCVSSource.notify): handle paths which are empty after the
7417 prefix is stripped. This only happens when the top-level (prefix)
7418 directory is added, at the very beginning of a Repository's life.
7420 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7421 Now the only reconnecting code is in the factory where it belongs.
7422 (Builder.unsubscribe): unregister the disconnect callback when we
7423 delete the builder on command from the master (i.e. when the
7424 buildmaster is reconfigured and that builder goes away). This
7425 fixes a multiple-delete exception when the status client is shut
7427 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7430 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7431 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7433 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7435 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7436 a list of globs (ugh). The testdir will be searched for files
7437 named *.tests and run the tests in the order specified in each of
7438 those files. This allows for "dependancies" between tests to be
7441 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7442 argument to pass to run_maxq.py, instead of a glob.
7444 2003-10-17 Brian Warner <warner@lothar.com>
7446 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7447 files that live in the sandbox
7449 2003-10-15 Brian Warner <warner@lothar.com>
7451 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7452 spelling error in "docs" count-warnings output
7453 (HLint.start): stupid thinko meant .xhtml files were ignored
7455 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7456 tests now that cReactor is banished to the sandbox
7458 2003-10-10 Brian Warner <warner@lothar.com>
7460 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7461 scheme: now .xhtml are sources and .html are generated
7463 2003-10-08 Brian Warner <warner@lothar.com>
7465 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7466 we were ignoring the 'randomly' parameter.
7468 2003-10-01 Brian Warner <warner@lothar.com>
7470 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7471 posix, to kill sub-children of aborted slavecommands.
7473 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7474 Clean up initialization: lastBuildStatus remains None until the
7475 first build has been completed.
7477 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7478 None as a lastBuildStatus
7479 * buildbot/clients/gtkPanes.py: same
7481 * buildbot/status/client.py (StatusClientService): keep
7482 BuilderStatus objects in self.statusbags . These objects now live
7483 here in the StatusClientService and are referenced by the Builder
7484 object, rather than the other way around.
7485 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7486 * buildbot/process/base.py (Builder): same
7487 * test/test_config.py (ConfigTest.testBuilders): same
7489 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7490 an existing builder, leave the statusbag alone. This will preserve the
7493 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7494 hook. This will probably go away in favor of a class in upcoming
7497 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7498 serviceName from newcred FreshCVSNotifiee setup
7500 2003-09-29 Brian Warner <warner@lothar.com>
7502 * buildbot/process/process_twisted.py: switch to new reactor
7504 * docs/examples/twisted_master.cfg: same
7506 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7508 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7509 botmaster reference instead of the oldapp service lookup
7511 * buildbot/master.py (BuildMaster.__init__): give the
7512 StatusClientService a reference to the botmaster to make it easier to
7515 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7517 * buildbot/status/html.py (Box.td): escape hreffy things so you
7518 can have spaces in things like builder names
7519 (StatusResourceBuilder.body)
7520 (WaterfallStatusResource.body)
7521 (WaterfallStatusResource.body0): same
7523 2003-09-25 Brian Warner <warner@lothar.com>
7525 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7526 rearrange the builder list when adding or removing builders: keep
7527 them in the order the user requested.
7528 * test/test_config.py (ConfigTest.testBuilders): verify it
7530 * contrib/debug.glade: give the debug window a name
7532 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7533 now wait on multiple interlocks. Fix code relating to that.
7534 (Builder.checkInterlocks): same
7535 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7537 * buildbot/master.py (BuildMaster.loadConfig): move from
7538 deprecated pb.BrokerFactory to new pb.PBServerFactory
7539 * test/test_config.py (ConfigTest.testWebPathname): same
7541 * docs/examples/twisted_master.cfg: fix interlock declaration
7543 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7544 Interlocks to their Builders into interlock.py .
7545 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7547 * test/test_config.py (ConfigTest.testInterlocks): validate
7550 * buildbot/process/base.py (Builder.__init__): better comments
7551 * buildbot/process/interlock.py (Interlock.__repr__): same
7552 (Interlock.deactivate): add .active flag, move the code that
7553 attaches/detaches builders into the Interlock
7555 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7557 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7558 tests using the new run_maxq.py script, and reporting failures by
7561 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7562 tests, reporting their success or failure in a buildbot-friendly
7565 2003-09-24 Brian Warner <warner@lothar.com>
7567 * docs/examples/twisted_master.cfg: example of a new-style config
7568 file. This lives in the buildmaster base directory as
7571 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7572 button to make the master re-read its config file
7574 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7575 buildmaster configuration from a file. This file can be re-read
7576 later, and the buildmaster will update itself to match the new
7577 desired configuration. Also use new Twisted Application class.
7578 * test/Makefile, test/test_config.py: unit tests for same
7580 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7581 FreshCVSSources comparable, to support reload.
7582 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7584 * buildbot/process/base.py (Builder): make them comparable, make
7585 Interlocks easier to attach, to support reload. Handle
7586 re-attachment of remote slaves.
7587 * buildbot/process/interlock.py (Interlock): same
7589 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7590 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7591 buildmaster taps are now constructed with mktap.
7592 * buildbot/status/client.py (StatusClientService): same
7594 * buildbot/status/words.py: move to new Services, add support to
7595 connect to multiple networks, add reload support, allow nickname
7596 to be configured on a per-network basis
7598 2003-09-20 Brian Warner <warner@lothar.com>
7600 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7601 the freebsd builder, now that the machine has been upgraded and no
7602 longer has python2.2
7604 * setup.py (version): bump to 0.3.5+ while between releases
7606 2003-09-19 Brian Warner <warner@lothar.com>
7608 * setup.py (version): Releasing buildbot-0.3.5
7610 2003-09-19 Brian Warner <warner@lothar.com>
7612 * NEWS: add post-0.3.4 notes
7614 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7616 * MANIFEST.in: add contrib/*
7618 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7619 use a remote root now: cvs.twistedmatrix.com
7621 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7623 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7624 compatibility with old servers
7625 (FreshCVSSource.start): and provide a way to use it
7626 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7628 * docs/examples/twisted_master.py (twisted_app): update to new
7630 (twisted_app): listen on new ~buildbot socket
7631 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7633 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7634 to reduce cvs bandwidth (update instead of full checkout)
7636 2003-09-11 Brian Warner <warner@lothar.com>
7638 * contrib/fakechange.py: demo how to connect to the changemaster
7639 port. You can use this technique to submit changes to the
7640 buildmaster from source control systems that offer a hook to run a
7641 script when changes are committed.
7643 * contrib/debugclient.py: tool to connect to the debug port. You
7644 can use it to force builds, submit fake changes, and wiggle the
7647 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7648 'Dispatcher' realm to handle all the different kinds of
7649 connections and Perspectives: buildslaves, the changemaster port,
7650 the debug port, and the status client port. NewCredPerspectives
7651 now have .attached/.detached methods called with the remote 'mind'
7652 reference, much like old perspectives did. All the pb.Services
7653 turned into ordinary app.ApplicationServices .
7654 (DebugService): went away, DebugPerspectives are now created
7655 directly by the Dispatcher.
7656 (makeApp): changed interface a little bit
7658 * buildbot/changes/changes.py: newcred
7659 * buildbot/status/client.py: newcred
7661 * buildbot/clients/base.py: newcred client side changes
7662 * buildbot/bot.py: ditto
7664 * docs/examples/glib_master.py: handle new makeApp() interface
7665 * docs/examples/twisted_master.py: ditto
7667 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7668 base newcred Perspectives on. This should go away once Twisted
7669 itself provides something sensible.
7672 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7674 * contrib/svn_buildbot.py: A program that you can call from your
7675 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7676 when a change in an SVN repository has happened. See the top of
7677 the file for some minimal usage info.
7679 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7681 * buildbot/slavecommand.py (ArglistCommand): Add new
7682 ArglistCommand that takes an argument list rather than a string as
7683 a parameter. Using a st.split() for argv is very bad.
7685 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7686 update to a particular revision rather than always checking out
7687 (still not very smart about it, there may be cases where the
7688 checkout becomes inconsistent).
7690 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7692 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7693 SVN fetch support. It can checkout (not update!) a specified
7694 revision from a specified repository to a specified directory.
7696 * buildbot/status/progress.py (Expectations.update): Fix an
7697 obvious bug (apparently created by the change described in the
7698 previous ChangeLog message) by moving a check to *after* the
7699 variable it checks is defined.
7702 2003-09-08 Brian Warner <warner@lothar.com>
7704 * buildbot/status/progress.py (Expectations.update): hack to catch
7705 an exception TTimo sees: sometimes the update() method seems to
7706 get called before the step has actually finished, so the .stopTime
7707 is not set, so no totalTime() is available and we average None
7708 with the previous value. Catch this and just don't update the
7709 metrics, and emit a log message.
7711 2003-08-24 Brian Warner <warner@lothar.com>
7713 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7714 parameter to set copydir='original' in CVS commands.
7716 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7718 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7719 which tells the command to maintain a separate original-source CVS
7720 workspace. For each build, this workspace will be updated, then
7721 the tree copied into a new workdir. This reduces CVS bandwidth
7722 (from a full checkout to a mere update) while doubling the local
7723 disk usage (to keep two copies of the tree).
7725 2003-08-21 Brian Warner <warner@lothar.com>
7727 * buildbot/status/event.py (Logfile.addEntry): if the master web
7728 server dies while we're serving a page, request.write raises
7729 pb.DeadReferenceError . Catch this and treat it like a
7730 notifyFinish event by dropping the request.
7732 2003-08-18 Brian Warner <warner@lothar.com>
7734 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7735 (instead of blowing up) if a force-build command is given without
7738 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7739 don't blow up if there aren't yet any Changes in the list
7741 2003-08-02 Brian Warner <warner@lothar.com>
7743 * buildbot/bot.py (updateApplication): don't set the .tap name,
7744 since we shouldn't assume we own the whole .tap file
7746 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7747 'mktap buildbot' (without a subcommand) better
7749 2003-07-29 Brian Warner <warner@lothar.com>
7751 * buildbot/status/words.py
7752 (IrcStatusFactory.clientConnectionLost): when we lose the
7753 connection to the IRC server, schedule a reconnection attempt.
7755 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7756 use shutil.rmtree instead of forking off an "rm -rf" command.
7757 rmtree may take a while and will block until it finishes, so we
7758 use "rm -rf" if available.
7760 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7761 freebsd buildslave badly
7763 * setup.py (version): bump to 0.3.4+ while between releases
7765 2003-07-28 Brian Warner <warner@lothar.com>
7767 * setup.py (version): Releasing buildbot-0.3.4
7769 2003-07-28 Brian Warner <warner@lothar.com>
7771 * NEWS: update in preparation for release
7773 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7774 process.signalProcess instead of os.kill, to improve w32
7777 * docs/examples/twisted_master.py (twisted_app): turn off
7778 win32eventreactor: the tests hang the buildslave badly
7780 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7781 failed builds, since usually the failures are consistent
7783 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7784 add compileOpts/compileOpts2 to reactors build
7786 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7787 (twisted_app): use both default and win32eventreactor on w32 build.
7788 Use both default and kqreactor on freebsd build.
7790 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7791 add compileOpts2, which is put after the build_ext argument. w32
7792 needs "-c mingw32" here.
7794 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7795 touch .acqpath, it goes away in recent Twisted releases
7797 * docs/examples/twisted_master.py (twisted_app): use "python" for
7798 the w32 buildslave, not "python2.2"
7800 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7801 the directory exists.. should hush an exception under w32
7803 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7804 ProcessTerminated -provided values for signal and exitCode rather
7805 than parsing the unix status code directly. This should remove one
7806 more roadblock for a w32-hosted buildslave.
7808 * test/test_mailparse.py: add test cases for Syncmail parser
7810 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7811 temporary compatibility import. Note! Start importing
7812 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7814 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7816 2003-07-27 Brian Warner <warner@lothar.com>
7818 * NEWS: started adding new features
7820 * buildbot/changes/mail.py: start work on Syncmail parser, move
7821 mail sources into their own file
7823 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7824 as implementing IChangeSource
7825 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7827 * buildbot/interfaces.py: define the IChangeSource interface
7829 2003-07-26 Brian Warner <warner@lothar.com>
7831 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7833 2003-06-25 Brian Warner <warner@lothar.com>
7835 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7838 2003-06-17 Brian Warner <warner@lothar.com>
7840 * buildbot/status/words.py: clean up method usage to avoid error
7841 in silly IRC command
7842 (IrcStatusBot.emit_status): round off seconds display
7844 * buildbot/process/base.py (Build): delete the timer when saving
7845 to the .tap file, and restore it (if it should still be running)
7846 upon restore. This should fix the "next build in -34 seconds"
7847 messages that result when the master is restarted while builds are
7848 sitting in the .waiting slot. If the time for the build has
7849 already passed, start it very soon (in 1 second).
7851 * buildbot/status/words.py: more silly commands
7853 * README (REQUIREMENTS): add URLs to all required software
7855 * buildbot/status/words.py ('last'): mention results of, and time
7858 2003-05-28 Brian Warner <warner@lothar.com>
7860 * buildbot/status/words.py: add 'last' command
7861 (IrcStatusBot.emit_status): add current-small text to 'status' output
7863 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7864 (twisted_app): remove spaces from OS-X builder name
7866 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7867 * buildbot/status/words.py: IRC bot should actually be useful now
7869 2003-05-23 Brian Warner <warner@lothar.com>
7871 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7872 "slave information" from $(slavedir)/info/* . These files are
7873 maintained by the slave administrator, and describe the
7874 machine/environment that is hosting the slave. Information from
7875 them is put into the "Builder" HTML page. Still need to establish
7876 a set of well-known filenames and meanings for this data: at the
7877 moment, *all* info/* files are sent to the master, but only
7878 'admin' and 'host' are used on that end.
7879 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7880 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7881 * buildbot/master.py (BotPerspective.got_info): ditto
7883 2003-05-22 Brian Warner <warner@lothar.com>
7885 * setup.py (version): bump version to 0.3.3+ while between releases
7887 2003-05-21 Brian Warner <warner@lothar.com>
7889 * setup.py: Releasing buildbot-0.3.3
7891 2003-05-21 Brian Warner <warner@lothar.com>
7893 * NEWS: 0.3.3 news items
7895 * README: describe --keepalive and life behind a NAT box
7897 * buildbot/bot.py (Bot.connected): implement application-level
7898 keepalives to deal with NAT timeouts, turn them on with
7899 --keepalive option or when SO_KEEPALIVE doesn't work.
7901 * buildbot/master.py (BotPerspective): accept keepalives silently
7903 * buildbot/process/base.py (Build.buildException): CopiedFailures
7904 don't carry as much information as local ones, so don't try to
7905 create a big HTMLized version of them.
7907 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7908 log file when step fails due to an exception, such as when the slave
7911 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7912 --testmodule argument instead of grepping for test-case-name tags
7913 ourselves. Remove FindUnitTests code.
7914 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7916 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7918 2003-05-16 Brian Warner <warner@lothar.com>
7920 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7921 argument to allow things like CFLAGS=-O0 to be passed without relying
7922 upon /bin/sh processing on the slave.
7924 * buildbot/process/step.py (InternalShellCommand.start): send
7926 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7927 'split' instead of letting /bin/sh do it. This should also remove
7928 the need for /bin/sh on the buildslave, making it more likely to
7931 * buildbot/status/html.py: html-escape text in blamelist.
7932 Add "force build" button to the Builder page.
7934 * buildbot/process/step_twisted.py (countFailedTests): look at
7935 last 1000 characters for status line, as import errors can put it
7936 before the -200 point.
7938 2003-05-15 Brian Warner <warner@lothar.com>
7940 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7942 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7943 make 'clobber' a parameter, so it is possible to have builds which
7944 do full tests but do a cvs update instead of hammering the CVS
7945 server with a full checkout each build
7947 * buildbot/process/step.py (InternalShellCommand): bump default
7948 timeout to 20 minutes
7950 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7951 the master to trigger a build. Run it via manhole.
7953 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7954 allow slaves to trigger any build that they host, to make life
7955 easier for slave admins who are testing out new build processes
7957 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7958 don't flunk cReactor or qtreactor on failure, since they fail alot
7959 these days. Do warnOnFailure instead.
7961 * buildbot/process/base.py: change Builder.buildable from a list
7962 into a single slot. When we don't have a slave, new builds (once
7963 they make it past the timeout) are now merged into an existing
7964 buildable one instead of being queued. With this change, a slave
7965 which has been away for a while doesn't get pounded with all the
7966 builds it missed, but instead just does a single build.
7968 2003-05-07 Brian Warner <warner@lothar.com>
7970 * setup.py (version): bump version to 0.3.2+ while between releases
7972 2003-05-07 Brian Warner <warner@lothar.com>
7974 * setup.py: Releasing buildbot-0.3.2
7976 2003-05-07 Brian Warner <warner@lothar.com>
7978 * setup.py: fix major packaging error: include subdirectories!
7980 * NEWS: add changes since last release
7982 * README (REQUIREMENTS): update twisted/python dependencies
7984 * buildbot/status/builder.py (Builder.startBuild): change
7985 BuildProcess API: now they should call startBuild/finishBuild
7986 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7987 keeping a list of builds in the statusbag, to support other kinds of
7989 (Builder.addClient): send current-activity-small to new clients
7990 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7993 * buildbot/status/client.py: drop RemoteReferences at shutdown
7995 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7997 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7998 more debug messages for remote status client
8000 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8001 (.stepFailed): only fire the Deferred once, even if both
8002 stepComplete and stepFailed are called. I think this can happen if
8003 an exception occurs at a weird time.
8005 * buildbot/status/words.py: work-in-progress: IRC status delivery
8007 2003-05-05 Brian Warner <warner@lothar.com>
8009 * docs/examples/twisted_master.py (twisted_app): hush internal
8010 python2.3 distutils deprecation warnings
8011 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8012 add compileOpts= argument which inserts extra args before the
8013 "setup.py build_ext" command. This can be used to give -Wignore
8014 warnings, to hush some internal python-2.3 deprecation messages.
8016 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8017 the ['twisted.test'] default test case to make it easier to change
8020 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8021 * buildbot/clients/gtkPanes.py: ditto
8023 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8024 arg to collapse RunUnitTestsRandomly into RunUnitTests
8025 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8026 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8028 * buildbot/status/html.py (StatusResource): shuffle Resources
8029 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8030 would serve the waterfall display, but the internal links were
8031 only valid on the trailing-slash version. The correct behavior is
8032 for the non-slashed one to serve a Redirect to the slashed one.
8033 This only shows up when the buildbot page is hanging off another
8034 server, like a Twisted-Web distributed server.
8036 * buildbot/status/event.py (Event, RemoteEvent): make Events
8037 pb.Cacheable, with RemoteEvent as the cached version. This removes
8038 a lot of explicit send-an-update code.
8039 * buildbot/status/builder.py (Builder): remove send-update code
8040 * buildbot/status/client.py (ClientBuilder): remove send-update
8041 code, and log errors that occur during callRemote (mostly to catch
8042 InsecureJelly exceptions)
8044 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8045 run Lore with the same python used in the rest of the build
8047 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8049 * buildbot/process/step_twisted.py (HLint): accept 'python'
8050 argument. Catch rc!=0 and mark the step as failed. This marks the
8051 build orange ("has warnings").
8052 (RunUnitTestsJelly): move out to step_twisted2.py
8054 * buildbot/util.py (ignoreStaleRefs): add utility function
8056 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8057 don't fake ETA object, it's too hard to get right
8059 2003-05-02 Brian Warner <warner@lothar.com>
8061 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8063 2003-05-01 Brian Warner <warner@lothar.com>
8065 * buildbot/status/html.py (StatusResource.body): oops, I was
8066 missing a <tr>, causing the waterfall page to be misrendered in
8067 everything except Galeon.
8069 2003-04-29 Brian Warner <warner@lothar.com>
8071 * docs/examples/twisted_master.py: make debuild use python-2.2
8072 explicitly, now that Twisted stopped supporting 2.1
8074 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8075 handle tuple results too. I keep forgetting this, which suggests
8076 it needs to be rethought.
8078 * setup.py (setup): bump version to 0.3.1+ while between releases
8080 2003-04-29 Brian Warner <warner@lothar.com>
8082 * setup.py: Releasing buildbot-0.3.1
8084 2003-04-29 Brian Warner <warner@lothar.com>
8086 * README (SUPPORT): add plea to send questions to the mailing list
8088 * NEWS, MANIFEST.in: add description of recent changes
8090 * docs/examples/twisted_master.py: add the code used to create the
8091 Twisted buildmaster, with passwords and such removed out to a
8094 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8095 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8096 buildmasters to not require CVSToys be installed.
8097 * README, docs/examples/glib_master: update to match the change
8099 * buildbot/clients/base.py, buildbot/bot.py,
8100 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8101 ReconnectingPB from CVSToys distribution to remove CVSToys
8102 dependency for build slaves and status clients. Buildmasters which
8103 use FreshCVSSources still require cvstoys be installed, of course.
8105 2003-04-25 Brian Warner <warner@lothar.com>
8107 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8108 runTestsRandomly arg to turn on trial -z
8110 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8111 experimental code to use trial's machine-parseable output to get
8112 more detailed test results. Still has some major issues.
8113 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8116 * buildbot/status/builder.py (Builder.setCurrentBuild):
8117 anticipating moving build history into statusbag, not used yet
8119 * buildbot/status/tests.py: code to centralize test results,
8120 doesn't work quite yet
8122 * buildbot/status/event.py (Event): use hasattr("setName") instead
8123 of isinstance for now.. need better long-term solution
8125 * buildbot/status/html.py: Remove old imports
8127 2003-04-24 Brian Warner <warner@lothar.com>
8129 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8130 ignore changes under doc/fun/ and sandbox/
8132 * buildbot/process/step_twisted.py: update pushEvent and friends.
8134 * buildbot/status/html.py (Box.td): replace event.buildername with
8135 event.parent.getSwappableName(). Needs more thought.
8137 * buildbot/status/builder.py (Builder): Replace pushEvent and
8138 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8139 Tell events they are being pruned with event.delete().
8141 * buildbot/process/base.py (Build): Remove Builder status-handling
8142 methods. s/pushEvent/setCurrentActivity/.
8144 * buildbot/process/step.py (BuildStep): clean up status delivery.
8145 Gouse builder.statusbag methods instead of intermediate builder
8146 methods. s/updateLastEvent/updateCurrentActivity/.
8147 s/finalizeLastEvent/finishCurrentActivity/. Use
8148 addFileToCurrentActivity for summaryFunction.
8150 * buildbot/status/event.py (Logfile): put data in a Swappable when
8152 (Event): add more setter methods. Remove .buildername, use .parent
8153 and getSwappableName instead (needs more thought).
8155 * buildbot/util.py (Swappable):
8156 * test/test_swap.py: don't bother setting filename at __init__
8157 time, do it later. Change setFilename args to take parent first,
8158 since it provides the most significant part of the filename.
8160 2003-04-23 Brian Warner <warner@lothar.com>
8162 * buildbot/status/event.py (Logfile.addEntry): append to previous
8165 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8166 anticipating Swappable
8167 (InternalShellCommand.remoteUpdate): split out various log-adding
8168 methods so subclasses can snarf stdout separately
8170 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8171 in anticipation of Swappable build logs
8172 (Builder.testsFinished): anticipating TestResults, still disabled
8174 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8177 * buildbot/status/event.py (Logfile): add (disabled) support for
8178 Swappable, not ready for use yet
8180 * buildbot/util.py (Swappable): object which is swapped out to
8181 disk after some period of no use.
8182 * test/test_swap.py: test buildbot.utils.Swappable
8184 2003-04-14 Brian Warner <warner@lothar.com>
8186 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8187 periodic-build timer. Set the .periodicBuildTime on a builder
8188 instance to some number of seconds to activate it.
8190 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8192 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8193 a way that survives result tuples
8195 2003-04-12 Brian Warner <warner@lothar.com>
8197 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8198 return a dict instead of a tuple: allow summarizers to provide
8199 multiple summaries if they want
8200 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8201 (debuildSummarizer): summarize lintian warnings/errors
8203 2003-04-10 Brian Warner <warner@lothar.com>
8205 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8207 2003-04-09 Brian Warner <warner@lothar.com>
8209 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8210 empty summaries: happens when the tests fail so hard they don't emit
8211 a parseable summary line.
8213 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8214 Allow summaryFunction to return None to indicate no summary should
8217 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8218 writing to stale HTTP requests: notice when they disconnect and
8219 remove the request from the list. Also add CacheToFile from
8220 moshez, will be used later.
8222 2003-04-08 Brian Warner <warner@lothar.com>
8224 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8225 should be an int, not a list of strings
8227 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8228 if we weren't actually connected
8230 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8231 to show the tail end of the trial text output
8233 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8234 hook to summarize the results of a ShellCommand
8236 2003-04-07 Brian Warner <warner@lothar.com>
8238 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8239 twisted test suite code into a single class.
8240 * buildbot/process/process_twisted.py: same
8242 2003-04-04 Brian Warner <warner@lothar.com>
8244 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8246 * README (SLAVE): document use of mktap to create slave .tap file
8247 (REQUIREMENTS): describe dependencies
8249 * buildbot/bb_tap.py, buildbot/plugins.tml:
8250 * buildbot/bot.py (updateApplication): Add mktap support for creating
8251 buildslave .tap files
8253 2003-03-28 Brian Warner <warner@lothar.com>
8255 * buildbot/process/step.py (InternalShellCommand.finished): handle
8256 new tuple result values (fix embarrasing bug that appeared during
8259 2003-03-27 Brian Warner <warner@lothar.com>
8261 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8264 2003-03-25 Brian Warner <warner@lothar.com>
8266 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8267 to overall build status
8268 * buildbot/clients/base.py (Builder): improve event printing
8269 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8270 instead of generic ShellCommand
8271 (Build): Add .stopBuild, use it when slave is detached
8273 * buildbot/process/step.py (Configure,Test): give the steps their
8274 own names and status strings
8276 * buildbot/status/html.py (StatusResource): add "show" argument,
8277 lets you limit the set of Builders being displayed.
8279 2003-03-20 Brian Warner <warner@lothar.com>
8281 * buildbot/process/basic.py: removed
8283 2003-03-19 Brian Warner <warner@lothar.com>
8285 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8286 turn off process-docs by default
8288 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8289 when displaying build information without anything in allBuilds[]
8291 * buildbot/bot.py (makeApp): really take password from sys.argv
8293 2003-03-18 Brian Warner <warner@lothar.com>
8295 * buildbot/bot.py (buildApp): take password from sys.argv
8297 * README: replace with more useful text
8299 * setup.py: add a real one
8300 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8302 * docs/PyCon-2003/: added sources for PyCon paper.
8304 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8305 now Build objects control the process and Builder only handles
8306 slave stuff and distribution of changes/status. A new BuildFactory
8307 class creates Build objects on demand.
8309 Created ConfigurableBuild which takes a list of steps to run. This
8310 makes it a lot easier to set up a new kind of build and moves us
8311 closer to being able to configure a build from a web page.
8313 * buildbot/process/step_twisted.py, process_twisted.py: move to
8314 new model. A lot of code went away.
8316 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8317 send lots of empty progress messages to the client.
8319 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8321 2003-02-20 Brian Warner <warner@lothar.com>
8323 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8325 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8326 Twisted bug that prevented non-pty processes from working just got
8327 fixed, and the bug that leaks ptys is still being investigated.
8329 * buildbot/process/step.py (CVS): send timeout arg to slave
8331 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8332 builders coming and going
8333 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8334 from CVSToys, handle lost-buildmaster
8336 * buildbot/status/client.py (StatusClientService.removeBuilder):
8337 Clean up status client protocol: send builders (with references)
8338 as they are created, rather than sending a list and requiring the
8339 client to figure out which ones are new.
8340 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8341 attempts to force a build on an unknown builder
8343 2003-02-19 Brian Warner <warner@lothar.com>
8345 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8346 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8347 Twisted stops leaking them.
8348 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8349 builder goes to an idle state.
8351 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8352 I figure out why CVS commands hang without them, and/or I fix the
8353 hung-command timeout
8355 2003-02-16 Brian Warner <warner@lothar.com>
8357 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8358 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8359 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8360 GenerateDocs now that they are prefixed with WARNING:.
8362 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8363 use manual href target instead of request.childLink
8365 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8366 display every second, but update the ETA every 5 seconds (or
8367 whenever) as remote_progress messages arrive.
8370 2003-02-12 Brian Warner <warner@lothar.com>
8372 * *: import current sources from home CVS repository
8376 # add-log-time-format: add-log-iso8601-time-string