1 2007-09-30 Brian Warner <warner@lothar.com>
3 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
4 auto-create an empty public_html directory, otherwise we get
5 internal server errors instead of 404s.
7 * README: reference buildbot.net, remove CVSToys section (does
10 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
11 message when public_html/ is missing (indicating that you should
12 probably run 'upgrade-master'), and don't auto-create an empty
13 directory in that case.
15 * contrib/darcs_buildbot.py: refactor internals a bit, make it
16 possible to use as an importable module (to make it easier to
17 write some unit tests for it)
19 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
20 DeprecationWarning for Waterfall, advising users to switch over to
23 * NEWS: update with user-visible changes since the last release
25 * buildbot/status/web/waterfall.py
26 (WaterfallStatusResource.get_reload_time): if the suggest a
27 reload time of less than 15 seconds, give them 15 seconds instead
28 of ignoring their request entirely, because that'd be confusing.
30 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
31 warning if we must invoke the last-change-is-most-recent guess
33 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
34 Waterfall is running in an upgraded master (which is the usual
35 case for folks who have followed the instructions to run
36 'upgrade-master' but who have not yet resolved all the
37 DeprecationWarnings), prefer the buildbot.css from public_html/
38 rather than the one passed in on the buildbot= argument.
39 Otherwise, the resulting pages don't quite use CSS right..
40 sometimes it works, sometimes it doesn't, and I don't know why.
41 Sites that are using custom CSS will see the default CSS until
42 they modify public_html/buildbot.css to include their
45 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
46 * buildbot/status/web/robots.txt (Disallow): update to cover all
47 dynamically-generated pages
49 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
50 include both 'trunk' and None in the output list, since some VC
51 systems (SVN, frequently) refer to trunk as 'trunk'.
53 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
54 point the 'welcome' link explicitly at index.html, rather than
55 '.', so that old Waterfall users can reach it and discover all the
58 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
59 build's text to the end of the line, without a CSS class so it
62 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
63 'max_search=' argument, to limit the number of builds that are
64 examined while trying to find ones that match the other criteria.
65 This helps to limit the work we do, since otherwise we might have
66 to trawl through all history.
67 (IBuilderStatus.generateFinishedBuilds): same
68 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
69 (BuilderStatus.generateFinishedBuilds): same
71 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
72 our got_revision before checking its length: SVN (at least) still
73 reports numeric values for this.
74 * buildbot/status/web/build.py (StatusResourceBuild.body): same
75 * buildbot/status/web/xmlrpc.py
76 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
77 serving a completely fake revision
79 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
80 basedir to sys.path, to mimic what a real buildmaster would have
81 access to, since it is common for master.cfg to import helper
82 classes from .py files in the buildmaster directory, and we want
83 config-file checking to accomodate this.
85 * buildbot/status/web/base.py (map_branches): when referring to
86 branches through WebStatus (i.e. by appending ?branch=FOO query
87 arguments to the URL), make "trunk" mean trunk, by mapping it to
88 None before passing it to generateFinishedBuilds() and the like.
89 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
90 (OneBoxPerBuilder.body): same, also improve display of branches in
92 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
93 (WaterfallStatusResource.buildGrid): same. Note that this filters
94 Changes as well as Builds.
95 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
96 caveat about trunk branches, now that it's fixed
98 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
99 from builder.py, use it on the Builder page too
101 * buildbot/status/web/builder.py (StatusResourceBuilder): same
102 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
103 names, add some CSS classes
104 * buildbot/status/web/classic.css (td.box): new class, for
107 * docs/buildbot.texinfo (WebStatus): update docs
109 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
110 the trailing "M" indicator that tells us this is a modified file.
111 This should help with mode="update" builds that modify files
112 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
115 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
116 new copies of files (to .new) when those files already exist,
117 check the master.cfg file for errors (and give DeprecationWarnings
118 a chance to be displayed).
119 * buildbot/test/test_runner.py: add more tests
120 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
122 2007-09-29 Brian Warner <warner@lothar.com>
124 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
125 the revision id from the last change in our list, since that's the
126 best we can do without knowing the full ancestry graph. Closes #103.
128 * buildbot/scripts/sample.cfg: use buildstep instances in
129 f.addStep, to demonstrate the (correct) modern usage.
130 * docs/examples/hello.cfg: bring this up to date. Closes #79.
131 * docs/examples/twisted_master.cfg: add a big warning about how
133 * docs/examples/glib_master.cfg: delete this one entirely, it is
134 ancient and not a very useful example anyways
136 * buildbot/status/web/base.py (HtmlResource.render): keep track of
137 HTTPChannels, so we can shut them down at reconfig time (when the
138 WebStatus goes away). Closes #102.
139 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
140 (WebStatus.registerChannel): same
141 (WebStatus.stopService): do .loseConnection() here
143 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
144 WebStatus, make sure all pages are still retrievable. I thought
145 this would exercise a bug, but it turns out that it was firefox
146 caching connections (and continuing to talk to the old WebStatus
147 even though I'd loaded a new one).
148 * buildbot/status/web/baseweb.py (WebStatus): add some comments
149 (WebStatus.__repr__): include id() in the repr
151 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
152 this to specify an errorparser. From Ted Mielczarek and the
153 mozilla crew. Closes #94.
155 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
156 bonsaipoller ignore funkyness in xml output for empy log
157 messages", from Axel Hecht. Closes #90.
158 * buildbot/test/test_bonsaipoller.py
159 (TestBonsaiPoller.testMergeEmptyLogMsg): same
161 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
162 respect 'builders' arg, from Ben Hearsum. Closes #89.
164 * buildbot/scripts/runner.py (stop): increase the timeout from 5
165 seconds to 10, to give heavily loaded machines a better chance to
166 finish shutting down. Addresses (partially) #68.
167 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
169 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
170 * buildbot/scripts/startup.py (Follower._failure): update message
172 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
173 team, to fix some bugs and avoid the use of blocking urlopen().
175 * buildbot/test/test_bonsaipoller.py: same
177 2007-09-28 Brian Warner <warner@lothar.com>
179 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
180 argument, to send email about buildslaves which are disconnected
181 for more than an hour. Closes #64.
182 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
184 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
185 (MailNotifier): add docs for this too
188 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
189 respect branch= queryargs, by restricting the builds displayed to
190 those matching the given branch names
191 * buildbot/status/web/waterfall.py (BuildTopBox): same
193 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
194 fix a test failure by adding .prepath to this fake object
196 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
197 up generation of relative URLs. With luck, this should play with
198 reverse proxies much better now.
199 * buildbot/test/test_webparts.py: new test for most of the subpages
200 * buildbot/test/test_web.py (base_config): add enough of a config
201 to exercise more Waterfall code
203 2007-09-27 Brian Warner <warner@lothar.com>
205 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
206 relative URL to the buildbot welcome page, rather than
208 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
210 * buildbot/status/web/base.py (HtmlResource.title): change the
211 default title of all Buildbot-generated page to "Buildbot"
212 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
213 change the title to include the Builder name
214 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
215 same, and also show the build number
216 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
217 redirect the browser to the Builder page
219 2007-09-26 Brian Warner <warner@lothar.com>
221 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
222 problem with the build links
224 2007-09-25 Brian Warner <warner@lothar.com>
226 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
227 to emit relative URLs instead of using URLPath,
229 * docs/buildbot.texinfo (WebStatus): provide an example
231 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
232 page, shows a simple table with one row per Builder. Still pretty
233 ugly, but functional.
234 * buildbot/status/web/index.html: reference it
236 * buildbot/status/web/waterfall.py (Spacer): make this *not*
237 inherit from builder.Event, so that show_events=false doesn't hide
238 spacers, since that would make the waterfall weirdly compressed.
240 * buildbot/status/web/waterfall.py (HELP): put the View button in
241 its own section, so it doesn't get visually confused with the
243 (WaterfallStatusResource.body): make the '[help]' links more
244 visually distinct from each other, and add a link to the Welcome
246 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
247 unused buildslaves without exploding
249 * buildbot/status/web/waterfall.py
250 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
251 it gives us absolute paths that break proxies
252 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
253 this, it was giving bad results when the Waterfall is behind a
256 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
257 new 'upgrade-master' command, which will bring an old buildmaster
258 directory up-to-date. Right now the only thing it does is populate
259 public_html/ if it wasn't already there. Still to do: check the
260 other files, add documentation.
261 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
262 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
264 2007-08-13 Brian Warner <warner@lothar.com>
266 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
267 that contains the checkin comments when you hover over the entry
268 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
271 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
274 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
275 page with versions of python, buildbot, and twisted
276 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
277 * buildbot/status/web/index.html: add links to most pages
278 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
280 * buildbot/status/web/robots.txt: put a robots.txt in new installs
281 which discourages robot access to all large dynamically-generated
282 pages. The intention is that the index page and the 'about' page
283 are the only ones which should be crawlable.
284 * buildbot/scripts/runner.py (Maker.public_html): same
286 * setup.py: ship index.html and robots.txt in source distributions
288 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
289 activate automatic reloading of the page (using a meta Refresh:
291 (WaterfallHelp): new page to explain all the nifty query arguments
292 you can use on the Waterfall, along with forms to set them for
293 you. From this page, you can add filters for builder=, branch=,
294 show_events=, as well as turning on reload=.
295 (WaterfallStatusResource.buildGrid): new query args: last_time=,
296 first_time=, show_time=, num_events= . The old show= is still
297 accepted, but the new builder= is preferred. We ignore empty
298 branch= arguments, to make the WaterfallHelp form easier to
300 (WaterfallStatusResource.head): new method to add text to the
302 * buildbot/status/web/base.py (HtmlResource.content): use head()
303 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
304 empty branch= arguments
305 (OneLinePerBuildOneBuilder.body): same
307 2007-08-12 Brian Warner <warner@lothar.com>
309 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
310 new query args: 'last_time' is a timestamp of the top-most event
311 on the display, 'first_time' is a timestamp for the bottom-most
312 event. 'show_time' is the difference between them, and overrides
313 'first_time'. 'num_events' puts an upper limit on the number of
314 timestamps that will be displayed on the left hand edge.
315 (WaterfallStatusResource.body): add a 'next page' link to the
316 bottom, which shows the events that come just after those shown on
317 the current page. This is a first step towards #67, but we need
318 some more controls before we can close that one.
320 * buildbot/buildslave.py (BuildSlave): these are now MultiService
321 instances too, and live as children of the BotMaster. The main
322 advantage of this approach is that BuildSlaves can know when they
323 are being removed (so they can shut off the upcoming
324 when-do-we-email-an-admin-because-we-lost-our-slave timer).
325 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
326 identify which service children are BuildSlaves
327 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
328 Checker updates here, but delegate the rest to..
329 (BotMaster.loadConfig_Slaves): .. here, which looks at the
330 BotMaster's service children to identify the old slaves. I think
331 the previous approach of using master.slaves was broken in the
332 face of config updates that modified BuildSlave instances but did
333 not completely replace them.
334 * docs/buildbot.texinfo (Developer's Appendix): note the change to
335 the Service hierarchy
337 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
338 page (at URL /buildslaves/) to view status of all buildslaves at
339 once, including how long it's been since we last heard from them,
340 and which Builders use them.
342 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
345 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
348 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
349 use the BuildSlave to keep track of the last time we've heard from
350 the buildslave. This is updated upon receipt of any message from
351 any SlaveBuilder (which generally means when RemoteCommands are
352 giving us status updates, as BuildSteps run). In the future this
353 will include slave pings too.
354 * buildbot/process/base.py
355 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
356 * buildbot/process/buildstep.py:
357 (BuildStep.setBuildSlave): accept that reference
358 (BuildStep.runCommand): pass the reference on to the RemoteCommand
359 (RemoteCommand.remote_update): update the timestamp
360 (RemoteCommand.remote_complete): same
361 * buildbot/test/runutils.py (StepTester.makeStep): match the change
362 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
363 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
364 interface to retrieve this timestamp
365 * buildbot/status/builder.py (SlaveStatus): track a copy of the
369 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
371 (OneLinePerBuild.body): use a <ul> instead of <div>s
372 (OneLinePerBuildOneBuilder.body): same
374 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
375 by adding the file's new name to the list of changed files. This
376 ought to be sufficient for things like isFileImportant and trial
377 tests that only exercise tests for files that have been modified.
380 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
381 XMLRPC server to the WebStatus page. This only has two methods
382 right now (getAllBuildsInInterval and getBuild), but we'll be
383 adding more in the future. This server is extracted from the
386 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
387 generateFinishedBuilds, and improve the data displayed.
388 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
389 the per-Build page, add some information like ETA and got_revision
390 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
391 adding a list of recently completed builds
392 * buildbot/status/web/base.py (css_classes): factor this out
394 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
395 new method, to make status display classes easier to write,
396 especially the WebStatus 'one_line_per_build' page.
397 (IBuilderStatus.generateFinishedBuilds): same
398 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
399 (Status.generateFinishedBuilds): implement it
401 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
402 'source' to be a BuildStep instance, since BuildFactory accepts
404 (CPAN.__init__): same
405 (Distutils.__init__): same
406 (Trial.__init__): same
408 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
409 this might raise KeyError
411 2007-08-07 Brian Warner <warner@lothar.com>
413 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
414 'Owner:' field of the view, rather than 'p4logname', since
415 p4logname comes from the buildslave's environment and seems
416 unlikely to ever do the right thing. Thanks to Wade Brainerd for
417 the patch. Closes #40.
419 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
420 which imposes a per-slave limit on how many builds are allowed to
421 run simultaneously. This has a the same scope than the SlaveLock,
422 but is different because max_builds= gives the buildmaster the
423 freedom to assign the build to a different slave, whereas the
424 SlaveLock doesn't get tested until after the build is irrevocably
425 assigned to a slave. Therefore using max_builds= will improve
426 utilization in the presence of multiple buildslaves that are
427 attached to the same Builder. This completes the incorporation of
428 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
429 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
430 any Builder finishes, potentially trigger *all* Builders, since
431 max_builds= may have stalled someone else while waiting for the
433 * buildbot/scripts/sample.cfg: mention max_builds=
434 * buildbot/test/test_run.py (ConcurrencyLimit): test it
435 * docs/buildbot.texinfo (Buildslave Specifiers): document it
437 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
438 inherit from RunMixin do not need to call master.stopService()
439 themselves, since RunMixin.tearDown does that. The double call
440 fails on Twisted-2.0.x, which didn't happen to protect against it.
441 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
443 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
444 from #48, this one to have the BuildSlave objects track
445 SlaveBuilders, so they'll be able to use that knowledge to
446 influence their canStartBuild() response.
447 * buildbot/process/builder.py (SlaveBuilder.attached): call it
448 (SlaveBuilder.detached): same
449 * buildbot/test/test_slaves.py (BuildSlave): test it
451 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
452 the second of Dustin's #48 patches, this one adding a method to
453 the BuildSlave that allows it to decide whether it is willing to
454 participate in a build or not.
455 (SlaveBuilder.isAvailable): use canStartBuild() to decide
457 * buildbot/test/test_run.py (CanStartBuild): test for it
459 * all: incorporate the first of four patches by Dustin Mitchell
460 from ticket #48, working towards improving control over slave
461 concurrency. The first patch is to use a long-lived BuildSlave
462 object per slave, on which other behavior can be added later. I've
463 modified his patch considerably.
464 * buildbot/buildslave.py (BuildSlave): move class out of
465 slave/__init__.py (where it would get loaded by the slave as well
466 as the master, making dependencies trickier), and merge it with
467 BotPerspective. Now these BuildSlave instances are created once in
468 the master.cfg file, and not destroyed until they are either
469 removed from the config file or changed so
470 much (name/password/class changes) that we cannot continue to use
471 the old one. This affects config files: they must use
472 'from buildbot.buildslave import BuildSlave' instead of using
473 'from buildbot.slave import BuildSlave'.
474 * buildbot/master.py: move BotPerspective out
475 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
476 add or remove as necessary, update the rest using data from
478 * buildbot/slave/__init__.py: move BuildSlave out
479 * buildbot/test/test*.py: import BuildSlave from the new place
480 * buildbot/scripts/sample.cfg: update to match
481 * docs/buildbot.texinfo: update to match
482 * buildbot/process/builder.py: update comments to match
484 2007-08-02 Brian Warner <warner@lothar.com>
486 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
487 one-line-per-build pages a bit, add a header, refactor slightly
489 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
490 the TimeOutError timer, patch by Dustin Mitchell.
492 2007-08-01 Brian Warner <warner@lothar.com>
494 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
495 mostly work (branch= is still ignored, we need a useful header)
496 (OneLinePerBuildOneBuilder.body): this too
498 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
499 bring this up-to-date w.r.t. recent refactorings, and fix
500 redirections to bounce the browser to the top page after hitting
501 the 'force' button. This needs to be improved, but at least it now
502 redirects to a valid page.
503 (StatusResourceBuilder.ping): same
504 (StatusResourceBuilder.getChild): same, although I think this code
505 might be dead anyways
507 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
508 a branch= query argument, to filter the display down to builds and
509 changes that involve the given branch. You can add multiple
510 branch= arguments to see multiple branches (using a logical OR).
511 Note that there is no way to include the default branch (i.e.
512 None, i.e. trunk) yet, there is still work to be done to allow for
513 simple+uniform names of branches (i.e. removing the VC-specific
514 details of how branches are implemented, so calling the branch
515 'beta4' even though the SVN checkout step requires
517 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
518 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
519 * buildbot/interfaces.py (IEventSource.eventGenerator): same
520 * docs/buildbot.texinfo (Buildbot Web Resources): document it
522 * all: bring import statements up-to-date: don't import
523 __future__, assume cPickle and cStringIO are always available.
524 Also remove #!/usr/bin/python lines from non-scripts, my editor
525 has been a bit over-enthusiastic about stuffing them into new .py
528 * buildbot/status/web/index.html: put a link to the waterfall page
529 on the index, otherwise first-time users of WebStatus aren't going
530 to see anything very interesting.
532 * buildbot/interfaces.py (IEventSource): document this interface.
533 Thanks to Dustin Mitchell for the patch. Closes #60.
534 * buildbot/status/builder.py (BuilderStatus): same
535 * buildbot/changes/changes.py (ChangeMaster): same
537 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
538 add a query arg of 'show_events=true' to display non-build events,
539 like slaves attaching/detaching and reconfig events, or
540 'show_events=false' to hide them. The default is 'true'.
541 * docs/buildbot.texinfo (Buildbot Web Resources): document it
543 * web-parts: merge in web-parts branch. Lots of changes. The new
544 functionality is to add buildbot.status.html.WebStatus, which is a
545 superset of the Waterfall that adds new status pages and serves
546 regular files from BASEDIR/public_html/ , which is now the preferred
547 place to put robots.txt, buildbot.css, and index.html .
548 * buildbot/scripts/runner.py: the 'create-master' command now
549 creates public_html/ too, and populates it with a couple of
551 * buildbot/status/web: split waterfall code into smaller pieces
553 2007-07-31 Brian Warner <warner@lothar.com>
555 * buildbot/scripts/startup.py (launch): import twistd.run in a
556 different way to hush pyflakes
557 * buildbot/process/builder.py: remove unused import
559 2007-07-30 Brian Warner <warner@lothar.com>
561 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
562 Mitchell: pass SourceStamps around rather than branch/version/etc
563 tuples. Thanks Dustin! Closes #70.
564 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
565 tuple rather than a list, to avoid surprising mutations
566 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
567 * buildbot/status/mail.py (MailNotifier.buildMessage): same
568 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
569 * buildbot/test/test_status.py (Subscription): same
570 * buildbot/test/test_control.py (Force): same
571 * buildbot/test/test_buildreq.py (Request.testMerge): same
573 2007-07-29 Brian Warner <warner@lothar.com>
575 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
576 variable, since it wasn't used and is confusing in the presence of
577 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
580 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
581 the Buildbot home-page link to point at buildbot.net instead of
582 sourceforge, and add a current-version query parameter so we can
583 get some statistics on which versions are in use out there.
585 2007-07-28 Brian Warner <warner@lothar.com>
587 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
588 with c['change_source'], leaving c['sources'] for backwards
589 compatibility (but deprecated), scheduled for removal in 0.8.0
590 * docs/buildbot.texinfo: same
591 * buildbot/test/test_config.py: verify that c['sources'] still works
592 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
593 * buildbot/scripts/sample.cfg: update to match
595 * buildbot/changes/mail.py (MaildirSource): parse with python's
596 stdlib 'email' module, which has been available since python2.2,
597 and drop use of the 'rfc822' module, which has been depreceated
599 * buildbot/test/test_maildir.py: same: use parse_file() not parse
601 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
602 this needs to match the renaming in test/mail/msg*
604 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
607 * buildbot/test/test_mailparse.py: rename sample emails a bit
608 * buildbot/test/mail/msg*: same
610 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
611 parser for the "commit-email.pl" script that is shipped with SVN,
612 written by Justin Mason. Thanks! Closes SF#1072845.
613 * buildbot/test/mail/svn-commit.*: sample messages
614 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
615 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
617 2007-07-27 Brian Warner <warner@lothar.com>
619 * buildbot/changes/mail.py: refactor: move parsing into a method
620 named 'parse', each parser type gets a separate subclass. Remove
621 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
622 to be a simple leading-substring match. Add a warning to the logs
623 if prefix= does not end in a slash, since that's probably a
624 mistake. Fix both places where a prefix= mismatch would skip all
625 subsequent files in the same email, instead of just skipping the
626 one that didn't match.
627 * buildbot/test/test_mailparse.py: match changes
629 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
630 docs on email-based ChangeSources
632 * docs/buildbot.texinfo (Getting Source Code Changes): move all
633 the changesource types up a level, removing the one-entry menu in
636 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
637 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
638 instances instead of tuples. Closes #63.
639 * buildbot/slave/__init__.py (BuildSlave): define marker class
640 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
641 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
642 * buildbot/test/test_*.py: update tests to match
643 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
644 the c['bots'] backwards-compatibility handler works
646 2007-07-26 Brian Warner <warner@lothar.com>
648 * buildbot/changes/hgbuildbot.py (hook): add an in-process
649 Mercurial change-sending hook, contributed by Frederic Leroy.
650 Thanks! Addresses #50.
651 * docs/buildbot.texinfo (MercurialHook): document it
653 * buildbot/changes/hgbuildbot.py: change the way imports are done,
654 to make it compatible with at least hg-0.9.1 and the current 0.9.4
656 2007-07-17 Brian Warner <warner@lothar.com>
658 * buildbot/process/buildstep.py (BuildStep.getLog): add a
659 convenience method to retrieve a log added with
660 addLog()/addCompleteLog()/etc or logfiles= . I should have added
663 2007-07-03 Brian Warner <warner@lothar.com>
665 * buildbot/slave/commands.py (ShellCommand._startCommand): when
666 logging the environment variables, put one variable on each line,
667 rather than having one really long line with all of them. This
668 should make them a bit more readable and not trigger the
669 horizontal scrollbar (when viewing it in a web browser) quite so
670 much. Thanks to Albert Hofkamp for the patch.
672 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
673 WithProperties instance. Thanks to Axel Hecht for the patch.
675 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
676 * docs/buildbot.texinfo (Build Properties): document it
677 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
678 workdir if it didn't already exist.
680 * docs/buildbot.texinfo (Scheduler Types): correct the description
681 of Dependent schedulers. Thanks to Greg Ward for the patch.
683 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
684 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
685 the patch. Closes #49.
687 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
688 0700 before removing it, to deal with situations where a build will
689 leave files around without write permissions and the 'copy' or
690 'clobber' VC checkout modes need to blow away the tree first.
691 Thanks to Steve Milner for the suggestion and the patch (which I
692 mangled horribly). Closes #29.
693 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
696 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
697 an allowReconnect= argument to let callers control whether they
698 want this don't-let-it-reconnect behavior, since some tests care.
699 Factor out the .continueTrying=False lines from those callers.
700 * buildbot/test/test_slaves.py: same
701 * buildbot/test/test_run.py: same
703 2007-07-02 Brian Warner <warner@lothar.com>
705 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
706 slave has been disappeared, don't let it reconnect. This was
707 causing an intermittent failure in test_slaves.py, when the slave
708 that was supposed to be gone managed to come back by the end of
709 the test and affect the count.
710 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
712 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
713 diagnostic messages to track down this problem
714 (Builder.startBuild): same
716 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
717 the slave randomly rather than always taking the first one. Thanks
718 to Pike for the patch. Closes #36.
719 * buildbot/test/test_slaves.py: match the change. to avoid huge
720 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
721 enables/disables the round-robin-ness (enabled by default), and
722 some unit tests disable it.
723 * docs/buildbot.texinfo (Buildmaster Architecture): document it
725 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
726 argument to 'buildmaster_host', to make it more obvious that this
727 points to the buildmaster. Thanks to Bob Proulx for the
729 * buildbot/scripts/runner.py (slaveTAC): same
730 * buildbot/test/test_runner.py (Create.testSlave): match the change
732 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
735 2007-06-17 Brian Warner <warner@lothar.com>
737 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
738 we can round-trip all of our current step classes by calling
739 getStepFactory() and using the results to make a clone of the
742 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
745 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
746 the config file, we're moving to using actual instances instead of
747 the (class, kwargs) 'step specification' tuples. BuildFactory
748 still keeps a list of tuples internally, but when real instances
749 are passed in to addStep(), they are asked for their class and
750 kwargs using the new BuildStep.getStepFactory method. BuildFactory
751 accepts both instances and the tuple form, and converts instances
752 to the tuple form, but the instance form is preferred because it
753 gives the Steps a chance to do argument validation. Closes: #11.
755 * buildbot/process/buildstep.py (BuildStep.__init__): record the
756 factory information necessary to implement getStepFactory. The
757 addFactoryArguments() method can be used to include arguments that
758 aren't passed to the BuildStep base class constructor.
759 (BuildStep.setBuild):
760 (BuildStep.setDefaultWorkdir): new methods to take parameters that
761 are needed for live BuildSteps but not to construct the specification
762 tuples that are stashed in the factory.
764 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
765 'workdir' into new BuildSteps by using methods instead of
766 arguments. This makes the constructor for BuildSteps a lot
769 * buildbot/steps/*.py: update to match this change. Basically this
770 means adding calls to addFactoryArguments() in the __init__
771 methods to capture the arguments that aren't passed through to the
773 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
774 the new workdir (if any) into the RemoteShellCommands arguments.
775 * buildbot/steps/source.py: allow workdir= to be optional,
776 implement setDefaultWorkdir() since we don't inherit from
777 (CVS): finally remove old clobber=/export=/copydir= arguments,
778 in favor of the mode= argument that's been around forever now.
779 * buildbot/steps/transfer.py: remove build= argument
781 * buildbot/test/*.py: update to match, generally by turning all
782 build= arguments into subsequent calls to s.setBuild()
783 * buildbot/test/test_config.py (Factories): verify that we can
784 use either BuildStep instances or class/kwarg tuples in both
785 BuildFactory.addStep and BuildFactory.__init__
787 * docs/buildbot.texinfo (Build Steps): document the new approach,
788 mention compatibility with the old approach, update all examples
789 to use the new style.
791 2007-06-16 Brian Warner <warner@lothar.com>
793 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
794 the LoopingCall, just eat the failure so that we'll poll again
795 next time. This should allow us to tolerate (e.g.) sf.net SVN
796 failures more gracefully. Many thanks to Dustin Mitchell for the
799 2007-05-17 Brian Warner <warner@lothar.com>
801 * buildbot/status/words.py: refactor the IRC status bot into
802 separate 'Contact' and 'Channel' classes. The base Contact class
803 contains the interaction code: commands and responses. The
804 IRCContact subclass (and IrcStatusBot 'Channel') handle the
805 IRC-specific aspects. The plan is to write other subclasses for
806 other IM protocols like AIM and Jabber.
808 2007-04-16 Brian Warner <warner@lothar.com>
810 * CREDITS: update list of contributors. Thank you all!
812 2007-04-13 Brian Warner <warner@lothar.com>
814 * buildbot/status/mail.py (MailNotifier): add the project name to
815 the subject line and message body, to make it easier to
816 distinguish email coming from different buildmasters. Thanks to
817 Benoit Sigoure for the patch.
818 * buildbot/test/test_status.py (Mail): update to match
820 2007-03-24 Brian Warner <warner@lothar.com>
822 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
823 avoid text-conversion problems between DOS/windows and unix.
824 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
826 2007-03-03 Brian Warner <warner@lothar.com>
828 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
829 warning about the use of Waterfall here
831 2007-03-01 Brian Warner <warner@lothar.com>
833 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
835 2007-02-28 Brian Warner <warner@lothar.com>
837 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
838 Lamb to use a more optimal form of 'p4 changes', to reduce server
839 load. He reports that this optimization was added to p4d release
840 2005.2, but it should work in all versions. Closes #27.
841 * buildbot/test/test_p4poller.py: match it
843 2007-02-27 Brian Warner <warner@lothar.com>
845 * buildbot/status/web/*.py: move all web status stuff into a
846 separate directory, in anticipation of splitting it into smaller
847 pieces and adding more files. html.py was getting way too big.
848 * buildbot/status/classic.css: move it too
849 * setup.py: add the new sub-package
850 * buildbot/test/test_web.py: match the changes
851 * MANIFEST.in: handle the move of classic.css
853 2007-02-07 Brian Warner <warner@lothar.com>
855 * contrib/OS-X/*: add some launchd .plist files for automatically
856 starting a buildmaster or buildslave under OS-X (10.4 or later).
857 Thanks to Mark Pauley for these.
859 2007-02-06 Brian Warner <warner@lothar.com>
861 * docs/buildbot.texinfo (Requirements): update requirements to
862 stop claiming compatibility with python-2.2 or twisted-1.3.x .
864 * README: mention python-2.5 and twisted-2.5 compatibility
866 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
868 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
870 * buildbot/status/builder.py: same, by requiring cStringIO
871 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
872 * buildbot/test/test_vc.py: same
873 * buildbot/test/test_web.py:
874 * buildbot/test/test_steps.py: same, remove unused import
876 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
879 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
880 see any Builders that don't have Schedulers to drive them
882 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
883 attributes this uses went away
885 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
886 dialog, to allow you to reset the buildmaster and force
887 connect/disconnect. Correctly handle losing the buildmaster
888 connection (by switching the display to the hexnut, at which point
889 you can use the 'Connect' menu item to reconnect).
891 * buildbot/steps/source.py (Source.start): if we're using a patch,
892 add it as a LogFile to the checkout/update step. This will turn
893 into a link on the waterfall page.
895 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
896 option, to take the patch from a pre-made file rather than
897 generating it from the local tree. Thanks to Robert Helmer for the
898 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
899 * buildbot/scripts/runner.py (TryOptions): add --diff,
900 --patchlevel, and --baserev options
901 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
902 as None, meaning HEAD.
903 * buildbot/sourcestamp.py (SourceStamp): update docstring to
904 indicate that baserev=None means HEAD
905 * docs/buildbot.texinfo (try --diff): document it
907 * buildbot/test/test_steps.py (BuildStep): remove use of
908 reactor.iterate(), although the technique I replaced it with is a
909 gross polling hack that must be cleaned up properly some day. This
910 was the last use of reactor.iterate in the entire tree, yay.
912 2007-02-05 Brian Warner <warner@lothar.com>
914 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
915 is one of the three known values, otherwise we emit some confusing
916 messages later on. Thanks to Grig Gheorghiu for the catch.
918 2007-01-30 Brian Warner <warner@lothar.com>
920 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
921 Hearsum contributed a patch to let BonsaiPoller work with results
922 that contain non-ascii characters. Closes SF#1632641.
924 2007-01-27 Brian Warner <warner@lothar.com>
926 * Makefile (release): produce both .tar.gz and .zip source bundles.
929 2007-01-23 Brian Warner <warner@lothar.com>
931 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
932 * buildbot/changes/monotone.py: same
934 * buildbot/changes/maildir.py: combine several files into one,
935 clean up maildir.py to use Services properly.
936 * buildbot/changes/maildirtwisted.py: remove
937 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
939 * buildbot/changes/mail.py: match the change
940 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
941 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
943 * buildbot/slave/commands.py (command_version): bump to "2.3" to
944 indicate that the buildslave knows about the 'bzr' command
946 2007-01-22 Brian Warner <warner@lothar.com>
948 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
949 'with', it will become a reserved work in python2.6 .
951 * contrib/bb_applet.py: add a simple gnome-panel applet, to
952 display a terse summary of buildbot status.
953 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
954 some icons, small versions of the Blender object that lives in
955 docs/images/icon.blend
957 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
958 * buildbot/slave/commands.py (Bzr): same
959 * buildbot/scripts/tryclient.py (BzrExtractor): same
960 (SourceStampExtractor.dovc): modify this to allow non-zero exit
961 status, since 'bzr diff' does that
962 * buildbot/test/test_vc.py (Bzr): same
963 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
967 2007-01-20 Brian Warner <warner@lothar.com>
969 * contrib/darcs_buildbot.py: tidy up the progress messages
971 2007-01-17 Brian Warner <warner@lothar.com>
973 * contrib/darcs_buildbot.py: enhance to handle multiple patches
974 being pushed at a time. This keeps state in the repository in a
975 small file named .darcs_buildbot-lastchange, but that shouldn't
976 interfere with normal repository operations. Fixes SF#1534049.
977 * buildbot/clients/sendchange.py (Sender): make a single Sender
978 capable of sending Changes with different usernames.
980 2006-12-11 Brian Warner <warner@lothar.com>
982 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
983 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
984 buildbot.changes.mail a long time ago, but I forgot to add the
985 DeprecationWarning until now.
987 * buildbot/process/maxq.py: remove this, the functionality now
988 lives in buildbot.steps.maxq
990 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
991 * buildbot/clients/gtkPanes.py: remove unused import
993 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
994 that was meant to provide a special Reporter to run inside trial
995 and give the buildslave lots of machine-readable status. We never
996 finished this project.
998 * buildbot/changes/bonsaipoller.py: remove unused imports
999 * buildbot/changes/svnpoller.py: same
1000 * buildbot/process/builder.py: same
1001 * buildbot/process/buildstep.py: same
1002 * buildbot/slave/bot.py: hush pyflakes warning
1003 * buildbot/status/tests.py: remove unused imports
1004 * buildbot/status/tinderbox.py: same
1005 * buildbot/steps/python_twisted.py: same
1007 * buildbot/process/step.py: remove this file, these names were
1008 deprecated in 0.7.5 and are now being removed.
1009 * buildbot/process/step_twisted.py: same
1010 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1012 * buildbot/twcompat.py: remove the empty file, yay it is gone
1014 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1015 tw-2.0.0 and newer have the method we need.
1016 (getProcessOutputAndValue): same
1017 (which): remove this method, tw-2.0.0 t.p.procutils has it
1019 * buildbot/twcompat.py (implements): remove this method
1020 * buildbot/*: import implements() from zope.interface directly
1022 * buildbot/status/mail.py: stop falling back to importing
1023 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1026 * buildbot/twcompat.py (Interface): remove this import
1027 * buildbot/*: import Interface from zope.interface directly
1029 * buildbot/twcompat.py (providedBy): remove this method
1030 * buildbot/*: turn all uses of providedBy(obj, iface) into
1031 iface.providedBy(obj)
1033 * buildbot/twcompat.py (maybeWait): remove this method, now that
1034 we no longer maintain compatibility with Twisted<=1.3.0 .
1035 Twisted-2.0.0 and later allow trial methods to return Deferreds
1037 * buildbot/test/*: remove all uses of maybeWait
1039 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1041 * docs/buildbot.texinfo: same
1043 2006-12-10 Brian Warner <warner@lothar.com>
1045 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1046 * docs/buildbot.texinfo: set version to match
1048 2006-12-10 Brian Warner <warner@lothar.com>
1050 * README (REQUIREMENTS): update for release
1051 * NEWS: update for release
1052 * buildbot/slave/commands.py (command_version): mention that this
1053 version (2.2) was released with buildbot-0.7.5
1055 * buildbot/test/test_config.py (StartService.testStartService):
1056 inhibit the usual read-config-on-startup behavior, since otherwise
1057 the log.err that gets recorded causes the test to fail
1059 * buildbot/status/builder.py (LogFile.finish): forget about all
1060 subscribers once the log has finished, since after that point
1061 we're never going to use them again. This might help free up some
1064 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1065 than the old/deprecated gtk.mainquit()
1067 2006-12-09 Brian Warner <warner@lothar.com>
1069 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1070 better when we can't open the masterdst file
1072 * buildbot/scripts/startup.py (Follower._failure): add missing
1073 import statement for BuildSlaveDetectedError
1075 * buildbot/steps/transfer.py (FileUpload): cleanup
1076 (FileDownload): same. Add tests for slave version, add mode=.
1077 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1078 (SlaveFileDownloadCommand): same
1079 * buildbot/test/test_transfer.py: enhance tests
1080 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1083 2006-12-08 Brian Warner <warner@lothar.com>
1085 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1086 both success *and* failure. Without this, the 'buildbot
1087 sendchange' command would hang if it could not contact the
1088 buildmaster or deliver the Change, which would generally cause the
1089 user's commit/record/checkin command to hang too. Thanks to
1090 Christian Unger for the catch.
1092 2006-12-06 Brian Warner <warner@lothar.com>
1094 * NEWS: update with items for the next release
1096 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1097 whimsical example pulled from a punch-drunk email I sent out late
1099 (Transferring Files): document some of the other parameters
1100 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1101 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1102 * buildbot/test/test_svnpoller.py: same
1103 * buildbot/changes/svnpoller.py (SVNPoller): same
1105 2006-11-26 Brian Warner <warner@lothar.com>
1107 * docs/buildbot.texinfo (Build Properties): remind users that
1108 WithProperties must appear in a command= list, not as a top-level
1110 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1111 we're sending a list or a single string to the RemoteShellCommand
1113 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1115 * buildbot/scripts/startup.py (start): skip the whole
1116 watch-the-logfile thing under windows, since it needs os.fork()
1118 * buildbot/scripts/runner.py (restart): remove the old message
1119 that got printed after the buildbot was restarted.. it most cases
1120 it didn't get printed at the right time anyways
1122 2006-11-25 Brian Warner <warner@lothar.com>
1124 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1125 follow twistd.log and print lines until the process has started
1126 started properly. For the buildmaster, this means until the config
1127 file has been parsed and accepted. For the buildslave, this means
1128 until we've connected to the master. We give up after 5 seconds in
1129 any case. Helpful error messages and troubleshooting suggestions
1130 are printed when we don't see a successful startup. This closes the
1131 remainder of SF#1517975.
1132 * buildbot/scripts/startup.py: moved app startup code to here
1133 * buildbot/scripts/logwatcher.py: utility class to follow log
1134 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1135 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1136 so the LogWatcher can tell the difference between a buildmaster
1139 2006-11-24 Brian Warner <warner@lothar.com>
1141 * docs/examples/twisted_master.cfg: update to match the version
1142 in use on twistedmatrix.com
1143 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1144 was using before stopped working, but 'irc.freenode.net' works
1147 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1150 * buildbot/clients/base.py (TextClient.not_connected): upon
1151 UnauthorizedLogin failures, remind the user to connect to the
1152 PBListener port instead of the slaveport.
1153 (TextClient.disconnected): shut down more quietly
1154 * docs/buildbot.texinfo (statuslog): add another reminder
1156 * buildbot/scripts/runner.py (Options.subCommands): rename
1157 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1158 'sighup' as an alias.
1159 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1160 reconfig command to follow twistd.log and print all of the lines
1161 from the start of the config-file reload to its completion. This
1162 should make it a lot easier to discover bugs in the config file.
1163 Use --quiet to disable this behavior. This addresses half of
1164 SF#1517975, the other half will be to add this same utility to
1165 'buildbot start' and 'buildbot restart'.
1166 * docs/buildbot.texinfo (Loading the Config File): same
1169 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1170 method, it has been deprecated for a long time. Use
1171 IBuilderControl.requestBuild instead.
1172 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1173 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1174 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1175 * buildbot/test/test_control.py (Force.testForce): same
1176 * buildbot/test/test_run.py: use requestBuild instead
1178 * buildbot/clients/debug.py: replace 'Force Build' button with
1179 'Request Build' (which just adds one to the queue), add Ping
1180 Builder, add branch/revision fields to Request Build.
1181 * buildbot/clients/debug.glade: same
1182 * buildbot/master.py: update interface to match. This creates an
1183 incompatibility between new debugclients and old buildmasters.
1185 * buildbot/process/builder.py (Builder._attached): delay the call
1186 to maybeStartBuild for a reactor turn, to avoid starting a build
1187 in the middle of a reconfig (say, if the new Builder uses a new
1188 slave which is already connected).
1190 2006-11-23 Brian Warner <warner@lothar.com>
1192 * buildbot/test/test_transfer.py: appease pyflakes
1193 * buildbot/test/test_steps.py: same
1195 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1196 keeps pyflakes from finding undefined names
1198 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1199 Builder no longer induces a disconnect/reconnect cycle. This means
1200 that any builds currently in progress will not be interrupted, and
1201 any builds which are queued in the Builder will not be lost. This
1202 is implemented by having the new Builder extract the state (i.e.
1203 all pending Builds and any desired SlaveBuilders) from the old
1205 (BotPerspective): refactor. The BotPerspective no longer keeps
1206 track of all the Builders that want to use this slave; instead, it
1207 asks the BotMaster each time it needs this list. This removes
1208 addBuilder and removeBuilder. Clean up attached() to acquire all
1209 the slave's information in a more atomic fashion. updateSlave() is
1210 now the way to make sure the slave is using the right set of
1211 Builders: just call it after everything else has been
1213 (BotMaster): refactor, removing addBuilder/removeBuilder and
1214 replacing them with an all-at-once setBuilders() call.
1216 * buildbot/test/test_slaves.py (Reconfig): new test case to
1217 exercise this functionality
1218 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1219 * buildbot/slave/commands.py (WaitCommand): same
1221 * docs/buildbot.texinfo (Loading the Config File): document the
1224 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1225 SlaveBuilder to have its parent Builder changed.
1226 (SlaveBuilder.isAvailable): new method to give access to state,
1227 which is now a private attribute
1228 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1229 the SlaveBuilder about how it is being used. These methods update
1230 its internal state. buildFinished() is now the place that invokes
1231 maybeStartBuild() on its parent Builder.
1232 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1233 new Builder to take over for an old one, transferring state from
1235 (Buider): refactor the way that SlaveBuilders are used to match,
1236 giving them a bit more autonomy.
1237 (Builder.buildFinished): this no longer calls maybeStartBuild():
1238 instead the SlaveBuilder calls it on whoever its parent Builder is
1239 at the time. This way, when an old Builder is replaced by a new
1240 one, and there was a build in progress during the transition, when
1241 that build finishes, it will be the new Builder that is told about
1242 the newly available slave so it can start a new build.
1244 * buildbot/process/base.py (Build.startBuild._release_slave): when
1245 the Build finishes, tell the SlaveBuilder that they've been
1248 * buildbot/status/builder.py (SlaveStatus): add some new setter
1249 methods for use by BotPerspective, to keep some attributes more
1252 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1253 called by the buildmaster.
1254 (Bot.setBuilderList): instead, we locally announce any leftover
1255 directories based upon which Builders we were told about. The
1256 master doesn't really care; it's the local admin who may or may not
1257 wish to delete them.
1260 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1261 to allow use of python2.4 or whatever. This tool still requires
1264 2006-11-19 Brian Warner <warner@lothar.com>
1266 * NEWS (IStatusLog.readlines): more news items
1268 2006-11-18 Brian Warner <warner@lothar.com>
1270 * NEWS: start collecting items for the next release.
1272 2006-11-04 Brian Warner <warner@lothar.com>
1274 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1275 Hearsum. Closes SF#1590310.
1276 * buildbot/test/test_bonsaipoller.py: and tests
1278 * buildbot/status/tinderbox.py
1279 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1280 status when the build results in WARNINGS. Patch from Dave
1281 Liebreich. Closes SF#1587352.
1283 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1284 linux-vs-osx behavior difference w.r.t. reading from files that
1285 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1286 to Mark Rowe for the patch.
1288 2006-10-15 Brian Warner <warner@lothar.com>
1290 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1291 method name was misspelled in the interface definition. Thanks to
1292 Roy Rapoport for the catch.
1294 2006-10-13 Brian Warner <warner@lothar.com>
1296 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1297 to match the great Steps renaming
1299 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1300 Maybe I should run my own unit tests before recording a big
1301 change. Good thing I've got a buildbot to remind me.
1303 2006-10-12 Brian Warner <warner@lothar.com>
1305 * buildbot/steps/transfer.py: rework __init__ and args setup
1306 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1308 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1309 when opening the target file, only catch IOError (to report via
1310 stderr/rc!=0), let the others be reported as normal exceptions
1312 2006-10-08 Brian Warner <warner@lothar.com>
1314 * contrib/svn_watcher.py: fix security holes by using proper argv
1315 arrays and subprocess.Popen() rather than commands.getoutput().
1316 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1317 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1318 probably be removed by the next release.
1321 2006-10-04 Brian Warner <warner@lothar.com>
1323 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1324 initial lines that weren't emitted by pyflakes. When the pyflakes
1325 command is run under a Makefile, 'make' will echo the command it
1326 runs to stdio, and that was getting logged as a "misc" warning.
1327 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1328 * buildbot/test/test_steps.py (testPyFlakes3): another test
1330 2006-10-01 Brian Warner <warner@lothar.com>
1332 * buildbot/status/html.py (HtmlResource.render): if we get a
1333 unicode object from our content() method, encode it into utf-8
1334 like we've been claiming to all along. This allows the comments
1335 and author names from svnpoller.py to be delivered properly.
1337 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1338 de-unicodify filenames before creating the Change, because the
1339 rest of buildbot is unlikely to handle them well. Leave the 'who'
1340 field as a unicode object.. I don't think there's anything that
1341 will break very soon, and it will probably nudge us towards
1342 accepting unicode everywhere sooner or later. Stop using the
1343 "date" field that comes out of SVN, since it is using the
1344 repository's clock (and timezone) and what we care about is the
1345 buildmaster's (otherwise Changes from the future show up later
1346 than the builds they triggered).
1347 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1350 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1351 Suvbersion repository polling ChangeSource. I've hacked it up
1352 considerably: any bugs are entirely my own fault. Thank you
1354 * buildbot/test/test_svnpoller.py: tests for it
1355 * docs/buildbot.texinfo (SvnSource): document it
1357 2006-09-30 Brian Warner <warner@lothar.com>
1359 * buildbot/scheduler.py (Periodic): submit a reason= to the
1360 BuildSet to indicate which Scheduler triggered the build. Thanks
1361 to Mateusz Loskot for the suggestion.
1363 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1365 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1366 changes: set self.loop in __init__, remove unused volatile=
1368 * docs/buildbot.texinfo (.buildbot config directory): add more
1369 docs on the .buildbot/options keys used by "buildbot try"
1370 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1371 (Try.deliverJob): same
1373 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1375 (BonsaiPoller): same
1377 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1378 close the filehandle when we stop watching the file. Before, the
1379 filehandle was only closed when the LogFileWatcher was
1380 garbage-collected, which could be quite a while in the future. If
1381 it was still open by the time the next build started, windows will
1382 refuse to let the new build delete the old build/ directory. Fixes
1383 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1384 #twisted for the catch.
1386 2006-09-29 Brian Warner <warner@lothar.com>
1388 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1391 2006-09-25 Brian Warner <warner@lothar.com>
1393 * setup.py: the new buildbot.steps module wasn't being installed.
1394 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1395 (testmsgs): add the extra stuff from buildbot/test/* so you can
1396 run unit tests on an installed copy of buildbot, not just from
1399 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1400 columns of 'svnlook changed' output contain status information, so
1401 strip [:4] instead of [:6]. Depending upon what the status flags
1402 were, this would sometimes lead to mangled filenames. Thanks to
1403 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1405 * buildbot/steps/source.py (Monotone): initial Monotone support,
1406 contributed by Nathaniel Smith. Still needs docs and tests, but
1407 this code has been in use on the Monotone buildbot for a long
1409 * buildbot/slave/commands.py (Monotone): slave-side support
1410 * buildbot/changes/monotone.py (MonotoneSource): polling change
1413 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1414 contributed a Change Source that polls a Bonsai server (a
1415 kind of web-based viewcvs CGI script).
1417 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1418 Hearsum contributed a status plugin which sends email in the same
1419 format that Tinderbox does: this allows a number of tinderbox
1420 tools to be driven by Buildbot instead. Thanks Ben!
1422 2006-09-24 Brian Warner <warner@lothar.com>
1424 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1425 Thanks to Robert Helmer for the patch.
1427 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1428 BuildStatus about the buildslave name at the *beginning* of the
1429 build, rather than at the end. Thanks to Alexander Lorenz for the
1431 * buildbot/status/html.py (StatusResourceBuild.body): always
1432 include the slavename in the build page, not just when the build
1434 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1435 slavename in the email message
1437 2006-09-21 Brian Warner <warner@lothar.com>
1439 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1441 * docs/examples/glib_master.cfg: same
1442 * docs/examples/hello.cfg: same
1443 * docs/examples/twisted_master.cfg: same, update to current usage
1445 2006-09-19 Brian Warner <warner@lothar.com>
1447 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1448 (PyFlakes.createSummary): make it compatible with python-2.2
1450 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1451 for at least the output-parsing parts of PyFlakes
1453 2006-09-18 Brian Warner <warner@lothar.com>
1455 * buildbot/steps/python.py: oops, fix import of StringIO
1457 2006-09-17 Brian Warner <warner@lothar.com>
1459 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1460 turns out that SVN-1.4.0 doesn't fail to update once you've
1461 replaced a file with a directory, unlike older versions of SVN and
1462 pretty much every other VC tool we support. Since what we really
1463 care about is that the update succeeds anyway, stop checking that
1464 the tree got clobbered and just assert that the build succeeded.
1465 (VCBase.printLogs): add a utility function for debugging
1467 * buildbot/process/step.py: oops, added extra imports by mistake
1469 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1470 rstrip() on the first line coming out of the 'p4 describe'
1471 process, to remove the stray ^M that Wade Brainerd reports seeing
1472 in the 'when' field. Fixes SF#1555985.
1474 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1475 message logged when c['schedulers'] is not right
1476 * buildbot/scheduler.py (Scheduler.__init__): improve error
1477 message when a Scheduler() is created with the wrong arguments
1478 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1479 verify that these error messages are emitted
1481 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1482 The idea is that all the base classes (like BuildStep and
1483 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1484 will be a leftover backwards-compatibility file that only contains
1485 aliases for the steps that were moved out to buildbot.steps.*
1486 * lots: change imports to match
1487 * buildbot/process/step.py: add a DeprecationWarning if it ever
1490 2006-09-12 Brian Warner <warner@lothar.com>
1492 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1493 builderNames= is actually a sequence, since if you happen to give
1494 it a single builder-specification dictionary instead, it won't get
1495 caught by the existing assert. Thanks to Brett Neely for the
1498 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1500 * docs/buildbot.texinfo (Python BuildSteps): document them
1501 (sendchange): include a link to PBChangeSource, since you need one
1503 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1505 * buildbot/steps/dummy.py: same
1507 2006-09-08 Brian Warner <warner@lothar.com>
1509 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1510 BuildStep which lets you transfer files from the master to the
1511 slave or vice versa. Thanks to Albert Hofkamp for the original
1512 patch. Fixes SF#1504631.
1513 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1515 (SlaveFileDownloadCommand): same
1516 * docs/buildbot.texinfo (Transferring Files): document it
1517 * buildbot/test/test_transfer.py: test it
1518 * buildbot/test/runutils.py (StepTester): new utility class for
1519 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1520 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1523 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1524 walk through StatusLogs one line at a time, mostly for the benefit
1525 of ShellCommand.createSummary methods. You can either walk through
1526 STDOUT or STDERR, but the default is STDOUT.
1528 * buildbot/status/builder.py (LogFile.readlines): implement it.
1529 Note that this is not yet memory-efficient, it just pulls the
1530 whole file into RAM and then splits it up with a StringIO.
1531 Eventually this should be a generator that only pulls chunks from
1533 * buildbot/test/test_status.py (Log.testReadlines): test it
1535 * docs/buildbot.texinfo: update to match changes
1536 * buildbot/process/factory.py: stop using old definitions
1537 * buildbot/process/process_twisted.py: same
1538 * buildbot/test/test_*.py: same
1540 * buildbot/process/step_twisted.py: move definition to..
1541 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1542 relative-import mechanisms prevent this from being named 'twisted'
1543 or 'python/twisted' as I would have preferred.
1545 * buildbot/process/maxq.py: move definition to..
1546 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1548 * buildbot/process/step.py: split the user-visible BuildSteps into
1549 separate files, all under buildbot/steps/
1550 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1551 * buildbot/steps/shell.py: this holds ShellCommand and friends
1552 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1554 2006-09-05 Brian Warner <warner@lothar.com>
1556 * lots: run pyflakes, removed a lot of unused imports, changed the
1557 form of some conditional imports to remove false pyflakes
1558 warnings. There are still a number of warnings left, mostly from
1559 imports that are done for their side-effects.
1560 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1563 2006-08-26 Brian Warner <warner@lothar.com>
1565 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1566 compatible with twisted-1.3.0, for some reason I just can't seem
1567 to let go of the past.
1569 2006-08-25 Brian Warner <warner@lothar.com>
1571 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1573 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1574 all logfiles= in startCommand(), rather than in start() . This
1575 makes it easier to have the 'stdio' log come before any secondary
1576 logfiles, which I feel makes the waterfall display more
1578 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1579 from ShellCommand up into LoggingBuildStep
1580 (LoggingBuildStep.__init__): move the handling of logfiles= from
1581 ShellCommand up to LoggingBuildStep, because startCommand is
1582 provided by LoggingBuildStep, whereas start() was specific to
1583 subclasses like ShellCommand and Source. This removes code
1584 duplication in those subclasses.
1585 (ShellCommand.__init__): same
1586 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1587 for a slave that's too old to understand logfiles= into a separate
1588 method, so it can live in ShellCommand. The rest of
1589 setupLogfiles() can live in LoggingBuildStep.
1591 2006-08-24 Brian Warner <warner@lothar.com>
1593 * buildbot/locks.py (BaseLock): you can now configure Locks to
1594 allow multiple simultaneous owners. They still default to
1595 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1597 * docs/buildbot.texinfo (Interlocks): document the new options
1598 * buildbot/test/test_locks.py: add a bunch of new unit tests
1599 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1600 waitUntilMaybeAvailable, not waitUntilAvailable
1601 * buildbot/process/step.py (BuildStep.acquireLocks): same
1602 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1603 the whole lockid in their constructor, not just the name. Also,
1604 keep track of which real locks we've handed out by the full
1605 lockid, not just class+name, otherwise changing just the maxCount=
1606 in the master.cfg file would not actually cause a behavioral
1609 2006-08-23 Brian Warner <warner@lothar.com>
1611 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1613 * docs/buildbot.texinfo: same
1615 2006-08-23 Brian Warner <warner@lothar.com>
1617 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1618 * docs/buildbot.texinfo: set version to match
1619 * NEWS: update for 0.7.4
1620 * buildbot/slave/commands.py (command_version): mention that this
1621 version (2.1) was released with buildbot-0.7.4
1623 2006-08-22 Brian Warner <warner@lothar.com>
1627 * CREDITS: new file, list of people who have helped. Thanks!
1628 * MANIFEST.in: ship it
1630 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1631 new diagrams, the user's manual is more informative than it was.
1632 Start shipping the .html user's manual (and generated .png
1634 * Makefile: update 'release' target to match
1636 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1637 test.. I think the web-parts effort will render it pointless well
1638 before it ever actually starts to work.
1640 2006-08-20 Brian Warner <warner@lothar.com>
1642 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1643 meaning of the prefix= argument. It is now just a string which is
1644 stripped from the beginning of the filename. If prefix= is set but
1645 not found on any given filename, that filename is ignored. If all
1646 filenames in a Change are ignored, the Change is dropped. This is
1647 much simpler than the previous sep= nonsense, and I should have
1648 implemented it this way from the beginning. Effectively resolves
1649 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1650 Gedminas for the catch and suggested fixes.
1651 (ChangePerspective.perspective_addChange): implement the actual
1653 * buildbot/test/test_changes.py (TestChangePerspective): test it
1654 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1655 how to properly use prefix=
1656 * docs/examples/twisted_master.cfg (source): update prefix= by
1657 adding the trailing slash
1660 * docs/examples/twisted_master.cfg: update to actual practice
1662 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1663 update test case to match new link text.. the HREF has both a
1664 class= setting and an enclosing [] pair that I didn't match in the
1667 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1668 list of strings is preferred over a single string with embedded
1670 (ShellCommand.description=): explain that either single strings or
1671 a list of strings is acceptable, and why you might prefer one over
1672 the other. Add an example. Fixes SF#1524659, thanks to Paul
1673 Winkler for the catch.
1674 (Build Steps): update to use f.addStep() rather than using s()
1675 and the constructor list
1677 * buildbot/process/step.py (ShellCommand): accept either a single
1678 string or a list of strings in both description= and
1680 * buildbot/test/test_steps.py (Steps.test_description): test it
1681 * buildbot/test/runutils.py (makeBuildStep): support for that test
1683 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1684 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1685 collecting the files and creating the patch.
1687 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1688 per-step URLs that will be displayed on the waterfall display,
1689 for things like the HTML output of code-coverage tools, when
1690 the results are hosted elsewhere.
1691 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1692 way to retrieve these URLs
1693 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1694 the method to retrieve these URLs. Also provide backwards
1695 compatibility for saved BuildStepStatus instances that didn't have
1697 * buildbot/process/step.py (BuildStep.addURL): method to set these
1698 URLs from within a BuildStep
1699 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1700 (StepBox.getBox): give these external links a distinct CSS class
1701 named "BuildStep external" so a .css file can display them
1704 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1706 * buildbot/test/test_steps.py (Steps): test that we can all the
1707 URLs. Also add a bunch of other tests on methods that can be
1708 called from within BuildSteps
1709 * buildbot/test/runutils.py (makeBuildStep): add utility function
1711 2006-08-13 Brian Warner <warner@lothar.com>
1713 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1715 2006-08-10 Brian Warner <warner@lothar.com>
1717 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1718 index, this one of things like c['sources'] and c['schedulers']
1719 (indices): it looks like my clever idea of putting the @fooindex
1720 commands in between the @node and the @subsection (to make the
1721 HREF anchor jump to slightly above the section title, which works
1722 much better in html) confused texinfo horribly, so I'm moving the
1723 index tags back to be just after the @subsection marker. I also
1724 added extra lines between the @node/@section paragraph and the
1725 index tags, since I think maybe texinfo wants to see these be
1726 separate paragraphs.
1728 * docs/Makefile (images): make sure images get built when
1729 rendering the manual
1730 * docs/images/Makefile: same
1732 * buildbot/scripts/runner.py: rename 'buildbot master' to
1733 'buildbot create-master', and 'buildbot slave' to 'buildbot
1735 * docs/buildbot.texinfo: same
1738 * docs/buildbot.texinfo: reimplement the "useful classes" index
1739 with actual texinfo indices. The .info rendering is a bit
1740 weird-looking but it works well, and the HTML rendering is quite
1741 nice. This also puts the index targets in the regular flow of the
1742 text, which is easier to maintain.
1744 2006-08-06 Brian Warner <warner@lothar.com>
1746 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1747 Kevin Turner to prefer the environ= argument be a list rather than
1748 a string. If it is a list, it will be joined with a platform-local
1749 os.pathsep delimiter, and then prepended to any existing
1750 $PYTHONPATH value. This works better in cross-platform (i.e.
1751 windows buildslaves) environments when you need to push multiple
1752 directories onto the front of the path.
1753 (SlaveShellCommand): documented the new magic
1754 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1755 in a user-visible form
1757 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1758 Turner to prefer lists over strings when creating/running VC
1759 commands during unit tests. This is clearly necessary to survive
1760 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1761 renamed the wq() function to qw() though, since that's how it's
1762 spelled in perl. Eventually I'd prefer all commands to be
1763 specified with lists.
1765 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1766 which are deleted (or not yet created) correctly. Also add
1767 failsafe code to not explode if the file-watching poller doesn't
1768 get started. Thanks to JP Calderone for the catch and the poller
1770 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1772 * buildbot/test/emitlogs.py: same
1774 * NEWS: summarize recent changes
1776 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1777 clause to avoid the "host key mismatch" warning
1779 * buildbot/process/step_twisted.py (Trial.start): if the
1780 buildslave is too old to understand logfiles=, fall back to
1781 running 'cat _trial_temp/test.log' like before.
1782 (Trial.commandComplete): same. this takes advantage of the
1783 LoggingBuildStep refactoring to stall commandComplete long enough
1784 to run a second RemoteShellCommand.
1786 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1787 refactor command-completion handling, to allow methods like
1788 commandComplete/createSummary/evaluateCommand to return Deferreds.
1789 (LoggingBuildStep._commandComplete): delete the refactored method
1790 (ShellCommand.setupLogfiles): if the buildslave is too old to
1791 understand logfiles=, put a warning message both into twistd.log
1792 and into the otherwise empty user-visible LogFiles.
1794 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1795 callers to provide the slave-side logfile name, rather than
1796 forcing it to come from the local name of the LogFile.
1797 (BuildStep.getSlaveName): new method
1799 * buildbot/process/base.py (Build.getSlaveName): new method, so
1800 steps can find out which buildslave they're running on
1802 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1803 to match the s/cvs_ver/command_version/ change
1805 2006-08-05 Brian Warner <warner@lothar.com>
1807 * buildbot/slave/commands.py (command_version): replace the CVS
1808 auto-updated cvs_ver keyword with a manually-updated variable,
1809 since CVS is no longer the master repository. Add a description of
1810 the remote API change starting in this version (2.1), specifically
1811 the fact that SlaveShellCommand now accepts 'initial_stdin',
1812 'keep_stdin_open', and 'logfiles'.
1814 2006-07-31 Brian Warner <warner@lothar.com>
1816 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1817 diagrams to describe how the whole system fits together. The
1818 images themselves are kept in SVG files, with ascii-art versions
1819 in corresponding .txt files. Texinfo knows how to interpolate the
1820 text version into .info files, reference the .png versions from
1821 .html files, and include .eps versions in the .ps format.
1822 * docs/images/Makefile: tools to create .png and .eps
1823 * docs/images/*.svg: created pictures with Inkscape.
1824 * .darcs-boring: ignore the generated .eps and .png files
1826 2006-07-24 Brian Warner <warner@lothar.com>
1828 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1829 Scheduler names, since they cause setServiceParent to explode
1831 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1833 2006-07-20 Brian Warner <warner@lothar.com>
1835 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1836 which runs the buildbot unit tests
1838 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1839 classes that are useful in master.cfg
1841 2006-07-15 Brian Warner <warner@lothar.com>
1843 * Makefile (some-apidocs): new target to build only some epydocs
1845 * setup.py: minor comment.. does the classifiers= argument prevent
1846 the setup.py script from working on python2.2/2.3?
1848 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1851 * buildbot/twcompat.py: fix minor typo in comments
1853 * buildbot/manhole.py: move all Manhole-related code out to this
1854 module. Implement SSH-based manholes (with TwistedConch), and move
1855 to conch's nifty line-editing syntax-coloring REPL shell instead
1856 of the boring non-editing monochromatic (and deprecated) old
1858 * buildbot/master.py: remove all Manhole-related code
1859 (BuildMaster.loadConfig._add): make sure the old manhole is
1860 removed before we add the new one
1861 * docs/buildbot.texinfo (Debug options): document new Manhole options
1863 * buildbot/twcompat.py (_which): fix some epydoc issues
1864 * buildbot/status/html.py (Waterfall.__init__): same
1866 2006-06-29 Brian Warner <warner@lothar.com>
1868 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1869 deprecation warnings under newer Twisteds (by using
1870 zope.interface.Interface instead of old twisted.python.components
1872 * buildbot/slave/interfaces.py: same
1874 2006-06-28 Brian Warner <warner@lothar.com>
1876 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1877 svn commands, so it will fail immediately instead of hanging while
1878 it waits for a username/password to be typed in.
1880 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1881 log message if the step was shut down
1883 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1884 obsolete reference to mktap.
1886 2006-06-20 Brian Warner <warner@lothar.com>
1888 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1889 test to include new 'logfiles' argument sent from master to slave
1891 2006-06-19 Brian Warner <warner@lothar.com>
1893 * buildbot/process/step_twisted.py (Trial): track Progress from
1894 _trial_temp/test.log too
1896 * buildbot/process/step.py (OutputProgressObserver): generalize
1897 the earlier StdioProgressObserver into an OutputProgressObserver
1898 that can track LogFiles other than stdio.
1899 (LoggingBuildStep.__init__): same
1901 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1902 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1903 will fail under windows because of os.sep issues. It might have
1904 worked before if 'cat' was doing cygwin path conversion.
1906 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1907 creation of LogFileWatchers
1908 (ShellCommand._startCommand): and record the files that were
1909 watched in the 'headers' section of the ShellCommand output
1911 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1912 need to actually pass it to the slave if you want it to work.
1913 (ShellCommand): document it a bit
1915 * buildbot/test/test_shell.py: new test to validate LogFiles
1916 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1918 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1919 before printing the last batch of lines, to test that the polling
1920 logic is working properly
1922 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1923 handling, making it possible to track multiple logs for a single
1924 RemoteCommand. The previous single logfile is now known as the
1926 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1927 (RemoteShellCommand.__init__): accept logfiles=
1928 (LoggingBuildStep.startCommand): stdio_log is now one of many
1929 (ShellCommand): added logfiles= argument, as well as a class-level
1930 .logfiles attribute, which will be merged together to figure out
1931 which logfiles should be tracked. The latter maybe be useful for
1932 subclasses of ShellCommand which know they will aways produce
1933 secondary logfiles in the same location.
1935 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1936 and closeStdin() methods, preparing to make it possible to write
1937 to a ShellCommand's stdin at any time, not just at startup. These
1938 writes are buffered if the child process hasn't started yet.
1939 (LogFileWatcher): new helper class to watch arbitrary logfiles
1940 while a ShellCommand runs. This class polls the file every two
1941 seconds, and sends back 10k chunks to the buildmaster.
1942 (ShellCommand): rename stdin= to initialStdin=, and add
1943 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1945 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1946 key of "log" and a value of (logname, data).
1947 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1948 'logfiles' to the master-visible args dictionary.
1949 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1952 * buildbot/test/test_vc.py (Patch.testPatch): same
1955 * buildbot/test/emit.py: write to a logfile in the current
1956 directory. We use this to figure out what was used as a basedir
1957 rather than looking to see which copy of emit.py gets run, so that
1958 we can run the commands from inside _trial_temp rather than inside
1960 * buildbot/test/subdir/emit.py: same
1961 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1962 argument rather than running from buildbot/test/
1963 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1964 rather than using an implicit setUp()
1965 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1966 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1967 of assuming that we're running in buildbot/test/ (and that '.' is
1970 * buildbot/slave/commands.py (Command.doStart): refactor Command
1971 startup/completion a bit: now the SlaveBuilder calls doStart(),
1972 which is not meant for overridding by subclasses, and doStart()
1973 calls start(), which is. Likewise the SlaveBuilder calls
1974 doInterrupt(), and subclasses override interrupt(). This also puts
1975 responsibility for maintaining .running in Command rather than in
1977 (Command.doInterrupt): same
1978 (Command.commandComplete): same, this is called when the deferred
1979 returned by start() completes.
1980 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1981 (SlaveBuilder.remote_interruptCommand): same
1982 (SlaveBuilder.stopCommand): same
1984 2006-06-16 Brian Warner <warner@lothar.com>
1986 * buildbot/test/test_shell.py: new test file to contain everything
1987 relating to ShellCommand
1988 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1989 multiple logfiles in realtime" feature, not yet implemented
1990 * buildbot/test/emitlogs.py: support file for testLogFiles
1991 * docs/buildbot.texinfo (ShellCommand): document the feature
1993 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1995 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1996 for tests which exercise SlaveCommands in isolation.
1998 * buildbot/test/test_slavecommand.py: Move some utilities like
1999 SignalMixin and FakeSlaveBuilder from here ..
2000 * buildbot/test/runutils.py: .. to here, so they can be used by
2001 other test classes too
2002 * buildbot/test/test_vc.py: more SignalMixin refactoring
2003 * buildbot/test/test_control.py: same
2004 * buildbot/test/test_run.py: and some rmtree refactoring
2006 2006-06-15 Brian Warner <warner@lothar.com>
2008 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2009 'testBranch' to match other VC tests and have the tests run in
2010 roughly increasing order of dependency
2012 * buildbot/test/test_steps.py (LogObserver): new test to verify
2013 LogObservers can be created at various times and still get
2014 connected up properly
2016 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2017 to create BuildStepStatus instances that actually work.
2019 * buildbot/process/step.py (LogObserver): add outReceived and
2020 errReceived base methods, to be overridden
2022 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2023 API to take a name instead of a step, reducing the coupling
2024 somewhat. This returns the BuildStepStatus object so it can be
2025 passed to the new Step, instead of jamming it directly into the
2027 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2029 * buildbot/process/base.py (Build.setupBuild): use both methods
2030 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2031 process a bit to match
2033 2006-06-14 Brian Warner <warner@lothar.com>
2035 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2036 docs on writing new LogObserver classes
2037 (Writing New Status Plugins): brief docs on how Status Plugins fit
2040 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2041 implement a LogObserver that counts how many unit tests have been
2043 (Trial.__init__): wire it in
2044 * buildbot/test/test_twisted.py (Counter): unit test for it
2046 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2047 to new cmd.logs['stdio'] scheme
2048 (Trial.commandComplete): same
2049 (BuildDebs.commandComplete): same
2051 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2052 LogFiles, instead of just a single one. The old single logfile is
2053 now called "stdio". LoggedRemoteCommand no longer creates a
2054 LogFile for you (the code to do that was broken anyway). If you
2055 don't create a "stdio" LogFile, then stdout/stderr will be
2057 (LogObserver): implement "LogObservers", which a BuildStep can add
2058 to parse the output of a command in real-time. The primary use is
2059 to provide more useful information to the Progress code, allowing
2060 better ETA estimates.
2061 (LogLineObserver): utility subclass which feeds complete lines to
2062 the parser instead of bytes.
2063 (BuildStep.progressMetrics): this is safer as a tuple
2064 (BuildStep.setProgress): utility method, meant to be called by
2066 (BuildStep.addLogObserver): new method, to be called at any time
2067 during the BuildStep (even before any LogFiles have been created),
2068 to attach (or schedule for eventual attachment) a LogObserver to a
2070 (StdioProgressObserver): new LogObserver which replaces the old
2071 "output" progress gatherer
2072 (LoggingBuildStep.__init__): same
2073 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2074 (LoggingBuildStep._commandComplete): must use logs['stdio']
2075 instead of the old single ".log" attribute.
2076 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2077 functionality, now subsumed into StdioProgressObserver
2078 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2079 log name changed from "output" to "stdio".
2082 * buildbot/interfaces.py (ILogFile): add the Interface used from
2083 the BuildStep towards the LogFile
2084 (ILogObserver): and the one provided by a LogObserver
2085 * buildbot/status/builder.py (LogFile): implement it
2087 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2088 HEADER constants here ..
2089 * buildbot/status/builder.py (STDOUT): .. from here
2091 2006-06-13 Brian Warner <warner@lothar.com>
2093 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2094 compatibility with python2.2, which doesn't have the 'substr in
2096 (TestP4Poller.makeTime): utility function to construct the
2097 timestamp using the same strptime() approach as p4poller does. It
2098 turns out that time.mktime() behaves slightly differently under
2099 python2.2, probably something to do with the DST flag, and that
2100 causes the test to fail under python2.2. (changing the mktime()
2101 arguments to have dst=0 instead of -1 caused it to fail under
2102 python2.3. Go figure.)
2103 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2105 2006-06-12 Brian Warner <warner@lothar.com>
2107 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2108 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2109 contributing such an excellent patch, including docs and unit
2110 tests! This makes it *so* much easier to apply. I had to update
2111 test_vc.py to handle some recent refactorings, but everything else
2112 applied smoothly. The only remaining thing I'd like to fix would
2113 be to remove the hard-wired port 1666 used by p4d, and allow it to
2114 claim any unused port. This would allow two copies of the test
2115 suite to run on the same host at the same time, as well as
2116 allowing the test suite to run while a real (production) p4d was
2117 running on the same host. Oh, and maybe we should add a warning to
2118 step.P4 that gets emitted if the slave is too old to provide the
2119 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2120 * buildbot/slave/commands.py (P4): same
2121 (P4Sync): same, some minor updates
2122 * buildbot/changes/p4poller.py: same
2123 * docs/buildbot.texinfo: same
2124 * buildbot/test/test_p4poller.py: same
2125 * buildbot/test/test_vc.py (P4): same
2127 * setup.py: add Trove classifiers for PyPI
2129 2006-06-08 Brian Warner <warner@allmydata.com>
2131 * buildbot/status/client.py
2132 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2133 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2134 build needs to be IRemote'd separately, rather than IRemote'ing
2135 the whole list at once. I can't wait until newpb's serialization
2136 adapters make this unnecessary.
2138 2006-06-06 Brian Warner <warner@lothar.com>
2140 * buildbot/process/step.py (WithProperties): make this inherit
2141 from ComparableMixin, so that reloading an unchanged config file
2142 doesn't cause us to spuriously reload any Builders which use them.
2143 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2146 2006-06-03 Brian Warner <warner@lothar.com>
2148 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2149 running py2exe on windows, contributed by Mark Hammond. Addresses
2150 SF#1401121, but I think we still need to include
2151 buildbot/scripts/sample.cfg
2152 * setup.py: include buildbot_service.py as a script under windows
2153 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2154 a py2exe application), get the icon/css datafiles from a different
2157 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2158 double-escape the build URL. Thanks to Olivier Bonnet for the
2159 patch. Fixes SF#1452801.
2161 2006-06-02 Brian Warner <warner@lothar.com>
2163 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2164 first six columns of 'svnlook' output, not just the first column,
2165 since property changes appear in the other five. Thanks to Olivier
2166 Bonnet for the patch. Fixes SF#1398174.
2168 2006-06-01 Brian Warner <warner@lothar.com>
2170 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2171 the fake build, so that title= has something to be set to
2173 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2174 attribute of the "Build #NN" link in the yellow start-the-build
2175 box to the build's reason. This means that you get a little
2176 tooltip explaining why the build was done when you hover over the
2177 yellow box. Thanks to Zandr Milewski for the suggestion.
2179 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2180 (Box.setETA): handle ETA=None (by stopping the timer)
2181 (Box.update): make the [soon] text less different than the usual
2182 text, so the rest of the text doesn't flop around so much. It
2183 would be awfully nice to figure out how to center this stuff.
2184 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2186 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2187 by default, so that any ShellCommand which fails marks the overall
2188 build as a failure. I should have done this from the beginning.
2189 Add flunkOnFailure=False to the arguments if you want to turn off
2192 2006-05-30 Brian Warner <warner@lothar.com>
2194 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2195 last-build/current-build/current-step. Show what step is currently
2196 running. Show ETA for both the overall build and the current step.
2197 Update GTK calls to modern non-deprecated forms. There's still a
2198 lot of dead code and debug noise to remove.
2200 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2201 shows up properly in status displays
2203 2006-05-28 Brian Warner <warner@lothar.com>
2205 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2206 build we use to verify that WithProperties works:
2208 ** set flunkOnFailure=True so that build failures get noticed
2209 ** set workdir='.' so that the build succeeds, otherwise it is trying
2210 to touch 'build/something', and 'build/' doesn't exist because
2211 usually that's created by a Source step
2212 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2213 this test somehow triggers, in which the 'touch' process becomes
2214 a zombie and we wait for th etimeout before giving up on it.
2216 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2217 to log the Build results and step logs to the twisted log.
2218 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2219 what went wrong if a build was expected to succeed but didn't.
2221 * buildbot/process/step_twisted.py (Trial): set the default
2222 trialMode to '--reporter=bwverbose', which specifies verbose
2223 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2224 '-to', but those are completely missing in modern Twisteds.
2226 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2227 a localhost-only port, to encourage better security
2229 * docs/buildbot.texinfo (Change Sources): mention
2232 * .darcs-boring: add a Darcs boringfile
2234 * README (REQUIREMENTS): stop claiming compatibility with
2237 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2240 2006-05-27 Brian Warner <warner@lothar.com>
2242 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2243 * docs/buildbot.texinfo: same
2245 2006-05-23 Brian Warner <warner@lothar.com>
2247 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2248 * docs/buildbot.texinfo: set version to match
2249 * NEWS: update for 0.7.3
2251 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2252 give a quick mapping from VC system to possible ChangeSources
2253 (Build Properties): add 'buildername'
2255 * buildbot/process/base.py (Build.setupStatus): oops, set
2256 'buildername' and 'buildnumber' properties
2257 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2260 2006-05-22 Brian Warner <warner@lothar.com>
2262 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2263 property interpolation better
2265 * README (INSTALLATION): remove old '-v' argument from recommended
2268 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2269 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2272 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2273 'svnversion' instead of grepping the output of 'svn info', much
2274 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2275 Bonnet for the suggestion.
2276 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2277 require the WC_PATH argument, so run 'svnversion .' instead.
2279 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2280 aren't supposed to have 'self' in their argument list
2282 2006-05-21 Brian Warner <warner@lothar.com>
2284 * buildbot/process/step.py (ShellCommand.start): make
2285 testInterpolate pass. I was passing the uninterpolated command to
2286 the RemoteShellCommand constructor
2287 (ShellCommand._interpolateProperties): oops, handle non-list
2288 commands (i.e. strings with multiple words separated by spaces in
2289 them) properly, instead of forgetting about them.
2291 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2292 to actually try to use build properties in a real build. This test
2294 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2295 to start and evaluate builds
2297 * buildbot/test/test__versions.py: add a pseudo-test to record
2298 what version of Twisted/Python/Buildbot are running. This should
2299 show up at the beginning of _trial_tmp/test.log, and exists to help
2300 debug other problems.
2302 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2303 a filename to be served as 'robots.txt' to discourage web spiders.
2304 Adapted from a patch by Tobi Vollebregt, thanks!
2305 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2306 (Waterfall.test_waterfall): tweak the way that filenames are put
2307 into the config file, to accomodate windows pathnames better.
2309 * docs/buildbot.texinfo (HTML Waterfall): document it
2311 * buildbot/process/process_twisted.py
2312 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2313 changed the build process. The new setup.py no longer takes the
2315 (FullTwistedBuildFactory.__init__): same
2316 (TwistedReactorsBuildFactory.__init__): same
2318 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2319 be placed in the [hooks] section of the central repository (the
2320 one that everybody pushes changes to).
2322 2006-05-20 Brian Warner <warner@lothar.com>
2324 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2325 .darcs-context file, use binary mode. I think this was causing a
2326 Darcs failure under windows.
2328 2006-05-19 Brian Warner <warner@lothar.com>
2330 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2331 use a timezone string of +0000 and gmtime, since this timestamp is
2332 sent to a buildmaster and %z is broken.
2334 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2335 string and localtime, since this timestamp will only be consumed
2336 locally, and %z is broken.
2338 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2339 gmtime, since this timestamp is returned to the buildmaster, and
2342 2006-05-18 Brian Warner <warner@lothar.com>
2344 * NEWS: update in preparation for next release
2346 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2347 setup-repository and do-we-have-the-vc-tools code into a separate
2348 "helper" class, which sticks around in a single module-level
2349 object. This seems more likely to continue to work in the future
2350 than having it hide in the TestCase and hope that TestCases stick
2351 around for a long time.
2353 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2354 addremove' has been deprecated in recent versions of mercurial, so
2355 use 'hg add' instead
2357 2006-05-07 Brian Warner <warner@lothar.com>
2359 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2360 operating under windows, move the file before opening it, since
2361 you can't rename a file that somebody has open.
2363 * buildbot/process/base.py (Build.setupBuild): if something goes
2364 wrong while creating a Step, log the name and arguments, since the
2365 error message when you get the number of arguments wrong is really
2368 2006-05-06 Brian Warner <warner@lothar.com>
2370 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2371 bugs in twisted-specific code not covered by my unit tests, this
2372 time use 'cmd' argument instead of self.cmd
2374 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2375 fix stupid braino: either use startwith or find()==0, not both.
2376 (TwistedReactorsBuildFactory.__init__): another dumb typo
2378 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2379 mark this test as TODO under windows, since process-killing seems
2380 dodgy there. We'll come back to this later and try to fix it
2383 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2384 and don't include a timezone
2385 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2386 This should avoid the windows-with-verbose-timezone-name problem
2388 (Patch.testPatch): add a test which runs 'patch' with less
2389 overhead than the full VCBase.do_patch sequence, to try to isolate
2390 a windows test failure. This one uses slave.commands.ShellCommand
2391 and 'patch', but none of the VC code.
2393 * buildbot/slave/commands.py (getCommand): use which() to find the
2394 executables for 'cvs', 'svn', etc. This ought to help under
2397 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2398 working directory before starting. If an earlier test failed, the
2399 leftover directory would mistakenly flunk a later test.
2400 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2401 Make sure that we use the right commandlines if which("tla") picks
2402 up "tla.exe" (as it does under windows).
2403 (TlaSupport.do_get): factor out this tla-vs-baz difference
2404 (TlaSupport.vc_create): more tla-vs-baz differences
2406 * buildbot/test/test_slavecommand.py
2407 (ShellBase.testShellMissingCommand): stop trying to assert
2408 anything about the error message: different shells on different
2409 OSes with different languages makes it hard, and it really isn't
2410 that interesting of a thing to test anyway.
2412 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2413 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2414 "Panther"), because it has a bug which flunks a couple tests in
2415 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2416 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2417 able to test that yet.
2419 2006-04-30 Brian Warner <warner@lothar.com>
2421 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2422 make sure child commands emit messages in english, so our regexps
2423 will match. Thanks to Nikaus Giger for identifying the problems.
2424 (VCBase._do_vctest_export_1): mode="export" is not responsible
2425 for setting the "got_revision" property, since in many cases it is
2426 not convenient to determine.
2427 (SVNSupport.capable): when running 'svn --version' to check for
2428 ra_local, we want error messages in english
2429 * buildbot/test/test_slavecommand.py
2430 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2431 to emit the error message in english
2433 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2434 the environment with $LC_ALL="C" so that Commands which need to
2435 parse the output of their child processes can obtain it in
2437 (SVN.parseGotRevision): call "svn info" afterwards instead of
2438 watching the output of the "svn update" or "svn checkout".
2439 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2440 (Arch.parseGotRevision): same
2441 (Bazaar.parseGotRevision): same
2442 (Mercurial.parseGotRevision): same
2444 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2445 $LC_ALL="C" when running commands under 'buildbot try', too
2447 * buildbot/test/__init__.py: remove the global os.environ()
2448 setting, instead we do it just for the tests that run commands and
2449 need to parse their output.
2451 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2452 remove the overly-short .timeout on this test, because non-DNotify
2453 platforms must fall back to polling which happens at 10 second
2454 intervals, so a 5 second timeout would never succeed.
2456 2006-04-24 Brian Warner <warner@lothar.com>
2458 * docs/buildbot.texinfo (Installing the code): update trial
2459 invocation, SF#1469116 by Niklaus Giger.
2460 (Attributes of Changes): updated branch-name examples to be
2461 a bit more realistic, SF#1475240 by Stephen Davis.
2463 * contrib/windows/buildbot2.bat: utility wrapper for windows
2464 developers, contributed by Nick Trout (after a year of neglect..
2465 sorry!). SF#1194231.
2467 * buildbot/test/test_vc.py (*.capable): store the actual VC
2468 binary's pathname in VCS[vcname], so it can be retrieved later
2469 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2470 strip out non-numeric timezone information, specifically the funky
2471 German string that his system produced that confuses CVS.
2472 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2473 allow Darcs tests to work on windows
2474 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2475 procutils.which() everywhere, to allow tryclient to work under
2476 windows. Also from Niklaus Giger, SF#1463394.
2478 * buildbot/twcompat.py (which): move the replacement for a missing
2479 twisted.python.procutils.which from test_vc.py to here, so it can
2480 be used in other places too (specifically tryclient.py)
2482 2006-04-23 Brian Warner <warner@lothar.com>
2484 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2485 bare buildbotURL/projectName line with a proper DIV, along with a
2486 CSS class of "title", from Stefan Seefeld (SF#1461675).
2487 (WaterfallStatusResource.body0): remove the redundant 'table'
2488 class from the table
2489 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2490 to the top-row TR, and class="Activity" to the second-row TR,
2491 rather than putting them in the individual TD nodes.
2493 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2494 'got_revision' build property for all VC systems that implement
2495 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2497 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2498 to determine which revision we actually obtained
2499 (CVS.parseGotRevision): implement this for CVS, which just means
2500 to grab a timestamp. Not ideal, and it depends upon the buildslave
2501 having a clock that is reasonably well syncronized with the server,
2502 but it's better than nothing.
2503 (SVN.parseGotRevision): implement it for SVN, which is accurate
2504 (Darcs.parseGotRevision): same
2505 (Arch.parseGotRevision): same
2506 (Bazaar.parseGotRevision): same
2507 (Mercurial.parseGotRevision): same
2509 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2510 keep a record of all non-stdout/stderr/header/rc status updates,
2511 for the benefit of RemoteCommands that send other useful things,
2513 (Source.commandComplete): put any 'got_revision' status values
2514 into a build property of the same name
2517 * buildbot/process/step_twisted.py (Trial): update to deal with
2518 new ShellCommand refactoring
2520 * docs/buildbot.texinfo (Build Properties): document new feature
2521 that allows BuildSteps to get/set Build-wide properties like which
2522 revision was requested and/or checked out.
2524 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2525 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2526 it. Note that this bumps the persistenceVersion of the saved Build
2527 object, so add the necessary upgrade-old-version logic to include
2528 an empty properties dict.
2530 * buildbot/process/base.py (Build.setProperty): implement it
2531 (Build.getProperty): same
2532 (Build.startBuild): change build startup to set 'branch',
2533 'revision', and 'slavename' properties at the right time
2535 * buildbot/process/step.py (BuildStep.__init__): change setup to
2536 require 'build' argument in a better way
2537 (LoggingBuildStep): split ShellCommand into two pieces, for better
2538 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2539 a single RemoteCommand that sends stdout/stderr status text. It
2540 also provides the usual commandComplete / createSummary /
2541 evaluateCommand / getText methods to be overridden...
2542 (ShellCommand): .. whereas ShellCommand is specifically for
2543 running RemoteShellCommands. Other shell-like BuildSteps (like
2544 Source) can inherit from LoggingBuildStep instead of ShellCommand
2545 (WithProperties): marker class to do build-property interpolation
2546 (Source): inherit from LoggingBuildStep instead of ShellCommand
2549 * buildbot/test/test_properties.py: test new functionality
2551 2006-04-21 Brian Warner <warner@lothar.com>
2553 * buildbot/test/test_vc.py: rename testBranch to
2554 testCheckoutBranch to keep the tests in about the right
2557 2006-04-18 Brian Warner <warner@lothar.com>
2559 * docs/buildbot.texinfo (PBListener): improve cross-references
2560 between PBListener and 'buildbot statusgui', thanks to John Pye
2563 2006-04-17 Brian Warner <warner@lothar.com>
2565 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2566 running under Twisted-1.3.0, otherwise skipped tests are reported
2569 * all: use isinstance() instead of 'type(x) is foo', suggested by
2572 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2573 oops, fix a brain-fade from the other week, when making the
2574 addStep changes. I changed all the __init__ upcalls to use the
2575 wrong superclass name.
2576 (FullTwistedBuildFactory.__init__): same
2577 (TwistedDebsBuildFactory.__init__): same
2578 (TwistedReactorsBuildFactory.__init__): same
2579 (TwistedBuild.isFileImportant): use .startswith for clarity,
2580 thanks to Neal Norwitz for the suggestions.
2582 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2583 changes, then deliver them over PB to a remote buildmaster.
2585 * contrib/svnpoller.py: added script by John Pye to poll a remote
2586 SVN repository (by running 'svn log') from a cronjob, and run
2587 'buildbot sendchange' to deliver the changes to a remote
2589 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2590 modification of svnpoller.py), same purpose, but this one loops
2591 internally (rather than expecting to run from a cronjob) and works
2593 * contrib/README.txt: same
2595 2006-04-11 Brian Warner <warner@lothar.com>
2597 * all: fix a number of incorrect names and missing imports, thanks
2598 to Anthony Baxter for the patch.
2599 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2600 remove unused buggy method.
2601 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2602 comes from shutil, not "shutils"
2603 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2604 (Arch.checkSlaveVersion): same
2605 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2607 * buildbot/process/step_twisted2.py: add some missing imports
2608 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2609 this code used to live in twisted.internet.defer
2611 2006-04-10 Brian Warner <warner@lothar.com>
2613 * buildbot/process/step.py (Mercurial): add Mercurial support
2614 * buildbot/slave/commands.py (Mercurial): same
2615 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2616 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2617 not yet tested, but 'try' support *is* covered
2618 * docs/buildbot.texinfo (Mercurial): document it
2620 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2621 some debugging messages (turned off)
2622 * buildbot/test/test_vc.py: improve debug messages
2624 2006-04-07 Brian Warner <warner@lothar.com>
2626 * buildbot/test/test_vc.py (which): define our own which() in case
2627 we can't import twisted.python.procutils, because procutils doesn't
2628 exist in Twisted-1.3
2630 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2631 of SlaveLocks for performance tests
2633 * docs/examples/twisted_master.cfg: update to match current usage
2635 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2636 password, p4 binary, pollinterval, maximum history to check.
2637 Patch from an anonymous sf.net contributor, SF#1219384.
2638 * buildbot/process/step.py (P4Sync.__init__): add username,
2639 password, and client arguments.
2640 * buildbot/slave/commands.py (P4Sync): same
2642 2006-04-05 Brian Warner <warner@lothar.com>
2644 * buildbot/process/factory.py (BuildFactory.addStep): new method
2645 to add steps to a BuildFactory. Use it instead of f.steps.append,
2646 and you can probably avoid using the s() convenience function.
2647 Patch from Neal Norwitz, sf.net #1412605.
2648 (other): update all factories to use addStep
2649 * buildbot/process/process_twisted.py: update all factories to use
2652 2006-04-03 Brian Warner <warner@lothar.com>
2654 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2655 work under windows too. Adapted from a patch by Niklaus Giger,
2656 addresses SF#1463399.
2658 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2659 spawned commands emit parseable results in english and not some
2660 other language. Patch from Niklaus Giger, SF#1463395.
2662 * README (INSTALLATION): discourage users from running unit tests on
2663 a "network drive", patch from Niklaus Giger, SF#1463394.
2665 2006-03-22 Brian Warner <warner@lothar.com>
2667 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2668 function to turn a repository-relative pathname into a (branch,
2669 branch-relative-filename) tuple. Change this function to handle
2670 the branch naming policy used by your Subversion repository.
2671 Thanks to AllMyData.com for sponsoring this work.
2673 2006-03-16 Brian Warner <warner@lothar.com>
2675 * buildbot/scripts/sample.cfg: add python-mode declaration for
2676 vim. Thanks to John Pye for the patch.
2678 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2679 command line, mention the importance of running 'crontab' as the
2680 buildmaster/buildslave user. Thanks to John Pye for the catch.
2682 2006-03-13 Brian Warner <warner@lothar.com>
2684 * buildbot/status/words.py (IRC): add an optional password=
2685 argument, which will be sent to Nickserv in an IDENTIFY message at
2686 login, to claim the nickname. freenode requires this before the
2687 bot can sent (or reply to) private messages. Thanks to Clement
2688 Stenac for the patch.
2689 * docs/buildbot.texinfo (IRC Bot): document it
2691 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2692 larger than chunkSize. Fixes SF#1349253.
2693 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2694 (Log.testConsumer): update to match new internal chunking behavior
2696 2006-03-12 Brian Warner <warner@lothar.com>
2698 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2700 * buildbot/test/test_maildir.py (MaildirTest): rename the
2701 'timeout' method, as it collides with trial's internals
2703 * buildbot/scripts/runner.py: add 'buildbot restart' command
2704 (stop): don't sys.exit() out of here, otherwise restart can't work
2705 * docs/buildbot.texinfo (Shutdown): document it
2707 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2708 * buildbot/status/html.py (Waterfall.__init__): same
2709 * buildbot/process/builder.py (Builder.startBuild): same
2710 * buildbot/process/base.py (BuildRequest): same
2711 * buildbot/sourcestamp.py (SourceStamp): same
2712 * buildbot/scheduler.py (Nightly): same
2714 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2716 * docs/buildbot.texinfo: same
2718 2006-02-17 Brian Warner <warner@lothar.com>
2720 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2721 * docs/buildbot.texinfo: set version number to match
2722 * NEWS: update for 0.7.2
2724 2006-02-16 Brian Warner <warner@lothar.com>
2726 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2728 2006-02-09 Brian Warner <warner@lothar.com>
2730 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2731 add text to explain per-build branch parameters
2732 * NEWS: mention --umask
2734 2006-02-08 Brian Warner <warner@lothar.com>
2736 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2738 (SlaveOptions.optParameters): add --umask, to make it possible to
2739 make buildslave-generated files (including build products) be
2742 * buildbot/slave/bot.py (BuildSlave.startService): same
2744 2006-01-23 Brian Warner <warner@lothar.com>
2746 * buildbot/status/builder.py: urllib.quote() all URLs that include
2747 Builder names, so that builders can include characters like '/'
2748 and ' ' without completely breaking the resulting HTML. Thanks to
2749 Kevin Turner for the patch.
2750 * buildbot/status/html.py: same
2751 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2753 * NEWS: update in preparation for upcoming release
2755 2006-01-18 Brian Warner <warner@lothar.com>
2757 * docs/examples/twisted_master.cfg: update to match the Twisted
2758 buildbot: remove python2.2, switch to exarkun's buildslaves,
2759 disable the .deb builder until we figure out how to build twisted
2760 .debs from SVN, add some ktrace debugging to the OS-X build
2761 process and remove the qt build, remove threadless builders,
2762 change freebsd builder to use landonf's buildslave.
2764 2006-01-12 Brian Warner <warner@lothar.com>
2766 * buildbot/master.py (Manhole.__init__): let port= be a strports
2767 specification string, but handle a regular int for backwards
2768 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2769 used in master.cfg to limit connections to just the local host.
2770 (BuildMaster.loadConfig): same for c['slavePortnum']
2771 * buildbot/scheduler.py (Try_Userpass.__init__): same
2772 * buildbot/status/client.py (PBListener.__init__): same
2773 * buildbot/status/html.py (Waterfall.__init__): same, for both
2774 http_port and distrib_port. Include backwards-compatibility checks
2775 so distrib_port can be a filename string and still mean unix:/foo
2776 * docs/buildbot.texinfo (Setting the slaveport): document it
2777 (Debug options): same
2778 (HTML Waterfall): same
2781 * buildbot/test/test_config.py (ConfigTest): test it
2783 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2784 slaveport's disownServiceParent deferred to fire before opening
2785 the new one. Fixes an annoying bug in the unit tests.
2787 2006-01-03 Brian Warner <warner@lothar.com>
2789 * buildbot/master.py (BuildMaster): remove the .schedulers
2790 attribute, replacing it with an allSchedulers() method that looks
2791 for all IService children that implement IScheduler. Having only
2792 one parent/child relationship means fewer opportunities for bugs.
2793 (BuildMaster.allSchedulers): new method
2794 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2795 also fix ugly bug that caused any config-file reload to
2796 half-forget about the earlier Schedulers, causing an exception
2797 when a Change arrived and was handed to a half-connected
2798 Scheduler. The exception was in scheduler.py line 54ish:
2799 self.parent.submitBuildSet(bs)
2800 exceptions.AttributeError: 'NoneType' object has no attribute
2802 (BuildMaster.addChange): update to use allSchedulers()
2804 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2805 to work properly with twisted-1.3.0, where you must explicitly
2806 include the __implements__ from parent classes
2807 (BaseScheduler.__repr__): make it easier to distinguish distinct
2809 (BaseUpstreamScheduler.__implements__): same
2811 * buildbot/status/builder.py (Status.getSchedulers): update to
2813 * buildbot/test/test_run.py (Run.testMaster): same
2814 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2815 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2816 make sure Scheduler instances are left alone when an identical
2817 config file is reloaded
2818 (ConfigElements.testSchedulers): make sure Schedulers are properly
2821 * Makefile (TRIALARGS): my local default Twisted version is now
2822 2.1.0, update the trial arguments accordingly
2824 2005-12-22 Brian Warner <warner@lothar.com>
2826 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2829 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2830 addChange in the parent class, although I suspect this should be
2831 fixed better in the future.
2833 2005-11-26 Brian Warner <warner@lothar.com>
2835 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2836 explode when branch==None, thanks to Kevin Turner for the catch
2837 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2840 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2842 * docs/buildbot.texinfo: same
2844 2005-11-26 Brian Warner <warner@lothar.com>
2846 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2847 * docs/buildbot.texinfo: set version number to match
2849 2005-11-26 Brian Warner <warner@lothar.com>
2851 * NEWS: update for 0.7.1
2853 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2854 sure that unsubscribe works even if we never sent an ETA update.
2855 Also, don't explode on duplicate unsubscribe.
2856 (BuildStepStatus.addLog): make the convenience "return self"-added
2857 watcher automatically unsubscribe when the Step finishes.
2858 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2859 (BuildStatus.stepStarted): same auto-unsubscribe
2860 (BuilderStatus.buildStarted): same auto-unsubscribe
2862 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2864 (IStatusReceiver.stepStarted): same
2865 (IStatusReceiver.logStarted): same
2867 * buildbot/test/test_run.py (Status): move the Status test..
2868 * buildbot/test/test_status.py (Subscription): .. to here
2870 2005-11-25 Brian Warner <warner@lothar.com>
2872 * NEWS: more updates
2874 * buildbot/locks.py: fix the problem in which loading a master.cfg
2875 file that changes some Builders (but not all of them) can result
2876 in having multiple copies of the same Lock. Now, the real Locks
2877 are kept in a table inside the BotMaster, and the Builders/Steps
2878 use "LockIDs", which are still instances of MasterLock and
2879 SlaveLock. The real Locks are instances of the new RealMasterLock
2880 and RealSlaveLock classes.
2881 * buildbot/master.py (BotMaster.getLockByID): new method to
2882 convert LockIDs into real Locks.
2883 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2884 into real Locks before building
2885 * buildbot/process/step.py (BuildStep.startStep): same
2886 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2887 exercises the problem
2890 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2891 what Schedulers are available
2893 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2894 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2895 'cron'-style build scheduling at certain times of day, week,
2897 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2899 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2900 handling: treat self.fileIsImportant more as an attribute that
2901 contains a callable than as a method. If the attribute is None,
2902 don't call it and assume all filenames are important. It is still
2903 possible to provide a fileIsImportant method in a subclass,
2905 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2907 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2908 test using AnyBranchScheduler with fileIsImportant=None
2910 2005-11-24 Brian Warner <warner@lothar.com>
2912 * buildbot/test/test_config.py (StartService): don't claim a fixed
2913 port number, instead set slavePort=0 on the first pass, figure out
2914 what port was allocated, then switch to a config file that uses
2917 * buildbot/master.py (BuildMaster.loadConfig): close the old
2918 slaveport before opening the new one, because unit tests might
2919 replace slavePort=0 with the same allocated portnumber, and if we
2920 don't wait for the old port to close first, we get a "port already
2921 in use" error. There is a tiny race condition here, but the only
2922 threat is from other programs that bind (statically) to the same
2923 port number we happened to be allocated, and only if those
2924 programs use SO_REUSEADDR, and only if they get control in between
2927 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2929 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2930 deleted ChangeSources before adding any new ones
2931 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2932 compare_attrs, to make sure that a config-file reload does not
2933 unnecessarily replace an unmodified ChangeSource instance
2934 * buildbot/test/test_config.py (ConfigTest.testSources): update
2936 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2937 mean "don't build anything", and add a warning if it gets used
2938 because it isn't actually useful.
2940 * contrib/svn_buildbot.py: update example usage to match the port
2941 number that gets used by the PBChangeSource
2942 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2944 2005-11-22 Brian Warner <warner@lothar.com>
2946 * NEWS: start collecting items for next release
2948 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2949 revisions are strings
2950 (P4Sync.computeSourceRevision): same
2952 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2953 to the Buildbot's overall status page
2954 (StatusResourceBuilder.body): same
2956 2005-11-15 Brian Warner <warner@lothar.com>
2958 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2959 config-file loading, specifically to make sure old StatusTargets
2960 are finished shutting down before new ones start up (thus
2961 resolving a bug in which changing the Waterfall object would fail
2962 because both new and old instances were claiming the same
2963 listening port). Also load new Schedulers after all the new
2964 Builders are set up, in case they fire off a new build right away.
2965 * buildbot/test/test_config.py (StartService): test it
2967 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2968 the branch name to the mail body
2970 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2971 Without it, a config-file reload fails to update an existing
2973 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2974 username/passwd to compare_attrs, for the same reason
2975 * buildbot/status/html.py (Waterfall): add favicon to
2976 compare_attrs, same reason
2978 2005-11-05 Brian Warner <warner@lothar.com>
2980 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2981 baserev before stuffing it in the jobfile. This resolves problems
2982 under SVN (and probably Arch) where revisions are expressed as
2983 numbers. I'm inclined to use string-based revisions everywhere in
2984 the future, but this fix should be safe for now. Thanks to Steven
2985 Walter for the patch.
2987 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2988 binary mode when opening pickle files, to make windows work
2989 better. Thanks to Dobes Vandermeer for the catch.
2990 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2991 (BuilderStatus.getBuildByNumber): same
2992 (Status.builderAdded): same
2993 * buildbot/master.py (BuildMaster.loadChanges): same
2995 * buildbot/util.py (Swappable): delete unused leftover code
2997 * buildbot/process/step.py (SVN): when building on a non-default
2998 branch, add the word "[branch]" to the VC step's description, so
2999 it is obvious that we're not building the usual stuff. Likewise,
3000 when we are building a specific revision, add the text "rNNN" to
3001 indicate what that revision number is. Thanks to Brad Hards and
3002 Nathaniel Smith for the suggestion.
3003 (Darcs.startVC): same
3004 (Arch.startVC): same
3005 (Bazaar.startVC): same
3007 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3008 typo, caught by Mark Dillavou, closes SF#1216636.
3010 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3011 about a test to add some day
3013 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3014 the 'full-2.3' build, and the 'reactors' build is now run under
3015 python-2.4 because the buildslave no longer has gtk/etc bindings
3016 for earlier versions.
3018 2005-11-03 Brian Warner <warner@lothar.com>
3020 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3021 method, takes an IBuildStatus and rebuilds it. It might make more
3022 sense to add this to IBuildControl instead, but that instance goes
3023 away completely once the build has finished, and resubmitting
3024 builds can take place weeks later.
3025 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3026 * buildbot/status/html.py (StatusResourceBuild): also stash an
3027 IBuilderControl so we can use resubmitBuild.
3028 (StatusResourceBuild.body): render "resubmit" button if we can.
3029 Also add hrefs for each BuildStep
3030 (StatusResourceBuild.rebuild): add action for "resubmit" button
3031 (StatusResourceBuilder.getChild): give it an IBuilderControl
3033 * buildbot/status/builder.py (Status.getURLForThing): change the
3034 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3035 that live as targets of buttons like "stop" and "rebuild" can't
3037 * buildbot/status/builder.py (Status.getURLForThing): same
3038 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3039 (StepBox.getBox): same
3040 * buildbot/test/test_web.py (GetURL): same
3043 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3044 exclusivity checks after Source.__init__ upcall, so misspelled
3045 arguments will be reported more usefully
3046 (Darcs.__init__): same
3048 2005-10-29 Brian Warner <warner@lothar.com>
3050 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3051 builder. Move the Try scheduler off to a separate port.
3053 2005-10-27 Brian Warner <warner@lothar.com>
3055 * buildbot/clients/gtkPanes.py
3056 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3057 to cause the app to crash, now they don't.
3059 * buildbot/clients/debug.py: display the buildmaster's location
3060 in the window's title bar
3062 2005-10-26 Brian Warner <warner@lothar.com>
3064 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3065 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3066 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3068 * buildbot/status/html.py (td): put a single non-breaking space
3069 inside otherwise empty <td> elements, as a workaround for buggy
3070 browsers which would optimize them away (along with any associated
3071 styles, like the kind that create the waterfall grid borders).
3072 Patch from Frerich Raabe.
3074 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3075 argv-list as an argument, defaulting to ["-to"], which is
3076 appropriate for the Trial that comes with Twisted-2.1.0 and
3077 earlier. The Trial in current Twisted SVN wants
3078 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3079 defaults to an empty list.
3080 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3081 match it, now that trialMode= is a list instead of a single string
3083 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3085 * docs/buildbot.texinfo: same
3087 2005-10-24 Brian Warner <warner@lothar.com>
3089 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3090 * docs/buildbot.texinfo: set version number to match
3092 2005-10-24 Brian Warner <warner@lothar.com>
3094 * README: update for 0.7.0
3096 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3098 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3099 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3100 send the branch= argument unless the user really provided one, to
3101 retain compatibility with older buildmasters that don't accept
3103 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3106 * docs/buildbot.texinfo: update lots of stuff
3108 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3109 to the 'buildbot sendchange' command
3110 * buildbot/clients/sendchange.py (Sender.send): same
3111 * buildbot/changes/pb.py (ChangePerspective): same
3112 * buildbot/test/test_changes.py (Sender.testSender): test it
3114 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3115 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3116 for consistency with other BuildStep arguments that use camelCase.
3117 Well, at least more of them use camelCase (like flunkOnWarnings)
3118 than don't.. I wish I'd picked one style and stuck with it
3119 earlier. Annoying, but it's best done before the release, since
3120 these arguments didn't exist at all in 0.6.6 .
3122 * buildbot/test/test_vc.py (SVN.testCheckout): same
3123 (Darcs.testPatch): same
3124 * docs/buildbot.texinfo (SVN): document the change
3125 (Darcs): same, add some build-on-branch docs
3126 * docs/examples/twisted_master.cfg: match change
3128 * buildbot/process/step.py (BuildStep): rename
3129 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3130 how it is normally used.
3131 * buildbot/test/test_steps.py (Version.checkCompare): same
3133 * buildbot/process/step.py (CVS.startVC): refuse to build
3134 update/copy -style builds on a non-default branch with an old
3135 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3136 concern is that it will do a VC 'update' in an existing tree when
3137 it is supposed to be switching branches (and therefore clobbering
3138 the tree to do a full checkout), thus building the wrong source.
3139 This used to be a warning, but I think the confusion it is likely
3140 to cause warrants making it an error.
3141 (SVN.startVC): same, also make mode=export on old slaves an error
3142 (Darcs.startVC): same
3143 (Git.startVC): improve error message for non-Git-enabled slaves
3144 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3145 specific revision is built on a slave that doesn't pay attention
3146 to args['revision'], because for slowly-changing trees it will
3147 probably do the right thing, and because we have no way to tell
3148 whether we're asking it to build the most recent version or not.
3149 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3151 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3152 that 'master' is in host:portnum format, to catch errors sooner
3154 2005-10-23 Brian Warner <warner@lothar.com>
3156 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3157 when creating the list of warning messages, include the line
3158 immediately after each WARNING: line, since that's usually where
3159 the file and line number wind up.
3161 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3166 2005-10-22 Brian Warner <warner@lothar.com>
3168 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3169 patch from Brad Hards
3170 * buildbot/status/classic.css: same
3171 * buildbot/test/test_web.py (Waterfall): match changes
3173 * buildbot/test/test_steps.py (BuildStep.setUp): set
3174 nextBuildNumber so the test passes
3175 * buildbot/test/test_status.py (MyBuilder): same
3177 * buildbot/status/html.py (StatusResourceBuild.body): revision
3178 might be numeric, so stringify it before html-escapifying it
3179 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3180 timer for the upcoming build
3181 * buildbot/status/classic.css: add background-color attributes for
3182 offline/waiting/building classes
3184 * buildbot/status/builder.py (BuildStatus): derive from
3185 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3186 the default (i.e. unknown) .slavename to "???" instead of None,
3187 since even unknown slavenames need to be printed eventually.
3188 (BuilderStatus): also derive from styles.Versioned . More
3189 importantly, determine .nextBuildNumber at creation/unpickling
3190 time by scanning the directory of saved BuildStatus instances and
3191 choosing one larger than the highest-numbered one found. This
3192 should fix the problem where random errors during upgrades cause
3193 the buildbot to forget about earlier builds. .nextBuildNumber is
3194 no longer stored in the pickle.
3195 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3196 at least log the error. Also call Builder.determineNextBuildNumber
3197 once the basedir is set.
3199 * buildbot/master.py (BuildMaster.loadChanges): do
3200 styles.doUpgrade afterwards, in case I decide to make Changes
3201 derived from styles.Versioned some day and forget to make this
3205 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3206 when running under older pythons (<2.3) in which the shlex module
3207 doesn't have a 'split' function.
3209 * buildbot/process/step.py (ShellCommand.start): make
3210 errorMessages= be a list of strings to stuff in the log before the
3211 command actually starts. This makes it easier to flag multiple
3212 warning messages, e.g. when the Source steps have to deal with an
3214 (CVS.startVC): handle slaves that don't handle multiple branches
3215 by switching into 'clobber' mode
3216 (SVN.startVC): same. Also reject branches without base_url
3217 (Darcs.startVC): same. Also reject revision= in older slaves
3218 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3219 (Bazaar.startVC): same, and test for baz separately than for arch
3221 * buildbot/slave/commands.py (cvs_ver): document new features
3223 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3224 (BuildStep.slaveVersionNewEnough): more useful utility method
3225 * buildbot/test/test_steps.py (Version): start testing it
3227 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3228 the 'force' command requires python2.3, for the shlex.split method
3230 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3231 since we don't use it anymore. The Twisted buildbot uses a
3234 2005-10-21 Brian Warner <warner@lothar.com>
3236 * buildbot/process/process_twisted.py: rework all BuildFactory
3237 classes to take a 'source' step as an argument, instead of
3238 building up the SVN instance in the factory.
3239 * docs/examples/twisted_master.cfg: enable build-on-branch by
3240 providing a base_url and default_branch
3242 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3243 control over --branch and --revision, not that they are always
3245 * buildbot/status/html.py (StatusResourceBuilder.force): same
3246 (StatusResourceBuild.body): display SourceStamp components
3248 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3249 IRC 'force' command, so it can be shared with an eventual
3250 command-line-tool 'buildbot force' mode.
3251 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3253 2005-10-20 Brian Warner <warner@lothar.com>
3255 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3257 * docs/examples/twisted_master.cfg: update to use Schedulers
3259 * buildbot/scripts/sample.cfg: update with Schedulers
3261 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3262 method specifically for use by HTML "force build" button and the
3263 IRC "force" command. Raises an immediate error if there are no
3265 (IBuilderControl.requestBuild): make this just submit a build, not
3266 try to check for existing slaves or set up any when-finished
3267 Deferreds or anything.
3268 * buildbot/process/builder.py (BuilderControl): same
3269 * buildbot/status/html.py (StatusResourceBuilder.force): same
3270 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3271 * buildbot/test/test_slaves.py: same
3272 * buildbot/test/test_web.py: same
3274 2005-10-19 Brian Warner <warner@lothar.com>
3276 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3277 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3279 2005-10-18 Brian Warner <warner@lothar.com>
3281 * buildbot/status/html.py: provide 'status' argument to most
3282 StatusResourceFOO objects
3283 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3284 and Logfiles" section to make the Build page into a more-or-less
3285 comprehensive source of status information about the build
3287 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3288 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3290 2005-10-17 Brian Warner <warner@lothar.com>
3292 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3293 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3294 out what to do about other projects: the correct options for
3295 recent Twisteds will not work for older ones.
3297 2005-10-15 Brian Warner <warner@lothar.com>
3299 * buildbot/status/builder.py (Status.getURLForThing): add method
3300 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3301 use this in email/IRC status clients to make them more useful, by
3302 providing the end user with hints on where to learn more about the
3303 object being reported on.
3304 * buildbot/test/test_web.py (GetURL): tests for it
3306 2005-10-14 Brian Warner <warner@lothar.com>
3308 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3309 fix bug resulting from deferredResult changes
3311 2005-10-13 Brian Warner <warner@lothar.com>
3313 * buildbot/test/test_changes.py: remove use of deferredResult
3314 * buildbot/test/test_config.py: same
3315 * buildbot/test/test_control.py: same
3316 * buildbot/test/test_status.py: same
3317 * buildbot/test/test_vc.py: this is the only remaining use, since
3318 it gets used at module level. This needs to be replaced by some
3319 sort of class-level run-once routine.
3321 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3323 * lots: implement multiple slaves per Builder, which means multiple
3324 current builds per Builder. Some highlights:
3325 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3326 of (state,currentBuilds) instead of (state,currentBuild)
3327 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3328 (IBuildStatus.getSlavename): new method, so you can tell which
3329 slave got used. This only gets set when the build completes.
3330 (IBuildRequestStatus.getBuilds): new method
3332 * buildbot/process/builder.py (SlaveBuilder): add a .state
3333 attribute to track things like ATTACHING and IDLE and BUILDING,
3335 (Builder): .. the .slaves attribute here, which has been turned
3336 into a simple list of available slaves. Added a separate
3337 attaching_slaves list to track ones that are not yet ready for
3339 (Builder.fireTestEvent): put off the test-event callback for a
3340 reactor turn, to make tests a bit more consistent.
3341 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3342 ping fails due to an exception. This needs work, I'm worried that
3343 a code error could lead to a constantly re-connecting slave.
3344 Especially since I'm trying to move to a distinct remote_ping
3345 method, separate from the remote_print that we currently use.
3346 (BuilderControl.requestBuild): return a convenience Deferred that
3347 provides an IBuildStatus when the build finishes.
3348 (BuilderControl.ping): ping all connected slaves, only return True
3349 if they all respond.
3351 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3352 reconnect when we shut down.
3354 * buildbot/status/builder.py: implement new methods, convert
3355 one-build-at-a-time methods to handle multiple builds
3356 * buildbot/status/*.py: do the same in all default status targets
3357 * buildbot/status/html.py: report the build's slavename in the
3358 per-Build page, report all buildslaves on the per-Builder page
3360 * buildbot/test/test_run.py: update/create tests
3361 * buildbot/test/test_slaves.py: same
3362 * buildbot/test/test_scheduler.py: remove stale test
3364 * docs/buildbot.texinfo: document the new builder-specification
3365 'slavenames' parameter
3367 2005-10-12 Brian Warner <warner@lothar.com>
3369 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3370 report failure correctly, causing Dependent builds to run when
3371 they shouldn't have.
3372 * buildbot/status/builder.py (BuildSetStatus): same
3373 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3374 (Set.testSuccess): test the both-pass case too
3375 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3376 fix this test: it was ending too early, masking the failure before
3377 (Logger): specialized StatusReceiver to make sure the dependent
3378 builds aren't even started, much less completed.
3380 2005-10-07 Brian Warner <warner@lothar.com>
3382 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3383 bot.SlaveBuilder being disowned in the middle of a build
3385 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3386 this inherit from StatusReceiver. Also upcall in __init__. This
3387 fixes the embarrasing crash when the new buildSetSubmitted method
3388 is invoked and Waterfall/etc don't implement their own.
3389 * buildbot/test/test_run.py: add a TODO note about a test to catch
3390 just this sort of thing.
3392 * buildbot/process/builder.py (Builder.attached): remove the
3393 already-attached warning, this situation is normal. Add some
3394 comments explaining it.
3396 2005-10-02 Brian Warner <warner@lothar.com>
3398 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3399 OverflowError when setting up dnotify, because some 64-bit systems
3400 have problems with signed-vs-unsigned constants and trip up on the
3401 DN_MULTISHOT flag. Patch from Brad Hards.
3403 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3405 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3406 progressMetrics, description, descriptionDone to the 'parms' list,
3407 and make use the 'parms' list from the implementation class
3408 instead of only BuildStep to initialize the parameters. This
3409 allows buildbot.process.factory.s() to initialize all the parms,
3410 not just those defined in directly by BuildStep.
3412 2005-09-03 Brian Warner <warner@lothar.com>
3414 * NEWS: start adding items for the next release
3416 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3417 python2.2 tests, change 'Quick' builder to only use python2.3
3419 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3421 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3422 the "Ping Builder" button if the build control is available; the
3423 user sees an exception otherwise
3425 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3427 2005-09-01 Brian Warner <warner@lothar.com>
3429 * buildbot/interfaces.py (IBuilderStatus.getState): update
3430 signature, point out that 'build' can be None
3431 (IBuildStatus.getETA): point out ETA can be none
3433 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3435 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3437 2005-08-31 Brian Warner <warner@lothar.com>
3439 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3440 update to match correct signature: removed 'eta' argument
3441 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3443 2005-08-30 Brian Warner <warner@lothar.com>
3445 * buildbot/status/builder.py (LogFile): remove the assertion that
3446 blows up when you try to overwrite an existing logfile, instead
3447 just emit a warning. This case gets hit when the buildmaster is
3448 killed and doesn't get a chance to write out the serialized
3449 BuilderStatus object, so the .nextBuildNumber attribute gets out
3452 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3453 the 'buildbot sendchange' arguments, for the Darcs context file
3454 * docs/buildbot.texinfo (sendchange): document it
3456 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3457 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3458 (IStatus.getSchedulers): new method
3459 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3460 (Status.getSchedulers): implement
3461 * buildbot/process/builder.py (Builder): maintain
3462 BuilderStatus.pendingBuilds
3463 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3464 (TryBase.addChange): Try schedulers should ignore Changes
3466 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3467 for 'try' on CVS/SVN
3468 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3470 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3471 report status properly.
3472 (Try.createJob): implement unique buildset IDs
3474 * buildbot/status/client.py (StatusClientPerspective): add a
3475 perspective_getBuildSets method for the benefit of jobdir-style
3477 * docs/buildbot.texinfo (try): more docs
3478 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3481 2005-08-18 Brian Warner <warner@lothar.com>
3483 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3484 actually work. It's functional but still kind of clunky. Also, it
3485 only works with the pb-style.. needs to be made to work with the
3488 * buildbot/status/client.py (RemoteBuildSet): new class
3489 (RemoteBuildRequest): same
3490 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3491 object, not the internal BuildStatus object.
3492 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3493 outside of the usual buildStarted() return value.
3494 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3496 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3497 (Try_Userpass_Perspective.perspective_try): return a remotely
3498 usable BuildSetStatus object
3500 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3501 isStarted()/waitUntilStarted()
3503 2005-08-16 Brian Warner <warner@lothar.com>
3505 * buildbot/status/builder.py: implement IBuildSetStatus and
3506 IBuildRequestStatus, wire them into place.
3507 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3508 methods into the BuildSetStatus object.
3509 * buildbot/interfaces.py: same
3510 (IStatus.getBuildSets): new method to get pending BuildSets
3511 (IStatusReceiver.buildsetSubmitted): new method which hears about
3513 * buildbot/master.py (BuildMaster.submitBuildSet): same
3514 * buildbot/process/base.py (BuildRequest): same, replace
3515 waitUntilStarted with subscribe/unsubscribe
3516 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3517 subscribe instead of waitUntilStarted
3518 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3520 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3522 * buildbot/test/test_buildreq.py: update for new code
3523 * buildbot/test/test_control.py (Force.testRequest): same
3526 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3527 for Darcs to not use the tempfile module, so it works under
3528 python-2.2 too. We really didn't need the full cleverness of that
3529 module, since the slave has exclusive control of its own builddir.
3531 2005-08-15 Brian Warner <warner@lothar.com>
3533 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3534 for CVS trees. It doesn't work for non-trunk branches,
3536 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3539 * Makefile: make it easier to test against python2.2
3541 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3542 tearDown2, so things like Arch can unregister archives as they're
3543 shutting down. The previous subclass-override-tearDown technique
3544 resulted in a nested maybeWait() and test failures under
3547 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3548 where we can (Arch), add a branch= argument to set the branch used
3550 (BazExtractor): extract the branch too
3551 (TlaExtractor): same
3552 * buildbot/scripts/runner.py (TryOptions): add --branch
3553 * docs/buildbot.texinfo (try): document --branch/try_branch
3555 * buildbot/slave/commands.py (Darcs): implement get-revision for
3556 Darcs, so that 'try' will work. This requires the tempfile module
3559 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3560 of revisions, branches, and 'try' in the process.
3562 2005-08-11 Brian Warner <warner@lothar.com>
3564 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3565 this, it got broken at some point in the last few releases
3566 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3567 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3568 specifically the removal of ETA information from the tuple
3570 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3573 * docs/buildbot.texinfo (try): document both --builder and
3574 'try_builders' in .buildbot/options
3575 * buildbot/scripts/runner.py (TryOptions): add --builder,
3576 accumulate the values into opts['builders']
3577 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3578 * buildbot/test/test_runner.py (Try): add some quick tests to make
3579 sure 'buildbot try --options' and .buildbot/options get parsed
3580 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3581 use --builder control
3583 * docs/buildbot.texinfo (try): add --port argument to PB style
3585 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3586 actual SourceStamp. Still need to extract a branch name, somehow.
3587 (Try): finish implementing the try client side, still need a UI
3588 for specifying which builders to use
3589 (Try.getopt): factor our options/config-file reading
3590 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3592 * buildbot/test/test_vc.py: match SourceStampExtractor change
3594 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3595 causes the twisted log to be sent to stderr
3597 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3599 2005-08-10 Brian Warner <warner@lothar.com>
3601 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3602 style is 90% done, still missing status reporting or waiting for
3603 the buildsets to finish, and it is completely untested.
3605 * buildbot/trybuild.py: delete file, move contents to ..
3606 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3607 * buildbot/test/test_vc.py: match the move
3609 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3610 of the TryScheduler, no buildsetID or status-tracking support yet
3611 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3613 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3614 possible to set the basedir after __init__ time, so it is easier
3615 to use as a Service-child of the BuildMaster instance
3617 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3618 that delivers messages to its Service parent instead of requiring
3619 a subclass to be useful. This turns out to be much easier to build
3622 * buildbot/scripts/tryclient.py (createJob): utility code to
3623 create jobfiles, will eventually be used by 'buildbot try'
3625 2005-08-08 Brian Warner <warner@lothar.com>
3627 * docs/buildbot.texinfo (try): add docs on the
3628 as-yet-unimplemented Try scheduler
3630 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3631 * buildbot/test/test_scheduler.py: .. here
3632 (Scheduling.testTryJobdir): add placeholder test for 'try'
3634 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3635 addEntry merging (>=chunkSize) behavior
3636 (Log.testConsumer): update to handle new callLater(0) behavior
3638 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3639 both the MAX_LENGTH bugfix and the resumeProducing hang.
3641 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3642 put off the actual resumeProducing for a moment with
3643 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3644 causes large logfiles to hang midway through.
3646 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3647 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3648 and to improve memory usage when streaming the file out to a web
3650 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3651 make this work cleanly
3653 2005-08-03 Brian Warner <warner@lothar.com>
3655 * buildbot/trybuild.py: new file for 'try' utilities
3656 (getSourceStamp): run in a tree, find out the baserev+patch
3657 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3658 implemented for SVN and Darcs, still working on Arch. I don't know
3659 how to make CVS work yet.
3661 * docs/buildbot.texinfo: document the 'buildbot' command-line
3662 tool, including the not-yet-implemented 'try' feature, and the
3663 in-flux .buildbot/ options directory.
3665 2005-07-20 Brian Warner <warner@lothar.com>
3667 * buildbot/locks.py: added temporary id() numbers to Lock
3668 descriptions, to track down a not-really-sharing-the-Lock bug
3670 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3672 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3673 needed for python2.2 compatibility
3674 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3675 are from the __future__
3677 2005-07-19 Brian Warner <warner@lothar.com>
3679 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3680 message when schedulers use unknown builders
3682 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3683 SlaveLock('name') and MasterLock('name') are distinct
3685 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3686 c['schedulers'] in such a way that we can actually accept
3688 * buildbot/test/test_config.py: check it
3690 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3691 utility method to *all* the Schedulers
3692 (Periodic.listBuilderNames): same
3694 * docs/buildbot.texinfo (Interlocks): update chapter to match
3697 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3698 to make sure that c['sources'], c['schedulers'], and c['status']
3699 are all lists of the appropriate objects, and that the Schedulers
3700 all point to real Builders
3701 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3702 'listBuilderNames' utility method to support this
3703 * buildbot/scheduler.py: implement the utility method
3704 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3706 * docs/buildbot.texinfo: add some @cindex entries
3708 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3709 if it wasn't already set: most tla commands will fail unless one
3711 (Arch.createRepository): and disable bazaar's revision cache, since
3712 they cause test failures (the multiple repositories we create all
3713 interfere with each other through the cache)
3715 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3716 bring it properly up to date with twisted-2.0 test guidelines
3718 * buildbot/master.py (BuildMaster): remove references to old
3719 'interlock' module, this caused a bunch of post-merge test
3721 * buildbot/test/test_config.py: same
3722 * buildbot/process/base.py (Build): same
3724 * buildbot/test/test_slaves.py: stubs for new test case
3726 * buildbot/scheduler.py: add test-case-name tag
3727 * buildbot/test/test_buildreq.py: same
3729 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3730 unnecessary init code
3731 (Bot.remote_setBuilderList): match it
3733 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3735 * buildbot/changes/mail.py (parseSyncmail): update comment
3737 * buildbot/test/test_slavecommand.py: disable Shell tests on
3738 platforms that don't suport IReactorProcess
3740 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3741 all places where we open logfiles. It causes OS-X to open the file
3742 in some weird mode that that prevents us from mixing reads and
3743 writes to the same filehandle, which we depend upon to implement
3744 _generateChunks properly. This change doesn't appear to break
3745 win32, on which "b" and "t" are treated differently but a missing
3746 flag seems to be interpreted as "t".
3748 2005-07-18 Brian Warner <warner@lothar.com>
3750 * buildbot/slave/commands.py (ShellCommand): overhaul
3751 error-handling code, to try and make timeout/interrupt work
3752 properly, and make win32 happier
3753 * buildbot/test/test_slavecommand.py: clean up, stop using
3754 reactor.iterate, add tests for timeout and interrupt
3755 * buildbot/test/sleep.py: utility for a new timeout test
3757 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3758 code from the local-usebranches branch
3760 2005-07-17 Brian Warner <warner@lothar.com>
3762 * buildbot/process/process_twisted.py
3763 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3764 minutes, to match the other twisted BuildFactories, and don't
3765 excuse failures in c/qt/win32 reactors any more.
3767 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3768 'freebsd' builders, since the buildslaves have been unavailable
3771 2005-07-13 Brian Warner <warner@lothar.com>
3773 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3774 build-on-branch feature
3776 * buildbot/process/step.py (Darcs.__init__): add base_url and
3777 default_branch arguments, just like SVN
3778 (Arch.__init__): note that the version= argument is really the
3781 * buildbot/slave/commands.py (SourceBase): keep track of the
3782 repository+branch that was used for the last checkout in
3783 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3784 match, we clobber the directory and perform a fresh checkout
3785 rather than trying to do an in-place update. This should protect
3786 us against trying to get to branch B by doing an update in a tree
3787 obtained from branch A.
3788 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3789 (SVN.setup): same, just the svnurl
3790 (Darcs.setup): same, just the repourl
3791 (Arch.setup): same, arch coordinates (url), version, and
3792 buildconfig. Also pull the buildconfig from the args dictionary,
3793 which we weren't doing before, so the build-config was effectively
3795 (Arch.sourcedirIsUpdateable): don't try to update when we're
3796 moving to a specific revision: arch can't go backwards, so it is
3797 safer to just clobber the tree and checkout a new one at the
3799 (Bazaar.setup): same sourcedata as Arch
3801 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3802 use maybeWait, to work with twisted-1.3.0 and twcompat
3803 (Dependencies.testRun_Pass): same
3805 * buildbot/test/test_vc.py: rearrange, cleanup
3807 * buildbot/twcompat.py: add defer.waitForDeferred and
3808 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3809 can work under twisted-1.3.0 .
3811 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3812 now created at setUp time. This increases the runtime of the test
3813 suite considerably (from 91 seconds to 151), but it removes the
3814 need for an offline tarball, which should solve a problem I've
3815 seen where the test host has a different version of svn than the
3816 tarball build host. The new code also validates that mode=update
3817 really picks up recent commits. This approach will also make it
3818 easier to test out branches, because the code which creates the VC
3819 branches is next to the code which uses them. It will also make it
3820 possible to test some change-notification hooks, by actually
3821 performing a VC commit and watching to see the ChangeSource get
3824 2005-07-12 Brian Warner <warner@lothar.com>
3826 * docs/buildbot.texinfo (SVN): add branches example
3827 * docs/Makefile (buildbot.ps): add target for postscript manual
3829 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3830 * buildbot/test/test_locks.py: same
3832 * buildbot/process/step.py (Darcs): comment about default branches
3834 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3835 c['interlocks'] in the config file, complain if it is present.
3836 Scan all locks in c['builders'] to make sure the Locks they use
3838 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3839 add some tests to check for non-uniquely-named Locks
3840 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3841 since the unique-Lock validation code requires it now
3843 * buildbot/locks.py: fix test-case-name
3845 * buildbot/interlock.py: remove old file
3847 2005-07-11 Brian Warner <warner@lothar.com>
3849 * buildbot/test/test_interlock.py: rename to..
3850 * buildbot/test/test_locks.py: .. something shorter
3852 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3853 versions (after 2.0.1) changed internet.TCPClient to shut down the
3854 connection in stopService. Change the code to handle this
3857 * buildbot/process/base.py (Build): handle whole-Build locks
3858 * buildbot/process/builder.py (Builder.compareToSetup): same
3859 * buildbot/test/test_interlock.py: make tests work
3861 * buildbot/process/step.py (BuildStep.startStep): complain if a
3862 Step tries to claim a lock that's owned by its own Build
3863 (BuildStep.releaseLocks): typo
3865 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3866 file reloads don't replace unchanged Builders
3868 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3869 rewrite to cover new Locks instead of old c['interlocks']
3870 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3874 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3875 start the master and connect the buildslave
3877 * buildbot/process/step.py (FailingDummy.done): finish with a
3878 FAILURE status rather than raising an exception
3880 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3881 stringify a BuildRequest.reason that is None
3883 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3885 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3886 allow scheduler.Dependent to work
3887 * buildbot/buildset.py (BuildSet): set .reason and .results
3889 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3890 slaves, to make the test stop hanging. It still fails, of course,
3891 because I haven't even started to implement Locks.
3893 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3895 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3896 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3897 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3898 (Dependent): new class for downstream build dependencies
3899 * buildbot/test/test_dependencies.py: tests (still failing)
3901 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3903 2005-07-07 Brian Warner <warner@lothar.com>
3905 * buildbot/test/runutils.py (RunMixin): factored this class out..
3906 * buildbot/test/test_run.py: .. from here
3907 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3908 added new buildbot.locks tests (which all hang right now)
3909 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3910 * buildbot/process/step.py: claim/release per-BuildStep locks
3912 * docs/Makefile: add 'buildbot.html' target
3914 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3915 interpreted as "HEAD", so that all VC steps can accept branch=None
3916 and have it mean the "default branch".
3918 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3920 2005-07-07 Brian Warner <warner@lothar.com>
3922 * docs/examples/twisted_master.cfg: update to match current usage
3924 * docs/buildbot.texinfo (System Architecture): comment out the
3925 image, it doesn't exist yet and just screws up the HTML manual.
3927 2005-07-05 Brian Warner <warner@lothar.com>
3929 * debian/.cvsignore: oops, missed one. Removing leftover file.
3931 2005-06-17 Brian Warner <warner@lothar.com>
3933 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3934 changed its output in 1.2.0, don't mistakenly think that the
3935 subversion we find isn't capable of supporting our tests.
3937 * debian/*: remove the debian/ directory and its contents, to make
3938 life easier for the proper Debian maintainer
3940 * Makefile (release): same
3942 2005-06-07 Brian Warner <warner@lothar.com>
3944 * everything: create a distinct SourceStamp class to replace the
3945 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3946 Changed the signature of Source.startVC to include the revision
3947 information (instead of passing it through self.args). Implement
3948 branches for SVN (now only Darcs/Git is missing support). Add more
3951 2005-06-06 Brian Warner <warner@lothar.com>
3953 * everything: rearrange build scheduling. Create a new Scheduler
3954 object (configured in c['schedulers'], which submit BuildSets to a
3955 set of Builders. Builders can now use multiple slaves. Builds can
3956 be run on alternate branches, either requested manually or driven
3957 by changes. This changed some of the Status classes. Interlocks
3958 are out of service until they've been properly split into Locks
3959 and Dependencies. treeStableTimer, isFileImportant, and
3960 periodicBuild have all been moved from the Builder to the
3962 (BuilderStatus.currentBigState): removed the 'waiting' and
3963 'interlocked' states, removed the 'ETA' argument.
3965 2005-05-24 Brian Warner <warner@lothar.com>
3967 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3968 erroneously abandons the connection (in clientConnectionFailed)
3969 for non-UserErrors, which means that if we lose the connection due
3970 to a network problem or a timeout, we'll never try to reconnect.
3971 Fix this by not upcalling to the buggy parent method. Note:
3972 twisted-2.0 fixes this, but the function only has 3 lines so it
3973 makes more sense to copy it than to try and detect the buggyness
3974 of the parent class. Fixes SF#1207588.
3976 * buildbot/changes/changes.py (Change.branch): doh! Add a
3977 class-level attribute to accomodate old Change instances that were
3978 pickled before 0.6.5 (where .branch was added for new Changes).
3979 This fixes the exception that occurs when you try to look at an
3980 old Change (through asHTML).
3982 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3985 2005-05-23 Brian Warner <warner@lothar.com>
3987 * buildbot/__init__.py (version): release 0.6.6
3989 2005-05-23 Brian Warner <warner@lothar.com>
3991 * NEWS: update for 0.6.6 release
3992 * debian/changelog: same
3994 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3995 before starting: this was done by twistd back when we spawned it,
3996 now that we're importing the pieces and running them in the
3997 current process, we have to do it ourselves. This allows
3998 master.cfg to import files from the same directory without
3999 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4000 Stichele for the catch.
4001 (Options.opt_version): Add a --version command (actually, just make
4002 the existing --version command emit Buildbot's version too)
4004 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4005 fix to make this behave like other LogFiles, this time to handle
4006 existing LogFiles on disk. (add the missing .upgrade method)
4007 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4009 2005-05-21 Brian Warner <warner@lothar.com>
4011 * buildbot/test/test_runner.py (Create.testMaster): match the
4012 rawstring change in runner.py:masterTAC
4014 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4015 TwistedWords is installed
4016 * buildbot/test/test_status.py: same, with TwistedMail
4018 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4019 some old, deprecated, and removed config keys). This should enable
4020 you to use the base buildbot functionality with Twisted-2.0.0 when
4021 you don't also have TwistedWeb and TwistedWords installed
4023 2005-05-20 Brian Warner <warner@lothar.com>
4025 * buildbot/scripts/runner.py (run): call sendchange(), not
4026 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4027 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4028 (stop): don't wait for process to die when sending SIGHUP
4029 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4030 directory name gets interpreted, which you don't want
4033 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4036 2005-05-18 Brian Warner <warner@lothar.com>
4038 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4040 2005-05-18 Brian Warner <warner@lothar.com>
4042 * README: update for 0.6.5
4043 * debian/changelog: same
4045 * buildbot/changes/changes.py: rename tag= to branch=, since
4046 that's how we're using it, and my design for the upcoming "build a
4047 specific branch" feature wants it. also, tag= was too CVS-centric
4048 * buildbot/changes/mail.py (parseSyncmail): same
4049 * buildbot/process/base.py (Build.isBranchImportant): same
4050 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4051 * docs/buildbot.texinfo (Attributes of Changes): same
4053 * NEWS: update tag=, update for upcoming release
4055 2005-05-17 Brian Warner <warner@lothar.com>
4057 * buildbot/scripts/runner.py (stop): actually poll once per
4058 second, instead of re-killing the poor daemon once per second.
4059 Sleep briefly (0.1s) before the first poll, since there's a good
4060 chance we can avoid waiting the full second if the daemon shuts
4061 down quickly. Also remove the sys.exit() at the end.
4062 (start): remove the unneighborly sys.exit()
4064 * Makefile: improve permission-setting to not kick Arch so badly
4066 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4067 default --keepalive=600, since it doesn't hurt very much, and it's
4068 a hassle to discover that you need it.
4069 * buildbot/test/test_runner.py (Create.testSlave): test it
4071 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4072 IRC bot about EXCEPTION
4074 * buildbot/status/client.py (PBListener): upcall more correctly
4076 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4077 an exception mark the overall build with EXCEPTION, not SUCCESS
4079 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4081 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4082 * Makefile: update some release-related stuff
4084 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4085 gets called when there isn't actually an active process, just end
4086 the Command instead of blowing up. I don't know how it gets into
4087 this state, but the twisted win32 buildslave will sometimes hang,
4088 and when it shakes its head and comes back, it thinks it's still
4089 running a Command. The next build causes this command to be
4090 interrupted, but the lack of self.process.pid breaks the interrupt
4093 * NEWS: document changes since the last release
4095 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4096 look for Makefile.buildbot instead of a bare Makefile . The
4097 'buildbot start' does not install this file, so you have to
4098 manually copy it if you want to customize startup behavior.
4099 (createMaster): change 'buildbot master' command to create
4100 Makefile.sample instead of Makefile, to create master.cfg.sample
4101 instead of master.cfg (requiring you to copy it before the
4102 buildmaster can be started). Both sample files are kept up to
4103 date, i.e. they are overwritten if they have been changed. The
4104 'buildbot.tac' file is *not* overwritten, but if the new contents
4105 don't match the old, a 'buildbot.tac.new' file is created and the
4106 user is warned. This seems to be a much more sane way to handle
4107 startup files. Also, don't sys.exit(0) when done, so we can run
4108 unit tests against it.
4109 (createSlave): same. Don't overwrite the sample info/ files.
4110 * buildbot/scripts/sample.mk: remove. the contents were pulled
4111 into runner.py, since they need to match the behavior of start()
4115 * docs/buildbot.texinfo (Launching the daemons): document it
4116 * buildbot/test/test_runner.py (Create): test it
4118 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4119 version that can handle string-in-string tests, because otherwise
4120 python-2.2 fails the tests. It'd be tremendous if Trial's test
4121 took two strings under 2.2 too.
4123 * everything: fixed all deprecation warnings when running against
4124 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4125 few that come from Twisted itself). This involved putting most of
4126 the Twisted-version specific code in the new buildbot.twcompat
4127 module, and creating some abstract base classes in
4128 buildbot.changes.base and buildbot.status.base (which might be
4129 useful anyway). __implements__ is a nuisance and requires an ugly
4130 'if' clause everywhere.
4132 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4133 delay before finishing the test: it seems that smtp.sendmail
4134 doesn't hang up on the server, so we must wait a moment so it can
4135 hang up on us. This removes the trial warning about an unclean
4138 2005-05-16 Brian Warner <warner@lothar.com>
4140 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4141 tuple of (delay, repeats).
4142 * buildbot/test/test_vc.py (Retry): test it
4143 * docs/buildbot.texinfo (Source Checkout): document it
4144 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4145 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4146 doVCFull() are handled by re-trying the checkout (after a delay)
4147 some number of times.
4148 (ShellCommand._startCommand): make header lines easier to read
4150 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4152 (WebTest.test_logfile): make sure master gets shut down, silences
4153 some "unclean reactor" test errors
4155 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4156 reactor once after shutdown, something in certain versions of
4157 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4158 fails, svn-trunk is ok.
4160 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4161 second win32 error message
4163 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4164 validating the ETA, so the tests don't fail on slow systems
4166 2005-05-15 Brian Warner <warner@lothar.com>
4168 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4169 the new LogFile class, so upgrading works properly
4170 (LogFileProducer.resumeProducing): survive resumeProducing after
4171 we've exhausted the chunkGenerator
4173 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4175 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4176 (Log.testUpgrade): same
4178 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4179 Builds and logs with a cron job.
4181 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4182 of the old non-offline LogFile, added code to upgrade these to
4183 new-style contents-live-on-disk instances at load time (in a way
4184 that doesn't invalidate the old Build pickles, so upgrading to
4185 0.6.5 is not a one-way operation). Got rid of everything related
4187 (LogFile.__init__): create LogFiles with the parent step status,
4188 the log's name, and a builder-relative filename where it can keep
4189 the contents on disk.
4190 (LogFile.hasContents): new method, clients are advised to call it
4191 before getText or getChunks and friends. If it returns False, the
4192 log's contents have been deleted and getText() will raise an
4194 (LogFile.getChunks): made it a generator
4195 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4196 Consumer (except one that takes chunks instead of strings). This
4197 enables streaming of very large logfiles without storing the whole
4199 (BuildStatus.generateLogfileName): create names like
4200 12-log-compile-output, with a _0 suffix if required to be unique
4201 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4202 or earlier) logfiles into new-style ones
4203 (BuilderStatus): remove everything related to 'stub' builds. There
4204 is now only one build cache, and we don't strip logs from old
4206 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4207 since we no longer fight to keep it in the cache
4209 * buildbot/status/html.py (TextLog.render_GET): use a
4210 ChunkConsumer to stream the log entries efficiently.
4211 (ChunkConsumer): wrapper which consumes chunks and writes
4214 * buildbot/test/test_twisted.py (Parse.testParse): use a
4215 LogFile-like object instead of a real one
4217 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4218 (Log.testMerge3): validate more merge behavior
4219 (Log.testChunks): validate LogFile.getChunks
4220 (Log.testUpgrade): validate old-style LogFile upgrading
4221 (Log.testSubscribe): validate LogFile.subscribe
4222 (Log.testConsumer): validate LogFile.subscribeConsumer
4224 * buildbot/interfaces.py (IStatusLogStub): remove
4225 (IStatusLog.subscribeConsumer): new method
4226 (IStatusLog.hasContents): new method
4227 (IStatusLogConsumer): describes things passed to subscribeConsumer
4229 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4230 the log contents if it does not have any contents.
4231 (StatusResourceBuildStep.body): same
4232 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4234 2005-05-14 Brian Warner <warner@lothar.com>
4236 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4237 timeouts to try and make the windows metabuildslave not hang
4239 2005-05-13 Mike Taylor <bear@code-bear.com>
4241 * buildbot/slave/commands.py (rmdirRecursive): added a check
4242 to ensure the path passed into rmdirRecursive actually exists.
4243 On win32 a non-existant path would generate an exception.
4245 2005-05-13 Brian Warner <warner@lothar.com>
4247 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4248 shutil.rmtree which behaves correctly on windows in the face of
4249 files that you have to chmod before deleting. Thanks to Bear at
4250 the OSAF for the routine.
4251 (SourceBase.doClobber): use rmdirRecursive
4253 2005-05-12 Brian Warner <warner@lothar.com>
4255 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4256 method generate chunks instead of returning a big list. This
4257 allows the same method to be used for both old LogFile and new
4259 (OfflineLogFile.getText): use the generator
4260 (OfflineLogFile.subscribe): same
4261 * buildbot/status/html.py (TextLog.resumeProducing): same
4262 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4264 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4265 point out that OfflineLogFile does not currently work with
4266 html.Waterfall . Fixing this is high-priority.
4268 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4269 apparently windows defaults to using stdout
4271 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4272 better message on failure so I can figure out the win32 problem
4274 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4275 log messages to include more useful copies of the command being
4276 run, the argv array, and the child command's environment.
4277 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4279 2005-05-11 Brian Warner <warner@lothar.com>
4281 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4283 * Makefile: update the deb-snapshot version
4285 * docs/buildbot.texinfo: move all .xhtml docs into a new
4286 .texinfo-format document, adding a lot of material in the process.
4287 This is starting to look like a real user's manual. Removed all
4288 the Lore-related files: *.xhtml, *.css, template.tpl .
4289 * docs/Makefile: simple makefile to run 'makeinfo'
4290 * buildbot/scripts/sample.cfg: rearrange slightly
4291 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4293 2005-05-10 Brian Warner <warner@lothar.com>
4295 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4296 different name for the internal twistw module, handle it.
4298 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4299 * setup.py: .. and stop trying to install it
4301 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4302 'git'), the new linux kernel VC system (http://kernel.org/git/).
4303 Thanks to Brandon Philips for the patch.
4304 * buildbot/slave/commands.py (Git): same
4306 2005-05-06 Brian Warner <warner@lothar.com>
4308 * buildbot/status/builder.py (OfflineLogFile): replace the default
4309 LogFile with a form that appends its new contents to a disk file
4310 as they arrive. The complete log data is never kept in RAM. This
4311 is the first step towards handling very large (100MB+) logfiles
4312 without choking quite so badly. (The other half is
4313 producer/consumer on the HTML pages).
4314 (BuildStepStatus.addLog): use OfflineLogFile by default
4315 (BuildStatus.getLogfileName): helper code to give the
4316 OfflineLogFile a filename to work with
4318 * buildbot/test/test_status.py (Results.testAddResults): update
4319 tests to handle new asserts
4320 * buildbot/test/test_vc.py (Patch.doPatch): same
4321 * buildbot/test/test_steps.py (BuildStep.setUp): same
4323 2005-05-05 Brian Warner <warner@lothar.com>
4325 * buildbot/scripts/runner.py (start): if there is no Makefile,
4326 launch the app by importing twistd's internals and calling run(),
4327 rather than spawning a new twistd process. This stands a much
4328 better chance of working under windows.
4329 (stop): kill the process with os.kill instead of spawning
4330 /bin/kill, again to reduce the number of external programs which
4331 windows might not have in the PATH. Also wait up to 5 seconds for
4332 the process to go away, allowing things like 'buildbot stop;
4333 buildbot start' to be reliable in the face of slow shutdowns.
4335 * buildbot/master.py (Dispatcher.__getstate__): remove old
4336 .tap-related methods
4337 (BuildMaster.__getstate__): same
4339 * buildbot/slave/bot.py (makeService): same
4340 (Options.longdesc): same
4341 * buildbot/scripts/runner.py: copy over some old mktap option text
4343 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4344 'buildbot master' now creates a buildbot.tac file, so there is no
4345 longer a create-instance/save/reload sequence. mktap is dead, long
4347 * buildbot/scripts/sample.mk: use twistd -y, not -f
4348 * buildbot/test/test_config.py: remove mktap-based test
4349 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4350 * README: don't reference mktap
4352 * docs/source.xhtml: document some of the attributes that Changes
4355 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4357 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4358 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4359 * buildbot/changes/changes.py (Change)
4360 * buildbot/changes/mail.py (parseSyncmail)
4361 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4363 * buildbot/process/base.py (Build.isTagImportant)
4367 2005-05-04 Brian Warner <warner@lothar.com>
4369 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4370 connection after sending the change, so that unit tests don't
4371 complain about sockets being left around
4373 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4374 exception in phase=0 rendering
4375 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4377 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4379 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4380 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4381 and configuring builders with tuples.
4382 * buildbot/test/test_config.py: stop testing compatibility with
4383 deprecated config keys
4384 * buildbot/test/test_run.py: same
4386 2005-05-03 Brian Warner <warner@lothar.com>
4388 * contrib/arch_buildbot.py: survive if there are no logfiles
4389 (username): just use a string, os.getlogin isn't reliable
4391 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4392 so 'buildbot sendchange' actually works. The earlier test only
4393 covered the internal (non-reactor-running) form.
4395 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4396 script to notify the buildmaster about changes
4398 * buildbot/scripts/runner.py (sendchange): new command to send a
4399 change to a buildbot.changes.pb.PBChangeSource receiver.
4400 * buildbot/test/test_changes.py (Sender): test it
4402 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4403 after any reading of the config file, not just when we do it in
4404 startService. This makes some tests a bit cleaner.
4406 * buildbot/changes/pb.py: add some log messages
4408 * buildbot/process/base.py (Build.startBuild): fix a bug that
4409 caused an exception when the build terminated in the very first
4411 (Build.stepDone): let steps return a status of EXCEPTION. This
4412 terminates the build right away, and sets the build's overall
4413 status to EXCEPTION too.
4414 * buildbot/process/step.py (BuildStep.failed): return a status of
4415 EXCEPTION when that is what has happened.
4417 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4418 implement this, allowing Arch-based projects to get precise
4419 checkouts instead of always using the latest code
4420 (Bazaar): create variant of Arch to let folks use baz instead of
4421 tla. Requires a new buildslave too.
4422 * buildbot/slave/commands.py (Arch): add 'revision' argument
4423 (Bazaar): create variant of Arch that uses baz instead of tla.
4424 Remove the code that extracts the archive name from the
4425 register-archive output, since baz doesn't provide it, and require
4426 the user provide both the archive name and its location.
4427 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4429 2005-05-02 Brian Warner <warner@lothar.com>
4431 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4432 thanks to Nick Trout.
4434 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4435 deals better with source Makefile coming from a read-only CVS
4436 checkout. Thanks to Nick Trout for the catch.
4438 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4441 2005-04-28 Brian Warner <warner@lothar.com>
4443 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4445 * debian/changelog: update for 0.6.4
4447 2005-04-28 Brian Warner <warner@lothar.com>
4449 * README.w32: add a checklist of steps for getting buildbot
4451 * MANIFEST.in: include it in the tarball
4455 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4456 broken .tap files from 0.6.3 by getting rid of .services,
4457 .namedServices, and .change_svc at load time.
4459 2005-04-27 Brian Warner <warner@lothar.com>
4461 * NEWS: update in preparation for new release
4463 * buildbot/test/test_config.py (Save.testSave): don't pull in
4464 twisted.scripts.twistd, we don't need it and it isn't for windows
4467 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4468 accomodate win32 which can't do atomic-rename
4470 2005-04-27 Brian Warner <warner@lothar.com>
4472 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4473 timeouts to help the slow metabuildbot not flunk them so much
4474 (Disconnect.testBuild3): same
4475 (Disconnect.testBuild4): same
4476 (Disconnect.testInterrupt): same
4478 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4479 setup, it was completely broken for new buildmasters (those which
4480 did not have a 'change.pck' already saved. Thanks to Paul Warren
4481 for catching this (embarrassing!) bug.
4482 (Dispatcher.__getstate__): don't save our registered avatar
4483 factories, since they'll be re-populated when the config file is
4485 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4486 tests (since the real mktap-generated BuildMaster doesn't save
4488 (BuildMaster.__getstate__): don't save any service children,
4489 they'll all be re-populated when the config file is re-read.
4490 * buildbot/test/test_config.py (Save.testSave): test for this
4492 2005-04-26 Brian Warner <warner@lothar.com>
4494 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4495 rendered with Blender.. looks a bit nicer.
4496 * buildbot/docs/images/icon.blend: add the Blender file for it
4498 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4499 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4500 running under windows. This appears to be the best way to allow
4501 BuildSteps to do something normal like 'trial -v buildbot.test' or
4502 'make foo' and still expect it to work. The idea is to make the
4503 BuildSteps look as much like what a developer would type when
4504 compiling or testing the tree by hand. This approach probably has
4505 problems when there are spaces in the arguments, so if you've got
4506 windows buildslaves, you'll need to pay close attention to your
4509 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4510 timezone to the timestamp column.
4511 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4513 * buildbot/scripts/runner.py (loadOptions): do something sane for
4514 windows, I think. We use %APPDATA%/buildbot instead of
4515 ~/.buildbot, but we still search everywhere from the current
4516 directory up to the root for a .buildbot/ subdir. The "is it under
4517 $HOME" security test was replaced with "is it owned by the current
4518 user", which is only performed under posix.
4519 * buildbot/test/test_runner.py (Options.testFindOptions): update
4520 tests to match. The "is it owned by the current user" check is
4521 untested. The test has been re-enabled for windows.
4523 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4524 any "\n" in the expected output with the platform-specific line
4525 separator. Make this separator "\r\n" on PTYs under unix, they
4526 seem to do that and I don't know why
4528 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4529 windows for now, I don't know what ~/.buildbot/ should mean there.
4531 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4532 win32 compatibility, don't use "/tmp"
4533 (Basedir.testChangeBuilddir): remove more unixisms
4535 2005-04-26 Brian Warner <warner@lothar.com>
4537 * buildbot/test/test_control.py (Force.rmtree): python2.2
4538 compatibility, apparently its shutil.rmtree ignore_errors=
4539 argument is ignored.
4540 * buildbot/test/test_run.py (Run.rmtree): same
4541 (RunMixin.setUp): same
4543 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4546 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4547 'substring in string' operator, must use string.find(substr)!=-1
4548 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4549 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4551 * buildbot/scripts/runner.py (loadOptions): add code to search for
4552 ~/.buildbot/, a directory with things like 'options', containing
4553 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4554 the current directory, your $HOME directory, or anywhere
4555 inbetween, as long as you're somewhere inside your home directory.
4556 (debugclient): look in ~/.buildbot/options for master and passwd
4557 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4558 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4560 * buildbot/status/client.py (makeRemote): new approach to making
4561 IRemote(None) be None, which works under Twisted-2.0
4562 * buildbot/test/test_status.py (Client.testAdaptation): test it
4564 * buildbot/status/builder.py (Status.builderAdded): when loading a
4565 pickled BuilderStatus in from disk, set its name after loading.
4566 The config file might have changed its name (but not its
4567 directory) while it wasn't looking.
4569 * buildbot/process/builder.py (Builder.attached): always return a
4570 Deferred, even if the builder was already attached
4571 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4573 2005-04-25 Brian Warner <warner@lothar.com>
4575 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4576 category-related exception when announcing a build has finished
4578 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4579 reference no-longer-existent changemaster.sources
4580 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4582 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4585 2005-04-25 Brian Warner <warner@lothar.com>
4587 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4589 * debian/changelog: update for 0.6.3
4591 2005-04-25 Brian Warner <warner@lothar.com>
4593 * MANIFEST.in: make sure debug.glade is in the tarball
4595 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4597 * NEWS: update for the imminent 0.6.3 release
4599 * buildbot/status/html.py (HtmlResource.content): make the
4600 stylesheet <link> always point at "buildbot.css".
4601 (StatusResource.getChild): map "buildbot.css" to a static.File
4602 containing whatever css= argument was provided to Waterfall()
4603 (Waterfall): provide the "classic" css as the default.
4604 * docs/waterfall.classic.css: move default CSS from here ..
4605 * buildbot/status/classic.css: .. to here
4607 * MANIFEST.in: make sure classic.css is included in the tarball
4608 * setup.py: and that it is installed too, under buildbot/status/
4610 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4611 the module level, because buildbot.tap files from 0.6.2 don't have
4612 it in their attribute dictionary.
4614 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4615 really exists at startup, might save some confusion somewhere.
4617 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4619 * docs/waterfall.classic.css:
4620 add a stylesheet that's almost the same as the "classic"
4623 * buildbot/status/builder.py:
4624 add EXCEPTION as a result - this is a problem for the bot
4625 maintainer, not a build problem for the changers
4626 * buildbot/process/step.py:
4627 use EXCEPTION instead of FAILURE for exceptions
4628 * buildbot/status/html.py:
4629 add build_get_class to get a class out of a build/buildstep
4630 finish naming the classes
4631 split out sourceNames to changeNames and builderNames so we
4632 can style them separately
4633 * docs/config.xhtml:
4634 finish documenting classes as they are right now
4636 * buildbot/status/html.py:
4637 name the classes as we agreed on IRC
4638 * docs/config.xhtml:
4641 * buildbot/status/html.py:
4642 same for cssclass->class_
4644 * buildbot/status/html.py:
4645 as decided on IRC, use class_ for the "class" attribute to not
4646 conflict with the class keyword, and clean up the messy **{} stuff.
4648 * buildbot/status/mail.py:
4649 put back "builders" argument, and fix docstring, because the
4650 code *ignores* builders listed in this argument
4652 * buildbot/process/builder.py:
4653 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4655 * docs/config.xhtml:
4656 describe the category argument for builders
4658 * buildbot/status/builder.py:
4659 Fix a silly bug due to merging
4661 * buildbot/process/builder.py:
4662 remove category from the process Builder ...
4663 * buildbot/status/builder.py:
4664 ... and add it to BuilderStatus instead.
4665 Set category on unpickled builder statuses, they might not have it.
4666 * buildbot/master.py:
4667 include category when doing builderAdded
4668 * buildbot/status/mail.py:
4669 return None instead of self for builders we are not interested in.
4670 * buildbot/test/test_run.py:
4671 fix a bug due to only doing deferredResult on "dummy" waiting
4672 * buildbot/test/test_status.py:
4673 add checks for the Mail IStatusReceiver returning None or self
4675 * buildbot/status/html.py:
4676 fix testsuite by prefixing page title with BuildBot
4678 * buildbot/status/builder.py:
4679 have .category in builder status ...
4680 * buildbot/process/builder.py:
4681 ... and set it from Builder
4682 * buildbot/status/html.py:
4683 make .css a class variable
4684 * buildbot/test/test_status.py:
4685 write more tests to cover our categories stuff ...
4686 * buildbot/status/mail.py:
4687 ... and fix the bug that this uncovered
4689 * buildbot/changes/mail.py:
4690 * buildbot/changes/pb.py:
4691 * buildbot/master.py:
4692 * buildbot/process/base.py:
4693 * buildbot/process/factory.py:
4694 * buildbot/process/interlock.py:
4695 * buildbot/process/step.py:
4696 * buildbot/process/step_twisted.py:
4697 * buildbot/slave/commands.py:
4698 * buildbot/status/builder.py:
4699 * buildbot/status/client.py:
4700 * buildbot/status/html.py:
4701 * buildbot/status/mail.py:
4702 * buildbot/status/progress.py:
4703 * buildbot/test/test_changes.py:
4704 * buildbot/test/test_config.py:
4705 * buildbot/test/test_control.py:
4706 * buildbot/test/test_interlock.py:
4707 * buildbot/test/test_maildir.py:
4708 * buildbot/test/test_mailparse.py:
4709 * buildbot/test/test_run.py:
4710 * buildbot/test/test_slavecommand.py:
4711 * buildbot/test/test_status.py:
4712 * buildbot/test/test_steps.py:
4713 * buildbot/test/test_twisted.py:
4714 * buildbot/test/test_util.py:
4715 * buildbot/test/test_vc.py:
4716 * buildbot/test/test_web.py:
4718 add test-case-name at the top of a whole set of files
4720 * buildbot/status/builder.py:
4721 keep order of addition when getting builder names
4722 * buildbot/status/words.py:
4723 * buildbot/test/test_run.py:
4724 add test for getBuilderNames
4726 * buildbot/process/base.py:
4727 * buildbot/process/step.py:
4728 * buildbot/status/builder.py:
4729 * buildbot/status/html.py:
4730 make buildbot css-able
4731 replace the color code for purple with purple, don't understand
4732 why it wasn't purple to start with
4734 * buildbot/status/words.py:
4735 ok, so it doesn't look like BuilderStatus.remote is still valid.
4736 Use what waterfall uses instead.
4738 * buildbot/interfaces.py:
4739 * buildbot/status/builder.py:
4740 * buildbot/status/html.py:
4741 * buildbot/status/mail.py:
4742 * buildbot/status/words.py:
4743 * buildbot/test/test_run.py:
4744 use categories everywhere and make it be a list. More sensible
4745 for the future. Also make words actually respect this in
4748 * buildbot/interfaces.py:
4749 add category argument to getBuilderNames
4750 * buildbot/process/builder.py:
4751 * buildbot/status/builder.py:
4752 * buildbot/status/html.py:
4753 * buildbot/status/mail.py:
4754 * buildbot/status/words.py:
4755 * buildbot/test/test_run.py:
4756 move from specifying builders by name to specifying the category
4758 * buildbot/status/html.py:
4759 * buildbot/status/words.py:
4760 add "builders=" to __init__ of status clients so they can
4761 limit themselves to the given list of builders to report on
4763 * buildbot/status/html.py: set the title to the product name
4765 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4767 * buildbot/interfaces.py:
4768 * buildbot/status/builder.py:
4769 more documentation. Hm, not sure if ChangeLog entries make sense
4772 2005-04-23 Brian Warner <warner@lothar.com>
4774 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4776 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4778 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4779 the sub-commands that log buildmaster status to stdout and to a
4780 GUI window, respectively.
4782 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4783 functionality is working again, but all the step-status and ETA
4784 stuff is missing. Commented out a lot of code pending more
4787 * buildbot/status/client.py: make sure that IRemote(None) is None
4789 * buildbot/changes/changes.py: import defer, oops
4790 (ChangeMaster): remove the .sources list, rely upon the fact that
4791 MultiServices can be treated as sequences of their children. This
4792 cleans up the add/remove ChangeSource routines a lot, as we keep
4793 exactly one list of the current sources instead of three.
4795 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4796 up an empty ChangeMaster at init time.
4797 (BuildMaster.loadChanges): if there are changes to be had from
4798 disk, replace self.change_svc with the new ones. If not, keep
4799 using the empty ChangeMaster set up in __init__.
4800 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4801 instead of a separate list, makes the code a bit cleaner.
4802 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4803 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4804 Extend the test to make sure we can get rid of the sources when
4807 2005-04-22 Brian Warner <warner@lothar.com>
4809 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4810 and info/host files when making the slave directory
4812 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4813 whendone= argument, just return the Deferred and let the caller do
4814 what they want with it.
4815 (Disconnect.testBuild1): wait for shutdownSlave
4816 (Basedir.testChangeBuilddir): new test to make sure changes to the
4817 builddir actually get propagated to the slave
4819 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4820 explicit method, rather than passing the builddir in __init__ .
4821 Make sure to update self.basedir too, this was broken before.
4822 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4823 builders and for ones that have just had their builddir changed.
4824 (BotFactory): add a class-level .perspective attribute, so
4825 BuildSlave.waitUntilDisconnected won't get upset when the
4826 connection hasn't yet been established
4827 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4828 tests can reach through it to inspect the SlaveBuilders
4830 * buildbot/process/base.py (Build.buildException): explain the
4831 log.err with a log.msg
4832 * buildbot/process/builder.py (Builder.startBuild): same
4833 (Builder._startBuildFailed): improve error message
4835 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4836 occurred because we lost the brand-new connection, retry instead
4837 of giving up. If not, it's probably an authorization failure, and
4838 it makes sense to stop trying. Make sure we log.msg the reason
4839 that we're log.err'ing the failure, otherwise test failures are
4840 really hard to figure out.
4842 * buildbot/master.py: change loadConfig() to return a Deferred
4843 that doesn't fire until the change has been fully implemented.
4844 This means any connected slaves have been updated with the new
4845 builddir. This change makes it easier to test the code which
4846 actually implements this builddir-updating.
4847 (BotPerspective.addBuilder): return Deferred
4848 (BotPerspective.removeBuilder): same
4849 (BotPerspective.attached): same
4850 (BotPerspective._attached): same. finish with remote_print before
4851 starting the getSlaveInfo, instead of doing them in parallel
4852 (BotPerspective.list_done): same
4853 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4854 actually calling slave.disconnect()
4855 (BotMaster.addBuilder): same
4856 (BotMaster.removeBuilder): same
4857 (BuildMaster.loadConfig): same
4858 (BuildMaster.loadConfig_Slaves): same
4859 (BuildMaster.loadConfig_Sources): same
4860 (BuildMaster.loadConfig_Builders): same
4861 (BuildMaster.loadConfig_status): same
4863 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4864 a Deferred that fires when the source is finally removed
4866 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4867 the previous tree on win32, where we have to do it synchronously,
4868 make sure we return a Deferred anyway.
4869 (SourceBase.doCopy): same
4871 * buildbot/scripts/runner.py (statusgui): use the text client for
4872 now, while I rewrite the Gtk one
4873 * buildbot/clients/base.py: strip out old code, leaving just the
4874 basic print-message-on-event functionality. I also remove the
4875 ReconnectingPBClientFactory, but it does at least quit when it
4876 loses the connection instead of going silent
4878 2005-04-21 Brian Warner <warner@lothar.com>
4880 * Makefile: minor tweaks
4882 * NEWS: point out deprecation warnings, new features for
4885 * buildbot/master.py (BuildMaster.loadConfig): emit
4886 DeprecationWarnings for Builders defined with tuples. Rearrange
4887 code to facility removal of deprecated configuration keys in the
4890 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4891 'buildbot' command to put a little Makefile in the target that
4892 helps you re-create the buildbot.tap file, start or stop the
4893 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4894 all the files 0600, since they contain passwords.
4895 (start): if there is a Makefile, and /usr/bin/make exists, use
4896 'make start' in preference to a raw twistd command. This lets
4897 slave admins put things like PYTHONPATH variables in their
4898 Makefiles and have them still work when the slave is started with
4899 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4900 be nice to first try the 'make' command and only fall back to
4901 twistd if it fails. TODO: the Makefile's "start" command does not
4902 add the --reactor=win32 argument when running under windows.
4903 (Options.debugclient, Options.statusgui): add sub-commands to launch
4904 the debug client (formerly in contrib/debugclient.py) and the
4905 Gtk status application (currently broken)
4906 * buildbot/clients/debug.py: move from contrib/debugclient.py
4907 * buildbot/clients/debug.glade: same
4909 * buildbot/test/test_trial.py: remove it. This requires some
4910 functionality out of Twisted that isn't there yet, and until then
4911 having it around just confuses things.
4913 * buildbot/test/test_slavecommand.py (Shell): test both with and
4914 without PTYs, and make sure that command output is properly
4915 interleaved in the with-PTY case. I think the without-PTY test
4916 should pass on windows, where we never use PTYs anyway.
4918 2005-04-20 Brian Warner <warner@lothar.com>
4920 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4922 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4924 * NEWS: start creating entries for the next release
4926 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4928 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4929 (WebTest.test_webPathname): same
4930 (WebTest.test_webPathname_port): same
4931 (WebTest.test_waterfall): use the default favicon rather than
4932 rooting around the filesystem for it. Open the expected-icon file
4933 in binary mode, to make win32 tests happier (thanks to Nick Trout
4935 * buildbot/status/html.py (buildbot_icon): win32 portability
4937 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4938 win32-compatibility fixes from Nick Trout, the "file not found" message
4939 is different under windows
4940 (FakeSlaveBuilder.__init__): clean up setup a bit
4941 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4943 2005-04-19 Brian Warner <warner@lothar.com>
4945 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4946 skip-if-repositories-are-unavailable test to not kill the trial
4947 that comes with Twisted-1.3.0
4949 * setup.py: install buildbot.png icon file when installing code
4951 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4952 environment used by the command, at least on the child side.
4954 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4955 this method needs to be added and implemented because it gets
4956 called under heavy load. I don't quite understand the
4957 producer/consumer API enough to write it.
4958 (StatusResource.getChild): add a resource for /favicon.ico
4959 (Waterfall.__init__): add favicon= argument
4960 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4961 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4962 (WebTest.test_webPathname): same
4963 (WebTest.test_webPathname_port): same
4964 * docs/config.xhtml: mention favicon=
4965 * buildbot/buildbot.png: add a default icon, dorky as it is
4967 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4969 * buildbot/master.py:
4970 * buildbot/process/base.py:
4971 * buildbot/process/builder.py:
4972 * buildbot/process/interlock.py:
4973 * buildbot/status/builder.py:
4974 * buildbot/status/html.py:
4975 * buildbot/status/mail.py:
4976 * buildbot/status/words.py:
4977 new documentation while digging through the code
4979 2005-04-17 Brian Warner <warner@lothar.com>
4981 * general: try to fix file modes on all .py files: a+r, a-x,
4982 but let buildbot/clients/*.py be +x since they're tools
4984 * docs/epyrun (addMod): when an import fails, say why
4986 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4988 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4990 * buildbot/process/base.py:
4991 * buildbot/process/builder.py:
4992 * buildbot/status/builder.py:
4993 new documentation while digging through the code
4995 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4997 * buildbot/changes/changes.py:
4998 * buildbot/changes/p4poller.py:
4999 * buildbot/interfaces.py:
5000 * buildbot/process/base.py:
5001 * buildbot/process/builder.py:
5002 * buildbot/process/step.py:
5003 * buildbot/process/step_twisted.py:
5004 * buildbot/slave/bot.py:
5005 * buildbot/slave/commands.py:
5006 * buildbot/status/builder.py:
5007 fix all docstrings to make epydoc happy. In the process of fixing
5008 some, I also moved pieces of docs, and removed some deprecated
5011 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5013 * buildbot/process/builder.py:
5014 * buildbot/process/interlock.py:
5015 * buildbot/process/process_twisted.py:
5016 * buildbot/process/step.py:
5017 BuildProcess -> Build, as it looks like that's what happened
5018 * buildbot/process/base.py:
5019 * buildbot/process/factory.py:
5022 2005-04-17 Brian Warner <warner@lothar.com>
5024 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5025 update compile command to accomodate the Twisted split.. now
5026 instead of './setup.py build_ext -i', you do './setup.py all
5027 build_ext -i', to run build_ext over all sub-projects.
5028 (FullTwistedBuildFactory): same
5029 (TwistedReactorsBuildFactory): same
5031 * buildbot/status/html.py (TextLog.finished): null out self.req
5032 when we're done, otherwise the reference cycle of TextLog to .req
5033 to .notifications to a Deferred to TextLog.stop keeps them from
5034 being collected, and consumes a huge (610MB on pyramid at last
5035 check) amount of memory.
5037 2005-04-11 Brian Warner <warner@lothar.com>
5039 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5040 normalize the VC-repository location.. makes SVN happier with
5041 certain test environments.
5043 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5044 RemoteShellCommand gets its own .env dictionary, so that code in
5045 start() doesn't mutate the original. I think this should fix the
5046 step_twisted.Trial problem where multiple identical components
5047 kept getting added to PYTHONPATH= over and over again.
5049 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5050 adding epydoc-format docstrings to many classes. Thanks to Thomas
5051 Vander Stichele for the patches.
5052 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5053 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5054 * buildbot/slave/bot.py, commands.py, registry.py: same
5056 2005-04-05 Brian Warner <warner@lothar.com>
5058 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5059 preserve timestamps, helps incremental builds of large trees.
5060 Patch from Rene Rivera.
5062 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5063 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5066 2005-04-03 Brian Warner <warner@lothar.com>
5068 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5069 with one dict, apparently exec has some scoping bugs when used
5070 with both global/local dicts. Thanks to Nathaniel Smith for the
5073 2005-04-02 Brian Warner <warner@lothar.com>
5075 * buildbot/process/step_twisted.py (countFailedTests): the new
5076 trial in Twisted-2.0 emits a slightly different status line than
5077 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5078 mistakenly think the test count is unparseable.
5079 (Trial.start): note that for some reason each build causes another
5080 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5081 be fixed but I'm not sure quite where the problem is.
5083 2005-04-01 Brian Warner <warner@lothar.com>
5085 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5086 deferredResult to avoid hangs/warnings under twisted-2.0
5087 (RunMixin.tearDown): same
5088 (RunMixin.shutdownSlave): same
5089 (Disconnect.testIdle1): same
5090 (Disconnect.testBuild2): same: wait one second after the build
5091 finishes for test to really be done.. this should be cleaned up to
5092 avoid wasting that second. Builder.detach uses a callLater(0),
5093 either that should be done in-line (something else needed that
5094 behavior), or it should return a Deferred that fires when the
5095 builder is really offline.
5096 (Disconnect.testBuild3): same
5097 (Disconnect.testDisappear): same
5099 * buildbot/test/test_web.py: rearrange server-setup and teardown
5100 code to remove unclean-reactor warnings from twisted-2.0
5102 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5103 so the tests don't hang under twisted-2.0
5105 2005-03-31 Brian Warner <warner@lothar.com>
5107 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5108 caused a warning each time the master changed our set of builders
5110 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5111 w32, don't unlink the file unless it already exists. Thanks to
5112 Baptiste Lepilleur for the catch.
5113 (BuilderStatus.saveYourself): same
5115 2005-02-01 Brian Warner <warner@lothar.com>
5117 * buildbot/status/html.py (TextLog.getChild): use a /text child
5118 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5119 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5120 logfile as text/plain (no markup, no headers). This replaces the
5121 previous scheme (which used an ?text=1 argument), and gets us back
5122 to a relative link (which works better when the buildbot lives
5123 behind another web server, such as Apache configured as a reverse
5124 proxy). Thanks to Gerald Combs for spotting the problem.
5126 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5129 2004-12-13 Brian Warner <warner@lothar.com>
5131 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5133 * debian/changelog: update for 0.6.2
5134 * NEWS: finalize for 0.6.2
5136 2004-12-11 Brian Warner <warner@lothar.com>
5138 * NEWS: bring it up to date
5140 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5141 detection code. Require some sign of life from the buildmaster
5142 every BotFactory.keepaliveInterval seconds. Provoke this
5143 indication at BotFactory.keepaliveTimeout seconds before the
5144 deadline by sending a keepalive request. We don't actually care if
5145 that request is answered in a timely fashion, what we care about
5146 is that .activity() is called before the deadline. .activity() is
5147 triggered by any PB message from the master (including an ack to
5148 one of the slave's status-update messages). With this new scheme,
5149 large status messages over slow pipes are OK, as long as any given
5150 message can be sent (and thus acked) within .keepaliveTimeout
5151 seconds (which defaults to 30).
5152 (SlaveBuilder.remote_startCommand): record activity
5153 (SlaveBuilder.ackUpdate): same
5154 (SlaveBuilder.ackComplete): same
5155 (BotFactory.gotPerspective): same
5156 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5158 2004-12-09 Brian Warner <warner@lothar.com>
5160 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5163 * buildbot/process/step_twisted.py (Trial._commandComplete):
5164 update self.cmd when we start the 'cat test.log' transfer. Without
5165 this, we cannot interrupt the correct RemoteCommand when we lose
5168 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5169 trying to tell the slave to stop the command if we're already
5170 inactive, or if we no longer have a .remote
5172 * buildbot/process/builder.py (Builder._detached): don't let an
5173 exception in currentBuild.stopBuild() prevent the builder from
5174 being marked offline
5176 2004-12-07 Brian Warner <warner@lothar.com>
5178 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5179 KeyError that happens when you ask for a non-existent Builder, and
5180 translate it into a UsageError.
5182 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5183 losing the slave in the middle of a remote step is handled too
5185 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5186 be a Failure, so be sure to stringify it before using it as the
5187 contents of the 'interrupt' logfile
5188 (RemoteCommand.interrupt): use stringified 'why' in
5189 remote_interruptCommand too, just in case
5191 2004-12-06 Brian Warner <warner@lothar.com>
5193 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5194 instead of 'tla update', which is more efficient in case we've
5195 missed a couple of patches since the last update.
5197 * debian/changelog: update for previous (0.6.1) release. Obviously
5198 this needs to be handled better.
5200 2004-12-05 Brian Warner <warner@lothar.com>
5202 * NEWS: update for stuff since last release
5204 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5205 match the maybeDeferred change in Dispatcher.requestAvatar
5206 * buildbot/changes/pb.py (ChangePerspective.attached): same
5207 * buildbot/status/client.py (StatusClientPerspective.attached): same
5208 * buildbot/process/builder.py (Builder._attached3): same
5209 * buildbot/pbutil.py (NewCredPerspective.attached): same
5211 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5212 the date to the top-most box, if it is not the same as today's
5215 * docs/slave.xhtml: provide a buildslave setup checklist
5217 * docs/source.xhtml (Arch): correct terminology
5219 2004-12-04 Brian Warner <warner@lothar.com>
5221 * buildbot/test/test_slavecommand.py: use sys.executable instead
5222 of hard-coding 'python' for child commands, might help portability
5224 * docs/examples/twisted_master.cfg: update to current usage
5226 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5227 'stop build' command to the IRC bot
5229 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5230 message that broke PBChangeSource
5232 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5233 (SlaveBuilder): make some attributes class-level, remove the old
5234 "update queue" which existed to support resuming a build after the
5235 master connection was lost. Try to reimplement that feature later.
5236 (SlaveBuilder.stopCommand): clear self.command when the
5237 SlaveCommand finishes, so that we don't try to kill a leftover one
5239 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5242 * buildbot/slave/commands.py (SourceBase): set self.command for
5243 all VC commands, so they can be interrupted.
5245 2004-12-03 Brian Warner <warner@lothar.com>
5247 * buildbot/master.py: clean up slave-handling code, to handle
5248 slave-disconnect and multiple-connect better
5249 (BotPerspective): make these long-lasting, exactly one per bot
5250 listed in the config file.
5251 (BotPerspective.attached): if a slave connects while an existing
5252 one appears to still be connected, disconnect the old one first.
5253 (BotPerspective.disconnect): new method to forcibly disconnect a
5254 buildslave. Use some hacks to empty the transmit buffer quickly to
5255 avoid the long (20-min?) TCP timeout that could occur if the old
5256 slave has dropped off the net.
5257 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5258 own their own SlaveStatus objects. Remove .attached/.detached, add
5259 .addSlave/.removeSlave, treat slaves like Builders (config file
5260 parsing sends deltas to the BotMaster). Inform the slave
5261 instances, i.e. the BotPerspective, about addBuilder and
5263 (BotMaster.getPerspective): turns into a single dict lookup
5264 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5265 which gives BotPerspective.attached a chance to disconnect the old
5267 (BuildMaster.loadConfig): add code (disabled) to validate that all
5268 builders use known slaves (listed in c['bots']). The check won't
5269 work with tuple-specified builders, which are deprecated but not
5270 yet invalid, so the check is disabled for now.
5271 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5272 routine, do the add/changed/removed dance with them like we do
5274 (BuildMaster.loadConfig_Sources): move source-config into a
5275 separate routine too
5277 * buildbot/status/builder.py (Status.getSlave): get the
5278 SlaveStatus object from the BotPerspective, not the BotMaster.
5280 * buildbot/test/test_run.py: bunch of new tests for losing the
5281 buildslave at various points in the build, handling a slave that
5282 connects multiple times, and making sure we can interrupt a
5285 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5286 something other than 'Bot' for the Bot object, to make certain
5287 test cases easier to write.
5288 (BuildSlave.waitUntilDisconnected): utility method for testing
5290 2004-11-30 Brian Warner <warner@lothar.com>
5292 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5294 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5295 argument, return a Deferred that always fires with True or False.
5296 I don't use an errback to indicate 'ping failed' so that callers
5297 are free to ignore the deferred without causing spurious errors in
5299 * buildbot/process/builder.py (BuilderControl.ping): implement it
5301 * buildbot/test/test_run.py (Status.testDisappear): test ping
5302 (Status.disappearSlave): fix it
5304 2004-11-30 Brian Warner <warner@lothar.com>
5306 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5307 (IBuilderControl): add .getBuild(num), only works for the current
5308 build, of course, although it might be interesting to offer
5309 something for builds in the .waiting or .interlocked state.
5311 * buildbot/process/base.py (Build): have .stopBuild just do the
5312 interrupt, then let the build die by itself.
5313 (BuildControl): add .stopBuild, and add a point-event named
5314 'interrupt' just after the build so status viewers can tell that
5316 (BuilderControl): add .getBuild
5318 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5319 stops when you kill it, good for testing
5320 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5321 contains the 'reason' text.
5323 * buildbot/status/html.py: Add Stop Build button, if the build can
5324 still be stopped. Send a Redirect (to the top page) one second
5325 later, hopefully long enough for the interrupt to have an effect.
5326 Move make_row() up to top-level to share it between Stop Build and
5329 * buildbot/slave/commands.py: only kill the child process once
5331 * buildbot/test/test_run.py: add testInterrupt
5333 2004-11-29 Brian Warner <warner@lothar.com>
5335 * buildbot/process/base.py: Refactor command interruption. The
5336 Build is now responsible for noticing that the slave has gone
5337 away: Build.lostRemote() interrupts the current step and makes
5338 sure that no further ones will be started.
5340 * buildbot/process/builder.py: When the initial remote_startBuild
5341 message fails, log it: this usually indicates that the slave has
5342 gone away, but we don't really start paying attention until they
5343 fail to respond to the first step's command.
5345 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5346 slave disconnect. Now sports a new interrupt() method. Error
5347 handling was simplified a lot by chaining deferreds, so
5348 remoteFailed/remoteComplete were merged into a single
5349 remoteComplete method (which can now get a Failure object).
5350 Likewise failed/finished were merged into just _finished.
5351 (BuildStep): Add interrupt(why) method, and if why is a
5352 ConnectionLost Failure then the step is failed with some useful
5355 * buildbot/slave/bot.py: stop the current command when the remote
5356 Step reference is lost, and when the slave is shut down.
5357 (Bot): make it a MultiService, so it can have children. Use
5358 stopService to tell when the slave is shutting down.
5359 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5360 remote_interruptCommand (which asks the current SlaveCommand to
5361 stop but allows it to keep emitting status messages), and
5362 stopCommand (which tells it to shut up and die).
5364 * buildbot/slave/commands.py: make commands interruptible
5365 (ShellCommand.kill): factor out os.kill logic
5366 (Command): factor out setup()
5367 (Command.sendStatus): don't send status if .running is false, this
5368 happens when the command has been halted.
5369 (Command.interrupt): new method, used to tell the command to die
5370 (SlaveShellCommand): implement .interrupt
5371 (DummyCommand): implement .interrupt
5372 (SourceBase, etc): factor out setup(), don't continue substeps if
5375 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5376 so they can be called after finishing
5378 * buildbot/test/test_run.py: new tests for disconnect behavior,
5379 refactor slave-shutdown routines, add different kinds of
5382 2004-11-27 Brian Warner <warner@lothar.com>
5384 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5385 method to express ETA time like "2m45s" instead of "165 seconds"
5387 2004-11-24 Brian Warner <warner@lothar.com>
5389 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5390 archive after the test completes, to avoid cluttering the user's
5391 'tla archives' listing with a bogus entry. Arch doesn't happen to
5392 provide any way to override the use of ~/.arch-params/, so there
5393 isn't a convenient way to avoid touching the setup of the user who
5395 (VC_HTTP.testArchHTTP): same
5397 2004-11-23 Brian Warner <warner@lothar.com>
5399 * buildbot/status/html.py (TextLog): split render() up into
5400 render_HEAD and render_GET. Use a Producer when sending log
5401 chunks, to reduce memory requirements and avoid sending huge
5402 non-Banana-able strings over web.distrib connections. Requires
5403 peeking under the covers of IStatusLog.
5404 (TextLog.resumeProducing): fix the "as text" link, handle client
5405 disconnects that occur while we're still sending old chunks.
5407 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5408 use defer.succeed, not the non-existent defer.success
5409 (LogFile.waitUntilFinished): same
5410 (LogFile.subscribe): don't add watchers to a finished logfile
5412 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5415 2004-11-23 Brian Warner <warner@lothar.com>
5417 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5419 2004-11-23 Brian Warner <warner@lothar.com>
5421 * NEWS: update for the 0.6.1 release
5422 * MANIFEST.in: add new files
5424 * README (INSTALLATION): explain how to enable the extra VC tests
5426 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5427 level to, so old pickled builds can be displayed ok
5429 2004-11-22 Brian Warner <warner@lothar.com>
5431 * NEWS: summarize updates since last release
5433 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5434 Yoz Grahame. Closes SF#1050138.
5436 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5439 * buildbot/process/step_twisted.py (Trial): update docs a bit
5441 * docs/factories.xhtml: fix Trial factory docs to match reality.
5444 * buildbot/process/factory.py (Trial.__init__): add args for
5445 randomly= and recurse=, making them available to instantiators
5446 instead of only to subclassers. Closes: SF#1049759.
5448 2004-11-15 Brian Warner <warner@lothar.com>
5450 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5451 try to teach the Quick factory to use multiple versions of python
5453 2004-11-12 Brian Warner <warner@lothar.com>
5455 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5456 safer w32-compatible approach, and only use it on windows
5457 (BuildStatus.saveYourself): same
5459 2004-11-11 Brian Warner <warner@lothar.com>
5461 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5462 it: one string merge per chunk. There are now separate .entries
5463 and .runEntries lists: when enumerating over all chunks, make sure
5465 * buildbot/test/test_status.py (Log): more tests
5467 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5468 chunks together, up to 10kb per chunk. This ought to cut down on
5469 the CPU-burning overhead of large log files. Thanks to Alexander
5470 Staubo for spotting the problem.
5471 * buildbot/test/test_status.py (Log): tests for same
5473 2004-11-10 Brian Warner <warner@lothar.com>
5475 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5476 header to outbound mail
5477 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5479 2004-11-08 Brian Warner <warner@lothar.com>
5481 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5482 can't do os.rename() onto an existing file, so catch the exception
5483 and unlink the target file first. This introduces a slight window
5484 where the existing file could be lost, but the main failure case
5485 (disk full) should still be handled safely.
5486 (BuildStatus.saveYourself): same
5488 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5489 separator character instead of os.sep, because the filenames being
5490 split here are coming from the VC system, which can have a
5491 different pathname convention than the local host. This should
5492 help a buildmaster running on windows that uses a CVS repository
5493 which runs under unix.
5494 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5496 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5497 when there are no test failures to be parsed
5499 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5500 instead of the unix-specific os.system("cp"), thanks to Elliot
5501 Murphy for this and the other buildbot-vs-windows catches.
5502 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5504 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5505 echo the command as it is run
5507 * setup.py: install sample.mk too, not just sample.cfg
5508 (scripts): install contrib/windows/buildbot.bat on windows
5510 2004-11-07 Brian Warner <warner@lothar.com>
5512 * buildbot/process/builder.py (Builder._detached): clear the
5513 self.currentBuild reference, otherwise the next build will be
5514 skipped because we think the Builder is already in use.
5516 * docs/examples/twisted_master.cfg: update to match current usage
5517 on the Twisted buildbot
5519 2004-10-29 Brian Warner <warner@lothar.com>
5521 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5523 2004-10-28 Brian Warner <warner@lothar.com>
5525 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5526 have separate doVCUpdate/doVCFull methods. Catch an update failure
5527 and respond by clobbering the source directory and re-trying. This
5528 will handle local changes (like replacing a file with a directory)
5529 that will cause CVS and SVN updates to fail.
5530 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5532 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5535 2004-10-19 Brian Warner <warner@lothar.com>
5537 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5539 * buildbot/status/html.py (StatusResourceTestResults): display any
5540 TestResults that the Build might have
5541 (StatusResourceTestResult): and the logs for each TestResult
5542 (StatusResourceBuild): add link from the per-build page
5544 2004-10-15 Brian Warner <warner@lothar.com>
5546 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5547 the 'problems' portion of stdout, add TestResults to our build
5548 * buildbot/test/test_twisted.py (Parse.testParse): test it
5550 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5551 to retrieve a dict of accumulated test results
5552 (ITestResult): define what a single test result can do
5553 * buildbot/status/builder.py (TestResult): implement ITestResult
5554 (BuildStatus.getTestResults): retrieve dict of TestResults
5555 (BuildStatus.addTestResult): add TestResults
5556 * buildbot/test/test_status.py (Results.testAddResults): test it
5558 2004-10-14 Brian Warner <warner@lothar.com>
5560 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5561 instead of os.system("rm -rf") for win32 portability
5563 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5564 SignalMixin instead of starting/stopping the reactor, which is
5565 likely to cause problems with other tests
5567 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5568 self.copyComplete() call. Yoz Grahame makes the catch.
5570 * contrib/windows/buildbot.bat: helper script to deal with path
5571 issues. Thanks to Yoz Grahame.
5573 * buildbot/master.py (BuildMaster.startService): don't register a
5574 SIGHUP handler if the signal module has no SIGHUP attribute.
5575 Apparently win32 does this.
5577 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5579 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5580 test if the reactor can't offer UNIX sockets
5582 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5583 error introduced in the last commit. We really need that
5586 2004-10-12 Brian Warner <warner@lothar.com>
5588 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5589 when describing a maildir source. Thanks to Stephen Davis.
5591 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5594 * buildbot/scripts/runner.py (createMaster): install Makefile too
5595 (start): add --no_save to 'start' command
5596 * buildbot/scripts/sample.mk: simple convenience Makefile with
5597 start/stop/reload targets
5599 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5602 2004-09-30 Brian Warner <warner@lothar.com>
5604 * setup.py: Releasing buildbot-0.6.0
5606 2004-09-30 Brian Warner <warner@lothar.com>
5608 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5609 test_trial.py from the source tarball until support is complete.
5611 * NEWS: update for 0.6.0 release
5612 * buildbot/__init__.py (version): same
5615 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5616 'source' command to tell users where to get the Buildbot source
5618 * docs/examples/*.cfg: update to modern standards
5620 * NEWS: update for release
5622 * buildbot/scripts/runner.py (createMaster): remove the
5623 -shutdown.tap stuff now that it isn't necessary
5625 (start): launch buildbot.tap, not buildbot-shutdown.tap
5628 * buildbot/status/mail.py (Domain): shorten class name
5629 (MailNotifier): if lookup= is a string, pass it to Domain()
5630 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5631 (Mail.testBuild2): test the string-to-Domain shortcut
5632 (Mail.testMail): fix test
5635 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5638 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5639 more attributes on load
5640 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5641 to accomodate the whole waterfall page at once, and the thrashing
5642 results in a lot of unnecessary loads
5643 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5644 (BuilderStatus.saveYourself): same
5645 (BuilderStatus.eventGenerator): stop generating on the first missing
5646 build. We assume that saved builds are deleted oldest-first.
5647 (BuildStepStatus.__getstate__): .progress might not exist
5649 * buildbot/changes/changes.py (ChangeMaster): make it
5650 serializable, in $masterdir/changes.pck
5651 (ChangeMaster.stopService): save on shutdown
5652 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5653 * buildbot/test/test_config.py: load Changes before config file
5656 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5657 "Oh my god, you killed the command" header on a separate line
5659 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5660 skip over corrupted build pickles
5661 (BuilderStatus.getFullBuildByNumber): same
5662 (BuilderStatus.eventGenerator): skip over unavailable builds
5663 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5664 do an atomic rename. This prevents a corrupted pickle when some
5665 internal serialization error occurs.
5666 (BuilderStatus.saveYourself): same
5668 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5669 the timeout for shell commands, it got lost somehow
5671 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5672 run out of build steps, return the rest of the builder events
5674 * buildbot/interfaces.py (IBuilderControl.ping): add method
5676 * buildbot/process/builder.py (BuilderControl.ping): move
5677 slave-ping to BuilderControl, and fix the failure case in the
5678 process (Event.finish() is the verb, Event.finished is the noun).
5680 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5681 through the BuilderControl instead of the BuilderStatus
5682 (EventBox): add adapter for builder.Event, allowing builder events to
5683 be displayed in the waterfall display
5685 * buildbot/master.py (BotMaster.stopService): add a 'master
5686 shutdown' event to the builder's log
5687 (BuildMaster.startService): and a 'master started' on startup
5689 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5690 builder events into the BuildStep event stream
5691 (Status.builderAdded): add a 'builder created' event
5694 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5695 command to announce the completion of a running build
5696 (IrcStatusBot.command_FORCE): announce when the build finishes
5698 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5699 don't evict unfinished builds from the cache: they must stay in
5700 the full-cache until their logfiles have stopped changing. Make
5701 sure the eviction loop terminates if an unfinished build was hit.
5702 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5703 This lets exceptions be dumped in an email status message. Really
5704 we need LogFiles which contain both text and HTML, instead of two
5706 (BuildStatus.__getstate__): handle self.finished=False
5707 (Status.builderAdded): if the pickle is corrupted, abandon the
5708 history and create a new BuilderStatus object.
5710 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5711 self.progress attribute, helped one test which doesn't fully set
5712 up the Build object.
5714 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5715 IStatusLog methods into an Interface that is implemented by "stub"
5716 logs, for which all the actual text chunks are on disk (in the
5717 pickled Build instance). To show the log contents, you must first
5718 adapt the stub log to a full IStatusLog object.
5720 * buildbot/status/builder.py (LogFileStub): create separate stub
5721 log objects, which can be upgraded to a real one if necessary.
5722 (LogFile): make them persistable, and let them stubify themselves
5724 (BuildStepStatus): same
5726 (BuildStatus.saveYourself): save the whole build out to disk
5727 (BuilderStatus): make it persistable
5728 (BuilderStatus.saveYourself): save the builder to disk
5729 (BuilderStatus.addFullBuildToCache): implement two caches which
5730 hold Build objects: a small one which holds full Builds, and a
5731 larger one which holds "stubbed" Builds (ones with their LogFiles
5732 turned into LogFileStubs). This reduces memory usage by the
5733 buildmaster by not keeping more than a few (default is 2) whole
5734 build logs in RAM all the time.
5735 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5737 (BuilderStatus.eventGenerator): rewrite since .builds went away
5738 (BuilderStatus.buildStarted): remove the .builds array. Add the
5739 build to the "full" cache when it starts.
5740 (BuilderStatus._buildFinished): save the build to disk when it
5742 (Status): give it a basedir (same as the BuildMaster's basedir)
5743 where the builder pickles can be saved
5744 (Status.builderAdded): create the BuilderStatus ourselves, by
5745 loading a pickle from disk (or creating a new instance if there
5746 was none on disk). Return the BuilderStatus so the master can glue
5747 it into the new Builder object.
5749 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5750 all BuilderStatuses to save themselves out to disk. This is in
5751 lieu of saving anything important in the main Application pickle
5752 (the -shutdown.tap file).
5753 (BuildMaster.__init__): give Status() a basedir for its files
5754 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5755 to get the BuilderStatus, then give it to the Builder (instead of
5756 doing it the other way around). It's ok if the status announces
5757 the new Builder before it's really ready, as the outside world can
5758 only see the BuilderStatus object anyway (and it is ready before
5759 builderAdded returns). Use the builder's "builddir" (which
5760 normally specifies where the slave will run the builder) as the
5761 master's basedir (for saving serialized builds).
5763 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5764 coerce the logfile to IStatusLog before trying to get the text
5765 chunks out of it. This will pull the full (non-stubified) Build in
5766 from disk if necessary.
5767 (TextLog): fix the adapter registration
5769 * buildbot/test/test_control.py (Force.setUp): create the basedir
5770 * buildbot/test/test_web.py: same
5771 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5772 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5773 * buildbot/test/test_run.py (Run.testMaster): same
5774 (Status.setUp): same
5776 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5778 * buildbot/status/html.py (Waterfall.__init__): store actual
5779 allowForce flag passed in rather than using True for everyone;
5780 make sure setting it to False doesn't cause a NameError
5782 (StatusResourceBuilder.__init__) add the builder name to the page
5784 (StatusResourceBuilder.body) move HTML generation for a name/value
5785 row into a helper method (StatusResourceBuilder.make_row); only
5786 generate the "Force Build" form if allowForce was True and the
5787 slave is connected. Use class attributes in the generated HTML to
5788 spread a little CSS-joy.
5790 2004-09-28 Brian Warner <warner@lothar.com>
5792 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5793 warning-scanner to not ignore things like
5794 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5796 * buildbot/status/html.py (StatusResource.control): add some
5797 class-level values for .control in an attempt to make upgrading
5800 * buildbot/util.py (ComparableMixin): survive missing attributes,
5801 such as when a class is modified and we're comparing old instances
5804 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5805 failure handling, remove a redundant try/except block. Don't
5806 return the full traceback to the IRC channel.
5807 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5808 error messages. Get ETA properly.
5810 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5811 the reason, since (at least) IRC message will have <> in them.
5812 (StatusResourceBuilder.__init__): take an IBuilderControl
5813 (StatusResourceBuilder.force): use the IBuilderControl we get in
5814 the constructor instead of trying to make our own. Catch the
5815 new exceptions and ignore them for now (until we make an
5816 intermediate web page where we could show the error message)
5817 (StatusResource): create with an IControl, use it to give an
5818 IBuilderControl to all children
5819 (Waterfall): take an allowForce= option, pass an IControl object
5820 to StatusResource if it is True
5822 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5824 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5825 catch new exceptions and return string forms
5827 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5828 * buildbot/process/builder.py (Builder.forceBuild): raise them
5829 * buildbot/test/test_control.py (Force.testNoSlave): new test
5830 (Force.testBuilderInUse): same
5833 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5835 * buildbot/test/test_run.py: use IControl
5836 * buildbot/test/test_vc.py: same
5838 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5839 to use IControl. Still offline.
5840 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5842 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5843 who=None so periodic builds don't send out status mail
5844 (Builder.forceBuild): include reason in the log message
5845 (BuilderControl.forceBuild): rename 'name' to 'who'
5847 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5848 'who' parameter, but make it None by default so builds forced by
5849 slave admins don't cause status mail to be sent to anybody
5850 (BotMaster.forceBuild): same. this method is deprecated.
5851 (DebugPerspective.perspective_forceBuild): same, use IControl.
5852 (DebugPerspective.perspective_fakeChange): use IControl..
5853 (Dispatcher.requestAvatar): .. so don't set .changemaster
5855 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5856 parameter to avoid confusion with the name of the builder
5859 * buildbot/status/mail.py: refine comment about needing 2.3
5861 * buildbot/status/html.py: move all imports to the top
5863 * buildbot/test/test_control.py: test new interfaces
5864 * buildbot/test/test_run.py (Status): handle new interfaces
5865 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5867 * buildbot/process/base.py (BuildControl): implement IBuildControl
5868 and its lonely getStatus() method
5870 * buildbot/process/builder.py (BuilderControl): implement
5871 IBuilderControl, obtained by adapting the Builder instance
5872 (Builder.startBuild): return a BuilderControl instead of a
5873 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5874 accomplish the same thing.
5876 * buildbot/master.py: move all import statements to the top
5877 (Control): implement IControl, obtained by adapting the
5878 BuildMaster instance.
5880 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5881 IBuildControl. These are used to force builds. Eventually they
5882 will provide ways to reconfigure the Builders, pause or abandon a
5883 Build, and perhaps control the BuildMaster itself.
5885 2004-09-26 Brian Warner <warner@lothar.com>
5887 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5888 ends up comparing us against something without a .__class__
5890 2004-09-24 Brian Warner <warner@lothar.com>
5892 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5895 * Makefile: add 'deb-snapshot' target, to create a timestamped
5898 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5900 2004-09-23 Brian Warner <warner@lothar.com>
5902 * buildbot/__init__.py (version): move version string here
5903 * setup.py: get version string from buildbot.version
5904 * buildbot/status/html.py (WaterfallStatusResource.body): add
5905 buildbot version to the page footer
5906 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5909 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5910 slaves, let the second know where the first one is coming from
5911 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5912 see our exceptions. It would be nice if there were a way to just
5913 send them the exception type and value, not the full traceback.
5916 * buildbot/status/mail.py (MailNotifier): add a new argument
5917 sendToInterestedUsers=, which can be set to False to disable the
5918 usual send-to-blamelist behavior.
5919 (top): handle python-2.2 which has no email.MIMEMultipart
5920 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5921 (MailNotifier.disownServiceParent): unsubscribe on removal
5923 * buildbot/test/test_status.py (Mail.testBuild2): test it
5926 * buildbot/status/progress.py (Expectations.wavg): tolerate
5927 current=None, which happens when steps start failing badly
5928 * buildbot/test/test_status.py (Progress.testWavg): test for it
5930 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5931 doesn't understand args['revision'], emit a warning instead of
5932 bailing completely. Updating to -rHEAD is probably close enough.
5934 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5936 * buildbot/test/test_status.py: at least import bb.status.client
5937 even if we don't have any test coverage for it yet
5939 * contrib/svn_buildbot.py: don't require python2.3
5940 (main): wait, do require it (for sets.py), but explain how to
5941 make it work under python2.2
5943 2004-09-23 Brian Warner <warner@lothar.com>
5945 * contrib/svn_buildbot.py: include the revision number in the Change
5947 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5948 using util.now() because FreshCVS is a realtime service
5950 * buildbot/status/event.py: delete dead code
5951 * buildbot/process/step.py: don't import dead Event class
5952 * buildbot/process/step_twisted.py: same
5953 * buildbot/status/builder.py: same
5954 * buildbot/status/client.py: same
5956 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5958 * buildbot/changes/changes.py (Change): set .when from an __init__
5959 argument (which defaults to now()), rather than having
5960 ChangeMaster.addChange set it later.
5961 (ChangeMaster.addChange): same
5963 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5964 (parseSyncmail): same. Just use util.now() for now.
5965 (parseBonsaiMail): parse the timestamp field for when=
5967 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5968 instead of setting .when after the fact
5972 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5973 results when the target project uses retrial. Still under
5975 * buildbot/test/test_trial.py: same
5977 2004-09-21 Brian Warner <warner@lothar.com>
5979 * buildbot/status/mail.py (MailNotifier.__init__): include
5980 success/warnings/failure in the Subject line
5981 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5982 use step.logname for the addLogs=True attachment filenames
5983 * buildbot/test/test_status.py (Mail): test Subject lines
5984 (Mail.testLogs): test attachment filenames
5986 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5987 accept a 'who' argument from the debug tool
5988 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5989 * contrib/debug.glade: add text box to set 'who'
5991 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5992 .getBuilderName with .getBuilder().getName(), more flexible
5993 (IStatusLog.getName): logs have short names, but you can prefix
5994 them with log.getStep().getName() to make them more useful
5995 * buildbot/status/builder.py: same
5996 * buildbot/status/client.py: same
5997 * buildbot/status/html.py: same
5998 * buildbot/test/test_run.py (Status.testSlave): same
5999 * buildbot/process/step.py: tweak logfile names
6001 * buildbot/status/mail.py (MailNotifier): add lookup, change
6002 argument to extraRecipients. The notifier is now aimed at sending
6003 mail to the people involved in a particular build, with additional
6004 constant recipients as a secondary function.
6006 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6007 including slow-lookup and failing-lookup. Make sure the blamelist
6008 members are included.
6010 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6011 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6012 (IBuildStatus.getInterestedUsers): new method
6013 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6014 * buildbot/status/client.py (remote_getResponsibleUsers): same
6015 * buildbot/status/html.py (StatusResourceBuild.body): same
6016 * buildbot/test/test_run.py (Status.testSlave): same
6018 2004-09-20 Brian Warner <warner@lothar.com>
6020 * docs/users.xhtml: update concepts
6022 * Makefile: add a convenience makefile, for things like 'make
6023 test'. It is not included in the source tarball.
6025 2004-09-16 Brian Warner <warner@lothar.com>
6027 * NEWS: mention /usr/bin/buildbot, debian/*
6029 * debian/*: add preliminary debian packaging. Many thanks to
6030 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6031 it considerably since it left their hands, I am responsible for
6032 all breakage that's resulted.
6034 * bin/buildbot: create a top-level 'buildbot' command, to be
6035 installed in /usr/bin/buildbot . For now it's just a simple
6036 frontend to mktap/twistd/kill, but eventually it will be the entry
6037 point to the 'try' command and also a status client. It is also
6038 intended to support the upcoming debian-packaging init.d scripts.
6039 * buildbot/scripts/runner.py: the real work is done here
6040 * buildbot/scripts/__init__.py: need this too
6041 * buildbot/scripts/sample.cfg: this is installed in new
6042 buildmaster directories
6043 * setup.py: install new stuff
6045 2004-09-15 Brian Warner <warner@lothar.com>
6047 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6048 'file:' schema (the version shipped with OS-X was built without the
6050 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6051 updates the log-timestamp, to make sure it isn't still running after
6054 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6055 values to the config file.
6056 * docs/examples/hello.cfg: add examples
6057 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6058 * buildbot/status/builder.py (Status.getProjectURL): implement them
6059 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6060 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6061 * buildbot/status/html.py (WaterfallStatusResource): display them
6064 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6065 certain error cases don't suffer a secondary exception.
6066 (top): Skip tests if the corresponding VC tool is not installed.
6068 * buildbot/process/factory.py (Trial): introduce separate
6069 'buildpython' and 'trialpython' lists, since trialpython=[] is
6070 what you want to invoke /usr/bin/python, whereas ./setup.py is
6071 less likely to be executable. Add env= parameter to pass options
6072 to test cases (which is how I usually write tests, I don't know if
6073 anyone else does it this way).
6075 * buildbot/process/step_twisted.py (Trial): handle python=None.
6076 Require 'testpath' be a string, not a list. Fix tests= typo.
6077 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6079 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6080 way to deal with the possibility of removing the disconnect notify
6082 (CVS): add a 'login' parameter to give a password to 'cvs login',
6083 commonly used with pserver methods (where pw="" or pw="guest")
6085 * buildbot/slave/commands.py (SourceBase): move common args
6086 extraction and setup() to __init__, so everything is ready by the
6087 time setup() is called
6088 (CVS.start): call 'cvs login' if a password was supplied
6089 (ShellCommand): special-case PYTHONPATH: prepend the master's
6090 value to any existing slave-local value.
6092 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6093 don't have a remote, mark the builder as Offline. This whole
6094 function should probably go away and be replaced by individual
6096 (Builder.buildFinished): return the results to the build-finished
6097 deferred callback, helps with testing
6099 2004-09-14 Brian Warner <warner@lothar.com>
6101 * buildbot/test/test_vc.py: put all the repositories needed to run
6102 the complete tests into a single small (1.3MB) tarball, so I can
6103 make that tarball available on the buildbot web site. Test HTTP
6104 access (for Arch and Darcs) by spawning a temporary web server
6105 while the test runs.
6107 * docs/users.xhtml: new document, describe Buildbot's limited
6108 understanding of different human users
6110 * buildbot/test/test_vc.py: rearrange test cases a bit
6112 * buildbot/process/step_twisted.py (Trial): handle testpath=
6113 * buildbot/process/factory.py (Trial): update to use step.Trial
6115 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6117 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6118 the overall build text (which gives you 'failed 2 tests' rather
6120 (BuildStepStatus.text2): default to [], not None
6122 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6125 2004-09-12 Brian Warner <warner@lothar.com>
6127 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6128 log the whole exception if it's just an AttributeError (old slave)
6130 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6131 so (e.g.) sub-commands can be run in the right directory.
6132 (ShellCommand.start): accept an optional errorMessage= argument
6133 to make life easier for SVN.start
6134 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6136 (ShellCommand.start): move ['dir'] compatibility hack..
6137 (RemoteShellCommand.start): .. to here so everyone can use it
6139 * buildbot/process/step_twisted.py (Trial): use .workdir
6141 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6142 text displayed when debuild fails completely
6143 (Trial): snarf _trial_temp/test.log from the slave and display it
6145 2004-09-11 Brian Warner <warner@lothar.com>
6147 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6149 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6150 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6152 * buildbot/process/step.py (ShellCommand): call .createSummary
6153 before .evaluateCommand instead of the other way around. This
6154 makes it slightly easier to count warnings and then use that to
6155 set results=WARNINGS
6156 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6158 * buildbot/process/base.py (Build.buildFinished): update status
6159 before doing progress. It's embarrassing for the build to be stuck
6160 in the "building" state when an exceptions occurs elsewhere..
6162 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6163 python2.2 doesn't have 'sum'
6165 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6166 to prevent clients from accidentally sorting it
6168 * buildbot/master.py (Manhole): add username/password
6169 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6170 c['manholePort'], deprecate old usage
6171 * docs/config.xhtml: document c['manhole']
6172 * docs/examples/hello.cfg: show example of using a Manhole
6175 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6176 pretend the slave is up to date
6178 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6179 the module, overlaps with 'log', the local variable
6181 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6183 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6184 new method to let Steps find out the version of their
6185 corresponding SlaveCommand.
6186 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6187 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6188 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6190 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6191 (Arch.startVC): same
6192 (P4Sync.startVC): same
6194 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6195 Deferred so we can catch errors in remote_startCommand
6196 (RemoteShellCommand.start): same
6198 * docs/examples/twisted_master.cfg: update sample config file
6200 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6201 after connectionMade() is called, not before. Close stdin at that
6204 * buildbot/process/process_twisted.py: update to use Trial, clean
6205 up argument passing (move to argv arrays instead of string
6208 * buildbot/process/step_twisted.py (Trial): new step to replace
6209 RunUnitTests, usable by any trial-using project (not just
6210 Twisted). Arguments have changed, see the docstring for details.
6212 * buildbot/process/base.py (Build.startBuild): this now returns a
6213 Deferred. Exceptions that occur during setupBuild are now
6214 caught better and lead to fewer build_status weirdnesses, like
6215 finishing a build that was never started.
6216 (Build.buildFinished): fire the Deferred instead of calling
6217 builder.buildFinished directly. The callback argument is this
6218 Build, everything else can be extracted from it, including the
6219 new build.results attribute.
6220 * buildbot/process/builder.py (Builder.startBuild): same
6221 (Builder.buildFinished): same, extract results from build
6223 * buildbot/process/step.py (ShellCommands): remove dead code
6225 2004-09-08 Brian Warner <warner@lothar.com>
6227 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6228 doesn't try to use the leftover patched workdir
6229 (SourceStamp): test source-stamp computation for CVS and SVN
6231 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6232 patched workdir ('touch .buildbot-patched') so we don't try to
6234 (SourceBase.start): add ['revision'] for all Source steps
6235 (CVS): change args: use ['branch'] for -r, remove ['files']
6236 (CVS.buildVC): fix revision/branch stuff
6237 (SVN): add revision stuff
6239 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6240 kwargs (except 'workdir') to avoid silent spelling errors
6241 (ShellCommand.__init__): same
6242 (Source): new base class for CVS/SVN/etc. Factor out everything
6243 common, add revision computation (perform the checkout with a -D
6244 DATE or -r REVISION that gets exactly the sources described by the
6245 last Change), overridable with step.alwaysUseLatest. Add patch
6246 handling (build.getSourceStamp can trigger the use of a base
6247 revision and a patch).
6248 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6249 * docs/steps.xhtml: update docs
6250 * docs/source.xhtml: mention .checkoutDelay
6251 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6253 * buildbot/process/base.py (Build.setSourceStamp): add a
6254 .sourceStamp attribute to each Build. If set, this indicates that
6255 the build should be done with something other than the most
6256 recent source tree. This will be used to implement "try" builds.
6257 (Build.allChanges): new support method
6258 (Build.lastChangeTime): remove, functionality moved to Source steps
6259 (Build.setupBuild): copy the Step args before adding ['workdir'],
6260 to avoid modifying the BuildFactory (and thus triggering spurious
6264 * buildbot/status/html.py: rename s/commits/changes/
6265 (StatusResourceChanges): same
6266 (CommitBox.getBox): same, update URL
6267 (WaterfallStatusResource): same
6268 (StatusResource.getChild): same
6270 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6271 * contrib/debug.glade: add optional 'revision' to the fakeChange
6273 * buildbot/changes/changes.py (html_tmpl): display .revision
6274 (ChangeMaster.addChange): note .revision in log
6275 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6276 accept a ['revision'] attribute
6278 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6280 * buildbot/master.py (BotMaster.getPerspective): update the
6281 .connected flag in SlaveStatus when it connects
6282 (BotMaster.detach): and when it disconnects
6283 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6284 (BuildMaster.loadConfig_Builders): walk old list correctly
6286 * buildbot/test/test_config.py: fix prefix= usage
6288 2004-09-06 Brian Warner <warner@lothar.com>
6292 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6293 poll a P4 depot looking for recent changes. Thanks to Dave
6294 Peticolas for the contribution. Probably needs some testing after
6297 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6298 requires manual client setup for each buildslave. Rather
6299 experimental. Thanks again to Dave Peticolas.
6300 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6302 * buildbot/changes/changes.py (Change): add a .revision attribute,
6303 which will eventually be used to generate source-stamp values.
6305 * buildbot/process/step.py (RemoteCommand.start): use
6306 notifyOnDisconnect to notice when we lose the slave, then treat it
6307 like an exception. This allows LogFiles to be closed and the build
6308 to be wrapped up normally. Be sure to remove the disconnect
6309 notification when the step completes so we don't accumulate a
6310 bazillion such notifications which will fire weeks later (when the
6311 slave finally disconnects normally). Fixes SF#915807, thanks to
6312 spiv (Andrew Bennetts) for the report.
6313 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6314 really isn't Logged- specific
6315 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6316 header, since it's almost always going to be appended to an
6318 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6319 update test to handle use of notifyOnDisconnect
6321 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6322 don't clear .ETA and .currentBuild when going offline, let the
6323 current build clean up after itself
6325 * buildbot/process/builder.py (Builder.detached): wait a moment
6326 before doing things like stopping the current build, because the
6327 current step will probably notice the disconnect and cleanup the
6329 * buildbot/test/test_run.py (Status.tearDown): update test to
6330 handle asynchronous build-detachment
6332 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6334 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6335 hush a debug message
6337 2004-09-05 Brian Warner <warner@lothar.com>
6339 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6340 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6341 kernels do this: the fcntl module has the F_NOTIFY constant, but
6342 the kernel itself doesn't support the operation. Thanks to Olly
6343 Betts for spotting the problem.
6345 * buildbot/process/step.py (Darcs): new source-checkout command
6346 (Arch): new source-checkout command
6347 (todo_P4): fix constructor syntax, still just a placeholder
6348 * buildbot/test/test_vc.py (VC.testDarcs): test it
6349 (VC.testDarcsHTTP): same, via localhost HTTP
6351 (VC.testArchHTTP): same
6352 * NEWS: mention new features
6354 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6355 which tells the step to stash stdout text locally (in .stdout).
6356 Slave-side Commands can use this to make decisions based upon the
6357 output of the the ShellCommand (not just the exit code).
6358 (Darcs): New source-checkout command
6359 (Arch): New source-checkout command, uses .keepStdout in one place
6360 where it needs to discover the archive's default name.
6362 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6363 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6364 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6366 * buildbot/process/step.py (ShellCommand.describe): add an
6367 alternate .descriptionDone attribute which provides descriptive
6368 text when the step is complete. .description can be ["compiling"],
6369 for use while the step is running, then .descriptionDone can be
6370 ["compile"], used alone when the step succeeds or with "failed" when
6371 it does not. Updated other steps to use the new text.
6372 * buildbot/process/step_twisted.py: same
6373 * buildbot/test/test_run.py: update tests to match
6375 2004-08-30 Brian Warner <warner@lothar.com>
6377 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6378 (CVS.__init__): send 'patch' argument to slave
6379 (CVS.start): don't create the LoggedRemoteCommand until start(),
6380 so we can catch a .patch added after __init__
6381 (SVN.__init__): add 'patch' to SVN too
6384 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6385 argument, to let commands push data into the process' stdin pipe.
6386 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6387 is in use, since closing a PTY doesn't really affect the process
6388 in the right way (in particular, I couldn't run /usr/bin/patch
6390 (SourceBase.doPatch): handle 'patch' argument
6392 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6395 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6396 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6398 * buildbot/master.py (BotPerspective.got_commands): get command
6399 versions from slave, give to each builder
6400 * buildbot/process/builder.py (Builder.attached): stash slave
6401 command versions in .remoteCommands
6403 * docs/steps.xhtml: bring docs in-line with reality
6405 * buildbot/process/step.py (CVS.__init__): more brutal
6406 compatibility code removal
6407 (SVN.__init__): same
6409 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6410 (SlaveShellCommand.start): require ['workdir'] argument, remove
6411 the ['dir'] fallback (compatibility will come later)
6412 (SourceBase): update docs
6413 (SourceBase.start): remove ['directory'] fallback
6416 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6417 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6418 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6420 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6421 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6422 code.. I will figure out 0.5.0-compatibility hooks later)
6424 2004-08-30 Brian Warner <warner@lothar.com>
6426 * buildbot/process/process_twisted.py: rewrite in terms of new
6427 BuildFactory base class. It got significantly shorter. Yay
6430 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6431 work with the new "self.build isn't nailed down until we call
6432 step.start()" scheme: specifically, __init__ is called before the
6433 build has decided on which Changes are going in, so we don't scan
6434 build.allFiles() for .xhtml files until start()
6435 (HLint.commandComplete): use getText(), not getStdout()
6436 (RunUnitTests.start): same: don't use .build until start()
6437 (RunUnitTests.describe): oops, don't report (None) when using
6439 (RunUnitTests.commandComplete): use getText()
6440 (RunUnitTests.createSummary): same
6441 (BuildDebs.commandComplete): same
6443 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6444 set args['command'] until start(), since our BuildStep is allowed
6445 to change their mind up until that point
6446 (TreeSize.commandComplete): use getText(), not getStdout()
6448 * docs/examples/twisted_master.cfg: update to current standards
6450 * docs/factories.xhtml: update
6451 * buildbot/process/factory.py: implement all the common factories
6452 described in the docs. The Trial factory doesn't work yet, and
6453 I've probably broken all the process_twisted.py factories in the
6454 process. There are compatibility classes left in for things like
6455 the old BasicBuildFactory, but subclasses of them are unlikely to
6457 * docs/examples/glib_master.cfg: use new BuildFactories
6458 * docs/examples/hello.cfg: same
6460 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6461 explicit 'workdir' args
6463 * buildbot/process/base.py (BuildFactory): move factories to ..
6464 * buildbot/process/factory.py (BuildFactory): .. here
6465 * buildbot/process/process_twisted.py: handle move
6466 * buildbot/test/test_config.py: same
6467 * buildbot/test/test_run.py: same
6468 * buildbot/test/test_steps.py: same
6469 * buildbot/test/test_vc.py: same
6470 * docs/factories.xhtml: same
6472 * NEWS: mention config changes that require updating master.cfg
6474 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6475 argument to all steps that weren't given one already, pointing at
6476 the "build/" directory.
6478 * docs/examples/hello.cfg: remove explicit 'workdir' args
6480 * docs/factories.xhtml: document standard BuildFactory clases,
6481 including a bunch which are have not yet been written
6483 2004-08-29 Brian Warner <warner@lothar.com>
6485 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6486 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6487 buildbot.status.builder so they aren't quite so internal
6488 * buildbot/process/base.py, buildbot/process/builder.py: same
6489 * buildbot/process/maxq.py, buildbot/process/step.py: same
6490 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6491 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6492 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6494 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6495 to handle new getLogs()-returns-list behavior
6496 (StatusResourceBuildStep.getChild): same
6497 (StepBox.getBox): same
6498 (WaterfallStatusResource.phase0): same
6500 * docs/source.xhtml: document how Buildbot uses version-control
6501 systems (output side: how we get source trees)
6502 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6503 systems (input side: how we learn about Changes)
6505 * buildbot/master.py (Manhole): use ComparableMixin
6506 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6507 * buildbot/changes/mail.py (MaildirSource): same
6508 * buildbot/status/client.py (PBListener): same
6509 * buildbot/status/html.py (Waterfall): same
6510 * buildbot/status/words.py (IRC): same
6512 * NEWS: start describing new features
6514 * buildbot/status/mail.py (MailNotifier): finish implementation.
6515 The message body is still a bit sparse.
6516 * buildbot/test/test_status.py (Mail): test it
6518 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6519 and __hash__ methods I wind up adding everywhere. Specifically
6520 intended to support the buildbot config-file update scheme where
6521 we compare, say, the old list of IStatusTargets against the new
6522 one and don't touch something which shows up on both lists.
6523 * buildbot/test/test_util.py (Compare): test case for it
6525 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6526 return a list instead of a dict
6527 (IBuildStepStatus.getLogs): same. The idea is that steps create
6528 logs with vaguely unique names (although their uniqueness is not
6529 guaranteed). Thus a compilation step should create its sole
6530 logfile with the name 'compile', and contribute it to the
6531 BuildStatus. If a step has two logfiles, try to create them with
6532 different names (like 'test.log' and 'test.summary'), and only
6533 contribute the important ones to the overall BuildStatus.
6534 * buildbot/status/builder.py (Event.getLogs): same
6535 (BuildStepStatus): fix default .text and .results
6536 (BuildStepStatus.addLog): switch to list-like .getLogs()
6537 (BuildStepStatus.stepFinished): same
6538 (BuildStatus.text): fix default .text
6539 (BuildStatus.getLogs): temporary hack to return all logs (from all
6540 child BuildStepStatus objects). Needs to be fixed to only report
6541 the significant ones (as contributed by the steps themselves)
6542 * buildbot/test/test_run.py: handle list-like .getLogs()
6543 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6545 2004-08-28 Brian Warner <warner@lothar.com>
6547 * buildbot/process/builder.py (Builder.attached): serialize the
6548 attachment process, so the attach-watcher isn't called until the
6549 slave is really available. Add detached watchers too, which makes
6552 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6554 * buildbot/test/test_swap.py: remove dead code
6556 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6557 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6558 sort of as if the command being run exited with a -1. There may
6559 still be some holes in this scheme.
6560 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6561 -r option appears before the module list
6562 * buildbot/process/step.py (CVS): add 'revision' argument
6564 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6565 when sending updates or stepComplete messages to the master, since
6566 we don't currently care whether they arrive or not. When we revamp
6567 the master/slave protocol to really resume interrupted builds,
6568 this will need revisiting.
6569 (lostRemote): remove spurious print
6571 * buildbot/master.py (BotPerspective.attached): serialize the
6572 new-builder interrogation process, to make testing easier
6573 (BotMaster.waitUntilBuilderDetached): convenience function
6575 * buildbot/status/builder.py (BuilderStatus): prune old builds
6576 (BuildStatus.pruneSteps): .. and steps
6577 (BuildStepStatus.pruneLogs): .. and logs
6578 (BuilderStatus.getBuild): handle missing builds
6579 * buildbot/status/html.py (StatusResourceBuild.body): display build
6580 status in the per-build page
6581 (BuildBox.getBox): color finished builds in the per-build box
6583 2004-08-27 Brian Warner <warner@lothar.com>
6585 * buildbot/status/mail.py (MailNotifier): new notification class,
6588 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6589 variants of a common base class which handles all the mode= logic
6591 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6593 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6595 2004-08-26 Brian Warner <warner@lothar.com>
6597 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6600 * buildbot/test/test_run.py: update to new Logfile interface, new
6601 buildbot.slave modules
6602 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6604 * MANIFEST.in: new sample config file
6605 * docs/examples/hello.cfg: same
6607 * buildbot/process/step_twisted.py: remove dead import
6609 * buildbot/process/step.py (RemoteCommand.run): catch errors
6611 (RemoteCommand.remote_update): ignore updates that arrive after
6613 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6614 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6615 the responsibilities of the subclass's methods
6616 (BuildStep.failed): catch errors during failure processing
6617 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6618 (CVS): move to a mode= argument (described in docstring), rather
6619 than the ungainly clobber=/export=/copydir= combination.
6620 (SVN): add mode= functionality to SVN too
6621 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6623 * buildbot/process/base.py (Build.startNextStep): catch errors
6624 during s.startStep()
6626 * buildbot/clients/base.py: update to new PB client interface.
6627 gtkPanes is still broken
6629 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6630 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6631 * setup.py: add buildbot.slave module
6632 * buildbot/bb_tap.py: handle move
6633 * buildbot/slave/registry.py: place to register commands, w/versions
6634 * buildbot/slave/bot.py: major simplifications
6635 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6636 instead of a fixed table. Eventually this will make the slave more
6637 extensible. Use 'start' method on the command, not .startCommand.
6638 Fix unsafeTracebacks handling (I think).
6639 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6640 helper class with a .start method that returns a Deferred.
6641 SlaveShellCommand is the form reached by the buildmaster. Commands
6642 which use multiple ShellCommands can just chain them as Deferreds,
6643 with some helper methods in Command (_abandonOnFailure and
6644 _checkAbandoned) to bail on rc!=0.
6645 (CVSCommand): prefer new mode= argument
6646 (SVNFetch): add mode= argument
6648 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6649 put a useful reason string on the build
6651 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6652 core functionality into an IStatusLog object
6653 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6654 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6655 (StatusResourceBuild.body): use proper accessor methods
6656 * buildbot/status/client.py (RemoteLog): PB-access goes here
6657 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6658 which delivers log contents too
6659 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6660 * buildbot/status/event.py: remove old Logfile completely
6662 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6663 subscription interface for IStatusLog subscriptions just like all
6664 other the status subscriptions
6665 (IStatusReceiver.logChunk): method called on subscribers
6667 2004-08-24 Brian Warner <warner@lothar.com>
6669 * buildbot/process/builder.py (Builder._pong): oops, ping response
6670 includes a result (the implicit None returned by remote_print).
6671 Accept it so the _pong method handles the response correctly.
6673 2004-08-06 Brian Warner <warner@lothar.com>
6675 * buildbot/test/test_config.py: update IRC, PBListener tests
6677 * buildbot/status/client.py (StatusClientPerspective): total
6678 rewrite to match new IStatus interfaces. New subscription scheme.
6679 There are still a few optimizations to make (sending down extra
6680 information with event messages so the client doesn't have to do a
6681 round trip). The logfile-retrieval code is probably still broken.
6682 Moved the PB service into its own port, you can no longer share a
6683 TCP socket between a PBListener and, say, the slaveport (this
6684 should be fixed eventually).
6685 * buildbot/clients/base.py (Client): revamp to match. still needs
6686 a lot of work, but basic event reporting works fine. gtkPanes is
6689 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6690 instance talks to a single irc server. Threw out all the old
6691 multi-server handling code. Still need to add back in
6692 builder-control (i.e. "force build")
6694 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6695 more random text to the as-yet-unreachable per-step page
6697 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6698 rename to stepETAUpdate
6699 (BuildStatus.subscribe): add build-wide ETA updates
6700 (BuilderStatus.getState): remove more cruft
6701 (BuilderStatus.getCurrentBuild): remove more cruft
6702 (BuilderStatus.buildStarted): really handle tuple-subscription
6703 * buildbot/test/test_run.py (Status.testSlave): handle the
6704 stepETAUpdate rename
6706 * buildbot/master.py (BuildMaster): don't add a default
6707 StatusClientService. Don't add a default IrcStatusFactory. Both
6708 are now added through c['status'] in the config file. c['irc'] is
6709 accepted for backwards compatibility, the only quirk is you cannot
6710 use c['irc'] to specify IRC servers on ports other than 6667.
6712 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6713 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6714 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6715 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6718 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6719 the buildmaster to re-read its config file
6722 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6723 find out the port our server is running on
6724 (WebTest.test_webPathname_port): same
6726 * buildbot/test/test_config.py (testWebPortnum): test it
6727 (testWebPathname): ditto
6729 * docs/config.xhtml: document new c['status'] configuration option
6731 * buildbot/status/html.py (Waterfall): new top-level class which
6732 can be added to c['status']. This creates the Site as well as the
6733 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6734 reachable as .parent, for everything.
6736 * buildbot/master.py (Manhole): make it a normal service Child
6737 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6738 webPathname. It will eventually replace c['irc'] and the implicit
6739 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6740 in as (deprecated) backward compatibility hooks for now.
6743 * buildbot/process/builder.py (Builder.buildFinished): don't
6744 inform out builder_status about a finished build, as it finds out
6745 through its child BuildStatus object
6747 * buildbot/status/html.py: extensive revamp. Use adapters to make
6748 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6749 have both starting and finishing times and adjust the waterfall
6750 display accordingly, using spacers if necessary. Use SlaveStatus
6751 to get buildslave info.
6752 (StatusResourceBuildStep): new just-one-step resource, used to get
6753 logfiles. No actual href to it yet.
6755 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6756 the time being, until I get the file-naming scheme right
6758 * buildbot/status/builder.py (Event): clean started/finished names
6759 (BuildStatus.isFinished): .finished is not None is the right test
6760 (BuildStatus.buildStarted): track started/finished times ourselves
6761 (BuilderStatus.getSlave): provide access to SlaveStatus object
6762 (BuilderStatus.getLastFinishedBuild): all builds are now in
6763 .builds, even the currently-running one. Accomodate this change.
6764 (BuilderStatus.eventGenerator): new per-builder event generator.
6765 Returns BuildStepStatus and BuildStatus objects, since they can
6766 both be adapted as necessary.
6767 (BuilderStatus.addEvent): clean up started/finished attributes
6768 (BuilderStatus.startBuild,finishBuild): remove dead code
6769 (SlaveStatus): new object to provide ISlaveStatus
6771 * buildbot/process/step.py (ShellCommand.getColor): actually
6772 return the color instead of setting it ourselves
6773 (CVS.__init__): pull .timeout and .workdir options out of
6774 **kwargs, since BuildStep will ignore them. Without this neither
6775 will be sent to the slave correctly.
6776 (SVN.__init__): same
6778 * buildbot/process/builder.py (Builder): move flags to class-level
6780 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6781 SlaveStatus handle that
6783 * buildbot/process/base.py (Build.firstEvent): remove dead code
6784 (Build.stopBuild): bugfix
6786 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6788 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6789 (ChangeMaster.eventGenerator): yield Changes, since there are now
6790 Adapters to turn them into HTML boxes
6792 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6793 (BotPerspective.attached): feed a SlaveStatus object
6794 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6795 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6797 * buildbot/interfaces.py: API additions
6798 (ISlaveStatus): place to get slave status
6800 2004-08-04 Brian Warner <warner@lothar.com>
6802 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6803 the delay finishes, so the step is marked as SUCCESS
6805 * buildbot/test/test_run.py (Status.testSlave): cover more of
6806 IBuildStatus and IBuildStepStatus
6808 * buildbot/status/progress.py (StepProgress): move some flags to
6809 class-level attributes
6810 (StepProgress.remaining): if there are no other progress metrics
6811 to go by, fall back to elapsed time
6812 (StepProgress.setExpectations): take a dict of metrics instead of
6814 (BuildProgress.setExpectationsFrom): pull expectations from the
6815 Expectations, instead of having it push them to the BuildProgress
6816 (Expectations): move some flags to class-level attributes
6817 (Expectations.__init__): copy per-step times from the
6819 (Expectations.expectedBuildTime): new method for per-build ETA
6821 * buildbot/status/event.py (Logfile): move some flags to
6822 class-level attributes
6823 (Logfile.logProgressTo): better method name, let step set the
6824 progress axis name (instead of always being "output")
6826 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6827 times directly, rather than depending upon the (possibly missing)
6828 .progress object. Use 'None' to indicate "not started/finished
6830 (BuildStepStatus.getExpectations): oops, return the full list of
6832 (BuilderStatus._buildFinished): append finished builds to .builds
6834 * buildbot/process/step.py (BuildStep): add separate .useProgress
6835 flag, since empty .progressMetrics[] still implies that time is a
6837 (CVS): set up the cmd in __init__, instead of waiting for start()
6839 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6840 calculation, this will eventually turn into a proper sourceStamp
6841 (Build.setupBuild): tell the Progress to load from the Expectations,
6842 instead of having the Expectations stuff things into the Progress
6843 (Build.buildException): add a build-level errback to make sure the
6844 build's Deferred fires even in case of exceptions
6846 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6848 * buildbot/process/builder.py (Builder.forceBuild): convey the
6849 reason instead of creating a fake Change
6851 * docs/examples/twisted_master.cfg: update to match reality
6853 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6854 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6855 fix or remove broken/breaking tests
6857 * buildbot/status/event.py (Logfile.__len__): remove evil method
6859 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6860 missing .build, for test convenience
6862 * buildbot/process/step_twisted.py: import fixes
6864 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6866 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6867 .statusbag reference
6869 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6870 connection at shutdown, and stop it from reconnecting
6872 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6873 chase down remote-execution bugs
6875 * buildbot/process/step.py: more fixes, remove
6876 BuildStep.setStatus()
6877 * buildbot/status/builder.py: move setStatus() functionality into
6879 * buildbot/status/event.py: minor fixes
6881 2004-08-03 Brian Warner <warner@lothar.com>
6883 * buildbot/process/base.py, buildbot/process/builder.py
6884 * buildbot/process/step.py, buildbot/status/builder.py
6885 * buildbot/status/event.py, buildbot/test/test_run.py:
6886 fix status delivery, get a basic test case working
6887 * buildbot/master.py: finish implementing basic status delivery,
6888 temporarily disable HTML/IRC/PB status sources
6890 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6892 * buildbot/status/progress.py (BuildProgress): remove dead code
6894 * buildbot/interfaces.py
6895 * buildbot/process/base.py, buildbot/process/builder.py
6896 * buildbot/process/step.py, buildbot/process/step_twisted.py
6897 * buildbot/status/builder.py: Complete overhaul of the all
6898 status-delivery code, unifying all types of status clients (HTML,
6899 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6900 look like. This commit is a checkpointing of the work-in-progress:
6901 the input side is mostly done (Builders/Builds sending status
6902 to the BuilderStatus/BuildStatus objects), but the output side has
6903 not yet been started (HTML resources querying BuilderStatus
6904 objects). Things are probably very broken right now and may remain
6905 so for several weeks, I apologize for the disruption.
6907 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6908 HTML as the log's contents. Currently used for exception tracebacks.
6909 * buildbot/status/progress.py: minor spelling changes
6911 2004-08-02 Brian Warner <warner@lothar.com>
6913 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6914 in mozilla. Also added stylesheets copied from Twisted's docs.
6915 Remember that these files are meant to be run through Lore first.
6916 Thanks to Philipp Frauenfelder for the fixes.
6917 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6918 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6919 * docs/template.tpl: added a Lore template
6921 2004-07-29 Brian Warner <warner@lothar.com>
6923 * buildbot/interfaces.py: revamp status delivery. This is the
6924 preview: these are the Interfaces that will be provided by new
6925 Builder code, and to which the current HTML/IRC/PB status
6926 displayers will be adapted.
6928 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6929 on the SlaveBuilder, not the Bot.
6930 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6932 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6933 set .usePTY on the FakeSlaveBuilder
6935 2004-07-25 Brian Warner <warner@lothar.com>
6937 * buildbot/changes/freshcvs.py: add some debug log messages
6938 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6939 disabled 'setFilter' syntax
6940 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6941 don't end with a slash
6943 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6945 * setup.py: bump to 0.5.0+ while between releases
6947 2004-07-23 Brian Warner <warner@lothar.com>
6949 * setup.py (version): Releasing buildbot-0.5.0
6951 2004-07-23 Brian Warner <warner@lothar.com>
6953 * README: update for 0.5.0 release
6955 * NEWS: update for 0.5.0 release
6957 2004-07-22 Brian Warner <warner@lothar.com>
6959 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6960 mktap-time configuration flag (--usepty=1, --usepty=0)
6961 * buildbot/bot.py: same
6963 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6964 an 'info' directory being unwanted
6966 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6967 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6968 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6969 and earlier), use a FreshCVSSourceOldcred instead.
6970 (test): simple test routine: connect to server, print changes
6972 * buildbot/changes/changes.py (Change.getTime): make it possible
6973 to print un-timestamped changes
6975 * buildbot/master.py (makeApp): delete ancient dead code
6976 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6977 * buildbot/test/test_config.py (testFindConfigFile): test it
6979 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6980 instead of win32 one
6983 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6984 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6987 * buildbot/process/base.py (Builder.__init__): change constructor
6988 to accept a dictionary of config data, rather than discrete
6989 name/slave/builddir/factory arguments
6991 * docs/examples/twisted_master.cfg: update to new syntax
6992 * docs/examples/glib_master.cfg: same
6993 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6994 rough tests of the new syntax
6997 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6998 to be an int, which means "run a web.distrib sub-server on a TCP
6999 port". This lets you publish the buildbot status page to a remote
7000 twisted.web server (using distrib.ResourceSubscription). Also
7001 rename the local attributes used to hold these web things so
7002 they're more in touch with reality.
7003 * buildbot/test/test_web.py: test webPortnum and webPathname
7004 * docs/config.xhtml: document this new use of webPathname
7006 * docs/config.xhtml: new document, slightly ahead of reality
7008 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7009 'prefix' handling: treat it as a simple string to check with
7010 .startswith, instead of treating it as a directory. This allows
7011 sub-directories to be used. If you use prefix=, you should give it
7012 a string that starts just below the CVSROOT and ends with a slash.
7013 This prefix will be stripped from all filenames, and filenames
7014 which do not start with it will be ignored.
7016 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7018 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7019 and --exclude (inverse of --include). SVN post-commit hooks
7020 now have total control over which changes get sent to buildbot and which
7023 2004-07-10 Brian Warner <warner@lothar.com>
7025 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7026 test case to match new API
7028 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7029 which crashed HTML display when self.entries=[] (needed to
7030 distinguish between [], which means "no entries yet", and None,
7031 which means "the entries have been swapped out to disk, go fetch
7034 2004-07-04 Brian Warner <warner@lothar.com>
7036 * buildbot/process/step_twisted.py (countFailedTests): Count
7037 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7038 10kb from the end because any import errors are wedged there and
7039 they would make us think the test log was unparseable.
7040 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7042 2004-06-26 Brian Warner <warner@lothar.com>
7044 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7045 delete-*.pyc command into an actual BuildStep, so we can label it
7047 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7048 (FullTwistedBuildFactory): same
7050 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7052 * contrib/fakechange.py: Add an errback when sending the fake
7053 change, so we know it didn't work.
7055 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7057 * buildbot/process/step_twisted.py: Delete *.pyc files before
7058 calling trial, so it doesn't catch any old .pyc files whose .py
7059 files have been moved or deleted.
7061 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7062 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7063 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7064 instead of ["twisted.test"], so that the end result is "trial -R
7067 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7068 regular expression to match filenames that should be ignored when
7069 changed. Also add a --revision parameter that specifies the
7070 revision to examine, which is useful for debugging.
7072 2004-06-25 Brian Warner <warner@lothar.com>
7074 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7075 summary of warnings (like DeprecationWarnings), next to the
7078 2004-05-13 Brian Warner <warner@lothar.com>
7080 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7081 we now have a w32 build slave courtesy of Mike Taylor.
7083 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7084 so broken. Fixed a race condition that tripped up interlocked
7085 builds and caused the status to be stuck at "Interlocked" forever.
7086 The twisted buildbot's one interlocked build just so happened to
7087 never hit this case until recently (the feeding builds both pass
7088 before the interlocked build is attempted.. usually it has to wait
7090 (Builder._pong_failed): fix method signature
7092 * setup.py: bump to 0.4.3+ while between releases
7094 2004-04-30 Brian Warner <warner@lothar.com>
7096 * setup.py (version): Releasing buildbot-0.4.3
7098 2004-04-30 Brian Warner <warner@lothar.com>
7100 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7102 * README: update for 0.4.3 release
7104 * NEWS: update for 0.4.3 release
7106 * buildbot/master.py (BuildMaster.__getstate__): make sure
7107 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7109 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7110 .trial as a class attribute, for upgrade from 0.4.2
7112 * buildbot/changes/changes.py (Change.links): add .links for
7115 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7116 .textWatchers and .htmlWatchers at save time, since they are both
7117 volatile, should allow smooth 0.4.2 upgrade
7119 * buildbot/process/step.py (CVS.finishStatus): catch failed
7120 CVS/SVN commands so we can make the status box red
7122 2004-04-29 Brian Warner <warner@lothar.com>
7124 * buildbot/changes/freshcvs.py
7125 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7126 code to do setFilter(), which tells the freshcvs daemon to not
7127 send us stuff that we're not interested in. I will uncomment it
7128 when a new version of CVSToys is available in which setFilter()
7129 actually works, and I get a chance to test it better.
7131 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7133 * buildbot/master.py (Dispatcher): use a registration scheme
7134 instead of hardwired service names
7135 (BuildMaster): keep track of the Dispatcher to support
7138 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7139 PBChangeSource class instead of having it be an undocumented
7140 internal feature of the ChangeMaster. Split out the code into a
7142 * buildbot/changes/pb.py (PBChangeSource): same
7143 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7145 * docs/{factories|sources|steps}.xhtml: document some pieces
7147 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7148 using FCMaildirSource
7149 (f23osx): update OS-X builder to use python2.3, since the slave
7150 was updated to Panther (10.3.3)
7152 2004-03-21 Brian Warner <warner@lothar.com>
7154 * buildbot/process/process_twisted.py: factor out doCheckout, change
7155 to use SVN instead of CVS
7157 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7158 an SVN subclass easier
7159 (BasicSVN): subclass which uses Subversion instead of CVS
7161 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7163 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7165 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7167 2004-02-25 Brian Warner <warner@lothar.com>
7169 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7170 is now either a list (which is passed to spawnProcess directly) or
7171 a string (which gets passed to /bin/sh -c). This removes the useSH
7172 flag and the ArgslistCommand class. Also send status header at the
7173 start and end of each command, instead of having the master-side
7175 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7176 -r'. Update to use list-based arguments.
7177 (SVNFetch): use list-based arguments, use ['dir'] argument to
7179 * buildbot/test/test_steps.py (Commands): match changes
7181 * buildbot/process/step.py (InternalShellCommand.words): handle
7183 (SVN): inherit from CVS, cleanup
7185 * buildbot/status/event.py (Logfile.content): render in HTML, with
7186 stderr in red and headers (like the name of the command we're
7187 about to run) in blue. Add link to a second URL (url + "?text=1")
7188 to get just stdout/stderr in text/plain without markup. There is
7189 still a problem with .entries=None causing a crash, it seems to occur
7190 when the logfile is read before it is finished.
7192 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7193 timeout to the keepalives, and use it to explicitly do a
7194 loseConnection instead of waiting for TCP to notice the loss. This
7195 ought to clear up the silent-lossage problem.
7196 (unsafeTracebacks): pass exception tracebacks back to the master,
7197 makes it much easier to debug problems
7199 2004-02-23 Brian Warner <warner@lothar.com>
7201 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7202 the whole command to /bin/sh instead of execve [Johan Dahlin]
7203 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7204 '-r HEAD' [Johan Dahlin]
7205 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7207 * buildbot/changes/changes.py (Change): add links= argument, add
7208 asHTML method [Johan Dahlin]. Modified to make a bit more
7209 XHTMLish. Still not sure how to best use links= .
7211 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7212 Change.asHTML to display the change, not asText
7214 * buildbot/status/html.py (StatusResourceBuilder): web button to
7217 * buildbot/test/test_run.py: test to actually start a buildmaster
7220 * MANIFEST.in: bring back accidentally-dropped test helper files
7222 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7223 that require cvstoys if it is not installed
7225 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7226 values of "bin/trial" [Dave Peticolas]
7227 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7228 tests passed" when we didn't happen to run any tests
7230 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7231 flunkOnFailure [Johan Dahlin]
7233 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7234 multiple instances of the same Step class by suffixing "_2", etc,
7235 to the name until it is unique. This name needs to be unique
7236 because it is used as a key in the dictionary that tracks build
7238 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7241 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7243 2004-01-14 Brian Warner <warner@lothar.com>
7245 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7246 kicked from a channel, log it
7248 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7249 something over whatever IRC channels the buildmaster is currently
7250 connected to. Added to try and track down a problem in which the
7251 master thinks it is still connected but the IRCd doesn't see it. I
7252 used a styles.Versioned this time, so hopefully users won't have
7253 to rebuild their .tap files this time.
7254 * contrib/debug.glade: add a "Poke IRC" button
7255 * contrib/debugclient.py: same
7257 * setup.py: bump to 0.4.2+ while between releases
7259 2004-01-08 Brian Warner <warner@lothar.com>
7261 * setup.py (version): Releasing buildbot-0.4.2
7263 2004-01-08 Brian Warner <warner@lothar.com>
7265 * NEWS: update for 0.4.2 release
7267 * README: document how to run the tests, now that they all pass
7269 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7271 * buildbot/process/step.py (CVS): add a global_options= argument,
7272 which lets you set CVS global options for the command like "-r"
7273 for read-only checkout, or "-R" to avoid writing in the
7275 * buildbot/slavecommand.py (CVSCommand): same
7277 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7278 testing easier (it is turned off when testing, to avoid the
7281 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7282 to make it easier to test: break generateStepID() out to a
7283 separate function, only update statusbag if it exists.
7284 (ShellCommands): create useful text for dict-based commands too.
7286 * test/*, buildbot/test/*: move unit tests under the buildbot/
7288 * setup.py (packages): install buildbot.test too
7290 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7291 * buildbot/test/test_steps.py: fix it, tests pass now
7293 2004-01-06 Brian Warner <warner@lothar.com>
7295 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7296 freshcvs mail uses a slightly different syntax for new
7297 directories. Update parser to handle either.
7298 * test/test_mailparse.py (Test1.testMsg9): test for same
7300 2003-12-21 Brian Warner <warner@lothar.com>
7302 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7303 'warnOnWarnings' so that lintian errors mark the build orange
7305 2003-12-17 Brian Warner <warner@lothar.com>
7307 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7308 messages emitted by Bonsai, contributed by Stephen Davis.
7310 * test/*: moved all tests to use trial instead of unittest. Some
7311 still fail (test_steps, test_slavecommand, and test_process).
7313 * setup.py (version): bump to 0.4.1+ while between releases
7315 2003-12-09 Brian Warner <warner@lothar.com>
7317 * setup.py (version): Releasing buildbot-0.4.1
7319 2003-12-09 Brian Warner <warner@lothar.com>
7321 * NEWS: update for 0.4.1 release
7323 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7324 freebsd builder code a little bit
7326 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7327 don't try to compare attributes of different classes
7328 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7329 (MaildirSource.messageReceived): fix Change delivery
7331 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7332 into the config file's namespace before loading it, like the
7333 documentation claims it does
7334 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7335 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7336 daemon comes back online
7338 2003-12-08 Brian Warner <warner@lothar.com>
7340 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7341 so the example will work with online=0 as well
7343 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7344 fix the __implements__ line
7346 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7347 class a twisted.application.service.Service, use startService to
7350 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7351 directory fd instead of simple open(). I'm sure this used to work,
7352 but the current version of python refuses to open directories with
7355 2003-12-05 Brian Warner <warner@lothar.com>
7357 * setup.py (version): bump to 0.4.0+ while between releases
7359 2003-12-05 Brian Warner <warner@lothar.com>
7361 * setup.py (version): Releasing buildbot-0.4.0
7363 2003-12-05 Brian Warner <warner@lothar.com>
7365 * docs/examples/glib_master.cfg: replace old sample scripts with
7366 new-style config files
7367 * MANIFEST.in: include .cfg files in distribution tarball
7369 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7370 implement a dummy method to avoid the exception that occurs when
7371 freshcvs sends this to us.
7373 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7374 removed the method, as it broke reconnection. Apparently
7375 stopFactory is called each time the connection attempt fails. Must
7377 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7378 attribute before serialization, since without stopFactory the
7379 reconnect timer may still be active and they aren't serializable.
7381 * test/test_mailparse.py (ParseTest): test with 'self' argument
7383 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7384 argument, as these "functions" are invoked like methods from class
7385 attributes and therefore always get an instance as the first
7388 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7389 message: thanks to Stephen Davis for the catch
7391 2003-12-04 Brian Warner <warner@lothar.com>
7393 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7394 twisted's standard ReconnectingClientFactory. Handles both oldcred
7395 and newcred connections. Also has a bug-workaround for
7396 ReconnectingClientFactory serializing its connector when it
7399 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7400 pbutil. Replace makeApp stuff with proper newcred/mktap
7401 makeService(). Don't serialize Ephemerals on shutdown.
7403 * buildbot/changes/changes.py (ChangeMaster): make it a
7404 MultiService and add the sources as children, to get startService
7405 and stopService for free. This also gets rid of the .running flag.
7407 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7408 new pbutil, turn into a TCPClient at the same time (to get
7409 startService for free). Two variants exist: FreshCVSSourceOldcred
7410 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7411 yet, but when it does, we'll be ready).
7412 (FreshCVSSource.notify): handle paths which are empty after the
7413 prefix is stripped. This only happens when the top-level (prefix)
7414 directory is added, at the very beginning of a Repository's life.
7416 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7417 Now the only reconnecting code is in the factory where it belongs.
7418 (Builder.unsubscribe): unregister the disconnect callback when we
7419 delete the builder on command from the master (i.e. when the
7420 buildmaster is reconfigured and that builder goes away). This
7421 fixes a multiple-delete exception when the status client is shut
7423 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7426 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7427 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7429 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7431 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7432 a list of globs (ugh). The testdir will be searched for files
7433 named *.tests and run the tests in the order specified in each of
7434 those files. This allows for "dependancies" between tests to be
7437 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7438 argument to pass to run_maxq.py, instead of a glob.
7440 2003-10-17 Brian Warner <warner@lothar.com>
7442 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7443 files that live in the sandbox
7445 2003-10-15 Brian Warner <warner@lothar.com>
7447 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7448 spelling error in "docs" count-warnings output
7449 (HLint.start): stupid thinko meant .xhtml files were ignored
7451 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7452 tests now that cReactor is banished to the sandbox
7454 2003-10-10 Brian Warner <warner@lothar.com>
7456 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7457 scheme: now .xhtml are sources and .html are generated
7459 2003-10-08 Brian Warner <warner@lothar.com>
7461 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7462 we were ignoring the 'randomly' parameter.
7464 2003-10-01 Brian Warner <warner@lothar.com>
7466 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7467 posix, to kill sub-children of aborted slavecommands.
7469 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7470 Clean up initialization: lastBuildStatus remains None until the
7471 first build has been completed.
7473 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7474 None as a lastBuildStatus
7475 * buildbot/clients/gtkPanes.py: same
7477 * buildbot/status/client.py (StatusClientService): keep
7478 BuilderStatus objects in self.statusbags . These objects now live
7479 here in the StatusClientService and are referenced by the Builder
7480 object, rather than the other way around.
7481 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7482 * buildbot/process/base.py (Builder): same
7483 * test/test_config.py (ConfigTest.testBuilders): same
7485 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7486 an existing builder, leave the statusbag alone. This will preserve the
7489 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7490 hook. This will probably go away in favor of a class in upcoming
7493 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7494 serviceName from newcred FreshCVSNotifiee setup
7496 2003-09-29 Brian Warner <warner@lothar.com>
7498 * buildbot/process/process_twisted.py: switch to new reactor
7500 * docs/examples/twisted_master.cfg: same
7502 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7504 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7505 botmaster reference instead of the oldapp service lookup
7507 * buildbot/master.py (BuildMaster.__init__): give the
7508 StatusClientService a reference to the botmaster to make it easier to
7511 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7513 * buildbot/status/html.py (Box.td): escape hreffy things so you
7514 can have spaces in things like builder names
7515 (StatusResourceBuilder.body)
7516 (WaterfallStatusResource.body)
7517 (WaterfallStatusResource.body0): same
7519 2003-09-25 Brian Warner <warner@lothar.com>
7521 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7522 rearrange the builder list when adding or removing builders: keep
7523 them in the order the user requested.
7524 * test/test_config.py (ConfigTest.testBuilders): verify it
7526 * contrib/debug.glade: give the debug window a name
7528 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7529 now wait on multiple interlocks. Fix code relating to that.
7530 (Builder.checkInterlocks): same
7531 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7533 * buildbot/master.py (BuildMaster.loadConfig): move from
7534 deprecated pb.BrokerFactory to new pb.PBServerFactory
7535 * test/test_config.py (ConfigTest.testWebPathname): same
7537 * docs/examples/twisted_master.cfg: fix interlock declaration
7539 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7540 Interlocks to their Builders into interlock.py .
7541 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7543 * test/test_config.py (ConfigTest.testInterlocks): validate
7546 * buildbot/process/base.py (Builder.__init__): better comments
7547 * buildbot/process/interlock.py (Interlock.__repr__): same
7548 (Interlock.deactivate): add .active flag, move the code that
7549 attaches/detaches builders into the Interlock
7551 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7553 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7554 tests using the new run_maxq.py script, and reporting failures by
7557 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7558 tests, reporting their success or failure in a buildbot-friendly
7561 2003-09-24 Brian Warner <warner@lothar.com>
7563 * docs/examples/twisted_master.cfg: example of a new-style config
7564 file. This lives in the buildmaster base directory as
7567 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7568 button to make the master re-read its config file
7570 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7571 buildmaster configuration from a file. This file can be re-read
7572 later, and the buildmaster will update itself to match the new
7573 desired configuration. Also use new Twisted Application class.
7574 * test/Makefile, test/test_config.py: unit tests for same
7576 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7577 FreshCVSSources comparable, to support reload.
7578 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7580 * buildbot/process/base.py (Builder): make them comparable, make
7581 Interlocks easier to attach, to support reload. Handle
7582 re-attachment of remote slaves.
7583 * buildbot/process/interlock.py (Interlock): same
7585 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7586 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7587 buildmaster taps are now constructed with mktap.
7588 * buildbot/status/client.py (StatusClientService): same
7590 * buildbot/status/words.py: move to new Services, add support to
7591 connect to multiple networks, add reload support, allow nickname
7592 to be configured on a per-network basis
7594 2003-09-20 Brian Warner <warner@lothar.com>
7596 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7597 the freebsd builder, now that the machine has been upgraded and no
7598 longer has python2.2
7600 * setup.py (version): bump to 0.3.5+ while between releases
7602 2003-09-19 Brian Warner <warner@lothar.com>
7604 * setup.py (version): Releasing buildbot-0.3.5
7606 2003-09-19 Brian Warner <warner@lothar.com>
7608 * NEWS: add post-0.3.4 notes
7610 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7612 * MANIFEST.in: add contrib/*
7614 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7615 use a remote root now: cvs.twistedmatrix.com
7617 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7619 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7620 compatibility with old servers
7621 (FreshCVSSource.start): and provide a way to use it
7622 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7624 * docs/examples/twisted_master.py (twisted_app): update to new
7626 (twisted_app): listen on new ~buildbot socket
7627 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7629 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7630 to reduce cvs bandwidth (update instead of full checkout)
7632 2003-09-11 Brian Warner <warner@lothar.com>
7634 * contrib/fakechange.py: demo how to connect to the changemaster
7635 port. You can use this technique to submit changes to the
7636 buildmaster from source control systems that offer a hook to run a
7637 script when changes are committed.
7639 * contrib/debugclient.py: tool to connect to the debug port. You
7640 can use it to force builds, submit fake changes, and wiggle the
7643 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7644 'Dispatcher' realm to handle all the different kinds of
7645 connections and Perspectives: buildslaves, the changemaster port,
7646 the debug port, and the status client port. NewCredPerspectives
7647 now have .attached/.detached methods called with the remote 'mind'
7648 reference, much like old perspectives did. All the pb.Services
7649 turned into ordinary app.ApplicationServices .
7650 (DebugService): went away, DebugPerspectives are now created
7651 directly by the Dispatcher.
7652 (makeApp): changed interface a little bit
7654 * buildbot/changes/changes.py: newcred
7655 * buildbot/status/client.py: newcred
7657 * buildbot/clients/base.py: newcred client side changes
7658 * buildbot/bot.py: ditto
7660 * docs/examples/glib_master.py: handle new makeApp() interface
7661 * docs/examples/twisted_master.py: ditto
7663 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7664 base newcred Perspectives on. This should go away once Twisted
7665 itself provides something sensible.
7668 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7670 * contrib/svn_buildbot.py: A program that you can call from your
7671 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7672 when a change in an SVN repository has happened. See the top of
7673 the file for some minimal usage info.
7675 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7677 * buildbot/slavecommand.py (ArglistCommand): Add new
7678 ArglistCommand that takes an argument list rather than a string as
7679 a parameter. Using a st.split() for argv is very bad.
7681 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7682 update to a particular revision rather than always checking out
7683 (still not very smart about it, there may be cases where the
7684 checkout becomes inconsistent).
7686 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7688 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7689 SVN fetch support. It can checkout (not update!) a specified
7690 revision from a specified repository to a specified directory.
7692 * buildbot/status/progress.py (Expectations.update): Fix an
7693 obvious bug (apparently created by the change described in the
7694 previous ChangeLog message) by moving a check to *after* the
7695 variable it checks is defined.
7698 2003-09-08 Brian Warner <warner@lothar.com>
7700 * buildbot/status/progress.py (Expectations.update): hack to catch
7701 an exception TTimo sees: sometimes the update() method seems to
7702 get called before the step has actually finished, so the .stopTime
7703 is not set, so no totalTime() is available and we average None
7704 with the previous value. Catch this and just don't update the
7705 metrics, and emit a log message.
7707 2003-08-24 Brian Warner <warner@lothar.com>
7709 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7710 parameter to set copydir='original' in CVS commands.
7712 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7714 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7715 which tells the command to maintain a separate original-source CVS
7716 workspace. For each build, this workspace will be updated, then
7717 the tree copied into a new workdir. This reduces CVS bandwidth
7718 (from a full checkout to a mere update) while doubling the local
7719 disk usage (to keep two copies of the tree).
7721 2003-08-21 Brian Warner <warner@lothar.com>
7723 * buildbot/status/event.py (Logfile.addEntry): if the master web
7724 server dies while we're serving a page, request.write raises
7725 pb.DeadReferenceError . Catch this and treat it like a
7726 notifyFinish event by dropping the request.
7728 2003-08-18 Brian Warner <warner@lothar.com>
7730 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7731 (instead of blowing up) if a force-build command is given without
7734 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7735 don't blow up if there aren't yet any Changes in the list
7737 2003-08-02 Brian Warner <warner@lothar.com>
7739 * buildbot/bot.py (updateApplication): don't set the .tap name,
7740 since we shouldn't assume we own the whole .tap file
7742 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7743 'mktap buildbot' (without a subcommand) better
7745 2003-07-29 Brian Warner <warner@lothar.com>
7747 * buildbot/status/words.py
7748 (IrcStatusFactory.clientConnectionLost): when we lose the
7749 connection to the IRC server, schedule a reconnection attempt.
7751 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7752 use shutil.rmtree instead of forking off an "rm -rf" command.
7753 rmtree may take a while and will block until it finishes, so we
7754 use "rm -rf" if available.
7756 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7757 freebsd buildslave badly
7759 * setup.py (version): bump to 0.3.4+ while between releases
7761 2003-07-28 Brian Warner <warner@lothar.com>
7763 * setup.py (version): Releasing buildbot-0.3.4
7765 2003-07-28 Brian Warner <warner@lothar.com>
7767 * NEWS: update in preparation for release
7769 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7770 process.signalProcess instead of os.kill, to improve w32
7773 * docs/examples/twisted_master.py (twisted_app): turn off
7774 win32eventreactor: the tests hang the buildslave badly
7776 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7777 failed builds, since usually the failures are consistent
7779 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7780 add compileOpts/compileOpts2 to reactors build
7782 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7783 (twisted_app): use both default and win32eventreactor on w32 build.
7784 Use both default and kqreactor on freebsd build.
7786 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7787 add compileOpts2, which is put after the build_ext argument. w32
7788 needs "-c mingw32" here.
7790 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7791 touch .acqpath, it goes away in recent Twisted releases
7793 * docs/examples/twisted_master.py (twisted_app): use "python" for
7794 the w32 buildslave, not "python2.2"
7796 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7797 the directory exists.. should hush an exception under w32
7799 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7800 ProcessTerminated -provided values for signal and exitCode rather
7801 than parsing the unix status code directly. This should remove one
7802 more roadblock for a w32-hosted buildslave.
7804 * test/test_mailparse.py: add test cases for Syncmail parser
7806 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7807 temporary compatibility import. Note! Start importing
7808 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7810 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7812 2003-07-27 Brian Warner <warner@lothar.com>
7814 * NEWS: started adding new features
7816 * buildbot/changes/mail.py: start work on Syncmail parser, move
7817 mail sources into their own file
7819 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7820 as implementing IChangeSource
7821 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7823 * buildbot/interfaces.py: define the IChangeSource interface
7825 2003-07-26 Brian Warner <warner@lothar.com>
7827 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7829 2003-06-25 Brian Warner <warner@lothar.com>
7831 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7834 2003-06-17 Brian Warner <warner@lothar.com>
7836 * buildbot/status/words.py: clean up method usage to avoid error
7837 in silly IRC command
7838 (IrcStatusBot.emit_status): round off seconds display
7840 * buildbot/process/base.py (Build): delete the timer when saving
7841 to the .tap file, and restore it (if it should still be running)
7842 upon restore. This should fix the "next build in -34 seconds"
7843 messages that result when the master is restarted while builds are
7844 sitting in the .waiting slot. If the time for the build has
7845 already passed, start it very soon (in 1 second).
7847 * buildbot/status/words.py: more silly commands
7849 * README (REQUIREMENTS): add URLs to all required software
7851 * buildbot/status/words.py ('last'): mention results of, and time
7854 2003-05-28 Brian Warner <warner@lothar.com>
7856 * buildbot/status/words.py: add 'last' command
7857 (IrcStatusBot.emit_status): add current-small text to 'status' output
7859 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7860 (twisted_app): remove spaces from OS-X builder name
7862 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7863 * buildbot/status/words.py: IRC bot should actually be useful now
7865 2003-05-23 Brian Warner <warner@lothar.com>
7867 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7868 "slave information" from $(slavedir)/info/* . These files are
7869 maintained by the slave administrator, and describe the
7870 machine/environment that is hosting the slave. Information from
7871 them is put into the "Builder" HTML page. Still need to establish
7872 a set of well-known filenames and meanings for this data: at the
7873 moment, *all* info/* files are sent to the master, but only
7874 'admin' and 'host' are used on that end.
7875 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7876 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7877 * buildbot/master.py (BotPerspective.got_info): ditto
7879 2003-05-22 Brian Warner <warner@lothar.com>
7881 * setup.py (version): bump version to 0.3.3+ while between releases
7883 2003-05-21 Brian Warner <warner@lothar.com>
7885 * setup.py: Releasing buildbot-0.3.3
7887 2003-05-21 Brian Warner <warner@lothar.com>
7889 * NEWS: 0.3.3 news items
7891 * README: describe --keepalive and life behind a NAT box
7893 * buildbot/bot.py (Bot.connected): implement application-level
7894 keepalives to deal with NAT timeouts, turn them on with
7895 --keepalive option or when SO_KEEPALIVE doesn't work.
7897 * buildbot/master.py (BotPerspective): accept keepalives silently
7899 * buildbot/process/base.py (Build.buildException): CopiedFailures
7900 don't carry as much information as local ones, so don't try to
7901 create a big HTMLized version of them.
7903 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7904 log file when step fails due to an exception, such as when the slave
7907 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7908 --testmodule argument instead of grepping for test-case-name tags
7909 ourselves. Remove FindUnitTests code.
7910 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7912 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7914 2003-05-16 Brian Warner <warner@lothar.com>
7916 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7917 argument to allow things like CFLAGS=-O0 to be passed without relying
7918 upon /bin/sh processing on the slave.
7920 * buildbot/process/step.py (InternalShellCommand.start): send
7922 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7923 'split' instead of letting /bin/sh do it. This should also remove
7924 the need for /bin/sh on the buildslave, making it more likely to
7927 * buildbot/status/html.py: html-escape text in blamelist.
7928 Add "force build" button to the Builder page.
7930 * buildbot/process/step_twisted.py (countFailedTests): look at
7931 last 1000 characters for status line, as import errors can put it
7932 before the -200 point.
7934 2003-05-15 Brian Warner <warner@lothar.com>
7936 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7938 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7939 make 'clobber' a parameter, so it is possible to have builds which
7940 do full tests but do a cvs update instead of hammering the CVS
7941 server with a full checkout each build
7943 * buildbot/process/step.py (InternalShellCommand): bump default
7944 timeout to 20 minutes
7946 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7947 the master to trigger a build. Run it via manhole.
7949 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7950 allow slaves to trigger any build that they host, to make life
7951 easier for slave admins who are testing out new build processes
7953 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7954 don't flunk cReactor or qtreactor on failure, since they fail alot
7955 these days. Do warnOnFailure instead.
7957 * buildbot/process/base.py: change Builder.buildable from a list
7958 into a single slot. When we don't have a slave, new builds (once
7959 they make it past the timeout) are now merged into an existing
7960 buildable one instead of being queued. With this change, a slave
7961 which has been away for a while doesn't get pounded with all the
7962 builds it missed, but instead just does a single build.
7964 2003-05-07 Brian Warner <warner@lothar.com>
7966 * setup.py (version): bump version to 0.3.2+ while between releases
7968 2003-05-07 Brian Warner <warner@lothar.com>
7970 * setup.py: Releasing buildbot-0.3.2
7972 2003-05-07 Brian Warner <warner@lothar.com>
7974 * setup.py: fix major packaging error: include subdirectories!
7976 * NEWS: add changes since last release
7978 * README (REQUIREMENTS): update twisted/python dependencies
7980 * buildbot/status/builder.py (Builder.startBuild): change
7981 BuildProcess API: now they should call startBuild/finishBuild
7982 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7983 keeping a list of builds in the statusbag, to support other kinds of
7985 (Builder.addClient): send current-activity-small to new clients
7986 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7989 * buildbot/status/client.py: drop RemoteReferences at shutdown
7991 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7993 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7994 more debug messages for remote status client
7996 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7997 (.stepFailed): only fire the Deferred once, even if both
7998 stepComplete and stepFailed are called. I think this can happen if
7999 an exception occurs at a weird time.
8001 * buildbot/status/words.py: work-in-progress: IRC status delivery
8003 2003-05-05 Brian Warner <warner@lothar.com>
8005 * docs/examples/twisted_master.py (twisted_app): hush internal
8006 python2.3 distutils deprecation warnings
8007 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8008 add compileOpts= argument which inserts extra args before the
8009 "setup.py build_ext" command. This can be used to give -Wignore
8010 warnings, to hush some internal python-2.3 deprecation messages.
8012 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8013 the ['twisted.test'] default test case to make it easier to change
8016 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8017 * buildbot/clients/gtkPanes.py: ditto
8019 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8020 arg to collapse RunUnitTestsRandomly into RunUnitTests
8021 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8022 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8024 * buildbot/status/html.py (StatusResource): shuffle Resources
8025 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8026 would serve the waterfall display, but the internal links were
8027 only valid on the trailing-slash version. The correct behavior is
8028 for the non-slashed one to serve a Redirect to the slashed one.
8029 This only shows up when the buildbot page is hanging off another
8030 server, like a Twisted-Web distributed server.
8032 * buildbot/status/event.py (Event, RemoteEvent): make Events
8033 pb.Cacheable, with RemoteEvent as the cached version. This removes
8034 a lot of explicit send-an-update code.
8035 * buildbot/status/builder.py (Builder): remove send-update code
8036 * buildbot/status/client.py (ClientBuilder): remove send-update
8037 code, and log errors that occur during callRemote (mostly to catch
8038 InsecureJelly exceptions)
8040 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8041 run Lore with the same python used in the rest of the build
8043 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8045 * buildbot/process/step_twisted.py (HLint): accept 'python'
8046 argument. Catch rc!=0 and mark the step as failed. This marks the
8047 build orange ("has warnings").
8048 (RunUnitTestsJelly): move out to step_twisted2.py
8050 * buildbot/util.py (ignoreStaleRefs): add utility function
8052 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8053 don't fake ETA object, it's too hard to get right
8055 2003-05-02 Brian Warner <warner@lothar.com>
8057 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8059 2003-05-01 Brian Warner <warner@lothar.com>
8061 * buildbot/status/html.py (StatusResource.body): oops, I was
8062 missing a <tr>, causing the waterfall page to be misrendered in
8063 everything except Galeon.
8065 2003-04-29 Brian Warner <warner@lothar.com>
8067 * docs/examples/twisted_master.py: make debuild use python-2.2
8068 explicitly, now that Twisted stopped supporting 2.1
8070 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8071 handle tuple results too. I keep forgetting this, which suggests
8072 it needs to be rethought.
8074 * setup.py (setup): bump version to 0.3.1+ while between releases
8076 2003-04-29 Brian Warner <warner@lothar.com>
8078 * setup.py: Releasing buildbot-0.3.1
8080 2003-04-29 Brian Warner <warner@lothar.com>
8082 * README (SUPPORT): add plea to send questions to the mailing list
8084 * NEWS, MANIFEST.in: add description of recent changes
8086 * docs/examples/twisted_master.py: add the code used to create the
8087 Twisted buildmaster, with passwords and such removed out to a
8090 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8091 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8092 buildmasters to not require CVSToys be installed.
8093 * README, docs/examples/glib_master: update to match the change
8095 * buildbot/clients/base.py, buildbot/bot.py,
8096 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8097 ReconnectingPB from CVSToys distribution to remove CVSToys
8098 dependency for build slaves and status clients. Buildmasters which
8099 use FreshCVSSources still require cvstoys be installed, of course.
8101 2003-04-25 Brian Warner <warner@lothar.com>
8103 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8104 runTestsRandomly arg to turn on trial -z
8106 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8107 experimental code to use trial's machine-parseable output to get
8108 more detailed test results. Still has some major issues.
8109 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8112 * buildbot/status/builder.py (Builder.setCurrentBuild):
8113 anticipating moving build history into statusbag, not used yet
8115 * buildbot/status/tests.py: code to centralize test results,
8116 doesn't work quite yet
8118 * buildbot/status/event.py (Event): use hasattr("setName") instead
8119 of isinstance for now.. need better long-term solution
8121 * buildbot/status/html.py: Remove old imports
8123 2003-04-24 Brian Warner <warner@lothar.com>
8125 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8126 ignore changes under doc/fun/ and sandbox/
8128 * buildbot/process/step_twisted.py: update pushEvent and friends.
8130 * buildbot/status/html.py (Box.td): replace event.buildername with
8131 event.parent.getSwappableName(). Needs more thought.
8133 * buildbot/status/builder.py (Builder): Replace pushEvent and
8134 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8135 Tell events they are being pruned with event.delete().
8137 * buildbot/process/base.py (Build): Remove Builder status-handling
8138 methods. s/pushEvent/setCurrentActivity/.
8140 * buildbot/process/step.py (BuildStep): clean up status delivery.
8141 Gouse builder.statusbag methods instead of intermediate builder
8142 methods. s/updateLastEvent/updateCurrentActivity/.
8143 s/finalizeLastEvent/finishCurrentActivity/. Use
8144 addFileToCurrentActivity for summaryFunction.
8146 * buildbot/status/event.py (Logfile): put data in a Swappable when
8148 (Event): add more setter methods. Remove .buildername, use .parent
8149 and getSwappableName instead (needs more thought).
8151 * buildbot/util.py (Swappable):
8152 * test/test_swap.py: don't bother setting filename at __init__
8153 time, do it later. Change setFilename args to take parent first,
8154 since it provides the most significant part of the filename.
8156 2003-04-23 Brian Warner <warner@lothar.com>
8158 * buildbot/status/event.py (Logfile.addEntry): append to previous
8161 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8162 anticipating Swappable
8163 (InternalShellCommand.remoteUpdate): split out various log-adding
8164 methods so subclasses can snarf stdout separately
8166 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8167 in anticipation of Swappable build logs
8168 (Builder.testsFinished): anticipating TestResults, still disabled
8170 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8173 * buildbot/status/event.py (Logfile): add (disabled) support for
8174 Swappable, not ready for use yet
8176 * buildbot/util.py (Swappable): object which is swapped out to
8177 disk after some period of no use.
8178 * test/test_swap.py: test buildbot.utils.Swappable
8180 2003-04-14 Brian Warner <warner@lothar.com>
8182 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8183 periodic-build timer. Set the .periodicBuildTime on a builder
8184 instance to some number of seconds to activate it.
8186 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8188 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8189 a way that survives result tuples
8191 2003-04-12 Brian Warner <warner@lothar.com>
8193 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8194 return a dict instead of a tuple: allow summarizers to provide
8195 multiple summaries if they want
8196 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8197 (debuildSummarizer): summarize lintian warnings/errors
8199 2003-04-10 Brian Warner <warner@lothar.com>
8201 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8203 2003-04-09 Brian Warner <warner@lothar.com>
8205 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8206 empty summaries: happens when the tests fail so hard they don't emit
8207 a parseable summary line.
8209 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8210 Allow summaryFunction to return None to indicate no summary should
8213 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8214 writing to stale HTTP requests: notice when they disconnect and
8215 remove the request from the list. Also add CacheToFile from
8216 moshez, will be used later.
8218 2003-04-08 Brian Warner <warner@lothar.com>
8220 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8221 should be an int, not a list of strings
8223 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8224 if we weren't actually connected
8226 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8227 to show the tail end of the trial text output
8229 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8230 hook to summarize the results of a ShellCommand
8232 2003-04-07 Brian Warner <warner@lothar.com>
8234 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8235 twisted test suite code into a single class.
8236 * buildbot/process/process_twisted.py: same
8238 2003-04-04 Brian Warner <warner@lothar.com>
8240 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8242 * README (SLAVE): document use of mktap to create slave .tap file
8243 (REQUIREMENTS): describe dependencies
8245 * buildbot/bb_tap.py, buildbot/plugins.tml:
8246 * buildbot/bot.py (updateApplication): Add mktap support for creating
8247 buildslave .tap files
8249 2003-03-28 Brian Warner <warner@lothar.com>
8251 * buildbot/process/step.py (InternalShellCommand.finished): handle
8252 new tuple result values (fix embarrasing bug that appeared during
8255 2003-03-27 Brian Warner <warner@lothar.com>
8257 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8260 2003-03-25 Brian Warner <warner@lothar.com>
8262 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8263 to overall build status
8264 * buildbot/clients/base.py (Builder): improve event printing
8265 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8266 instead of generic ShellCommand
8267 (Build): Add .stopBuild, use it when slave is detached
8269 * buildbot/process/step.py (Configure,Test): give the steps their
8270 own names and status strings
8272 * buildbot/status/html.py (StatusResource): add "show" argument,
8273 lets you limit the set of Builders being displayed.
8275 2003-03-20 Brian Warner <warner@lothar.com>
8277 * buildbot/process/basic.py: removed
8279 2003-03-19 Brian Warner <warner@lothar.com>
8281 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8282 turn off process-docs by default
8284 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8285 when displaying build information without anything in allBuilds[]
8287 * buildbot/bot.py (makeApp): really take password from sys.argv
8289 2003-03-18 Brian Warner <warner@lothar.com>
8291 * buildbot/bot.py (buildApp): take password from sys.argv
8293 * README: replace with more useful text
8295 * setup.py: add a real one
8296 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8298 * docs/PyCon-2003/: added sources for PyCon paper.
8300 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8301 now Build objects control the process and Builder only handles
8302 slave stuff and distribution of changes/status. A new BuildFactory
8303 class creates Build objects on demand.
8305 Created ConfigurableBuild which takes a list of steps to run. This
8306 makes it a lot easier to set up a new kind of build and moves us
8307 closer to being able to configure a build from a web page.
8309 * buildbot/process/step_twisted.py, process_twisted.py: move to
8310 new model. A lot of code went away.
8312 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8313 send lots of empty progress messages to the client.
8315 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8317 2003-02-20 Brian Warner <warner@lothar.com>
8319 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8321 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8322 Twisted bug that prevented non-pty processes from working just got
8323 fixed, and the bug that leaks ptys is still being investigated.
8325 * buildbot/process/step.py (CVS): send timeout arg to slave
8327 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8328 builders coming and going
8329 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8330 from CVSToys, handle lost-buildmaster
8332 * buildbot/status/client.py (StatusClientService.removeBuilder):
8333 Clean up status client protocol: send builders (with references)
8334 as they are created, rather than sending a list and requiring the
8335 client to figure out which ones are new.
8336 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8337 attempts to force a build on an unknown builder
8339 2003-02-19 Brian Warner <warner@lothar.com>
8341 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8342 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8343 Twisted stops leaking them.
8344 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8345 builder goes to an idle state.
8347 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8348 I figure out why CVS commands hang without them, and/or I fix the
8349 hung-command timeout
8351 2003-02-16 Brian Warner <warner@lothar.com>
8353 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8354 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8355 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8356 GenerateDocs now that they are prefixed with WARNING:.
8358 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8359 use manual href target instead of request.childLink
8361 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8362 display every second, but update the ETA every 5 seconds (or
8363 whenever) as remote_progress messages arrive.
8366 2003-02-12 Brian Warner <warner@lothar.com>
8368 * *: import current sources from home CVS repository
8372 # add-log-time-format: add-log-iso8601-time-string