1 2007-08-01 Brian Warner <warner@lothar.com>
3 * web-parts: merge in web-parts branch. Lots of changes. The new
4 functionality is to add buildbot.status.html.WebStatus, which is a
5 superset of the Waterfall that adds new status pages and serves
6 regular files from BASEDIR/public_html/ , which is now the preferred
7 place to put robots.txt, buildbot.css, and index.html .
8 * buildbot/scripts/runner.py: the 'create-master' command now
9 creates public_html/ too, and populates it with a couple of
11 * buildbot/status/web: split waterfall code into smaller pieces
13 2007-07-31 Brian Warner <warner@lothar.com>
15 * buildbot/scripts/startup.py (launch): import twistd.run in a
16 different way to hush pyflakes
17 * buildbot/process/builder.py: remove unused import
19 2007-07-30 Brian Warner <warner@lothar.com>
21 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
22 Mitchell: pass SourceStamps around rather than branch/version/etc
23 tuples. Thanks Dustin! Closes #70.
24 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
25 tuple rather than a list, to avoid surprising mutations
26 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
27 * buildbot/status/mail.py (MailNotifier.buildMessage): same
28 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
29 * buildbot/test/test_status.py (Subscription): same
30 * buildbot/test/test_control.py (Force): same
31 * buildbot/test/test_buildreq.py (Request.testMerge): same
33 2007-07-29 Brian Warner <warner@lothar.com>
35 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
36 variable, since it wasn't used and is confusing in the presence of
37 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
40 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
41 the Buildbot home-page link to point at buildbot.net instead of
42 sourceforge, and add a current-version query parameter so we can
43 get some statistics on which versions are in use out there.
45 2007-07-28 Brian Warner <warner@lothar.com>
47 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
48 with c['change_source'], leaving c['sources'] for backwards
49 compatibility (but deprecated), scheduled for removal in 0.8.0
50 * docs/buildbot.texinfo: same
51 * buildbot/test/test_config.py: verify that c['sources'] still works
52 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
53 * buildbot/scripts/sample.cfg: update to match
55 * buildbot/changes/mail.py (MaildirSource): parse with python's
56 stdlib 'email' module, which has been available since python2.2,
57 and drop use of the 'rfc822' module, which has been depreceated
59 * buildbot/test/test_maildir.py: same: use parse_file() not parse
61 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
62 this needs to match the renaming in test/mail/msg*
64 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
67 * buildbot/test/test_mailparse.py: rename sample emails a bit
68 * buildbot/test/mail/msg*: same
70 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
71 parser for the "commit-email.pl" script that is shipped with SVN,
72 written by Justin Mason. Thanks! Closes SF#1072845.
73 * buildbot/test/mail/svn-commit.*: sample messages
74 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
75 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
77 2007-07-27 Brian Warner <warner@lothar.com>
79 * buildbot/changes/mail.py: refactor: move parsing into a method
80 named 'parse', each parser type gets a separate subclass. Remove
81 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
82 to be a simple leading-substring match. Add a warning to the logs
83 if prefix= does not end in a slash, since that's probably a
84 mistake. Fix both places where a prefix= mismatch would skip all
85 subsequent files in the same email, instead of just skipping the
86 one that didn't match.
87 * buildbot/test/test_mailparse.py: match changes
89 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
90 docs on email-based ChangeSources
92 * docs/buildbot.texinfo (Getting Source Code Changes): move all
93 the changesource types up a level, removing the one-entry menu in
96 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
97 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
98 instances instead of tuples. Closes #63.
99 * buildbot/slave/__init__.py (BuildSlave): define marker class
100 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
101 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
102 * buildbot/test/test_*.py: update tests to match
103 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
104 the c['bots'] backwards-compatibility handler works
106 2007-07-26 Brian Warner <warner@lothar.com>
108 * buildbot/changes/hgbuildbot.py (hook): add an in-process
109 Mercurial change-sending hook, contributed by Frederic Leroy.
110 Thanks! Addresses #50.
111 * docs/buildbot.texinfo (MercurialHook): document it
113 * buildbot/changes/hgbuildbot.py: change the way imports are done,
114 to make it compatible with at least hg-0.9.1 and the current 0.9.4
116 2007-07-17 Brian Warner <warner@lothar.com>
118 * buildbot/process/buildstep.py (BuildStep.getLog): add a
119 convenience method to retrieve a log added with
120 addLog()/addCompleteLog()/etc or logfiles= . I should have added
123 2007-07-03 Brian Warner <warner@lothar.com>
125 * buildbot/slave/commands.py (ShellCommand._startCommand): when
126 logging the environment variables, put one variable on each line,
127 rather than having one really long line with all of them. This
128 should make them a bit more readable and not trigger the
129 horizontal scrollbar (when viewing it in a web browser) quite so
130 much. Thanks to Albert Hofkamp for the patch.
132 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
133 WithProperties instance. Thanks to Axel Hecht for the patch.
135 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
136 * docs/buildbot.texinfo (Build Properties): document it
137 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
138 workdir if it didn't already exist.
140 * docs/buildbot.texinfo (Scheduler Types): correct the description
141 of Dependent schedulers. Thanks to Greg Ward for the patch.
143 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
144 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
145 the patch. Closes #49.
147 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
148 0700 before removing it, to deal with situations where a build will
149 leave files around without write permissions and the 'copy' or
150 'clobber' VC checkout modes need to blow away the tree first.
151 Thanks to Steve Milner for the suggestion and the patch (which I
152 mangled horribly). Closes #29.
153 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
156 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
157 an allowReconnect= argument to let callers control whether they
158 want this don't-let-it-reconnect behavior, since some tests care.
159 Factor out the .continueTrying=False lines from those callers.
160 * buildbot/test/test_slaves.py: same
161 * buildbot/test/test_run.py: same
163 2007-07-02 Brian Warner <warner@lothar.com>
165 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
166 slave has been disappeared, don't let it reconnect. This was
167 causing an intermittent failure in test_slaves.py, when the slave
168 that was supposed to be gone managed to come back by the end of
169 the test and affect the count.
170 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
172 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
173 diagnostic messages to track down this problem
174 (Builder.startBuild): same
176 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
177 the slave randomly rather than always taking the first one. Thanks
178 to Pike for the patch. Closes #36.
179 * buildbot/test/test_slaves.py: match the change. to avoid huge
180 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
181 enables/disables the round-robin-ness (enabled by default), and
182 some unit tests disable it.
183 * docs/buildbot.texinfo (Buildmaster Architecture): document it
185 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
186 argument to 'buildmaster_host', to make it more obvious that this
187 points to the buildmaster. Thanks to Bob Proulx for the
189 * buildbot/scripts/runner.py (slaveTAC): same
190 * buildbot/test/test_runner.py (Create.testSlave): match the change
192 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
195 2007-06-17 Brian Warner <warner@lothar.com>
197 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
198 we can round-trip all of our current step classes by calling
199 getStepFactory() and using the results to make a clone of the
202 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
205 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
206 the config file, we're moving to using actual instances instead of
207 the (class, kwargs) 'step specification' tuples. BuildFactory
208 still keeps a list of tuples internally, but when real instances
209 are passed in to addStep(), they are asked for their class and
210 kwargs using the new BuildStep.getStepFactory method. BuildFactory
211 accepts both instances and the tuple form, and converts instances
212 to the tuple form, but the instance form is preferred because it
213 gives the Steps a chance to do argument validation. Closes: #11.
215 * buildbot/process/buildstep.py (BuildStep.__init__): record the
216 factory information necessary to implement getStepFactory. The
217 addFactoryArguments() method can be used to include arguments that
218 aren't passed to the BuildStep base class constructor.
219 (BuildStep.setBuild):
220 (BuildStep.setDefaultWorkdir): new methods to take parameters that
221 are needed for live BuildSteps but not to construct the specification
222 tuples that are stashed in the factory.
224 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
225 'workdir' into new BuildSteps by using methods instead of
226 arguments. This makes the constructor for BuildSteps a lot
229 * buildbot/steps/*.py: update to match this change. Basically this
230 means adding calls to addFactoryArguments() in the __init__
231 methods to capture the arguments that aren't passed through to the
233 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
234 the new workdir (if any) into the RemoteShellCommands arguments.
235 * buildbot/steps/source.py: allow workdir= to be optional,
236 implement setDefaultWorkdir() since we don't inherit from
237 (CVS): finally remove old clobber=/export=/copydir= arguments,
238 in favor of the mode= argument that's been around forever now.
239 * buildbot/steps/transfer.py: remove build= argument
241 * buildbot/test/*.py: update to match, generally by turning all
242 build= arguments into subsequent calls to s.setBuild()
243 * buildbot/test/test_config.py (Factories): verify that we can
244 use either BuildStep instances or class/kwarg tuples in both
245 BuildFactory.addStep and BuildFactory.__init__
247 * docs/buildbot.texinfo (Build Steps): document the new approach,
248 mention compatibility with the old approach, update all examples
249 to use the new style.
251 2007-06-16 Brian Warner <warner@lothar.com>
253 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
254 the LoopingCall, just eat the failure so that we'll poll again
255 next time. This should allow us to tolerate (e.g.) sf.net SVN
256 failures more gracefully. Many thanks to Dustin Mitchell for the
259 2007-05-17 Brian Warner <warner@lothar.com>
261 * buildbot/status/words.py: refactor the IRC status bot into
262 separate 'Contact' and 'Channel' classes. The base Contact class
263 contains the interaction code: commands and responses. The
264 IRCContact subclass (and IrcStatusBot 'Channel') handle the
265 IRC-specific aspects. The plan is to write other subclasses for
266 other IM protocols like AIM and Jabber.
268 2007-04-16 Brian Warner <warner@lothar.com>
270 * CREDITS: update list of contributors. Thank you all!
272 2007-04-13 Brian Warner <warner@lothar.com>
274 * buildbot/status/mail.py (MailNotifier): add the project name to
275 the subject line and message body, to make it easier to
276 distinguish email coming from different buildmasters. Thanks to
277 Benoit Sigoure for the patch.
278 * buildbot/test/test_status.py (Mail): update to match
280 2007-03-24 Brian Warner <warner@lothar.com>
282 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
283 avoid text-conversion problems between DOS/windows and unix.
284 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
286 2007-03-03 Brian Warner <warner@lothar.com>
288 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
289 warning about the use of Waterfall here
291 2007-03-01 Brian Warner <warner@lothar.com>
293 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
295 2007-02-28 Brian Warner <warner@lothar.com>
297 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
298 Lamb to use a more optimal form of 'p4 changes', to reduce server
299 load. He reports that this optimization was added to p4d release
300 2005.2, but it should work in all versions. Closes #27.
301 * buildbot/test/test_p4poller.py: match it
303 2007-02-27 Brian Warner <warner@lothar.com>
305 * buildbot/status/web/*.py: move all web status stuff into a
306 separate directory, in anticipation of splitting it into smaller
307 pieces and adding more files. html.py was getting way too big.
308 * buildbot/status/classic.css: move it too
309 * setup.py: add the new sub-package
310 * buildbot/test/test_web.py: match the changes
311 * MANIFEST.in: handle the move of classic.css
313 2007-02-07 Brian Warner <warner@lothar.com>
315 * contrib/OS-X/*: add some launchd .plist files for automatically
316 starting a buildmaster or buildslave under OS-X (10.4 or later).
317 Thanks to Mark Pauley for these.
319 2007-02-06 Brian Warner <warner@lothar.com>
321 * docs/buildbot.texinfo (Requirements): update requirements to
322 stop claiming compatibility with python-2.2 or twisted-1.3.x .
324 * README: mention python-2.5 and twisted-2.5 compatibility
326 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
328 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
330 * buildbot/status/builder.py: same, by requiring cStringIO
331 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
332 * buildbot/test/test_vc.py: same
333 * buildbot/test/test_web.py:
334 * buildbot/test/test_steps.py: same, remove unused import
336 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
339 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
340 see any Builders that don't have Schedulers to drive them
342 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
343 attributes this uses went away
345 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
346 dialog, to allow you to reset the buildmaster and force
347 connect/disconnect. Correctly handle losing the buildmaster
348 connection (by switching the display to the hexnut, at which point
349 you can use the 'Connect' menu item to reconnect).
351 * buildbot/steps/source.py (Source.start): if we're using a patch,
352 add it as a LogFile to the checkout/update step. This will turn
353 into a link on the waterfall page.
355 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
356 option, to take the patch from a pre-made file rather than
357 generating it from the local tree. Thanks to Robert Helmer for the
358 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
359 * buildbot/scripts/runner.py (TryOptions): add --diff,
360 --patchlevel, and --baserev options
361 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
362 as None, meaning HEAD.
363 * buildbot/sourcestamp.py (SourceStamp): update docstring to
364 indicate that baserev=None means HEAD
365 * docs/buildbot.texinfo (try --diff): document it
367 * buildbot/test/test_steps.py (BuildStep): remove use of
368 reactor.iterate(), although the technique I replaced it with is a
369 gross polling hack that must be cleaned up properly some day. This
370 was the last use of reactor.iterate in the entire tree, yay.
372 2007-02-05 Brian Warner <warner@lothar.com>
374 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
375 is one of the three known values, otherwise we emit some confusing
376 messages later on. Thanks to Grig Gheorghiu for the catch.
378 2007-01-30 Brian Warner <warner@lothar.com>
380 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
381 Hearsum contributed a patch to let BonsaiPoller work with results
382 that contain non-ascii characters. Closes SF#1632641.
384 2007-01-27 Brian Warner <warner@lothar.com>
386 * Makefile (release): produce both .tar.gz and .zip source bundles.
389 2007-01-23 Brian Warner <warner@lothar.com>
391 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
392 * buildbot/changes/monotone.py: same
394 * buildbot/changes/maildir.py: combine several files into one,
395 clean up maildir.py to use Services properly.
396 * buildbot/changes/maildirtwisted.py: remove
397 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
399 * buildbot/changes/mail.py: match the change
400 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
401 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
403 * buildbot/slave/commands.py (command_version): bump to "2.3" to
404 indicate that the buildslave knows about the 'bzr' command
406 2007-01-22 Brian Warner <warner@lothar.com>
408 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
409 'with', it will become a reserved work in python2.6 .
411 * contrib/bb_applet.py: add a simple gnome-panel applet, to
412 display a terse summary of buildbot status.
413 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
414 some icons, small versions of the Blender object that lives in
415 docs/images/icon.blend
417 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
418 * buildbot/slave/commands.py (Bzr): same
419 * buildbot/scripts/tryclient.py (BzrExtractor): same
420 (SourceStampExtractor.dovc): modify this to allow non-zero exit
421 status, since 'bzr diff' does that
422 * buildbot/test/test_vc.py (Bzr): same
423 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
427 2007-01-20 Brian Warner <warner@lothar.com>
429 * contrib/darcs_buildbot.py: tidy up the progress messages
431 2007-01-17 Brian Warner <warner@lothar.com>
433 * contrib/darcs_buildbot.py: enhance to handle multiple patches
434 being pushed at a time. This keeps state in the repository in a
435 small file named .darcs_buildbot-lastchange, but that shouldn't
436 interfere with normal repository operations. Fixes SF#1534049.
437 * buildbot/clients/sendchange.py (Sender): make a single Sender
438 capable of sending Changes with different usernames.
440 2006-12-11 Brian Warner <warner@lothar.com>
442 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
443 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
444 buildbot.changes.mail a long time ago, but I forgot to add the
445 DeprecationWarning until now.
447 * buildbot/process/maxq.py: remove this, the functionality now
448 lives in buildbot.steps.maxq
450 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
451 * buildbot/clients/gtkPanes.py: remove unused import
453 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
454 that was meant to provide a special Reporter to run inside trial
455 and give the buildslave lots of machine-readable status. We never
456 finished this project.
458 * buildbot/changes/bonsaipoller.py: remove unused imports
459 * buildbot/changes/svnpoller.py: same
460 * buildbot/process/builder.py: same
461 * buildbot/process/buildstep.py: same
462 * buildbot/slave/bot.py: hush pyflakes warning
463 * buildbot/status/tests.py: remove unused imports
464 * buildbot/status/tinderbox.py: same
465 * buildbot/steps/python_twisted.py: same
467 * buildbot/process/step.py: remove this file, these names were
468 deprecated in 0.7.5 and are now being removed.
469 * buildbot/process/step_twisted.py: same
470 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
472 * buildbot/twcompat.py: remove the empty file, yay it is gone
474 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
475 tw-2.0.0 and newer have the method we need.
476 (getProcessOutputAndValue): same
477 (which): remove this method, tw-2.0.0 t.p.procutils has it
479 * buildbot/twcompat.py (implements): remove this method
480 * buildbot/*: import implements() from zope.interface directly
482 * buildbot/status/mail.py: stop falling back to importing
483 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
486 * buildbot/twcompat.py (Interface): remove this import
487 * buildbot/*: import Interface from zope.interface directly
489 * buildbot/twcompat.py (providedBy): remove this method
490 * buildbot/*: turn all uses of providedBy(obj, iface) into
491 iface.providedBy(obj)
493 * buildbot/twcompat.py (maybeWait): remove this method, now that
494 we no longer maintain compatibility with Twisted<=1.3.0 .
495 Twisted-2.0.0 and later allow trial methods to return Deferreds
497 * buildbot/test/*: remove all uses of maybeWait
499 * buildbot/__init__.py (version): bump to 0.7.5+ while between
501 * docs/buildbot.texinfo: same
503 2006-12-10 Brian Warner <warner@lothar.com>
505 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
506 * docs/buildbot.texinfo: set version to match
508 2006-12-10 Brian Warner <warner@lothar.com>
510 * README (REQUIREMENTS): update for release
511 * NEWS: update for release
512 * buildbot/slave/commands.py (command_version): mention that this
513 version (2.2) was released with buildbot-0.7.5
515 * buildbot/test/test_config.py (StartService.testStartService):
516 inhibit the usual read-config-on-startup behavior, since otherwise
517 the log.err that gets recorded causes the test to fail
519 * buildbot/status/builder.py (LogFile.finish): forget about all
520 subscribers once the log has finished, since after that point
521 we're never going to use them again. This might help free up some
524 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
525 than the old/deprecated gtk.mainquit()
527 2006-12-09 Brian Warner <warner@lothar.com>
529 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
530 better when we can't open the masterdst file
532 * buildbot/scripts/startup.py (Follower._failure): add missing
533 import statement for BuildSlaveDetectedError
535 * buildbot/steps/transfer.py (FileUpload): cleanup
536 (FileDownload): same. Add tests for slave version, add mode=.
537 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
538 (SlaveFileDownloadCommand): same
539 * buildbot/test/test_transfer.py: enhance tests
540 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
543 2006-12-08 Brian Warner <warner@lothar.com>
545 * buildbot/scripts/runner.py (sendchange): halt the reactor on
546 both success *and* failure. Without this, the 'buildbot
547 sendchange' command would hang if it could not contact the
548 buildmaster or deliver the Change, which would generally cause the
549 user's commit/record/checkin command to hang too. Thanks to
550 Christian Unger for the catch.
552 2006-12-06 Brian Warner <warner@lothar.com>
554 * NEWS: update with items for the next release
556 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
557 whimsical example pulled from a punch-drunk email I sent out late
559 (Transferring Files): document some of the other parameters
560 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
561 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
562 * buildbot/test/test_svnpoller.py: same
563 * buildbot/changes/svnpoller.py (SVNPoller): same
565 2006-11-26 Brian Warner <warner@lothar.com>
567 * docs/buildbot.texinfo (Build Properties): remind users that
568 WithProperties must appear in a command= list, not as a top-level
570 * buildbot/steps/shell.py (ShellCommand.start): and assert that
571 we're sending a list or a single string to the RemoteShellCommand
573 * buildbot/scheduler.py (Nightly): Improve docs slightly.
575 * buildbot/scripts/startup.py (start): skip the whole
576 watch-the-logfile thing under windows, since it needs os.fork()
578 * buildbot/scripts/runner.py (restart): remove the old message
579 that got printed after the buildbot was restarted.. it most cases
580 it didn't get printed at the right time anyways
582 2006-11-25 Brian Warner <warner@lothar.com>
584 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
585 follow twistd.log and print lines until the process has started
586 started properly. For the buildmaster, this means until the config
587 file has been parsed and accepted. For the buildslave, this means
588 until we've connected to the master. We give up after 5 seconds in
589 any case. Helpful error messages and troubleshooting suggestions
590 are printed when we don't see a successful startup. This closes the
591 remainder of SF#1517975.
592 * buildbot/scripts/startup.py: moved app startup code to here
593 * buildbot/scripts/logwatcher.py: utility class to follow log
594 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
595 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
596 so the LogWatcher can tell the difference between a buildmaster
599 2006-11-24 Brian Warner <warner@lothar.com>
601 * docs/examples/twisted_master.cfg: update to match the version
602 in use on twistedmatrix.com
603 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
604 was using before stopped working, but 'irc.freenode.net' works
607 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
610 * buildbot/clients/base.py (TextClient.not_connected): upon
611 UnauthorizedLogin failures, remind the user to connect to the
612 PBListener port instead of the slaveport.
613 (TextClient.disconnected): shut down more quietly
614 * docs/buildbot.texinfo (statuslog): add another reminder
616 * buildbot/scripts/runner.py (Options.subCommands): rename
617 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
618 'sighup' as an alias.
619 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
620 reconfig command to follow twistd.log and print all of the lines
621 from the start of the config-file reload to its completion. This
622 should make it a lot easier to discover bugs in the config file.
623 Use --quiet to disable this behavior. This addresses half of
624 SF#1517975, the other half will be to add this same utility to
625 'buildbot start' and 'buildbot restart'.
626 * docs/buildbot.texinfo (Loading the Config File): same
629 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
630 method, it has been deprecated for a long time. Use
631 IBuilderControl.requestBuild instead.
632 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
633 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
634 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
635 * buildbot/test/test_control.py (Force.testForce): same
636 * buildbot/test/test_run.py: use requestBuild instead
638 * buildbot/clients/debug.py: replace 'Force Build' button with
639 'Request Build' (which just adds one to the queue), add Ping
640 Builder, add branch/revision fields to Request Build.
641 * buildbot/clients/debug.glade: same
642 * buildbot/master.py: update interface to match. This creates an
643 incompatibility between new debugclients and old buildmasters.
645 * buildbot/process/builder.py (Builder._attached): delay the call
646 to maybeStartBuild for a reactor turn, to avoid starting a build
647 in the middle of a reconfig (say, if the new Builder uses a new
648 slave which is already connected).
650 2006-11-23 Brian Warner <warner@lothar.com>
652 * buildbot/test/test_transfer.py: appease pyflakes
653 * buildbot/test/test_steps.py: same
655 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
656 keeps pyflakes from finding undefined names
658 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
659 Builder no longer induces a disconnect/reconnect cycle. This means
660 that any builds currently in progress will not be interrupted, and
661 any builds which are queued in the Builder will not be lost. This
662 is implemented by having the new Builder extract the state (i.e.
663 all pending Builds and any desired SlaveBuilders) from the old
665 (BotPerspective): refactor. The BotPerspective no longer keeps
666 track of all the Builders that want to use this slave; instead, it
667 asks the BotMaster each time it needs this list. This removes
668 addBuilder and removeBuilder. Clean up attached() to acquire all
669 the slave's information in a more atomic fashion. updateSlave() is
670 now the way to make sure the slave is using the right set of
671 Builders: just call it after everything else has been
673 (BotMaster): refactor, removing addBuilder/removeBuilder and
674 replacing them with an all-at-once setBuilders() call.
676 * buildbot/test/test_slaves.py (Reconfig): new test case to
677 exercise this functionality
678 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
679 * buildbot/slave/commands.py (WaitCommand): same
681 * docs/buildbot.texinfo (Loading the Config File): document the
684 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
685 SlaveBuilder to have its parent Builder changed.
686 (SlaveBuilder.isAvailable): new method to give access to state,
687 which is now a private attribute
688 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
689 the SlaveBuilder about how it is being used. These methods update
690 its internal state. buildFinished() is now the place that invokes
691 maybeStartBuild() on its parent Builder.
692 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
693 new Builder to take over for an old one, transferring state from
695 (Buider): refactor the way that SlaveBuilders are used to match,
696 giving them a bit more autonomy.
697 (Builder.buildFinished): this no longer calls maybeStartBuild():
698 instead the SlaveBuilder calls it on whoever its parent Builder is
699 at the time. This way, when an old Builder is replaced by a new
700 one, and there was a build in progress during the transition, when
701 that build finishes, it will be the new Builder that is told about
702 the newly available slave so it can start a new build.
704 * buildbot/process/base.py (Build.startBuild._release_slave): when
705 the Build finishes, tell the SlaveBuilder that they've been
708 * buildbot/status/builder.py (SlaveStatus): add some new setter
709 methods for use by BotPerspective, to keep some attributes more
712 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
713 called by the buildmaster.
714 (Bot.setBuilderList): instead, we locally announce any leftover
715 directories based upon which Builders we were told about. The
716 master doesn't really care; it's the local admin who may or may not
720 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
721 to allow use of python2.4 or whatever. This tool still requires
724 2006-11-19 Brian Warner <warner@lothar.com>
726 * NEWS (IStatusLog.readlines): more news items
728 2006-11-18 Brian Warner <warner@lothar.com>
730 * NEWS: start collecting items for the next release.
732 2006-11-04 Brian Warner <warner@lothar.com>
734 * buildbot/changes/bonsaipoller.py: apply updates from Ben
735 Hearsum. Closes SF#1590310.
736 * buildbot/test/test_bonsaipoller.py: and tests
738 * buildbot/status/tinderbox.py
739 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
740 status when the build results in WARNINGS. Patch from Dave
741 Liebreich. Closes SF#1587352.
743 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
744 linux-vs-osx behavior difference w.r.t. reading from files that
745 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
746 to Mark Rowe for the patch.
748 2006-10-15 Brian Warner <warner@lothar.com>
750 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
751 method name was misspelled in the interface definition. Thanks to
752 Roy Rapoport for the catch.
754 2006-10-13 Brian Warner <warner@lothar.com>
756 * docs/buildbot.texinfo (Adding LogObservers): update sample code
757 to match the great Steps renaming
759 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
760 Maybe I should run my own unit tests before recording a big
761 change. Good thing I've got a buildbot to remind me.
763 2006-10-12 Brian Warner <warner@lothar.com>
765 * buildbot/steps/transfer.py: rework __init__ and args setup
766 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
768 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
769 when opening the target file, only catch IOError (to report via
770 stderr/rc!=0), let the others be reported as normal exceptions
772 2006-10-08 Brian Warner <warner@lothar.com>
774 * contrib/svn_watcher.py: fix security holes by using proper argv
775 arrays and subprocess.Popen() rather than commands.getoutput().
776 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
777 is deprecated in favor of buildbot/changes/svnpoller.py, and will
778 probably be removed by the next release.
781 2006-10-04 Brian Warner <warner@lothar.com>
783 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
784 initial lines that weren't emitted by pyflakes. When the pyflakes
785 command is run under a Makefile, 'make' will echo the command it
786 runs to stdio, and that was getting logged as a "misc" warning.
787 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
788 * buildbot/test/test_steps.py (testPyFlakes3): another test
790 2006-10-01 Brian Warner <warner@lothar.com>
792 * buildbot/status/html.py (HtmlResource.render): if we get a
793 unicode object from our content() method, encode it into utf-8
794 like we've been claiming to all along. This allows the comments
795 and author names from svnpoller.py to be delivered properly.
797 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
798 de-unicodify filenames before creating the Change, because the
799 rest of buildbot is unlikely to handle them well. Leave the 'who'
800 field as a unicode object.. I don't think there's anything that
801 will break very soon, and it will probably nudge us towards
802 accepting unicode everywhere sooner or later. Stop using the
803 "date" field that comes out of SVN, since it is using the
804 repository's clock (and timezone) and what we care about is the
805 buildmaster's (otherwise Changes from the future show up later
806 than the builds they triggered).
807 * buildbot/test/test_svnpoller.py (Everything.test1): match the
810 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
811 Suvbersion repository polling ChangeSource. I've hacked it up
812 considerably: any bugs are entirely my own fault. Thank you
814 * buildbot/test/test_svnpoller.py: tests for it
815 * docs/buildbot.texinfo (SvnSource): document it
817 2006-09-30 Brian Warner <warner@lothar.com>
819 * buildbot/scheduler.py (Periodic): submit a reason= to the
820 BuildSet to indicate which Scheduler triggered the build. Thanks
821 to Mateusz Loskot for the suggestion.
823 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
825 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
826 changes: set self.loop in __init__, remove unused volatile=
828 * docs/buildbot.texinfo (.buildbot config directory): add more
829 docs on the .buildbot/options keys used by "buildbot try"
830 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
831 (Try.deliverJob): same
833 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
837 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
838 close the filehandle when we stop watching the file. Before, the
839 filehandle was only closed when the LogFileWatcher was
840 garbage-collected, which could be quite a while in the future. If
841 it was still open by the time the next build started, windows will
842 refuse to let the new build delete the old build/ directory. Fixes
843 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
844 #twisted for the catch.
846 2006-09-29 Brian Warner <warner@lothar.com>
848 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
851 2006-09-25 Brian Warner <warner@lothar.com>
853 * setup.py: the new buildbot.steps module wasn't being installed.
854 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
855 (testmsgs): add the extra stuff from buildbot/test/* so you can
856 run unit tests on an installed copy of buildbot, not just from
859 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
860 columns of 'svnlook changed' output contain status information, so
861 strip [:4] instead of [:6]. Depending upon what the status flags
862 were, this would sometimes lead to mangled filenames. Thanks to
863 Riccardo Magliocchetti for the patch. Closes SF#1545146.
865 * buildbot/steps/source.py (Monotone): initial Monotone support,
866 contributed by Nathaniel Smith. Still needs docs and tests, but
867 this code has been in use on the Monotone buildbot for a long
869 * buildbot/slave/commands.py (Monotone): slave-side support
870 * buildbot/changes/monotone.py (MonotoneSource): polling change
873 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
874 contributed a Change Source that polls a Bonsai server (a
875 kind of web-based viewcvs CGI script).
877 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
878 Hearsum contributed a status plugin which sends email in the same
879 format that Tinderbox does: this allows a number of tinderbox
880 tools to be driven by Buildbot instead. Thanks Ben!
882 2006-09-24 Brian Warner <warner@lothar.com>
884 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
885 Thanks to Robert Helmer for the patch.
887 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
888 BuildStatus about the buildslave name at the *beginning* of the
889 build, rather than at the end. Thanks to Alexander Lorenz for the
891 * buildbot/status/html.py (StatusResourceBuild.body): always
892 include the slavename in the build page, not just when the build
894 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
895 slavename in the email message
897 2006-09-21 Brian Warner <warner@lothar.com>
899 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
901 * docs/examples/glib_master.cfg: same
902 * docs/examples/hello.cfg: same
903 * docs/examples/twisted_master.cfg: same, update to current usage
905 2006-09-19 Brian Warner <warner@lothar.com>
907 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
908 (PyFlakes.createSummary): make it compatible with python-2.2
910 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
911 for at least the output-parsing parts of PyFlakes
913 2006-09-18 Brian Warner <warner@lothar.com>
915 * buildbot/steps/python.py: oops, fix import of StringIO
917 2006-09-17 Brian Warner <warner@lothar.com>
919 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
920 turns out that SVN-1.4.0 doesn't fail to update once you've
921 replaced a file with a directory, unlike older versions of SVN and
922 pretty much every other VC tool we support. Since what we really
923 care about is that the update succeeds anyway, stop checking that
924 the tree got clobbered and just assert that the build succeeded.
925 (VCBase.printLogs): add a utility function for debugging
927 * buildbot/process/step.py: oops, added extra imports by mistake
929 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
930 rstrip() on the first line coming out of the 'p4 describe'
931 process, to remove the stray ^M that Wade Brainerd reports seeing
932 in the 'when' field. Fixes SF#1555985.
934 * buildbot/master.py (BuildMaster.loadConfig): improve the error
935 message logged when c['schedulers'] is not right
936 * buildbot/scheduler.py (Scheduler.__init__): improve error
937 message when a Scheduler() is created with the wrong arguments
938 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
939 verify that these error messages are emitted
941 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
942 The idea is that all the base classes (like BuildStep and
943 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
944 will be a leftover backwards-compatibility file that only contains
945 aliases for the steps that were moved out to buildbot.steps.*
946 * lots: change imports to match
947 * buildbot/process/step.py: add a DeprecationWarning if it ever
950 2006-09-12 Brian Warner <warner@lothar.com>
952 * buildbot/scheduler.py (Scheduler.__init__): make sure that
953 builderNames= is actually a sequence, since if you happen to give
954 it a single builder-specification dictionary instead, it won't get
955 caught by the existing assert. Thanks to Brett Neely for the
958 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
960 * docs/buildbot.texinfo (Python BuildSteps): document them
961 (sendchange): include a link to PBChangeSource, since you need one
963 * buildbot/steps/shell.py: clean up test-case-name line, remove some
965 * buildbot/steps/dummy.py: same
967 2006-09-08 Brian Warner <warner@lothar.com>
969 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
970 BuildStep which lets you transfer files from the master to the
971 slave or vice versa. Thanks to Albert Hofkamp for the original
972 patch. Fixes SF#1504631.
973 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
975 (SlaveFileDownloadCommand): same
976 * docs/buildbot.texinfo (Transferring Files): document it
977 * buildbot/test/test_transfer.py: test it
978 * buildbot/test/runutils.py (StepTester): new utility class for
979 testing BuildSteps and RemoteCommands without Builds or Bots or PB
980 * buildbot/test/test_steps.py (CheckStepTester): validate that the
983 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
984 walk through StatusLogs one line at a time, mostly for the benefit
985 of ShellCommand.createSummary methods. You can either walk through
986 STDOUT or STDERR, but the default is STDOUT.
988 * buildbot/status/builder.py (LogFile.readlines): implement it.
989 Note that this is not yet memory-efficient, it just pulls the
990 whole file into RAM and then splits it up with a StringIO.
991 Eventually this should be a generator that only pulls chunks from
993 * buildbot/test/test_status.py (Log.testReadlines): test it
995 * docs/buildbot.texinfo: update to match changes
996 * buildbot/process/factory.py: stop using old definitions
997 * buildbot/process/process_twisted.py: same
998 * buildbot/test/test_*.py: same
1000 * buildbot/process/step_twisted.py: move definition to..
1001 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1002 relative-import mechanisms prevent this from being named 'twisted'
1003 or 'python/twisted' as I would have preferred.
1005 * buildbot/process/maxq.py: move definition to..
1006 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1008 * buildbot/process/step.py: split the user-visible BuildSteps into
1009 separate files, all under buildbot/steps/
1010 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1011 * buildbot/steps/shell.py: this holds ShellCommand and friends
1012 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1014 2006-09-05 Brian Warner <warner@lothar.com>
1016 * lots: run pyflakes, removed a lot of unused imports, changed the
1017 form of some conditional imports to remove false pyflakes
1018 warnings. There are still a number of warnings left, mostly from
1019 imports that are done for their side-effects.
1020 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1023 2006-08-26 Brian Warner <warner@lothar.com>
1025 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1026 compatible with twisted-1.3.0, for some reason I just can't seem
1027 to let go of the past.
1029 2006-08-25 Brian Warner <warner@lothar.com>
1031 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1033 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1034 all logfiles= in startCommand(), rather than in start() . This
1035 makes it easier to have the 'stdio' log come before any secondary
1036 logfiles, which I feel makes the waterfall display more
1038 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1039 from ShellCommand up into LoggingBuildStep
1040 (LoggingBuildStep.__init__): move the handling of logfiles= from
1041 ShellCommand up to LoggingBuildStep, because startCommand is
1042 provided by LoggingBuildStep, whereas start() was specific to
1043 subclasses like ShellCommand and Source. This removes code
1044 duplication in those subclasses.
1045 (ShellCommand.__init__): same
1046 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1047 for a slave that's too old to understand logfiles= into a separate
1048 method, so it can live in ShellCommand. The rest of
1049 setupLogfiles() can live in LoggingBuildStep.
1051 2006-08-24 Brian Warner <warner@lothar.com>
1053 * buildbot/locks.py (BaseLock): you can now configure Locks to
1054 allow multiple simultaneous owners. They still default to
1055 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1057 * docs/buildbot.texinfo (Interlocks): document the new options
1058 * buildbot/test/test_locks.py: add a bunch of new unit tests
1059 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1060 waitUntilMaybeAvailable, not waitUntilAvailable
1061 * buildbot/process/step.py (BuildStep.acquireLocks): same
1062 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1063 the whole lockid in their constructor, not just the name. Also,
1064 keep track of which real locks we've handed out by the full
1065 lockid, not just class+name, otherwise changing just the maxCount=
1066 in the master.cfg file would not actually cause a behavioral
1069 2006-08-23 Brian Warner <warner@lothar.com>
1071 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1073 * docs/buildbot.texinfo: same
1075 2006-08-23 Brian Warner <warner@lothar.com>
1077 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1078 * docs/buildbot.texinfo: set version to match
1079 * NEWS: update for 0.7.4
1080 * buildbot/slave/commands.py (command_version): mention that this
1081 version (2.1) was released with buildbot-0.7.4
1083 2006-08-22 Brian Warner <warner@lothar.com>
1087 * CREDITS: new file, list of people who have helped. Thanks!
1088 * MANIFEST.in: ship it
1090 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1091 new diagrams, the user's manual is more informative than it was.
1092 Start shipping the .html user's manual (and generated .png
1094 * Makefile: update 'release' target to match
1096 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1097 test.. I think the web-parts effort will render it pointless well
1098 before it ever actually starts to work.
1100 2006-08-20 Brian Warner <warner@lothar.com>
1102 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1103 meaning of the prefix= argument. It is now just a string which is
1104 stripped from the beginning of the filename. If prefix= is set but
1105 not found on any given filename, that filename is ignored. If all
1106 filenames in a Change are ignored, the Change is dropped. This is
1107 much simpler than the previous sep= nonsense, and I should have
1108 implemented it this way from the beginning. Effectively resolves
1109 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1110 Gedminas for the catch and suggested fixes.
1111 (ChangePerspective.perspective_addChange): implement the actual
1113 * buildbot/test/test_changes.py (TestChangePerspective): test it
1114 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1115 how to properly use prefix=
1116 * docs/examples/twisted_master.cfg (source): update prefix= by
1117 adding the trailing slash
1120 * docs/examples/twisted_master.cfg: update to actual practice
1122 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1123 update test case to match new link text.. the HREF has both a
1124 class= setting and an enclosing [] pair that I didn't match in the
1127 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1128 list of strings is preferred over a single string with embedded
1130 (ShellCommand.description=): explain that either single strings or
1131 a list of strings is acceptable, and why you might prefer one over
1132 the other. Add an example. Fixes SF#1524659, thanks to Paul
1133 Winkler for the catch.
1134 (Build Steps): update to use f.addStep() rather than using s()
1135 and the constructor list
1137 * buildbot/process/step.py (ShellCommand): accept either a single
1138 string or a list of strings in both description= and
1140 * buildbot/test/test_steps.py (Steps.test_description): test it
1141 * buildbot/test/runutils.py (makeBuildStep): support for that test
1143 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1144 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1145 collecting the files and creating the patch.
1147 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1148 per-step URLs that will be displayed on the waterfall display,
1149 for things like the HTML output of code-coverage tools, when
1150 the results are hosted elsewhere.
1151 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1152 way to retrieve these URLs
1153 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1154 the method to retrieve these URLs. Also provide backwards
1155 compatibility for saved BuildStepStatus instances that didn't have
1157 * buildbot/process/step.py (BuildStep.addURL): method to set these
1158 URLs from within a BuildStep
1159 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1160 (StepBox.getBox): give these external links a distinct CSS class
1161 named "BuildStep external" so a .css file can display them
1164 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1166 * buildbot/test/test_steps.py (Steps): test that we can all the
1167 URLs. Also add a bunch of other tests on methods that can be
1168 called from within BuildSteps
1169 * buildbot/test/runutils.py (makeBuildStep): add utility function
1171 2006-08-13 Brian Warner <warner@lothar.com>
1173 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1175 2006-08-10 Brian Warner <warner@lothar.com>
1177 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1178 index, this one of things like c['sources'] and c['schedulers']
1179 (indices): it looks like my clever idea of putting the @fooindex
1180 commands in between the @node and the @subsection (to make the
1181 HREF anchor jump to slightly above the section title, which works
1182 much better in html) confused texinfo horribly, so I'm moving the
1183 index tags back to be just after the @subsection marker. I also
1184 added extra lines between the @node/@section paragraph and the
1185 index tags, since I think maybe texinfo wants to see these be
1186 separate paragraphs.
1188 * docs/Makefile (images): make sure images get built when
1189 rendering the manual
1190 * docs/images/Makefile: same
1192 * buildbot/scripts/runner.py: rename 'buildbot master' to
1193 'buildbot create-master', and 'buildbot slave' to 'buildbot
1195 * docs/buildbot.texinfo: same
1198 * docs/buildbot.texinfo: reimplement the "useful classes" index
1199 with actual texinfo indices. The .info rendering is a bit
1200 weird-looking but it works well, and the HTML rendering is quite
1201 nice. This also puts the index targets in the regular flow of the
1202 text, which is easier to maintain.
1204 2006-08-06 Brian Warner <warner@lothar.com>
1206 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1207 Kevin Turner to prefer the environ= argument be a list rather than
1208 a string. If it is a list, it will be joined with a platform-local
1209 os.pathsep delimiter, and then prepended to any existing
1210 $PYTHONPATH value. This works better in cross-platform (i.e.
1211 windows buildslaves) environments when you need to push multiple
1212 directories onto the front of the path.
1213 (SlaveShellCommand): documented the new magic
1214 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1215 in a user-visible form
1217 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1218 Turner to prefer lists over strings when creating/running VC
1219 commands during unit tests. This is clearly necessary to survive
1220 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1221 renamed the wq() function to qw() though, since that's how it's
1222 spelled in perl. Eventually I'd prefer all commands to be
1223 specified with lists.
1225 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1226 which are deleted (or not yet created) correctly. Also add
1227 failsafe code to not explode if the file-watching poller doesn't
1228 get started. Thanks to JP Calderone for the catch and the poller
1230 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1232 * buildbot/test/emitlogs.py: same
1234 * NEWS: summarize recent changes
1236 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1237 clause to avoid the "host key mismatch" warning
1239 * buildbot/process/step_twisted.py (Trial.start): if the
1240 buildslave is too old to understand logfiles=, fall back to
1241 running 'cat _trial_temp/test.log' like before.
1242 (Trial.commandComplete): same. this takes advantage of the
1243 LoggingBuildStep refactoring to stall commandComplete long enough
1244 to run a second RemoteShellCommand.
1246 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1247 refactor command-completion handling, to allow methods like
1248 commandComplete/createSummary/evaluateCommand to return Deferreds.
1249 (LoggingBuildStep._commandComplete): delete the refactored method
1250 (ShellCommand.setupLogfiles): if the buildslave is too old to
1251 understand logfiles=, put a warning message both into twistd.log
1252 and into the otherwise empty user-visible LogFiles.
1254 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1255 callers to provide the slave-side logfile name, rather than
1256 forcing it to come from the local name of the LogFile.
1257 (BuildStep.getSlaveName): new method
1259 * buildbot/process/base.py (Build.getSlaveName): new method, so
1260 steps can find out which buildslave they're running on
1262 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1263 to match the s/cvs_ver/command_version/ change
1265 2006-08-05 Brian Warner <warner@lothar.com>
1267 * buildbot/slave/commands.py (command_version): replace the CVS
1268 auto-updated cvs_ver keyword with a manually-updated variable,
1269 since CVS is no longer the master repository. Add a description of
1270 the remote API change starting in this version (2.1), specifically
1271 the fact that SlaveShellCommand now accepts 'initial_stdin',
1272 'keep_stdin_open', and 'logfiles'.
1274 2006-07-31 Brian Warner <warner@lothar.com>
1276 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1277 diagrams to describe how the whole system fits together. The
1278 images themselves are kept in SVG files, with ascii-art versions
1279 in corresponding .txt files. Texinfo knows how to interpolate the
1280 text version into .info files, reference the .png versions from
1281 .html files, and include .eps versions in the .ps format.
1282 * docs/images/Makefile: tools to create .png and .eps
1283 * docs/images/*.svg: created pictures with Inkscape.
1284 * .darcs-boring: ignore the generated .eps and .png files
1286 2006-07-24 Brian Warner <warner@lothar.com>
1288 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1289 Scheduler names, since they cause setServiceParent to explode
1291 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1293 2006-07-20 Brian Warner <warner@lothar.com>
1295 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1296 which runs the buildbot unit tests
1298 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1299 classes that are useful in master.cfg
1301 2006-07-15 Brian Warner <warner@lothar.com>
1303 * Makefile (some-apidocs): new target to build only some epydocs
1305 * setup.py: minor comment.. does the classifiers= argument prevent
1306 the setup.py script from working on python2.2/2.3?
1308 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1311 * buildbot/twcompat.py: fix minor typo in comments
1313 * buildbot/manhole.py: move all Manhole-related code out to this
1314 module. Implement SSH-based manholes (with TwistedConch), and move
1315 to conch's nifty line-editing syntax-coloring REPL shell instead
1316 of the boring non-editing monochromatic (and deprecated) old
1318 * buildbot/master.py: remove all Manhole-related code
1319 (BuildMaster.loadConfig._add): make sure the old manhole is
1320 removed before we add the new one
1321 * docs/buildbot.texinfo (Debug options): document new Manhole options
1323 * buildbot/twcompat.py (_which): fix some epydoc issues
1324 * buildbot/status/html.py (Waterfall.__init__): same
1326 2006-06-29 Brian Warner <warner@lothar.com>
1328 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1329 deprecation warnings under newer Twisteds (by using
1330 zope.interface.Interface instead of old twisted.python.components
1332 * buildbot/slave/interfaces.py: same
1334 2006-06-28 Brian Warner <warner@lothar.com>
1336 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1337 svn commands, so it will fail immediately instead of hanging while
1338 it waits for a username/password to be typed in.
1340 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1341 log message if the step was shut down
1343 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1344 obsolete reference to mktap.
1346 2006-06-20 Brian Warner <warner@lothar.com>
1348 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1349 test to include new 'logfiles' argument sent from master to slave
1351 2006-06-19 Brian Warner <warner@lothar.com>
1353 * buildbot/process/step_twisted.py (Trial): track Progress from
1354 _trial_temp/test.log too
1356 * buildbot/process/step.py (OutputProgressObserver): generalize
1357 the earlier StdioProgressObserver into an OutputProgressObserver
1358 that can track LogFiles other than stdio.
1359 (LoggingBuildStep.__init__): same
1361 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1362 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1363 will fail under windows because of os.sep issues. It might have
1364 worked before if 'cat' was doing cygwin path conversion.
1366 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1367 creation of LogFileWatchers
1368 (ShellCommand._startCommand): and record the files that were
1369 watched in the 'headers' section of the ShellCommand output
1371 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1372 need to actually pass it to the slave if you want it to work.
1373 (ShellCommand): document it a bit
1375 * buildbot/test/test_shell.py: new test to validate LogFiles
1376 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1378 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1379 before printing the last batch of lines, to test that the polling
1380 logic is working properly
1382 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1383 handling, making it possible to track multiple logs for a single
1384 RemoteCommand. The previous single logfile is now known as the
1386 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1387 (RemoteShellCommand.__init__): accept logfiles=
1388 (LoggingBuildStep.startCommand): stdio_log is now one of many
1389 (ShellCommand): added logfiles= argument, as well as a class-level
1390 .logfiles attribute, which will be merged together to figure out
1391 which logfiles should be tracked. The latter maybe be useful for
1392 subclasses of ShellCommand which know they will aways produce
1393 secondary logfiles in the same location.
1395 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1396 and closeStdin() methods, preparing to make it possible to write
1397 to a ShellCommand's stdin at any time, not just at startup. These
1398 writes are buffered if the child process hasn't started yet.
1399 (LogFileWatcher): new helper class to watch arbitrary logfiles
1400 while a ShellCommand runs. This class polls the file every two
1401 seconds, and sends back 10k chunks to the buildmaster.
1402 (ShellCommand): rename stdin= to initialStdin=, and add
1403 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1405 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1406 key of "log" and a value of (logname, data).
1407 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1408 'logfiles' to the master-visible args dictionary.
1409 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1412 * buildbot/test/test_vc.py (Patch.testPatch): same
1415 * buildbot/test/emit.py: write to a logfile in the current
1416 directory. We use this to figure out what was used as a basedir
1417 rather than looking to see which copy of emit.py gets run, so that
1418 we can run the commands from inside _trial_temp rather than inside
1420 * buildbot/test/subdir/emit.py: same
1421 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1422 argument rather than running from buildbot/test/
1423 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1424 rather than using an implicit setUp()
1425 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1426 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1427 of assuming that we're running in buildbot/test/ (and that '.' is
1430 * buildbot/slave/commands.py (Command.doStart): refactor Command
1431 startup/completion a bit: now the SlaveBuilder calls doStart(),
1432 which is not meant for overridding by subclasses, and doStart()
1433 calls start(), which is. Likewise the SlaveBuilder calls
1434 doInterrupt(), and subclasses override interrupt(). This also puts
1435 responsibility for maintaining .running in Command rather than in
1437 (Command.doInterrupt): same
1438 (Command.commandComplete): same, this is called when the deferred
1439 returned by start() completes.
1440 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1441 (SlaveBuilder.remote_interruptCommand): same
1442 (SlaveBuilder.stopCommand): same
1444 2006-06-16 Brian Warner <warner@lothar.com>
1446 * buildbot/test/test_shell.py: new test file to contain everything
1447 relating to ShellCommand
1448 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1449 multiple logfiles in realtime" feature, not yet implemented
1450 * buildbot/test/emitlogs.py: support file for testLogFiles
1451 * docs/buildbot.texinfo (ShellCommand): document the feature
1453 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1455 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1456 for tests which exercise SlaveCommands in isolation.
1458 * buildbot/test/test_slavecommand.py: Move some utilities like
1459 SignalMixin and FakeSlaveBuilder from here ..
1460 * buildbot/test/runutils.py: .. to here, so they can be used by
1461 other test classes too
1462 * buildbot/test/test_vc.py: more SignalMixin refactoring
1463 * buildbot/test/test_control.py: same
1464 * buildbot/test/test_run.py: and some rmtree refactoring
1466 2006-06-15 Brian Warner <warner@lothar.com>
1468 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1469 'testBranch' to match other VC tests and have the tests run in
1470 roughly increasing order of dependency
1472 * buildbot/test/test_steps.py (LogObserver): new test to verify
1473 LogObservers can be created at various times and still get
1474 connected up properly
1476 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1477 to create BuildStepStatus instances that actually work.
1479 * buildbot/process/step.py (LogObserver): add outReceived and
1480 errReceived base methods, to be overridden
1482 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1483 API to take a name instead of a step, reducing the coupling
1484 somewhat. This returns the BuildStepStatus object so it can be
1485 passed to the new Step, instead of jamming it directly into the
1487 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1489 * buildbot/process/base.py (Build.setupBuild): use both methods
1490 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1491 process a bit to match
1493 2006-06-14 Brian Warner <warner@lothar.com>
1495 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1496 docs on writing new LogObserver classes
1497 (Writing New Status Plugins): brief docs on how Status Plugins fit
1500 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1501 implement a LogObserver that counts how many unit tests have been
1503 (Trial.__init__): wire it in
1504 * buildbot/test/test_twisted.py (Counter): unit test for it
1506 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1507 to new cmd.logs['stdio'] scheme
1508 (Trial.commandComplete): same
1509 (BuildDebs.commandComplete): same
1511 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1512 LogFiles, instead of just a single one. The old single logfile is
1513 now called "stdio". LoggedRemoteCommand no longer creates a
1514 LogFile for you (the code to do that was broken anyway). If you
1515 don't create a "stdio" LogFile, then stdout/stderr will be
1517 (LogObserver): implement "LogObservers", which a BuildStep can add
1518 to parse the output of a command in real-time. The primary use is
1519 to provide more useful information to the Progress code, allowing
1520 better ETA estimates.
1521 (LogLineObserver): utility subclass which feeds complete lines to
1522 the parser instead of bytes.
1523 (BuildStep.progressMetrics): this is safer as a tuple
1524 (BuildStep.setProgress): utility method, meant to be called by
1526 (BuildStep.addLogObserver): new method, to be called at any time
1527 during the BuildStep (even before any LogFiles have been created),
1528 to attach (or schedule for eventual attachment) a LogObserver to a
1530 (StdioProgressObserver): new LogObserver which replaces the old
1531 "output" progress gatherer
1532 (LoggingBuildStep.__init__): same
1533 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1534 (LoggingBuildStep._commandComplete): must use logs['stdio']
1535 instead of the old single ".log" attribute.
1536 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1537 functionality, now subsumed into StdioProgressObserver
1538 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1539 log name changed from "output" to "stdio".
1542 * buildbot/interfaces.py (ILogFile): add the Interface used from
1543 the BuildStep towards the LogFile
1544 (ILogObserver): and the one provided by a LogObserver
1545 * buildbot/status/builder.py (LogFile): implement it
1547 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1548 HEADER constants here ..
1549 * buildbot/status/builder.py (STDOUT): .. from here
1551 2006-06-13 Brian Warner <warner@lothar.com>
1553 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1554 compatibility with python2.2, which doesn't have the 'substr in
1556 (TestP4Poller.makeTime): utility function to construct the
1557 timestamp using the same strptime() approach as p4poller does. It
1558 turns out that time.mktime() behaves slightly differently under
1559 python2.2, probably something to do with the DST flag, and that
1560 causes the test to fail under python2.2. (changing the mktime()
1561 arguments to have dst=0 instead of -1 caused it to fail under
1562 python2.3. Go figure.)
1563 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1565 2006-06-12 Brian Warner <warner@lothar.com>
1567 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1568 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1569 contributing such an excellent patch, including docs and unit
1570 tests! This makes it *so* much easier to apply. I had to update
1571 test_vc.py to handle some recent refactorings, but everything else
1572 applied smoothly. The only remaining thing I'd like to fix would
1573 be to remove the hard-wired port 1666 used by p4d, and allow it to
1574 claim any unused port. This would allow two copies of the test
1575 suite to run on the same host at the same time, as well as
1576 allowing the test suite to run while a real (production) p4d was
1577 running on the same host. Oh, and maybe we should add a warning to
1578 step.P4 that gets emitted if the slave is too old to provide the
1579 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1580 * buildbot/slave/commands.py (P4): same
1581 (P4Sync): same, some minor updates
1582 * buildbot/changes/p4poller.py: same
1583 * docs/buildbot.texinfo: same
1584 * buildbot/test/test_p4poller.py: same
1585 * buildbot/test/test_vc.py (P4): same
1587 * setup.py: add Trove classifiers for PyPI
1589 2006-06-08 Brian Warner <warner@allmydata.com>
1591 * buildbot/status/client.py
1592 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1593 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1594 build needs to be IRemote'd separately, rather than IRemote'ing
1595 the whole list at once. I can't wait until newpb's serialization
1596 adapters make this unnecessary.
1598 2006-06-06 Brian Warner <warner@lothar.com>
1600 * buildbot/process/step.py (WithProperties): make this inherit
1601 from ComparableMixin, so that reloading an unchanged config file
1602 doesn't cause us to spuriously reload any Builders which use them.
1603 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1606 2006-06-03 Brian Warner <warner@lothar.com>
1608 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1609 running py2exe on windows, contributed by Mark Hammond. Addresses
1610 SF#1401121, but I think we still need to include
1611 buildbot/scripts/sample.cfg
1612 * setup.py: include buildbot_service.py as a script under windows
1613 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1614 a py2exe application), get the icon/css datafiles from a different
1617 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1618 double-escape the build URL. Thanks to Olivier Bonnet for the
1619 patch. Fixes SF#1452801.
1621 2006-06-02 Brian Warner <warner@lothar.com>
1623 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1624 first six columns of 'svnlook' output, not just the first column,
1625 since property changes appear in the other five. Thanks to Olivier
1626 Bonnet for the patch. Fixes SF#1398174.
1628 2006-06-01 Brian Warner <warner@lothar.com>
1630 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1631 the fake build, so that title= has something to be set to
1633 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1634 attribute of the "Build #NN" link in the yellow start-the-build
1635 box to the build's reason. This means that you get a little
1636 tooltip explaining why the build was done when you hover over the
1637 yellow box. Thanks to Zandr Milewski for the suggestion.
1639 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1640 (Box.setETA): handle ETA=None (by stopping the timer)
1641 (Box.update): make the [soon] text less different than the usual
1642 text, so the rest of the text doesn't flop around so much. It
1643 would be awfully nice to figure out how to center this stuff.
1644 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1646 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1647 by default, so that any ShellCommand which fails marks the overall
1648 build as a failure. I should have done this from the beginning.
1649 Add flunkOnFailure=False to the arguments if you want to turn off
1652 2006-05-30 Brian Warner <warner@lothar.com>
1654 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1655 last-build/current-build/current-step. Show what step is currently
1656 running. Show ETA for both the overall build and the current step.
1657 Update GTK calls to modern non-deprecated forms. There's still a
1658 lot of dead code and debug noise to remove.
1660 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1661 shows up properly in status displays
1663 2006-05-28 Brian Warner <warner@lothar.com>
1665 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1666 build we use to verify that WithProperties works:
1668 ** set flunkOnFailure=True so that build failures get noticed
1669 ** set workdir='.' so that the build succeeds, otherwise it is trying
1670 to touch 'build/something', and 'build/' doesn't exist because
1671 usually that's created by a Source step
1672 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1673 this test somehow triggers, in which the 'touch' process becomes
1674 a zombie and we wait for th etimeout before giving up on it.
1676 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1677 to log the Build results and step logs to the twisted log.
1678 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1679 what went wrong if a build was expected to succeed but didn't.
1681 * buildbot/process/step_twisted.py (Trial): set the default
1682 trialMode to '--reporter=bwverbose', which specifies verbose
1683 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1684 '-to', but those are completely missing in modern Twisteds.
1686 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1687 a localhost-only port, to encourage better security
1689 * docs/buildbot.texinfo (Change Sources): mention
1692 * .darcs-boring: add a Darcs boringfile
1694 * README (REQUIREMENTS): stop claiming compatibility with
1697 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1700 2006-05-27 Brian Warner <warner@lothar.com>
1702 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1703 * docs/buildbot.texinfo: same
1705 2006-05-23 Brian Warner <warner@lothar.com>
1707 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1708 * docs/buildbot.texinfo: set version to match
1709 * NEWS: update for 0.7.3
1711 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1712 give a quick mapping from VC system to possible ChangeSources
1713 (Build Properties): add 'buildername'
1715 * buildbot/process/base.py (Build.setupStatus): oops, set
1716 'buildername' and 'buildnumber' properties
1717 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1720 2006-05-22 Brian Warner <warner@lothar.com>
1722 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1723 property interpolation better
1725 * README (INSTALLATION): remove old '-v' argument from recommended
1728 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1729 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1732 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1733 'svnversion' instead of grepping the output of 'svn info', much
1734 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1735 Bonnet for the suggestion.
1736 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1737 require the WC_PATH argument, so run 'svnversion .' instead.
1739 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1740 aren't supposed to have 'self' in their argument list
1742 2006-05-21 Brian Warner <warner@lothar.com>
1744 * buildbot/process/step.py (ShellCommand.start): make
1745 testInterpolate pass. I was passing the uninterpolated command to
1746 the RemoteShellCommand constructor
1747 (ShellCommand._interpolateProperties): oops, handle non-list
1748 commands (i.e. strings with multiple words separated by spaces in
1749 them) properly, instead of forgetting about them.
1751 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1752 to actually try to use build properties in a real build. This test
1754 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1755 to start and evaluate builds
1757 * buildbot/test/test__versions.py: add a pseudo-test to record
1758 what version of Twisted/Python/Buildbot are running. This should
1759 show up at the beginning of _trial_tmp/test.log, and exists to help
1760 debug other problems.
1762 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1763 a filename to be served as 'robots.txt' to discourage web spiders.
1764 Adapted from a patch by Tobi Vollebregt, thanks!
1765 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1766 (Waterfall.test_waterfall): tweak the way that filenames are put
1767 into the config file, to accomodate windows pathnames better.
1769 * docs/buildbot.texinfo (HTML Waterfall): document it
1771 * buildbot/process/process_twisted.py
1772 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1773 changed the build process. The new setup.py no longer takes the
1775 (FullTwistedBuildFactory.__init__): same
1776 (TwistedReactorsBuildFactory.__init__): same
1778 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1779 be placed in the [hooks] section of the central repository (the
1780 one that everybody pushes changes to).
1782 2006-05-20 Brian Warner <warner@lothar.com>
1784 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1785 .darcs-context file, use binary mode. I think this was causing a
1786 Darcs failure under windows.
1788 2006-05-19 Brian Warner <warner@lothar.com>
1790 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1791 use a timezone string of +0000 and gmtime, since this timestamp is
1792 sent to a buildmaster and %z is broken.
1794 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1795 string and localtime, since this timestamp will only be consumed
1796 locally, and %z is broken.
1798 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1799 gmtime, since this timestamp is returned to the buildmaster, and
1802 2006-05-18 Brian Warner <warner@lothar.com>
1804 * NEWS: update in preparation for next release
1806 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1807 setup-repository and do-we-have-the-vc-tools code into a separate
1808 "helper" class, which sticks around in a single module-level
1809 object. This seems more likely to continue to work in the future
1810 than having it hide in the TestCase and hope that TestCases stick
1811 around for a long time.
1813 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1814 addremove' has been deprecated in recent versions of mercurial, so
1815 use 'hg add' instead
1817 2006-05-07 Brian Warner <warner@lothar.com>
1819 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1820 operating under windows, move the file before opening it, since
1821 you can't rename a file that somebody has open.
1823 * buildbot/process/base.py (Build.setupBuild): if something goes
1824 wrong while creating a Step, log the name and arguments, since the
1825 error message when you get the number of arguments wrong is really
1828 2006-05-06 Brian Warner <warner@lothar.com>
1830 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1831 bugs in twisted-specific code not covered by my unit tests, this
1832 time use 'cmd' argument instead of self.cmd
1834 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1835 fix stupid braino: either use startwith or find()==0, not both.
1836 (TwistedReactorsBuildFactory.__init__): another dumb typo
1838 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1839 mark this test as TODO under windows, since process-killing seems
1840 dodgy there. We'll come back to this later and try to fix it
1843 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1844 and don't include a timezone
1845 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1846 This should avoid the windows-with-verbose-timezone-name problem
1848 (Patch.testPatch): add a test which runs 'patch' with less
1849 overhead than the full VCBase.do_patch sequence, to try to isolate
1850 a windows test failure. This one uses slave.commands.ShellCommand
1851 and 'patch', but none of the VC code.
1853 * buildbot/slave/commands.py (getCommand): use which() to find the
1854 executables for 'cvs', 'svn', etc. This ought to help under
1857 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1858 working directory before starting. If an earlier test failed, the
1859 leftover directory would mistakenly flunk a later test.
1860 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1861 Make sure that we use the right commandlines if which("tla") picks
1862 up "tla.exe" (as it does under windows).
1863 (TlaSupport.do_get): factor out this tla-vs-baz difference
1864 (TlaSupport.vc_create): more tla-vs-baz differences
1866 * buildbot/test/test_slavecommand.py
1867 (ShellBase.testShellMissingCommand): stop trying to assert
1868 anything about the error message: different shells on different
1869 OSes with different languages makes it hard, and it really isn't
1870 that interesting of a thing to test anyway.
1872 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1873 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1874 "Panther"), because it has a bug which flunks a couple tests in
1875 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1876 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1877 able to test that yet.
1879 2006-04-30 Brian Warner <warner@lothar.com>
1881 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1882 make sure child commands emit messages in english, so our regexps
1883 will match. Thanks to Nikaus Giger for identifying the problems.
1884 (VCBase._do_vctest_export_1): mode="export" is not responsible
1885 for setting the "got_revision" property, since in many cases it is
1886 not convenient to determine.
1887 (SVNSupport.capable): when running 'svn --version' to check for
1888 ra_local, we want error messages in english
1889 * buildbot/test/test_slavecommand.py
1890 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1891 to emit the error message in english
1893 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1894 the environment with $LC_ALL="C" so that Commands which need to
1895 parse the output of their child processes can obtain it in
1897 (SVN.parseGotRevision): call "svn info" afterwards instead of
1898 watching the output of the "svn update" or "svn checkout".
1899 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1900 (Arch.parseGotRevision): same
1901 (Bazaar.parseGotRevision): same
1902 (Mercurial.parseGotRevision): same
1904 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1905 $LC_ALL="C" when running commands under 'buildbot try', too
1907 * buildbot/test/__init__.py: remove the global os.environ()
1908 setting, instead we do it just for the tests that run commands and
1909 need to parse their output.
1911 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1912 remove the overly-short .timeout on this test, because non-DNotify
1913 platforms must fall back to polling which happens at 10 second
1914 intervals, so a 5 second timeout would never succeed.
1916 2006-04-24 Brian Warner <warner@lothar.com>
1918 * docs/buildbot.texinfo (Installing the code): update trial
1919 invocation, SF#1469116 by Niklaus Giger.
1920 (Attributes of Changes): updated branch-name examples to be
1921 a bit more realistic, SF#1475240 by Stephen Davis.
1923 * contrib/windows/buildbot2.bat: utility wrapper for windows
1924 developers, contributed by Nick Trout (after a year of neglect..
1925 sorry!). SF#1194231.
1927 * buildbot/test/test_vc.py (*.capable): store the actual VC
1928 binary's pathname in VCS[vcname], so it can be retrieved later
1929 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1930 strip out non-numeric timezone information, specifically the funky
1931 German string that his system produced that confuses CVS.
1932 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1933 allow Darcs tests to work on windows
1934 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1935 procutils.which() everywhere, to allow tryclient to work under
1936 windows. Also from Niklaus Giger, SF#1463394.
1938 * buildbot/twcompat.py (which): move the replacement for a missing
1939 twisted.python.procutils.which from test_vc.py to here, so it can
1940 be used in other places too (specifically tryclient.py)
1942 2006-04-23 Brian Warner <warner@lothar.com>
1944 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1945 bare buildbotURL/projectName line with a proper DIV, along with a
1946 CSS class of "title", from Stefan Seefeld (SF#1461675).
1947 (WaterfallStatusResource.body0): remove the redundant 'table'
1948 class from the table
1949 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1950 to the top-row TR, and class="Activity" to the second-row TR,
1951 rather than putting them in the individual TD nodes.
1953 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1954 'got_revision' build property for all VC systems that implement
1955 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1957 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1958 to determine which revision we actually obtained
1959 (CVS.parseGotRevision): implement this for CVS, which just means
1960 to grab a timestamp. Not ideal, and it depends upon the buildslave
1961 having a clock that is reasonably well syncronized with the server,
1962 but it's better than nothing.
1963 (SVN.parseGotRevision): implement it for SVN, which is accurate
1964 (Darcs.parseGotRevision): same
1965 (Arch.parseGotRevision): same
1966 (Bazaar.parseGotRevision): same
1967 (Mercurial.parseGotRevision): same
1969 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1970 keep a record of all non-stdout/stderr/header/rc status updates,
1971 for the benefit of RemoteCommands that send other useful things,
1973 (Source.commandComplete): put any 'got_revision' status values
1974 into a build property of the same name
1977 * buildbot/process/step_twisted.py (Trial): update to deal with
1978 new ShellCommand refactoring
1980 * docs/buildbot.texinfo (Build Properties): document new feature
1981 that allows BuildSteps to get/set Build-wide properties like which
1982 revision was requested and/or checked out.
1984 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1985 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1986 it. Note that this bumps the persistenceVersion of the saved Build
1987 object, so add the necessary upgrade-old-version logic to include
1988 an empty properties dict.
1990 * buildbot/process/base.py (Build.setProperty): implement it
1991 (Build.getProperty): same
1992 (Build.startBuild): change build startup to set 'branch',
1993 'revision', and 'slavename' properties at the right time
1995 * buildbot/process/step.py (BuildStep.__init__): change setup to
1996 require 'build' argument in a better way
1997 (LoggingBuildStep): split ShellCommand into two pieces, for better
1998 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1999 a single RemoteCommand that sends stdout/stderr status text. It
2000 also provides the usual commandComplete / createSummary /
2001 evaluateCommand / getText methods to be overridden...
2002 (ShellCommand): .. whereas ShellCommand is specifically for
2003 running RemoteShellCommands. Other shell-like BuildSteps (like
2004 Source) can inherit from LoggingBuildStep instead of ShellCommand
2005 (WithProperties): marker class to do build-property interpolation
2006 (Source): inherit from LoggingBuildStep instead of ShellCommand
2009 * buildbot/test/test_properties.py: test new functionality
2011 2006-04-21 Brian Warner <warner@lothar.com>
2013 * buildbot/test/test_vc.py: rename testBranch to
2014 testCheckoutBranch to keep the tests in about the right
2017 2006-04-18 Brian Warner <warner@lothar.com>
2019 * docs/buildbot.texinfo (PBListener): improve cross-references
2020 between PBListener and 'buildbot statusgui', thanks to John Pye
2023 2006-04-17 Brian Warner <warner@lothar.com>
2025 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2026 running under Twisted-1.3.0, otherwise skipped tests are reported
2029 * all: use isinstance() instead of 'type(x) is foo', suggested by
2032 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2033 oops, fix a brain-fade from the other week, when making the
2034 addStep changes. I changed all the __init__ upcalls to use the
2035 wrong superclass name.
2036 (FullTwistedBuildFactory.__init__): same
2037 (TwistedDebsBuildFactory.__init__): same
2038 (TwistedReactorsBuildFactory.__init__): same
2039 (TwistedBuild.isFileImportant): use .startswith for clarity,
2040 thanks to Neal Norwitz for the suggestions.
2042 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2043 changes, then deliver them over PB to a remote buildmaster.
2045 * contrib/svnpoller.py: added script by John Pye to poll a remote
2046 SVN repository (by running 'svn log') from a cronjob, and run
2047 'buildbot sendchange' to deliver the changes to a remote
2049 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2050 modification of svnpoller.py), same purpose, but this one loops
2051 internally (rather than expecting to run from a cronjob) and works
2053 * contrib/README.txt: same
2055 2006-04-11 Brian Warner <warner@lothar.com>
2057 * all: fix a number of incorrect names and missing imports, thanks
2058 to Anthony Baxter for the patch.
2059 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2060 remove unused buggy method.
2061 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2062 comes from shutil, not "shutils"
2063 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2064 (Arch.checkSlaveVersion): same
2065 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2067 * buildbot/process/step_twisted2.py: add some missing imports
2068 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2069 this code used to live in twisted.internet.defer
2071 2006-04-10 Brian Warner <warner@lothar.com>
2073 * buildbot/process/step.py (Mercurial): add Mercurial support
2074 * buildbot/slave/commands.py (Mercurial): same
2075 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2076 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2077 not yet tested, but 'try' support *is* covered
2078 * docs/buildbot.texinfo (Mercurial): document it
2080 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2081 some debugging messages (turned off)
2082 * buildbot/test/test_vc.py: improve debug messages
2084 2006-04-07 Brian Warner <warner@lothar.com>
2086 * buildbot/test/test_vc.py (which): define our own which() in case
2087 we can't import twisted.python.procutils, because procutils doesn't
2088 exist in Twisted-1.3
2090 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2091 of SlaveLocks for performance tests
2093 * docs/examples/twisted_master.cfg: update to match current usage
2095 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2096 password, p4 binary, pollinterval, maximum history to check.
2097 Patch from an anonymous sf.net contributor, SF#1219384.
2098 * buildbot/process/step.py (P4Sync.__init__): add username,
2099 password, and client arguments.
2100 * buildbot/slave/commands.py (P4Sync): same
2102 2006-04-05 Brian Warner <warner@lothar.com>
2104 * buildbot/process/factory.py (BuildFactory.addStep): new method
2105 to add steps to a BuildFactory. Use it instead of f.steps.append,
2106 and you can probably avoid using the s() convenience function.
2107 Patch from Neal Norwitz, sf.net #1412605.
2108 (other): update all factories to use addStep
2109 * buildbot/process/process_twisted.py: update all factories to use
2112 2006-04-03 Brian Warner <warner@lothar.com>
2114 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2115 work under windows too. Adapted from a patch by Niklaus Giger,
2116 addresses SF#1463399.
2118 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2119 spawned commands emit parseable results in english and not some
2120 other language. Patch from Niklaus Giger, SF#1463395.
2122 * README (INSTALLATION): discourage users from running unit tests on
2123 a "network drive", patch from Niklaus Giger, SF#1463394.
2125 2006-03-22 Brian Warner <warner@lothar.com>
2127 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2128 function to turn a repository-relative pathname into a (branch,
2129 branch-relative-filename) tuple. Change this function to handle
2130 the branch naming policy used by your Subversion repository.
2131 Thanks to AllMyData.com for sponsoring this work.
2133 2006-03-16 Brian Warner <warner@lothar.com>
2135 * buildbot/scripts/sample.cfg: add python-mode declaration for
2136 vim. Thanks to John Pye for the patch.
2138 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2139 command line, mention the importance of running 'crontab' as the
2140 buildmaster/buildslave user. Thanks to John Pye for the catch.
2142 2006-03-13 Brian Warner <warner@lothar.com>
2144 * buildbot/status/words.py (IRC): add an optional password=
2145 argument, which will be sent to Nickserv in an IDENTIFY message at
2146 login, to claim the nickname. freenode requires this before the
2147 bot can sent (or reply to) private messages. Thanks to Clement
2148 Stenac for the patch.
2149 * docs/buildbot.texinfo (IRC Bot): document it
2151 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2152 larger than chunkSize. Fixes SF#1349253.
2153 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2154 (Log.testConsumer): update to match new internal chunking behavior
2156 2006-03-12 Brian Warner <warner@lothar.com>
2158 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2160 * buildbot/test/test_maildir.py (MaildirTest): rename the
2161 'timeout' method, as it collides with trial's internals
2163 * buildbot/scripts/runner.py: add 'buildbot restart' command
2164 (stop): don't sys.exit() out of here, otherwise restart can't work
2165 * docs/buildbot.texinfo (Shutdown): document it
2167 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2168 * buildbot/status/html.py (Waterfall.__init__): same
2169 * buildbot/process/builder.py (Builder.startBuild): same
2170 * buildbot/process/base.py (BuildRequest): same
2171 * buildbot/sourcestamp.py (SourceStamp): same
2172 * buildbot/scheduler.py (Nightly): same
2174 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2176 * docs/buildbot.texinfo: same
2178 2006-02-17 Brian Warner <warner@lothar.com>
2180 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2181 * docs/buildbot.texinfo: set version number to match
2182 * NEWS: update for 0.7.2
2184 2006-02-16 Brian Warner <warner@lothar.com>
2186 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2188 2006-02-09 Brian Warner <warner@lothar.com>
2190 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2191 add text to explain per-build branch parameters
2192 * NEWS: mention --umask
2194 2006-02-08 Brian Warner <warner@lothar.com>
2196 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2198 (SlaveOptions.optParameters): add --umask, to make it possible to
2199 make buildslave-generated files (including build products) be
2202 * buildbot/slave/bot.py (BuildSlave.startService): same
2204 2006-01-23 Brian Warner <warner@lothar.com>
2206 * buildbot/status/builder.py: urllib.quote() all URLs that include
2207 Builder names, so that builders can include characters like '/'
2208 and ' ' without completely breaking the resulting HTML. Thanks to
2209 Kevin Turner for the patch.
2210 * buildbot/status/html.py: same
2211 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2213 * NEWS: update in preparation for upcoming release
2215 2006-01-18 Brian Warner <warner@lothar.com>
2217 * docs/examples/twisted_master.cfg: update to match the Twisted
2218 buildbot: remove python2.2, switch to exarkun's buildslaves,
2219 disable the .deb builder until we figure out how to build twisted
2220 .debs from SVN, add some ktrace debugging to the OS-X build
2221 process and remove the qt build, remove threadless builders,
2222 change freebsd builder to use landonf's buildslave.
2224 2006-01-12 Brian Warner <warner@lothar.com>
2226 * buildbot/master.py (Manhole.__init__): let port= be a strports
2227 specification string, but handle a regular int for backwards
2228 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2229 used in master.cfg to limit connections to just the local host.
2230 (BuildMaster.loadConfig): same for c['slavePortnum']
2231 * buildbot/scheduler.py (Try_Userpass.__init__): same
2232 * buildbot/status/client.py (PBListener.__init__): same
2233 * buildbot/status/html.py (Waterfall.__init__): same, for both
2234 http_port and distrib_port. Include backwards-compatibility checks
2235 so distrib_port can be a filename string and still mean unix:/foo
2236 * docs/buildbot.texinfo (Setting the slaveport): document it
2237 (Debug options): same
2238 (HTML Waterfall): same
2241 * buildbot/test/test_config.py (ConfigTest): test it
2243 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2244 slaveport's disownServiceParent deferred to fire before opening
2245 the new one. Fixes an annoying bug in the unit tests.
2247 2006-01-03 Brian Warner <warner@lothar.com>
2249 * buildbot/master.py (BuildMaster): remove the .schedulers
2250 attribute, replacing it with an allSchedulers() method that looks
2251 for all IService children that implement IScheduler. Having only
2252 one parent/child relationship means fewer opportunities for bugs.
2253 (BuildMaster.allSchedulers): new method
2254 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2255 also fix ugly bug that caused any config-file reload to
2256 half-forget about the earlier Schedulers, causing an exception
2257 when a Change arrived and was handed to a half-connected
2258 Scheduler. The exception was in scheduler.py line 54ish:
2259 self.parent.submitBuildSet(bs)
2260 exceptions.AttributeError: 'NoneType' object has no attribute
2262 (BuildMaster.addChange): update to use allSchedulers()
2264 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2265 to work properly with twisted-1.3.0, where you must explicitly
2266 include the __implements__ from parent classes
2267 (BaseScheduler.__repr__): make it easier to distinguish distinct
2269 (BaseUpstreamScheduler.__implements__): same
2271 * buildbot/status/builder.py (Status.getSchedulers): update to
2273 * buildbot/test/test_run.py (Run.testMaster): same
2274 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2275 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2276 make sure Scheduler instances are left alone when an identical
2277 config file is reloaded
2278 (ConfigElements.testSchedulers): make sure Schedulers are properly
2281 * Makefile (TRIALARGS): my local default Twisted version is now
2282 2.1.0, update the trial arguments accordingly
2284 2005-12-22 Brian Warner <warner@lothar.com>
2286 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2289 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2290 addChange in the parent class, although I suspect this should be
2291 fixed better in the future.
2293 2005-11-26 Brian Warner <warner@lothar.com>
2295 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2296 explode when branch==None, thanks to Kevin Turner for the catch
2297 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2300 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2302 * docs/buildbot.texinfo: same
2304 2005-11-26 Brian Warner <warner@lothar.com>
2306 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2307 * docs/buildbot.texinfo: set version number to match
2309 2005-11-26 Brian Warner <warner@lothar.com>
2311 * NEWS: update for 0.7.1
2313 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2314 sure that unsubscribe works even if we never sent an ETA update.
2315 Also, don't explode on duplicate unsubscribe.
2316 (BuildStepStatus.addLog): make the convenience "return self"-added
2317 watcher automatically unsubscribe when the Step finishes.
2318 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2319 (BuildStatus.stepStarted): same auto-unsubscribe
2320 (BuilderStatus.buildStarted): same auto-unsubscribe
2322 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2324 (IStatusReceiver.stepStarted): same
2325 (IStatusReceiver.logStarted): same
2327 * buildbot/test/test_run.py (Status): move the Status test..
2328 * buildbot/test/test_status.py (Subscription): .. to here
2330 2005-11-25 Brian Warner <warner@lothar.com>
2332 * NEWS: more updates
2334 * buildbot/locks.py: fix the problem in which loading a master.cfg
2335 file that changes some Builders (but not all of them) can result
2336 in having multiple copies of the same Lock. Now, the real Locks
2337 are kept in a table inside the BotMaster, and the Builders/Steps
2338 use "LockIDs", which are still instances of MasterLock and
2339 SlaveLock. The real Locks are instances of the new RealMasterLock
2340 and RealSlaveLock classes.
2341 * buildbot/master.py (BotMaster.getLockByID): new method to
2342 convert LockIDs into real Locks.
2343 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2344 into real Locks before building
2345 * buildbot/process/step.py (BuildStep.startStep): same
2346 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2347 exercises the problem
2350 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2351 what Schedulers are available
2353 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2354 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2355 'cron'-style build scheduling at certain times of day, week,
2357 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2359 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2360 handling: treat self.fileIsImportant more as an attribute that
2361 contains a callable than as a method. If the attribute is None,
2362 don't call it and assume all filenames are important. It is still
2363 possible to provide a fileIsImportant method in a subclass,
2365 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2367 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2368 test using AnyBranchScheduler with fileIsImportant=None
2370 2005-11-24 Brian Warner <warner@lothar.com>
2372 * buildbot/test/test_config.py (StartService): don't claim a fixed
2373 port number, instead set slavePort=0 on the first pass, figure out
2374 what port was allocated, then switch to a config file that uses
2377 * buildbot/master.py (BuildMaster.loadConfig): close the old
2378 slaveport before opening the new one, because unit tests might
2379 replace slavePort=0 with the same allocated portnumber, and if we
2380 don't wait for the old port to close first, we get a "port already
2381 in use" error. There is a tiny race condition here, but the only
2382 threat is from other programs that bind (statically) to the same
2383 port number we happened to be allocated, and only if those
2384 programs use SO_REUSEADDR, and only if they get control in between
2387 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2389 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2390 deleted ChangeSources before adding any new ones
2391 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2392 compare_attrs, to make sure that a config-file reload does not
2393 unnecessarily replace an unmodified ChangeSource instance
2394 * buildbot/test/test_config.py (ConfigTest.testSources): update
2396 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2397 mean "don't build anything", and add a warning if it gets used
2398 because it isn't actually useful.
2400 * contrib/svn_buildbot.py: update example usage to match the port
2401 number that gets used by the PBChangeSource
2402 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2404 2005-11-22 Brian Warner <warner@lothar.com>
2406 * NEWS: start collecting items for next release
2408 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2409 revisions are strings
2410 (P4Sync.computeSourceRevision): same
2412 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2413 to the Buildbot's overall status page
2414 (StatusResourceBuilder.body): same
2416 2005-11-15 Brian Warner <warner@lothar.com>
2418 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2419 config-file loading, specifically to make sure old StatusTargets
2420 are finished shutting down before new ones start up (thus
2421 resolving a bug in which changing the Waterfall object would fail
2422 because both new and old instances were claiming the same
2423 listening port). Also load new Schedulers after all the new
2424 Builders are set up, in case they fire off a new build right away.
2425 * buildbot/test/test_config.py (StartService): test it
2427 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2428 the branch name to the mail body
2430 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2431 Without it, a config-file reload fails to update an existing
2433 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2434 username/passwd to compare_attrs, for the same reason
2435 * buildbot/status/html.py (Waterfall): add favicon to
2436 compare_attrs, same reason
2438 2005-11-05 Brian Warner <warner@lothar.com>
2440 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2441 baserev before stuffing it in the jobfile. This resolves problems
2442 under SVN (and probably Arch) where revisions are expressed as
2443 numbers. I'm inclined to use string-based revisions everywhere in
2444 the future, but this fix should be safe for now. Thanks to Steven
2445 Walter for the patch.
2447 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2448 binary mode when opening pickle files, to make windows work
2449 better. Thanks to Dobes Vandermeer for the catch.
2450 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2451 (BuilderStatus.getBuildByNumber): same
2452 (Status.builderAdded): same
2453 * buildbot/master.py (BuildMaster.loadChanges): same
2455 * buildbot/util.py (Swappable): delete unused leftover code
2457 * buildbot/process/step.py (SVN): when building on a non-default
2458 branch, add the word "[branch]" to the VC step's description, so
2459 it is obvious that we're not building the usual stuff. Likewise,
2460 when we are building a specific revision, add the text "rNNN" to
2461 indicate what that revision number is. Thanks to Brad Hards and
2462 Nathaniel Smith for the suggestion.
2463 (Darcs.startVC): same
2464 (Arch.startVC): same
2465 (Bazaar.startVC): same
2467 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2468 typo, caught by Mark Dillavou, closes SF#1216636.
2470 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2471 about a test to add some day
2473 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2474 the 'full-2.3' build, and the 'reactors' build is now run under
2475 python-2.4 because the buildslave no longer has gtk/etc bindings
2476 for earlier versions.
2478 2005-11-03 Brian Warner <warner@lothar.com>
2480 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2481 method, takes an IBuildStatus and rebuilds it. It might make more
2482 sense to add this to IBuildControl instead, but that instance goes
2483 away completely once the build has finished, and resubmitting
2484 builds can take place weeks later.
2485 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2486 * buildbot/status/html.py (StatusResourceBuild): also stash an
2487 IBuilderControl so we can use resubmitBuild.
2488 (StatusResourceBuild.body): render "resubmit" button if we can.
2489 Also add hrefs for each BuildStep
2490 (StatusResourceBuild.rebuild): add action for "resubmit" button
2491 (StatusResourceBuilder.getChild): give it an IBuilderControl
2493 * buildbot/status/builder.py (Status.getURLForThing): change the
2494 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2495 that live as targets of buttons like "stop" and "rebuild" can't
2497 * buildbot/status/builder.py (Status.getURLForThing): same
2498 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2499 (StepBox.getBox): same
2500 * buildbot/test/test_web.py (GetURL): same
2503 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2504 exclusivity checks after Source.__init__ upcall, so misspelled
2505 arguments will be reported more usefully
2506 (Darcs.__init__): same
2508 2005-10-29 Brian Warner <warner@lothar.com>
2510 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2511 builder. Move the Try scheduler off to a separate port.
2513 2005-10-27 Brian Warner <warner@lothar.com>
2515 * buildbot/clients/gtkPanes.py
2516 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2517 to cause the app to crash, now they don't.
2519 * buildbot/clients/debug.py: display the buildmaster's location
2520 in the window's title bar
2522 2005-10-26 Brian Warner <warner@lothar.com>
2524 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2525 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2526 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2528 * buildbot/status/html.py (td): put a single non-breaking space
2529 inside otherwise empty <td> elements, as a workaround for buggy
2530 browsers which would optimize them away (along with any associated
2531 styles, like the kind that create the waterfall grid borders).
2532 Patch from Frerich Raabe.
2534 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2535 argv-list as an argument, defaulting to ["-to"], which is
2536 appropriate for the Trial that comes with Twisted-2.1.0 and
2537 earlier. The Trial in current Twisted SVN wants
2538 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2539 defaults to an empty list.
2540 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2541 match it, now that trialMode= is a list instead of a single string
2543 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2545 * docs/buildbot.texinfo: same
2547 2005-10-24 Brian Warner <warner@lothar.com>
2549 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2550 * docs/buildbot.texinfo: set version number to match
2552 2005-10-24 Brian Warner <warner@lothar.com>
2554 * README: update for 0.7.0
2556 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2558 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2559 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2560 send the branch= argument unless the user really provided one, to
2561 retain compatibility with older buildmasters that don't accept
2563 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2566 * docs/buildbot.texinfo: update lots of stuff
2568 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2569 to the 'buildbot sendchange' command
2570 * buildbot/clients/sendchange.py (Sender.send): same
2571 * buildbot/changes/pb.py (ChangePerspective): same
2572 * buildbot/test/test_changes.py (Sender.testSender): test it
2574 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2575 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2576 for consistency with other BuildStep arguments that use camelCase.
2577 Well, at least more of them use camelCase (like flunkOnWarnings)
2578 than don't.. I wish I'd picked one style and stuck with it
2579 earlier. Annoying, but it's best done before the release, since
2580 these arguments didn't exist at all in 0.6.6 .
2582 * buildbot/test/test_vc.py (SVN.testCheckout): same
2583 (Darcs.testPatch): same
2584 * docs/buildbot.texinfo (SVN): document the change
2585 (Darcs): same, add some build-on-branch docs
2586 * docs/examples/twisted_master.cfg: match change
2588 * buildbot/process/step.py (BuildStep): rename
2589 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2590 how it is normally used.
2591 * buildbot/test/test_steps.py (Version.checkCompare): same
2593 * buildbot/process/step.py (CVS.startVC): refuse to build
2594 update/copy -style builds on a non-default branch with an old
2595 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2596 concern is that it will do a VC 'update' in an existing tree when
2597 it is supposed to be switching branches (and therefore clobbering
2598 the tree to do a full checkout), thus building the wrong source.
2599 This used to be a warning, but I think the confusion it is likely
2600 to cause warrants making it an error.
2601 (SVN.startVC): same, also make mode=export on old slaves an error
2602 (Darcs.startVC): same
2603 (Git.startVC): improve error message for non-Git-enabled slaves
2604 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2605 specific revision is built on a slave that doesn't pay attention
2606 to args['revision'], because for slowly-changing trees it will
2607 probably do the right thing, and because we have no way to tell
2608 whether we're asking it to build the most recent version or not.
2609 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2611 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2612 that 'master' is in host:portnum format, to catch errors sooner
2614 2005-10-23 Brian Warner <warner@lothar.com>
2616 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2617 when creating the list of warning messages, include the line
2618 immediately after each WARNING: line, since that's usually where
2619 the file and line number wind up.
2621 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2626 2005-10-22 Brian Warner <warner@lothar.com>
2628 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2629 patch from Brad Hards
2630 * buildbot/status/classic.css: same
2631 * buildbot/test/test_web.py (Waterfall): match changes
2633 * buildbot/test/test_steps.py (BuildStep.setUp): set
2634 nextBuildNumber so the test passes
2635 * buildbot/test/test_status.py (MyBuilder): same
2637 * buildbot/status/html.py (StatusResourceBuild.body): revision
2638 might be numeric, so stringify it before html-escapifying it
2639 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2640 timer for the upcoming build
2641 * buildbot/status/classic.css: add background-color attributes for
2642 offline/waiting/building classes
2644 * buildbot/status/builder.py (BuildStatus): derive from
2645 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2646 the default (i.e. unknown) .slavename to "???" instead of None,
2647 since even unknown slavenames need to be printed eventually.
2648 (BuilderStatus): also derive from styles.Versioned . More
2649 importantly, determine .nextBuildNumber at creation/unpickling
2650 time by scanning the directory of saved BuildStatus instances and
2651 choosing one larger than the highest-numbered one found. This
2652 should fix the problem where random errors during upgrades cause
2653 the buildbot to forget about earlier builds. .nextBuildNumber is
2654 no longer stored in the pickle.
2655 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2656 at least log the error. Also call Builder.determineNextBuildNumber
2657 once the basedir is set.
2659 * buildbot/master.py (BuildMaster.loadChanges): do
2660 styles.doUpgrade afterwards, in case I decide to make Changes
2661 derived from styles.Versioned some day and forget to make this
2665 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2666 when running under older pythons (<2.3) in which the shlex module
2667 doesn't have a 'split' function.
2669 * buildbot/process/step.py (ShellCommand.start): make
2670 errorMessages= be a list of strings to stuff in the log before the
2671 command actually starts. This makes it easier to flag multiple
2672 warning messages, e.g. when the Source steps have to deal with an
2674 (CVS.startVC): handle slaves that don't handle multiple branches
2675 by switching into 'clobber' mode
2676 (SVN.startVC): same. Also reject branches without base_url
2677 (Darcs.startVC): same. Also reject revision= in older slaves
2678 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2679 (Bazaar.startVC): same, and test for baz separately than for arch
2681 * buildbot/slave/commands.py (cvs_ver): document new features
2683 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2684 (BuildStep.slaveVersionNewEnough): more useful utility method
2685 * buildbot/test/test_steps.py (Version): start testing it
2687 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2688 the 'force' command requires python2.3, for the shlex.split method
2690 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2691 since we don't use it anymore. The Twisted buildbot uses a
2694 2005-10-21 Brian Warner <warner@lothar.com>
2696 * buildbot/process/process_twisted.py: rework all BuildFactory
2697 classes to take a 'source' step as an argument, instead of
2698 building up the SVN instance in the factory.
2699 * docs/examples/twisted_master.cfg: enable build-on-branch by
2700 providing a base_url and default_branch
2702 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2703 control over --branch and --revision, not that they are always
2705 * buildbot/status/html.py (StatusResourceBuilder.force): same
2706 (StatusResourceBuild.body): display SourceStamp components
2708 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2709 IRC 'force' command, so it can be shared with an eventual
2710 command-line-tool 'buildbot force' mode.
2711 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2713 2005-10-20 Brian Warner <warner@lothar.com>
2715 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2717 * docs/examples/twisted_master.cfg: update to use Schedulers
2719 * buildbot/scripts/sample.cfg: update with Schedulers
2721 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2722 method specifically for use by HTML "force build" button and the
2723 IRC "force" command. Raises an immediate error if there are no
2725 (IBuilderControl.requestBuild): make this just submit a build, not
2726 try to check for existing slaves or set up any when-finished
2727 Deferreds or anything.
2728 * buildbot/process/builder.py (BuilderControl): same
2729 * buildbot/status/html.py (StatusResourceBuilder.force): same
2730 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2731 * buildbot/test/test_slaves.py: same
2732 * buildbot/test/test_web.py: same
2734 2005-10-19 Brian Warner <warner@lothar.com>
2736 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2737 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2739 2005-10-18 Brian Warner <warner@lothar.com>
2741 * buildbot/status/html.py: provide 'status' argument to most
2742 StatusResourceFOO objects
2743 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2744 and Logfiles" section to make the Build page into a more-or-less
2745 comprehensive source of status information about the build
2747 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2748 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2750 2005-10-17 Brian Warner <warner@lothar.com>
2752 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2753 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2754 out what to do about other projects: the correct options for
2755 recent Twisteds will not work for older ones.
2757 2005-10-15 Brian Warner <warner@lothar.com>
2759 * buildbot/status/builder.py (Status.getURLForThing): add method
2760 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2761 use this in email/IRC status clients to make them more useful, by
2762 providing the end user with hints on where to learn more about the
2763 object being reported on.
2764 * buildbot/test/test_web.py (GetURL): tests for it
2766 2005-10-14 Brian Warner <warner@lothar.com>
2768 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2769 fix bug resulting from deferredResult changes
2771 2005-10-13 Brian Warner <warner@lothar.com>
2773 * buildbot/test/test_changes.py: remove use of deferredResult
2774 * buildbot/test/test_config.py: same
2775 * buildbot/test/test_control.py: same
2776 * buildbot/test/test_status.py: same
2777 * buildbot/test/test_vc.py: this is the only remaining use, since
2778 it gets used at module level. This needs to be replaced by some
2779 sort of class-level run-once routine.
2781 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2783 * lots: implement multiple slaves per Builder, which means multiple
2784 current builds per Builder. Some highlights:
2785 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2786 of (state,currentBuilds) instead of (state,currentBuild)
2787 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2788 (IBuildStatus.getSlavename): new method, so you can tell which
2789 slave got used. This only gets set when the build completes.
2790 (IBuildRequestStatus.getBuilds): new method
2792 * buildbot/process/builder.py (SlaveBuilder): add a .state
2793 attribute to track things like ATTACHING and IDLE and BUILDING,
2795 (Builder): .. the .slaves attribute here, which has been turned
2796 into a simple list of available slaves. Added a separate
2797 attaching_slaves list to track ones that are not yet ready for
2799 (Builder.fireTestEvent): put off the test-event callback for a
2800 reactor turn, to make tests a bit more consistent.
2801 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2802 ping fails due to an exception. This needs work, I'm worried that
2803 a code error could lead to a constantly re-connecting slave.
2804 Especially since I'm trying to move to a distinct remote_ping
2805 method, separate from the remote_print that we currently use.
2806 (BuilderControl.requestBuild): return a convenience Deferred that
2807 provides an IBuildStatus when the build finishes.
2808 (BuilderControl.ping): ping all connected slaves, only return True
2809 if they all respond.
2811 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2812 reconnect when we shut down.
2814 * buildbot/status/builder.py: implement new methods, convert
2815 one-build-at-a-time methods to handle multiple builds
2816 * buildbot/status/*.py: do the same in all default status targets
2817 * buildbot/status/html.py: report the build's slavename in the
2818 per-Build page, report all buildslaves on the per-Builder page
2820 * buildbot/test/test_run.py: update/create tests
2821 * buildbot/test/test_slaves.py: same
2822 * buildbot/test/test_scheduler.py: remove stale test
2824 * docs/buildbot.texinfo: document the new builder-specification
2825 'slavenames' parameter
2827 2005-10-12 Brian Warner <warner@lothar.com>
2829 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2830 report failure correctly, causing Dependent builds to run when
2831 they shouldn't have.
2832 * buildbot/status/builder.py (BuildSetStatus): same
2833 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2834 (Set.testSuccess): test the both-pass case too
2835 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2836 fix this test: it was ending too early, masking the failure before
2837 (Logger): specialized StatusReceiver to make sure the dependent
2838 builds aren't even started, much less completed.
2840 2005-10-07 Brian Warner <warner@lothar.com>
2842 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2843 bot.SlaveBuilder being disowned in the middle of a build
2845 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2846 this inherit from StatusReceiver. Also upcall in __init__. This
2847 fixes the embarrasing crash when the new buildSetSubmitted method
2848 is invoked and Waterfall/etc don't implement their own.
2849 * buildbot/test/test_run.py: add a TODO note about a test to catch
2850 just this sort of thing.
2852 * buildbot/process/builder.py (Builder.attached): remove the
2853 already-attached warning, this situation is normal. Add some
2854 comments explaining it.
2856 2005-10-02 Brian Warner <warner@lothar.com>
2858 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2859 OverflowError when setting up dnotify, because some 64-bit systems
2860 have problems with signed-vs-unsigned constants and trip up on the
2861 DN_MULTISHOT flag. Patch from Brad Hards.
2863 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2865 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2866 progressMetrics, description, descriptionDone to the 'parms' list,
2867 and make use the 'parms' list from the implementation class
2868 instead of only BuildStep to initialize the parameters. This
2869 allows buildbot.process.factory.s() to initialize all the parms,
2870 not just those defined in directly by BuildStep.
2872 2005-09-03 Brian Warner <warner@lothar.com>
2874 * NEWS: start adding items for the next release
2876 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2877 python2.2 tests, change 'Quick' builder to only use python2.3
2879 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2881 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2882 the "Ping Builder" button if the build control is available; the
2883 user sees an exception otherwise
2885 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2887 2005-09-01 Brian Warner <warner@lothar.com>
2889 * buildbot/interfaces.py (IBuilderStatus.getState): update
2890 signature, point out that 'build' can be None
2891 (IBuildStatus.getETA): point out ETA can be none
2893 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2895 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2897 2005-08-31 Brian Warner <warner@lothar.com>
2899 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2900 update to match correct signature: removed 'eta' argument
2901 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2903 2005-08-30 Brian Warner <warner@lothar.com>
2905 * buildbot/status/builder.py (LogFile): remove the assertion that
2906 blows up when you try to overwrite an existing logfile, instead
2907 just emit a warning. This case gets hit when the buildmaster is
2908 killed and doesn't get a chance to write out the serialized
2909 BuilderStatus object, so the .nextBuildNumber attribute gets out
2912 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2913 the 'buildbot sendchange' arguments, for the Darcs context file
2914 * docs/buildbot.texinfo (sendchange): document it
2916 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2917 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2918 (IStatus.getSchedulers): new method
2919 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2920 (Status.getSchedulers): implement
2921 * buildbot/process/builder.py (Builder): maintain
2922 BuilderStatus.pendingBuilds
2923 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2924 (TryBase.addChange): Try schedulers should ignore Changes
2926 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2927 for 'try' on CVS/SVN
2928 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2930 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2931 report status properly.
2932 (Try.createJob): implement unique buildset IDs
2934 * buildbot/status/client.py (StatusClientPerspective): add a
2935 perspective_getBuildSets method for the benefit of jobdir-style
2937 * docs/buildbot.texinfo (try): more docs
2938 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2941 2005-08-18 Brian Warner <warner@lothar.com>
2943 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2944 actually work. It's functional but still kind of clunky. Also, it
2945 only works with the pb-style.. needs to be made to work with the
2948 * buildbot/status/client.py (RemoteBuildSet): new class
2949 (RemoteBuildRequest): same
2950 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2951 object, not the internal BuildStatus object.
2952 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2953 outside of the usual buildStarted() return value.
2954 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2956 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2957 (Try_Userpass_Perspective.perspective_try): return a remotely
2958 usable BuildSetStatus object
2960 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2961 isStarted()/waitUntilStarted()
2963 2005-08-16 Brian Warner <warner@lothar.com>
2965 * buildbot/status/builder.py: implement IBuildSetStatus and
2966 IBuildRequestStatus, wire them into place.
2967 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2968 methods into the BuildSetStatus object.
2969 * buildbot/interfaces.py: same
2970 (IStatus.getBuildSets): new method to get pending BuildSets
2971 (IStatusReceiver.buildsetSubmitted): new method which hears about
2973 * buildbot/master.py (BuildMaster.submitBuildSet): same
2974 * buildbot/process/base.py (BuildRequest): same, replace
2975 waitUntilStarted with subscribe/unsubscribe
2976 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2977 subscribe instead of waitUntilStarted
2978 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2980 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2982 * buildbot/test/test_buildreq.py: update for new code
2983 * buildbot/test/test_control.py (Force.testRequest): same
2986 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2987 for Darcs to not use the tempfile module, so it works under
2988 python-2.2 too. We really didn't need the full cleverness of that
2989 module, since the slave has exclusive control of its own builddir.
2991 2005-08-15 Brian Warner <warner@lothar.com>
2993 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2994 for CVS trees. It doesn't work for non-trunk branches,
2996 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2999 * Makefile: make it easier to test against python2.2
3001 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3002 tearDown2, so things like Arch can unregister archives as they're
3003 shutting down. The previous subclass-override-tearDown technique
3004 resulted in a nested maybeWait() and test failures under
3007 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3008 where we can (Arch), add a branch= argument to set the branch used
3010 (BazExtractor): extract the branch too
3011 (TlaExtractor): same
3012 * buildbot/scripts/runner.py (TryOptions): add --branch
3013 * docs/buildbot.texinfo (try): document --branch/try_branch
3015 * buildbot/slave/commands.py (Darcs): implement get-revision for
3016 Darcs, so that 'try' will work. This requires the tempfile module
3019 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3020 of revisions, branches, and 'try' in the process.
3022 2005-08-11 Brian Warner <warner@lothar.com>
3024 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3025 this, it got broken at some point in the last few releases
3026 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3027 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3028 specifically the removal of ETA information from the tuple
3030 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3033 * docs/buildbot.texinfo (try): document both --builder and
3034 'try_builders' in .buildbot/options
3035 * buildbot/scripts/runner.py (TryOptions): add --builder,
3036 accumulate the values into opts['builders']
3037 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3038 * buildbot/test/test_runner.py (Try): add some quick tests to make
3039 sure 'buildbot try --options' and .buildbot/options get parsed
3040 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3041 use --builder control
3043 * docs/buildbot.texinfo (try): add --port argument to PB style
3045 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3046 actual SourceStamp. Still need to extract a branch name, somehow.
3047 (Try): finish implementing the try client side, still need a UI
3048 for specifying which builders to use
3049 (Try.getopt): factor our options/config-file reading
3050 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3052 * buildbot/test/test_vc.py: match SourceStampExtractor change
3054 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3055 causes the twisted log to be sent to stderr
3057 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3059 2005-08-10 Brian Warner <warner@lothar.com>
3061 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3062 style is 90% done, still missing status reporting or waiting for
3063 the buildsets to finish, and it is completely untested.
3065 * buildbot/trybuild.py: delete file, move contents to ..
3066 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3067 * buildbot/test/test_vc.py: match the move
3069 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3070 of the TryScheduler, no buildsetID or status-tracking support yet
3071 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3073 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3074 possible to set the basedir after __init__ time, so it is easier
3075 to use as a Service-child of the BuildMaster instance
3077 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3078 that delivers messages to its Service parent instead of requiring
3079 a subclass to be useful. This turns out to be much easier to build
3082 * buildbot/scripts/tryclient.py (createJob): utility code to
3083 create jobfiles, will eventually be used by 'buildbot try'
3085 2005-08-08 Brian Warner <warner@lothar.com>
3087 * docs/buildbot.texinfo (try): add docs on the
3088 as-yet-unimplemented Try scheduler
3090 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3091 * buildbot/test/test_scheduler.py: .. here
3092 (Scheduling.testTryJobdir): add placeholder test for 'try'
3094 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3095 addEntry merging (>=chunkSize) behavior
3096 (Log.testConsumer): update to handle new callLater(0) behavior
3098 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3099 both the MAX_LENGTH bugfix and the resumeProducing hang.
3101 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3102 put off the actual resumeProducing for a moment with
3103 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3104 causes large logfiles to hang midway through.
3106 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3107 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3108 and to improve memory usage when streaming the file out to a web
3110 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3111 make this work cleanly
3113 2005-08-03 Brian Warner <warner@lothar.com>
3115 * buildbot/trybuild.py: new file for 'try' utilities
3116 (getSourceStamp): run in a tree, find out the baserev+patch
3117 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3118 implemented for SVN and Darcs, still working on Arch. I don't know
3119 how to make CVS work yet.
3121 * docs/buildbot.texinfo: document the 'buildbot' command-line
3122 tool, including the not-yet-implemented 'try' feature, and the
3123 in-flux .buildbot/ options directory.
3125 2005-07-20 Brian Warner <warner@lothar.com>
3127 * buildbot/locks.py: added temporary id() numbers to Lock
3128 descriptions, to track down a not-really-sharing-the-Lock bug
3130 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3132 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3133 needed for python2.2 compatibility
3134 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3135 are from the __future__
3137 2005-07-19 Brian Warner <warner@lothar.com>
3139 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3140 message when schedulers use unknown builders
3142 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3143 SlaveLock('name') and MasterLock('name') are distinct
3145 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3146 c['schedulers'] in such a way that we can actually accept
3148 * buildbot/test/test_config.py: check it
3150 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3151 utility method to *all* the Schedulers
3152 (Periodic.listBuilderNames): same
3154 * docs/buildbot.texinfo (Interlocks): update chapter to match
3157 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3158 to make sure that c['sources'], c['schedulers'], and c['status']
3159 are all lists of the appropriate objects, and that the Schedulers
3160 all point to real Builders
3161 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3162 'listBuilderNames' utility method to support this
3163 * buildbot/scheduler.py: implement the utility method
3164 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3166 * docs/buildbot.texinfo: add some @cindex entries
3168 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3169 if it wasn't already set: most tla commands will fail unless one
3171 (Arch.createRepository): and disable bazaar's revision cache, since
3172 they cause test failures (the multiple repositories we create all
3173 interfere with each other through the cache)
3175 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3176 bring it properly up to date with twisted-2.0 test guidelines
3178 * buildbot/master.py (BuildMaster): remove references to old
3179 'interlock' module, this caused a bunch of post-merge test
3181 * buildbot/test/test_config.py: same
3182 * buildbot/process/base.py (Build): same
3184 * buildbot/test/test_slaves.py: stubs for new test case
3186 * buildbot/scheduler.py: add test-case-name tag
3187 * buildbot/test/test_buildreq.py: same
3189 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3190 unnecessary init code
3191 (Bot.remote_setBuilderList): match it
3193 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3195 * buildbot/changes/mail.py (parseSyncmail): update comment
3197 * buildbot/test/test_slavecommand.py: disable Shell tests on
3198 platforms that don't suport IReactorProcess
3200 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3201 all places where we open logfiles. It causes OS-X to open the file
3202 in some weird mode that that prevents us from mixing reads and
3203 writes to the same filehandle, which we depend upon to implement
3204 _generateChunks properly. This change doesn't appear to break
3205 win32, on which "b" and "t" are treated differently but a missing
3206 flag seems to be interpreted as "t".
3208 2005-07-18 Brian Warner <warner@lothar.com>
3210 * buildbot/slave/commands.py (ShellCommand): overhaul
3211 error-handling code, to try and make timeout/interrupt work
3212 properly, and make win32 happier
3213 * buildbot/test/test_slavecommand.py: clean up, stop using
3214 reactor.iterate, add tests for timeout and interrupt
3215 * buildbot/test/sleep.py: utility for a new timeout test
3217 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3218 code from the local-usebranches branch
3220 2005-07-17 Brian Warner <warner@lothar.com>
3222 * buildbot/process/process_twisted.py
3223 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3224 minutes, to match the other twisted BuildFactories, and don't
3225 excuse failures in c/qt/win32 reactors any more.
3227 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3228 'freebsd' builders, since the buildslaves have been unavailable
3231 2005-07-13 Brian Warner <warner@lothar.com>
3233 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3234 build-on-branch feature
3236 * buildbot/process/step.py (Darcs.__init__): add base_url and
3237 default_branch arguments, just like SVN
3238 (Arch.__init__): note that the version= argument is really the
3241 * buildbot/slave/commands.py (SourceBase): keep track of the
3242 repository+branch that was used for the last checkout in
3243 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3244 match, we clobber the directory and perform a fresh checkout
3245 rather than trying to do an in-place update. This should protect
3246 us against trying to get to branch B by doing an update in a tree
3247 obtained from branch A.
3248 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3249 (SVN.setup): same, just the svnurl
3250 (Darcs.setup): same, just the repourl
3251 (Arch.setup): same, arch coordinates (url), version, and
3252 buildconfig. Also pull the buildconfig from the args dictionary,
3253 which we weren't doing before, so the build-config was effectively
3255 (Arch.sourcedirIsUpdateable): don't try to update when we're
3256 moving to a specific revision: arch can't go backwards, so it is
3257 safer to just clobber the tree and checkout a new one at the
3259 (Bazaar.setup): same sourcedata as Arch
3261 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3262 use maybeWait, to work with twisted-1.3.0 and twcompat
3263 (Dependencies.testRun_Pass): same
3265 * buildbot/test/test_vc.py: rearrange, cleanup
3267 * buildbot/twcompat.py: add defer.waitForDeferred and
3268 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3269 can work under twisted-1.3.0 .
3271 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3272 now created at setUp time. This increases the runtime of the test
3273 suite considerably (from 91 seconds to 151), but it removes the
3274 need for an offline tarball, which should solve a problem I've
3275 seen where the test host has a different version of svn than the
3276 tarball build host. The new code also validates that mode=update
3277 really picks up recent commits. This approach will also make it
3278 easier to test out branches, because the code which creates the VC
3279 branches is next to the code which uses them. It will also make it
3280 possible to test some change-notification hooks, by actually
3281 performing a VC commit and watching to see the ChangeSource get
3284 2005-07-12 Brian Warner <warner@lothar.com>
3286 * docs/buildbot.texinfo (SVN): add branches example
3287 * docs/Makefile (buildbot.ps): add target for postscript manual
3289 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3290 * buildbot/test/test_locks.py: same
3292 * buildbot/process/step.py (Darcs): comment about default branches
3294 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3295 c['interlocks'] in the config file, complain if it is present.
3296 Scan all locks in c['builders'] to make sure the Locks they use
3298 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3299 add some tests to check for non-uniquely-named Locks
3300 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3301 since the unique-Lock validation code requires it now
3303 * buildbot/locks.py: fix test-case-name
3305 * buildbot/interlock.py: remove old file
3307 2005-07-11 Brian Warner <warner@lothar.com>
3309 * buildbot/test/test_interlock.py: rename to..
3310 * buildbot/test/test_locks.py: .. something shorter
3312 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3313 versions (after 2.0.1) changed internet.TCPClient to shut down the
3314 connection in stopService. Change the code to handle this
3317 * buildbot/process/base.py (Build): handle whole-Build locks
3318 * buildbot/process/builder.py (Builder.compareToSetup): same
3319 * buildbot/test/test_interlock.py: make tests work
3321 * buildbot/process/step.py (BuildStep.startStep): complain if a
3322 Step tries to claim a lock that's owned by its own Build
3323 (BuildStep.releaseLocks): typo
3325 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3326 file reloads don't replace unchanged Builders
3328 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3329 rewrite to cover new Locks instead of old c['interlocks']
3330 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3334 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3335 start the master and connect the buildslave
3337 * buildbot/process/step.py (FailingDummy.done): finish with a
3338 FAILURE status rather than raising an exception
3340 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3341 stringify a BuildRequest.reason that is None
3343 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3345 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3346 allow scheduler.Dependent to work
3347 * buildbot/buildset.py (BuildSet): set .reason and .results
3349 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3350 slaves, to make the test stop hanging. It still fails, of course,
3351 because I haven't even started to implement Locks.
3353 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3355 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3356 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3357 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3358 (Dependent): new class for downstream build dependencies
3359 * buildbot/test/test_dependencies.py: tests (still failing)
3361 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3363 2005-07-07 Brian Warner <warner@lothar.com>
3365 * buildbot/test/runutils.py (RunMixin): factored this class out..
3366 * buildbot/test/test_run.py: .. from here
3367 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3368 added new buildbot.locks tests (which all hang right now)
3369 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3370 * buildbot/process/step.py: claim/release per-BuildStep locks
3372 * docs/Makefile: add 'buildbot.html' target
3374 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3375 interpreted as "HEAD", so that all VC steps can accept branch=None
3376 and have it mean the "default branch".
3378 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3380 2005-07-07 Brian Warner <warner@lothar.com>
3382 * docs/examples/twisted_master.cfg: update to match current usage
3384 * docs/buildbot.texinfo (System Architecture): comment out the
3385 image, it doesn't exist yet and just screws up the HTML manual.
3387 2005-07-05 Brian Warner <warner@lothar.com>
3389 * debian/.cvsignore: oops, missed one. Removing leftover file.
3391 2005-06-17 Brian Warner <warner@lothar.com>
3393 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3394 changed its output in 1.2.0, don't mistakenly think that the
3395 subversion we find isn't capable of supporting our tests.
3397 * debian/*: remove the debian/ directory and its contents, to make
3398 life easier for the proper Debian maintainer
3400 * Makefile (release): same
3402 2005-06-07 Brian Warner <warner@lothar.com>
3404 * everything: create a distinct SourceStamp class to replace the
3405 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3406 Changed the signature of Source.startVC to include the revision
3407 information (instead of passing it through self.args). Implement
3408 branches for SVN (now only Darcs/Git is missing support). Add more
3411 2005-06-06 Brian Warner <warner@lothar.com>
3413 * everything: rearrange build scheduling. Create a new Scheduler
3414 object (configured in c['schedulers'], which submit BuildSets to a
3415 set of Builders. Builders can now use multiple slaves. Builds can
3416 be run on alternate branches, either requested manually or driven
3417 by changes. This changed some of the Status classes. Interlocks
3418 are out of service until they've been properly split into Locks
3419 and Dependencies. treeStableTimer, isFileImportant, and
3420 periodicBuild have all been moved from the Builder to the
3422 (BuilderStatus.currentBigState): removed the 'waiting' and
3423 'interlocked' states, removed the 'ETA' argument.
3425 2005-05-24 Brian Warner <warner@lothar.com>
3427 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3428 erroneously abandons the connection (in clientConnectionFailed)
3429 for non-UserErrors, which means that if we lose the connection due
3430 to a network problem or a timeout, we'll never try to reconnect.
3431 Fix this by not upcalling to the buggy parent method. Note:
3432 twisted-2.0 fixes this, but the function only has 3 lines so it
3433 makes more sense to copy it than to try and detect the buggyness
3434 of the parent class. Fixes SF#1207588.
3436 * buildbot/changes/changes.py (Change.branch): doh! Add a
3437 class-level attribute to accomodate old Change instances that were
3438 pickled before 0.6.5 (where .branch was added for new Changes).
3439 This fixes the exception that occurs when you try to look at an
3440 old Change (through asHTML).
3442 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3445 2005-05-23 Brian Warner <warner@lothar.com>
3447 * buildbot/__init__.py (version): release 0.6.6
3449 2005-05-23 Brian Warner <warner@lothar.com>
3451 * NEWS: update for 0.6.6 release
3452 * debian/changelog: same
3454 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3455 before starting: this was done by twistd back when we spawned it,
3456 now that we're importing the pieces and running them in the
3457 current process, we have to do it ourselves. This allows
3458 master.cfg to import files from the same directory without
3459 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3460 Stichele for the catch.
3461 (Options.opt_version): Add a --version command (actually, just make
3462 the existing --version command emit Buildbot's version too)
3464 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3465 fix to make this behave like other LogFiles, this time to handle
3466 existing LogFiles on disk. (add the missing .upgrade method)
3467 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3469 2005-05-21 Brian Warner <warner@lothar.com>
3471 * buildbot/test/test_runner.py (Create.testMaster): match the
3472 rawstring change in runner.py:masterTAC
3474 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3475 TwistedWords is installed
3476 * buildbot/test/test_status.py: same, with TwistedMail
3478 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3479 some old, deprecated, and removed config keys). This should enable
3480 you to use the base buildbot functionality with Twisted-2.0.0 when
3481 you don't also have TwistedWeb and TwistedWords installed
3483 2005-05-20 Brian Warner <warner@lothar.com>
3485 * buildbot/scripts/runner.py (run): call sendchange(), not
3486 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3487 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3488 (stop): don't wait for process to die when sending SIGHUP
3489 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3490 directory name gets interpreted, which you don't want
3493 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3496 2005-05-18 Brian Warner <warner@lothar.com>
3498 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3500 2005-05-18 Brian Warner <warner@lothar.com>
3502 * README: update for 0.6.5
3503 * debian/changelog: same
3505 * buildbot/changes/changes.py: rename tag= to branch=, since
3506 that's how we're using it, and my design for the upcoming "build a
3507 specific branch" feature wants it. also, tag= was too CVS-centric
3508 * buildbot/changes/mail.py (parseSyncmail): same
3509 * buildbot/process/base.py (Build.isBranchImportant): same
3510 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3511 * docs/buildbot.texinfo (Attributes of Changes): same
3513 * NEWS: update tag=, update for upcoming release
3515 2005-05-17 Brian Warner <warner@lothar.com>
3517 * buildbot/scripts/runner.py (stop): actually poll once per
3518 second, instead of re-killing the poor daemon once per second.
3519 Sleep briefly (0.1s) before the first poll, since there's a good
3520 chance we can avoid waiting the full second if the daemon shuts
3521 down quickly. Also remove the sys.exit() at the end.
3522 (start): remove the unneighborly sys.exit()
3524 * Makefile: improve permission-setting to not kick Arch so badly
3526 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3527 default --keepalive=600, since it doesn't hurt very much, and it's
3528 a hassle to discover that you need it.
3529 * buildbot/test/test_runner.py (Create.testSlave): test it
3531 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3532 IRC bot about EXCEPTION
3534 * buildbot/status/client.py (PBListener): upcall more correctly
3536 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3537 an exception mark the overall build with EXCEPTION, not SUCCESS
3539 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3541 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3542 * Makefile: update some release-related stuff
3544 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3545 gets called when there isn't actually an active process, just end
3546 the Command instead of blowing up. I don't know how it gets into
3547 this state, but the twisted win32 buildslave will sometimes hang,
3548 and when it shakes its head and comes back, it thinks it's still
3549 running a Command. The next build causes this command to be
3550 interrupted, but the lack of self.process.pid breaks the interrupt
3553 * NEWS: document changes since the last release
3555 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3556 look for Makefile.buildbot instead of a bare Makefile . The
3557 'buildbot start' does not install this file, so you have to
3558 manually copy it if you want to customize startup behavior.
3559 (createMaster): change 'buildbot master' command to create
3560 Makefile.sample instead of Makefile, to create master.cfg.sample
3561 instead of master.cfg (requiring you to copy it before the
3562 buildmaster can be started). Both sample files are kept up to
3563 date, i.e. they are overwritten if they have been changed. The
3564 'buildbot.tac' file is *not* overwritten, but if the new contents
3565 don't match the old, a 'buildbot.tac.new' file is created and the
3566 user is warned. This seems to be a much more sane way to handle
3567 startup files. Also, don't sys.exit(0) when done, so we can run
3568 unit tests against it.
3569 (createSlave): same. Don't overwrite the sample info/ files.
3570 * buildbot/scripts/sample.mk: remove. the contents were pulled
3571 into runner.py, since they need to match the behavior of start()
3575 * docs/buildbot.texinfo (Launching the daemons): document it
3576 * buildbot/test/test_runner.py (Create): test it
3578 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3579 version that can handle string-in-string tests, because otherwise
3580 python-2.2 fails the tests. It'd be tremendous if Trial's test
3581 took two strings under 2.2 too.
3583 * everything: fixed all deprecation warnings when running against
3584 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3585 few that come from Twisted itself). This involved putting most of
3586 the Twisted-version specific code in the new buildbot.twcompat
3587 module, and creating some abstract base classes in
3588 buildbot.changes.base and buildbot.status.base (which might be
3589 useful anyway). __implements__ is a nuisance and requires an ugly
3590 'if' clause everywhere.
3592 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3593 delay before finishing the test: it seems that smtp.sendmail
3594 doesn't hang up on the server, so we must wait a moment so it can
3595 hang up on us. This removes the trial warning about an unclean
3598 2005-05-16 Brian Warner <warner@lothar.com>
3600 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3601 tuple of (delay, repeats).
3602 * buildbot/test/test_vc.py (Retry): test it
3603 * docs/buildbot.texinfo (Source Checkout): document it
3604 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3605 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3606 doVCFull() are handled by re-trying the checkout (after a delay)
3607 some number of times.
3608 (ShellCommand._startCommand): make header lines easier to read
3610 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3612 (WebTest.test_logfile): make sure master gets shut down, silences
3613 some "unclean reactor" test errors
3615 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3616 reactor once after shutdown, something in certain versions of
3617 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3618 fails, svn-trunk is ok.
3620 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3621 second win32 error message
3623 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3624 validating the ETA, so the tests don't fail on slow systems
3626 2005-05-15 Brian Warner <warner@lothar.com>
3628 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3629 the new LogFile class, so upgrading works properly
3630 (LogFileProducer.resumeProducing): survive resumeProducing after
3631 we've exhausted the chunkGenerator
3633 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3635 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3636 (Log.testUpgrade): same
3638 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3639 Builds and logs with a cron job.
3641 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3642 of the old non-offline LogFile, added code to upgrade these to
3643 new-style contents-live-on-disk instances at load time (in a way
3644 that doesn't invalidate the old Build pickles, so upgrading to
3645 0.6.5 is not a one-way operation). Got rid of everything related
3647 (LogFile.__init__): create LogFiles with the parent step status,
3648 the log's name, and a builder-relative filename where it can keep
3649 the contents on disk.
3650 (LogFile.hasContents): new method, clients are advised to call it
3651 before getText or getChunks and friends. If it returns False, the
3652 log's contents have been deleted and getText() will raise an
3654 (LogFile.getChunks): made it a generator
3655 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3656 Consumer (except one that takes chunks instead of strings). This
3657 enables streaming of very large logfiles without storing the whole
3659 (BuildStatus.generateLogfileName): create names like
3660 12-log-compile-output, with a _0 suffix if required to be unique
3661 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3662 or earlier) logfiles into new-style ones
3663 (BuilderStatus): remove everything related to 'stub' builds. There
3664 is now only one build cache, and we don't strip logs from old
3666 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3667 since we no longer fight to keep it in the cache
3669 * buildbot/status/html.py (TextLog.render_GET): use a
3670 ChunkConsumer to stream the log entries efficiently.
3671 (ChunkConsumer): wrapper which consumes chunks and writes
3674 * buildbot/test/test_twisted.py (Parse.testParse): use a
3675 LogFile-like object instead of a real one
3677 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3678 (Log.testMerge3): validate more merge behavior
3679 (Log.testChunks): validate LogFile.getChunks
3680 (Log.testUpgrade): validate old-style LogFile upgrading
3681 (Log.testSubscribe): validate LogFile.subscribe
3682 (Log.testConsumer): validate LogFile.subscribeConsumer
3684 * buildbot/interfaces.py (IStatusLogStub): remove
3685 (IStatusLog.subscribeConsumer): new method
3686 (IStatusLog.hasContents): new method
3687 (IStatusLogConsumer): describes things passed to subscribeConsumer
3689 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3690 the log contents if it does not have any contents.
3691 (StatusResourceBuildStep.body): same
3692 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3694 2005-05-14 Brian Warner <warner@lothar.com>
3696 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3697 timeouts to try and make the windows metabuildslave not hang
3699 2005-05-13 Mike Taylor <bear@code-bear.com>
3701 * buildbot/slave/commands.py (rmdirRecursive): added a check
3702 to ensure the path passed into rmdirRecursive actually exists.
3703 On win32 a non-existant path would generate an exception.
3705 2005-05-13 Brian Warner <warner@lothar.com>
3707 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3708 shutil.rmtree which behaves correctly on windows in the face of
3709 files that you have to chmod before deleting. Thanks to Bear at
3710 the OSAF for the routine.
3711 (SourceBase.doClobber): use rmdirRecursive
3713 2005-05-12 Brian Warner <warner@lothar.com>
3715 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3716 method generate chunks instead of returning a big list. This
3717 allows the same method to be used for both old LogFile and new
3719 (OfflineLogFile.getText): use the generator
3720 (OfflineLogFile.subscribe): same
3721 * buildbot/status/html.py (TextLog.resumeProducing): same
3722 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3724 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3725 point out that OfflineLogFile does not currently work with
3726 html.Waterfall . Fixing this is high-priority.
3728 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3729 apparently windows defaults to using stdout
3731 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3732 better message on failure so I can figure out the win32 problem
3734 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3735 log messages to include more useful copies of the command being
3736 run, the argv array, and the child command's environment.
3737 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3739 2005-05-11 Brian Warner <warner@lothar.com>
3741 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3743 * Makefile: update the deb-snapshot version
3745 * docs/buildbot.texinfo: move all .xhtml docs into a new
3746 .texinfo-format document, adding a lot of material in the process.
3747 This is starting to look like a real user's manual. Removed all
3748 the Lore-related files: *.xhtml, *.css, template.tpl .
3749 * docs/Makefile: simple makefile to run 'makeinfo'
3750 * buildbot/scripts/sample.cfg: rearrange slightly
3751 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3753 2005-05-10 Brian Warner <warner@lothar.com>
3755 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3756 different name for the internal twistw module, handle it.
3758 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3759 * setup.py: .. and stop trying to install it
3761 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3762 'git'), the new linux kernel VC system (http://kernel.org/git/).
3763 Thanks to Brandon Philips for the patch.
3764 * buildbot/slave/commands.py (Git): same
3766 2005-05-06 Brian Warner <warner@lothar.com>
3768 * buildbot/status/builder.py (OfflineLogFile): replace the default
3769 LogFile with a form that appends its new contents to a disk file
3770 as they arrive. The complete log data is never kept in RAM. This
3771 is the first step towards handling very large (100MB+) logfiles
3772 without choking quite so badly. (The other half is
3773 producer/consumer on the HTML pages).
3774 (BuildStepStatus.addLog): use OfflineLogFile by default
3775 (BuildStatus.getLogfileName): helper code to give the
3776 OfflineLogFile a filename to work with
3778 * buildbot/test/test_status.py (Results.testAddResults): update
3779 tests to handle new asserts
3780 * buildbot/test/test_vc.py (Patch.doPatch): same
3781 * buildbot/test/test_steps.py (BuildStep.setUp): same
3783 2005-05-05 Brian Warner <warner@lothar.com>
3785 * buildbot/scripts/runner.py (start): if there is no Makefile,
3786 launch the app by importing twistd's internals and calling run(),
3787 rather than spawning a new twistd process. This stands a much
3788 better chance of working under windows.
3789 (stop): kill the process with os.kill instead of spawning
3790 /bin/kill, again to reduce the number of external programs which
3791 windows might not have in the PATH. Also wait up to 5 seconds for
3792 the process to go away, allowing things like 'buildbot stop;
3793 buildbot start' to be reliable in the face of slow shutdowns.
3795 * buildbot/master.py (Dispatcher.__getstate__): remove old
3796 .tap-related methods
3797 (BuildMaster.__getstate__): same
3799 * buildbot/slave/bot.py (makeService): same
3800 (Options.longdesc): same
3801 * buildbot/scripts/runner.py: copy over some old mktap option text
3803 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3804 'buildbot master' now creates a buildbot.tac file, so there is no
3805 longer a create-instance/save/reload sequence. mktap is dead, long
3807 * buildbot/scripts/sample.mk: use twistd -y, not -f
3808 * buildbot/test/test_config.py: remove mktap-based test
3809 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3810 * README: don't reference mktap
3812 * docs/source.xhtml: document some of the attributes that Changes
3815 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3817 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3818 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3819 * buildbot/changes/changes.py (Change)
3820 * buildbot/changes/mail.py (parseSyncmail)
3821 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3823 * buildbot/process/base.py (Build.isTagImportant)
3827 2005-05-04 Brian Warner <warner@lothar.com>
3829 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3830 connection after sending the change, so that unit tests don't
3831 complain about sockets being left around
3833 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3834 exception in phase=0 rendering
3835 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3837 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3839 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3840 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3841 and configuring builders with tuples.
3842 * buildbot/test/test_config.py: stop testing compatibility with
3843 deprecated config keys
3844 * buildbot/test/test_run.py: same
3846 2005-05-03 Brian Warner <warner@lothar.com>
3848 * contrib/arch_buildbot.py: survive if there are no logfiles
3849 (username): just use a string, os.getlogin isn't reliable
3851 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3852 so 'buildbot sendchange' actually works. The earlier test only
3853 covered the internal (non-reactor-running) form.
3855 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3856 script to notify the buildmaster about changes
3858 * buildbot/scripts/runner.py (sendchange): new command to send a
3859 change to a buildbot.changes.pb.PBChangeSource receiver.
3860 * buildbot/test/test_changes.py (Sender): test it
3862 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3863 after any reading of the config file, not just when we do it in
3864 startService. This makes some tests a bit cleaner.
3866 * buildbot/changes/pb.py: add some log messages
3868 * buildbot/process/base.py (Build.startBuild): fix a bug that
3869 caused an exception when the build terminated in the very first
3871 (Build.stepDone): let steps return a status of EXCEPTION. This
3872 terminates the build right away, and sets the build's overall
3873 status to EXCEPTION too.
3874 * buildbot/process/step.py (BuildStep.failed): return a status of
3875 EXCEPTION when that is what has happened.
3877 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3878 implement this, allowing Arch-based projects to get precise
3879 checkouts instead of always using the latest code
3880 (Bazaar): create variant of Arch to let folks use baz instead of
3881 tla. Requires a new buildslave too.
3882 * buildbot/slave/commands.py (Arch): add 'revision' argument
3883 (Bazaar): create variant of Arch that uses baz instead of tla.
3884 Remove the code that extracts the archive name from the
3885 register-archive output, since baz doesn't provide it, and require
3886 the user provide both the archive name and its location.
3887 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3889 2005-05-02 Brian Warner <warner@lothar.com>
3891 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3892 thanks to Nick Trout.
3894 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3895 deals better with source Makefile coming from a read-only CVS
3896 checkout. Thanks to Nick Trout for the catch.
3898 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3901 2005-04-28 Brian Warner <warner@lothar.com>
3903 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3905 * debian/changelog: update for 0.6.4
3907 2005-04-28 Brian Warner <warner@lothar.com>
3909 * README.w32: add a checklist of steps for getting buildbot
3911 * MANIFEST.in: include it in the tarball
3915 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3916 broken .tap files from 0.6.3 by getting rid of .services,
3917 .namedServices, and .change_svc at load time.
3919 2005-04-27 Brian Warner <warner@lothar.com>
3921 * NEWS: update in preparation for new release
3923 * buildbot/test/test_config.py (Save.testSave): don't pull in
3924 twisted.scripts.twistd, we don't need it and it isn't for windows
3927 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3928 accomodate win32 which can't do atomic-rename
3930 2005-04-27 Brian Warner <warner@lothar.com>
3932 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3933 timeouts to help the slow metabuildbot not flunk them so much
3934 (Disconnect.testBuild3): same
3935 (Disconnect.testBuild4): same
3936 (Disconnect.testInterrupt): same
3938 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3939 setup, it was completely broken for new buildmasters (those which
3940 did not have a 'change.pck' already saved. Thanks to Paul Warren
3941 for catching this (embarrassing!) bug.
3942 (Dispatcher.__getstate__): don't save our registered avatar
3943 factories, since they'll be re-populated when the config file is
3945 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3946 tests (since the real mktap-generated BuildMaster doesn't save
3948 (BuildMaster.__getstate__): don't save any service children,
3949 they'll all be re-populated when the config file is re-read.
3950 * buildbot/test/test_config.py (Save.testSave): test for this
3952 2005-04-26 Brian Warner <warner@lothar.com>
3954 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3955 rendered with Blender.. looks a bit nicer.
3956 * buildbot/docs/images/icon.blend: add the Blender file for it
3958 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3959 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3960 running under windows. This appears to be the best way to allow
3961 BuildSteps to do something normal like 'trial -v buildbot.test' or
3962 'make foo' and still expect it to work. The idea is to make the
3963 BuildSteps look as much like what a developer would type when
3964 compiling or testing the tree by hand. This approach probably has
3965 problems when there are spaces in the arguments, so if you've got
3966 windows buildslaves, you'll need to pay close attention to your
3969 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3970 timezone to the timestamp column.
3971 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3973 * buildbot/scripts/runner.py (loadOptions): do something sane for
3974 windows, I think. We use %APPDATA%/buildbot instead of
3975 ~/.buildbot, but we still search everywhere from the current
3976 directory up to the root for a .buildbot/ subdir. The "is it under
3977 $HOME" security test was replaced with "is it owned by the current
3978 user", which is only performed under posix.
3979 * buildbot/test/test_runner.py (Options.testFindOptions): update
3980 tests to match. The "is it owned by the current user" check is
3981 untested. The test has been re-enabled for windows.
3983 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3984 any "\n" in the expected output with the platform-specific line
3985 separator. Make this separator "\r\n" on PTYs under unix, they
3986 seem to do that and I don't know why
3988 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3989 windows for now, I don't know what ~/.buildbot/ should mean there.
3991 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3992 win32 compatibility, don't use "/tmp"
3993 (Basedir.testChangeBuilddir): remove more unixisms
3995 2005-04-26 Brian Warner <warner@lothar.com>
3997 * buildbot/test/test_control.py (Force.rmtree): python2.2
3998 compatibility, apparently its shutil.rmtree ignore_errors=
3999 argument is ignored.
4000 * buildbot/test/test_run.py (Run.rmtree): same
4001 (RunMixin.setUp): same
4003 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4006 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4007 'substring in string' operator, must use string.find(substr)!=-1
4008 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4009 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4011 * buildbot/scripts/runner.py (loadOptions): add code to search for
4012 ~/.buildbot/, a directory with things like 'options', containing
4013 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4014 the current directory, your $HOME directory, or anywhere
4015 inbetween, as long as you're somewhere inside your home directory.
4016 (debugclient): look in ~/.buildbot/options for master and passwd
4017 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4018 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4020 * buildbot/status/client.py (makeRemote): new approach to making
4021 IRemote(None) be None, which works under Twisted-2.0
4022 * buildbot/test/test_status.py (Client.testAdaptation): test it
4024 * buildbot/status/builder.py (Status.builderAdded): when loading a
4025 pickled BuilderStatus in from disk, set its name after loading.
4026 The config file might have changed its name (but not its
4027 directory) while it wasn't looking.
4029 * buildbot/process/builder.py (Builder.attached): always return a
4030 Deferred, even if the builder was already attached
4031 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4033 2005-04-25 Brian Warner <warner@lothar.com>
4035 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4036 category-related exception when announcing a build has finished
4038 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4039 reference no-longer-existent changemaster.sources
4040 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4042 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4045 2005-04-25 Brian Warner <warner@lothar.com>
4047 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4049 * debian/changelog: update for 0.6.3
4051 2005-04-25 Brian Warner <warner@lothar.com>
4053 * MANIFEST.in: make sure debug.glade is in the tarball
4055 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4057 * NEWS: update for the imminent 0.6.3 release
4059 * buildbot/status/html.py (HtmlResource.content): make the
4060 stylesheet <link> always point at "buildbot.css".
4061 (StatusResource.getChild): map "buildbot.css" to a static.File
4062 containing whatever css= argument was provided to Waterfall()
4063 (Waterfall): provide the "classic" css as the default.
4064 * docs/waterfall.classic.css: move default CSS from here ..
4065 * buildbot/status/classic.css: .. to here
4067 * MANIFEST.in: make sure classic.css is included in the tarball
4068 * setup.py: and that it is installed too, under buildbot/status/
4070 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4071 the module level, because buildbot.tap files from 0.6.2 don't have
4072 it in their attribute dictionary.
4074 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4075 really exists at startup, might save some confusion somewhere.
4077 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4079 * docs/waterfall.classic.css:
4080 add a stylesheet that's almost the same as the "classic"
4083 * buildbot/status/builder.py:
4084 add EXCEPTION as a result - this is a problem for the bot
4085 maintainer, not a build problem for the changers
4086 * buildbot/process/step.py:
4087 use EXCEPTION instead of FAILURE for exceptions
4088 * buildbot/status/html.py:
4089 add build_get_class to get a class out of a build/buildstep
4090 finish naming the classes
4091 split out sourceNames to changeNames and builderNames so we
4092 can style them separately
4093 * docs/config.xhtml:
4094 finish documenting classes as they are right now
4096 * buildbot/status/html.py:
4097 name the classes as we agreed on IRC
4098 * docs/config.xhtml:
4101 * buildbot/status/html.py:
4102 same for cssclass->class_
4104 * buildbot/status/html.py:
4105 as decided on IRC, use class_ for the "class" attribute to not
4106 conflict with the class keyword, and clean up the messy **{} stuff.
4108 * buildbot/status/mail.py:
4109 put back "builders" argument, and fix docstring, because the
4110 code *ignores* builders listed in this argument
4112 * buildbot/process/builder.py:
4113 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4115 * docs/config.xhtml:
4116 describe the category argument for builders
4118 * buildbot/status/builder.py:
4119 Fix a silly bug due to merging
4121 * buildbot/process/builder.py:
4122 remove category from the process Builder ...
4123 * buildbot/status/builder.py:
4124 ... and add it to BuilderStatus instead.
4125 Set category on unpickled builder statuses, they might not have it.
4126 * buildbot/master.py:
4127 include category when doing builderAdded
4128 * buildbot/status/mail.py:
4129 return None instead of self for builders we are not interested in.
4130 * buildbot/test/test_run.py:
4131 fix a bug due to only doing deferredResult on "dummy" waiting
4132 * buildbot/test/test_status.py:
4133 add checks for the Mail IStatusReceiver returning None or self
4135 * buildbot/status/html.py:
4136 fix testsuite by prefixing page title with BuildBot
4138 * buildbot/status/builder.py:
4139 have .category in builder status ...
4140 * buildbot/process/builder.py:
4141 ... and set it from Builder
4142 * buildbot/status/html.py:
4143 make .css a class variable
4144 * buildbot/test/test_status.py:
4145 write more tests to cover our categories stuff ...
4146 * buildbot/status/mail.py:
4147 ... and fix the bug that this uncovered
4149 * buildbot/changes/mail.py:
4150 * buildbot/changes/pb.py:
4151 * buildbot/master.py:
4152 * buildbot/process/base.py:
4153 * buildbot/process/factory.py:
4154 * buildbot/process/interlock.py:
4155 * buildbot/process/step.py:
4156 * buildbot/process/step_twisted.py:
4157 * buildbot/slave/commands.py:
4158 * buildbot/status/builder.py:
4159 * buildbot/status/client.py:
4160 * buildbot/status/html.py:
4161 * buildbot/status/mail.py:
4162 * buildbot/status/progress.py:
4163 * buildbot/test/test_changes.py:
4164 * buildbot/test/test_config.py:
4165 * buildbot/test/test_control.py:
4166 * buildbot/test/test_interlock.py:
4167 * buildbot/test/test_maildir.py:
4168 * buildbot/test/test_mailparse.py:
4169 * buildbot/test/test_run.py:
4170 * buildbot/test/test_slavecommand.py:
4171 * buildbot/test/test_status.py:
4172 * buildbot/test/test_steps.py:
4173 * buildbot/test/test_twisted.py:
4174 * buildbot/test/test_util.py:
4175 * buildbot/test/test_vc.py:
4176 * buildbot/test/test_web.py:
4178 add test-case-name at the top of a whole set of files
4180 * buildbot/status/builder.py:
4181 keep order of addition when getting builder names
4182 * buildbot/status/words.py:
4183 * buildbot/test/test_run.py:
4184 add test for getBuilderNames
4186 * buildbot/process/base.py:
4187 * buildbot/process/step.py:
4188 * buildbot/status/builder.py:
4189 * buildbot/status/html.py:
4190 make buildbot css-able
4191 replace the color code for purple with purple, don't understand
4192 why it wasn't purple to start with
4194 * buildbot/status/words.py:
4195 ok, so it doesn't look like BuilderStatus.remote is still valid.
4196 Use what waterfall uses instead.
4198 * buildbot/interfaces.py:
4199 * buildbot/status/builder.py:
4200 * buildbot/status/html.py:
4201 * buildbot/status/mail.py:
4202 * buildbot/status/words.py:
4203 * buildbot/test/test_run.py:
4204 use categories everywhere and make it be a list. More sensible
4205 for the future. Also make words actually respect this in
4208 * buildbot/interfaces.py:
4209 add category argument to getBuilderNames
4210 * buildbot/process/builder.py:
4211 * buildbot/status/builder.py:
4212 * buildbot/status/html.py:
4213 * buildbot/status/mail.py:
4214 * buildbot/status/words.py:
4215 * buildbot/test/test_run.py:
4216 move from specifying builders by name to specifying the category
4218 * buildbot/status/html.py:
4219 * buildbot/status/words.py:
4220 add "builders=" to __init__ of status clients so they can
4221 limit themselves to the given list of builders to report on
4223 * buildbot/status/html.py: set the title to the product name
4225 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4227 * buildbot/interfaces.py:
4228 * buildbot/status/builder.py:
4229 more documentation. Hm, not sure if ChangeLog entries make sense
4232 2005-04-23 Brian Warner <warner@lothar.com>
4234 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4236 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4238 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4239 the sub-commands that log buildmaster status to stdout and to a
4240 GUI window, respectively.
4242 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4243 functionality is working again, but all the step-status and ETA
4244 stuff is missing. Commented out a lot of code pending more
4247 * buildbot/status/client.py: make sure that IRemote(None) is None
4249 * buildbot/changes/changes.py: import defer, oops
4250 (ChangeMaster): remove the .sources list, rely upon the fact that
4251 MultiServices can be treated as sequences of their children. This
4252 cleans up the add/remove ChangeSource routines a lot, as we keep
4253 exactly one list of the current sources instead of three.
4255 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4256 up an empty ChangeMaster at init time.
4257 (BuildMaster.loadChanges): if there are changes to be had from
4258 disk, replace self.change_svc with the new ones. If not, keep
4259 using the empty ChangeMaster set up in __init__.
4260 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4261 instead of a separate list, makes the code a bit cleaner.
4262 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4263 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4264 Extend the test to make sure we can get rid of the sources when
4267 2005-04-22 Brian Warner <warner@lothar.com>
4269 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4270 and info/host files when making the slave directory
4272 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4273 whendone= argument, just return the Deferred and let the caller do
4274 what they want with it.
4275 (Disconnect.testBuild1): wait for shutdownSlave
4276 (Basedir.testChangeBuilddir): new test to make sure changes to the
4277 builddir actually get propagated to the slave
4279 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4280 explicit method, rather than passing the builddir in __init__ .
4281 Make sure to update self.basedir too, this was broken before.
4282 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4283 builders and for ones that have just had their builddir changed.
4284 (BotFactory): add a class-level .perspective attribute, so
4285 BuildSlave.waitUntilDisconnected won't get upset when the
4286 connection hasn't yet been established
4287 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4288 tests can reach through it to inspect the SlaveBuilders
4290 * buildbot/process/base.py (Build.buildException): explain the
4291 log.err with a log.msg
4292 * buildbot/process/builder.py (Builder.startBuild): same
4293 (Builder._startBuildFailed): improve error message
4295 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4296 occurred because we lost the brand-new connection, retry instead
4297 of giving up. If not, it's probably an authorization failure, and
4298 it makes sense to stop trying. Make sure we log.msg the reason
4299 that we're log.err'ing the failure, otherwise test failures are
4300 really hard to figure out.
4302 * buildbot/master.py: change loadConfig() to return a Deferred
4303 that doesn't fire until the change has been fully implemented.
4304 This means any connected slaves have been updated with the new
4305 builddir. This change makes it easier to test the code which
4306 actually implements this builddir-updating.
4307 (BotPerspective.addBuilder): return Deferred
4308 (BotPerspective.removeBuilder): same
4309 (BotPerspective.attached): same
4310 (BotPerspective._attached): same. finish with remote_print before
4311 starting the getSlaveInfo, instead of doing them in parallel
4312 (BotPerspective.list_done): same
4313 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4314 actually calling slave.disconnect()
4315 (BotMaster.addBuilder): same
4316 (BotMaster.removeBuilder): same
4317 (BuildMaster.loadConfig): same
4318 (BuildMaster.loadConfig_Slaves): same
4319 (BuildMaster.loadConfig_Sources): same
4320 (BuildMaster.loadConfig_Builders): same
4321 (BuildMaster.loadConfig_status): same
4323 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4324 a Deferred that fires when the source is finally removed
4326 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4327 the previous tree on win32, where we have to do it synchronously,
4328 make sure we return a Deferred anyway.
4329 (SourceBase.doCopy): same
4331 * buildbot/scripts/runner.py (statusgui): use the text client for
4332 now, while I rewrite the Gtk one
4333 * buildbot/clients/base.py: strip out old code, leaving just the
4334 basic print-message-on-event functionality. I also remove the
4335 ReconnectingPBClientFactory, but it does at least quit when it
4336 loses the connection instead of going silent
4338 2005-04-21 Brian Warner <warner@lothar.com>
4340 * Makefile: minor tweaks
4342 * NEWS: point out deprecation warnings, new features for
4345 * buildbot/master.py (BuildMaster.loadConfig): emit
4346 DeprecationWarnings for Builders defined with tuples. Rearrange
4347 code to facility removal of deprecated configuration keys in the
4350 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4351 'buildbot' command to put a little Makefile in the target that
4352 helps you re-create the buildbot.tap file, start or stop the
4353 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4354 all the files 0600, since they contain passwords.
4355 (start): if there is a Makefile, and /usr/bin/make exists, use
4356 'make start' in preference to a raw twistd command. This lets
4357 slave admins put things like PYTHONPATH variables in their
4358 Makefiles and have them still work when the slave is started with
4359 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4360 be nice to first try the 'make' command and only fall back to
4361 twistd if it fails. TODO: the Makefile's "start" command does not
4362 add the --reactor=win32 argument when running under windows.
4363 (Options.debugclient, Options.statusgui): add sub-commands to launch
4364 the debug client (formerly in contrib/debugclient.py) and the
4365 Gtk status application (currently broken)
4366 * buildbot/clients/debug.py: move from contrib/debugclient.py
4367 * buildbot/clients/debug.glade: same
4369 * buildbot/test/test_trial.py: remove it. This requires some
4370 functionality out of Twisted that isn't there yet, and until then
4371 having it around just confuses things.
4373 * buildbot/test/test_slavecommand.py (Shell): test both with and
4374 without PTYs, and make sure that command output is properly
4375 interleaved in the with-PTY case. I think the without-PTY test
4376 should pass on windows, where we never use PTYs anyway.
4378 2005-04-20 Brian Warner <warner@lothar.com>
4380 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4382 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4384 * NEWS: start creating entries for the next release
4386 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4388 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4389 (WebTest.test_webPathname): same
4390 (WebTest.test_webPathname_port): same
4391 (WebTest.test_waterfall): use the default favicon rather than
4392 rooting around the filesystem for it. Open the expected-icon file
4393 in binary mode, to make win32 tests happier (thanks to Nick Trout
4395 * buildbot/status/html.py (buildbot_icon): win32 portability
4397 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4398 win32-compatibility fixes from Nick Trout, the "file not found" message
4399 is different under windows
4400 (FakeSlaveBuilder.__init__): clean up setup a bit
4401 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4403 2005-04-19 Brian Warner <warner@lothar.com>
4405 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4406 skip-if-repositories-are-unavailable test to not kill the trial
4407 that comes with Twisted-1.3.0
4409 * setup.py: install buildbot.png icon file when installing code
4411 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4412 environment used by the command, at least on the child side.
4414 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4415 this method needs to be added and implemented because it gets
4416 called under heavy load. I don't quite understand the
4417 producer/consumer API enough to write it.
4418 (StatusResource.getChild): add a resource for /favicon.ico
4419 (Waterfall.__init__): add favicon= argument
4420 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4421 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4422 (WebTest.test_webPathname): same
4423 (WebTest.test_webPathname_port): same
4424 * docs/config.xhtml: mention favicon=
4425 * buildbot/buildbot.png: add a default icon, dorky as it is
4427 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4429 * buildbot/master.py:
4430 * buildbot/process/base.py:
4431 * buildbot/process/builder.py:
4432 * buildbot/process/interlock.py:
4433 * buildbot/status/builder.py:
4434 * buildbot/status/html.py:
4435 * buildbot/status/mail.py:
4436 * buildbot/status/words.py:
4437 new documentation while digging through the code
4439 2005-04-17 Brian Warner <warner@lothar.com>
4441 * general: try to fix file modes on all .py files: a+r, a-x,
4442 but let buildbot/clients/*.py be +x since they're tools
4444 * docs/epyrun (addMod): when an import fails, say why
4446 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4448 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4450 * buildbot/process/base.py:
4451 * buildbot/process/builder.py:
4452 * buildbot/status/builder.py:
4453 new documentation while digging through the code
4455 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4457 * buildbot/changes/changes.py:
4458 * buildbot/changes/p4poller.py:
4459 * buildbot/interfaces.py:
4460 * buildbot/process/base.py:
4461 * buildbot/process/builder.py:
4462 * buildbot/process/step.py:
4463 * buildbot/process/step_twisted.py:
4464 * buildbot/slave/bot.py:
4465 * buildbot/slave/commands.py:
4466 * buildbot/status/builder.py:
4467 fix all docstrings to make epydoc happy. In the process of fixing
4468 some, I also moved pieces of docs, and removed some deprecated
4471 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4473 * buildbot/process/builder.py:
4474 * buildbot/process/interlock.py:
4475 * buildbot/process/process_twisted.py:
4476 * buildbot/process/step.py:
4477 BuildProcess -> Build, as it looks like that's what happened
4478 * buildbot/process/base.py:
4479 * buildbot/process/factory.py:
4482 2005-04-17 Brian Warner <warner@lothar.com>
4484 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4485 update compile command to accomodate the Twisted split.. now
4486 instead of './setup.py build_ext -i', you do './setup.py all
4487 build_ext -i', to run build_ext over all sub-projects.
4488 (FullTwistedBuildFactory): same
4489 (TwistedReactorsBuildFactory): same
4491 * buildbot/status/html.py (TextLog.finished): null out self.req
4492 when we're done, otherwise the reference cycle of TextLog to .req
4493 to .notifications to a Deferred to TextLog.stop keeps them from
4494 being collected, and consumes a huge (610MB on pyramid at last
4495 check) amount of memory.
4497 2005-04-11 Brian Warner <warner@lothar.com>
4499 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4500 normalize the VC-repository location.. makes SVN happier with
4501 certain test environments.
4503 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4504 RemoteShellCommand gets its own .env dictionary, so that code in
4505 start() doesn't mutate the original. I think this should fix the
4506 step_twisted.Trial problem where multiple identical components
4507 kept getting added to PYTHONPATH= over and over again.
4509 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4510 adding epydoc-format docstrings to many classes. Thanks to Thomas
4511 Vander Stichele for the patches.
4512 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4513 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4514 * buildbot/slave/bot.py, commands.py, registry.py: same
4516 2005-04-05 Brian Warner <warner@lothar.com>
4518 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4519 preserve timestamps, helps incremental builds of large trees.
4520 Patch from Rene Rivera.
4522 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4523 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4526 2005-04-03 Brian Warner <warner@lothar.com>
4528 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4529 with one dict, apparently exec has some scoping bugs when used
4530 with both global/local dicts. Thanks to Nathaniel Smith for the
4533 2005-04-02 Brian Warner <warner@lothar.com>
4535 * buildbot/process/step_twisted.py (countFailedTests): the new
4536 trial in Twisted-2.0 emits a slightly different status line than
4537 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4538 mistakenly think the test count is unparseable.
4539 (Trial.start): note that for some reason each build causes another
4540 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4541 be fixed but I'm not sure quite where the problem is.
4543 2005-04-01 Brian Warner <warner@lothar.com>
4545 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4546 deferredResult to avoid hangs/warnings under twisted-2.0
4547 (RunMixin.tearDown): same
4548 (RunMixin.shutdownSlave): same
4549 (Disconnect.testIdle1): same
4550 (Disconnect.testBuild2): same: wait one second after the build
4551 finishes for test to really be done.. this should be cleaned up to
4552 avoid wasting that second. Builder.detach uses a callLater(0),
4553 either that should be done in-line (something else needed that
4554 behavior), or it should return a Deferred that fires when the
4555 builder is really offline.
4556 (Disconnect.testBuild3): same
4557 (Disconnect.testDisappear): same
4559 * buildbot/test/test_web.py: rearrange server-setup and teardown
4560 code to remove unclean-reactor warnings from twisted-2.0
4562 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4563 so the tests don't hang under twisted-2.0
4565 2005-03-31 Brian Warner <warner@lothar.com>
4567 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4568 caused a warning each time the master changed our set of builders
4570 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4571 w32, don't unlink the file unless it already exists. Thanks to
4572 Baptiste Lepilleur for the catch.
4573 (BuilderStatus.saveYourself): same
4575 2005-02-01 Brian Warner <warner@lothar.com>
4577 * buildbot/status/html.py (TextLog.getChild): use a /text child
4578 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4579 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4580 logfile as text/plain (no markup, no headers). This replaces the
4581 previous scheme (which used an ?text=1 argument), and gets us back
4582 to a relative link (which works better when the buildbot lives
4583 behind another web server, such as Apache configured as a reverse
4584 proxy). Thanks to Gerald Combs for spotting the problem.
4586 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4589 2004-12-13 Brian Warner <warner@lothar.com>
4591 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4593 * debian/changelog: update for 0.6.2
4594 * NEWS: finalize for 0.6.2
4596 2004-12-11 Brian Warner <warner@lothar.com>
4598 * NEWS: bring it up to date
4600 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4601 detection code. Require some sign of life from the buildmaster
4602 every BotFactory.keepaliveInterval seconds. Provoke this
4603 indication at BotFactory.keepaliveTimeout seconds before the
4604 deadline by sending a keepalive request. We don't actually care if
4605 that request is answered in a timely fashion, what we care about
4606 is that .activity() is called before the deadline. .activity() is
4607 triggered by any PB message from the master (including an ack to
4608 one of the slave's status-update messages). With this new scheme,
4609 large status messages over slow pipes are OK, as long as any given
4610 message can be sent (and thus acked) within .keepaliveTimeout
4611 seconds (which defaults to 30).
4612 (SlaveBuilder.remote_startCommand): record activity
4613 (SlaveBuilder.ackUpdate): same
4614 (SlaveBuilder.ackComplete): same
4615 (BotFactory.gotPerspective): same
4616 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4618 2004-12-09 Brian Warner <warner@lothar.com>
4620 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4623 * buildbot/process/step_twisted.py (Trial._commandComplete):
4624 update self.cmd when we start the 'cat test.log' transfer. Without
4625 this, we cannot interrupt the correct RemoteCommand when we lose
4628 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4629 trying to tell the slave to stop the command if we're already
4630 inactive, or if we no longer have a .remote
4632 * buildbot/process/builder.py (Builder._detached): don't let an
4633 exception in currentBuild.stopBuild() prevent the builder from
4634 being marked offline
4636 2004-12-07 Brian Warner <warner@lothar.com>
4638 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4639 KeyError that happens when you ask for a non-existent Builder, and
4640 translate it into a UsageError.
4642 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4643 losing the slave in the middle of a remote step is handled too
4645 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4646 be a Failure, so be sure to stringify it before using it as the
4647 contents of the 'interrupt' logfile
4648 (RemoteCommand.interrupt): use stringified 'why' in
4649 remote_interruptCommand too, just in case
4651 2004-12-06 Brian Warner <warner@lothar.com>
4653 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4654 instead of 'tla update', which is more efficient in case we've
4655 missed a couple of patches since the last update.
4657 * debian/changelog: update for previous (0.6.1) release. Obviously
4658 this needs to be handled better.
4660 2004-12-05 Brian Warner <warner@lothar.com>
4662 * NEWS: update for stuff since last release
4664 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4665 match the maybeDeferred change in Dispatcher.requestAvatar
4666 * buildbot/changes/pb.py (ChangePerspective.attached): same
4667 * buildbot/status/client.py (StatusClientPerspective.attached): same
4668 * buildbot/process/builder.py (Builder._attached3): same
4669 * buildbot/pbutil.py (NewCredPerspective.attached): same
4671 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4672 the date to the top-most box, if it is not the same as today's
4675 * docs/slave.xhtml: provide a buildslave setup checklist
4677 * docs/source.xhtml (Arch): correct terminology
4679 2004-12-04 Brian Warner <warner@lothar.com>
4681 * buildbot/test/test_slavecommand.py: use sys.executable instead
4682 of hard-coding 'python' for child commands, might help portability
4684 * docs/examples/twisted_master.cfg: update to current usage
4686 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4687 'stop build' command to the IRC bot
4689 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4690 message that broke PBChangeSource
4692 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4693 (SlaveBuilder): make some attributes class-level, remove the old
4694 "update queue" which existed to support resuming a build after the
4695 master connection was lost. Try to reimplement that feature later.
4696 (SlaveBuilder.stopCommand): clear self.command when the
4697 SlaveCommand finishes, so that we don't try to kill a leftover one
4699 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4702 * buildbot/slave/commands.py (SourceBase): set self.command for
4703 all VC commands, so they can be interrupted.
4705 2004-12-03 Brian Warner <warner@lothar.com>
4707 * buildbot/master.py: clean up slave-handling code, to handle
4708 slave-disconnect and multiple-connect better
4709 (BotPerspective): make these long-lasting, exactly one per bot
4710 listed in the config file.
4711 (BotPerspective.attached): if a slave connects while an existing
4712 one appears to still be connected, disconnect the old one first.
4713 (BotPerspective.disconnect): new method to forcibly disconnect a
4714 buildslave. Use some hacks to empty the transmit buffer quickly to
4715 avoid the long (20-min?) TCP timeout that could occur if the old
4716 slave has dropped off the net.
4717 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4718 own their own SlaveStatus objects. Remove .attached/.detached, add
4719 .addSlave/.removeSlave, treat slaves like Builders (config file
4720 parsing sends deltas to the BotMaster). Inform the slave
4721 instances, i.e. the BotPerspective, about addBuilder and
4723 (BotMaster.getPerspective): turns into a single dict lookup
4724 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4725 which gives BotPerspective.attached a chance to disconnect the old
4727 (BuildMaster.loadConfig): add code (disabled) to validate that all
4728 builders use known slaves (listed in c['bots']). The check won't
4729 work with tuple-specified builders, which are deprecated but not
4730 yet invalid, so the check is disabled for now.
4731 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4732 routine, do the add/changed/removed dance with them like we do
4734 (BuildMaster.loadConfig_Sources): move source-config into a
4735 separate routine too
4737 * buildbot/status/builder.py (Status.getSlave): get the
4738 SlaveStatus object from the BotPerspective, not the BotMaster.
4740 * buildbot/test/test_run.py: bunch of new tests for losing the
4741 buildslave at various points in the build, handling a slave that
4742 connects multiple times, and making sure we can interrupt a
4745 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4746 something other than 'Bot' for the Bot object, to make certain
4747 test cases easier to write.
4748 (BuildSlave.waitUntilDisconnected): utility method for testing
4750 2004-11-30 Brian Warner <warner@lothar.com>
4752 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4754 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4755 argument, return a Deferred that always fires with True or False.
4756 I don't use an errback to indicate 'ping failed' so that callers
4757 are free to ignore the deferred without causing spurious errors in
4759 * buildbot/process/builder.py (BuilderControl.ping): implement it
4761 * buildbot/test/test_run.py (Status.testDisappear): test ping
4762 (Status.disappearSlave): fix it
4764 2004-11-30 Brian Warner <warner@lothar.com>
4766 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4767 (IBuilderControl): add .getBuild(num), only works for the current
4768 build, of course, although it might be interesting to offer
4769 something for builds in the .waiting or .interlocked state.
4771 * buildbot/process/base.py (Build): have .stopBuild just do the
4772 interrupt, then let the build die by itself.
4773 (BuildControl): add .stopBuild, and add a point-event named
4774 'interrupt' just after the build so status viewers can tell that
4776 (BuilderControl): add .getBuild
4778 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4779 stops when you kill it, good for testing
4780 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4781 contains the 'reason' text.
4783 * buildbot/status/html.py: Add Stop Build button, if the build can
4784 still be stopped. Send a Redirect (to the top page) one second
4785 later, hopefully long enough for the interrupt to have an effect.
4786 Move make_row() up to top-level to share it between Stop Build and
4789 * buildbot/slave/commands.py: only kill the child process once
4791 * buildbot/test/test_run.py: add testInterrupt
4793 2004-11-29 Brian Warner <warner@lothar.com>
4795 * buildbot/process/base.py: Refactor command interruption. The
4796 Build is now responsible for noticing that the slave has gone
4797 away: Build.lostRemote() interrupts the current step and makes
4798 sure that no further ones will be started.
4800 * buildbot/process/builder.py: When the initial remote_startBuild
4801 message fails, log it: this usually indicates that the slave has
4802 gone away, but we don't really start paying attention until they
4803 fail to respond to the first step's command.
4805 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4806 slave disconnect. Now sports a new interrupt() method. Error
4807 handling was simplified a lot by chaining deferreds, so
4808 remoteFailed/remoteComplete were merged into a single
4809 remoteComplete method (which can now get a Failure object).
4810 Likewise failed/finished were merged into just _finished.
4811 (BuildStep): Add interrupt(why) method, and if why is a
4812 ConnectionLost Failure then the step is failed with some useful
4815 * buildbot/slave/bot.py: stop the current command when the remote
4816 Step reference is lost, and when the slave is shut down.
4817 (Bot): make it a MultiService, so it can have children. Use
4818 stopService to tell when the slave is shutting down.
4819 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4820 remote_interruptCommand (which asks the current SlaveCommand to
4821 stop but allows it to keep emitting status messages), and
4822 stopCommand (which tells it to shut up and die).
4824 * buildbot/slave/commands.py: make commands interruptible
4825 (ShellCommand.kill): factor out os.kill logic
4826 (Command): factor out setup()
4827 (Command.sendStatus): don't send status if .running is false, this
4828 happens when the command has been halted.
4829 (Command.interrupt): new method, used to tell the command to die
4830 (SlaveShellCommand): implement .interrupt
4831 (DummyCommand): implement .interrupt
4832 (SourceBase, etc): factor out setup(), don't continue substeps if
4835 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4836 so they can be called after finishing
4838 * buildbot/test/test_run.py: new tests for disconnect behavior,
4839 refactor slave-shutdown routines, add different kinds of
4842 2004-11-27 Brian Warner <warner@lothar.com>
4844 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4845 method to express ETA time like "2m45s" instead of "165 seconds"
4847 2004-11-24 Brian Warner <warner@lothar.com>
4849 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4850 archive after the test completes, to avoid cluttering the user's
4851 'tla archives' listing with a bogus entry. Arch doesn't happen to
4852 provide any way to override the use of ~/.arch-params/, so there
4853 isn't a convenient way to avoid touching the setup of the user who
4855 (VC_HTTP.testArchHTTP): same
4857 2004-11-23 Brian Warner <warner@lothar.com>
4859 * buildbot/status/html.py (TextLog): split render() up into
4860 render_HEAD and render_GET. Use a Producer when sending log
4861 chunks, to reduce memory requirements and avoid sending huge
4862 non-Banana-able strings over web.distrib connections. Requires
4863 peeking under the covers of IStatusLog.
4864 (TextLog.resumeProducing): fix the "as text" link, handle client
4865 disconnects that occur while we're still sending old chunks.
4867 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4868 use defer.succeed, not the non-existent defer.success
4869 (LogFile.waitUntilFinished): same
4870 (LogFile.subscribe): don't add watchers to a finished logfile
4872 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4875 2004-11-23 Brian Warner <warner@lothar.com>
4877 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4879 2004-11-23 Brian Warner <warner@lothar.com>
4881 * NEWS: update for the 0.6.1 release
4882 * MANIFEST.in: add new files
4884 * README (INSTALLATION): explain how to enable the extra VC tests
4886 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4887 level to, so old pickled builds can be displayed ok
4889 2004-11-22 Brian Warner <warner@lothar.com>
4891 * NEWS: summarize updates since last release
4893 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4894 Yoz Grahame. Closes SF#1050138.
4896 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4899 * buildbot/process/step_twisted.py (Trial): update docs a bit
4901 * docs/factories.xhtml: fix Trial factory docs to match reality.
4904 * buildbot/process/factory.py (Trial.__init__): add args for
4905 randomly= and recurse=, making them available to instantiators
4906 instead of only to subclassers. Closes: SF#1049759.
4908 2004-11-15 Brian Warner <warner@lothar.com>
4910 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4911 try to teach the Quick factory to use multiple versions of python
4913 2004-11-12 Brian Warner <warner@lothar.com>
4915 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4916 safer w32-compatible approach, and only use it on windows
4917 (BuildStatus.saveYourself): same
4919 2004-11-11 Brian Warner <warner@lothar.com>
4921 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4922 it: one string merge per chunk. There are now separate .entries
4923 and .runEntries lists: when enumerating over all chunks, make sure
4925 * buildbot/test/test_status.py (Log): more tests
4927 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4928 chunks together, up to 10kb per chunk. This ought to cut down on
4929 the CPU-burning overhead of large log files. Thanks to Alexander
4930 Staubo for spotting the problem.
4931 * buildbot/test/test_status.py (Log): tests for same
4933 2004-11-10 Brian Warner <warner@lothar.com>
4935 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4936 header to outbound mail
4937 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4939 2004-11-08 Brian Warner <warner@lothar.com>
4941 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4942 can't do os.rename() onto an existing file, so catch the exception
4943 and unlink the target file first. This introduces a slight window
4944 where the existing file could be lost, but the main failure case
4945 (disk full) should still be handled safely.
4946 (BuildStatus.saveYourself): same
4948 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4949 separator character instead of os.sep, because the filenames being
4950 split here are coming from the VC system, which can have a
4951 different pathname convention than the local host. This should
4952 help a buildmaster running on windows that uses a CVS repository
4953 which runs under unix.
4954 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4956 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4957 when there are no test failures to be parsed
4959 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4960 instead of the unix-specific os.system("cp"), thanks to Elliot
4961 Murphy for this and the other buildbot-vs-windows catches.
4962 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4964 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4965 echo the command as it is run
4967 * setup.py: install sample.mk too, not just sample.cfg
4968 (scripts): install contrib/windows/buildbot.bat on windows
4970 2004-11-07 Brian Warner <warner@lothar.com>
4972 * buildbot/process/builder.py (Builder._detached): clear the
4973 self.currentBuild reference, otherwise the next build will be
4974 skipped because we think the Builder is already in use.
4976 * docs/examples/twisted_master.cfg: update to match current usage
4977 on the Twisted buildbot
4979 2004-10-29 Brian Warner <warner@lothar.com>
4981 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4983 2004-10-28 Brian Warner <warner@lothar.com>
4985 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4986 have separate doVCUpdate/doVCFull methods. Catch an update failure
4987 and respond by clobbering the source directory and re-trying. This
4988 will handle local changes (like replacing a file with a directory)
4989 that will cause CVS and SVN updates to fail.
4990 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4992 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4995 2004-10-19 Brian Warner <warner@lothar.com>
4997 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4999 * buildbot/status/html.py (StatusResourceTestResults): display any
5000 TestResults that the Build might have
5001 (StatusResourceTestResult): and the logs for each TestResult
5002 (StatusResourceBuild): add link from the per-build page
5004 2004-10-15 Brian Warner <warner@lothar.com>
5006 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5007 the 'problems' portion of stdout, add TestResults to our build
5008 * buildbot/test/test_twisted.py (Parse.testParse): test it
5010 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5011 to retrieve a dict of accumulated test results
5012 (ITestResult): define what a single test result can do
5013 * buildbot/status/builder.py (TestResult): implement ITestResult
5014 (BuildStatus.getTestResults): retrieve dict of TestResults
5015 (BuildStatus.addTestResult): add TestResults
5016 * buildbot/test/test_status.py (Results.testAddResults): test it
5018 2004-10-14 Brian Warner <warner@lothar.com>
5020 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5021 instead of os.system("rm -rf") for win32 portability
5023 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5024 SignalMixin instead of starting/stopping the reactor, which is
5025 likely to cause problems with other tests
5027 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5028 self.copyComplete() call. Yoz Grahame makes the catch.
5030 * contrib/windows/buildbot.bat: helper script to deal with path
5031 issues. Thanks to Yoz Grahame.
5033 * buildbot/master.py (BuildMaster.startService): don't register a
5034 SIGHUP handler if the signal module has no SIGHUP attribute.
5035 Apparently win32 does this.
5037 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5039 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5040 test if the reactor can't offer UNIX sockets
5042 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5043 error introduced in the last commit. We really need that
5046 2004-10-12 Brian Warner <warner@lothar.com>
5048 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5049 when describing a maildir source. Thanks to Stephen Davis.
5051 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5054 * buildbot/scripts/runner.py (createMaster): install Makefile too
5055 (start): add --no_save to 'start' command
5056 * buildbot/scripts/sample.mk: simple convenience Makefile with
5057 start/stop/reload targets
5059 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5062 2004-09-30 Brian Warner <warner@lothar.com>
5064 * setup.py: Releasing buildbot-0.6.0
5066 2004-09-30 Brian Warner <warner@lothar.com>
5068 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5069 test_trial.py from the source tarball until support is complete.
5071 * NEWS: update for 0.6.0 release
5072 * buildbot/__init__.py (version): same
5075 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5076 'source' command to tell users where to get the Buildbot source
5078 * docs/examples/*.cfg: update to modern standards
5080 * NEWS: update for release
5082 * buildbot/scripts/runner.py (createMaster): remove the
5083 -shutdown.tap stuff now that it isn't necessary
5085 (start): launch buildbot.tap, not buildbot-shutdown.tap
5088 * buildbot/status/mail.py (Domain): shorten class name
5089 (MailNotifier): if lookup= is a string, pass it to Domain()
5090 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5091 (Mail.testBuild2): test the string-to-Domain shortcut
5092 (Mail.testMail): fix test
5095 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5098 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5099 more attributes on load
5100 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5101 to accomodate the whole waterfall page at once, and the thrashing
5102 results in a lot of unnecessary loads
5103 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5104 (BuilderStatus.saveYourself): same
5105 (BuilderStatus.eventGenerator): stop generating on the first missing
5106 build. We assume that saved builds are deleted oldest-first.
5107 (BuildStepStatus.__getstate__): .progress might not exist
5109 * buildbot/changes/changes.py (ChangeMaster): make it
5110 serializable, in $masterdir/changes.pck
5111 (ChangeMaster.stopService): save on shutdown
5112 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5113 * buildbot/test/test_config.py: load Changes before config file
5116 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5117 "Oh my god, you killed the command" header on a separate line
5119 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5120 skip over corrupted build pickles
5121 (BuilderStatus.getFullBuildByNumber): same
5122 (BuilderStatus.eventGenerator): skip over unavailable builds
5123 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5124 do an atomic rename. This prevents a corrupted pickle when some
5125 internal serialization error occurs.
5126 (BuilderStatus.saveYourself): same
5128 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5129 the timeout for shell commands, it got lost somehow
5131 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5132 run out of build steps, return the rest of the builder events
5134 * buildbot/interfaces.py (IBuilderControl.ping): add method
5136 * buildbot/process/builder.py (BuilderControl.ping): move
5137 slave-ping to BuilderControl, and fix the failure case in the
5138 process (Event.finish() is the verb, Event.finished is the noun).
5140 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5141 through the BuilderControl instead of the BuilderStatus
5142 (EventBox): add adapter for builder.Event, allowing builder events to
5143 be displayed in the waterfall display
5145 * buildbot/master.py (BotMaster.stopService): add a 'master
5146 shutdown' event to the builder's log
5147 (BuildMaster.startService): and a 'master started' on startup
5149 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5150 builder events into the BuildStep event stream
5151 (Status.builderAdded): add a 'builder created' event
5154 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5155 command to announce the completion of a running build
5156 (IrcStatusBot.command_FORCE): announce when the build finishes
5158 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5159 don't evict unfinished builds from the cache: they must stay in
5160 the full-cache until their logfiles have stopped changing. Make
5161 sure the eviction loop terminates if an unfinished build was hit.
5162 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5163 This lets exceptions be dumped in an email status message. Really
5164 we need LogFiles which contain both text and HTML, instead of two
5166 (BuildStatus.__getstate__): handle self.finished=False
5167 (Status.builderAdded): if the pickle is corrupted, abandon the
5168 history and create a new BuilderStatus object.
5170 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5171 self.progress attribute, helped one test which doesn't fully set
5172 up the Build object.
5174 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5175 IStatusLog methods into an Interface that is implemented by "stub"
5176 logs, for which all the actual text chunks are on disk (in the
5177 pickled Build instance). To show the log contents, you must first
5178 adapt the stub log to a full IStatusLog object.
5180 * buildbot/status/builder.py (LogFileStub): create separate stub
5181 log objects, which can be upgraded to a real one if necessary.
5182 (LogFile): make them persistable, and let them stubify themselves
5184 (BuildStepStatus): same
5186 (BuildStatus.saveYourself): save the whole build out to disk
5187 (BuilderStatus): make it persistable
5188 (BuilderStatus.saveYourself): save the builder to disk
5189 (BuilderStatus.addFullBuildToCache): implement two caches which
5190 hold Build objects: a small one which holds full Builds, and a
5191 larger one which holds "stubbed" Builds (ones with their LogFiles
5192 turned into LogFileStubs). This reduces memory usage by the
5193 buildmaster by not keeping more than a few (default is 2) whole
5194 build logs in RAM all the time.
5195 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5197 (BuilderStatus.eventGenerator): rewrite since .builds went away
5198 (BuilderStatus.buildStarted): remove the .builds array. Add the
5199 build to the "full" cache when it starts.
5200 (BuilderStatus._buildFinished): save the build to disk when it
5202 (Status): give it a basedir (same as the BuildMaster's basedir)
5203 where the builder pickles can be saved
5204 (Status.builderAdded): create the BuilderStatus ourselves, by
5205 loading a pickle from disk (or creating a new instance if there
5206 was none on disk). Return the BuilderStatus so the master can glue
5207 it into the new Builder object.
5209 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5210 all BuilderStatuses to save themselves out to disk. This is in
5211 lieu of saving anything important in the main Application pickle
5212 (the -shutdown.tap file).
5213 (BuildMaster.__init__): give Status() a basedir for its files
5214 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5215 to get the BuilderStatus, then give it to the Builder (instead of
5216 doing it the other way around). It's ok if the status announces
5217 the new Builder before it's really ready, as the outside world can
5218 only see the BuilderStatus object anyway (and it is ready before
5219 builderAdded returns). Use the builder's "builddir" (which
5220 normally specifies where the slave will run the builder) as the
5221 master's basedir (for saving serialized builds).
5223 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5224 coerce the logfile to IStatusLog before trying to get the text
5225 chunks out of it. This will pull the full (non-stubified) Build in
5226 from disk if necessary.
5227 (TextLog): fix the adapter registration
5229 * buildbot/test/test_control.py (Force.setUp): create the basedir
5230 * buildbot/test/test_web.py: same
5231 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5232 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5233 * buildbot/test/test_run.py (Run.testMaster): same
5234 (Status.setUp): same
5236 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5238 * buildbot/status/html.py (Waterfall.__init__): store actual
5239 allowForce flag passed in rather than using True for everyone;
5240 make sure setting it to False doesn't cause a NameError
5242 (StatusResourceBuilder.__init__) add the builder name to the page
5244 (StatusResourceBuilder.body) move HTML generation for a name/value
5245 row into a helper method (StatusResourceBuilder.make_row); only
5246 generate the "Force Build" form if allowForce was True and the
5247 slave is connected. Use class attributes in the generated HTML to
5248 spread a little CSS-joy.
5250 2004-09-28 Brian Warner <warner@lothar.com>
5252 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5253 warning-scanner to not ignore things like
5254 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5256 * buildbot/status/html.py (StatusResource.control): add some
5257 class-level values for .control in an attempt to make upgrading
5260 * buildbot/util.py (ComparableMixin): survive missing attributes,
5261 such as when a class is modified and we're comparing old instances
5264 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5265 failure handling, remove a redundant try/except block. Don't
5266 return the full traceback to the IRC channel.
5267 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5268 error messages. Get ETA properly.
5270 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5271 the reason, since (at least) IRC message will have <> in them.
5272 (StatusResourceBuilder.__init__): take an IBuilderControl
5273 (StatusResourceBuilder.force): use the IBuilderControl we get in
5274 the constructor instead of trying to make our own. Catch the
5275 new exceptions and ignore them for now (until we make an
5276 intermediate web page where we could show the error message)
5277 (StatusResource): create with an IControl, use it to give an
5278 IBuilderControl to all children
5279 (Waterfall): take an allowForce= option, pass an IControl object
5280 to StatusResource if it is True
5282 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5284 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5285 catch new exceptions and return string forms
5287 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5288 * buildbot/process/builder.py (Builder.forceBuild): raise them
5289 * buildbot/test/test_control.py (Force.testNoSlave): new test
5290 (Force.testBuilderInUse): same
5293 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5295 * buildbot/test/test_run.py: use IControl
5296 * buildbot/test/test_vc.py: same
5298 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5299 to use IControl. Still offline.
5300 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5302 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5303 who=None so periodic builds don't send out status mail
5304 (Builder.forceBuild): include reason in the log message
5305 (BuilderControl.forceBuild): rename 'name' to 'who'
5307 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5308 'who' parameter, but make it None by default so builds forced by
5309 slave admins don't cause status mail to be sent to anybody
5310 (BotMaster.forceBuild): same. this method is deprecated.
5311 (DebugPerspective.perspective_forceBuild): same, use IControl.
5312 (DebugPerspective.perspective_fakeChange): use IControl..
5313 (Dispatcher.requestAvatar): .. so don't set .changemaster
5315 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5316 parameter to avoid confusion with the name of the builder
5319 * buildbot/status/mail.py: refine comment about needing 2.3
5321 * buildbot/status/html.py: move all imports to the top
5323 * buildbot/test/test_control.py: test new interfaces
5324 * buildbot/test/test_run.py (Status): handle new interfaces
5325 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5327 * buildbot/process/base.py (BuildControl): implement IBuildControl
5328 and its lonely getStatus() method
5330 * buildbot/process/builder.py (BuilderControl): implement
5331 IBuilderControl, obtained by adapting the Builder instance
5332 (Builder.startBuild): return a BuilderControl instead of a
5333 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5334 accomplish the same thing.
5336 * buildbot/master.py: move all import statements to the top
5337 (Control): implement IControl, obtained by adapting the
5338 BuildMaster instance.
5340 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5341 IBuildControl. These are used to force builds. Eventually they
5342 will provide ways to reconfigure the Builders, pause or abandon a
5343 Build, and perhaps control the BuildMaster itself.
5345 2004-09-26 Brian Warner <warner@lothar.com>
5347 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5348 ends up comparing us against something without a .__class__
5350 2004-09-24 Brian Warner <warner@lothar.com>
5352 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5355 * Makefile: add 'deb-snapshot' target, to create a timestamped
5358 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5360 2004-09-23 Brian Warner <warner@lothar.com>
5362 * buildbot/__init__.py (version): move version string here
5363 * setup.py: get version string from buildbot.version
5364 * buildbot/status/html.py (WaterfallStatusResource.body): add
5365 buildbot version to the page footer
5366 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5369 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5370 slaves, let the second know where the first one is coming from
5371 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5372 see our exceptions. It would be nice if there were a way to just
5373 send them the exception type and value, not the full traceback.
5376 * buildbot/status/mail.py (MailNotifier): add a new argument
5377 sendToInterestedUsers=, which can be set to False to disable the
5378 usual send-to-blamelist behavior.
5379 (top): handle python-2.2 which has no email.MIMEMultipart
5380 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5381 (MailNotifier.disownServiceParent): unsubscribe on removal
5383 * buildbot/test/test_status.py (Mail.testBuild2): test it
5386 * buildbot/status/progress.py (Expectations.wavg): tolerate
5387 current=None, which happens when steps start failing badly
5388 * buildbot/test/test_status.py (Progress.testWavg): test for it
5390 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5391 doesn't understand args['revision'], emit a warning instead of
5392 bailing completely. Updating to -rHEAD is probably close enough.
5394 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5396 * buildbot/test/test_status.py: at least import bb.status.client
5397 even if we don't have any test coverage for it yet
5399 * contrib/svn_buildbot.py: don't require python2.3
5400 (main): wait, do require it (for sets.py), but explain how to
5401 make it work under python2.2
5403 2004-09-23 Brian Warner <warner@lothar.com>
5405 * contrib/svn_buildbot.py: include the revision number in the Change
5407 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5408 using util.now() because FreshCVS is a realtime service
5410 * buildbot/status/event.py: delete dead code
5411 * buildbot/process/step.py: don't import dead Event class
5412 * buildbot/process/step_twisted.py: same
5413 * buildbot/status/builder.py: same
5414 * buildbot/status/client.py: same
5416 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5418 * buildbot/changes/changes.py (Change): set .when from an __init__
5419 argument (which defaults to now()), rather than having
5420 ChangeMaster.addChange set it later.
5421 (ChangeMaster.addChange): same
5423 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5424 (parseSyncmail): same. Just use util.now() for now.
5425 (parseBonsaiMail): parse the timestamp field for when=
5427 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5428 instead of setting .when after the fact
5432 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5433 results when the target project uses retrial. Still under
5435 * buildbot/test/test_trial.py: same
5437 2004-09-21 Brian Warner <warner@lothar.com>
5439 * buildbot/status/mail.py (MailNotifier.__init__): include
5440 success/warnings/failure in the Subject line
5441 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5442 use step.logname for the addLogs=True attachment filenames
5443 * buildbot/test/test_status.py (Mail): test Subject lines
5444 (Mail.testLogs): test attachment filenames
5446 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5447 accept a 'who' argument from the debug tool
5448 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5449 * contrib/debug.glade: add text box to set 'who'
5451 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5452 .getBuilderName with .getBuilder().getName(), more flexible
5453 (IStatusLog.getName): logs have short names, but you can prefix
5454 them with log.getStep().getName() to make them more useful
5455 * buildbot/status/builder.py: same
5456 * buildbot/status/client.py: same
5457 * buildbot/status/html.py: same
5458 * buildbot/test/test_run.py (Status.testSlave): same
5459 * buildbot/process/step.py: tweak logfile names
5461 * buildbot/status/mail.py (MailNotifier): add lookup, change
5462 argument to extraRecipients. The notifier is now aimed at sending
5463 mail to the people involved in a particular build, with additional
5464 constant recipients as a secondary function.
5466 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5467 including slow-lookup and failing-lookup. Make sure the blamelist
5468 members are included.
5470 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5471 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5472 (IBuildStatus.getInterestedUsers): new method
5473 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5474 * buildbot/status/client.py (remote_getResponsibleUsers): same
5475 * buildbot/status/html.py (StatusResourceBuild.body): same
5476 * buildbot/test/test_run.py (Status.testSlave): same
5478 2004-09-20 Brian Warner <warner@lothar.com>
5480 * docs/users.xhtml: update concepts
5482 * Makefile: add a convenience makefile, for things like 'make
5483 test'. It is not included in the source tarball.
5485 2004-09-16 Brian Warner <warner@lothar.com>
5487 * NEWS: mention /usr/bin/buildbot, debian/*
5489 * debian/*: add preliminary debian packaging. Many thanks to
5490 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5491 it considerably since it left their hands, I am responsible for
5492 all breakage that's resulted.
5494 * bin/buildbot: create a top-level 'buildbot' command, to be
5495 installed in /usr/bin/buildbot . For now it's just a simple
5496 frontend to mktap/twistd/kill, but eventually it will be the entry
5497 point to the 'try' command and also a status client. It is also
5498 intended to support the upcoming debian-packaging init.d scripts.
5499 * buildbot/scripts/runner.py: the real work is done here
5500 * buildbot/scripts/__init__.py: need this too
5501 * buildbot/scripts/sample.cfg: this is installed in new
5502 buildmaster directories
5503 * setup.py: install new stuff
5505 2004-09-15 Brian Warner <warner@lothar.com>
5507 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5508 'file:' schema (the version shipped with OS-X was built without the
5510 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5511 updates the log-timestamp, to make sure it isn't still running after
5514 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5515 values to the config file.
5516 * docs/examples/hello.cfg: add examples
5517 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5518 * buildbot/status/builder.py (Status.getProjectURL): implement them
5519 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5520 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5521 * buildbot/status/html.py (WaterfallStatusResource): display them
5524 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5525 certain error cases don't suffer a secondary exception.
5526 (top): Skip tests if the corresponding VC tool is not installed.
5528 * buildbot/process/factory.py (Trial): introduce separate
5529 'buildpython' and 'trialpython' lists, since trialpython=[] is
5530 what you want to invoke /usr/bin/python, whereas ./setup.py is
5531 less likely to be executable. Add env= parameter to pass options
5532 to test cases (which is how I usually write tests, I don't know if
5533 anyone else does it this way).
5535 * buildbot/process/step_twisted.py (Trial): handle python=None.
5536 Require 'testpath' be a string, not a list. Fix tests= typo.
5537 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5539 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5540 way to deal with the possibility of removing the disconnect notify
5542 (CVS): add a 'login' parameter to give a password to 'cvs login',
5543 commonly used with pserver methods (where pw="" or pw="guest")
5545 * buildbot/slave/commands.py (SourceBase): move common args
5546 extraction and setup() to __init__, so everything is ready by the
5547 time setup() is called
5548 (CVS.start): call 'cvs login' if a password was supplied
5549 (ShellCommand): special-case PYTHONPATH: prepend the master's
5550 value to any existing slave-local value.
5552 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5553 don't have a remote, mark the builder as Offline. This whole
5554 function should probably go away and be replaced by individual
5556 (Builder.buildFinished): return the results to the build-finished
5557 deferred callback, helps with testing
5559 2004-09-14 Brian Warner <warner@lothar.com>
5561 * buildbot/test/test_vc.py: put all the repositories needed to run
5562 the complete tests into a single small (1.3MB) tarball, so I can
5563 make that tarball available on the buildbot web site. Test HTTP
5564 access (for Arch and Darcs) by spawning a temporary web server
5565 while the test runs.
5567 * docs/users.xhtml: new document, describe Buildbot's limited
5568 understanding of different human users
5570 * buildbot/test/test_vc.py: rearrange test cases a bit
5572 * buildbot/process/step_twisted.py (Trial): handle testpath=
5573 * buildbot/process/factory.py (Trial): update to use step.Trial
5575 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5577 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5578 the overall build text (which gives you 'failed 2 tests' rather
5580 (BuildStepStatus.text2): default to [], not None
5582 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5585 2004-09-12 Brian Warner <warner@lothar.com>
5587 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5588 log the whole exception if it's just an AttributeError (old slave)
5590 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5591 so (e.g.) sub-commands can be run in the right directory.
5592 (ShellCommand.start): accept an optional errorMessage= argument
5593 to make life easier for SVN.start
5594 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5596 (ShellCommand.start): move ['dir'] compatibility hack..
5597 (RemoteShellCommand.start): .. to here so everyone can use it
5599 * buildbot/process/step_twisted.py (Trial): use .workdir
5601 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5602 text displayed when debuild fails completely
5603 (Trial): snarf _trial_temp/test.log from the slave and display it
5605 2004-09-11 Brian Warner <warner@lothar.com>
5607 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5609 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5610 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5612 * buildbot/process/step.py (ShellCommand): call .createSummary
5613 before .evaluateCommand instead of the other way around. This
5614 makes it slightly easier to count warnings and then use that to
5615 set results=WARNINGS
5616 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5618 * buildbot/process/base.py (Build.buildFinished): update status
5619 before doing progress. It's embarrassing for the build to be stuck
5620 in the "building" state when an exceptions occurs elsewhere..
5622 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5623 python2.2 doesn't have 'sum'
5625 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5626 to prevent clients from accidentally sorting it
5628 * buildbot/master.py (Manhole): add username/password
5629 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5630 c['manholePort'], deprecate old usage
5631 * docs/config.xhtml: document c['manhole']
5632 * docs/examples/hello.cfg: show example of using a Manhole
5635 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5636 pretend the slave is up to date
5638 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5639 the module, overlaps with 'log', the local variable
5641 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5643 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5644 new method to let Steps find out the version of their
5645 corresponding SlaveCommand.
5646 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5647 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5648 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5650 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5651 (Arch.startVC): same
5652 (P4Sync.startVC): same
5654 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5655 Deferred so we can catch errors in remote_startCommand
5656 (RemoteShellCommand.start): same
5658 * docs/examples/twisted_master.cfg: update sample config file
5660 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5661 after connectionMade() is called, not before. Close stdin at that
5664 * buildbot/process/process_twisted.py: update to use Trial, clean
5665 up argument passing (move to argv arrays instead of string
5668 * buildbot/process/step_twisted.py (Trial): new step to replace
5669 RunUnitTests, usable by any trial-using project (not just
5670 Twisted). Arguments have changed, see the docstring for details.
5672 * buildbot/process/base.py (Build.startBuild): this now returns a
5673 Deferred. Exceptions that occur during setupBuild are now
5674 caught better and lead to fewer build_status weirdnesses, like
5675 finishing a build that was never started.
5676 (Build.buildFinished): fire the Deferred instead of calling
5677 builder.buildFinished directly. The callback argument is this
5678 Build, everything else can be extracted from it, including the
5679 new build.results attribute.
5680 * buildbot/process/builder.py (Builder.startBuild): same
5681 (Builder.buildFinished): same, extract results from build
5683 * buildbot/process/step.py (ShellCommands): remove dead code
5685 2004-09-08 Brian Warner <warner@lothar.com>
5687 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5688 doesn't try to use the leftover patched workdir
5689 (SourceStamp): test source-stamp computation for CVS and SVN
5691 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5692 patched workdir ('touch .buildbot-patched') so we don't try to
5694 (SourceBase.start): add ['revision'] for all Source steps
5695 (CVS): change args: use ['branch'] for -r, remove ['files']
5696 (CVS.buildVC): fix revision/branch stuff
5697 (SVN): add revision stuff
5699 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5700 kwargs (except 'workdir') to avoid silent spelling errors
5701 (ShellCommand.__init__): same
5702 (Source): new base class for CVS/SVN/etc. Factor out everything
5703 common, add revision computation (perform the checkout with a -D
5704 DATE or -r REVISION that gets exactly the sources described by the
5705 last Change), overridable with step.alwaysUseLatest. Add patch
5706 handling (build.getSourceStamp can trigger the use of a base
5707 revision and a patch).
5708 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5709 * docs/steps.xhtml: update docs
5710 * docs/source.xhtml: mention .checkoutDelay
5711 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5713 * buildbot/process/base.py (Build.setSourceStamp): add a
5714 .sourceStamp attribute to each Build. If set, this indicates that
5715 the build should be done with something other than the most
5716 recent source tree. This will be used to implement "try" builds.
5717 (Build.allChanges): new support method
5718 (Build.lastChangeTime): remove, functionality moved to Source steps
5719 (Build.setupBuild): copy the Step args before adding ['workdir'],
5720 to avoid modifying the BuildFactory (and thus triggering spurious
5724 * buildbot/status/html.py: rename s/commits/changes/
5725 (StatusResourceChanges): same
5726 (CommitBox.getBox): same, update URL
5727 (WaterfallStatusResource): same
5728 (StatusResource.getChild): same
5730 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5731 * contrib/debug.glade: add optional 'revision' to the fakeChange
5733 * buildbot/changes/changes.py (html_tmpl): display .revision
5734 (ChangeMaster.addChange): note .revision in log
5735 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5736 accept a ['revision'] attribute
5738 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5740 * buildbot/master.py (BotMaster.getPerspective): update the
5741 .connected flag in SlaveStatus when it connects
5742 (BotMaster.detach): and when it disconnects
5743 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5744 (BuildMaster.loadConfig_Builders): walk old list correctly
5746 * buildbot/test/test_config.py: fix prefix= usage
5748 2004-09-06 Brian Warner <warner@lothar.com>
5752 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5753 poll a P4 depot looking for recent changes. Thanks to Dave
5754 Peticolas for the contribution. Probably needs some testing after
5757 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5758 requires manual client setup for each buildslave. Rather
5759 experimental. Thanks again to Dave Peticolas.
5760 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5762 * buildbot/changes/changes.py (Change): add a .revision attribute,
5763 which will eventually be used to generate source-stamp values.
5765 * buildbot/process/step.py (RemoteCommand.start): use
5766 notifyOnDisconnect to notice when we lose the slave, then treat it
5767 like an exception. This allows LogFiles to be closed and the build
5768 to be wrapped up normally. Be sure to remove the disconnect
5769 notification when the step completes so we don't accumulate a
5770 bazillion such notifications which will fire weeks later (when the
5771 slave finally disconnects normally). Fixes SF#915807, thanks to
5772 spiv (Andrew Bennetts) for the report.
5773 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5774 really isn't Logged- specific
5775 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5776 header, since it's almost always going to be appended to an
5778 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5779 update test to handle use of notifyOnDisconnect
5781 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5782 don't clear .ETA and .currentBuild when going offline, let the
5783 current build clean up after itself
5785 * buildbot/process/builder.py (Builder.detached): wait a moment
5786 before doing things like stopping the current build, because the
5787 current step will probably notice the disconnect and cleanup the
5789 * buildbot/test/test_run.py (Status.tearDown): update test to
5790 handle asynchronous build-detachment
5792 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5794 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5795 hush a debug message
5797 2004-09-05 Brian Warner <warner@lothar.com>
5799 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5800 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5801 kernels do this: the fcntl module has the F_NOTIFY constant, but
5802 the kernel itself doesn't support the operation. Thanks to Olly
5803 Betts for spotting the problem.
5805 * buildbot/process/step.py (Darcs): new source-checkout command
5806 (Arch): new source-checkout command
5807 (todo_P4): fix constructor syntax, still just a placeholder
5808 * buildbot/test/test_vc.py (VC.testDarcs): test it
5809 (VC.testDarcsHTTP): same, via localhost HTTP
5811 (VC.testArchHTTP): same
5812 * NEWS: mention new features
5814 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5815 which tells the step to stash stdout text locally (in .stdout).
5816 Slave-side Commands can use this to make decisions based upon the
5817 output of the the ShellCommand (not just the exit code).
5818 (Darcs): New source-checkout command
5819 (Arch): New source-checkout command, uses .keepStdout in one place
5820 where it needs to discover the archive's default name.
5822 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5823 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5824 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5826 * buildbot/process/step.py (ShellCommand.describe): add an
5827 alternate .descriptionDone attribute which provides descriptive
5828 text when the step is complete. .description can be ["compiling"],
5829 for use while the step is running, then .descriptionDone can be
5830 ["compile"], used alone when the step succeeds or with "failed" when
5831 it does not. Updated other steps to use the new text.
5832 * buildbot/process/step_twisted.py: same
5833 * buildbot/test/test_run.py: update tests to match
5835 2004-08-30 Brian Warner <warner@lothar.com>
5837 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5838 (CVS.__init__): send 'patch' argument to slave
5839 (CVS.start): don't create the LoggedRemoteCommand until start(),
5840 so we can catch a .patch added after __init__
5841 (SVN.__init__): add 'patch' to SVN too
5844 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5845 argument, to let commands push data into the process' stdin pipe.
5846 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5847 is in use, since closing a PTY doesn't really affect the process
5848 in the right way (in particular, I couldn't run /usr/bin/patch
5850 (SourceBase.doPatch): handle 'patch' argument
5852 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5855 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5856 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5858 * buildbot/master.py (BotPerspective.got_commands): get command
5859 versions from slave, give to each builder
5860 * buildbot/process/builder.py (Builder.attached): stash slave
5861 command versions in .remoteCommands
5863 * docs/steps.xhtml: bring docs in-line with reality
5865 * buildbot/process/step.py (CVS.__init__): more brutal
5866 compatibility code removal
5867 (SVN.__init__): same
5869 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5870 (SlaveShellCommand.start): require ['workdir'] argument, remove
5871 the ['dir'] fallback (compatibility will come later)
5872 (SourceBase): update docs
5873 (SourceBase.start): remove ['directory'] fallback
5876 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5877 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5878 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5880 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5881 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5882 code.. I will figure out 0.5.0-compatibility hooks later)
5884 2004-08-30 Brian Warner <warner@lothar.com>
5886 * buildbot/process/process_twisted.py: rewrite in terms of new
5887 BuildFactory base class. It got significantly shorter. Yay
5890 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5891 work with the new "self.build isn't nailed down until we call
5892 step.start()" scheme: specifically, __init__ is called before the
5893 build has decided on which Changes are going in, so we don't scan
5894 build.allFiles() for .xhtml files until start()
5895 (HLint.commandComplete): use getText(), not getStdout()
5896 (RunUnitTests.start): same: don't use .build until start()
5897 (RunUnitTests.describe): oops, don't report (None) when using
5899 (RunUnitTests.commandComplete): use getText()
5900 (RunUnitTests.createSummary): same
5901 (BuildDebs.commandComplete): same
5903 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5904 set args['command'] until start(), since our BuildStep is allowed
5905 to change their mind up until that point
5906 (TreeSize.commandComplete): use getText(), not getStdout()
5908 * docs/examples/twisted_master.cfg: update to current standards
5910 * docs/factories.xhtml: update
5911 * buildbot/process/factory.py: implement all the common factories
5912 described in the docs. The Trial factory doesn't work yet, and
5913 I've probably broken all the process_twisted.py factories in the
5914 process. There are compatibility classes left in for things like
5915 the old BasicBuildFactory, but subclasses of them are unlikely to
5917 * docs/examples/glib_master.cfg: use new BuildFactories
5918 * docs/examples/hello.cfg: same
5920 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5921 explicit 'workdir' args
5923 * buildbot/process/base.py (BuildFactory): move factories to ..
5924 * buildbot/process/factory.py (BuildFactory): .. here
5925 * buildbot/process/process_twisted.py: handle move
5926 * buildbot/test/test_config.py: same
5927 * buildbot/test/test_run.py: same
5928 * buildbot/test/test_steps.py: same
5929 * buildbot/test/test_vc.py: same
5930 * docs/factories.xhtml: same
5932 * NEWS: mention config changes that require updating master.cfg
5934 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5935 argument to all steps that weren't given one already, pointing at
5936 the "build/" directory.
5938 * docs/examples/hello.cfg: remove explicit 'workdir' args
5940 * docs/factories.xhtml: document standard BuildFactory clases,
5941 including a bunch which are have not yet been written
5943 2004-08-29 Brian Warner <warner@lothar.com>
5945 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5946 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5947 buildbot.status.builder so they aren't quite so internal
5948 * buildbot/process/base.py, buildbot/process/builder.py: same
5949 * buildbot/process/maxq.py, buildbot/process/step.py: same
5950 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5951 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5952 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5954 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5955 to handle new getLogs()-returns-list behavior
5956 (StatusResourceBuildStep.getChild): same
5957 (StepBox.getBox): same
5958 (WaterfallStatusResource.phase0): same
5960 * docs/source.xhtml: document how Buildbot uses version-control
5961 systems (output side: how we get source trees)
5962 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5963 systems (input side: how we learn about Changes)
5965 * buildbot/master.py (Manhole): use ComparableMixin
5966 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5967 * buildbot/changes/mail.py (MaildirSource): same
5968 * buildbot/status/client.py (PBListener): same
5969 * buildbot/status/html.py (Waterfall): same
5970 * buildbot/status/words.py (IRC): same
5972 * NEWS: start describing new features
5974 * buildbot/status/mail.py (MailNotifier): finish implementation.
5975 The message body is still a bit sparse.
5976 * buildbot/test/test_status.py (Mail): test it
5978 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5979 and __hash__ methods I wind up adding everywhere. Specifically
5980 intended to support the buildbot config-file update scheme where
5981 we compare, say, the old list of IStatusTargets against the new
5982 one and don't touch something which shows up on both lists.
5983 * buildbot/test/test_util.py (Compare): test case for it
5985 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5986 return a list instead of a dict
5987 (IBuildStepStatus.getLogs): same. The idea is that steps create
5988 logs with vaguely unique names (although their uniqueness is not
5989 guaranteed). Thus a compilation step should create its sole
5990 logfile with the name 'compile', and contribute it to the
5991 BuildStatus. If a step has two logfiles, try to create them with
5992 different names (like 'test.log' and 'test.summary'), and only
5993 contribute the important ones to the overall BuildStatus.
5994 * buildbot/status/builder.py (Event.getLogs): same
5995 (BuildStepStatus): fix default .text and .results
5996 (BuildStepStatus.addLog): switch to list-like .getLogs()
5997 (BuildStepStatus.stepFinished): same
5998 (BuildStatus.text): fix default .text
5999 (BuildStatus.getLogs): temporary hack to return all logs (from all
6000 child BuildStepStatus objects). Needs to be fixed to only report
6001 the significant ones (as contributed by the steps themselves)
6002 * buildbot/test/test_run.py: handle list-like .getLogs()
6003 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6005 2004-08-28 Brian Warner <warner@lothar.com>
6007 * buildbot/process/builder.py (Builder.attached): serialize the
6008 attachment process, so the attach-watcher isn't called until the
6009 slave is really available. Add detached watchers too, which makes
6012 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6014 * buildbot/test/test_swap.py: remove dead code
6016 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6017 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6018 sort of as if the command being run exited with a -1. There may
6019 still be some holes in this scheme.
6020 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6021 -r option appears before the module list
6022 * buildbot/process/step.py (CVS): add 'revision' argument
6024 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6025 when sending updates or stepComplete messages to the master, since
6026 we don't currently care whether they arrive or not. When we revamp
6027 the master/slave protocol to really resume interrupted builds,
6028 this will need revisiting.
6029 (lostRemote): remove spurious print
6031 * buildbot/master.py (BotPerspective.attached): serialize the
6032 new-builder interrogation process, to make testing easier
6033 (BotMaster.waitUntilBuilderDetached): convenience function
6035 * buildbot/status/builder.py (BuilderStatus): prune old builds
6036 (BuildStatus.pruneSteps): .. and steps
6037 (BuildStepStatus.pruneLogs): .. and logs
6038 (BuilderStatus.getBuild): handle missing builds
6039 * buildbot/status/html.py (StatusResourceBuild.body): display build
6040 status in the per-build page
6041 (BuildBox.getBox): color finished builds in the per-build box
6043 2004-08-27 Brian Warner <warner@lothar.com>
6045 * buildbot/status/mail.py (MailNotifier): new notification class,
6048 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6049 variants of a common base class which handles all the mode= logic
6051 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6053 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6055 2004-08-26 Brian Warner <warner@lothar.com>
6057 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6060 * buildbot/test/test_run.py: update to new Logfile interface, new
6061 buildbot.slave modules
6062 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6064 * MANIFEST.in: new sample config file
6065 * docs/examples/hello.cfg: same
6067 * buildbot/process/step_twisted.py: remove dead import
6069 * buildbot/process/step.py (RemoteCommand.run): catch errors
6071 (RemoteCommand.remote_update): ignore updates that arrive after
6073 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6074 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6075 the responsibilities of the subclass's methods
6076 (BuildStep.failed): catch errors during failure processing
6077 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6078 (CVS): move to a mode= argument (described in docstring), rather
6079 than the ungainly clobber=/export=/copydir= combination.
6080 (SVN): add mode= functionality to SVN too
6081 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6083 * buildbot/process/base.py (Build.startNextStep): catch errors
6084 during s.startStep()
6086 * buildbot/clients/base.py: update to new PB client interface.
6087 gtkPanes is still broken
6089 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6090 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6091 * setup.py: add buildbot.slave module
6092 * buildbot/bb_tap.py: handle move
6093 * buildbot/slave/registry.py: place to register commands, w/versions
6094 * buildbot/slave/bot.py: major simplifications
6095 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6096 instead of a fixed table. Eventually this will make the slave more
6097 extensible. Use 'start' method on the command, not .startCommand.
6098 Fix unsafeTracebacks handling (I think).
6099 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6100 helper class with a .start method that returns a Deferred.
6101 SlaveShellCommand is the form reached by the buildmaster. Commands
6102 which use multiple ShellCommands can just chain them as Deferreds,
6103 with some helper methods in Command (_abandonOnFailure and
6104 _checkAbandoned) to bail on rc!=0.
6105 (CVSCommand): prefer new mode= argument
6106 (SVNFetch): add mode= argument
6108 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6109 put a useful reason string on the build
6111 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6112 core functionality into an IStatusLog object
6113 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6114 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6115 (StatusResourceBuild.body): use proper accessor methods
6116 * buildbot/status/client.py (RemoteLog): PB-access goes here
6117 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6118 which delivers log contents too
6119 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6120 * buildbot/status/event.py: remove old Logfile completely
6122 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6123 subscription interface for IStatusLog subscriptions just like all
6124 other the status subscriptions
6125 (IStatusReceiver.logChunk): method called on subscribers
6127 2004-08-24 Brian Warner <warner@lothar.com>
6129 * buildbot/process/builder.py (Builder._pong): oops, ping response
6130 includes a result (the implicit None returned by remote_print).
6131 Accept it so the _pong method handles the response correctly.
6133 2004-08-06 Brian Warner <warner@lothar.com>
6135 * buildbot/test/test_config.py: update IRC, PBListener tests
6137 * buildbot/status/client.py (StatusClientPerspective): total
6138 rewrite to match new IStatus interfaces. New subscription scheme.
6139 There are still a few optimizations to make (sending down extra
6140 information with event messages so the client doesn't have to do a
6141 round trip). The logfile-retrieval code is probably still broken.
6142 Moved the PB service into its own port, you can no longer share a
6143 TCP socket between a PBListener and, say, the slaveport (this
6144 should be fixed eventually).
6145 * buildbot/clients/base.py (Client): revamp to match. still needs
6146 a lot of work, but basic event reporting works fine. gtkPanes is
6149 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6150 instance talks to a single irc server. Threw out all the old
6151 multi-server handling code. Still need to add back in
6152 builder-control (i.e. "force build")
6154 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6155 more random text to the as-yet-unreachable per-step page
6157 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6158 rename to stepETAUpdate
6159 (BuildStatus.subscribe): add build-wide ETA updates
6160 (BuilderStatus.getState): remove more cruft
6161 (BuilderStatus.getCurrentBuild): remove more cruft
6162 (BuilderStatus.buildStarted): really handle tuple-subscription
6163 * buildbot/test/test_run.py (Status.testSlave): handle the
6164 stepETAUpdate rename
6166 * buildbot/master.py (BuildMaster): don't add a default
6167 StatusClientService. Don't add a default IrcStatusFactory. Both
6168 are now added through c['status'] in the config file. c['irc'] is
6169 accepted for backwards compatibility, the only quirk is you cannot
6170 use c['irc'] to specify IRC servers on ports other than 6667.
6172 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6173 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6174 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6175 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6178 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6179 the buildmaster to re-read its config file
6182 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6183 find out the port our server is running on
6184 (WebTest.test_webPathname_port): same
6186 * buildbot/test/test_config.py (testWebPortnum): test it
6187 (testWebPathname): ditto
6189 * docs/config.xhtml: document new c['status'] configuration option
6191 * buildbot/status/html.py (Waterfall): new top-level class which
6192 can be added to c['status']. This creates the Site as well as the
6193 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6194 reachable as .parent, for everything.
6196 * buildbot/master.py (Manhole): make it a normal service Child
6197 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6198 webPathname. It will eventually replace c['irc'] and the implicit
6199 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6200 in as (deprecated) backward compatibility hooks for now.
6203 * buildbot/process/builder.py (Builder.buildFinished): don't
6204 inform out builder_status about a finished build, as it finds out
6205 through its child BuildStatus object
6207 * buildbot/status/html.py: extensive revamp. Use adapters to make
6208 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6209 have both starting and finishing times and adjust the waterfall
6210 display accordingly, using spacers if necessary. Use SlaveStatus
6211 to get buildslave info.
6212 (StatusResourceBuildStep): new just-one-step resource, used to get
6213 logfiles. No actual href to it yet.
6215 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6216 the time being, until I get the file-naming scheme right
6218 * buildbot/status/builder.py (Event): clean started/finished names
6219 (BuildStatus.isFinished): .finished is not None is the right test
6220 (BuildStatus.buildStarted): track started/finished times ourselves
6221 (BuilderStatus.getSlave): provide access to SlaveStatus object
6222 (BuilderStatus.getLastFinishedBuild): all builds are now in
6223 .builds, even the currently-running one. Accomodate this change.
6224 (BuilderStatus.eventGenerator): new per-builder event generator.
6225 Returns BuildStepStatus and BuildStatus objects, since they can
6226 both be adapted as necessary.
6227 (BuilderStatus.addEvent): clean up started/finished attributes
6228 (BuilderStatus.startBuild,finishBuild): remove dead code
6229 (SlaveStatus): new object to provide ISlaveStatus
6231 * buildbot/process/step.py (ShellCommand.getColor): actually
6232 return the color instead of setting it ourselves
6233 (CVS.__init__): pull .timeout and .workdir options out of
6234 **kwargs, since BuildStep will ignore them. Without this neither
6235 will be sent to the slave correctly.
6236 (SVN.__init__): same
6238 * buildbot/process/builder.py (Builder): move flags to class-level
6240 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6241 SlaveStatus handle that
6243 * buildbot/process/base.py (Build.firstEvent): remove dead code
6244 (Build.stopBuild): bugfix
6246 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6248 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6249 (ChangeMaster.eventGenerator): yield Changes, since there are now
6250 Adapters to turn them into HTML boxes
6252 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6253 (BotPerspective.attached): feed a SlaveStatus object
6254 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6255 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6257 * buildbot/interfaces.py: API additions
6258 (ISlaveStatus): place to get slave status
6260 2004-08-04 Brian Warner <warner@lothar.com>
6262 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6263 the delay finishes, so the step is marked as SUCCESS
6265 * buildbot/test/test_run.py (Status.testSlave): cover more of
6266 IBuildStatus and IBuildStepStatus
6268 * buildbot/status/progress.py (StepProgress): move some flags to
6269 class-level attributes
6270 (StepProgress.remaining): if there are no other progress metrics
6271 to go by, fall back to elapsed time
6272 (StepProgress.setExpectations): take a dict of metrics instead of
6274 (BuildProgress.setExpectationsFrom): pull expectations from the
6275 Expectations, instead of having it push them to the BuildProgress
6276 (Expectations): move some flags to class-level attributes
6277 (Expectations.__init__): copy per-step times from the
6279 (Expectations.expectedBuildTime): new method for per-build ETA
6281 * buildbot/status/event.py (Logfile): move some flags to
6282 class-level attributes
6283 (Logfile.logProgressTo): better method name, let step set the
6284 progress axis name (instead of always being "output")
6286 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6287 times directly, rather than depending upon the (possibly missing)
6288 .progress object. Use 'None' to indicate "not started/finished
6290 (BuildStepStatus.getExpectations): oops, return the full list of
6292 (BuilderStatus._buildFinished): append finished builds to .builds
6294 * buildbot/process/step.py (BuildStep): add separate .useProgress
6295 flag, since empty .progressMetrics[] still implies that time is a
6297 (CVS): set up the cmd in __init__, instead of waiting for start()
6299 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6300 calculation, this will eventually turn into a proper sourceStamp
6301 (Build.setupBuild): tell the Progress to load from the Expectations,
6302 instead of having the Expectations stuff things into the Progress
6303 (Build.buildException): add a build-level errback to make sure the
6304 build's Deferred fires even in case of exceptions
6306 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6308 * buildbot/process/builder.py (Builder.forceBuild): convey the
6309 reason instead of creating a fake Change
6311 * docs/examples/twisted_master.cfg: update to match reality
6313 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6314 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6315 fix or remove broken/breaking tests
6317 * buildbot/status/event.py (Logfile.__len__): remove evil method
6319 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6320 missing .build, for test convenience
6322 * buildbot/process/step_twisted.py: import fixes
6324 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6326 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6327 .statusbag reference
6329 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6330 connection at shutdown, and stop it from reconnecting
6332 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6333 chase down remote-execution bugs
6335 * buildbot/process/step.py: more fixes, remove
6336 BuildStep.setStatus()
6337 * buildbot/status/builder.py: move setStatus() functionality into
6339 * buildbot/status/event.py: minor fixes
6341 2004-08-03 Brian Warner <warner@lothar.com>
6343 * buildbot/process/base.py, buildbot/process/builder.py
6344 * buildbot/process/step.py, buildbot/status/builder.py
6345 * buildbot/status/event.py, buildbot/test/test_run.py:
6346 fix status delivery, get a basic test case working
6347 * buildbot/master.py: finish implementing basic status delivery,
6348 temporarily disable HTML/IRC/PB status sources
6350 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6352 * buildbot/status/progress.py (BuildProgress): remove dead code
6354 * buildbot/interfaces.py
6355 * buildbot/process/base.py, buildbot/process/builder.py
6356 * buildbot/process/step.py, buildbot/process/step_twisted.py
6357 * buildbot/status/builder.py: Complete overhaul of the all
6358 status-delivery code, unifying all types of status clients (HTML,
6359 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6360 look like. This commit is a checkpointing of the work-in-progress:
6361 the input side is mostly done (Builders/Builds sending status
6362 to the BuilderStatus/BuildStatus objects), but the output side has
6363 not yet been started (HTML resources querying BuilderStatus
6364 objects). Things are probably very broken right now and may remain
6365 so for several weeks, I apologize for the disruption.
6367 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6368 HTML as the log's contents. Currently used for exception tracebacks.
6369 * buildbot/status/progress.py: minor spelling changes
6371 2004-08-02 Brian Warner <warner@lothar.com>
6373 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6374 in mozilla. Also added stylesheets copied from Twisted's docs.
6375 Remember that these files are meant to be run through Lore first.
6376 Thanks to Philipp Frauenfelder for the fixes.
6377 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6378 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6379 * docs/template.tpl: added a Lore template
6381 2004-07-29 Brian Warner <warner@lothar.com>
6383 * buildbot/interfaces.py: revamp status delivery. This is the
6384 preview: these are the Interfaces that will be provided by new
6385 Builder code, and to which the current HTML/IRC/PB status
6386 displayers will be adapted.
6388 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6389 on the SlaveBuilder, not the Bot.
6390 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6392 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6393 set .usePTY on the FakeSlaveBuilder
6395 2004-07-25 Brian Warner <warner@lothar.com>
6397 * buildbot/changes/freshcvs.py: add some debug log messages
6398 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6399 disabled 'setFilter' syntax
6400 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6401 don't end with a slash
6403 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6405 * setup.py: bump to 0.5.0+ while between releases
6407 2004-07-23 Brian Warner <warner@lothar.com>
6409 * setup.py (version): Releasing buildbot-0.5.0
6411 2004-07-23 Brian Warner <warner@lothar.com>
6413 * README: update for 0.5.0 release
6415 * NEWS: update for 0.5.0 release
6417 2004-07-22 Brian Warner <warner@lothar.com>
6419 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6420 mktap-time configuration flag (--usepty=1, --usepty=0)
6421 * buildbot/bot.py: same
6423 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6424 an 'info' directory being unwanted
6426 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6427 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6428 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6429 and earlier), use a FreshCVSSourceOldcred instead.
6430 (test): simple test routine: connect to server, print changes
6432 * buildbot/changes/changes.py (Change.getTime): make it possible
6433 to print un-timestamped changes
6435 * buildbot/master.py (makeApp): delete ancient dead code
6436 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6437 * buildbot/test/test_config.py (testFindConfigFile): test it
6439 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6440 instead of win32 one
6443 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6444 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6447 * buildbot/process/base.py (Builder.__init__): change constructor
6448 to accept a dictionary of config data, rather than discrete
6449 name/slave/builddir/factory arguments
6451 * docs/examples/twisted_master.cfg: update to new syntax
6452 * docs/examples/glib_master.cfg: same
6453 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6454 rough tests of the new syntax
6457 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6458 to be an int, which means "run a web.distrib sub-server on a TCP
6459 port". This lets you publish the buildbot status page to a remote
6460 twisted.web server (using distrib.ResourceSubscription). Also
6461 rename the local attributes used to hold these web things so
6462 they're more in touch with reality.
6463 * buildbot/test/test_web.py: test webPortnum and webPathname
6464 * docs/config.xhtml: document this new use of webPathname
6466 * docs/config.xhtml: new document, slightly ahead of reality
6468 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6469 'prefix' handling: treat it as a simple string to check with
6470 .startswith, instead of treating it as a directory. This allows
6471 sub-directories to be used. If you use prefix=, you should give it
6472 a string that starts just below the CVSROOT and ends with a slash.
6473 This prefix will be stripped from all filenames, and filenames
6474 which do not start with it will be ignored.
6476 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6478 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6479 and --exclude (inverse of --include). SVN post-commit hooks
6480 now have total control over which changes get sent to buildbot and which
6483 2004-07-10 Brian Warner <warner@lothar.com>
6485 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6486 test case to match new API
6488 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6489 which crashed HTML display when self.entries=[] (needed to
6490 distinguish between [], which means "no entries yet", and None,
6491 which means "the entries have been swapped out to disk, go fetch
6494 2004-07-04 Brian Warner <warner@lothar.com>
6496 * buildbot/process/step_twisted.py (countFailedTests): Count
6497 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6498 10kb from the end because any import errors are wedged there and
6499 they would make us think the test log was unparseable.
6500 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6502 2004-06-26 Brian Warner <warner@lothar.com>
6504 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6505 delete-*.pyc command into an actual BuildStep, so we can label it
6507 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6508 (FullTwistedBuildFactory): same
6510 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6512 * contrib/fakechange.py: Add an errback when sending the fake
6513 change, so we know it didn't work.
6515 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6517 * buildbot/process/step_twisted.py: Delete *.pyc files before
6518 calling trial, so it doesn't catch any old .pyc files whose .py
6519 files have been moved or deleted.
6521 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6522 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6523 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6524 instead of ["twisted.test"], so that the end result is "trial -R
6527 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6528 regular expression to match filenames that should be ignored when
6529 changed. Also add a --revision parameter that specifies the
6530 revision to examine, which is useful for debugging.
6532 2004-06-25 Brian Warner <warner@lothar.com>
6534 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6535 summary of warnings (like DeprecationWarnings), next to the
6538 2004-05-13 Brian Warner <warner@lothar.com>
6540 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6541 we now have a w32 build slave courtesy of Mike Taylor.
6543 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6544 so broken. Fixed a race condition that tripped up interlocked
6545 builds and caused the status to be stuck at "Interlocked" forever.
6546 The twisted buildbot's one interlocked build just so happened to
6547 never hit this case until recently (the feeding builds both pass
6548 before the interlocked build is attempted.. usually it has to wait
6550 (Builder._pong_failed): fix method signature
6552 * setup.py: bump to 0.4.3+ while between releases
6554 2004-04-30 Brian Warner <warner@lothar.com>
6556 * setup.py (version): Releasing buildbot-0.4.3
6558 2004-04-30 Brian Warner <warner@lothar.com>
6560 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6562 * README: update for 0.4.3 release
6564 * NEWS: update for 0.4.3 release
6566 * buildbot/master.py (BuildMaster.__getstate__): make sure
6567 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6569 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6570 .trial as a class attribute, for upgrade from 0.4.2
6572 * buildbot/changes/changes.py (Change.links): add .links for
6575 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6576 .textWatchers and .htmlWatchers at save time, since they are both
6577 volatile, should allow smooth 0.4.2 upgrade
6579 * buildbot/process/step.py (CVS.finishStatus): catch failed
6580 CVS/SVN commands so we can make the status box red
6582 2004-04-29 Brian Warner <warner@lothar.com>
6584 * buildbot/changes/freshcvs.py
6585 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6586 code to do setFilter(), which tells the freshcvs daemon to not
6587 send us stuff that we're not interested in. I will uncomment it
6588 when a new version of CVSToys is available in which setFilter()
6589 actually works, and I get a chance to test it better.
6591 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6593 * buildbot/master.py (Dispatcher): use a registration scheme
6594 instead of hardwired service names
6595 (BuildMaster): keep track of the Dispatcher to support
6598 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6599 PBChangeSource class instead of having it be an undocumented
6600 internal feature of the ChangeMaster. Split out the code into a
6602 * buildbot/changes/pb.py (PBChangeSource): same
6603 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6605 * docs/{factories|sources|steps}.xhtml: document some pieces
6607 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6608 using FCMaildirSource
6609 (f23osx): update OS-X builder to use python2.3, since the slave
6610 was updated to Panther (10.3.3)
6612 2004-03-21 Brian Warner <warner@lothar.com>
6614 * buildbot/process/process_twisted.py: factor out doCheckout, change
6615 to use SVN instead of CVS
6617 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6618 an SVN subclass easier
6619 (BasicSVN): subclass which uses Subversion instead of CVS
6621 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6623 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6625 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6627 2004-02-25 Brian Warner <warner@lothar.com>
6629 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6630 is now either a list (which is passed to spawnProcess directly) or
6631 a string (which gets passed to /bin/sh -c). This removes the useSH
6632 flag and the ArgslistCommand class. Also send status header at the
6633 start and end of each command, instead of having the master-side
6635 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6636 -r'. Update to use list-based arguments.
6637 (SVNFetch): use list-based arguments, use ['dir'] argument to
6639 * buildbot/test/test_steps.py (Commands): match changes
6641 * buildbot/process/step.py (InternalShellCommand.words): handle
6643 (SVN): inherit from CVS, cleanup
6645 * buildbot/status/event.py (Logfile.content): render in HTML, with
6646 stderr in red and headers (like the name of the command we're
6647 about to run) in blue. Add link to a second URL (url + "?text=1")
6648 to get just stdout/stderr in text/plain without markup. There is
6649 still a problem with .entries=None causing a crash, it seems to occur
6650 when the logfile is read before it is finished.
6652 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6653 timeout to the keepalives, and use it to explicitly do a
6654 loseConnection instead of waiting for TCP to notice the loss. This
6655 ought to clear up the silent-lossage problem.
6656 (unsafeTracebacks): pass exception tracebacks back to the master,
6657 makes it much easier to debug problems
6659 2004-02-23 Brian Warner <warner@lothar.com>
6661 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6662 the whole command to /bin/sh instead of execve [Johan Dahlin]
6663 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6664 '-r HEAD' [Johan Dahlin]
6665 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6667 * buildbot/changes/changes.py (Change): add links= argument, add
6668 asHTML method [Johan Dahlin]. Modified to make a bit more
6669 XHTMLish. Still not sure how to best use links= .
6671 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6672 Change.asHTML to display the change, not asText
6674 * buildbot/status/html.py (StatusResourceBuilder): web button to
6677 * buildbot/test/test_run.py: test to actually start a buildmaster
6680 * MANIFEST.in: bring back accidentally-dropped test helper files
6682 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6683 that require cvstoys if it is not installed
6685 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6686 values of "bin/trial" [Dave Peticolas]
6687 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6688 tests passed" when we didn't happen to run any tests
6690 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6691 flunkOnFailure [Johan Dahlin]
6693 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6694 multiple instances of the same Step class by suffixing "_2", etc,
6695 to the name until it is unique. This name needs to be unique
6696 because it is used as a key in the dictionary that tracks build
6698 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6701 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6703 2004-01-14 Brian Warner <warner@lothar.com>
6705 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6706 kicked from a channel, log it
6708 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6709 something over whatever IRC channels the buildmaster is currently
6710 connected to. Added to try and track down a problem in which the
6711 master thinks it is still connected but the IRCd doesn't see it. I
6712 used a styles.Versioned this time, so hopefully users won't have
6713 to rebuild their .tap files this time.
6714 * contrib/debug.glade: add a "Poke IRC" button
6715 * contrib/debugclient.py: same
6717 * setup.py: bump to 0.4.2+ while between releases
6719 2004-01-08 Brian Warner <warner@lothar.com>
6721 * setup.py (version): Releasing buildbot-0.4.2
6723 2004-01-08 Brian Warner <warner@lothar.com>
6725 * NEWS: update for 0.4.2 release
6727 * README: document how to run the tests, now that they all pass
6729 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6731 * buildbot/process/step.py (CVS): add a global_options= argument,
6732 which lets you set CVS global options for the command like "-r"
6733 for read-only checkout, or "-R" to avoid writing in the
6735 * buildbot/slavecommand.py (CVSCommand): same
6737 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6738 testing easier (it is turned off when testing, to avoid the
6741 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6742 to make it easier to test: break generateStepID() out to a
6743 separate function, only update statusbag if it exists.
6744 (ShellCommands): create useful text for dict-based commands too.
6746 * test/*, buildbot/test/*: move unit tests under the buildbot/
6748 * setup.py (packages): install buildbot.test too
6750 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6751 * buildbot/test/test_steps.py: fix it, tests pass now
6753 2004-01-06 Brian Warner <warner@lothar.com>
6755 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6756 freshcvs mail uses a slightly different syntax for new
6757 directories. Update parser to handle either.
6758 * test/test_mailparse.py (Test1.testMsg9): test for same
6760 2003-12-21 Brian Warner <warner@lothar.com>
6762 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6763 'warnOnWarnings' so that lintian errors mark the build orange
6765 2003-12-17 Brian Warner <warner@lothar.com>
6767 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6768 messages emitted by Bonsai, contributed by Stephen Davis.
6770 * test/*: moved all tests to use trial instead of unittest. Some
6771 still fail (test_steps, test_slavecommand, and test_process).
6773 * setup.py (version): bump to 0.4.1+ while between releases
6775 2003-12-09 Brian Warner <warner@lothar.com>
6777 * setup.py (version): Releasing buildbot-0.4.1
6779 2003-12-09 Brian Warner <warner@lothar.com>
6781 * NEWS: update for 0.4.1 release
6783 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6784 freebsd builder code a little bit
6786 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6787 don't try to compare attributes of different classes
6788 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6789 (MaildirSource.messageReceived): fix Change delivery
6791 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6792 into the config file's namespace before loading it, like the
6793 documentation claims it does
6794 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6795 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6796 daemon comes back online
6798 2003-12-08 Brian Warner <warner@lothar.com>
6800 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6801 so the example will work with online=0 as well
6803 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6804 fix the __implements__ line
6806 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6807 class a twisted.application.service.Service, use startService to
6810 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6811 directory fd instead of simple open(). I'm sure this used to work,
6812 but the current version of python refuses to open directories with
6815 2003-12-05 Brian Warner <warner@lothar.com>
6817 * setup.py (version): bump to 0.4.0+ while between releases
6819 2003-12-05 Brian Warner <warner@lothar.com>
6821 * setup.py (version): Releasing buildbot-0.4.0
6823 2003-12-05 Brian Warner <warner@lothar.com>
6825 * docs/examples/glib_master.cfg: replace old sample scripts with
6826 new-style config files
6827 * MANIFEST.in: include .cfg files in distribution tarball
6829 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6830 implement a dummy method to avoid the exception that occurs when
6831 freshcvs sends this to us.
6833 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6834 removed the method, as it broke reconnection. Apparently
6835 stopFactory is called each time the connection attempt fails. Must
6837 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6838 attribute before serialization, since without stopFactory the
6839 reconnect timer may still be active and they aren't serializable.
6841 * test/test_mailparse.py (ParseTest): test with 'self' argument
6843 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6844 argument, as these "functions" are invoked like methods from class
6845 attributes and therefore always get an instance as the first
6848 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6849 message: thanks to Stephen Davis for the catch
6851 2003-12-04 Brian Warner <warner@lothar.com>
6853 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6854 twisted's standard ReconnectingClientFactory. Handles both oldcred
6855 and newcred connections. Also has a bug-workaround for
6856 ReconnectingClientFactory serializing its connector when it
6859 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6860 pbutil. Replace makeApp stuff with proper newcred/mktap
6861 makeService(). Don't serialize Ephemerals on shutdown.
6863 * buildbot/changes/changes.py (ChangeMaster): make it a
6864 MultiService and add the sources as children, to get startService
6865 and stopService for free. This also gets rid of the .running flag.
6867 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6868 new pbutil, turn into a TCPClient at the same time (to get
6869 startService for free). Two variants exist: FreshCVSSourceOldcred
6870 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6871 yet, but when it does, we'll be ready).
6872 (FreshCVSSource.notify): handle paths which are empty after the
6873 prefix is stripped. This only happens when the top-level (prefix)
6874 directory is added, at the very beginning of a Repository's life.
6876 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6877 Now the only reconnecting code is in the factory where it belongs.
6878 (Builder.unsubscribe): unregister the disconnect callback when we
6879 delete the builder on command from the master (i.e. when the
6880 buildmaster is reconfigured and that builder goes away). This
6881 fixes a multiple-delete exception when the status client is shut
6883 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6886 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6887 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6889 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6891 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6892 a list of globs (ugh). The testdir will be searched for files
6893 named *.tests and run the tests in the order specified in each of
6894 those files. This allows for "dependancies" between tests to be
6897 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6898 argument to pass to run_maxq.py, instead of a glob.
6900 2003-10-17 Brian Warner <warner@lothar.com>
6902 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6903 files that live in the sandbox
6905 2003-10-15 Brian Warner <warner@lothar.com>
6907 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6908 spelling error in "docs" count-warnings output
6909 (HLint.start): stupid thinko meant .xhtml files were ignored
6911 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6912 tests now that cReactor is banished to the sandbox
6914 2003-10-10 Brian Warner <warner@lothar.com>
6916 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6917 scheme: now .xhtml are sources and .html are generated
6919 2003-10-08 Brian Warner <warner@lothar.com>
6921 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6922 we were ignoring the 'randomly' parameter.
6924 2003-10-01 Brian Warner <warner@lothar.com>
6926 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6927 posix, to kill sub-children of aborted slavecommands.
6929 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6930 Clean up initialization: lastBuildStatus remains None until the
6931 first build has been completed.
6933 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6934 None as a lastBuildStatus
6935 * buildbot/clients/gtkPanes.py: same
6937 * buildbot/status/client.py (StatusClientService): keep
6938 BuilderStatus objects in self.statusbags . These objects now live
6939 here in the StatusClientService and are referenced by the Builder
6940 object, rather than the other way around.
6941 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6942 * buildbot/process/base.py (Builder): same
6943 * test/test_config.py (ConfigTest.testBuilders): same
6945 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6946 an existing builder, leave the statusbag alone. This will preserve the
6949 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6950 hook. This will probably go away in favor of a class in upcoming
6953 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6954 serviceName from newcred FreshCVSNotifiee setup
6956 2003-09-29 Brian Warner <warner@lothar.com>
6958 * buildbot/process/process_twisted.py: switch to new reactor
6960 * docs/examples/twisted_master.cfg: same
6962 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6964 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6965 botmaster reference instead of the oldapp service lookup
6967 * buildbot/master.py (BuildMaster.__init__): give the
6968 StatusClientService a reference to the botmaster to make it easier to
6971 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6973 * buildbot/status/html.py (Box.td): escape hreffy things so you
6974 can have spaces in things like builder names
6975 (StatusResourceBuilder.body)
6976 (WaterfallStatusResource.body)
6977 (WaterfallStatusResource.body0): same
6979 2003-09-25 Brian Warner <warner@lothar.com>
6981 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6982 rearrange the builder list when adding or removing builders: keep
6983 them in the order the user requested.
6984 * test/test_config.py (ConfigTest.testBuilders): verify it
6986 * contrib/debug.glade: give the debug window a name
6988 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6989 now wait on multiple interlocks. Fix code relating to that.
6990 (Builder.checkInterlocks): same
6991 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6993 * buildbot/master.py (BuildMaster.loadConfig): move from
6994 deprecated pb.BrokerFactory to new pb.PBServerFactory
6995 * test/test_config.py (ConfigTest.testWebPathname): same
6997 * docs/examples/twisted_master.cfg: fix interlock declaration
6999 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7000 Interlocks to their Builders into interlock.py .
7001 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7003 * test/test_config.py (ConfigTest.testInterlocks): validate
7006 * buildbot/process/base.py (Builder.__init__): better comments
7007 * buildbot/process/interlock.py (Interlock.__repr__): same
7008 (Interlock.deactivate): add .active flag, move the code that
7009 attaches/detaches builders into the Interlock
7011 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7013 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7014 tests using the new run_maxq.py script, and reporting failures by
7017 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7018 tests, reporting their success or failure in a buildbot-friendly
7021 2003-09-24 Brian Warner <warner@lothar.com>
7023 * docs/examples/twisted_master.cfg: example of a new-style config
7024 file. This lives in the buildmaster base directory as
7027 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7028 button to make the master re-read its config file
7030 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7031 buildmaster configuration from a file. This file can be re-read
7032 later, and the buildmaster will update itself to match the new
7033 desired configuration. Also use new Twisted Application class.
7034 * test/Makefile, test/test_config.py: unit tests for same
7036 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7037 FreshCVSSources comparable, to support reload.
7038 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7040 * buildbot/process/base.py (Builder): make them comparable, make
7041 Interlocks easier to attach, to support reload. Handle
7042 re-attachment of remote slaves.
7043 * buildbot/process/interlock.py (Interlock): same
7045 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7046 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7047 buildmaster taps are now constructed with mktap.
7048 * buildbot/status/client.py (StatusClientService): same
7050 * buildbot/status/words.py: move to new Services, add support to
7051 connect to multiple networks, add reload support, allow nickname
7052 to be configured on a per-network basis
7054 2003-09-20 Brian Warner <warner@lothar.com>
7056 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7057 the freebsd builder, now that the machine has been upgraded and no
7058 longer has python2.2
7060 * setup.py (version): bump to 0.3.5+ while between releases
7062 2003-09-19 Brian Warner <warner@lothar.com>
7064 * setup.py (version): Releasing buildbot-0.3.5
7066 2003-09-19 Brian Warner <warner@lothar.com>
7068 * NEWS: add post-0.3.4 notes
7070 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7072 * MANIFEST.in: add contrib/*
7074 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7075 use a remote root now: cvs.twistedmatrix.com
7077 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7079 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7080 compatibility with old servers
7081 (FreshCVSSource.start): and provide a way to use it
7082 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7084 * docs/examples/twisted_master.py (twisted_app): update to new
7086 (twisted_app): listen on new ~buildbot socket
7087 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7089 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7090 to reduce cvs bandwidth (update instead of full checkout)
7092 2003-09-11 Brian Warner <warner@lothar.com>
7094 * contrib/fakechange.py: demo how to connect to the changemaster
7095 port. You can use this technique to submit changes to the
7096 buildmaster from source control systems that offer a hook to run a
7097 script when changes are committed.
7099 * contrib/debugclient.py: tool to connect to the debug port. You
7100 can use it to force builds, submit fake changes, and wiggle the
7103 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7104 'Dispatcher' realm to handle all the different kinds of
7105 connections and Perspectives: buildslaves, the changemaster port,
7106 the debug port, and the status client port. NewCredPerspectives
7107 now have .attached/.detached methods called with the remote 'mind'
7108 reference, much like old perspectives did. All the pb.Services
7109 turned into ordinary app.ApplicationServices .
7110 (DebugService): went away, DebugPerspectives are now created
7111 directly by the Dispatcher.
7112 (makeApp): changed interface a little bit
7114 * buildbot/changes/changes.py: newcred
7115 * buildbot/status/client.py: newcred
7117 * buildbot/clients/base.py: newcred client side changes
7118 * buildbot/bot.py: ditto
7120 * docs/examples/glib_master.py: handle new makeApp() interface
7121 * docs/examples/twisted_master.py: ditto
7123 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7124 base newcred Perspectives on. This should go away once Twisted
7125 itself provides something sensible.
7128 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7130 * contrib/svn_buildbot.py: A program that you can call from your
7131 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7132 when a change in an SVN repository has happened. See the top of
7133 the file for some minimal usage info.
7135 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7137 * buildbot/slavecommand.py (ArglistCommand): Add new
7138 ArglistCommand that takes an argument list rather than a string as
7139 a parameter. Using a st.split() for argv is very bad.
7141 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7142 update to a particular revision rather than always checking out
7143 (still not very smart about it, there may be cases where the
7144 checkout becomes inconsistent).
7146 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7148 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7149 SVN fetch support. It can checkout (not update!) a specified
7150 revision from a specified repository to a specified directory.
7152 * buildbot/status/progress.py (Expectations.update): Fix an
7153 obvious bug (apparently created by the change described in the
7154 previous ChangeLog message) by moving a check to *after* the
7155 variable it checks is defined.
7158 2003-09-08 Brian Warner <warner@lothar.com>
7160 * buildbot/status/progress.py (Expectations.update): hack to catch
7161 an exception TTimo sees: sometimes the update() method seems to
7162 get called before the step has actually finished, so the .stopTime
7163 is not set, so no totalTime() is available and we average None
7164 with the previous value. Catch this and just don't update the
7165 metrics, and emit a log message.
7167 2003-08-24 Brian Warner <warner@lothar.com>
7169 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7170 parameter to set copydir='original' in CVS commands.
7172 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7174 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7175 which tells the command to maintain a separate original-source CVS
7176 workspace. For each build, this workspace will be updated, then
7177 the tree copied into a new workdir. This reduces CVS bandwidth
7178 (from a full checkout to a mere update) while doubling the local
7179 disk usage (to keep two copies of the tree).
7181 2003-08-21 Brian Warner <warner@lothar.com>
7183 * buildbot/status/event.py (Logfile.addEntry): if the master web
7184 server dies while we're serving a page, request.write raises
7185 pb.DeadReferenceError . Catch this and treat it like a
7186 notifyFinish event by dropping the request.
7188 2003-08-18 Brian Warner <warner@lothar.com>
7190 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7191 (instead of blowing up) if a force-build command is given without
7194 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7195 don't blow up if there aren't yet any Changes in the list
7197 2003-08-02 Brian Warner <warner@lothar.com>
7199 * buildbot/bot.py (updateApplication): don't set the .tap name,
7200 since we shouldn't assume we own the whole .tap file
7202 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7203 'mktap buildbot' (without a subcommand) better
7205 2003-07-29 Brian Warner <warner@lothar.com>
7207 * buildbot/status/words.py
7208 (IrcStatusFactory.clientConnectionLost): when we lose the
7209 connection to the IRC server, schedule a reconnection attempt.
7211 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7212 use shutil.rmtree instead of forking off an "rm -rf" command.
7213 rmtree may take a while and will block until it finishes, so we
7214 use "rm -rf" if available.
7216 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7217 freebsd buildslave badly
7219 * setup.py (version): bump to 0.3.4+ while between releases
7221 2003-07-28 Brian Warner <warner@lothar.com>
7223 * setup.py (version): Releasing buildbot-0.3.4
7225 2003-07-28 Brian Warner <warner@lothar.com>
7227 * NEWS: update in preparation for release
7229 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7230 process.signalProcess instead of os.kill, to improve w32
7233 * docs/examples/twisted_master.py (twisted_app): turn off
7234 win32eventreactor: the tests hang the buildslave badly
7236 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7237 failed builds, since usually the failures are consistent
7239 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7240 add compileOpts/compileOpts2 to reactors build
7242 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7243 (twisted_app): use both default and win32eventreactor on w32 build.
7244 Use both default and kqreactor on freebsd build.
7246 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7247 add compileOpts2, which is put after the build_ext argument. w32
7248 needs "-c mingw32" here.
7250 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7251 touch .acqpath, it goes away in recent Twisted releases
7253 * docs/examples/twisted_master.py (twisted_app): use "python" for
7254 the w32 buildslave, not "python2.2"
7256 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7257 the directory exists.. should hush an exception under w32
7259 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7260 ProcessTerminated -provided values for signal and exitCode rather
7261 than parsing the unix status code directly. This should remove one
7262 more roadblock for a w32-hosted buildslave.
7264 * test/test_mailparse.py: add test cases for Syncmail parser
7266 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7267 temporary compatibility import. Note! Start importing
7268 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7270 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7272 2003-07-27 Brian Warner <warner@lothar.com>
7274 * NEWS: started adding new features
7276 * buildbot/changes/mail.py: start work on Syncmail parser, move
7277 mail sources into their own file
7279 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7280 as implementing IChangeSource
7281 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7283 * buildbot/interfaces.py: define the IChangeSource interface
7285 2003-07-26 Brian Warner <warner@lothar.com>
7287 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7289 2003-06-25 Brian Warner <warner@lothar.com>
7291 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7294 2003-06-17 Brian Warner <warner@lothar.com>
7296 * buildbot/status/words.py: clean up method usage to avoid error
7297 in silly IRC command
7298 (IrcStatusBot.emit_status): round off seconds display
7300 * buildbot/process/base.py (Build): delete the timer when saving
7301 to the .tap file, and restore it (if it should still be running)
7302 upon restore. This should fix the "next build in -34 seconds"
7303 messages that result when the master is restarted while builds are
7304 sitting in the .waiting slot. If the time for the build has
7305 already passed, start it very soon (in 1 second).
7307 * buildbot/status/words.py: more silly commands
7309 * README (REQUIREMENTS): add URLs to all required software
7311 * buildbot/status/words.py ('last'): mention results of, and time
7314 2003-05-28 Brian Warner <warner@lothar.com>
7316 * buildbot/status/words.py: add 'last' command
7317 (IrcStatusBot.emit_status): add current-small text to 'status' output
7319 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7320 (twisted_app): remove spaces from OS-X builder name
7322 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7323 * buildbot/status/words.py: IRC bot should actually be useful now
7325 2003-05-23 Brian Warner <warner@lothar.com>
7327 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7328 "slave information" from $(slavedir)/info/* . These files are
7329 maintained by the slave administrator, and describe the
7330 machine/environment that is hosting the slave. Information from
7331 them is put into the "Builder" HTML page. Still need to establish
7332 a set of well-known filenames and meanings for this data: at the
7333 moment, *all* info/* files are sent to the master, but only
7334 'admin' and 'host' are used on that end.
7335 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7336 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7337 * buildbot/master.py (BotPerspective.got_info): ditto
7339 2003-05-22 Brian Warner <warner@lothar.com>
7341 * setup.py (version): bump version to 0.3.3+ while between releases
7343 2003-05-21 Brian Warner <warner@lothar.com>
7345 * setup.py: Releasing buildbot-0.3.3
7347 2003-05-21 Brian Warner <warner@lothar.com>
7349 * NEWS: 0.3.3 news items
7351 * README: describe --keepalive and life behind a NAT box
7353 * buildbot/bot.py (Bot.connected): implement application-level
7354 keepalives to deal with NAT timeouts, turn them on with
7355 --keepalive option or when SO_KEEPALIVE doesn't work.
7357 * buildbot/master.py (BotPerspective): accept keepalives silently
7359 * buildbot/process/base.py (Build.buildException): CopiedFailures
7360 don't carry as much information as local ones, so don't try to
7361 create a big HTMLized version of them.
7363 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7364 log file when step fails due to an exception, such as when the slave
7367 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7368 --testmodule argument instead of grepping for test-case-name tags
7369 ourselves. Remove FindUnitTests code.
7370 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7372 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7374 2003-05-16 Brian Warner <warner@lothar.com>
7376 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7377 argument to allow things like CFLAGS=-O0 to be passed without relying
7378 upon /bin/sh processing on the slave.
7380 * buildbot/process/step.py (InternalShellCommand.start): send
7382 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7383 'split' instead of letting /bin/sh do it. This should also remove
7384 the need for /bin/sh on the buildslave, making it more likely to
7387 * buildbot/status/html.py: html-escape text in blamelist.
7388 Add "force build" button to the Builder page.
7390 * buildbot/process/step_twisted.py (countFailedTests): look at
7391 last 1000 characters for status line, as import errors can put it
7392 before the -200 point.
7394 2003-05-15 Brian Warner <warner@lothar.com>
7396 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7398 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7399 make 'clobber' a parameter, so it is possible to have builds which
7400 do full tests but do a cvs update instead of hammering the CVS
7401 server with a full checkout each build
7403 * buildbot/process/step.py (InternalShellCommand): bump default
7404 timeout to 20 minutes
7406 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7407 the master to trigger a build. Run it via manhole.
7409 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7410 allow slaves to trigger any build that they host, to make life
7411 easier for slave admins who are testing out new build processes
7413 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7414 don't flunk cReactor or qtreactor on failure, since they fail alot
7415 these days. Do warnOnFailure instead.
7417 * buildbot/process/base.py: change Builder.buildable from a list
7418 into a single slot. When we don't have a slave, new builds (once
7419 they make it past the timeout) are now merged into an existing
7420 buildable one instead of being queued. With this change, a slave
7421 which has been away for a while doesn't get pounded with all the
7422 builds it missed, but instead just does a single build.
7424 2003-05-07 Brian Warner <warner@lothar.com>
7426 * setup.py (version): bump version to 0.3.2+ while between releases
7428 2003-05-07 Brian Warner <warner@lothar.com>
7430 * setup.py: Releasing buildbot-0.3.2
7432 2003-05-07 Brian Warner <warner@lothar.com>
7434 * setup.py: fix major packaging error: include subdirectories!
7436 * NEWS: add changes since last release
7438 * README (REQUIREMENTS): update twisted/python dependencies
7440 * buildbot/status/builder.py (Builder.startBuild): change
7441 BuildProcess API: now they should call startBuild/finishBuild
7442 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7443 keeping a list of builds in the statusbag, to support other kinds of
7445 (Builder.addClient): send current-activity-small to new clients
7446 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7449 * buildbot/status/client.py: drop RemoteReferences at shutdown
7451 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7453 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7454 more debug messages for remote status client
7456 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7457 (.stepFailed): only fire the Deferred once, even if both
7458 stepComplete and stepFailed are called. I think this can happen if
7459 an exception occurs at a weird time.
7461 * buildbot/status/words.py: work-in-progress: IRC status delivery
7463 2003-05-05 Brian Warner <warner@lothar.com>
7465 * docs/examples/twisted_master.py (twisted_app): hush internal
7466 python2.3 distutils deprecation warnings
7467 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7468 add compileOpts= argument which inserts extra args before the
7469 "setup.py build_ext" command. This can be used to give -Wignore
7470 warnings, to hush some internal python-2.3 deprecation messages.
7472 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7473 the ['twisted.test'] default test case to make it easier to change
7476 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7477 * buildbot/clients/gtkPanes.py: ditto
7479 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7480 arg to collapse RunUnitTestsRandomly into RunUnitTests
7481 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7482 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7484 * buildbot/status/html.py (StatusResource): shuffle Resources
7485 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7486 would serve the waterfall display, but the internal links were
7487 only valid on the trailing-slash version. The correct behavior is
7488 for the non-slashed one to serve a Redirect to the slashed one.
7489 This only shows up when the buildbot page is hanging off another
7490 server, like a Twisted-Web distributed server.
7492 * buildbot/status/event.py (Event, RemoteEvent): make Events
7493 pb.Cacheable, with RemoteEvent as the cached version. This removes
7494 a lot of explicit send-an-update code.
7495 * buildbot/status/builder.py (Builder): remove send-update code
7496 * buildbot/status/client.py (ClientBuilder): remove send-update
7497 code, and log errors that occur during callRemote (mostly to catch
7498 InsecureJelly exceptions)
7500 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7501 run Lore with the same python used in the rest of the build
7503 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7505 * buildbot/process/step_twisted.py (HLint): accept 'python'
7506 argument. Catch rc!=0 and mark the step as failed. This marks the
7507 build orange ("has warnings").
7508 (RunUnitTestsJelly): move out to step_twisted2.py
7510 * buildbot/util.py (ignoreStaleRefs): add utility function
7512 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7513 don't fake ETA object, it's too hard to get right
7515 2003-05-02 Brian Warner <warner@lothar.com>
7517 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7519 2003-05-01 Brian Warner <warner@lothar.com>
7521 * buildbot/status/html.py (StatusResource.body): oops, I was
7522 missing a <tr>, causing the waterfall page to be misrendered in
7523 everything except Galeon.
7525 2003-04-29 Brian Warner <warner@lothar.com>
7527 * docs/examples/twisted_master.py: make debuild use python-2.2
7528 explicitly, now that Twisted stopped supporting 2.1
7530 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7531 handle tuple results too. I keep forgetting this, which suggests
7532 it needs to be rethought.
7534 * setup.py (setup): bump version to 0.3.1+ while between releases
7536 2003-04-29 Brian Warner <warner@lothar.com>
7538 * setup.py: Releasing buildbot-0.3.1
7540 2003-04-29 Brian Warner <warner@lothar.com>
7542 * README (SUPPORT): add plea to send questions to the mailing list
7544 * NEWS, MANIFEST.in: add description of recent changes
7546 * docs/examples/twisted_master.py: add the code used to create the
7547 Twisted buildmaster, with passwords and such removed out to a
7550 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7551 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7552 buildmasters to not require CVSToys be installed.
7553 * README, docs/examples/glib_master: update to match the change
7555 * buildbot/clients/base.py, buildbot/bot.py,
7556 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7557 ReconnectingPB from CVSToys distribution to remove CVSToys
7558 dependency for build slaves and status clients. Buildmasters which
7559 use FreshCVSSources still require cvstoys be installed, of course.
7561 2003-04-25 Brian Warner <warner@lothar.com>
7563 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7564 runTestsRandomly arg to turn on trial -z
7566 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7567 experimental code to use trial's machine-parseable output to get
7568 more detailed test results. Still has some major issues.
7569 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7572 * buildbot/status/builder.py (Builder.setCurrentBuild):
7573 anticipating moving build history into statusbag, not used yet
7575 * buildbot/status/tests.py: code to centralize test results,
7576 doesn't work quite yet
7578 * buildbot/status/event.py (Event): use hasattr("setName") instead
7579 of isinstance for now.. need better long-term solution
7581 * buildbot/status/html.py: Remove old imports
7583 2003-04-24 Brian Warner <warner@lothar.com>
7585 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7586 ignore changes under doc/fun/ and sandbox/
7588 * buildbot/process/step_twisted.py: update pushEvent and friends.
7590 * buildbot/status/html.py (Box.td): replace event.buildername with
7591 event.parent.getSwappableName(). Needs more thought.
7593 * buildbot/status/builder.py (Builder): Replace pushEvent and
7594 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7595 Tell events they are being pruned with event.delete().
7597 * buildbot/process/base.py (Build): Remove Builder status-handling
7598 methods. s/pushEvent/setCurrentActivity/.
7600 * buildbot/process/step.py (BuildStep): clean up status delivery.
7601 Gouse builder.statusbag methods instead of intermediate builder
7602 methods. s/updateLastEvent/updateCurrentActivity/.
7603 s/finalizeLastEvent/finishCurrentActivity/. Use
7604 addFileToCurrentActivity for summaryFunction.
7606 * buildbot/status/event.py (Logfile): put data in a Swappable when
7608 (Event): add more setter methods. Remove .buildername, use .parent
7609 and getSwappableName instead (needs more thought).
7611 * buildbot/util.py (Swappable):
7612 * test/test_swap.py: don't bother setting filename at __init__
7613 time, do it later. Change setFilename args to take parent first,
7614 since it provides the most significant part of the filename.
7616 2003-04-23 Brian Warner <warner@lothar.com>
7618 * buildbot/status/event.py (Logfile.addEntry): append to previous
7621 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7622 anticipating Swappable
7623 (InternalShellCommand.remoteUpdate): split out various log-adding
7624 methods so subclasses can snarf stdout separately
7626 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7627 in anticipation of Swappable build logs
7628 (Builder.testsFinished): anticipating TestResults, still disabled
7630 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7633 * buildbot/status/event.py (Logfile): add (disabled) support for
7634 Swappable, not ready for use yet
7636 * buildbot/util.py (Swappable): object which is swapped out to
7637 disk after some period of no use.
7638 * test/test_swap.py: test buildbot.utils.Swappable
7640 2003-04-14 Brian Warner <warner@lothar.com>
7642 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7643 periodic-build timer. Set the .periodicBuildTime on a builder
7644 instance to some number of seconds to activate it.
7646 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7648 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7649 a way that survives result tuples
7651 2003-04-12 Brian Warner <warner@lothar.com>
7653 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7654 return a dict instead of a tuple: allow summarizers to provide
7655 multiple summaries if they want
7656 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7657 (debuildSummarizer): summarize lintian warnings/errors
7659 2003-04-10 Brian Warner <warner@lothar.com>
7661 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7663 2003-04-09 Brian Warner <warner@lothar.com>
7665 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7666 empty summaries: happens when the tests fail so hard they don't emit
7667 a parseable summary line.
7669 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7670 Allow summaryFunction to return None to indicate no summary should
7673 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7674 writing to stale HTTP requests: notice when they disconnect and
7675 remove the request from the list. Also add CacheToFile from
7676 moshez, will be used later.
7678 2003-04-08 Brian Warner <warner@lothar.com>
7680 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7681 should be an int, not a list of strings
7683 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7684 if we weren't actually connected
7686 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7687 to show the tail end of the trial text output
7689 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7690 hook to summarize the results of a ShellCommand
7692 2003-04-07 Brian Warner <warner@lothar.com>
7694 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7695 twisted test suite code into a single class.
7696 * buildbot/process/process_twisted.py: same
7698 2003-04-04 Brian Warner <warner@lothar.com>
7700 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7702 * README (SLAVE): document use of mktap to create slave .tap file
7703 (REQUIREMENTS): describe dependencies
7705 * buildbot/bb_tap.py, buildbot/plugins.tml:
7706 * buildbot/bot.py (updateApplication): Add mktap support for creating
7707 buildslave .tap files
7709 2003-03-28 Brian Warner <warner@lothar.com>
7711 * buildbot/process/step.py (InternalShellCommand.finished): handle
7712 new tuple result values (fix embarrasing bug that appeared during
7715 2003-03-27 Brian Warner <warner@lothar.com>
7717 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7720 2003-03-25 Brian Warner <warner@lothar.com>
7722 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7723 to overall build status
7724 * buildbot/clients/base.py (Builder): improve event printing
7725 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7726 instead of generic ShellCommand
7727 (Build): Add .stopBuild, use it when slave is detached
7729 * buildbot/process/step.py (Configure,Test): give the steps their
7730 own names and status strings
7732 * buildbot/status/html.py (StatusResource): add "show" argument,
7733 lets you limit the set of Builders being displayed.
7735 2003-03-20 Brian Warner <warner@lothar.com>
7737 * buildbot/process/basic.py: removed
7739 2003-03-19 Brian Warner <warner@lothar.com>
7741 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7742 turn off process-docs by default
7744 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7745 when displaying build information without anything in allBuilds[]
7747 * buildbot/bot.py (makeApp): really take password from sys.argv
7749 2003-03-18 Brian Warner <warner@lothar.com>
7751 * buildbot/bot.py (buildApp): take password from sys.argv
7753 * README: replace with more useful text
7755 * setup.py: add a real one
7756 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7758 * docs/PyCon-2003/: added sources for PyCon paper.
7760 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7761 now Build objects control the process and Builder only handles
7762 slave stuff and distribution of changes/status. A new BuildFactory
7763 class creates Build objects on demand.
7765 Created ConfigurableBuild which takes a list of steps to run. This
7766 makes it a lot easier to set up a new kind of build and moves us
7767 closer to being able to configure a build from a web page.
7769 * buildbot/process/step_twisted.py, process_twisted.py: move to
7770 new model. A lot of code went away.
7772 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7773 send lots of empty progress messages to the client.
7775 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7777 2003-02-20 Brian Warner <warner@lothar.com>
7779 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7781 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7782 Twisted bug that prevented non-pty processes from working just got
7783 fixed, and the bug that leaks ptys is still being investigated.
7785 * buildbot/process/step.py (CVS): send timeout arg to slave
7787 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7788 builders coming and going
7789 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7790 from CVSToys, handle lost-buildmaster
7792 * buildbot/status/client.py (StatusClientService.removeBuilder):
7793 Clean up status client protocol: send builders (with references)
7794 as they are created, rather than sending a list and requiring the
7795 client to figure out which ones are new.
7796 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7797 attempts to force a build on an unknown builder
7799 2003-02-19 Brian Warner <warner@lothar.com>
7801 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7802 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7803 Twisted stops leaking them.
7804 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7805 builder goes to an idle state.
7807 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7808 I figure out why CVS commands hang without them, and/or I fix the
7809 hung-command timeout
7811 2003-02-16 Brian Warner <warner@lothar.com>
7813 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7814 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7815 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7816 GenerateDocs now that they are prefixed with WARNING:.
7818 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7819 use manual href target instead of request.childLink
7821 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7822 display every second, but update the ETA every 5 seconds (or
7823 whenever) as remote_progress messages arrive.
7826 2003-02-12 Brian Warner <warner@lothar.com>
7828 * *: import current sources from home CVS repository
7832 # add-log-time-format: add-log-iso8601-time-string