1 2007-09-30 Brian Warner <warner@lothar.com>
3 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
4 * docs/buildbot.texinfo: same
6 2007-09-30 Brian Warner <warner@lothar.com>
8 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
9 * setup.py: install all test files from buildbot/test/mail/* . Also
10 update URL to point at buildbot.net
11 * MANIFEST.in: update with new files
13 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
14 auto-create an empty public_html directory, otherwise we get
15 internal server errors instead of 404s.
17 * README: reference buildbot.net, remove CVSToys section (does
20 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
21 message when public_html/ is missing (indicating that you should
22 probably run 'upgrade-master'), and don't auto-create an empty
23 directory in that case.
25 * contrib/darcs_buildbot.py: refactor internals a bit, make it
26 possible to use as an importable module (to make it easier to
27 write some unit tests for it)
29 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
30 DeprecationWarning for Waterfall, advising users to switch over to
33 * NEWS: update with user-visible changes since the last release
35 * buildbot/status/web/waterfall.py
36 (WaterfallStatusResource.get_reload_time): if the suggest a
37 reload time of less than 15 seconds, give them 15 seconds instead
38 of ignoring their request entirely, because that'd be confusing.
40 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
41 warning if we must invoke the last-change-is-most-recent guess
43 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
44 Waterfall is running in an upgraded master (which is the usual
45 case for folks who have followed the instructions to run
46 'upgrade-master' but who have not yet resolved all the
47 DeprecationWarnings), prefer the buildbot.css from public_html/
48 rather than the one passed in on the buildbot= argument.
49 Otherwise, the resulting pages don't quite use CSS right..
50 sometimes it works, sometimes it doesn't, and I don't know why.
51 Sites that are using custom CSS will see the default CSS until
52 they modify public_html/buildbot.css to include their
55 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
56 * buildbot/status/web/robots.txt (Disallow): update to cover all
57 dynamically-generated pages
59 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
60 include both 'trunk' and None in the output list, since some VC
61 systems (SVN, frequently) refer to trunk as 'trunk'.
63 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
64 point the 'welcome' link explicitly at index.html, rather than
65 '.', so that old Waterfall users can reach it and discover all the
68 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
69 build's text to the end of the line, without a CSS class so it
72 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
73 'max_search=' argument, to limit the number of builds that are
74 examined while trying to find ones that match the other criteria.
75 This helps to limit the work we do, since otherwise we might have
76 to trawl through all history.
77 (IBuilderStatus.generateFinishedBuilds): same
78 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
79 (BuilderStatus.generateFinishedBuilds): same
81 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
82 our got_revision before checking its length: SVN (at least) still
83 reports numeric values for this.
84 * buildbot/status/web/build.py (StatusResourceBuild.body): same
85 * buildbot/status/web/xmlrpc.py
86 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
87 serving a completely fake revision
89 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
90 basedir to sys.path, to mimic what a real buildmaster would have
91 access to, since it is common for master.cfg to import helper
92 classes from .py files in the buildmaster directory, and we want
93 config-file checking to accomodate this.
95 * buildbot/status/web/base.py (map_branches): when referring to
96 branches through WebStatus (i.e. by appending ?branch=FOO query
97 arguments to the URL), make "trunk" mean trunk, by mapping it to
98 None before passing it to generateFinishedBuilds() and the like.
99 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
100 (OneBoxPerBuilder.body): same, also improve display of branches in
102 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
103 (WaterfallStatusResource.buildGrid): same. Note that this filters
104 Changes as well as Builds.
105 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
106 caveat about trunk branches, now that it's fixed
108 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
109 from builder.py, use it on the Builder page too
111 * buildbot/status/web/builder.py (StatusResourceBuilder): same
112 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
113 names, add some CSS classes
114 * buildbot/status/web/classic.css (td.box): new class, for
117 * docs/buildbot.texinfo (WebStatus): update docs
119 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
120 the trailing "M" indicator that tells us this is a modified file.
121 This should help with mode="update" builds that modify files
122 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
125 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
126 new copies of files (to .new) when those files already exist,
127 check the master.cfg file for errors (and give DeprecationWarnings
128 a chance to be displayed).
129 * buildbot/test/test_runner.py: add more tests
130 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
132 2007-09-29 Brian Warner <warner@lothar.com>
134 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
135 the revision id from the last change in our list, since that's the
136 best we can do without knowing the full ancestry graph. Closes #103.
138 * buildbot/scripts/sample.cfg: use buildstep instances in
139 f.addStep, to demonstrate the (correct) modern usage.
140 * docs/examples/hello.cfg: bring this up to date. Closes #79.
141 * docs/examples/twisted_master.cfg: add a big warning about how
143 * docs/examples/glib_master.cfg: delete this one entirely, it is
144 ancient and not a very useful example anyways
146 * buildbot/status/web/base.py (HtmlResource.render): keep track of
147 HTTPChannels, so we can shut them down at reconfig time (when the
148 WebStatus goes away). Closes #102.
149 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
150 (WebStatus.registerChannel): same
151 (WebStatus.stopService): do .loseConnection() here
153 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
154 WebStatus, make sure all pages are still retrievable. I thought
155 this would exercise a bug, but it turns out that it was firefox
156 caching connections (and continuing to talk to the old WebStatus
157 even though I'd loaded a new one).
158 * buildbot/status/web/baseweb.py (WebStatus): add some comments
159 (WebStatus.__repr__): include id() in the repr
161 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
162 this to specify an errorparser. From Ted Mielczarek and the
163 mozilla crew. Closes #94.
165 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
166 bonsaipoller ignore funkyness in xml output for empy log
167 messages", from Axel Hecht. Closes #90.
168 * buildbot/test/test_bonsaipoller.py
169 (TestBonsaiPoller.testMergeEmptyLogMsg): same
171 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
172 respect 'builders' arg, from Ben Hearsum. Closes #89.
174 * buildbot/scripts/runner.py (stop): increase the timeout from 5
175 seconds to 10, to give heavily loaded machines a better chance to
176 finish shutting down. Addresses (partially) #68.
177 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
179 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
180 * buildbot/scripts/startup.py (Follower._failure): update message
182 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
183 team, to fix some bugs and avoid the use of blocking urlopen().
185 * buildbot/test/test_bonsaipoller.py: same
187 2007-09-28 Brian Warner <warner@lothar.com>
189 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
190 argument, to send email about buildslaves which are disconnected
191 for more than an hour. Closes #64.
192 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
194 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
195 (MailNotifier): add docs for this too
198 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
199 respect branch= queryargs, by restricting the builds displayed to
200 those matching the given branch names
201 * buildbot/status/web/waterfall.py (BuildTopBox): same
203 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
204 fix a test failure by adding .prepath to this fake object
206 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
207 up generation of relative URLs. With luck, this should play with
208 reverse proxies much better now.
209 * buildbot/test/test_webparts.py: new test for most of the subpages
210 * buildbot/test/test_web.py (base_config): add enough of a config
211 to exercise more Waterfall code
213 2007-09-27 Brian Warner <warner@lothar.com>
215 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
216 relative URL to the buildbot welcome page, rather than
218 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
220 * buildbot/status/web/base.py (HtmlResource.title): change the
221 default title of all Buildbot-generated page to "Buildbot"
222 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
223 change the title to include the Builder name
224 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
225 same, and also show the build number
226 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
227 redirect the browser to the Builder page
229 2007-09-26 Brian Warner <warner@lothar.com>
231 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
232 problem with the build links
234 2007-09-25 Brian Warner <warner@lothar.com>
236 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
237 to emit relative URLs instead of using URLPath,
239 * docs/buildbot.texinfo (WebStatus): provide an example
241 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
242 page, shows a simple table with one row per Builder. Still pretty
243 ugly, but functional.
244 * buildbot/status/web/index.html: reference it
246 * buildbot/status/web/waterfall.py (Spacer): make this *not*
247 inherit from builder.Event, so that show_events=false doesn't hide
248 spacers, since that would make the waterfall weirdly compressed.
250 * buildbot/status/web/waterfall.py (HELP): put the View button in
251 its own section, so it doesn't get visually confused with the
253 (WaterfallStatusResource.body): make the '[help]' links more
254 visually distinct from each other, and add a link to the Welcome
256 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
257 unused buildslaves without exploding
259 * buildbot/status/web/waterfall.py
260 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
261 it gives us absolute paths that break proxies
262 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
263 this, it was giving bad results when the Waterfall is behind a
266 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
267 new 'upgrade-master' command, which will bring an old buildmaster
268 directory up-to-date. Right now the only thing it does is populate
269 public_html/ if it wasn't already there. Still to do: check the
270 other files, add documentation.
271 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
272 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
274 2007-08-13 Brian Warner <warner@lothar.com>
276 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
277 that contains the checkin comments when you hover over the entry
278 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
281 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
284 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
285 page with versions of python, buildbot, and twisted
286 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
287 * buildbot/status/web/index.html: add links to most pages
288 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
290 * buildbot/status/web/robots.txt: put a robots.txt in new installs
291 which discourages robot access to all large dynamically-generated
292 pages. The intention is that the index page and the 'about' page
293 are the only ones which should be crawlable.
294 * buildbot/scripts/runner.py (Maker.public_html): same
296 * setup.py: ship index.html and robots.txt in source distributions
298 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
299 activate automatic reloading of the page (using a meta Refresh:
301 (WaterfallHelp): new page to explain all the nifty query arguments
302 you can use on the Waterfall, along with forms to set them for
303 you. From this page, you can add filters for builder=, branch=,
304 show_events=, as well as turning on reload=.
305 (WaterfallStatusResource.buildGrid): new query args: last_time=,
306 first_time=, show_time=, num_events= . The old show= is still
307 accepted, but the new builder= is preferred. We ignore empty
308 branch= arguments, to make the WaterfallHelp form easier to
310 (WaterfallStatusResource.head): new method to add text to the
312 * buildbot/status/web/base.py (HtmlResource.content): use head()
313 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
314 empty branch= arguments
315 (OneLinePerBuildOneBuilder.body): same
317 2007-08-12 Brian Warner <warner@lothar.com>
319 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
320 new query args: 'last_time' is a timestamp of the top-most event
321 on the display, 'first_time' is a timestamp for the bottom-most
322 event. 'show_time' is the difference between them, and overrides
323 'first_time'. 'num_events' puts an upper limit on the number of
324 timestamps that will be displayed on the left hand edge.
325 (WaterfallStatusResource.body): add a 'next page' link to the
326 bottom, which shows the events that come just after those shown on
327 the current page. This is a first step towards #67, but we need
328 some more controls before we can close that one.
330 * buildbot/buildslave.py (BuildSlave): these are now MultiService
331 instances too, and live as children of the BotMaster. The main
332 advantage of this approach is that BuildSlaves can know when they
333 are being removed (so they can shut off the upcoming
334 when-do-we-email-an-admin-because-we-lost-our-slave timer).
335 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
336 identify which service children are BuildSlaves
337 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
338 Checker updates here, but delegate the rest to..
339 (BotMaster.loadConfig_Slaves): .. here, which looks at the
340 BotMaster's service children to identify the old slaves. I think
341 the previous approach of using master.slaves was broken in the
342 face of config updates that modified BuildSlave instances but did
343 not completely replace them.
344 * docs/buildbot.texinfo (Developer's Appendix): note the change to
345 the Service hierarchy
347 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
348 page (at URL /buildslaves/) to view status of all buildslaves at
349 once, including how long it's been since we last heard from them,
350 and which Builders use them.
352 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
355 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
358 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
359 use the BuildSlave to keep track of the last time we've heard from
360 the buildslave. This is updated upon receipt of any message from
361 any SlaveBuilder (which generally means when RemoteCommands are
362 giving us status updates, as BuildSteps run). In the future this
363 will include slave pings too.
364 * buildbot/process/base.py
365 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
366 * buildbot/process/buildstep.py:
367 (BuildStep.setBuildSlave): accept that reference
368 (BuildStep.runCommand): pass the reference on to the RemoteCommand
369 (RemoteCommand.remote_update): update the timestamp
370 (RemoteCommand.remote_complete): same
371 * buildbot/test/runutils.py (StepTester.makeStep): match the change
372 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
373 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
374 interface to retrieve this timestamp
375 * buildbot/status/builder.py (SlaveStatus): track a copy of the
379 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
381 (OneLinePerBuild.body): use a <ul> instead of <div>s
382 (OneLinePerBuildOneBuilder.body): same
384 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
385 by adding the file's new name to the list of changed files. This
386 ought to be sufficient for things like isFileImportant and trial
387 tests that only exercise tests for files that have been modified.
390 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
391 XMLRPC server to the WebStatus page. This only has two methods
392 right now (getAllBuildsInInterval and getBuild), but we'll be
393 adding more in the future. This server is extracted from the
396 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
397 generateFinishedBuilds, and improve the data displayed.
398 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
399 the per-Build page, add some information like ETA and got_revision
400 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
401 adding a list of recently completed builds
402 * buildbot/status/web/base.py (css_classes): factor this out
404 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
405 new method, to make status display classes easier to write,
406 especially the WebStatus 'one_line_per_build' page.
407 (IBuilderStatus.generateFinishedBuilds): same
408 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
409 (Status.generateFinishedBuilds): implement it
411 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
412 'source' to be a BuildStep instance, since BuildFactory accepts
414 (CPAN.__init__): same
415 (Distutils.__init__): same
416 (Trial.__init__): same
418 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
419 this might raise KeyError
421 2007-08-07 Brian Warner <warner@lothar.com>
423 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
424 'Owner:' field of the view, rather than 'p4logname', since
425 p4logname comes from the buildslave's environment and seems
426 unlikely to ever do the right thing. Thanks to Wade Brainerd for
427 the patch. Closes #40.
429 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
430 which imposes a per-slave limit on how many builds are allowed to
431 run simultaneously. This has a the same scope than the SlaveLock,
432 but is different because max_builds= gives the buildmaster the
433 freedom to assign the build to a different slave, whereas the
434 SlaveLock doesn't get tested until after the build is irrevocably
435 assigned to a slave. Therefore using max_builds= will improve
436 utilization in the presence of multiple buildslaves that are
437 attached to the same Builder. This completes the incorporation of
438 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
439 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
440 any Builder finishes, potentially trigger *all* Builders, since
441 max_builds= may have stalled someone else while waiting for the
443 * buildbot/scripts/sample.cfg: mention max_builds=
444 * buildbot/test/test_run.py (ConcurrencyLimit): test it
445 * docs/buildbot.texinfo (Buildslave Specifiers): document it
447 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
448 inherit from RunMixin do not need to call master.stopService()
449 themselves, since RunMixin.tearDown does that. The double call
450 fails on Twisted-2.0.x, which didn't happen to protect against it.
451 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
453 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
454 from #48, this one to have the BuildSlave objects track
455 SlaveBuilders, so they'll be able to use that knowledge to
456 influence their canStartBuild() response.
457 * buildbot/process/builder.py (SlaveBuilder.attached): call it
458 (SlaveBuilder.detached): same
459 * buildbot/test/test_slaves.py (BuildSlave): test it
461 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
462 the second of Dustin's #48 patches, this one adding a method to
463 the BuildSlave that allows it to decide whether it is willing to
464 participate in a build or not.
465 (SlaveBuilder.isAvailable): use canStartBuild() to decide
467 * buildbot/test/test_run.py (CanStartBuild): test for it
469 * all: incorporate the first of four patches by Dustin Mitchell
470 from ticket #48, working towards improving control over slave
471 concurrency. The first patch is to use a long-lived BuildSlave
472 object per slave, on which other behavior can be added later. I've
473 modified his patch considerably.
474 * buildbot/buildslave.py (BuildSlave): move class out of
475 slave/__init__.py (where it would get loaded by the slave as well
476 as the master, making dependencies trickier), and merge it with
477 BotPerspective. Now these BuildSlave instances are created once in
478 the master.cfg file, and not destroyed until they are either
479 removed from the config file or changed so
480 much (name/password/class changes) that we cannot continue to use
481 the old one. This affects config files: they must use
482 'from buildbot.buildslave import BuildSlave' instead of using
483 'from buildbot.slave import BuildSlave'.
484 * buildbot/master.py: move BotPerspective out
485 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
486 add or remove as necessary, update the rest using data from
488 * buildbot/slave/__init__.py: move BuildSlave out
489 * buildbot/test/test*.py: import BuildSlave from the new place
490 * buildbot/scripts/sample.cfg: update to match
491 * docs/buildbot.texinfo: update to match
492 * buildbot/process/builder.py: update comments to match
494 2007-08-02 Brian Warner <warner@lothar.com>
496 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
497 one-line-per-build pages a bit, add a header, refactor slightly
499 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
500 the TimeOutError timer, patch by Dustin Mitchell.
502 2007-08-01 Brian Warner <warner@lothar.com>
504 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
505 mostly work (branch= is still ignored, we need a useful header)
506 (OneLinePerBuildOneBuilder.body): this too
508 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
509 bring this up-to-date w.r.t. recent refactorings, and fix
510 redirections to bounce the browser to the top page after hitting
511 the 'force' button. This needs to be improved, but at least it now
512 redirects to a valid page.
513 (StatusResourceBuilder.ping): same
514 (StatusResourceBuilder.getChild): same, although I think this code
515 might be dead anyways
517 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
518 a branch= query argument, to filter the display down to builds and
519 changes that involve the given branch. You can add multiple
520 branch= arguments to see multiple branches (using a logical OR).
521 Note that there is no way to include the default branch (i.e.
522 None, i.e. trunk) yet, there is still work to be done to allow for
523 simple+uniform names of branches (i.e. removing the VC-specific
524 details of how branches are implemented, so calling the branch
525 'beta4' even though the SVN checkout step requires
527 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
528 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
529 * buildbot/interfaces.py (IEventSource.eventGenerator): same
530 * docs/buildbot.texinfo (Buildbot Web Resources): document it
532 * all: bring import statements up-to-date: don't import
533 __future__, assume cPickle and cStringIO are always available.
534 Also remove #!/usr/bin/python lines from non-scripts, my editor
535 has been a bit over-enthusiastic about stuffing them into new .py
538 * buildbot/status/web/index.html: put a link to the waterfall page
539 on the index, otherwise first-time users of WebStatus aren't going
540 to see anything very interesting.
542 * buildbot/interfaces.py (IEventSource): document this interface.
543 Thanks to Dustin Mitchell for the patch. Closes #60.
544 * buildbot/status/builder.py (BuilderStatus): same
545 * buildbot/changes/changes.py (ChangeMaster): same
547 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
548 add a query arg of 'show_events=true' to display non-build events,
549 like slaves attaching/detaching and reconfig events, or
550 'show_events=false' to hide them. The default is 'true'.
551 * docs/buildbot.texinfo (Buildbot Web Resources): document it
553 * web-parts: merge in web-parts branch. Lots of changes. The new
554 functionality is to add buildbot.status.html.WebStatus, which is a
555 superset of the Waterfall that adds new status pages and serves
556 regular files from BASEDIR/public_html/ , which is now the preferred
557 place to put robots.txt, buildbot.css, and index.html .
558 * buildbot/scripts/runner.py: the 'create-master' command now
559 creates public_html/ too, and populates it with a couple of
561 * buildbot/status/web: split waterfall code into smaller pieces
563 2007-07-31 Brian Warner <warner@lothar.com>
565 * buildbot/scripts/startup.py (launch): import twistd.run in a
566 different way to hush pyflakes
567 * buildbot/process/builder.py: remove unused import
569 2007-07-30 Brian Warner <warner@lothar.com>
571 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
572 Mitchell: pass SourceStamps around rather than branch/version/etc
573 tuples. Thanks Dustin! Closes #70.
574 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
575 tuple rather than a list, to avoid surprising mutations
576 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
577 * buildbot/status/mail.py (MailNotifier.buildMessage): same
578 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
579 * buildbot/test/test_status.py (Subscription): same
580 * buildbot/test/test_control.py (Force): same
581 * buildbot/test/test_buildreq.py (Request.testMerge): same
583 2007-07-29 Brian Warner <warner@lothar.com>
585 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
586 variable, since it wasn't used and is confusing in the presence of
587 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
590 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
591 the Buildbot home-page link to point at buildbot.net instead of
592 sourceforge, and add a current-version query parameter so we can
593 get some statistics on which versions are in use out there.
595 2007-07-28 Brian Warner <warner@lothar.com>
597 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
598 with c['change_source'], leaving c['sources'] for backwards
599 compatibility (but deprecated), scheduled for removal in 0.8.0
600 * docs/buildbot.texinfo: same
601 * buildbot/test/test_config.py: verify that c['sources'] still works
602 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
603 * buildbot/scripts/sample.cfg: update to match
605 * buildbot/changes/mail.py (MaildirSource): parse with python's
606 stdlib 'email' module, which has been available since python2.2,
607 and drop use of the 'rfc822' module, which has been depreceated
609 * buildbot/test/test_maildir.py: same: use parse_file() not parse
611 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
612 this needs to match the renaming in test/mail/msg*
614 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
617 * buildbot/test/test_mailparse.py: rename sample emails a bit
618 * buildbot/test/mail/msg*: same
620 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
621 parser for the "commit-email.pl" script that is shipped with SVN,
622 written by Justin Mason. Thanks! Closes SF#1072845.
623 * buildbot/test/mail/svn-commit.*: sample messages
624 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
625 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
627 2007-07-27 Brian Warner <warner@lothar.com>
629 * buildbot/changes/mail.py: refactor: move parsing into a method
630 named 'parse', each parser type gets a separate subclass. Remove
631 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
632 to be a simple leading-substring match. Add a warning to the logs
633 if prefix= does not end in a slash, since that's probably a
634 mistake. Fix both places where a prefix= mismatch would skip all
635 subsequent files in the same email, instead of just skipping the
636 one that didn't match.
637 * buildbot/test/test_mailparse.py: match changes
639 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
640 docs on email-based ChangeSources
642 * docs/buildbot.texinfo (Getting Source Code Changes): move all
643 the changesource types up a level, removing the one-entry menu in
646 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
647 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
648 instances instead of tuples. Closes #63.
649 * buildbot/slave/__init__.py (BuildSlave): define marker class
650 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
651 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
652 * buildbot/test/test_*.py: update tests to match
653 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
654 the c['bots'] backwards-compatibility handler works
656 2007-07-26 Brian Warner <warner@lothar.com>
658 * buildbot/changes/hgbuildbot.py (hook): add an in-process
659 Mercurial change-sending hook, contributed by Frederic Leroy.
660 Thanks! Addresses #50.
661 * docs/buildbot.texinfo (MercurialHook): document it
663 * buildbot/changes/hgbuildbot.py: change the way imports are done,
664 to make it compatible with at least hg-0.9.1 and the current 0.9.4
666 2007-07-17 Brian Warner <warner@lothar.com>
668 * buildbot/process/buildstep.py (BuildStep.getLog): add a
669 convenience method to retrieve a log added with
670 addLog()/addCompleteLog()/etc or logfiles= . I should have added
673 2007-07-03 Brian Warner <warner@lothar.com>
675 * buildbot/slave/commands.py (ShellCommand._startCommand): when
676 logging the environment variables, put one variable on each line,
677 rather than having one really long line with all of them. This
678 should make them a bit more readable and not trigger the
679 horizontal scrollbar (when viewing it in a web browser) quite so
680 much. Thanks to Albert Hofkamp for the patch.
682 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
683 WithProperties instance. Thanks to Axel Hecht for the patch.
685 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
686 * docs/buildbot.texinfo (Build Properties): document it
687 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
688 workdir if it didn't already exist.
690 * docs/buildbot.texinfo (Scheduler Types): correct the description
691 of Dependent schedulers. Thanks to Greg Ward for the patch.
693 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
694 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
695 the patch. Closes #49.
697 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
698 0700 before removing it, to deal with situations where a build will
699 leave files around without write permissions and the 'copy' or
700 'clobber' VC checkout modes need to blow away the tree first.
701 Thanks to Steve Milner for the suggestion and the patch (which I
702 mangled horribly). Closes #29.
703 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
706 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
707 an allowReconnect= argument to let callers control whether they
708 want this don't-let-it-reconnect behavior, since some tests care.
709 Factor out the .continueTrying=False lines from those callers.
710 * buildbot/test/test_slaves.py: same
711 * buildbot/test/test_run.py: same
713 2007-07-02 Brian Warner <warner@lothar.com>
715 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
716 slave has been disappeared, don't let it reconnect. This was
717 causing an intermittent failure in test_slaves.py, when the slave
718 that was supposed to be gone managed to come back by the end of
719 the test and affect the count.
720 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
722 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
723 diagnostic messages to track down this problem
724 (Builder.startBuild): same
726 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
727 the slave randomly rather than always taking the first one. Thanks
728 to Pike for the patch. Closes #36.
729 * buildbot/test/test_slaves.py: match the change. to avoid huge
730 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
731 enables/disables the round-robin-ness (enabled by default), and
732 some unit tests disable it.
733 * docs/buildbot.texinfo (Buildmaster Architecture): document it
735 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
736 argument to 'buildmaster_host', to make it more obvious that this
737 points to the buildmaster. Thanks to Bob Proulx for the
739 * buildbot/scripts/runner.py (slaveTAC): same
740 * buildbot/test/test_runner.py (Create.testSlave): match the change
742 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
745 2007-06-17 Brian Warner <warner@lothar.com>
747 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
748 we can round-trip all of our current step classes by calling
749 getStepFactory() and using the results to make a clone of the
752 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
755 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
756 the config file, we're moving to using actual instances instead of
757 the (class, kwargs) 'step specification' tuples. BuildFactory
758 still keeps a list of tuples internally, but when real instances
759 are passed in to addStep(), they are asked for their class and
760 kwargs using the new BuildStep.getStepFactory method. BuildFactory
761 accepts both instances and the tuple form, and converts instances
762 to the tuple form, but the instance form is preferred because it
763 gives the Steps a chance to do argument validation. Closes: #11.
765 * buildbot/process/buildstep.py (BuildStep.__init__): record the
766 factory information necessary to implement getStepFactory. The
767 addFactoryArguments() method can be used to include arguments that
768 aren't passed to the BuildStep base class constructor.
769 (BuildStep.setBuild):
770 (BuildStep.setDefaultWorkdir): new methods to take parameters that
771 are needed for live BuildSteps but not to construct the specification
772 tuples that are stashed in the factory.
774 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
775 'workdir' into new BuildSteps by using methods instead of
776 arguments. This makes the constructor for BuildSteps a lot
779 * buildbot/steps/*.py: update to match this change. Basically this
780 means adding calls to addFactoryArguments() in the __init__
781 methods to capture the arguments that aren't passed through to the
783 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
784 the new workdir (if any) into the RemoteShellCommands arguments.
785 * buildbot/steps/source.py: allow workdir= to be optional,
786 implement setDefaultWorkdir() since we don't inherit from
787 (CVS): finally remove old clobber=/export=/copydir= arguments,
788 in favor of the mode= argument that's been around forever now.
789 * buildbot/steps/transfer.py: remove build= argument
791 * buildbot/test/*.py: update to match, generally by turning all
792 build= arguments into subsequent calls to s.setBuild()
793 * buildbot/test/test_config.py (Factories): verify that we can
794 use either BuildStep instances or class/kwarg tuples in both
795 BuildFactory.addStep and BuildFactory.__init__
797 * docs/buildbot.texinfo (Build Steps): document the new approach,
798 mention compatibility with the old approach, update all examples
799 to use the new style.
801 2007-06-16 Brian Warner <warner@lothar.com>
803 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
804 the LoopingCall, just eat the failure so that we'll poll again
805 next time. This should allow us to tolerate (e.g.) sf.net SVN
806 failures more gracefully. Many thanks to Dustin Mitchell for the
809 2007-05-17 Brian Warner <warner@lothar.com>
811 * buildbot/status/words.py: refactor the IRC status bot into
812 separate 'Contact' and 'Channel' classes. The base Contact class
813 contains the interaction code: commands and responses. The
814 IRCContact subclass (and IrcStatusBot 'Channel') handle the
815 IRC-specific aspects. The plan is to write other subclasses for
816 other IM protocols like AIM and Jabber.
818 2007-04-16 Brian Warner <warner@lothar.com>
820 * CREDITS: update list of contributors. Thank you all!
822 2007-04-13 Brian Warner <warner@lothar.com>
824 * buildbot/status/mail.py (MailNotifier): add the project name to
825 the subject line and message body, to make it easier to
826 distinguish email coming from different buildmasters. Thanks to
827 Benoit Sigoure for the patch.
828 * buildbot/test/test_status.py (Mail): update to match
830 2007-03-24 Brian Warner <warner@lothar.com>
832 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
833 avoid text-conversion problems between DOS/windows and unix.
834 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
836 2007-03-03 Brian Warner <warner@lothar.com>
838 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
839 warning about the use of Waterfall here
841 2007-03-01 Brian Warner <warner@lothar.com>
843 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
845 2007-02-28 Brian Warner <warner@lothar.com>
847 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
848 Lamb to use a more optimal form of 'p4 changes', to reduce server
849 load. He reports that this optimization was added to p4d release
850 2005.2, but it should work in all versions. Closes #27.
851 * buildbot/test/test_p4poller.py: match it
853 2007-02-27 Brian Warner <warner@lothar.com>
855 * buildbot/status/web/*.py: move all web status stuff into a
856 separate directory, in anticipation of splitting it into smaller
857 pieces and adding more files. html.py was getting way too big.
858 * buildbot/status/classic.css: move it too
859 * setup.py: add the new sub-package
860 * buildbot/test/test_web.py: match the changes
861 * MANIFEST.in: handle the move of classic.css
863 2007-02-07 Brian Warner <warner@lothar.com>
865 * contrib/OS-X/*: add some launchd .plist files for automatically
866 starting a buildmaster or buildslave under OS-X (10.4 or later).
867 Thanks to Mark Pauley for these.
869 2007-02-06 Brian Warner <warner@lothar.com>
871 * docs/buildbot.texinfo (Requirements): update requirements to
872 stop claiming compatibility with python-2.2 or twisted-1.3.x .
874 * README: mention python-2.5 and twisted-2.5 compatibility
876 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
878 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
880 * buildbot/status/builder.py: same, by requiring cStringIO
881 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
882 * buildbot/test/test_vc.py: same
883 * buildbot/test/test_web.py:
884 * buildbot/test/test_steps.py: same, remove unused import
886 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
889 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
890 see any Builders that don't have Schedulers to drive them
892 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
893 attributes this uses went away
895 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
896 dialog, to allow you to reset the buildmaster and force
897 connect/disconnect. Correctly handle losing the buildmaster
898 connection (by switching the display to the hexnut, at which point
899 you can use the 'Connect' menu item to reconnect).
901 * buildbot/steps/source.py (Source.start): if we're using a patch,
902 add it as a LogFile to the checkout/update step. This will turn
903 into a link on the waterfall page.
905 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
906 option, to take the patch from a pre-made file rather than
907 generating it from the local tree. Thanks to Robert Helmer for the
908 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
909 * buildbot/scripts/runner.py (TryOptions): add --diff,
910 --patchlevel, and --baserev options
911 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
912 as None, meaning HEAD.
913 * buildbot/sourcestamp.py (SourceStamp): update docstring to
914 indicate that baserev=None means HEAD
915 * docs/buildbot.texinfo (try --diff): document it
917 * buildbot/test/test_steps.py (BuildStep): remove use of
918 reactor.iterate(), although the technique I replaced it with is a
919 gross polling hack that must be cleaned up properly some day. This
920 was the last use of reactor.iterate in the entire tree, yay.
922 2007-02-05 Brian Warner <warner@lothar.com>
924 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
925 is one of the three known values, otherwise we emit some confusing
926 messages later on. Thanks to Grig Gheorghiu for the catch.
928 2007-01-30 Brian Warner <warner@lothar.com>
930 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
931 Hearsum contributed a patch to let BonsaiPoller work with results
932 that contain non-ascii characters. Closes SF#1632641.
934 2007-01-27 Brian Warner <warner@lothar.com>
936 * Makefile (release): produce both .tar.gz and .zip source bundles.
939 2007-01-23 Brian Warner <warner@lothar.com>
941 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
942 * buildbot/changes/monotone.py: same
944 * buildbot/changes/maildir.py: combine several files into one,
945 clean up maildir.py to use Services properly.
946 * buildbot/changes/maildirtwisted.py: remove
947 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
949 * buildbot/changes/mail.py: match the change
950 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
951 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
953 * buildbot/slave/commands.py (command_version): bump to "2.3" to
954 indicate that the buildslave knows about the 'bzr' command
956 2007-01-22 Brian Warner <warner@lothar.com>
958 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
959 'with', it will become a reserved work in python2.6 .
961 * contrib/bb_applet.py: add a simple gnome-panel applet, to
962 display a terse summary of buildbot status.
963 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
964 some icons, small versions of the Blender object that lives in
965 docs/images/icon.blend
967 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
968 * buildbot/slave/commands.py (Bzr): same
969 * buildbot/scripts/tryclient.py (BzrExtractor): same
970 (SourceStampExtractor.dovc): modify this to allow non-zero exit
971 status, since 'bzr diff' does that
972 * buildbot/test/test_vc.py (Bzr): same
973 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
977 2007-01-20 Brian Warner <warner@lothar.com>
979 * contrib/darcs_buildbot.py: tidy up the progress messages
981 2007-01-17 Brian Warner <warner@lothar.com>
983 * contrib/darcs_buildbot.py: enhance to handle multiple patches
984 being pushed at a time. This keeps state in the repository in a
985 small file named .darcs_buildbot-lastchange, but that shouldn't
986 interfere with normal repository operations. Fixes SF#1534049.
987 * buildbot/clients/sendchange.py (Sender): make a single Sender
988 capable of sending Changes with different usernames.
990 2006-12-11 Brian Warner <warner@lothar.com>
992 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
993 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
994 buildbot.changes.mail a long time ago, but I forgot to add the
995 DeprecationWarning until now.
997 * buildbot/process/maxq.py: remove this, the functionality now
998 lives in buildbot.steps.maxq
1000 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1001 * buildbot/clients/gtkPanes.py: remove unused import
1003 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1004 that was meant to provide a special Reporter to run inside trial
1005 and give the buildslave lots of machine-readable status. We never
1006 finished this project.
1008 * buildbot/changes/bonsaipoller.py: remove unused imports
1009 * buildbot/changes/svnpoller.py: same
1010 * buildbot/process/builder.py: same
1011 * buildbot/process/buildstep.py: same
1012 * buildbot/slave/bot.py: hush pyflakes warning
1013 * buildbot/status/tests.py: remove unused imports
1014 * buildbot/status/tinderbox.py: same
1015 * buildbot/steps/python_twisted.py: same
1017 * buildbot/process/step.py: remove this file, these names were
1018 deprecated in 0.7.5 and are now being removed.
1019 * buildbot/process/step_twisted.py: same
1020 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1022 * buildbot/twcompat.py: remove the empty file, yay it is gone
1024 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1025 tw-2.0.0 and newer have the method we need.
1026 (getProcessOutputAndValue): same
1027 (which): remove this method, tw-2.0.0 t.p.procutils has it
1029 * buildbot/twcompat.py (implements): remove this method
1030 * buildbot/*: import implements() from zope.interface directly
1032 * buildbot/status/mail.py: stop falling back to importing
1033 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1036 * buildbot/twcompat.py (Interface): remove this import
1037 * buildbot/*: import Interface from zope.interface directly
1039 * buildbot/twcompat.py (providedBy): remove this method
1040 * buildbot/*: turn all uses of providedBy(obj, iface) into
1041 iface.providedBy(obj)
1043 * buildbot/twcompat.py (maybeWait): remove this method, now that
1044 we no longer maintain compatibility with Twisted<=1.3.0 .
1045 Twisted-2.0.0 and later allow trial methods to return Deferreds
1047 * buildbot/test/*: remove all uses of maybeWait
1049 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1051 * docs/buildbot.texinfo: same
1053 2006-12-10 Brian Warner <warner@lothar.com>
1055 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1056 * docs/buildbot.texinfo: set version to match
1058 2006-12-10 Brian Warner <warner@lothar.com>
1060 * README (REQUIREMENTS): update for release
1061 * NEWS: update for release
1062 * buildbot/slave/commands.py (command_version): mention that this
1063 version (2.2) was released with buildbot-0.7.5
1065 * buildbot/test/test_config.py (StartService.testStartService):
1066 inhibit the usual read-config-on-startup behavior, since otherwise
1067 the log.err that gets recorded causes the test to fail
1069 * buildbot/status/builder.py (LogFile.finish): forget about all
1070 subscribers once the log has finished, since after that point
1071 we're never going to use them again. This might help free up some
1074 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1075 than the old/deprecated gtk.mainquit()
1077 2006-12-09 Brian Warner <warner@lothar.com>
1079 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1080 better when we can't open the masterdst file
1082 * buildbot/scripts/startup.py (Follower._failure): add missing
1083 import statement for BuildSlaveDetectedError
1085 * buildbot/steps/transfer.py (FileUpload): cleanup
1086 (FileDownload): same. Add tests for slave version, add mode=.
1087 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1088 (SlaveFileDownloadCommand): same
1089 * buildbot/test/test_transfer.py: enhance tests
1090 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1093 2006-12-08 Brian Warner <warner@lothar.com>
1095 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1096 both success *and* failure. Without this, the 'buildbot
1097 sendchange' command would hang if it could not contact the
1098 buildmaster or deliver the Change, which would generally cause the
1099 user's commit/record/checkin command to hang too. Thanks to
1100 Christian Unger for the catch.
1102 2006-12-06 Brian Warner <warner@lothar.com>
1104 * NEWS: update with items for the next release
1106 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1107 whimsical example pulled from a punch-drunk email I sent out late
1109 (Transferring Files): document some of the other parameters
1110 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1111 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1112 * buildbot/test/test_svnpoller.py: same
1113 * buildbot/changes/svnpoller.py (SVNPoller): same
1115 2006-11-26 Brian Warner <warner@lothar.com>
1117 * docs/buildbot.texinfo (Build Properties): remind users that
1118 WithProperties must appear in a command= list, not as a top-level
1120 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1121 we're sending a list or a single string to the RemoteShellCommand
1123 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1125 * buildbot/scripts/startup.py (start): skip the whole
1126 watch-the-logfile thing under windows, since it needs os.fork()
1128 * buildbot/scripts/runner.py (restart): remove the old message
1129 that got printed after the buildbot was restarted.. it most cases
1130 it didn't get printed at the right time anyways
1132 2006-11-25 Brian Warner <warner@lothar.com>
1134 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1135 follow twistd.log and print lines until the process has started
1136 started properly. For the buildmaster, this means until the config
1137 file has been parsed and accepted. For the buildslave, this means
1138 until we've connected to the master. We give up after 5 seconds in
1139 any case. Helpful error messages and troubleshooting suggestions
1140 are printed when we don't see a successful startup. This closes the
1141 remainder of SF#1517975.
1142 * buildbot/scripts/startup.py: moved app startup code to here
1143 * buildbot/scripts/logwatcher.py: utility class to follow log
1144 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1145 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1146 so the LogWatcher can tell the difference between a buildmaster
1149 2006-11-24 Brian Warner <warner@lothar.com>
1151 * docs/examples/twisted_master.cfg: update to match the version
1152 in use on twistedmatrix.com
1153 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1154 was using before stopped working, but 'irc.freenode.net' works
1157 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1160 * buildbot/clients/base.py (TextClient.not_connected): upon
1161 UnauthorizedLogin failures, remind the user to connect to the
1162 PBListener port instead of the slaveport.
1163 (TextClient.disconnected): shut down more quietly
1164 * docs/buildbot.texinfo (statuslog): add another reminder
1166 * buildbot/scripts/runner.py (Options.subCommands): rename
1167 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1168 'sighup' as an alias.
1169 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1170 reconfig command to follow twistd.log and print all of the lines
1171 from the start of the config-file reload to its completion. This
1172 should make it a lot easier to discover bugs in the config file.
1173 Use --quiet to disable this behavior. This addresses half of
1174 SF#1517975, the other half will be to add this same utility to
1175 'buildbot start' and 'buildbot restart'.
1176 * docs/buildbot.texinfo (Loading the Config File): same
1179 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1180 method, it has been deprecated for a long time. Use
1181 IBuilderControl.requestBuild instead.
1182 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1183 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1184 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1185 * buildbot/test/test_control.py (Force.testForce): same
1186 * buildbot/test/test_run.py: use requestBuild instead
1188 * buildbot/clients/debug.py: replace 'Force Build' button with
1189 'Request Build' (which just adds one to the queue), add Ping
1190 Builder, add branch/revision fields to Request Build.
1191 * buildbot/clients/debug.glade: same
1192 * buildbot/master.py: update interface to match. This creates an
1193 incompatibility between new debugclients and old buildmasters.
1195 * buildbot/process/builder.py (Builder._attached): delay the call
1196 to maybeStartBuild for a reactor turn, to avoid starting a build
1197 in the middle of a reconfig (say, if the new Builder uses a new
1198 slave which is already connected).
1200 2006-11-23 Brian Warner <warner@lothar.com>
1202 * buildbot/test/test_transfer.py: appease pyflakes
1203 * buildbot/test/test_steps.py: same
1205 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1206 keeps pyflakes from finding undefined names
1208 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1209 Builder no longer induces a disconnect/reconnect cycle. This means
1210 that any builds currently in progress will not be interrupted, and
1211 any builds which are queued in the Builder will not be lost. This
1212 is implemented by having the new Builder extract the state (i.e.
1213 all pending Builds and any desired SlaveBuilders) from the old
1215 (BotPerspective): refactor. The BotPerspective no longer keeps
1216 track of all the Builders that want to use this slave; instead, it
1217 asks the BotMaster each time it needs this list. This removes
1218 addBuilder and removeBuilder. Clean up attached() to acquire all
1219 the slave's information in a more atomic fashion. updateSlave() is
1220 now the way to make sure the slave is using the right set of
1221 Builders: just call it after everything else has been
1223 (BotMaster): refactor, removing addBuilder/removeBuilder and
1224 replacing them with an all-at-once setBuilders() call.
1226 * buildbot/test/test_slaves.py (Reconfig): new test case to
1227 exercise this functionality
1228 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1229 * buildbot/slave/commands.py (WaitCommand): same
1231 * docs/buildbot.texinfo (Loading the Config File): document the
1234 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1235 SlaveBuilder to have its parent Builder changed.
1236 (SlaveBuilder.isAvailable): new method to give access to state,
1237 which is now a private attribute
1238 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1239 the SlaveBuilder about how it is being used. These methods update
1240 its internal state. buildFinished() is now the place that invokes
1241 maybeStartBuild() on its parent Builder.
1242 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1243 new Builder to take over for an old one, transferring state from
1245 (Buider): refactor the way that SlaveBuilders are used to match,
1246 giving them a bit more autonomy.
1247 (Builder.buildFinished): this no longer calls maybeStartBuild():
1248 instead the SlaveBuilder calls it on whoever its parent Builder is
1249 at the time. This way, when an old Builder is replaced by a new
1250 one, and there was a build in progress during the transition, when
1251 that build finishes, it will be the new Builder that is told about
1252 the newly available slave so it can start a new build.
1254 * buildbot/process/base.py (Build.startBuild._release_slave): when
1255 the Build finishes, tell the SlaveBuilder that they've been
1258 * buildbot/status/builder.py (SlaveStatus): add some new setter
1259 methods for use by BotPerspective, to keep some attributes more
1262 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1263 called by the buildmaster.
1264 (Bot.setBuilderList): instead, we locally announce any leftover
1265 directories based upon which Builders we were told about. The
1266 master doesn't really care; it's the local admin who may or may not
1267 wish to delete them.
1270 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1271 to allow use of python2.4 or whatever. This tool still requires
1274 2006-11-19 Brian Warner <warner@lothar.com>
1276 * NEWS (IStatusLog.readlines): more news items
1278 2006-11-18 Brian Warner <warner@lothar.com>
1280 * NEWS: start collecting items for the next release.
1282 2006-11-04 Brian Warner <warner@lothar.com>
1284 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1285 Hearsum. Closes SF#1590310.
1286 * buildbot/test/test_bonsaipoller.py: and tests
1288 * buildbot/status/tinderbox.py
1289 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1290 status when the build results in WARNINGS. Patch from Dave
1291 Liebreich. Closes SF#1587352.
1293 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1294 linux-vs-osx behavior difference w.r.t. reading from files that
1295 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1296 to Mark Rowe for the patch.
1298 2006-10-15 Brian Warner <warner@lothar.com>
1300 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1301 method name was misspelled in the interface definition. Thanks to
1302 Roy Rapoport for the catch.
1304 2006-10-13 Brian Warner <warner@lothar.com>
1306 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1307 to match the great Steps renaming
1309 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1310 Maybe I should run my own unit tests before recording a big
1311 change. Good thing I've got a buildbot to remind me.
1313 2006-10-12 Brian Warner <warner@lothar.com>
1315 * buildbot/steps/transfer.py: rework __init__ and args setup
1316 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1318 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1319 when opening the target file, only catch IOError (to report via
1320 stderr/rc!=0), let the others be reported as normal exceptions
1322 2006-10-08 Brian Warner <warner@lothar.com>
1324 * contrib/svn_watcher.py: fix security holes by using proper argv
1325 arrays and subprocess.Popen() rather than commands.getoutput().
1326 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1327 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1328 probably be removed by the next release.
1331 2006-10-04 Brian Warner <warner@lothar.com>
1333 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1334 initial lines that weren't emitted by pyflakes. When the pyflakes
1335 command is run under a Makefile, 'make' will echo the command it
1336 runs to stdio, and that was getting logged as a "misc" warning.
1337 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1338 * buildbot/test/test_steps.py (testPyFlakes3): another test
1340 2006-10-01 Brian Warner <warner@lothar.com>
1342 * buildbot/status/html.py (HtmlResource.render): if we get a
1343 unicode object from our content() method, encode it into utf-8
1344 like we've been claiming to all along. This allows the comments
1345 and author names from svnpoller.py to be delivered properly.
1347 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1348 de-unicodify filenames before creating the Change, because the
1349 rest of buildbot is unlikely to handle them well. Leave the 'who'
1350 field as a unicode object.. I don't think there's anything that
1351 will break very soon, and it will probably nudge us towards
1352 accepting unicode everywhere sooner or later. Stop using the
1353 "date" field that comes out of SVN, since it is using the
1354 repository's clock (and timezone) and what we care about is the
1355 buildmaster's (otherwise Changes from the future show up later
1356 than the builds they triggered).
1357 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1360 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1361 Suvbersion repository polling ChangeSource. I've hacked it up
1362 considerably: any bugs are entirely my own fault. Thank you
1364 * buildbot/test/test_svnpoller.py: tests for it
1365 * docs/buildbot.texinfo (SvnSource): document it
1367 2006-09-30 Brian Warner <warner@lothar.com>
1369 * buildbot/scheduler.py (Periodic): submit a reason= to the
1370 BuildSet to indicate which Scheduler triggered the build. Thanks
1371 to Mateusz Loskot for the suggestion.
1373 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1375 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1376 changes: set self.loop in __init__, remove unused volatile=
1378 * docs/buildbot.texinfo (.buildbot config directory): add more
1379 docs on the .buildbot/options keys used by "buildbot try"
1380 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1381 (Try.deliverJob): same
1383 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1385 (BonsaiPoller): same
1387 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1388 close the filehandle when we stop watching the file. Before, the
1389 filehandle was only closed when the LogFileWatcher was
1390 garbage-collected, which could be quite a while in the future. If
1391 it was still open by the time the next build started, windows will
1392 refuse to let the new build delete the old build/ directory. Fixes
1393 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1394 #twisted for the catch.
1396 2006-09-29 Brian Warner <warner@lothar.com>
1398 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1401 2006-09-25 Brian Warner <warner@lothar.com>
1403 * setup.py: the new buildbot.steps module wasn't being installed.
1404 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1405 (testmsgs): add the extra stuff from buildbot/test/* so you can
1406 run unit tests on an installed copy of buildbot, not just from
1409 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1410 columns of 'svnlook changed' output contain status information, so
1411 strip [:4] instead of [:6]. Depending upon what the status flags
1412 were, this would sometimes lead to mangled filenames. Thanks to
1413 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1415 * buildbot/steps/source.py (Monotone): initial Monotone support,
1416 contributed by Nathaniel Smith. Still needs docs and tests, but
1417 this code has been in use on the Monotone buildbot for a long
1419 * buildbot/slave/commands.py (Monotone): slave-side support
1420 * buildbot/changes/monotone.py (MonotoneSource): polling change
1423 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1424 contributed a Change Source that polls a Bonsai server (a
1425 kind of web-based viewcvs CGI script).
1427 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1428 Hearsum contributed a status plugin which sends email in the same
1429 format that Tinderbox does: this allows a number of tinderbox
1430 tools to be driven by Buildbot instead. Thanks Ben!
1432 2006-09-24 Brian Warner <warner@lothar.com>
1434 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1435 Thanks to Robert Helmer for the patch.
1437 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1438 BuildStatus about the buildslave name at the *beginning* of the
1439 build, rather than at the end. Thanks to Alexander Lorenz for the
1441 * buildbot/status/html.py (StatusResourceBuild.body): always
1442 include the slavename in the build page, not just when the build
1444 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1445 slavename in the email message
1447 2006-09-21 Brian Warner <warner@lothar.com>
1449 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1451 * docs/examples/glib_master.cfg: same
1452 * docs/examples/hello.cfg: same
1453 * docs/examples/twisted_master.cfg: same, update to current usage
1455 2006-09-19 Brian Warner <warner@lothar.com>
1457 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1458 (PyFlakes.createSummary): make it compatible with python-2.2
1460 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1461 for at least the output-parsing parts of PyFlakes
1463 2006-09-18 Brian Warner <warner@lothar.com>
1465 * buildbot/steps/python.py: oops, fix import of StringIO
1467 2006-09-17 Brian Warner <warner@lothar.com>
1469 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1470 turns out that SVN-1.4.0 doesn't fail to update once you've
1471 replaced a file with a directory, unlike older versions of SVN and
1472 pretty much every other VC tool we support. Since what we really
1473 care about is that the update succeeds anyway, stop checking that
1474 the tree got clobbered and just assert that the build succeeded.
1475 (VCBase.printLogs): add a utility function for debugging
1477 * buildbot/process/step.py: oops, added extra imports by mistake
1479 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1480 rstrip() on the first line coming out of the 'p4 describe'
1481 process, to remove the stray ^M that Wade Brainerd reports seeing
1482 in the 'when' field. Fixes SF#1555985.
1484 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1485 message logged when c['schedulers'] is not right
1486 * buildbot/scheduler.py (Scheduler.__init__): improve error
1487 message when a Scheduler() is created with the wrong arguments
1488 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1489 verify that these error messages are emitted
1491 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1492 The idea is that all the base classes (like BuildStep and
1493 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1494 will be a leftover backwards-compatibility file that only contains
1495 aliases for the steps that were moved out to buildbot.steps.*
1496 * lots: change imports to match
1497 * buildbot/process/step.py: add a DeprecationWarning if it ever
1500 2006-09-12 Brian Warner <warner@lothar.com>
1502 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1503 builderNames= is actually a sequence, since if you happen to give
1504 it a single builder-specification dictionary instead, it won't get
1505 caught by the existing assert. Thanks to Brett Neely for the
1508 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1510 * docs/buildbot.texinfo (Python BuildSteps): document them
1511 (sendchange): include a link to PBChangeSource, since you need one
1513 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1515 * buildbot/steps/dummy.py: same
1517 2006-09-08 Brian Warner <warner@lothar.com>
1519 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1520 BuildStep which lets you transfer files from the master to the
1521 slave or vice versa. Thanks to Albert Hofkamp for the original
1522 patch. Fixes SF#1504631.
1523 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1525 (SlaveFileDownloadCommand): same
1526 * docs/buildbot.texinfo (Transferring Files): document it
1527 * buildbot/test/test_transfer.py: test it
1528 * buildbot/test/runutils.py (StepTester): new utility class for
1529 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1530 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1533 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1534 walk through StatusLogs one line at a time, mostly for the benefit
1535 of ShellCommand.createSummary methods. You can either walk through
1536 STDOUT or STDERR, but the default is STDOUT.
1538 * buildbot/status/builder.py (LogFile.readlines): implement it.
1539 Note that this is not yet memory-efficient, it just pulls the
1540 whole file into RAM and then splits it up with a StringIO.
1541 Eventually this should be a generator that only pulls chunks from
1543 * buildbot/test/test_status.py (Log.testReadlines): test it
1545 * docs/buildbot.texinfo: update to match changes
1546 * buildbot/process/factory.py: stop using old definitions
1547 * buildbot/process/process_twisted.py: same
1548 * buildbot/test/test_*.py: same
1550 * buildbot/process/step_twisted.py: move definition to..
1551 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1552 relative-import mechanisms prevent this from being named 'twisted'
1553 or 'python/twisted' as I would have preferred.
1555 * buildbot/process/maxq.py: move definition to..
1556 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1558 * buildbot/process/step.py: split the user-visible BuildSteps into
1559 separate files, all under buildbot/steps/
1560 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1561 * buildbot/steps/shell.py: this holds ShellCommand and friends
1562 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1564 2006-09-05 Brian Warner <warner@lothar.com>
1566 * lots: run pyflakes, removed a lot of unused imports, changed the
1567 form of some conditional imports to remove false pyflakes
1568 warnings. There are still a number of warnings left, mostly from
1569 imports that are done for their side-effects.
1570 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1573 2006-08-26 Brian Warner <warner@lothar.com>
1575 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1576 compatible with twisted-1.3.0, for some reason I just can't seem
1577 to let go of the past.
1579 2006-08-25 Brian Warner <warner@lothar.com>
1581 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1583 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1584 all logfiles= in startCommand(), rather than in start() . This
1585 makes it easier to have the 'stdio' log come before any secondary
1586 logfiles, which I feel makes the waterfall display more
1588 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1589 from ShellCommand up into LoggingBuildStep
1590 (LoggingBuildStep.__init__): move the handling of logfiles= from
1591 ShellCommand up to LoggingBuildStep, because startCommand is
1592 provided by LoggingBuildStep, whereas start() was specific to
1593 subclasses like ShellCommand and Source. This removes code
1594 duplication in those subclasses.
1595 (ShellCommand.__init__): same
1596 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1597 for a slave that's too old to understand logfiles= into a separate
1598 method, so it can live in ShellCommand. The rest of
1599 setupLogfiles() can live in LoggingBuildStep.
1601 2006-08-24 Brian Warner <warner@lothar.com>
1603 * buildbot/locks.py (BaseLock): you can now configure Locks to
1604 allow multiple simultaneous owners. They still default to
1605 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1607 * docs/buildbot.texinfo (Interlocks): document the new options
1608 * buildbot/test/test_locks.py: add a bunch of new unit tests
1609 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1610 waitUntilMaybeAvailable, not waitUntilAvailable
1611 * buildbot/process/step.py (BuildStep.acquireLocks): same
1612 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1613 the whole lockid in their constructor, not just the name. Also,
1614 keep track of which real locks we've handed out by the full
1615 lockid, not just class+name, otherwise changing just the maxCount=
1616 in the master.cfg file would not actually cause a behavioral
1619 2006-08-23 Brian Warner <warner@lothar.com>
1621 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1623 * docs/buildbot.texinfo: same
1625 2006-08-23 Brian Warner <warner@lothar.com>
1627 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1628 * docs/buildbot.texinfo: set version to match
1629 * NEWS: update for 0.7.4
1630 * buildbot/slave/commands.py (command_version): mention that this
1631 version (2.1) was released with buildbot-0.7.4
1633 2006-08-22 Brian Warner <warner@lothar.com>
1637 * CREDITS: new file, list of people who have helped. Thanks!
1638 * MANIFEST.in: ship it
1640 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1641 new diagrams, the user's manual is more informative than it was.
1642 Start shipping the .html user's manual (and generated .png
1644 * Makefile: update 'release' target to match
1646 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1647 test.. I think the web-parts effort will render it pointless well
1648 before it ever actually starts to work.
1650 2006-08-20 Brian Warner <warner@lothar.com>
1652 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1653 meaning of the prefix= argument. It is now just a string which is
1654 stripped from the beginning of the filename. If prefix= is set but
1655 not found on any given filename, that filename is ignored. If all
1656 filenames in a Change are ignored, the Change is dropped. This is
1657 much simpler than the previous sep= nonsense, and I should have
1658 implemented it this way from the beginning. Effectively resolves
1659 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1660 Gedminas for the catch and suggested fixes.
1661 (ChangePerspective.perspective_addChange): implement the actual
1663 * buildbot/test/test_changes.py (TestChangePerspective): test it
1664 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1665 how to properly use prefix=
1666 * docs/examples/twisted_master.cfg (source): update prefix= by
1667 adding the trailing slash
1670 * docs/examples/twisted_master.cfg: update to actual practice
1672 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1673 update test case to match new link text.. the HREF has both a
1674 class= setting and an enclosing [] pair that I didn't match in the
1677 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1678 list of strings is preferred over a single string with embedded
1680 (ShellCommand.description=): explain that either single strings or
1681 a list of strings is acceptable, and why you might prefer one over
1682 the other. Add an example. Fixes SF#1524659, thanks to Paul
1683 Winkler for the catch.
1684 (Build Steps): update to use f.addStep() rather than using s()
1685 and the constructor list
1687 * buildbot/process/step.py (ShellCommand): accept either a single
1688 string or a list of strings in both description= and
1690 * buildbot/test/test_steps.py (Steps.test_description): test it
1691 * buildbot/test/runutils.py (makeBuildStep): support for that test
1693 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1694 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1695 collecting the files and creating the patch.
1697 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1698 per-step URLs that will be displayed on the waterfall display,
1699 for things like the HTML output of code-coverage tools, when
1700 the results are hosted elsewhere.
1701 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1702 way to retrieve these URLs
1703 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1704 the method to retrieve these URLs. Also provide backwards
1705 compatibility for saved BuildStepStatus instances that didn't have
1707 * buildbot/process/step.py (BuildStep.addURL): method to set these
1708 URLs from within a BuildStep
1709 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1710 (StepBox.getBox): give these external links a distinct CSS class
1711 named "BuildStep external" so a .css file can display them
1714 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1716 * buildbot/test/test_steps.py (Steps): test that we can all the
1717 URLs. Also add a bunch of other tests on methods that can be
1718 called from within BuildSteps
1719 * buildbot/test/runutils.py (makeBuildStep): add utility function
1721 2006-08-13 Brian Warner <warner@lothar.com>
1723 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1725 2006-08-10 Brian Warner <warner@lothar.com>
1727 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1728 index, this one of things like c['sources'] and c['schedulers']
1729 (indices): it looks like my clever idea of putting the @fooindex
1730 commands in between the @node and the @subsection (to make the
1731 HREF anchor jump to slightly above the section title, which works
1732 much better in html) confused texinfo horribly, so I'm moving the
1733 index tags back to be just after the @subsection marker. I also
1734 added extra lines between the @node/@section paragraph and the
1735 index tags, since I think maybe texinfo wants to see these be
1736 separate paragraphs.
1738 * docs/Makefile (images): make sure images get built when
1739 rendering the manual
1740 * docs/images/Makefile: same
1742 * buildbot/scripts/runner.py: rename 'buildbot master' to
1743 'buildbot create-master', and 'buildbot slave' to 'buildbot
1745 * docs/buildbot.texinfo: same
1748 * docs/buildbot.texinfo: reimplement the "useful classes" index
1749 with actual texinfo indices. The .info rendering is a bit
1750 weird-looking but it works well, and the HTML rendering is quite
1751 nice. This also puts the index targets in the regular flow of the
1752 text, which is easier to maintain.
1754 2006-08-06 Brian Warner <warner@lothar.com>
1756 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1757 Kevin Turner to prefer the environ= argument be a list rather than
1758 a string. If it is a list, it will be joined with a platform-local
1759 os.pathsep delimiter, and then prepended to any existing
1760 $PYTHONPATH value. This works better in cross-platform (i.e.
1761 windows buildslaves) environments when you need to push multiple
1762 directories onto the front of the path.
1763 (SlaveShellCommand): documented the new magic
1764 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1765 in a user-visible form
1767 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1768 Turner to prefer lists over strings when creating/running VC
1769 commands during unit tests. This is clearly necessary to survive
1770 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1771 renamed the wq() function to qw() though, since that's how it's
1772 spelled in perl. Eventually I'd prefer all commands to be
1773 specified with lists.
1775 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1776 which are deleted (or not yet created) correctly. Also add
1777 failsafe code to not explode if the file-watching poller doesn't
1778 get started. Thanks to JP Calderone for the catch and the poller
1780 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1782 * buildbot/test/emitlogs.py: same
1784 * NEWS: summarize recent changes
1786 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1787 clause to avoid the "host key mismatch" warning
1789 * buildbot/process/step_twisted.py (Trial.start): if the
1790 buildslave is too old to understand logfiles=, fall back to
1791 running 'cat _trial_temp/test.log' like before.
1792 (Trial.commandComplete): same. this takes advantage of the
1793 LoggingBuildStep refactoring to stall commandComplete long enough
1794 to run a second RemoteShellCommand.
1796 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1797 refactor command-completion handling, to allow methods like
1798 commandComplete/createSummary/evaluateCommand to return Deferreds.
1799 (LoggingBuildStep._commandComplete): delete the refactored method
1800 (ShellCommand.setupLogfiles): if the buildslave is too old to
1801 understand logfiles=, put a warning message both into twistd.log
1802 and into the otherwise empty user-visible LogFiles.
1804 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1805 callers to provide the slave-side logfile name, rather than
1806 forcing it to come from the local name of the LogFile.
1807 (BuildStep.getSlaveName): new method
1809 * buildbot/process/base.py (Build.getSlaveName): new method, so
1810 steps can find out which buildslave they're running on
1812 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1813 to match the s/cvs_ver/command_version/ change
1815 2006-08-05 Brian Warner <warner@lothar.com>
1817 * buildbot/slave/commands.py (command_version): replace the CVS
1818 auto-updated cvs_ver keyword with a manually-updated variable,
1819 since CVS is no longer the master repository. Add a description of
1820 the remote API change starting in this version (2.1), specifically
1821 the fact that SlaveShellCommand now accepts 'initial_stdin',
1822 'keep_stdin_open', and 'logfiles'.
1824 2006-07-31 Brian Warner <warner@lothar.com>
1826 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1827 diagrams to describe how the whole system fits together. The
1828 images themselves are kept in SVG files, with ascii-art versions
1829 in corresponding .txt files. Texinfo knows how to interpolate the
1830 text version into .info files, reference the .png versions from
1831 .html files, and include .eps versions in the .ps format.
1832 * docs/images/Makefile: tools to create .png and .eps
1833 * docs/images/*.svg: created pictures with Inkscape.
1834 * .darcs-boring: ignore the generated .eps and .png files
1836 2006-07-24 Brian Warner <warner@lothar.com>
1838 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1839 Scheduler names, since they cause setServiceParent to explode
1841 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1843 2006-07-20 Brian Warner <warner@lothar.com>
1845 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1846 which runs the buildbot unit tests
1848 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1849 classes that are useful in master.cfg
1851 2006-07-15 Brian Warner <warner@lothar.com>
1853 * Makefile (some-apidocs): new target to build only some epydocs
1855 * setup.py: minor comment.. does the classifiers= argument prevent
1856 the setup.py script from working on python2.2/2.3?
1858 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1861 * buildbot/twcompat.py: fix minor typo in comments
1863 * buildbot/manhole.py: move all Manhole-related code out to this
1864 module. Implement SSH-based manholes (with TwistedConch), and move
1865 to conch's nifty line-editing syntax-coloring REPL shell instead
1866 of the boring non-editing monochromatic (and deprecated) old
1868 * buildbot/master.py: remove all Manhole-related code
1869 (BuildMaster.loadConfig._add): make sure the old manhole is
1870 removed before we add the new one
1871 * docs/buildbot.texinfo (Debug options): document new Manhole options
1873 * buildbot/twcompat.py (_which): fix some epydoc issues
1874 * buildbot/status/html.py (Waterfall.__init__): same
1876 2006-06-29 Brian Warner <warner@lothar.com>
1878 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1879 deprecation warnings under newer Twisteds (by using
1880 zope.interface.Interface instead of old twisted.python.components
1882 * buildbot/slave/interfaces.py: same
1884 2006-06-28 Brian Warner <warner@lothar.com>
1886 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1887 svn commands, so it will fail immediately instead of hanging while
1888 it waits for a username/password to be typed in.
1890 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1891 log message if the step was shut down
1893 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1894 obsolete reference to mktap.
1896 2006-06-20 Brian Warner <warner@lothar.com>
1898 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1899 test to include new 'logfiles' argument sent from master to slave
1901 2006-06-19 Brian Warner <warner@lothar.com>
1903 * buildbot/process/step_twisted.py (Trial): track Progress from
1904 _trial_temp/test.log too
1906 * buildbot/process/step.py (OutputProgressObserver): generalize
1907 the earlier StdioProgressObserver into an OutputProgressObserver
1908 that can track LogFiles other than stdio.
1909 (LoggingBuildStep.__init__): same
1911 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1912 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1913 will fail under windows because of os.sep issues. It might have
1914 worked before if 'cat' was doing cygwin path conversion.
1916 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1917 creation of LogFileWatchers
1918 (ShellCommand._startCommand): and record the files that were
1919 watched in the 'headers' section of the ShellCommand output
1921 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1922 need to actually pass it to the slave if you want it to work.
1923 (ShellCommand): document it a bit
1925 * buildbot/test/test_shell.py: new test to validate LogFiles
1926 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1928 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1929 before printing the last batch of lines, to test that the polling
1930 logic is working properly
1932 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1933 handling, making it possible to track multiple logs for a single
1934 RemoteCommand. The previous single logfile is now known as the
1936 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1937 (RemoteShellCommand.__init__): accept logfiles=
1938 (LoggingBuildStep.startCommand): stdio_log is now one of many
1939 (ShellCommand): added logfiles= argument, as well as a class-level
1940 .logfiles attribute, which will be merged together to figure out
1941 which logfiles should be tracked. The latter maybe be useful for
1942 subclasses of ShellCommand which know they will aways produce
1943 secondary logfiles in the same location.
1945 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1946 and closeStdin() methods, preparing to make it possible to write
1947 to a ShellCommand's stdin at any time, not just at startup. These
1948 writes are buffered if the child process hasn't started yet.
1949 (LogFileWatcher): new helper class to watch arbitrary logfiles
1950 while a ShellCommand runs. This class polls the file every two
1951 seconds, and sends back 10k chunks to the buildmaster.
1952 (ShellCommand): rename stdin= to initialStdin=, and add
1953 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1955 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1956 key of "log" and a value of (logname, data).
1957 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1958 'logfiles' to the master-visible args dictionary.
1959 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1962 * buildbot/test/test_vc.py (Patch.testPatch): same
1965 * buildbot/test/emit.py: write to a logfile in the current
1966 directory. We use this to figure out what was used as a basedir
1967 rather than looking to see which copy of emit.py gets run, so that
1968 we can run the commands from inside _trial_temp rather than inside
1970 * buildbot/test/subdir/emit.py: same
1971 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1972 argument rather than running from buildbot/test/
1973 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1974 rather than using an implicit setUp()
1975 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1976 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1977 of assuming that we're running in buildbot/test/ (and that '.' is
1980 * buildbot/slave/commands.py (Command.doStart): refactor Command
1981 startup/completion a bit: now the SlaveBuilder calls doStart(),
1982 which is not meant for overridding by subclasses, and doStart()
1983 calls start(), which is. Likewise the SlaveBuilder calls
1984 doInterrupt(), and subclasses override interrupt(). This also puts
1985 responsibility for maintaining .running in Command rather than in
1987 (Command.doInterrupt): same
1988 (Command.commandComplete): same, this is called when the deferred
1989 returned by start() completes.
1990 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1991 (SlaveBuilder.remote_interruptCommand): same
1992 (SlaveBuilder.stopCommand): same
1994 2006-06-16 Brian Warner <warner@lothar.com>
1996 * buildbot/test/test_shell.py: new test file to contain everything
1997 relating to ShellCommand
1998 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1999 multiple logfiles in realtime" feature, not yet implemented
2000 * buildbot/test/emitlogs.py: support file for testLogFiles
2001 * docs/buildbot.texinfo (ShellCommand): document the feature
2003 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2005 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2006 for tests which exercise SlaveCommands in isolation.
2008 * buildbot/test/test_slavecommand.py: Move some utilities like
2009 SignalMixin and FakeSlaveBuilder from here ..
2010 * buildbot/test/runutils.py: .. to here, so they can be used by
2011 other test classes too
2012 * buildbot/test/test_vc.py: more SignalMixin refactoring
2013 * buildbot/test/test_control.py: same
2014 * buildbot/test/test_run.py: and some rmtree refactoring
2016 2006-06-15 Brian Warner <warner@lothar.com>
2018 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2019 'testBranch' to match other VC tests and have the tests run in
2020 roughly increasing order of dependency
2022 * buildbot/test/test_steps.py (LogObserver): new test to verify
2023 LogObservers can be created at various times and still get
2024 connected up properly
2026 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2027 to create BuildStepStatus instances that actually work.
2029 * buildbot/process/step.py (LogObserver): add outReceived and
2030 errReceived base methods, to be overridden
2032 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2033 API to take a name instead of a step, reducing the coupling
2034 somewhat. This returns the BuildStepStatus object so it can be
2035 passed to the new Step, instead of jamming it directly into the
2037 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2039 * buildbot/process/base.py (Build.setupBuild): use both methods
2040 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2041 process a bit to match
2043 2006-06-14 Brian Warner <warner@lothar.com>
2045 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2046 docs on writing new LogObserver classes
2047 (Writing New Status Plugins): brief docs on how Status Plugins fit
2050 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2051 implement a LogObserver that counts how many unit tests have been
2053 (Trial.__init__): wire it in
2054 * buildbot/test/test_twisted.py (Counter): unit test for it
2056 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2057 to new cmd.logs['stdio'] scheme
2058 (Trial.commandComplete): same
2059 (BuildDebs.commandComplete): same
2061 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2062 LogFiles, instead of just a single one. The old single logfile is
2063 now called "stdio". LoggedRemoteCommand no longer creates a
2064 LogFile for you (the code to do that was broken anyway). If you
2065 don't create a "stdio" LogFile, then stdout/stderr will be
2067 (LogObserver): implement "LogObservers", which a BuildStep can add
2068 to parse the output of a command in real-time. The primary use is
2069 to provide more useful information to the Progress code, allowing
2070 better ETA estimates.
2071 (LogLineObserver): utility subclass which feeds complete lines to
2072 the parser instead of bytes.
2073 (BuildStep.progressMetrics): this is safer as a tuple
2074 (BuildStep.setProgress): utility method, meant to be called by
2076 (BuildStep.addLogObserver): new method, to be called at any time
2077 during the BuildStep (even before any LogFiles have been created),
2078 to attach (or schedule for eventual attachment) a LogObserver to a
2080 (StdioProgressObserver): new LogObserver which replaces the old
2081 "output" progress gatherer
2082 (LoggingBuildStep.__init__): same
2083 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2084 (LoggingBuildStep._commandComplete): must use logs['stdio']
2085 instead of the old single ".log" attribute.
2086 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2087 functionality, now subsumed into StdioProgressObserver
2088 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2089 log name changed from "output" to "stdio".
2092 * buildbot/interfaces.py (ILogFile): add the Interface used from
2093 the BuildStep towards the LogFile
2094 (ILogObserver): and the one provided by a LogObserver
2095 * buildbot/status/builder.py (LogFile): implement it
2097 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2098 HEADER constants here ..
2099 * buildbot/status/builder.py (STDOUT): .. from here
2101 2006-06-13 Brian Warner <warner@lothar.com>
2103 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2104 compatibility with python2.2, which doesn't have the 'substr in
2106 (TestP4Poller.makeTime): utility function to construct the
2107 timestamp using the same strptime() approach as p4poller does. It
2108 turns out that time.mktime() behaves slightly differently under
2109 python2.2, probably something to do with the DST flag, and that
2110 causes the test to fail under python2.2. (changing the mktime()
2111 arguments to have dst=0 instead of -1 caused it to fail under
2112 python2.3. Go figure.)
2113 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2115 2006-06-12 Brian Warner <warner@lothar.com>
2117 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2118 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2119 contributing such an excellent patch, including docs and unit
2120 tests! This makes it *so* much easier to apply. I had to update
2121 test_vc.py to handle some recent refactorings, but everything else
2122 applied smoothly. The only remaining thing I'd like to fix would
2123 be to remove the hard-wired port 1666 used by p4d, and allow it to
2124 claim any unused port. This would allow two copies of the test
2125 suite to run on the same host at the same time, as well as
2126 allowing the test suite to run while a real (production) p4d was
2127 running on the same host. Oh, and maybe we should add a warning to
2128 step.P4 that gets emitted if the slave is too old to provide the
2129 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2130 * buildbot/slave/commands.py (P4): same
2131 (P4Sync): same, some minor updates
2132 * buildbot/changes/p4poller.py: same
2133 * docs/buildbot.texinfo: same
2134 * buildbot/test/test_p4poller.py: same
2135 * buildbot/test/test_vc.py (P4): same
2137 * setup.py: add Trove classifiers for PyPI
2139 2006-06-08 Brian Warner <warner@allmydata.com>
2141 * buildbot/status/client.py
2142 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2143 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2144 build needs to be IRemote'd separately, rather than IRemote'ing
2145 the whole list at once. I can't wait until newpb's serialization
2146 adapters make this unnecessary.
2148 2006-06-06 Brian Warner <warner@lothar.com>
2150 * buildbot/process/step.py (WithProperties): make this inherit
2151 from ComparableMixin, so that reloading an unchanged config file
2152 doesn't cause us to spuriously reload any Builders which use them.
2153 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2156 2006-06-03 Brian Warner <warner@lothar.com>
2158 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2159 running py2exe on windows, contributed by Mark Hammond. Addresses
2160 SF#1401121, but I think we still need to include
2161 buildbot/scripts/sample.cfg
2162 * setup.py: include buildbot_service.py as a script under windows
2163 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2164 a py2exe application), get the icon/css datafiles from a different
2167 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2168 double-escape the build URL. Thanks to Olivier Bonnet for the
2169 patch. Fixes SF#1452801.
2171 2006-06-02 Brian Warner <warner@lothar.com>
2173 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2174 first six columns of 'svnlook' output, not just the first column,
2175 since property changes appear in the other five. Thanks to Olivier
2176 Bonnet for the patch. Fixes SF#1398174.
2178 2006-06-01 Brian Warner <warner@lothar.com>
2180 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2181 the fake build, so that title= has something to be set to
2183 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2184 attribute of the "Build #NN" link in the yellow start-the-build
2185 box to the build's reason. This means that you get a little
2186 tooltip explaining why the build was done when you hover over the
2187 yellow box. Thanks to Zandr Milewski for the suggestion.
2189 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2190 (Box.setETA): handle ETA=None (by stopping the timer)
2191 (Box.update): make the [soon] text less different than the usual
2192 text, so the rest of the text doesn't flop around so much. It
2193 would be awfully nice to figure out how to center this stuff.
2194 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2196 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2197 by default, so that any ShellCommand which fails marks the overall
2198 build as a failure. I should have done this from the beginning.
2199 Add flunkOnFailure=False to the arguments if you want to turn off
2202 2006-05-30 Brian Warner <warner@lothar.com>
2204 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2205 last-build/current-build/current-step. Show what step is currently
2206 running. Show ETA for both the overall build and the current step.
2207 Update GTK calls to modern non-deprecated forms. There's still a
2208 lot of dead code and debug noise to remove.
2210 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2211 shows up properly in status displays
2213 2006-05-28 Brian Warner <warner@lothar.com>
2215 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2216 build we use to verify that WithProperties works:
2218 ** set flunkOnFailure=True so that build failures get noticed
2219 ** set workdir='.' so that the build succeeds, otherwise it is trying
2220 to touch 'build/something', and 'build/' doesn't exist because
2221 usually that's created by a Source step
2222 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2223 this test somehow triggers, in which the 'touch' process becomes
2224 a zombie and we wait for th etimeout before giving up on it.
2226 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2227 to log the Build results and step logs to the twisted log.
2228 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2229 what went wrong if a build was expected to succeed but didn't.
2231 * buildbot/process/step_twisted.py (Trial): set the default
2232 trialMode to '--reporter=bwverbose', which specifies verbose
2233 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2234 '-to', but those are completely missing in modern Twisteds.
2236 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2237 a localhost-only port, to encourage better security
2239 * docs/buildbot.texinfo (Change Sources): mention
2242 * .darcs-boring: add a Darcs boringfile
2244 * README (REQUIREMENTS): stop claiming compatibility with
2247 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2250 2006-05-27 Brian Warner <warner@lothar.com>
2252 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2253 * docs/buildbot.texinfo: same
2255 2006-05-23 Brian Warner <warner@lothar.com>
2257 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2258 * docs/buildbot.texinfo: set version to match
2259 * NEWS: update for 0.7.3
2261 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2262 give a quick mapping from VC system to possible ChangeSources
2263 (Build Properties): add 'buildername'
2265 * buildbot/process/base.py (Build.setupStatus): oops, set
2266 'buildername' and 'buildnumber' properties
2267 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2270 2006-05-22 Brian Warner <warner@lothar.com>
2272 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2273 property interpolation better
2275 * README (INSTALLATION): remove old '-v' argument from recommended
2278 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2279 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2282 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2283 'svnversion' instead of grepping the output of 'svn info', much
2284 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2285 Bonnet for the suggestion.
2286 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2287 require the WC_PATH argument, so run 'svnversion .' instead.
2289 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2290 aren't supposed to have 'self' in their argument list
2292 2006-05-21 Brian Warner <warner@lothar.com>
2294 * buildbot/process/step.py (ShellCommand.start): make
2295 testInterpolate pass. I was passing the uninterpolated command to
2296 the RemoteShellCommand constructor
2297 (ShellCommand._interpolateProperties): oops, handle non-list
2298 commands (i.e. strings with multiple words separated by spaces in
2299 them) properly, instead of forgetting about them.
2301 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2302 to actually try to use build properties in a real build. This test
2304 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2305 to start and evaluate builds
2307 * buildbot/test/test__versions.py: add a pseudo-test to record
2308 what version of Twisted/Python/Buildbot are running. This should
2309 show up at the beginning of _trial_tmp/test.log, and exists to help
2310 debug other problems.
2312 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2313 a filename to be served as 'robots.txt' to discourage web spiders.
2314 Adapted from a patch by Tobi Vollebregt, thanks!
2315 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2316 (Waterfall.test_waterfall): tweak the way that filenames are put
2317 into the config file, to accomodate windows pathnames better.
2319 * docs/buildbot.texinfo (HTML Waterfall): document it
2321 * buildbot/process/process_twisted.py
2322 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2323 changed the build process. The new setup.py no longer takes the
2325 (FullTwistedBuildFactory.__init__): same
2326 (TwistedReactorsBuildFactory.__init__): same
2328 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2329 be placed in the [hooks] section of the central repository (the
2330 one that everybody pushes changes to).
2332 2006-05-20 Brian Warner <warner@lothar.com>
2334 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2335 .darcs-context file, use binary mode. I think this was causing a
2336 Darcs failure under windows.
2338 2006-05-19 Brian Warner <warner@lothar.com>
2340 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2341 use a timezone string of +0000 and gmtime, since this timestamp is
2342 sent to a buildmaster and %z is broken.
2344 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2345 string and localtime, since this timestamp will only be consumed
2346 locally, and %z is broken.
2348 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2349 gmtime, since this timestamp is returned to the buildmaster, and
2352 2006-05-18 Brian Warner <warner@lothar.com>
2354 * NEWS: update in preparation for next release
2356 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2357 setup-repository and do-we-have-the-vc-tools code into a separate
2358 "helper" class, which sticks around in a single module-level
2359 object. This seems more likely to continue to work in the future
2360 than having it hide in the TestCase and hope that TestCases stick
2361 around for a long time.
2363 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2364 addremove' has been deprecated in recent versions of mercurial, so
2365 use 'hg add' instead
2367 2006-05-07 Brian Warner <warner@lothar.com>
2369 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2370 operating under windows, move the file before opening it, since
2371 you can't rename a file that somebody has open.
2373 * buildbot/process/base.py (Build.setupBuild): if something goes
2374 wrong while creating a Step, log the name and arguments, since the
2375 error message when you get the number of arguments wrong is really
2378 2006-05-06 Brian Warner <warner@lothar.com>
2380 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2381 bugs in twisted-specific code not covered by my unit tests, this
2382 time use 'cmd' argument instead of self.cmd
2384 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2385 fix stupid braino: either use startwith or find()==0, not both.
2386 (TwistedReactorsBuildFactory.__init__): another dumb typo
2388 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2389 mark this test as TODO under windows, since process-killing seems
2390 dodgy there. We'll come back to this later and try to fix it
2393 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2394 and don't include a timezone
2395 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2396 This should avoid the windows-with-verbose-timezone-name problem
2398 (Patch.testPatch): add a test which runs 'patch' with less
2399 overhead than the full VCBase.do_patch sequence, to try to isolate
2400 a windows test failure. This one uses slave.commands.ShellCommand
2401 and 'patch', but none of the VC code.
2403 * buildbot/slave/commands.py (getCommand): use which() to find the
2404 executables for 'cvs', 'svn', etc. This ought to help under
2407 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2408 working directory before starting. If an earlier test failed, the
2409 leftover directory would mistakenly flunk a later test.
2410 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2411 Make sure that we use the right commandlines if which("tla") picks
2412 up "tla.exe" (as it does under windows).
2413 (TlaSupport.do_get): factor out this tla-vs-baz difference
2414 (TlaSupport.vc_create): more tla-vs-baz differences
2416 * buildbot/test/test_slavecommand.py
2417 (ShellBase.testShellMissingCommand): stop trying to assert
2418 anything about the error message: different shells on different
2419 OSes with different languages makes it hard, and it really isn't
2420 that interesting of a thing to test anyway.
2422 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2423 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2424 "Panther"), because it has a bug which flunks a couple tests in
2425 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2426 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2427 able to test that yet.
2429 2006-04-30 Brian Warner <warner@lothar.com>
2431 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2432 make sure child commands emit messages in english, so our regexps
2433 will match. Thanks to Nikaus Giger for identifying the problems.
2434 (VCBase._do_vctest_export_1): mode="export" is not responsible
2435 for setting the "got_revision" property, since in many cases it is
2436 not convenient to determine.
2437 (SVNSupport.capable): when running 'svn --version' to check for
2438 ra_local, we want error messages in english
2439 * buildbot/test/test_slavecommand.py
2440 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2441 to emit the error message in english
2443 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2444 the environment with $LC_ALL="C" so that Commands which need to
2445 parse the output of their child processes can obtain it in
2447 (SVN.parseGotRevision): call "svn info" afterwards instead of
2448 watching the output of the "svn update" or "svn checkout".
2449 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2450 (Arch.parseGotRevision): same
2451 (Bazaar.parseGotRevision): same
2452 (Mercurial.parseGotRevision): same
2454 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2455 $LC_ALL="C" when running commands under 'buildbot try', too
2457 * buildbot/test/__init__.py: remove the global os.environ()
2458 setting, instead we do it just for the tests that run commands and
2459 need to parse their output.
2461 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2462 remove the overly-short .timeout on this test, because non-DNotify
2463 platforms must fall back to polling which happens at 10 second
2464 intervals, so a 5 second timeout would never succeed.
2466 2006-04-24 Brian Warner <warner@lothar.com>
2468 * docs/buildbot.texinfo (Installing the code): update trial
2469 invocation, SF#1469116 by Niklaus Giger.
2470 (Attributes of Changes): updated branch-name examples to be
2471 a bit more realistic, SF#1475240 by Stephen Davis.
2473 * contrib/windows/buildbot2.bat: utility wrapper for windows
2474 developers, contributed by Nick Trout (after a year of neglect..
2475 sorry!). SF#1194231.
2477 * buildbot/test/test_vc.py (*.capable): store the actual VC
2478 binary's pathname in VCS[vcname], so it can be retrieved later
2479 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2480 strip out non-numeric timezone information, specifically the funky
2481 German string that his system produced that confuses CVS.
2482 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2483 allow Darcs tests to work on windows
2484 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2485 procutils.which() everywhere, to allow tryclient to work under
2486 windows. Also from Niklaus Giger, SF#1463394.
2488 * buildbot/twcompat.py (which): move the replacement for a missing
2489 twisted.python.procutils.which from test_vc.py to here, so it can
2490 be used in other places too (specifically tryclient.py)
2492 2006-04-23 Brian Warner <warner@lothar.com>
2494 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2495 bare buildbotURL/projectName line with a proper DIV, along with a
2496 CSS class of "title", from Stefan Seefeld (SF#1461675).
2497 (WaterfallStatusResource.body0): remove the redundant 'table'
2498 class from the table
2499 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2500 to the top-row TR, and class="Activity" to the second-row TR,
2501 rather than putting them in the individual TD nodes.
2503 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2504 'got_revision' build property for all VC systems that implement
2505 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2507 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2508 to determine which revision we actually obtained
2509 (CVS.parseGotRevision): implement this for CVS, which just means
2510 to grab a timestamp. Not ideal, and it depends upon the buildslave
2511 having a clock that is reasonably well syncronized with the server,
2512 but it's better than nothing.
2513 (SVN.parseGotRevision): implement it for SVN, which is accurate
2514 (Darcs.parseGotRevision): same
2515 (Arch.parseGotRevision): same
2516 (Bazaar.parseGotRevision): same
2517 (Mercurial.parseGotRevision): same
2519 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2520 keep a record of all non-stdout/stderr/header/rc status updates,
2521 for the benefit of RemoteCommands that send other useful things,
2523 (Source.commandComplete): put any 'got_revision' status values
2524 into a build property of the same name
2527 * buildbot/process/step_twisted.py (Trial): update to deal with
2528 new ShellCommand refactoring
2530 * docs/buildbot.texinfo (Build Properties): document new feature
2531 that allows BuildSteps to get/set Build-wide properties like which
2532 revision was requested and/or checked out.
2534 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2535 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2536 it. Note that this bumps the persistenceVersion of the saved Build
2537 object, so add the necessary upgrade-old-version logic to include
2538 an empty properties dict.
2540 * buildbot/process/base.py (Build.setProperty): implement it
2541 (Build.getProperty): same
2542 (Build.startBuild): change build startup to set 'branch',
2543 'revision', and 'slavename' properties at the right time
2545 * buildbot/process/step.py (BuildStep.__init__): change setup to
2546 require 'build' argument in a better way
2547 (LoggingBuildStep): split ShellCommand into two pieces, for better
2548 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2549 a single RemoteCommand that sends stdout/stderr status text. It
2550 also provides the usual commandComplete / createSummary /
2551 evaluateCommand / getText methods to be overridden...
2552 (ShellCommand): .. whereas ShellCommand is specifically for
2553 running RemoteShellCommands. Other shell-like BuildSteps (like
2554 Source) can inherit from LoggingBuildStep instead of ShellCommand
2555 (WithProperties): marker class to do build-property interpolation
2556 (Source): inherit from LoggingBuildStep instead of ShellCommand
2559 * buildbot/test/test_properties.py: test new functionality
2561 2006-04-21 Brian Warner <warner@lothar.com>
2563 * buildbot/test/test_vc.py: rename testBranch to
2564 testCheckoutBranch to keep the tests in about the right
2567 2006-04-18 Brian Warner <warner@lothar.com>
2569 * docs/buildbot.texinfo (PBListener): improve cross-references
2570 between PBListener and 'buildbot statusgui', thanks to John Pye
2573 2006-04-17 Brian Warner <warner@lothar.com>
2575 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2576 running under Twisted-1.3.0, otherwise skipped tests are reported
2579 * all: use isinstance() instead of 'type(x) is foo', suggested by
2582 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2583 oops, fix a brain-fade from the other week, when making the
2584 addStep changes. I changed all the __init__ upcalls to use the
2585 wrong superclass name.
2586 (FullTwistedBuildFactory.__init__): same
2587 (TwistedDebsBuildFactory.__init__): same
2588 (TwistedReactorsBuildFactory.__init__): same
2589 (TwistedBuild.isFileImportant): use .startswith for clarity,
2590 thanks to Neal Norwitz for the suggestions.
2592 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2593 changes, then deliver them over PB to a remote buildmaster.
2595 * contrib/svnpoller.py: added script by John Pye to poll a remote
2596 SVN repository (by running 'svn log') from a cronjob, and run
2597 'buildbot sendchange' to deliver the changes to a remote
2599 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2600 modification of svnpoller.py), same purpose, but this one loops
2601 internally (rather than expecting to run from a cronjob) and works
2603 * contrib/README.txt: same
2605 2006-04-11 Brian Warner <warner@lothar.com>
2607 * all: fix a number of incorrect names and missing imports, thanks
2608 to Anthony Baxter for the patch.
2609 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2610 remove unused buggy method.
2611 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2612 comes from shutil, not "shutils"
2613 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2614 (Arch.checkSlaveVersion): same
2615 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2617 * buildbot/process/step_twisted2.py: add some missing imports
2618 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2619 this code used to live in twisted.internet.defer
2621 2006-04-10 Brian Warner <warner@lothar.com>
2623 * buildbot/process/step.py (Mercurial): add Mercurial support
2624 * buildbot/slave/commands.py (Mercurial): same
2625 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2626 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2627 not yet tested, but 'try' support *is* covered
2628 * docs/buildbot.texinfo (Mercurial): document it
2630 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2631 some debugging messages (turned off)
2632 * buildbot/test/test_vc.py: improve debug messages
2634 2006-04-07 Brian Warner <warner@lothar.com>
2636 * buildbot/test/test_vc.py (which): define our own which() in case
2637 we can't import twisted.python.procutils, because procutils doesn't
2638 exist in Twisted-1.3
2640 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2641 of SlaveLocks for performance tests
2643 * docs/examples/twisted_master.cfg: update to match current usage
2645 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2646 password, p4 binary, pollinterval, maximum history to check.
2647 Patch from an anonymous sf.net contributor, SF#1219384.
2648 * buildbot/process/step.py (P4Sync.__init__): add username,
2649 password, and client arguments.
2650 * buildbot/slave/commands.py (P4Sync): same
2652 2006-04-05 Brian Warner <warner@lothar.com>
2654 * buildbot/process/factory.py (BuildFactory.addStep): new method
2655 to add steps to a BuildFactory. Use it instead of f.steps.append,
2656 and you can probably avoid using the s() convenience function.
2657 Patch from Neal Norwitz, sf.net #1412605.
2658 (other): update all factories to use addStep
2659 * buildbot/process/process_twisted.py: update all factories to use
2662 2006-04-03 Brian Warner <warner@lothar.com>
2664 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2665 work under windows too. Adapted from a patch by Niklaus Giger,
2666 addresses SF#1463399.
2668 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2669 spawned commands emit parseable results in english and not some
2670 other language. Patch from Niklaus Giger, SF#1463395.
2672 * README (INSTALLATION): discourage users from running unit tests on
2673 a "network drive", patch from Niklaus Giger, SF#1463394.
2675 2006-03-22 Brian Warner <warner@lothar.com>
2677 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2678 function to turn a repository-relative pathname into a (branch,
2679 branch-relative-filename) tuple. Change this function to handle
2680 the branch naming policy used by your Subversion repository.
2681 Thanks to AllMyData.com for sponsoring this work.
2683 2006-03-16 Brian Warner <warner@lothar.com>
2685 * buildbot/scripts/sample.cfg: add python-mode declaration for
2686 vim. Thanks to John Pye for the patch.
2688 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2689 command line, mention the importance of running 'crontab' as the
2690 buildmaster/buildslave user. Thanks to John Pye for the catch.
2692 2006-03-13 Brian Warner <warner@lothar.com>
2694 * buildbot/status/words.py (IRC): add an optional password=
2695 argument, which will be sent to Nickserv in an IDENTIFY message at
2696 login, to claim the nickname. freenode requires this before the
2697 bot can sent (or reply to) private messages. Thanks to Clement
2698 Stenac for the patch.
2699 * docs/buildbot.texinfo (IRC Bot): document it
2701 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2702 larger than chunkSize. Fixes SF#1349253.
2703 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2704 (Log.testConsumer): update to match new internal chunking behavior
2706 2006-03-12 Brian Warner <warner@lothar.com>
2708 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2710 * buildbot/test/test_maildir.py (MaildirTest): rename the
2711 'timeout' method, as it collides with trial's internals
2713 * buildbot/scripts/runner.py: add 'buildbot restart' command
2714 (stop): don't sys.exit() out of here, otherwise restart can't work
2715 * docs/buildbot.texinfo (Shutdown): document it
2717 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2718 * buildbot/status/html.py (Waterfall.__init__): same
2719 * buildbot/process/builder.py (Builder.startBuild): same
2720 * buildbot/process/base.py (BuildRequest): same
2721 * buildbot/sourcestamp.py (SourceStamp): same
2722 * buildbot/scheduler.py (Nightly): same
2724 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2726 * docs/buildbot.texinfo: same
2728 2006-02-17 Brian Warner <warner@lothar.com>
2730 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2731 * docs/buildbot.texinfo: set version number to match
2732 * NEWS: update for 0.7.2
2734 2006-02-16 Brian Warner <warner@lothar.com>
2736 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2738 2006-02-09 Brian Warner <warner@lothar.com>
2740 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2741 add text to explain per-build branch parameters
2742 * NEWS: mention --umask
2744 2006-02-08 Brian Warner <warner@lothar.com>
2746 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2748 (SlaveOptions.optParameters): add --umask, to make it possible to
2749 make buildslave-generated files (including build products) be
2752 * buildbot/slave/bot.py (BuildSlave.startService): same
2754 2006-01-23 Brian Warner <warner@lothar.com>
2756 * buildbot/status/builder.py: urllib.quote() all URLs that include
2757 Builder names, so that builders can include characters like '/'
2758 and ' ' without completely breaking the resulting HTML. Thanks to
2759 Kevin Turner for the patch.
2760 * buildbot/status/html.py: same
2761 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2763 * NEWS: update in preparation for upcoming release
2765 2006-01-18 Brian Warner <warner@lothar.com>
2767 * docs/examples/twisted_master.cfg: update to match the Twisted
2768 buildbot: remove python2.2, switch to exarkun's buildslaves,
2769 disable the .deb builder until we figure out how to build twisted
2770 .debs from SVN, add some ktrace debugging to the OS-X build
2771 process and remove the qt build, remove threadless builders,
2772 change freebsd builder to use landonf's buildslave.
2774 2006-01-12 Brian Warner <warner@lothar.com>
2776 * buildbot/master.py (Manhole.__init__): let port= be a strports
2777 specification string, but handle a regular int for backwards
2778 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2779 used in master.cfg to limit connections to just the local host.
2780 (BuildMaster.loadConfig): same for c['slavePortnum']
2781 * buildbot/scheduler.py (Try_Userpass.__init__): same
2782 * buildbot/status/client.py (PBListener.__init__): same
2783 * buildbot/status/html.py (Waterfall.__init__): same, for both
2784 http_port and distrib_port. Include backwards-compatibility checks
2785 so distrib_port can be a filename string and still mean unix:/foo
2786 * docs/buildbot.texinfo (Setting the slaveport): document it
2787 (Debug options): same
2788 (HTML Waterfall): same
2791 * buildbot/test/test_config.py (ConfigTest): test it
2793 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2794 slaveport's disownServiceParent deferred to fire before opening
2795 the new one. Fixes an annoying bug in the unit tests.
2797 2006-01-03 Brian Warner <warner@lothar.com>
2799 * buildbot/master.py (BuildMaster): remove the .schedulers
2800 attribute, replacing it with an allSchedulers() method that looks
2801 for all IService children that implement IScheduler. Having only
2802 one parent/child relationship means fewer opportunities for bugs.
2803 (BuildMaster.allSchedulers): new method
2804 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2805 also fix ugly bug that caused any config-file reload to
2806 half-forget about the earlier Schedulers, causing an exception
2807 when a Change arrived and was handed to a half-connected
2808 Scheduler. The exception was in scheduler.py line 54ish:
2809 self.parent.submitBuildSet(bs)
2810 exceptions.AttributeError: 'NoneType' object has no attribute
2812 (BuildMaster.addChange): update to use allSchedulers()
2814 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2815 to work properly with twisted-1.3.0, where you must explicitly
2816 include the __implements__ from parent classes
2817 (BaseScheduler.__repr__): make it easier to distinguish distinct
2819 (BaseUpstreamScheduler.__implements__): same
2821 * buildbot/status/builder.py (Status.getSchedulers): update to
2823 * buildbot/test/test_run.py (Run.testMaster): same
2824 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2825 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2826 make sure Scheduler instances are left alone when an identical
2827 config file is reloaded
2828 (ConfigElements.testSchedulers): make sure Schedulers are properly
2831 * Makefile (TRIALARGS): my local default Twisted version is now
2832 2.1.0, update the trial arguments accordingly
2834 2005-12-22 Brian Warner <warner@lothar.com>
2836 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2839 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2840 addChange in the parent class, although I suspect this should be
2841 fixed better in the future.
2843 2005-11-26 Brian Warner <warner@lothar.com>
2845 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2846 explode when branch==None, thanks to Kevin Turner for the catch
2847 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2850 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2852 * docs/buildbot.texinfo: same
2854 2005-11-26 Brian Warner <warner@lothar.com>
2856 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2857 * docs/buildbot.texinfo: set version number to match
2859 2005-11-26 Brian Warner <warner@lothar.com>
2861 * NEWS: update for 0.7.1
2863 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2864 sure that unsubscribe works even if we never sent an ETA update.
2865 Also, don't explode on duplicate unsubscribe.
2866 (BuildStepStatus.addLog): make the convenience "return self"-added
2867 watcher automatically unsubscribe when the Step finishes.
2868 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2869 (BuildStatus.stepStarted): same auto-unsubscribe
2870 (BuilderStatus.buildStarted): same auto-unsubscribe
2872 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2874 (IStatusReceiver.stepStarted): same
2875 (IStatusReceiver.logStarted): same
2877 * buildbot/test/test_run.py (Status): move the Status test..
2878 * buildbot/test/test_status.py (Subscription): .. to here
2880 2005-11-25 Brian Warner <warner@lothar.com>
2882 * NEWS: more updates
2884 * buildbot/locks.py: fix the problem in which loading a master.cfg
2885 file that changes some Builders (but not all of them) can result
2886 in having multiple copies of the same Lock. Now, the real Locks
2887 are kept in a table inside the BotMaster, and the Builders/Steps
2888 use "LockIDs", which are still instances of MasterLock and
2889 SlaveLock. The real Locks are instances of the new RealMasterLock
2890 and RealSlaveLock classes.
2891 * buildbot/master.py (BotMaster.getLockByID): new method to
2892 convert LockIDs into real Locks.
2893 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2894 into real Locks before building
2895 * buildbot/process/step.py (BuildStep.startStep): same
2896 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2897 exercises the problem
2900 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2901 what Schedulers are available
2903 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2904 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2905 'cron'-style build scheduling at certain times of day, week,
2907 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2909 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2910 handling: treat self.fileIsImportant more as an attribute that
2911 contains a callable than as a method. If the attribute is None,
2912 don't call it and assume all filenames are important. It is still
2913 possible to provide a fileIsImportant method in a subclass,
2915 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2917 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2918 test using AnyBranchScheduler with fileIsImportant=None
2920 2005-11-24 Brian Warner <warner@lothar.com>
2922 * buildbot/test/test_config.py (StartService): don't claim a fixed
2923 port number, instead set slavePort=0 on the first pass, figure out
2924 what port was allocated, then switch to a config file that uses
2927 * buildbot/master.py (BuildMaster.loadConfig): close the old
2928 slaveport before opening the new one, because unit tests might
2929 replace slavePort=0 with the same allocated portnumber, and if we
2930 don't wait for the old port to close first, we get a "port already
2931 in use" error. There is a tiny race condition here, but the only
2932 threat is from other programs that bind (statically) to the same
2933 port number we happened to be allocated, and only if those
2934 programs use SO_REUSEADDR, and only if they get control in between
2937 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2939 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2940 deleted ChangeSources before adding any new ones
2941 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2942 compare_attrs, to make sure that a config-file reload does not
2943 unnecessarily replace an unmodified ChangeSource instance
2944 * buildbot/test/test_config.py (ConfigTest.testSources): update
2946 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2947 mean "don't build anything", and add a warning if it gets used
2948 because it isn't actually useful.
2950 * contrib/svn_buildbot.py: update example usage to match the port
2951 number that gets used by the PBChangeSource
2952 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2954 2005-11-22 Brian Warner <warner@lothar.com>
2956 * NEWS: start collecting items for next release
2958 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2959 revisions are strings
2960 (P4Sync.computeSourceRevision): same
2962 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2963 to the Buildbot's overall status page
2964 (StatusResourceBuilder.body): same
2966 2005-11-15 Brian Warner <warner@lothar.com>
2968 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2969 config-file loading, specifically to make sure old StatusTargets
2970 are finished shutting down before new ones start up (thus
2971 resolving a bug in which changing the Waterfall object would fail
2972 because both new and old instances were claiming the same
2973 listening port). Also load new Schedulers after all the new
2974 Builders are set up, in case they fire off a new build right away.
2975 * buildbot/test/test_config.py (StartService): test it
2977 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2978 the branch name to the mail body
2980 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2981 Without it, a config-file reload fails to update an existing
2983 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2984 username/passwd to compare_attrs, for the same reason
2985 * buildbot/status/html.py (Waterfall): add favicon to
2986 compare_attrs, same reason
2988 2005-11-05 Brian Warner <warner@lothar.com>
2990 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2991 baserev before stuffing it in the jobfile. This resolves problems
2992 under SVN (and probably Arch) where revisions are expressed as
2993 numbers. I'm inclined to use string-based revisions everywhere in
2994 the future, but this fix should be safe for now. Thanks to Steven
2995 Walter for the patch.
2997 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2998 binary mode when opening pickle files, to make windows work
2999 better. Thanks to Dobes Vandermeer for the catch.
3000 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3001 (BuilderStatus.getBuildByNumber): same
3002 (Status.builderAdded): same
3003 * buildbot/master.py (BuildMaster.loadChanges): same
3005 * buildbot/util.py (Swappable): delete unused leftover code
3007 * buildbot/process/step.py (SVN): when building on a non-default
3008 branch, add the word "[branch]" to the VC step's description, so
3009 it is obvious that we're not building the usual stuff. Likewise,
3010 when we are building a specific revision, add the text "rNNN" to
3011 indicate what that revision number is. Thanks to Brad Hards and
3012 Nathaniel Smith for the suggestion.
3013 (Darcs.startVC): same
3014 (Arch.startVC): same
3015 (Bazaar.startVC): same
3017 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3018 typo, caught by Mark Dillavou, closes SF#1216636.
3020 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3021 about a test to add some day
3023 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3024 the 'full-2.3' build, and the 'reactors' build is now run under
3025 python-2.4 because the buildslave no longer has gtk/etc bindings
3026 for earlier versions.
3028 2005-11-03 Brian Warner <warner@lothar.com>
3030 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3031 method, takes an IBuildStatus and rebuilds it. It might make more
3032 sense to add this to IBuildControl instead, but that instance goes
3033 away completely once the build has finished, and resubmitting
3034 builds can take place weeks later.
3035 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3036 * buildbot/status/html.py (StatusResourceBuild): also stash an
3037 IBuilderControl so we can use resubmitBuild.
3038 (StatusResourceBuild.body): render "resubmit" button if we can.
3039 Also add hrefs for each BuildStep
3040 (StatusResourceBuild.rebuild): add action for "resubmit" button
3041 (StatusResourceBuilder.getChild): give it an IBuilderControl
3043 * buildbot/status/builder.py (Status.getURLForThing): change the
3044 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3045 that live as targets of buttons like "stop" and "rebuild" can't
3047 * buildbot/status/builder.py (Status.getURLForThing): same
3048 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3049 (StepBox.getBox): same
3050 * buildbot/test/test_web.py (GetURL): same
3053 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3054 exclusivity checks after Source.__init__ upcall, so misspelled
3055 arguments will be reported more usefully
3056 (Darcs.__init__): same
3058 2005-10-29 Brian Warner <warner@lothar.com>
3060 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3061 builder. Move the Try scheduler off to a separate port.
3063 2005-10-27 Brian Warner <warner@lothar.com>
3065 * buildbot/clients/gtkPanes.py
3066 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3067 to cause the app to crash, now they don't.
3069 * buildbot/clients/debug.py: display the buildmaster's location
3070 in the window's title bar
3072 2005-10-26 Brian Warner <warner@lothar.com>
3074 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3075 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3076 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3078 * buildbot/status/html.py (td): put a single non-breaking space
3079 inside otherwise empty <td> elements, as a workaround for buggy
3080 browsers which would optimize them away (along with any associated
3081 styles, like the kind that create the waterfall grid borders).
3082 Patch from Frerich Raabe.
3084 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3085 argv-list as an argument, defaulting to ["-to"], which is
3086 appropriate for the Trial that comes with Twisted-2.1.0 and
3087 earlier. The Trial in current Twisted SVN wants
3088 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3089 defaults to an empty list.
3090 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3091 match it, now that trialMode= is a list instead of a single string
3093 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3095 * docs/buildbot.texinfo: same
3097 2005-10-24 Brian Warner <warner@lothar.com>
3099 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3100 * docs/buildbot.texinfo: set version number to match
3102 2005-10-24 Brian Warner <warner@lothar.com>
3104 * README: update for 0.7.0
3106 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3108 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3109 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3110 send the branch= argument unless the user really provided one, to
3111 retain compatibility with older buildmasters that don't accept
3113 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3116 * docs/buildbot.texinfo: update lots of stuff
3118 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3119 to the 'buildbot sendchange' command
3120 * buildbot/clients/sendchange.py (Sender.send): same
3121 * buildbot/changes/pb.py (ChangePerspective): same
3122 * buildbot/test/test_changes.py (Sender.testSender): test it
3124 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3125 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3126 for consistency with other BuildStep arguments that use camelCase.
3127 Well, at least more of them use camelCase (like flunkOnWarnings)
3128 than don't.. I wish I'd picked one style and stuck with it
3129 earlier. Annoying, but it's best done before the release, since
3130 these arguments didn't exist at all in 0.6.6 .
3132 * buildbot/test/test_vc.py (SVN.testCheckout): same
3133 (Darcs.testPatch): same
3134 * docs/buildbot.texinfo (SVN): document the change
3135 (Darcs): same, add some build-on-branch docs
3136 * docs/examples/twisted_master.cfg: match change
3138 * buildbot/process/step.py (BuildStep): rename
3139 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3140 how it is normally used.
3141 * buildbot/test/test_steps.py (Version.checkCompare): same
3143 * buildbot/process/step.py (CVS.startVC): refuse to build
3144 update/copy -style builds on a non-default branch with an old
3145 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3146 concern is that it will do a VC 'update' in an existing tree when
3147 it is supposed to be switching branches (and therefore clobbering
3148 the tree to do a full checkout), thus building the wrong source.
3149 This used to be a warning, but I think the confusion it is likely
3150 to cause warrants making it an error.
3151 (SVN.startVC): same, also make mode=export on old slaves an error
3152 (Darcs.startVC): same
3153 (Git.startVC): improve error message for non-Git-enabled slaves
3154 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3155 specific revision is built on a slave that doesn't pay attention
3156 to args['revision'], because for slowly-changing trees it will
3157 probably do the right thing, and because we have no way to tell
3158 whether we're asking it to build the most recent version or not.
3159 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3161 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3162 that 'master' is in host:portnum format, to catch errors sooner
3164 2005-10-23 Brian Warner <warner@lothar.com>
3166 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3167 when creating the list of warning messages, include the line
3168 immediately after each WARNING: line, since that's usually where
3169 the file and line number wind up.
3171 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3176 2005-10-22 Brian Warner <warner@lothar.com>
3178 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3179 patch from Brad Hards
3180 * buildbot/status/classic.css: same
3181 * buildbot/test/test_web.py (Waterfall): match changes
3183 * buildbot/test/test_steps.py (BuildStep.setUp): set
3184 nextBuildNumber so the test passes
3185 * buildbot/test/test_status.py (MyBuilder): same
3187 * buildbot/status/html.py (StatusResourceBuild.body): revision
3188 might be numeric, so stringify it before html-escapifying it
3189 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3190 timer for the upcoming build
3191 * buildbot/status/classic.css: add background-color attributes for
3192 offline/waiting/building classes
3194 * buildbot/status/builder.py (BuildStatus): derive from
3195 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3196 the default (i.e. unknown) .slavename to "???" instead of None,
3197 since even unknown slavenames need to be printed eventually.
3198 (BuilderStatus): also derive from styles.Versioned . More
3199 importantly, determine .nextBuildNumber at creation/unpickling
3200 time by scanning the directory of saved BuildStatus instances and
3201 choosing one larger than the highest-numbered one found. This
3202 should fix the problem where random errors during upgrades cause
3203 the buildbot to forget about earlier builds. .nextBuildNumber is
3204 no longer stored in the pickle.
3205 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3206 at least log the error. Also call Builder.determineNextBuildNumber
3207 once the basedir is set.
3209 * buildbot/master.py (BuildMaster.loadChanges): do
3210 styles.doUpgrade afterwards, in case I decide to make Changes
3211 derived from styles.Versioned some day and forget to make this
3215 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3216 when running under older pythons (<2.3) in which the shlex module
3217 doesn't have a 'split' function.
3219 * buildbot/process/step.py (ShellCommand.start): make
3220 errorMessages= be a list of strings to stuff in the log before the
3221 command actually starts. This makes it easier to flag multiple
3222 warning messages, e.g. when the Source steps have to deal with an
3224 (CVS.startVC): handle slaves that don't handle multiple branches
3225 by switching into 'clobber' mode
3226 (SVN.startVC): same. Also reject branches without base_url
3227 (Darcs.startVC): same. Also reject revision= in older slaves
3228 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3229 (Bazaar.startVC): same, and test for baz separately than for arch
3231 * buildbot/slave/commands.py (cvs_ver): document new features
3233 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3234 (BuildStep.slaveVersionNewEnough): more useful utility method
3235 * buildbot/test/test_steps.py (Version): start testing it
3237 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3238 the 'force' command requires python2.3, for the shlex.split method
3240 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3241 since we don't use it anymore. The Twisted buildbot uses a
3244 2005-10-21 Brian Warner <warner@lothar.com>
3246 * buildbot/process/process_twisted.py: rework all BuildFactory
3247 classes to take a 'source' step as an argument, instead of
3248 building up the SVN instance in the factory.
3249 * docs/examples/twisted_master.cfg: enable build-on-branch by
3250 providing a base_url and default_branch
3252 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3253 control over --branch and --revision, not that they are always
3255 * buildbot/status/html.py (StatusResourceBuilder.force): same
3256 (StatusResourceBuild.body): display SourceStamp components
3258 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3259 IRC 'force' command, so it can be shared with an eventual
3260 command-line-tool 'buildbot force' mode.
3261 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3263 2005-10-20 Brian Warner <warner@lothar.com>
3265 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3267 * docs/examples/twisted_master.cfg: update to use Schedulers
3269 * buildbot/scripts/sample.cfg: update with Schedulers
3271 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3272 method specifically for use by HTML "force build" button and the
3273 IRC "force" command. Raises an immediate error if there are no
3275 (IBuilderControl.requestBuild): make this just submit a build, not
3276 try to check for existing slaves or set up any when-finished
3277 Deferreds or anything.
3278 * buildbot/process/builder.py (BuilderControl): same
3279 * buildbot/status/html.py (StatusResourceBuilder.force): same
3280 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3281 * buildbot/test/test_slaves.py: same
3282 * buildbot/test/test_web.py: same
3284 2005-10-19 Brian Warner <warner@lothar.com>
3286 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3287 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3289 2005-10-18 Brian Warner <warner@lothar.com>
3291 * buildbot/status/html.py: provide 'status' argument to most
3292 StatusResourceFOO objects
3293 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3294 and Logfiles" section to make the Build page into a more-or-less
3295 comprehensive source of status information about the build
3297 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3298 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3300 2005-10-17 Brian Warner <warner@lothar.com>
3302 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3303 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3304 out what to do about other projects: the correct options for
3305 recent Twisteds will not work for older ones.
3307 2005-10-15 Brian Warner <warner@lothar.com>
3309 * buildbot/status/builder.py (Status.getURLForThing): add method
3310 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3311 use this in email/IRC status clients to make them more useful, by
3312 providing the end user with hints on where to learn more about the
3313 object being reported on.
3314 * buildbot/test/test_web.py (GetURL): tests for it
3316 2005-10-14 Brian Warner <warner@lothar.com>
3318 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3319 fix bug resulting from deferredResult changes
3321 2005-10-13 Brian Warner <warner@lothar.com>
3323 * buildbot/test/test_changes.py: remove use of deferredResult
3324 * buildbot/test/test_config.py: same
3325 * buildbot/test/test_control.py: same
3326 * buildbot/test/test_status.py: same
3327 * buildbot/test/test_vc.py: this is the only remaining use, since
3328 it gets used at module level. This needs to be replaced by some
3329 sort of class-level run-once routine.
3331 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3333 * lots: implement multiple slaves per Builder, which means multiple
3334 current builds per Builder. Some highlights:
3335 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3336 of (state,currentBuilds) instead of (state,currentBuild)
3337 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3338 (IBuildStatus.getSlavename): new method, so you can tell which
3339 slave got used. This only gets set when the build completes.
3340 (IBuildRequestStatus.getBuilds): new method
3342 * buildbot/process/builder.py (SlaveBuilder): add a .state
3343 attribute to track things like ATTACHING and IDLE and BUILDING,
3345 (Builder): .. the .slaves attribute here, which has been turned
3346 into a simple list of available slaves. Added a separate
3347 attaching_slaves list to track ones that are not yet ready for
3349 (Builder.fireTestEvent): put off the test-event callback for a
3350 reactor turn, to make tests a bit more consistent.
3351 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3352 ping fails due to an exception. This needs work, I'm worried that
3353 a code error could lead to a constantly re-connecting slave.
3354 Especially since I'm trying to move to a distinct remote_ping
3355 method, separate from the remote_print that we currently use.
3356 (BuilderControl.requestBuild): return a convenience Deferred that
3357 provides an IBuildStatus when the build finishes.
3358 (BuilderControl.ping): ping all connected slaves, only return True
3359 if they all respond.
3361 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3362 reconnect when we shut down.
3364 * buildbot/status/builder.py: implement new methods, convert
3365 one-build-at-a-time methods to handle multiple builds
3366 * buildbot/status/*.py: do the same in all default status targets
3367 * buildbot/status/html.py: report the build's slavename in the
3368 per-Build page, report all buildslaves on the per-Builder page
3370 * buildbot/test/test_run.py: update/create tests
3371 * buildbot/test/test_slaves.py: same
3372 * buildbot/test/test_scheduler.py: remove stale test
3374 * docs/buildbot.texinfo: document the new builder-specification
3375 'slavenames' parameter
3377 2005-10-12 Brian Warner <warner@lothar.com>
3379 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3380 report failure correctly, causing Dependent builds to run when
3381 they shouldn't have.
3382 * buildbot/status/builder.py (BuildSetStatus): same
3383 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3384 (Set.testSuccess): test the both-pass case too
3385 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3386 fix this test: it was ending too early, masking the failure before
3387 (Logger): specialized StatusReceiver to make sure the dependent
3388 builds aren't even started, much less completed.
3390 2005-10-07 Brian Warner <warner@lothar.com>
3392 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3393 bot.SlaveBuilder being disowned in the middle of a build
3395 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3396 this inherit from StatusReceiver. Also upcall in __init__. This
3397 fixes the embarrasing crash when the new buildSetSubmitted method
3398 is invoked and Waterfall/etc don't implement their own.
3399 * buildbot/test/test_run.py: add a TODO note about a test to catch
3400 just this sort of thing.
3402 * buildbot/process/builder.py (Builder.attached): remove the
3403 already-attached warning, this situation is normal. Add some
3404 comments explaining it.
3406 2005-10-02 Brian Warner <warner@lothar.com>
3408 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3409 OverflowError when setting up dnotify, because some 64-bit systems
3410 have problems with signed-vs-unsigned constants and trip up on the
3411 DN_MULTISHOT flag. Patch from Brad Hards.
3413 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3415 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3416 progressMetrics, description, descriptionDone to the 'parms' list,
3417 and make use the 'parms' list from the implementation class
3418 instead of only BuildStep to initialize the parameters. This
3419 allows buildbot.process.factory.s() to initialize all the parms,
3420 not just those defined in directly by BuildStep.
3422 2005-09-03 Brian Warner <warner@lothar.com>
3424 * NEWS: start adding items for the next release
3426 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3427 python2.2 tests, change 'Quick' builder to only use python2.3
3429 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3431 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3432 the "Ping Builder" button if the build control is available; the
3433 user sees an exception otherwise
3435 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3437 2005-09-01 Brian Warner <warner@lothar.com>
3439 * buildbot/interfaces.py (IBuilderStatus.getState): update
3440 signature, point out that 'build' can be None
3441 (IBuildStatus.getETA): point out ETA can be none
3443 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3445 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3447 2005-08-31 Brian Warner <warner@lothar.com>
3449 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3450 update to match correct signature: removed 'eta' argument
3451 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3453 2005-08-30 Brian Warner <warner@lothar.com>
3455 * buildbot/status/builder.py (LogFile): remove the assertion that
3456 blows up when you try to overwrite an existing logfile, instead
3457 just emit a warning. This case gets hit when the buildmaster is
3458 killed and doesn't get a chance to write out the serialized
3459 BuilderStatus object, so the .nextBuildNumber attribute gets out
3462 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3463 the 'buildbot sendchange' arguments, for the Darcs context file
3464 * docs/buildbot.texinfo (sendchange): document it
3466 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3467 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3468 (IStatus.getSchedulers): new method
3469 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3470 (Status.getSchedulers): implement
3471 * buildbot/process/builder.py (Builder): maintain
3472 BuilderStatus.pendingBuilds
3473 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3474 (TryBase.addChange): Try schedulers should ignore Changes
3476 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3477 for 'try' on CVS/SVN
3478 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3480 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3481 report status properly.
3482 (Try.createJob): implement unique buildset IDs
3484 * buildbot/status/client.py (StatusClientPerspective): add a
3485 perspective_getBuildSets method for the benefit of jobdir-style
3487 * docs/buildbot.texinfo (try): more docs
3488 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3491 2005-08-18 Brian Warner <warner@lothar.com>
3493 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3494 actually work. It's functional but still kind of clunky. Also, it
3495 only works with the pb-style.. needs to be made to work with the
3498 * buildbot/status/client.py (RemoteBuildSet): new class
3499 (RemoteBuildRequest): same
3500 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3501 object, not the internal BuildStatus object.
3502 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3503 outside of the usual buildStarted() return value.
3504 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3506 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3507 (Try_Userpass_Perspective.perspective_try): return a remotely
3508 usable BuildSetStatus object
3510 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3511 isStarted()/waitUntilStarted()
3513 2005-08-16 Brian Warner <warner@lothar.com>
3515 * buildbot/status/builder.py: implement IBuildSetStatus and
3516 IBuildRequestStatus, wire them into place.
3517 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3518 methods into the BuildSetStatus object.
3519 * buildbot/interfaces.py: same
3520 (IStatus.getBuildSets): new method to get pending BuildSets
3521 (IStatusReceiver.buildsetSubmitted): new method which hears about
3523 * buildbot/master.py (BuildMaster.submitBuildSet): same
3524 * buildbot/process/base.py (BuildRequest): same, replace
3525 waitUntilStarted with subscribe/unsubscribe
3526 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3527 subscribe instead of waitUntilStarted
3528 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3530 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3532 * buildbot/test/test_buildreq.py: update for new code
3533 * buildbot/test/test_control.py (Force.testRequest): same
3536 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3537 for Darcs to not use the tempfile module, so it works under
3538 python-2.2 too. We really didn't need the full cleverness of that
3539 module, since the slave has exclusive control of its own builddir.
3541 2005-08-15 Brian Warner <warner@lothar.com>
3543 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3544 for CVS trees. It doesn't work for non-trunk branches,
3546 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3549 * Makefile: make it easier to test against python2.2
3551 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3552 tearDown2, so things like Arch can unregister archives as they're
3553 shutting down. The previous subclass-override-tearDown technique
3554 resulted in a nested maybeWait() and test failures under
3557 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3558 where we can (Arch), add a branch= argument to set the branch used
3560 (BazExtractor): extract the branch too
3561 (TlaExtractor): same
3562 * buildbot/scripts/runner.py (TryOptions): add --branch
3563 * docs/buildbot.texinfo (try): document --branch/try_branch
3565 * buildbot/slave/commands.py (Darcs): implement get-revision for
3566 Darcs, so that 'try' will work. This requires the tempfile module
3569 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3570 of revisions, branches, and 'try' in the process.
3572 2005-08-11 Brian Warner <warner@lothar.com>
3574 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3575 this, it got broken at some point in the last few releases
3576 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3577 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3578 specifically the removal of ETA information from the tuple
3580 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3583 * docs/buildbot.texinfo (try): document both --builder and
3584 'try_builders' in .buildbot/options
3585 * buildbot/scripts/runner.py (TryOptions): add --builder,
3586 accumulate the values into opts['builders']
3587 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3588 * buildbot/test/test_runner.py (Try): add some quick tests to make
3589 sure 'buildbot try --options' and .buildbot/options get parsed
3590 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3591 use --builder control
3593 * docs/buildbot.texinfo (try): add --port argument to PB style
3595 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3596 actual SourceStamp. Still need to extract a branch name, somehow.
3597 (Try): finish implementing the try client side, still need a UI
3598 for specifying which builders to use
3599 (Try.getopt): factor our options/config-file reading
3600 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3602 * buildbot/test/test_vc.py: match SourceStampExtractor change
3604 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3605 causes the twisted log to be sent to stderr
3607 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3609 2005-08-10 Brian Warner <warner@lothar.com>
3611 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3612 style is 90% done, still missing status reporting or waiting for
3613 the buildsets to finish, and it is completely untested.
3615 * buildbot/trybuild.py: delete file, move contents to ..
3616 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3617 * buildbot/test/test_vc.py: match the move
3619 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3620 of the TryScheduler, no buildsetID or status-tracking support yet
3621 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3623 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3624 possible to set the basedir after __init__ time, so it is easier
3625 to use as a Service-child of the BuildMaster instance
3627 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3628 that delivers messages to its Service parent instead of requiring
3629 a subclass to be useful. This turns out to be much easier to build
3632 * buildbot/scripts/tryclient.py (createJob): utility code to
3633 create jobfiles, will eventually be used by 'buildbot try'
3635 2005-08-08 Brian Warner <warner@lothar.com>
3637 * docs/buildbot.texinfo (try): add docs on the
3638 as-yet-unimplemented Try scheduler
3640 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3641 * buildbot/test/test_scheduler.py: .. here
3642 (Scheduling.testTryJobdir): add placeholder test for 'try'
3644 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3645 addEntry merging (>=chunkSize) behavior
3646 (Log.testConsumer): update to handle new callLater(0) behavior
3648 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3649 both the MAX_LENGTH bugfix and the resumeProducing hang.
3651 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3652 put off the actual resumeProducing for a moment with
3653 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3654 causes large logfiles to hang midway through.
3656 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3657 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3658 and to improve memory usage when streaming the file out to a web
3660 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3661 make this work cleanly
3663 2005-08-03 Brian Warner <warner@lothar.com>
3665 * buildbot/trybuild.py: new file for 'try' utilities
3666 (getSourceStamp): run in a tree, find out the baserev+patch
3667 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3668 implemented for SVN and Darcs, still working on Arch. I don't know
3669 how to make CVS work yet.
3671 * docs/buildbot.texinfo: document the 'buildbot' command-line
3672 tool, including the not-yet-implemented 'try' feature, and the
3673 in-flux .buildbot/ options directory.
3675 2005-07-20 Brian Warner <warner@lothar.com>
3677 * buildbot/locks.py: added temporary id() numbers to Lock
3678 descriptions, to track down a not-really-sharing-the-Lock bug
3680 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3682 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3683 needed for python2.2 compatibility
3684 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3685 are from the __future__
3687 2005-07-19 Brian Warner <warner@lothar.com>
3689 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3690 message when schedulers use unknown builders
3692 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3693 SlaveLock('name') and MasterLock('name') are distinct
3695 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3696 c['schedulers'] in such a way that we can actually accept
3698 * buildbot/test/test_config.py: check it
3700 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3701 utility method to *all* the Schedulers
3702 (Periodic.listBuilderNames): same
3704 * docs/buildbot.texinfo (Interlocks): update chapter to match
3707 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3708 to make sure that c['sources'], c['schedulers'], and c['status']
3709 are all lists of the appropriate objects, and that the Schedulers
3710 all point to real Builders
3711 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3712 'listBuilderNames' utility method to support this
3713 * buildbot/scheduler.py: implement the utility method
3714 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3716 * docs/buildbot.texinfo: add some @cindex entries
3718 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3719 if it wasn't already set: most tla commands will fail unless one
3721 (Arch.createRepository): and disable bazaar's revision cache, since
3722 they cause test failures (the multiple repositories we create all
3723 interfere with each other through the cache)
3725 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3726 bring it properly up to date with twisted-2.0 test guidelines
3728 * buildbot/master.py (BuildMaster): remove references to old
3729 'interlock' module, this caused a bunch of post-merge test
3731 * buildbot/test/test_config.py: same
3732 * buildbot/process/base.py (Build): same
3734 * buildbot/test/test_slaves.py: stubs for new test case
3736 * buildbot/scheduler.py: add test-case-name tag
3737 * buildbot/test/test_buildreq.py: same
3739 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3740 unnecessary init code
3741 (Bot.remote_setBuilderList): match it
3743 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3745 * buildbot/changes/mail.py (parseSyncmail): update comment
3747 * buildbot/test/test_slavecommand.py: disable Shell tests on
3748 platforms that don't suport IReactorProcess
3750 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3751 all places where we open logfiles. It causes OS-X to open the file
3752 in some weird mode that that prevents us from mixing reads and
3753 writes to the same filehandle, which we depend upon to implement
3754 _generateChunks properly. This change doesn't appear to break
3755 win32, on which "b" and "t" are treated differently but a missing
3756 flag seems to be interpreted as "t".
3758 2005-07-18 Brian Warner <warner@lothar.com>
3760 * buildbot/slave/commands.py (ShellCommand): overhaul
3761 error-handling code, to try and make timeout/interrupt work
3762 properly, and make win32 happier
3763 * buildbot/test/test_slavecommand.py: clean up, stop using
3764 reactor.iterate, add tests for timeout and interrupt
3765 * buildbot/test/sleep.py: utility for a new timeout test
3767 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3768 code from the local-usebranches branch
3770 2005-07-17 Brian Warner <warner@lothar.com>
3772 * buildbot/process/process_twisted.py
3773 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3774 minutes, to match the other twisted BuildFactories, and don't
3775 excuse failures in c/qt/win32 reactors any more.
3777 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3778 'freebsd' builders, since the buildslaves have been unavailable
3781 2005-07-13 Brian Warner <warner@lothar.com>
3783 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3784 build-on-branch feature
3786 * buildbot/process/step.py (Darcs.__init__): add base_url and
3787 default_branch arguments, just like SVN
3788 (Arch.__init__): note that the version= argument is really the
3791 * buildbot/slave/commands.py (SourceBase): keep track of the
3792 repository+branch that was used for the last checkout in
3793 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3794 match, we clobber the directory and perform a fresh checkout
3795 rather than trying to do an in-place update. This should protect
3796 us against trying to get to branch B by doing an update in a tree
3797 obtained from branch A.
3798 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3799 (SVN.setup): same, just the svnurl
3800 (Darcs.setup): same, just the repourl
3801 (Arch.setup): same, arch coordinates (url), version, and
3802 buildconfig. Also pull the buildconfig from the args dictionary,
3803 which we weren't doing before, so the build-config was effectively
3805 (Arch.sourcedirIsUpdateable): don't try to update when we're
3806 moving to a specific revision: arch can't go backwards, so it is
3807 safer to just clobber the tree and checkout a new one at the
3809 (Bazaar.setup): same sourcedata as Arch
3811 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3812 use maybeWait, to work with twisted-1.3.0 and twcompat
3813 (Dependencies.testRun_Pass): same
3815 * buildbot/test/test_vc.py: rearrange, cleanup
3817 * buildbot/twcompat.py: add defer.waitForDeferred and
3818 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3819 can work under twisted-1.3.0 .
3821 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3822 now created at setUp time. This increases the runtime of the test
3823 suite considerably (from 91 seconds to 151), but it removes the
3824 need for an offline tarball, which should solve a problem I've
3825 seen where the test host has a different version of svn than the
3826 tarball build host. The new code also validates that mode=update
3827 really picks up recent commits. This approach will also make it
3828 easier to test out branches, because the code which creates the VC
3829 branches is next to the code which uses them. It will also make it
3830 possible to test some change-notification hooks, by actually
3831 performing a VC commit and watching to see the ChangeSource get
3834 2005-07-12 Brian Warner <warner@lothar.com>
3836 * docs/buildbot.texinfo (SVN): add branches example
3837 * docs/Makefile (buildbot.ps): add target for postscript manual
3839 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3840 * buildbot/test/test_locks.py: same
3842 * buildbot/process/step.py (Darcs): comment about default branches
3844 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3845 c['interlocks'] in the config file, complain if it is present.
3846 Scan all locks in c['builders'] to make sure the Locks they use
3848 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3849 add some tests to check for non-uniquely-named Locks
3850 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3851 since the unique-Lock validation code requires it now
3853 * buildbot/locks.py: fix test-case-name
3855 * buildbot/interlock.py: remove old file
3857 2005-07-11 Brian Warner <warner@lothar.com>
3859 * buildbot/test/test_interlock.py: rename to..
3860 * buildbot/test/test_locks.py: .. something shorter
3862 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3863 versions (after 2.0.1) changed internet.TCPClient to shut down the
3864 connection in stopService. Change the code to handle this
3867 * buildbot/process/base.py (Build): handle whole-Build locks
3868 * buildbot/process/builder.py (Builder.compareToSetup): same
3869 * buildbot/test/test_interlock.py: make tests work
3871 * buildbot/process/step.py (BuildStep.startStep): complain if a
3872 Step tries to claim a lock that's owned by its own Build
3873 (BuildStep.releaseLocks): typo
3875 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3876 file reloads don't replace unchanged Builders
3878 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3879 rewrite to cover new Locks instead of old c['interlocks']
3880 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3884 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3885 start the master and connect the buildslave
3887 * buildbot/process/step.py (FailingDummy.done): finish with a
3888 FAILURE status rather than raising an exception
3890 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3891 stringify a BuildRequest.reason that is None
3893 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3895 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3896 allow scheduler.Dependent to work
3897 * buildbot/buildset.py (BuildSet): set .reason and .results
3899 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3900 slaves, to make the test stop hanging. It still fails, of course,
3901 because I haven't even started to implement Locks.
3903 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3905 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3906 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3907 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3908 (Dependent): new class for downstream build dependencies
3909 * buildbot/test/test_dependencies.py: tests (still failing)
3911 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3913 2005-07-07 Brian Warner <warner@lothar.com>
3915 * buildbot/test/runutils.py (RunMixin): factored this class out..
3916 * buildbot/test/test_run.py: .. from here
3917 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3918 added new buildbot.locks tests (which all hang right now)
3919 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3920 * buildbot/process/step.py: claim/release per-BuildStep locks
3922 * docs/Makefile: add 'buildbot.html' target
3924 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3925 interpreted as "HEAD", so that all VC steps can accept branch=None
3926 and have it mean the "default branch".
3928 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3930 2005-07-07 Brian Warner <warner@lothar.com>
3932 * docs/examples/twisted_master.cfg: update to match current usage
3934 * docs/buildbot.texinfo (System Architecture): comment out the
3935 image, it doesn't exist yet and just screws up the HTML manual.
3937 2005-07-05 Brian Warner <warner@lothar.com>
3939 * debian/.cvsignore: oops, missed one. Removing leftover file.
3941 2005-06-17 Brian Warner <warner@lothar.com>
3943 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3944 changed its output in 1.2.0, don't mistakenly think that the
3945 subversion we find isn't capable of supporting our tests.
3947 * debian/*: remove the debian/ directory and its contents, to make
3948 life easier for the proper Debian maintainer
3950 * Makefile (release): same
3952 2005-06-07 Brian Warner <warner@lothar.com>
3954 * everything: create a distinct SourceStamp class to replace the
3955 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3956 Changed the signature of Source.startVC to include the revision
3957 information (instead of passing it through self.args). Implement
3958 branches for SVN (now only Darcs/Git is missing support). Add more
3961 2005-06-06 Brian Warner <warner@lothar.com>
3963 * everything: rearrange build scheduling. Create a new Scheduler
3964 object (configured in c['schedulers'], which submit BuildSets to a
3965 set of Builders. Builders can now use multiple slaves. Builds can
3966 be run on alternate branches, either requested manually or driven
3967 by changes. This changed some of the Status classes. Interlocks
3968 are out of service until they've been properly split into Locks
3969 and Dependencies. treeStableTimer, isFileImportant, and
3970 periodicBuild have all been moved from the Builder to the
3972 (BuilderStatus.currentBigState): removed the 'waiting' and
3973 'interlocked' states, removed the 'ETA' argument.
3975 2005-05-24 Brian Warner <warner@lothar.com>
3977 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3978 erroneously abandons the connection (in clientConnectionFailed)
3979 for non-UserErrors, which means that if we lose the connection due
3980 to a network problem or a timeout, we'll never try to reconnect.
3981 Fix this by not upcalling to the buggy parent method. Note:
3982 twisted-2.0 fixes this, but the function only has 3 lines so it
3983 makes more sense to copy it than to try and detect the buggyness
3984 of the parent class. Fixes SF#1207588.
3986 * buildbot/changes/changes.py (Change.branch): doh! Add a
3987 class-level attribute to accomodate old Change instances that were
3988 pickled before 0.6.5 (where .branch was added for new Changes).
3989 This fixes the exception that occurs when you try to look at an
3990 old Change (through asHTML).
3992 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3995 2005-05-23 Brian Warner <warner@lothar.com>
3997 * buildbot/__init__.py (version): release 0.6.6
3999 2005-05-23 Brian Warner <warner@lothar.com>
4001 * NEWS: update for 0.6.6 release
4002 * debian/changelog: same
4004 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4005 before starting: this was done by twistd back when we spawned it,
4006 now that we're importing the pieces and running them in the
4007 current process, we have to do it ourselves. This allows
4008 master.cfg to import files from the same directory without
4009 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4010 Stichele for the catch.
4011 (Options.opt_version): Add a --version command (actually, just make
4012 the existing --version command emit Buildbot's version too)
4014 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4015 fix to make this behave like other LogFiles, this time to handle
4016 existing LogFiles on disk. (add the missing .upgrade method)
4017 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4019 2005-05-21 Brian Warner <warner@lothar.com>
4021 * buildbot/test/test_runner.py (Create.testMaster): match the
4022 rawstring change in runner.py:masterTAC
4024 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4025 TwistedWords is installed
4026 * buildbot/test/test_status.py: same, with TwistedMail
4028 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4029 some old, deprecated, and removed config keys). This should enable
4030 you to use the base buildbot functionality with Twisted-2.0.0 when
4031 you don't also have TwistedWeb and TwistedWords installed
4033 2005-05-20 Brian Warner <warner@lothar.com>
4035 * buildbot/scripts/runner.py (run): call sendchange(), not
4036 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4037 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4038 (stop): don't wait for process to die when sending SIGHUP
4039 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4040 directory name gets interpreted, which you don't want
4043 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4046 2005-05-18 Brian Warner <warner@lothar.com>
4048 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4050 2005-05-18 Brian Warner <warner@lothar.com>
4052 * README: update for 0.6.5
4053 * debian/changelog: same
4055 * buildbot/changes/changes.py: rename tag= to branch=, since
4056 that's how we're using it, and my design for the upcoming "build a
4057 specific branch" feature wants it. also, tag= was too CVS-centric
4058 * buildbot/changes/mail.py (parseSyncmail): same
4059 * buildbot/process/base.py (Build.isBranchImportant): same
4060 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4061 * docs/buildbot.texinfo (Attributes of Changes): same
4063 * NEWS: update tag=, update for upcoming release
4065 2005-05-17 Brian Warner <warner@lothar.com>
4067 * buildbot/scripts/runner.py (stop): actually poll once per
4068 second, instead of re-killing the poor daemon once per second.
4069 Sleep briefly (0.1s) before the first poll, since there's a good
4070 chance we can avoid waiting the full second if the daemon shuts
4071 down quickly. Also remove the sys.exit() at the end.
4072 (start): remove the unneighborly sys.exit()
4074 * Makefile: improve permission-setting to not kick Arch so badly
4076 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4077 default --keepalive=600, since it doesn't hurt very much, and it's
4078 a hassle to discover that you need it.
4079 * buildbot/test/test_runner.py (Create.testSlave): test it
4081 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4082 IRC bot about EXCEPTION
4084 * buildbot/status/client.py (PBListener): upcall more correctly
4086 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4087 an exception mark the overall build with EXCEPTION, not SUCCESS
4089 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4091 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4092 * Makefile: update some release-related stuff
4094 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4095 gets called when there isn't actually an active process, just end
4096 the Command instead of blowing up. I don't know how it gets into
4097 this state, but the twisted win32 buildslave will sometimes hang,
4098 and when it shakes its head and comes back, it thinks it's still
4099 running a Command. The next build causes this command to be
4100 interrupted, but the lack of self.process.pid breaks the interrupt
4103 * NEWS: document changes since the last release
4105 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4106 look for Makefile.buildbot instead of a bare Makefile . The
4107 'buildbot start' does not install this file, so you have to
4108 manually copy it if you want to customize startup behavior.
4109 (createMaster): change 'buildbot master' command to create
4110 Makefile.sample instead of Makefile, to create master.cfg.sample
4111 instead of master.cfg (requiring you to copy it before the
4112 buildmaster can be started). Both sample files are kept up to
4113 date, i.e. they are overwritten if they have been changed. The
4114 'buildbot.tac' file is *not* overwritten, but if the new contents
4115 don't match the old, a 'buildbot.tac.new' file is created and the
4116 user is warned. This seems to be a much more sane way to handle
4117 startup files. Also, don't sys.exit(0) when done, so we can run
4118 unit tests against it.
4119 (createSlave): same. Don't overwrite the sample info/ files.
4120 * buildbot/scripts/sample.mk: remove. the contents were pulled
4121 into runner.py, since they need to match the behavior of start()
4125 * docs/buildbot.texinfo (Launching the daemons): document it
4126 * buildbot/test/test_runner.py (Create): test it
4128 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4129 version that can handle string-in-string tests, because otherwise
4130 python-2.2 fails the tests. It'd be tremendous if Trial's test
4131 took two strings under 2.2 too.
4133 * everything: fixed all deprecation warnings when running against
4134 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4135 few that come from Twisted itself). This involved putting most of
4136 the Twisted-version specific code in the new buildbot.twcompat
4137 module, and creating some abstract base classes in
4138 buildbot.changes.base and buildbot.status.base (which might be
4139 useful anyway). __implements__ is a nuisance and requires an ugly
4140 'if' clause everywhere.
4142 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4143 delay before finishing the test: it seems that smtp.sendmail
4144 doesn't hang up on the server, so we must wait a moment so it can
4145 hang up on us. This removes the trial warning about an unclean
4148 2005-05-16 Brian Warner <warner@lothar.com>
4150 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4151 tuple of (delay, repeats).
4152 * buildbot/test/test_vc.py (Retry): test it
4153 * docs/buildbot.texinfo (Source Checkout): document it
4154 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4155 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4156 doVCFull() are handled by re-trying the checkout (after a delay)
4157 some number of times.
4158 (ShellCommand._startCommand): make header lines easier to read
4160 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4162 (WebTest.test_logfile): make sure master gets shut down, silences
4163 some "unclean reactor" test errors
4165 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4166 reactor once after shutdown, something in certain versions of
4167 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4168 fails, svn-trunk is ok.
4170 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4171 second win32 error message
4173 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4174 validating the ETA, so the tests don't fail on slow systems
4176 2005-05-15 Brian Warner <warner@lothar.com>
4178 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4179 the new LogFile class, so upgrading works properly
4180 (LogFileProducer.resumeProducing): survive resumeProducing after
4181 we've exhausted the chunkGenerator
4183 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4185 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4186 (Log.testUpgrade): same
4188 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4189 Builds and logs with a cron job.
4191 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4192 of the old non-offline LogFile, added code to upgrade these to
4193 new-style contents-live-on-disk instances at load time (in a way
4194 that doesn't invalidate the old Build pickles, so upgrading to
4195 0.6.5 is not a one-way operation). Got rid of everything related
4197 (LogFile.__init__): create LogFiles with the parent step status,
4198 the log's name, and a builder-relative filename where it can keep
4199 the contents on disk.
4200 (LogFile.hasContents): new method, clients are advised to call it
4201 before getText or getChunks and friends. If it returns False, the
4202 log's contents have been deleted and getText() will raise an
4204 (LogFile.getChunks): made it a generator
4205 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4206 Consumer (except one that takes chunks instead of strings). This
4207 enables streaming of very large logfiles without storing the whole
4209 (BuildStatus.generateLogfileName): create names like
4210 12-log-compile-output, with a _0 suffix if required to be unique
4211 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4212 or earlier) logfiles into new-style ones
4213 (BuilderStatus): remove everything related to 'stub' builds. There
4214 is now only one build cache, and we don't strip logs from old
4216 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4217 since we no longer fight to keep it in the cache
4219 * buildbot/status/html.py (TextLog.render_GET): use a
4220 ChunkConsumer to stream the log entries efficiently.
4221 (ChunkConsumer): wrapper which consumes chunks and writes
4224 * buildbot/test/test_twisted.py (Parse.testParse): use a
4225 LogFile-like object instead of a real one
4227 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4228 (Log.testMerge3): validate more merge behavior
4229 (Log.testChunks): validate LogFile.getChunks
4230 (Log.testUpgrade): validate old-style LogFile upgrading
4231 (Log.testSubscribe): validate LogFile.subscribe
4232 (Log.testConsumer): validate LogFile.subscribeConsumer
4234 * buildbot/interfaces.py (IStatusLogStub): remove
4235 (IStatusLog.subscribeConsumer): new method
4236 (IStatusLog.hasContents): new method
4237 (IStatusLogConsumer): describes things passed to subscribeConsumer
4239 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4240 the log contents if it does not have any contents.
4241 (StatusResourceBuildStep.body): same
4242 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4244 2005-05-14 Brian Warner <warner@lothar.com>
4246 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4247 timeouts to try and make the windows metabuildslave not hang
4249 2005-05-13 Mike Taylor <bear@code-bear.com>
4251 * buildbot/slave/commands.py (rmdirRecursive): added a check
4252 to ensure the path passed into rmdirRecursive actually exists.
4253 On win32 a non-existant path would generate an exception.
4255 2005-05-13 Brian Warner <warner@lothar.com>
4257 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4258 shutil.rmtree which behaves correctly on windows in the face of
4259 files that you have to chmod before deleting. Thanks to Bear at
4260 the OSAF for the routine.
4261 (SourceBase.doClobber): use rmdirRecursive
4263 2005-05-12 Brian Warner <warner@lothar.com>
4265 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4266 method generate chunks instead of returning a big list. This
4267 allows the same method to be used for both old LogFile and new
4269 (OfflineLogFile.getText): use the generator
4270 (OfflineLogFile.subscribe): same
4271 * buildbot/status/html.py (TextLog.resumeProducing): same
4272 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4274 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4275 point out that OfflineLogFile does not currently work with
4276 html.Waterfall . Fixing this is high-priority.
4278 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4279 apparently windows defaults to using stdout
4281 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4282 better message on failure so I can figure out the win32 problem
4284 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4285 log messages to include more useful copies of the command being
4286 run, the argv array, and the child command's environment.
4287 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4289 2005-05-11 Brian Warner <warner@lothar.com>
4291 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4293 * Makefile: update the deb-snapshot version
4295 * docs/buildbot.texinfo: move all .xhtml docs into a new
4296 .texinfo-format document, adding a lot of material in the process.
4297 This is starting to look like a real user's manual. Removed all
4298 the Lore-related files: *.xhtml, *.css, template.tpl .
4299 * docs/Makefile: simple makefile to run 'makeinfo'
4300 * buildbot/scripts/sample.cfg: rearrange slightly
4301 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4303 2005-05-10 Brian Warner <warner@lothar.com>
4305 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4306 different name for the internal twistw module, handle it.
4308 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4309 * setup.py: .. and stop trying to install it
4311 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4312 'git'), the new linux kernel VC system (http://kernel.org/git/).
4313 Thanks to Brandon Philips for the patch.
4314 * buildbot/slave/commands.py (Git): same
4316 2005-05-06 Brian Warner <warner@lothar.com>
4318 * buildbot/status/builder.py (OfflineLogFile): replace the default
4319 LogFile with a form that appends its new contents to a disk file
4320 as they arrive. The complete log data is never kept in RAM. This
4321 is the first step towards handling very large (100MB+) logfiles
4322 without choking quite so badly. (The other half is
4323 producer/consumer on the HTML pages).
4324 (BuildStepStatus.addLog): use OfflineLogFile by default
4325 (BuildStatus.getLogfileName): helper code to give the
4326 OfflineLogFile a filename to work with
4328 * buildbot/test/test_status.py (Results.testAddResults): update
4329 tests to handle new asserts
4330 * buildbot/test/test_vc.py (Patch.doPatch): same
4331 * buildbot/test/test_steps.py (BuildStep.setUp): same
4333 2005-05-05 Brian Warner <warner@lothar.com>
4335 * buildbot/scripts/runner.py (start): if there is no Makefile,
4336 launch the app by importing twistd's internals and calling run(),
4337 rather than spawning a new twistd process. This stands a much
4338 better chance of working under windows.
4339 (stop): kill the process with os.kill instead of spawning
4340 /bin/kill, again to reduce the number of external programs which
4341 windows might not have in the PATH. Also wait up to 5 seconds for
4342 the process to go away, allowing things like 'buildbot stop;
4343 buildbot start' to be reliable in the face of slow shutdowns.
4345 * buildbot/master.py (Dispatcher.__getstate__): remove old
4346 .tap-related methods
4347 (BuildMaster.__getstate__): same
4349 * buildbot/slave/bot.py (makeService): same
4350 (Options.longdesc): same
4351 * buildbot/scripts/runner.py: copy over some old mktap option text
4353 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4354 'buildbot master' now creates a buildbot.tac file, so there is no
4355 longer a create-instance/save/reload sequence. mktap is dead, long
4357 * buildbot/scripts/sample.mk: use twistd -y, not -f
4358 * buildbot/test/test_config.py: remove mktap-based test
4359 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4360 * README: don't reference mktap
4362 * docs/source.xhtml: document some of the attributes that Changes
4365 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4367 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4368 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4369 * buildbot/changes/changes.py (Change)
4370 * buildbot/changes/mail.py (parseSyncmail)
4371 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4373 * buildbot/process/base.py (Build.isTagImportant)
4377 2005-05-04 Brian Warner <warner@lothar.com>
4379 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4380 connection after sending the change, so that unit tests don't
4381 complain about sockets being left around
4383 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4384 exception in phase=0 rendering
4385 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4387 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4389 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4390 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4391 and configuring builders with tuples.
4392 * buildbot/test/test_config.py: stop testing compatibility with
4393 deprecated config keys
4394 * buildbot/test/test_run.py: same
4396 2005-05-03 Brian Warner <warner@lothar.com>
4398 * contrib/arch_buildbot.py: survive if there are no logfiles
4399 (username): just use a string, os.getlogin isn't reliable
4401 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4402 so 'buildbot sendchange' actually works. The earlier test only
4403 covered the internal (non-reactor-running) form.
4405 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4406 script to notify the buildmaster about changes
4408 * buildbot/scripts/runner.py (sendchange): new command to send a
4409 change to a buildbot.changes.pb.PBChangeSource receiver.
4410 * buildbot/test/test_changes.py (Sender): test it
4412 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4413 after any reading of the config file, not just when we do it in
4414 startService. This makes some tests a bit cleaner.
4416 * buildbot/changes/pb.py: add some log messages
4418 * buildbot/process/base.py (Build.startBuild): fix a bug that
4419 caused an exception when the build terminated in the very first
4421 (Build.stepDone): let steps return a status of EXCEPTION. This
4422 terminates the build right away, and sets the build's overall
4423 status to EXCEPTION too.
4424 * buildbot/process/step.py (BuildStep.failed): return a status of
4425 EXCEPTION when that is what has happened.
4427 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4428 implement this, allowing Arch-based projects to get precise
4429 checkouts instead of always using the latest code
4430 (Bazaar): create variant of Arch to let folks use baz instead of
4431 tla. Requires a new buildslave too.
4432 * buildbot/slave/commands.py (Arch): add 'revision' argument
4433 (Bazaar): create variant of Arch that uses baz instead of tla.
4434 Remove the code that extracts the archive name from the
4435 register-archive output, since baz doesn't provide it, and require
4436 the user provide both the archive name and its location.
4437 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4439 2005-05-02 Brian Warner <warner@lothar.com>
4441 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4442 thanks to Nick Trout.
4444 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4445 deals better with source Makefile coming from a read-only CVS
4446 checkout. Thanks to Nick Trout for the catch.
4448 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4451 2005-04-28 Brian Warner <warner@lothar.com>
4453 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4455 * debian/changelog: update for 0.6.4
4457 2005-04-28 Brian Warner <warner@lothar.com>
4459 * README.w32: add a checklist of steps for getting buildbot
4461 * MANIFEST.in: include it in the tarball
4465 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4466 broken .tap files from 0.6.3 by getting rid of .services,
4467 .namedServices, and .change_svc at load time.
4469 2005-04-27 Brian Warner <warner@lothar.com>
4471 * NEWS: update in preparation for new release
4473 * buildbot/test/test_config.py (Save.testSave): don't pull in
4474 twisted.scripts.twistd, we don't need it and it isn't for windows
4477 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4478 accomodate win32 which can't do atomic-rename
4480 2005-04-27 Brian Warner <warner@lothar.com>
4482 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4483 timeouts to help the slow metabuildbot not flunk them so much
4484 (Disconnect.testBuild3): same
4485 (Disconnect.testBuild4): same
4486 (Disconnect.testInterrupt): same
4488 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4489 setup, it was completely broken for new buildmasters (those which
4490 did not have a 'change.pck' already saved. Thanks to Paul Warren
4491 for catching this (embarrassing!) bug.
4492 (Dispatcher.__getstate__): don't save our registered avatar
4493 factories, since they'll be re-populated when the config file is
4495 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4496 tests (since the real mktap-generated BuildMaster doesn't save
4498 (BuildMaster.__getstate__): don't save any service children,
4499 they'll all be re-populated when the config file is re-read.
4500 * buildbot/test/test_config.py (Save.testSave): test for this
4502 2005-04-26 Brian Warner <warner@lothar.com>
4504 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4505 rendered with Blender.. looks a bit nicer.
4506 * buildbot/docs/images/icon.blend: add the Blender file for it
4508 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4509 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4510 running under windows. This appears to be the best way to allow
4511 BuildSteps to do something normal like 'trial -v buildbot.test' or
4512 'make foo' and still expect it to work. The idea is to make the
4513 BuildSteps look as much like what a developer would type when
4514 compiling or testing the tree by hand. This approach probably has
4515 problems when there are spaces in the arguments, so if you've got
4516 windows buildslaves, you'll need to pay close attention to your
4519 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4520 timezone to the timestamp column.
4521 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4523 * buildbot/scripts/runner.py (loadOptions): do something sane for
4524 windows, I think. We use %APPDATA%/buildbot instead of
4525 ~/.buildbot, but we still search everywhere from the current
4526 directory up to the root for a .buildbot/ subdir. The "is it under
4527 $HOME" security test was replaced with "is it owned by the current
4528 user", which is only performed under posix.
4529 * buildbot/test/test_runner.py (Options.testFindOptions): update
4530 tests to match. The "is it owned by the current user" check is
4531 untested. The test has been re-enabled for windows.
4533 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4534 any "\n" in the expected output with the platform-specific line
4535 separator. Make this separator "\r\n" on PTYs under unix, they
4536 seem to do that and I don't know why
4538 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4539 windows for now, I don't know what ~/.buildbot/ should mean there.
4541 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4542 win32 compatibility, don't use "/tmp"
4543 (Basedir.testChangeBuilddir): remove more unixisms
4545 2005-04-26 Brian Warner <warner@lothar.com>
4547 * buildbot/test/test_control.py (Force.rmtree): python2.2
4548 compatibility, apparently its shutil.rmtree ignore_errors=
4549 argument is ignored.
4550 * buildbot/test/test_run.py (Run.rmtree): same
4551 (RunMixin.setUp): same
4553 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4556 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4557 'substring in string' operator, must use string.find(substr)!=-1
4558 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4559 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4561 * buildbot/scripts/runner.py (loadOptions): add code to search for
4562 ~/.buildbot/, a directory with things like 'options', containing
4563 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4564 the current directory, your $HOME directory, or anywhere
4565 inbetween, as long as you're somewhere inside your home directory.
4566 (debugclient): look in ~/.buildbot/options for master and passwd
4567 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4568 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4570 * buildbot/status/client.py (makeRemote): new approach to making
4571 IRemote(None) be None, which works under Twisted-2.0
4572 * buildbot/test/test_status.py (Client.testAdaptation): test it
4574 * buildbot/status/builder.py (Status.builderAdded): when loading a
4575 pickled BuilderStatus in from disk, set its name after loading.
4576 The config file might have changed its name (but not its
4577 directory) while it wasn't looking.
4579 * buildbot/process/builder.py (Builder.attached): always return a
4580 Deferred, even if the builder was already attached
4581 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4583 2005-04-25 Brian Warner <warner@lothar.com>
4585 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4586 category-related exception when announcing a build has finished
4588 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4589 reference no-longer-existent changemaster.sources
4590 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4592 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4595 2005-04-25 Brian Warner <warner@lothar.com>
4597 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4599 * debian/changelog: update for 0.6.3
4601 2005-04-25 Brian Warner <warner@lothar.com>
4603 * MANIFEST.in: make sure debug.glade is in the tarball
4605 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4607 * NEWS: update for the imminent 0.6.3 release
4609 * buildbot/status/html.py (HtmlResource.content): make the
4610 stylesheet <link> always point at "buildbot.css".
4611 (StatusResource.getChild): map "buildbot.css" to a static.File
4612 containing whatever css= argument was provided to Waterfall()
4613 (Waterfall): provide the "classic" css as the default.
4614 * docs/waterfall.classic.css: move default CSS from here ..
4615 * buildbot/status/classic.css: .. to here
4617 * MANIFEST.in: make sure classic.css is included in the tarball
4618 * setup.py: and that it is installed too, under buildbot/status/
4620 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4621 the module level, because buildbot.tap files from 0.6.2 don't have
4622 it in their attribute dictionary.
4624 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4625 really exists at startup, might save some confusion somewhere.
4627 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4629 * docs/waterfall.classic.css:
4630 add a stylesheet that's almost the same as the "classic"
4633 * buildbot/status/builder.py:
4634 add EXCEPTION as a result - this is a problem for the bot
4635 maintainer, not a build problem for the changers
4636 * buildbot/process/step.py:
4637 use EXCEPTION instead of FAILURE for exceptions
4638 * buildbot/status/html.py:
4639 add build_get_class to get a class out of a build/buildstep
4640 finish naming the classes
4641 split out sourceNames to changeNames and builderNames so we
4642 can style them separately
4643 * docs/config.xhtml:
4644 finish documenting classes as they are right now
4646 * buildbot/status/html.py:
4647 name the classes as we agreed on IRC
4648 * docs/config.xhtml:
4651 * buildbot/status/html.py:
4652 same for cssclass->class_
4654 * buildbot/status/html.py:
4655 as decided on IRC, use class_ for the "class" attribute to not
4656 conflict with the class keyword, and clean up the messy **{} stuff.
4658 * buildbot/status/mail.py:
4659 put back "builders" argument, and fix docstring, because the
4660 code *ignores* builders listed in this argument
4662 * buildbot/process/builder.py:
4663 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4665 * docs/config.xhtml:
4666 describe the category argument for builders
4668 * buildbot/status/builder.py:
4669 Fix a silly bug due to merging
4671 * buildbot/process/builder.py:
4672 remove category from the process Builder ...
4673 * buildbot/status/builder.py:
4674 ... and add it to BuilderStatus instead.
4675 Set category on unpickled builder statuses, they might not have it.
4676 * buildbot/master.py:
4677 include category when doing builderAdded
4678 * buildbot/status/mail.py:
4679 return None instead of self for builders we are not interested in.
4680 * buildbot/test/test_run.py:
4681 fix a bug due to only doing deferredResult on "dummy" waiting
4682 * buildbot/test/test_status.py:
4683 add checks for the Mail IStatusReceiver returning None or self
4685 * buildbot/status/html.py:
4686 fix testsuite by prefixing page title with BuildBot
4688 * buildbot/status/builder.py:
4689 have .category in builder status ...
4690 * buildbot/process/builder.py:
4691 ... and set it from Builder
4692 * buildbot/status/html.py:
4693 make .css a class variable
4694 * buildbot/test/test_status.py:
4695 write more tests to cover our categories stuff ...
4696 * buildbot/status/mail.py:
4697 ... and fix the bug that this uncovered
4699 * buildbot/changes/mail.py:
4700 * buildbot/changes/pb.py:
4701 * buildbot/master.py:
4702 * buildbot/process/base.py:
4703 * buildbot/process/factory.py:
4704 * buildbot/process/interlock.py:
4705 * buildbot/process/step.py:
4706 * buildbot/process/step_twisted.py:
4707 * buildbot/slave/commands.py:
4708 * buildbot/status/builder.py:
4709 * buildbot/status/client.py:
4710 * buildbot/status/html.py:
4711 * buildbot/status/mail.py:
4712 * buildbot/status/progress.py:
4713 * buildbot/test/test_changes.py:
4714 * buildbot/test/test_config.py:
4715 * buildbot/test/test_control.py:
4716 * buildbot/test/test_interlock.py:
4717 * buildbot/test/test_maildir.py:
4718 * buildbot/test/test_mailparse.py:
4719 * buildbot/test/test_run.py:
4720 * buildbot/test/test_slavecommand.py:
4721 * buildbot/test/test_status.py:
4722 * buildbot/test/test_steps.py:
4723 * buildbot/test/test_twisted.py:
4724 * buildbot/test/test_util.py:
4725 * buildbot/test/test_vc.py:
4726 * buildbot/test/test_web.py:
4728 add test-case-name at the top of a whole set of files
4730 * buildbot/status/builder.py:
4731 keep order of addition when getting builder names
4732 * buildbot/status/words.py:
4733 * buildbot/test/test_run.py:
4734 add test for getBuilderNames
4736 * buildbot/process/base.py:
4737 * buildbot/process/step.py:
4738 * buildbot/status/builder.py:
4739 * buildbot/status/html.py:
4740 make buildbot css-able
4741 replace the color code for purple with purple, don't understand
4742 why it wasn't purple to start with
4744 * buildbot/status/words.py:
4745 ok, so it doesn't look like BuilderStatus.remote is still valid.
4746 Use what waterfall uses instead.
4748 * buildbot/interfaces.py:
4749 * buildbot/status/builder.py:
4750 * buildbot/status/html.py:
4751 * buildbot/status/mail.py:
4752 * buildbot/status/words.py:
4753 * buildbot/test/test_run.py:
4754 use categories everywhere and make it be a list. More sensible
4755 for the future. Also make words actually respect this in
4758 * buildbot/interfaces.py:
4759 add category argument to getBuilderNames
4760 * buildbot/process/builder.py:
4761 * buildbot/status/builder.py:
4762 * buildbot/status/html.py:
4763 * buildbot/status/mail.py:
4764 * buildbot/status/words.py:
4765 * buildbot/test/test_run.py:
4766 move from specifying builders by name to specifying the category
4768 * buildbot/status/html.py:
4769 * buildbot/status/words.py:
4770 add "builders=" to __init__ of status clients so they can
4771 limit themselves to the given list of builders to report on
4773 * buildbot/status/html.py: set the title to the product name
4775 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4777 * buildbot/interfaces.py:
4778 * buildbot/status/builder.py:
4779 more documentation. Hm, not sure if ChangeLog entries make sense
4782 2005-04-23 Brian Warner <warner@lothar.com>
4784 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4786 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4788 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4789 the sub-commands that log buildmaster status to stdout and to a
4790 GUI window, respectively.
4792 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4793 functionality is working again, but all the step-status and ETA
4794 stuff is missing. Commented out a lot of code pending more
4797 * buildbot/status/client.py: make sure that IRemote(None) is None
4799 * buildbot/changes/changes.py: import defer, oops
4800 (ChangeMaster): remove the .sources list, rely upon the fact that
4801 MultiServices can be treated as sequences of their children. This
4802 cleans up the add/remove ChangeSource routines a lot, as we keep
4803 exactly one list of the current sources instead of three.
4805 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4806 up an empty ChangeMaster at init time.
4807 (BuildMaster.loadChanges): if there are changes to be had from
4808 disk, replace self.change_svc with the new ones. If not, keep
4809 using the empty ChangeMaster set up in __init__.
4810 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4811 instead of a separate list, makes the code a bit cleaner.
4812 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4813 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4814 Extend the test to make sure we can get rid of the sources when
4817 2005-04-22 Brian Warner <warner@lothar.com>
4819 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4820 and info/host files when making the slave directory
4822 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4823 whendone= argument, just return the Deferred and let the caller do
4824 what they want with it.
4825 (Disconnect.testBuild1): wait for shutdownSlave
4826 (Basedir.testChangeBuilddir): new test to make sure changes to the
4827 builddir actually get propagated to the slave
4829 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4830 explicit method, rather than passing the builddir in __init__ .
4831 Make sure to update self.basedir too, this was broken before.
4832 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4833 builders and for ones that have just had their builddir changed.
4834 (BotFactory): add a class-level .perspective attribute, so
4835 BuildSlave.waitUntilDisconnected won't get upset when the
4836 connection hasn't yet been established
4837 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4838 tests can reach through it to inspect the SlaveBuilders
4840 * buildbot/process/base.py (Build.buildException): explain the
4841 log.err with a log.msg
4842 * buildbot/process/builder.py (Builder.startBuild): same
4843 (Builder._startBuildFailed): improve error message
4845 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4846 occurred because we lost the brand-new connection, retry instead
4847 of giving up. If not, it's probably an authorization failure, and
4848 it makes sense to stop trying. Make sure we log.msg the reason
4849 that we're log.err'ing the failure, otherwise test failures are
4850 really hard to figure out.
4852 * buildbot/master.py: change loadConfig() to return a Deferred
4853 that doesn't fire until the change has been fully implemented.
4854 This means any connected slaves have been updated with the new
4855 builddir. This change makes it easier to test the code which
4856 actually implements this builddir-updating.
4857 (BotPerspective.addBuilder): return Deferred
4858 (BotPerspective.removeBuilder): same
4859 (BotPerspective.attached): same
4860 (BotPerspective._attached): same. finish with remote_print before
4861 starting the getSlaveInfo, instead of doing them in parallel
4862 (BotPerspective.list_done): same
4863 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4864 actually calling slave.disconnect()
4865 (BotMaster.addBuilder): same
4866 (BotMaster.removeBuilder): same
4867 (BuildMaster.loadConfig): same
4868 (BuildMaster.loadConfig_Slaves): same
4869 (BuildMaster.loadConfig_Sources): same
4870 (BuildMaster.loadConfig_Builders): same
4871 (BuildMaster.loadConfig_status): same
4873 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4874 a Deferred that fires when the source is finally removed
4876 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4877 the previous tree on win32, where we have to do it synchronously,
4878 make sure we return a Deferred anyway.
4879 (SourceBase.doCopy): same
4881 * buildbot/scripts/runner.py (statusgui): use the text client for
4882 now, while I rewrite the Gtk one
4883 * buildbot/clients/base.py: strip out old code, leaving just the
4884 basic print-message-on-event functionality. I also remove the
4885 ReconnectingPBClientFactory, but it does at least quit when it
4886 loses the connection instead of going silent
4888 2005-04-21 Brian Warner <warner@lothar.com>
4890 * Makefile: minor tweaks
4892 * NEWS: point out deprecation warnings, new features for
4895 * buildbot/master.py (BuildMaster.loadConfig): emit
4896 DeprecationWarnings for Builders defined with tuples. Rearrange
4897 code to facility removal of deprecated configuration keys in the
4900 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4901 'buildbot' command to put a little Makefile in the target that
4902 helps you re-create the buildbot.tap file, start or stop the
4903 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4904 all the files 0600, since they contain passwords.
4905 (start): if there is a Makefile, and /usr/bin/make exists, use
4906 'make start' in preference to a raw twistd command. This lets
4907 slave admins put things like PYTHONPATH variables in their
4908 Makefiles and have them still work when the slave is started with
4909 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4910 be nice to first try the 'make' command and only fall back to
4911 twistd if it fails. TODO: the Makefile's "start" command does not
4912 add the --reactor=win32 argument when running under windows.
4913 (Options.debugclient, Options.statusgui): add sub-commands to launch
4914 the debug client (formerly in contrib/debugclient.py) and the
4915 Gtk status application (currently broken)
4916 * buildbot/clients/debug.py: move from contrib/debugclient.py
4917 * buildbot/clients/debug.glade: same
4919 * buildbot/test/test_trial.py: remove it. This requires some
4920 functionality out of Twisted that isn't there yet, and until then
4921 having it around just confuses things.
4923 * buildbot/test/test_slavecommand.py (Shell): test both with and
4924 without PTYs, and make sure that command output is properly
4925 interleaved in the with-PTY case. I think the without-PTY test
4926 should pass on windows, where we never use PTYs anyway.
4928 2005-04-20 Brian Warner <warner@lothar.com>
4930 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4932 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4934 * NEWS: start creating entries for the next release
4936 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4938 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4939 (WebTest.test_webPathname): same
4940 (WebTest.test_webPathname_port): same
4941 (WebTest.test_waterfall): use the default favicon rather than
4942 rooting around the filesystem for it. Open the expected-icon file
4943 in binary mode, to make win32 tests happier (thanks to Nick Trout
4945 * buildbot/status/html.py (buildbot_icon): win32 portability
4947 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4948 win32-compatibility fixes from Nick Trout, the "file not found" message
4949 is different under windows
4950 (FakeSlaveBuilder.__init__): clean up setup a bit
4951 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4953 2005-04-19 Brian Warner <warner@lothar.com>
4955 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4956 skip-if-repositories-are-unavailable test to not kill the trial
4957 that comes with Twisted-1.3.0
4959 * setup.py: install buildbot.png icon file when installing code
4961 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4962 environment used by the command, at least on the child side.
4964 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4965 this method needs to be added and implemented because it gets
4966 called under heavy load. I don't quite understand the
4967 producer/consumer API enough to write it.
4968 (StatusResource.getChild): add a resource for /favicon.ico
4969 (Waterfall.__init__): add favicon= argument
4970 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4971 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4972 (WebTest.test_webPathname): same
4973 (WebTest.test_webPathname_port): same
4974 * docs/config.xhtml: mention favicon=
4975 * buildbot/buildbot.png: add a default icon, dorky as it is
4977 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4979 * buildbot/master.py:
4980 * buildbot/process/base.py:
4981 * buildbot/process/builder.py:
4982 * buildbot/process/interlock.py:
4983 * buildbot/status/builder.py:
4984 * buildbot/status/html.py:
4985 * buildbot/status/mail.py:
4986 * buildbot/status/words.py:
4987 new documentation while digging through the code
4989 2005-04-17 Brian Warner <warner@lothar.com>
4991 * general: try to fix file modes on all .py files: a+r, a-x,
4992 but let buildbot/clients/*.py be +x since they're tools
4994 * docs/epyrun (addMod): when an import fails, say why
4996 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4998 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5000 * buildbot/process/base.py:
5001 * buildbot/process/builder.py:
5002 * buildbot/status/builder.py:
5003 new documentation while digging through the code
5005 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5007 * buildbot/changes/changes.py:
5008 * buildbot/changes/p4poller.py:
5009 * buildbot/interfaces.py:
5010 * buildbot/process/base.py:
5011 * buildbot/process/builder.py:
5012 * buildbot/process/step.py:
5013 * buildbot/process/step_twisted.py:
5014 * buildbot/slave/bot.py:
5015 * buildbot/slave/commands.py:
5016 * buildbot/status/builder.py:
5017 fix all docstrings to make epydoc happy. In the process of fixing
5018 some, I also moved pieces of docs, and removed some deprecated
5021 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5023 * buildbot/process/builder.py:
5024 * buildbot/process/interlock.py:
5025 * buildbot/process/process_twisted.py:
5026 * buildbot/process/step.py:
5027 BuildProcess -> Build, as it looks like that's what happened
5028 * buildbot/process/base.py:
5029 * buildbot/process/factory.py:
5032 2005-04-17 Brian Warner <warner@lothar.com>
5034 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5035 update compile command to accomodate the Twisted split.. now
5036 instead of './setup.py build_ext -i', you do './setup.py all
5037 build_ext -i', to run build_ext over all sub-projects.
5038 (FullTwistedBuildFactory): same
5039 (TwistedReactorsBuildFactory): same
5041 * buildbot/status/html.py (TextLog.finished): null out self.req
5042 when we're done, otherwise the reference cycle of TextLog to .req
5043 to .notifications to a Deferred to TextLog.stop keeps them from
5044 being collected, and consumes a huge (610MB on pyramid at last
5045 check) amount of memory.
5047 2005-04-11 Brian Warner <warner@lothar.com>
5049 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5050 normalize the VC-repository location.. makes SVN happier with
5051 certain test environments.
5053 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5054 RemoteShellCommand gets its own .env dictionary, so that code in
5055 start() doesn't mutate the original. I think this should fix the
5056 step_twisted.Trial problem where multiple identical components
5057 kept getting added to PYTHONPATH= over and over again.
5059 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5060 adding epydoc-format docstrings to many classes. Thanks to Thomas
5061 Vander Stichele for the patches.
5062 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5063 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5064 * buildbot/slave/bot.py, commands.py, registry.py: same
5066 2005-04-05 Brian Warner <warner@lothar.com>
5068 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5069 preserve timestamps, helps incremental builds of large trees.
5070 Patch from Rene Rivera.
5072 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5073 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5076 2005-04-03 Brian Warner <warner@lothar.com>
5078 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5079 with one dict, apparently exec has some scoping bugs when used
5080 with both global/local dicts. Thanks to Nathaniel Smith for the
5083 2005-04-02 Brian Warner <warner@lothar.com>
5085 * buildbot/process/step_twisted.py (countFailedTests): the new
5086 trial in Twisted-2.0 emits a slightly different status line than
5087 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5088 mistakenly think the test count is unparseable.
5089 (Trial.start): note that for some reason each build causes another
5090 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5091 be fixed but I'm not sure quite where the problem is.
5093 2005-04-01 Brian Warner <warner@lothar.com>
5095 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5096 deferredResult to avoid hangs/warnings under twisted-2.0
5097 (RunMixin.tearDown): same
5098 (RunMixin.shutdownSlave): same
5099 (Disconnect.testIdle1): same
5100 (Disconnect.testBuild2): same: wait one second after the build
5101 finishes for test to really be done.. this should be cleaned up to
5102 avoid wasting that second. Builder.detach uses a callLater(0),
5103 either that should be done in-line (something else needed that
5104 behavior), or it should return a Deferred that fires when the
5105 builder is really offline.
5106 (Disconnect.testBuild3): same
5107 (Disconnect.testDisappear): same
5109 * buildbot/test/test_web.py: rearrange server-setup and teardown
5110 code to remove unclean-reactor warnings from twisted-2.0
5112 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5113 so the tests don't hang under twisted-2.0
5115 2005-03-31 Brian Warner <warner@lothar.com>
5117 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5118 caused a warning each time the master changed our set of builders
5120 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5121 w32, don't unlink the file unless it already exists. Thanks to
5122 Baptiste Lepilleur for the catch.
5123 (BuilderStatus.saveYourself): same
5125 2005-02-01 Brian Warner <warner@lothar.com>
5127 * buildbot/status/html.py (TextLog.getChild): use a /text child
5128 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5129 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5130 logfile as text/plain (no markup, no headers). This replaces the
5131 previous scheme (which used an ?text=1 argument), and gets us back
5132 to a relative link (which works better when the buildbot lives
5133 behind another web server, such as Apache configured as a reverse
5134 proxy). Thanks to Gerald Combs for spotting the problem.
5136 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5139 2004-12-13 Brian Warner <warner@lothar.com>
5141 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5143 * debian/changelog: update for 0.6.2
5144 * NEWS: finalize for 0.6.2
5146 2004-12-11 Brian Warner <warner@lothar.com>
5148 * NEWS: bring it up to date
5150 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5151 detection code. Require some sign of life from the buildmaster
5152 every BotFactory.keepaliveInterval seconds. Provoke this
5153 indication at BotFactory.keepaliveTimeout seconds before the
5154 deadline by sending a keepalive request. We don't actually care if
5155 that request is answered in a timely fashion, what we care about
5156 is that .activity() is called before the deadline. .activity() is
5157 triggered by any PB message from the master (including an ack to
5158 one of the slave's status-update messages). With this new scheme,
5159 large status messages over slow pipes are OK, as long as any given
5160 message can be sent (and thus acked) within .keepaliveTimeout
5161 seconds (which defaults to 30).
5162 (SlaveBuilder.remote_startCommand): record activity
5163 (SlaveBuilder.ackUpdate): same
5164 (SlaveBuilder.ackComplete): same
5165 (BotFactory.gotPerspective): same
5166 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5168 2004-12-09 Brian Warner <warner@lothar.com>
5170 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5173 * buildbot/process/step_twisted.py (Trial._commandComplete):
5174 update self.cmd when we start the 'cat test.log' transfer. Without
5175 this, we cannot interrupt the correct RemoteCommand when we lose
5178 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5179 trying to tell the slave to stop the command if we're already
5180 inactive, or if we no longer have a .remote
5182 * buildbot/process/builder.py (Builder._detached): don't let an
5183 exception in currentBuild.stopBuild() prevent the builder from
5184 being marked offline
5186 2004-12-07 Brian Warner <warner@lothar.com>
5188 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5189 KeyError that happens when you ask for a non-existent Builder, and
5190 translate it into a UsageError.
5192 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5193 losing the slave in the middle of a remote step is handled too
5195 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5196 be a Failure, so be sure to stringify it before using it as the
5197 contents of the 'interrupt' logfile
5198 (RemoteCommand.interrupt): use stringified 'why' in
5199 remote_interruptCommand too, just in case
5201 2004-12-06 Brian Warner <warner@lothar.com>
5203 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5204 instead of 'tla update', which is more efficient in case we've
5205 missed a couple of patches since the last update.
5207 * debian/changelog: update for previous (0.6.1) release. Obviously
5208 this needs to be handled better.
5210 2004-12-05 Brian Warner <warner@lothar.com>
5212 * NEWS: update for stuff since last release
5214 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5215 match the maybeDeferred change in Dispatcher.requestAvatar
5216 * buildbot/changes/pb.py (ChangePerspective.attached): same
5217 * buildbot/status/client.py (StatusClientPerspective.attached): same
5218 * buildbot/process/builder.py (Builder._attached3): same
5219 * buildbot/pbutil.py (NewCredPerspective.attached): same
5221 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5222 the date to the top-most box, if it is not the same as today's
5225 * docs/slave.xhtml: provide a buildslave setup checklist
5227 * docs/source.xhtml (Arch): correct terminology
5229 2004-12-04 Brian Warner <warner@lothar.com>
5231 * buildbot/test/test_slavecommand.py: use sys.executable instead
5232 of hard-coding 'python' for child commands, might help portability
5234 * docs/examples/twisted_master.cfg: update to current usage
5236 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5237 'stop build' command to the IRC bot
5239 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5240 message that broke PBChangeSource
5242 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5243 (SlaveBuilder): make some attributes class-level, remove the old
5244 "update queue" which existed to support resuming a build after the
5245 master connection was lost. Try to reimplement that feature later.
5246 (SlaveBuilder.stopCommand): clear self.command when the
5247 SlaveCommand finishes, so that we don't try to kill a leftover one
5249 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5252 * buildbot/slave/commands.py (SourceBase): set self.command for
5253 all VC commands, so they can be interrupted.
5255 2004-12-03 Brian Warner <warner@lothar.com>
5257 * buildbot/master.py: clean up slave-handling code, to handle
5258 slave-disconnect and multiple-connect better
5259 (BotPerspective): make these long-lasting, exactly one per bot
5260 listed in the config file.
5261 (BotPerspective.attached): if a slave connects while an existing
5262 one appears to still be connected, disconnect the old one first.
5263 (BotPerspective.disconnect): new method to forcibly disconnect a
5264 buildslave. Use some hacks to empty the transmit buffer quickly to
5265 avoid the long (20-min?) TCP timeout that could occur if the old
5266 slave has dropped off the net.
5267 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5268 own their own SlaveStatus objects. Remove .attached/.detached, add
5269 .addSlave/.removeSlave, treat slaves like Builders (config file
5270 parsing sends deltas to the BotMaster). Inform the slave
5271 instances, i.e. the BotPerspective, about addBuilder and
5273 (BotMaster.getPerspective): turns into a single dict lookup
5274 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5275 which gives BotPerspective.attached a chance to disconnect the old
5277 (BuildMaster.loadConfig): add code (disabled) to validate that all
5278 builders use known slaves (listed in c['bots']). The check won't
5279 work with tuple-specified builders, which are deprecated but not
5280 yet invalid, so the check is disabled for now.
5281 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5282 routine, do the add/changed/removed dance with them like we do
5284 (BuildMaster.loadConfig_Sources): move source-config into a
5285 separate routine too
5287 * buildbot/status/builder.py (Status.getSlave): get the
5288 SlaveStatus object from the BotPerspective, not the BotMaster.
5290 * buildbot/test/test_run.py: bunch of new tests for losing the
5291 buildslave at various points in the build, handling a slave that
5292 connects multiple times, and making sure we can interrupt a
5295 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5296 something other than 'Bot' for the Bot object, to make certain
5297 test cases easier to write.
5298 (BuildSlave.waitUntilDisconnected): utility method for testing
5300 2004-11-30 Brian Warner <warner@lothar.com>
5302 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5304 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5305 argument, return a Deferred that always fires with True or False.
5306 I don't use an errback to indicate 'ping failed' so that callers
5307 are free to ignore the deferred without causing spurious errors in
5309 * buildbot/process/builder.py (BuilderControl.ping): implement it
5311 * buildbot/test/test_run.py (Status.testDisappear): test ping
5312 (Status.disappearSlave): fix it
5314 2004-11-30 Brian Warner <warner@lothar.com>
5316 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5317 (IBuilderControl): add .getBuild(num), only works for the current
5318 build, of course, although it might be interesting to offer
5319 something for builds in the .waiting or .interlocked state.
5321 * buildbot/process/base.py (Build): have .stopBuild just do the
5322 interrupt, then let the build die by itself.
5323 (BuildControl): add .stopBuild, and add a point-event named
5324 'interrupt' just after the build so status viewers can tell that
5326 (BuilderControl): add .getBuild
5328 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5329 stops when you kill it, good for testing
5330 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5331 contains the 'reason' text.
5333 * buildbot/status/html.py: Add Stop Build button, if the build can
5334 still be stopped. Send a Redirect (to the top page) one second
5335 later, hopefully long enough for the interrupt to have an effect.
5336 Move make_row() up to top-level to share it between Stop Build and
5339 * buildbot/slave/commands.py: only kill the child process once
5341 * buildbot/test/test_run.py: add testInterrupt
5343 2004-11-29 Brian Warner <warner@lothar.com>
5345 * buildbot/process/base.py: Refactor command interruption. The
5346 Build is now responsible for noticing that the slave has gone
5347 away: Build.lostRemote() interrupts the current step and makes
5348 sure that no further ones will be started.
5350 * buildbot/process/builder.py: When the initial remote_startBuild
5351 message fails, log it: this usually indicates that the slave has
5352 gone away, but we don't really start paying attention until they
5353 fail to respond to the first step's command.
5355 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5356 slave disconnect. Now sports a new interrupt() method. Error
5357 handling was simplified a lot by chaining deferreds, so
5358 remoteFailed/remoteComplete were merged into a single
5359 remoteComplete method (which can now get a Failure object).
5360 Likewise failed/finished were merged into just _finished.
5361 (BuildStep): Add interrupt(why) method, and if why is a
5362 ConnectionLost Failure then the step is failed with some useful
5365 * buildbot/slave/bot.py: stop the current command when the remote
5366 Step reference is lost, and when the slave is shut down.
5367 (Bot): make it a MultiService, so it can have children. Use
5368 stopService to tell when the slave is shutting down.
5369 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5370 remote_interruptCommand (which asks the current SlaveCommand to
5371 stop but allows it to keep emitting status messages), and
5372 stopCommand (which tells it to shut up and die).
5374 * buildbot/slave/commands.py: make commands interruptible
5375 (ShellCommand.kill): factor out os.kill logic
5376 (Command): factor out setup()
5377 (Command.sendStatus): don't send status if .running is false, this
5378 happens when the command has been halted.
5379 (Command.interrupt): new method, used to tell the command to die
5380 (SlaveShellCommand): implement .interrupt
5381 (DummyCommand): implement .interrupt
5382 (SourceBase, etc): factor out setup(), don't continue substeps if
5385 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5386 so they can be called after finishing
5388 * buildbot/test/test_run.py: new tests for disconnect behavior,
5389 refactor slave-shutdown routines, add different kinds of
5392 2004-11-27 Brian Warner <warner@lothar.com>
5394 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5395 method to express ETA time like "2m45s" instead of "165 seconds"
5397 2004-11-24 Brian Warner <warner@lothar.com>
5399 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5400 archive after the test completes, to avoid cluttering the user's
5401 'tla archives' listing with a bogus entry. Arch doesn't happen to
5402 provide any way to override the use of ~/.arch-params/, so there
5403 isn't a convenient way to avoid touching the setup of the user who
5405 (VC_HTTP.testArchHTTP): same
5407 2004-11-23 Brian Warner <warner@lothar.com>
5409 * buildbot/status/html.py (TextLog): split render() up into
5410 render_HEAD and render_GET. Use a Producer when sending log
5411 chunks, to reduce memory requirements and avoid sending huge
5412 non-Banana-able strings over web.distrib connections. Requires
5413 peeking under the covers of IStatusLog.
5414 (TextLog.resumeProducing): fix the "as text" link, handle client
5415 disconnects that occur while we're still sending old chunks.
5417 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5418 use defer.succeed, not the non-existent defer.success
5419 (LogFile.waitUntilFinished): same
5420 (LogFile.subscribe): don't add watchers to a finished logfile
5422 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5425 2004-11-23 Brian Warner <warner@lothar.com>
5427 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5429 2004-11-23 Brian Warner <warner@lothar.com>
5431 * NEWS: update for the 0.6.1 release
5432 * MANIFEST.in: add new files
5434 * README (INSTALLATION): explain how to enable the extra VC tests
5436 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5437 level to, so old pickled builds can be displayed ok
5439 2004-11-22 Brian Warner <warner@lothar.com>
5441 * NEWS: summarize updates since last release
5443 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5444 Yoz Grahame. Closes SF#1050138.
5446 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5449 * buildbot/process/step_twisted.py (Trial): update docs a bit
5451 * docs/factories.xhtml: fix Trial factory docs to match reality.
5454 * buildbot/process/factory.py (Trial.__init__): add args for
5455 randomly= and recurse=, making them available to instantiators
5456 instead of only to subclassers. Closes: SF#1049759.
5458 2004-11-15 Brian Warner <warner@lothar.com>
5460 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5461 try to teach the Quick factory to use multiple versions of python
5463 2004-11-12 Brian Warner <warner@lothar.com>
5465 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5466 safer w32-compatible approach, and only use it on windows
5467 (BuildStatus.saveYourself): same
5469 2004-11-11 Brian Warner <warner@lothar.com>
5471 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5472 it: one string merge per chunk. There are now separate .entries
5473 and .runEntries lists: when enumerating over all chunks, make sure
5475 * buildbot/test/test_status.py (Log): more tests
5477 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5478 chunks together, up to 10kb per chunk. This ought to cut down on
5479 the CPU-burning overhead of large log files. Thanks to Alexander
5480 Staubo for spotting the problem.
5481 * buildbot/test/test_status.py (Log): tests for same
5483 2004-11-10 Brian Warner <warner@lothar.com>
5485 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5486 header to outbound mail
5487 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5489 2004-11-08 Brian Warner <warner@lothar.com>
5491 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5492 can't do os.rename() onto an existing file, so catch the exception
5493 and unlink the target file first. This introduces a slight window
5494 where the existing file could be lost, but the main failure case
5495 (disk full) should still be handled safely.
5496 (BuildStatus.saveYourself): same
5498 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5499 separator character instead of os.sep, because the filenames being
5500 split here are coming from the VC system, which can have a
5501 different pathname convention than the local host. This should
5502 help a buildmaster running on windows that uses a CVS repository
5503 which runs under unix.
5504 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5506 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5507 when there are no test failures to be parsed
5509 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5510 instead of the unix-specific os.system("cp"), thanks to Elliot
5511 Murphy for this and the other buildbot-vs-windows catches.
5512 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5514 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5515 echo the command as it is run
5517 * setup.py: install sample.mk too, not just sample.cfg
5518 (scripts): install contrib/windows/buildbot.bat on windows
5520 2004-11-07 Brian Warner <warner@lothar.com>
5522 * buildbot/process/builder.py (Builder._detached): clear the
5523 self.currentBuild reference, otherwise the next build will be
5524 skipped because we think the Builder is already in use.
5526 * docs/examples/twisted_master.cfg: update to match current usage
5527 on the Twisted buildbot
5529 2004-10-29 Brian Warner <warner@lothar.com>
5531 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5533 2004-10-28 Brian Warner <warner@lothar.com>
5535 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5536 have separate doVCUpdate/doVCFull methods. Catch an update failure
5537 and respond by clobbering the source directory and re-trying. This
5538 will handle local changes (like replacing a file with a directory)
5539 that will cause CVS and SVN updates to fail.
5540 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5542 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5545 2004-10-19 Brian Warner <warner@lothar.com>
5547 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5549 * buildbot/status/html.py (StatusResourceTestResults): display any
5550 TestResults that the Build might have
5551 (StatusResourceTestResult): and the logs for each TestResult
5552 (StatusResourceBuild): add link from the per-build page
5554 2004-10-15 Brian Warner <warner@lothar.com>
5556 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5557 the 'problems' portion of stdout, add TestResults to our build
5558 * buildbot/test/test_twisted.py (Parse.testParse): test it
5560 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5561 to retrieve a dict of accumulated test results
5562 (ITestResult): define what a single test result can do
5563 * buildbot/status/builder.py (TestResult): implement ITestResult
5564 (BuildStatus.getTestResults): retrieve dict of TestResults
5565 (BuildStatus.addTestResult): add TestResults
5566 * buildbot/test/test_status.py (Results.testAddResults): test it
5568 2004-10-14 Brian Warner <warner@lothar.com>
5570 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5571 instead of os.system("rm -rf") for win32 portability
5573 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5574 SignalMixin instead of starting/stopping the reactor, which is
5575 likely to cause problems with other tests
5577 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5578 self.copyComplete() call. Yoz Grahame makes the catch.
5580 * contrib/windows/buildbot.bat: helper script to deal with path
5581 issues. Thanks to Yoz Grahame.
5583 * buildbot/master.py (BuildMaster.startService): don't register a
5584 SIGHUP handler if the signal module has no SIGHUP attribute.
5585 Apparently win32 does this.
5587 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5589 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5590 test if the reactor can't offer UNIX sockets
5592 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5593 error introduced in the last commit. We really need that
5596 2004-10-12 Brian Warner <warner@lothar.com>
5598 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5599 when describing a maildir source. Thanks to Stephen Davis.
5601 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5604 * buildbot/scripts/runner.py (createMaster): install Makefile too
5605 (start): add --no_save to 'start' command
5606 * buildbot/scripts/sample.mk: simple convenience Makefile with
5607 start/stop/reload targets
5609 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5612 2004-09-30 Brian Warner <warner@lothar.com>
5614 * setup.py: Releasing buildbot-0.6.0
5616 2004-09-30 Brian Warner <warner@lothar.com>
5618 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5619 test_trial.py from the source tarball until support is complete.
5621 * NEWS: update for 0.6.0 release
5622 * buildbot/__init__.py (version): same
5625 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5626 'source' command to tell users where to get the Buildbot source
5628 * docs/examples/*.cfg: update to modern standards
5630 * NEWS: update for release
5632 * buildbot/scripts/runner.py (createMaster): remove the
5633 -shutdown.tap stuff now that it isn't necessary
5635 (start): launch buildbot.tap, not buildbot-shutdown.tap
5638 * buildbot/status/mail.py (Domain): shorten class name
5639 (MailNotifier): if lookup= is a string, pass it to Domain()
5640 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5641 (Mail.testBuild2): test the string-to-Domain shortcut
5642 (Mail.testMail): fix test
5645 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5648 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5649 more attributes on load
5650 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5651 to accomodate the whole waterfall page at once, and the thrashing
5652 results in a lot of unnecessary loads
5653 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5654 (BuilderStatus.saveYourself): same
5655 (BuilderStatus.eventGenerator): stop generating on the first missing
5656 build. We assume that saved builds are deleted oldest-first.
5657 (BuildStepStatus.__getstate__): .progress might not exist
5659 * buildbot/changes/changes.py (ChangeMaster): make it
5660 serializable, in $masterdir/changes.pck
5661 (ChangeMaster.stopService): save on shutdown
5662 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5663 * buildbot/test/test_config.py: load Changes before config file
5666 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5667 "Oh my god, you killed the command" header on a separate line
5669 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5670 skip over corrupted build pickles
5671 (BuilderStatus.getFullBuildByNumber): same
5672 (BuilderStatus.eventGenerator): skip over unavailable builds
5673 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5674 do an atomic rename. This prevents a corrupted pickle when some
5675 internal serialization error occurs.
5676 (BuilderStatus.saveYourself): same
5678 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5679 the timeout for shell commands, it got lost somehow
5681 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5682 run out of build steps, return the rest of the builder events
5684 * buildbot/interfaces.py (IBuilderControl.ping): add method
5686 * buildbot/process/builder.py (BuilderControl.ping): move
5687 slave-ping to BuilderControl, and fix the failure case in the
5688 process (Event.finish() is the verb, Event.finished is the noun).
5690 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5691 through the BuilderControl instead of the BuilderStatus
5692 (EventBox): add adapter for builder.Event, allowing builder events to
5693 be displayed in the waterfall display
5695 * buildbot/master.py (BotMaster.stopService): add a 'master
5696 shutdown' event to the builder's log
5697 (BuildMaster.startService): and a 'master started' on startup
5699 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5700 builder events into the BuildStep event stream
5701 (Status.builderAdded): add a 'builder created' event
5704 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5705 command to announce the completion of a running build
5706 (IrcStatusBot.command_FORCE): announce when the build finishes
5708 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5709 don't evict unfinished builds from the cache: they must stay in
5710 the full-cache until their logfiles have stopped changing. Make
5711 sure the eviction loop terminates if an unfinished build was hit.
5712 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5713 This lets exceptions be dumped in an email status message. Really
5714 we need LogFiles which contain both text and HTML, instead of two
5716 (BuildStatus.__getstate__): handle self.finished=False
5717 (Status.builderAdded): if the pickle is corrupted, abandon the
5718 history and create a new BuilderStatus object.
5720 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5721 self.progress attribute, helped one test which doesn't fully set
5722 up the Build object.
5724 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5725 IStatusLog methods into an Interface that is implemented by "stub"
5726 logs, for which all the actual text chunks are on disk (in the
5727 pickled Build instance). To show the log contents, you must first
5728 adapt the stub log to a full IStatusLog object.
5730 * buildbot/status/builder.py (LogFileStub): create separate stub
5731 log objects, which can be upgraded to a real one if necessary.
5732 (LogFile): make them persistable, and let them stubify themselves
5734 (BuildStepStatus): same
5736 (BuildStatus.saveYourself): save the whole build out to disk
5737 (BuilderStatus): make it persistable
5738 (BuilderStatus.saveYourself): save the builder to disk
5739 (BuilderStatus.addFullBuildToCache): implement two caches which
5740 hold Build objects: a small one which holds full Builds, and a
5741 larger one which holds "stubbed" Builds (ones with their LogFiles
5742 turned into LogFileStubs). This reduces memory usage by the
5743 buildmaster by not keeping more than a few (default is 2) whole
5744 build logs in RAM all the time.
5745 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5747 (BuilderStatus.eventGenerator): rewrite since .builds went away
5748 (BuilderStatus.buildStarted): remove the .builds array. Add the
5749 build to the "full" cache when it starts.
5750 (BuilderStatus._buildFinished): save the build to disk when it
5752 (Status): give it a basedir (same as the BuildMaster's basedir)
5753 where the builder pickles can be saved
5754 (Status.builderAdded): create the BuilderStatus ourselves, by
5755 loading a pickle from disk (or creating a new instance if there
5756 was none on disk). Return the BuilderStatus so the master can glue
5757 it into the new Builder object.
5759 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5760 all BuilderStatuses to save themselves out to disk. This is in
5761 lieu of saving anything important in the main Application pickle
5762 (the -shutdown.tap file).
5763 (BuildMaster.__init__): give Status() a basedir for its files
5764 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5765 to get the BuilderStatus, then give it to the Builder (instead of
5766 doing it the other way around). It's ok if the status announces
5767 the new Builder before it's really ready, as the outside world can
5768 only see the BuilderStatus object anyway (and it is ready before
5769 builderAdded returns). Use the builder's "builddir" (which
5770 normally specifies where the slave will run the builder) as the
5771 master's basedir (for saving serialized builds).
5773 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5774 coerce the logfile to IStatusLog before trying to get the text
5775 chunks out of it. This will pull the full (non-stubified) Build in
5776 from disk if necessary.
5777 (TextLog): fix the adapter registration
5779 * buildbot/test/test_control.py (Force.setUp): create the basedir
5780 * buildbot/test/test_web.py: same
5781 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5782 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5783 * buildbot/test/test_run.py (Run.testMaster): same
5784 (Status.setUp): same
5786 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5788 * buildbot/status/html.py (Waterfall.__init__): store actual
5789 allowForce flag passed in rather than using True for everyone;
5790 make sure setting it to False doesn't cause a NameError
5792 (StatusResourceBuilder.__init__) add the builder name to the page
5794 (StatusResourceBuilder.body) move HTML generation for a name/value
5795 row into a helper method (StatusResourceBuilder.make_row); only
5796 generate the "Force Build" form if allowForce was True and the
5797 slave is connected. Use class attributes in the generated HTML to
5798 spread a little CSS-joy.
5800 2004-09-28 Brian Warner <warner@lothar.com>
5802 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5803 warning-scanner to not ignore things like
5804 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5806 * buildbot/status/html.py (StatusResource.control): add some
5807 class-level values for .control in an attempt to make upgrading
5810 * buildbot/util.py (ComparableMixin): survive missing attributes,
5811 such as when a class is modified and we're comparing old instances
5814 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5815 failure handling, remove a redundant try/except block. Don't
5816 return the full traceback to the IRC channel.
5817 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5818 error messages. Get ETA properly.
5820 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5821 the reason, since (at least) IRC message will have <> in them.
5822 (StatusResourceBuilder.__init__): take an IBuilderControl
5823 (StatusResourceBuilder.force): use the IBuilderControl we get in
5824 the constructor instead of trying to make our own. Catch the
5825 new exceptions and ignore them for now (until we make an
5826 intermediate web page where we could show the error message)
5827 (StatusResource): create with an IControl, use it to give an
5828 IBuilderControl to all children
5829 (Waterfall): take an allowForce= option, pass an IControl object
5830 to StatusResource if it is True
5832 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5834 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5835 catch new exceptions and return string forms
5837 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5838 * buildbot/process/builder.py (Builder.forceBuild): raise them
5839 * buildbot/test/test_control.py (Force.testNoSlave): new test
5840 (Force.testBuilderInUse): same
5843 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5845 * buildbot/test/test_run.py: use IControl
5846 * buildbot/test/test_vc.py: same
5848 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5849 to use IControl. Still offline.
5850 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5852 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5853 who=None so periodic builds don't send out status mail
5854 (Builder.forceBuild): include reason in the log message
5855 (BuilderControl.forceBuild): rename 'name' to 'who'
5857 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5858 'who' parameter, but make it None by default so builds forced by
5859 slave admins don't cause status mail to be sent to anybody
5860 (BotMaster.forceBuild): same. this method is deprecated.
5861 (DebugPerspective.perspective_forceBuild): same, use IControl.
5862 (DebugPerspective.perspective_fakeChange): use IControl..
5863 (Dispatcher.requestAvatar): .. so don't set .changemaster
5865 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5866 parameter to avoid confusion with the name of the builder
5869 * buildbot/status/mail.py: refine comment about needing 2.3
5871 * buildbot/status/html.py: move all imports to the top
5873 * buildbot/test/test_control.py: test new interfaces
5874 * buildbot/test/test_run.py (Status): handle new interfaces
5875 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5877 * buildbot/process/base.py (BuildControl): implement IBuildControl
5878 and its lonely getStatus() method
5880 * buildbot/process/builder.py (BuilderControl): implement
5881 IBuilderControl, obtained by adapting the Builder instance
5882 (Builder.startBuild): return a BuilderControl instead of a
5883 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5884 accomplish the same thing.
5886 * buildbot/master.py: move all import statements to the top
5887 (Control): implement IControl, obtained by adapting the
5888 BuildMaster instance.
5890 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5891 IBuildControl. These are used to force builds. Eventually they
5892 will provide ways to reconfigure the Builders, pause or abandon a
5893 Build, and perhaps control the BuildMaster itself.
5895 2004-09-26 Brian Warner <warner@lothar.com>
5897 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5898 ends up comparing us against something without a .__class__
5900 2004-09-24 Brian Warner <warner@lothar.com>
5902 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5905 * Makefile: add 'deb-snapshot' target, to create a timestamped
5908 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5910 2004-09-23 Brian Warner <warner@lothar.com>
5912 * buildbot/__init__.py (version): move version string here
5913 * setup.py: get version string from buildbot.version
5914 * buildbot/status/html.py (WaterfallStatusResource.body): add
5915 buildbot version to the page footer
5916 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5919 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5920 slaves, let the second know where the first one is coming from
5921 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5922 see our exceptions. It would be nice if there were a way to just
5923 send them the exception type and value, not the full traceback.
5926 * buildbot/status/mail.py (MailNotifier): add a new argument
5927 sendToInterestedUsers=, which can be set to False to disable the
5928 usual send-to-blamelist behavior.
5929 (top): handle python-2.2 which has no email.MIMEMultipart
5930 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5931 (MailNotifier.disownServiceParent): unsubscribe on removal
5933 * buildbot/test/test_status.py (Mail.testBuild2): test it
5936 * buildbot/status/progress.py (Expectations.wavg): tolerate
5937 current=None, which happens when steps start failing badly
5938 * buildbot/test/test_status.py (Progress.testWavg): test for it
5940 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5941 doesn't understand args['revision'], emit a warning instead of
5942 bailing completely. Updating to -rHEAD is probably close enough.
5944 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5946 * buildbot/test/test_status.py: at least import bb.status.client
5947 even if we don't have any test coverage for it yet
5949 * contrib/svn_buildbot.py: don't require python2.3
5950 (main): wait, do require it (for sets.py), but explain how to
5951 make it work under python2.2
5953 2004-09-23 Brian Warner <warner@lothar.com>
5955 * contrib/svn_buildbot.py: include the revision number in the Change
5957 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5958 using util.now() because FreshCVS is a realtime service
5960 * buildbot/status/event.py: delete dead code
5961 * buildbot/process/step.py: don't import dead Event class
5962 * buildbot/process/step_twisted.py: same
5963 * buildbot/status/builder.py: same
5964 * buildbot/status/client.py: same
5966 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5968 * buildbot/changes/changes.py (Change): set .when from an __init__
5969 argument (which defaults to now()), rather than having
5970 ChangeMaster.addChange set it later.
5971 (ChangeMaster.addChange): same
5973 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5974 (parseSyncmail): same. Just use util.now() for now.
5975 (parseBonsaiMail): parse the timestamp field for when=
5977 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5978 instead of setting .when after the fact
5982 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5983 results when the target project uses retrial. Still under
5985 * buildbot/test/test_trial.py: same
5987 2004-09-21 Brian Warner <warner@lothar.com>
5989 * buildbot/status/mail.py (MailNotifier.__init__): include
5990 success/warnings/failure in the Subject line
5991 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5992 use step.logname for the addLogs=True attachment filenames
5993 * buildbot/test/test_status.py (Mail): test Subject lines
5994 (Mail.testLogs): test attachment filenames
5996 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5997 accept a 'who' argument from the debug tool
5998 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5999 * contrib/debug.glade: add text box to set 'who'
6001 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6002 .getBuilderName with .getBuilder().getName(), more flexible
6003 (IStatusLog.getName): logs have short names, but you can prefix
6004 them with log.getStep().getName() to make them more useful
6005 * buildbot/status/builder.py: same
6006 * buildbot/status/client.py: same
6007 * buildbot/status/html.py: same
6008 * buildbot/test/test_run.py (Status.testSlave): same
6009 * buildbot/process/step.py: tweak logfile names
6011 * buildbot/status/mail.py (MailNotifier): add lookup, change
6012 argument to extraRecipients. The notifier is now aimed at sending
6013 mail to the people involved in a particular build, with additional
6014 constant recipients as a secondary function.
6016 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6017 including slow-lookup and failing-lookup. Make sure the blamelist
6018 members are included.
6020 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6021 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6022 (IBuildStatus.getInterestedUsers): new method
6023 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6024 * buildbot/status/client.py (remote_getResponsibleUsers): same
6025 * buildbot/status/html.py (StatusResourceBuild.body): same
6026 * buildbot/test/test_run.py (Status.testSlave): same
6028 2004-09-20 Brian Warner <warner@lothar.com>
6030 * docs/users.xhtml: update concepts
6032 * Makefile: add a convenience makefile, for things like 'make
6033 test'. It is not included in the source tarball.
6035 2004-09-16 Brian Warner <warner@lothar.com>
6037 * NEWS: mention /usr/bin/buildbot, debian/*
6039 * debian/*: add preliminary debian packaging. Many thanks to
6040 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6041 it considerably since it left their hands, I am responsible for
6042 all breakage that's resulted.
6044 * bin/buildbot: create a top-level 'buildbot' command, to be
6045 installed in /usr/bin/buildbot . For now it's just a simple
6046 frontend to mktap/twistd/kill, but eventually it will be the entry
6047 point to the 'try' command and also a status client. It is also
6048 intended to support the upcoming debian-packaging init.d scripts.
6049 * buildbot/scripts/runner.py: the real work is done here
6050 * buildbot/scripts/__init__.py: need this too
6051 * buildbot/scripts/sample.cfg: this is installed in new
6052 buildmaster directories
6053 * setup.py: install new stuff
6055 2004-09-15 Brian Warner <warner@lothar.com>
6057 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6058 'file:' schema (the version shipped with OS-X was built without the
6060 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6061 updates the log-timestamp, to make sure it isn't still running after
6064 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6065 values to the config file.
6066 * docs/examples/hello.cfg: add examples
6067 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6068 * buildbot/status/builder.py (Status.getProjectURL): implement them
6069 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6070 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6071 * buildbot/status/html.py (WaterfallStatusResource): display them
6074 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6075 certain error cases don't suffer a secondary exception.
6076 (top): Skip tests if the corresponding VC tool is not installed.
6078 * buildbot/process/factory.py (Trial): introduce separate
6079 'buildpython' and 'trialpython' lists, since trialpython=[] is
6080 what you want to invoke /usr/bin/python, whereas ./setup.py is
6081 less likely to be executable. Add env= parameter to pass options
6082 to test cases (which is how I usually write tests, I don't know if
6083 anyone else does it this way).
6085 * buildbot/process/step_twisted.py (Trial): handle python=None.
6086 Require 'testpath' be a string, not a list. Fix tests= typo.
6087 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6089 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6090 way to deal with the possibility of removing the disconnect notify
6092 (CVS): add a 'login' parameter to give a password to 'cvs login',
6093 commonly used with pserver methods (where pw="" or pw="guest")
6095 * buildbot/slave/commands.py (SourceBase): move common args
6096 extraction and setup() to __init__, so everything is ready by the
6097 time setup() is called
6098 (CVS.start): call 'cvs login' if a password was supplied
6099 (ShellCommand): special-case PYTHONPATH: prepend the master's
6100 value to any existing slave-local value.
6102 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6103 don't have a remote, mark the builder as Offline. This whole
6104 function should probably go away and be replaced by individual
6106 (Builder.buildFinished): return the results to the build-finished
6107 deferred callback, helps with testing
6109 2004-09-14 Brian Warner <warner@lothar.com>
6111 * buildbot/test/test_vc.py: put all the repositories needed to run
6112 the complete tests into a single small (1.3MB) tarball, so I can
6113 make that tarball available on the buildbot web site. Test HTTP
6114 access (for Arch and Darcs) by spawning a temporary web server
6115 while the test runs.
6117 * docs/users.xhtml: new document, describe Buildbot's limited
6118 understanding of different human users
6120 * buildbot/test/test_vc.py: rearrange test cases a bit
6122 * buildbot/process/step_twisted.py (Trial): handle testpath=
6123 * buildbot/process/factory.py (Trial): update to use step.Trial
6125 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6127 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6128 the overall build text (which gives you 'failed 2 tests' rather
6130 (BuildStepStatus.text2): default to [], not None
6132 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6135 2004-09-12 Brian Warner <warner@lothar.com>
6137 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6138 log the whole exception if it's just an AttributeError (old slave)
6140 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6141 so (e.g.) sub-commands can be run in the right directory.
6142 (ShellCommand.start): accept an optional errorMessage= argument
6143 to make life easier for SVN.start
6144 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6146 (ShellCommand.start): move ['dir'] compatibility hack..
6147 (RemoteShellCommand.start): .. to here so everyone can use it
6149 * buildbot/process/step_twisted.py (Trial): use .workdir
6151 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6152 text displayed when debuild fails completely
6153 (Trial): snarf _trial_temp/test.log from the slave and display it
6155 2004-09-11 Brian Warner <warner@lothar.com>
6157 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6159 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6160 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6162 * buildbot/process/step.py (ShellCommand): call .createSummary
6163 before .evaluateCommand instead of the other way around. This
6164 makes it slightly easier to count warnings and then use that to
6165 set results=WARNINGS
6166 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6168 * buildbot/process/base.py (Build.buildFinished): update status
6169 before doing progress. It's embarrassing for the build to be stuck
6170 in the "building" state when an exceptions occurs elsewhere..
6172 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6173 python2.2 doesn't have 'sum'
6175 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6176 to prevent clients from accidentally sorting it
6178 * buildbot/master.py (Manhole): add username/password
6179 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6180 c['manholePort'], deprecate old usage
6181 * docs/config.xhtml: document c['manhole']
6182 * docs/examples/hello.cfg: show example of using a Manhole
6185 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6186 pretend the slave is up to date
6188 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6189 the module, overlaps with 'log', the local variable
6191 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6193 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6194 new method to let Steps find out the version of their
6195 corresponding SlaveCommand.
6196 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6197 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6198 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6200 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6201 (Arch.startVC): same
6202 (P4Sync.startVC): same
6204 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6205 Deferred so we can catch errors in remote_startCommand
6206 (RemoteShellCommand.start): same
6208 * docs/examples/twisted_master.cfg: update sample config file
6210 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6211 after connectionMade() is called, not before. Close stdin at that
6214 * buildbot/process/process_twisted.py: update to use Trial, clean
6215 up argument passing (move to argv arrays instead of string
6218 * buildbot/process/step_twisted.py (Trial): new step to replace
6219 RunUnitTests, usable by any trial-using project (not just
6220 Twisted). Arguments have changed, see the docstring for details.
6222 * buildbot/process/base.py (Build.startBuild): this now returns a
6223 Deferred. Exceptions that occur during setupBuild are now
6224 caught better and lead to fewer build_status weirdnesses, like
6225 finishing a build that was never started.
6226 (Build.buildFinished): fire the Deferred instead of calling
6227 builder.buildFinished directly. The callback argument is this
6228 Build, everything else can be extracted from it, including the
6229 new build.results attribute.
6230 * buildbot/process/builder.py (Builder.startBuild): same
6231 (Builder.buildFinished): same, extract results from build
6233 * buildbot/process/step.py (ShellCommands): remove dead code
6235 2004-09-08 Brian Warner <warner@lothar.com>
6237 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6238 doesn't try to use the leftover patched workdir
6239 (SourceStamp): test source-stamp computation for CVS and SVN
6241 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6242 patched workdir ('touch .buildbot-patched') so we don't try to
6244 (SourceBase.start): add ['revision'] for all Source steps
6245 (CVS): change args: use ['branch'] for -r, remove ['files']
6246 (CVS.buildVC): fix revision/branch stuff
6247 (SVN): add revision stuff
6249 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6250 kwargs (except 'workdir') to avoid silent spelling errors
6251 (ShellCommand.__init__): same
6252 (Source): new base class for CVS/SVN/etc. Factor out everything
6253 common, add revision computation (perform the checkout with a -D
6254 DATE or -r REVISION that gets exactly the sources described by the
6255 last Change), overridable with step.alwaysUseLatest. Add patch
6256 handling (build.getSourceStamp can trigger the use of a base
6257 revision and a patch).
6258 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6259 * docs/steps.xhtml: update docs
6260 * docs/source.xhtml: mention .checkoutDelay
6261 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6263 * buildbot/process/base.py (Build.setSourceStamp): add a
6264 .sourceStamp attribute to each Build. If set, this indicates that
6265 the build should be done with something other than the most
6266 recent source tree. This will be used to implement "try" builds.
6267 (Build.allChanges): new support method
6268 (Build.lastChangeTime): remove, functionality moved to Source steps
6269 (Build.setupBuild): copy the Step args before adding ['workdir'],
6270 to avoid modifying the BuildFactory (and thus triggering spurious
6274 * buildbot/status/html.py: rename s/commits/changes/
6275 (StatusResourceChanges): same
6276 (CommitBox.getBox): same, update URL
6277 (WaterfallStatusResource): same
6278 (StatusResource.getChild): same
6280 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6281 * contrib/debug.glade: add optional 'revision' to the fakeChange
6283 * buildbot/changes/changes.py (html_tmpl): display .revision
6284 (ChangeMaster.addChange): note .revision in log
6285 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6286 accept a ['revision'] attribute
6288 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6290 * buildbot/master.py (BotMaster.getPerspective): update the
6291 .connected flag in SlaveStatus when it connects
6292 (BotMaster.detach): and when it disconnects
6293 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6294 (BuildMaster.loadConfig_Builders): walk old list correctly
6296 * buildbot/test/test_config.py: fix prefix= usage
6298 2004-09-06 Brian Warner <warner@lothar.com>
6302 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6303 poll a P4 depot looking for recent changes. Thanks to Dave
6304 Peticolas for the contribution. Probably needs some testing after
6307 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6308 requires manual client setup for each buildslave. Rather
6309 experimental. Thanks again to Dave Peticolas.
6310 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6312 * buildbot/changes/changes.py (Change): add a .revision attribute,
6313 which will eventually be used to generate source-stamp values.
6315 * buildbot/process/step.py (RemoteCommand.start): use
6316 notifyOnDisconnect to notice when we lose the slave, then treat it
6317 like an exception. This allows LogFiles to be closed and the build
6318 to be wrapped up normally. Be sure to remove the disconnect
6319 notification when the step completes so we don't accumulate a
6320 bazillion such notifications which will fire weeks later (when the
6321 slave finally disconnects normally). Fixes SF#915807, thanks to
6322 spiv (Andrew Bennetts) for the report.
6323 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6324 really isn't Logged- specific
6325 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6326 header, since it's almost always going to be appended to an
6328 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6329 update test to handle use of notifyOnDisconnect
6331 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6332 don't clear .ETA and .currentBuild when going offline, let the
6333 current build clean up after itself
6335 * buildbot/process/builder.py (Builder.detached): wait a moment
6336 before doing things like stopping the current build, because the
6337 current step will probably notice the disconnect and cleanup the
6339 * buildbot/test/test_run.py (Status.tearDown): update test to
6340 handle asynchronous build-detachment
6342 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6344 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6345 hush a debug message
6347 2004-09-05 Brian Warner <warner@lothar.com>
6349 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6350 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6351 kernels do this: the fcntl module has the F_NOTIFY constant, but
6352 the kernel itself doesn't support the operation. Thanks to Olly
6353 Betts for spotting the problem.
6355 * buildbot/process/step.py (Darcs): new source-checkout command
6356 (Arch): new source-checkout command
6357 (todo_P4): fix constructor syntax, still just a placeholder
6358 * buildbot/test/test_vc.py (VC.testDarcs): test it
6359 (VC.testDarcsHTTP): same, via localhost HTTP
6361 (VC.testArchHTTP): same
6362 * NEWS: mention new features
6364 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6365 which tells the step to stash stdout text locally (in .stdout).
6366 Slave-side Commands can use this to make decisions based upon the
6367 output of the the ShellCommand (not just the exit code).
6368 (Darcs): New source-checkout command
6369 (Arch): New source-checkout command, uses .keepStdout in one place
6370 where it needs to discover the archive's default name.
6372 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6373 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6374 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6376 * buildbot/process/step.py (ShellCommand.describe): add an
6377 alternate .descriptionDone attribute which provides descriptive
6378 text when the step is complete. .description can be ["compiling"],
6379 for use while the step is running, then .descriptionDone can be
6380 ["compile"], used alone when the step succeeds or with "failed" when
6381 it does not. Updated other steps to use the new text.
6382 * buildbot/process/step_twisted.py: same
6383 * buildbot/test/test_run.py: update tests to match
6385 2004-08-30 Brian Warner <warner@lothar.com>
6387 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6388 (CVS.__init__): send 'patch' argument to slave
6389 (CVS.start): don't create the LoggedRemoteCommand until start(),
6390 so we can catch a .patch added after __init__
6391 (SVN.__init__): add 'patch' to SVN too
6394 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6395 argument, to let commands push data into the process' stdin pipe.
6396 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6397 is in use, since closing a PTY doesn't really affect the process
6398 in the right way (in particular, I couldn't run /usr/bin/patch
6400 (SourceBase.doPatch): handle 'patch' argument
6402 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6405 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6406 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6408 * buildbot/master.py (BotPerspective.got_commands): get command
6409 versions from slave, give to each builder
6410 * buildbot/process/builder.py (Builder.attached): stash slave
6411 command versions in .remoteCommands
6413 * docs/steps.xhtml: bring docs in-line with reality
6415 * buildbot/process/step.py (CVS.__init__): more brutal
6416 compatibility code removal
6417 (SVN.__init__): same
6419 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6420 (SlaveShellCommand.start): require ['workdir'] argument, remove
6421 the ['dir'] fallback (compatibility will come later)
6422 (SourceBase): update docs
6423 (SourceBase.start): remove ['directory'] fallback
6426 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6427 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6428 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6430 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6431 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6432 code.. I will figure out 0.5.0-compatibility hooks later)
6434 2004-08-30 Brian Warner <warner@lothar.com>
6436 * buildbot/process/process_twisted.py: rewrite in terms of new
6437 BuildFactory base class. It got significantly shorter. Yay
6440 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6441 work with the new "self.build isn't nailed down until we call
6442 step.start()" scheme: specifically, __init__ is called before the
6443 build has decided on which Changes are going in, so we don't scan
6444 build.allFiles() for .xhtml files until start()
6445 (HLint.commandComplete): use getText(), not getStdout()
6446 (RunUnitTests.start): same: don't use .build until start()
6447 (RunUnitTests.describe): oops, don't report (None) when using
6449 (RunUnitTests.commandComplete): use getText()
6450 (RunUnitTests.createSummary): same
6451 (BuildDebs.commandComplete): same
6453 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6454 set args['command'] until start(), since our BuildStep is allowed
6455 to change their mind up until that point
6456 (TreeSize.commandComplete): use getText(), not getStdout()
6458 * docs/examples/twisted_master.cfg: update to current standards
6460 * docs/factories.xhtml: update
6461 * buildbot/process/factory.py: implement all the common factories
6462 described in the docs. The Trial factory doesn't work yet, and
6463 I've probably broken all the process_twisted.py factories in the
6464 process. There are compatibility classes left in for things like
6465 the old BasicBuildFactory, but subclasses of them are unlikely to
6467 * docs/examples/glib_master.cfg: use new BuildFactories
6468 * docs/examples/hello.cfg: same
6470 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6471 explicit 'workdir' args
6473 * buildbot/process/base.py (BuildFactory): move factories to ..
6474 * buildbot/process/factory.py (BuildFactory): .. here
6475 * buildbot/process/process_twisted.py: handle move
6476 * buildbot/test/test_config.py: same
6477 * buildbot/test/test_run.py: same
6478 * buildbot/test/test_steps.py: same
6479 * buildbot/test/test_vc.py: same
6480 * docs/factories.xhtml: same
6482 * NEWS: mention config changes that require updating master.cfg
6484 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6485 argument to all steps that weren't given one already, pointing at
6486 the "build/" directory.
6488 * docs/examples/hello.cfg: remove explicit 'workdir' args
6490 * docs/factories.xhtml: document standard BuildFactory clases,
6491 including a bunch which are have not yet been written
6493 2004-08-29 Brian Warner <warner@lothar.com>
6495 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6496 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6497 buildbot.status.builder so they aren't quite so internal
6498 * buildbot/process/base.py, buildbot/process/builder.py: same
6499 * buildbot/process/maxq.py, buildbot/process/step.py: same
6500 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6501 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6502 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6504 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6505 to handle new getLogs()-returns-list behavior
6506 (StatusResourceBuildStep.getChild): same
6507 (StepBox.getBox): same
6508 (WaterfallStatusResource.phase0): same
6510 * docs/source.xhtml: document how Buildbot uses version-control
6511 systems (output side: how we get source trees)
6512 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6513 systems (input side: how we learn about Changes)
6515 * buildbot/master.py (Manhole): use ComparableMixin
6516 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6517 * buildbot/changes/mail.py (MaildirSource): same
6518 * buildbot/status/client.py (PBListener): same
6519 * buildbot/status/html.py (Waterfall): same
6520 * buildbot/status/words.py (IRC): same
6522 * NEWS: start describing new features
6524 * buildbot/status/mail.py (MailNotifier): finish implementation.
6525 The message body is still a bit sparse.
6526 * buildbot/test/test_status.py (Mail): test it
6528 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6529 and __hash__ methods I wind up adding everywhere. Specifically
6530 intended to support the buildbot config-file update scheme where
6531 we compare, say, the old list of IStatusTargets against the new
6532 one and don't touch something which shows up on both lists.
6533 * buildbot/test/test_util.py (Compare): test case for it
6535 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6536 return a list instead of a dict
6537 (IBuildStepStatus.getLogs): same. The idea is that steps create
6538 logs with vaguely unique names (although their uniqueness is not
6539 guaranteed). Thus a compilation step should create its sole
6540 logfile with the name 'compile', and contribute it to the
6541 BuildStatus. If a step has two logfiles, try to create them with
6542 different names (like 'test.log' and 'test.summary'), and only
6543 contribute the important ones to the overall BuildStatus.
6544 * buildbot/status/builder.py (Event.getLogs): same
6545 (BuildStepStatus): fix default .text and .results
6546 (BuildStepStatus.addLog): switch to list-like .getLogs()
6547 (BuildStepStatus.stepFinished): same
6548 (BuildStatus.text): fix default .text
6549 (BuildStatus.getLogs): temporary hack to return all logs (from all
6550 child BuildStepStatus objects). Needs to be fixed to only report
6551 the significant ones (as contributed by the steps themselves)
6552 * buildbot/test/test_run.py: handle list-like .getLogs()
6553 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6555 2004-08-28 Brian Warner <warner@lothar.com>
6557 * buildbot/process/builder.py (Builder.attached): serialize the
6558 attachment process, so the attach-watcher isn't called until the
6559 slave is really available. Add detached watchers too, which makes
6562 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6564 * buildbot/test/test_swap.py: remove dead code
6566 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6567 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6568 sort of as if the command being run exited with a -1. There may
6569 still be some holes in this scheme.
6570 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6571 -r option appears before the module list
6572 * buildbot/process/step.py (CVS): add 'revision' argument
6574 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6575 when sending updates or stepComplete messages to the master, since
6576 we don't currently care whether they arrive or not. When we revamp
6577 the master/slave protocol to really resume interrupted builds,
6578 this will need revisiting.
6579 (lostRemote): remove spurious print
6581 * buildbot/master.py (BotPerspective.attached): serialize the
6582 new-builder interrogation process, to make testing easier
6583 (BotMaster.waitUntilBuilderDetached): convenience function
6585 * buildbot/status/builder.py (BuilderStatus): prune old builds
6586 (BuildStatus.pruneSteps): .. and steps
6587 (BuildStepStatus.pruneLogs): .. and logs
6588 (BuilderStatus.getBuild): handle missing builds
6589 * buildbot/status/html.py (StatusResourceBuild.body): display build
6590 status in the per-build page
6591 (BuildBox.getBox): color finished builds in the per-build box
6593 2004-08-27 Brian Warner <warner@lothar.com>
6595 * buildbot/status/mail.py (MailNotifier): new notification class,
6598 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6599 variants of a common base class which handles all the mode= logic
6601 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6603 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6605 2004-08-26 Brian Warner <warner@lothar.com>
6607 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6610 * buildbot/test/test_run.py: update to new Logfile interface, new
6611 buildbot.slave modules
6612 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6614 * MANIFEST.in: new sample config file
6615 * docs/examples/hello.cfg: same
6617 * buildbot/process/step_twisted.py: remove dead import
6619 * buildbot/process/step.py (RemoteCommand.run): catch errors
6621 (RemoteCommand.remote_update): ignore updates that arrive after
6623 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6624 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6625 the responsibilities of the subclass's methods
6626 (BuildStep.failed): catch errors during failure processing
6627 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6628 (CVS): move to a mode= argument (described in docstring), rather
6629 than the ungainly clobber=/export=/copydir= combination.
6630 (SVN): add mode= functionality to SVN too
6631 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6633 * buildbot/process/base.py (Build.startNextStep): catch errors
6634 during s.startStep()
6636 * buildbot/clients/base.py: update to new PB client interface.
6637 gtkPanes is still broken
6639 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6640 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6641 * setup.py: add buildbot.slave module
6642 * buildbot/bb_tap.py: handle move
6643 * buildbot/slave/registry.py: place to register commands, w/versions
6644 * buildbot/slave/bot.py: major simplifications
6645 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6646 instead of a fixed table. Eventually this will make the slave more
6647 extensible. Use 'start' method on the command, not .startCommand.
6648 Fix unsafeTracebacks handling (I think).
6649 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6650 helper class with a .start method that returns a Deferred.
6651 SlaveShellCommand is the form reached by the buildmaster. Commands
6652 which use multiple ShellCommands can just chain them as Deferreds,
6653 with some helper methods in Command (_abandonOnFailure and
6654 _checkAbandoned) to bail on rc!=0.
6655 (CVSCommand): prefer new mode= argument
6656 (SVNFetch): add mode= argument
6658 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6659 put a useful reason string on the build
6661 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6662 core functionality into an IStatusLog object
6663 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6664 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6665 (StatusResourceBuild.body): use proper accessor methods
6666 * buildbot/status/client.py (RemoteLog): PB-access goes here
6667 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6668 which delivers log contents too
6669 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6670 * buildbot/status/event.py: remove old Logfile completely
6672 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6673 subscription interface for IStatusLog subscriptions just like all
6674 other the status subscriptions
6675 (IStatusReceiver.logChunk): method called on subscribers
6677 2004-08-24 Brian Warner <warner@lothar.com>
6679 * buildbot/process/builder.py (Builder._pong): oops, ping response
6680 includes a result (the implicit None returned by remote_print).
6681 Accept it so the _pong method handles the response correctly.
6683 2004-08-06 Brian Warner <warner@lothar.com>
6685 * buildbot/test/test_config.py: update IRC, PBListener tests
6687 * buildbot/status/client.py (StatusClientPerspective): total
6688 rewrite to match new IStatus interfaces. New subscription scheme.
6689 There are still a few optimizations to make (sending down extra
6690 information with event messages so the client doesn't have to do a
6691 round trip). The logfile-retrieval code is probably still broken.
6692 Moved the PB service into its own port, you can no longer share a
6693 TCP socket between a PBListener and, say, the slaveport (this
6694 should be fixed eventually).
6695 * buildbot/clients/base.py (Client): revamp to match. still needs
6696 a lot of work, but basic event reporting works fine. gtkPanes is
6699 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6700 instance talks to a single irc server. Threw out all the old
6701 multi-server handling code. Still need to add back in
6702 builder-control (i.e. "force build")
6704 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6705 more random text to the as-yet-unreachable per-step page
6707 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6708 rename to stepETAUpdate
6709 (BuildStatus.subscribe): add build-wide ETA updates
6710 (BuilderStatus.getState): remove more cruft
6711 (BuilderStatus.getCurrentBuild): remove more cruft
6712 (BuilderStatus.buildStarted): really handle tuple-subscription
6713 * buildbot/test/test_run.py (Status.testSlave): handle the
6714 stepETAUpdate rename
6716 * buildbot/master.py (BuildMaster): don't add a default
6717 StatusClientService. Don't add a default IrcStatusFactory. Both
6718 are now added through c['status'] in the config file. c['irc'] is
6719 accepted for backwards compatibility, the only quirk is you cannot
6720 use c['irc'] to specify IRC servers on ports other than 6667.
6722 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6723 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6724 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6725 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6728 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6729 the buildmaster to re-read its config file
6732 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6733 find out the port our server is running on
6734 (WebTest.test_webPathname_port): same
6736 * buildbot/test/test_config.py (testWebPortnum): test it
6737 (testWebPathname): ditto
6739 * docs/config.xhtml: document new c['status'] configuration option
6741 * buildbot/status/html.py (Waterfall): new top-level class which
6742 can be added to c['status']. This creates the Site as well as the
6743 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6744 reachable as .parent, for everything.
6746 * buildbot/master.py (Manhole): make it a normal service Child
6747 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6748 webPathname. It will eventually replace c['irc'] and the implicit
6749 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6750 in as (deprecated) backward compatibility hooks for now.
6753 * buildbot/process/builder.py (Builder.buildFinished): don't
6754 inform out builder_status about a finished build, as it finds out
6755 through its child BuildStatus object
6757 * buildbot/status/html.py: extensive revamp. Use adapters to make
6758 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6759 have both starting and finishing times and adjust the waterfall
6760 display accordingly, using spacers if necessary. Use SlaveStatus
6761 to get buildslave info.
6762 (StatusResourceBuildStep): new just-one-step resource, used to get
6763 logfiles. No actual href to it yet.
6765 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6766 the time being, until I get the file-naming scheme right
6768 * buildbot/status/builder.py (Event): clean started/finished names
6769 (BuildStatus.isFinished): .finished is not None is the right test
6770 (BuildStatus.buildStarted): track started/finished times ourselves
6771 (BuilderStatus.getSlave): provide access to SlaveStatus object
6772 (BuilderStatus.getLastFinishedBuild): all builds are now in
6773 .builds, even the currently-running one. Accomodate this change.
6774 (BuilderStatus.eventGenerator): new per-builder event generator.
6775 Returns BuildStepStatus and BuildStatus objects, since they can
6776 both be adapted as necessary.
6777 (BuilderStatus.addEvent): clean up started/finished attributes
6778 (BuilderStatus.startBuild,finishBuild): remove dead code
6779 (SlaveStatus): new object to provide ISlaveStatus
6781 * buildbot/process/step.py (ShellCommand.getColor): actually
6782 return the color instead of setting it ourselves
6783 (CVS.__init__): pull .timeout and .workdir options out of
6784 **kwargs, since BuildStep will ignore them. Without this neither
6785 will be sent to the slave correctly.
6786 (SVN.__init__): same
6788 * buildbot/process/builder.py (Builder): move flags to class-level
6790 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6791 SlaveStatus handle that
6793 * buildbot/process/base.py (Build.firstEvent): remove dead code
6794 (Build.stopBuild): bugfix
6796 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6798 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6799 (ChangeMaster.eventGenerator): yield Changes, since there are now
6800 Adapters to turn them into HTML boxes
6802 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6803 (BotPerspective.attached): feed a SlaveStatus object
6804 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6805 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6807 * buildbot/interfaces.py: API additions
6808 (ISlaveStatus): place to get slave status
6810 2004-08-04 Brian Warner <warner@lothar.com>
6812 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6813 the delay finishes, so the step is marked as SUCCESS
6815 * buildbot/test/test_run.py (Status.testSlave): cover more of
6816 IBuildStatus and IBuildStepStatus
6818 * buildbot/status/progress.py (StepProgress): move some flags to
6819 class-level attributes
6820 (StepProgress.remaining): if there are no other progress metrics
6821 to go by, fall back to elapsed time
6822 (StepProgress.setExpectations): take a dict of metrics instead of
6824 (BuildProgress.setExpectationsFrom): pull expectations from the
6825 Expectations, instead of having it push them to the BuildProgress
6826 (Expectations): move some flags to class-level attributes
6827 (Expectations.__init__): copy per-step times from the
6829 (Expectations.expectedBuildTime): new method for per-build ETA
6831 * buildbot/status/event.py (Logfile): move some flags to
6832 class-level attributes
6833 (Logfile.logProgressTo): better method name, let step set the
6834 progress axis name (instead of always being "output")
6836 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6837 times directly, rather than depending upon the (possibly missing)
6838 .progress object. Use 'None' to indicate "not started/finished
6840 (BuildStepStatus.getExpectations): oops, return the full list of
6842 (BuilderStatus._buildFinished): append finished builds to .builds
6844 * buildbot/process/step.py (BuildStep): add separate .useProgress
6845 flag, since empty .progressMetrics[] still implies that time is a
6847 (CVS): set up the cmd in __init__, instead of waiting for start()
6849 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6850 calculation, this will eventually turn into a proper sourceStamp
6851 (Build.setupBuild): tell the Progress to load from the Expectations,
6852 instead of having the Expectations stuff things into the Progress
6853 (Build.buildException): add a build-level errback to make sure the
6854 build's Deferred fires even in case of exceptions
6856 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6858 * buildbot/process/builder.py (Builder.forceBuild): convey the
6859 reason instead of creating a fake Change
6861 * docs/examples/twisted_master.cfg: update to match reality
6863 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6864 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6865 fix or remove broken/breaking tests
6867 * buildbot/status/event.py (Logfile.__len__): remove evil method
6869 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6870 missing .build, for test convenience
6872 * buildbot/process/step_twisted.py: import fixes
6874 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6876 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6877 .statusbag reference
6879 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6880 connection at shutdown, and stop it from reconnecting
6882 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6883 chase down remote-execution bugs
6885 * buildbot/process/step.py: more fixes, remove
6886 BuildStep.setStatus()
6887 * buildbot/status/builder.py: move setStatus() functionality into
6889 * buildbot/status/event.py: minor fixes
6891 2004-08-03 Brian Warner <warner@lothar.com>
6893 * buildbot/process/base.py, buildbot/process/builder.py
6894 * buildbot/process/step.py, buildbot/status/builder.py
6895 * buildbot/status/event.py, buildbot/test/test_run.py:
6896 fix status delivery, get a basic test case working
6897 * buildbot/master.py: finish implementing basic status delivery,
6898 temporarily disable HTML/IRC/PB status sources
6900 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6902 * buildbot/status/progress.py (BuildProgress): remove dead code
6904 * buildbot/interfaces.py
6905 * buildbot/process/base.py, buildbot/process/builder.py
6906 * buildbot/process/step.py, buildbot/process/step_twisted.py
6907 * buildbot/status/builder.py: Complete overhaul of the all
6908 status-delivery code, unifying all types of status clients (HTML,
6909 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6910 look like. This commit is a checkpointing of the work-in-progress:
6911 the input side is mostly done (Builders/Builds sending status
6912 to the BuilderStatus/BuildStatus objects), but the output side has
6913 not yet been started (HTML resources querying BuilderStatus
6914 objects). Things are probably very broken right now and may remain
6915 so for several weeks, I apologize for the disruption.
6917 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6918 HTML as the log's contents. Currently used for exception tracebacks.
6919 * buildbot/status/progress.py: minor spelling changes
6921 2004-08-02 Brian Warner <warner@lothar.com>
6923 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6924 in mozilla. Also added stylesheets copied from Twisted's docs.
6925 Remember that these files are meant to be run through Lore first.
6926 Thanks to Philipp Frauenfelder for the fixes.
6927 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6928 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6929 * docs/template.tpl: added a Lore template
6931 2004-07-29 Brian Warner <warner@lothar.com>
6933 * buildbot/interfaces.py: revamp status delivery. This is the
6934 preview: these are the Interfaces that will be provided by new
6935 Builder code, and to which the current HTML/IRC/PB status
6936 displayers will be adapted.
6938 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6939 on the SlaveBuilder, not the Bot.
6940 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6942 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6943 set .usePTY on the FakeSlaveBuilder
6945 2004-07-25 Brian Warner <warner@lothar.com>
6947 * buildbot/changes/freshcvs.py: add some debug log messages
6948 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6949 disabled 'setFilter' syntax
6950 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6951 don't end with a slash
6953 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6955 * setup.py: bump to 0.5.0+ while between releases
6957 2004-07-23 Brian Warner <warner@lothar.com>
6959 * setup.py (version): Releasing buildbot-0.5.0
6961 2004-07-23 Brian Warner <warner@lothar.com>
6963 * README: update for 0.5.0 release
6965 * NEWS: update for 0.5.0 release
6967 2004-07-22 Brian Warner <warner@lothar.com>
6969 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6970 mktap-time configuration flag (--usepty=1, --usepty=0)
6971 * buildbot/bot.py: same
6973 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6974 an 'info' directory being unwanted
6976 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6977 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6978 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6979 and earlier), use a FreshCVSSourceOldcred instead.
6980 (test): simple test routine: connect to server, print changes
6982 * buildbot/changes/changes.py (Change.getTime): make it possible
6983 to print un-timestamped changes
6985 * buildbot/master.py (makeApp): delete ancient dead code
6986 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6987 * buildbot/test/test_config.py (testFindConfigFile): test it
6989 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6990 instead of win32 one
6993 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6994 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6997 * buildbot/process/base.py (Builder.__init__): change constructor
6998 to accept a dictionary of config data, rather than discrete
6999 name/slave/builddir/factory arguments
7001 * docs/examples/twisted_master.cfg: update to new syntax
7002 * docs/examples/glib_master.cfg: same
7003 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7004 rough tests of the new syntax
7007 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7008 to be an int, which means "run a web.distrib sub-server on a TCP
7009 port". This lets you publish the buildbot status page to a remote
7010 twisted.web server (using distrib.ResourceSubscription). Also
7011 rename the local attributes used to hold these web things so
7012 they're more in touch with reality.
7013 * buildbot/test/test_web.py: test webPortnum and webPathname
7014 * docs/config.xhtml: document this new use of webPathname
7016 * docs/config.xhtml: new document, slightly ahead of reality
7018 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7019 'prefix' handling: treat it as a simple string to check with
7020 .startswith, instead of treating it as a directory. This allows
7021 sub-directories to be used. If you use prefix=, you should give it
7022 a string that starts just below the CVSROOT and ends with a slash.
7023 This prefix will be stripped from all filenames, and filenames
7024 which do not start with it will be ignored.
7026 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7028 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7029 and --exclude (inverse of --include). SVN post-commit hooks
7030 now have total control over which changes get sent to buildbot and which
7033 2004-07-10 Brian Warner <warner@lothar.com>
7035 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7036 test case to match new API
7038 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7039 which crashed HTML display when self.entries=[] (needed to
7040 distinguish between [], which means "no entries yet", and None,
7041 which means "the entries have been swapped out to disk, go fetch
7044 2004-07-04 Brian Warner <warner@lothar.com>
7046 * buildbot/process/step_twisted.py (countFailedTests): Count
7047 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7048 10kb from the end because any import errors are wedged there and
7049 they would make us think the test log was unparseable.
7050 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7052 2004-06-26 Brian Warner <warner@lothar.com>
7054 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7055 delete-*.pyc command into an actual BuildStep, so we can label it
7057 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7058 (FullTwistedBuildFactory): same
7060 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7062 * contrib/fakechange.py: Add an errback when sending the fake
7063 change, so we know it didn't work.
7065 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7067 * buildbot/process/step_twisted.py: Delete *.pyc files before
7068 calling trial, so it doesn't catch any old .pyc files whose .py
7069 files have been moved or deleted.
7071 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7072 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7073 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7074 instead of ["twisted.test"], so that the end result is "trial -R
7077 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7078 regular expression to match filenames that should be ignored when
7079 changed. Also add a --revision parameter that specifies the
7080 revision to examine, which is useful for debugging.
7082 2004-06-25 Brian Warner <warner@lothar.com>
7084 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7085 summary of warnings (like DeprecationWarnings), next to the
7088 2004-05-13 Brian Warner <warner@lothar.com>
7090 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7091 we now have a w32 build slave courtesy of Mike Taylor.
7093 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7094 so broken. Fixed a race condition that tripped up interlocked
7095 builds and caused the status to be stuck at "Interlocked" forever.
7096 The twisted buildbot's one interlocked build just so happened to
7097 never hit this case until recently (the feeding builds both pass
7098 before the interlocked build is attempted.. usually it has to wait
7100 (Builder._pong_failed): fix method signature
7102 * setup.py: bump to 0.4.3+ while between releases
7104 2004-04-30 Brian Warner <warner@lothar.com>
7106 * setup.py (version): Releasing buildbot-0.4.3
7108 2004-04-30 Brian Warner <warner@lothar.com>
7110 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7112 * README: update for 0.4.3 release
7114 * NEWS: update for 0.4.3 release
7116 * buildbot/master.py (BuildMaster.__getstate__): make sure
7117 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7119 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7120 .trial as a class attribute, for upgrade from 0.4.2
7122 * buildbot/changes/changes.py (Change.links): add .links for
7125 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7126 .textWatchers and .htmlWatchers at save time, since they are both
7127 volatile, should allow smooth 0.4.2 upgrade
7129 * buildbot/process/step.py (CVS.finishStatus): catch failed
7130 CVS/SVN commands so we can make the status box red
7132 2004-04-29 Brian Warner <warner@lothar.com>
7134 * buildbot/changes/freshcvs.py
7135 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7136 code to do setFilter(), which tells the freshcvs daemon to not
7137 send us stuff that we're not interested in. I will uncomment it
7138 when a new version of CVSToys is available in which setFilter()
7139 actually works, and I get a chance to test it better.
7141 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7143 * buildbot/master.py (Dispatcher): use a registration scheme
7144 instead of hardwired service names
7145 (BuildMaster): keep track of the Dispatcher to support
7148 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7149 PBChangeSource class instead of having it be an undocumented
7150 internal feature of the ChangeMaster. Split out the code into a
7152 * buildbot/changes/pb.py (PBChangeSource): same
7153 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7155 * docs/{factories|sources|steps}.xhtml: document some pieces
7157 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7158 using FCMaildirSource
7159 (f23osx): update OS-X builder to use python2.3, since the slave
7160 was updated to Panther (10.3.3)
7162 2004-03-21 Brian Warner <warner@lothar.com>
7164 * buildbot/process/process_twisted.py: factor out doCheckout, change
7165 to use SVN instead of CVS
7167 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7168 an SVN subclass easier
7169 (BasicSVN): subclass which uses Subversion instead of CVS
7171 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7173 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7175 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7177 2004-02-25 Brian Warner <warner@lothar.com>
7179 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7180 is now either a list (which is passed to spawnProcess directly) or
7181 a string (which gets passed to /bin/sh -c). This removes the useSH
7182 flag and the ArgslistCommand class. Also send status header at the
7183 start and end of each command, instead of having the master-side
7185 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7186 -r'. Update to use list-based arguments.
7187 (SVNFetch): use list-based arguments, use ['dir'] argument to
7189 * buildbot/test/test_steps.py (Commands): match changes
7191 * buildbot/process/step.py (InternalShellCommand.words): handle
7193 (SVN): inherit from CVS, cleanup
7195 * buildbot/status/event.py (Logfile.content): render in HTML, with
7196 stderr in red and headers (like the name of the command we're
7197 about to run) in blue. Add link to a second URL (url + "?text=1")
7198 to get just stdout/stderr in text/plain without markup. There is
7199 still a problem with .entries=None causing a crash, it seems to occur
7200 when the logfile is read before it is finished.
7202 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7203 timeout to the keepalives, and use it to explicitly do a
7204 loseConnection instead of waiting for TCP to notice the loss. This
7205 ought to clear up the silent-lossage problem.
7206 (unsafeTracebacks): pass exception tracebacks back to the master,
7207 makes it much easier to debug problems
7209 2004-02-23 Brian Warner <warner@lothar.com>
7211 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7212 the whole command to /bin/sh instead of execve [Johan Dahlin]
7213 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7214 '-r HEAD' [Johan Dahlin]
7215 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7217 * buildbot/changes/changes.py (Change): add links= argument, add
7218 asHTML method [Johan Dahlin]. Modified to make a bit more
7219 XHTMLish. Still not sure how to best use links= .
7221 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7222 Change.asHTML to display the change, not asText
7224 * buildbot/status/html.py (StatusResourceBuilder): web button to
7227 * buildbot/test/test_run.py: test to actually start a buildmaster
7230 * MANIFEST.in: bring back accidentally-dropped test helper files
7232 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7233 that require cvstoys if it is not installed
7235 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7236 values of "bin/trial" [Dave Peticolas]
7237 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7238 tests passed" when we didn't happen to run any tests
7240 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7241 flunkOnFailure [Johan Dahlin]
7243 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7244 multiple instances of the same Step class by suffixing "_2", etc,
7245 to the name until it is unique. This name needs to be unique
7246 because it is used as a key in the dictionary that tracks build
7248 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7251 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7253 2004-01-14 Brian Warner <warner@lothar.com>
7255 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7256 kicked from a channel, log it
7258 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7259 something over whatever IRC channels the buildmaster is currently
7260 connected to. Added to try and track down a problem in which the
7261 master thinks it is still connected but the IRCd doesn't see it. I
7262 used a styles.Versioned this time, so hopefully users won't have
7263 to rebuild their .tap files this time.
7264 * contrib/debug.glade: add a "Poke IRC" button
7265 * contrib/debugclient.py: same
7267 * setup.py: bump to 0.4.2+ while between releases
7269 2004-01-08 Brian Warner <warner@lothar.com>
7271 * setup.py (version): Releasing buildbot-0.4.2
7273 2004-01-08 Brian Warner <warner@lothar.com>
7275 * NEWS: update for 0.4.2 release
7277 * README: document how to run the tests, now that they all pass
7279 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7281 * buildbot/process/step.py (CVS): add a global_options= argument,
7282 which lets you set CVS global options for the command like "-r"
7283 for read-only checkout, or "-R" to avoid writing in the
7285 * buildbot/slavecommand.py (CVSCommand): same
7287 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7288 testing easier (it is turned off when testing, to avoid the
7291 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7292 to make it easier to test: break generateStepID() out to a
7293 separate function, only update statusbag if it exists.
7294 (ShellCommands): create useful text for dict-based commands too.
7296 * test/*, buildbot/test/*: move unit tests under the buildbot/
7298 * setup.py (packages): install buildbot.test too
7300 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7301 * buildbot/test/test_steps.py: fix it, tests pass now
7303 2004-01-06 Brian Warner <warner@lothar.com>
7305 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7306 freshcvs mail uses a slightly different syntax for new
7307 directories. Update parser to handle either.
7308 * test/test_mailparse.py (Test1.testMsg9): test for same
7310 2003-12-21 Brian Warner <warner@lothar.com>
7312 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7313 'warnOnWarnings' so that lintian errors mark the build orange
7315 2003-12-17 Brian Warner <warner@lothar.com>
7317 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7318 messages emitted by Bonsai, contributed by Stephen Davis.
7320 * test/*: moved all tests to use trial instead of unittest. Some
7321 still fail (test_steps, test_slavecommand, and test_process).
7323 * setup.py (version): bump to 0.4.1+ while between releases
7325 2003-12-09 Brian Warner <warner@lothar.com>
7327 * setup.py (version): Releasing buildbot-0.4.1
7329 2003-12-09 Brian Warner <warner@lothar.com>
7331 * NEWS: update for 0.4.1 release
7333 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7334 freebsd builder code a little bit
7336 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7337 don't try to compare attributes of different classes
7338 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7339 (MaildirSource.messageReceived): fix Change delivery
7341 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7342 into the config file's namespace before loading it, like the
7343 documentation claims it does
7344 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7345 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7346 daemon comes back online
7348 2003-12-08 Brian Warner <warner@lothar.com>
7350 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7351 so the example will work with online=0 as well
7353 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7354 fix the __implements__ line
7356 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7357 class a twisted.application.service.Service, use startService to
7360 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7361 directory fd instead of simple open(). I'm sure this used to work,
7362 but the current version of python refuses to open directories with
7365 2003-12-05 Brian Warner <warner@lothar.com>
7367 * setup.py (version): bump to 0.4.0+ while between releases
7369 2003-12-05 Brian Warner <warner@lothar.com>
7371 * setup.py (version): Releasing buildbot-0.4.0
7373 2003-12-05 Brian Warner <warner@lothar.com>
7375 * docs/examples/glib_master.cfg: replace old sample scripts with
7376 new-style config files
7377 * MANIFEST.in: include .cfg files in distribution tarball
7379 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7380 implement a dummy method to avoid the exception that occurs when
7381 freshcvs sends this to us.
7383 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7384 removed the method, as it broke reconnection. Apparently
7385 stopFactory is called each time the connection attempt fails. Must
7387 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7388 attribute before serialization, since without stopFactory the
7389 reconnect timer may still be active and they aren't serializable.
7391 * test/test_mailparse.py (ParseTest): test with 'self' argument
7393 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7394 argument, as these "functions" are invoked like methods from class
7395 attributes and therefore always get an instance as the first
7398 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7399 message: thanks to Stephen Davis for the catch
7401 2003-12-04 Brian Warner <warner@lothar.com>
7403 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7404 twisted's standard ReconnectingClientFactory. Handles both oldcred
7405 and newcred connections. Also has a bug-workaround for
7406 ReconnectingClientFactory serializing its connector when it
7409 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7410 pbutil. Replace makeApp stuff with proper newcred/mktap
7411 makeService(). Don't serialize Ephemerals on shutdown.
7413 * buildbot/changes/changes.py (ChangeMaster): make it a
7414 MultiService and add the sources as children, to get startService
7415 and stopService for free. This also gets rid of the .running flag.
7417 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7418 new pbutil, turn into a TCPClient at the same time (to get
7419 startService for free). Two variants exist: FreshCVSSourceOldcred
7420 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7421 yet, but when it does, we'll be ready).
7422 (FreshCVSSource.notify): handle paths which are empty after the
7423 prefix is stripped. This only happens when the top-level (prefix)
7424 directory is added, at the very beginning of a Repository's life.
7426 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7427 Now the only reconnecting code is in the factory where it belongs.
7428 (Builder.unsubscribe): unregister the disconnect callback when we
7429 delete the builder on command from the master (i.e. when the
7430 buildmaster is reconfigured and that builder goes away). This
7431 fixes a multiple-delete exception when the status client is shut
7433 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7436 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7437 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7439 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7441 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7442 a list of globs (ugh). The testdir will be searched for files
7443 named *.tests and run the tests in the order specified in each of
7444 those files. This allows for "dependancies" between tests to be
7447 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7448 argument to pass to run_maxq.py, instead of a glob.
7450 2003-10-17 Brian Warner <warner@lothar.com>
7452 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7453 files that live in the sandbox
7455 2003-10-15 Brian Warner <warner@lothar.com>
7457 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7458 spelling error in "docs" count-warnings output
7459 (HLint.start): stupid thinko meant .xhtml files were ignored
7461 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7462 tests now that cReactor is banished to the sandbox
7464 2003-10-10 Brian Warner <warner@lothar.com>
7466 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7467 scheme: now .xhtml are sources and .html are generated
7469 2003-10-08 Brian Warner <warner@lothar.com>
7471 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7472 we were ignoring the 'randomly' parameter.
7474 2003-10-01 Brian Warner <warner@lothar.com>
7476 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7477 posix, to kill sub-children of aborted slavecommands.
7479 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7480 Clean up initialization: lastBuildStatus remains None until the
7481 first build has been completed.
7483 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7484 None as a lastBuildStatus
7485 * buildbot/clients/gtkPanes.py: same
7487 * buildbot/status/client.py (StatusClientService): keep
7488 BuilderStatus objects in self.statusbags . These objects now live
7489 here in the StatusClientService and are referenced by the Builder
7490 object, rather than the other way around.
7491 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7492 * buildbot/process/base.py (Builder): same
7493 * test/test_config.py (ConfigTest.testBuilders): same
7495 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7496 an existing builder, leave the statusbag alone. This will preserve the
7499 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7500 hook. This will probably go away in favor of a class in upcoming
7503 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7504 serviceName from newcred FreshCVSNotifiee setup
7506 2003-09-29 Brian Warner <warner@lothar.com>
7508 * buildbot/process/process_twisted.py: switch to new reactor
7510 * docs/examples/twisted_master.cfg: same
7512 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7514 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7515 botmaster reference instead of the oldapp service lookup
7517 * buildbot/master.py (BuildMaster.__init__): give the
7518 StatusClientService a reference to the botmaster to make it easier to
7521 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7523 * buildbot/status/html.py (Box.td): escape hreffy things so you
7524 can have spaces in things like builder names
7525 (StatusResourceBuilder.body)
7526 (WaterfallStatusResource.body)
7527 (WaterfallStatusResource.body0): same
7529 2003-09-25 Brian Warner <warner@lothar.com>
7531 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7532 rearrange the builder list when adding or removing builders: keep
7533 them in the order the user requested.
7534 * test/test_config.py (ConfigTest.testBuilders): verify it
7536 * contrib/debug.glade: give the debug window a name
7538 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7539 now wait on multiple interlocks. Fix code relating to that.
7540 (Builder.checkInterlocks): same
7541 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7543 * buildbot/master.py (BuildMaster.loadConfig): move from
7544 deprecated pb.BrokerFactory to new pb.PBServerFactory
7545 * test/test_config.py (ConfigTest.testWebPathname): same
7547 * docs/examples/twisted_master.cfg: fix interlock declaration
7549 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7550 Interlocks to their Builders into interlock.py .
7551 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7553 * test/test_config.py (ConfigTest.testInterlocks): validate
7556 * buildbot/process/base.py (Builder.__init__): better comments
7557 * buildbot/process/interlock.py (Interlock.__repr__): same
7558 (Interlock.deactivate): add .active flag, move the code that
7559 attaches/detaches builders into the Interlock
7561 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7563 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7564 tests using the new run_maxq.py script, and reporting failures by
7567 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7568 tests, reporting their success or failure in a buildbot-friendly
7571 2003-09-24 Brian Warner <warner@lothar.com>
7573 * docs/examples/twisted_master.cfg: example of a new-style config
7574 file. This lives in the buildmaster base directory as
7577 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7578 button to make the master re-read its config file
7580 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7581 buildmaster configuration from a file. This file can be re-read
7582 later, and the buildmaster will update itself to match the new
7583 desired configuration. Also use new Twisted Application class.
7584 * test/Makefile, test/test_config.py: unit tests for same
7586 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7587 FreshCVSSources comparable, to support reload.
7588 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7590 * buildbot/process/base.py (Builder): make them comparable, make
7591 Interlocks easier to attach, to support reload. Handle
7592 re-attachment of remote slaves.
7593 * buildbot/process/interlock.py (Interlock): same
7595 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7596 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7597 buildmaster taps are now constructed with mktap.
7598 * buildbot/status/client.py (StatusClientService): same
7600 * buildbot/status/words.py: move to new Services, add support to
7601 connect to multiple networks, add reload support, allow nickname
7602 to be configured on a per-network basis
7604 2003-09-20 Brian Warner <warner@lothar.com>
7606 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7607 the freebsd builder, now that the machine has been upgraded and no
7608 longer has python2.2
7610 * setup.py (version): bump to 0.3.5+ while between releases
7612 2003-09-19 Brian Warner <warner@lothar.com>
7614 * setup.py (version): Releasing buildbot-0.3.5
7616 2003-09-19 Brian Warner <warner@lothar.com>
7618 * NEWS: add post-0.3.4 notes
7620 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7622 * MANIFEST.in: add contrib/*
7624 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7625 use a remote root now: cvs.twistedmatrix.com
7627 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7629 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7630 compatibility with old servers
7631 (FreshCVSSource.start): and provide a way to use it
7632 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7634 * docs/examples/twisted_master.py (twisted_app): update to new
7636 (twisted_app): listen on new ~buildbot socket
7637 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7639 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7640 to reduce cvs bandwidth (update instead of full checkout)
7642 2003-09-11 Brian Warner <warner@lothar.com>
7644 * contrib/fakechange.py: demo how to connect to the changemaster
7645 port. You can use this technique to submit changes to the
7646 buildmaster from source control systems that offer a hook to run a
7647 script when changes are committed.
7649 * contrib/debugclient.py: tool to connect to the debug port. You
7650 can use it to force builds, submit fake changes, and wiggle the
7653 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7654 'Dispatcher' realm to handle all the different kinds of
7655 connections and Perspectives: buildslaves, the changemaster port,
7656 the debug port, and the status client port. NewCredPerspectives
7657 now have .attached/.detached methods called with the remote 'mind'
7658 reference, much like old perspectives did. All the pb.Services
7659 turned into ordinary app.ApplicationServices .
7660 (DebugService): went away, DebugPerspectives are now created
7661 directly by the Dispatcher.
7662 (makeApp): changed interface a little bit
7664 * buildbot/changes/changes.py: newcred
7665 * buildbot/status/client.py: newcred
7667 * buildbot/clients/base.py: newcred client side changes
7668 * buildbot/bot.py: ditto
7670 * docs/examples/glib_master.py: handle new makeApp() interface
7671 * docs/examples/twisted_master.py: ditto
7673 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7674 base newcred Perspectives on. This should go away once Twisted
7675 itself provides something sensible.
7678 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7680 * contrib/svn_buildbot.py: A program that you can call from your
7681 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7682 when a change in an SVN repository has happened. See the top of
7683 the file for some minimal usage info.
7685 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7687 * buildbot/slavecommand.py (ArglistCommand): Add new
7688 ArglistCommand that takes an argument list rather than a string as
7689 a parameter. Using a st.split() for argv is very bad.
7691 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7692 update to a particular revision rather than always checking out
7693 (still not very smart about it, there may be cases where the
7694 checkout becomes inconsistent).
7696 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7698 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7699 SVN fetch support. It can checkout (not update!) a specified
7700 revision from a specified repository to a specified directory.
7702 * buildbot/status/progress.py (Expectations.update): Fix an
7703 obvious bug (apparently created by the change described in the
7704 previous ChangeLog message) by moving a check to *after* the
7705 variable it checks is defined.
7708 2003-09-08 Brian Warner <warner@lothar.com>
7710 * buildbot/status/progress.py (Expectations.update): hack to catch
7711 an exception TTimo sees: sometimes the update() method seems to
7712 get called before the step has actually finished, so the .stopTime
7713 is not set, so no totalTime() is available and we average None
7714 with the previous value. Catch this and just don't update the
7715 metrics, and emit a log message.
7717 2003-08-24 Brian Warner <warner@lothar.com>
7719 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7720 parameter to set copydir='original' in CVS commands.
7722 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7724 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7725 which tells the command to maintain a separate original-source CVS
7726 workspace. For each build, this workspace will be updated, then
7727 the tree copied into a new workdir. This reduces CVS bandwidth
7728 (from a full checkout to a mere update) while doubling the local
7729 disk usage (to keep two copies of the tree).
7731 2003-08-21 Brian Warner <warner@lothar.com>
7733 * buildbot/status/event.py (Logfile.addEntry): if the master web
7734 server dies while we're serving a page, request.write raises
7735 pb.DeadReferenceError . Catch this and treat it like a
7736 notifyFinish event by dropping the request.
7738 2003-08-18 Brian Warner <warner@lothar.com>
7740 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7741 (instead of blowing up) if a force-build command is given without
7744 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7745 don't blow up if there aren't yet any Changes in the list
7747 2003-08-02 Brian Warner <warner@lothar.com>
7749 * buildbot/bot.py (updateApplication): don't set the .tap name,
7750 since we shouldn't assume we own the whole .tap file
7752 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7753 'mktap buildbot' (without a subcommand) better
7755 2003-07-29 Brian Warner <warner@lothar.com>
7757 * buildbot/status/words.py
7758 (IrcStatusFactory.clientConnectionLost): when we lose the
7759 connection to the IRC server, schedule a reconnection attempt.
7761 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7762 use shutil.rmtree instead of forking off an "rm -rf" command.
7763 rmtree may take a while and will block until it finishes, so we
7764 use "rm -rf" if available.
7766 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7767 freebsd buildslave badly
7769 * setup.py (version): bump to 0.3.4+ while between releases
7771 2003-07-28 Brian Warner <warner@lothar.com>
7773 * setup.py (version): Releasing buildbot-0.3.4
7775 2003-07-28 Brian Warner <warner@lothar.com>
7777 * NEWS: update in preparation for release
7779 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7780 process.signalProcess instead of os.kill, to improve w32
7783 * docs/examples/twisted_master.py (twisted_app): turn off
7784 win32eventreactor: the tests hang the buildslave badly
7786 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7787 failed builds, since usually the failures are consistent
7789 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7790 add compileOpts/compileOpts2 to reactors build
7792 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7793 (twisted_app): use both default and win32eventreactor on w32 build.
7794 Use both default and kqreactor on freebsd build.
7796 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7797 add compileOpts2, which is put after the build_ext argument. w32
7798 needs "-c mingw32" here.
7800 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7801 touch .acqpath, it goes away in recent Twisted releases
7803 * docs/examples/twisted_master.py (twisted_app): use "python" for
7804 the w32 buildslave, not "python2.2"
7806 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7807 the directory exists.. should hush an exception under w32
7809 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7810 ProcessTerminated -provided values for signal and exitCode rather
7811 than parsing the unix status code directly. This should remove one
7812 more roadblock for a w32-hosted buildslave.
7814 * test/test_mailparse.py: add test cases for Syncmail parser
7816 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7817 temporary compatibility import. Note! Start importing
7818 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7820 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7822 2003-07-27 Brian Warner <warner@lothar.com>
7824 * NEWS: started adding new features
7826 * buildbot/changes/mail.py: start work on Syncmail parser, move
7827 mail sources into their own file
7829 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7830 as implementing IChangeSource
7831 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7833 * buildbot/interfaces.py: define the IChangeSource interface
7835 2003-07-26 Brian Warner <warner@lothar.com>
7837 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7839 2003-06-25 Brian Warner <warner@lothar.com>
7841 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7844 2003-06-17 Brian Warner <warner@lothar.com>
7846 * buildbot/status/words.py: clean up method usage to avoid error
7847 in silly IRC command
7848 (IrcStatusBot.emit_status): round off seconds display
7850 * buildbot/process/base.py (Build): delete the timer when saving
7851 to the .tap file, and restore it (if it should still be running)
7852 upon restore. This should fix the "next build in -34 seconds"
7853 messages that result when the master is restarted while builds are
7854 sitting in the .waiting slot. If the time for the build has
7855 already passed, start it very soon (in 1 second).
7857 * buildbot/status/words.py: more silly commands
7859 * README (REQUIREMENTS): add URLs to all required software
7861 * buildbot/status/words.py ('last'): mention results of, and time
7864 2003-05-28 Brian Warner <warner@lothar.com>
7866 * buildbot/status/words.py: add 'last' command
7867 (IrcStatusBot.emit_status): add current-small text to 'status' output
7869 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7870 (twisted_app): remove spaces from OS-X builder name
7872 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7873 * buildbot/status/words.py: IRC bot should actually be useful now
7875 2003-05-23 Brian Warner <warner@lothar.com>
7877 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7878 "slave information" from $(slavedir)/info/* . These files are
7879 maintained by the slave administrator, and describe the
7880 machine/environment that is hosting the slave. Information from
7881 them is put into the "Builder" HTML page. Still need to establish
7882 a set of well-known filenames and meanings for this data: at the
7883 moment, *all* info/* files are sent to the master, but only
7884 'admin' and 'host' are used on that end.
7885 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7886 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7887 * buildbot/master.py (BotPerspective.got_info): ditto
7889 2003-05-22 Brian Warner <warner@lothar.com>
7891 * setup.py (version): bump version to 0.3.3+ while between releases
7893 2003-05-21 Brian Warner <warner@lothar.com>
7895 * setup.py: Releasing buildbot-0.3.3
7897 2003-05-21 Brian Warner <warner@lothar.com>
7899 * NEWS: 0.3.3 news items
7901 * README: describe --keepalive and life behind a NAT box
7903 * buildbot/bot.py (Bot.connected): implement application-level
7904 keepalives to deal with NAT timeouts, turn them on with
7905 --keepalive option or when SO_KEEPALIVE doesn't work.
7907 * buildbot/master.py (BotPerspective): accept keepalives silently
7909 * buildbot/process/base.py (Build.buildException): CopiedFailures
7910 don't carry as much information as local ones, so don't try to
7911 create a big HTMLized version of them.
7913 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7914 log file when step fails due to an exception, such as when the slave
7917 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7918 --testmodule argument instead of grepping for test-case-name tags
7919 ourselves. Remove FindUnitTests code.
7920 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7922 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7924 2003-05-16 Brian Warner <warner@lothar.com>
7926 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7927 argument to allow things like CFLAGS=-O0 to be passed without relying
7928 upon /bin/sh processing on the slave.
7930 * buildbot/process/step.py (InternalShellCommand.start): send
7932 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7933 'split' instead of letting /bin/sh do it. This should also remove
7934 the need for /bin/sh on the buildslave, making it more likely to
7937 * buildbot/status/html.py: html-escape text in blamelist.
7938 Add "force build" button to the Builder page.
7940 * buildbot/process/step_twisted.py (countFailedTests): look at
7941 last 1000 characters for status line, as import errors can put it
7942 before the -200 point.
7944 2003-05-15 Brian Warner <warner@lothar.com>
7946 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7948 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7949 make 'clobber' a parameter, so it is possible to have builds which
7950 do full tests but do a cvs update instead of hammering the CVS
7951 server with a full checkout each build
7953 * buildbot/process/step.py (InternalShellCommand): bump default
7954 timeout to 20 minutes
7956 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7957 the master to trigger a build. Run it via manhole.
7959 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7960 allow slaves to trigger any build that they host, to make life
7961 easier for slave admins who are testing out new build processes
7963 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7964 don't flunk cReactor or qtreactor on failure, since they fail alot
7965 these days. Do warnOnFailure instead.
7967 * buildbot/process/base.py: change Builder.buildable from a list
7968 into a single slot. When we don't have a slave, new builds (once
7969 they make it past the timeout) are now merged into an existing
7970 buildable one instead of being queued. With this change, a slave
7971 which has been away for a while doesn't get pounded with all the
7972 builds it missed, but instead just does a single build.
7974 2003-05-07 Brian Warner <warner@lothar.com>
7976 * setup.py (version): bump version to 0.3.2+ while between releases
7978 2003-05-07 Brian Warner <warner@lothar.com>
7980 * setup.py: Releasing buildbot-0.3.2
7982 2003-05-07 Brian Warner <warner@lothar.com>
7984 * setup.py: fix major packaging error: include subdirectories!
7986 * NEWS: add changes since last release
7988 * README (REQUIREMENTS): update twisted/python dependencies
7990 * buildbot/status/builder.py (Builder.startBuild): change
7991 BuildProcess API: now they should call startBuild/finishBuild
7992 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7993 keeping a list of builds in the statusbag, to support other kinds of
7995 (Builder.addClient): send current-activity-small to new clients
7996 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7999 * buildbot/status/client.py: drop RemoteReferences at shutdown
8001 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8003 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8004 more debug messages for remote status client
8006 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8007 (.stepFailed): only fire the Deferred once, even if both
8008 stepComplete and stepFailed are called. I think this can happen if
8009 an exception occurs at a weird time.
8011 * buildbot/status/words.py: work-in-progress: IRC status delivery
8013 2003-05-05 Brian Warner <warner@lothar.com>
8015 * docs/examples/twisted_master.py (twisted_app): hush internal
8016 python2.3 distutils deprecation warnings
8017 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8018 add compileOpts= argument which inserts extra args before the
8019 "setup.py build_ext" command. This can be used to give -Wignore
8020 warnings, to hush some internal python-2.3 deprecation messages.
8022 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8023 the ['twisted.test'] default test case to make it easier to change
8026 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8027 * buildbot/clients/gtkPanes.py: ditto
8029 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8030 arg to collapse RunUnitTestsRandomly into RunUnitTests
8031 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8032 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8034 * buildbot/status/html.py (StatusResource): shuffle Resources
8035 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8036 would serve the waterfall display, but the internal links were
8037 only valid on the trailing-slash version. The correct behavior is
8038 for the non-slashed one to serve a Redirect to the slashed one.
8039 This only shows up when the buildbot page is hanging off another
8040 server, like a Twisted-Web distributed server.
8042 * buildbot/status/event.py (Event, RemoteEvent): make Events
8043 pb.Cacheable, with RemoteEvent as the cached version. This removes
8044 a lot of explicit send-an-update code.
8045 * buildbot/status/builder.py (Builder): remove send-update code
8046 * buildbot/status/client.py (ClientBuilder): remove send-update
8047 code, and log errors that occur during callRemote (mostly to catch
8048 InsecureJelly exceptions)
8050 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8051 run Lore with the same python used in the rest of the build
8053 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8055 * buildbot/process/step_twisted.py (HLint): accept 'python'
8056 argument. Catch rc!=0 and mark the step as failed. This marks the
8057 build orange ("has warnings").
8058 (RunUnitTestsJelly): move out to step_twisted2.py
8060 * buildbot/util.py (ignoreStaleRefs): add utility function
8062 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8063 don't fake ETA object, it's too hard to get right
8065 2003-05-02 Brian Warner <warner@lothar.com>
8067 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8069 2003-05-01 Brian Warner <warner@lothar.com>
8071 * buildbot/status/html.py (StatusResource.body): oops, I was
8072 missing a <tr>, causing the waterfall page to be misrendered in
8073 everything except Galeon.
8075 2003-04-29 Brian Warner <warner@lothar.com>
8077 * docs/examples/twisted_master.py: make debuild use python-2.2
8078 explicitly, now that Twisted stopped supporting 2.1
8080 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8081 handle tuple results too. I keep forgetting this, which suggests
8082 it needs to be rethought.
8084 * setup.py (setup): bump version to 0.3.1+ while between releases
8086 2003-04-29 Brian Warner <warner@lothar.com>
8088 * setup.py: Releasing buildbot-0.3.1
8090 2003-04-29 Brian Warner <warner@lothar.com>
8092 * README (SUPPORT): add plea to send questions to the mailing list
8094 * NEWS, MANIFEST.in: add description of recent changes
8096 * docs/examples/twisted_master.py: add the code used to create the
8097 Twisted buildmaster, with passwords and such removed out to a
8100 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8101 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8102 buildmasters to not require CVSToys be installed.
8103 * README, docs/examples/glib_master: update to match the change
8105 * buildbot/clients/base.py, buildbot/bot.py,
8106 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8107 ReconnectingPB from CVSToys distribution to remove CVSToys
8108 dependency for build slaves and status clients. Buildmasters which
8109 use FreshCVSSources still require cvstoys be installed, of course.
8111 2003-04-25 Brian Warner <warner@lothar.com>
8113 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8114 runTestsRandomly arg to turn on trial -z
8116 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8117 experimental code to use trial's machine-parseable output to get
8118 more detailed test results. Still has some major issues.
8119 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8122 * buildbot/status/builder.py (Builder.setCurrentBuild):
8123 anticipating moving build history into statusbag, not used yet
8125 * buildbot/status/tests.py: code to centralize test results,
8126 doesn't work quite yet
8128 * buildbot/status/event.py (Event): use hasattr("setName") instead
8129 of isinstance for now.. need better long-term solution
8131 * buildbot/status/html.py: Remove old imports
8133 2003-04-24 Brian Warner <warner@lothar.com>
8135 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8136 ignore changes under doc/fun/ and sandbox/
8138 * buildbot/process/step_twisted.py: update pushEvent and friends.
8140 * buildbot/status/html.py (Box.td): replace event.buildername with
8141 event.parent.getSwappableName(). Needs more thought.
8143 * buildbot/status/builder.py (Builder): Replace pushEvent and
8144 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8145 Tell events they are being pruned with event.delete().
8147 * buildbot/process/base.py (Build): Remove Builder status-handling
8148 methods. s/pushEvent/setCurrentActivity/.
8150 * buildbot/process/step.py (BuildStep): clean up status delivery.
8151 Gouse builder.statusbag methods instead of intermediate builder
8152 methods. s/updateLastEvent/updateCurrentActivity/.
8153 s/finalizeLastEvent/finishCurrentActivity/. Use
8154 addFileToCurrentActivity for summaryFunction.
8156 * buildbot/status/event.py (Logfile): put data in a Swappable when
8158 (Event): add more setter methods. Remove .buildername, use .parent
8159 and getSwappableName instead (needs more thought).
8161 * buildbot/util.py (Swappable):
8162 * test/test_swap.py: don't bother setting filename at __init__
8163 time, do it later. Change setFilename args to take parent first,
8164 since it provides the most significant part of the filename.
8166 2003-04-23 Brian Warner <warner@lothar.com>
8168 * buildbot/status/event.py (Logfile.addEntry): append to previous
8171 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8172 anticipating Swappable
8173 (InternalShellCommand.remoteUpdate): split out various log-adding
8174 methods so subclasses can snarf stdout separately
8176 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8177 in anticipation of Swappable build logs
8178 (Builder.testsFinished): anticipating TestResults, still disabled
8180 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8183 * buildbot/status/event.py (Logfile): add (disabled) support for
8184 Swappable, not ready for use yet
8186 * buildbot/util.py (Swappable): object which is swapped out to
8187 disk after some period of no use.
8188 * test/test_swap.py: test buildbot.utils.Swappable
8190 2003-04-14 Brian Warner <warner@lothar.com>
8192 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8193 periodic-build timer. Set the .periodicBuildTime on a builder
8194 instance to some number of seconds to activate it.
8196 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8198 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8199 a way that survives result tuples
8201 2003-04-12 Brian Warner <warner@lothar.com>
8203 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8204 return a dict instead of a tuple: allow summarizers to provide
8205 multiple summaries if they want
8206 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8207 (debuildSummarizer): summarize lintian warnings/errors
8209 2003-04-10 Brian Warner <warner@lothar.com>
8211 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8213 2003-04-09 Brian Warner <warner@lothar.com>
8215 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8216 empty summaries: happens when the tests fail so hard they don't emit
8217 a parseable summary line.
8219 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8220 Allow summaryFunction to return None to indicate no summary should
8223 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8224 writing to stale HTTP requests: notice when they disconnect and
8225 remove the request from the list. Also add CacheToFile from
8226 moshez, will be used later.
8228 2003-04-08 Brian Warner <warner@lothar.com>
8230 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8231 should be an int, not a list of strings
8233 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8234 if we weren't actually connected
8236 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8237 to show the tail end of the trial text output
8239 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8240 hook to summarize the results of a ShellCommand
8242 2003-04-07 Brian Warner <warner@lothar.com>
8244 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8245 twisted test suite code into a single class.
8246 * buildbot/process/process_twisted.py: same
8248 2003-04-04 Brian Warner <warner@lothar.com>
8250 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8252 * README (SLAVE): document use of mktap to create slave .tap file
8253 (REQUIREMENTS): describe dependencies
8255 * buildbot/bb_tap.py, buildbot/plugins.tml:
8256 * buildbot/bot.py (updateApplication): Add mktap support for creating
8257 buildslave .tap files
8259 2003-03-28 Brian Warner <warner@lothar.com>
8261 * buildbot/process/step.py (InternalShellCommand.finished): handle
8262 new tuple result values (fix embarrasing bug that appeared during
8265 2003-03-27 Brian Warner <warner@lothar.com>
8267 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8270 2003-03-25 Brian Warner <warner@lothar.com>
8272 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8273 to overall build status
8274 * buildbot/clients/base.py (Builder): improve event printing
8275 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8276 instead of generic ShellCommand
8277 (Build): Add .stopBuild, use it when slave is detached
8279 * buildbot/process/step.py (Configure,Test): give the steps their
8280 own names and status strings
8282 * buildbot/status/html.py (StatusResource): add "show" argument,
8283 lets you limit the set of Builders being displayed.
8285 2003-03-20 Brian Warner <warner@lothar.com>
8287 * buildbot/process/basic.py: removed
8289 2003-03-19 Brian Warner <warner@lothar.com>
8291 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8292 turn off process-docs by default
8294 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8295 when displaying build information without anything in allBuilds[]
8297 * buildbot/bot.py (makeApp): really take password from sys.argv
8299 2003-03-18 Brian Warner <warner@lothar.com>
8301 * buildbot/bot.py (buildApp): take password from sys.argv
8303 * README: replace with more useful text
8305 * setup.py: add a real one
8306 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8308 * docs/PyCon-2003/: added sources for PyCon paper.
8310 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8311 now Build objects control the process and Builder only handles
8312 slave stuff and distribution of changes/status. A new BuildFactory
8313 class creates Build objects on demand.
8315 Created ConfigurableBuild which takes a list of steps to run. This
8316 makes it a lot easier to set up a new kind of build and moves us
8317 closer to being able to configure a build from a web page.
8319 * buildbot/process/step_twisted.py, process_twisted.py: move to
8320 new model. A lot of code went away.
8322 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8323 send lots of empty progress messages to the client.
8325 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8327 2003-02-20 Brian Warner <warner@lothar.com>
8329 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8331 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8332 Twisted bug that prevented non-pty processes from working just got
8333 fixed, and the bug that leaks ptys is still being investigated.
8335 * buildbot/process/step.py (CVS): send timeout arg to slave
8337 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8338 builders coming and going
8339 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8340 from CVSToys, handle lost-buildmaster
8342 * buildbot/status/client.py (StatusClientService.removeBuilder):
8343 Clean up status client protocol: send builders (with references)
8344 as they are created, rather than sending a list and requiring the
8345 client to figure out which ones are new.
8346 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8347 attempts to force a build on an unknown builder
8349 2003-02-19 Brian Warner <warner@lothar.com>
8351 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8352 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8353 Twisted stops leaking them.
8354 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8355 builder goes to an idle state.
8357 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8358 I figure out why CVS commands hang without them, and/or I fix the
8359 hung-command timeout
8361 2003-02-16 Brian Warner <warner@lothar.com>
8363 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8364 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8365 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8366 GenerateDocs now that they are prefixed with WARNING:.
8368 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8369 use manual href target instead of request.childLink
8371 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8372 display every second, but update the ETA every 5 seconds (or
8373 whenever) as remote_progress messages arrive.
8376 2003-02-12 Brian Warner <warner@lothar.com>
8378 * *: import current sources from home CVS repository
8382 # add-log-time-format: add-log-iso8601-time-string