1 2006-09-08 Brian Warner <warner@lothar.com>
3 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
4 walk through StatusLogs one line at a time, mostly for the benefit
5 of ShellCommand.createSummary methods. You can either walk through
6 STDOUT or STDERR, but the default is STDOUT.
8 * buildbot/status/builder.py (LogFile.readlines): implement it.
9 Note that this is not yet memory-efficient, it just pulls the
10 whole file into RAM and then splits it up with a StringIO.
11 Eventually this should be a generator that only pulls chunks from
13 * buildbot/test/test_status.py (Log.testReadlines): test it
15 * docs/buildbot.texinfo: update to match changes
16 * buildbot/process/factory.py: stop using old definitions
17 * buildbot/process/process_twisted.py: same
18 * buildbot/test/test_*.py: same
20 * buildbot/process/step_twisted.py: move definition to..
21 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
22 relative-import mechanisms prevent this from being named 'twisted'
23 or 'python/twisted' as I would have preferred.
25 * buildbot/process/maxq.py: move definition to..
26 * buildbot/steps/maxq.py: .. here, leave a compatibility import
28 * buildbot/process/step.py: split the user-visible BuildSteps into
29 separate files, all under buildbot/steps/
30 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
31 * buildbot/steps/shell.py: this holds ShellCommand and friends
32 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
34 2006-09-05 Brian Warner <warner@lothar.com>
36 * lots: run pyflakes, removed a lot of unused imports, changed the
37 form of some conditional imports to remove false pyflakes
38 warnings. There are still a number of warnings left, mostly from
39 imports that are done for their side-effects.
40 * buildbot/test/test_vc.py: import twisted.python.failure, since it
43 2006-08-26 Brian Warner <warner@lothar.com>
45 * buildbot/test/test_locks.py (Unit.testLater): make the tests
46 compatible with twisted-1.3.0, for some reason I just can't seem
47 to let go of the past.
49 2006-08-25 Brian Warner <warner@lothar.com>
51 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
53 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
54 all logfiles= in startCommand(), rather than in start() . This
55 makes it easier to have the 'stdio' log come before any secondary
56 logfiles, which I feel makes the waterfall display more
58 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
59 from ShellCommand up into LoggingBuildStep
60 (LoggingBuildStep.__init__): move the handling of logfiles= from
61 ShellCommand up to LoggingBuildStep, because startCommand is
62 provided by LoggingBuildStep, whereas start() was specific to
63 subclasses like ShellCommand and Source. This removes code
64 duplication in those subclasses.
65 (ShellCommand.__init__): same
66 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
67 for a slave that's too old to understand logfiles= into a separate
68 method, so it can live in ShellCommand. The rest of
69 setupLogfiles() can live in LoggingBuildStep.
71 2006-08-24 Brian Warner <warner@lothar.com>
73 * buildbot/locks.py (BaseLock): you can now configure Locks to
74 allow multiple simultaneous owners. They still default to
75 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
77 * docs/buildbot.texinfo (Interlocks): document the new options
78 * buildbot/test/test_locks.py: add a bunch of new unit tests
79 * buildbot/process/base.py (Build.acquireLocks): locks now offer
80 waitUntilMaybeAvailable, not waitUntilAvailable
81 * buildbot/process/step.py (BuildStep.acquireLocks): same
82 * buildbot/master.py (BotMaster.getLockByID): real locks now use
83 the whole lockid in their constructor, not just the name. Also,
84 keep track of which real locks we've handed out by the full
85 lockid, not just class+name, otherwise changing just the maxCount=
86 in the master.cfg file would not actually cause a behavioral
89 2006-08-23 Brian Warner <warner@lothar.com>
91 * buildbot/__init__.py (version): bump to 0.7.4+ while between
93 * docs/buildbot.texinfo: same
95 2006-08-23 Brian Warner <warner@lothar.com>
97 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
98 * docs/buildbot.texinfo: set version to match
99 * NEWS: update for 0.7.4
100 * buildbot/slave/commands.py (command_version): mention that this
101 version (2.1) was released with buildbot-0.7.4
103 2006-08-22 Brian Warner <warner@lothar.com>
107 * CREDITS: new file, list of people who have helped. Thanks!
108 * MANIFEST.in: ship it
110 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
111 new diagrams, the user's manual is more informative than it was.
112 Start shipping the .html user's manual (and generated .png
114 * Makefile: update 'release' target to match
116 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
117 test.. I think the web-parts effort will render it pointless well
118 before it ever actually starts to work.
120 2006-08-20 Brian Warner <warner@lothar.com>
122 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
123 meaning of the prefix= argument. It is now just a string which is
124 stripped from the beginning of the filename. If prefix= is set but
125 not found on any given filename, that filename is ignored. If all
126 filenames in a Change are ignored, the Change is dropped. This is
127 much simpler than the previous sep= nonsense, and I should have
128 implemented it this way from the beginning. Effectively resolves
129 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
130 Gedminas for the catch and suggested fixes.
131 (ChangePerspective.perspective_addChange): implement the actual
133 * buildbot/test/test_changes.py (TestChangePerspective): test it
134 * docs/buildbot.texinfo (PBChangeSource): document it, explain
135 how to properly use prefix=
136 * docs/examples/twisted_master.cfg (source): update prefix= by
137 adding the trailing slash
140 * docs/examples/twisted_master.cfg: update to actual practice
142 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
143 update test case to match new link text.. the HREF has both a
144 class= setting and an enclosing [] pair that I didn't match in the
147 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
148 list of strings is preferred over a single string with embedded
150 (ShellCommand.description=): explain that either single strings or
151 a list of strings is acceptable, and why you might prefer one over
152 the other. Add an example. Fixes SF#1524659, thanks to Paul
153 Winkler for the catch.
154 (Build Steps): update to use f.addStep() rather than using s()
155 and the constructor list
157 * buildbot/process/step.py (ShellCommand): accept either a single
158 string or a list of strings in both description= and
160 * buildbot/test/test_steps.py (Steps.test_description): test it
161 * buildbot/test/runutils.py (makeBuildStep): support for that test
163 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
164 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
165 collecting the files and creating the patch.
167 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
168 per-step URLs that will be displayed on the waterfall display,
169 for things like the HTML output of code-coverage tools, when
170 the results are hosted elsewhere.
171 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
172 way to retrieve these URLs
173 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
174 the method to retrieve these URLs. Also provide backwards
175 compatibility for saved BuildStepStatus instances that didn't have
177 * buildbot/process/step.py (BuildStep.addURL): method to set these
178 URLs from within a BuildStep
179 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
180 (StepBox.getBox): give these external links a distinct CSS class
181 named "BuildStep external" so a .css file can display them
184 * buildbot/test/test_web.py (WaterfallSteps): test that we really
186 * buildbot/test/test_steps.py (Steps): test that we can all the
187 URLs. Also add a bunch of other tests on methods that can be
188 called from within BuildSteps
189 * buildbot/test/runutils.py (makeBuildStep): add utility function
191 2006-08-13 Brian Warner <warner@lothar.com>
193 * docs/buildbot.texinfo (BuildStep LogFiles): document them
195 2006-08-10 Brian Warner <warner@lothar.com>
197 * docs/buildbot.texinfo (Index of master.cfg keys): add another
198 index, this one of things like c['sources'] and c['schedulers']
199 (indices): it looks like my clever idea of putting the @fooindex
200 commands in between the @node and the @subsection (to make the
201 HREF anchor jump to slightly above the section title, which works
202 much better in html) confused texinfo horribly, so I'm moving the
203 index tags back to be just after the @subsection marker. I also
204 added extra lines between the @node/@section paragraph and the
205 index tags, since I think maybe texinfo wants to see these be
208 * docs/Makefile (images): make sure images get built when
210 * docs/images/Makefile: same
212 * buildbot/scripts/runner.py: rename 'buildbot master' to
213 'buildbot create-master', and 'buildbot slave' to 'buildbot
215 * docs/buildbot.texinfo: same
218 * docs/buildbot.texinfo: reimplement the "useful classes" index
219 with actual texinfo indices. The .info rendering is a bit
220 weird-looking but it works well, and the HTML rendering is quite
221 nice. This also puts the index targets in the regular flow of the
222 text, which is easier to maintain.
224 2006-08-06 Brian Warner <warner@lothar.com>
226 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
227 Kevin Turner to prefer the environ= argument be a list rather than
228 a string. If it is a list, it will be joined with a platform-local
229 os.pathsep delimiter, and then prepended to any existing
230 $PYTHONPATH value. This works better in cross-platform (i.e.
231 windows buildslaves) environments when you need to push multiple
232 directories onto the front of the path.
233 (SlaveShellCommand): documented the new magic
234 * docs/buildbot.texinfo (ShellCommand): documented the new magic
235 in a user-visible form
237 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
238 Turner to prefer lists over strings when creating/running VC
239 commands during unit tests. This is clearly necessary to survive
240 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
241 renamed the wq() function to qw() though, since that's how it's
242 spelled in perl. Eventually I'd prefer all commands to be
243 specified with lists.
245 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
246 which are deleted (or not yet created) correctly. Also add
247 failsafe code to not explode if the file-watching poller doesn't
248 get started. Thanks to JP Calderone for the catch and the poller
250 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
252 * buildbot/test/emitlogs.py: same
254 * NEWS: summarize recent changes
256 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
257 clause to avoid the "host key mismatch" warning
259 * buildbot/process/step_twisted.py (Trial.start): if the
260 buildslave is too old to understand logfiles=, fall back to
261 running 'cat _trial_temp/test.log' like before.
262 (Trial.commandComplete): same. this takes advantage of the
263 LoggingBuildStep refactoring to stall commandComplete long enough
264 to run a second RemoteShellCommand.
266 * buildbot/process/step.py (LoggingBuildStep.startCommand):
267 refactor command-completion handling, to allow methods like
268 commandComplete/createSummary/evaluateCommand to return Deferreds.
269 (LoggingBuildStep._commandComplete): delete the refactored method
270 (ShellCommand.setupLogfiles): if the buildslave is too old to
271 understand logfiles=, put a warning message both into twistd.log
272 and into the otherwise empty user-visible LogFiles.
274 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
275 callers to provide the slave-side logfile name, rather than
276 forcing it to come from the local name of the LogFile.
277 (BuildStep.getSlaveName): new method
279 * buildbot/process/base.py (Build.getSlaveName): new method, so
280 steps can find out which buildslave they're running on
282 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
283 to match the s/cvs_ver/command_version/ change
285 2006-08-05 Brian Warner <warner@lothar.com>
287 * buildbot/slave/commands.py (command_version): replace the CVS
288 auto-updated cvs_ver keyword with a manually-updated variable,
289 since CVS is no longer the master repository. Add a description of
290 the remote API change starting in this version (2.1), specifically
291 the fact that SlaveShellCommand now accepts 'initial_stdin',
292 'keep_stdin_open', and 'logfiles'.
294 2006-07-31 Brian Warner <warner@lothar.com>
296 * docs/buildbot.texinfo (System Architecture): Finally add lots of
297 diagrams to describe how the whole system fits together. The
298 images themselves are kept in SVG files, with ascii-art versions
299 in corresponding .txt files. Texinfo knows how to interpolate the
300 text version into .info files, reference the .png versions from
301 .html files, and include .eps versions in the .ps format.
302 * docs/images/Makefile: tools to create .png and .eps
303 * docs/images/*.svg: created pictures with Inkscape.
304 * .darcs-boring: ignore the generated .eps and .png files
306 2006-07-24 Brian Warner <warner@lothar.com>
308 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
309 Scheduler names, since they cause setServiceParent to explode
311 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
313 2006-07-20 Brian Warner <warner@lothar.com>
315 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
316 which runs the buildbot unit tests
318 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
319 classes that are useful in master.cfg
321 2006-07-15 Brian Warner <warner@lothar.com>
323 * Makefile (some-apidocs): new target to build only some epydocs
325 * setup.py: minor comment.. does the classifiers= argument prevent
326 the setup.py script from working on python2.2/2.3?
328 * buildbot/scripts/sample.cfg: update manhole example, arrange into
331 * buildbot/twcompat.py: fix minor typo in comments
333 * buildbot/manhole.py: move all Manhole-related code out to this
334 module. Implement SSH-based manholes (with TwistedConch), and move
335 to conch's nifty line-editing syntax-coloring REPL shell instead
336 of the boring non-editing monochromatic (and deprecated) old
338 * buildbot/master.py: remove all Manhole-related code
339 (BuildMaster.loadConfig._add): make sure the old manhole is
340 removed before we add the new one
341 * docs/buildbot.texinfo (Debug options): document new Manhole options
343 * buildbot/twcompat.py (_which): fix some epydoc issues
344 * buildbot/status/html.py (Waterfall.__init__): same
346 2006-06-29 Brian Warner <warner@lothar.com>
348 * buildbot/interfaces.py: get Interface from b.twcompat to hush
349 deprecation warnings under newer Twisteds (by using
350 zope.interface.Interface instead of old twisted.python.components
352 * buildbot/slave/interfaces.py: same
354 2006-06-28 Brian Warner <warner@lothar.com>
356 * buildbot/slave/commands.py (SVN): add --non-interactive to all
357 svn commands, so it will fail immediately instead of hanging while
358 it waits for a username/password to be typed in.
360 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
361 log message if the step was shut down
363 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
364 obsolete reference to mktap.
366 2006-06-20 Brian Warner <warner@lothar.com>
368 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
369 test to include new 'logfiles' argument sent from master to slave
371 2006-06-19 Brian Warner <warner@lothar.com>
373 * buildbot/process/step_twisted.py (Trial): track Progress from
374 _trial_temp/test.log too
376 * buildbot/process/step.py (OutputProgressObserver): generalize
377 the earlier StdioProgressObserver into an OutputProgressObserver
378 that can track LogFiles other than stdio.
379 (LoggingBuildStep.__init__): same
381 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
382 _trial_temp/test.log, not a separate 'cat' command. TODO: this
383 will fail under windows because of os.sep issues. It might have
384 worked before if 'cat' was doing cygwin path conversion.
386 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
387 creation of LogFileWatchers
388 (ShellCommand._startCommand): and record the files that were
389 watched in the 'headers' section of the ShellCommand output
391 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
392 need to actually pass it to the slave if you want it to work.
393 (ShellCommand): document it a bit
395 * buildbot/test/test_shell.py: new test to validate LogFiles
396 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
398 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
399 before printing the last batch of lines, to test that the polling
400 logic is working properly
402 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
403 handling, making it possible to track multiple logs for a single
404 RemoteCommand. The previous single logfile is now known as the
406 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
407 (RemoteShellCommand.__init__): accept logfiles=
408 (LoggingBuildStep.startCommand): stdio_log is now one of many
409 (ShellCommand): added logfiles= argument, as well as a class-level
410 .logfiles attribute, which will be merged together to figure out
411 which logfiles should be tracked. The latter maybe be useful for
412 subclasses of ShellCommand which know they will aways produce
413 secondary logfiles in the same location.
415 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
416 and closeStdin() methods, preparing to make it possible to write
417 to a ShellCommand's stdin at any time, not just at startup. These
418 writes are buffered if the child process hasn't started yet.
419 (LogFileWatcher): new helper class to watch arbitrary logfiles
420 while a ShellCommand runs. This class polls the file every two
421 seconds, and sends back 10k chunks to the buildmaster.
422 (ShellCommand): rename stdin= to initialStdin=, and add
423 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
425 (ShellCommand.addLogfile): LogFile text is sent in updates with a
426 key of "log" and a value of (logname, data).
427 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
428 'logfiles' to the master-visible args dictionary.
429 (SourceBase.doPatch): match s/stdin/initialStdin/ change
432 * buildbot/test/test_vc.py (Patch.testPatch): same
435 * buildbot/test/emit.py: write to a logfile in the current
436 directory. We use this to figure out what was used as a basedir
437 rather than looking to see which copy of emit.py gets run, so that
438 we can run the commands from inside _trial_temp rather than inside
440 * buildbot/test/subdir/emit.py: same
441 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
442 argument rather than running from buildbot/test/
443 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
444 rather than using an implicit setUp()
445 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
446 (ShellBase.testShell1, etc): use explicit path to emit.py instead
447 of assuming that we're running in buildbot/test/ (and that '.' is
450 * buildbot/slave/commands.py (Command.doStart): refactor Command
451 startup/completion a bit: now the SlaveBuilder calls doStart(),
452 which is not meant for overridding by subclasses, and doStart()
453 calls start(), which is. Likewise the SlaveBuilder calls
454 doInterrupt(), and subclasses override interrupt(). This also puts
455 responsibility for maintaining .running in Command rather than in
457 (Command.doInterrupt): same
458 (Command.commandComplete): same, this is called when the deferred
459 returned by start() completes.
460 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
461 (SlaveBuilder.remote_interruptCommand): same
462 (SlaveBuilder.stopCommand): same
464 2006-06-16 Brian Warner <warner@lothar.com>
466 * buildbot/test/test_shell.py: new test file to contain everything
467 relating to ShellCommand
468 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
469 multiple logfiles in realtime" feature, not yet implemented
470 * buildbot/test/emitlogs.py: support file for testLogFiles
471 * docs/buildbot.texinfo (ShellCommand): document the feature
473 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
475 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
476 for tests which exercise SlaveCommands in isolation.
478 * buildbot/test/test_slavecommand.py: Move some utilities like
479 SignalMixin and FakeSlaveBuilder from here ..
480 * buildbot/test/runutils.py: .. to here, so they can be used by
481 other test classes too
482 * buildbot/test/test_vc.py: more SignalMixin refactoring
483 * buildbot/test/test_control.py: same
484 * buildbot/test/test_run.py: and some rmtree refactoring
486 2006-06-15 Brian Warner <warner@lothar.com>
488 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
489 'testBranch' to match other VC tests and have the tests run in
490 roughly increasing order of dependency
492 * buildbot/test/test_steps.py (LogObserver): new test to verify
493 LogObservers can be created at various times and still get
494 connected up properly
496 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
497 to create BuildStepStatus instances that actually work.
499 * buildbot/process/step.py (LogObserver): add outReceived and
500 errReceived base methods, to be overridden
502 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
503 API to take a name instead of a step, reducing the coupling
504 somewhat. This returns the BuildStepStatus object so it can be
505 passed to the new Step, instead of jamming it directly into the
507 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
509 * buildbot/process/base.py (Build.setupBuild): use both methods
510 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
511 process a bit to match
513 2006-06-14 Brian Warner <warner@lothar.com>
515 * docs/buildbot.texinfo (Adding LogObservers): add some limited
516 docs on writing new LogObserver classes
517 (Writing New Status Plugins): brief docs on how Status Plugins fit
520 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
521 implement a LogObserver that counts how many unit tests have been
523 (Trial.__init__): wire it in
524 * buildbot/test/test_twisted.py (Counter): unit test for it
526 * buildbot/process/step_twisted.py (HLint.commandComplete): update
527 to new cmd.logs['stdio'] scheme
528 (Trial.commandComplete): same
529 (BuildDebs.commandComplete): same
531 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
532 LogFiles, instead of just a single one. The old single logfile is
533 now called "stdio". LoggedRemoteCommand no longer creates a
534 LogFile for you (the code to do that was broken anyway). If you
535 don't create a "stdio" LogFile, then stdout/stderr will be
537 (LogObserver): implement "LogObservers", which a BuildStep can add
538 to parse the output of a command in real-time. The primary use is
539 to provide more useful information to the Progress code, allowing
540 better ETA estimates.
541 (LogLineObserver): utility subclass which feeds complete lines to
542 the parser instead of bytes.
543 (BuildStep.progressMetrics): this is safer as a tuple
544 (BuildStep.setProgress): utility method, meant to be called by
546 (BuildStep.addLogObserver): new method, to be called at any time
547 during the BuildStep (even before any LogFiles have been created),
548 to attach (or schedule for eventual attachment) a LogObserver to a
550 (StdioProgressObserver): new LogObserver which replaces the old
551 "output" progress gatherer
552 (LoggingBuildStep.__init__): same
553 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
554 (LoggingBuildStep._commandComplete): must use logs['stdio']
555 instead of the old single ".log" attribute.
556 * buildbot/status/builder.py (LogFile): remove old logProgressTo
557 functionality, now subsumed into StdioProgressObserver
558 * buildbot/test/test_status.py (Subscription._testSlave_2): the
559 log name changed from "output" to "stdio".
562 * buildbot/interfaces.py (ILogFile): add the Interface used from
563 the BuildStep towards the LogFile
564 (ILogObserver): and the one provided by a LogObserver
565 * buildbot/status/builder.py (LogFile): implement it
567 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
568 HEADER constants here ..
569 * buildbot/status/builder.py (STDOUT): .. from here
571 2006-06-13 Brian Warner <warner@lothar.com>
573 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
574 compatibility with python2.2, which doesn't have the 'substr in
576 (TestP4Poller.makeTime): utility function to construct the
577 timestamp using the same strptime() approach as p4poller does. It
578 turns out that time.mktime() behaves slightly differently under
579 python2.2, probably something to do with the DST flag, and that
580 causes the test to fail under python2.2. (changing the mktime()
581 arguments to have dst=0 instead of -1 caused it to fail under
582 python2.3. Go figure.)
583 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
585 2006-06-12 Brian Warner <warner@lothar.com>
587 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
588 proper Perforce (P4) support. Many many thanks to Scott Lamb for
589 contributing such an excellent patch, including docs and unit
590 tests! This makes it *so* much easier to apply. I had to update
591 test_vc.py to handle some recent refactorings, but everything else
592 applied smoothly. The only remaining thing I'd like to fix would
593 be to remove the hard-wired port 1666 used by p4d, and allow it to
594 claim any unused port. This would allow two copies of the test
595 suite to run on the same host at the same time, as well as
596 allowing the test suite to run while a real (production) p4d was
597 running on the same host. Oh, and maybe we should add a warning to
598 step.P4 that gets emitted if the slave is too old to provide the
599 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
600 * buildbot/slave/commands.py (P4): same
601 (P4Sync): same, some minor updates
602 * buildbot/changes/p4poller.py: same
603 * docs/buildbot.texinfo: same
604 * buildbot/test/test_p4poller.py: same
605 * buildbot/test/test_vc.py (P4): same
607 * setup.py: add Trove classifiers for PyPI
609 2006-06-08 Brian Warner <warner@allmydata.com>
611 * buildbot/status/client.py
612 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
613 changing this from getCurrentBuild() to getCurrentBuilds(). Each
614 build needs to be IRemote'd separately, rather than IRemote'ing
615 the whole list at once. I can't wait until newpb's serialization
616 adapters make this unnecessary.
618 2006-06-06 Brian Warner <warner@lothar.com>
620 * buildbot/process/step.py (WithProperties): make this inherit
621 from ComparableMixin, so that reloading an unchanged config file
622 doesn't cause us to spuriously reload any Builders which use them.
623 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
626 2006-06-03 Brian Warner <warner@lothar.com>
628 * contrib/windows/{setup.py, buildbot_service.py}: add support for
629 running py2exe on windows, contributed by Mark Hammond. Addresses
630 SF#1401121, but I think we still need to include
631 buildbot/scripts/sample.cfg
632 * setup.py: include buildbot_service.py as a script under windows
633 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
634 a py2exe application), get the icon/css datafiles from a different
637 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
638 double-escape the build URL. Thanks to Olivier Bonnet for the
639 patch. Fixes SF#1452801.
641 2006-06-02 Brian Warner <warner@lothar.com>
643 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
644 first six columns of 'svnlook' output, not just the first column,
645 since property changes appear in the other five. Thanks to Olivier
646 Bonnet for the patch. Fixes SF#1398174.
648 2006-06-01 Brian Warner <warner@lothar.com>
650 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
651 the fake build, so that title= has something to be set to
653 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
654 attribute of the "Build #NN" link in the yellow start-the-build
655 box to the build's reason. This means that you get a little
656 tooltip explaining why the build was done when you hover over the
657 yellow box. Thanks to Zandr Milewski for the suggestion.
659 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
660 (Box.setETA): handle ETA=None (by stopping the timer)
661 (Box.update): make the [soon] text less different than the usual
662 text, so the rest of the text doesn't flop around so much. It
663 would be awfully nice to figure out how to center this stuff.
664 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
666 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
667 by default, so that any ShellCommand which fails marks the overall
668 build as a failure. I should have done this from the beginning.
669 Add flunkOnFailure=False to the arguments if you want to turn off
672 2006-05-30 Brian Warner <warner@lothar.com>
674 * buildbot/clients/gtkPanes.py: add a third row: now it shows
675 last-build/current-build/current-step. Show what step is currently
676 running. Show ETA for both the overall build and the current step.
677 Update GTK calls to modern non-deprecated forms. There's still a
678 lot of dead code and debug noise to remove.
680 * buildbot/process/step_twisted.py (Trial): set the step name, so it
681 shows up properly in status displays
683 2006-05-28 Brian Warner <warner@lothar.com>
685 * buildbot/test/test_properties.py (Run.testInterpolate): on the
686 build we use to verify that WithProperties works:
688 ** set flunkOnFailure=True so that build failures get noticed
689 ** set workdir='.' so that the build succeeds, otherwise it is trying
690 to touch 'build/something', and 'build/' doesn't exist because
691 usually that's created by a Source step
692 ** set timeout=10, because Twisted-1.3.0 has a race condition that
693 this test somehow triggers, in which the 'touch' process becomes
694 a zombie and we wait for th etimeout before giving up on it.
696 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
697 to log the Build results and step logs to the twisted log.
698 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
699 what went wrong if a build was expected to succeed but didn't.
701 * buildbot/process/step_twisted.py (Trial): set the default
702 trialMode to '--reporter=bwverbose', which specifies verbose
703 black-and-white text. Back in twisted-1.3/2.0 days we had to use
704 '-to', but those are completely missing in modern Twisteds.
706 * buildbot/scripts/sample.cfg: make the sample Manhole config use
707 a localhost-only port, to encourage better security
709 * docs/buildbot.texinfo (Change Sources): mention
712 * .darcs-boring: add a Darcs boringfile
714 * README (REQUIREMENTS): stop claiming compatibility with
717 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
720 2006-05-27 Brian Warner <warner@lothar.com>
722 * buildbot/__init__.py: bump to 0.7.3+ while between releases
723 * docs/buildbot.texinfo: same
725 2006-05-23 Brian Warner <warner@lothar.com>
727 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
728 * docs/buildbot.texinfo: set version to match
729 * NEWS: update for 0.7.3
731 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
732 give a quick mapping from VC system to possible ChangeSources
733 (Build Properties): add 'buildername'
735 * buildbot/process/base.py (Build.setupStatus): oops, set
736 'buildername' and 'buildnumber' properties
737 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
740 2006-05-22 Brian Warner <warner@lothar.com>
742 * docs/buildbot.texinfo (Build Properties): explain the syntax of
743 property interpolation better
745 * README (INSTALLATION): remove old '-v' argument from recommended
748 * docs/buildbot.texinfo (ShellCommand): add docs for description=
749 and descriptionDone= arguments. Thanks to Niklaus Giger for the
752 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
753 'svnversion' instead of grepping the output of 'svn info', much
754 simpler and avoids CR/LF problems on windows. Thanks to Olivier
755 Bonnet for the suggestion.
756 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
757 require the WC_PATH argument, so run 'svnversion .' instead.
759 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
760 aren't supposed to have 'self' in their argument list
762 2006-05-21 Brian Warner <warner@lothar.com>
764 * buildbot/process/step.py (ShellCommand.start): make
765 testInterpolate pass. I was passing the uninterpolated command to
766 the RemoteShellCommand constructor
767 (ShellCommand._interpolateProperties): oops, handle non-list
768 commands (i.e. strings with multiple words separated by spaces in
769 them) properly, instead of forgetting about them.
771 * buildbot/test/test_properties.py (Run.testInterpolate): new test
772 to actually try to use build properties in a real build. This test
774 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
775 to start and evaluate builds
777 * buildbot/test/test__versions.py: add a pseudo-test to record
778 what version of Twisted/Python/Buildbot are running. This should
779 show up at the beginning of _trial_tmp/test.log, and exists to help
780 debug other problems.
782 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
783 a filename to be served as 'robots.txt' to discourage web spiders.
784 Adapted from a patch by Tobi Vollebregt, thanks!
785 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
786 (Waterfall.test_waterfall): tweak the way that filenames are put
787 into the config file, to accomodate windows pathnames better.
789 * docs/buildbot.texinfo (HTML Waterfall): document it
791 * buildbot/process/process_twisted.py
792 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
793 changed the build process. The new setup.py no longer takes the
795 (FullTwistedBuildFactory.__init__): same
796 (TwistedReactorsBuildFactory.__init__): same
798 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
799 be placed in the [hooks] section of the central repository (the
800 one that everybody pushes changes to).
802 2006-05-20 Brian Warner <warner@lothar.com>
804 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
805 .darcs-context file, use binary mode. I think this was causing a
806 Darcs failure under windows.
808 2006-05-19 Brian Warner <warner@lothar.com>
810 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
811 use a timezone string of +0000 and gmtime, since this timestamp is
812 sent to a buildmaster and %z is broken.
814 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
815 string and localtime, since this timestamp will only be consumed
816 locally, and %z is broken.
818 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
819 gmtime, since this timestamp is returned to the buildmaster, and
822 2006-05-18 Brian Warner <warner@lothar.com>
824 * NEWS: update in preparation for next release
826 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
827 setup-repository and do-we-have-the-vc-tools code into a separate
828 "helper" class, which sticks around in a single module-level
829 object. This seems more likely to continue to work in the future
830 than having it hide in the TestCase and hope that TestCases stick
831 around for a long time.
833 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
834 addremove' has been deprecated in recent versions of mercurial, so
837 2006-05-07 Brian Warner <warner@lothar.com>
839 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
840 operating under windows, move the file before opening it, since
841 you can't rename a file that somebody has open.
843 * buildbot/process/base.py (Build.setupBuild): if something goes
844 wrong while creating a Step, log the name and arguments, since the
845 error message when you get the number of arguments wrong is really
848 2006-05-06 Brian Warner <warner@lothar.com>
850 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
851 bugs in twisted-specific code not covered by my unit tests, this
852 time use 'cmd' argument instead of self.cmd
854 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
855 fix stupid braino: either use startwith or find()==0, not both.
856 (TwistedReactorsBuildFactory.__init__): another dumb typo
858 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
859 mark this test as TODO under windows, since process-killing seems
860 dodgy there. We'll come back to this later and try to fix it
863 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
864 and don't include a timezone
865 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
866 This should avoid the windows-with-verbose-timezone-name problem
868 (Patch.testPatch): add a test which runs 'patch' with less
869 overhead than the full VCBase.do_patch sequence, to try to isolate
870 a windows test failure. This one uses slave.commands.ShellCommand
871 and 'patch', but none of the VC code.
873 * buildbot/slave/commands.py (getCommand): use which() to find the
874 executables for 'cvs', 'svn', etc. This ought to help under
877 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
878 working directory before starting. If an earlier test failed, the
879 leftover directory would mistakenly flunk a later test.
880 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
881 Make sure that we use the right commandlines if which("tla") picks
882 up "tla.exe" (as it does under windows).
883 (TlaSupport.do_get): factor out this tla-vs-baz difference
884 (TlaSupport.vc_create): more tla-vs-baz differences
886 * buildbot/test/test_slavecommand.py
887 (ShellBase.testShellMissingCommand): stop trying to assert
888 anything about the error message: different shells on different
889 OSes with different languages makes it hard, and it really isn't
890 that interesting of a thing to test anyway.
892 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
893 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
894 "Panther"), because it has a bug which flunks a couple tests in
895 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
896 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
897 able to test that yet.
899 2006-04-30 Brian Warner <warner@lothar.com>
901 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
902 make sure child commands emit messages in english, so our regexps
903 will match. Thanks to Nikaus Giger for identifying the problems.
904 (VCBase._do_vctest_export_1): mode="export" is not responsible
905 for setting the "got_revision" property, since in many cases it is
906 not convenient to determine.
907 (SVNSupport.capable): when running 'svn --version' to check for
908 ra_local, we want error messages in english
909 * buildbot/test/test_slavecommand.py
910 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
911 to emit the error message in english
913 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
914 the environment with $LC_ALL="C" so that Commands which need to
915 parse the output of their child processes can obtain it in
917 (SVN.parseGotRevision): call "svn info" afterwards instead of
918 watching the output of the "svn update" or "svn checkout".
919 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
920 (Arch.parseGotRevision): same
921 (Bazaar.parseGotRevision): same
922 (Mercurial.parseGotRevision): same
924 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
925 $LC_ALL="C" when running commands under 'buildbot try', too
927 * buildbot/test/__init__.py: remove the global os.environ()
928 setting, instead we do it just for the tests that run commands and
929 need to parse their output.
931 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
932 remove the overly-short .timeout on this test, because non-DNotify
933 platforms must fall back to polling which happens at 10 second
934 intervals, so a 5 second timeout would never succeed.
936 2006-04-24 Brian Warner <warner@lothar.com>
938 * docs/buildbot.texinfo (Installing the code): update trial
939 invocation, SF#1469116 by Niklaus Giger.
940 (Attributes of Changes): updated branch-name examples to be
941 a bit more realistic, SF#1475240 by Stephen Davis.
943 * contrib/windows/buildbot2.bat: utility wrapper for windows
944 developers, contributed by Nick Trout (after a year of neglect..
947 * buildbot/test/test_vc.py (*.capable): store the actual VC
948 binary's pathname in VCS[vcname], so it can be retrieved later
949 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
950 strip out non-numeric timezone information, specifically the funky
951 German string that his system produced that confuses CVS.
952 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
953 allow Darcs tests to work on windows
954 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
955 procutils.which() everywhere, to allow tryclient to work under
956 windows. Also from Niklaus Giger, SF#1463394.
958 * buildbot/twcompat.py (which): move the replacement for a missing
959 twisted.python.procutils.which from test_vc.py to here, so it can
960 be used in other places too (specifically tryclient.py)
962 2006-04-23 Brian Warner <warner@lothar.com>
964 * buildbot/status/html.py (StatusResourceBuild.body): replace the
965 bare buildbotURL/projectName line with a proper DIV, along with a
966 CSS class of "title", from Stefan Seefeld (SF#1461675).
967 (WaterfallStatusResource.body0): remove the redundant 'table'
969 (WaterfallStatusResource.body): same. Also add class="LastBuild"
970 to the top-row TR, and class="Activity" to the second-row TR,
971 rather than putting them in the individual TD nodes.
973 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
974 'got_revision' build property for all VC systems that implement
975 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
977 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
978 to determine which revision we actually obtained
979 (CVS.parseGotRevision): implement this for CVS, which just means
980 to grab a timestamp. Not ideal, and it depends upon the buildslave
981 having a clock that is reasonably well syncronized with the server,
982 but it's better than nothing.
983 (SVN.parseGotRevision): implement it for SVN, which is accurate
984 (Darcs.parseGotRevision): same
985 (Arch.parseGotRevision): same
986 (Bazaar.parseGotRevision): same
987 (Mercurial.parseGotRevision): same
989 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
990 keep a record of all non-stdout/stderr/header/rc status updates,
991 for the benefit of RemoteCommands that send other useful things,
993 (Source.commandComplete): put any 'got_revision' status values
994 into a build property of the same name
997 * buildbot/process/step_twisted.py (Trial): update to deal with
998 new ShellCommand refactoring
1000 * docs/buildbot.texinfo (Build Properties): document new feature
1001 that allows BuildSteps to get/set Build-wide properties like which
1002 revision was requested and/or checked out.
1004 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1005 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1006 it. Note that this bumps the persistenceVersion of the saved Build
1007 object, so add the necessary upgrade-old-version logic to include
1008 an empty properties dict.
1010 * buildbot/process/base.py (Build.setProperty): implement it
1011 (Build.getProperty): same
1012 (Build.startBuild): change build startup to set 'branch',
1013 'revision', and 'slavename' properties at the right time
1015 * buildbot/process/step.py (BuildStep.__init__): change setup to
1016 require 'build' argument in a better way
1017 (LoggingBuildStep): split ShellCommand into two pieces, for better
1018 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1019 a single RemoteCommand that sends stdout/stderr status text. It
1020 also provides the usual commandComplete / createSummary /
1021 evaluateCommand / getText methods to be overridden...
1022 (ShellCommand): .. whereas ShellCommand is specifically for
1023 running RemoteShellCommands. Other shell-like BuildSteps (like
1024 Source) can inherit from LoggingBuildStep instead of ShellCommand
1025 (WithProperties): marker class to do build-property interpolation
1026 (Source): inherit from LoggingBuildStep instead of ShellCommand
1029 * buildbot/test/test_properties.py: test new functionality
1031 2006-04-21 Brian Warner <warner@lothar.com>
1033 * buildbot/test/test_vc.py: rename testBranch to
1034 testCheckoutBranch to keep the tests in about the right
1037 2006-04-18 Brian Warner <warner@lothar.com>
1039 * docs/buildbot.texinfo (PBListener): improve cross-references
1040 between PBListener and 'buildbot statusgui', thanks to John Pye
1043 2006-04-17 Brian Warner <warner@lothar.com>
1045 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1046 running under Twisted-1.3.0, otherwise skipped tests are reported
1049 * all: use isinstance() instead of 'type(x) is foo', suggested by
1052 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1053 oops, fix a brain-fade from the other week, when making the
1054 addStep changes. I changed all the __init__ upcalls to use the
1055 wrong superclass name.
1056 (FullTwistedBuildFactory.__init__): same
1057 (TwistedDebsBuildFactory.__init__): same
1058 (TwistedReactorsBuildFactory.__init__): same
1059 (TwistedBuild.isFileImportant): use .startswith for clarity,
1060 thanks to Neal Norwitz for the suggestions.
1062 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1063 changes, then deliver them over PB to a remote buildmaster.
1065 * contrib/svnpoller.py: added script by John Pye to poll a remote
1066 SVN repository (by running 'svn log') from a cronjob, and run
1067 'buildbot sendchange' to deliver the changes to a remote
1069 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1070 modification of svnpoller.py), same purpose, but this one loops
1071 internally (rather than expecting to run from a cronjob) and works
1073 * contrib/README.txt: same
1075 2006-04-11 Brian Warner <warner@lothar.com>
1077 * all: fix a number of incorrect names and missing imports, thanks
1078 to Anthony Baxter for the patch.
1079 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1080 remove unused buggy method.
1081 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1082 comes from shutil, not "shutils"
1083 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1084 (Arch.checkSlaveVersion): same
1085 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1087 * buildbot/process/step_twisted2.py: add some missing imports
1088 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1089 this code used to live in twisted.internet.defer
1091 2006-04-10 Brian Warner <warner@lothar.com>
1093 * buildbot/process/step.py (Mercurial): add Mercurial support
1094 * buildbot/slave/commands.py (Mercurial): same
1095 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1096 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1097 not yet tested, but 'try' support *is* covered
1098 * docs/buildbot.texinfo (Mercurial): document it
1100 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1101 some debugging messages (turned off)
1102 * buildbot/test/test_vc.py: improve debug messages
1104 2006-04-07 Brian Warner <warner@lothar.com>
1106 * buildbot/test/test_vc.py (which): define our own which() in case
1107 we can't import twisted.python.procutils, because procutils doesn't
1108 exist in Twisted-1.3
1110 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1111 of SlaveLocks for performance tests
1113 * docs/examples/twisted_master.cfg: update to match current usage
1115 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1116 password, p4 binary, pollinterval, maximum history to check.
1117 Patch from an anonymous sf.net contributor, SF#1219384.
1118 * buildbot/process/step.py (P4Sync.__init__): add username,
1119 password, and client arguments.
1120 * buildbot/slave/commands.py (P4Sync): same
1122 2006-04-05 Brian Warner <warner@lothar.com>
1124 * buildbot/process/factory.py (BuildFactory.addStep): new method
1125 to add steps to a BuildFactory. Use it instead of f.steps.append,
1126 and you can probably avoid using the s() convenience function.
1127 Patch from Neal Norwitz, sf.net #1412605.
1128 (other): update all factories to use addStep
1129 * buildbot/process/process_twisted.py: update all factories to use
1132 2006-04-03 Brian Warner <warner@lothar.com>
1134 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1135 work under windows too. Adapted from a patch by Niklaus Giger,
1136 addresses SF#1463399.
1138 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1139 spawned commands emit parseable results in english and not some
1140 other language. Patch from Niklaus Giger, SF#1463395.
1142 * README (INSTALLATION): discourage users from running unit tests on
1143 a "network drive", patch from Niklaus Giger, SF#1463394.
1145 2006-03-22 Brian Warner <warner@lothar.com>
1147 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1148 function to turn a repository-relative pathname into a (branch,
1149 branch-relative-filename) tuple. Change this function to handle
1150 the branch naming policy used by your Subversion repository.
1151 Thanks to AllMyData.com for sponsoring this work.
1153 2006-03-16 Brian Warner <warner@lothar.com>
1155 * buildbot/scripts/sample.cfg: add python-mode declaration for
1156 vim. Thanks to John Pye for the patch.
1158 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1159 command line, mention the importance of running 'crontab' as the
1160 buildmaster/buildslave user. Thanks to John Pye for the catch.
1162 2006-03-13 Brian Warner <warner@lothar.com>
1164 * buildbot/status/words.py (IRC): add an optional password=
1165 argument, which will be sent to Nickserv in an IDENTIFY message at
1166 login, to claim the nickname. freenode requires this before the
1167 bot can sent (or reply to) private messages. Thanks to Clement
1168 Stenac for the patch.
1169 * docs/buildbot.texinfo (IRC Bot): document it
1171 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1172 larger than chunkSize. Fixes SF#1349253.
1173 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1174 (Log.testConsumer): update to match new internal chunking behavior
1176 2006-03-12 Brian Warner <warner@lothar.com>
1178 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1180 * buildbot/test/test_maildir.py (MaildirTest): rename the
1181 'timeout' method, as it collides with trial's internals
1183 * buildbot/scripts/runner.py: add 'buildbot restart' command
1184 (stop): don't sys.exit() out of here, otherwise restart can't work
1185 * docs/buildbot.texinfo (Shutdown): document it
1187 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1188 * buildbot/status/html.py (Waterfall.__init__): same
1189 * buildbot/process/builder.py (Builder.startBuild): same
1190 * buildbot/process/base.py (BuildRequest): same
1191 * buildbot/sourcestamp.py (SourceStamp): same
1192 * buildbot/scheduler.py (Nightly): same
1194 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1196 * docs/buildbot.texinfo: same
1198 2006-02-17 Brian Warner <warner@lothar.com>
1200 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1201 * docs/buildbot.texinfo: set version number to match
1202 * NEWS: update for 0.7.2
1204 2006-02-16 Brian Warner <warner@lothar.com>
1206 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1208 2006-02-09 Brian Warner <warner@lothar.com>
1210 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1211 add text to explain per-build branch parameters
1212 * NEWS: mention --umask
1214 2006-02-08 Brian Warner <warner@lothar.com>
1216 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1218 (SlaveOptions.optParameters): add --umask, to make it possible to
1219 make buildslave-generated files (including build products) be
1222 * buildbot/slave/bot.py (BuildSlave.startService): same
1224 2006-01-23 Brian Warner <warner@lothar.com>
1226 * buildbot/status/builder.py: urllib.quote() all URLs that include
1227 Builder names, so that builders can include characters like '/'
1228 and ' ' without completely breaking the resulting HTML. Thanks to
1229 Kevin Turner for the patch.
1230 * buildbot/status/html.py: same
1231 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1233 * NEWS: update in preparation for upcoming release
1235 2006-01-18 Brian Warner <warner@lothar.com>
1237 * docs/examples/twisted_master.cfg: update to match the Twisted
1238 buildbot: remove python2.2, switch to exarkun's buildslaves,
1239 disable the .deb builder until we figure out how to build twisted
1240 .debs from SVN, add some ktrace debugging to the OS-X build
1241 process and remove the qt build, remove threadless builders,
1242 change freebsd builder to use landonf's buildslave.
1244 2006-01-12 Brian Warner <warner@lothar.com>
1246 * buildbot/master.py (Manhole.__init__): let port= be a strports
1247 specification string, but handle a regular int for backwards
1248 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1249 used in master.cfg to limit connections to just the local host.
1250 (BuildMaster.loadConfig): same for c['slavePortnum']
1251 * buildbot/scheduler.py (Try_Userpass.__init__): same
1252 * buildbot/status/client.py (PBListener.__init__): same
1253 * buildbot/status/html.py (Waterfall.__init__): same, for both
1254 http_port and distrib_port. Include backwards-compatibility checks
1255 so distrib_port can be a filename string and still mean unix:/foo
1256 * docs/buildbot.texinfo (Setting the slaveport): document it
1257 (Debug options): same
1258 (HTML Waterfall): same
1261 * buildbot/test/test_config.py (ConfigTest): test it
1263 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1264 slaveport's disownServiceParent deferred to fire before opening
1265 the new one. Fixes an annoying bug in the unit tests.
1267 2006-01-03 Brian Warner <warner@lothar.com>
1269 * buildbot/master.py (BuildMaster): remove the .schedulers
1270 attribute, replacing it with an allSchedulers() method that looks
1271 for all IService children that implement IScheduler. Having only
1272 one parent/child relationship means fewer opportunities for bugs.
1273 (BuildMaster.allSchedulers): new method
1274 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1275 also fix ugly bug that caused any config-file reload to
1276 half-forget about the earlier Schedulers, causing an exception
1277 when a Change arrived and was handed to a half-connected
1278 Scheduler. The exception was in scheduler.py line 54ish:
1279 self.parent.submitBuildSet(bs)
1280 exceptions.AttributeError: 'NoneType' object has no attribute
1282 (BuildMaster.addChange): update to use allSchedulers()
1284 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1285 to work properly with twisted-1.3.0, where you must explicitly
1286 include the __implements__ from parent classes
1287 (BaseScheduler.__repr__): make it easier to distinguish distinct
1289 (BaseUpstreamScheduler.__implements__): same
1291 * buildbot/status/builder.py (Status.getSchedulers): update to
1293 * buildbot/test/test_run.py (Run.testMaster): same
1294 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1295 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1296 make sure Scheduler instances are left alone when an identical
1297 config file is reloaded
1298 (ConfigElements.testSchedulers): make sure Schedulers are properly
1301 * Makefile (TRIALARGS): my local default Twisted version is now
1302 2.1.0, update the trial arguments accordingly
1304 2005-12-22 Brian Warner <warner@lothar.com>
1306 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1309 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1310 addChange in the parent class, although I suspect this should be
1311 fixed better in the future.
1313 2005-11-26 Brian Warner <warner@lothar.com>
1315 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1316 explode when branch==None, thanks to Kevin Turner for the catch
1317 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1320 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1322 * docs/buildbot.texinfo: same
1324 2005-11-26 Brian Warner <warner@lothar.com>
1326 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1327 * docs/buildbot.texinfo: set version number to match
1329 2005-11-26 Brian Warner <warner@lothar.com>
1331 * NEWS: update for 0.7.1
1333 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1334 sure that unsubscribe works even if we never sent an ETA update.
1335 Also, don't explode on duplicate unsubscribe.
1336 (BuildStepStatus.addLog): make the convenience "return self"-added
1337 watcher automatically unsubscribe when the Step finishes.
1338 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1339 (BuildStatus.stepStarted): same auto-unsubscribe
1340 (BuilderStatus.buildStarted): same auto-unsubscribe
1342 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1344 (IStatusReceiver.stepStarted): same
1345 (IStatusReceiver.logStarted): same
1347 * buildbot/test/test_run.py (Status): move the Status test..
1348 * buildbot/test/test_status.py (Subscription): .. to here
1350 2005-11-25 Brian Warner <warner@lothar.com>
1352 * NEWS: more updates
1354 * buildbot/locks.py: fix the problem in which loading a master.cfg
1355 file that changes some Builders (but not all of them) can result
1356 in having multiple copies of the same Lock. Now, the real Locks
1357 are kept in a table inside the BotMaster, and the Builders/Steps
1358 use "LockIDs", which are still instances of MasterLock and
1359 SlaveLock. The real Locks are instances of the new RealMasterLock
1360 and RealSlaveLock classes.
1361 * buildbot/master.py (BotMaster.getLockByID): new method to
1362 convert LockIDs into real Locks.
1363 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1364 into real Locks before building
1365 * buildbot/process/step.py (BuildStep.startStep): same
1366 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1367 exercises the problem
1370 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1371 what Schedulers are available
1373 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1374 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1375 'cron'-style build scheduling at certain times of day, week,
1377 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1379 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1380 handling: treat self.fileIsImportant more as an attribute that
1381 contains a callable than as a method. If the attribute is None,
1382 don't call it and assume all filenames are important. It is still
1383 possible to provide a fileIsImportant method in a subclass,
1385 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1387 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1388 test using AnyBranchScheduler with fileIsImportant=None
1390 2005-11-24 Brian Warner <warner@lothar.com>
1392 * buildbot/test/test_config.py (StartService): don't claim a fixed
1393 port number, instead set slavePort=0 on the first pass, figure out
1394 what port was allocated, then switch to a config file that uses
1397 * buildbot/master.py (BuildMaster.loadConfig): close the old
1398 slaveport before opening the new one, because unit tests might
1399 replace slavePort=0 with the same allocated portnumber, and if we
1400 don't wait for the old port to close first, we get a "port already
1401 in use" error. There is a tiny race condition here, but the only
1402 threat is from other programs that bind (statically) to the same
1403 port number we happened to be allocated, and only if those
1404 programs use SO_REUSEADDR, and only if they get control in between
1407 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1409 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1410 deleted ChangeSources before adding any new ones
1411 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1412 compare_attrs, to make sure that a config-file reload does not
1413 unnecessarily replace an unmodified ChangeSource instance
1414 * buildbot/test/test_config.py (ConfigTest.testSources): update
1416 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1417 mean "don't build anything", and add a warning if it gets used
1418 because it isn't actually useful.
1420 * contrib/svn_buildbot.py: update example usage to match the port
1421 number that gets used by the PBChangeSource
1422 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1424 2005-11-22 Brian Warner <warner@lothar.com>
1426 * NEWS: start collecting items for next release
1428 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1429 revisions are strings
1430 (P4Sync.computeSourceRevision): same
1432 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1433 to the Buildbot's overall status page
1434 (StatusResourceBuilder.body): same
1436 2005-11-15 Brian Warner <warner@lothar.com>
1438 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1439 config-file loading, specifically to make sure old StatusTargets
1440 are finished shutting down before new ones start up (thus
1441 resolving a bug in which changing the Waterfall object would fail
1442 because both new and old instances were claiming the same
1443 listening port). Also load new Schedulers after all the new
1444 Builders are set up, in case they fire off a new build right away.
1445 * buildbot/test/test_config.py (StartService): test it
1447 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1448 the branch name to the mail body
1450 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1451 Without it, a config-file reload fails to update an existing
1453 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1454 username/passwd to compare_attrs, for the same reason
1455 * buildbot/status/html.py (Waterfall): add favicon to
1456 compare_attrs, same reason
1458 2005-11-05 Brian Warner <warner@lothar.com>
1460 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1461 baserev before stuffing it in the jobfile. This resolves problems
1462 under SVN (and probably Arch) where revisions are expressed as
1463 numbers. I'm inclined to use string-based revisions everywhere in
1464 the future, but this fix should be safe for now. Thanks to Steven
1465 Walter for the patch.
1467 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1468 binary mode when opening pickle files, to make windows work
1469 better. Thanks to Dobes Vandermeer for the catch.
1470 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1471 (BuilderStatus.getBuildByNumber): same
1472 (Status.builderAdded): same
1473 * buildbot/master.py (BuildMaster.loadChanges): same
1475 * buildbot/util.py (Swappable): delete unused leftover code
1477 * buildbot/process/step.py (SVN): when building on a non-default
1478 branch, add the word "[branch]" to the VC step's description, so
1479 it is obvious that we're not building the usual stuff. Likewise,
1480 when we are building a specific revision, add the text "rNNN" to
1481 indicate what that revision number is. Thanks to Brad Hards and
1482 Nathaniel Smith for the suggestion.
1483 (Darcs.startVC): same
1484 (Arch.startVC): same
1485 (Bazaar.startVC): same
1487 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1488 typo, caught by Mark Dillavou, closes SF#1216636.
1490 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1491 about a test to add some day
1493 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1494 the 'full-2.3' build, and the 'reactors' build is now run under
1495 python-2.4 because the buildslave no longer has gtk/etc bindings
1496 for earlier versions.
1498 2005-11-03 Brian Warner <warner@lothar.com>
1500 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1501 method, takes an IBuildStatus and rebuilds it. It might make more
1502 sense to add this to IBuildControl instead, but that instance goes
1503 away completely once the build has finished, and resubmitting
1504 builds can take place weeks later.
1505 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1506 * buildbot/status/html.py (StatusResourceBuild): also stash an
1507 IBuilderControl so we can use resubmitBuild.
1508 (StatusResourceBuild.body): render "resubmit" button if we can.
1509 Also add hrefs for each BuildStep
1510 (StatusResourceBuild.rebuild): add action for "resubmit" button
1511 (StatusResourceBuilder.getChild): give it an IBuilderControl
1513 * buildbot/status/builder.py (Status.getURLForThing): change the
1514 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1515 that live as targets of buttons like "stop" and "rebuild" can't
1517 * buildbot/status/builder.py (Status.getURLForThing): same
1518 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1519 (StepBox.getBox): same
1520 * buildbot/test/test_web.py (GetURL): same
1523 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1524 exclusivity checks after Source.__init__ upcall, so misspelled
1525 arguments will be reported more usefully
1526 (Darcs.__init__): same
1528 2005-10-29 Brian Warner <warner@lothar.com>
1530 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1531 builder. Move the Try scheduler off to a separate port.
1533 2005-10-27 Brian Warner <warner@lothar.com>
1535 * buildbot/clients/gtkPanes.py
1536 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1537 to cause the app to crash, now they don't.
1539 * buildbot/clients/debug.py: display the buildmaster's location
1540 in the window's title bar
1542 2005-10-26 Brian Warner <warner@lothar.com>
1544 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
1545 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
1546 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
1548 * buildbot/status/html.py (td): put a single non-breaking space
1549 inside otherwise empty <td> elements, as a workaround for buggy
1550 browsers which would optimize them away (along with any associated
1551 styles, like the kind that create the waterfall grid borders).
1552 Patch from Frerich Raabe.
1554 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
1555 argv-list as an argument, defaulting to ["-to"], which is
1556 appropriate for the Trial that comes with Twisted-2.1.0 and
1557 earlier. The Trial in current Twisted SVN wants
1558 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
1559 defaults to an empty list.
1560 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
1561 match it, now that trialMode= is a list instead of a single string
1563 * buildbot/__init__.py (version): bump to 0.7.0+ while between
1565 * docs/buildbot.texinfo: same
1567 2005-10-24 Brian Warner <warner@lothar.com>
1569 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
1570 * docs/buildbot.texinfo: set version number to match
1572 2005-10-24 Brian Warner <warner@lothar.com>
1574 * README: update for 0.7.0
1576 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
1578 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
1579 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
1580 send the branch= argument unless the user really provided one, to
1581 retain compatibility with older buildmasters that don't accept
1583 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
1586 * docs/buildbot.texinfo: update lots of stuff
1588 * buildbot/scripts/runner.py (sendchange): add a --branch argument
1589 to the 'buildbot sendchange' command
1590 * buildbot/clients/sendchange.py (Sender.send): same
1591 * buildbot/changes/pb.py (ChangePerspective): same
1592 * buildbot/test/test_changes.py (Sender.testSender): test it
1594 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
1595 'default_branch' argument names to 'baseURL' and 'defaultBranch',
1596 for consistency with other BuildStep arguments that use camelCase.
1597 Well, at least more of them use camelCase (like flunkOnWarnings)
1598 than don't.. I wish I'd picked one style and stuck with it
1599 earlier. Annoying, but it's best done before the release, since
1600 these arguments didn't exist at all in 0.6.6 .
1602 * buildbot/test/test_vc.py (SVN.testCheckout): same
1603 (Darcs.testPatch): same
1604 * docs/buildbot.texinfo (SVN): document the change
1605 (Darcs): same, add some build-on-branch docs
1606 * docs/examples/twisted_master.cfg: match change
1608 * buildbot/process/step.py (BuildStep): rename
1609 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
1610 how it is normally used.
1611 * buildbot/test/test_steps.py (Version.checkCompare): same
1613 * buildbot/process/step.py (CVS.startVC): refuse to build
1614 update/copy -style builds on a non-default branch with an old
1615 buildslave (<=0.6.6) that doesn't know how to do it properly. The
1616 concern is that it will do a VC 'update' in an existing tree when
1617 it is supposed to be switching branches (and therefore clobbering
1618 the tree to do a full checkout), thus building the wrong source.
1619 This used to be a warning, but I think the confusion it is likely
1620 to cause warrants making it an error.
1621 (SVN.startVC): same, also make mode=export on old slaves an error
1622 (Darcs.startVC): same
1623 (Git.startVC): improve error message for non-Git-enabled slaves
1624 (Arch.checkSlaveVersion): same. continue to emit a warning when a
1625 specific revision is built on a slave that doesn't pay attention
1626 to args['revision'], because for slowly-changing trees it will
1627 probably do the right thing, and because we have no way to tell
1628 whether we're asking it to build the most recent version or not.
1629 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
1631 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
1632 that 'master' is in host:portnum format, to catch errors sooner
1634 2005-10-23 Brian Warner <warner@lothar.com>
1636 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
1637 when creating the list of warning messages, include the line
1638 immediately after each WARNING: line, since that's usually where
1639 the file and line number wind up.
1641 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
1646 2005-10-22 Brian Warner <warner@lothar.com>
1648 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
1649 patch from Brad Hards
1650 * buildbot/status/classic.css: same
1651 * buildbot/test/test_web.py (Waterfall): match changes
1653 * buildbot/test/test_steps.py (BuildStep.setUp): set
1654 nextBuildNumber so the test passes
1655 * buildbot/test/test_status.py (MyBuilder): same
1657 * buildbot/status/html.py (StatusResourceBuild.body): revision
1658 might be numeric, so stringify it before html-escapifying it
1659 (CurrentBox.getBox): add a "waiting" state, and show a countdown
1660 timer for the upcoming build
1661 * buildbot/status/classic.css: add background-color attributes for
1662 offline/waiting/building classes
1664 * buildbot/status/builder.py (BuildStatus): derive from
1665 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
1666 the default (i.e. unknown) .slavename to "???" instead of None,
1667 since even unknown slavenames need to be printed eventually.
1668 (BuilderStatus): also derive from styles.Versioned . More
1669 importantly, determine .nextBuildNumber at creation/unpickling
1670 time by scanning the directory of saved BuildStatus instances and
1671 choosing one larger than the highest-numbered one found. This
1672 should fix the problem where random errors during upgrades cause
1673 the buildbot to forget about earlier builds. .nextBuildNumber is
1674 no longer stored in the pickle.
1675 (Status.builderAdded): if we can't unpickle the BuilderStatus,
1676 at least log the error. Also call Builder.determineNextBuildNumber
1677 once the basedir is set.
1679 * buildbot/master.py (BuildMaster.loadChanges): do
1680 styles.doUpgrade afterwards, in case I decide to make Changes
1681 derived from styles.Versioned some day and forget to make this
1685 * buildbot/test/test_runner.py (Options.testForceOptions): skip
1686 when running under older pythons (<2.3) in which the shlex module
1687 doesn't have a 'split' function.
1689 * buildbot/process/step.py (ShellCommand.start): make
1690 errorMessages= be a list of strings to stuff in the log before the
1691 command actually starts. This makes it easier to flag multiple
1692 warning messages, e.g. when the Source steps have to deal with an
1694 (CVS.startVC): handle slaves that don't handle multiple branches
1695 by switching into 'clobber' mode
1696 (SVN.startVC): same. Also reject branches without base_url
1697 (Darcs.startVC): same. Also reject revision= in older slaves
1698 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
1699 (Bazaar.startVC): same, and test for baz separately than for arch
1701 * buildbot/slave/commands.py (cvs_ver): document new features
1703 * buildbot/process/step.py (BuildStep.slaveVersion): document it
1704 (BuildStep.slaveVersionNewEnough): more useful utility method
1705 * buildbot/test/test_steps.py (Version): start testing it
1707 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
1708 the 'force' command requires python2.3, for the shlex.split method
1710 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
1711 since we don't use it anymore. The Twisted buildbot uses a
1714 2005-10-21 Brian Warner <warner@lothar.com>
1716 * buildbot/process/process_twisted.py: rework all BuildFactory
1717 classes to take a 'source' step as an argument, instead of
1718 building up the SVN instance in the factory.
1719 * docs/examples/twisted_master.cfg: enable build-on-branch by
1720 providing a base_url and default_branch
1722 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
1723 control over --branch and --revision, not that they are always
1725 * buildbot/status/html.py (StatusResourceBuilder.force): same
1726 (StatusResourceBuild.body): display SourceStamp components
1728 * buildbot/scripts/runner.py (ForceOptions): option parser for the
1729 IRC 'force' command, so it can be shared with an eventual
1730 command-line-tool 'buildbot force' mode.
1731 * buildbot/test/test_runner.py (Options.testForceOptions): test it
1733 2005-10-20 Brian Warner <warner@lothar.com>
1735 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
1737 * docs/examples/twisted_master.cfg: update to use Schedulers
1739 * buildbot/scripts/sample.cfg: update with Schedulers
1741 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
1742 method specifically for use by HTML "force build" button and the
1743 IRC "force" command. Raises an immediate error if there are no
1745 (IBuilderControl.requestBuild): make this just submit a build, not
1746 try to check for existing slaves or set up any when-finished
1747 Deferreds or anything.
1748 * buildbot/process/builder.py (BuilderControl): same
1749 * buildbot/status/html.py (StatusResourceBuilder.force): same
1750 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
1751 * buildbot/test/test_slaves.py: same
1752 * buildbot/test/test_web.py: same
1754 2005-10-19 Brian Warner <warner@lothar.com>
1756 * docs/examples/twisted_master.cfg: re-sync with reality: bring
1757 back python2.2 tests, turn off OS-X threadedselect-reactor tests
1759 2005-10-18 Brian Warner <warner@lothar.com>
1761 * buildbot/status/html.py: provide 'status' argument to most
1762 StatusResourceFOO objects
1763 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
1764 and Logfiles" section to make the Build page into a more-or-less
1765 comprehensive source of status information about the build
1767 * buildbot/status/mail.py (MailNotifier): include the Build's URL
1768 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
1770 2005-10-17 Brian Warner <warner@lothar.com>
1772 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
1773 arguments to accomodate Twisted >=2.1.0 . I will have to figure
1774 out what to do about other projects: the correct options for
1775 recent Twisteds will not work for older ones.
1777 2005-10-15 Brian Warner <warner@lothar.com>
1779 * buildbot/status/builder.py (Status.getURLForThing): add method
1780 to provide a URL for arbitrary IStatusFoo objects. The idea is to
1781 use this in email/IRC status clients to make them more useful, by
1782 providing the end user with hints on where to learn more about the
1783 object being reported on.
1784 * buildbot/test/test_web.py (GetURL): tests for it
1786 2005-10-14 Brian Warner <warner@lothar.com>
1788 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
1789 fix bug resulting from deferredResult changes
1791 2005-10-13 Brian Warner <warner@lothar.com>
1793 * buildbot/test/test_changes.py: remove use of deferredResult
1794 * buildbot/test/test_config.py: same
1795 * buildbot/test/test_control.py: same
1796 * buildbot/test/test_status.py: same
1797 * buildbot/test/test_vc.py: this is the only remaining use, since
1798 it gets used at module level. This needs to be replaced by some
1799 sort of class-level run-once routine.
1801 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
1803 * lots: implement multiple slaves per Builder, which means multiple
1804 current builds per Builder. Some highlights:
1805 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
1806 of (state,currentBuilds) instead of (state,currentBuild)
1807 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
1808 (IBuildStatus.getSlavename): new method, so you can tell which
1809 slave got used. This only gets set when the build completes.
1810 (IBuildRequestStatus.getBuilds): new method
1812 * buildbot/process/builder.py (SlaveBuilder): add a .state
1813 attribute to track things like ATTACHING and IDLE and BUILDING,
1815 (Builder): .. the .slaves attribute here, which has been turned
1816 into a simple list of available slaves. Added a separate
1817 attaching_slaves list to track ones that are not yet ready for
1819 (Builder.fireTestEvent): put off the test-event callback for a
1820 reactor turn, to make tests a bit more consistent.
1821 (Ping): cleaned up the slaveping a bit, now it disconnects if the
1822 ping fails due to an exception. This needs work, I'm worried that
1823 a code error could lead to a constantly re-connecting slave.
1824 Especially since I'm trying to move to a distinct remote_ping
1825 method, separate from the remote_print that we currently use.
1826 (BuilderControl.requestBuild): return a convenience Deferred that
1827 provides an IBuildStatus when the build finishes.
1828 (BuilderControl.ping): ping all connected slaves, only return True
1829 if they all respond.
1831 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
1832 reconnect when we shut down.
1834 * buildbot/status/builder.py: implement new methods, convert
1835 one-build-at-a-time methods to handle multiple builds
1836 * buildbot/status/*.py: do the same in all default status targets
1837 * buildbot/status/html.py: report the build's slavename in the
1838 per-Build page, report all buildslaves on the per-Builder page
1840 * buildbot/test/test_run.py: update/create tests
1841 * buildbot/test/test_slaves.py: same
1842 * buildbot/test/test_scheduler.py: remove stale test
1844 * docs/buildbot.texinfo: document the new builder-specification
1845 'slavenames' parameter
1847 2005-10-12 Brian Warner <warner@lothar.com>
1849 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
1850 report failure correctly, causing Dependent builds to run when
1851 they shouldn't have.
1852 * buildbot/status/builder.py (BuildSetStatus): same
1853 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
1854 (Set.testSuccess): test the both-pass case too
1855 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
1856 fix this test: it was ending too early, masking the failure before
1857 (Logger): specialized StatusReceiver to make sure the dependent
1858 builds aren't even started, much less completed.
1860 2005-10-07 Brian Warner <warner@lothar.com>
1862 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
1863 bot.SlaveBuilder being disowned in the middle of a build
1865 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
1866 this inherit from StatusReceiver. Also upcall in __init__. This
1867 fixes the embarrasing crash when the new buildSetSubmitted method
1868 is invoked and Waterfall/etc don't implement their own.
1869 * buildbot/test/test_run.py: add a TODO note about a test to catch
1870 just this sort of thing.
1872 * buildbot/process/builder.py (Builder.attached): remove the
1873 already-attached warning, this situation is normal. Add some
1874 comments explaining it.
1876 2005-10-02 Brian Warner <warner@lothar.com>
1878 * buildbot/changes/maildir.py (Maildir.start): Tolerate
1879 OverflowError when setting up dnotify, because some 64-bit systems
1880 have problems with signed-vs-unsigned constants and trip up on the
1881 DN_MULTISHOT flag. Patch from Brad Hards.
1883 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
1885 * buildbot/process/step.py (BuildStep, ShellCommand): Add
1886 progressMetrics, description, descriptionDone to the 'parms' list,
1887 and make use the 'parms' list from the implementation class
1888 instead of only BuildStep to initialize the parameters. This
1889 allows buildbot.process.factory.s() to initialize all the parms,
1890 not just those defined in directly by BuildStep.
1892 2005-09-03 Brian Warner <warner@lothar.com>
1894 * NEWS: start adding items for the next release
1896 * docs/examples/twisted_master.cfg: (sync with reality) turn off
1897 python2.2 tests, change 'Quick' builder to only use python2.3
1899 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
1901 * buildbot/status/html.py (StatusResourceBuilder.body): only show
1902 the "Ping Builder" button if the build control is available; the
1903 user sees an exception otherwise
1905 * docs/buildbot.texinfo (PBChangeSource): fix a typo
1907 2005-09-01 Brian Warner <warner@lothar.com>
1909 * buildbot/interfaces.py (IBuilderStatus.getState): update
1910 signature, point out that 'build' can be None
1911 (IBuildStatus.getETA): point out ETA can be none
1913 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
1915 * buildbot/status/words.py (IrcStatusBot.emit_status): same
1917 2005-08-31 Brian Warner <warner@lothar.com>
1919 * buildbot/status/base.py (StatusReceiver.builderChangedState):
1920 update to match correct signature: removed 'eta' argument
1921 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
1923 2005-08-30 Brian Warner <warner@lothar.com>
1925 * buildbot/status/builder.py (LogFile): remove the assertion that
1926 blows up when you try to overwrite an existing logfile, instead
1927 just emit a warning. This case gets hit when the buildmaster is
1928 killed and doesn't get a chance to write out the serialized
1929 BuilderStatus object, so the .nextBuildNumber attribute gets out
1932 * buildbot/scripts/runner.py (sendchange): add --revision_file to
1933 the 'buildbot sendchange' arguments, for the Darcs context file
1934 * docs/buildbot.texinfo (sendchange): document it
1936 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
1937 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
1938 (IStatus.getSchedulers): new method
1939 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
1940 (Status.getSchedulers): implement
1941 * buildbot/process/builder.py (Builder): maintain
1942 BuilderStatus.pendingBuilds
1943 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
1944 (TryBase.addChange): Try schedulers should ignore Changes
1946 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
1947 for 'try' on CVS/SVN
1948 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
1950 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
1951 report status properly.
1952 (Try.createJob): implement unique buildset IDs
1954 * buildbot/status/client.py (StatusClientPerspective): add a
1955 perspective_getBuildSets method for the benefit of jobdir-style
1957 * docs/buildbot.texinfo (try): more docs
1958 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
1961 2005-08-18 Brian Warner <warner@lothar.com>
1963 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
1964 actually work. It's functional but still kind of clunky. Also, it
1965 only works with the pb-style.. needs to be made to work with the
1968 * buildbot/status/client.py (RemoteBuildSet): new class
1969 (RemoteBuildRequest): same
1970 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
1971 object, not the internal BuildStatus object.
1972 (RemoteBuild.remote_subscribe): new method to subscribe to builds
1973 outside of the usual buildStarted() return value.
1974 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
1976 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
1977 (Try_Userpass_Perspective.perspective_try): return a remotely
1978 usable BuildSetStatus object
1980 * buildbot/interfaces.py (IBuildStatus): remove obsolete
1981 isStarted()/waitUntilStarted()
1983 2005-08-16 Brian Warner <warner@lothar.com>
1985 * buildbot/status/builder.py: implement IBuildSetStatus and
1986 IBuildRequestStatus, wire them into place.
1987 * buildbot/buildset.py: same. Add ID, move wait-until-finished
1988 methods into the BuildSetStatus object.
1989 * buildbot/interfaces.py: same
1990 (IStatus.getBuildSets): new method to get pending BuildSets
1991 (IStatusReceiver.buildsetSubmitted): new method which hears about
1993 * buildbot/master.py (BuildMaster.submitBuildSet): same
1994 * buildbot/process/base.py (BuildRequest): same, replace
1995 waitUntilStarted with subscribe/unsubscribe
1996 * buildbot/process/builder.py (BuilderControl.forceBuild): use
1997 subscribe instead of waitUntilStarted
1998 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2000 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2002 * buildbot/test/test_buildreq.py: update for new code
2003 * buildbot/test/test_control.py (Force.testRequest): same
2006 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2007 for Darcs to not use the tempfile module, so it works under
2008 python-2.2 too. We really didn't need the full cleverness of that
2009 module, since the slave has exclusive control of its own builddir.
2011 2005-08-15 Brian Warner <warner@lothar.com>
2013 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2014 for CVS trees. It doesn't work for non-trunk branches,
2016 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2019 * Makefile: make it easier to test against python2.2
2021 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2022 tearDown2, so things like Arch can unregister archives as they're
2023 shutting down. The previous subclass-override-tearDown technique
2024 resulted in a nested maybeWait() and test failures under
2027 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2028 where we can (Arch), add a branch= argument to set the branch used
2030 (BazExtractor): extract the branch too
2031 (TlaExtractor): same
2032 * buildbot/scripts/runner.py (TryOptions): add --branch
2033 * docs/buildbot.texinfo (try): document --branch/try_branch
2035 * buildbot/slave/commands.py (Darcs): implement get-revision for
2036 Darcs, so that 'try' will work. This requires the tempfile module
2039 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2040 of revisions, branches, and 'try' in the process.
2042 2005-08-11 Brian Warner <warner@lothar.com>
2044 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2045 this, it got broken at some point in the last few releases
2046 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2047 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2048 specifically the removal of ETA information from the tuple
2050 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2053 * docs/buildbot.texinfo (try): document both --builder and
2054 'try_builders' in .buildbot/options
2055 * buildbot/scripts/runner.py (TryOptions): add --builder,
2056 accumulate the values into opts['builders']
2057 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2058 * buildbot/test/test_runner.py (Try): add some quick tests to make
2059 sure 'buildbot try --options' and .buildbot/options get parsed
2060 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2061 use --builder control
2063 * docs/buildbot.texinfo (try): add --port argument to PB style
2065 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2066 actual SourceStamp. Still need to extract a branch name, somehow.
2067 (Try): finish implementing the try client side, still need a UI
2068 for specifying which builders to use
2069 (Try.getopt): factor our options/config-file reading
2070 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2072 * buildbot/test/test_vc.py: match SourceStampExtractor change
2074 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2075 causes the twisted log to be sent to stderr
2077 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2079 2005-08-10 Brian Warner <warner@lothar.com>
2081 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2082 style is 90% done, still missing status reporting or waiting for
2083 the buildsets to finish, and it is completely untested.
2085 * buildbot/trybuild.py: delete file, move contents to ..
2086 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2087 * buildbot/test/test_vc.py: match the move
2089 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2090 of the TryScheduler, no buildsetID or status-tracking support yet
2091 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2093 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2094 possible to set the basedir after __init__ time, so it is easier
2095 to use as a Service-child of the BuildMaster instance
2097 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2098 that delivers messages to its Service parent instead of requiring
2099 a subclass to be useful. This turns out to be much easier to build
2102 * buildbot/scripts/tryclient.py (createJob): utility code to
2103 create jobfiles, will eventually be used by 'buildbot try'
2105 2005-08-08 Brian Warner <warner@lothar.com>
2107 * docs/buildbot.texinfo (try): add docs on the
2108 as-yet-unimplemented Try scheduler
2110 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2111 * buildbot/test/test_scheduler.py: .. here
2112 (Scheduling.testTryJobdir): add placeholder test for 'try'
2114 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2115 addEntry merging (>=chunkSize) behavior
2116 (Log.testConsumer): update to handle new callLater(0) behavior
2118 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2119 both the MAX_LENGTH bugfix and the resumeProducing hang.
2121 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2122 put off the actual resumeProducing for a moment with
2123 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2124 causes large logfiles to hang midway through.
2126 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2127 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2128 and to improve memory usage when streaming the file out to a web
2130 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2131 make this work cleanly
2133 2005-08-03 Brian Warner <warner@lothar.com>
2135 * buildbot/trybuild.py: new file for 'try' utilities
2136 (getSourceStamp): run in a tree, find out the baserev+patch
2137 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2138 implemented for SVN and Darcs, still working on Arch. I don't know
2139 how to make CVS work yet.
2141 * docs/buildbot.texinfo: document the 'buildbot' command-line
2142 tool, including the not-yet-implemented 'try' feature, and the
2143 in-flux .buildbot/ options directory.
2145 2005-07-20 Brian Warner <warner@lothar.com>
2147 * buildbot/locks.py: added temporary id() numbers to Lock
2148 descriptions, to track down a not-really-sharing-the-Lock bug
2150 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2152 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2153 needed for python2.2 compatibility
2154 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2155 are from the __future__
2157 2005-07-19 Brian Warner <warner@lothar.com>
2159 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2160 message when schedulers use unknown builders
2162 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2163 SlaveLock('name') and MasterLock('name') are distinct
2165 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2166 c['schedulers'] in such a way that we can actually accept
2168 * buildbot/test/test_config.py: check it
2170 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2171 utility method to *all* the Schedulers
2172 (Periodic.listBuilderNames): same
2174 * docs/buildbot.texinfo (Interlocks): update chapter to match
2177 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2178 to make sure that c['sources'], c['schedulers'], and c['status']
2179 are all lists of the appropriate objects, and that the Schedulers
2180 all point to real Builders
2181 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2182 'listBuilderNames' utility method to support this
2183 * buildbot/scheduler.py: implement the utility method
2184 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2186 * docs/buildbot.texinfo: add some @cindex entries
2188 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2189 if it wasn't already set: most tla commands will fail unless one
2191 (Arch.createRepository): and disable bazaar's revision cache, since
2192 they cause test failures (the multiple repositories we create all
2193 interfere with each other through the cache)
2195 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2196 bring it properly up to date with twisted-2.0 test guidelines
2198 * buildbot/master.py (BuildMaster): remove references to old
2199 'interlock' module, this caused a bunch of post-merge test
2201 * buildbot/test/test_config.py: same
2202 * buildbot/process/base.py (Build): same
2204 * buildbot/test/test_slaves.py: stubs for new test case
2206 * buildbot/scheduler.py: add test-case-name tag
2207 * buildbot/test/test_buildreq.py: same
2209 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2210 unnecessary init code
2211 (Bot.remote_setBuilderList): match it
2213 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2215 * buildbot/changes/mail.py (parseSyncmail): update comment
2217 * buildbot/test/test_slavecommand.py: disable Shell tests on
2218 platforms that don't suport IReactorProcess
2220 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2221 all places where we open logfiles. It causes OS-X to open the file
2222 in some weird mode that that prevents us from mixing reads and
2223 writes to the same filehandle, which we depend upon to implement
2224 _generateChunks properly. This change doesn't appear to break
2225 win32, on which "b" and "t" are treated differently but a missing
2226 flag seems to be interpreted as "t".
2228 2005-07-18 Brian Warner <warner@lothar.com>
2230 * buildbot/slave/commands.py (ShellCommand): overhaul
2231 error-handling code, to try and make timeout/interrupt work
2232 properly, and make win32 happier
2233 * buildbot/test/test_slavecommand.py: clean up, stop using
2234 reactor.iterate, add tests for timeout and interrupt
2235 * buildbot/test/sleep.py: utility for a new timeout test
2237 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2238 code from the local-usebranches branch
2240 2005-07-17 Brian Warner <warner@lothar.com>
2242 * buildbot/process/process_twisted.py
2243 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2244 minutes, to match the other twisted BuildFactories, and don't
2245 excuse failures in c/qt/win32 reactors any more.
2247 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2248 'freebsd' builders, since the buildslaves have been unavailable
2251 2005-07-13 Brian Warner <warner@lothar.com>
2253 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2254 build-on-branch feature
2256 * buildbot/process/step.py (Darcs.__init__): add base_url and
2257 default_branch arguments, just like SVN
2258 (Arch.__init__): note that the version= argument is really the
2261 * buildbot/slave/commands.py (SourceBase): keep track of the
2262 repository+branch that was used for the last checkout in
2263 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2264 match, we clobber the directory and perform a fresh checkout
2265 rather than trying to do an in-place update. This should protect
2266 us against trying to get to branch B by doing an update in a tree
2267 obtained from branch A.
2268 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2269 (SVN.setup): same, just the svnurl
2270 (Darcs.setup): same, just the repourl
2271 (Arch.setup): same, arch coordinates (url), version, and
2272 buildconfig. Also pull the buildconfig from the args dictionary,
2273 which we weren't doing before, so the build-config was effectively
2275 (Arch.sourcedirIsUpdateable): don't try to update when we're
2276 moving to a specific revision: arch can't go backwards, so it is
2277 safer to just clobber the tree and checkout a new one at the
2279 (Bazaar.setup): same sourcedata as Arch
2281 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2282 use maybeWait, to work with twisted-1.3.0 and twcompat
2283 (Dependencies.testRun_Pass): same
2285 * buildbot/test/test_vc.py: rearrange, cleanup
2287 * buildbot/twcompat.py: add defer.waitForDeferred and
2288 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2289 can work under twisted-1.3.0 .
2291 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2292 now created at setUp time. This increases the runtime of the test
2293 suite considerably (from 91 seconds to 151), but it removes the
2294 need for an offline tarball, which should solve a problem I've
2295 seen where the test host has a different version of svn than the
2296 tarball build host. The new code also validates that mode=update
2297 really picks up recent commits. This approach will also make it
2298 easier to test out branches, because the code which creates the VC
2299 branches is next to the code which uses them. It will also make it
2300 possible to test some change-notification hooks, by actually
2301 performing a VC commit and watching to see the ChangeSource get
2304 2005-07-12 Brian Warner <warner@lothar.com>
2306 * docs/buildbot.texinfo (SVN): add branches example
2307 * docs/Makefile (buildbot.ps): add target for postscript manual
2309 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2310 * buildbot/test/test_locks.py: same
2312 * buildbot/process/step.py (Darcs): comment about default branches
2314 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2315 c['interlocks'] in the config file, complain if it is present.
2316 Scan all locks in c['builders'] to make sure the Locks they use
2318 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2319 add some tests to check for non-uniquely-named Locks
2320 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2321 since the unique-Lock validation code requires it now
2323 * buildbot/locks.py: fix test-case-name
2325 * buildbot/interlock.py: remove old file
2327 2005-07-11 Brian Warner <warner@lothar.com>
2329 * buildbot/test/test_interlock.py: rename to..
2330 * buildbot/test/test_locks.py: .. something shorter
2332 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2333 versions (after 2.0.1) changed internet.TCPClient to shut down the
2334 connection in stopService. Change the code to handle this
2337 * buildbot/process/base.py (Build): handle whole-Build locks
2338 * buildbot/process/builder.py (Builder.compareToSetup): same
2339 * buildbot/test/test_interlock.py: make tests work
2341 * buildbot/process/step.py (BuildStep.startStep): complain if a
2342 Step tries to claim a lock that's owned by its own Build
2343 (BuildStep.releaseLocks): typo
2345 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2346 file reloads don't replace unchanged Builders
2348 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2349 rewrite to cover new Locks instead of old c['interlocks']
2350 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2354 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2355 start the master and connect the buildslave
2357 * buildbot/process/step.py (FailingDummy.done): finish with a
2358 FAILURE status rather than raising an exception
2360 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2361 stringify a BuildRequest.reason that is None
2363 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2365 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2366 allow scheduler.Dependent to work
2367 * buildbot/buildset.py (BuildSet): set .reason and .results
2369 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2370 slaves, to make the test stop hanging. It still fails, of course,
2371 because I haven't even started to implement Locks.
2373 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2375 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2376 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2377 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2378 (Dependent): new class for downstream build dependencies
2379 * buildbot/test/test_dependencies.py: tests (still failing)
2381 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2383 2005-07-07 Brian Warner <warner@lothar.com>
2385 * buildbot/test/runutils.py (RunMixin): factored this class out..
2386 * buildbot/test/test_run.py: .. from here
2387 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2388 added new buildbot.locks tests (which all hang right now)
2389 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2390 * buildbot/process/step.py: claim/release per-BuildStep locks
2392 * docs/Makefile: add 'buildbot.html' target
2394 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2395 interpreted as "HEAD", so that all VC steps can accept branch=None
2396 and have it mean the "default branch".
2398 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2400 2005-07-07 Brian Warner <warner@lothar.com>
2402 * docs/examples/twisted_master.cfg: update to match current usage
2404 * docs/buildbot.texinfo (System Architecture): comment out the
2405 image, it doesn't exist yet and just screws up the HTML manual.
2407 2005-07-05 Brian Warner <warner@lothar.com>
2409 * debian/.cvsignore: oops, missed one. Removing leftover file.
2411 2005-06-17 Brian Warner <warner@lothar.com>
2413 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2414 changed its output in 1.2.0, don't mistakenly think that the
2415 subversion we find isn't capable of supporting our tests.
2417 * debian/*: remove the debian/ directory and its contents, to make
2418 life easier for the proper Debian maintainer
2420 * Makefile (release): same
2422 2005-06-07 Brian Warner <warner@lothar.com>
2424 * everything: create a distinct SourceStamp class to replace the
2425 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2426 Changed the signature of Source.startVC to include the revision
2427 information (instead of passing it through self.args). Implement
2428 branches for SVN (now only Darcs/Git is missing support). Add more
2431 2005-06-06 Brian Warner <warner@lothar.com>
2433 * everything: rearrange build scheduling. Create a new Scheduler
2434 object (configured in c['schedulers'], which submit BuildSets to a
2435 set of Builders. Builders can now use multiple slaves. Builds can
2436 be run on alternate branches, either requested manually or driven
2437 by changes. This changed some of the Status classes. Interlocks
2438 are out of service until they've been properly split into Locks
2439 and Dependencies. treeStableTimer, isFileImportant, and
2440 periodicBuild have all been moved from the Builder to the
2442 (BuilderStatus.currentBigState): removed the 'waiting' and
2443 'interlocked' states, removed the 'ETA' argument.
2445 2005-05-24 Brian Warner <warner@lothar.com>
2447 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2448 erroneously abandons the connection (in clientConnectionFailed)
2449 for non-UserErrors, which means that if we lose the connection due
2450 to a network problem or a timeout, we'll never try to reconnect.
2451 Fix this by not upcalling to the buggy parent method. Note:
2452 twisted-2.0 fixes this, but the function only has 3 lines so it
2453 makes more sense to copy it than to try and detect the buggyness
2454 of the parent class. Fixes SF#1207588.
2456 * buildbot/changes/changes.py (Change.branch): doh! Add a
2457 class-level attribute to accomodate old Change instances that were
2458 pickled before 0.6.5 (where .branch was added for new Changes).
2459 This fixes the exception that occurs when you try to look at an
2460 old Change (through asHTML).
2462 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2465 2005-05-23 Brian Warner <warner@lothar.com>
2467 * buildbot/__init__.py (version): release 0.6.6
2469 2005-05-23 Brian Warner <warner@lothar.com>
2471 * NEWS: update for 0.6.6 release
2472 * debian/changelog: same
2474 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2475 before starting: this was done by twistd back when we spawned it,
2476 now that we're importing the pieces and running them in the
2477 current process, we have to do it ourselves. This allows
2478 master.cfg to import files from the same directory without
2479 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2480 Stichele for the catch.
2481 (Options.opt_version): Add a --version command (actually, just make
2482 the existing --version command emit Buildbot's version too)
2484 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2485 fix to make this behave like other LogFiles, this time to handle
2486 existing LogFiles on disk. (add the missing .upgrade method)
2487 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2489 2005-05-21 Brian Warner <warner@lothar.com>
2491 * buildbot/test/test_runner.py (Create.testMaster): match the
2492 rawstring change in runner.py:masterTAC
2494 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2495 TwistedWords is installed
2496 * buildbot/test/test_status.py: same, with TwistedMail
2498 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2499 some old, deprecated, and removed config keys). This should enable
2500 you to use the base buildbot functionality with Twisted-2.0.0 when
2501 you don't also have TwistedWeb and TwistedWords installed
2503 2005-05-20 Brian Warner <warner@lothar.com>
2505 * buildbot/scripts/runner.py (run): call sendchange(), not
2506 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2507 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2508 (stop): don't wait for process to die when sending SIGHUP
2509 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2510 directory name gets interpreted, which you don't want
2513 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2516 2005-05-18 Brian Warner <warner@lothar.com>
2518 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2520 2005-05-18 Brian Warner <warner@lothar.com>
2522 * README: update for 0.6.5
2523 * debian/changelog: same
2525 * buildbot/changes/changes.py: rename tag= to branch=, since
2526 that's how we're using it, and my design for the upcoming "build a
2527 specific branch" feature wants it. also, tag= was too CVS-centric
2528 * buildbot/changes/mail.py (parseSyncmail): same
2529 * buildbot/process/base.py (Build.isBranchImportant): same
2530 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2531 * docs/buildbot.texinfo (Attributes of Changes): same
2533 * NEWS: update tag=, update for upcoming release
2535 2005-05-17 Brian Warner <warner@lothar.com>
2537 * buildbot/scripts/runner.py (stop): actually poll once per
2538 second, instead of re-killing the poor daemon once per second.
2539 Sleep briefly (0.1s) before the first poll, since there's a good
2540 chance we can avoid waiting the full second if the daemon shuts
2541 down quickly. Also remove the sys.exit() at the end.
2542 (start): remove the unneighborly sys.exit()
2544 * Makefile: improve permission-setting to not kick Arch so badly
2546 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
2547 default --keepalive=600, since it doesn't hurt very much, and it's
2548 a hassle to discover that you need it.
2549 * buildbot/test/test_runner.py (Create.testSlave): test it
2551 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
2552 IRC bot about EXCEPTION
2554 * buildbot/status/client.py (PBListener): upcall more correctly
2556 * buildbot/process/base.py (Build.allStepsDone): if a step caused
2557 an exception mark the overall build with EXCEPTION, not SUCCESS
2559 * buildbot/scripts/runner.py (makefile_sample): remove the leading
2561 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
2562 * Makefile: update some release-related stuff
2564 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
2565 gets called when there isn't actually an active process, just end
2566 the Command instead of blowing up. I don't know how it gets into
2567 this state, but the twisted win32 buildslave will sometimes hang,
2568 and when it shakes its head and comes back, it thinks it's still
2569 running a Command. The next build causes this command to be
2570 interrupted, but the lack of self.process.pid breaks the interrupt
2573 * NEWS: document changes since the last release
2575 * buildbot/scripts/runner.py (start): change 'buildbot start' to
2576 look for Makefile.buildbot instead of a bare Makefile . The
2577 'buildbot start' does not install this file, so you have to
2578 manually copy it if you want to customize startup behavior.
2579 (createMaster): change 'buildbot master' command to create
2580 Makefile.sample instead of Makefile, to create master.cfg.sample
2581 instead of master.cfg (requiring you to copy it before the
2582 buildmaster can be started). Both sample files are kept up to
2583 date, i.e. they are overwritten if they have been changed. The
2584 'buildbot.tac' file is *not* overwritten, but if the new contents
2585 don't match the old, a 'buildbot.tac.new' file is created and the
2586 user is warned. This seems to be a much more sane way to handle
2587 startup files. Also, don't sys.exit(0) when done, so we can run
2588 unit tests against it.
2589 (createSlave): same. Don't overwrite the sample info/ files.
2590 * buildbot/scripts/sample.mk: remove. the contents were pulled
2591 into runner.py, since they need to match the behavior of start()
2595 * docs/buildbot.texinfo (Launching the daemons): document it
2596 * buildbot/test/test_runner.py (Create): test it
2598 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
2599 version that can handle string-in-string tests, because otherwise
2600 python-2.2 fails the tests. It'd be tremendous if Trial's test
2601 took two strings under 2.2 too.
2603 * everything: fixed all deprecation warnings when running against
2604 Twisted-2.0 . (at least all the ones in buildbot code, there are a
2605 few that come from Twisted itself). This involved putting most of
2606 the Twisted-version specific code in the new buildbot.twcompat
2607 module, and creating some abstract base classes in
2608 buildbot.changes.base and buildbot.status.base (which might be
2609 useful anyway). __implements__ is a nuisance and requires an ugly
2610 'if' clause everywhere.
2612 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
2613 delay before finishing the test: it seems that smtp.sendmail
2614 doesn't hang up on the server, so we must wait a moment so it can
2615 hang up on us. This removes the trial warning about an unclean
2618 2005-05-16 Brian Warner <warner@lothar.com>
2620 * buildbot/process/step.py (Source): add 'retry' argument. It is a
2621 tuple of (delay, repeats).
2622 * buildbot/test/test_vc.py (Retry): test it
2623 * docs/buildbot.texinfo (Source Checkout): document it
2624 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
2625 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
2626 doVCFull() are handled by re-trying the checkout (after a delay)
2627 some number of times.
2628 (ShellCommand._startCommand): make header lines easier to read
2630 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
2632 (WebTest.test_logfile): make sure master gets shut down, silences
2633 some "unclean reactor" test errors
2635 * buildbot/test/test_changes.py (Sender.tearDown): spin the
2636 reactor once after shutdown, something in certain versions of
2637 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
2638 fails, svn-trunk is ok.
2640 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
2641 second win32 error message
2643 * buildbot/test/test_run.py (Status.testSlave): be smarter about
2644 validating the ETA, so the tests don't fail on slow systems
2646 2005-05-15 Brian Warner <warner@lothar.com>
2648 * buildbot/status/builder.py (HTMLLogFile): make this behave like
2649 the new LogFile class, so upgrading works properly
2650 (LogFileProducer.resumeProducing): survive resumeProducing after
2651 we've exhausted the chunkGenerator
2653 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
2655 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
2656 (Log.testUpgrade): same
2658 * docs/buildbot.texinfo (Maintenance): describe how to delete old
2659 Builds and logs with a cron job.
2661 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
2662 of the old non-offline LogFile, added code to upgrade these to
2663 new-style contents-live-on-disk instances at load time (in a way
2664 that doesn't invalidate the old Build pickles, so upgrading to
2665 0.6.5 is not a one-way operation). Got rid of everything related
2667 (LogFile.__init__): create LogFiles with the parent step status,
2668 the log's name, and a builder-relative filename where it can keep
2669 the contents on disk.
2670 (LogFile.hasContents): new method, clients are advised to call it
2671 before getText or getChunks and friends. If it returns False, the
2672 log's contents have been deleted and getText() will raise an
2674 (LogFile.getChunks): made it a generator
2675 (LogFile.subscribeConsumer): new method, takes a Twisted-style
2676 Consumer (except one that takes chunks instead of strings). This
2677 enables streaming of very large logfiles without storing the whole
2679 (BuildStatus.generateLogfileName): create names like
2680 12-log-compile-output, with a _0 suffix if required to be unique
2681 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
2682 or earlier) logfiles into new-style ones
2683 (BuilderStatus): remove everything related to 'stub' builds. There
2684 is now only one build cache, and we don't strip logs from old
2686 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
2687 since we no longer fight to keep it in the cache
2689 * buildbot/status/html.py (TextLog.render_GET): use a
2690 ChunkConsumer to stream the log entries efficiently.
2691 (ChunkConsumer): wrapper which consumes chunks and writes
2694 * buildbot/test/test_twisted.py (Parse.testParse): use a
2695 LogFile-like object instead of a real one
2697 * buildbot/test/test_status.py (MyLog): handle new LogFile code
2698 (Log.testMerge3): validate more merge behavior
2699 (Log.testChunks): validate LogFile.getChunks
2700 (Log.testUpgrade): validate old-style LogFile upgrading
2701 (Log.testSubscribe): validate LogFile.subscribe
2702 (Log.testConsumer): validate LogFile.subscribeConsumer
2704 * buildbot/interfaces.py (IStatusLogStub): remove
2705 (IStatusLog.subscribeConsumer): new method
2706 (IStatusLog.hasContents): new method
2707 (IStatusLogConsumer): describes things passed to subscribeConsumer
2709 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
2710 the log contents if it does not have any contents.
2711 (StatusResourceBuildStep.body): same
2712 (StatusResourceBuildStep.getChild): give a 404 for empty logs
2714 2005-05-14 Brian Warner <warner@lothar.com>
2716 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
2717 timeouts to try and make the windows metabuildslave not hang
2719 2005-05-13 Mike Taylor <bear@code-bear.com>
2721 * buildbot/slave/commands.py (rmdirRecursive): added a check
2722 to ensure the path passed into rmdirRecursive actually exists.
2723 On win32 a non-existant path would generate an exception.
2725 2005-05-13 Brian Warner <warner@lothar.com>
2727 * buildbot/slave/commands.py (rmdirRecursive): replacement for
2728 shutil.rmtree which behaves correctly on windows in the face of
2729 files that you have to chmod before deleting. Thanks to Bear at
2730 the OSAF for the routine.
2731 (SourceBase.doClobber): use rmdirRecursive
2733 2005-05-12 Brian Warner <warner@lothar.com>
2735 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
2736 method generate chunks instead of returning a big list. This
2737 allows the same method to be used for both old LogFile and new
2739 (OfflineLogFile.getText): use the generator
2740 (OfflineLogFile.subscribe): same
2741 * buildbot/status/html.py (TextLog.resumeProducing): same
2742 * buildbot/interfaces.py (IStatusLog.getChunks): document it
2744 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
2745 point out that OfflineLogFile does not currently work with
2746 html.Waterfall . Fixing this is high-priority.
2748 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
2749 apparently windows defaults to using stdout
2751 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
2752 better message on failure so I can figure out the win32 problem
2754 * buildbot/slave/commands.py (ShellCommand._startCommand): update
2755 log messages to include more useful copies of the command being
2756 run, the argv array, and the child command's environment.
2757 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
2759 2005-05-11 Brian Warner <warner@lothar.com>
2761 * setup.py: oops, install debug.glade so 'buildbot debugclient'
2763 * Makefile: update the deb-snapshot version
2765 * docs/buildbot.texinfo: move all .xhtml docs into a new
2766 .texinfo-format document, adding a lot of material in the process.
2767 This is starting to look like a real user's manual. Removed all
2768 the Lore-related files: *.xhtml, *.css, template.tpl .
2769 * docs/Makefile: simple makefile to run 'makeinfo'
2770 * buildbot/scripts/sample.cfg: rearrange slightly
2771 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
2773 2005-05-10 Brian Warner <warner@lothar.com>
2775 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
2776 different name for the internal twistw module, handle it.
2778 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
2779 * setup.py: .. and stop trying to install it
2781 * buildbot/process/step.py (Git): added support for 'cogito' (aka
2782 'git'), the new linux kernel VC system (http://kernel.org/git/).
2783 Thanks to Brandon Philips for the patch.
2784 * buildbot/slave/commands.py (Git): same
2786 2005-05-06 Brian Warner <warner@lothar.com>
2788 * buildbot/status/builder.py (OfflineLogFile): replace the default
2789 LogFile with a form that appends its new contents to a disk file
2790 as they arrive. The complete log data is never kept in RAM. This
2791 is the first step towards handling very large (100MB+) logfiles
2792 without choking quite so badly. (The other half is
2793 producer/consumer on the HTML pages).
2794 (BuildStepStatus.addLog): use OfflineLogFile by default
2795 (BuildStatus.getLogfileName): helper code to give the
2796 OfflineLogFile a filename to work with
2798 * buildbot/test/test_status.py (Results.testAddResults): update
2799 tests to handle new asserts
2800 * buildbot/test/test_vc.py (Patch.doPatch): same
2801 * buildbot/test/test_steps.py (BuildStep.setUp): same
2803 2005-05-05 Brian Warner <warner@lothar.com>
2805 * buildbot/scripts/runner.py (start): if there is no Makefile,
2806 launch the app by importing twistd's internals and calling run(),
2807 rather than spawning a new twistd process. This stands a much
2808 better chance of working under windows.
2809 (stop): kill the process with os.kill instead of spawning
2810 /bin/kill, again to reduce the number of external programs which
2811 windows might not have in the PATH. Also wait up to 5 seconds for
2812 the process to go away, allowing things like 'buildbot stop;
2813 buildbot start' to be reliable in the face of slow shutdowns.
2815 * buildbot/master.py (Dispatcher.__getstate__): remove old
2816 .tap-related methods
2817 (BuildMaster.__getstate__): same
2819 * buildbot/slave/bot.py (makeService): same
2820 (Options.longdesc): same
2821 * buildbot/scripts/runner.py: copy over some old mktap option text
2823 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
2824 'buildbot master' now creates a buildbot.tac file, so there is no
2825 longer a create-instance/save/reload sequence. mktap is dead, long
2827 * buildbot/scripts/sample.mk: use twistd -y, not -f
2828 * buildbot/test/test_config.py: remove mktap-based test
2829 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
2830 * README: don't reference mktap
2832 * docs/source.xhtml: document some of the attributes that Changes
2835 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
2837 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
2838 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
2839 * buildbot/changes/changes.py (Change)
2840 * buildbot/changes/mail.py (parseSyncmail)
2841 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
2843 * buildbot/process/base.py (Build.isTagImportant)
2847 2005-05-04 Brian Warner <warner@lothar.com>
2849 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
2850 connection after sending the change, so that unit tests don't
2851 complain about sockets being left around
2853 * buildbot/status/html.py (WaterfallStatusResource.body): fix
2854 exception in phase=0 rendering
2855 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
2857 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
2859 * buildbot/master.py (BuildMaster.loadConfig): finally remove
2860 deprecated config keys: webPortnum, webPathname, irc, manholePort,
2861 and configuring builders with tuples.
2862 * buildbot/test/test_config.py: stop testing compatibility with
2863 deprecated config keys
2864 * buildbot/test/test_run.py: same
2866 2005-05-03 Brian Warner <warner@lothar.com>
2868 * contrib/arch_buildbot.py: survive if there are no logfiles
2869 (username): just use a string, os.getlogin isn't reliable
2871 * buildbot/scripts/runner.py (sendchange): oops, fix the command
2872 so 'buildbot sendchange' actually works. The earlier test only
2873 covered the internal (non-reactor-running) form.
2875 * contrib/arch_buildbot.py: utility that can run as an Arch hook
2876 script to notify the buildmaster about changes
2878 * buildbot/scripts/runner.py (sendchange): new command to send a
2879 change to a buildbot.changes.pb.PBChangeSource receiver.
2880 * buildbot/test/test_changes.py (Sender): test it
2882 * buildbot/master.py (BuildMaster.startService): mark .readConfig
2883 after any reading of the config file, not just when we do it in
2884 startService. This makes some tests a bit cleaner.
2886 * buildbot/changes/pb.py: add some log messages
2888 * buildbot/process/base.py (Build.startBuild): fix a bug that
2889 caused an exception when the build terminated in the very first
2891 (Build.stepDone): let steps return a status of EXCEPTION. This
2892 terminates the build right away, and sets the build's overall
2893 status to EXCEPTION too.
2894 * buildbot/process/step.py (BuildStep.failed): return a status of
2895 EXCEPTION when that is what has happened.
2897 * buildbot/process/step.py (Arch.computeSourceRevision): finally
2898 implement this, allowing Arch-based projects to get precise
2899 checkouts instead of always using the latest code
2900 (Bazaar): create variant of Arch to let folks use baz instead of
2901 tla. Requires a new buildslave too.
2902 * buildbot/slave/commands.py (Arch): add 'revision' argument
2903 (Bazaar): create variant of Arch that uses baz instead of tla.
2904 Remove the code that extracts the archive name from the
2905 register-archive output, since baz doesn't provide it, and require
2906 the user provide both the archive name and its location.
2907 * buildbot/test/test_vc.py (VC.testBazaar): added tests
2909 2005-05-02 Brian Warner <warner@lothar.com>
2911 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
2912 thanks to Nick Trout.
2914 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
2915 deals better with source Makefile coming from a read-only CVS
2916 checkout. Thanks to Nick Trout for the catch.
2918 * buildbot/__init__.py (version): bump to 0.6.4+ while between
2921 2005-04-28 Brian Warner <warner@lothar.com>
2923 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
2925 * debian/changelog: update for 0.6.4
2927 2005-04-28 Brian Warner <warner@lothar.com>
2929 * README.w32: add a checklist of steps for getting buildbot
2931 * MANIFEST.in: include it in the tarball
2935 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
2936 broken .tap files from 0.6.3 by getting rid of .services,
2937 .namedServices, and .change_svc at load time.
2939 2005-04-27 Brian Warner <warner@lothar.com>
2941 * NEWS: update in preparation for new release
2943 * buildbot/test/test_config.py (Save.testSave): don't pull in
2944 twisted.scripts.twistd, we don't need it and it isn't for windows
2947 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
2948 accomodate win32 which can't do atomic-rename
2950 2005-04-27 Brian Warner <warner@lothar.com>
2952 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
2953 timeouts to help the slow metabuildbot not flunk them so much
2954 (Disconnect.testBuild3): same
2955 (Disconnect.testBuild4): same
2956 (Disconnect.testInterrupt): same
2958 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
2959 setup, it was completely broken for new buildmasters (those which
2960 did not have a 'change.pck' already saved. Thanks to Paul Warren
2961 for catching this (embarrassing!) bug.
2962 (Dispatcher.__getstate__): don't save our registered avatar
2963 factories, since they'll be re-populated when the config file is
2965 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
2966 tests (since the real mktap-generated BuildMaster doesn't save
2968 (BuildMaster.__getstate__): don't save any service children,
2969 they'll all be re-populated when the config file is re-read.
2970 * buildbot/test/test_config.py (Save.testSave): test for this
2972 2005-04-26 Brian Warner <warner@lothar.com>
2974 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
2975 rendered with Blender.. looks a bit nicer.
2976 * buildbot/docs/images/icon.blend: add the Blender file for it
2978 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
2979 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
2980 running under windows. This appears to be the best way to allow
2981 BuildSteps to do something normal like 'trial -v buildbot.test' or
2982 'make foo' and still expect it to work. The idea is to make the
2983 BuildSteps look as much like what a developer would type when
2984 compiling or testing the tree by hand. This approach probably has
2985 problems when there are spaces in the arguments, so if you've got
2986 windows buildslaves, you'll need to pay close attention to your
2989 * buildbot/status/html.py (WaterfallStatusResource.body): add the
2990 timezone to the timestamp column.
2991 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
2993 * buildbot/scripts/runner.py (loadOptions): do something sane for
2994 windows, I think. We use %APPDATA%/buildbot instead of
2995 ~/.buildbot, but we still search everywhere from the current
2996 directory up to the root for a .buildbot/ subdir. The "is it under
2997 $HOME" security test was replaced with "is it owned by the current
2998 user", which is only performed under posix.
2999 * buildbot/test/test_runner.py (Options.testFindOptions): update
3000 tests to match. The "is it owned by the current user" check is
3001 untested. The test has been re-enabled for windows.
3003 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3004 any "\n" in the expected output with the platform-specific line
3005 separator. Make this separator "\r\n" on PTYs under unix, they
3006 seem to do that and I don't know why
3008 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3009 windows for now, I don't know what ~/.buildbot/ should mean there.
3011 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3012 win32 compatibility, don't use "/tmp"
3013 (Basedir.testChangeBuilddir): remove more unixisms
3015 2005-04-26 Brian Warner <warner@lothar.com>
3017 * buildbot/test/test_control.py (Force.rmtree): python2.2
3018 compatibility, apparently its shutil.rmtree ignore_errors=
3019 argument is ignored.
3020 * buildbot/test/test_run.py (Run.rmtree): same
3021 (RunMixin.setUp): same
3023 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3026 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3027 'substring in string' operator, must use string.find(substr)!=-1
3028 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3029 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3031 * buildbot/scripts/runner.py (loadOptions): add code to search for
3032 ~/.buildbot/, a directory with things like 'options', containing
3033 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3034 the current directory, your $HOME directory, or anywhere
3035 inbetween, as long as you're somewhere inside your home directory.
3036 (debugclient): look in ~/.buildbot/options for master and passwd
3037 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3038 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3040 * buildbot/status/client.py (makeRemote): new approach to making
3041 IRemote(None) be None, which works under Twisted-2.0
3042 * buildbot/test/test_status.py (Client.testAdaptation): test it
3044 * buildbot/status/builder.py (Status.builderAdded): when loading a
3045 pickled BuilderStatus in from disk, set its name after loading.
3046 The config file might have changed its name (but not its
3047 directory) while it wasn't looking.
3049 * buildbot/process/builder.py (Builder.attached): always return a
3050 Deferred, even if the builder was already attached
3051 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3053 2005-04-25 Brian Warner <warner@lothar.com>
3055 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3056 category-related exception when announcing a build has finished
3058 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3059 reference no-longer-existent changemaster.sources
3060 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3062 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3065 2005-04-25 Brian Warner <warner@lothar.com>
3067 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3069 * debian/changelog: update for 0.6.3
3071 2005-04-25 Brian Warner <warner@lothar.com>
3073 * MANIFEST.in: make sure debug.glade is in the tarball
3075 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3077 * NEWS: update for the imminent 0.6.3 release
3079 * buildbot/status/html.py (HtmlResource.content): make the
3080 stylesheet <link> always point at "buildbot.css".
3081 (StatusResource.getChild): map "buildbot.css" to a static.File
3082 containing whatever css= argument was provided to Waterfall()
3083 (Waterfall): provide the "classic" css as the default.
3084 * docs/waterfall.classic.css: move default CSS from here ..
3085 * buildbot/status/classic.css: .. to here
3087 * MANIFEST.in: make sure classic.css is included in the tarball
3088 * setup.py: and that it is installed too, under buildbot/status/
3090 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3091 the module level, because buildbot.tap files from 0.6.2 don't have
3092 it in their attribute dictionary.
3094 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3095 really exists at startup, might save some confusion somewhere.
3097 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3099 * docs/waterfall.classic.css:
3100 add a stylesheet that's almost the same as the "classic"
3103 * buildbot/status/builder.py:
3104 add EXCEPTION as a result - this is a problem for the bot
3105 maintainer, not a build problem for the changers
3106 * buildbot/process/step.py:
3107 use EXCEPTION instead of FAILURE for exceptions
3108 * buildbot/status/html.py:
3109 add build_get_class to get a class out of a build/buildstep
3110 finish naming the classes
3111 split out sourceNames to changeNames and builderNames so we
3112 can style them separately
3113 * docs/config.xhtml:
3114 finish documenting classes as they are right now
3116 * buildbot/status/html.py:
3117 name the classes as we agreed on IRC
3118 * docs/config.xhtml:
3121 * buildbot/status/html.py:
3122 same for cssclass->class_
3124 * buildbot/status/html.py:
3125 as decided on IRC, use class_ for the "class" attribute to not
3126 conflict with the class keyword, and clean up the messy **{} stuff.
3128 * buildbot/status/mail.py:
3129 put back "builders" argument, and fix docstring, because the
3130 code *ignores* builders listed in this argument
3132 * buildbot/process/builder.py:
3133 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3135 * docs/config.xhtml:
3136 describe the category argument for builders
3138 * buildbot/status/builder.py:
3139 Fix a silly bug due to merging
3141 * buildbot/process/builder.py:
3142 remove category from the process Builder ...
3143 * buildbot/status/builder.py:
3144 ... and add it to BuilderStatus instead.
3145 Set category on unpickled builder statuses, they might not have it.
3146 * buildbot/master.py:
3147 include category when doing builderAdded
3148 * buildbot/status/mail.py:
3149 return None instead of self for builders we are not interested in.
3150 * buildbot/test/test_run.py:
3151 fix a bug due to only doing deferredResult on "dummy" waiting
3152 * buildbot/test/test_status.py:
3153 add checks for the Mail IStatusReceiver returning None or self
3155 * buildbot/status/html.py:
3156 fix testsuite by prefixing page title with BuildBot
3158 * buildbot/status/builder.py:
3159 have .category in builder status ...
3160 * buildbot/process/builder.py:
3161 ... and set it from Builder
3162 * buildbot/status/html.py:
3163 make .css a class variable
3164 * buildbot/test/test_status.py:
3165 write more tests to cover our categories stuff ...
3166 * buildbot/status/mail.py:
3167 ... and fix the bug that this uncovered
3169 * buildbot/changes/mail.py:
3170 * buildbot/changes/pb.py:
3171 * buildbot/master.py:
3172 * buildbot/process/base.py:
3173 * buildbot/process/factory.py:
3174 * buildbot/process/interlock.py:
3175 * buildbot/process/step.py:
3176 * buildbot/process/step_twisted.py:
3177 * buildbot/slave/commands.py:
3178 * buildbot/status/builder.py:
3179 * buildbot/status/client.py:
3180 * buildbot/status/html.py:
3181 * buildbot/status/mail.py:
3182 * buildbot/status/progress.py:
3183 * buildbot/test/test_changes.py:
3184 * buildbot/test/test_config.py:
3185 * buildbot/test/test_control.py:
3186 * buildbot/test/test_interlock.py:
3187 * buildbot/test/test_maildir.py:
3188 * buildbot/test/test_mailparse.py:
3189 * buildbot/test/test_run.py:
3190 * buildbot/test/test_slavecommand.py:
3191 * buildbot/test/test_status.py:
3192 * buildbot/test/test_steps.py:
3193 * buildbot/test/test_twisted.py:
3194 * buildbot/test/test_util.py:
3195 * buildbot/test/test_vc.py:
3196 * buildbot/test/test_web.py:
3198 add test-case-name at the top of a whole set of files
3200 * buildbot/status/builder.py:
3201 keep order of addition when getting builder names
3202 * buildbot/status/words.py:
3203 * buildbot/test/test_run.py:
3204 add test for getBuilderNames
3206 * buildbot/process/base.py:
3207 * buildbot/process/step.py:
3208 * buildbot/status/builder.py:
3209 * buildbot/status/html.py:
3210 make buildbot css-able
3211 replace the color code for purple with purple, don't understand
3212 why it wasn't purple to start with
3214 * buildbot/status/words.py:
3215 ok, so it doesn't look like BuilderStatus.remote is still valid.
3216 Use what waterfall uses instead.
3218 * buildbot/interfaces.py:
3219 * buildbot/status/builder.py:
3220 * buildbot/status/html.py:
3221 * buildbot/status/mail.py:
3222 * buildbot/status/words.py:
3223 * buildbot/test/test_run.py:
3224 use categories everywhere and make it be a list. More sensible
3225 for the future. Also make words actually respect this in
3228 * buildbot/interfaces.py:
3229 add category argument to getBuilderNames
3230 * buildbot/process/builder.py:
3231 * buildbot/status/builder.py:
3232 * buildbot/status/html.py:
3233 * buildbot/status/mail.py:
3234 * buildbot/status/words.py:
3235 * buildbot/test/test_run.py:
3236 move from specifying builders by name to specifying the category
3238 * buildbot/status/html.py:
3239 * buildbot/status/words.py:
3240 add "builders=" to __init__ of status clients so they can
3241 limit themselves to the given list of builders to report on
3243 * buildbot/status/html.py: set the title to the product name
3245 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3247 * buildbot/interfaces.py:
3248 * buildbot/status/builder.py:
3249 more documentation. Hm, not sure if ChangeLog entries make sense
3252 2005-04-23 Brian Warner <warner@lothar.com>
3254 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3256 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3258 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3259 the sub-commands that log buildmaster status to stdout and to a
3260 GUI window, respectively.
3262 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3263 functionality is working again, but all the step-status and ETA
3264 stuff is missing. Commented out a lot of code pending more
3267 * buildbot/status/client.py: make sure that IRemote(None) is None
3269 * buildbot/changes/changes.py: import defer, oops
3270 (ChangeMaster): remove the .sources list, rely upon the fact that
3271 MultiServices can be treated as sequences of their children. This
3272 cleans up the add/remove ChangeSource routines a lot, as we keep
3273 exactly one list of the current sources instead of three.
3275 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3276 up an empty ChangeMaster at init time.
3277 (BuildMaster.loadChanges): if there are changes to be had from
3278 disk, replace self.change_svc with the new ones. If not, keep
3279 using the empty ChangeMaster set up in __init__.
3280 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3281 instead of a separate list, makes the code a bit cleaner.
3282 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3283 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3284 Extend the test to make sure we can get rid of the sources when
3287 2005-04-22 Brian Warner <warner@lothar.com>
3289 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3290 and info/host files when making the slave directory
3292 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3293 whendone= argument, just return the Deferred and let the caller do
3294 what they want with it.
3295 (Disconnect.testBuild1): wait for shutdownSlave
3296 (Basedir.testChangeBuilddir): new test to make sure changes to the
3297 builddir actually get propagated to the slave
3299 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3300 explicit method, rather than passing the builddir in __init__ .
3301 Make sure to update self.basedir too, this was broken before.
3302 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3303 builders and for ones that have just had their builddir changed.
3304 (BotFactory): add a class-level .perspective attribute, so
3305 BuildSlave.waitUntilDisconnected won't get upset when the
3306 connection hasn't yet been established
3307 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3308 tests can reach through it to inspect the SlaveBuilders
3310 * buildbot/process/base.py (Build.buildException): explain the
3311 log.err with a log.msg
3312 * buildbot/process/builder.py (Builder.startBuild): same
3313 (Builder._startBuildFailed): improve error message
3315 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3316 occurred because we lost the brand-new connection, retry instead
3317 of giving up. If not, it's probably an authorization failure, and
3318 it makes sense to stop trying. Make sure we log.msg the reason
3319 that we're log.err'ing the failure, otherwise test failures are
3320 really hard to figure out.
3322 * buildbot/master.py: change loadConfig() to return a Deferred
3323 that doesn't fire until the change has been fully implemented.
3324 This means any connected slaves have been updated with the new
3325 builddir. This change makes it easier to test the code which
3326 actually implements this builddir-updating.
3327 (BotPerspective.addBuilder): return Deferred
3328 (BotPerspective.removeBuilder): same
3329 (BotPerspective.attached): same
3330 (BotPerspective._attached): same. finish with remote_print before
3331 starting the getSlaveInfo, instead of doing them in parallel
3332 (BotPerspective.list_done): same
3333 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3334 actually calling slave.disconnect()
3335 (BotMaster.addBuilder): same
3336 (BotMaster.removeBuilder): same
3337 (BuildMaster.loadConfig): same
3338 (BuildMaster.loadConfig_Slaves): same
3339 (BuildMaster.loadConfig_Sources): same
3340 (BuildMaster.loadConfig_Builders): same
3341 (BuildMaster.loadConfig_status): same
3343 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3344 a Deferred that fires when the source is finally removed
3346 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3347 the previous tree on win32, where we have to do it synchronously,
3348 make sure we return a Deferred anyway.
3349 (SourceBase.doCopy): same
3351 * buildbot/scripts/runner.py (statusgui): use the text client for
3352 now, while I rewrite the Gtk one
3353 * buildbot/clients/base.py: strip out old code, leaving just the
3354 basic print-message-on-event functionality. I also remove the
3355 ReconnectingPBClientFactory, but it does at least quit when it
3356 loses the connection instead of going silent
3358 2005-04-21 Brian Warner <warner@lothar.com>
3360 * Makefile: minor tweaks
3362 * NEWS: point out deprecation warnings, new features for
3365 * buildbot/master.py (BuildMaster.loadConfig): emit
3366 DeprecationWarnings for Builders defined with tuples. Rearrange
3367 code to facility removal of deprecated configuration keys in the
3370 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3371 'buildbot' command to put a little Makefile in the target that
3372 helps you re-create the buildbot.tap file, start or stop the
3373 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3374 all the files 0600, since they contain passwords.
3375 (start): if there is a Makefile, and /usr/bin/make exists, use
3376 'make start' in preference to a raw twistd command. This lets
3377 slave admins put things like PYTHONPATH variables in their
3378 Makefiles and have them still work when the slave is started with
3379 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3380 be nice to first try the 'make' command and only fall back to
3381 twistd if it fails. TODO: the Makefile's "start" command does not
3382 add the --reactor=win32 argument when running under windows.
3383 (Options.debugclient, Options.statusgui): add sub-commands to launch
3384 the debug client (formerly in contrib/debugclient.py) and the
3385 Gtk status application (currently broken)
3386 * buildbot/clients/debug.py: move from contrib/debugclient.py
3387 * buildbot/clients/debug.glade: same
3389 * buildbot/test/test_trial.py: remove it. This requires some
3390 functionality out of Twisted that isn't there yet, and until then
3391 having it around just confuses things.
3393 * buildbot/test/test_slavecommand.py (Shell): test both with and
3394 without PTYs, and make sure that command output is properly
3395 interleaved in the with-PTY case. I think the without-PTY test
3396 should pass on windows, where we never use PTYs anyway.
3398 2005-04-20 Brian Warner <warner@lothar.com>
3400 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3402 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3404 * NEWS: start creating entries for the next release
3406 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3408 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3409 (WebTest.test_webPathname): same
3410 (WebTest.test_webPathname_port): same
3411 (WebTest.test_waterfall): use the default favicon rather than
3412 rooting around the filesystem for it. Open the expected-icon file
3413 in binary mode, to make win32 tests happier (thanks to Nick Trout
3415 * buildbot/status/html.py (buildbot_icon): win32 portability
3417 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3418 win32-compatibility fixes from Nick Trout, the "file not found" message
3419 is different under windows
3420 (FakeSlaveBuilder.__init__): clean up setup a bit
3421 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3423 2005-04-19 Brian Warner <warner@lothar.com>
3425 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3426 skip-if-repositories-are-unavailable test to not kill the trial
3427 that comes with Twisted-1.3.0
3429 * setup.py: install buildbot.png icon file when installing code
3431 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3432 environment used by the command, at least on the child side.
3434 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3435 this method needs to be added and implemented because it gets
3436 called under heavy load. I don't quite understand the
3437 producer/consumer API enough to write it.
3438 (StatusResource.getChild): add a resource for /favicon.ico
3439 (Waterfall.__init__): add favicon= argument
3440 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3441 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3442 (WebTest.test_webPathname): same
3443 (WebTest.test_webPathname_port): same
3444 * docs/config.xhtml: mention favicon=
3445 * buildbot/buildbot.png: add a default icon, dorky as it is
3447 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3449 * buildbot/master.py:
3450 * buildbot/process/base.py:
3451 * buildbot/process/builder.py:
3452 * buildbot/process/interlock.py:
3453 * buildbot/status/builder.py:
3454 * buildbot/status/html.py:
3455 * buildbot/status/mail.py:
3456 * buildbot/status/words.py:
3457 new documentation while digging through the code
3459 2005-04-17 Brian Warner <warner@lothar.com>
3461 * general: try to fix file modes on all .py files: a+r, a-x,
3462 but let buildbot/clients/*.py be +x since they're tools
3464 * docs/epyrun (addMod): when an import fails, say why
3466 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3468 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3470 * buildbot/process/base.py:
3471 * buildbot/process/builder.py:
3472 * buildbot/status/builder.py:
3473 new documentation while digging through the code
3475 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3477 * buildbot/changes/changes.py:
3478 * buildbot/changes/p4poller.py:
3479 * buildbot/interfaces.py:
3480 * buildbot/process/base.py:
3481 * buildbot/process/builder.py:
3482 * buildbot/process/step.py:
3483 * buildbot/process/step_twisted.py:
3484 * buildbot/slave/bot.py:
3485 * buildbot/slave/commands.py:
3486 * buildbot/status/builder.py:
3487 fix all docstrings to make epydoc happy. In the process of fixing
3488 some, I also moved pieces of docs, and removed some deprecated
3491 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3493 * buildbot/process/builder.py:
3494 * buildbot/process/interlock.py:
3495 * buildbot/process/process_twisted.py:
3496 * buildbot/process/step.py:
3497 BuildProcess -> Build, as it looks like that's what happened
3498 * buildbot/process/base.py:
3499 * buildbot/process/factory.py:
3502 2005-04-17 Brian Warner <warner@lothar.com>
3504 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3505 update compile command to accomodate the Twisted split.. now
3506 instead of './setup.py build_ext -i', you do './setup.py all
3507 build_ext -i', to run build_ext over all sub-projects.
3508 (FullTwistedBuildFactory): same
3509 (TwistedReactorsBuildFactory): same
3511 * buildbot/status/html.py (TextLog.finished): null out self.req
3512 when we're done, otherwise the reference cycle of TextLog to .req
3513 to .notifications to a Deferred to TextLog.stop keeps them from
3514 being collected, and consumes a huge (610MB on pyramid at last
3515 check) amount of memory.
3517 2005-04-11 Brian Warner <warner@lothar.com>
3519 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3520 normalize the VC-repository location.. makes SVN happier with
3521 certain test environments.
3523 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3524 RemoteShellCommand gets its own .env dictionary, so that code in
3525 start() doesn't mutate the original. I think this should fix the
3526 step_twisted.Trial problem where multiple identical components
3527 kept getting added to PYTHONPATH= over and over again.
3529 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3530 adding epydoc-format docstrings to many classes. Thanks to Thomas
3531 Vander Stichele for the patches.
3532 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3533 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3534 * buildbot/slave/bot.py, commands.py, registry.py: same
3536 2005-04-05 Brian Warner <warner@lothar.com>
3538 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3539 preserve timestamps, helps incremental builds of large trees.
3540 Patch from Rene Rivera.
3542 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
3543 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
3546 2005-04-03 Brian Warner <warner@lothar.com>
3548 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
3549 with one dict, apparently exec has some scoping bugs when used
3550 with both global/local dicts. Thanks to Nathaniel Smith for the
3553 2005-04-02 Brian Warner <warner@lothar.com>
3555 * buildbot/process/step_twisted.py (countFailedTests): the new
3556 trial in Twisted-2.0 emits a slightly different status line than
3557 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
3558 mistakenly think the test count is unparseable.
3559 (Trial.start): note that for some reason each build causes another
3560 copy of self.testpath to be prepended to PYTHONPATH. This needs to
3561 be fixed but I'm not sure quite where the problem is.
3563 2005-04-01 Brian Warner <warner@lothar.com>
3565 * buildbot/test/test_run.py (Run.testMaster): change some uses of
3566 deferredResult to avoid hangs/warnings under twisted-2.0
3567 (RunMixin.tearDown): same
3568 (RunMixin.shutdownSlave): same
3569 (Disconnect.testIdle1): same
3570 (Disconnect.testBuild2): same: wait one second after the build
3571 finishes for test to really be done.. this should be cleaned up to
3572 avoid wasting that second. Builder.detach uses a callLater(0),
3573 either that should be done in-line (something else needed that
3574 behavior), or it should return a Deferred that fires when the
3575 builder is really offline.
3576 (Disconnect.testBuild3): same
3577 (Disconnect.testDisappear): same
3579 * buildbot/test/test_web.py: rearrange server-setup and teardown
3580 code to remove unclean-reactor warnings from twisted-2.0
3582 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
3583 so the tests don't hang under twisted-2.0
3585 2005-03-31 Brian Warner <warner@lothar.com>
3587 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
3588 caused a warning each time the master changed our set of builders
3590 * buildbot/status/builder.py (BuildStatus.saveYourself): under
3591 w32, don't unlink the file unless it already exists. Thanks to
3592 Baptiste Lepilleur for the catch.
3593 (BuilderStatus.saveYourself): same
3595 2005-02-01 Brian Warner <warner@lothar.com>
3597 * buildbot/status/html.py (TextLog.getChild): use a /text child
3598 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
3599 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
3600 logfile as text/plain (no markup, no headers). This replaces the
3601 previous scheme (which used an ?text=1 argument), and gets us back
3602 to a relative link (which works better when the buildbot lives
3603 behind another web server, such as Apache configured as a reverse
3604 proxy). Thanks to Gerald Combs for spotting the problem.
3606 * buildbot/__init__.py (version): bump to 0.6.2+ while between
3609 2004-12-13 Brian Warner <warner@lothar.com>
3611 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
3613 * debian/changelog: update for 0.6.2
3614 * NEWS: finalize for 0.6.2
3616 2004-12-11 Brian Warner <warner@lothar.com>
3618 * NEWS: bring it up to date
3620 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
3621 detection code. Require some sign of life from the buildmaster
3622 every BotFactory.keepaliveInterval seconds. Provoke this
3623 indication at BotFactory.keepaliveTimeout seconds before the
3624 deadline by sending a keepalive request. We don't actually care if
3625 that request is answered in a timely fashion, what we care about
3626 is that .activity() is called before the deadline. .activity() is
3627 triggered by any PB message from the master (including an ack to
3628 one of the slave's status-update messages). With this new scheme,
3629 large status messages over slow pipes are OK, as long as any given
3630 message can be sent (and thus acked) within .keepaliveTimeout
3631 seconds (which defaults to 30).
3632 (SlaveBuilder.remote_startCommand): record activity
3633 (SlaveBuilder.ackUpdate): same
3634 (SlaveBuilder.ackComplete): same
3635 (BotFactory.gotPerspective): same
3636 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
3638 2004-12-09 Brian Warner <warner@lothar.com>
3640 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
3643 * buildbot/process/step_twisted.py (Trial._commandComplete):
3644 update self.cmd when we start the 'cat test.log' transfer. Without
3645 this, we cannot interrupt the correct RemoteCommand when we lose
3648 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
3649 trying to tell the slave to stop the command if we're already
3650 inactive, or if we no longer have a .remote
3652 * buildbot/process/builder.py (Builder._detached): don't let an
3653 exception in currentBuild.stopBuild() prevent the builder from
3654 being marked offline
3656 2004-12-07 Brian Warner <warner@lothar.com>
3658 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
3659 KeyError that happens when you ask for a non-existent Builder, and
3660 translate it into a UsageError.
3662 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
3663 losing the slave in the middle of a remote step is handled too
3665 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
3666 be a Failure, so be sure to stringify it before using it as the
3667 contents of the 'interrupt' logfile
3668 (RemoteCommand.interrupt): use stringified 'why' in
3669 remote_interruptCommand too, just in case
3671 2004-12-06 Brian Warner <warner@lothar.com>
3673 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
3674 instead of 'tla update', which is more efficient in case we've
3675 missed a couple of patches since the last update.
3677 * debian/changelog: update for previous (0.6.1) release. Obviously
3678 this needs to be handled better.
3680 2004-12-05 Brian Warner <warner@lothar.com>
3682 * NEWS: update for stuff since last release
3684 * buildbot/master.py (DebugPerspective.attached): return 'self', to
3685 match the maybeDeferred change in Dispatcher.requestAvatar
3686 * buildbot/changes/pb.py (ChangePerspective.attached): same
3687 * buildbot/status/client.py (StatusClientPerspective.attached): same
3688 * buildbot/process/builder.py (Builder._attached3): same
3689 * buildbot/pbutil.py (NewCredPerspective.attached): same
3691 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
3692 the date to the top-most box, if it is not the same as today's
3695 * docs/slave.xhtml: provide a buildslave setup checklist
3697 * docs/source.xhtml (Arch): correct terminology
3699 2004-12-04 Brian Warner <warner@lothar.com>
3701 * buildbot/test/test_slavecommand.py: use sys.executable instead
3702 of hard-coding 'python' for child commands, might help portability
3704 * docs/examples/twisted_master.cfg: update to current usage
3706 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
3707 'stop build' command to the IRC bot
3709 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
3710 message that broke PBChangeSource
3712 * buildbot/slave/bot.py: clean up shutdown/lose-master code
3713 (SlaveBuilder): make some attributes class-level, remove the old
3714 "update queue" which existed to support resuming a build after the
3715 master connection was lost. Try to reimplement that feature later.
3716 (SlaveBuilder.stopCommand): clear self.command when the
3717 SlaveCommand finishes, so that we don't try to kill a leftover one
3719 (SlaveBuilder.commandComplete): same, merge with commandFailed and
3722 * buildbot/slave/commands.py (SourceBase): set self.command for
3723 all VC commands, so they can be interrupted.
3725 2004-12-03 Brian Warner <warner@lothar.com>
3727 * buildbot/master.py: clean up slave-handling code, to handle
3728 slave-disconnect and multiple-connect better
3729 (BotPerspective): make these long-lasting, exactly one per bot
3730 listed in the config file.
3731 (BotPerspective.attached): if a slave connects while an existing
3732 one appears to still be connected, disconnect the old one first.
3733 (BotPerspective.disconnect): new method to forcibly disconnect a
3734 buildslave. Use some hacks to empty the transmit buffer quickly to
3735 avoid the long (20-min?) TCP timeout that could occur if the old
3736 slave has dropped off the net.
3737 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
3738 own their own SlaveStatus objects. Remove .attached/.detached, add
3739 .addSlave/.removeSlave, treat slaves like Builders (config file
3740 parsing sends deltas to the BotMaster). Inform the slave
3741 instances, i.e. the BotPerspective, about addBuilder and
3743 (BotMaster.getPerspective): turns into a single dict lookup
3744 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
3745 which gives BotPerspective.attached a chance to disconnect the old
3747 (BuildMaster.loadConfig): add code (disabled) to validate that all
3748 builders use known slaves (listed in c['bots']). The check won't
3749 work with tuple-specified builders, which are deprecated but not
3750 yet invalid, so the check is disabled for now.
3751 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
3752 routine, do the add/changed/removed dance with them like we do
3754 (BuildMaster.loadConfig_Sources): move source-config into a
3755 separate routine too
3757 * buildbot/status/builder.py (Status.getSlave): get the
3758 SlaveStatus object from the BotPerspective, not the BotMaster.
3760 * buildbot/test/test_run.py: bunch of new tests for losing the
3761 buildslave at various points in the build, handling a slave that
3762 connects multiple times, and making sure we can interrupt a
3765 * buildbot/slave/bot.py (BuildSlave): make it possible to use
3766 something other than 'Bot' for the Bot object, to make certain
3767 test cases easier to write.
3768 (BuildSlave.waitUntilDisconnected): utility method for testing
3770 2004-11-30 Brian Warner <warner@lothar.com>
3772 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
3774 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
3775 argument, return a Deferred that always fires with True or False.
3776 I don't use an errback to indicate 'ping failed' so that callers
3777 are free to ignore the deferred without causing spurious errors in
3779 * buildbot/process/builder.py (BuilderControl.ping): implement it
3781 * buildbot/test/test_run.py (Status.testDisappear): test ping
3782 (Status.disappearSlave): fix it
3784 2004-11-30 Brian Warner <warner@lothar.com>
3786 * buildbot/interfaces.py (IBuildControl): add .stopBuild
3787 (IBuilderControl): add .getBuild(num), only works for the current
3788 build, of course, although it might be interesting to offer
3789 something for builds in the .waiting or .interlocked state.
3791 * buildbot/process/base.py (Build): have .stopBuild just do the
3792 interrupt, then let the build die by itself.
3793 (BuildControl): add .stopBuild, and add a point-event named
3794 'interrupt' just after the build so status viewers can tell that
3796 (BuilderControl): add .getBuild
3798 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
3799 stops when you kill it, good for testing
3800 (ShellCommand.interrupt): add a logfile named 'interrupt' which
3801 contains the 'reason' text.
3803 * buildbot/status/html.py: Add Stop Build button, if the build can
3804 still be stopped. Send a Redirect (to the top page) one second
3805 later, hopefully long enough for the interrupt to have an effect.
3806 Move make_row() up to top-level to share it between Stop Build and
3809 * buildbot/slave/commands.py: only kill the child process once
3811 * buildbot/test/test_run.py: add testInterrupt
3813 2004-11-29 Brian Warner <warner@lothar.com>
3815 * buildbot/process/base.py: Refactor command interruption. The
3816 Build is now responsible for noticing that the slave has gone
3817 away: Build.lostRemote() interrupts the current step and makes
3818 sure that no further ones will be started.
3820 * buildbot/process/builder.py: When the initial remote_startBuild
3821 message fails, log it: this usually indicates that the slave has
3822 gone away, but we don't really start paying attention until they
3823 fail to respond to the first step's command.
3825 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
3826 slave disconnect. Now sports a new interrupt() method. Error
3827 handling was simplified a lot by chaining deferreds, so
3828 remoteFailed/remoteComplete were merged into a single
3829 remoteComplete method (which can now get a Failure object).
3830 Likewise failed/finished were merged into just _finished.
3831 (BuildStep): Add interrupt(why) method, and if why is a
3832 ConnectionLost Failure then the step is failed with some useful
3835 * buildbot/slave/bot.py: stop the current command when the remote
3836 Step reference is lost, and when the slave is shut down.
3837 (Bot): make it a MultiService, so it can have children. Use
3838 stopService to tell when the slave is shutting down.
3839 (SlaveBuilder): make it a Service, and a child of the Bot. Add
3840 remote_interruptCommand (which asks the current SlaveCommand to
3841 stop but allows it to keep emitting status messages), and
3842 stopCommand (which tells it to shut up and die).
3844 * buildbot/slave/commands.py: make commands interruptible
3845 (ShellCommand.kill): factor out os.kill logic
3846 (Command): factor out setup()
3847 (Command.sendStatus): don't send status if .running is false, this
3848 happens when the command has been halted.
3849 (Command.interrupt): new method, used to tell the command to die
3850 (SlaveShellCommand): implement .interrupt
3851 (DummyCommand): implement .interrupt
3852 (SourceBase, etc): factor out setup(), don't continue substeps if
3855 * buildbot/status/builder.py: fix all waitUntilFinished() methods
3856 so they can be called after finishing
3858 * buildbot/test/test_run.py: new tests for disconnect behavior,
3859 refactor slave-shutdown routines, add different kinds of
3862 2004-11-27 Brian Warner <warner@lothar.com>
3864 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
3865 method to express ETA time like "2m45s" instead of "165 seconds"
3867 2004-11-24 Brian Warner <warner@lothar.com>
3869 * buildbot/test/test_vc.py (VC.testArch): unregister the test
3870 archive after the test completes, to avoid cluttering the user's
3871 'tla archives' listing with a bogus entry. Arch doesn't happen to
3872 provide any way to override the use of ~/.arch-params/, so there
3873 isn't a convenient way to avoid touching the setup of the user who
3875 (VC_HTTP.testArchHTTP): same
3877 2004-11-23 Brian Warner <warner@lothar.com>
3879 * buildbot/status/html.py (TextLog): split render() up into
3880 render_HEAD and render_GET. Use a Producer when sending log
3881 chunks, to reduce memory requirements and avoid sending huge
3882 non-Banana-able strings over web.distrib connections. Requires
3883 peeking under the covers of IStatusLog.
3884 (TextLog.resumeProducing): fix the "as text" link, handle client
3885 disconnects that occur while we're still sending old chunks.
3887 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
3888 use defer.succeed, not the non-existent defer.success
3889 (LogFile.waitUntilFinished): same
3890 (LogFile.subscribe): don't add watchers to a finished logfile
3892 * buildbot/__init__.py (version): bump to 0.6.1+ while between
3895 2004-11-23 Brian Warner <warner@lothar.com>
3897 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
3899 2004-11-23 Brian Warner <warner@lothar.com>
3901 * NEWS: update for the 0.6.1 release
3902 * MANIFEST.in: add new files
3904 * README (INSTALLATION): explain how to enable the extra VC tests
3906 * buildbot/status/builder.py (LogFile): add .runEntries at the class
3907 level to, so old pickled builds can be displayed ok
3909 2004-11-22 Brian Warner <warner@lothar.com>
3911 * NEWS: summarize updates since last release
3913 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
3914 Yoz Grahame. Closes SF#1050138.
3916 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
3919 * buildbot/process/step_twisted.py (Trial): update docs a bit
3921 * docs/factories.xhtml: fix Trial factory docs to match reality.
3924 * buildbot/process/factory.py (Trial.__init__): add args for
3925 randomly= and recurse=, making them available to instantiators
3926 instead of only to subclassers. Closes: SF#1049759.
3928 2004-11-15 Brian Warner <warner@lothar.com>
3930 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3931 try to teach the Quick factory to use multiple versions of python
3933 2004-11-12 Brian Warner <warner@lothar.com>
3935 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
3936 safer w32-compatible approach, and only use it on windows
3937 (BuildStatus.saveYourself): same
3939 2004-11-11 Brian Warner <warner@lothar.com>
3941 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
3942 it: one string merge per chunk. There are now separate .entries
3943 and .runEntries lists: when enumerating over all chunks, make sure
3945 * buildbot/test/test_status.py (Log): more tests
3947 * buildbot/status/builder.py (LogFile.addEntry): Merge string
3948 chunks together, up to 10kb per chunk. This ought to cut down on
3949 the CPU-burning overhead of large log files. Thanks to Alexander
3950 Staubo for spotting the problem.
3951 * buildbot/test/test_status.py (Log): tests for same
3953 2004-11-10 Brian Warner <warner@lothar.com>
3955 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
3956 header to outbound mail
3957 * buildbot/test/test_status.py (Mail.testBuild1): test for same
3959 2004-11-08 Brian Warner <warner@lothar.com>
3961 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
3962 can't do os.rename() onto an existing file, so catch the exception
3963 and unlink the target file first. This introduces a slight window
3964 where the existing file could be lost, but the main failure case
3965 (disk full) should still be handled safely.
3966 (BuildStatus.saveYourself): same
3968 * buildbot/changes/pb.py (ChangePerspective): use a configurable
3969 separator character instead of os.sep, because the filenames being
3970 split here are coming from the VC system, which can have a
3971 different pathname convention than the local host. This should
3972 help a buildmaster running on windows that uses a CVS repository
3973 which runs under unix.
3974 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
3976 * buildbot/process/step_twisted.py (Trial.createSummary): survive
3977 when there are no test failures to be parsed
3979 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
3980 instead of the unix-specific os.system("cp"), thanks to Elliot
3981 Murphy for this and the other buildbot-vs-windows catches.
3982 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
3984 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
3985 echo the command as it is run
3987 * setup.py: install sample.mk too, not just sample.cfg
3988 (scripts): install contrib/windows/buildbot.bat on windows
3990 2004-11-07 Brian Warner <warner@lothar.com>
3992 * buildbot/process/builder.py (Builder._detached): clear the
3993 self.currentBuild reference, otherwise the next build will be
3994 skipped because we think the Builder is already in use.
3996 * docs/examples/twisted_master.cfg: update to match current usage
3997 on the Twisted buildbot
3999 2004-10-29 Brian Warner <warner@lothar.com>
4001 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4003 2004-10-28 Brian Warner <warner@lothar.com>
4005 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4006 have separate doVCUpdate/doVCFull methods. Catch an update failure
4007 and respond by clobbering the source directory and re-trying. This
4008 will handle local changes (like replacing a file with a directory)
4009 that will cause CVS and SVN updates to fail.
4010 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4012 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4015 2004-10-19 Brian Warner <warner@lothar.com>
4017 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4019 * buildbot/status/html.py (StatusResourceTestResults): display any
4020 TestResults that the Build might have
4021 (StatusResourceTestResult): and the logs for each TestResult
4022 (StatusResourceBuild): add link from the per-build page
4024 2004-10-15 Brian Warner <warner@lothar.com>
4026 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4027 the 'problems' portion of stdout, add TestResults to our build
4028 * buildbot/test/test_twisted.py (Parse.testParse): test it
4030 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4031 to retrieve a dict of accumulated test results
4032 (ITestResult): define what a single test result can do
4033 * buildbot/status/builder.py (TestResult): implement ITestResult
4034 (BuildStatus.getTestResults): retrieve dict of TestResults
4035 (BuildStatus.addTestResult): add TestResults
4036 * buildbot/test/test_status.py (Results.testAddResults): test it
4038 2004-10-14 Brian Warner <warner@lothar.com>
4040 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4041 instead of os.system("rm -rf") for win32 portability
4043 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4044 SignalMixin instead of starting/stopping the reactor, which is
4045 likely to cause problems with other tests
4047 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4048 self.copyComplete() call. Yoz Grahame makes the catch.
4050 * contrib/windows/buildbot.bat: helper script to deal with path
4051 issues. Thanks to Yoz Grahame.
4053 * buildbot/master.py (BuildMaster.startService): don't register a
4054 SIGHUP handler if the signal module has no SIGHUP attribute.
4055 Apparently win32 does this.
4057 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4059 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4060 test if the reactor can't offer UNIX sockets
4062 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4063 error introduced in the last commit. We really need that
4066 2004-10-12 Brian Warner <warner@lothar.com>
4068 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4069 when describing a maildir source. Thanks to Stephen Davis.
4071 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4074 * buildbot/scripts/runner.py (createMaster): install Makefile too
4075 (start): add --no_save to 'start' command
4076 * buildbot/scripts/sample.mk: simple convenience Makefile with
4077 start/stop/reload targets
4079 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4082 2004-09-30 Brian Warner <warner@lothar.com>
4084 * setup.py: Releasing buildbot-0.6.0
4086 2004-09-30 Brian Warner <warner@lothar.com>
4088 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4089 test_trial.py from the source tarball until support is complete.
4091 * NEWS: update for 0.6.0 release
4092 * buildbot/__init__.py (version): same
4095 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4096 'source' command to tell users where to get the Buildbot source
4098 * docs/examples/*.cfg: update to modern standards
4100 * NEWS: update for release
4102 * buildbot/scripts/runner.py (createMaster): remove the
4103 -shutdown.tap stuff now that it isn't necessary
4105 (start): launch buildbot.tap, not buildbot-shutdown.tap
4108 * buildbot/status/mail.py (Domain): shorten class name
4109 (MailNotifier): if lookup= is a string, pass it to Domain()
4110 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4111 (Mail.testBuild2): test the string-to-Domain shortcut
4112 (Mail.testMail): fix test
4115 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4118 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4119 more attributes on load
4120 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4121 to accomodate the whole waterfall page at once, and the thrashing
4122 results in a lot of unnecessary loads
4123 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4124 (BuilderStatus.saveYourself): same
4125 (BuilderStatus.eventGenerator): stop generating on the first missing
4126 build. We assume that saved builds are deleted oldest-first.
4127 (BuildStepStatus.__getstate__): .progress might not exist
4129 * buildbot/changes/changes.py (ChangeMaster): make it
4130 serializable, in $masterdir/changes.pck
4131 (ChangeMaster.stopService): save on shutdown
4132 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4133 * buildbot/test/test_config.py: load Changes before config file
4136 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4137 "Oh my god, you killed the command" header on a separate line
4139 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4140 skip over corrupted build pickles
4141 (BuilderStatus.getFullBuildByNumber): same
4142 (BuilderStatus.eventGenerator): skip over unavailable builds
4143 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4144 do an atomic rename. This prevents a corrupted pickle when some
4145 internal serialization error occurs.
4146 (BuilderStatus.saveYourself): same
4148 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4149 the timeout for shell commands, it got lost somehow
4151 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4152 run out of build steps, return the rest of the builder events
4154 * buildbot/interfaces.py (IBuilderControl.ping): add method
4156 * buildbot/process/builder.py (BuilderControl.ping): move
4157 slave-ping to BuilderControl, and fix the failure case in the
4158 process (Event.finish() is the verb, Event.finished is the noun).
4160 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4161 through the BuilderControl instead of the BuilderStatus
4162 (EventBox): add adapter for builder.Event, allowing builder events to
4163 be displayed in the waterfall display
4165 * buildbot/master.py (BotMaster.stopService): add a 'master
4166 shutdown' event to the builder's log
4167 (BuildMaster.startService): and a 'master started' on startup
4169 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4170 builder events into the BuildStep event stream
4171 (Status.builderAdded): add a 'builder created' event
4174 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4175 command to announce the completion of a running build
4176 (IrcStatusBot.command_FORCE): announce when the build finishes
4178 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4179 don't evict unfinished builds from the cache: they must stay in
4180 the full-cache until their logfiles have stopped changing. Make
4181 sure the eviction loop terminates if an unfinished build was hit.
4182 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4183 This lets exceptions be dumped in an email status message. Really
4184 we need LogFiles which contain both text and HTML, instead of two
4186 (BuildStatus.__getstate__): handle self.finished=False
4187 (Status.builderAdded): if the pickle is corrupted, abandon the
4188 history and create a new BuilderStatus object.
4190 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4191 self.progress attribute, helped one test which doesn't fully set
4192 up the Build object.
4194 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4195 IStatusLog methods into an Interface that is implemented by "stub"
4196 logs, for which all the actual text chunks are on disk (in the
4197 pickled Build instance). To show the log contents, you must first
4198 adapt the stub log to a full IStatusLog object.
4200 * buildbot/status/builder.py (LogFileStub): create separate stub
4201 log objects, which can be upgraded to a real one if necessary.
4202 (LogFile): make them persistable, and let them stubify themselves
4204 (BuildStepStatus): same
4206 (BuildStatus.saveYourself): save the whole build out to disk
4207 (BuilderStatus): make it persistable
4208 (BuilderStatus.saveYourself): save the builder to disk
4209 (BuilderStatus.addFullBuildToCache): implement two caches which
4210 hold Build objects: a small one which holds full Builds, and a
4211 larger one which holds "stubbed" Builds (ones with their LogFiles
4212 turned into LogFileStubs). This reduces memory usage by the
4213 buildmaster by not keeping more than a few (default is 2) whole
4214 build logs in RAM all the time.
4215 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4217 (BuilderStatus.eventGenerator): rewrite since .builds went away
4218 (BuilderStatus.buildStarted): remove the .builds array. Add the
4219 build to the "full" cache when it starts.
4220 (BuilderStatus._buildFinished): save the build to disk when it
4222 (Status): give it a basedir (same as the BuildMaster's basedir)
4223 where the builder pickles can be saved
4224 (Status.builderAdded): create the BuilderStatus ourselves, by
4225 loading a pickle from disk (or creating a new instance if there
4226 was none on disk). Return the BuilderStatus so the master can glue
4227 it into the new Builder object.
4229 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4230 all BuilderStatuses to save themselves out to disk. This is in
4231 lieu of saving anything important in the main Application pickle
4232 (the -shutdown.tap file).
4233 (BuildMaster.__init__): give Status() a basedir for its files
4234 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4235 to get the BuilderStatus, then give it to the Builder (instead of
4236 doing it the other way around). It's ok if the status announces
4237 the new Builder before it's really ready, as the outside world can
4238 only see the BuilderStatus object anyway (and it is ready before
4239 builderAdded returns). Use the builder's "builddir" (which
4240 normally specifies where the slave will run the builder) as the
4241 master's basedir (for saving serialized builds).
4243 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4244 coerce the logfile to IStatusLog before trying to get the text
4245 chunks out of it. This will pull the full (non-stubified) Build in
4246 from disk if necessary.
4247 (TextLog): fix the adapter registration
4249 * buildbot/test/test_control.py (Force.setUp): create the basedir
4250 * buildbot/test/test_web.py: same
4251 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4252 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4253 * buildbot/test/test_run.py (Run.testMaster): same
4254 (Status.setUp): same
4256 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4258 * buildbot/status/html.py (Waterfall.__init__): store actual
4259 allowForce flag passed in rather than using True for everyone;
4260 make sure setting it to False doesn't cause a NameError
4262 (StatusResourceBuilder.__init__) add the builder name to the page
4264 (StatusResourceBuilder.body) move HTML generation for a name/value
4265 row into a helper method (StatusResourceBuilder.make_row); only
4266 generate the "Force Build" form if allowForce was True and the
4267 slave is connected. Use class attributes in the generated HTML to
4268 spread a little CSS-joy.
4270 2004-09-28 Brian Warner <warner@lothar.com>
4272 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4273 warning-scanner to not ignore things like
4274 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4276 * buildbot/status/html.py (StatusResource.control): add some
4277 class-level values for .control in an attempt to make upgrading
4280 * buildbot/util.py (ComparableMixin): survive missing attributes,
4281 such as when a class is modified and we're comparing old instances
4284 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4285 failure handling, remove a redundant try/except block. Don't
4286 return the full traceback to the IRC channel.
4287 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4288 error messages. Get ETA properly.
4290 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4291 the reason, since (at least) IRC message will have <> in them.
4292 (StatusResourceBuilder.__init__): take an IBuilderControl
4293 (StatusResourceBuilder.force): use the IBuilderControl we get in
4294 the constructor instead of trying to make our own. Catch the
4295 new exceptions and ignore them for now (until we make an
4296 intermediate web page where we could show the error message)
4297 (StatusResource): create with an IControl, use it to give an
4298 IBuilderControl to all children
4299 (Waterfall): take an allowForce= option, pass an IControl object
4300 to StatusResource if it is True
4302 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4304 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4305 catch new exceptions and return string forms
4307 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4308 * buildbot/process/builder.py (Builder.forceBuild): raise them
4309 * buildbot/test/test_control.py (Force.testNoSlave): new test
4310 (Force.testBuilderInUse): same
4313 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4315 * buildbot/test/test_run.py: use IControl
4316 * buildbot/test/test_vc.py: same
4318 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4319 to use IControl. Still offline.
4320 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4322 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4323 who=None so periodic builds don't send out status mail
4324 (Builder.forceBuild): include reason in the log message
4325 (BuilderControl.forceBuild): rename 'name' to 'who'
4327 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4328 'who' parameter, but make it None by default so builds forced by
4329 slave admins don't cause status mail to be sent to anybody
4330 (BotMaster.forceBuild): same. this method is deprecated.
4331 (DebugPerspective.perspective_forceBuild): same, use IControl.
4332 (DebugPerspective.perspective_fakeChange): use IControl..
4333 (Dispatcher.requestAvatar): .. so don't set .changemaster
4335 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4336 parameter to avoid confusion with the name of the builder
4339 * buildbot/status/mail.py: refine comment about needing 2.3
4341 * buildbot/status/html.py: move all imports to the top
4343 * buildbot/test/test_control.py: test new interfaces
4344 * buildbot/test/test_run.py (Status): handle new interfaces
4345 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4347 * buildbot/process/base.py (BuildControl): implement IBuildControl
4348 and its lonely getStatus() method
4350 * buildbot/process/builder.py (BuilderControl): implement
4351 IBuilderControl, obtained by adapting the Builder instance
4352 (Builder.startBuild): return a BuilderControl instead of a
4353 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4354 accomplish the same thing.
4356 * buildbot/master.py: move all import statements to the top
4357 (Control): implement IControl, obtained by adapting the
4358 BuildMaster instance.
4360 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4361 IBuildControl. These are used to force builds. Eventually they
4362 will provide ways to reconfigure the Builders, pause or abandon a
4363 Build, and perhaps control the BuildMaster itself.
4365 2004-09-26 Brian Warner <warner@lothar.com>
4367 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4368 ends up comparing us against something without a .__class__
4370 2004-09-24 Brian Warner <warner@lothar.com>
4372 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4375 * Makefile: add 'deb-snapshot' target, to create a timestamped
4378 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4380 2004-09-23 Brian Warner <warner@lothar.com>
4382 * buildbot/__init__.py (version): move version string here
4383 * setup.py: get version string from buildbot.version
4384 * buildbot/status/html.py (WaterfallStatusResource.body): add
4385 buildbot version to the page footer
4386 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4389 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4390 slaves, let the second know where the first one is coming from
4391 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4392 see our exceptions. It would be nice if there were a way to just
4393 send them the exception type and value, not the full traceback.
4396 * buildbot/status/mail.py (MailNotifier): add a new argument
4397 sendToInterestedUsers=, which can be set to False to disable the
4398 usual send-to-blamelist behavior.
4399 (top): handle python-2.2 which has no email.MIMEMultipart
4400 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4401 (MailNotifier.disownServiceParent): unsubscribe on removal
4403 * buildbot/test/test_status.py (Mail.testBuild2): test it
4406 * buildbot/status/progress.py (Expectations.wavg): tolerate
4407 current=None, which happens when steps start failing badly
4408 * buildbot/test/test_status.py (Progress.testWavg): test for it
4410 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4411 doesn't understand args['revision'], emit a warning instead of
4412 bailing completely. Updating to -rHEAD is probably close enough.
4414 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4416 * buildbot/test/test_status.py: at least import bb.status.client
4417 even if we don't have any test coverage for it yet
4419 * contrib/svn_buildbot.py: don't require python2.3
4420 (main): wait, do require it (for sets.py), but explain how to
4421 make it work under python2.2
4423 2004-09-23 Brian Warner <warner@lothar.com>
4425 * contrib/svn_buildbot.py: include the revision number in the Change
4427 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4428 using util.now() because FreshCVS is a realtime service
4430 * buildbot/status/event.py: delete dead code
4431 * buildbot/process/step.py: don't import dead Event class
4432 * buildbot/process/step_twisted.py: same
4433 * buildbot/status/builder.py: same
4434 * buildbot/status/client.py: same
4436 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4438 * buildbot/changes/changes.py (Change): set .when from an __init__
4439 argument (which defaults to now()), rather than having
4440 ChangeMaster.addChange set it later.
4441 (ChangeMaster.addChange): same
4443 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4444 (parseSyncmail): same. Just use util.now() for now.
4445 (parseBonsaiMail): parse the timestamp field for when=
4447 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4448 instead of setting .when after the fact
4452 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4453 results when the target project uses retrial. Still under
4455 * buildbot/test/test_trial.py: same
4457 2004-09-21 Brian Warner <warner@lothar.com>
4459 * buildbot/status/mail.py (MailNotifier.__init__): include
4460 success/warnings/failure in the Subject line
4461 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4462 use step.logname for the addLogs=True attachment filenames
4463 * buildbot/test/test_status.py (Mail): test Subject lines
4464 (Mail.testLogs): test attachment filenames
4466 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4467 accept a 'who' argument from the debug tool
4468 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4469 * contrib/debug.glade: add text box to set 'who'
4471 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4472 .getBuilderName with .getBuilder().getName(), more flexible
4473 (IStatusLog.getName): logs have short names, but you can prefix
4474 them with log.getStep().getName() to make them more useful
4475 * buildbot/status/builder.py: same
4476 * buildbot/status/client.py: same
4477 * buildbot/status/html.py: same
4478 * buildbot/test/test_run.py (Status.testSlave): same
4479 * buildbot/process/step.py: tweak logfile names
4481 * buildbot/status/mail.py (MailNotifier): add lookup, change
4482 argument to extraRecipients. The notifier is now aimed at sending
4483 mail to the people involved in a particular build, with additional
4484 constant recipients as a secondary function.
4486 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4487 including slow-lookup and failing-lookup. Make sure the blamelist
4488 members are included.
4490 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4491 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4492 (IBuildStatus.getInterestedUsers): new method
4493 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4494 * buildbot/status/client.py (remote_getResponsibleUsers): same
4495 * buildbot/status/html.py (StatusResourceBuild.body): same
4496 * buildbot/test/test_run.py (Status.testSlave): same
4498 2004-09-20 Brian Warner <warner@lothar.com>
4500 * docs/users.xhtml: update concepts
4502 * Makefile: add a convenience makefile, for things like 'make
4503 test'. It is not included in the source tarball.
4505 2004-09-16 Brian Warner <warner@lothar.com>
4507 * NEWS: mention /usr/bin/buildbot, debian/*
4509 * debian/*: add preliminary debian packaging. Many thanks to
4510 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4511 it considerably since it left their hands, I am responsible for
4512 all breakage that's resulted.
4514 * bin/buildbot: create a top-level 'buildbot' command, to be
4515 installed in /usr/bin/buildbot . For now it's just a simple
4516 frontend to mktap/twistd/kill, but eventually it will be the entry
4517 point to the 'try' command and also a status client. It is also
4518 intended to support the upcoming debian-packaging init.d scripts.
4519 * buildbot/scripts/runner.py: the real work is done here
4520 * buildbot/scripts/__init__.py: need this too
4521 * buildbot/scripts/sample.cfg: this is installed in new
4522 buildmaster directories
4523 * setup.py: install new stuff
4525 2004-09-15 Brian Warner <warner@lothar.com>
4527 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4528 'file:' schema (the version shipped with OS-X was built without the
4530 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4531 updates the log-timestamp, to make sure it isn't still running after
4534 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4535 values to the config file.
4536 * docs/examples/hello.cfg: add examples
4537 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4538 * buildbot/status/builder.py (Status.getProjectURL): implement them
4539 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4540 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
4541 * buildbot/status/html.py (WaterfallStatusResource): display them
4544 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
4545 certain error cases don't suffer a secondary exception.
4546 (top): Skip tests if the corresponding VC tool is not installed.
4548 * buildbot/process/factory.py (Trial): introduce separate
4549 'buildpython' and 'trialpython' lists, since trialpython=[] is
4550 what you want to invoke /usr/bin/python, whereas ./setup.py is
4551 less likely to be executable. Add env= parameter to pass options
4552 to test cases (which is how I usually write tests, I don't know if
4553 anyone else does it this way).
4555 * buildbot/process/step_twisted.py (Trial): handle python=None.
4556 Require 'testpath' be a string, not a list. Fix tests= typo.
4557 (Trial.start): sanity-check any PYTHONPATH value for stringness.
4559 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
4560 way to deal with the possibility of removing the disconnect notify
4562 (CVS): add a 'login' parameter to give a password to 'cvs login',
4563 commonly used with pserver methods (where pw="" or pw="guest")
4565 * buildbot/slave/commands.py (SourceBase): move common args
4566 extraction and setup() to __init__, so everything is ready by the
4567 time setup() is called
4568 (CVS.start): call 'cvs login' if a password was supplied
4569 (ShellCommand): special-case PYTHONPATH: prepend the master's
4570 value to any existing slave-local value.
4572 * buildbot/process/builder.py (Builder.updateBigStatus): if we
4573 don't have a remote, mark the builder as Offline. This whole
4574 function should probably go away and be replaced by individual
4576 (Builder.buildFinished): return the results to the build-finished
4577 deferred callback, helps with testing
4579 2004-09-14 Brian Warner <warner@lothar.com>
4581 * buildbot/test/test_vc.py: put all the repositories needed to run
4582 the complete tests into a single small (1.3MB) tarball, so I can
4583 make that tarball available on the buildbot web site. Test HTTP
4584 access (for Arch and Darcs) by spawning a temporary web server
4585 while the test runs.
4587 * docs/users.xhtml: new document, describe Buildbot's limited
4588 understanding of different human users
4590 * buildbot/test/test_vc.py: rearrange test cases a bit
4592 * buildbot/process/step_twisted.py (Trial): handle testpath=
4593 * buildbot/process/factory.py (Trial): update to use step.Trial
4595 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
4597 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
4598 the overall build text (which gives you 'failed 2 tests' rather
4600 (BuildStepStatus.text2): default to [], not None
4602 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
4605 2004-09-12 Brian Warner <warner@lothar.com>
4607 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
4608 log the whole exception if it's just an AttributeError (old slave)
4610 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
4611 so (e.g.) sub-commands can be run in the right directory.
4612 (ShellCommand.start): accept an optional errorMessage= argument
4613 to make life easier for SVN.start
4614 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
4616 (ShellCommand.start): move ['dir'] compatibility hack..
4617 (RemoteShellCommand.start): .. to here so everyone can use it
4619 * buildbot/process/step_twisted.py (Trial): use .workdir
4621 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
4622 text displayed when debuild fails completely
4623 (Trial): snarf _trial_temp/test.log from the slave and display it
4625 2004-09-11 Brian Warner <warner@lothar.com>
4627 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
4629 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
4630 set to 'twisted', so --recurse can find twisted/web/test/*, etc
4632 * buildbot/process/step.py (ShellCommand): call .createSummary
4633 before .evaluateCommand instead of the other way around. This
4634 makes it slightly easier to count warnings and then use that to
4635 set results=WARNINGS
4636 * buildbot/process/step_twisted.py: cosmetic, swap the methods
4638 * buildbot/process/base.py (Build.buildFinished): update status
4639 before doing progress. It's embarrassing for the build to be stuck
4640 in the "building" state when an exceptions occurs elsewhere..
4642 * buildbot/status/progress.py (Expectations.expectedBuildTime):
4643 python2.2 doesn't have 'sum'
4645 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
4646 to prevent clients from accidentally sorting it
4648 * buildbot/master.py (Manhole): add username/password
4649 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
4650 c['manholePort'], deprecate old usage
4651 * docs/config.xhtml: document c['manhole']
4652 * docs/examples/hello.cfg: show example of using a Manhole
4655 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
4656 pretend the slave is up to date
4658 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
4659 the module, overlaps with 'log', the local variable
4661 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
4663 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
4664 new method to let Steps find out the version of their
4665 corresponding SlaveCommand.
4666 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
4667 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
4668 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
4670 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
4671 (Arch.startVC): same
4672 (P4Sync.startVC): same
4674 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
4675 Deferred so we can catch errors in remote_startCommand
4676 (RemoteShellCommand.start): same
4678 * docs/examples/twisted_master.cfg: update sample config file
4680 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
4681 after connectionMade() is called, not before. Close stdin at that
4684 * buildbot/process/process_twisted.py: update to use Trial, clean
4685 up argument passing (move to argv arrays instead of string
4688 * buildbot/process/step_twisted.py (Trial): new step to replace
4689 RunUnitTests, usable by any trial-using project (not just
4690 Twisted). Arguments have changed, see the docstring for details.
4692 * buildbot/process/base.py (Build.startBuild): this now returns a
4693 Deferred. Exceptions that occur during setupBuild are now
4694 caught better and lead to fewer build_status weirdnesses, like
4695 finishing a build that was never started.
4696 (Build.buildFinished): fire the Deferred instead of calling
4697 builder.buildFinished directly. The callback argument is this
4698 Build, everything else can be extracted from it, including the
4699 new build.results attribute.
4700 * buildbot/process/builder.py (Builder.startBuild): same
4701 (Builder.buildFinished): same, extract results from build
4703 * buildbot/process/step.py (ShellCommands): remove dead code
4705 2004-09-08 Brian Warner <warner@lothar.com>
4707 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
4708 doesn't try to use the leftover patched workdir
4709 (SourceStamp): test source-stamp computation for CVS and SVN
4711 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
4712 patched workdir ('touch .buildbot-patched') so we don't try to
4714 (SourceBase.start): add ['revision'] for all Source steps
4715 (CVS): change args: use ['branch'] for -r, remove ['files']
4716 (CVS.buildVC): fix revision/branch stuff
4717 (SVN): add revision stuff
4719 * buildbot/process/step.py (BuildStep.__init__): reject unknown
4720 kwargs (except 'workdir') to avoid silent spelling errors
4721 (ShellCommand.__init__): same
4722 (Source): new base class for CVS/SVN/etc. Factor out everything
4723 common, add revision computation (perform the checkout with a -D
4724 DATE or -r REVISION that gets exactly the sources described by the
4725 last Change), overridable with step.alwaysUseLatest. Add patch
4726 handling (build.getSourceStamp can trigger the use of a base
4727 revision and a patch).
4728 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
4729 * docs/steps.xhtml: update docs
4730 * docs/source.xhtml: mention .checkoutDelay
4731 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
4733 * buildbot/process/base.py (Build.setSourceStamp): add a
4734 .sourceStamp attribute to each Build. If set, this indicates that
4735 the build should be done with something other than the most
4736 recent source tree. This will be used to implement "try" builds.
4737 (Build.allChanges): new support method
4738 (Build.lastChangeTime): remove, functionality moved to Source steps
4739 (Build.setupBuild): copy the Step args before adding ['workdir'],
4740 to avoid modifying the BuildFactory (and thus triggering spurious
4744 * buildbot/status/html.py: rename s/commits/changes/
4745 (StatusResourceChanges): same
4746 (CommitBox.getBox): same, update URL
4747 (WaterfallStatusResource): same
4748 (StatusResource.getChild): same
4750 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
4751 * contrib/debug.glade: add optional 'revision' to the fakeChange
4753 * buildbot/changes/changes.py (html_tmpl): display .revision
4754 (ChangeMaster.addChange): note .revision in log
4755 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
4756 accept a ['revision'] attribute
4758 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
4760 * buildbot/master.py (BotMaster.getPerspective): update the
4761 .connected flag in SlaveStatus when it connects
4762 (BotMaster.detach): and when it disconnects
4763 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
4764 (BuildMaster.loadConfig_Builders): walk old list correctly
4766 * buildbot/test/test_config.py: fix prefix= usage
4768 2004-09-06 Brian Warner <warner@lothar.com>
4772 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
4773 poll a P4 depot looking for recent changes. Thanks to Dave
4774 Peticolas for the contribution. Probably needs some testing after
4777 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
4778 requires manual client setup for each buildslave. Rather
4779 experimental. Thanks again to Dave Peticolas.
4780 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
4782 * buildbot/changes/changes.py (Change): add a .revision attribute,
4783 which will eventually be used to generate source-stamp values.
4785 * buildbot/process/step.py (RemoteCommand.start): use
4786 notifyOnDisconnect to notice when we lose the slave, then treat it
4787 like an exception. This allows LogFiles to be closed and the build
4788 to be wrapped up normally. Be sure to remove the disconnect
4789 notification when the step completes so we don't accumulate a
4790 bazillion such notifications which will fire weeks later (when the
4791 slave finally disconnects normally). Fixes SF#915807, thanks to
4792 spiv (Andrew Bennetts) for the report.
4793 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
4794 really isn't Logged- specific
4795 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
4796 header, since it's almost always going to be appended to an
4798 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
4799 update test to handle use of notifyOnDisconnect
4801 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
4802 don't clear .ETA and .currentBuild when going offline, let the
4803 current build clean up after itself
4805 * buildbot/process/builder.py (Builder.detached): wait a moment
4806 before doing things like stopping the current build, because the
4807 current step will probably notice the disconnect and cleanup the
4809 * buildbot/test/test_run.py (Status.tearDown): update test to
4810 handle asynchronous build-detachment
4812 * buildbot/process/base.py (Build.stopBuild): minor shuffles
4814 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
4815 hush a debug message
4817 2004-09-05 Brian Warner <warner@lothar.com>
4819 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
4820 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
4821 kernels do this: the fcntl module has the F_NOTIFY constant, but
4822 the kernel itself doesn't support the operation. Thanks to Olly
4823 Betts for spotting the problem.
4825 * buildbot/process/step.py (Darcs): new source-checkout command
4826 (Arch): new source-checkout command
4827 (todo_P4): fix constructor syntax, still just a placeholder
4828 * buildbot/test/test_vc.py (VC.testDarcs): test it
4829 (VC.testDarcsHTTP): same, via localhost HTTP
4831 (VC.testArchHTTP): same
4832 * NEWS: mention new features
4834 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
4835 which tells the step to stash stdout text locally (in .stdout).
4836 Slave-side Commands can use this to make decisions based upon the
4837 output of the the ShellCommand (not just the exit code).
4838 (Darcs): New source-checkout command
4839 (Arch): New source-checkout command, uses .keepStdout in one place
4840 where it needs to discover the archive's default name.
4842 * docs/steps.xhtml: Document options taken by Darcs and Arch.
4843 * docs/source.xhtml: add brief descriptions of Darcs and Arch
4844 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
4846 * buildbot/process/step.py (ShellCommand.describe): add an
4847 alternate .descriptionDone attribute which provides descriptive
4848 text when the step is complete. .description can be ["compiling"],
4849 for use while the step is running, then .descriptionDone can be
4850 ["compile"], used alone when the step succeeds or with "failed" when
4851 it does not. Updated other steps to use the new text.
4852 * buildbot/process/step_twisted.py: same
4853 * buildbot/test/test_run.py: update tests to match
4855 2004-08-30 Brian Warner <warner@lothar.com>
4857 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
4858 (CVS.__init__): send 'patch' argument to slave
4859 (CVS.start): don't create the LoggedRemoteCommand until start(),
4860 so we can catch a .patch added after __init__
4861 (SVN.__init__): add 'patch' to SVN too
4864 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
4865 argument, to let commands push data into the process' stdin pipe.
4866 Move usePTY to a per-instance attribute, and clear it if 'stdin'
4867 is in use, since closing a PTY doesn't really affect the process
4868 in the right way (in particular, I couldn't run /usr/bin/patch
4870 (SourceBase.doPatch): handle 'patch' argument
4872 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
4875 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
4876 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
4878 * buildbot/master.py (BotPerspective.got_commands): get command
4879 versions from slave, give to each builder
4880 * buildbot/process/builder.py (Builder.attached): stash slave
4881 command versions in .remoteCommands
4883 * docs/steps.xhtml: bring docs in-line with reality
4885 * buildbot/process/step.py (CVS.__init__): more brutal
4886 compatibility code removal
4887 (SVN.__init__): same
4889 * buildbot/slave/commands.py (SlaveShellCommand): update docs
4890 (SlaveShellCommand.start): require ['workdir'] argument, remove
4891 the ['dir'] fallback (compatibility will come later)
4892 (SourceBase): update docs
4893 (SourceBase.start): remove ['directory'] fallback
4896 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
4897 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
4898 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
4900 * buildbot/process/step.py (RemoteShellCommand.__init__): add
4901 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
4902 code.. I will figure out 0.5.0-compatibility hooks later)
4904 2004-08-30 Brian Warner <warner@lothar.com>
4906 * buildbot/process/process_twisted.py: rewrite in terms of new
4907 BuildFactory base class. It got significantly shorter. Yay
4910 * buildbot/process/step_twisted.py (HLint.start): fix to make it
4911 work with the new "self.build isn't nailed down until we call
4912 step.start()" scheme: specifically, __init__ is called before the
4913 build has decided on which Changes are going in, so we don't scan
4914 build.allFiles() for .xhtml files until start()
4915 (HLint.commandComplete): use getText(), not getStdout()
4916 (RunUnitTests.start): same: don't use .build until start()
4917 (RunUnitTests.describe): oops, don't report (None) when using
4919 (RunUnitTests.commandComplete): use getText()
4920 (RunUnitTests.createSummary): same
4921 (BuildDebs.commandComplete): same
4923 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
4924 set args['command'] until start(), since our BuildStep is allowed
4925 to change their mind up until that point
4926 (TreeSize.commandComplete): use getText(), not getStdout()
4928 * docs/examples/twisted_master.cfg: update to current standards
4930 * docs/factories.xhtml: update
4931 * buildbot/process/factory.py: implement all the common factories
4932 described in the docs. The Trial factory doesn't work yet, and
4933 I've probably broken all the process_twisted.py factories in the
4934 process. There are compatibility classes left in for things like
4935 the old BasicBuildFactory, but subclasses of them are unlikely to
4937 * docs/examples/glib_master.cfg: use new BuildFactories
4938 * docs/examples/hello.cfg: same
4940 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
4941 explicit 'workdir' args
4943 * buildbot/process/base.py (BuildFactory): move factories to ..
4944 * buildbot/process/factory.py (BuildFactory): .. here
4945 * buildbot/process/process_twisted.py: handle move
4946 * buildbot/test/test_config.py: same
4947 * buildbot/test/test_run.py: same
4948 * buildbot/test/test_steps.py: same
4949 * buildbot/test/test_vc.py: same
4950 * docs/factories.xhtml: same
4952 * NEWS: mention config changes that require updating master.cfg
4954 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
4955 argument to all steps that weren't given one already, pointing at
4956 the "build/" directory.
4958 * docs/examples/hello.cfg: remove explicit 'workdir' args
4960 * docs/factories.xhtml: document standard BuildFactory clases,
4961 including a bunch which are have not yet been written
4963 2004-08-29 Brian Warner <warner@lothar.com>
4965 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
4966 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
4967 buildbot.status.builder so they aren't quite so internal
4968 * buildbot/process/base.py, buildbot/process/builder.py: same
4969 * buildbot/process/maxq.py, buildbot/process/step.py: same
4970 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
4971 * buildbot/status/mail.py, buildbot/test/test_run.py: same
4972 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
4974 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
4975 to handle new getLogs()-returns-list behavior
4976 (StatusResourceBuildStep.getChild): same
4977 (StepBox.getBox): same
4978 (WaterfallStatusResource.phase0): same
4980 * docs/source.xhtml: document how Buildbot uses version-control
4981 systems (output side: how we get source trees)
4982 * docs/changes.xhtml: rename from sources.xhtml, documents VC
4983 systems (input side: how we learn about Changes)
4985 * buildbot/master.py (Manhole): use ComparableMixin
4986 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
4987 * buildbot/changes/mail.py (MaildirSource): same
4988 * buildbot/status/client.py (PBListener): same
4989 * buildbot/status/html.py (Waterfall): same
4990 * buildbot/status/words.py (IRC): same
4992 * NEWS: start describing new features
4994 * buildbot/status/mail.py (MailNotifier): finish implementation.
4995 The message body is still a bit sparse.
4996 * buildbot/test/test_status.py (Mail): test it
4998 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
4999 and __hash__ methods I wind up adding everywhere. Specifically
5000 intended to support the buildbot config-file update scheme where
5001 we compare, say, the old list of IStatusTargets against the new
5002 one and don't touch something which shows up on both lists.
5003 * buildbot/test/test_util.py (Compare): test case for it
5005 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5006 return a list instead of a dict
5007 (IBuildStepStatus.getLogs): same. The idea is that steps create
5008 logs with vaguely unique names (although their uniqueness is not
5009 guaranteed). Thus a compilation step should create its sole
5010 logfile with the name 'compile', and contribute it to the
5011 BuildStatus. If a step has two logfiles, try to create them with
5012 different names (like 'test.log' and 'test.summary'), and only
5013 contribute the important ones to the overall BuildStatus.
5014 * buildbot/status/builder.py (Event.getLogs): same
5015 (BuildStepStatus): fix default .text and .results
5016 (BuildStepStatus.addLog): switch to list-like .getLogs()
5017 (BuildStepStatus.stepFinished): same
5018 (BuildStatus.text): fix default .text
5019 (BuildStatus.getLogs): temporary hack to return all logs (from all
5020 child BuildStepStatus objects). Needs to be fixed to only report
5021 the significant ones (as contributed by the steps themselves)
5022 * buildbot/test/test_run.py: handle list-like .getLogs()
5023 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5025 2004-08-28 Brian Warner <warner@lothar.com>
5027 * buildbot/process/builder.py (Builder.attached): serialize the
5028 attachment process, so the attach-watcher isn't called until the
5029 slave is really available. Add detached watchers too, which makes
5032 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5034 * buildbot/test/test_swap.py: remove dead code
5036 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5037 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5038 sort of as if the command being run exited with a -1. There may
5039 still be some holes in this scheme.
5040 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5041 -r option appears before the module list
5042 * buildbot/process/step.py (CVS): add 'revision' argument
5044 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5045 when sending updates or stepComplete messages to the master, since
5046 we don't currently care whether they arrive or not. When we revamp
5047 the master/slave protocol to really resume interrupted builds,
5048 this will need revisiting.
5049 (lostRemote): remove spurious print
5051 * buildbot/master.py (BotPerspective.attached): serialize the
5052 new-builder interrogation process, to make testing easier
5053 (BotMaster.waitUntilBuilderDetached): convenience function
5055 * buildbot/status/builder.py (BuilderStatus): prune old builds
5056 (BuildStatus.pruneSteps): .. and steps
5057 (BuildStepStatus.pruneLogs): .. and logs
5058 (BuilderStatus.getBuild): handle missing builds
5059 * buildbot/status/html.py (StatusResourceBuild.body): display build
5060 status in the per-build page
5061 (BuildBox.getBox): color finished builds in the per-build box
5063 2004-08-27 Brian Warner <warner@lothar.com>
5065 * buildbot/status/mail.py (MailNotifier): new notification class,
5068 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5069 variants of a common base class which handles all the mode= logic
5071 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5073 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5075 2004-08-26 Brian Warner <warner@lothar.com>
5077 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5080 * buildbot/test/test_run.py: update to new Logfile interface, new
5081 buildbot.slave modules
5082 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5084 * MANIFEST.in: new sample config file
5085 * docs/examples/hello.cfg: same
5087 * buildbot/process/step_twisted.py: remove dead import
5089 * buildbot/process/step.py (RemoteCommand.run): catch errors
5091 (RemoteCommand.remote_update): ignore updates that arrive after
5093 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5094 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5095 the responsibilities of the subclass's methods
5096 (BuildStep.failed): catch errors during failure processing
5097 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5098 (CVS): move to a mode= argument (described in docstring), rather
5099 than the ungainly clobber=/export=/copydir= combination.
5100 (SVN): add mode= functionality to SVN too
5101 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5103 * buildbot/process/base.py (Build.startNextStep): catch errors
5104 during s.startStep()
5106 * buildbot/clients/base.py: update to new PB client interface.
5107 gtkPanes is still broken
5109 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5110 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5111 * setup.py: add buildbot.slave module
5112 * buildbot/bb_tap.py: handle move
5113 * buildbot/slave/registry.py: place to register commands, w/versions
5114 * buildbot/slave/bot.py: major simplifications
5115 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5116 instead of a fixed table. Eventually this will make the slave more
5117 extensible. Use 'start' method on the command, not .startCommand.
5118 Fix unsafeTracebacks handling (I think).
5119 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5120 helper class with a .start method that returns a Deferred.
5121 SlaveShellCommand is the form reached by the buildmaster. Commands
5122 which use multiple ShellCommands can just chain them as Deferreds,
5123 with some helper methods in Command (_abandonOnFailure and
5124 _checkAbandoned) to bail on rc!=0.
5125 (CVSCommand): prefer new mode= argument
5126 (SVNFetch): add mode= argument
5128 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5129 put a useful reason string on the build
5131 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5132 core functionality into an IStatusLog object
5133 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5134 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5135 (StatusResourceBuild.body): use proper accessor methods
5136 * buildbot/status/client.py (RemoteLog): PB-access goes here
5137 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5138 which delivers log contents too
5139 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5140 * buildbot/status/event.py: remove old Logfile completely
5142 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5143 subscription interface for IStatusLog subscriptions just like all
5144 other the status subscriptions
5145 (IStatusReceiver.logChunk): method called on subscribers
5147 2004-08-24 Brian Warner <warner@lothar.com>
5149 * buildbot/process/builder.py (Builder._pong): oops, ping response
5150 includes a result (the implicit None returned by remote_print).
5151 Accept it so the _pong method handles the response correctly.
5153 2004-08-06 Brian Warner <warner@lothar.com>
5155 * buildbot/test/test_config.py: update IRC, PBListener tests
5157 * buildbot/status/client.py (StatusClientPerspective): total
5158 rewrite to match new IStatus interfaces. New subscription scheme.
5159 There are still a few optimizations to make (sending down extra
5160 information with event messages so the client doesn't have to do a
5161 round trip). The logfile-retrieval code is probably still broken.
5162 Moved the PB service into its own port, you can no longer share a
5163 TCP socket between a PBListener and, say, the slaveport (this
5164 should be fixed eventually).
5165 * buildbot/clients/base.py (Client): revamp to match. still needs
5166 a lot of work, but basic event reporting works fine. gtkPanes is
5169 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5170 instance talks to a single irc server. Threw out all the old
5171 multi-server handling code. Still need to add back in
5172 builder-control (i.e. "force build")
5174 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5175 more random text to the as-yet-unreachable per-step page
5177 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5178 rename to stepETAUpdate
5179 (BuildStatus.subscribe): add build-wide ETA updates
5180 (BuilderStatus.getState): remove more cruft
5181 (BuilderStatus.getCurrentBuild): remove more cruft
5182 (BuilderStatus.buildStarted): really handle tuple-subscription
5183 * buildbot/test/test_run.py (Status.testSlave): handle the
5184 stepETAUpdate rename
5186 * buildbot/master.py (BuildMaster): don't add a default
5187 StatusClientService. Don't add a default IrcStatusFactory. Both
5188 are now added through c['status'] in the config file. c['irc'] is
5189 accepted for backwards compatibility, the only quirk is you cannot
5190 use c['irc'] to specify IRC servers on ports other than 6667.
5192 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5193 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5194 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5195 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5198 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5199 the buildmaster to re-read its config file
5202 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5203 find out the port our server is running on
5204 (WebTest.test_webPathname_port): same
5206 * buildbot/test/test_config.py (testWebPortnum): test it
5207 (testWebPathname): ditto
5209 * docs/config.xhtml: document new c['status'] configuration option
5211 * buildbot/status/html.py (Waterfall): new top-level class which
5212 can be added to c['status']. This creates the Site as well as the
5213 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5214 reachable as .parent, for everything.
5216 * buildbot/master.py (Manhole): make it a normal service Child
5217 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5218 webPathname. It will eventually replace c['irc'] and the implicit
5219 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5220 in as (deprecated) backward compatibility hooks for now.
5223 * buildbot/process/builder.py (Builder.buildFinished): don't
5224 inform out builder_status about a finished build, as it finds out
5225 through its child BuildStatus object
5227 * buildbot/status/html.py: extensive revamp. Use adapters to make
5228 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5229 have both starting and finishing times and adjust the waterfall
5230 display accordingly, using spacers if necessary. Use SlaveStatus
5231 to get buildslave info.
5232 (StatusResourceBuildStep): new just-one-step resource, used to get
5233 logfiles. No actual href to it yet.
5235 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5236 the time being, until I get the file-naming scheme right
5238 * buildbot/status/builder.py (Event): clean started/finished names
5239 (BuildStatus.isFinished): .finished is not None is the right test
5240 (BuildStatus.buildStarted): track started/finished times ourselves
5241 (BuilderStatus.getSlave): provide access to SlaveStatus object
5242 (BuilderStatus.getLastFinishedBuild): all builds are now in
5243 .builds, even the currently-running one. Accomodate this change.
5244 (BuilderStatus.eventGenerator): new per-builder event generator.
5245 Returns BuildStepStatus and BuildStatus objects, since they can
5246 both be adapted as necessary.
5247 (BuilderStatus.addEvent): clean up started/finished attributes
5248 (BuilderStatus.startBuild,finishBuild): remove dead code
5249 (SlaveStatus): new object to provide ISlaveStatus
5251 * buildbot/process/step.py (ShellCommand.getColor): actually
5252 return the color instead of setting it ourselves
5253 (CVS.__init__): pull .timeout and .workdir options out of
5254 **kwargs, since BuildStep will ignore them. Without this neither
5255 will be sent to the slave correctly.
5256 (SVN.__init__): same
5258 * buildbot/process/builder.py (Builder): move flags to class-level
5260 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5261 SlaveStatus handle that
5263 * buildbot/process/base.py (Build.firstEvent): remove dead code
5264 (Build.stopBuild): bugfix
5266 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5268 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5269 (ChangeMaster.eventGenerator): yield Changes, since there are now
5270 Adapters to turn them into HTML boxes
5272 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5273 (BotPerspective.attached): feed a SlaveStatus object
5274 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5275 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5277 * buildbot/interfaces.py: API additions
5278 (ISlaveStatus): place to get slave status
5280 2004-08-04 Brian Warner <warner@lothar.com>
5282 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5283 the delay finishes, so the step is marked as SUCCESS
5285 * buildbot/test/test_run.py (Status.testSlave): cover more of
5286 IBuildStatus and IBuildStepStatus
5288 * buildbot/status/progress.py (StepProgress): move some flags to
5289 class-level attributes
5290 (StepProgress.remaining): if there are no other progress metrics
5291 to go by, fall back to elapsed time
5292 (StepProgress.setExpectations): take a dict of metrics instead of
5294 (BuildProgress.setExpectationsFrom): pull expectations from the
5295 Expectations, instead of having it push them to the BuildProgress
5296 (Expectations): move some flags to class-level attributes
5297 (Expectations.__init__): copy per-step times from the
5299 (Expectations.expectedBuildTime): new method for per-build ETA
5301 * buildbot/status/event.py (Logfile): move some flags to
5302 class-level attributes
5303 (Logfile.logProgressTo): better method name, let step set the
5304 progress axis name (instead of always being "output")
5306 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5307 times directly, rather than depending upon the (possibly missing)
5308 .progress object. Use 'None' to indicate "not started/finished
5310 (BuildStepStatus.getExpectations): oops, return the full list of
5312 (BuilderStatus._buildFinished): append finished builds to .builds
5314 * buildbot/process/step.py (BuildStep): add separate .useProgress
5315 flag, since empty .progressMetrics[] still implies that time is a
5317 (CVS): set up the cmd in __init__, instead of waiting for start()
5319 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5320 calculation, this will eventually turn into a proper sourceStamp
5321 (Build.setupBuild): tell the Progress to load from the Expectations,
5322 instead of having the Expectations stuff things into the Progress
5323 (Build.buildException): add a build-level errback to make sure the
5324 build's Deferred fires even in case of exceptions
5326 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5328 * buildbot/process/builder.py (Builder.forceBuild): convey the
5329 reason instead of creating a fake Change
5331 * docs/examples/twisted_master.cfg: update to match reality
5333 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5334 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5335 fix or remove broken/breaking tests
5337 * buildbot/status/event.py (Logfile.__len__): remove evil method
5339 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5340 missing .build, for test convenience
5342 * buildbot/process/step_twisted.py: import fixes
5344 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5346 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5347 .statusbag reference
5349 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5350 connection at shutdown, and stop it from reconnecting
5352 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5353 chase down remote-execution bugs
5355 * buildbot/process/step.py: more fixes, remove
5356 BuildStep.setStatus()
5357 * buildbot/status/builder.py: move setStatus() functionality into
5359 * buildbot/status/event.py: minor fixes
5361 2004-08-03 Brian Warner <warner@lothar.com>
5363 * buildbot/process/base.py, buildbot/process/builder.py
5364 * buildbot/process/step.py, buildbot/status/builder.py
5365 * buildbot/status/event.py, buildbot/test/test_run.py:
5366 fix status delivery, get a basic test case working
5367 * buildbot/master.py: finish implementing basic status delivery,
5368 temporarily disable HTML/IRC/PB status sources
5370 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5372 * buildbot/status/progress.py (BuildProgress): remove dead code
5374 * buildbot/interfaces.py
5375 * buildbot/process/base.py, buildbot/process/builder.py
5376 * buildbot/process/step.py, buildbot/process/step_twisted.py
5377 * buildbot/status/builder.py: Complete overhaul of the all
5378 status-delivery code, unifying all types of status clients (HTML,
5379 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5380 look like. This commit is a checkpointing of the work-in-progress:
5381 the input side is mostly done (Builders/Builds sending status
5382 to the BuilderStatus/BuildStatus objects), but the output side has
5383 not yet been started (HTML resources querying BuilderStatus
5384 objects). Things are probably very broken right now and may remain
5385 so for several weeks, I apologize for the disruption.
5387 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5388 HTML as the log's contents. Currently used for exception tracebacks.
5389 * buildbot/status/progress.py: minor spelling changes
5391 2004-08-02 Brian Warner <warner@lothar.com>
5393 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5394 in mozilla. Also added stylesheets copied from Twisted's docs.
5395 Remember that these files are meant to be run through Lore first.
5396 Thanks to Philipp Frauenfelder for the fixes.
5397 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5398 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5399 * docs/template.tpl: added a Lore template
5401 2004-07-29 Brian Warner <warner@lothar.com>
5403 * buildbot/interfaces.py: revamp status delivery. This is the
5404 preview: these are the Interfaces that will be provided by new
5405 Builder code, and to which the current HTML/IRC/PB status
5406 displayers will be adapted.
5408 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5409 on the SlaveBuilder, not the Bot.
5410 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5412 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5413 set .usePTY on the FakeSlaveBuilder
5415 2004-07-25 Brian Warner <warner@lothar.com>
5417 * buildbot/changes/freshcvs.py: add some debug log messages
5418 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5419 disabled 'setFilter' syntax
5420 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5421 don't end with a slash
5423 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5425 * setup.py: bump to 0.5.0+ while between releases
5427 2004-07-23 Brian Warner <warner@lothar.com>
5429 * setup.py (version): Releasing buildbot-0.5.0
5431 2004-07-23 Brian Warner <warner@lothar.com>
5433 * README: update for 0.5.0 release
5435 * NEWS: update for 0.5.0 release
5437 2004-07-22 Brian Warner <warner@lothar.com>
5439 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5440 mktap-time configuration flag (--usepty=1, --usepty=0)
5441 * buildbot/bot.py: same
5443 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5444 an 'info' directory being unwanted
5446 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5447 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5448 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5449 and earlier), use a FreshCVSSourceOldcred instead.
5450 (test): simple test routine: connect to server, print changes
5452 * buildbot/changes/changes.py (Change.getTime): make it possible
5453 to print un-timestamped changes
5455 * buildbot/master.py (makeApp): delete ancient dead code
5456 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5457 * buildbot/test/test_config.py (testFindConfigFile): test it
5459 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5460 instead of win32 one
5463 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5464 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5467 * buildbot/process/base.py (Builder.__init__): change constructor
5468 to accept a dictionary of config data, rather than discrete
5469 name/slave/builddir/factory arguments
5471 * docs/examples/twisted_master.cfg: update to new syntax
5472 * docs/examples/glib_master.cfg: same
5473 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5474 rough tests of the new syntax
5477 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5478 to be an int, which means "run a web.distrib sub-server on a TCP
5479 port". This lets you publish the buildbot status page to a remote
5480 twisted.web server (using distrib.ResourceSubscription). Also
5481 rename the local attributes used to hold these web things so
5482 they're more in touch with reality.
5483 * buildbot/test/test_web.py: test webPortnum and webPathname
5484 * docs/config.xhtml: document this new use of webPathname
5486 * docs/config.xhtml: new document, slightly ahead of reality
5488 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5489 'prefix' handling: treat it as a simple string to check with
5490 .startswith, instead of treating it as a directory. This allows
5491 sub-directories to be used. If you use prefix=, you should give it
5492 a string that starts just below the CVSROOT and ends with a slash.
5493 This prefix will be stripped from all filenames, and filenames
5494 which do not start with it will be ignored.
5496 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5498 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5499 and --exclude (inverse of --include). SVN post-commit hooks
5500 now have total control over which changes get sent to buildbot and which
5503 2004-07-10 Brian Warner <warner@lothar.com>
5505 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5506 test case to match new API
5508 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5509 which crashed HTML display when self.entries=[] (needed to
5510 distinguish between [], which means "no entries yet", and None,
5511 which means "the entries have been swapped out to disk, go fetch
5514 2004-07-04 Brian Warner <warner@lothar.com>
5516 * buildbot/process/step_twisted.py (countFailedTests): Count
5517 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5518 10kb from the end because any import errors are wedged there and
5519 they would make us think the test log was unparseable.
5520 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5522 2004-06-26 Brian Warner <warner@lothar.com>
5524 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5525 delete-*.pyc command into an actual BuildStep, so we can label it
5527 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5528 (FullTwistedBuildFactory): same
5530 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5532 * contrib/fakechange.py: Add an errback when sending the fake
5533 change, so we know it didn't work.
5535 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5537 * buildbot/process/step_twisted.py: Delete *.pyc files before
5538 calling trial, so it doesn't catch any old .pyc files whose .py
5539 files have been moved or deleted.
5541 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
5542 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
5543 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
5544 instead of ["twisted.test"], so that the end result is "trial -R
5547 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
5548 regular expression to match filenames that should be ignored when
5549 changed. Also add a --revision parameter that specifies the
5550 revision to examine, which is useful for debugging.
5552 2004-06-25 Brian Warner <warner@lothar.com>
5554 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
5555 summary of warnings (like DeprecationWarnings), next to the
5558 2004-05-13 Brian Warner <warner@lothar.com>
5560 * docs/examples/twisted_master.cfg: enable the win32 builder, as
5561 we now have a w32 build slave courtesy of Mike Taylor.
5563 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
5564 so broken. Fixed a race condition that tripped up interlocked
5565 builds and caused the status to be stuck at "Interlocked" forever.
5566 The twisted buildbot's one interlocked build just so happened to
5567 never hit this case until recently (the feeding builds both pass
5568 before the interlocked build is attempted.. usually it has to wait
5570 (Builder._pong_failed): fix method signature
5572 * setup.py: bump to 0.4.3+ while between releases
5574 2004-04-30 Brian Warner <warner@lothar.com>
5576 * setup.py (version): Releasing buildbot-0.4.3
5578 2004-04-30 Brian Warner <warner@lothar.com>
5580 * MANIFEST.in: add the doc fragments in docs/*.xhtml
5582 * README: update for 0.4.3 release
5584 * NEWS: update for 0.4.3 release
5586 * buildbot/master.py (BuildMaster.__getstate__): make sure
5587 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
5589 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
5590 .trial as a class attribute, for upgrade from 0.4.2
5592 * buildbot/changes/changes.py (Change.links): add .links for
5595 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
5596 .textWatchers and .htmlWatchers at save time, since they are both
5597 volatile, should allow smooth 0.4.2 upgrade
5599 * buildbot/process/step.py (CVS.finishStatus): catch failed
5600 CVS/SVN commands so we can make the status box red
5602 2004-04-29 Brian Warner <warner@lothar.com>
5604 * buildbot/changes/freshcvs.py
5605 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
5606 code to do setFilter(), which tells the freshcvs daemon to not
5607 send us stuff that we're not interested in. I will uncomment it
5608 when a new version of CVSToys is available in which setFilter()
5609 actually works, and I get a chance to test it better.
5611 * docs/examples/twisted_master.cfg: start using a PBChangeSource
5613 * buildbot/master.py (Dispatcher): use a registration scheme
5614 instead of hardwired service names
5615 (BuildMaster): keep track of the Dispatcher to support
5618 * buildbot/changes/changes.py (ChangeMaster): create a distinct
5619 PBChangeSource class instead of having it be an undocumented
5620 internal feature of the ChangeMaster. Split out the code into a
5622 * buildbot/changes/pb.py (PBChangeSource): same
5623 * buildbot/test/test_changes.py: a few tests for PBChangeSource
5625 * docs/{factories|sources|steps}.xhtml: document some pieces
5627 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
5628 using FCMaildirSource
5629 (f23osx): update OS-X builder to use python2.3, since the slave
5630 was updated to Panther (10.3.3)
5632 2004-03-21 Brian Warner <warner@lothar.com>
5634 * buildbot/process/process_twisted.py: factor out doCheckout, change
5635 to use SVN instead of CVS
5637 * buildbot/process/base.py (BasicBuildFactory): refactor to make
5638 an SVN subclass easier
5639 (BasicSVN): subclass which uses Subversion instead of CVS
5641 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
5643 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
5645 (CVSCommand.cvsComplete): don't assume chdir worked on win32
5647 2004-02-25 Brian Warner <warner@lothar.com>
5649 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
5650 is now either a list (which is passed to spawnProcess directly) or
5651 a string (which gets passed to /bin/sh -c). This removes the useSH
5652 flag and the ArgslistCommand class. Also send status header at the
5653 start and end of each command, instead of having the master-side
5655 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
5656 -r'. Update to use list-based arguments.
5657 (SVNFetch): use list-based arguments, use ['dir'] argument to
5659 * buildbot/test/test_steps.py (Commands): match changes
5661 * buildbot/process/step.py (InternalShellCommand.words): handle
5663 (SVN): inherit from CVS, cleanup
5665 * buildbot/status/event.py (Logfile.content): render in HTML, with
5666 stderr in red and headers (like the name of the command we're
5667 about to run) in blue. Add link to a second URL (url + "?text=1")
5668 to get just stdout/stderr in text/plain without markup. There is
5669 still a problem with .entries=None causing a crash, it seems to occur
5670 when the logfile is read before it is finished.
5672 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
5673 timeout to the keepalives, and use it to explicitly do a
5674 loseConnection instead of waiting for TCP to notice the loss. This
5675 ought to clear up the silent-lossage problem.
5676 (unsafeTracebacks): pass exception tracebacks back to the master,
5677 makes it much easier to debug problems
5679 2004-02-23 Brian Warner <warner@lothar.com>
5681 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
5682 the whole command to /bin/sh instead of execve [Johan Dahlin]
5683 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
5684 '-r HEAD' [Johan Dahlin]
5685 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
5687 * buildbot/changes/changes.py (Change): add links= argument, add
5688 asHTML method [Johan Dahlin]. Modified to make a bit more
5689 XHTMLish. Still not sure how to best use links= .
5691 * buildbot/status/html.py (StatusResourceCommits.getChild): use
5692 Change.asHTML to display the change, not asText
5694 * buildbot/status/html.py (StatusResourceBuilder): web button to
5697 * buildbot/test/test_run.py: test to actually start a buildmaster
5700 * MANIFEST.in: bring back accidentally-dropped test helper files
5702 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
5703 that require cvstoys if it is not installed
5705 * buildbot/process/step_twisted.py (RunUnitTests): allow other
5706 values of "bin/trial" [Dave Peticolas]
5707 (RunUnitTests.finishStatus): say "no tests run" instead of "0
5708 tests passed" when we didn't happen to run any tests
5710 * buildbot/process/step.py (Compile): use haltOnFailure instead of
5711 flunkOnFailure [Johan Dahlin]
5713 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
5714 multiple instances of the same Step class by suffixing "_2", etc,
5715 to the name until it is unique. This name needs to be unique
5716 because it is used as a key in the dictionary that tracks build
5718 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
5721 * buildbot/process/base.py (Builder.ping): add "ping slave" command
5723 2004-01-14 Brian Warner <warner@lothar.com>
5725 * buildbot/status/words.py (IrcStatusBot): when we leave or get
5726 kicked from a channel, log it
5728 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
5729 something over whatever IRC channels the buildmaster is currently
5730 connected to. Added to try and track down a problem in which the
5731 master thinks it is still connected but the IRCd doesn't see it. I
5732 used a styles.Versioned this time, so hopefully users won't have
5733 to rebuild their .tap files this time.
5734 * contrib/debug.glade: add a "Poke IRC" button
5735 * contrib/debugclient.py: same
5737 * setup.py: bump to 0.4.2+ while between releases
5739 2004-01-08 Brian Warner <warner@lothar.com>
5741 * setup.py (version): Releasing buildbot-0.4.2
5743 2004-01-08 Brian Warner <warner@lothar.com>
5745 * NEWS: update for 0.4.2 release
5747 * README: document how to run the tests, now that they all pass
5749 * buildbot/changes/maildir.py (Maildir.poll): minor comment
5751 * buildbot/process/step.py (CVS): add a global_options= argument,
5752 which lets you set CVS global options for the command like "-r"
5753 for read-only checkout, or "-R" to avoid writing in the
5755 * buildbot/slavecommand.py (CVSCommand): same
5757 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
5758 testing easier (it is turned off when testing, to avoid the
5761 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
5762 to make it easier to test: break generateStepID() out to a
5763 separate function, only update statusbag if it exists.
5764 (ShellCommands): create useful text for dict-based commands too.
5766 * test/*, buildbot/test/*: move unit tests under the buildbot/
5768 * setup.py (packages): install buildbot.test too
5770 * buildbot/test/test_slavecommand.py: fix it, tests pass now
5771 * buildbot/test/test_steps.py: fix it, tests pass now
5773 2004-01-06 Brian Warner <warner@lothar.com>
5775 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
5776 freshcvs mail uses a slightly different syntax for new
5777 directories. Update parser to handle either.
5778 * test/test_mailparse.py (Test1.testMsg9): test for same
5780 2003-12-21 Brian Warner <warner@lothar.com>
5782 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
5783 'warnOnWarnings' so that lintian errors mark the build orange
5785 2003-12-17 Brian Warner <warner@lothar.com>
5787 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
5788 messages emitted by Bonsai, contributed by Stephen Davis.
5790 * test/*: moved all tests to use trial instead of unittest. Some
5791 still fail (test_steps, test_slavecommand, and test_process).
5793 * setup.py (version): bump to 0.4.1+ while between releases
5795 2003-12-09 Brian Warner <warner@lothar.com>
5797 * setup.py (version): Releasing buildbot-0.4.1
5799 2003-12-09 Brian Warner <warner@lothar.com>
5801 * NEWS: update for 0.4.1 release
5803 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
5804 freebsd builder code a little bit
5806 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
5807 don't try to compare attributes of different classes
5808 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
5809 (MaildirSource.messageReceived): fix Change delivery
5811 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
5812 into the config file's namespace before loading it, like the
5813 documentation claims it does
5814 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
5815 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
5816 daemon comes back online
5818 2003-12-08 Brian Warner <warner@lothar.com>
5820 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
5821 so the example will work with online=0 as well
5823 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
5824 fix the __implements__ line
5826 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
5827 class a twisted.application.service.Service, use startService to
5830 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
5831 directory fd instead of simple open(). I'm sure this used to work,
5832 but the current version of python refuses to open directories with
5835 2003-12-05 Brian Warner <warner@lothar.com>
5837 * setup.py (version): bump to 0.4.0+ while between releases
5839 2003-12-05 Brian Warner <warner@lothar.com>
5841 * setup.py (version): Releasing buildbot-0.4.0
5843 2003-12-05 Brian Warner <warner@lothar.com>
5845 * docs/examples/glib_master.cfg: replace old sample scripts with
5846 new-style config files
5847 * MANIFEST.in: include .cfg files in distribution tarball
5849 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
5850 implement a dummy method to avoid the exception that occurs when
5851 freshcvs sends this to us.
5853 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
5854 removed the method, as it broke reconnection. Apparently
5855 stopFactory is called each time the connection attempt fails. Must
5857 (ReconnectingPBClientFactory.__getstate__): squash the _callID
5858 attribute before serialization, since without stopFactory the
5859 reconnect timer may still be active and they aren't serializable.
5861 * test/test_mailparse.py (ParseTest): test with 'self' argument
5863 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
5864 argument, as these "functions" are invoked like methods from class
5865 attributes and therefore always get an instance as the first
5868 * buildbot/changes/maildir.py (Maildir.start): fix error in error
5869 message: thanks to Stephen Davis for the catch
5871 2003-12-04 Brian Warner <warner@lothar.com>
5873 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
5874 twisted's standard ReconnectingClientFactory. Handles both oldcred
5875 and newcred connections. Also has a bug-workaround for
5876 ReconnectingClientFactory serializing its connector when it
5879 * buildbot/bot.py (BotFactory): rewrite connection layer with new
5880 pbutil. Replace makeApp stuff with proper newcred/mktap
5881 makeService(). Don't serialize Ephemerals on shutdown.
5883 * buildbot/changes/changes.py (ChangeMaster): make it a
5884 MultiService and add the sources as children, to get startService
5885 and stopService for free. This also gets rid of the .running flag.
5887 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
5888 new pbutil, turn into a TCPClient at the same time (to get
5889 startService for free). Two variants exist: FreshCVSSourceOldcred
5890 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
5891 yet, but when it does, we'll be ready).
5892 (FreshCVSSource.notify): handle paths which are empty after the
5893 prefix is stripped. This only happens when the top-level (prefix)
5894 directory is added, at the very beginning of a Repository's life.
5896 * buildbot/clients/base.py: use new pbutil, clean up startup code.
5897 Now the only reconnecting code is in the factory where it belongs.
5898 (Builder.unsubscribe): unregister the disconnect callback when we
5899 delete the builder on command from the master (i.e. when the
5900 buildmaster is reconfigured and that builder goes away). This
5901 fixes a multiple-delete exception when the status client is shut
5903 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
5906 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
5907 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
5909 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
5911 * contrib/run_maxq.py: Accept a testdir as an argument rather than
5912 a list of globs (ugh). The testdir will be searched for files
5913 named *.tests and run the tests in the order specified in each of
5914 those files. This allows for "dependancies" between tests to be
5917 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
5918 argument to pass to run_maxq.py, instead of a glob.
5920 2003-10-17 Brian Warner <warner@lothar.com>
5922 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
5923 files that live in the sandbox
5925 2003-10-15 Brian Warner <warner@lothar.com>
5927 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
5928 spelling error in "docs" count-warnings output
5929 (HLint.start): stupid thinko meant .xhtml files were ignored
5931 * docs/examples/twisted_master.cfg (reactors): disable cReactor
5932 tests now that cReactor is banished to the sandbox
5934 2003-10-10 Brian Warner <warner@lothar.com>
5936 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
5937 scheme: now .xhtml are sources and .html are generated
5939 2003-10-08 Brian Warner <warner@lothar.com>
5941 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
5942 we were ignoring the 'randomly' parameter.
5944 2003-10-01 Brian Warner <warner@lothar.com>
5946 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
5947 posix, to kill sub-children of aborted slavecommands.
5949 * buildbot/status/builder.py: rename Builder to BuilderStatus.
5950 Clean up initialization: lastBuildStatus remains None until the
5951 first build has been completed.
5953 * buildbot/status/html.py (WaterfallStatusResource.body): handle
5954 None as a lastBuildStatus
5955 * buildbot/clients/gtkPanes.py: same
5957 * buildbot/status/client.py (StatusClientService): keep
5958 BuilderStatus objects in self.statusbags . These objects now live
5959 here in the StatusClientService and are referenced by the Builder
5960 object, rather than the other way around.
5961 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
5962 * buildbot/process/base.py (Builder): same
5963 * test/test_config.py (ConfigTest.testBuilders): same
5965 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
5966 an existing builder, leave the statusbag alone. This will preserve the
5969 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
5970 hook. This will probably go away in favor of a class in upcoming
5973 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
5974 serviceName from newcred FreshCVSNotifiee setup
5976 2003-09-29 Brian Warner <warner@lothar.com>
5978 * buildbot/process/process_twisted.py: switch to new reactor
5980 * docs/examples/twisted_master.cfg: same
5982 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
5984 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
5985 botmaster reference instead of the oldapp service lookup
5987 * buildbot/master.py (BuildMaster.__init__): give the
5988 StatusClientService a reference to the botmaster to make it easier to
5991 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
5993 * buildbot/status/html.py (Box.td): escape hreffy things so you
5994 can have spaces in things like builder names
5995 (StatusResourceBuilder.body)
5996 (WaterfallStatusResource.body)
5997 (WaterfallStatusResource.body0): same
5999 2003-09-25 Brian Warner <warner@lothar.com>
6001 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6002 rearrange the builder list when adding or removing builders: keep
6003 them in the order the user requested.
6004 * test/test_config.py (ConfigTest.testBuilders): verify it
6006 * contrib/debug.glade: give the debug window a name
6008 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6009 now wait on multiple interlocks. Fix code relating to that.
6010 (Builder.checkInterlocks): same
6011 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6013 * buildbot/master.py (BuildMaster.loadConfig): move from
6014 deprecated pb.BrokerFactory to new pb.PBServerFactory
6015 * test/test_config.py (ConfigTest.testWebPathname): same
6017 * docs/examples/twisted_master.cfg: fix interlock declaration
6019 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6020 Interlocks to their Builders into interlock.py .
6021 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6023 * test/test_config.py (ConfigTest.testInterlocks): validate
6026 * buildbot/process/base.py (Builder.__init__): better comments
6027 * buildbot/process/interlock.py (Interlock.__repr__): same
6028 (Interlock.deactivate): add .active flag, move the code that
6029 attaches/detaches builders into the Interlock
6031 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6033 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6034 tests using the new run_maxq.py script, and reporting failures by
6037 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6038 tests, reporting their success or failure in a buildbot-friendly
6041 2003-09-24 Brian Warner <warner@lothar.com>
6043 * docs/examples/twisted_master.cfg: example of a new-style config
6044 file. This lives in the buildmaster base directory as
6047 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6048 button to make the master re-read its config file
6050 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6051 buildmaster configuration from a file. This file can be re-read
6052 later, and the buildmaster will update itself to match the new
6053 desired configuration. Also use new Twisted Application class.
6054 * test/Makefile, test/test_config.py: unit tests for same
6056 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6057 FreshCVSSources comparable, to support reload.
6058 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6060 * buildbot/process/base.py (Builder): make them comparable, make
6061 Interlocks easier to attach, to support reload. Handle
6062 re-attachment of remote slaves.
6063 * buildbot/process/interlock.py (Interlock): same
6065 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6066 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6067 buildmaster taps are now constructed with mktap.
6068 * buildbot/status/client.py (StatusClientService): same
6070 * buildbot/status/words.py: move to new Services, add support to
6071 connect to multiple networks, add reload support, allow nickname
6072 to be configured on a per-network basis
6074 2003-09-20 Brian Warner <warner@lothar.com>
6076 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6077 the freebsd builder, now that the machine has been upgraded and no
6078 longer has python2.2
6080 * setup.py (version): bump to 0.3.5+ while between releases
6082 2003-09-19 Brian Warner <warner@lothar.com>
6084 * setup.py (version): Releasing buildbot-0.3.5
6086 2003-09-19 Brian Warner <warner@lothar.com>
6088 * NEWS: add post-0.3.4 notes
6090 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6092 * MANIFEST.in: add contrib/*
6094 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6095 use a remote root now: cvs.twistedmatrix.com
6097 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6099 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6100 compatibility with old servers
6101 (FreshCVSSource.start): and provide a way to use it
6102 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6104 * docs/examples/twisted_master.py (twisted_app): update to new
6106 (twisted_app): listen on new ~buildbot socket
6107 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6109 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6110 to reduce cvs bandwidth (update instead of full checkout)
6112 2003-09-11 Brian Warner <warner@lothar.com>
6114 * contrib/fakechange.py: demo how to connect to the changemaster
6115 port. You can use this technique to submit changes to the
6116 buildmaster from source control systems that offer a hook to run a
6117 script when changes are committed.
6119 * contrib/debugclient.py: tool to connect to the debug port. You
6120 can use it to force builds, submit fake changes, and wiggle the
6123 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6124 'Dispatcher' realm to handle all the different kinds of
6125 connections and Perspectives: buildslaves, the changemaster port,
6126 the debug port, and the status client port. NewCredPerspectives
6127 now have .attached/.detached methods called with the remote 'mind'
6128 reference, much like old perspectives did. All the pb.Services
6129 turned into ordinary app.ApplicationServices .
6130 (DebugService): went away, DebugPerspectives are now created
6131 directly by the Dispatcher.
6132 (makeApp): changed interface a little bit
6134 * buildbot/changes/changes.py: newcred
6135 * buildbot/status/client.py: newcred
6137 * buildbot/clients/base.py: newcred client side changes
6138 * buildbot/bot.py: ditto
6140 * docs/examples/glib_master.py: handle new makeApp() interface
6141 * docs/examples/twisted_master.py: ditto
6143 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6144 base newcred Perspectives on. This should go away once Twisted
6145 itself provides something sensible.
6148 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6150 * contrib/svn_buildbot.py: A program that you can call from your
6151 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6152 when a change in an SVN repository has happened. See the top of
6153 the file for some minimal usage info.
6155 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6157 * buildbot/slavecommand.py (ArglistCommand): Add new
6158 ArglistCommand that takes an argument list rather than a string as
6159 a parameter. Using a st.split() for argv is very bad.
6161 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6162 update to a particular revision rather than always checking out
6163 (still not very smart about it, there may be cases where the
6164 checkout becomes inconsistent).
6166 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6168 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6169 SVN fetch support. It can checkout (not update!) a specified
6170 revision from a specified repository to a specified directory.
6172 * buildbot/status/progress.py (Expectations.update): Fix an
6173 obvious bug (apparently created by the change described in the
6174 previous ChangeLog message) by moving a check to *after* the
6175 variable it checks is defined.
6178 2003-09-08 Brian Warner <warner@lothar.com>
6180 * buildbot/status/progress.py (Expectations.update): hack to catch
6181 an exception TTimo sees: sometimes the update() method seems to
6182 get called before the step has actually finished, so the .stopTime
6183 is not set, so no totalTime() is available and we average None
6184 with the previous value. Catch this and just don't update the
6185 metrics, and emit a log message.
6187 2003-08-24 Brian Warner <warner@lothar.com>
6189 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6190 parameter to set copydir='original' in CVS commands.
6192 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6194 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6195 which tells the command to maintain a separate original-source CVS
6196 workspace. For each build, this workspace will be updated, then
6197 the tree copied into a new workdir. This reduces CVS bandwidth
6198 (from a full checkout to a mere update) while doubling the local
6199 disk usage (to keep two copies of the tree).
6201 2003-08-21 Brian Warner <warner@lothar.com>
6203 * buildbot/status/event.py (Logfile.addEntry): if the master web
6204 server dies while we're serving a page, request.write raises
6205 pb.DeadReferenceError . Catch this and treat it like a
6206 notifyFinish event by dropping the request.
6208 2003-08-18 Brian Warner <warner@lothar.com>
6210 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6211 (instead of blowing up) if a force-build command is given without
6214 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6215 don't blow up if there aren't yet any Changes in the list
6217 2003-08-02 Brian Warner <warner@lothar.com>
6219 * buildbot/bot.py (updateApplication): don't set the .tap name,
6220 since we shouldn't assume we own the whole .tap file
6222 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6223 'mktap buildbot' (without a subcommand) better
6225 2003-07-29 Brian Warner <warner@lothar.com>
6227 * buildbot/status/words.py
6228 (IrcStatusFactory.clientConnectionLost): when we lose the
6229 connection to the IRC server, schedule a reconnection attempt.
6231 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6232 use shutil.rmtree instead of forking off an "rm -rf" command.
6233 rmtree may take a while and will block until it finishes, so we
6234 use "rm -rf" if available.
6236 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6237 freebsd buildslave badly
6239 * setup.py (version): bump to 0.3.4+ while between releases
6241 2003-07-28 Brian Warner <warner@lothar.com>
6243 * setup.py (version): Releasing buildbot-0.3.4
6245 2003-07-28 Brian Warner <warner@lothar.com>
6247 * NEWS: update in preparation for release
6249 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6250 process.signalProcess instead of os.kill, to improve w32
6253 * docs/examples/twisted_master.py (twisted_app): turn off
6254 win32eventreactor: the tests hang the buildslave badly
6256 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6257 failed builds, since usually the failures are consistent
6259 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6260 add compileOpts/compileOpts2 to reactors build
6262 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6263 (twisted_app): use both default and win32eventreactor on w32 build.
6264 Use both default and kqreactor on freebsd build.
6266 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6267 add compileOpts2, which is put after the build_ext argument. w32
6268 needs "-c mingw32" here.
6270 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6271 touch .acqpath, it goes away in recent Twisted releases
6273 * docs/examples/twisted_master.py (twisted_app): use "python" for
6274 the w32 buildslave, not "python2.2"
6276 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6277 the directory exists.. should hush an exception under w32
6279 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6280 ProcessTerminated -provided values for signal and exitCode rather
6281 than parsing the unix status code directly. This should remove one
6282 more roadblock for a w32-hosted buildslave.
6284 * test/test_mailparse.py: add test cases for Syncmail parser
6286 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6287 temporary compatibility import. Note! Start importing
6288 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6290 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6292 2003-07-27 Brian Warner <warner@lothar.com>
6294 * NEWS: started adding new features
6296 * buildbot/changes/mail.py: start work on Syncmail parser, move
6297 mail sources into their own file
6299 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6300 as implementing IChangeSource
6301 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6303 * buildbot/interfaces.py: define the IChangeSource interface
6305 2003-07-26 Brian Warner <warner@lothar.com>
6307 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6309 2003-06-25 Brian Warner <warner@lothar.com>
6311 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6314 2003-06-17 Brian Warner <warner@lothar.com>
6316 * buildbot/status/words.py: clean up method usage to avoid error
6317 in silly IRC command
6318 (IrcStatusBot.emit_status): round off seconds display
6320 * buildbot/process/base.py (Build): delete the timer when saving
6321 to the .tap file, and restore it (if it should still be running)
6322 upon restore. This should fix the "next build in -34 seconds"
6323 messages that result when the master is restarted while builds are
6324 sitting in the .waiting slot. If the time for the build has
6325 already passed, start it very soon (in 1 second).
6327 * buildbot/status/words.py: more silly commands
6329 * README (REQUIREMENTS): add URLs to all required software
6331 * buildbot/status/words.py ('last'): mention results of, and time
6334 2003-05-28 Brian Warner <warner@lothar.com>
6336 * buildbot/status/words.py: add 'last' command
6337 (IrcStatusBot.emit_status): add current-small text to 'status' output
6339 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6340 (twisted_app): remove spaces from OS-X builder name
6342 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6343 * buildbot/status/words.py: IRC bot should actually be useful now
6345 2003-05-23 Brian Warner <warner@lothar.com>
6347 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6348 "slave information" from $(slavedir)/info/* . These files are
6349 maintained by the slave administrator, and describe the
6350 machine/environment that is hosting the slave. Information from
6351 them is put into the "Builder" HTML page. Still need to establish
6352 a set of well-known filenames and meanings for this data: at the
6353 moment, *all* info/* files are sent to the master, but only
6354 'admin' and 'host' are used on that end.
6355 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6356 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6357 * buildbot/master.py (BotPerspective.got_info): ditto
6359 2003-05-22 Brian Warner <warner@lothar.com>
6361 * setup.py (version): bump version to 0.3.3+ while between releases
6363 2003-05-21 Brian Warner <warner@lothar.com>
6365 * setup.py: Releasing buildbot-0.3.3
6367 2003-05-21 Brian Warner <warner@lothar.com>
6369 * NEWS: 0.3.3 news items
6371 * README: describe --keepalive and life behind a NAT box
6373 * buildbot/bot.py (Bot.connected): implement application-level
6374 keepalives to deal with NAT timeouts, turn them on with
6375 --keepalive option or when SO_KEEPALIVE doesn't work.
6377 * buildbot/master.py (BotPerspective): accept keepalives silently
6379 * buildbot/process/base.py (Build.buildException): CopiedFailures
6380 don't carry as much information as local ones, so don't try to
6381 create a big HTMLized version of them.
6383 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6384 log file when step fails due to an exception, such as when the slave
6387 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6388 --testmodule argument instead of grepping for test-case-name tags
6389 ourselves. Remove FindUnitTests code.
6390 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6392 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6394 2003-05-16 Brian Warner <warner@lothar.com>
6396 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6397 argument to allow things like CFLAGS=-O0 to be passed without relying
6398 upon /bin/sh processing on the slave.
6400 * buildbot/process/step.py (InternalShellCommand.start): send
6402 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6403 'split' instead of letting /bin/sh do it. This should also remove
6404 the need for /bin/sh on the buildslave, making it more likely to
6407 * buildbot/status/html.py: html-escape text in blamelist.
6408 Add "force build" button to the Builder page.
6410 * buildbot/process/step_twisted.py (countFailedTests): look at
6411 last 1000 characters for status line, as import errors can put it
6412 before the -200 point.
6414 2003-05-15 Brian Warner <warner@lothar.com>
6416 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6418 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6419 make 'clobber' a parameter, so it is possible to have builds which
6420 do full tests but do a cvs update instead of hammering the CVS
6421 server with a full checkout each build
6423 * buildbot/process/step.py (InternalShellCommand): bump default
6424 timeout to 20 minutes
6426 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6427 the master to trigger a build. Run it via manhole.
6429 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6430 allow slaves to trigger any build that they host, to make life
6431 easier for slave admins who are testing out new build processes
6433 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6434 don't flunk cReactor or qtreactor on failure, since they fail alot
6435 these days. Do warnOnFailure instead.
6437 * buildbot/process/base.py: change Builder.buildable from a list
6438 into a single slot. When we don't have a slave, new builds (once
6439 they make it past the timeout) are now merged into an existing
6440 buildable one instead of being queued. With this change, a slave
6441 which has been away for a while doesn't get pounded with all the
6442 builds it missed, but instead just does a single build.
6444 2003-05-07 Brian Warner <warner@lothar.com>
6446 * setup.py (version): bump version to 0.3.2+ while between releases
6448 2003-05-07 Brian Warner <warner@lothar.com>
6450 * setup.py: Releasing buildbot-0.3.2
6452 2003-05-07 Brian Warner <warner@lothar.com>
6454 * setup.py: fix major packaging error: include subdirectories!
6456 * NEWS: add changes since last release
6458 * README (REQUIREMENTS): update twisted/python dependencies
6460 * buildbot/status/builder.py (Builder.startBuild): change
6461 BuildProcess API: now they should call startBuild/finishBuild
6462 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6463 keeping a list of builds in the statusbag, to support other kinds of
6465 (Builder.addClient): send current-activity-small to new clients
6466 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6469 * buildbot/status/client.py: drop RemoteReferences at shutdown
6471 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6473 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6474 more debug messages for remote status client
6476 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6477 (.stepFailed): only fire the Deferred once, even if both
6478 stepComplete and stepFailed are called. I think this can happen if
6479 an exception occurs at a weird time.
6481 * buildbot/status/words.py: work-in-progress: IRC status delivery
6483 2003-05-05 Brian Warner <warner@lothar.com>
6485 * docs/examples/twisted_master.py (twisted_app): hush internal
6486 python2.3 distutils deprecation warnings
6487 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6488 add compileOpts= argument which inserts extra args before the
6489 "setup.py build_ext" command. This can be used to give -Wignore
6490 warnings, to hush some internal python-2.3 deprecation messages.
6492 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6493 the ['twisted.test'] default test case to make it easier to change
6496 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6497 * buildbot/clients/gtkPanes.py: ditto
6499 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6500 arg to collapse RunUnitTestsRandomly into RunUnitTests
6501 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6502 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6504 * buildbot/status/html.py (StatusResource): shuffle Resources
6505 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6506 would serve the waterfall display, but the internal links were
6507 only valid on the trailing-slash version. The correct behavior is
6508 for the non-slashed one to serve a Redirect to the slashed one.
6509 This only shows up when the buildbot page is hanging off another
6510 server, like a Twisted-Web distributed server.
6512 * buildbot/status/event.py (Event, RemoteEvent): make Events
6513 pb.Cacheable, with RemoteEvent as the cached version. This removes
6514 a lot of explicit send-an-update code.
6515 * buildbot/status/builder.py (Builder): remove send-update code
6516 * buildbot/status/client.py (ClientBuilder): remove send-update
6517 code, and log errors that occur during callRemote (mostly to catch
6518 InsecureJelly exceptions)
6520 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6521 run Lore with the same python used in the rest of the build
6523 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6525 * buildbot/process/step_twisted.py (HLint): accept 'python'
6526 argument. Catch rc!=0 and mark the step as failed. This marks the
6527 build orange ("has warnings").
6528 (RunUnitTestsJelly): move out to step_twisted2.py
6530 * buildbot/util.py (ignoreStaleRefs): add utility function
6532 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6533 don't fake ETA object, it's too hard to get right
6535 2003-05-02 Brian Warner <warner@lothar.com>
6537 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6539 2003-05-01 Brian Warner <warner@lothar.com>
6541 * buildbot/status/html.py (StatusResource.body): oops, I was
6542 missing a <tr>, causing the waterfall page to be misrendered in
6543 everything except Galeon.
6545 2003-04-29 Brian Warner <warner@lothar.com>
6547 * docs/examples/twisted_master.py: make debuild use python-2.2
6548 explicitly, now that Twisted stopped supporting 2.1
6550 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
6551 handle tuple results too. I keep forgetting this, which suggests
6552 it needs to be rethought.
6554 * setup.py (setup): bump version to 0.3.1+ while between releases
6556 2003-04-29 Brian Warner <warner@lothar.com>
6558 * setup.py: Releasing buildbot-0.3.1
6560 2003-04-29 Brian Warner <warner@lothar.com>
6562 * README (SUPPORT): add plea to send questions to the mailing list
6564 * NEWS, MANIFEST.in: add description of recent changes
6566 * docs/examples/twisted_master.py: add the code used to create the
6567 Twisted buildmaster, with passwords and such removed out to a
6570 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
6571 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
6572 buildmasters to not require CVSToys be installed.
6573 * README, docs/examples/glib_master: update to match the change
6575 * buildbot/clients/base.py, buildbot/bot.py,
6576 buildbot/changes/changes.py, buildbot/pbutil.py: copy
6577 ReconnectingPB from CVSToys distribution to remove CVSToys
6578 dependency for build slaves and status clients. Buildmasters which
6579 use FreshCVSSources still require cvstoys be installed, of course.
6581 2003-04-25 Brian Warner <warner@lothar.com>
6583 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
6584 runTestsRandomly arg to turn on trial -z
6586 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
6587 experimental code to use trial's machine-parseable output to get
6588 more detailed test results. Still has some major issues.
6589 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
6592 * buildbot/status/builder.py (Builder.setCurrentBuild):
6593 anticipating moving build history into statusbag, not used yet
6595 * buildbot/status/tests.py: code to centralize test results,
6596 doesn't work quite yet
6598 * buildbot/status/event.py (Event): use hasattr("setName") instead
6599 of isinstance for now.. need better long-term solution
6601 * buildbot/status/html.py: Remove old imports
6603 2003-04-24 Brian Warner <warner@lothar.com>
6605 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
6606 ignore changes under doc/fun/ and sandbox/
6608 * buildbot/process/step_twisted.py: update pushEvent and friends.
6610 * buildbot/status/html.py (Box.td): replace event.buildername with
6611 event.parent.getSwappableName(). Needs more thought.
6613 * buildbot/status/builder.py (Builder): Replace pushEvent and
6614 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
6615 Tell events they are being pruned with event.delete().
6617 * buildbot/process/base.py (Build): Remove Builder status-handling
6618 methods. s/pushEvent/setCurrentActivity/.
6620 * buildbot/process/step.py (BuildStep): clean up status delivery.
6621 Gouse builder.statusbag methods instead of intermediate builder
6622 methods. s/updateLastEvent/updateCurrentActivity/.
6623 s/finalizeLastEvent/finishCurrentActivity/. Use
6624 addFileToCurrentActivity for summaryFunction.
6626 * buildbot/status/event.py (Logfile): put data in a Swappable when
6628 (Event): add more setter methods. Remove .buildername, use .parent
6629 and getSwappableName instead (needs more thought).
6631 * buildbot/util.py (Swappable):
6632 * test/test_swap.py: don't bother setting filename at __init__
6633 time, do it later. Change setFilename args to take parent first,
6634 since it provides the most significant part of the filename.
6636 2003-04-23 Brian Warner <warner@lothar.com>
6638 * buildbot/status/event.py (Logfile.addEntry): append to previous
6641 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
6642 anticipating Swappable
6643 (InternalShellCommand.remoteUpdate): split out various log-adding
6644 methods so subclasses can snarf stdout separately
6646 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
6647 in anticipation of Swappable build logs
6648 (Builder.testsFinished): anticipating TestResults, still disabled
6650 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
6653 * buildbot/status/event.py (Logfile): add (disabled) support for
6654 Swappable, not ready for use yet
6656 * buildbot/util.py (Swappable): object which is swapped out to
6657 disk after some period of no use.
6658 * test/test_swap.py: test buildbot.utils.Swappable
6660 2003-04-14 Brian Warner <warner@lothar.com>
6662 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
6663 periodic-build timer. Set the .periodicBuildTime on a builder
6664 instance to some number of seconds to activate it.
6666 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
6668 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
6669 a way that survives result tuples
6671 2003-04-12 Brian Warner <warner@lothar.com>
6673 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
6674 return a dict instead of a tuple: allow summarizers to provide
6675 multiple summaries if they want
6676 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
6677 (debuildSummarizer): summarize lintian warnings/errors
6679 2003-04-10 Brian Warner <warner@lothar.com>
6681 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
6683 2003-04-09 Brian Warner <warner@lothar.com>
6685 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
6686 empty summaries: happens when the tests fail so hard they don't emit
6687 a parseable summary line.
6689 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
6690 Allow summaryFunction to return None to indicate no summary should
6693 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
6694 writing to stale HTTP requests: notice when they disconnect and
6695 remove the request from the list. Also add CacheToFile from
6696 moshez, will be used later.
6698 2003-04-08 Brian Warner <warner@lothar.com>
6700 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
6701 should be an int, not a list of strings
6703 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
6704 if we weren't actually connected
6706 * buildbot/process/step_twisted.py (trialTextSummarizer): function
6707 to show the tail end of the trial text output
6709 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
6710 hook to summarize the results of a ShellCommand
6712 2003-04-07 Brian Warner <warner@lothar.com>
6714 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
6715 twisted test suite code into a single class.
6716 * buildbot/process/process_twisted.py: same
6718 2003-04-04 Brian Warner <warner@lothar.com>
6720 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
6722 * README (SLAVE): document use of mktap to create slave .tap file
6723 (REQUIREMENTS): describe dependencies
6725 * buildbot/bb_tap.py, buildbot/plugins.tml:
6726 * buildbot/bot.py (updateApplication): Add mktap support for creating
6727 buildslave .tap files
6729 2003-03-28 Brian Warner <warner@lothar.com>
6731 * buildbot/process/step.py (InternalShellCommand.finished): handle
6732 new tuple result values (fix embarrasing bug that appeared during
6735 2003-03-27 Brian Warner <warner@lothar.com>
6737 * docs/examples/glib_master.py, README: add sample buildmaster.tap
6740 2003-03-25 Brian Warner <warner@lothar.com>
6742 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
6743 to overall build status
6744 * buildbot/clients/base.py (Builder): improve event printing
6745 * buildbot/process/base.py (BasicBuildFactory): use specific steps
6746 instead of generic ShellCommand
6747 (Build): Add .stopBuild, use it when slave is detached
6749 * buildbot/process/step.py (Configure,Test): give the steps their
6750 own names and status strings
6752 * buildbot/status/html.py (StatusResource): add "show" argument,
6753 lets you limit the set of Builders being displayed.
6755 2003-03-20 Brian Warner <warner@lothar.com>
6757 * buildbot/process/basic.py: removed
6759 2003-03-19 Brian Warner <warner@lothar.com>
6761 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6762 turn off process-docs by default
6764 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
6765 when displaying build information without anything in allBuilds[]
6767 * buildbot/bot.py (makeApp): really take password from sys.argv
6769 2003-03-18 Brian Warner <warner@lothar.com>
6771 * buildbot/bot.py (buildApp): take password from sys.argv
6773 * README: replace with more useful text
6775 * setup.py: add a real one
6776 * MANIFEST.in, .cvsignore: more distutils packaging stuff
6778 * docs/PyCon-2003/: added sources for PyCon paper.
6780 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
6781 now Build objects control the process and Builder only handles
6782 slave stuff and distribution of changes/status. A new BuildFactory
6783 class creates Build objects on demand.
6785 Created ConfigurableBuild which takes a list of steps to run. This
6786 makes it a lot easier to set up a new kind of build and moves us
6787 closer to being able to configure a build from a web page.
6789 * buildbot/process/step_twisted.py, process_twisted.py: move to
6790 new model. A lot of code went away.
6792 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
6793 send lots of empty progress messages to the client.
6795 * buildbot/master.py (makeApp): enforce builder-name uniqueness
6797 2003-02-20 Brian Warner <warner@lothar.com>
6799 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
6801 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
6802 Twisted bug that prevented non-pty processes from working just got
6803 fixed, and the bug that leaks ptys is still being investigated.
6805 * buildbot/process/step.py (CVS): send timeout arg to slave
6807 * buildbot/clients/gtkPanes.py: add connection-status row, handle
6808 builders coming and going
6809 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
6810 from CVSToys, handle lost-buildmaster
6812 * buildbot/status/client.py (StatusClientService.removeBuilder):
6813 Clean up status client protocol: send builders (with references)
6814 as they are created, rather than sending a list and requiring the
6815 client to figure out which ones are new.
6816 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
6817 attempts to force a build on an unknown builder
6819 2003-02-19 Brian Warner <warner@lothar.com>
6821 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
6822 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
6823 Twisted stops leaking them.
6824 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
6825 builder goes to an idle state.
6827 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
6828 I figure out why CVS commands hang without them, and/or I fix the
6829 hung-command timeout
6831 2003-02-16 Brian Warner <warner@lothar.com>
6833 * buildbot/process/step_twisted.py: bin/hlint went away, replace
6834 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
6835 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
6836 GenerateDocs now that they are prefixed with WARNING:.
6838 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
6839 use manual href target instead of request.childLink
6841 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
6842 display every second, but update the ETA every 5 seconds (or
6843 whenever) as remote_progress messages arrive.
6846 2003-02-12 Brian Warner <warner@lothar.com>
6848 * *: import current sources from home CVS repository
6852 # add-log-time-format: add-log-iso8601-time-string