1 2007-09-29 Brian Warner <warner@lothar.com>
3 * buildbot/scripts/runner.py (stop): increase the timeout from 5
4 seconds to 10, to give heavily loaded machines a better chance to
5 finish shutting down. Addresses (partially) #68.
6 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
8 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
9 * buildbot/scripts/startup.py (Follower._failure): update message
11 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
12 team, to fix some bugs and avoid the use of blocking urlopen().
14 * buildbot/test/test_bonsaipoller.py: same
16 2007-09-28 Brian Warner <warner@lothar.com>
18 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
19 argument, to send email about buildslaves which are disconnected
20 for more than an hour. Closes #64.
21 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
23 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
24 (MailNotifier): add docs for this too
27 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
28 respect branch= queryargs, by restricting the builds displayed to
29 those matching the given branch names
30 * buildbot/status/web/waterfall.py (BuildTopBox): same
32 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
33 fix a test failure by adding .prepath to this fake object
35 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
36 up generation of relative URLs. With luck, this should play with
37 reverse proxies much better now.
38 * buildbot/test/test_webparts.py: new test for most of the subpages
39 * buildbot/test/test_web.py (base_config): add enough of a config
40 to exercise more Waterfall code
42 2007-09-27 Brian Warner <warner@lothar.com>
44 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
45 relative URL to the buildbot welcome page, rather than
47 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
49 * buildbot/status/web/base.py (HtmlResource.title): change the
50 default title of all Buildbot-generated page to "Buildbot"
51 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
52 change the title to include the Builder name
53 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
54 same, and also show the build number
55 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
56 redirect the browser to the Builder page
58 2007-09-26 Brian Warner <warner@lothar.com>
60 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
61 problem with the build links
63 2007-09-25 Brian Warner <warner@lothar.com>
65 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
66 to emit relative URLs instead of using URLPath,
68 * docs/buildbot.texinfo (WebStatus): provide an example
70 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
71 page, shows a simple table with one row per Builder. Still pretty
73 * buildbot/status/web/index.html: reference it
75 * buildbot/status/web/waterfall.py (Spacer): make this *not*
76 inherit from builder.Event, so that show_events=false doesn't hide
77 spacers, since that would make the waterfall weirdly compressed.
79 * buildbot/status/web/waterfall.py (HELP): put the View button in
80 its own section, so it doesn't get visually confused with the
82 (WaterfallStatusResource.body): make the '[help]' links more
83 visually distinct from each other, and add a link to the Welcome
85 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
86 unused buildslaves without exploding
88 * buildbot/status/web/waterfall.py
89 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
90 it gives us absolute paths that break proxies
91 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
92 this, it was giving bad results when the Waterfall is behind a
95 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
96 new 'upgrade-master' command, which will bring an old buildmaster
97 directory up-to-date. Right now the only thing it does is populate
98 public_html/ if it wasn't already there. Still to do: check the
99 other files, add documentation.
100 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
101 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
103 2007-08-13 Brian Warner <warner@lothar.com>
105 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
106 that contains the checkin comments when you hover over the entry
107 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
110 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
113 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
114 page with versions of python, buildbot, and twisted
115 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
116 * buildbot/status/web/index.html: add links to most pages
117 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
119 * buildbot/status/web/robots.txt: put a robots.txt in new installs
120 which discourages robot access to all large dynamically-generated
121 pages. The intention is that the index page and the 'about' page
122 are the only ones which should be crawlable.
123 * buildbot/scripts/runner.py (Maker.public_html): same
125 * setup.py: ship index.html and robots.txt in source distributions
127 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
128 activate automatic reloading of the page (using a meta Refresh:
130 (WaterfallHelp): new page to explain all the nifty query arguments
131 you can use on the Waterfall, along with forms to set them for
132 you. From this page, you can add filters for builder=, branch=,
133 show_events=, as well as turning on reload=.
134 (WaterfallStatusResource.buildGrid): new query args: last_time=,
135 first_time=, show_time=, num_events= . The old show= is still
136 accepted, but the new builder= is preferred. We ignore empty
137 branch= arguments, to make the WaterfallHelp form easier to
139 (WaterfallStatusResource.head): new method to add text to the
141 * buildbot/status/web/base.py (HtmlResource.content): use head()
142 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
143 empty branch= arguments
144 (OneLinePerBuildOneBuilder.body): same
146 2007-08-12 Brian Warner <warner@lothar.com>
148 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
149 new query args: 'last_time' is a timestamp of the top-most event
150 on the display, 'first_time' is a timestamp for the bottom-most
151 event. 'show_time' is the difference between them, and overrides
152 'first_time'. 'num_events' puts an upper limit on the number of
153 timestamps that will be displayed on the left hand edge.
154 (WaterfallStatusResource.body): add a 'next page' link to the
155 bottom, which shows the events that come just after those shown on
156 the current page. This is a first step towards #67, but we need
157 some more controls before we can close that one.
159 * buildbot/buildslave.py (BuildSlave): these are now MultiService
160 instances too, and live as children of the BotMaster. The main
161 advantage of this approach is that BuildSlaves can know when they
162 are being removed (so they can shut off the upcoming
163 when-do-we-email-an-admin-because-we-lost-our-slave timer).
164 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
165 identify which service children are BuildSlaves
166 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
167 Checker updates here, but delegate the rest to..
168 (BotMaster.loadConfig_Slaves): .. here, which looks at the
169 BotMaster's service children to identify the old slaves. I think
170 the previous approach of using master.slaves was broken in the
171 face of config updates that modified BuildSlave instances but did
172 not completely replace them.
173 * docs/buildbot.texinfo (Developer's Appendix): note the change to
174 the Service hierarchy
176 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
177 page (at URL /buildslaves/) to view status of all buildslaves at
178 once, including how long it's been since we last heard from them,
179 and which Builders use them.
181 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
184 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
187 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
188 use the BuildSlave to keep track of the last time we've heard from
189 the buildslave. This is updated upon receipt of any message from
190 any SlaveBuilder (which generally means when RemoteCommands are
191 giving us status updates, as BuildSteps run). In the future this
192 will include slave pings too.
193 * buildbot/process/base.py
194 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
195 * buildbot/process/buildstep.py:
196 (BuildStep.setBuildSlave): accept that reference
197 (BuildStep.runCommand): pass the reference on to the RemoteCommand
198 (RemoteCommand.remote_update): update the timestamp
199 (RemoteCommand.remote_complete): same
200 * buildbot/test/runutils.py (StepTester.makeStep): match the change
201 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
202 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
203 interface to retrieve this timestamp
204 * buildbot/status/builder.py (SlaveStatus): track a copy of the
208 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
210 (OneLinePerBuild.body): use a <ul> instead of <div>s
211 (OneLinePerBuildOneBuilder.body): same
213 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
214 by adding the file's new name to the list of changed files. This
215 ought to be sufficient for things like isFileImportant and trial
216 tests that only exercise tests for files that have been modified.
219 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
220 XMLRPC server to the WebStatus page. This only has two methods
221 right now (getAllBuildsInInterval and getBuild), but we'll be
222 adding more in the future. This server is extracted from the
225 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
226 generateFinishedBuilds, and improve the data displayed.
227 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
228 the per-Build page, add some information like ETA and got_revision
229 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
230 adding a list of recently completed builds
231 * buildbot/status/web/base.py (css_classes): factor this out
233 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
234 new method, to make status display classes easier to write,
235 especially the WebStatus 'one_line_per_build' page.
236 (IBuilderStatus.generateFinishedBuilds): same
237 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
238 (Status.generateFinishedBuilds): implement it
240 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
241 'source' to be a BuildStep instance, since BuildFactory accepts
243 (CPAN.__init__): same
244 (Distutils.__init__): same
245 (Trial.__init__): same
247 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
248 this might raise KeyError
250 2007-08-07 Brian Warner <warner@lothar.com>
252 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
253 'Owner:' field of the view, rather than 'p4logname', since
254 p4logname comes from the buildslave's environment and seems
255 unlikely to ever do the right thing. Thanks to Wade Brainerd for
256 the patch. Closes #40.
258 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
259 which imposes a per-slave limit on how many builds are allowed to
260 run simultaneously. This has a the same scope than the SlaveLock,
261 but is different because max_builds= gives the buildmaster the
262 freedom to assign the build to a different slave, whereas the
263 SlaveLock doesn't get tested until after the build is irrevocably
264 assigned to a slave. Therefore using max_builds= will improve
265 utilization in the presence of multiple buildslaves that are
266 attached to the same Builder. This completes the incorporation of
267 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
268 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
269 any Builder finishes, potentially trigger *all* Builders, since
270 max_builds= may have stalled someone else while waiting for the
272 * buildbot/scripts/sample.cfg: mention max_builds=
273 * buildbot/test/test_run.py (ConcurrencyLimit): test it
274 * docs/buildbot.texinfo (Buildslave Specifiers): document it
276 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
277 inherit from RunMixin do not need to call master.stopService()
278 themselves, since RunMixin.tearDown does that. The double call
279 fails on Twisted-2.0.x, which didn't happen to protect against it.
280 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
282 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
283 from #48, this one to have the BuildSlave objects track
284 SlaveBuilders, so they'll be able to use that knowledge to
285 influence their canStartBuild() response.
286 * buildbot/process/builder.py (SlaveBuilder.attached): call it
287 (SlaveBuilder.detached): same
288 * buildbot/test/test_slaves.py (BuildSlave): test it
290 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
291 the second of Dustin's #48 patches, this one adding a method to
292 the BuildSlave that allows it to decide whether it is willing to
293 participate in a build or not.
294 (SlaveBuilder.isAvailable): use canStartBuild() to decide
296 * buildbot/test/test_run.py (CanStartBuild): test for it
298 * all: incorporate the first of four patches by Dustin Mitchell
299 from ticket #48, working towards improving control over slave
300 concurrency. The first patch is to use a long-lived BuildSlave
301 object per slave, on which other behavior can be added later. I've
302 modified his patch considerably.
303 * buildbot/buildslave.py (BuildSlave): move class out of
304 slave/__init__.py (where it would get loaded by the slave as well
305 as the master, making dependencies trickier), and merge it with
306 BotPerspective. Now these BuildSlave instances are created once in
307 the master.cfg file, and not destroyed until they are either
308 removed from the config file or changed so
309 much (name/password/class changes) that we cannot continue to use
310 the old one. This affects config files: they must use
311 'from buildbot.buildslave import BuildSlave' instead of using
312 'from buildbot.slave import BuildSlave'.
313 * buildbot/master.py: move BotPerspective out
314 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
315 add or remove as necessary, update the rest using data from
317 * buildbot/slave/__init__.py: move BuildSlave out
318 * buildbot/test/test*.py: import BuildSlave from the new place
319 * buildbot/scripts/sample.cfg: update to match
320 * docs/buildbot.texinfo: update to match
321 * buildbot/process/builder.py: update comments to match
323 2007-08-02 Brian Warner <warner@lothar.com>
325 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
326 one-line-per-build pages a bit, add a header, refactor slightly
328 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
329 the TimeOutError timer, patch by Dustin Mitchell.
331 2007-08-01 Brian Warner <warner@lothar.com>
333 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
334 mostly work (branch= is still ignored, we need a useful header)
335 (OneLinePerBuildOneBuilder.body): this too
337 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
338 bring this up-to-date w.r.t. recent refactorings, and fix
339 redirections to bounce the browser to the top page after hitting
340 the 'force' button. This needs to be improved, but at least it now
341 redirects to a valid page.
342 (StatusResourceBuilder.ping): same
343 (StatusResourceBuilder.getChild): same, although I think this code
344 might be dead anyways
346 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
347 a branch= query argument, to filter the display down to builds and
348 changes that involve the given branch. You can add multiple
349 branch= arguments to see multiple branches (using a logical OR).
350 Note that there is no way to include the default branch (i.e.
351 None, i.e. trunk) yet, there is still work to be done to allow for
352 simple+uniform names of branches (i.e. removing the VC-specific
353 details of how branches are implemented, so calling the branch
354 'beta4' even though the SVN checkout step requires
356 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
357 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
358 * buildbot/interfaces.py (IEventSource.eventGenerator): same
359 * docs/buildbot.texinfo (Buildbot Web Resources): document it
361 * all: bring import statements up-to-date: don't import
362 __future__, assume cPickle and cStringIO are always available.
363 Also remove #!/usr/bin/python lines from non-scripts, my editor
364 has been a bit over-enthusiastic about stuffing them into new .py
367 * buildbot/status/web/index.html: put a link to the waterfall page
368 on the index, otherwise first-time users of WebStatus aren't going
369 to see anything very interesting.
371 * buildbot/interfaces.py (IEventSource): document this interface.
372 Thanks to Dustin Mitchell for the patch. Closes #60.
373 * buildbot/status/builder.py (BuilderStatus): same
374 * buildbot/changes/changes.py (ChangeMaster): same
376 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
377 add a query arg of 'show_events=true' to display non-build events,
378 like slaves attaching/detaching and reconfig events, or
379 'show_events=false' to hide them. The default is 'true'.
380 * docs/buildbot.texinfo (Buildbot Web Resources): document it
382 * web-parts: merge in web-parts branch. Lots of changes. The new
383 functionality is to add buildbot.status.html.WebStatus, which is a
384 superset of the Waterfall that adds new status pages and serves
385 regular files from BASEDIR/public_html/ , which is now the preferred
386 place to put robots.txt, buildbot.css, and index.html .
387 * buildbot/scripts/runner.py: the 'create-master' command now
388 creates public_html/ too, and populates it with a couple of
390 * buildbot/status/web: split waterfall code into smaller pieces
392 2007-07-31 Brian Warner <warner@lothar.com>
394 * buildbot/scripts/startup.py (launch): import twistd.run in a
395 different way to hush pyflakes
396 * buildbot/process/builder.py: remove unused import
398 2007-07-30 Brian Warner <warner@lothar.com>
400 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
401 Mitchell: pass SourceStamps around rather than branch/version/etc
402 tuples. Thanks Dustin! Closes #70.
403 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
404 tuple rather than a list, to avoid surprising mutations
405 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
406 * buildbot/status/mail.py (MailNotifier.buildMessage): same
407 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
408 * buildbot/test/test_status.py (Subscription): same
409 * buildbot/test/test_control.py (Force): same
410 * buildbot/test/test_buildreq.py (Request.testMerge): same
412 2007-07-29 Brian Warner <warner@lothar.com>
414 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
415 variable, since it wasn't used and is confusing in the presence of
416 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
419 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
420 the Buildbot home-page link to point at buildbot.net instead of
421 sourceforge, and add a current-version query parameter so we can
422 get some statistics on which versions are in use out there.
424 2007-07-28 Brian Warner <warner@lothar.com>
426 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
427 with c['change_source'], leaving c['sources'] for backwards
428 compatibility (but deprecated), scheduled for removal in 0.8.0
429 * docs/buildbot.texinfo: same
430 * buildbot/test/test_config.py: verify that c['sources'] still works
431 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
432 * buildbot/scripts/sample.cfg: update to match
434 * buildbot/changes/mail.py (MaildirSource): parse with python's
435 stdlib 'email' module, which has been available since python2.2,
436 and drop use of the 'rfc822' module, which has been depreceated
438 * buildbot/test/test_maildir.py: same: use parse_file() not parse
440 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
441 this needs to match the renaming in test/mail/msg*
443 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
446 * buildbot/test/test_mailparse.py: rename sample emails a bit
447 * buildbot/test/mail/msg*: same
449 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
450 parser for the "commit-email.pl" script that is shipped with SVN,
451 written by Justin Mason. Thanks! Closes SF#1072845.
452 * buildbot/test/mail/svn-commit.*: sample messages
453 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
454 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
456 2007-07-27 Brian Warner <warner@lothar.com>
458 * buildbot/changes/mail.py: refactor: move parsing into a method
459 named 'parse', each parser type gets a separate subclass. Remove
460 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
461 to be a simple leading-substring match. Add a warning to the logs
462 if prefix= does not end in a slash, since that's probably a
463 mistake. Fix both places where a prefix= mismatch would skip all
464 subsequent files in the same email, instead of just skipping the
465 one that didn't match.
466 * buildbot/test/test_mailparse.py: match changes
468 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
469 docs on email-based ChangeSources
471 * docs/buildbot.texinfo (Getting Source Code Changes): move all
472 the changesource types up a level, removing the one-entry menu in
475 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
476 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
477 instances instead of tuples. Closes #63.
478 * buildbot/slave/__init__.py (BuildSlave): define marker class
479 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
480 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
481 * buildbot/test/test_*.py: update tests to match
482 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
483 the c['bots'] backwards-compatibility handler works
485 2007-07-26 Brian Warner <warner@lothar.com>
487 * buildbot/changes/hgbuildbot.py (hook): add an in-process
488 Mercurial change-sending hook, contributed by Frederic Leroy.
489 Thanks! Addresses #50.
490 * docs/buildbot.texinfo (MercurialHook): document it
492 * buildbot/changes/hgbuildbot.py: change the way imports are done,
493 to make it compatible with at least hg-0.9.1 and the current 0.9.4
495 2007-07-17 Brian Warner <warner@lothar.com>
497 * buildbot/process/buildstep.py (BuildStep.getLog): add a
498 convenience method to retrieve a log added with
499 addLog()/addCompleteLog()/etc or logfiles= . I should have added
502 2007-07-03 Brian Warner <warner@lothar.com>
504 * buildbot/slave/commands.py (ShellCommand._startCommand): when
505 logging the environment variables, put one variable on each line,
506 rather than having one really long line with all of them. This
507 should make them a bit more readable and not trigger the
508 horizontal scrollbar (when viewing it in a web browser) quite so
509 much. Thanks to Albert Hofkamp for the patch.
511 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
512 WithProperties instance. Thanks to Axel Hecht for the patch.
514 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
515 * docs/buildbot.texinfo (Build Properties): document it
516 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
517 workdir if it didn't already exist.
519 * docs/buildbot.texinfo (Scheduler Types): correct the description
520 of Dependent schedulers. Thanks to Greg Ward for the patch.
522 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
523 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
524 the patch. Closes #49.
526 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
527 0700 before removing it, to deal with situations where a build will
528 leave files around without write permissions and the 'copy' or
529 'clobber' VC checkout modes need to blow away the tree first.
530 Thanks to Steve Milner for the suggestion and the patch (which I
531 mangled horribly). Closes #29.
532 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
535 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
536 an allowReconnect= argument to let callers control whether they
537 want this don't-let-it-reconnect behavior, since some tests care.
538 Factor out the .continueTrying=False lines from those callers.
539 * buildbot/test/test_slaves.py: same
540 * buildbot/test/test_run.py: same
542 2007-07-02 Brian Warner <warner@lothar.com>
544 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
545 slave has been disappeared, don't let it reconnect. This was
546 causing an intermittent failure in test_slaves.py, when the slave
547 that was supposed to be gone managed to come back by the end of
548 the test and affect the count.
549 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
551 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
552 diagnostic messages to track down this problem
553 (Builder.startBuild): same
555 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
556 the slave randomly rather than always taking the first one. Thanks
557 to Pike for the patch. Closes #36.
558 * buildbot/test/test_slaves.py: match the change. to avoid huge
559 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
560 enables/disables the round-robin-ness (enabled by default), and
561 some unit tests disable it.
562 * docs/buildbot.texinfo (Buildmaster Architecture): document it
564 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
565 argument to 'buildmaster_host', to make it more obvious that this
566 points to the buildmaster. Thanks to Bob Proulx for the
568 * buildbot/scripts/runner.py (slaveTAC): same
569 * buildbot/test/test_runner.py (Create.testSlave): match the change
571 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
574 2007-06-17 Brian Warner <warner@lothar.com>
576 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
577 we can round-trip all of our current step classes by calling
578 getStepFactory() and using the results to make a clone of the
581 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
584 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
585 the config file, we're moving to using actual instances instead of
586 the (class, kwargs) 'step specification' tuples. BuildFactory
587 still keeps a list of tuples internally, but when real instances
588 are passed in to addStep(), they are asked for their class and
589 kwargs using the new BuildStep.getStepFactory method. BuildFactory
590 accepts both instances and the tuple form, and converts instances
591 to the tuple form, but the instance form is preferred because it
592 gives the Steps a chance to do argument validation. Closes: #11.
594 * buildbot/process/buildstep.py (BuildStep.__init__): record the
595 factory information necessary to implement getStepFactory. The
596 addFactoryArguments() method can be used to include arguments that
597 aren't passed to the BuildStep base class constructor.
598 (BuildStep.setBuild):
599 (BuildStep.setDefaultWorkdir): new methods to take parameters that
600 are needed for live BuildSteps but not to construct the specification
601 tuples that are stashed in the factory.
603 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
604 'workdir' into new BuildSteps by using methods instead of
605 arguments. This makes the constructor for BuildSteps a lot
608 * buildbot/steps/*.py: update to match this change. Basically this
609 means adding calls to addFactoryArguments() in the __init__
610 methods to capture the arguments that aren't passed through to the
612 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
613 the new workdir (if any) into the RemoteShellCommands arguments.
614 * buildbot/steps/source.py: allow workdir= to be optional,
615 implement setDefaultWorkdir() since we don't inherit from
616 (CVS): finally remove old clobber=/export=/copydir= arguments,
617 in favor of the mode= argument that's been around forever now.
618 * buildbot/steps/transfer.py: remove build= argument
620 * buildbot/test/*.py: update to match, generally by turning all
621 build= arguments into subsequent calls to s.setBuild()
622 * buildbot/test/test_config.py (Factories): verify that we can
623 use either BuildStep instances or class/kwarg tuples in both
624 BuildFactory.addStep and BuildFactory.__init__
626 * docs/buildbot.texinfo (Build Steps): document the new approach,
627 mention compatibility with the old approach, update all examples
628 to use the new style.
630 2007-06-16 Brian Warner <warner@lothar.com>
632 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
633 the LoopingCall, just eat the failure so that we'll poll again
634 next time. This should allow us to tolerate (e.g.) sf.net SVN
635 failures more gracefully. Many thanks to Dustin Mitchell for the
638 2007-05-17 Brian Warner <warner@lothar.com>
640 * buildbot/status/words.py: refactor the IRC status bot into
641 separate 'Contact' and 'Channel' classes. The base Contact class
642 contains the interaction code: commands and responses. The
643 IRCContact subclass (and IrcStatusBot 'Channel') handle the
644 IRC-specific aspects. The plan is to write other subclasses for
645 other IM protocols like AIM and Jabber.
647 2007-04-16 Brian Warner <warner@lothar.com>
649 * CREDITS: update list of contributors. Thank you all!
651 2007-04-13 Brian Warner <warner@lothar.com>
653 * buildbot/status/mail.py (MailNotifier): add the project name to
654 the subject line and message body, to make it easier to
655 distinguish email coming from different buildmasters. Thanks to
656 Benoit Sigoure for the patch.
657 * buildbot/test/test_status.py (Mail): update to match
659 2007-03-24 Brian Warner <warner@lothar.com>
661 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
662 avoid text-conversion problems between DOS/windows and unix.
663 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
665 2007-03-03 Brian Warner <warner@lothar.com>
667 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
668 warning about the use of Waterfall here
670 2007-03-01 Brian Warner <warner@lothar.com>
672 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
674 2007-02-28 Brian Warner <warner@lothar.com>
676 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
677 Lamb to use a more optimal form of 'p4 changes', to reduce server
678 load. He reports that this optimization was added to p4d release
679 2005.2, but it should work in all versions. Closes #27.
680 * buildbot/test/test_p4poller.py: match it
682 2007-02-27 Brian Warner <warner@lothar.com>
684 * buildbot/status/web/*.py: move all web status stuff into a
685 separate directory, in anticipation of splitting it into smaller
686 pieces and adding more files. html.py was getting way too big.
687 * buildbot/status/classic.css: move it too
688 * setup.py: add the new sub-package
689 * buildbot/test/test_web.py: match the changes
690 * MANIFEST.in: handle the move of classic.css
692 2007-02-07 Brian Warner <warner@lothar.com>
694 * contrib/OS-X/*: add some launchd .plist files for automatically
695 starting a buildmaster or buildslave under OS-X (10.4 or later).
696 Thanks to Mark Pauley for these.
698 2007-02-06 Brian Warner <warner@lothar.com>
700 * docs/buildbot.texinfo (Requirements): update requirements to
701 stop claiming compatibility with python-2.2 or twisted-1.3.x .
703 * README: mention python-2.5 and twisted-2.5 compatibility
705 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
707 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
709 * buildbot/status/builder.py: same, by requiring cStringIO
710 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
711 * buildbot/test/test_vc.py: same
712 * buildbot/test/test_web.py:
713 * buildbot/test/test_steps.py: same, remove unused import
715 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
718 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
719 see any Builders that don't have Schedulers to drive them
721 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
722 attributes this uses went away
724 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
725 dialog, to allow you to reset the buildmaster and force
726 connect/disconnect. Correctly handle losing the buildmaster
727 connection (by switching the display to the hexnut, at which point
728 you can use the 'Connect' menu item to reconnect).
730 * buildbot/steps/source.py (Source.start): if we're using a patch,
731 add it as a LogFile to the checkout/update step. This will turn
732 into a link on the waterfall page.
734 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
735 option, to take the patch from a pre-made file rather than
736 generating it from the local tree. Thanks to Robert Helmer for the
737 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
738 * buildbot/scripts/runner.py (TryOptions): add --diff,
739 --patchlevel, and --baserev options
740 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
741 as None, meaning HEAD.
742 * buildbot/sourcestamp.py (SourceStamp): update docstring to
743 indicate that baserev=None means HEAD
744 * docs/buildbot.texinfo (try --diff): document it
746 * buildbot/test/test_steps.py (BuildStep): remove use of
747 reactor.iterate(), although the technique I replaced it with is a
748 gross polling hack that must be cleaned up properly some day. This
749 was the last use of reactor.iterate in the entire tree, yay.
751 2007-02-05 Brian Warner <warner@lothar.com>
753 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
754 is one of the three known values, otherwise we emit some confusing
755 messages later on. Thanks to Grig Gheorghiu for the catch.
757 2007-01-30 Brian Warner <warner@lothar.com>
759 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
760 Hearsum contributed a patch to let BonsaiPoller work with results
761 that contain non-ascii characters. Closes SF#1632641.
763 2007-01-27 Brian Warner <warner@lothar.com>
765 * Makefile (release): produce both .tar.gz and .zip source bundles.
768 2007-01-23 Brian Warner <warner@lothar.com>
770 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
771 * buildbot/changes/monotone.py: same
773 * buildbot/changes/maildir.py: combine several files into one,
774 clean up maildir.py to use Services properly.
775 * buildbot/changes/maildirtwisted.py: remove
776 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
778 * buildbot/changes/mail.py: match the change
779 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
780 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
782 * buildbot/slave/commands.py (command_version): bump to "2.3" to
783 indicate that the buildslave knows about the 'bzr' command
785 2007-01-22 Brian Warner <warner@lothar.com>
787 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
788 'with', it will become a reserved work in python2.6 .
790 * contrib/bb_applet.py: add a simple gnome-panel applet, to
791 display a terse summary of buildbot status.
792 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
793 some icons, small versions of the Blender object that lives in
794 docs/images/icon.blend
796 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
797 * buildbot/slave/commands.py (Bzr): same
798 * buildbot/scripts/tryclient.py (BzrExtractor): same
799 (SourceStampExtractor.dovc): modify this to allow non-zero exit
800 status, since 'bzr diff' does that
801 * buildbot/test/test_vc.py (Bzr): same
802 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
806 2007-01-20 Brian Warner <warner@lothar.com>
808 * contrib/darcs_buildbot.py: tidy up the progress messages
810 2007-01-17 Brian Warner <warner@lothar.com>
812 * contrib/darcs_buildbot.py: enhance to handle multiple patches
813 being pushed at a time. This keeps state in the repository in a
814 small file named .darcs_buildbot-lastchange, but that shouldn't
815 interfere with normal repository operations. Fixes SF#1534049.
816 * buildbot/clients/sendchange.py (Sender): make a single Sender
817 capable of sending Changes with different usernames.
819 2006-12-11 Brian Warner <warner@lothar.com>
821 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
822 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
823 buildbot.changes.mail a long time ago, but I forgot to add the
824 DeprecationWarning until now.
826 * buildbot/process/maxq.py: remove this, the functionality now
827 lives in buildbot.steps.maxq
829 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
830 * buildbot/clients/gtkPanes.py: remove unused import
832 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
833 that was meant to provide a special Reporter to run inside trial
834 and give the buildslave lots of machine-readable status. We never
835 finished this project.
837 * buildbot/changes/bonsaipoller.py: remove unused imports
838 * buildbot/changes/svnpoller.py: same
839 * buildbot/process/builder.py: same
840 * buildbot/process/buildstep.py: same
841 * buildbot/slave/bot.py: hush pyflakes warning
842 * buildbot/status/tests.py: remove unused imports
843 * buildbot/status/tinderbox.py: same
844 * buildbot/steps/python_twisted.py: same
846 * buildbot/process/step.py: remove this file, these names were
847 deprecated in 0.7.5 and are now being removed.
848 * buildbot/process/step_twisted.py: same
849 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
851 * buildbot/twcompat.py: remove the empty file, yay it is gone
853 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
854 tw-2.0.0 and newer have the method we need.
855 (getProcessOutputAndValue): same
856 (which): remove this method, tw-2.0.0 t.p.procutils has it
858 * buildbot/twcompat.py (implements): remove this method
859 * buildbot/*: import implements() from zope.interface directly
861 * buildbot/status/mail.py: stop falling back to importing
862 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
865 * buildbot/twcompat.py (Interface): remove this import
866 * buildbot/*: import Interface from zope.interface directly
868 * buildbot/twcompat.py (providedBy): remove this method
869 * buildbot/*: turn all uses of providedBy(obj, iface) into
870 iface.providedBy(obj)
872 * buildbot/twcompat.py (maybeWait): remove this method, now that
873 we no longer maintain compatibility with Twisted<=1.3.0 .
874 Twisted-2.0.0 and later allow trial methods to return Deferreds
876 * buildbot/test/*: remove all uses of maybeWait
878 * buildbot/__init__.py (version): bump to 0.7.5+ while between
880 * docs/buildbot.texinfo: same
882 2006-12-10 Brian Warner <warner@lothar.com>
884 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
885 * docs/buildbot.texinfo: set version to match
887 2006-12-10 Brian Warner <warner@lothar.com>
889 * README (REQUIREMENTS): update for release
890 * NEWS: update for release
891 * buildbot/slave/commands.py (command_version): mention that this
892 version (2.2) was released with buildbot-0.7.5
894 * buildbot/test/test_config.py (StartService.testStartService):
895 inhibit the usual read-config-on-startup behavior, since otherwise
896 the log.err that gets recorded causes the test to fail
898 * buildbot/status/builder.py (LogFile.finish): forget about all
899 subscribers once the log has finished, since after that point
900 we're never going to use them again. This might help free up some
903 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
904 than the old/deprecated gtk.mainquit()
906 2006-12-09 Brian Warner <warner@lothar.com>
908 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
909 better when we can't open the masterdst file
911 * buildbot/scripts/startup.py (Follower._failure): add missing
912 import statement for BuildSlaveDetectedError
914 * buildbot/steps/transfer.py (FileUpload): cleanup
915 (FileDownload): same. Add tests for slave version, add mode=.
916 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
917 (SlaveFileDownloadCommand): same
918 * buildbot/test/test_transfer.py: enhance tests
919 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
922 2006-12-08 Brian Warner <warner@lothar.com>
924 * buildbot/scripts/runner.py (sendchange): halt the reactor on
925 both success *and* failure. Without this, the 'buildbot
926 sendchange' command would hang if it could not contact the
927 buildmaster or deliver the Change, which would generally cause the
928 user's commit/record/checkin command to hang too. Thanks to
929 Christian Unger for the catch.
931 2006-12-06 Brian Warner <warner@lothar.com>
933 * NEWS: update with items for the next release
935 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
936 whimsical example pulled from a punch-drunk email I sent out late
938 (Transferring Files): document some of the other parameters
939 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
940 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
941 * buildbot/test/test_svnpoller.py: same
942 * buildbot/changes/svnpoller.py (SVNPoller): same
944 2006-11-26 Brian Warner <warner@lothar.com>
946 * docs/buildbot.texinfo (Build Properties): remind users that
947 WithProperties must appear in a command= list, not as a top-level
949 * buildbot/steps/shell.py (ShellCommand.start): and assert that
950 we're sending a list or a single string to the RemoteShellCommand
952 * buildbot/scheduler.py (Nightly): Improve docs slightly.
954 * buildbot/scripts/startup.py (start): skip the whole
955 watch-the-logfile thing under windows, since it needs os.fork()
957 * buildbot/scripts/runner.py (restart): remove the old message
958 that got printed after the buildbot was restarted.. it most cases
959 it didn't get printed at the right time anyways
961 2006-11-25 Brian Warner <warner@lothar.com>
963 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
964 follow twistd.log and print lines until the process has started
965 started properly. For the buildmaster, this means until the config
966 file has been parsed and accepted. For the buildslave, this means
967 until we've connected to the master. We give up after 5 seconds in
968 any case. Helpful error messages and troubleshooting suggestions
969 are printed when we don't see a successful startup. This closes the
970 remainder of SF#1517975.
971 * buildbot/scripts/startup.py: moved app startup code to here
972 * buildbot/scripts/logwatcher.py: utility class to follow log
973 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
974 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
975 so the LogWatcher can tell the difference between a buildmaster
978 2006-11-24 Brian Warner <warner@lothar.com>
980 * docs/examples/twisted_master.cfg: update to match the version
981 in use on twistedmatrix.com
982 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
983 was using before stopped working, but 'irc.freenode.net' works
986 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
989 * buildbot/clients/base.py (TextClient.not_connected): upon
990 UnauthorizedLogin failures, remind the user to connect to the
991 PBListener port instead of the slaveport.
992 (TextClient.disconnected): shut down more quietly
993 * docs/buildbot.texinfo (statuslog): add another reminder
995 * buildbot/scripts/runner.py (Options.subCommands): rename
996 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
997 'sighup' as an alias.
998 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
999 reconfig command to follow twistd.log and print all of the lines
1000 from the start of the config-file reload to its completion. This
1001 should make it a lot easier to discover bugs in the config file.
1002 Use --quiet to disable this behavior. This addresses half of
1003 SF#1517975, the other half will be to add this same utility to
1004 'buildbot start' and 'buildbot restart'.
1005 * docs/buildbot.texinfo (Loading the Config File): same
1008 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1009 method, it has been deprecated for a long time. Use
1010 IBuilderControl.requestBuild instead.
1011 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1012 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1013 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1014 * buildbot/test/test_control.py (Force.testForce): same
1015 * buildbot/test/test_run.py: use requestBuild instead
1017 * buildbot/clients/debug.py: replace 'Force Build' button with
1018 'Request Build' (which just adds one to the queue), add Ping
1019 Builder, add branch/revision fields to Request Build.
1020 * buildbot/clients/debug.glade: same
1021 * buildbot/master.py: update interface to match. This creates an
1022 incompatibility between new debugclients and old buildmasters.
1024 * buildbot/process/builder.py (Builder._attached): delay the call
1025 to maybeStartBuild for a reactor turn, to avoid starting a build
1026 in the middle of a reconfig (say, if the new Builder uses a new
1027 slave which is already connected).
1029 2006-11-23 Brian Warner <warner@lothar.com>
1031 * buildbot/test/test_transfer.py: appease pyflakes
1032 * buildbot/test/test_steps.py: same
1034 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1035 keeps pyflakes from finding undefined names
1037 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1038 Builder no longer induces a disconnect/reconnect cycle. This means
1039 that any builds currently in progress will not be interrupted, and
1040 any builds which are queued in the Builder will not be lost. This
1041 is implemented by having the new Builder extract the state (i.e.
1042 all pending Builds and any desired SlaveBuilders) from the old
1044 (BotPerspective): refactor. The BotPerspective no longer keeps
1045 track of all the Builders that want to use this slave; instead, it
1046 asks the BotMaster each time it needs this list. This removes
1047 addBuilder and removeBuilder. Clean up attached() to acquire all
1048 the slave's information in a more atomic fashion. updateSlave() is
1049 now the way to make sure the slave is using the right set of
1050 Builders: just call it after everything else has been
1052 (BotMaster): refactor, removing addBuilder/removeBuilder and
1053 replacing them with an all-at-once setBuilders() call.
1055 * buildbot/test/test_slaves.py (Reconfig): new test case to
1056 exercise this functionality
1057 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1058 * buildbot/slave/commands.py (WaitCommand): same
1060 * docs/buildbot.texinfo (Loading the Config File): document the
1063 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1064 SlaveBuilder to have its parent Builder changed.
1065 (SlaveBuilder.isAvailable): new method to give access to state,
1066 which is now a private attribute
1067 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1068 the SlaveBuilder about how it is being used. These methods update
1069 its internal state. buildFinished() is now the place that invokes
1070 maybeStartBuild() on its parent Builder.
1071 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1072 new Builder to take over for an old one, transferring state from
1074 (Buider): refactor the way that SlaveBuilders are used to match,
1075 giving them a bit more autonomy.
1076 (Builder.buildFinished): this no longer calls maybeStartBuild():
1077 instead the SlaveBuilder calls it on whoever its parent Builder is
1078 at the time. This way, when an old Builder is replaced by a new
1079 one, and there was a build in progress during the transition, when
1080 that build finishes, it will be the new Builder that is told about
1081 the newly available slave so it can start a new build.
1083 * buildbot/process/base.py (Build.startBuild._release_slave): when
1084 the Build finishes, tell the SlaveBuilder that they've been
1087 * buildbot/status/builder.py (SlaveStatus): add some new setter
1088 methods for use by BotPerspective, to keep some attributes more
1091 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1092 called by the buildmaster.
1093 (Bot.setBuilderList): instead, we locally announce any leftover
1094 directories based upon which Builders we were told about. The
1095 master doesn't really care; it's the local admin who may or may not
1096 wish to delete them.
1099 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1100 to allow use of python2.4 or whatever. This tool still requires
1103 2006-11-19 Brian Warner <warner@lothar.com>
1105 * NEWS (IStatusLog.readlines): more news items
1107 2006-11-18 Brian Warner <warner@lothar.com>
1109 * NEWS: start collecting items for the next release.
1111 2006-11-04 Brian Warner <warner@lothar.com>
1113 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1114 Hearsum. Closes SF#1590310.
1115 * buildbot/test/test_bonsaipoller.py: and tests
1117 * buildbot/status/tinderbox.py
1118 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1119 status when the build results in WARNINGS. Patch from Dave
1120 Liebreich. Closes SF#1587352.
1122 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1123 linux-vs-osx behavior difference w.r.t. reading from files that
1124 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1125 to Mark Rowe for the patch.
1127 2006-10-15 Brian Warner <warner@lothar.com>
1129 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1130 method name was misspelled in the interface definition. Thanks to
1131 Roy Rapoport for the catch.
1133 2006-10-13 Brian Warner <warner@lothar.com>
1135 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1136 to match the great Steps renaming
1138 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1139 Maybe I should run my own unit tests before recording a big
1140 change. Good thing I've got a buildbot to remind me.
1142 2006-10-12 Brian Warner <warner@lothar.com>
1144 * buildbot/steps/transfer.py: rework __init__ and args setup
1145 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1147 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1148 when opening the target file, only catch IOError (to report via
1149 stderr/rc!=0), let the others be reported as normal exceptions
1151 2006-10-08 Brian Warner <warner@lothar.com>
1153 * contrib/svn_watcher.py: fix security holes by using proper argv
1154 arrays and subprocess.Popen() rather than commands.getoutput().
1155 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1156 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1157 probably be removed by the next release.
1160 2006-10-04 Brian Warner <warner@lothar.com>
1162 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1163 initial lines that weren't emitted by pyflakes. When the pyflakes
1164 command is run under a Makefile, 'make' will echo the command it
1165 runs to stdio, and that was getting logged as a "misc" warning.
1166 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1167 * buildbot/test/test_steps.py (testPyFlakes3): another test
1169 2006-10-01 Brian Warner <warner@lothar.com>
1171 * buildbot/status/html.py (HtmlResource.render): if we get a
1172 unicode object from our content() method, encode it into utf-8
1173 like we've been claiming to all along. This allows the comments
1174 and author names from svnpoller.py to be delivered properly.
1176 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1177 de-unicodify filenames before creating the Change, because the
1178 rest of buildbot is unlikely to handle them well. Leave the 'who'
1179 field as a unicode object.. I don't think there's anything that
1180 will break very soon, and it will probably nudge us towards
1181 accepting unicode everywhere sooner or later. Stop using the
1182 "date" field that comes out of SVN, since it is using the
1183 repository's clock (and timezone) and what we care about is the
1184 buildmaster's (otherwise Changes from the future show up later
1185 than the builds they triggered).
1186 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1189 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1190 Suvbersion repository polling ChangeSource. I've hacked it up
1191 considerably: any bugs are entirely my own fault. Thank you
1193 * buildbot/test/test_svnpoller.py: tests for it
1194 * docs/buildbot.texinfo (SvnSource): document it
1196 2006-09-30 Brian Warner <warner@lothar.com>
1198 * buildbot/scheduler.py (Periodic): submit a reason= to the
1199 BuildSet to indicate which Scheduler triggered the build. Thanks
1200 to Mateusz Loskot for the suggestion.
1202 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1204 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1205 changes: set self.loop in __init__, remove unused volatile=
1207 * docs/buildbot.texinfo (.buildbot config directory): add more
1208 docs on the .buildbot/options keys used by "buildbot try"
1209 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1210 (Try.deliverJob): same
1212 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1214 (BonsaiPoller): same
1216 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1217 close the filehandle when we stop watching the file. Before, the
1218 filehandle was only closed when the LogFileWatcher was
1219 garbage-collected, which could be quite a while in the future. If
1220 it was still open by the time the next build started, windows will
1221 refuse to let the new build delete the old build/ directory. Fixes
1222 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1223 #twisted for the catch.
1225 2006-09-29 Brian Warner <warner@lothar.com>
1227 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1230 2006-09-25 Brian Warner <warner@lothar.com>
1232 * setup.py: the new buildbot.steps module wasn't being installed.
1233 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1234 (testmsgs): add the extra stuff from buildbot/test/* so you can
1235 run unit tests on an installed copy of buildbot, not just from
1238 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1239 columns of 'svnlook changed' output contain status information, so
1240 strip [:4] instead of [:6]. Depending upon what the status flags
1241 were, this would sometimes lead to mangled filenames. Thanks to
1242 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1244 * buildbot/steps/source.py (Monotone): initial Monotone support,
1245 contributed by Nathaniel Smith. Still needs docs and tests, but
1246 this code has been in use on the Monotone buildbot for a long
1248 * buildbot/slave/commands.py (Monotone): slave-side support
1249 * buildbot/changes/monotone.py (MonotoneSource): polling change
1252 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1253 contributed a Change Source that polls a Bonsai server (a
1254 kind of web-based viewcvs CGI script).
1256 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1257 Hearsum contributed a status plugin which sends email in the same
1258 format that Tinderbox does: this allows a number of tinderbox
1259 tools to be driven by Buildbot instead. Thanks Ben!
1261 2006-09-24 Brian Warner <warner@lothar.com>
1263 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1264 Thanks to Robert Helmer for the patch.
1266 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1267 BuildStatus about the buildslave name at the *beginning* of the
1268 build, rather than at the end. Thanks to Alexander Lorenz for the
1270 * buildbot/status/html.py (StatusResourceBuild.body): always
1271 include the slavename in the build page, not just when the build
1273 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1274 slavename in the email message
1276 2006-09-21 Brian Warner <warner@lothar.com>
1278 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1280 * docs/examples/glib_master.cfg: same
1281 * docs/examples/hello.cfg: same
1282 * docs/examples/twisted_master.cfg: same, update to current usage
1284 2006-09-19 Brian Warner <warner@lothar.com>
1286 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1287 (PyFlakes.createSummary): make it compatible with python-2.2
1289 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1290 for at least the output-parsing parts of PyFlakes
1292 2006-09-18 Brian Warner <warner@lothar.com>
1294 * buildbot/steps/python.py: oops, fix import of StringIO
1296 2006-09-17 Brian Warner <warner@lothar.com>
1298 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1299 turns out that SVN-1.4.0 doesn't fail to update once you've
1300 replaced a file with a directory, unlike older versions of SVN and
1301 pretty much every other VC tool we support. Since what we really
1302 care about is that the update succeeds anyway, stop checking that
1303 the tree got clobbered and just assert that the build succeeded.
1304 (VCBase.printLogs): add a utility function for debugging
1306 * buildbot/process/step.py: oops, added extra imports by mistake
1308 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1309 rstrip() on the first line coming out of the 'p4 describe'
1310 process, to remove the stray ^M that Wade Brainerd reports seeing
1311 in the 'when' field. Fixes SF#1555985.
1313 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1314 message logged when c['schedulers'] is not right
1315 * buildbot/scheduler.py (Scheduler.__init__): improve error
1316 message when a Scheduler() is created with the wrong arguments
1317 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1318 verify that these error messages are emitted
1320 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1321 The idea is that all the base classes (like BuildStep and
1322 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1323 will be a leftover backwards-compatibility file that only contains
1324 aliases for the steps that were moved out to buildbot.steps.*
1325 * lots: change imports to match
1326 * buildbot/process/step.py: add a DeprecationWarning if it ever
1329 2006-09-12 Brian Warner <warner@lothar.com>
1331 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1332 builderNames= is actually a sequence, since if you happen to give
1333 it a single builder-specification dictionary instead, it won't get
1334 caught by the existing assert. Thanks to Brett Neely for the
1337 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1339 * docs/buildbot.texinfo (Python BuildSteps): document them
1340 (sendchange): include a link to PBChangeSource, since you need one
1342 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1344 * buildbot/steps/dummy.py: same
1346 2006-09-08 Brian Warner <warner@lothar.com>
1348 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1349 BuildStep which lets you transfer files from the master to the
1350 slave or vice versa. Thanks to Albert Hofkamp for the original
1351 patch. Fixes SF#1504631.
1352 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1354 (SlaveFileDownloadCommand): same
1355 * docs/buildbot.texinfo (Transferring Files): document it
1356 * buildbot/test/test_transfer.py: test it
1357 * buildbot/test/runutils.py (StepTester): new utility class for
1358 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1359 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1362 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1363 walk through StatusLogs one line at a time, mostly for the benefit
1364 of ShellCommand.createSummary methods. You can either walk through
1365 STDOUT or STDERR, but the default is STDOUT.
1367 * buildbot/status/builder.py (LogFile.readlines): implement it.
1368 Note that this is not yet memory-efficient, it just pulls the
1369 whole file into RAM and then splits it up with a StringIO.
1370 Eventually this should be a generator that only pulls chunks from
1372 * buildbot/test/test_status.py (Log.testReadlines): test it
1374 * docs/buildbot.texinfo: update to match changes
1375 * buildbot/process/factory.py: stop using old definitions
1376 * buildbot/process/process_twisted.py: same
1377 * buildbot/test/test_*.py: same
1379 * buildbot/process/step_twisted.py: move definition to..
1380 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1381 relative-import mechanisms prevent this from being named 'twisted'
1382 or 'python/twisted' as I would have preferred.
1384 * buildbot/process/maxq.py: move definition to..
1385 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1387 * buildbot/process/step.py: split the user-visible BuildSteps into
1388 separate files, all under buildbot/steps/
1389 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1390 * buildbot/steps/shell.py: this holds ShellCommand and friends
1391 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1393 2006-09-05 Brian Warner <warner@lothar.com>
1395 * lots: run pyflakes, removed a lot of unused imports, changed the
1396 form of some conditional imports to remove false pyflakes
1397 warnings. There are still a number of warnings left, mostly from
1398 imports that are done for their side-effects.
1399 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1402 2006-08-26 Brian Warner <warner@lothar.com>
1404 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1405 compatible with twisted-1.3.0, for some reason I just can't seem
1406 to let go of the past.
1408 2006-08-25 Brian Warner <warner@lothar.com>
1410 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1412 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1413 all logfiles= in startCommand(), rather than in start() . This
1414 makes it easier to have the 'stdio' log come before any secondary
1415 logfiles, which I feel makes the waterfall display more
1417 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1418 from ShellCommand up into LoggingBuildStep
1419 (LoggingBuildStep.__init__): move the handling of logfiles= from
1420 ShellCommand up to LoggingBuildStep, because startCommand is
1421 provided by LoggingBuildStep, whereas start() was specific to
1422 subclasses like ShellCommand and Source. This removes code
1423 duplication in those subclasses.
1424 (ShellCommand.__init__): same
1425 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1426 for a slave that's too old to understand logfiles= into a separate
1427 method, so it can live in ShellCommand. The rest of
1428 setupLogfiles() can live in LoggingBuildStep.
1430 2006-08-24 Brian Warner <warner@lothar.com>
1432 * buildbot/locks.py (BaseLock): you can now configure Locks to
1433 allow multiple simultaneous owners. They still default to
1434 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1436 * docs/buildbot.texinfo (Interlocks): document the new options
1437 * buildbot/test/test_locks.py: add a bunch of new unit tests
1438 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1439 waitUntilMaybeAvailable, not waitUntilAvailable
1440 * buildbot/process/step.py (BuildStep.acquireLocks): same
1441 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1442 the whole lockid in their constructor, not just the name. Also,
1443 keep track of which real locks we've handed out by the full
1444 lockid, not just class+name, otherwise changing just the maxCount=
1445 in the master.cfg file would not actually cause a behavioral
1448 2006-08-23 Brian Warner <warner@lothar.com>
1450 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1452 * docs/buildbot.texinfo: same
1454 2006-08-23 Brian Warner <warner@lothar.com>
1456 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1457 * docs/buildbot.texinfo: set version to match
1458 * NEWS: update for 0.7.4
1459 * buildbot/slave/commands.py (command_version): mention that this
1460 version (2.1) was released with buildbot-0.7.4
1462 2006-08-22 Brian Warner <warner@lothar.com>
1466 * CREDITS: new file, list of people who have helped. Thanks!
1467 * MANIFEST.in: ship it
1469 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1470 new diagrams, the user's manual is more informative than it was.
1471 Start shipping the .html user's manual (and generated .png
1473 * Makefile: update 'release' target to match
1475 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1476 test.. I think the web-parts effort will render it pointless well
1477 before it ever actually starts to work.
1479 2006-08-20 Brian Warner <warner@lothar.com>
1481 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1482 meaning of the prefix= argument. It is now just a string which is
1483 stripped from the beginning of the filename. If prefix= is set but
1484 not found on any given filename, that filename is ignored. If all
1485 filenames in a Change are ignored, the Change is dropped. This is
1486 much simpler than the previous sep= nonsense, and I should have
1487 implemented it this way from the beginning. Effectively resolves
1488 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1489 Gedminas for the catch and suggested fixes.
1490 (ChangePerspective.perspective_addChange): implement the actual
1492 * buildbot/test/test_changes.py (TestChangePerspective): test it
1493 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1494 how to properly use prefix=
1495 * docs/examples/twisted_master.cfg (source): update prefix= by
1496 adding the trailing slash
1499 * docs/examples/twisted_master.cfg: update to actual practice
1501 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1502 update test case to match new link text.. the HREF has both a
1503 class= setting and an enclosing [] pair that I didn't match in the
1506 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1507 list of strings is preferred over a single string with embedded
1509 (ShellCommand.description=): explain that either single strings or
1510 a list of strings is acceptable, and why you might prefer one over
1511 the other. Add an example. Fixes SF#1524659, thanks to Paul
1512 Winkler for the catch.
1513 (Build Steps): update to use f.addStep() rather than using s()
1514 and the constructor list
1516 * buildbot/process/step.py (ShellCommand): accept either a single
1517 string or a list of strings in both description= and
1519 * buildbot/test/test_steps.py (Steps.test_description): test it
1520 * buildbot/test/runutils.py (makeBuildStep): support for that test
1522 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1523 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1524 collecting the files and creating the patch.
1526 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1527 per-step URLs that will be displayed on the waterfall display,
1528 for things like the HTML output of code-coverage tools, when
1529 the results are hosted elsewhere.
1530 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1531 way to retrieve these URLs
1532 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1533 the method to retrieve these URLs. Also provide backwards
1534 compatibility for saved BuildStepStatus instances that didn't have
1536 * buildbot/process/step.py (BuildStep.addURL): method to set these
1537 URLs from within a BuildStep
1538 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1539 (StepBox.getBox): give these external links a distinct CSS class
1540 named "BuildStep external" so a .css file can display them
1543 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1545 * buildbot/test/test_steps.py (Steps): test that we can all the
1546 URLs. Also add a bunch of other tests on methods that can be
1547 called from within BuildSteps
1548 * buildbot/test/runutils.py (makeBuildStep): add utility function
1550 2006-08-13 Brian Warner <warner@lothar.com>
1552 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1554 2006-08-10 Brian Warner <warner@lothar.com>
1556 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1557 index, this one of things like c['sources'] and c['schedulers']
1558 (indices): it looks like my clever idea of putting the @fooindex
1559 commands in between the @node and the @subsection (to make the
1560 HREF anchor jump to slightly above the section title, which works
1561 much better in html) confused texinfo horribly, so I'm moving the
1562 index tags back to be just after the @subsection marker. I also
1563 added extra lines between the @node/@section paragraph and the
1564 index tags, since I think maybe texinfo wants to see these be
1565 separate paragraphs.
1567 * docs/Makefile (images): make sure images get built when
1568 rendering the manual
1569 * docs/images/Makefile: same
1571 * buildbot/scripts/runner.py: rename 'buildbot master' to
1572 'buildbot create-master', and 'buildbot slave' to 'buildbot
1574 * docs/buildbot.texinfo: same
1577 * docs/buildbot.texinfo: reimplement the "useful classes" index
1578 with actual texinfo indices. The .info rendering is a bit
1579 weird-looking but it works well, and the HTML rendering is quite
1580 nice. This also puts the index targets in the regular flow of the
1581 text, which is easier to maintain.
1583 2006-08-06 Brian Warner <warner@lothar.com>
1585 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1586 Kevin Turner to prefer the environ= argument be a list rather than
1587 a string. If it is a list, it will be joined with a platform-local
1588 os.pathsep delimiter, and then prepended to any existing
1589 $PYTHONPATH value. This works better in cross-platform (i.e.
1590 windows buildslaves) environments when you need to push multiple
1591 directories onto the front of the path.
1592 (SlaveShellCommand): documented the new magic
1593 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1594 in a user-visible form
1596 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1597 Turner to prefer lists over strings when creating/running VC
1598 commands during unit tests. This is clearly necessary to survive
1599 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1600 renamed the wq() function to qw() though, since that's how it's
1601 spelled in perl. Eventually I'd prefer all commands to be
1602 specified with lists.
1604 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1605 which are deleted (or not yet created) correctly. Also add
1606 failsafe code to not explode if the file-watching poller doesn't
1607 get started. Thanks to JP Calderone for the catch and the poller
1609 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1611 * buildbot/test/emitlogs.py: same
1613 * NEWS: summarize recent changes
1615 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1616 clause to avoid the "host key mismatch" warning
1618 * buildbot/process/step_twisted.py (Trial.start): if the
1619 buildslave is too old to understand logfiles=, fall back to
1620 running 'cat _trial_temp/test.log' like before.
1621 (Trial.commandComplete): same. this takes advantage of the
1622 LoggingBuildStep refactoring to stall commandComplete long enough
1623 to run a second RemoteShellCommand.
1625 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1626 refactor command-completion handling, to allow methods like
1627 commandComplete/createSummary/evaluateCommand to return Deferreds.
1628 (LoggingBuildStep._commandComplete): delete the refactored method
1629 (ShellCommand.setupLogfiles): if the buildslave is too old to
1630 understand logfiles=, put a warning message both into twistd.log
1631 and into the otherwise empty user-visible LogFiles.
1633 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1634 callers to provide the slave-side logfile name, rather than
1635 forcing it to come from the local name of the LogFile.
1636 (BuildStep.getSlaveName): new method
1638 * buildbot/process/base.py (Build.getSlaveName): new method, so
1639 steps can find out which buildslave they're running on
1641 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1642 to match the s/cvs_ver/command_version/ change
1644 2006-08-05 Brian Warner <warner@lothar.com>
1646 * buildbot/slave/commands.py (command_version): replace the CVS
1647 auto-updated cvs_ver keyword with a manually-updated variable,
1648 since CVS is no longer the master repository. Add a description of
1649 the remote API change starting in this version (2.1), specifically
1650 the fact that SlaveShellCommand now accepts 'initial_stdin',
1651 'keep_stdin_open', and 'logfiles'.
1653 2006-07-31 Brian Warner <warner@lothar.com>
1655 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1656 diagrams to describe how the whole system fits together. The
1657 images themselves are kept in SVG files, with ascii-art versions
1658 in corresponding .txt files. Texinfo knows how to interpolate the
1659 text version into .info files, reference the .png versions from
1660 .html files, and include .eps versions in the .ps format.
1661 * docs/images/Makefile: tools to create .png and .eps
1662 * docs/images/*.svg: created pictures with Inkscape.
1663 * .darcs-boring: ignore the generated .eps and .png files
1665 2006-07-24 Brian Warner <warner@lothar.com>
1667 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1668 Scheduler names, since they cause setServiceParent to explode
1670 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1672 2006-07-20 Brian Warner <warner@lothar.com>
1674 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1675 which runs the buildbot unit tests
1677 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1678 classes that are useful in master.cfg
1680 2006-07-15 Brian Warner <warner@lothar.com>
1682 * Makefile (some-apidocs): new target to build only some epydocs
1684 * setup.py: minor comment.. does the classifiers= argument prevent
1685 the setup.py script from working on python2.2/2.3?
1687 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1690 * buildbot/twcompat.py: fix minor typo in comments
1692 * buildbot/manhole.py: move all Manhole-related code out to this
1693 module. Implement SSH-based manholes (with TwistedConch), and move
1694 to conch's nifty line-editing syntax-coloring REPL shell instead
1695 of the boring non-editing monochromatic (and deprecated) old
1697 * buildbot/master.py: remove all Manhole-related code
1698 (BuildMaster.loadConfig._add): make sure the old manhole is
1699 removed before we add the new one
1700 * docs/buildbot.texinfo (Debug options): document new Manhole options
1702 * buildbot/twcompat.py (_which): fix some epydoc issues
1703 * buildbot/status/html.py (Waterfall.__init__): same
1705 2006-06-29 Brian Warner <warner@lothar.com>
1707 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1708 deprecation warnings under newer Twisteds (by using
1709 zope.interface.Interface instead of old twisted.python.components
1711 * buildbot/slave/interfaces.py: same
1713 2006-06-28 Brian Warner <warner@lothar.com>
1715 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1716 svn commands, so it will fail immediately instead of hanging while
1717 it waits for a username/password to be typed in.
1719 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1720 log message if the step was shut down
1722 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1723 obsolete reference to mktap.
1725 2006-06-20 Brian Warner <warner@lothar.com>
1727 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1728 test to include new 'logfiles' argument sent from master to slave
1730 2006-06-19 Brian Warner <warner@lothar.com>
1732 * buildbot/process/step_twisted.py (Trial): track Progress from
1733 _trial_temp/test.log too
1735 * buildbot/process/step.py (OutputProgressObserver): generalize
1736 the earlier StdioProgressObserver into an OutputProgressObserver
1737 that can track LogFiles other than stdio.
1738 (LoggingBuildStep.__init__): same
1740 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1741 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1742 will fail under windows because of os.sep issues. It might have
1743 worked before if 'cat' was doing cygwin path conversion.
1745 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1746 creation of LogFileWatchers
1747 (ShellCommand._startCommand): and record the files that were
1748 watched in the 'headers' section of the ShellCommand output
1750 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1751 need to actually pass it to the slave if you want it to work.
1752 (ShellCommand): document it a bit
1754 * buildbot/test/test_shell.py: new test to validate LogFiles
1755 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1757 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1758 before printing the last batch of lines, to test that the polling
1759 logic is working properly
1761 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1762 handling, making it possible to track multiple logs for a single
1763 RemoteCommand. The previous single logfile is now known as the
1765 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1766 (RemoteShellCommand.__init__): accept logfiles=
1767 (LoggingBuildStep.startCommand): stdio_log is now one of many
1768 (ShellCommand): added logfiles= argument, as well as a class-level
1769 .logfiles attribute, which will be merged together to figure out
1770 which logfiles should be tracked. The latter maybe be useful for
1771 subclasses of ShellCommand which know they will aways produce
1772 secondary logfiles in the same location.
1774 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1775 and closeStdin() methods, preparing to make it possible to write
1776 to a ShellCommand's stdin at any time, not just at startup. These
1777 writes are buffered if the child process hasn't started yet.
1778 (LogFileWatcher): new helper class to watch arbitrary logfiles
1779 while a ShellCommand runs. This class polls the file every two
1780 seconds, and sends back 10k chunks to the buildmaster.
1781 (ShellCommand): rename stdin= to initialStdin=, and add
1782 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1784 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1785 key of "log" and a value of (logname, data).
1786 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1787 'logfiles' to the master-visible args dictionary.
1788 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1791 * buildbot/test/test_vc.py (Patch.testPatch): same
1794 * buildbot/test/emit.py: write to a logfile in the current
1795 directory. We use this to figure out what was used as a basedir
1796 rather than looking to see which copy of emit.py gets run, so that
1797 we can run the commands from inside _trial_temp rather than inside
1799 * buildbot/test/subdir/emit.py: same
1800 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1801 argument rather than running from buildbot/test/
1802 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1803 rather than using an implicit setUp()
1804 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1805 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1806 of assuming that we're running in buildbot/test/ (and that '.' is
1809 * buildbot/slave/commands.py (Command.doStart): refactor Command
1810 startup/completion a bit: now the SlaveBuilder calls doStart(),
1811 which is not meant for overridding by subclasses, and doStart()
1812 calls start(), which is. Likewise the SlaveBuilder calls
1813 doInterrupt(), and subclasses override interrupt(). This also puts
1814 responsibility for maintaining .running in Command rather than in
1816 (Command.doInterrupt): same
1817 (Command.commandComplete): same, this is called when the deferred
1818 returned by start() completes.
1819 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1820 (SlaveBuilder.remote_interruptCommand): same
1821 (SlaveBuilder.stopCommand): same
1823 2006-06-16 Brian Warner <warner@lothar.com>
1825 * buildbot/test/test_shell.py: new test file to contain everything
1826 relating to ShellCommand
1827 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1828 multiple logfiles in realtime" feature, not yet implemented
1829 * buildbot/test/emitlogs.py: support file for testLogFiles
1830 * docs/buildbot.texinfo (ShellCommand): document the feature
1832 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1834 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1835 for tests which exercise SlaveCommands in isolation.
1837 * buildbot/test/test_slavecommand.py: Move some utilities like
1838 SignalMixin and FakeSlaveBuilder from here ..
1839 * buildbot/test/runutils.py: .. to here, so they can be used by
1840 other test classes too
1841 * buildbot/test/test_vc.py: more SignalMixin refactoring
1842 * buildbot/test/test_control.py: same
1843 * buildbot/test/test_run.py: and some rmtree refactoring
1845 2006-06-15 Brian Warner <warner@lothar.com>
1847 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1848 'testBranch' to match other VC tests and have the tests run in
1849 roughly increasing order of dependency
1851 * buildbot/test/test_steps.py (LogObserver): new test to verify
1852 LogObservers can be created at various times and still get
1853 connected up properly
1855 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1856 to create BuildStepStatus instances that actually work.
1858 * buildbot/process/step.py (LogObserver): add outReceived and
1859 errReceived base methods, to be overridden
1861 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1862 API to take a name instead of a step, reducing the coupling
1863 somewhat. This returns the BuildStepStatus object so it can be
1864 passed to the new Step, instead of jamming it directly into the
1866 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1868 * buildbot/process/base.py (Build.setupBuild): use both methods
1869 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1870 process a bit to match
1872 2006-06-14 Brian Warner <warner@lothar.com>
1874 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1875 docs on writing new LogObserver classes
1876 (Writing New Status Plugins): brief docs on how Status Plugins fit
1879 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1880 implement a LogObserver that counts how many unit tests have been
1882 (Trial.__init__): wire it in
1883 * buildbot/test/test_twisted.py (Counter): unit test for it
1885 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1886 to new cmd.logs['stdio'] scheme
1887 (Trial.commandComplete): same
1888 (BuildDebs.commandComplete): same
1890 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1891 LogFiles, instead of just a single one. The old single logfile is
1892 now called "stdio". LoggedRemoteCommand no longer creates a
1893 LogFile for you (the code to do that was broken anyway). If you
1894 don't create a "stdio" LogFile, then stdout/stderr will be
1896 (LogObserver): implement "LogObservers", which a BuildStep can add
1897 to parse the output of a command in real-time. The primary use is
1898 to provide more useful information to the Progress code, allowing
1899 better ETA estimates.
1900 (LogLineObserver): utility subclass which feeds complete lines to
1901 the parser instead of bytes.
1902 (BuildStep.progressMetrics): this is safer as a tuple
1903 (BuildStep.setProgress): utility method, meant to be called by
1905 (BuildStep.addLogObserver): new method, to be called at any time
1906 during the BuildStep (even before any LogFiles have been created),
1907 to attach (or schedule for eventual attachment) a LogObserver to a
1909 (StdioProgressObserver): new LogObserver which replaces the old
1910 "output" progress gatherer
1911 (LoggingBuildStep.__init__): same
1912 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1913 (LoggingBuildStep._commandComplete): must use logs['stdio']
1914 instead of the old single ".log" attribute.
1915 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1916 functionality, now subsumed into StdioProgressObserver
1917 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1918 log name changed from "output" to "stdio".
1921 * buildbot/interfaces.py (ILogFile): add the Interface used from
1922 the BuildStep towards the LogFile
1923 (ILogObserver): and the one provided by a LogObserver
1924 * buildbot/status/builder.py (LogFile): implement it
1926 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1927 HEADER constants here ..
1928 * buildbot/status/builder.py (STDOUT): .. from here
1930 2006-06-13 Brian Warner <warner@lothar.com>
1932 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1933 compatibility with python2.2, which doesn't have the 'substr in
1935 (TestP4Poller.makeTime): utility function to construct the
1936 timestamp using the same strptime() approach as p4poller does. It
1937 turns out that time.mktime() behaves slightly differently under
1938 python2.2, probably something to do with the DST flag, and that
1939 causes the test to fail under python2.2. (changing the mktime()
1940 arguments to have dst=0 instead of -1 caused it to fail under
1941 python2.3. Go figure.)
1942 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1944 2006-06-12 Brian Warner <warner@lothar.com>
1946 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1947 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1948 contributing such an excellent patch, including docs and unit
1949 tests! This makes it *so* much easier to apply. I had to update
1950 test_vc.py to handle some recent refactorings, but everything else
1951 applied smoothly. The only remaining thing I'd like to fix would
1952 be to remove the hard-wired port 1666 used by p4d, and allow it to
1953 claim any unused port. This would allow two copies of the test
1954 suite to run on the same host at the same time, as well as
1955 allowing the test suite to run while a real (production) p4d was
1956 running on the same host. Oh, and maybe we should add a warning to
1957 step.P4 that gets emitted if the slave is too old to provide the
1958 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1959 * buildbot/slave/commands.py (P4): same
1960 (P4Sync): same, some minor updates
1961 * buildbot/changes/p4poller.py: same
1962 * docs/buildbot.texinfo: same
1963 * buildbot/test/test_p4poller.py: same
1964 * buildbot/test/test_vc.py (P4): same
1966 * setup.py: add Trove classifiers for PyPI
1968 2006-06-08 Brian Warner <warner@allmydata.com>
1970 * buildbot/status/client.py
1971 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1972 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1973 build needs to be IRemote'd separately, rather than IRemote'ing
1974 the whole list at once. I can't wait until newpb's serialization
1975 adapters make this unnecessary.
1977 2006-06-06 Brian Warner <warner@lothar.com>
1979 * buildbot/process/step.py (WithProperties): make this inherit
1980 from ComparableMixin, so that reloading an unchanged config file
1981 doesn't cause us to spuriously reload any Builders which use them.
1982 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1985 2006-06-03 Brian Warner <warner@lothar.com>
1987 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1988 running py2exe on windows, contributed by Mark Hammond. Addresses
1989 SF#1401121, but I think we still need to include
1990 buildbot/scripts/sample.cfg
1991 * setup.py: include buildbot_service.py as a script under windows
1992 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1993 a py2exe application), get the icon/css datafiles from a different
1996 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1997 double-escape the build URL. Thanks to Olivier Bonnet for the
1998 patch. Fixes SF#1452801.
2000 2006-06-02 Brian Warner <warner@lothar.com>
2002 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2003 first six columns of 'svnlook' output, not just the first column,
2004 since property changes appear in the other five. Thanks to Olivier
2005 Bonnet for the patch. Fixes SF#1398174.
2007 2006-06-01 Brian Warner <warner@lothar.com>
2009 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2010 the fake build, so that title= has something to be set to
2012 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2013 attribute of the "Build #NN" link in the yellow start-the-build
2014 box to the build's reason. This means that you get a little
2015 tooltip explaining why the build was done when you hover over the
2016 yellow box. Thanks to Zandr Milewski for the suggestion.
2018 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2019 (Box.setETA): handle ETA=None (by stopping the timer)
2020 (Box.update): make the [soon] text less different than the usual
2021 text, so the rest of the text doesn't flop around so much. It
2022 would be awfully nice to figure out how to center this stuff.
2023 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2025 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2026 by default, so that any ShellCommand which fails marks the overall
2027 build as a failure. I should have done this from the beginning.
2028 Add flunkOnFailure=False to the arguments if you want to turn off
2031 2006-05-30 Brian Warner <warner@lothar.com>
2033 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2034 last-build/current-build/current-step. Show what step is currently
2035 running. Show ETA for both the overall build and the current step.
2036 Update GTK calls to modern non-deprecated forms. There's still a
2037 lot of dead code and debug noise to remove.
2039 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2040 shows up properly in status displays
2042 2006-05-28 Brian Warner <warner@lothar.com>
2044 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2045 build we use to verify that WithProperties works:
2047 ** set flunkOnFailure=True so that build failures get noticed
2048 ** set workdir='.' so that the build succeeds, otherwise it is trying
2049 to touch 'build/something', and 'build/' doesn't exist because
2050 usually that's created by a Source step
2051 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2052 this test somehow triggers, in which the 'touch' process becomes
2053 a zombie and we wait for th etimeout before giving up on it.
2055 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2056 to log the Build results and step logs to the twisted log.
2057 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2058 what went wrong if a build was expected to succeed but didn't.
2060 * buildbot/process/step_twisted.py (Trial): set the default
2061 trialMode to '--reporter=bwverbose', which specifies verbose
2062 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2063 '-to', but those are completely missing in modern Twisteds.
2065 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2066 a localhost-only port, to encourage better security
2068 * docs/buildbot.texinfo (Change Sources): mention
2071 * .darcs-boring: add a Darcs boringfile
2073 * README (REQUIREMENTS): stop claiming compatibility with
2076 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2079 2006-05-27 Brian Warner <warner@lothar.com>
2081 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2082 * docs/buildbot.texinfo: same
2084 2006-05-23 Brian Warner <warner@lothar.com>
2086 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2087 * docs/buildbot.texinfo: set version to match
2088 * NEWS: update for 0.7.3
2090 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2091 give a quick mapping from VC system to possible ChangeSources
2092 (Build Properties): add 'buildername'
2094 * buildbot/process/base.py (Build.setupStatus): oops, set
2095 'buildername' and 'buildnumber' properties
2096 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2099 2006-05-22 Brian Warner <warner@lothar.com>
2101 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2102 property interpolation better
2104 * README (INSTALLATION): remove old '-v' argument from recommended
2107 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2108 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2111 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2112 'svnversion' instead of grepping the output of 'svn info', much
2113 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2114 Bonnet for the suggestion.
2115 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2116 require the WC_PATH argument, so run 'svnversion .' instead.
2118 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2119 aren't supposed to have 'self' in their argument list
2121 2006-05-21 Brian Warner <warner@lothar.com>
2123 * buildbot/process/step.py (ShellCommand.start): make
2124 testInterpolate pass. I was passing the uninterpolated command to
2125 the RemoteShellCommand constructor
2126 (ShellCommand._interpolateProperties): oops, handle non-list
2127 commands (i.e. strings with multiple words separated by spaces in
2128 them) properly, instead of forgetting about them.
2130 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2131 to actually try to use build properties in a real build. This test
2133 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2134 to start and evaluate builds
2136 * buildbot/test/test__versions.py: add a pseudo-test to record
2137 what version of Twisted/Python/Buildbot are running. This should
2138 show up at the beginning of _trial_tmp/test.log, and exists to help
2139 debug other problems.
2141 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2142 a filename to be served as 'robots.txt' to discourage web spiders.
2143 Adapted from a patch by Tobi Vollebregt, thanks!
2144 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2145 (Waterfall.test_waterfall): tweak the way that filenames are put
2146 into the config file, to accomodate windows pathnames better.
2148 * docs/buildbot.texinfo (HTML Waterfall): document it
2150 * buildbot/process/process_twisted.py
2151 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2152 changed the build process. The new setup.py no longer takes the
2154 (FullTwistedBuildFactory.__init__): same
2155 (TwistedReactorsBuildFactory.__init__): same
2157 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2158 be placed in the [hooks] section of the central repository (the
2159 one that everybody pushes changes to).
2161 2006-05-20 Brian Warner <warner@lothar.com>
2163 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2164 .darcs-context file, use binary mode. I think this was causing a
2165 Darcs failure under windows.
2167 2006-05-19 Brian Warner <warner@lothar.com>
2169 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2170 use a timezone string of +0000 and gmtime, since this timestamp is
2171 sent to a buildmaster and %z is broken.
2173 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2174 string and localtime, since this timestamp will only be consumed
2175 locally, and %z is broken.
2177 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2178 gmtime, since this timestamp is returned to the buildmaster, and
2181 2006-05-18 Brian Warner <warner@lothar.com>
2183 * NEWS: update in preparation for next release
2185 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2186 setup-repository and do-we-have-the-vc-tools code into a separate
2187 "helper" class, which sticks around in a single module-level
2188 object. This seems more likely to continue to work in the future
2189 than having it hide in the TestCase and hope that TestCases stick
2190 around for a long time.
2192 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2193 addremove' has been deprecated in recent versions of mercurial, so
2194 use 'hg add' instead
2196 2006-05-07 Brian Warner <warner@lothar.com>
2198 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2199 operating under windows, move the file before opening it, since
2200 you can't rename a file that somebody has open.
2202 * buildbot/process/base.py (Build.setupBuild): if something goes
2203 wrong while creating a Step, log the name and arguments, since the
2204 error message when you get the number of arguments wrong is really
2207 2006-05-06 Brian Warner <warner@lothar.com>
2209 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2210 bugs in twisted-specific code not covered by my unit tests, this
2211 time use 'cmd' argument instead of self.cmd
2213 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2214 fix stupid braino: either use startwith or find()==0, not both.
2215 (TwistedReactorsBuildFactory.__init__): another dumb typo
2217 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2218 mark this test as TODO under windows, since process-killing seems
2219 dodgy there. We'll come back to this later and try to fix it
2222 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2223 and don't include a timezone
2224 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2225 This should avoid the windows-with-verbose-timezone-name problem
2227 (Patch.testPatch): add a test which runs 'patch' with less
2228 overhead than the full VCBase.do_patch sequence, to try to isolate
2229 a windows test failure. This one uses slave.commands.ShellCommand
2230 and 'patch', but none of the VC code.
2232 * buildbot/slave/commands.py (getCommand): use which() to find the
2233 executables for 'cvs', 'svn', etc. This ought to help under
2236 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2237 working directory before starting. If an earlier test failed, the
2238 leftover directory would mistakenly flunk a later test.
2239 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2240 Make sure that we use the right commandlines if which("tla") picks
2241 up "tla.exe" (as it does under windows).
2242 (TlaSupport.do_get): factor out this tla-vs-baz difference
2243 (TlaSupport.vc_create): more tla-vs-baz differences
2245 * buildbot/test/test_slavecommand.py
2246 (ShellBase.testShellMissingCommand): stop trying to assert
2247 anything about the error message: different shells on different
2248 OSes with different languages makes it hard, and it really isn't
2249 that interesting of a thing to test anyway.
2251 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2252 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2253 "Panther"), because it has a bug which flunks a couple tests in
2254 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2255 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2256 able to test that yet.
2258 2006-04-30 Brian Warner <warner@lothar.com>
2260 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2261 make sure child commands emit messages in english, so our regexps
2262 will match. Thanks to Nikaus Giger for identifying the problems.
2263 (VCBase._do_vctest_export_1): mode="export" is not responsible
2264 for setting the "got_revision" property, since in many cases it is
2265 not convenient to determine.
2266 (SVNSupport.capable): when running 'svn --version' to check for
2267 ra_local, we want error messages in english
2268 * buildbot/test/test_slavecommand.py
2269 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2270 to emit the error message in english
2272 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2273 the environment with $LC_ALL="C" so that Commands which need to
2274 parse the output of their child processes can obtain it in
2276 (SVN.parseGotRevision): call "svn info" afterwards instead of
2277 watching the output of the "svn update" or "svn checkout".
2278 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2279 (Arch.parseGotRevision): same
2280 (Bazaar.parseGotRevision): same
2281 (Mercurial.parseGotRevision): same
2283 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2284 $LC_ALL="C" when running commands under 'buildbot try', too
2286 * buildbot/test/__init__.py: remove the global os.environ()
2287 setting, instead we do it just for the tests that run commands and
2288 need to parse their output.
2290 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2291 remove the overly-short .timeout on this test, because non-DNotify
2292 platforms must fall back to polling which happens at 10 second
2293 intervals, so a 5 second timeout would never succeed.
2295 2006-04-24 Brian Warner <warner@lothar.com>
2297 * docs/buildbot.texinfo (Installing the code): update trial
2298 invocation, SF#1469116 by Niklaus Giger.
2299 (Attributes of Changes): updated branch-name examples to be
2300 a bit more realistic, SF#1475240 by Stephen Davis.
2302 * contrib/windows/buildbot2.bat: utility wrapper for windows
2303 developers, contributed by Nick Trout (after a year of neglect..
2304 sorry!). SF#1194231.
2306 * buildbot/test/test_vc.py (*.capable): store the actual VC
2307 binary's pathname in VCS[vcname], so it can be retrieved later
2308 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2309 strip out non-numeric timezone information, specifically the funky
2310 German string that his system produced that confuses CVS.
2311 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2312 allow Darcs tests to work on windows
2313 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2314 procutils.which() everywhere, to allow tryclient to work under
2315 windows. Also from Niklaus Giger, SF#1463394.
2317 * buildbot/twcompat.py (which): move the replacement for a missing
2318 twisted.python.procutils.which from test_vc.py to here, so it can
2319 be used in other places too (specifically tryclient.py)
2321 2006-04-23 Brian Warner <warner@lothar.com>
2323 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2324 bare buildbotURL/projectName line with a proper DIV, along with a
2325 CSS class of "title", from Stefan Seefeld (SF#1461675).
2326 (WaterfallStatusResource.body0): remove the redundant 'table'
2327 class from the table
2328 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2329 to the top-row TR, and class="Activity" to the second-row TR,
2330 rather than putting them in the individual TD nodes.
2332 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2333 'got_revision' build property for all VC systems that implement
2334 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2336 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2337 to determine which revision we actually obtained
2338 (CVS.parseGotRevision): implement this for CVS, which just means
2339 to grab a timestamp. Not ideal, and it depends upon the buildslave
2340 having a clock that is reasonably well syncronized with the server,
2341 but it's better than nothing.
2342 (SVN.parseGotRevision): implement it for SVN, which is accurate
2343 (Darcs.parseGotRevision): same
2344 (Arch.parseGotRevision): same
2345 (Bazaar.parseGotRevision): same
2346 (Mercurial.parseGotRevision): same
2348 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2349 keep a record of all non-stdout/stderr/header/rc status updates,
2350 for the benefit of RemoteCommands that send other useful things,
2352 (Source.commandComplete): put any 'got_revision' status values
2353 into a build property of the same name
2356 * buildbot/process/step_twisted.py (Trial): update to deal with
2357 new ShellCommand refactoring
2359 * docs/buildbot.texinfo (Build Properties): document new feature
2360 that allows BuildSteps to get/set Build-wide properties like which
2361 revision was requested and/or checked out.
2363 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2364 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2365 it. Note that this bumps the persistenceVersion of the saved Build
2366 object, so add the necessary upgrade-old-version logic to include
2367 an empty properties dict.
2369 * buildbot/process/base.py (Build.setProperty): implement it
2370 (Build.getProperty): same
2371 (Build.startBuild): change build startup to set 'branch',
2372 'revision', and 'slavename' properties at the right time
2374 * buildbot/process/step.py (BuildStep.__init__): change setup to
2375 require 'build' argument in a better way
2376 (LoggingBuildStep): split ShellCommand into two pieces, for better
2377 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2378 a single RemoteCommand that sends stdout/stderr status text. It
2379 also provides the usual commandComplete / createSummary /
2380 evaluateCommand / getText methods to be overridden...
2381 (ShellCommand): .. whereas ShellCommand is specifically for
2382 running RemoteShellCommands. Other shell-like BuildSteps (like
2383 Source) can inherit from LoggingBuildStep instead of ShellCommand
2384 (WithProperties): marker class to do build-property interpolation
2385 (Source): inherit from LoggingBuildStep instead of ShellCommand
2388 * buildbot/test/test_properties.py: test new functionality
2390 2006-04-21 Brian Warner <warner@lothar.com>
2392 * buildbot/test/test_vc.py: rename testBranch to
2393 testCheckoutBranch to keep the tests in about the right
2396 2006-04-18 Brian Warner <warner@lothar.com>
2398 * docs/buildbot.texinfo (PBListener): improve cross-references
2399 between PBListener and 'buildbot statusgui', thanks to John Pye
2402 2006-04-17 Brian Warner <warner@lothar.com>
2404 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2405 running under Twisted-1.3.0, otherwise skipped tests are reported
2408 * all: use isinstance() instead of 'type(x) is foo', suggested by
2411 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2412 oops, fix a brain-fade from the other week, when making the
2413 addStep changes. I changed all the __init__ upcalls to use the
2414 wrong superclass name.
2415 (FullTwistedBuildFactory.__init__): same
2416 (TwistedDebsBuildFactory.__init__): same
2417 (TwistedReactorsBuildFactory.__init__): same
2418 (TwistedBuild.isFileImportant): use .startswith for clarity,
2419 thanks to Neal Norwitz for the suggestions.
2421 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2422 changes, then deliver them over PB to a remote buildmaster.
2424 * contrib/svnpoller.py: added script by John Pye to poll a remote
2425 SVN repository (by running 'svn log') from a cronjob, and run
2426 'buildbot sendchange' to deliver the changes to a remote
2428 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2429 modification of svnpoller.py), same purpose, but this one loops
2430 internally (rather than expecting to run from a cronjob) and works
2432 * contrib/README.txt: same
2434 2006-04-11 Brian Warner <warner@lothar.com>
2436 * all: fix a number of incorrect names and missing imports, thanks
2437 to Anthony Baxter for the patch.
2438 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2439 remove unused buggy method.
2440 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2441 comes from shutil, not "shutils"
2442 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2443 (Arch.checkSlaveVersion): same
2444 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2446 * buildbot/process/step_twisted2.py: add some missing imports
2447 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2448 this code used to live in twisted.internet.defer
2450 2006-04-10 Brian Warner <warner@lothar.com>
2452 * buildbot/process/step.py (Mercurial): add Mercurial support
2453 * buildbot/slave/commands.py (Mercurial): same
2454 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2455 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2456 not yet tested, but 'try' support *is* covered
2457 * docs/buildbot.texinfo (Mercurial): document it
2459 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2460 some debugging messages (turned off)
2461 * buildbot/test/test_vc.py: improve debug messages
2463 2006-04-07 Brian Warner <warner@lothar.com>
2465 * buildbot/test/test_vc.py (which): define our own which() in case
2466 we can't import twisted.python.procutils, because procutils doesn't
2467 exist in Twisted-1.3
2469 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2470 of SlaveLocks for performance tests
2472 * docs/examples/twisted_master.cfg: update to match current usage
2474 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2475 password, p4 binary, pollinterval, maximum history to check.
2476 Patch from an anonymous sf.net contributor, SF#1219384.
2477 * buildbot/process/step.py (P4Sync.__init__): add username,
2478 password, and client arguments.
2479 * buildbot/slave/commands.py (P4Sync): same
2481 2006-04-05 Brian Warner <warner@lothar.com>
2483 * buildbot/process/factory.py (BuildFactory.addStep): new method
2484 to add steps to a BuildFactory. Use it instead of f.steps.append,
2485 and you can probably avoid using the s() convenience function.
2486 Patch from Neal Norwitz, sf.net #1412605.
2487 (other): update all factories to use addStep
2488 * buildbot/process/process_twisted.py: update all factories to use
2491 2006-04-03 Brian Warner <warner@lothar.com>
2493 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2494 work under windows too. Adapted from a patch by Niklaus Giger,
2495 addresses SF#1463399.
2497 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2498 spawned commands emit parseable results in english and not some
2499 other language. Patch from Niklaus Giger, SF#1463395.
2501 * README (INSTALLATION): discourage users from running unit tests on
2502 a "network drive", patch from Niklaus Giger, SF#1463394.
2504 2006-03-22 Brian Warner <warner@lothar.com>
2506 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2507 function to turn a repository-relative pathname into a (branch,
2508 branch-relative-filename) tuple. Change this function to handle
2509 the branch naming policy used by your Subversion repository.
2510 Thanks to AllMyData.com for sponsoring this work.
2512 2006-03-16 Brian Warner <warner@lothar.com>
2514 * buildbot/scripts/sample.cfg: add python-mode declaration for
2515 vim. Thanks to John Pye for the patch.
2517 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2518 command line, mention the importance of running 'crontab' as the
2519 buildmaster/buildslave user. Thanks to John Pye for the catch.
2521 2006-03-13 Brian Warner <warner@lothar.com>
2523 * buildbot/status/words.py (IRC): add an optional password=
2524 argument, which will be sent to Nickserv in an IDENTIFY message at
2525 login, to claim the nickname. freenode requires this before the
2526 bot can sent (or reply to) private messages. Thanks to Clement
2527 Stenac for the patch.
2528 * docs/buildbot.texinfo (IRC Bot): document it
2530 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2531 larger than chunkSize. Fixes SF#1349253.
2532 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2533 (Log.testConsumer): update to match new internal chunking behavior
2535 2006-03-12 Brian Warner <warner@lothar.com>
2537 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2539 * buildbot/test/test_maildir.py (MaildirTest): rename the
2540 'timeout' method, as it collides with trial's internals
2542 * buildbot/scripts/runner.py: add 'buildbot restart' command
2543 (stop): don't sys.exit() out of here, otherwise restart can't work
2544 * docs/buildbot.texinfo (Shutdown): document it
2546 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2547 * buildbot/status/html.py (Waterfall.__init__): same
2548 * buildbot/process/builder.py (Builder.startBuild): same
2549 * buildbot/process/base.py (BuildRequest): same
2550 * buildbot/sourcestamp.py (SourceStamp): same
2551 * buildbot/scheduler.py (Nightly): same
2553 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2555 * docs/buildbot.texinfo: same
2557 2006-02-17 Brian Warner <warner@lothar.com>
2559 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2560 * docs/buildbot.texinfo: set version number to match
2561 * NEWS: update for 0.7.2
2563 2006-02-16 Brian Warner <warner@lothar.com>
2565 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2567 2006-02-09 Brian Warner <warner@lothar.com>
2569 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2570 add text to explain per-build branch parameters
2571 * NEWS: mention --umask
2573 2006-02-08 Brian Warner <warner@lothar.com>
2575 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2577 (SlaveOptions.optParameters): add --umask, to make it possible to
2578 make buildslave-generated files (including build products) be
2581 * buildbot/slave/bot.py (BuildSlave.startService): same
2583 2006-01-23 Brian Warner <warner@lothar.com>
2585 * buildbot/status/builder.py: urllib.quote() all URLs that include
2586 Builder names, so that builders can include characters like '/'
2587 and ' ' without completely breaking the resulting HTML. Thanks to
2588 Kevin Turner for the patch.
2589 * buildbot/status/html.py: same
2590 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2592 * NEWS: update in preparation for upcoming release
2594 2006-01-18 Brian Warner <warner@lothar.com>
2596 * docs/examples/twisted_master.cfg: update to match the Twisted
2597 buildbot: remove python2.2, switch to exarkun's buildslaves,
2598 disable the .deb builder until we figure out how to build twisted
2599 .debs from SVN, add some ktrace debugging to the OS-X build
2600 process and remove the qt build, remove threadless builders,
2601 change freebsd builder to use landonf's buildslave.
2603 2006-01-12 Brian Warner <warner@lothar.com>
2605 * buildbot/master.py (Manhole.__init__): let port= be a strports
2606 specification string, but handle a regular int for backwards
2607 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2608 used in master.cfg to limit connections to just the local host.
2609 (BuildMaster.loadConfig): same for c['slavePortnum']
2610 * buildbot/scheduler.py (Try_Userpass.__init__): same
2611 * buildbot/status/client.py (PBListener.__init__): same
2612 * buildbot/status/html.py (Waterfall.__init__): same, for both
2613 http_port and distrib_port. Include backwards-compatibility checks
2614 so distrib_port can be a filename string and still mean unix:/foo
2615 * docs/buildbot.texinfo (Setting the slaveport): document it
2616 (Debug options): same
2617 (HTML Waterfall): same
2620 * buildbot/test/test_config.py (ConfigTest): test it
2622 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2623 slaveport's disownServiceParent deferred to fire before opening
2624 the new one. Fixes an annoying bug in the unit tests.
2626 2006-01-03 Brian Warner <warner@lothar.com>
2628 * buildbot/master.py (BuildMaster): remove the .schedulers
2629 attribute, replacing it with an allSchedulers() method that looks
2630 for all IService children that implement IScheduler. Having only
2631 one parent/child relationship means fewer opportunities for bugs.
2632 (BuildMaster.allSchedulers): new method
2633 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2634 also fix ugly bug that caused any config-file reload to
2635 half-forget about the earlier Schedulers, causing an exception
2636 when a Change arrived and was handed to a half-connected
2637 Scheduler. The exception was in scheduler.py line 54ish:
2638 self.parent.submitBuildSet(bs)
2639 exceptions.AttributeError: 'NoneType' object has no attribute
2641 (BuildMaster.addChange): update to use allSchedulers()
2643 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2644 to work properly with twisted-1.3.0, where you must explicitly
2645 include the __implements__ from parent classes
2646 (BaseScheduler.__repr__): make it easier to distinguish distinct
2648 (BaseUpstreamScheduler.__implements__): same
2650 * buildbot/status/builder.py (Status.getSchedulers): update to
2652 * buildbot/test/test_run.py (Run.testMaster): same
2653 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2654 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2655 make sure Scheduler instances are left alone when an identical
2656 config file is reloaded
2657 (ConfigElements.testSchedulers): make sure Schedulers are properly
2660 * Makefile (TRIALARGS): my local default Twisted version is now
2661 2.1.0, update the trial arguments accordingly
2663 2005-12-22 Brian Warner <warner@lothar.com>
2665 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2668 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2669 addChange in the parent class, although I suspect this should be
2670 fixed better in the future.
2672 2005-11-26 Brian Warner <warner@lothar.com>
2674 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2675 explode when branch==None, thanks to Kevin Turner for the catch
2676 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2679 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2681 * docs/buildbot.texinfo: same
2683 2005-11-26 Brian Warner <warner@lothar.com>
2685 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2686 * docs/buildbot.texinfo: set version number to match
2688 2005-11-26 Brian Warner <warner@lothar.com>
2690 * NEWS: update for 0.7.1
2692 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2693 sure that unsubscribe works even if we never sent an ETA update.
2694 Also, don't explode on duplicate unsubscribe.
2695 (BuildStepStatus.addLog): make the convenience "return self"-added
2696 watcher automatically unsubscribe when the Step finishes.
2697 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2698 (BuildStatus.stepStarted): same auto-unsubscribe
2699 (BuilderStatus.buildStarted): same auto-unsubscribe
2701 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2703 (IStatusReceiver.stepStarted): same
2704 (IStatusReceiver.logStarted): same
2706 * buildbot/test/test_run.py (Status): move the Status test..
2707 * buildbot/test/test_status.py (Subscription): .. to here
2709 2005-11-25 Brian Warner <warner@lothar.com>
2711 * NEWS: more updates
2713 * buildbot/locks.py: fix the problem in which loading a master.cfg
2714 file that changes some Builders (but not all of them) can result
2715 in having multiple copies of the same Lock. Now, the real Locks
2716 are kept in a table inside the BotMaster, and the Builders/Steps
2717 use "LockIDs", which are still instances of MasterLock and
2718 SlaveLock. The real Locks are instances of the new RealMasterLock
2719 and RealSlaveLock classes.
2720 * buildbot/master.py (BotMaster.getLockByID): new method to
2721 convert LockIDs into real Locks.
2722 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2723 into real Locks before building
2724 * buildbot/process/step.py (BuildStep.startStep): same
2725 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2726 exercises the problem
2729 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2730 what Schedulers are available
2732 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2733 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2734 'cron'-style build scheduling at certain times of day, week,
2736 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2738 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2739 handling: treat self.fileIsImportant more as an attribute that
2740 contains a callable than as a method. If the attribute is None,
2741 don't call it and assume all filenames are important. It is still
2742 possible to provide a fileIsImportant method in a subclass,
2744 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2746 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2747 test using AnyBranchScheduler with fileIsImportant=None
2749 2005-11-24 Brian Warner <warner@lothar.com>
2751 * buildbot/test/test_config.py (StartService): don't claim a fixed
2752 port number, instead set slavePort=0 on the first pass, figure out
2753 what port was allocated, then switch to a config file that uses
2756 * buildbot/master.py (BuildMaster.loadConfig): close the old
2757 slaveport before opening the new one, because unit tests might
2758 replace slavePort=0 with the same allocated portnumber, and if we
2759 don't wait for the old port to close first, we get a "port already
2760 in use" error. There is a tiny race condition here, but the only
2761 threat is from other programs that bind (statically) to the same
2762 port number we happened to be allocated, and only if those
2763 programs use SO_REUSEADDR, and only if they get control in between
2766 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2768 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2769 deleted ChangeSources before adding any new ones
2770 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2771 compare_attrs, to make sure that a config-file reload does not
2772 unnecessarily replace an unmodified ChangeSource instance
2773 * buildbot/test/test_config.py (ConfigTest.testSources): update
2775 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2776 mean "don't build anything", and add a warning if it gets used
2777 because it isn't actually useful.
2779 * contrib/svn_buildbot.py: update example usage to match the port
2780 number that gets used by the PBChangeSource
2781 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2783 2005-11-22 Brian Warner <warner@lothar.com>
2785 * NEWS: start collecting items for next release
2787 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2788 revisions are strings
2789 (P4Sync.computeSourceRevision): same
2791 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2792 to the Buildbot's overall status page
2793 (StatusResourceBuilder.body): same
2795 2005-11-15 Brian Warner <warner@lothar.com>
2797 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2798 config-file loading, specifically to make sure old StatusTargets
2799 are finished shutting down before new ones start up (thus
2800 resolving a bug in which changing the Waterfall object would fail
2801 because both new and old instances were claiming the same
2802 listening port). Also load new Schedulers after all the new
2803 Builders are set up, in case they fire off a new build right away.
2804 * buildbot/test/test_config.py (StartService): test it
2806 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2807 the branch name to the mail body
2809 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2810 Without it, a config-file reload fails to update an existing
2812 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2813 username/passwd to compare_attrs, for the same reason
2814 * buildbot/status/html.py (Waterfall): add favicon to
2815 compare_attrs, same reason
2817 2005-11-05 Brian Warner <warner@lothar.com>
2819 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2820 baserev before stuffing it in the jobfile. This resolves problems
2821 under SVN (and probably Arch) where revisions are expressed as
2822 numbers. I'm inclined to use string-based revisions everywhere in
2823 the future, but this fix should be safe for now. Thanks to Steven
2824 Walter for the patch.
2826 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2827 binary mode when opening pickle files, to make windows work
2828 better. Thanks to Dobes Vandermeer for the catch.
2829 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2830 (BuilderStatus.getBuildByNumber): same
2831 (Status.builderAdded): same
2832 * buildbot/master.py (BuildMaster.loadChanges): same
2834 * buildbot/util.py (Swappable): delete unused leftover code
2836 * buildbot/process/step.py (SVN): when building on a non-default
2837 branch, add the word "[branch]" to the VC step's description, so
2838 it is obvious that we're not building the usual stuff. Likewise,
2839 when we are building a specific revision, add the text "rNNN" to
2840 indicate what that revision number is. Thanks to Brad Hards and
2841 Nathaniel Smith for the suggestion.
2842 (Darcs.startVC): same
2843 (Arch.startVC): same
2844 (Bazaar.startVC): same
2846 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2847 typo, caught by Mark Dillavou, closes SF#1216636.
2849 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2850 about a test to add some day
2852 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2853 the 'full-2.3' build, and the 'reactors' build is now run under
2854 python-2.4 because the buildslave no longer has gtk/etc bindings
2855 for earlier versions.
2857 2005-11-03 Brian Warner <warner@lothar.com>
2859 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2860 method, takes an IBuildStatus and rebuilds it. It might make more
2861 sense to add this to IBuildControl instead, but that instance goes
2862 away completely once the build has finished, and resubmitting
2863 builds can take place weeks later.
2864 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2865 * buildbot/status/html.py (StatusResourceBuild): also stash an
2866 IBuilderControl so we can use resubmitBuild.
2867 (StatusResourceBuild.body): render "resubmit" button if we can.
2868 Also add hrefs for each BuildStep
2869 (StatusResourceBuild.rebuild): add action for "resubmit" button
2870 (StatusResourceBuilder.getChild): give it an IBuilderControl
2872 * buildbot/status/builder.py (Status.getURLForThing): change the
2873 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2874 that live as targets of buttons like "stop" and "rebuild" can't
2876 * buildbot/status/builder.py (Status.getURLForThing): same
2877 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2878 (StepBox.getBox): same
2879 * buildbot/test/test_web.py (GetURL): same
2882 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2883 exclusivity checks after Source.__init__ upcall, so misspelled
2884 arguments will be reported more usefully
2885 (Darcs.__init__): same
2887 2005-10-29 Brian Warner <warner@lothar.com>
2889 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2890 builder. Move the Try scheduler off to a separate port.
2892 2005-10-27 Brian Warner <warner@lothar.com>
2894 * buildbot/clients/gtkPanes.py
2895 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2896 to cause the app to crash, now they don't.
2898 * buildbot/clients/debug.py: display the buildmaster's location
2899 in the window's title bar
2901 2005-10-26 Brian Warner <warner@lothar.com>
2903 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2904 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2905 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2907 * buildbot/status/html.py (td): put a single non-breaking space
2908 inside otherwise empty <td> elements, as a workaround for buggy
2909 browsers which would optimize them away (along with any associated
2910 styles, like the kind that create the waterfall grid borders).
2911 Patch from Frerich Raabe.
2913 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2914 argv-list as an argument, defaulting to ["-to"], which is
2915 appropriate for the Trial that comes with Twisted-2.1.0 and
2916 earlier. The Trial in current Twisted SVN wants
2917 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2918 defaults to an empty list.
2919 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2920 match it, now that trialMode= is a list instead of a single string
2922 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2924 * docs/buildbot.texinfo: same
2926 2005-10-24 Brian Warner <warner@lothar.com>
2928 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2929 * docs/buildbot.texinfo: set version number to match
2931 2005-10-24 Brian Warner <warner@lothar.com>
2933 * README: update for 0.7.0
2935 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2937 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2938 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2939 send the branch= argument unless the user really provided one, to
2940 retain compatibility with older buildmasters that don't accept
2942 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2945 * docs/buildbot.texinfo: update lots of stuff
2947 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2948 to the 'buildbot sendchange' command
2949 * buildbot/clients/sendchange.py (Sender.send): same
2950 * buildbot/changes/pb.py (ChangePerspective): same
2951 * buildbot/test/test_changes.py (Sender.testSender): test it
2953 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2954 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2955 for consistency with other BuildStep arguments that use camelCase.
2956 Well, at least more of them use camelCase (like flunkOnWarnings)
2957 than don't.. I wish I'd picked one style and stuck with it
2958 earlier. Annoying, but it's best done before the release, since
2959 these arguments didn't exist at all in 0.6.6 .
2961 * buildbot/test/test_vc.py (SVN.testCheckout): same
2962 (Darcs.testPatch): same
2963 * docs/buildbot.texinfo (SVN): document the change
2964 (Darcs): same, add some build-on-branch docs
2965 * docs/examples/twisted_master.cfg: match change
2967 * buildbot/process/step.py (BuildStep): rename
2968 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2969 how it is normally used.
2970 * buildbot/test/test_steps.py (Version.checkCompare): same
2972 * buildbot/process/step.py (CVS.startVC): refuse to build
2973 update/copy -style builds on a non-default branch with an old
2974 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2975 concern is that it will do a VC 'update' in an existing tree when
2976 it is supposed to be switching branches (and therefore clobbering
2977 the tree to do a full checkout), thus building the wrong source.
2978 This used to be a warning, but I think the confusion it is likely
2979 to cause warrants making it an error.
2980 (SVN.startVC): same, also make mode=export on old slaves an error
2981 (Darcs.startVC): same
2982 (Git.startVC): improve error message for non-Git-enabled slaves
2983 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2984 specific revision is built on a slave that doesn't pay attention
2985 to args['revision'], because for slowly-changing trees it will
2986 probably do the right thing, and because we have no way to tell
2987 whether we're asking it to build the most recent version or not.
2988 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2990 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2991 that 'master' is in host:portnum format, to catch errors sooner
2993 2005-10-23 Brian Warner <warner@lothar.com>
2995 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2996 when creating the list of warning messages, include the line
2997 immediately after each WARNING: line, since that's usually where
2998 the file and line number wind up.
3000 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3005 2005-10-22 Brian Warner <warner@lothar.com>
3007 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3008 patch from Brad Hards
3009 * buildbot/status/classic.css: same
3010 * buildbot/test/test_web.py (Waterfall): match changes
3012 * buildbot/test/test_steps.py (BuildStep.setUp): set
3013 nextBuildNumber so the test passes
3014 * buildbot/test/test_status.py (MyBuilder): same
3016 * buildbot/status/html.py (StatusResourceBuild.body): revision
3017 might be numeric, so stringify it before html-escapifying it
3018 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3019 timer for the upcoming build
3020 * buildbot/status/classic.css: add background-color attributes for
3021 offline/waiting/building classes
3023 * buildbot/status/builder.py (BuildStatus): derive from
3024 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3025 the default (i.e. unknown) .slavename to "???" instead of None,
3026 since even unknown slavenames need to be printed eventually.
3027 (BuilderStatus): also derive from styles.Versioned . More
3028 importantly, determine .nextBuildNumber at creation/unpickling
3029 time by scanning the directory of saved BuildStatus instances and
3030 choosing one larger than the highest-numbered one found. This
3031 should fix the problem where random errors during upgrades cause
3032 the buildbot to forget about earlier builds. .nextBuildNumber is
3033 no longer stored in the pickle.
3034 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3035 at least log the error. Also call Builder.determineNextBuildNumber
3036 once the basedir is set.
3038 * buildbot/master.py (BuildMaster.loadChanges): do
3039 styles.doUpgrade afterwards, in case I decide to make Changes
3040 derived from styles.Versioned some day and forget to make this
3044 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3045 when running under older pythons (<2.3) in which the shlex module
3046 doesn't have a 'split' function.
3048 * buildbot/process/step.py (ShellCommand.start): make
3049 errorMessages= be a list of strings to stuff in the log before the
3050 command actually starts. This makes it easier to flag multiple
3051 warning messages, e.g. when the Source steps have to deal with an
3053 (CVS.startVC): handle slaves that don't handle multiple branches
3054 by switching into 'clobber' mode
3055 (SVN.startVC): same. Also reject branches without base_url
3056 (Darcs.startVC): same. Also reject revision= in older slaves
3057 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3058 (Bazaar.startVC): same, and test for baz separately than for arch
3060 * buildbot/slave/commands.py (cvs_ver): document new features
3062 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3063 (BuildStep.slaveVersionNewEnough): more useful utility method
3064 * buildbot/test/test_steps.py (Version): start testing it
3066 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3067 the 'force' command requires python2.3, for the shlex.split method
3069 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3070 since we don't use it anymore. The Twisted buildbot uses a
3073 2005-10-21 Brian Warner <warner@lothar.com>
3075 * buildbot/process/process_twisted.py: rework all BuildFactory
3076 classes to take a 'source' step as an argument, instead of
3077 building up the SVN instance in the factory.
3078 * docs/examples/twisted_master.cfg: enable build-on-branch by
3079 providing a base_url and default_branch
3081 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3082 control over --branch and --revision, not that they are always
3084 * buildbot/status/html.py (StatusResourceBuilder.force): same
3085 (StatusResourceBuild.body): display SourceStamp components
3087 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3088 IRC 'force' command, so it can be shared with an eventual
3089 command-line-tool 'buildbot force' mode.
3090 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3092 2005-10-20 Brian Warner <warner@lothar.com>
3094 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3096 * docs/examples/twisted_master.cfg: update to use Schedulers
3098 * buildbot/scripts/sample.cfg: update with Schedulers
3100 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3101 method specifically for use by HTML "force build" button and the
3102 IRC "force" command. Raises an immediate error if there are no
3104 (IBuilderControl.requestBuild): make this just submit a build, not
3105 try to check for existing slaves or set up any when-finished
3106 Deferreds or anything.
3107 * buildbot/process/builder.py (BuilderControl): same
3108 * buildbot/status/html.py (StatusResourceBuilder.force): same
3109 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3110 * buildbot/test/test_slaves.py: same
3111 * buildbot/test/test_web.py: same
3113 2005-10-19 Brian Warner <warner@lothar.com>
3115 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3116 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3118 2005-10-18 Brian Warner <warner@lothar.com>
3120 * buildbot/status/html.py: provide 'status' argument to most
3121 StatusResourceFOO objects
3122 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3123 and Logfiles" section to make the Build page into a more-or-less
3124 comprehensive source of status information about the build
3126 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3127 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3129 2005-10-17 Brian Warner <warner@lothar.com>
3131 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3132 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3133 out what to do about other projects: the correct options for
3134 recent Twisteds will not work for older ones.
3136 2005-10-15 Brian Warner <warner@lothar.com>
3138 * buildbot/status/builder.py (Status.getURLForThing): add method
3139 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3140 use this in email/IRC status clients to make them more useful, by
3141 providing the end user with hints on where to learn more about the
3142 object being reported on.
3143 * buildbot/test/test_web.py (GetURL): tests for it
3145 2005-10-14 Brian Warner <warner@lothar.com>
3147 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3148 fix bug resulting from deferredResult changes
3150 2005-10-13 Brian Warner <warner@lothar.com>
3152 * buildbot/test/test_changes.py: remove use of deferredResult
3153 * buildbot/test/test_config.py: same
3154 * buildbot/test/test_control.py: same
3155 * buildbot/test/test_status.py: same
3156 * buildbot/test/test_vc.py: this is the only remaining use, since
3157 it gets used at module level. This needs to be replaced by some
3158 sort of class-level run-once routine.
3160 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3162 * lots: implement multiple slaves per Builder, which means multiple
3163 current builds per Builder. Some highlights:
3164 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3165 of (state,currentBuilds) instead of (state,currentBuild)
3166 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3167 (IBuildStatus.getSlavename): new method, so you can tell which
3168 slave got used. This only gets set when the build completes.
3169 (IBuildRequestStatus.getBuilds): new method
3171 * buildbot/process/builder.py (SlaveBuilder): add a .state
3172 attribute to track things like ATTACHING and IDLE and BUILDING,
3174 (Builder): .. the .slaves attribute here, which has been turned
3175 into a simple list of available slaves. Added a separate
3176 attaching_slaves list to track ones that are not yet ready for
3178 (Builder.fireTestEvent): put off the test-event callback for a
3179 reactor turn, to make tests a bit more consistent.
3180 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3181 ping fails due to an exception. This needs work, I'm worried that
3182 a code error could lead to a constantly re-connecting slave.
3183 Especially since I'm trying to move to a distinct remote_ping
3184 method, separate from the remote_print that we currently use.
3185 (BuilderControl.requestBuild): return a convenience Deferred that
3186 provides an IBuildStatus when the build finishes.
3187 (BuilderControl.ping): ping all connected slaves, only return True
3188 if they all respond.
3190 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3191 reconnect when we shut down.
3193 * buildbot/status/builder.py: implement new methods, convert
3194 one-build-at-a-time methods to handle multiple builds
3195 * buildbot/status/*.py: do the same in all default status targets
3196 * buildbot/status/html.py: report the build's slavename in the
3197 per-Build page, report all buildslaves on the per-Builder page
3199 * buildbot/test/test_run.py: update/create tests
3200 * buildbot/test/test_slaves.py: same
3201 * buildbot/test/test_scheduler.py: remove stale test
3203 * docs/buildbot.texinfo: document the new builder-specification
3204 'slavenames' parameter
3206 2005-10-12 Brian Warner <warner@lothar.com>
3208 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3209 report failure correctly, causing Dependent builds to run when
3210 they shouldn't have.
3211 * buildbot/status/builder.py (BuildSetStatus): same
3212 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3213 (Set.testSuccess): test the both-pass case too
3214 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3215 fix this test: it was ending too early, masking the failure before
3216 (Logger): specialized StatusReceiver to make sure the dependent
3217 builds aren't even started, much less completed.
3219 2005-10-07 Brian Warner <warner@lothar.com>
3221 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3222 bot.SlaveBuilder being disowned in the middle of a build
3224 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3225 this inherit from StatusReceiver. Also upcall in __init__. This
3226 fixes the embarrasing crash when the new buildSetSubmitted method
3227 is invoked and Waterfall/etc don't implement their own.
3228 * buildbot/test/test_run.py: add a TODO note about a test to catch
3229 just this sort of thing.
3231 * buildbot/process/builder.py (Builder.attached): remove the
3232 already-attached warning, this situation is normal. Add some
3233 comments explaining it.
3235 2005-10-02 Brian Warner <warner@lothar.com>
3237 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3238 OverflowError when setting up dnotify, because some 64-bit systems
3239 have problems with signed-vs-unsigned constants and trip up on the
3240 DN_MULTISHOT flag. Patch from Brad Hards.
3242 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3244 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3245 progressMetrics, description, descriptionDone to the 'parms' list,
3246 and make use the 'parms' list from the implementation class
3247 instead of only BuildStep to initialize the parameters. This
3248 allows buildbot.process.factory.s() to initialize all the parms,
3249 not just those defined in directly by BuildStep.
3251 2005-09-03 Brian Warner <warner@lothar.com>
3253 * NEWS: start adding items for the next release
3255 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3256 python2.2 tests, change 'Quick' builder to only use python2.3
3258 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3260 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3261 the "Ping Builder" button if the build control is available; the
3262 user sees an exception otherwise
3264 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3266 2005-09-01 Brian Warner <warner@lothar.com>
3268 * buildbot/interfaces.py (IBuilderStatus.getState): update
3269 signature, point out that 'build' can be None
3270 (IBuildStatus.getETA): point out ETA can be none
3272 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3274 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3276 2005-08-31 Brian Warner <warner@lothar.com>
3278 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3279 update to match correct signature: removed 'eta' argument
3280 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3282 2005-08-30 Brian Warner <warner@lothar.com>
3284 * buildbot/status/builder.py (LogFile): remove the assertion that
3285 blows up when you try to overwrite an existing logfile, instead
3286 just emit a warning. This case gets hit when the buildmaster is
3287 killed and doesn't get a chance to write out the serialized
3288 BuilderStatus object, so the .nextBuildNumber attribute gets out
3291 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3292 the 'buildbot sendchange' arguments, for the Darcs context file
3293 * docs/buildbot.texinfo (sendchange): document it
3295 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3296 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3297 (IStatus.getSchedulers): new method
3298 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3299 (Status.getSchedulers): implement
3300 * buildbot/process/builder.py (Builder): maintain
3301 BuilderStatus.pendingBuilds
3302 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3303 (TryBase.addChange): Try schedulers should ignore Changes
3305 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3306 for 'try' on CVS/SVN
3307 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3309 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3310 report status properly.
3311 (Try.createJob): implement unique buildset IDs
3313 * buildbot/status/client.py (StatusClientPerspective): add a
3314 perspective_getBuildSets method for the benefit of jobdir-style
3316 * docs/buildbot.texinfo (try): more docs
3317 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3320 2005-08-18 Brian Warner <warner@lothar.com>
3322 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3323 actually work. It's functional but still kind of clunky. Also, it
3324 only works with the pb-style.. needs to be made to work with the
3327 * buildbot/status/client.py (RemoteBuildSet): new class
3328 (RemoteBuildRequest): same
3329 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3330 object, not the internal BuildStatus object.
3331 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3332 outside of the usual buildStarted() return value.
3333 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3335 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3336 (Try_Userpass_Perspective.perspective_try): return a remotely
3337 usable BuildSetStatus object
3339 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3340 isStarted()/waitUntilStarted()
3342 2005-08-16 Brian Warner <warner@lothar.com>
3344 * buildbot/status/builder.py: implement IBuildSetStatus and
3345 IBuildRequestStatus, wire them into place.
3346 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3347 methods into the BuildSetStatus object.
3348 * buildbot/interfaces.py: same
3349 (IStatus.getBuildSets): new method to get pending BuildSets
3350 (IStatusReceiver.buildsetSubmitted): new method which hears about
3352 * buildbot/master.py (BuildMaster.submitBuildSet): same
3353 * buildbot/process/base.py (BuildRequest): same, replace
3354 waitUntilStarted with subscribe/unsubscribe
3355 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3356 subscribe instead of waitUntilStarted
3357 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3359 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3361 * buildbot/test/test_buildreq.py: update for new code
3362 * buildbot/test/test_control.py (Force.testRequest): same
3365 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3366 for Darcs to not use the tempfile module, so it works under
3367 python-2.2 too. We really didn't need the full cleverness of that
3368 module, since the slave has exclusive control of its own builddir.
3370 2005-08-15 Brian Warner <warner@lothar.com>
3372 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3373 for CVS trees. It doesn't work for non-trunk branches,
3375 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3378 * Makefile: make it easier to test against python2.2
3380 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3381 tearDown2, so things like Arch can unregister archives as they're
3382 shutting down. The previous subclass-override-tearDown technique
3383 resulted in a nested maybeWait() and test failures under
3386 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3387 where we can (Arch), add a branch= argument to set the branch used
3389 (BazExtractor): extract the branch too
3390 (TlaExtractor): same
3391 * buildbot/scripts/runner.py (TryOptions): add --branch
3392 * docs/buildbot.texinfo (try): document --branch/try_branch
3394 * buildbot/slave/commands.py (Darcs): implement get-revision for
3395 Darcs, so that 'try' will work. This requires the tempfile module
3398 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3399 of revisions, branches, and 'try' in the process.
3401 2005-08-11 Brian Warner <warner@lothar.com>
3403 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3404 this, it got broken at some point in the last few releases
3405 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3406 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3407 specifically the removal of ETA information from the tuple
3409 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3412 * docs/buildbot.texinfo (try): document both --builder and
3413 'try_builders' in .buildbot/options
3414 * buildbot/scripts/runner.py (TryOptions): add --builder,
3415 accumulate the values into opts['builders']
3416 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3417 * buildbot/test/test_runner.py (Try): add some quick tests to make
3418 sure 'buildbot try --options' and .buildbot/options get parsed
3419 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3420 use --builder control
3422 * docs/buildbot.texinfo (try): add --port argument to PB style
3424 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3425 actual SourceStamp. Still need to extract a branch name, somehow.
3426 (Try): finish implementing the try client side, still need a UI
3427 for specifying which builders to use
3428 (Try.getopt): factor our options/config-file reading
3429 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3431 * buildbot/test/test_vc.py: match SourceStampExtractor change
3433 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3434 causes the twisted log to be sent to stderr
3436 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3438 2005-08-10 Brian Warner <warner@lothar.com>
3440 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3441 style is 90% done, still missing status reporting or waiting for
3442 the buildsets to finish, and it is completely untested.
3444 * buildbot/trybuild.py: delete file, move contents to ..
3445 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3446 * buildbot/test/test_vc.py: match the move
3448 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3449 of the TryScheduler, no buildsetID or status-tracking support yet
3450 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3452 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3453 possible to set the basedir after __init__ time, so it is easier
3454 to use as a Service-child of the BuildMaster instance
3456 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3457 that delivers messages to its Service parent instead of requiring
3458 a subclass to be useful. This turns out to be much easier to build
3461 * buildbot/scripts/tryclient.py (createJob): utility code to
3462 create jobfiles, will eventually be used by 'buildbot try'
3464 2005-08-08 Brian Warner <warner@lothar.com>
3466 * docs/buildbot.texinfo (try): add docs on the
3467 as-yet-unimplemented Try scheduler
3469 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3470 * buildbot/test/test_scheduler.py: .. here
3471 (Scheduling.testTryJobdir): add placeholder test for 'try'
3473 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3474 addEntry merging (>=chunkSize) behavior
3475 (Log.testConsumer): update to handle new callLater(0) behavior
3477 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3478 both the MAX_LENGTH bugfix and the resumeProducing hang.
3480 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3481 put off the actual resumeProducing for a moment with
3482 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3483 causes large logfiles to hang midway through.
3485 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3486 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3487 and to improve memory usage when streaming the file out to a web
3489 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3490 make this work cleanly
3492 2005-08-03 Brian Warner <warner@lothar.com>
3494 * buildbot/trybuild.py: new file for 'try' utilities
3495 (getSourceStamp): run in a tree, find out the baserev+patch
3496 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3497 implemented for SVN and Darcs, still working on Arch. I don't know
3498 how to make CVS work yet.
3500 * docs/buildbot.texinfo: document the 'buildbot' command-line
3501 tool, including the not-yet-implemented 'try' feature, and the
3502 in-flux .buildbot/ options directory.
3504 2005-07-20 Brian Warner <warner@lothar.com>
3506 * buildbot/locks.py: added temporary id() numbers to Lock
3507 descriptions, to track down a not-really-sharing-the-Lock bug
3509 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3511 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3512 needed for python2.2 compatibility
3513 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3514 are from the __future__
3516 2005-07-19 Brian Warner <warner@lothar.com>
3518 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3519 message when schedulers use unknown builders
3521 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3522 SlaveLock('name') and MasterLock('name') are distinct
3524 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3525 c['schedulers'] in such a way that we can actually accept
3527 * buildbot/test/test_config.py: check it
3529 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3530 utility method to *all* the Schedulers
3531 (Periodic.listBuilderNames): same
3533 * docs/buildbot.texinfo (Interlocks): update chapter to match
3536 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3537 to make sure that c['sources'], c['schedulers'], and c['status']
3538 are all lists of the appropriate objects, and that the Schedulers
3539 all point to real Builders
3540 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3541 'listBuilderNames' utility method to support this
3542 * buildbot/scheduler.py: implement the utility method
3543 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3545 * docs/buildbot.texinfo: add some @cindex entries
3547 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3548 if it wasn't already set: most tla commands will fail unless one
3550 (Arch.createRepository): and disable bazaar's revision cache, since
3551 they cause test failures (the multiple repositories we create all
3552 interfere with each other through the cache)
3554 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3555 bring it properly up to date with twisted-2.0 test guidelines
3557 * buildbot/master.py (BuildMaster): remove references to old
3558 'interlock' module, this caused a bunch of post-merge test
3560 * buildbot/test/test_config.py: same
3561 * buildbot/process/base.py (Build): same
3563 * buildbot/test/test_slaves.py: stubs for new test case
3565 * buildbot/scheduler.py: add test-case-name tag
3566 * buildbot/test/test_buildreq.py: same
3568 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3569 unnecessary init code
3570 (Bot.remote_setBuilderList): match it
3572 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3574 * buildbot/changes/mail.py (parseSyncmail): update comment
3576 * buildbot/test/test_slavecommand.py: disable Shell tests on
3577 platforms that don't suport IReactorProcess
3579 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3580 all places where we open logfiles. It causes OS-X to open the file
3581 in some weird mode that that prevents us from mixing reads and
3582 writes to the same filehandle, which we depend upon to implement
3583 _generateChunks properly. This change doesn't appear to break
3584 win32, on which "b" and "t" are treated differently but a missing
3585 flag seems to be interpreted as "t".
3587 2005-07-18 Brian Warner <warner@lothar.com>
3589 * buildbot/slave/commands.py (ShellCommand): overhaul
3590 error-handling code, to try and make timeout/interrupt work
3591 properly, and make win32 happier
3592 * buildbot/test/test_slavecommand.py: clean up, stop using
3593 reactor.iterate, add tests for timeout and interrupt
3594 * buildbot/test/sleep.py: utility for a new timeout test
3596 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3597 code from the local-usebranches branch
3599 2005-07-17 Brian Warner <warner@lothar.com>
3601 * buildbot/process/process_twisted.py
3602 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3603 minutes, to match the other twisted BuildFactories, and don't
3604 excuse failures in c/qt/win32 reactors any more.
3606 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3607 'freebsd' builders, since the buildslaves have been unavailable
3610 2005-07-13 Brian Warner <warner@lothar.com>
3612 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3613 build-on-branch feature
3615 * buildbot/process/step.py (Darcs.__init__): add base_url and
3616 default_branch arguments, just like SVN
3617 (Arch.__init__): note that the version= argument is really the
3620 * buildbot/slave/commands.py (SourceBase): keep track of the
3621 repository+branch that was used for the last checkout in
3622 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3623 match, we clobber the directory and perform a fresh checkout
3624 rather than trying to do an in-place update. This should protect
3625 us against trying to get to branch B by doing an update in a tree
3626 obtained from branch A.
3627 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3628 (SVN.setup): same, just the svnurl
3629 (Darcs.setup): same, just the repourl
3630 (Arch.setup): same, arch coordinates (url), version, and
3631 buildconfig. Also pull the buildconfig from the args dictionary,
3632 which we weren't doing before, so the build-config was effectively
3634 (Arch.sourcedirIsUpdateable): don't try to update when we're
3635 moving to a specific revision: arch can't go backwards, so it is
3636 safer to just clobber the tree and checkout a new one at the
3638 (Bazaar.setup): same sourcedata as Arch
3640 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3641 use maybeWait, to work with twisted-1.3.0 and twcompat
3642 (Dependencies.testRun_Pass): same
3644 * buildbot/test/test_vc.py: rearrange, cleanup
3646 * buildbot/twcompat.py: add defer.waitForDeferred and
3647 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3648 can work under twisted-1.3.0 .
3650 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3651 now created at setUp time. This increases the runtime of the test
3652 suite considerably (from 91 seconds to 151), but it removes the
3653 need for an offline tarball, which should solve a problem I've
3654 seen where the test host has a different version of svn than the
3655 tarball build host. The new code also validates that mode=update
3656 really picks up recent commits. This approach will also make it
3657 easier to test out branches, because the code which creates the VC
3658 branches is next to the code which uses them. It will also make it
3659 possible to test some change-notification hooks, by actually
3660 performing a VC commit and watching to see the ChangeSource get
3663 2005-07-12 Brian Warner <warner@lothar.com>
3665 * docs/buildbot.texinfo (SVN): add branches example
3666 * docs/Makefile (buildbot.ps): add target for postscript manual
3668 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3669 * buildbot/test/test_locks.py: same
3671 * buildbot/process/step.py (Darcs): comment about default branches
3673 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3674 c['interlocks'] in the config file, complain if it is present.
3675 Scan all locks in c['builders'] to make sure the Locks they use
3677 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3678 add some tests to check for non-uniquely-named Locks
3679 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3680 since the unique-Lock validation code requires it now
3682 * buildbot/locks.py: fix test-case-name
3684 * buildbot/interlock.py: remove old file
3686 2005-07-11 Brian Warner <warner@lothar.com>
3688 * buildbot/test/test_interlock.py: rename to..
3689 * buildbot/test/test_locks.py: .. something shorter
3691 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3692 versions (after 2.0.1) changed internet.TCPClient to shut down the
3693 connection in stopService. Change the code to handle this
3696 * buildbot/process/base.py (Build): handle whole-Build locks
3697 * buildbot/process/builder.py (Builder.compareToSetup): same
3698 * buildbot/test/test_interlock.py: make tests work
3700 * buildbot/process/step.py (BuildStep.startStep): complain if a
3701 Step tries to claim a lock that's owned by its own Build
3702 (BuildStep.releaseLocks): typo
3704 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3705 file reloads don't replace unchanged Builders
3707 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3708 rewrite to cover new Locks instead of old c['interlocks']
3709 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3713 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3714 start the master and connect the buildslave
3716 * buildbot/process/step.py (FailingDummy.done): finish with a
3717 FAILURE status rather than raising an exception
3719 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3720 stringify a BuildRequest.reason that is None
3722 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3724 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3725 allow scheduler.Dependent to work
3726 * buildbot/buildset.py (BuildSet): set .reason and .results
3728 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3729 slaves, to make the test stop hanging. It still fails, of course,
3730 because I haven't even started to implement Locks.
3732 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3734 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3735 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3736 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3737 (Dependent): new class for downstream build dependencies
3738 * buildbot/test/test_dependencies.py: tests (still failing)
3740 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3742 2005-07-07 Brian Warner <warner@lothar.com>
3744 * buildbot/test/runutils.py (RunMixin): factored this class out..
3745 * buildbot/test/test_run.py: .. from here
3746 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3747 added new buildbot.locks tests (which all hang right now)
3748 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3749 * buildbot/process/step.py: claim/release per-BuildStep locks
3751 * docs/Makefile: add 'buildbot.html' target
3753 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3754 interpreted as "HEAD", so that all VC steps can accept branch=None
3755 and have it mean the "default branch".
3757 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3759 2005-07-07 Brian Warner <warner@lothar.com>
3761 * docs/examples/twisted_master.cfg: update to match current usage
3763 * docs/buildbot.texinfo (System Architecture): comment out the
3764 image, it doesn't exist yet and just screws up the HTML manual.
3766 2005-07-05 Brian Warner <warner@lothar.com>
3768 * debian/.cvsignore: oops, missed one. Removing leftover file.
3770 2005-06-17 Brian Warner <warner@lothar.com>
3772 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3773 changed its output in 1.2.0, don't mistakenly think that the
3774 subversion we find isn't capable of supporting our tests.
3776 * debian/*: remove the debian/ directory and its contents, to make
3777 life easier for the proper Debian maintainer
3779 * Makefile (release): same
3781 2005-06-07 Brian Warner <warner@lothar.com>
3783 * everything: create a distinct SourceStamp class to replace the
3784 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3785 Changed the signature of Source.startVC to include the revision
3786 information (instead of passing it through self.args). Implement
3787 branches for SVN (now only Darcs/Git is missing support). Add more
3790 2005-06-06 Brian Warner <warner@lothar.com>
3792 * everything: rearrange build scheduling. Create a new Scheduler
3793 object (configured in c['schedulers'], which submit BuildSets to a
3794 set of Builders. Builders can now use multiple slaves. Builds can
3795 be run on alternate branches, either requested manually or driven
3796 by changes. This changed some of the Status classes. Interlocks
3797 are out of service until they've been properly split into Locks
3798 and Dependencies. treeStableTimer, isFileImportant, and
3799 periodicBuild have all been moved from the Builder to the
3801 (BuilderStatus.currentBigState): removed the 'waiting' and
3802 'interlocked' states, removed the 'ETA' argument.
3804 2005-05-24 Brian Warner <warner@lothar.com>
3806 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3807 erroneously abandons the connection (in clientConnectionFailed)
3808 for non-UserErrors, which means that if we lose the connection due
3809 to a network problem or a timeout, we'll never try to reconnect.
3810 Fix this by not upcalling to the buggy parent method. Note:
3811 twisted-2.0 fixes this, but the function only has 3 lines so it
3812 makes more sense to copy it than to try and detect the buggyness
3813 of the parent class. Fixes SF#1207588.
3815 * buildbot/changes/changes.py (Change.branch): doh! Add a
3816 class-level attribute to accomodate old Change instances that were
3817 pickled before 0.6.5 (where .branch was added for new Changes).
3818 This fixes the exception that occurs when you try to look at an
3819 old Change (through asHTML).
3821 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3824 2005-05-23 Brian Warner <warner@lothar.com>
3826 * buildbot/__init__.py (version): release 0.6.6
3828 2005-05-23 Brian Warner <warner@lothar.com>
3830 * NEWS: update for 0.6.6 release
3831 * debian/changelog: same
3833 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3834 before starting: this was done by twistd back when we spawned it,
3835 now that we're importing the pieces and running them in the
3836 current process, we have to do it ourselves. This allows
3837 master.cfg to import files from the same directory without
3838 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3839 Stichele for the catch.
3840 (Options.opt_version): Add a --version command (actually, just make
3841 the existing --version command emit Buildbot's version too)
3843 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3844 fix to make this behave like other LogFiles, this time to handle
3845 existing LogFiles on disk. (add the missing .upgrade method)
3846 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3848 2005-05-21 Brian Warner <warner@lothar.com>
3850 * buildbot/test/test_runner.py (Create.testMaster): match the
3851 rawstring change in runner.py:masterTAC
3853 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3854 TwistedWords is installed
3855 * buildbot/test/test_status.py: same, with TwistedMail
3857 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3858 some old, deprecated, and removed config keys). This should enable
3859 you to use the base buildbot functionality with Twisted-2.0.0 when
3860 you don't also have TwistedWeb and TwistedWords installed
3862 2005-05-20 Brian Warner <warner@lothar.com>
3864 * buildbot/scripts/runner.py (run): call sendchange(), not
3865 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3866 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3867 (stop): don't wait for process to die when sending SIGHUP
3868 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3869 directory name gets interpreted, which you don't want
3872 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3875 2005-05-18 Brian Warner <warner@lothar.com>
3877 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3879 2005-05-18 Brian Warner <warner@lothar.com>
3881 * README: update for 0.6.5
3882 * debian/changelog: same
3884 * buildbot/changes/changes.py: rename tag= to branch=, since
3885 that's how we're using it, and my design for the upcoming "build a
3886 specific branch" feature wants it. also, tag= was too CVS-centric
3887 * buildbot/changes/mail.py (parseSyncmail): same
3888 * buildbot/process/base.py (Build.isBranchImportant): same
3889 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3890 * docs/buildbot.texinfo (Attributes of Changes): same
3892 * NEWS: update tag=, update for upcoming release
3894 2005-05-17 Brian Warner <warner@lothar.com>
3896 * buildbot/scripts/runner.py (stop): actually poll once per
3897 second, instead of re-killing the poor daemon once per second.
3898 Sleep briefly (0.1s) before the first poll, since there's a good
3899 chance we can avoid waiting the full second if the daemon shuts
3900 down quickly. Also remove the sys.exit() at the end.
3901 (start): remove the unneighborly sys.exit()
3903 * Makefile: improve permission-setting to not kick Arch so badly
3905 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3906 default --keepalive=600, since it doesn't hurt very much, and it's
3907 a hassle to discover that you need it.
3908 * buildbot/test/test_runner.py (Create.testSlave): test it
3910 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3911 IRC bot about EXCEPTION
3913 * buildbot/status/client.py (PBListener): upcall more correctly
3915 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3916 an exception mark the overall build with EXCEPTION, not SUCCESS
3918 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3920 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3921 * Makefile: update some release-related stuff
3923 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3924 gets called when there isn't actually an active process, just end
3925 the Command instead of blowing up. I don't know how it gets into
3926 this state, but the twisted win32 buildslave will sometimes hang,
3927 and when it shakes its head and comes back, it thinks it's still
3928 running a Command. The next build causes this command to be
3929 interrupted, but the lack of self.process.pid breaks the interrupt
3932 * NEWS: document changes since the last release
3934 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3935 look for Makefile.buildbot instead of a bare Makefile . The
3936 'buildbot start' does not install this file, so you have to
3937 manually copy it if you want to customize startup behavior.
3938 (createMaster): change 'buildbot master' command to create
3939 Makefile.sample instead of Makefile, to create master.cfg.sample
3940 instead of master.cfg (requiring you to copy it before the
3941 buildmaster can be started). Both sample files are kept up to
3942 date, i.e. they are overwritten if they have been changed. The
3943 'buildbot.tac' file is *not* overwritten, but if the new contents
3944 don't match the old, a 'buildbot.tac.new' file is created and the
3945 user is warned. This seems to be a much more sane way to handle
3946 startup files. Also, don't sys.exit(0) when done, so we can run
3947 unit tests against it.
3948 (createSlave): same. Don't overwrite the sample info/ files.
3949 * buildbot/scripts/sample.mk: remove. the contents were pulled
3950 into runner.py, since they need to match the behavior of start()
3954 * docs/buildbot.texinfo (Launching the daemons): document it
3955 * buildbot/test/test_runner.py (Create): test it
3957 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3958 version that can handle string-in-string tests, because otherwise
3959 python-2.2 fails the tests. It'd be tremendous if Trial's test
3960 took two strings under 2.2 too.
3962 * everything: fixed all deprecation warnings when running against
3963 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3964 few that come from Twisted itself). This involved putting most of
3965 the Twisted-version specific code in the new buildbot.twcompat
3966 module, and creating some abstract base classes in
3967 buildbot.changes.base and buildbot.status.base (which might be
3968 useful anyway). __implements__ is a nuisance and requires an ugly
3969 'if' clause everywhere.
3971 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3972 delay before finishing the test: it seems that smtp.sendmail
3973 doesn't hang up on the server, so we must wait a moment so it can
3974 hang up on us. This removes the trial warning about an unclean
3977 2005-05-16 Brian Warner <warner@lothar.com>
3979 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3980 tuple of (delay, repeats).
3981 * buildbot/test/test_vc.py (Retry): test it
3982 * docs/buildbot.texinfo (Source Checkout): document it
3983 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3984 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3985 doVCFull() are handled by re-trying the checkout (after a delay)
3986 some number of times.
3987 (ShellCommand._startCommand): make header lines easier to read
3989 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3991 (WebTest.test_logfile): make sure master gets shut down, silences
3992 some "unclean reactor" test errors
3994 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3995 reactor once after shutdown, something in certain versions of
3996 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3997 fails, svn-trunk is ok.
3999 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4000 second win32 error message
4002 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4003 validating the ETA, so the tests don't fail on slow systems
4005 2005-05-15 Brian Warner <warner@lothar.com>
4007 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4008 the new LogFile class, so upgrading works properly
4009 (LogFileProducer.resumeProducing): survive resumeProducing after
4010 we've exhausted the chunkGenerator
4012 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4014 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4015 (Log.testUpgrade): same
4017 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4018 Builds and logs with a cron job.
4020 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4021 of the old non-offline LogFile, added code to upgrade these to
4022 new-style contents-live-on-disk instances at load time (in a way
4023 that doesn't invalidate the old Build pickles, so upgrading to
4024 0.6.5 is not a one-way operation). Got rid of everything related
4026 (LogFile.__init__): create LogFiles with the parent step status,
4027 the log's name, and a builder-relative filename where it can keep
4028 the contents on disk.
4029 (LogFile.hasContents): new method, clients are advised to call it
4030 before getText or getChunks and friends. If it returns False, the
4031 log's contents have been deleted and getText() will raise an
4033 (LogFile.getChunks): made it a generator
4034 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4035 Consumer (except one that takes chunks instead of strings). This
4036 enables streaming of very large logfiles without storing the whole
4038 (BuildStatus.generateLogfileName): create names like
4039 12-log-compile-output, with a _0 suffix if required to be unique
4040 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4041 or earlier) logfiles into new-style ones
4042 (BuilderStatus): remove everything related to 'stub' builds. There
4043 is now only one build cache, and we don't strip logs from old
4045 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4046 since we no longer fight to keep it in the cache
4048 * buildbot/status/html.py (TextLog.render_GET): use a
4049 ChunkConsumer to stream the log entries efficiently.
4050 (ChunkConsumer): wrapper which consumes chunks and writes
4053 * buildbot/test/test_twisted.py (Parse.testParse): use a
4054 LogFile-like object instead of a real one
4056 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4057 (Log.testMerge3): validate more merge behavior
4058 (Log.testChunks): validate LogFile.getChunks
4059 (Log.testUpgrade): validate old-style LogFile upgrading
4060 (Log.testSubscribe): validate LogFile.subscribe
4061 (Log.testConsumer): validate LogFile.subscribeConsumer
4063 * buildbot/interfaces.py (IStatusLogStub): remove
4064 (IStatusLog.subscribeConsumer): new method
4065 (IStatusLog.hasContents): new method
4066 (IStatusLogConsumer): describes things passed to subscribeConsumer
4068 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4069 the log contents if it does not have any contents.
4070 (StatusResourceBuildStep.body): same
4071 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4073 2005-05-14 Brian Warner <warner@lothar.com>
4075 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4076 timeouts to try and make the windows metabuildslave not hang
4078 2005-05-13 Mike Taylor <bear@code-bear.com>
4080 * buildbot/slave/commands.py (rmdirRecursive): added a check
4081 to ensure the path passed into rmdirRecursive actually exists.
4082 On win32 a non-existant path would generate an exception.
4084 2005-05-13 Brian Warner <warner@lothar.com>
4086 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4087 shutil.rmtree which behaves correctly on windows in the face of
4088 files that you have to chmod before deleting. Thanks to Bear at
4089 the OSAF for the routine.
4090 (SourceBase.doClobber): use rmdirRecursive
4092 2005-05-12 Brian Warner <warner@lothar.com>
4094 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4095 method generate chunks instead of returning a big list. This
4096 allows the same method to be used for both old LogFile and new
4098 (OfflineLogFile.getText): use the generator
4099 (OfflineLogFile.subscribe): same
4100 * buildbot/status/html.py (TextLog.resumeProducing): same
4101 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4103 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4104 point out that OfflineLogFile does not currently work with
4105 html.Waterfall . Fixing this is high-priority.
4107 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4108 apparently windows defaults to using stdout
4110 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4111 better message on failure so I can figure out the win32 problem
4113 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4114 log messages to include more useful copies of the command being
4115 run, the argv array, and the child command's environment.
4116 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4118 2005-05-11 Brian Warner <warner@lothar.com>
4120 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4122 * Makefile: update the deb-snapshot version
4124 * docs/buildbot.texinfo: move all .xhtml docs into a new
4125 .texinfo-format document, adding a lot of material in the process.
4126 This is starting to look like a real user's manual. Removed all
4127 the Lore-related files: *.xhtml, *.css, template.tpl .
4128 * docs/Makefile: simple makefile to run 'makeinfo'
4129 * buildbot/scripts/sample.cfg: rearrange slightly
4130 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4132 2005-05-10 Brian Warner <warner@lothar.com>
4134 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4135 different name for the internal twistw module, handle it.
4137 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4138 * setup.py: .. and stop trying to install it
4140 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4141 'git'), the new linux kernel VC system (http://kernel.org/git/).
4142 Thanks to Brandon Philips for the patch.
4143 * buildbot/slave/commands.py (Git): same
4145 2005-05-06 Brian Warner <warner@lothar.com>
4147 * buildbot/status/builder.py (OfflineLogFile): replace the default
4148 LogFile with a form that appends its new contents to a disk file
4149 as they arrive. The complete log data is never kept in RAM. This
4150 is the first step towards handling very large (100MB+) logfiles
4151 without choking quite so badly. (The other half is
4152 producer/consumer on the HTML pages).
4153 (BuildStepStatus.addLog): use OfflineLogFile by default
4154 (BuildStatus.getLogfileName): helper code to give the
4155 OfflineLogFile a filename to work with
4157 * buildbot/test/test_status.py (Results.testAddResults): update
4158 tests to handle new asserts
4159 * buildbot/test/test_vc.py (Patch.doPatch): same
4160 * buildbot/test/test_steps.py (BuildStep.setUp): same
4162 2005-05-05 Brian Warner <warner@lothar.com>
4164 * buildbot/scripts/runner.py (start): if there is no Makefile,
4165 launch the app by importing twistd's internals and calling run(),
4166 rather than spawning a new twistd process. This stands a much
4167 better chance of working under windows.
4168 (stop): kill the process with os.kill instead of spawning
4169 /bin/kill, again to reduce the number of external programs which
4170 windows might not have in the PATH. Also wait up to 5 seconds for
4171 the process to go away, allowing things like 'buildbot stop;
4172 buildbot start' to be reliable in the face of slow shutdowns.
4174 * buildbot/master.py (Dispatcher.__getstate__): remove old
4175 .tap-related methods
4176 (BuildMaster.__getstate__): same
4178 * buildbot/slave/bot.py (makeService): same
4179 (Options.longdesc): same
4180 * buildbot/scripts/runner.py: copy over some old mktap option text
4182 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4183 'buildbot master' now creates a buildbot.tac file, so there is no
4184 longer a create-instance/save/reload sequence. mktap is dead, long
4186 * buildbot/scripts/sample.mk: use twistd -y, not -f
4187 * buildbot/test/test_config.py: remove mktap-based test
4188 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4189 * README: don't reference mktap
4191 * docs/source.xhtml: document some of the attributes that Changes
4194 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4196 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4197 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4198 * buildbot/changes/changes.py (Change)
4199 * buildbot/changes/mail.py (parseSyncmail)
4200 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4202 * buildbot/process/base.py (Build.isTagImportant)
4206 2005-05-04 Brian Warner <warner@lothar.com>
4208 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4209 connection after sending the change, so that unit tests don't
4210 complain about sockets being left around
4212 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4213 exception in phase=0 rendering
4214 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4216 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4218 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4219 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4220 and configuring builders with tuples.
4221 * buildbot/test/test_config.py: stop testing compatibility with
4222 deprecated config keys
4223 * buildbot/test/test_run.py: same
4225 2005-05-03 Brian Warner <warner@lothar.com>
4227 * contrib/arch_buildbot.py: survive if there are no logfiles
4228 (username): just use a string, os.getlogin isn't reliable
4230 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4231 so 'buildbot sendchange' actually works. The earlier test only
4232 covered the internal (non-reactor-running) form.
4234 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4235 script to notify the buildmaster about changes
4237 * buildbot/scripts/runner.py (sendchange): new command to send a
4238 change to a buildbot.changes.pb.PBChangeSource receiver.
4239 * buildbot/test/test_changes.py (Sender): test it
4241 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4242 after any reading of the config file, not just when we do it in
4243 startService. This makes some tests a bit cleaner.
4245 * buildbot/changes/pb.py: add some log messages
4247 * buildbot/process/base.py (Build.startBuild): fix a bug that
4248 caused an exception when the build terminated in the very first
4250 (Build.stepDone): let steps return a status of EXCEPTION. This
4251 terminates the build right away, and sets the build's overall
4252 status to EXCEPTION too.
4253 * buildbot/process/step.py (BuildStep.failed): return a status of
4254 EXCEPTION when that is what has happened.
4256 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4257 implement this, allowing Arch-based projects to get precise
4258 checkouts instead of always using the latest code
4259 (Bazaar): create variant of Arch to let folks use baz instead of
4260 tla. Requires a new buildslave too.
4261 * buildbot/slave/commands.py (Arch): add 'revision' argument
4262 (Bazaar): create variant of Arch that uses baz instead of tla.
4263 Remove the code that extracts the archive name from the
4264 register-archive output, since baz doesn't provide it, and require
4265 the user provide both the archive name and its location.
4266 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4268 2005-05-02 Brian Warner <warner@lothar.com>
4270 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4271 thanks to Nick Trout.
4273 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4274 deals better with source Makefile coming from a read-only CVS
4275 checkout. Thanks to Nick Trout for the catch.
4277 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4280 2005-04-28 Brian Warner <warner@lothar.com>
4282 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4284 * debian/changelog: update for 0.6.4
4286 2005-04-28 Brian Warner <warner@lothar.com>
4288 * README.w32: add a checklist of steps for getting buildbot
4290 * MANIFEST.in: include it in the tarball
4294 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4295 broken .tap files from 0.6.3 by getting rid of .services,
4296 .namedServices, and .change_svc at load time.
4298 2005-04-27 Brian Warner <warner@lothar.com>
4300 * NEWS: update in preparation for new release
4302 * buildbot/test/test_config.py (Save.testSave): don't pull in
4303 twisted.scripts.twistd, we don't need it and it isn't for windows
4306 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4307 accomodate win32 which can't do atomic-rename
4309 2005-04-27 Brian Warner <warner@lothar.com>
4311 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4312 timeouts to help the slow metabuildbot not flunk them so much
4313 (Disconnect.testBuild3): same
4314 (Disconnect.testBuild4): same
4315 (Disconnect.testInterrupt): same
4317 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4318 setup, it was completely broken for new buildmasters (those which
4319 did not have a 'change.pck' already saved. Thanks to Paul Warren
4320 for catching this (embarrassing!) bug.
4321 (Dispatcher.__getstate__): don't save our registered avatar
4322 factories, since they'll be re-populated when the config file is
4324 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4325 tests (since the real mktap-generated BuildMaster doesn't save
4327 (BuildMaster.__getstate__): don't save any service children,
4328 they'll all be re-populated when the config file is re-read.
4329 * buildbot/test/test_config.py (Save.testSave): test for this
4331 2005-04-26 Brian Warner <warner@lothar.com>
4333 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4334 rendered with Blender.. looks a bit nicer.
4335 * buildbot/docs/images/icon.blend: add the Blender file for it
4337 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4338 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4339 running under windows. This appears to be the best way to allow
4340 BuildSteps to do something normal like 'trial -v buildbot.test' or
4341 'make foo' and still expect it to work. The idea is to make the
4342 BuildSteps look as much like what a developer would type when
4343 compiling or testing the tree by hand. This approach probably has
4344 problems when there are spaces in the arguments, so if you've got
4345 windows buildslaves, you'll need to pay close attention to your
4348 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4349 timezone to the timestamp column.
4350 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4352 * buildbot/scripts/runner.py (loadOptions): do something sane for
4353 windows, I think. We use %APPDATA%/buildbot instead of
4354 ~/.buildbot, but we still search everywhere from the current
4355 directory up to the root for a .buildbot/ subdir. The "is it under
4356 $HOME" security test was replaced with "is it owned by the current
4357 user", which is only performed under posix.
4358 * buildbot/test/test_runner.py (Options.testFindOptions): update
4359 tests to match. The "is it owned by the current user" check is
4360 untested. The test has been re-enabled for windows.
4362 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4363 any "\n" in the expected output with the platform-specific line
4364 separator. Make this separator "\r\n" on PTYs under unix, they
4365 seem to do that and I don't know why
4367 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4368 windows for now, I don't know what ~/.buildbot/ should mean there.
4370 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4371 win32 compatibility, don't use "/tmp"
4372 (Basedir.testChangeBuilddir): remove more unixisms
4374 2005-04-26 Brian Warner <warner@lothar.com>
4376 * buildbot/test/test_control.py (Force.rmtree): python2.2
4377 compatibility, apparently its shutil.rmtree ignore_errors=
4378 argument is ignored.
4379 * buildbot/test/test_run.py (Run.rmtree): same
4380 (RunMixin.setUp): same
4382 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4385 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4386 'substring in string' operator, must use string.find(substr)!=-1
4387 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4388 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4390 * buildbot/scripts/runner.py (loadOptions): add code to search for
4391 ~/.buildbot/, a directory with things like 'options', containing
4392 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4393 the current directory, your $HOME directory, or anywhere
4394 inbetween, as long as you're somewhere inside your home directory.
4395 (debugclient): look in ~/.buildbot/options for master and passwd
4396 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4397 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4399 * buildbot/status/client.py (makeRemote): new approach to making
4400 IRemote(None) be None, which works under Twisted-2.0
4401 * buildbot/test/test_status.py (Client.testAdaptation): test it
4403 * buildbot/status/builder.py (Status.builderAdded): when loading a
4404 pickled BuilderStatus in from disk, set its name after loading.
4405 The config file might have changed its name (but not its
4406 directory) while it wasn't looking.
4408 * buildbot/process/builder.py (Builder.attached): always return a
4409 Deferred, even if the builder was already attached
4410 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4412 2005-04-25 Brian Warner <warner@lothar.com>
4414 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4415 category-related exception when announcing a build has finished
4417 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4418 reference no-longer-existent changemaster.sources
4419 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4421 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4424 2005-04-25 Brian Warner <warner@lothar.com>
4426 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4428 * debian/changelog: update for 0.6.3
4430 2005-04-25 Brian Warner <warner@lothar.com>
4432 * MANIFEST.in: make sure debug.glade is in the tarball
4434 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4436 * NEWS: update for the imminent 0.6.3 release
4438 * buildbot/status/html.py (HtmlResource.content): make the
4439 stylesheet <link> always point at "buildbot.css".
4440 (StatusResource.getChild): map "buildbot.css" to a static.File
4441 containing whatever css= argument was provided to Waterfall()
4442 (Waterfall): provide the "classic" css as the default.
4443 * docs/waterfall.classic.css: move default CSS from here ..
4444 * buildbot/status/classic.css: .. to here
4446 * MANIFEST.in: make sure classic.css is included in the tarball
4447 * setup.py: and that it is installed too, under buildbot/status/
4449 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4450 the module level, because buildbot.tap files from 0.6.2 don't have
4451 it in their attribute dictionary.
4453 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4454 really exists at startup, might save some confusion somewhere.
4456 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4458 * docs/waterfall.classic.css:
4459 add a stylesheet that's almost the same as the "classic"
4462 * buildbot/status/builder.py:
4463 add EXCEPTION as a result - this is a problem for the bot
4464 maintainer, not a build problem for the changers
4465 * buildbot/process/step.py:
4466 use EXCEPTION instead of FAILURE for exceptions
4467 * buildbot/status/html.py:
4468 add build_get_class to get a class out of a build/buildstep
4469 finish naming the classes
4470 split out sourceNames to changeNames and builderNames so we
4471 can style them separately
4472 * docs/config.xhtml:
4473 finish documenting classes as they are right now
4475 * buildbot/status/html.py:
4476 name the classes as we agreed on IRC
4477 * docs/config.xhtml:
4480 * buildbot/status/html.py:
4481 same for cssclass->class_
4483 * buildbot/status/html.py:
4484 as decided on IRC, use class_ for the "class" attribute to not
4485 conflict with the class keyword, and clean up the messy **{} stuff.
4487 * buildbot/status/mail.py:
4488 put back "builders" argument, and fix docstring, because the
4489 code *ignores* builders listed in this argument
4491 * buildbot/process/builder.py:
4492 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4494 * docs/config.xhtml:
4495 describe the category argument for builders
4497 * buildbot/status/builder.py:
4498 Fix a silly bug due to merging
4500 * buildbot/process/builder.py:
4501 remove category from the process Builder ...
4502 * buildbot/status/builder.py:
4503 ... and add it to BuilderStatus instead.
4504 Set category on unpickled builder statuses, they might not have it.
4505 * buildbot/master.py:
4506 include category when doing builderAdded
4507 * buildbot/status/mail.py:
4508 return None instead of self for builders we are not interested in.
4509 * buildbot/test/test_run.py:
4510 fix a bug due to only doing deferredResult on "dummy" waiting
4511 * buildbot/test/test_status.py:
4512 add checks for the Mail IStatusReceiver returning None or self
4514 * buildbot/status/html.py:
4515 fix testsuite by prefixing page title with BuildBot
4517 * buildbot/status/builder.py:
4518 have .category in builder status ...
4519 * buildbot/process/builder.py:
4520 ... and set it from Builder
4521 * buildbot/status/html.py:
4522 make .css a class variable
4523 * buildbot/test/test_status.py:
4524 write more tests to cover our categories stuff ...
4525 * buildbot/status/mail.py:
4526 ... and fix the bug that this uncovered
4528 * buildbot/changes/mail.py:
4529 * buildbot/changes/pb.py:
4530 * buildbot/master.py:
4531 * buildbot/process/base.py:
4532 * buildbot/process/factory.py:
4533 * buildbot/process/interlock.py:
4534 * buildbot/process/step.py:
4535 * buildbot/process/step_twisted.py:
4536 * buildbot/slave/commands.py:
4537 * buildbot/status/builder.py:
4538 * buildbot/status/client.py:
4539 * buildbot/status/html.py:
4540 * buildbot/status/mail.py:
4541 * buildbot/status/progress.py:
4542 * buildbot/test/test_changes.py:
4543 * buildbot/test/test_config.py:
4544 * buildbot/test/test_control.py:
4545 * buildbot/test/test_interlock.py:
4546 * buildbot/test/test_maildir.py:
4547 * buildbot/test/test_mailparse.py:
4548 * buildbot/test/test_run.py:
4549 * buildbot/test/test_slavecommand.py:
4550 * buildbot/test/test_status.py:
4551 * buildbot/test/test_steps.py:
4552 * buildbot/test/test_twisted.py:
4553 * buildbot/test/test_util.py:
4554 * buildbot/test/test_vc.py:
4555 * buildbot/test/test_web.py:
4557 add test-case-name at the top of a whole set of files
4559 * buildbot/status/builder.py:
4560 keep order of addition when getting builder names
4561 * buildbot/status/words.py:
4562 * buildbot/test/test_run.py:
4563 add test for getBuilderNames
4565 * buildbot/process/base.py:
4566 * buildbot/process/step.py:
4567 * buildbot/status/builder.py:
4568 * buildbot/status/html.py:
4569 make buildbot css-able
4570 replace the color code for purple with purple, don't understand
4571 why it wasn't purple to start with
4573 * buildbot/status/words.py:
4574 ok, so it doesn't look like BuilderStatus.remote is still valid.
4575 Use what waterfall uses instead.
4577 * buildbot/interfaces.py:
4578 * buildbot/status/builder.py:
4579 * buildbot/status/html.py:
4580 * buildbot/status/mail.py:
4581 * buildbot/status/words.py:
4582 * buildbot/test/test_run.py:
4583 use categories everywhere and make it be a list. More sensible
4584 for the future. Also make words actually respect this in
4587 * buildbot/interfaces.py:
4588 add category argument to getBuilderNames
4589 * buildbot/process/builder.py:
4590 * buildbot/status/builder.py:
4591 * buildbot/status/html.py:
4592 * buildbot/status/mail.py:
4593 * buildbot/status/words.py:
4594 * buildbot/test/test_run.py:
4595 move from specifying builders by name to specifying the category
4597 * buildbot/status/html.py:
4598 * buildbot/status/words.py:
4599 add "builders=" to __init__ of status clients so they can
4600 limit themselves to the given list of builders to report on
4602 * buildbot/status/html.py: set the title to the product name
4604 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4606 * buildbot/interfaces.py:
4607 * buildbot/status/builder.py:
4608 more documentation. Hm, not sure if ChangeLog entries make sense
4611 2005-04-23 Brian Warner <warner@lothar.com>
4613 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4615 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4617 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4618 the sub-commands that log buildmaster status to stdout and to a
4619 GUI window, respectively.
4621 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4622 functionality is working again, but all the step-status and ETA
4623 stuff is missing. Commented out a lot of code pending more
4626 * buildbot/status/client.py: make sure that IRemote(None) is None
4628 * buildbot/changes/changes.py: import defer, oops
4629 (ChangeMaster): remove the .sources list, rely upon the fact that
4630 MultiServices can be treated as sequences of their children. This
4631 cleans up the add/remove ChangeSource routines a lot, as we keep
4632 exactly one list of the current sources instead of three.
4634 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4635 up an empty ChangeMaster at init time.
4636 (BuildMaster.loadChanges): if there are changes to be had from
4637 disk, replace self.change_svc with the new ones. If not, keep
4638 using the empty ChangeMaster set up in __init__.
4639 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4640 instead of a separate list, makes the code a bit cleaner.
4641 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4642 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4643 Extend the test to make sure we can get rid of the sources when
4646 2005-04-22 Brian Warner <warner@lothar.com>
4648 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4649 and info/host files when making the slave directory
4651 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4652 whendone= argument, just return the Deferred and let the caller do
4653 what they want with it.
4654 (Disconnect.testBuild1): wait for shutdownSlave
4655 (Basedir.testChangeBuilddir): new test to make sure changes to the
4656 builddir actually get propagated to the slave
4658 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4659 explicit method, rather than passing the builddir in __init__ .
4660 Make sure to update self.basedir too, this was broken before.
4661 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4662 builders and for ones that have just had their builddir changed.
4663 (BotFactory): add a class-level .perspective attribute, so
4664 BuildSlave.waitUntilDisconnected won't get upset when the
4665 connection hasn't yet been established
4666 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4667 tests can reach through it to inspect the SlaveBuilders
4669 * buildbot/process/base.py (Build.buildException): explain the
4670 log.err with a log.msg
4671 * buildbot/process/builder.py (Builder.startBuild): same
4672 (Builder._startBuildFailed): improve error message
4674 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4675 occurred because we lost the brand-new connection, retry instead
4676 of giving up. If not, it's probably an authorization failure, and
4677 it makes sense to stop trying. Make sure we log.msg the reason
4678 that we're log.err'ing the failure, otherwise test failures are
4679 really hard to figure out.
4681 * buildbot/master.py: change loadConfig() to return a Deferred
4682 that doesn't fire until the change has been fully implemented.
4683 This means any connected slaves have been updated with the new
4684 builddir. This change makes it easier to test the code which
4685 actually implements this builddir-updating.
4686 (BotPerspective.addBuilder): return Deferred
4687 (BotPerspective.removeBuilder): same
4688 (BotPerspective.attached): same
4689 (BotPerspective._attached): same. finish with remote_print before
4690 starting the getSlaveInfo, instead of doing them in parallel
4691 (BotPerspective.list_done): same
4692 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4693 actually calling slave.disconnect()
4694 (BotMaster.addBuilder): same
4695 (BotMaster.removeBuilder): same
4696 (BuildMaster.loadConfig): same
4697 (BuildMaster.loadConfig_Slaves): same
4698 (BuildMaster.loadConfig_Sources): same
4699 (BuildMaster.loadConfig_Builders): same
4700 (BuildMaster.loadConfig_status): same
4702 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4703 a Deferred that fires when the source is finally removed
4705 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4706 the previous tree on win32, where we have to do it synchronously,
4707 make sure we return a Deferred anyway.
4708 (SourceBase.doCopy): same
4710 * buildbot/scripts/runner.py (statusgui): use the text client for
4711 now, while I rewrite the Gtk one
4712 * buildbot/clients/base.py: strip out old code, leaving just the
4713 basic print-message-on-event functionality. I also remove the
4714 ReconnectingPBClientFactory, but it does at least quit when it
4715 loses the connection instead of going silent
4717 2005-04-21 Brian Warner <warner@lothar.com>
4719 * Makefile: minor tweaks
4721 * NEWS: point out deprecation warnings, new features for
4724 * buildbot/master.py (BuildMaster.loadConfig): emit
4725 DeprecationWarnings for Builders defined with tuples. Rearrange
4726 code to facility removal of deprecated configuration keys in the
4729 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4730 'buildbot' command to put a little Makefile in the target that
4731 helps you re-create the buildbot.tap file, start or stop the
4732 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4733 all the files 0600, since they contain passwords.
4734 (start): if there is a Makefile, and /usr/bin/make exists, use
4735 'make start' in preference to a raw twistd command. This lets
4736 slave admins put things like PYTHONPATH variables in their
4737 Makefiles and have them still work when the slave is started with
4738 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4739 be nice to first try the 'make' command and only fall back to
4740 twistd if it fails. TODO: the Makefile's "start" command does not
4741 add the --reactor=win32 argument when running under windows.
4742 (Options.debugclient, Options.statusgui): add sub-commands to launch
4743 the debug client (formerly in contrib/debugclient.py) and the
4744 Gtk status application (currently broken)
4745 * buildbot/clients/debug.py: move from contrib/debugclient.py
4746 * buildbot/clients/debug.glade: same
4748 * buildbot/test/test_trial.py: remove it. This requires some
4749 functionality out of Twisted that isn't there yet, and until then
4750 having it around just confuses things.
4752 * buildbot/test/test_slavecommand.py (Shell): test both with and
4753 without PTYs, and make sure that command output is properly
4754 interleaved in the with-PTY case. I think the without-PTY test
4755 should pass on windows, where we never use PTYs anyway.
4757 2005-04-20 Brian Warner <warner@lothar.com>
4759 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4761 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4763 * NEWS: start creating entries for the next release
4765 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4767 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4768 (WebTest.test_webPathname): same
4769 (WebTest.test_webPathname_port): same
4770 (WebTest.test_waterfall): use the default favicon rather than
4771 rooting around the filesystem for it. Open the expected-icon file
4772 in binary mode, to make win32 tests happier (thanks to Nick Trout
4774 * buildbot/status/html.py (buildbot_icon): win32 portability
4776 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4777 win32-compatibility fixes from Nick Trout, the "file not found" message
4778 is different under windows
4779 (FakeSlaveBuilder.__init__): clean up setup a bit
4780 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4782 2005-04-19 Brian Warner <warner@lothar.com>
4784 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4785 skip-if-repositories-are-unavailable test to not kill the trial
4786 that comes with Twisted-1.3.0
4788 * setup.py: install buildbot.png icon file when installing code
4790 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4791 environment used by the command, at least on the child side.
4793 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4794 this method needs to be added and implemented because it gets
4795 called under heavy load. I don't quite understand the
4796 producer/consumer API enough to write it.
4797 (StatusResource.getChild): add a resource for /favicon.ico
4798 (Waterfall.__init__): add favicon= argument
4799 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4800 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4801 (WebTest.test_webPathname): same
4802 (WebTest.test_webPathname_port): same
4803 * docs/config.xhtml: mention favicon=
4804 * buildbot/buildbot.png: add a default icon, dorky as it is
4806 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4808 * buildbot/master.py:
4809 * buildbot/process/base.py:
4810 * buildbot/process/builder.py:
4811 * buildbot/process/interlock.py:
4812 * buildbot/status/builder.py:
4813 * buildbot/status/html.py:
4814 * buildbot/status/mail.py:
4815 * buildbot/status/words.py:
4816 new documentation while digging through the code
4818 2005-04-17 Brian Warner <warner@lothar.com>
4820 * general: try to fix file modes on all .py files: a+r, a-x,
4821 but let buildbot/clients/*.py be +x since they're tools
4823 * docs/epyrun (addMod): when an import fails, say why
4825 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4827 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4829 * buildbot/process/base.py:
4830 * buildbot/process/builder.py:
4831 * buildbot/status/builder.py:
4832 new documentation while digging through the code
4834 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4836 * buildbot/changes/changes.py:
4837 * buildbot/changes/p4poller.py:
4838 * buildbot/interfaces.py:
4839 * buildbot/process/base.py:
4840 * buildbot/process/builder.py:
4841 * buildbot/process/step.py:
4842 * buildbot/process/step_twisted.py:
4843 * buildbot/slave/bot.py:
4844 * buildbot/slave/commands.py:
4845 * buildbot/status/builder.py:
4846 fix all docstrings to make epydoc happy. In the process of fixing
4847 some, I also moved pieces of docs, and removed some deprecated
4850 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4852 * buildbot/process/builder.py:
4853 * buildbot/process/interlock.py:
4854 * buildbot/process/process_twisted.py:
4855 * buildbot/process/step.py:
4856 BuildProcess -> Build, as it looks like that's what happened
4857 * buildbot/process/base.py:
4858 * buildbot/process/factory.py:
4861 2005-04-17 Brian Warner <warner@lothar.com>
4863 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4864 update compile command to accomodate the Twisted split.. now
4865 instead of './setup.py build_ext -i', you do './setup.py all
4866 build_ext -i', to run build_ext over all sub-projects.
4867 (FullTwistedBuildFactory): same
4868 (TwistedReactorsBuildFactory): same
4870 * buildbot/status/html.py (TextLog.finished): null out self.req
4871 when we're done, otherwise the reference cycle of TextLog to .req
4872 to .notifications to a Deferred to TextLog.stop keeps them from
4873 being collected, and consumes a huge (610MB on pyramid at last
4874 check) amount of memory.
4876 2005-04-11 Brian Warner <warner@lothar.com>
4878 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4879 normalize the VC-repository location.. makes SVN happier with
4880 certain test environments.
4882 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4883 RemoteShellCommand gets its own .env dictionary, so that code in
4884 start() doesn't mutate the original. I think this should fix the
4885 step_twisted.Trial problem where multiple identical components
4886 kept getting added to PYTHONPATH= over and over again.
4888 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4889 adding epydoc-format docstrings to many classes. Thanks to Thomas
4890 Vander Stichele for the patches.
4891 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4892 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4893 * buildbot/slave/bot.py, commands.py, registry.py: same
4895 2005-04-05 Brian Warner <warner@lothar.com>
4897 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4898 preserve timestamps, helps incremental builds of large trees.
4899 Patch from Rene Rivera.
4901 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4902 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4905 2005-04-03 Brian Warner <warner@lothar.com>
4907 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4908 with one dict, apparently exec has some scoping bugs when used
4909 with both global/local dicts. Thanks to Nathaniel Smith for the
4912 2005-04-02 Brian Warner <warner@lothar.com>
4914 * buildbot/process/step_twisted.py (countFailedTests): the new
4915 trial in Twisted-2.0 emits a slightly different status line than
4916 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4917 mistakenly think the test count is unparseable.
4918 (Trial.start): note that for some reason each build causes another
4919 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4920 be fixed but I'm not sure quite where the problem is.
4922 2005-04-01 Brian Warner <warner@lothar.com>
4924 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4925 deferredResult to avoid hangs/warnings under twisted-2.0
4926 (RunMixin.tearDown): same
4927 (RunMixin.shutdownSlave): same
4928 (Disconnect.testIdle1): same
4929 (Disconnect.testBuild2): same: wait one second after the build
4930 finishes for test to really be done.. this should be cleaned up to
4931 avoid wasting that second. Builder.detach uses a callLater(0),
4932 either that should be done in-line (something else needed that
4933 behavior), or it should return a Deferred that fires when the
4934 builder is really offline.
4935 (Disconnect.testBuild3): same
4936 (Disconnect.testDisappear): same
4938 * buildbot/test/test_web.py: rearrange server-setup and teardown
4939 code to remove unclean-reactor warnings from twisted-2.0
4941 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4942 so the tests don't hang under twisted-2.0
4944 2005-03-31 Brian Warner <warner@lothar.com>
4946 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4947 caused a warning each time the master changed our set of builders
4949 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4950 w32, don't unlink the file unless it already exists. Thanks to
4951 Baptiste Lepilleur for the catch.
4952 (BuilderStatus.saveYourself): same
4954 2005-02-01 Brian Warner <warner@lothar.com>
4956 * buildbot/status/html.py (TextLog.getChild): use a /text child
4957 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4958 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4959 logfile as text/plain (no markup, no headers). This replaces the
4960 previous scheme (which used an ?text=1 argument), and gets us back
4961 to a relative link (which works better when the buildbot lives
4962 behind another web server, such as Apache configured as a reverse
4963 proxy). Thanks to Gerald Combs for spotting the problem.
4965 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4968 2004-12-13 Brian Warner <warner@lothar.com>
4970 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4972 * debian/changelog: update for 0.6.2
4973 * NEWS: finalize for 0.6.2
4975 2004-12-11 Brian Warner <warner@lothar.com>
4977 * NEWS: bring it up to date
4979 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4980 detection code. Require some sign of life from the buildmaster
4981 every BotFactory.keepaliveInterval seconds. Provoke this
4982 indication at BotFactory.keepaliveTimeout seconds before the
4983 deadline by sending a keepalive request. We don't actually care if
4984 that request is answered in a timely fashion, what we care about
4985 is that .activity() is called before the deadline. .activity() is
4986 triggered by any PB message from the master (including an ack to
4987 one of the slave's status-update messages). With this new scheme,
4988 large status messages over slow pipes are OK, as long as any given
4989 message can be sent (and thus acked) within .keepaliveTimeout
4990 seconds (which defaults to 30).
4991 (SlaveBuilder.remote_startCommand): record activity
4992 (SlaveBuilder.ackUpdate): same
4993 (SlaveBuilder.ackComplete): same
4994 (BotFactory.gotPerspective): same
4995 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4997 2004-12-09 Brian Warner <warner@lothar.com>
4999 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5002 * buildbot/process/step_twisted.py (Trial._commandComplete):
5003 update self.cmd when we start the 'cat test.log' transfer. Without
5004 this, we cannot interrupt the correct RemoteCommand when we lose
5007 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5008 trying to tell the slave to stop the command if we're already
5009 inactive, or if we no longer have a .remote
5011 * buildbot/process/builder.py (Builder._detached): don't let an
5012 exception in currentBuild.stopBuild() prevent the builder from
5013 being marked offline
5015 2004-12-07 Brian Warner <warner@lothar.com>
5017 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5018 KeyError that happens when you ask for a non-existent Builder, and
5019 translate it into a UsageError.
5021 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5022 losing the slave in the middle of a remote step is handled too
5024 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5025 be a Failure, so be sure to stringify it before using it as the
5026 contents of the 'interrupt' logfile
5027 (RemoteCommand.interrupt): use stringified 'why' in
5028 remote_interruptCommand too, just in case
5030 2004-12-06 Brian Warner <warner@lothar.com>
5032 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5033 instead of 'tla update', which is more efficient in case we've
5034 missed a couple of patches since the last update.
5036 * debian/changelog: update for previous (0.6.1) release. Obviously
5037 this needs to be handled better.
5039 2004-12-05 Brian Warner <warner@lothar.com>
5041 * NEWS: update for stuff since last release
5043 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5044 match the maybeDeferred change in Dispatcher.requestAvatar
5045 * buildbot/changes/pb.py (ChangePerspective.attached): same
5046 * buildbot/status/client.py (StatusClientPerspective.attached): same
5047 * buildbot/process/builder.py (Builder._attached3): same
5048 * buildbot/pbutil.py (NewCredPerspective.attached): same
5050 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5051 the date to the top-most box, if it is not the same as today's
5054 * docs/slave.xhtml: provide a buildslave setup checklist
5056 * docs/source.xhtml (Arch): correct terminology
5058 2004-12-04 Brian Warner <warner@lothar.com>
5060 * buildbot/test/test_slavecommand.py: use sys.executable instead
5061 of hard-coding 'python' for child commands, might help portability
5063 * docs/examples/twisted_master.cfg: update to current usage
5065 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5066 'stop build' command to the IRC bot
5068 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5069 message that broke PBChangeSource
5071 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5072 (SlaveBuilder): make some attributes class-level, remove the old
5073 "update queue" which existed to support resuming a build after the
5074 master connection was lost. Try to reimplement that feature later.
5075 (SlaveBuilder.stopCommand): clear self.command when the
5076 SlaveCommand finishes, so that we don't try to kill a leftover one
5078 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5081 * buildbot/slave/commands.py (SourceBase): set self.command for
5082 all VC commands, so they can be interrupted.
5084 2004-12-03 Brian Warner <warner@lothar.com>
5086 * buildbot/master.py: clean up slave-handling code, to handle
5087 slave-disconnect and multiple-connect better
5088 (BotPerspective): make these long-lasting, exactly one per bot
5089 listed in the config file.
5090 (BotPerspective.attached): if a slave connects while an existing
5091 one appears to still be connected, disconnect the old one first.
5092 (BotPerspective.disconnect): new method to forcibly disconnect a
5093 buildslave. Use some hacks to empty the transmit buffer quickly to
5094 avoid the long (20-min?) TCP timeout that could occur if the old
5095 slave has dropped off the net.
5096 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5097 own their own SlaveStatus objects. Remove .attached/.detached, add
5098 .addSlave/.removeSlave, treat slaves like Builders (config file
5099 parsing sends deltas to the BotMaster). Inform the slave
5100 instances, i.e. the BotPerspective, about addBuilder and
5102 (BotMaster.getPerspective): turns into a single dict lookup
5103 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5104 which gives BotPerspective.attached a chance to disconnect the old
5106 (BuildMaster.loadConfig): add code (disabled) to validate that all
5107 builders use known slaves (listed in c['bots']). The check won't
5108 work with tuple-specified builders, which are deprecated but not
5109 yet invalid, so the check is disabled for now.
5110 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5111 routine, do the add/changed/removed dance with them like we do
5113 (BuildMaster.loadConfig_Sources): move source-config into a
5114 separate routine too
5116 * buildbot/status/builder.py (Status.getSlave): get the
5117 SlaveStatus object from the BotPerspective, not the BotMaster.
5119 * buildbot/test/test_run.py: bunch of new tests for losing the
5120 buildslave at various points in the build, handling a slave that
5121 connects multiple times, and making sure we can interrupt a
5124 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5125 something other than 'Bot' for the Bot object, to make certain
5126 test cases easier to write.
5127 (BuildSlave.waitUntilDisconnected): utility method for testing
5129 2004-11-30 Brian Warner <warner@lothar.com>
5131 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5133 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5134 argument, return a Deferred that always fires with True or False.
5135 I don't use an errback to indicate 'ping failed' so that callers
5136 are free to ignore the deferred without causing spurious errors in
5138 * buildbot/process/builder.py (BuilderControl.ping): implement it
5140 * buildbot/test/test_run.py (Status.testDisappear): test ping
5141 (Status.disappearSlave): fix it
5143 2004-11-30 Brian Warner <warner@lothar.com>
5145 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5146 (IBuilderControl): add .getBuild(num), only works for the current
5147 build, of course, although it might be interesting to offer
5148 something for builds in the .waiting or .interlocked state.
5150 * buildbot/process/base.py (Build): have .stopBuild just do the
5151 interrupt, then let the build die by itself.
5152 (BuildControl): add .stopBuild, and add a point-event named
5153 'interrupt' just after the build so status viewers can tell that
5155 (BuilderControl): add .getBuild
5157 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5158 stops when you kill it, good for testing
5159 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5160 contains the 'reason' text.
5162 * buildbot/status/html.py: Add Stop Build button, if the build can
5163 still be stopped. Send a Redirect (to the top page) one second
5164 later, hopefully long enough for the interrupt to have an effect.
5165 Move make_row() up to top-level to share it between Stop Build and
5168 * buildbot/slave/commands.py: only kill the child process once
5170 * buildbot/test/test_run.py: add testInterrupt
5172 2004-11-29 Brian Warner <warner@lothar.com>
5174 * buildbot/process/base.py: Refactor command interruption. The
5175 Build is now responsible for noticing that the slave has gone
5176 away: Build.lostRemote() interrupts the current step and makes
5177 sure that no further ones will be started.
5179 * buildbot/process/builder.py: When the initial remote_startBuild
5180 message fails, log it: this usually indicates that the slave has
5181 gone away, but we don't really start paying attention until they
5182 fail to respond to the first step's command.
5184 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5185 slave disconnect. Now sports a new interrupt() method. Error
5186 handling was simplified a lot by chaining deferreds, so
5187 remoteFailed/remoteComplete were merged into a single
5188 remoteComplete method (which can now get a Failure object).
5189 Likewise failed/finished were merged into just _finished.
5190 (BuildStep): Add interrupt(why) method, and if why is a
5191 ConnectionLost Failure then the step is failed with some useful
5194 * buildbot/slave/bot.py: stop the current command when the remote
5195 Step reference is lost, and when the slave is shut down.
5196 (Bot): make it a MultiService, so it can have children. Use
5197 stopService to tell when the slave is shutting down.
5198 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5199 remote_interruptCommand (which asks the current SlaveCommand to
5200 stop but allows it to keep emitting status messages), and
5201 stopCommand (which tells it to shut up and die).
5203 * buildbot/slave/commands.py: make commands interruptible
5204 (ShellCommand.kill): factor out os.kill logic
5205 (Command): factor out setup()
5206 (Command.sendStatus): don't send status if .running is false, this
5207 happens when the command has been halted.
5208 (Command.interrupt): new method, used to tell the command to die
5209 (SlaveShellCommand): implement .interrupt
5210 (DummyCommand): implement .interrupt
5211 (SourceBase, etc): factor out setup(), don't continue substeps if
5214 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5215 so they can be called after finishing
5217 * buildbot/test/test_run.py: new tests for disconnect behavior,
5218 refactor slave-shutdown routines, add different kinds of
5221 2004-11-27 Brian Warner <warner@lothar.com>
5223 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5224 method to express ETA time like "2m45s" instead of "165 seconds"
5226 2004-11-24 Brian Warner <warner@lothar.com>
5228 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5229 archive after the test completes, to avoid cluttering the user's
5230 'tla archives' listing with a bogus entry. Arch doesn't happen to
5231 provide any way to override the use of ~/.arch-params/, so there
5232 isn't a convenient way to avoid touching the setup of the user who
5234 (VC_HTTP.testArchHTTP): same
5236 2004-11-23 Brian Warner <warner@lothar.com>
5238 * buildbot/status/html.py (TextLog): split render() up into
5239 render_HEAD and render_GET. Use a Producer when sending log
5240 chunks, to reduce memory requirements and avoid sending huge
5241 non-Banana-able strings over web.distrib connections. Requires
5242 peeking under the covers of IStatusLog.
5243 (TextLog.resumeProducing): fix the "as text" link, handle client
5244 disconnects that occur while we're still sending old chunks.
5246 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5247 use defer.succeed, not the non-existent defer.success
5248 (LogFile.waitUntilFinished): same
5249 (LogFile.subscribe): don't add watchers to a finished logfile
5251 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5254 2004-11-23 Brian Warner <warner@lothar.com>
5256 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5258 2004-11-23 Brian Warner <warner@lothar.com>
5260 * NEWS: update for the 0.6.1 release
5261 * MANIFEST.in: add new files
5263 * README (INSTALLATION): explain how to enable the extra VC tests
5265 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5266 level to, so old pickled builds can be displayed ok
5268 2004-11-22 Brian Warner <warner@lothar.com>
5270 * NEWS: summarize updates since last release
5272 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5273 Yoz Grahame. Closes SF#1050138.
5275 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5278 * buildbot/process/step_twisted.py (Trial): update docs a bit
5280 * docs/factories.xhtml: fix Trial factory docs to match reality.
5283 * buildbot/process/factory.py (Trial.__init__): add args for
5284 randomly= and recurse=, making them available to instantiators
5285 instead of only to subclassers. Closes: SF#1049759.
5287 2004-11-15 Brian Warner <warner@lothar.com>
5289 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5290 try to teach the Quick factory to use multiple versions of python
5292 2004-11-12 Brian Warner <warner@lothar.com>
5294 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5295 safer w32-compatible approach, and only use it on windows
5296 (BuildStatus.saveYourself): same
5298 2004-11-11 Brian Warner <warner@lothar.com>
5300 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5301 it: one string merge per chunk. There are now separate .entries
5302 and .runEntries lists: when enumerating over all chunks, make sure
5304 * buildbot/test/test_status.py (Log): more tests
5306 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5307 chunks together, up to 10kb per chunk. This ought to cut down on
5308 the CPU-burning overhead of large log files. Thanks to Alexander
5309 Staubo for spotting the problem.
5310 * buildbot/test/test_status.py (Log): tests for same
5312 2004-11-10 Brian Warner <warner@lothar.com>
5314 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5315 header to outbound mail
5316 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5318 2004-11-08 Brian Warner <warner@lothar.com>
5320 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5321 can't do os.rename() onto an existing file, so catch the exception
5322 and unlink the target file first. This introduces a slight window
5323 where the existing file could be lost, but the main failure case
5324 (disk full) should still be handled safely.
5325 (BuildStatus.saveYourself): same
5327 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5328 separator character instead of os.sep, because the filenames being
5329 split here are coming from the VC system, which can have a
5330 different pathname convention than the local host. This should
5331 help a buildmaster running on windows that uses a CVS repository
5332 which runs under unix.
5333 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5335 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5336 when there are no test failures to be parsed
5338 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5339 instead of the unix-specific os.system("cp"), thanks to Elliot
5340 Murphy for this and the other buildbot-vs-windows catches.
5341 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5343 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5344 echo the command as it is run
5346 * setup.py: install sample.mk too, not just sample.cfg
5347 (scripts): install contrib/windows/buildbot.bat on windows
5349 2004-11-07 Brian Warner <warner@lothar.com>
5351 * buildbot/process/builder.py (Builder._detached): clear the
5352 self.currentBuild reference, otherwise the next build will be
5353 skipped because we think the Builder is already in use.
5355 * docs/examples/twisted_master.cfg: update to match current usage
5356 on the Twisted buildbot
5358 2004-10-29 Brian Warner <warner@lothar.com>
5360 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5362 2004-10-28 Brian Warner <warner@lothar.com>
5364 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5365 have separate doVCUpdate/doVCFull methods. Catch an update failure
5366 and respond by clobbering the source directory and re-trying. This
5367 will handle local changes (like replacing a file with a directory)
5368 that will cause CVS and SVN updates to fail.
5369 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5371 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5374 2004-10-19 Brian Warner <warner@lothar.com>
5376 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5378 * buildbot/status/html.py (StatusResourceTestResults): display any
5379 TestResults that the Build might have
5380 (StatusResourceTestResult): and the logs for each TestResult
5381 (StatusResourceBuild): add link from the per-build page
5383 2004-10-15 Brian Warner <warner@lothar.com>
5385 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5386 the 'problems' portion of stdout, add TestResults to our build
5387 * buildbot/test/test_twisted.py (Parse.testParse): test it
5389 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5390 to retrieve a dict of accumulated test results
5391 (ITestResult): define what a single test result can do
5392 * buildbot/status/builder.py (TestResult): implement ITestResult
5393 (BuildStatus.getTestResults): retrieve dict of TestResults
5394 (BuildStatus.addTestResult): add TestResults
5395 * buildbot/test/test_status.py (Results.testAddResults): test it
5397 2004-10-14 Brian Warner <warner@lothar.com>
5399 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5400 instead of os.system("rm -rf") for win32 portability
5402 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5403 SignalMixin instead of starting/stopping the reactor, which is
5404 likely to cause problems with other tests
5406 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5407 self.copyComplete() call. Yoz Grahame makes the catch.
5409 * contrib/windows/buildbot.bat: helper script to deal with path
5410 issues. Thanks to Yoz Grahame.
5412 * buildbot/master.py (BuildMaster.startService): don't register a
5413 SIGHUP handler if the signal module has no SIGHUP attribute.
5414 Apparently win32 does this.
5416 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5418 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5419 test if the reactor can't offer UNIX sockets
5421 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5422 error introduced in the last commit. We really need that
5425 2004-10-12 Brian Warner <warner@lothar.com>
5427 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5428 when describing a maildir source. Thanks to Stephen Davis.
5430 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5433 * buildbot/scripts/runner.py (createMaster): install Makefile too
5434 (start): add --no_save to 'start' command
5435 * buildbot/scripts/sample.mk: simple convenience Makefile with
5436 start/stop/reload targets
5438 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5441 2004-09-30 Brian Warner <warner@lothar.com>
5443 * setup.py: Releasing buildbot-0.6.0
5445 2004-09-30 Brian Warner <warner@lothar.com>
5447 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5448 test_trial.py from the source tarball until support is complete.
5450 * NEWS: update for 0.6.0 release
5451 * buildbot/__init__.py (version): same
5454 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5455 'source' command to tell users where to get the Buildbot source
5457 * docs/examples/*.cfg: update to modern standards
5459 * NEWS: update for release
5461 * buildbot/scripts/runner.py (createMaster): remove the
5462 -shutdown.tap stuff now that it isn't necessary
5464 (start): launch buildbot.tap, not buildbot-shutdown.tap
5467 * buildbot/status/mail.py (Domain): shorten class name
5468 (MailNotifier): if lookup= is a string, pass it to Domain()
5469 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5470 (Mail.testBuild2): test the string-to-Domain shortcut
5471 (Mail.testMail): fix test
5474 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5477 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5478 more attributes on load
5479 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5480 to accomodate the whole waterfall page at once, and the thrashing
5481 results in a lot of unnecessary loads
5482 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5483 (BuilderStatus.saveYourself): same
5484 (BuilderStatus.eventGenerator): stop generating on the first missing
5485 build. We assume that saved builds are deleted oldest-first.
5486 (BuildStepStatus.__getstate__): .progress might not exist
5488 * buildbot/changes/changes.py (ChangeMaster): make it
5489 serializable, in $masterdir/changes.pck
5490 (ChangeMaster.stopService): save on shutdown
5491 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5492 * buildbot/test/test_config.py: load Changes before config file
5495 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5496 "Oh my god, you killed the command" header on a separate line
5498 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5499 skip over corrupted build pickles
5500 (BuilderStatus.getFullBuildByNumber): same
5501 (BuilderStatus.eventGenerator): skip over unavailable builds
5502 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5503 do an atomic rename. This prevents a corrupted pickle when some
5504 internal serialization error occurs.
5505 (BuilderStatus.saveYourself): same
5507 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5508 the timeout for shell commands, it got lost somehow
5510 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5511 run out of build steps, return the rest of the builder events
5513 * buildbot/interfaces.py (IBuilderControl.ping): add method
5515 * buildbot/process/builder.py (BuilderControl.ping): move
5516 slave-ping to BuilderControl, and fix the failure case in the
5517 process (Event.finish() is the verb, Event.finished is the noun).
5519 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5520 through the BuilderControl instead of the BuilderStatus
5521 (EventBox): add adapter for builder.Event, allowing builder events to
5522 be displayed in the waterfall display
5524 * buildbot/master.py (BotMaster.stopService): add a 'master
5525 shutdown' event to the builder's log
5526 (BuildMaster.startService): and a 'master started' on startup
5528 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5529 builder events into the BuildStep event stream
5530 (Status.builderAdded): add a 'builder created' event
5533 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5534 command to announce the completion of a running build
5535 (IrcStatusBot.command_FORCE): announce when the build finishes
5537 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5538 don't evict unfinished builds from the cache: they must stay in
5539 the full-cache until their logfiles have stopped changing. Make
5540 sure the eviction loop terminates if an unfinished build was hit.
5541 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5542 This lets exceptions be dumped in an email status message. Really
5543 we need LogFiles which contain both text and HTML, instead of two
5545 (BuildStatus.__getstate__): handle self.finished=False
5546 (Status.builderAdded): if the pickle is corrupted, abandon the
5547 history and create a new BuilderStatus object.
5549 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5550 self.progress attribute, helped one test which doesn't fully set
5551 up the Build object.
5553 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5554 IStatusLog methods into an Interface that is implemented by "stub"
5555 logs, for which all the actual text chunks are on disk (in the
5556 pickled Build instance). To show the log contents, you must first
5557 adapt the stub log to a full IStatusLog object.
5559 * buildbot/status/builder.py (LogFileStub): create separate stub
5560 log objects, which can be upgraded to a real one if necessary.
5561 (LogFile): make them persistable, and let them stubify themselves
5563 (BuildStepStatus): same
5565 (BuildStatus.saveYourself): save the whole build out to disk
5566 (BuilderStatus): make it persistable
5567 (BuilderStatus.saveYourself): save the builder to disk
5568 (BuilderStatus.addFullBuildToCache): implement two caches which
5569 hold Build objects: a small one which holds full Builds, and a
5570 larger one which holds "stubbed" Builds (ones with their LogFiles
5571 turned into LogFileStubs). This reduces memory usage by the
5572 buildmaster by not keeping more than a few (default is 2) whole
5573 build logs in RAM all the time.
5574 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5576 (BuilderStatus.eventGenerator): rewrite since .builds went away
5577 (BuilderStatus.buildStarted): remove the .builds array. Add the
5578 build to the "full" cache when it starts.
5579 (BuilderStatus._buildFinished): save the build to disk when it
5581 (Status): give it a basedir (same as the BuildMaster's basedir)
5582 where the builder pickles can be saved
5583 (Status.builderAdded): create the BuilderStatus ourselves, by
5584 loading a pickle from disk (or creating a new instance if there
5585 was none on disk). Return the BuilderStatus so the master can glue
5586 it into the new Builder object.
5588 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5589 all BuilderStatuses to save themselves out to disk. This is in
5590 lieu of saving anything important in the main Application pickle
5591 (the -shutdown.tap file).
5592 (BuildMaster.__init__): give Status() a basedir for its files
5593 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5594 to get the BuilderStatus, then give it to the Builder (instead of
5595 doing it the other way around). It's ok if the status announces
5596 the new Builder before it's really ready, as the outside world can
5597 only see the BuilderStatus object anyway (and it is ready before
5598 builderAdded returns). Use the builder's "builddir" (which
5599 normally specifies where the slave will run the builder) as the
5600 master's basedir (for saving serialized builds).
5602 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5603 coerce the logfile to IStatusLog before trying to get the text
5604 chunks out of it. This will pull the full (non-stubified) Build in
5605 from disk if necessary.
5606 (TextLog): fix the adapter registration
5608 * buildbot/test/test_control.py (Force.setUp): create the basedir
5609 * buildbot/test/test_web.py: same
5610 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5611 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5612 * buildbot/test/test_run.py (Run.testMaster): same
5613 (Status.setUp): same
5615 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5617 * buildbot/status/html.py (Waterfall.__init__): store actual
5618 allowForce flag passed in rather than using True for everyone;
5619 make sure setting it to False doesn't cause a NameError
5621 (StatusResourceBuilder.__init__) add the builder name to the page
5623 (StatusResourceBuilder.body) move HTML generation for a name/value
5624 row into a helper method (StatusResourceBuilder.make_row); only
5625 generate the "Force Build" form if allowForce was True and the
5626 slave is connected. Use class attributes in the generated HTML to
5627 spread a little CSS-joy.
5629 2004-09-28 Brian Warner <warner@lothar.com>
5631 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5632 warning-scanner to not ignore things like
5633 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5635 * buildbot/status/html.py (StatusResource.control): add some
5636 class-level values for .control in an attempt to make upgrading
5639 * buildbot/util.py (ComparableMixin): survive missing attributes,
5640 such as when a class is modified and we're comparing old instances
5643 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5644 failure handling, remove a redundant try/except block. Don't
5645 return the full traceback to the IRC channel.
5646 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5647 error messages. Get ETA properly.
5649 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5650 the reason, since (at least) IRC message will have <> in them.
5651 (StatusResourceBuilder.__init__): take an IBuilderControl
5652 (StatusResourceBuilder.force): use the IBuilderControl we get in
5653 the constructor instead of trying to make our own. Catch the
5654 new exceptions and ignore them for now (until we make an
5655 intermediate web page where we could show the error message)
5656 (StatusResource): create with an IControl, use it to give an
5657 IBuilderControl to all children
5658 (Waterfall): take an allowForce= option, pass an IControl object
5659 to StatusResource if it is True
5661 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5663 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5664 catch new exceptions and return string forms
5666 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5667 * buildbot/process/builder.py (Builder.forceBuild): raise them
5668 * buildbot/test/test_control.py (Force.testNoSlave): new test
5669 (Force.testBuilderInUse): same
5672 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5674 * buildbot/test/test_run.py: use IControl
5675 * buildbot/test/test_vc.py: same
5677 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5678 to use IControl. Still offline.
5679 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5681 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5682 who=None so periodic builds don't send out status mail
5683 (Builder.forceBuild): include reason in the log message
5684 (BuilderControl.forceBuild): rename 'name' to 'who'
5686 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5687 'who' parameter, but make it None by default so builds forced by
5688 slave admins don't cause status mail to be sent to anybody
5689 (BotMaster.forceBuild): same. this method is deprecated.
5690 (DebugPerspective.perspective_forceBuild): same, use IControl.
5691 (DebugPerspective.perspective_fakeChange): use IControl..
5692 (Dispatcher.requestAvatar): .. so don't set .changemaster
5694 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5695 parameter to avoid confusion with the name of the builder
5698 * buildbot/status/mail.py: refine comment about needing 2.3
5700 * buildbot/status/html.py: move all imports to the top
5702 * buildbot/test/test_control.py: test new interfaces
5703 * buildbot/test/test_run.py (Status): handle new interfaces
5704 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5706 * buildbot/process/base.py (BuildControl): implement IBuildControl
5707 and its lonely getStatus() method
5709 * buildbot/process/builder.py (BuilderControl): implement
5710 IBuilderControl, obtained by adapting the Builder instance
5711 (Builder.startBuild): return a BuilderControl instead of a
5712 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5713 accomplish the same thing.
5715 * buildbot/master.py: move all import statements to the top
5716 (Control): implement IControl, obtained by adapting the
5717 BuildMaster instance.
5719 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5720 IBuildControl. These are used to force builds. Eventually they
5721 will provide ways to reconfigure the Builders, pause or abandon a
5722 Build, and perhaps control the BuildMaster itself.
5724 2004-09-26 Brian Warner <warner@lothar.com>
5726 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5727 ends up comparing us against something without a .__class__
5729 2004-09-24 Brian Warner <warner@lothar.com>
5731 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5734 * Makefile: add 'deb-snapshot' target, to create a timestamped
5737 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5739 2004-09-23 Brian Warner <warner@lothar.com>
5741 * buildbot/__init__.py (version): move version string here
5742 * setup.py: get version string from buildbot.version
5743 * buildbot/status/html.py (WaterfallStatusResource.body): add
5744 buildbot version to the page footer
5745 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5748 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5749 slaves, let the second know where the first one is coming from
5750 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5751 see our exceptions. It would be nice if there were a way to just
5752 send them the exception type and value, not the full traceback.
5755 * buildbot/status/mail.py (MailNotifier): add a new argument
5756 sendToInterestedUsers=, which can be set to False to disable the
5757 usual send-to-blamelist behavior.
5758 (top): handle python-2.2 which has no email.MIMEMultipart
5759 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5760 (MailNotifier.disownServiceParent): unsubscribe on removal
5762 * buildbot/test/test_status.py (Mail.testBuild2): test it
5765 * buildbot/status/progress.py (Expectations.wavg): tolerate
5766 current=None, which happens when steps start failing badly
5767 * buildbot/test/test_status.py (Progress.testWavg): test for it
5769 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5770 doesn't understand args['revision'], emit a warning instead of
5771 bailing completely. Updating to -rHEAD is probably close enough.
5773 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5775 * buildbot/test/test_status.py: at least import bb.status.client
5776 even if we don't have any test coverage for it yet
5778 * contrib/svn_buildbot.py: don't require python2.3
5779 (main): wait, do require it (for sets.py), but explain how to
5780 make it work under python2.2
5782 2004-09-23 Brian Warner <warner@lothar.com>
5784 * contrib/svn_buildbot.py: include the revision number in the Change
5786 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5787 using util.now() because FreshCVS is a realtime service
5789 * buildbot/status/event.py: delete dead code
5790 * buildbot/process/step.py: don't import dead Event class
5791 * buildbot/process/step_twisted.py: same
5792 * buildbot/status/builder.py: same
5793 * buildbot/status/client.py: same
5795 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5797 * buildbot/changes/changes.py (Change): set .when from an __init__
5798 argument (which defaults to now()), rather than having
5799 ChangeMaster.addChange set it later.
5800 (ChangeMaster.addChange): same
5802 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5803 (parseSyncmail): same. Just use util.now() for now.
5804 (parseBonsaiMail): parse the timestamp field for when=
5806 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5807 instead of setting .when after the fact
5811 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5812 results when the target project uses retrial. Still under
5814 * buildbot/test/test_trial.py: same
5816 2004-09-21 Brian Warner <warner@lothar.com>
5818 * buildbot/status/mail.py (MailNotifier.__init__): include
5819 success/warnings/failure in the Subject line
5820 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5821 use step.logname for the addLogs=True attachment filenames
5822 * buildbot/test/test_status.py (Mail): test Subject lines
5823 (Mail.testLogs): test attachment filenames
5825 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5826 accept a 'who' argument from the debug tool
5827 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5828 * contrib/debug.glade: add text box to set 'who'
5830 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5831 .getBuilderName with .getBuilder().getName(), more flexible
5832 (IStatusLog.getName): logs have short names, but you can prefix
5833 them with log.getStep().getName() to make them more useful
5834 * buildbot/status/builder.py: same
5835 * buildbot/status/client.py: same
5836 * buildbot/status/html.py: same
5837 * buildbot/test/test_run.py (Status.testSlave): same
5838 * buildbot/process/step.py: tweak logfile names
5840 * buildbot/status/mail.py (MailNotifier): add lookup, change
5841 argument to extraRecipients. The notifier is now aimed at sending
5842 mail to the people involved in a particular build, with additional
5843 constant recipients as a secondary function.
5845 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5846 including slow-lookup and failing-lookup. Make sure the blamelist
5847 members are included.
5849 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5850 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5851 (IBuildStatus.getInterestedUsers): new method
5852 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5853 * buildbot/status/client.py (remote_getResponsibleUsers): same
5854 * buildbot/status/html.py (StatusResourceBuild.body): same
5855 * buildbot/test/test_run.py (Status.testSlave): same
5857 2004-09-20 Brian Warner <warner@lothar.com>
5859 * docs/users.xhtml: update concepts
5861 * Makefile: add a convenience makefile, for things like 'make
5862 test'. It is not included in the source tarball.
5864 2004-09-16 Brian Warner <warner@lothar.com>
5866 * NEWS: mention /usr/bin/buildbot, debian/*
5868 * debian/*: add preliminary debian packaging. Many thanks to
5869 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5870 it considerably since it left their hands, I am responsible for
5871 all breakage that's resulted.
5873 * bin/buildbot: create a top-level 'buildbot' command, to be
5874 installed in /usr/bin/buildbot . For now it's just a simple
5875 frontend to mktap/twistd/kill, but eventually it will be the entry
5876 point to the 'try' command and also a status client. It is also
5877 intended to support the upcoming debian-packaging init.d scripts.
5878 * buildbot/scripts/runner.py: the real work is done here
5879 * buildbot/scripts/__init__.py: need this too
5880 * buildbot/scripts/sample.cfg: this is installed in new
5881 buildmaster directories
5882 * setup.py: install new stuff
5884 2004-09-15 Brian Warner <warner@lothar.com>
5886 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5887 'file:' schema (the version shipped with OS-X was built without the
5889 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5890 updates the log-timestamp, to make sure it isn't still running after
5893 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5894 values to the config file.
5895 * docs/examples/hello.cfg: add examples
5896 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5897 * buildbot/status/builder.py (Status.getProjectURL): implement them
5898 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5899 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5900 * buildbot/status/html.py (WaterfallStatusResource): display them
5903 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5904 certain error cases don't suffer a secondary exception.
5905 (top): Skip tests if the corresponding VC tool is not installed.
5907 * buildbot/process/factory.py (Trial): introduce separate
5908 'buildpython' and 'trialpython' lists, since trialpython=[] is
5909 what you want to invoke /usr/bin/python, whereas ./setup.py is
5910 less likely to be executable. Add env= parameter to pass options
5911 to test cases (which is how I usually write tests, I don't know if
5912 anyone else does it this way).
5914 * buildbot/process/step_twisted.py (Trial): handle python=None.
5915 Require 'testpath' be a string, not a list. Fix tests= typo.
5916 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5918 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5919 way to deal with the possibility of removing the disconnect notify
5921 (CVS): add a 'login' parameter to give a password to 'cvs login',
5922 commonly used with pserver methods (where pw="" or pw="guest")
5924 * buildbot/slave/commands.py (SourceBase): move common args
5925 extraction and setup() to __init__, so everything is ready by the
5926 time setup() is called
5927 (CVS.start): call 'cvs login' if a password was supplied
5928 (ShellCommand): special-case PYTHONPATH: prepend the master's
5929 value to any existing slave-local value.
5931 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5932 don't have a remote, mark the builder as Offline. This whole
5933 function should probably go away and be replaced by individual
5935 (Builder.buildFinished): return the results to the build-finished
5936 deferred callback, helps with testing
5938 2004-09-14 Brian Warner <warner@lothar.com>
5940 * buildbot/test/test_vc.py: put all the repositories needed to run
5941 the complete tests into a single small (1.3MB) tarball, so I can
5942 make that tarball available on the buildbot web site. Test HTTP
5943 access (for Arch and Darcs) by spawning a temporary web server
5944 while the test runs.
5946 * docs/users.xhtml: new document, describe Buildbot's limited
5947 understanding of different human users
5949 * buildbot/test/test_vc.py: rearrange test cases a bit
5951 * buildbot/process/step_twisted.py (Trial): handle testpath=
5952 * buildbot/process/factory.py (Trial): update to use step.Trial
5954 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5956 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5957 the overall build text (which gives you 'failed 2 tests' rather
5959 (BuildStepStatus.text2): default to [], not None
5961 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5964 2004-09-12 Brian Warner <warner@lothar.com>
5966 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5967 log the whole exception if it's just an AttributeError (old slave)
5969 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5970 so (e.g.) sub-commands can be run in the right directory.
5971 (ShellCommand.start): accept an optional errorMessage= argument
5972 to make life easier for SVN.start
5973 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5975 (ShellCommand.start): move ['dir'] compatibility hack..
5976 (RemoteShellCommand.start): .. to here so everyone can use it
5978 * buildbot/process/step_twisted.py (Trial): use .workdir
5980 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5981 text displayed when debuild fails completely
5982 (Trial): snarf _trial_temp/test.log from the slave and display it
5984 2004-09-11 Brian Warner <warner@lothar.com>
5986 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5988 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5989 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5991 * buildbot/process/step.py (ShellCommand): call .createSummary
5992 before .evaluateCommand instead of the other way around. This
5993 makes it slightly easier to count warnings and then use that to
5994 set results=WARNINGS
5995 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5997 * buildbot/process/base.py (Build.buildFinished): update status
5998 before doing progress. It's embarrassing for the build to be stuck
5999 in the "building" state when an exceptions occurs elsewhere..
6001 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6002 python2.2 doesn't have 'sum'
6004 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6005 to prevent clients from accidentally sorting it
6007 * buildbot/master.py (Manhole): add username/password
6008 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6009 c['manholePort'], deprecate old usage
6010 * docs/config.xhtml: document c['manhole']
6011 * docs/examples/hello.cfg: show example of using a Manhole
6014 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6015 pretend the slave is up to date
6017 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6018 the module, overlaps with 'log', the local variable
6020 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6022 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6023 new method to let Steps find out the version of their
6024 corresponding SlaveCommand.
6025 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6026 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6027 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6029 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6030 (Arch.startVC): same
6031 (P4Sync.startVC): same
6033 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6034 Deferred so we can catch errors in remote_startCommand
6035 (RemoteShellCommand.start): same
6037 * docs/examples/twisted_master.cfg: update sample config file
6039 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6040 after connectionMade() is called, not before. Close stdin at that
6043 * buildbot/process/process_twisted.py: update to use Trial, clean
6044 up argument passing (move to argv arrays instead of string
6047 * buildbot/process/step_twisted.py (Trial): new step to replace
6048 RunUnitTests, usable by any trial-using project (not just
6049 Twisted). Arguments have changed, see the docstring for details.
6051 * buildbot/process/base.py (Build.startBuild): this now returns a
6052 Deferred. Exceptions that occur during setupBuild are now
6053 caught better and lead to fewer build_status weirdnesses, like
6054 finishing a build that was never started.
6055 (Build.buildFinished): fire the Deferred instead of calling
6056 builder.buildFinished directly. The callback argument is this
6057 Build, everything else can be extracted from it, including the
6058 new build.results attribute.
6059 * buildbot/process/builder.py (Builder.startBuild): same
6060 (Builder.buildFinished): same, extract results from build
6062 * buildbot/process/step.py (ShellCommands): remove dead code
6064 2004-09-08 Brian Warner <warner@lothar.com>
6066 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6067 doesn't try to use the leftover patched workdir
6068 (SourceStamp): test source-stamp computation for CVS and SVN
6070 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6071 patched workdir ('touch .buildbot-patched') so we don't try to
6073 (SourceBase.start): add ['revision'] for all Source steps
6074 (CVS): change args: use ['branch'] for -r, remove ['files']
6075 (CVS.buildVC): fix revision/branch stuff
6076 (SVN): add revision stuff
6078 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6079 kwargs (except 'workdir') to avoid silent spelling errors
6080 (ShellCommand.__init__): same
6081 (Source): new base class for CVS/SVN/etc. Factor out everything
6082 common, add revision computation (perform the checkout with a -D
6083 DATE or -r REVISION that gets exactly the sources described by the
6084 last Change), overridable with step.alwaysUseLatest. Add patch
6085 handling (build.getSourceStamp can trigger the use of a base
6086 revision and a patch).
6087 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6088 * docs/steps.xhtml: update docs
6089 * docs/source.xhtml: mention .checkoutDelay
6090 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6092 * buildbot/process/base.py (Build.setSourceStamp): add a
6093 .sourceStamp attribute to each Build. If set, this indicates that
6094 the build should be done with something other than the most
6095 recent source tree. This will be used to implement "try" builds.
6096 (Build.allChanges): new support method
6097 (Build.lastChangeTime): remove, functionality moved to Source steps
6098 (Build.setupBuild): copy the Step args before adding ['workdir'],
6099 to avoid modifying the BuildFactory (and thus triggering spurious
6103 * buildbot/status/html.py: rename s/commits/changes/
6104 (StatusResourceChanges): same
6105 (CommitBox.getBox): same, update URL
6106 (WaterfallStatusResource): same
6107 (StatusResource.getChild): same
6109 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6110 * contrib/debug.glade: add optional 'revision' to the fakeChange
6112 * buildbot/changes/changes.py (html_tmpl): display .revision
6113 (ChangeMaster.addChange): note .revision in log
6114 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6115 accept a ['revision'] attribute
6117 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6119 * buildbot/master.py (BotMaster.getPerspective): update the
6120 .connected flag in SlaveStatus when it connects
6121 (BotMaster.detach): and when it disconnects
6122 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6123 (BuildMaster.loadConfig_Builders): walk old list correctly
6125 * buildbot/test/test_config.py: fix prefix= usage
6127 2004-09-06 Brian Warner <warner@lothar.com>
6131 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6132 poll a P4 depot looking for recent changes. Thanks to Dave
6133 Peticolas for the contribution. Probably needs some testing after
6136 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6137 requires manual client setup for each buildslave. Rather
6138 experimental. Thanks again to Dave Peticolas.
6139 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6141 * buildbot/changes/changes.py (Change): add a .revision attribute,
6142 which will eventually be used to generate source-stamp values.
6144 * buildbot/process/step.py (RemoteCommand.start): use
6145 notifyOnDisconnect to notice when we lose the slave, then treat it
6146 like an exception. This allows LogFiles to be closed and the build
6147 to be wrapped up normally. Be sure to remove the disconnect
6148 notification when the step completes so we don't accumulate a
6149 bazillion such notifications which will fire weeks later (when the
6150 slave finally disconnects normally). Fixes SF#915807, thanks to
6151 spiv (Andrew Bennetts) for the report.
6152 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6153 really isn't Logged- specific
6154 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6155 header, since it's almost always going to be appended to an
6157 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6158 update test to handle use of notifyOnDisconnect
6160 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6161 don't clear .ETA and .currentBuild when going offline, let the
6162 current build clean up after itself
6164 * buildbot/process/builder.py (Builder.detached): wait a moment
6165 before doing things like stopping the current build, because the
6166 current step will probably notice the disconnect and cleanup the
6168 * buildbot/test/test_run.py (Status.tearDown): update test to
6169 handle asynchronous build-detachment
6171 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6173 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6174 hush a debug message
6176 2004-09-05 Brian Warner <warner@lothar.com>
6178 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6179 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6180 kernels do this: the fcntl module has the F_NOTIFY constant, but
6181 the kernel itself doesn't support the operation. Thanks to Olly
6182 Betts for spotting the problem.
6184 * buildbot/process/step.py (Darcs): new source-checkout command
6185 (Arch): new source-checkout command
6186 (todo_P4): fix constructor syntax, still just a placeholder
6187 * buildbot/test/test_vc.py (VC.testDarcs): test it
6188 (VC.testDarcsHTTP): same, via localhost HTTP
6190 (VC.testArchHTTP): same
6191 * NEWS: mention new features
6193 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6194 which tells the step to stash stdout text locally (in .stdout).
6195 Slave-side Commands can use this to make decisions based upon the
6196 output of the the ShellCommand (not just the exit code).
6197 (Darcs): New source-checkout command
6198 (Arch): New source-checkout command, uses .keepStdout in one place
6199 where it needs to discover the archive's default name.
6201 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6202 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6203 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6205 * buildbot/process/step.py (ShellCommand.describe): add an
6206 alternate .descriptionDone attribute which provides descriptive
6207 text when the step is complete. .description can be ["compiling"],
6208 for use while the step is running, then .descriptionDone can be
6209 ["compile"], used alone when the step succeeds or with "failed" when
6210 it does not. Updated other steps to use the new text.
6211 * buildbot/process/step_twisted.py: same
6212 * buildbot/test/test_run.py: update tests to match
6214 2004-08-30 Brian Warner <warner@lothar.com>
6216 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6217 (CVS.__init__): send 'patch' argument to slave
6218 (CVS.start): don't create the LoggedRemoteCommand until start(),
6219 so we can catch a .patch added after __init__
6220 (SVN.__init__): add 'patch' to SVN too
6223 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6224 argument, to let commands push data into the process' stdin pipe.
6225 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6226 is in use, since closing a PTY doesn't really affect the process
6227 in the right way (in particular, I couldn't run /usr/bin/patch
6229 (SourceBase.doPatch): handle 'patch' argument
6231 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6234 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6235 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6237 * buildbot/master.py (BotPerspective.got_commands): get command
6238 versions from slave, give to each builder
6239 * buildbot/process/builder.py (Builder.attached): stash slave
6240 command versions in .remoteCommands
6242 * docs/steps.xhtml: bring docs in-line with reality
6244 * buildbot/process/step.py (CVS.__init__): more brutal
6245 compatibility code removal
6246 (SVN.__init__): same
6248 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6249 (SlaveShellCommand.start): require ['workdir'] argument, remove
6250 the ['dir'] fallback (compatibility will come later)
6251 (SourceBase): update docs
6252 (SourceBase.start): remove ['directory'] fallback
6255 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6256 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6257 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6259 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6260 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6261 code.. I will figure out 0.5.0-compatibility hooks later)
6263 2004-08-30 Brian Warner <warner@lothar.com>
6265 * buildbot/process/process_twisted.py: rewrite in terms of new
6266 BuildFactory base class. It got significantly shorter. Yay
6269 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6270 work with the new "self.build isn't nailed down until we call
6271 step.start()" scheme: specifically, __init__ is called before the
6272 build has decided on which Changes are going in, so we don't scan
6273 build.allFiles() for .xhtml files until start()
6274 (HLint.commandComplete): use getText(), not getStdout()
6275 (RunUnitTests.start): same: don't use .build until start()
6276 (RunUnitTests.describe): oops, don't report (None) when using
6278 (RunUnitTests.commandComplete): use getText()
6279 (RunUnitTests.createSummary): same
6280 (BuildDebs.commandComplete): same
6282 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6283 set args['command'] until start(), since our BuildStep is allowed
6284 to change their mind up until that point
6285 (TreeSize.commandComplete): use getText(), not getStdout()
6287 * docs/examples/twisted_master.cfg: update to current standards
6289 * docs/factories.xhtml: update
6290 * buildbot/process/factory.py: implement all the common factories
6291 described in the docs. The Trial factory doesn't work yet, and
6292 I've probably broken all the process_twisted.py factories in the
6293 process. There are compatibility classes left in for things like
6294 the old BasicBuildFactory, but subclasses of them are unlikely to
6296 * docs/examples/glib_master.cfg: use new BuildFactories
6297 * docs/examples/hello.cfg: same
6299 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6300 explicit 'workdir' args
6302 * buildbot/process/base.py (BuildFactory): move factories to ..
6303 * buildbot/process/factory.py (BuildFactory): .. here
6304 * buildbot/process/process_twisted.py: handle move
6305 * buildbot/test/test_config.py: same
6306 * buildbot/test/test_run.py: same
6307 * buildbot/test/test_steps.py: same
6308 * buildbot/test/test_vc.py: same
6309 * docs/factories.xhtml: same
6311 * NEWS: mention config changes that require updating master.cfg
6313 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6314 argument to all steps that weren't given one already, pointing at
6315 the "build/" directory.
6317 * docs/examples/hello.cfg: remove explicit 'workdir' args
6319 * docs/factories.xhtml: document standard BuildFactory clases,
6320 including a bunch which are have not yet been written
6322 2004-08-29 Brian Warner <warner@lothar.com>
6324 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6325 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6326 buildbot.status.builder so they aren't quite so internal
6327 * buildbot/process/base.py, buildbot/process/builder.py: same
6328 * buildbot/process/maxq.py, buildbot/process/step.py: same
6329 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6330 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6331 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6333 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6334 to handle new getLogs()-returns-list behavior
6335 (StatusResourceBuildStep.getChild): same
6336 (StepBox.getBox): same
6337 (WaterfallStatusResource.phase0): same
6339 * docs/source.xhtml: document how Buildbot uses version-control
6340 systems (output side: how we get source trees)
6341 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6342 systems (input side: how we learn about Changes)
6344 * buildbot/master.py (Manhole): use ComparableMixin
6345 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6346 * buildbot/changes/mail.py (MaildirSource): same
6347 * buildbot/status/client.py (PBListener): same
6348 * buildbot/status/html.py (Waterfall): same
6349 * buildbot/status/words.py (IRC): same
6351 * NEWS: start describing new features
6353 * buildbot/status/mail.py (MailNotifier): finish implementation.
6354 The message body is still a bit sparse.
6355 * buildbot/test/test_status.py (Mail): test it
6357 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6358 and __hash__ methods I wind up adding everywhere. Specifically
6359 intended to support the buildbot config-file update scheme where
6360 we compare, say, the old list of IStatusTargets against the new
6361 one and don't touch something which shows up on both lists.
6362 * buildbot/test/test_util.py (Compare): test case for it
6364 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6365 return a list instead of a dict
6366 (IBuildStepStatus.getLogs): same. The idea is that steps create
6367 logs with vaguely unique names (although their uniqueness is not
6368 guaranteed). Thus a compilation step should create its sole
6369 logfile with the name 'compile', and contribute it to the
6370 BuildStatus. If a step has two logfiles, try to create them with
6371 different names (like 'test.log' and 'test.summary'), and only
6372 contribute the important ones to the overall BuildStatus.
6373 * buildbot/status/builder.py (Event.getLogs): same
6374 (BuildStepStatus): fix default .text and .results
6375 (BuildStepStatus.addLog): switch to list-like .getLogs()
6376 (BuildStepStatus.stepFinished): same
6377 (BuildStatus.text): fix default .text
6378 (BuildStatus.getLogs): temporary hack to return all logs (from all
6379 child BuildStepStatus objects). Needs to be fixed to only report
6380 the significant ones (as contributed by the steps themselves)
6381 * buildbot/test/test_run.py: handle list-like .getLogs()
6382 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6384 2004-08-28 Brian Warner <warner@lothar.com>
6386 * buildbot/process/builder.py (Builder.attached): serialize the
6387 attachment process, so the attach-watcher isn't called until the
6388 slave is really available. Add detached watchers too, which makes
6391 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6393 * buildbot/test/test_swap.py: remove dead code
6395 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6396 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6397 sort of as if the command being run exited with a -1. There may
6398 still be some holes in this scheme.
6399 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6400 -r option appears before the module list
6401 * buildbot/process/step.py (CVS): add 'revision' argument
6403 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6404 when sending updates or stepComplete messages to the master, since
6405 we don't currently care whether they arrive or not. When we revamp
6406 the master/slave protocol to really resume interrupted builds,
6407 this will need revisiting.
6408 (lostRemote): remove spurious print
6410 * buildbot/master.py (BotPerspective.attached): serialize the
6411 new-builder interrogation process, to make testing easier
6412 (BotMaster.waitUntilBuilderDetached): convenience function
6414 * buildbot/status/builder.py (BuilderStatus): prune old builds
6415 (BuildStatus.pruneSteps): .. and steps
6416 (BuildStepStatus.pruneLogs): .. and logs
6417 (BuilderStatus.getBuild): handle missing builds
6418 * buildbot/status/html.py (StatusResourceBuild.body): display build
6419 status in the per-build page
6420 (BuildBox.getBox): color finished builds in the per-build box
6422 2004-08-27 Brian Warner <warner@lothar.com>
6424 * buildbot/status/mail.py (MailNotifier): new notification class,
6427 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6428 variants of a common base class which handles all the mode= logic
6430 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6432 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6434 2004-08-26 Brian Warner <warner@lothar.com>
6436 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6439 * buildbot/test/test_run.py: update to new Logfile interface, new
6440 buildbot.slave modules
6441 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6443 * MANIFEST.in: new sample config file
6444 * docs/examples/hello.cfg: same
6446 * buildbot/process/step_twisted.py: remove dead import
6448 * buildbot/process/step.py (RemoteCommand.run): catch errors
6450 (RemoteCommand.remote_update): ignore updates that arrive after
6452 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6453 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6454 the responsibilities of the subclass's methods
6455 (BuildStep.failed): catch errors during failure processing
6456 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6457 (CVS): move to a mode= argument (described in docstring), rather
6458 than the ungainly clobber=/export=/copydir= combination.
6459 (SVN): add mode= functionality to SVN too
6460 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6462 * buildbot/process/base.py (Build.startNextStep): catch errors
6463 during s.startStep()
6465 * buildbot/clients/base.py: update to new PB client interface.
6466 gtkPanes is still broken
6468 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6469 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6470 * setup.py: add buildbot.slave module
6471 * buildbot/bb_tap.py: handle move
6472 * buildbot/slave/registry.py: place to register commands, w/versions
6473 * buildbot/slave/bot.py: major simplifications
6474 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6475 instead of a fixed table. Eventually this will make the slave more
6476 extensible. Use 'start' method on the command, not .startCommand.
6477 Fix unsafeTracebacks handling (I think).
6478 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6479 helper class with a .start method that returns a Deferred.
6480 SlaveShellCommand is the form reached by the buildmaster. Commands
6481 which use multiple ShellCommands can just chain them as Deferreds,
6482 with some helper methods in Command (_abandonOnFailure and
6483 _checkAbandoned) to bail on rc!=0.
6484 (CVSCommand): prefer new mode= argument
6485 (SVNFetch): add mode= argument
6487 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6488 put a useful reason string on the build
6490 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6491 core functionality into an IStatusLog object
6492 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6493 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6494 (StatusResourceBuild.body): use proper accessor methods
6495 * buildbot/status/client.py (RemoteLog): PB-access goes here
6496 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6497 which delivers log contents too
6498 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6499 * buildbot/status/event.py: remove old Logfile completely
6501 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6502 subscription interface for IStatusLog subscriptions just like all
6503 other the status subscriptions
6504 (IStatusReceiver.logChunk): method called on subscribers
6506 2004-08-24 Brian Warner <warner@lothar.com>
6508 * buildbot/process/builder.py (Builder._pong): oops, ping response
6509 includes a result (the implicit None returned by remote_print).
6510 Accept it so the _pong method handles the response correctly.
6512 2004-08-06 Brian Warner <warner@lothar.com>
6514 * buildbot/test/test_config.py: update IRC, PBListener tests
6516 * buildbot/status/client.py (StatusClientPerspective): total
6517 rewrite to match new IStatus interfaces. New subscription scheme.
6518 There are still a few optimizations to make (sending down extra
6519 information with event messages so the client doesn't have to do a
6520 round trip). The logfile-retrieval code is probably still broken.
6521 Moved the PB service into its own port, you can no longer share a
6522 TCP socket between a PBListener and, say, the slaveport (this
6523 should be fixed eventually).
6524 * buildbot/clients/base.py (Client): revamp to match. still needs
6525 a lot of work, but basic event reporting works fine. gtkPanes is
6528 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6529 instance talks to a single irc server. Threw out all the old
6530 multi-server handling code. Still need to add back in
6531 builder-control (i.e. "force build")
6533 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6534 more random text to the as-yet-unreachable per-step page
6536 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6537 rename to stepETAUpdate
6538 (BuildStatus.subscribe): add build-wide ETA updates
6539 (BuilderStatus.getState): remove more cruft
6540 (BuilderStatus.getCurrentBuild): remove more cruft
6541 (BuilderStatus.buildStarted): really handle tuple-subscription
6542 * buildbot/test/test_run.py (Status.testSlave): handle the
6543 stepETAUpdate rename
6545 * buildbot/master.py (BuildMaster): don't add a default
6546 StatusClientService. Don't add a default IrcStatusFactory. Both
6547 are now added through c['status'] in the config file. c['irc'] is
6548 accepted for backwards compatibility, the only quirk is you cannot
6549 use c['irc'] to specify IRC servers on ports other than 6667.
6551 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6552 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6553 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6554 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6557 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6558 the buildmaster to re-read its config file
6561 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6562 find out the port our server is running on
6563 (WebTest.test_webPathname_port): same
6565 * buildbot/test/test_config.py (testWebPortnum): test it
6566 (testWebPathname): ditto
6568 * docs/config.xhtml: document new c['status'] configuration option
6570 * buildbot/status/html.py (Waterfall): new top-level class which
6571 can be added to c['status']. This creates the Site as well as the
6572 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6573 reachable as .parent, for everything.
6575 * buildbot/master.py (Manhole): make it a normal service Child
6576 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6577 webPathname. It will eventually replace c['irc'] and the implicit
6578 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6579 in as (deprecated) backward compatibility hooks for now.
6582 * buildbot/process/builder.py (Builder.buildFinished): don't
6583 inform out builder_status about a finished build, as it finds out
6584 through its child BuildStatus object
6586 * buildbot/status/html.py: extensive revamp. Use adapters to make
6587 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6588 have both starting and finishing times and adjust the waterfall
6589 display accordingly, using spacers if necessary. Use SlaveStatus
6590 to get buildslave info.
6591 (StatusResourceBuildStep): new just-one-step resource, used to get
6592 logfiles. No actual href to it yet.
6594 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6595 the time being, until I get the file-naming scheme right
6597 * buildbot/status/builder.py (Event): clean started/finished names
6598 (BuildStatus.isFinished): .finished is not None is the right test
6599 (BuildStatus.buildStarted): track started/finished times ourselves
6600 (BuilderStatus.getSlave): provide access to SlaveStatus object
6601 (BuilderStatus.getLastFinishedBuild): all builds are now in
6602 .builds, even the currently-running one. Accomodate this change.
6603 (BuilderStatus.eventGenerator): new per-builder event generator.
6604 Returns BuildStepStatus and BuildStatus objects, since they can
6605 both be adapted as necessary.
6606 (BuilderStatus.addEvent): clean up started/finished attributes
6607 (BuilderStatus.startBuild,finishBuild): remove dead code
6608 (SlaveStatus): new object to provide ISlaveStatus
6610 * buildbot/process/step.py (ShellCommand.getColor): actually
6611 return the color instead of setting it ourselves
6612 (CVS.__init__): pull .timeout and .workdir options out of
6613 **kwargs, since BuildStep will ignore them. Without this neither
6614 will be sent to the slave correctly.
6615 (SVN.__init__): same
6617 * buildbot/process/builder.py (Builder): move flags to class-level
6619 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6620 SlaveStatus handle that
6622 * buildbot/process/base.py (Build.firstEvent): remove dead code
6623 (Build.stopBuild): bugfix
6625 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6627 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6628 (ChangeMaster.eventGenerator): yield Changes, since there are now
6629 Adapters to turn them into HTML boxes
6631 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6632 (BotPerspective.attached): feed a SlaveStatus object
6633 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6634 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6636 * buildbot/interfaces.py: API additions
6637 (ISlaveStatus): place to get slave status
6639 2004-08-04 Brian Warner <warner@lothar.com>
6641 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6642 the delay finishes, so the step is marked as SUCCESS
6644 * buildbot/test/test_run.py (Status.testSlave): cover more of
6645 IBuildStatus and IBuildStepStatus
6647 * buildbot/status/progress.py (StepProgress): move some flags to
6648 class-level attributes
6649 (StepProgress.remaining): if there are no other progress metrics
6650 to go by, fall back to elapsed time
6651 (StepProgress.setExpectations): take a dict of metrics instead of
6653 (BuildProgress.setExpectationsFrom): pull expectations from the
6654 Expectations, instead of having it push them to the BuildProgress
6655 (Expectations): move some flags to class-level attributes
6656 (Expectations.__init__): copy per-step times from the
6658 (Expectations.expectedBuildTime): new method for per-build ETA
6660 * buildbot/status/event.py (Logfile): move some flags to
6661 class-level attributes
6662 (Logfile.logProgressTo): better method name, let step set the
6663 progress axis name (instead of always being "output")
6665 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6666 times directly, rather than depending upon the (possibly missing)
6667 .progress object. Use 'None' to indicate "not started/finished
6669 (BuildStepStatus.getExpectations): oops, return the full list of
6671 (BuilderStatus._buildFinished): append finished builds to .builds
6673 * buildbot/process/step.py (BuildStep): add separate .useProgress
6674 flag, since empty .progressMetrics[] still implies that time is a
6676 (CVS): set up the cmd in __init__, instead of waiting for start()
6678 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6679 calculation, this will eventually turn into a proper sourceStamp
6680 (Build.setupBuild): tell the Progress to load from the Expectations,
6681 instead of having the Expectations stuff things into the Progress
6682 (Build.buildException): add a build-level errback to make sure the
6683 build's Deferred fires even in case of exceptions
6685 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6687 * buildbot/process/builder.py (Builder.forceBuild): convey the
6688 reason instead of creating a fake Change
6690 * docs/examples/twisted_master.cfg: update to match reality
6692 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6693 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6694 fix or remove broken/breaking tests
6696 * buildbot/status/event.py (Logfile.__len__): remove evil method
6698 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6699 missing .build, for test convenience
6701 * buildbot/process/step_twisted.py: import fixes
6703 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6705 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6706 .statusbag reference
6708 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6709 connection at shutdown, and stop it from reconnecting
6711 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6712 chase down remote-execution bugs
6714 * buildbot/process/step.py: more fixes, remove
6715 BuildStep.setStatus()
6716 * buildbot/status/builder.py: move setStatus() functionality into
6718 * buildbot/status/event.py: minor fixes
6720 2004-08-03 Brian Warner <warner@lothar.com>
6722 * buildbot/process/base.py, buildbot/process/builder.py
6723 * buildbot/process/step.py, buildbot/status/builder.py
6724 * buildbot/status/event.py, buildbot/test/test_run.py:
6725 fix status delivery, get a basic test case working
6726 * buildbot/master.py: finish implementing basic status delivery,
6727 temporarily disable HTML/IRC/PB status sources
6729 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6731 * buildbot/status/progress.py (BuildProgress): remove dead code
6733 * buildbot/interfaces.py
6734 * buildbot/process/base.py, buildbot/process/builder.py
6735 * buildbot/process/step.py, buildbot/process/step_twisted.py
6736 * buildbot/status/builder.py: Complete overhaul of the all
6737 status-delivery code, unifying all types of status clients (HTML,
6738 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6739 look like. This commit is a checkpointing of the work-in-progress:
6740 the input side is mostly done (Builders/Builds sending status
6741 to the BuilderStatus/BuildStatus objects), but the output side has
6742 not yet been started (HTML resources querying BuilderStatus
6743 objects). Things are probably very broken right now and may remain
6744 so for several weeks, I apologize for the disruption.
6746 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6747 HTML as the log's contents. Currently used for exception tracebacks.
6748 * buildbot/status/progress.py: minor spelling changes
6750 2004-08-02 Brian Warner <warner@lothar.com>
6752 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6753 in mozilla. Also added stylesheets copied from Twisted's docs.
6754 Remember that these files are meant to be run through Lore first.
6755 Thanks to Philipp Frauenfelder for the fixes.
6756 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6757 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6758 * docs/template.tpl: added a Lore template
6760 2004-07-29 Brian Warner <warner@lothar.com>
6762 * buildbot/interfaces.py: revamp status delivery. This is the
6763 preview: these are the Interfaces that will be provided by new
6764 Builder code, and to which the current HTML/IRC/PB status
6765 displayers will be adapted.
6767 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6768 on the SlaveBuilder, not the Bot.
6769 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6771 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6772 set .usePTY on the FakeSlaveBuilder
6774 2004-07-25 Brian Warner <warner@lothar.com>
6776 * buildbot/changes/freshcvs.py: add some debug log messages
6777 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6778 disabled 'setFilter' syntax
6779 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6780 don't end with a slash
6782 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6784 * setup.py: bump to 0.5.0+ while between releases
6786 2004-07-23 Brian Warner <warner@lothar.com>
6788 * setup.py (version): Releasing buildbot-0.5.0
6790 2004-07-23 Brian Warner <warner@lothar.com>
6792 * README: update for 0.5.0 release
6794 * NEWS: update for 0.5.0 release
6796 2004-07-22 Brian Warner <warner@lothar.com>
6798 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6799 mktap-time configuration flag (--usepty=1, --usepty=0)
6800 * buildbot/bot.py: same
6802 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6803 an 'info' directory being unwanted
6805 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6806 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6807 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6808 and earlier), use a FreshCVSSourceOldcred instead.
6809 (test): simple test routine: connect to server, print changes
6811 * buildbot/changes/changes.py (Change.getTime): make it possible
6812 to print un-timestamped changes
6814 * buildbot/master.py (makeApp): delete ancient dead code
6815 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6816 * buildbot/test/test_config.py (testFindConfigFile): test it
6818 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6819 instead of win32 one
6822 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6823 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6826 * buildbot/process/base.py (Builder.__init__): change constructor
6827 to accept a dictionary of config data, rather than discrete
6828 name/slave/builddir/factory arguments
6830 * docs/examples/twisted_master.cfg: update to new syntax
6831 * docs/examples/glib_master.cfg: same
6832 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6833 rough tests of the new syntax
6836 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6837 to be an int, which means "run a web.distrib sub-server on a TCP
6838 port". This lets you publish the buildbot status page to a remote
6839 twisted.web server (using distrib.ResourceSubscription). Also
6840 rename the local attributes used to hold these web things so
6841 they're more in touch with reality.
6842 * buildbot/test/test_web.py: test webPortnum and webPathname
6843 * docs/config.xhtml: document this new use of webPathname
6845 * docs/config.xhtml: new document, slightly ahead of reality
6847 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6848 'prefix' handling: treat it as a simple string to check with
6849 .startswith, instead of treating it as a directory. This allows
6850 sub-directories to be used. If you use prefix=, you should give it
6851 a string that starts just below the CVSROOT and ends with a slash.
6852 This prefix will be stripped from all filenames, and filenames
6853 which do not start with it will be ignored.
6855 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6857 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6858 and --exclude (inverse of --include). SVN post-commit hooks
6859 now have total control over which changes get sent to buildbot and which
6862 2004-07-10 Brian Warner <warner@lothar.com>
6864 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6865 test case to match new API
6867 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6868 which crashed HTML display when self.entries=[] (needed to
6869 distinguish between [], which means "no entries yet", and None,
6870 which means "the entries have been swapped out to disk, go fetch
6873 2004-07-04 Brian Warner <warner@lothar.com>
6875 * buildbot/process/step_twisted.py (countFailedTests): Count
6876 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6877 10kb from the end because any import errors are wedged there and
6878 they would make us think the test log was unparseable.
6879 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6881 2004-06-26 Brian Warner <warner@lothar.com>
6883 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6884 delete-*.pyc command into an actual BuildStep, so we can label it
6886 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6887 (FullTwistedBuildFactory): same
6889 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6891 * contrib/fakechange.py: Add an errback when sending the fake
6892 change, so we know it didn't work.
6894 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6896 * buildbot/process/step_twisted.py: Delete *.pyc files before
6897 calling trial, so it doesn't catch any old .pyc files whose .py
6898 files have been moved or deleted.
6900 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6901 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6902 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6903 instead of ["twisted.test"], so that the end result is "trial -R
6906 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6907 regular expression to match filenames that should be ignored when
6908 changed. Also add a --revision parameter that specifies the
6909 revision to examine, which is useful for debugging.
6911 2004-06-25 Brian Warner <warner@lothar.com>
6913 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6914 summary of warnings (like DeprecationWarnings), next to the
6917 2004-05-13 Brian Warner <warner@lothar.com>
6919 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6920 we now have a w32 build slave courtesy of Mike Taylor.
6922 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6923 so broken. Fixed a race condition that tripped up interlocked
6924 builds and caused the status to be stuck at "Interlocked" forever.
6925 The twisted buildbot's one interlocked build just so happened to
6926 never hit this case until recently (the feeding builds both pass
6927 before the interlocked build is attempted.. usually it has to wait
6929 (Builder._pong_failed): fix method signature
6931 * setup.py: bump to 0.4.3+ while between releases
6933 2004-04-30 Brian Warner <warner@lothar.com>
6935 * setup.py (version): Releasing buildbot-0.4.3
6937 2004-04-30 Brian Warner <warner@lothar.com>
6939 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6941 * README: update for 0.4.3 release
6943 * NEWS: update for 0.4.3 release
6945 * buildbot/master.py (BuildMaster.__getstate__): make sure
6946 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6948 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6949 .trial as a class attribute, for upgrade from 0.4.2
6951 * buildbot/changes/changes.py (Change.links): add .links for
6954 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6955 .textWatchers and .htmlWatchers at save time, since they are both
6956 volatile, should allow smooth 0.4.2 upgrade
6958 * buildbot/process/step.py (CVS.finishStatus): catch failed
6959 CVS/SVN commands so we can make the status box red
6961 2004-04-29 Brian Warner <warner@lothar.com>
6963 * buildbot/changes/freshcvs.py
6964 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6965 code to do setFilter(), which tells the freshcvs daemon to not
6966 send us stuff that we're not interested in. I will uncomment it
6967 when a new version of CVSToys is available in which setFilter()
6968 actually works, and I get a chance to test it better.
6970 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6972 * buildbot/master.py (Dispatcher): use a registration scheme
6973 instead of hardwired service names
6974 (BuildMaster): keep track of the Dispatcher to support
6977 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6978 PBChangeSource class instead of having it be an undocumented
6979 internal feature of the ChangeMaster. Split out the code into a
6981 * buildbot/changes/pb.py (PBChangeSource): same
6982 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6984 * docs/{factories|sources|steps}.xhtml: document some pieces
6986 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6987 using FCMaildirSource
6988 (f23osx): update OS-X builder to use python2.3, since the slave
6989 was updated to Panther (10.3.3)
6991 2004-03-21 Brian Warner <warner@lothar.com>
6993 * buildbot/process/process_twisted.py: factor out doCheckout, change
6994 to use SVN instead of CVS
6996 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6997 an SVN subclass easier
6998 (BasicSVN): subclass which uses Subversion instead of CVS
7000 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7002 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7004 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7006 2004-02-25 Brian Warner <warner@lothar.com>
7008 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7009 is now either a list (which is passed to spawnProcess directly) or
7010 a string (which gets passed to /bin/sh -c). This removes the useSH
7011 flag and the ArgslistCommand class. Also send status header at the
7012 start and end of each command, instead of having the master-side
7014 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7015 -r'. Update to use list-based arguments.
7016 (SVNFetch): use list-based arguments, use ['dir'] argument to
7018 * buildbot/test/test_steps.py (Commands): match changes
7020 * buildbot/process/step.py (InternalShellCommand.words): handle
7022 (SVN): inherit from CVS, cleanup
7024 * buildbot/status/event.py (Logfile.content): render in HTML, with
7025 stderr in red and headers (like the name of the command we're
7026 about to run) in blue. Add link to a second URL (url + "?text=1")
7027 to get just stdout/stderr in text/plain without markup. There is
7028 still a problem with .entries=None causing a crash, it seems to occur
7029 when the logfile is read before it is finished.
7031 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7032 timeout to the keepalives, and use it to explicitly do a
7033 loseConnection instead of waiting for TCP to notice the loss. This
7034 ought to clear up the silent-lossage problem.
7035 (unsafeTracebacks): pass exception tracebacks back to the master,
7036 makes it much easier to debug problems
7038 2004-02-23 Brian Warner <warner@lothar.com>
7040 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7041 the whole command to /bin/sh instead of execve [Johan Dahlin]
7042 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7043 '-r HEAD' [Johan Dahlin]
7044 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7046 * buildbot/changes/changes.py (Change): add links= argument, add
7047 asHTML method [Johan Dahlin]. Modified to make a bit more
7048 XHTMLish. Still not sure how to best use links= .
7050 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7051 Change.asHTML to display the change, not asText
7053 * buildbot/status/html.py (StatusResourceBuilder): web button to
7056 * buildbot/test/test_run.py: test to actually start a buildmaster
7059 * MANIFEST.in: bring back accidentally-dropped test helper files
7061 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7062 that require cvstoys if it is not installed
7064 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7065 values of "bin/trial" [Dave Peticolas]
7066 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7067 tests passed" when we didn't happen to run any tests
7069 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7070 flunkOnFailure [Johan Dahlin]
7072 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7073 multiple instances of the same Step class by suffixing "_2", etc,
7074 to the name until it is unique. This name needs to be unique
7075 because it is used as a key in the dictionary that tracks build
7077 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7080 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7082 2004-01-14 Brian Warner <warner@lothar.com>
7084 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7085 kicked from a channel, log it
7087 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7088 something over whatever IRC channels the buildmaster is currently
7089 connected to. Added to try and track down a problem in which the
7090 master thinks it is still connected but the IRCd doesn't see it. I
7091 used a styles.Versioned this time, so hopefully users won't have
7092 to rebuild their .tap files this time.
7093 * contrib/debug.glade: add a "Poke IRC" button
7094 * contrib/debugclient.py: same
7096 * setup.py: bump to 0.4.2+ while between releases
7098 2004-01-08 Brian Warner <warner@lothar.com>
7100 * setup.py (version): Releasing buildbot-0.4.2
7102 2004-01-08 Brian Warner <warner@lothar.com>
7104 * NEWS: update for 0.4.2 release
7106 * README: document how to run the tests, now that they all pass
7108 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7110 * buildbot/process/step.py (CVS): add a global_options= argument,
7111 which lets you set CVS global options for the command like "-r"
7112 for read-only checkout, or "-R" to avoid writing in the
7114 * buildbot/slavecommand.py (CVSCommand): same
7116 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7117 testing easier (it is turned off when testing, to avoid the
7120 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7121 to make it easier to test: break generateStepID() out to a
7122 separate function, only update statusbag if it exists.
7123 (ShellCommands): create useful text for dict-based commands too.
7125 * test/*, buildbot/test/*: move unit tests under the buildbot/
7127 * setup.py (packages): install buildbot.test too
7129 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7130 * buildbot/test/test_steps.py: fix it, tests pass now
7132 2004-01-06 Brian Warner <warner@lothar.com>
7134 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7135 freshcvs mail uses a slightly different syntax for new
7136 directories. Update parser to handle either.
7137 * test/test_mailparse.py (Test1.testMsg9): test for same
7139 2003-12-21 Brian Warner <warner@lothar.com>
7141 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7142 'warnOnWarnings' so that lintian errors mark the build orange
7144 2003-12-17 Brian Warner <warner@lothar.com>
7146 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7147 messages emitted by Bonsai, contributed by Stephen Davis.
7149 * test/*: moved all tests to use trial instead of unittest. Some
7150 still fail (test_steps, test_slavecommand, and test_process).
7152 * setup.py (version): bump to 0.4.1+ while between releases
7154 2003-12-09 Brian Warner <warner@lothar.com>
7156 * setup.py (version): Releasing buildbot-0.4.1
7158 2003-12-09 Brian Warner <warner@lothar.com>
7160 * NEWS: update for 0.4.1 release
7162 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7163 freebsd builder code a little bit
7165 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7166 don't try to compare attributes of different classes
7167 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7168 (MaildirSource.messageReceived): fix Change delivery
7170 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7171 into the config file's namespace before loading it, like the
7172 documentation claims it does
7173 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7174 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7175 daemon comes back online
7177 2003-12-08 Brian Warner <warner@lothar.com>
7179 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7180 so the example will work with online=0 as well
7182 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7183 fix the __implements__ line
7185 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7186 class a twisted.application.service.Service, use startService to
7189 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7190 directory fd instead of simple open(). I'm sure this used to work,
7191 but the current version of python refuses to open directories with
7194 2003-12-05 Brian Warner <warner@lothar.com>
7196 * setup.py (version): bump to 0.4.0+ while between releases
7198 2003-12-05 Brian Warner <warner@lothar.com>
7200 * setup.py (version): Releasing buildbot-0.4.0
7202 2003-12-05 Brian Warner <warner@lothar.com>
7204 * docs/examples/glib_master.cfg: replace old sample scripts with
7205 new-style config files
7206 * MANIFEST.in: include .cfg files in distribution tarball
7208 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7209 implement a dummy method to avoid the exception that occurs when
7210 freshcvs sends this to us.
7212 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7213 removed the method, as it broke reconnection. Apparently
7214 stopFactory is called each time the connection attempt fails. Must
7216 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7217 attribute before serialization, since without stopFactory the
7218 reconnect timer may still be active and they aren't serializable.
7220 * test/test_mailparse.py (ParseTest): test with 'self' argument
7222 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7223 argument, as these "functions" are invoked like methods from class
7224 attributes and therefore always get an instance as the first
7227 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7228 message: thanks to Stephen Davis for the catch
7230 2003-12-04 Brian Warner <warner@lothar.com>
7232 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7233 twisted's standard ReconnectingClientFactory. Handles both oldcred
7234 and newcred connections. Also has a bug-workaround for
7235 ReconnectingClientFactory serializing its connector when it
7238 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7239 pbutil. Replace makeApp stuff with proper newcred/mktap
7240 makeService(). Don't serialize Ephemerals on shutdown.
7242 * buildbot/changes/changes.py (ChangeMaster): make it a
7243 MultiService and add the sources as children, to get startService
7244 and stopService for free. This also gets rid of the .running flag.
7246 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7247 new pbutil, turn into a TCPClient at the same time (to get
7248 startService for free). Two variants exist: FreshCVSSourceOldcred
7249 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7250 yet, but when it does, we'll be ready).
7251 (FreshCVSSource.notify): handle paths which are empty after the
7252 prefix is stripped. This only happens when the top-level (prefix)
7253 directory is added, at the very beginning of a Repository's life.
7255 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7256 Now the only reconnecting code is in the factory where it belongs.
7257 (Builder.unsubscribe): unregister the disconnect callback when we
7258 delete the builder on command from the master (i.e. when the
7259 buildmaster is reconfigured and that builder goes away). This
7260 fixes a multiple-delete exception when the status client is shut
7262 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7265 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7266 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7268 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7270 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7271 a list of globs (ugh). The testdir will be searched for files
7272 named *.tests and run the tests in the order specified in each of
7273 those files. This allows for "dependancies" between tests to be
7276 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7277 argument to pass to run_maxq.py, instead of a glob.
7279 2003-10-17 Brian Warner <warner@lothar.com>
7281 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7282 files that live in the sandbox
7284 2003-10-15 Brian Warner <warner@lothar.com>
7286 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7287 spelling error in "docs" count-warnings output
7288 (HLint.start): stupid thinko meant .xhtml files were ignored
7290 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7291 tests now that cReactor is banished to the sandbox
7293 2003-10-10 Brian Warner <warner@lothar.com>
7295 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7296 scheme: now .xhtml are sources and .html are generated
7298 2003-10-08 Brian Warner <warner@lothar.com>
7300 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7301 we were ignoring the 'randomly' parameter.
7303 2003-10-01 Brian Warner <warner@lothar.com>
7305 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7306 posix, to kill sub-children of aborted slavecommands.
7308 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7309 Clean up initialization: lastBuildStatus remains None until the
7310 first build has been completed.
7312 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7313 None as a lastBuildStatus
7314 * buildbot/clients/gtkPanes.py: same
7316 * buildbot/status/client.py (StatusClientService): keep
7317 BuilderStatus objects in self.statusbags . These objects now live
7318 here in the StatusClientService and are referenced by the Builder
7319 object, rather than the other way around.
7320 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7321 * buildbot/process/base.py (Builder): same
7322 * test/test_config.py (ConfigTest.testBuilders): same
7324 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7325 an existing builder, leave the statusbag alone. This will preserve the
7328 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7329 hook. This will probably go away in favor of a class in upcoming
7332 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7333 serviceName from newcred FreshCVSNotifiee setup
7335 2003-09-29 Brian Warner <warner@lothar.com>
7337 * buildbot/process/process_twisted.py: switch to new reactor
7339 * docs/examples/twisted_master.cfg: same
7341 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7343 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7344 botmaster reference instead of the oldapp service lookup
7346 * buildbot/master.py (BuildMaster.__init__): give the
7347 StatusClientService a reference to the botmaster to make it easier to
7350 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7352 * buildbot/status/html.py (Box.td): escape hreffy things so you
7353 can have spaces in things like builder names
7354 (StatusResourceBuilder.body)
7355 (WaterfallStatusResource.body)
7356 (WaterfallStatusResource.body0): same
7358 2003-09-25 Brian Warner <warner@lothar.com>
7360 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7361 rearrange the builder list when adding or removing builders: keep
7362 them in the order the user requested.
7363 * test/test_config.py (ConfigTest.testBuilders): verify it
7365 * contrib/debug.glade: give the debug window a name
7367 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7368 now wait on multiple interlocks. Fix code relating to that.
7369 (Builder.checkInterlocks): same
7370 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7372 * buildbot/master.py (BuildMaster.loadConfig): move from
7373 deprecated pb.BrokerFactory to new pb.PBServerFactory
7374 * test/test_config.py (ConfigTest.testWebPathname): same
7376 * docs/examples/twisted_master.cfg: fix interlock declaration
7378 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7379 Interlocks to their Builders into interlock.py .
7380 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7382 * test/test_config.py (ConfigTest.testInterlocks): validate
7385 * buildbot/process/base.py (Builder.__init__): better comments
7386 * buildbot/process/interlock.py (Interlock.__repr__): same
7387 (Interlock.deactivate): add .active flag, move the code that
7388 attaches/detaches builders into the Interlock
7390 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7392 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7393 tests using the new run_maxq.py script, and reporting failures by
7396 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7397 tests, reporting their success or failure in a buildbot-friendly
7400 2003-09-24 Brian Warner <warner@lothar.com>
7402 * docs/examples/twisted_master.cfg: example of a new-style config
7403 file. This lives in the buildmaster base directory as
7406 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7407 button to make the master re-read its config file
7409 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7410 buildmaster configuration from a file. This file can be re-read
7411 later, and the buildmaster will update itself to match the new
7412 desired configuration. Also use new Twisted Application class.
7413 * test/Makefile, test/test_config.py: unit tests for same
7415 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7416 FreshCVSSources comparable, to support reload.
7417 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7419 * buildbot/process/base.py (Builder): make them comparable, make
7420 Interlocks easier to attach, to support reload. Handle
7421 re-attachment of remote slaves.
7422 * buildbot/process/interlock.py (Interlock): same
7424 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7425 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7426 buildmaster taps are now constructed with mktap.
7427 * buildbot/status/client.py (StatusClientService): same
7429 * buildbot/status/words.py: move to new Services, add support to
7430 connect to multiple networks, add reload support, allow nickname
7431 to be configured on a per-network basis
7433 2003-09-20 Brian Warner <warner@lothar.com>
7435 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7436 the freebsd builder, now that the machine has been upgraded and no
7437 longer has python2.2
7439 * setup.py (version): bump to 0.3.5+ while between releases
7441 2003-09-19 Brian Warner <warner@lothar.com>
7443 * setup.py (version): Releasing buildbot-0.3.5
7445 2003-09-19 Brian Warner <warner@lothar.com>
7447 * NEWS: add post-0.3.4 notes
7449 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7451 * MANIFEST.in: add contrib/*
7453 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7454 use a remote root now: cvs.twistedmatrix.com
7456 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7458 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7459 compatibility with old servers
7460 (FreshCVSSource.start): and provide a way to use it
7461 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7463 * docs/examples/twisted_master.py (twisted_app): update to new
7465 (twisted_app): listen on new ~buildbot socket
7466 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7468 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7469 to reduce cvs bandwidth (update instead of full checkout)
7471 2003-09-11 Brian Warner <warner@lothar.com>
7473 * contrib/fakechange.py: demo how to connect to the changemaster
7474 port. You can use this technique to submit changes to the
7475 buildmaster from source control systems that offer a hook to run a
7476 script when changes are committed.
7478 * contrib/debugclient.py: tool to connect to the debug port. You
7479 can use it to force builds, submit fake changes, and wiggle the
7482 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7483 'Dispatcher' realm to handle all the different kinds of
7484 connections and Perspectives: buildslaves, the changemaster port,
7485 the debug port, and the status client port. NewCredPerspectives
7486 now have .attached/.detached methods called with the remote 'mind'
7487 reference, much like old perspectives did. All the pb.Services
7488 turned into ordinary app.ApplicationServices .
7489 (DebugService): went away, DebugPerspectives are now created
7490 directly by the Dispatcher.
7491 (makeApp): changed interface a little bit
7493 * buildbot/changes/changes.py: newcred
7494 * buildbot/status/client.py: newcred
7496 * buildbot/clients/base.py: newcred client side changes
7497 * buildbot/bot.py: ditto
7499 * docs/examples/glib_master.py: handle new makeApp() interface
7500 * docs/examples/twisted_master.py: ditto
7502 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7503 base newcred Perspectives on. This should go away once Twisted
7504 itself provides something sensible.
7507 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7509 * contrib/svn_buildbot.py: A program that you can call from your
7510 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7511 when a change in an SVN repository has happened. See the top of
7512 the file for some minimal usage info.
7514 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7516 * buildbot/slavecommand.py (ArglistCommand): Add new
7517 ArglistCommand that takes an argument list rather than a string as
7518 a parameter. Using a st.split() for argv is very bad.
7520 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7521 update to a particular revision rather than always checking out
7522 (still not very smart about it, there may be cases where the
7523 checkout becomes inconsistent).
7525 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7527 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7528 SVN fetch support. It can checkout (not update!) a specified
7529 revision from a specified repository to a specified directory.
7531 * buildbot/status/progress.py (Expectations.update): Fix an
7532 obvious bug (apparently created by the change described in the
7533 previous ChangeLog message) by moving a check to *after* the
7534 variable it checks is defined.
7537 2003-09-08 Brian Warner <warner@lothar.com>
7539 * buildbot/status/progress.py (Expectations.update): hack to catch
7540 an exception TTimo sees: sometimes the update() method seems to
7541 get called before the step has actually finished, so the .stopTime
7542 is not set, so no totalTime() is available and we average None
7543 with the previous value. Catch this and just don't update the
7544 metrics, and emit a log message.
7546 2003-08-24 Brian Warner <warner@lothar.com>
7548 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7549 parameter to set copydir='original' in CVS commands.
7551 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7553 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7554 which tells the command to maintain a separate original-source CVS
7555 workspace. For each build, this workspace will be updated, then
7556 the tree copied into a new workdir. This reduces CVS bandwidth
7557 (from a full checkout to a mere update) while doubling the local
7558 disk usage (to keep two copies of the tree).
7560 2003-08-21 Brian Warner <warner@lothar.com>
7562 * buildbot/status/event.py (Logfile.addEntry): if the master web
7563 server dies while we're serving a page, request.write raises
7564 pb.DeadReferenceError . Catch this and treat it like a
7565 notifyFinish event by dropping the request.
7567 2003-08-18 Brian Warner <warner@lothar.com>
7569 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7570 (instead of blowing up) if a force-build command is given without
7573 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7574 don't blow up if there aren't yet any Changes in the list
7576 2003-08-02 Brian Warner <warner@lothar.com>
7578 * buildbot/bot.py (updateApplication): don't set the .tap name,
7579 since we shouldn't assume we own the whole .tap file
7581 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7582 'mktap buildbot' (without a subcommand) better
7584 2003-07-29 Brian Warner <warner@lothar.com>
7586 * buildbot/status/words.py
7587 (IrcStatusFactory.clientConnectionLost): when we lose the
7588 connection to the IRC server, schedule a reconnection attempt.
7590 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7591 use shutil.rmtree instead of forking off an "rm -rf" command.
7592 rmtree may take a while and will block until it finishes, so we
7593 use "rm -rf" if available.
7595 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7596 freebsd buildslave badly
7598 * setup.py (version): bump to 0.3.4+ while between releases
7600 2003-07-28 Brian Warner <warner@lothar.com>
7602 * setup.py (version): Releasing buildbot-0.3.4
7604 2003-07-28 Brian Warner <warner@lothar.com>
7606 * NEWS: update in preparation for release
7608 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7609 process.signalProcess instead of os.kill, to improve w32
7612 * docs/examples/twisted_master.py (twisted_app): turn off
7613 win32eventreactor: the tests hang the buildslave badly
7615 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7616 failed builds, since usually the failures are consistent
7618 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7619 add compileOpts/compileOpts2 to reactors build
7621 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7622 (twisted_app): use both default and win32eventreactor on w32 build.
7623 Use both default and kqreactor on freebsd build.
7625 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7626 add compileOpts2, which is put after the build_ext argument. w32
7627 needs "-c mingw32" here.
7629 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7630 touch .acqpath, it goes away in recent Twisted releases
7632 * docs/examples/twisted_master.py (twisted_app): use "python" for
7633 the w32 buildslave, not "python2.2"
7635 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7636 the directory exists.. should hush an exception under w32
7638 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7639 ProcessTerminated -provided values for signal and exitCode rather
7640 than parsing the unix status code directly. This should remove one
7641 more roadblock for a w32-hosted buildslave.
7643 * test/test_mailparse.py: add test cases for Syncmail parser
7645 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7646 temporary compatibility import. Note! Start importing
7647 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7649 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7651 2003-07-27 Brian Warner <warner@lothar.com>
7653 * NEWS: started adding new features
7655 * buildbot/changes/mail.py: start work on Syncmail parser, move
7656 mail sources into their own file
7658 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7659 as implementing IChangeSource
7660 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7662 * buildbot/interfaces.py: define the IChangeSource interface
7664 2003-07-26 Brian Warner <warner@lothar.com>
7666 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7668 2003-06-25 Brian Warner <warner@lothar.com>
7670 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7673 2003-06-17 Brian Warner <warner@lothar.com>
7675 * buildbot/status/words.py: clean up method usage to avoid error
7676 in silly IRC command
7677 (IrcStatusBot.emit_status): round off seconds display
7679 * buildbot/process/base.py (Build): delete the timer when saving
7680 to the .tap file, and restore it (if it should still be running)
7681 upon restore. This should fix the "next build in -34 seconds"
7682 messages that result when the master is restarted while builds are
7683 sitting in the .waiting slot. If the time for the build has
7684 already passed, start it very soon (in 1 second).
7686 * buildbot/status/words.py: more silly commands
7688 * README (REQUIREMENTS): add URLs to all required software
7690 * buildbot/status/words.py ('last'): mention results of, and time
7693 2003-05-28 Brian Warner <warner@lothar.com>
7695 * buildbot/status/words.py: add 'last' command
7696 (IrcStatusBot.emit_status): add current-small text to 'status' output
7698 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7699 (twisted_app): remove spaces from OS-X builder name
7701 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7702 * buildbot/status/words.py: IRC bot should actually be useful now
7704 2003-05-23 Brian Warner <warner@lothar.com>
7706 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7707 "slave information" from $(slavedir)/info/* . These files are
7708 maintained by the slave administrator, and describe the
7709 machine/environment that is hosting the slave. Information from
7710 them is put into the "Builder" HTML page. Still need to establish
7711 a set of well-known filenames and meanings for this data: at the
7712 moment, *all* info/* files are sent to the master, but only
7713 'admin' and 'host' are used on that end.
7714 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7715 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7716 * buildbot/master.py (BotPerspective.got_info): ditto
7718 2003-05-22 Brian Warner <warner@lothar.com>
7720 * setup.py (version): bump version to 0.3.3+ while between releases
7722 2003-05-21 Brian Warner <warner@lothar.com>
7724 * setup.py: Releasing buildbot-0.3.3
7726 2003-05-21 Brian Warner <warner@lothar.com>
7728 * NEWS: 0.3.3 news items
7730 * README: describe --keepalive and life behind a NAT box
7732 * buildbot/bot.py (Bot.connected): implement application-level
7733 keepalives to deal with NAT timeouts, turn them on with
7734 --keepalive option or when SO_KEEPALIVE doesn't work.
7736 * buildbot/master.py (BotPerspective): accept keepalives silently
7738 * buildbot/process/base.py (Build.buildException): CopiedFailures
7739 don't carry as much information as local ones, so don't try to
7740 create a big HTMLized version of them.
7742 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7743 log file when step fails due to an exception, such as when the slave
7746 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7747 --testmodule argument instead of grepping for test-case-name tags
7748 ourselves. Remove FindUnitTests code.
7749 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7751 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7753 2003-05-16 Brian Warner <warner@lothar.com>
7755 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7756 argument to allow things like CFLAGS=-O0 to be passed without relying
7757 upon /bin/sh processing on the slave.
7759 * buildbot/process/step.py (InternalShellCommand.start): send
7761 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7762 'split' instead of letting /bin/sh do it. This should also remove
7763 the need for /bin/sh on the buildslave, making it more likely to
7766 * buildbot/status/html.py: html-escape text in blamelist.
7767 Add "force build" button to the Builder page.
7769 * buildbot/process/step_twisted.py (countFailedTests): look at
7770 last 1000 characters for status line, as import errors can put it
7771 before the -200 point.
7773 2003-05-15 Brian Warner <warner@lothar.com>
7775 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7777 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7778 make 'clobber' a parameter, so it is possible to have builds which
7779 do full tests but do a cvs update instead of hammering the CVS
7780 server with a full checkout each build
7782 * buildbot/process/step.py (InternalShellCommand): bump default
7783 timeout to 20 minutes
7785 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7786 the master to trigger a build. Run it via manhole.
7788 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7789 allow slaves to trigger any build that they host, to make life
7790 easier for slave admins who are testing out new build processes
7792 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7793 don't flunk cReactor or qtreactor on failure, since they fail alot
7794 these days. Do warnOnFailure instead.
7796 * buildbot/process/base.py: change Builder.buildable from a list
7797 into a single slot. When we don't have a slave, new builds (once
7798 they make it past the timeout) are now merged into an existing
7799 buildable one instead of being queued. With this change, a slave
7800 which has been away for a while doesn't get pounded with all the
7801 builds it missed, but instead just does a single build.
7803 2003-05-07 Brian Warner <warner@lothar.com>
7805 * setup.py (version): bump version to 0.3.2+ while between releases
7807 2003-05-07 Brian Warner <warner@lothar.com>
7809 * setup.py: Releasing buildbot-0.3.2
7811 2003-05-07 Brian Warner <warner@lothar.com>
7813 * setup.py: fix major packaging error: include subdirectories!
7815 * NEWS: add changes since last release
7817 * README (REQUIREMENTS): update twisted/python dependencies
7819 * buildbot/status/builder.py (Builder.startBuild): change
7820 BuildProcess API: now they should call startBuild/finishBuild
7821 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7822 keeping a list of builds in the statusbag, to support other kinds of
7824 (Builder.addClient): send current-activity-small to new clients
7825 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7828 * buildbot/status/client.py: drop RemoteReferences at shutdown
7830 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7832 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7833 more debug messages for remote status client
7835 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7836 (.stepFailed): only fire the Deferred once, even if both
7837 stepComplete and stepFailed are called. I think this can happen if
7838 an exception occurs at a weird time.
7840 * buildbot/status/words.py: work-in-progress: IRC status delivery
7842 2003-05-05 Brian Warner <warner@lothar.com>
7844 * docs/examples/twisted_master.py (twisted_app): hush internal
7845 python2.3 distutils deprecation warnings
7846 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7847 add compileOpts= argument which inserts extra args before the
7848 "setup.py build_ext" command. This can be used to give -Wignore
7849 warnings, to hush some internal python-2.3 deprecation messages.
7851 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7852 the ['twisted.test'] default test case to make it easier to change
7855 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7856 * buildbot/clients/gtkPanes.py: ditto
7858 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7859 arg to collapse RunUnitTestsRandomly into RunUnitTests
7860 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7861 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7863 * buildbot/status/html.py (StatusResource): shuffle Resources
7864 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7865 would serve the waterfall display, but the internal links were
7866 only valid on the trailing-slash version. The correct behavior is
7867 for the non-slashed one to serve a Redirect to the slashed one.
7868 This only shows up when the buildbot page is hanging off another
7869 server, like a Twisted-Web distributed server.
7871 * buildbot/status/event.py (Event, RemoteEvent): make Events
7872 pb.Cacheable, with RemoteEvent as the cached version. This removes
7873 a lot of explicit send-an-update code.
7874 * buildbot/status/builder.py (Builder): remove send-update code
7875 * buildbot/status/client.py (ClientBuilder): remove send-update
7876 code, and log errors that occur during callRemote (mostly to catch
7877 InsecureJelly exceptions)
7879 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7880 run Lore with the same python used in the rest of the build
7882 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7884 * buildbot/process/step_twisted.py (HLint): accept 'python'
7885 argument. Catch rc!=0 and mark the step as failed. This marks the
7886 build orange ("has warnings").
7887 (RunUnitTestsJelly): move out to step_twisted2.py
7889 * buildbot/util.py (ignoreStaleRefs): add utility function
7891 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7892 don't fake ETA object, it's too hard to get right
7894 2003-05-02 Brian Warner <warner@lothar.com>
7896 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7898 2003-05-01 Brian Warner <warner@lothar.com>
7900 * buildbot/status/html.py (StatusResource.body): oops, I was
7901 missing a <tr>, causing the waterfall page to be misrendered in
7902 everything except Galeon.
7904 2003-04-29 Brian Warner <warner@lothar.com>
7906 * docs/examples/twisted_master.py: make debuild use python-2.2
7907 explicitly, now that Twisted stopped supporting 2.1
7909 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7910 handle tuple results too. I keep forgetting this, which suggests
7911 it needs to be rethought.
7913 * setup.py (setup): bump version to 0.3.1+ while between releases
7915 2003-04-29 Brian Warner <warner@lothar.com>
7917 * setup.py: Releasing buildbot-0.3.1
7919 2003-04-29 Brian Warner <warner@lothar.com>
7921 * README (SUPPORT): add plea to send questions to the mailing list
7923 * NEWS, MANIFEST.in: add description of recent changes
7925 * docs/examples/twisted_master.py: add the code used to create the
7926 Twisted buildmaster, with passwords and such removed out to a
7929 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7930 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7931 buildmasters to not require CVSToys be installed.
7932 * README, docs/examples/glib_master: update to match the change
7934 * buildbot/clients/base.py, buildbot/bot.py,
7935 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7936 ReconnectingPB from CVSToys distribution to remove CVSToys
7937 dependency for build slaves and status clients. Buildmasters which
7938 use FreshCVSSources still require cvstoys be installed, of course.
7940 2003-04-25 Brian Warner <warner@lothar.com>
7942 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7943 runTestsRandomly arg to turn on trial -z
7945 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7946 experimental code to use trial's machine-parseable output to get
7947 more detailed test results. Still has some major issues.
7948 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7951 * buildbot/status/builder.py (Builder.setCurrentBuild):
7952 anticipating moving build history into statusbag, not used yet
7954 * buildbot/status/tests.py: code to centralize test results,
7955 doesn't work quite yet
7957 * buildbot/status/event.py (Event): use hasattr("setName") instead
7958 of isinstance for now.. need better long-term solution
7960 * buildbot/status/html.py: Remove old imports
7962 2003-04-24 Brian Warner <warner@lothar.com>
7964 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7965 ignore changes under doc/fun/ and sandbox/
7967 * buildbot/process/step_twisted.py: update pushEvent and friends.
7969 * buildbot/status/html.py (Box.td): replace event.buildername with
7970 event.parent.getSwappableName(). Needs more thought.
7972 * buildbot/status/builder.py (Builder): Replace pushEvent and
7973 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7974 Tell events they are being pruned with event.delete().
7976 * buildbot/process/base.py (Build): Remove Builder status-handling
7977 methods. s/pushEvent/setCurrentActivity/.
7979 * buildbot/process/step.py (BuildStep): clean up status delivery.
7980 Gouse builder.statusbag methods instead of intermediate builder
7981 methods. s/updateLastEvent/updateCurrentActivity/.
7982 s/finalizeLastEvent/finishCurrentActivity/. Use
7983 addFileToCurrentActivity for summaryFunction.
7985 * buildbot/status/event.py (Logfile): put data in a Swappable when
7987 (Event): add more setter methods. Remove .buildername, use .parent
7988 and getSwappableName instead (needs more thought).
7990 * buildbot/util.py (Swappable):
7991 * test/test_swap.py: don't bother setting filename at __init__
7992 time, do it later. Change setFilename args to take parent first,
7993 since it provides the most significant part of the filename.
7995 2003-04-23 Brian Warner <warner@lothar.com>
7997 * buildbot/status/event.py (Logfile.addEntry): append to previous
8000 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8001 anticipating Swappable
8002 (InternalShellCommand.remoteUpdate): split out various log-adding
8003 methods so subclasses can snarf stdout separately
8005 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8006 in anticipation of Swappable build logs
8007 (Builder.testsFinished): anticipating TestResults, still disabled
8009 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8012 * buildbot/status/event.py (Logfile): add (disabled) support for
8013 Swappable, not ready for use yet
8015 * buildbot/util.py (Swappable): object which is swapped out to
8016 disk after some period of no use.
8017 * test/test_swap.py: test buildbot.utils.Swappable
8019 2003-04-14 Brian Warner <warner@lothar.com>
8021 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8022 periodic-build timer. Set the .periodicBuildTime on a builder
8023 instance to some number of seconds to activate it.
8025 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8027 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8028 a way that survives result tuples
8030 2003-04-12 Brian Warner <warner@lothar.com>
8032 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8033 return a dict instead of a tuple: allow summarizers to provide
8034 multiple summaries if they want
8035 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8036 (debuildSummarizer): summarize lintian warnings/errors
8038 2003-04-10 Brian Warner <warner@lothar.com>
8040 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8042 2003-04-09 Brian Warner <warner@lothar.com>
8044 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8045 empty summaries: happens when the tests fail so hard they don't emit
8046 a parseable summary line.
8048 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8049 Allow summaryFunction to return None to indicate no summary should
8052 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8053 writing to stale HTTP requests: notice when they disconnect and
8054 remove the request from the list. Also add CacheToFile from
8055 moshez, will be used later.
8057 2003-04-08 Brian Warner <warner@lothar.com>
8059 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8060 should be an int, not a list of strings
8062 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8063 if we weren't actually connected
8065 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8066 to show the tail end of the trial text output
8068 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8069 hook to summarize the results of a ShellCommand
8071 2003-04-07 Brian Warner <warner@lothar.com>
8073 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8074 twisted test suite code into a single class.
8075 * buildbot/process/process_twisted.py: same
8077 2003-04-04 Brian Warner <warner@lothar.com>
8079 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8081 * README (SLAVE): document use of mktap to create slave .tap file
8082 (REQUIREMENTS): describe dependencies
8084 * buildbot/bb_tap.py, buildbot/plugins.tml:
8085 * buildbot/bot.py (updateApplication): Add mktap support for creating
8086 buildslave .tap files
8088 2003-03-28 Brian Warner <warner@lothar.com>
8090 * buildbot/process/step.py (InternalShellCommand.finished): handle
8091 new tuple result values (fix embarrasing bug that appeared during
8094 2003-03-27 Brian Warner <warner@lothar.com>
8096 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8099 2003-03-25 Brian Warner <warner@lothar.com>
8101 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8102 to overall build status
8103 * buildbot/clients/base.py (Builder): improve event printing
8104 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8105 instead of generic ShellCommand
8106 (Build): Add .stopBuild, use it when slave is detached
8108 * buildbot/process/step.py (Configure,Test): give the steps their
8109 own names and status strings
8111 * buildbot/status/html.py (StatusResource): add "show" argument,
8112 lets you limit the set of Builders being displayed.
8114 2003-03-20 Brian Warner <warner@lothar.com>
8116 * buildbot/process/basic.py: removed
8118 2003-03-19 Brian Warner <warner@lothar.com>
8120 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8121 turn off process-docs by default
8123 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8124 when displaying build information without anything in allBuilds[]
8126 * buildbot/bot.py (makeApp): really take password from sys.argv
8128 2003-03-18 Brian Warner <warner@lothar.com>
8130 * buildbot/bot.py (buildApp): take password from sys.argv
8132 * README: replace with more useful text
8134 * setup.py: add a real one
8135 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8137 * docs/PyCon-2003/: added sources for PyCon paper.
8139 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8140 now Build objects control the process and Builder only handles
8141 slave stuff and distribution of changes/status. A new BuildFactory
8142 class creates Build objects on demand.
8144 Created ConfigurableBuild which takes a list of steps to run. This
8145 makes it a lot easier to set up a new kind of build and moves us
8146 closer to being able to configure a build from a web page.
8148 * buildbot/process/step_twisted.py, process_twisted.py: move to
8149 new model. A lot of code went away.
8151 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8152 send lots of empty progress messages to the client.
8154 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8156 2003-02-20 Brian Warner <warner@lothar.com>
8158 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8160 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8161 Twisted bug that prevented non-pty processes from working just got
8162 fixed, and the bug that leaks ptys is still being investigated.
8164 * buildbot/process/step.py (CVS): send timeout arg to slave
8166 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8167 builders coming and going
8168 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8169 from CVSToys, handle lost-buildmaster
8171 * buildbot/status/client.py (StatusClientService.removeBuilder):
8172 Clean up status client protocol: send builders (with references)
8173 as they are created, rather than sending a list and requiring the
8174 client to figure out which ones are new.
8175 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8176 attempts to force a build on an unknown builder
8178 2003-02-19 Brian Warner <warner@lothar.com>
8180 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8181 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8182 Twisted stops leaking them.
8183 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8184 builder goes to an idle state.
8186 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8187 I figure out why CVS commands hang without them, and/or I fix the
8188 hung-command timeout
8190 2003-02-16 Brian Warner <warner@lothar.com>
8192 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8193 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8194 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8195 GenerateDocs now that they are prefixed with WARNING:.
8197 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8198 use manual href target instead of request.childLink
8200 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8201 display every second, but update the ETA every 5 seconds (or
8202 whenever) as remote_progress messages arrive.
8205 2003-02-12 Brian Warner <warner@lothar.com>
8207 * *: import current sources from home CVS repository
8211 # add-log-time-format: add-log-iso8601-time-string