1 2007-11-21 Brian Warner <warner@lothar.com>
3 * buildbot/status/web/waterfall.py (WaterfallStatusResource.body):
4 fix timezone calculation, we were always emitting DST, even in
5 winter. Thanks to Charles Lepple and John Saxton for the patch.
7 * buildbot/test/test_web.py (Waterfall.test_waterfall._check1): same
10 * lots: a whole batch of patches from Benoit Sigoure, referenced
11 in ticket #138. Thanks!
13 * buildbot/master.py (BuildMaster.loadConfig): builder names that
14 begin with an underscore are now reserved, so prohibit them from
15 appearing in the config file.
16 * NEWS: announce this change.
18 * buildbot/status/web/base.py: add buttons (to one_line_per_build
19 and one_box_per_builder) to force/stop builds on all Builders at
21 * buildbot/status/web/baseweb.py: same
22 (OneBoxPerBuilder.body): add links to the per-Builder page
24 * buildbot/status/web/builder.py: same
26 * buildbot/status/web/builder.py (StatusResourceBuilder.body):
27 factor out force/stop form generation
28 * buildbot/status/web/base.py: same
29 * buildbot/status/web/build.py: same
31 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
32 simplify some 'if' statements
33 (StatusResourceBuilder.build_line): add a 'Stop Build' button next
34 to the 'Force Build' button, so you can start and stop a build
36 (StatusResourceBuilder.force): redirect back to the waterfall,
37 rather than the index page
38 (StatusResourceBuilder.ping): same
39 * buildbot/status/web/build.py (StatusResourceBuild.stop): same
41 * buildbot/slave/bot.py (Bot.remote_setBuilderList): don't
42 consider the 'info' directory as a leftover directory. Patch from
43 Benoit Sigoure, ticket #138.
44 (others): remove trailing whitespace
46 2007-11-01 Brian Warner <warner@lothar.com>
48 * buildbot/status/web/builder.py (StatusResourceBuilder.build_line):
49 if there's no current step, don't try to display its description.
50 Same crash as in #96, this time in the web page. Closes #111.
52 * buildbot/status/web/base.py (OneLineMixin.make_line): tolerate
53 results == None (i.e. when the build hasn't finished yet);
54 previously this code exploded when trying to find a CSS class for
55 that results value. Patch from Greg Ward. Closes #118.
57 * buildbot/status/client.py (RemoteBuildStep.remote_getLogs):
58 IBuildStepStatus.getLogs() returns a list, not a dict. Patch from
59 Fabrice Crestois. Closes #121.
61 2007-10-31 Brian Warner <warner@lothar.com>
63 * buildbot/status/words.py (Contact.emit_status): if there's no
64 current step, don't try to display its description. This should
65 fix the crash when asking the irc bot about builds which are
66 waiting for a build-wide Lock. Closes #96.
68 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
69 'columnName' argument, from a patch by Ben Hearsum. Closes #120.
71 2007-10-16 Brian Warner <warner@lothar.com>
73 * buildbot/status/web/slaves.py (BuildSlavesResource.body): fix
74 timestamp, I was using %M (minutes) where I meant to be using
75 %b (abbreviated month name). Closes #109.
77 2007-10-13 Brian Warner <warner@lothar.com>
79 * README (COPYING): make it clear that buildbot is distributed under
81 * COPYING: add a copy of the GPLv2 to the source tree
82 * MANIFEST.in: .. and to the source distribution too
84 2007-10-10 Brian Warner <warner@lothar.com>
86 * buildbot/status/builder.py (Status.getURLForThing): update this
87 to match new URL layout, I completely forgot about it. Closes #112.
88 * buildbot/test/test_web.py (GetURL): add unit tests
90 * buildbot/status/web/build.py (BuildsResource.getChild): fix
91 silly typo which prevented the Build page from ever offering
92 control options like 'Stop Build'. Thanks to Aaron Hsieh for the
94 * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd
97 * buildbot/__init__.py (version): bump to 0.7.6+ while between
99 * docs/buildbot.texinfo: same
101 2007-09-30 Brian Warner <warner@lothar.com>
103 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
104 * docs/buildbot.texinfo: same
106 2007-09-30 Brian Warner <warner@lothar.com>
108 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
109 * setup.py: install all test files from buildbot/test/mail/* . Also
110 update URL to point at buildbot.net
111 * MANIFEST.in: update with new files
113 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
114 auto-create an empty public_html directory, otherwise we get
115 internal server errors instead of 404s.
117 * README: reference buildbot.net, remove CVSToys section (does
118 anyone still use it?)
120 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
121 message when public_html/ is missing (indicating that you should
122 probably run 'upgrade-master'), and don't auto-create an empty
123 directory in that case.
125 * contrib/darcs_buildbot.py: refactor internals a bit, make it
126 possible to use as an importable module (to make it easier to
127 write some unit tests for it)
129 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
130 DeprecationWarning for Waterfall, advising users to switch over to
133 * NEWS: update with user-visible changes since the last release
135 * buildbot/status/web/waterfall.py
136 (WaterfallStatusResource.get_reload_time): if the suggest a
137 reload time of less than 15 seconds, give them 15 seconds instead
138 of ignoring their request entirely, because that'd be confusing.
140 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
141 warning if we must invoke the last-change-is-most-recent guess
143 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
144 Waterfall is running in an upgraded master (which is the usual
145 case for folks who have followed the instructions to run
146 'upgrade-master' but who have not yet resolved all the
147 DeprecationWarnings), prefer the buildbot.css from public_html/
148 rather than the one passed in on the buildbot= argument.
149 Otherwise, the resulting pages don't quite use CSS right..
150 sometimes it works, sometimes it doesn't, and I don't know why.
151 Sites that are using custom CSS will see the default CSS until
152 they modify public_html/buildbot.css to include their
155 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
156 * buildbot/status/web/robots.txt (Disallow): update to cover all
157 dynamically-generated pages
159 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
160 include both 'trunk' and None in the output list, since some VC
161 systems (SVN, frequently) refer to trunk as 'trunk'.
163 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
164 point the 'welcome' link explicitly at index.html, rather than
165 '.', so that old Waterfall users can reach it and discover all the
168 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
169 build's text to the end of the line, without a CSS class so it
172 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
173 'max_search=' argument, to limit the number of builds that are
174 examined while trying to find ones that match the other criteria.
175 This helps to limit the work we do, since otherwise we might have
176 to trawl through all history.
177 (IBuilderStatus.generateFinishedBuilds): same
178 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
179 (BuilderStatus.generateFinishedBuilds): same
181 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
182 our got_revision before checking its length: SVN (at least) still
183 reports numeric values for this.
184 * buildbot/status/web/build.py (StatusResourceBuild.body): same
185 * buildbot/status/web/xmlrpc.py
186 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
187 serving a completely fake revision
189 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
190 basedir to sys.path, to mimic what a real buildmaster would have
191 access to, since it is common for master.cfg to import helper
192 classes from .py files in the buildmaster directory, and we want
193 config-file checking to accomodate this.
195 * buildbot/status/web/base.py (map_branches): when referring to
196 branches through WebStatus (i.e. by appending ?branch=FOO query
197 arguments to the URL), make "trunk" mean trunk, by mapping it to
198 None before passing it to generateFinishedBuilds() and the like.
199 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
200 (OneBoxPerBuilder.body): same, also improve display of branches in
202 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
203 (WaterfallStatusResource.buildGrid): same. Note that this filters
204 Changes as well as Builds.
205 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
206 caveat about trunk branches, now that it's fixed
208 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
209 from builder.py, use it on the Builder page too
211 * buildbot/status/web/builder.py (StatusResourceBuilder): same
212 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
213 names, add some CSS classes
214 * buildbot/status/web/classic.css (td.box): new class, for
217 * docs/buildbot.texinfo (WebStatus): update docs
219 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
220 the trailing "M" indicator that tells us this is a modified file.
221 This should help with mode="update" builds that modify files
222 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
225 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
226 new copies of files (to .new) when those files already exist,
227 check the master.cfg file for errors (and give DeprecationWarnings
228 a chance to be displayed).
229 * buildbot/test/test_runner.py: add more tests
230 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
232 2007-09-29 Brian Warner <warner@lothar.com>
234 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
235 the revision id from the last change in our list, since that's the
236 best we can do without knowing the full ancestry graph. Closes #103.
238 * buildbot/scripts/sample.cfg: use buildstep instances in
239 f.addStep, to demonstrate the (correct) modern usage.
240 * docs/examples/hello.cfg: bring this up to date. Closes #79.
241 * docs/examples/twisted_master.cfg: add a big warning about how
243 * docs/examples/glib_master.cfg: delete this one entirely, it is
244 ancient and not a very useful example anyways
246 * buildbot/status/web/base.py (HtmlResource.render): keep track of
247 HTTPChannels, so we can shut them down at reconfig time (when the
248 WebStatus goes away). Closes #102.
249 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
250 (WebStatus.registerChannel): same
251 (WebStatus.stopService): do .loseConnection() here
253 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
254 WebStatus, make sure all pages are still retrievable. I thought
255 this would exercise a bug, but it turns out that it was firefox
256 caching connections (and continuing to talk to the old WebStatus
257 even though I'd loaded a new one).
258 * buildbot/status/web/baseweb.py (WebStatus): add some comments
259 (WebStatus.__repr__): include id() in the repr
261 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
262 this to specify an errorparser. From Ted Mielczarek and the
263 mozilla crew. Closes #94.
265 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
266 bonsaipoller ignore funkyness in xml output for empy log
267 messages", from Axel Hecht. Closes #90.
268 * buildbot/test/test_bonsaipoller.py
269 (TestBonsaiPoller.testMergeEmptyLogMsg): same
271 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
272 respect 'builders' arg, from Ben Hearsum. Closes #89.
274 * buildbot/scripts/runner.py (stop): increase the timeout from 5
275 seconds to 10, to give heavily loaded machines a better chance to
276 finish shutting down. Addresses (partially) #68.
277 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
279 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
280 * buildbot/scripts/startup.py (Follower._failure): update message
282 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
283 team, to fix some bugs and avoid the use of blocking urlopen().
285 * buildbot/test/test_bonsaipoller.py: same
287 2007-09-28 Brian Warner <warner@lothar.com>
289 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
290 argument, to send email about buildslaves which are disconnected
291 for more than an hour. Closes #64.
292 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
294 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
295 (MailNotifier): add docs for this too
298 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
299 respect branch= queryargs, by restricting the builds displayed to
300 those matching the given branch names
301 * buildbot/status/web/waterfall.py (BuildTopBox): same
303 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
304 fix a test failure by adding .prepath to this fake object
306 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
307 up generation of relative URLs. With luck, this should play with
308 reverse proxies much better now.
309 * buildbot/test/test_webparts.py: new test for most of the subpages
310 * buildbot/test/test_web.py (base_config): add enough of a config
311 to exercise more Waterfall code
313 2007-09-27 Brian Warner <warner@lothar.com>
315 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
316 relative URL to the buildbot welcome page, rather than
318 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
320 * buildbot/status/web/base.py (HtmlResource.title): change the
321 default title of all Buildbot-generated page to "Buildbot"
322 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
323 change the title to include the Builder name
324 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
325 same, and also show the build number
326 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
327 redirect the browser to the Builder page
329 2007-09-26 Brian Warner <warner@lothar.com>
331 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
332 problem with the build links
334 2007-09-25 Brian Warner <warner@lothar.com>
336 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
337 to emit relative URLs instead of using URLPath,
339 * docs/buildbot.texinfo (WebStatus): provide an example
341 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
342 page, shows a simple table with one row per Builder. Still pretty
343 ugly, but functional.
344 * buildbot/status/web/index.html: reference it
346 * buildbot/status/web/waterfall.py (Spacer): make this *not*
347 inherit from builder.Event, so that show_events=false doesn't hide
348 spacers, since that would make the waterfall weirdly compressed.
350 * buildbot/status/web/waterfall.py (HELP): put the View button in
351 its own section, so it doesn't get visually confused with the
353 (WaterfallStatusResource.body): make the '[help]' links more
354 visually distinct from each other, and add a link to the Welcome
356 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
357 unused buildslaves without exploding
359 * buildbot/status/web/waterfall.py
360 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
361 it gives us absolute paths that break proxies
362 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
363 this, it was giving bad results when the Waterfall is behind a
366 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
367 new 'upgrade-master' command, which will bring an old buildmaster
368 directory up-to-date. Right now the only thing it does is populate
369 public_html/ if it wasn't already there. Still to do: check the
370 other files, add documentation.
371 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
372 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
374 2007-08-13 Brian Warner <warner@lothar.com>
376 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
377 that contains the checkin comments when you hover over the entry
378 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
381 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
384 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
385 page with versions of python, buildbot, and twisted
386 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
387 * buildbot/status/web/index.html: add links to most pages
388 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
390 * buildbot/status/web/robots.txt: put a robots.txt in new installs
391 which discourages robot access to all large dynamically-generated
392 pages. The intention is that the index page and the 'about' page
393 are the only ones which should be crawlable.
394 * buildbot/scripts/runner.py (Maker.public_html): same
396 * setup.py: ship index.html and robots.txt in source distributions
398 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
399 activate automatic reloading of the page (using a meta Refresh:
401 (WaterfallHelp): new page to explain all the nifty query arguments
402 you can use on the Waterfall, along with forms to set them for
403 you. From this page, you can add filters for builder=, branch=,
404 show_events=, as well as turning on reload=.
405 (WaterfallStatusResource.buildGrid): new query args: last_time=,
406 first_time=, show_time=, num_events= . The old show= is still
407 accepted, but the new builder= is preferred. We ignore empty
408 branch= arguments, to make the WaterfallHelp form easier to
410 (WaterfallStatusResource.head): new method to add text to the
412 * buildbot/status/web/base.py (HtmlResource.content): use head()
413 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
414 empty branch= arguments
415 (OneLinePerBuildOneBuilder.body): same
417 2007-08-12 Brian Warner <warner@lothar.com>
419 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
420 new query args: 'last_time' is a timestamp of the top-most event
421 on the display, 'first_time' is a timestamp for the bottom-most
422 event. 'show_time' is the difference between them, and overrides
423 'first_time'. 'num_events' puts an upper limit on the number of
424 timestamps that will be displayed on the left hand edge.
425 (WaterfallStatusResource.body): add a 'next page' link to the
426 bottom, which shows the events that come just after those shown on
427 the current page. This is a first step towards #67, but we need
428 some more controls before we can close that one.
430 * buildbot/buildslave.py (BuildSlave): these are now MultiService
431 instances too, and live as children of the BotMaster. The main
432 advantage of this approach is that BuildSlaves can know when they
433 are being removed (so they can shut off the upcoming
434 when-do-we-email-an-admin-because-we-lost-our-slave timer).
435 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
436 identify which service children are BuildSlaves
437 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
438 Checker updates here, but delegate the rest to..
439 (BotMaster.loadConfig_Slaves): .. here, which looks at the
440 BotMaster's service children to identify the old slaves. I think
441 the previous approach of using master.slaves was broken in the
442 face of config updates that modified BuildSlave instances but did
443 not completely replace them.
444 * docs/buildbot.texinfo (Developer's Appendix): note the change to
445 the Service hierarchy
447 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
448 page (at URL /buildslaves/) to view status of all buildslaves at
449 once, including how long it's been since we last heard from them,
450 and which Builders use them.
452 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
455 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
458 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
459 use the BuildSlave to keep track of the last time we've heard from
460 the buildslave. This is updated upon receipt of any message from
461 any SlaveBuilder (which generally means when RemoteCommands are
462 giving us status updates, as BuildSteps run). In the future this
463 will include slave pings too.
464 * buildbot/process/base.py
465 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
466 * buildbot/process/buildstep.py:
467 (BuildStep.setBuildSlave): accept that reference
468 (BuildStep.runCommand): pass the reference on to the RemoteCommand
469 (RemoteCommand.remote_update): update the timestamp
470 (RemoteCommand.remote_complete): same
471 * buildbot/test/runutils.py (StepTester.makeStep): match the change
472 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
473 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
474 interface to retrieve this timestamp
475 * buildbot/status/builder.py (SlaveStatus): track a copy of the
479 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
481 (OneLinePerBuild.body): use a <ul> instead of <div>s
482 (OneLinePerBuildOneBuilder.body): same
484 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
485 by adding the file's new name to the list of changed files. This
486 ought to be sufficient for things like isFileImportant and trial
487 tests that only exercise tests for files that have been modified.
490 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
491 XMLRPC server to the WebStatus page. This only has two methods
492 right now (getAllBuildsInInterval and getBuild), but we'll be
493 adding more in the future. This server is extracted from the
496 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
497 generateFinishedBuilds, and improve the data displayed.
498 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
499 the per-Build page, add some information like ETA and got_revision
500 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
501 adding a list of recently completed builds
502 * buildbot/status/web/base.py (css_classes): factor this out
504 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
505 new method, to make status display classes easier to write,
506 especially the WebStatus 'one_line_per_build' page.
507 (IBuilderStatus.generateFinishedBuilds): same
508 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
509 (Status.generateFinishedBuilds): implement it
511 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
512 'source' to be a BuildStep instance, since BuildFactory accepts
514 (CPAN.__init__): same
515 (Distutils.__init__): same
516 (Trial.__init__): same
518 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
519 this might raise KeyError
521 2007-08-07 Brian Warner <warner@lothar.com>
523 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
524 'Owner:' field of the view, rather than 'p4logname', since
525 p4logname comes from the buildslave's environment and seems
526 unlikely to ever do the right thing. Thanks to Wade Brainerd for
527 the patch. Closes #40.
529 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
530 which imposes a per-slave limit on how many builds are allowed to
531 run simultaneously. This has a the same scope than the SlaveLock,
532 but is different because max_builds= gives the buildmaster the
533 freedom to assign the build to a different slave, whereas the
534 SlaveLock doesn't get tested until after the build is irrevocably
535 assigned to a slave. Therefore using max_builds= will improve
536 utilization in the presence of multiple buildslaves that are
537 attached to the same Builder. This completes the incorporation of
538 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
539 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
540 any Builder finishes, potentially trigger *all* Builders, since
541 max_builds= may have stalled someone else while waiting for the
543 * buildbot/scripts/sample.cfg: mention max_builds=
544 * buildbot/test/test_run.py (ConcurrencyLimit): test it
545 * docs/buildbot.texinfo (Buildslave Specifiers): document it
547 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
548 inherit from RunMixin do not need to call master.stopService()
549 themselves, since RunMixin.tearDown does that. The double call
550 fails on Twisted-2.0.x, which didn't happen to protect against it.
551 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
553 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
554 from #48, this one to have the BuildSlave objects track
555 SlaveBuilders, so they'll be able to use that knowledge to
556 influence their canStartBuild() response.
557 * buildbot/process/builder.py (SlaveBuilder.attached): call it
558 (SlaveBuilder.detached): same
559 * buildbot/test/test_slaves.py (BuildSlave): test it
561 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
562 the second of Dustin's #48 patches, this one adding a method to
563 the BuildSlave that allows it to decide whether it is willing to
564 participate in a build or not.
565 (SlaveBuilder.isAvailable): use canStartBuild() to decide
567 * buildbot/test/test_run.py (CanStartBuild): test for it
569 * all: incorporate the first of four patches by Dustin Mitchell
570 from ticket #48, working towards improving control over slave
571 concurrency. The first patch is to use a long-lived BuildSlave
572 object per slave, on which other behavior can be added later. I've
573 modified his patch considerably.
574 * buildbot/buildslave.py (BuildSlave): move class out of
575 slave/__init__.py (where it would get loaded by the slave as well
576 as the master, making dependencies trickier), and merge it with
577 BotPerspective. Now these BuildSlave instances are created once in
578 the master.cfg file, and not destroyed until they are either
579 removed from the config file or changed so
580 much (name/password/class changes) that we cannot continue to use
581 the old one. This affects config files: they must use
582 'from buildbot.buildslave import BuildSlave' instead of using
583 'from buildbot.slave import BuildSlave'.
584 * buildbot/master.py: move BotPerspective out
585 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
586 add or remove as necessary, update the rest using data from
588 * buildbot/slave/__init__.py: move BuildSlave out
589 * buildbot/test/test*.py: import BuildSlave from the new place
590 * buildbot/scripts/sample.cfg: update to match
591 * docs/buildbot.texinfo: update to match
592 * buildbot/process/builder.py: update comments to match
594 2007-08-02 Brian Warner <warner@lothar.com>
596 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
597 one-line-per-build pages a bit, add a header, refactor slightly
599 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
600 the TimeOutError timer, patch by Dustin Mitchell.
602 2007-08-01 Brian Warner <warner@lothar.com>
604 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
605 mostly work (branch= is still ignored, we need a useful header)
606 (OneLinePerBuildOneBuilder.body): this too
608 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
609 bring this up-to-date w.r.t. recent refactorings, and fix
610 redirections to bounce the browser to the top page after hitting
611 the 'force' button. This needs to be improved, but at least it now
612 redirects to a valid page.
613 (StatusResourceBuilder.ping): same
614 (StatusResourceBuilder.getChild): same, although I think this code
615 might be dead anyways
617 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
618 a branch= query argument, to filter the display down to builds and
619 changes that involve the given branch. You can add multiple
620 branch= arguments to see multiple branches (using a logical OR).
621 Note that there is no way to include the default branch (i.e.
622 None, i.e. trunk) yet, there is still work to be done to allow for
623 simple+uniform names of branches (i.e. removing the VC-specific
624 details of how branches are implemented, so calling the branch
625 'beta4' even though the SVN checkout step requires
627 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
628 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
629 * buildbot/interfaces.py (IEventSource.eventGenerator): same
630 * docs/buildbot.texinfo (Buildbot Web Resources): document it
632 * all: bring import statements up-to-date: don't import
633 __future__, assume cPickle and cStringIO are always available.
634 Also remove #!/usr/bin/python lines from non-scripts, my editor
635 has been a bit over-enthusiastic about stuffing them into new .py
638 * buildbot/status/web/index.html: put a link to the waterfall page
639 on the index, otherwise first-time users of WebStatus aren't going
640 to see anything very interesting.
642 * buildbot/interfaces.py (IEventSource): document this interface.
643 Thanks to Dustin Mitchell for the patch. Closes #60.
644 * buildbot/status/builder.py (BuilderStatus): same
645 * buildbot/changes/changes.py (ChangeMaster): same
647 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
648 add a query arg of 'show_events=true' to display non-build events,
649 like slaves attaching/detaching and reconfig events, or
650 'show_events=false' to hide them. The default is 'true'.
651 * docs/buildbot.texinfo (Buildbot Web Resources): document it
653 * web-parts: merge in web-parts branch. Lots of changes. The new
654 functionality is to add buildbot.status.html.WebStatus, which is a
655 superset of the Waterfall that adds new status pages and serves
656 regular files from BASEDIR/public_html/ , which is now the preferred
657 place to put robots.txt, buildbot.css, and index.html .
658 * buildbot/scripts/runner.py: the 'create-master' command now
659 creates public_html/ too, and populates it with a couple of
661 * buildbot/status/web: split waterfall code into smaller pieces
663 2007-07-31 Brian Warner <warner@lothar.com>
665 * buildbot/scripts/startup.py (launch): import twistd.run in a
666 different way to hush pyflakes
667 * buildbot/process/builder.py: remove unused import
669 2007-07-30 Brian Warner <warner@lothar.com>
671 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
672 Mitchell: pass SourceStamps around rather than branch/version/etc
673 tuples. Thanks Dustin! Closes #70.
674 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
675 tuple rather than a list, to avoid surprising mutations
676 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
677 * buildbot/status/mail.py (MailNotifier.buildMessage): same
678 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
679 * buildbot/test/test_status.py (Subscription): same
680 * buildbot/test/test_control.py (Force): same
681 * buildbot/test/test_buildreq.py (Request.testMerge): same
683 2007-07-29 Brian Warner <warner@lothar.com>
685 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
686 variable, since it wasn't used and is confusing in the presence of
687 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
690 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
691 the Buildbot home-page link to point at buildbot.net instead of
692 sourceforge, and add a current-version query parameter so we can
693 get some statistics on which versions are in use out there.
695 2007-07-28 Brian Warner <warner@lothar.com>
697 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
698 with c['change_source'], leaving c['sources'] for backwards
699 compatibility (but deprecated), scheduled for removal in 0.8.0
700 * docs/buildbot.texinfo: same
701 * buildbot/test/test_config.py: verify that c['sources'] still works
702 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
703 * buildbot/scripts/sample.cfg: update to match
705 * buildbot/changes/mail.py (MaildirSource): parse with python's
706 stdlib 'email' module, which has been available since python2.2,
707 and drop use of the 'rfc822' module, which has been depreceated
709 * buildbot/test/test_maildir.py: same: use parse_file() not parse
711 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
712 this needs to match the renaming in test/mail/msg*
714 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
717 * buildbot/test/test_mailparse.py: rename sample emails a bit
718 * buildbot/test/mail/msg*: same
720 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
721 parser for the "commit-email.pl" script that is shipped with SVN,
722 written by Justin Mason. Thanks! Closes SF#1072845.
723 * buildbot/test/mail/svn-commit.*: sample messages
724 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
725 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
727 2007-07-27 Brian Warner <warner@lothar.com>
729 * buildbot/changes/mail.py: refactor: move parsing into a method
730 named 'parse', each parser type gets a separate subclass. Remove
731 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
732 to be a simple leading-substring match. Add a warning to the logs
733 if prefix= does not end in a slash, since that's probably a
734 mistake. Fix both places where a prefix= mismatch would skip all
735 subsequent files in the same email, instead of just skipping the
736 one that didn't match.
737 * buildbot/test/test_mailparse.py: match changes
739 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
740 docs on email-based ChangeSources
742 * docs/buildbot.texinfo (Getting Source Code Changes): move all
743 the changesource types up a level, removing the one-entry menu in
746 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
747 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
748 instances instead of tuples. Closes #63.
749 * buildbot/slave/__init__.py (BuildSlave): define marker class
750 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
751 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
752 * buildbot/test/test_*.py: update tests to match
753 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
754 the c['bots'] backwards-compatibility handler works
756 2007-07-26 Brian Warner <warner@lothar.com>
758 * buildbot/changes/hgbuildbot.py (hook): add an in-process
759 Mercurial change-sending hook, contributed by Frederic Leroy.
760 Thanks! Addresses #50.
761 * docs/buildbot.texinfo (MercurialHook): document it
763 * buildbot/changes/hgbuildbot.py: change the way imports are done,
764 to make it compatible with at least hg-0.9.1 and the current 0.9.4
766 2007-07-17 Brian Warner <warner@lothar.com>
768 * buildbot/process/buildstep.py (BuildStep.getLog): add a
769 convenience method to retrieve a log added with
770 addLog()/addCompleteLog()/etc or logfiles= . I should have added
773 2007-07-03 Brian Warner <warner@lothar.com>
775 * buildbot/slave/commands.py (ShellCommand._startCommand): when
776 logging the environment variables, put one variable on each line,
777 rather than having one really long line with all of them. This
778 should make them a bit more readable and not trigger the
779 horizontal scrollbar (when viewing it in a web browser) quite so
780 much. Thanks to Albert Hofkamp for the patch.
782 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
783 WithProperties instance. Thanks to Axel Hecht for the patch.
785 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
786 * docs/buildbot.texinfo (Build Properties): document it
787 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
788 workdir if it didn't already exist.
790 * docs/buildbot.texinfo (Scheduler Types): correct the description
791 of Dependent schedulers. Thanks to Greg Ward for the patch.
793 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
794 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
795 the patch. Closes #49.
797 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
798 0700 before removing it, to deal with situations where a build will
799 leave files around without write permissions and the 'copy' or
800 'clobber' VC checkout modes need to blow away the tree first.
801 Thanks to Steve Milner for the suggestion and the patch (which I
802 mangled horribly). Closes #29.
803 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
806 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
807 an allowReconnect= argument to let callers control whether they
808 want this don't-let-it-reconnect behavior, since some tests care.
809 Factor out the .continueTrying=False lines from those callers.
810 * buildbot/test/test_slaves.py: same
811 * buildbot/test/test_run.py: same
813 2007-07-02 Brian Warner <warner@lothar.com>
815 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
816 slave has been disappeared, don't let it reconnect. This was
817 causing an intermittent failure in test_slaves.py, when the slave
818 that was supposed to be gone managed to come back by the end of
819 the test and affect the count.
820 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
822 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
823 diagnostic messages to track down this problem
824 (Builder.startBuild): same
826 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
827 the slave randomly rather than always taking the first one. Thanks
828 to Pike for the patch. Closes #36.
829 * buildbot/test/test_slaves.py: match the change. to avoid huge
830 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
831 enables/disables the round-robin-ness (enabled by default), and
832 some unit tests disable it.
833 * docs/buildbot.texinfo (Buildmaster Architecture): document it
835 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
836 argument to 'buildmaster_host', to make it more obvious that this
837 points to the buildmaster. Thanks to Bob Proulx for the
839 * buildbot/scripts/runner.py (slaveTAC): same
840 * buildbot/test/test_runner.py (Create.testSlave): match the change
842 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
845 2007-06-17 Brian Warner <warner@lothar.com>
847 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
848 we can round-trip all of our current step classes by calling
849 getStepFactory() and using the results to make a clone of the
852 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
855 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
856 the config file, we're moving to using actual instances instead of
857 the (class, kwargs) 'step specification' tuples. BuildFactory
858 still keeps a list of tuples internally, but when real instances
859 are passed in to addStep(), they are asked for their class and
860 kwargs using the new BuildStep.getStepFactory method. BuildFactory
861 accepts both instances and the tuple form, and converts instances
862 to the tuple form, but the instance form is preferred because it
863 gives the Steps a chance to do argument validation. Closes: #11.
865 * buildbot/process/buildstep.py (BuildStep.__init__): record the
866 factory information necessary to implement getStepFactory. The
867 addFactoryArguments() method can be used to include arguments that
868 aren't passed to the BuildStep base class constructor.
869 (BuildStep.setBuild):
870 (BuildStep.setDefaultWorkdir): new methods to take parameters that
871 are needed for live BuildSteps but not to construct the specification
872 tuples that are stashed in the factory.
874 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
875 'workdir' into new BuildSteps by using methods instead of
876 arguments. This makes the constructor for BuildSteps a lot
879 * buildbot/steps/*.py: update to match this change. Basically this
880 means adding calls to addFactoryArguments() in the __init__
881 methods to capture the arguments that aren't passed through to the
883 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
884 the new workdir (if any) into the RemoteShellCommands arguments.
885 * buildbot/steps/source.py: allow workdir= to be optional,
886 implement setDefaultWorkdir() since we don't inherit from
887 (CVS): finally remove old clobber=/export=/copydir= arguments,
888 in favor of the mode= argument that's been around forever now.
889 * buildbot/steps/transfer.py: remove build= argument
891 * buildbot/test/*.py: update to match, generally by turning all
892 build= arguments into subsequent calls to s.setBuild()
893 * buildbot/test/test_config.py (Factories): verify that we can
894 use either BuildStep instances or class/kwarg tuples in both
895 BuildFactory.addStep and BuildFactory.__init__
897 * docs/buildbot.texinfo (Build Steps): document the new approach,
898 mention compatibility with the old approach, update all examples
899 to use the new style.
901 2007-06-16 Brian Warner <warner@lothar.com>
903 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
904 the LoopingCall, just eat the failure so that we'll poll again
905 next time. This should allow us to tolerate (e.g.) sf.net SVN
906 failures more gracefully. Many thanks to Dustin Mitchell for the
909 2007-05-17 Brian Warner <warner@lothar.com>
911 * buildbot/status/words.py: refactor the IRC status bot into
912 separate 'Contact' and 'Channel' classes. The base Contact class
913 contains the interaction code: commands and responses. The
914 IRCContact subclass (and IrcStatusBot 'Channel') handle the
915 IRC-specific aspects. The plan is to write other subclasses for
916 other IM protocols like AIM and Jabber.
918 2007-04-16 Brian Warner <warner@lothar.com>
920 * CREDITS: update list of contributors. Thank you all!
922 2007-04-13 Brian Warner <warner@lothar.com>
924 * buildbot/status/mail.py (MailNotifier): add the project name to
925 the subject line and message body, to make it easier to
926 distinguish email coming from different buildmasters. Thanks to
927 Benoit Sigoure for the patch.
928 * buildbot/test/test_status.py (Mail): update to match
930 2007-03-24 Brian Warner <warner@lothar.com>
932 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
933 avoid text-conversion problems between DOS/windows and unix.
934 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
936 2007-03-03 Brian Warner <warner@lothar.com>
938 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
939 warning about the use of Waterfall here
941 2007-03-01 Brian Warner <warner@lothar.com>
943 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
945 2007-02-28 Brian Warner <warner@lothar.com>
947 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
948 Lamb to use a more optimal form of 'p4 changes', to reduce server
949 load. He reports that this optimization was added to p4d release
950 2005.2, but it should work in all versions. Closes #27.
951 * buildbot/test/test_p4poller.py: match it
953 2007-02-27 Brian Warner <warner@lothar.com>
955 * buildbot/status/web/*.py: move all web status stuff into a
956 separate directory, in anticipation of splitting it into smaller
957 pieces and adding more files. html.py was getting way too big.
958 * buildbot/status/classic.css: move it too
959 * setup.py: add the new sub-package
960 * buildbot/test/test_web.py: match the changes
961 * MANIFEST.in: handle the move of classic.css
963 2007-02-07 Brian Warner <warner@lothar.com>
965 * contrib/OS-X/*: add some launchd .plist files for automatically
966 starting a buildmaster or buildslave under OS-X (10.4 or later).
967 Thanks to Mark Pauley for these.
969 2007-02-06 Brian Warner <warner@lothar.com>
971 * docs/buildbot.texinfo (Requirements): update requirements to
972 stop claiming compatibility with python-2.2 or twisted-1.3.x .
974 * README: mention python-2.5 and twisted-2.5 compatibility
976 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
978 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
980 * buildbot/status/builder.py: same, by requiring cStringIO
981 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
982 * buildbot/test/test_vc.py: same
983 * buildbot/test/test_web.py:
984 * buildbot/test/test_steps.py: same, remove unused import
986 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
989 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
990 see any Builders that don't have Schedulers to drive them
992 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
993 attributes this uses went away
995 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
996 dialog, to allow you to reset the buildmaster and force
997 connect/disconnect. Correctly handle losing the buildmaster
998 connection (by switching the display to the hexnut, at which point
999 you can use the 'Connect' menu item to reconnect).
1001 * buildbot/steps/source.py (Source.start): if we're using a patch,
1002 add it as a LogFile to the checkout/update step. This will turn
1003 into a link on the waterfall page.
1005 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
1006 option, to take the patch from a pre-made file rather than
1007 generating it from the local tree. Thanks to Robert Helmer for the
1008 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
1009 * buildbot/scripts/runner.py (TryOptions): add --diff,
1010 --patchlevel, and --baserev options
1011 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
1012 as None, meaning HEAD.
1013 * buildbot/sourcestamp.py (SourceStamp): update docstring to
1014 indicate that baserev=None means HEAD
1015 * docs/buildbot.texinfo (try --diff): document it
1017 * buildbot/test/test_steps.py (BuildStep): remove use of
1018 reactor.iterate(), although the technique I replaced it with is a
1019 gross polling hack that must be cleaned up properly some day. This
1020 was the last use of reactor.iterate in the entire tree, yay.
1022 2007-02-05 Brian Warner <warner@lothar.com>
1024 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
1025 is one of the three known values, otherwise we emit some confusing
1026 messages later on. Thanks to Grig Gheorghiu for the catch.
1028 2007-01-30 Brian Warner <warner@lothar.com>
1030 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
1031 Hearsum contributed a patch to let BonsaiPoller work with results
1032 that contain non-ascii characters. Closes SF#1632641.
1034 2007-01-27 Brian Warner <warner@lothar.com>
1036 * Makefile (release): produce both .tar.gz and .zip source bundles.
1039 2007-01-23 Brian Warner <warner@lothar.com>
1041 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
1042 * buildbot/changes/monotone.py: same
1044 * buildbot/changes/maildir.py: combine several files into one,
1045 clean up maildir.py to use Services properly.
1046 * buildbot/changes/maildirtwisted.py: remove
1047 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
1049 * buildbot/changes/mail.py: match the change
1050 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
1051 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
1053 * buildbot/slave/commands.py (command_version): bump to "2.3" to
1054 indicate that the buildslave knows about the 'bzr' command
1056 2007-01-22 Brian Warner <warner@lothar.com>
1058 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
1059 'with', it will become a reserved work in python2.6 .
1061 * contrib/bb_applet.py: add a simple gnome-panel applet, to
1062 display a terse summary of buildbot status.
1063 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
1064 some icons, small versions of the Blender object that lives in
1065 docs/images/icon.blend
1067 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
1068 * buildbot/slave/commands.py (Bzr): same
1069 * buildbot/scripts/tryclient.py (BzrExtractor): same
1070 (SourceStampExtractor.dovc): modify this to allow non-zero exit
1071 status, since 'bzr diff' does that
1072 * buildbot/test/test_vc.py (Bzr): same
1073 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1077 2007-01-20 Brian Warner <warner@lothar.com>
1079 * contrib/darcs_buildbot.py: tidy up the progress messages
1081 2007-01-17 Brian Warner <warner@lothar.com>
1083 * contrib/darcs_buildbot.py: enhance to handle multiple patches
1084 being pushed at a time. This keeps state in the repository in a
1085 small file named .darcs_buildbot-lastchange, but that shouldn't
1086 interfere with normal repository operations. Fixes SF#1534049.
1087 * buildbot/clients/sendchange.py (Sender): make a single Sender
1088 capable of sending Changes with different usernames.
1090 2006-12-11 Brian Warner <warner@lothar.com>
1092 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
1093 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
1094 buildbot.changes.mail a long time ago, but I forgot to add the
1095 DeprecationWarning until now.
1097 * buildbot/process/maxq.py: remove this, the functionality now
1098 lives in buildbot.steps.maxq
1100 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1101 * buildbot/clients/gtkPanes.py: remove unused import
1103 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1104 that was meant to provide a special Reporter to run inside trial
1105 and give the buildslave lots of machine-readable status. We never
1106 finished this project.
1108 * buildbot/changes/bonsaipoller.py: remove unused imports
1109 * buildbot/changes/svnpoller.py: same
1110 * buildbot/process/builder.py: same
1111 * buildbot/process/buildstep.py: same
1112 * buildbot/slave/bot.py: hush pyflakes warning
1113 * buildbot/status/tests.py: remove unused imports
1114 * buildbot/status/tinderbox.py: same
1115 * buildbot/steps/python_twisted.py: same
1117 * buildbot/process/step.py: remove this file, these names were
1118 deprecated in 0.7.5 and are now being removed.
1119 * buildbot/process/step_twisted.py: same
1120 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1122 * buildbot/twcompat.py: remove the empty file, yay it is gone
1124 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1125 tw-2.0.0 and newer have the method we need.
1126 (getProcessOutputAndValue): same
1127 (which): remove this method, tw-2.0.0 t.p.procutils has it
1129 * buildbot/twcompat.py (implements): remove this method
1130 * buildbot/*: import implements() from zope.interface directly
1132 * buildbot/status/mail.py: stop falling back to importing
1133 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1136 * buildbot/twcompat.py (Interface): remove this import
1137 * buildbot/*: import Interface from zope.interface directly
1139 * buildbot/twcompat.py (providedBy): remove this method
1140 * buildbot/*: turn all uses of providedBy(obj, iface) into
1141 iface.providedBy(obj)
1143 * buildbot/twcompat.py (maybeWait): remove this method, now that
1144 we no longer maintain compatibility with Twisted<=1.3.0 .
1145 Twisted-2.0.0 and later allow trial methods to return Deferreds
1147 * buildbot/test/*: remove all uses of maybeWait
1149 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1151 * docs/buildbot.texinfo: same
1153 2006-12-10 Brian Warner <warner@lothar.com>
1155 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1156 * docs/buildbot.texinfo: set version to match
1158 2006-12-10 Brian Warner <warner@lothar.com>
1160 * README (REQUIREMENTS): update for release
1161 * NEWS: update for release
1162 * buildbot/slave/commands.py (command_version): mention that this
1163 version (2.2) was released with buildbot-0.7.5
1165 * buildbot/test/test_config.py (StartService.testStartService):
1166 inhibit the usual read-config-on-startup behavior, since otherwise
1167 the log.err that gets recorded causes the test to fail
1169 * buildbot/status/builder.py (LogFile.finish): forget about all
1170 subscribers once the log has finished, since after that point
1171 we're never going to use them again. This might help free up some
1174 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1175 than the old/deprecated gtk.mainquit()
1177 2006-12-09 Brian Warner <warner@lothar.com>
1179 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1180 better when we can't open the masterdst file
1182 * buildbot/scripts/startup.py (Follower._failure): add missing
1183 import statement for BuildSlaveDetectedError
1185 * buildbot/steps/transfer.py (FileUpload): cleanup
1186 (FileDownload): same. Add tests for slave version, add mode=.
1187 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1188 (SlaveFileDownloadCommand): same
1189 * buildbot/test/test_transfer.py: enhance tests
1190 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1193 2006-12-08 Brian Warner <warner@lothar.com>
1195 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1196 both success *and* failure. Without this, the 'buildbot
1197 sendchange' command would hang if it could not contact the
1198 buildmaster or deliver the Change, which would generally cause the
1199 user's commit/record/checkin command to hang too. Thanks to
1200 Christian Unger for the catch.
1202 2006-12-06 Brian Warner <warner@lothar.com>
1204 * NEWS: update with items for the next release
1206 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1207 whimsical example pulled from a punch-drunk email I sent out late
1209 (Transferring Files): document some of the other parameters
1210 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1211 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1212 * buildbot/test/test_svnpoller.py: same
1213 * buildbot/changes/svnpoller.py (SVNPoller): same
1215 2006-11-26 Brian Warner <warner@lothar.com>
1217 * docs/buildbot.texinfo (Build Properties): remind users that
1218 WithProperties must appear in a command= list, not as a top-level
1220 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1221 we're sending a list or a single string to the RemoteShellCommand
1223 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1225 * buildbot/scripts/startup.py (start): skip the whole
1226 watch-the-logfile thing under windows, since it needs os.fork()
1228 * buildbot/scripts/runner.py (restart): remove the old message
1229 that got printed after the buildbot was restarted.. it most cases
1230 it didn't get printed at the right time anyways
1232 2006-11-25 Brian Warner <warner@lothar.com>
1234 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1235 follow twistd.log and print lines until the process has started
1236 started properly. For the buildmaster, this means until the config
1237 file has been parsed and accepted. For the buildslave, this means
1238 until we've connected to the master. We give up after 5 seconds in
1239 any case. Helpful error messages and troubleshooting suggestions
1240 are printed when we don't see a successful startup. This closes the
1241 remainder of SF#1517975.
1242 * buildbot/scripts/startup.py: moved app startup code to here
1243 * buildbot/scripts/logwatcher.py: utility class to follow log
1244 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1245 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1246 so the LogWatcher can tell the difference between a buildmaster
1249 2006-11-24 Brian Warner <warner@lothar.com>
1251 * docs/examples/twisted_master.cfg: update to match the version
1252 in use on twistedmatrix.com
1253 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1254 was using before stopped working, but 'irc.freenode.net' works
1257 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1260 * buildbot/clients/base.py (TextClient.not_connected): upon
1261 UnauthorizedLogin failures, remind the user to connect to the
1262 PBListener port instead of the slaveport.
1263 (TextClient.disconnected): shut down more quietly
1264 * docs/buildbot.texinfo (statuslog): add another reminder
1266 * buildbot/scripts/runner.py (Options.subCommands): rename
1267 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1268 'sighup' as an alias.
1269 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1270 reconfig command to follow twistd.log and print all of the lines
1271 from the start of the config-file reload to its completion. This
1272 should make it a lot easier to discover bugs in the config file.
1273 Use --quiet to disable this behavior. This addresses half of
1274 SF#1517975, the other half will be to add this same utility to
1275 'buildbot start' and 'buildbot restart'.
1276 * docs/buildbot.texinfo (Loading the Config File): same
1279 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1280 method, it has been deprecated for a long time. Use
1281 IBuilderControl.requestBuild instead.
1282 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1283 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1284 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1285 * buildbot/test/test_control.py (Force.testForce): same
1286 * buildbot/test/test_run.py: use requestBuild instead
1288 * buildbot/clients/debug.py: replace 'Force Build' button with
1289 'Request Build' (which just adds one to the queue), add Ping
1290 Builder, add branch/revision fields to Request Build.
1291 * buildbot/clients/debug.glade: same
1292 * buildbot/master.py: update interface to match. This creates an
1293 incompatibility between new debugclients and old buildmasters.
1295 * buildbot/process/builder.py (Builder._attached): delay the call
1296 to maybeStartBuild for a reactor turn, to avoid starting a build
1297 in the middle of a reconfig (say, if the new Builder uses a new
1298 slave which is already connected).
1300 2006-11-23 Brian Warner <warner@lothar.com>
1302 * buildbot/test/test_transfer.py: appease pyflakes
1303 * buildbot/test/test_steps.py: same
1305 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1306 keeps pyflakes from finding undefined names
1308 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1309 Builder no longer induces a disconnect/reconnect cycle. This means
1310 that any builds currently in progress will not be interrupted, and
1311 any builds which are queued in the Builder will not be lost. This
1312 is implemented by having the new Builder extract the state (i.e.
1313 all pending Builds and any desired SlaveBuilders) from the old
1315 (BotPerspective): refactor. The BotPerspective no longer keeps
1316 track of all the Builders that want to use this slave; instead, it
1317 asks the BotMaster each time it needs this list. This removes
1318 addBuilder and removeBuilder. Clean up attached() to acquire all
1319 the slave's information in a more atomic fashion. updateSlave() is
1320 now the way to make sure the slave is using the right set of
1321 Builders: just call it after everything else has been
1323 (BotMaster): refactor, removing addBuilder/removeBuilder and
1324 replacing them with an all-at-once setBuilders() call.
1326 * buildbot/test/test_slaves.py (Reconfig): new test case to
1327 exercise this functionality
1328 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1329 * buildbot/slave/commands.py (WaitCommand): same
1331 * docs/buildbot.texinfo (Loading the Config File): document the
1334 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1335 SlaveBuilder to have its parent Builder changed.
1336 (SlaveBuilder.isAvailable): new method to give access to state,
1337 which is now a private attribute
1338 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1339 the SlaveBuilder about how it is being used. These methods update
1340 its internal state. buildFinished() is now the place that invokes
1341 maybeStartBuild() on its parent Builder.
1342 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1343 new Builder to take over for an old one, transferring state from
1345 (Buider): refactor the way that SlaveBuilders are used to match,
1346 giving them a bit more autonomy.
1347 (Builder.buildFinished): this no longer calls maybeStartBuild():
1348 instead the SlaveBuilder calls it on whoever its parent Builder is
1349 at the time. This way, when an old Builder is replaced by a new
1350 one, and there was a build in progress during the transition, when
1351 that build finishes, it will be the new Builder that is told about
1352 the newly available slave so it can start a new build.
1354 * buildbot/process/base.py (Build.startBuild._release_slave): when
1355 the Build finishes, tell the SlaveBuilder that they've been
1358 * buildbot/status/builder.py (SlaveStatus): add some new setter
1359 methods for use by BotPerspective, to keep some attributes more
1362 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1363 called by the buildmaster.
1364 (Bot.setBuilderList): instead, we locally announce any leftover
1365 directories based upon which Builders we were told about. The
1366 master doesn't really care; it's the local admin who may or may not
1367 wish to delete them.
1370 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1371 to allow use of python2.4 or whatever. This tool still requires
1374 2006-11-19 Brian Warner <warner@lothar.com>
1376 * NEWS (IStatusLog.readlines): more news items
1378 2006-11-18 Brian Warner <warner@lothar.com>
1380 * NEWS: start collecting items for the next release.
1382 2006-11-04 Brian Warner <warner@lothar.com>
1384 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1385 Hearsum. Closes SF#1590310.
1386 * buildbot/test/test_bonsaipoller.py: and tests
1388 * buildbot/status/tinderbox.py
1389 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1390 status when the build results in WARNINGS. Patch from Dave
1391 Liebreich. Closes SF#1587352.
1393 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1394 linux-vs-osx behavior difference w.r.t. reading from files that
1395 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1396 to Mark Rowe for the patch.
1398 2006-10-15 Brian Warner <warner@lothar.com>
1400 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1401 method name was misspelled in the interface definition. Thanks to
1402 Roy Rapoport for the catch.
1404 2006-10-13 Brian Warner <warner@lothar.com>
1406 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1407 to match the great Steps renaming
1409 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1410 Maybe I should run my own unit tests before recording a big
1411 change. Good thing I've got a buildbot to remind me.
1413 2006-10-12 Brian Warner <warner@lothar.com>
1415 * buildbot/steps/transfer.py: rework __init__ and args setup
1416 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1418 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1419 when opening the target file, only catch IOError (to report via
1420 stderr/rc!=0), let the others be reported as normal exceptions
1422 2006-10-08 Brian Warner <warner@lothar.com>
1424 * contrib/svn_watcher.py: fix security holes by using proper argv
1425 arrays and subprocess.Popen() rather than commands.getoutput().
1426 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1427 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1428 probably be removed by the next release.
1431 2006-10-04 Brian Warner <warner@lothar.com>
1433 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1434 initial lines that weren't emitted by pyflakes. When the pyflakes
1435 command is run under a Makefile, 'make' will echo the command it
1436 runs to stdio, and that was getting logged as a "misc" warning.
1437 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1438 * buildbot/test/test_steps.py (testPyFlakes3): another test
1440 2006-10-01 Brian Warner <warner@lothar.com>
1442 * buildbot/status/html.py (HtmlResource.render): if we get a
1443 unicode object from our content() method, encode it into utf-8
1444 like we've been claiming to all along. This allows the comments
1445 and author names from svnpoller.py to be delivered properly.
1447 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1448 de-unicodify filenames before creating the Change, because the
1449 rest of buildbot is unlikely to handle them well. Leave the 'who'
1450 field as a unicode object.. I don't think there's anything that
1451 will break very soon, and it will probably nudge us towards
1452 accepting unicode everywhere sooner or later. Stop using the
1453 "date" field that comes out of SVN, since it is using the
1454 repository's clock (and timezone) and what we care about is the
1455 buildmaster's (otherwise Changes from the future show up later
1456 than the builds they triggered).
1457 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1460 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1461 Suvbersion repository polling ChangeSource. I've hacked it up
1462 considerably: any bugs are entirely my own fault. Thank you
1464 * buildbot/test/test_svnpoller.py: tests for it
1465 * docs/buildbot.texinfo (SvnSource): document it
1467 2006-09-30 Brian Warner <warner@lothar.com>
1469 * buildbot/scheduler.py (Periodic): submit a reason= to the
1470 BuildSet to indicate which Scheduler triggered the build. Thanks
1471 to Mateusz Loskot for the suggestion.
1473 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1475 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1476 changes: set self.loop in __init__, remove unused volatile=
1478 * docs/buildbot.texinfo (.buildbot config directory): add more
1479 docs on the .buildbot/options keys used by "buildbot try"
1480 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1481 (Try.deliverJob): same
1483 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1485 (BonsaiPoller): same
1487 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1488 close the filehandle when we stop watching the file. Before, the
1489 filehandle was only closed when the LogFileWatcher was
1490 garbage-collected, which could be quite a while in the future. If
1491 it was still open by the time the next build started, windows will
1492 refuse to let the new build delete the old build/ directory. Fixes
1493 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1494 #twisted for the catch.
1496 2006-09-29 Brian Warner <warner@lothar.com>
1498 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1501 2006-09-25 Brian Warner <warner@lothar.com>
1503 * setup.py: the new buildbot.steps module wasn't being installed.
1504 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1505 (testmsgs): add the extra stuff from buildbot/test/* so you can
1506 run unit tests on an installed copy of buildbot, not just from
1509 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1510 columns of 'svnlook changed' output contain status information, so
1511 strip [:4] instead of [:6]. Depending upon what the status flags
1512 were, this would sometimes lead to mangled filenames. Thanks to
1513 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1515 * buildbot/steps/source.py (Monotone): initial Monotone support,
1516 contributed by Nathaniel Smith. Still needs docs and tests, but
1517 this code has been in use on the Monotone buildbot for a long
1519 * buildbot/slave/commands.py (Monotone): slave-side support
1520 * buildbot/changes/monotone.py (MonotoneSource): polling change
1523 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1524 contributed a Change Source that polls a Bonsai server (a
1525 kind of web-based viewcvs CGI script).
1527 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1528 Hearsum contributed a status plugin which sends email in the same
1529 format that Tinderbox does: this allows a number of tinderbox
1530 tools to be driven by Buildbot instead. Thanks Ben!
1532 2006-09-24 Brian Warner <warner@lothar.com>
1534 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1535 Thanks to Robert Helmer for the patch.
1537 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1538 BuildStatus about the buildslave name at the *beginning* of the
1539 build, rather than at the end. Thanks to Alexander Lorenz for the
1541 * buildbot/status/html.py (StatusResourceBuild.body): always
1542 include the slavename in the build page, not just when the build
1544 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1545 slavename in the email message
1547 2006-09-21 Brian Warner <warner@lothar.com>
1549 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1551 * docs/examples/glib_master.cfg: same
1552 * docs/examples/hello.cfg: same
1553 * docs/examples/twisted_master.cfg: same, update to current usage
1555 2006-09-19 Brian Warner <warner@lothar.com>
1557 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1558 (PyFlakes.createSummary): make it compatible with python-2.2
1560 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1561 for at least the output-parsing parts of PyFlakes
1563 2006-09-18 Brian Warner <warner@lothar.com>
1565 * buildbot/steps/python.py: oops, fix import of StringIO
1567 2006-09-17 Brian Warner <warner@lothar.com>
1569 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1570 turns out that SVN-1.4.0 doesn't fail to update once you've
1571 replaced a file with a directory, unlike older versions of SVN and
1572 pretty much every other VC tool we support. Since what we really
1573 care about is that the update succeeds anyway, stop checking that
1574 the tree got clobbered and just assert that the build succeeded.
1575 (VCBase.printLogs): add a utility function for debugging
1577 * buildbot/process/step.py: oops, added extra imports by mistake
1579 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1580 rstrip() on the first line coming out of the 'p4 describe'
1581 process, to remove the stray ^M that Wade Brainerd reports seeing
1582 in the 'when' field. Fixes SF#1555985.
1584 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1585 message logged when c['schedulers'] is not right
1586 * buildbot/scheduler.py (Scheduler.__init__): improve error
1587 message when a Scheduler() is created with the wrong arguments
1588 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1589 verify that these error messages are emitted
1591 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1592 The idea is that all the base classes (like BuildStep and
1593 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1594 will be a leftover backwards-compatibility file that only contains
1595 aliases for the steps that were moved out to buildbot.steps.*
1596 * lots: change imports to match
1597 * buildbot/process/step.py: add a DeprecationWarning if it ever
1600 2006-09-12 Brian Warner <warner@lothar.com>
1602 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1603 builderNames= is actually a sequence, since if you happen to give
1604 it a single builder-specification dictionary instead, it won't get
1605 caught by the existing assert. Thanks to Brett Neely for the
1608 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1610 * docs/buildbot.texinfo (Python BuildSteps): document them
1611 (sendchange): include a link to PBChangeSource, since you need one
1613 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1615 * buildbot/steps/dummy.py: same
1617 2006-09-08 Brian Warner <warner@lothar.com>
1619 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1620 BuildStep which lets you transfer files from the master to the
1621 slave or vice versa. Thanks to Albert Hofkamp for the original
1622 patch. Fixes SF#1504631.
1623 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1625 (SlaveFileDownloadCommand): same
1626 * docs/buildbot.texinfo (Transferring Files): document it
1627 * buildbot/test/test_transfer.py: test it
1628 * buildbot/test/runutils.py (StepTester): new utility class for
1629 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1630 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1633 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1634 walk through StatusLogs one line at a time, mostly for the benefit
1635 of ShellCommand.createSummary methods. You can either walk through
1636 STDOUT or STDERR, but the default is STDOUT.
1638 * buildbot/status/builder.py (LogFile.readlines): implement it.
1639 Note that this is not yet memory-efficient, it just pulls the
1640 whole file into RAM and then splits it up with a StringIO.
1641 Eventually this should be a generator that only pulls chunks from
1643 * buildbot/test/test_status.py (Log.testReadlines): test it
1645 * docs/buildbot.texinfo: update to match changes
1646 * buildbot/process/factory.py: stop using old definitions
1647 * buildbot/process/process_twisted.py: same
1648 * buildbot/test/test_*.py: same
1650 * buildbot/process/step_twisted.py: move definition to..
1651 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1652 relative-import mechanisms prevent this from being named 'twisted'
1653 or 'python/twisted' as I would have preferred.
1655 * buildbot/process/maxq.py: move definition to..
1656 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1658 * buildbot/process/step.py: split the user-visible BuildSteps into
1659 separate files, all under buildbot/steps/
1660 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1661 * buildbot/steps/shell.py: this holds ShellCommand and friends
1662 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1664 2006-09-05 Brian Warner <warner@lothar.com>
1666 * lots: run pyflakes, removed a lot of unused imports, changed the
1667 form of some conditional imports to remove false pyflakes
1668 warnings. There are still a number of warnings left, mostly from
1669 imports that are done for their side-effects.
1670 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1673 2006-08-26 Brian Warner <warner@lothar.com>
1675 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1676 compatible with twisted-1.3.0, for some reason I just can't seem
1677 to let go of the past.
1679 2006-08-25 Brian Warner <warner@lothar.com>
1681 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1683 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1684 all logfiles= in startCommand(), rather than in start() . This
1685 makes it easier to have the 'stdio' log come before any secondary
1686 logfiles, which I feel makes the waterfall display more
1688 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1689 from ShellCommand up into LoggingBuildStep
1690 (LoggingBuildStep.__init__): move the handling of logfiles= from
1691 ShellCommand up to LoggingBuildStep, because startCommand is
1692 provided by LoggingBuildStep, whereas start() was specific to
1693 subclasses like ShellCommand and Source. This removes code
1694 duplication in those subclasses.
1695 (ShellCommand.__init__): same
1696 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1697 for a slave that's too old to understand logfiles= into a separate
1698 method, so it can live in ShellCommand. The rest of
1699 setupLogfiles() can live in LoggingBuildStep.
1701 2006-08-24 Brian Warner <warner@lothar.com>
1703 * buildbot/locks.py (BaseLock): you can now configure Locks to
1704 allow multiple simultaneous owners. They still default to
1705 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1707 * docs/buildbot.texinfo (Interlocks): document the new options
1708 * buildbot/test/test_locks.py: add a bunch of new unit tests
1709 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1710 waitUntilMaybeAvailable, not waitUntilAvailable
1711 * buildbot/process/step.py (BuildStep.acquireLocks): same
1712 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1713 the whole lockid in their constructor, not just the name. Also,
1714 keep track of which real locks we've handed out by the full
1715 lockid, not just class+name, otherwise changing just the maxCount=
1716 in the master.cfg file would not actually cause a behavioral
1719 2006-08-23 Brian Warner <warner@lothar.com>
1721 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1723 * docs/buildbot.texinfo: same
1725 2006-08-23 Brian Warner <warner@lothar.com>
1727 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1728 * docs/buildbot.texinfo: set version to match
1729 * NEWS: update for 0.7.4
1730 * buildbot/slave/commands.py (command_version): mention that this
1731 version (2.1) was released with buildbot-0.7.4
1733 2006-08-22 Brian Warner <warner@lothar.com>
1737 * CREDITS: new file, list of people who have helped. Thanks!
1738 * MANIFEST.in: ship it
1740 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1741 new diagrams, the user's manual is more informative than it was.
1742 Start shipping the .html user's manual (and generated .png
1744 * Makefile: update 'release' target to match
1746 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1747 test.. I think the web-parts effort will render it pointless well
1748 before it ever actually starts to work.
1750 2006-08-20 Brian Warner <warner@lothar.com>
1752 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1753 meaning of the prefix= argument. It is now just a string which is
1754 stripped from the beginning of the filename. If prefix= is set but
1755 not found on any given filename, that filename is ignored. If all
1756 filenames in a Change are ignored, the Change is dropped. This is
1757 much simpler than the previous sep= nonsense, and I should have
1758 implemented it this way from the beginning. Effectively resolves
1759 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1760 Gedminas for the catch and suggested fixes.
1761 (ChangePerspective.perspective_addChange): implement the actual
1763 * buildbot/test/test_changes.py (TestChangePerspective): test it
1764 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1765 how to properly use prefix=
1766 * docs/examples/twisted_master.cfg (source): update prefix= by
1767 adding the trailing slash
1770 * docs/examples/twisted_master.cfg: update to actual practice
1772 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1773 update test case to match new link text.. the HREF has both a
1774 class= setting and an enclosing [] pair that I didn't match in the
1777 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1778 list of strings is preferred over a single string with embedded
1780 (ShellCommand.description=): explain that either single strings or
1781 a list of strings is acceptable, and why you might prefer one over
1782 the other. Add an example. Fixes SF#1524659, thanks to Paul
1783 Winkler for the catch.
1784 (Build Steps): update to use f.addStep() rather than using s()
1785 and the constructor list
1787 * buildbot/process/step.py (ShellCommand): accept either a single
1788 string or a list of strings in both description= and
1790 * buildbot/test/test_steps.py (Steps.test_description): test it
1791 * buildbot/test/runutils.py (makeBuildStep): support for that test
1793 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1794 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1795 collecting the files and creating the patch.
1797 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1798 per-step URLs that will be displayed on the waterfall display,
1799 for things like the HTML output of code-coverage tools, when
1800 the results are hosted elsewhere.
1801 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1802 way to retrieve these URLs
1803 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1804 the method to retrieve these URLs. Also provide backwards
1805 compatibility for saved BuildStepStatus instances that didn't have
1807 * buildbot/process/step.py (BuildStep.addURL): method to set these
1808 URLs from within a BuildStep
1809 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1810 (StepBox.getBox): give these external links a distinct CSS class
1811 named "BuildStep external" so a .css file can display them
1814 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1816 * buildbot/test/test_steps.py (Steps): test that we can all the
1817 URLs. Also add a bunch of other tests on methods that can be
1818 called from within BuildSteps
1819 * buildbot/test/runutils.py (makeBuildStep): add utility function
1821 2006-08-13 Brian Warner <warner@lothar.com>
1823 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1825 2006-08-10 Brian Warner <warner@lothar.com>
1827 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1828 index, this one of things like c['sources'] and c['schedulers']
1829 (indices): it looks like my clever idea of putting the @fooindex
1830 commands in between the @node and the @subsection (to make the
1831 HREF anchor jump to slightly above the section title, which works
1832 much better in html) confused texinfo horribly, so I'm moving the
1833 index tags back to be just after the @subsection marker. I also
1834 added extra lines between the @node/@section paragraph and the
1835 index tags, since I think maybe texinfo wants to see these be
1836 separate paragraphs.
1838 * docs/Makefile (images): make sure images get built when
1839 rendering the manual
1840 * docs/images/Makefile: same
1842 * buildbot/scripts/runner.py: rename 'buildbot master' to
1843 'buildbot create-master', and 'buildbot slave' to 'buildbot
1845 * docs/buildbot.texinfo: same
1848 * docs/buildbot.texinfo: reimplement the "useful classes" index
1849 with actual texinfo indices. The .info rendering is a bit
1850 weird-looking but it works well, and the HTML rendering is quite
1851 nice. This also puts the index targets in the regular flow of the
1852 text, which is easier to maintain.
1854 2006-08-06 Brian Warner <warner@lothar.com>
1856 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1857 Kevin Turner to prefer the environ= argument be a list rather than
1858 a string. If it is a list, it will be joined with a platform-local
1859 os.pathsep delimiter, and then prepended to any existing
1860 $PYTHONPATH value. This works better in cross-platform (i.e.
1861 windows buildslaves) environments when you need to push multiple
1862 directories onto the front of the path.
1863 (SlaveShellCommand): documented the new magic
1864 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1865 in a user-visible form
1867 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1868 Turner to prefer lists over strings when creating/running VC
1869 commands during unit tests. This is clearly necessary to survive
1870 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1871 renamed the wq() function to qw() though, since that's how it's
1872 spelled in perl. Eventually I'd prefer all commands to be
1873 specified with lists.
1875 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1876 which are deleted (or not yet created) correctly. Also add
1877 failsafe code to not explode if the file-watching poller doesn't
1878 get started. Thanks to JP Calderone for the catch and the poller
1880 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1882 * buildbot/test/emitlogs.py: same
1884 * NEWS: summarize recent changes
1886 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1887 clause to avoid the "host key mismatch" warning
1889 * buildbot/process/step_twisted.py (Trial.start): if the
1890 buildslave is too old to understand logfiles=, fall back to
1891 running 'cat _trial_temp/test.log' like before.
1892 (Trial.commandComplete): same. this takes advantage of the
1893 LoggingBuildStep refactoring to stall commandComplete long enough
1894 to run a second RemoteShellCommand.
1896 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1897 refactor command-completion handling, to allow methods like
1898 commandComplete/createSummary/evaluateCommand to return Deferreds.
1899 (LoggingBuildStep._commandComplete): delete the refactored method
1900 (ShellCommand.setupLogfiles): if the buildslave is too old to
1901 understand logfiles=, put a warning message both into twistd.log
1902 and into the otherwise empty user-visible LogFiles.
1904 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1905 callers to provide the slave-side logfile name, rather than
1906 forcing it to come from the local name of the LogFile.
1907 (BuildStep.getSlaveName): new method
1909 * buildbot/process/base.py (Build.getSlaveName): new method, so
1910 steps can find out which buildslave they're running on
1912 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1913 to match the s/cvs_ver/command_version/ change
1915 2006-08-05 Brian Warner <warner@lothar.com>
1917 * buildbot/slave/commands.py (command_version): replace the CVS
1918 auto-updated cvs_ver keyword with a manually-updated variable,
1919 since CVS is no longer the master repository. Add a description of
1920 the remote API change starting in this version (2.1), specifically
1921 the fact that SlaveShellCommand now accepts 'initial_stdin',
1922 'keep_stdin_open', and 'logfiles'.
1924 2006-07-31 Brian Warner <warner@lothar.com>
1926 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1927 diagrams to describe how the whole system fits together. The
1928 images themselves are kept in SVG files, with ascii-art versions
1929 in corresponding .txt files. Texinfo knows how to interpolate the
1930 text version into .info files, reference the .png versions from
1931 .html files, and include .eps versions in the .ps format.
1932 * docs/images/Makefile: tools to create .png and .eps
1933 * docs/images/*.svg: created pictures with Inkscape.
1934 * .darcs-boring: ignore the generated .eps and .png files
1936 2006-07-24 Brian Warner <warner@lothar.com>
1938 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1939 Scheduler names, since they cause setServiceParent to explode
1941 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1943 2006-07-20 Brian Warner <warner@lothar.com>
1945 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1946 which runs the buildbot unit tests
1948 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1949 classes that are useful in master.cfg
1951 2006-07-15 Brian Warner <warner@lothar.com>
1953 * Makefile (some-apidocs): new target to build only some epydocs
1955 * setup.py: minor comment.. does the classifiers= argument prevent
1956 the setup.py script from working on python2.2/2.3?
1958 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1961 * buildbot/twcompat.py: fix minor typo in comments
1963 * buildbot/manhole.py: move all Manhole-related code out to this
1964 module. Implement SSH-based manholes (with TwistedConch), and move
1965 to conch's nifty line-editing syntax-coloring REPL shell instead
1966 of the boring non-editing monochromatic (and deprecated) old
1968 * buildbot/master.py: remove all Manhole-related code
1969 (BuildMaster.loadConfig._add): make sure the old manhole is
1970 removed before we add the new one
1971 * docs/buildbot.texinfo (Debug options): document new Manhole options
1973 * buildbot/twcompat.py (_which): fix some epydoc issues
1974 * buildbot/status/html.py (Waterfall.__init__): same
1976 2006-06-29 Brian Warner <warner@lothar.com>
1978 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1979 deprecation warnings under newer Twisteds (by using
1980 zope.interface.Interface instead of old twisted.python.components
1982 * buildbot/slave/interfaces.py: same
1984 2006-06-28 Brian Warner <warner@lothar.com>
1986 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1987 svn commands, so it will fail immediately instead of hanging while
1988 it waits for a username/password to be typed in.
1990 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1991 log message if the step was shut down
1993 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1994 obsolete reference to mktap.
1996 2006-06-20 Brian Warner <warner@lothar.com>
1998 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1999 test to include new 'logfiles' argument sent from master to slave
2001 2006-06-19 Brian Warner <warner@lothar.com>
2003 * buildbot/process/step_twisted.py (Trial): track Progress from
2004 _trial_temp/test.log too
2006 * buildbot/process/step.py (OutputProgressObserver): generalize
2007 the earlier StdioProgressObserver into an OutputProgressObserver
2008 that can track LogFiles other than stdio.
2009 (LoggingBuildStep.__init__): same
2011 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
2012 _trial_temp/test.log, not a separate 'cat' command. TODO: this
2013 will fail under windows because of os.sep issues. It might have
2014 worked before if 'cat' was doing cygwin path conversion.
2016 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
2017 creation of LogFileWatchers
2018 (ShellCommand._startCommand): and record the files that were
2019 watched in the 'headers' section of the ShellCommand output
2021 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
2022 need to actually pass it to the slave if you want it to work.
2023 (ShellCommand): document it a bit
2025 * buildbot/test/test_shell.py: new test to validate LogFiles
2026 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
2028 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
2029 before printing the last batch of lines, to test that the polling
2030 logic is working properly
2032 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
2033 handling, making it possible to track multiple logs for a single
2034 RemoteCommand. The previous single logfile is now known as the
2036 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
2037 (RemoteShellCommand.__init__): accept logfiles=
2038 (LoggingBuildStep.startCommand): stdio_log is now one of many
2039 (ShellCommand): added logfiles= argument, as well as a class-level
2040 .logfiles attribute, which will be merged together to figure out
2041 which logfiles should be tracked. The latter maybe be useful for
2042 subclasses of ShellCommand which know they will aways produce
2043 secondary logfiles in the same location.
2045 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
2046 and closeStdin() methods, preparing to make it possible to write
2047 to a ShellCommand's stdin at any time, not just at startup. These
2048 writes are buffered if the child process hasn't started yet.
2049 (LogFileWatcher): new helper class to watch arbitrary logfiles
2050 while a ShellCommand runs. This class polls the file every two
2051 seconds, and sends back 10k chunks to the buildmaster.
2052 (ShellCommand): rename stdin= to initialStdin=, and add
2053 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
2055 (ShellCommand.addLogfile): LogFile text is sent in updates with a
2056 key of "log" and a value of (logname, data).
2057 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
2058 'logfiles' to the master-visible args dictionary.
2059 (SourceBase.doPatch): match s/stdin/initialStdin/ change
2062 * buildbot/test/test_vc.py (Patch.testPatch): same
2065 * buildbot/test/emit.py: write to a logfile in the current
2066 directory. We use this to figure out what was used as a basedir
2067 rather than looking to see which copy of emit.py gets run, so that
2068 we can run the commands from inside _trial_temp rather than inside
2070 * buildbot/test/subdir/emit.py: same
2071 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
2072 argument rather than running from buildbot/test/
2073 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
2074 rather than using an implicit setUp()
2075 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
2076 (ShellBase.testShell1, etc): use explicit path to emit.py instead
2077 of assuming that we're running in buildbot/test/ (and that '.' is
2080 * buildbot/slave/commands.py (Command.doStart): refactor Command
2081 startup/completion a bit: now the SlaveBuilder calls doStart(),
2082 which is not meant for overridding by subclasses, and doStart()
2083 calls start(), which is. Likewise the SlaveBuilder calls
2084 doInterrupt(), and subclasses override interrupt(). This also puts
2085 responsibility for maintaining .running in Command rather than in
2087 (Command.doInterrupt): same
2088 (Command.commandComplete): same, this is called when the deferred
2089 returned by start() completes.
2090 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
2091 (SlaveBuilder.remote_interruptCommand): same
2092 (SlaveBuilder.stopCommand): same
2094 2006-06-16 Brian Warner <warner@lothar.com>
2096 * buildbot/test/test_shell.py: new test file to contain everything
2097 relating to ShellCommand
2098 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
2099 multiple logfiles in realtime" feature, not yet implemented
2100 * buildbot/test/emitlogs.py: support file for testLogFiles
2101 * docs/buildbot.texinfo (ShellCommand): document the feature
2103 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2105 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2106 for tests which exercise SlaveCommands in isolation.
2108 * buildbot/test/test_slavecommand.py: Move some utilities like
2109 SignalMixin and FakeSlaveBuilder from here ..
2110 * buildbot/test/runutils.py: .. to here, so they can be used by
2111 other test classes too
2112 * buildbot/test/test_vc.py: more SignalMixin refactoring
2113 * buildbot/test/test_control.py: same
2114 * buildbot/test/test_run.py: and some rmtree refactoring
2116 2006-06-15 Brian Warner <warner@lothar.com>
2118 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2119 'testBranch' to match other VC tests and have the tests run in
2120 roughly increasing order of dependency
2122 * buildbot/test/test_steps.py (LogObserver): new test to verify
2123 LogObservers can be created at various times and still get
2124 connected up properly
2126 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2127 to create BuildStepStatus instances that actually work.
2129 * buildbot/process/step.py (LogObserver): add outReceived and
2130 errReceived base methods, to be overridden
2132 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2133 API to take a name instead of a step, reducing the coupling
2134 somewhat. This returns the BuildStepStatus object so it can be
2135 passed to the new Step, instead of jamming it directly into the
2137 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2139 * buildbot/process/base.py (Build.setupBuild): use both methods
2140 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2141 process a bit to match
2143 2006-06-14 Brian Warner <warner@lothar.com>
2145 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2146 docs on writing new LogObserver classes
2147 (Writing New Status Plugins): brief docs on how Status Plugins fit
2150 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2151 implement a LogObserver that counts how many unit tests have been
2153 (Trial.__init__): wire it in
2154 * buildbot/test/test_twisted.py (Counter): unit test for it
2156 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2157 to new cmd.logs['stdio'] scheme
2158 (Trial.commandComplete): same
2159 (BuildDebs.commandComplete): same
2161 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2162 LogFiles, instead of just a single one. The old single logfile is
2163 now called "stdio". LoggedRemoteCommand no longer creates a
2164 LogFile for you (the code to do that was broken anyway). If you
2165 don't create a "stdio" LogFile, then stdout/stderr will be
2167 (LogObserver): implement "LogObservers", which a BuildStep can add
2168 to parse the output of a command in real-time. The primary use is
2169 to provide more useful information to the Progress code, allowing
2170 better ETA estimates.
2171 (LogLineObserver): utility subclass which feeds complete lines to
2172 the parser instead of bytes.
2173 (BuildStep.progressMetrics): this is safer as a tuple
2174 (BuildStep.setProgress): utility method, meant to be called by
2176 (BuildStep.addLogObserver): new method, to be called at any time
2177 during the BuildStep (even before any LogFiles have been created),
2178 to attach (or schedule for eventual attachment) a LogObserver to a
2180 (StdioProgressObserver): new LogObserver which replaces the old
2181 "output" progress gatherer
2182 (LoggingBuildStep.__init__): same
2183 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2184 (LoggingBuildStep._commandComplete): must use logs['stdio']
2185 instead of the old single ".log" attribute.
2186 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2187 functionality, now subsumed into StdioProgressObserver
2188 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2189 log name changed from "output" to "stdio".
2192 * buildbot/interfaces.py (ILogFile): add the Interface used from
2193 the BuildStep towards the LogFile
2194 (ILogObserver): and the one provided by a LogObserver
2195 * buildbot/status/builder.py (LogFile): implement it
2197 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2198 HEADER constants here ..
2199 * buildbot/status/builder.py (STDOUT): .. from here
2201 2006-06-13 Brian Warner <warner@lothar.com>
2203 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2204 compatibility with python2.2, which doesn't have the 'substr in
2206 (TestP4Poller.makeTime): utility function to construct the
2207 timestamp using the same strptime() approach as p4poller does. It
2208 turns out that time.mktime() behaves slightly differently under
2209 python2.2, probably something to do with the DST flag, and that
2210 causes the test to fail under python2.2. (changing the mktime()
2211 arguments to have dst=0 instead of -1 caused it to fail under
2212 python2.3. Go figure.)
2213 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2215 2006-06-12 Brian Warner <warner@lothar.com>
2217 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2218 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2219 contributing such an excellent patch, including docs and unit
2220 tests! This makes it *so* much easier to apply. I had to update
2221 test_vc.py to handle some recent refactorings, but everything else
2222 applied smoothly. The only remaining thing I'd like to fix would
2223 be to remove the hard-wired port 1666 used by p4d, and allow it to
2224 claim any unused port. This would allow two copies of the test
2225 suite to run on the same host at the same time, as well as
2226 allowing the test suite to run while a real (production) p4d was
2227 running on the same host. Oh, and maybe we should add a warning to
2228 step.P4 that gets emitted if the slave is too old to provide the
2229 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2230 * buildbot/slave/commands.py (P4): same
2231 (P4Sync): same, some minor updates
2232 * buildbot/changes/p4poller.py: same
2233 * docs/buildbot.texinfo: same
2234 * buildbot/test/test_p4poller.py: same
2235 * buildbot/test/test_vc.py (P4): same
2237 * setup.py: add Trove classifiers for PyPI
2239 2006-06-08 Brian Warner <warner@allmydata.com>
2241 * buildbot/status/client.py
2242 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2243 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2244 build needs to be IRemote'd separately, rather than IRemote'ing
2245 the whole list at once. I can't wait until newpb's serialization
2246 adapters make this unnecessary.
2248 2006-06-06 Brian Warner <warner@lothar.com>
2250 * buildbot/process/step.py (WithProperties): make this inherit
2251 from ComparableMixin, so that reloading an unchanged config file
2252 doesn't cause us to spuriously reload any Builders which use them.
2253 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2256 2006-06-03 Brian Warner <warner@lothar.com>
2258 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2259 running py2exe on windows, contributed by Mark Hammond. Addresses
2260 SF#1401121, but I think we still need to include
2261 buildbot/scripts/sample.cfg
2262 * setup.py: include buildbot_service.py as a script under windows
2263 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2264 a py2exe application), get the icon/css datafiles from a different
2267 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2268 double-escape the build URL. Thanks to Olivier Bonnet for the
2269 patch. Fixes SF#1452801.
2271 2006-06-02 Brian Warner <warner@lothar.com>
2273 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2274 first six columns of 'svnlook' output, not just the first column,
2275 since property changes appear in the other five. Thanks to Olivier
2276 Bonnet for the patch. Fixes SF#1398174.
2278 2006-06-01 Brian Warner <warner@lothar.com>
2280 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2281 the fake build, so that title= has something to be set to
2283 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2284 attribute of the "Build #NN" link in the yellow start-the-build
2285 box to the build's reason. This means that you get a little
2286 tooltip explaining why the build was done when you hover over the
2287 yellow box. Thanks to Zandr Milewski for the suggestion.
2289 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2290 (Box.setETA): handle ETA=None (by stopping the timer)
2291 (Box.update): make the [soon] text less different than the usual
2292 text, so the rest of the text doesn't flop around so much. It
2293 would be awfully nice to figure out how to center this stuff.
2294 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2296 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2297 by default, so that any ShellCommand which fails marks the overall
2298 build as a failure. I should have done this from the beginning.
2299 Add flunkOnFailure=False to the arguments if you want to turn off
2302 2006-05-30 Brian Warner <warner@lothar.com>
2304 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2305 last-build/current-build/current-step. Show what step is currently
2306 running. Show ETA for both the overall build and the current step.
2307 Update GTK calls to modern non-deprecated forms. There's still a
2308 lot of dead code and debug noise to remove.
2310 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2311 shows up properly in status displays
2313 2006-05-28 Brian Warner <warner@lothar.com>
2315 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2316 build we use to verify that WithProperties works:
2318 ** set flunkOnFailure=True so that build failures get noticed
2319 ** set workdir='.' so that the build succeeds, otherwise it is trying
2320 to touch 'build/something', and 'build/' doesn't exist because
2321 usually that's created by a Source step
2322 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2323 this test somehow triggers, in which the 'touch' process becomes
2324 a zombie and we wait for th etimeout before giving up on it.
2326 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2327 to log the Build results and step logs to the twisted log.
2328 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2329 what went wrong if a build was expected to succeed but didn't.
2331 * buildbot/process/step_twisted.py (Trial): set the default
2332 trialMode to '--reporter=bwverbose', which specifies verbose
2333 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2334 '-to', but those are completely missing in modern Twisteds.
2336 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2337 a localhost-only port, to encourage better security
2339 * docs/buildbot.texinfo (Change Sources): mention
2342 * .darcs-boring: add a Darcs boringfile
2344 * README (REQUIREMENTS): stop claiming compatibility with
2347 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2350 2006-05-27 Brian Warner <warner@lothar.com>
2352 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2353 * docs/buildbot.texinfo: same
2355 2006-05-23 Brian Warner <warner@lothar.com>
2357 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2358 * docs/buildbot.texinfo: set version to match
2359 * NEWS: update for 0.7.3
2361 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2362 give a quick mapping from VC system to possible ChangeSources
2363 (Build Properties): add 'buildername'
2365 * buildbot/process/base.py (Build.setupStatus): oops, set
2366 'buildername' and 'buildnumber' properties
2367 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2370 2006-05-22 Brian Warner <warner@lothar.com>
2372 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2373 property interpolation better
2375 * README (INSTALLATION): remove old '-v' argument from recommended
2378 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2379 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2382 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2383 'svnversion' instead of grepping the output of 'svn info', much
2384 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2385 Bonnet for the suggestion.
2386 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2387 require the WC_PATH argument, so run 'svnversion .' instead.
2389 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2390 aren't supposed to have 'self' in their argument list
2392 2006-05-21 Brian Warner <warner@lothar.com>
2394 * buildbot/process/step.py (ShellCommand.start): make
2395 testInterpolate pass. I was passing the uninterpolated command to
2396 the RemoteShellCommand constructor
2397 (ShellCommand._interpolateProperties): oops, handle non-list
2398 commands (i.e. strings with multiple words separated by spaces in
2399 them) properly, instead of forgetting about them.
2401 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2402 to actually try to use build properties in a real build. This test
2404 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2405 to start and evaluate builds
2407 * buildbot/test/test__versions.py: add a pseudo-test to record
2408 what version of Twisted/Python/Buildbot are running. This should
2409 show up at the beginning of _trial_tmp/test.log, and exists to help
2410 debug other problems.
2412 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2413 a filename to be served as 'robots.txt' to discourage web spiders.
2414 Adapted from a patch by Tobi Vollebregt, thanks!
2415 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2416 (Waterfall.test_waterfall): tweak the way that filenames are put
2417 into the config file, to accomodate windows pathnames better.
2419 * docs/buildbot.texinfo (HTML Waterfall): document it
2421 * buildbot/process/process_twisted.py
2422 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2423 changed the build process. The new setup.py no longer takes the
2425 (FullTwistedBuildFactory.__init__): same
2426 (TwistedReactorsBuildFactory.__init__): same
2428 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2429 be placed in the [hooks] section of the central repository (the
2430 one that everybody pushes changes to).
2432 2006-05-20 Brian Warner <warner@lothar.com>
2434 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2435 .darcs-context file, use binary mode. I think this was causing a
2436 Darcs failure under windows.
2438 2006-05-19 Brian Warner <warner@lothar.com>
2440 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2441 use a timezone string of +0000 and gmtime, since this timestamp is
2442 sent to a buildmaster and %z is broken.
2444 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2445 string and localtime, since this timestamp will only be consumed
2446 locally, and %z is broken.
2448 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2449 gmtime, since this timestamp is returned to the buildmaster, and
2452 2006-05-18 Brian Warner <warner@lothar.com>
2454 * NEWS: update in preparation for next release
2456 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2457 setup-repository and do-we-have-the-vc-tools code into a separate
2458 "helper" class, which sticks around in a single module-level
2459 object. This seems more likely to continue to work in the future
2460 than having it hide in the TestCase and hope that TestCases stick
2461 around for a long time.
2463 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2464 addremove' has been deprecated in recent versions of mercurial, so
2465 use 'hg add' instead
2467 2006-05-07 Brian Warner <warner@lothar.com>
2469 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2470 operating under windows, move the file before opening it, since
2471 you can't rename a file that somebody has open.
2473 * buildbot/process/base.py (Build.setupBuild): if something goes
2474 wrong while creating a Step, log the name and arguments, since the
2475 error message when you get the number of arguments wrong is really
2478 2006-05-06 Brian Warner <warner@lothar.com>
2480 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2481 bugs in twisted-specific code not covered by my unit tests, this
2482 time use 'cmd' argument instead of self.cmd
2484 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2485 fix stupid braino: either use startwith or find()==0, not both.
2486 (TwistedReactorsBuildFactory.__init__): another dumb typo
2488 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2489 mark this test as TODO under windows, since process-killing seems
2490 dodgy there. We'll come back to this later and try to fix it
2493 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2494 and don't include a timezone
2495 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2496 This should avoid the windows-with-verbose-timezone-name problem
2498 (Patch.testPatch): add a test which runs 'patch' with less
2499 overhead than the full VCBase.do_patch sequence, to try to isolate
2500 a windows test failure. This one uses slave.commands.ShellCommand
2501 and 'patch', but none of the VC code.
2503 * buildbot/slave/commands.py (getCommand): use which() to find the
2504 executables for 'cvs', 'svn', etc. This ought to help under
2507 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2508 working directory before starting. If an earlier test failed, the
2509 leftover directory would mistakenly flunk a later test.
2510 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2511 Make sure that we use the right commandlines if which("tla") picks
2512 up "tla.exe" (as it does under windows).
2513 (TlaSupport.do_get): factor out this tla-vs-baz difference
2514 (TlaSupport.vc_create): more tla-vs-baz differences
2516 * buildbot/test/test_slavecommand.py
2517 (ShellBase.testShellMissingCommand): stop trying to assert
2518 anything about the error message: different shells on different
2519 OSes with different languages makes it hard, and it really isn't
2520 that interesting of a thing to test anyway.
2522 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2523 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2524 "Panther"), because it has a bug which flunks a couple tests in
2525 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2526 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2527 able to test that yet.
2529 2006-04-30 Brian Warner <warner@lothar.com>
2531 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2532 make sure child commands emit messages in english, so our regexps
2533 will match. Thanks to Nikaus Giger for identifying the problems.
2534 (VCBase._do_vctest_export_1): mode="export" is not responsible
2535 for setting the "got_revision" property, since in many cases it is
2536 not convenient to determine.
2537 (SVNSupport.capable): when running 'svn --version' to check for
2538 ra_local, we want error messages in english
2539 * buildbot/test/test_slavecommand.py
2540 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2541 to emit the error message in english
2543 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2544 the environment with $LC_ALL="C" so that Commands which need to
2545 parse the output of their child processes can obtain it in
2547 (SVN.parseGotRevision): call "svn info" afterwards instead of
2548 watching the output of the "svn update" or "svn checkout".
2549 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2550 (Arch.parseGotRevision): same
2551 (Bazaar.parseGotRevision): same
2552 (Mercurial.parseGotRevision): same
2554 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2555 $LC_ALL="C" when running commands under 'buildbot try', too
2557 * buildbot/test/__init__.py: remove the global os.environ()
2558 setting, instead we do it just for the tests that run commands and
2559 need to parse their output.
2561 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2562 remove the overly-short .timeout on this test, because non-DNotify
2563 platforms must fall back to polling which happens at 10 second
2564 intervals, so a 5 second timeout would never succeed.
2566 2006-04-24 Brian Warner <warner@lothar.com>
2568 * docs/buildbot.texinfo (Installing the code): update trial
2569 invocation, SF#1469116 by Niklaus Giger.
2570 (Attributes of Changes): updated branch-name examples to be
2571 a bit more realistic, SF#1475240 by Stephen Davis.
2573 * contrib/windows/buildbot2.bat: utility wrapper for windows
2574 developers, contributed by Nick Trout (after a year of neglect..
2575 sorry!). SF#1194231.
2577 * buildbot/test/test_vc.py (*.capable): store the actual VC
2578 binary's pathname in VCS[vcname], so it can be retrieved later
2579 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2580 strip out non-numeric timezone information, specifically the funky
2581 German string that his system produced that confuses CVS.
2582 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2583 allow Darcs tests to work on windows
2584 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2585 procutils.which() everywhere, to allow tryclient to work under
2586 windows. Also from Niklaus Giger, SF#1463394.
2588 * buildbot/twcompat.py (which): move the replacement for a missing
2589 twisted.python.procutils.which from test_vc.py to here, so it can
2590 be used in other places too (specifically tryclient.py)
2592 2006-04-23 Brian Warner <warner@lothar.com>
2594 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2595 bare buildbotURL/projectName line with a proper DIV, along with a
2596 CSS class of "title", from Stefan Seefeld (SF#1461675).
2597 (WaterfallStatusResource.body0): remove the redundant 'table'
2598 class from the table
2599 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2600 to the top-row TR, and class="Activity" to the second-row TR,
2601 rather than putting them in the individual TD nodes.
2603 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2604 'got_revision' build property for all VC systems that implement
2605 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2607 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2608 to determine which revision we actually obtained
2609 (CVS.parseGotRevision): implement this for CVS, which just means
2610 to grab a timestamp. Not ideal, and it depends upon the buildslave
2611 having a clock that is reasonably well syncronized with the server,
2612 but it's better than nothing.
2613 (SVN.parseGotRevision): implement it for SVN, which is accurate
2614 (Darcs.parseGotRevision): same
2615 (Arch.parseGotRevision): same
2616 (Bazaar.parseGotRevision): same
2617 (Mercurial.parseGotRevision): same
2619 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2620 keep a record of all non-stdout/stderr/header/rc status updates,
2621 for the benefit of RemoteCommands that send other useful things,
2623 (Source.commandComplete): put any 'got_revision' status values
2624 into a build property of the same name
2627 * buildbot/process/step_twisted.py (Trial): update to deal with
2628 new ShellCommand refactoring
2630 * docs/buildbot.texinfo (Build Properties): document new feature
2631 that allows BuildSteps to get/set Build-wide properties like which
2632 revision was requested and/or checked out.
2634 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2635 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2636 it. Note that this bumps the persistenceVersion of the saved Build
2637 object, so add the necessary upgrade-old-version logic to include
2638 an empty properties dict.
2640 * buildbot/process/base.py (Build.setProperty): implement it
2641 (Build.getProperty): same
2642 (Build.startBuild): change build startup to set 'branch',
2643 'revision', and 'slavename' properties at the right time
2645 * buildbot/process/step.py (BuildStep.__init__): change setup to
2646 require 'build' argument in a better way
2647 (LoggingBuildStep): split ShellCommand into two pieces, for better
2648 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2649 a single RemoteCommand that sends stdout/stderr status text. It
2650 also provides the usual commandComplete / createSummary /
2651 evaluateCommand / getText methods to be overridden...
2652 (ShellCommand): .. whereas ShellCommand is specifically for
2653 running RemoteShellCommands. Other shell-like BuildSteps (like
2654 Source) can inherit from LoggingBuildStep instead of ShellCommand
2655 (WithProperties): marker class to do build-property interpolation
2656 (Source): inherit from LoggingBuildStep instead of ShellCommand
2659 * buildbot/test/test_properties.py: test new functionality
2661 2006-04-21 Brian Warner <warner@lothar.com>
2663 * buildbot/test/test_vc.py: rename testBranch to
2664 testCheckoutBranch to keep the tests in about the right
2667 2006-04-18 Brian Warner <warner@lothar.com>
2669 * docs/buildbot.texinfo (PBListener): improve cross-references
2670 between PBListener and 'buildbot statusgui', thanks to John Pye
2673 2006-04-17 Brian Warner <warner@lothar.com>
2675 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2676 running under Twisted-1.3.0, otherwise skipped tests are reported
2679 * all: use isinstance() instead of 'type(x) is foo', suggested by
2682 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2683 oops, fix a brain-fade from the other week, when making the
2684 addStep changes. I changed all the __init__ upcalls to use the
2685 wrong superclass name.
2686 (FullTwistedBuildFactory.__init__): same
2687 (TwistedDebsBuildFactory.__init__): same
2688 (TwistedReactorsBuildFactory.__init__): same
2689 (TwistedBuild.isFileImportant): use .startswith for clarity,
2690 thanks to Neal Norwitz for the suggestions.
2692 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2693 changes, then deliver them over PB to a remote buildmaster.
2695 * contrib/svnpoller.py: added script by John Pye to poll a remote
2696 SVN repository (by running 'svn log') from a cronjob, and run
2697 'buildbot sendchange' to deliver the changes to a remote
2699 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2700 modification of svnpoller.py), same purpose, but this one loops
2701 internally (rather than expecting to run from a cronjob) and works
2703 * contrib/README.txt: same
2705 2006-04-11 Brian Warner <warner@lothar.com>
2707 * all: fix a number of incorrect names and missing imports, thanks
2708 to Anthony Baxter for the patch.
2709 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2710 remove unused buggy method.
2711 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2712 comes from shutil, not "shutils"
2713 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2714 (Arch.checkSlaveVersion): same
2715 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2717 * buildbot/process/step_twisted2.py: add some missing imports
2718 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2719 this code used to live in twisted.internet.defer
2721 2006-04-10 Brian Warner <warner@lothar.com>
2723 * buildbot/process/step.py (Mercurial): add Mercurial support
2724 * buildbot/slave/commands.py (Mercurial): same
2725 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2726 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2727 not yet tested, but 'try' support *is* covered
2728 * docs/buildbot.texinfo (Mercurial): document it
2730 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2731 some debugging messages (turned off)
2732 * buildbot/test/test_vc.py: improve debug messages
2734 2006-04-07 Brian Warner <warner@lothar.com>
2736 * buildbot/test/test_vc.py (which): define our own which() in case
2737 we can't import twisted.python.procutils, because procutils doesn't
2738 exist in Twisted-1.3
2740 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2741 of SlaveLocks for performance tests
2743 * docs/examples/twisted_master.cfg: update to match current usage
2745 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2746 password, p4 binary, pollinterval, maximum history to check.
2747 Patch from an anonymous sf.net contributor, SF#1219384.
2748 * buildbot/process/step.py (P4Sync.__init__): add username,
2749 password, and client arguments.
2750 * buildbot/slave/commands.py (P4Sync): same
2752 2006-04-05 Brian Warner <warner@lothar.com>
2754 * buildbot/process/factory.py (BuildFactory.addStep): new method
2755 to add steps to a BuildFactory. Use it instead of f.steps.append,
2756 and you can probably avoid using the s() convenience function.
2757 Patch from Neal Norwitz, sf.net #1412605.
2758 (other): update all factories to use addStep
2759 * buildbot/process/process_twisted.py: update all factories to use
2762 2006-04-03 Brian Warner <warner@lothar.com>
2764 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2765 work under windows too. Adapted from a patch by Niklaus Giger,
2766 addresses SF#1463399.
2768 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2769 spawned commands emit parseable results in english and not some
2770 other language. Patch from Niklaus Giger, SF#1463395.
2772 * README (INSTALLATION): discourage users from running unit tests on
2773 a "network drive", patch from Niklaus Giger, SF#1463394.
2775 2006-03-22 Brian Warner <warner@lothar.com>
2777 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2778 function to turn a repository-relative pathname into a (branch,
2779 branch-relative-filename) tuple. Change this function to handle
2780 the branch naming policy used by your Subversion repository.
2781 Thanks to AllMyData.com for sponsoring this work.
2783 2006-03-16 Brian Warner <warner@lothar.com>
2785 * buildbot/scripts/sample.cfg: add python-mode declaration for
2786 vim. Thanks to John Pye for the patch.
2788 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2789 command line, mention the importance of running 'crontab' as the
2790 buildmaster/buildslave user. Thanks to John Pye for the catch.
2792 2006-03-13 Brian Warner <warner@lothar.com>
2794 * buildbot/status/words.py (IRC): add an optional password=
2795 argument, which will be sent to Nickserv in an IDENTIFY message at
2796 login, to claim the nickname. freenode requires this before the
2797 bot can sent (or reply to) private messages. Thanks to Clement
2798 Stenac for the patch.
2799 * docs/buildbot.texinfo (IRC Bot): document it
2801 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2802 larger than chunkSize. Fixes SF#1349253.
2803 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2804 (Log.testConsumer): update to match new internal chunking behavior
2806 2006-03-12 Brian Warner <warner@lothar.com>
2808 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2810 * buildbot/test/test_maildir.py (MaildirTest): rename the
2811 'timeout' method, as it collides with trial's internals
2813 * buildbot/scripts/runner.py: add 'buildbot restart' command
2814 (stop): don't sys.exit() out of here, otherwise restart can't work
2815 * docs/buildbot.texinfo (Shutdown): document it
2817 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2818 * buildbot/status/html.py (Waterfall.__init__): same
2819 * buildbot/process/builder.py (Builder.startBuild): same
2820 * buildbot/process/base.py (BuildRequest): same
2821 * buildbot/sourcestamp.py (SourceStamp): same
2822 * buildbot/scheduler.py (Nightly): same
2824 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2826 * docs/buildbot.texinfo: same
2828 2006-02-17 Brian Warner <warner@lothar.com>
2830 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2831 * docs/buildbot.texinfo: set version number to match
2832 * NEWS: update for 0.7.2
2834 2006-02-16 Brian Warner <warner@lothar.com>
2836 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2838 2006-02-09 Brian Warner <warner@lothar.com>
2840 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2841 add text to explain per-build branch parameters
2842 * NEWS: mention --umask
2844 2006-02-08 Brian Warner <warner@lothar.com>
2846 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2848 (SlaveOptions.optParameters): add --umask, to make it possible to
2849 make buildslave-generated files (including build products) be
2852 * buildbot/slave/bot.py (BuildSlave.startService): same
2854 2006-01-23 Brian Warner <warner@lothar.com>
2856 * buildbot/status/builder.py: urllib.quote() all URLs that include
2857 Builder names, so that builders can include characters like '/'
2858 and ' ' without completely breaking the resulting HTML. Thanks to
2859 Kevin Turner for the patch.
2860 * buildbot/status/html.py: same
2861 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2863 * NEWS: update in preparation for upcoming release
2865 2006-01-18 Brian Warner <warner@lothar.com>
2867 * docs/examples/twisted_master.cfg: update to match the Twisted
2868 buildbot: remove python2.2, switch to exarkun's buildslaves,
2869 disable the .deb builder until we figure out how to build twisted
2870 .debs from SVN, add some ktrace debugging to the OS-X build
2871 process and remove the qt build, remove threadless builders,
2872 change freebsd builder to use landonf's buildslave.
2874 2006-01-12 Brian Warner <warner@lothar.com>
2876 * buildbot/master.py (Manhole.__init__): let port= be a strports
2877 specification string, but handle a regular int for backwards
2878 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2879 used in master.cfg to limit connections to just the local host.
2880 (BuildMaster.loadConfig): same for c['slavePortnum']
2881 * buildbot/scheduler.py (Try_Userpass.__init__): same
2882 * buildbot/status/client.py (PBListener.__init__): same
2883 * buildbot/status/html.py (Waterfall.__init__): same, for both
2884 http_port and distrib_port. Include backwards-compatibility checks
2885 so distrib_port can be a filename string and still mean unix:/foo
2886 * docs/buildbot.texinfo (Setting the slaveport): document it
2887 (Debug options): same
2888 (HTML Waterfall): same
2891 * buildbot/test/test_config.py (ConfigTest): test it
2893 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2894 slaveport's disownServiceParent deferred to fire before opening
2895 the new one. Fixes an annoying bug in the unit tests.
2897 2006-01-03 Brian Warner <warner@lothar.com>
2899 * buildbot/master.py (BuildMaster): remove the .schedulers
2900 attribute, replacing it with an allSchedulers() method that looks
2901 for all IService children that implement IScheduler. Having only
2902 one parent/child relationship means fewer opportunities for bugs.
2903 (BuildMaster.allSchedulers): new method
2904 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2905 also fix ugly bug that caused any config-file reload to
2906 half-forget about the earlier Schedulers, causing an exception
2907 when a Change arrived and was handed to a half-connected
2908 Scheduler. The exception was in scheduler.py line 54ish:
2909 self.parent.submitBuildSet(bs)
2910 exceptions.AttributeError: 'NoneType' object has no attribute
2912 (BuildMaster.addChange): update to use allSchedulers()
2914 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2915 to work properly with twisted-1.3.0, where you must explicitly
2916 include the __implements__ from parent classes
2917 (BaseScheduler.__repr__): make it easier to distinguish distinct
2919 (BaseUpstreamScheduler.__implements__): same
2921 * buildbot/status/builder.py (Status.getSchedulers): update to
2923 * buildbot/test/test_run.py (Run.testMaster): same
2924 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2925 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2926 make sure Scheduler instances are left alone when an identical
2927 config file is reloaded
2928 (ConfigElements.testSchedulers): make sure Schedulers are properly
2931 * Makefile (TRIALARGS): my local default Twisted version is now
2932 2.1.0, update the trial arguments accordingly
2934 2005-12-22 Brian Warner <warner@lothar.com>
2936 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2939 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2940 addChange in the parent class, although I suspect this should be
2941 fixed better in the future.
2943 2005-11-26 Brian Warner <warner@lothar.com>
2945 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2946 explode when branch==None, thanks to Kevin Turner for the catch
2947 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2950 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2952 * docs/buildbot.texinfo: same
2954 2005-11-26 Brian Warner <warner@lothar.com>
2956 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2957 * docs/buildbot.texinfo: set version number to match
2959 2005-11-26 Brian Warner <warner@lothar.com>
2961 * NEWS: update for 0.7.1
2963 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2964 sure that unsubscribe works even if we never sent an ETA update.
2965 Also, don't explode on duplicate unsubscribe.
2966 (BuildStepStatus.addLog): make the convenience "return self"-added
2967 watcher automatically unsubscribe when the Step finishes.
2968 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2969 (BuildStatus.stepStarted): same auto-unsubscribe
2970 (BuilderStatus.buildStarted): same auto-unsubscribe
2972 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2974 (IStatusReceiver.stepStarted): same
2975 (IStatusReceiver.logStarted): same
2977 * buildbot/test/test_run.py (Status): move the Status test..
2978 * buildbot/test/test_status.py (Subscription): .. to here
2980 2005-11-25 Brian Warner <warner@lothar.com>
2982 * NEWS: more updates
2984 * buildbot/locks.py: fix the problem in which loading a master.cfg
2985 file that changes some Builders (but not all of them) can result
2986 in having multiple copies of the same Lock. Now, the real Locks
2987 are kept in a table inside the BotMaster, and the Builders/Steps
2988 use "LockIDs", which are still instances of MasterLock and
2989 SlaveLock. The real Locks are instances of the new RealMasterLock
2990 and RealSlaveLock classes.
2991 * buildbot/master.py (BotMaster.getLockByID): new method to
2992 convert LockIDs into real Locks.
2993 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2994 into real Locks before building
2995 * buildbot/process/step.py (BuildStep.startStep): same
2996 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2997 exercises the problem
3000 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
3001 what Schedulers are available
3003 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
3004 work by Dobes Vandermeer and hacked mercilessly by me. This offers
3005 'cron'-style build scheduling at certain times of day, week,
3007 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
3009 * buildbot/scheduler.py (Scheduler): change fileIsImportant
3010 handling: treat self.fileIsImportant more as an attribute that
3011 contains a callable than as a method. If the attribute is None,
3012 don't call it and assume all filenames are important. It is still
3013 possible to provide a fileIsImportant method in a subclass,
3015 (AnyBranchScheduler): handle fileIsImportant=None, previously it
3017 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
3018 test using AnyBranchScheduler with fileIsImportant=None
3020 2005-11-24 Brian Warner <warner@lothar.com>
3022 * buildbot/test/test_config.py (StartService): don't claim a fixed
3023 port number, instead set slavePort=0 on the first pass, figure out
3024 what port was allocated, then switch to a config file that uses
3027 * buildbot/master.py (BuildMaster.loadConfig): close the old
3028 slaveport before opening the new one, because unit tests might
3029 replace slavePort=0 with the same allocated portnumber, and if we
3030 don't wait for the old port to close first, we get a "port already
3031 in use" error. There is a tiny race condition here, but the only
3032 threat is from other programs that bind (statically) to the same
3033 port number we happened to be allocated, and only if those
3034 programs use SO_REUSEADDR, and only if they get control in between
3037 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
3039 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
3040 deleted ChangeSources before adding any new ones
3041 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
3042 compare_attrs, to make sure that a config-file reload does not
3043 unnecessarily replace an unmodified ChangeSource instance
3044 * buildbot/test/test_config.py (ConfigTest.testSources): update
3046 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
3047 mean "don't build anything", and add a warning if it gets used
3048 because it isn't actually useful.
3050 * contrib/svn_buildbot.py: update example usage to match the port
3051 number that gets used by the PBChangeSource
3052 * buildbot/scripts/sample.cfg: add example of PBChangeSource
3054 2005-11-22 Brian Warner <warner@lothar.com>
3056 * NEWS: start collecting items for next release
3058 * buildbot/process/step.py (SVN.computeSourceRevision): assume
3059 revisions are strings
3060 (P4Sync.computeSourceRevision): same
3062 * buildbot/status/html.py (StatusResourceBuild.body): add a link
3063 to the Buildbot's overall status page
3064 (StatusResourceBuilder.body): same
3066 2005-11-15 Brian Warner <warner@lothar.com>
3068 * buildbot/master.py (BuildMaster.loadConfig): serialize the
3069 config-file loading, specifically to make sure old StatusTargets
3070 are finished shutting down before new ones start up (thus
3071 resolving a bug in which changing the Waterfall object would fail
3072 because both new and old instances were claiming the same
3073 listening port). Also load new Schedulers after all the new
3074 Builders are set up, in case they fire off a new build right away.
3075 * buildbot/test/test_config.py (StartService): test it
3077 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
3078 the branch name to the mail body
3080 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
3081 Without it, a config-file reload fails to update an existing
3083 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
3084 username/passwd to compare_attrs, for the same reason
3085 * buildbot/status/html.py (Waterfall): add favicon to
3086 compare_attrs, same reason
3088 2005-11-05 Brian Warner <warner@lothar.com>
3090 * buildbot/scripts/tryclient.py (createJobfile): stringify the
3091 baserev before stuffing it in the jobfile. This resolves problems
3092 under SVN (and probably Arch) where revisions are expressed as
3093 numbers. I'm inclined to use string-based revisions everywhere in
3094 the future, but this fix should be safe for now. Thanks to Steven
3095 Walter for the patch.
3097 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
3098 binary mode when opening pickle files, to make windows work
3099 better. Thanks to Dobes Vandermeer for the catch.
3100 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3101 (BuilderStatus.getBuildByNumber): same
3102 (Status.builderAdded): same
3103 * buildbot/master.py (BuildMaster.loadChanges): same
3105 * buildbot/util.py (Swappable): delete unused leftover code
3107 * buildbot/process/step.py (SVN): when building on a non-default
3108 branch, add the word "[branch]" to the VC step's description, so
3109 it is obvious that we're not building the usual stuff. Likewise,
3110 when we are building a specific revision, add the text "rNNN" to
3111 indicate what that revision number is. Thanks to Brad Hards and
3112 Nathaniel Smith for the suggestion.
3113 (Darcs.startVC): same
3114 (Arch.startVC): same
3115 (Bazaar.startVC): same
3117 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3118 typo, caught by Mark Dillavou, closes SF#1216636.
3120 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3121 about a test to add some day
3123 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3124 the 'full-2.3' build, and the 'reactors' build is now run under
3125 python-2.4 because the buildslave no longer has gtk/etc bindings
3126 for earlier versions.
3128 2005-11-03 Brian Warner <warner@lothar.com>
3130 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3131 method, takes an IBuildStatus and rebuilds it. It might make more
3132 sense to add this to IBuildControl instead, but that instance goes
3133 away completely once the build has finished, and resubmitting
3134 builds can take place weeks later.
3135 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3136 * buildbot/status/html.py (StatusResourceBuild): also stash an
3137 IBuilderControl so we can use resubmitBuild.
3138 (StatusResourceBuild.body): render "resubmit" button if we can.
3139 Also add hrefs for each BuildStep
3140 (StatusResourceBuild.rebuild): add action for "resubmit" button
3141 (StatusResourceBuilder.getChild): give it an IBuilderControl
3143 * buildbot/status/builder.py (Status.getURLForThing): change the
3144 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3145 that live as targets of buttons like "stop" and "rebuild" can't
3147 * buildbot/status/builder.py (Status.getURLForThing): same
3148 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3149 (StepBox.getBox): same
3150 * buildbot/test/test_web.py (GetURL): same
3153 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3154 exclusivity checks after Source.__init__ upcall, so misspelled
3155 arguments will be reported more usefully
3156 (Darcs.__init__): same
3158 2005-10-29 Brian Warner <warner@lothar.com>
3160 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3161 builder. Move the Try scheduler off to a separate port.
3163 2005-10-27 Brian Warner <warner@lothar.com>
3165 * buildbot/clients/gtkPanes.py
3166 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3167 to cause the app to crash, now they don't.
3169 * buildbot/clients/debug.py: display the buildmaster's location
3170 in the window's title bar
3172 2005-10-26 Brian Warner <warner@lothar.com>
3174 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3175 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3176 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3178 * buildbot/status/html.py (td): put a single non-breaking space
3179 inside otherwise empty <td> elements, as a workaround for buggy
3180 browsers which would optimize them away (along with any associated
3181 styles, like the kind that create the waterfall grid borders).
3182 Patch from Frerich Raabe.
3184 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3185 argv-list as an argument, defaulting to ["-to"], which is
3186 appropriate for the Trial that comes with Twisted-2.1.0 and
3187 earlier. The Trial in current Twisted SVN wants
3188 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3189 defaults to an empty list.
3190 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3191 match it, now that trialMode= is a list instead of a single string
3193 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3195 * docs/buildbot.texinfo: same
3197 2005-10-24 Brian Warner <warner@lothar.com>
3199 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3200 * docs/buildbot.texinfo: set version number to match
3202 2005-10-24 Brian Warner <warner@lothar.com>
3204 * README: update for 0.7.0
3206 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3208 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3209 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3210 send the branch= argument unless the user really provided one, to
3211 retain compatibility with older buildmasters that don't accept
3213 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3216 * docs/buildbot.texinfo: update lots of stuff
3218 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3219 to the 'buildbot sendchange' command
3220 * buildbot/clients/sendchange.py (Sender.send): same
3221 * buildbot/changes/pb.py (ChangePerspective): same
3222 * buildbot/test/test_changes.py (Sender.testSender): test it
3224 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3225 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3226 for consistency with other BuildStep arguments that use camelCase.
3227 Well, at least more of them use camelCase (like flunkOnWarnings)
3228 than don't.. I wish I'd picked one style and stuck with it
3229 earlier. Annoying, but it's best done before the release, since
3230 these arguments didn't exist at all in 0.6.6 .
3232 * buildbot/test/test_vc.py (SVN.testCheckout): same
3233 (Darcs.testPatch): same
3234 * docs/buildbot.texinfo (SVN): document the change
3235 (Darcs): same, add some build-on-branch docs
3236 * docs/examples/twisted_master.cfg: match change
3238 * buildbot/process/step.py (BuildStep): rename
3239 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3240 how it is normally used.
3241 * buildbot/test/test_steps.py (Version.checkCompare): same
3243 * buildbot/process/step.py (CVS.startVC): refuse to build
3244 update/copy -style builds on a non-default branch with an old
3245 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3246 concern is that it will do a VC 'update' in an existing tree when
3247 it is supposed to be switching branches (and therefore clobbering
3248 the tree to do a full checkout), thus building the wrong source.
3249 This used to be a warning, but I think the confusion it is likely
3250 to cause warrants making it an error.
3251 (SVN.startVC): same, also make mode=export on old slaves an error
3252 (Darcs.startVC): same
3253 (Git.startVC): improve error message for non-Git-enabled slaves
3254 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3255 specific revision is built on a slave that doesn't pay attention
3256 to args['revision'], because for slowly-changing trees it will
3257 probably do the right thing, and because we have no way to tell
3258 whether we're asking it to build the most recent version or not.
3259 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3261 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3262 that 'master' is in host:portnum format, to catch errors sooner
3264 2005-10-23 Brian Warner <warner@lothar.com>
3266 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3267 when creating the list of warning messages, include the line
3268 immediately after each WARNING: line, since that's usually where
3269 the file and line number wind up.
3271 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3276 2005-10-22 Brian Warner <warner@lothar.com>
3278 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3279 patch from Brad Hards
3280 * buildbot/status/classic.css: same
3281 * buildbot/test/test_web.py (Waterfall): match changes
3283 * buildbot/test/test_steps.py (BuildStep.setUp): set
3284 nextBuildNumber so the test passes
3285 * buildbot/test/test_status.py (MyBuilder): same
3287 * buildbot/status/html.py (StatusResourceBuild.body): revision
3288 might be numeric, so stringify it before html-escapifying it
3289 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3290 timer for the upcoming build
3291 * buildbot/status/classic.css: add background-color attributes for
3292 offline/waiting/building classes
3294 * buildbot/status/builder.py (BuildStatus): derive from
3295 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3296 the default (i.e. unknown) .slavename to "???" instead of None,
3297 since even unknown slavenames need to be printed eventually.
3298 (BuilderStatus): also derive from styles.Versioned . More
3299 importantly, determine .nextBuildNumber at creation/unpickling
3300 time by scanning the directory of saved BuildStatus instances and
3301 choosing one larger than the highest-numbered one found. This
3302 should fix the problem where random errors during upgrades cause
3303 the buildbot to forget about earlier builds. .nextBuildNumber is
3304 no longer stored in the pickle.
3305 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3306 at least log the error. Also call Builder.determineNextBuildNumber
3307 once the basedir is set.
3309 * buildbot/master.py (BuildMaster.loadChanges): do
3310 styles.doUpgrade afterwards, in case I decide to make Changes
3311 derived from styles.Versioned some day and forget to make this
3315 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3316 when running under older pythons (<2.3) in which the shlex module
3317 doesn't have a 'split' function.
3319 * buildbot/process/step.py (ShellCommand.start): make
3320 errorMessages= be a list of strings to stuff in the log before the
3321 command actually starts. This makes it easier to flag multiple
3322 warning messages, e.g. when the Source steps have to deal with an
3324 (CVS.startVC): handle slaves that don't handle multiple branches
3325 by switching into 'clobber' mode
3326 (SVN.startVC): same. Also reject branches without base_url
3327 (Darcs.startVC): same. Also reject revision= in older slaves
3328 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3329 (Bazaar.startVC): same, and test for baz separately than for arch
3331 * buildbot/slave/commands.py (cvs_ver): document new features
3333 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3334 (BuildStep.slaveVersionNewEnough): more useful utility method
3335 * buildbot/test/test_steps.py (Version): start testing it
3337 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3338 the 'force' command requires python2.3, for the shlex.split method
3340 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3341 since we don't use it anymore. The Twisted buildbot uses a
3344 2005-10-21 Brian Warner <warner@lothar.com>
3346 * buildbot/process/process_twisted.py: rework all BuildFactory
3347 classes to take a 'source' step as an argument, instead of
3348 building up the SVN instance in the factory.
3349 * docs/examples/twisted_master.cfg: enable build-on-branch by
3350 providing a base_url and default_branch
3352 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3353 control over --branch and --revision, not that they are always
3355 * buildbot/status/html.py (StatusResourceBuilder.force): same
3356 (StatusResourceBuild.body): display SourceStamp components
3358 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3359 IRC 'force' command, so it can be shared with an eventual
3360 command-line-tool 'buildbot force' mode.
3361 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3363 2005-10-20 Brian Warner <warner@lothar.com>
3365 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3367 * docs/examples/twisted_master.cfg: update to use Schedulers
3369 * buildbot/scripts/sample.cfg: update with Schedulers
3371 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3372 method specifically for use by HTML "force build" button and the
3373 IRC "force" command. Raises an immediate error if there are no
3375 (IBuilderControl.requestBuild): make this just submit a build, not
3376 try to check for existing slaves or set up any when-finished
3377 Deferreds or anything.
3378 * buildbot/process/builder.py (BuilderControl): same
3379 * buildbot/status/html.py (StatusResourceBuilder.force): same
3380 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3381 * buildbot/test/test_slaves.py: same
3382 * buildbot/test/test_web.py: same
3384 2005-10-19 Brian Warner <warner@lothar.com>
3386 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3387 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3389 2005-10-18 Brian Warner <warner@lothar.com>
3391 * buildbot/status/html.py: provide 'status' argument to most
3392 StatusResourceFOO objects
3393 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3394 and Logfiles" section to make the Build page into a more-or-less
3395 comprehensive source of status information about the build
3397 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3398 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3400 2005-10-17 Brian Warner <warner@lothar.com>
3402 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3403 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3404 out what to do about other projects: the correct options for
3405 recent Twisteds will not work for older ones.
3407 2005-10-15 Brian Warner <warner@lothar.com>
3409 * buildbot/status/builder.py (Status.getURLForThing): add method
3410 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3411 use this in email/IRC status clients to make them more useful, by
3412 providing the end user with hints on where to learn more about the
3413 object being reported on.
3414 * buildbot/test/test_web.py (GetURL): tests for it
3416 2005-10-14 Brian Warner <warner@lothar.com>
3418 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3419 fix bug resulting from deferredResult changes
3421 2005-10-13 Brian Warner <warner@lothar.com>
3423 * buildbot/test/test_changes.py: remove use of deferredResult
3424 * buildbot/test/test_config.py: same
3425 * buildbot/test/test_control.py: same
3426 * buildbot/test/test_status.py: same
3427 * buildbot/test/test_vc.py: this is the only remaining use, since
3428 it gets used at module level. This needs to be replaced by some
3429 sort of class-level run-once routine.
3431 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3433 * lots: implement multiple slaves per Builder, which means multiple
3434 current builds per Builder. Some highlights:
3435 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3436 of (state,currentBuilds) instead of (state,currentBuild)
3437 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3438 (IBuildStatus.getSlavename): new method, so you can tell which
3439 slave got used. This only gets set when the build completes.
3440 (IBuildRequestStatus.getBuilds): new method
3442 * buildbot/process/builder.py (SlaveBuilder): add a .state
3443 attribute to track things like ATTACHING and IDLE and BUILDING,
3445 (Builder): .. the .slaves attribute here, which has been turned
3446 into a simple list of available slaves. Added a separate
3447 attaching_slaves list to track ones that are not yet ready for
3449 (Builder.fireTestEvent): put off the test-event callback for a
3450 reactor turn, to make tests a bit more consistent.
3451 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3452 ping fails due to an exception. This needs work, I'm worried that
3453 a code error could lead to a constantly re-connecting slave.
3454 Especially since I'm trying to move to a distinct remote_ping
3455 method, separate from the remote_print that we currently use.
3456 (BuilderControl.requestBuild): return a convenience Deferred that
3457 provides an IBuildStatus when the build finishes.
3458 (BuilderControl.ping): ping all connected slaves, only return True
3459 if they all respond.
3461 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3462 reconnect when we shut down.
3464 * buildbot/status/builder.py: implement new methods, convert
3465 one-build-at-a-time methods to handle multiple builds
3466 * buildbot/status/*.py: do the same in all default status targets
3467 * buildbot/status/html.py: report the build's slavename in the
3468 per-Build page, report all buildslaves on the per-Builder page
3470 * buildbot/test/test_run.py: update/create tests
3471 * buildbot/test/test_slaves.py: same
3472 * buildbot/test/test_scheduler.py: remove stale test
3474 * docs/buildbot.texinfo: document the new builder-specification
3475 'slavenames' parameter
3477 2005-10-12 Brian Warner <warner@lothar.com>
3479 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3480 report failure correctly, causing Dependent builds to run when
3481 they shouldn't have.
3482 * buildbot/status/builder.py (BuildSetStatus): same
3483 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3484 (Set.testSuccess): test the both-pass case too
3485 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3486 fix this test: it was ending too early, masking the failure before
3487 (Logger): specialized StatusReceiver to make sure the dependent
3488 builds aren't even started, much less completed.
3490 2005-10-07 Brian Warner <warner@lothar.com>
3492 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3493 bot.SlaveBuilder being disowned in the middle of a build
3495 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3496 this inherit from StatusReceiver. Also upcall in __init__. This
3497 fixes the embarrasing crash when the new buildSetSubmitted method
3498 is invoked and Waterfall/etc don't implement their own.
3499 * buildbot/test/test_run.py: add a TODO note about a test to catch
3500 just this sort of thing.
3502 * buildbot/process/builder.py (Builder.attached): remove the
3503 already-attached warning, this situation is normal. Add some
3504 comments explaining it.
3506 2005-10-02 Brian Warner <warner@lothar.com>
3508 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3509 OverflowError when setting up dnotify, because some 64-bit systems
3510 have problems with signed-vs-unsigned constants and trip up on the
3511 DN_MULTISHOT flag. Patch from Brad Hards.
3513 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3515 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3516 progressMetrics, description, descriptionDone to the 'parms' list,
3517 and make use the 'parms' list from the implementation class
3518 instead of only BuildStep to initialize the parameters. This
3519 allows buildbot.process.factory.s() to initialize all the parms,
3520 not just those defined in directly by BuildStep.
3522 2005-09-03 Brian Warner <warner@lothar.com>
3524 * NEWS: start adding items for the next release
3526 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3527 python2.2 tests, change 'Quick' builder to only use python2.3
3529 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3531 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3532 the "Ping Builder" button if the build control is available; the
3533 user sees an exception otherwise
3535 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3537 2005-09-01 Brian Warner <warner@lothar.com>
3539 * buildbot/interfaces.py (IBuilderStatus.getState): update
3540 signature, point out that 'build' can be None
3541 (IBuildStatus.getETA): point out ETA can be none
3543 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3545 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3547 2005-08-31 Brian Warner <warner@lothar.com>
3549 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3550 update to match correct signature: removed 'eta' argument
3551 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3553 2005-08-30 Brian Warner <warner@lothar.com>
3555 * buildbot/status/builder.py (LogFile): remove the assertion that
3556 blows up when you try to overwrite an existing logfile, instead
3557 just emit a warning. This case gets hit when the buildmaster is
3558 killed and doesn't get a chance to write out the serialized
3559 BuilderStatus object, so the .nextBuildNumber attribute gets out
3562 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3563 the 'buildbot sendchange' arguments, for the Darcs context file
3564 * docs/buildbot.texinfo (sendchange): document it
3566 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3567 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3568 (IStatus.getSchedulers): new method
3569 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3570 (Status.getSchedulers): implement
3571 * buildbot/process/builder.py (Builder): maintain
3572 BuilderStatus.pendingBuilds
3573 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3574 (TryBase.addChange): Try schedulers should ignore Changes
3576 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3577 for 'try' on CVS/SVN
3578 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3580 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3581 report status properly.
3582 (Try.createJob): implement unique buildset IDs
3584 * buildbot/status/client.py (StatusClientPerspective): add a
3585 perspective_getBuildSets method for the benefit of jobdir-style
3587 * docs/buildbot.texinfo (try): more docs
3588 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3591 2005-08-18 Brian Warner <warner@lothar.com>
3593 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3594 actually work. It's functional but still kind of clunky. Also, it
3595 only works with the pb-style.. needs to be made to work with the
3598 * buildbot/status/client.py (RemoteBuildSet): new class
3599 (RemoteBuildRequest): same
3600 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3601 object, not the internal BuildStatus object.
3602 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3603 outside of the usual buildStarted() return value.
3604 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3606 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3607 (Try_Userpass_Perspective.perspective_try): return a remotely
3608 usable BuildSetStatus object
3610 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3611 isStarted()/waitUntilStarted()
3613 2005-08-16 Brian Warner <warner@lothar.com>
3615 * buildbot/status/builder.py: implement IBuildSetStatus and
3616 IBuildRequestStatus, wire them into place.
3617 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3618 methods into the BuildSetStatus object.
3619 * buildbot/interfaces.py: same
3620 (IStatus.getBuildSets): new method to get pending BuildSets
3621 (IStatusReceiver.buildsetSubmitted): new method which hears about
3623 * buildbot/master.py (BuildMaster.submitBuildSet): same
3624 * buildbot/process/base.py (BuildRequest): same, replace
3625 waitUntilStarted with subscribe/unsubscribe
3626 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3627 subscribe instead of waitUntilStarted
3628 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3630 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3632 * buildbot/test/test_buildreq.py: update for new code
3633 * buildbot/test/test_control.py (Force.testRequest): same
3636 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3637 for Darcs to not use the tempfile module, so it works under
3638 python-2.2 too. We really didn't need the full cleverness of that
3639 module, since the slave has exclusive control of its own builddir.
3641 2005-08-15 Brian Warner <warner@lothar.com>
3643 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3644 for CVS trees. It doesn't work for non-trunk branches,
3646 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3649 * Makefile: make it easier to test against python2.2
3651 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3652 tearDown2, so things like Arch can unregister archives as they're
3653 shutting down. The previous subclass-override-tearDown technique
3654 resulted in a nested maybeWait() and test failures under
3657 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3658 where we can (Arch), add a branch= argument to set the branch used
3660 (BazExtractor): extract the branch too
3661 (TlaExtractor): same
3662 * buildbot/scripts/runner.py (TryOptions): add --branch
3663 * docs/buildbot.texinfo (try): document --branch/try_branch
3665 * buildbot/slave/commands.py (Darcs): implement get-revision for
3666 Darcs, so that 'try' will work. This requires the tempfile module
3669 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3670 of revisions, branches, and 'try' in the process.
3672 2005-08-11 Brian Warner <warner@lothar.com>
3674 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3675 this, it got broken at some point in the last few releases
3676 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3677 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3678 specifically the removal of ETA information from the tuple
3680 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3683 * docs/buildbot.texinfo (try): document both --builder and
3684 'try_builders' in .buildbot/options
3685 * buildbot/scripts/runner.py (TryOptions): add --builder,
3686 accumulate the values into opts['builders']
3687 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3688 * buildbot/test/test_runner.py (Try): add some quick tests to make
3689 sure 'buildbot try --options' and .buildbot/options get parsed
3690 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3691 use --builder control
3693 * docs/buildbot.texinfo (try): add --port argument to PB style
3695 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3696 actual SourceStamp. Still need to extract a branch name, somehow.
3697 (Try): finish implementing the try client side, still need a UI
3698 for specifying which builders to use
3699 (Try.getopt): factor our options/config-file reading
3700 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3702 * buildbot/test/test_vc.py: match SourceStampExtractor change
3704 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3705 causes the twisted log to be sent to stderr
3707 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3709 2005-08-10 Brian Warner <warner@lothar.com>
3711 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3712 style is 90% done, still missing status reporting or waiting for
3713 the buildsets to finish, and it is completely untested.
3715 * buildbot/trybuild.py: delete file, move contents to ..
3716 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3717 * buildbot/test/test_vc.py: match the move
3719 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3720 of the TryScheduler, no buildsetID or status-tracking support yet
3721 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3723 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3724 possible to set the basedir after __init__ time, so it is easier
3725 to use as a Service-child of the BuildMaster instance
3727 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3728 that delivers messages to its Service parent instead of requiring
3729 a subclass to be useful. This turns out to be much easier to build
3732 * buildbot/scripts/tryclient.py (createJob): utility code to
3733 create jobfiles, will eventually be used by 'buildbot try'
3735 2005-08-08 Brian Warner <warner@lothar.com>
3737 * docs/buildbot.texinfo (try): add docs on the
3738 as-yet-unimplemented Try scheduler
3740 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3741 * buildbot/test/test_scheduler.py: .. here
3742 (Scheduling.testTryJobdir): add placeholder test for 'try'
3744 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3745 addEntry merging (>=chunkSize) behavior
3746 (Log.testConsumer): update to handle new callLater(0) behavior
3748 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3749 both the MAX_LENGTH bugfix and the resumeProducing hang.
3751 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3752 put off the actual resumeProducing for a moment with
3753 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3754 causes large logfiles to hang midway through.
3756 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3757 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3758 and to improve memory usage when streaming the file out to a web
3760 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3761 make this work cleanly
3763 2005-08-03 Brian Warner <warner@lothar.com>
3765 * buildbot/trybuild.py: new file for 'try' utilities
3766 (getSourceStamp): run in a tree, find out the baserev+patch
3767 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3768 implemented for SVN and Darcs, still working on Arch. I don't know
3769 how to make CVS work yet.
3771 * docs/buildbot.texinfo: document the 'buildbot' command-line
3772 tool, including the not-yet-implemented 'try' feature, and the
3773 in-flux .buildbot/ options directory.
3775 2005-07-20 Brian Warner <warner@lothar.com>
3777 * buildbot/locks.py: added temporary id() numbers to Lock
3778 descriptions, to track down a not-really-sharing-the-Lock bug
3780 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3782 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3783 needed for python2.2 compatibility
3784 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3785 are from the __future__
3787 2005-07-19 Brian Warner <warner@lothar.com>
3789 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3790 message when schedulers use unknown builders
3792 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3793 SlaveLock('name') and MasterLock('name') are distinct
3795 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3796 c['schedulers'] in such a way that we can actually accept
3798 * buildbot/test/test_config.py: check it
3800 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3801 utility method to *all* the Schedulers
3802 (Periodic.listBuilderNames): same
3804 * docs/buildbot.texinfo (Interlocks): update chapter to match
3807 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3808 to make sure that c['sources'], c['schedulers'], and c['status']
3809 are all lists of the appropriate objects, and that the Schedulers
3810 all point to real Builders
3811 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3812 'listBuilderNames' utility method to support this
3813 * buildbot/scheduler.py: implement the utility method
3814 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3816 * docs/buildbot.texinfo: add some @cindex entries
3818 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3819 if it wasn't already set: most tla commands will fail unless one
3821 (Arch.createRepository): and disable bazaar's revision cache, since
3822 they cause test failures (the multiple repositories we create all
3823 interfere with each other through the cache)
3825 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3826 bring it properly up to date with twisted-2.0 test guidelines
3828 * buildbot/master.py (BuildMaster): remove references to old
3829 'interlock' module, this caused a bunch of post-merge test
3831 * buildbot/test/test_config.py: same
3832 * buildbot/process/base.py (Build): same
3834 * buildbot/test/test_slaves.py: stubs for new test case
3836 * buildbot/scheduler.py: add test-case-name tag
3837 * buildbot/test/test_buildreq.py: same
3839 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3840 unnecessary init code
3841 (Bot.remote_setBuilderList): match it
3843 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3845 * buildbot/changes/mail.py (parseSyncmail): update comment
3847 * buildbot/test/test_slavecommand.py: disable Shell tests on
3848 platforms that don't suport IReactorProcess
3850 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3851 all places where we open logfiles. It causes OS-X to open the file
3852 in some weird mode that that prevents us from mixing reads and
3853 writes to the same filehandle, which we depend upon to implement
3854 _generateChunks properly. This change doesn't appear to break
3855 win32, on which "b" and "t" are treated differently but a missing
3856 flag seems to be interpreted as "t".
3858 2005-07-18 Brian Warner <warner@lothar.com>
3860 * buildbot/slave/commands.py (ShellCommand): overhaul
3861 error-handling code, to try and make timeout/interrupt work
3862 properly, and make win32 happier
3863 * buildbot/test/test_slavecommand.py: clean up, stop using
3864 reactor.iterate, add tests for timeout and interrupt
3865 * buildbot/test/sleep.py: utility for a new timeout test
3867 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3868 code from the local-usebranches branch
3870 2005-07-17 Brian Warner <warner@lothar.com>
3872 * buildbot/process/process_twisted.py
3873 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3874 minutes, to match the other twisted BuildFactories, and don't
3875 excuse failures in c/qt/win32 reactors any more.
3877 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3878 'freebsd' builders, since the buildslaves have been unavailable
3881 2005-07-13 Brian Warner <warner@lothar.com>
3883 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3884 build-on-branch feature
3886 * buildbot/process/step.py (Darcs.__init__): add base_url and
3887 default_branch arguments, just like SVN
3888 (Arch.__init__): note that the version= argument is really the
3891 * buildbot/slave/commands.py (SourceBase): keep track of the
3892 repository+branch that was used for the last checkout in
3893 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3894 match, we clobber the directory and perform a fresh checkout
3895 rather than trying to do an in-place update. This should protect
3896 us against trying to get to branch B by doing an update in a tree
3897 obtained from branch A.
3898 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3899 (SVN.setup): same, just the svnurl
3900 (Darcs.setup): same, just the repourl
3901 (Arch.setup): same, arch coordinates (url), version, and
3902 buildconfig. Also pull the buildconfig from the args dictionary,
3903 which we weren't doing before, so the build-config was effectively
3905 (Arch.sourcedirIsUpdateable): don't try to update when we're
3906 moving to a specific revision: arch can't go backwards, so it is
3907 safer to just clobber the tree and checkout a new one at the
3909 (Bazaar.setup): same sourcedata as Arch
3911 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3912 use maybeWait, to work with twisted-1.3.0 and twcompat
3913 (Dependencies.testRun_Pass): same
3915 * buildbot/test/test_vc.py: rearrange, cleanup
3917 * buildbot/twcompat.py: add defer.waitForDeferred and
3918 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3919 can work under twisted-1.3.0 .
3921 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3922 now created at setUp time. This increases the runtime of the test
3923 suite considerably (from 91 seconds to 151), but it removes the
3924 need for an offline tarball, which should solve a problem I've
3925 seen where the test host has a different version of svn than the
3926 tarball build host. The new code also validates that mode=update
3927 really picks up recent commits. This approach will also make it
3928 easier to test out branches, because the code which creates the VC
3929 branches is next to the code which uses them. It will also make it
3930 possible to test some change-notification hooks, by actually
3931 performing a VC commit and watching to see the ChangeSource get
3934 2005-07-12 Brian Warner <warner@lothar.com>
3936 * docs/buildbot.texinfo (SVN): add branches example
3937 * docs/Makefile (buildbot.ps): add target for postscript manual
3939 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3940 * buildbot/test/test_locks.py: same
3942 * buildbot/process/step.py (Darcs): comment about default branches
3944 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3945 c['interlocks'] in the config file, complain if it is present.
3946 Scan all locks in c['builders'] to make sure the Locks they use
3948 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3949 add some tests to check for non-uniquely-named Locks
3950 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3951 since the unique-Lock validation code requires it now
3953 * buildbot/locks.py: fix test-case-name
3955 * buildbot/interlock.py: remove old file
3957 2005-07-11 Brian Warner <warner@lothar.com>
3959 * buildbot/test/test_interlock.py: rename to..
3960 * buildbot/test/test_locks.py: .. something shorter
3962 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3963 versions (after 2.0.1) changed internet.TCPClient to shut down the
3964 connection in stopService. Change the code to handle this
3967 * buildbot/process/base.py (Build): handle whole-Build locks
3968 * buildbot/process/builder.py (Builder.compareToSetup): same
3969 * buildbot/test/test_interlock.py: make tests work
3971 * buildbot/process/step.py (BuildStep.startStep): complain if a
3972 Step tries to claim a lock that's owned by its own Build
3973 (BuildStep.releaseLocks): typo
3975 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3976 file reloads don't replace unchanged Builders
3978 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3979 rewrite to cover new Locks instead of old c['interlocks']
3980 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3984 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3985 start the master and connect the buildslave
3987 * buildbot/process/step.py (FailingDummy.done): finish with a
3988 FAILURE status rather than raising an exception
3990 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3991 stringify a BuildRequest.reason that is None
3993 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3995 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3996 allow scheduler.Dependent to work
3997 * buildbot/buildset.py (BuildSet): set .reason and .results
3999 * buildbot/test/test_interlock.py (Locks.setUp): connect both
4000 slaves, to make the test stop hanging. It still fails, of course,
4001 because I haven't even started to implement Locks.
4003 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
4005 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
4006 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
4007 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
4008 (Dependent): new class for downstream build dependencies
4009 * buildbot/test/test_dependencies.py: tests (still failing)
4011 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
4013 2005-07-07 Brian Warner <warner@lothar.com>
4015 * buildbot/test/runutils.py (RunMixin): factored this class out..
4016 * buildbot/test/test_run.py: .. from here
4017 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
4018 added new buildbot.locks tests (which all hang right now)
4019 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
4020 * buildbot/process/step.py: claim/release per-BuildStep locks
4022 * docs/Makefile: add 'buildbot.html' target
4024 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
4025 interpreted as "HEAD", so that all VC steps can accept branch=None
4026 and have it mean the "default branch".
4028 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
4030 2005-07-07 Brian Warner <warner@lothar.com>
4032 * docs/examples/twisted_master.cfg: update to match current usage
4034 * docs/buildbot.texinfo (System Architecture): comment out the
4035 image, it doesn't exist yet and just screws up the HTML manual.
4037 2005-07-05 Brian Warner <warner@lothar.com>
4039 * debian/.cvsignore: oops, missed one. Removing leftover file.
4041 2005-06-17 Brian Warner <warner@lothar.com>
4043 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
4044 changed its output in 1.2.0, don't mistakenly think that the
4045 subversion we find isn't capable of supporting our tests.
4047 * debian/*: remove the debian/ directory and its contents, to make
4048 life easier for the proper Debian maintainer
4050 * Makefile (release): same
4052 2005-06-07 Brian Warner <warner@lothar.com>
4054 * everything: create a distinct SourceStamp class to replace the
4055 ungainly 4-tuple, let it handle merging instead of BuildRequest.
4056 Changed the signature of Source.startVC to include the revision
4057 information (instead of passing it through self.args). Implement
4058 branches for SVN (now only Darcs/Git is missing support). Add more
4061 2005-06-06 Brian Warner <warner@lothar.com>
4063 * everything: rearrange build scheduling. Create a new Scheduler
4064 object (configured in c['schedulers'], which submit BuildSets to a
4065 set of Builders. Builders can now use multiple slaves. Builds can
4066 be run on alternate branches, either requested manually or driven
4067 by changes. This changed some of the Status classes. Interlocks
4068 are out of service until they've been properly split into Locks
4069 and Dependencies. treeStableTimer, isFileImportant, and
4070 periodicBuild have all been moved from the Builder to the
4072 (BuilderStatus.currentBigState): removed the 'waiting' and
4073 'interlocked' states, removed the 'ETA' argument.
4075 2005-05-24 Brian Warner <warner@lothar.com>
4077 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
4078 erroneously abandons the connection (in clientConnectionFailed)
4079 for non-UserErrors, which means that if we lose the connection due
4080 to a network problem or a timeout, we'll never try to reconnect.
4081 Fix this by not upcalling to the buggy parent method. Note:
4082 twisted-2.0 fixes this, but the function only has 3 lines so it
4083 makes more sense to copy it than to try and detect the buggyness
4084 of the parent class. Fixes SF#1207588.
4086 * buildbot/changes/changes.py (Change.branch): doh! Add a
4087 class-level attribute to accomodate old Change instances that were
4088 pickled before 0.6.5 (where .branch was added for new Changes).
4089 This fixes the exception that occurs when you try to look at an
4090 old Change (through asHTML).
4092 * buildbot/__init__.py (version): bump to 0.6.6+ while between
4095 2005-05-23 Brian Warner <warner@lothar.com>
4097 * buildbot/__init__.py (version): release 0.6.6
4099 2005-05-23 Brian Warner <warner@lothar.com>
4101 * NEWS: update for 0.6.6 release
4102 * debian/changelog: same
4104 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4105 before starting: this was done by twistd back when we spawned it,
4106 now that we're importing the pieces and running them in the
4107 current process, we have to do it ourselves. This allows
4108 master.cfg to import files from the same directory without
4109 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4110 Stichele for the catch.
4111 (Options.opt_version): Add a --version command (actually, just make
4112 the existing --version command emit Buildbot's version too)
4114 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4115 fix to make this behave like other LogFiles, this time to handle
4116 existing LogFiles on disk. (add the missing .upgrade method)
4117 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4119 2005-05-21 Brian Warner <warner@lothar.com>
4121 * buildbot/test/test_runner.py (Create.testMaster): match the
4122 rawstring change in runner.py:masterTAC
4124 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4125 TwistedWords is installed
4126 * buildbot/test/test_status.py: same, with TwistedMail
4128 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4129 some old, deprecated, and removed config keys). This should enable
4130 you to use the base buildbot functionality with Twisted-2.0.0 when
4131 you don't also have TwistedWeb and TwistedWords installed
4133 2005-05-20 Brian Warner <warner@lothar.com>
4135 * buildbot/scripts/runner.py (run): call sendchange(), not
4136 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4137 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4138 (stop): don't wait for process to die when sending SIGHUP
4139 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4140 directory name gets interpreted, which you don't want
4143 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4146 2005-05-18 Brian Warner <warner@lothar.com>
4148 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4150 2005-05-18 Brian Warner <warner@lothar.com>
4152 * README: update for 0.6.5
4153 * debian/changelog: same
4155 * buildbot/changes/changes.py: rename tag= to branch=, since
4156 that's how we're using it, and my design for the upcoming "build a
4157 specific branch" feature wants it. also, tag= was too CVS-centric
4158 * buildbot/changes/mail.py (parseSyncmail): same
4159 * buildbot/process/base.py (Build.isBranchImportant): same
4160 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4161 * docs/buildbot.texinfo (Attributes of Changes): same
4163 * NEWS: update tag=, update for upcoming release
4165 2005-05-17 Brian Warner <warner@lothar.com>
4167 * buildbot/scripts/runner.py (stop): actually poll once per
4168 second, instead of re-killing the poor daemon once per second.
4169 Sleep briefly (0.1s) before the first poll, since there's a good
4170 chance we can avoid waiting the full second if the daemon shuts
4171 down quickly. Also remove the sys.exit() at the end.
4172 (start): remove the unneighborly sys.exit()
4174 * Makefile: improve permission-setting to not kick Arch so badly
4176 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4177 default --keepalive=600, since it doesn't hurt very much, and it's
4178 a hassle to discover that you need it.
4179 * buildbot/test/test_runner.py (Create.testSlave): test it
4181 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4182 IRC bot about EXCEPTION
4184 * buildbot/status/client.py (PBListener): upcall more correctly
4186 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4187 an exception mark the overall build with EXCEPTION, not SUCCESS
4189 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4191 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4192 * Makefile: update some release-related stuff
4194 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4195 gets called when there isn't actually an active process, just end
4196 the Command instead of blowing up. I don't know how it gets into
4197 this state, but the twisted win32 buildslave will sometimes hang,
4198 and when it shakes its head and comes back, it thinks it's still
4199 running a Command. The next build causes this command to be
4200 interrupted, but the lack of self.process.pid breaks the interrupt
4203 * NEWS: document changes since the last release
4205 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4206 look for Makefile.buildbot instead of a bare Makefile . The
4207 'buildbot start' does not install this file, so you have to
4208 manually copy it if you want to customize startup behavior.
4209 (createMaster): change 'buildbot master' command to create
4210 Makefile.sample instead of Makefile, to create master.cfg.sample
4211 instead of master.cfg (requiring you to copy it before the
4212 buildmaster can be started). Both sample files are kept up to
4213 date, i.e. they are overwritten if they have been changed. The
4214 'buildbot.tac' file is *not* overwritten, but if the new contents
4215 don't match the old, a 'buildbot.tac.new' file is created and the
4216 user is warned. This seems to be a much more sane way to handle
4217 startup files. Also, don't sys.exit(0) when done, so we can run
4218 unit tests against it.
4219 (createSlave): same. Don't overwrite the sample info/ files.
4220 * buildbot/scripts/sample.mk: remove. the contents were pulled
4221 into runner.py, since they need to match the behavior of start()
4225 * docs/buildbot.texinfo (Launching the daemons): document it
4226 * buildbot/test/test_runner.py (Create): test it
4228 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4229 version that can handle string-in-string tests, because otherwise
4230 python-2.2 fails the tests. It'd be tremendous if Trial's test
4231 took two strings under 2.2 too.
4233 * everything: fixed all deprecation warnings when running against
4234 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4235 few that come from Twisted itself). This involved putting most of
4236 the Twisted-version specific code in the new buildbot.twcompat
4237 module, and creating some abstract base classes in
4238 buildbot.changes.base and buildbot.status.base (which might be
4239 useful anyway). __implements__ is a nuisance and requires an ugly
4240 'if' clause everywhere.
4242 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4243 delay before finishing the test: it seems that smtp.sendmail
4244 doesn't hang up on the server, so we must wait a moment so it can
4245 hang up on us. This removes the trial warning about an unclean
4248 2005-05-16 Brian Warner <warner@lothar.com>
4250 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4251 tuple of (delay, repeats).
4252 * buildbot/test/test_vc.py (Retry): test it
4253 * docs/buildbot.texinfo (Source Checkout): document it
4254 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4255 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4256 doVCFull() are handled by re-trying the checkout (after a delay)
4257 some number of times.
4258 (ShellCommand._startCommand): make header lines easier to read
4260 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4262 (WebTest.test_logfile): make sure master gets shut down, silences
4263 some "unclean reactor" test errors
4265 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4266 reactor once after shutdown, something in certain versions of
4267 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4268 fails, svn-trunk is ok.
4270 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4271 second win32 error message
4273 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4274 validating the ETA, so the tests don't fail on slow systems
4276 2005-05-15 Brian Warner <warner@lothar.com>
4278 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4279 the new LogFile class, so upgrading works properly
4280 (LogFileProducer.resumeProducing): survive resumeProducing after
4281 we've exhausted the chunkGenerator
4283 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4285 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4286 (Log.testUpgrade): same
4288 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4289 Builds and logs with a cron job.
4291 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4292 of the old non-offline LogFile, added code to upgrade these to
4293 new-style contents-live-on-disk instances at load time (in a way
4294 that doesn't invalidate the old Build pickles, so upgrading to
4295 0.6.5 is not a one-way operation). Got rid of everything related
4297 (LogFile.__init__): create LogFiles with the parent step status,
4298 the log's name, and a builder-relative filename where it can keep
4299 the contents on disk.
4300 (LogFile.hasContents): new method, clients are advised to call it
4301 before getText or getChunks and friends. If it returns False, the
4302 log's contents have been deleted and getText() will raise an
4304 (LogFile.getChunks): made it a generator
4305 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4306 Consumer (except one that takes chunks instead of strings). This
4307 enables streaming of very large logfiles without storing the whole
4309 (BuildStatus.generateLogfileName): create names like
4310 12-log-compile-output, with a _0 suffix if required to be unique
4311 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4312 or earlier) logfiles into new-style ones
4313 (BuilderStatus): remove everything related to 'stub' builds. There
4314 is now only one build cache, and we don't strip logs from old
4316 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4317 since we no longer fight to keep it in the cache
4319 * buildbot/status/html.py (TextLog.render_GET): use a
4320 ChunkConsumer to stream the log entries efficiently.
4321 (ChunkConsumer): wrapper which consumes chunks and writes
4324 * buildbot/test/test_twisted.py (Parse.testParse): use a
4325 LogFile-like object instead of a real one
4327 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4328 (Log.testMerge3): validate more merge behavior
4329 (Log.testChunks): validate LogFile.getChunks
4330 (Log.testUpgrade): validate old-style LogFile upgrading
4331 (Log.testSubscribe): validate LogFile.subscribe
4332 (Log.testConsumer): validate LogFile.subscribeConsumer
4334 * buildbot/interfaces.py (IStatusLogStub): remove
4335 (IStatusLog.subscribeConsumer): new method
4336 (IStatusLog.hasContents): new method
4337 (IStatusLogConsumer): describes things passed to subscribeConsumer
4339 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4340 the log contents if it does not have any contents.
4341 (StatusResourceBuildStep.body): same
4342 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4344 2005-05-14 Brian Warner <warner@lothar.com>
4346 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4347 timeouts to try and make the windows metabuildslave not hang
4349 2005-05-13 Mike Taylor <bear@code-bear.com>
4351 * buildbot/slave/commands.py (rmdirRecursive): added a check
4352 to ensure the path passed into rmdirRecursive actually exists.
4353 On win32 a non-existant path would generate an exception.
4355 2005-05-13 Brian Warner <warner@lothar.com>
4357 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4358 shutil.rmtree which behaves correctly on windows in the face of
4359 files that you have to chmod before deleting. Thanks to Bear at
4360 the OSAF for the routine.
4361 (SourceBase.doClobber): use rmdirRecursive
4363 2005-05-12 Brian Warner <warner@lothar.com>
4365 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4366 method generate chunks instead of returning a big list. This
4367 allows the same method to be used for both old LogFile and new
4369 (OfflineLogFile.getText): use the generator
4370 (OfflineLogFile.subscribe): same
4371 * buildbot/status/html.py (TextLog.resumeProducing): same
4372 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4374 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4375 point out that OfflineLogFile does not currently work with
4376 html.Waterfall . Fixing this is high-priority.
4378 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4379 apparently windows defaults to using stdout
4381 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4382 better message on failure so I can figure out the win32 problem
4384 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4385 log messages to include more useful copies of the command being
4386 run, the argv array, and the child command's environment.
4387 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4389 2005-05-11 Brian Warner <warner@lothar.com>
4391 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4393 * Makefile: update the deb-snapshot version
4395 * docs/buildbot.texinfo: move all .xhtml docs into a new
4396 .texinfo-format document, adding a lot of material in the process.
4397 This is starting to look like a real user's manual. Removed all
4398 the Lore-related files: *.xhtml, *.css, template.tpl .
4399 * docs/Makefile: simple makefile to run 'makeinfo'
4400 * buildbot/scripts/sample.cfg: rearrange slightly
4401 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4403 2005-05-10 Brian Warner <warner@lothar.com>
4405 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4406 different name for the internal twistw module, handle it.
4408 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4409 * setup.py: .. and stop trying to install it
4411 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4412 'git'), the new linux kernel VC system (http://kernel.org/git/).
4413 Thanks to Brandon Philips for the patch.
4414 * buildbot/slave/commands.py (Git): same
4416 2005-05-06 Brian Warner <warner@lothar.com>
4418 * buildbot/status/builder.py (OfflineLogFile): replace the default
4419 LogFile with a form that appends its new contents to a disk file
4420 as they arrive. The complete log data is never kept in RAM. This
4421 is the first step towards handling very large (100MB+) logfiles
4422 without choking quite so badly. (The other half is
4423 producer/consumer on the HTML pages).
4424 (BuildStepStatus.addLog): use OfflineLogFile by default
4425 (BuildStatus.getLogfileName): helper code to give the
4426 OfflineLogFile a filename to work with
4428 * buildbot/test/test_status.py (Results.testAddResults): update
4429 tests to handle new asserts
4430 * buildbot/test/test_vc.py (Patch.doPatch): same
4431 * buildbot/test/test_steps.py (BuildStep.setUp): same
4433 2005-05-05 Brian Warner <warner@lothar.com>
4435 * buildbot/scripts/runner.py (start): if there is no Makefile,
4436 launch the app by importing twistd's internals and calling run(),
4437 rather than spawning a new twistd process. This stands a much
4438 better chance of working under windows.
4439 (stop): kill the process with os.kill instead of spawning
4440 /bin/kill, again to reduce the number of external programs which
4441 windows might not have in the PATH. Also wait up to 5 seconds for
4442 the process to go away, allowing things like 'buildbot stop;
4443 buildbot start' to be reliable in the face of slow shutdowns.
4445 * buildbot/master.py (Dispatcher.__getstate__): remove old
4446 .tap-related methods
4447 (BuildMaster.__getstate__): same
4449 * buildbot/slave/bot.py (makeService): same
4450 (Options.longdesc): same
4451 * buildbot/scripts/runner.py: copy over some old mktap option text
4453 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4454 'buildbot master' now creates a buildbot.tac file, so there is no
4455 longer a create-instance/save/reload sequence. mktap is dead, long
4457 * buildbot/scripts/sample.mk: use twistd -y, not -f
4458 * buildbot/test/test_config.py: remove mktap-based test
4459 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4460 * README: don't reference mktap
4462 * docs/source.xhtml: document some of the attributes that Changes
4465 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4467 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4468 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4469 * buildbot/changes/changes.py (Change)
4470 * buildbot/changes/mail.py (parseSyncmail)
4471 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4473 * buildbot/process/base.py (Build.isTagImportant)
4477 2005-05-04 Brian Warner <warner@lothar.com>
4479 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4480 connection after sending the change, so that unit tests don't
4481 complain about sockets being left around
4483 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4484 exception in phase=0 rendering
4485 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4487 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4489 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4490 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4491 and configuring builders with tuples.
4492 * buildbot/test/test_config.py: stop testing compatibility with
4493 deprecated config keys
4494 * buildbot/test/test_run.py: same
4496 2005-05-03 Brian Warner <warner@lothar.com>
4498 * contrib/arch_buildbot.py: survive if there are no logfiles
4499 (username): just use a string, os.getlogin isn't reliable
4501 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4502 so 'buildbot sendchange' actually works. The earlier test only
4503 covered the internal (non-reactor-running) form.
4505 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4506 script to notify the buildmaster about changes
4508 * buildbot/scripts/runner.py (sendchange): new command to send a
4509 change to a buildbot.changes.pb.PBChangeSource receiver.
4510 * buildbot/test/test_changes.py (Sender): test it
4512 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4513 after any reading of the config file, not just when we do it in
4514 startService. This makes some tests a bit cleaner.
4516 * buildbot/changes/pb.py: add some log messages
4518 * buildbot/process/base.py (Build.startBuild): fix a bug that
4519 caused an exception when the build terminated in the very first
4521 (Build.stepDone): let steps return a status of EXCEPTION. This
4522 terminates the build right away, and sets the build's overall
4523 status to EXCEPTION too.
4524 * buildbot/process/step.py (BuildStep.failed): return a status of
4525 EXCEPTION when that is what has happened.
4527 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4528 implement this, allowing Arch-based projects to get precise
4529 checkouts instead of always using the latest code
4530 (Bazaar): create variant of Arch to let folks use baz instead of
4531 tla. Requires a new buildslave too.
4532 * buildbot/slave/commands.py (Arch): add 'revision' argument
4533 (Bazaar): create variant of Arch that uses baz instead of tla.
4534 Remove the code that extracts the archive name from the
4535 register-archive output, since baz doesn't provide it, and require
4536 the user provide both the archive name and its location.
4537 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4539 2005-05-02 Brian Warner <warner@lothar.com>
4541 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4542 thanks to Nick Trout.
4544 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4545 deals better with source Makefile coming from a read-only CVS
4546 checkout. Thanks to Nick Trout for the catch.
4548 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4551 2005-04-28 Brian Warner <warner@lothar.com>
4553 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4555 * debian/changelog: update for 0.6.4
4557 2005-04-28 Brian Warner <warner@lothar.com>
4559 * README.w32: add a checklist of steps for getting buildbot
4561 * MANIFEST.in: include it in the tarball
4565 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4566 broken .tap files from 0.6.3 by getting rid of .services,
4567 .namedServices, and .change_svc at load time.
4569 2005-04-27 Brian Warner <warner@lothar.com>
4571 * NEWS: update in preparation for new release
4573 * buildbot/test/test_config.py (Save.testSave): don't pull in
4574 twisted.scripts.twistd, we don't need it and it isn't for windows
4577 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4578 accomodate win32 which can't do atomic-rename
4580 2005-04-27 Brian Warner <warner@lothar.com>
4582 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4583 timeouts to help the slow metabuildbot not flunk them so much
4584 (Disconnect.testBuild3): same
4585 (Disconnect.testBuild4): same
4586 (Disconnect.testInterrupt): same
4588 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4589 setup, it was completely broken for new buildmasters (those which
4590 did not have a 'change.pck' already saved. Thanks to Paul Warren
4591 for catching this (embarrassing!) bug.
4592 (Dispatcher.__getstate__): don't save our registered avatar
4593 factories, since they'll be re-populated when the config file is
4595 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4596 tests (since the real mktap-generated BuildMaster doesn't save
4598 (BuildMaster.__getstate__): don't save any service children,
4599 they'll all be re-populated when the config file is re-read.
4600 * buildbot/test/test_config.py (Save.testSave): test for this
4602 2005-04-26 Brian Warner <warner@lothar.com>
4604 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4605 rendered with Blender.. looks a bit nicer.
4606 * buildbot/docs/images/icon.blend: add the Blender file for it
4608 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4609 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4610 running under windows. This appears to be the best way to allow
4611 BuildSteps to do something normal like 'trial -v buildbot.test' or
4612 'make foo' and still expect it to work. The idea is to make the
4613 BuildSteps look as much like what a developer would type when
4614 compiling or testing the tree by hand. This approach probably has
4615 problems when there are spaces in the arguments, so if you've got
4616 windows buildslaves, you'll need to pay close attention to your
4619 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4620 timezone to the timestamp column.
4621 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4623 * buildbot/scripts/runner.py (loadOptions): do something sane for
4624 windows, I think. We use %APPDATA%/buildbot instead of
4625 ~/.buildbot, but we still search everywhere from the current
4626 directory up to the root for a .buildbot/ subdir. The "is it under
4627 $HOME" security test was replaced with "is it owned by the current
4628 user", which is only performed under posix.
4629 * buildbot/test/test_runner.py (Options.testFindOptions): update
4630 tests to match. The "is it owned by the current user" check is
4631 untested. The test has been re-enabled for windows.
4633 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4634 any "\n" in the expected output with the platform-specific line
4635 separator. Make this separator "\r\n" on PTYs under unix, they
4636 seem to do that and I don't know why
4638 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4639 windows for now, I don't know what ~/.buildbot/ should mean there.
4641 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4642 win32 compatibility, don't use "/tmp"
4643 (Basedir.testChangeBuilddir): remove more unixisms
4645 2005-04-26 Brian Warner <warner@lothar.com>
4647 * buildbot/test/test_control.py (Force.rmtree): python2.2
4648 compatibility, apparently its shutil.rmtree ignore_errors=
4649 argument is ignored.
4650 * buildbot/test/test_run.py (Run.rmtree): same
4651 (RunMixin.setUp): same
4653 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4656 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4657 'substring in string' operator, must use string.find(substr)!=-1
4658 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4659 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4661 * buildbot/scripts/runner.py (loadOptions): add code to search for
4662 ~/.buildbot/, a directory with things like 'options', containing
4663 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4664 the current directory, your $HOME directory, or anywhere
4665 inbetween, as long as you're somewhere inside your home directory.
4666 (debugclient): look in ~/.buildbot/options for master and passwd
4667 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4668 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4670 * buildbot/status/client.py (makeRemote): new approach to making
4671 IRemote(None) be None, which works under Twisted-2.0
4672 * buildbot/test/test_status.py (Client.testAdaptation): test it
4674 * buildbot/status/builder.py (Status.builderAdded): when loading a
4675 pickled BuilderStatus in from disk, set its name after loading.
4676 The config file might have changed its name (but not its
4677 directory) while it wasn't looking.
4679 * buildbot/process/builder.py (Builder.attached): always return a
4680 Deferred, even if the builder was already attached
4681 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4683 2005-04-25 Brian Warner <warner@lothar.com>
4685 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4686 category-related exception when announcing a build has finished
4688 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4689 reference no-longer-existent changemaster.sources
4690 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4692 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4695 2005-04-25 Brian Warner <warner@lothar.com>
4697 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4699 * debian/changelog: update for 0.6.3
4701 2005-04-25 Brian Warner <warner@lothar.com>
4703 * MANIFEST.in: make sure debug.glade is in the tarball
4705 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4707 * NEWS: update for the imminent 0.6.3 release
4709 * buildbot/status/html.py (HtmlResource.content): make the
4710 stylesheet <link> always point at "buildbot.css".
4711 (StatusResource.getChild): map "buildbot.css" to a static.File
4712 containing whatever css= argument was provided to Waterfall()
4713 (Waterfall): provide the "classic" css as the default.
4714 * docs/waterfall.classic.css: move default CSS from here ..
4715 * buildbot/status/classic.css: .. to here
4717 * MANIFEST.in: make sure classic.css is included in the tarball
4718 * setup.py: and that it is installed too, under buildbot/status/
4720 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4721 the module level, because buildbot.tap files from 0.6.2 don't have
4722 it in their attribute dictionary.
4724 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4725 really exists at startup, might save some confusion somewhere.
4727 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4729 * docs/waterfall.classic.css:
4730 add a stylesheet that's almost the same as the "classic"
4733 * buildbot/status/builder.py:
4734 add EXCEPTION as a result - this is a problem for the bot
4735 maintainer, not a build problem for the changers
4736 * buildbot/process/step.py:
4737 use EXCEPTION instead of FAILURE for exceptions
4738 * buildbot/status/html.py:
4739 add build_get_class to get a class out of a build/buildstep
4740 finish naming the classes
4741 split out sourceNames to changeNames and builderNames so we
4742 can style them separately
4743 * docs/config.xhtml:
4744 finish documenting classes as they are right now
4746 * buildbot/status/html.py:
4747 name the classes as we agreed on IRC
4748 * docs/config.xhtml:
4751 * buildbot/status/html.py:
4752 same for cssclass->class_
4754 * buildbot/status/html.py:
4755 as decided on IRC, use class_ for the "class" attribute to not
4756 conflict with the class keyword, and clean up the messy **{} stuff.
4758 * buildbot/status/mail.py:
4759 put back "builders" argument, and fix docstring, because the
4760 code *ignores* builders listed in this argument
4762 * buildbot/process/builder.py:
4763 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4765 * docs/config.xhtml:
4766 describe the category argument for builders
4768 * buildbot/status/builder.py:
4769 Fix a silly bug due to merging
4771 * buildbot/process/builder.py:
4772 remove category from the process Builder ...
4773 * buildbot/status/builder.py:
4774 ... and add it to BuilderStatus instead.
4775 Set category on unpickled builder statuses, they might not have it.
4776 * buildbot/master.py:
4777 include category when doing builderAdded
4778 * buildbot/status/mail.py:
4779 return None instead of self for builders we are not interested in.
4780 * buildbot/test/test_run.py:
4781 fix a bug due to only doing deferredResult on "dummy" waiting
4782 * buildbot/test/test_status.py:
4783 add checks for the Mail IStatusReceiver returning None or self
4785 * buildbot/status/html.py:
4786 fix testsuite by prefixing page title with BuildBot
4788 * buildbot/status/builder.py:
4789 have .category in builder status ...
4790 * buildbot/process/builder.py:
4791 ... and set it from Builder
4792 * buildbot/status/html.py:
4793 make .css a class variable
4794 * buildbot/test/test_status.py:
4795 write more tests to cover our categories stuff ...
4796 * buildbot/status/mail.py:
4797 ... and fix the bug that this uncovered
4799 * buildbot/changes/mail.py:
4800 * buildbot/changes/pb.py:
4801 * buildbot/master.py:
4802 * buildbot/process/base.py:
4803 * buildbot/process/factory.py:
4804 * buildbot/process/interlock.py:
4805 * buildbot/process/step.py:
4806 * buildbot/process/step_twisted.py:
4807 * buildbot/slave/commands.py:
4808 * buildbot/status/builder.py:
4809 * buildbot/status/client.py:
4810 * buildbot/status/html.py:
4811 * buildbot/status/mail.py:
4812 * buildbot/status/progress.py:
4813 * buildbot/test/test_changes.py:
4814 * buildbot/test/test_config.py:
4815 * buildbot/test/test_control.py:
4816 * buildbot/test/test_interlock.py:
4817 * buildbot/test/test_maildir.py:
4818 * buildbot/test/test_mailparse.py:
4819 * buildbot/test/test_run.py:
4820 * buildbot/test/test_slavecommand.py:
4821 * buildbot/test/test_status.py:
4822 * buildbot/test/test_steps.py:
4823 * buildbot/test/test_twisted.py:
4824 * buildbot/test/test_util.py:
4825 * buildbot/test/test_vc.py:
4826 * buildbot/test/test_web.py:
4828 add test-case-name at the top of a whole set of files
4830 * buildbot/status/builder.py:
4831 keep order of addition when getting builder names
4832 * buildbot/status/words.py:
4833 * buildbot/test/test_run.py:
4834 add test for getBuilderNames
4836 * buildbot/process/base.py:
4837 * buildbot/process/step.py:
4838 * buildbot/status/builder.py:
4839 * buildbot/status/html.py:
4840 make buildbot css-able
4841 replace the color code for purple with purple, don't understand
4842 why it wasn't purple to start with
4844 * buildbot/status/words.py:
4845 ok, so it doesn't look like BuilderStatus.remote is still valid.
4846 Use what waterfall uses instead.
4848 * buildbot/interfaces.py:
4849 * buildbot/status/builder.py:
4850 * buildbot/status/html.py:
4851 * buildbot/status/mail.py:
4852 * buildbot/status/words.py:
4853 * buildbot/test/test_run.py:
4854 use categories everywhere and make it be a list. More sensible
4855 for the future. Also make words actually respect this in
4858 * buildbot/interfaces.py:
4859 add category argument to getBuilderNames
4860 * buildbot/process/builder.py:
4861 * buildbot/status/builder.py:
4862 * buildbot/status/html.py:
4863 * buildbot/status/mail.py:
4864 * buildbot/status/words.py:
4865 * buildbot/test/test_run.py:
4866 move from specifying builders by name to specifying the category
4868 * buildbot/status/html.py:
4869 * buildbot/status/words.py:
4870 add "builders=" to __init__ of status clients so they can
4871 limit themselves to the given list of builders to report on
4873 * buildbot/status/html.py: set the title to the product name
4875 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4877 * buildbot/interfaces.py:
4878 * buildbot/status/builder.py:
4879 more documentation. Hm, not sure if ChangeLog entries make sense
4882 2005-04-23 Brian Warner <warner@lothar.com>
4884 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4886 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4888 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4889 the sub-commands that log buildmaster status to stdout and to a
4890 GUI window, respectively.
4892 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4893 functionality is working again, but all the step-status and ETA
4894 stuff is missing. Commented out a lot of code pending more
4897 * buildbot/status/client.py: make sure that IRemote(None) is None
4899 * buildbot/changes/changes.py: import defer, oops
4900 (ChangeMaster): remove the .sources list, rely upon the fact that
4901 MultiServices can be treated as sequences of their children. This
4902 cleans up the add/remove ChangeSource routines a lot, as we keep
4903 exactly one list of the current sources instead of three.
4905 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4906 up an empty ChangeMaster at init time.
4907 (BuildMaster.loadChanges): if there are changes to be had from
4908 disk, replace self.change_svc with the new ones. If not, keep
4909 using the empty ChangeMaster set up in __init__.
4910 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4911 instead of a separate list, makes the code a bit cleaner.
4912 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4913 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4914 Extend the test to make sure we can get rid of the sources when
4917 2005-04-22 Brian Warner <warner@lothar.com>
4919 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4920 and info/host files when making the slave directory
4922 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4923 whendone= argument, just return the Deferred and let the caller do
4924 what they want with it.
4925 (Disconnect.testBuild1): wait for shutdownSlave
4926 (Basedir.testChangeBuilddir): new test to make sure changes to the
4927 builddir actually get propagated to the slave
4929 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4930 explicit method, rather than passing the builddir in __init__ .
4931 Make sure to update self.basedir too, this was broken before.
4932 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4933 builders and for ones that have just had their builddir changed.
4934 (BotFactory): add a class-level .perspective attribute, so
4935 BuildSlave.waitUntilDisconnected won't get upset when the
4936 connection hasn't yet been established
4937 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4938 tests can reach through it to inspect the SlaveBuilders
4940 * buildbot/process/base.py (Build.buildException): explain the
4941 log.err with a log.msg
4942 * buildbot/process/builder.py (Builder.startBuild): same
4943 (Builder._startBuildFailed): improve error message
4945 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4946 occurred because we lost the brand-new connection, retry instead
4947 of giving up. If not, it's probably an authorization failure, and
4948 it makes sense to stop trying. Make sure we log.msg the reason
4949 that we're log.err'ing the failure, otherwise test failures are
4950 really hard to figure out.
4952 * buildbot/master.py: change loadConfig() to return a Deferred
4953 that doesn't fire until the change has been fully implemented.
4954 This means any connected slaves have been updated with the new
4955 builddir. This change makes it easier to test the code which
4956 actually implements this builddir-updating.
4957 (BotPerspective.addBuilder): return Deferred
4958 (BotPerspective.removeBuilder): same
4959 (BotPerspective.attached): same
4960 (BotPerspective._attached): same. finish with remote_print before
4961 starting the getSlaveInfo, instead of doing them in parallel
4962 (BotPerspective.list_done): same
4963 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4964 actually calling slave.disconnect()
4965 (BotMaster.addBuilder): same
4966 (BotMaster.removeBuilder): same
4967 (BuildMaster.loadConfig): same
4968 (BuildMaster.loadConfig_Slaves): same
4969 (BuildMaster.loadConfig_Sources): same
4970 (BuildMaster.loadConfig_Builders): same
4971 (BuildMaster.loadConfig_status): same
4973 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4974 a Deferred that fires when the source is finally removed
4976 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4977 the previous tree on win32, where we have to do it synchronously,
4978 make sure we return a Deferred anyway.
4979 (SourceBase.doCopy): same
4981 * buildbot/scripts/runner.py (statusgui): use the text client for
4982 now, while I rewrite the Gtk one
4983 * buildbot/clients/base.py: strip out old code, leaving just the
4984 basic print-message-on-event functionality. I also remove the
4985 ReconnectingPBClientFactory, but it does at least quit when it
4986 loses the connection instead of going silent
4988 2005-04-21 Brian Warner <warner@lothar.com>
4990 * Makefile: minor tweaks
4992 * NEWS: point out deprecation warnings, new features for
4995 * buildbot/master.py (BuildMaster.loadConfig): emit
4996 DeprecationWarnings for Builders defined with tuples. Rearrange
4997 code to facility removal of deprecated configuration keys in the
5000 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
5001 'buildbot' command to put a little Makefile in the target that
5002 helps you re-create the buildbot.tap file, start or stop the
5003 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
5004 all the files 0600, since they contain passwords.
5005 (start): if there is a Makefile, and /usr/bin/make exists, use
5006 'make start' in preference to a raw twistd command. This lets
5007 slave admins put things like PYTHONPATH variables in their
5008 Makefiles and have them still work when the slave is started with
5009 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
5010 be nice to first try the 'make' command and only fall back to
5011 twistd if it fails. TODO: the Makefile's "start" command does not
5012 add the --reactor=win32 argument when running under windows.
5013 (Options.debugclient, Options.statusgui): add sub-commands to launch
5014 the debug client (formerly in contrib/debugclient.py) and the
5015 Gtk status application (currently broken)
5016 * buildbot/clients/debug.py: move from contrib/debugclient.py
5017 * buildbot/clients/debug.glade: same
5019 * buildbot/test/test_trial.py: remove it. This requires some
5020 functionality out of Twisted that isn't there yet, and until then
5021 having it around just confuses things.
5023 * buildbot/test/test_slavecommand.py (Shell): test both with and
5024 without PTYs, and make sure that command output is properly
5025 interleaved in the with-PTY case. I think the without-PTY test
5026 should pass on windows, where we never use PTYs anyway.
5028 2005-04-20 Brian Warner <warner@lothar.com>
5030 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
5032 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
5034 * NEWS: start creating entries for the next release
5036 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
5038 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
5039 (WebTest.test_webPathname): same
5040 (WebTest.test_webPathname_port): same
5041 (WebTest.test_waterfall): use the default favicon rather than
5042 rooting around the filesystem for it. Open the expected-icon file
5043 in binary mode, to make win32 tests happier (thanks to Nick Trout
5045 * buildbot/status/html.py (buildbot_icon): win32 portability
5047 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
5048 win32-compatibility fixes from Nick Trout, the "file not found" message
5049 is different under windows
5050 (FakeSlaveBuilder.__init__): clean up setup a bit
5051 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
5053 2005-04-19 Brian Warner <warner@lothar.com>
5055 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
5056 skip-if-repositories-are-unavailable test to not kill the trial
5057 that comes with Twisted-1.3.0
5059 * setup.py: install buildbot.png icon file when installing code
5061 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
5062 environment used by the command, at least on the child side.
5064 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
5065 this method needs to be added and implemented because it gets
5066 called under heavy load. I don't quite understand the
5067 producer/consumer API enough to write it.
5068 (StatusResource.getChild): add a resource for /favicon.ico
5069 (Waterfall.__init__): add favicon= argument
5070 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5071 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
5072 (WebTest.test_webPathname): same
5073 (WebTest.test_webPathname_port): same
5074 * docs/config.xhtml: mention favicon=
5075 * buildbot/buildbot.png: add a default icon, dorky as it is
5077 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
5079 * buildbot/master.py:
5080 * buildbot/process/base.py:
5081 * buildbot/process/builder.py:
5082 * buildbot/process/interlock.py:
5083 * buildbot/status/builder.py:
5084 * buildbot/status/html.py:
5085 * buildbot/status/mail.py:
5086 * buildbot/status/words.py:
5087 new documentation while digging through the code
5089 2005-04-17 Brian Warner <warner@lothar.com>
5091 * general: try to fix file modes on all .py files: a+r, a-x,
5092 but let buildbot/clients/*.py be +x since they're tools
5094 * docs/epyrun (addMod): when an import fails, say why
5096 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
5098 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5100 * buildbot/process/base.py:
5101 * buildbot/process/builder.py:
5102 * buildbot/status/builder.py:
5103 new documentation while digging through the code
5105 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5107 * buildbot/changes/changes.py:
5108 * buildbot/changes/p4poller.py:
5109 * buildbot/interfaces.py:
5110 * buildbot/process/base.py:
5111 * buildbot/process/builder.py:
5112 * buildbot/process/step.py:
5113 * buildbot/process/step_twisted.py:
5114 * buildbot/slave/bot.py:
5115 * buildbot/slave/commands.py:
5116 * buildbot/status/builder.py:
5117 fix all docstrings to make epydoc happy. In the process of fixing
5118 some, I also moved pieces of docs, and removed some deprecated
5121 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5123 * buildbot/process/builder.py:
5124 * buildbot/process/interlock.py:
5125 * buildbot/process/process_twisted.py:
5126 * buildbot/process/step.py:
5127 BuildProcess -> Build, as it looks like that's what happened
5128 * buildbot/process/base.py:
5129 * buildbot/process/factory.py:
5132 2005-04-17 Brian Warner <warner@lothar.com>
5134 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5135 update compile command to accomodate the Twisted split.. now
5136 instead of './setup.py build_ext -i', you do './setup.py all
5137 build_ext -i', to run build_ext over all sub-projects.
5138 (FullTwistedBuildFactory): same
5139 (TwistedReactorsBuildFactory): same
5141 * buildbot/status/html.py (TextLog.finished): null out self.req
5142 when we're done, otherwise the reference cycle of TextLog to .req
5143 to .notifications to a Deferred to TextLog.stop keeps them from
5144 being collected, and consumes a huge (610MB on pyramid at last
5145 check) amount of memory.
5147 2005-04-11 Brian Warner <warner@lothar.com>
5149 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5150 normalize the VC-repository location.. makes SVN happier with
5151 certain test environments.
5153 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5154 RemoteShellCommand gets its own .env dictionary, so that code in
5155 start() doesn't mutate the original. I think this should fix the
5156 step_twisted.Trial problem where multiple identical components
5157 kept getting added to PYTHONPATH= over and over again.
5159 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5160 adding epydoc-format docstrings to many classes. Thanks to Thomas
5161 Vander Stichele for the patches.
5162 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5163 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5164 * buildbot/slave/bot.py, commands.py, registry.py: same
5166 2005-04-05 Brian Warner <warner@lothar.com>
5168 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5169 preserve timestamps, helps incremental builds of large trees.
5170 Patch from Rene Rivera.
5172 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5173 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5176 2005-04-03 Brian Warner <warner@lothar.com>
5178 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5179 with one dict, apparently exec has some scoping bugs when used
5180 with both global/local dicts. Thanks to Nathaniel Smith for the
5183 2005-04-02 Brian Warner <warner@lothar.com>
5185 * buildbot/process/step_twisted.py (countFailedTests): the new
5186 trial in Twisted-2.0 emits a slightly different status line than
5187 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5188 mistakenly think the test count is unparseable.
5189 (Trial.start): note that for some reason each build causes another
5190 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5191 be fixed but I'm not sure quite where the problem is.
5193 2005-04-01 Brian Warner <warner@lothar.com>
5195 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5196 deferredResult to avoid hangs/warnings under twisted-2.0
5197 (RunMixin.tearDown): same
5198 (RunMixin.shutdownSlave): same
5199 (Disconnect.testIdle1): same
5200 (Disconnect.testBuild2): same: wait one second after the build
5201 finishes for test to really be done.. this should be cleaned up to
5202 avoid wasting that second. Builder.detach uses a callLater(0),
5203 either that should be done in-line (something else needed that
5204 behavior), or it should return a Deferred that fires when the
5205 builder is really offline.
5206 (Disconnect.testBuild3): same
5207 (Disconnect.testDisappear): same
5209 * buildbot/test/test_web.py: rearrange server-setup and teardown
5210 code to remove unclean-reactor warnings from twisted-2.0
5212 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5213 so the tests don't hang under twisted-2.0
5215 2005-03-31 Brian Warner <warner@lothar.com>
5217 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5218 caused a warning each time the master changed our set of builders
5220 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5221 w32, don't unlink the file unless it already exists. Thanks to
5222 Baptiste Lepilleur for the catch.
5223 (BuilderStatus.saveYourself): same
5225 2005-02-01 Brian Warner <warner@lothar.com>
5227 * buildbot/status/html.py (TextLog.getChild): use a /text child
5228 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5229 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5230 logfile as text/plain (no markup, no headers). This replaces the
5231 previous scheme (which used an ?text=1 argument), and gets us back
5232 to a relative link (which works better when the buildbot lives
5233 behind another web server, such as Apache configured as a reverse
5234 proxy). Thanks to Gerald Combs for spotting the problem.
5236 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5239 2004-12-13 Brian Warner <warner@lothar.com>
5241 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5243 * debian/changelog: update for 0.6.2
5244 * NEWS: finalize for 0.6.2
5246 2004-12-11 Brian Warner <warner@lothar.com>
5248 * NEWS: bring it up to date
5250 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5251 detection code. Require some sign of life from the buildmaster
5252 every BotFactory.keepaliveInterval seconds. Provoke this
5253 indication at BotFactory.keepaliveTimeout seconds before the
5254 deadline by sending a keepalive request. We don't actually care if
5255 that request is answered in a timely fashion, what we care about
5256 is that .activity() is called before the deadline. .activity() is
5257 triggered by any PB message from the master (including an ack to
5258 one of the slave's status-update messages). With this new scheme,
5259 large status messages over slow pipes are OK, as long as any given
5260 message can be sent (and thus acked) within .keepaliveTimeout
5261 seconds (which defaults to 30).
5262 (SlaveBuilder.remote_startCommand): record activity
5263 (SlaveBuilder.ackUpdate): same
5264 (SlaveBuilder.ackComplete): same
5265 (BotFactory.gotPerspective): same
5266 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5268 2004-12-09 Brian Warner <warner@lothar.com>
5270 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5273 * buildbot/process/step_twisted.py (Trial._commandComplete):
5274 update self.cmd when we start the 'cat test.log' transfer. Without
5275 this, we cannot interrupt the correct RemoteCommand when we lose
5278 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5279 trying to tell the slave to stop the command if we're already
5280 inactive, or if we no longer have a .remote
5282 * buildbot/process/builder.py (Builder._detached): don't let an
5283 exception in currentBuild.stopBuild() prevent the builder from
5284 being marked offline
5286 2004-12-07 Brian Warner <warner@lothar.com>
5288 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5289 KeyError that happens when you ask for a non-existent Builder, and
5290 translate it into a UsageError.
5292 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5293 losing the slave in the middle of a remote step is handled too
5295 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5296 be a Failure, so be sure to stringify it before using it as the
5297 contents of the 'interrupt' logfile
5298 (RemoteCommand.interrupt): use stringified 'why' in
5299 remote_interruptCommand too, just in case
5301 2004-12-06 Brian Warner <warner@lothar.com>
5303 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5304 instead of 'tla update', which is more efficient in case we've
5305 missed a couple of patches since the last update.
5307 * debian/changelog: update for previous (0.6.1) release. Obviously
5308 this needs to be handled better.
5310 2004-12-05 Brian Warner <warner@lothar.com>
5312 * NEWS: update for stuff since last release
5314 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5315 match the maybeDeferred change in Dispatcher.requestAvatar
5316 * buildbot/changes/pb.py (ChangePerspective.attached): same
5317 * buildbot/status/client.py (StatusClientPerspective.attached): same
5318 * buildbot/process/builder.py (Builder._attached3): same
5319 * buildbot/pbutil.py (NewCredPerspective.attached): same
5321 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5322 the date to the top-most box, if it is not the same as today's
5325 * docs/slave.xhtml: provide a buildslave setup checklist
5327 * docs/source.xhtml (Arch): correct terminology
5329 2004-12-04 Brian Warner <warner@lothar.com>
5331 * buildbot/test/test_slavecommand.py: use sys.executable instead
5332 of hard-coding 'python' for child commands, might help portability
5334 * docs/examples/twisted_master.cfg: update to current usage
5336 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5337 'stop build' command to the IRC bot
5339 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5340 message that broke PBChangeSource
5342 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5343 (SlaveBuilder): make some attributes class-level, remove the old
5344 "update queue" which existed to support resuming a build after the
5345 master connection was lost. Try to reimplement that feature later.
5346 (SlaveBuilder.stopCommand): clear self.command when the
5347 SlaveCommand finishes, so that we don't try to kill a leftover one
5349 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5352 * buildbot/slave/commands.py (SourceBase): set self.command for
5353 all VC commands, so they can be interrupted.
5355 2004-12-03 Brian Warner <warner@lothar.com>
5357 * buildbot/master.py: clean up slave-handling code, to handle
5358 slave-disconnect and multiple-connect better
5359 (BotPerspective): make these long-lasting, exactly one per bot
5360 listed in the config file.
5361 (BotPerspective.attached): if a slave connects while an existing
5362 one appears to still be connected, disconnect the old one first.
5363 (BotPerspective.disconnect): new method to forcibly disconnect a
5364 buildslave. Use some hacks to empty the transmit buffer quickly to
5365 avoid the long (20-min?) TCP timeout that could occur if the old
5366 slave has dropped off the net.
5367 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5368 own their own SlaveStatus objects. Remove .attached/.detached, add
5369 .addSlave/.removeSlave, treat slaves like Builders (config file
5370 parsing sends deltas to the BotMaster). Inform the slave
5371 instances, i.e. the BotPerspective, about addBuilder and
5373 (BotMaster.getPerspective): turns into a single dict lookup
5374 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5375 which gives BotPerspective.attached a chance to disconnect the old
5377 (BuildMaster.loadConfig): add code (disabled) to validate that all
5378 builders use known slaves (listed in c['bots']). The check won't
5379 work with tuple-specified builders, which are deprecated but not
5380 yet invalid, so the check is disabled for now.
5381 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5382 routine, do the add/changed/removed dance with them like we do
5384 (BuildMaster.loadConfig_Sources): move source-config into a
5385 separate routine too
5387 * buildbot/status/builder.py (Status.getSlave): get the
5388 SlaveStatus object from the BotPerspective, not the BotMaster.
5390 * buildbot/test/test_run.py: bunch of new tests for losing the
5391 buildslave at various points in the build, handling a slave that
5392 connects multiple times, and making sure we can interrupt a
5395 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5396 something other than 'Bot' for the Bot object, to make certain
5397 test cases easier to write.
5398 (BuildSlave.waitUntilDisconnected): utility method for testing
5400 2004-11-30 Brian Warner <warner@lothar.com>
5402 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5404 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5405 argument, return a Deferred that always fires with True or False.
5406 I don't use an errback to indicate 'ping failed' so that callers
5407 are free to ignore the deferred without causing spurious errors in
5409 * buildbot/process/builder.py (BuilderControl.ping): implement it
5411 * buildbot/test/test_run.py (Status.testDisappear): test ping
5412 (Status.disappearSlave): fix it
5414 2004-11-30 Brian Warner <warner@lothar.com>
5416 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5417 (IBuilderControl): add .getBuild(num), only works for the current
5418 build, of course, although it might be interesting to offer
5419 something for builds in the .waiting or .interlocked state.
5421 * buildbot/process/base.py (Build): have .stopBuild just do the
5422 interrupt, then let the build die by itself.
5423 (BuildControl): add .stopBuild, and add a point-event named
5424 'interrupt' just after the build so status viewers can tell that
5426 (BuilderControl): add .getBuild
5428 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5429 stops when you kill it, good for testing
5430 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5431 contains the 'reason' text.
5433 * buildbot/status/html.py: Add Stop Build button, if the build can
5434 still be stopped. Send a Redirect (to the top page) one second
5435 later, hopefully long enough for the interrupt to have an effect.
5436 Move make_row() up to top-level to share it between Stop Build and
5439 * buildbot/slave/commands.py: only kill the child process once
5441 * buildbot/test/test_run.py: add testInterrupt
5443 2004-11-29 Brian Warner <warner@lothar.com>
5445 * buildbot/process/base.py: Refactor command interruption. The
5446 Build is now responsible for noticing that the slave has gone
5447 away: Build.lostRemote() interrupts the current step and makes
5448 sure that no further ones will be started.
5450 * buildbot/process/builder.py: When the initial remote_startBuild
5451 message fails, log it: this usually indicates that the slave has
5452 gone away, but we don't really start paying attention until they
5453 fail to respond to the first step's command.
5455 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5456 slave disconnect. Now sports a new interrupt() method. Error
5457 handling was simplified a lot by chaining deferreds, so
5458 remoteFailed/remoteComplete were merged into a single
5459 remoteComplete method (which can now get a Failure object).
5460 Likewise failed/finished were merged into just _finished.
5461 (BuildStep): Add interrupt(why) method, and if why is a
5462 ConnectionLost Failure then the step is failed with some useful
5465 * buildbot/slave/bot.py: stop the current command when the remote
5466 Step reference is lost, and when the slave is shut down.
5467 (Bot): make it a MultiService, so it can have children. Use
5468 stopService to tell when the slave is shutting down.
5469 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5470 remote_interruptCommand (which asks the current SlaveCommand to
5471 stop but allows it to keep emitting status messages), and
5472 stopCommand (which tells it to shut up and die).
5474 * buildbot/slave/commands.py: make commands interruptible
5475 (ShellCommand.kill): factor out os.kill logic
5476 (Command): factor out setup()
5477 (Command.sendStatus): don't send status if .running is false, this
5478 happens when the command has been halted.
5479 (Command.interrupt): new method, used to tell the command to die
5480 (SlaveShellCommand): implement .interrupt
5481 (DummyCommand): implement .interrupt
5482 (SourceBase, etc): factor out setup(), don't continue substeps if
5485 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5486 so they can be called after finishing
5488 * buildbot/test/test_run.py: new tests for disconnect behavior,
5489 refactor slave-shutdown routines, add different kinds of
5492 2004-11-27 Brian Warner <warner@lothar.com>
5494 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5495 method to express ETA time like "2m45s" instead of "165 seconds"
5497 2004-11-24 Brian Warner <warner@lothar.com>
5499 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5500 archive after the test completes, to avoid cluttering the user's
5501 'tla archives' listing with a bogus entry. Arch doesn't happen to
5502 provide any way to override the use of ~/.arch-params/, so there
5503 isn't a convenient way to avoid touching the setup of the user who
5505 (VC_HTTP.testArchHTTP): same
5507 2004-11-23 Brian Warner <warner@lothar.com>
5509 * buildbot/status/html.py (TextLog): split render() up into
5510 render_HEAD and render_GET. Use a Producer when sending log
5511 chunks, to reduce memory requirements and avoid sending huge
5512 non-Banana-able strings over web.distrib connections. Requires
5513 peeking under the covers of IStatusLog.
5514 (TextLog.resumeProducing): fix the "as text" link, handle client
5515 disconnects that occur while we're still sending old chunks.
5517 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5518 use defer.succeed, not the non-existent defer.success
5519 (LogFile.waitUntilFinished): same
5520 (LogFile.subscribe): don't add watchers to a finished logfile
5522 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5525 2004-11-23 Brian Warner <warner@lothar.com>
5527 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5529 2004-11-23 Brian Warner <warner@lothar.com>
5531 * NEWS: update for the 0.6.1 release
5532 * MANIFEST.in: add new files
5534 * README (INSTALLATION): explain how to enable the extra VC tests
5536 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5537 level to, so old pickled builds can be displayed ok
5539 2004-11-22 Brian Warner <warner@lothar.com>
5541 * NEWS: summarize updates since last release
5543 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5544 Yoz Grahame. Closes SF#1050138.
5546 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5549 * buildbot/process/step_twisted.py (Trial): update docs a bit
5551 * docs/factories.xhtml: fix Trial factory docs to match reality.
5554 * buildbot/process/factory.py (Trial.__init__): add args for
5555 randomly= and recurse=, making them available to instantiators
5556 instead of only to subclassers. Closes: SF#1049759.
5558 2004-11-15 Brian Warner <warner@lothar.com>
5560 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5561 try to teach the Quick factory to use multiple versions of python
5563 2004-11-12 Brian Warner <warner@lothar.com>
5565 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5566 safer w32-compatible approach, and only use it on windows
5567 (BuildStatus.saveYourself): same
5569 2004-11-11 Brian Warner <warner@lothar.com>
5571 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5572 it: one string merge per chunk. There are now separate .entries
5573 and .runEntries lists: when enumerating over all chunks, make sure
5575 * buildbot/test/test_status.py (Log): more tests
5577 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5578 chunks together, up to 10kb per chunk. This ought to cut down on
5579 the CPU-burning overhead of large log files. Thanks to Alexander
5580 Staubo for spotting the problem.
5581 * buildbot/test/test_status.py (Log): tests for same
5583 2004-11-10 Brian Warner <warner@lothar.com>
5585 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5586 header to outbound mail
5587 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5589 2004-11-08 Brian Warner <warner@lothar.com>
5591 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5592 can't do os.rename() onto an existing file, so catch the exception
5593 and unlink the target file first. This introduces a slight window
5594 where the existing file could be lost, but the main failure case
5595 (disk full) should still be handled safely.
5596 (BuildStatus.saveYourself): same
5598 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5599 separator character instead of os.sep, because the filenames being
5600 split here are coming from the VC system, which can have a
5601 different pathname convention than the local host. This should
5602 help a buildmaster running on windows that uses a CVS repository
5603 which runs under unix.
5604 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5606 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5607 when there are no test failures to be parsed
5609 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5610 instead of the unix-specific os.system("cp"), thanks to Elliot
5611 Murphy for this and the other buildbot-vs-windows catches.
5612 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5614 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5615 echo the command as it is run
5617 * setup.py: install sample.mk too, not just sample.cfg
5618 (scripts): install contrib/windows/buildbot.bat on windows
5620 2004-11-07 Brian Warner <warner@lothar.com>
5622 * buildbot/process/builder.py (Builder._detached): clear the
5623 self.currentBuild reference, otherwise the next build will be
5624 skipped because we think the Builder is already in use.
5626 * docs/examples/twisted_master.cfg: update to match current usage
5627 on the Twisted buildbot
5629 2004-10-29 Brian Warner <warner@lothar.com>
5631 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5633 2004-10-28 Brian Warner <warner@lothar.com>
5635 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5636 have separate doVCUpdate/doVCFull methods. Catch an update failure
5637 and respond by clobbering the source directory and re-trying. This
5638 will handle local changes (like replacing a file with a directory)
5639 that will cause CVS and SVN updates to fail.
5640 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5642 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5645 2004-10-19 Brian Warner <warner@lothar.com>
5647 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5649 * buildbot/status/html.py (StatusResourceTestResults): display any
5650 TestResults that the Build might have
5651 (StatusResourceTestResult): and the logs for each TestResult
5652 (StatusResourceBuild): add link from the per-build page
5654 2004-10-15 Brian Warner <warner@lothar.com>
5656 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5657 the 'problems' portion of stdout, add TestResults to our build
5658 * buildbot/test/test_twisted.py (Parse.testParse): test it
5660 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5661 to retrieve a dict of accumulated test results
5662 (ITestResult): define what a single test result can do
5663 * buildbot/status/builder.py (TestResult): implement ITestResult
5664 (BuildStatus.getTestResults): retrieve dict of TestResults
5665 (BuildStatus.addTestResult): add TestResults
5666 * buildbot/test/test_status.py (Results.testAddResults): test it
5668 2004-10-14 Brian Warner <warner@lothar.com>
5670 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5671 instead of os.system("rm -rf") for win32 portability
5673 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5674 SignalMixin instead of starting/stopping the reactor, which is
5675 likely to cause problems with other tests
5677 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5678 self.copyComplete() call. Yoz Grahame makes the catch.
5680 * contrib/windows/buildbot.bat: helper script to deal with path
5681 issues. Thanks to Yoz Grahame.
5683 * buildbot/master.py (BuildMaster.startService): don't register a
5684 SIGHUP handler if the signal module has no SIGHUP attribute.
5685 Apparently win32 does this.
5687 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5689 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5690 test if the reactor can't offer UNIX sockets
5692 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5693 error introduced in the last commit. We really need that
5696 2004-10-12 Brian Warner <warner@lothar.com>
5698 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5699 when describing a maildir source. Thanks to Stephen Davis.
5701 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5704 * buildbot/scripts/runner.py (createMaster): install Makefile too
5705 (start): add --no_save to 'start' command
5706 * buildbot/scripts/sample.mk: simple convenience Makefile with
5707 start/stop/reload targets
5709 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5712 2004-09-30 Brian Warner <warner@lothar.com>
5714 * setup.py: Releasing buildbot-0.6.0
5716 2004-09-30 Brian Warner <warner@lothar.com>
5718 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5719 test_trial.py from the source tarball until support is complete.
5721 * NEWS: update for 0.6.0 release
5722 * buildbot/__init__.py (version): same
5725 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5726 'source' command to tell users where to get the Buildbot source
5728 * docs/examples/*.cfg: update to modern standards
5730 * NEWS: update for release
5732 * buildbot/scripts/runner.py (createMaster): remove the
5733 -shutdown.tap stuff now that it isn't necessary
5735 (start): launch buildbot.tap, not buildbot-shutdown.tap
5738 * buildbot/status/mail.py (Domain): shorten class name
5739 (MailNotifier): if lookup= is a string, pass it to Domain()
5740 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5741 (Mail.testBuild2): test the string-to-Domain shortcut
5742 (Mail.testMail): fix test
5745 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5748 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5749 more attributes on load
5750 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5751 to accomodate the whole waterfall page at once, and the thrashing
5752 results in a lot of unnecessary loads
5753 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5754 (BuilderStatus.saveYourself): same
5755 (BuilderStatus.eventGenerator): stop generating on the first missing
5756 build. We assume that saved builds are deleted oldest-first.
5757 (BuildStepStatus.__getstate__): .progress might not exist
5759 * buildbot/changes/changes.py (ChangeMaster): make it
5760 serializable, in $masterdir/changes.pck
5761 (ChangeMaster.stopService): save on shutdown
5762 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5763 * buildbot/test/test_config.py: load Changes before config file
5766 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5767 "Oh my god, you killed the command" header on a separate line
5769 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5770 skip over corrupted build pickles
5771 (BuilderStatus.getFullBuildByNumber): same
5772 (BuilderStatus.eventGenerator): skip over unavailable builds
5773 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5774 do an atomic rename. This prevents a corrupted pickle when some
5775 internal serialization error occurs.
5776 (BuilderStatus.saveYourself): same
5778 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5779 the timeout for shell commands, it got lost somehow
5781 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5782 run out of build steps, return the rest of the builder events
5784 * buildbot/interfaces.py (IBuilderControl.ping): add method
5786 * buildbot/process/builder.py (BuilderControl.ping): move
5787 slave-ping to BuilderControl, and fix the failure case in the
5788 process (Event.finish() is the verb, Event.finished is the noun).
5790 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5791 through the BuilderControl instead of the BuilderStatus
5792 (EventBox): add adapter for builder.Event, allowing builder events to
5793 be displayed in the waterfall display
5795 * buildbot/master.py (BotMaster.stopService): add a 'master
5796 shutdown' event to the builder's log
5797 (BuildMaster.startService): and a 'master started' on startup
5799 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5800 builder events into the BuildStep event stream
5801 (Status.builderAdded): add a 'builder created' event
5804 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5805 command to announce the completion of a running build
5806 (IrcStatusBot.command_FORCE): announce when the build finishes
5808 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5809 don't evict unfinished builds from the cache: they must stay in
5810 the full-cache until their logfiles have stopped changing. Make
5811 sure the eviction loop terminates if an unfinished build was hit.
5812 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5813 This lets exceptions be dumped in an email status message. Really
5814 we need LogFiles which contain both text and HTML, instead of two
5816 (BuildStatus.__getstate__): handle self.finished=False
5817 (Status.builderAdded): if the pickle is corrupted, abandon the
5818 history and create a new BuilderStatus object.
5820 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5821 self.progress attribute, helped one test which doesn't fully set
5822 up the Build object.
5824 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5825 IStatusLog methods into an Interface that is implemented by "stub"
5826 logs, for which all the actual text chunks are on disk (in the
5827 pickled Build instance). To show the log contents, you must first
5828 adapt the stub log to a full IStatusLog object.
5830 * buildbot/status/builder.py (LogFileStub): create separate stub
5831 log objects, which can be upgraded to a real one if necessary.
5832 (LogFile): make them persistable, and let them stubify themselves
5834 (BuildStepStatus): same
5836 (BuildStatus.saveYourself): save the whole build out to disk
5837 (BuilderStatus): make it persistable
5838 (BuilderStatus.saveYourself): save the builder to disk
5839 (BuilderStatus.addFullBuildToCache): implement two caches which
5840 hold Build objects: a small one which holds full Builds, and a
5841 larger one which holds "stubbed" Builds (ones with their LogFiles
5842 turned into LogFileStubs). This reduces memory usage by the
5843 buildmaster by not keeping more than a few (default is 2) whole
5844 build logs in RAM all the time.
5845 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5847 (BuilderStatus.eventGenerator): rewrite since .builds went away
5848 (BuilderStatus.buildStarted): remove the .builds array. Add the
5849 build to the "full" cache when it starts.
5850 (BuilderStatus._buildFinished): save the build to disk when it
5852 (Status): give it a basedir (same as the BuildMaster's basedir)
5853 where the builder pickles can be saved
5854 (Status.builderAdded): create the BuilderStatus ourselves, by
5855 loading a pickle from disk (or creating a new instance if there
5856 was none on disk). Return the BuilderStatus so the master can glue
5857 it into the new Builder object.
5859 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5860 all BuilderStatuses to save themselves out to disk. This is in
5861 lieu of saving anything important in the main Application pickle
5862 (the -shutdown.tap file).
5863 (BuildMaster.__init__): give Status() a basedir for its files
5864 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5865 to get the BuilderStatus, then give it to the Builder (instead of
5866 doing it the other way around). It's ok if the status announces
5867 the new Builder before it's really ready, as the outside world can
5868 only see the BuilderStatus object anyway (and it is ready before
5869 builderAdded returns). Use the builder's "builddir" (which
5870 normally specifies where the slave will run the builder) as the
5871 master's basedir (for saving serialized builds).
5873 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5874 coerce the logfile to IStatusLog before trying to get the text
5875 chunks out of it. This will pull the full (non-stubified) Build in
5876 from disk if necessary.
5877 (TextLog): fix the adapter registration
5879 * buildbot/test/test_control.py (Force.setUp): create the basedir
5880 * buildbot/test/test_web.py: same
5881 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5882 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5883 * buildbot/test/test_run.py (Run.testMaster): same
5884 (Status.setUp): same
5886 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5888 * buildbot/status/html.py (Waterfall.__init__): store actual
5889 allowForce flag passed in rather than using True for everyone;
5890 make sure setting it to False doesn't cause a NameError
5892 (StatusResourceBuilder.__init__) add the builder name to the page
5894 (StatusResourceBuilder.body) move HTML generation for a name/value
5895 row into a helper method (StatusResourceBuilder.make_row); only
5896 generate the "Force Build" form if allowForce was True and the
5897 slave is connected. Use class attributes in the generated HTML to
5898 spread a little CSS-joy.
5900 2004-09-28 Brian Warner <warner@lothar.com>
5902 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5903 warning-scanner to not ignore things like
5904 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5906 * buildbot/status/html.py (StatusResource.control): add some
5907 class-level values for .control in an attempt to make upgrading
5910 * buildbot/util.py (ComparableMixin): survive missing attributes,
5911 such as when a class is modified and we're comparing old instances
5914 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5915 failure handling, remove a redundant try/except block. Don't
5916 return the full traceback to the IRC channel.
5917 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5918 error messages. Get ETA properly.
5920 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5921 the reason, since (at least) IRC message will have <> in them.
5922 (StatusResourceBuilder.__init__): take an IBuilderControl
5923 (StatusResourceBuilder.force): use the IBuilderControl we get in
5924 the constructor instead of trying to make our own. Catch the
5925 new exceptions and ignore them for now (until we make an
5926 intermediate web page where we could show the error message)
5927 (StatusResource): create with an IControl, use it to give an
5928 IBuilderControl to all children
5929 (Waterfall): take an allowForce= option, pass an IControl object
5930 to StatusResource if it is True
5932 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5934 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5935 catch new exceptions and return string forms
5937 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5938 * buildbot/process/builder.py (Builder.forceBuild): raise them
5939 * buildbot/test/test_control.py (Force.testNoSlave): new test
5940 (Force.testBuilderInUse): same
5943 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5945 * buildbot/test/test_run.py: use IControl
5946 * buildbot/test/test_vc.py: same
5948 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5949 to use IControl. Still offline.
5950 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5952 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5953 who=None so periodic builds don't send out status mail
5954 (Builder.forceBuild): include reason in the log message
5955 (BuilderControl.forceBuild): rename 'name' to 'who'
5957 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5958 'who' parameter, but make it None by default so builds forced by
5959 slave admins don't cause status mail to be sent to anybody
5960 (BotMaster.forceBuild): same. this method is deprecated.
5961 (DebugPerspective.perspective_forceBuild): same, use IControl.
5962 (DebugPerspective.perspective_fakeChange): use IControl..
5963 (Dispatcher.requestAvatar): .. so don't set .changemaster
5965 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5966 parameter to avoid confusion with the name of the builder
5969 * buildbot/status/mail.py: refine comment about needing 2.3
5971 * buildbot/status/html.py: move all imports to the top
5973 * buildbot/test/test_control.py: test new interfaces
5974 * buildbot/test/test_run.py (Status): handle new interfaces
5975 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5977 * buildbot/process/base.py (BuildControl): implement IBuildControl
5978 and its lonely getStatus() method
5980 * buildbot/process/builder.py (BuilderControl): implement
5981 IBuilderControl, obtained by adapting the Builder instance
5982 (Builder.startBuild): return a BuilderControl instead of a
5983 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5984 accomplish the same thing.
5986 * buildbot/master.py: move all import statements to the top
5987 (Control): implement IControl, obtained by adapting the
5988 BuildMaster instance.
5990 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5991 IBuildControl. These are used to force builds. Eventually they
5992 will provide ways to reconfigure the Builders, pause or abandon a
5993 Build, and perhaps control the BuildMaster itself.
5995 2004-09-26 Brian Warner <warner@lothar.com>
5997 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5998 ends up comparing us against something without a .__class__
6000 2004-09-24 Brian Warner <warner@lothar.com>
6002 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
6005 * Makefile: add 'deb-snapshot' target, to create a timestamped
6008 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
6010 2004-09-23 Brian Warner <warner@lothar.com>
6012 * buildbot/__init__.py (version): move version string here
6013 * setup.py: get version string from buildbot.version
6014 * buildbot/status/html.py (WaterfallStatusResource.body): add
6015 buildbot version to the page footer
6016 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
6019 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
6020 slaves, let the second know where the first one is coming from
6021 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
6022 see our exceptions. It would be nice if there were a way to just
6023 send them the exception type and value, not the full traceback.
6026 * buildbot/status/mail.py (MailNotifier): add a new argument
6027 sendToInterestedUsers=, which can be set to False to disable the
6028 usual send-to-blamelist behavior.
6029 (top): handle python-2.2 which has no email.MIMEMultipart
6030 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
6031 (MailNotifier.disownServiceParent): unsubscribe on removal
6033 * buildbot/test/test_status.py (Mail.testBuild2): test it
6036 * buildbot/status/progress.py (Expectations.wavg): tolerate
6037 current=None, which happens when steps start failing badly
6038 * buildbot/test/test_status.py (Progress.testWavg): test for it
6040 * buildbot/process/step.py (SVN.startVC): when the (old) slave
6041 doesn't understand args['revision'], emit a warning instead of
6042 bailing completely. Updating to -rHEAD is probably close enough.
6044 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
6046 * buildbot/test/test_status.py: at least import bb.status.client
6047 even if we don't have any test coverage for it yet
6049 * contrib/svn_buildbot.py: don't require python2.3
6050 (main): wait, do require it (for sets.py), but explain how to
6051 make it work under python2.2
6053 2004-09-23 Brian Warner <warner@lothar.com>
6055 * contrib/svn_buildbot.py: include the revision number in the Change
6057 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
6058 using util.now() because FreshCVS is a realtime service
6060 * buildbot/status/event.py: delete dead code
6061 * buildbot/process/step.py: don't import dead Event class
6062 * buildbot/process/step_twisted.py: same
6063 * buildbot/status/builder.py: same
6064 * buildbot/status/client.py: same
6066 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
6068 * buildbot/changes/changes.py (Change): set .when from an __init__
6069 argument (which defaults to now()), rather than having
6070 ChangeMaster.addChange set it later.
6071 (ChangeMaster.addChange): same
6073 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
6074 (parseSyncmail): same. Just use util.now() for now.
6075 (parseBonsaiMail): parse the timestamp field for when=
6077 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
6078 instead of setting .when after the fact
6082 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
6083 results when the target project uses retrial. Still under
6085 * buildbot/test/test_trial.py: same
6087 2004-09-21 Brian Warner <warner@lothar.com>
6089 * buildbot/status/mail.py (MailNotifier.__init__): include
6090 success/warnings/failure in the Subject line
6091 (MailNotifier.buildMessage): add the buildbot's URL to the body,
6092 use step.logname for the addLogs=True attachment filenames
6093 * buildbot/test/test_status.py (Mail): test Subject lines
6094 (Mail.testLogs): test attachment filenames
6096 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
6097 accept a 'who' argument from the debug tool
6098 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
6099 * contrib/debug.glade: add text box to set 'who'
6101 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6102 .getBuilderName with .getBuilder().getName(), more flexible
6103 (IStatusLog.getName): logs have short names, but you can prefix
6104 them with log.getStep().getName() to make them more useful
6105 * buildbot/status/builder.py: same
6106 * buildbot/status/client.py: same
6107 * buildbot/status/html.py: same
6108 * buildbot/test/test_run.py (Status.testSlave): same
6109 * buildbot/process/step.py: tweak logfile names
6111 * buildbot/status/mail.py (MailNotifier): add lookup, change
6112 argument to extraRecipients. The notifier is now aimed at sending
6113 mail to the people involved in a particular build, with additional
6114 constant recipients as a secondary function.
6116 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6117 including slow-lookup and failing-lookup. Make sure the blamelist
6118 members are included.
6120 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6121 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6122 (IBuildStatus.getInterestedUsers): new method
6123 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6124 * buildbot/status/client.py (remote_getResponsibleUsers): same
6125 * buildbot/status/html.py (StatusResourceBuild.body): same
6126 * buildbot/test/test_run.py (Status.testSlave): same
6128 2004-09-20 Brian Warner <warner@lothar.com>
6130 * docs/users.xhtml: update concepts
6132 * Makefile: add a convenience makefile, for things like 'make
6133 test'. It is not included in the source tarball.
6135 2004-09-16 Brian Warner <warner@lothar.com>
6137 * NEWS: mention /usr/bin/buildbot, debian/*
6139 * debian/*: add preliminary debian packaging. Many thanks to
6140 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6141 it considerably since it left their hands, I am responsible for
6142 all breakage that's resulted.
6144 * bin/buildbot: create a top-level 'buildbot' command, to be
6145 installed in /usr/bin/buildbot . For now it's just a simple
6146 frontend to mktap/twistd/kill, but eventually it will be the entry
6147 point to the 'try' command and also a status client. It is also
6148 intended to support the upcoming debian-packaging init.d scripts.
6149 * buildbot/scripts/runner.py: the real work is done here
6150 * buildbot/scripts/__init__.py: need this too
6151 * buildbot/scripts/sample.cfg: this is installed in new
6152 buildmaster directories
6153 * setup.py: install new stuff
6155 2004-09-15 Brian Warner <warner@lothar.com>
6157 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6158 'file:' schema (the version shipped with OS-X was built without the
6160 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6161 updates the log-timestamp, to make sure it isn't still running after
6164 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6165 values to the config file.
6166 * docs/examples/hello.cfg: add examples
6167 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6168 * buildbot/status/builder.py (Status.getProjectURL): implement them
6169 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6170 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6171 * buildbot/status/html.py (WaterfallStatusResource): display them
6174 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6175 certain error cases don't suffer a secondary exception.
6176 (top): Skip tests if the corresponding VC tool is not installed.
6178 * buildbot/process/factory.py (Trial): introduce separate
6179 'buildpython' and 'trialpython' lists, since trialpython=[] is
6180 what you want to invoke /usr/bin/python, whereas ./setup.py is
6181 less likely to be executable. Add env= parameter to pass options
6182 to test cases (which is how I usually write tests, I don't know if
6183 anyone else does it this way).
6185 * buildbot/process/step_twisted.py (Trial): handle python=None.
6186 Require 'testpath' be a string, not a list. Fix tests= typo.
6187 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6189 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6190 way to deal with the possibility of removing the disconnect notify
6192 (CVS): add a 'login' parameter to give a password to 'cvs login',
6193 commonly used with pserver methods (where pw="" or pw="guest")
6195 * buildbot/slave/commands.py (SourceBase): move common args
6196 extraction and setup() to __init__, so everything is ready by the
6197 time setup() is called
6198 (CVS.start): call 'cvs login' if a password was supplied
6199 (ShellCommand): special-case PYTHONPATH: prepend the master's
6200 value to any existing slave-local value.
6202 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6203 don't have a remote, mark the builder as Offline. This whole
6204 function should probably go away and be replaced by individual
6206 (Builder.buildFinished): return the results to the build-finished
6207 deferred callback, helps with testing
6209 2004-09-14 Brian Warner <warner@lothar.com>
6211 * buildbot/test/test_vc.py: put all the repositories needed to run
6212 the complete tests into a single small (1.3MB) tarball, so I can
6213 make that tarball available on the buildbot web site. Test HTTP
6214 access (for Arch and Darcs) by spawning a temporary web server
6215 while the test runs.
6217 * docs/users.xhtml: new document, describe Buildbot's limited
6218 understanding of different human users
6220 * buildbot/test/test_vc.py: rearrange test cases a bit
6222 * buildbot/process/step_twisted.py (Trial): handle testpath=
6223 * buildbot/process/factory.py (Trial): update to use step.Trial
6225 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6227 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6228 the overall build text (which gives you 'failed 2 tests' rather
6230 (BuildStepStatus.text2): default to [], not None
6232 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6235 2004-09-12 Brian Warner <warner@lothar.com>
6237 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6238 log the whole exception if it's just an AttributeError (old slave)
6240 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6241 so (e.g.) sub-commands can be run in the right directory.
6242 (ShellCommand.start): accept an optional errorMessage= argument
6243 to make life easier for SVN.start
6244 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6246 (ShellCommand.start): move ['dir'] compatibility hack..
6247 (RemoteShellCommand.start): .. to here so everyone can use it
6249 * buildbot/process/step_twisted.py (Trial): use .workdir
6251 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6252 text displayed when debuild fails completely
6253 (Trial): snarf _trial_temp/test.log from the slave and display it
6255 2004-09-11 Brian Warner <warner@lothar.com>
6257 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6259 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6260 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6262 * buildbot/process/step.py (ShellCommand): call .createSummary
6263 before .evaluateCommand instead of the other way around. This
6264 makes it slightly easier to count warnings and then use that to
6265 set results=WARNINGS
6266 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6268 * buildbot/process/base.py (Build.buildFinished): update status
6269 before doing progress. It's embarrassing for the build to be stuck
6270 in the "building" state when an exceptions occurs elsewhere..
6272 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6273 python2.2 doesn't have 'sum'
6275 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6276 to prevent clients from accidentally sorting it
6278 * buildbot/master.py (Manhole): add username/password
6279 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6280 c['manholePort'], deprecate old usage
6281 * docs/config.xhtml: document c['manhole']
6282 * docs/examples/hello.cfg: show example of using a Manhole
6285 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6286 pretend the slave is up to date
6288 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6289 the module, overlaps with 'log', the local variable
6291 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6293 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6294 new method to let Steps find out the version of their
6295 corresponding SlaveCommand.
6296 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6297 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6298 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6300 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6301 (Arch.startVC): same
6302 (P4Sync.startVC): same
6304 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6305 Deferred so we can catch errors in remote_startCommand
6306 (RemoteShellCommand.start): same
6308 * docs/examples/twisted_master.cfg: update sample config file
6310 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6311 after connectionMade() is called, not before. Close stdin at that
6314 * buildbot/process/process_twisted.py: update to use Trial, clean
6315 up argument passing (move to argv arrays instead of string
6318 * buildbot/process/step_twisted.py (Trial): new step to replace
6319 RunUnitTests, usable by any trial-using project (not just
6320 Twisted). Arguments have changed, see the docstring for details.
6322 * buildbot/process/base.py (Build.startBuild): this now returns a
6323 Deferred. Exceptions that occur during setupBuild are now
6324 caught better and lead to fewer build_status weirdnesses, like
6325 finishing a build that was never started.
6326 (Build.buildFinished): fire the Deferred instead of calling
6327 builder.buildFinished directly. The callback argument is this
6328 Build, everything else can be extracted from it, including the
6329 new build.results attribute.
6330 * buildbot/process/builder.py (Builder.startBuild): same
6331 (Builder.buildFinished): same, extract results from build
6333 * buildbot/process/step.py (ShellCommands): remove dead code
6335 2004-09-08 Brian Warner <warner@lothar.com>
6337 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6338 doesn't try to use the leftover patched workdir
6339 (SourceStamp): test source-stamp computation for CVS and SVN
6341 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6342 patched workdir ('touch .buildbot-patched') so we don't try to
6344 (SourceBase.start): add ['revision'] for all Source steps
6345 (CVS): change args: use ['branch'] for -r, remove ['files']
6346 (CVS.buildVC): fix revision/branch stuff
6347 (SVN): add revision stuff
6349 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6350 kwargs (except 'workdir') to avoid silent spelling errors
6351 (ShellCommand.__init__): same
6352 (Source): new base class for CVS/SVN/etc. Factor out everything
6353 common, add revision computation (perform the checkout with a -D
6354 DATE or -r REVISION that gets exactly the sources described by the
6355 last Change), overridable with step.alwaysUseLatest. Add patch
6356 handling (build.getSourceStamp can trigger the use of a base
6357 revision and a patch).
6358 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6359 * docs/steps.xhtml: update docs
6360 * docs/source.xhtml: mention .checkoutDelay
6361 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6363 * buildbot/process/base.py (Build.setSourceStamp): add a
6364 .sourceStamp attribute to each Build. If set, this indicates that
6365 the build should be done with something other than the most
6366 recent source tree. This will be used to implement "try" builds.
6367 (Build.allChanges): new support method
6368 (Build.lastChangeTime): remove, functionality moved to Source steps
6369 (Build.setupBuild): copy the Step args before adding ['workdir'],
6370 to avoid modifying the BuildFactory (and thus triggering spurious
6374 * buildbot/status/html.py: rename s/commits/changes/
6375 (StatusResourceChanges): same
6376 (CommitBox.getBox): same, update URL
6377 (WaterfallStatusResource): same
6378 (StatusResource.getChild): same
6380 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6381 * contrib/debug.glade: add optional 'revision' to the fakeChange
6383 * buildbot/changes/changes.py (html_tmpl): display .revision
6384 (ChangeMaster.addChange): note .revision in log
6385 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6386 accept a ['revision'] attribute
6388 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6390 * buildbot/master.py (BotMaster.getPerspective): update the
6391 .connected flag in SlaveStatus when it connects
6392 (BotMaster.detach): and when it disconnects
6393 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6394 (BuildMaster.loadConfig_Builders): walk old list correctly
6396 * buildbot/test/test_config.py: fix prefix= usage
6398 2004-09-06 Brian Warner <warner@lothar.com>
6402 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6403 poll a P4 depot looking for recent changes. Thanks to Dave
6404 Peticolas for the contribution. Probably needs some testing after
6407 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6408 requires manual client setup for each buildslave. Rather
6409 experimental. Thanks again to Dave Peticolas.
6410 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6412 * buildbot/changes/changes.py (Change): add a .revision attribute,
6413 which will eventually be used to generate source-stamp values.
6415 * buildbot/process/step.py (RemoteCommand.start): use
6416 notifyOnDisconnect to notice when we lose the slave, then treat it
6417 like an exception. This allows LogFiles to be closed and the build
6418 to be wrapped up normally. Be sure to remove the disconnect
6419 notification when the step completes so we don't accumulate a
6420 bazillion such notifications which will fire weeks later (when the
6421 slave finally disconnects normally). Fixes SF#915807, thanks to
6422 spiv (Andrew Bennetts) for the report.
6423 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6424 really isn't Logged- specific
6425 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6426 header, since it's almost always going to be appended to an
6428 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6429 update test to handle use of notifyOnDisconnect
6431 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6432 don't clear .ETA and .currentBuild when going offline, let the
6433 current build clean up after itself
6435 * buildbot/process/builder.py (Builder.detached): wait a moment
6436 before doing things like stopping the current build, because the
6437 current step will probably notice the disconnect and cleanup the
6439 * buildbot/test/test_run.py (Status.tearDown): update test to
6440 handle asynchronous build-detachment
6442 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6444 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6445 hush a debug message
6447 2004-09-05 Brian Warner <warner@lothar.com>
6449 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6450 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6451 kernels do this: the fcntl module has the F_NOTIFY constant, but
6452 the kernel itself doesn't support the operation. Thanks to Olly
6453 Betts for spotting the problem.
6455 * buildbot/process/step.py (Darcs): new source-checkout command
6456 (Arch): new source-checkout command
6457 (todo_P4): fix constructor syntax, still just a placeholder
6458 * buildbot/test/test_vc.py (VC.testDarcs): test it
6459 (VC.testDarcsHTTP): same, via localhost HTTP
6461 (VC.testArchHTTP): same
6462 * NEWS: mention new features
6464 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6465 which tells the step to stash stdout text locally (in .stdout).
6466 Slave-side Commands can use this to make decisions based upon the
6467 output of the the ShellCommand (not just the exit code).
6468 (Darcs): New source-checkout command
6469 (Arch): New source-checkout command, uses .keepStdout in one place
6470 where it needs to discover the archive's default name.
6472 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6473 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6474 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6476 * buildbot/process/step.py (ShellCommand.describe): add an
6477 alternate .descriptionDone attribute which provides descriptive
6478 text when the step is complete. .description can be ["compiling"],
6479 for use while the step is running, then .descriptionDone can be
6480 ["compile"], used alone when the step succeeds or with "failed" when
6481 it does not. Updated other steps to use the new text.
6482 * buildbot/process/step_twisted.py: same
6483 * buildbot/test/test_run.py: update tests to match
6485 2004-08-30 Brian Warner <warner@lothar.com>
6487 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6488 (CVS.__init__): send 'patch' argument to slave
6489 (CVS.start): don't create the LoggedRemoteCommand until start(),
6490 so we can catch a .patch added after __init__
6491 (SVN.__init__): add 'patch' to SVN too
6494 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6495 argument, to let commands push data into the process' stdin pipe.
6496 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6497 is in use, since closing a PTY doesn't really affect the process
6498 in the right way (in particular, I couldn't run /usr/bin/patch
6500 (SourceBase.doPatch): handle 'patch' argument
6502 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6505 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6506 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6508 * buildbot/master.py (BotPerspective.got_commands): get command
6509 versions from slave, give to each builder
6510 * buildbot/process/builder.py (Builder.attached): stash slave
6511 command versions in .remoteCommands
6513 * docs/steps.xhtml: bring docs in-line with reality
6515 * buildbot/process/step.py (CVS.__init__): more brutal
6516 compatibility code removal
6517 (SVN.__init__): same
6519 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6520 (SlaveShellCommand.start): require ['workdir'] argument, remove
6521 the ['dir'] fallback (compatibility will come later)
6522 (SourceBase): update docs
6523 (SourceBase.start): remove ['directory'] fallback
6526 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6527 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6528 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6530 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6531 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6532 code.. I will figure out 0.5.0-compatibility hooks later)
6534 2004-08-30 Brian Warner <warner@lothar.com>
6536 * buildbot/process/process_twisted.py: rewrite in terms of new
6537 BuildFactory base class. It got significantly shorter. Yay
6540 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6541 work with the new "self.build isn't nailed down until we call
6542 step.start()" scheme: specifically, __init__ is called before the
6543 build has decided on which Changes are going in, so we don't scan
6544 build.allFiles() for .xhtml files until start()
6545 (HLint.commandComplete): use getText(), not getStdout()
6546 (RunUnitTests.start): same: don't use .build until start()
6547 (RunUnitTests.describe): oops, don't report (None) when using
6549 (RunUnitTests.commandComplete): use getText()
6550 (RunUnitTests.createSummary): same
6551 (BuildDebs.commandComplete): same
6553 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6554 set args['command'] until start(), since our BuildStep is allowed
6555 to change their mind up until that point
6556 (TreeSize.commandComplete): use getText(), not getStdout()
6558 * docs/examples/twisted_master.cfg: update to current standards
6560 * docs/factories.xhtml: update
6561 * buildbot/process/factory.py: implement all the common factories
6562 described in the docs. The Trial factory doesn't work yet, and
6563 I've probably broken all the process_twisted.py factories in the
6564 process. There are compatibility classes left in for things like
6565 the old BasicBuildFactory, but subclasses of them are unlikely to
6567 * docs/examples/glib_master.cfg: use new BuildFactories
6568 * docs/examples/hello.cfg: same
6570 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6571 explicit 'workdir' args
6573 * buildbot/process/base.py (BuildFactory): move factories to ..
6574 * buildbot/process/factory.py (BuildFactory): .. here
6575 * buildbot/process/process_twisted.py: handle move
6576 * buildbot/test/test_config.py: same
6577 * buildbot/test/test_run.py: same
6578 * buildbot/test/test_steps.py: same
6579 * buildbot/test/test_vc.py: same
6580 * docs/factories.xhtml: same
6582 * NEWS: mention config changes that require updating master.cfg
6584 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6585 argument to all steps that weren't given one already, pointing at
6586 the "build/" directory.
6588 * docs/examples/hello.cfg: remove explicit 'workdir' args
6590 * docs/factories.xhtml: document standard BuildFactory clases,
6591 including a bunch which are have not yet been written
6593 2004-08-29 Brian Warner <warner@lothar.com>
6595 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6596 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6597 buildbot.status.builder so they aren't quite so internal
6598 * buildbot/process/base.py, buildbot/process/builder.py: same
6599 * buildbot/process/maxq.py, buildbot/process/step.py: same
6600 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6601 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6602 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6604 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6605 to handle new getLogs()-returns-list behavior
6606 (StatusResourceBuildStep.getChild): same
6607 (StepBox.getBox): same
6608 (WaterfallStatusResource.phase0): same
6610 * docs/source.xhtml: document how Buildbot uses version-control
6611 systems (output side: how we get source trees)
6612 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6613 systems (input side: how we learn about Changes)
6615 * buildbot/master.py (Manhole): use ComparableMixin
6616 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6617 * buildbot/changes/mail.py (MaildirSource): same
6618 * buildbot/status/client.py (PBListener): same
6619 * buildbot/status/html.py (Waterfall): same
6620 * buildbot/status/words.py (IRC): same
6622 * NEWS: start describing new features
6624 * buildbot/status/mail.py (MailNotifier): finish implementation.
6625 The message body is still a bit sparse.
6626 * buildbot/test/test_status.py (Mail): test it
6628 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6629 and __hash__ methods I wind up adding everywhere. Specifically
6630 intended to support the buildbot config-file update scheme where
6631 we compare, say, the old list of IStatusTargets against the new
6632 one and don't touch something which shows up on both lists.
6633 * buildbot/test/test_util.py (Compare): test case for it
6635 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6636 return a list instead of a dict
6637 (IBuildStepStatus.getLogs): same. The idea is that steps create
6638 logs with vaguely unique names (although their uniqueness is not
6639 guaranteed). Thus a compilation step should create its sole
6640 logfile with the name 'compile', and contribute it to the
6641 BuildStatus. If a step has two logfiles, try to create them with
6642 different names (like 'test.log' and 'test.summary'), and only
6643 contribute the important ones to the overall BuildStatus.
6644 * buildbot/status/builder.py (Event.getLogs): same
6645 (BuildStepStatus): fix default .text and .results
6646 (BuildStepStatus.addLog): switch to list-like .getLogs()
6647 (BuildStepStatus.stepFinished): same
6648 (BuildStatus.text): fix default .text
6649 (BuildStatus.getLogs): temporary hack to return all logs (from all
6650 child BuildStepStatus objects). Needs to be fixed to only report
6651 the significant ones (as contributed by the steps themselves)
6652 * buildbot/test/test_run.py: handle list-like .getLogs()
6653 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6655 2004-08-28 Brian Warner <warner@lothar.com>
6657 * buildbot/process/builder.py (Builder.attached): serialize the
6658 attachment process, so the attach-watcher isn't called until the
6659 slave is really available. Add detached watchers too, which makes
6662 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6664 * buildbot/test/test_swap.py: remove dead code
6666 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6667 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6668 sort of as if the command being run exited with a -1. There may
6669 still be some holes in this scheme.
6670 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6671 -r option appears before the module list
6672 * buildbot/process/step.py (CVS): add 'revision' argument
6674 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6675 when sending updates or stepComplete messages to the master, since
6676 we don't currently care whether they arrive or not. When we revamp
6677 the master/slave protocol to really resume interrupted builds,
6678 this will need revisiting.
6679 (lostRemote): remove spurious print
6681 * buildbot/master.py (BotPerspective.attached): serialize the
6682 new-builder interrogation process, to make testing easier
6683 (BotMaster.waitUntilBuilderDetached): convenience function
6685 * buildbot/status/builder.py (BuilderStatus): prune old builds
6686 (BuildStatus.pruneSteps): .. and steps
6687 (BuildStepStatus.pruneLogs): .. and logs
6688 (BuilderStatus.getBuild): handle missing builds
6689 * buildbot/status/html.py (StatusResourceBuild.body): display build
6690 status in the per-build page
6691 (BuildBox.getBox): color finished builds in the per-build box
6693 2004-08-27 Brian Warner <warner@lothar.com>
6695 * buildbot/status/mail.py (MailNotifier): new notification class,
6698 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6699 variants of a common base class which handles all the mode= logic
6701 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6703 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6705 2004-08-26 Brian Warner <warner@lothar.com>
6707 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6710 * buildbot/test/test_run.py: update to new Logfile interface, new
6711 buildbot.slave modules
6712 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6714 * MANIFEST.in: new sample config file
6715 * docs/examples/hello.cfg: same
6717 * buildbot/process/step_twisted.py: remove dead import
6719 * buildbot/process/step.py (RemoteCommand.run): catch errors
6721 (RemoteCommand.remote_update): ignore updates that arrive after
6723 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6724 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6725 the responsibilities of the subclass's methods
6726 (BuildStep.failed): catch errors during failure processing
6727 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6728 (CVS): move to a mode= argument (described in docstring), rather
6729 than the ungainly clobber=/export=/copydir= combination.
6730 (SVN): add mode= functionality to SVN too
6731 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6733 * buildbot/process/base.py (Build.startNextStep): catch errors
6734 during s.startStep()
6736 * buildbot/clients/base.py: update to new PB client interface.
6737 gtkPanes is still broken
6739 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6740 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6741 * setup.py: add buildbot.slave module
6742 * buildbot/bb_tap.py: handle move
6743 * buildbot/slave/registry.py: place to register commands, w/versions
6744 * buildbot/slave/bot.py: major simplifications
6745 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6746 instead of a fixed table. Eventually this will make the slave more
6747 extensible. Use 'start' method on the command, not .startCommand.
6748 Fix unsafeTracebacks handling (I think).
6749 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6750 helper class with a .start method that returns a Deferred.
6751 SlaveShellCommand is the form reached by the buildmaster. Commands
6752 which use multiple ShellCommands can just chain them as Deferreds,
6753 with some helper methods in Command (_abandonOnFailure and
6754 _checkAbandoned) to bail on rc!=0.
6755 (CVSCommand): prefer new mode= argument
6756 (SVNFetch): add mode= argument
6758 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6759 put a useful reason string on the build
6761 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6762 core functionality into an IStatusLog object
6763 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6764 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6765 (StatusResourceBuild.body): use proper accessor methods
6766 * buildbot/status/client.py (RemoteLog): PB-access goes here
6767 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6768 which delivers log contents too
6769 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6770 * buildbot/status/event.py: remove old Logfile completely
6772 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6773 subscription interface for IStatusLog subscriptions just like all
6774 other the status subscriptions
6775 (IStatusReceiver.logChunk): method called on subscribers
6777 2004-08-24 Brian Warner <warner@lothar.com>
6779 * buildbot/process/builder.py (Builder._pong): oops, ping response
6780 includes a result (the implicit None returned by remote_print).
6781 Accept it so the _pong method handles the response correctly.
6783 2004-08-06 Brian Warner <warner@lothar.com>
6785 * buildbot/test/test_config.py: update IRC, PBListener tests
6787 * buildbot/status/client.py (StatusClientPerspective): total
6788 rewrite to match new IStatus interfaces. New subscription scheme.
6789 There are still a few optimizations to make (sending down extra
6790 information with event messages so the client doesn't have to do a
6791 round trip). The logfile-retrieval code is probably still broken.
6792 Moved the PB service into its own port, you can no longer share a
6793 TCP socket between a PBListener and, say, the slaveport (this
6794 should be fixed eventually).
6795 * buildbot/clients/base.py (Client): revamp to match. still needs
6796 a lot of work, but basic event reporting works fine. gtkPanes is
6799 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6800 instance talks to a single irc server. Threw out all the old
6801 multi-server handling code. Still need to add back in
6802 builder-control (i.e. "force build")
6804 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6805 more random text to the as-yet-unreachable per-step page
6807 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6808 rename to stepETAUpdate
6809 (BuildStatus.subscribe): add build-wide ETA updates
6810 (BuilderStatus.getState): remove more cruft
6811 (BuilderStatus.getCurrentBuild): remove more cruft
6812 (BuilderStatus.buildStarted): really handle tuple-subscription
6813 * buildbot/test/test_run.py (Status.testSlave): handle the
6814 stepETAUpdate rename
6816 * buildbot/master.py (BuildMaster): don't add a default
6817 StatusClientService. Don't add a default IrcStatusFactory. Both
6818 are now added through c['status'] in the config file. c['irc'] is
6819 accepted for backwards compatibility, the only quirk is you cannot
6820 use c['irc'] to specify IRC servers on ports other than 6667.
6822 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6823 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6824 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6825 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6828 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6829 the buildmaster to re-read its config file
6832 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6833 find out the port our server is running on
6834 (WebTest.test_webPathname_port): same
6836 * buildbot/test/test_config.py (testWebPortnum): test it
6837 (testWebPathname): ditto
6839 * docs/config.xhtml: document new c['status'] configuration option
6841 * buildbot/status/html.py (Waterfall): new top-level class which
6842 can be added to c['status']. This creates the Site as well as the
6843 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6844 reachable as .parent, for everything.
6846 * buildbot/master.py (Manhole): make it a normal service Child
6847 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6848 webPathname. It will eventually replace c['irc'] and the implicit
6849 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6850 in as (deprecated) backward compatibility hooks for now.
6853 * buildbot/process/builder.py (Builder.buildFinished): don't
6854 inform out builder_status about a finished build, as it finds out
6855 through its child BuildStatus object
6857 * buildbot/status/html.py: extensive revamp. Use adapters to make
6858 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6859 have both starting and finishing times and adjust the waterfall
6860 display accordingly, using spacers if necessary. Use SlaveStatus
6861 to get buildslave info.
6862 (StatusResourceBuildStep): new just-one-step resource, used to get
6863 logfiles. No actual href to it yet.
6865 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6866 the time being, until I get the file-naming scheme right
6868 * buildbot/status/builder.py (Event): clean started/finished names
6869 (BuildStatus.isFinished): .finished is not None is the right test
6870 (BuildStatus.buildStarted): track started/finished times ourselves
6871 (BuilderStatus.getSlave): provide access to SlaveStatus object
6872 (BuilderStatus.getLastFinishedBuild): all builds are now in
6873 .builds, even the currently-running one. Accomodate this change.
6874 (BuilderStatus.eventGenerator): new per-builder event generator.
6875 Returns BuildStepStatus and BuildStatus objects, since they can
6876 both be adapted as necessary.
6877 (BuilderStatus.addEvent): clean up started/finished attributes
6878 (BuilderStatus.startBuild,finishBuild): remove dead code
6879 (SlaveStatus): new object to provide ISlaveStatus
6881 * buildbot/process/step.py (ShellCommand.getColor): actually
6882 return the color instead of setting it ourselves
6883 (CVS.__init__): pull .timeout and .workdir options out of
6884 **kwargs, since BuildStep will ignore them. Without this neither
6885 will be sent to the slave correctly.
6886 (SVN.__init__): same
6888 * buildbot/process/builder.py (Builder): move flags to class-level
6890 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6891 SlaveStatus handle that
6893 * buildbot/process/base.py (Build.firstEvent): remove dead code
6894 (Build.stopBuild): bugfix
6896 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6898 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6899 (ChangeMaster.eventGenerator): yield Changes, since there are now
6900 Adapters to turn them into HTML boxes
6902 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6903 (BotPerspective.attached): feed a SlaveStatus object
6904 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6905 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6907 * buildbot/interfaces.py: API additions
6908 (ISlaveStatus): place to get slave status
6910 2004-08-04 Brian Warner <warner@lothar.com>
6912 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6913 the delay finishes, so the step is marked as SUCCESS
6915 * buildbot/test/test_run.py (Status.testSlave): cover more of
6916 IBuildStatus and IBuildStepStatus
6918 * buildbot/status/progress.py (StepProgress): move some flags to
6919 class-level attributes
6920 (StepProgress.remaining): if there are no other progress metrics
6921 to go by, fall back to elapsed time
6922 (StepProgress.setExpectations): take a dict of metrics instead of
6924 (BuildProgress.setExpectationsFrom): pull expectations from the
6925 Expectations, instead of having it push them to the BuildProgress
6926 (Expectations): move some flags to class-level attributes
6927 (Expectations.__init__): copy per-step times from the
6929 (Expectations.expectedBuildTime): new method for per-build ETA
6931 * buildbot/status/event.py (Logfile): move some flags to
6932 class-level attributes
6933 (Logfile.logProgressTo): better method name, let step set the
6934 progress axis name (instead of always being "output")
6936 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6937 times directly, rather than depending upon the (possibly missing)
6938 .progress object. Use 'None' to indicate "not started/finished
6940 (BuildStepStatus.getExpectations): oops, return the full list of
6942 (BuilderStatus._buildFinished): append finished builds to .builds
6944 * buildbot/process/step.py (BuildStep): add separate .useProgress
6945 flag, since empty .progressMetrics[] still implies that time is a
6947 (CVS): set up the cmd in __init__, instead of waiting for start()
6949 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6950 calculation, this will eventually turn into a proper sourceStamp
6951 (Build.setupBuild): tell the Progress to load from the Expectations,
6952 instead of having the Expectations stuff things into the Progress
6953 (Build.buildException): add a build-level errback to make sure the
6954 build's Deferred fires even in case of exceptions
6956 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6958 * buildbot/process/builder.py (Builder.forceBuild): convey the
6959 reason instead of creating a fake Change
6961 * docs/examples/twisted_master.cfg: update to match reality
6963 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6964 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6965 fix or remove broken/breaking tests
6967 * buildbot/status/event.py (Logfile.__len__): remove evil method
6969 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6970 missing .build, for test convenience
6972 * buildbot/process/step_twisted.py: import fixes
6974 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6976 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6977 .statusbag reference
6979 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6980 connection at shutdown, and stop it from reconnecting
6982 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6983 chase down remote-execution bugs
6985 * buildbot/process/step.py: more fixes, remove
6986 BuildStep.setStatus()
6987 * buildbot/status/builder.py: move setStatus() functionality into
6989 * buildbot/status/event.py: minor fixes
6991 2004-08-03 Brian Warner <warner@lothar.com>
6993 * buildbot/process/base.py, buildbot/process/builder.py
6994 * buildbot/process/step.py, buildbot/status/builder.py
6995 * buildbot/status/event.py, buildbot/test/test_run.py:
6996 fix status delivery, get a basic test case working
6997 * buildbot/master.py: finish implementing basic status delivery,
6998 temporarily disable HTML/IRC/PB status sources
7000 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
7002 * buildbot/status/progress.py (BuildProgress): remove dead code
7004 * buildbot/interfaces.py
7005 * buildbot/process/base.py, buildbot/process/builder.py
7006 * buildbot/process/step.py, buildbot/process/step_twisted.py
7007 * buildbot/status/builder.py: Complete overhaul of the all
7008 status-delivery code, unifying all types of status clients (HTML,
7009 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
7010 look like. This commit is a checkpointing of the work-in-progress:
7011 the input side is mostly done (Builders/Builds sending status
7012 to the BuilderStatus/BuildStatus objects), but the output side has
7013 not yet been started (HTML resources querying BuilderStatus
7014 objects). Things are probably very broken right now and may remain
7015 so for several weeks, I apologize for the disruption.
7017 * buildbot/status/event.py: add a setHTML method to use pre-rendered
7018 HTML as the log's contents. Currently used for exception tracebacks.
7019 * buildbot/status/progress.py: minor spelling changes
7021 2004-08-02 Brian Warner <warner@lothar.com>
7023 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
7024 in mozilla. Also added stylesheets copied from Twisted's docs.
7025 Remember that these files are meant to be run through Lore first.
7026 Thanks to Philipp Frauenfelder for the fixes.
7027 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
7028 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
7029 * docs/template.tpl: added a Lore template
7031 2004-07-29 Brian Warner <warner@lothar.com>
7033 * buildbot/interfaces.py: revamp status delivery. This is the
7034 preview: these are the Interfaces that will be provided by new
7035 Builder code, and to which the current HTML/IRC/PB status
7036 displayers will be adapted.
7038 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
7039 on the SlaveBuilder, not the Bot.
7040 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
7042 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
7043 set .usePTY on the FakeSlaveBuilder
7045 2004-07-25 Brian Warner <warner@lothar.com>
7047 * buildbot/changes/freshcvs.py: add some debug log messages
7048 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
7049 disabled 'setFilter' syntax
7050 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
7051 don't end with a slash
7053 * buildbot/process/base.py (Builder._pong_failed): add TODO note
7055 * setup.py: bump to 0.5.0+ while between releases
7057 2004-07-23 Brian Warner <warner@lothar.com>
7059 * setup.py (version): Releasing buildbot-0.5.0
7061 2004-07-23 Brian Warner <warner@lothar.com>
7063 * README: update for 0.5.0 release
7065 * NEWS: update for 0.5.0 release
7067 2004-07-22 Brian Warner <warner@lothar.com>
7069 * buildbot/slavecommand.py (ShellCommand): make usePTY a
7070 mktap-time configuration flag (--usepty=1, --usepty=0)
7071 * buildbot/bot.py: same
7073 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
7074 an 'info' directory being unwanted
7076 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
7077 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
7078 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
7079 and earlier), use a FreshCVSSourceOldcred instead.
7080 (test): simple test routine: connect to server, print changes
7082 * buildbot/changes/changes.py (Change.getTime): make it possible
7083 to print un-timestamped changes
7085 * buildbot/master.py (makeApp): delete ancient dead code
7086 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
7087 * buildbot/test/test_config.py (testFindConfigFile): test it
7089 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
7090 instead of win32 one
7093 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
7094 now takes a dictionary instead of a tuple. See docs/config.xhtml for
7097 * buildbot/process/base.py (Builder.__init__): change constructor
7098 to accept a dictionary of config data, rather than discrete
7099 name/slave/builddir/factory arguments
7101 * docs/examples/twisted_master.cfg: update to new syntax
7102 * docs/examples/glib_master.cfg: same
7103 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7104 rough tests of the new syntax
7107 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7108 to be an int, which means "run a web.distrib sub-server on a TCP
7109 port". This lets you publish the buildbot status page to a remote
7110 twisted.web server (using distrib.ResourceSubscription). Also
7111 rename the local attributes used to hold these web things so
7112 they're more in touch with reality.
7113 * buildbot/test/test_web.py: test webPortnum and webPathname
7114 * docs/config.xhtml: document this new use of webPathname
7116 * docs/config.xhtml: new document, slightly ahead of reality
7118 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7119 'prefix' handling: treat it as a simple string to check with
7120 .startswith, instead of treating it as a directory. This allows
7121 sub-directories to be used. If you use prefix=, you should give it
7122 a string that starts just below the CVSROOT and ends with a slash.
7123 This prefix will be stripped from all filenames, and filenames
7124 which do not start with it will be ignored.
7126 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7128 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7129 and --exclude (inverse of --include). SVN post-commit hooks
7130 now have total control over which changes get sent to buildbot and which
7133 2004-07-10 Brian Warner <warner@lothar.com>
7135 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7136 test case to match new API
7138 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7139 which crashed HTML display when self.entries=[] (needed to
7140 distinguish between [], which means "no entries yet", and None,
7141 which means "the entries have been swapped out to disk, go fetch
7144 2004-07-04 Brian Warner <warner@lothar.com>
7146 * buildbot/process/step_twisted.py (countFailedTests): Count
7147 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7148 10kb from the end because any import errors are wedged there and
7149 they would make us think the test log was unparseable.
7150 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7152 2004-06-26 Brian Warner <warner@lothar.com>
7154 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7155 delete-*.pyc command into an actual BuildStep, so we can label it
7157 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7158 (FullTwistedBuildFactory): same
7160 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7162 * contrib/fakechange.py: Add an errback when sending the fake
7163 change, so we know it didn't work.
7165 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7167 * buildbot/process/step_twisted.py: Delete *.pyc files before
7168 calling trial, so it doesn't catch any old .pyc files whose .py
7169 files have been moved or deleted.
7171 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7172 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7173 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7174 instead of ["twisted.test"], so that the end result is "trial -R
7177 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7178 regular expression to match filenames that should be ignored when
7179 changed. Also add a --revision parameter that specifies the
7180 revision to examine, which is useful for debugging.
7182 2004-06-25 Brian Warner <warner@lothar.com>
7184 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7185 summary of warnings (like DeprecationWarnings), next to the
7188 2004-05-13 Brian Warner <warner@lothar.com>
7190 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7191 we now have a w32 build slave courtesy of Mike Taylor.
7193 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7194 so broken. Fixed a race condition that tripped up interlocked
7195 builds and caused the status to be stuck at "Interlocked" forever.
7196 The twisted buildbot's one interlocked build just so happened to
7197 never hit this case until recently (the feeding builds both pass
7198 before the interlocked build is attempted.. usually it has to wait
7200 (Builder._pong_failed): fix method signature
7202 * setup.py: bump to 0.4.3+ while between releases
7204 2004-04-30 Brian Warner <warner@lothar.com>
7206 * setup.py (version): Releasing buildbot-0.4.3
7208 2004-04-30 Brian Warner <warner@lothar.com>
7210 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7212 * README: update for 0.4.3 release
7214 * NEWS: update for 0.4.3 release
7216 * buildbot/master.py (BuildMaster.__getstate__): make sure
7217 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7219 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7220 .trial as a class attribute, for upgrade from 0.4.2
7222 * buildbot/changes/changes.py (Change.links): add .links for
7225 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7226 .textWatchers and .htmlWatchers at save time, since they are both
7227 volatile, should allow smooth 0.4.2 upgrade
7229 * buildbot/process/step.py (CVS.finishStatus): catch failed
7230 CVS/SVN commands so we can make the status box red
7232 2004-04-29 Brian Warner <warner@lothar.com>
7234 * buildbot/changes/freshcvs.py
7235 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7236 code to do setFilter(), which tells the freshcvs daemon to not
7237 send us stuff that we're not interested in. I will uncomment it
7238 when a new version of CVSToys is available in which setFilter()
7239 actually works, and I get a chance to test it better.
7241 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7243 * buildbot/master.py (Dispatcher): use a registration scheme
7244 instead of hardwired service names
7245 (BuildMaster): keep track of the Dispatcher to support
7248 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7249 PBChangeSource class instead of having it be an undocumented
7250 internal feature of the ChangeMaster. Split out the code into a
7252 * buildbot/changes/pb.py (PBChangeSource): same
7253 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7255 * docs/{factories|sources|steps}.xhtml: document some pieces
7257 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7258 using FCMaildirSource
7259 (f23osx): update OS-X builder to use python2.3, since the slave
7260 was updated to Panther (10.3.3)
7262 2004-03-21 Brian Warner <warner@lothar.com>
7264 * buildbot/process/process_twisted.py: factor out doCheckout, change
7265 to use SVN instead of CVS
7267 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7268 an SVN subclass easier
7269 (BasicSVN): subclass which uses Subversion instead of CVS
7271 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7273 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7275 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7277 2004-02-25 Brian Warner <warner@lothar.com>
7279 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7280 is now either a list (which is passed to spawnProcess directly) or
7281 a string (which gets passed to /bin/sh -c). This removes the useSH
7282 flag and the ArgslistCommand class. Also send status header at the
7283 start and end of each command, instead of having the master-side
7285 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7286 -r'. Update to use list-based arguments.
7287 (SVNFetch): use list-based arguments, use ['dir'] argument to
7289 * buildbot/test/test_steps.py (Commands): match changes
7291 * buildbot/process/step.py (InternalShellCommand.words): handle
7293 (SVN): inherit from CVS, cleanup
7295 * buildbot/status/event.py (Logfile.content): render in HTML, with
7296 stderr in red and headers (like the name of the command we're
7297 about to run) in blue. Add link to a second URL (url + "?text=1")
7298 to get just stdout/stderr in text/plain without markup. There is
7299 still a problem with .entries=None causing a crash, it seems to occur
7300 when the logfile is read before it is finished.
7302 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7303 timeout to the keepalives, and use it to explicitly do a
7304 loseConnection instead of waiting for TCP to notice the loss. This
7305 ought to clear up the silent-lossage problem.
7306 (unsafeTracebacks): pass exception tracebacks back to the master,
7307 makes it much easier to debug problems
7309 2004-02-23 Brian Warner <warner@lothar.com>
7311 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7312 the whole command to /bin/sh instead of execve [Johan Dahlin]
7313 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7314 '-r HEAD' [Johan Dahlin]
7315 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7317 * buildbot/changes/changes.py (Change): add links= argument, add
7318 asHTML method [Johan Dahlin]. Modified to make a bit more
7319 XHTMLish. Still not sure how to best use links= .
7321 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7322 Change.asHTML to display the change, not asText
7324 * buildbot/status/html.py (StatusResourceBuilder): web button to
7327 * buildbot/test/test_run.py: test to actually start a buildmaster
7330 * MANIFEST.in: bring back accidentally-dropped test helper files
7332 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7333 that require cvstoys if it is not installed
7335 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7336 values of "bin/trial" [Dave Peticolas]
7337 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7338 tests passed" when we didn't happen to run any tests
7340 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7341 flunkOnFailure [Johan Dahlin]
7343 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7344 multiple instances of the same Step class by suffixing "_2", etc,
7345 to the name until it is unique. This name needs to be unique
7346 because it is used as a key in the dictionary that tracks build
7348 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7351 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7353 2004-01-14 Brian Warner <warner@lothar.com>
7355 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7356 kicked from a channel, log it
7358 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7359 something over whatever IRC channels the buildmaster is currently
7360 connected to. Added to try and track down a problem in which the
7361 master thinks it is still connected but the IRCd doesn't see it. I
7362 used a styles.Versioned this time, so hopefully users won't have
7363 to rebuild their .tap files this time.
7364 * contrib/debug.glade: add a "Poke IRC" button
7365 * contrib/debugclient.py: same
7367 * setup.py: bump to 0.4.2+ while between releases
7369 2004-01-08 Brian Warner <warner@lothar.com>
7371 * setup.py (version): Releasing buildbot-0.4.2
7373 2004-01-08 Brian Warner <warner@lothar.com>
7375 * NEWS: update for 0.4.2 release
7377 * README: document how to run the tests, now that they all pass
7379 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7381 * buildbot/process/step.py (CVS): add a global_options= argument,
7382 which lets you set CVS global options for the command like "-r"
7383 for read-only checkout, or "-R" to avoid writing in the
7385 * buildbot/slavecommand.py (CVSCommand): same
7387 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7388 testing easier (it is turned off when testing, to avoid the
7391 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7392 to make it easier to test: break generateStepID() out to a
7393 separate function, only update statusbag if it exists.
7394 (ShellCommands): create useful text for dict-based commands too.
7396 * test/*, buildbot/test/*: move unit tests under the buildbot/
7398 * setup.py (packages): install buildbot.test too
7400 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7401 * buildbot/test/test_steps.py: fix it, tests pass now
7403 2004-01-06 Brian Warner <warner@lothar.com>
7405 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7406 freshcvs mail uses a slightly different syntax for new
7407 directories. Update parser to handle either.
7408 * test/test_mailparse.py (Test1.testMsg9): test for same
7410 2003-12-21 Brian Warner <warner@lothar.com>
7412 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7413 'warnOnWarnings' so that lintian errors mark the build orange
7415 2003-12-17 Brian Warner <warner@lothar.com>
7417 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7418 messages emitted by Bonsai, contributed by Stephen Davis.
7420 * test/*: moved all tests to use trial instead of unittest. Some
7421 still fail (test_steps, test_slavecommand, and test_process).
7423 * setup.py (version): bump to 0.4.1+ while between releases
7425 2003-12-09 Brian Warner <warner@lothar.com>
7427 * setup.py (version): Releasing buildbot-0.4.1
7429 2003-12-09 Brian Warner <warner@lothar.com>
7431 * NEWS: update for 0.4.1 release
7433 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7434 freebsd builder code a little bit
7436 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7437 don't try to compare attributes of different classes
7438 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7439 (MaildirSource.messageReceived): fix Change delivery
7441 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7442 into the config file's namespace before loading it, like the
7443 documentation claims it does
7444 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7445 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7446 daemon comes back online
7448 2003-12-08 Brian Warner <warner@lothar.com>
7450 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7451 so the example will work with online=0 as well
7453 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7454 fix the __implements__ line
7456 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7457 class a twisted.application.service.Service, use startService to
7460 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7461 directory fd instead of simple open(). I'm sure this used to work,
7462 but the current version of python refuses to open directories with
7465 2003-12-05 Brian Warner <warner@lothar.com>
7467 * setup.py (version): bump to 0.4.0+ while between releases
7469 2003-12-05 Brian Warner <warner@lothar.com>
7471 * setup.py (version): Releasing buildbot-0.4.0
7473 2003-12-05 Brian Warner <warner@lothar.com>
7475 * docs/examples/glib_master.cfg: replace old sample scripts with
7476 new-style config files
7477 * MANIFEST.in: include .cfg files in distribution tarball
7479 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7480 implement a dummy method to avoid the exception that occurs when
7481 freshcvs sends this to us.
7483 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7484 removed the method, as it broke reconnection. Apparently
7485 stopFactory is called each time the connection attempt fails. Must
7487 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7488 attribute before serialization, since without stopFactory the
7489 reconnect timer may still be active and they aren't serializable.
7491 * test/test_mailparse.py (ParseTest): test with 'self' argument
7493 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7494 argument, as these "functions" are invoked like methods from class
7495 attributes and therefore always get an instance as the first
7498 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7499 message: thanks to Stephen Davis for the catch
7501 2003-12-04 Brian Warner <warner@lothar.com>
7503 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7504 twisted's standard ReconnectingClientFactory. Handles both oldcred
7505 and newcred connections. Also has a bug-workaround for
7506 ReconnectingClientFactory serializing its connector when it
7509 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7510 pbutil. Replace makeApp stuff with proper newcred/mktap
7511 makeService(). Don't serialize Ephemerals on shutdown.
7513 * buildbot/changes/changes.py (ChangeMaster): make it a
7514 MultiService and add the sources as children, to get startService
7515 and stopService for free. This also gets rid of the .running flag.
7517 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7518 new pbutil, turn into a TCPClient at the same time (to get
7519 startService for free). Two variants exist: FreshCVSSourceOldcred
7520 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7521 yet, but when it does, we'll be ready).
7522 (FreshCVSSource.notify): handle paths which are empty after the
7523 prefix is stripped. This only happens when the top-level (prefix)
7524 directory is added, at the very beginning of a Repository's life.
7526 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7527 Now the only reconnecting code is in the factory where it belongs.
7528 (Builder.unsubscribe): unregister the disconnect callback when we
7529 delete the builder on command from the master (i.e. when the
7530 buildmaster is reconfigured and that builder goes away). This
7531 fixes a multiple-delete exception when the status client is shut
7533 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7536 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7537 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7539 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7541 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7542 a list of globs (ugh). The testdir will be searched for files
7543 named *.tests and run the tests in the order specified in each of
7544 those files. This allows for "dependancies" between tests to be
7547 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7548 argument to pass to run_maxq.py, instead of a glob.
7550 2003-10-17 Brian Warner <warner@lothar.com>
7552 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7553 files that live in the sandbox
7555 2003-10-15 Brian Warner <warner@lothar.com>
7557 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7558 spelling error in "docs" count-warnings output
7559 (HLint.start): stupid thinko meant .xhtml files were ignored
7561 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7562 tests now that cReactor is banished to the sandbox
7564 2003-10-10 Brian Warner <warner@lothar.com>
7566 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7567 scheme: now .xhtml are sources and .html are generated
7569 2003-10-08 Brian Warner <warner@lothar.com>
7571 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7572 we were ignoring the 'randomly' parameter.
7574 2003-10-01 Brian Warner <warner@lothar.com>
7576 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7577 posix, to kill sub-children of aborted slavecommands.
7579 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7580 Clean up initialization: lastBuildStatus remains None until the
7581 first build has been completed.
7583 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7584 None as a lastBuildStatus
7585 * buildbot/clients/gtkPanes.py: same
7587 * buildbot/status/client.py (StatusClientService): keep
7588 BuilderStatus objects in self.statusbags . These objects now live
7589 here in the StatusClientService and are referenced by the Builder
7590 object, rather than the other way around.
7591 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7592 * buildbot/process/base.py (Builder): same
7593 * test/test_config.py (ConfigTest.testBuilders): same
7595 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7596 an existing builder, leave the statusbag alone. This will preserve the
7599 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7600 hook. This will probably go away in favor of a class in upcoming
7603 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7604 serviceName from newcred FreshCVSNotifiee setup
7606 2003-09-29 Brian Warner <warner@lothar.com>
7608 * buildbot/process/process_twisted.py: switch to new reactor
7610 * docs/examples/twisted_master.cfg: same
7612 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7614 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7615 botmaster reference instead of the oldapp service lookup
7617 * buildbot/master.py (BuildMaster.__init__): give the
7618 StatusClientService a reference to the botmaster to make it easier to
7621 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7623 * buildbot/status/html.py (Box.td): escape hreffy things so you
7624 can have spaces in things like builder names
7625 (StatusResourceBuilder.body)
7626 (WaterfallStatusResource.body)
7627 (WaterfallStatusResource.body0): same
7629 2003-09-25 Brian Warner <warner@lothar.com>
7631 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7632 rearrange the builder list when adding or removing builders: keep
7633 them in the order the user requested.
7634 * test/test_config.py (ConfigTest.testBuilders): verify it
7636 * contrib/debug.glade: give the debug window a name
7638 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7639 now wait on multiple interlocks. Fix code relating to that.
7640 (Builder.checkInterlocks): same
7641 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7643 * buildbot/master.py (BuildMaster.loadConfig): move from
7644 deprecated pb.BrokerFactory to new pb.PBServerFactory
7645 * test/test_config.py (ConfigTest.testWebPathname): same
7647 * docs/examples/twisted_master.cfg: fix interlock declaration
7649 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7650 Interlocks to their Builders into interlock.py .
7651 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7653 * test/test_config.py (ConfigTest.testInterlocks): validate
7656 * buildbot/process/base.py (Builder.__init__): better comments
7657 * buildbot/process/interlock.py (Interlock.__repr__): same
7658 (Interlock.deactivate): add .active flag, move the code that
7659 attaches/detaches builders into the Interlock
7661 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7663 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7664 tests using the new run_maxq.py script, and reporting failures by
7667 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7668 tests, reporting their success or failure in a buildbot-friendly
7671 2003-09-24 Brian Warner <warner@lothar.com>
7673 * docs/examples/twisted_master.cfg: example of a new-style config
7674 file. This lives in the buildmaster base directory as
7677 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7678 button to make the master re-read its config file
7680 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7681 buildmaster configuration from a file. This file can be re-read
7682 later, and the buildmaster will update itself to match the new
7683 desired configuration. Also use new Twisted Application class.
7684 * test/Makefile, test/test_config.py: unit tests for same
7686 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7687 FreshCVSSources comparable, to support reload.
7688 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7690 * buildbot/process/base.py (Builder): make them comparable, make
7691 Interlocks easier to attach, to support reload. Handle
7692 re-attachment of remote slaves.
7693 * buildbot/process/interlock.py (Interlock): same
7695 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7696 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7697 buildmaster taps are now constructed with mktap.
7698 * buildbot/status/client.py (StatusClientService): same
7700 * buildbot/status/words.py: move to new Services, add support to
7701 connect to multiple networks, add reload support, allow nickname
7702 to be configured on a per-network basis
7704 2003-09-20 Brian Warner <warner@lothar.com>
7706 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7707 the freebsd builder, now that the machine has been upgraded and no
7708 longer has python2.2
7710 * setup.py (version): bump to 0.3.5+ while between releases
7712 2003-09-19 Brian Warner <warner@lothar.com>
7714 * setup.py (version): Releasing buildbot-0.3.5
7716 2003-09-19 Brian Warner <warner@lothar.com>
7718 * NEWS: add post-0.3.4 notes
7720 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7722 * MANIFEST.in: add contrib/*
7724 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7725 use a remote root now: cvs.twistedmatrix.com
7727 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7729 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7730 compatibility with old servers
7731 (FreshCVSSource.start): and provide a way to use it
7732 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7734 * docs/examples/twisted_master.py (twisted_app): update to new
7736 (twisted_app): listen on new ~buildbot socket
7737 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7739 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7740 to reduce cvs bandwidth (update instead of full checkout)
7742 2003-09-11 Brian Warner <warner@lothar.com>
7744 * contrib/fakechange.py: demo how to connect to the changemaster
7745 port. You can use this technique to submit changes to the
7746 buildmaster from source control systems that offer a hook to run a
7747 script when changes are committed.
7749 * contrib/debugclient.py: tool to connect to the debug port. You
7750 can use it to force builds, submit fake changes, and wiggle the
7753 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7754 'Dispatcher' realm to handle all the different kinds of
7755 connections and Perspectives: buildslaves, the changemaster port,
7756 the debug port, and the status client port. NewCredPerspectives
7757 now have .attached/.detached methods called with the remote 'mind'
7758 reference, much like old perspectives did. All the pb.Services
7759 turned into ordinary app.ApplicationServices .
7760 (DebugService): went away, DebugPerspectives are now created
7761 directly by the Dispatcher.
7762 (makeApp): changed interface a little bit
7764 * buildbot/changes/changes.py: newcred
7765 * buildbot/status/client.py: newcred
7767 * buildbot/clients/base.py: newcred client side changes
7768 * buildbot/bot.py: ditto
7770 * docs/examples/glib_master.py: handle new makeApp() interface
7771 * docs/examples/twisted_master.py: ditto
7773 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7774 base newcred Perspectives on. This should go away once Twisted
7775 itself provides something sensible.
7778 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7780 * contrib/svn_buildbot.py: A program that you can call from your
7781 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7782 when a change in an SVN repository has happened. See the top of
7783 the file for some minimal usage info.
7785 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7787 * buildbot/slavecommand.py (ArglistCommand): Add new
7788 ArglistCommand that takes an argument list rather than a string as
7789 a parameter. Using a st.split() for argv is very bad.
7791 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7792 update to a particular revision rather than always checking out
7793 (still not very smart about it, there may be cases where the
7794 checkout becomes inconsistent).
7796 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7798 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7799 SVN fetch support. It can checkout (not update!) a specified
7800 revision from a specified repository to a specified directory.
7802 * buildbot/status/progress.py (Expectations.update): Fix an
7803 obvious bug (apparently created by the change described in the
7804 previous ChangeLog message) by moving a check to *after* the
7805 variable it checks is defined.
7808 2003-09-08 Brian Warner <warner@lothar.com>
7810 * buildbot/status/progress.py (Expectations.update): hack to catch
7811 an exception TTimo sees: sometimes the update() method seems to
7812 get called before the step has actually finished, so the .stopTime
7813 is not set, so no totalTime() is available and we average None
7814 with the previous value. Catch this and just don't update the
7815 metrics, and emit a log message.
7817 2003-08-24 Brian Warner <warner@lothar.com>
7819 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7820 parameter to set copydir='original' in CVS commands.
7822 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7824 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7825 which tells the command to maintain a separate original-source CVS
7826 workspace. For each build, this workspace will be updated, then
7827 the tree copied into a new workdir. This reduces CVS bandwidth
7828 (from a full checkout to a mere update) while doubling the local
7829 disk usage (to keep two copies of the tree).
7831 2003-08-21 Brian Warner <warner@lothar.com>
7833 * buildbot/status/event.py (Logfile.addEntry): if the master web
7834 server dies while we're serving a page, request.write raises
7835 pb.DeadReferenceError . Catch this and treat it like a
7836 notifyFinish event by dropping the request.
7838 2003-08-18 Brian Warner <warner@lothar.com>
7840 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7841 (instead of blowing up) if a force-build command is given without
7844 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7845 don't blow up if there aren't yet any Changes in the list
7847 2003-08-02 Brian Warner <warner@lothar.com>
7849 * buildbot/bot.py (updateApplication): don't set the .tap name,
7850 since we shouldn't assume we own the whole .tap file
7852 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7853 'mktap buildbot' (without a subcommand) better
7855 2003-07-29 Brian Warner <warner@lothar.com>
7857 * buildbot/status/words.py
7858 (IrcStatusFactory.clientConnectionLost): when we lose the
7859 connection to the IRC server, schedule a reconnection attempt.
7861 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7862 use shutil.rmtree instead of forking off an "rm -rf" command.
7863 rmtree may take a while and will block until it finishes, so we
7864 use "rm -rf" if available.
7866 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7867 freebsd buildslave badly
7869 * setup.py (version): bump to 0.3.4+ while between releases
7871 2003-07-28 Brian Warner <warner@lothar.com>
7873 * setup.py (version): Releasing buildbot-0.3.4
7875 2003-07-28 Brian Warner <warner@lothar.com>
7877 * NEWS: update in preparation for release
7879 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7880 process.signalProcess instead of os.kill, to improve w32
7883 * docs/examples/twisted_master.py (twisted_app): turn off
7884 win32eventreactor: the tests hang the buildslave badly
7886 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7887 failed builds, since usually the failures are consistent
7889 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7890 add compileOpts/compileOpts2 to reactors build
7892 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7893 (twisted_app): use both default and win32eventreactor on w32 build.
7894 Use both default and kqreactor on freebsd build.
7896 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7897 add compileOpts2, which is put after the build_ext argument. w32
7898 needs "-c mingw32" here.
7900 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7901 touch .acqpath, it goes away in recent Twisted releases
7903 * docs/examples/twisted_master.py (twisted_app): use "python" for
7904 the w32 buildslave, not "python2.2"
7906 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7907 the directory exists.. should hush an exception under w32
7909 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7910 ProcessTerminated -provided values for signal and exitCode rather
7911 than parsing the unix status code directly. This should remove one
7912 more roadblock for a w32-hosted buildslave.
7914 * test/test_mailparse.py: add test cases for Syncmail parser
7916 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7917 temporary compatibility import. Note! Start importing
7918 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7920 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7922 2003-07-27 Brian Warner <warner@lothar.com>
7924 * NEWS: started adding new features
7926 * buildbot/changes/mail.py: start work on Syncmail parser, move
7927 mail sources into their own file
7929 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7930 as implementing IChangeSource
7931 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7933 * buildbot/interfaces.py: define the IChangeSource interface
7935 2003-07-26 Brian Warner <warner@lothar.com>
7937 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7939 2003-06-25 Brian Warner <warner@lothar.com>
7941 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7944 2003-06-17 Brian Warner <warner@lothar.com>
7946 * buildbot/status/words.py: clean up method usage to avoid error
7947 in silly IRC command
7948 (IrcStatusBot.emit_status): round off seconds display
7950 * buildbot/process/base.py (Build): delete the timer when saving
7951 to the .tap file, and restore it (if it should still be running)
7952 upon restore. This should fix the "next build in -34 seconds"
7953 messages that result when the master is restarted while builds are
7954 sitting in the .waiting slot. If the time for the build has
7955 already passed, start it very soon (in 1 second).
7957 * buildbot/status/words.py: more silly commands
7959 * README (REQUIREMENTS): add URLs to all required software
7961 * buildbot/status/words.py ('last'): mention results of, and time
7964 2003-05-28 Brian Warner <warner@lothar.com>
7966 * buildbot/status/words.py: add 'last' command
7967 (IrcStatusBot.emit_status): add current-small text to 'status' output
7969 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7970 (twisted_app): remove spaces from OS-X builder name
7972 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7973 * buildbot/status/words.py: IRC bot should actually be useful now
7975 2003-05-23 Brian Warner <warner@lothar.com>
7977 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7978 "slave information" from $(slavedir)/info/* . These files are
7979 maintained by the slave administrator, and describe the
7980 machine/environment that is hosting the slave. Information from
7981 them is put into the "Builder" HTML page. Still need to establish
7982 a set of well-known filenames and meanings for this data: at the
7983 moment, *all* info/* files are sent to the master, but only
7984 'admin' and 'host' are used on that end.
7985 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7986 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7987 * buildbot/master.py (BotPerspective.got_info): ditto
7989 2003-05-22 Brian Warner <warner@lothar.com>
7991 * setup.py (version): bump version to 0.3.3+ while between releases
7993 2003-05-21 Brian Warner <warner@lothar.com>
7995 * setup.py: Releasing buildbot-0.3.3
7997 2003-05-21 Brian Warner <warner@lothar.com>
7999 * NEWS: 0.3.3 news items
8001 * README: describe --keepalive and life behind a NAT box
8003 * buildbot/bot.py (Bot.connected): implement application-level
8004 keepalives to deal with NAT timeouts, turn them on with
8005 --keepalive option or when SO_KEEPALIVE doesn't work.
8007 * buildbot/master.py (BotPerspective): accept keepalives silently
8009 * buildbot/process/base.py (Build.buildException): CopiedFailures
8010 don't carry as much information as local ones, so don't try to
8011 create a big HTMLized version of them.
8013 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
8014 log file when step fails due to an exception, such as when the slave
8017 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
8018 --testmodule argument instead of grepping for test-case-name tags
8019 ourselves. Remove FindUnitTests code.
8020 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
8022 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
8024 2003-05-16 Brian Warner <warner@lothar.com>
8026 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
8027 argument to allow things like CFLAGS=-O0 to be passed without relying
8028 upon /bin/sh processing on the slave.
8030 * buildbot/process/step.py (InternalShellCommand.start): send
8032 * buildbot/slavecommand.py (ShellCommand.start): create argv with
8033 'split' instead of letting /bin/sh do it. This should also remove
8034 the need for /bin/sh on the buildslave, making it more likely to
8037 * buildbot/status/html.py: html-escape text in blamelist.
8038 Add "force build" button to the Builder page.
8040 * buildbot/process/step_twisted.py (countFailedTests): look at
8041 last 1000 characters for status line, as import errors can put it
8042 before the -200 point.
8044 2003-05-15 Brian Warner <warner@lothar.com>
8046 * docs/examples/twisted_master.py: use clobber=0 for remote builds
8048 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8049 make 'clobber' a parameter, so it is possible to have builds which
8050 do full tests but do a cvs update instead of hammering the CVS
8051 server with a full checkout each build
8053 * buildbot/process/step.py (InternalShellCommand): bump default
8054 timeout to 20 minutes
8056 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
8057 the master to trigger a build. Run it via manhole.
8059 * buildbot/master.py (BotPerspective.perspective_forceBuild):
8060 allow slaves to trigger any build that they host, to make life
8061 easier for slave admins who are testing out new build processes
8063 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8064 don't flunk cReactor or qtreactor on failure, since they fail alot
8065 these days. Do warnOnFailure instead.
8067 * buildbot/process/base.py: change Builder.buildable from a list
8068 into a single slot. When we don't have a slave, new builds (once
8069 they make it past the timeout) are now merged into an existing
8070 buildable one instead of being queued. With this change, a slave
8071 which has been away for a while doesn't get pounded with all the
8072 builds it missed, but instead just does a single build.
8074 2003-05-07 Brian Warner <warner@lothar.com>
8076 * setup.py (version): bump version to 0.3.2+ while between releases
8078 2003-05-07 Brian Warner <warner@lothar.com>
8080 * setup.py: Releasing buildbot-0.3.2
8082 2003-05-07 Brian Warner <warner@lothar.com>
8084 * setup.py: fix major packaging error: include subdirectories!
8086 * NEWS: add changes since last release
8088 * README (REQUIREMENTS): update twisted/python dependencies
8090 * buildbot/status/builder.py (Builder.startBuild): change
8091 BuildProcess API: now they should call startBuild/finishBuild
8092 instead of pushing firstEvent / setLastBuildStatus. Moving towards
8093 keeping a list of builds in the statusbag, to support other kinds of
8095 (Builder.addClient): send current-activity-small to new clients
8096 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
8099 * buildbot/status/client.py: drop RemoteReferences at shutdown
8101 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8103 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8104 more debug messages for remote status client
8106 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8107 (.stepFailed): only fire the Deferred once, even if both
8108 stepComplete and stepFailed are called. I think this can happen if
8109 an exception occurs at a weird time.
8111 * buildbot/status/words.py: work-in-progress: IRC status delivery
8113 2003-05-05 Brian Warner <warner@lothar.com>
8115 * docs/examples/twisted_master.py (twisted_app): hush internal
8116 python2.3 distutils deprecation warnings
8117 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8118 add compileOpts= argument which inserts extra args before the
8119 "setup.py build_ext" command. This can be used to give -Wignore
8120 warnings, to hush some internal python-2.3 deprecation messages.
8122 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8123 the ['twisted.test'] default test case to make it easier to change
8126 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8127 * buildbot/clients/gtkPanes.py: ditto
8129 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8130 arg to collapse RunUnitTestsRandomly into RunUnitTests
8131 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8132 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8134 * buildbot/status/html.py (StatusResource): shuffle Resources
8135 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8136 would serve the waterfall display, but the internal links were
8137 only valid on the trailing-slash version. The correct behavior is
8138 for the non-slashed one to serve a Redirect to the slashed one.
8139 This only shows up when the buildbot page is hanging off another
8140 server, like a Twisted-Web distributed server.
8142 * buildbot/status/event.py (Event, RemoteEvent): make Events
8143 pb.Cacheable, with RemoteEvent as the cached version. This removes
8144 a lot of explicit send-an-update code.
8145 * buildbot/status/builder.py (Builder): remove send-update code
8146 * buildbot/status/client.py (ClientBuilder): remove send-update
8147 code, and log errors that occur during callRemote (mostly to catch
8148 InsecureJelly exceptions)
8150 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8151 run Lore with the same python used in the rest of the build
8153 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8155 * buildbot/process/step_twisted.py (HLint): accept 'python'
8156 argument. Catch rc!=0 and mark the step as failed. This marks the
8157 build orange ("has warnings").
8158 (RunUnitTestsJelly): move out to step_twisted2.py
8160 * buildbot/util.py (ignoreStaleRefs): add utility function
8162 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8163 don't fake ETA object, it's too hard to get right
8165 2003-05-02 Brian Warner <warner@lothar.com>
8167 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8169 2003-05-01 Brian Warner <warner@lothar.com>
8171 * buildbot/status/html.py (StatusResource.body): oops, I was
8172 missing a <tr>, causing the waterfall page to be misrendered in
8173 everything except Galeon.
8175 2003-04-29 Brian Warner <warner@lothar.com>
8177 * docs/examples/twisted_master.py: make debuild use python-2.2
8178 explicitly, now that Twisted stopped supporting 2.1
8180 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8181 handle tuple results too. I keep forgetting this, which suggests
8182 it needs to be rethought.
8184 * setup.py (setup): bump version to 0.3.1+ while between releases
8186 2003-04-29 Brian Warner <warner@lothar.com>
8188 * setup.py: Releasing buildbot-0.3.1
8190 2003-04-29 Brian Warner <warner@lothar.com>
8192 * README (SUPPORT): add plea to send questions to the mailing list
8194 * NEWS, MANIFEST.in: add description of recent changes
8196 * docs/examples/twisted_master.py: add the code used to create the
8197 Twisted buildmaster, with passwords and such removed out to a
8200 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8201 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8202 buildmasters to not require CVSToys be installed.
8203 * README, docs/examples/glib_master: update to match the change
8205 * buildbot/clients/base.py, buildbot/bot.py,
8206 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8207 ReconnectingPB from CVSToys distribution to remove CVSToys
8208 dependency for build slaves and status clients. Buildmasters which
8209 use FreshCVSSources still require cvstoys be installed, of course.
8211 2003-04-25 Brian Warner <warner@lothar.com>
8213 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8214 runTestsRandomly arg to turn on trial -z
8216 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8217 experimental code to use trial's machine-parseable output to get
8218 more detailed test results. Still has some major issues.
8219 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8222 * buildbot/status/builder.py (Builder.setCurrentBuild):
8223 anticipating moving build history into statusbag, not used yet
8225 * buildbot/status/tests.py: code to centralize test results,
8226 doesn't work quite yet
8228 * buildbot/status/event.py (Event): use hasattr("setName") instead
8229 of isinstance for now.. need better long-term solution
8231 * buildbot/status/html.py: Remove old imports
8233 2003-04-24 Brian Warner <warner@lothar.com>
8235 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8236 ignore changes under doc/fun/ and sandbox/
8238 * buildbot/process/step_twisted.py: update pushEvent and friends.
8240 * buildbot/status/html.py (Box.td): replace event.buildername with
8241 event.parent.getSwappableName(). Needs more thought.
8243 * buildbot/status/builder.py (Builder): Replace pushEvent and
8244 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8245 Tell events they are being pruned with event.delete().
8247 * buildbot/process/base.py (Build): Remove Builder status-handling
8248 methods. s/pushEvent/setCurrentActivity/.
8250 * buildbot/process/step.py (BuildStep): clean up status delivery.
8251 Gouse builder.statusbag methods instead of intermediate builder
8252 methods. s/updateLastEvent/updateCurrentActivity/.
8253 s/finalizeLastEvent/finishCurrentActivity/. Use
8254 addFileToCurrentActivity for summaryFunction.
8256 * buildbot/status/event.py (Logfile): put data in a Swappable when
8258 (Event): add more setter methods. Remove .buildername, use .parent
8259 and getSwappableName instead (needs more thought).
8261 * buildbot/util.py (Swappable):
8262 * test/test_swap.py: don't bother setting filename at __init__
8263 time, do it later. Change setFilename args to take parent first,
8264 since it provides the most significant part of the filename.
8266 2003-04-23 Brian Warner <warner@lothar.com>
8268 * buildbot/status/event.py (Logfile.addEntry): append to previous
8271 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8272 anticipating Swappable
8273 (InternalShellCommand.remoteUpdate): split out various log-adding
8274 methods so subclasses can snarf stdout separately
8276 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8277 in anticipation of Swappable build logs
8278 (Builder.testsFinished): anticipating TestResults, still disabled
8280 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8283 * buildbot/status/event.py (Logfile): add (disabled) support for
8284 Swappable, not ready for use yet
8286 * buildbot/util.py (Swappable): object which is swapped out to
8287 disk after some period of no use.
8288 * test/test_swap.py: test buildbot.utils.Swappable
8290 2003-04-14 Brian Warner <warner@lothar.com>
8292 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8293 periodic-build timer. Set the .periodicBuildTime on a builder
8294 instance to some number of seconds to activate it.
8296 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8298 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8299 a way that survives result tuples
8301 2003-04-12 Brian Warner <warner@lothar.com>
8303 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8304 return a dict instead of a tuple: allow summarizers to provide
8305 multiple summaries if they want
8306 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8307 (debuildSummarizer): summarize lintian warnings/errors
8309 2003-04-10 Brian Warner <warner@lothar.com>
8311 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8313 2003-04-09 Brian Warner <warner@lothar.com>
8315 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8316 empty summaries: happens when the tests fail so hard they don't emit
8317 a parseable summary line.
8319 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8320 Allow summaryFunction to return None to indicate no summary should
8323 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8324 writing to stale HTTP requests: notice when they disconnect and
8325 remove the request from the list. Also add CacheToFile from
8326 moshez, will be used later.
8328 2003-04-08 Brian Warner <warner@lothar.com>
8330 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8331 should be an int, not a list of strings
8333 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8334 if we weren't actually connected
8336 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8337 to show the tail end of the trial text output
8339 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8340 hook to summarize the results of a ShellCommand
8342 2003-04-07 Brian Warner <warner@lothar.com>
8344 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8345 twisted test suite code into a single class.
8346 * buildbot/process/process_twisted.py: same
8348 2003-04-04 Brian Warner <warner@lothar.com>
8350 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8352 * README (SLAVE): document use of mktap to create slave .tap file
8353 (REQUIREMENTS): describe dependencies
8355 * buildbot/bb_tap.py, buildbot/plugins.tml:
8356 * buildbot/bot.py (updateApplication): Add mktap support for creating
8357 buildslave .tap files
8359 2003-03-28 Brian Warner <warner@lothar.com>
8361 * buildbot/process/step.py (InternalShellCommand.finished): handle
8362 new tuple result values (fix embarrasing bug that appeared during
8365 2003-03-27 Brian Warner <warner@lothar.com>
8367 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8370 2003-03-25 Brian Warner <warner@lothar.com>
8372 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8373 to overall build status
8374 * buildbot/clients/base.py (Builder): improve event printing
8375 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8376 instead of generic ShellCommand
8377 (Build): Add .stopBuild, use it when slave is detached
8379 * buildbot/process/step.py (Configure,Test): give the steps their
8380 own names and status strings
8382 * buildbot/status/html.py (StatusResource): add "show" argument,
8383 lets you limit the set of Builders being displayed.
8385 2003-03-20 Brian Warner <warner@lothar.com>
8387 * buildbot/process/basic.py: removed
8389 2003-03-19 Brian Warner <warner@lothar.com>
8391 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8392 turn off process-docs by default
8394 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8395 when displaying build information without anything in allBuilds[]
8397 * buildbot/bot.py (makeApp): really take password from sys.argv
8399 2003-03-18 Brian Warner <warner@lothar.com>
8401 * buildbot/bot.py (buildApp): take password from sys.argv
8403 * README: replace with more useful text
8405 * setup.py: add a real one
8406 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8408 * docs/PyCon-2003/: added sources for PyCon paper.
8410 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8411 now Build objects control the process and Builder only handles
8412 slave stuff and distribution of changes/status. A new BuildFactory
8413 class creates Build objects on demand.
8415 Created ConfigurableBuild which takes a list of steps to run. This
8416 makes it a lot easier to set up a new kind of build and moves us
8417 closer to being able to configure a build from a web page.
8419 * buildbot/process/step_twisted.py, process_twisted.py: move to
8420 new model. A lot of code went away.
8422 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8423 send lots of empty progress messages to the client.
8425 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8427 2003-02-20 Brian Warner <warner@lothar.com>
8429 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8431 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8432 Twisted bug that prevented non-pty processes from working just got
8433 fixed, and the bug that leaks ptys is still being investigated.
8435 * buildbot/process/step.py (CVS): send timeout arg to slave
8437 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8438 builders coming and going
8439 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8440 from CVSToys, handle lost-buildmaster
8442 * buildbot/status/client.py (StatusClientService.removeBuilder):
8443 Clean up status client protocol: send builders (with references)
8444 as they are created, rather than sending a list and requiring the
8445 client to figure out which ones are new.
8446 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8447 attempts to force a build on an unknown builder
8449 2003-02-19 Brian Warner <warner@lothar.com>
8451 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8452 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8453 Twisted stops leaking them.
8454 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8455 builder goes to an idle state.
8457 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8458 I figure out why CVS commands hang without them, and/or I fix the
8459 hung-command timeout
8461 2003-02-16 Brian Warner <warner@lothar.com>
8463 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8464 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8465 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8466 GenerateDocs now that they are prefixed with WARNING:.
8468 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8469 use manual href target instead of request.childLink
8471 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8472 display every second, but update the ETA every 5 seconds (or
8473 whenever) as remote_progress messages arrive.
8476 2003-02-12 Brian Warner <warner@lothar.com>
8478 * *: import current sources from home CVS repository
8482 # add-log-time-format: add-log-iso8601-time-string